[webkit-changes] [102321] trunk/Source/WebCore
Title: [102321] trunk/Source/WebCore
Revision 102321
Author hara...@chromium.org
Date 2011-12-08 00:20:25 -0800 (Thu, 08 Dec 2011)
Log Message
Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394
Reviewed by Adam Barth.
- Overview: Using the [Supplemental] IDL, this patch moves the attribute
declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).
- This patch changes the build flow of WebCore.gyp as follows:
Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
}
- This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:
In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.
This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:
- DerivedSources.make
- DerivedSources.pri
- GNUmakefile.am
- PlatformBlackBerry.cmake
- UseJSC.cmake
- UseV8.cmake
- WebCore.vcproj/MigrateScripts
- WebCore.vcproj/WebCore.vcproj
- bindings/gobject/GNUmakefile.am
- WebCore.gyp/WebCore.gyp
Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:
DOMWindowWebAudio.idl:
interface [
Supplemental=DOMWindow
] DOMWindowWebAudio {
attribute attr1;
attribute attr2;
};
DOMWindow.idl:
interface [
] DOMWindow {
attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;
};
Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:
- If a given build script supports the [Supplemental] IDL,
generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
- Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL
as normal attributes and instead ignores all attributes with the [Supplemental] IDL
(i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).
Tests: webaudio/*
* WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a /cygdrive/c/...-style path, it is converted to a C:\cygwin\...-style path by the cygpath command.
* WebCore.gypi: Added DOMWindowWebAudio.idl.
* bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
* page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
* webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in
[webkit-changes] [102322] trunk/LayoutTests
Title: [102322] trunk/LayoutTests Revision 102322 Author ba...@chromium.org Date 2011-12-08 00:48:36 -0800 (Thu, 08 Dec 2011) Log Message Unreviewed, remove duplicate test expectations. Patch by Kenichi Ishibashi ba...@chromium.org on 2011-12-08 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (102321 => 102322) --- trunk/LayoutTests/ChangeLog 2011-12-08 08:20:25 UTC (rev 102321) +++ trunk/LayoutTests/ChangeLog 2011-12-08 08:48:36 UTC (rev 102322) @@ -1,3 +1,9 @@ +2011-12-08 Kenichi Ishibashi ba...@chromium.org + +Unreviewed, remove duplicate test expectations. + +* platform/chromium/test_expectations.txt: + 2011-12-07 Yosifumi Inoue yo...@chromium.org CSS color gets adjusted for disabled input elements Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102321 => 102322) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-08 08:20:25 UTC (rev 102321) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-08 08:48:36 UTC (rev 102322) @@ -1289,9 +1289,7 @@ BUGCR23496 MAC : css2.1/t09-c5526c-display-00-e.html = IMAGE BUGCR23496 MAC : fast/block/basic/011.html = IMAGE BUGCR23496 MAC : fast/forms/001.html = IMAGE -BUGCR23496 MAC : fast/forms/basic-inputs.html = IMAGE BUGCR23496 MAC : fast/forms/checkbox-radio-onchange.html = IMAGE -BUGCR23496 MAC : fast/forms/file/file-input-disabled.html = IMAGE+TEXT BUGCR23496 MAC : fast/forms/form-element-geometry.html = IMAGE+TEXT BUGCR23496 MAC : fast/forms/formmove.html = IMAGE // Recently became crashy. See http://crbug.com/24721 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102325] trunk/LayoutTests
Title: [102325] trunk/LayoutTests Revision 102325 Author o...@webkit.org Date 2011-12-08 02:26:37 -0800 (Thu, 08 Dec 2011) Log Message [WK2] Unreviewed gardening. WebKitTestRunner needs layoutTestController.setEditingBehavior https://bugs.webkit.org/show_bug.cgi?id=42689 * platform/wk2/Skipped: Skip new failing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (102324 => 102325) --- trunk/LayoutTests/ChangeLog 2011-12-08 10:12:22 UTC (rev 102324) +++ trunk/LayoutTests/ChangeLog 2011-12-08 10:26:37 UTC (rev 102325) @@ -1,3 +1,12 @@ +2011-12-08 Csaba Osztrogonác o...@webkit.org + +[WK2] Unreviewed gardening. + +WebKitTestRunner needs layoutTestController.setEditingBehavior +https://bugs.webkit.org/show_bug.cgi?id=42689 + +* platform/wk2/Skipped: Skip new failing tests. + 2011-12-08 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r102323. Modified: trunk/LayoutTests/platform/wk2/Skipped (102324 => 102325) --- trunk/LayoutTests/platform/wk2/Skipped 2011-12-08 10:12:22 UTC (rev 102324) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-12-08 10:26:37 UTC (rev 102325) @@ -687,6 +687,13 @@ editing/selection/collapse-selection-in-bidi.html editing/selection/context-menu-text-selection.html editing/selection/directionality-after-undo-replace.html +editing/selection/move-by-word-visually-crash-test-4.html +editing/selection/move-by-word-visually-crash-test-3.html +editing/selection/move-left-right-by-word-mac.html +editing/selection/move-by-word-visually-crash-test-1.html +editing/selection/move-by-word-visually-crash-test-textarea.html +editing/selection/move-by-word-visually-crash-test-2.html +editing/selection/move-by-word-visually-textarea.html editing/selection/programmatic-selection-on-mac-is-directionless.html editing/execCommand/query-command-state.html editing/execCommand/query-text-alignment.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102326] trunk/LayoutTests
Title: [102326] trunk/LayoutTests Revision 102326 Author kbal...@webkit.org Date 2011-12-08 02:37:07 -0800 (Thu, 08 Dec 2011) Log Message Unreviewed gardening. Remove duplicated entries from skipped list. * platform/qt-5.0/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-5.0/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (102325 => 102326) --- trunk/LayoutTests/ChangeLog 2011-12-08 10:26:37 UTC (rev 102325) +++ trunk/LayoutTests/ChangeLog 2011-12-08 10:37:07 UTC (rev 102326) @@ -1,3 +1,11 @@ +2011-12-08 Balazs Kelemen kbal...@webkit.org + +Unreviewed gardening. + +Remove duplicated entries from skipped list. + +* platform/qt-5.0/Skipped: + 2011-12-08 Csaba Osztrogonác o...@webkit.org [WK2] Unreviewed gardening. Modified: trunk/LayoutTests/platform/qt-5.0/Skipped (102325 => 102326) --- trunk/LayoutTests/platform/qt-5.0/Skipped 2011-12-08 10:26:37 UTC (rev 102325) +++ trunk/LayoutTests/platform/qt-5.0/Skipped 2011-12-08 10:37:07 UTC (rev 102326) @@ -6933,10 +6933,6 @@ tables/mozilla_expected_failures/marvin/backgr_position-table-column.html tables/mozilla_expected_failures/marvin/backgr_position-table-row-group.html tables/mozilla_expected_failures/marvin/backgr_position-table-row.html -fast/forms/number/input-appearance-number-rtl.html -fast/forms/number/input-appearance-spinbutton-disabled-readonly.html -fast/forms/number/input-appearance-spinbutton-layer.html -fast/forms/number/spin-in-multi-column.html # crashing test fast/text/regional-indicator-symobls.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102327] trunk/LayoutTests
Title: [102327] trunk/LayoutTests Revision 102327 Author commit-qu...@webkit.org Date 2011-12-08 02:44:51 -0800 (Thu, 08 Dec 2011) Log Message Fix failed layout test, bufferedAmount-after-close-in-busy.html https://bugs.webkit.org/show_bug.cgi?id=73666 Originally the failed layout test use simple_wsh server side WebSocket handler. But this handler starts closing handshake after a while and it bring flakiness on the test. Now the test use echo_wsh instead of simple_wsh. It never perform server initiated closing handshake. Patch by Takashi Toyoshima toyos...@chromium.org on 2011-12-08 Reviewed by Kent Tamura. * http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html: * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (102326 => 102327) --- trunk/LayoutTests/ChangeLog 2011-12-08 10:37:07 UTC (rev 102326) +++ trunk/LayoutTests/ChangeLog 2011-12-08 10:44:51 UTC (rev 102327) @@ -1,3 +1,19 @@ +2011-12-08 Takashi Toyoshima toyos...@chromium.org + +Fix failed layout test, bufferedAmount-after-close-in-busy.html +https://bugs.webkit.org/show_bug.cgi?id=73666 + +Originally the failed layout test use simple_wsh server side WebSocket +handler. But this handler starts closing handshake after a while and +it bring flakiness on the test. +Now the test use echo_wsh instead of simple_wsh. It never perform +server initiated closing handshake. + +Reviewed by Kent Tamura. + +* http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html: +* platform/gtk/Skipped: + 2011-12-08 Balazs Kelemen kbal...@webkit.org Unreviewed gardening. Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html (102326 => 102327) --- trunk/LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html 2011-12-08 10:37:07 UTC (rev 102326) +++ trunk/LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html 2011-12-08 10:44:51 UTC (rev 102327) @@ -28,7 +28,7 @@ return builder.getBlob(); } -var ws = new WebSocket(ws://localhost:8880/websocket/tests/hybi/simple); +var ws = new WebSocket(ws://localhost:8880/websocket/tests/hybi/echo); var bufferedAmountBeforeClose = 0; var bufferedAmountAfterClose = 0; Modified: trunk/LayoutTests/platform/gtk/Skipped (102326 => 102327) --- trunk/LayoutTests/platform/gtk/Skipped 2011-12-08 10:37:07 UTC (rev 102326) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-12-08 10:44:51 UTC (rev 102327) @@ -1589,9 +1589,6 @@ fast/forms/number/spin-in-multi-column.html fast/forms/range/slider-in-multi-column.html -# https://bugs.webkit.org/show_bug.cgi?id=73666 -http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html - # https://bugs.webkit.org/show_bug.cgi?id=73583 fullscreen/video-controls-override.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102328] trunk/Source/WebCore
Title: [102328] trunk/Source/WebCore
Revision 102328
Author commit-qu...@webkit.org
Date 2011-12-08 02:46:32 -0800 (Thu, 08 Dec 2011)
Log Message
Refactoring: Editor::requestCheckingFor should take SpellCheckRequest object.
https://bugs.webkit.org/show_bug.cgi?id=74033
Patch by Shinya Kawanaka shin...@google.com on 2011-12-08
Reviewed by Hajime Morita.
SpellChecker::requestCheckingFor takes SpellCheckRequest object in order to make it easy to
pass necessary information to requestCheckingFor.
No new tests. Covered by existing tests.
* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
Uses the new interface.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
* editing/SpellChecker.cpp:
(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::~SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
Creates a new SpellCheckRequest object.
(WebCore::SpellChecker::requestCheckingFor):
Uses the new interface.
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h:
(WebCore::SpellCheckRequest::setSequence):
(WebCore::SpellCheckRequest::sequence):
(WebCore::SpellCheckRequest::checkingRange):
(WebCore::SpellCheckRequest::paragraphRange):
(WebCore::SpellCheckRequest::text):
(WebCore::SpellCheckRequest::mask):
(WebCore::SpellCheckRequest::rootEditableElement):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/SpellChecker.cpp
trunk/Source/WebCore/editing/SpellChecker.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (102327 => 102328)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 10:44:51 UTC (rev 102327)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 10:46:32 UTC (rev 102328)
@@ -1,3 +1,36 @@
+2011-12-08 Shinya Kawanaka shin...@google.com
+
+Refactoring: Editor::requestCheckingFor should take SpellCheckRequest object.
+https://bugs.webkit.org/show_bug.cgi?id=74033
+
+Reviewed by Hajime Morita.
+
+SpellChecker::requestCheckingFor takes SpellCheckRequest object in order to make it easy to
+pass necessary information to requestCheckingFor.
+
+No new tests. Covered by existing tests.
+
+* editing/Editor.cpp:
+(WebCore::Editor::replaceSelectionWithFragment):
+ Uses the new interface.
+(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
+* editing/SpellChecker.cpp:
+(WebCore::SpellCheckRequest::SpellCheckRequest):
+(WebCore::SpellCheckRequest::~SpellCheckRequest):
+(WebCore::SpellCheckRequest::create):
+ Creates a new SpellCheckRequest object.
+(WebCore::SpellChecker::requestCheckingFor):
+ Uses the new interface.
+(WebCore::SpellChecker::didCheck):
+* editing/SpellChecker.h:
+(WebCore::SpellCheckRequest::setSequence):
+(WebCore::SpellCheckRequest::sequence):
+(WebCore::SpellCheckRequest::checkingRange):
+(WebCore::SpellCheckRequest::paragraphRange):
+(WebCore::SpellCheckRequest::text):
+(WebCore::SpellCheckRequest::mask):
+(WebCore::SpellCheckRequest::rootEditableElement):
+
2011-12-08 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r102323.
Modified: trunk/Source/WebCore/editing/Editor.cpp (102327 => 102328)
--- trunk/Source/WebCore/editing/Editor.cpp 2011-12-08 10:44:51 UTC (rev 102327)
+++ trunk/Source/WebCore/editing/Editor.cpp 2011-12-08 10:46:32 UTC (rev 102328)
@@ -416,8 +416,8 @@
if (!nodeToCheck)
return;
-m_spellChecker-requestCheckingFor(resolveTextCheckingTypeMask(TextCheckingTypeSpelling | TextCheckingTypeGrammar),
-Range::create(m_frame-document(), firstPositionInNode(nodeToCheck), lastPositionInNode(nodeToCheck)));
+RefPtrRange rangeToCheck = Range::create(m_frame-document(), firstPositionInNode(nodeToCheck), lastPositionInNode(nodeToCheck));
+m_spellChecker-requestCheckingFor(SpellCheckRequest::create(resolveTextCheckingTypeMask(TextCheckingTypeSpelling | TextCheckingTypeGrammar), rangeToCheck, rangeToCheck));
}
void Editor::replaceSelectionWithText(const String text, bool selectReplacement, bool smartReplace)
@@ -2017,7 +2017,9 @@
bool asynchronous = m_frame m_frame-settings() m_frame-settings()-asynchronousSpellCheckingEnabled() !shouldShowCorrectionPanel;
if (asynchronous) {
-m_spellChecker-requestCheckingFor(resolveTextCheckingTypeMask(textCheckingOptions), paragraphToCheck.paragraphRange());
+// In asynchronous mode, we intentionally check paragraph-wide sentence.
+RefPtrRange paragraphRange = paragraphToCheck.paragraphRange();
+m_spellChecker-requestCheckingFor(SpellCheckRequest::create(resolveTextCheckingTypeMask(textCheckingOptions), paragraphRange, paragraphRange));
return;
}
Modified: trunk/Source/WebCore/editing/SpellChecker.cpp (102327 => 102328)
---
[webkit-changes] [102330] trunk/Source/WebCore
Title: [102330] trunk/Source/WebCore
Revision 102330
Author commit-qu...@webkit.org
Date 2011-12-08 03:24:31 -0800 (Thu, 08 Dec 2011)
Log Message
Unreviewed, rolling out r102321.
http://trac.webkit.org/changeset/102321
https://bugs.webkit.org/show_bug.cgi?id=74072
Breaks all Chromium clobbered builds (Requested by apavlov_
on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-12-08
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main):
* WebCore.gypi:
* bindings/scripts/generate-bindings.pl:
* page/DOMWindow.idl:
* webaudio/DOMWindowWebAudio.idl: Removed.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gyp/scripts/action_derivedsourcesallinone.py
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/bindings/scripts/generate-bindings.pl
trunk/Source/WebCore/page/DOMWindow.idl
Removed Paths
trunk/Source/WebCore/webaudio/DOMWindowWebAudio.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (102329 => 102330)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 11:09:24 UTC (rev 102329)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 11:24:31 UTC (rev 102330)
@@ -1,3 +1,20 @@
+2011-12-08 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r102321.
+http://trac.webkit.org/changeset/102321
+https://bugs.webkit.org/show_bug.cgi?id=74072
+
+Breaks all Chromium clobbered builds (Requested by apavlov_
+on #webkit).
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
+(main):
+* WebCore.gypi:
+* bindings/scripts/generate-bindings.pl:
+* page/DOMWindow.idl:
+* webaudio/DOMWindowWebAudio.idl: Removed.
+
2011-12-08 Shinya Kawanaka shin...@google.com
Refactoring: Editor::requestCheckingFor should take SpellCheckRequest object.
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (102329 => 102330)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-12-08 11:09:24 UTC (rev 102329)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-12-08 11:24:31 UTC (rev 102330)
@@ -446,48 +446,9 @@
]
},
{
- 'target_name': 'generate_supplemental_dependency',
- 'type': 'none',
- 'actions': [
- {
- 'action_name': 'generateSupplementalDependency',
- 'variables': {
-# Write sources into a file, so that the action command line won't
-# exceed OS limits.
-'idl_files_list': '|(idl_files_list.tmp @(bindings_idl_files))',
- },
- 'inputs': [
-'../bindings/scripts/resolve-supplemental.pl',
-'../bindings/scripts/IDLParser.pm',
-'(idl_files_list)',
-'!@(cat (idl_files_list))',
- ],
- 'outputs': [
-'(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
- ],
- 'action': [
-'perl',
-'-w',
-'-I../bindings/scripts',
-'../bindings/scripts/resolve-supplemental.pl',
-'--defines',
-'(feature_defines) LANGUAGE_JAVASCRIPT V8_BINDING',
-'--idlFilesList',
-'(idl_files_list)',
-'--supplementalDependencyFile',
-'(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
- ],
- 'message': 'Resolving [Supplemental=XXX] dependencies in all IDL files',
-}
- ]
-},
-{
'target_name': 'webcore_bindings_sources',
'type': 'none',
'hard_dependency': 1,
- 'dependencies': [
-'generate_supplemental_dependency',
- ],
'sources': [
# bison rule
'../css/CSSGrammar.y',
@@ -900,9 +861,15 @@
},
{
'action_name': 'derived_sources_all_in_one',
+ 'variables': {
+# Write sources into a file, so that the action command line won't
+# exceed OS limites.
+'idls_list_temp_file': '|(idls_list_temp_file.tmp @(bindings_idl_files))',
+ },
'inputs': [
'scripts/action_derivedsourcesallinone.py',
-'(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
+'(idls_list_temp_file)',
+'!@(cat (idls_list_temp_file))',
],
'outputs': [
'@(derived_sources_aggregate_files)',
@@ -910,7 +877,7 @@
'action': [
'python',
'scripts/action_derivedsourcesallinone.py',
-'(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
+'(idls_list_temp_file)',
'--',
'@(derived_sources_aggregate_files)',
],
@@ -963,7 +930,6 @@
'../bindings/scripts/IDLParser.pm',
'../bindings/scripts/IDLStructure.pm',
'../bindings/scripts/preprocessor.pm',
-
[webkit-changes] [102331] trunk/Source/WebKit2
Title: [102331] trunk/Source/WebKit2 Revision 102331 Author hausm...@webkit.org Date 2011-12-08 03:52:47 -0800 (Thu, 08 Dec 2011) Log Message 2011-12-08 Gopal Raghavan gopal.1.ragha...@nokia.com [Qt] cleanup qmlplugin https://bugs.webkit.org/show_bug.cgi?id=73834 Reviewed by Tor Arne Vestbø. Removed empty folder qmlplugin. Modified Paths trunk/Source/WebKit2/ChangeLog Removed Paths trunk/Source/WebKit2/UIProcess/API/qt/qmlplugin/ Diff Modified: trunk/Source/WebKit2/ChangeLog (102330 => 102331) --- trunk/Source/WebKit2/ChangeLog 2011-12-08 11:24:31 UTC (rev 102330) +++ trunk/Source/WebKit2/ChangeLog 2011-12-08 11:52:47 UTC (rev 102331) @@ -1,3 +1,14 @@ +2011-12-08 Gopal Raghavan gopal.1.ragha...@nokia.com + +[Qt] cleanup qmlplugin +https://bugs.webkit.org/show_bug.cgi?id=73834 + +Reviewed by Tor Arne Vestbø. + +Removed empty folder qmlplugin. + +* UIProcess/API/qt/qmlplugin: Removed. + 2011-12-08 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r102323. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102332] trunk/Tools
Title: [102332] trunk/Tools
Revision 102332
Author hara...@chromium.org
Date 2011-12-08 05:04:41 -0800 (Thu, 08 Dec 2011)
Log Message
Unreviewed, rolling out r102280.
http://trac.webkit.org/changeset/102280
https://bugs.webkit.org/show_bug.cgi?id=74031
Chromium/Windows build is broken
* Scripts/webkitdirs.pm:
(buildChromium):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (102331 => 102332)
--- trunk/Tools/ChangeLog 2011-12-08 11:52:47 UTC (rev 102331)
+++ trunk/Tools/ChangeLog 2011-12-08 13:04:41 UTC (rev 102332)
@@ -1,3 +1,14 @@
+2011-12-08 Kentaro Hara hara...@chromium.org
+
+Unreviewed, rolling out r102280.
+http://trac.webkit.org/changeset/102280
+https://bugs.webkit.org/show_bug.cgi?id=74031
+
+Chromium/Windows build is broken
+
+* Scripts/webkitdirs.pm:
+(buildChromium):
+
2011-12-08 Nayan Kumar K naya...@motorola.com
Adding myself to committers list.
Modified: trunk/Tools/Scripts/webkitdirs.pm (102331 => 102332)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-12-08 11:52:47 UTC (rev 102331)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-12-08 13:04:41 UTC (rev 102332)
@@ -2081,10 +2081,10 @@
my $result = 1;
if (isDarwin() !isChromiumAndroid() !isChromiumMacMake()) {
# Mac build - builds the root xcode project.
-$result = buildXCodeProject(Source/WebKit/chromium/All, $clean, -configuration, configuration(), @options);
+$result = buildXCodeProject(Source/WebKit/chromium/WebKit, $clean, -configuration, configuration(), @options);
} elsif (isCygwin() || isWindows()) {
# Windows build - builds the root visual studio solution.
-$result = buildChromiumVisualStudioProject(Source/WebKit/chromium/All.sln, $clean);
+$result = buildChromiumVisualStudioProject(Source/WebKit/chromium/WebKit.sln, $clean);
} elsif (isLinux() || isChromiumAndroid() || isChromiumMacMake) {
# Linux build - build using make.
$result = buildChromiumMakefile(all, $clean, @options);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102334] trunk/Source/WebKit2
Title: [102334] trunk/Source/WebKit2
Revision 102334
Author kenn...@webkit.org
Date 2011-12-08 06:27:14 -0800 (Thu, 08 Dec 2011)
Log Message
Upsteam the Qt changes to the EditorState https://bugs.webkit.org/show_bug.cgi?id=74080
Reviewed by Simon Hausmann.
We are not doing the serialization manually due to it not being a POD
structure anymore in the case of Qt.
* GNUmakefile.am:
* Shared/EditorState.h:
(WebKit::EditorState::EditorState):
* Target.pri:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
* win/WebKit2.vcproj:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/Shared/EditorState.h
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/win/WebKit2.vcproj
Added Paths
trunk/Source/WebKit2/Shared/EditorState.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (102333 => 102334)
--- trunk/Source/WebKit2/ChangeLog 2011-12-08 14:23:10 UTC (rev 102333)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-08 14:27:14 UTC (rev 102334)
@@ -1,3 +1,24 @@
+2011-12-08 Kenneth Rohde Christiansen kenn...@webkit.org
+
+Upsteam the Qt changes to the EditorState
+https://bugs.webkit.org/show_bug.cgi?id=74080
+
+Reviewed by Simon Hausmann.
+
+We are not doing the serialization manually due to it not being a POD
+structure anymore in the case of Qt.
+
+* GNUmakefile.am:
+* Shared/EditorState.h:
+(WebKit::EditorState::EditorState):
+* Target.pri:
+* WebKit2.xcodeproj/project.pbxproj:
+* WebProcess/WebCoreSupport/WebEditorClient.cpp:
+(WebKit::WebEditorClient::respondToChangedSelection):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::editorState):
+* win/WebKit2.vcproj:
+
2011-12-08 Gopal Raghavan gopal.1.ragha...@nokia.com
[Qt] cleanup qmlplugin
Modified: trunk/Source/WebKit2/GNUmakefile.am (102333 => 102334)
--- trunk/Source/WebKit2/GNUmakefile.am 2011-12-08 14:23:10 UTC (rev 102333)
+++ trunk/Source/WebKit2/GNUmakefile.am 2011-12-08 14:27:14 UTC (rev 102334)
@@ -307,6 +307,7 @@
Source/WebKit2/Shared/CoreIPCSupport/WebContextMessageKinds.h \
Source/WebKit2/Shared/CoreIPCSupport/WebPageProxyMessageKinds.h \
Source/WebKit2/Shared/DrawingAreaInfo.h \
+ Source/WebKit2/Shared/EditorState.cpp \
Source/WebKit2/Shared/EditorState.h \
Source/WebKit2/Shared/FontSmoothingLevel.h \
Source/WebKit2/Shared/cairo/LayerTreeContextCairo.cpp \
Added: trunk/Source/WebKit2/Shared/EditorState.cpp (0 => 102334)
--- trunk/Source/WebKit2/Shared/EditorState.cpp (rev 0)
+++ trunk/Source/WebKit2/Shared/EditorState.cpp 2011-12-08 14:27:14 UTC (rev 102334)
@@ -0,0 +1,108 @@
+/*
+ * Copyright (C) 2010, 2011 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include config.h
+#include EditorState.h
+
+#include Arguments.h
+#include WebCoreArgumentCoders.h
+
+namespace WebKit {
+
+void EditorState::encode(CoreIPC::ArgumentEncoder* encoder) const
+{
+encoder-encode(shouldIgnoreCompositionSelectionChange);
+encoder-encode(selectionIsNone);
+encoder-encode(selectionIsRange);
+encoder-encode(isContentEditable);
+encoder-encode(isContentRichlyEditable);
+encoder-encode(isInPasswordField);
+encoder-encode(hasComposition);
+
+#if PLATFORM(QT)
+encoder-encode(cursorPosition);
+
[webkit-changes] [102335] trunk/Tools
Title: [102335] trunk/Tools
Revision 102335
Author dpra...@chromium.org
Date 2011-12-08 06:50:55 -0800 (Thu, 08 Dec 2011)
Log Message
fix build-webkit --chromium after breakage in r102201
https://bugs.webkit.org/show_bug.cgi?id=74031
Reviewed by Tony Chang.
* Scripts/webkitdirs.pm:
(buildChromium):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (102334 => 102335)
--- trunk/Tools/ChangeLog 2011-12-08 14:27:14 UTC (rev 102334)
+++ trunk/Tools/ChangeLog 2011-12-08 14:50:55 UTC (rev 102335)
@@ -1,3 +1,13 @@
+2011-12-08 Dirk Pranke dpra...@chromium.org
+
+fix build-webkit --chromium after breakage in r102201
+https://bugs.webkit.org/show_bug.cgi?id=74031
+
+Reviewed by Tony Chang.
+
+* Scripts/webkitdirs.pm:
+(buildChromium):
+
2011-12-08 Kentaro Hara hara...@chromium.org
Unreviewed, rolling out r102280.
Modified: trunk/Tools/Scripts/webkitdirs.pm (102334 => 102335)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-12-08 14:27:14 UTC (rev 102334)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-12-08 14:50:55 UTC (rev 102335)
@@ -2081,10 +2081,10 @@
my $result = 1;
if (isDarwin() !isChromiumAndroid() !isChromiumMacMake()) {
# Mac build - builds the root xcode project.
-$result = buildXCodeProject(Source/WebKit/chromium/WebKit, $clean, -configuration, configuration(), @options);
+$result = buildXCodeProject(Source/WebKit/chromium/All, $clean, -configuration, configuration(), @options);
} elsif (isCygwin() || isWindows()) {
# Windows build - builds the root visual studio solution.
-$result = buildChromiumVisualStudioProject(Source/WebKit/chromium/WebKit.sln, $clean);
+$result = buildChromiumVisualStudioProject(Source/WebKit/chromium/All.sln, $clean);
} elsif (isLinux() || isChromiumAndroid() || isChromiumMacMake) {
# Linux build - build using make.
$result = buildChromiumMakefile(all, $clean, @options);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102336] trunk/Source/WebKit2
Title: [102336] trunk/Source/WebKit2
Revision 102336
Author jocelyn.turco...@nokia.com
Date 2011-12-08 07:29:13 -0800 (Thu, 08 Dec 2011)
Log Message
[Qt] Fix the memory leak of AC layer update message contents on the UI process.
https://bugs.webkit.org/show_bug.cgi?id=74012
Reviewed by Noam Rosenthal.
Since the messages didn't have a virtual destructor, the destructor
of child class members wouldn't be called and would cause the all tile
update buffers, contained in a QImage, to be leaked as well.
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeMessageToRenderer::~LayerTreeMessageToRenderer):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (102335 => 102336)
--- trunk/Source/WebKit2/ChangeLog 2011-12-08 14:50:55 UTC (rev 102335)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-08 15:29:13 UTC (rev 102336)
@@ -1,3 +1,17 @@
+2011-12-07 Jocelyn Turcotte jocelyn.turco...@nokia.com
+
+[Qt] Fix the memory leak of AC layer update message contents on the UI process.
+https://bugs.webkit.org/show_bug.cgi?id=74012
+
+Reviewed by Noam Rosenthal.
+
+Since the messages didn't have a virtual destructor, the destructor
+of child class members wouldn't be called and would cause the all tile
+update buffers, contained in a QImage, to be leaked as well.
+
+* UIProcess/qt/LayerTreeHostProxyQt.cpp:
+(WebKit::LayerTreeMessageToRenderer::~LayerTreeMessageToRenderer):
+
2011-12-08 Kenneth Rohde Christiansen kenn...@webkit.org
Upsteam the Qt changes to the EditorState
Modified: trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp (102335 => 102336)
--- trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp 2011-12-08 14:50:55 UTC (rev 102335)
+++ trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp 2011-12-08 15:29:13 UTC (rev 102336)
@@ -53,6 +53,7 @@
FlushLayerChanges,
SetRootLayer
};
+virtual ~LayerTreeMessageToRenderer() { }
virtual Type type() const = 0;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102337] trunk/Source/WebKit2
Title: [102337] trunk/Source/WebKit2
Revision 102337
Author hausm...@webkit.org
Date 2011-12-08 07:30:29 -0800 (Thu, 08 Dec 2011)
Log Message
REGRESSION(r101683): QQuickWebView doesn't work with OpenGL/ES 2.0
https://bugs.webkit.org/show_bug.cgi?id=74077
Reviewed by Kenneth Rohde Christiansen.
Replace Desktop OpenGL idiom of using gl_Vertex with a simple vertex attribute
that's tied to the same register 0 (by being the first in the array).
* UIProcess/API/qt/qquickwebpage.cpp:
(PageProxyMaterialShader::attributeNames): Define vertex attribute, which is
bound to register 0, which is the current vertex.
(PageProxyMaterialShader::vertexShader): Use the vertex attribute instead of the
built-in gl_Vertex, which is only present in Desktop GL.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (102336 => 102337)
--- trunk/Source/WebKit2/ChangeLog 2011-12-08 15:29:13 UTC (rev 102336)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-08 15:30:29 UTC (rev 102337)
@@ -1,3 +1,19 @@
+2011-12-08 Simon Hausmann simon.hausm...@nokia.com
+
+REGRESSION(r101683): QQuickWebView doesn't work with OpenGL/ES 2.0
+https://bugs.webkit.org/show_bug.cgi?id=74077
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Replace Desktop OpenGL idiom of using gl_Vertex with a simple vertex attribute
+that's tied to the same register 0 (by being the first in the array).
+
+* UIProcess/API/qt/qquickwebpage.cpp:
+(PageProxyMaterialShader::attributeNames): Define vertex attribute, which is
+bound to register 0, which is the current vertex.
+(PageProxyMaterialShader::vertexShader): Use the vertex attribute instead of the
+built-in gl_Vertex, which is only present in Desktop GL.
+
2011-12-07 Jocelyn Turcotte jocelyn.turco...@nokia.com
[Qt] Fix the memory leak of AC layer update message contents on the UI process.
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp (102336 => 102337)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp 2011-12-08 15:29:13 UTC (rev 102336)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp 2011-12-08 15:30:29 UTC (rev 102337)
@@ -226,7 +226,7 @@
virtual void updateState(const RenderState state, QSGMaterial* newMaterial, QSGMaterial* oldMaterial);
virtual char const* const* attributeNames() const
{
-static char const* const attr[] = { 0 };
+static char const* const attr[] = { vertex, 0 };
return attr;
}
@@ -234,7 +234,8 @@
// All real painting is gone by TextureMapper through LayerTreeHostProxy.
virtual const char* vertexShader() const
{
-return void main() { gl_Position = gl_Vertex; };
+return attribute highp vec4 vertex; \n
+ void main() { gl_Position = vertex; };
}
virtual const char* fragmentShader() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102338] trunk/Source/WebKit2
Title: [102338] trunk/Source/WebKit2
Revision 102338
Author jocelyn.turco...@nokia.com
Date 2011-12-08 07:32:37 -0800 (Thu, 08 Dec 2011)
Log Message
[Qt] Fix non-animated pinch-zoom scale commit.
https://bugs.webkit.org/show_bug.cgi?id=74007
Reviewed by Kenneth Rohde Christiansen.
The update deferrer object was only destroyed at the end of the animation
and wouldn't be if the pinch-zoom was ended within legal bounds.
This patch also makes sure that the deferrer isn't destroyed and re-created
once the animation is started if it was already there.
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
* UIProcess/qt/QtViewportInteractionEngine.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (102337 => 102338)
--- trunk/Source/WebKit2/ChangeLog 2011-12-08 15:30:29 UTC (rev 102337)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-08 15:32:37 UTC (rev 102338)
@@ -1,3 +1,22 @@
+2011-12-07 Jocelyn Turcotte jocelyn.turco...@nokia.com
+
+[Qt] Fix non-animated pinch-zoom scale commit.
+https://bugs.webkit.org/show_bug.cgi?id=74007
+
+Reviewed by Kenneth Rohde Christiansen.
+
+The update deferrer object was only destroyed at the end of the animation
+and wouldn't be if the pinch-zoom was ended within legal bounds.
+This patch also makes sure that the deferrer isn't destroyed and re-created
+once the animation is started if it was already there.
+
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
+(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
+(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
+(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
+* UIProcess/qt/QtViewportInteractionEngine.h:
+
2011-12-08 Simon Hausmann simon.hausm...@nokia.com
REGRESSION(r101683): QQuickWebView doesn't work with OpenGL/ES 2.0
Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp (102337 => 102338)
--- trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp 2011-12-08 15:30:29 UTC (rev 102337)
+++ trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp 2011-12-08 15:32:37 UTC (rev 102338)
@@ -181,11 +181,11 @@
m_content-setPos(- itemRect.topLeft() * itemScale);
}
-void QtViewportInteractionEngine::animateItemRectVisible(const QRectF itemRect)
+bool QtViewportInteractionEngine::animateItemRectVisible(const QRectF itemRect)
{
QRectF currentItemRectVisible = m_content-mapRectFromItem(m_viewport, m_viewport-boundingRect());
if (itemRect == currentItemRectVisible)
-return;
+return false;
m_scaleAnimation-setDuration(kScaleAnimationDurationMillis);
m_scaleAnimation-setEasingCurve(QEasingCurve::OutCubic);
@@ -194,13 +194,15 @@
m_scaleAnimation-setEndValue(itemRect);
m_scaleAnimation-start();
+return true;
}
void QtViewportInteractionEngine::scaleAnimationStateChanged(QAbstractAnimation::State newState, QAbstractAnimation::State /*oldState*/)
{
switch (newState) {
case QAbstractAnimation::Running:
-m_scaleUpdateDeferrer = adoptPtr(new ViewportUpdateDeferrer(this));
+if (!m_scaleUpdateDeferrer)
+m_scaleUpdateDeferrer = adoptPtr(new ViewportUpdateDeferrer(this));
break;
case QAbstractAnimation::Stopped:
m_scaleUpdateDeferrer.clear();
@@ -392,12 +394,12 @@
animateItemRectVisible(endVisibleContentRect);
}
-void QtViewportInteractionEngine::ensureContentWithinViewportBoundary(bool immediate)
+bool QtViewportInteractionEngine::ensureContentWithinViewportBoundary(bool immediate)
{
ASSERT(m_suspendCount);
if (scrollAnimationActive() || scaleAnimationActive())
-return;
+return false;
qreal currentCSSScale = cssScaleFromItem(m_content-scale());
@@ -413,10 +415,11 @@
QRectF endVisibleContentRect(endPosition / endItemScale, viewportRect.size() / endItemScale);
-if (immediate)
+if (immediate) {
setItemRectVisible(endVisibleContentRect);
-else
-animateItemRectVisible(endVisibleContentRect);
+return true;
+}
+return !animateItemRectVisible(endVisibleContentRect);
}
void QtViewportInteractionEngine::reset()
@@ -555,7 +558,9 @@
return;
m_pinchStartScale = -1;
-ensureContentWithinViewportBoundary();
+// Clear the update deferrer now if we're in our final position and there won't be any
[webkit-changes] [102339] trunk/Source/WebCore
Title: [102339] trunk/Source/WebCore
Revision 102339
Author commit-qu...@webkit.org
Date 2011-12-08 07:45:39 -0800 (Thu, 08 Dec 2011)
Log Message
Provide more specific error description for SocketStreamError.
https://bugs.webkit.org/show_bug.cgi?id=74066
Patch by Takashi Toyoshima toyos...@chromium.org on 2011-12-08
Reviewed by Martin Robinson.
No new tests because this change just improve error messages for unexpected failures.
* platform/network/soup/SocketStreamError.h: Add an argument for passing error description.
(WebCore::SocketStreamError::SocketStreamError):
* platform/network/soup/SocketStreamHandleSoup.cpp: Add error description for SocketStreamError.
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/SocketStreamError.h
trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (102338 => 102339)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 15:32:37 UTC (rev 102338)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 15:45:39 UTC (rev 102339)
@@ -1,3 +1,20 @@
+2011-12-08 Takashi Toyoshima toyos...@chromium.org
+
+Provide more specific error description for SocketStreamError.
+https://bugs.webkit.org/show_bug.cgi?id=74066
+
+Reviewed by Martin Robinson.
+
+No new tests because this change just improve error messages for unexpected failures.
+
+* platform/network/soup/SocketStreamError.h: Add an argument for passing error description.
+(WebCore::SocketStreamError::SocketStreamError):
+* platform/network/soup/SocketStreamHandleSoup.cpp: Add error description for SocketStreamError.
+(WebCore::SocketStreamHandle::connected):
+(WebCore::SocketStreamHandle::readBytes):
+(WebCore::SocketStreamHandle::platformSend):
+(WebCore::SocketStreamHandle::platformClose):
+
2011-12-08 Mihnea Ovidenie mih...@adobe.com
[CSSRegions][CSSOM] Implement NamedFlow interface
Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamError.h (102338 => 102339)
--- trunk/Source/WebCore/platform/network/soup/SocketStreamError.h 2011-12-08 15:32:37 UTC (rev 102338)
+++ trunk/Source/WebCore/platform/network/soup/SocketStreamError.h 2011-12-08 15:45:39 UTC (rev 102339)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -38,8 +38,8 @@
class SocketStreamError : public SocketStreamErrorBase {
public:
SocketStreamError() { }
-explicit SocketStreamError(int errorCode)
-: SocketStreamErrorBase(errorCode)
+explicit SocketStreamError(int errorCode, const gchar* description)
+: SocketStreamErrorBase(errorCode, String(), String(description))
{
}
Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp (102338 => 102339)
--- trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2011-12-08 15:32:37 UTC (rev 102338)
+++ trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2011-12-08 15:45:39 UTC (rev 102339)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -102,7 +102,7 @@
void SocketStreamHandle::connected(GSocketConnection* socketConnection, GError* error)
{
if (error) {
-m_client-didFailSocketStream(this, SocketStreamError(error-code));
+m_client-didFailSocketStream(this, SocketStreamError(error-code, error-message));
return;
}
@@ -125,7 +125,7 @@
void SocketStreamHandle::readBytes(signed long bytesRead, GError* error)
{
if (error) {
-m_client-didFailSocketStream(this, SocketStreamError(error-code));
+m_client-didFailSocketStream(this, SocketStreamError(error-code, error-message));
return;
}
@@ -155,15 +155,13 @@
int SocketStreamHandle::platformSend(const char* data, int length)
{
-if (!g_pollable_output_stream_is_writable(m_outputStream.get())) {
-beginWaitingForSocketWritability();
-return 0;
-}
-
GOwnPtrGError error;
gssize written = g_pollable_output_stream_write_nonblocking(m_outputStream.get(), data, length, 0, error.outPtr());
-if (error !g_error_matches(error.get(), G_IO_ERROR, G_IO_ERROR_WOULD_BLOCK)) {
-m_client-didFailSocketStream(this, SocketStreamError(error-code)); // FIXME: Provide a sensible
[webkit-changes] [102340] trunk
Title: [102340] trunk
Revision 102340
Author hausm...@webkit.org
Date 2011-12-08 07:46:47 -0800 (Thu, 08 Dec 2011)
Log Message
[Qt] WebKitTestRunner crashes with debug builds https://bugs.webkit.org/show_bug.cgi?id=74090
Reviewed by Tor Arne Vestbø.
Source/WebKit2:
Export private C++ API style platformInitialize function needed
by low-level WTR.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::platformInitialize):
* UIProcess/API/qt/qquickwebview_p.h:
Tools:
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
to ensure WTF/JSC threading is initialized.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (102339 => 102340)
--- trunk/Source/WebKit2/ChangeLog 2011-12-08 15:45:39 UTC (rev 102339)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-08 15:46:47 UTC (rev 102340)
@@ -1,3 +1,17 @@
+2011-12-08 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] WebKitTestRunner crashes with debug builds
+https://bugs.webkit.org/show_bug.cgi?id=74090
+
+Reviewed by Tor Arne Vestbø.
+
+Export private C++ API style platformInitialize function needed
+by low-level WTR.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebView::platformInitialize):
+* UIProcess/API/qt/qquickwebview_p.h:
+
2011-12-07 Jocelyn Turcotte jocelyn.turco...@nokia.com
[Qt] Fix non-animated pinch-zoom scale commit.
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (102339 => 102340)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2011-12-08 15:45:39 UTC (rev 102339)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2011-12-08 15:46:47 UTC (rev 102340)
@@ -31,6 +31,7 @@
#include qquickwebview_p_p.h
#include qwebpreferences_p_p.h
+#include _javascript_Core/InitializeThreading.h
#include QtDeclarative/QQuickCanvas
#include QtWidgets/QFileDialog
#include QtWidgets/QInputDialog
@@ -616,6 +617,12 @@
return new QQuickWebViewAttached(object);
}
+void QQuickWebView::platformInitialize()
+{
+JSC::initializeThreading();
+WTF::initializeMainThread();
+}
+
void QQuickWebView::geometryChanged(const QRectF newGeometry, const QRectF oldGeometry)
{
Q_D(QQuickWebView);
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h (102339 => 102340)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h 2011-12-08 15:45:39 UTC (rev 102339)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h 2011-12-08 15:46:47 UTC (rev 102340)
@@ -91,6 +91,8 @@
QQuickWebViewExperimental* experimental() const;
static QQuickWebViewAttached* qmlAttachedProperties(QObject*);
+static void platformInitialize(); // Only needed by WTR.
+
public Q_SLOTS:
void load(const QUrl);
void postMessage(const QString);
Modified: trunk/Tools/ChangeLog (102339 => 102340)
--- trunk/Tools/ChangeLog 2011-12-08 15:45:39 UTC (rev 102339)
+++ trunk/Tools/ChangeLog 2011-12-08 15:46:47 UTC (rev 102340)
@@ -1,3 +1,14 @@
+2011-12-08 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] WebKitTestRunner crashes with debug builds
+https://bugs.webkit.org/show_bug.cgi?id=74090
+
+Reviewed by Tor Arne Vestbø.
+
+* WebKitTestRunner/qt/TestControllerQt.cpp:
+(WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
+to ensure WTF/JSC threading is initialized.
+
2011-12-08 Dirk Pranke dpra...@chromium.org
fix build-webkit --chromium after breakage in r102201
Modified: trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp (102339 => 102340)
--- trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp 2011-12-08 15:45:39 UTC (rev 102339)
+++ trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp 2011-12-08 15:46:47 UTC (rev 102340)
@@ -35,6 +35,7 @@
#include QFileInfo
#include QLibrary
#include QObject
+#include qquickwebview_p.h
#include QtGlobal
#include wtf/Platform.h
#include wtf/text/WTFString.h
@@ -82,6 +83,7 @@
void TestController::platformInitialize()
{
+QQuickWebView::platformInitialize();
}
void TestController::platformRunUntil(bool, double timeout)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102341] trunk/Source/WebKit2
Title: [102341] trunk/Source/WebKit2
Revision 102341
Author hausm...@webkit.org
Date 2011-12-08 08:06:52 -0800 (Thu, 08 Dec 2011)
Log Message
REGRESSION(r102334): Various Qt WK2 layout tests crash
Reviewed by Tor Arne Vestbø.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState): Add missing null pointer check for the editable
element (scope) before calling innerText.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (102340 => 102341)
--- trunk/Source/WebKit2/ChangeLog 2011-12-08 15:46:47 UTC (rev 102340)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-08 16:06:52 UTC (rev 102341)
@@ -1,5 +1,15 @@
2011-12-08 Simon Hausmann simon.hausm...@nokia.com
+REGRESSION(r102334): Various Qt WK2 layout tests crash
+
+Reviewed by Tor Arne Vestbø.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::editorState): Add missing null pointer check for the editable
+element (scope) before calling innerText.
+
+2011-12-08 Simon Hausmann simon.hausm...@nokia.com
+
[Qt] WebKitTestRunner crashes with debug builds
https://bugs.webkit.org/show_bug.cgi?id=74090
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (102340 => 102341)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-12-08 15:46:47 UTC (rev 102340)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-12-08 16:06:52 UTC (rev 102341)
@@ -409,7 +409,7 @@
result.selectedText = range-text();
}
-if (result.isContentEditable !result.isInPasswordField) {
+if (scope result.isContentEditable !result.isInPasswordField) {
result.surroundingText = scope-innerText();
result.surroundingText.remove(result.compositionStart, result.compositionLength);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102342] trunk/Source/WebKit2
Title: [102342] trunk/Source/WebKit2
Revision 102342
Author commit-qu...@webkit.org
Date 2011-12-08 08:16:55 -0800 (Thu, 08 Dec 2011)
Log Message
[Qt] [WK2] Directly composited images doesn't render
https://bugs.webkit.org/show_bug.cgi?id=74058
Patch by Viatcheslav Ostapenko ostapenko.viatches...@nokia.com on 2011-12-08
Reviewed by Noam Rosenthal.
Attach image to WebGraphicsLayer even if layerTreeTileClient is not set
and create/assign remote image tiles later during sync.
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (102341 => 102342)
--- trunk/Source/WebKit2/ChangeLog 2011-12-08 16:06:52 UTC (rev 102341)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-08 16:16:55 UTC (rev 102342)
@@ -1,3 +1,18 @@
+2011-12-08 Viatcheslav Ostapenko ostapenko.viatches...@nokia.com
+
+[Qt] [WK2] Directly composited images doesn't render
+https://bugs.webkit.org/show_bug.cgi?id=74058
+
+Reviewed by Noam Rosenthal.
+
+Attach image to WebGraphicsLayer even if layerTreeTileClient is not set
+and create/assign remote image tiles later during sync.
+
+* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
+(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
+(WebCore::WebGraphicsLayer::setContentsToImage):
+(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
+
2011-12-08 Simon Hausmann simon.hausm...@nokia.com
REGRESSION(r102334): Various Qt WK2 layout tests crash
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp (102341 => 102342)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp 2011-12-08 16:06:52 UTC (rev 102341)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp 2011-12-08 16:16:55 UTC (rev 102342)
@@ -317,8 +317,9 @@
void WebGraphicsLayer::setContentsNeedsDisplay()
{
+RefPtrImage image = m_image;
setContentsToImage(0);
-setContentsToImage(m_image.get());
+setContentsToImage(image.get());
}
void WebGraphicsLayer::setContentsToImage(Image* image)
@@ -326,15 +327,20 @@
if (image == m_image)
return;
WebLayerTreeTileClient* client = layerTreeTileClient();
-if (!client)
-return;
+int64_t newID = 0;
+if (client) {
+// We adopt first, in case this is the same frame - that way we avoid destroying and recreating the image.
+newID = client-adoptImageBackingStore(image);
+client-releaseImageBackingStore(m_layerInfo.imageBackingStoreID);
+notifyChange();
+if (m_layerInfo.imageBackingStoreID newID == m_layerInfo.imageBackingStoreID)
+return;
+} else {
+// If client not set yet there should be no backing store ID.
+ASSERT(!m_layerInfo.imageBackingStoreID);
+notifyChange();
+}
-// We adopt first, in case this is the same frame - that way we avoid destroying and recreating the image.
-int64_t newID = client-adoptImageBackingStore(image);
-client-releaseImageBackingStore(m_layerInfo.imageBackingStoreID);
-notifyChange();
-if (newID == m_layerInfo.imageBackingStoreID)
-return;
m_layerInfo.imageBackingStoreID = newID;
m_image = image;
m_layerInfo.imageIsUpdated = true;
@@ -421,6 +427,9 @@
for (size_t i = 0; i children().size(); ++i)
m_layerInfo.children.append(toWebLayerID(children()[i]));
+if (m_layerInfo.imageIsUpdated m_image !m_layerInfo.imageBackingStoreID)
+m_layerInfo.imageBackingStoreID = layerTreeTileClient()-adoptImageBackingStore(m_image.get());
+
m_layerTreeTileClient-didSyncCompositingStateForLayer(m_layerInfo);
m_modified = false;
m_layerInfo.imageIsUpdated = false;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102343] trunk/LayoutTests
Title: [102343] trunk/LayoutTests Revision 102343 Author dmazz...@google.com Date 2011-12-08 08:36:39 -0800 (Thu, 08 Dec 2011) Log Message Unreviewed, skipping failing test platform/mac/accessibility/search-with-frames.html Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (102342 => 102343) --- trunk/LayoutTests/ChangeLog 2011-12-08 16:16:55 UTC (rev 102342) +++ trunk/LayoutTests/ChangeLog 2011-12-08 16:36:39 UTC (rev 102343) @@ -1,3 +1,12 @@ +2011-12-08 Dominic Mazzoni dmazz...@google.com + +Unreviewed, skipping failing test. +https://bugs.webkit.org/show_bug.cgi?id=74093 + +platform/mac/accessibility/search-with-frames.html crashes. + +* platform/mac/Skipped: + 2011-12-08 Mihnea Ovidenie mih...@adobe.com [CSSRegions][CSSOM] Implement NamedFlow interface Modified: trunk/LayoutTests/platform/mac/Skipped (102342 => 102343) --- trunk/LayoutTests/platform/mac/Skipped 2011-12-08 16:16:55 UTC (rev 102342) +++ trunk/LayoutTests/platform/mac/Skipped 2011-12-08 16:36:39 UTC (rev 102343) @@ -523,3 +523,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=73974 fast/canvas/webgl/canvas-2d-webgl-texture.html + +# https://bugs.webkit.org/show_bug.cgi?id=74093 +platform/mac/accessibility/search-with-frames.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102344] branches/safari-534.53-branch/Source/WebKit2
Title: [102344] branches/safari-534.53-branch/Source/WebKit2 Revision 102344 Author lforsch...@apple.com Date 2011-12-08 09:23:00 -0800 (Thu, 08 Dec 2011) Log Message Merged r99911. Modified Paths branches/safari-534.53-branch/Source/WebKit2/ChangeLog branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.h branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.mm branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h branches/safari-534.53-branch/Source/WebKit2/UIProcess/PageClient.h branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.h branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.messages.in branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/FindController.cpp branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/FindController.h branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: branches/safari-534.53-branch/Source/WebKit2/ChangeLog (102343 => 102344) --- branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-12-08 16:36:39 UTC (rev 102343) +++ branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-12-08 17:23:00 UTC (rev 102344) @@ -1,3 +1,59 @@ +2011-12-08 Lucas Forschler lforsch...@apple.com + +Merge 99911 + +2011-11-10 Beth Dakin bda...@apple.com + +https://bugs.webkit.org/show_bug.cgi?id=66584 +WebKit2's find bouncy looks blurry after dragging window onto 1.0 scale factor +display +-and corresponding- +rdar://problem/9987559 + +Reviewed by Anders Carlsson. + +The setFindIndicator message and various functions of the same name must all take +an additional parameter indicating whether or not setting the find indicator +should result in a bounce animation. This is because when the device scale factor +changes, if there is currently a find indicator, it must be re-set to a higher or +lower resolution version, but we don't want the bounce animation to happen again. +* UIProcess/API/mac/FindIndicatorWindow.h: +* UIProcess/API/mac/FindIndicatorWindow.mm: +(WebKit::FindIndicatorWindow::setFindIndicator): +* UIProcess/API/mac/PageClientImpl.h: +* UIProcess/API/mac/PageClientImpl.mm: +(WebKit::PageClientImpl::setFindIndicator): +* UIProcess/API/mac/WKView.mm: +(-[WKView _setFindIndicator:fadeOut:animate:]): +* UIProcess/API/mac/WKViewInternal.h: +* UIProcess/PageClient.h: +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::setFindIndicator): +* UIProcess/WebPageProxy.h: +* UIProcess/WebPageProxy.messages.in: + +New function FindController::isShowingOverlay() is used to determine if +FindController::deviceScaleFactorDidChange() needs to be called. +* WebProcess/WebPage/FindController.h: +(WebKit::FindController::isShowingOverlay): + +FindController::deviceScaleFactorDidChange() calls updateFindIndicator to re- +generate the bitmap at the appropriate scale factor, but tells it not to animate +this time. +(WebKit::FindController::deviceScaleFactorDidChange): + +updateFindIndicator() takes a new parameter indicating whether or not the +FindIndicator should animate. It defaults to true since the deviceScaleFactor +changing is the only case currently where we do not want it to animate. +* WebProcess/WebPage/FindController.cpp: +(WebKit::FindController::updateFindIndicator): +(WebKit::FindController::hideFindIndicator): + +Calls into FindController::deviceScaleFactorDidChange() when the scale factor has +changed and the find overlay is showing. +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::setDeviceScaleFactor): + 2011-12-07 Lucas Forschler lforsch...@apple.com Merge 99617 Modified: branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.h (102343 => 102344) --- branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.h 2011-12-08 16:36:39 UTC (rev 102343) +++ branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.h 2011-12-08 17:23:00 UTC (rev 102344) @@ -47,7 +47,7 @@ static PassOwnPtrFindIndicatorWindow create(WKView *); ~FindIndicatorWindow(); -void
[webkit-changes] [102345] branches/safari-534.53-branch/Source/WebKit2
Title: [102345] branches/safari-534.53-branch/Source/WebKit2
Revision 102345
Author lforsch...@apple.com
Date 2011-12-08 09:25:13 -0800 (Thu, 08 Dec 2011)
Log Message
Merged r99912.
Modified Paths
branches/safari-534.53-branch/Source/WebKit2/ChangeLog
branches/safari-534.53-branch/Source/WebKit2/UIProcess/win/WebView.cpp
branches/safari-534.53-branch/Source/WebKit2/UIProcess/win/WebView.h
Diff
Modified: branches/safari-534.53-branch/Source/WebKit2/ChangeLog (102344 => 102345)
--- branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-12-08 17:23:00 UTC (rev 102344)
+++ branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-12-08 17:25:13 UTC (rev 102345)
@@ -1,5 +1,17 @@
2011-12-08 Lucas Forschler lforsch...@apple.com
+Merge 99912
+
+2011-11-10 Beth Dakin bda...@apple.com
+
+Speculative build fix.
+
+* UIProcess/win/WebView.cpp:
+(WebKit::WebView::setFindIndicator):
+* UIProcess/win/WebView.h:
+
+2011-12-08 Lucas Forschler lforsch...@apple.com
+
Merge 99911
2011-11-10 Beth Dakin bda...@apple.com
Modified: branches/safari-534.53-branch/Source/WebKit2/UIProcess/win/WebView.cpp (102344 => 102345)
--- branches/safari-534.53-branch/Source/WebKit2/UIProcess/win/WebView.cpp 2011-12-08 17:23:00 UTC (rev 102344)
+++ branches/safari-534.53-branch/Source/WebKit2/UIProcess/win/WebView.cpp 2011-12-08 17:25:13 UTC (rev 102345)
@@ -1443,8 +1443,10 @@
return WebContextMenuProxyWin::create(m_window, page);
}
-void WebView::setFindIndicator(PassRefPtrFindIndicator prpFindIndicator, bool fadeOut)
+void WebView::setFindIndicator(PassRefPtrFindIndicator prpFindIndicator, bool fadeOut, bool animate)
{
+UNUSED_PARAM(animate);
+
if (!m_findIndicatorCallback)
return;
Modified: branches/safari-534.53-branch/Source/WebKit2/UIProcess/win/WebView.h (102344 => 102345)
--- branches/safari-534.53-branch/Source/WebKit2/UIProcess/win/WebView.h 2011-12-08 17:23:00 UTC (rev 102344)
+++ branches/safari-534.53-branch/Source/WebKit2/UIProcess/win/WebView.h 2011-12-08 17:25:13 UTC (rev 102345)
@@ -198,7 +198,7 @@
virtual void compositionSelectionChanged(bool);
virtual PassRefPtrWebPopupMenuProxy createPopupMenuProxy(WebPageProxy*);
virtual PassRefPtrWebContextMenuProxy createContextMenuProxy(WebPageProxy*);
-virtual void setFindIndicator(PassRefPtrFindIndicator, bool fadeOut);
+virtual void setFindIndicator(PassRefPtrFindIndicator, bool fadeOut, bool animate);
virtual void didInstallOrUninstallPageOverlay(bool);
#if USE(ACCELERATED_COMPOSITING)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102348] trunk/Tools
Title: [102348] trunk/Tools
Revision 102348
Author commit-qu...@webkit.org
Date 2011-12-08 10:38:53 -0800 (Thu, 08 Dec 2011)
Log Message
[Qt] Visualize mock points in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74074
Patch by Alexander Færøy alexander.fae...@nokia.com on 2011-12-08
Reviewed by Tor Arne Vestbø.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):
* MiniBrowser/qt/MiniBrowserApplication.h:
* MiniBrowser/qt/icons/touchpoint.png: Added.
* MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp
trunk/Tools/MiniBrowser/qt/BrowserWindow.h
trunk/Tools/MiniBrowser/qt/MiniBrowser.qrc
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.h
Added Paths
trunk/Tools/MiniBrowser/qt/icons/touchpoint.png
trunk/Tools/MiniBrowser/qt/qml/MockTouchPoint.qml
Diff
Modified: trunk/Tools/ChangeLog (102347 => 102348)
--- trunk/Tools/ChangeLog 2011-12-08 18:23:08 UTC (rev 102347)
+++ trunk/Tools/ChangeLog 2011-12-08 18:38:53 UTC (rev 102348)
@@ -1,3 +1,21 @@
+2011-12-08 Alexander Færøy alexander.fae...@nokia.com
+
+[Qt] Visualize mock points in the Qt MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=74074
+
+Reviewed by Tor Arne Vestbø.
+
+* MiniBrowser/qt/BrowserWindow.cpp:
+(BrowserWindow::updateVisualMockTouchPoints):
+* MiniBrowser/qt/BrowserWindow.h:
+* MiniBrowser/qt/MiniBrowser.qrc:
+* MiniBrowser/qt/MiniBrowserApplication.cpp:
+(MiniBrowserApplication::notify):
+(MiniBrowserApplication::sendTouchEvent):
+* MiniBrowser/qt/MiniBrowserApplication.h:
+* MiniBrowser/qt/icons/touchpoint.png: Added.
+* MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
+
2011-12-08 Simon Hausmann simon.hausm...@nokia.com
[Qt] WebKitTestRunner crashes with debug builds
Modified: trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp (102347 => 102348)
--- trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp 2011-12-08 18:23:08 UTC (rev 102347)
+++ trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp 2011-12-08 18:38:53 UTC (rev 102348)
@@ -34,6 +34,7 @@
#include QDeclarativeEngine
#include QDir
+#include QPointF
BrowserWindow::BrowserWindow(WindowOptions* options)
{
@@ -82,6 +83,30 @@
return window;
}
+void BrowserWindow::updateVisualMockTouchPoints(const QListQWindowSystemInterface::TouchPoint touchPoints)
+{
+foreach (const QWindowSystemInterface::TouchPoint touchPoint, touchPoints) {
+QString mockTouchPointIdentifier = QString(mockTouchPoint%1).arg(touchPoint.id);
+QQuickItem* mockTouchPointItem = rootObject()-findChildQQuickItem*(mockTouchPointIdentifier, Qt::FindDirectChildrenOnly);
+
+if (!mockTouchPointItem) {
+QDeclarativeComponent touchMockPointComponent(engine(), QUrl(qrc:/qml/MockTouchPoint.qml));
+mockTouchPointItem = qobject_castQQuickItem*(touchMockPointComponent.create());
+mockTouchPointItem-setObjectName(mockTouchPointIdentifier);
+mockTouchPointItem-setParent(rootObject());
+mockTouchPointItem-setParentItem(rootObject());
+}
+
+QPointF position = touchPoint.area.topLeft();
+position.rx() -= geometry().x();
+position.ry() -= geometry().y();
+
+mockTouchPointItem-setX(position.x());
+mockTouchPointItem-setY(position.y());
+mockTouchPointItem-setProperty(pressed, QVariant(touchPoint.state != Qt::TouchPointReleased));
+}
+}
+
void BrowserWindow::screenshot()
{
}
Modified: trunk/Tools/MiniBrowser/qt/BrowserWindow.h (102347 => 102348)
--- trunk/Tools/MiniBrowser/qt/BrowserWindow.h 2011-12-08 18:23:08 UTC (rev 102347)
+++ trunk/Tools/MiniBrowser/qt/BrowserWindow.h 2011-12-08 18:38:53 UTC (rev 102348)
@@ -44,6 +44,8 @@
void load(const QString url);
QQuickWebView* webView() const;
+void updateVisualMockTouchPoints(const QListQWindowSystemInterface::TouchPoint touchPoints);
+
public slots:
BrowserWindow* newWindow(const QString url = ""
Modified: trunk/Tools/MiniBrowser/qt/MiniBrowser.qrc (102347 => 102348)
--- trunk/Tools/MiniBrowser/qt/MiniBrowser.qrc 2011-12-08 18:23:08 UTC (rev 102347)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowser.qrc 2011-12-08 18:38:53 UTC (rev 102348)
@@ -4,7 +4,9 @@
fileicons/previous.png/file
fileicons/refresh.png/file
fileicons/stop.png/file
+fileicons/touchpoint.png/file
fileqml/BrowserWindow.qml/file
+fileqml/MockTouchPoint.qml/file
fileuseragentlist.txt/file
/qresource
/RCC
Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp (102347 => 102348)
---
[webkit-changes] [102349] trunk/Source/WebCore
Title: [102349] trunk/Source/WebCore
Revision 102349
Author kl...@webkit.org
Date 2011-12-08 10:50:41 -0800 (Thu, 08 Dec 2011)
Log Message
Remove EventListenerMap destructor.
http://webkit.org/b/74096
Reviewed by Darin Adler.
Let the compiler generate ~EventListenerMap(). We only needed it when the hash map
was managing raw pointers.
We're losing the no-iterators assertion from clear() by doing this, but that was
superfluous to begin with - we were just using it to avoid duplicating code.
* dom/EventListenerMap.cpp:
* dom/EventListenerMap.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventListenerMap.cpp
trunk/Source/WebCore/dom/EventListenerMap.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (102348 => 102349)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 18:38:53 UTC (rev 102348)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 18:50:41 UTC (rev 102349)
@@ -1,3 +1,19 @@
+2011-12-08 Andreas Kling kl...@webkit.org
+
+Remove EventListenerMap destructor.
+http://webkit.org/b/74096
+
+Reviewed by Darin Adler.
+
+Let the compiler generate ~EventListenerMap(). We only needed it when the hash map
+was managing raw pointers.
+
+We're losing the no-iterators assertion from clear() by doing this, but that was
+superfluous to begin with - we were just using it to avoid duplicating code.
+
+* dom/EventListenerMap.cpp:
+* dom/EventListenerMap.h:
+
2011-12-08 Takashi Toyoshima toyos...@chromium.org
Provide more specific error description for SocketStreamError.
Modified: trunk/Source/WebCore/dom/EventListenerMap.cpp (102348 => 102349)
--- trunk/Source/WebCore/dom/EventListenerMap.cpp 2011-12-08 18:38:53 UTC (rev 102348)
+++ trunk/Source/WebCore/dom/EventListenerMap.cpp 2011-12-08 18:50:41 UTC (rev 102349)
@@ -50,11 +50,6 @@
{
}
-EventListenerMap::~EventListenerMap()
-{
-clear();
-}
-
bool EventListenerMap::isEmpty() const
{
if (m_hashMap)
Modified: trunk/Source/WebCore/dom/EventListenerMap.h (102348 => 102349)
--- trunk/Source/WebCore/dom/EventListenerMap.h 2011-12-08 18:38:53 UTC (rev 102348)
+++ trunk/Source/WebCore/dom/EventListenerMap.h 2011-12-08 18:50:41 UTC (rev 102349)
@@ -47,7 +47,6 @@
class EventListenerMap {
public:
EventListenerMap();
-~EventListenerMap();
bool isEmpty() const;
bool contains(const AtomicString eventType) const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102350] trunk/LayoutTests
Title: [102350] trunk/LayoutTests
Revision 102350
Author commit-qu...@webkit.org
Date 2011-12-08 10:53:11 -0800 (Thu, 08 Dec 2011)
Log Message
Added a test for css number types problem.
It's testing the css number types parser, where 'px' defined like escape sequences (\70\78) or uppercase / lowercase.
https://bugs.webkit.org/show_bug.cgi?id=72007
Patch by Szilard Ledan ledan-muntean.szil...@stud.u-szeged.hu on 2011-12-08
Reviewed by Darin Adler.
* fast/css/parsing-css-number-types-expected.txt: Added.
* fast/css/parsing-css-number-types.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/css/parsing-css-number-types-expected.txt
trunk/LayoutTests/fast/css/parsing-css-number-types.html
Diff
Modified: trunk/LayoutTests/ChangeLog (102349 => 102350)
--- trunk/LayoutTests/ChangeLog 2011-12-08 18:50:41 UTC (rev 102349)
+++ trunk/LayoutTests/ChangeLog 2011-12-08 18:53:11 UTC (rev 102350)
@@ -1,3 +1,14 @@
+2011-12-08 Szilard Ledan ledan-muntean.szil...@stud.u-szeged.hu
+
+Added a test for css number types problem.
+It's testing the css number types parser, where 'px' defined like escape sequences (\70\78) or uppercase / lowercase.
+https://bugs.webkit.org/show_bug.cgi?id=72007
+
+Reviewed by Darin Adler.
+
+* fast/css/parsing-css-number-types-expected.txt: Added.
+* fast/css/parsing-css-number-types.html: Added.
+
2011-12-08 Tony Chang t...@chromium.org
[chromium] Rebaseline printing/width-overflow.html on Chromium Mac Leopard.
Added: trunk/LayoutTests/fast/css/parsing-css-number-types-expected.txt (0 => 102350)
--- trunk/LayoutTests/fast/css/parsing-css-number-types-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/parsing-css-number-types-expected.txt 2011-12-08 18:53:11 UTC (rev 102350)
@@ -0,0 +1,44 @@
+Test parsing of CSS number types.
+
+FAILURE
+
+Rules from the stylesheet:
+
+#a { font-size: 1em; }
+#b { }
+#c { }
+#d { }
+#e { font-size: 1rem; }
+#f { }
+#g { font-size: 16px; }
+#h { font-size: 16px; }
+#i { }
+#j { }
+#k { font-size: 1cm; }
+#l { }
+#m { font-size: 1in; }
+#n { font-size: 12pt; }
+#o { }
+#p { }
+#q { font-size: 100%; }
+Expected result:
+
+#a { font-size: 1em; }
+#b { font-size: 1em; }
+#c { font-size: 1em; }
+#d { font-size: 1em; }
+#e { font-size: 1rem; }
+#f { font-size: 1ex; }
+#g { font-size: 16px; }
+#h { font-size: 16px; }
+#i { font-size: 16px; }
+#j { font-size: 16px; }
+#k { font-size: 1cm; }
+#l { font-size: 1mm; }
+#m { font-size: 1in; }
+#n { font-size: 12pt; }
+#o { font-size: 16px; }
+#p { font-size: 1pc; }
+#q { font-size: 100%; }
+
+
Added: trunk/LayoutTests/fast/css/parsing-css-number-types.html (0 => 102350)
--- trunk/LayoutTests/fast/css/parsing-css-number-types.html (rev 0)
+++ trunk/LayoutTests/fast/css/parsing-css-number-types.html 2011-12-08 18:53:11 UTC (rev 102350)
@@ -0,0 +1,86 @@
+head
+style
+/* Base form of the rule: */
+/*em */ #a { font-size: 1em; }
+/*em */ #b { font-size: 1\65m; }
+/*em */ #c { font-size: 1\65\6D; }
+/*em */ #d { font-size: 1\65\6d; }
+/*rEm */ #e { font-size: 1rEm; } /* */
+/*Ex */ #f { font-size: 1\45x; }
+/*px */ #g { font-size: 16px; }
+/*Px */ #h { font-size: 16Px; }
+/*px */ #i { font-size: 16\70\78; }
+/*pX */ #j { font-size: 16\70 X; }
+/*Cm */ #k { font-size: 1Cm;}
+/*MM */ #l { font-size: 1M\4d;}
+/*In */ #m { font-size: 1In;}
+/*pt */ #n { font-size: 12pt; }
+/*pt */ #o { font-size: 16p\78; }
+/*PC */ #p { font-size: 1\70 C;}
+/*%*/ #q { font-size: 100%;}
+/*mS#r { pause: 2000mS; } */
+/*KhZ #s { pitch: 105KhZ; } */
+/style
+
+script
+
+function runTest()
+{
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var rules = document.styleSheets[0].cssRules;
+var text = ;
+for (var i = 0; i rules.length; i++) {
+text += rules.item(i).cssText;
+text += \n;
+}
+
+document.getElementById(result).appendChild(document.createTextNode(text));
+
+if (document.getElementById(result).firstChild.data ="" document.getElementById(expected).firstChild.data)
+document.getElementById(message).firstChild.data = ""
+else
+document.getElementById(message).firstChild.data = ""
+}
+
+/script
+
+/head
+
+body _onload_=runTest()
+
+pTest parsing of CSS number types./p
+
+p id=messageTEST DID NOT COMPLETE/p
+
+pRules from the stylesheet:/p
+
+pre id=result/pre
+
+pExpected result:/p
+
+pre id=expected#a { font-size: 1em; }
+#b { font-size: 1em; }
+#c { font-size: 1em; }
+#d { font-size: 1em; }
+#e { font-size: 1rem; }
+#f { font-size: 1ex; }
+#g { font-size: 16px; }
+#h { font-size: 16px; }
+#i { font-size: 16px; }
+#j { font-size: 16px; }
+#k { font-size: 1cm; }
+#l { font-size: 1mm; }
+#m { font-size: 1in; }
+#n { font-size: 12pt; }
+#o { font-size: 16px; }
+#p { font-size: 1pc; }
+#q { font-size: 100%; }
+!--#r { pause: 2000ms; }
+#s
[webkit-changes] [102351] trunk/Source/WebCore
Title: [102351] trunk/Source/WebCore
Revision 102351
Author commit-qu...@webkit.org
Date 2011-12-08 10:55:05 -0800 (Thu, 08 Dec 2011)
Log Message
Fixing support for static conditional overloaded functions.
https://bugs.webkit.org/show_bug.cgi?id=74068
Patch by Kaustubh Atrawalkar kaust...@motorola.com on 2011-12-08
Reviewed by Adam Barth.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Pushing static keyword after condition #if.
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::overloadedMethod1): Added newly generated bindings.
* bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
(webkit_dom_test_obj_overloaded_method1):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
* bindings/scripts/test/JS/JSTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
(-[DOMTestObj overloadedMethod1:]):
* bindings/scripts/test/TestObj.idl: Ditto.
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::ConfigureV8TestObjTemplate):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (102350 => 102351)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 18:53:11 UTC (rev 102350)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 18:55:05 UTC (rev 102351)
@@ -1,3 +1,33 @@
+2011-12-08 Kaustubh Atrawalkar kaust...@motorola.com
+
+Fixing support for static conditional overloaded functions.
+https://bugs.webkit.org/show_bug.cgi?id=74068
+
+Reviewed by Adam Barth.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation): Pushing static keyword after condition #if.
+* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
+(WebDOMTestObj::overloadedMethod1): Added newly generated bindings.
+* bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
+* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
+(webkit_dom_test_obj_overloaded_method1):
+* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
+* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
+(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
+(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
+(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
+* bindings/scripts/test/JS/JSTestObj.h: Ditto.
+* bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
+* bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
+(-[DOMTestObj overloadedMethod1:]):
+* bindings/scripts/test/TestObj.idl: Ditto.
+* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
+(WebCore::TestObjInternal::overloadedMethod11Callback):
+(WebCore::TestObjInternal::overloadedMethod12Callback):
+(WebCore::TestObjInternal::overloadedMethod1Callback):
+(WebCore::ConfigureV8TestObjTemplate):
+
2011-12-08 Andreas Kling kl...@webkit.org
Remove EventListenerMap destructor.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (102350 => 102351)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-12-08 18:53:11 UTC (rev 102350)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-12-08 18:55:05 UTC (rev 102351)
@@ -2071,6 +2071,13 @@
my $functionName = GetFunctionName($className, $function);
+my $conditional = $function-signature-extendedAttributes-{Conditional};
+if ($conditional) {
+my $conditionalString = $codeGenerator-GenerateConditionalStringFromAttributeValue($conditional);
+push(@implContent, #if ${conditionalString}\n);
+}
+
+
if (!$isCustom $isOverloaded) {
# Append a number to an overloaded method's name to make it unique:
$functionName = $functionName
[webkit-changes] [102355] trunk/Source/WebCore
Title: [102355] trunk/Source/WebCore
Revision 102355
Author bda...@apple.com
Date 2011-12-08 11:19:05 -0800 (Thu, 08 Dec 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=73348
REGRESSION: Assertion when loading a page with a scrollable RenderLayer
-and corresponding-
rdar://problem/10518918
Reviewed by Darin Adler.
The main problem here is that certain delegate calls into AppKit for overlay
scrollbars can cause AppKit to call back into WebKit looking for more information.
The assertion happens when WebKit tells AppKit that the scroll position has
changed during a layout, and AppKit immediately asks WebKit to convert some
coordinates, and WebKit asserts that you shouldn't do that while a layout is still
happening. It's still possible for AppKit to call this delegate method while a
layout is happening, and we should guard against that. This patch, however, does
not do that.
This change instead addresses the reason this assertion started happening much
more frequently recently, which is that it recently became true that
notifyPositionChanged() can be called when the position has not changed. To fix
the assertion AND the bug that that change was intended to fix, we can just make
sure that either the position OR the scroll origin has changed before calling
notifyPositionChanged().
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Call resetScrollOriginChanged() after the scroll instead of before so that we know
whether or not to call notifyPositionChanged().
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (102354 => 102355)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 19:16:14 UTC (rev 102354)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 19:19:05 UTC (rev 102355)
@@ -1,3 +1,36 @@
+2011-12-08 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=73348
+REGRESSION: Assertion when loading a page with a scrollable RenderLayer
+-and corresponding-
+rdar://problem/10518918
+
+Reviewed by Darin Adler.
+
+The main problem here is that certain delegate calls into AppKit for overlay
+scrollbars can cause AppKit to call back into WebKit looking for more information.
+The assertion happens when WebKit tells AppKit that the scroll position has
+changed during a layout, and AppKit immediately asks WebKit to convert some
+coordinates, and WebKit asserts that you shouldn't do that while a layout is still
+happening. It's still possible for AppKit to call this delegate method while a
+layout is happening, and we should guard against that. This patch, however, does
+not do that.
+
+This change instead addresses the reason this assertion started happening much
+more frequently recently, which is that it recently became true that
+notifyPositionChanged() can be called when the position has not changed. To fix
+the assertion AND the bug that that change was intended to fix, we can just make
+sure that either the position OR the scroll origin has changed before calling
+notifyPositionChanged().
+
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
+
+Call resetScrollOriginChanged() after the scroll instead of before so that we know
+whether or not to call notifyPositionChanged().
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::updateScrollbars):
+
2011-12-08 Kaustubh Atrawalkar kaust...@motorola.com
Fixing support for static conditional overloaded functions.
Modified: trunk/Source/WebCore/platform/ScrollView.cpp (102354 => 102355)
--- trunk/Source/WebCore/platform/ScrollView.cpp 2011-12-08 19:16:14 UTC (rev 102354)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2011-12-08 19:19:05 UTC (rev 102355)
@@ -591,8 +591,8 @@
IntPoint adjustedScrollPosition = adjustScrollPositionWithinRange(IntPoint(desiredOffset));
if (adjustedScrollPosition != scrollPosition() || scrollOriginChanged()) {
+ScrollableArea::scrollToOffsetWithoutAnimation(adjustedScrollPosition + IntSize(scrollOrigin().x(), scrollOrigin().y()));
resetScrollOriginChanged();
-ScrollableArea::scrollToOffsetWithoutAnimation(adjustedScrollPosition + IntSize(scrollOrigin().x(), scrollOrigin().y()));
}
// Make sure the scrollbar offsets are up to date.
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102354 => 102355)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-08 19:16:14 UTC (rev 102354)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-08 19:19:05 UTC (rev 102355)
@@ -668,6 +668,10 @@
[webkit-changes] [102356] trunk/Source/WebCore
Title: [102356] trunk/Source/WebCore
Revision 102356
Author senorbla...@chromium.org
Date 2011-12-08 11:25:47 -0800 (Thu, 08 Dec 2011)
Log Message
Add missing V8 bindings to get CSS_FILTERS to compile in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=74091
Reviewed by Kenneth Russell.
Will be covered by tests in css3/filters (when enabled).
* bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added.
(WebCore::V8WebKitCSSFilterValue::indexedPropertyGetter):
Modified Paths
trunk/Source/WebCore/ChangeLog
Added Paths
trunk/Source/WebCore/bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (102355 => 102356)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 19:19:05 UTC (rev 102355)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 19:25:47 UTC (rev 102356)
@@ -1,3 +1,15 @@
+2011-12-08 Stephen White senorbla...@chromium.org
+
+Add missing V8 bindings to get CSS_FILTERS to compile in Chromium.
+https://bugs.webkit.org/show_bug.cgi?id=74091
+
+Reviewed by Kenneth Russell.
+
+Will be covered by tests in css3/filters (when enabled).
+
+* bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added.
+(WebCore::V8WebKitCSSFilterValue::indexedPropertyGetter):
+
2011-12-08 Beth Dakin bda...@apple.com
https://bugs.webkit.org/show_bug.cgi?id=73348
Added: trunk/Source/WebCore/bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp (0 => 102356)
--- trunk/Source/WebCore/bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp (rev 0)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp 2011-12-08 19:25:47 UTC (rev 102356)
@@ -0,0 +1,45 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include config.h
+
+#if ENABLE(CSS_FILTERS)
+
+#include V8WebKitCSSFilterValue.h
+
+#include V8Binding.h
+#include WebKitCSSFilterValue.h
+
+namespace WebCore {
+
+v8::Handlev8::Value V8WebKitCSSFilterValue::indexedPropertyGetter(uint32_t index, const v8::AccessorInfo info)
+{
+INC_STATS(DOM.WebKitCSSFilterValue.IndexedPropertyGetter);
+WebKitCSSFilterValue* list = V8WebKitCSSFilterValue::toNative(info.Holder());
+return toV8(list-item(index));
+}
+
+} // namespace WebCore
+
+#endif
Property changes on: trunk/Source/WebCore/bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp
___
Added: svn:eol-style
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102357] trunk/Source/WebCore
Title: [102357] trunk/Source/WebCore Revision 102357 Author rn...@webkit.org Date 2011-12-08 11:32:17 -0800 (Thu, 08 Dec 2011) Log Message CompositeEditCommand should not be kept alive for undo and redo https://bugs.webkit.org/show_bug.cgi?id=64414 Reviewed by Enrica Casucci. This patch introduces EditCommandComposition that replaces CompositeEditCommand for undo and redo purposes. Furthermore, we now keep a list of commands instead of a tree of commands to unapply and reapply edit commands that composes an undoable action. Each top-level CompositeEditCommand holds a ref-pointer to EditCommandComposition, and applyCommandToComposite adds new SimpleEditCommands to the list. * editing/CompositeEditCommand.cpp: (WebCore::EditCommandComposition::create): (WebCore::EditCommandComposition::doApply): Never used. (WebCore::EditCommandComposition::doUnapply): (WebCore::EditCommandComposition::doReapply): (WebCore::EditCommandComposition::append): (WebCore::CompositeEditCommand::~CompositeEditCommand): Add an assertion to ensure we didn't create a composition for CompositeEditCommands that have parents. (WebCore::CompositeEditCommand::doUnapply): Never used. (WebCore::CompositeEditCommand::doReapply): Never used. (WebCore::CompositeEditCommand::ensureComposition): Creates and attaches a EditCommandComposition. (WebCore::CompositeEditCommand::applyCommandToComposite): Append a SimpleEditCommand to the composition. * editing/CompositeEditCommand.h: (WebCore::EditCommandComposition::EditCommandComposition): (WebCore::CompositeEditCommand::composition): (WebCore::toEditCommandComposition): (WebCore::toCompositeEditCommand): * editing/DeleteButtonController.cpp: Wrap RemoveNodeCommand in RemoveTargetCommand since top level commands are now required to be a CompositeEditCommand. (WebCore::RemoveTargetCommand::create): (WebCore::RemoveTargetCommand::RemoveTargetCommand): (WebCore::RemoveTargetCommand::doApply): (WebCore::DeleteButtonController::deleteTarget): * editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand): New constructor; used by EditCommandComposition. (WebCore::EditCommand::apply): Create a composition for a top-level command. (WebCore::EditCommand::unapply): Since we clear m_parent of SimpleEditCommand as soon as they are added to EditCommandComposition, we can't use isTopLevelCommand() to differentiate EditCommandComposition from SimpleEditCommand. Use isEditCommandComposition() instead. (WebCore::EditCommand::reapply): Ditto. (WebCore::compositionIfPossible): (WebCore::EditCommand::setStartingSelection): Update the starting selection of EditCommandComposition. (WebCore::EditCommand::setEndingSelection): Ditto. (WebCore::EditCommand::setParent): Accepts a null pointer in order to avoid keeping a stale pointer in m_parent inside SimpleEditCommand when CompositeEditCommand goes away. * editing/EditCommand.h: (WebCore::EditCommand::isSimpleEditCommand): (WebCore::EditCommand::isCompositeEditCommand): (WebCore::EditCommand::isEditCommandComposition): (WebCore::EditCommand::parent): (WebCore::toSimpleEditCommand): * editing/Editor.cpp: (WebCore::Editor::appliedEditing): Register a EditCommandComposition, instead of a CompositeEditCommand to the undo stack. (WebCore::Editor::unappliedEditing): Unapplied or reapplied commands are now always EditCommandComposition. (WebCore::Editor::reappliedEditing): * editing/Editor.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/CompositeEditCommand.cpp trunk/Source/WebCore/editing/CompositeEditCommand.h trunk/Source/WebCore/editing/DeleteButtonController.cpp trunk/Source/WebCore/editing/EditCommand.cpp trunk/Source/WebCore/editing/EditCommand.h trunk/Source/WebCore/editing/Editor.cpp trunk/Source/WebCore/editing/Editor.h Diff Modified: trunk/Source/WebCore/ChangeLog (102356 => 102357) --- trunk/Source/WebCore/ChangeLog 2011-12-08 19:25:47 UTC (rev 102356) +++ trunk/Source/WebCore/ChangeLog 2011-12-08 19:32:17 UTC (rev 102357) @@ -1,3 +1,70 @@ +2011-12-08 Ryosuke Niwa rn...@webkit.org + +CompositeEditCommand should not be kept alive for undo and redo +https://bugs.webkit.org/show_bug.cgi?id=64414 + +Reviewed by Enrica Casucci. + +This patch introduces EditCommandComposition that replaces CompositeEditCommand for +undo and redo purposes. Furthermore, we now keep a list of commands instead of a tree of commands +to unapply and reapply edit commands that composes an undoable action. + +Each top-level CompositeEditCommand holds a ref-pointer to EditCommandComposition, +and applyCommandToComposite adds new SimpleEditCommands to the list. + +* editing/CompositeEditCommand.cpp: +(WebCore::EditCommandComposition::create): +(WebCore::EditCommandComposition::doApply): Never used. +(WebCore::EditCommandComposition::doUnapply): +(WebCore::EditCommandComposition::doReapply): +
[webkit-changes] [102360] trunk/Source/WebCore
Title: [102360] trunk/Source/WebCore
Revision 102360
Author kl...@webkit.org
Date 2011-12-08 12:01:12 -0800 (Thu, 08 Dec 2011)
Log Message
Optimize RenderObject::containingBlock().
http://webkit.org/b/74109
Reviewed by David Hyatt.
When climbing the parent chain to locate the containing block-level element,
use !isRenderBlock() to reject renderers rather than checking against an arbitrary
list of non-block renderers and then rejecting anything that isn't a block anyway.
RenderObject::containingBlock() was very hot (2.0%) when scrolling on youtube.com.
This change takes it down to 1.0% (60% of which is RenderObject::isRenderBlock().)
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (102359 => 102360)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 19:39:57 UTC (rev 102359)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 20:01:12 UTC (rev 102360)
@@ -1,3 +1,20 @@
+2011-12-08 Andreas Kling kl...@webkit.org
+
+Optimize RenderObject::containingBlock().
+http://webkit.org/b/74109
+
+Reviewed by David Hyatt.
+
+When climbing the parent chain to locate the containing block-level element,
+use !isRenderBlock() to reject renderers rather than checking against an arbitrary
+list of non-block renderers and then rejecting anything that isn't a block anyway.
+
+RenderObject::containingBlock() was very hot (2.0%) when scrolling on youtube.com.
+This change takes it down to 1.0% (60% of which is RenderObject::isRenderBlock().)
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::containingBlock):
+
2011-12-08 Nayan Kumar K naya...@motorola.com
Define DEBUG_GL_COMMANDS only in debug builds.
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (102359 => 102360)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2011-12-08 19:39:57 UTC (rev 102359)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2011-12-08 20:01:12 UTC (rev 102360)
@@ -736,12 +736,7 @@
o = o-parent();
}
} else {
-while (o ((o-isInline() !o-isReplaced()) || o-isTableRow() || o-isTableSection()
- || o-isTableCol() || o-isFrameSet() || o-isMedia()
-#if ENABLE(SVG)
- || o-isSVGContainer() || o-isSVGRoot()
-#endif
- ))
+while (o ((o-isInline() !o-isReplaced()) || !o-isRenderBlock()))
o = o-parent();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102361] trunk/Source/WebKit/chromium
Title: [102361] trunk/Source/WebKit/chromium
Revision 102361
Author commit-qu...@webkit.org
Date 2011-12-08 12:11:57 -0800 (Thu, 08 Dec 2011)
Log Message
IndexedDB: WebKit API addition of IDBObjectStore.count() and IDBIndex.count()
https://bugs.webkit.org/show_bug.cgi?id=73685
Patch by Joshua Bell jsb...@chromium.org on 2011-12-08
Reviewed by Darin Fisher.
Implementation to follow - this just extends the WebKit API.
* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::count):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::count):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBIndex.h
trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (102360 => 102361)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-08 20:01:12 UTC (rev 102360)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-08 20:11:57 UTC (rev 102361)
@@ -1,3 +1,17 @@
+2011-12-08 Joshua Bell jsb...@chromium.org
+
+IndexedDB: WebKit API addition of IDBObjectStore.count() and IDBIndex.count()
+https://bugs.webkit.org/show_bug.cgi?id=73685
+
+Reviewed by Darin Fisher.
+
+Implementation to follow - this just extends the WebKit API.
+
+* public/WebIDBIndex.h:
+(WebKit::WebIDBIndex::count):
+* public/WebIDBObjectStore.h:
+(WebKit::WebIDBObjectStore::count):
+
2011-12-07 Alexandre Elias ael...@google.com
[chromium] Add page-scale animation support to Impl thread
Modified: trunk/Source/WebKit/chromium/public/WebIDBIndex.h (102360 => 102361)
--- trunk/Source/WebKit/chromium/public/WebIDBIndex.h 2011-12-08 20:01:12 UTC (rev 102360)
+++ trunk/Source/WebKit/chromium/public/WebIDBIndex.h 2011-12-08 20:11:57 UTC (rev 102361)
@@ -69,6 +69,7 @@
virtual void openObjectCursor(const WebIDBKeyRange, unsigned short direction, WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void openKeyCursor(const WebIDBKeyRange, unsigned short direction, WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
+virtual void count(const WebIDBKeyRange, WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void getObject(const WebIDBKey, WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void getKey(const WebIDBKey, WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
Modified: trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h (102360 => 102361)
--- trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h 2011-12-08 20:01:12 UTC (rev 102360)
+++ trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h 2011-12-08 20:11:57 UTC (rev 102361)
@@ -88,6 +88,7 @@
}
virtual void deleteIndex(const WebString name, const WebIDBTransaction, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void openCursor(const WebIDBKeyRange, unsigned short direction, WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
+virtual void count(const WebIDBKeyRange, WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
protected:
WebIDBObjectStore() {}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102362] trunk/Source/WebKit/chromium
Title: [102362] trunk/Source/WebKit/chromium
Revision 102362
Author pe...@chromium.org
Date 2011-12-08 12:16:29 -0800 (Thu, 08 Dec 2011)
Log Message
[Chromium] Exclude the four RenderTableCellDeathTest death tests for Android
https://bugs.webkit.org/show_bug.cgi?id=73997
The ASSERT_DEATH macro is not yet available in Google Test when
building for Android, which causes compilation errors. This code
will be removed once support lands in the GTest version Chromium
uses. See https://bugs.webkit.org/show_bug.cgi?id=74089.
Reviewed by Julien Chaffraix.
* tests/RenderTableCellTest.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/RenderTableCellTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (102361 => 102362)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-08 20:11:57 UTC (rev 102361)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-08 20:16:29 UTC (rev 102362)
@@ -1,3 +1,17 @@
+2011-12-08 Peter Beverloo pe...@chromium.org
+
+[Chromium] Exclude the four RenderTableCellDeathTest death tests for Android
+https://bugs.webkit.org/show_bug.cgi?id=73997
+
+The ASSERT_DEATH macro is not yet available in Google Test when
+building for Android, which causes compilation errors. This code
+will be removed once support lands in the GTest version Chromium
+uses. See https://bugs.webkit.org/show_bug.cgi?id=74089.
+
+Reviewed by Julien Chaffraix.
+
+* tests/RenderTableCellTest.cpp:
+
2011-12-08 Joshua Bell jsb...@chromium.org
IndexedDB: WebKit API addition of IDBObjectStore.count() and IDBIndex.count()
Modified: trunk/Source/WebKit/chromium/tests/RenderTableCellTest.cpp (102361 => 102362)
--- trunk/Source/WebKit/chromium/tests/RenderTableCellTest.cpp 2011-12-08 20:11:57 UTC (rev 102361)
+++ trunk/Source/WebKit/chromium/tests/RenderTableCellTest.cpp 2011-12-08 20:16:29 UTC (rev 102362)
@@ -110,6 +110,10 @@
EXPECT_EQ(maxRowIndex, m_cell-row());
}
+// FIXME: Re-enable these tests once ASSERT_DEATH is supported for Android.
+// See: https://bugs.webkit.org/show_bug.cgi?id=74089
+#if !OS(ANDROID)
+
TEST_F(RenderTableCellDeathTest, CrashIfColumnOverflowOnSetting)
{
ASSERT_DEATH(m_cell-setCol(maxColumnIndex + 1), );
@@ -130,6 +134,8 @@
ASSERT_DEATH(m_cell-setRow(unsetRowIndex), );
}
+#endif
+
}
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102368] trunk/Source/WebCore
Title: [102368] trunk/Source/WebCore
Revision 102368
Author benja...@webkit.org
Date 2011-12-08 12:53:05 -0800 (Thu, 08 Dec 2011)
Log Message
Add a platform EventLoop for iOS
https://bugs.webkit.org/show_bug.cgi?id=74043
Patch by Benjamin Poulain bpoul...@apple.com on 2011-12-08
Reviewed by David Kilzer.
* WebCore.xcodeproj/project.pbxproj:
* platform/ios/EventLoopIOS.mm: Added.
(WebCore::EventLoop::cycle):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebCore/platform/ios/EventLoopIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (102367 => 102368)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 20:47:11 UTC (rev 102367)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 20:53:05 UTC (rev 102368)
@@ -1,3 +1,14 @@
+2011-12-08 Benjamin Poulain bpoul...@apple.com
+
+Add a platform EventLoop for iOS
+https://bugs.webkit.org/show_bug.cgi?id=74043
+
+Reviewed by David Kilzer.
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/ios/EventLoopIOS.mm: Added.
+(WebCore::EventLoop::cycle):
+
2011-12-08 Pavel Feldman pfeld...@google.com
Web Inspector: return node counts on the document / detached root basis
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (102367 => 102368)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-12-08 20:47:11 UTC (rev 102367)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-12-08 20:53:05 UTC (rev 102368)
@@ -679,6 +679,7 @@
2655413A1489811C000DFC5D /* KeyEventIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 265541381489811C000DFC5D /* KeyEventIOS.mm */; };
265541521489B233000DFC5D /* CursorIOS.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2655414B1489AA2B000DFC5D /* CursorIOS.cpp */; };
26E98A10130A9FCA008EB7B2 /* TextCodecASCIIFastPath.h in Headers */ = {isa = PBXBuildFile; fileRef = 26E98A0F130A9FCA008EB7B2 /* TextCodecASCIIFastPath.h */; };
+ 26F40D4A14904A6300CA67C4 /* EventLoopIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 26F40D4914904A6300CA67C4 /* EventLoopIOS.mm */; };
2917B5611473496C0052C9D0 /* LayerFlushScheduler.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2917B55E1473496C0052C9D0 /* LayerFlushScheduler.cpp */; };
2917B5621473496C0052C9D0 /* LayerFlushScheduler.h in Headers */ = {isa = PBXBuildFile; fileRef = 2917B55F1473496C0052C9D0 /* LayerFlushScheduler.h */; settings = {ATTRIBUTES = (Private, ); }; };
2917B5631473496C0052C9D0 /* LayerFlushSchedulerClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 2917B5601473496C0052C9D0 /* LayerFlushSchedulerClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -7786,6 +7787,7 @@
265541381489811C000DFC5D /* KeyEventIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = KeyEventIOS.mm; path = ios/KeyEventIOS.mm; sourceTree = group; };
2655414B1489AA2B000DFC5D /* CursorIOS.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = CursorIOS.cpp; path = ios/CursorIOS.cpp; sourceTree = group; };
26E98A0F130A9FCA008EB7B2 /* TextCodecASCIIFastPath.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextCodecASCIIFastPath.h; sourceTree = group; };
+ 26F40D4914904A6300CA67C4 /* EventLoopIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = EventLoopIOS.mm; path = ios/EventLoopIOS.mm; sourceTree = group; };
2917B55E1473496C0052C9D0 /* LayerFlushScheduler.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = LayerFlushScheduler.cpp; path = ca/LayerFlushScheduler.cpp; sourceTree = group; };
2917B55F1473496C0052C9D0 /* LayerFlushScheduler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = LayerFlushScheduler.h; path = ca/LayerFlushScheduler.h; sourceTree = group; };
2917B5601473496C0052C9D0 /* LayerFlushSchedulerClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = LayerFlushSchedulerClient.h; path = ca/LayerFlushSchedulerClient.h; sourceTree = group; };
@@ -17625,6 +17627,7 @@
A59E3C1B11580F340072928E /* ios */ = {
isa = PBXGroup;
children = (
+26F40D4914904A6300CA67C4 /* EventLoopIOS.mm */,
2655414B1489AA2B000DFC5D /* CursorIOS.cpp */,
265541371489811C000DFC5D /* KeyEventCodesIOS.h */,
265541381489811C000DFC5D /* KeyEventIOS.mm */,
@@ -27654,6 +27657,7 @@
6E3FAD3814733F4000E42306 /* JSWebGLCompressedTextures.cpp in Sources */,
6E3FAE8E14733FDB00E42306 /* WebGLCompressedTextures.cpp in Sources */,
2655413A1489811C000DFC5D /* KeyEventIOS.mm in Sources */,
+26F40D4A14904A6300CA67C4 /* EventLoopIOS.mm in Sources */,
D7613A501474F13F00DB8606 /* WebKitNamedFlow.cpp in Sources */,
D7613AC414753E5600DB8606 /*
[webkit-changes] [102370] branches/safari-534.53-branch/Source
Title: [102370] branches/safari-534.53-branch/Source
Revision 102370
Author lforsch...@apple.com
Date 2011-12-08 13:03:01 -0800 (Thu, 08 Dec 2011)
Log Message
Merged r101290.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/page/ChromeClient.h
branches/safari-534.53-branch/Source/WebCore/page/FrameView.cpp
branches/safari-534.53-branch/Source/WebCore/page/FrameView.h
branches/safari-534.53-branch/Source/WebCore/platform/ScrollView.cpp
branches/safari-534.53-branch/Source/WebCore/platform/ScrollView.h
branches/safari-534.53-branch/Source/WebCore/platform/ScrollableArea.h
branches/safari-534.53-branch/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
branches/safari-534.53-branch/Source/WebKit2/ChangeLog
branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm
branches/safari-534.53-branch/Source/WebKit2/UIProcess/PageClient.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp
branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.messages.in
branches/safari-534.53-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
branches/safari-534.53-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (102369 => 102370)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-12-08 20:59:19 UTC (rev 102369)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-12-08 21:03:01 UTC (rev 102370)
@@ -1,5 +1,44 @@
2011-12-08 Lucas Forschler lforsch...@apple.com
+Merge 101290
+
+2011-11-28 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=72551
+When the recommended scrollbar style changes, WKView's tracking options should
+adjust accordingly
+-and corresponding-
+rdar://problem/10409328
+
+Reviewed by Darin Adler.
+
+This new ChromeClient function is called when the recommended scrollbar style
+changes. This way, WebKit can respond to the change by adjusting its mouse
+tracking.
+* page/ChromeClient.h:
+(WebCore::ChromeClient::recommendedScrollbarStyleDidChange):
+
+Existing ScrollableArea function scrollbarStyleChanged() now takes an int
+indicating the new scrollbar style and a bool indicating whether it is necessary
+to force an update. It used to be the case that this function was ONLY used to
+force an update (and only called when an updated was needed), but now that it must
+also call into the ChromeClient, it is necessary to include a bool tracking
+whether we need to force an update. New implementation on FrameView is responsible
+for calling ChromeClient, and then that calls into the pre-existing ScrollView
+function for the forceUpdate part.
+* page/FrameView.cpp:
+(WebCore::FrameView::scrollbarStyleChanged):
+* page/FrameView.h:
+* platform/ScrollView.cpp:
+(WebCore::ScrollView:: scrollbarStyleChanged):
+* platform/ScrollView.h:
+* platform/ScrollableArea.h:
+(WebCore::ScrollableArea::scrollbarStyleChanged):
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::updateScrollerStyle):
+
+2011-12-08 Lucas Forschler lforsch...@apple.com
+
Merge 100483
2011-11-16 Beth Dakin bda...@apple.com
Modified: branches/safari-534.53-branch/Source/WebCore/page/ChromeClient.h (102369 => 102370)
--- branches/safari-534.53-branch/Source/WebCore/page/ChromeClient.h 2011-12-08 20:59:19 UTC (rev 102369)
+++ branches/safari-534.53-branch/Source/WebCore/page/ChromeClient.h 2011-12-08 21:03:01 UTC (rev 102370)
@@ -315,6 +315,7 @@
virtual void didCompleteAnimatedScroll() const { }
virtual void notifyScrollerThumbIsVisibleInRect(const IntRect) { }
+virtual void recommendedScrollbarStyleDidChange(int /*newStyle*/) { }
enum DialogType {
AlertDialog = 0,
Modified: branches/safari-534.53-branch/Source/WebCore/page/FrameView.cpp (102369 => 102370)
--- branches/safari-534.53-branch/Source/WebCore/page/FrameView.cpp 2011-12-08 20:59:19 UTC (rev 102369)
+++ branches/safari-534.53-branch/Source/WebCore/page/FrameView.cpp 2011-12-08 21:03:01 UTC (rev 102370)
@@ -2248,6 +2248,19 @@
return m_frame-loader()-state() != FrameStateComplete;
}
+void FrameView::scrollbarStyleChanged(int newStyle, bool
[webkit-changes] [102371] trunk/Source/WebCore
Title: [102371] trunk/Source/WebCore
Revision 102371
Author commit-qu...@webkit.org
Date 2011-12-08 13:05:38 -0800 (Thu, 08 Dec 2011)
Log Message
[chromium] Need to adjust memory limit and viewport multipliers.
https://bugs.webkit.org/show_bug.cgi?id=74022
Patch by Eric Penner epen...@google.com on 2011-12-08
Reviewed by James Robinson.
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes): Changing constants
(WebCore::TextureManager::reclaimLimitBytes): ditto
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (102370 => 102371)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 21:03:01 UTC (rev 102370)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 21:05:38 UTC (rev 102371)
@@ -1,3 +1,14 @@
+2011-12-08 Eric Penner epen...@google.com
+
+[chromium] Need to adjust memory limit and viewport multipliers.
+https://bugs.webkit.org/show_bug.cgi?id=74022
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/TextureManager.cpp:
+(WebCore::TextureManager::highLimitBytes): Changing constants
+(WebCore::TextureManager::reclaimLimitBytes): ditto
+
2011-12-08 Benjamin Poulain bpoul...@apple.com
Add a platform EventLoop for iOS
Modified: trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp (102370 => 102371)
--- trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp 2011-12-08 21:03:01 UTC (rev 102370)
+++ trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp 2011-12-08 21:05:38 UTC (rev 102371)
@@ -47,10 +47,10 @@
size_t TextureManager::highLimitBytes(const IntSize viewportSize)
{
size_t viewportMultiplier, minMegabytes, maxMegabytes;
-viewportMultiplier = 8;
+viewportMultiplier = 12;
#if OS(ANDROID)
minMegabytes = 24;
-maxMegabytes = 32;
+maxMegabytes = 40;
#else
minMegabytes = 64;
maxMegabytes = 128;
@@ -61,7 +61,7 @@
size_t TextureManager::reclaimLimitBytes(const IntSize viewportSize)
{
size_t viewportMultiplier, minMegabytes, maxMegabytes;
-viewportMultiplier = 4;
+viewportMultiplier = 6;
#if OS(ANDROID)
minMegabytes = 9;
maxMegabytes = 32;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102372] branches/safari-534.53-branch
Title: [102372] branches/safari-534.53-branch
Revision 102372
Author lforsch...@apple.com
Date 2011-12-08 13:06:08 -0800 (Thu, 08 Dec 2011)
Log Message
Merged r101532.
Modified Paths
branches/safari-534.53-branch/Source/WebKit2/ChangeLog
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
branches/safari-534.53-branch/Tools/ChangeLog
branches/safari-534.53-branch/Tools/TestWebKitAPI/mac/PlatformWebViewMac.mm
Diff
Modified: branches/safari-534.53-branch/Source/WebKit2/ChangeLog (102371 => 102372)
--- branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-12-08 21:05:38 UTC (rev 102371)
+++ branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-12-08 21:06:08 UTC (rev 102372)
@@ -1,5 +1,22 @@
2011-12-08 Lucas Forschler lforsch...@apple.com
+Merge 101532
+
+2011-11-29 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=72751
+WebKit2.MouseMoveAfterCrash API test is failing
+
+Reviewed by Sam Weinig.
+
+windowIsFocused() is too restrictive. All we need to know is that the page is
+active.
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::mouseEvent):
+(WebKit::WebPage::mouseEventSyncForTesting):
+
+2011-12-08 Lucas Forschler lforsch...@apple.com
+
Merge 101290
2011-11-28 Beth Dakin bda...@apple.com
Modified: branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (102371 => 102372)
--- branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-12-08 21:05:38 UTC (rev 102371)
+++ branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-12-08 21:06:08 UTC (rev 102372)
@@ -1084,7 +1084,7 @@
if (!handled) {
CurrentEvent currentEvent(mouseEvent);
-handled = handleMouseEvent(mouseEvent, m_page.get(), !windowIsFocused());
+handled = handleMouseEvent(mouseEvent, m_page.get(), !m_page-focusController()-isActive());
}
send(Messages::WebPageProxy::DidReceiveEvent(static_castuint32_t(mouseEvent.type()), handled));
Modified: branches/safari-534.53-branch/Tools/ChangeLog (102371 => 102372)
--- branches/safari-534.53-branch/Tools/ChangeLog 2011-12-08 21:05:38 UTC (rev 102371)
+++ branches/safari-534.53-branch/Tools/ChangeLog 2011-12-08 21:06:08 UTC (rev 102372)
@@ -1,3 +1,19 @@
+2011-12-08 Lucas Forschler lforsch...@apple.com
+
+Merge 101532
+
+2011-11-29 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=72751
+WebKit2.MouseMoveAfterCrash API test is failing
+
+Reviewed by Sam Weinig.
+
+Like DumpRenderTree, the NSWindow should act as an active window.
+* TestWebKitAPI/mac/PlatformWebViewMac.mm:
+(-[ActiveOffscreenWindow isKeyWindow]):
+(TestWebKitAPI::PlatformWebView::PlatformWebView):
+
2011-12-06 Lucas Forschler lforsch...@apple.com
Merge 98413
Modified: branches/safari-534.53-branch/Tools/TestWebKitAPI/mac/PlatformWebViewMac.mm (102371 => 102372)
--- branches/safari-534.53-branch/Tools/TestWebKitAPI/mac/PlatformWebViewMac.mm 2011-12-08 21:05:38 UTC (rev 102371)
+++ branches/safari-534.53-branch/Tools/TestWebKitAPI/mac/PlatformWebViewMac.mm 2011-12-08 21:06:08 UTC (rev 102372)
@@ -27,6 +27,16 @@
#import Carbon/Carbon.h
+@interface ActiveOffscreenWindow : NSWindow
+@end
+
+@implementation ActiveOffscreenWindow
+- (BOOL)isKeyWindow
+{
+return YES;
+}
+@end
+
namespace TestWebKitAPI {
PlatformWebView::PlatformWebView(WKContextRef contextRef, WKPageGroupRef pageGroupRef)
@@ -35,7 +45,7 @@
m_view = [[WKView alloc] initWithFrame:rect contextRef:contextRef pageGroupRef:pageGroupRef];
NSRect windowRect = NSOffsetRect(rect, -1, [(NSScreen *)[[NSScreen screens] objectAtIndex:0] frame].size.height - rect.size.height + 1);
-m_window = [[NSWindow alloc] initWithContentRect:windowRect styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:YES];
+m_window = [[ActiveOffscreenWindow alloc] initWithContentRect:windowRect styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:YES];
[m_window setColorSpace:[[NSScreen mainScreen] colorSpace]];
[[m_window contentView] addSubview:m_view];
[m_window orderBack:nil];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102373] trunk/Source/WebCore
Title: [102373] trunk/Source/WebCore
Revision 102373
Author e...@google.com
Date 2011-12-08 13:07:57 -0800 (Thu, 08 Dec 2011)
Log Message
[chromium] Remove dead code in compositor
https://bugs.webkit.org/show_bug.cgi?id=74103
Reviewed by James Robinson.
Tested via the compiler.
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (102372 => 102373)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 21:06:08 UTC (rev 102372)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 21:07:57 UTC (rev 102373)
@@ -1,3 +1,16 @@
+2011-12-08 Adrienne Walker e...@google.com
+
+[chromium] Remove dead code in compositor
+https://bugs.webkit.org/show_bug.cgi?id=74103
+
+Reviewed by James Robinson.
+
+Tested via the compiler.
+
+* platform/graphics/chromium/LayerChromium.h:
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+* platform/graphics/chromium/LayerRendererChromium.h:
+
2011-12-08 Eric Penner epen...@google.com
[chromium] Need to adjust memory limit and viewport multipliers.
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h (102372 => 102373)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-12-08 21:06:08 UTC (rev 102372)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-12-08 21:07:57 UTC (rev 102373)
@@ -169,10 +169,8 @@
virtual void protectVisibleTileTextures() { }
virtual bool needsContentsScale() const { return false; }
-// These exist just for debugging (via drawDebugBorder()).
void setDebugBorderColor(const Color);
void setDebugBorderWidth(float);
-void drawDebugBorder();
virtual void pushPropertiesTo(CCLayerImpl*);
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (102372 => 102373)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-12-08 21:06:08 UTC (rev 102372)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-12-08 21:07:57 UTC (rev 102373)
@@ -596,23 +596,6 @@
GraphicsContext3D::RGBA, GraphicsContext3D::UNSIGNED_BYTE, pixels));
}
-// Returns true if any part of the layer falls within the visibleRect
-bool LayerRendererChromium::isLayerVisible(LayerChromium* layer, const TransformationMatrix matrix, const IntRect visibleRect)
-{
-// Form the matrix used by the shader to map the corners of the layer's
-// bounds into clip space.
-TransformationMatrix renderMatrix = matrix;
-renderMatrix.scale3d(layer-bounds().width(), layer-bounds().height(), 1);
-renderMatrix = m_projectionMatrix * renderMatrix;
-
-FloatRect layerRect(-0.5, -0.5, 1, 1);
-FloatRect mappedRect = renderMatrix.mapRect(layerRect);
-
-// The layer is visible if it intersects any part of a rectangle whose origin
-// is at (-1, -1) and size is 2x2.
-return mappedRect.intersects(FloatRect(-1, -1, 2, 2));
-}
-
ManagedTexture* LayerRendererChromium::getOffscreenLayerTexture()
{
return settings().compositeOffscreen rootLayer() ? rootLayer()-renderSurface()-contentsTexture() : 0;
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h (102372 => 102373)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h 2011-12-08 21:06:08 UTC (rev 102372)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h 2011-12-08 21:07:57 UTC (rev 102373)
@@ -172,8 +172,6 @@
ManagedTexture* getOffscreenLayerTexture();
void copyOffscreenTextureToDisplay();
-bool isLayerVisible(LayerChromium*, const TransformationMatrix, const IntRect visibleRect);
-
void setDrawViewportRect(const IntRect, bool flipY);
void releaseRenderSurfaceTextures();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102374] branches/safari-534.53-branch/Source/WebKit2
Title: [102374] branches/safari-534.53-branch/Source/WebKit2
Revision 102374
Author lforsch...@apple.com
Date 2011-12-08 13:11:44 -0800 (Thu, 08 Dec 2011)
Log Message
Merged r101719.
Modified Paths
branches/safari-534.53-branch/Source/WebKit2/ChangeLog
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Diff
Modified: branches/safari-534.53-branch/Source/WebKit2/ChangeLog (102373 => 102374)
--- branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-12-08 21:07:57 UTC (rev 102373)
+++ branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-12-08 21:11:44 UTC (rev 102374)
@@ -1,5 +1,24 @@
2011-12-08 Lucas Forschler lforsch...@apple.com
+Merge 101719
+
+2011-12-01 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=73592
+REGRESSION (r100483): Can't drag out of background window
+-and corresponding-
+rdar://problem/10508870
+
+Reviewed by Darin Adler.
+
+If the mouse is pressed we need to do a full, normal hit test even if the window
+is not active.
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::mouseEvent):
+(WebKit::WebPage::mouseEventSyncForTesting):
+
+2011-12-08 Lucas Forschler lforsch...@apple.com
+
Merge 101532
2011-11-29 Beth Dakin bda...@apple.com
Modified: branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (102373 => 102374)
--- branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-12-08 21:07:57 UTC (rev 102373)
+++ branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-12-08 21:11:44 UTC (rev 102374)
@@ -1084,7 +1084,13 @@
if (!handled) {
CurrentEvent currentEvent(mouseEvent);
-handled = handleMouseEvent(mouseEvent, m_page.get(), !m_page-focusController()-isActive());
+// We need to do a full, normal hit test during this mouse event if the page is active or if a mouse
+// button is currently pressed. It is possible that neither of those things will be true since on
+// Lion when legacy scrollbars are enabled, WebKit receives mouse events all the time. If it is one
+// of those cases where the page is not active and the mouse is not pressed, then we can fire a more
+// efficient scrollbars-only version of the event.
+bool _onlyUpdateScrollbars_ = !(m_page-focusController()-isActive() || (mouseEvent.button() != WebMouseEvent::NoButton));
+handled = handleMouseEvent(mouseEvent, m_page.get(), onlyUpdateScrollbars);
}
send(Messages::WebPageProxy::DidReceiveEvent(static_castuint32_t(mouseEvent.type()), handled));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102375] trunk/Source/WebCore
Title: [102375] trunk/Source/WebCore
Revision 102375
Author vse...@chromium.org
Date 2011-12-08 13:15:29 -0800 (Thu, 08 Dec 2011)
Log Message
Web Inspector: Rename createScriptCallStack() without parameters to createScriptCallStackForInspector().
https://bugs.webkit.org/show_bug.cgi?id=74120
Reviewed by Pavel Feldman.
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
* bindings/js/ScriptCallStackFactory.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
* bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
* bindings/v8/ScriptCallStackFactory.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.cpp
trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/v8/ScriptCallStackFactory.cpp
trunk/Source/WebCore/bindings/v8/ScriptCallStackFactory.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (102374 => 102375)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 21:15:29 UTC (rev 102375)
@@ -1,3 +1,25 @@
+2011-12-08 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Rename createScriptCallStack() without parameters to createScriptCallStackForInspector().
+https://bugs.webkit.org/show_bug.cgi?id=74120
+
+Reviewed by Pavel Feldman.
+
+* bindings/js/ScriptCallStackFactory.cpp:
+(WebCore::createScriptCallStackForInspector):
+* bindings/js/ScriptCallStackFactory.h:
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateParametersCheck):
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateFunctionCallback):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjInternal::customArgsAndExceptionCallback):
+* bindings/v8/ScriptCallStackFactory.cpp:
+(WebCore::createScriptCallStackForInspector):
+* bindings/v8/ScriptCallStackFactory.h:
+
2011-12-08 Adrienne Walker e...@google.com
[chromium] Remove dead code in compositor
Modified: trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.cpp (102374 => 102375)
--- trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.cpp 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.cpp 2011-12-08 21:15:29 UTC (rev 102375)
@@ -86,7 +86,7 @@
return ScriptCallStack::create(frames);
}
-PassRefPtrScriptCallStack createScriptCallStack(JSC::ExecState* exec)
+PassRefPtrScriptCallStack createScriptCallStackForInspector(JSC::ExecState* exec)
{
size_t maxStackSize = 1;
if (InspectorInstrumentation::hasFrontends()) {
Modified: trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.h (102374 => 102375)
--- trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.h 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.h 2011-12-08 21:15:29 UTC (rev 102375)
@@ -44,7 +44,7 @@
PassRefPtrScriptCallStack createScriptCallStack(size_t maxStackSize, bool emptyStackIsAllowed);
PassRefPtrScriptCallStack createScriptCallStack(JSC::ExecState*, size_t maxStackSize);
-PassRefPtrScriptCallStack createScriptCallStack(JSC::ExecState*);
+PassRefPtrScriptCallStack createScriptCallStackForInspector(JSC::ExecState*);
PassRefPtrScriptArguments createScriptArguments(JSC::ExecState*, unsigned skipArgumentCount);
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (102374 => 102375)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-12-08 21:15:29 UTC (rev 102375)
@@ -2399,7 +2399,7 @@
if ($function-signature-extendedAttributes-{CustomArgumentHandling} and !$function-isStatic) {
push(@$outputArray, RefPtrScriptArguments scriptArguments(createScriptArguments(exec, $numParameters));\n);
-push(@$outputArray, RefPtrScriptCallStack callStack(createScriptCallStack(exec));\n);
+push(@$outputArray, RefPtrScriptCallStack callStack(createScriptCallStackForInspector(exec));\n);
$implIncludes{ScriptArguments.h} = 1;
$implIncludes{ScriptCallStack.h} = 1;
[webkit-changes] [102376] branches/safari-534.53-branch/Source/WebCore
Title: [102376] branches/safari-534.53-branch/Source/WebCore Revision 102376 Author lforsch...@apple.com Date 2011-12-08 13:21:15 -0800 (Thu, 08 Dec 2011) Log Message Merged r96777. Modified Paths branches/safari-534.53-branch/Source/WebCore/ChangeLog branches/safari-534.53-branch/Source/WebCore/platform/mac/CursorMac.mm Diff Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (102375 => 102376) --- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-12-08 21:15:29 UTC (rev 102375) +++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-12-08 21:21:15 UTC (rev 102376) @@ -1,5 +1,21 @@ 2011-12-08 Lucas Forschler lforsch...@apple.com +Merge 96777 + +2011-10-05 Darin Adler da...@apple.com + +[Mac] Use four more named cursors if present +https://bugs.webkit.org/show_bug.cgi?id=69488 + +Reviewed by Dan Bernstein. + +* platform/mac/CursorMac.mm: +(WebCore::Cursor::ensurePlatformCursor): Use the names Help, Cell, +ZoomIn, and ZoomOut to get those cursors. Structure the code so it +falls back if the cursors are not present. + +2011-12-08 Lucas Forschler lforsch...@apple.com + Merge 101290 2011-11-28 Beth Dakin bda...@apple.com Modified: branches/safari-534.53-branch/Source/WebCore/platform/mac/CursorMac.mm (102375 => 102376) --- branches/safari-534.53-branch/Source/WebCore/platform/mac/CursorMac.mm 2011-12-08 21:15:29 UTC (rev 102375) +++ branches/safari-534.53-branch/Source/WebCore/platform/mac/CursorMac.mm 2011-12-08 21:21:15 UTC (rev 102376) @@ -79,21 +79,25 @@ case Cursor::Pointer: m_platformCursor = [NSCursor arrowCursor]; break; + case Cursor::Cross: m_platformCursor = [NSCursor crosshairCursor]; break; + case Cursor::Hand: #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) m_platformCursor = [NSCursor pointingHandCursor]; #else // The pointingHandCursor from NSCursor does not have a shadow on -// older versions of Mac OS X, so use our own custom cursor. +// older versions of OS X, so use our own custom cursor. m_platformCursor = createNamedCursor(linkCursor, 6, 1); #endif break; + case Cursor::IBeam: m_platformCursor = [NSCursor IBeamCursor]; break; + case Cursor::Wait: #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) m_platformCursor = wkCursor(BusyButClickable); @@ -101,9 +105,16 @@ m_platformCursor = createNamedCursor(waitCursor, 7, 7); #endif break; + case Cursor::Help: +#if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) +m_platformCursor = wkCursor(Help); +if (m_platformCursor) +break; +#endif m_platformCursor = createNamedCursor(helpCursor, 8, 8); break; + case Cursor::Move: case Cursor::MiddlePanning: #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) @@ -112,6 +123,7 @@ m_platformCursor = createNamedCursor(moveCursor, 7, 7); #endif break; + case Cursor::EastResize: case Cursor::EastPanning: #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) @@ -120,6 +132,7 @@ m_platformCursor = createNamedCursor(eastResizeCursor, 14, 7); #endif break; + case Cursor::NorthResize: case Cursor::NorthPanning: #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) @@ -128,6 +141,7 @@ m_platformCursor = createNamedCursor(northResizeCursor, 7, 1); #endif break; + case Cursor::NorthEastResize: case Cursor::NorthEastPanning: #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) @@ -136,6 +150,7 @@ m_platformCursor = createNamedCursor(northEastResizeCursor, 14, 1); #endif break; + case Cursor::NorthWestResize: case Cursor::NorthWestPanning: #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) @@ -144,6 +159,7 @@ m_platformCursor = createNamedCursor(northWestResizeCursor, 0, 0); #endif break; + case Cursor::SouthResize: case Cursor::SouthPanning: #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) @@ -152,6 +168,7 @@ m_platformCursor = createNamedCursor(southResizeCursor, 7, 14); #endif break; + case Cursor::SouthEastResize: case Cursor::SouthEastPanning: #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) @@ -160,6 +177,7 @@ m_platformCursor = createNamedCursor(southEastResizeCursor, 14, 14); #endif break; + case Cursor::SouthWestResize: case Cursor::SouthWestPanning: #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) @@ -168,6 +186,7 @@ m_platformCursor = createNamedCursor(southWestResizeCursor, 1, 14); #endif break; +
[webkit-changes] [102377] trunk/Source/WebKit2
Title: [102377] trunk/Source/WebKit2 Revision 102377 Author jer.no...@apple.com Date 2011-12-08 13:23:16 -0800 (Thu, 08 Dec 2011) Log Message HiDPI: Switching a video element to full screen in HiDPI mode doesn't fit the screen correctly https://bugs.webkit.org/show_bug.cgi?id=74119 rdar://problem/10356869 Reviewed by Darin Adler. Use the Lion-only -[NSWindow convertRectToScreen:] function to convert between window coordinates and screen coordinates. * UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (102376 => 102377) --- trunk/Source/WebKit2/ChangeLog 2011-12-08 21:21:15 UTC (rev 102376) +++ trunk/Source/WebKit2/ChangeLog 2011-12-08 21:23:16 UTC (rev 102377) @@ -1,3 +1,17 @@ +2011-12-08 Jer Noble jer.no...@apple.com + +HiDPI: Switching a video element to full screen in HiDPI mode doesn't fit the screen correctly +https://bugs.webkit.org/show_bug.cgi?id=74119 +rdar://problem/10356869 + +Reviewed by Darin Adler. + +Use the Lion-only -[NSWindow convertRectToScreen:] function to convert between window +coordinates and screen coordinates. + +* UIProcess/mac/WKFullScreenWindowController.mm: +(-[WKFullScreenWindowController enterFullScreen:]): + 2011-12-08 Csaba Osztrogonác o...@webkit.org [Qt][WK2] Unreviewed buildfix after r102352. Modified: trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (102376 => 102377) --- trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm 2011-12-08 21:21:15 UTC (rev 102376) +++ trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm 2011-12-08 21:23:16 UTC (rev 102377) @@ -188,8 +188,13 @@ screen = [NSScreen mainScreen]; NSRect screenFrame = [screen frame]; +#if defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD) NSRect webViewFrame = [_webView convertRectToBase:[_webView frame]]; webViewFrame.origin = [[_webView window] convertBaseToScreen:webViewFrame.origin]; +#else +NSRect webViewFrame = [[_webView window] convertRectToScreen: +[_webView convertRect:[_webView frame] toView:nil]]; +#endif // In the case of a multi-monitor setup where the webView straddles two // monitors, we must create a window large enough to contain the destination ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102380] trunk/Source/JavaScriptCore
Title: [102380] trunk/Source/_javascript_Core
Revision 102380
Author msab...@apple.com
Date 2011-12-08 13:47:42 -0800 (Thu, 08 Dec 2011)
Log Message
Add 8 bit paths for StringTypeAdapter classes
https://bugs.webkit.org/show_bug.cgi?id=73882
Reviewed by Darin Adler.
Added is8Bit() method and writeTo(LChar*) methods
to StringTypeAdapter classes. The writeTo(LChar*)
method can be used if is8Bit() returns true. The
non-native 8 bit classes contain ASSERT(is8Bit())
in their writeTo(LChar*).
Updated all of the various versions of tryMakeString() to
use 8 bit processing in the updated StringTypeAdapter
classes.
This has slight if any performance improvement on kraken.
* runtime/UStringConcatenate.h:
* wtf/text/StringConcatenate.h:
(WTF::tryMakeString):
* wtf/text/StringOperators.h:
(WTF::StringAppend::is8Bit):
(WTF::StringAppend::writeTo):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/UStringConcatenate.h
trunk/Source/_javascript_Core/wtf/text/StringConcatenate.h
trunk/Source/_javascript_Core/wtf/text/StringOperators.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (102379 => 102380)
--- trunk/Source/_javascript_Core/ChangeLog 2011-12-08 21:29:31 UTC (rev 102379)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-12-08 21:47:42 UTC (rev 102380)
@@ -1,3 +1,29 @@
+2011-12-08 Michael Saboff msab...@apple.com
+
+Add 8 bit paths for StringTypeAdapter classes
+https://bugs.webkit.org/show_bug.cgi?id=73882
+
+Reviewed by Darin Adler.
+
+Added is8Bit() method and writeTo(LChar*) methods
+to StringTypeAdapter classes. The writeTo(LChar*)
+method can be used if is8Bit() returns true. The
+non-native 8 bit classes contain ASSERT(is8Bit())
+in their writeTo(LChar*).
+
+Updated all of the various versions of tryMakeString() to
+use 8 bit processing in the updated StringTypeAdapter
+classes.
+
+This has slight if any performance improvement on kraken.
+
+* runtime/UStringConcatenate.h:
+* wtf/text/StringConcatenate.h:
+(WTF::tryMakeString):
+* wtf/text/StringOperators.h:
+(WTF::StringAppend::is8Bit):
+(WTF::StringAppend::writeTo):
+
2011-12-07 Filip Pizlo fpi...@apple.com
DFG CSE should know that CheckFunction is pure
Modified: trunk/Source/_javascript_Core/runtime/UStringConcatenate.h (102379 => 102380)
--- trunk/Source/_javascript_Core/runtime/UStringConcatenate.h 2011-12-08 21:29:31 UTC (rev 102379)
+++ trunk/Source/_javascript_Core/runtime/UStringConcatenate.h 2011-12-08 21:47:42 UTC (rev 102380)
@@ -35,21 +35,37 @@
class StringTypeAdapterJSC::UString {
public:
StringTypeAdapterJSC::UString(JSC::UString string)
-: m_data(string.characters())
+: m_string(string)
, m_length(string.length())
{
}
unsigned length() { return m_length; }
-void writeTo(UChar* destination)
+bool is8Bit() { return m_string.isNull() || m_string.is8Bit(); }
+
+void writeTo(LChar* destination)
{
+const LChar* characters = m_string.characters8();
for (unsigned i = 0; i m_length; ++i)
-destination[i] = m_data[i];
+destination[i] = characters[i];
}
+void writeTo(UChar* destination)
+{
+if (is8Bit()) {
+const LChar* characters = m_string.characters8();
+for (unsigned i = 0; i m_length; ++i)
+destination[i] = characters[i];
+} else {
+const UChar* characters = m_string.characters16();
+for (unsigned i = 0; i m_length; ++i)
+destination[i] = characters[i];
+}
+}
+
private:
-const UChar* m_data;
+const JSC::UString m_string;
unsigned m_length;
};
Modified: trunk/Source/_javascript_Core/wtf/text/StringConcatenate.h (102379 => 102380)
--- trunk/Source/_javascript_Core/wtf/text/StringConcatenate.h 2011-12-08 21:29:31 UTC (rev 102379)
+++ trunk/Source/_javascript_Core/wtf/text/StringConcatenate.h 2011-12-08 21:47:42 UTC (rev 102380)
@@ -51,6 +51,14 @@
}
unsigned length() { return 1; }
+
+bool is8Bit() { return true; }
+
+void writeTo(LChar* destination)
+{
+*destination = m_buffer;
+}
+
void writeTo(UChar* destination) { *destination = m_buffer; }
private:
@@ -66,6 +74,14 @@
}
unsigned length() { return 1; }
+
+bool is8Bit() { return true; }
+
+void writeTo(LChar* destination)
+{
+*destination = m_buffer;
+}
+
void writeTo(UChar* destination) { *destination = m_buffer; }
private:
@@ -81,6 +97,15 @@
}
unsigned length() { return 1; }
+
+bool is8Bit() { return m_buffer = 0xff; }
+
+void writeTo(LChar* destination)
+{
+ASSERT(is8Bit());
+*destination = static_castLChar(m_buffer);
+}
+
void writeTo(UChar* destination) { *destination = m_buffer;
[webkit-changes] [102381] trunk/Tools
Title: [102381] trunk/Tools
Revision 102381
Author commit-qu...@webkit.org
Date 2011-12-08 14:08:51 -0800 (Thu, 08 Dec 2011)
Log Message
[Qt] Visualize mock point ID's in the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74098
Patch by Alexander Færøy a...@0x90.dk on 2011-12-08
Reviewed by Tor Arne Vestbø.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/qml/MockTouchPoint.qml:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp
trunk/Tools/MiniBrowser/qt/qml/MockTouchPoint.qml
Diff
Modified: trunk/Tools/ChangeLog (102380 => 102381)
--- trunk/Tools/ChangeLog 2011-12-08 21:47:42 UTC (rev 102380)
+++ trunk/Tools/ChangeLog 2011-12-08 22:08:51 UTC (rev 102381)
@@ -1,3 +1,14 @@
+2011-12-08 Alexander Færøy a...@0x90.dk
+
+[Qt] Visualize mock point ID's in the MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=74098
+
+Reviewed by Tor Arne Vestbø.
+
+* MiniBrowser/qt/BrowserWindow.cpp:
+(BrowserWindow::updateVisualMockTouchPoints):
+* MiniBrowser/qt/qml/MockTouchPoint.qml:
+
2011-12-08 Dominic Mazzoni dmazz...@google.com
Accessibility: AccessibilityController should support listening to notifications on all elements.
Modified: trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp (102380 => 102381)
--- trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp 2011-12-08 21:47:42 UTC (rev 102380)
+++ trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp 2011-12-08 22:08:51 UTC (rev 102381)
@@ -93,6 +93,7 @@
QDeclarativeComponent touchMockPointComponent(engine(), QUrl(qrc:/qml/MockTouchPoint.qml));
mockTouchPointItem = qobject_castQQuickItem*(touchMockPointComponent.create());
mockTouchPointItem-setObjectName(mockTouchPointIdentifier);
+mockTouchPointItem-setProperty(pointId, QVariant(touchPoint.id));
mockTouchPointItem-setParent(rootObject());
mockTouchPointItem-setParentItem(rootObject());
}
Modified: trunk/Tools/MiniBrowser/qt/qml/MockTouchPoint.qml (102380 => 102381)
--- trunk/Tools/MiniBrowser/qt/qml/MockTouchPoint.qml 2011-12-08 21:47:42 UTC (rev 102380)
+++ trunk/Tools/MiniBrowser/qt/qml/MockTouchPoint.qml 2011-12-08 22:08:51 UTC (rev 102381)
@@ -28,7 +28,10 @@
import QtQuick 2.0
Item {
+id: mockTouchPoint
+
property bool pressed: false
+property int pointId: 0
Image {
source: ../icons/touchpoint.png
@@ -39,5 +42,10 @@
Behavior on opacity {
NumberAnimation { duration: 200 }
}
+
+Text {
+text: mockTouchPoint.pointId
+anchors.centerIn: parent
+}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102382] trunk
Title: [102382] trunk
Revision 102382
Author cfleiz...@apple.com
Date 2011-12-08 14:11:50 -0800 (Thu, 08 Dec 2011)
Log Message
Tools: AX: platform/mac/accessibility/search-with-frames.html crashes
https://bugs.webkit.org/show_bug.cgi?id=74093
Reviewed by Darin Adler.
Take care of the case when an incoming element is null.
* DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementForSearchPredicateCallback):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementForSearchPredicate):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
LayoutTests: platform/mac/accessibility/search-with-frames.html crashes
https://bugs.webkit.org/show_bug.cgi?id=74093
Reviewed by Darin Adler.
Unskip the crashing test.
* platform/mac/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp
trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
Diff
Modified: trunk/LayoutTests/ChangeLog (102381 => 102382)
--- trunk/LayoutTests/ChangeLog 2011-12-08 22:08:51 UTC (rev 102381)
+++ trunk/LayoutTests/ChangeLog 2011-12-08 22:11:50 UTC (rev 102382)
@@ -1,3 +1,14 @@
+2011-12-08 Chris Fleizach cfleiz...@apple.com
+
+platform/mac/accessibility/search-with-frames.html crashes
+https://bugs.webkit.org/show_bug.cgi?id=74093
+
+Reviewed by Darin Adler.
+
+Unskip the crashing test.
+
+* platform/mac/Skipped:
+
2011-12-08 Dominic Mazzoni dmazz...@google.com
Accessibility: AccessibilityController should support listening to notifications on all elements.
Modified: trunk/LayoutTests/platform/mac/Skipped (102381 => 102382)
--- trunk/LayoutTests/platform/mac/Skipped 2011-12-08 22:08:51 UTC (rev 102381)
+++ trunk/LayoutTests/platform/mac/Skipped 2011-12-08 22:11:50 UTC (rev 102382)
@@ -523,6 +523,3 @@
# https://bugs.webkit.org/show_bug.cgi?id=73974
fast/canvas/webgl/canvas-2d-webgl-texture.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=74093
-platform/mac/accessibility/search-with-frames.html
Modified: trunk/Tools/ChangeLog (102381 => 102382)
--- trunk/Tools/ChangeLog 2011-12-08 22:08:51 UTC (rev 102381)
+++ trunk/Tools/ChangeLog 2011-12-08 22:11:50 UTC (rev 102382)
@@ -1,3 +1,19 @@
+2011-12-08 Chris Fleizach cfleiz...@apple.com
+
+AX: platform/mac/accessibility/search-with-frames.html crashes
+https://bugs.webkit.org/show_bug.cgi?id=74093
+
+Reviewed by Darin Adler.
+
+Take care of the case when an incoming element is null.
+
+* DumpRenderTree/AccessibilityUIElement.cpp:
+(uiElementForSearchPredicateCallback):
+* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
+(AccessibilityUIElement::uiElementForSearchPredicate):
+* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
+
2011-12-08 Alexander Færøy a...@0x90.dk
[Qt] Visualize mock point ID's in the MiniBrowser
Modified: trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp (102381 => 102382)
--- trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp 2011-12-08 22:08:51 UTC (rev 102381)
+++ trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp 2011-12-08 22:11:50 UTC (rev 102382)
@@ -192,7 +192,9 @@
JSStringRef searchKey = 0;
JSStringRef searchText = 0;
if (argumentCount == 4) {
-startElement = toAXElement(JSValueToObject(context, arguments[0], exception));
+JSObjectRef startElementObject = JSValueToObject(context, arguments[0], exception);
+if (startElementObject)
+startElement = toAXElement(startElementObject);
isDirectionNext = JSValueToBoolean(context, arguments[1]);
if (JSValueIsString(context, arguments[2]))
searchKey = JSValueToStringCopy(context, arguments[2], exception);
Modified: trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm (102381 => 102382)
--- trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2011-12-08 22:08:51 UTC (rev 102381)
+++ trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2011-12-08 22:11:50 UTC (rev 102382)
@@ -900,7 +900,7 @@
NSMutableDictionary* parameter = [NSMutableDictionary dictionary];
[parameter setObject:(isDirectionNext) ? @AXDirectionNext : @AXDirectionPrevious forKey:@AXDirection];
[parameter setObject:[NSNumber numberWithInt:1] forKey:@AXResultsLimit];
-if (startElement)
+if (startElement startElement-platformUIElement())
[parameter setObject:(id)startElement-platformUIElement() forKey:@AXStartElement];
if (searchKey)
[parameter setObject:[NSString stringWithJSStringRef:searchKey] forKey:@AXSearchKey];
Modified:
[webkit-changes] [102383] tags/Safari-534.53.7/
Title: [102383] tags/Safari-534.53.7/ Revision 102383 Author lforsch...@apple.com Date 2011-12-08 14:15:56 -0800 (Thu, 08 Dec 2011) Log Message New tag. Added Paths tags/Safari-534.53.7/ Diff Property changes: tags/Safari-534.53.7 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102384] branches/safari-534.53-branch/Source
Title: [102384] branches/safari-534.53-branch/Source Revision 102384 Author lforsch...@apple.com Date 2011-12-08 14:20:09 -0800 (Thu, 08 Dec 2011) Log Message Versioning. Modified Paths branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig (102383 => 102384) --- branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-12-08 22:15:56 UTC (rev 102383) +++ branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-12-08 22:20:09 UTC (rev 102384) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (102383 => 102384) --- branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-12-08 22:15:56 UTC (rev 102383) +++ branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-12-08 22:20:09 UTC (rev 102384) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig (102383 => 102384) --- branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig 2011-12-08 22:15:56 UTC (rev 102383) +++ branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig 2011-12-08 22:20:09 UTC (rev 102384) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig (102383 => 102384) --- branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-12-08 22:15:56 UTC (rev 102383) +++ branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-12-08 22:20:09 UTC (rev 102384) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig (102383 => 102384) --- branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-12-08 22:15:56 UTC (rev 102383) +++ branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-12-08 22:20:09 UTC (rev 102384) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102385] trunk/Source/WebCore
Title: [102385] trunk/Source/WebCore
Revision 102385
Author senorbla...@chromium.org
Date 2011-12-08 14:29:39 -0800 (Thu, 08 Dec 2011)
Log Message
Use Skia's implementation of Gaussian blur when accelerated filters
are enabled.
https://bugs.webkit.org/show_bug.cgi?id=73949
Reviewed by Zoltan Herczeg.
In the future, this will be covered by the SVG tests run in GPU mode.
* WebCore.gypi:
Add FEGaussianBlurSkia.cpp to the build.
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware):
Call out to platformApplySkia() when USE_SKIA is enabled.
* platform/graphics/filters/FEGaussianBlur.h:
platformApplySkia() declaration.
* platform/graphics/filters/skia: Added.
* platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Added.
(WebCore::FEGaussianBlur::platformApplySkia):
On the Skia port, use SkBlurImageFilter for drawing
Gaussian blurs in accelerated mode.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
Implement ImageBuffer::copyImage() with DontCopyBackingStore semantics.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp
trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
Added Paths
trunk/Source/WebCore/platform/graphics/filters/skia/
trunk/Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (102384 => 102385)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 22:20:09 UTC (rev 102384)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 22:29:39 UTC (rev 102385)
@@ -1,3 +1,29 @@
+2011-12-08 Stephen White senorbla...@chromium.org
+
+Use Skia's implementation of Gaussian blur when accelerated filters
+are enabled.
+https://bugs.webkit.org/show_bug.cgi?id=73949
+
+Reviewed by Zoltan Herczeg.
+
+In the future, this will be covered by the SVG tests run in GPU mode.
+
+* WebCore.gypi:
+Add FEGaussianBlurSkia.cpp to the build.
+* platform/graphics/filters/FEGaussianBlur.cpp:
+(WebCore::FEGaussianBlur::platformApplySoftware):
+Call out to platformApplySkia() when USE_SKIA is enabled.
+* platform/graphics/filters/FEGaussianBlur.h:
+platformApplySkia() declaration.
+* platform/graphics/filters/skia: Added.
+* platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Added.
+(WebCore::FEGaussianBlur::platformApplySkia):
+On the Skia port, use SkBlurImageFilter for drawing
+Gaussian blurs in accelerated mode.
+* platform/graphics/skia/ImageBufferSkia.cpp:
+(WebCore::ImageBuffer::copyImage):
+Implement ImageBuffer::copyImage() with DontCopyBackingStore semantics.
+
2011-12-08 Erik Arvidsson a...@chromium.org
CodeGeneratorV8: Fix issue with overloaded static conditional methods
Modified: trunk/Source/WebCore/WebCore.gypi (102384 => 102385)
--- trunk/Source/WebCore/WebCore.gypi 2011-12-08 22:20:09 UTC (rev 102384)
+++ trunk/Source/WebCore/WebCore.gypi 2011-12-08 22:29:39 UTC (rev 102385)
@@ -3701,6 +3701,7 @@
'platform/graphics/filters/arm/FEGaussianBlurNEON.h',
'platform/graphics/filters/arm/FELightingNEON.cpp',
'platform/graphics/filters/arm/FELightingNEON.h',
+'platform/graphics/filters/skia/FEGaussianBlurSkia.cpp',
'platform/graphics/freetype/FontCacheFreeType.cpp',
'platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp',
'platform/graphics/freetype/FontPlatformData.h',
Modified: trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp (102384 => 102385)
--- trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp 2011-12-08 22:20:09 UTC (rev 102384)
+++ trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp 2011-12-08 22:29:39 UTC (rev 102385)
@@ -265,6 +265,13 @@
void FEGaussianBlur::platformApplySoftware()
{
+#if USE(SKIA)
+if (filter()-renderingMode() == Accelerated) {
+platformApplySkia();
+return;
+}
+#endif
+
FilterEffect* in = inputEffect(0);
ByteArray* srcPixelArray = createPremultipliedImageResult();
Modified: trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h (102384 => 102385)
--- trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h 2011-12-08 22:20:09 UTC (rev 102384)
+++ trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h 2011-12-08 22:29:39 UTC (rev 102385)
@@ -73,6 +73,7 @@
inline void platformApplyGeneric(ByteArray* srcPixelArray, ByteArray* tmpPixelArray, unsigned kernelSizeX, unsigned kernelSizeY, IntSize paintSize);
inline void platformApplyNeon(ByteArray* srcPixelArray, ByteArray* tmpPixelArray, unsigned kernelSizeX, unsigned kernelSizeY, IntSize paintSize);
+void platformApplySkia();
[webkit-changes] [102386] branches/chromium/963
Title: [102386] branches/chromium/963
Revision 102386
Author dslo...@google.com
Date 2011-12-08 14:38:12 -0800 (Thu, 08 Dec 2011)
Log Message
Merge 102317 - https://bugs.webkit.org/show_bug.cgi?id=74038
[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
Reviewed by David Levin.
Source/WebCore:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::isLegacyTargetOriginDesignation):
(WebCore::handlePostMessageCallback):
LayoutTests:
* fast/dom/Window/window-postmessage-args-expected.txt:
* fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
TBR=ca...@chromium.org
ISSUE=http://code.google.com/p/chromium/issues/detail?id=106797
Review URL: http://codereview.chromium.org/8883032
Modified Paths
branches/chromium/963/LayoutTests/ChangeLog
branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt
branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args.html
branches/chromium/963/LayoutTests/platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt
branches/chromium/963/Source/WebCore/ChangeLog
branches/chromium/963/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
Diff
Modified: branches/chromium/963/LayoutTests/ChangeLog (102385 => 102386)
--- branches/chromium/963/LayoutTests/ChangeLog 2011-12-08 22:29:39 UTC (rev 102385)
+++ branches/chromium/963/LayoutTests/ChangeLog 2011-12-08 22:38:12 UTC (rev 102386)
@@ -1,3 +1,14 @@
+2011-12-07 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=74038
+[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
+
+Reviewed by David Levin.
+
+* fast/dom/Window/window-postmessage-args-expected.txt:
+* fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
+* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
+
2011-12-02 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r101731.
Modified: branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt (102385 => 102386)
--- branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-08 22:29:39 UTC (rev 102385)
+++ branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-08 22:38:12 UTC (rev 102386)
@@ -8,11 +8,14 @@
PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
+PASS: Posting message ('4a', *) did not throw an exception
+PASS: Posting message ('4a', *) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+PASS: Posting message ('7a', *) did not throw an exception
FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
PASS: Posting message ('2147483648', null) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
@@ -23,10 +26,13 @@
FAIL: arrayBuffer not neutered; byteLength = 30
FAIL: view was not neutered; length = 10
PASS: Posting message ('done', undefined) did not throw an exception
+Received message '4a' with 0 ports.
+Received message '4a' with 0 ports.
Received message '5' with 0 ports.
Received message '5' with 0 ports.
Received message '6' with 0 ports.
Received message '6' with 0 ports.
+Received message '7a' with 2 ports.
Received message '2147483648' with 0 ports.
Received message '2147483648' with 0 ports.
Received message 'done' with 0 ports.
Modified: branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args.html (102385 => 102386)
--- branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args.html 2011-12-08 22:29:39 UTC (rev 102385)
+++ branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args.html 2011-12-08 22:38:12 UTC (rev 102386)
@@ -46,10 +46,13 @@
tryPostMessage('2', '*', 'c', true);
tryPostMessage('3', '*', { x: 1 }, true);
tryPostMessage('4', '*', window); // Passes because window has a length attribute of value '0', so it looks like an array
+tryPostMessage('4a', window, '*'); // Legacy argument order.
tryPostMessage('5', '*', null);
tryPostMessage('6', '*', void 0);
var channel1 = new MessageChannel;
tryPostMessageFunction(window.postMessage, '7', '*', [channel1.port1,
[webkit-changes] [102389] trunk/Source/JavaScriptCore
Title: [102389] trunk/Source/_javascript_Core
Revision 102389
Author commit-qu...@webkit.org
Date 2011-12-08 15:16:54 -0800 (Thu, 08 Dec 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=74005
fix unaligned access memory in generatePatternCharacterOnce function
for SH4 platforms.
Patch by Thouraya ANDOLSI thouraya.ando...@st.com on 2011-12-08
Reviewed by Gavin Barraclough.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load16Unaligned):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Unaligned):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load16Unaligned):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::lshift32):
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::load16):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::branch8):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load16Unaligned):
* jit/JIT.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (102388 => 102389)
--- trunk/Source/_javascript_Core/ChangeLog 2011-12-08 23:06:15 UTC (rev 102388)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-12-08 23:16:54 UTC (rev 102389)
@@ -1,3 +1,29 @@
+2011-12-08 Thouraya ANDOLSI thouraya.ando...@st.com
+
+https://bugs.webkit.org/show_bug.cgi?id=74005
+fix unaligned access memory in generatePatternCharacterOnce function
+for SH4 platforms.
+
+Reviewed by Gavin Barraclough.
+
+* assembler/MacroAssemblerARM.h:
+(JSC::MacroAssemblerARM::load16Unaligned):
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::load16Unaligned):
+* assembler/MacroAssemblerMIPS.h:
+(JSC::MacroAssemblerMIPS::load16Unaligned):
+* assembler/MacroAssemblerSH4.h:
+(JSC::MacroAssemblerSH4::lshift32):
+(JSC::MacroAssemblerSH4::load8):
+(JSC::MacroAssemblerSH4::load16):
+(JSC::MacroAssemblerSH4::load16Unaligned):
+(JSC::MacroAssemblerSH4::branch8):
+* assembler/MacroAssemblerX86Common.h:
+(JSC::MacroAssemblerX86Common::load16Unaligned):
+* jit/JIT.h:
+* yarr/YarrJIT.cpp:
+(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
+
2011-12-08 Michael Saboff msab...@apple.com
Add 8 bit paths for StringTypeAdapter classes
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (102388 => 102389)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2011-12-08 23:06:15 UTC (rev 102388)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2011-12-08 23:16:54 UTC (rev 102389)
@@ -282,6 +282,11 @@
}
#endif
+void load16Unaligned(BaseIndex address, RegisterID dest)
+{
+load16(address, dest);
+}
+
DataLabel32 load32WithAddressOffsetPatch(Address address, RegisterID dest)
{
DataLabel32 dataLabel(this);
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (102388 => 102389)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2011-12-08 23:06:15 UTC (rev 102388)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2011-12-08 23:16:54 UTC (rev 102389)
@@ -575,6 +575,11 @@
load32(setupArmAddress(address), dest);
}
+void load16Unaligned(BaseIndex address, RegisterID dest)
+{
+load16(setupArmAddress(address), dest);
+}
+
void load32(const void* address, RegisterID dest)
{
move(TrustedImmPtr(address), addressTempRegister);
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h (102388 => 102389)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h 2011-12-08 23:06:15 UTC (rev 102388)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h 2011-12-08 23:16:54 UTC (rev 102389)
@@ -576,6 +576,11 @@
}
}
+void load16Unaligned(BaseIndex address, RegisterID dest)
+{
+load16(address, dest);
+}
+
void load32WithUnalignedHalfWords(BaseIndex address, RegisterID dest)
{
if (address.offset = -32768 address.offset = 32764
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h (102388 => 102389)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h 2011-12-08 23:06:15 UTC (rev 102388)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h 2011-12-08 23:16:54 UTC (rev 102389)
@@ -158,6 +158,14 @@
void lshift32(RegisterID shiftamount,
[webkit-changes] [102390] trunk/LayoutTests
Title: [102390] trunk/LayoutTests Revision 102390 Author t...@chromium.org Date 2011-12-08 15:38:27 -0800 (Thu, 08 Dec 2011) Log Message Mark tests added in r102388 as failing on Chromium. Fix the cross platform expected results for transitions/svg-transitions.html (the line number changed). * platform/chromium/test_expectations.txt: * transitions/svg-transitions-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/transitions/svg-transitions-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (102389 => 102390) --- trunk/LayoutTests/ChangeLog 2011-12-08 23:16:54 UTC (rev 102389) +++ trunk/LayoutTests/ChangeLog 2011-12-08 23:38:27 UTC (rev 102390) @@ -1,3 +1,11 @@ +2011-12-08 Tony Chang t...@chromium.org + +Mark tests added in r102388 as failing on Chromium. Fix the cross platform +expected results for transitions/svg-transitions.html (the line number changed). + +* platform/chromium/test_expectations.txt: +* transitions/svg-transitions-expected.txt: + 2011-12-08 Tim Horton timothy_hor...@apple.com Enable animations of CSS images using -webkit-cross-fade Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102389 => 102390) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-08 23:16:54 UTC (rev 102389) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-08 23:38:27 UTC (rev 102390) @@ -3809,3 +3809,12 @@ BUGWK74050 : compositing/reflections/nested-reflection-on-overflow.html = IMAGE PASS BUGWK74055 LEOPARD : fast/canvas/canvas-largedraws.html = TIMEOUT + +// New tests added in r102388, just needs a new baseline. +BUG_TONY : animations/cross-fade-background-image.html = PASS FAIL +BUG_TONY : animations/cross-fade-border-image-source.html = PASS FAIL +BUG_TONY : animations/cross-fade-list-style-image.html = PASS FAIL +BUG_TONY : animations/cross-fade-webkit-mask-box-image.html = PASS FAIL +BUG_TONY : animations/cross-fade-webkit-mask-image.html = PASS FAIL +BUG_TONY : transitions/cross-fade-background-image.html = PASS FAIL +BUG_TONY : transitions/cross-fade-border-image.html = PASS FAIL Modified: trunk/LayoutTests/transitions/svg-transitions-expected.txt (102389 => 102390) --- trunk/LayoutTests/transitions/svg-transitions-expected.txt 2011-12-08 23:16:54 UTC (rev 102389) +++ trunk/LayoutTests/transitions/svg-transitions-expected.txt 2011-12-08 23:38:27 UTC (rev 102390) @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 212: Failed to pause 'fill' transition on element 'rect7' +CONSOLE MESSAGE: line 239: Failed to pause 'fill' transition on element 'rect7' Example PASS - fill-opacity property for rect1 element at 1s saw something close to: 0.6 PASS - stroke-width property for rect1 element at 1s saw something close to: 3 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102391] trunk
Title: [102391] trunk
Revision 102391
Author commit-qu...@webkit.org
Date 2011-12-08 16:07:10 -0800 (Thu, 08 Dec 2011)
Log Message
Moving SVG elements on the page doesn't always erase element at the old position
https://bugs.webkit.org/show_bug.cgi?id=74002
Patch by Florin Malita fmal...@google.com on 2011-12-08
Reviewed by Darin Adler.
Source/WebCore:
Test: svg/repaint/container-repaint.svg
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
Save the old repaint bounds before updating the viewport.
LayoutTests:
* svg/repaint/container-repaint-expected.png: Added.
* svg/repaint/container-repaint-expected.txt: Added.
* svg/repaint/container-repaint.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp
Added Paths
trunk/LayoutTests/svg/repaint/container-repaint-expected.png
trunk/LayoutTests/svg/repaint/container-repaint-expected.txt
trunk/LayoutTests/svg/repaint/container-repaint.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (102390 => 102391)
--- trunk/LayoutTests/ChangeLog 2011-12-08 23:38:27 UTC (rev 102390)
+++ trunk/LayoutTests/ChangeLog 2011-12-09 00:07:10 UTC (rev 102391)
@@ -1,3 +1,14 @@
+2011-12-08 Florin Malita fmal...@google.com
+
+Moving SVG elements on the page doesn't always erase element at the old position
+https://bugs.webkit.org/show_bug.cgi?id=74002
+
+Reviewed by Darin Adler.
+
+* svg/repaint/container-repaint-expected.png: Added.
+* svg/repaint/container-repaint-expected.txt: Added.
+* svg/repaint/container-repaint.svg: Added.
+
2011-12-08 Tony Chang t...@chromium.org
Mark tests added in r102388 as failing on Chromium. Fix the cross platform
Added: trunk/LayoutTests/svg/repaint/container-repaint-expected.png (0 => 102391)
--- trunk/LayoutTests/svg/repaint/container-repaint-expected.png (rev 0)
+++ trunk/LayoutTests/svg/repaint/container-repaint-expected.png 2011-12-09 00:07:10 UTC (rev 102391)
@@ -0,0 +1,7 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum 8726a76158a12fb8ac8507e4ef7d34d5\xEB\xA6nE
+\xB7IDATx\x9C\xED\xD8\xC1 \x80@A\xCF\xC45\xF35
+\x87R\xC1\x9BY\xC7}\xF0\xD2\\xB3{ \xF0\xE7\xEE #\xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b
[webkit-changes] [102392] trunk
Title: [102392] trunk
Revision 102392
Author rn...@webkit.org
Date 2011-12-08 16:15:26 -0800 (Thu, 08 Dec 2011)
Log Message
Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden
https://bugs.webkit.org/show_bug.cgi?id=74126
Reviewed by Tony Chang.
The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment
pasted into textarea even though serialization algorithm in textarea doesn't handle block elements.
Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this
whole pre-rendering trick.
* editing/markup.cpp:
(WebCore::createFragmentFromText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/markup.cpp
Added Paths
trunk/LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea-expected.txt
trunk/LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea.html
Diff
Added: trunk/LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea-expected.txt (0 => 102392)
--- trunk/LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea-expected.txt 2011-12-09 00:15:26 UTC (rev 102392)
@@ -0,0 +1,4 @@
+This tests pasting into a textarea that starts with a line break that didn't initially have a renderer (display: none). WebKit should still be able to paste text with line breaks.
+
+
+PASS
Added: trunk/LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea.html (0 => 102392)
--- trunk/LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea.html (rev 0)
+++ trunk/LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea.html 2011-12-09 00:15:26 UTC (rev 102392)
@@ -0,0 +1,29 @@
+!DOCTYPE html
+html
+body
+pThis tests pasting into a textarea that starts with a line break that didn't initially have a renderer (display: none).
+WebKit should still be able to paste text with line breaks./p
+textarea id=test style=display: none cols=50 rows=10/textarea
+div id=log/div
+script type=text/_javascript_
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var textarea = document.querySelector('textarea');
+textarea.value = \nwebkit;
+textarea.style.display = ;
+
+textarea.focus();
+textarea.selectionStart = textarea.selectionEnd = 0;
+document.execCommand('insertHTML', false, 'hello\nworld\n');
+
+var expected = 'hello\nworld\nwebkit';
+if (textarea.value == expected)
+document.getElementById('log').innerText = 'PASS';
+else
+document.getElementById('log').innerText = 'FAILED: expected ' + expected + ' but got ' + textarea.value + '';
+
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (102391 => 102392)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 00:07:10 UTC (rev 102391)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 00:15:26 UTC (rev 102392)
@@ -1,3 +1,19 @@
+2011-12-08 Ryosuke Niwa rn...@webkit.org
+
+Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden
+https://bugs.webkit.org/show_bug.cgi?id=74126
+
+Reviewed by Tony Chang.
+
+The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment
+pasted into textarea even though serialization algorithm in textarea doesn't handle block elements.
+
+Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this
+whole pre-rendering trick.
+
+* editing/markup.cpp:
+(WebCore::createFragmentFromText):
+
2011-12-08 Florin Malita fmal...@google.com
Moving SVG elements on the page doesn't always erase element at the old position
Modified: trunk/Source/WebCore/editing/markup.cpp (102391 => 102392)
--- trunk/Source/WebCore/editing/markup.cpp 2011-12-09 00:07:10 UTC (rev 102391)
+++ trunk/Source/WebCore/editing/markup.cpp 2011-12-09 00:15:26 UTC (rev 102392)
@@ -49,6 +49,7 @@
#include HTMLBodyElement.h
#include HTMLElement.h
#include HTMLNames.h
+#include HTMLTextFormControlElement.h
#include KURL.h
#include MarkupAccumulator.h
#include Range.h
@@ -880,7 +881,8 @@
!block-hasTagName(bodyTag)
!block-hasTagName(htmlTag)
block != editableRootForPosition(context-startPosition());
-
+bool useLineBreak = enclosingTextFormControl(context-startPosition());
+
VectorString list;
string.split('\n', true, list); // true gets us empty strings in the list
size_t numLines = list.size();
@@ -891,7 +893,10 @@
if (s.isEmpty() i + 1 == numLines) {
// For last line, use the magic BR rather than a P.
element = createBreakElement(document);
-
[webkit-changes] [102393] trunk/Tools
Title: [102393] trunk/Tools
Revision 102393
Author dpra...@chromium.org
Date 2011-12-08 16:20:39 -0800 (Thu, 08 Dec 2011)
Log Message
create a SystemHost object for webkitpy to slim down the Host object
https://bugs.webkit.org/show_bug.cgi?id=72680
Reviewed by Eric Siedel.
This creates a SystemHost object that other objects that should
only have dependencies on functionality in webkitpy.common.system
can use; this will allow them to not require a full Host.
* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/common/host_mock.py:
* Scripts/webkitpy/common/system/systemhost.py: Added.
* Scripts/webkitpy/common/system/systemhost_mock.py: Added.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/host.py
trunk/Tools/Scripts/webkitpy/common/host_mock.py
Added Paths
trunk/Tools/Scripts/webkitpy/common/system/systemhost.py
trunk/Tools/Scripts/webkitpy/common/system/systemhost_mock.py
Diff
Modified: trunk/Tools/ChangeLog (102392 => 102393)
--- trunk/Tools/ChangeLog 2011-12-09 00:15:26 UTC (rev 102392)
+++ trunk/Tools/ChangeLog 2011-12-09 00:20:39 UTC (rev 102393)
@@ -1,3 +1,19 @@
+2011-12-08 Dirk Pranke dpra...@chromium.org
+
+create a SystemHost object for webkitpy to slim down the Host object
+https://bugs.webkit.org/show_bug.cgi?id=72680
+
+Reviewed by Eric Siedel.
+
+This creates a SystemHost object that other objects that should
+only have dependencies on functionality in webkitpy.common.system
+can use; this will allow them to not require a full Host.
+
+* Scripts/webkitpy/common/host.py:
+* Scripts/webkitpy/common/host_mock.py:
+* Scripts/webkitpy/common/system/systemhost.py: Added.
+* Scripts/webkitpy/common/system/systemhost_mock.py: Added.
+
2011-12-08 Chris Fleizach cfleiz...@apple.com
AX: platform/mac/accessibility/search-with-frames.html crashes
Modified: trunk/Tools/Scripts/webkitpy/common/host.py (102392 => 102393)
--- trunk/Tools/Scripts/webkitpy/common/host.py 2011-12-09 00:15:26 UTC (rev 102392)
+++ trunk/Tools/Scripts/webkitpy/common/host.py 2011-12-09 00:20:39 UTC (rev 102393)
@@ -36,8 +36,7 @@
from webkitpy.common.memoized import memoized
from webkitpy.common.net import bugzilla, buildbot, web
from webkitpy.common.net.buildbot.chromiumbuildbot import ChromiumBuildBot
-from webkitpy.common.system import executive, filesystem, platforminfo, user, workspace
-from webkitpy.common.system.environment import Environment
+from webkitpy.common.system.systemhost import SystemHost
from webkitpy.common.watchlist.watchlistloader import WatchListLoader
from webkitpy.layout_tests.port.factory import PortFactory
@@ -45,15 +44,9 @@
_log = logging.getLogger(__name__)
-class Host(object):
+class Host(SystemHost):
def __init__(self):
-# These basic environment abstractions should be a separate lower-level object.
-# Alternatively the rest of the objects in Host should just move up to a higher abstraction.
-self.executive = executive.Executive()
-self.filesystem = filesystem.FileSystem()
-self.user = user.User()
-self.platform = platforminfo.PlatformInfo(self.executive)
-self.workspace = workspace.Workspace(self.filesystem, self.executive)
+SystemHost.__init__(self)
self.web = web.Web()
# FIXME: Checkout should own the scm object.
@@ -112,9 +105,6 @@
except OSError, e:
_log.debug('Failed to engage svn.bat Windows hack.')
-def copy_current_environment(self):
-return Environment(os.environ.copy())
-
def _initialize_scm(self, patch_directories=None):
if sys.platform == win32:
self._engage_awesome_windows_hacks()
Modified: trunk/Tools/Scripts/webkitpy/common/host_mock.py (102392 => 102393)
--- trunk/Tools/Scripts/webkitpy/common/host_mock.py 2011-12-09 00:15:26 UTC (rev 102392)
+++ trunk/Tools/Scripts/webkitpy/common/host_mock.py 2011-12-09 00:20:39 UTC (rev 102393)
@@ -31,31 +31,23 @@
from webkitpy.common.net.bugzilla.bugzilla_mock import MockBugzilla
from webkitpy.common.net.buildbot.buildbot_mock import MockBuildBot
from webkitpy.common.net.web_mock import MockWeb
-from webkitpy.common.system.environment import Environment
-from webkitpy.common.system.executive_mock import MockExecutive
-from webkitpy.common.system.filesystem_mock import MockFileSystem
-from webkitpy.common.system.platforminfo_mock import MockPlatformInfo
-from webkitpy.common.system.user_mock import MockUser
-from webkitpy.common.system.workspace_mock import MockWorkspace
+from webkitpy.common.system.systemhost_mock import MockSystemHost
from webkitpy.common.watchlist.watchlist_mock import MockWatchList
# New-style ports need to move down into webkitpy.common.
from webkitpy.layout_tests.port.factory import PortFactory
-class MockHost(object):
+class MockHost(MockSystemHost):
def __init__(self, log_executive=False,
[webkit-changes] [102394] trunk/Source/WebCore
Title: [102394] trunk/Source/WebCore Revision 102394 Author senorbla...@chromium.org Date 2011-12-08 16:22:08 -0800 (Thu, 08 Dec 2011) Log Message [chromium] Add CSS_FILTERS custom binding file to WebCore.gypi. https://bugs.webkit.org/show_bug.cgi?id=74091 Reviewed by Adam Barth. If it builds, you're happy. * WebCore.gypi: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi Diff Modified: trunk/Source/WebCore/ChangeLog (102393 => 102394) --- trunk/Source/WebCore/ChangeLog 2011-12-09 00:20:39 UTC (rev 102393) +++ trunk/Source/WebCore/ChangeLog 2011-12-09 00:22:08 UTC (rev 102394) @@ -1,3 +1,14 @@ +2011-12-08 Stephen White senorbla...@chromium.org + +[chromium] Add CSS_FILTERS custom binding file to WebCore.gypi. +https://bugs.webkit.org/show_bug.cgi?id=74091 + +Reviewed by Adam Barth. + +If it builds, you're happy. + +* WebCore.gypi: + 2011-12-08 Ryosuke Niwa rn...@webkit.org Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden Modified: trunk/Source/WebCore/WebCore.gypi (102393 => 102394) --- trunk/Source/WebCore/WebCore.gypi 2011-12-09 00:20:39 UTC (rev 102393) +++ trunk/Source/WebCore/WebCore.gypi 2011-12-09 00:22:08 UTC (rev 102394) @@ -2264,6 +2264,7 @@ 'bindings/v8/custom/V8Uint8ArrayCustom.cpp', 'bindings/v8/custom/V8WebGLRenderingContextCustom.cpp', 'bindings/v8/custom/V8WebKitAnimationCustom.cpp', +'bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp', 'bindings/v8/custom/V8WebKitMutationObserverCustom.cpp', 'bindings/v8/custom/V8WebKitPointConstructor.cpp', 'bindings/v8/custom/V8WebSocketCustom.cpp', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102395] trunk/Source
Title: [102395] trunk/Source
Revision 102395
Author commit-qu...@webkit.org
Date 2011-12-08 16:37:47 -0800 (Thu, 08 Dec 2011)
Log Message
[chromium] Layer contents scale change should trigger invalidation
https://bugs.webkit.org/show_bug.cgi?id=74086
When the contents scale of a layer is changed, the entire contents of
the layer should be marked dirty.
Patch by Sami Kyostila skyos...@google.com on 2011-12-08
Reviewed by James Robinson.
Source/WebCore:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setContentsScale):
Source/WebKit/chromium:
* tests/LayerChromiumTest.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (102394 => 102395)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 00:22:08 UTC (rev 102394)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 00:37:47 UTC (rev 102395)
@@ -1,3 +1,17 @@
+2011-12-08 Sami Kyostila skyos...@google.com
+
+[chromium] Layer contents scale change should trigger invalidation
+
+https://bugs.webkit.org/show_bug.cgi?id=74086
+
+When the contents scale of a layer is changed, the entire contents of
+the layer should be marked dirty.
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/LayerChromium.cpp:
+(WebCore::LayerChromium::setContentsScale):
+
2011-12-08 Stephen White senorbla...@chromium.org
[chromium] Add CSS_FILTERS custom binding file to WebCore.gypi.
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp (102394 => 102395)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2011-12-09 00:22:08 UTC (rev 102394)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2011-12-09 00:37:47 UTC (rev 102395)
@@ -425,9 +425,10 @@
void LayerChromium::setContentsScale(float contentsScale)
{
-if (!needsContentsScale())
+if (!needsContentsScale() || m_contentsScale == contentsScale)
return;
m_contentsScale = contentsScale;
+setNeedsDisplay();
}
void LayerChromium::createRenderSurface()
Modified: trunk/Source/WebKit/chromium/ChangeLog (102394 => 102395)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-09 00:22:08 UTC (rev 102394)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-09 00:37:47 UTC (rev 102395)
@@ -1,3 +1,16 @@
+2011-12-08 Sami Kyostila skyos...@google.com
+
+[chromium] Layer contents scale change should trigger invalidation
+
+https://bugs.webkit.org/show_bug.cgi?id=74086
+
+When the contents scale of a layer is changed, the entire contents of
+the layer should be marked dirty.
+
+Reviewed by James Robinson.
+
+* tests/LayerChromiumTest.cpp:
+
2011-12-08 Dana Jansens dan...@chromium.org
[chromium] Set opaque() for VideoLayerChromium
Modified: trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp (102394 => 102395)
--- trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp 2011-12-09 00:22:08 UTC (rev 102394)
+++ trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp 2011-12-09 00:37:47 UTC (rev 102395)
@@ -700,4 +700,37 @@
nonCompositedContentHost-setViewport(IntSize(30, 30), IntSize(20, 20), IntPoint(10, 10), 1);
}
+class LayerChromiumWithContentScaling : public LayerChromium {
+public:
+explicit LayerChromiumWithContentScaling(CCLayerDelegate* delegate)
+: LayerChromium(delegate)
+{
+}
+
+virtual bool needsContentsScale() const
+{
+return true;
+}
+
+void resetNeedsDisplay()
+{
+m_needsDisplay = false;
+}
+};
+
+TEST_F(LayerChromiumTest, checkContentsScaleChangeTriggersNeedsDisplay)
+{
+MockLayerDelegate mockDelegate;
+RefPtrLayerChromiumWithContentScaling testLayer = adoptRef(new LayerChromiumWithContentScaling(mockDelegate));
+
+IntSize testBounds = IntSize(320, 240);
+EXECUTE_AND_VERIFY_NOTIFY_SYNC_BEHAVIOR(mockDelegate, 1, testLayer-setBounds(testBounds));
+
+testLayer-resetNeedsDisplay();
+EXPECT_FALSE(testLayer-needsDisplay());
+
+EXECUTE_AND_VERIFY_NOTIFY_SYNC_BEHAVIOR(mockDelegate, 1, testLayer-setContentsScale(testLayer-contentsScale() + 1.f));
+EXPECT_TRUE(testLayer-needsDisplay());
+}
+
} // namespace
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102397] trunk/Source
Title: [102397] trunk/Source Revision 102397 Author commit-qu...@webkit.org Date 2011-12-08 16:42:00 -0800 (Thu, 08 Dec 2011) Log Message [chromium] Move NonCompositedContentHost to WebKit https://bugs.webkit.org/show_bug.cgi?id=74047 Patch by James Robinson jam...@chromium.org on 2011-12-08 Reviewed by Kenneth Russell. Source/WebCore: Updates WebCore.gypi to remove files no longer within WebCore and removes unused forward declaration and include from LayerRendererChromium. * WebCore.gypi: * platform/graphics/chromium/LayerRendererChromium.cpp: * platform/graphics/chromium/LayerRendererChromium.h: Source/WebKit/chromium: Moves NonCompositedContentHost into WebKit/chromium/src. This class is a helper class designed to make it easier for WebViewImpl to interface with the compositor. The compositor proper should not depend on this class, and other clients of the compositor do not need this functionality. Follow-up patches will transition this code from using compositor-internal interfaces directly to using higher-level interfaces like the WebKit platform APIs. This patch simply does a file mv and updates namespaces to keep things simpler. Refactor only and covered by several unit tests. * WebKit.gyp: * src/NonCompositedContentHost.cpp: Renamed from Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp. (WebKit::NonCompositedContentHost::NonCompositedContentHost): (WebKit::NonCompositedContentHost::~NonCompositedContentHost): (WebKit::NonCompositedContentHost::setBackgroundColor): (WebKit::NonCompositedContentHost::setScrollLayer): (WebKit::NonCompositedContentHost::setViewport): (WebKit::NonCompositedContentHost::scrollLayer): (WebKit::NonCompositedContentHost::protectVisibleTileTextures): (WebKit::NonCompositedContentHost::invalidateRect): (WebKit::NonCompositedContentHost::notifyAnimationStarted): (WebKit::NonCompositedContentHost::notifySyncRequired): (WebKit::NonCompositedContentHost::paintContents): (WebKit::NonCompositedContentHost::showDebugBorders): (WebKit::NonCompositedContentHost::showRepaintCounter): * src/NonCompositedContentHost.h: Renamed from Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.h. (WebKit::NonCompositedContentHost::create): (WebKit::NonCompositedContentHost::topLevelRootLayer): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::nonCompositedContentHost): * src/WebViewImpl.h: * tests/LayerChromiumTest.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/src/WebViewImpl.cpp trunk/Source/WebKit/chromium/src/WebViewImpl.h trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp Added Paths trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp trunk/Source/WebKit/chromium/src/NonCompositedContentHost.h Removed Paths trunk/Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp trunk/Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.h Diff Modified: trunk/Source/WebCore/ChangeLog (102396 => 102397) --- trunk/Source/WebCore/ChangeLog 2011-12-09 00:41:55 UTC (rev 102396) +++ trunk/Source/WebCore/ChangeLog 2011-12-09 00:42:00 UTC (rev 102397) @@ -1,3 +1,17 @@ +2011-12-08 James Robinson jam...@chromium.org + +[chromium] Move NonCompositedContentHost to WebKit +https://bugs.webkit.org/show_bug.cgi?id=74047 + +Reviewed by Kenneth Russell. + +Updates WebCore.gypi to remove files no longer within WebCore and removes unused forward declaration and include +from LayerRendererChromium. + +* WebCore.gypi: +* platform/graphics/chromium/LayerRendererChromium.cpp: +* platform/graphics/chromium/LayerRendererChromium.h: + 2011-12-08 Sami Kyostila skyos...@google.com [chromium] Layer contents scale change should trigger invalidation Modified: trunk/Source/WebCore/WebCore.gypi (102396 => 102397) --- trunk/Source/WebCore/WebCore.gypi 2011-12-09 00:41:55 UTC (rev 102396) +++ trunk/Source/WebCore/WebCore.gypi 2011-12-09 00:42:00 UTC (rev 102397) @@ -3544,8 +3544,6 @@ 'platform/graphics/chromium/LayerTextureSubImage.cpp', 'platform/graphics/chromium/LayerTextureSubImage.h', 'platform/graphics/chromium/LayerTextureUpdater.h', -'platform/graphics/chromium/NonCompositedContentHost.cpp', -'platform/graphics/chromium/NonCompositedContentHost.h', 'platform/graphics/chromium/MediaPlayerPrivateChromium.h', 'platform/graphics/chromium/PlatformCanvas.cpp', 'platform/graphics/chromium/PlatformCanvas.h', Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (102396 => 102397) ---
[webkit-changes] [102396] trunk/LayoutTests
Title: [102396] trunk/LayoutTests
Revision 102396
Author commit-qu...@webkit.org
Date 2011-12-08 16:41:55 -0800 (Thu, 08 Dec 2011)
Log Message
Fix fast/css/hover-active-drag.html on Mac
https://bugs.webkit.org/show_bug.cgi?id=74046
Patch by Jeremy Apthorp jere...@chromium.org on 2011-12-08
Reviewed by Darin Adler.
* fast/css/hover-active-drag.html:
* platform/chromium/fast/css/hover-active-drag-expected.txt: Removed.
* platform/mac/fast/css/hover-active-drag-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/hover-active-drag.html
Removed Paths
trunk/LayoutTests/platform/chromium/fast/css/hover-active-drag-expected.txt
trunk/LayoutTests/platform/mac/fast/css/hover-active-drag-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (102395 => 102396)
--- trunk/LayoutTests/ChangeLog 2011-12-09 00:37:47 UTC (rev 102395)
+++ trunk/LayoutTests/ChangeLog 2011-12-09 00:41:55 UTC (rev 102396)
@@ -1,3 +1,14 @@
+2011-12-08 Jeremy Apthorp jere...@chromium.org
+
+Fix fast/css/hover-active-drag.html on Mac
+https://bugs.webkit.org/show_bug.cgi?id=74046
+
+Reviewed by Darin Adler.
+
+* fast/css/hover-active-drag.html:
+* platform/chromium/fast/css/hover-active-drag-expected.txt: Removed.
+* platform/mac/fast/css/hover-active-drag-expected.txt: Removed.
+
2011-12-08 Florin Malita fmal...@google.com
Moving SVG elements on the page doesn't always erase element at the old position
Modified: trunk/LayoutTests/fast/css/hover-active-drag.html (102395 => 102396)
--- trunk/LayoutTests/fast/css/hover-active-drag.html 2011-12-09 00:37:47 UTC (rev 102395)
+++ trunk/LayoutTests/fast/css/hover-active-drag.html 2011-12-09 00:41:55 UTC (rev 102396)
@@ -20,9 +20,6 @@
script src=""
script
- function backgroundOf(element) {
-return getComputedStyle(element, null).getPropertyValue(background-color)
- }
function shouldHaveBackground(element, bg) {
background = "" null).getPropertyValue(background-color)
shouldBeEqualToString('background', bg)
@@ -35,22 +32,29 @@
eventSender.dragMode = false;
eventSender.mouseMoveTo(50, 50)
+eventSender.leapForward(50)
+eventSender.mouseMoveTo(60, 50)
+eventSender.leapForward(50)
shouldHaveBackground(box, 'rgb(255, 0, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
eventSender.mouseDown()
+eventSender.leapForward(50)
shouldHaveBackground(box, 'rgb(255, 255, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
eventSender.mouseMoveTo(50, 150)
+eventSender.leapForward(50)
shouldHaveBackground(box, 'rgb(0, 255, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
eventSender.mouseMoveTo(400, 50)
+eventSender.leapForward(50)
shouldHaveBackground(box, 'rgb(0, 255, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
eventSender.mouseUp()
+eventSender.leapForward(50)
shouldHaveBackground(box, 'rgb(0, 0, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
}
Deleted: trunk/LayoutTests/platform/chromium/fast/css/hover-active-drag-expected.txt (102395 => 102396)
--- trunk/LayoutTests/platform/chromium/fast/css/hover-active-drag-expected.txt 2011-12-09 00:37:47 UTC (rev 102395)
+++ trunk/LayoutTests/platform/chromium/fast/css/hover-active-drag-expected.txt 2011-12-09 00:41:55 UTC (rev 102396)
@@ -1,20 +0,0 @@
-Dragging out of an element should cause it to lose :hover
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-PASS background is rgb(255, 0, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(255, 255, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 255, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 255, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 0, 0)
-
-
-
-
-
-
Deleted: trunk/LayoutTests/platform/mac/fast/css/hover-active-drag-expected.txt (102395 => 102396)
--- trunk/LayoutTests/platform/mac/fast/css/hover-active-drag-expected.txt 2011-12-09 00:37:47 UTC (rev 102395)
+++ trunk/LayoutTests/platform/mac/fast/css/hover-active-drag-expected.txt 2011-12-09 00:41:55 UTC (rev 102396)
@@ -1,20 +0,0 @@
-Dragging out of an element should cause it to lose :hover
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-FAIL background should be rgb(255, 0, 0). Was rgb(0, 0, 0).
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(255, 255, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 255, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 255, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 0, 0)
-
-
-
-
-
-
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102398] trunk/Source/WebCore
Title: [102398] trunk/Source/WebCore
Revision 102398
Author ander...@apple.com
Date 2011-12-08 16:52:01 -0800 (Thu, 08 Dec 2011)
Log Message
Add a scrollbarPainterForScrollbar helper function
https://bugs.webkit.org/show_bug.cgi?id=74139
Reviewed by Sam Weinig.
* platform/mac/ScrollAnimatorMac.mm:
(macScrollbarTheme):
(scrollbarPainterForScrollbar):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (102397 => 102398)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 00:42:00 UTC (rev 102397)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 00:52:01 UTC (rev 102398)
@@ -1,3 +1,20 @@
+2011-12-08 Anders Carlsson ander...@apple.com
+
+Add a scrollbarPainterForScrollbar helper function
+https://bugs.webkit.org/show_bug.cgi?id=74139
+
+Reviewed by Sam Weinig.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(macScrollbarTheme):
+(scrollbarPainterForScrollbar):
+(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
+(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
+(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
+(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
+(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
+(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
+
2011-12-08 James Robinson jam...@chromium.org
[chromium] Move NonCompositedContentHost to WebKit
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102397 => 102398)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-09 00:42:00 UTC (rev 102397)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-09 00:52:01 UTC (rev 102398)
@@ -52,6 +52,20 @@
static bool globalSupportsUIStateTransitionProgress = [NSClassFromString(@NSScrollerImp) instancesRespondToSelector:@selector(mouseEnteredScroller)];
return globalSupportsUIStateTransitionProgress;
}
+
+static ScrollbarThemeMac* macScrollbarTheme()
+{
+ScrollbarTheme* scrollbarTheme = ScrollbarTheme::theme();
+return !scrollbarTheme-isMockTheme() ? static_castScrollbarThemeMac*(scrollbarTheme) : 0;
+}
+
+static ScrollbarPainter scrollbarPainterForScrollbar(Scrollbar* scrollbar)
+{
+if (ScrollbarThemeMac* scrollbarTheme = macScrollbarTheme())
+return scrollbarTheme-painterForScrollbar(scrollbar);
+
+return nil;
+}
#endif
@interface NSObject (ScrollAnimationHelperDetails)
@@ -557,14 +571,6 @@
return adoptPtr(new ScrollAnimatorMac(scrollableArea));
}
-#if USE(SCROLLBAR_PAINTER)
-static ScrollbarThemeMac* macScrollbarTheme()
-{
-ScrollbarTheme* scrollbarTheme = ScrollbarTheme::theme();
-return !scrollbarTheme-isMockTheme() ? static_castScrollbarThemeMac*(scrollbarTheme) : 0;
-}
-#endif
-
ScrollAnimatorMac::ScrollAnimatorMac(ScrollableArea* scrollableArea)
: ScrollAnimator(scrollableArea)
#if USE(SCROLLBAR_PAINTER)
@@ -765,10 +771,8 @@
#if USE(SCROLLBAR_PAINTER)
if (!supportsUIStateTransitionProgress())
return;
-if (ScrollbarThemeMac* theme = macScrollbarTheme()) {
-ScrollbarPainter painter = theme-painterForScrollbar(scrollbar);
+if (ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar))
[painter mouseEnteredScroller];
-}
#else
UNUSED_PARAM(scrollbar);
#endif
@@ -781,10 +785,8 @@
#if USE(SCROLLBAR_PAINTER)
if (!supportsUIStateTransitionProgress())
return;
-if (ScrollbarThemeMac* theme = macScrollbarTheme()) {
-ScrollbarPainter painter = theme-painterForScrollbar(scrollbar);
+if (ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar))
[painter mouseExitedScroller];
-}
#else
UNUSED_PARAM(scrollbar);
#endif
@@ -856,8 +858,7 @@
void ScrollAnimatorMac::didAddVerticalScrollbar(Scrollbar* scrollbar)
{
#if USE(SCROLLBAR_PAINTER)
-if (ScrollbarThemeMac* theme = macScrollbarTheme()) {
-ScrollbarPainter painter = theme-painterForScrollbar(scrollbar);
+if (ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar)) {
[painter setDelegate:m_scrollbarPainterDelegate.get()];
[m_scrollbarPainterController.get() setVerticalScrollerImp:painter];
if (scrollableArea()-inLiveResize())
@@ -871,8 +872,7 @@
void ScrollAnimatorMac::willRemoveVerticalScrollbar(Scrollbar* scrollbar)
{
#if USE(SCROLLBAR_PAINTER)
-if (ScrollbarThemeMac* theme = macScrollbarTheme()) {
-ScrollbarPainter painter = theme-painterForScrollbar(scrollbar);
+if (ScrollbarPainter painter =
[webkit-changes] [102399] trunk/LayoutTests
Title: [102399] trunk/LayoutTests Revision 102399 Author jchaffr...@webkit.org Date 2011-12-08 16:58:48 -0800 (Thu, 08 Dec 2011) Log Message REGRESSION: Changing disabled state of a textarea does not do a repaint https://bugs.webkit.org/show_bug.cgi?id=23789 Reviewed by Darin Adler. The bug got fixed (I did not bisect to find out when) thus landing the test case converted to a repaint test and made cross-platform. * fast/repaint/textarea-set-disabled-expected.png: Added. * fast/repaint/textarea-set-disabled-expected.txt: Added. * fast/repaint/textarea-set-disabled.html: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/fast/repaint/textarea-set-disabled-expected.png trunk/LayoutTests/fast/repaint/textarea-set-disabled-expected.txt trunk/LayoutTests/fast/repaint/textarea-set-disabled.html Diff Modified: trunk/LayoutTests/ChangeLog (102398 => 102399) --- trunk/LayoutTests/ChangeLog 2011-12-09 00:52:01 UTC (rev 102398) +++ trunk/LayoutTests/ChangeLog 2011-12-09 00:58:48 UTC (rev 102399) @@ -1,3 +1,17 @@ +2011-12-08 Julien Chaffraix jchaffr...@webkit.org + +REGRESSION: Changing disabled state of a textarea does not do a repaint +https://bugs.webkit.org/show_bug.cgi?id=23789 + +Reviewed by Darin Adler. + +The bug got fixed (I did not bisect to find out when) thus landing +the test case converted to a repaint test and made cross-platform. + +* fast/repaint/textarea-set-disabled-expected.png: Added. +* fast/repaint/textarea-set-disabled-expected.txt: Added. +* fast/repaint/textarea-set-disabled.html: Added. + 2011-12-08 Jeremy Apthorp jere...@chromium.org Fix fast/css/hover-active-drag.html on Mac Added: trunk/LayoutTests/fast/repaint/textarea-set-disabled-expected.png (0 => 102399) --- trunk/LayoutTests/fast/repaint/textarea-set-disabled-expected.png (rev 0) +++ trunk/LayoutTests/fast/repaint/textarea-set-disabled-expected.png 2011-12-09 00:58:48 UTC (rev 102399) @@ -0,0 +1,7 @@ +\x89PNG + + +IHDR X ' )tEXtchecksum 5ce706916a0e96cde67973ad1f2e1c93\xB90;\xBC +\xDCIDATx\x9C\xEDܱ +\x83@A\xB0h\x81\xCC}]\x8D\xF4\xE5\x8C\\x8EV \x9Dg\xD2K^\xB8җn c, t^O \x98\x8D\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\xD8v\xF5p ǝ;\xE3w1 \xF8g\x97\x81\xB5,\xCBy~n\xDB1\x93}?= x\x92! @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @l\xFB\xF1\xB6\xEF\xEF\xDBv Lc
[webkit-changes] [102400] trunk
Title: [102400] trunk
Revision 102400
Author commit-qu...@webkit.org
Date 2011-12-08 17:04:51 -0800 (Thu, 08 Dec 2011)
Log Message
[Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
https://bugs.webkit.org/show_bug.cgi?id=74017
Source/WebCore:
Patch by David Reveman reve...@chromium.org on 2011-12-08
Reviewed by James Robinson.
Add per-tile drawing to page settings.
No new tests.
* page/Settings.h:
(WebCore::Settings::setPerTileDrawingEnabled):
(WebCore::Settings::perTileDrawingEnabled):
* testing/Internals.cpp:
(WebCore::Internals::setPerTileDrawingEnabled):
* testing/Internals.h:
Source/WebKit/chromium:
Patch by David Reveman reve...@chromium.org on 2011-12-08
Reviewed by James Robinson.
Add WebSettings::setAcceleratedPaintingEnabled to public API.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setAcceleratedPaintingEnabled):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
* src/WebSettingsImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
Tools:
Patch by David Reveman reve...@chromium.org on 2011-12-08
Reviewed by James Robinson.
Add support for command line flag enable-per-tile-painting in DumpRenderTree.
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setAcceleratedPaintingEnabled):
(TestShell::setPerTilePaintingEnabled):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver._wrapper_options):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.h
trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp
trunk/Tools/DumpRenderTree/chromium/WebPreferences.h
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
Diff
Modified: trunk/Source/WebCore/ChangeLog (102399 => 102400)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 00:58:48 UTC (rev 102399)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 01:04:51 UTC (rev 102400)
@@ -1,3 +1,21 @@
+2011-12-08 David Reveman reve...@chromium.org
+
+[Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
+https://bugs.webkit.org/show_bug.cgi?id=74017
+
+Reviewed by James Robinson.
+
+Add per-tile drawing to page settings.
+
+No new tests.
+
+* page/Settings.h:
+(WebCore::Settings::setPerTileDrawingEnabled):
+(WebCore::Settings::perTileDrawingEnabled):
+* testing/Internals.cpp:
+(WebCore::Internals::setPerTileDrawingEnabled):
+* testing/Internals.h:
+
2011-12-08 Anders Carlsson ander...@apple.com
Add a scrollbarPainterForScrollbar helper function
Modified: trunk/Source/WebCore/page/Settings.h (102399 => 102400)
--- trunk/Source/WebCore/page/Settings.h 2011-12-09 00:58:48 UTC (rev 102399)
+++ trunk/Source/WebCore/page/Settings.h 2011-12-09 01:04:51 UTC (rev 102400)
@@ -500,6 +500,9 @@
bool shouldDisplayTextDescriptions() const { return m_shouldDisplayTextDescriptions; }
#endif
+void setPerTileDrawingEnabled(bool enabled) { m_perTileDrawingEnabled = enabled; }
+bool perTileDrawingEnabled() const { return m_perTileDrawingEnabled; }
+
private:
Page* m_page;
@@ -632,6 +635,7 @@
bool m_shouldDisplayCaptions : 1;
bool m_shouldDisplayTextDescriptions : 1;
#endif
+bool m_perTileDrawingEnabled : 1;
TimerSettings m_loadsImagesAutomaticallyTimer;
void loadsImagesAutomaticallyTimerFired(TimerSettings*);
Modified: trunk/Source/WebCore/testing/Internals.cpp (102399 => 102400)
--- trunk/Source/WebCore/testing/Internals.cpp 2011-12-09 00:58:48 UTC (rev 102399)
+++ trunk/Source/WebCore/testing/Internals.cpp 2011-12-09 01:04:51 UTC (rev 102400)
@@ -651,4 +651,14 @@
return checker-lastProcessedSequence();
}
+void Internals::setPerTileDrawingEnabled(Document* document, bool enabled, ExceptionCode ec)
+{
+if (!document ||
[webkit-changes] [102401] trunk/Source/WebCore
Title: [102401] trunk/Source/WebCore
Revision 102401
Author ander...@apple.com
Date 2011-12-08 17:11:02 -0800 (Thu, 08 Dec 2011)
Log Message
Create one WebScrollbarPainterDelegate for each scrollbar
https://bugs.webkit.org/show_bug.cgi?id=74142
Reviewed by Sam Weinig.
Create and destroy WebScrollbarPainterDelegate objects as scrollbars come and go.
This is a step towards simplifying the WebScrollbarPainterDelegate object.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (102400 => 102401)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 01:04:51 UTC (rev 102400)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 01:11:02 UTC (rev 102401)
@@ -1,3 +1,23 @@
+2011-12-08 Anders Carlsson ander...@apple.com
+
+Create one WebScrollbarPainterDelegate for each scrollbar
+https://bugs.webkit.org/show_bug.cgi?id=74142
+
+Reviewed by Sam Weinig.
+
+Create and destroy WebScrollbarPainterDelegate objects as scrollbars come and go.
+This is a step towards simplifying the WebScrollbarPainterDelegate object.
+
+* platform/mac/ScrollAnimatorMac.h:
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
+(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
+(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
+(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
+(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
+(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
+(WebCore::ScrollAnimatorMac::cancelAnimations):
+
2011-12-08 David Reveman reve...@chromium.org
[Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h (102400 => 102401)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h 2011-12-09 01:04:51 UTC (rev 102400)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h 2011-12-09 01:11:02 UTC (rev 102401)
@@ -106,7 +106,8 @@
#if USE(SCROLLBAR_PAINTER)
RetainPtrScrollbarPainterController m_scrollbarPainterController;
RetainPtrWebScrollbarPainterControllerDelegate m_scrollbarPainterControllerDelegate;
-RetainPtrWebScrollbarPainterDelegate m_scrollbarPainterDelegate;
+RetainPtrWebScrollbarPainterDelegate m_horizontalScrollbarPainterDelegate;
+RetainPtrWebScrollbarPainterDelegate m_verticalScrollbarPainterDelegate;
void initialScrollbarPaintTimerFired(TimerScrollAnimatorMac*);
TimerScrollAnimatorMac m_initialScrollbarPaintTimer;
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102400 => 102401)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-09 01:04:51 UTC (rev 102400)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-09 01:11:02 UTC (rev 102401)
@@ -592,8 +592,6 @@
m_scrollbarPainterController = [[[NSClassFromString(@NSScrollerImpPair) alloc] init] autorelease];
[m_scrollbarPainterController.get() setDelegate:m_scrollbarPainterControllerDelegate.get()];
[m_scrollbarPainterController.get() setScrollerStyle:wkRecommendedScrollerStyle()];
-
-m_scrollbarPainterDelegate.adoptNS([[WebScrollbarPainterDelegate alloc] initWithScrollAnimator:this]);
#endif
}
@@ -603,7 +601,8 @@
BEGIN_BLOCK_OBJC_EXCEPTIONS;
[m_scrollbarPainterControllerDelegate.get() scrollAnimatorDestroyed];
[m_scrollbarPainterController.get() setDelegate:nil];
-[m_scrollbarPainterDelegate.get() scrollAnimatorDestroyed];
+[m_horizontalScrollbarPainterDelegate.get() scrollAnimatorDestroyed];
+[m_verticalScrollbarPainterDelegate.get() scrollAnimatorDestroyed];
[m_scrollAnimationHelperDelegate.get() scrollAnimatorDestroyed];
END_BLOCK_OBJC_EXCEPTIONS;
#endif
@@ -858,12 +857,18 @@
void ScrollAnimatorMac::didAddVerticalScrollbar(Scrollbar* scrollbar)
{
#if USE(SCROLLBAR_PAINTER)
-if (ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar)) {
-[painter setDelegate:m_scrollbarPainterDelegate.get()];
-[m_scrollbarPainterController.get() setVerticalScrollerImp:painter];
-if (scrollableArea()-inLiveResize())
-[painter setKnobAlpha:1];
-}
+ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar);
+if (!painter)
+
[webkit-changes] [102402] trunk/LayoutTests
Title: [102402] trunk/LayoutTests
Revision 102402
Author commit-qu...@webkit.org
Date 2011-12-08 17:13:29 -0800 (Thu, 08 Dec 2011)
Log Message
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=74116
Patch by Jacob Goldstein jac...@adobe.com on 2011-12-08
Reviewed by Darin Adler.
* fast/regions/webkit-flow-renderer-expected.html: Added.
* fast/regions/webkit-flow-renderer-layer-expected.html: Added.
* fast/regions/webkit-flow-renderer-nested-expected.html: Added.
* platform/efl/fast/regions/webkit-flow-renderer-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-renderer-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-expected.png: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/regions/webkit-flow-renderer-expected.html
trunk/LayoutTests/fast/regions/webkit-flow-renderer-layer-expected.html
trunk/LayoutTests/fast/regions/webkit-flow-renderer-nested-expected.html
Removed Paths
trunk/LayoutTests/platform/efl/fast/regions/webkit-flow-renderer-expected.png
trunk/LayoutTests/platform/efl/fast/regions/webkit-flow-renderer-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-flow-renderer-layer-expected.png
trunk/LayoutTests/platform/efl/fast/regions/webkit-flow-renderer-layer-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-flow-renderer-nested-expected.png
trunk/LayoutTests/platform/efl/fast/regions/webkit-flow-renderer-nested-expected.txt
trunk/LayoutTests/platform/mac/fast/regions/webkit-flow-renderer-expected.png
trunk/LayoutTests/platform/mac/fast/regions/webkit-flow-renderer-expected.txt
trunk/LayoutTests/platform/mac/fast/regions/webkit-flow-renderer-layer-expected.png
trunk/LayoutTests/platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt
trunk/LayoutTests/platform/mac/fast/regions/webkit-flow-renderer-nested-expected.png
trunk/LayoutTests/platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (102401 => 102402)
--- trunk/LayoutTests/ChangeLog 2011-12-09 01:11:02 UTC (rev 102401)
+++ trunk/LayoutTests/ChangeLog 2011-12-09 01:13:29 UTC (rev 102402)
@@ -1,3 +1,26 @@
+2011-12-08 Jacob Goldstein jac...@adobe.com
+
+Convert some fast/regions pixel tests to reftests
+https://bugs.webkit.org/show_bug.cgi?id=74116
+
+Reviewed by Darin Adler.
+
+* fast/regions/webkit-flow-renderer-expected.html: Added.
+* fast/regions/webkit-flow-renderer-layer-expected.html: Added.
+* fast/regions/webkit-flow-renderer-nested-expected.html: Added.
+* platform/efl/fast/regions/webkit-flow-renderer-expected.png: Removed.
+* platform/efl/fast/regions/webkit-flow-renderer-expected.txt: Removed.
+* platform/efl/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
+* platform/efl/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
+* platform/efl/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
+* platform/efl/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
+* platform/mac/fast/regions/webkit-flow-renderer-expected.png: Removed.
+* platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Removed.
+* platform/mac/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
+* platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
+* platform/mac/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
+* platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
+
2011-12-08 Julien Chaffraix jchaffr...@webkit.org
REGRESSION: Changing disabled state of a textarea does not do a repaint
Added: trunk/LayoutTests/fast/regions/webkit-flow-renderer-expected.html (0 => 102402)
--- trunk/LayoutTests/fast/regions/webkit-flow-renderer-expected.html (rev 0)
+++ trunk/LayoutTests/fast/regions/webkit-flow-renderer-expected.html 2011-12-09 01:13:29 UTC (rev 102402)
@@ -0,0 +1,23 @@
+!DOCTYPE HTML
+style
+.region{
+ height:100px;
+}
+/style
+
+body
+div class=region
+divDIV4 - flowA/div
+divDIV1 - flowA/div
+/div
+
[webkit-changes] [102403] trunk/Source/WebCore
Title: [102403] trunk/Source/WebCore Revision 102403 Author ander...@apple.com Date 2011-12-08 17:16:22 -0800 (Thu, 08 Dec 2011) Log Message Fix a paste-o in ScrollAnimatorMac::updateScrollerStyle https://bugs.webkit.org/show_bug.cgi?id=74145 Reviewed by Sam Weinig. Call setHorizontalScrollerImp to set the horizontal scrollbar painter. * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::updateScrollerStyle): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (102402 => 102403) --- trunk/Source/WebCore/ChangeLog 2011-12-09 01:13:29 UTC (rev 102402) +++ trunk/Source/WebCore/ChangeLog 2011-12-09 01:16:22 UTC (rev 102403) @@ -1,5 +1,17 @@ 2011-12-08 Anders Carlsson ander...@apple.com +Fix a paste-o in ScrollAnimatorMac::updateScrollerStyle +https://bugs.webkit.org/show_bug.cgi?id=74145 + +Reviewed by Sam Weinig. + +Call setHorizontalScrollerImp to set the horizontal scrollbar painter. + +* platform/mac/ScrollAnimatorMac.mm: +(WebCore::ScrollAnimatorMac::updateScrollerStyle): + +2011-12-08 Anders Carlsson ander...@apple.com + Create one WebScrollbarPainterDelegate for each scrollbar https://bugs.webkit.org/show_bug.cgi?id=74142 Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102402 => 102403) --- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-09 01:13:29 UTC (rev 102402) +++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-09 01:16:22 UTC (rev 102403) @@ -1475,7 +1475,7 @@ horizontal:YES replacingScrollerImp:oldHorizontalPainter]; macTheme-setNewPainterForScrollbar(horizontalScrollbar, newHorizontalPainter); -[m_scrollbarPainterController.get() setVerticalScrollerImp:newHorizontalPainter]; +[m_scrollbarPainterController.get() setHorizontalScrollerImp:newHorizontalPainter]; // The different scrollbar styles have different thicknesses, so we must re-set the // frameRect to the new thickness, and the re-layout below will ensure the position ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102404] trunk/Source/WebCore
Title: [102404] trunk/Source/WebCore
Revision 102404
Author commit-qu...@webkit.org
Date 2011-12-08 17:31:12 -0800 (Thu, 08 Dec 2011)
Log Message
Use bitfield for bool data members in BitmapImage.
https://bugs.webkit.org/show_bug.cgi?id=74102
Patch by Yongjun Zhang yongjun_zh...@apple.com on 2011-12-08
Reviewed by Darin Adler.
Class BitmapImage and FrameData has bool data members, we can use bitfield for those data
members to reduce the BitmapImage's memory footprint.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
* platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::BitmapImage):
* platform/graphics/openvg/ImageOpenVG.cpp:
(WebCore::BitmapImage::BitmapImage):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::BitmapImage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.h
trunk/Source/WebCore/platform/graphics/cairo/ImageCairo.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageCG.cpp
trunk/Source/WebCore/platform/graphics/openvg/ImageOpenVG.cpp
trunk/Source/WebCore/platform/graphics/qt/ImageQt.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (102403 => 102404)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 01:16:22 UTC (rev 102403)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 01:31:12 UTC (rev 102404)
@@ -1,3 +1,26 @@
+2011-12-08 Yongjun Zhang yongjun_zh...@apple.com
+
+Use bitfield for bool data members in BitmapImage.
+https://bugs.webkit.org/show_bug.cgi?id=74102
+
+Reviewed by Darin Adler.
+
+Class BitmapImage and FrameData has bool data members, we can use bitfield for those data
+members to reduce the BitmapImage's memory footprint.
+
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::BitmapImage):
+* platform/graphics/BitmapImage.h:
+(WebCore::FrameData::FrameData):
+* platform/graphics/cairo/ImageCairo.cpp:
+(WebCore::BitmapImage::BitmapImage):
+* platform/graphics/cg/ImageCG.cpp:
+(WebCore::BitmapImage::BitmapImage):
+* platform/graphics/openvg/ImageOpenVG.cpp:
+(WebCore::BitmapImage::BitmapImage):
+* platform/graphics/qt/ImageQt.cpp:
+(WebCore::BitmapImage::BitmapImage):
+
2011-12-08 Anders Carlsson ander...@apple.com
Fix a paste-o in ScrollAnimatorMac::updateScrollerStyle
Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (102403 => 102404)
--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp 2011-12-09 01:16:22 UTC (rev 102403)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp 2011-12-09 01:31:12 UTC (rev 102404)
@@ -52,6 +52,9 @@
, m_repetitionCountStatus(Unknown)
, m_repetitionsComplete(0)
, m_desiredFrameStartTime(0)
+, m_decodedSize(0)
+, m_decodedPropertiesSize(0)
+, m_frameCount(0)
, m_isSolidColor(false)
, m_checkedForSolidColor(false)
, m_animationFinished(false)
@@ -59,10 +62,7 @@
, m_haveSize(false)
, m_sizeAvailable(false)
, m_hasUniformFrameSize(true)
-, m_decodedSize(0)
-, m_decodedPropertiesSize(0)
, m_haveFrameCount(false)
-, m_frameCount(0)
{
initPlatformData();
}
Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.h (102403 => 102404)
--- trunk/Source/WebCore/platform/graphics/BitmapImage.h 2011-12-09 01:16:22 UTC (rev 102403)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.h 2011-12-09 01:31:12 UTC (rev 102404)
@@ -69,9 +69,9 @@
public:
FrameData()
: m_frame(0)
+, m_duration(0)
, m_haveMetadata(false)
, m_isComplete(false)
-, m_duration(0)
, m_hasAlpha(true)
{
}
@@ -86,10 +86,10 @@
bool clear(bool clearMetadata);
NativeImagePtr m_frame;
-bool m_haveMetadata;
-bool m_isComplete;
float m_duration;
-bool m_hasAlpha;
+bool m_haveMetadata : 1;
+bool m_isComplete : 1;
+bool m_hasAlpha : 1;
};
// =
@@ -275,22 +275,21 @@
#endif
Color m_solidColor; // If we're a 1x1 solid color, this is the color to use to fill.
-bool m_isSolidColor; // Whether or not we are a 1x1 solid image.
-bool m_checkedForSolidColor; // Whether we've checked the frame for solid color.
-bool m_animationFinished; // Whether or not we've completed the entire animation.
-
-bool m_allDataReceived; // Whether or not we've received all our data.
-
-mutable bool m_haveSize; // Whether or not our |m_size| member variable has the final overall image size yet.
-bool m_sizeAvailable; // Whether or not we can obtain the size of the first image frame yet from ImageIO.
-mutable bool m_hasUniformFrameSize;
-
unsigned
[webkit-changes] [102405] trunk
Title: [102405] trunk
Revision 102405
Author jam...@google.com
Date 2011-12-08 17:33:41 -0800 (Thu, 08 Dec 2011)
Log Message
Source/WebCore: Improve handling of frame removal during requestAnimationFrame callback invocation
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
See bug for details.
Test: fast/animation/request-animation-frame-detach-element.html
* dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::detach):
* dom/Document.h:
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::~ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::scheduleAnimation):
* dom/ScriptedAnimationController.h:
(WebCore::ScriptedAnimationController::create):
(WebCore::ScriptedAnimationController::clearDocumentPointer):
* page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
LayoutTests: Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
* fast/animation/request-animation-frame-detach-element-expected.txt: Added.
* fast/animation/request-animation-frame-detach-element.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/ScriptedAnimationController.cpp
trunk/Source/WebCore/dom/ScriptedAnimationController.h
trunk/Source/WebCore/page/FrameView.cpp
Added Paths
trunk/LayoutTests/fast/animation/request-animation-frame-detach-element-expected.txt
trunk/LayoutTests/fast/animation/request-animation-frame-detach-element.html
Diff
Modified: trunk/LayoutTests/ChangeLog (102404 => 102405)
--- trunk/LayoutTests/ChangeLog 2011-12-09 01:31:12 UTC (rev 102404)
+++ trunk/LayoutTests/ChangeLog 2011-12-09 01:33:41 UTC (rev 102405)
@@ -1,3 +1,13 @@
+2011-12-08 James Robinson jam...@chromium.org
+
+Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks
+https://bugs.webkit.org/show_bug.cgi?id=74036
+
+Reviewed by Adam Barth.
+
+* fast/animation/request-animation-frame-detach-element-expected.txt: Added.
+* fast/animation/request-animation-frame-detach-element.html: Added.
+
2011-12-08 Jacob Goldstein jac...@adobe.com
Convert some fast/regions pixel tests to reftests
Added: trunk/LayoutTests/fast/animation/request-animation-frame-detach-element-expected.txt (0 => 102405)
--- trunk/LayoutTests/fast/animation/request-animation-frame-detach-element-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-detach-element-expected.txt 2011-12-09 01:33:41 UTC (rev 102405)
@@ -0,0 +1 @@
+Test passes is there is no crash.
Property changes on: trunk/LayoutTests/fast/animation/request-animation-frame-detach-element-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/animation/request-animation-frame-detach-element.html (0 => 102405)
--- trunk/LayoutTests/fast/animation/request-animation-frame-detach-element.html (rev 0)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-detach-element.html 2011-12-09 01:33:41 UTC (rev 102405)
@@ -0,0 +1,25 @@
+!DOCTYPE html
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+window._onload_ = function() {
+var el = document.getElementsByTagName(iframe)[0];
+window.frames[0].webkitRequestAnimationFrame(function() {
+el.parentNode.removeChild(el);
+});
+window.frames[1].webkitRequestAnimationFrame(function() {
+});
+
+if (window.layoutTestController) {
+window.setTimeout(function() {
+layoutTestController.display();
+layoutTestController.notifyDone();
+}, 50);
+}
+}
+/script
+Test passes is there is no crash.
+iframe/iframe
+iframe/iframe
Property changes on: trunk/LayoutTests/fast/animation/request-animation-frame-detach-element.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (102404 => 102405)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 01:31:12 UTC (rev 102404)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 01:33:41 UTC (rev 102405)
@@ -1,3 +1,28 @@
+2011-12-08 James Robinson jam...@chromium.org
+
+Improve handling of frame removal during requestAnimationFrame callback invocation
+https://bugs.webkit.org/show_bug.cgi?id=74036
+
+Reviewed by Adam Barth.
+
+See bug for details.
+
+Test: fast/animation/request-animation-frame-detach-element.html
+
+* dom/Document.cpp:
+(WebCore::Document::removedLastRef):
+
[webkit-changes] [102406] trunk/Source/WebCore
Title: [102406] trunk/Source/WebCore
Revision 102406
Author ander...@apple.com
Date 2011-12-08 17:35:25 -0800 (Thu, 08 Dec 2011)
Log Message
Add scrollAnimator getter method to WebScrollbarPainterDelegate
https://bugs.webkit.org/show_bug.cgi?id=74146
Reviewed by Beth Dakin.
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate scrollAnimator]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (102405 => 102406)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 01:33:41 UTC (rev 102405)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 01:35:25 UTC (rev 102406)
@@ -1,3 +1,19 @@
+2011-12-08 Anders Carlsson ander...@apple.com
+
+Add scrollAnimator getter method to WebScrollbarPainterDelegate
+https://bugs.webkit.org/show_bug.cgi?id=74146
+
+Reviewed by Beth Dakin.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollbarPainterDelegate scrollAnimator]):
+(-[WebScrollbarPainterDelegate layer]):
+(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
+(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
+
2011-12-08 James Robinson jam...@chromium.org
Improve handling of frame removal during requestAnimationFrame callback invocation
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102405 => 102406)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-09 01:33:41 UTC (rev 102405)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-09 01:35:25 UTC (rev 102406)
@@ -398,6 +398,11 @@
END_BLOCK_OBJC_EXCEPTIONS;
}
+- (ScrollAnimatorMac*)scrollAnimator
+{
+return _animator;
+}
+
- (NSRect)convertRectToBacking:(NSRect)aRect
{
return aRect;
@@ -410,9 +415,11 @@
- (CALayer *)layer
{
-if (!_animator)
+ScrollAnimatorMac* animator = [self scrollAnimator];
+if (!animator)
return nil;
-if (!_animator-isDrawingIntoLayer())
+
+if (!animator-isDrawingIntoLayer())
return nil;
// FIXME: This should attempt to return an actual layer.
@@ -422,38 +429,38 @@
- (NSPoint)mouseLocationInScrollerForScrollerImp:(id)scrollerImp
{
-if (!_animator)
+if (![self scrollAnimator])
return NSZeroPoint;
ScrollbarPainter scrollerPainter = (ScrollbarPainter)scrollerImp;
Scrollbar* scrollbar;
if ([scrollerPainter isHorizontal])
-scrollbar = _animator-scrollableArea()-horizontalScrollbar();
+scrollbar = [self scrollAnimator]-scrollableArea()-horizontalScrollbar();
else
-scrollbar = _animator-scrollableArea()-verticalScrollbar();
+scrollbar = [self scrollAnimator]-scrollableArea()-verticalScrollbar();
if (!scrollbar)
return NSZeroPoint;
-return scrollbar-convertFromContainingView(_animator-scrollableArea()-currentMousePosition());
+return scrollbar-convertFromContainingView([self scrollAnimator]-scrollableArea()-currentMousePosition());
}
- (void)setUpAlphaAnimation:(RetainPtrWebScrollbarPartAnimation)scrollbarPartAnimation scrollerPainter:(ScrollbarPainter)scrollerPainter part:(WebCore::ScrollbarPart)part animateAlphaTo:(CGFloat)newAlpha duration:(NSTimeInterval)duration
{
// If the user has scrolled the page, then the scrollbars must be animated here.
// This overrides the early returns.
-bool mustAnimate = _animator-haveScrolledSincePageLoad();
+bool mustAnimate = [self scrollAnimator]-haveScrolledSincePageLoad();
-if (_animator-scrollbarPaintTimerIsActive() !mustAnimate)
+if ([self scrollAnimator]-scrollbarPaintTimerIsActive() !mustAnimate)
return;
-if (_animator-scrollableArea()-shouldSuspendScrollAnimations() !mustAnimate) {
-_animator-startScrollbarPaintTimer();
+if ([self scrollAnimator]-scrollableArea()-shouldSuspendScrollAnimations() !mustAnimate) {
+[self scrollAnimator]-startScrollbarPaintTimer();
return;
}
// At this point, we are definitely going to animate now, so stop the timer.
-_animator-stopScrollbarPaintTimer();
+[self
[webkit-changes] [102407] trunk/Source/WebKit2
Title: [102407] trunk/Source/WebKit2
Revision 102407
Author simon.fra...@apple.com
Date 2011-12-08 17:46:30 -0800 (Thu, 08 Dec 2011)
Log Message
Forced compositing mode breaks display of full-page PDFs in WK2
https://bugs.webkit.org/show_bug.cgi?id=74122
rdar://problem/9550059
Reviewed by Dan Bernstein.
Full page PDFs are displayed in WK2 in a subview of the WKView. However,
when the WKView is forced to use accelerated compositing, the layer obscures
the PDF subview.
To fix this we have to drop out of compositing mode when the WKView is showing
a custom representation.
* UIProcess/API/mac/WKView.mm:
(-[WKView _setPageHasCustomRepresentation:]): Tell the drawing area that the view
gained or lost a custom representation.
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::pageCustomRepresentationChanged):
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::pageCustomRepresentationChanged): Send a messgae to the web process
to indicate that the custom representation changed.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::pageCustomRepresentationChanged):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::pageCustomRepresentationChanged): Enter or exit compositing mode
as appropriate when we gain or lost a custom represenetation.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
* WebProcess/WebPage/DrawingAreaImpl.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h
trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (102406 => 102407)
--- trunk/Source/WebKit2/ChangeLog 2011-12-09 01:35:25 UTC (rev 102406)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-09 01:46:30 UTC (rev 102407)
@@ -1,3 +1,36 @@
+2011-12-08 Simon Fraser simon.fra...@apple.com
+
+Forced compositing mode breaks display of full-page PDFs in WK2
+https://bugs.webkit.org/show_bug.cgi?id=74122
+rdar://problem/9550059
+
+Reviewed by Dan Bernstein.
+
+Full page PDFs are displayed in WK2 in a subview of the WKView. However,
+when the WKView is forced to use accelerated compositing, the layer obscures
+the PDF subview.
+
+To fix this we have to drop out of compositing mode when the WKView is showing
+a custom representation.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView _setPageHasCustomRepresentation:]): Tell the drawing area that the view
+gained or lost a custom representation.
+* UIProcess/DrawingAreaProxy.h:
+(WebKit::DrawingAreaProxy::pageCustomRepresentationChanged):
+* UIProcess/DrawingAreaProxyImpl.h:
+* UIProcess/DrawingAreaProxyImpl.cpp:
+(WebKit::DrawingAreaProxyImpl::pageCustomRepresentationChanged): Send a messgae to the web process
+to indicate that the custom representation changed.
+* WebProcess/WebPage/DrawingArea.h:
+(WebKit::DrawingArea::pageCustomRepresentationChanged):
+* WebProcess/WebPage/DrawingArea.messages.in:
+* WebProcess/WebPage/DrawingAreaImpl.cpp:
+(WebKit::DrawingAreaImpl::pageCustomRepresentationChanged): Enter or exit compositing mode
+as appropriate when we gain or lost a custom represenetation.
+(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
+* WebProcess/WebPage/DrawingAreaImpl.h:
+
2011-12-08 Jer Noble jer.no...@apple.com
HiDPI: Switching a video element to full screen in HiDPI mode doesn't fit the screen correctly
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (102406 => 102407)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-12-09 01:35:25 UTC (rev 102406)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-12-09 01:46:30 UTC (rev 102407)
@@ -2445,10 +2445,14 @@
- (void)_setPageHasCustomRepresentation:(BOOL)pageHasCustomRepresentation
{
+bool hadPDFView = _data-_pdfViewController;
_data-_pdfViewController = nullptr;
if (pageHasCustomRepresentation)
_data-_pdfViewController = PDFViewController::create(self);
+
+if (pageHasCustomRepresentation != hadPDFView)
+_data-_page-drawingArea()-pageCustomRepresentationChanged();
}
- (void)_didFinishLoadingDataForCustomRepresentationWithSuggestedFilename:(const String)suggestedFilename dataReference:(const CoreIPC::DataReference)dataReference
Modified: trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h (102406 => 102407)
---
[webkit-changes] [102408] trunk
Title: [102408] trunk Revision 102408 Author commit-qu...@webkit.org Date 2011-12-08 17:46:49 -0800 (Thu, 08 Dec 2011) Log Message keyboard event doesn't fire while moving mouse with button pressed https://bugs.webkit.org/show_bug.cgi?id=73821 Patch by Rakesh KN rakesh...@motorola.com on 2011-12-08 Reviewed by Alexey Proskuryakov. Autoscroll should not stop on key press. Source/WebCore: Test: fast/events/autoscroll-should-not-stop-on-keypress.html * page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Removed the check for autoscroll so that autoscroll is not stopped on key press and key event is processed. LayoutTests: * fast/events/autoscroll-should-not-stop-on-keypress-expected.txt: Added. * fast/events/autoscroll-should-not-stop-on-keypress.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/EventHandler.cpp Added Paths trunk/LayoutTests/fast/events/autoscroll-should-not-stop-on-keypress-expected.txt trunk/LayoutTests/fast/events/autoscroll-should-not-stop-on-keypress.html Diff Modified: trunk/LayoutTests/ChangeLog (102407 => 102408) --- trunk/LayoutTests/ChangeLog 2011-12-09 01:46:30 UTC (rev 102407) +++ trunk/LayoutTests/ChangeLog 2011-12-09 01:46:49 UTC (rev 102408) @@ -1,3 +1,15 @@ +2011-12-08 Rakesh KN rakesh...@motorola.com + +keyboard event doesn't fire while moving mouse with button pressed +https://bugs.webkit.org/show_bug.cgi?id=73821 + +Reviewed by Alexey Proskuryakov. + +Autoscroll should not stop on key press. + +* fast/events/autoscroll-should-not-stop-on-keypress-expected.txt: Added. +* fast/events/autoscroll-should-not-stop-on-keypress.html: Added. + 2011-12-08 James Robinson jam...@chromium.org Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks Added: trunk/LayoutTests/fast/events/autoscroll-should-not-stop-on-keypress-expected.txt (0 => 102408) --- trunk/LayoutTests/fast/events/autoscroll-should-not-stop-on-keypress-expected.txt (rev 0) +++ trunk/LayoutTests/fast/events/autoscroll-should-not-stop-on-keypress-expected.txt 2011-12-09 01:46:49 UTC (rev 102408) @@ -0,0 +1,167 @@ +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +Lots of text +PASS document.body.scrollTop + window.innerHeight is document.body.scrollHeight +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/events/autoscroll-should-not-stop-on-keypress.html (0 => 102408) --- trunk/LayoutTests/fast/events/autoscroll-should-not-stop-on-keypress.html (rev 0) +++ trunk/LayoutTests/fast/events/autoscroll-should-not-stop-on-keypress.html 2011-12-09 01:46:49 UTC (rev 102408) @@ -0,0
[webkit-changes] [102409] trunk/Source/WebCore
Title: [102409] trunk/Source/WebCore
Revision 102409
Author ander...@apple.com
Date 2011-12-08 17:54:06 -0800 (Thu, 08 Dec 2011)
Log Message
WebScrollbarPainterDelegate should have a pointer to its Scrollbar
https://bugs.webkit.org/show_bug.cgi?id=74149
Reviewed by Darin Adler.
This is another step towards making the scroll animation code more robust.
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate initWithScrollbar:WebCore::]):
(-[WebScrollbarPainterDelegate scrollAnimator]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (102408 => 102409)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 01:46:49 UTC (rev 102408)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 01:54:06 UTC (rev 102409)
@@ -1,3 +1,24 @@
+2011-12-08 Anders Carlsson ander...@apple.com
+
+WebScrollbarPainterDelegate should have a pointer to its Scrollbar
+https://bugs.webkit.org/show_bug.cgi?id=74149
+
+Reviewed by Darin Adler.
+
+This is another step towards making the scroll animation code more robust.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollbarPainterDelegate initWithScrollbar:WebCore::]):
+(-[WebScrollbarPainterDelegate scrollAnimator]):
+(-[WebScrollbarPainterDelegate layer]):
+(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
+(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
+(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
+(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
+
2011-12-08 Rakesh KN rakesh...@motorola.com
keyboard event doesn't fire while moving mouse with button pressed
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102408 => 102409)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-09 01:46:49 UTC (rev 102408)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-12-09 01:54:06 UTC (rev 102409)
@@ -359,7 +359,7 @@
@interface WebScrollbarPainterDelegate : NSObjectNSAnimationDelegate
{
-WebCore::ScrollAnimatorMac* _animator;
+WebCore::Scrollbar* _scrollbar;
RetainPtrWebScrollbarPartAnimation _verticalKnobAnimation;
RetainPtrWebScrollbarPartAnimation _horizontalKnobAnimation;
@@ -370,19 +370,19 @@
RetainPtrWebScrollbarPartAnimation _verticalUIStateTransitionAnimation;
RetainPtrWebScrollbarPartAnimation _horizontalUIStateTransitionAnimation;
}
-- (id)initWithScrollAnimator:(WebCore::ScrollAnimatorMac*)scrollAnimator;
+- (id)initWithScrollbar:(WebCore::Scrollbar*)scrollbar;
- (void)cancelAnimations;
@end
@implementation WebScrollbarPainterDelegate
-- (id)initWithScrollAnimator:(WebCore::ScrollAnimatorMac*)scrollAnimator
+- (id)initWithScrollbar:(WebCore::Scrollbar*)scrollbar
{
self = [super init];
if (!self)
return nil;
-_animator = scrollAnimator;
+_scrollbar = scrollbar;
return self;
}
@@ -400,7 +400,7 @@
- (ScrollAnimatorMac*)scrollAnimator
{
-return _animator;
+return static_castScrollAnimatorMac*(_scrollbar-scrollableArea()-scrollAnimator());
}
- (NSRect)convertRectToBacking:(NSRect)aRect
@@ -415,11 +415,10 @@
- (CALayer *)layer
{
-ScrollAnimatorMac* animator = [self scrollAnimator];
-if (!animator)
+if (!_scrollbar)
return nil;
-if (!animator-isDrawingIntoLayer())
+if (![self scrollAnimator]-isDrawingIntoLayer())
return nil;
// FIXME: This should attempt to return an actual layer.
@@ -429,7 +428,7 @@
- (NSPoint)mouseLocationInScrollerForScrollerImp:(id)scrollerImp
{
-if (![self scrollAnimator])
+if (!_scrollbar)
return NSZeroPoint;
ScrollbarPainter scrollerPainter = (ScrollbarPainter)scrollerImp;
@@ -491,7 +490,7 @@
- (void)scrollerImp:(id)scrollerImp animateKnobAlphaTo:(CGFloat)newKnobAlpha duration:(NSTimeInterval)duration
{
-if (![self scrollAnimator])
+if (!_scrollbar)
return;
ScrollbarPainter scrollerPainter = (ScrollbarPainter)scrollerImp;
@@ -503,7 +502,7 @@
-
[webkit-changes] [102410] trunk/Source
Title: [102410] trunk/Source
Revision 102410
Author ad...@chromium.org
Date 2011-12-08 17:56:59 -0800 (Thu, 08 Dec 2011)
Log Message
Use HashMapNode*, OwnPtr... in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=73964
Reviewed by Darin Adler.
Source/_javascript_Core:
* wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on a HashMap of OwnPtrs.
Source/WebCore:
Re-landing r102267 with a fix for the clang build.
No new tests, refactoring only.
* dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/HashTraits.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ChildListMutationScope.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (102409 => 102410)
--- trunk/Source/_javascript_Core/ChangeLog 2011-12-09 01:54:06 UTC (rev 102409)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-12-09 01:56:59 UTC (rev 102410)
@@ -1,3 +1,12 @@
+2011-12-08 Adam Klein ad...@chromium.org
+
+Use HashMapNode*, OwnPtr... in ChildListMutationScope
+https://bugs.webkit.org/show_bug.cgi?id=73964
+
+Reviewed by Darin Adler.
+
+* wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on a HashMap of OwnPtrs.
+
2011-12-08 Thouraya ANDOLSI thouraya.ando...@st.com
https://bugs.webkit.org/show_bug.cgi?id=74005
Modified: trunk/Source/_javascript_Core/wtf/HashTraits.h (102409 => 102410)
--- trunk/Source/_javascript_Core/wtf/HashTraits.h 2011-12-09 01:54:06 UTC (rev 102409)
+++ trunk/Source/_javascript_Core/wtf/HashTraits.h 2011-12-09 01:56:59 UTC (rev 102410)
@@ -117,6 +117,7 @@
typedef PassOwnPtrP PassOutType;
static PassOwnPtrP passOut(OwnPtrP value) { return value.release(); }
+static PassOwnPtrP passOut(std::nullptr_t) { return nullptr; }
typedef typename OwnPtrP::PtrType PeekType;
static PeekType peek(const OwnPtrP value) { return value.get(); }
Modified: trunk/Source/WebCore/ChangeLog (102409 => 102410)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 01:54:06 UTC (rev 102409)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 01:56:59 UTC (rev 102410)
@@ -1,3 +1,20 @@
+2011-12-08 Adam Klein ad...@chromium.org
+
+Use HashMapNode*, OwnPtr... in ChildListMutationScope
+https://bugs.webkit.org/show_bug.cgi?id=73964
+
+Reviewed by Darin Adler.
+
+Re-landing r102267 with a fix for the clang build.
+
+No new tests, refactoring only.
+
+* dom/ChildListMutationScope.cpp:
+(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
+(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
+(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
+(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):
+
2011-12-08 Anders Carlsson ander...@apple.com
WebScrollbarPainterDelegate should have a pointer to its Scrollbar
Modified: trunk/Source/WebCore/dom/ChildListMutationScope.cpp (102409 => 102410)
--- trunk/Source/WebCore/dom/ChildListMutationScope.cpp 2011-12-09 01:54:06 UTC (rev 102409)
+++ trunk/Source/WebCore/dom/ChildListMutationScope.cpp 2011-12-09 01:56:59 UTC (rev 102410)
@@ -40,7 +40,7 @@
#include Node.h
#include StaticNodeList.h
#include wtf/HashMap.h
-#include wtf/RefCounted.h
+#include wtf/OwnPtr.h
namespace WebCore {
@@ -50,7 +50,7 @@
// and precede any additions. If this is violated (i.e. because of code changes elsewhere
// in WebCore) it will likely result in both (a) ASSERTions failing, and (b) mutation records
// being enqueued for delivery before the outer-most scope closes.
-class ChildListMutationAccumulator : public RefCountedChildListMutationAccumulator {
+class ChildListMutationAccumulator {
WTF_MAKE_NONCOPYABLE(ChildListMutationAccumulator);
public:
ChildListMutationAccumulator(PassRefPtrNode, PassOwnPtrMutationObserverInterestGroup observers);
@@ -95,7 +95,7 @@
typedef HashMapNode*, unsigned ScopingLevelMap;
ScopingLevelMap m_scopingLevels;
-HashMapNode*, RefPtrChildListMutationAccumulator m_accumulations;
+HashMapNode*, OwnPtrChildListMutationAccumulator m_accumulations;
static MutationAccumulationRouter* s_instance;
};
@@ -216,7 +216,7 @@
void MutationAccumulationRouter::childAdded(Node* target, Node* child)
{
-HashMapNode*, RefPtrChildListMutationAccumulator ::iterator iter = m_accumulations.find(target);
+HashMapNode*,
[webkit-changes] [102412] trunk/Tools
Title: [102412] trunk/Tools Revision 102412 Author e...@google.com Date 2011-12-08 18:00:57 -0800 (Thu, 08 Dec 2011) Log Message Unreviewed contributor additions to committers.py. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (102411 => 102412) --- trunk/Tools/ChangeLog 2011-12-09 01:59:18 UTC (rev 102411) +++ trunk/Tools/ChangeLog 2011-12-09 02:00:57 UTC (rev 102412) @@ -1,3 +1,9 @@ +2011-12-08 Adrienne Walker e...@google.com + +Unreviewed contributor additions to committers.py. + +* Scripts/webkitpy/common/config/committers.py: + 2011-12-08 David Reveman reve...@chromium.org [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code. Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (102411 => 102412) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-12-09 01:59:18 UTC (rev 102411) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-12-09 02:00:57 UTC (rev 102412) @@ -107,6 +107,7 @@ contributors_who_are_not_committers = [ Contributor(Aharon Lanin, aha...@google.com), Contributor(Alan Stearns, stea...@adobe.com, 'astearns'), +Contributor(Alexandre Elias, ael...@chromium.org), Contributor(Alexey Marinichev, [amarinic...@chromium.org, amarinic...@google.com], amarinichev), Contributor(Ami Fischman, [fisch...@chromium.org, fisch...@google.com], amifischman0), Contributor(Andras Piroska, pand...@inf.u-szeged.hu, andris88), @@ -114,12 +115,17 @@ Contributor(Annie Sullivan, sulli...@chromium.org, annie), Contributor(Antoine Labour, pi...@chromium.org, piman), Contributor(Aryeh Gregor, a...@aryeh.name, AryehGregor), +Contributor(Dana Jansens, dan...@chromium.org, danakj), +Contributor(Daniel Sievers, siev...@chromium.org), Contributor(David Barr, davidb...@chromium.org, barrbrain), Contributor(David Dorwin, ddor...@chromium.org, ddorwin), +Contributor(David Reveman, reve...@chromium.org, reveman), Contributor(Douglas Davidson, ddavi...@apple.com), Contributor(Edward O'Connor, eocon...@apple.com, hober), +Contributor(Eric Penner, epen...@chromium.org, epenner), Contributor(Felician Marton, [felic...@inf.u-szeged.hu, marton.felician.zol...@stud.u-szeged.hu], Felician), Contributor(Finnur Thorarinsson, [fin...@chromium.org, finnur.web...@gmail.com], finnur), +Contributor(Grace Kloba, klo...@chromium.org, klobag), Contributor(Greg Simon, gregsi...@chromium.org, gregsimon), Contributor(Gregg Tavares, [g...@google.com, g...@chromium.org], gman), Contributor(Ian Hickson, i...@hixie.ch, hixie), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102413] trunk/Source/WebCore
Title: [102413] trunk/Source/WebCore
Revision 102413
Author commit-qu...@webkit.org
Date 2011-12-08 18:28:27 -0800 (Thu, 08 Dec 2011)
Log Message
Caret keeps blinking during forward-delete
https://bugs.webkit.org/show_bug.cgi?id=38564
Patch by Van Lam van...@google.com on 2011-12-08
Reviewed by Darin Adler.
Currently updateAppearance determines if the caret should stop blinking
based on whether or not the editing operation changed the position of
the caret; so the caret stops blinking in case of typing text and
backwards delete (which always displace the caret) but does not stop
blinking in the case of forward delete (which does not displace the
caret).
Added a boolean member function shouldStopCaretBlinking in EditCommand
which will return true if the object is a TypingCommand (my
understanding here is that all TypingCommands should stop the caret
from blinking for a cycle, currently 0.5 seconds). Then used this
function to stop the caret from blinking if the last editing command
is a TypingCommand.
* editing/EditCommand.h:
(WebCore::EditCommand::shouldStopCaretBlinking):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAppearance):
* editing/TypingCommand.h:
(WebCore::TypingCommand::shouldStopCaretBlinking):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/EditCommand.h
trunk/Source/WebCore/editing/FrameSelection.cpp
trunk/Source/WebCore/editing/TypingCommand.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (102412 => 102413)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 02:00:57 UTC (rev 102412)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 02:28:27 UTC (rev 102413)
@@ -1,3 +1,31 @@
+2011-12-08 Van Lam van...@google.com
+
+Caret keeps blinking during forward-delete
+https://bugs.webkit.org/show_bug.cgi?id=38564
+
+Reviewed by Darin Adler.
+
+Currently updateAppearance determines if the caret should stop blinking
+based on whether or not the editing operation changed the position of
+the caret; so the caret stops blinking in case of typing text and
+backwards delete (which always displace the caret) but does not stop
+blinking in the case of forward delete (which does not displace the
+caret).
+
+Added a boolean member function shouldStopCaretBlinking in EditCommand
+which will return true if the object is a TypingCommand (my
+understanding here is that all TypingCommands should stop the caret
+from blinking for a cycle, currently 0.5 seconds). Then used this
+function to stop the caret from blinking if the last editing command
+is a TypingCommand.
+
+* editing/EditCommand.h:
+(WebCore::EditCommand::shouldStopCaretBlinking):
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::updateAppearance):
+* editing/TypingCommand.h:
+(WebCore::TypingCommand::shouldStopCaretBlinking):
+
2011-12-08 Adam Klein ad...@chromium.org
Use HashMapNode*, OwnPtr... in ChildListMutationScope
Modified: trunk/Source/WebCore/editing/EditCommand.h (102412 => 102413)
--- trunk/Source/WebCore/editing/EditCommand.h 2011-12-09 02:00:57 UTC (rev 102412)
+++ trunk/Source/WebCore/editing/EditCommand.h 2011-12-09 02:28:27 UTC (rev 102413)
@@ -65,6 +65,7 @@
virtual bool shouldRetainAutocorrectionIndicator() const;
virtual void setShouldRetainAutocorrectionIndicator(bool);
+virtual bool shouldStopCaretBlinking() const { return false; }
protected:
EditCommand(Document*);
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (102412 => 102413)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2011-12-09 02:00:57 UTC (rev 102412)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2011-12-09 02:28:27 UTC (rev 102413)
@@ -1656,10 +1656,13 @@
bool caretBrowsing = m_frame-settings() m_frame-settings()-caretBrowsingEnabled();
bool shouldBlink = caretIsVisible() isCaret() (isContentEditable() || caretBrowsing);
+
+EditCommand* lastEditCommand = m_frame ? m_frame-editor()-lastEditCommand() : 0;
+bool shouldStopBlinkingDueToTypingCommand = lastEditCommand lastEditCommand-shouldStopCaretBlinking();
// If the caret moved, stop the blink timer so we can restart with a
// black caret in the new location.
-if (caretRectChanged || !shouldBlink)
+if (caretRectChanged || !shouldBlink || shouldStopBlinkingDueToTypingCommand)
m_caretBlinkTimer.stop();
// Start blinking with a black caret. Be sure not to restart if we're
Modified: trunk/Source/WebCore/editing/TypingCommand.h (102412 => 102413)
--- trunk/Source/WebCore/editing/TypingCommand.h 2011-12-09 02:00:57 UTC (rev 102412)
+++ trunk/Source/WebCore/editing/TypingCommand.h 2011-12-09 02:28:27 UTC (rev 102413)
@@ -103,6 +103,7 @@
virtual bool preservesTypingStyle() const { return m_preservesTypingStyle; }
virtual bool
[webkit-changes] [102414] trunk/LayoutTests
Title: [102414] trunk/LayoutTests
Revision 102414
Author commit-qu...@webkit.org
Date 2011-12-08 18:32:14 -0800 (Thu, 08 Dec 2011)
Log Message
Unreviewed, rolling out r102396.
http://trac.webkit.org/changeset/102396
https://bugs.webkit.org/show_bug.cgi?id=74153
over-active-drag test still failing. (Requested by macpherson
on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-12-08
* fast/css/hover-active-drag.html:
* platform/chromium/fast/css/hover-active-drag-expected.txt: Added.
* platform/mac/fast/css/hover-active-drag-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/hover-active-drag.html
Added Paths
trunk/LayoutTests/platform/chromium/fast/css/hover-active-drag-expected.txt
trunk/LayoutTests/platform/mac/fast/css/hover-active-drag-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (102413 => 102414)
--- trunk/LayoutTests/ChangeLog 2011-12-09 02:28:27 UTC (rev 102413)
+++ trunk/LayoutTests/ChangeLog 2011-12-09 02:32:14 UTC (rev 102414)
@@ -1,3 +1,16 @@
+2011-12-08 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r102396.
+http://trac.webkit.org/changeset/102396
+https://bugs.webkit.org/show_bug.cgi?id=74153
+
+over-active-drag test still failing. (Requested by macpherson
+on #webkit).
+
+* fast/css/hover-active-drag.html:
+* platform/chromium/fast/css/hover-active-drag-expected.txt: Added.
+* platform/mac/fast/css/hover-active-drag-expected.txt: Added.
+
2011-12-08 Kent Tamura tk...@chromium.org
[Chromium] Rebaseline for r102320.
Modified: trunk/LayoutTests/fast/css/hover-active-drag.html (102413 => 102414)
--- trunk/LayoutTests/fast/css/hover-active-drag.html 2011-12-09 02:28:27 UTC (rev 102413)
+++ trunk/LayoutTests/fast/css/hover-active-drag.html 2011-12-09 02:32:14 UTC (rev 102414)
@@ -20,6 +20,9 @@
script src=""
script
+ function backgroundOf(element) {
+return getComputedStyle(element, null).getPropertyValue(background-color)
+ }
function shouldHaveBackground(element, bg) {
background = "" null).getPropertyValue(background-color)
shouldBeEqualToString('background', bg)
@@ -32,29 +35,22 @@
eventSender.dragMode = false;
eventSender.mouseMoveTo(50, 50)
-eventSender.leapForward(50)
-eventSender.mouseMoveTo(60, 50)
-eventSender.leapForward(50)
shouldHaveBackground(box, 'rgb(255, 0, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
eventSender.mouseDown()
-eventSender.leapForward(50)
shouldHaveBackground(box, 'rgb(255, 255, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
eventSender.mouseMoveTo(50, 150)
-eventSender.leapForward(50)
shouldHaveBackground(box, 'rgb(0, 255, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
eventSender.mouseMoveTo(400, 50)
-eventSender.leapForward(50)
shouldHaveBackground(box, 'rgb(0, 255, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
eventSender.mouseUp()
-eventSender.leapForward(50)
shouldHaveBackground(box, 'rgb(0, 0, 0)')
shouldHaveBackground(box2, 'rgb(0, 0, 0)')
}
Added: trunk/LayoutTests/platform/chromium/fast/css/hover-active-drag-expected.txt (0 => 102414)
--- trunk/LayoutTests/platform/chromium/fast/css/hover-active-drag-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/css/hover-active-drag-expected.txt 2011-12-09 02:32:14 UTC (rev 102414)
@@ -0,0 +1,20 @@
+Dragging out of an element should cause it to lose :hover
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+PASS background is rgb(255, 0, 0)
+PASS background is rgb(0, 0, 0)
+PASS background is rgb(255, 255, 0)
+PASS background is rgb(0, 0, 0)
+PASS background is rgb(0, 255, 0)
+PASS background is rgb(0, 0, 0)
+PASS background is rgb(0, 255, 0)
+PASS background is rgb(0, 0, 0)
+PASS background is rgb(0, 0, 0)
+PASS background is rgb(0, 0, 0)
+
+
+
+
+
+
Added: trunk/LayoutTests/platform/mac/fast/css/hover-active-drag-expected.txt (0 => 102414)
--- trunk/LayoutTests/platform/mac/fast/css/hover-active-drag-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/css/hover-active-drag-expected.txt 2011-12-09 02:32:14 UTC (rev 102414)
@@ -0,0 +1,20 @@
+Dragging out of an element should cause it to lose :hover
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+FAIL background should be rgb(255, 0, 0). Was rgb(0, 0, 0).
+PASS background is rgb(0, 0, 0)
+PASS background is rgb(255, 255, 0)
+PASS background is rgb(0, 0, 0)
+PASS background is rgb(0, 255, 0)
+PASS background is rgb(0, 0, 0)
+PASS background is rgb(0, 255, 0)
+PASS background is rgb(0, 0, 0)
+PASS background is rgb(0, 0, 0)
+PASS background is rgb(0, 0, 0)
+
+
+
+
+
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [102415] trunk/LayoutTests
Title: [102415] trunk/LayoutTests
Revision 102415
Author commit-qu...@webkit.org
Date 2011-12-08 18:38:37 -0800 (Thu, 08 Dec 2011)
Log Message
Add test for inline style block in HTML tag
https://bugs.webkit.org/show_bug.cgi?id=72360
Patch by Szilard Ledan ledan-muntean.szil...@stud.u-szeged.hu on 2011-12-08
Reviewed by Darin Adler.
* fast/css/parsing-css-block-expected.txt: Added.
* fast/css/parsing-css-block.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/css/parsing-css-block-expected.txt
trunk/LayoutTests/fast/css/parsing-css-block.html
Diff
Modified: trunk/LayoutTests/ChangeLog (102414 => 102415)
--- trunk/LayoutTests/ChangeLog 2011-12-09 02:32:14 UTC (rev 102414)
+++ trunk/LayoutTests/ChangeLog 2011-12-09 02:38:37 UTC (rev 102415)
@@ -1,3 +1,13 @@
+2011-12-08 Szilard Ledan ledan-muntean.szil...@stud.u-szeged.hu
+
+Add test for inline style block in HTML tag
+https://bugs.webkit.org/show_bug.cgi?id=72360
+
+Reviewed by Darin Adler.
+
+* fast/css/parsing-css-block-expected.txt: Added.
+* fast/css/parsing-css-block.html: Added.
+
2011-12-08 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r102396.
Added: trunk/LayoutTests/fast/css/parsing-css-block-expected.txt (0 => 102415)
--- trunk/LayoutTests/fast/css/parsing-css-block-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/parsing-css-block-expected.txt 2011-12-09 02:38:37 UTC (rev 102415)
@@ -0,0 +1,17 @@
+Test parsing of CSS curly brackets block
+
+FAILURE
+
+Rules from the stylesheet:
+
+Font size is 16px.
+
+
+
+Expected result:
+
+Font size is 16px.
+
+
+
+
Added: trunk/LayoutTests/fast/css/parsing-css-block.html (0 => 102415)
--- trunk/LayoutTests/fast/css/parsing-css-block.html (rev 0)
+++ trunk/LayoutTests/fast/css/parsing-css-block.html 2011-12-09 02:38:37 UTC (rev 102415)
@@ -0,0 +1,47 @@
+head
+style
+
+/* Base form of the rule: */
+/style
+
+script
+
+function runTest()
+{
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+if (document.getElementById(result).firstChild.style.fontSize === document.getElementById(expected).firstChild.style.fontSize)
+document.getElementById(message).firstChild.data = ""
+else
+document.getElementById(message).firstChild.data = ""
+}
+
+/script
+
+/head
+
+body _onload_=runTest()
+
+pTest parsing of CSS curly brackets block/p
+
+p id=messageTEST DID NOT COMPLETE/p
+
+pRules from the stylesheet:/p
+
+pre id=result
+p style={font-size: 16px;}Font size is 16px./p
+
+/pre
+
+pExpected result:/p
+
+pre id=expected
+p style=font-size: 16px;Font size is 16px./p
+
+/pre
+
+script
+
+/script
+/body
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102416] trunk/Source/WebCore
Title: [102416] trunk/Source/WebCore
Revision 102416
Author hara...@chromium.org
Date 2011-12-08 18:49:28 -0800 (Thu, 08 Dec 2011)
Log Message
Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394
Reviewed by Adam Barth.
- Overview: Using the [Supplemental] IDL, this patch moves the attribute
declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).
- This patch changes the build flow of WebCore.gyp as follows:
Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
}
- This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:
In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.
This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:
- DerivedSources.make
- DerivedSources.pri
- GNUmakefile.am
- PlatformBlackBerry.cmake
- UseJSC.cmake
- UseV8.cmake
- WebCore.vcproj/MigrateScripts
- WebCore.vcproj/WebCore.vcproj
- bindings/gobject/GNUmakefile.am
- WebCore.gyp/WebCore.gyp
Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:
DOMWindowWebAudio.idl:
interface [
Supplemental=DOMWindow
] DOMWindowWebAudio {
attribute attr1;
attribute attr2;
};
DOMWindow.idl:
interface [
] DOMWindow {
attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;
};
Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:
- If a given build script supports the [Supplemental] IDL,
generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
- Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL
as normal attributes and instead ignores all attributes with the [Supplemental] IDL
(i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).
Tests: webaudio/*
* WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a /cygdrive/c/...-style path, it is converted to a C:\cygwin\...-style path by the cygpath command.
* WebCore.gypi: Added DOMWindowWebAudio.idl.
* bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
* page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
* webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in
[webkit-changes] [102417] trunk/LayoutTests
Title: [102417] trunk/LayoutTests Revision 102417 Author ba...@chromium.org Date 2011-12-08 18:59:02 -0800 (Thu, 08 Dec 2011) Log Message Unreviewed chromium rebaseline fast/repaint/textarea-set-disabled.html. Patch by Kenichi Ishibashi ba...@chromium.org on 2011-12-08 * platform/chromium-win/fast/repaint/textarea-set-disabled-expected.png: Added. * platform/chromium/fast/repaint/textarea-set-disabled-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium/fast/repaint/textarea-set-disabled-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/textarea-set-disabled-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (102416 => 102417) --- trunk/LayoutTests/ChangeLog 2011-12-09 02:49:28 UTC (rev 102416) +++ trunk/LayoutTests/ChangeLog 2011-12-09 02:59:02 UTC (rev 102417) @@ -1,3 +1,10 @@ +2011-12-08 Kenichi Ishibashi ba...@chromium.org + +Unreviewed chromium rebaseline fast/repaint/textarea-set-disabled.html. + +* platform/chromium-win/fast/repaint/textarea-set-disabled-expected.png: Added. +* platform/chromium/fast/repaint/textarea-set-disabled-expected.png: Added. + 2011-12-08 Szilard Ledan ledan-muntean.szil...@stud.u-szeged.hu Add test for inline style block in HTML tag Added: trunk/LayoutTests/platform/chromium/fast/repaint/textarea-set-disabled-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium/fast/repaint/textarea-set-disabled-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/fast/repaint/textarea-set-disabled-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/fast/repaint/textarea-set-disabled-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102420] trunk/Tools
Title: [102420] trunk/Tools
Revision 102420
Author hay...@chromium.org
Date 2011-12-08 19:24:30 -0800 (Thu, 08 Dec 2011)
Log Message
[gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
https://bugs.webkit.org/show_bug.cgi?id=73980
Reviewed by Tony Chang.
* gdb/webkit.py:
(guess_string_length):
(ustring_to_string):
(lstring_to_string):
(LCharStringPrinter):
(LCharStringPrinter.to_string):
(WTFStringImplPrinter.get_length):
(WTFStringImplPrinter.to_string):
(WTFStringImplPrinter.is_8bit):
(WTFStringPrinter.stringimpl_ptr):
(WTFStringPrinter.get_length):
(WTFStringPrinter.to_string):
(add_pretty_printers.lookup_function):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/gdb/webkit.py
Diff
Modified: trunk/Tools/ChangeLog (102419 => 102420)
--- trunk/Tools/ChangeLog 2011-12-09 03:22:18 UTC (rev 102419)
+++ trunk/Tools/ChangeLog 2011-12-09 03:24:30 UTC (rev 102420)
@@ -1,3 +1,24 @@
+2011-12-08 Hayato Ito hay...@chromium.org
+
+[gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
+https://bugs.webkit.org/show_bug.cgi?id=73980
+
+Reviewed by Tony Chang.
+
+* gdb/webkit.py:
+(guess_string_length):
+(ustring_to_string):
+(lstring_to_string):
+(LCharStringPrinter):
+(LCharStringPrinter.to_string):
+(WTFStringImplPrinter.get_length):
+(WTFStringImplPrinter.to_string):
+(WTFStringImplPrinter.is_8bit):
+(WTFStringPrinter.stringimpl_ptr):
+(WTFStringPrinter.get_length):
+(WTFStringPrinter.to_string):
+(add_pretty_printers.lookup_function):
+
2011-12-08 Pierre Rossi pierre.ro...@gmail.com
Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
Modified: trunk/Tools/gdb/webkit.py (102419 => 102420)
--- trunk/Tools/gdb/webkit.py 2011-12-09 03:22:18 UTC (rev 102419)
+++ trunk/Tools/gdb/webkit.py 2011-12-09 03:24:30 UTC (rev 102420)
@@ -40,36 +40,51 @@
import struct
+def guess_string_length(ptr):
+Guess length of string pointed by ptr.
+
+Returns a tuple of (length, an error message).
+
+# Try to guess at the length.
+for i in xrange(0, 2048):
+try:
+if int((ptr + i).dereference()) == 0:
+return i, ''
+except RuntimeError:
+# We indexed into inaccessible memory; give up.
+return i, ' (gdb hit inaccessible memory)'
+return 256, ' (gdb found no trailing NUL)'
+
+
def ustring_to_string(ptr, length=None):
-Convert a pointer to UTF-16 data into a Python Unicode string.
+Convert a pointer to UTF-16 data into a Python string encoded with utf-8.
ptr and length are both gdb.Value objects.
If length is unspecified, will guess at the length.
-extra = ''
+error_message = ''
if length is None:
-# Try to guess at the length.
-for i in xrange(0, 2048):
-try:
-if int((ptr + i).dereference()) == 0:
-length = i
-break
-except RuntimeError:
-# We indexed into inaccessible memory; give up.
-length = i
-extra = u' (gdb hit inaccessible memory)'
-break
-if length is None:
-length = 256
-extra = u' (gdb found no trailing NUL)'
+length, error_message = guess_string_length(ptr)
else:
length = int(length)
-
char_vals = [int((ptr + i).dereference()) for i in xrange(length)]
-string = struct.pack('H' * length, *char_vals).decode('utf-16', 'replace')
+string = struct.pack('H' * length, *char_vals).decode('utf-16', 'replace').encode('utf-8')
+return string + error_message
-return string + extra
+def lstring_to_string(ptr, length=None):
+Convert a pointer to LChar* data into a Python (non-Unicode) string.
+ptr and length are both gdb.Value objects.
+If length is unspecified, will guess at the length.
+error_message = ''
+if length is None:
+length, error_message = guess_string_length(ptr)
+else:
+length = int(length)
+string = ''.join([chr((ptr + i).dereference()) for i in xrange(length)])
+return string + error_message
+
+
class StringPrinter(object):
Shared code between different string-printing classes
def __init__(self, val):
@@ -85,6 +100,12 @@
return ustring_to_string(self.val)
+class LCharStringPrinter(StringPrinter):
+Print a LChar*; we must guess at the length
+def to_string(self):
+return lstring_to_string(self.val)
+
+
class WTFAtomicStringPrinter(StringPrinter):
Print a WTF::AtomicString
def to_string(self):
@@ -100,50 +121,37 @@
return vector['m_buffer']['m_buffer']
-class WTFStringPrinter(StringPrinter):
-Print a WTF::String
+class WTFStringImplPrinter(StringPrinter):
+Print a WTF::StringImpl
def get_length(self):
-if not
[webkit-changes] [102421] trunk/LayoutTests
Title: [102421] trunk/LayoutTests
Revision 102421
Author commit-qu...@webkit.org
Date 2011-12-08 19:28:25 -0800 (Thu, 08 Dec 2011)
Log Message
Accessibility object searching layout tests are incomplete.
https://bugs.webkit.org/show_bug.cgi?id=74130
Patch by Sam White samuel.wh...@rochester.edu on 2011-12-08
Reviewed by Chris Fleizach.
Added a layout test to support visited link searching and removed frame searching
(which was unimplemented) as it's fully covered by the tests in:
platform/mac/accessibility/search-with-frames.html
* platform/mac/accessibility/search-predicate-expected.txt:
* platform/mac/accessibility/search-predicate.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt
trunk/LayoutTests/platform/mac/accessibility/search-predicate.html
Diff
Modified: trunk/LayoutTests/ChangeLog (102420 => 102421)
--- trunk/LayoutTests/ChangeLog 2011-12-09 03:24:30 UTC (rev 102420)
+++ trunk/LayoutTests/ChangeLog 2011-12-09 03:28:25 UTC (rev 102421)
@@ -1,3 +1,17 @@
+2011-12-08 Sam White samuel.wh...@rochester.edu
+
+Accessibility object searching layout tests are incomplete.
+https://bugs.webkit.org/show_bug.cgi?id=74130
+
+Reviewed by Chris Fleizach.
+
+Added a layout test to support visited link searching and removed frame searching
+(which was unimplemented) as it's fully covered by the tests in:
+platform/mac/accessibility/search-with-frames.html
+
+* platform/mac/accessibility/search-predicate-expected.txt:
+* platform/mac/accessibility/search-predicate.html:
+
2011-12-08 Kenneth Russell k...@google.com
Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context
Modified: trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt (102420 => 102421)
--- trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt 2011-12-09 03:24:30 UTC (rev 102420)
+++ trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt 2011-12-09 03:28:25 UTC (rev 102421)
@@ -97,8 +97,10 @@
PASS resultElement.role is 'AXRole: AXTextField'
PASS resultElement.role is 'AXRole: AXGroup'
PASS resultElement.childAtIndex(0).stringValue is 'AXValue: sans-serif black bold text with underline'
-PASS resultElement.role is 'AXRole: AXLink'
+PASS resultElement.boolAttributeValue('AXVisited') is false
PASS resultElement.childAtIndex(0).stringValue is 'AXValue: link'
+PASS resultElement.boolAttributeValue('AXVisited') is true
+PASS resultElement.childAtIndex(0).stringValue is 'AXValue: link'
PASS resultElement.role is 'AXRole: AXStaticText'
PASS resultElement.stringValue is 'AXValue: sans-serif black bold text with underline'
PASS successfullyParsed is true
Modified: trunk/LayoutTests/platform/mac/accessibility/search-predicate.html (102420 => 102421)
--- trunk/LayoutTests/platform/mac/accessibility/search-predicate.html 2011-12-09 03:24:30 UTC (rev 102420)
+++ trunk/LayoutTests/platform/mac/accessibility/search-predicate.html 2011-12-09 03:28:25 UTC (rev 102421)
@@ -43,201 +43,149 @@
description(This tests the ability to search for accessible elements by key or text.);
if (window.accessibilityController) {
+window.layoutTestController.keepWebHistory();
+
document.getElementById(body).focus();
var containerElement = accessibilityController.focusedElement;
var startElement;
-var isDirectionNext;
-var searchKey;
-var searchText = ;
var resultElement;
// Any element.
startElement = accessibilityController.focusedElement.childAtIndex(0);
-isDirectionNext = true;
-searchKey = AXAnyTypeSearchKey;
-resultElement = containerElement.uiElementForSearchPredicate(startElement, isDirectionNext, searchKey, searchText);
+resultElement = containerElement.uiElementForSearchPredicate(startElement, true, AXAnyTypeSearchKey, );
shouldBe(resultElement.role, 'AXRole: AXStaticText');
shouldBe(resultElement.stringValue, 'AXValue: first blockquote level 1');
// Same level blockquote.
startElement = accessibilityController.focusedElement.childAtIndex(0);
-isDirectionNext = true;
-searchKey = AXBlockquoteSameLevelSearchKey;
-resultElement = containerElement.uiElementForSearchPredicate(startElement, isDirectionNext, searchKey, searchText);
+resultElement = containerElement.uiElementForSearchPredicate(startElement, true, AXBlockquoteSameLevelSearchKey, );
shouldBe(resultElement.role, 'AXRole: AXGroup');
shouldBe(resultElement.childAtIndex(0).stringValue, 'AXValue: second blockquote level 1');
// Blockquote.
startElement = accessibilityController.focusedElement.childAtIndex(0);
-isDirectionNext = true;
-searchKey = AXBlockquoteSearchKey;
-resultElement =
[webkit-changes] [102423] trunk
Title: [102423] trunk
Revision 102423
Author hay...@chromium.org
Date 2011-12-08 20:16:26 -0800 (Thu, 08 Dec 2011)
Log Message
Suppress rendering of light children when ShadowRoot is dynamically created.
https://bugs.webkit.org/show_bug.cgi?id=72441
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html
fast/dom/shadow/dynamically-created-shadow-root.html
* dom/Element.cpp:
(WebCore::Element::setShadowRoot):
LayoutTests:
* fast/dom/shadow/dynamically-created-shadow-root-expected.html: Added.
* fast/dom/shadow/dynamically-created-shadow-root.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
Added Paths
trunk/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root-expected.html
trunk/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html
Diff
Modified: trunk/LayoutTests/ChangeLog (102422 => 102423)
--- trunk/LayoutTests/ChangeLog 2011-12-09 04:12:55 UTC (rev 102422)
+++ trunk/LayoutTests/ChangeLog 2011-12-09 04:16:26 UTC (rev 102423)
@@ -1,3 +1,13 @@
+2011-12-08 Hayato Ito hay...@chromium.org
+
+Suppress rendering of light children when ShadowRoot is dynamically created.
+https://bugs.webkit.org/show_bug.cgi?id=72441
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/shadow/dynamically-created-shadow-root-expected.html: Added.
+* fast/dom/shadow/dynamically-created-shadow-root.html: Added.
+
2011-12-08 Kenichi Ishibashi ba...@chromium.org
Unreviewed, chromium test rebaseline tests added in r102388. Updates expectations.
Added: trunk/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root-expected.html (0 => 102423)
--- trunk/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root-expected.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root-expected.html 2011-12-09 04:16:26 UTC (rev 102423)
@@ -0,0 +1,9 @@
+!DOCTYPE html
+body
+div
+This tests that dynamically created ShadowRoot should be rendered correctly.
+Can only run within DRT.
+/div
+divShadow should be rendered./div
+/body
+/html
Added: trunk/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html (0 => 102423)
--- trunk/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html 2011-12-09 04:16:26 UTC (rev 102423)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+body
+div
+This tests that dynamically created ShadowRoot should be rendered correctly.
+Can only run within DRT.
+/div
+div id=hostLight children should not be rendered./div
+script
+if (window.internals) {
+var host = document.querySelector('#host');
+var shadowRoot = window.internals.ensureShadowRoot(host);
+shadowRoot.appendChild(document.createTextNode('Shadow should be rendered.'));
+}
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (102422 => 102423)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 04:12:55 UTC (rev 102422)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 04:16:26 UTC (rev 102423)
@@ -1,3 +1,16 @@
+2011-12-08 Hayato Ito hay...@chromium.org
+
+Suppress rendering of light children when ShadowRoot is dynamically created.
+https://bugs.webkit.org/show_bug.cgi?id=72441
+
+Reviewed by Ryosuke Niwa.
+
+Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html
+ fast/dom/shadow/dynamically-created-shadow-root.html
+
+* dom/Element.cpp:
+(WebCore::Element::setShadowRoot):
+
2011-12-08 Pierre Rossi pierre.ro...@gmail.com
Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
Modified: trunk/Source/WebCore/dom/Element.cpp (102422 => 102423)
--- trunk/Source/WebCore/dom/Element.cpp 2011-12-09 04:12:55 UTC (rev 102422)
+++ trunk/Source/WebCore/dom/Element.cpp 2011-12-09 04:16:26 UTC (rev 102423)
@@ -1238,8 +1238,11 @@
shadowRoot-setShadowHost(this);
if (inDocument())
shadowRoot-insertedIntoDocument();
-if (attached())
+if (attached()) {
shadowRoot-lazyAttach();
+for (Node* child = firstChild(); child; child = child-nextSibling())
+child-detach();
+}
}
ShadowRoot* Element::ensureShadowRoot()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102424] trunk
Title: [102424] trunk
Revision 102424
Author ad...@chromium.org
Date 2011-12-08 20:19:48 -0800 (Thu, 08 Dec 2011)
Log Message
[MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
https://bugs.webkit.org/show_bug.cgi?id=73492
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/mutation/inline-event-listener.html
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy.
Tools:
Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
keypress event without any script on the stack.
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::keyDown):
(KeyDownTask::KeyDownTask):
(KeyDownTask::runIfValid):
(EventSender::scheduleAsynchronousKeyDown):
* DumpRenderTree/chromium/EventSender.h:
LayoutTests:
* fast/mutation/inline-event-listener-expected.txt: Added.
* fast/mutation/inline-event-listener.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/EventSender.cpp
trunk/Tools/DumpRenderTree/chromium/EventSender.h
Added Paths
trunk/LayoutTests/fast/mutation/inline-event-listener-expected.txt
trunk/LayoutTests/fast/mutation/inline-event-listener.html
Diff
Modified: trunk/LayoutTests/ChangeLog (102423 => 102424)
--- trunk/LayoutTests/ChangeLog 2011-12-09 04:16:26 UTC (rev 102423)
+++ trunk/LayoutTests/ChangeLog 2011-12-09 04:19:48 UTC (rev 102424)
@@ -1,3 +1,13 @@
+2011-12-08 Adam Klein ad...@chromium.org
+
+[MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
+https://bugs.webkit.org/show_bug.cgi?id=73492
+
+Reviewed by Adam Barth.
+
+* fast/mutation/inline-event-listener-expected.txt: Added.
+* fast/mutation/inline-event-listener.html: Added.
+
2011-12-08 Hayato Ito hay...@chromium.org
Suppress rendering of light children when ShadowRoot is dynamically created.
Added: trunk/LayoutTests/fast/mutation/inline-event-listener-expected.txt (0 => 102424)
--- trunk/LayoutTests/fast/mutation/inline-event-listener-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/mutation/inline-event-listener-expected.txt 2011-12-09 04:19:48 UTC (rev 102424)
@@ -0,0 +1 @@
+PASSED
Added: trunk/LayoutTests/fast/mutation/inline-event-listener.html (0 => 102424)
--- trunk/LayoutTests/fast/mutation/inline-event-listener.html (rev 0)
+++ trunk/LayoutTests/fast/mutation/inline-event-listener.html 2011-12-09 04:19:48 UTC (rev 102424)
@@ -0,0 +1,18 @@
+!DOCTYPE html
+ol contenteditable _oninput_=document.body.innerHTML = observerRan ? 'FAILED' : 'PASSED'; if (window.layoutTestController) layoutTestController.notifyDone()
+liPress enter
+/ol
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+var list = document.querySelector('ol');
+var observerRan = false;
+var observer = new WebKitMutationObserver(function() { observerRan = true; });
+observer.observe(list, {childList: true, characterData: true});
+list.focus();
+if (window.eventSender)
+eventSender.scheduleAsynchronousKeyDown('\n');
+/script
Modified: trunk/Source/WebCore/ChangeLog (102423 => 102424)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 04:16:26 UTC (rev 102423)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 04:19:48 UTC (rev 102424)
@@ -1,3 +1,15 @@
+2011-12-08 Adam Klein ad...@chromium.org
+
+[MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
+https://bugs.webkit.org/show_bug.cgi?id=73492
+
+Reviewed by Adam Barth.
+
+Test: fast/mutation/inline-event-listener.html
+
+* bindings/v8/V8LazyEventListener.cpp:
+(WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy.
+
2011-12-08 Hayato Ito hay...@chromium.org
Suppress rendering of light children when ShadowRoot is dynamically created.
Modified: trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp (102423 => 102424)
--- trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp 2011-12-09 04:16:26 UTC (rev 102423)
+++ trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp 2011-12-09 04:19:48 UTC (rev 102424)
@@ -123,7 +123,9 @@
v8::Handlev8::String codeExternalString = v8ExternalString(code);
v8::Handlev8::Script script = V8Proxy::compileScript(codeExternalString, m_sourceURL, m_position);
if (!script.IsEmpty()) {
-v8::Localv8::Value value = proxy-runScript(script);
+// Call v8::Script::Run() directly to avoid an erroneous call to V8RecursionScope::didLeaveScriptContext().
+// FIXME: Remove this code when we stop doing the 'with' hack above.
+
[webkit-changes] [102425] trunk
Title: [102425] trunk
Revision 102425
Author commit-qu...@webkit.org
Date 2011-12-08 20:22:14 -0800 (Thu, 08 Dec 2011)
Log Message
Unreviewed, rolling out r101619.
http://trac.webkit.org/changeset/101619
https://bugs.webkit.org/show_bug.cgi?id=74158
this patch produces bad behaviour on mac (Requested by
jeremya_ on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-12-08
Source/WebCore:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dragSourceEndedAt):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState):
LayoutTests:
* fast/css/hover-active-drag-expected.txt: Removed.
* fast/css/hover-active-drag.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
Removed Paths
trunk/LayoutTests/fast/css/hover-active-drag-expected.txt
trunk/LayoutTests/fast/css/hover-active-drag.html
Diff
Modified: trunk/LayoutTests/ChangeLog (102424 => 102425)
--- trunk/LayoutTests/ChangeLog 2011-12-09 04:19:48 UTC (rev 102424)
+++ trunk/LayoutTests/ChangeLog 2011-12-09 04:22:14 UTC (rev 102425)
@@ -1,3 +1,15 @@
+2011-12-08 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r101619.
+http://trac.webkit.org/changeset/101619
+https://bugs.webkit.org/show_bug.cgi?id=74158
+
+this patch produces bad behaviour on mac (Requested by
+jeremya_ on #webkit).
+
+* fast/css/hover-active-drag-expected.txt: Removed.
+* fast/css/hover-active-drag.html: Removed.
+
2011-12-08 Adam Klein ad...@chromium.org
[MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
Deleted: trunk/LayoutTests/fast/css/hover-active-drag-expected.txt (102424 => 102425)
--- trunk/LayoutTests/fast/css/hover-active-drag-expected.txt 2011-12-09 04:19:48 UTC (rev 102424)
+++ trunk/LayoutTests/fast/css/hover-active-drag-expected.txt 2011-12-09 04:22:14 UTC (rev 102425)
@@ -1,20 +0,0 @@
-Dragging out of an element should cause it to lose :hover
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-PASS background is rgb(255, 0, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(255, 255, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 255, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 255, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 0, 0)
-PASS background is rgb(0, 0, 0)
-
-
-
-
-
-
Deleted: trunk/LayoutTests/fast/css/hover-active-drag.html (102424 => 102425)
--- trunk/LayoutTests/fast/css/hover-active-drag.html 2011-12-09 04:19:48 UTC (rev 102424)
+++ trunk/LayoutTests/fast/css/hover-active-drag.html 2011-12-09 04:22:14 UTC (rev 102425)
@@ -1,57 +0,0 @@
-!DOCTYPE html
-style
- div { background: rgb(0, 0, 0); }
- div:hover { background: rgb(255, 0, 0); }
- div:hover:active { background: rgb(255, 255, 0); }
- div:active { background: rgb(0, 255, 0); }
- div {
-width: 100px;
-height: 100px;
-border: 2px solid rgb(0, 0, 255);
- }
-/style
-
-body
- div id=box/div
- div id=box2/div
- pre id=description/div
- pre id=console/pre
-/body
-
-script src=""
-script
- function backgroundOf(element) {
-return getComputedStyle(element, null).getPropertyValue(background-color)
- }
- function shouldHaveBackground(element, bg) {
-background = "" null).getPropertyValue(background-color)
-shouldBeEqualToString('background', bg)
- }
- if (window.layoutTestController) {
-description(Dragging out of an element should cause it to lose :hover)
-var box = document.getElementById('box')
-var box2 = document.getElementById('box2')
-layoutTestController.dumpAsText();
-
-eventSender.dragMode = false;
-eventSender.mouseMoveTo(50, 50)
-shouldHaveBackground(box, 'rgb(255, 0, 0)')
-shouldHaveBackground(box2, 'rgb(0, 0, 0)')
-
-eventSender.mouseDown()
-shouldHaveBackground(box, 'rgb(255, 255, 0)')
-shouldHaveBackground(box2, 'rgb(0, 0, 0)')
-
-eventSender.mouseMoveTo(50, 150)
-shouldHaveBackground(box, 'rgb(0, 255, 0)')
-shouldHaveBackground(box2, 'rgb(0, 0, 0)')
-
-eventSender.mouseMoveTo(400, 50)
-shouldHaveBackground(box, 'rgb(0, 255, 0)')
-shouldHaveBackground(box2, 'rgb(0, 0, 0)')
-
-eventSender.mouseUp()
-shouldHaveBackground(box, 'rgb(0, 0, 0)')
-shouldHaveBackground(box2, 'rgb(0, 0, 0)')
- }
-/script
Modified: trunk/Source/WebCore/ChangeLog (102424 => 102425)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 04:19:48 UTC (rev 102424)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 04:22:14 UTC (rev 102425)
@@ -1,3 +1,18 @@
+2011-12-08 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r101619.
+http://trac.webkit.org/changeset/101619
+https://bugs.webkit.org/show_bug.cgi?id=74158
+
+this patch produces bad
[webkit-changes] [102426] trunk/Source/WebCore
Title: [102426] trunk/Source/WebCore Revision 102426 Author commit-qu...@webkit.org Date 2011-12-08 20:37:41 -0800 (Thu, 08 Dec 2011) Log Message Upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent https://bugs.webkit.org/show_bug.cgi?id=73534 Patch by Mary Wu mary...@torchmobile.com.cn on 2011-12-08 Reviewed by Rob Buis. Other main contributors: Mike Fenton mifen...@rim.com Joe Mason jma...@rim.com Max Feil mf...@qnx.com Lukas Sydorowski lsydorow...@rim.com Crystal Zhang haizh...@rim.com Initial upstream, no new tests. * platform/blackberry/MIMETypeRegistryBlackBerry.cpp: Added. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType): * platform/blackberry/PlatformKeyboardEventBlackBerry.cpp: Added. (WebCore::keyIdentifierForBlackBerryCharacter): (WebCore::windowsKeyCodeForBlackBerryCharacter): (WebCore::adjustCharacterFromOS): (WebCore::toWebCorePlatformKeyboardEventType): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Modified Paths trunk/Source/WebCore/ChangeLog Added Paths trunk/Source/WebCore/platform/blackberry/MIMETypeRegistryBlackBerry.cpp trunk/Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (102425 => 102426) --- trunk/Source/WebCore/ChangeLog 2011-12-09 04:22:14 UTC (rev 102425) +++ trunk/Source/WebCore/ChangeLog 2011-12-09 04:37:41 UTC (rev 102426) @@ -1,3 +1,33 @@ +2011-12-08 Mary Wu mary...@torchmobile.com.cn + +Upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent +https://bugs.webkit.org/show_bug.cgi?id=73534 + +Reviewed by Rob Buis. + +Other main contributors: +Mike Fenton mifen...@rim.com +Joe Mason jma...@rim.com +Max Feil mf...@qnx.com +Lukas Sydorowski lsydorow...@rim.com +Crystal Zhang haizh...@rim.com + +Initial upstream, no new tests. + +* platform/blackberry/MIMETypeRegistryBlackBerry.cpp: Added. +(WebCore::MIMETypeRegistry::getMIMETypeForExtension): +(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): +(WebCore::MIMETypeRegistry::isApplicationPluginMIMEType): +* platform/blackberry/PlatformKeyboardEventBlackBerry.cpp: Added. +(WebCore::keyIdentifierForBlackBerryCharacter): +(WebCore::windowsKeyCodeForBlackBerryCharacter): +(WebCore::adjustCharacterFromOS): +(WebCore::toWebCorePlatformKeyboardEventType): +(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): +(WebCore::PlatformKeyboardEvent::currentCapsLockState): +(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): +(WebCore::PlatformKeyboardEvent::getCurrentModifierState): + 2011-12-08 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r101619. Added: trunk/Source/WebCore/platform/blackberry/MIMETypeRegistryBlackBerry.cpp (0 => 102426) --- trunk/Source/WebCore/platform/blackberry/MIMETypeRegistryBlackBerry.cpp (rev 0) +++ trunk/Source/WebCore/platform/blackberry/MIMETypeRegistryBlackBerry.cpp 2011-12-09 04:37:41 UTC (rev 102426) @@ -0,0 +1,141 @@ +/* + * Copyright (C) 2006 Zack Rusin z...@kde.org + * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. + * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) + * Copyright (C) 2008, 2009, 2010, 2011 Research In Motion Limited. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR + * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, + * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, + * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY + * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF
[webkit-changes] [102428] trunk/Source/WebCore
Title: [102428] trunk/Source/WebCore
Revision 102428
Author tk...@chromium.org
Date 2011-12-08 21:00:25 -0800 (Thu, 08 Dec 2011)
Log Message
Build fix for r102419.
https://bugs.webkit.org/show_bug.cgi?id=73916
* platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::listBoxSelectItem):
Remove unused argument names.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PopupMenuClient.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (102427 => 102428)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 04:51:22 UTC (rev 102427)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 05:00:25 UTC (rev 102428)
@@ -1,3 +1,12 @@
+2011-12-08 Kent Tamura tk...@chromium.org
+
+Build fix for r102419.
+https://bugs.webkit.org/show_bug.cgi?id=73916
+
+* platform/PopupMenuClient.h:
+(WebCore::PopupMenuClient::listBoxSelectItem):
+Remove unused argument names.
+
2011-12-08 Kentaro Hara hara...@chromium.org
Unreviewed. Rebaselined run-bindings-tests results.
Modified: trunk/Source/WebCore/platform/PopupMenuClient.h (102427 => 102428)
--- trunk/Source/WebCore/platform/PopupMenuClient.h 2011-12-09 04:51:22 UTC (rev 102427)
+++ trunk/Source/WebCore/platform/PopupMenuClient.h 2011-12-09 05:00:25 UTC (rev 102428)
@@ -63,7 +63,7 @@
virtual bool valueShouldChangeOnHotTrack() const = 0;
virtual void setTextFromItem(unsigned listIndex) = 0;
-virtual void listBoxSelectItem(int listIndex, bool allowMultiplySelections, bool shift, bool fireOnChangeNow = true) { ASSERT_NOT_REACHED(); }
+virtual void listBoxSelectItem(int /*listIndex*/, bool /*allowMultiplySelections*/, bool /*shift*/, bool /*fireOnChangeNow*/ = true) { ASSERT_NOT_REACHED(); }
virtual bool multiple()
{
ASSERT_NOT_REACHED();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102429] trunk/Source
Title: [102429] trunk/Source
Revision 102429
Author fsam...@chromium.org
Date 2011-12-08 21:15:18 -0800 (Thu, 08 Dec 2011)
Log Message
[Chromium] Enable viewport metatag
https://bugs.webkit.org/show_bug.cgi?id=73495
Reviewed by Darin Fisher.
Source/_javascript_Core:
* wtf/Platform.h: Added ENABLE(VIEWPORT) tag.
Source/WebCore:
Recompute viewpot parameters on frame rect resize.
* page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
Source/WebKit/chromium:
Compute the appropriate fixed layout size, page, and device scale factors,
based on the viewport meta tag parameters.
See http://developer.android.com/guide/webapps/targeting.html for more information.
* features.gypi:
* public/WebView.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::layoutUpdated):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* src/ChromeClientImpl.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::isPageScaleFactorSet):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::observeNewNavigation):
* src/WebViewImpl.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp
trunk/Source/WebKit/chromium/src/ChromeClientImpl.h
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (102428 => 102429)
--- trunk/Source/_javascript_Core/ChangeLog 2011-12-09 05:00:25 UTC (rev 102428)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-12-09 05:15:18 UTC (rev 102429)
@@ -1,3 +1,12 @@
+2011-12-08 Fady Samuel fsam...@chromium.org
+
+[Chromium] Enable viewport metatag
+https://bugs.webkit.org/show_bug.cgi?id=73495
+
+Reviewed by Darin Fisher.
+
+* wtf/Platform.h: Added ENABLE(VIEWPORT) tag.
+
2011-12-08 Adam Klein ad...@chromium.org
Use HashMapNode*, OwnPtr... in ChildListMutationScope
Modified: trunk/Source/_javascript_Core/wtf/Platform.h (102428 => 102429)
--- trunk/Source/_javascript_Core/wtf/Platform.h 2011-12-09 05:00:25 UTC (rev 102428)
+++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-12-09 05:15:18 UTC (rev 102429)
@@ -857,6 +857,10 @@
#define ENABLE_GESTURE_RECOGNIZER 0
#endif
+#if !defined(ENABLE_VIEWPORT)
+#define ENABLE_VIEWPORT 0
+#endif
+
#if !defined(ENABLE_NOTIFICATIONS)
#define ENABLE_NOTIFICATIONS 0
#endif
Modified: trunk/Source/WebCore/ChangeLog (102428 => 102429)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 05:00:25 UTC (rev 102428)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 05:15:18 UTC (rev 102429)
@@ -1,3 +1,15 @@
+2011-12-08 Fady Samuel fsam...@chromium.org
+
+[Chromium] Enable viewport metatag
+https://bugs.webkit.org/show_bug.cgi?id=73495
+
+Reviewed by Darin Fisher.
+
+Recompute viewpot parameters on frame rect resize.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::setFrameRect):
+
2011-12-08 Kent Tamura tk...@chromium.org
Build fix for r102419.
Modified: trunk/Source/WebCore/page/FrameView.cpp (102428 => 102429)
--- trunk/Source/WebCore/page/FrameView.cpp 2011-12-09 05:00:25 UTC (rev 102428)
+++ trunk/Source/WebCore/page/FrameView.cpp 2011-12-09 05:15:18 UTC (rev 102429)
@@ -405,6 +405,16 @@
if (newRect == oldRect)
return;
+#if ENABLE(VIEWPORT)
+if (useFixedLayout()) {
+Document* document = m_frame-document();
+ViewportArguments viewport = document-viewportArguments();
+Page* page = frame() ? frame()-page() : 0;
+if (page)
+page-chrome()-client()-dispatchViewportPropertiesDidChange(viewport);
+}
+#endif
+
ScrollView::setFrameRect(newRect);
#if USE(ACCELERATED_COMPOSITING)
Modified: trunk/Source/WebKit/chromium/ChangeLog (102428 => 102429)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-09 05:00:25 UTC (rev 102428)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-09 05:15:18 UTC (rev 102429)
@@ -1,3 +1,31 @@
+2011-12-08 Fady Samuel fsam...@chromium.org
+
+[Chromium] Enable viewport metatag
+https://bugs.webkit.org/show_bug.cgi?id=73495
+
+Reviewed by Darin Fisher.
+
+Compute the appropriate fixed layout size, page, and device scale factors,
+based on the viewport meta tag parameters.
+
+See http://developer.android.com/guide/webapps/targeting.html for more information.
+
+
+* features.gypi:
+* public/WebView.h:
+* src/ChromeClientImpl.cpp:
+(WebKit::ChromeClientImpl::layoutUpdated):
+
[webkit-changes] [102431] trunk/Source/WebCore
Title: [102431] trunk/Source/WebCore
Revision 102431
Author rn...@webkit.org
Date 2011-12-08 21:26:58 -0800 (Thu, 08 Dec 2011)
Log Message
It's semantically incorrect to call notifyNodeListsAttributeChanged in dispatchSubtreeModifiedEvent
https://bugs.webkit.org/show_bug.cgi?id=74028
Reviewed by Darin Adler.
Remove a call to notifyNodeListsAttributeChanged in dispatchSubtreeModified and add explicit calls
to notifyNodeListsAttributeChanged at appropriate places.
Also merge notifyNodeListsChildrenChanged with notifyLocalNodeListsChildrenChanged, and
notifyNodeListsAttributeChanged with notifyLocalNodeListsAttributeChanged, and rename them to
invalidateNodeListsCacheAfterAttributeChanges and invalidateNodeListsCacheAfterNodeChanges respectively.
* dom/Attr.cpp:
(WebCore::Attr::childrenChanged):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
* dom/Document.cpp:
(WebCore::Document::updateRangesAfterNodeChanges):
* dom/Document.h:
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
* dom/Node.cpp:
(WebCore::removeNodeListCacheIfPossible):
(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanges):
(WebCore::Node::invalidateNodeListsCacheAfterNodeChanges):
(WebCore::Node::dispatchSubtreeModifiedEvent):
* dom/Node.h:
* dom/NodeRareData.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Attr.cpp
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/NamedNodeMap.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/NodeRareData.h
trunk/Source/WebCore/dom/StyledElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (102430 => 102431)
--- trunk/Source/WebCore/ChangeLog 2011-12-09 05:23:18 UTC (rev 102430)
+++ trunk/Source/WebCore/ChangeLog 2011-12-09 05:26:58 UTC (rev 102431)
@@ -1,3 +1,38 @@
+2011-12-08 Ryosuke Niwa rn...@webkit.org
+
+It's semantically incorrect to call notifyNodeListsAttributeChanged in dispatchSubtreeModifiedEvent
+https://bugs.webkit.org/show_bug.cgi?id=74028
+
+Reviewed by Darin Adler.
+
+Remove a call to notifyNodeListsAttributeChanged in dispatchSubtreeModified and add explicit calls
+to notifyNodeListsAttributeChanged at appropriate places.
+
+Also merge notifyNodeListsChildrenChanged with notifyLocalNodeListsChildrenChanged, and
+notifyNodeListsAttributeChanged with notifyLocalNodeListsAttributeChanged, and rename them to
+invalidateNodeListsCacheAfterAttributeChanges and invalidateNodeListsCacheAfterNodeChanges respectively.
+
+* dom/Attr.cpp:
+(WebCore::Attr::childrenChanged):
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::childrenChanged):
+* dom/Document.cpp:
+(WebCore::Document::updateRangesAfterNodeChanges):
+* dom/Document.h:
+* dom/NamedNodeMap.cpp:
+(WebCore::NamedNodeMap::addAttribute):
+(WebCore::NamedNodeMap::removeAttribute):
+* dom/Node.cpp:
+(WebCore::removeNodeListCacheIfPossible):
+(WebCore::Node::unregisterDynamicNodeList):
+(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanges):
+(WebCore::Node::invalidateNodeListsCacheAfterNodeChanges):
+(WebCore::Node::dispatchSubtreeModifiedEvent):
+* dom/Node.h:
+* dom/NodeRareData.h:
+* dom/StyledElement.cpp:
+(WebCore::StyledElement::classAttributeChanged):
+
2011-12-08 Kenichi Ishibashi ba...@chromium.org
Unreviewed, rolling out r102418.
Modified: trunk/Source/WebCore/dom/Attr.cpp (102430 => 102431)
--- trunk/Source/WebCore/dom/Attr.cpp 2011-12-09 05:23:18 UTC (rev 102430)
+++ trunk/Source/WebCore/dom/Attr.cpp 2011-12-09 05:26:58 UTC (rev 102431)
@@ -170,6 +170,8 @@
Node::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta);
+invalidateNodeListsCacheAfterAttributeChanged();
+
// FIXME: We should include entity references in the value
String val = ;
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (102430 => 102431)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2011-12-09 05:23:18 UTC (rev 102430)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2011-12-09 05:26:58 UTC (rev 102431)
@@ -843,9 +843,9 @@
{
Node::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta);
if (!changedByParser childCountDelta)
-document()-nodeChildrenChanged(this);
+document()-updateRangesAfterChildrenChanged(this);
if (treeScope()-hasNodeListCaches())
-notifyNodeListsChildrenChanged();
+invalidateNodeListsCacheAfterChildrenChanged();
}
void ContainerNode::cloneChildNodes(ContainerNode *clone)
Modified:
[webkit-changes] [102432] trunk/LayoutTests
Title: [102432] trunk/LayoutTests Revision 102432 Author ba...@chromium.org Date 2011-12-08 21:36:35 -0800 (Thu, 08 Dec 2011) Log Message Unreviewed, rebaseline fast/repaint/textarea-set-disabled.html for Chromium Linux. Patch by Kenichi Ishibashi ba...@chromium.org on 2011-12-08 * platform/chromium-linux/fast/repaint/textarea-set-disabled-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-linux/fast/repaint/textarea-set-disabled-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (102431 => 102432) --- trunk/LayoutTests/ChangeLog 2011-12-09 05:26:58 UTC (rev 102431) +++ trunk/LayoutTests/ChangeLog 2011-12-09 05:36:35 UTC (rev 102432) @@ -1,5 +1,12 @@ 2011-12-08 Kenichi Ishibashi ba...@chromium.org +Unreviewed, rebaseline fast/repaint/textarea-set-disabled.html for +Chromium Linux. + +* platform/chromium-linux/fast/repaint/textarea-set-disabled-expected.png: Added. + +2011-12-08 Kenichi Ishibashi ba...@chromium.org + Unreviewed, rolling out r102418. http://trac.webkit.org/changeset/102418 https://bugs.webkit.org/show_bug.cgi?id=71870 Added: trunk/LayoutTests/platform/chromium-linux/fast/repaint/textarea-set-disabled-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/repaint/textarea-set-disabled-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102434] trunk/LayoutTests
Title: [102434] trunk/LayoutTests Revision 102434 Author ba...@chromium.org Date 2011-12-08 22:53:47 -0800 (Thu, 08 Dec 2011) Log Message Unreviewed, chromium test expectation update. Patch by Kenichi Ishibashi ba...@chromium.org on 2011-12-08 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (102433 => 102434) --- trunk/LayoutTests/ChangeLog 2011-12-09 06:43:42 UTC (rev 102433) +++ trunk/LayoutTests/ChangeLog 2011-12-09 06:53:47 UTC (rev 102434) @@ -1,5 +1,11 @@ 2011-12-08 Kenichi Ishibashi ba...@chromium.org +Unreviewed, chromium test expectation update. + +* platform/chromium/test_expectations.txt: + +2011-12-08 Kenichi Ishibashi ba...@chromium.org + Unreviewed, rebaseline fast/repaint/textarea-set-disabled.html for Chromium Linux. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102433 => 102434) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-09 06:43:42 UTC (rev 102433) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-09 06:53:47 UTC (rev 102434) @@ -3801,3 +3801,5 @@ BUGWK74157 SNOWLEOPARD : animations/cross-fade-border-image-source.html = IMAGE+TEXT BUGWK74157 SNOWLEOPARD LEOPARD : transitions/cross-fade-border-image.html = IMAGE+TEXT + +BUGWK74167 WIN LINUX : fast/replaced/width100percent-textarea.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102436] tags/Safari-535.12/
Title: [102436] tags/Safari-535.12/ Revision 102436 Author lforsch...@apple.com Date 2011-12-08 22:59:29 -0800 (Thu, 08 Dec 2011) Log Message New Tag. Added Paths tags/Safari-535.12/ Diff Property changes: tags/Safari-535.12 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102437] trunk/Source
Title: [102437] trunk/Source Revision 102437 Author lforsch...@apple.com Date 2011-12-08 23:01:50 -0800 (Thu, 08 Dec 2011) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/_javascript_Glue/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (102436 => 102437) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2011-12-09 06:59:29 UTC (rev 102436) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2011-12-09 07:01:50 UTC (rev 102437) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 12; +MINOR_VERSION = 13; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/_javascript_Glue/Configurations/Version.xcconfig (102436 => 102437) --- trunk/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-12-09 06:59:29 UTC (rev 102436) +++ trunk/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-12-09 07:01:50 UTC (rev 102437) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 12; +MINOR_VERSION = 13; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (102436 => 102437) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2011-12-09 06:59:29 UTC (rev 102436) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2011-12-09 07:01:50 UTC (rev 102437) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 12; +MINOR_VERSION = 13; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (102436 => 102437) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2011-12-09 06:59:29 UTC (rev 102436) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2011-12-09 07:01:50 UTC (rev 102437) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 12; +MINOR_VERSION = 13; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (102436 => 102437) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2011-12-09 06:59:29 UTC (rev 102436) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2011-12-09 07:01:50 UTC (rev 102437) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 12; +MINOR_VERSION = 13; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102438] trunk/LayoutTests
Title: [102438] trunk/LayoutTests Revision 102438 Author ba...@chromium.org Date 2011-12-08 23:26:47 -0800 (Thu, 08 Dec 2011) Log Message Unreviewed, rebaseline fast/forms/select-listbox-multiple-no-focusring.html Patch by Kenichi Ishibashi ba...@chromium.org on 2011-12-08 * platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (102437 => 102438) --- trunk/LayoutTests/ChangeLog 2011-12-09 07:01:50 UTC (rev 102437) +++ trunk/LayoutTests/ChangeLog 2011-12-09 07:26:47 UTC (rev 102438) @@ -1,5 +1,11 @@ 2011-12-08 Kenichi Ishibashi ba...@chromium.org +Unreviewed, rebaseline fast/forms/select-listbox-multiple-no-focusring.html + +* platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png: + +2011-12-08 Kenichi Ishibashi ba...@chromium.org + Unreviewed, chromium test expectation update. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
