[webkit-changes] [103033] trunk/LayoutTests

[morrita]

Title: [103033] trunk/LayoutTests








Revision 103033
Author morr...@google.com
Date 2011-12-15 23:55:16 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed expectations update.

* html5lib/webkit-resumer-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/html5lib/webkit-resumer-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (103032 => 103033)

--- trunk/LayoutTests/ChangeLog	2011-12-16 07:26:13 UTC (rev 103032)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 07:55:16 UTC (rev 103033)
@@ -1,3 +1,9 @@
+2011-12-15  Hajime Morrita 
+
+Unreviewed expectations update.
+
+* html5lib/webkit-resumer-expected.txt:
+
 2011-12-15  Hajime Morrita  
 
 Unreviewed test_expectations.txt update.


Modified: trunk/LayoutTests/html5lib/webkit-resumer-expected.txt (103032 => 103033)

--- trunk/LayoutTests/html5lib/webkit-resumer-expected.txt	2011-12-16 07:26:13 UTC (rev 103032)
+++ trunk/LayoutTests/html5lib/webkit-resumer-expected.txt	2011-12-16 07:55:16 UTC (rev 103033)
@@ -156,124 +156,4 @@
 CONSOLE MESSAGE: line 2: FOOBARBAZ
 CONSOLE MESSAGE: line 2: FOOBARBAZ
 CONSOLE MESSAGE: line 2: FOOBARBAZ
-resources/webkit01.dat:
-818.1
-819.2
-820.3
-821.4
-822.5
-823.6
-824.7
-825.8
-826.9
-827.10
-828.11
-829.12
-830.13
-831.14
-832.15
-833.16
-834.17
-835.18
-836.19
-837.20
-838.21
-839.22
-840.23
-841.24
-842.25
-843.26
-844.27
-845.28
-846.29
-847.30
-848.31
-849.32
-850.33
-851.34
-852.35
-853.36
-854.37
-855.38
-856.39
-857.40
-858.41
-859.42
-860.43
-861.44
-862.45
-863.46
-864.47
-865.48
-866.49
-867.50
-868.51
-869.52
-870.53
-871.54
-872.55
-873.56
-874.57
-875.58
-876.59
-877.60
-878.1
-879.2
-880.3
-881.4
-882.5
-883.6
-884.7
-885.8
-886.9
-887.10
-888.11
-889.12
-890.13
-891.14
-892.15
-893.16
-894.17
-895.18
-896.19
-897.20
-898.21
-899.22
-900.23
-901.24
-902.25
-903.26
-904.27
-905.28
-906.29
-907.30
-908.31
-909.32
-910.33
-911.34
-912.35
-913.36
-914.37
-915.38
-916.39
-917.40
-918.41
-919.42
-920.43
-921.44
-922.45
-923.46
-924.47
-925.48
-926.49
-927.50
-928.51
-929.52
-930.53
-931.54
-932.55
-933.56
-934.57
-935.58
-936.59
-937.60
+resources/webkit01.dat: PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103032] trunk/LayoutTests

[morrita]

Title: [103032] trunk/LayoutTests








Revision 103032
Author morr...@google.com
Date 2011-12-15 23:26:13 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed test_expectations.txt update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (103031 => 103032)

--- trunk/LayoutTests/ChangeLog	2011-12-16 07:18:05 UTC (rev 103031)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 07:26:13 UTC (rev 103032)
@@ -1,3 +1,9 @@
+2011-12-15  Hajime Morrita  
+
+Unreviewed test_expectations.txt update.
+
+* platform/chromium/test_expectations.txt:
+
 2011-12-15  Dominic Mazzoni  
 
 Unreviewed Chromium test expectations update.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103031 => 103032)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-16 07:18:05 UTC (rev 103031)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-16 07:26:13 UTC (rev 103032)
@@ -4014,3 +4014,5 @@
 BUGWK74662 MAC : fast/text/unicode-variation-selector.html = PASS CRASH
 
 BUGWK74634 WIN : compositing/absolute-position-changed-with-composited-parent-layer.html = IMAGE
+
+BUGWK74688  : fast/css/bidi-override-in-anonymous-block.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103031] trunk/Source/WebCore

[commit-queue]

Title: [103031] trunk/Source/WebCore








Revision 103031
Author commit-qu...@webkit.org
Date 2011-12-15 23:18:05 -0800 (Thu, 15 Dec 2011)


Log Message
Don't create empty files on error.
https://bugs.webkit.org/show_bug.cgi?id=74373

Patch by Rafael Ávila de Espíndola  on 2011-12-15
Reviewed by Ryosuke Niwa.

* css/makeprop.pl:
* css/makevalues.pl:
* make-hash-tools.pl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/makeprop.pl
trunk/Source/WebCore/css/makevalues.pl
trunk/Source/WebCore/make-hash-tools.pl




Diff

Modified: trunk/Source/WebCore/ChangeLog (103030 => 103031)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 07:14:30 UTC (rev 103030)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 07:18:05 UTC (rev 103031)
@@ -1,3 +1,14 @@
+2011-12-15  Rafael Ávila de Espíndola  
+
+Don't create empty files on error.
+https://bugs.webkit.org/show_bug.cgi?id=74373
+
+Reviewed by Ryosuke Niwa.
+
+* css/makeprop.pl:
+* css/makevalues.pl:
+* make-hash-tools.pl:
+
 2011-12-15  Yongjun Zhang  
 
 PODIntervalTree takes 1.7MB memory on www.nytimes.com.


Modified: trunk/Source/WebCore/css/makeprop.pl (103030 => 103031)

--- trunk/Source/WebCore/css/makeprop.pl	2011-12-16 07:14:30 UTC (rev 103030)
+++ trunk/Source/WebCore/css/makeprop.pl	2011-12-16 07:18:05 UTC (rev 103031)
@@ -200,4 +200,4 @@
 
 close HEADER;
 
-system("gperf --key-positions=\"*\" -D -n -s 2 CSSPropertyNames.gperf > CSSPropertyNames.cpp") == 0 || die "calling gperf failed: $?";
+system("gperf --key-positions=\"*\" -D -n -s 2 CSSPropertyNames.gperf --output-file=CSSPropertyNames.cpp") == 0 || die "calling gperf failed: $?";


Modified: trunk/Source/WebCore/css/makevalues.pl (103030 => 103031)

--- trunk/Source/WebCore/css/makevalues.pl	2011-12-16 07:14:30 UTC (rev 103030)
+++ trunk/Source/WebCore/css/makevalues.pl	2011-12-16 07:18:05 UTC (rev 103031)
@@ -155,4 +155,4 @@
 EOF
 close HEADER;
 
-system("gperf --key-positions=\"*\" -D -n -s 2 CSSValueKeywords.gperf > CSSValueKeywords.cpp") == 0 || die "calling gperf failed: $?";
+system("gperf --key-positions=\"*\" -D -n -s 2 CSSValueKeywords.gperf --output-file=CSSValueKeywords.cpp") == 0 || die "calling gperf failed: $?";


Modified: trunk/Source/WebCore/make-hash-tools.pl (103030 => 103031)

--- trunk/Source/WebCore/make-hash-tools.pl	2011-12-16 07:14:30 UTC (rev 103030)
+++ trunk/Source/WebCore/make-hash-tools.pl	2011-12-16 07:18:05 UTC (rev 103031)
@@ -33,7 +33,7 @@
 my $colorDataGperf = $ARGV[0];
 shift;
 
-system("gperf --key-positions=\"*\" -D -s 2 $colorDataGperf > $colorDataGenerated") == 0 || die "calling gperf failed: $?";
+system("gperf --key-positions=\"*\" -D -s 2 $colorDataGperf --output-file=$colorDataGenerated") == 0 || die "calling gperf failed: $?";
 
 } else {
 die "Unknown option.";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103030] trunk/Source

[commit-queue]

Title: [103030] trunk/Source








Revision 103030
Author commit-qu...@webkit.org
Date 2011-12-15 23:14:30 -0800 (Thu, 15 Dec 2011)


Log Message
PODIntervalTree takes 1.7MB memory on www.nytimes.com.
https://bugs.webkit.org/show_bug.cgi?id=73712

Patch by Yongjun Zhang  on 2011-12-15
Reviewed by Kenneth Russell.

Source/WebCore:

For a RenderBlock which has floating objects inside, we will create a PODIntervalTree and a PODArena with
at least one 16KB chunk.  A page could have a large number of such RenderBlocks and they could take huge
amount of memory.  To fix that, we can create a shared PODArena in the root RenderView.  Instead of having
their own PODArena, each RenderBlock with floating objects could share this PODArena to reduce memory consumption.

The shared PODArena could grow unboundedly if we keep removing and adding floating objects.  We can fix that
by reusing the freed memory in each chunk.  However, a PODArena could allocate objects of different sizes and
it would be complex to keep track of the size for each allocation in PODArena.  To address that, this patch
added class PODFreeListArena which only allocates objects of type T (hence the same size).  We can then use a
free list to track freed nodes inside the chunk and reuse the free nodes in future allocations.

Manually tested on nytimes.com and the heap consumption of PODIntervalTree reduced from 1.7MB to 16KB. Performance
doesn't regress on test PerformanceTests/Layout/floats.html.

* WebCore.xcodeproj/project.pbxproj: add new header file PODFreeListArena.h.
* platform/PODArena.h:
(WebCore::PODArena::~PODArena): change dtor to virtual.
(WebCore::PODArena::Chunk::~Chunk): ditto.
* platform/PODFreeListArena.h: Added.
(WebCore::PODFreeListArena::create):
(WebCore::PODFreeListArena::allocateObject): allocate an object.
(WebCore::PODFreeListArena::freeObject): free an object, find the right chunk and update its free list.
(WebCore::PODFreeListArena::allocate): allocate memory from the free list or current chunk.
(WebCore::PODFreeListArena::FreeListChunk::FreeListChunk): add m_freeList to track freed cells.
(WebCore::PODFreeListArena::FreeListChunk::allocate): reuse a free cell if there is one.
(WebCore::PODFreeListArena::FreeListChunk::free): make the memory taken by this object is free, and link it to m_freeList.
(WebCore::PODFreeListArena::FreeListChunk::contains): check if a pointer is inside this chunk.
(WebCore::PODFreeListArena::FreeListChunk::hasFreeList): check if this chunk has free cells.
* platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::PODRedBlackTree): take PODFreeListArena instead of PODArena, since nodes of a particular PODRedBlackTree
is always of the same size.
(WebCore::PODRedBlackTree::clear): mark all nodes before clearing the tree.
(WebCore::PODRedBlackTree::initIfNeeded): add initIfNeeded to take an external PODFreeListArena.
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::deleteNode): mark the node free in arena after it is removed from the tree.
(WebCore::PODRedBlackTree::markFree): mark all node free in the tree.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTree):  passing the shared PODFreeListArena to m_placedFloatsTree.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
* rendering/RenderView.cpp:
(WebCore::RenderView::intervalArena): create the shared PODFreeListArena lazily.
* rendering/RenderView.h:

Source/WebKit/chromium:

Change the test code in chromium port since PODRedBlackTree now takes PODFreeListArena
in its constructor.

* tests/PODRedBlackTreeTest.cpp:
(WebCore::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/PODArena.h
trunk/Source/WebCore/platform/PODRedBlackTree.h
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/PODRedBlackTreeTest.cpp


Added Paths

trunk/Source/WebCore/platform/PODFreeListArena.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (103029 => 103030)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 07:02:29 UTC (rev 103029)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 07:14:30 UTC (rev 103030)
@@ -1,3 +1,57 @@
+2011-12-15  Yongjun Zhang  
+
+PODIntervalTree takes 1.7MB memory on www.nytimes.com.
+https://bugs.webkit.org/show_bug.cgi?id=73712
+
+Reviewed by Kenneth Russell.
+
+For a RenderBlock which has floating objects inside, we will create a PODIntervalTree and a PODArena with
+at least one 16KB chunk.  A page could have a large number of such RenderBlocks and they could take huge
+amount of memory.  To 

[webkit-changes] [103029] trunk/LayoutTests

[dmazzoni]

Title: [103029] trunk/LayoutTests








Revision 103029
Author dmazz...@google.com
Date 2011-12-15 23:02:29 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed; rebaseline Chromium speech input image tests.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png
trunk/LayoutTests/platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png
trunk/LayoutTests/platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png
trunk/LayoutTests/platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png
trunk/LayoutTests/platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (103028 => 103029)

--- trunk/LayoutTests/ChangeLog	2011-12-16 06:46:44 UTC (rev 103028)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 07:02:29 UTC (rev 103029)
@@ -1,3 +1,34 @@
+2011-12-15  Dominic Mazzoni  
+
+Unreviewed Chromium test expectations update.
+Rebaseline all speech input image tests after new Chromium assets were checked in.
+
+* platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
+* platform/chromium-cg-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png:
+* platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
+* platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
+* platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
+* platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
+* platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
+* platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
+* platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
+* platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
+* platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
+* platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png:
+* platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
+* platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png:
+* platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
+* platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
+* platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
+* platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
+* platform/chromium-mac-snowleopard/fast/speech

[webkit-changes] [103028] trunk/Source/JavaScriptCore

[weinig]

Title: [103028] trunk/Source/_javascript_Core








Revision 103028
Author wei...@apple.com
Date 2011-12-15 22:46:44 -0800 (Thu, 15 Dec 2011)


Log Message
 _javascript_Core uses obsolete 'cpy' mnemonic in ARM assembly

Reviewed by Gavin Barraclough.

Original patch by Jim Grosbach.

* jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
Replace uses of the 'cpy' mnemonic with 'mov'.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITStubs.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (103027 => 103028)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-16 06:40:32 UTC (rev 103027)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-16 06:46:44 UTC (rev 103028)
@@ -1,3 +1,16 @@
+2011-12-15  Sam Weinig  
+
+ _javascript_Core uses obsolete 'cpy' mnemonic in ARM assembly
+
+Reviewed by Gavin Barraclough.
+
+Original patch by Jim Grosbach.
+
+* jit/JITStubs.cpp:
+(JSC::ctiTrampoline):
+(JSC::ctiVMThrowTrampoline):
+Replace uses of the 'cpy' mnemonic with 'mov'.
+
 2011-12-15  Filip Pizlo  
 
 Value profiling should distinguished between NaN and non-NaN doubles


Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (103027 => 103028)

--- trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-12-16 06:40:32 UTC (rev 103027)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-12-16 06:46:44 UTC (rev 103028)
@@ -544,7 +544,7 @@
 "str r1, [sp, #" STRINGIZE_VALUE_OF(REGISTER_FILE_OFFSET) "]" "\n"
 "str r2, [sp, #" STRINGIZE_VALUE_OF(CALLFRAME_OFFSET) "]" "\n"
 "str r3, [sp, #" STRINGIZE_VALUE_OF(EXCEPTION_OFFSET) "]" "\n"
-"cpy r5, r2" "\n"
+"mov r5, r2" "\n"
 "mov r6, #512" "\n"
 "blx r0" "\n"
 "ldr r11, [sp, #" STRINGIZE_VALUE_OF(PRESERVED_R11_OFFSET) "]" "\n"
@@ -568,7 +568,7 @@
 ".thumb" "\n"
 ".thumb_func " THUMB_FUNC_PARAM(ctiVMThrowTrampoline) "\n"
 SYMBOL_STRING(ctiVMThrowTrampoline) ":" "\n"
-"cpy r0, sp" "\n"
+"mov r0, sp" "\n"
 "bl " SYMBOL_STRING_RELOCATION(cti_vm_throw) "\n"
 "ldr r11, [sp, #" STRINGIZE_VALUE_OF(PRESERVED_R11_OFFSET) "]" "\n"
 "ldr r10, [sp, #" STRINGIZE_VALUE_OF(PRESERVED_R10_OFFSET) "]" "\n"
@@ -659,7 +659,7 @@
 str r1, [sp, # REGISTER_FILE_OFFSET ]
 str r2, [sp, # CALLFRAME_OFFSET ]
 str r3, [sp, # EXCEPTION_OFFSET ]
-cpy r5, r2
+mov r5, r2
 mov r6, #512
 blx r0
 ldr r11, [sp, # PRESERVED_R11_OFFSET ]
@@ -678,7 +678,7 @@
 __asm void ctiVMThrowTrampoline()
 {
 PRESERVE8
-cpy r0, sp
+mov r0, sp
 bl cti_vm_throw
 ldr r11, [sp, # PRESERVED_R11_OFFSET ]
 ldr r10, [sp, # PRESERVED_R10_OFFSET ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103027] trunk/Source/WebCore

[tony]

Title: [103027] trunk/Source/WebCore








Revision 103027
Author t...@chromium.org
Date 2011-12-15 22:40:32 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed, rollout r102825 because it didn't improve performance.
https://bugs.webkit.org/show_bug.cgi?id=74622


* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (103026 => 103027)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 06:02:55 UTC (rev 103026)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 06:40:32 UTC (rev 103027)
@@ -1,3 +1,12 @@
+2011-12-15  Tony Chang  
+
+Unreviewed, rollout r102825 because it didn't improve performance.
+https://bugs.webkit.org/show_bug.cgi?id=74622
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::styleForElement):
+(WebCore::CSSStyleSelector::pseudoStyleForElement):
+
 2011-12-15  Ryosuke Niwa  
 
 sizeof(RenderObject) is 32 instead of 24 on Windows


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (103026 => 103027)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-12-16 06:02:55 UTC (rev 103026)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-12-16 06:40:32 UTC (rev 103027)
@@ -1249,7 +1249,7 @@
 // If resolveForRootDefault is true, style based on user agent style sheet only. This is used in media queries, where
 // relative units are interpreted according to document root element style, styled only with UA stylesheet
 
-PassRefPtr CSSStyleSelector::styleForElement(Element* element, RenderStyle* defaultParent, bool allowSharing, bool resolveForRootDefault, RenderRegion*)
+PassRefPtr CSSStyleSelector::styleForElement(Element* element, RenderStyle* defaultParent, bool allowSharing, bool resolveForRootDefault, RenderRegion* regionForStyling)
 {
 // Once an element has a renderer, we don't try to destroy it, since otherwise the renderer
 // will vanish if a style recalc happens during loading.
@@ -1265,6 +1265,7 @@
 
 initElement(element);
 initForStyleResolve(element, defaultParent);
+initForRegionStyling(regionForStyling);
 if (allowSharing) {
 RenderStyle* sharedStyle = locateSharedStyle();
 if (sharedStyle)
@@ -1420,7 +1421,7 @@
 }
 }
 
-PassRefPtr CSSStyleSelector::pseudoStyleForElement(PseudoId pseudo, Element* e, RenderStyle* parentStyle, RenderRegion*)
+PassRefPtr CSSStyleSelector::pseudoStyleForElement(PseudoId pseudo, Element* e, RenderStyle* parentStyle, RenderRegion* regionForStyling)
 {
 if (!e)
 return 0;
@@ -1428,6 +1429,7 @@
 initElement(e);
 
 initForStyleResolve(e, parentStyle, pseudo);
+initForRegionStyling(regionForStyling);
 m_style = RenderStyle::create();
 
 if (m_parentStyle)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103026] trunk/Tools

[eric]

Title: [103026] trunk/Tools








Revision 103026
Author e...@webkit.org
Date 2011-12-15 22:02:55 -0800 (Thu, 15 Dec 2011)


Log Message
NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
https://bugs.webkit.org/show_bug.cgi?id=74650

Reviewed by Adam Barth.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._compute_bytes_from_vm_stat_output):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_child_processes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_child_processes):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (103025 => 103026)

--- trunk/Tools/ChangeLog	2011-12-16 06:00:00 UTC (rev 103025)
+++ trunk/Tools/ChangeLog	2011-12-16 06:02:55 UTC (rev 103026)
@@ -1,3 +1,17 @@
+2011-12-15  Eric Seidel  
+
+NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
+https://bugs.webkit.org/show_bug.cgi?id=74650
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/common/system/platforminfo.py:
+(PlatformInfo._compute_bytes_from_vm_stat_output):
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.default_child_processes):
+* Scripts/webkitpy/layout_tests/port/base_unittest.py:
+(PortTest.test_default_child_processes):
+
 2011-12-15  Filip Pizlo  
 
 bencher script should support remote benchmarking on platforms that don't have ruby


Modified: trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py (103025 => 103026)

--- trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py	2011-12-16 06:00:00 UTC (rev 103025)
+++ trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py	2011-12-16 06:02:55 UTC (rev 103026)
@@ -51,9 +51,9 @@
 return int(self._executive.run_command(["sysctl", "-n", "hw.memsize"]))
 return None
 
-def _compute_free_bytes_from_vm_stat_output(self, vm_stat_output):
+def _compute_bytes_from_vm_stat_output(self, label_text, vm_stat_output):
 page_size_match = re.search(r"page size of (\d+) bytes", vm_stat_output)
-free_pages_match = re.search(r"Pages free:\s+(\d+).", vm_stat_output)
+free_pages_match = re.search(r"%s:\s+(\d+)." % label_text, vm_stat_output)
 if not page_size_match or not free_pages_match:
 return None
 free_page_count = int(free_pages_match.group(1))
@@ -64,5 +64,8 @@
 system_name = platform.system()
 if system_name == "Darwin":
 vm_stat_output = self._executive.run_command(["vm_stat"])
-return self._compute_free_bytes_from_vm_stat_output(vm_stat_output)
+free_bytes = self._compute_bytes_from_vm_stat_output("Pages free", vm_stat_output)
+# Per https://bugs.webkit.org/show_bug.cgi?id=74650 include inactive memory since the OS is lazy about freeing memory.
+free_bytes += self._compute_bytes_from_vm_stat_output("Pages inactive", vm_stat_output)
+return free_bytes
 return None


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (103025 => 103026)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2011-12-16 06:00:00 UTC (rev 103025)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2011-12-16 06:02:55 UTC (rev 103026)
@@ -169,7 +169,7 @@
 free_memory = self.host.platform.free_bytes_memory()
 if free_memory:
 bytes_per_drt = 200 * 1024 * 1024  # Assume each DRT needs 200MB to run.
-supportable_instances = free_memory / bytes_per_drt
+supportable_instances = max(free_memory / bytes_per_drt, 1)  # Always use one process, even if we don't have space for it.
 if supportable_instances < cpu_count:
 # FIXME: The Printer isn't initialized when this is called, so using _log would just show an unitialized logger error.
 print "This machine could support %s child processes, but only has enough memory for %s." % (cpu_count, supportable_instances)


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py (103025 => 103026)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py	2011-12-16 06:00:00 UTC (rev 103025)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py	2011-12-16 06:02:55 UTC (rev 103026)
@@ -65,10 +65,11 @@
 child_processes = OutputCapture().assert_outputs(self, port.default_child_processes, (), expected_stdout=expected_stdout)
 self.assertEqual(child_processes, 1)
 
+# Make sure that we always use one process, even if we don't have the memory for it.
 port.host.platform.free_bytes_memory = lambda: bytes_for_drt - 1
-expected_stdout = "This mach

[webkit-changes] [103025] trunk/Source/WebKit/chromium

[commit-queue]

Title: [103025] trunk/Source/WebKit/chromium








Revision 103025
Author commit-qu...@webkit.org
Date 2011-12-15 22:00:00 -0800 (Thu, 15 Dec 2011)


Log Message
IndexedDB: Clean up WebIDBObjectStore createIndex temp code
https://bugs.webkit.org/show_bug.cgi?id=74205

Patch by Joshua Bell  on 2011-12-15
Reviewed by Darin Fisher.

Remove a method and an implementation that only needed for
older Chromium revisions.

* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::createIndex):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (103024 => 103025)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-16 05:56:23 UTC (rev 103024)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-16 06:00:00 UTC (rev 103025)
@@ -1,3 +1,16 @@
+2011-12-15  Joshua Bell  
+
+IndexedDB: Clean up WebIDBObjectStore createIndex temp code
+https://bugs.webkit.org/show_bug.cgi?id=74205
+
+Reviewed by Darin Fisher.
+
+Remove a method and an implementation that only needed for
+older Chromium revisions.
+
+* public/WebIDBObjectStore.h:
+(WebKit::WebIDBObjectStore::createIndex):
+
 2011-12-15  Tony Chang  
 
 Chromium Windows (Tests) is failing to build


Modified: trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h (103024 => 103025)

--- trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h	2011-12-16 05:56:23 UTC (rev 103024)
+++ trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h	2011-12-16 06:00:00 UTC (rev 103025)
@@ -70,15 +70,10 @@
 virtual void put(const WebSerializedScriptValue&, const WebIDBKey&, PutMode, WebIDBCallbacks*, const WebIDBTransaction&, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void deleteFunction(const WebIDBKey&, WebIDBCallbacks*, const WebIDBTransaction&, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void clear(WebIDBCallbacks*, const WebIDBTransaction&, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
-// FIXME: Remove once callers are updated.
-virtual WebIDBIndex* createIndex(const WebString& name, const WebString& keyPath, bool unique, const WebIDBTransaction& transaction, WebExceptionCode& ec)
-{
-return createIndex(name, keyPath, unique, false, transaction, ec);
-}
 virtual WebIDBIndex* createIndex(const WebString& name, const WebString& keyPath, bool unique, bool multiEntry, const WebIDBTransaction& transaction, WebExceptionCode& ec)
 {
-// FIXME: Assert not reached once implementing classes are updated.
-return createIndex(name, keyPath, unique, transaction, ec);
+WEBKIT_ASSERT_NOT_REACHED();
+return 0;
 }
 // Transfers ownership of the WebIDBIndex to the caller.
 virtual WebIDBIndex* index(const WebString& name, WebExceptionCode&)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103023] trunk/Source/JavaScriptCore

[fpizlo]

Title: [103023] trunk/Source/_javascript_Core








Revision 103023
Author fpi...@apple.com
Date 2011-12-15 21:32:58 -0800 (Thu, 15 Dec 2011)


Log Message
Value profiling should distinguished between NaN and non-NaN doubles
https://bugs.webkit.org/show_bug.cgi?id=74682

Reviewed by Gavin Barraclough.

Added PredictDoubleReal and PredictDoubleNaN. PredictDouble is now the union
of the two.

* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromValue):
* bytecode/PredictedType.h:
(JSC::isDoubleRealPrediction):
(JSC::isDoublePrediction):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/PredictedType.cpp
trunk/Source/_javascript_Core/bytecode/PredictedType.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (103022 => 103023)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-16 05:22:48 UTC (rev 103022)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-16 05:32:58 UTC (rev 103023)
@@ -1,3 +1,20 @@
+2011-12-15  Filip Pizlo  
+
+Value profiling should distinguished between NaN and non-NaN doubles
+https://bugs.webkit.org/show_bug.cgi?id=74682
+
+Reviewed by Gavin Barraclough.
+
+Added PredictDoubleReal and PredictDoubleNaN. PredictDouble is now the union
+of the two.
+
+* bytecode/PredictedType.cpp:
+(JSC::predictionToString):
+(JSC::predictionFromValue):
+* bytecode/PredictedType.h:
+(JSC::isDoubleRealPrediction):
+(JSC::isDoublePrediction):
+
 2011-12-15  Anders Carlsson  
 
 Regression (r102866): Navigating away from or closing a page with a plugin crashes


Modified: trunk/Source/_javascript_Core/bytecode/PredictedType.cpp (103022 => 103023)

--- trunk/Source/_javascript_Core/bytecode/PredictedType.cpp	2011-12-16 05:22:48 UTC (rev 103022)
+++ trunk/Source/_javascript_Core/bytecode/PredictedType.cpp	2011-12-16 05:32:58 UTC (rev 103023)
@@ -128,11 +128,16 @@
 else
 isTop = false;
 
-if (value & PredictDouble)
-ptr.strcat("Double");
+if (value & PredictDoubleReal)
+ptr.strcat("Doublereal");
 else
 isTop = false;
 
+if (value & PredictDoubleNaN)
+ptr.strcat("Doublenan");
+else
+isTop = false;
+
 if (value & PredictBoolean)
 ptr.strcat("Bool");
 else
@@ -212,8 +217,12 @@
 {
 if (value.isInt32())
 return PredictInt32;
-if (value.isDouble())
-return PredictDouble;
+if (value.isDouble()) {
+double number = value.asNumber();
+if (number == number)
+return PredictDoubleReal;
+return PredictDoubleNaN;
+}
 if (value.isCell())
 return predictionFromCell(value.asCell());
 if (value.isBoolean())


Modified: trunk/Source/_javascript_Core/bytecode/PredictedType.h (103022 => 103023)

--- trunk/Source/_javascript_Core/bytecode/PredictedType.h	2011-12-16 05:22:48 UTC (rev 103022)
+++ trunk/Source/_javascript_Core/bytecode/PredictedType.h	2011-12-16 05:32:58 UTC (rev 103023)
@@ -55,9 +55,11 @@
 static const PredictedType PredictCellOther = 0x4000; // It's definitely a JSCell but not a subclass of JSObject and definitely not a JSString.
 static const PredictedType PredictCell  = 0x7fff; // It's definitely a JSCell.
 static const PredictedType PredictInt32 = 0x8000; // It's definitely an Int32.
-static const PredictedType PredictDouble= 0x0001; // It's definitely a Double.
-static const PredictedType PredictNumber= 0x00018000; // It's either an Int32 or a Double.
-static const PredictedType PredictBoolean   = 0x0002; // It's definitely a Boolean.
+static const PredictedType PredictDoubleReal= 0x0001; // It's definitely a non-NaN double.
+static const PredictedType PredictDoubleNaN = 0x0002; // It's definitely a NaN.
+static const PredictedType PredictDouble= 0x0003; // It's either a non-NaN or a NaN double.
+static const PredictedType PredictNumber= 0x00038000; // It's either an Int32 or a Double.
+static const PredictedType PredictBoolean   = 0x0004; // It's definitely a Boolean.
 static const PredictedType PredictOther = 0x4000; // It's definitely none of the above.
 static const PredictedType PredictTop   = 0x7fff; // It can be any of the above.
 static const PredictedType FixedIndexedStorageMask = PredictByteArray | PredictInt8Array | PredictInt16Array | PredictInt32Array | PredictUint8Array | PredictUint16Array | PredictUint32Array | PredictFloat32Array | PredictFloat64Array;
@@ -159,9 +161,14 @@
 return value == PredictInt32;
 }
 
+inline bool isDoubleRealPrediction(PredictedType value)
+{
+return value == PredictDoubleReal;
+}
+
 inline bool isDoublePrediction(PredictedType value)
 {
-return value == PredictDouble;
+return (value & PredictDouble) == value;
 }
 
 inline bool isNumberPrediction(PredictedType

[webkit-changes] [103022] trunk/Source/WebKit

[commit-queue]

Title: [103022] trunk/Source/WebKit








Revision 103022
Author commit-qu...@webkit.org
Date 2011-12-15 21:22:48 -0800 (Thu, 15 Dec 2011)


Log Message
[BlackBerry] Upstream BlackBerry WebCoreSupport drag client and context menu client
https://bugs.webkit.org/show_bug.cgi?id=74643

Patch by Jacky Jiang  on 2011-12-15
Reviewed by Rob Buis.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/ContextMenuClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/ContextMenuClientBlackBerry.h: Added.
* blackberry/WebCoreSupport/DragClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/DragClientBlackBerry.h: Added.

Modified Paths

trunk/Source/WebKit/ChangeLog


Added Paths

trunk/Source/WebKit/blackberry/WebCoreSupport/ContextMenuClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/ContextMenuClientBlackBerry.h
trunk/Source/WebKit/blackberry/WebCoreSupport/DragClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/DragClientBlackBerry.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (103021 => 103022)

--- trunk/Source/WebKit/ChangeLog	2011-12-16 05:21:00 UTC (rev 103021)
+++ trunk/Source/WebKit/ChangeLog	2011-12-16 05:22:48 UTC (rev 103022)
@@ -1,5 +1,19 @@
 2011-12-15  Jacky Jiang  
 
+[BlackBerry] Upstream BlackBerry WebCoreSupport drag client and context menu client
+https://bugs.webkit.org/show_bug.cgi?id=74643
+
+Reviewed by Rob Buis.
+
+Initial upstream, no new tests.
+
+* blackberry/WebCoreSupport/ContextMenuClientBlackBerry.cpp: Added.
+* blackberry/WebCoreSupport/ContextMenuClientBlackBerry.h: Added.
+* blackberry/WebCoreSupport/DragClientBlackBerry.cpp: Added.
+* blackberry/WebCoreSupport/DragClientBlackBerry.h: Added.
+
+2011-12-15  Jacky Jiang  
+
 [BlackBerry] Regression: lots of checkerboarding
 https://bugs.webkit.org/show_bug.cgi?id=74611
 


Added: trunk/Source/WebKit/blackberry/WebCoreSupport/ContextMenuClientBlackBerry.cpp (0 => 103022)

--- trunk/Source/WebKit/blackberry/WebCoreSupport/ContextMenuClientBlackBerry.cpp	(rev 0)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ContextMenuClientBlackBerry.cpp	2011-12-16 05:22:48 UTC (rev 103022)
@@ -0,0 +1,74 @@
+/*
+ * Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
+ * Copyright (C) 2011 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include "config.h"
+#include "ContextMenuClientBlackBerry.h"
+
+#include "NotImplemented.h"
+
+namespace WebCore {
+
+void ContextMenuClientBlackBerry::contextMenuDestroyed()
+{
+delete this;
+}
+
+void* ContextMenuClientBlackBerry::getCustomMenuFromDefaultItems(ContextMenu*)
+{
+notImplemented();
+return 0;
+}
+
+void ContextMenuClientBlackBerry::contextMenuItemSelected(ContextMenuItem*, const ContextMenu*)
+{
+notImplemented();
+}
+
+void ContextMenuClientBlackBerry::downloadURL(const KURL&)
+{
+notImplemented();
+}
+
+void ContextMenuClientBlackBerry::searchWithGoogle(const Frame*)
+{
+notImplemented();
+}
+
+void ContextMenuClientBlackBerry::lookUpInDictionary(Frame*)
+{
+notImplemented();
+}
+
+bool ContextMenuClientBlackBerry::isSpeaking()
+{
+notImplemented();
+return false;
+}
+
+void ContextMenuClientBlackBerry::speak(const String&)
+{
+notImplemented();
+}
+
+void ContextMenuClientBlackBerry::stopSpeaking()
+{
+notImplemented();
+}
+
+} // namespace WebCore


Added: trunk/Source/WebKit/blackberry/WebCoreSupport/ContextMenuClientBlackBerry.h (0 => 103022)

--- trunk/Source/WebKit/blackberry/WebCoreSupport/ContextMenuClientBlackBerry.h	(rev 0)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ContextMenuClientBlackBerry.h	2011-12-16 05:22:48 UTC (rev 103022)
@@ -0,0 +1,42 @@
+/*
+ * Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
+ * Copyright (C) 2011 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the ho

[webkit-changes] [103021] trunk/Source/WebKit/chromium

[tony]

Title: [103021] trunk/Source/WebKit/chromium








Revision 103021
Author t...@chromium.org
Date 2011-12-15 21:21:00 -0800 (Thu, 15 Dec 2011)


Log Message
Chromium Windows (Tests) is failing to build
https://bugs.webkit.org/show_bug.cgi?id=74320

Reviewed by Kenneth Russell.

Roll chromium deps to r114686 to pull in a change to how generated
headers include files from third_party/WebKit.  This should make the
file path shorter, reducing the chance of hitting the 260 char path
limit on Windows.

* DEPS: roll to r114686

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (103020 => 103021)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-16 05:09:51 UTC (rev 103020)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-16 05:21:00 UTC (rev 103021)
@@ -1,3 +1,17 @@
+2011-12-15  Tony Chang  
+
+Chromium Windows (Tests) is failing to build
+https://bugs.webkit.org/show_bug.cgi?id=74320
+
+Reviewed by Kenneth Russell.
+
+Roll chromium deps to r114686 to pull in a change to how generated
+headers include files from third_party/WebKit.  This should make the
+file path shorter, reducing the chance of hitting the 260 char path
+limit on Windows.
+
+* DEPS: roll to r114686
+
 2011-12-15  James Robinson  
 
 [chromium] Set the CCLayerTreeHost pointer on LayerChromium instances eagerly


Modified: trunk/Source/WebKit/chromium/DEPS (103020 => 103021)

--- trunk/Source/WebKit/chromium/DEPS	2011-12-16 05:09:51 UTC (rev 103020)
+++ trunk/Source/WebKit/chromium/DEPS	2011-12-16 05:21:00 UTC (rev 103021)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '114356',
+  'chromium_rev': '114686',
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103019] trunk/Source/WebCore

[leo . yang]

Title: [103019] trunk/Source/WebCore








Revision 103019
Author leo.y...@torchmobile.com.cn
Date 2011-12-15 20:41:14 -0800 (Thu, 15 Dec 2011)


Log Message
[BlackBerry] Upstream BlackBerry porting of pluginView
https://bugs.webkit.org/show_bug.cgi?id=73397

Patch by Wei Charles  on 2011-12-15
Reviewed by Daniel Bates.

No new tests for now.

* plugins/blackberry/PluginViewBlackBerry.cpp: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog


Added Paths

trunk/Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (103018 => 103019)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 04:23:15 UTC (rev 103018)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 04:41:14 UTC (rev 103019)
@@ -1,3 +1,14 @@
+2011-12-15  Wei Charles  
+
+[BlackBerry] Upstream BlackBerry porting of pluginView
+https://bugs.webkit.org/show_bug.cgi?id=73397
+
+Reviewed by Daniel Bates.
+
+No new tests for now.
+
+* plugins/blackberry/PluginViewBlackBerry.cpp: Added.
+
 2011-12-15  Joshua Bell  
 
 IndexedDB: Can't pass DOMStringList to IDBDatabase.transaction()


Added: trunk/Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp (0 => 103019)

--- trunk/Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp	(rev 0)
+++ trunk/Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp	2011-12-16 04:41:14 UTC (rev 103019)
@@ -0,0 +1,1393 @@
+/*
+ * Copyright (C) 2006, 2007 Apple Inc.  All rights reserved.
+ * Copyright (C) 2008 Collabora Ltd. All rights reserved.
+ * Copyright (C) 2009 Girish Ramakrishnan 
+ * Copyright (C) 2011 Research In Motion Limited. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
+ */
+
+#include "config.h"
+#include "PluginView.h"
+
+#include "DocumentLoader.h"
+#include "Event.h"
+#include "EventNames.h"
+#include "Frame.h"
+#include "FrameView.h"
+#include "HTMLNames.h"
+#include "HTMLPlugInElement.h"
+#include "HostWindow.h"
+#include "JSDOMBinding.h"
+#include "KeyboardEvent.h"
+#include "MouseEvent.h"
+#include "NPCallbacksBlackBerry.h"
+#include "NotImplemented.h"
+#include "Page.h"
+#include "PlatformContextSkia.h"
+#include "PlatformKeyboardEvent.h"
+#include "PluginDebug.h"
+#include "PluginMainThreadScheduler.h"
+#include "PluginPackage.h"
+#include "PluginViewPrivateBlackBerry.h"
+#include "RenderLayer.h"
+#include "Settings.h"
+#include "TouchEvent.h"
+#include "TouchList.h"
+#include "WheelEvent.h"
+#include "npruntime_impl.h"
+#include "runtime_root.h"
+
+#if USE(ACCELERATED_COMPOSITING)
+#include "Chrome.h"
+#include "ChromeClient.h"
+#include "PluginLayerWebKitThread.h"
+#endif
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+const unsigned UninitializedCoordinate = 0x;
+
+namespace WebCore {
+
+template static NPRect toNPRect(const T& rect)
+{
+NPRect npRect;
+npRect.top = rect.y();
+npRect.left = rect.x();
+npRect.bottom = rect.y() + rect.height();
+npRect.right = rect.x() + rect.width();
+return npRect;
+}
+
+using JSC::ExecState;
+using JSC::Interpreter;
+using JSC::JSLock;
+using JSC::JSObject;
+using JSC::UString;
+
+using namespace std;
+using namespace WTF;
+using namespace HTMLNames;
+
+void PluginView::updatePluginWidget()
+{
+if (!parent() || !m_private)
+return;
+
+ASSERT(parent()->isFrameView());
+FrameView* frameView = static_cast(parent());
+
+IntRect oldWindowRect = m_windowRect;
+IntRect oldClipRect = m_clipRect;
+
+m_windowRect = IntRect(frameView->contentsToWindow(frameRect().location()), frameRect().size());
+
+// Map rect to content coordinate space of main frame.
+m_windowRect.mo

[webkit-changes] [103018] trunk

[commit-queue]

Title: [103018] trunk








Revision 103018
Author commit-qu...@webkit.org
Date 2011-12-15 20:23:15 -0800 (Thu, 15 Dec 2011)


Log Message
IndexedDB: Can't pass DOMStringList to IDBDatabase.transaction()
https://bugs.webkit.org/show_bug.cgi?id=74452

Patch by Joshua Bell  on 2011-12-15
Reviewed by Adam Barth.

Source/WebCore:

V8 code generator generated checks for DOMStringList arguments, then
deferred to a function that only handled array inputs. This previously
worked for IndexedDB because it would fall into a now-removed default
handler.

Modified storage/indexeddb/transaction-basics.html to test this.

* bindings/v8/V8Binding.cpp:
(WebCore::v8ValueToWebCoreDOMStringList):

LayoutTests:

* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-basics.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/transaction-basics-expected.txt
trunk/LayoutTests/storage/indexeddb/transaction-basics.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Binding.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (103017 => 103018)

--- trunk/LayoutTests/ChangeLog	2011-12-16 04:19:33 UTC (rev 103017)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 04:23:15 UTC (rev 103018)
@@ -1,3 +1,13 @@
+2011-12-15  Joshua Bell  
+
+IndexedDB: Can't pass DOMStringList to IDBDatabase.transaction()
+https://bugs.webkit.org/show_bug.cgi?id=74452
+
+Reviewed by Adam Barth.
+
+* storage/indexeddb/transaction-basics-expected.txt:
+* storage/indexeddb/transaction-basics.html:
+
 2011-12-15  Kenneth Russell  
 
 Unreviewed, rolling out r103000.


Modified: trunk/LayoutTests/storage/indexeddb/transaction-basics-expected.txt (103017 => 103018)

--- trunk/LayoutTests/storage/indexeddb/transaction-basics-expected.txt	2011-12-16 04:19:33 UTC (rev 103017)
+++ trunk/LayoutTests/storage/indexeddb/transaction-basics-expected.txt	2011-12-16 04:23:15 UTC (rev 103018)
@@ -90,6 +90,14 @@
 store = transaction.objectStore('storeName')
 PASS store.name is "storeName"
 PASS abort event fired
+
+Verifying DOMStringList works as argument for IDBDatabase.transaction()
+db.objectStoreNames is [object DOMStringList]
+... which contains: ["storeName"]
+transaction = db.transaction(db.objectStoreNames)
+PASS no exception thrown
+PASS transaction.objectStore("storeName") != null is true
+PASS all stores present in transaction
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/storage/indexeddb/transaction-basics.html (103017 => 103018)

--- trunk/LayoutTests/storage/indexeddb/transaction-basics.html	2011-12-16 04:19:33 UTC (rev 103017)
+++ trunk/LayoutTests/storage/indexeddb/transaction-basics.html	2011-12-16 04:23:15 UTC (rev 103018)
@@ -223,6 +223,21 @@
 function abortCallback()
 {
 testPassed("abort event fired");
+testDOMStringList();
+}
+
+function testDOMStringList()
+{
+debug("");
+debug("Verifying DOMStringList works as argument for IDBDatabase.transaction()");
+debug("db.objectStoreNames is " + db.objectStoreNames);
+debug("... which contains: " + JSON.stringify(Array.prototype.slice.call(db.objectStoreNames)));
+evalAndLog("transaction = db.transaction(db.objectStoreNames)");
+testPassed("no exception thrown");
+for (var i = 0; i < db.objectStoreNames.length; ++i) {
+  shouldBeTrue("transaction.objectStore(" + JSON.stringify(db.objectStoreNames[i]) + ") != null");
+}
+testPassed("all stores present in transaction");
 finishJSTest();
 }
 


Modified: trunk/Source/WebCore/ChangeLog (103017 => 103018)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 04:19:33 UTC (rev 103017)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 04:23:15 UTC (rev 103018)
@@ -1,3 +1,20 @@
+2011-12-15  Joshua Bell  
+
+IndexedDB: Can't pass DOMStringList to IDBDatabase.transaction()
+https://bugs.webkit.org/show_bug.cgi?id=74452
+
+Reviewed by Adam Barth.
+
+V8 code generator generated checks for DOMStringList arguments, then
+deferred to a function that only handled array inputs. This previously
+worked for IndexedDB because it would fall into a now-removed default
+handler.
+
+Modified storage/indexeddb/transaction-basics.html to test this.
+
+* bindings/v8/V8Binding.cpp:
+(WebCore::v8ValueToWebCoreDOMStringList):
+
 2011-12-15  Adam Klein  
 
 Make Element::setAttributeInternal inline in an attempt to avoid function call overhead


Modified: trunk/Source/WebCore/bindings/v8/V8Binding.cpp (103017 => 103018)

--- trunk/Source/WebCore/bindings/v8/V8Binding.cpp	2011-12-16 04:19:33 UTC (rev 103017)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.cpp	2011-12-16 04:23:15 UTC (rev 103018)
@@ -38,6 +38,7 @@
 #include "QualifiedName.h"
 #include "StdLibExtras.h"
 #include "Threading.h"
+#include "V8DOMStringList.h"
 #include "V8Element.h"
 #include "V8Proxy.h"
 #include 
@@ -620,6 +621,12 @@
 PassRefPtr v

[webkit-changes] [103017] trunk/Source/WebCore

[adamk]

Title: [103017] trunk/Source/WebCore








Revision 103017
Author ad...@chromium.org
Date 2011-12-15 20:19:33 -0800 (Thu, 15 Dec 2011)


Log Message
Make Element::setAttributeInternal inline in an attempt to avoid function call overhead
https://bugs.webkit.org/show_bug.cgi?id=74638

Reviewed by Andreas Kling.

In r102695, I factored common code in setAttribute into
Element::setAttributeInternal. This may have caused a perf regression
due to the extra function call, which inlining should eliminate.

Running Dromaeo locally suggests that this will improve performance
by ~9% on the "dom-attr element.property = value" test (which assigns
a value to an element's id).

* dom/Element.cpp:
(WebCore::Element::setAttributeInternal):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (103016 => 103017)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 04:03:47 UTC (rev 103016)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 04:19:33 UTC (rev 103017)
@@ -1,3 +1,21 @@
+2011-12-15  Adam Klein  
+
+Make Element::setAttributeInternal inline in an attempt to avoid function call overhead
+https://bugs.webkit.org/show_bug.cgi?id=74638
+
+Reviewed by Andreas Kling.
+
+In r102695, I factored common code in setAttribute into
+Element::setAttributeInternal. This may have caused a perf regression
+due to the extra function call, which inlining should eliminate.
+
+Running Dromaeo locally suggests that this will improve performance
+by ~9% on the "dom-attr element.property = value" test (which assigns
+a value to an element's id).
+
+* dom/Element.cpp:
+(WebCore::Element::setAttributeInternal):
+
 2011-12-15  Mary Wu  
 
 Upstream FileSystemBlackBerry.cpp into WebCore/platform/blackberry


Modified: trunk/Source/WebCore/dom/Element.cpp (103016 => 103017)

--- trunk/Source/WebCore/dom/Element.cpp	2011-12-16 04:03:47 UTC (rev 103016)
+++ trunk/Source/WebCore/dom/Element.cpp	2011-12-16 04:19:33 UTC (rev 103017)
@@ -648,7 +648,7 @@
 setAttributeInternal(old, name, value);
 }
 
-void Element::setAttributeInternal(Attribute* old, const QualifiedName& name, const AtomicString& value)
+inline void Element::setAttributeInternal(Attribute* old, const QualifiedName& name, const AtomicString& value)
 {
 #if ENABLE(INSPECTOR)
 if (!isSynchronizingStyleAttribute())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103016] trunk/Source/WebCore

[commit-queue]

Title: [103016] trunk/Source/WebCore








Revision 103016
Author commit-qu...@webkit.org
Date 2011-12-15 20:03:47 -0800 (Thu, 15 Dec 2011)


Log Message
Upstream FileSystemBlackBerry.cpp into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74491

Patch by Mary Wu  on 2011-12-15
Reviewed by Rob Buis.

We are using POSIX porting of FileSystem, so here only implement other
necessary functions.

Initial upstream, no new tests.

* platform/blackberry/FileSystemBlackBerry.cpp: Added.
(WebCore::homeDirectoryPath):
(WebCore::fileSystemRepresentation):
(WebCore::unloadModule):
(WebCore::openTemporaryFile):

Modified Paths

trunk/Source/WebCore/ChangeLog


Added Paths

trunk/Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (103015 => 103016)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 03:43:40 UTC (rev 103015)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 04:03:47 UTC (rev 103016)
@@ -1,3 +1,21 @@
+2011-12-15  Mary Wu  
+
+Upstream FileSystemBlackBerry.cpp into WebCore/platform/blackberry
+https://bugs.webkit.org/show_bug.cgi?id=74491
+
+Reviewed by Rob Buis.
+
+We are using POSIX porting of FileSystem, so here only implement other 
+necessary functions.
+
+Initial upstream, no new tests.
+
+* platform/blackberry/FileSystemBlackBerry.cpp: Added.
+(WebCore::homeDirectoryPath):
+(WebCore::fileSystemRepresentation):
+(WebCore::unloadModule):
+(WebCore::openTemporaryFile):
+
 2011-12-15  Adrienne Walker  
 
 [chromium] Clean up unnecessary leaf functions in GraphicsLayerChromium


Added: trunk/Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp (0 => 103016)

--- trunk/Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp	2011-12-16 04:03:47 UTC (rev 103016)
@@ -0,0 +1,47 @@
+/*
+ * Copyright (C) 2009, 2010, 2011 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include "config.h"
+#include "FileSystem.h"
+
+#include 
+#include 
+
+namespace WebCore {
+
+String homeDirectoryPath()
+{
+return BlackBerry::Platform::Client::get()->getApplicationDataDirectory().c_str();
+}
+
+CString fileSystemRepresentation(const String& path)
+{
+return path.utf8();
+}
+
+bool unloadModule(PlatformModule)
+{
+return false;
+}
+
+String openTemporaryFile(const String&, PlatformFileHandle&)
+{
+return "";
+}
+
+} // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103015] trunk/Source/WebCore

[enne]

Title: [103015] trunk/Source/WebCore








Revision 103015
Author e...@google.com
Date 2011-12-15 19:43:40 -0800 (Thu, 15 Dec 2011)


Log Message
[chromium] Clean up unnecessary leaf functions in GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=74140

Reviewed by James Robinson.

Tested by existing compositor layout tests.

This is a follow-on cleanup to r102196, which made some of these
functions less useful than they had been in the past.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
* platform/graphics/chromium/GraphicsLayerChromium.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (103014 => 103015)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 03:41:12 UTC (rev 103014)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 03:43:40 UTC (rev 103015)
@@ -1,3 +1,21 @@
+2011-12-15  Adrienne Walker  
+
+[chromium] Clean up unnecessary leaf functions in GraphicsLayerChromium
+https://bugs.webkit.org/show_bug.cgi?id=74140
+
+Reviewed by James Robinson.
+
+Tested by existing compositor layout tests.
+
+This is a follow-on cleanup to r102196, which made some of these
+functions less useful than they had been in the past.
+
+* platform/graphics/chromium/GraphicsLayerChromium.cpp:
+(WebCore::GraphicsLayerChromium::setContentsOpaque):
+(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
+(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
+* platform/graphics/chromium/GraphicsLayerChromium.h:
+
 2011-12-15  Kenneth Russell  
 
 Unreviewed, rolling out r103000.


Modified: trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp (103014 => 103015)

--- trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2011-12-16 03:41:12 UTC (rev 103014)
+++ trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2011-12-16 03:43:40 UTC (rev 103015)
@@ -242,7 +242,7 @@
 void GraphicsLayerChromium::setContentsOpaque(bool opaque)
 {
 GraphicsLayer::setContentsOpaque(opaque);
-updateContentsOpaque();
+m_layer->setOpaque(m_contentsOpaque);
 }
 
 void GraphicsLayerChromium::setMaskLayer(GraphicsLayer* maskLayer)
@@ -261,7 +261,7 @@
 void GraphicsLayerChromium::setBackfaceVisibility(bool visible)
 {
 GraphicsLayer::setBackfaceVisibility(visible);
-updateBackfaceVisibility();
+m_layer->setDoubleSided(m_backfaceVisibility);
 }
 
 void GraphicsLayerChromium::setOpacity(float opacity)
@@ -514,16 +514,6 @@
 updateDebugIndicators();
 }
 
-void GraphicsLayerChromium::updateContentsOpaque()
-{
-m_layer->setOpaque(m_contentsOpaque);
-}
-
-void GraphicsLayerChromium::updateBackfaceVisibility()
-{
-m_layer->setDoubleSided(m_backfaceVisibility);
-}
-
 void GraphicsLayerChromium::updateLayerPreserves3D()
 {
 if (m_preserves3D && !m_transformLayer) {
@@ -574,7 +564,7 @@
 }
 
 m_layer->setPreserves3D(m_preserves3D);
-updateOpacityOnLayer();
+primaryLayer()->setOpacity(m_opacity);
 updateNames();
 }
 
@@ -658,12 +648,6 @@
 return 1;
 }
 
-// This function simply mimics the operation of GraphicsLayerCA
-void GraphicsLayerChromium::updateOpacityOnLayer()
-{
-primaryLayer()->setOpacity(m_opacity);
-}
-
 void GraphicsLayerChromium::deviceOrPageScaleFactorChanged()
 {
 updateContentsScale();


Modified: trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h (103014 => 103015)

--- trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h	2011-12-16 03:41:12 UTC (rev 103014)
+++ trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h	2011-12-16 03:43:40 UTC (rev 103015)
@@ -105,8 +105,6 @@
 LayerChromium* contentsLayer() const { return m_contentsLayer.get(); }
 
 private:
-void updateOpacityOnLayer();
-
 LayerChromium* primaryLayer() const  { return m_transformLayer.get() ? m_transformLayer.get() : m_layer.get(); }
 LayerChromium* hostLayerForChildren() const;
 LayerChromium* layerForParent() const;
@@ -119,8 +117,6 @@
 void updateTransform();
 void updateChildrenTransform();
 void updateMasksToBounds();
-void updateContentsOpaque();
-void updateBackfaceVisibility();
 void updateLayerPreserves3D();
 void updateLayerDrawsContent();
 void updateLayerBackgroundColor();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103014] trunk/Tools

[dpranke]

Title: [103014] trunk/Tools








Revision 103014
Author dpra...@chromium.org
Date 2011-12-15 19:41:12 -0800 (Thu, 15 Dec 2011)


Log Message
webkitpy: clean up TestPort to (mostly) not create a new filesystem
https://bugs.webkit.org/show_bug.cgi?id=74556

This change modifies the TestPort to be ready to add tests to an
existing filesystem instead of creating a new filesystem; we
leave unit_test_filesystem() in for now for compatibility.

* Scripts/webkitpy/common/host_mock.py:
(MockHost.__init__):
  - call add_unit_tests_to_mock_filesystem by default to make
the MockHost more generally useful for layout_test unit tests.
* Scripts/webkitpy/layout_tests/port/test.py:
(TestInstance.__init__):
(add_unit_tests_to_mock_filesystem):
(add_file):
(unit_test_filesystem):
(TestPort.__init__):
(TestPort._set_default_overriding_none):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/host_mock.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py




Diff

Modified: trunk/Tools/ChangeLog (103013 => 103014)

--- trunk/Tools/ChangeLog	2011-12-16 03:05:08 UTC (rev 103013)
+++ trunk/Tools/ChangeLog	2011-12-16 03:41:12 UTC (rev 103014)
@@ -1,5 +1,26 @@
 2011-12-15  Dirk Pranke  
 
+webkitpy: clean up TestPort to (mostly) not create a new filesystem
+https://bugs.webkit.org/show_bug.cgi?id=74556
+
+This change modifies the TestPort to be ready to add tests to an
+existing filesystem instead of creating a new filesystem; we
+leave unit_test_filesystem() in for now for compatibility.
+
+* Scripts/webkitpy/common/host_mock.py:
+(MockHost.__init__):
+  - call add_unit_tests_to_mock_filesystem by default to make
+the MockHost more generally useful for layout_test unit tests.
+* Scripts/webkitpy/layout_tests/port/test.py:
+(TestInstance.__init__):
+(add_unit_tests_to_mock_filesystem):
+(add_file):
+(unit_test_filesystem):
+(TestPort.__init__):
+(TestPort._set_default_overriding_none):
+
+2011-12-15  Dirk Pranke  
+
 webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
 https://bugs.webkit.org/show_bug.cgi?id=74551
 


Modified: trunk/Tools/Scripts/webkitpy/common/host_mock.py (103013 => 103014)

--- trunk/Tools/Scripts/webkitpy/common/host_mock.py	2011-12-16 03:05:08 UTC (rev 103013)
+++ trunk/Tools/Scripts/webkitpy/common/host_mock.py	2011-12-16 03:41:12 UTC (rev 103014)
@@ -36,11 +36,13 @@
 
 # New-style ports need to move down into webkitpy.common.
 from webkitpy.layout_tests.port.factory import PortFactory
+from webkitpy.layout_tests.port.test import add_unit_tests_to_mock_filesystem
 
 
 class MockHost(MockSystemHost):
 def __init__(self, log_executive=False, executive_throws_when_run=None):
 MockSystemHost.__init__(self, log_executive, executive_throws_when_run)
+add_unit_tests_to_mock_filesystem(self.filesystem)
 self.web = MockWeb()
 
 self._checkout = MockCheckout()


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py (103013 => 103014)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py	2011-12-16 03:05:08 UTC (rev 103013)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py	2011-12-16 03:41:12 UTC (rev 103014)
@@ -35,7 +35,6 @@
 
 from webkitpy.layout_tests.port import Port, Driver, DriverOutput
 from webkitpy.layout_tests.models.test_configuration import TestConfiguration
-from webkitpy.common.host_mock import MockHost
 from webkitpy.common.system.filesystem_mock import MockFileSystem
 
 
@@ -227,35 +226,11 @@
 # Here we synthesize an in-memory filesystem from the test list
 # in order to fully control the test output and to demonstrate that
 # we don't need a real filesystem to run the tests.
-
-def unit_test_filesystem(files=None):
-"""Return the FileSystem object used by the unit tests."""
-test_list = unit_test_list()
-files = files or {}
-
-def add_test_file(files, test, suffix, contents):
-dirname = test.name[0:test.name.rfind('/')]
-base = test.base
-add_file(files, dirname + '/' + base + suffix, contents)
-
-def add_file(files, file_name, contents):
-files[LAYOUT_TEST_DIR + '/' + file_name] = contents
-
-# Add each test and the expected output, if any.
-for test in test_list.tests.values():
-add_test_file(files, test, '.html', '')
-if test.is_reftest:
-continue
-if test.actual_audio:
-add_test_file(files, test, '-expected.wav', test.expected_audio)
-continue
-
-add_test_file(files, test, '-expected.txt', test.expected_text)
-add_test_file(files, test, '-expected.png', test.expected_image)
-
-
+def add_unit_tests_to_mock_filesystem(filesystem):
 # Add the test_expectations file.
-files[LAYOUT_TEST_DIR + '/platform/test/test_expectations.txt'] = """
+filesystem.maybe_make_directory(LAYOUT_TEST_DIR + '/pl

[webkit-changes] [103013] trunk

[kbr]

Title: [103013] trunk








Revision 103013
Author k...@google.com
Date 2011-12-15 19:05:08 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed, rolling out r103000.
http://trac.webkit.org/changeset/103000
https://bugs.webkit.org/show_bug.cgi?id=74658

Does not handle text/plain documents correctly.

Source/WebCore: 

* html/parser/HTMLTokenizer.cpp:
* html/parser/HTMLTokenizer.h:
* html/parser/HTMLTreeBuilder.cpp:
* html/parser/HTMLTreeBuilder.h:
* xml/parser/MarkupTokenizerBase.h:

LayoutTests: 

* html5lib/runner-expected.txt:
* platform/chromium/html5lib/runner-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/html5lib/runner-expected.txt
trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp
trunk/Source/WebCore/html/parser/HTMLTokenizer.h
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h
trunk/Source/WebCore/xml/parser/MarkupTokenizerBase.h




Diff

Modified: trunk/LayoutTests/ChangeLog (103012 => 103013)

--- trunk/LayoutTests/ChangeLog	2011-12-16 03:02:33 UTC (rev 103012)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 03:05:08 UTC (rev 103013)
@@ -1,3 +1,14 @@
+2011-12-15  Kenneth Russell  
+
+Unreviewed, rolling out r103000.
+http://trac.webkit.org/changeset/103000
+https://bugs.webkit.org/show_bug.cgi?id=74658
+
+Does not handle text/plain documents correctly.
+
+* html5lib/runner-expected.txt:
+* platform/chromium/html5lib/runner-expected.txt:
+
 2011-12-15  James Robinson  
 
 [chromium] Set the CCLayerTreeHost pointer on LayerChromium instances eagerly


Modified: trunk/LayoutTests/html5lib/runner-expected.txt (103012 => 103013)

--- trunk/LayoutTests/html5lib/runner-expected.txt	2011-12-16 03:02:33 UTC (rev 103012)
+++ trunk/LayoutTests/html5lib/runner-expected.txt	2011-12-16 03:05:08 UTC (rev 103013)
@@ -126,8 +126,28 @@
 
 resources/tests2.dat: PASS
 
-resources/tests3.dat: PASS
+resources/tests3.dat:
+12
 
+Test 12 of 24 in resources/tests3.dat failed. Input:
+

A
+Got:
+| 
+| 
+|   
+|   
+| 
+|   "
+
+A"
+Expected:
+| 
+| 
+|   
+|   
+| 
+|   "
+A"
 resources/tests4.dat: PASS
 
 resources/tests5.dat: PASS


Modified: trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt (103012 => 103013)

--- trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt	2011-12-16 03:02:33 UTC (rev 103012)
+++ trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt	2011-12-16 03:05:08 UTC (rev 103013)
@@ -126,8 +126,28 @@
 
 resources/tests2.dat: PASS
 
-resources/tests3.dat: PASS
+resources/tests3.dat:
+12
 
+Test 12 of 24 in resources/tests3.dat failed. Input:
+

A
+Got:
+| 
+| 
+|   
+|   
+| 
+|   "
+
+A"
+Expected:
+| 
+| 
+|   
+|   
+| 
+|   "
+A"
 resources/tests4.dat: PASS
 
 resources/tests5.dat: PASS


Modified: trunk/Source/WebCore/ChangeLog (103012 => 103013)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 03:02:33 UTC (rev 103012)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 03:05:08 UTC (rev 103013)
@@ -1,3 +1,17 @@
+2011-12-15  Kenneth Russell  
+
+Unreviewed, rolling out r103000.
+http://trac.webkit.org/changeset/103000
+https://bugs.webkit.org/show_bug.cgi?id=74658
+
+Does not handle text/plain documents correctly.
+
+* html/parser/HTMLTokenizer.cpp:
+* html/parser/HTMLTokenizer.h:
+* html/parser/HTMLTreeBuilder.cpp:
+* html/parser/HTMLTreeBuilder.h:
+* xml/parser/MarkupTokenizerBase.h:
+
 2011-12-15  James Robinson  
 
 [chromium] Set the CCLayerTreeHost pointer on LayerChromium instances eagerly


Modified: trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp (103012 => 103013)

--- trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp	2011-12-16 03:02:33 UTC (rev 103012)
+++ trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp	2011-12-16 03:05:08 UTC (rev 103013)
@@ -136,6 +136,7 @@
 m_state = HTMLTokenizerState::DataState;
 m_token = 0;
 m_lineNumber = 0;
+m_skipLeadingNewLineForListing = false;
 m_forceNullCharacterReplacement = false;
 m_shouldAllowCDATA = false;
 m_additionalAllowedCharacter = '\0';
@@ -210,6 +211,30 @@
 return haveBufferedCharacterToken();
 UChar cc = m_inputStreamPreprocessor.nextInputCharacter();
 
+// http://www.whatwg.org/specs/web-apps/current-work/multipage/tokenization.html#parsing-main-inbody
+// Note that this logic is different than the generic \r\n collapsing
+// handled in the input stream preprocessor. This logic is here as an
+// "authoring convenience" so folks can write:
+//
+// 
+// lorem ipsum
+// lorem ipsum
+// 
+//
+// without getting an extra newline at the start of their  element.
+if (m_skipLeadingNewLineForListing) {
+m_skipLeadingNewLineForListing = false;
+if (cc == '\n') {
+ 

[webkit-changes] [103012] trunk/Tools

[dpranke]

Title: [103012] trunk/Tools








Revision 103012
Author dpra...@chromium.org
Date 2011-12-15 19:02:33 -0800 (Thu, 15 Dec 2011)


Log Message
webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
https://bugs.webkit.org/show_bug.cgi?id=74551

This is some minor cleanup prior to making all of the host/port
changes described in bug 74138.

* Scripts/webkitpy/common/host_mock.py:
(MockHost.__init__):
  - make sure the scm object is initialized with the same mock
executive and filesystem objects.

* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.clear_written_files):
  - add a routine that will be useful in testing.
(MockFileSystem.maybe_make_directory):
(MockFileSystem.write_binary_file):
  - fix bugs to make sure directories are created properly.
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_Process.run):
  - add clarifying comments.
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRTPort.__init__):
(MockDRT.__init__):
  - add clarifying comments.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/host_mock.py
trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py




Diff

Modified: trunk/Tools/ChangeLog (103011 => 103012)

--- trunk/Tools/ChangeLog	2011-12-16 02:32:29 UTC (rev 103011)
+++ trunk/Tools/ChangeLog	2011-12-16 03:02:33 UTC (rev 103012)
@@ -1,3 +1,30 @@
+2011-12-15  Dirk Pranke  
+
+webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
+https://bugs.webkit.org/show_bug.cgi?id=74551
+
+This is some minor cleanup prior to making all of the host/port
+changes described in bug 74138.
+
+* Scripts/webkitpy/common/host_mock.py:
+(MockHost.__init__):
+  - make sure the scm object is initialized with the same mock
+executive and filesystem objects.
+
+* Scripts/webkitpy/common/system/filesystem_mock.py:
+(MockFileSystem.clear_written_files):
+  - add a routine that will be useful in testing.
+(MockFileSystem.maybe_make_directory):
+(MockFileSystem.write_binary_file):
+  - fix bugs to make sure directories are created properly.
+* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
+(_Process.run):
+  - add clarifying comments.
+* Scripts/webkitpy/layout_tests/port/mock_drt.py:
+(MockDRTPort.__init__):
+(MockDRT.__init__):
+  - add clarifying comments.
+
 2011-12-15  Anders Carlsson  
 
 Regression (r102866): Navigating away from or closing a page with a plugin crashes


Modified: trunk/Tools/Scripts/webkitpy/common/host_mock.py (103011 => 103012)

--- trunk/Tools/Scripts/webkitpy/common/host_mock.py	2011-12-16 02:32:29 UTC (rev 103011)
+++ trunk/Tools/Scripts/webkitpy/common/host_mock.py	2011-12-16 03:02:33 UTC (rev 103012)
@@ -44,7 +44,7 @@
 self.web = MockWeb()
 
 self._checkout = MockCheckout()
-self._scm = MockSCM()
+self._scm = MockSCM(filesystem=self.filesystem, executive=self.executive)
 # Various pieces of code (wrongly) call filesystem.chdir(checkout_root).
 # Making the checkout_root exist in the mock filesystem makes that chdir not raise.
 self.filesystem.maybe_make_directory(self._scm.checkout_root)


Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py (103011 => 103012)

--- trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py	2011-12-16 02:32:29 UTC (rev 103011)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py	2011-12-16 03:02:33 UTC (rev 103012)
@@ -64,6 +64,10 @@
 
 sep = property(_get_sep, doc="pathname separator")
 
+def clear_written_files(self):
+# This function can be used to track what is written between steps in a test.
+self.written_files = {}
+
 def _raise_not_found(self, path):
 raise IOError(errno.ENOENT, path, os.strerror(errno.ENOENT))
 
@@ -243,8 +247,9 @@
 
 def maybe_make_directory(self, *path):
 norm_path = self.normpath(self.join(*path))
-if not self.isdir(norm_path):
+while norm_path and not self.isdir(norm_path):
 self.dirs.add(norm_path)
+norm_path = self.dirname(norm_path)
 
 def move(self, source, destination):
 if self.files[source] is None:
@@ -275,6 +280,7 @@
 return self.files[path]
 
 def write_binary_file(self, path, contents):
+# FIXME: should this assert if dirname(path) doesn't exist?
 self.files[path] = contents
 self.written_files[path] = contents
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py (103011 => 103012)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py	2011-12-16 02:32:29 UTC (re

[webkit-changes] [103011] trunk

[jamesr]

Title: [103011] trunk








Revision 103011
Author jam...@google.com
Date 2011-12-15 18:32:29 -0800 (Thu, 15 Dec 2011)


Log Message
[chromium] Set the CCLayerTreeHost pointer on LayerChromium instances eagerly
https://bugs.webkit.org/show_bug.cgi?id=74477

Reviewed by Kenneth Russell.

Source/WebCore:

This enforces that the m_layerTreeHost pointer on LayerChromium instances is always up to date, instead of
lazily setting it in the paintContents loop. There are two invariants:
1.) If a LayerChromium is the root layer of a CCLayerTreeHost, or is reachable via the children, mask, or
replica pointers from the root layer of a CCLayerTreeHost, then that LayerChromium's m_layerTreeHost pointer
refers to that CCLayerTreeHost
2.) If a LayerChromium is not a root layer or reachable from a root layer of any CCLayerTreeHost, its
CCLayerTreeHost pointer is nil.

Covered by several new layout tests in LayerChromiumTest

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setLayerTreeHost):
(WebCore::LayerChromium::setParent):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setReplicaLayer):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::createTile):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Add some new tests for LayerChromium::m_layerTreeHost behavior.

* tests/CCLayerTreeHostTest.cpp:
(::MockLayerTreeHost::create):
(::MockLayerTreeHost::MockLayerTreeHost):
(::CCLayerTreeHostTestShortlived1::beginTest):
(::CCLayerTreeHostTestShortlived2::beginTest):
(::CCLayerTreeHostTestShortlived3::beginTest):
* tests/LayerChromiumTest.cpp:

LayoutTests:

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (103010 => 103011)

--- trunk/LayoutTests/ChangeLog	2011-12-16 02:32:08 UTC (rev 103010)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 02:32:29 UTC (rev 103011)
@@ -1,3 +1,12 @@
+2011-12-15  James Robinson  
+
+[chromium] Set the CCLayerTreeHost pointer on LayerChromium instances eagerly
+https://bugs.webkit.org/show_bug.cgi?id=74477
+
+Reviewed by Kenneth Russell.
+
+* platform/chromium/test_expectations.txt:
+
 2011-12-15  Adam Barth  
 
  parses incorrectly


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103010 => 103011)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-16 02:32:08 UTC (rev 103010)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-16 02:32:29 UTC (rev 103011)
@@ -2804,6 +2804,10 @@
 BUGWK49629 SKIP : platform/chromium/compositing/lots-of-img-layers-with-opacity.html = PASS
 BUGWK49629 SKIP : compositing/iframes/page-cache-layer-tree.html = PASS
 
+// Needs an image-only rebaseline since we no longer invalidate when setting the replica layer
+// to NULL when it already was NULL so we have no damage at the end of the test.
+BUGJAMESR : compositing/iframes/iframe-content-flipping.html = IMAGE
+
 BUGNONE SLOW WIN DEBUG GPU : fast/canvas/canvas-getImageData.html = PASS
 
 // Accelerated 2d for mac isn't supported yet, so SKIP this test for now.


Modified: trunk/Source/WebCore/ChangeLog (103010 => 103011)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 02:32:08 UTC (rev 103010)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 02:32:29 UTC (rev 103011)
@@ -1,3 +1,34 @@
+2011-12-15  James Robinson  
+
+[chromium] Set the CCLayerTreeHost pointer on LayerChromium instances eagerly
+https://bugs.webkit.org/show_bug.cgi?id=74477
+
+Reviewed by Kenneth Russell.
+
+This enforces that the m_layerTreeHost pointer on LayerChromium instances is always up to date, instead of
+lazily setting it in the paintContents loop. There are two invariants:
+1.) If a LayerChromium is the root layer of a CCLayerTreeHost, or is reachable via the children, mask, or
+replica pointers from the root layer of a CCLayerTreeHost, then that La

[webkit-changes] [103010] trunk/Source/WebKit2

[andersca]

Title: [103010] trunk/Source/WebKit2








Revision 103010
Author ander...@apple.com
Date 2011-12-15 18:32:08 -0800 (Thu, 15 Dec 2011)


Log Message
Add support for accelerated compositing to the tiled Core Animation drawing area
https://bugs.webkit.org/show_bug.cgi?id=74675

Reviewed by Andreas Kling.

Add a layer flush scheduler and get rid of the content layer since WebCore will manage that for us.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::scroll):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (103009 => 103010)

--- trunk/Source/WebKit2/ChangeLog	2011-12-16 02:15:22 UTC (rev 103009)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-16 02:32:08 UTC (rev 103010)
@@ -1,3 +1,23 @@
+2011-12-15  Anders Carlsson  
+
+Add support for accelerated compositing to the tiled Core Animation drawing area
+https://bugs.webkit.org/show_bug.cgi?id=74675
+
+Reviewed by Andreas Kling.
+
+Add a layer flush scheduler and get rid of the content layer since WebCore will manage that for us.
+
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
+(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
+(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
+(WebKit::TiledCoreAnimationDrawingArea::scroll):
+(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
+(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):
+(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
+(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
+
 2011-12-15  Sheriff Bot  
 
 Unreviewed, rolling out r102652 and r102717.


Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h (103009 => 103010)

--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h	2011-12-16 02:15:22 UTC (rev 103009)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h	2011-12-16 02:32:08 UTC (rev 103010)
@@ -27,6 +27,8 @@
 #define TiledCoreAnimationDrawingArea_h
 
 #include "DrawingArea.h"
+#include 
+#include 
 #include 
 
 OBJC_CLASS CALayer;
@@ -36,7 +38,7 @@
 
 namespace WebKit {
 
-class TiledCoreAnimationDrawingArea : public DrawingArea {
+class TiledCoreAnimationDrawingArea : public DrawingArea, private WebCore::LayerFlushSchedulerClient {
 public:
 static PassOwnPtr create(WebPage*, const WebPageCreationParameters&);
 virtual ~TiledCoreAnimationDrawingArea();
@@ -51,14 +53,16 @@
 virtual void setRootCompositingLayer(WebCore::GraphicsLayer*) OVERRIDE;
 virtual void scheduleCompositingLayerSync() OVERRIDE;
 
+// WebCore::LayerFlushSchedulerClient
+virtual bool flushLayers() OVERRIDE;
+
 // Message handlers.
 virtual void updateGeometry(const WebCore::IntSize& viewSize) OVERRIDE;
 
+WebCore::LayerFlushScheduler m_layerFlushScheduler;
 RetainPtr m_remoteLayerClient;
 
 RetainPtr m_rootLayer;
-
-RetainPtr m_contentLayer;
 };
 
 } // namespace WebKit


Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (103009 => 103010)

--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	2011-12-16 02:15:22 UTC (rev 103009)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	2011-12-16 02:32:08 UTC (rev 103010)
@@ -31,7 +31,12 @@
 #import "WebPage.h"
 #import "WebProcess.h"
 #import 
+#import 
+#import 
 #import 
+#import 
+#import 
+#import 
 #import 
 
 @interface CATransaction (Details)
@@ -40,37 +45,6 @@
 
 using namespace WebCore;
 
-@interface WKContentLayer : CALayer {
-WebKit::WebPage *_webPage;
-}
-
-- (id)initWithWebPage:(WebKit::WebPage *)webPage;
-
-@end
-
-@implementation WKContentLayer
-
-- (id)initWithWebPage:(WebKit::WebPage *)webPage
-{
-self = [super init];
-if (self)
-self->_webPage = webPage;
-
-return self;
-}
-
-- (void)drawInContext:(CGContextRef)context
-{
-_webPage->layoutIfNeeded();
-
-CGRect clipRect = CGContextGetClipBoundingBox(context);
-
-GraphicsCon

[webkit-changes] [103009] trunk/Source

[commit-queue]

Title: [103009] trunk/Source








Revision 103009
Author commit-qu...@webkit.org
Date 2011-12-15 18:15:22 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed, rolling out r102652 and r102717.
http://trac.webkit.org/changeset/102652
http://trac.webkit.org/changeset/102717
https://bugs.webkit.org/show_bug.cgi?id=74674

Broke too many webs. (Requested by kling on #webkit).

Patch by Sheriff Bot  on 2011-12-15

Source/WebCore:

* WebCore.exp.in:

Source/WebKit2:

* UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowAndViewFramesChanged):
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowRect):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::windowFrameInScreenCoordinates):
(WebKit::WebPage::viewFrameInWindowCoordinates):
(WebKit::WebPage::accessibilityPosition):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (103008 => 103009)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 02:15:22 UTC (rev 103009)
@@ -1,3 +1,14 @@
+2011-12-15  Sheriff Bot  
+
+Unreviewed, rolling out r102652 and r102717.
+http://trac.webkit.org/changeset/102652
+http://trac.webkit.org/changeset/102717
+https://bugs.webkit.org/show_bug.cgi?id=74674
+
+Broke too many webs. (Requested by kling on #webkit).
+
+* WebCore.exp.in:
+
 2011-12-15  Anders Carlsson  
 
 Lazily create the scrolling coordinator and add a setting for enabling it


Modified: trunk/Source/WebCore/WebCore.exp.in (103008 => 103009)

--- trunk/Source/WebCore/WebCore.exp.in	2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebCore/WebCore.exp.in	2011-12-16 02:15:22 UTC (rev 103009)
@@ -140,7 +140,6 @@
 __ZN7WebCore10ClientRectC1Ev
 __ZN7WebCore10CredentialC1ERKN3WTF6StringES4_NS_21CredentialPersistenceE
 __ZN7WebCore10CredentialC1Ev
-__ZN7WebCore10FloatPointC1ERK8_NSPoint
 __ZN7WebCore10FloatPointC1ERKNS_8IntPointE
 __ZN7WebCore10JSDocument6s_infoE
 __ZN7WebCore10MouseEvent6createERKN3WTF12AtomicStringENS1_10PassRefPtrINS_9DOMWindowEEERKNS_18PlatformMouseEventEiNS5_INS_4NodeEEE


Modified: trunk/Source/WebKit2/ChangeLog (103008 => 103009)

--- trunk/Source/WebKit2/ChangeLog	2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-16 02:15:22 UTC (rev 103009)
@@ -1,3 +1,32 @@
+2011-12-15  Sheriff Bot  
+
+Unreviewed, rolling out r102652 and r102717.
+http://trac.webkit.org/changeset/102652
+http://trac.webkit.org/changeset/102717
+https://bugs.webkit.org/show_bug.cgi?id=74674
+
+Broke too many webs. (Requested by kling on #webkit).
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView _updateWindowAndViewFrames]):
+* UIProcess/WebPageProxy.h:
+* UIProcess/mac/WebPageProxyMac.mm:
+(WebKit::WebPageProxy::windowAndViewFramesChanged):
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::windowAndViewFramesChanged):
+* WebProcess/Plugins/PluginView.h:
+* WebProcess/WebCoreSupport/WebChromeClient.cpp:
+(WebKit::WebChromeClient::windowRect):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::windowAndViewFramesChanged):
+* WebProcess/WebPage/WebPage.h:
+(WebKit::WebPage::windowFrameInScreenCoordinates):
+(WebKit::WebPage::viewFrameInWindowCoordinates):
+(WebKit::WebPage::accessibilityPosition):
+* WebProcess/WebPage/WebPage.messages.in:
+* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
+(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
+
 2011-12-15  Gustavo Noronha Silva  
 
 [GTK] New API test for WindowProperties fails


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (103008 => 103009)

--- trunk/Source/WebKit2/UIProcess/API/mac/W

[webkit-changes] [103008] trunk

[andersca]

Title: [103008] trunk








Revision 103008
Author ander...@apple.com
Date 2011-12-15 18:00:43 -0800 (Thu, 15 Dec 2011)


Log Message
Source/_javascript_Core: Regression (r102866): Navigating away from or closing a page with a plugin crashes
https://bugs.webkit.org/show_bug.cgi?id=74655


Reviewed by Sam Weinig.

Rewrite HasRefAndDeref to work if ref and deref are implemented in base classes,
using a modified version of the technique described here:
http://groups.google.com/group/comp.lang.c++.moderated/msg/e5fbc9305539f699

* wtf/Functional.h:

Tools: Regression (r102866): Navigating away from or closing a page with a plugin crashes
https://bugs.webkit.org/show_bug.cgi?id=74655

Reviewed by Sam Weinig.

Add a bunch of tests.

* TestWebKitAPI/Tests/WTF/Functional.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Functional.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/Functional.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (103007 => 103008)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-16 01:50:47 UTC (rev 103007)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-16 02:00:43 UTC (rev 103008)
@@ -1,3 +1,17 @@
+2011-12-15  Anders Carlsson  
+
+Regression (r102866): Navigating away from or closing a page with a plugin crashes
+https://bugs.webkit.org/show_bug.cgi?id=74655
+
+
+Reviewed by Sam Weinig.
+
+Rewrite HasRefAndDeref to work if ref and deref are implemented in base classes,
+using a modified version of the technique described here:
+http://groups.google.com/group/comp.lang.c++.moderated/msg/e5fbc9305539f699
+
+* wtf/Functional.h:
+
 2011-12-15  Andy Wingo  
 
 Warnings fixes in Interpreter.cpp and PrivateExecute.cpp


Modified: trunk/Source/_javascript_Core/wtf/Functional.h (103007 => 103008)

--- trunk/Source/_javascript_Core/wtf/Functional.h	2011-12-16 01:50:47 UTC (rev 103007)
+++ trunk/Source/_javascript_Core/wtf/Functional.h	2011-12-16 02:00:43 UTC (rev 103008)
@@ -46,16 +46,26 @@
 char padding[8];
 };
 
-template struct TypeChecker { };
+struct BaseMixin {
+void deref();
+void ref();
+};
 
+struct Base : public T, public BaseMixin { };
+
+template struct
+TypeChecker { };
+
 template
-static YesType refAndDerefCheck(TypeChecker*);
+static NoType refCheck(U*, TypeChecker* = 0);
+static YesType refCheck(...);
 
 template
-static NoType refAndDerefCheck(...);
+static NoType derefCheck(U*, TypeChecker* = 0);
+static YesType derefCheck(...);
 
 public:
-static const bool value = sizeof(refAndDerefCheck(0)) == sizeof(YesType);
+static const bool value = sizeof(refCheck(static_cast(0))) == sizeof(YesType) && sizeof(derefCheck(static_cast(0))) == sizeof(YesType);
 };
 
 // A FunctionWrapper is a class template that can wrap a function pointer or a member function pointer and


Modified: trunk/Tools/ChangeLog (103007 => 103008)

--- trunk/Tools/ChangeLog	2011-12-16 01:50:47 UTC (rev 103007)
+++ trunk/Tools/ChangeLog	2011-12-16 02:00:43 UTC (rev 103008)
@@ -1,3 +1,14 @@
+2011-12-15  Anders Carlsson  
+
+Regression (r102866): Navigating away from or closing a page with a plugin crashes
+https://bugs.webkit.org/show_bug.cgi?id=74655
+
+Reviewed by Sam Weinig.
+
+Add a bunch of tests.
+
+* TestWebKitAPI/Tests/WTF/Functional.cpp:
+
 2011-12-15  Stephanie Lewis  
 
 https://bugs.webkit.org/show_bug.cgi?id=74469


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Functional.cpp (103007 => 103008)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/Functional.cpp	2011-12-16 01:50:47 UTC (rev 103007)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Functional.cpp	2011-12-16 02:00:43 UTC (rev 103008)
@@ -151,4 +151,24 @@
 
 }
 
+namespace RefAndDerefTests {
+
+template struct RefCounted {
+void ref();
+void deref();
+};
+struct Connection : RefCounted { };
+COMPILE_ASSERT(WTF::HasRefAndDeref::value, class_has_ref_and_deref);
+
+struct NoRefOrDeref { };
+COMPILE_ASSERT(!WTF::HasRefAndDeref::value, class_has_no_ref_or_deref);
+
+struct RefOnly { void ref(); };
+COMPILE_ASSERT(!WTF::HasRefAndDeref::value, class_has_ref_only);
+
+struct DerefOnly { void deref(); };
+COMPILE_ASSERT(!WTF::HasRefAndDeref::value, class_has_deref_only);
+
+}
+
 } // namespace TestWebKitAPI






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103007] trunk/Source/WebCore

[andersca]

Title: [103007] trunk/Source/WebCore








Revision 103007
Author ander...@apple.com
Date 2011-12-15 17:50:47 -0800 (Thu, 15 Dec 2011)


Log Message
Lazily create the scrolling coordinator and add a setting for enabling it
https://bugs.webkit.org/show_bug.cgi?id=74667

Reviewed by Darin Adler.

* WebCore.xcodeproj/project.pbxproj:
Make ScrollingCoordinator.h a private header so it can be used in WebKit.
* page/Page.cpp:
(WebCore::Page::Page):
Don't create the scrolling coordinator.

(WebCore::Page::~Page):
Check for a null scrolling coordinator.

(WebCore::Page::scrollingCoordinator):
Create the scrolling coordinator lazily.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setScrollingCoordinatorEnabled):
(WebCore::Settings::scrollingCoordinatorEnabled):
Add a setting for enabling the scrolling coordinator.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
Use a tile cache layer for the main frame when the scrolling coordinator is neabled.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (103006 => 103007)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 01:33:56 UTC (rev 103006)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 01:50:47 UTC (rev 103007)
@@ -1,3 +1,33 @@
+2011-12-15  Anders Carlsson  
+
+Lazily create the scrolling coordinator and add a setting for enabling it
+https://bugs.webkit.org/show_bug.cgi?id=74667
+
+Reviewed by Darin Adler.
+
+* WebCore.xcodeproj/project.pbxproj:
+Make ScrollingCoordinator.h a private header so it can be used in WebKit.
+* page/Page.cpp:
+(WebCore::Page::Page):
+Don't create the scrolling coordinator.
+
+(WebCore::Page::~Page):
+Check for a null scrolling coordinator.
+
+(WebCore::Page::scrollingCoordinator):
+Create the scrolling coordinator lazily.
+
+* page/Settings.cpp:
+(WebCore::Settings::Settings):
+* page/Settings.h:
+(WebCore::Settings::setScrollingCoordinatorEnabled):
+(WebCore::Settings::scrollingCoordinatorEnabled):
+Add a setting for enabling the scrolling coordinator.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::RenderLayerBacking):
+Use a tile cache layer for the main frame when the scrolling coordinator is neabled.
+
 2011-12-15  Gyuyoung Kim  
 
 Unreviewed. Fix build break when data-transfer-items is enabled.


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (103006 => 103007)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-12-16 01:33:56 UTC (rev 103006)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-12-16 01:50:47 UTC (rev 103007)
@@ -373,7 +373,7 @@
 		1A2E6E5A0CC55213004A2062 /* SQLValue.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A2E6E580CC55213004A2062 /* SQLValue.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		1A2E6E7A0CC556D5004A2062 /* SQLiteAuthorizer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A2E6E780CC556D5004A2062 /* SQLiteAuthorizer.cpp */; };
 		1A2F9D7914968C740065AC63 /* ScrollingCoordinator.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A2F9D7714968C740065AC63 /* ScrollingCoordinator.cpp */; };
-		1A2F9D7A14968C740065AC63 /* ScrollingCoordinator.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A2F9D7814968C740065AC63 /* ScrollingCoordinator.h */; };
+		1A2F9D7A14968C740065AC63 /* ScrollingCoordinator.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A2F9D7814968C740065AC63 /* ScrollingCoordinator.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		1A3417C90CECFF250049CBDE /* JSCustomVoidCallback.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A3417C70CECFF250049CBDE /* JSCustomVoidCallback.h */; };
 		1A3417CA0CECFF250049CBDE /* JSCustomVoidCallback.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A3417C80CECFF250049CBDE /* JSCustomVoidCallback.cpp */; };
 		1A494BFA0A122F4400FDAFC1 /* JSHTMLElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A494BF80A122F4400FDAFC1 /* JSHTMLElement.cpp */; };


Modified: trunk/Source/WebCore/page/Page.cpp (103006 => 103007)

--- trunk/Source/WebCore/page/Page.cpp	2011-12-16 01:33:56 UTC (rev 103006)
+++ trunk/Source/WebCore/page/Page.cpp	2011-12-16 01:50:47 UTC (rev 103007)
@@ -152,9 +152,6 @@
 #if ENABLE(MEDIA_STREAM)
 , m_userMediaClient(pageClients.userMediaClient)
 #endif
-#if ENABLE(THREADED_SCROLLING)
-, m_scrollingCoordinator(ScrollingCoordinator::create(this))
-#endif
 , m_settings(adoptPtr(new Settings(this)))
 , m_progress(adoptPtr(new ProgressTracker))
 , m_backForwardController(adoptPtr(new BackForwardC

[webkit-changes] [103005] trunk

[abarth]

Title: [103005] trunk








Revision 103005
Author aba...@webkit.org
Date 2011-12-15 17:19:44 -0800 (Thu, 15 Dec 2011)


Log Message
 parses incorrectly
https://bugs.webkit.org/show_bug.cgi?id=74668

Reviewed by Darin Adler.

Source/WebCore: 

This patch updates our implementation to match a change to the HTML5
specification regarding how  elements parse.  Previously, 
and similar tags used to pop the stack up to the  element.  Now
the popping does not occur.

Tests: html5lib/runner.html

* html/parser/HTMLTreeBuilder.cpp:

LayoutTests: 

Update test results to show progression.

* html5lib/runner-expected.txt:
* platform/chromium/html5lib/runner-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/html5lib/runner-expected.txt
trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (103004 => 103005)

--- trunk/LayoutTests/ChangeLog	2011-12-16 01:17:45 UTC (rev 103004)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 01:19:44 UTC (rev 103005)
@@ -1,5 +1,17 @@
 2011-12-15  Adam Barth  
 
+ parses incorrectly
+https://bugs.webkit.org/show_bug.cgi?id=74668
+
+Reviewed by Darin Adler.
+
+Update test results to show progression.
+
+* html5lib/runner-expected.txt:
+* platform/chromium/html5lib/runner-expected.txt:
+
+2011-12-15  Adam Barth  
+
 

A doesn't parse correctly
 https://bugs.webkit.org/show_bug.cgi?id=74658
 


Modified: trunk/LayoutTests/html5lib/runner-expected.txt (103004 => 103005)

--- trunk/LayoutTests/html5lib/runner-expected.txt	2011-12-16 01:17:45 UTC (rev 103004)
+++ trunk/LayoutTests/html5lib/runner-expected.txt	2011-12-16 01:19:44 UTC (rev 103005)
@@ -157,96 +157,8 @@
 resources/tests18.dat: PASS
 
 resources/tests19.dat:
-14
-15
-17
-18
 81
 
-Test 14 of 104 in resources/tests19.dat failed. Input:
-
-Got:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-Expected:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-
-Test 15 of 104 in resources/tests19.dat failed. Input:
-
-Got:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-Expected:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-| 
-
-Test 17 of 104 in resources/tests19.dat failed. Input:
-
-Got:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-Expected:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-
-Test 18 of 104 in resources/tests19.dat failed. Input:
-
-Got:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-Expected:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-| 
-
 Test 81 of 104 in resources/tests19.dat failed. Input:
 
 Got:
@@ -793,47 +705,8 @@
 
 resources/tests_innerHTML_1.dat: PASS
 
-resources/webkit01.dat:
-26
-27
+resources/webkit01.dat: PASS
 
-Test 26 of 49 in resources/webkit01.dat failed. Input:
-xx
-Got:
-| 
-|   
-|   
-| 
-|   
-|   
-| "xx"
-Expected:
-| 
-|   
-|   
-| 
-|   
-| 
-|   "xx"
-
-Test 27 of 49 in resources/webkit01.dat failed. Input:
-xx
-Got:
-| 
-|   
-|   
-| 
-|   
-|   
-| "xx"
-Expected:
-| 
-|   
-|   
-| 
-|   
-| 
-|   "xx"
 resources/webkit02.dat: PASS
 
 resources/doctype01.dat: PASS


Modified: trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt (103004 => 103005)

--- trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt	2011-12-16 01:17:45 UTC (rev 103004)
+++ trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt	2011-12-16 01:19:44 UTC (rev 103005)
@@ -157,96 +157,8 @@
 resources/tests18.dat: PASS
 
 resources/tests19.dat:
-14
-15
-17
-18
 81
 
-Test 14 of 104 in resources/tests19.dat failed. Input:
-
-Got:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-Expected:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-
-Test 15 of 104 in resources/tests19.dat failed. Input:
-
-Got:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-Expected:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-| 
-
-Test 17 of 104 in resources/tests19.dat failed. Input:
-
-Got:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-Expected:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-
-Test 18 of 104 in resources/tests19.dat failed. Input:
-
-Got:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-|   
-Expected:
-| 
-| 
-|   
-|   
-| 
-|   
-| 
-| 
-
 Test 81 of 104 in resources/tests19.dat failed. Input:
 
 Got:
@@ -793,47 +705,8 @@
 
 resources/tests_innerHTML_1.dat: PASS
 
-resources/webkit01.dat:
-26
-27
+resources/webkit01.dat: PASS
 
-Test 26 of 49 in resources/webkit01.dat failed. Input:
-xx
-Got:
-| 
-|   
-|   
-| 
-|   
-|   
-| "xx"
-Expected:
-| 
-|   
-|   
-| 
-|   
-| 
-|   "xx"
-
-Test 27 of 49 in reso

[webkit-changes] [103004] trunk/Source/WebCore

[commit-queue]

Title: [103004] trunk/Source/WebCore








Revision 103004
Author commit-qu...@webkit.org
Date 2011-12-15 17:17:45 -0800 (Thu, 15 Dec 2011)


Log Message
[Chromium] Avoid strdup() for extra argument when tracing is disabled.
https://bugs.webkit.org/show_bug.cgi?id=74637

Patch by Daniel Sievers  on 2011-12-15
Reviewed by James Robinson.

* platform/chromium/TraceEvent.h:
(WebCore::internal::ScopeTracer::ScopeTracer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/TraceEvent.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (103003 => 103004)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 01:12:45 UTC (rev 103003)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 01:17:45 UTC (rev 103004)
@@ -1,3 +1,13 @@
+2011-12-15  Daniel Sievers  
+
+[Chromium] Avoid strdup() for extra argument when tracing is disabled.
+https://bugs.webkit.org/show_bug.cgi?id=74637
+
+Reviewed by James Robinson.
+
+* platform/chromium/TraceEvent.h:
+(WebCore::internal::ScopeTracer::ScopeTracer):
+
 2011-12-15  Rafael Weinstein  
 
 [MutationObservers] Add a document-level flag that can trivially be checked to avoid doing unnessary work if mutation observers absent


Modified: trunk/Source/WebCore/platform/chromium/TraceEvent.h (103003 => 103004)

--- trunk/Source/WebCore/platform/chromium/TraceEvent.h	2011-12-16 01:12:45 UTC (rev 103003)
+++ trunk/Source/WebCore/platform/chromium/TraceEvent.h	2011-12-16 01:17:45 UTC (rev 103004)
@@ -59,7 +59,7 @@
 , m_id(id)
 {
 PlatformSupport::traceEventBegin(name, id, extra); \
-if (extra)
+if (extra && PlatformSupport::isTraceEventEnabled())
 m_extra = adoptArrayPtr(strdup(extra));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103003] trunk/Source/JavaScriptCore

[commit-queue]

Title: [103003] trunk/Source/_javascript_Core








Revision 103003
Author commit-qu...@webkit.org
Date 2011-12-15 17:12:45 -0800 (Thu, 15 Dec 2011)


Log Message
Warnings fixes in Interpreter.cpp and PrivateExecute.cpp
https://bugs.webkit.org/show_bug.cgi?id=74624

Patch by Andy Wingo  on 2011-12-15
Reviewed by Darin Adler.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Fix variables unused in
release mode.
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment): Fix
signed/unsigned comparison warning, with a cast.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (103002 => 103003)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-16 01:08:25 UTC (rev 103002)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-16 01:12:45 UTC (rev 103003)
@@ -1,5 +1,19 @@
 2011-12-15  Andy Wingo  
 
+Warnings fixes in Interpreter.cpp and PrivateExecute.cpp
+https://bugs.webkit.org/show_bug.cgi?id=74624
+
+Reviewed by Darin Adler.
+
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::privateExecute): Fix variables unused in
+release mode.
+* wtf/ParallelJobsGeneric.cpp:
+(WTF::ParallelEnvironment::ParallelEnvironment): Fix
+signed/unsigned comparison warning, with a cast.
+
+2011-12-15  Andy Wingo  
+
 Use more macrology in JSC::Options
 https://bugs.webkit.org/show_bug.cgi?id=72938
 


Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (103002 => 103003)

--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	2011-12-16 01:08:25 UTC (rev 103002)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	2011-12-16 01:12:45 UTC (rev 103003)
@@ -2655,17 +2655,17 @@
 ScopeChainNode* scopeChain = callFrame->scopeChain();
 ScopeChainIterator iter = scopeChain->begin();
 ScopeChainIterator end = scopeChain->end();
-ASSERT(iter != end);
+ASSERT_UNUSED(end, iter != end);
 ASSERT(codeBlock == callFrame->codeBlock());
 bool checkTopLevel = codeBlock->codeType() == FunctionCode && codeBlock->needsFullScopeChain();
 ASSERT(skip || !checkTopLevel);
-if (checkTopLevel && skip--) {
+if (checkTopLevel && skip--) {
 if (callFrame->r(codeBlock->activationRegister()).jsValue())
 ++iter;
 }
 while (skip--) {
 ++iter;
-ASSERT(iter != end);
+ASSERT_UNUSED(end, iter != end);
 }
 ASSERT((*iter)->isVariableObject());
 JSVariableObject* scope = static_cast(iter->get());
@@ -2686,16 +2686,16 @@
 ScopeChainIterator iter = scopeChain->begin();
 ScopeChainIterator end = scopeChain->end();
 ASSERT(codeBlock == callFrame->codeBlock());
-ASSERT(iter != end);
+ASSERT_UNUSED(end, iter != end);
 bool checkTopLevel = codeBlock->codeType() == FunctionCode && codeBlock->needsFullScopeChain();
 ASSERT(skip || !checkTopLevel);
-if (checkTopLevel && skip--) {
+if (checkTopLevel && skip--) {
 if (callFrame->r(codeBlock->activationRegister()).jsValue())
 ++iter;
 }
 while (skip--) {
 ++iter;
-ASSERT(iter != end);
+ASSERT_UNUSED(end, iter != end);
 }
 
 ASSERT((*iter)->isVariableObject());


Modified: trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.cpp (103002 => 103003)

--- trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.cpp	2011-12-16 01:08:25 UTC (rev 103002)
+++ trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.cpp	2011-12-16 01:12:45 UTC (rev 103003)
@@ -66,7 +66,7 @@
 int maxNumberOfNewThreads = requestedJobNumber - 1;
 
 for (int i = 0; i < s_maxNumberOfParallelThreads && m_threads.size() < static_cast(maxNumberOfNewThreads); ++i) {
-if (s_threadPool->size() < i + 1)
+if (s_threadPool->size() < static_cast(i) + 1U)
 s_threadPool->append(ThreadPrivate::create());
 
 if ((*s_threadPool)[i]->tryLockFor(this))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [103002] trunk/Tools

[slewis]

Title: [103002] trunk/Tools








Revision 103002
Author sle...@apple.com
Date 2011-12-15 17:08:25 -0800 (Thu, 15 Dec 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=74469
Escape paths to svn commands so our tools can handle filenames with @ symbols.

Reviewed by Adam Roben.

* Scripts/VCSUtils.pm:
(scmMoveOrRenameFile):
(scmAddExecutableBit):
(scmRemoveExecutableBit):
(determineSVNRoot):
(svnRevisionForDirectory):
(pathRelativeToSVNRepositoryRootForPath):
(svnStatus):
(escapeSubversionPath):
* Scripts/parse-malloc-history:
(main):
* Scripts/prepare-ChangeLog:
(diffCommand):
(statusCommand):
(findOriginalFileFromSvn):
(determinePropertyChanges):
* Scripts/resolve-ChangeLogs:
(conflictFiles):
(resolveConflict):
(showStatus):
* Scripts/svn-apply:
(patch):
(scmCopy):
(scmAdd):
(scmRemove):
* Scripts/svn-create-patch:
(findBaseUrl):
(findMimeType):
(findSourceFileAndRevision):
(generateDiff):
(generateFileList):
(manufacturePatchForAdditionWithHistory):
* Scripts/svn-unapply:
(patch):
(revertDirectories):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/VCSUtils.pm
trunk/Tools/Scripts/prepare-ChangeLog
trunk/Tools/Scripts/resolve-ChangeLogs
trunk/Tools/Scripts/svn-apply
trunk/Tools/Scripts/svn-create-patch
trunk/Tools/Scripts/svn-unapply




Diff

Modified: trunk/Tools/ChangeLog (103001 => 103002)

--- trunk/Tools/ChangeLog	2011-12-16 00:59:39 UTC (rev 103001)
+++ trunk/Tools/ChangeLog	2011-12-16 01:08:25 UTC (rev 103002)
@@ -1,3 +1,46 @@
+2011-12-15  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=74469
+Escape paths to svn commands so our tools can handle filenames with @ symbols.
+
+Reviewed by Adam Roben.
+
+* Scripts/VCSUtils.pm:
+(scmMoveOrRenameFile):
+(scmAddExecutableBit):
+(scmRemoveExecutableBit):
+(determineSVNRoot):
+(svnRevisionForDirectory):
+(pathRelativeToSVNRepositoryRootForPath):
+(svnStatus):
+(escapeSubversionPath):
+* Scripts/parse-malloc-history:
+(main):
+* Scripts/prepare-ChangeLog:
+(diffCommand):
+(statusCommand):
+(findOriginalFileFromSvn):
+(determinePropertyChanges):
+* Scripts/resolve-ChangeLogs:
+(conflictFiles):
+(resolveConflict):
+(showStatus):
+* Scripts/svn-apply:
+(patch):
+(scmCopy):
+(scmAdd):
+(scmRemove):
+* Scripts/svn-create-patch:
+(findBaseUrl):
+(findMimeType):
+(findSourceFileAndRevision):
+(generateDiff):
+(generateFileList):
+(manufacturePatchForAdditionWithHistory):
+* Scripts/svn-unapply:
+(patch):
+(revertDirectories):
+
 2011-12-15  Michael Bruning  
 
 [qt][wk2] MiniBrowser: Add pressed state for viewport info button.


Modified: trunk/Tools/Scripts/VCSUtils.pm (103001 => 103002)

--- trunk/Tools/Scripts/VCSUtils.pm	2011-12-16 00:59:39 UTC (rev 103001)
+++ trunk/Tools/Scripts/VCSUtils.pm	2011-12-16 01:08:25 UTC (rev 103002)
@@ -55,6 +55,7 @@
 &decodeGitBinaryPatch
 &determineSVNRoot
 &determineVCSRoot
+&escapeSubversionPath
 &exitStatus
 &fixChangeLogPatch
 &gitBranch
@@ -153,7 +154,9 @@
 my ($source, $destination) = @_;
 return if ! -e $source;
 if (isSVN()) {
-system("svn", "move", $source, $destination);
+my $escapedDestination = escapeSubversionPath($destination);
+my $escapedSource = escapeSubversionPath($source);
+system("svn", "move", $escapedSource, $escapedDestination);
 } elsif (isGit()) {
 system("git", "mv", $source, $destination);
 }
@@ -176,7 +179,8 @@
 my ($path) = @_;
 
 if (isSVN()) {
-system("svn", "propset", "svn:executable", "on", $path) == 0 or die "Failed to run 'svn propset svn:executable on $path'.";
+my $escapedPath = escapeSubversionPath($path);
+system("svn", "propset", "svn:executable", "on", $escapedPath) == 0 or die "Failed to run 'svn propset svn:executable on $escapedPath'.";
 } elsif (isGit()) {
 chmod(0755, $path);
 }
@@ -187,7 +191,8 @@
 my ($path) = @_;
 
 if (isSVN()) {
-system("svn", "propdel", "svn:executable", $path) == 0 or die "Failed to run 'svn propdel svn:executable $path'.";
+my $escapedPath = escapeSubversionPath($path);
+system("svn", "propdel", "svn:executable", $escapedPath) == 0 or die "Failed to run 'svn propdel svn:executable $escapedPath'.";
 } elsif (isGit()) {
 chmod(0664, $path);
 }
@@ -304,8 +309,9 @@
 while (1) {
 my $thisRoot;
 my $thisUUID;
+my $escapedPath = escapeSubversionPath($path);
 # Ignore error messages in case we've run past the root of the checkout.
-open INFO, "svn info '$path' 2> " . File::Spec->devnull() . " |" or die;
+open INFO, "svn info '$escapedPath' 2> " . File::Spec->devnull

[webkit-changes] [103001] trunk/Source/WebCore

[adamk]

Title: [103001] trunk/Source/WebCore








Revision 103001
Author ad...@chromium.org
Date 2011-12-15 16:59:39 -0800 (Thu, 15 Dec 2011)


Log Message
[MutationObservers] Add a document-level flag that can trivially be checked to avoid doing unnessary work if mutation observers absent
https://bugs.webkit.org/show_bug.cgi?id=74641

Patch by Rafael Weinstein  on 2011-12-15
Reviewed by Ojan Vafai.

This patch adds a byte of flags to Document, of which three bits are used to signal if any
node owned by the document has a Mutation Observer of the given type. This is used to
reduce the cost of discovering there are none to a single (inlined) method call and bit-check.
Also, a similar byte of flags which was used to optimize a particular case when mutation observers
are present has been removed, with the reasoning that we should first focus on minimizing impact on
the null-case before optimizing particular in-use cases.

Also, MutationObserverInterestGroup is broken out into its own file (which probably should have happened
earlier, but now avoids a circular header dependency).

No tests needed. This patch is just a refactor.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSMutableStyleDeclaration.cpp:
* dom/CharacterData.cpp:
* dom/ChildListMutationScope.cpp:
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::hasMutationObserversOfType):
(WebCore::Document::hasMutationObservers):
(WebCore::Document::addMutationObserverTypes):
* dom/Element.cpp:
* dom/MutationObserverInterestGroup.cpp: Added.
(WebCore::MutationObserverInterestGroup::createIfNeeded):
(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup):
(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):
* dom/MutationObserverInterestGroup.h: Copied from Source/WebCore/dom/WebKitMutationObserver.h.
(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(WebCore::MutationObserverInterestGroup::hasOldValue):
* dom/Node.cpp:
(WebCore::Node::didMoveToNewOwnerDocument):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::notifyMutationObserversNodeWillDetach):
* dom/Node.h:
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe):
* dom/WebKitMutationObserver.h:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp
trunk/Source/WebCore/dom/CharacterData.cpp
trunk/Source/WebCore/dom/ChildListMutationScope.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/WebKitMutationObserver.cpp
trunk/Source/WebCore/dom/WebKitMutationObserver.h


Added Paths

trunk/Source/WebCore/dom/MutationObserverInterestGroup.cpp
trunk/Source/WebCore/dom/MutationObserverInterestGroup.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (103000 => 103001)

--- trunk/Source/WebCore/CMakeLists.txt	2011-12-16 00:51:06 UTC (rev 103000)
+++ trunk/Source/WebCore/CMakeLists.txt	2011-12-16 00:59:39 UTC (rev 103001)
@@ -561,6 +561,8 @@
 dom/MouseEvent.cpp
 dom/MouseRelatedEvent.cpp
 dom/MutationEvent.cpp
+dom/MutationObserverInterestGroup.cpp
+dom/MutationObserverRegistration.cpp
 dom/MutationRecord.cpp
 dom/NamedNodeMap.cpp
 dom/NameNodeList.cpp


Modified: trunk/Source/WebCore/ChangeLog (103000 => 103001)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 00:51:06 UTC (rev 103000)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 00:59:39 UTC (rev 103001)
@@ -1,3 +1,57 @@
+2011-12-15  Rafael Weinstein  
+
+[MutationObservers] Add a document-level flag that can trivially be checked to avoid doing unnessary work if mutation observers absent
+https://bugs.webkit.org/show_bug.cgi?id=74641
+
+Reviewed by Ojan Vafai.
+
+This patch adds a byte of flags to Document, of which three bits are used to signal if any
+node owned by the document has a Mutation Observer of the given type. This is used to
+reduce the cost of discovering there are none to a single (inlined) method call and bit-check.
+Also, a similar byte of flags which was used to optimize a particular case when mutation observers
+are present has been removed, with the reasoning that we should first focus on minimizing impact on
+the null-case before optimizing particular in-use case

[webkit-changes] [103000] trunk

[abarth]

Title: [103000] trunk








Revision 103000
Author aba...@webkit.org
Date 2011-12-15 16:51:06 -0800 (Thu, 15 Dec 2011)


Log Message


A doesn't parse correctly
https://bugs.webkit.org/show_bug.cgi?id=74658

Reviewed by Darin Adler.

Source/WebCore: 

Previously, we handled skipping newlines after  in the tokenizer,
which isn't how the spec handles them.  Instead, the spec skips them in
the tree builder.  This isn't usually observable, except in the case of
an HTML entity.  In that case, the tokenzier sees '&' (because the
entity hasn't been decoded yet), but the tree builder sees '\n' (the
decoded entity).  This patch fixes the bug by more closely aligning our
implementation with the spec.

Test: html5lib/runner.html

* html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::nextToken):
* html/parser/HTMLTokenizer.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipAtMostOneLeadingNewline):
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
* html/parser/HTMLTreeBuilder.h:
* xml/parser/MarkupTokenizerBase.h:

LayoutTests: 

Shows test progression.

* html5lib/runner-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/html5lib/runner-expected.txt
trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp
trunk/Source/WebCore/html/parser/HTMLTokenizer.h
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h
trunk/Source/WebCore/xml/parser/MarkupTokenizerBase.h




Diff

Modified: trunk/LayoutTests/ChangeLog (102999 => 103000)

--- trunk/LayoutTests/ChangeLog	2011-12-16 00:44:56 UTC (rev 102999)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 00:51:06 UTC (rev 103000)
@@ -1,3 +1,14 @@
+2011-12-15  Adam Barth  
+
+

A doesn't parse correctly
+https://bugs.webkit.org/show_bug.cgi?id=74658
+
+Reviewed by Darin Adler.
+
+Shows test progression.
+
+* html5lib/runner-expected.txt:
+
 2011-12-15  Larry McLister  
 
 Create reftest for render-region-renderer


Modified: trunk/LayoutTests/html5lib/runner-expected.txt (102999 => 103000)

--- trunk/LayoutTests/html5lib/runner-expected.txt	2011-12-16 00:44:56 UTC (rev 102999)
+++ trunk/LayoutTests/html5lib/runner-expected.txt	2011-12-16 00:51:06 UTC (rev 103000)
@@ -126,28 +126,8 @@
 
 resources/tests2.dat: PASS
 
-resources/tests3.dat:
-12
+resources/tests3.dat: PASS
 
-Test 12 of 24 in resources/tests3.dat failed. Input:
-

A
-Got:
-| 
-| 
-|   
-|   
-| 
-|   "
-
-A"
-Expected:
-| 
-| 
-|   
-|   
-| 
-|   "
-A"
 resources/tests4.dat: PASS
 
 resources/tests5.dat: PASS


Modified: trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt (102999 => 103000)

--- trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt	2011-12-16 00:44:56 UTC (rev 102999)
+++ trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt	2011-12-16 00:51:06 UTC (rev 103000)
@@ -126,28 +126,8 @@
 
 resources/tests2.dat: PASS
 
-resources/tests3.dat:
-12
+resources/tests3.dat: PASS
 
-Test 12 of 24 in resources/tests3.dat failed. Input:
-

A
-Got:
-| 
-| 
-|   
-|   
-| 
-|   "
-
-A"
-Expected:
-| 
-| 
-|   
-|   
-| 
-|   "
-A"
 resources/tests4.dat: PASS
 
 resources/tests5.dat: PASS


Modified: trunk/Source/WebCore/ChangeLog (102999 => 103000)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 00:44:56 UTC (rev 102999)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 00:51:06 UTC (rev 103000)
@@ -1,3 +1,32 @@
+2011-12-15  Adam Barth  
+
+

A doesn't parse correctly
+https://bugs.webkit.org/show_bug.cgi?id=74658
+
+Reviewed by Darin Adler.
+
+Previously, we handled skipping newlines after  in the tokenizer,
+which isn't how the spec handles them.  Instead, the spec skips them in
+the tree builder.  This isn't usually observable, except in the case of
+an HTML entity.  In that case, the tokenzier sees '&' (because the
+entity hasn't been decoded yet), but the tree builder sees '\n' (the
+decoded entity).  This patch fixes the bug by more closely aligning our
+implementation with the spec.
+
+Test: html5lib/runner.html
+
+* html/parser/HTMLTokenizer.cpp:
+(WebCore::HTMLTokenizer::reset):
+(WebCore::HTMLTokenizer::nextToken):
+* html/parser/HTMLTokenizer.h:
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipAtMostOneLeadingNewline):
+(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
+(WebCore::HTMLTreeBuilder::processStartTagForInBody):
+(WebCore::HTMLTreeBuilder::processCharacterBuffer):
+* html/parser/HTMLTreeBuilder.h:
+* xml/parser/MarkupTokenizerBas

[webkit-changes] [102999] trunk/Source/WebCore

[kbr]

Title: [102999] trunk/Source/WebCore








Revision 102999
Author k...@google.com
Date 2011-12-15 16:44:56 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed, rolling out r102989.
http://trac.webkit.org/changeset/102989
https://bugs.webkit.org/show_bug.cgi?id=74580

Caused SHOULD NOT BE REACHED assertions in debug builds.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
* rendering/RenderFullScreen.cpp:
(createFullScreenStyle):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::boxPack):
(WebCore::InheritedFlags::setBoxAlign):
(WebCore::InheritedFlags::setBoxPack):
(WebCore::InheritedFlags::initialBoxPack):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleDeprecatedFlexibleBoxData.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFullScreen.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102998 => 102999)

--- trunk/Source/WebCore/ChangeLog	2011-12-16 00:41:00 UTC (rev 102998)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 00:44:56 UTC (rev 102999)
@@ -1,3 +1,31 @@
+2011-12-15  Kenneth Russell  
+
+Unreviewed, rolling out r102989.
+http://trac.webkit.org/changeset/102989
+https://bugs.webkit.org/show_bug.cgi?id=74580
+
+Caused SHOULD NOT BE REACHED assertions in debug builds.
+
+* css/CSSComputedStyleDeclaration.cpp:
+(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+* rendering/RenderDeprecatedFlexibleBox.cpp:
+(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
+(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
+* rendering/RenderFullScreen.cpp:
+(createFullScreenStyle):
+* rendering/style/RenderStyle.h:
+(WebCore::InheritedFlags::boxPack):
+(WebCore::InheritedFlags::setBoxAlign):
+(WebCore::InheritedFlags::setBoxPack):
+(WebCore::InheritedFlags::initialBoxPack):
+* rendering/style/RenderStyleConstants.h:
+* rendering/style/StyleDeprecatedFlexibleBoxData.h:
+
 2011-12-15  Ryosuke Niwa  
 
 Touch make_name.pl in an attempt to make Qt bots happy.


Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (102998 => 102999)

--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2011-12-16 00:41:00 UTC (rev 102998)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2011-12-16 00:44:56 UTC (rev 102999)
@@ -1401,8 +1401,14 @@
 return cssValuePool->createValue(style->boxOrdinalGroup(), CSSPrimitiveValue::CSS_NUMBER);
 case CSSPropertyWebkitBoxOrient:
 return cssValuePool->createValue(style->boxOrient());
-case CSSPropertyWebkitBoxPack:
-return cssValuePool->createValue(style->boxPack());
+case CSSPropertyWebkitBoxPack: {
+EBoxAlignment boxPack = style->boxPack();
+ASSERT(boxPack != BSTRETCH);
+ASSERT(boxPack != BBASELINE);
+if (boxPack == BJUSTIFY || boxPack== BBASELINE)
+return 0;
+return cssValuePool->createValue(boxPack);
+}
 case CSSPropertyWebkitBoxReflect:
 return valueForReflection(style->boxReflect(), style.get(), cssValuePool);
 case CSSPropertyBoxShadow:


Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (102998 => 102999)

--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2011-12-16 00:41:00 UTC (rev 102998)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2011-12-16 00:44:56 UTC (rev 102999)
@@ -649,43 +649,6 @@
 }
 }
 
-template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EBoxPack e)
-: CSSValue(PrimitiveClass)
-{
-m_primitiveUnitType = CSS_IDENT;
-switch (e) {
-case Start:
-m_value.ident = CSSValueStart;
-break;
-case Center:
-m_value.ident = CSSValueCenter;
-break;
-case End:
-m_value.ident = CSS

[webkit-changes] [102998] trunk/Source/WebKit

[commit-queue]

Title: [102998] trunk/Source/WebKit








Revision 102998
Author commit-qu...@webkit.org
Date 2011-12-15 16:41:00 -0800 (Thu, 15 Dec 2011)


Log Message
[BlackBerry] Regression: lots of checkerboarding
https://bugs.webkit.org/show_bug.cgi?id=74611

Patch by Jacky Jiang  on 2011-12-15
Reviewed by Daniel Bates.

Fix a regression caused by r102843 which introduced a lot of unnecessary
checkerboarding. R102843 changed behavior by removing a check for blit
based on whether the render actually took place and whether the
backingstore was in the midst of suspended updates.
The initial anthor is Adam Treat .

* blackberry/Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
(BlackBerry::WebKit::BackingStorePrivate::renderVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::renderBackingStore):
* blackberry/Api/BackingStore_p.h:
(BlackBerry::WebKit::BackingStorePrivate::isSuspended):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/blackberry/Api/BackingStore.cpp
trunk/Source/WebKit/blackberry/Api/BackingStore_p.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (102997 => 102998)

--- trunk/Source/WebKit/ChangeLog	2011-12-16 00:37:08 UTC (rev 102997)
+++ trunk/Source/WebKit/ChangeLog	2011-12-16 00:41:00 UTC (rev 102998)
@@ -1,3 +1,24 @@
+2011-12-15  Jacky Jiang  
+
+[BlackBerry] Regression: lots of checkerboarding
+https://bugs.webkit.org/show_bug.cgi?id=74611
+
+Reviewed by Daniel Bates.
+
+Fix a regression caused by r102843 which introduced a lot of unnecessary
+checkerboarding. R102843 changed behavior by removing a check for blit
+based on whether the render actually took place and whether the
+backingstore was in the midst of suspended updates.
+The initial anthor is Adam Treat .
+
+* blackberry/Api/BackingStore.cpp:
+(BlackBerry::WebKit::BackingStorePrivate::repaint):
+(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
+(BlackBerry::WebKit::BackingStorePrivate::renderVisibleContents):
+(BlackBerry::WebKit::BackingStorePrivate::renderBackingStore):
+* blackberry/Api/BackingStore_p.h:
+(BlackBerry::WebKit::BackingStorePrivate::isSuspended):
+
 2011-12-15  Adam Treat  
 
 Reviewed by Rob Buis.


Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (102997 => 102998)

--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2011-12-16 00:37:08 UTC (rev 102997)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2011-12-16 00:41:00 UTC (rev 102998)
@@ -333,8 +333,8 @@
 #endif
 
 if (immediate) {
-render(rect);
-blitVisibleContents();
+if (render(rect))
+blitVisibleContents();
 } else
 m_renderQueue->addToQueue(RenderQueue::RegularRender, rect);
 }
@@ -354,8 +354,8 @@
 Platform::IntRect rect = m_webPage->d->mapToTransformed(m_client->mapFromViewportToContents(windowRect));
 
 if (immediate) {
-render(rect);
-blitVisibleContents();
+if (render(rect) && !isSuspended())
+blitVisibleContents();
 } else {
 m_renderQueue->addToQueue(RenderQueue::VisibleScroll, rect);
 // We only blit here if the client did not generate the scroll as the client
@@ -1087,16 +1087,19 @@
 m_webPage->d->requestLayoutIfNeeded();
 }
 
-void BackingStorePrivate::renderVisibleContents()
+bool BackingStorePrivate::renderVisibleContents()
 {
 Platform::IntRect renderRect = shouldDirectRenderingToWindow() ? visibleContentsRect() : visibleTilesRect();
-render(renderRect);
-m_renderQueue->clear(renderRect, true /*clearRegularRenderJobs*/);
+if (render(renderRect)) {
+m_renderQueue->clear(renderRect, true /*clearRegularRenderJobs*/);
+return true;
+}
+return false;
 }
 
-void BackingStorePrivate::renderBackingStore()
+bool BackingStorePrivate::renderBackingStore()
 {
-render(frontState()->backingStoreRect());
+return render(frontState()->backingStoreRect());
 }
 
 void BackingStorePrivate::blitVisibleContents(bool force)


Modified: trunk/Source/WebKit/blackberry/Api/BackingStore_p.h (102997 => 102998)

--- trunk/Source/WebKit/blackberry/Api/BackingStore_p.h	2011-12-16 00:37:08 UTC (rev 102997)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore_p.h	2011-12-16 00:41:00 UTC (rev 102998)
@@ -110,6 +110,8 @@
 // the minimum number of tiles required to scroll.
 bool shouldDirectRenderingToWindow() const;
 
+bool isSuspended() const { return m_suspendBackingStoreUpdates; }
+
 // Suspends all screen updates so that 'blitContents' is disabled.
 void suspendScreenAndBackingStoreUpdates();
 
@@ -180,8 +182,8 @@
 void requestLayoutIfNeeded() const;
 
 // Helper render methods.
-void renderVisibleContents();
-void renderBackingStore();
+bool renderVisibleContents();
+bool renderBa

[webkit-changes] [102997] trunk/LayoutTests

[commit-queue]

Title: [102997] trunk/LayoutTests








Revision 102997
Author commit-qu...@webkit.org
Date 2011-12-15 16:37:08 -0800 (Thu, 15 Dec 2011)


Log Message
Create reftest for render-region-renderer
https://bugs.webkit.org/show_bug.cgi?id=74518

Patch by Larry McLister  on 2011-12-15
Reviewed by Tony Chang.

* fast/regions/render-region-renderer-expected.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/fast/regions/render-region-renderer-expected.png: Removed.
* platform/efl/fast/regions/render-region-renderer-expected.txt: Removed.
* platform/mac/fast/regions/render-region-renderer-expected.png: Removed.
* platform/mac/fast/regions/render-region-renderer-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/fast/regions/render-region-renderer-expected.html


Removed Paths

trunk/LayoutTests/platform/efl/fast/regions/render-region-renderer-expected.png
trunk/LayoutTests/platform/efl/fast/regions/render-region-renderer-expected.txt
trunk/LayoutTests/platform/mac/fast/regions/render-region-renderer-expected.png
trunk/LayoutTests/platform/mac/fast/regions/render-region-renderer-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102996 => 102997)

--- trunk/LayoutTests/ChangeLog	2011-12-16 00:32:27 UTC (rev 102996)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 00:37:08 UTC (rev 102997)
@@ -1,3 +1,17 @@
+2011-12-15  Larry McLister  
+
+Create reftest for render-region-renderer
+https://bugs.webkit.org/show_bug.cgi?id=74518
+
+Reviewed by Tony Chang.
+
+* fast/regions/render-region-renderer-expected.html: Added.
+* platform/chromium/test_expectations.txt:
+* platform/efl/fast/regions/render-region-renderer-expected.png: Removed.
+* platform/efl/fast/regions/render-region-renderer-expected.txt: Removed.
+* platform/mac/fast/regions/render-region-renderer-expected.png: Removed.
+* platform/mac/fast/regions/render-region-renderer-expected.txt: Removed.
+
 2011-12-15  Kenichi Ishibashi  
 
 Unreviewed Chromium test expectations update.


Added: trunk/LayoutTests/fast/regions/render-region-renderer-expected.html (0 => 102997)

--- trunk/LayoutTests/fast/regions/render-region-renderer-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/render-region-renderer-expected.html	2011-12-16 00:37:08 UTC (rev 102997)
@@ -0,0 +1,59 @@
+
+
+
+
+.border
+{
+border: 1px solid red;
+}
+
+.size
+{
+width:50px;
+height:51px;
+}
+.size1
+{
+width:0.5px;
+height:0.5px;
+}
+
+.size2
+{
+width:50px;
+height:50px;
+}
+
+.pos
+{
+top: 61px;
+position: absolute;
+}
+
+.pos1
+{
+top: 150px;
+position: absolute;
+}
+
+.pos2
+{
+top: 200px;
+position: absolute;
+}
+
+.outline
+{
+outline: green dotted thick;
+}
+
+
+
+
+
+
+
+
+
+
+


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102996 => 102997)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-16 00:32:27 UTC (rev 102996)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-16 00:37:08 UTC (rev 102997)
@@ -3355,7 +3355,6 @@
 BUGWK74137 : fast/regions/region-style-image-background-color.html = PASS FAIL MISSING
 BUGWK74137 : fast/regions/region-style-inline-background-color.html = PASS FAIL MISSING
 BUGWK74137 : fast/regions/render-region-custom-style-mark.html = PASS FAIL MISSING
-BUGWK74137 : fast/regions/render-region-renderer.html = PASS FAIL MISSING
 BUGWK74137 : fast/regions/text-region-split-small-pagination.html = PASS FAIL MISSING
 BUGWK74137 : fast/regions/top-overflow-out-of-second-region.html = PASS FAIL MISSING
 BUGWK74137 : fast/regions/webkit-flow-double-pagination-float-push.html = PASS FAIL MISSING


Deleted: trunk/LayoutTests/platform/efl/fast/regions/render-region-renderer-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/efl/fast/regions/render-region-renderer-expected.txt (102996 => 102997)

--- trunk/LayoutTests/platform/efl/fast/regions/render-region-renderer-expected.txt	2011-12-16 00:32:27 UTC (rev 102996)
+++ trunk/LayoutTests/platform/efl/fast/regions/render-region-renderer-expected.txt	2011-12-16 00:37:08 UTC (rev 102997)
@@ -1,24 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x170
-  RenderBlock {HTML} at (0,0) size 800x170
-RenderBody {BODY} at (8,8) size 784x154
-  RenderRegion {DIV} at (0,0) size 2x2 [border: (1px solid #FF)]
-  RenderRegion {DIV} at (0,2) size 52x52 [border: (1px solid #FF)]
-  RenderBlock {DIV} at (0,54) size 100x100
-RenderRegion {DIV} at (0,0) size 52x52 [border: (1px solid #FF)]
-layer at (8,150) size 52

[webkit-changes] [102996] trunk/Tools

[commit-queue]

Title: [102996] trunk/Tools








Revision 102996
Author commit-qu...@webkit.org
Date 2011-12-15 16:32:27 -0800 (Thu, 15 Dec 2011)


Log Message
[qt][wk2] MiniBrowser: Add pressed state for viewport info button.
https://bugs.webkit.org/show_bug.cgi?id=74617

Patch by Michael Bruning  on 2011-12-15
Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
for viewport info button, adjusted height and added rounded corners.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml




Diff

Modified: trunk/Tools/ChangeLog (102995 => 102996)

--- trunk/Tools/ChangeLog	2011-12-16 00:25:09 UTC (rev 102995)
+++ trunk/Tools/ChangeLog	2011-12-16 00:32:27 UTC (rev 102996)
@@ -1,3 +1,13 @@
+2011-12-15  Michael Bruning  
+
+[qt][wk2] MiniBrowser: Add pressed state for viewport info button.
+https://bugs.webkit.org/show_bug.cgi?id=74617
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
+for viewport info button, adjusted height and added rounded corners.
+
 2011-12-15  Andy Estes  
 
 TestFailures: store the name of the buildbot results directory in a property


Modified: trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml (102995 => 102996)

--- trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml	2011-12-16 00:25:09 UTC (rev 102995)
+++ trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml	2011-12-16 00:32:27 UTC (rev 102996)
@@ -163,9 +163,10 @@
 
 Rectangle {
 id: viewportInfoButton
-height: navigationBar.height - 2
+height: parent.height
 width: height
-color: "#efefef"
+color: { viewportInfoItem.visible ? "#cfcfcf" : "#efefef" }
+radius: 6
 
 Image {
 anchors.centerIn: parent






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102995] trunk/LayoutTests

[bashi]

Title: [102995] trunk/LayoutTests








Revision 102995
Author ba...@chromium.org
Date 2011-12-15 16:25:09 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed Chromium test expectations update.
Rebaseline fast/text/unicode-variation-selector.html.

* platform/chromium-cg-mac-leopard/fast/text/unicode-variation-selector-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/text/unicode-variation-selector-expected.png: Added.
* platform/chromium-linux/fast/text/unicode-variation-selector-expected.png: Added.
* platform/chromium-linux/fast/text/unicode-variation-selector-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/unicode-variation-selector-expected.png: Added.
* platform/chromium-win/fast/text/unicode-variation-selector-expected.png: Added.
* platform/chromium-win/fast/text/unicode-variation-selector-expected.txt: Added.
* platform/chromium/fast/text/unicode-variation-selector-expected.txt: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium/fast/text/unicode-variation-selector-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/text/unicode-variation-selector-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/text/
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/text/unicode-variation-selector-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/text/unicode-variation-selector-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/text/unicode-variation-selector-expected.txt
trunk/LayoutTests/platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/unicode-variation-selector-expected.png
trunk/LayoutTests/platform/chromium-win/fast/text/unicode-variation-selector-expected.png
trunk/LayoutTests/platform/chromium-win/fast/text/unicode-variation-selector-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102994 => 102995)

--- trunk/LayoutTests/ChangeLog	2011-12-16 00:18:35 UTC (rev 102994)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 00:25:09 UTC (rev 102995)
@@ -1,3 +1,19 @@
+2011-12-15  Kenichi Ishibashi  
+
+Unreviewed Chromium test expectations update.
+Rebaseline fast/text/unicode-variation-selector.html.
+
+* platform/chromium-cg-mac-leopard/fast/text/unicode-variation-selector-expected.png: Added.
+* platform/chromium-cg-mac-snowleopard/fast/text/unicode-variation-selector-expected.png: Added.
+* platform/chromium-linux/fast/text/unicode-variation-selector-expected.png: Added.
+* platform/chromium-linux/fast/text/unicode-variation-selector-expected.txt: Added.
+* platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.png: Added.
+* platform/chromium-mac-snowleopard/fast/text/unicode-variation-selector-expected.png: Added.
+* platform/chromium-win/fast/text/unicode-variation-selector-expected.png: Added.
+* platform/chromium-win/fast/text/unicode-variation-selector-expected.txt: Added.
+* platform/chromium/fast/text/unicode-variation-selector-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-12-15  Kenneth Russell  
 
 Unreviewed Chromium test expectations update; pull up some


Added: trunk/LayoutTests/platform/chromium/fast/text/unicode-variation-selector-expected.txt (0 => 102995)

--- trunk/LayoutTests/platform/chromium/fast/text/unicode-variation-selector-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/text/unicode-variation-selector-expected.txt	2011-12-16 00:25:09 UTC (rev 102995)
@@ -0,0 +1,26 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+  RenderBlock {P} at (0,0) size 784x54
+RenderText {#text} at (0,0) size 775x54
+  text run at (0,0) width 496: "This page ensures that WebKit can render unicode variation selector correctly. "
+  text run at (496,0) width 254: "On platforms which support UVSes, the"
+  text run at (0,18) width 676: "glyphs of U+845B should be different. On platforms which don't support UVSes, they should be identical. "
+  text run at (676,18) width 99: "In addition, any"
+  text run at (0,36) width 579: "glyphs (including the last resort glyph) should not appear after the U+845B on all platforms."
+  RenderBlock {DIV} at (0,70) size 784x18
+RenderText {#text} at (0,0) size 289x18
+  text run at (0,0) width 289: "Glyph for code point U+845B without UVS: "
+RenderInline {SPAN} at (0,0) size 16x15
+  RenderText {#text} at (289,0) size 16x15
+ 

[webkit-changes] [102994] trunk/Tools

[aestes]

Title: [102994] trunk/Tools








Revision 102994
Author aes...@apple.com
Date 2011-12-15 16:18:35 -0800 (Thu, 15 Dec 2011)


Log Message
TestFailures: store the name of the buildbot results directory in a property
https://bugs.webkit.org/show_bug.cgi?id=74663

Reviewed by Adam Barth.

Store the name of the results directory as a property on Buildbot's
prototype. This allows subclasses of Buildbot to customize the results
directory.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
(Buildbot.prototype.resultsDirectoryURL):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js (102993 => 102994)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js	2011-12-16 00:02:59 UTC (rev 102993)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js	2011-12-16 00:18:35 UTC (rev 102994)
@@ -30,6 +30,7 @@
 
 Buildbot.prototype = {
 _builders: {},
+_resultsDirectory: 'results/',
 
 buildURL: function(builderName, buildName) {
 return this.baseURL + 'builders/' + builderName + '/builds/' + buildName;
@@ -49,7 +50,7 @@
 }
 
 var self = this;
-getResource(this.baseURL + 'results/', function(xhr) {
+getResource(this.baseURL + this._resultsDirectory, function(xhr) {
 var root = document.createElement('html');
 root.innerHTML = xhr.responseText;
 var names = Array.prototype.map.call(root.querySelectorAll('td:first-child > a > b'), function(elem) {
@@ -69,7 +70,7 @@
 },
 
 resultsDirectoryURL: function(builderName, buildName) {
-return this.baseURL + 'results/' + encodeURIComponent(builderName) + '/' + encodeURIComponent(buildName) + '/';
+return this.baseURL + this._resultsDirectory + encodeURIComponent(builderName) + '/' + encodeURIComponent(buildName) + '/';
 },
 
 _buildersForNames: function(names) {


Modified: trunk/Tools/ChangeLog (102993 => 102994)

--- trunk/Tools/ChangeLog	2011-12-16 00:02:59 UTC (rev 102993)
+++ trunk/Tools/ChangeLog	2011-12-16 00:18:35 UTC (rev 102994)
@@ -1,3 +1,17 @@
+2011-12-15  Andy Estes  
+
+TestFailures: store the name of the buildbot results directory in a property
+https://bugs.webkit.org/show_bug.cgi?id=74663
+
+Reviewed by Adam Barth.
+
+Store the name of the results directory as a property on Buildbot's
+prototype. This allows subclasses of Buildbot to customize the results
+directory.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
+(Buildbot.prototype.resultsDirectoryURL):
+
 2011-12-15  Tony Chang  
 
 [chromium] pass --delete_unversioned_trees to gclient on the bots






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102993] trunk

[kubo]

Title: [102993] trunk








Revision 102993
Author k...@profusion.mobi
Date 2011-12-15 16:02:59 -0800 (Thu, 15 Dec 2011)


Log Message
[CMake] Remove ENABLE_DATAGRID from the buildsystem.
https://bugs.webkit.org/show_bug.cgi?id=74640

Reviewed by Antonio Gomes.

r84991 removed Datagrid from the tree, but the options in CMake were
kept.

* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmakeconfig.h.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsBlackBerry.cmake
trunk/Source/cmake/OptionsEfl.cmake
trunk/Source/cmake/OptionsWinCE.cmake
trunk/Source/cmakeconfig.h.cmake




Diff

Modified: trunk/ChangeLog (102992 => 102993)

--- trunk/ChangeLog	2011-12-15 23:50:17 UTC (rev 102992)
+++ trunk/ChangeLog	2011-12-16 00:02:59 UTC (rev 102993)
@@ -1,3 +1,18 @@
+2011-12-15  Raphael Kubo da Costa  
+
+[CMake] Remove ENABLE_DATAGRID from the buildsystem.
+https://bugs.webkit.org/show_bug.cgi?id=74640
+
+Reviewed by Antonio Gomes.
+
+r84991 removed Datagrid from the tree, but the options in CMake were
+kept.
+
+* Source/cmake/OptionsBlackBerry.cmake:
+* Source/cmake/OptionsEfl.cmake:
+* Source/cmake/OptionsWinCE.cmake:
+* Source/cmakeconfig.h.cmake:
+
 2011-12-15  Ulan Degenbaev  
 
 Web Inspector: [Chromium]  Call LowMemoryNotification instead of IdleNotification


Modified: trunk/Source/cmake/OptionsBlackBerry.cmake (102992 => 102993)

--- trunk/Source/cmake/OptionsBlackBerry.cmake	2011-12-15 23:50:17 UTC (rev 102992)
+++ trunk/Source/cmake/OptionsBlackBerry.cmake	2011-12-16 00:02:59 UTC (rev 102993)
@@ -135,7 +135,6 @@
 WEBKIT_FEATURE(ENABLE_CHANNEL_MESSAGING "Enable channel messaging" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_CLIENT_BASED_GEOLOCATION "Client based Geolocation" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_DATABASE "Enable database" DEFAULT ON)
-WEBKIT_FEATURE(ENABLE_DATAGRID "Enable datagrid" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_DATALIST "Enable datalist" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_DETAILS "Enable details element" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_DEVICE_ORIENTATION "Enable Device Orientation" DEFAULT ON)


Modified: trunk/Source/cmake/OptionsEfl.cmake (102992 => 102993)

--- trunk/Source/cmake/OptionsEfl.cmake	2011-12-15 23:50:17 UTC (rev 102992)
+++ trunk/Source/cmake/OptionsEfl.cmake	2011-12-16 00:02:59 UTC (rev 102993)
@@ -62,7 +62,6 @@
 WEBKIT_FEATURE(ENABLE_BLOB "Enable blob slice" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_CHANNEL_MESSAGING "Enable channel messaging" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_CLIENT_BASED_GEOLOCATION "Enable client based geolocation" DEFAULT OFF)
-WEBKIT_FEATURE(ENABLE_DATAGRID "Enable datagrid" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_DATALIST "Enable datalist" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_DATA_TRANSFER_ITEMS "Enable data transfer items" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_DEVICE_ORIENTATION "Enable device orientation" DEFAULT OFF)


Modified: trunk/Source/cmake/OptionsWinCE.cmake (102992 => 102993)

--- trunk/Source/cmake/OptionsWinCE.cmake	2011-12-15 23:50:17 UTC (rev 102992)
+++ trunk/Source/cmake/OptionsWinCE.cmake	2011-12-16 00:02:59 UTC (rev 102993)
@@ -22,7 +22,6 @@
 WEBKIT_FEATURE(ENABLE_BLOB "Enable blob slice" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_CHANNEL_MESSAGING "Enable channel messaging" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_CLIENT_BASED_GEOLOCATION "Enable client based geolocation" DEFAULT OFF)
-WEBKIT_FEATURE(ENABLE_DATAGRID "Enable datagrid" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_DATALIST "Enable datalist" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_DATA_TRANSFER_ITEMS "Enable data transfer items" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_FAST_MOBILE_SCROLLING "Enable fast mobile scrolling" DEFAULT ON)


Modified: trunk/Source/cmakeconfig.h.cmake (102992 => 102993)

--- trunk/Source/cmakeconfig.h.cmake	2011-12-15 23:50:17 UTC (rev 102992)
+++ trunk/Source/cmakeconfig.h.cmake	2011-12-16 00:02:59 UTC (rev 102993)
@@ -9,7 +9,6 @@
 #cmakedefine01 ENABLE_BLOB
 #cmakedefine01 ENABLE_CHANNEL_MESSAGING
 #cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION
-#cmakedefine01 ENABLE_DATAGRID
 #cmakedefine01 ENABLE_DATALIST
 #cmakedefine01 ENABLE_DATA_TRANSFER_ITEMS
 #cmakedefine01 ENABLE_DEVICE_ORIENTATION






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102992] trunk/Source/WebCore

[rniwa]

Title: [102992] trunk/Source/WebCore








Revision 102992
Author rn...@webkit.org
Date 2011-12-15 15:50:17 -0800 (Thu, 15 Dec 2011)


Log Message
Touch make_name.pl in an attempt to make Qt bots happy.

* dom/make_names.pl:
(printNamesHeaderFile):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/make_names.pl




Diff

Modified: trunk/Source/WebCore/ChangeLog (102991 => 102992)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 23:48:19 UTC (rev 102991)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 23:50:17 UTC (rev 102992)
@@ -1,3 +1,10 @@
+2011-12-15  Ryosuke Niwa  
+
+Touch make_name.pl in an attempt to make Qt bots happy.
+
+* dom/make_names.pl:
+(printNamesHeaderFile):
+
 2011-12-15  Kentaro Hara  
 
 Unreviewed. Rebaselined run-bindings-tests results.


Modified: trunk/Source/WebCore/dom/make_names.pl (102991 => 102992)

--- trunk/Source/WebCore/dom/make_names.pl	2011-12-15 23:48:19 UTC (rev 102991)
+++ trunk/Source/WebCore/dom/make_names.pl	2011-12-15 23:50:17 UTC (rev 102992)
@@ -576,7 +576,7 @@
 print F "// Tags\n";
 printMacros($F, "extern const WebCore::QualifiedName", "Tag", \%allTags);
 }
-
+
 if (keys %allAttrs) {
 print F "// Attributes\n";
 printMacros($F, "extern const WebCore::QualifiedName", "Attr", \%allAttrs);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102991] trunk/Source/WebCore

[haraken]

Title: [102991] trunk/Source/WebCore








Revision 102991
Author hara...@chromium.org
Date 2011-12-15 15:48:19 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed. Rebaselined run-bindings-tests results.

* bindings/scripts/test/JS/JSFloat64Array.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102990 => 102991)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 23:46:48 UTC (rev 102990)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 23:48:19 UTC (rev 102991)
@@ -1,3 +1,11 @@
+2011-12-15  Kentaro Hara  
+
+Unreviewed. Rebaselined run-bindings-tests results.
+
+* bindings/scripts/test/JS/JSFloat64Array.cpp:
+* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
+* bindings/scripts/test/JS/JSTestObj.cpp:
+
 2011-12-15  Luke Macpherson   
 
 Separate box alignment and box pack values into separate enums.


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp (102990 => 102991)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp	2011-12-15 23:46:48 UTC (rev 102990)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp	2011-12-15 23:48:19 UTC (rev 102991)
@@ -88,7 +88,7 @@
 
 static const HashTableValue JSFloat64ArrayPrototypeTableValues[] =
 {
-{ "foo", DontDelete | Function, (intptr_t)static_cast(jsFloat64ArrayPrototypeFunctionFoo), (intptr_t)1, NoIntrinsic },
+{ "foo", DontDelete | JSC::Function, (intptr_t)static_cast(jsFloat64ArrayPrototypeFunctionFoo), (intptr_t)1, NoIntrinsic },
 { 0, 0, 0, 0, NoIntrinsic }
 };
 


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp (102990 => 102991)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp	2011-12-15 23:46:48 UTC (rev 102990)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp	2011-12-15 23:48:19 UTC (rev 102991)
@@ -79,7 +79,7 @@
 
 static const HashTableValue JSTestMediaQueryListListenerPrototypeTableValues[] =
 {
-{ "method", DontDelete | Function, (intptr_t)static_cast(jsTestMediaQueryListListenerPrototypeFunctionMethod), (intptr_t)1, NoIntrinsic },
+{ "method", DontDelete | JSC::Function, (intptr_t)static_cast(jsTestMediaQueryListListenerPrototypeFunctionMethod), (intptr_t)1, NoIntrinsic },
 { 0, 0, 0, 0, NoIntrinsic }
 };
 


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (102990 => 102991)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2011-12-15 23:46:48 UTC (rev 102990)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2011-12-15 23:48:19 UTC (rev 102991)
@@ -141,10 +141,10 @@
 { "CONST_VALUE_13", DontDelete | ReadOnly, (intptr_t)static_cast(jsTestObjCONST_VALUE_13), (intptr_t)0, NoIntrinsic },
 { "CONST_VALUE_14", DontDelete | ReadOnly, (intptr_t)static_cast(jsTestObjCONST_VALUE_14), (intptr_t)0, NoIntrinsic },
 { "CONST_JAVASCRIPT", DontDelete | ReadOnly, (intptr_t)static_cast(jsTestObjCONST_JAVASCRIPT), (intptr_t)0, NoIntrinsic },
-{ "classMethod", DontDelete | Function, (intptr_t)static_cast(jsTestObjConstructorFunctionClassMethod), (intptr_t)0, NoIntrinsic },
-{ "classMethodWithOptional", DontDelete | Function, (intptr_t)static_cast(jsTestObjConstructorFunctionClassMethodWithOptional), (intptr_t)1, NoIntrinsic },
+{ "classMethod", DontDelete | JSC::Function, (intptr_t)static_cast(jsTestObjConstructorFunctionClassMethod), (intptr_t)0, NoIntrinsic },
+{ "classMethodWithOptional", DontDelete | JSC::Function, (intptr_t)static_cast(jsTestObjConstructorFunctionClassMethodWithOptional), (intptr_t)1, NoIntrinsic },
 #if ENABLE(Condition1)
-{ "overloadedMethod1", DontDelete | Function, (intptr_t)static_cast(jsTestObjConstructorFunctionOverloadedMethod1), (intptr_t)1, NoIntrinsic },
+{ "overloadedMethod1", DontDelete | JSC::Function, (intptr_t)static_cast(jsTestObjConstructorFunctionOverloadedMethod1), (intptr_t)1, NoIntrinsic },
 #endif
 { 0, 0, 0, 0, NoIntrinsic }
 };
@@ -223,48 +223,48 @@
 { "CONST_VALUE_13", DontDelete | ReadOnly, (intptr_t)static_cast(jsTestObjCONST_VALUE_13), (intptr_t)0, NoIntrinsic },
 { "CONST_VALUE_14", DontDelete | ReadOnly, (intptr_t)static_cast(jsTestObjCONST_VALUE_14), (intptr_t)0, NoIntrinsic },
 { "CONST_JAVASCRIPT", DontDelete | ReadOnly, (intptr_t)static_cast(jsTestObjCONST_JAVASCRIPT), (intptr_t)0, NoIntrinsic },
-{ "voidMethod", DontDelete | Function, (intptr_t)static_cast(jsTestObjPrototypeFunctionVoidMethod), (intptr_t)0, NoIntrinsic },
-{ "voidMethodWithArgs", DontDelete | Function, (intptr_t)static_cast(jsTestObjPrototypeFunctio

[webkit-changes] [102990] trunk/Tools

[tony]

Title: [102990] trunk/Tools








Revision 102990
Author t...@chromium.org
Date 2011-12-15 15:46:48 -0800 (Thu, 15 Dec 2011)


Log Message
[chromium] pass --delete_unversioned_trees to gclient on the bots
https://bugs.webkit.org/show_bug.cgi?id=74565

Reviewed by Kenneth Russell.

It was temporarily removed in r102891 to keep the bots green.  Now
that the bots have cycled, we can add it back.

* Scripts/update-webkit-chromium:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/update-webkit-chromium




Diff

Modified: trunk/Tools/ChangeLog (102989 => 102990)

--- trunk/Tools/ChangeLog	2011-12-15 23:44:20 UTC (rev 102989)
+++ trunk/Tools/ChangeLog	2011-12-15 23:46:48 UTC (rev 102990)
@@ -1,3 +1,15 @@
+2011-12-15  Tony Chang  
+
+[chromium] pass --delete_unversioned_trees to gclient on the bots
+https://bugs.webkit.org/show_bug.cgi?id=74565
+
+Reviewed by Kenneth Russell.
+
+It was temporarily removed in r102891 to keep the bots green.  Now
+that the bots have cycled, we can add it back.
+
+* Scripts/update-webkit-chromium:
+
 2011-12-15  Kentaro Hara  
 
 [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing


Modified: trunk/Tools/Scripts/update-webkit-chromium (102989 => 102990)

--- trunk/Tools/Scripts/update-webkit-chromium	2011-12-15 23:44:20 UTC (rev 102989)
+++ trunk/Tools/Scripts/update-webkit-chromium	2011-12-15 23:46:48 UTC (rev 102990)
@@ -86,9 +86,7 @@
 push @gclientArgs, "--force" if $force;
 # --reset could delete modified files if necessary to sync.
 push @gclientArgs, "--reset" if $force;
-# Temporarily keep unversioned trees so we don't delete third_party/libwebp.
-# See https://bugs.webkit.org/show_bug.cgi?id=74565 .
-#push @gclientArgs, "--delete_unversioned_trees" if $force;
+push @gclientArgs, "--delete_unversioned_trees" if $force;
 push @gclientArgs, "--deps=unix,android" if isChromiumAndroid();
 
 my $cmd = join(" ",@gclientArgs);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102989] trunk/Source/WebCore

[macpherson]

Title: [102989] trunk/Source/WebCore








Revision 102989
Author macpher...@chromium.org
Date 2011-12-15 15:44:20 -0800 (Thu, 15 Dec 2011)


Log Message
Separate box alignment and box pack values into separate enums.
https://bugs.webkit.org/show_bug.cgi?id=74580

Reviewed by Darin Adler.

No new tests / refactoring only.

Separating these types cleans up the code by removing several assertions that
values are in the correct ranges, as this is ensured by the type system.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBoxPack):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
* rendering/RenderFullScreen.cpp:
(createFullScreenStyle):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::boxPack):
(WebCore::InheritedFlags::setBoxAlign):
(WebCore::InheritedFlags::setBoxPack):
(WebCore::InheritedFlags::initialBoxPack):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleDeprecatedFlexibleBoxData.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFullScreen.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102988 => 102989)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 23:13:40 UTC (rev 102988)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 23:44:20 UTC (rev 102989)
@@ -1,3 +1,36 @@
+2011-12-15  Luke Macpherson   
+
+Separate box alignment and box pack values into separate enums.
+https://bugs.webkit.org/show_bug.cgi?id=74580
+
+Reviewed by Darin Adler.
+
+No new tests / refactoring only.
+
+Separating these types cleans up the code by removing several assertions that
+values are in the correct ranges, as this is ensured by the type system.
+
+* css/CSSComputedStyleDeclaration.cpp:
+(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+(WebCore::CSSPrimitiveValue::operator EBoxPack):
+(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+* rendering/RenderDeprecatedFlexibleBox.cpp:
+(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
+(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
+* rendering/RenderFullScreen.cpp:
+(createFullScreenStyle):
+* rendering/style/RenderStyle.h:
+(WebCore::InheritedFlags::boxPack):
+(WebCore::InheritedFlags::setBoxAlign):
+(WebCore::InheritedFlags::setBoxPack):
+(WebCore::InheritedFlags::initialBoxPack):
+* rendering/style/RenderStyleConstants.h:
+* rendering/style/StyleDeprecatedFlexibleBoxData.h:
+
 2011-12-15  Kentaro Hara  
 
 REGRESSION(r102663): generate-bindings.pl runs every time


Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (102988 => 102989)

--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2011-12-15 23:13:40 UTC (rev 102988)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2011-12-15 23:44:20 UTC (rev 102989)
@@ -1401,14 +1401,8 @@
 return cssValuePool->createValue(style->boxOrdinalGroup(), CSSPrimitiveValue::CSS_NUMBER);
 case CSSPropertyWebkitBoxOrient:
 return cssValuePool->createValue(style->boxOrient());
-case CSSPropertyWebkitBoxPack: {
-EBoxAlignment boxPack = style->boxPack();
-ASSERT(boxPack != BSTRETCH);
-ASSERT(boxPack != BBASELINE);
-if (boxPack == BJUSTIFY || boxPack== BBASELINE)
-return 0;
-return cssValuePool->createValue(boxPack);
-}
+case CSSPropertyWebkitBoxPack:
+return cssValuePool->createValue(style->boxPack());
 case CSSPropertyWebkitBoxReflect:
 return valueForReflection(style->boxReflect(), style.get(), cssValuePool);
 case CSSPropertyBoxShadow:


Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (102988 => 102989)

--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2011-12-15 23:13:40 UTC (rev 102988)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMap

[webkit-changes] [102988] trunk/Tools

[haraken]

Title: [102988] trunk/Tools








Revision 102988
Author hara...@chromium.org
Date 2011-12-15 15:13:40 -0800 (Thu, 15 Dec 2011)


Log Message
[Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
https://bugs.webkit.org/show_bug.cgi?id=74497

Reviewed by Ryosuke Niwa.

We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
manner. This bug is one of the incremental refactorings to remove all top-level
code and global variables from prepare-ChangeLog. In this patch,
we make the following global variables be used only through parameter passing.
- $bugDescription
- $bugNumber
- $name
- $emailAddress
- $gitReviewer
- $writeChangeLogs

* Scripts/prepare-ChangeLog:
(fetchBugDescriptionFromURL):
(generateNewChangeLogs):
(reviewerAndDescriptionForGitCommit):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/prepare-ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (102987 => 102988)

--- trunk/Tools/ChangeLog	2011-12-15 23:10:33 UTC (rev 102987)
+++ trunk/Tools/ChangeLog	2011-12-15 23:13:40 UTC (rev 102988)
@@ -1,3 +1,26 @@
+2011-12-15  Kentaro Hara  
+
+[Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
+https://bugs.webkit.org/show_bug.cgi?id=74497
+
+Reviewed by Ryosuke Niwa.
+
+We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
+manner. This bug is one of the incremental refactorings to remove all top-level
+code and global variables from prepare-ChangeLog. In this patch,
+we make the following global variables be used only through parameter passing.
+- $bugDescription
+- $bugNumber
+- $name
+- $emailAddress
+- $gitReviewer
+- $writeChangeLogs
+
+* Scripts/prepare-ChangeLog:
+(fetchBugDescriptionFromURL):
+(generateNewChangeLogs):
+(reviewerAndDescriptionForGitCommit):
+
 2011-12-15  Raphael Kubo da Costa  
 
 [EFL] Add a few more web database functions to ewk_settings.


Modified: trunk/Tools/Scripts/prepare-ChangeLog (102987 => 102988)

--- trunk/Tools/Scripts/prepare-ChangeLog	2011-12-15 23:10:33 UTC (rev 102987)
+++ trunk/Tools/Scripts/prepare-ChangeLog	2011-12-15 23:13:40 UTC (rev 102988)
@@ -67,11 +67,11 @@
 sub changeLogDate($);
 sub changeLogEmailAddressFromArgs($);
 sub changeLogNameFromArgs($);
-sub fetchBugDescriptionFromURL($);
+sub fetchBugDescriptionFromURL($$);
 sub findChangeLogs($);
 sub getLatestChangeLogs($);
 sub resolveConflictedChangeLogs($);
-sub generateNewChangeLogs($);
+sub generateNewChangeLogs($$);
 sub printDiff($);
 sub openChangeLogs($);
 sub diffFromToString();
@@ -100,7 +100,7 @@
 sub get_selector_line_ranges_for_css($$);
 sub method_decl_to_selector($);
 sub processPaths(\@);
-sub reviewerAndDescriptionForGitCommit($);
+sub reviewerAndDescriptionForGitCommit($$);
 sub normalizeLineEndings($$);
 sub decodeEntities($);
 
@@ -201,7 +201,7 @@
 }
 
 if ($bugNumber && !$bugDescription) {
-$bugDescription = fetchBugDescriptionFromURL($bugURL);
+$bugDescription = fetchBugDescriptionFromURL($bugURL, $bugNumber);
 }
 
 my ($filesInChangeLog, $prefixes) = findChangeLogs($functionLists);
@@ -213,7 +213,7 @@
 resolveConflictedChangeLogs($changeLogs);
 }
 
-generateNewChangeLogs($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL);
+generateNewChangeLogs($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $bugDescription, $name, $emailAddress, $gitReviewer, $writeChangeLogs);
 
 if ($writeChangeLogs) {
 print STDERR "-- Please remember to include a detailed description in your ChangeLog entry. --\n-- See  for more info --\n";
@@ -336,9 +336,9 @@
 return $emailAddressFromArgs || changeLogEmailAddress();
 }
 
-sub fetchBugDescriptionFromURL($)
+sub fetchBugDescriptionFromURL($$)
 {
-my ($bugURL) = @_;
+my ($bugURL, $bugNumber) = @_;
 
 my $bugXMLURL = "$bugURL&ctype=xml";
 # Perl has no built in XML processing, so we'll fetch and parse with curl and grep
@@ -452,9 +452,9 @@
 close RESOLVE;
 }
 
-sub generateNewChangeLogs($)
+sub generateNewChangeLogs($$)
 {
-my ($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL) = @_;
+my ($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $bugDescription, $name, $emailAddress, $gitReviewer, $writeChangeLogs) = @_;
 
 # Generate new ChangeLog entries and (optionally) write out new ChangeLog files.
 foreach my $prefix (@$prefixes) {
@@ -483,7 +483,7 @@
 my $date = changeLogDate($changeLogTimeZone);
 print CHANGE_LOG normalizeLineEndings("$date  $name  <$emailAddress>\n\n", $endl);
 
-my ($reviewer, $description) = reviewerAndDescriptionForGitCommit($gitCommit) if $gitCommit;
+my ($revie

[webkit-changes] [102987] trunk/Source/WebCore

[haraken]

Title: [102987] trunk/Source/WebCore








Revision 102987
Author hara...@chromium.org
Date 2011-12-15 15:10:33 -0800 (Thu, 15 Dec 2011)


Log Message
REGRESSION(r102663): generate-bindings.pl runs every time
https://bugs.webkit.org/show_bug.cgi?id=74481

Reviewed by Adam Barth.

See the comment #1 of bug 74481 for the cause of this bug.

This patch fixes generate-bindings.pl so that it generates .h and .cpp files
even for IDL files that do not need .h and .cpp files. This is just to prevent
build scripts from trying to generate .h and .cpp files at every build.

No new tests. No change in behavior.

* bindings/scripts/generate-bindings.pl:
(generateEmptyHeaderAndCpp): Generates .h and .cpp files for IDL files
that do not need .h and .cpp files.
* bindings/scripts/test/CPP/CPPTestSupplemental.cpp: Added.
* bindings/scripts/test/CPP/CPPTestSupplemental.h: Added.
* bindings/scripts/test/GObject/GObjectTestSupplemental.cpp: Added.
* bindings/scripts/test/GObject/GObjectTestSupplemental.h: Added.
* bindings/scripts/test/JS/JSTestSupplemental.cpp: Added.
* bindings/scripts/test/JS/JSTestSupplemental.h: Added.
* bindings/scripts/test/ObjC/ObjCTestSupplemental.cpp: Added.
* bindings/scripts/test/ObjC/ObjCTestSupplemental.h: Added.
* bindings/scripts/test/V8/V8TestSupplemental.cpp: Added.
* bindings/scripts/test/V8/V8TestSupplemental.h: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/generate-bindings.pl


Added Paths

trunk/Source/WebCore/bindings/scripts/test/CPP/CPPTestSupplemental.cpp
trunk/Source/WebCore/bindings/scripts/test/CPP/CPPTestSupplemental.h
trunk/Source/WebCore/bindings/scripts/test/GObject/GObjectTestSupplemental.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/GObjectTestSupplemental.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSupplemental.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSupplemental.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/ObjCTestSupplemental.cpp
trunk/Source/WebCore/bindings/scripts/test/ObjC/ObjCTestSupplemental.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSupplemental.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSupplemental.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102986 => 102987)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 22:53:53 UTC (rev 102986)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 23:10:33 UTC (rev 102987)
@@ -1,3 +1,32 @@
+2011-12-15  Kentaro Hara  
+
+REGRESSION(r102663): generate-bindings.pl runs every time
+https://bugs.webkit.org/show_bug.cgi?id=74481
+
+Reviewed by Adam Barth.
+
+See the comment #1 of bug 74481 for the cause of this bug.
+
+This patch fixes generate-bindings.pl so that it generates .h and .cpp files
+even for IDL files that do not need .h and .cpp files. This is just to prevent
+build scripts from trying to generate .h and .cpp files at every build.
+
+No new tests. No change in behavior.
+
+* bindings/scripts/generate-bindings.pl:
+(generateEmptyHeaderAndCpp): Generates .h and .cpp files for IDL files
+that do not need .h and .cpp files.
+* bindings/scripts/test/CPP/CPPTestSupplemental.cpp: Added.
+* bindings/scripts/test/CPP/CPPTestSupplemental.h: Added.
+* bindings/scripts/test/GObject/GObjectTestSupplemental.cpp: Added.
+* bindings/scripts/test/GObject/GObjectTestSupplemental.h: Added.
+* bindings/scripts/test/JS/JSTestSupplemental.cpp: Added.
+* bindings/scripts/test/JS/JSTestSupplemental.h: Added.
+* bindings/scripts/test/ObjC/ObjCTestSupplemental.cpp: Added.
+* bindings/scripts/test/ObjC/ObjCTestSupplemental.h: Added.
+* bindings/scripts/test/V8/V8TestSupplemental.cpp: Added.
+* bindings/scripts/test/V8/V8TestSupplemental.h: Added.
+
 2011-12-15  Jarred Nicholls  
 
 Unreviewed build fix. Mac build broken when CSS Filters enabled.


Modified: trunk/Source/WebCore/bindings/scripts/generate-bindings.pl (102986 => 102987)

--- trunk/Source/WebCore/bindings/scripts/generate-bindings.pl	2011-12-15 22:53:53 UTC (rev 102986)
+++ trunk/Source/WebCore/bindings/scripts/generate-bindings.pl	2011-12-15 23:10:33 UTC (rev 102987)
@@ -118,9 +118,8 @@
 }
 
 if (!$idlFound) {
-if ($verbose) {
-print "$targetIdlFile is supplementing another IDL file, and thus .h and .cpp for $targetIdlFile are not generated.\n";
-}
+# We generate empty .h and .cpp files just to tell build scripts that .h and .cpp files are created.
+generateEmptyHeaderAndCpp($generator, $targetInterfaceName, $outputHeadersDirectory, $outputDirectory);
 exit 0;
 }
 }
@@ -238,3 +237,25 @@
 # Generate desired output for the target IDL file.
 my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, 0, $preprocessor, $writeDependencies, $verbose);
 $codeGen->ProcessDocument($targetDocument

[webkit-changes] [102986] tags/Safari-534.53.11/

[lforschler]

Title: [102986] tags/Safari-534.53.11/








Revision 102986
Author lforsch...@apple.com
Date 2011-12-15 14:53:53 -0800 (Thu, 15 Dec 2011)


Log Message
New tag.

Added Paths

tags/Safari-534.53.11/




Diff

Property changes: tags/Safari-534.53.11



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102985] trunk/LayoutTests

[kbr]

Title: [102985] trunk/LayoutTests








Revision 102985
Author k...@google.com
Date 2011-12-15 14:19:11 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed Chromium test expectations update; pull up some
downstream suppressions.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102984 => 102985)

--- trunk/LayoutTests/ChangeLog	2011-12-15 22:17:04 UTC (rev 102984)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 22:19:11 UTC (rev 102985)
@@ -1,3 +1,10 @@
+2011-12-15  Kenneth Russell  
+
+Unreviewed Chromium test expectations update; pull up some
+downstream suppressions.
+
+* platform/chromium/test_expectations.txt:
+
 2011-12-15  Adam Barth  
 
  parses incorrectly


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102984 => 102985)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-15 22:17:04 UTC (rev 102984)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-15 22:19:11 UTC (rev 102985)
@@ -4012,3 +4012,8 @@
 BUGWK50999 : fast/text/unicode-variation-selector.html = MISSING FAIL
 
 BUGWK74634 WIN : compositing/absolute-position-changed-with-composited-parent-layer.html = IMAGE
+
+BUGCR107668: fast/speech/input-appearance-numberandspeech.html = IMAGE
+BUGCR107668: fast/speech/input-appearance-searchandspeech.html = IMAGE
+BUGCR107668: fast/speech/input-appearance-speechbutton.html = IMAGE
+BUGCR107668: fast/speech/speech-bidi-rendering.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102983] trunk/Source/WebCore

[eric]

Title: [102983] trunk/Source/WebCore








Revision 102983
Author e...@webkit.org
Date 2011-12-15 14:00:09 -0800 (Thu, 15 Dec 2011)


Log Message
WebCore has two (disconnected) ways to keep track of updated widgets, should be unified
https://bugs.webkit.org/show_bug.cgi?id=74367

Reviewed by Adam Barth.

It seems the FrameView updateWidgets set is needed for now,
so just making FrameView::addWidgetToUpdate mark the DOM node
as needing a widget update and later when it goes to call
updateWidget() checking first if it needs an update.

No new tests, just adding an assert.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
* html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::needsWidgetUpdate):
(WebCore::HTMLPlugInImageElement::setNeedsWidgetUpdate):
* page/FrameView.cpp:
(WebCore::FrameView::addWidgetToUpdate):
(WebCore::FrameView::updateWidget):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLEmbedElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp
trunk/Source/WebCore/html/HTMLPlugInImageElement.h
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102982 => 102983)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 21:56:15 UTC (rev 102982)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 22:00:09 UTC (rev 102983)
@@ -1,3 +1,28 @@
+2011-12-15  Eric Seidel  
+
+WebCore has two (disconnected) ways to keep track of updated widgets, should be unified
+https://bugs.webkit.org/show_bug.cgi?id=74367
+
+Reviewed by Adam Barth.
+
+It seems the FrameView updateWidgets set is needed for now,
+so just making FrameView::addWidgetToUpdate mark the DOM node
+as needing a widget update and later when it goes to call
+updateWidget() checking first if it needs an update.
+
+No new tests, just adding an assert.
+
+* html/HTMLEmbedElement.cpp:
+(WebCore::HTMLEmbedElement::updateWidget):
+* html/HTMLObjectElement.cpp:
+(WebCore::HTMLObjectElement::updateWidget):
+* html/HTMLPlugInImageElement.h:
+(WebCore::HTMLPlugInImageElement::needsWidgetUpdate):
+(WebCore::HTMLPlugInImageElement::setNeedsWidgetUpdate):
+* page/FrameView.cpp:
+(WebCore::FrameView::addWidgetToUpdate):
+(WebCore::FrameView::updateWidget):
+
 2011-12-15  Alexandru Chiculita  
 
 Windows project file is broken. It has a missing  enclosing tag


Modified: trunk/Source/WebCore/html/HTMLEmbedElement.cpp (102982 => 102983)

--- trunk/Source/WebCore/html/HTMLEmbedElement.cpp	2011-12-15 21:56:15 UTC (rev 102982)
+++ trunk/Source/WebCore/html/HTMLEmbedElement.cpp	2011-12-15 22:00:09 UTC (rev 102983)
@@ -141,9 +141,7 @@
 void HTMLEmbedElement::updateWidget(PluginCreationOption pluginCreationOption)
 {
 ASSERT(!renderEmbeddedObject()->pluginCrashedOrWasMissing());
-// FIXME: We should ASSERT(needsWidgetUpdate()), but currently
-// FrameView::updateWidget() calls updateWidget(false) without checking if
-// the widget actually needs updating!
+ASSERT(needsWidgetUpdate());
 setNeedsWidgetUpdate(false);
 
 if (m_url.isEmpty() && m_serviceType.isEmpty())


Modified: trunk/Source/WebCore/html/HTMLObjectElement.cpp (102982 => 102983)

--- trunk/Source/WebCore/html/HTMLObjectElement.cpp	2011-12-15 21:56:15 UTC (rev 102982)
+++ trunk/Source/WebCore/html/HTMLObjectElement.cpp	2011-12-15 22:00:09 UTC (rev 102983)
@@ -290,9 +290,7 @@
 void HTMLObjectElement::updateWidget(PluginCreationOption pluginCreationOption)
 {
 ASSERT(!renderEmbeddedObject()->pluginCrashedOrWasMissing());
-// FIXME: We should ASSERT(needsWidgetUpdate()), but currently
-// FrameView::updateWidget() calls updateWidget(false) without checking if
-// the widget actually needs updating!
+ASSERT(needsWidgetUpdate());
 setNeedsWidgetUpdate(false);
 // FIXME: This should ASSERT isFinishedParsingChildren() instead.
 if (!isFinishedParsingChildren())


Modified: trunk/Source/WebCore/html/HTMLPlugInImageElement.h (102982 => 102983)

--- trunk/Source/WebCore/html/HTMLPlugInImageElement.h	2011-12-15 21:56:15 UTC (rev 102982)
+++ trunk/Source/WebCore/html/HTMLPlugInImageElement.h	2011-12-15 22:00:09 UTC (rev 102983)
@@ -54,6 +54,10 @@
 const String& url() const { return m_url; }
 bool shouldPreferPlugInsForImages() const { return m_shouldPreferPlugInsForImages; }
 
+// Public for FrameView::addWidgetToUpdate()
+bool needsWidgetUpdate() const { return m_needsWidgetUpdate; }
+void setNeedsWidgetUpdate(bool needsWidgetUpdate) { m_needsWidgetUpdate = needsWidgetUpdate; }
+
 protected:
 HTMLPlugInImageElement(const QualifiedName& tagName, Document*, bool createdByParser, PreferPlugInsForImagesOption);
 
@@ -67,9 +71,6 @@
 virtual void attach();
 virtual void detach();
 
-bool needsWidgetUpdate() const { 

[webkit-changes] [102982] trunk/Source/WebCore

[achicu]

Title: [102982] trunk/Source/WebCore








Revision 102982
Author ach...@adobe.com
Date 2011-12-15 13:56:15 -0800 (Thu, 15 Dec 2011)


Log Message
Windows project file is broken. It has a missing  enclosing tag
https://bugs.webkit.org/show_bug.cgi?id=74632

Reviewed by Anders Carlsson.

No new tests, just fixing the project file.

* WebCore.vcproj/WebCore.vcproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (102981 => 102982)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 21:35:23 UTC (rev 102981)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 21:56:15 UTC (rev 102982)
@@ -1,3 +1,14 @@
+2011-12-15  Alexandru Chiculita  
+
+Windows project file is broken. It has a missing  enclosing tag
+https://bugs.webkit.org/show_bug.cgi?id=74632
+
+Reviewed by Anders Carlsson.
+
+No new tests, just fixing the project file.
+
+* WebCore.vcproj/WebCore.vcproj:
+
 2011-12-15  Adam Barth  
 
  parses incorrectly


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (102981 => 102982)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-12-15 21:35:23 UTC (rev 102981)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-12-15 21:56:15 UTC (rev 102982)
@@ -42481,6 +42481,7 @@
  	RelativePath="..\rendering\style\FilterOperations.h"
 	>
+
  	RelativePath="..\rendering\style\CustomFilterOperation.h"
 	>






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102980] trunk/Source/WebKit/chromium

[nduca]

Title: [102980] trunk/Source/WebKit/chromium








Revision 102980
Author nd...@chromium.org
Date 2011-12-15 13:34:02 -0800 (Thu, 15 Dec 2011)


Log Message
[chromium] Add forUseOnAnotherThread to WebGraphicsContext3D::Attributes
https://bugs.webkit.org/show_bug.cgi?id=74557

Reviewed by Kenneth Russell.

* public/platform/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::Attributes::Attributes):
* src/GraphicsContext3DChromium.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h
trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102979 => 102980)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 21:30:21 UTC (rev 102979)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 21:34:02 UTC (rev 102980)
@@ -1,3 +1,14 @@
+2011-12-15  Nat Duca  
+
+[chromium] Add forUseOnAnotherThread to WebGraphicsContext3D::Attributes
+https://bugs.webkit.org/show_bug.cgi?id=74557
+
+Reviewed by Kenneth Russell.
+
+* public/platform/WebGraphicsContext3D.h:
+(WebKit::WebGraphicsContext3D::Attributes::Attributes):
+* src/GraphicsContext3DChromium.cpp:
+
 2011-12-15  Tommy Widenflycht  
 
 [chromium] MediaStream API: Fixing #include statements and removing forwarding header file


Modified: trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h (102979 => 102980)

--- trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h	2011-12-15 21:30:21 UTC (rev 102979)
+++ trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h	2011-12-15 21:34:02 UTC (rev 102980)
@@ -97,6 +97,7 @@
 , canRecoverFromContextLoss(true)
 , noExtensions(false)
 , shareResources(true)
+, forUseOnAnotherThread(false)
 {
 }
 
@@ -108,6 +109,7 @@
 bool canRecoverFromContextLoss;
 bool noExtensions;
 bool shareResources;
+bool forUseOnAnotherThread;
 };
 
 class WebGraphicsContextLostCallback {


Modified: trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp (102979 => 102980)

--- trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp	2011-12-15 21:30:21 UTC (rev 102979)
+++ trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp	2011-12-15 21:34:02 UTC (rev 102980)
@@ -150,6 +150,7 @@
 webAttributes.canRecoverFromContextLoss = attrs.canRecoverFromContextLoss;
 webAttributes.noExtensions = attrs.noExtensions;
 webAttributes.shareResources = attrs.shareResources;
+webAttributes.forUseOnAnotherThread = threadUsage == GraphicsContext3DPrivate::ForUseOnAnotherThread;
 OwnPtr webContext = adoptPtr(WebKit::webKitPlatformSupport()->createGraphicsContext3D());
 if (!webContext)
 return 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102979] trunk/Source/WebCore

[rniwa]

Title: [102979] trunk/Source/WebCore








Revision 102979
Author rn...@webkit.org
Date 2011-12-15 13:30:21 -0800 (Thu, 15 Dec 2011)


Log Message
m_hasCounterNodeMap and m_everHadLayout should be private to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=74645

Reviewed by Eric Seidel.

Made them private and added getters and setters as needed.

* rendering/RenderCounter.cpp:
(WebCore::makeCounterNode):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):
(showCounterRendererTree):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasCounterNodeMap):
(WebCore::RenderObject::setHasCounterNodeMap):
(WebCore::RenderObject::everHadLayout):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::layout):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::layout):
* rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::layout):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderCounter.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102978 => 102979)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 21:29:37 UTC (rev 102978)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 21:30:21 UTC (rev 102979)
@@ -1,3 +1,39 @@
+2011-12-15  Ryosuke Niwa  
+
+m_hasCounterNodeMap and m_everHadLayout should be private to RenderObject
+https://bugs.webkit.org/show_bug.cgi?id=74645
+
+Reviewed by Eric Seidel.
+
+Made them private and added getters and setters as needed.
+
+* rendering/RenderCounter.cpp:
+(WebCore::makeCounterNode):
+(WebCore::RenderCounter::destroyCounterNodes):
+(WebCore::updateCounters):
+(WebCore::RenderCounter::rendererStyleChanged):
+(showCounterRendererTree):
+* rendering/RenderFlowThread.cpp:
+(WebCore::RenderFlowThread::layout):
+* rendering/RenderObject.h:
+(WebCore::RenderObject::hasCounterNodeMap):
+(WebCore::RenderObject::setHasCounterNodeMap):
+(WebCore::RenderObject::everHadLayout):
+* rendering/svg/RenderSVGForeignObject.cpp:
+(WebCore::RenderSVGForeignObject::layout):
+* rendering/svg/RenderSVGImage.cpp:
+(WebCore::RenderSVGImage::layout):
+* rendering/svg/RenderSVGResourceContainer.cpp:
+(WebCore::RenderSVGResourceContainer::layout):
+* rendering/svg/RenderSVGResourceMarker.cpp:
+(WebCore::RenderSVGResourceMarker::layout):
+* rendering/svg/RenderSVGRoot.cpp:
+(WebCore::RenderSVGRoot::layout):
+* rendering/svg/RenderSVGShape.cpp:
+(WebCore::RenderSVGShape::layout):
+* rendering/svg/RenderSVGText.cpp:
+(WebCore::RenderSVGText::layout):
+
 2011-12-15  Vsevolod Vlasov  
 
 Not able to navigate the Resource tab options properly with arrow keys after adding the sticky-notes.


Modified: trunk/Source/WebCore/rendering/RenderCounter.cpp (102978 => 102979)

--- trunk/Source/WebCore/rendering/RenderCounter.cpp	2011-12-15 21:29:37 UTC (rev 102978)
+++ trunk/Source/WebCore/rendering/RenderCounter.cpp	2011-12-15 21:30:21 UTC (rev 102979)
@@ -416,7 +416,7 @@
 {
 ASSERT(object);
 
-if (object->m_hasCounterNodeMap) {
+if (object->hasCounterNodeMap()) {
 if (CounterMap* nodeMap = counterMaps().get(object)) {
 if (CounterNode* node = nodeMap->get(identifier.impl()).get())
 return node;
@@ -434,12 +434,12 @@
 if (findPlaceForCounter(object, identifier, isReset, newParent, newPreviousSibling))
 newParent->insertAfter(newNode.get(), newPreviousSibling, identifier);
 CounterMap* nodeMap;
-if (object->m_hasCounterNodeMap)
+if (object->hasCounterNodeMap())
 nodeMap = counterMaps().get(object);
 else {
 nodeMap = new CounterMap;
 counterMaps().set(object, nodeMap);
-object->m_hasCounterNodeMap = true;
+object->setHasCounterNodeMap(true);
 }
 nodeMap->set(identifier.impl(), newNode);
 if (newNode->parent())
@@ -451,7 +451,7

[webkit-changes] [102978] trunk/Source/JavaScriptCore

[commit-queue]

Title: [102978] trunk/Source/_javascript_Core








Revision 102978
Author commit-qu...@webkit.org
Date 2011-12-15 13:29:37 -0800 (Thu, 15 Dec 2011)


Log Message
Use more macrology in JSC::Options
https://bugs.webkit.org/show_bug.cgi?id=72938

Patch by Andy Wingo  on 2011-12-15
Reviewed by Filip Pizlo.

* runtime/Options.cpp:
(JSC::Options::initializeOptions):
* runtime/Options.h: Use macros to ensure that all heuristics are
declared and have initializers.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.cpp
trunk/Source/_javascript_Core/runtime/Options.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102977 => 102978)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-15 21:07:14 UTC (rev 102977)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-15 21:29:37 UTC (rev 102978)
@@ -1,3 +1,15 @@
+2011-12-15  Andy Wingo  
+
+Use more macrology in JSC::Options
+https://bugs.webkit.org/show_bug.cgi?id=72938
+
+Reviewed by Filip Pizlo.
+
+* runtime/Options.cpp:
+(JSC::Options::initializeOptions):
+* runtime/Options.h: Use macros to ensure that all heuristics are
+declared and have initializers.
+
 2011-12-15  Anders Carlsson  
 
 Add ScrollingCoordinator class and ENABLE_THREADED_SCROLLING define


Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (102977 => 102978)

--- trunk/Source/_javascript_Core/runtime/Options.cpp	2011-12-15 21:07:14 UTC (rev 102977)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp	2011-12-15 21:29:37 UTC (rev 102978)
@@ -44,52 +44,10 @@
 
 namespace JSC { namespace Options {
 
-unsigned maximumOptimizationCandidateInstructionCount;
+#define DEFINE(type, cname, default_val) type cname;
+FOR_EACH_OPTION(DEFINE)
+#undef DEFINE
 
-unsigned maximumFunctionForCallInlineCandidateInstructionCount;
-unsigned maximumFunctionForConstructInlineCandidateInstructionCount;
-
-unsigned maximumInliningDepth;
-
-int32_t executionCounterValueForOptimizeAfterWarmUp;
-int32_t executionCounterValueForOptimizeAfterLongWarmUp;
-int32_t executionCounterValueForDontOptimizeAnytimeSoon;
-int32_t executionCounterValueForOptimizeSoon;
-int32_t executionCounterValueForOptimizeNextInvocation;
-
-int32_t executionCounterIncrementForLoop;
-int32_t executionCounterIncrementForReturn;
-
-unsigned desiredSpeculativeSuccessFailRatio;
-
-double likelyToTakeSlowCaseThreshold;
-double couldTakeSlowCaseThreshold;
-unsigned likelyToTakeSlowCaseMinimumCount;
-unsigned couldTakeSlowCaseMinimumCount;
-
-double osrExitProminenceForFrequentExitSite;
-
-unsigned largeFailCountThresholdBase;
-unsigned largeFailCountThresholdBaseForLoop;
-
-unsigned reoptimizationRetryCounterMax;
-unsigned reoptimizationRetryCounterStep;
-
-unsigned minimumOptimizationDelay;
-unsigned maximumOptimizationDelay;
-double desiredProfileLivenessRate;
-double desiredProfileFullnessRate;
-
-double doubleVoteRatioForDoubleFormat;
-
-unsigned minimumNumberOfScansBetweenRebalance;
-unsigned gcMarkStackSegmentSize;
-unsigned minimumNumberOfCellsToKeep;
-unsigned maximumNumberOfSharedSegments;
-unsigned sharedStackWakeupThreshold;
-unsigned numberOfGCMarkers;
-unsigned opaqueRootMergeThreshold;
-
 #if ENABLE(RUN_TIME_HEURISTICS)
 static bool parse(const char* string, int32_t& value)
 {
@@ -129,67 +87,35 @@
 
 void initializeOptions()
 {
-SET(maximumOptimizationCandidateInstructionCount, 1000);
-
-SET(maximumFunctionForCallInlineCandidateInstructionCount, 150);
-SET(maximumFunctionForConstructInlineCandidateInstructionCount, 80);
-
-SET(maximumInliningDepth, 5);
+#define INIT(type, cname, default_val) SET(cname, default_val);
+FOR_EACH_OPTION(INIT)
+#undef INIT
 
-SET(executionCounterValueForOptimizeAfterWarmUp, -1000);
-SET(executionCounterValueForOptimizeAfterLongWarmUp, -5000);
-SET(executionCounterValueForDontOptimizeAnytimeSoon, std::numeric_limits::min());
-SET(executionCounterValueForOptimizeSoon,-1000);
-SET(executionCounterValueForOptimizeNextInvocation,  0);
+// Now we initialize heuristics whose defaults are not known at
+// compile-time.
 
-SET(executionCounterIncrementForLoop,   1);
-SET(executionCounterIncrementForReturn, 15);
+if (!gcMarkStackSegmentSize)
+gcMarkStackSegmentSize = pageSize();
 
-SET(desiredSpeculativeSuccessFailRatio, 6);
-
-SET(likelyToTakeSlowCaseThreshold,0.15);
-SET(couldTakeSlowCaseThreshold,   0.05); // Shouldn't be zero because some ops will spuriously take slow case, for example for linking or caching.
-SET(likelyToTakeSlowCaseMinimumCount, 100);
-SET(couldTakeSlowCaseMinimumCount,10);
-
-SET(osrExitProminenceForFrequentExitSite, 0.3);
-
-SET(largeFailCountThresholdBase,20);
-SET(largeFailCountThresholdBaseForLoop, 1);
-
-SET(reoptimizationRetryCounterStep, 1);
-
-SET(minimumOptimizationDelay,   1);
-SET(maximumOptimi

[webkit-changes] [102977] trunk/Source/WebCore

[vsevik]

Title: [102977] trunk/Source/WebCore








Revision 102977
Author vse...@chromium.org
Date 2011-12-15 13:07:14 -0800 (Thu, 15 Dec 2011)


Log Message
Not able to navigate the Resource tab options properly with arrow keys after adding the sticky-notes.
https://bugs.webkit.org/show_bug.cgi?id=72013

Reviewed by Pavel Feldman.

* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype._messagesClicked):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.DatabaseTreeElement.prototype.onexpand):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (102976 => 102977)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 20:46:29 UTC (rev 102976)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 21:07:14 UTC (rev 102977)
@@ -1,3 +1,16 @@
+2011-12-15  Vsevolod Vlasov  
+
+Not able to navigate the Resource tab options properly with arrow keys after adding the sticky-notes.
+https://bugs.webkit.org/show_bug.cgi?id=72013
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/DatabaseQueryView.js:
+(WebInspector.DatabaseQueryView):
+(WebInspector.DatabaseQueryView.prototype._messagesClicked):
+* inspector/front-end/ResourcesPanel.js:
+(WebInspector.DatabaseTreeElement.prototype.onexpand):
+
 2011-12-15  Anders Carlsson  
 
 Add ScrollingCoordinator class and ENABLE_THREADED_SCROLLING define


Modified: trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js (102976 => 102977)

--- trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js	2011-12-15 20:46:29 UTC (rev 102976)
+++ trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js	2011-12-15 21:07:14 UTC (rev 102977)
@@ -36,7 +36,6 @@
 this.element.addStyleClass("storage-view");
 this.element.addStyleClass("query");
 this.element.addStyleClass("monospace");
-this.element.tabIndex = 0;
 this.element.addEventListener("selectstart", this._selectStart.bind(this), false);
 
 this._promptElement = document.createElement("div");
@@ -47,6 +46,8 @@
 
 this.prompt = new WebInspector.TextPromptWithHistory(this.completions.bind(this), " ");
 this.prompt.attach(this._promptElement);
+
+this.element.addEventListener("click", this._messagesClicked.bind(this), true);
 }
 
 WebInspector.DatabaseQueryView.Events = {
@@ -54,22 +55,12 @@
 }
 
 WebInspector.DatabaseQueryView.prototype = {
-wasShown: function()
+_messagesClicked: function()
 {
-function moveBackIfOutside()
-{
-if (!this.prompt.isCaretInsidePrompt() && window.getSelection().isCollapsed)
-this.prompt.moveCaretToEndOfPrompt();
-}
-
-setTimeout(moveBackIfOutside.bind(this), 0);
+if (!this.prompt.isCaretInsidePrompt() && window.getSelection().isCollapsed)
+this.prompt.moveCaretToEndOfPrompt();
 },
-
-afterShow: function()
-{
-WebInspector.setCurrentFocusElement(this._promptElement);
-},
-
+
 completions: function(wordRange, force, completionsReadyCallback)
 {
 var prefix = wordRange.toString().toLowerCase();


Modified: trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js (102976 => 102977)

--- trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js	2011-12-15 20:46:29 UTC (rev 102976)
+++ trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js	2011-12-15 21:07:14 UTC (rev 102977)
@@ -1436,14 +1436,12 @@
 this._storagePanel.showDatabase(this._database);
 },
 
-oncollapse: function()
+onexpand: function()
 {
-// Request a refresh after every collapse so the next
-// expand will have an updated table list.
-this.shouldRefreshChildren = true;
+this._updateChildren();
 },
 
-onpopulate: function()
+_updateChildren: function()
 {
 this.removeChildren();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102975] trunk/Source

[andersca]

Title: [102975] trunk/Source








Revision 102975
Author ander...@apple.com
Date 2011-12-15 12:44:57 -0800 (Thu, 15 Dec 2011)


Log Message
Add ScrollingCoordinator class and ENABLE_THREADED_SCROLLING define
https://bugs.webkit.org/show_bug.cgi?id=74639

Reviewed by Andreas Kling.

Source/_javascript_Core:

Add ENABLE_THREADED_SCROLLING #define.

* wtf/Platform.h:

Source/WebCore:

Add a ScrollingCoordinator class and make it a member of Page. Tear it down
when the page goes away.

* WebCore.xcodeproj/project.pbxproj:
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
* page/Page.h:
(WebCore::Page::scrollingCoordinator):
* page/ScrollingCoordinator.cpp: Added.
(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
(WebCore::ScrollingCoordinator::pageDestroyed):
* page/ScrollingCoordinator.h: Added.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h


Added Paths

trunk/Source/WebCore/page/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/ScrollingCoordinator.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102974 => 102975)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-15 20:32:45 UTC (rev 102974)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-15 20:44:57 UTC (rev 102975)
@@ -1,5 +1,16 @@
 2011-12-15  Anders Carlsson  
 
+Add ScrollingCoordinator class and ENABLE_THREADED_SCROLLING define
+https://bugs.webkit.org/show_bug.cgi?id=74639
+
+Reviewed by Andreas Kling.
+
+Add ENABLE_THREADED_SCROLLING #define.
+
+* wtf/Platform.h:
+
+2011-12-15  Anders Carlsson  
+
 EventDispatcher should handle wheel events on the connection queue
 https://bugs.webkit.org/show_bug.cgi?id=74627
 


Modified: trunk/Source/_javascript_Core/wtf/Platform.h (102974 => 102975)

--- trunk/Source/_javascript_Core/wtf/Platform.h	2011-12-15 20:32:45 UTC (rev 102974)
+++ trunk/Source/_javascript_Core/wtf/Platform.h	2011-12-15 20:44:57 UTC (rev 102975)
@@ -1062,6 +1062,10 @@
 #define ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH 1
 #endif
 
+#if PLATFORM(MAC) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD) && !defined(BUILDING_ON_LION)
+#define ENABLE_THREADED_SCROLLING 1
+#endif
+
 /* Set up a define for a common error that is intended to cause a build error -- thus the space after Error. */
 #define WTF_PLATFORM_CFNETWORK Error USE_macro_should_be_used_with_CFNETWORK
 


Modified: trunk/Source/WebCore/ChangeLog (102974 => 102975)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 20:32:45 UTC (rev 102974)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 20:44:57 UTC (rev 102975)
@@ -1,3 +1,26 @@
+2011-12-15  Anders Carlsson  
+
+Add ScrollingCoordinator class and ENABLE_THREADED_SCROLLING define
+https://bugs.webkit.org/show_bug.cgi?id=74639
+
+Reviewed by Andreas Kling.
+
+Add a ScrollingCoordinator class and make it a member of Page. Tear it down
+when the page goes away.
+
+* WebCore.xcodeproj/project.pbxproj:
+* page/Page.cpp:
+(WebCore::Page::Page):
+(WebCore::Page::~Page):
+* page/Page.h:
+(WebCore::Page::scrollingCoordinator):
+* page/ScrollingCoordinator.cpp: Added.
+(WebCore::ScrollingCoordinator::create):
+(WebCore::ScrollingCoordinator::ScrollingCoordinator):
+(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
+(WebCore::ScrollingCoordinator::pageDestroyed):
+* page/ScrollingCoordinator.h: Added.
+
 2011-12-15  Kenneth Russell  
 
 Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (102974 => 102975)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-12-15 20:32:45 UTC (rev 102974)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-12-15 20:44:57 UTC (rev 102975)
@@ -372,6 +372,8 @@
 		1A2E6E590CC55213004A2062 /* SQLValue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A2E6E570CC55213004A2062 /* SQLValue.cpp */; };
 		1A2E6E5A0CC55213004A2062 /* SQLValue.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A2E6E580CC55213004A2062 /* SQLValue.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		1A2E6E7A0CC556D5004A2062 /* SQLiteAuthorizer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A2E6E780CC556D5004A2062 /* SQLiteAuthorizer.cpp */; };
+		1A2F9D7914968C740065AC63 /* ScrollingCoordinator.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A2F9D7714968C740065AC63 /* ScrollingCoordinator.cpp */; };
+		1A2F9D7A14968C740065AC63 /* ScrollingCoordinator.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A2F9D7814968C740065AC63 /* ScrollingCoordinator.h */; };
 		1A3417C90CECFF250049CBDE

[webkit-changes] [102974] trunk/Source/WebKit/chromium

[tommyw]

Title: [102974] trunk/Source/WebKit/chromium








Revision 102974
Author tom...@google.com
Date 2011-12-15 12:32:45 -0800 (Thu, 15 Dec 2011)


Log Message
[chromium] MediaStream API: Fixing #include statements and removing forwarding header file
https://bugs.webkit.org/show_bug.cgi?id=74598

Reviewed by Darin Fisher.

WebMediaStreamSource.h had some issues when accessed from chromium. Also cleaned up the forwarding header.

* WebKit.gyp:
* public/WebMediaStreamSource.h: Removed.
* public/platform/WebMediaStreamSource.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/platform/WebMediaStreamSource.h


Removed Paths

trunk/Source/WebKit/chromium/public/WebMediaStreamSource.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102973 => 102974)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 19:54:23 UTC (rev 102973)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 20:32:45 UTC (rev 102974)
@@ -1,3 +1,16 @@
+2011-12-15  Tommy Widenflycht  
+
+[chromium] MediaStream API: Fixing #include statements and removing forwarding header file
+https://bugs.webkit.org/show_bug.cgi?id=74598
+
+Reviewed by Darin Fisher.
+
+WebMediaStreamSource.h had some issues when accessed from chromium. Also cleaned up the forwarding header.
+
+* WebKit.gyp:
+* public/WebMediaStreamSource.h: Removed.
+* public/platform/WebMediaStreamSource.h:
+
 2011-12-15  Stephen White  
 
 Unreviewed, rolling out r102956.


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (102973 => 102974)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2011-12-15 19:54:23 UTC (rev 102973)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2011-12-15 20:32:45 UTC (rev 102974)
@@ -193,7 +193,6 @@
 'public/WebMediaPlayerAction.h',
 'public/WebMediaPlayerClient.h',
 'public/WebMediaStreamRegistry.h',
-'public/WebMediaStreamSource.h',
 'public/WebMenuItemInfo.h',
 'public/WebMessagePortChannel.h',
 'public/WebMessagePortChannelClient.h',


Deleted: trunk/Source/WebKit/chromium/public/WebMediaStreamSource.h (102973 => 102974)

--- trunk/Source/WebKit/chromium/public/WebMediaStreamSource.h	2011-12-15 19:54:23 UTC (rev 102973)
+++ trunk/Source/WebKit/chromium/public/WebMediaStreamSource.h	2011-12-15 20:32:45 UTC (rev 102974)
@@ -1,31 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "platform/WebMediaStreamSource.h"


Modified: trunk/Source/WebKit/chromium/public/platform/WebMediaStreamSource.h (102973 => 102974)

--- trunk/Source/WebKit/chromium/public/platform/WebMediaStreamSource.h	2011-12-15 19:54:23 UTC (rev 102973)
+++ trunk/Source/WebKit/chromium/public/platform/WebMediaStreamSource.h	2011-12-15 20:32:45 UTC (rev 102974)
@@ -31,9 +31,9 @@
 #ifndef WebMediaStreamSource_h
 #define WebMediaStreamSource_h
 
-#include "platform/WebCommon.h"
-#include "platform/WebNonCopyable.h"
-#include "platform/WebPrivatePtr.h"
+#include "WebCommon.h"
+#include "WebNonCopyable.h"
+#include "WebPrivatePtr.h"
 
 namespace WebCore {
 class MediaStreamSource;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102972] trunk/Source/WebKit/chromium

[senorblanco]

Title: [102972] trunk/Source/WebKit/chromium








Revision 102972
Author senorbla...@chromium.org
Date 2011-12-15 11:47:58 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed, rolling out r102956.
http://trac.webkit.org/changeset/102956
https://bugs.webkit.org/show_bug.cgi?id=74334

Broke Chromium/Win build.

* features.gypi:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102971 => 102972)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 19:45:35 UTC (rev 102971)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 19:47:58 UTC (rev 102972)
@@ -1,3 +1,13 @@
+2011-12-15  Stephen White  
+
+Unreviewed, rolling out r102956.
+http://trac.webkit.org/changeset/102956
+https://bugs.webkit.org/show_bug.cgi?id=74334
+
+Broke Chromium/Win build.
+
+* features.gypi:
+
 2011-12-15  Kenneth Russell  
 
 Unreviewed. Disable flaky tests. Built and tested on Linux.


Modified: trunk/Source/WebKit/chromium/features.gypi (102971 => 102972)

--- trunk/Source/WebKit/chromium/features.gypi	2011-12-15 19:45:35 UTC (rev 102971)
+++ trunk/Source/WebKit/chromium/features.gypi	2011-12-15 19:47:58 UTC (rev 102972)
@@ -37,7 +37,6 @@
   'ENABLE_BLOB_SLICE=1',
   'ENABLE_CHANNEL_MESSAGING=1',
   'ENABLE_CLIENT_BASED_GEOLOCATION=1',
-  'ENABLE_CSS_FILTERS=1',
   'ENABLE_DASHBOARD_SUPPORT=0',
   'ENABLE_DATA_TRANSFER_ITEMS=1',
   'ENABLE_DETAILS=1',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102971] trunk/Source/WebKit/efl

[kubo]

Title: [102971] trunk/Source/WebKit/efl








Revision 102971
Author k...@profusion.mobi
Date 2011-12-15 11:45:35 -0800 (Thu, 15 Dec 2011)


Log Message
[EFL] Clean up and refactor the memory cache functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72140

Reviewed by Antonio Gomes.

Use a better naming prefix, as "ewk_settings_cache" was too general,
and make it possible to pass all parameters to
MemoryCache::setCapacities().

* ewk/ewk_settings.cpp:
(ewk_settings_object_cache_capacity_set):
(ewk_settings_object_cache_enable_get):
(ewk_settings_object_cache_enable_set):
* ewk/ewk_settings.h:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_settings.cpp
trunk/Source/WebKit/efl/ewk/ewk_settings.h




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (102970 => 102971)

--- trunk/Source/WebKit/efl/ChangeLog	2011-12-15 19:34:20 UTC (rev 102970)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-12-15 19:45:35 UTC (rev 102971)
@@ -1,5 +1,22 @@
 2011-12-15  Raphael Kubo da Costa  
 
+[EFL] Clean up and refactor the memory cache functions in ewk_settings.
+https://bugs.webkit.org/show_bug.cgi?id=72140
+
+Reviewed by Antonio Gomes.
+
+Use a better naming prefix, as "ewk_settings_cache" was too general,
+and make it possible to pass all parameters to
+MemoryCache::setCapacities().
+
+* ewk/ewk_settings.cpp:
+(ewk_settings_object_cache_capacity_set):
+(ewk_settings_object_cache_enable_get):
+(ewk_settings_object_cache_enable_set):
+* ewk/ewk_settings.h:
+
+2011-12-15  Raphael Kubo da Costa  
+
 [EFL] Add a few more web database functions to ewk_settings.
 https://bugs.webkit.org/show_bug.cgi?id=72148
 


Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.cpp (102970 => 102971)

--- trunk/Source/WebKit/efl/ewk/ewk_settings.cpp	2011-12-15 19:34:20 UTC (rev 102970)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.cpp	2011-12-15 19:45:35 UTC (rev 102971)
@@ -220,24 +220,19 @@
 return ewk_util_image_from_cairo_surface_add(canvas, surface);
 }
 
-Eina_Bool ewk_settings_cache_enable_get(void)
+void ewk_settings_object_cache_capacity_set(unsigned minDeadCapacity, unsigned maxDeadCapacity, unsigned totalCapacity)
 {
-WebCore::MemoryCache* cache = WebCore::memoryCache();
-return !cache->disabled();
+WebCore::memoryCache()->setCapacities(minDeadCapacity, maxDeadCapacity, totalCapacity);
 }
 
-void ewk_settings_cache_enable_set(Eina_Bool set)
+Eina_Bool ewk_settings_object_cache_enable_get()
 {
-WebCore::MemoryCache* cache = WebCore::memoryCache();
-set = !set;
-if (cache->disabled() != set)
-cache->setDisabled(set);
+return !WebCore::memoryCache()->disabled();
 }
 
-void ewk_settings_cache_capacity_set(unsigned capacity)
+void ewk_settings_object_cache_enable_set(Eina_Bool enable)
 {
-WebCore::MemoryCache* cache = WebCore::memoryCache();
-cache->setCapacities(0, capacity, capacity);
+WebCore::memoryCache()->setDisabled(!enable);
 }
 
 void ewk_settings_memory_cache_clear()


Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.h (102970 => 102971)

--- trunk/Source/WebKit/efl/ewk/ewk_settings.h	2011-12-15 19:34:20 UTC (rev 102970)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.h	2011-12-15 19:45:35 UTC (rev 102971)
@@ -203,30 +203,51 @@
 EAPI void ewk_settings_application_cache_clear(void);
 
 /**
- * Gets status of the memory cache of WebCore.
+ * Returns whether the in-memory object cache is enabled.
  *
+ * The object cache is responsible for holding resources such as scripts, stylesheets
+ * and images in memory.
+ *
+ * By default, the cache is enabled.
+ *
  * @return @c EINA_TRUE if the cache is enabled or @c EINA_FALSE if not
+ *
+ * @sa ewk_settings_object_cache_capacity_set
  */
-EAPI Eina_Boolewk_settings_cache_enable_get(void);
+EAPI Eina_Boolewk_settings_object_cache_enable_get(void);
 
 /**
- * Enables/disables the memory cache of WebCore, possibly clearing it.
+ * Enables/disables the in-memory object cache of WebCore, possibly clearing it.
  *
+ * The object cache is responsible for holding resources such as scripts, stylesheets
+ * and images in memory.
+ *
+ * By default, the cache is enabled.
+ *
  * Disabling the cache will remove all resources from the cache.
  * They may still live on if they are referenced by some Web page though.
  *
  * @param set @c EINA_TRUE to enable memory cache, @c EINA_FALSE to disable
  */
-EAPI void ewk_settings_cache_enable_set(Eina_Bool set);
+EAPI void ewk_settings_object_cache_enable_set(Eina_Bool set);
 
 /**
- * Sets capacity of memory cache of WebCore.
+ * Defines the capacities for the in-memory object cache.
  *
- * WebCore sets default value of memory cache on 8192 * 1024 bytes.
+ * The object cache is responsible for holding resources such as scripts, stylesheets
+ * and images in memory.
  *
+ * By default, @p min_dead_bytes i

[webkit-changes] [102970] trunk/Source/WebKit/chromium

[kbr]

Title: [102970] trunk/Source/WebKit/chromium








Revision 102970
Author k...@google.com
Date 2011-12-15 11:34:20 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed. Disable flaky tests. Built and tested on Linux.
https://bugs.webkit.org/show_bug.cgi?id=74623

* tests/CCLayerTreeHostTest.cpp:
(WTF::TEST_F):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102969 => 102970)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 19:28:14 UTC (rev 102969)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 19:34:20 UTC (rev 102970)
@@ -1,3 +1,11 @@
+2011-12-15  Kenneth Russell  
+
+Unreviewed. Disable flaky tests. Built and tested on Linux.
+https://bugs.webkit.org/show_bug.cgi?id=74623
+
+* tests/CCLayerTreeHostTest.cpp:
+(WTF::TEST_F):
+
 2011-12-15  Stephen White  
 
 Enable CSS_FILTERS in Chromium.


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (102969 => 102970)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp	2011-12-15 19:28:14 UTC (rev 102969)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp	2011-12-15 19:34:20 UTC (rev 102970)
@@ -808,7 +808,7 @@
 int m_scrolls;
 };
 
-TEST_F(CCLayerTreeHostTestScrollSimple, runMultiThread)
+TEST_F(CCLayerTreeHostTestScrollSimple, DISABLED_runMultiThread)
 {
 runTestThreaded();
 }
@@ -884,7 +884,7 @@
 int m_scrolls;
 };
 
-TEST_F(CCLayerTreeHostTestScrollMultipleRedraw, runMultiThread)
+TEST_F(CCLayerTreeHostTestScrollMultipleRedraw, DISABLED_runMultiThread)
 {
 runTestThreaded();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102969] trunk/Source/WebCore

[beidson]

Title: [102969] trunk/Source/WebCore








Revision 102969
Author beid...@apple.com
Date 2011-12-15 11:28:14 -0800 (Thu, 15 Dec 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=74631
HTMLMediaElement should not register for document activation callbacks as it doesn't use them

Reviewed by Eric Carlson.

No new tests. (No behavior change, pruning useless code)

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::willMoveToNewOwnerDocument):
(WebCore::HTMLMediaElement::didMoveToNewOwnerDocument):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102968 => 102969)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 19:18:54 UTC (rev 102968)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 19:28:14 UTC (rev 102969)
@@ -1,3 +1,18 @@
+2011-12-15  Brady Eidson  
+
+https://bugs.webkit.org/show_bug.cgi?id=74631
+HTMLMediaElement should not register for document activation callbacks as it doesn't use them
+
+Reviewed by Eric Carlson.
+
+No new tests. (No behavior change, pruning useless code)
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::HTMLMediaElement):
+(WebCore::HTMLMediaElement::~HTMLMediaElement):
+(WebCore::HTMLMediaElement::willMoveToNewOwnerDocument):
+(WebCore::HTMLMediaElement::didMoveToNewOwnerDocument):
+
 2011-12-15  Eric Carlson  
 
 Text tracks should be treated differently according to their kind


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (102968 => 102969)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2011-12-15 19:18:54 UTC (rev 102968)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2011-12-15 19:28:14 UTC (rev 102969)
@@ -238,7 +238,6 @@
 #endif
 {
 LOG(Media, "HTMLMediaElement::HTMLMediaElement");
-document->registerForDocumentActivationCallbacks(this);
 document->registerForMediaVolumeCallbacks(this);
 document->registerForPrivateBrowsingStateChangedCallbacks(this);
 
@@ -260,7 +259,6 @@
 if (m_isWaitingUntilMediaCanStart)
 document()->removeMediaCanStartListener(this);
 setShouldDelayLoadEvent(false);
-document()->unregisterForDocumentActivationCallbacks(this);
 document()->unregisterForMediaVolumeCallbacks(this);
 document()->unregisterForPrivateBrowsingStateChangedCallbacks(this);
 #if ENABLE(VIDEO_TRACK)
@@ -283,7 +281,6 @@
 if (m_isWaitingUntilMediaCanStart)
 document()->removeMediaCanStartListener(this);
 setShouldDelayLoadEvent(false);
-document()->unregisterForDocumentActivationCallbacks(this);
 document()->unregisterForMediaVolumeCallbacks(this);
 removeElementFromDocumentMap(this, document());
 HTMLElement::willMoveToNewOwnerDocument();
@@ -295,7 +292,6 @@
 document()->addMediaCanStartListener(this);
 if (m_readyState < HAVE_CURRENT_DATA)
 setShouldDelayLoadEvent(true);
-document()->registerForDocumentActivationCallbacks(this);
 document()->registerForMediaVolumeCallbacks(this);
 addElementToDocumentMap(this, document());
 HTMLElement::didMoveToNewOwnerDocument();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102967] trunk/LayoutTests

[kbr]

Title: [102967] trunk/LayoutTests








Revision 102967
Author k...@google.com
Date 2011-12-15 11:13:24 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed Chromium test expectations update; add suppression.
https://bugs.webkit.org/show_bug.cgi?id=74634

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102966 => 102967)

--- trunk/LayoutTests/ChangeLog	2011-12-15 19:11:35 UTC (rev 102966)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 19:13:24 UTC (rev 102967)
@@ -1,3 +1,10 @@
+2011-12-15  Kenneth Russell  
+
+Unreviewed Chromium test expectations update; add suppression.
+https://bugs.webkit.org/show_bug.cgi?id=74634
+
+* platform/chromium/test_expectations.txt:
+
 2011-12-15  Raphael Kubo da Costa  
 
 [EFL] Add a few more web database functions to ewk_settings.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102966 => 102967)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-15 19:11:35 UTC (rev 102966)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-15 19:13:24 UTC (rev 102967)
@@ -4010,3 +4010,5 @@
 
 // Need rebaseline on Mac.
 BUGWK50999 : fast/text/unicode-variation-selector.html = MISSING FAIL
+
+BUGWK74634 WIN : compositing/absolute-position-changed-with-composited-parent-layer.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102966] trunk

[kubo]

Title: [102966] trunk








Revision 102966
Author k...@profusion.mobi
Date 2011-12-15 11:11:35 -0800 (Thu, 15 Dec 2011)


Log Message
[EFL] Add a few more web database functions to ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72148

Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add code to change the default quota (there as only a getter so far)
and one to clear the databases.

* ewk/ewk_settings.cpp:
(ewk_settings_web_database_default_quota_set):
(ewk_settings_web_database_clear):
* ewk/ewk_settings.h:

Tools:

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearAllDatabases):
(LayoutTestController::setDatabaseQuota):

LayoutTests:

LayoutTestController::setDatabaseQuota is implemented now.

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_settings.cpp
trunk/Source/WebKit/efl/ewk/ewk_settings.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (102965 => 102966)

--- trunk/LayoutTests/ChangeLog	2011-12-15 19:07:58 UTC (rev 102965)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 19:11:35 UTC (rev 102966)
@@ -1,3 +1,14 @@
+2011-12-15  Raphael Kubo da Costa  
+
+[EFL] Add a few more web database functions to ewk_settings.
+https://bugs.webkit.org/show_bug.cgi?id=72148
+
+Reviewed by Antonio Gomes.
+
+LayoutTestController::setDatabaseQuota is implemented now.
+
+* platform/efl/Skipped:
+
 2011-12-15  Brady Eidson  
 
 https://bugs.webkit.org/show_bug.cgi?id=74607


Modified: trunk/LayoutTests/platform/efl/Skipped (102965 => 102966)

--- trunk/LayoutTests/platform/efl/Skipped	2011-12-15 19:07:58 UTC (rev 102965)
+++ trunk/LayoutTests/platform/efl/Skipped	2011-12-15 19:11:35 UTC (rev 102966)
@@ -667,10 +667,6 @@
 # EFL's LayoutTestController does not implement clearAllDatabases
 storage
 
-# EFL's LayoutTestController does not implement setDatabaseQuota
-storage/open-database-creation-callback.html
-storage/quota-tracking.html
-
 # EFL's LayoutTestController does not implement originsWithLocalStorage
 storage/domstorage/localstorage/storagetracker
 


Modified: trunk/Source/WebKit/efl/ChangeLog (102965 => 102966)

--- trunk/Source/WebKit/efl/ChangeLog	2011-12-15 19:07:58 UTC (rev 102965)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-12-15 19:11:35 UTC (rev 102966)
@@ -1,3 +1,18 @@
+2011-12-15  Raphael Kubo da Costa  
+
+[EFL] Add a few more web database functions to ewk_settings.
+https://bugs.webkit.org/show_bug.cgi?id=72148
+
+Reviewed by Antonio Gomes.
+
+Add code to change the default quota (there as only a getter so far)
+and one to clear the databases.
+
+* ewk/ewk_settings.cpp:
+(ewk_settings_web_database_default_quota_set):
+(ewk_settings_web_database_clear):
+* ewk/ewk_settings.h:
+
 2011-12-14  Gyuyoung Kim  
 
 [EFL] Change efl style variable name with WebKit style for internal functions.


Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.cpp (102965 => 102966)

--- trunk/Source/WebKit/efl/ewk/ewk_settings.cpp	2011-12-15 19:07:58 UTC (rev 102965)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.cpp	2011-12-15 19:11:35 UTC (rev 102966)
@@ -99,6 +99,18 @@
 return s_webDatabaseQuota;
 }
 
+void ewk_settings_web_database_default_quota_set(uint64_t maximumSize)
+{
+s_webDatabaseQuota = maximumSize;
+}
+
+void ewk_settings_web_database_clear()
+{
+#if ENABLE(SQL_DATABASE)
+WebCore::DatabaseTracker::tracker().deleteAllDatabases();
+#endif
+}
+
 void ewk_settings_web_database_path_set(const char* path)
 {
 #if ENABLE(SQL_DATABASE)


Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.h (102965 => 102966)

--- trunk/Source/WebKit/efl/ewk/ewk_settings.h	2011-12-15 19:07:58 UTC (rev 102965)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.h	2011-12-15 19:11:35 UTC (rev 102966)
@@ -44,6 +44,20 @@
 EAPI uint64_t ewk_settings_web_database_default_quota_get(void);
 
 /**
+ * Sets the default maximum size (in bytes) an HTML5 Web Database database can have.
+ *
+ * By default, this value is 1MB.
+ *
+ * @param maximum_size the new maximum size a database is allowed
+ */
+EAPI void ewk_settings_web_database_default_quota_set(uint64_t maximum_size);
+
+/**
+ * Removes all HTML5 Web Database databases.
+ */
+EAPI void ewk_settings_web_database_clear(void);
+
+/**
  * Sets the current path to the directory WebKit will write Web
  * Database databases.
  *


Modified: trunk/Tools/ChangeLog (102965 => 102966)

--- trunk/Tools/ChangeLog	2011-12-15 19:07:58 UTC (rev 102965)
+++ trunk/Tools/ChangeLog	2011-12-15 19:11:35 UTC (rev 102966)
@@ -1,3 +1,14 @@
+2011-12-15  Raphael Kubo da Costa  
+
+[EFL] Add a few more web database functions to ewk_settings.
+https://bugs.webkit.org/show_bug.cgi?id=72148
+
+Reviewe

[webkit-changes] [102965] trunk/Source/WebKit2

[kov]

Title: [102965] trunk/Source/WebKit2








Revision 102965
Author k...@webkit.org
Date 2011-12-15 11:07:58 -0800 (Thu, 15 Dec 2011)


Log Message
[GTK] New API test for WindowProperties fails
https://bugs.webkit.org/show_bug.cgi?id=74630

Patch by Gustavo Noronha Silva  on 2011-12-15
Reviewed by Martin Robinson.

* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(WindowProperties::viewReadyToShow): assert each member to make
assertion error messages more useful, and avoid asserting x and y,
since we are getting bad values from WebCore, for some reason.
(testWebViewWindowProperties): use smaller values that fit inside the
800x600 screen used by the bots.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102964 => 102965)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 19:04:53 UTC (rev 102964)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 19:07:58 UTC (rev 102965)
@@ -1,3 +1,17 @@
+2011-12-15  Gustavo Noronha Silva  
+
+[GTK] New API test for WindowProperties fails
+https://bugs.webkit.org/show_bug.cgi?id=74630
+
+Reviewed by Martin Robinson.
+
+* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
+(WindowProperties::viewReadyToShow): assert each member to make
+assertion error messages more useful, and avoid asserting x and y,
+since we are getting bad values from WebCore, for some reason.
+(testWebViewWindowProperties): use smaller values that fit inside the
+800x600 screen used by the bots.
+
 2011-12-15  Anders Carlsson  
 
 EventDispatcher should handle wheel events on the connection queue


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp (102964 => 102965)

--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp	2011-12-15 19:04:53 UTC (rev 102964)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp	2011-12-15 19:07:58 UTC (rev 102965)
@@ -137,19 +137,19 @@
 {
 }
 
-bool operator==(const WindowProperties& other) const
+void assertEqual(const WindowProperties& other) const
 {
-return m_geometry.x == other.m_geometry.x
-&& m_geometry.y == other.m_geometry.y
-&& m_geometry.width == other.m_geometry.width
-&& m_geometry.height == other.m_geometry.height
-&& m_toolbarVisible == other.m_toolbarVisible
-&& m_statusbarVisible == other.m_statusbarVisible
-&& m_scrollbarsVisible == other.m_scrollbarsVisible
-&& m_menubarVisible == other.m_menubarVisible
-&& m_locationbarVisible == other.m_locationbarVisible
-&& m_resizable == other.m_resizable
-&& m_fullscreen == other.m_fullscreen;
+// FIXME: We should assert x and y are equal, but we are getting an incorrect
+// value from WebCore (280 instead of 150).
+g_assert_cmpint(m_geometry.width, ==, other.m_geometry.width);
+g_assert_cmpint(m_geometry.height, ==, other.m_geometry.height);
+g_assert_cmpint(static_cast(m_toolbarVisible), ==, static_cast(other.m_toolbarVisible));
+g_assert_cmpint(static_cast(m_statusbarVisible), ==, static_cast(other.m_statusbarVisible));
+g_assert_cmpint(static_cast(m_scrollbarsVisible), ==, static_cast(other.m_scrollbarsVisible));
+g_assert_cmpint(static_cast(m_menubarVisible), ==, static_cast(other.m_menubarVisible));
+g_assert_cmpint(static_cast(m_locationbarVisible), ==, static_cast(other.m_locationbarVisible));
+g_assert_cmpint(static_cast(m_resizable), ==, static_cast(other.m_resizable));
+g_assert_cmpint(static_cast(m_fullscreen), ==, static_cast(other.m_fullscreen));
 }
 
 private:
@@ -186,7 +186,7 @@
 
 WebKitWindowProperties* windowProperties = webkit_web_view_get_window_properties(webView);
 g_assert(windowProperties);
-g_assert(WindowProperties(windowProperties) == test->m_windowProperties);
+WindowProperties(windowProperties).assertEqual(test->m_windowProperties);
 
 test->m_webViewEvents.append(ReadyToShow);
 }
@@ -326,8 +326,8 @@
 
 static void testWebViewWindowProperties(UIClientTest* test, gconstpointer)
 {
-static const char* windowProrpertiesString = "left=100,top=150,width=800,height=600,location=no,menubar=no,status=no,toolbar=no,scrollbars=no";
-GdkRectangle geometry = { 100, 150, 800, 600 };
+static const char* windowProrpertiesString = "left=100,top=150,width=400,height=400,location=no,menubar=no,status=no,toolbar=no,scrollbars=no";
+GdkRectangle geometry = { 100, 150, 400, 400 };
 test->setExpectedWindowProperties(UIClientTest::WindowProperties(&geometry, false, false, false, false, false, true, false));
 
 GOwnPtr htmlString(g_strdup_printf("",

[webkit-changes] [102964] trunk/LayoutTests

[beidson]

Title: [102964] trunk/LayoutTests








Revision 102964
Author beid...@apple.com
Date 2011-12-15 11:04:53 -0800 (Thu, 15 Dec 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=74607
Removed a skipped test after rolling out r102829

Unreviewed.

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (102963 => 102964)

--- trunk/LayoutTests/ChangeLog	2011-12-15 18:56:16 UTC (rev 102963)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 19:04:53 UTC (rev 102964)
@@ -1,5 +1,14 @@
 2011-12-15  Brady Eidson  
 
+https://bugs.webkit.org/show_bug.cgi?id=74607
+Removed a skipped test after rolling out r102829
+
+Unreviewed.
+
+* platform/qt/Skipped:
+
+2011-12-15  Brady Eidson  
+
 Unreviewed, rolling out r102829.
 http://trac.webkit.org/changeset/102829
 https://bugs.webkit.org/show_bug.cgi?id=74533


Modified: trunk/LayoutTests/platform/qt/Skipped (102963 => 102964)

--- trunk/LayoutTests/platform/qt/Skipped	2011-12-15 18:56:16 UTC (rev 102963)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-12-15 19:04:53 UTC (rev 102964)
@@ -2531,7 +2531,3 @@
 # [Qt][GTK] The html5lib/runner.html test is start to fail after r102626
 # https://bugs.webkit.org/show_bug.cgi?id=74411
 html5lib/runner.html
-
-# REGRESSION(r102829): It made fast/images/move-image-to-new-document.html timeout
-# https://bugs.webkit.org/show_bug.cgi?id=74607
-fast/images/move-image-to-new-document.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102963] trunk/Source

[andersca]

Title: [102963] trunk/Source








Revision 102963
Author ander...@apple.com
Date 2011-12-15 10:56:16 -0800 (Thu, 15 Dec 2011)


Log Message
EventDispatcher should handle wheel events on the connection queue
https://bugs.webkit.org/show_bug.cgi?id=74627

Reviewed by Andreas Kling.

Source/_javascript_Core:

Add a BoundFunctionImpl specialization that takes three parameters.

* wtf/Functional.h:
(WTF::C::):
(WTF::R):
(WTF::bind):

Source/WebKit2:

Send wheel events to the EventDispatcher, which handles them on the connection work queue, and
immediately bounces them to the main thread (for now).

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent):
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::dispatchWheelEvent):
* WebProcess/WebPage/EventDispatcher.h:
* WebProcess/WebPage/EventDispatcher.messages.in:
* WebProcess/WebPage/WebPage.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Functional.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp
trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.h
trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102962 => 102963)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-15 18:50:59 UTC (rev 102962)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-15 18:56:16 UTC (rev 102963)
@@ -1,3 +1,17 @@
+2011-12-15  Anders Carlsson  
+
+EventDispatcher should handle wheel events on the connection queue
+https://bugs.webkit.org/show_bug.cgi?id=74627
+
+Reviewed by Andreas Kling.
+
+Add a BoundFunctionImpl specialization that takes three parameters.
+
+* wtf/Functional.h:
+(WTF::C::):
+(WTF::R):
+(WTF::bind):
+
 2011-12-14  Anders Carlsson  
 
 Add WTF::Function to wtf/Forward.h


Modified: trunk/Source/_javascript_Core/wtf/Functional.h (102962 => 102963)

--- trunk/Source/_javascript_Core/wtf/Functional.h	2011-12-15 18:50:59 UTC (rev 102962)
+++ trunk/Source/_javascript_Core/wtf/Functional.h	2011-12-15 18:56:16 UTC (rev 102963)
@@ -157,6 +157,25 @@
 R (C::*m_function)(P0);
 };
 
+template class FunctionWrapper {
+public:
+typedef R ResultType;
+static const bool shouldRefFirstParameter = HasRefAndDeref::value;
+
+explicit FunctionWrapper(R (C::*function)(P0, P1))
+: m_function(function)
+{
+}
+
+R operator()(C* c, P0 p0, P1 p1)
+{
+return (c->*m_function)(p0, p1);
+}
+
+private:
+R (C::*m_function)(P0, P1);
+};
+
 template struct RefAndDeref {
 static void ref(T) { }
 static void deref(T) { }
@@ -251,6 +270,34 @@
 P1 m_p1;
 };
 
+template class BoundFunctionImpl : public FunctionImpl {
+public:
+BoundFunctionImpl(FunctionWrapper functionWrapper, const P0& p0, const P1& p1, const P2& p2)
+: m_functionWrapper(functionWrapper)
+, m_p0(p0)
+, m_p1(p1)
+, m_p2(p2)
+{
+RefAndDeref::ref(m_p0);
+}
+
+~BoundFunctionImpl()
+{
+RefAndDeref::deref(m_p0);
+}
+
+virtual typename FunctionWrapper::ResultType operator()()
+{
+return m_functionWrapper(m_p0, m_p1, m_p2);
+}
+
+private:
+FunctionWrapper m_functionWrapper;
+P0 m_p0;
+P1 m_p1;
+P2 m_p2;
+};
+
 class FunctionBase {
 public:
 bool isNull() const
@@ -317,8 +364,14 @@
 return Function::ResultType ()>(adoptRef(new BoundFunctionImpl, typename FunctionWrapper::ResultType (A1, A2)>(FunctionWrapper(function), a1, a2)));
 }
 
+template
+Function::ResultType ()> bind(FunctionType function, const A1& a1, const A2& a2, const A3& a3)
+{
+return Function::ResultType ()>(adoptRef(new BoundFunctionImpl, typename FunctionWrapper::ResultType (A1, A2, A3)>(FunctionWrapper(function), a1, a2, a3)));
 }
 
+}
+
 using WTF::Function;
 using WTF::bind;
 


Modified: trunk/Source/WebKit2/ChangeLog (102962 => 102963)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 18:50:59 UTC (rev 102962)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 18:56:16 UTC (rev 102963)
@@ -1,3 +1,23 @@
+2011-12-15  Anders Carlsson  
+
+EventDispatcher should handle wheel events on the connection queue
+https://bugs.webkit.org/show_bug.cgi?id=74627
+
+Reviewed by Andreas Kling.
+
+Send wheel events to the EventDispatcher, which handles them on the connection work queue, and
+immediately bounces them to the main thread (for now).
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::handleWheelEvent):
+(WebKit::WebPageProxy::didReceiveEvent):
+* WebProcess/WebPage/EventDispatcher.cpp:
+(WebKit::EventDispa

[webkit-changes] [102962] trunk

[beidson]

Title: [102962] trunk








Revision 102962
Author beid...@apple.com
Date 2011-12-15 10:50:59 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed, rolling out r102829.
http://trac.webkit.org/changeset/102829
https://bugs.webkit.org/show_bug.cgi?id=74533

Caused https://bugs.webkit.org/show_bug.cgi?id=74555

Source/WebCore: 

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::willMoveToNewOwnerDocument):
(WebCore::HTMLPlugInImageElement::didMoveToNewOwnerDocument):
(WebCore::HTMLPlugInImageElement::documentWillBecomeInactive):
(WebCore::HTMLPlugInImageElement::documentDidBecomeActive):
* html/HTMLPlugInImageElement.h:

LayoutTests: 

* media/crash-closing-page-with-media-as-plugin-fallback-expected.txt: Removed.
* media/crash-closing-page-with-media-as-plugin-fallback.html: Removed.
* media/resources/video-with-poster-as-object-fallback.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp
trunk/Source/WebCore/html/HTMLPlugInImageElement.h


Removed Paths

trunk/LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback-expected.txt
trunk/LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback.html
trunk/LayoutTests/media/resources/video-with-poster-as-object-fallback.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102961 => 102962)

--- trunk/LayoutTests/ChangeLog	2011-12-15 18:45:29 UTC (rev 102961)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 18:50:59 UTC (rev 102962)
@@ -1,3 +1,15 @@
+2011-12-15  Brady Eidson  
+
+Unreviewed, rolling out r102829.
+http://trac.webkit.org/changeset/102829
+https://bugs.webkit.org/show_bug.cgi?id=74533
+
+Caused https://bugs.webkit.org/show_bug.cgi?id=74555
+
+* media/crash-closing-page-with-media-as-plugin-fallback-expected.txt: Removed.
+* media/crash-closing-page-with-media-as-plugin-fallback.html: Removed.
+* media/resources/video-with-poster-as-object-fallback.html: Removed.
+
 2011-12-15  James Simonsen  
 
 [Navigation Timing] Use monotonicallyIncreasingTime() instead of currentTime()


Deleted: trunk/LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback-expected.txt (102961 => 102962)

--- trunk/LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback-expected.txt	2011-12-15 18:45:29 UTC (rev 102961)
+++ trunk/LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback-expected.txt	2011-12-15 18:50:59 UTC (rev 102962)
@@ -1,6 +0,0 @@
-This test makes sure that closing a window with a video element that has a poster image doesn't crash (radar 10576732 and https://bugs.webkit.org/show_bug.cgi?id=74533)
-If it doesn't crash, it passes.
-Click here to open test window
-Closed the window without crashing!
-
-


Deleted: trunk/LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback.html (102961 => 102962)

--- trunk/LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback.html	2011-12-15 18:45:29 UTC (rev 102961)
+++ trunk/LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback.html	2011-12-15 18:50:59 UTC (rev 102962)
@@ -1,41 +0,0 @@
-
-var childWindow;
-
-This test makes sure that closing a window with a video element that has a poster image doesn't crash (radar 10576732 and https://bugs.webkit.org/show_bug.cgi?id=74533)
-If it doesn't crash, it passes.
-
-Click here to open test window
-
-
-
-
-if (window.layoutTestController) {
-layoutTestController.dumpAsText();
-layoutTestController.waitUntilDone();
-layoutTestController.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
-layoutTestController.overridePreference("WebKitPageCacheSupportsPluginsPreferenceKey", 1);
-layoutTestController.setCanOpenWindows(true);
-layoutTestController.setCloseRemainingWindowsWhenComplete(true);
-var button = document.getElementById("button");
-eventSender.mouseMoveTo(button.offsetParent.offsetLeft + button.offsetLeft + button.offsetWidth / 2, button.offsetParent.offsetTop +  button.offsetTop + button.offsetHeight / 2);
-eventSender.mouseDown();
-eventSender.mouseUp();
-}
-
-function childLoaded()
-{
-childWindow.close();
-setTimeout("checkClosed()", 0);
-}
-
-function checkClosed()
-{
-if (childWindow.closed) {
-document.getElementById("result").innerText = "Closed the window without crashing!";
-if (window.layoutTestController)
-setTimeout("layoutTestController.notifyDone();", 0);
-}
-setTimeout("checkClosed()", 0);
-}
-
-


Deleted: trunk/LayoutTests/media/resources/video-with-poster-as-object-fallback.html (102961 => 102962)

--- trunk/LayoutTests/media/resources/video-with-poster-as-object-fallback.html	2011-12-15 18:45:29 UTC (rev 102961)
+++ trunk/LayoutTests/media/resources/video-with-poster-as-object-fallback.html	2011-12-15 18:50:59 UTC (rev 102962)
@@ -1,10 +0,0 @@
-
-

[webkit-changes] [102960] trunk/Source/WebKit2

[jonlee]

Title: [102960] trunk/Source/WebKit2








Revision 102960
Author jon...@apple.com
Date 2011-12-15 10:44:43 -0800 (Thu, 15 Dec 2011)


Log Message
[WK2] Extend WebNotification to include its origin https://bugs.webkit.org/show_bug.cgi?id=74615 

Reviewed by Sam Weinig.

* Shared/API/c/WKSecurityOrigin.h: Expose API that converts the security origin to database
identifier.
* Shared/API/c/WKSecurityOrigin.cpp:
(WKSecurityOriginCopyDatabaseIdentifier):

* UIProcess/Notifications/WebNotification.h: Extend WebNotification to include the origin.
(WebKit::WebNotification::create):
(WebKit::WebNotification::origin):
* UIProcess/Notifications/WebNotification.cpp: Remove unneeded encode() and decode() functions.
(WebKit::WebNotification::WebNotification):

* UIProcess/API/C/WKNotification.h: Expose WebNotification's origin().
* UIProcess/API/C/WKNotification.cpp:
(WKNotificationGetSecurityOrigin):

* UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Update show() to include the
origin of the notification.
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): Pass the notification's exec context's origin as
identifier.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.cpp
trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.h
trunk/Source/WebKit2/UIProcess/API/C/WKNotification.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKNotification.h
trunk/Source/WebKit2/UIProcess/Notifications/WebNotification.cpp
trunk/Source/WebKit2/UIProcess/Notifications/WebNotification.h
trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp
trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.h
trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.messages.in
trunk/Source/WebKit2/WebProcess/Notifications/WebNotificationManager.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102959 => 102960)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 18:39:51 UTC (rev 102959)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 18:44:43 UTC (rev 102960)
@@ -1,3 +1,35 @@
+2011-12-15  Jon Lee  
+
+[WK2] Extend WebNotification to include its origin
+https://bugs.webkit.org/show_bug.cgi?id=74615
+
+
+Reviewed by Sam Weinig.
+
+* Shared/API/c/WKSecurityOrigin.h: Expose API that converts the security origin to database
+identifier.
+* Shared/API/c/WKSecurityOrigin.cpp:
+(WKSecurityOriginCopyDatabaseIdentifier):
+
+* UIProcess/Notifications/WebNotification.h: Extend WebNotification to include the origin.
+(WebKit::WebNotification::create):
+(WebKit::WebNotification::origin):
+* UIProcess/Notifications/WebNotification.cpp: Remove unneeded encode() and decode() functions.
+(WebKit::WebNotification::WebNotification):
+
+* UIProcess/API/C/WKNotification.h: Expose WebNotification's origin().
+* UIProcess/API/C/WKNotification.cpp:
+(WKNotificationGetSecurityOrigin):
+
+* UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Update show() to include the
+origin of the notification.
+* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
+(WebKit::WebNotificationManagerProxy::show):
+* UIProcess/Notifications/WebNotificationManagerProxy.h:
+* WebProcess/Notifications/WebNotificationManager.cpp:
+(WebKit::WebNotificationManager::show): Pass the notification's exec context's origin as
+identifier.
+
 2011-12-15  Rafael Brandao  
 
 [Qt][WK2] Add test for download policy on navigation request


Modified: trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.cpp (102959 => 102960)

--- trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.cpp	2011-12-15 18:39:51 UTC (rev 102959)
+++ trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.cpp	2011-12-15 18:44:43 UTC (rev 102960)
@@ -48,6 +48,11 @@
 return toAPI(securityOrigin.release().leakRef());
 }
 
+WKStringRef WKSecurityOriginCopyDatabaseIdentifier(WKSecurityOriginRef securityOrigin)
+{
+return toCopiedAPI(toImpl(securityOrigin)->databaseIdentifier());
+}
+
 WKStringRef WKSecurityOriginCopyProtocol(WKSecurityOriginRef securityOrigin)
 {
 return toCopiedAPI(toImpl(securityOrigin)->protocol());


Modified: trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.h (102959 => 102960)

--- trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.h	2011-12-15 18:39:51 UTC (rev 102959)
+++ trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.h	2011-12-15 18:44:43 UTC (rev 102960)
@@ -37,6 +37,7 @@
 WK_EXPORT WKSecurityOriginRef WKSecurityOriginCreateFromIdentifier(WKStringRef identifier);
 WK_EXPORT WKSecurityOriginRef WKSecurityOriginCreate(WKStringRef protocol, WKStringRef host, int port);
 
+WK_EXPORT WKS

[webkit-changes] [102959] trunk/Source/WebKit2

[commit-queue]

Title: [102959] trunk/Source/WebKit2








Revision 102959
Author commit-qu...@webkit.org
Date 2011-12-15 10:39:51 -0800 (Thu, 15 Dec 2011)


Log Message
[Qt][WK2] Add test for download policy on navigation request
https://bugs.webkit.org/show_bug.cgi?id=74541

Patch by Rafael Brandao  on 2011-12-15
Reviewed by Tor Arne Vestbø.

* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Make it wait for a
downloadFinished signal to finish the test.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102958 => 102959)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 18:28:29 UTC (rev 102958)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 18:39:51 UTC (rev 102959)
@@ -1,3 +1,14 @@
+2011-12-15  Rafael Brandao  
+
+[Qt][WK2] Add test for download policy on navigation request
+https://bugs.webkit.org/show_bug.cgi?id=74541
+
+Reviewed by Tor Arne Vestbø.
+
+* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
+* UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Make it wait for a
+downloadFinished signal to finish the test.
+
 2011-12-15  Anders Carlsson  
 
 Move WorkQueue Mach handlers over to WTF::Function


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml (102958 => 102959)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml	2011-12-15 18:28:29 UTC (rev 102958)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml	2011-12-15 18:39:51 UTC (rev 102959)
@@ -3,16 +3,41 @@
 import QtWebKit 3.0
 
 Item {
+property int expectedLength: 0
+property int totalBytes: 0
+property bool shouldDownload: false
+
 DesktopWebView {
 id: webView
 width: 200
 height: 200
+
+signal downloadFinished()
+
 onNavigationRequested: {
-if (request.button == Qt.MiddleButton && request.modifiers & Qt.ControlModifier) {
+if (shouldDownload)
+request.action = ""
+else if (request.button == Qt.MiddleButton && request.modifiers & Qt.ControlModifier) {
 otherWebView.load(request.url)
 request.action = ""
 }
 }
+
+experimental.onDownloadRequested: {
+download.target = downloadItem
+expectedLength = downloadItem.expectedContentLength
+downloadItem.destinationPath = downloadItem.suggestedFilename
+downloadItem.start()
+}
+
+Connections {
+id: download
+ignoreUnknownSignals: true
+onSucceeded: {
+totalBytes = download.target.totalBytesReceived
+webView.downloadFinished()
+}
+}
 }
 
 SignalSpy {
@@ -31,6 +56,18 @@
 signalName: "loadSucceeded"
 }
 
+SignalSpy {
+id: downloadSpy
+target: webView.experimental
+signalName: "downloadRequested"
+}
+
+SignalSpy {
+id: downloadFinishedSpy
+target: webView
+signalName: "downloadFinished"
+}
+
 TestCase {
 name: "DesktopWebViewNavigationRequested"
 
@@ -43,6 +80,14 @@
 onTriggered: parent.when = true
 }
 
+function init() {
+spy.clear()
+otherSpy.clear()
+downloadSpy.clear()
+downloadFinishedSpy.clear()
+shouldDownload = false
+}
+
 function test_usePolicy() {
 webView.load(Qt.resolvedUrl("../common/test2.html"))
 spy.wait()
@@ -65,5 +110,22 @@
 compare(otherSpy.count, 1)
 compare(otherWebView.title, "Test page 1")
 }
+
+function test_downloadPolicy() {
+webView.load(Qt.resolvedUrl("../common/test2.html"))
+spy.wait()
+spy.clear()
+compare(spy.count, 0)
+downloadSpy.clear()
+downloadFinishedSpy.clear()
+expectedLength = 0
+shouldDownload = true
+mouseClick(webView, 100, 100, Qt.LeftButton)
+downloadSpy.wait()
+compare(downloadSpy.count, 1)
+downloadFinishedSpy.wait()
+compare(downloadFinishedSpy.count, 1)
+compare(totalBytes, expectedLength)
+}
 }
 }


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml (102958 => 102959)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml	2011-12-15 18:28:29 UTC (rev 102958)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/

[webkit-changes] [102958] trunk/Source/WebCore

[commit-queue]

Title: [102958] trunk/Source/WebCore








Revision 102958
Author commit-qu...@webkit.org
Date 2011-12-15 10:28:29 -0800 (Thu, 15 Dec 2011)


Log Message
plugin crash

[GTK] Plugins sometimes crash WebKitGTK+ with Gdk-CRITICAL **: gdk_window_get_toplevel: assertion `GDK_IS_WINDOW (window)' failed
https://bugs.webkit.org/show_bug.cgi?id=73719

Patch by Martin Robinson  on 2011-12-15
Reviewed by Philippe Normand.

No new tests. It's difficult to test or reproduce this exact situation
as it only occurs when running plugins under nspluginwrapper.

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformGetValue): Properly handle when the plugin tries to
get the window value when the GtkSocket is no longer realized.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102957 => 102958)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 18:21:31 UTC (rev 102957)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 18:28:29 UTC (rev 102958)
@@ -1,3 +1,19 @@
+2011-12-15  Martin Robinson  
+
+plugin crash
+
+[GTK] Plugins sometimes crash WebKitGTK+ with Gdk-CRITICAL **: gdk_window_get_toplevel: assertion `GDK_IS_WINDOW (window)' failed
+https://bugs.webkit.org/show_bug.cgi?id=73719
+
+Reviewed by Philippe Normand.
+
+No new tests. It's difficult to test or reproduce this exact situation
+as it only occurs when running plugins under nspluginwrapper.
+
+* plugins/gtk/PluginViewGtk.cpp:
+(WebCore::PluginView::platformGetValue): Properly handle when the plugin tries to
+get the window value when the GtkSocket is no longer realized.
+
 2011-12-15  Martin Kosiba  
 
 Fix find on web pages with -webkit-user-select: none for Chromium


Modified: trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp (102957 => 102958)

--- trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp	2011-12-15 18:21:31 UTC (rev 102957)
+++ trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp	2011-12-15 18:28:29 UTC (rev 102958)
@@ -710,7 +710,12 @@
 case NPNVnetscapeWindow: {
 GdkWindow* gdkWindow = gtk_widget_get_window(m_parentFrame->view()->hostWindow()->platformPageClient());
 #if defined(XP_UNIX)
-*static_cast(value) = GDK_WINDOW_XWINDOW(gdk_window_get_toplevel(gdkWindow));
+GdkWindow* toplevelWindow = gdk_window_get_toplevel(gdkWindow);
+if (!toplevelWindow) {
+*result = NPERR_GENERIC_ERROR;
+return true;
+}
+*static_cast(value) = GDK_WINDOW_XWINDOW(toplevelWindow);
 #elif defined(GDK_WINDOWING_WIN32)
 *static_cast(value) = GDK_WINDOW_HWND(gdkWindow);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102957] trunk/LayoutTests

[kbr]

Title: [102957] trunk/LayoutTests








Revision 102957
Author k...@google.com
Date 2011-12-15 10:21:31 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed Chromium expectations update. Mark another flaky compositing test.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102956 => 102957)

--- trunk/LayoutTests/ChangeLog	2011-12-15 18:20:00 UTC (rev 102956)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 18:21:31 UTC (rev 102957)
@@ -1,3 +1,9 @@
+2011-12-15  Kenneth Russell  
+
+Unreviewed Chromium expectations update. Mark another flaky compositing test.
+
+* platform/chromium/test_expectations.txt:
+
 2011-12-15  Martin Kosiba  
 
 Fix find on web pages with -webkit-user-select: none for Chromium


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102956 => 102957)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-15 18:20:00 UTC (rev 102956)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-15 18:21:31 UTC (rev 102957)
@@ -3983,6 +3983,7 @@
 BUGWK74050 : compositing/reflections/nested-reflection-on-overflow.html = IMAGE PASS
 BUGWK74050 : compositing/reflections/reflection-in-composited.html = IMAGE PASS
 BUGWK74050 : compositing/reflections/simple-composited-reflections.html = IMAGE PASS
+BUGWK74050 : compositing/reflections/nested-reflection-mask-change.html = IMAGE PASS
 
 BUGWK74055 LEOPARD : fast/canvas/canvas-largedraws.html = TIMEOUT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102956] trunk/Source/WebKit/chromium

[senorblanco]

Title: [102956] trunk/Source/WebKit/chromium








Revision 102956
Author senorbla...@chromium.org
Date 2011-12-15 10:20:00 -0800 (Thu, 15 Dec 2011)


Log Message
Enable CSS_FILTERS in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=74334

Reviewed by Kenneth Russell.

* features.gypi:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102955 => 102956)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 18:17:49 UTC (rev 102955)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 18:20:00 UTC (rev 102956)
@@ -1,3 +1,12 @@
+2011-12-15  Stephen White  
+
+Enable CSS_FILTERS in Chromium.
+https://bugs.webkit.org/show_bug.cgi?id=74334
+
+Reviewed by Kenneth Russell.
+
+* features.gypi:
+
 2011-12-15  Martin Kosiba  
 
 Fix find on web pages with -webkit-user-select: none for Chromium


Modified: trunk/Source/WebKit/chromium/features.gypi (102955 => 102956)

--- trunk/Source/WebKit/chromium/features.gypi	2011-12-15 18:17:49 UTC (rev 102955)
+++ trunk/Source/WebKit/chromium/features.gypi	2011-12-15 18:20:00 UTC (rev 102956)
@@ -37,6 +37,7 @@
   'ENABLE_BLOB_SLICE=1',
   'ENABLE_CHANNEL_MESSAGING=1',
   'ENABLE_CLIENT_BASED_GEOLOCATION=1',
+  'ENABLE_CSS_FILTERS=1',
   'ENABLE_DASHBOARD_SUPPORT=0',
   'ENABLE_DATA_TRANSFER_ITEMS=1',
   'ENABLE_DETAILS=1',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102955] trunk

[commit-queue]

Title: [102955] trunk








Revision 102955
Author commit-qu...@webkit.org
Date 2011-12-15 10:17:49 -0800 (Thu, 15 Dec 2011)


Log Message
Fix find on web pages with -webkit-user-select: none for Chromium
https://bugs.webkit.org/show_bug.cgi?id=72281

Patch by Martin Kosiba  on 2011-12-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding findStringAndScrollToVisible to Editor. This new method returns
the new match as a range rather than modify the active selection.

Test: editing/text-iterator/findString-selection-disabled.html

* editing/Editor.cpp:
(WebCore::Editor::findStringAndScrollToVisible):
* editing/Editor.h:

Source/WebKit/chromium:

This will make it possible to search for text that has
selection disabled (via the webkit-user-select attribute).

WebFrameImpl::find will use findStringAndScrollToVisible, which is
similar to findString except that it uses Range directly rather
than passing the find result in the active selection.

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::find):

Tools:

Provided a partial findString implementation. This doesn't support
all of the FindOptions since they're not exposed via WebFindOptions.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::findString):
* DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

Adding a layout test to verify that find works correctly on pages
that prevent text selection.

* editing/text-iterator/findString-selection-disabled-expected.txt: Added.
* editing/text-iterator/findString-selection-disabled.html: Added.
* platform/efl/Skipped:
* platform/gtk-wk2/Skipped:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-mac/Skipped:
* platform/qt-wk2/Skipped:
* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/LayoutTests/platform/gtk-wk2/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/mac-lion/Skipped
trunk/LayoutTests/platform/mac-snowleopard/Skipped
trunk/LayoutTests/platform/qt-5.0/Skipped
trunk/LayoutTests/platform/qt-mac/Skipped
trunk/LayoutTests/platform/qt-wk2/Skipped
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h


Added Paths

trunk/LayoutTests/editing/text-iterator/findString-selection-disabled-expected.txt
trunk/LayoutTests/editing/text-iterator/findString-selection-disabled.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102954 => 102955)

--- trunk/LayoutTests/ChangeLog	2011-12-15 18:15:14 UTC (rev 102954)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 18:17:49 UTC (rev 102955)
@@ -1,3 +1,25 @@
+2011-12-15  Martin Kosiba  
+
+Fix find on web pages with -webkit-user-select: none for Chromium
+https://bugs.webkit.org/show_bug.cgi?id=72281
+
+Reviewed by Ryosuke Niwa.
+
+Adding a layout test to verify that find works correctly on pages
+that prevent text selection.
+
+* editing/text-iterator/findString-selection-disabled-expected.txt: Added.
+* editing/text-iterator/findString-selection-disabled.html: Added.
+* platform/efl/Skipped:
+* platform/gtk-wk2/Skipped:
+* platform/mac-lion/Skipped:
+* platform/mac-snowleopard/Skipped:
+* platform/mac/Skipped:
+* platform/qt-5.0/Skipped:
+* platform/qt-mac/Skipped:
+* platform/qt-wk2/Skipped:
+* platform/wk2/Skipped:
+
 2011-12-15  Julien Chaffraix  
 
 Hardware-backed renderLayer could avoid repainting during a positioned movement layout


Added: trunk/LayoutTests/editing/text-iterator/findString-selection-disabled-expected.txt (0 => 102955)

--- trunk/LayoutTests/editing/text-iterator/findString-selection-disabled-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/text-iterator/findString-selection-disabled-expected.txt	2011-12-15 18:17:49 UTC (rev 102955)
@@ -0,0 +1,40 @@
+Searching for 'e' in 'Some sample text that can be searched' with selection enabled:
+PASS layoutTestController.findString('e', []) is true
+
+Searching for 'o' in 'Some sample text that can be searched' with selection enabled:
+PASS layoutTestController.findString('o', []) is true
+
+Searching for 'y' in 'Some sample text that can be searched' with selection enabled:
+PASS layoutTestController.findString('y', []) is false
+
+Searching for 't t' in 'Some sample text that can be searched' with selection enabled:
+PASS layoutTestController.findString('t t', []) is true
+
+Searching for 'mount' in 'insurmountable mountain' with selection enabl

[webkit-changes] [102954] trunk/Source/WebKit2

[andersca]

Title: [102954] trunk/Source/WebKit2








Revision 102954
Author ander...@apple.com
Date 2011-12-15 10:15:14 -0800 (Thu, 15 Dec 2011)


Log Message
Move WorkQueue Mach handlers over to WTF::Function
https://bugs.webkit.org/show_bug.cgi?id=74620

Reviewed by Sam Weinig.

* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
(CoreIPC::Connection::initializeDeadNameSource):
* Platform/WorkQueue.h:
* Platform/mac/WorkQueueMac.cpp:
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::eventHandler):
(WorkQueue::registerMachPortEventHandler):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp
trunk/Source/WebKit2/Platform/WorkQueue.h
trunk/Source/WebKit2/Platform/mac/WorkQueueMac.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102953 => 102954)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 18:05:19 UTC (rev 102953)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 18:15:14 UTC (rev 102954)
@@ -1,3 +1,19 @@
+2011-12-15  Anders Carlsson  
+
+Move WorkQueue Mach handlers over to WTF::Function
+https://bugs.webkit.org/show_bug.cgi?id=74620
+
+Reviewed by Sam Weinig.
+
+* Platform/CoreIPC/mac/ConnectionMac.cpp:
+(CoreIPC::Connection::open):
+(CoreIPC::Connection::initializeDeadNameSource):
+* Platform/WorkQueue.h:
+* Platform/mac/WorkQueueMac.cpp:
+(WorkQueue::EventSource::EventSource):
+(WorkQueue::EventSource::eventHandler):
+(WorkQueue::registerMachPortEventHandler):
+
 2011-12-14  Anders Carlsson  
 
 Add WTF::Function to wtf/Forward.h


Modified: trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp (102953 => 102954)

--- trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp	2011-12-15 18:05:19 UTC (rev 102953)
+++ trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp	2011-12-15 18:15:14 UTC (rev 102954)
@@ -104,11 +104,11 @@
 setMachPortQueueLength(m_receivePort, MACH_PORT_QLIMIT_LARGE);
 
 // Register the data available handler.
-m_connectionQueue.registerMachPortEventHandler(m_receivePort, WorkQueue::MachPortDataAvailable, WorkItem::create(this, &Connection::receiveSourceEventHandler));
+m_connectionQueue.registerMachPortEventHandler(m_receivePort, WorkQueue::MachPortDataAvailable, bind(&Connection::receiveSourceEventHandler, this));
 
 // If we have an exception port, register the data available handler and send over the port to the other end.
 if (m_exceptionPort) {
-m_connectionQueue.registerMachPortEventHandler(m_exceptionPort, WorkQueue::MachPortDataAvailable, WorkItem::create(this, &Connection::exceptionSourceEventHandler));
+m_connectionQueue.registerMachPortEventHandler(m_exceptionPort, WorkQueue::MachPortDataAvailable, bind(&Connection::exceptionSourceEventHandler, this));
 
 deprecatedSend(CoreIPCMessage::SetExceptionPort, 0, MachPort(m_exceptionPort, MACH_MSG_TYPE_MAKE_SEND));
 }
@@ -225,7 +225,7 @@
 
 void Connection::initializeDeadNameSource()
 {
-m_connectionQueue.registerMachPortEventHandler(m_sendPort, WorkQueue::MachPortDeadNameNotification, WorkItem::create(this, &Connection::connectionDidClose));
+m_connectionQueue.registerMachPortEventHandler(m_sendPort, WorkQueue::MachPortDeadNameNotification, bind(&Connection::connectionDidClose, this));
 }
 
 static PassOwnPtr createArgumentDecoder(mach_msg_header_t* header)


Modified: trunk/Source/WebKit2/Platform/WorkQueue.h (102953 => 102954)

--- trunk/Source/WebKit2/Platform/WorkQueue.h	2011-12-15 18:05:19 UTC (rev 102953)
+++ trunk/Source/WebKit2/Platform/WorkQueue.h	2011-12-15 18:15:14 UTC (rev 102954)
@@ -87,9 +87,9 @@
 MachPortDeadNameNotification
 };
 
-// Will execute the given work item whenever the given mach port event fires.
+// Will execute the given function whenever the given mach port event fires.
 // Note that this will adopt the mach port and destroy it when the work queue is invalidated.
-void registerMachPortEventHandler(mach_port_t, MachPortEventType, PassOwnPtr);
+void registerMachPortEventHandler(mach_port_t, MachPortEventType, const Function&);
 void unregisterMachPortEventHandler(mach_port_t);
 #elif PLATFORM(WIN)
 void registerHandle(HANDLE, PassOwnPtr);


Modified: trunk/Source/WebKit2/Platform/mac/WorkQueueMac.cpp (102953 => 102954)

--- trunk/Source/WebKit2/Platform/mac/WorkQueueMac.cpp	2011-12-15 18:05:19 UTC (rev 102953)
+++ trunk/Source/WebKit2/Platform/mac/WorkQueueMac.cpp	2011-12-15 18:15:14 UTC (rev 102954)
@@ -60,10 +60,10 @@
 
 class WorkQueue::EventSource {
 public:
-EventSource(MachPortEventType eventType, dispatch_source_t dispatchSource, PassOwnPtr workItem)
+EventSource(MachPortEventType eventType, dispatch_source_t dispatchSource, const Function& function)
 : m_eventType(eventType)
 , m_dispatchSource(dispatchSource)
-, m_workItem(workItem)
+, m_function(function

[webkit-changes] [102953] trunk/Source

[andersca]

Title: [102953] trunk/Source








Revision 102953
Author ander...@apple.com
Date 2011-12-15 10:05:19 -0800 (Thu, 15 Dec 2011)


Log Message
Add WTF::Function to wtf/Forward.h
https://bugs.webkit.org/show_bug.cgi?id=74576

Reviewed by Adam Roben.

Source/_javascript_Core:

* jsc.cpp:
Work around a name conflict in the readline library.

* wtf/Forward.h:
Add Function.

Source/WebCore:

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Add a JSC:: qualifier to the Function flags to avoid ambiguities.

Source/WebKit2:

* Platform/RunLoop.h:
* Platform/WorkQueue.h:
Remove forward declarations and just include wtf/Forward.h.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/wtf/Forward.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/RunLoop.h
trunk/Source/WebKit2/Platform/WorkQueue.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102952 => 102953)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-15 17:55:47 UTC (rev 102952)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-15 18:05:19 UTC (rev 102953)
@@ -1,3 +1,16 @@
+2011-12-14  Anders Carlsson  
+
+Add WTF::Function to wtf/Forward.h
+https://bugs.webkit.org/show_bug.cgi?id=74576
+
+Reviewed by Adam Roben.
+
+* jsc.cpp:
+Work around a name conflict in the readline library.
+
+* wtf/Forward.h:
+Add Function.
+
 2011-12-15  Igor Oliveira  
 
 [Qt] Support requestAnimationFrame API


Modified: trunk/Source/_javascript_Core/jsc.cpp (102952 => 102953)

--- trunk/Source/_javascript_Core/jsc.cpp	2011-12-15 17:55:47 UTC (rev 102952)
+++ trunk/Source/_javascript_Core/jsc.cpp	2011-12-15 18:05:19 UTC (rev 102953)
@@ -43,8 +43,12 @@
 #endif
 
 #if HAVE(READLINE)
+// readline/history.h has a Function typedef which conflicts with the WTF::Function template from WTF/Forward.h
+// We #define it to something else to avoid this conflict.
+#define Function ReadlineFunction
 #include 
 #include 
+#undef Function
 #endif
 
 #if HAVE(SYS_TIME_H)


Modified: trunk/Source/_javascript_Core/wtf/Forward.h (102952 => 102953)

--- trunk/Source/_javascript_Core/wtf/Forward.h	2011-12-15 17:55:47 UTC (rev 102952)
+++ trunk/Source/_javascript_Core/wtf/Forward.h	2011-12-15 18:05:19 UTC (rev 102953)
@@ -24,6 +24,7 @@
 #include 
 
 namespace WTF {
+template class Function;
 template class ListRefPtr;
 template class OwnArrayPtr;
 template class OwnPtr;
@@ -54,6 +55,7 @@
 class Uint32Array;
 }
 
+using WTF::Function;
 using WTF::ListRefPtr;
 using WTF::OwnArrayPtr;
 using WTF::OwnPtr;


Modified: trunk/Source/WebCore/ChangeLog (102952 => 102953)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 17:55:47 UTC (rev 102952)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 18:05:19 UTC (rev 102953)
@@ -1,3 +1,14 @@
+2011-12-14  Anders Carlsson  
+
+Add WTF::Function to wtf/Forward.h
+https://bugs.webkit.org/show_bug.cgi?id=74576
+
+Reviewed by Adam Roben.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation):
+Add a JSC:: qualifier to the Function flags to avoid ambiguities.
+
 2011-12-15  Julien Chaffraix  
 
 Hardware-backed renderLayer could avoid repainting during a positioned movement layout


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (102952 => 102953)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-12-15 17:55:47 UTC (rev 102952)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-12-15 18:05:19 UTC (rev 102953)
@@ -1417,7 +1417,7 @@
 my @specials = ();
 push(@specials, "DontDelete") unless $function->signature->extendedAttributes->{"Deletable"};
 push(@specials, "DontEnum") if $function->signature->extendedAttributes->{"DontEnum"};
-push(@specials, "Function");
+push(@specials, "JSC::Function");
 my $special = (@specials > 0) ? join(" | ", @specials) : "0";
 push(@hashSpecials, $special);
 
@@ -1481,7 +1481,7 @@
 my @specials = ();
 push(@specials, "DontDelete") unless $function->signature->extendedAttributes->{"Deletable"};
 push(@specials, "DontEnum") if $function->signature->extendedAttributes->{"DontEnum"};
-push(@specials, "Function");
+push(@specials, "JSC::Function");
 my $special = (@specials > 0) ? join(" | ", @specials) : "0";
 push(@hashSpecials, $special);
 


Modified: trunk/Source/WebKit2/ChangeLog (102952 => 102953)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 17:55:47 UTC (rev 102952)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 18:05:19 UTC (rev 102953)
@@ -1,3 +1,14 @@
+2011-12-14  Anders Carlsson  
+
+Add WTF::Function to wtf/Forward.h
+https://bugs.webkit.org/show_bug.cgi?id=74576
+
+Reviewed by 

[webkit-changes] [102951] trunk/Source/WebCore

[antti]

Title: [102951] trunk/Source/WebCore








Revision 102951
Author an...@apple.com
Date 2011-12-15 09:53:46 -0800 (Thu, 15 Dec 2011)


Log Message
Don't invoke CSSStyleSelector::pushParent before Text::recalcTextStyle
https://bugs.webkit.org/show_bug.cgi?id=74575

Reviewed by Darin Adler.

Text::recalcTextStyle never enters the style selector so pushing the state is not necessary

* dom/Element.cpp:
(WebCore::Element::recalcStyle):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102950 => 102951)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 17:50:41 UTC (rev 102950)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 17:53:46 UTC (rev 102951)
@@ -1,3 +1,15 @@
+2011-12-15  Antti Koivisto  
+
+Don't invoke CSSStyleSelector::pushParent before Text::recalcTextStyle
+https://bugs.webkit.org/show_bug.cgi?id=74575
+
+Reviewed by Darin Adler.
+
+Text::recalcTextStyle never enters the style selector so pushing the state is not necessary
+
+* dom/Element.cpp:
+(WebCore::Element::recalcStyle):
+
 2011-12-15  Chris Marrin  
 
 Fixed error in Target.pri.


Modified: trunk/Source/WebCore/dom/Element.cpp (102950 => 102951)

--- trunk/Source/WebCore/dom/Element.cpp	2011-12-15 17:50:41 UTC (rev 102950)
+++ trunk/Source/WebCore/dom/Element.cpp	2011-12-15 17:53:46 UTC (rev 102951)
@@ -1138,7 +1138,6 @@
 bool forceCheckOfAnyElementSibling = false;
 for (Node *n = firstChild(); n; n = n->nextSibling()) {
 if (n->isTextNode()) {
-parentPusher.push();
 static_cast(n)->recalcTextStyle(change);
 continue;
 } 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102950] trunk

[kbr]

Title: [102950] trunk








Revision 102950
Author k...@google.com
Date 2011-12-15 09:50:41 -0800 (Thu, 15 Dec 2011)


Log Message
[chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
https://bugs.webkit.org/show_bug.cgi?id=74581

Reviewed by Darin Fisher.

Source/WebKit/chromium: 

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setPageCacheSupportsPlugins):
* src/WebSettingsImpl.h:

Tools: 

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::overridePreference):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:

LayoutTests: 

Unskip one test which now passes. The other one will continue to
be covered under the other bug.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp
trunk/Tools/DumpRenderTree/chromium/WebPreferences.h




Diff

Modified: trunk/LayoutTests/ChangeLog (102949 => 102950)

--- trunk/LayoutTests/ChangeLog	2011-12-15 17:33:03 UTC (rev 102949)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 17:50:41 UTC (rev 102950)
@@ -1,3 +1,15 @@
+2011-12-15  Kenneth Russell  
+
+[chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
+https://bugs.webkit.org/show_bug.cgi?id=74581
+
+Reviewed by Darin Fisher.
+
+Unskip one test which now passes. The other one will continue to
+be covered under the other bug.
+
+* platform/chromium/test_expectations.txt:
+
 2011-12-15  Alexander Pavlov  
 
 Web Inspector: #hex colors are not highlighted in CSS files


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102949 => 102950)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-15 17:33:03 UTC (rev 102949)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-15 17:50:41 UTC (rev 102950)
@@ -3999,7 +3999,6 @@
 BUGWK74317 LINUX : transitions/cross-fade-border-image.html = PASS CRASH
 
 BUGWK74357 SKIP : plugins/netscape-plugin-page-cache-works.html = TEXT TIMEOUT
-BUGWK74357 SKIP : media/crash-closing-page-with-media-as-plugin-fallback.html = TEXT
 
 BUGWK74374 WIN : fast/forms/select-listbox-multiple-no-focusring.html = PASS IMAGE
 


Modified: trunk/Source/WebKit/chromium/ChangeLog (102949 => 102950)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 17:33:03 UTC (rev 102949)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 17:50:41 UTC (rev 102950)
@@ -1,3 +1,15 @@
+2011-12-15  Kenneth Russell  
+
+[chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
+https://bugs.webkit.org/show_bug.cgi?id=74581
+
+Reviewed by Darin Fisher.
+
+* public/WebSettings.h:
+* src/WebSettingsImpl.cpp:
+(WebKit::WebSettingsImpl::setPageCacheSupportsPlugins):
+* src/WebSettingsImpl.h:
+
 2011-12-15  Andrey Kosyakov  
 
 Web Inspector: [Chromium] add support to inspector test suite to fetch test execution results from console


Modified: trunk/Source/WebKit/chromium/public/WebSettings.h (102949 => 102950)

--- trunk/Source/WebKit/chromium/public/WebSettings.h	2011-12-15 17:33:03 UTC (rev 102949)
+++ trunk/Source/WebKit/chromium/public/WebSettings.h	2011-12-15 17:50:41 UTC (rev 102950)
@@ -80,6 +80,7 @@
 virtual void setUserStyleSheetLocation(const WebURL&) = 0;
 virtual void setAuthorAndUserStylesEnabled(bool) = 0;
 virtual void setUsesPageCache(bool) = 0;
+virtual void setPageCacheSupportsPlugins(bool) = 0;
 virtual void setDownloadableBinaryFontsEnabled(bool) = 0;
 virtual void setJavaScriptCanAccessClipboard(bool) = 0;
 virtual void setXSSAuditorEnabled(bool) = 0;


Modified: trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp (102949 => 102950)

--- trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp	2011-12-15 17:33:03 UTC (rev 102949)
+++ trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp	2011-12-15 17:50:41 UTC (rev 102950)
@@ -199,6 +199,11 @@
 m_settings->setUsesPageCache(usesPageCache);
 }
 
+void WebSettingsImpl::setPageCacheSupportsPlugins(bool pageCacheSupportsPlugins)
+{
+m_settings->setPageCacheSupportsPlugins(pageCacheSupportsPlugins);
+}
+
 void WebSettingsImpl::setDownloadableBinaryFontsEnabled(bool enabled)
 {
 m_settings->setDownloadableBinaryFontsEnabled(enabled);


Modified: trunk/Source/WebKit/chromium/src/WebSettingsImpl.h (102949 => 102950)

--- trunk/Source/WebKit/chromium/src/WebSettingsImpl.h	2011-12-15 17:33:03 UTC (rev 102949)
+++ trunk/Source/WebKit/chromium/src/W

[webkit-changes] [102949] trunk/Source/WebKit

[commit-queue]

Title: [102949] trunk/Source/WebKit








Revision 102949
Author commit-qu...@webkit.org
Date 2011-12-15 09:33:03 -0800 (Thu, 15 Dec 2011)


Log Message
Patch by Adam Treat  on 2011-12-15
Reviewed by Rob Buis.

https://bugs.webkit.org/show_bug.cgi?id=74609
PR 122703

For certain configurations of webpage content and zoom level we were
failing to produce a valid backingstore matrix by being to strict on
whether a given matrix fits the preferred matrix orientation.
This patch fixes this by insisting on storing a candidate divisor
whether or not it agrees with the preferred matrix orientation and then
comparing all subsequent divisors.

* blackberry/Api/BackingStore.cpp:
(BlackBerry::WebKit::divisorIsPerfectWidth):
(BlackBerry::WebKit::divisorIsPerfectHeight):
(BlackBerry::WebKit::divisorIsPreferredDirection):
(BlackBerry::WebKit::bestDivisor):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/blackberry/Api/BackingStore.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (102948 => 102949)

--- trunk/Source/WebKit/ChangeLog	2011-12-15 17:21:56 UTC (rev 102948)
+++ trunk/Source/WebKit/ChangeLog	2011-12-15 17:33:03 UTC (rev 102949)
@@ -1,3 +1,23 @@
+2011-12-15  Adam Treat  
+
+Reviewed by Rob Buis.
+
+https://bugs.webkit.org/show_bug.cgi?id=74609
+PR 122703
+
+For certain configurations of webpage content and zoom level we were
+failing to produce a valid backingstore matrix by being to strict on
+whether a given matrix fits the preferred matrix orientation.
+This patch fixes this by insisting on storing a candidate divisor
+whether or not it agrees with the preferred matrix orientation and then
+comparing all subsequent divisors.
+
+* blackberry/Api/BackingStore.cpp:
+(BlackBerry::WebKit::divisorIsPerfectWidth):
+(BlackBerry::WebKit::divisorIsPerfectHeight):
+(BlackBerry::WebKit::divisorIsPreferredDirection):
+(BlackBerry::WebKit::bestDivisor):
+
 2011-12-14  Jacky Jiang  
 
 [BlackBerry] Refactor code and add some debug messages in backing store


Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (102948 => 102949)

--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2011-12-15 17:21:56 UTC (rev 102948)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2011-12-15 17:33:03 UTC (rev 102949)
@@ -86,6 +86,23 @@
 return divisors;
 }
 
+static bool divisorIsPerfectWidth(Divisor divisor, Platform::IntSize size, int tileWidth)
+{
+return size.width() <= divisor.first * tileWidth && abs(size.width() - divisor.first * tileWidth) < tileWidth;
+}
+
+static bool divisorIsPerfectHeight(Divisor divisor, Platform::IntSize size, int tileHeight)
+{
+return size.height() <= divisor.second * tileHeight && abs(size.height() - divisor.second * tileHeight) < tileHeight;
+}
+
+static bool divisorIsPreferredDirection(Divisor divisor, BackingStorePrivate::TileMatrixDirection direction)
+{
+if (direction == BackingStorePrivate::Vertical)
+return divisor.second > divisor.first;
+return divisor.first > divisor.second;
+}
+
 // Compute best divisor given the ratio determined by size.
 static Divisor bestDivisor(Platform::IntSize size, int tileWidth, int tileHeight,
int minimumNumberOfTilesWide, int minimumNumberOfTilesHigh,
@@ -110,35 +127,34 @@
 for (size_t i = 0; i < divisorList.size(); ++i) {
 Divisor divisor = divisorList[i];
 
-bool divisorWidthIsPerfect = size.width() <= divisor.first * tileWidth && abs(size.width() - divisor.first * tileWidth) < tileWidth;
-bool divisorHeightIsPerfect = size.height() <= divisor.second * tileHeight && abs(size.height() - divisor.second * tileHeight) < tileHeight;
-bool divisorWidthIsValid = divisor.first >= minimumNumberOfTilesWide || divisorWidthIsPerfect;
-bool divisorHeightIsValid = divisor.second >= minimumNumberOfTilesHigh || divisorHeightIsPerfect;
-if (!divisorWidthIsValid || !divisorHeightIsValid)
+const bool isPerfectWidth = divisorIsPerfectWidth(divisor, size, tileWidth);
+const bool isPerfectHeight = divisorIsPerfectHeight(divisor, size, tileHeight);
+const bool isValidWidth = divisor.first >= minimumNumberOfTilesWide || isPerfectWidth;
+const bool isValidHeight = divisor.second >= minimumNumberOfTilesHigh || isPerfectHeight;
+if (!isValidWidth || !isValidHeight)
 continue;
 
-if (divisor.first > divisor.second && direction == BackingStorePrivate::Vertical && !divisorHeightIsPerfect)
-continue;
-
-if (divisor.second > divisor.first && direction == BackingStorePrivate::Horizontal && !divisorWidthIsPerfect)
-continue;
-
-if (divisorWidthIsPerfect || divisorHeightIsPerfect) {
+if (isPerfectWidth || isPerfectHeight) {
 bestDivisor = divisor; // Found a perfect fit!
 #if DEBUG_TILEMATRIX
-BlackBer

[webkit-changes] [102948] trunk/Source/WebKit2

[commit-queue]

Title: [102948] trunk/Source/WebKit2








Revision 102948
Author commit-qu...@webkit.org
Date 2011-12-15 09:21:56 -0800 (Thu, 15 Dec 2011)


Log Message
[Qt][WK2] Move WebPreferences into experimental
https://bugs.webkit.org/show_bug.cgi?id=74404

Patch by Rafael Brandao  on 2011-12-15
Reviewed by Tor Arne Vestbø.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::preferences):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102947 => 102948)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 17:09:55 UTC (rev 102947)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 17:21:56 UTC (rev 102948)
@@ -1,3 +1,16 @@
+2011-12-15  Rafael Brandao  
+
+[Qt][WK2] Move WebPreferences into experimental
+https://bugs.webkit.org/show_bug.cgi?id=74404
+
+Reviewed by Tor Arne Vestbø.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewExperimental::preferences):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
+* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
+
 2011-12-15  Carlos Garcia Campos  
 
 [GTK] Add WebKitWindowProperties to WebKit2 GTK+ API


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (102947 => 102948)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-12-15 17:09:55 UTC (rev 102947)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-12-15 17:21:56 UTC (rev 102948)
@@ -617,6 +617,14 @@
 return d->promptDialog;
 }
 
+QWebPreferences* QQuickWebViewExperimental::preferences() const
+{
+QQuickWebViewPrivate* const d = d_ptr;
+if (!d->preferences)
+d->preferences = adoptPtr(QWebPreferencesPrivate::createPreferences(d));
+return d->preferences.get();
+}
+
 void QQuickWebViewExperimental::setPromptDialog(QDeclarativeComponent* promptDialog)
 {
 Q_D(QQuickWebView);
@@ -771,14 +779,6 @@
 return d->webPageProxy->pageTitle();
 }
 
-QWebPreferences* QQuickWebView::preferences() const
-{
-QQuickWebViewPrivate* const d = d_ptr.data();
-if (!d->preferences)
-d->preferences = adoptPtr(QWebPreferencesPrivate::createPreferences(d));
-return d->preferences.get();
-}
-
 QQuickWebViewExperimental* QQuickWebView::experimental() const
 {
 return m_experimental;


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h (102947 => 102948)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2011-12-15 17:09:55 UTC (rev 102947)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2011-12-15 17:21:56 UTC (rev 102948)
@@ -58,7 +58,6 @@
 Q_PROPERTY(bool canGoForward READ canGoForward NOTIFY navigationStateChanged FINAL)
 Q_PROPERTY(bool loading READ loading NOTIFY navigationStateChanged FINAL)
 Q_PROPERTY(bool canReload READ canReload NOTIFY navigationStateChanged FINAL)
-Q_PROPERTY(QWebPreferences* preferences READ preferences CONSTANT FINAL)
 Q_PROPERTY(QQuickWebPage* page READ page CONSTANT FINAL)
 Q_ENUMS(NavigationRequestAction)
 Q_ENUMS(ErrorType)
@@ -88,7 +87,6 @@
 bool loading() const;
 bool canReload() const;
 
-QWebPreferences* preferences() const;
 QQuickWebPage* page();
 
 QQuickWebViewExperimental* experimental() const;
@@ -173,6 +171,7 @@
 Q_PROPERTY(QDeclarativeComponent* confirmDialog READ confirmDialog WRITE setConfirmDialog NOTIFY confirmDialogChanged)
 Q_PROPERTY(QDeclarativeComponent* promptDialog READ promptDialog WRITE setPromptDialog NOTIFY promptDialogChanged)
 Q_PROPERTY(QDeclarativeComponent* itemSelector READ itemSelector WRITE setItemSelector NOTIFY itemSelectorChanged)
+Q_PROPERTY(QWebPreferences* preferences READ preferences CONSTANT FINAL)
 Q_PROPERTY(bool useTraditionalDesktopBehaviour READ useTraditionalDesktopBehaviour WRITE setUseTraditionalDesktopBehaviour)
 Q_PROPERTY(QWebViewportInfo* viewportInfo READ viewportInfo CONSTANT FINAL)
 
@@ -191,6 +190,7 @@
 
 QWebViewportInfo* viewportInfo();
 
+QWebPreferences* preferences() const;
 bool useTraditionalDesktopBehaviour() const;
 QWebNavigationHistory* navigationHistory() const;
 


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml (102947 => 102948)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml	2011-12-15 17:09:55 UTC (rev 102947)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopB

[webkit-changes] [102946] trunk/Source/WebCore

[cmarrin]

Title: [102946] trunk/Source/WebCore








Revision 102946
Author cmar...@apple.com
Date 2011-12-15 09:09:44 -0800 (Thu, 15 Dec 2011)


Log Message
Fixed error in Target.pri.

Unreviewed.

* Target.pri:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (102945 => 102946)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 16:58:26 UTC (rev 102945)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 17:09:44 UTC (rev 102946)
@@ -1,3 +1,12 @@
+2011-12-15  Chris Marrin  
+
+Fixed error in Target.pri.
+
+Unreviewed.
+
+
+* Target.pri:
+
 2011-12-15  Alexander Pavlov  
 
 Web Inspector: #hex colors are not highlighted in CSS files


Modified: trunk/Source/WebCore/Target.pri (102945 => 102946)

--- trunk/Source/WebCore/Target.pri	2011-12-15 16:58:26 UTC (rev 102945)
+++ trunk/Source/WebCore/Target.pri	2011-12-15 17:09:44 UTC (rev 102946)
@@ -3254,7 +3254,7 @@
 platform/graphics/filters/FETile.cpp \
 platform/graphics/filters/FETurbulence.cpp \
 platform/graphics/filters/FilterOperations.cpp \
-platform/graphics/filters/FilterOperation.cpp
+platform/graphics/filters/FilterOperation.cpp \
 platform/graphics/filters/FilterEffect.cpp \
 platform/graphics/filters/LightSource.cpp \
 platform/graphics/filters/PointLightSource.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102947] trunk/Source/WebCore/ChangeLog

[cmarrin]

Title: [102947] trunk/Source/WebCore/ChangeLog








Revision 102947
Author cmar...@apple.com
Date 2011-12-15 09:09:55 -0800 (Thu, 15 Dec 2011)


Log Message
Fixed error in Target.pri.

Unreviewed.

* Target.pri:

Modified Paths

trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (102946 => 102947)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 17:09:44 UTC (rev 102946)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 17:09:55 UTC (rev 102947)
@@ -4,7 +4,6 @@
 
 Unreviewed.
 
-
 * Target.pri:
 
 2011-12-15  Alexander Pavlov  






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102945] branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp

[leviw]

Title: [102945] branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp








Revision 102945
Author le...@chromium.org
Date 2011-12-15 08:58:26 -0800 (Thu, 15 Dec 2011)


Log Message
Correcting positioning of scrollbars to use pixelSnapped logic instead of enclosingIntRect

Modified Paths

branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp (102944 => 102945)

--- branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp	2011-12-15 16:55:05 UTC (rev 102944)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp	2011-12-15 16:58:26 UTC (rev 102945)
@@ -2118,7 +2118,7 @@
 if (!box)
 return;
 
-const IntRect borderBox = enclosingIntRect(box->borderBoxRect());
+const IntRect borderBox = pixelSnappedIntRect(box->borderBoxRect());
 const IntRect& scrollCorner = scrollCornerRect();
 IntRect absBounds(borderBox.location() + roundedIntSize(offsetFromLayer), borderBox.size());
 if (m_vBar)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102944] branches/subpixellayout/Source/WebCore

[leviw]

Title: [102944] branches/subpixellayout/Source/WebCore








Revision 102944
Author le...@chromium.org
Date 2011-12-15 08:55:05 -0800 (Thu, 15 Dec 2011)


Log Message
* Changing Renderer offsetLeft/Top/Width/Height to be LayoutUnits. Adding pixelSnapped versions as well.
* Changing AppUnit version of adjustForAbsoluteZoom to return an int and behave like the int version. This is
  needed to get zoomed values to read back properly.
* Moved snapSizeToPixel to AppUnit.h.

Modified Paths

branches/subpixellayout/Source/WebCore/inspector/DOMNodeHighlighter.cpp
branches/subpixellayout/Source/WebCore/page/PrintContext.cpp
branches/subpixellayout/Source/WebCore/platform/AppUnit.h
branches/subpixellayout/Source/WebCore/rendering/RenderBox.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderBox.h
branches/subpixellayout/Source/WebCore/rendering/RenderBoxModelObject.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderBoxModelObject.h
branches/subpixellayout/Source/WebCore/rendering/RenderInline.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderInline.h
branches/subpixellayout/Source/WebCore/rendering/RenderObject.h
branches/subpixellayout/Source/WebCore/rendering/RenderTheme.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderTreeAsText.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderVideo.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderVideo.h
branches/subpixellayout/Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
branches/subpixellayout/Source/WebCore/rendering/mathml/RenderMathMLBlock.h
branches/subpixellayout/Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
branches/subpixellayout/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp
branches/subpixellayout/Source/WebCore/rendering/mathml/RenderMathMLRow.cpp
branches/subpixellayout/Source/WebCore/rendering/mathml/RenderMathMLSquareRoot.cpp
branches/subpixellayout/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp
branches/subpixellayout/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp
branches/subpixellayout/Source/WebCore/rendering/style/RenderStyle.h




Diff

Modified: branches/subpixellayout/Source/WebCore/inspector/DOMNodeHighlighter.cpp (102943 => 102944)

--- branches/subpixellayout/Source/WebCore/inspector/DOMNodeHighlighter.cpp	2011-12-15 16:46:16 UTC (rev 102943)
+++ branches/subpixellayout/Source/WebCore/inspector/DOMNodeHighlighter.cpp	2011-12-15 16:55:05 UTC (rev 102944)
@@ -269,11 +269,11 @@
 
 RenderBoxModelObject* modelObject = renderer->isBoxModelObject() ? toRenderBoxModelObject(renderer) : 0;
 
-String widthNumberPart = " " + String::number(modelObject ? adjustForAbsoluteZoom(modelObject->offsetWidth(), modelObject) : boundingBox.width().toFloat());
+String widthNumberPart = " " + String::number(modelObject ? adjustForAbsoluteZoom(modelObject->pixelSnappedOffsetWidth(), modelObject) : boundingBox.width().toFloat());
 nodeTitle.append(widthNumberPart);
 nodeTitle.append(pxString);
 nodeTitle.append(timesString);
-String heightNumberPart = String::number(modelObject ? adjustForAbsoluteZoom(modelObject->offsetHeight(), modelObject) : boundingBox.height().toFloat());
+String heightNumberPart = String::number(modelObject ? adjustForAbsoluteZoom(modelObject->pixelSnappedOffsetHeight(), modelObject) : boundingBox.height().toFloat());
 nodeTitle.append(heightNumberPart);
 nodeTitle.append(pxString);
 


Modified: branches/subpixellayout/Source/WebCore/page/PrintContext.cpp (102943 => 102944)

--- branches/subpixellayout/Source/WebCore/page/PrintContext.cpp	2011-12-15 16:46:16 UTC (rev 102943)
+++ branches/subpixellayout/Source/WebCore/page/PrintContext.cpp	2011-12-15 16:55:05 UTC (rev 102944)
@@ -249,8 +249,8 @@
 scaledPageSize.scale(frame->view()->contentsSize().width() / pageRect.width());
 printContext.computePageRectsWithPageSize(scaledPageSize, false);
 
-int top = box->offsetTop();
-int left = box->offsetLeft();
+int top = box->pixelSnappedOffsetTop();
+int left = box->pixelSnappedOffsetLeft();
 size_t pageNumber = 0;
 for (; pageNumber < printContext.pageCount(); pageNumber++) {
 const IntRect& page = printContext.pageRect(pageNumber);


Modified: branches/subpixellayout/Source/WebCore/platform/AppUnit.h (102943 => 102944)

--- branches/subpixellayout/Source/WebCore/platform/AppUnit.h	2011-12-15 16:46:16 UTC (rev 102943)
+++ branches/subpixellayout/Source/WebCore/platform/AppUnit.h	2011-12-15 16:55:05 UTC (rev 102944)
@@ -497,7 +497,12 @@
 return a;
 }
 
+inline int snapSizeToPixel(AppUnit size, AppUnit location) 
+{
+return (location + size).round() - location.round();
+}
 
+
 } // namespace WebCore
 
 namespace std {


Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBox.cpp (102943 => 102944)

--- branches/subpixellayout/Source/WebCore/rendering/RenderBox.cpp	2011-12-15 16:46:16 UTC (rev 102943)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBox.cpp	

[webkit-changes] [102941] trunk/Tools

[kenneth]

Title: [102941] trunk/Tools








Revision 102941
Author kenn...@webkit.org
Date 2011-12-15 08:40:41 -0800 (Thu, 15 Dec 2011)


Log Message
[Qt] Improve the look of the viewport info overlay

Reviewed by Tor Arne Vestbø.

* MiniBrowser/qt/qml/ViewportInfoItem.qml:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/qml/ViewportInfoItem.qml




Diff

Modified: trunk/Tools/ChangeLog (102940 => 102941)

--- trunk/Tools/ChangeLog	2011-12-15 16:40:19 UTC (rev 102940)
+++ trunk/Tools/ChangeLog	2011-12-15 16:40:41 UTC (rev 102941)
@@ -1,3 +1,11 @@
+2011-12-15  Kenneth Rohde Christiansen  
+
+[Qt] Improve the look of the viewport info overlay
+
+Reviewed by Tor Arne Vestbø.
+
+* MiniBrowser/qt/qml/ViewportInfoItem.qml:
+
 2011-12-15  Igor Oliveira  
 
 [Qt] Support requestAnimationFrame API


Modified: trunk/Tools/MiniBrowser/qt/qml/ViewportInfoItem.qml (102940 => 102941)

--- trunk/Tools/MiniBrowser/qt/qml/ViewportInfoItem.qml	2011-12-15 16:40:19 UTC (rev 102940)
+++ trunk/Tools/MiniBrowser/qt/qml/ViewportInfoItem.qml	2011-12-15 16:40:41 UTC (rev 102941)
@@ -7,57 +7,78 @@
 color: "black"
 opacity: 0.8
 
-Text {
-id: viewportInfoLabel
-text: "Viewport Info"
-color: "white"
+Item {
+anchors.fill: parent
+anchors.margins: 20
+
+property string fontFamily: "Nokia Pure, Helvetica"
+property color fontColor: "white"
+
+Text {
+id: viewportInfoLabel
+text: "Viewport Info"
+color: "white"
+font.family: "Nokia Pure, Helvetica"
+font.pointSize: 24
+}
+Text {
+id: currentScaleLabel
+anchors.top: viewportInfoLabel.bottom
+anchors.topMargin: 30
+text: "Current scale: " + parseFloat(viewportInfo.currentScale.toFixed(4))
+font.family: parent.fontFamily
+color: parent.fontColor
+}
+Text {
+id: initialScaleLabel
+anchors.top: currentScaleLabel.bottom
+text: "Initial scale: " + parseFloat(viewportInfo.initialScale.toFixed(4))
+font.family: parent.fontFamily
+color: parent.fontColor
+}
+Text {
+id: minimumScaleLabel
+anchors.top: initialScaleLabel.bottom
+text: "Minimum scale: " + parseFloat(viewportInfo.minimumScale.toFixed(4))
+font.family: parent.fontFamily
+color: parent.fontColor
+}
+Text {
+id: maximumScaleLabel
+anchors.top: minimumScaleLabel.bottom
+text: "Maximum scale: " + parseFloat(viewportInfo.maximumScale.toFixed(4))
+font.family: parent.fontFamily
+color: parent.fontColor
+}
+Text {
+id: devicePixelRatioLabel
+anchors.top: maximumScaleLabel.bottom
+anchors.topMargin: 30
+text: "Device pixel ratio: " + parseFloat(viewportInfo.devicePixelRatio.toFixed(4))
+font.family: parent.fontFamily
+color: parent.fontColor
+}
+Text {
+id: contentsSizeLabel
+anchors.top: devicePixelRatioLabel.bottom
+text: "Contents size: " + viewportInfo.contentsSize.width + "x" + viewportInfo.contentsSize.height
+font.family: parent.fontFamily
+color: parent.fontColor
+}
+Text {
+id: layoutSizeLabel
+anchors.top: contentsSizeLabel.bottom
+text: "Viewport layout size: " + viewportInfo.layoutSize.width + "x" + viewportInfo.layoutSize.height
+font.family: parent.fontFamily
+color: parent.fontColor
+}
+Text {
+id: scalableLabel
+anchors.top: layoutSizeLabel.bottom
+anchors.topMargin: 30
+text: "View " + (viewportInfo.isScalable ? "is " : "is not " ) + "scalable."
+font.family: parent.fontFamily
+color: parent.fontColor
+}
 }
-Text {
-id: currentScaleLabel
-anchors.top: viewportInfoLabel.bottom
-text: "Current scale: " + viewportInfo.currentScale
-color: "white"
-}
-Text {
-id: initialScaleLabel
-anchors.top: currentScaleLabel.bottom
-text: "Initial scale: " + viewportInfo.initialScale
-color: "white"
-}
-Text {
-id: minimumScaleLabel
-anchors.top: initialScaleLabel.bottom
-text: "Minimum scale: " + viewportInfo.minimumScale
-color: "white"
-}
-Text {
-id: maximumScaleLabel
-anchors.top: minimumScaleLabel.bottom
-text: "Maximum scale: " + viewportInfo.maximumScale
-color: "white"
-}
-Text {
-id: devicePixelRatioLabel
-anchors.top: maximumScaleLabel.bottom
-text: "Device pixel ration: " + viewportInfo.devicePixelRatio
-color: "white

[webkit-changes] [102940] trunk/LayoutTests

[vsevik]

Title: [102940] trunk/LayoutTests








Revision 102940
Author vse...@chromium.org
Date 2011-12-15 08:40:19 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed test expectations fix.

* http/tests/inspector/console-resource-errors-expected.txt:
* http/tests/inspector/console-xhr-logging-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/console-resource-errors-expected.txt
trunk/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt
trunk/LayoutTests/platform/qt/Skipped


Added Paths

trunk/LayoutTests/platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102939 => 102940)

--- trunk/LayoutTests/ChangeLog	2011-12-15 16:27:55 UTC (rev 102939)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 16:40:19 UTC (rev 102940)
@@ -1,3 +1,12 @@
+2011-12-15  Vsevolod Vlasov  
+
+Unreviewed test expectations fix.
+
+* http/tests/inspector/console-resource-errors-expected.txt:
+* http/tests/inspector/console-xhr-logging-expected.txt:
+* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.
+* platform/qt/Skipped:
+
 2011-12-15  Igor Oliveira  
 
 [Qt] Support requestAnimationFrame API


Modified: trunk/LayoutTests/http/tests/inspector/console-resource-errors-expected.txt (102939 => 102940)

--- trunk/LayoutTests/http/tests/inspector/console-resource-errors-expected.txt	2011-12-15 16:27:55 UTC (rev 102939)
+++ trunk/LayoutTests/http/tests/inspector/console-resource-errors-expected.txt	2011-12-15 16:40:19 UTC (rev 102940)
@@ -1,8 +1,8 @@
 Tests that errors to load a resource cause error messages to be logged to console.
 
 
-GET http://127.0.0.1:8000/inspector/missing.css 404 (Not Found) console-message console-error-level
-GET http://127.0.0.1:8000/inspector/non-existent-script.js 404 (Not Found) console-message console-error-level
-console-resource-errors.html:18GET http://127.0.0.1:8000/inspector/non-existent-xhr 404 (Not Found) console-message console-error-level
+console-resource-errors-iframe.html:3GET http://127.0.0.1:8000/inspector/missing.css 404 (Not Found) console-message console-error-level
+console-resource-errors-iframe.html:4GET http://127.0.0.1:8000/inspector/non-existent-script.js 404 (Not Found) console-message console-error-level
 non-existent-iframe.html:1GET http://127.0.0.1:8000/inspector/non-existent-iframe.html 404 (Not Found) console-message console-error-level
+non-existent-xhr:1GET http://127.0.0.1:8000/inspector/non-existent-xhr 404 (Not Found) console-message console-error-level
 


Modified: trunk/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt (102939 => 102940)

--- trunk/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt	2011-12-15 16:27:55 UTC (rev 102939)
+++ trunk/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt	2011-12-15 16:40:19 UTC (rev 102940)
@@ -11,17 +11,17 @@
 Tests that XMLHttpRequest Logging works when Enabled and doesn't show logs when Disabled.
 
 console-xhr-logging.html:10sending a GET request to resources/xhr-exists.html
-network-test.js:39XHR finished loading: "http://127.0.0.1:8000/inspector/resources/xhr-exists.html".
+XHR finished loading: "http://127.0.0.1:8000/inspector/resources/xhr-exists.html".
 console-xhr-logging.html:10sending a GET request to resources/xhr-does-not-exist.html
-network-test.js:39GET http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html 404 (Not Found)
-network-test.js:39XHR finished loading: "http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html".
+resources/xhr-does-not-exist.html:1GET http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html 404 (Not Found)
+XHR finished loading: "http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html".
 console-xhr-logging.html:10sending a POST request to resources/post-target.cgi
-network-test.js:39XHR finished loading: "http://127.0.0.1:8000/inspector/resources/post-target.cgi".
+XHR finished loading: "http://127.0.0.1:8000/inspector/resources/post-target.cgi".
 console-xhr-logging.html:10sending a GET request to http://localhost:8000/inspector/resources/xhr-exists.html
 XMLHttpRequest cannot load http://localhost:8000/inspector/resources/xhr-exists.html. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
 console-xhr-logging.html:10sending a GET request to resources/xhr-exists.html
 console-xhr-logging.html:10sending a GET request to resources/xhr-does-not-exist.html
-network-test.js:39GET http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html 404 (Not Found)
+resources/xhr-does-not-exist.html:1GET http://127.0.0.1:8000/inspector/resources/xhr-d

[webkit-changes] [102938] trunk/LayoutTests

[ossy]

Title: [102938] trunk/LayoutTests








Revision 102938
Author o...@webkit.org
Date 2011-12-15 08:21:53 -0800 (Thu, 15 Dec 2011)


Log Message
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip new failing tests (regressions).
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r102918.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102937 => 102938)

--- trunk/LayoutTests/ChangeLog	2011-12-15 15:53:48 UTC (rev 102937)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 16:21:53 UTC (rev 102938)
@@ -1,3 +1,10 @@
+2011-12-15  Csaba Osztrogonác  
+
+[Qt] Unreviewed gardening.
+
+* platform/qt/Skipped: Skip new failing tests (regressions).
+* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r102918.
+
 2011-12-15  Vsevolod Vlasov  
 
 Unreviewed chromium test rebaseline.


Modified: trunk/LayoutTests/platform/qt/Skipped (102937 => 102938)

--- trunk/LayoutTests/platform/qt/Skipped	2011-12-15 15:53:48 UTC (rev 102937)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-12-15 16:21:53 UTC (rev 102938)
@@ -2533,3 +2533,12 @@
 # [Qt][GTK] The html5lib/runner.html test is start to fail after r102626
 # https://bugs.webkit.org/show_bug.cgi?id=74411
 html5lib/runner.html
+
+# http://trac.webkit.org/changeset/102919 broke them
+# https://bugs.webkit.org/show_bug.cgi?id=74521
+http/tests/inspector/console-resource-errors.html
+http/tests/inspector/console-xhr-logging.html
+
+# REGRESSION(r102829): It made fast/images/move-image-to-new-document.html timeout
+# https://bugs.webkit.org/show_bug.cgi?id=74607
+fast/images/move-image-to-new-document.html


Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt (102937 => 102938)

--- trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt	2011-12-15 15:53:48 UTC (rev 102937)
+++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt	2011-12-15 16:21:53 UTC (rev 102938)
@@ -490,6 +490,7 @@
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeUndefined') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldEvaluateTo') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldHaveHadError') is 'object'
+PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldNotBe') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldThrow') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'status') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'statusbar') is 'object'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102937] trunk/Source/WebCore

[commit-queue]

Title: [102937] trunk/Source/WebCore








Revision 102937
Author commit-qu...@webkit.org
Date 2011-12-15 07:53:48 -0800 (Thu, 15 Dec 2011)


Log Message
Removing BlackBerryCookieCache from the build system
https://bugs.webkit.org/show_bug.cgi?id=74318

Patch by Otto Cheung  on 2011-12-15
Reviewed by Rob Buis.

Removing any references to BlackBerryCookieCache in files that are upstreamed.

We are removing the BlackBerryCookieCache because the CookieManager cookie structure has been
refactored to have a similar structure to the cache. Since the read speeds in both structures
are similar, we no longer need the cache to speed up read performance.

No new tests, this patch by itself will not work. This patch is only removing
the references to BlackBerryCookieCache in files that are upstreamed.

* PlatformBlackBerry.cmake:
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyHeaderReceived):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformBlackBerry.cmake
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102936 => 102937)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 15:36:15 UTC (rev 102936)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 15:53:48 UTC (rev 102937)
@@ -1,3 +1,23 @@
+2011-12-15  Otto Cheung  
+
+Removing BlackBerryCookieCache from the build system
+https://bugs.webkit.org/show_bug.cgi?id=74318
+
+Reviewed by Rob Buis.
+
+Removing any references to BlackBerryCookieCache in files that are upstreamed.
+
+We are removing the BlackBerryCookieCache because the CookieManager cookie structure has been
+refactored to have a similar structure to the cache. Since the read speeds in both structures
+are similar, we no longer need the cache to speed up read performance.
+
+No new tests, this patch by itself will not work. This patch is only removing
+the references to BlackBerryCookieCache in files that are upstreamed.
+
+* PlatformBlackBerry.cmake:
+* platform/network/blackberry/NetworkJob.cpp:
+(WebCore::NetworkJob::handleNotifyHeaderReceived):
+
 2011-12-15  Kenneth Rohde Christiansen  
 
 [Qt] Mobile theme improvements


Modified: trunk/Source/WebCore/PlatformBlackBerry.cmake (102936 => 102937)

--- trunk/Source/WebCore/PlatformBlackBerry.cmake	2011-12-15 15:36:15 UTC (rev 102936)
+++ trunk/Source/WebCore/PlatformBlackBerry.cmake	2011-12-15 15:53:48 UTC (rev 102937)
@@ -133,7 +133,6 @@
 page/blackberry/DragControllerBlackBerry.cpp
 page/blackberry/EventHandlerBlackBerry.cpp
 page/blackberry/FrameBlackBerry.cpp
-platform/blackberry/BlackBerryCookieCache.cpp
 platform/blackberry/ClipboardBlackBerry.cpp
 platform/blackberry/ContextMenuBlackBerry.cpp
 platform/blackberry/ContextMenuItemBlackBerry.cpp


Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (102936 => 102937)

--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2011-12-15 15:36:15 UTC (rev 102936)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2011-12-15 15:53:48 UTC (rev 102937)
@@ -21,7 +21,6 @@
 
 #include "AboutData.h"
 #include "Base64.h"
-#include "BlackBerryCookieCache.h"
 #include "CookieManager.h"
 #include "CredentialStorage.h"
 #include "Frame.h"
@@ -305,7 +304,6 @@
 if (m_frame && m_frame->loader() && m_frame->loader()->client()
 && static_cast(m_frame->loader()->client())->cookiesEnabled())
 handleSetCookieHeader(value);
-BlackBerryCookieCache::instance().clearAllCookiesForHost(m_pageGroupName, m_response.url());
 }
 
 if (lowerKey == "www-authenticate")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102936] trunk

[commit-queue]

Title: [102936] trunk








Revision 102936
Author commit-qu...@webkit.org
Date 2011-12-15 07:36:15 -0800 (Thu, 15 Dec 2011)


Log Message
Web Inspector: [Chromium]  Call LowMemoryNotification instead of IdleNotification
https://bugs.webkit.org/show_bug.cgi?id=71821

Patch by Ulan Degenbaev  on 2011-12-15
Reviewed by Yury Semikhatsky.

* Source/WebCore/bindings/v8/ScriptProfiler.cpp:

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp




Diff

Modified: trunk/ChangeLog (102935 => 102936)

--- trunk/ChangeLog	2011-12-15 15:11:59 UTC (rev 102935)
+++ trunk/ChangeLog	2011-12-15 15:36:15 UTC (rev 102936)
@@ -1,3 +1,12 @@
+2011-12-15  Ulan Degenbaev  
+
+Web Inspector: [Chromium]  Call LowMemoryNotification instead of IdleNotification
+https://bugs.webkit.org/show_bug.cgi?id=71821
+
+Reviewed by Yury Semikhatsky.
+
+* Source/WebCore/bindings/v8/ScriptProfiler.cpp:
+
 2011-12-15  Tor Arne Vestbø  
 
 [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path


Modified: trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp (102935 => 102936)

--- trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp	2011-12-15 15:11:59 UTC (rev 102935)
+++ trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp	2011-12-15 15:36:15 UTC (rev 102936)
@@ -61,11 +61,7 @@
 
 void ScriptProfiler::collectGarbage()
 {
-// Repeatedly call the V8 idle notification until it returns true ("nothing
-// more to free"). Note that it makes more sense to do this than to implement
-// a new "delete everything" pass because object references make it difficult
-// to free everything possible in just one pass.
-while (!v8::V8::IdleNotification()) { }
+v8::V8::LowMemoryNotification();
 }
 
 PassRefPtr ScriptProfiler::objectByHeapObjectId(unsigned id, InjectedScriptManager* injectedScriptManager)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102934] trunk/Source/WebCore

[kenneth]

Title: [102934] trunk/Source/WebCore








Revision 102934
Author kenn...@webkit.org
Date 2011-12-15 06:59:26 -0800 (Thu, 15 Dec 2011)


Log Message
[Qt] Mobile theme improvements

Rubberstamped by Simon Hausmann.

- Invert the gradient on the checkboxes
- Make the buttons on the multi select combobox work on floats
- Mini cleanups

* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::StylePainterMobile::drawCheckableBackground):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::drawComboBox):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/RenderThemeQtMobile.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102933 => 102934)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 14:19:49 UTC (rev 102933)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 14:59:26 UTC (rev 102934)
@@ -1,3 +1,19 @@
+2011-12-15  Kenneth Rohde Christiansen  
+
+[Qt] Mobile theme improvements
+
+Rubberstamped by Simon Hausmann.
+
+- Invert the gradient on the checkboxes
+- Make the buttons on the multi select combobox work on floats
+- Mini cleanups
+
+* platform/qt/RenderThemeQtMobile.cpp:
+(WebCore::StylePainterMobile::drawCheckableBackground):
+(WebCore::StylePainterMobile::drawMultipleComboButton):
+(WebCore::StylePainterMobile::getButtonImageSize):
+(WebCore::StylePainterMobile::drawComboBox):
+
 2011-12-15  Peter Rybin  
 
 Web Inspector: CodeGeneratorInspector.py convert script conditions to precompiler #ifs


Modified: trunk/Source/WebCore/platform/qt/RenderThemeQtMobile.cpp (102933 => 102934)

--- trunk/Source/WebCore/platform/qt/RenderThemeQtMobile.cpp	2011-12-15 14:19:49 UTC (rev 102933)
+++ trunk/Source/WebCore/platform/qt/RenderThemeQtMobile.cpp	2011-12-15 14:59:26 UTC (rev 102934)
@@ -79,7 +79,7 @@
 static const QColor highlightColor(16, 128, 221);
 static const QColor buttonGradientBottom(245, 245, 245);
 static const QColor shadowColor(80, 80, 80, 160);
-static const QPen borderPen(darkColor, 0.3, Qt::SolidLine, Qt::RoundCap, Qt::RoundJoin);
+static const QPen borderPen(darkColor, 0.4, Qt::SolidLine, Qt::RoundCap, Qt::RoundJoin);
 
 static inline void drawRectangularControlBackground(QPainter* painter, const QPen& pen, const QRect& rect, const QBrush& brush)
 {
@@ -123,15 +123,17 @@
 void StylePainterMobile::drawCheckableBackground(QPainter* painter, const QRect& rect, bool checked, bool enabled) const
 {
 QBrush brush;
-if (checked && enabled) {
-QLinearGradient gradient;
-gradient.setStart(rect.bottomLeft());
-gradient.setFinalStop(rect.topLeft());
-gradient.setColorAt(0.0, highlightColor);
-gradient.setColorAt(1.0, highlightColor.lighter());
-brush = gradient;
-} else
-brush = Qt::lightGray;
+QColor color = Qt::gray;
+if (checked && enabled)
+color = highlightColor;
+
+QLinearGradient gradient;
+gradient.setStart(rect.topLeft());
+gradient.setFinalStop(rect.bottomLeft());
+gradient.setColorAt(0.0, color);
+gradient.setColorAt(1.0, color.lighter());
+brush = gradient;
+
 drawRectangularControlBackground(painter, borderPen, rect, brush);
 }
 
@@ -209,14 +211,18 @@
 
 void StylePainterMobile::drawMultipleComboButton(QPainter* painter, const QSize& size, const QColor& color) const
 {
-const int dotSize = size.height() - 1;
+const qreal dotDiameter = size.height();
+const qreal dotRadii = dotDiameter / 2;
 
+painter->setRenderHint(QPainter::Antialiasing, true);
 painter->setPen(color);
 painter->setBrush(color);
 
-painter->drawEllipse(0, 0, dotSize, dotSize);
-painter->drawEllipse(dotSize * 2, 0, dotSize, dotSize);
-painter->drawEllipse(4 * dotSize, 0, dotSize, dotSize);
+const qreal offsetFactor = 1.6;
+for (int i = 0; i < 3; ++i) {
+QPointF center(offsetFactor * dotRadii + i * offsetFactor * dotDiameter, dotRadii);
+painter->drawEllipse(center, dotRadii, dotRadii);
+}
 }
 
 void StylePainterMobile::drawSimpleComboButton(QPainter* painter, const QSize& size, const QColor& color) const
@@ -252,7 +258,7 @@
 
 const int height = buttonSize.height() / 2 + frameWidth;
 const int width = height - (2 * (1 + height / 15)) - 1;
-return QSize(width , height);
+return QSize(width, height);
 }
 
 QPixmap StylePainterMobile::findComboButton(const QSize& size, bool multiple, bool enabled) const
@@ -342,7 +348,6 @@
 linearGradient.setColorAt(0.0, buttonGradientBottom);
 linearGradient.setColorAt(1.0, Qt::white);
 
-
 drawRectangularControlBackground(painter, borderPen, rect, linearGradient);
 
 const QRect buttonRect(rect.x() + rect.width() - frameWidth - arrowBoxWidth, rect.y() + frameWidth
@@ -513,7 +518,6 @@
 setButtonPadding(style);
 }
 
-
 void RenderThemeQtMobile::setButtonPadding(RenderStyle* style) const
 {
 i

[webkit-changes] [102933] trunk/Source/WebCore

[loislo]

Title: [102933] trunk/Source/WebCore








Revision 102933
Author loi...@chromium.org
Date 2011-12-15 06:19:49 -0800 (Thu, 15 Dec 2011)


Log Message
Web Inspector: CodeGeneratorInspector.py convert script conditions to precompiler #ifs
https://bugs.webkit.org/show_bug.cgi?id=74534

Patch by Peter Rybin  on 2011-12-15
Reviewed by Pavel Feldman.

Generator is rewritten to add #if's to output.

* inspector/CodeGeneratorInspector.py:
(DomainNameFixes.get_fixed_data.Res.get_guard.Guard.generate_open):
(DomainNameFixes.get_fixed_data.Res.get_guard.Guard):
(DomainNameFixes.get_fixed_data.Res.get_guard.Guard.generate_close):
(DomainNameFixes.get_fixed_data.Res):
(DomainNameFixes.get_fixed_data.Res.get_guard):
(Generator.go):
(Generator.process_event):
(Generator.process_command):
(Generator.process_types):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py




Diff

Modified: trunk/Source/WebCore/ChangeLog (102932 => 102933)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 14:09:48 UTC (rev 102932)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 14:19:49 UTC (rev 102933)
@@ -1,3 +1,23 @@
+2011-12-15  Peter Rybin  
+
+Web Inspector: CodeGeneratorInspector.py convert script conditions to precompiler #ifs
+https://bugs.webkit.org/show_bug.cgi?id=74534
+
+Reviewed by Pavel Feldman.
+
+Generator is rewritten to add #if's to output.
+
+* inspector/CodeGeneratorInspector.py:
+(DomainNameFixes.get_fixed_data.Res.get_guard.Guard.generate_open):
+(DomainNameFixes.get_fixed_data.Res.get_guard.Guard):
+(DomainNameFixes.get_fixed_data.Res.get_guard.Guard.generate_close):
+(DomainNameFixes.get_fixed_data.Res):
+(DomainNameFixes.get_fixed_data.Res.get_guard):
+(Generator.go):
+(Generator.process_event):
+(Generator.process_command):
+(Generator.process_types):
+
 2011-12-15  Jesus Sanchez-Palencia  
 
 [Qt][WK2] Setting Download as action for navigation request crashes WebProcess


Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (102932 => 102933)

--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2011-12-15 14:09:48 UTC (rev 102932)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2011-12-15 14:19:49 UTC (rev 102933)
@@ -39,12 +39,12 @@
 
 
 DOMAIN_DEFINE_NAME_MAP = {
-"Database": "ENABLE_SQL_DATABASE",
-"Debugger": "ENABLE_JAVASCRIPT_DEBUGGER",
-"DOMDebugger": "ENABLE_JAVASCRIPT_DEBUGGER",
-"FileSystem": "ENABLE_FILE_SYSTEM",
-"Profiler": "ENABLE_JAVASCRIPT_DEBUGGER",
-"Worker": "ENABLE_WORKERS",
+"Database": "SQL_DATABASE",
+"Debugger": "_javascript__DEBUGGER",
+"DOMDebugger": "_javascript__DEBUGGER",
+"FileSystem": "FILE_SYSTEM",
+"Profiler": "_javascript__DEBUGGER",
+"Worker": "WORKERS",
 }
 
 
@@ -55,6 +55,7 @@
 
 
 cmdline_parser = optparse.OptionParser()
+# FIXME: get rid of this option once the system is stable.
 cmdline_parser.add_option("--defines")
 cmdline_parser.add_option("--output_h_dir")
 cmdline_parser.add_option("--output_cpp_dir")
@@ -188,19 +189,20 @@
 agent_field_name = field_name_res
 
 @staticmethod
-def is_disabled(defines):
-if not domain_name in DOMAIN_DEFINE_NAME_MAP:
-# Has not corresponding preprocessor symbol.
-return False
+def get_guard():
+if domain_name in DOMAIN_DEFINE_NAME_MAP:
+define_name = DOMAIN_DEFINE_NAME_MAP[domain_name]
 
-define_name = DOMAIN_DEFINE_NAME_MAP[domain_name]
+class Guard:
+@staticmethod
+def generate_open(output):
+output.append("#if ENABLE(%s)\n" % define_name)
 
-if not define_name in defines:
-# Disabled when not mentioned
-return True
+@staticmethod
+def generate_close(output):
+output.append("#endif // ENABLE(%s)\n" % define_name)
 
-define_value = defines[define_name]
-return not bool(define_value)
+return Guard
 
 return Res
 
@@ -1292,9 +1294,7 @@
 backend_js = string.Template(file_header_ +
 """
 
-$delegates
-$eventArgs
-$domainDispatchers
+$domainInitializers
 """)
 
 param_container_access_code = """
@@ -1316,9 +1316,7 @@
 backend_method_name_declaration_list = []
 method_handler_list = []
 frontend_method_list = []
-backend_js_initializer_list = []
-backend_js_event_list = []
-backend_js_domain_dispatcher_list = []
+backend_js_domain_initializer_list = []
 
 backend_setters_list = []
 backend_constructor_init_list = []
@@ -1332,19 +1330,38 @@
 def go():
 Generator.process_types(type_map)
 
+first_cycle

[webkit-changes] [102932] trunk/Source/WebKit2

[caio . oliveira]

Title: [102932] trunk/Source/WebKit2








Revision 102932
Author caio.olive...@openbossa.org
Date 2011-12-15 06:09:48 -0800 (Thu, 15 Dec 2011)


Log Message
[Qt] [WK2] Remove QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=74540

Reviewed by Kenneth Rohde Christiansen.

Move WebPageProxy* to QQuickWebViewPrivate. The remaining functions in
QtWebPageProxy were simple wrappers to WebKit functionality (text zoom, page zoom
and user agent setting). Since those wrappers are unused, they were removed. The
signal in the class was also unused.

This patch also remove the code from WebContextMenuProxyQt, it was remains of a
previous QMenu-based implementation. We want to rewrite this code for QML anyway,
so I reverted to an empty state.

Farewell, QtWebPageProxy!

* Target.pri:
* UIProcess/API/qt/qquickwebpage.cpp:
* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::~QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::createDrawingAreaProxy):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QQuickWebViewPrivate::_q_onVisibleChanged):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::computeViewportConstraints):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewPrivate::setNavigatorQtObjectEnabled):
(QQuickWebViewExperimental::postMessage):
(QQuickWebView::load):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::url):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::loading):
(QQuickWebView::canReload):
(QQuickWebView::title):
(QQuickWebView::pageRef):
(QQuickWebView::loadHtml):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/API/qt/qwebnavigationhistory_p_p.h:
* UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::preferencesRef):
* UIProcess/PageClient.h:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::QtPageClient):
(QtPageClient::initialize):
(QtPageClient::createPopupMenuProxy):
(QtPageClient::createContextMenuProxy):
* UIProcess/qt/QtPageClient.h:
* UIProcess/qt/QtWebPageProxy.cpp: Removed.
* UIProcess/qt/QtWebPageProxy.h: Removed.
* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::hideContextMenu):
* UIProcess/qt/WebContextMenuProxyQt.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qwebnavigationhistory_p_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp
trunk/Source/WebKit2/UIProcess/PageClient.h
trunk/Source/WebKit2/UIProcess/qt/QtPageClient.cpp
trunk/Source/WebKit2/UIProcess/qt/QtPageClient.h
trunk/Source/WebKit2/UIProcess/qt/WebContextMenuProxyQt.cpp
trunk/Source/WebKit2/UIProcess/qt/WebContextMenuProxyQt.h


Removed Paths

trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102931 => 102932)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 13:45:56 UTC (rev 102931)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 14:09:48 UTC (rev 102932)
@@ -1,3 +1,71 @@
+2011-12-15  Caio Marcelo de Oliveira Filho  
+
+[Qt] [WK2] Remove QtWebPageProxy
+https://bugs.webkit.org/show_bug.cgi?id=74540
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Move WebPageProxy* to QQuickWebViewPrivate. The remaining functions in
+QtWebPageProxy were simple wrappers to WebKit functionality (text zoom, page zoom
+and user agent setting). Since those wrappers are unused, they were removed. The
+signal in the class was also unused.
+
+This patch also remove the code from WebContextMenuProxyQt, it was remains of a
+previous QMenu-based implementation. We want to rewrite this code for QML anyway,
+so I reverted to an empty state.
+
+Farewell, QtWebPageProxy!
+
+* Target.pri:
+* UIProcess/API/qt/qquickwebpage.cpp:
+* UIProcess/API/qt/qquickwebpage_p.h:
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::~QQuickWebViewPrivate):
+(QQuickWebViewPrivate::initialize):
+(QQuickWebViewPrivate::processDidCrash):
+(QQuickWebViewPrivate::createDrawingAreaProxy):
+(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
+(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged)

[webkit-changes] [102931] trunk/Source/JavaScriptCore

[commit-queue]

Title: [102931] trunk/Source/_javascript_Core








Revision 102931
Author commit-qu...@webkit.org
Date 2011-12-15 05:45:56 -0800 (Thu, 15 Dec 2011)


Log Message
Minor refactor to Parser::parseTryStatement
https://bugs.webkit.org/show_bug.cgi?id=74507

Patch by Andy Wingo  on 2011-12-15
Reviewed by Geoffrey Garen.

* parser/Parser.cpp (JSC::Parser::parseTryStatement): Use the
Parser's declareVariable instead of going directly to the scope.
This will facilitate future checks related to harmony block
scoping.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Parser.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102930 => 102931)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-15 13:36:17 UTC (rev 102930)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-15 13:45:56 UTC (rev 102931)
@@ -1,5 +1,17 @@
 2011-12-15  Andy Wingo  
 
+Minor refactor to Parser::parseTryStatement
+https://bugs.webkit.org/show_bug.cgi?id=74507
+
+Reviewed by Geoffrey Garen.
+
+* parser/Parser.cpp (JSC::Parser::parseTryStatement): Use the
+Parser's declareVariable instead of going directly to the scope.
+This will facilitate future checks related to harmony block
+scoping.
+
+2011-12-15  Andy Wingo  
+
 Rename JSC::Heuristics to JSC::Options
 https://bugs.webkit.org/show_bug.cgi?id=72889
 


Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (102930 => 102931)

--- trunk/Source/_javascript_Core/parser/Parser.cpp	2011-12-15 13:36:17 UTC (rev 102930)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp	2011-12-15 13:45:56 UTC (rev 102931)
@@ -623,7 +623,7 @@
 ident = m_token.m_data.ident;
 next();
 AutoPopScopeRef catchScope(this, pushScope());
-failIfFalseIfStrictWithNameAndMessage(catchScope->declareVariable(ident), "Cannot declare a variable named", ident->impl(), "in strict mode");
+failIfFalseIfStrictWithNameAndMessage(declareVariable(ident), "Cannot declare a variable named", ident->impl(), "in strict mode");
 catchScope->preventNewDecls();
 consumeOrFail(CLOSEPAREN);
 matchOrFail(OPENBRACE);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102930] trunk/LayoutTests

[vsevik]

Title: [102930] trunk/LayoutTests








Revision 102930
Author vse...@chromium.org
Date 2011-12-15 05:36:17 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed chromium test rebaseline.

* platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102929 => 102930)

--- trunk/LayoutTests/ChangeLog	2011-12-15 13:32:43 UTC (rev 102929)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 13:36:17 UTC (rev 102930)
@@ -1,3 +1,9 @@
+2011-12-15  Vsevolod Vlasov  
+
+Unreviewed chromium test rebaseline.
+
+* platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt: Added.
+
 2011-12-15  Philippe Normand  
 
 Unreviewed, GTK rebaseline.


Added: trunk/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt (0 => 102930)

--- trunk/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt	2011-12-15 13:36:17 UTC (rev 102930)
@@ -0,0 +1,5 @@
+Tests console message when script is loaded with incorrect text/html mime type.
+
+Bug 69972
+script-as-text-loading.html:10Resource interpreted as Script but transferred with MIME type text/plain: "http://127.0.0.1:8000/inspector/network/resources/script-as-text.php".
+
Property changes on: trunk/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt
___


Added: svn:eol-style




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102929] trunk/LayoutTests

[philn]

Title: [102929] trunk/LayoutTests








Revision 102929
Author ph...@webkit.org
Date 2011-12-15 05:32:43 -0800 (Thu, 15 Dec 2011)


Log Message
Unreviewed, GTK rebaseline.

* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102928 => 102929)

--- trunk/LayoutTests/ChangeLog	2011-12-15 13:26:06 UTC (rev 102928)
+++ trunk/LayoutTests/ChangeLog	2011-12-15 13:32:43 UTC (rev 102929)
@@ -1,3 +1,9 @@
+2011-12-15  Philippe Normand  
+
+Unreviewed, GTK rebaseline.
+
+* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
+
 2011-12-14  Vsevolod Vlasov  
 
 Web Inspector: Console should show network messages origins.


Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt (102928 => 102929)

--- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt	2011-12-15 13:26:06 UTC (rev 102928)
+++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt	2011-12-15 13:32:43 UTC (rev 102929)
@@ -493,6 +493,7 @@
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeUndefined') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldEvaluateTo') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldHaveHadError') is 'object'
+PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldNotBe') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldThrow') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'status') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'statusbar') is 'object'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102928] trunk/Source/WebKit/chromium

[caseq]

Title: [102928] trunk/Source/WebKit/chromium








Revision 102928
Author ca...@chromium.org
Date 2011-12-15 05:26:06 -0800 (Thu, 15 Dec 2011)


Log Message
Web Inspector: [Chromium] add support to inspector test suite to fetch test execution results from console
https://bugs.webkit.org/show_bug.cgi?id=74208

Reviewed by Yury Semikhatsky.

This adds waitForTestResultsInConsole, a test suite method that monitors console for a message containing
either PASS or FAIL and sets result accordingly. This is used by tests running in the extension context to
communicate test results to the test driver (see devtools_sanity_unittest.cc for an example).

* src/js/Tests.js:
(.TestSuite.prototype.testWaitForResultsInConsole.onConsoleMessage):
(.TestSuite.prototype.testWaitForResultsInConsole):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/Tests.js




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102927 => 102928)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 13:19:31 UTC (rev 102927)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 13:26:06 UTC (rev 102928)
@@ -1,3 +1,18 @@
+2011-12-15  Andrey Kosyakov  
+
+Web Inspector: [Chromium] add support to inspector test suite to fetch test execution results from console
+https://bugs.webkit.org/show_bug.cgi?id=74208
+
+Reviewed by Yury Semikhatsky.
+
+This adds waitForTestResultsInConsole, a test suite method that monitors console for a message containing
+either PASS or FAIL and sets result accordingly. This is used by tests running in the extension context to
+communicate test results to the test driver (see devtools_sanity_unittest.cc for an example).
+
+* src/js/Tests.js:
+(.TestSuite.prototype.testWaitForResultsInConsole.onConsoleMessage):
+(.TestSuite.prototype.testWaitForResultsInConsole):
+
 2011-12-15  Peter Beverloo  
 
 [Chromium] Enable TestNetscapePlugIn to link for Android


Modified: trunk/Source/WebKit/chromium/src/js/Tests.js (102927 => 102928)

--- trunk/Source/WebKit/chromium/src/js/Tests.js	2011-12-15 13:19:31 UTC (rev 102927)
+++ trunk/Source/WebKit/chromium/src/js/Tests.js	2011-12-15 13:26:06 UTC (rev 102928)
@@ -558,6 +558,31 @@
 };
 
 
+TestSuite.prototype.waitForTestResultsInConsole = function()
+{
+var messages = WebInspector.console.messages;
+for (var i = 0; i < messages.length; ++i) {
+var text = messages[i].text;
+if (text === "PASS")
+return;
+else if (/^FAIL/.test(text))
+this.fail(text); // This will throw.
+}
+// Neitwer PASS nor FAIL, so wait for more messages.
+function onConsoleMessage(event)
+{
+var text = event.data.text;
+if (text === "PASS")
+this.releaseControl();
+else if (/^FAIL/.test(text))
+this.fail(text);
+}
+
+WebInspector.console.addEventListener(WebInspector.ConsoleModel.Events.MessageAdded, onConsoleMessage, this);
+this.takeControl();
+};
+
+
 /**
  * Serializes options collection to string.
  * @param {HTMLOptionsCollection} options






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102927] trunk/Source/WebKit2

[commit-queue]

Title: [102927] trunk/Source/WebKit2








Revision 102927
Author commit-qu...@webkit.org
Date 2011-12-15 05:19:31 -0800 (Thu, 15 Dec 2011)


Log Message
[WK2] Eliminate unnecessary GTK/QT ifdefs for shared memory implementation
https://bugs.webkit.org/show_bug.cgi?id=74602

Patch by Simon Hausmann  on 2011-12-15
Reviewed by Kenneth Rohde Christiansen.

For shared memory Qt was using shm_open, Gtk was using files in /tmp. There
is no reason to obfuscate the code with #ifdefs or let Gtk use an inferior
method of opening shared memory. So this patch makes SharedMemoryUnix.cpp
truly Qt and Gtk independent.

* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102926 => 102927)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 13:18:44 UTC (rev 102926)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 13:19:31 UTC (rev 102927)
@@ -1,5 +1,20 @@
 2011-12-15  Simon Hausmann  
 
+[WK2] Eliminate unnecessary GTK/QT ifdefs for shared memory implementation
+https://bugs.webkit.org/show_bug.cgi?id=74602
+
+Reviewed by Kenneth Rohde Christiansen.
+
+For shared memory Qt was using shm_open, Gtk was using files in /tmp. There
+is no reason to obfuscate the code with #ifdefs or let Gtk use an inferior
+method of opening shared memory. So this patch makes SharedMemoryUnix.cpp
+truly Qt and Gtk independent.
+
+* Platform/unix/SharedMemoryUnix.cpp:
+(WebKit::SharedMemory::create):
+
+2011-12-15  Simon Hausmann  
+
 [Qt] Cleanup: Remove unnecessary const_cast
 
 Reviewed by Kenneth Christiansen.


Modified: trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp (102926 => 102927)

--- trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp	2011-12-15 13:18:44 UTC (rev 102926)
+++ trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp	2011-12-15 13:19:31 UTC (rev 102927)
@@ -41,14 +41,9 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
-#if PLATFORM(QT)
-#include 
-#elif PLATFORM(GTK)
-#include 
-#include 
-#endif
-
 namespace WebKit {
 
 SharedMemory::Handle::Handle()
@@ -104,42 +99,24 @@
 
 PassRefPtr SharedMemory::create(size_t size)
 {
-#if PLATFORM(QT)
-QByteArray tempNameCSTR("/qwkshm.");
-tempNameCSTR += QByteArray::number(qrand(), 36);
-char* tempNameC = tempNameCSTR.data();
-#elif PLATFORM(GTK)
-GOwnPtr tempName(g_build_filename(g_get_tmp_dir(), "WK2SharedMemoryXX", NULL));
-gchar* tempNameC = tempName.get();
-#endif
+CString tempName;
 
-int fileDescriptor;
-#if PLATFORM(QT)
-while ((fileDescriptor = shm_open(tempNameC, O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR)) == -1) {
-if (errno != EINTR)
-return 0;
+int fileDescriptor = -1;
+for (int tries = 0; fileDescriptor == -1 && tries < 10; ++tries) {
+String name = String("/WK2SharedMemory.") + String::number(static_cast(WTF::randomNumber() * (std::numeric_limits::max() + 1.0)));
+tempName = name.utf8();
+
+do {
+fileDescriptor = shm_open(tempName.data(), O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR);
+} while (fileDescriptor == -1 && errno == EINTR);
 }
-#else
-while ((fileDescriptor = mkstemp(tempNameC)) == -1) {
-if (errno != EINTR)
-return 0;
-}
-while (fcntl(fileDescriptor, F_SETFD, FD_CLOEXEC) == -1) {
-if (errno != EINTR) {
-while (close(fileDescriptor) == -1 && errno == EINTR) { }
-unlink(tempNameC);
-return 0;
-}
-}
-#endif
+if (fileDescriptor == -1)
+return 0;
+
 while (ftruncate(fileDescriptor, size) == -1) {
 if (errno != EINTR) {
 while (close(fileDescriptor) == -1 && errno == EINTR) { }
-#if PLATFORM(QT)
-shm_unlink(tempNameC);
-#else
-unlink(tempNameC);
-#endif
+shm_unlink(tempName.data());
 return 0;
 }
 }
@@ -147,19 +124,11 @@
 void* data = "" size, PROT_READ | PROT_WRITE, MAP_SHARED, fileDescriptor, 0);
 if (data == MAP_FAILED) {
 while (close(fileDescriptor) == -1 && errno == EINTR) { }
-#if PLATFORM(QT)
-shm_unlink(tempNameC);
-#else
-unlink(tempNameC);
-#endif
+shm_unlink(tempName.data());
 return 0;
 }
 
-#if PLATFORM(QT)
-shm_unlink(tempNameC);
-#else
-unlink(tempNameC);
-#endif
+shm_unlink(tempName.data());
 
 RefPtr instance = adoptRef(new SharedMemory());
 instance->m_data = data;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102926] trunk/Source/WebCore

[jesus]

Title: [102926] trunk/Source/WebCore








Revision 102926
Author je...@webkit.org
Date 2011-12-15 05:18:44 -0800 (Thu, 15 Dec 2011)


Log Message
[Qt][WK2] Setting Download as action for navigation request crashes WebProcess
https://bugs.webkit.org/show_bug.cgi?id=74526

Reviewed by Simon Hausmann.

Adding checks for networkcontext and networkAccessManager
and return true in case they don't exist, following the same
logic as if the CookieJar doesn't exist.

* platform/qt/ThirdPartyCookiesQt.cpp:
(WebCore::thirdPartyCookiePolicyPermits):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/ThirdPartyCookiesQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102925 => 102926)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 13:16:08 UTC (rev 102925)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 13:18:44 UTC (rev 102926)
@@ -1,3 +1,17 @@
+2011-12-15  Jesus Sanchez-Palencia  
+
+[Qt][WK2] Setting Download as action for navigation request crashes WebProcess
+https://bugs.webkit.org/show_bug.cgi?id=74526
+
+Reviewed by Simon Hausmann.
+
+Adding checks for networkcontext and networkAccessManager
+and return true in case they don't exist, following the same
+logic as if the CookieJar doesn't exist.
+
+* platform/qt/ThirdPartyCookiesQt.cpp:
+(WebCore::thirdPartyCookiePolicyPermits):
+
 2011-12-14  Tor Arne Vestbø  
 
 [Qt] Get rid of layering violation in PluginViewQt


Modified: trunk/Source/WebCore/platform/qt/ThirdPartyCookiesQt.cpp (102925 => 102926)

--- trunk/Source/WebCore/platform/qt/ThirdPartyCookiesQt.cpp	2011-12-15 13:16:08 UTC (rev 102925)
+++ trunk/Source/WebCore/platform/qt/ThirdPartyCookiesQt.cpp	2011-12-15 13:18:44 UTC (rev 102926)
@@ -62,6 +62,12 @@
 bool thirdPartyCookiePolicyPermits(NetworkingContext* context, const QUrl& url, const QUrl& firstPartyUrl)
 {
 #if QT_VERSION >= QT_VERSION_CHECK(4, 8, 0)
+if (!context)
+return true;
+
+if (!context->networkAccessManager())
+return true;
+
 QNetworkCookieJar* jar = context->networkAccessManager()->cookieJar();
 if (!jar)
 return true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102925] trunk

[vestbo]

Title: [102925] trunk








Revision 102925
Author ves...@webkit.org
Date 2011-12-15 05:16:08 -0800 (Thu, 15 Dec 2011)


Log Message
[Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path

Reviewed Simon Hausmann.

Modified Paths

trunk/ChangeLog
trunk/Source/api.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/webcore.prf




Diff

Modified: trunk/ChangeLog (102924 => 102925)

--- trunk/ChangeLog	2011-12-15 13:04:53 UTC (rev 102924)
+++ trunk/ChangeLog	2011-12-15 13:16:08 UTC (rev 102925)
@@ -1,3 +1,11 @@
+2011-12-15  Tor Arne Vestbø  
+
+[Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
+
+Reviewed Simon Hausmann.
+
+* Source/api.pri:
+
 2011-12-15  Michael Brüning  
 
 [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.


Modified: trunk/Source/api.pri (102924 => 102925)

--- trunk/Source/api.pri	2011-12-15 13:04:53 UTC (rev 102924)
+++ trunk/Source/api.pri	2011-12-15 13:16:08 UTC (rev 102925)
@@ -79,7 +79,9 @@
 $$PWD/WebKit/qt/WebCoreSupport/TextCheckerClientQt.h \
 $$PWD/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.h
 
-INCLUDEPATH += $$PWD/WebKit/qt/WebCoreSupport
+INCLUDEPATH += \
+$$PWD/WebKit/qt/Api \
+$$PWD/WebKit/qt/WebCoreSupport
 
 contains(DEFINES, ENABLE_VIDEO=1) {
 !contains(DEFINES, WTF_USE_QTKIT=1):!contains(DEFINES, WTF_USE_GSTREAMER=1):contains(DEFINES, WTF_USE_QT_MULTIMEDIA=1) {


Modified: trunk/Tools/ChangeLog (102924 => 102925)

--- trunk/Tools/ChangeLog	2011-12-15 13:04:53 UTC (rev 102924)
+++ trunk/Tools/ChangeLog	2011-12-15 13:16:08 UTC (rev 102925)
@@ -1,3 +1,11 @@
+2011-12-15  Tor Arne Vestbø  
+
+[Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
+
+Reviewed by Simon Hausmann.
+
+* qmake/mkspecs/features/webcore.prf:
+
 2011-12-15  Michael Brüning  
 
 [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.


Modified: trunk/Tools/qmake/mkspecs/features/webcore.prf (102924 => 102925)

--- trunk/Tools/qmake/mkspecs/features/webcore.prf	2011-12-15 13:04:53 UTC (rev 102924)
+++ trunk/Tools/qmake/mkspecs/features/webcore.prf	2011-12-15 13:16:08 UTC (rev 102925)
@@ -112,8 +112,6 @@
 $$SOURCE_DIR/WebCore/platform/graphics/qt \
 $$SOURCE_DIR/WebCore/platform/network/qt \
 $$SOURCE_DIR/WebCore/platform/qt \
-$$SOURCE_DIR/WebKit/qt/Api \
-$$SOURCE_DIR/WebKit/qt/WebCoreSupport \
 $$WEBCORE_INCLUDEPATH
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102924] trunk/Source/WebKit2

[hausmann]

Title: [102924] trunk/Source/WebKit2








Revision 102924
Author hausm...@webkit.org
Date 2011-12-15 05:04:53 -0800 (Thu, 15 Dec 2011)


Log Message
[Qt] Cleanup: Remove unnecessary const_cast

Reviewed by Kenneth Christiansen.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::preferences):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102923 => 102924)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 12:40:47 UTC (rev 102923)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 13:04:53 UTC (rev 102924)
@@ -1,3 +1,12 @@
+2011-12-15  Simon Hausmann  
+
+[Qt] Cleanup: Remove unnecessary const_cast
+
+Reviewed by Kenneth Christiansen.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebView::preferences):
+
 2011-12-15  Michael Brüning  
 
 [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (102923 => 102924)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-12-15 12:40:47 UTC (rev 102923)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-12-15 13:04:53 UTC (rev 102924)
@@ -785,7 +785,7 @@
 
 QWebPreferences* QQuickWebView::preferences() const
 {
-QQuickWebViewPrivate* d = const_cast(d_ptr.data());
+QQuickWebViewPrivate* const d = d_ptr.data();
 if (!d->preferences)
 d->preferences = adoptPtr(QWebPreferencesPrivate::createPreferences(d));
 return d->preferences.get();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102923] trunk/Source

[vestbo]

Title: [102923] trunk/Source








Revision 102923
Author ves...@webkit.org
Date 2011-12-15 04:40:47 -0800 (Thu, 15 Dec 2011)


Log Message
[Qt] Get rid of layering violation in PluginViewQt

PluginViewQt has a layering violation in relying on QWebPagePrivate for
the check if running under DRT. We remove this and add a specific flag
in the PluginView for this check, enabled from DRTSupport. This isn't
pretty, but an improvement over what's currently there.

Reviewed by Simon Hausmann.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/PluginView.h
trunk/Source/WebCore/plugins/qt/PluginViewQt.cpp
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102922 => 102923)

--- trunk/Source/WebCore/ChangeLog	2011-12-15 12:38:42 UTC (rev 102922)
+++ trunk/Source/WebCore/ChangeLog	2011-12-15 12:40:47 UTC (rev 102923)
@@ -1,3 +1,19 @@
+2011-12-14  Tor Arne Vestbø  
+
+[Qt] Get rid of layering violation in PluginViewQt
+
+PluginViewQt has a layering violation in relying on QWebPagePrivate for
+the check if running under DRT. We remove this and add a specific flag
+in the PluginView for this check, enabled from DRTSupport. This isn't
+pretty, but an improvement over what's currently there.
+
+Reviewed by Simon Hausmann.
+
+* plugins/PluginView.h:
+* plugins/qt/PluginViewQt.cpp:
+(WebCore::PluginView::updatePluginWidget):
+(WebCore::setXKeyEventSpecificFields):
+
 2011-12-14  Vsevolod Vlasov  
 
 Web Inspector: Console should show network messages origins.


Modified: trunk/Source/WebCore/plugins/PluginView.h (102922 => 102923)

--- trunk/Source/WebCore/plugins/PluginView.h	2011-12-15 12:38:42 UTC (rev 102922)
+++ trunk/Source/WebCore/plugins/PluginView.h	2011-12-15 12:40:47 UTC (rev 102923)
@@ -260,6 +260,11 @@
 #endif
 #endif
 
+#if PLATFORM(QT) && ENABLE(NETSCAPE_PLUGIN_API) && defined(XP_UNIX)
+// PluginViewQt (X11) needs a few workarounds when running under DRT
+static void setIsRunningUnderDRT(bool flag) { s_isRunningUnderDRT = flag; }
+#endif
+
 private:
 PluginView(Frame* parentFrame, const IntSize&, PluginPackage*, Element*, const KURL&, const Vector& paramNames, const Vector& paramValues, const String& mimeType, bool loadManually);
 
@@ -418,8 +423,10 @@
 void initXEvent(XEvent* event);
 #endif
 
-#if PLATFORM(QT) 
+#if PLATFORM(QT)
 #if defined(XP_UNIX) && ENABLE(NETSCAPE_PLUGIN_API)
+static bool s_isRunningUnderDRT;
+static void setXKeyEventSpecificFields(XEvent*, KeyboardEvent*);
 void paintUsingXPixmap(QPainter* painter, const QRect &exposedRect);
 #endif
 #if USE(ACCELERATED_COMPOSITING_PLUGIN_LAYER)


Modified: trunk/Source/WebCore/plugins/qt/PluginViewQt.cpp (102922 => 102923)

--- trunk/Source/WebCore/plugins/qt/PluginViewQt.cpp	2011-12-15 12:38:42 UTC (rev 102922)
+++ trunk/Source/WebCore/plugins/qt/PluginViewQt.cpp	2011-12-15 12:40:47 UTC (rev 102923)
@@ -66,7 +66,6 @@
 #include "RenderLayer.h"
 #include "Settings.h"
 #include "npruntime_impl.h"
-#include "qwebpage_p.h"
 #if USE(JSC)
 #include "runtime_root.h"
 #endif
@@ -102,6 +101,8 @@
 
 namespace WebCore {
 
+bool PluginView::s_isRunningUnderDRT = false;
+
 using namespace HTMLNames;
 
 #if USE(ACCELERATED_COMPOSITING)
@@ -171,7 +172,7 @@
 // (ii) if we are running layout tests from DRT, paint() won't ever get called
 // so we need to call setNPWindowIfNeeded() if window geometry has changed
 if (!m_windowRect.intersects(frameView->frameRect())
-|| (QWebPagePrivate::drtRun && platformPluginWidget() && (m_windowRect != oldWindowRect || m_clipRect != oldClipRect)))
+|| (s_isRunningUnderDRT && platformPluginWidget() && (m_windowRect != oldWindowRect || m_clipRect != oldClipRect)))
 setNPWindowIfNeeded();
 
 if (!m_platformLayer) {
@@ -350,7 +351,7 @@
 setSharedXEventFields(xEvent, ownerWidget);
 }
 
-void setXKeyEventSpecificFields(XEvent* xEvent, KeyboardEvent* event)
+void PluginView::setXKeyEventSpecificFields(XEvent* xEvent, KeyboardEvent* event)
 {
 const PlatformKeyboardEvent* keyEvent = event->keyEvent();
 
@@ -365,7 +366,7 @@
 // case fetch the XEvent's keycode from the event's text. The only
 // place this keycode will be used is in webkit_test_plugin_handle_event().
 // FIXME: Create Qt API so that we can set the appropriate keycode in DRT EventSender instead.
-if (QWebPagePrivate::drtRun && !xEvent->xkey.keycode) {
+if (s_isRunningUnderDRT && !xEvent->xkey.keycode) {
 QKeyEvent* qKeyEvent = keyEvent->qtEvent();
 ASSERT(qKeyEvent);
 QString keyText = qKeyEvent->text().left(1);


Modified: trunk/Source/WebKit/qt/ChangeLog (102922 => 102923)

--- trunk/Source/WebKit/qt/ChangeLog	2011-12-15 12:38:42 UTC (rev 102922)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-12-15 12:40:47 UTC (rev 10

[webkit-changes] [102922] trunk

[commit-queue]

Title: [102922] trunk








Revision 102922
Author commit-qu...@webkit.org
Date 2011-12-15 04:38:42 -0800 (Thu, 15 Dec 2011)


Log Message
[QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
https://bugs.webkit.org/show_bug.cgi?id=72893

Patch by Michael Brüning  on 2011-12-15
Reviewed by Kenneth Rohde Christiansen.

This patch extends QQuickWebViewExperimental by a property named
viewportInfo, which contains the viewport scalability and
layout and contents size information. This property is exposed to
QML through the experimental extension for QQuickWebView.

.:

* Source/qtwebkit-export.map:

Source/WebKit/qt:

* declarative/experimental/plugin.cpp:

Source/WebKit2:

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::computeViewportConstraints):
(QQuickWebViewPrivate::PostTransitionState::apply): Added applying
contentsSize to viewportInfo.
(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebViewExperimental::viewportInfo):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h: Moved PostTransitionState::apply
to qquickwebview.cpp. Added friend QWebViewportInfo.
* UIProcess/API/qt/qwebviewportinfo.cpp: Added.
(QWebViewportInfo::QWebViewportInfo):
(QWebViewportInfo::~QWebViewportInfo):
(QWebViewportInfo::contentsSize):
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):
(QWebViewportInfo::didUpdateContentsSize):
(QWebViewportInfo::didUpdateCurrentScale):
(QWebViewportInfo::didUpdateViewportConstraints):
* UIProcess/API/qt/qwebviewportinfo_p.h: Added.
* UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit::QtViewportInteractionEngine::Constraints::Constraints): Added layoutSize.
(WebKit::QtViewportInteractionEngine::constraints): Added property to access m_contraints.

Tools:

* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/icons/info.png: Added.
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h
trunk/Source/qtwebkit-export.map
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/MiniBrowser.pro
trunk/Tools/MiniBrowser/qt/MiniBrowser.qrc
trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml


Added Paths

trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo_p.h
trunk/Tools/MiniBrowser/qt/icons/info.png
trunk/Tools/MiniBrowser/qt/qml/ViewportInfoItem.qml




Diff

Modified: trunk/ChangeLog (102921 => 102922)

--- trunk/ChangeLog	2011-12-15 12:35:27 UTC (rev 102921)
+++ trunk/ChangeLog	2011-12-15 12:38:42 UTC (rev 102922)
@@ -1,3 +1,17 @@
+2011-12-15  Michael Brüning  
+
+[QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
+https://bugs.webkit.org/show_bug.cgi?id=72893
+
+Reviewed by Kenneth Rohde Christiansen.
+
+This patch extends QQuickWebViewExperimental by a property named
+viewportInfo, which contains the viewport scalability and
+layout and contents size information. This property is exposed to
+QML through the experimental extension for QQuickWebView.
+
+* Source/qtwebkit-export.map:
+
 2011-12-14  Ryosuke Niwa  
 
 Add a manual test for caret blinking during forward deletion


Modified: trunk/Source/WebKit/qt/ChangeLog (102921 => 102922)

--- trunk/Source/WebKit/qt/ChangeLog	2011-12-15 12:35:27 UTC (rev 102921)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-12-15 12:38:42 UTC (rev 102922)
@@ -1,3 +1,17 @@
+2011-12-15  Michael Brüning  
+
+[QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
+https://bugs.webkit.org/show_bug.cgi?id=72893
+
+Reviewed by Kenneth Rohde Christiansen.
+
+This patch extends QQuickWebViewExperimental by a property named
+viewportInfo, which contains the viewport scalability and
+layout and contents size information. This property is exposed to
+QML through the experimental extension for QQuickWebView.
+
+* declarative/experimental/plugin.cpp:
+
 2011-12-15  Alexander Færøy  
 
 [Qt] Remove unnecessary methods and members from DeviceOrientationClientQt


Modified: trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp (102921 => 102922)

--- trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp	2011-12-15 12:35:27 UTC (rev 102921)
+++ trunk/Source/WebKit/qt/de

[webkit-changes] [102921] trunk/Source/WebKit/chromium

[peter]

Title: [102921] trunk/Source/WebKit/chromium








Revision 102921
Author pe...@chromium.org
Date 2011-12-15 04:35:27 -0800 (Thu, 15 Dec 2011)


Log Message
[Chromium] Enable TestNetscapePlugIn to link for Android
https://bugs.webkit.org/show_bug.cgi?id=74597

Reviewed by Tony Gentilcore.

The -nostdlib linker flag is being passed to all targets being build
for Android, which conflicts with the shared library the
TestNetscapePlugIn target created. Explicitly exclude the flag.

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102920 => 102921)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 12:31:48 UTC (rev 102920)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-15 12:35:27 UTC (rev 102921)
@@ -1,3 +1,16 @@
+2011-12-15  Peter Beverloo  
+
+[Chromium] Enable TestNetscapePlugIn to link for Android
+https://bugs.webkit.org/show_bug.cgi?id=74597
+
+Reviewed by Tony Gentilcore.
+
+The -nostdlib linker flag is being passed to all targets being build
+for Android, which conflicts with the shared library the
+TestNetscapePlugIn target created. Explicitly exclude the flag.
+
+* WebKit.gyp:
+
 2011-12-14  David Levin  
 
 [chromium] DatabaseObserver needs threadsafe fixes and other clean-up.


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (102920 => 102921)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2011-12-15 12:31:48 UTC (rev 102920)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2011-12-15 12:35:27 UTC (rev 102921)
@@ -1452,6 +1452,11 @@
 '-fvisibility=default',
 ],
 }],
+['OS=="android"', {
+'ldflags!': [
+'-nostdlib',
+],
+}],
 ['OS=="win"', {
 'defines': [
 # This seems like a hack, but this is what Safari Win does.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102920] trunk/Source/WebKit2

[commit-queue]

Title: [102920] trunk/Source/WebKit2








Revision 102920
Author commit-qu...@webkit.org
Date 2011-12-15 04:31:48 -0800 (Thu, 15 Dec 2011)


Log Message
[WK2] WebPage::m_useFixedLayout variable unininitialized
https://bugs.webkit.org/show_bug.cgi?id=74596

Patch by Simon Hausmann  on 2011-12-15
Reviewed by Kenneth Rohde Christiansen.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Avoid uninitialized use through
initialization in the constructor.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102919 => 102920)

--- trunk/Source/WebKit2/ChangeLog	2011-12-15 12:16:04 UTC (rev 102919)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-15 12:31:48 UTC (rev 102920)
@@ -1,3 +1,14 @@
+2011-12-15  Simon Hausmann  
+
+[WK2] WebPage::m_useFixedLayout variable unininitialized
+https://bugs.webkit.org/show_bug.cgi?id=74596
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::WebPage): Avoid uninitialized use through
+initialization in the constructor.
+
 2011-12-15  Alexander Færøy  
 
 [Qt] r102849 broke the Qt build on Mac OS X.


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (102919 => 102920)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2011-12-15 12:16:04 UTC (rev 102919)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2011-12-15 12:31:48 UTC (rev 102920)
@@ -174,6 +174,7 @@
 
 WebPage::WebPage(uint64_t pageID, const WebPageCreationParameters& parameters)
 : m_viewSize(parameters.viewSize)
+, m_useFixedLayout(false)
 , m_drawsBackground(true)
 , m_drawsTransparentBackground(false)
 , m_isInRedo(false)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes