[webkit-changes] [104579] trunk/LayoutTests
Title: [104579] trunk/LayoutTests
Revision 104579
Author jknot...@chromium.org
Date 2012-01-10 08:23:54 -0800 (Tue, 10 Jan 2012)
Log Message
Rebaseline fast/text/unicode-variation-selector.html following r104545.
* platform/chromium-win/fast/text/unicode-variation-selector-expected.png:
* platform/chromium/fast/text/unicode-variation-selector-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/fast/text/unicode-variation-selector-expected.png
Removed Paths
trunk/LayoutTests/platform/chromium/fast/text/unicode-variation-selector-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (104578 => 104579)
--- trunk/LayoutTests/ChangeLog 2012-01-10 16:03:44 UTC (rev 104578)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 16:23:54 UTC (rev 104579)
@@ -1,3 +1,10 @@
+2012-01-10 John Knottenbelt jknot...@chromium.org
+
+Rebaseline fast/text/unicode-variation-selector.html following r104545.
+
+* platform/chromium-win/fast/text/unicode-variation-selector-expected.png:
+* platform/chromium/fast/text/unicode-variation-selector-expected.txt: Removed.
+
2012-01-10 Julien Chaffraix jchaffr...@webkit.org
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
Deleted: trunk/LayoutTests/platform/chromium/fast/text/unicode-variation-selector-expected.txt (104578 => 104579)
--- trunk/LayoutTests/platform/chromium/fast/text/unicode-variation-selector-expected.txt 2012-01-10 16:03:44 UTC (rev 104578)
+++ trunk/LayoutTests/platform/chromium/fast/text/unicode-variation-selector-expected.txt 2012-01-10 16:23:54 UTC (rev 104579)
@@ -1,26 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x54
-RenderText {#text} at (0,0) size 775x54
- text run at (0,0) width 496: This page ensures that WebKit can render unicode variation selector correctly.
- text run at (496,0) width 254: On platforms which support UVSes, the
- text run at (0,18) width 676: glyphs of U+845B should be different. On platforms which don't support UVSes, they should be identical.
- text run at (676,18) width 99: In addition, any
- text run at (0,36) width 579: glyphs (including the last resort glyph) should not appear after the U+845B on all platforms.
- RenderBlock {DIV} at (0,70) size 784x18
-RenderText {#text} at (0,0) size 289x18
- text run at (0,0) width 289: Glyph for code point U+845B without UVS:
-RenderInline {SPAN} at (0,0) size 16x15
- RenderText {#text} at (289,0) size 16x15
-text run at (289,0) width 16: \x{845B}
-RenderText {#text} at (0,0) size 0x0
- RenderBlock {DIV} at (0,88) size 784x18
-RenderText {#text} at (0,0) size 269x18
- text run at (0,0) width 269: Glyph for code point U+845B with UVS:
-RenderInline {SPAN} at (0,0) size 16x15
- RenderText {#text} at (269,0) size 16x15
-text run at (269,0) width 16: \x{845B}\x{DB40}\x{DD00}
-RenderText {#text} at (0,0) size 0x0
Modified: trunk/LayoutTests/platform/chromium-win/fast/text/unicode-variation-selector-expected.png
(Binary files differ)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104580] trunk/PerformanceTests
Title: [104580] trunk/PerformanceTests
Revision 104580
Author loi...@chromium.org
Date 2012-01-10 08:31:28 -0800 (Tue, 10 Jan 2012)
Log Message
Unreviewed. Restore test that was removed during migration from LayoutTests folder.
* inspector/first-open-resources.html: Added.
Modified Paths
trunk/PerformanceTests/ChangeLog
Added Paths
trunk/PerformanceTests/inspector/first-open-resources.html
Diff
Modified: trunk/PerformanceTests/ChangeLog (104579 => 104580)
--- trunk/PerformanceTests/ChangeLog 2012-01-10 16:23:54 UTC (rev 104579)
+++ trunk/PerformanceTests/ChangeLog 2012-01-10 16:31:28 UTC (rev 104580)
@@ -1,3 +1,9 @@
+2012-01-10 Ilya Tikhonovsky loi...@chromium.org
+
+Unreviewed. Restore test that was removed during migration from LayoutTests folder.
+
+* inspector/first-open-resources.html: Added.
+
2012-01-09 Ilya Tikhonovsky loi...@chromium.org
Unreviewed test fix after r103683.
Added: trunk/PerformanceTests/inspector/first-open-resources.html (0 => 104580)
--- trunk/PerformanceTests/inspector/first-open-resources.html (rev 0)
+++ trunk/PerformanceTests/inspector/first-open-resources.html 2012-01-10 16:31:28 UTC (rev 104580)
@@ -0,0 +1,37 @@
+html
+head
+script src=""
+script src=""
+script
+
+function test()
+{
+WebInspector.showPanel(resources);
+console.log(test: + WebInspector.inspectedPageURL);
+WebInspector.settings.resourcesLastSelectedItem.set(WebInspector.inspectedPageURL);
+
+function test(timer)
+{
+WebInspector.showPanel(audits);
+
+var showPanelTimerCookie = timer.start(first-open-resources);
+InspectorTest.addBackendResponseSniffer(PageAgent, getResourceTree, function() {
+timer.finish(showPanelTimerCookie);
+timer.done(first-open);
+});
+WebInspector.panels.resources.reset();
+WebInspector.panels.resources._initialized = false;
+WebInspector.resourceTreeModel._fetchResourceTree();
+WebInspector.showPanel(resources);
+}
+
+InspectorTest.runPerformanceTest(test, 5000);
+}
+
+/script
+/head
+body _onload_=runTest()
+/body
+/body
+/html
+
Property changes on: trunk/PerformanceTests/inspector/first-open-resources.html
___
Added: svn:eol-style
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104581] trunk/PerformanceTests
Title: [104581] trunk/PerformanceTests
Revision 104581
Author loi...@chromium.org
Date 2012-01-10 08:39:10 -0800 (Tue, 10 Jan 2012)
Log Message
Unreviewed. WebInspector: Remove unnecessary logging from the test.
* inspector/first-open-resources.html:
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/inspector/first-open-resources.html
Diff
Modified: trunk/PerformanceTests/ChangeLog (104580 => 104581)
--- trunk/PerformanceTests/ChangeLog 2012-01-10 16:31:28 UTC (rev 104580)
+++ trunk/PerformanceTests/ChangeLog 2012-01-10 16:39:10 UTC (rev 104581)
@@ -1,5 +1,11 @@
2012-01-10 Ilya Tikhonovsky loi...@chromium.org
+Unreviewed. WebInspector: Remove unnecessary logging from the test.
+
+* inspector/first-open-resources.html:
+
+2012-01-10 Ilya Tikhonovsky loi...@chromium.org
+
Unreviewed. Restore test that was removed during migration from LayoutTests folder.
* inspector/first-open-resources.html: Added.
Modified: trunk/PerformanceTests/inspector/first-open-resources.html (104580 => 104581)
--- trunk/PerformanceTests/inspector/first-open-resources.html 2012-01-10 16:31:28 UTC (rev 104580)
+++ trunk/PerformanceTests/inspector/first-open-resources.html 2012-01-10 16:39:10 UTC (rev 104581)
@@ -7,7 +7,6 @@
function test()
{
WebInspector.showPanel(resources);
-console.log(test: + WebInspector.inspectedPageURL);
WebInspector.settings.resourcesLastSelectedItem.set(WebInspector.inspectedPageURL);
function test(timer)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104582] trunk/Source/WebKit2
Title: [104582] trunk/Source/WebKit2 Revision 104582 Author kenn...@webkit.org Date 2012-01-10 08:44:01 -0800 (Tue, 10 Jan 2012) Log Message Unreviewed potential Mac WK2 build fix. * UIProcess/PageClient.h: forward declare WebGestureEvent. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/PageClient.h Diff Modified: trunk/Source/WebKit2/ChangeLog (104581 => 104582) --- trunk/Source/WebKit2/ChangeLog 2012-01-10 16:39:10 UTC (rev 104581) +++ trunk/Source/WebKit2/ChangeLog 2012-01-10 16:44:01 UTC (rev 104582) @@ -1,3 +1,9 @@ +2012-01-10 Kenneth Rohde Christiansen kenn...@webkit.org + +Unreviewed potential Mac WK2 build fix. + +* UIProcess/PageClient.h: forward declare WebGestureEvent. + 2012-01-10 Csaba Osztrogonác o...@webkit.org Unreviewed, rolling out an accidental commit r104569. Modified: trunk/Source/WebKit2/UIProcess/PageClient.h (104581 => 104582) --- trunk/Source/WebKit2/UIProcess/PageClient.h 2012-01-10 16:39:10 UTC (rev 104581) +++ trunk/Source/WebKit2/UIProcess/PageClient.h 2012-01-10 16:44:01 UTC (rev 104582) @@ -52,6 +52,9 @@ #if ENABLE(TOUCH_EVENTS) class NativeWebTouchEvent; #endif +#if ENABLE(GESTURE_EVENTS) +class WebGestureEvent; +#endif class WebContextMenuProxy; class WebEditCommandProxy; class WebPopupMenuProxy; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104583] trunk/LayoutTests
Title: [104583] trunk/LayoutTests Revision 104583 Author jknot...@chromium.org Date 2012-01-10 08:45:55 -0800 (Tue, 10 Jan 2012) Log Message [Chromium] Clean up test expectations for mac. https://bugs.webkit.org/show_bug.cgi?id=75966 Unreviewed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104582 => 104583) --- trunk/LayoutTests/ChangeLog 2012-01-10 16:44:01 UTC (rev 104582) +++ trunk/LayoutTests/ChangeLog 2012-01-10 16:45:55 UTC (rev 104583) @@ -1,5 +1,14 @@ 2012-01-10 John Knottenbelt jknot...@chromium.org +[Chromium] Clean up test expectations for mac. +https://bugs.webkit.org/show_bug.cgi?id=75966 + +Unreviewed. + +* platform/chromium/test_expectations.txt: + +2012-01-10 John Knottenbelt jknot...@chromium.org + Rebaseline fast/text/unicode-variation-selector.html following r104545. * platform/chromium-win/fast/text/unicode-variation-selector-expected.png: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104582 => 104583) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 16:44:01 UTC (rev 104582) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 16:45:55 UTC (rev 104583) @@ -939,6 +939,7 @@ BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr.html = FAIL BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr.html = FAIL BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop.html = FAIL + BUGSENORBLANCO : svg/filters/feColorMatrix-offset.svg = FAIL BUGSENORBLANCO : svg/filters/feColorMatrix-saturate.svg = FAIL @@ -3095,17 +3096,12 @@ // Has been going on for at least a few weeks (as of 20/5/2011) BUGCR83426 MAC : svg/as-border-image/svg-as-border-image-2.html = PASS IMAGE BUGCR83426 MAC : svg/as-border-image/svg-as-border-image.html = PASS IMAGE -BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-color-01-b.svg = PASS IMAGE BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-specular-01-f.svg = PASS IMAGE BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-turb-01-f.svg = PASS IMAGE BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-turb-02-f.svg = PASS IMAGE BUGCR83426 MAC : svg/W3C-SVG-1.1/masking-mask-01-b.svg = PASS IMAGE BUGCR83426 MAC : svg/css/circle-in-mask-with-shadow.svg = PASS IMAGE BUGCR83426 MAC : svg/custom/foreign-object-skew.svg = PASS IMAGE -BUGCR83426 MAC : svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr.html = PASS IMAGE -BUGCR83426 MAC : svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr.html = PASS IMAGE -BUGCR83426 MAC : svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr.html = PASS IMAGE -BUGCR83426 MAC : svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop.html = PASS IMAGE BUGCR83426 MAC : svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html = PASS IMAGE BUGCR83426 MAC : svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.html = PASS IMAGE BUGCR83426 MAC : svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104584] trunk
Title: [104584] trunk
Revision 104584
Author o...@webkit.org
Date 2012-01-10 08:47:59 -0800 (Tue, 10 Jan 2012)
Log Message
Unreviewed, rolling out r104572.
http://trac.webkit.org/changeset/104572
https://bugs.webkit.org/show_bug.cgi?id=75967
It broke zillion tests (Requested by Ossy on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-01-10
Tools:
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::sendOrQueueEvent):
(EventSender::replaySavedEvents):
(EventSender::eventFilter):
* DumpRenderTree/qt/EventSenderQt.h:
LayoutTests:
* platform/qt-wk1/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-wk1/Skipped
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/EventSenderQt.cpp
trunk/Tools/DumpRenderTree/qt/EventSenderQt.h
Diff
Modified: trunk/LayoutTests/ChangeLog (104583 => 104584)
--- trunk/LayoutTests/ChangeLog 2012-01-10 16:45:55 UTC (rev 104583)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 16:47:59 UTC (rev 104584)
@@ -1,3 +1,13 @@
+2012-01-10 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r104572.
+http://trac.webkit.org/changeset/104572
+https://bugs.webkit.org/show_bug.cgi?id=75967
+
+It broke zillion tests (Requested by Ossy on #webkit).
+
+* platform/qt-wk1/Skipped:
+
2012-01-10 John Knottenbelt jknot...@chromium.org
[Chromium] Clean up test expectations for mac.
Modified: trunk/LayoutTests/platform/qt-wk1/Skipped (104583 => 104584)
--- trunk/LayoutTests/platform/qt-wk1/Skipped 2012-01-10 16:45:55 UTC (rev 104583)
+++ trunk/LayoutTests/platform/qt-wk1/Skipped 2012-01-10 16:47:59 UTC (rev 104584)
@@ -1,5 +1,9 @@
# Tests failing on WK1 only (working on WK2)
+# New test introduced in r102048 fails on Qt-WK1
+# https://bugs.webkit.org/show_bug.cgi?id=73366
+fast/events/dont-loose-last-event.html
+
# This has been fixed only on qt-wk2
# https://bugs.webkit.org/show_bug.cgi?id=45666
fast/events/click-count.html
Modified: trunk/Tools/ChangeLog (104583 => 104584)
--- trunk/Tools/ChangeLog 2012-01-10 16:45:55 UTC (rev 104583)
+++ trunk/Tools/ChangeLog 2012-01-10 16:47:59 UTC (rev 104584)
@@ -1,3 +1,18 @@
+2012-01-10 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r104572.
+http://trac.webkit.org/changeset/104572
+https://bugs.webkit.org/show_bug.cgi?id=75967
+
+It broke zillion tests (Requested by Ossy on #webkit).
+
+* DumpRenderTree/qt/EventSenderQt.cpp:
+(EventSender::EventSender):
+(EventSender::sendOrQueueEvent):
+(EventSender::replaySavedEvents):
+(EventSender::eventFilter):
+* DumpRenderTree/qt/EventSenderQt.h:
+
2012-01-10 Hugo Parente Lima hugo.l...@openbossa.org
[Qt] fast/events/dont-loose-last-event test fails on WK1
Modified: trunk/Tools/DumpRenderTree/qt/EventSenderQt.cpp (104583 => 104584)
--- trunk/Tools/DumpRenderTree/qt/EventSenderQt.cpp 2012-01-10 16:45:55 UTC (rev 104583)
+++ trunk/Tools/DumpRenderTree/qt/EventSenderQt.cpp 2012-01-10 16:47:59 UTC (rev 104584)
@@ -45,6 +45,8 @@
// Hence Qt DRT adopts a fixed zoom-factor (1.2) for compatibility.
#define ZOOM_STEP 1.2
+#define DRT_MESSAGE_DONE (QEvent::User + 1)
+
struct DRTEventQueue {
QEvent* m_event;
int m_delay;
@@ -52,18 +54,21 @@
static DRTEventQueue eventQueue[1024];
static unsigned endOfQueue;
-static bool isReplayingEvents;
+static unsigned startOfQueue;
EventSender::EventSender(QWebPage* parent)
: QObject(parent)
{
m_page = parent;
+m_mouseButtonPressed = false;
+m_drag = false;
memset(eventQueue, 0, sizeof(eventQueue));
endOfQueue = 0;
-isReplayingEvents = false;
+startOfQueue = 0;
m_eventLoop = 0;
m_currentButton = 0;
resetClickCount();
+m_page-view()-installEventFilter(this);
// So that we can match Scrollbar::pixelsPerLineStep() in WheelEventQt.cpp and
// pass fast/events/platform-wheelevent-in-scrolling-div.html
QApplication::setWheelScrollLines(2);
@@ -554,34 +559,73 @@
// 2. A delay was set-up by leapForward().
// 3. A call to mouseMoveTo while the mouse button is pressed could initiate a drag operation, and that does not return until mouseUp is processed.
// To be safe and avoid a deadlock, this event is queued.
-if (!endOfQueue !eventQueue[endOfQueue].m_delay) {
+if (endOfQueue == startOfQueue !eventQueue[endOfQueue].m_delay (!(m_mouseButtonPressed (m_eventLoop event-type() == QEvent::MouseButtonRelease {
sendEvent(m_page-view(), event);
delete event;
return;
}
eventQueue[endOfQueue++].m_event = event;
eventQueue[endOfQueue].m_delay = 0;
-replaySavedEvents();
+replaySavedEvents(event-type() != QEvent::MouseMove);
}
-void EventSender::replaySavedEvents()
+void EventSender::replaySavedEvents(bool flush)
{
-if (isReplayingEvents)
+
[webkit-changes] [104585] trunk
Title: [104585] trunk
Revision 104585
Author commit-qu...@webkit.org
Date 2012-01-10 08:54:29 -0800 (Tue, 10 Jan 2012)
Log Message
[Chromium] Shift PathSkia to use Skia's new RawIter
https://bugs.webkit.org/show_bug.cgi?id=75703
Patch by Stephen Chenney schen...@chromium.org on 2012-01-10
Reviewed by Nikolas Zimmermann.
Source/WebCore:
No new tests required - covered by existing tests.
* platform/graphics/Path.h: Added comments ont he return values from iteration.
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::apply): Switched to SkPath::RawIter
LayoutTests:
* platform/chromium/test_expectations.txt: Updated epxectation for
tests that may change after this modification.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Path.h
trunk/Source/WebCore/platform/graphics/skia/PathSkia.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (104584 => 104585)
--- trunk/LayoutTests/ChangeLog 2012-01-10 16:47:59 UTC (rev 104584)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 16:54:29 UTC (rev 104585)
@@ -1,3 +1,13 @@
+2012-01-10 Stephen Chenney schen...@chromium.org
+
+[Chromium] Shift PathSkia to use Skia's new RawIter
+https://bugs.webkit.org/show_bug.cgi?id=75703
+
+Reviewed by Nikolas Zimmermann.
+
+* platform/chromium/test_expectations.txt: Updated epxectation for
+ tests that may change after this modification.
+
2012-01-10 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r104572.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104584 => 104585)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 16:47:59 UTC (rev 104584)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 16:54:29 UTC (rev 104585)
@@ -879,6 +879,11 @@
// Merge 39744:39829 - regression
BUGCR10284 MAC : svg/custom/path-bad-data.svg = FAIL
+// Needs rebaselining after BUGWK75703. Old results are, in fact, incorrect.
+BUGWK75703 : svg/custom/shapes-supporting-markers.svg = PASS IMAGE+TEXT TEXT IMAGE
+BUGWK75703 : svg/W3C-SVG-1.1/painting-marker-02-f.svg = PASS IMAGE
+BUGWK75703 : svg/W3C-SVG-1.1/painting-marker-03-f.svg = PASS IMAGE
+
// Text mismatch since r65370.
// There was also an unnoticed image mismatch before this revision
// (wrong baseline was committed). No idea about when it really started to fail.
Modified: trunk/Source/WebCore/ChangeLog (104584 => 104585)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 16:47:59 UTC (rev 104584)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 16:54:29 UTC (rev 104585)
@@ -1,3 +1,16 @@
+2012-01-10 Stephen Chenney schen...@chromium.org
+
+[Chromium] Shift PathSkia to use Skia's new RawIter
+https://bugs.webkit.org/show_bug.cgi?id=75703
+
+Reviewed by Nikolas Zimmermann.
+
+No new tests required - covered by existing tests.
+
+* platform/graphics/Path.h: Added comments ont he return values from iteration.
+* platform/graphics/skia/PathSkia.cpp:
+(WebCore::Path::apply): Switched to SkPath::RawIter
+
2012-01-10 Peter Beverloo pe...@chromium.org
[Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type
Modified: trunk/Source/WebCore/platform/graphics/Path.h (104584 => 104585)
--- trunk/Source/WebCore/platform/graphics/Path.h 2012-01-10 16:47:59 UTC (rev 104584)
+++ trunk/Source/WebCore/platform/graphics/Path.h 2012-01-10 16:54:29 UTC (rev 104585)
@@ -80,13 +80,16 @@
class StrokeStyleApplier;
enum PathElementType {
-PathElementMoveToPoint,
-PathElementAddLineToPoint,
-PathElementAddQuadCurveToPoint,
-PathElementAddCurveToPoint,
-PathElementCloseSubpath
+PathElementMoveToPoint, // The points member will contain 1 value.
+PathElementAddLineToPoint, // The points member will contain 1 value.
+PathElementAddQuadCurveToPoint, // The points member will contain 2 values.
+PathElementAddCurveToPoint, // The points member will contain 3 values.
+PathElementCloseSubpath // The points member will contain no values.
};
+// The points in the sturcture are the same as those that would be used with the
+// add... method. For example, a line returns the endpoint, while a cubic returns
+// two tangent points and the endpoint.
struct PathElement {
PathElementType type;
FloatPoint* points;
Modified: trunk/Source/WebCore/platform/graphics/skia/PathSkia.cpp (104584 => 104585)
--- trunk/Source/WebCore/platform/graphics/skia/PathSkia.cpp 2012-01-10 16:47:59 UTC (rev 104584)
+++ trunk/Source/WebCore/platform/graphics/skia/PathSkia.cpp 2012-01-10 16:54:29 UTC (rev 104585)
@@ -197,7 +197,7 @@
void Path::apply(void* info, PathApplierFunction function) const
{
-SkPath::Iter iter(*m_path, false);
+SkPath::RawIter
[webkit-changes] [104586] trunk/Source/WebCore
Title: [104586] trunk/Source/WebCore Revision 104586 Author pfeld...@chromium.org Date 2012-01-10 09:01:05 -0800 (Tue, 10 Jan 2012) Log Message Web Inspector: add free flow DOM editing experiment. https://bugs.webkit.org/show_bug.cgi?id=75955 This change enables HTML editing from Resources panel experiment. Reviewed by Yury Semikhatsky. * CMakeLists.txt: * English.lproj/localizedStrings.js: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * inspector/DOMEditor.cpp: Added. (WebCore::DOMEditor::DOMEditor): (WebCore::DOMEditor::~DOMEditor): (WebCore::DOMEditor::patch): (WebCore::DOMEditor::NodeDigest::NodeDigest): (WebCore::DOMEditor::patchElement): (WebCore::DOMEditor::patchNode): (WebCore::DOMEditor::patchChildren): (WebCore::addStringToSHA1): (WebCore::DOMEditor::createNodeDigest): * inspector/DOMEditor.h: Added. * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setOuterHTML): * inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent): (WebInspector.DOMModelResourceBinding): (WebInspector.DOMModelResourceBinding.prototype.setContent): (WebInspector.DOMModelResourceBinding.prototype.canSetContent): * inspector/front-end/Settings.js: (WebInspector.ExperimentsSettings): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp trunk/Source/WebCore/inspector/front-end/DOMAgent.js trunk/Source/WebCore/inspector/front-end/Settings.js Added Paths trunk/Source/WebCore/inspector/DOMEditor.cpp trunk/Source/WebCore/inspector/DOMEditor.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (104585 => 104586) --- trunk/Source/WebCore/CMakeLists.txt 2012-01-10 16:54:29 UTC (rev 104585) +++ trunk/Source/WebCore/CMakeLists.txt 2012-01-10 17:01:05 UTC (rev 104586) @@ -870,6 +870,7 @@ inspector/ConsoleMessage.cpp inspector/ContentSearchUtils.cpp +inspector/DOMEditor.cpp inspector/DOMNodeHighlighter.cpp inspector/IdentifiersFactory.cpp inspector/InjectedScript.cpp Modified: trunk/Source/WebCore/ChangeLog (104585 => 104586) --- trunk/Source/WebCore/ChangeLog 2012-01-10 16:54:29 UTC (rev 104585) +++ trunk/Source/WebCore/ChangeLog 2012-01-10 17:01:05 UTC (rev 104586) @@ -1,3 +1,40 @@ +2012-01-10 Pavel Feldman pfeld...@google.com + +Web Inspector: add free flow DOM editing experiment. +https://bugs.webkit.org/show_bug.cgi?id=75955 + +This change enables HTML editing from Resources panel experiment. + +Reviewed by Yury Semikhatsky. + +* CMakeLists.txt: +* English.lproj/localizedStrings.js: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* inspector/DOMEditor.cpp: Added. +(WebCore::DOMEditor::DOMEditor): +(WebCore::DOMEditor::~DOMEditor): +(WebCore::DOMEditor::patch): +(WebCore::DOMEditor::NodeDigest::NodeDigest): +(WebCore::DOMEditor::patchElement): +(WebCore::DOMEditor::patchNode): +(WebCore::DOMEditor::patchChildren): +(WebCore::addStringToSHA1): +(WebCore::DOMEditor::createNodeDigest): +* inspector/DOMEditor.h: Added. +* inspector/InspectorDOMAgent.cpp: +(WebCore::InspectorDOMAgent::setOuterHTML): +* inspector/front-end/DOMAgent.js: +(WebInspector.DOMAgent): +(WebInspector.DOMModelResourceBinding): +(WebInspector.DOMModelResourceBinding.prototype.setContent): +(WebInspector.DOMModelResourceBinding.prototype.canSetContent): +* inspector/front-end/Settings.js: +(WebInspector.ExperimentsSettings): + 2012-01-10 Stephen Chenney schen...@chromium.org [Chromium] Shift PathSkia to use Skia's new RawIter Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (Binary files differ) Modified: trunk/Source/WebCore/GNUmakefile.list.am (104585 => 104586) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-01-10 16:54:29 UTC (rev 104585) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-01-10 17:01:05 UTC (rev 104586) @@ -2327,6 +2327,8 @@ Source/WebCore/inspector/ConsoleMessage.h \ Source/WebCore/inspector/ContentSearchUtils.cpp \ Source/WebCore/inspector/ContentSearchUtils.h \ + Source/WebCore/inspector/DOMEditor.cpp \ + Source/WebCore/inspector/DOMEditor.h \ Source/WebCore/inspector/DOMNodeHighlighter.cpp \ Source/WebCore/inspector/DOMNodeHighlighter.h \ Source/WebCore/inspector/DOMWrapperVisitor.h \ Modified: trunk/Source/WebCore/Target.pri (104585 => 104586) ---
[webkit-changes] [104587] trunk/LayoutTests
Title: [104587] trunk/LayoutTests
Revision 104587
Author o...@webkit.org
Date 2012-01-10 09:19:08 -0800 (Tue, 10 Jan 2012)
Log Message
[Qt] Unreviewed gardening. Remove png and txt expected files for reftests.
* platform/qt/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-017-expected.txt: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-037-expected.txt: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-038-expected.txt: Removed.
* platform/qt/fast/writing-mode/margins-expected.png: Removed.
* platform/qt/fast/writing-mode/margins-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-016-expected.png
trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt
trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-017-expected.png
trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-017-expected.txt
trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-037-expected.png
trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-037-expected.txt
trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-038-expected.png
trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-038-expected.txt
trunk/LayoutTests/platform/qt/fast/writing-mode/margins-expected.png
trunk/LayoutTests/platform/qt/fast/writing-mode/margins-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (104586 => 104587)
--- trunk/LayoutTests/ChangeLog 2012-01-10 17:01:05 UTC (rev 104586)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 17:19:08 UTC (rev 104587)
@@ -1,3 +1,18 @@
+2012-01-10 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Unreviewed gardening. Remove png and txt expected files for reftests.
+
+* platform/qt/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
+* platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt: Removed.
+* platform/qt/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
+* platform/qt/css2.1/20110323/border-conflict-element-017-expected.txt: Removed.
+* platform/qt/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
+* platform/qt/css2.1/20110323/border-conflict-element-037-expected.txt: Removed.
+* platform/qt/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
+* platform/qt/css2.1/20110323/border-conflict-element-038-expected.txt: Removed.
+* platform/qt/fast/writing-mode/margins-expected.png: Removed.
+* platform/qt/fast/writing-mode/margins-expected.txt: Removed.
+
2012-01-10 Stephen Chenney schen...@chromium.org
[Chromium] Shift PathSkia to use Skia's new RawIter
Deleted: trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-016-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt (104586 => 104587)
--- trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt 2012-01-10 17:01:05 UTC (rev 104586)
+++ trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt 2012-01-10 17:19:08 UTC (rev 104587)
@@ -1,14 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x253
- RenderBlock {HTML} at (0,0) size 800x253
-RenderBody {BODY} at (8,16) size 784x229
- RenderBlock {P} at (0,0) size 784x21
-RenderText {#text} at (0,0) size 345x21
- text run at (0,0) width 345: Test passes if there is no red visible on the page.
- RenderTable {TABLE} at (0,37) size 192x192 [border: (2px none #808080)]
-RenderTableCol {COLGROUP} at (0,0) size 0x0
- RenderTableCol {COL} at (0,0) size 0x0 [border: (5px solid #FF)]
-RenderTableSection {TBODY} at (2,2) size 187x187
- RenderTableRow {TR} at (0,0) size 187x187 [border: (5px solid #00)]
-RenderTableCell {TD} at (0,90) size 187x7 [border: (3px none #00)] [r=0 c=0 rs=1 cs=1]
Deleted: trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-017-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-017-expected.txt (104586 => 104587)
--- trunk/LayoutTests/platform/qt/css2.1/20110323/border-conflict-element-017-expected.txt 2012-01-10 17:01:05 UTC (rev 104586)
+++
[webkit-changes] [104588] trunk/LayoutTests
Title: [104588] trunk/LayoutTests Revision 104588 Author jchaffr...@webkit.org Date 2012-01-10 09:34:33 -0800 (Tue, 10 Jan 2012) Log Message REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling https://bugs.webkit.org/show_bug.cgi?id=67100 Unreviewed, chromium rebaselining after r104575. The SL baseline for scroll-with-transform-layer.html is missing some scroll thumbs (http://webkit.org/b/75969). * platform/chromium-linux/fast/layers/scroll-with-transform-composited-layer-expected.png: Added. * platform/chromium-linux/fast/layers/scroll-with-transform-layer-expected.png: Added. * platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added. * platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added. * platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png: Added. * platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-linux/fast/layers/scroll-with-transform-composited-layer-expected.png trunk/LayoutTests/platform/chromium-linux/fast/layers/scroll-with-transform-layer-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png trunk/LayoutTests/platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png trunk/LayoutTests/platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (104587 => 104588) --- trunk/LayoutTests/ChangeLog 2012-01-10 17:19:08 UTC (rev 104587) +++ trunk/LayoutTests/ChangeLog 2012-01-10 17:34:33 UTC (rev 104588) @@ -1,3 +1,19 @@ +2012-01-10 Julien Chaffraix jchaffr...@webkit.org + +REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling +https://bugs.webkit.org/show_bug.cgi?id=67100 + +Unreviewed, chromium rebaselining after r104575. + +The SL baseline for scroll-with-transform-layer.html is missing some scroll thumbs (http://webkit.org/b/75969). + +* platform/chromium-linux/fast/layers/scroll-with-transform-composited-layer-expected.png: Added. +* platform/chromium-linux/fast/layers/scroll-with-transform-layer-expected.png: Added. +* platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added. +* platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added. +* platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png: Added. +* platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png: Added. + 2012-01-10 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed gardening. Remove png and txt expected files for reftests. Added: trunk/LayoutTests/platform/chromium-linux/fast/layers/scroll-with-transform-composited-layer-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/layers/scroll-with-transform-composited-layer-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-linux/fast/layers/scroll-with-transform-layer-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/layers/scroll-with-transform-layer-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png (Binary files differ) Property changes on:
[webkit-changes] [104589] trunk
Title: [104589] trunk
Revision 104589
Author jer.no...@apple.com
Date 2012-01-10 09:38:34 -0800 (Tue, 10 Jan 2012)
Log Message
Elements can appear over fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=75913
Reviewed by Simon Fraser.
Source/WebCore:
No new tests; updated fullscreen/full-screen-zIndex.html to trigger error condition.
RenderFullScreenPlaceholder inherits the pre-fullscreen element's style, causing a stacking
context to be created. Instead of making the placeholder the parent of the RenderFullScreen
object, make the two renderers siblings. Then the stacking context created by the placeholder
will not affect the z-ordering of the RenderFullScreen.
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
(RenderFullScreen::createPlaceholder):
LayoutTests:
Update the test to trigger the error condition in the linked bug.
* fullscreen/full-screen-zIndex.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fullscreen/full-screen-zIndex.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFullScreen.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (104588 => 104589)
--- trunk/LayoutTests/ChangeLog 2012-01-10 17:34:33 UTC (rev 104588)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 17:38:34 UTC (rev 104589)
@@ -1,3 +1,14 @@
+2012-01-09 Jer Noble jer.no...@apple.com
+
+Elements can appear over fullscreen video
+https://bugs.webkit.org/show_bug.cgi?id=75913
+
+Reviewed by Simon Fraser.
+
+Update the test to trigger the error condition in the linked bug.
+
+* fullscreen/full-screen-zIndex.html:
+
2012-01-10 Julien Chaffraix jchaffr...@webkit.org
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
Modified: trunk/LayoutTests/fullscreen/full-screen-zIndex.html (104588 => 104589)
--- trunk/LayoutTests/fullscreen/full-screen-zIndex.html 2012-01-10 17:34:33 UTC (rev 104588)
+++ trunk/LayoutTests/fullscreen/full-screen-zIndex.html 2012-01-10 17:38:34 UTC (rev 104589)
@@ -26,6 +26,8 @@
height: 100px;
border: 4px solid darkgreen;
background-color: green;
+z-index: 100;
+position: relative;
}
#block2 {
width: 100px;
Modified: trunk/Source/WebCore/ChangeLog (104588 => 104589)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 17:34:33 UTC (rev 104588)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 17:38:34 UTC (rev 104589)
@@ -1,3 +1,22 @@
+2012-01-09 Jer Noble jer.no...@apple.com
+
+Elements can appear over fullscreen video
+https://bugs.webkit.org/show_bug.cgi?id=75913
+
+Reviewed by Simon Fraser.
+
+No new tests; updated fullscreen/full-screen-zIndex.html to trigger error condition.
+
+RenderFullScreenPlaceholder inherits the pre-fullscreen element's style, causing a stacking
+context to be created. Instead of making the placeholder the parent of the RenderFullScreen
+object, make the two renderers siblings. Then the stacking context created by the placeholder
+will not affect the z-ordering of the RenderFullScreen.
+
+* rendering/RenderFullScreen.cpp:
+(RenderFullScreen::wrapRenderer):
+(RenderFullScreen::unwrapRenderer):
+(RenderFullScreen::createPlaceholder):
+
2012-01-10 Pavel Feldman pfeld...@google.com
Web Inspector: add free flow DOM editing experiment.
Modified: trunk/Source/WebCore/rendering/RenderFullScreen.cpp (104588 => 104589)
--- trunk/Source/WebCore/rendering/RenderFullScreen.cpp 2012-01-10 17:34:33 UTC (rev 104588)
+++ trunk/Source/WebCore/rendering/RenderFullScreen.cpp 2012-01-10 17:38:34 UTC (rev 104589)
@@ -117,21 +117,20 @@
fullscreenRenderer-addChild(object);
}
document-setFullScreenRenderer(fullscreenRenderer);
-if (fullscreenRenderer-placeholder())
-return fullscreenRenderer-placeholder();
return fullscreenRenderer;
}
void RenderFullScreen::unwrapRenderer()
{
-RenderObject* holder = placeholder() ? placeholder() : this;
-if (holder-parent()) {
+if (parent()) {
RenderObject* child;
while ((child = firstChild())) {
child-remove();
-holder-parent()-addChild(child, holder);
+parent()-addChild(child, this);
}
}
+if (placeholder())
+placeholder()-remove();
remove();
document()-setFullScreenRenderer(0);
}
@@ -151,11 +150,8 @@
if (!m_placeholder) {
m_placeholder = new (document()-renderArena()) RenderFullScreenPlaceholder(this);
m_placeholder-setStyle(style);
-if (parent()) {
+if (parent())
parent()-addChild(m_placeholder, this);
-remove();
-}
-m_placeholder-addChild(this);
} else
m_placeholder-setStyle(style);
}
[webkit-changes] [104590] trunk/LayoutTests
Title: [104590] trunk/LayoutTests Revision 104590 Author ma...@webkit.org Date 2012-01-10 09:41:18 -0800 (Tue, 10 Jan 2012) Log Message [GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky https://bugs.webkit.org/show_bug.cgi?id=74493 Unreviewed. Unskipping passing test. * platform/gtk/test_expectations.txt: Unskip test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104589 => 104590) --- trunk/LayoutTests/ChangeLog 2012-01-10 17:38:34 UTC (rev 104589) +++ trunk/LayoutTests/ChangeLog 2012-01-10 17:41:18 UTC (rev 104590) @@ -1,3 +1,12 @@ +2012-01-10 Mario Sanchez Prada msanc...@igalia.com + +[GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=74493 + +Unreviewed. Unskipping passing test. + +* platform/gtk/test_expectations.txt: Unskip test. + 2012-01-09 Jer Noble jer.no...@apple.com Elements can appear over fullscreen video Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (104589 => 104590) --- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-01-10 17:38:34 UTC (rev 104589) +++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-01-10 17:41:18 UTC (rev 104590) @@ -86,8 +86,6 @@ BUGWK74297 DEBUG : http/tests/security/cross-origin-xsl-redirect-BLOCKED.html = PASS TEXT -BUGWK74493 : platform/gtk/accessibility/unknown-roles-not-exposed.html = PASS TEXT - BUGWK74710 : editing/pasteboard/paste-text-013.html = PASS TEXT // End of Flaky tests ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104591] trunk
Title: [104591] trunk Revision 104591 Author ma...@webkit.org Date 2012-01-10 09:44:21 -0800 (Tue, 10 Jan 2012) Log Message AX: support helpText() in DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=40193 Reviewed by Chris Fleizach. Source/WebKit/gtk: Add support for retrieving WebCore's AccessibilityObject's helpText from the GTK DumpRenderTree. * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::accessibilityHelpText): Returns result of calling to helpText() over the core accessibility object's. * WebCoreSupport/DumpRenderTreeSupportGtk.h: Tools: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::helpText): Implemented. LayoutTests: Unskip tests now passing. * accessibility/aria-describedby-on-input-expected.txt: Moved from LayoutTests/platform/mac/accessibility. * platform/gtk/Skipped: Unskip tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp Added Paths trunk/LayoutTests/accessibility/aria-describedby-on-input-expected.txt Removed Paths trunk/LayoutTests/platform/mac/accessibility/aria-describedby-on-input-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104590 => 104591) --- trunk/LayoutTests/ChangeLog 2012-01-10 17:41:18 UTC (rev 104590) +++ trunk/LayoutTests/ChangeLog 2012-01-10 17:44:21 UTC (rev 104591) @@ -1,5 +1,18 @@ 2012-01-10 Mario Sanchez Prada msanc...@igalia.com +AX: support helpText() in DumpRenderTree +https://bugs.webkit.org/show_bug.cgi?id=40193 + +Reviewed by Chris Fleizach. + +Unskip tests now passing. + +* accessibility/aria-describedby-on-input-expected.txt: Moved from +LayoutTests/platform/mac/accessibility. +* platform/gtk/Skipped: Unskip tests. + +2012-01-10 Mario Sanchez Prada msanc...@igalia.com + [GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky https://bugs.webkit.org/show_bug.cgi?id=74493 Copied: trunk/LayoutTests/accessibility/aria-describedby-on-input-expected.txt (from rev 104590, trunk/LayoutTests/platform/mac/accessibility/aria-describedby-on-input-expected.txt) (0 => 104591) --- trunk/LayoutTests/accessibility/aria-describedby-on-input-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/aria-describedby-on-input-expected.txt 2012-01-10 17:44:21 UTC (rev 104591) @@ -0,0 +1,4 @@ +This computer will self-destruct in minutes. +Allows you to specify the number of minutes after which the computer will self-destruct. + +The accessibility description is AXHelp: Allows you to specify the number of minutes after which the computer will self-destruct. Modified: trunk/LayoutTests/platform/gtk/Skipped (104590 => 104591) --- trunk/LayoutTests/platform/gtk/Skipped 2012-01-10 17:41:18 UTC (rev 104590) +++ trunk/LayoutTests/platform/gtk/Skipped 2012-01-10 17:44:21 UTC (rev 104591) @@ -388,7 +388,6 @@ # TESTS FAILING ### accessibility/aria-checkbox-sends-notification.html -accessibility/aria-help.html accessibility/aria-hidden.html accessibility/aria-hidden-with-elements.html accessibility/aria-labelledby-on-input.html @@ -1124,9 +1123,6 @@ platform/gtk/accessibility/object-attributes.html platform/gtk/accessibility/title-and-alt.html -# [GTK] https://bugs.webkit.org/show_bug.cgi?id=40193 -accessibility/aria-describedby-on-input.html - # fails on 32-bits debug bot # https://bugs.webkit.org/show_bug.cgi?id=50389 media/video-volume.html Deleted: trunk/LayoutTests/platform/mac/accessibility/aria-describedby-on-input-expected.txt (104590 => 104591) --- trunk/LayoutTests/platform/mac/accessibility/aria-describedby-on-input-expected.txt 2012-01-10 17:41:18 UTC (rev 104590) +++ trunk/LayoutTests/platform/mac/accessibility/aria-describedby-on-input-expected.txt 2012-01-10 17:44:21 UTC (rev 104591) @@ -1,4 +0,0 @@ -This computer will self-destruct in minutes. -Allows you to specify the number of minutes after which the computer will self-destruct. - -The accessibility description is AXHelp: Allows you to specify the number of minutes after which the computer will self-destruct. Modified: trunk/Source/WebKit/gtk/ChangeLog (104590 => 104591) --- trunk/Source/WebKit/gtk/ChangeLog 2012-01-10 17:41:18 UTC (rev 104590) +++ trunk/Source/WebKit/gtk/ChangeLog 2012-01-10 17:44:21 UTC (rev 104591) @@ -1,3 +1,18 @@ +2012-01-10 Mario Sanchez Prada msanc...@igalia.com + +AX: support helpText() in DumpRenderTree +https://bugs.webkit.org/show_bug.cgi?id=40193 + +Reviewed by Chris Fleizach. + +Add support for retrieving WebCore's AccessibilityObject's +
[webkit-changes] [104593] trunk/Source/WebCore
Title: [104593] trunk/Source/WebCore
Revision 104593
Author beid...@apple.com
Date 2012-01-10 09:57:42 -0800 (Tue, 10 Jan 2012)
Log Message
rdar://problem/9328684 and https://bugs.webkit.org/show_bug.cgi?id=62764
Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
Reviewed by Maciej Stachowiak.
This is a non-reproducible high volume crash, so no test :(.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::stopLoading): Don't re-run actual stop loading logic if the document loader is already
stopping loading. Also add an ASSERT that might catch cases where new loads may have been started while old loads
were being stopped.
(WebCore::DocumentLoader::detachFromFrame): Be conservative and stop loading when we detach a document loader from a frame.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104592 => 104593)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 17:49:05 UTC (rev 104592)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 17:57:42 UTC (rev 104593)
@@ -1,3 +1,18 @@
+2012-01-10 Brady Eidson beid...@apple.com
+
+rdar://problem/9328684 and https://bugs.webkit.org/show_bug.cgi?id=62764
+Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
+
+Reviewed by Maciej Stachowiak.
+
+This is a non-reproducible high volume crash, so no test :(.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::stopLoading): Don't re-run actual stop loading logic if the document loader is already
+ stopping loading. Also add an ASSERT that might catch cases where new loads may have been started while old loads
+ were being stopped.
+(WebCore::DocumentLoader::detachFromFrame): Be conservative and stop loading when we detach a document loader from a frame.
+
2012-01-10 Pavel Feldman pfeld...@google.com
Not reviewed: fixing the Mac build.
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (104592 => 104593)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2012-01-10 17:49:05 UTC (rev 104592)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2012-01-10 17:57:42 UTC (rev 104593)
@@ -233,8 +233,18 @@
// Appcache uses ResourceHandle directly, DocumentLoader doesn't count these loads.
m_applicationCacheHost-stopLoadingInFrame(m_frame);
-if (!loading)
+if (!loading) {
+// If something above restarted loading we might run into mysterious crashes like
+// https://bugs.webkit.org/show_bug.cgi?id=62764 and rdar://problem/9328684
+ASSERT(!m_loading);
return;
+}
+
+// We might run in to infinite recursion if we're stopping loading as the result of
+// detaching from the frame, so break out of that recursion here.
+// See rdar://problem/9673866 for more details.
+if (m_isStopping)
+return;
RefPtrFrame protectFrame(m_frame);
RefPtrDocumentLoader protectLoader(this);
@@ -396,6 +406,10 @@
{
ASSERT(m_frame);
+// It never makes sense to have a document loader that is detached from its
+// frame have any loads active, so go ahead and kill all the loads.
+stopLoading();
+
m_applicationCacheHost-setDOMApplicationCache(0);
InspectorInstrumentation::loaderDetachedFromFrame(m_frame, this);
m_frame = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104594] trunk/LayoutTests
Title: [104594] trunk/LayoutTests Revision 104594 Author ma...@webkit.org Date 2012-01-10 10:05:45 -0800 (Tue, 10 Jan 2012) Log Message AX: support helpText() in DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=40193 Unreviewed. Remove no longer needed GTK-specific expectation. * platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/gtk/accessibility/aria-describedby-on-input-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104593 => 104594) --- trunk/LayoutTests/ChangeLog 2012-01-10 17:57:42 UTC (rev 104593) +++ trunk/LayoutTests/ChangeLog 2012-01-10 18:05:45 UTC (rev 104594) @@ -3,6 +3,15 @@ AX: support helpText() in DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=40193 +Unreviewed. Remove no longer needed GTK-specific expectation. + +* platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Removed. + +2012-01-10 Mario Sanchez Prada msanc...@igalia.com + +AX: support helpText() in DumpRenderTree +https://bugs.webkit.org/show_bug.cgi?id=40193 + Reviewed by Chris Fleizach. Unskip tests now passing. Deleted: trunk/LayoutTests/platform/gtk/accessibility/aria-describedby-on-input-expected.txt (104593 => 104594) --- trunk/LayoutTests/platform/gtk/accessibility/aria-describedby-on-input-expected.txt 2012-01-10 17:57:42 UTC (rev 104593) +++ trunk/LayoutTests/platform/gtk/accessibility/aria-describedby-on-input-expected.txt 2012-01-10 18:05:45 UTC (rev 104594) @@ -1,4 +0,0 @@ -This computer will self-destruct in minutes. -Allows you to specify the number of minutes after which the computer will self-destruct. - -The accessibility description is AXDescription: Allows you to specify the number of minutes after which the computer will self-destruct. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104595] trunk/Source/WebCore
Title: [104595] trunk/Source/WebCore Revision 104595 Author pfeld...@chromium.org Date 2012-01-10 10:23:13 -0800 (Tue, 10 Jan 2012) Log Message Not reviewed, follow up to r104586: fix assertion within the loop. * inspector/DOMEditor.cpp: (WebCore::DOMEditor::patchChildren): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/DOMEditor.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (104594 => 104595) --- trunk/Source/WebCore/ChangeLog 2012-01-10 18:05:45 UTC (rev 104594) +++ trunk/Source/WebCore/ChangeLog 2012-01-10 18:23:13 UTC (rev 104595) @@ -1,3 +1,10 @@ +2012-01-10 Pavel Feldman pfeld...@google.com + +Not reviewed, follow up to r104586: fix assertion within the loop. + +* inspector/DOMEditor.cpp: +(WebCore::DOMEditor::patchChildren): + 2012-01-10 Brady Eidson beid...@apple.com rdar://problem/9328684 and https://bugs.webkit.org/show_bug.cgi?id=62764 Modified: trunk/Source/WebCore/inspector/DOMEditor.cpp (104594 => 104595) --- trunk/Source/WebCore/inspector/DOMEditor.cpp 2012-01-10 18:05:45 UTC (rev 104594) +++ trunk/Source/WebCore/inspector/DOMEditor.cpp 2012-01-10 18:23:13 UTC (rev 104595) @@ -232,7 +232,8 @@ ExceptionCode ec = 0; oldParent-insertBefore(newList[i]-m_node, oldParent-childNode(i + offset), ec); -return !ec; +if (ec) +return false; } return true; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104596] trunk/Source/WebCore
Title: [104596] trunk/Source/WebCore
Revision 104596
Author commit-qu...@webkit.org
Date 2012-01-10 10:44:41 -0800 (Tue, 10 Jan 2012)
Log Message
Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
https://bugs.webkit.org/show_bug.cgi?id=75759
Follow-up: Remove the unused method. Keep the setter private.
Patch by Joseph Pecoraro pecor...@apple.com on 2012-01-10
Reviewed by Pavel Feldman.
* inspector/InspectorDOMAgent.cpp:
* inspector/InspectorDOMAgent.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/InspectorDOMAgent.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104595 => 104596)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 18:23:13 UTC (rev 104595)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 18:44:41 UTC (rev 104596)
@@ -1,3 +1,15 @@
+2012-01-10 Joseph Pecoraro pecor...@apple.com
+
+Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
+https://bugs.webkit.org/show_bug.cgi?id=75759
+
+Follow-up: Remove the unused method. Keep the setter private.
+
+Reviewed by Pavel Feldman.
+
+* inspector/InspectorDOMAgent.cpp:
+* inspector/InspectorDOMAgent.h:
+
2012-01-10 Pavel Feldman pfeld...@google.com
Not reviewed, follow up to r104586: fix assertion within the loop.
Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (104595 => 104596)
--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2012-01-10 18:23:13 UTC (rev 104595)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2012-01-10 18:44:41 UTC (rev 104596)
@@ -953,11 +953,6 @@
}
}
-bool InspectorDOMAgent::searchingForNodeInPage() const
-{
-return m_searchingForNode;
-}
-
void InspectorDOMAgent::setSearchingForNode(bool enabled, InspectorObject* highlightConfig)
{
if (m_searchingForNode == enabled)
Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.h (104595 => 104596)
--- trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2012-01-10 18:23:13 UTC (rev 104595)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2012-01-10 18:44:41 UTC (rev 104596)
@@ -170,8 +170,6 @@
PassRefPtrInspectorObject resolveNode(Node*, const String objectGroup);
bool handleMousePress();
void mouseDidMoveOverElement(const HitTestResult, unsigned modifierFlags);
-bool searchingForNodeInPage() const;
-void setSearchingForNode(bool enabled, InspectorObject* highlightConfig);
void inspect(Node*);
void focusNode();
@@ -192,6 +190,7 @@
private:
InspectorDOMAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorClient*, InspectorState*, InjectedScriptManager*);
+void setSearchingForNode(bool enabled, InspectorObject* highlightConfig);
bool setHighlightDataFromConfig(InspectorObject* highlightConfig);
void highlight();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104598] trunk/LayoutTests
Title: [104598] trunk/LayoutTests Revision 104598 Author vse...@chromium.org Date 2012-01-10 10:49:36 -0800 (Tue, 10 Jan 2012) Log Message http/tests/inspector/network-preflight-options.html is flaky on linux https://bugs.webkit.org/show_bug.cgi?id=75917 Reviewed by Yury Semikhatsky. * http/tests/inspector/network-preflight-options-expected.txt: * http/tests/inspector/network-preflight-options.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/network-preflight-options-expected.txt trunk/LayoutTests/http/tests/inspector/network-preflight-options.html Diff Modified: trunk/LayoutTests/ChangeLog (104597 => 104598) --- trunk/LayoutTests/ChangeLog 2012-01-10 18:46:30 UTC (rev 104597) +++ trunk/LayoutTests/ChangeLog 2012-01-10 18:49:36 UTC (rev 104598) @@ -1,3 +1,13 @@ +2012-01-10 Vsevolod Vlasov vse...@chromium.org + +http/tests/inspector/network-preflight-options.html is flaky on linux +https://bugs.webkit.org/show_bug.cgi?id=75917 + +Reviewed by Yury Semikhatsky. + +* http/tests/inspector/network-preflight-options-expected.txt: +* http/tests/inspector/network-preflight-options.html: + 2012-01-10 Mario Sanchez Prada msanc...@igalia.com AX: support helpText() in DumpRenderTree Modified: trunk/LayoutTests/http/tests/inspector/network-preflight-options-expected.txt (104597 => 104598) --- trunk/LayoutTests/http/tests/inspector/network-preflight-options-expected.txt 2012-01-10 18:46:30 UTC (rev 104597) +++ trunk/LayoutTests/http/tests/inspector/network-preflight-options-expected.txt 2012-01-10 18:49:36 UTC (rev 104598) @@ -1,16 +1,16 @@ -CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. +CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?id=0deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. +CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?id=1deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. +CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?id=3deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. +CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/inspector/resources/cors-target.php?id=4deny=yes. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. Tests that preflight OPTIONS requests appear in Network resources Bug 63712 -POST http://localhost:8000/inspector/resources/cors-target.php?deny=yes -OPTIONS http://localhost:8000/inspector/resources/cors-target.php?deny=yes -OPTIONS http://localhost:8000/inspector/resources/cors-target.php -POST http://localhost:8000/inspector/resources/cors-target.php -POST http://localhost:8000/inspector/resources/cors-target.php?deny=yes -OPTIONS http://localhost:8000/inspector/resources/cors-target.php?deny=yes -OPTIONS http://localhost:8000/inspector/resources/cors-target.php?async=yes -POST http://localhost:8000/inspector/resources/cors-target.php?async=yes +0:POST http://localhost:8000/inspector/resources/cors-target.php?id=0deny=yes +1:OPTIONS http://localhost:8000/inspector/resources/cors-target.php?id=1deny=yes +2:OPTIONS http://localhost:8000/inspector/resources/cors-target.php?id=2 +2:POST http://localhost:8000/inspector/resources/cors-target.php?id=2 +3:POST http://localhost:8000/inspector/resources/cors-target.php?id=3deny=yes +4:OPTIONS http://localhost:8000/inspector/resources/cors-target.php?id=4deny=yes +5:OPTIONS http://localhost:8000/inspector/resources/cors-target.php?id=5 +5:POST http://localhost:8000/inspector/resources/cors-target.php?id=5 Modified: trunk/LayoutTests/http/tests/inspector/network-preflight-options.html (104597 => 104598) --- trunk/LayoutTests/http/tests/inspector/network-preflight-options.html 2012-01-10 18:46:30 UTC (rev 104597) +++ trunk/LayoutTests/http/tests/inspector/network-preflight-options.html 2012-01-10 18:49:36 UTC (rev 104598) @@ -22,41 +22,60 @@ } } -var targetURL = http://localhost:8000/inspector/resources/cors-target.php; +var baseTargetURL =
[webkit-changes] [104599] tags/Safari-534.54.4/
Title: [104599] tags/Safari-534.54.4/ Revision 104599 Author lforsch...@apple.com Date 2012-01-10 10:53:21 -0800 (Tue, 10 Jan 2012) Log Message New tag. Added Paths tags/Safari-534.54.4/ Diff Property changes: tags/Safari-534.54.4 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104600] trunk/Source
Title: [104600] trunk/Source Revision 104600 Author e...@google.com Date 2012-01-10 10:59:16 -0800 (Tue, 10 Jan 2012) Log Message [chromium] Draw debug tile borders on composited layers https://bugs.webkit.org/show_bug.cgi?id=75680 Reviewed by James Robinson. Source/WebCore: On tiled layers, draw debug borders on the tiles themselves. By default, these are one pixel wide and transparent, so should be unobtrusive but informative. They are triggered when the layer itself would have a debug border via the existing flags. Also, fix the drawDebugBorderQuad function to handle arbitrarily positioned quads, not just full layer quads. Also, fix alpha issue with debug borders. * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawDebugBorderQuad): * platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp: (WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad): * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::appendDebugBorderQuad): (WebCore::CCLayerImpl::quadTransform): (WebCore::CCLayerImpl::hasDebugBorders): * platform/graphics/chromium/cc/CCLayerImpl.h: * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: (WebCore::CCTiledLayerImpl::appendQuads): Source/WebKit/chromium: As debug borders are not a CCSetting and are instead grabbed directly from each graphics layer, modify the NonCompositedContentHost to say that its graphics layer has debug borders if the page settings demand it. * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): (WebKit::NonCompositedContentHost::setShowDebugBorders): (WebKit::NonCompositedContentHost::showDebugBorders): * src/NonCompositedContentHost.h: * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp trunk/Source/WebKit/chromium/src/NonCompositedContentHost.h trunk/Source/WebKit/chromium/src/WebViewImpl.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (104599 => 104600) --- trunk/Source/WebCore/ChangeLog 2012-01-10 18:53:21 UTC (rev 104599) +++ trunk/Source/WebCore/ChangeLog 2012-01-10 18:59:16 UTC (rev 104600) @@ -1,3 +1,31 @@ +2012-01-10 Adrienne Walker e...@google.com + +[chromium] Draw debug tile borders on composited layers +https://bugs.webkit.org/show_bug.cgi?id=75680 + +Reviewed by James Robinson. + +On tiled layers, draw debug borders on the tiles themselves. By +default, these are one pixel wide and transparent, so should be +unobtrusive but informative. They are triggered when the layer itself +would have a debug border via the existing flags. + +Also, fix the drawDebugBorderQuad function to handle arbitrarily +positioned quads, not just full layer quads. Also, fix alpha issue +with debug borders. + +* platform/graphics/chromium/LayerRendererChromium.cpp: +(WebCore::LayerRendererChromium::drawDebugBorderQuad): +* platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp: +(WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad): +* platform/graphics/chromium/cc/CCLayerImpl.cpp: +(WebCore::CCLayerImpl::appendDebugBorderQuad): +(WebCore::CCLayerImpl::quadTransform): +(WebCore::CCLayerImpl::hasDebugBorders): +* platform/graphics/chromium/cc/CCLayerImpl.h: +* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: +(WebCore::CCTiledLayerImpl::appendQuads): + 2012-01-10 Joseph Pecoraro pecor...@apple.com Web Inspector: Missing Implementation of Public InspectorDOMAgent Function Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (104599 => 104600) --- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2012-01-10 18:53:21 UTC (rev 104599) +++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2012-01-10 18:59:16 UTC (rev 104600) @@ -435,13 +435,14 @@ ASSERT(program program-initialized()); GLC(context(), context()-useProgram(program-program())); -TransformationMatrix renderMatrix = quad-layerTransform(); const IntRect layerRect = quad-quadRect(); +TransformationMatrix renderMatrix = quad-quadTransform(); +renderMatrix.translate(0.5 * layerRect.width() + layerRect.x(), 0.5 * layerRect.height() + layerRect.y()); renderMatrix.scaleNonUniform(layerRect.width(), layerRect.height()); LayerRendererChromium::toGLMatrix(glMatrix[0],
[webkit-changes] [104601] trunk/LayoutTests
Title: [104601] trunk/LayoutTests Revision 104601 Author t...@chromium.org Date 2012-01-10 11:21:14 -0800 (Tue, 10 Jan 2012) Log Message [chromium] Fix expectations for worker-script-error.html on Mac/Linux https://bugs.webkit.org/show_bug.cgi?id=75758 Reviewed by David Levin. The Win results appear to apply to Mac and Linux as well. * platform/chromium-win/fast/workers/worker-script-error-expected.txt: Removed. * platform/chromium/fast/workers/worker-script-error-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/fast/workers/worker-script-error-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-win/fast/workers/worker-script-error-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104600 => 104601) --- trunk/LayoutTests/ChangeLog 2012-01-10 18:59:16 UTC (rev 104600) +++ trunk/LayoutTests/ChangeLog 2012-01-10 19:21:14 UTC (rev 104601) @@ -1,3 +1,15 @@ +2012-01-10 Tony Chang t...@chromium.org + +[chromium] Fix expectations for worker-script-error.html on Mac/Linux +https://bugs.webkit.org/show_bug.cgi?id=75758 + +Reviewed by David Levin. + +The Win results appear to apply to Mac and Linux as well. + +* platform/chromium-win/fast/workers/worker-script-error-expected.txt: Removed. +* platform/chromium/fast/workers/worker-script-error-expected.txt: + 2012-01-10 Vsevolod Vlasov vse...@chromium.org http/tests/inspector/network-preflight-options.html is flaky on linux Modified: trunk/LayoutTests/platform/chromium/fast/workers/worker-script-error-expected.txt (104600 => 104601) --- trunk/LayoutTests/platform/chromium/fast/workers/worker-script-error-expected.txt 2012-01-10 18:59:16 UTC (rev 104600) +++ trunk/LayoutTests/platform/chromium/fast/workers/worker-script-error-expected.txt 2012-01-10 19:21:14 UTC (rev 104601) @@ -1,4 +1,3 @@ -CONSOLE MESSAGE: line 10: Uncaught ReferenceError: foo is not defined Test Worker script error handling functionality. Should print a series of PASS messages, followed with DONE. PASS: onerror invoked for a script that has invalid syntax. Deleted: trunk/LayoutTests/platform/chromium-win/fast/workers/worker-script-error-expected.txt (104600 => 104601) --- trunk/LayoutTests/platform/chromium-win/fast/workers/worker-script-error-expected.txt 2012-01-10 18:59:16 UTC (rev 104600) +++ trunk/LayoutTests/platform/chromium-win/fast/workers/worker-script-error-expected.txt 2012-01-10 19:21:14 UTC (rev 104601) @@ -1,14 +0,0 @@ -Test Worker script error handling functionality. Should print a series of PASS messages, followed with DONE. - -PASS: onerror invoked for a script that has invalid syntax. -PASS: onerror invoked for a script that has script error 'Uncaught ReferenceError: foo is not defined' at line 1. -PASS: event listener invoked for a script that has script error 'Uncaught ReferenceError: foo is not defined' at line 1. -PASS: onerror invoked for a script that has script error 'Uncaught ReferenceError: foo is not defined' at line 7. -PASS: onerror invoked for a script that has script error 'Uncaught ReferenceError: bar is not defined' at line 3. -message from worker: PASS: onerror in worker context invoked for a script that has script error 'Uncaught ReferenceError: foo is not defined' at line 10 in worker-script-error-bubbled.js. -PASS: onerror invoked for a script that has script error 'Uncaught ReferenceError: foo is not defined' at line 10. -PASS: onerror invoked for a script that has script error 'Uncaught ReferenceError: foo is not defined' at line 10. -PASS: message received from WorkerGlobalScope.onerror: onerror invoked for a script that has script error 'Uncaught ReferenceError: foo is not defined' at line 7. -PASS: onerror invoked for an exception in setTimeout callback. -DONE - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104602] trunk
Title: [104602] trunk
Revision 104602
Author barraclo...@apple.com
Date 2012-01-10 11:22:54 -0800 (Tue, 10 Jan 2012)
Log Message
Use SameValue to compare property descriptor values
https://bugs.webkit.org/show_bug.cgi?id=75975
Reviewed by Sam Weinig.
Source/_javascript_Core:
Rather than strictEqual.
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnNumericProperty):
- Missing configurablePresent() check.
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
- call sameValue.
* runtime/PropertyDescriptor.cpp:
(JSC::sameValue):
- Moved from JSArray.cpp, fix NaN comparison.
(JSC::PropertyDescriptor::equalTo):
- call sameValue.
* runtime/PropertyDescriptor.h:
- Added declaration for sameValue.
LayoutTests:
* fast/js/array-defineOwnProperty-expected.txt:
* fast/js/script-tests/array-defineOwnProperty.js:
- Add new test cases.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt
trunk/LayoutTests/fast/js/script-tests/array-defineOwnProperty.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/PropertyDescriptor.cpp
trunk/Source/_javascript_Core/runtime/PropertyDescriptor.h
Diff
Modified: trunk/LayoutTests/ChangeLog (104601 => 104602)
--- trunk/LayoutTests/ChangeLog 2012-01-10 19:21:14 UTC (rev 104601)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 19:22:54 UTC (rev 104602)
@@ -1,3 +1,14 @@
+2012-01-10 Gavin Barraclough barraclo...@apple.com
+
+Use SameValue to compare property descriptor values
+https://bugs.webkit.org/show_bug.cgi?id=75975
+
+Reviewed by Sam Weinig.
+
+* fast/js/array-defineOwnProperty-expected.txt:
+* fast/js/script-tests/array-defineOwnProperty.js:
+- Add new test cases.
+
2012-01-10 Tony Chang t...@chromium.org
[chromium] Fix expectations for worker-script-error.html on Mac/Linux
Modified: trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt (104601 => 104602)
--- trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt 2012-01-10 19:21:14 UTC (rev 104601)
+++ trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt 2012-01-10 19:22:54 UTC (rev 104602)
@@ -17,7 +17,23 @@
PASS var foo = 0; Object.defineProperty([], '0', { set:function(x){foo = x;} })[0] = 42; foo is 42
PASS Object.defineProperty([], '0', { get:function(){return true;} })[0] is true
PASS Object.defineProperty(Object.defineProperty([true], '0', { configurable:true, writable: false }), '0', { writable: true })[0] is true
-PASS Object.defineProperty(Object.defineProperty([true], '0', { configurable:false, writable: false }), '0', { writable: true })[0] threw exception TypeError: Attempting to change configurable attribute of unconfigurable property..
+PASS Object.defineProperty(Object.defineProperty([true], '0', { configurable:false, writable: false }), '0', { writable: true })[0] threw exception TypeError: Attempting to change writable attribute of unconfigurable property..
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: 1, writable:true }), '0', { value: 2 })[0] is 2
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: 1 }), '0', { value: 1 })[0] is 1
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: Number.NaN }), '0', { value: -Number.NaN })[0] is Number.NaN
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: 'okay'.substring(0,2) }), '0', { value: 'not ok'.substring(4,6) })[0] is ok
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: true }), '0', { value: true })[0] is true
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: false }), '0', { value: false })[0] is false
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: null }), '0', { value: null })[0] is null
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: undefined }), '0', { value: undefined })[0] is undefined
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: Math }), '0', { value: Math })[0] is Math
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: 1 }), '0', { value: 2 })[0] threw exception TypeError: Attempting to change value of a readonly property..
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: 'okay' }), '0', { value: 'not ok' })[0] threw exception TypeError: Attempting to change value of a readonly property..
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: true }), '0', { value: false })[0] threw exception TypeError: Attempting to change value of a readonly property..
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: false }), '0', { value: true })[0] threw exception TypeError: Attempting to change value of a readonly property..
+PASS Object.defineProperty(Object.defineProperty([], '0', { value: Math }), '0', {
[webkit-changes] [104604] trunk
Title: [104604] trunk
Revision 104604
Author barraclo...@apple.com
Date 2012-01-10 11:27:46 -0800 (Tue, 10 Jan 2012)
Log Message
Source/_javascript_Core: Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935
Reviewed by Sam Weinig.
Do not allow Array length to be set if it is non-configurable, and if the new
length is less than the old length then intervening properties should removed
in reverse order. Removal of properties should cease if an intervening indexed
property being removed is non-configurable.
* _javascript_Core.exp:
- Removed export for setLength.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
- JSArray::setLength now takes an ExecState*
(JSC::arrayProtoFuncSlice):
- JSArray::setLength now takes an ExecState*
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
- JSArray::setLength now takes an ExecState*
(JSC::JSArray::put):
- JSArray::setLength now takes an ExecState*
(JSC::compareKeysForQSort):
- Keys extracted from the map can be stored as unsigneds.
(JSC::JSArray::getOwnPropertyNames):
- Keys extracted from the map can be stored as unsigneds.
(JSC::JSArray::setLength):
- Check lengthIsReadOnly(), rather than copying the entire map to iterate
over to determine which keys to remove, instead just copy the keys from
the map to a Vector. When inSparseMode sort the keys in the Vector so
that we can remove properties in reverse order.
* runtime/JSArray.h:
- JSArray::setLength now takes an ExecState*
Source/WebCore: Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935
Reviewed by Sam Weinig.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::deserialize):
- remove unnecessary call to JSArray::setLength.
LayoutTests: rebaselining some canvas images
https://bugs.webkit.org/show_bug.cgi?id=75552
Patch by Elliot Poger epo...@google.com on 2012-01-10
Reviewed by Ryosuke Niwa.
* platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-mac-leopard/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-lineWidth-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt
trunk/LayoutTests/fast/js/mozilla/strict/15.4.5.1-expected.txt
trunk/LayoutTests/fast/js/script-tests/array-defineOwnProperty.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/_javascript_Core/runtime/JSArray.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (104603 => 104604)
--- trunk/LayoutTests/ChangeLog 2012-01-10 19:27:02 UTC (rev 104603)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 19:27:46 UTC (rev 104604)
@@ -19,6 +19,18 @@
2012-01-10 Gavin Barraclough barraclo...@apple.com
+Do not allow Array length to be set if it is non-configurable
+https://bugs.webkit.org/show_bug.cgi?id=75935
+
+Reviewed by Sam Weinig.
+
+* fast/js/array-defineOwnProperty-expected.txt:
+* fast/js/mozilla/strict/15.4.5.1-expected.txt:
+* fast/js/script-tests/array-defineOwnProperty.js:
+- Added one more test some missing comments, updated results.
+
+2012-01-10 Gavin Barraclough barraclo...@apple.com
+
Use SameValue to compare property descriptor values
https://bugs.webkit.org/show_bug.cgi?id=75975
Modified: trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt (104603 => 104604)
--- trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt 2012-01-10 19:27:02 UTC (rev 104603)
+++ trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt 2012-01-10 19:27:46 UTC (rev 104604)
@@ -6,6 +6,7 @@
PASS Object.defineProperty([], 'x', { get:function(){return true;} }).x is true
PASS Object.defineProperty([], 'length', { value: 1 }).length is 1
PASS var a = Object.defineProperty([], 'length', { writable: false }); a[1] = 1; a.length is 0
+PASS var a = Object.defineProperty([], 'length', { writable: false }); a.length = 1; a.length is 0
PASS
[webkit-changes] [104605] trunk/Source/WebKit
Title: [104605] trunk/Source/WebKit Revision 104605 Author commit-qu...@webkit.org Date 2012-01-10 11:38:09 -0800 (Tue, 10 Jan 2012) Log Message [BlackBerry] Fix assertion failure in BackingStore::blitContents https://bugs.webkit.org/show_bug.cgi?id=75976 Prevent an assertion failure in BackingStore::blitContents by checking that the srcRect of the transformation matrix is non empty. Patch by Mike Lattanzio mlattan...@rim.com on 2012-01-10 Reviewed by Adam Treat. Upstream BlackBerry port is not yet building and testable. * blackberry/Api/BackingStore.cpp: (BlackBerry::WebKit::BackingStorePrivate::blitContents): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/blackberry/Api/BackingStore.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (104604 => 104605) --- trunk/Source/WebKit/ChangeLog 2012-01-10 19:27:46 UTC (rev 104604) +++ trunk/Source/WebKit/ChangeLog 2012-01-10 19:38:09 UTC (rev 104605) @@ -1,3 +1,18 @@ +2012-01-10 Mike Lattanzio mlattan...@rim.com + +[BlackBerry] Fix assertion failure in BackingStore::blitContents +https://bugs.webkit.org/show_bug.cgi?id=75976 + +Prevent an assertion failure in BackingStore::blitContents by +checking that the srcRect of the transformation matrix is non empty. + +Reviewed by Adam Treat. + +Upstream BlackBerry port is not yet building and testable. + +* blackberry/Api/BackingStore.cpp: +(BlackBerry::WebKit::BackingStorePrivate::blitContents): + 2012-01-06 Benjamin Poulain bpoul...@apple.com [Mac] Sort the resources of WebKit.xcodeproj Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (104604 => 104605) --- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-01-10 19:27:46 UTC (rev 104604) +++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-01-10 19:38:09 UTC (rev 104605) @@ -1241,8 +1241,9 @@ #endif // FIXME: This should not explicitely depend on WebCore::. -TransformationMatrix transformation = TransformationMatrix::rectToRect( -FloatRect(FloatPoint(0.0, 0.0), WebCore::IntSize(contents.size())), WebCore::IntRect(dstRect)); +TransformationMatrix transformation; +if (!contents.isEmpty()) +transformation = TransformationMatrix::rectToRect(FloatRect(FloatPoint(0.0, 0.0), WebCore::IntSize(contents.size())), WebCore::IntRect(dstRect)); bool blittingDirectlyToCompositingWindow = m_webPage-d-m_client-window()-windowUsage() == BlackBerry::Platform::Graphics::Window::GLES2Usage; #if USE(ACCELERATED_COMPOSITING) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104606] trunk/LayoutTests
Title: [104606] trunk/LayoutTests
Revision 104606
Author simon.fra...@apple.com
Date 2012-01-10 11:43:08 -0800 (Tue, 10 Jan 2012)
Log Message
Improve keyboard navigation in layout test results
https://bugs.webkit.org/show_bug.cgi?id=75901
Reviewed by Ojan Vafai.
Add support for keyboard shortcuts for navigating the list of tests,
and for flagging tests.
'i', 'k', 'k', and 'l' go foward, back, to first and to last, denoting
the current test with a red expand indicator.
'e', 'c' and 't' expand, collapse and toggle the current test.
'f' toggled a test as flagged, which adds it to a copyable list
at the bottom of the document. The user can use flagging for whatever they want.
* fast/harness/resources/results-test.js:
(runTests):
(runTests.isCollapsed):
():
* fast/harness/results-expected.txt:
* fast/harness/results.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/harness/resources/results-test.js
trunk/LayoutTests/fast/harness/results-expected.txt
trunk/LayoutTests/fast/harness/results.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104605 => 104606)
--- trunk/LayoutTests/ChangeLog 2012-01-10 19:38:09 UTC (rev 104605)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 19:43:08 UTC (rev 104606)
@@ -1,3 +1,28 @@
+2012-01-10 Simon Fraser simon.fra...@apple.com
+
+Improve keyboard navigation in layout test results
+https://bugs.webkit.org/show_bug.cgi?id=75901
+
+Reviewed by Ojan Vafai.
+
+Add support for keyboard shortcuts for navigating the list of tests,
+and for flagging tests.
+
+'i', 'k', 'k', and 'l' go foward, back, to first and to last, denoting
+the current test with a red expand indicator.
+
+'e', 'c' and 't' expand, collapse and toggle the current test.
+
+'f' toggled a test as flagged, which adds it to a copyable list
+at the bottom of the document. The user can use flagging for whatever they want.
+
+* fast/harness/resources/results-test.js:
+(runTests):
+(runTests.isCollapsed):
+():
+* fast/harness/results-expected.txt:
+* fast/harness/results.html:
+
2012-01-10 Elliot Poger epo...@google.com
rebaselining some canvas images
Modified: trunk/LayoutTests/fast/harness/resources/results-test.js (104605 => 104606)
--- trunk/LayoutTests/fast/harness/resources/results-test.js 2012-01-10 19:38:09 UTC (rev 104605)
+++ trunk/LayoutTests/fast/harness/resources/results-test.js 2012-01-10 19:43:08 UTC (rev 104606)
@@ -181,6 +181,17 @@
assertTrue(document.getElementById('timeout-tests-table').textContent.indexOf('expected actual diff') != -1);
});
+function isExpanded(expandLink)
+{
+var enDash = '\u2013';
+return expandLink.textContent == enDash;
+}
+
+function isCollapsed(expandLink)
+{
+return expandLink.textContent == '+';
+}
+
results = mockResults();
var subtree = results.tests['foo'] = {}
subtree['bar.html'] = mockExpectation('TEXT', 'PASS');
@@ -194,21 +205,19 @@
expandAllExpectations();
assertTrue(document.querySelectorAll('tbody tr').length == 8);
var expandLinks = document.querySelectorAll('.expand-button-text');
-var enDash = '\u2013';
-for (var i = 0; i expandLinks.length; i++) {
-assertTrue(expandLinks[i].textContent == enDash);
-}
+for (var i = 0; i expandLinks.length; i++)
+assertTrue(isExpanded(expandLinks[i]));
collapseAllExpectations();
// Collapsed expectations stay in the dom, but are display:none.
assertTrue(document.querySelectorAll('tbody tr').length == 8);
var expandLinks = document.querySelectorAll('.expand-button-text');
for (var i = 0; i expandLinks.length; i++)
-assertTrue(expandLinks[i].textContent == '+');
+assertTrue(isCollapsed(expandLinks[i]));
expandExpectations(expandLinks[1]);
-assertTrue(expandLinks[0].textContent == '+');
-assertTrue(expandLinks[1].textContent == enDash);
+assertTrue(isCollapsed(expandLinks[0]));
+assertTrue(isExpanded(expandLinks[1]));
collapseExpectations(expandLinks[1]);
assertTrue(expandLinks[1].textContent == '+');
@@ -548,7 +557,60 @@
expandAllExpectations();
assertTrue(visibleExpandLinks().length == 2);
});
+
+results = mockResults();
+var subtree = results.tests['foo'] = {}
+subtree['bar.html'] = mockExpectation('TEXT', 'FAIL');
+subtree['bar1.html'] = mockExpectation('TEXT', 'FAIL');
+subtree['bar2.html'] = mockExpectation('TEXT', 'FAIL');
+
+runTest(results, function() {
+assertTrue(document.getElementById('results-table'));
+assertTrue(visibleExpandLinks().length == 3);
+
+if (window.eventSender) {
+
[webkit-changes] [104608] trunk/LayoutTests
Title: [104608] trunk/LayoutTests Revision 104608 Author senorbla...@chromium.org Date 2012-01-10 11:47:28 -0800 (Tue, 10 Jan 2012) Log Message [chromium] Unreviewed gardening. New baselines for SVG feColorMatrix tests after r104571. * platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added. * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added. * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added. * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added. * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added. * platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added. * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added. * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added. * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-offset-expected.png: * platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-saturate-expected.png: Added. * platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed. * platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed. * platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed. * platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed. * platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png: Removed. * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: * platform/chromium-win/svg/filters/feColorMatrix-offset-expected.png: * platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png: * platform/chromium/test_expectations.txt: * platform/mac/svg/filters/feColorMatrix-saturate-expected.txt: Added. * svg/filters/feColorMatrix-saturate-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-offset-expected.png trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png trunk/LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png trunk/LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png trunk/LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png trunk/LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feColorMatrix-offset-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png
[webkit-changes] [104609] trunk/Source/WebCore
Title: [104609] trunk/Source/WebCore Revision 104609 Author r...@google.com Date 2012-01-10 11:50:40 -0800 (Tue, 10 Jan 2012) Log Message [skia] not all convex paths are convex, so recompute convexity for the problematic ones https://bugs.webkit.org/show_bug.cgi?id=75960 Reviewed by Stephen White. No new tests. See related chrome issue http://code.google.com/p/chromium/issues/detail?id=108605 * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::setPathFromConvexPoints): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (104608 => 104609) --- trunk/Source/WebCore/ChangeLog 2012-01-10 19:47:28 UTC (rev 104608) +++ trunk/Source/WebCore/ChangeLog 2012-01-10 19:50:40 UTC (rev 104609) @@ -1,3 +1,17 @@ +2012-01-10 Mike Reed r...@google.com + +[skia] not all convex paths are convex, so recompute convexity for the problematic ones +https://bugs.webkit.org/show_bug.cgi?id=75960 + +Reviewed by Stephen White. + +No new tests. +See related chrome issue +http://code.google.com/p/chromium/issues/detail?id=108605 + +* platform/graphics/skia/GraphicsContextSkia.cpp: +(WebCore::setPathFromConvexPoints): + 2012-01-10 Gavin Barraclough barraclo...@apple.com Do not allow Array length to be set if it is non-configurable Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (104608 => 104609) --- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2012-01-10 19:47:28 UTC (rev 104608) +++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2012-01-10 19:50:40 UTC (rev 104609) @@ -440,7 +440,17 @@ path-lineTo(WebCoreFloatToSkScalar(points[i].x()), WebCoreFloatToSkScalar(points[i].y())); } -path-setIsConvex(true); + +/* The code used to just blindly call this +path-setIsConvex(true); +But webkit can sometimes send us non-convex 4-point values, so we mark the path's +convexity as unknown, so it will get computed by skia at draw time. +See crbug.com 108605 +*/ +SkPath::Convexity convexity = SkPath::kConvex_Convexity; +if (numPoints == 4) +convexity = SkPath::kUnknown_Convexity; +path-setConvexity(convexity); } void GraphicsContext::drawConvexPolygon(size_t numPoints, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104611] trunk/Source/JavaScriptCore
Title: [104611] trunk/Source/_javascript_Core Revision 104611 Author barraclo...@apple.com Date 2012-01-10 11:56:18 -0800 (Tue, 10 Jan 2012) Log Message Windows build fix. * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def Diff Modified: trunk/Source/_javascript_Core/ChangeLog (104610 => 104611) --- trunk/Source/_javascript_Core/ChangeLog 2012-01-10 19:52:39 UTC (rev 104610) +++ trunk/Source/_javascript_Core/ChangeLog 2012-01-10 19:56:18 UTC (rev 104611) @@ -1,5 +1,11 @@ 2012-01-10 Gavin Barraclough barraclo...@apple.com +Windows build fix. + +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: + +2012-01-10 Gavin Barraclough barraclo...@apple.com + Do not allow Array length to be set if it is non-configurable https://bugs.webkit.org/show_bug.cgi?id=75935 Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (104610 => 104611) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2012-01-10 19:52:39 UTC (rev 104610) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2012-01-10 19:56:18 UTC (rev 104611) @@ -302,7 +302,6 @@ ?setDumpsGeneratedCode@BytecodeGenerator@JSC@@SAX_N@Z ?setEnumerable@PropertyDescriptor@JSC@@QAEX_N@Z ?setGetter@PropertyDescriptor@JSC@@QAEXVJSValue@2@@Z -?setLength@JSArray@JSC@@QAEXI@Z ?setLoc@StatementNode@JSC@@QAEXHH@Z ?setMainThreadCallbacksPaused@WTF@@YAX_N@Z ?setOrderLowerFirst@Collator@WTF@@QAEX_N@Z ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104612] branches/safari-534.54-branch/Source
Title: [104612] branches/safari-534.54-branch/Source Revision 104612 Author lforsch...@apple.com Date 2012-01-10 11:57:31 -0800 (Tue, 10 Jan 2012) Log Message Versioning. Modified Paths branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig (104611 => 104612) --- branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-01-10 19:56:18 UTC (rev 104611) +++ branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-01-10 19:57:31 UTC (rev 104612) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 4; +TINY_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (104611 => 104612) --- branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-01-10 19:56:18 UTC (rev 104611) +++ branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-01-10 19:57:31 UTC (rev 104612) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 4; +TINY_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig (104611 => 104612) --- branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2012-01-10 19:56:18 UTC (rev 104611) +++ branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2012-01-10 19:57:31 UTC (rev 104612) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 4; +TINY_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig (104611 => 104612) --- branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-01-10 19:56:18 UTC (rev 104611) +++ branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-01-10 19:57:31 UTC (rev 104612) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 4; +TINY_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig (104611 => 104612) --- branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-01-10 19:56:18 UTC (rev 104611) +++ branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-01-10 19:57:31 UTC (rev 104612) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 4; +TINY_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104614] trunk/Tools
Title: [104614] trunk/Tools Revision 104614 Author benwe...@chromium.org Date 2012-01-10 12:08:55 -0800 (Tue, 10 Jan 2012) Log Message Adding myself (benwells) to committers.py https://bugs.webkit.org/show_bug.cgi?id=75971 Reviewed by Ojan Vafai. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (104613 => 104614) --- trunk/Tools/ChangeLog 2012-01-10 20:01:04 UTC (rev 104613) +++ trunk/Tools/ChangeLog 2012-01-10 20:08:55 UTC (rev 104614) @@ -1,3 +1,12 @@ +2012-01-10 Ben Wells benwe...@chromium.org + +Adding myself (benwells) to committers.py +https://bugs.webkit.org/show_bug.cgi?id=75971 + +Reviewed by Ojan Vafai. + +* Scripts/webkitpy/common/config/committers.py: + 2012-01-10 Mario Sanchez Prada msanc...@igalia.com AX: support helpText() in DumpRenderTree Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (104613 => 104614) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-01-10 20:01:04 UTC (rev 104613) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-01-10 20:08:55 UTC (rev 104614) @@ -182,6 +182,7 @@ Committer(Anton Muhin, ant...@chromium.org, antonm), Committer(Balazs Kelemen, kbal...@webkit.org, kbalazs), Committer(Ben Murdoch, b...@google.com, benm), +Committer(Ben Wells, benwe...@chromium.org, benwells), Committer(Benjamin C Meyer, [b...@meyerhome.net, b...@webkit.org, bme...@rim.com], icefox), Committer(Benjamin Kalman, [kal...@chromium.org, kal...@google.com], kalman), Committer(Benjamin Otte, [o...@gnome.org, o...@webkit.org], otte), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104615] trunk/Tools
Title: [104615] trunk/Tools
Revision 104615
Author aro...@apple.com
Date 2012-01-10 12:23:48 -0800 (Tue, 10 Jan 2012)
Log Message
Make MiniBrowser automatically escape invalid URL characters typed in its URL field
Fixes http://webkit.org/b/75086 Crash when typing a data: URL containing double-quotes in
MiniBrowser on Windows
Reviewed by Darin Adler.
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::goToURL): Pass the typed string through
CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/win/BrowserView.cpp
Diff
Modified: trunk/Tools/ChangeLog (104614 => 104615)
--- trunk/Tools/ChangeLog 2012-01-10 20:08:55 UTC (rev 104614)
+++ trunk/Tools/ChangeLog 2012-01-10 20:23:48 UTC (rev 104615)
@@ -1,3 +1,16 @@
+2012-01-10 Adam Roben aro...@apple.com
+
+Make MiniBrowser automatically escape invalid URL characters typed in its URL field
+
+Fixes http://webkit.org/b/75086 Crash when typing a data: URL containing double-quotes in
+MiniBrowser on Windows
+
+Reviewed by Darin Adler.
+
+* MiniBrowser/win/BrowserView.cpp:
+(BrowserView::goToURL): Pass the typed string through
+CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
+
2012-01-10 Ben Wells benwe...@chromium.org
Adding myself (benwells) to committers.py
Modified: trunk/Tools/MiniBrowser/win/BrowserView.cpp (104614 => 104615)
--- trunk/Tools/MiniBrowser/win/BrowserView.cpp 2012-01-10 20:08:55 UTC (rev 104614)
+++ trunk/Tools/MiniBrowser/win/BrowserView.cpp 2012-01-10 20:23:48 UTC (rev 104615)
@@ -152,8 +152,10 @@
void BrowserView::goToURL(const std::wstring urlString)
{
CFStringRef string = CFStringCreateWithCharacters(0, (const UniChar*)urlString.data(), urlString.size());
-CFURLRef cfURL = CFURLCreateWithString(0, string, 0);
+CFStringRef escapedString = CFURLCreateStringByAddingPercentEscapes(0, string, 0, 0, kCFStringEncodingUTF8);
CFRelease(string);
+CFURLRef cfURL = CFURLCreateWithString(0, escapedString, 0);
+CFRelease(escapedString);
WKURLRef url = ""
CFRelease(cfURL);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104616] trunk/Source/WebCore
Title: [104616] trunk/Source/WebCore
Revision 104616
Author mdela...@apple.com
Date 2012-01-10 12:30:59 -0800 (Tue, 10 Jan 2012)
Log Message
[Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
https://bugs.webkit.org/show_bug.cgi?id=75921
Reviewed by Simon Fraser.
No new tests. Does not affect detectable behavior.
* rendering/RenderLayerCompositor.cpp: Use canvas's shouldAccelerate to avoid asking
uninitialized canvas's if they're accelerated or not.
(WebCore::RenderLayerCompositor::updateBacking):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104615 => 104616)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 20:23:48 UTC (rev 104615)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 20:30:59 UTC (rev 104616)
@@ -1,3 +1,16 @@
+2012-01-09 Matthew Delaney mdela...@apple.com
+
+[Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
+https://bugs.webkit.org/show_bug.cgi?id=75921
+
+Reviewed by Simon Fraser.
+
+No new tests. Does not affect detectable behavior.
+
+* rendering/RenderLayerCompositor.cpp: Use canvas's shouldAccelerate to avoid asking
+uninitialized canvas's if they're accelerated or not.
+(WebCore::RenderLayerCompositor::updateBacking):
+
2012-01-10 Daniel Sievers siev...@chromium.org
[Chromium] Do not recreate texture updater for image layer if one exists.
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (104615 => 104616)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2012-01-10 20:23:48 UTC (rev 104615)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2012-01-10 20:30:59 UTC (rev 104616)
@@ -373,7 +373,7 @@
layer-backing()-graphicsLayer()-setAcceleratesDrawing(true);
else if (layer-renderer()-isCanvas()) {
HTMLCanvasElement* canvas = static_castHTMLCanvasElement*(layer-renderer()-node());
-if (canvas-renderingContext() canvas-renderingContext()-isAccelerated())
+if (canvas-shouldAccelerate(canvas-size()))
layer-backing()-graphicsLayer()-setAcceleratesDrawing(true);
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104619] trunk/Source/WebCore
Title: [104619] trunk/Source/WebCore
Revision 104619
Author jer.no...@apple.com
Date 2012-01-10 12:43:20 -0800 (Tue, 10 Jan 2012)
Log Message
REGRESSION (r102024): Having the Bing homepage open prevents idle sleep
https://bugs.webkit.org/show_bug.cgi?id=75972
Reviewed by Oliver Hunt.
No new tests; no testing infrastructure exists to test display sleep assertions.
Only disable idle and display sleep when a video element is not paused, not looping, and
has both a video and audio track.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRateChanged): Factor into updateDisableSleep() and
shouldDisplaySleep().
(WebCore::HTMLMediaElement::setLoop): Ditto.
(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::updateDisableSleep):
(WebCore::HTMLMediaElement::shouldDisableSleep):
* html/HTMLMediaElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104618 => 104619)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 20:42:41 UTC (rev 104618)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 20:43:20 UTC (rev 104619)
@@ -1,3 +1,24 @@
+2012-01-10 Jer Noble jer.no...@apple.com
+
+REGRESSION (r102024): Having the Bing homepage open prevents idle sleep
+https://bugs.webkit.org/show_bug.cgi?id=75972
+
+Reviewed by Oliver Hunt.
+
+No new tests; no testing infrastructure exists to test display sleep assertions.
+
+Only disable idle and display sleep when a video element is not paused, not looping, and
+has both a video and audio track.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::mediaPlayerRateChanged): Factor into updateDisableSleep() and
+shouldDisplaySleep().
+(WebCore::HTMLMediaElement::setLoop): Ditto.
+(WebCore::HTMLMediaElement::attributeChanged): Ditto.
+(WebCore::HTMLMediaElement::updateDisableSleep):
+(WebCore::HTMLMediaElement::shouldDisableSleep):
+* html/HTMLMediaElement.h:
+
2012-01-09 Matthew Delaney mdela...@apple.com
[Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (104618 => 104619)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-01-10 20:42:41 UTC (rev 104618)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-01-10 20:43:20 UTC (rev 104619)
@@ -326,6 +326,10 @@
scheduleLoad(MediaResource);
} else if (attrName == controlsAttr)
configureMediaControls();
+#if PLATFORM(MAC)
+else if (attrName == loopAttr)
+updateDisableSleep();
+#endif
}
void HTMLMediaElement::parseMappedAttribute(Attribute* attr)
@@ -2006,6 +2010,9 @@
{
LOG(Media, HTMLMediaElement::setLoop(%s), boolString(b));
setBooleanAttribute(loopAttr, b);
+#if PLATFORM(MAC)
+updateDisableSleep();
+#endif
}
bool HTMLMediaElement::controls() const
@@ -2737,10 +2744,7 @@
invalidateCachedTime();
#if PLATFORM(MAC)
-if (m_player-paused() m_sleepDisabler)
-m_sleepDisabler = nullptr;
-else if (!m_player-paused() !m_sleepDisabler)
-m_sleepDisabler = DisplaySleepDisabler::create(com.apple.WebCore: HTMLMediaElement playback);
+updateDisableSleep();
#endif
endProcessingMediaPlayerCallback();
@@ -3736,6 +3740,21 @@
}
}
+#if PLATFORM(MAC)
+void HTMLMediaElement::updateDisableSleep()
+{
+if (!shouldDisableSleep() m_sleepDisabler)
+m_sleepDisabler = nullptr;
+else if (shouldDisableSleep() !m_sleepDisabler)
+m_sleepDisabler = DisplaySleepDisabler::create(com.apple.WebCore: HTMLMediaElement playback);
}
+bool HTMLMediaElement::shouldDisableSleep() const
+{
+return !m_player-paused() hasVideo() hasAudio() !loop();
+}
#endif
+
+}
+
+#endif
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (104618 => 104619)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2012-01-10 20:42:41 UTC (rev 104618)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2012-01-10 20:43:20 UTC (rev 104619)
@@ -461,6 +461,11 @@
bool isLiveStream() const { return movieLoadType() == MediaPlayer::LiveStream; }
bool isAutoplaying() const { return m_autoplaying; }
+#if PLATFORM(MAC)
+void updateDisableSleep();
+bool shouldDisableSleep() const;
+#endif
+
TimerHTMLMediaElement m_loadTimer;
TimerHTMLMediaElement m_asyncEventTimer;
TimerHTMLMediaElement m_progressEventTimer;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104620] trunk/Source/JavaScriptCore
Title: [104620] trunk/Source/_javascript_Core
Revision 104620
Author barraclo...@apple.com
Date 2012-01-10 13:01:01 -0800 (Tue, 10 Jan 2012)
Log Message
Build fix following https://bugs.webkit.org/show_bug.cgi?id=75935
Fix 32-bit builds.
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSArray.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (104619 => 104620)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-10 20:43:20 UTC (rev 104619)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-10 21:01:01 UTC (rev 104620)
@@ -1,5 +1,15 @@
2012-01-10 Gavin Barraclough barraclo...@apple.com
+Build fix following https://bugs.webkit.org/show_bug.cgi?id=75935
+
+Fix 32-bit builds.
+
+* runtime/JSArray.cpp:
+(JSC::JSArray::getOwnPropertyNames):
+(JSC::JSArray::setLength):
+
+2012-01-10 Gavin Barraclough barraclo...@apple.com
+
Windows build fix.
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
Modified: trunk/Source/_javascript_Core/runtime/JSArray.cpp (104619 => 104620)
--- trunk/Source/_javascript_Core/runtime/JSArray.cpp 2012-01-10 20:43:20 UTC (rev 104619)
+++ trunk/Source/_javascript_Core/runtime/JSArray.cpp 2012-01-10 21:01:01 UTC (rev 104620)
@@ -899,7 +899,7 @@
SparseArrayValueMap::const_iterator end = map-end();
for (SparseArrayValueMap::const_iterator it = map-begin(); it != end; ++it) {
if (mode == IncludeDontEnumProperties || !(it-second.attributes DontEnum))
-keys.append(it-first);
+keys.append(static_castunsigned(it-first));
}
qsort(keys.begin(), keys.size(), sizeof(unsigned), compareKeysForQSort);
@@ -1114,7 +1114,7 @@
keys.reserveCapacity(min(map-size(), static_castsize_t(length - newLength)));
SparseArrayValueMap::const_iterator end = map-end();
for (SparseArrayValueMap::const_iterator it = map-begin(); it != end; ++it) {
-unsigned index = it-first;
+unsigned index = static_castunsigned(it-first);
if (index length index = newLength)
keys.append(index);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104621] trunk/Tools
Title: [104621] trunk/Tools Revision 104621 Author aro...@apple.com Date 2012-01-10 13:05:59 -0800 (Tue, 10 Jan 2012) Log Message Make it possible to type data: URLs into MiniBrowser on Windows Fixes http://webkit.org/b/75084 Crash when trying to navigate to a data: URL in MiniBrowser on Windows Reviewed by Darin Adler. * MiniBrowser/win/BrowserWindow.cpp: (BrowserWindow::handleMessage): Instead of checking for an http:// prefix when deciding whether to prepend http://, just look for whether the typed URL contains a colon. If it does, we assume it already has a scheme and don't modify it. Modified Paths trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/win/BrowserWindow.cpp Diff Modified: trunk/Tools/ChangeLog (104620 => 104621) --- trunk/Tools/ChangeLog 2012-01-10 21:01:01 UTC (rev 104620) +++ trunk/Tools/ChangeLog 2012-01-10 21:05:59 UTC (rev 104621) @@ -1,5 +1,19 @@ 2012-01-10 Adam Roben aro...@apple.com +Make it possible to type data: URLs into MiniBrowser on Windows + +Fixes http://webkit.org/b/75084 Crash when trying to navigate to a data: URL in +MiniBrowser on Windows + +Reviewed by Darin Adler. + +* MiniBrowser/win/BrowserWindow.cpp: +(BrowserWindow::handleMessage): Instead of checking for an http:// prefix when deciding +whether to prepend http://, just look for whether the typed URL contains a colon. If it +does, we assume it already has a scheme and don't modify it. + +2012-01-10 Adam Roben aro...@apple.com + Make MiniBrowser automatically escape invalid URL characters typed in its URL field Fixes http://webkit.org/b/75086 Crash when typing a data: URL containing double-quotes in Modified: trunk/Tools/MiniBrowser/win/BrowserWindow.cpp (104620 => 104621) --- trunk/Tools/MiniBrowser/win/BrowserWindow.cpp 2012-01-10 21:01:01 UTC (rev 104620) +++ trunk/Tools/MiniBrowser/win/BrowserWindow.cpp 2012-01-10 21:05:59 UTC (rev 104621) @@ -251,7 +251,7 @@ std::wstring url(buffer[0], buffer.size() - 1); -if (url.find(Lhttp://)) +if (url.find(L:) == std::wstring::npos) url = "" + url; m_browserView.goToURL(url); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104622] trunk
Title: [104622] trunk
Revision 104622
Author cmar...@apple.com
Date 2012-01-10 13:12:45 -0800 (Tue, 10 Jan 2012)
Log Message
Turn off the FilterTrigger in WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=75914
Reviewed by Simon Fraser.
Source/WebKit/mac:
Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::allowedCompositingTriggers):
Source/WebKit2:
Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::allowedCompositingTriggers):
LayoutTests:
Test to make sure compositing layers are off for filters
* css3/filters/should-not-have-compositing-layer-expected.txt: Added.
* css3/filters/should-not-have-compositing-layer.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
Added Paths
trunk/LayoutTests/css3/filters/should-not-have-compositing-layer-expected.txt
trunk/LayoutTests/css3/filters/should-not-have-compositing-layer.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104621 => 104622)
--- trunk/LayoutTests/ChangeLog 2012-01-10 21:05:59 UTC (rev 104621)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 21:12:45 UTC (rev 104622)
@@ -1,3 +1,15 @@
+2012-01-10 Chris Marrin cmar...@apple.com
+
+Turn off the FilterTrigger in WebKit and WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=75914
+
+Reviewed by Simon Fraser.
+
+Test to make sure compositing layers are off for filters
+
+* css3/filters/should-not-have-compositing-layer-expected.txt: Added.
+* css3/filters/should-not-have-compositing-layer.html: Added.
+
2012-01-10 Stephen Chenney schen...@chromium.org
[Chromium] Rebaseline after r104585
Added: trunk/LayoutTests/css3/filters/should-not-have-compositing-layer-expected.txt (0 => 104622)
--- trunk/LayoutTests/css3/filters/should-not-have-compositing-layer-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/filters/should-not-have-compositing-layer-expected.txt 2012-01-10 21:12:45 UTC (rev 104622)
@@ -0,0 +1,8 @@
+Test to make sure a simple CSS filter does not create a compositing layer. Test is successful of render tree does not show any compositing
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS no compositing layers
+
+
Added: trunk/LayoutTests/css3/filters/should-not-have-compositing-layer.html (0 => 104622)
--- trunk/LayoutTests/css3/filters/should-not-have-compositing-layer.html (rev 0)
+++ trunk/LayoutTests/css3/filters/should-not-have-compositing-layer.html 2012-01-10 21:12:45 UTC (rev 104622)
@@ -0,0 +1,30 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function doTest()
+{
+description(Test to make sure a simple CSS filter does not create a compositing layer. Test is successful of render tree does not show any compositing);
+if (window.layoutTestController) {
+var layers = layoutTestController.layerTreeAsText();
+if (layers == )
+testPassed(no compositing layers);
+else
+testFailed(content has compositing layers);
+document.getElementById(layertree).innerText = layers;
+layoutTestController.notifyDone();
+}
+}
+
+window.addEventListener('load', doTest, false);
+
+/script
+img style=-webkit-filter: blur(0); src=""
+div id=layertree/div
\ No newline at end of file
Modified: trunk/Source/WebKit/mac/ChangeLog (104621 => 104622)
--- trunk/Source/WebKit/mac/ChangeLog 2012-01-10 21:05:59 UTC (rev 104621)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-01-10 21:12:45 UTC (rev 104622)
@@ -1,3 +1,15 @@
+2012-01-10 Chris Marrin cmar...@apple.com
+
+Turn off the FilterTrigger in WebKit and WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=75914
+
+Reviewed by Simon Fraser.
+
+Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.
+
+* WebCoreSupport/WebChromeClient.h:
+(WebChromeClient::allowedCompositingTriggers):
+
2012-01-10 Dan Bernstein m...@apple.com
Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (104621 => 104622)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2012-01-10 21:05:59 UTC (rev 104621)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2012-01-10 21:12:45 UTC (rev 104622)
@@ -150,6 +150,16
[webkit-changes] [104623] trunk/Source/WebKit2
Title: [104623] trunk/Source/WebKit2
Revision 104623
Author ander...@apple.com
Date 2012-01-10 13:14:16 -0800 (Tue, 10 Jan 2012)
Log Message
DispatchOnConnectionQueue messages should have a Connection parameter
https://bugs.webkit.org/show_bug.cgi?id=75986
Reviewed by Adam Roben.
Message handlers for messages with the DispatchOnConnectionQueue should have a CoreIPC::Connection
parameter, making it easier to send messages back over that connection.
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageOnConnectionQueue):
* Scripts/webkit2/messages.py:
(async_case_statement):
(generate_message_handler):
* Scripts/webkit2/messages_unittest.py:
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):
* WebProcess/WebPage/EventDispatcher.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::pluginProcessCrashed):
* WebProcess/WebProcess.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/HandleMessage.h
trunk/Source/WebKit2/Scripts/webkit2/messages.py
trunk/Source/WebKit2/Scripts/webkit2/messages_unittest.py
trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp
trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.h
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (104622 => 104623)
--- trunk/Source/WebKit2/ChangeLog 2012-01-10 21:12:45 UTC (rev 104622)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-10 21:14:16 UTC (rev 104623)
@@ -1,3 +1,28 @@
+2012-01-10 Anders Carlsson ander...@apple.com
+
+DispatchOnConnectionQueue messages should have a Connection parameter
+https://bugs.webkit.org/show_bug.cgi?id=75986
+
+Reviewed by Adam Roben.
+
+Message handlers for messages with the DispatchOnConnectionQueue should have a CoreIPC::Connection
+parameter, making it easier to send messages back over that connection.
+
+* Platform/CoreIPC/HandleMessage.h:
+(CoreIPC::callMemberFunction):
+(CoreIPC::handleMessageOnConnectionQueue):
+* Scripts/webkit2/messages.py:
+(async_case_statement):
+(generate_message_handler):
+* Scripts/webkit2/messages_unittest.py:
+* WebProcess/WebPage/EventDispatcher.cpp:
+(WebKit::EventDispatcher::wheelEvent):
+(WebKit::EventDispatcher::gestureEvent):
+* WebProcess/WebPage/EventDispatcher.h:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::pluginProcessCrashed):
+* WebProcess/WebProcess.h:
+
2012-01-10 Chris Marrin cmar...@apple.com
Turn off the FilterTrigger in WebKit and WebKit2
Modified: trunk/Source/WebKit2/Platform/CoreIPC/HandleMessage.h (104622 => 104623)
--- trunk/Source/WebKit2/Platform/CoreIPC/HandleMessage.h 2012-01-10 21:12:45 UTC (rev 104622)
+++ trunk/Source/WebKit2/Platform/CoreIPC/HandleMessage.h 2012-01-10 21:14:16 UTC (rev 104623)
@@ -196,6 +196,19 @@
(object-*function)(args.argument1, delayedReply);
}
+// Dispatch functions with connection parameter.
+templatetypename C, typename MF, typename P1
+void callMemberFunction(Connection* connection, const Arguments1P1 args, C* object, MF function)
+{
+(object-*function)(connection, args.argument1);
+}
+
+templatetypename C, typename MF, typename P1, typename P2
+void callMemberFunction(Connection* connection, const Arguments2P1, P2 args, C* object, MF function)
+{
+(object-*function)(connection, args.argument1, args.argument2);
+}
+
// Variadic dispatch functions.
templatetypename C, typename MF
@@ -290,6 +303,15 @@
}
templatetypename T, typename C, typename MF
+void handleMessageOnConnectionQueue(Connection* connection, ArgumentDecoder* argumentDecoder, C* object, MF function)
+{
+typename T::DecodeType::ValueType arguments;
+if (!argumentDecoder-decode(arguments))
+return;
+callMemberFunction(connection, arguments, object, function);
+}
+
+templatetypename T, typename C, typename MF
void handleMessageVariadic(ArgumentDecoder* argumentDecoder, C* object, MF function)
{
typename T::DecodeType::ValueType arguments;
Modified: trunk/Source/WebKit2/Scripts/webkit2/messages.py (104622 => 104623)
--- trunk/Source/WebKit2/Scripts/webkit2/messages.py 2012-01-10 21:12:45 UTC (rev 104622)
+++ trunk/Source/WebKit2/Scripts/webkit2/messages.py 2012-01-10 21:14:16 UTC (rev 104623)
@@ -311,16 +311,21 @@
return '%s::%s' % (receiver.name, message.name[0].lower() + message.name[1:])
-def async_case_statement(receiver, message, statement_before_return=None):
+def async_case_statement(receiver, message):
+dispatch_function_args = ['arguments', 'this', '%s' % handler_function(receiver, message)]
dispatch_function = 'handleMessage'
if message_is_variadic(message):
dispatch_function += 'Variadic'
-
+if
[webkit-changes] [104627] trunk/LayoutTests
Title: [104627] trunk/LayoutTests Revision 104627 Author o...@chromium.org Date 2012-01-10 13:30:30 -0800 (Tue, 10 Jan 2012) Log Message Layout test rebaselines after r104606. * platform/chromium-win/fast/harness/results-expected.txt: Renamed from LayoutTests/platform/chromium/fast/harness/results-expected.txt. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-win/fast/harness/ trunk/LayoutTests/platform/chromium-win/fast/harness/results-expected.txt Removed Paths trunk/LayoutTests/platform/chromium/fast/harness/results-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104626 => 104627) --- trunk/LayoutTests/ChangeLog 2012-01-10 21:24:39 UTC (rev 104626) +++ trunk/LayoutTests/ChangeLog 2012-01-10 21:30:30 UTC (rev 104627) @@ -1,5 +1,11 @@ 2012-01-10 Ojan Vafai o...@chromium.org +Layout test rebaselines after r104606. + +* platform/chromium-win/fast/harness/results-expected.txt: Renamed from LayoutTests/platform/chromium/fast/harness/results-expected.txt. + +2012-01-10 Ojan Vafai o...@chromium.org + Rename flex-align to flex-item-align. https://bugs.webkit.org/show_bug.cgi?id=75929 Deleted: trunk/LayoutTests/platform/chromium/fast/harness/results-expected.txt (104626 => 104627) --- trunk/LayoutTests/platform/chromium/fast/harness/results-expected.txt 2012-01-10 21:24:39 UTC (rev 104626) +++ trunk/LayoutTests/platform/chromium/fast/harness/results-expected.txt 2012-01-10 21:30:30 UTC (rev 104627) @@ -1,179 +0,0 @@ -You should see a serios of PASS lines. -TEST-1: PASS -TEST-1: PASS -TEST-1: PASS -TEST-2: PASS -TEST-2: PASS -TEST-2: PASS -TEST-2: PASS -TEST-2: PASS -TEST-3: PASS -TEST-3: PASS -TEST-4: PASS -TEST-4: PASS -TEST-4: PASS -TEST-4: PASS -TEST-4: PASS -TEST-4: PASS -TEST-4: PASS -TEST-4: PASS -TEST-4: PASS -TEST-4: PASS -TEST-4: PASS -TEST-4: PASS -TEST-5: PASS -TEST-5: PASS -TEST-5: PASS -TEST-5: PASS -TEST-5: PASS -TEST-5: PASS -TEST-5: PASS -TEST-5: PASS -TEST-5: PASS -TEST-5: PASS -TEST-5: PASS -TEST-5: PASS -TEST-6: PASS -TEST-6: PASS -TEST-6: PASS -TEST-6: PASS -TEST-6: PASS -TEST-6: PASS -TEST-6: PASS -TEST-6: PASS -TEST-6: PASS -TEST-6: PASS -TEST-6: PASS -TEST-7: PASS -TEST-8: PASS -TEST-8: PASS -TEST-8: PASS -TEST-8: PASS -TEST-8: PASS -TEST-8: PASS -TEST-9: PASS -TEST-9: PASS -TEST-9: PASS -TEST-9: PASS -TEST-9: PASS -TEST-9: PASS -TEST-10: PASS -TEST-10: PASS -TEST-10: PASS -TEST-10: PASS -TEST-10: PASS -TEST-10: PASS -TEST-11: PASS -TEST-11: PASS -TEST-11: PASS -TEST-11: PASS -TEST-11: PASS -TEST-11: PASS -TEST-12: PASS -TEST-12: PASS -TEST-12: PASS -TEST-12: PASS -TEST-12: PASS -TEST-12: PASS -TEST-13: PASS -TEST-13: PASS -TEST-13: PASS -TEST-13: PASS -TEST-13: PASS -TEST-13: PASS -TEST-14: PASS -TEST-14: PASS -TEST-14: PASS -TEST-14: PASS -TEST-14: PASS -TEST-14: PASS -TEST-15: PASS -TEST-15: PASS -TEST-15: PASS -TEST-15: PASS -TEST-15: PASS -TEST-15: PASS -TEST-16: PASS -TEST-16: PASS -TEST-16: PASS -TEST-16: PASS -TEST-16: PASS -TEST-16: PASS -TEST-17: PASS -TEST-18: PASS -TEST-18: PASS -TEST-18: PASS -TEST-18: PASS -TEST-18: PASS -TEST-18: PASS -TEST-19: PASS -TEST-20: PASS -TEST-20: PASS -TEST-20: PASS -TEST-21: PASS -TEST-21: PASS -TEST-21: PASS -TEST-22: PASS -TEST-22: PASS -TEST-22: PASS -TEST-22: PASS -TEST-23: PASS -TEST-23: PASS -TEST-24: PASS -TEST-24: PASS -TEST-24: PASS -TEST-24: PASS -TEST-24: PASS -TEST-25: PASS -TEST-25: PASS -TEST-26: PASS -TEST-26: PASS -TEST-27: PASS -TEST-28: PASS -TEST-28: PASS -TEST-29: PASS -TEST-30: PASS -TEST-31: PASS -TEST-32: PASS -TEST-32: PASS -TEST-32: PASS -TEST-33: PASS -TEST-33: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-34: PASS -TEST-35: PASS -TEST-35: PASS -TEST-35: PASS -TEST-35: PASS -TEST-35: PASS -TEST-35: PASS -TEST-35: PASS -TEST-35: PASS -TEST-35: PASS -TEST-35: PASS -TEST-36: PASS -TEST-36: PASS -TEST-36: PASS -TEST-36: PASS -TEST-37: PASS -TEST-37: PASS -TEST-37: PASS -TEST-37: PASS -TEST-37: PASS -TEST-37: PASS -TEST-37: PASS -TEST-37: PASS Copied: trunk/LayoutTests/platform/chromium-win/fast/harness/results-expected.txt (from rev 104625, trunk/LayoutTests/platform/chromium/fast/harness/results-expected.txt) (0 => 104627) --- trunk/LayoutTests/platform/chromium-win/fast/harness/results-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-win/fast/harness/results-expected.txt 2012-01-10 21:30:30 UTC (rev 104627) @@ -0,0 +1,195 @@ +You should see a serios of PASS lines. +TEST-1: PASS +TEST-1: PASS +TEST-1: PASS +TEST-2: PASS +TEST-2: PASS +TEST-2: PASS +TEST-2: PASS +TEST-2: PASS +TEST-3: PASS +TEST-3: PASS +TEST-4: PASS +TEST-4: PASS +TEST-4: PASS +TEST-4: PASS +TEST-4: PASS +TEST-4: PASS +TEST-4: PASS +TEST-4: PASS +TEST-4: PASS +TEST-4: PASS +TEST-4: PASS +TEST-4: PASS +TEST-5:
[webkit-changes] [104628] trunk
Title: [104628] trunk
Revision 104628
Author simon.fra...@apple.com
Date 2012-01-10 13:38:41 -0800 (Tue, 10 Jan 2012)
Log Message
Clean up RenderLayerBacking code that looks for the body
https://bugs.webkit.org/show_bug.cgi?id=39502
Source/WebCore:
Reviewed by Dave Hyatt.
Consolidate code that propagates the body background to the
root, adding a utility method on RenderObject that is called
by RenderBox and RenderLayerBacking.
Removed an unused method in RenderLayerBacking.
The compositiong changes are not testable, since rendererBackgroundColor()
is only used by fullscreen at present.
Tests: fast/backgrounds/root-background-propagation.html
fast/backgrounds/root-background-propagation2.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::rendererBackgroundColor):
* rendering/RenderLayerBacking.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::rendererForRootBackground):
* rendering/RenderObject.h:
LayoutTests:
Reviewed by Dave Hyatt.
Tests for propagation of the body background to the root.
* fast/backgrounds/root-background-propagation-expected.png: Added.
* fast/backgrounds/root-background-propagation-expected.txt: Added.
* fast/backgrounds/root-background-propagation.html: Added.
* fast/backgrounds/root-background-propagation2-expected.png: Added.
* fast/backgrounds/root-background-propagation2-expected.txt: Added.
* fast/backgrounds/root-background-propagation2.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
Added Paths
trunk/LayoutTests/fast/backgrounds/root-background-propagation-expected.png
trunk/LayoutTests/fast/backgrounds/root-background-propagation-expected.txt
trunk/LayoutTests/fast/backgrounds/root-background-propagation.html
trunk/LayoutTests/fast/backgrounds/root-background-propagation2-expected.png
trunk/LayoutTests/fast/backgrounds/root-background-propagation2-expected.txt
trunk/LayoutTests/fast/backgrounds/root-background-propagation2.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104627 => 104628)
--- trunk/LayoutTests/ChangeLog 2012-01-10 21:30:30 UTC (rev 104627)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 21:38:41 UTC (rev 104628)
@@ -1,3 +1,19 @@
+2012-01-10 Simon Fraser simon.fra...@apple.com
+
+Clean up RenderLayerBacking code that looks for the body
+https://bugs.webkit.org/show_bug.cgi?id=39502
+
+Reviewed by Dave Hyatt.
+
+Tests for propagation of the body background to the root.
+
+* fast/backgrounds/root-background-propagation-expected.png: Added.
+* fast/backgrounds/root-background-propagation-expected.txt: Added.
+* fast/backgrounds/root-background-propagation.html: Added.
+* fast/backgrounds/root-background-propagation2-expected.png: Added.
+* fast/backgrounds/root-background-propagation2-expected.txt: Added.
+* fast/backgrounds/root-background-propagation2.html: Added.
+
2012-01-10 Ojan Vafai o...@chromium.org
Layout test rebaselines after r104606.
Added: trunk/LayoutTests/fast/backgrounds/root-background-propagation-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/backgrounds/root-background-propagation-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/fast/backgrounds/root-background-propagation-expected.txt (0 => 104628)
--- trunk/LayoutTests/fast/backgrounds/root-background-propagation-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/root-background-propagation-expected.txt 2012-01-10 21:38:41 UTC (rev 104628)
@@ -0,0 +1 @@
+The entire viewport should be filled with green
Property changes on: trunk/LayoutTests/fast/backgrounds/root-background-propagation-expected.txt
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Added: trunk/LayoutTests/fast/backgrounds/root-background-propagation.html (0 => 104628)
--- trunk/LayoutTests/fast/backgrounds/root-background-propagation.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/root-background-propagation.html 2012-01-10 21:38:41 UTC (rev 104628)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+head
+style
+body {
+background-color: green;
+height: 100px;
+}
+p {
+color: green; /* Hide from pixel result */
+}
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText(true);
+/script
+/head
+body
+pThe entire viewport should be filled
[webkit-changes] [104629] trunk/LayoutTests
Title: [104629] trunk/LayoutTests Revision 104629 Author dim...@chromium.org Date 2012-01-10 14:03:13 -0800 (Tue, 10 Jan 2012) Log Message [Chromium] Unreviewed test expectations update. This test needs a new baseline for Vista. * platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (104628 => 104629) --- trunk/LayoutTests/ChangeLog 2012-01-10 21:38:41 UTC (rev 104628) +++ trunk/LayoutTests/ChangeLog 2012-01-10 22:03:13 UTC (rev 104629) @@ -1,3 +1,9 @@ +2012-01-10 Dmitry Titov dim...@chromium.org + +[Chromium] Unreviewed test expectations update. This test needs a new baseline for Vista. + +* platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png: Added. + 2012-01-10 Simon Fraser simon.fra...@apple.com Clean up RenderLayerBacking code that looks for the body Added: trunk/LayoutTests/platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104631] trunk/LayoutTests
Title: [104631] trunk/LayoutTests Revision 104631 Author dim...@chromium.org Date 2012-01-10 14:09:02 -0800 (Tue, 10 Jan 2012) Log Message [Chromium] Unreviewed, rebaseline tests after r104575 and r104588. * platform/chromium-mac-leopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added. * platform/chromium-mac-leopard/fast/layers/scroll-with-transform-layer-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-mac-leopard/fast/layers/scroll-with-transform-composited-layer-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/layers/scroll-with-transform-layer-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (104630 => 104631) --- trunk/LayoutTests/ChangeLog 2012-01-10 22:08:47 UTC (rev 104630) +++ trunk/LayoutTests/ChangeLog 2012-01-10 22:09:02 UTC (rev 104631) @@ -1,5 +1,12 @@ 2012-01-10 Dmitry Titov dim...@chromium.org +[Chromium] Unreviewed, rebaseline tests after r104575 and r104588. + +* platform/chromium-mac-leopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added. +* platform/chromium-mac-leopard/fast/layers/scroll-with-transform-layer-expected.png: Added. + +2012-01-10 Dmitry Titov dim...@chromium.org + [Chromium] Unreviewed test expectations update. This test needs a new baseline for Vista. * platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png: Added. Added: trunk/LayoutTests/platform/chromium-mac-leopard/fast/layers/scroll-with-transform-composited-layer-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/fast/layers/scroll-with-transform-composited-layer-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-leopard/fast/layers/scroll-with-transform-layer-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/fast/layers/scroll-with-transform-layer-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104630] trunk/Source/JavaScriptCore
Title: [104630] trunk/Source/_javascript_Core Revision 104630 Author fpi...@apple.com Date 2012-01-10 14:08:47 -0800 (Tue, 10 Jan 2012) Log Message CodeBlock::m_numParameters should be encapsulated https://bugs.webkit.org/show_bug.cgi?id=75985 rdar://problem/10671020 Reviewed by Oliver Hunt. Encapsulated CodeBlock::m_numParameters and hooked argument profile creation into it. This appears to be performance neutral. * bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::setNumParameters): (JSC::CodeBlock::addParameter): * bytecode/CodeBlock.h: (JSC::CodeBlock::numParameters): (JSC::CodeBlock::addressOfNumParameters): (JSC::CodeBlock::offsetOfNumParameters): (JSC::CodeBlock::numberOfArgumentValueProfiles): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::addParameter): (JSC::BytecodeGenerator::emitReturn): * dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::AbstractState): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::ByteCodeParser): (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry): * dfg/DFGGraph.cpp: (JSC::DFG::Graph::predictArgumentTypes): * dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction): * dfg/DFGOperations.cpp: * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::checkArgumentTypes): * dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::SpeculativeJIT): * interpreter/Interpreter.cpp: (JSC::Interpreter::slideRegisterWindowForCall): (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall): * jit/JIT.cpp: (JSC::JIT::privateCompile): * jit/JITStubs.cpp: (JSC::arityCheckFor): (JSC::lazyLinkFor): * runtime/Executable.cpp: (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp trunk/Source/_javascript_Core/bytecode/CodeBlock.h trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGGraph.cpp trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp trunk/Source/_javascript_Core/dfg/DFGOperations.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h trunk/Source/_javascript_Core/interpreter/Interpreter.cpp trunk/Source/_javascript_Core/jit/JIT.cpp trunk/Source/_javascript_Core/jit/JITStubs.cpp trunk/Source/_javascript_Core/runtime/Executable.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (104629 => 104630) --- trunk/Source/_javascript_Core/ChangeLog 2012-01-10 22:03:13 UTC (rev 104629) +++ trunk/Source/_javascript_Core/ChangeLog 2012-01-10 22:08:47 UTC (rev 104630) @@ -1,3 +1,55 @@ +2012-01-10 Filip Pizlo fpi...@apple.com + +CodeBlock::m_numParameters should be encapsulated +https://bugs.webkit.org/show_bug.cgi?id=75985 +rdar://problem/10671020 + +Reviewed by Oliver Hunt. + +Encapsulated CodeBlock::m_numParameters and hooked argument profile creation +into it. This appears to be performance neutral. + +* bytecode/CodeBlock.cpp: +(JSC::CodeBlock::CodeBlock): +(JSC::CodeBlock::setNumParameters): +(JSC::CodeBlock::addParameter): +* bytecode/CodeBlock.h: +(JSC::CodeBlock::numParameters): +(JSC::CodeBlock::addressOfNumParameters): +(JSC::CodeBlock::offsetOfNumParameters): +(JSC::CodeBlock::numberOfArgumentValueProfiles): +* bytecompiler/BytecodeGenerator.cpp: +(JSC::BytecodeGenerator::BytecodeGenerator): +(JSC::BytecodeGenerator::addParameter): +(JSC::BytecodeGenerator::emitReturn): +* dfg/DFGAbstractState.cpp: +(JSC::DFG::AbstractState::AbstractState): +* dfg/DFGByteCodeParser.cpp: +(JSC::DFG::ByteCodeParser::ByteCodeParser): +(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry): +* dfg/DFGGraph.cpp: +(JSC::DFG::Graph::predictArgumentTypes): +* dfg/DFGJITCompiler.cpp: +(JSC::DFG::JITCompiler::compileFunction): +* dfg/DFGOperations.cpp: +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::checkArgumentTypes): +* dfg/DFGSpeculativeJIT.h: +(JSC::DFG::SpeculativeJIT::SpeculativeJIT): +* interpreter/Interpreter.cpp: +(JSC::Interpreter::slideRegisterWindowForCall): +(JSC::Interpreter::dumpRegisters): +(JSC::Interpreter::execute): +(JSC::Interpreter::prepareForRepeatCall): +* jit/JIT.cpp: +(JSC::JIT::privateCompile): +* jit/JITStubs.cpp: +(JSC::arityCheckFor): +(JSC::lazyLinkFor): +* runtime/Executable.cpp: +(JSC::FunctionExecutable::compileForCallInternal): +
[webkit-changes] [104632] trunk
Title: [104632] trunk Revision 104632 Author senorbla...@chromium.org Date 2012-01-10 14:34:23 -0800 (Tue, 10 Jan 2012) Log Message Source/WebCore: [Chromium] Partial revert of r104566, since it breaks the shared library build on Windows. https://bugs.webkit.org/show_bug.cgi?id=75994 Reviewed by Dmitry Titov. Covered by SVG feColorMatrix tests (see LayoutTests/ChangeLog). * WebCore.gypi: * platform/graphics/filters/FEColorMatrix.h: LayoutTests: Suppress failures caused by partial revert of r104566. https://bugs.webkit.org/show_bug.cgi?id=75994 Reviewed by Dmitry Titov. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.h Diff Modified: trunk/LayoutTests/ChangeLog (104631 => 104632) --- trunk/LayoutTests/ChangeLog 2012-01-10 22:09:02 UTC (rev 104631) +++ trunk/LayoutTests/ChangeLog 2012-01-10 22:34:23 UTC (rev 104632) @@ -1,3 +1,12 @@ +2012-01-10 Stephen White senorbla...@chromium.org + +Suppress failures caused by partial revert of r104566. +https://bugs.webkit.org/show_bug.cgi?id=75994 + +Reviewed by Dmitry Titov. + +* platform/chromium/test_expectations.txt: + 2012-01-10 Dmitry Titov dim...@chromium.org [Chromium] Unreviewed, rebaseline tests after r104575 and r104588. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104631 => 104632) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 22:09:02 UTC (rev 104631) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 22:34:23 UTC (rev 104632) @@ -945,6 +945,15 @@ BUGWK62974 : svg/custom/svg-fonts-with-no-element-reference.html = IMAGE+TEXT IMAGE BUGWK62974 MAC : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = IMAGE +BUGSENORBLANCO : svg/W3C-SVG-1.1/filters-color-01-b.svg = FAIL +BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr.html = FAIL +BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr.html = FAIL +BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr.html = FAIL +BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop.html = FAIL + +BUGSENORBLANCO : svg/filters/feColorMatrix-offset.svg = FAIL +BUGSENORBLANCO : svg/filters/feColorMatrix-saturate.svg = FAIL + // - // End SVG Regressions // - Modified: trunk/Source/WebCore/ChangeLog (104631 => 104632) --- trunk/Source/WebCore/ChangeLog 2012-01-10 22:09:02 UTC (rev 104631) +++ trunk/Source/WebCore/ChangeLog 2012-01-10 22:34:23 UTC (rev 104632) @@ -1,3 +1,16 @@ +2012-01-10 Stephen White senorbla...@chromium.org + +[Chromium] Partial revert of r104566, since it breaks the shared +library build on Windows. +https://bugs.webkit.org/show_bug.cgi?id=75994 + +Reviewed by Dmitry Titov. + +Covered by SVG feColorMatrix tests (see LayoutTests/ChangeLog). + +* WebCore.gypi: +* platform/graphics/filters/FEColorMatrix.h: + 2012-01-10 Simon Fraser simon.fra...@apple.com Clean up RenderLayerBacking code that looks for the body Modified: trunk/Source/WebCore/WebCore.gypi (104631 => 104632) --- trunk/Source/WebCore/WebCore.gypi 2012-01-10 22:09:02 UTC (rev 104631) +++ trunk/Source/WebCore/WebCore.gypi 2012-01-10 22:34:23 UTC (rev 104632) @@ -3747,7 +3747,6 @@ 'platform/graphics/filters/arm/FEGaussianBlurNEON.h', 'platform/graphics/filters/arm/FELightingNEON.cpp', 'platform/graphics/filters/arm/FELightingNEON.h', -'platform/graphics/filters/skia/FEColorMatrixSkia.cpp', 'platform/graphics/filters/skia/FEGaussianBlurSkia.cpp', 'platform/graphics/freetype/FontCacheFreeType.cpp', 'platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp', Modified: trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.h (104631 => 104632) --- trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.h 2012-01-10 22:09:02 UTC (rev 104631) +++ trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.h 2012-01-10 22:34:23 UTC (rev 104632) @@ -49,9 +49,6 @@ bool setValues(const Vectorfloat); virtual void platformApplySoftware(); -#if USE(SKIA) -virtual bool platformApplySkia(); -#endif virtual void dump(); virtual TextStream externalRepresentation(TextStream, int indention) const; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104634] trunk/Source/WebKit/chromium
Title: [104634] trunk/Source/WebKit/chromium
Revision 104634
Author bbu...@chromium.org
Date 2012-01-10 15:01:52 -0800 (Tue, 10 Jan 2012)
Log Message
Allow plugins to add rotate items to browser's context menu. Adds a new
WebPluginAction struct, with rotate types.
https://bugs.webkit.org/show_bug.cgi?id=75645
Reviewed by Darin Fisher.
* WebKit.gyp:
* public/WebContextMenuData.h:
* public/WebPlugin.h:
(WebKit::WebPlugin::canRotateView):
(WebKit::WebPlugin::rotateView):
* public/WebPluginAction.h: Added.
(WebKit::WebPluginAction::WebPluginAction):
* public/WebView.h:
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::performMediaPlayerAction):
(WebKit::WebViewImpl::performPluginAction):
* src/WebViewImpl.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/WebContextMenuData.h
trunk/Source/WebKit/chromium/public/WebPlugin.h
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
Added Paths
trunk/Source/WebKit/chromium/public/WebPluginAction.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (104633 => 104634)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-10 22:50:51 UTC (rev 104633)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-10 23:01:52 UTC (rev 104634)
@@ -1,3 +1,26 @@
+2012-01-10 Bill Budge bbu...@chromium.org
+
+Allow plugins to add rotate items to browser's context menu. Adds a new
+WebPluginAction struct, with rotate types.
+https://bugs.webkit.org/show_bug.cgi?id=75645
+
+Reviewed by Darin Fisher.
+
+* WebKit.gyp:
+* public/WebContextMenuData.h:
+* public/WebPlugin.h:
+(WebKit::WebPlugin::canRotateView):
+(WebKit::WebPlugin::rotateView):
+* public/WebPluginAction.h: Added.
+(WebKit::WebPluginAction::WebPluginAction):
+* public/WebView.h:
+* src/ContextMenuClientImpl.cpp:
+(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::performMediaPlayerAction):
+(WebKit::WebViewImpl::performPluginAction):
+* src/WebViewImpl.h:
+
2012-01-10 Dana Jansens dan...@chromium.org
[chromium] Create iterators for the RenderSurface-Layer tree
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (104633 => 104634)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2012-01-10 22:50:51 UTC (rev 104633)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-01-10 23:01:52 UTC (rev 104634)
@@ -216,6 +216,7 @@
'public/WebPerformance.h',
'public/WebPermissionClient.h',
'public/WebPlugin.h',
+'public/WebPluginAction.h',
'public/WebPluginContainer.h',
'public/WebPluginDocument.h',
'public/WebPluginListBuilder.h',
Modified: trunk/Source/WebKit/chromium/public/WebContextMenuData.h (104633 => 104634)
--- trunk/Source/WebKit/chromium/public/WebContextMenuData.h 2012-01-10 22:50:51 UTC (rev 104633)
+++ trunk/Source/WebKit/chromium/public/WebContextMenuData.h 2012-01-10 23:01:52 UTC (rev 104634)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -102,6 +102,7 @@
MediaHasVideo = 0x40,
MediaControlRootElement = 0x80,
MediaCanPrint = 0x100,
+MediaCanRotate = 0x200,
};
// Extra attributes describing media elements.
Modified: trunk/Source/WebKit/chromium/public/WebPlugin.h (104633 => 104634)
--- trunk/Source/WebKit/chromium/public/WebPlugin.h 2012-01-10 22:50:51 UTC (rev 104633)
+++ trunk/Source/WebKit/chromium/public/WebPlugin.h 2012-01-10 23:01:52 UTC (rev 104634)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -125,6 +125,16 @@
// Tells the plugin that the user has stopped the find operation.
virtual void stopFind() { }
+// View rotation types.
+enum RotationType {
+RotationType90Clockwise,
+RotationType90Counterclockwise
+};
+// Whether the plugin can rotate the view of its content.
+virtual bool canRotateView() { return false; }
+// Rotates the plugin's view of its content.
+virtual void rotateView(RotationType type) { }
+
protected:
~WebPlugin() { }
};
Added:
[webkit-changes] [104635] trunk/Source/WebKit2
Title: [104635] trunk/Source/WebKit2
Revision 104635
Author rn...@webkit.org
Date 2012-01-10 15:17:33 -0800 (Tue, 10 Jan 2012)
Log Message
Snow Leopard build fix.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h
trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (104634 => 104635)
--- trunk/Source/WebKit2/ChangeLog 2012-01-10 23:01:52 UTC (rev 104634)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-10 23:17:33 UTC (rev 104635)
@@ -1,3 +1,10 @@
+2012-01-10 Ryosuke Niwa rn...@webkit.org
+
+Snow Leopard build fix.
+
+* UIProcess/API/mac/PageClientImpl.h:
+* UIProcess/API/mac/PageClientImpl.mm:
+
2012-01-10 Anders Carlsson ander...@apple.com
Hang opening movie that requires authentication
Modified: trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h (104634 => 104635)
--- trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h 2012-01-10 23:01:52 UTC (rev 104634)
+++ trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h 2012-01-10 23:17:33 UTC (rev 104635)
@@ -83,7 +83,9 @@
virtual WebCore::IntPoint screenToWindow(const WebCore::IntPoint);
virtual WebCore::IntRect windowToScreen(const WebCore::IntRect);
+#if ENABLE(GESTURE_EVENTS)
virtual void doneWithGestureEvent(const WebGestureEvent, bool wasEventHandled);
+#endif
virtual void doneWithKeyEvent(const NativeWebKeyboardEvent, bool wasEventHandled);
virtual PassRefPtrWebPopupMenuProxy createPopupMenuProxy(WebPageProxy*);
Modified: trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm (104634 => 104635)
--- trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2012-01-10 23:01:52 UTC (rev 104634)
+++ trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2012-01-10 23:17:33 UTC (rev 104635)
@@ -298,10 +298,12 @@
return enclosingIntRect(tempRect);
}
+#if ENABLE(GESTURE_EVENTS)
void PageClientImpl::doneWithGestureEvent(const WebGestureEvent, bool wasEventHandled)
{
notImplemented();
}
+#endif
void PageClientImpl::doneWithKeyEvent(const NativeWebKeyboardEvent event, bool eventWasHandled)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104636] trunk/Source/WebCore
Title: [104636] trunk/Source/WebCore
Revision 104636
Author commit-qu...@webkit.org
Date 2012-01-10 15:19:03 -0800 (Tue, 10 Jan 2012)
Log Message
[chromium] Correctly recreate DrawingBuffer on lost device
https://bugs.webkit.org/show_bug.cgi?id=75912
Patch by John Bauman jbau...@chromium.org on 2012-01-10
Reviewed by Kenneth Russell.
Create new drawing buffer on new context, not old lost context. Also,
make sure to bind new drawing buffer.
No new tests.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::maybeRestoreContext):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104635 => 104636)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 23:17:33 UTC (rev 104635)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 23:19:03 UTC (rev 104636)
@@ -1,3 +1,18 @@
+2012-01-10 John Bauman jbau...@chromium.org
+
+[chromium] Correctly recreate DrawingBuffer on lost device
+https://bugs.webkit.org/show_bug.cgi?id=75912
+
+Reviewed by Kenneth Russell.
+
+Create new drawing buffer on new context, not old lost context. Also,
+make sure to bind new drawing buffer.
+
+No new tests.
+
+* html/canvas/WebGLRenderingContext.cpp:
+(WebCore::WebGLRenderingContext::maybeRestoreContext):
+
2012-01-10 Stephen White senorbla...@chromium.org
[Chromium] Partial revert of r104566, since it breaks the shared
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (104635 => 104636)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2012-01-10 23:17:33 UTC (rev 104635)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2012-01-10 23:19:03 UTC (rev 104636)
@@ -5037,7 +5037,8 @@
// Construct a new drawing buffer with the new GraphicsContext3D.
if (m_drawingBuffer) {
m_drawingBuffer-discardResources();
-m_drawingBuffer = DrawingBuffer::create(m_context.get(), m_drawingBuffer-size(), !m_attributes.preserveDrawingBuffer);
+m_drawingBuffer = DrawingBuffer::create(context.get(), m_drawingBuffer-size(), !m_attributes.preserveDrawingBuffer);
+m_drawingBuffer-bind();
}
m_context = context;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104637] trunk/Tools
Title: [104637] trunk/Tools Revision 104637 Author dpra...@chromium.org Date 2012-01-10 15:33:59 -0800 (Tue, 10 Jan 2012) Log Message webkitpy: add os_name, os_version to platforminfo https://bugs.webkit.org/show_bug.cgi?id=75931 Reviewed by Eric Siedel. As a first step in cleaning up the version parsing logic in webkitpy.layout_tests.port, this adds common routines for getting the os_name and os_version fields to the PlatformInfo class. Nothing uses them yet but I've added FIXME's to some of the code that needs to be deleted in the port files. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo.__init__): (PlatformInfo): (PlatformInfo._determine_os_name): (PlatformInfo._determine_mac_version): (PlatformInfo._determine_linux_version): (PlatformInfo._determine_win_version): (PlatformInfo.display_name): (PlatformInfo.total_bytes_memory): (PlatformInfo._compute_bytes_from_vm_stat_output): (PlatformInfo.free_bytes_memory): * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added. (TestPlatformInfo): (TestPlatformInfo.make_info): (TestPlatformInfo.make_info.mock_run_command): (TestPlatformInfo.setUp): (TestPlatformInfo.tearDown): (TestPlatformInfo.test_basic): (TestPlatformInfo.integration_test_basic): (TestPlatformInfo.test_display_name_mac): (TestPlatformInfo.test_display_name_win32): (TestPlatformInfo.test_memory_mac): (TestPlatformInfo.test_memory_win32): (TestPlatformInfo.test_determine_os_name): (TestPlatformInfo.test_determine_mac_version): (TestPlatformInfo.test_determine_linux_version): (TestPlatformInfo.test_determine_win_version_from_tuple): (TestPlatformInfo.test_determine_win_version_from_cmd): * Scripts/webkitpy/layout_tests/port/apple.py: (ApplePort.__init__): * Scripts/webkitpy/layout_tests/port/chromium_mac.py: (ChromiumMacPort.__init__): * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort): * Scripts/webkitpy/layout_tests/port/win.py: (WinPort): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py trunk/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py trunk/Tools/Scripts/webkitpy/common/system/systemhost.py trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py Added Paths trunk/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py Diff Modified: trunk/Tools/ChangeLog (104636 => 104637) --- trunk/Tools/ChangeLog 2012-01-10 23:19:03 UTC (rev 104636) +++ trunk/Tools/ChangeLog 2012-01-10 23:33:59 UTC (rev 104637) @@ -1,3 +1,53 @@ +2012-01-09 Dirk Pranke dpra...@chromium.org + +webkitpy: add os_name, os_version to platforminfo +https://bugs.webkit.org/show_bug.cgi?id=75931 + +Reviewed by Eric Siedel. + +As a first step in cleaning up the version parsing logic in +webkitpy.layout_tests.port, this adds common routines for +getting the os_name and os_version fields to the PlatformInfo +class. Nothing uses them yet but I've added FIXME's to some of +the code that needs to be deleted in the port files. + +* Scripts/webkitpy/common/system/platforminfo.py: +(PlatformInfo.__init__): +(PlatformInfo): +(PlatformInfo._determine_os_name): +(PlatformInfo._determine_mac_version): +(PlatformInfo._determine_linux_version): +(PlatformInfo._determine_win_version): +(PlatformInfo.display_name): +(PlatformInfo.total_bytes_memory): +(PlatformInfo._compute_bytes_from_vm_stat_output): +(PlatformInfo.free_bytes_memory): +* Scripts/webkitpy/common/system/platforminfo_unittest.py: Added. +(TestPlatformInfo): +(TestPlatformInfo.make_info): +(TestPlatformInfo.make_info.mock_run_command): +(TestPlatformInfo.setUp): +(TestPlatformInfo.tearDown): +(TestPlatformInfo.test_basic): +(TestPlatformInfo.integration_test_basic): +(TestPlatformInfo.test_display_name_mac): +(TestPlatformInfo.test_display_name_win32): +(TestPlatformInfo.test_memory_mac): +(TestPlatformInfo.test_memory_win32): +(TestPlatformInfo.test_determine_os_name): +(TestPlatformInfo.test_determine_mac_version): +(TestPlatformInfo.test_determine_linux_version): +(TestPlatformInfo.test_determine_win_version_from_tuple): +(TestPlatformInfo.test_determine_win_version_from_cmd): +* Scripts/webkitpy/layout_tests/port/apple.py: +(ApplePort.__init__): +* Scripts/webkitpy/layout_tests/port/chromium_mac.py: +(ChromiumMacPort.__init__): +* Scripts/webkitpy/layout_tests/port/mac.py: +(MacPort): +* Scripts/webkitpy/layout_tests/port/win.py: +(WinPort): + 2012-01-10 Adam Roben aro...@apple.com Make it possible to type data: URLs into MiniBrowser
[webkit-changes] [104638] trunk/Tools
Title: [104638] trunk/Tools Revision 104638 Author commit-qu...@webkit.org Date 2012-01-10 15:35:33 -0800 (Tue, 10 Jan 2012) Log Message [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test https://bugs.webkit.org/show_bug.cgi?id=75988 Patch by James Robinson jam...@chromium.org on 2012-01-10 Reviewed by Adam Barth. * Scripts/webkitpy/common/config/ports.py: (WebKitPort.run_webkit_unit_tests_command): (WebKitPort): (ChromiumPort.run_webkit_unit_tests_command): (ChromiumPort): * Scripts/webkitpy/common/config/ports_mock.py: (MockPort.run_webkit_unit_tests_command): * Scripts/webkitpy/tool/commands/download_unittest.py: (DownloadCommandsTest.test_build_and_test): (test_land): (test_land_red_builders): * Scripts/webkitpy/tool/steps/runtests.py: (RunTests.run): * Scripts/webkitpy/tool/steps/runtests_unittest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/ports.py trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py Diff Modified: trunk/Tools/ChangeLog (104637 => 104638) --- trunk/Tools/ChangeLog 2012-01-10 23:33:59 UTC (rev 104637) +++ trunk/Tools/ChangeLog 2012-01-10 23:35:33 UTC (rev 104638) @@ -1,3 +1,25 @@ +2012-01-10 James Robinson jam...@chromium.org + +[chromium] Run webkit_unit_tests as part of webkit-patch build-and-test +https://bugs.webkit.org/show_bug.cgi?id=75988 + +Reviewed by Adam Barth. + +* Scripts/webkitpy/common/config/ports.py: +(WebKitPort.run_webkit_unit_tests_command): +(WebKitPort): +(ChromiumPort.run_webkit_unit_tests_command): +(ChromiumPort): +* Scripts/webkitpy/common/config/ports_mock.py: +(MockPort.run_webkit_unit_tests_command): +* Scripts/webkitpy/tool/commands/download_unittest.py: +(DownloadCommandsTest.test_build_and_test): +(test_land): +(test_land_red_builders): +* Scripts/webkitpy/tool/steps/runtests.py: +(RunTests.run): +* Scripts/webkitpy/tool/steps/runtests_unittest.py: + 2012-01-09 Dirk Pranke dpra...@chromium.org webkitpy: add os_name, os_version to platforminfo Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (104637 => 104638) --- trunk/Tools/Scripts/webkitpy/common/config/ports.py 2012-01-10 23:33:59 UTC (rev 104637) +++ trunk/Tools/Scripts/webkitpy/common/config/ports.py 2012-01-10 23:35:33 UTC (rev 104638) @@ -105,6 +105,10 @@ return cls.script_shell_command(run-_javascript_core-tests) @classmethod +def run_webkit_unit_tests_command(cls): +return None + +@classmethod def run_webkit_tests_command(cls): return cls.script_shell_command(run-webkit-tests) @@ -240,6 +244,10 @@ return command @classmethod +def run_webkit_unit_tests_command(cls): +return cls.script_shell_command(run-chromium-webkit-unit-tests) + +@classmethod def run_webkit_tests_command(cls): command = cls.script_shell_command(new-run-webkit-tests) command.append(--chromium) Modified: trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py (104637 => 104638) --- trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py 2012-01-10 23:33:59 UTC (rev 104637) +++ trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py 2012-01-10 23:35:33 UTC (rev 104638) @@ -55,5 +55,8 @@ def run_javascriptcore_tests_command(self): return ['mock-run-javacriptcore-tests'] +def run_webkit_unit_tests_command(self): +return ['mock-run-webkit-unit-tests'] + def run_webkit_tests_command(self): return ['mock-run-webkit-tests'] Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (104637 => 104638) --- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2012-01-10 23:33:59 UTC (rev 104637) +++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2012-01-10 23:35:33 UTC (rev 104638) @@ -90,7 +90,7 @@ self.assert_execute_outputs(Build(), [], options=self._default_options(), expected_stderr=expected_stderr) def test_build_and_test(self): -expected_stderr = Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\n +expected_stderr = Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning _javascript_Core tests\nRunning WebKit unit tests\nRunning run-webkit-tests\n self.assert_execute_outputs(BuildAndTest(), [], options=self._default_options(), expected_stderr=expected_stderr) def test_apply_attachment(self): @@ -116,7 +116,7 @@ self.assert_execute_outputs(ApplyWatchList(), [1], options=self._default_options(),
[webkit-changes] [104639] trunk/Source/WebCore
Title: [104639] trunk/Source/WebCore
Revision 104639
Author hara...@chromium.org
Date 2012-01-10 15:35:38 -0800 (Tue, 10 Jan 2012)
Log Message
[Refactoring] Rename attributes in TestSupplemental.idl to clarify
that they are supplemental attributes
https://bugs.webkit.org/show_bug.cgi?id=75942
Reviewed by Adam Barth.
This patch just renames attributes in TestSupplemental.idl
to make it easy to find in {JS,V8,WebKitDOM,DOM,WebDOM}TestInterface.cpp
which attributes originate from TestSupplemental.idl.
* bindings/scripts/test/TestSupplemental.idl: Just renamed three attributes.
* bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated the test result.
(WebDOMTestInterface::supplementalStr1):
(WebDOMTestInterface::supplementalStr2):
(WebDOMTestInterface::setSupplementalStr2):
* bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
* bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterface):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterface):
* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.
(-[DOMTestInterface supplementalStr1]):
(-[DOMTestInterface supplementalStr2]):
(-[DOMTestInterface setSupplementalStr2:]):
(-[DOMTestInterface ]):
(-[DOMTestInterface set:]):
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::TestInterfaceInternal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceInternal::supplementalStr2AttrGetter):
(WebCore::TestInterfaceInternal::supplementalStr2AttrSetter):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.mm
trunk/Source/WebCore/bindings/scripts/test/TestSupplemental.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104638 => 104639)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 23:35:33 UTC (rev 104638)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 23:35:38 UTC (rev 104639)
@@ -1,3 +1,49 @@
+2012-01-10 Kentaro Hara hara...@chromium.org
+
+[Refactoring] Rename attributes in TestSupplemental.idl to clarify
+that they are supplemental attributes
+https://bugs.webkit.org/show_bug.cgi?id=75942
+
+Reviewed by Adam Barth.
+
+This patch just renames attributes in TestSupplemental.idl
+to make it easy to find in {JS,V8,WebKitDOM,DOM,WebDOM}TestInterface.cpp
+which attributes originate from TestSupplemental.idl.
+
+* bindings/scripts/test/TestSupplemental.idl: Just renamed three attributes.
+
+* bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated the test result.
+(WebDOMTestInterface::supplementalStr1):
+(WebDOMTestInterface::supplementalStr2):
+(WebDOMTestInterface::setSupplementalStr2):
+* bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
+* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.
+(webkit_dom_test_interface_get_supplemental_str1):
+(webkit_dom_test_interface_get_supplemental_str2):
+(webkit_dom_test_interface_set_supplemental_str2):
+(webkit_dom_test_interface_set_property):
+(webkit_dom_test_interface_get_property):
+(webkit_dom_test_interface_class_init):
+* bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
+* bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
+(WebCore::jsTestInterfaceSupplementalStr1):
+(WebCore::jsTestInterfaceSupplementalStr2):
+(WebCore::jsTestInterface):
+(WebCore::setJSTestInterfaceSupplementalStr2):
+(WebCore::setJSTestInterface):
+* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
+* bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
+* bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.
+(-[DOMTestInterface supplementalStr1]):
+(-[DOMTestInterface
[webkit-changes] [104640] trunk/LayoutTests
Title: [104640] trunk/LayoutTests Revision 104640 Author rn...@webkit.org Date 2012-01-10 15:37:01 -0800 (Tue, 10 Jan 2012) Log Message Qt rebaseline after r104625. * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104639 => 104640) --- trunk/LayoutTests/ChangeLog 2012-01-10 23:35:38 UTC (rev 104639) +++ trunk/LayoutTests/ChangeLog 2012-01-10 23:37:01 UTC (rev 104640) @@ -1,3 +1,9 @@ +2012-01-10 Ryosuke Niwa rn...@webkit.org + +Qt rebaseline after r104625. + +* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: + 2012-01-10 Stephen White senorbla...@chromium.org Suppress failures caused by partial revert of r104566. Modified: trunk/LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (104639 => 104640) --- trunk/LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-01-10 23:35:38 UTC (rev 104639) +++ trunk/LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-01-10 23:37:01 UTC (rev 104640) @@ -143,7 +143,7 @@ -webkit-column-width: auto -webkit-flex-order: 0 -webkit-flex-pack: start --webkit-flex-align: stretch +-webkit-flex-item-align: stretch -webkit-flex-direction: row -webkit-flex-flow: row nowrap -webkit-flex-wrap: nowrap ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104641] trunk/Source/WebKit/chromium
Title: [104641] trunk/Source/WebKit/chromium
Revision 104641
Author t...@chromium.org
Date 2012-01-10 15:37:55 -0800 (Tue, 10 Jan 2012)
Log Message
[chromium] Unreviewed, roll Chromium DEPS to r117109.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (104640 => 104641)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-10 23:37:01 UTC (rev 104640)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-10 23:37:55 UTC (rev 104641)
@@ -1,3 +1,9 @@
+2012-01-10 Tony Chang t...@chromium.org
+
+[chromium] Unreviewed, roll Chromium DEPS to r117109.
+
+* DEPS:
+
2012-01-10 Bill Budge bbu...@chromium.org
Allow plugins to add rotate items to browser's context menu. Adds a new
Modified: trunk/Source/WebKit/chromium/DEPS (104640 => 104641)
--- trunk/Source/WebKit/chromium/DEPS 2012-01-10 23:37:01 UTC (rev 104640)
+++ trunk/Source/WebKit/chromium/DEPS 2012-01-10 23:37:55 UTC (rev 104641)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '117006'
+ 'chromium_rev': '117109'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104642] trunk/LayoutTests
Title: [104642] trunk/LayoutTests Revision 104642 Author rn...@webkit.org Date 2012-01-10 15:44:05 -0800 (Tue, 10 Jan 2012) Log Message Chromium rebaseline after r104625. * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104641 => 104642) --- trunk/LayoutTests/ChangeLog 2012-01-10 23:37:55 UTC (rev 104641) +++ trunk/LayoutTests/ChangeLog 2012-01-10 23:44:05 UTC (rev 104642) @@ -1,5 +1,13 @@ 2012-01-10 Ryosuke Niwa rn...@webkit.org +Chromium rebaseline after r104625. + +* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: +* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: + +2012-01-10 Ryosuke Niwa rn...@webkit.org + Qt rebaseline after r104625. * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Modified: trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt (104641 => 104642) --- trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt 2012-01-10 23:37:55 UTC (rev 104641) +++ trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt 2012-01-10 23:44:05 UTC (rev 104642) @@ -144,7 +144,7 @@ -webkit-column-width: auto; -webkit-flex-order: 0; -webkit-flex-pack: start; --webkit-flex-align: stretch; +-webkit-flex-item-align: stretch; -webkit-flex-direction: row; -webkit-flex-flow: row nowrap; -webkit-flex-wrap: nowrap; Modified: trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (104641 => 104642) --- trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-01-10 23:37:55 UTC (rev 104641) +++ trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-01-10 23:44:05 UTC (rev 104642) @@ -143,7 +143,7 @@ -webkit-column-width: auto -webkit-flex-order: 0 -webkit-flex-pack: start --webkit-flex-align: stretch +-webkit-flex-item-align: stretch -webkit-flex-direction: row -webkit-flex-flow: row nowrap -webkit-flex-wrap: nowrap Modified: trunk/LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt (104641 => 104642) --- trunk/LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt 2012-01-10 23:37:55 UTC (rev 104641) +++ trunk/LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt 2012-01-10 23:44:05 UTC (rev 104642) @@ -286,8 +286,8 @@ rect: style.getPropertyCSSValue(-webkit-flex-order) : [object CSSPrimitiveValue] rect: style.getPropertyValue(-webkit-flex-pack) : start rect: style.getPropertyCSSValue(-webkit-flex-pack) : [object CSSPrimitiveValue] -rect: style.getPropertyValue(-webkit-flex-align) : stretch -rect: style.getPropertyCSSValue(-webkit-flex-align) : [object CSSPrimitiveValue] +rect: style.getPropertyValue(-webkit-flex-item-align) : stretch +rect: style.getPropertyCSSValue(-webkit-flex-item-align) : [object CSSPrimitiveValue] rect: style.getPropertyValue(-webkit-flex-direction) : row rect: style.getPropertyCSSValue(-webkit-flex-direction) : [object CSSPrimitiveValue] rect: style.getPropertyValue(-webkit-flex-flow) : row nowrap @@ -794,8 +794,8 @@ g: style.getPropertyCSSValue(-webkit-flex-order) : [object CSSPrimitiveValue] g: style.getPropertyValue(-webkit-flex-pack) : start g: style.getPropertyCSSValue(-webkit-flex-pack) : [object CSSPrimitiveValue] -g: style.getPropertyValue(-webkit-flex-align) : stretch -g: style.getPropertyCSSValue(-webkit-flex-align) : [object CSSPrimitiveValue] +g: style.getPropertyValue(-webkit-flex-item-align) : stretch +g: style.getPropertyCSSValue(-webkit-flex-item-align) : [object CSSPrimitiveValue] g: style.getPropertyValue(-webkit-flex-direction) : row g: style.getPropertyCSSValue(-webkit-flex-direction) : [object CSSPrimitiveValue] g: style.getPropertyValue(-webkit-flex-flow) : row nowrap ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104644] trunk/Source
Title: [104644] trunk/Source
Revision 104644
Author nd...@chromium.org
Date 2012-01-10 15:50:35 -0800 (Tue, 10 Jan 2012)
Log Message
[chromium] Reuse old timebase when activating CCDelayBasedTimeSource
https://bugs.webkit.org/show_bug.cgi?id=75938
Reviewed by James Robinson.
Source/WebCore:
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
Source/WebKit/chromium:
* tests/CCDelayBasedTimeSourceTest.cpp:
(WebKitTests::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104643 => 104644)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 23:48:39 UTC (rev 104643)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 23:50:35 UTC (rev 104644)
@@ -1,3 +1,17 @@
+2012-01-10 Nat Duca nd...@chromium.org
+
+[chromium] Reuse old timebase when activating CCDelayBasedTimeSource
+https://bugs.webkit.org/show_bug.cgi?id=75938
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
+(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
+(WebCore::CCDelayBasedTimeSource::setActive):
+(WebCore::CCDelayBasedTimeSource::onTimerFired):
+(WebCore::CCDelayBasedTimeSource::postNextTickTask):
+* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
+
2012-01-10 Kentaro Hara hara...@chromium.org
Support the [Supplemental] IDL on methods
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp (104643 => 104644)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp 2012-01-10 23:48:39 UTC (rev 104643)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp 2012-01-10 23:50:35 UTC (rev 104644)
@@ -40,10 +40,11 @@
CCDelayBasedTimeSource::CCDelayBasedTimeSource(double intervalMs, CCThread* thread)
: m_client(0)
+, m_hasTickTarget(false)
, m_intervalMs(intervalMs)
, m_tickTarget(0)
, m_state(STATE_INACTIVE)
-, m_thread(thread)
+, m_timer(thread, this)
{
}
@@ -51,29 +52,45 @@
{
if (!active) {
m_state = STATE_INACTIVE;
+m_timer.stop();
return;
}
-// Becoming active is deferred: we post a 0-delay task. When it runs, we use
-// that to establish the timebase, become truly active, and fire the first
-// tick.
if (m_state == STATE_STARTING || m_state == STATE_ACTIVE)
return;
-m_state = STATE_STARTING;
-postTickTask(0);
+if (!m_hasTickTarget) {
+// Becoming active the first time is deferred: we post a 0-delay task. When
+// it runs, we use that to establish the timebase, become truly active, and
+// fire the first tick.
+m_state = STATE_STARTING;
+m_timer.startOneShot(0);
+return;
+}
+
+m_state = STATE_ACTIVE;
+
+double nowMs = monotonicallyIncreasingTimeMs();
+postNextTickTask(nowMs);
}
-void CCDelayBasedTimeSource::postTickTask(long long delay)
+void CCDelayBasedTimeSource::onTimerFired()
{
-this-ref();
-m_thread-postDelayedTask(createCCThreadTask(this, CCDelayBasedTimeSource::onTick), delay);
-}
+ASSERT(m_state != STATE_INACTIVE);
-void CCDelayBasedTimeSource::onTick()
-{
-updateState();
-this-deref();
+double nowMs = monotonicallyIncreasingTimeMs();
+
+if (m_state == STATE_STARTING) {
+m_hasTickTarget = true;
+m_tickTarget = nowMs;
+m_state = STATE_ACTIVE;
+}
+
+postNextTickTask(nowMs);
+
+// Fire the tick
+if (m_client)
+m_client-onTimerTick();
}
double CCDelayBasedTimeSource::monotonicallyIncreasingTimeMs() const
@@ -124,36 +141,22 @@
//
// For the really late delay, we we move to the next logical tick. The timebase is not reset.
// now=37 tickTarget=16.667 newTarget=50.000 -- tick(), postDelayedTask(floor(50.000-37)) -- postDelayedTask(13)
-void CCDelayBasedTimeSource::updateState()
+void CCDelayBasedTimeSource::postNextTickTask(double nowMs)
{
-if (m_state == STATE_INACTIVE)
-return;
-
-double now = monotonicallyIncreasingTimeMs();
-
-if (m_state == STATE_STARTING) {
-m_tickTarget = now;
-m_state = STATE_ACTIVE;
-}
-
-int numIntervalsElapsed = static_castint(floor((now - m_tickTarget) / m_intervalMs));
+int numIntervalsElapsed = static_castint(floor((nowMs - m_tickTarget) / m_intervalMs));
double
[webkit-changes] [104645] trunk
Title: [104645] trunk
Revision 104645
Author t...@chromium.org
Date 2012-01-10 15:52:56 -0800 (Tue, 10 Jan 2012)
Log Message
Need to handle absolutely positioned elements inside flexboxes
https://bugs.webkit.org/show_bug.cgi?id=70793
Reviewed by David Hyatt.
Source/WebCore:
Tests: css3/flexbox/insert-text-crash.html
css3/flexbox/position-absolute-child.html
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Skip the size of positioned elements.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Add placeholders for positioned elements.
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout): Positions the layer for the positioned child.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Handle positioned elements.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Adjust the main axis offset of the layer for positioned elements.
* rendering/RenderFlexibleBox.h:
LayoutTests:
* css3/flexbox/insert-text-crash-expected.txt: Added.
* css3/flexbox/insert-text-crash.html: Added.
* css3/flexbox/position-absolute-child-expected.txt: Added.
* css3/flexbox/position-absolute-child.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.h
Added Paths
trunk/LayoutTests/css3/flexbox/insert-text-crash-expected.txt
trunk/LayoutTests/css3/flexbox/insert-text-crash.html
trunk/LayoutTests/css3/flexbox/position-absolute-child-expected.txt
trunk/LayoutTests/css3/flexbox/position-absolute-child.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104644 => 104645)
--- trunk/LayoutTests/ChangeLog 2012-01-10 23:50:35 UTC (rev 104644)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 23:52:56 UTC (rev 104645)
@@ -1,3 +1,15 @@
+2012-01-10 Tony Chang t...@chromium.org
+
+Need to handle absolutely positioned elements inside flexboxes
+https://bugs.webkit.org/show_bug.cgi?id=70793
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/insert-text-crash-expected.txt: Added.
+* css3/flexbox/insert-text-crash.html: Added.
+* css3/flexbox/position-absolute-child-expected.txt: Added.
+* css3/flexbox/position-absolute-child.html: Added.
+
2012-01-10 Ryosuke Niwa rn...@webkit.org
Chromium rebaseline after r104625.
Added: trunk/LayoutTests/css3/flexbox/insert-text-crash-expected.txt (0 => 104645)
--- trunk/LayoutTests/css3/flexbox/insert-text-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/flexbox/insert-text-crash-expected.txt 2012-01-10 23:52:56 UTC (rev 104645)
@@ -0,0 +1 @@
+This test passes if it does not crash.
Added: trunk/LayoutTests/css3/flexbox/insert-text-crash.html (0 => 104645)
--- trunk/LayoutTests/css3/flexbox/insert-text-crash.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/insert-text-crash.html 2012-01-10 23:52:56 UTC (rev 104645)
@@ -0,0 +1,20 @@
+style
+#el2 {
+display: -webkit-flexbox;
+border: 1px solid red;
+}
+#el3 {
+position: absolute;
+border: 1px solid green;
+}
+/style
+body contenteditable=true
+div id=el2div id=el3AA /div/div
+/body
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+document.execCommand('selectall')
+document.execCommand('inserttext', '')
+document.body.innerText = This test passes if it does not crash.;
+/script
Added: trunk/LayoutTests/css3/flexbox/position-absolute-child-expected.txt (0 => 104645)
--- trunk/LayoutTests/css3/flexbox/position-absolute-child-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/flexbox/position-absolute-child-expected.txt 2012-01-10 23:52:56 UTC (rev 104645)
@@ -0,0 +1,224 @@
+horizontal-tb ltr row
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-tb rtl row
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-tb ltr column
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-tb rtl column
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-tb ltr row-reverse
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-tb rtl row-reverse
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-tb ltr column-reverse
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-tb rtl column-reverse
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-bt ltr row
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-bt rtl row
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-bt ltr column
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-bt rtl column
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-bt ltr row-reverse
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-bt rtl row-reverse
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-bt ltr column-reverse
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+horizontal-bt rtl column-reverse
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+vertical-rl ltr row
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+vertical-rl rtl row
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+vertical-rl ltr column
+PASS
+PASS
+PASS
+PASS
+PASS
[webkit-changes] [104647] trunk
Title: [104647] trunk
Revision 104647
Author simon.fra...@apple.com
Date 2012-01-10 16:19:50 -0800 (Tue, 10 Jan 2012)
Log Message
Disabled mock scrollbars should draw differently
https://bugs.webkit.org/show_bug.cgi?id=75995
Source/WebCore:
Reviewed by James Robinson.
When the scrollbar is disabled, paint the entire track of
mock scrollbars with a lighter gray, and hide the thumb.
No tests, since mock scrollbars aren't enabled by default on Mac yet.
* platform/mock/ScrollbarThemeMock.cpp:
(WebCore::ScrollbarThemeMock::paintTrackBackground):
(WebCore::ScrollbarThemeMock::paintThumb):
Tools:
Reviewed by James Robinson.
When the scrollbar is disabled, paint the entire track of
mock scrollbars with a lighter gray, and hide the thumb.
* DumpRenderTree/mac/DumpRenderTree.mm:
(-[DRTMockScroller drawKnob]):
(-[DRTMockScroller drawRect:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mock/ScrollbarThemeMock.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (104646 => 104647)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 00:18:05 UTC (rev 104646)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 00:19:50 UTC (rev 104647)
@@ -1,3 +1,19 @@
+2012-01-10 Simon Fraser simon.fra...@apple.com
+
+Disabled mock scrollbars should draw differently
+https://bugs.webkit.org/show_bug.cgi?id=75995
+
+Reviewed by James Robinson.
+
+When the scrollbar is disabled, paint the entire track of
+mock scrollbars with a lighter gray, and hide the thumb.
+
+No tests, since mock scrollbars aren't enabled by default on Mac yet.
+
+* platform/mock/ScrollbarThemeMock.cpp:
+(WebCore::ScrollbarThemeMock::paintTrackBackground):
+(WebCore::ScrollbarThemeMock::paintThumb):
+
2012-01-10 Tony Chang t...@chromium.org
Need to handle absolutely positioned elements inside flexboxes
Modified: trunk/Source/WebCore/platform/mock/ScrollbarThemeMock.cpp (104646 => 104647)
--- trunk/Source/WebCore/platform/mock/ScrollbarThemeMock.cpp 2012-01-11 00:18:05 UTC (rev 104646)
+++ trunk/Source/WebCore/platform/mock/ScrollbarThemeMock.cpp 2012-01-11 00:19:50 UTC (rev 104647)
@@ -42,14 +42,15 @@
return cScrollbarThickness[controlSize];
}
-void ScrollbarThemeMock::paintTrackBackground(GraphicsContext* context, Scrollbar*, const IntRect trackRect)
+void ScrollbarThemeMock::paintTrackBackground(GraphicsContext* context, Scrollbar* scrollbar, const IntRect trackRect)
{
-context-fillRect(trackRect, Color::lightGray, ColorSpaceDeviceRGB);
+context-fillRect(trackRect, scrollbar-enabled() ? Color::lightGray : Color(0xFFE0E0E0), ColorSpaceDeviceRGB);
}
-void ScrollbarThemeMock::paintThumb(GraphicsContext* context, Scrollbar*, const IntRect thumbRect)
+void ScrollbarThemeMock::paintThumb(GraphicsContext* context, Scrollbar* scrollbar, const IntRect thumbRect)
{
-context-fillRect(thumbRect, Color::darkGray, ColorSpaceDeviceRGB);
+if (scrollbar-enabled())
+context-fillRect(thumbRect, Color::darkGray, ColorSpaceDeviceRGB);
}
}
Modified: trunk/Tools/ChangeLog (104646 => 104647)
--- trunk/Tools/ChangeLog 2012-01-11 00:18:05 UTC (rev 104646)
+++ trunk/Tools/ChangeLog 2012-01-11 00:19:50 UTC (rev 104647)
@@ -1,3 +1,17 @@
+2012-01-10 Simon Fraser simon.fra...@apple.com
+
+Disabled mock scrollbars should draw differently
+https://bugs.webkit.org/show_bug.cgi?id=75995
+
+Reviewed by James Robinson.
+
+When the scrollbar is disabled, paint the entire track of
+mock scrollbars with a lighter gray, and hide the thumb.
+
+* DumpRenderTree/mac/DumpRenderTree.mm:
+(-[DRTMockScroller drawKnob]):
+(-[DRTMockScroller drawRect:]):
+
2012-01-10 James Robinson jam...@chromium.org
[chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (104646 => 104647)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2012-01-11 00:18:05 UTC (rev 104646)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2012-01-11 00:19:50 UTC (rev 104647)
@@ -469,6 +469,9 @@
- (void)drawKnob
{
+if (![self isEnabled])
+return;
+
NSRect knobRect = [self rectForPart:NSScrollerKnob];
static NSColor *knobColor = [[NSColor colorWithDeviceRed:0x80 / 255.0 green:0x80 / 255.0 blue:0x80 / 255.0 alpha:1] retain];
@@ -480,8 +483,13 @@
- (void)drawRect:(NSRect)dirtyRect
{
static NSColor *trackColor = [[NSColor colorWithDeviceRed:0xC0 / 255.0 green:0xC0 / 255.0 blue:0xC0 / 255.0 alpha:1] retain];
-[trackColor set];
+static NSColor *disabledTrackColor = [[NSColor colorWithDeviceRed:0xE0 / 255.0 green:0xE0 / 255.0 blue:0xE0 / 255.0 alpha:1] retain];
+if ([self isEnabled])
+[trackColor set];
+else
+[disabledTrackColor set];
+
NSRectFill(dirtyRect);
[webkit-changes] [104649] trunk/Tools
Title: [104649] trunk/Tools Revision 104649 Author sch...@chromium.org Date 2012-01-10 16:32:36 -0800 (Tue, 10 Jan 2012) Log Message Clarify run-webkit-tests options reset-results and new-baseline https://bugs.webkit.org/show_bug.cgi?id=75993 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py Diff Modified: trunk/Tools/ChangeLog (104648 => 104649) --- trunk/Tools/ChangeLog 2012-01-11 00:23:20 UTC (rev 104648) +++ trunk/Tools/ChangeLog 2012-01-11 00:32:36 UTC (rev 104649) @@ -1,3 +1,13 @@ +2012-01-10 Vincent Scheib sch...@chromium.org + +Clarify run-webkit-tests options reset-results and new-baseline +https://bugs.webkit.org/show_bug.cgi?id=75993 + +Reviewed by Dirk Pranke. + +* Scripts/webkitpy/layout_tests/run_webkit_tests.py: +(parse_args): + 2012-01-10 Simon Fraser simon.fra...@apple.com Disabled mock scrollbars should draw differently Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (104648 => 104649) --- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-01-11 00:23:20 UTC (rev 104648) +++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-01-11 00:32:36 UTC (rev 104649) @@ -265,12 +265,12 @@ optparse.make_option(--build-directory, help=Path to the directory under which build files are kept (should not include configuration)), optparse.make_option(--new-baseline, action="" -default=False, help=Save all generated results as new baselines - into the platform directory, overwriting whatever's +default=False, help=Save generated results as new baselines + into the *platform* directory, overwriting whatever's already there.), optparse.make_option(--reset-results, action="" -default=False, help=Reset any existing baselines to the - generated results), +default=False, help=Reset expectations to the + generated results in their existing location.), optparse.make_option(--no-new-test-results, action="" dest=new_test_results, default=True, help=Don't create new baselines when no expected results exist), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104650] trunk/Source/WebKit/chromium
Title: [104650] trunk/Source/WebKit/chromium
Revision 104650
Author dch...@chromium.org
Date 2012-01-10 16:39:01 -0800 (Tue, 10 Jan 2012)
Log Message
[chromium] Unreviewed, roll Chromium DEPS to r117121.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (104649 => 104650)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-11 00:32:36 UTC (rev 104649)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-11 00:39:01 UTC (rev 104650)
@@ -1,3 +1,9 @@
+2012-01-10 Daniel Cheng dch...@chromium.org
+
+[chromium] Unreviewed, roll Chromium DEPS to r117121.
+
+* DEPS:
+
2012-01-10 Nat Duca nd...@chromium.org
[chromium] Reuse old timebase when activating CCDelayBasedTimeSource
Modified: trunk/Source/WebKit/chromium/DEPS (104649 => 104650)
--- trunk/Source/WebKit/chromium/DEPS 2012-01-11 00:32:36 UTC (rev 104649)
+++ trunk/Source/WebKit/chromium/DEPS 2012-01-11 00:39:01 UTC (rev 104650)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '117109'
+ 'chromium_rev': '117121'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104651] trunk/Source
Title: [104651] trunk/Source Revision 104651 Author ostapenko.viatches...@nokia.com Date 2012-01-10 16:42:11 -0800 (Tue, 10 Jan 2012) Log Message [Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show() crash https://bugs.webkit.org/show_bug.cgi?id=74176 Reviewed by Noam Rosenthal. Source/WebCore: Replaces static global GL resource holder with holder shared between TextureMapperGL instances created on the same GL context. Also adds deallocation of GL resources when last TextureMapperGL instance on the current GL context gets deleted. Tested by multipleWebViewWindows and multipleWebViews Qt WK2 API tests. * platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TextureMapperGLData::SharedGLData::getCurrentGLContext): (WebCore::TextureMapperGLData::SharedGLData::glContextDataMap): (WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData): (WebCore::TextureMapperGLData::SharedGLData::ProgramInfo::ProgramInfo): (WebCore::TextureMapperGLData::SharedGLData::createShaderProgram): (WebCore::TextureMapperGLData::SharedGLData::deleteShaderProgram): (WebCore::TextureMapperGLData::SharedGLData::SharedGLData): (WebCore::TextureMapperGLData::SharedGLData::~SharedGLData): (WebCore::TextureMapperGLData::sharedGLData): (WebCore::TextureMapperGLData::TextureMapperGLData): (WebCore::TextureMapperGLData::SharedGLData::initializeShaders): (WebCore::TextureMapperGL::beginPainting): (WebCore::TextureMapperGL::drawTexture): (WebCore::BitmapTextureGL::bind): (WebCore::TextureMapperGL::bindSurface): (WebCore::TextureMapperGL::beginClip): (WebCore::TextureMapperGL::endClip): * platform/graphics/opengl/TextureMapperGL.h: Source/WebKit2: Check texture mapper exists already in ensureRootLayer to avoid recrecation. Check if root layer was deleted already in purgeGLResources. Added multipleWebViewWindows and multipleWebViews API tests. * UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: (tst_QQuickWebView::multipleWebViewWindows): (tst_QQuickWebView::multipleWebViews): * UIProcess/qt/LayerTreeHostProxyQt.cpp: (WebKit::LayerTreeHostProxy::ensureRootLayer): (WebKit::LayerTreeHostProxy::purgeGLResources): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (104650 => 104651) --- trunk/Source/WebCore/ChangeLog 2012-01-11 00:39:01 UTC (rev 104650) +++ trunk/Source/WebCore/ChangeLog 2012-01-11 00:42:11 UTC (rev 104651) @@ -1,3 +1,37 @@ +2012-01-10 Viatcheslav Ostapenko ostapenko.viatches...@nokia.com + +[Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show() crash +https://bugs.webkit.org/show_bug.cgi?id=74176 + +Reviewed by Noam Rosenthal. + +Replaces static global GL resource holder with holder shared between +TextureMapperGL instances created on the same GL context. Also adds +deallocation of GL resources when last TextureMapperGL instance on the +current GL context gets deleted. + +Tested by multipleWebViewWindows and multipleWebViews Qt WK2 API tests. + +* platform/graphics/opengl/TextureMapperGL.cpp: +(WebCore::TextureMapperGLData::SharedGLData::getCurrentGLContext): +(WebCore::TextureMapperGLData::SharedGLData::glContextDataMap): +(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData): +(WebCore::TextureMapperGLData::SharedGLData::ProgramInfo::ProgramInfo): +(WebCore::TextureMapperGLData::SharedGLData::createShaderProgram): +(WebCore::TextureMapperGLData::SharedGLData::deleteShaderProgram): +(WebCore::TextureMapperGLData::SharedGLData::SharedGLData): +(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData): +(WebCore::TextureMapperGLData::sharedGLData): +(WebCore::TextureMapperGLData::TextureMapperGLData): +(WebCore::TextureMapperGLData::SharedGLData::initializeShaders): +(WebCore::TextureMapperGL::beginPainting): +(WebCore::TextureMapperGL::drawTexture): +(WebCore::BitmapTextureGL::bind): +(WebCore::TextureMapperGL::bindSurface): +(WebCore::TextureMapperGL::beginClip): +(WebCore::TextureMapperGL::endClip): +* platform/graphics/opengl/TextureMapperGL.h: + 2012-01-10 Simon Fraser simon.fra...@apple.com Disabled mock scrollbars should draw differently Modified: trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp (104650 => 104651) --- trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp 2012-01-11 00:39:01 UTC (rev 104650) +++ trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp 2012-01-11 00:42:11 UTC (rev 104651) @@ -41,6 +41,16 @@ #include GL/gl.h #endif
[webkit-changes] [104652] trunk
Title: [104652] trunk
Revision 104652
Author cmar...@apple.com
Date 2012-01-10 17:07:14 -0800 (Tue, 10 Jan 2012)
Log Message
CIFilter version of Sepia Tone filter doesn't match software
https://bugs.webkit.org/show_bug.cgi?id=75129
Reviewed by Simon Fraser.
Source/WebCore:
Changed sepia tone filter to use a CIColorMatrix filter with
values that match sw filter.
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(interp):
(PlatformCALayer::setFilters):
LayoutTests:
Updated sepia tone results for core image filters on CA layers to match changes. Updated sw results because
they had the wrong color space
* css3/filters/effect-sepia-expected.png:
* css3/filters/effect-sepia-hw-expected.png:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/filters/effect-sepia-expected.png
trunk/LayoutTests/css3/filters/effect-sepia-hw-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm
Diff
Modified: trunk/LayoutTests/ChangeLog (104651 => 104652)
--- trunk/LayoutTests/ChangeLog 2012-01-11 00:42:11 UTC (rev 104651)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 01:07:14 UTC (rev 104652)
@@ -1,3 +1,16 @@
+2012-01-10 Chris Marrin cmar...@apple.com
+
+CIFilter version of Sepia Tone filter doesn't match software
+https://bugs.webkit.org/show_bug.cgi?id=75129
+
+Reviewed by Simon Fraser.
+
+Updated sepia tone results for core image filters on CA layers to match changes. Updated sw results because
+they had the wrong color space
+
+* css3/filters/effect-sepia-expected.png:
+* css3/filters/effect-sepia-hw-expected.png:
+
2012-01-10 Tony Chang t...@chromium.org
Need to handle absolutely positioned elements inside flexboxes
Modified: trunk/LayoutTests/css3/filters/effect-sepia-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/css3/filters/effect-sepia-hw-expected.png
(Binary files differ)
Modified: trunk/Source/WebCore/ChangeLog (104651 => 104652)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 00:42:11 UTC (rev 104651)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 01:07:14 UTC (rev 104652)
@@ -1,3 +1,17 @@
+2012-01-10 Chris Marrin cmar...@apple.com
+
+CIFilter version of Sepia Tone filter doesn't match software
+https://bugs.webkit.org/show_bug.cgi?id=75129
+
+Reviewed by Simon Fraser.
+
+Changed sepia tone filter to use a CIColorMatrix filter with
+values that match sw filter.
+
+* platform/graphics/ca/mac/PlatformCALayerMac.mm:
+(interp):
+(PlatformCALayer::setFilters):
+
2012-01-10 Viatcheslav Ostapenko ostapenko.viatches...@nokia.com
[Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show() crash
Modified: trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm (104651 => 104652)
--- trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm 2012-01-11 00:42:11 UTC (rev 104651)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm 2012-01-11 01:07:14 UTC (rev 104652)
@@ -29,6 +29,7 @@
#import PlatformCALayer.h
+#import AnimationUtilities.h
#import BlockExceptions.h
#import FloatConversion.h
#import GraphicsContext.h
@@ -44,6 +45,9 @@
#define HAVE_MODERN_QUARTZCORE (!defined(BUILDING_ON_LEOPARD))
+using std::min;
+using std::max;
+
using namespace WebCore;
// This value must be the same as in PlatformCAAnimationMac.mm
@@ -746,9 +750,18 @@
}
case FilterOperation::SEPIA: {
const BasicColorMatrixFilterOperation* op = static_castconst BasicColorMatrixFilterOperation*(filterOperation);
-CIFilter* caFilter = [CIFilter filterWithName:@CISepiaTone];
+CIFilter* caFilter = [CIFilter filterWithName:@CIColorMatrix];
[caFilter setDefaults];
-[caFilter setValue:[NSNumber numberWithFloat:op-amount()] forKey:@inputIntensity];
+
+double t = op-amount();
+t = min(max(0.0, t), 1.0);
+
+// FIXME: Should put these values into constants (https://bugs.webkit.org/show_bug.cgi?id=76008)
+[caFilter setValue:[CIVector vectorWithX:WebCore::blend(1.0, 0.393, t) Y:WebCore::blend(0.0, 0.769, t) Z:WebCore::blend(0.0, 0.189, t) W:0] forKey:@inputRVector];
+[caFilter setValue:[CIVector vectorWithX:WebCore::blend(0.0, 0.349, t) Y:WebCore::blend(1.0, 0.686, t) Z:WebCore::blend(0.0, 0.168, t) W:0] forKey:@inputGVector];
+[caFilter setValue:[CIVector vectorWithX:WebCore::blend(0.0, 0.272, t) Y:WebCore::blend(0.0, 0.534, t) Z:WebCore::blend(1.0, 0.131, t) W:0] forKey:@inputBVector];
+[caFilter setValue:[CIVector vectorWithX:0 Y:0 Z:0 W:1] forKey:@inputAVector];
+[caFilter setValue:[CIVector vectorWithX:0 Y:0 Z:0 W:0] forKey:@inputBiasVector];
[caFilter setName:@sepiaFilter];
[array.get() addObject:caFilter];
break;
[webkit-changes] [104655] trunk
Title: [104655] trunk
Revision 104655
Author dch...@chromium.org
Date 2012-01-10 17:19:14 -0800 (Tue, 10 Jan 2012)
Log Message
[chromium] Pasteboard::documentFragment should fall back to text if there's no HTML text
https://bugs.webkit.org/show_bug.cgi?id=75923
Reviewed by Tony Chang.
Source/WebCore:
Test: editing/pasteboard/pasting-empty-html-falls-back-to-text.html
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
LayoutTests:
* editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt: Added.
* editing/pasteboard/pasting-empty-html-falls-back-to-text.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PasteboardChromium.cpp
Added Paths
trunk/LayoutTests/editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt
trunk/LayoutTests/editing/pasteboard/pasting-empty-html-falls-back-to-text.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104654 => 104655)
--- trunk/LayoutTests/ChangeLog 2012-01-11 01:12:22 UTC (rev 104654)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 01:19:14 UTC (rev 104655)
@@ -1,3 +1,13 @@
+2012-01-10 Daniel Cheng dch...@chromium.org
+
+[chromium] Pasteboard::documentFragment should fall back to text if there's no HTML text
+https://bugs.webkit.org/show_bug.cgi?id=75923
+
+Reviewed by Tony Chang.
+
+* editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt: Added.
+* editing/pasteboard/pasting-empty-html-falls-back-to-text.html: Added.
+
2012-01-10 Mike Lawther mikelawt...@chromium.org
padding test for CSS3 calc
Added: trunk/LayoutTests/editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt (0 => 104655)
--- trunk/LayoutTests/editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt 2012-01-11 01:19:14 UTC (rev 104655)
@@ -0,0 +1,5 @@
+This test requires DRT. It verifies that pasting in a richly editable area falls back to text if the HTML content is an empty string.
+
+
+
+PASS
Property changes on: trunk/LayoutTests/editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/editing/pasteboard/pasting-empty-html-falls-back-to-text.html (0 => 104655)
--- trunk/LayoutTests/editing/pasteboard/pasting-empty-html-falls-back-to-text.html (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/pasting-empty-html-falls-back-to-text.html 2012-01-11 01:19:14 UTC (rev 104655)
@@ -0,0 +1,30 @@
+html
+head
+script
+function handleCopy(event)
+{
+ event.clipboardData.setData('text/html', '');
+ event.clipboardData.setData('text/plain', '\nPASS');
+ event.preventDefault();
+}
+
+function runTest()
+{
+ if (!window.layoutTestController)
+return;
+ layoutTestController.dumpAsText();
+
+ document.body.addEventListener('copy', handleCopy);
+ document.execCommand('copy');
+ var selection = window.getSelection();
+ var range = document.createRange();
+ range.selectNode(document.getElementById('description'));
+ selection.addRange(range);
+ selection.collapseToEnd();
+ document.execCommand('paste');
+}
+/script
+body _onload_=runTest() contenteditable=true
+p id=descriptionThis test requires DRT. It verifies that pasting in a richly editable area falls back to text if the HTML content is an empty string.
+/body
+/html
Property changes on: trunk/LayoutTests/editing/pasteboard/pasting-empty-html-falls-back-to-text.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (104654 => 104655)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 01:12:22 UTC (rev 104654)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 01:19:14 UTC (rev 104655)
@@ -1,3 +1,15 @@
+2012-01-10 Daniel Cheng dch...@chromium.org
+
+[chromium] Pasteboard::documentFragment should fall back to text if there's no HTML text
+https://bugs.webkit.org/show_bug.cgi?id=75923
+
+Reviewed by Tony Chang.
+
+Test: editing/pasteboard/pasting-empty-html-falls-back-to-text.html
+
+* platform/chromium/PasteboardChromium.cpp:
+(WebCore::Pasteboard::documentFragment):
+
2012-01-10 Kentaro Hara hara...@chromium.org
Use the [Supplemental] IDL in SQLDatabase
Modified: trunk/Source/WebCore/platform/chromium/PasteboardChromium.cpp (104654 => 104655)
--- trunk/Source/WebCore/platform/chromium/PasteboardChromium.cpp 2012-01-11 01:12:22 UTC (rev 104654)
+++ trunk/Source/WebCore/platform/chromium/PasteboardChromium.cpp 2012-01-11 01:19:14 UTC (rev 104655)
@@ -182,10 +182,12 @@
unsigned fragmentEnd = 0;
PlatformSupport::clipboardReadHTML(buffer, markup, srcURL, fragmentStart,
[webkit-changes] [104656] trunk/Source
Title: [104656] trunk/Source
Revision 104656
Author cmar...@apple.com
Date 2012-01-10 17:19:34 -0800 (Tue, 10 Jan 2012)
Log Message
2012-01-10 Chris Marrin cmar...@apple.com
Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work
Unreviewed.
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (104655 => 104656)
--- trunk/Source/WebKit/mac/ChangeLog 2012-01-11 01:19:14 UTC (rev 104655)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-01-11 01:19:34 UTC (rev 104656)
@@ -1,5 +1,13 @@
2012-01-10 Chris Marrin cmar...@apple.com
+Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work
+
+Unreviewed.
+
+* WebCoreSupport/WebChromeClient.h:
+
+2012-01-10 Chris Marrin cmar...@apple.com
+
Turn off the FilterTrigger in WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=75914
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (104655 => 104656)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2012-01-11 01:19:14 UTC (rev 104655)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2012-01-11 01:19:34 UTC (rev 104656)
@@ -148,7 +148,6 @@
virtual void attachRootGraphicsLayer(WebCore::Frame*, WebCore::GraphicsLayer*) OVERRIDE;
virtual void setNeedsOneShotDrawingSynchronization() OVERRIDE;
virtual void scheduleCompositingLayerSync() OVERRIDE;
-#endif
virtual CompositingTriggerFlags allowedCompositingTriggers() const
{
@@ -159,6 +158,7 @@
CanvasTrigger |
AnimationTrigger);
}
+#endif
#if ENABLE(VIDEO)
virtual bool supportsFullscreenForNode(const WebCore::Node*) OVERRIDE;
Modified: trunk/Source/WebKit2/ChangeLog (104655 => 104656)
--- trunk/Source/WebKit2/ChangeLog 2012-01-11 01:19:14 UTC (rev 104655)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-11 01:19:34 UTC (rev 104656)
@@ -1,3 +1,11 @@
+2012-01-10 Chris Marrin cmar...@apple.com
+
+Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work
+
+Unreviewed.
+
+* WebProcess/WebCoreSupport/WebChromeClient.h:
+
2012-01-10 Viatcheslav Ostapenko ostapenko.viatches...@nokia.com
[Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show() crash
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h (104655 => 104656)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2012-01-11 01:19:14 UTC (rev 104655)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2012-01-11 01:19:34 UTC (rev 104656)
@@ -182,7 +182,6 @@
virtual void attachRootGraphicsLayer(WebCore::Frame*, WebCore::GraphicsLayer*) OVERRIDE;
virtual void setNeedsOneShotDrawingSynchronization() OVERRIDE;
virtual void scheduleCompositingLayerSync() OVERRIDE;
-#endif
virtual CompositingTriggerFlags allowedCompositingTriggers() const
{
@@ -193,6 +192,7 @@
CanvasTrigger |
AnimationTrigger);
}
+#endif
#if ENABLE(TOUCH_EVENTS)
virtual void needTouchEvents(bool) OVERRIDE;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104657] trunk/LayoutTests
Title: [104657] trunk/LayoutTests
Revision 104657
Author commit-qu...@webkit.org
Date 2012-01-10 17:35:50 -0800 (Tue, 10 Jan 2012)
Log Message
Unreviewed, rolling out r104543.
http://trac.webkit.org/changeset/104543
https://bugs.webkit.org/show_bug.cgi?id=76013
Asserts on Mac 10.6 dbg bots (Requested by dimich on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-01-10
* css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Removed.
* css3/calc/block-mask-overlay-image-outset.html: Removed.
* css3/calc/resources/mask.png: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html
trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset.html
trunk/LayoutTests/css3/calc/resources/mask.png
Diff
Modified: trunk/LayoutTests/ChangeLog (104656 => 104657)
--- trunk/LayoutTests/ChangeLog 2012-01-11 01:19:34 UTC (rev 104656)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 01:35:50 UTC (rev 104657)
@@ -1,3 +1,15 @@
+2012-01-10 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r104543.
+http://trac.webkit.org/changeset/104543
+https://bugs.webkit.org/show_bug.cgi?id=76013
+
+Asserts on Mac 10.6 dbg bots (Requested by dimich on #webkit).
+
+* css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Removed.
+* css3/calc/block-mask-overlay-image-outset.html: Removed.
+* css3/calc/resources/mask.png: Removed.
+
2012-01-10 Daniel Cheng dch...@chromium.org
[chromium] Pasteboard::documentFragment should fall back to text if there's no HTML text
Deleted: trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html (104656 => 104657)
--- trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html 2012-01-11 01:19:34 UTC (rev 104656)
+++ trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html 2012-01-11 01:35:50 UTC (rev 104657)
@@ -1,15 +0,0 @@
-DOCTYPE html
-style
-.blockTest {
-margin: 25px;
-padding: 50px;
-color: white;
-background-color: maroon;
--webkit-mask-box-image: url(resources/mask.png) 75 75 75 75 / auto / 100px 0;
-}
-/style
-body
-div class=blockTest style=height: 0px
-div style=height: 400px; background-color: greyThis content should be masked with a soft glow./div
-/div
-/body
Deleted: trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset.html (104656 => 104657)
--- trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset.html 2012-01-11 01:19:34 UTC (rev 104656)
+++ trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset.html 2012-01-11 01:35:50 UTC (rev 104657)
@@ -1,15 +0,0 @@
-DOCTYPE html
-style
-.blockTest {
-margin: 25px;
-padding: 50px;
-color: white;
-background-color: maroon;
--webkit-mask-box-image: url(resources/mask.png) 75 75 75 75 / auto / -webkit-calc(100px) 0;
-}
-/style
-body
-div class=blockTest style=height: 0px
-div style=height: 400px; background-color: greyThis content should be masked with a soft glow./div
-/div
-/body
Deleted: trunk/LayoutTests/css3/calc/resources/mask.png (104656 => 104657)
--- trunk/LayoutTests/css3/calc/resources/mask.png 2012-01-11 01:19:34 UTC (rev 104656)
+++ trunk/LayoutTests/css3/calc/resources/mask.png 2012-01-11 01:35:50 UTC (rev 104657)
@@ -1,64 +0,0 @@
-\x89PNG
-
-
-IHDR \xA5 \xA3 A{L KiCCPICC Profile x\x9C\x95Wy4\xD5\xDD\xD7\xDF\xDF{\xAF{\x8D\xD7O\xD7%\x99\xC7 W2\xCF\xE1\xBA\xE6\xB9{\xCD!\xF1\xA4\xCCC4Ȑ\xA9\x90)\x89
-IR\xC64H\xA2\x92T\xC8\x99\xC2}\xFF\xA0\x9Ew\xBD\xCF\xFA\xAD\xDFz\xF7 g}\xCE\xE7\xEC}\xF6\xE7\xECs\xD6:k\xB0 \x91BCQ F\xB19\xA0O8\xE4\xE4L\xC0\xBD40'\x80\x89D\xA6\x86\xEAYY\x99\xC1\xB4\xA5\x97\x80 \x97'\x85\x86\x9Bt \xC0\xE5,\xB9p̟ 6\xF8\xCFq \x80\xA7 rr@\xE4 \x80\xCBg \xEF .\x8F-l \\x91a\xA1a \x88/ p\x91}I\x9E H, \xC8Q\xECl \x90* \xC0\xFBl\xE1; \x80\xF7\xD8\xC2\xDD \x80\x8F \xFB\x84 \xAF\xB0 \xC1\x9E~\xC1 \xB8 \xAC\x8E\xA7\x95 \x80\x97 OO*9 \x9F
-\x80\xD2
-
-\xF1` \x80\x9D\xE4PJ \xDB
- H rrlIv\x8FPg\xA0k\xFD\x87 \xA1 Ի\xA5\xFC\xC3IM\xF0\xD4ԏ\xFF\xC3-\xD8 O?\xD5{\x9F \xCC\xFA t\xEFh\xB4) \.\xC0F\x8D\xF6\xAB\x8CF\xDB(@\xBFh $\x87S\xB6\xEB\x85 \xBD \xFFm\xBEu\xE6mC# ( ?x\x83\xB8!\xEB\xA8\xF4( \xFB\x9C\xFE9\x93 \xC3V\xC2)\xCA \xCC[\xCA_'\xAC+2A\xA0\x8A\xD1$b%I\x85KO\xC9\xD8\xCBv\xC8\xC9\xC8g\xEF^U\xF0\xD8\xFB|\x9F\xB1R\xBB\x8A\xAAj\xB1چ\x86\x83\xE6e\xADy e݈\xFDMzkچI\xC4N\xA3c\xF1\x83\xA6\xFE\xA6'\xCD
-\xCD\xEB-:-G\xAC\xE6m\x98le\xECl\xECc j G\x9D\x9D\x95;\xB9P\x8F$\xB8\x9EtKp\xA7\x92r=Z\xC9\x84\xBD\xED|N\xFBv\xF8\xAD\xEC \xF4\xCA
-\xAE 9\xEAsԐ\xB2\x8B*\xC6 \xCE \xC1)\xB53zO\x8C\xD21\xADX\x83\xB8\xF1F\xC7\xF5\xD4N\xC8
[webkit-changes] [104659] trunk/Source/WebCore
Title: [104659] trunk/Source/WebCore Revision 104659 Author hara...@chromium.org Date 2012-01-10 18:04:53 -0800 (Tue, 10 Jan 2012) Log Message Remove redundant code from DOMWindowSQLDatabase.cpp https://bugs.webkit.org/show_bug.cgi?id=76010 Reviewed by Adam Barth. This patch removes redundant code from DOMWindowSQLDatabase.cpp. - Remove window-frame() check, since window-frame() is always true when window-isCurrentlyDisplayedInFrame() is true. - window-frame()-document() can just be window-document() Tests: storage/open-database-creation-callback-isolated-world.html storage/open-database-creation-callback.html storage/open-database-empty-version.html storage/open-database-over-quota.html storage/open-database-set-empty-version.html storage/open-database-while-transaction-in-progress.html * storage/DOMWindowSQLDatabase.cpp: (WebCore::DOMWindowSQLDatabase::openDatabase): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/storage/DOMWindowSQLDatabase.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (104658 => 104659) --- trunk/Source/WebCore/ChangeLog 2012-01-11 01:51:19 UTC (rev 104658) +++ trunk/Source/WebCore/ChangeLog 2012-01-11 02:04:53 UTC (rev 104659) @@ -1,3 +1,26 @@ +2012-01-10 Kentaro Hara hara...@chromium.org + +Remove redundant code from DOMWindowSQLDatabase.cpp +https://bugs.webkit.org/show_bug.cgi?id=76010 + +Reviewed by Adam Barth. + +This patch removes redundant code from DOMWindowSQLDatabase.cpp. + +- Remove window-frame() check, since window-frame() is always true when + window-isCurrentlyDisplayedInFrame() is true. +- window-frame()-document() can just be window-document() + +Tests: storage/open-database-creation-callback-isolated-world.html + storage/open-database-creation-callback.html + storage/open-database-empty-version.html + storage/open-database-over-quota.html + storage/open-database-set-empty-version.html + storage/open-database-while-transaction-in-progress.html + +* storage/DOMWindowSQLDatabase.cpp: +(WebCore::DOMWindowSQLDatabase::openDatabase): + 2012-01-10 Dale Curtis dalecur...@chromium.org Repaint video controls when buffering during pause. Modified: trunk/Source/WebCore/storage/DOMWindowSQLDatabase.cpp (104658 => 104659) --- trunk/Source/WebCore/storage/DOMWindowSQLDatabase.cpp 2012-01-11 01:51:19 UTC (rev 104658) +++ trunk/Source/WebCore/storage/DOMWindowSQLDatabase.cpp 2012-01-11 02:04:53 UTC (rev 104659) @@ -49,8 +49,8 @@ return 0; RefPtrDatabase database = 0; -if (window-frame() AbstractDatabase::isAvailable() window-frame()-document()-securityOrigin()-canAccessDatabase()) -database = Database::openDatabase(window-frame()-document(), name, version, displayName, estimatedSize, creationCallback, ec); +if (AbstractDatabase::isAvailable() window-document()-securityOrigin()-canAccessDatabase()) +database = Database::openDatabase(window-document(), name, version, displayName, estimatedSize, creationCallback, ec); if (!database !ec) ec = SECURITY_ERR; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104664] trunk/Source/JavaScriptCore
Title: [104664] trunk/Source/_javascript_Core Revision 104664 Author mr...@apple.com Date 2012-01-10 20:50:30 -0800 (Tue, 10 Jan 2012) Log Message rdar://problem/10673792 jsc should install directly in to versioned Resources subfolder This ensures that jsc ends up in a consistent location whether built in to the same DSTROOT as _javascript_Core.framework or in to a different one. Rubber-stamped by Dan Bernstein. * Configurations/JSC.xcconfig: Update INSTALL_PATH. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/JSC.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (104663 => 104664) --- trunk/Source/_javascript_Core/ChangeLog 2012-01-11 04:50:17 UTC (rev 104663) +++ trunk/Source/_javascript_Core/ChangeLog 2012-01-11 04:50:30 UTC (rev 104664) @@ -1,3 +1,14 @@ +2012-01-10 Mark Rowe mr...@apple.com + +rdar://problem/10673792 jsc should install directly in to versioned Resources subfolder + +This ensures that jsc ends up in a consistent location whether built in to the same DSTROOT +as _javascript_Core.framework or in to a different one. + +Rubber-stamped by Dan Bernstein. + +* Configurations/JSC.xcconfig: Update INSTALL_PATH. + 2012-01-10 Filip Pizlo fpi...@apple.com DFG inlining block linking compares BlockIndex against bytecode index Modified: trunk/Source/_javascript_Core/Configurations/JSC.xcconfig (104663 => 104664) --- trunk/Source/_javascript_Core/Configurations/JSC.xcconfig 2012-01-11 04:50:17 UTC (rev 104663) +++ trunk/Source/_javascript_Core/Configurations/JSC.xcconfig 2012-01-11 04:50:30 UTC (rev 104664) @@ -21,7 +21,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR)/_javascript_Core.framework/Resources +INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR)/_javascript_Core.framework/Versions/A/Resources PRODUCT_NAME = jsc; CODE_SIGN_ENTITLEMENTS = $(CODE_SIGN_ENTITLEMENTS_$(REAL_PLATFORM_NAME)); CODE_SIGN_ENTITLEMENTS_iphoneos = entitlements.plist; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104663] trunk/Source/WebKit2
Title: [104663] trunk/Source/WebKit2
Revision 104663
Author mr...@apple.com
Date 2012-01-10 20:50:17 -0800 (Tue, 10 Jan 2012)
Log Message
REGRESSION (r104377): All pages print blank on Snow Leopard
http://webkit.org/b/75879 / rdar://problem/10674335
We need to explicitly load PDFKit.framework before using PDFDocument and friends.
On SnowLeopard the framework is not necessarily loaded by anything else before we
print, which would lead to us failing to allocate the PDFDocument that we use for
drawing the content from the web process.
Reviewed by Dan Bernstein.
* UIProcess/API/mac/WKPrintingView.mm:
(pdfKitFrameworkPath): Construct the path to the PDFKit framework.
(classFromPDFKit): Ensure that the PDFKit framework is loaded, and then retrieve the
given class from it.
(pdfAnnotationLinkClass): ASSERT that we found the class.
(pdfDocumentClass): Ditto.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (104662 => 104663)
--- trunk/Source/WebKit2/ChangeLog 2012-01-11 03:52:33 UTC (rev 104662)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-11 04:50:17 UTC (rev 104663)
@@ -1,3 +1,22 @@
+2012-01-10 Mark Rowe mr...@apple.com
+
+REGRESSION (r104377): All pages print blank on Snow Leopard
+http://webkit.org/b/75879 / rdar://problem/10674335
+
+We need to explicitly load PDFKit.framework before using PDFDocument and friends.
+On SnowLeopard the framework is not necessarily loaded by anything else before we
+print, which would lead to us failing to allocate the PDFDocument that we use for
+drawing the content from the web process.
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/mac/WKPrintingView.mm:
+(pdfKitFrameworkPath): Construct the path to the PDFKit framework.
+(classFromPDFKit): Ensure that the PDFKit framework is loaded, and then retrieve the
+given class from it.
+(pdfAnnotationLinkClass): ASSERT that we found the class.
+(pdfDocumentClass): Ditto.
+
2012-01-10 Chris Marrin cmar...@apple.com
Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm (104662 => 104663)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm 2012-01-11 03:52:33 UTC (rev 104662)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm 2012-01-11 04:50:17 UTC (rev 104663)
@@ -411,15 +411,30 @@
return 0; // Invalid page number.
}
+static NSString *pdfKitFrameworkPath()
+{
+NSString *systemLibraryPath = [NSSearchPathForDirectoriesInDomains(NSLibraryDirectory, NSSystemDomainMask, NO) objectAtIndex:0];
+return [systemLibraryPath stringByAppendingPathComponent:@Frameworks/Quartz.framework/Frameworks/PDFKit.framework];
+}
+
+static Class classFromPDFKit(NSString *className)
+{
+static NSBundle *pdfKitBundle = [NSBundle bundleWithPath:pdfKitFrameworkPath()];
+[pdfKitBundle load];
+return [pdfKitBundle classNamed:className];
+}
+
static Class pdfAnnotationLinkClass()
{
-static Class pdfAnnotationLinkClass = NSClassFromString(@PDFAnnotationLink);
+static Class pdfAnnotationLinkClass = classFromPDFKit(@PDFAnnotationLink);
+ASSERT(pdfAnnotationLinkClass);
return pdfAnnotationLinkClass;
}
static Class pdfDocumentClass()
{
-static Class pdfDocumentClass = NSClassFromString(@PDFDocument);
+static Class pdfDocumentClass = classFromPDFKit(@PDFDocument);
+ASSERT(pdfDocumentClass);
return pdfDocumentClass;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104666] tags/Safari-535.15.2/Source
Title: [104666] tags/Safari-535.15.2/Source Revision 104666 Author mr...@apple.com Date 2012-01-10 21:02:43 -0800 (Tue, 10 Jan 2012) Log Message Versioning. Modified Paths tags/Safari-535.15.2/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-535.15.2/Source/_javascript_Glue/Configurations/Version.xcconfig tags/Safari-535.15.2/Source/WebCore/Configurations/Version.xcconfig tags/Safari-535.15.2/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-535.15.2/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-535.15.2/Source/_javascript_Core/Configurations/Version.xcconfig (104665 => 104666) --- tags/Safari-535.15.2/Source/_javascript_Core/Configurations/Version.xcconfig 2012-01-11 04:51:30 UTC (rev 104665) +++ tags/Safari-535.15.2/Source/_javascript_Core/Configurations/Version.xcconfig 2012-01-11 05:02:43 UTC (rev 104666) @@ -23,7 +23,7 @@ MAJOR_VERSION = 535; MINOR_VERSION = 15; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-535.15.2/Source/_javascript_Glue/Configurations/Version.xcconfig (104665 => 104666) --- tags/Safari-535.15.2/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-01-11 04:51:30 UTC (rev 104665) +++ tags/Safari-535.15.2/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-01-11 05:02:43 UTC (rev 104666) @@ -23,7 +23,7 @@ MAJOR_VERSION = 535; MINOR_VERSION = 15; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-535.15.2/Source/WebCore/Configurations/Version.xcconfig (104665 => 104666) --- tags/Safari-535.15.2/Source/WebCore/Configurations/Version.xcconfig 2012-01-11 04:51:30 UTC (rev 104665) +++ tags/Safari-535.15.2/Source/WebCore/Configurations/Version.xcconfig 2012-01-11 05:02:43 UTC (rev 104666) @@ -23,7 +23,7 @@ MAJOR_VERSION = 535; MINOR_VERSION = 15; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-535.15.2/Source/WebKit/mac/Configurations/Version.xcconfig (104665 => 104666) --- tags/Safari-535.15.2/Source/WebKit/mac/Configurations/Version.xcconfig 2012-01-11 04:51:30 UTC (rev 104665) +++ tags/Safari-535.15.2/Source/WebKit/mac/Configurations/Version.xcconfig 2012-01-11 05:02:43 UTC (rev 104666) @@ -23,7 +23,7 @@ MAJOR_VERSION = 535; MINOR_VERSION = 15; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-535.15.2/Source/WebKit2/Configurations/Version.xcconfig (104665 => 104666) --- tags/Safari-535.15.2/Source/WebKit2/Configurations/Version.xcconfig 2012-01-11 04:51:30 UTC (rev 104665) +++ tags/Safari-535.15.2/Source/WebKit2/Configurations/Version.xcconfig 2012-01-11 05:02:43 UTC (rev 104666) @@ -23,7 +23,7 @@ MAJOR_VERSION = 535; MINOR_VERSION = 15; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104667] tags/Safari-535.15.2/Source/JavaScriptCore
Title: [104667] tags/Safari-535.15.2/Source/_javascript_Core Revision 104667 Author mr...@apple.com Date 2012-01-10 21:02:48 -0800 (Tue, 10 Jan 2012) Log Message Merge r104664. Modified Paths tags/Safari-535.15.2/Source/_javascript_Core/ChangeLog tags/Safari-535.15.2/Source/_javascript_Core/Configurations/JSC.xcconfig Diff Modified: tags/Safari-535.15.2/Source/_javascript_Core/ChangeLog (104666 => 104667) --- tags/Safari-535.15.2/Source/_javascript_Core/ChangeLog 2012-01-11 05:02:43 UTC (rev 104666) +++ tags/Safari-535.15.2/Source/_javascript_Core/ChangeLog 2012-01-11 05:02:48 UTC (rev 104667) @@ -1,3 +1,14 @@ +2012-01-10 Mark Rowe mr...@apple.com + +rdar://problem/10673792 jsc should install directly in to versioned Resources subfolder + +This ensures that jsc ends up in a consistent location whether built in to the same DSTROOT +as _javascript_Core.framework or in to a different one. + +Rubber-stamped by Dan Bernstein. + +* Configurations/JSC.xcconfig: Update INSTALL_PATH. + 2012-01-09 Mark Rowe mr...@apple.com _javascript_Core executable targets shouldn't explicitly depend on the _javascript_Core framework target Modified: tags/Safari-535.15.2/Source/_javascript_Core/Configurations/JSC.xcconfig (104666 => 104667) --- tags/Safari-535.15.2/Source/_javascript_Core/Configurations/JSC.xcconfig 2012-01-11 05:02:43 UTC (rev 104666) +++ tags/Safari-535.15.2/Source/_javascript_Core/Configurations/JSC.xcconfig 2012-01-11 05:02:48 UTC (rev 104667) @@ -21,7 +21,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR)/_javascript_Core.framework/Resources +INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR)/_javascript_Core.framework/Versions/A/Resources PRODUCT_NAME = jsc; CODE_SIGN_ENTITLEMENTS = $(CODE_SIGN_ENTITLEMENTS_$(REAL_PLATFORM_NAME)); CODE_SIGN_ENTITLEMENTS_iphoneos = entitlements.plist; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104669] trunk/Source/WebCore
Title: [104669] trunk/Source/WebCore
Revision 104669
Author jer.no...@apple.com
Date 2012-01-10 21:34:54 -0800 (Tue, 10 Jan 2012)
Log Message
Crash in HTMLMediaElement::shouldDisableSleep()
https://bugs.webkit.org/show_bug.cgi?id=76025
Reviewed by Dan Bernstein.
Check nullity of m_player before dereferencing.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::shouldDisableSleep):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104668 => 104669)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 05:03:23 UTC (rev 104668)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 05:34:54 UTC (rev 104669)
@@ -1,3 +1,15 @@
+2012-01-10 Jer Noble jer.no...@apple.com
+
+Crash in HTMLMediaElement::shouldDisableSleep()
+https://bugs.webkit.org/show_bug.cgi?id=76025
+
+Reviewed by Dan Bernstein.
+
+Check nullity of m_player before dereferencing.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::shouldDisableSleep):
+
2012-01-04 Kent Tamura tk...@chromium.org
A radio button not in a document should not join a radio button group
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (104668 => 104669)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-01-11 05:03:23 UTC (rev 104668)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-01-11 05:34:54 UTC (rev 104669)
@@ -3758,7 +3758,7 @@
bool HTMLMediaElement::shouldDisableSleep() const
{
-return !m_player-paused() hasVideo() hasAudio() !loop();
+return m_player !m_player-paused() hasVideo() hasAudio() !loop();
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104672] trunk/Websites/webkit.org
Title: [104672] trunk/Websites/webkit.org Revision 104672 Author morr...@google.com Date 2012-01-10 22:20:37 -0800 (Tue, 10 Jan 2012) Log Message [Website] i-Bench is no longer available. https://bugs.webkit.org/show_bug.cgi?id=76027 Reviewed by Ryosuke Niwa. Updated the availability information of i-Bench. * projects/performance/index.html: Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/projects/performance/index.html Diff Modified: trunk/Websites/webkit.org/ChangeLog (104671 => 104672) --- trunk/Websites/webkit.org/ChangeLog 2012-01-11 06:07:52 UTC (rev 104671) +++ trunk/Websites/webkit.org/ChangeLog 2012-01-11 06:20:37 UTC (rev 104672) @@ -1,3 +1,14 @@ +2012-01-10 Hajime Morrita morr...@chromium.org + +[Website] i-Bench is no longer available. +https://bugs.webkit.org/show_bug.cgi?id=76027 + +Reviewed by Ryosuke Niwa. + +Updated the availability information of i-Bench. + +* projects/performance/index.html: + 2011-12-07 Daniel Bates dba...@webkit.org ASSERT_UNREACHED() should be ASSERT_NOT_REACHED() on assertion-guidelines.html Modified: trunk/Websites/webkit.org/projects/performance/index.html (104671 => 104672) --- trunk/Websites/webkit.org/projects/performance/index.html 2012-01-11 06:07:52 UTC (rev 104671) +++ trunk/Websites/webkit.org/projects/performance/index.html 2012-01-11 06:20:37 UTC (rev 104672) @@ -22,12 +22,8 @@ pWe have a number of benchmarks that we use to measure performance./p ol -liThe i-Bench test suite is the most well-known cross-browser benchmark. -The HTML Load Speed and _javascript_ tests are the most important sub-tests in the suite. -No check-in can regress the benchmark scores for these tests. -As of this writing, you can get the i-Bench test suite from -a href="" page/a on the Lionbridge website. -After accepting the license agreement you'll be able to download the suite from an FTP site at pcmag.com./li +liThe i-Bench test suite was the most well-known cross-browser benchmark. We used to use this for testing the performance. +The suite was developed by Lionbridge, but unfortunately they no longer support it thus the suite isn't available now. We are looking for good alternatives. liOur internal page load test suite (called the PLT for short) must also not regress. The PLT contains pages that are representative of sites that are encountered in the real world. The harness itself is built into Safari and is accessible from the iDebug/i menu. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104673] trunk
Title: [104673] trunk
Revision 104673
Author rn...@webkit.org
Date 2012-01-10 22:57:57 -0800 (Tue, 10 Jan 2012)
Log Message
Unreviewed, rolling out r104263 and r104381.
http://trac.webkit.org/changeset/104263
http://trac.webkit.org/changeset/104381
https://bugs.webkit.org/show_bug.cgi?id=76029
Preparation to rollout r104210 (Requested by rniwa on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-01-10
Source/WebCore:
* dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::item):
* dom/DynamicNodeList.h:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent):
LayoutTests:
* fast/dom/node-list-length-after-removing-node-expected.txt: Removed.
* fast/dom/node-list-length-after-removing-node.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DynamicNodeList.cpp
trunk/Source/WebCore/dom/DynamicNodeList.h
Removed Paths
trunk/LayoutTests/fast/dom/node-list-length-after-removing-node-expected.txt
trunk/LayoutTests/fast/dom/node-list-length-after-removing-node.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104672 => 104673)
--- trunk/LayoutTests/ChangeLog 2012-01-11 06:20:37 UTC (rev 104672)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 06:57:57 UTC (rev 104673)
@@ -1,3 +1,16 @@
+2012-01-10 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r104263 and r104381.
+http://trac.webkit.org/changeset/104263
+http://trac.webkit.org/changeset/104381
+https://bugs.webkit.org/show_bug.cgi?id=76029
+
+Preparation to rollout r104210 (Requested by rniwa on
+#webkit).
+
+* fast/dom/node-list-length-after-removing-node-expected.txt: Removed.
+* fast/dom/node-list-length-after-removing-node.html: Removed.
+
2012-01-04 Kent Tamura tk...@chromium.org
A radio button not in a Document should not join a radio button group
Deleted: trunk/LayoutTests/fast/dom/node-list-length-after-removing-node-expected.txt (104672 => 104673)
--- trunk/LayoutTests/fast/dom/node-list-length-after-removing-node-expected.txt 2012-01-11 06:20:37 UTC (rev 104672)
+++ trunk/LayoutTests/fast/dom/node-list-length-after-removing-node-expected.txt 2012-01-11 06:57:57 UTC (rev 104673)
@@ -1,3 +0,0 @@
-This tests accessing an item in node list and then querying the length of the node list after removing the item. WebKit should not crash.
-
-PASS
Deleted: trunk/LayoutTests/fast/dom/node-list-length-after-removing-node.html (104672 => 104673)
--- trunk/LayoutTests/fast/dom/node-list-length-after-removing-node.html 2012-01-11 06:20:37 UTC (rev 104672)
+++ trunk/LayoutTests/fast/dom/node-list-length-after-removing-node.html 2012-01-11 06:57:57 UTC (rev 104673)
@@ -1,31 +0,0 @@
-!DOCTYPE html
-html
-body _onload_=runTest()
-pThis tests accessing an item in node list and then querying the length of the node list after removing the item.
-WebKit should not crash./p
-span/spanspan/span
-div id=result/div
-script
-
-var nodeList = document.getElementsByTagName('span');
-document.body.removeChild(nodeList[0]);
-
-if (window.layoutTestController)
-layoutTestController.dumpAsText();
-
-if (window.GCController)
- GCController.collect();
-else {
-for (var i = 0; i 1; ++i)
-new Object;
-}
-
-document.body.offsetLeft;
-
-function runTest() {
-document.getElementById('result').innerHTML = nodeList.length == 1 ? 'PASS' : 'FAIL';
-}
-
-/script
-/body
-/html
Modified: trunk/Source/WebCore/ChangeLog (104672 => 104673)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 06:20:37 UTC (rev 104672)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 06:57:57 UTC (rev 104673)
@@ -1,3 +1,23 @@
+2012-01-10 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r104263 and r104381.
+http://trac.webkit.org/changeset/104263
+http://trac.webkit.org/changeset/104381
+https://bugs.webkit.org/show_bug.cgi?id=76029
+
+Preparation to rollout r104210 (Requested by rniwa on
+#webkit).
+
+* dom/DynamicNodeList.cpp:
+(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
+(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
+(WebCore::DynamicSubtreeNodeList::length):
+(WebCore::DynamicSubtreeNodeList::item):
+* dom/DynamicNodeList.h:
+(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
+(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid):
+(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent):
+
2012-01-10 David Kilzer ddkil...@apple.com
[webkit-changes] [104674] trunk/Source/WebCore
Title: [104674] trunk/Source/WebCore
Revision 104674
Author rn...@webkit.org
Date 2012-01-10 23:03:04 -0800 (Tue, 10 Jan 2012)
Log Message
Revert r104210. It turned out that this patch makes improving the node list caches harder.
* dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
* dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicSubtreeNodeList::Caches::create):
(WebCore::DynamicSubtreeNodeList::Caches::reset):
* dom/DynamicNodeList.h:
* dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
* dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged):
(WebCore::Node::notifyLocalNodeListsLabelChanged):
(WebCore::Node::itemTypeAttributeChanged):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
* dom/NodeRareData.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::parseMappedAttribute):
* html/HTMLLabelElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Attr.cpp
trunk/Source/WebCore/dom/DynamicNodeList.cpp
trunk/Source/WebCore/dom/DynamicNodeList.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/NodeRareData.h
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/html/HTMLLabelElement.cpp
trunk/Source/WebCore/html/HTMLLabelElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104673 => 104674)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 06:57:57 UTC (rev 104673)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 07:03:04 UTC (rev 104674)
@@ -1,3 +1,36 @@
+2012-01-10 Ryosuke Niwa rn...@webkit.org
+
+Revert r104210. It turned out that this patch makes improving the node list caches harder.
+
+* dom/Attr.cpp:
+(WebCore::Attr::setValue):
+(WebCore::Attr::childrenChanged):
+* dom/DynamicNodeList.cpp:
+(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
+(WebCore::DynamicSubtreeNodeList::length):
+(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
+(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
+(WebCore::DynamicSubtreeNodeList::item):
+(WebCore::DynamicSubtreeNodeList::invalidateCache):
+(WebCore::DynamicSubtreeNodeList::Caches::create):
+(WebCore::DynamicSubtreeNodeList::Caches::reset):
+* dom/DynamicNodeList.h:
+* dom/Element.cpp:
+(WebCore::Element::updateAfterAttributeChanged):
+* dom/Node.cpp:
+(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
+(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged):
+(WebCore::Node::notifyLocalNodeListsLabelChanged):
+(WebCore::Node::itemTypeAttributeChanged):
+(WebCore::NodeListsNodeData::invalidateCaches):
+(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
+* dom/NodeRareData.h:
+* html/HTMLElement.cpp:
+(WebCore::HTMLElement::parseMappedAttribute):
+* html/HTMLLabelElement.cpp:
+(WebCore::HTMLLabelElement::parseMappedAttribute):
+* html/HTMLLabelElement.h:
+
2012-01-10 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r104263 and r104381.
Modified: trunk/Source/WebCore/dom/Attr.cpp (104673 => 104674)
--- trunk/Source/WebCore/dom/Attr.cpp 2012-01-11 06:57:57 UTC (rev 104673)
+++ trunk/Source/WebCore/dom/Attr.cpp 2012-01-11 07:03:04 UTC (rev 104674)
@@ -129,7 +129,7 @@
createTextChild();
m_ignoreChildrenChanged--;
-invalidateNodeListsCacheAfterAttributeChanged();
+invalidateNodeListsCacheAfterAttributeChanged(m_attribute-name());
}
void Attr::setValue(const AtomicString value, ExceptionCode)
@@ -174,7 +174,7 @@
Node::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta);
-invalidateNodeListsCacheAfterAttributeChanged();
+invalidateNodeListsCacheAfterAttributeChanged(m_attribute-name());
// FIXME: We should include entity references in the value
Modified: trunk/Source/WebCore/dom/DynamicNodeList.cpp (104673 => 104674)
--- trunk/Source/WebCore/dom/DynamicNodeList.cpp 2012-01-11 06:57:57 UTC (rev 104673)
+++ trunk/Source/WebCore/dom/DynamicNodeList.cpp 2012-01-11 07:03:04 UTC (rev 104674)
@@ -28,44 +28,9 @@
namespace WebCore {
-DynamicSubtreeNodeList::SubtreeCaches::SubtreeCaches()
-: m_cachedItem(0)
-, m_isLengthCacheValid(false)
-, m_isItemCacheValid(false)
-,
[webkit-changes] [104676] branches/chromium/963/Source/WebCore/inspector/front-end/ DebuggerPresentationModel.js
Title: [104676] branches/chromium/963/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Revision 104676
Author pfeld...@chromium.org
Date 2012-01-10 23:53:21 -0800 (Tue, 10 Jan 2012)
Log Message
Merge 104563 - Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
over same raw source code multiple times.
https://bugs.webkit.org/show_bug.cgi?id=75953
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
TBR=pfeld...@chromium.org
BUG=109730
Review URL: http://codereview.chromium.org/9187001
Modified Paths
branches/chromium/963/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Diff
Modified: branches/chromium/963/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (104675 => 104676)
--- branches/chromium/963/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-01-11 07:14:38 UTC (rev 104675)
+++ branches/chromium/963/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-01-11 07:53:21 UTC (rev 104676)
@@ -36,6 +36,7 @@
{
// FIXME: apply formatter from outside as a generic mapping.
this._formatter = new WebInspector.ScriptFormatter();
+this._rawSourceCodes = [];
this._rawSourceCodeForScriptId = {};
this._rawSourceCodeForURL = {};
this._rawSourceCodeForDocumentURL = {};
@@ -140,6 +141,7 @@
}
rawSourceCode = new WebInspector.RawSourceCode(script.scriptId, script, resource, this._formatter, this._formatSource);
+this._rawSourceCodes.push(rawSourceCode);
this._bindScriptToRawSourceCode(script, rawSourceCode);
if (isInlineScript)
@@ -176,10 +178,10 @@
uiSourceCodes: function()
{
var result = [];
-for (var id in this._rawSourceCodeForScriptId) {
-var uiSourceCodeList = this._rawSourceCodeForScriptId[id].sourceMapping.uiSourceCodeList();
-for (var i = 0; i uiSourceCodeList.length; ++i)
-result.push(uiSourceCodeList[i]);
+for (var i = 0; i this._rawSourceCodes.length; ++i) {
+var uiSourceCodeList = this._rawSourceCodes[i].sourceMapping.uiSourceCodeList();
+for (var j = 0; j uiSourceCodeList.length; ++j)
+result.push(uiSourceCodeList[j]);
}
return result;
},
@@ -331,8 +333,8 @@
this._formatSource = formatSource;
this._breakpointManager.reset();
-for (var id in this._rawSourceCodeForScriptId)
-this._rawSourceCodeForScriptId[id].setFormatted(this._formatSource);
+for (var i = 0; i this._rawSourceCodes.length; ++i)
+this._rawSourceCodes[i].setFormatted(this._formatSource);
},
/**
@@ -382,8 +384,8 @@
_consoleCleared: function()
{
-for (var id in this._rawSourceCodeForScriptId)
-this._rawSourceCodeForScriptId[id].messages = [];
+for (var i = 0; i this._rawSourceCodes.length; ++i)
+this._rawSourceCodes[i].messages = [];
this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.ConsoleMessagesCleared);
},
@@ -654,15 +656,16 @@
_debuggerReset: function()
{
-for (var id in this._rawSourceCodeForScriptId) {
-var rawSourceCode = this._rawSourceCodeForScriptId[id];
+for (var i = 0; i this._rawSourceCodes.length; ++i) {
+var rawSourceCode = this._rawSourceCodes[i];
if (rawSourceCode.sourceMapping) {
var uiSourceCodeList = rawSourceCode.sourceMapping.uiSourceCodeList();
-for (var i = 0; i uiSourceCodeList.length; ++i)
-this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.UISourceCodeRemoved, uiSourceCodeList[i]);
+for (var j = 0; j uiSourceCodeList.length; ++j)
+this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.UISourceCodeRemoved, uiSourceCodeList[j]);
}
rawSourceCode.removeAllListeners();
}
+this._rawSourceCodes = [];
this._rawSourceCodeForScriptId = {};
this._rawSourceCodeForURL = {};
this._rawSourceCodeForDocumentURL = {};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104539] trunk/PerformanceTests
Title: [104539] trunk/PerformanceTests
Revision 104539
Author loi...@chromium.org
Date 2012-01-10 01:08:06 -0800 (Tue, 10 Jan 2012)
Log Message
Unreviewed test fix after r103683.
* inspector/first-open-scripts.html:
* inspector/show-panel.html:
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/inspector/first-open-scripts.html
trunk/PerformanceTests/inspector/show-panel.html
Diff
Modified: trunk/PerformanceTests/ChangeLog (104538 => 104539)
--- trunk/PerformanceTests/ChangeLog 2012-01-10 05:42:38 UTC (rev 104538)
+++ trunk/PerformanceTests/ChangeLog 2012-01-10 09:08:06 UTC (rev 104539)
@@ -1,3 +1,10 @@
+2012-01-09 Ilya Tikhonovsky loi...@chromium.org
+
+Unreviewed test fix after r103683.
+
+* inspector/first-open-scripts.html:
+* inspector/show-panel.html:
+
2012-01-03 Adam Barth aba...@webkit.org
html-parser.html takes too long to run
Modified: trunk/PerformanceTests/inspector/first-open-scripts.html (104538 => 104539)
--- trunk/PerformanceTests/inspector/first-open-scripts.html 2012-01-10 05:42:38 UTC (rev 104538)
+++ trunk/PerformanceTests/inspector/first-open-scripts.html 2012-01-10 09:08:06 UTC (rev 104539)
@@ -7,11 +7,11 @@
function test()
{
WebInspector.showPanel(scripts);
-var files = WebInspector.panels.scripts._filesSelectElement;
+var files = WebInspector.panels.scripts._fileSelector._filesSelectElement;
for (var i = 0; i files.options.length; ++i) {
if (files.options[i].value.indexOf(inspector-test.js) !== -1) {
files.selectedIndex = i;
- WebInspector.panels.scripts._filesSelectChanged();
+ WebInspector.panels.scripts._fileSelector._filesSelectChanged();
break;
}
}
@@ -21,9 +21,9 @@
WebInspector.showPanel(audits);
var showPanelTimerCookie = timer.start(first-open-scripts);
WebInspector.showPanel(scripts);
-var count = WebInspector.panels.scripts._visibleView._textViewer._mainPanel._textChunks.length;
-WebInspector.panels.scripts._visibleView._textViewer._mainPanel._expandChunks(0, count);
-WebInspector.panels.scripts._visibleView._textViewer._mainPanel._paintScheduledLines();
+var count = WebInspector.panels.scripts.visibleView._textViewer._mainPanel._textChunks.length;
+WebInspector.panels.scripts.visibleView._textViewer._mainPanel._expandChunks(0, count);
+WebInspector.panels.scripts.visibleView._textViewer._mainPanel._paintScheduledLines();
timer.finish(showPanelTimerCookie);
timer.done(first-open);
}
Modified: trunk/PerformanceTests/inspector/show-panel.html (104538 => 104539)
--- trunk/PerformanceTests/inspector/show-panel.html 2012-01-10 05:42:38 UTC (rev 104538)
+++ trunk/PerformanceTests/inspector/show-panel.html 2012-01-10 09:08:06 UTC (rev 104539)
@@ -16,11 +16,11 @@
function test()
{
WebInspector.showPanel(scripts);
-var files = WebInspector.panels.scripts._filesSelectElement;
+var files = WebInspector.panels.scripts._fileSelector._filesSelectElement;
for (var i = 0; i files.options.length; ++i) {
if (files.options[i].value.indexOf(inspector-test.js) !== -1) {
files.selectedIndex = i;
- WebInspector.panels.scripts._filesSelectChanged();
+ WebInspector.panels.scripts._fileSelector._filesSelectChanged();
break;
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104540] trunk/Source/WebKit/chromium
Title: [104540] trunk/Source/WebKit/chromium
Revision 104540
Author rn...@webkit.org
Date 2012-01-10 01:08:57 -0800 (Tue, 10 Jan 2012)
Log Message
Roll Chromium DEPS from 116979 to 117006.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (104539 => 104540)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-10 09:08:06 UTC (rev 104539)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-10 09:08:57 UTC (rev 104540)
@@ -1,3 +1,9 @@
+2012-01-09 Ryosuke Niwa rn...@webkit.org
+
+Roll Chromium DEPS from 116979 to 117006.
+
+* DEPS:
+
2012-01-09 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r104507.
Modified: trunk/Source/WebKit/chromium/DEPS (104539 => 104540)
--- trunk/Source/WebKit/chromium/DEPS 2012-01-10 09:08:06 UTC (rev 104539)
+++ trunk/Source/WebKit/chromium/DEPS 2012-01-10 09:08:57 UTC (rev 104540)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '116979'
+ 'chromium_rev': '117006'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104541] trunk/Source/WebCore
Title: [104541] trunk/Source/WebCore
Revision 104541
Author pfeld...@chromium.org
Date 2012-01-10 01:58:33 -0800 (Tue, 10 Jan 2012)
Log Message
Web Inspector: introduce experimental setting that makes source files always editable
https://bugs.webkit.org/show_bug.cgi?id=75626
Patch by pfeld...@chomium.org pavel.feld...@gmail.com on 2012-01-10
Reviewed by Timothy Hatcher.
* English.lproj/localizedStrings.js:
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame):
(WebInspector._javascript_SourceFrame.prototype.setReadOnly):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.NavigatorScriptTreeElement.prototype.onselect):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.get statusBarItems):
(WebInspector.SourceFrame.prototype.setReadOnly):
* inspector/front-end/inspector.js:
(WebInspector.loaded):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/ResourceView.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
trunk/Source/WebCore/inspector/front-end/TextViewer.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (104540 => 104541)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 09:08:57 UTC (rev 104540)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 09:58:33 UTC (rev 104541)
@@ -1,3 +1,27 @@
+2012-01-10 pfeld...@chomium.org pavel.feld...@gmail.com
+
+Web Inspector: introduce experimental setting that makes source files always editable
+https://bugs.webkit.org/show_bug.cgi?id=75626
+
+Reviewed by Timothy Hatcher.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame):
+(WebInspector._javascript_SourceFrame.prototype.setReadOnly):
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkLogView):
+* inspector/front-end/ScriptsNavigator.js:
+(WebInspector.NavigatorScriptTreeElement.prototype.onselect):
+* inspector/front-end/Settings.js:
+(WebInspector.ExperimentsSettings):
+* inspector/front-end/SourceFrame.js:
+(WebInspector.SourceFrame):
+(WebInspector.SourceFrame.prototype.get statusBarItems):
+(WebInspector.SourceFrame.prototype.setReadOnly):
+* inspector/front-end/inspector.js:
+(WebInspector.loaded):
+
2012-01-09 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r104507.
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (104540 => 104541)
--- trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2012-01-10 09:08:57 UTC (rev 104540)
+++ trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2012-01-10 09:58:33 UTC (rev 104541)
@@ -37,13 +37,14 @@
*/
WebInspector._javascript_SourceFrame = function(scriptsPanel, model, uiSourceCode)
{
-WebInspector.SourceFrame.call(this, uiSourceCode.url);
-
this._scriptsPanel = scriptsPanel;
this._model = model;
this._uiSourceCode = uiSourceCode;
this._popoverObjectGroup = popover;
this._breakpoints = {};
+
+WebInspector.SourceFrame.call(this, uiSourceCode.url);
+
this._popoverHelper = new WebInspector.ObjectPopoverHelper(this.textViewer.element,
this._getPopoverAnchor.bind(this), this._onShowPopover.bind(this), this._onHidePopover.bind(this), true);
@@ -95,7 +96,7 @@
setReadOnly: function(readOnly)
{
-if (!readOnly)
+if (this._popoverHelper !readOnly)
this._popoverHelper.hidePopover();
WebInspector.SourceFrame.prototype.setReadOnly.call(this, readOnly);
if (readOnly)
@@ -202,10 +203,13 @@
cancelEditing: function()
{
+if (WebInspector.experimentsSettings.sourceFrameAlwaysEditable.isEnabled())
+return false;
+
WebInspector.SourceFrame.prototype.cancelEditing.call(this);
if (!this._javaScriptSourceFrameState)
-return;
+return true;
if (typeof this._javaScriptSourceFrameState.executionLineNumber === number) {
this.clearExecutionLine();
@@ -225,6 +229,7 @@
}
delete this._javaScriptSourceFrameState;
+return true;
},
didEditContent: function(error)
Modified: trunk/Source/WebCore/inspector/front-end/ResourceView.js (104540 => 104541)
--- trunk/Source/WebCore/inspector/front-end/ResourceView.js 2012-01-10 09:08:57 UTC (rev 104540)
+++
[webkit-changes] [104542] trunk
Title: [104542] trunk
Revision 104542
Author ba...@chromium.org
Date 2012-01-10 02:13:02 -0800 (Tue, 10 Jan 2012)
Log Message
WebFonts are re-fetched from the server upon Document::styleSelectorChanged call.
https://bugs.webkit.org/show_bug.cgi?id=73419
Source/WebCore:
Holds the CachedFont handle in CSSFontFaceSrcValue so that avoiding re-validation during style recalculation.
Reviewed by Dan Bernstein.
Test: http/tests/css/font-face-src-loading.html
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont): Added.
* css/CSSFontFaceSrcValue.h:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Gets the CachedFont from CSSFontFaceSrcValue object. The object will request the resource if it doesn't exist.
LayoutTests:
Reviewed by Dan Bernstein.
Adds a test that ensures re-fetching WebFonts doesn't occur after style recalculation.
* http/tests/css/font-face-src-loading-expected.txt: Added.
* http/tests/css/font-face-src-loading.html: Added.
* http/tests/css/resources/webfont-request.php: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceSrcValue.cpp
trunk/Source/WebCore/css/CSSFontFaceSrcValue.h
trunk/Source/WebCore/css/CSSFontSelector.cpp
Added Paths
trunk/LayoutTests/http/tests/css/font-face-src-loading-expected.txt
trunk/LayoutTests/http/tests/css/font-face-src-loading.html
trunk/LayoutTests/http/tests/css/resources/webfont-request.php
Diff
Modified: trunk/LayoutTests/ChangeLog (104541 => 104542)
--- trunk/LayoutTests/ChangeLog 2012-01-10 09:58:33 UTC (rev 104541)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 10:13:02 UTC (rev 104542)
@@ -1,3 +1,16 @@
+2012-01-10 Kenichi Ishibashi ba...@chromium.org
+
+WebFonts are re-fetched from the server upon Document::styleSelectorChanged call.
+https://bugs.webkit.org/show_bug.cgi?id=73419
+
+Reviewed by Dan Bernstein.
+
+Adds a test that ensures re-fetching WebFonts doesn't occur after style recalculation.
+
+* http/tests/css/font-face-src-loading-expected.txt: Added.
+* http/tests/css/font-face-src-loading.html: Added.
+* http/tests/css/resources/webfont-request.php: Added.
+
2012-01-09 Dmitry Titov dim...@chromium.org
[Chromium] Unreviewed rebaseline, fixing incorrect rebaseline from r104489.
Added: trunk/LayoutTests/http/tests/css/font-face-src-loading-expected.txt (0 => 104542)
--- trunk/LayoutTests/http/tests/css/font-face-src-loading-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/css/font-face-src-loading-expected.txt 2012-01-10 10:13:02 UTC (rev 104542)
@@ -0,0 +1,5 @@
+This test ensures that webfonts are not re-fetched after style recalculation.
+
+Text
+Number of requests after recalculation: 0
+SUCCESS
Added: trunk/LayoutTests/http/tests/css/font-face-src-loading.html (0 => 104542)
--- trunk/LayoutTests/http/tests/css/font-face-src-loading.html (rev 0)
+++ trunk/LayoutTests/http/tests/css/font-face-src-loading.html 2012-01-10 10:13:02 UTC (rev 104542)
@@ -0,0 +1,68 @@
+head
+style
+@font-face {
+font-family: 'webfont';
+src: url(http://localhost:8000/css/resources/webfont-request.php?mode=getFontfilename=webfontRequestCount.txt) format('truetype');
+}
+/style
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+var filename = 'filename=webfontRequestCount.txt';
+var xhr;
+
+function startTest() {
+// Resets request count before starting the test.
+xhr = new XMLHttpRequest;
+xhr._onerror_ = function() {
+document.getElementById('result').innerText = 'FAIL: Network error.';
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+};
+xhr._onreadystatechange_ = function() {
+if (xhr.readyState == xhr.DONE)
+forceStyleSelectorRecreation();
+};
+xhr.open('GET', '/resources/reset-temp-file.php?' + filename, true);
+xhr.send();
+}
+
+function forceStyleSelectorRecreation() {
+document.head.appendChild(document.createElement(style));
+// Pauses for a moment to see whether font re-fetching occurs.
+setTimeout(getRequestCount, 100);
+}
+
+function getRequestCount() {
+xhr._onreadystatechange_ = function() {
+if (xhr.readyState == xhr.DONE)
+checkRequestCount();
+};
+xhr.open('GET', 'http://localhost:8000/css/resources/webfont-request.php?mode=getRequestCount' + filename, true);
+xhr.send();
+}
+
+function checkRequestCount() {
+var numRequest = xhr.responseText;
+var result = document.getElementById('result');
+result.innerHTML = 'Number of requests after recalculation: ' + numRequest + 'br /';
+if (numRequest == '0')
+result.innerHTML += 'SUCCESS';
+else
+result.innerHTML += 'FAIL';
+if (window.layoutTestController)
+
[webkit-changes] [104543] trunk/LayoutTests
Title: [104543] trunk/LayoutTests
Revision 104543
Author mikelawt...@chromium.org
Date 2012-01-10 02:21:29 -0800 (Tue, 10 Jan 2012)
Log Message
block mask overlay test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75896
Reviewed by Ryosuke Niwa.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
* css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Added.
* css3/calc/block-mask-overlay-image-outset.html: Added.
* css3/calc/resources/mask.png: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html
trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset.html
trunk/LayoutTests/css3/calc/resources/mask.png
Diff
Modified: trunk/LayoutTests/ChangeLog (104542 => 104543)
--- trunk/LayoutTests/ChangeLog 2012-01-10 10:13:02 UTC (rev 104542)
+++ trunk/LayoutTests/ChangeLog 2012-01-10 10:21:29 UTC (rev 104543)
@@ -1,3 +1,19 @@
+2012-01-10 Mike Lawther mikelawt...@chromium.org
+
+block mask overlay test for CSS3 calc
+https://bugs.webkit.org/show_bug.cgi?id=75896
+
+Reviewed by Ryosuke Niwa.
+
+Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
+
+These tests are expected to 'fail', and will pass once calc() functionality is landed.
+For now, they serve to demonstrate that the current code doesn't crash on these tests.
+
+* css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Added.
+* css3/calc/block-mask-overlay-image-outset.html: Added.
+* css3/calc/resources/mask.png: Added.
+
2012-01-10 Kenichi Ishibashi ba...@chromium.org
WebFonts are re-fetched from the server upon Document::styleSelectorChanged call.
Added: trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html (0 => 104543)
--- trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html (rev 0)
+++ trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html 2012-01-10 10:21:29 UTC (rev 104543)
@@ -0,0 +1,15 @@
+DOCTYPE html
+style
+.blockTest {
+margin: 25px;
+padding: 50px;
+color: white;
+background-color: maroon;
+-webkit-mask-box-image: url(resources/mask.png) 75 75 75 75 / auto / 100px 0;
+}
+/style
+body
+div class=blockTest style=height: 0px
+div style=height: 400px; background-color: greyThis content should be masked with a soft glow./div
+/div
+/body
Added: trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset.html (0 => 104543)
--- trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset.html (rev 0)
+++ trunk/LayoutTests/css3/calc/block-mask-overlay-image-outset.html 2012-01-10 10:21:29 UTC (rev 104543)
@@ -0,0 +1,15 @@
+DOCTYPE html
+style
+.blockTest {
+margin: 25px;
+padding: 50px;
+color: white;
+background-color: maroon;
+-webkit-mask-box-image: url(resources/mask.png) 75 75 75 75 / auto / -webkit-calc(100px) 0;
+}
+/style
+body
+div class=blockTest style=height: 0px
+div style=height: 400px; background-color: greyThis content should be masked with a soft glow./div
+/div
+/body
Added: trunk/LayoutTests/css3/calc/resources/mask.png (0 => 104543)
--- trunk/LayoutTests/css3/calc/resources/mask.png (rev 0)
+++ trunk/LayoutTests/css3/calc/resources/mask.png 2012-01-10 10:21:29 UTC (rev 104543)
@@ -0,0 +1,64 @@
+\x89PNG
+
+
+IHDR \xA5 \xA3 A{L KiCCPICC Profile x\x9C\x95Wy4\xD5\xDD\xD7\xDF\xDF{\xAF{\x8D\xD7O\xD7%\x99\xC7 W2\xCF\xE1\xBA\xE6\xB9{\xCD!\xF1\xA4\xCCC4Ȑ\xA9\x90)\x89
+IR\xC64H\xA2\x92T\xC8\x99\xC2}\xFF\xA0\x9Ew\xBD\xCF\xFA\xAD\xDFz\xF7 g}\xCE\xE7\xEC}\xF6\xE7\xECs\xD6:k\xB0 \x91BCQ F\xB19\xA0O8\xE4\xE4L\xC0\xBD40'\x80\x89D\xA6\x86\xEAYY\x99\xC1\xB4\xA5\x97\x80 \x97'\x85\x86\x9Bt \xC0\xE5,\xB9p̟ 6\xF8\xCFq \x80\xA7 rr@\xE4 \x80\xCBg \xEF .\x8F-l \\x91a\xA1a \x88/ p\x91}I\x9E H, \xC8Q\xECl \x90* \xC0\xFBl\xE1; \x80\xF7\xD8\xC2\xDD \x80\x8F \xFB\x84 \xAF\xB0 \xC1\x9E~\xC1 \xB8 \xAC\x8E\xA7\x95 \x80\x97 OO*9 \x9F
+\x80\xD2
+
+\xF1` \x80\x9D\xE4PJ \xDB
+ H rrlIv\x8FPg\xA0k\xFD\x87 \xA1 Ի\xA5\xFC\xC3IM\xF0\xD4ԏ\xFF\xC3-\xD8 O?\xD5{\x9F \xCC\xFA t\xEFh\xB4) \.\xC0F\x8D\xF6\xAB\x8CF\xDB(@\xBFh $\x87S\xB6\xEB\x85 \xBD \xFFm\xBEu\xE6mC# ( ?x\x83\xB8!\xEB\xA8\xF4( \xFB\x9C\xFE9\x93 \xC3V\xC2)\xCA \xCC[\xCA_'\xAC+2A\xA0\x8A\xD1$b%I\x85KO\xC9\xD8\xCBv\xC8\xC9\xC8g\xEF^U\xF0\xD8\xFB|\x9F\xB1R\xBB\x8A\xAAj\xB1چ\x86\x83\xE6e\xADy e݈\xFDMzkچI\xC4N\xA3c\xF1\x83\xA6\xFE\xA6'\xCD
+\xCD\xEB-:-G\xAC\xE6m\x98le\xECl\xECc j
[webkit-changes] [104545] trunk
Title: [104545] trunk Revision 104545 Author ba...@chromium.org Date 2012-01-10 02:46:31 -0800 (Tue, 10 Jan 2012) Log Message Complex path should be used when UVS exists in text run https://bugs.webkit.org/show_bug.cgi?id=75289 Source/WebCore: Uses complex path when a text run contains UVS. The range from U+180B to U+180D already uses complex path. Removes unnecessary functions that were added by r102915. Reviewed by Dan Bernstein. No new tests. fast/text/unicode-variation-selector.html should take care of this change. * platform/graphics/Font.cpp: (WebCore::Font::codePath): Use Complex path when the text run contains UVS. * platform/graphics/SimpleFontData.h: Removed updateGlyphWithVariationSelector(). * platform/graphics/SurrogatePairAwareTextIterator.cpp: Removed unnecessary static functions. * platform/graphics/SurrogatePairAwareTextIterator.h: Removed hasTrailingVariationSelector(). * platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance): Removed UVS detection code. * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Removed updateGlyphWithVariationSelector(). * platform/graphics/freetype/SimpleFontDataFreeType.cpp: Ditto. * platform/graphics/harfbuzz/SimpleFontDataSkia.cpp: Ditto. * platform/graphics/mac/SimpleFontDataMac.mm: Ditto. * platform/graphics/pango/SimpleFontDataPango.cpp: Ditto. * platform/graphics/qt/SimpleFontDataQt.cpp: Ditto. * platform/graphics/win/SimpleFontDataWin.cpp: Ditto. * platform/graphics/wince/SimpleFontDataWinCE.cpp: Ditto. * platform/graphics/wx/SimpleFontDataWx.cpp: Ditto. LayoutTests: Reviewed by Dan Bernstein. * platform/chromium/test_expectations.txt: Updates expectation for fast/text/unicode-variation-selector.html. Need rebaselines. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/Font.cpp trunk/Source/WebCore/platform/graphics/SimpleFontData.h trunk/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp trunk/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h trunk/Source/WebCore/platform/graphics/WidthIterator.cpp trunk/Source/WebCore/platform/graphics/chromium/SimpleFontDataChromiumWin.cpp trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp trunk/Source/WebCore/platform/graphics/harfbuzz/SimpleFontDataSkia.cpp trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm trunk/Source/WebCore/platform/graphics/pango/SimpleFontDataPango.cpp trunk/Source/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp trunk/Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp trunk/Source/WebCore/platform/graphics/wince/SimpleFontDataWinCE.cpp trunk/Source/WebCore/platform/graphics/wx/SimpleFontDataWx.cpp Diff Modified: trunk/LayoutTests/ChangeLog (104544 => 104545) --- trunk/LayoutTests/ChangeLog 2012-01-10 10:34:46 UTC (rev 104544) +++ trunk/LayoutTests/ChangeLog 2012-01-10 10:46:31 UTC (rev 104545) @@ -1,3 +1,12 @@ +2012-01-10 Kenichi Ishibashi ba...@chromium.org + +Complex path should be used when UVS exists in text run +https://bugs.webkit.org/show_bug.cgi?id=75289 + +Reviewed by Dan Bernstein. + +* platform/chromium/test_expectations.txt: Updates expectation for fast/text/unicode-variation-selector.html. Need rebaselines. + 2012-01-10 Mike Lawther mikelawt...@chromium.org block mask overlay test for CSS3 calc Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104544 => 104545) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 10:34:46 UTC (rev 104544) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 10:46:31 UTC (rev 104545) @@ -3774,7 +3774,7 @@ // The test hits an ASSERT in Debug. BUGWK68859 DEBUG : fast/dynamic/crash-paint-no-documentElement-renderer.html = CRASH -BUGWK74662 MAC : fast/text/unicode-variation-selector.html = PASS CRASH +BUGWK74662 : fast/text/unicode-variation-selector.html = IMAGE+TEXT BUGWK74634 WIN : compositing/absolute-position-changed-with-composited-parent-layer.html = IMAGE Modified: trunk/Source/WebCore/ChangeLog (104544 => 104545) --- trunk/Source/WebCore/ChangeLog 2012-01-10 10:34:46 UTC (rev 104544) +++ trunk/Source/WebCore/ChangeLog 2012-01-10 10:46:31 UTC (rev 104545) @@ -1,5 +1,34 @@ 2012-01-10 Kenichi Ishibashi ba...@chromium.org +Complex path should be used when UVS exists in text run +https://bugs.webkit.org/show_bug.cgi?id=75289 + +Uses complex path when a text run contains UVS. The range from U+180B to U+180D already uses complex path. +Removes unnecessary functions that were added by r102915. + +Reviewed by Dan Bernstein. + +No new tests. fast/text/unicode-variation-selector.html should take care of this change. + +* platform/graphics/Font.cpp: +(WebCore::Font::codePath): Use Complex path when the text run contains
[webkit-changes] [104546] trunk/Tools
Title: [104546] trunk/Tools
Revision 104546
Author zeno.albis...@nokia.com
Date 2012-01-10 03:06:52 -0800 (Tue, 10 Jan 2012)
Log Message
[Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=75885
In QML events are propagated through parents. But since the
WebView may consume key events, a shortcut might never reach
the top QtQuickItem.
Therefore an application wide event handling function in C++
needs to take care of shortcuts for MiniBrowser.
Reviewed by Kenneth Rohde Christiansen.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::reload):
(BrowserWindow::focusAddressBar):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
* MiniBrowser/qt/qml/BrowserWindow.qml:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp
trunk/Tools/MiniBrowser/qt/BrowserWindow.h
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp
trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml
Diff
Modified: trunk/Tools/ChangeLog (104545 => 104546)
--- trunk/Tools/ChangeLog 2012-01-10 10:46:31 UTC (rev 104545)
+++ trunk/Tools/ChangeLog 2012-01-10 11:06:52 UTC (rev 104546)
@@ -1,3 +1,24 @@
+2012-01-10 Zeno Albisser z...@webkit.org
+
+[Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
+https://bugs.webkit.org/show_bug.cgi?id=75885
+
+In QML events are propagated through parents. But since the
+WebView may consume key events, a shortcut might never reach
+the top QtQuickItem.
+Therefore an application wide event handling function in C++
+needs to take care of shortcuts for MiniBrowser.
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* MiniBrowser/qt/BrowserWindow.cpp:
+(BrowserWindow::reload):
+(BrowserWindow::focusAddressBar):
+* MiniBrowser/qt/BrowserWindow.h:
+* MiniBrowser/qt/MiniBrowserApplication.cpp:
+(MiniBrowserApplication::notify):
+* MiniBrowser/qt/qml/BrowserWindow.qml:
+
2012-01-10 Gyuyoung Kim gyuyoung@samsung.com
Add --efl alias for --platform=efl to run-webkit-test
Modified: trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp (104545 => 104546)
--- trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp 2012-01-10 10:46:31 UTC (rev 104545)
+++ trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp 2012-01-10 11:06:52 UTC (rev 104546)
@@ -76,6 +76,16 @@
QMetaObject::invokeMethod(rootObject(), load, Qt::DirectConnection, Q_ARG(QVariant, completedUrl));
}
+void BrowserWindow::reload()
+{
+QMetaObject::invokeMethod(rootObject(), reload, Qt::DirectConnection);
+}
+
+void BrowserWindow::focusAddressBar()
+{
+QMetaObject::invokeMethod(rootObject(), focusAddressBar, Qt::DirectConnection);
+}
+
BrowserWindow* BrowserWindow::newWindow(const QString url)
{
BrowserWindow* window = new BrowserWindow();
Modified: trunk/Tools/MiniBrowser/qt/BrowserWindow.h (104545 => 104546)
--- trunk/Tools/MiniBrowser/qt/BrowserWindow.h 2012-01-10 10:46:31 UTC (rev 104545)
+++ trunk/Tools/MiniBrowser/qt/BrowserWindow.h 2012-01-10 11:06:52 UTC (rev 104546)
@@ -42,6 +42,8 @@
BrowserWindow(WindowOptions* = 0);
~BrowserWindow();
void load(const QString url);
+void reload();
+void focusAddressBar();
QQuickWebView* webView() const;
void updateVisualMockTouchPoints(const QListQWindowSystemInterface::TouchPoint touchPoints);
Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp (104545 => 104546)
--- trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2012-01-10 10:46:31 UTC (rev 104545)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2012-01-10 11:06:52 UTC (rev 104546)
@@ -97,6 +97,21 @@
if (!browserWindow)
return QApplication::notify(target, event);
+// In QML events are propagated through parents. But since the WebView
+// may consume key events, a shortcut might never reach the top QQuickItem.
+// Therefore we are checking here for shortcuts.
+if (event-type() == QEvent::KeyPress) {
+QKeyEvent* keyEvent = static_castQKeyEvent*(event);
+if ((keyEvent-key() == Qt::Key_R keyEvent-modifiers() == Qt::ControlModifier) || keyEvent-key() == Qt::Key_F5) {
+browserWindow-reload();
+return true;
+}
+if ((keyEvent-key() == Qt::Key_L keyEvent-modifiers() == Qt::ControlModifier) || keyEvent-key() == Qt::Key_F6) {
+browserWindow-focusAddressBar();
+return true;
+}
+}
+
if (event-type() == QEvent::KeyRelease static_castQKeyEvent*(event)-key() == Qt::Key_Control) {
foreach (int id, m_heldTouchPoints)
if (m_touchPoints.contains(id))
Modified: trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml (104545 => 104546)
--- trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml 2012-01-10 10:46:31 UTC (rev 104545)
+++ trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml 2012-01-10 11:06:52 UTC (rev
[webkit-changes] [104548] trunk/Tools
Title: [104548] trunk/Tools Revision 104548 Author o...@webkit.org Date 2012-01-10 03:30:21 -0800 (Tue, 10 Jan 2012) Log Message [Qt] REGRESSION(r100130): Clean build feature is broken. https://bugs.webkit.org/show_bug.cgi?id=75863 Reviewed by Tor Arne Vestbø. * Scripts/webkitdirs.pm: (buildQMakeProject): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitdirs.pm Diff Modified: trunk/Tools/ChangeLog (104547 => 104548) --- trunk/Tools/ChangeLog 2012-01-10 11:20:15 UTC (rev 104547) +++ trunk/Tools/ChangeLog 2012-01-10 11:30:21 UTC (rev 104548) @@ -1,3 +1,13 @@ +2012-01-10 Csaba Osztrogonác o...@webkit.org + +[Qt] REGRESSION(r100130): Clean build feature is broken. +https://bugs.webkit.org/show_bug.cgi?id=75863 + +Reviewed by Tor Arne Vestbø. + +* Scripts/webkitdirs.pm: +(buildQMakeProject): + 2012-01-10 Zeno Albisser z...@webkit.org [Qt][WK2] Fix keyboard shortcuts in MiniBrowser. Modified: trunk/Tools/Scripts/webkitdirs.pm (104547 => 104548) --- trunk/Tools/Scripts/webkitdirs.pm 2012-01-10 11:20:15 UTC (rev 104547) +++ trunk/Tools/Scripts/webkitdirs.pm 2012-01-10 11:30:21 UTC (rev 104548) @@ -2111,6 +2111,10 @@ File::Path::rmtree($dir); File::Path::mkpath($dir); chdir $dir or die Failed to cd into . $dir . \n; + +# After removing WebKitBuild directory, we have to call qtFeatureDefaults() +# to run config tests and generate the removed Tools/qmake/.qmake.cache again. +qtFeatureDefaults(\@buildArgs); #} } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104549] trunk/Source/WebKit2
Title: [104549] trunk/Source/WebKit2
Revision 104549
Author commit-qu...@webkit.org
Date 2012-01-10 03:33:37 -0800 (Tue, 10 Jan 2012)
Log Message
[EFL][WK2] Remove codes to move and resize the clip.
https://bugs.webkit.org/show_bug.cgi?id=75428
Patch by Eunmi Lee eunmi15@samsung.com on 2012-01-10
Reviewed by Andreas Kling.
Remove codes to move and resize the clip because clip is not used now.
We have to show whole area of evas_object_image so we don't have to
clip any area.
In the WebKit1 Efl, the clip is used to clip the area to show during
weak zoom, so we can use codes to manipulate the clip when we want to
implement weak zoom for WebKit2 Efl.
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (104548 => 104549)
--- trunk/Source/WebKit2/ChangeLog 2012-01-10 11:30:21 UTC (rev 104548)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-10 11:33:37 UTC (rev 104549)
@@ -1,3 +1,20 @@
+2012-01-10 Eunmi Lee eunmi15@samsung.com
+
+[EFL][WK2] Remove codes to move and resize the clip.
+https://bugs.webkit.org/show_bug.cgi?id=75428
+
+Reviewed by Andreas Kling.
+
+Remove codes to move and resize the clip because clip is not used now.
+We have to show whole area of evas_object_image so we don't have to
+clip any area.
+In the WebKit1 Efl, the clip is used to clip the area to show during
+weak zoom, so we can use codes to manipulate the clip when we want to
+implement weak zoom for WebKit2 Efl.
+
+* UIProcess/API/efl/ewk_view.cpp:
+(_ewk_view_smart_calculate):
+
2012-01-09 Andras Becsi andras.be...@nokia.com
[Qt][WK2] Pinch zoom should affect the page size
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (104548 => 104549)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-01-10 11:30:21 UTC (rev 104548)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-01-10 11:33:37 UTC (rev 104549)
@@ -348,20 +348,17 @@
smartData-changed.any = false;
evas_object_geometry_get(ewkView, x, y, width, height);
-Evas_Object* clip = evas_object_clip_get(smartData-image);
if (smartData-changed.size) {
if (priv-pageClient-page()-drawingArea())
priv-pageClient-page()-drawingArea()-setSize(IntSize(width, height), IntSize());
smartData-view.w = width;
smartData-view.h = height;
-evas_object_resize(clip, width, height);
smartData-changed.size = false;
}
if (smartData-changed.position) {
evas_object_move(smartData-image, x, y);
-evas_object_move(clip, x, y);
smartData-view.x = x;
smartData-view.y = y;
smartData-changed.position = false;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104550] trunk/Source/WebCore
Title: [104550] trunk/Source/WebCore
Revision 104550
Author kl...@webkit.org
Date 2012-01-10 03:35:32 -0800 (Tue, 10 Jan 2012)
Log Message
Matched declaration cache should support mapped attribute declarations.
http://webkit.org/b/75948
Reviewed by Antti Koivisto.
Support caching of matches that include mapped attribute declarations.
To make this possible, let the cache hold references to the matched style declarations.
Otherwise, declarations are assumed to survive until ~CSSStyleSelector, which may not
be the case for CSSMappedAttributeDeclaration.
To avoid hoarding of stale CSSMappedAttributeDeclarations in the cache, do a sweep for
every 100 additions and garbage collect any entries containing a declaration that is
only referenced by the cache.
This increases cache hit rate by up to ~10% on the Alexa top sites.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::sweepMatchedDeclarationCache):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):
* css/CSSStyleSelector.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104549 => 104550)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 11:33:37 UTC (rev 104549)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 11:35:32 UTC (rev 104550)
@@ -1,3 +1,29 @@
+2012-01-10 Andreas Kling awesomekl...@apple.com
+
+Matched declaration cache should support mapped attribute declarations.
+http://webkit.org/b/75948
+
+Reviewed by Antti Koivisto.
+
+Support caching of matches that include mapped attribute declarations.
+To make this possible, let the cache hold references to the matched style declarations.
+Otherwise, declarations are assumed to survive until ~CSSStyleSelector, which may not
+be the case for CSSMappedAttributeDeclaration.
+
+To avoid hoarding of stale CSSMappedAttributeDeclarations in the cache, do a sweep for
+every 100 additions and garbage collect any entries containing a declaration that is
+only referenced by the cache.
+
+This increases cache hit rate by up to ~10% on the Alexa top sites.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::CSSStyleSelector):
+(WebCore::CSSStyleSelector::sweepMatchedDeclarationCache):
+(WebCore::CSSStyleSelector::matchAllRules):
+(WebCore::CSSStyleSelector::applyDeclarations):
+(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):
+* css/CSSStyleSelector.h:
+
2012-01-10 Kenichi Ishibashi ba...@chromium.org
Complex path should be used when UVS exists in text run
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (104549 => 104550)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-01-10 11:33:37 UTC (rev 104549)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-01-10 11:35:32 UTC (rev 104550)
@@ -330,6 +330,7 @@
bool strictParsing, bool matchAuthorAndUserStyles)
: m_hasUAAppearance(false)
, m_backgroundData(BackgroundFillLayer)
+, m_matchedDeclarationCacheAdditionsSinceLastSweep(0)
, m_checker(document, strictParsing)
, m_parentStyle(0)
, m_rootElementStyle(0)
@@ -481,6 +482,27 @@
m_fontSelector-clearDocument();
}
+void CSSStyleSelector::sweepMatchedDeclarationCache()
+{
+// Look for cache entries containing a style declaration with a single ref and remove them.
+// This may happen when an element attribute mutation causes it to swap out its Attribute::decl()
+// for another CSSMappedAttributeDeclaration, potentially leaving this cache with the last ref.
+Vectorunsigned, 16 toRemove;
+MatchedStyleDeclarationCache::iterator it = m_matchedStyleDeclarationCache.begin();
+MatchedStyleDeclarationCache::iterator end = m_matchedStyleDeclarationCache.end();
+for (; it != end; ++it) {
+VectorMatchedStyleDeclaration matchedStyleDeclarations = it-second.matchedStyleDeclarations;
+for (size_t i = 0; i matchedStyleDeclarations.size(); ++i) {
+if (matchedStyleDeclarations[i].styleDeclaration-hasOneRef()) {
+toRemove.append(it-first);
+break;
+}
+}
+}
+for (size_t i = 0; i toRemove.size(); ++i)
+m_matchedStyleDeclarationCache.remove(toRemove[i]);
+}
+
CSSStyleSelector::Features::Features()
: usesFirstLineRules(false)
, usesBeforeAfterRules(false)
@@ -626,12 +648,6 @@
#endif
}
-CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration()
-{
-// Make sure all memory is zero initializes as we calculate hash over the bytes of this object.
-memset(this, 0, sizeof(*this));
-}
-
void
[webkit-changes] [104551] trunk/Tools
Title: [104551] trunk/Tools Revision 104551 Author hausm...@webkit.org Date 2012-01-10 04:11:42 -0800 (Tue, 10 Jan 2012) Log Message [Qt] DRT crashes with Qt 5 https://bugs.webkit.org/show_bug.cgi?id=75951 Reviewed by Ossy. * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where Qt relies on font-config to define the default font family. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/qt/fonts.conf Diff Modified: trunk/Tools/ChangeLog (104550 => 104551) --- trunk/Tools/ChangeLog 2012-01-10 11:35:32 UTC (rev 104550) +++ trunk/Tools/ChangeLog 2012-01-10 12:11:42 UTC (rev 104551) @@ -1,3 +1,13 @@ +2012-01-10 Simon Hausmann simon.hausm...@nokia.com + +[Qt] DRT crashes with Qt 5 +https://bugs.webkit.org/show_bug.cgi?id=75951 + +Reviewed by Ossy. + +* DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where +Qt relies on font-config to define the default font family. + 2012-01-10 Csaba Osztrogonác o...@webkit.org [Qt] REGRESSION(r100130): Clean build feature is broken. Modified: trunk/Tools/DumpRenderTree/qt/fonts.conf (104550 => 104551) --- trunk/Tools/DumpRenderTree/qt/fonts.conf 2012-01-10 11:35:32 UTC (rev 104550) +++ trunk/Tools/DumpRenderTree/qt/fonts.conf 2012-01-10 12:11:42 UTC (rev 104551) @@ -38,6 +38,23 @@ /edit /match +!-- + If the font still has no generic name, add sans-serif + -- + match target=pattern + test qual=all name=family compare=not_eq + stringsans-serif/string + /test + test qual=all name=family compare=not_eq + stringserif/string + /test + test qual=all name=family compare=not_eq + stringmonospace/string + /test + edit name=family mode=append_last + stringsans-serif/string + /edit + /match config !-- ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104552] trunk/Source/WebCore
Title: [104552] trunk/Source/WebCore
Revision 104552
Author commit-qu...@webkit.org
Date 2012-01-10 04:19:42 -0800 (Tue, 10 Jan 2012)
Log Message
Add NULL checks to setting access obtained on frame and document.
https://bugs.webkit.org/show_bug.cgi?id=72002
Patch by Grzegorz Czajkowski g.czajkow...@samsung.com on 2012-01-10
Reviewed by Andreas Kling.
Adds NULL checks to setting object where it's required.
Generally WebCore checks NULL which may be returned from setting object obtained
on frame or document but in some cases these are skipped. These checks are not
needed to setting's access on page object.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::shouldAccelerate):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
* page/DragController.cpp:
(WebCore::DragController::draggableNode):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::flattenFrameSet):
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
* rendering/RenderText.cpp:
(WebCore::SecureTextTimer::restartWithNewText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCanvasElement.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/SubframeLoader.cpp
trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/FocusController.cpp
trunk/Source/WebCore/rendering/RenderFrameSet.cpp
trunk/Source/WebCore/rendering/RenderIFrame.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderText.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104551 => 104552)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 12:11:42 UTC (rev 104551)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 12:19:42 UTC (rev 104552)
@@ -1,3 +1,39 @@
+2012-01-10 Grzegorz Czajkowski g.czajkow...@samsung.com
+
+Add NULL checks to setting access obtained on frame and document.
+https://bugs.webkit.org/show_bug.cgi?id=72002
+
+Reviewed by Andreas Kling.
+
+Adds NULL checks to setting object where it's required.
+Generally WebCore checks NULL which may be returned from setting object obtained
+on frame or document but in some cases these are skipped. These checks are not
+needed to setting's access on page object.
+
+* html/HTMLCanvasElement.cpp:
+(WebCore::HTMLCanvasElement::shouldAccelerate):
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::scheduleArchiveLoad):
+* loader/SubframeLoader.cpp:
+(WebCore::SubframeLoader::requestPlugin):
+* loader/appcache/ApplicationCacheGroup.cpp:
+(WebCore::ApplicationCacheGroup::selectCache):
+(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
+* page/DragController.cpp:
+(WebCore::DragController::draggableNode):
+* page/EventHandler.cpp:
+(WebCore::EventHandler::handleMouseReleaseEvent):
+* page/FocusController.cpp:
+(WebCore::FocusController::advanceFocusInDocumentOrder):
+* rendering/RenderFrameSet.cpp:
+(WebCore::RenderFrameSet::flattenFrameSet):
+* rendering/RenderIFrame.cpp:
+(WebCore::RenderIFrame::flattenFrame):
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateBacking):
+* rendering/RenderText.cpp:
+(WebCore::SecureTextTimer::restartWithNewText):
+
2012-01-10 Andreas Kling awesomekl...@apple.com
Matched declaration cache should support mapped attribute declarations.
Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (104551 => 104552)
--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2012-01-10 12:11:42 UTC (rev 104551)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2012-01-10 12:19:42 UTC (rev 104552)
@@ -423,13 +423,13 @@
{
#if USE(IOSURFACE_CANVAS_BACKING_STORE)
UNUSED_PARAM(size);
-return document()-settings()-canvasUsesAcceleratedDrawing();
+return document()-settings() document()-settings()-canvasUsesAcceleratedDrawing();
#elif ENABLE(ACCELERATED_2D_CANVAS)
if (m_context !m_context-is2d())
return false;
Settings* settings = document()-settings();
-if (!settings-accelerated2dCanvasEnabled())
+if (!settings || !settings-accelerated2dCanvasEnabled())
return false;
// Do not use acceleration for small canvas.
[webkit-changes] [104553] trunk/Source/WebCore
Title: [104553] trunk/Source/WebCore
Revision 104553
Author pfeld...@chromium.org
Date 2012-01-10 04:57:00 -0800 (Tue, 10 Jan 2012)
Log Message
Web Inspector: restore front-end compilation
https://bugs.webkit.org/show_bug.cgi?id=75625
Patch by pfeld...@chomium.org pavel.feld...@gmail.com on 2012-01-10
Reviewed by Yury Semikhatsky.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
* inspector/front-end/TabbedPane.js:
* inspector/front-end/externs.js:
(WebInspector.isCompactMode):
* inspector/front-end/treeoutline.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/TabbedPane.js
trunk/Source/WebCore/inspector/front-end/externs.js
trunk/Source/WebCore/inspector/front-end/treeoutline.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (104552 => 104553)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 12:19:42 UTC (rev 104552)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 12:57:00 UTC (rev 104553)
@@ -1,3 +1,17 @@
+2012-01-10 pfeld...@chomium.org pavel.feld...@gmail.com
+
+Web Inspector: restore front-end compilation
+https://bugs.webkit.org/show_bug.cgi?id=75625
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
+* inspector/front-end/TabbedPane.js:
+* inspector/front-end/externs.js:
+(WebInspector.isCompactMode):
+* inspector/front-end/treeoutline.js:
+
2012-01-10 Grzegorz Czajkowski g.czajkow...@samsung.com
Add NULL checks to setting access obtained on frame and document.
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (104552 => 104553)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-01-10 12:19:42 UTC (rev 104552)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-01-10 12:57:00 UTC (rev 104553)
@@ -1529,7 +1529,7 @@
{
this._currentSourceFrame.detach();
this._currentSourceFrame = null;
-this.showSourceFrame(title, sourceFrame);
+this.showSourceFrame(title, sourceFrame, tooltip);
},
/**
Modified: trunk/Source/WebCore/inspector/front-end/TabbedPane.js (104552 => 104553)
--- trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-01-10 12:19:42 UTC (rev 104552)
+++ trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-01-10 12:57:00 UTC (rev 104553)
@@ -484,7 +484,7 @@
},
/**
- * @type {string=}
+ * @type {string|undefined}
*/
get tooltip()
{
Modified: trunk/Source/WebCore/inspector/front-end/externs.js (104552 => 104553)
--- trunk/Source/WebCore/inspector/front-end/externs.js 2012-01-10 12:19:42 UTC (rev 104552)
+++ trunk/Source/WebCore/inspector/front-end/externs.js 2012-01-10 12:57:00 UTC (rev 104553)
@@ -184,3 +184,5 @@
* @type {string}
*/
WebInspector.inspectedPageDomain;
+
+WebInspector.isCompactMode = function() { return false; }
Modified: trunk/Source/WebCore/inspector/front-end/treeoutline.js (104552 => 104553)
--- trunk/Source/WebCore/inspector/front-end/treeoutline.js 2012-01-10 12:19:42 UTC (rev 104552)
+++ trunk/Source/WebCore/inspector/front-end/treeoutline.js 2012-01-10 12:57:00 UTC (rev 104553)
@@ -539,7 +539,7 @@
/**
* @param {string} searchText
- * @param {TreeElement=} startTreeElement
+ * @param {TreeElement} startTreeElement
* @param {boolean} skipStartTreeElement
*/
TreeOutline.prototype._nextSearchMatch = function(searchText, startTreeElement, skipStartTreeElement)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104554] trunk/Source/WebCore
Title: [104554] trunk/Source/WebCore
Revision 104554
Author pfeld...@chromium.org
Date 2012-01-10 05:00:47 -0800 (Tue, 10 Jan 2012)
Log Message
Web Inspector: typo: NetworkAgent.canClearBrowserCache - NetworkAgent.canClearBrowserCookies.
https://bugs.webkit.org/show_bug.cgi?id=75949
Reviewed by Andreas Kling.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (104553 => 104554)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 12:57:00 UTC (rev 104553)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 13:00:47 UTC (rev 104554)
@@ -1,3 +1,13 @@
+2012-01-10 Pavel Feldman pfeld...@google.com
+
+Web Inspector: typo: NetworkAgent.canClearBrowserCache - NetworkAgent.canClearBrowserCookies.
+https://bugs.webkit.org/show_bug.cgi?id=75949
+
+Reviewed by Andreas Kling.
+
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkLogView):
+
2012-01-10 pfeld...@chomium.org pavel.feld...@gmail.com
Web Inspector: restore front-end compilation
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (104553 => 104554)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-01-10 12:57:00 UTC (rev 104553)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-01-10 13:00:47 UTC (rev 104554)
@@ -76,7 +76,7 @@
{
this._canClearBrowserCookies = result;
}
-NetworkAgent.canClearBrowserCache(onCanClearBrowserCookies.bind(this));
+NetworkAgent.canClearBrowserCookies(onCanClearBrowserCookies.bind(this));
}
WebInspector.NetworkLogView.prototype = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104555] trunk/LayoutTests
Title: [104555] trunk/LayoutTests Revision 104555 Author vse...@chromium.org Date 2012-01-10 05:06:32 -0800 (Tue, 10 Jan 2012) Log Message Unreviewed, chromium test expectations update. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104554 => 104555) --- trunk/LayoutTests/ChangeLog 2012-01-10 13:00:47 UTC (rev 104554) +++ trunk/LayoutTests/ChangeLog 2012-01-10 13:06:32 UTC (rev 104555) @@ -1,3 +1,9 @@ +2012-01-10 Vsevolod Vlasov vse...@chromium.org + +Unreviewed, chromium test expectations update. + +* platform/chromium/test_expectations.txt: + 2012-01-10 Gyuyoung Kim gyuyoung@samsung.com Add initial test_expectations.txt for EFL port. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104554 => 104555) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 13:00:47 UTC (rev 104554) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 13:06:32 UTC (rev 104555) @@ -653,10 +653,11 @@ BUGCR67662 LINUX WIN : http/tests/inspector/console-websocket-error.html = TIMEOUT TEXT -BUGWK56602 SKIP : http/tests/inspector/network/network-timing.html = FAIL -BUGWK56602 SKIP : http/tests/inspector/network/network-size.html = FAIL -BUGWK56602 SKIP : http/tests/inspector/network/network-size-chunked.html = FAIL -BUGWK56602 SKIP : http/tests/inspector/network/network-size-sync.html = FAIL +// Transferred time/size are not supported in DRT. +WONTFIX SKIP : http/tests/inspector/network/network-timing.html = FAIL +WONTFIX SKIP : http/tests/inspector/network/network-size.html = FAIL +WONTFIX SKIP : http/tests/inspector/network/network-size-chunked.html = FAIL +WONTFIX SKIP : http/tests/inspector/network/network-size-sync.html = FAIL // PageAgent can not getCookies from DumpRenderTree. BUGWK65770 SKIP : http/tests/inspector/resource-main-cookies.php = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104556] trunk/Tools
Title: [104556] trunk/Tools
Revision 104556
Author commit-qu...@webkit.org
Date 2012-01-10 05:24:58 -0800 (Tue, 10 Jan 2012)
Log Message
[Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
https://bugs.webkit.org/show_bug.cgi?id=75894
Patch by Alexander Færøy alexander.fae...@nokia.com on 2012-01-10
Reviewed by Tor Arne Vestbø.
* MiniBrowser/qt/MiniBrowserApplication.h:
(MiniBrowserApplication::windowOptions):
* MiniBrowser/qt/main.cpp:
(main):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.h
trunk/Tools/MiniBrowser/qt/main.cpp
Diff
Modified: trunk/Tools/ChangeLog (104555 => 104556)
--- trunk/Tools/ChangeLog 2012-01-10 13:06:32 UTC (rev 104555)
+++ trunk/Tools/ChangeLog 2012-01-10 13:24:58 UTC (rev 104556)
@@ -1,3 +1,15 @@
+2012-01-10 Alexander Færøy alexander.fae...@nokia.com
+
+[Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
+https://bugs.webkit.org/show_bug.cgi?id=75894
+
+Reviewed by Tor Arne Vestbø.
+
+* MiniBrowser/qt/MiniBrowserApplication.h:
+(MiniBrowserApplication::windowOptions):
+* MiniBrowser/qt/main.cpp:
+(main):
+
2012-01-10 Simon Hausmann simon.hausm...@nokia.com
[Qt] DRT crashes with Qt 5
Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.h (104555 => 104556)
--- trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.h 2012-01-10 13:06:32 UTC (rev 104555)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.h 2012-01-10 13:24:58 UTC (rev 104556)
@@ -98,9 +98,8 @@
bool isRobotized() const { return m_isRobotized; }
int robotTimeout() const { return m_robotTimeoutSeconds; }
int robotExtraTime() const { return m_robotExtraTimeSeconds; }
+WindowOptions* windowOptions() { return m_windowOptions; }
-WindowOptions m_windowOptions;
-
virtual bool notify(QObject*, QEvent*);
private:
@@ -117,6 +116,8 @@
QHashint, QWindowSystemInterface::TouchPoint m_touchPoints;
QSetint m_heldTouchPoints;
+
+WindowOptions m_windowOptions;
};
QML_DECLARE_TYPE(WindowOptions);
Modified: trunk/Tools/MiniBrowser/qt/main.cpp (104555 => 104556)
--- trunk/Tools/MiniBrowser/qt/main.cpp 2012-01-10 13:06:32 UTC (rev 104555)
+++ trunk/Tools/MiniBrowser/qt/main.cpp 2012-01-10 13:24:58 UTC (rev 104556)
@@ -45,7 +45,7 @@
MiniBrowserApplication app(argc, argv);
if (app.isRobotized()) {
-BrowserWindow* window = new BrowserWindow(app.m_windowOptions);
+BrowserWindow* window = new BrowserWindow(app.windowOptions());
UrlLoader loader(window, app.urls().at(0), app.robotTimeout(), app.robotExtraTime());
loader.loadNext();
window-show();
@@ -62,7 +62,7 @@
urls.append(http://www.google.com);
}
-BrowserWindow* window = new BrowserWindow(app.m_windowOptions);
+BrowserWindow* window = new BrowserWindow(app.windowOptions());
window-load(urls.at(0));
for (int i = 1; i urls.size(); ++i)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104557] trunk/Source/WebKit2
Title: [104557] trunk/Source/WebKit2 Revision 104557 Author kenn...@webkit.org Date 2012-01-10 05:25:27 -0800 (Tue, 10 Jan 2012) Log Message Implement the input panel request/close handling Reviewed by Simon Hausmann. With the current patch we only request the input panel as a response to a user tap. Close requests, on the other hand, is always respected. As multiple show/hide requests can happen while processing the tap gesture, input panel visibility changes are postponed until the tap gesture ends. The input panel will become visible if the WebCore editor is in canEdit mode and thus work for content-editable, meaning that it won't close the input panel if you click on a link (eg. editCommand) while in content-editable mode. * UIProcess/PageClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleGestureEvent): (WebKit::WebPageProxy::editorStateChanged): (WebKit::WebPageProxy::didReceiveEvent): Add a new doneWithGestureEvent method to the PageClient as well as add a updateTextInputState similar to that of mac. * UIProcess/WebPageProxy.h: * UIProcess/qt/QtPageClient.cpp: (QtPageClient::updateTextInputState): (QtPageClient::doneWithGestureEvent): Propagate the new events to the Qt EventHandler. * UIProcess/qt/QtPageClient.h: * UIProcess/qt/QtWebPageEventHandler.cpp: * UIProcess/qt/QtWebPageEventHandler.h: (QtWebPageEventHandler::QtWebPageEventHandler): (QtWebPageEventHandler::handleSingleTapEvent): (setInputPanelVisible): (QtWebPageEventHandler::updateTextInputState): (QtWebPageEventHandler::doneWithGestureEvent): Handle postponing of the input method visibility change and the actual showing/hiding. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/PageClient.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/qt/QtPageClient.cpp trunk/Source/WebKit2/UIProcess/qt/QtPageClient.h trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.h Diff Modified: trunk/Source/WebKit2/ChangeLog (104556 => 104557) --- trunk/Source/WebKit2/ChangeLog 2012-01-10 13:24:58 UTC (rev 104556) +++ trunk/Source/WebKit2/ChangeLog 2012-01-10 13:25:27 UTC (rev 104557) @@ -1,3 +1,50 @@ +2012-01-10 Kenneth Rohde Christiansen kenn...@webkit.org + +Implement the input panel request/close handling + +Reviewed by Simon Hausmann. + +With the current patch we only request the input panel as a +response to a user tap. Close requests, on the other hand, +is always respected. + +As multiple show/hide requests can happen while processing +the tap gesture, input panel visibility changes are postponed +until the tap gesture ends. + +The input panel will become visible if the WebCore editor is +in canEdit mode and thus work for content-editable, meaning +that it won't close the input panel if you click on a link +(eg. editCommand) while in content-editable mode. + +* UIProcess/PageClient.h: +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::handleGestureEvent): +(WebKit::WebPageProxy::editorStateChanged): +(WebKit::WebPageProxy::didReceiveEvent): + +Add a new doneWithGestureEvent method to the PageClient +as well as add a updateTextInputState similar to that of mac. + +* UIProcess/WebPageProxy.h: +* UIProcess/qt/QtPageClient.cpp: +(QtPageClient::updateTextInputState): +(QtPageClient::doneWithGestureEvent): + +Propagate the new events to the Qt EventHandler. + +* UIProcess/qt/QtPageClient.h: +* UIProcess/qt/QtWebPageEventHandler.cpp: +* UIProcess/qt/QtWebPageEventHandler.h: +(QtWebPageEventHandler::QtWebPageEventHandler): +(QtWebPageEventHandler::handleSingleTapEvent): +(setInputPanelVisible): +(QtWebPageEventHandler::updateTextInputState): +(QtWebPageEventHandler::doneWithGestureEvent): + +Handle postponing of the input method visibility change +and the actual showing/hiding. + 2012-01-10 Eunmi Lee eunmi15@samsung.com [EFL][WK2] Remove codes to move and resize the clip. Modified: trunk/Source/WebKit2/UIProcess/PageClient.h (104556 => 104557) --- trunk/Source/WebKit2/UIProcess/PageClient.h 2012-01-10 13:24:58 UTC (rev 104556) +++ trunk/Source/WebKit2/UIProcess/PageClient.h 2012-01-10 13:25:27 UTC (rev 104557) @@ -106,6 +106,7 @@ virtual void focusEditableArea(const WebCore::IntRect, const WebCore::IntRect) = 0; virtual void didReceiveMessageFromNavigatorQtObject(const String) = 0; virtual void handleDownloadRequest(DownloadProxy*) = 0; +virtual void updateTextInputState() = 0; #endif #if PLATFORM(QT) || PLATFORM(GTK) @@ -141,6 +142,9 @@ virtual WebCore::IntRect windowToScreen(const
[webkit-changes] [104558] trunk/Tools
Title: [104558] trunk/Tools Revision 104558 Author hausm...@webkit.org Date 2012-01-10 05:34:08 -0800 (Tue, 10 Jan 2012) Log Message [Qt] Remove dependency to uitools https://bugs.webkit.org/show_bug.cgi?id=75952 Reviewed by Tor Arne Vestbø. QUiLoader is used for creating QLabel/QProgressBar widgets for a layout test, to verify some widget embedding feature. Unfortunately in Qt 5, QUiLoader is part of qttools, which depends on webkit, which depends on qttools. Since we don't really _need_ QUiLoader for our tests, let's break the circular dependency. * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::createPlugin): * QtTestBrowser/QtTestBrowser.pro: * QtTestBrowser/launcherwindow.h: * QtTestBrowser/webpage.cpp: (WebPage::createPlugin): * qmake/mkspecs/features/minimal_qt.prf: * qmake/mkspecs/features/uitools.prf: Removed. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp trunk/Tools/QtTestBrowser/QtTestBrowser.pro trunk/Tools/QtTestBrowser/launcherwindow.h trunk/Tools/QtTestBrowser/webpage.cpp trunk/Tools/qmake/mkspecs/features/minimal_qt.prf Removed Paths trunk/Tools/qmake/mkspecs/features/uitools.prf Diff Modified: trunk/Tools/ChangeLog (104557 => 104558) --- trunk/Tools/ChangeLog 2012-01-10 13:25:27 UTC (rev 104557) +++ trunk/Tools/ChangeLog 2012-01-10 13:34:08 UTC (rev 104558) @@ -1,3 +1,26 @@ +2012-01-10 Simon Hausmann simon.hausm...@nokia.com + +[Qt] Remove dependency to uitools +https://bugs.webkit.org/show_bug.cgi?id=75952 + +Reviewed by Tor Arne Vestbø. + +QUiLoader is used for creating QLabel/QProgressBar widgets for +a layout test, to verify some widget embedding feature. Unfortunately +in Qt 5, QUiLoader is part of qttools, which depends on webkit, which +depends on qttools. Since we don't really _need_ QUiLoader for our tests, +let's break the circular dependency. + +* DumpRenderTree/qt/DumpRenderTree.pro: +* DumpRenderTree/qt/DumpRenderTreeQt.cpp: +(WebCore::WebPage::createPlugin): +* QtTestBrowser/QtTestBrowser.pro: +* QtTestBrowser/launcherwindow.h: +* QtTestBrowser/webpage.cpp: +(WebPage::createPlugin): +* qmake/mkspecs/features/minimal_qt.prf: +* qmake/mkspecs/features/uitools.prf: Removed. + 2012-01-10 Alexander Færøy alexander.fae...@nokia.com [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication Modified: trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro (104557 => 104558) --- trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro 2012-01-10 13:25:27 UTC (rev 104557) +++ trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro 2012-01-10 13:34:08 UTC (rev 104558) @@ -10,7 +10,6 @@ DESTDIR = $$ROOT_BUILD_DIR/bin load(features) -CONFIG += uitools WEBKIT += wtf webcore Modified: trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp (104557 => 104558) --- trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp 2012-01-10 13:25:27 UTC (rev 104557) +++ trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp 2012-01-10 13:34:08 UTC (rev 104558) @@ -49,6 +49,7 @@ #include QFileInfo #include QFocusEvent #include QFontDatabase +#include QLabel #include QLocale #include QNetworkAccessManager #include QNetworkReply @@ -58,16 +59,13 @@ #ifndef QT_NO_PRINTER #include QPrinter #endif +#include QProgressBar #include QUndoStack #include QUrl #include qwebsettings.h #include qwebsecurityorigin.h -#ifndef QT_NO_UITOOLS -#include QtUiTools/QUiLoader -#endif - #if HAVE(FONTCONFIG) #include fontconfig/fontconfig.h #endif @@ -363,13 +361,13 @@ Q_UNUSED(url); Q_UNUSED(paramNames); Q_UNUSED(paramValues); -#ifndef QT_NO_UITOOLS -QUiLoader loader; -return loader.createWidget(classId, view()); -#else -Q_UNUSED(classId); + +if (classId == QLatin1String(QProgressBar)) +return new QProgressBar(view()); +if (classId == QLatin1String(QLabel)) +return new QLabel(view()); + return 0; -#endif } void WebPage::setViewGeometry(const QRect rect) Modified: trunk/Tools/QtTestBrowser/QtTestBrowser.pro (104557 => 104558) --- trunk/Tools/QtTestBrowser/QtTestBrowser.pro 2012-01-10 13:25:27 UTC (rev 104557) +++ trunk/Tools/QtTestBrowser/QtTestBrowser.pro 2012-01-10 13:34:08 UTC (rev 104558) @@ -35,8 +35,6 @@ cookiejar.h -CONFIG += uitools - WEBKIT += webcore CONFIG += qtwebkit Modified: trunk/Tools/QtTestBrowser/launcherwindow.h (104557 => 104558) --- trunk/Tools/QtTestBrowser/launcherwindow.h 2012-01-10 13:25:27 UTC (rev 104557) +++ trunk/Tools/QtTestBrowser/launcherwindow.h 2012-01-10 13:34:08 UTC (rev 104558) @@ -43,10 +43,6 @@ #include QPrintPreviewDialog #endif -#ifndef QT_NO_UITOOLS -#include QtUiTools/QUiLoader -#endif - #include QDebug #include cstdio Modified:
[webkit-changes] [104559] trunk/Tools
Title: [104559] trunk/Tools
Revision 104559
Author hausm...@webkit.org
Date 2012-01-10 05:36:26 -0800 (Tue, 10 Jan 2012)
Log Message
[Qt] Unreviewed -Werror build fix.
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
declaration.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp
Diff
Modified: trunk/Tools/ChangeLog (104558 => 104559)
--- trunk/Tools/ChangeLog 2012-01-10 13:34:08 UTC (rev 104558)
+++ trunk/Tools/ChangeLog 2012-01-10 13:36:26 UTC (rev 104559)
@@ -1,5 +1,13 @@
2012-01-10 Simon Hausmann simon.hausm...@nokia.com
+[Qt] Unreviewed -Werror build fix.
+
+* MiniBrowser/qt/MiniBrowserApplication.cpp:
+(MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
+declaration.
+
+2012-01-10 Simon Hausmann simon.hausm...@nokia.com
+
[Qt] Remove dependency to uitools
https://bugs.webkit.org/show_bug.cgi?id=75952
Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp (104558 => 104559)
--- trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2012-01-10 13:34:08 UTC (rev 104558)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2012-01-10 13:36:26 UTC (rev 104559)
@@ -63,12 +63,12 @@
MiniBrowserApplication::MiniBrowserApplication(int argc, char** argv)
: QApplication(argc, argv)
-, m_windowOptions(this)
, m_realTouchEventReceived(false)
, m_pendingFakeTouchEventCount(0)
, m_isRobotized(false)
, m_robotTimeoutSeconds(0)
, m_robotExtraTimeSeconds(0)
+, m_windowOptions(this)
{
setOrganizationName(Nokia);
setApplicationName(QtMiniBrowser);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104561] trunk/LayoutTests
Title: [104561] trunk/LayoutTests Revision 104561 Author o...@webkit.org Date 2012-01-10 05:44:50 -0800 (Tue, 10 Jan 2012) Log Message Unreviewed gardening. * platform/gtk/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html. * platform/qt-wk2/Skipped: Skip fast/loader/submit-form-while-parsing-2.html, because it fails intermittently. * platform/qt/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (104560 => 104561) --- trunk/LayoutTests/ChangeLog 2012-01-10 13:44:02 UTC (rev 104560) +++ trunk/LayoutTests/ChangeLog 2012-01-10 13:44:50 UTC (rev 104561) @@ -1,3 +1,11 @@ +2012-01-10 Csaba Osztrogonác o...@webkit.org + +Unreviewed gardening. + +* platform/gtk/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html. +* platform/qt-wk2/Skipped: Skip fast/loader/submit-form-while-parsing-2.html, because it fails intermittently. +* platform/qt/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html. + 2012-01-10 No'am Rosenthal noam.rosent...@nokia.com [Qt] Enable CSS_FILTERS in Qt build Modified: trunk/LayoutTests/platform/gtk/Skipped (104560 => 104561) --- trunk/LayoutTests/platform/gtk/Skipped 2012-01-10 13:44:02 UTC (rev 104560) +++ trunk/LayoutTests/platform/gtk/Skipped 2012-01-10 13:44:50 UTC (rev 104561) @@ -1620,10 +1620,6 @@ media/W3C/video/readyState/readyState_during_loadedmetadata.html media/W3C/video/readyState/readyState_during_playing.html -# fast/dom/htmlcollection-zombies.html fails on GTK and on Qt -# https://bugs.webkit.org/show_bug.cgi?id=75431 -fast/dom/htmlcollection-zombies.html - # https://bugs.webkit.org/show_bug.cgi?id=75785 accessibility/textbox-role-reports-line-number.html Modified: trunk/LayoutTests/platform/qt/Skipped (104560 => 104561) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-10 13:44:02 UTC (rev 104560) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-10 13:44:50 UTC (rev 104561) @@ -2564,10 +2564,6 @@ fast/css/absolute-inline-alignment.html fast/css/absolute-inline-alignment-2.html -# fast/dom/htmlcollection-zombies.html fails on GTK and on Qt -# https://bugs.webkit.org/show_bug.cgi?id=75431 -fast/dom/htmlcollection-zombies.html - # [Qt]http/tests/workers/terminate-during-sync-operation.html fails intermittently # https://bugs.webkit.org/show_bug.cgi?id=75614 http/tests/workers/terminate-during-sync-operation.html Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (104560 => 104561) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-10 13:44:02 UTC (rev 104560) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-10 13:44:50 UTC (rev 104561) @@ -922,3 +922,7 @@ # [Qt][WK2]REGRESSION(r104068): editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html made the next test fail # https://bugs.webkit.org/show_bug.cgi?id=75615 editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html + +# [Qt][WK2]fast/loader/submit-form-while-parsing-2.html fails intermittently +# https://bugs.webkit.org/show_bug.cgi?id=75950 +fast/loader/submit-form-while-parsing-2.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104562] trunk/Source/WebKit/efl
Title: [104562] trunk/Source/WebKit/efl
Revision 104562
Author k...@profusion.mobi
Date 2012-01-10 05:46:54 -0800 (Tue, 10 Jan 2012)
Log Message
[EFL] Add getter for Ewk_JS_Object::view.
https://bugs.webkit.org/show_bug.cgi?id=75868
Reviewed by Andreas Kling.
So far the view associated with a given JS object was a private
property only accessible to ewk itself. This does not make much sense,
as one often needs to know which view a certain method was invoked
from, for example.
* ewk/ewk_js.cpp:
(ewk_js_object_view_get):
* ewk/ewk_js.h:
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_js.cpp
trunk/Source/WebKit/efl/ewk/ewk_js.h
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (104561 => 104562)
--- trunk/Source/WebKit/efl/ChangeLog 2012-01-10 13:44:50 UTC (rev 104561)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-01-10 13:46:54 UTC (rev 104562)
@@ -1,3 +1,19 @@
+2012-01-09 Raphael Kubo da Costa k...@profusion.mobi
+
+[EFL] Add getter for Ewk_JS_Object::view.
+https://bugs.webkit.org/show_bug.cgi?id=75868
+
+Reviewed by Andreas Kling.
+
+So far the view associated with a given JS object was a private
+property only accessible to ewk itself. This does not make much sense,
+as one often needs to know which view a certain method was invoked
+from, for example.
+
+* ewk/ewk_js.cpp:
+(ewk_js_object_view_get):
+* ewk/ewk_js.h:
+
2012-01-06 JungJik Lee jungjik@samsung.com
[EFL] Add new pre-rendering code.
Modified: trunk/Source/WebKit/efl/ewk/ewk_js.cpp (104561 => 104562)
--- trunk/Source/WebKit/efl/ewk/ewk_js.cpp 2012-01-10 13:44:50 UTC (rev 104561)
+++ trunk/Source/WebKit/efl/ewk/ewk_js.cpp 2012-01-10 13:46:54 UTC (rev 104562)
@@ -612,6 +612,13 @@
free(jsObject);
}
+Evas_Object* ewk_js_object_view_get(const Ewk_JS_Object* jsObject)
+{
+EINA_SAFETY_ON_NULL_RETURN_VAL(jsObject, 0);
+EINA_MAGIC_CHECK_OR_RETURN(jsObject, 0);
+return jsObject-view;
+}
+
Eina_Hash* ewk_js_object_properties_get(const Ewk_JS_Object* jsObject)
{
EINA_SAFETY_ON_NULL_RETURN_VAL(jsObject, 0);
@@ -708,6 +715,11 @@
return 0;
}
+Evas_Object* ewk_js_object_view_get(const Ewk_JS_Object* jsObject)
+{
+return 0;
+}
+
void ewk_js_variant_free(Ewk_JS_Variant* jsVariant)
{
}
Modified: trunk/Source/WebKit/efl/ewk/ewk_js.h (104561 => 104562)
--- trunk/Source/WebKit/efl/ewk/ewk_js.h 2012-01-10 13:44:50 UTC (rev 104561)
+++ trunk/Source/WebKit/efl/ewk/ewk_js.h 2012-01-10 13:46:54 UTC (rev 104562)
@@ -119,6 +119,21 @@
EAPI const char *ewk_js_object_name_get(const Ewk_JS_Object *obj);
/**
+ * Returns the view associated with an Ewk_JS_Object.
+ *
+ * The returned view is the one passed to ewk_view_js_object_add. Right now,
+ * the object is always added to the view's main frame.
+ *
+ * @param obj The object to be queried.
+ *
+ * @return The view whose main frame the object has been inserted into, or
+ * @c NULL if the object has not been added to a view yet.
+ *
+ * @sa ewk_view_js_object_add, ewk_view_frame_main_get
+ */
+EAPI Evas_Object *ewk_js_object_view_get(const Ewk_JS_Object *obj);
+
+/**
* Release resources allocated by @a var.
*
* @param var @a Ewk_JS_Variant to be release
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104563] trunk/Source/WebCore
Title: [104563] trunk/Source/WebCore
Revision 104563
Author pfeld...@chromium.org
Date 2012-01-10 05:49:04 -0800 (Tue, 10 Jan 2012)
Log Message
Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
over same raw source code multiple times.
https://bugs.webkit.org/show_bug.cgi?id=75953
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (104562 => 104563)
--- trunk/Source/WebCore/ChangeLog 2012-01-10 13:46:54 UTC (rev 104562)
+++ trunk/Source/WebCore/ChangeLog 2012-01-10 13:49:04 UTC (rev 104563)
@@ -1,3 +1,19 @@
+2012-01-10 Pavel Feldman pfeld...@google.com
+
+Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
+over same raw source code multiple times.
+https://bugs.webkit.org/show_bug.cgi?id=75953
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel):
+(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
+(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
+(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
+(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
+(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
+
2012-01-10 No'am Rosenthal noam.rosent...@nokia.com
[Qt] Enable CSS_FILTERS in Qt build
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (104562 => 104563)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-01-10 13:46:54 UTC (rev 104562)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-01-10 13:49:04 UTC (rev 104563)
@@ -36,6 +36,7 @@
{
// FIXME: apply formatter from outside as a generic mapping.
this._formatter = new WebInspector.ScriptFormatter();
+this._rawSourceCodes = [];
this._rawSourceCodeForScriptId = {};
this._rawSourceCodeForURL = {};
this._rawSourceCodeForDocumentURL = {};
@@ -143,7 +144,8 @@
if (WebInspector.settings.sourceMapsEnabled.get() script.sourceMapURL)
compilerSourceMapping = new WebInspector.ClosureCompilerSourceMapping(script.sourceMapURL, script.sourceURL);
-rawSourceCode = new WebInspector.RawSourceCode(script.scriptId, script, resource, this._formatter, this._formatSource, compilerSourceMapping);
+var rawSourceCode = new WebInspector.RawSourceCode(script.scriptId, script, resource, this._formatter, this._formatSource, compilerSourceMapping);
+this._rawSourceCodes.push(rawSourceCode);
this._bindScriptToRawSourceCode(script, rawSourceCode);
if (isInlineScript)
@@ -180,10 +182,10 @@
uiSourceCodes: function()
{
var result = [];
-for (var id in this._rawSourceCodeForScriptId) {
-var uiSourceCodeList = this._rawSourceCodeForScriptId[id].sourceMapping.uiSourceCodeList();
-for (var i = 0; i uiSourceCodeList.length; ++i)
-result.push(uiSourceCodeList[i]);
+for (var i = 0; i this._rawSourceCodes.length; ++i) {
+var uiSourceCodeList = this._rawSourceCodes[i].sourceMapping.uiSourceCodeList();
+for (var j = 0; j uiSourceCodeList.length; ++j)
+result.push(uiSourceCodeList[j]);
}
return result;
},
@@ -335,8 +337,8 @@
this._formatSource = formatSource;
this._breakpointManager.reset();
-for (var id in this._rawSourceCodeForScriptId)
-this._rawSourceCodeForScriptId[id].setFormatted(this._formatSource);
+for (var i = 0; i this._rawSourceCodes.length; ++i)
+this._rawSourceCodes[i].setFormatted(this._formatSource);
},
/**
@@ -376,8 +378,8 @@
_consoleCleared: function()
{
-for (var id in this._rawSourceCodeForScriptId)
-this._rawSourceCodeForScriptId[id].messages = [];
+for (var i = 0; i this._rawSourceCodes.length; ++i)
+this._rawSourceCodes[i].messages = [];
this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.ConsoleMessagesCleared);
},
@@ -655,15 +657,16 @@
_debuggerReset: function()
{
-for (var id in this._rawSourceCodeForScriptId) {
-var rawSourceCode =
[webkit-changes] [104564] trunk/Source/WebKit2
Title: [104564] trunk/Source/WebKit2 Revision 104564 Author kenn...@webkit.org Date 2012-01-10 06:13:44 -0800 (Tue, 10 Jan 2012) Log Message Unreviewed buildfix. * UIProcess/WebPageProxy.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebPageProxy.h Diff Modified: trunk/Source/WebKit2/ChangeLog (104563 => 104564) --- trunk/Source/WebKit2/ChangeLog 2012-01-10 13:49:04 UTC (rev 104563) +++ trunk/Source/WebKit2/ChangeLog 2012-01-10 14:13:44 UTC (rev 104564) @@ -1,5 +1,11 @@ 2012-01-10 Kenneth Rohde Christiansen kenn...@webkit.org +Unreviewed buildfix. + +* UIProcess/WebPageProxy.h: + +2012-01-10 Kenneth Rohde Christiansen kenn...@webkit.org + Implement the input panel request/close handling Reviewed by Simon Hausmann. Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (104563 => 104564) --- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2012-01-10 13:49:04 UTC (rev 104563) +++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2012-01-10 14:13:44 UTC (rev 104564) @@ -952,7 +952,9 @@ WebCore::PolicyAction m_syncNavigationActionPolicyAction; uint64_t m_syncNavigationActionPolicyDownloadID; +#if ENABLE(GESTURE_EVENTS) DequeWebGestureEvent m_gestureEventQueue; +#endif DequeNativeWebKeyboardEvent m_keyEventQueue; DequeNativeWebWheelEvent m_wheelEventQueue; VectorNativeWebWheelEvent m_currentlyProcessedWheelEvents; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104565] trunk/Source/WebKit2
Title: [104565] trunk/Source/WebKit2 Revision 104565 Author hausm...@webkit.org Date 2012-01-10 06:18:38 -0800 (Tue, 10 Jan 2012) Log Message [Qt] Fix failing WK2 layout tests after r104557 Reviewed by Kenneth Rohde Christiansen. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Add missing break to not handle mouseDown as gesture event. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (104564 => 104565) --- trunk/Source/WebKit2/ChangeLog 2012-01-10 14:13:44 UTC (rev 104564) +++ trunk/Source/WebKit2/ChangeLog 2012-01-10 14:18:38 UTC (rev 104565) @@ -1,3 +1,13 @@ +2012-01-10 Simon Hausmann simon.hausm...@nokia.com + +[Qt] Fix failing WK2 layout tests after r104557 + +Reviewed by Kenneth Rohde Christiansen. + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::didReceiveEvent): Add missing break to not +handle mouseDown as gesture event. + 2012-01-10 Kenneth Rohde Christiansen kenn...@webkit.org Unreviewed buildfix. Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (104564 => 104565) --- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-01-10 14:13:44 UTC (rev 104564) +++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-01-10 14:18:38 UTC (rev 104565) @@ -2912,6 +2912,7 @@ } break; case WebEvent::MouseDown: +break; #if ENABLE(GESTURE_EVENTS) case WebEvent::GestureScrollBegin: case WebEvent::GestureScrollEnd: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104566] trunk
Title: [104566] trunk Revision 104566 Author senorbla...@chromium.org Date 2012-01-10 07:01:07 -0800 (Tue, 10 Jan 2012) Log Message Source/WebCore: [Skia] Switch FEColorMatrix to use a skia-based implementation when compiling with USE(SKIA). This change will also switch the software implementation of FEGaussianBlur to the skia implementation (ie., it removes the acceleration check). https://bugs.webkit.org/show_bug.cgi?id=75582 Reviewed by Dirk Schulze. Covered by svg/W3C-SVG-1.1/filters-color-01-b.svg and friends (will need a rebaseline). * WebCore.gypi: Add FEColorMatrixSkia.cpp to the build. * platform/graphics/filters/FEColorMatrix.h: Add platformApplySkia(). * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplySoftware): Remove skia-specific code from FEGaussianBlur::platformApplySoftware(). * platform/graphics/filters/FEGaussianBlur.h: Make platformApplySkia() virtual, and put it behind #if USE(SKIA). * platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::apply): Call out to platformApplySkia(), or fall back to platformApplySoftware(). * platform/graphics/filters/FilterEffect.h: Add platformApplySkia(). * platform/graphics/filters/skia/FEColorMatrixSkia.cpp: Added. (WebCore::saturateMatrix): (WebCore::hueRotateMatrix): (WebCore::luminanceToAlphaMatrix): (WebCore::FEColorMatrix::platformApplySkia): Process color matrix effect, by calling out to generic matrix version of SkColorMatrixFilter. * platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: (WebCore::FEGaussianBlur::platformApplySkia): Change the signature of FEGaussianBlur::platformApplySkia to be an override of the new FilterEffect base class version. LayoutTests: [chomium] Mark svg FEColorMatrix tests as needing new baselines. https://bugs.webkit.org/show_bug.cgi?id=75582 Reviewed by Dirk Schulze. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.h trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h trunk/Source/WebCore/platform/graphics/filters/FilterEffect.cpp trunk/Source/WebCore/platform/graphics/filters/FilterEffect.h trunk/Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkia.cpp Added Paths trunk/Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkia.cpp Diff Modified: trunk/LayoutTests/ChangeLog (104565 => 104566) --- trunk/LayoutTests/ChangeLog 2012-01-10 14:18:38 UTC (rev 104565) +++ trunk/LayoutTests/ChangeLog 2012-01-10 15:01:07 UTC (rev 104566) @@ -1,3 +1,12 @@ +2012-01-05 Stephen White senorbla...@chromium.org + +[chomium] Mark svg FEColorMatrix tests as needing new baselines. +https://bugs.webkit.org/show_bug.cgi?id=75582 + +Reviewed by Dirk Schulze. + +* platform/chromium/test_expectations.txt: + 2012-01-10 Csaba Osztrogonác o...@webkit.org Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104565 => 104566) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 14:18:38 UTC (rev 104565) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-10 15:01:07 UTC (rev 104566) @@ -934,6 +934,14 @@ BUGWK62974 : svg/custom/svg-fonts-with-no-element-reference.html = IMAGE+TEXT IMAGE BUGWK62974 MAC : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = IMAGE +BUGSENORBLANCO : svg/W3C-SVG-1.1/filters-color-01-b.svg = FAIL +BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr.html = FAIL +BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr.html = FAIL +BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr.html = FAIL +BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop.html = FAIL +BUGSENORBLANCO : svg/filters/feColorMatrix-offset.svg = FAIL +BUGSENORBLANCO : svg/filters/feColorMatrix-saturate.svg = FAIL + // - // End SVG Regressions // - Modified: trunk/Source/WebCore/ChangeLog (104565 => 104566) --- trunk/Source/WebCore/ChangeLog 2012-01-10 14:18:38 UTC (rev 104565) +++ trunk/Source/WebCore/ChangeLog 2012-01-10 15:01:07 UTC (rev 104566) @@ -1,3 +1,43 @@ +2012-01-06 Stephen White senorbla...@chromium.org + +[Skia] Switch FEColorMatrix to use a skia-based implementation when +compiling with USE(SKIA). This change will also switch the software +implementation of FEGaussianBlur to the skia implementation (ie., +it removes the acceleration check). +https://bugs.webkit.org/show_bug.cgi?id=75582 + +Reviewed by Dirk Schulze. + +Covered by
[webkit-changes] [104567] trunk/Source/WebKit2
Title: [104567] trunk/Source/WebKit2
Revision 104567
Author commit-qu...@webkit.org
Date 2012-01-10 07:14:05 -0800 (Tue, 10 Jan 2012)
Log Message
[Qt][WK2] Add font-related API tests for QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=75739
Patch by Rafael Brandao rafael.l...@openbossa.org on 2012-01-10
Reviewed by Zoltan Herczeg.
* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
* UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Added.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml
Added Paths
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/font-preferences.html
Diff
Modified: trunk/Source/WebKit2/ChangeLog (104566 => 104567)
--- trunk/Source/WebKit2/ChangeLog 2012-01-10 15:01:07 UTC (rev 104566)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-10 15:14:05 UTC (rev 104567)
@@ -1,3 +1,13 @@
+2012-01-10 Rafael Brandao rafael.l...@openbossa.org
+
+[Qt][WK2] Add font-related API tests for QWebPreferences
+https://bugs.webkit.org/show_bug.cgi?id=75739
+
+Reviewed by Zoltan Herczeg.
+
+* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
+* UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Added.
+
2012-01-10 Simon Hausmann simon.hausm...@nokia.com
[Qt] Fix failing WK2 layout tests after r104557
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml (104566 => 104567)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml 2012-01-10 15:01:07 UTC (rev 104566)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml 2012-01-10 15:14:05 UTC (rev 104567)
@@ -26,6 +26,66 @@
}
SignalSpy {
+id: titleSpy
+target: webView
+signalName: titleChanged
+}
+
+SignalSpy {
+id: standardFontFamilySpy
+target: webView.experimental.preferences
+signalName: standardFontFamilyChanged
+}
+
+SignalSpy {
+id: fixedFontFamilySpy
+target: webView.experimental.preferences
+signalName: fixedFontFamilyChanged
+}
+
+SignalSpy {
+id: serifFontFamilySpy
+target: webView.experimental.preferences
+signalName: serifFontFamilyChanged
+}
+
+SignalSpy {
+id: sansSerifFontFamilySpy
+target: webView.experimental.preferences
+signalName: sansSerifFontFamilyChanged
+}
+
+SignalSpy {
+id: cursiveFontFamilySpy
+target: webView.experimental.preferences
+signalName: cursiveFontFamilyChanged
+}
+
+SignalSpy {
+id: fantasyFontFamilySpy
+target: webView.experimental.preferences
+signalName: fantasyFontFamilyChanged
+}
+
+SignalSpy {
+id: minimumFontSizeSpy
+target: webView.experimental.preferences
+signalName: minimumFontSizeChanged
+}
+
+SignalSpy {
+id: defaultFontSizeSpy
+target: webView.experimental.preferences
+signalName: defaultFontSizeChanged
+}
+
+SignalSpy {
+id: defaultFixedFontSizeSpy
+target: webView.experimental.preferences
+signalName: defaultFixedFontSizeChanged
+}
+
+SignalSpy {
id: otherSpy
target: webView2
signalName: loadSucceeded
@@ -34,11 +94,65 @@
TestCase {
name: WebViewPreferences
+property bool shouldSetupFonts: true
+property string defaultStandardFontFamily
+property string defaultFixedFontFamily
+property string defaultSerifFontFamily
+property string defaultSansSerifFontFamily
+property string defaultCursiveFontFamily
+property string defaultFantasyFontFamily
+property int defaultMinimumFontSize
+property int defaultFontSize
+property int defaultFixedFontSize
+
function init() {
+if (shouldSetupFonts) {
+// Setup initial values (may be different per platform).
+shouldSetupFonts = false
+defaultStandardFontFamily = webView.experimental.preferences.standardFontFamily
+defaultFixedFontFamily = webView.experimental.preferences.fixedFontFamily
+defaultSerifFontFamily = webView.experimental.preferences.serifFontFamily
+defaultSansSerifFontFamily = webView.experimental.preferences.sansSerifFontFamily
+defaultCursiveFontFamily = webView.experimental.preferences.cursiveFontFamily
+defaultFantasyFontFamily =
[webkit-changes] [104568] trunk/Source/WebKit/efl
Title: [104568] trunk/Source/WebKit/efl
Revision 104568
Author commit-qu...@webkit.org
Date 2012-01-10 07:17:50 -0800 (Tue, 10 Jan 2012)
Log Message
[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
https://bugs.webkit.org/show_bug.cgi?id=75837
Patch by Tomasz Morawski t.moraw...@samsung.com on 2012-01-10
Reviewed by Ryosuke Niwa.
Changed graphicContext raw pointer to OwnPtr smart pointer.
Renamed cr to cairo and made it a RefPtr.
* ewk/ewk_view.cpp:
(ewk_view_paint_context_new): Adjust to auto pointers use.
(ewk_view_paint_context_free): Removed explicit raw pointers delete.
Adjust to auto pointers use:
(ewk_view_paint_context_save):
(ewk_view_paint_context_restore):
(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (104567 => 104568)
--- trunk/Source/WebKit/efl/ChangeLog 2012-01-10 15:14:05 UTC (rev 104567)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-01-10 15:17:50 UTC (rev 104568)
@@ -1,3 +1,23 @@
+2012-01-10 Tomasz Morawski t.moraw...@samsung.com
+
+[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
+https://bugs.webkit.org/show_bug.cgi?id=75837
+
+Reviewed by Ryosuke Niwa.
+
+Changed graphicContext raw pointer to OwnPtr smart pointer.
+Renamed cr to cairo and made it a RefPtr.
+
+* ewk/ewk_view.cpp:
+(ewk_view_paint_context_new): Adjust to auto pointers use.
+(ewk_view_paint_context_free): Removed explicit raw pointers delete.
+Adjust to auto pointers use:
+(ewk_view_paint_context_save):
+(ewk_view_paint_context_restore):
+(ewk_view_paint_context_clip):
+(ewk_view_paint_context_paint):
+(ewk_view_paint_context_paint_contents):
+
2012-01-09 Raphael Kubo da Costa k...@profusion.mobi
[EFL] Add getter for Ewk_JS_Object::view.
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (104567 => 104568)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2012-01-10 15:14:05 UTC (rev 104567)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2012-01-10 15:17:50 UTC (rev 104568)
@@ -2562,57 +2562,54 @@
* to define their own backing store.
*/
struct _Ewk_View_Paint_Context {
-WebCore::GraphicsContext* graphicContext;
WebCore::FrameView* view;
-cairo_t* cr;
+OwnPtrWebCore::GraphicsContext graphicContext;
+RefPtrcairo_t cairo;
};
-Ewk_View_Paint_Context* ewk_view_paint_context_new(Ewk_View_Private_Data* priv, cairo_t* cr)
+Ewk_View_Paint_Context* ewk_view_paint_context_new(Ewk_View_Private_Data* priv, cairo_t* cairo)
{
EINA_SAFETY_ON_NULL_RETURN_VAL(priv, 0);
-EINA_SAFETY_ON_NULL_RETURN_VAL(cr, 0);
+EINA_SAFETY_ON_NULL_RETURN_VAL(cairo, 0);
EINA_SAFETY_ON_NULL_RETURN_VAL(priv-mainFrame, 0);
-WebCore::FrameView* view = priv-mainFrame-view();
-EINA_SAFETY_ON_NULL_RETURN_VAL(view, 0);
-Ewk_View_Paint_Context* context = static_castEwk_View_Paint_Context*(malloc(sizeof(*context)));
-EINA_SAFETY_ON_NULL_RETURN_VAL(context, 0);
+EINA_SAFETY_ON_NULL_RETURN_VAL(priv-mainFrame-view(), 0);
-context-graphicContext = new WebCore::GraphicsContext(cr);
-if (!context-graphicContext) {
-free(context);
-return 0;
-}
-context-view = view;
-context-cr = cairo_reference(cr);
+Ewk_View_Paint_Context* context = new Ewk_View_Paint_Context;
+context-view = priv-mainFrame-view();
+context-graphicContext = adoptPtr(new WebCore::GraphicsContext(cairo));
+context-cairo = adoptRef(cairo_reference(cairo));
+
return context;
}
void ewk_view_paint_context_free(Ewk_View_Paint_Context* context)
{
EINA_SAFETY_ON_NULL_RETURN(context);
-delete context-graphicContext;
-cairo_destroy(context-cr);
-free(context);
+
+delete context;
}
void ewk_view_paint_context_save(Ewk_View_Paint_Context* context)
{
EINA_SAFETY_ON_NULL_RETURN(context);
-cairo_save(context-cr);
+
+cairo_save(context-cairo.get());
context-graphicContext-save();
}
void ewk_view_paint_context_restore(Ewk_View_Paint_Context* context)
{
EINA_SAFETY_ON_NULL_RETURN(context);
+
context-graphicContext-restore();
-cairo_restore(context-cr);
+cairo_restore(context-cairo.get());
}
void ewk_view_paint_context_clip(Ewk_View_Paint_Context* context, const Eina_Rectangle* area)
{
EINA_SAFETY_ON_NULL_RETURN(context);
EINA_SAFETY_ON_NULL_RETURN(area);
+
context-graphicContext-clip(WebCore::IntRect(area-x, area-y, area-w, area-h));
}
@@ -2625,7 +2622,7 @@
if (context-view-isTransparent())
context-graphicContext-clearRect(rect);
-context-view-paint(context-graphicContext, rect);
+context-view-paint(context-graphicContext.get(), rect);
}
void
[webkit-changes] [104569] trunk/Source/WebKit2
Title: [104569] trunk/Source/WebKit2
Revision 104569
Author kenn...@webkit.org
Date 2012-01-10 07:20:10 -0800 (Tue, 10 Jan 2012)
Log Message
WIP
Modified Paths
trunk/Source/WebKit2/Shared/EditorState.cpp
trunk/Source/WebKit2/Shared/EditorState.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebKit2/Shared/EditorState.cpp (104568 => 104569)
--- trunk/Source/WebKit2/Shared/EditorState.cpp 2012-01-10 15:17:50 UTC (rev 104568)
+++ trunk/Source/WebKit2/Shared/EditorState.cpp 2012-01-10 15:20:10 UTC (rev 104569)
@@ -44,7 +44,8 @@
#if PLATFORM(QT)
encoder-encode(cursorPosition);
encoder-encode(anchorPosition);
-encoder-encode(microFocus);
+encoder-encode(editorRect);
+encoder-encode(cursorRect);
encoder-encode(compositionRect);
encoder-encode(selectedText);
encoder-encode(surroundingText);
@@ -81,9 +82,12 @@
if (!decoder-decode(result.anchorPosition))
return false;
-if (!decoder-decode(result.microFocus))
+if (!decoder-decode(result.editorRect))
return false;
+if (!decoder-decode(result.cursorRect))
+return false;
+
if (!decoder-decode(result.compositionRect))
return false;
Modified: trunk/Source/WebKit2/Shared/EditorState.h (104568 => 104569)
--- trunk/Source/WebKit2/Shared/EditorState.h 2012-01-10 15:17:50 UTC (rev 104568)
+++ trunk/Source/WebKit2/Shared/EditorState.h 2012-01-10 15:20:10 UTC (rev 104569)
@@ -63,7 +63,8 @@
unsigned cursorPosition;
unsigned anchorPosition;
-WebCore::IntRect microFocus;
+WebCore::IntRect editorRect;
+WebCore::IntRect cursorRect;
WebCore::IntRect compositionRect;
WTF::String selectedText;
WTF::String surroundingText;
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (104568 => 104569)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-01-10 15:17:50 UTC (rev 104568)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-01-10 15:20:10 UTC (rev 104569)
@@ -924,7 +924,7 @@
switch(property) {
case Qt::ImCursorRectangle:
-return QRectF(state.microFocus);
+return QRectF(state.cursorRect);
case Qt::ImFont:
return QVariant();
case Qt::ImCursorPosition:
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp (104568 => 104569)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2012-01-10 15:17:50 UTC (rev 104568)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2012-01-10 15:20:10 UTC (rev 104569)
@@ -186,8 +186,9 @@
EditorState state = m_page-editorState();
#if PLATFORM(QT)
-if (Element* scope = frame-selection()-rootEditableElement())
-m_page-send(Messages::WebPageProxy::FocusEditableArea(state.microFocus, scope-getRect()));
+// FIXME: Move this to act on the vkb visibility change.
+if (state.isContentEditable)
+m_page-send(Messages::WebPageProxy::FocusEditableArea(state.cursorRect, state.editorRect));
#endif
m_page-send(Messages::WebPageProxy::EditorStateChanged(state));
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (104568 => 104569)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-01-10 15:17:50 UTC (rev 104568)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-01-10 15:20:10 UTC (rev 104569)
@@ -398,6 +398,9 @@
if (!scope)
return result;
+if (selectionRoot)
+result.editorRect = frame-view()-contentsToWindow(selectionRoot-getRect());
+
RefPtrRange range;
if (result.hasComposition (range = frame-editor()-compositionRange())) {
frame-editor()-getCompositionSelection(result.anchorPosition, result.cursorPosition);
@@ -415,7 +418,7 @@
}
if (range)
-result.microFocus = frame-view()-contentsToWindow(frame-editor()-firstRectForRange(range.get()));
+result.cursorRect = frame-view()-contentsToWindow(frame-editor()-firstRectForRange(range.get()));
// FIXME: We should only transfer innerText when it changes and do this on the UI side.
if (result.isContentEditable !result.isInPasswordField) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
