[webkit-changes] [104677] trunk/Source/WebKit/efl
Title: [104677] trunk/Source/WebKit/efl Revision 104677 Author commit-qu...@webkit.org Date 2012-01-11 00:19:24 -0800 (Wed, 11 Jan 2012) Log Message [EFL] Fix page rendering issue on ewk_view_tiled. https://bugs.webkit.org/show_bug.cgi?id=75686 Patch by KwangHyuk Kim hyuki@samsung.com on 2012-01-11 Reviewed by Andreas Kling. As for now the discard of ewk_tiled_backing_store doesn't reset its own contents size information and ewk_tiled_backing_store just ignores the request if new contents size change request would contain the same size compared to the one that it owns, contents size change request coming from ChromeClientEfl::contentsSizeChanged() API can be skipped and therefore web page can't be presented properly. In order to resolve this, I just add code to reset contents size information which ewk_tiled_backing_store owns when it discards its own data. * ewk/ewk_tiled_backing_store.cpp: (ewk_tiled_backing_store_flush): Modified Paths trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp Diff Modified: trunk/Source/WebKit/efl/ChangeLog (104676 => 104677) --- trunk/Source/WebKit/efl/ChangeLog 2012-01-11 07:53:21 UTC (rev 104676) +++ trunk/Source/WebKit/efl/ChangeLog 2012-01-11 08:19:24 UTC (rev 104677) @@ -1,3 +1,21 @@ +2012-01-11 KwangHyuk Kim hyuki@samsung.com + +[EFL] Fix page rendering issue on ewk_view_tiled. +https://bugs.webkit.org/show_bug.cgi?id=75686 + +Reviewed by Andreas Kling. + +As for now the discard of ewk_tiled_backing_store doesn't reset its own contents size information +and ewk_tiled_backing_store just ignores the request if new contents size change request would contain +the same size compared to the one that it owns, +contents size change request coming from ChromeClientEfl::contentsSizeChanged() API can be skipped +and therefore web page can't be presented properly. +In order to resolve this, I just add code to reset contents size information which ewk_tiled_backing_store owns +when it discards its own data. + +* ewk/ewk_tiled_backing_store.cpp: +(ewk_tiled_backing_store_flush): + 2012-01-10 Tomasz Morawski t.moraw...@samsung.com [EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring. Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp (104676 => 104677) --- trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp 2012-01-11 07:53:21 UTC (rev 104676) +++ trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp 2012-01-11 08:19:24 UTC (rev 104677) @@ -1821,6 +1821,8 @@ priv-model.current.rows = 1; priv-model.old.columns = 0; priv-model.old.rows = 0; +priv-model.width = 0; +priv-model.height = 0; priv-changed.size = true; #ifdef DEBUG_MEM_LEAKS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104678] trunk
Title: [104678] trunk Revision 104678 Author m...@apple.com Date 2012-01-11 00:38:29 -0800 (Wed, 11 Jan 2012) Log Message rdar://problem/10674686 Implement the font-kerning CSS property https://bugs.webkit.org/show_bug.cgi?id=76033 Reviewed by Darin Adler. Source/WebCore: Tests: fast/text/font-kerning-expected.html fast/text/font-kerning.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added code to handle font-kerning. * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Ditto. * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added mapping from FontDescription::Kerning. (WebCore::CSSPrimitiveValue::operator FontDescription::Kerning): Added mapping to FontDescription::Kerning. * css/CSSProperty.cpp: (WebCore::CSSProperty::isInheritedProperty): Added font-kerning to the set of inherited properties. * css/CSSPropertyNames.in: Added -webkit-font-kerning. * css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added a handler for font-kerning. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyDeclaration): Updated for the number of properties that affect the font. * platform/graphics/Font.h: (WebCore::Font::typesettingFeatures): Changed to enable kerning if font-kerning is set to normal, disable it if font-kerning is set to none, and leave it to the default (determined by the text-rendering property) if font-kerning is set to auto. * platform/graphics/FontDescription.h: (WebCore::FontDescription::FontDescription): Added a Kerning enum. (WebCore::FontDescription::kerning): Added this getter. (WebCore::FontDescription::setKerning): Added this setter. (WebCore::FontDescription::operator==): Updated to compare the m_kerning member. LayoutTests: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/text/font-kerning-expected.html: Added. * fast/text/font-kerning.html: Added. * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: * platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt trunk/LayoutTests/platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/CSSProperty.cpp trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/platform/graphics/Font.h trunk/Source/WebCore/platform/graphics/FontDescription.h Added Paths trunk/LayoutTests/fast/text/font-kerning-expected.html trunk/LayoutTests/fast/text/font-kerning.html Diff Modified: trunk/LayoutTests/ChangeLog (104677 => 104678) --- trunk/LayoutTests/ChangeLog 2012-01-11 08:19:24 UTC (rev 104677) +++ trunk/LayoutTests/ChangeLog 2012-01-11 08:38:29 UTC (rev 104678) @@ -1,3 +1,20 @@ +2012-01-11 Dan Bernstein m...@apple.com + +rdar://problem/10674686 Implement the font-kerning CSS property +https://bugs.webkit.org/show_bug.cgi?id=76033 + +Reviewed by Darin Adler. + +* fast/css/getComputedStyle/computed-style-expected.txt: +* fast/text/font-kerning-expected.html: Added. +* fast/text/font-kerning.html: Added. +* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: +* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* svg/css/getComputedStyle-basic-expected.txt: + 2012-01-10 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r104263 and r104381. Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (104677 => 104678) ---
[webkit-changes] [104679] trunk/LayoutTests
Title: [104679] trunk/LayoutTests
Revision 104679
Author ddkil...@apple.com
Date 2012-01-11 00:40:32 -0800 (Wed, 11 Jan 2012)
Log Message
Fix fast/spatial-navigation/snav-media-elements.html
http://webkit.org/b/76028
Reviewed by Daniel Bates.
* fast/spatial-navigation/snav-media-elements-expected.txt: Update
results.
* fast/spatial-navigation/snav-media-elements.html: Fix
test-complete code path by using js-test-post-async.js. Note
that the path to js-test-post.js was incorrect, so it was never
even loaded.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/spatial-navigation/snav-media-elements-expected.txt
trunk/LayoutTests/fast/spatial-navigation/snav-media-elements.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104678 => 104679)
--- trunk/LayoutTests/ChangeLog 2012-01-11 08:38:29 UTC (rev 104678)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 08:40:32 UTC (rev 104679)
@@ -1,3 +1,17 @@
+2012-01-11 David Kilzer ddkil...@apple.com
+
+Fix fast/spatial-navigation/snav-media-elements.html
+http://webkit.org/b/76028
+
+Reviewed by Daniel Bates.
+
+* fast/spatial-navigation/snav-media-elements-expected.txt: Update
+results.
+* fast/spatial-navigation/snav-media-elements.html: Fix
+test-complete code path by using js-test-post-async.js. Note
+that the path to js-test-post.js was incorrect, so it was never
+even loaded.
+
2012-01-11 Dan Bernstein m...@apple.com
rdar://problem/10674686 Implement the font-kerning CSS property
Modified: trunk/LayoutTests/fast/spatial-navigation/snav-media-elements-expected.txt (104678 => 104679)
--- trunk/LayoutTests/fast/spatial-navigation/snav-media-elements-expected.txt 2012-01-11 08:38:29 UTC (rev 104678)
+++ trunk/LayoutTests/fast/spatial-navigation/snav-media-elements-expected.txt 2012-01-11 08:40:32 UTC (rev 104679)
@@ -22,4 +22,7 @@
PASS gFocusedDocument.activeElement.getAttribute(id) is end
PASS gFocusedDocument.activeElement.getAttribute(id) is i8
PASS gFocusedDocument.activeElement.getAttribute(id) is end
+PASS successfullyParsed is true
+
+TEST COMPLETE
This tests that a media elements ie: Audio or video, without tabindex are able to be reached through keyboard access
Modified: trunk/LayoutTests/fast/spatial-navigation/snav-media-elements.html (104678 => 104679)
--- trunk/LayoutTests/fast/spatial-navigation/snav-media-elements.html 2012-01-11 08:38:29 UTC (rev 104678)
+++ trunk/LayoutTests/fast/spatial-navigation/snav-media-elements.html 2012-01-11 08:40:32 UTC (rev 104679)
@@ -38,14 +38,14 @@
function testCompleted()
{
- if (window.layoutTestController)
-layoutTestController.notifyDone();
+ var scriptElement = document.createElement(script)
+ scriptElement.src = ''
+ document.body.appendChild(scriptElement);
}
window._onload_ = runTest;
/script
-script src=""
/head
body id=some-content xmlns=http://www.w3.org/1999/xhtml
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104680] trunk/Source/WebKit
Title: [104680] trunk/Source/WebKit
Revision 104680
Author hausm...@webkit.org
Date 2012-01-11 01:02:18 -0800 (Wed, 11 Jan 2012)
Log Message
[Qt][WK2] Fix the build for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=75964
Patch by Rafael Brandao rafael.l...@openbossa.org on 2012-01-11
Reviewed by Simon Hausmann.
Source/WebKit:
* WebKit.pri: Added the new files to the buildsystem.
Source/WebKit/qt:
Added QHttpHeader, QHttpResponseHeader and QHttpRequestHeader
that were removed from Qt. They are now kept under a private header
and only the relevant code is present.
* Api/qhttpheader.cpp: Added.
(QHttpHeader::QHttpHeader):
(QHttpHeader::~QHttpHeader):
(QHttpHeader::parse):
(QHttpHeader::value):
(QHttpHeader::hasKey):
(QHttpHeader::setValue):
(QHttpHeader::addValue):
(QHttpHeader::parseLine):
(QHttpHeader::toString):
(QHttpHeader::hasContentLength):
(QHttpHeader::contentLength):
(QHttpHeader::setContentLength):
(QHttpHeader::hasContentType):
(QHttpHeader::contentType):
(QHttpHeader::setContentType):
(QHttpResponseHeader::QHttpResponseHeader):
(QHttpResponseHeader::parseLine):
(QHttpResponseHeader::toString):
(QHttpRequestHeader::QHttpRequestHeader):
(QHttpRequestHeader::parseLine):
(QHttpRequestHeader::toString):
* Api/qhttpheader_p.h: Added.
(QHttpHeader::isValid):
(QHttpHeader::setValid):
(QHttpResponseHeader::statusCode):
(QHttpResponseHeader::reasonPhrase):
(QHttpResponseHeader::majorVersion):
(QHttpResponseHeader::minorVersion):
(QHttpRequestHeader::method):
(QHttpRequestHeader::path):
(QHttpRequestHeader::majorVersion):
(QHttpRequestHeader::minorVersion):
* WebCoreSupport/InspectorServerQt.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.pri
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp
Added Paths
trunk/Source/WebKit/qt/Api/qhttpheader.cpp
trunk/Source/WebKit/qt/Api/qhttpheader_p.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (104679 => 104680)
--- trunk/Source/WebKit/ChangeLog 2012-01-11 08:40:32 UTC (rev 104679)
+++ trunk/Source/WebKit/ChangeLog 2012-01-11 09:02:18 UTC (rev 104680)
@@ -1,3 +1,12 @@
+2012-01-11 Rafael Brandao rafael.l...@openbossa.org
+
+[Qt][WK2] Fix the build for newer Qt5
+https://bugs.webkit.org/show_bug.cgi?id=75964
+
+Reviewed by Simon Hausmann.
+
+* WebKit.pri: Added the new files to the buildsystem.
+
2012-01-10 Mike Lattanzio mlattan...@rim.com
[BlackBerry] Fix assertion failure in BackingStore::blitContents
Modified: trunk/Source/WebKit/WebKit.pri (104679 => 104680)
--- trunk/Source/WebKit/WebKit.pri 2012-01-11 08:40:32 UTC (rev 104679)
+++ trunk/Source/WebKit/WebKit.pri 2012-01-11 09:02:18 UTC (rev 104680)
@@ -13,7 +13,8 @@
$$PWD/qt/Api/qwebscriptworld.cpp \
$$PWD/qt/Api/qwebdatabase.cpp \
$$PWD/qt/Api/qwebinspector.cpp \
-$$PWD/qt/Api/qwebkitversion.cpp
+$$PWD/qt/Api/qwebkitversion.cpp \
+$$PWD/qt/Api/qhttpheader.cpp
HEADERS += \
$$PWD/qt/Api/qwebframe.h \
@@ -32,5 +33,6 @@
$$PWD/qt/Api/qwebhistory.h \
$$PWD/qt/Api/qwebinspector.h \
$$PWD/qt/Api/qwebkitversion.h \
-$$PWD/qt/Api/qwebplugindatabase_p.h
+$$PWD/qt/Api/qwebplugindatabase_p.h \
+$$PWD/qt/Api/qhttpheader_p.h
Added: trunk/Source/WebKit/qt/Api/qhttpheader.cpp (0 => 104680)
--- trunk/Source/WebKit/qt/Api/qhttpheader.cpp (rev 0)
+++ trunk/Source/WebKit/qt/Api/qhttpheader.cpp 2012-01-11 09:02:18 UTC (rev 104680)
@@ -0,0 +1,273 @@
+/*
+Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies)
+
+These were part of the QtNetwork module of the Qt Toolkit.
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU Library General Public
+License as published by the Free Software Foundation; either
+version 2 of the License, or (at your option) any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+Library General Public License for more details.
+
+You should have received a copy of the GNU Library General Public License
+along with this library; see the file COPYING.LIB. If not, write to
+the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+Boston, MA 02110-1301, USA.
+*/
+
+#include config.h
+#include qhttpheader_p.h
+
+using namespace WebKit;
+
+static QString contentLengthString = QLatin1String(content-length);
+static QString contentTypeString = QLatin1String(content-type);
+
+QHttpHeader::QHttpHeader()
+{
+setValid(true);
+}
+
+QHttpHeader::QHttpHeader(const QString str)
+{
+setValid(true);
+parse(str);
+}
+
+QHttpHeader::~QHttpHeader()
+{
+}
+
+bool QHttpHeader::parse(const QString str)
+{
+QStringList lst;
+int pos = str.indexOf(QLatin1Char('\n'));
+if (pos 0
[webkit-changes] [104681] trunk/Source/WebKit/qt
Title: [104681] trunk/Source/WebKit/qt Revision 104681 Author hausm...@webkit.org Date 2012-01-11 01:02:35 -0800 (Wed, 11 Jan 2012) Log Message Unreviewed trivial build fix: Removed unnecessary QHttpRequestHeader inclusion (and the file is removed in newer Qt 5 versions). * Api/qwebpage.cpp: Modified Paths trunk/Source/WebKit/qt/Api/qwebpage.cpp trunk/Source/WebKit/qt/ChangeLog Diff Modified: trunk/Source/WebKit/qt/Api/qwebpage.cpp (104680 => 104681) --- trunk/Source/WebKit/qt/Api/qwebpage.cpp 2012-01-11 09:02:18 UTC (rev 104680) +++ trunk/Source/WebKit/qt/Api/qwebpage.cpp 2012-01-11 09:02:35 UTC (rev 104681) @@ -125,7 +125,6 @@ #include QDragMoveEvent #include QDropEvent #include QFileDialog -#include QHttpRequestHeader #include QInputDialog #include QMessageBox #include QNetworkProxy Modified: trunk/Source/WebKit/qt/ChangeLog (104680 => 104681) --- trunk/Source/WebKit/qt/ChangeLog 2012-01-11 09:02:18 UTC (rev 104680) +++ trunk/Source/WebKit/qt/ChangeLog 2012-01-11 09:02:35 UTC (rev 104681) @@ -1,3 +1,10 @@ +2012-01-11 Simon Hausmann simon.hausm...@nokia.com + +Unreviewed trivial build fix: Removed unnecessary QHttpRequestHeader +inclusion (and the file is removed in newer Qt 5 versions). + +* Api/qwebpage.cpp: + 2012-01-11 Rafael Brandao rafael.l...@openbossa.org [Qt][WK2] Fix the build for newer Qt5 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104682] trunk/LayoutTests
Title: [104682] trunk/LayoutTests
Revision 104682
Author apav...@chromium.org
Date 2012-01-11 01:16:11 -0800 (Wed, 11 Jan 2012)
Log Message
[Chromium] Unreviewed, add baselines for http/tests/media/video-buffering-repaints-controls.html
* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Copied from LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt.
* platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
* platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Renamed from LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/media/
trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/
trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt
trunk/LayoutTests/platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png
trunk/LayoutTests/platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt
Removed Paths
trunk/LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (104681 => 104682)
--- trunk/LayoutTests/ChangeLog 2012-01-11 09:02:35 UTC (rev 104681)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 09:16:11 UTC (rev 104682)
@@ -1,3 +1,14 @@
+2012-01-11 Alexander Pavlov apav...@chromium.org
+
+[Chromium] Unreviewed, add baselines for http/tests/media/video-buffering-repaints-controls.html
+
+* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
+* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
+* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
+* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Copied from LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt.
+* platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
+* platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Renamed from LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt.
+
2012-01-11 David Kilzer ddkil...@apple.com
Fix fast/spatial-navigation/snav-media-elements.html
Deleted: trunk/LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt (104681 => 104682)
--- trunk/LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt 2012-01-11 09:02:35 UTC (rev 104681)
+++ trunk/LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt 2012-01-11 09:16:11 UTC (rev 104682)
@@ -1,33 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x20
-RenderText {#text} at (0,0) size 538x19
- text run at (0,0) width 538: Test that media controls repaint correctly during paused states when new data is buffered.
- RenderBlock (anonymous) at (0,36) size 784x240
-RenderBR {BR} at (320,240) size 0x0
-layer at (8,44) size 320x240
- RenderVideo {VIDEO} at (0,0) size 320x240
-layer at (8,44) size 320x240
- RenderBlock (relative positioned) {DIV} at (0,0) size 320x240
-layer at (8,252) size 320x32
- RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,208) size 320x32 [bgcolor=#0099]
-layer at (15,258) size 18x19
- RenderButton {INPUT} at (7,6) size 18x19
-layer at (38,252) size 256x32
- RenderDeprecatedFlexibleBox (positioned) {DIV} at (30,0) size 256x32 [border: (1px solid #FF33) none (1px solid #FF33)]
-RenderSlider {INPUT} at (7,7) size 184x18 [color=#328CDF]
[webkit-changes] [104683] trunk/Source/WebCore
Title: [104683] trunk/Source/WebCore Revision 104683 Author zimmerm...@webkit.org Date 2012-01-11 01:16:16 -0800 (Wed, 11 Jan 2012) Log Message Large SVG text layout performance regression in r81168 https://bugs.webkit.org/show_bug.cgi?id=65711 Reviewed by Zoltan Herczeg. Introduce SVGTextMetricsBuilder, which will be used to speed-up measuring of SVG text, by using the simple code path, whenever possibly. It's not enabled yet, as it requires a restructurization of SVGTextLayoutAttributesBuilder - its the first chunk of a set of patches, that all together fix the performance regression and much more :-) Doesn't affect any tests, SVGTextMetricsBuilder is not turned on yet. * CMakeLists.txt: Add SVGTextMetricsBuilder.cpp/h to build. * GNUmakefile.list.am: Ditto. * Target.pri: Ditto. * WebCore.gypi: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * platform/graphics/Font.h: (WebCore::Font::codePath): Make it public, to be usable from SVGTextMetricsBuilder. * rendering/svg/RenderSVGAllInOne.cpp: Add SVGTextMetricsBuilder.cpp to build. * rendering/svg/RenderSVGText.cpp: * rendering/svg/RenderSVGText.h: * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): SVGTextMetrics::emptyMetrics() is gone, adapt code. * rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics): Ditto. (WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath): Ditto. * rendering/svg/SVGTextMetrics.cpp: (WebCore::SVGTextMetrics::SVGTextMetrics): Made public, now used in SVGTextLayoutEngine. (WebCore::SVGTextMetrics::constructTextRun): Move to public static function, to be usable from SVGTextMetricsBuilder. * rendering/svg/SVGTextMetrics.h: (WebCore::SVGTextMetrics::isEmpty): Add new isEmpty method, which replaces the == empyMetrics(). (WebCore::SVGTextMetrics::setWidth): Remove friendship with SVGTextLayoutAttributesBuilder, and make it public, to avoid another friendship. * rendering/svg/SVGTextMetricsBuilder.cpp: Added. (WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder): (WebCore::SVGTextMetricsBuilder::advance): (WebCore::SVGTextMetricsBuilder::advanceSimpleText): New variant using WidthIterator directly, this is finally possible as SVG Fonts have been integrated into the glyph pages concept a while ago. (WebCore::SVGTextMetricsBuilder::advanceComplexText): Complex code path, accounting for sum of glyph widths != run width. (WebCore::SVGTextMetricsBuilder::measureTextRenderer): Either measure the text renderer, or just figure out lastCharacter. (WebCore::SVGTextMetricsBuilder::walkTreeUntilSpecificLeafIsReached): Walks SVG text tree, correctly computing lastCharacter until the leaf is reached. (WebCore::SVGTextMetricsBuilder::measureAllCharactersOfRenderer): Use above method. * rendering/svg/SVGTextMetricsBuilder.h: Added. Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/Font.h trunk/Source/WebCore/rendering/svg/RenderSVGAllInOne.cpp trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp trunk/Source/WebCore/rendering/svg/RenderSVGText.h trunk/Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp trunk/Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp trunk/Source/WebCore/rendering/svg/SVGTextMetrics.cpp trunk/Source/WebCore/rendering/svg/SVGTextMetrics.h Added Paths trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (104682 => 104683) --- trunk/Source/WebCore/CMakeLists.txt 2012-01-11 09:16:11 UTC (rev 104682) +++ trunk/Source/WebCore/CMakeLists.txt 2012-01-11 09:16:16 UTC (rev 104683) @@ -1681,6 +1681,7 @@ rendering/svg/SVGTextLayoutEngineSpacing.cpp rendering/svg/SVGTextRunRenderingContext.cpp rendering/svg/SVGTextMetrics.cpp +rendering/svg/SVGTextMetricsBuilder.cpp rendering/svg/SVGTextQuery.cpp svg/ColorDistance.cpp svg/SVGAElement.cpp Modified: trunk/Source/WebCore/ChangeLog (104682 => 104683) --- trunk/Source/WebCore/ChangeLog 2012-01-11 09:16:11 UTC (rev 104682) +++ trunk/Source/WebCore/ChangeLog 2012-01-11 09:16:16 UTC (rev 104683) @@ -1,3 +1,49 @@ +2012-01-10 Nikolas Zimmermann nzimmerm...@rim.com + +Large SVG text layout performance regression in r81168 +https://bugs.webkit.org/show_bug.cgi?id=65711 + +Reviewed by Zoltan Herczeg. + +Introduce SVGTextMetricsBuilder, which will be used to speed-up measuring of SVG text, +by using the simple code path, whenever possibly. It's not enabled yet, as it requires +a restructurization of
[webkit-changes] [104684] trunk/Source/WebCore
Title: [104684] trunk/Source/WebCore
Revision 104684
Author hara...@chromium.org
Date 2012-01-11 01:24:56 -0800 (Wed, 11 Jan 2012)
Log Message
REGRESSION(r101445): [V8] Generated code for custom getters and setters
with the [Supplemental] IDL is wrong
https://bugs.webkit.org/show_bug.cgi?id=76034
Reviewed by Adam Barth.
This patch fixes the class name of the implementation of custom getters
and setters, as follows.
Previous V8TestInterface.cpp:
// Attribute 'supplementalStr3'
{supplementalStr3, V8TestSupplemental::supplementalStr3AccessorGetter, V8TestSupplemental::supplementalStr3AccessorSetter, ...},
New V8TestInterface.cpp:
// Attribute 'supplementalStr3'
{supplementalStr3, V8TestInterface::supplementalStr3AccessorGetter, V8TestInterface::supplementalStr3AccessorSetter, ...},
Test: bindings/scripts/test/TestInterface.idl
bindings/scripts/test/TestSupplemental.idl
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateSingleBatchedAttribute):
* bindings/scripts/test/V8/V8TestInterface.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104683 => 104684)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 09:16:16 UTC (rev 104683)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 09:24:56 UTC (rev 104684)
@@ -1,3 +1,29 @@
+2012-01-11 Kentaro Hara hara...@chromium.org
+
+REGRESSION(r101445): [V8] Generated code for custom getters and setters
+with the [Supplemental] IDL is wrong
+https://bugs.webkit.org/show_bug.cgi?id=76034
+
+Reviewed by Adam Barth.
+
+This patch fixes the class name of the implementation of custom getters
+and setters, as follows.
+
+Previous V8TestInterface.cpp:
+// Attribute 'supplementalStr3'
+{supplementalStr3, V8TestSupplemental::supplementalStr3AccessorGetter, V8TestSupplemental::supplementalStr3AccessorSetter, ...},
+
+New V8TestInterface.cpp:
+// Attribute 'supplementalStr3'
+{supplementalStr3, V8TestInterface::supplementalStr3AccessorGetter, V8TestInterface::supplementalStr3AccessorSetter, ...},
+
+Test: bindings/scripts/test/TestInterface.idl
+ bindings/scripts/test/TestSupplemental.idl
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateSingleBatchedAttribute):
+* bindings/scripts/test/V8/V8TestInterface.cpp:
+
2012-01-10 Nikolas Zimmermann nzimmerm...@rim.com
Large SVG text layout performance regression in r81168
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (104683 => 104684)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-01-11 09:16:16 UTC (rev 104683)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-01-11 09:24:56 UTC (rev 104684)
@@ -1931,12 +1931,7 @@
;
if ($customAccessor eq 1) {
# use the naming convension, interface + (capitalize) attr name
-if ($attribute-signature-extendedAttributes-{ImplementedBy}) {
-$customAccessor = $attribute-signature-extendedAttributes-{ImplementedBy} . :: . $attrName;
-AddToImplIncludes(V8 . $attribute-signature-extendedAttributes-{ImplementedBy} . .h);
-} else {
-$customAccessor = $interfaceName . :: . $attrName;
-}
+$customAccessor = $interfaceName . :: . $attrName;
}
my $getter;
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp (104683 => 104684)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp 2012-01-11 09:16:16 UTC (rev 104683)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp 2012-01-11 09:24:56 UTC (rev 104684)
@@ -33,7 +33,6 @@
#include V8IsolatedContext.h
#include V8Proxy.h
#include V8TestObj.h
-#include V8TestSupplemental.h
#include wtf/GetPtr.h
#include wtf/RefCounted.h
#include wtf/RefPtr.h
@@ -134,7 +133,7 @@
#endif // ENABLE(Condition11) || ENABLE(Condition12)
#if ENABLE(Condition11) || ENABLE(Condition12)
// Attribute 'supplementalStr3' (Type: 'attribute' ExtAttr: 'CustomSetter CustomGetter Conditional ImplementedBy')
-{supplementalStr3, V8TestSupplemental::supplementalStr3AccessorGetter, V8TestSupplemental::supplementalStr3AccessorSetter, 0 /* no data */, static_castv8::AccessControl(v8::DEFAULT), static_castv8::PropertyAttribute(v8::None), 0 /* on instance */},
+{supplementalStr3, V8TestInterface::supplementalStr3AccessorGetter, V8TestInterface::supplementalStr3AccessorSetter, 0 /* no data */, static_castv8::AccessControl(v8::DEFAULT), static_castv8::PropertyAttribute(v8::None), 0 /* on instance */},
#endif // ENABLE(Condition11) || ENABLE(Condition12)
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [104685] trunk/LayoutTests
Title: [104685] trunk/LayoutTests Revision 104685 Author apav...@chromium.org Date 2012-01-11 01:26:22 -0800 (Wed, 11 Jan 2012) Log Message [Chromium] Unreviewed, rebaseline fast/css/getComputedStyle/computed-style.html after r104678. * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104684 => 104685) --- trunk/LayoutTests/ChangeLog 2012-01-11 09:24:56 UTC (rev 104684) +++ trunk/LayoutTests/ChangeLog 2012-01-11 09:26:22 UTC (rev 104685) @@ -1,5 +1,11 @@ 2012-01-11 Alexander Pavlov apav...@chromium.org +[Chromium] Unreviewed, rebaseline fast/css/getComputedStyle/computed-style.html after r104678. + +* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: + +2012-01-11 Alexander Pavlov apav...@chromium.org + [Chromium] Unreviewed, add baselines for http/tests/media/video-buffering-repaints-controls.html * platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added. Modified: trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt (104684 => 104685) --- trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt 2012-01-11 09:24:56 UTC (rev 104684) +++ trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt 2012-01-11 09:26:22 UTC (rev 104685) @@ -148,6 +148,7 @@ -webkit-flex-direction: row; -webkit-flex-flow: row nowrap; -webkit-flex-wrap: nowrap; +-webkit-font-kerning: auto; -webkit-font-smoothing: auto; -webkit-highlight: none; -webkit-hyphenate-character: auto; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104686] trunk/Source/WebCore
Title: [104686] trunk/Source/WebCore
Revision 104686
Author zimmerm...@webkit.org
Date 2012-01-11 02:04:26 -0800 (Wed, 11 Jan 2012)
Log Message
2012-01-11 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Fix release builds.
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104685 => 104686)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 09:26:22 UTC (rev 104685)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 10:04:26 UTC (rev 104686)
@@ -1,3 +1,10 @@
+2012-01-11 Nikolas Zimmermann nzimmerm...@rim.com
+
+Not reviewed. Fix release builds.
+
+* rendering/svg/SVGTextMetricsBuilder.cpp:
+(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
+
2012-01-11 Kentaro Hara hara...@chromium.org
REGRESSION(r101445): [V8] Generated code for custom getters and setters
Modified: trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp (104685 => 104686)
--- trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp 2012-01-11 09:26:22 UTC (rev 104685)
+++ trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp 2012-01-11 10:04:26 UTC (rev 104686)
@@ -107,10 +107,9 @@
m_totalWidth = m_complexStartToCurrentMetrics.width();
}
-void SVGTextMetricsBuilder::measureTextRenderer(RenderSVGInlineText* text, const UChar* lastCharacter, VectorSVGTextMetrics* textMetricsValues)
+void SVGTextMetricsBuilder::measureTextRenderer(RenderSVGInlineText*, const UChar* lastCharacter, VectorSVGTextMetrics* textMetricsValues)
{
-ASSERT(text);
-ASSERT(textMetricsValues-isEmpty());
+ASSERT(textMetricsValues ? textMetricsValues-isEmpty() : true);
while (!m_finished) {
advance();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104687] trunk/Source/WebKit/efl
Title: [104687] trunk/Source/WebKit/efl
Revision 104687
Author commit-qu...@webkit.org
Date 2012-01-11 02:05:48 -0800 (Wed, 11 Jan 2012)
Log Message
[EFL] Refactor single backing store scroll code.
https://bugs.webkit.org/show_bug.cgi?id=75243
Patch by JungJik Lee jungjik@samsung.com on 2012-01-11
Reviewed by Zoltan Herczeg.
Remove the duplicated code and refactor the scroll procedure.
Wherever the page is scrolled, there are one screen copy and two updates.
This patch optimises the scroll procedure by less calculation.
* ewk/ewk_view_single.cpp:
(_ewk_view_screen_move):
(_ewk_view_single_scroll_process_single):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (104686 => 104687)
--- trunk/Source/WebKit/efl/ChangeLog 2012-01-11 10:04:26 UTC (rev 104686)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-01-11 10:05:48 UTC (rev 104687)
@@ -1,3 +1,18 @@
+2012-01-11 JungJik Lee jungjik@samsung.com
+
+[EFL] Refactor single backing store scroll code.
+https://bugs.webkit.org/show_bug.cgi?id=75243
+
+Reviewed by Zoltan Herczeg.
+
+Remove the duplicated code and refactor the scroll procedure.
+Wherever the page is scrolled, there are one screen copy and two updates.
+This patch optimises the scroll procedure by less calculation.
+
+* ewk/ewk_view_single.cpp:
+(_ewk_view_screen_move):
+(_ewk_view_single_scroll_process_single):
+
2012-01-11 KwangHyuk Kim hyuki@samsung.com
[EFL] Fix page rendering issue on ewk_view_tiled.
Modified: trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp (104686 => 104687)
--- trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp 2012-01-11 10:04:26 UTC (rev 104686)
+++ trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp 2012-01-11 10:05:48 UTC (rev 104687)
@@ -88,115 +88,29 @@
}
}
-static inline void _ewk_view_4b_move_region_up(uint32_t* image, size_t rows, size_t x, size_t y, size_t width, size_t height, size_t rowSize)
+static inline void _ewk_view_screen_move(uint32_t* image, size_t destinationX, size_t destinationY, size_t sourceX, size_t sourceY, size_t copyWidth, size_t copyHeight, size_t frameWidth)
{
-uint32_t* source;
-uint32_t* destination;
+uint32_t* sourceBegin = image + (frameWidth * sourceY) + sourceX;
+uint32_t* destinationBegin = image + (frameWidth * destinationY) + destinationX;
-destination = image + x + y * rowSize;
-source = destination + rows * rowSize;
-height -= rows;
+size_t copyLength = copyWidth * 4;
+const int moveLineUpDown = sourceY = destinationY ? 1 : -1;
+int startHeight = sourceY = destinationY ? 0 : copyHeight - 1;
-for (; height 0; height--, destination += rowSize, source += rowSize)
-memcpy(destination, source, width * 4);
-}
-
-static inline void _ewk_view_4b_move_region_down(uint32_t* image, size_t rows, size_t x, size_t y, size_t width, size_t height, size_t rowSize)
-{
-uint32_t* source;
-uint32_t* destination;
-
-height -= rows;
-source = image + x + (y + height - 1) * rowSize;
-destination = source + rows * rowSize;
-
-for (; height 0; height--, destination -= rowSize, source -= rowSize)
-memcpy(destination, source, width * 4);
-}
-
-static inline void _ewk_view_4b_move_line_left(uint32_t* destination, const uint32_t* source, size_t count)
-{
-uint32_t* endOfDestination = destination + count;
-/* no memcpy() as it does not allow overlapping regions */
-/* no memmove() as it will copy to a temporary buffer */
-/* TODO: loop unrolling, copying up to quad-words would help */
-for (; destination endOfDestination; destination++, source++)
-*destination = *source;
-}
-
-static inline void _ewk_view_4b_move_line_right(uint32_t* destination, uint32_t* source, size_t count)
-{
-uint32_t* endOfDestination = destination - count;
-/* no memcpy() as it does not allow overlapping regions */
-/* no memmove() as it will copy to a temporary buffer */
-/* TODO: loop unrolling, copying up to quad-words would help */
-for (; destination endOfDestination; destination--, source--)
-*destination = *source;
-}
-
-static inline void _ewk_view_4b_move_region_left(uint32_t* image, size_t columns, size_t x, size_t y, size_t width, size_t height, size_t rowSize)
-{
-uint32_t* source;
-uint32_t* destination;
-
-destination = image + x + y * rowSize;
-source = destination + columns;
-width -= columns;
-
-for (; height 0; height--, destination += rowSize, source += rowSize)
-_ewk_view_4b_move_line_left(destination, source, width);
-}
-
-static inline void _ewk_view_4b_move_region_right(uint32_t* image, size_t columns, size_t x, size_t y, size_t width, size_t height, size_t rowSize)
-{
-uint32_t* source;
-uint32_t* destination;
-
-width -= columns;
-source = image + (x + width -
[webkit-changes] [104688] trunk/Source/WebCore
Title: [104688] trunk/Source/WebCore
Revision 104688
Author zherc...@webkit.org
Date 2012-01-11 02:11:55 -0800 (Wed, 11 Jan 2012)
Log Message
Fix more style errors in CSSParser.cpp (followup patch)
https://bugs.webkit.org/show_bug.cgi?id=76038
Reviewed by Nikolas Zimmermann.
The previous was: http://trac.webkit.org/changeset/104576
This patch mostly contains C cast to static_cast rewrites.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::ShadowParseContext::commitLength):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::parseDeprecatedGradientPoint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104687 => 104688)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 10:05:48 UTC (rev 104687)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 10:11:55 UTC (rev 104688)
@@ -1,3 +1,23 @@
+2012-01-11 Zoltan Herczeg zherc...@webkit.org
+
+Fix more style errors in CSSParser.cpp (followup patch)
+https://bugs.webkit.org/show_bug.cgi?id=76038
+
+Reviewed by Nikolas Zimmermann.
+
+The previous was: http://trac.webkit.org/changeset/104576
+This patch mostly contains C cast to static_cast rewrites.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseValue):
+(WebCore::CSSParser::parseBackgroundColor):
+(WebCore::ShadowParseContext::commitLength):
+(WebCore::BorderImageSliceParseContext::commitNumber):
+(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
+(WebCore::BorderImageQuadParseContext::commitNumber):
+(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
+(WebCore::parseDeprecatedGradientPoint):
+
2012-01-11 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Fix release builds.
Modified: trunk/Source/WebCore/css/CSSParser.cpp (104687 => 104688)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-01-11 10:05:48 UTC (rev 104687)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-01-11 10:11:55 UTC (rev 104688)
@@ -1037,7 +1037,7 @@
case CSSPropertyClear:// none | left | right | both | inherit
if (id == CSSValueNone || id == CSSValueLeft
-|| id == CSSValueRight|| id == CSSValueBoth)
+|| id == CSSValueRight || id == CSSValueBoth)
validPrimitive = true;
break;
@@ -2883,7 +2883,7 @@
int id = m_valueList-current()-id;
if (id == CSSValueWebkitText || (id = CSSValueAqua id = CSSValueWindowtext) || id == CSSValueMenu || id == CSSValueCurrentcolor ||
(id = CSSValueGrey id CSSValueWebkitText !m_strict))
- return cssValuePool()-createIdentifierValue(id);
+return cssValuePool()-createIdentifierValue(id);
return parseColor();
}
@@ -5054,7 +5054,7 @@
void commitLength(CSSParserValue* v)
{
-RefPtrCSSPrimitiveValue val = m_cssValuePool-createValue(v-fValue, (CSSPrimitiveValue::UnitTypes)v-unit);
+RefPtrCSSPrimitiveValue val = m_cssValuePool-createValue(v-fValue, static_castCSSPrimitiveValue::UnitTypes(v-unit));
if (allowX) {
x = val.release();
@@ -5512,7 +5512,7 @@
void commitNumber(CSSParserValue* v)
{
-RefPtrCSSPrimitiveValue val = m_cssValuePool-createValue(v-fValue, (CSSPrimitiveValue::UnitTypes)v-unit);
+RefPtrCSSPrimitiveValue val = m_cssValuePool-createValue(v-fValue, static_castCSSPrimitiveValue::UnitTypes(v-unit));
if (!m_top)
m_top = val;
else if (!m_right)
@@ -5539,16 +5539,16 @@
// We need to clone and repeat values for any omissions.
ASSERT(m_top);
if (!m_right) {
-m_right = m_cssValuePool-createValue(m_top-getDoubleValue(), (CSSPrimitiveValue::UnitTypes)m_top-primitiveType());
-m_bottom = m_cssValuePool-createValue(m_top-getDoubleValue(), (CSSPrimitiveValue::UnitTypes)m_top-primitiveType());
-m_left = m_cssValuePool-createValue(m_top-getDoubleValue(), (CSSPrimitiveValue::UnitTypes)m_top-primitiveType());
+m_right = m_cssValuePool-createValue(m_top-getDoubleValue(), static_castCSSPrimitiveValue::UnitTypes(m_top-primitiveType()));
+m_bottom = m_cssValuePool-createValue(m_top-getDoubleValue(), static_castCSSPrimitiveValue::UnitTypes(m_top-primitiveType()));
+m_left = m_cssValuePool-createValue(m_top-getDoubleValue(), static_castCSSPrimitiveValue::UnitTypes(m_top-primitiveType()));
}
if (!m_bottom) {
-m_bottom = m_cssValuePool-createValue(m_top-getDoubleValue(), (CSSPrimitiveValue::UnitTypes)m_top-primitiveType());
-m_left =
[webkit-changes] [104690] trunk/Source/WebCore
Title: [104690] trunk/Source/WebCore
Revision 104690
Author hara...@chromium.org
Date 2012-01-11 02:24:51 -0800 (Wed, 11 Jan 2012)
Log Message
ShouldSkipTypeInHeader() and ShouldSkipTypeInImplementation() should be the same
https://bugs.webkit.org/show_bug.cgi?id=76030
Reviewed by Adam Barth.
Because the attributes/methods that do not appear in the implementation
do not need to appear in the header.
Tests: bindings/scripts/test/TestCallback.idl
bindings/scripts/test/TestObj.idl
* bindings/scripts/CodeGeneratorCPP.pm:
(ShouldSkipType): Renamed from ShouldSkipTypeInImplementation().
(GenerateHeader): Replaced ShouldSkipTypeInImplementation() with ShouldSkipType(),
and replaced ShouldSkipTypeInHeader() with ShouldSkipType().
(GenerateImplementation): Ditto.
* bindings/scripts/test/CPP/WebDOMTestCallback.h: Updated the test result.
* bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestCallback.h
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104689 => 104690)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 10:14:44 UTC (rev 104689)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 10:24:51 UTC (rev 104690)
@@ -1,3 +1,24 @@
+2012-01-11 Kentaro Hara hara...@chromium.org
+
+ShouldSkipTypeInHeader() and ShouldSkipTypeInImplementation() should be the same
+https://bugs.webkit.org/show_bug.cgi?id=76030
+
+Reviewed by Adam Barth.
+
+Because the attributes/methods that do not appear in the implementation
+do not need to appear in the header.
+
+Tests: bindings/scripts/test/TestCallback.idl
+ bindings/scripts/test/TestObj.idl
+
+* bindings/scripts/CodeGeneratorCPP.pm:
+(ShouldSkipType): Renamed from ShouldSkipTypeInImplementation().
+(GenerateHeader): Replaced ShouldSkipTypeInImplementation() with ShouldSkipType(),
+and replaced ShouldSkipTypeInHeader() with ShouldSkipType().
+(GenerateImplementation): Ditto.
+* bindings/scripts/test/CPP/WebDOMTestCallback.h: Updated the test result.
+* bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
+
2012-01-11 Zoltan Herczeg zherc...@webkit.org
Fix more style errors in CSSParser.cpp (followup patch)
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm (104689 => 104690)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm 2012-01-11 10:14:44 UTC (rev 104689)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm 2012-01-11 10:24:51 UTC (rev 104690)
@@ -192,7 +192,7 @@
return $parent;
}
-sub ShouldSkipTypeInImplementation
+sub ShouldSkipType
{
my $typeInfo = shift;
@@ -210,21 +210,6 @@
return 0;
}
-sub ShouldSkipTypeInHeader
-{
-my $typeInfo = shift;
-
-# FIXME: We currently ignore any attribute/function needing custom code
-return 1 if $typeInfo-signature-extendedAttributes-{CustomArgumentHandling}
- or $typeInfo-signature-extendedAttributes-{CustomGetter};
-
-# FIXME: We don't generate bindings for SVG related interfaces yet
-return 1 if $typeInfo-signature-name =~ /getSVGDocument/;
-
-return 1 if $typeInfo-signature-name =~ /Constructor/;
-return 0;
-}
-
sub GetCPPType
{
my $type = shift;
@@ -443,7 +428,7 @@
# - Add attribute getters/setters.
if ($numAttributes 0) {
foreach my $attribute (@{$dataNode-attributes}) {
-next if ShouldSkipTypeInHeader($attribute);
+next if ShouldSkipType($attribute);
my $attributeConditionalString = GenerateConditionalString($attribute-signature);
my $attributeName = $attribute-signature-name;
@@ -482,7 +467,7 @@
# - Add functions.
if ($numFunctions 0) {
foreach my $function (@{$dataNode-functions}) {
-next if ShouldSkipTypeInHeader($function);
+next if ShouldSkipType($function);
my $functionName = $function-signature-name;
my $returnType = GetCPPType($function-signature-type, 0);
@@ -694,7 +679,7 @@
# - Attributes
if ($numAttributes 0) {
foreach my $attribute (@{$dataNode-attributes}) {
-next if ShouldSkipTypeInImplementation($attribute);
+next if ShouldSkipType($attribute);
AddIncludesForType($attribute-signature-type);
my $idlType = $codeGenerator-StripModule($attribute-signature-type);
@@ -805,7 +790,7 @@
if ($numFunctions 0) {
foreach my $function (@{$dataNode-functions}) {
# Treat PureInterface as Custom as well, since the WebCore versions will take a script context as well
-next if ShouldSkipTypeInImplementation($function) || $dataNode-extendedAttributes-{PureInterface};
+next if ShouldSkipType($function)
[webkit-changes] [104692] trunk/Tools
Title: [104692] trunk/Tools
Revision 104692
Author t...@chromium.org
Date 2012-01-11 02:49:51 -0800 (Wed, 11 Jan 2012)
Log Message
Don't remove 0 byte files when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=75997
Reviewed by Csaba Osztrogonác.
If QTDIR is set, isQt() is true even when running build-webkit --chromium.
* Scripts/webkitdirs.pm:
(determineIsQt):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (104691 => 104692)
--- trunk/Tools/ChangeLog 2012-01-11 10:41:57 UTC (rev 104691)
+++ trunk/Tools/ChangeLog 2012-01-11 10:49:51 UTC (rev 104692)
@@ -1,3 +1,15 @@
+2012-01-11 Tony Chang t...@chromium.org
+
+Don't remove 0 byte files when running build-webkit --chromium
+https://bugs.webkit.org/show_bug.cgi?id=75997
+
+Reviewed by Csaba Osztrogonác.
+
+If QTDIR is set, isQt() is true even when running build-webkit --chromium.
+
+* Scripts/webkitdirs.pm:
+(determineIsQt):
+
2012-01-10 David Kilzer ddkil...@apple.com
Add TestWebKitAPI tests for KURL
Modified: trunk/Tools/Scripts/webkitdirs.pm (104691 => 104692)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-01-11 10:41:57 UTC (rev 104691)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-01-11 10:49:51 UTC (rev 104692)
@@ -876,8 +876,8 @@
return;
}
-# The presence of QTDIR only means Qt if --gtk or --wx or --efl or --blackberry are not on the command-line
-if (isGtk() || isWx() || isEfl() || isBlackBerry()) {
+# The presence of QTDIR only means Qt if --gtk or --wx or --efl or --blackberry or --chromium are not on the command-line
+if (isGtk() || isWx() || isEfl() || isBlackBerry() || isChromium()) {
$isQt = 0;
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104693] trunk/Websites/webkit.org
Title: [104693] trunk/Websites/webkit.org Revision 104693 Author an...@apple.com Date 2012-01-11 02:51:16 -0800 (Wed, 11 Jan 2012) Log Message Remove S60 reference from webkit.org https://bugs.webkit.org/show_bug.cgi?id=76044 Reviewed by Simon Hausmann. There is no S60. * index.html: Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/index.html Diff Modified: trunk/Websites/webkit.org/ChangeLog (104692 => 104693) --- trunk/Websites/webkit.org/ChangeLog 2012-01-11 10:49:51 UTC (rev 104692) +++ trunk/Websites/webkit.org/ChangeLog 2012-01-11 10:51:16 UTC (rev 104693) @@ -1,3 +1,14 @@ +2012-01-11 Antti Koivisto an...@apple.com + +Remove S60 reference from webkit.org +https://bugs.webkit.org/show_bug.cgi?id=76044 + +Reviewed by Simon Hausmann. + +There is no S60. + +* index.html: + 2012-01-10 Hajime Morrita morr...@chromium.org [Website] i-Bench is no longer available. Modified: trunk/Websites/webkit.org/index.html (104692 => 104693) --- trunk/Websites/webkit.org/index.html 2012-01-11 10:49:51 UTC (rev 104692) +++ trunk/Websites/webkit.org/index.html 2012-01-11 10:51:16 UTC (rev 104693) @@ -11,7 +11,7 @@ pWebKit is an open source web browser engine. WebKit is also the name of the Mac OS X system framework version of the engine that's used by a href="" Dashboard, Mail, and many other OS X applications. WebKit's HTML and _javascript_ code began as a branch of the a href="" and KJS libraries from a href="" -This website is also the home of a href="" a href="" WebKit development/a./p +/p h2Getting involved/h2 a href="" src="" id=download alt=download nightly width=189 height=65/a ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104694] trunk/Source
Title: [104694] trunk/Source
Revision 104694
Author joc...@chromium.org
Date 2012-01-11 02:58:00 -0800 (Wed, 11 Jan 2012)
Log Message
Move the check for canExecuteScripts out of V8Proxy::retrieve
https://bugs.webkit.org/show_bug.cgi?id=75533
Reviewed by Adam Barth.
Source/WebCore:
This change doesn't move the check to custom/generated bindings for
individual objects, as these won't get executed if scripts are disabled
anyway.
No new tests. No functional change.
* bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/v8/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::callListenerFunction):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::callListenerFunction):
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::V8Proxy::retrieve):
(WebCore::toV8Context):
Source/WebKit/chromium:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didClearWindowObject):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/PageScriptDebugServer.cpp
trunk/Source/WebCore/bindings/v8/ScheduledAction.cpp
trunk/Source/WebCore/bindings/v8/ScriptCachedFrameData.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp
trunk/Source/WebCore/bindings/v8/V8EventListener.cpp
trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104693 => 104694)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 10:51:16 UTC (rev 104693)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 10:58:00 UTC (rev 104694)
@@ -1,3 +1,34 @@
+2012-01-11 Jochen Eisinger joc...@chromium.org
+
+Move the check for canExecuteScripts out of V8Proxy::retrieve
+https://bugs.webkit.org/show_bug.cgi?id=75533
+
+Reviewed by Adam Barth.
+
+This change doesn't move the check to custom/generated bindings for
+individual objects, as these won't get executed if scripts are disabled
+anyway.
+
+No new tests. No functional change.
+
+* bindings/v8/PageScriptDebugServer.cpp:
+(WebCore::PageScriptDebugServer::addListener):
+* bindings/v8/ScheduledAction.cpp:
+(WebCore::ScheduledAction::execute):
+* bindings/v8/ScriptCachedFrameData.cpp:
+(WebCore::ScriptCachedFrameData::restore):
+* bindings/v8/V8DOMWrapper.cpp:
+(WebCore::V8DOMWrapper::instantiateV8Object):
+* bindings/v8/V8EventListener.cpp:
+(WebCore::V8EventListener::callListenerFunction):
+* bindings/v8/V8LazyEventListener.cpp:
+(WebCore::V8LazyEventListener::callListenerFunction):
+(WebCore::V8LazyEventListener::prepareListenerObject):
+* bindings/v8/V8Proxy.cpp:
+(WebCore::V8Proxy::handleOutOfMemory):
+(WebCore::V8Proxy::retrieve):
+(WebCore::toV8Context):
+
2012-01-11 Kentaro Hara hara...@chromium.org
ShouldSkipTypeInHeader() and ShouldSkipTypeInImplementation() should be the same
Modified: trunk/Source/WebCore/bindings/v8/PageScriptDebugServer.cpp (104693 => 104694)
--- trunk/Source/WebCore/bindings/v8/PageScriptDebugServer.cpp 2012-01-11 10:51:16 UTC (rev 104693)
+++ trunk/Source/WebCore/bindings/v8/PageScriptDebugServer.cpp 2012-01-11 10:58:00 UTC (rev 104694)
@@ -76,9 +76,10 @@
void PageScriptDebugServer::addListener(ScriptDebugListener* listener, Page* page)
{
+ScriptController* scriptController = page-mainFrame()-script();
+if (!scriptController-canExecuteScripts(NotAboutToExecuteScript))
+return;
V8Proxy* proxy = V8Proxy::retrieve(page-mainFrame());
-if (!proxy)
-return;
v8::HandleScope scope;
v8::Localv8::Context debuggerContext = v8::Debug::GetDebugContext();
Modified: trunk/Source/WebCore/bindings/v8/ScheduledAction.cpp (104693 => 104694)
--- trunk/Source/WebCore/bindings/v8/ScheduledAction.cpp 2012-01-11 10:51:16 UTC (rev 104693)
+++ trunk/Source/WebCore/bindings/v8/ScheduledAction.cpp 2012-01-11 10:58:00 UTC (rev 104694)
@@ -94,15 +94,20 @@
void ScheduledAction::execute(ScriptExecutionContext* context)
{
-V8Proxy* proxy = V8Proxy::retrieve(context);
-if (proxy)
+if (context-isDocument()) {
+Frame* frame = static_castDocument*(context)-frame();
+ScriptController* scriptController = frame-script();
+if (!scriptController-canExecuteScripts(NotAboutToExecuteScript))
+return;
+V8Proxy* proxy = V8Proxy::retrieve(frame);
execute(proxy);
+}
#if ENABLE(WORKERS)
-else if
[webkit-changes] [104695] trunk/LayoutTests
Title: [104695] trunk/LayoutTests Revision 104695 Author apav...@chromium.org Date 2012-01-11 03:27:58 -0800 (Wed, 11 Jan 2012) Log Message [Chromium] Unreviewed, mark http/tests/media/video-buffering-repaints-controls.html as timing out on Leopard. https://bugs.webkit.org/show_bug.cgi?id=75570 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104694 => 104695) --- trunk/LayoutTests/ChangeLog 2012-01-11 10:58:00 UTC (rev 104694) +++ trunk/LayoutTests/ChangeLog 2012-01-11 11:27:58 UTC (rev 104695) @@ -1,5 +1,12 @@ 2012-01-11 Alexander Pavlov apav...@chromium.org +[Chromium] Unreviewed, mark http/tests/media/video-buffering-repaints-controls.html as timing out on Leopard. +https://bugs.webkit.org/show_bug.cgi?id=75570 + +* platform/chromium/test_expectations.txt: + +2012-01-11 Alexander Pavlov apav...@chromium.org + [Chromium] Unreviewed, more rebaselines after r104678. * platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Added. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104694 => 104695) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-11 10:58:00 UTC (rev 104694) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-11 11:27:58 UTC (rev 104695) @@ -3849,5 +3849,5 @@ BUGWK75933 WIN : webaudio/convolution-mono-mono.html = TEXT -// New test, needs image results added. -BUGWK75570 : http/tests/media/video-buffering-repaints-controls.html = IMAGE +// New test, image results added but it is timing out on Leopard. +BUGWK75570 LEOPARD : http/tests/media/video-buffering-repaints-controls.html = PASS TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104696] trunk/LayoutTests
Title: [104696] trunk/LayoutTests Revision 104696 Author o...@webkit.org Date 2012-01-11 03:50:41 -0800 (Wed, 11 Jan 2012) Log Message Implement the font-kerning CSS property https://bugs.webkit.org/show_bug.cgi?id=76033 Unreviewed gardening after r104678. * svg/css/getComputedStyle-basic-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104695 => 104696) --- trunk/LayoutTests/ChangeLog 2012-01-11 11:27:58 UTC (rev 104695) +++ trunk/LayoutTests/ChangeLog 2012-01-11 11:50:41 UTC (rev 104696) @@ -1,3 +1,12 @@ +2012-01-11 Csaba Osztrogonác o...@webkit.org + +Implement the font-kerning CSS property +https://bugs.webkit.org/show_bug.cgi?id=76033 + +Unreviewed gardening after r104678. + +* svg/css/getComputedStyle-basic-expected.txt: + 2012-01-11 Alexander Pavlov apav...@chromium.org [Chromium] Unreviewed, mark http/tests/media/video-buffering-repaints-controls.html as timing out on Leopard. Modified: trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt (104695 => 104696) --- trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt 2012-01-11 11:27:58 UTC (rev 104695) +++ trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt 2012-01-11 11:50:41 UTC (rev 104696) @@ -294,6 +294,8 @@ rect: style.getPropertyCSSValue(-webkit-flex-flow) : [object CSSValueList] rect: style.getPropertyValue(-webkit-flex-wrap) : nowrap rect: style.getPropertyCSSValue(-webkit-flex-wrap) : [object CSSPrimitiveValue] +rect: style.getPropertyValue(-webkit-font-kerning) : auto +rect: style.getPropertyCSSValue(-webkit-font-kerning) : [object CSSPrimitiveValue] rect: style.getPropertyValue(-webkit-font-smoothing) : auto rect: style.getPropertyCSSValue(-webkit-font-smoothing) : [object CSSPrimitiveValue] rect: style.getPropertyValue(-webkit-highlight) : none @@ -802,6 +804,8 @@ g: style.getPropertyCSSValue(-webkit-flex-flow) : [object CSSValueList] g: style.getPropertyValue(-webkit-flex-wrap) : nowrap g: style.getPropertyCSSValue(-webkit-flex-wrap) : [object CSSPrimitiveValue] +g: style.getPropertyValue(-webkit-font-kerning) : auto +g: style.getPropertyCSSValue(-webkit-font-kerning) : [object CSSPrimitiveValue] g: style.getPropertyValue(-webkit-font-smoothing) : auto g: style.getPropertyCSSValue(-webkit-font-smoothing) : [object CSSPrimitiveValue] g: style.getPropertyValue(-webkit-highlight) : none ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104697] trunk/LayoutTests
Title: [104697] trunk/LayoutTests Revision 104697 Author ph...@webkit.org Date 2012-01-11 03:52:53 -0800 (Wed, 11 Jan 2012) Log Message Unreviewed, rebaseline after r104678. * platform/gtk/Skipped: Skip failing fast/text/font-kerning.html ref test. * platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104696 => 104697) --- trunk/LayoutTests/ChangeLog 2012-01-11 11:50:41 UTC (rev 104696) +++ trunk/LayoutTests/ChangeLog 2012-01-11 11:52:53 UTC (rev 104697) @@ -1,3 +1,11 @@ +2012-01-11 Philippe Normand pnorm...@igalia.com + +Unreviewed, GTK rebaseline after r104678. + +* platform/gtk/Skipped: Skip failing fast/text/font-kerning.html +ref test. +* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: + 2012-01-11 Csaba Osztrogonác o...@webkit.org Implement the font-kerning CSS property Modified: trunk/LayoutTests/platform/gtk/Skipped (104696 => 104697) --- trunk/LayoutTests/platform/gtk/Skipped 2012-01-11 11:50:41 UTC (rev 104696) +++ trunk/LayoutTests/platform/gtk/Skipped 2012-01-11 11:52:53 UTC (rev 104697) @@ -1622,3 +1622,5 @@ # https://bugs.webkit.org/show_bug.cgi?id=75833 fast/text/international/spaces-combined-in-vertical-text.html +# https://bugs.webkit.org/show_bug.cgi?id=76048 +fast/text/font-kerning.html Modified: trunk/LayoutTests/platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (104696 => 104697) --- trunk/LayoutTests/platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-01-11 11:50:41 UTC (rev 104696) +++ trunk/LayoutTests/platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-01-11 11:52:53 UTC (rev 104697) @@ -143,7 +143,7 @@ -webkit-column-width: auto -webkit-flex-order: 0 -webkit-flex-pack: start --webkit-flex-align: stretch +-webkit-flex-item-align: stretch -webkit-flex-direction: row -webkit-flex-flow: row nowrap -webkit-flex-wrap: nowrap ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104699] trunk/LayoutTests
Title: [104699] trunk/LayoutTests Revision 104699 Author apav...@chromium.org Date 2012-01-11 04:24:42 -0800 (Wed, 11 Jan 2012) Log Message [Chromium] Skip failing fast/text/font-kerning.html reftest on Win7. * platform/chromium-win/fast/text/font-kerning-expected.png: Removed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Removed Paths trunk/LayoutTests/platform/chromium-win/fast/text/font-kerning-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (104698 => 104699) --- trunk/LayoutTests/ChangeLog 2012-01-11 12:08:59 UTC (rev 104698) +++ trunk/LayoutTests/ChangeLog 2012-01-11 12:24:42 UTC (rev 104699) @@ -1,3 +1,10 @@ +2012-01-11 Alexander Pavlov apav...@chromium.org + +[Chromium] Skip failing fast/text/font-kerning.html reftest on Win7. + +* platform/chromium-win/fast/text/font-kerning-expected.png: Removed. +* platform/chromium/test_expectations.txt: + 2012-01-11 Alexandru Chiculita ach...@adobe.com CSS Filters: apply the filters in RenderLayerBacking::paintIntoLayer when filters cannot be composited in hardware Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104698 => 104699) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-11 12:08:59 UTC (rev 104698) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-11 12:24:42 UTC (rev 104699) @@ -3851,3 +3851,6 @@ // New test, image results added but it is timing out on Leopard. BUGWK75570 LEOPARD : http/tests/media/video-buffering-repaints-controls.html = PASS TIMEOUT + +// New reftest failing on Win7. +BUGWK76050 WIN7 : fast/text/font-kerning.html = IMAGE Deleted: trunk/LayoutTests/platform/chromium-win/fast/text/font-kerning-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104700] trunk/LayoutTests
Title: [104700] trunk/LayoutTests Revision 104700 Author rga...@webkit.org Date 2012-01-11 04:46:45 -0800 (Wed, 11 Jan 2012) Log Message [Qt] new test fast/forms/radio/radio-group.html failing after r104668 https://bugs.webkit.org/show_bug.cgi?id=76051 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (104699 => 104700) --- trunk/LayoutTests/ChangeLog 2012-01-11 12:24:42 UTC (rev 104699) +++ trunk/LayoutTests/ChangeLog 2012-01-11 12:46:45 UTC (rev 104700) @@ -1,3 +1,12 @@ +2012-01-11 Gabor Rapcsanyi rga...@webkit.org + +[Qt] new test fast/forms/radio/radio-group.html failing after r104668 +https://bugs.webkit.org/show_bug.cgi?id=76051 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2012-01-11 Alexander Pavlov apav...@chromium.org [Chromium] Skip failing fast/text/font-kerning.html reftest on Win7. Modified: trunk/LayoutTests/platform/qt/Skipped (104699 => 104700) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-11 12:24:42 UTC (rev 104699) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-11 12:46:45 UTC (rev 104700) @@ -2566,3 +2566,7 @@ # [Qt] REGRESSION(r104267): fast/js/date-constructor.html fails # https://bugs.webkit.org/show_bug.cgi?id=75692 fast/js/date-constructor.html + +# [Qt] new test fast/forms/radio/radio-group.html failing after r104668 +# https://bugs.webkit.org/show_bug.cgi?id=76051 +fast/forms/radio/radio-group.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104701] trunk/LayoutTests
Title: [104701] trunk/LayoutTests
Revision 104701
Author apav...@chromium.org
Date 2012-01-11 05:21:10 -0800 (Wed, 11 Jan 2012)
Log Message
[Chromium] Unreviewed, rebaseline http/tests/media/video-buffering-repaints-controls.html for Mac Leopard Debug.
* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png:
* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png
Removed Paths
trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (104700 => 104701)
--- trunk/LayoutTests/ChangeLog 2012-01-11 12:46:45 UTC (rev 104700)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 13:21:10 UTC (rev 104701)
@@ -1,3 +1,10 @@
+2012-01-11 Alexander Pavlov apav...@chromium.org
+
+[Chromium] Unreviewed, rebaseline http/tests/media/video-buffering-repaints-controls.html for Mac Leopard Debug.
+
+* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png:
+* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
+
2012-01-11 Gabor Rapcsanyi rga...@webkit.org
[Qt] new test fast/forms/radio/radio-group.html failing after r104668
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt (104700 => 104701)
--- trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt 2012-01-11 12:46:45 UTC (rev 104700)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.txt 2012-01-11 13:21:10 UTC (rev 104701)
@@ -1,34 +0,0 @@
-
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x18
-RenderText {#text} at (0,0) size 562x18
- text run at (0,0) width 562: Test that media controls repaint correctly during paused states when new data is buffered.
- RenderBlock (anonymous) at (0,34) size 784x150
-RenderBR {BR} at (300,150) size 0x0
-layer at (8,42) size 300x150
- RenderVideo {VIDEO} at (0,0) size 300x150
-layer at (8,42) size 300x150
- RenderBlock (relative positioned) {DIV} at (0,0) size 300x150
-layer at (8,160) size 300x32
- RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,118) size 300x32 [bgcolor=#0099]
-layer at (15,166) size 18x19
- RenderButton {INPUT} at (7,6) size 18x19
-layer at (38,160) size 236x32
- RenderDeprecatedFlexibleBox (positioned) {DIV} at (30,0) size 236x32 [border: (1px solid #FF33) none (1px solid #FF33)]
-RenderSlider {INPUT} at (7,7) size 164x18 [color=#328CDF] [bgcolor=#FF14] [border: (1px solid #FF33)]
- RenderDeprecatedFlexibleBox {DIV} at (1,1) size 162x16
-RenderBlock {DIV} at (0,0) size 153x29
-RenderBlock {DIV} at (153,0) size 9x29
-layer at (215,166) size 58x20 scrollHeight 21
- RenderDeprecatedFlexibleBox {DIV} at (177,6) size 58x20 [color=#FF]
-RenderBlock (anonymous) at (8,0) size 41x21
- RenderText {#text} at (0,2) size 41x17
-text run at (0,2) width 41: 00:00
-layer at (46,162) size 9x29
- RenderBlock (relative positioned) {DIV} at (0,-6) size 9x29
-layer at (274,160) size 34x32
- RenderButton {INPUT} at (266,0) size 34x32
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104703] trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp
Title: [104703] trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp
Revision 104703
Author ach...@adobe.com
Date 2012-01-11 05:38:03 -0800 (Wed, 11 Jan 2012)
Log Message
2012-01-11 Alexandru Chiculita ach...@adobe.com
Unreviewd build fix after http://trac.webkit.org/changeset/104702.
Moving the FilterEffectRenderer::updateBackingStore outside the ENABLE(CSS_SHADERS) block.
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::notifyCustomFilterProgramLoaded):
Modified Paths
trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp
Diff
Modified: trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp (104702 => 104703)
--- trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp 2012-01-11 13:24:39 UTC (rev 104702)
+++ trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp 2012-01-11 13:38:03 UTC (rev 104703)
@@ -292,12 +292,6 @@
#endif
}
-#if ENABLE(CSS_SHADERS)
-void FilterEffectRenderer::notifyCustomFilterProgramLoaded(CustomFilterProgram*)
-{
-m_observer-filterNeedsRepaint();
-}
-
void FilterEffectRenderer::updateBackingStore(const FloatRect filterRect)
{
if (!filterRect.isZero()) {
@@ -307,6 +301,12 @@
}
}
+#if ENABLE(CSS_SHADERS)
+void FilterEffectRenderer::notifyCustomFilterProgramLoaded(CustomFilterProgram*)
+{
+m_observer-filterNeedsRepaint();
+}
+
void FilterEffectRenderer::removeCustomFilterClients()
{
for (CustomFilterProgramList::iterator iter = m_cachedCustomFilterPrograms.begin(), end = m_cachedCustomFilterPrograms.end(); iter != end; ++iter)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104704] trunk/LayoutTests
Title: [104704] trunk/LayoutTests Revision 104704 Author rga...@webkit.org Date 2012-01-11 05:47:47 -0800 (Wed, 11 Jan 2012) Log Message [Qt] Some css3 filter tests are failing after r104698 https://bugs.webkit.org/show_bug.cgi?id=76055 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (104703 => 104704) --- trunk/LayoutTests/ChangeLog 2012-01-11 13:38:03 UTC (rev 104703) +++ trunk/LayoutTests/ChangeLog 2012-01-11 13:47:47 UTC (rev 104704) @@ -1,3 +1,12 @@ +2012-01-11 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Some css3 filter tests are failing after r104698 +https://bugs.webkit.org/show_bug.cgi?id=76055 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2012-01-09 Alexandru Chiculita ach...@adobe.com [CSS Shaders] Move CustomFilterOperation to the platform layer Modified: trunk/LayoutTests/platform/qt/Skipped (104703 => 104704) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-11 13:38:03 UTC (rev 104703) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-11 13:47:47 UTC (rev 104704) @@ -2570,3 +2570,16 @@ # [Qt] new test fast/forms/radio/radio-group.html failing after r104668 # https://bugs.webkit.org/show_bug.cgi?id=76051 fast/forms/radio/radio-group.html + +# [Qt] Some css3 filter tests are failing after r104698 +# https://bugs.webkit.org/show_bug.cgi?id=76055 +css3/filters/effect-blur.html +css3/filters/effect-brightness.html +css3/filters/effect-contrast.html +css3/filters/effect-drop-shadow.html +css3/filters/effect-grayscale.html +css3/filters/effect-hue-rotate.html +css3/filters/effect-invert.html +css3/filters/effect-opacity.html +css3/filters/effect-saturate.html +css3/filters/effect-sepia.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104705] trunk/Source/WebCore
Title: [104705] trunk/Source/WebCore
Revision 104705
Author caio.olive...@openbossa.org
Date 2012-01-11 05:50:20 -0800 (Wed, 11 Jan 2012)
Log Message
Avoid separate heap allocation for each RenderRegionRange in RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=75908
Reviewed by Darin Adler.
There's no benefit in explicit allocating RenderRegionRange in the heap. So this
patch changes the RenderRegionRangeMap to use the value type directly instead of
the pointer.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):
* rendering/RenderFlowThread.h: add default constructor to act as emptyValue()
for HashMap.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104704 => 104705)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 13:47:47 UTC (rev 104704)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 13:50:20 UTC (rev 104705)
@@ -1,3 +1,23 @@
+2012-01-11 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
+
+Avoid separate heap allocation for each RenderRegionRange in RenderFlowThread
+https://bugs.webkit.org/show_bug.cgi?id=75908
+
+Reviewed by Darin Adler.
+
+There's no benefit in explicit allocating RenderRegionRange in the heap. So this
+patch changes the RenderRegionRangeMap to use the value type directly instead of
+the pointer.
+
+* rendering/RenderFlowThread.cpp:
+(WebCore::RenderFlowThread::removeRegionFromThread):
+(WebCore::RenderFlowThread::layout):
+(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
+(WebCore::RenderFlowThread::setRegionRangeForBox):
+(WebCore::RenderFlowThread::getRegionRangeForBox):
+* rendering/RenderFlowThread.h: add default constructor to act as emptyValue()
+for HashMap.
+
2012-01-09 Alexandru Chiculita ach...@adobe.com
[CSS Shaders] Move CustomFilterOperation to the platform layer
Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (104704 => 104705)
--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2012-01-11 13:47:47 UTC (rev 104704)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2012-01-11 13:50:20 UTC (rev 104705)
@@ -56,17 +56,6 @@
setInRenderFlowThread();
}
-void RenderFlowThread::clearRenderRegionRangeMap()
-{
-deleteAllValues(m_regionRangeMap);
-m_regionRangeMap.clear();
-}
-
-RenderFlowThread::~RenderFlowThread()
-{
-clearRenderRegionRangeMap();
-}
-
PassRefPtrRenderStyle RenderFlowThread::createFlowThreadStyle(RenderStyle* parentStyle)
{
RefPtrRenderStyle newStyle(RenderStyle::create());
@@ -215,7 +204,7 @@
void RenderFlowThread::removeRegionFromThread(RenderRegion* renderRegion)
{
ASSERT(renderRegion);
-clearRenderRegionRangeMap();
+m_regionRangeMap.clear();
m_regionList.remove(renderRegion);
if (renderRegion-parentFlowThread()) {
@@ -318,7 +307,7 @@
m_hasValidRegions = false;
m_regionsHaveUniformLogicalWidth = true;
m_regionsHaveUniformLogicalHeight = true;
-clearRenderRegionRangeMap();
+m_regionRangeMap.clear();
LayoutUnit previousRegionLogicalWidth = 0;
LayoutUnit previousRegionLogicalHeight = 0;
if (hasRegions()) {
@@ -641,7 +630,7 @@
break;
}
-delete m_regionRangeMap.take(box);
+m_regionRangeMap.remove(box);
}
bool RenderFlowThread::logicalWidthChangedInRegions(const RenderBlock* block, LayoutUnit offsetFromLogicalTopOfFirstPage)
@@ -752,43 +741,45 @@
// FIXME: Not right for differing writing-modes.
RenderRegion* startRegion = renderRegionForLine(offsetFromLogicalTopOfFirstPage, true);
RenderRegion* endRegion = renderRegionForLine(offsetFromLogicalTopOfFirstPage + box-logicalHeight(), true);
-RenderRegionRange* range = m_regionRangeMap.get(box);
-if (range) {
-// If nothing changed, just bail.
-if (range-startRegion() == startRegion range-endRegion() == endRegion)
-return;
+RenderRegionRangeMap::iterator it = m_regionRangeMap.find(box);
+if (it == m_regionRangeMap.end()) {
+m_regionRangeMap.set(box, RenderRegionRange(startRegion, endRegion));
+return;
+}
-// Delete any info that we find before our new startRegion and after our new endRegion.
-for (RenderRegionList::iterator iter = m_regionList.begin(); iter != m_regionList.end(); ++iter) {
-RenderRegion* region = *iter;
-if (region == startRegion) {
-iter = m_regionList.find(endRegion);
-continue;
-}
+// If nothing changed, just bail.
[webkit-changes] [104706] trunk/Source/WebKit2
Title: [104706] trunk/Source/WebKit2 Revision 104706 Author k...@webkit.org Date 2012-01-11 05:54:06 -0800 (Wed, 11 Jan 2012) Log Message [GTK] Linking of big binaries should be serialized to avoid thrashing https://bugs.webkit.org/show_bug.cgi?id=75977 Patch by Gustavo Noronha Silva gustavo.noro...@collabora.com on 2012-01-11 Reviewed by Martin Robinson. Added artificial dependencies so that libwebkitgtk is always linked first, libwebkit2gtk second, and WebKitPluginProcess last. Automake unfortunately replaces the whole rule used to build the libraries if the actual name is used to add the dependency, so we use helper variables to work around that. * GNUmakefile.am: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am Diff Modified: trunk/Source/WebKit2/ChangeLog (104705 => 104706) --- trunk/Source/WebKit2/ChangeLog 2012-01-11 13:50:20 UTC (rev 104705) +++ trunk/Source/WebKit2/ChangeLog 2012-01-11 13:54:06 UTC (rev 104706) @@ -1,3 +1,18 @@ +2012-01-11 Gustavo Noronha Silva gustavo.noro...@collabora.com + +[GTK] Linking of big binaries should be serialized to avoid thrashing +https://bugs.webkit.org/show_bug.cgi?id=75977 + +Reviewed by Martin Robinson. + +Added artificial dependencies so that libwebkitgtk is always +linked first, libwebkit2gtk second, and WebKitPluginProcess +last. Automake unfortunately replaces the whole rule used to build +the libraries if the actual name is used to add the dependency, so +we use helper variables to work around that. + +* GNUmakefile.am: + 2012-01-11 Ryuan Choi ryuan.c...@samsung.com [EFL][WK2] Rename viewObject to viewWidget Modified: trunk/Source/WebKit2/GNUmakefile.am (104705 => 104706) --- trunk/Source/WebKit2/GNUmakefile.am 2012-01-11 13:50:20 UTC (rev 104705) +++ trunk/Source/WebKit2/GNUmakefile.am 2012-01-11 13:54:06 UTC (rev 104706) @@ -1011,6 +1011,12 @@ lib_LTLIBRARIES += \ libwebkit2gtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la +# Artificial dependency to make sure libwebkit2gtk and libwebkitgtk are not linked at the same time +# The variable creation is to avoid having automake override the entire rule instead of adding the +# dependency. +webkit2gtk_lib_for_dep = libwebkit2gtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la +$(webkit2gtk_lib_for_dep): libwebkitgtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la + libwebkit2gtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_ladir = \ $(libwebkit2gtkincludedir)/WebKit2 @@ -1271,6 +1277,10 @@ libexec_PROGRAMS += \ Programs/WebKitPluginProcess +# Serialize linking of the plugin process with both webkit libraries. +plugin_process_for_dep = Programs/WebKitPluginProcess +$(plugin_process_for_dep): libwebkitgtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la libwebkit2gtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la + Programs_WebKitPluginProcess_CPPFLAGS = \ -include $(srcdir)/Source/WebKit2/WebKit2Prefix.h \ -I$(srcdir)/Source/WebKit2 \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104707] trunk/Source/WebCore
Title: [104707] trunk/Source/WebCore
Revision 104707
Author yu...@chromium.org
Date 2012-01-11 06:17:45 -0800 (Wed, 11 Jan 2012)
Log Message
Web Inspector: CodeGeneratorInspector.py: generate enum types.
https://bugs.webkit.org/show_bug.cgi?id=74954
Patch by Peter Rybin peter.ry...@gmail.com on 2012-01-11
Reviewed by Yury Semikhatsky.
Internal map of string contants is created. C enums are created for
each JSON enum.
* inspector/CodeGeneratorInspector.py:
(EnumConstants.add_constant):
(EnumConstants):
(EnumConstants.get_enum_constant_code):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainString.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainString.get_setter_value_expression_pattern):
(get_in_c_type_text):
(get_setter_value_expression_pattern):
(PlainObjectBinding.get_in_c_type_text):
(PlainObjectBinding.get_setter_value_expression_pattern):
(RawTypesBinding.get_in_c_type_text):
(RawTypesBinding.get_setter_value_expression_pattern):
(get_annotated_type_text):
(MethodGenerateModes.get_modes):
(MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
(MethodGenerateModes.StrictParameterMode):
(MethodGenerateModes.StrictParameterMode.get_setter_value_expression):
(MethodGenerateModes.RawParameterMode.get_c_param_type_text):
(MethodGenerateModes.RawParameterMode):
(MethodGenerateModes.RawParameterMode.get_setter_value_expression):
(MethodGenerateModes.CombinedMode.get_c_param_type_text):
(MethodGenerateModes):
(MethodGenerateModes.CombinedMode):
(MethodGenerateModes.CombinedMode.get_setter_value_expression):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py
Diff
Modified: trunk/Source/WebCore/ChangeLog (104706 => 104707)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 13:54:06 UTC (rev 104706)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 14:17:45 UTC (rev 104707)
@@ -1,3 +1,41 @@
+2012-01-11 Peter Rybin peter.ry...@gmail.com
+
+Web Inspector: CodeGeneratorInspector.py: generate enum types.
+https://bugs.webkit.org/show_bug.cgi?id=74954
+
+Reviewed by Yury Semikhatsky.
+
+Internal map of string contants is created. C enums are created for
+each JSON enum.
+
+* inspector/CodeGeneratorInspector.py:
+(EnumConstants.add_constant):
+(EnumConstants):
+(EnumConstants.get_enum_constant_code):
+(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
+(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
+(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
+(TypeBindings.create_type_declaration_.PlainString.reduce_to_raw_type):
+(TypeBindings.create_type_declaration_.PlainString.get_setter_value_expression_pattern):
+(get_in_c_type_text):
+(get_setter_value_expression_pattern):
+(PlainObjectBinding.get_in_c_type_text):
+(PlainObjectBinding.get_setter_value_expression_pattern):
+(RawTypesBinding.get_in_c_type_text):
+(RawTypesBinding.get_setter_value_expression_pattern):
+(get_annotated_type_text):
+(MethodGenerateModes.get_modes):
+(MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
+(MethodGenerateModes.StrictParameterMode):
+(MethodGenerateModes.StrictParameterMode.get_setter_value_expression):
+(MethodGenerateModes.RawParameterMode.get_c_param_type_text):
+(MethodGenerateModes.RawParameterMode):
+(MethodGenerateModes.RawParameterMode.get_setter_value_expression):
+(MethodGenerateModes.CombinedMode.get_c_param_type_text):
+(MethodGenerateModes):
+(MethodGenerateModes.CombinedMode):
+(MethodGenerateModes.CombinedMode.get_setter_value_expression):
+
2012-01-11 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
Avoid separate heap allocation for each RenderRegionRange in RenderFlowThread
Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (104706 => 104707)
--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py 2012-01-11 13:54:06 UTC (rev 104706)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py 2012-01-11 14:17:45 UTC (rev 104707)
@@ -51,6 +51,7 @@
# Manually-filled map of type name replacements.
TYPE_NAME_FIX_MAP = {
RGBA: Rgba, # RGBA is reported to be conflicting with a define name in Windows CE.
+: Empty,
}
@@ -519,6 +520,28 @@
return Writer(new_output, self.indent + additional_indent)
+class EnumConstants:
+map_ = {}
+constants_ = []
+
+@classmethod
+def add_constant(cls, value):
+
[webkit-changes] [104708] trunk
Title: [104708] trunk Revision 104708 Author o...@webkit.org Date 2012-01-11 06:33:49 -0800 (Wed, 11 Jan 2012) Log Message [Qt] Some css3 filter tests are failing after r104698 https://bugs.webkit.org/show_bug.cgi?id=76055 Reviewed by Simon Hausmann. Tools: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference. LayoutTests: * platform/qt/Skipped: Unskip now passing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp Diff Modified: trunk/LayoutTests/ChangeLog (104707 => 104708) --- trunk/LayoutTests/ChangeLog 2012-01-11 14:17:45 UTC (rev 104707) +++ trunk/LayoutTests/ChangeLog 2012-01-11 14:33:49 UTC (rev 104708) @@ -1,3 +1,12 @@ +2012-01-11 Csaba Osztrogonác o...@webkit.org + +[Qt] Some css3 filter tests are failing after r104698 +https://bugs.webkit.org/show_bug.cgi?id=76055 + +Reviewed by Simon Hausmann. + +* platform/qt/Skipped: Unskip now passing tests. + 2012-01-11 Gabor Rapcsanyi rga...@webkit.org [Qt] Some css3 filter tests are failing after r104698 Modified: trunk/LayoutTests/platform/qt/Skipped (104707 => 104708) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-11 14:17:45 UTC (rev 104707) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-11 14:33:49 UTC (rev 104708) @@ -2570,16 +2570,3 @@ # [Qt] new test fast/forms/radio/radio-group.html failing after r104668 # https://bugs.webkit.org/show_bug.cgi?id=76051 fast/forms/radio/radio-group.html - -# [Qt] Some css3 filter tests are failing after r104698 -# https://bugs.webkit.org/show_bug.cgi?id=76055 -css3/filters/effect-blur.html -css3/filters/effect-brightness.html -css3/filters/effect-contrast.html -css3/filters/effect-drop-shadow.html -css3/filters/effect-grayscale.html -css3/filters/effect-hue-rotate.html -css3/filters/effect-invert.html -css3/filters/effect-opacity.html -css3/filters/effect-saturate.html -css3/filters/effect-sepia.html Modified: trunk/Tools/ChangeLog (104707 => 104708) --- trunk/Tools/ChangeLog 2012-01-11 14:17:45 UTC (rev 104707) +++ trunk/Tools/ChangeLog 2012-01-11 14:33:49 UTC (rev 104708) @@ -1,3 +1,13 @@ +2012-01-11 Csaba Osztrogonác o...@webkit.org + +[Qt] Some css3 filter tests are failing after r104698 +https://bugs.webkit.org/show_bug.cgi?id=76055 + +Reviewed by Simon Hausmann. + +* DumpRenderTree/qt/LayoutTestControllerQt.cpp: +(LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference. + 2012-01-11 Tony Chang t...@chromium.org Don't remove 0 byte files when running build-webkit --chromium Modified: trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp (104707 => 104708) --- trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp 2012-01-11 14:17:45 UTC (rev 104707) +++ trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp 2012-01-11 14:33:49 UTC (rev 104708) @@ -699,6 +699,8 @@ settings-setAttribute(QWebSettings::HyperlinkAuditingEnabled, value.toBool()); else if (name == WebKitHixie76WebSocketProtocolEnabled) DumpRenderTreeSupportQt::setHixie76WebSocketProtocolEnabled(m_topLoadingFrame-page(), value.toBool()); +else if (name == WebKitAcceleratedCompositingEnabled) +settings-setAttribute(QWebSettings::AcceleratedCompositingEnabled, value.toBool()); else printf(ERROR: LayoutTestController::overridePreference() does not support the '%s' preference\n, name.toLatin1().data()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104709] trunk/Source/WebKit2
Title: [104709] trunk/Source/WebKit2
Revision 104709
Author kenn...@webkit.org
Date 2012-01-11 06:58:22 -0800 (Wed, 11 Jan 2012)
Log Message
[Qt] Add the editor rect to the EditorState https://bugs.webkit.org/show_bug.cgi?id=76053
Reviewed by Simon Hausmann.
Also rename some members to match the new Qt naming scheme.
* Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
* Shared/EditorState.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::inputMethodQuery):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/EditorState.cpp
trunk/Source/WebKit2/Shared/EditorState.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (104708 => 104709)
--- trunk/Source/WebKit2/ChangeLog 2012-01-11 14:33:49 UTC (rev 104708)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-11 14:58:22 UTC (rev 104709)
@@ -1,3 +1,23 @@
+2012-01-11 Kenneth Rohde Christiansen kenn...@webkit.org
+
+[Qt] Add the editor rect to the EditorState
+https://bugs.webkit.org/show_bug.cgi?id=76053
+
+Reviewed by Simon Hausmann.
+
+Also rename some members to match the new Qt naming scheme.
+
+* Shared/EditorState.cpp:
+(WebKit::EditorState::encode):
+(WebKit::EditorState::decode):
+* Shared/EditorState.h:
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebView::inputMethodQuery):
+* WebProcess/WebCoreSupport/WebEditorClient.cpp:
+(WebKit::WebEditorClient::respondToChangedSelection):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::editorState):
+
2012-01-11 Gustavo Noronha Silva gustavo.noro...@collabora.com
[GTK] Linking of big binaries should be serialized to avoid thrashing
Modified: trunk/Source/WebKit2/Shared/EditorState.cpp (104708 => 104709)
--- trunk/Source/WebKit2/Shared/EditorState.cpp 2012-01-11 14:33:49 UTC (rev 104708)
+++ trunk/Source/WebKit2/Shared/EditorState.cpp 2012-01-11 14:58:22 UTC (rev 104709)
@@ -44,7 +44,8 @@
#if PLATFORM(QT)
encoder-encode(cursorPosition);
encoder-encode(anchorPosition);
-encoder-encode(microFocus);
+encoder-encode(editorRect);
+encoder-encode(cursorRect);
encoder-encode(compositionRect);
encoder-encode(selectedText);
encoder-encode(surroundingText);
@@ -81,9 +82,12 @@
if (!decoder-decode(result.anchorPosition))
return false;
-if (!decoder-decode(result.microFocus))
+if (!decoder-decode(result.editorRect))
return false;
+if (!decoder-decode(result.cursorRect))
+return false;
+
if (!decoder-decode(result.compositionRect))
return false;
Modified: trunk/Source/WebKit2/Shared/EditorState.h (104708 => 104709)
--- trunk/Source/WebKit2/Shared/EditorState.h 2012-01-11 14:33:49 UTC (rev 104708)
+++ trunk/Source/WebKit2/Shared/EditorState.h 2012-01-11 14:58:22 UTC (rev 104709)
@@ -63,7 +63,8 @@
unsigned cursorPosition;
unsigned anchorPosition;
-WebCore::IntRect microFocus;
+WebCore::IntRect editorRect;
+WebCore::IntRect cursorRect;
WebCore::IntRect compositionRect;
WTF::String selectedText;
WTF::String surroundingText;
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (104708 => 104709)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-01-11 14:33:49 UTC (rev 104708)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-01-11 14:58:22 UTC (rev 104709)
@@ -924,7 +924,7 @@
switch(property) {
case Qt::ImCursorRectangle:
-return QRectF(state.microFocus);
+return QRectF(state.cursorRect);
case Qt::ImFont:
return QVariant();
case Qt::ImCursorPosition:
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp (104708 => 104709)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2012-01-11 14:33:49 UTC (rev 104708)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2012-01-11 14:58:22 UTC (rev 104709)
@@ -186,8 +186,9 @@
EditorState state = m_page-editorState();
#if PLATFORM(QT)
-if (Element* scope = frame-selection()-rootEditableElement())
-m_page-send(Messages::WebPageProxy::FocusEditableArea(state.microFocus, scope-getRect()));
+// FIXME: Move this to act on the vkb visibility change.
+if (state.isContentEditable)
+m_page-send(Messages::WebPageProxy::FocusEditableArea(state.cursorRect, state.editorRect));
#endif
m_page-send(Messages::WebPageProxy::EditorStateChanged(state));
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (104708 =>
[webkit-changes] [104710] trunk/Source/WebCore
Title: [104710] trunk/Source/WebCore
Revision 104710
Author apav...@chromium.org
Date 2012-01-11 07:14:44 -0800 (Wed, 11 Jan 2012)
Log Message
Web Inspector: introduce source column in the CSS profiler.
https://bugs.webkit.org/show_bug.cgi?id=75378
Reviewed by Pavel Feldman.
Rules are no longer merged by their selectors but are shown one per profile entry, with a link to
their selector in the source whenever the latter is available.
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::RuleMatchingStats::RuleMatchingStats):
(WebCore::SelectorProfile::makeKey):
(WebCore::SelectorProfile::startSelector):
(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::willMatchRule):
(WebCore::InspectorCSSAgent::willProcessRule):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::styleSheetURL):
(WebCore::InspectorStyleSheet::finalURL):
(WebCore::InspectorStyleSheet::setRuleSelector):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorDataGridNode.prototype.get rawData):
(WebInspector.CSSSelectorDataGridNode.prototype.createCell):
(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype._createProfileNodes):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.sourceComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.sidebarResized):
* inspector/front-end/dataGrid.css:
(.data-grid:focus tr.selected a):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp
trunk/Source/WebCore/inspector/InspectorCSSAgent.h
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp
trunk/Source/WebCore/inspector/InspectorStyleSheet.h
trunk/Source/WebCore/inspector/front-end/CSSSelectorProfileView.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
trunk/Source/WebCore/inspector/front-end/dataGrid.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (104709 => 104710)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 14:58:22 UTC (rev 104709)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 15:14:44 UTC (rev 104710)
@@ -1,3 +1,41 @@
+2012-01-10 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: introduce source column in the CSS profiler.
+https://bugs.webkit.org/show_bug.cgi?id=75378
+
+Reviewed by Pavel Feldman.
+
+Rules are no longer merged by their selectors but are shown one per profile entry, with a link to
+their selector in the source whenever the latter is available.
+
+* inspector/Inspector.json:
+* inspector/InspectorCSSAgent.cpp:
+(WebCore::RuleMatchingStats::RuleMatchingStats):
+(WebCore::SelectorProfile::makeKey):
+(WebCore::SelectorProfile::startSelector):
+(WebCore::SelectorProfile::commitSelector):
+(WebCore::SelectorProfile::commitSelectorTime):
+(WebCore::SelectorProfile::toInspectorObject):
+(WebCore::InspectorCSSAgent::willMatchRule):
+(WebCore::InspectorCSSAgent::willProcessRule):
+(WebCore::InspectorCSSAgent::buildArrayForRuleList):
+* inspector/InspectorStyleSheet.cpp:
+(WebCore::InspectorStyleSheet::styleSheetURL):
+(WebCore::InspectorStyleSheet::finalURL):
+(WebCore::InspectorStyleSheet::setRuleSelector):
+* inspector/InspectorStyleSheet.h:
+* inspector/front-end/CSSSelectorProfileView.js:
+(WebInspector.CSSSelectorDataGridNode.prototype.get rawData):
+(WebInspector.CSSSelectorDataGridNode.prototype.createCell):
+(WebInspector.CSSSelectorProfileView):
+(WebInspector.CSSSelectorProfileView.prototype._createProfileNodes):
+(WebInspector.CSSSelectorProfileView.prototype._sortProfile.sourceComparator):
+(WebInspector.CSSSelectorProfileView.prototype._sortProfile):
+* inspector/front-end/ProfilesPanel.js:
+(WebInspector.ProfilesPanel.prototype.sidebarResized):
+* inspector/front-end/dataGrid.css:
+(.data-grid:focus tr.selected a):
+
2012-01-11 Peter Rybin peter.ry...@gmail.com
Web Inspector: CodeGeneratorInspector.py: generate enum types.
Modified: trunk/Source/WebCore/inspector/Inspector.json (104709 => 104710)
--- trunk/Source/WebCore/inspector/Inspector.json 2012-01-11 14:58:22 UTC (rev 104709)
+++ trunk/Source/WebCore/inspector/Inspector.json 2012-01-11 15:14:44 UTC (rev 104710)
@@ -1628,10 +1628,12 @@
id: SelectorProfileEntry,
type: object,
properties: [
-{ name: selector, type: string, description: CSS selector. },
-{ name: time, type: number,
[webkit-changes] [104711] trunk/LayoutTests
Title: [104711] trunk/LayoutTests Revision 104711 Author kbal...@webkit.org Date 2012-01-11 07:16:11 -0800 (Wed, 11 Jan 2012) Log Message WebKit2 needs layoutTestController.overridePreference https://bugs.webkit.org/show_bug.cgi?id=42197 Unreviewed gardening. Skip new dependent tests. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (104710 => 104711) --- trunk/LayoutTests/ChangeLog 2012-01-11 15:14:44 UTC (rev 104710) +++ trunk/LayoutTests/ChangeLog 2012-01-11 15:16:11 UTC (rev 104711) @@ -1,3 +1,14 @@ +2012-01-11 Balazs Kelemen kbal...@webkit.org + +WebKit2 needs layoutTestController.overridePreference +https://bugs.webkit.org/show_bug.cgi?id=42197 + +Unreviewed gardening. + +Skip new dependent tests. + +* platform/wk2/Skipped: + 2012-01-11 Csaba Osztrogonác o...@webkit.org [Qt] Some css3 filter tests are failing after r104698 Modified: trunk/LayoutTests/platform/wk2/Skipped (104710 => 104711) --- trunk/LayoutTests/platform/wk2/Skipped 2012-01-11 15:14:44 UTC (rev 104710) +++ trunk/LayoutTests/platform/wk2/Skipped 2012-01-11 15:16:11 UTC (rev 104711) @@ -311,6 +311,19 @@ fast/text/zero-font-size.html fast/text/international/locale-sensitive-fonts.html http/tests/appcache/disabled.html +css3/filters/custom-filter-shader-cache.html +css3/filters/effect-blur.html +css3/filters/effect-brightness.html +css3/filters/effect-contrast.html +css3/filters/effect-drop-shadow.html +css3/filters/effect-grayscale.html +css3/filters/effect-hue-rotate.html +css3/filters/effect-invert.html +css3/filters/effect-opacity.html +css3/filters/effect-saturate.html +css3/filters/effect-sepia.html +css3/filters/missing-custom-filter-shader.html + # LayoutTestController::applicationCacheDiskUsageForOrigin isn't implemented - https://bugs.webkit.org/show_bug.cgi?id=57127 http/tests/appcache/origin-usage.html http/tests/canvas/webgl/origin-clean-conformance.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104712] trunk/LayoutTests
Title: [104712] trunk/LayoutTests Revision 104712 Author kbal...@webkit.org Date 2012-01-11 07:49:23 -0800 (Wed, 11 Jan 2012) Log Message [Qt][WK2] css3/filters/should-not-have-compositing-layer.html is failing since added in 104622 https://bugs.webkit.org/show_bug.cgi?id=76061 Unreviewed gardening. * platform/qt-wk2/Skipped: Skip failig test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (104711 => 104712) --- trunk/LayoutTests/ChangeLog 2012-01-11 15:16:11 UTC (rev 104711) +++ trunk/LayoutTests/ChangeLog 2012-01-11 15:49:23 UTC (rev 104712) @@ -1,5 +1,14 @@ 2012-01-11 Balazs Kelemen kbal...@webkit.org +[Qt][WK2] css3/filters/should-not-have-compositing-layer.html is failing since added in 104622 +https://bugs.webkit.org/show_bug.cgi?id=76061 + +Unreviewed gardening. + +* platform/qt-wk2/Skipped: Skip failig test. + +2012-01-11 Balazs Kelemen kbal...@webkit.org + WebKit2 needs layoutTestController.overridePreference https://bugs.webkit.org/show_bug.cgi?id=42197 Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (104711 => 104712) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-11 15:16:11 UTC (rev 104711) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-11 15:49:23 UTC (rev 104712) @@ -926,3 +926,7 @@ # [Qt][WK2]fast/loader/submit-form-while-parsing-2.html fails intermittently # https://bugs.webkit.org/show_bug.cgi?id=75950 fast/loader/submit-form-while-parsing-2.html + +# [Qt][WK2] css3/filters/should-not-have-compositing-layer.html is failing since added in 104622 +# https://bugs.webkit.org/show_bug.cgi?id=76061 +css3/filters/should-not-have-compositing-layer.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104716] trunk/Source/WebCore
Title: [104716] trunk/Source/WebCore
Revision 104716
Author commit-qu...@webkit.org
Date 2012-01-11 09:36:20 -0800 (Wed, 11 Jan 2012)
Log Message
Web Inspector: CodeGeneratorInspector.py: fix codestyle of generated enums
https://bugs.webkit.org/show_bug.cgi?id=76062
Patch by Peter Rybin peter.ry...@gmail.com on 2012-01-11
Reviewed by Yury Semikhatsky.
This only changes how constants are named in generated .h file.
* inspector/CodeGeneratorInspector.py:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py
Diff
Modified: trunk/Source/WebCore/ChangeLog (104715 => 104716)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 17:19:52 UTC (rev 104715)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 17:36:20 UTC (rev 104716)
@@ -1,3 +1,14 @@
+2012-01-11 Peter Rybin peter.ry...@gmail.com
+
+Web Inspector: CodeGeneratorInspector.py: fix codestyle of generated enums
+https://bugs.webkit.org/show_bug.cgi?id=76062
+
+Reviewed by Yury Semikhatsky.
+
+This only changes how constants are named in generated .h file.
+
+* inspector/CodeGeneratorInspector.py:
+
2012-01-11 Pavel Feldman pfeld...@google.com
Web Inspector: undefined instead of error message in the SourceFrame.
Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (104715 => 104716)
--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py 2012-01-11 17:19:52 UTC (rev 104715)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py 2012-01-11 17:36:20 UTC (rev 104716)
@@ -707,14 +707,14 @@
writer.newline_multiline(
enum {
-NO_FIELDS_SET = 0,
+NoFieldsSet = 0,
)
state_enum_items = []
if len(main_properties) 0:
pos = 0
for p in main_properties:
-item_name = Capitalizer.camel_case_to_capitalized_with_underscores(p[name]) + _SET
+item_name = Capitalizer.lower_camel_case_to_upper(p[name]) + Set
state_enum_items.append(item_name)
writer.newline(%s = 1 %s,\n % (item_name, pos))
pos += 1
@@ -723,7 +723,7 @@
all_fields_set_value = 0
writer.newline_multiline(
-ALL_FIELDS_SET = %s
+AllFieldsSet = %s
};
templateint STATE
@@ -738,7 +738,7 @@
Builder(PassRefPtr%s ptr)
{
-COMPILE_ASSERT(STATE == NO_FIELDS_SET, builder_created_in_non_init_state);
+COMPILE_ASSERT(STATE == NoFieldsSet, builder_created_in_non_init_state);
m_result = ptr;
}
friend class %s;
@@ -779,7 +779,7 @@
writer.newline_multiline(
operator RefPtr%s ()
{
-COMPILE_ASSERT(STATE == ALL_FIELDS_SET, result_is_not_ready);
+COMPILE_ASSERT(STATE == AllFieldsSet, result_is_not_ready);
return *reinterpret_castRefPtr%s*(m_result);
}
@@ -800,9 +800,9 @@
writer.append_multiline(;\n */\n)
writer.newline_multiline(
-static BuilderNO_FIELDS_SET create()
+static BuilderNoFieldsSet create()
{
-return BuilderNO_FIELDS_SET(adoptRef(new %s()));
+return BuilderNoFieldsSet(adoptRef(new %s()));
}
% class_name)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104717] trunk
Title: [104717] trunk
Revision 104717
Author dslo...@google.com
Date 2012-01-11 09:40:58 -0800 (Wed, 11 Jan 2012)
Log Message
[Chromium] Remove obsolete references to WebWorker class.
https://bugs.webkit.org/show_bug.cgi?id=76020
Reviewed by David Levin.
Source/WebKit/chromium:
* public/WebFrameClient.h:
* public/WebSharedWorkerClient.h:
Tools:
* DumpRenderTree/chromium/TestWebWorker.h: Removed.
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h
Removed Paths
trunk/Tools/DumpRenderTree/chromium/TestWebWorker.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (104716 => 104717)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-11 17:36:20 UTC (rev 104716)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-11 17:40:58 UTC (rev 104717)
@@ -1,3 +1,13 @@
+2012-01-10 Dmitry Lomov dslo...@google.com
+
+[Chromium] Remove obsolete references to WebWorker class.
+https://bugs.webkit.org/show_bug.cgi?id=76020
+
+Reviewed by David Levin.
+
+* public/WebFrameClient.h:
+* public/WebSharedWorkerClient.h:
+
2012-01-11 Jochen Eisinger joc...@chromium.org
Move the check for canExecuteScripts out of V8Proxy::retrieve
Modified: trunk/Source/WebKit/chromium/public/WebFrameClient.h (104716 => 104717)
--- trunk/Source/WebKit/chromium/public/WebFrameClient.h 2012-01-11 17:36:20 UTC (rev 104716)
+++ trunk/Source/WebKit/chromium/public/WebFrameClient.h 2012-01-11 17:40:58 UTC (rev 104717)
@@ -83,9 +83,6 @@
virtual WebPlugin* createPlugin(WebFrame*, const WebPluginParams) { return 0; }
// May return null.
-virtual WebWorker* createWorker(WebFrame*, WebSharedWorkerClient*) { return 0; }
-
-// May return null.
virtual WebSharedWorker* createSharedWorker(WebFrame*, const WebURL, const WebString, unsigned long long) { return 0; }
// May return null.
Modified: trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h (104716 => 104717)
--- trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h 2012-01-11 17:36:20 UTC (rev 104716)
+++ trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h 2012-01-11 17:40:58 UTC (rev 104717)
@@ -76,11 +76,6 @@
// is owned by the object implementing WebCommonWorkerClient.
virtual WebNotificationPresenter* notificationPresenter() = 0;
-// This can be called on any thread to create a nested WebWorker.
-// WebSharedWorkers are not instantiated via this API - instead
-// they are created via the WebSharedWorkerRepository.
-virtual WebWorker* createWorker(WebSharedWorkerClient*) = 0;
-
// Called on the main webkit thread in the worker process during initialization.
virtual WebApplicationCacheHost* createApplicationCacheHost(WebApplicationCacheHostClient*) = 0;
Modified: trunk/Tools/ChangeLog (104716 => 104717)
--- trunk/Tools/ChangeLog 2012-01-11 17:36:20 UTC (rev 104716)
+++ trunk/Tools/ChangeLog 2012-01-11 17:40:58 UTC (rev 104717)
@@ -1,3 +1,14 @@
+2012-01-10 Dmitry Lomov dslo...@google.com
+
+[Chromium] Remove obsolete references to WebWorker class.
+https://bugs.webkit.org/show_bug.cgi?id=76020
+
+Reviewed by David Levin.
+
+* DumpRenderTree/chromium/TestWebWorker.h: Removed.
+* DumpRenderTree/chromium/WebViewHost.cpp:
+* DumpRenderTree/chromium/WebViewHost.h:
+
2012-01-11 Csaba Osztrogonác o...@webkit.org
[Qt] Some css3 filter tests are failing after r104698
Deleted: trunk/Tools/DumpRenderTree/chromium/TestWebWorker.h (104716 => 104717)
--- trunk/Tools/DumpRenderTree/chromium/TestWebWorker.h 2012-01-11 17:36:20 UTC (rev 104716)
+++ trunk/Tools/DumpRenderTree/chromium/TestWebWorker.h 2012-01-11 17:40:58 UTC (rev 104717)
@@ -1,93 +0,0 @@
-/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
[webkit-changes] [104718] trunk/Tools
Title: [104718] trunk/Tools
Revision 104718
Author commit-qu...@webkit.org
Date 2012-01-11 09:49:43 -0800 (Wed, 11 Jan 2012)
Log Message
[Qt][WK2] Remove workaround introduced into bug 75470
https://bugs.webkit.org/show_bug.cgi?id=75889
Patch by Hugo Parente Lima hugo.l...@openbossa.org on 2012-01-11
Reviewed by Tor Arne Vestbø.
* MiniBrowser/qt/qml/BrowserWindow.qml:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml
Diff
Modified: trunk/Tools/ChangeLog (104717 => 104718)
--- trunk/Tools/ChangeLog 2012-01-11 17:40:58 UTC (rev 104717)
+++ trunk/Tools/ChangeLog 2012-01-11 17:49:43 UTC (rev 104718)
@@ -1,3 +1,12 @@
+2012-01-11 Hugo Parente Lima hugo.l...@openbossa.org
+
+[Qt][WK2] Remove workaround introduced into bug 75470
+https://bugs.webkit.org/show_bug.cgi?id=75889
+
+Reviewed by Tor Arne Vestbø.
+
+* MiniBrowser/qt/qml/BrowserWindow.qml:
+
2012-01-10 Dmitry Lomov dslo...@google.com
[Chromium] Remove obsolete references to WebWorker class.
Modified: trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml (104717 => 104718)
--- trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml 2012-01-11 17:40:58 UTC (rev 104717)
+++ trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml 2012-01-11 17:49:43 UTC (rev 104718)
@@ -247,6 +247,7 @@
}
TextInput {
id: addressLine
+clip: true
selectByMouse: true
font {
pointSize: 11
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104719] trunk
Title: [104719] trunk Revision 104719 Author commit-qu...@webkit.org Date 2012-01-11 09:54:43 -0800 (Wed, 11 Jan 2012) Log Message Implement setCurrentTime() and pauseAnimations() on SVGSVGElement https://bugs.webkit.org/show_bug.cgi?id=12073 Patch by Joel Webber j...@google.com on 2012-01-11 Reviewed by Nikolas Zimmermann. Source/WebCore: Adds the ability to reset an SVGSMILElement internally. SVGSMILElements are no longer removed from their containers when they become inactive, because they sometimes have to be reactivated when the container's current time is changed. Test: svg/animations/animate-setcurrenttime.html * svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentTime): * svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::SMILTimeContainer): (WebCore::SMILTimeContainer::begin): (WebCore::SMILTimeContainer::pause): (WebCore::SMILTimeContainer::setElapsed): (WebCore::SMILTimeContainer::updateAnimations): * svg/animation/SMILTimeContainer.h: * svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::reset): * svg/animation/SVGSMILElement.h: LayoutTests: * platform/chromium-linux/svg/animations/animate-setcurrenttime-expected.png: Added. * platform/chromium-linux/svg/animations/animate-setcurrenttime-expected.txt: Added. * svg/animations/animate-setcurrenttime.svg: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/SVGSVGElement.cpp trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp trunk/Source/WebCore/svg/animation/SMILTimeContainer.h trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp trunk/Source/WebCore/svg/animation/SVGSMILElement.h Added Paths trunk/LayoutTests/svg/animations/animate-setcurrenttime-expected.txt trunk/LayoutTests/svg/animations/animate-setcurrenttime.html Diff Modified: trunk/LayoutTests/ChangeLog (104718 => 104719) --- trunk/LayoutTests/ChangeLog 2012-01-11 17:49:43 UTC (rev 104718) +++ trunk/LayoutTests/ChangeLog 2012-01-11 17:54:43 UTC (rev 104719) @@ -1,3 +1,14 @@ +2012-01-11 Joel Webber j...@google.com + +Implement setCurrentTime() and pauseAnimations() on SVGSVGElement +https://bugs.webkit.org/show_bug.cgi?id=12073 + +Reviewed by Nikolas Zimmermann. + +* platform/chromium-linux/svg/animations/animate-setcurrenttime-expected.png: Added. +* platform/chromium-linux/svg/animations/animate-setcurrenttime-expected.txt: Added. +* svg/animations/animate-setcurrenttime.svg: Added. + 2012-01-11 Stephen Chenney schen...@chromium.org REGRESSION(r103130) - svg/W3C-SVG-1.1/animate-elem-*-t.svg asserting Added: trunk/LayoutTests/svg/animations/animate-setcurrenttime-expected.txt (0 => 104719) --- trunk/LayoutTests/svg/animations/animate-setcurrenttime-expected.txt (rev 0) +++ trunk/LayoutTests/svg/animations/animate-setcurrenttime-expected.txt 2012-01-11 17:54:43 UTC (rev 104719) @@ -0,0 +1,93 @@ +SVG 1.1 dynamic animation tests + + PASS plain.x.animVal.value is 0 +PASS sequential.x.animVal.value is 0 +PASS accumulating.x.animVal.value is 0 +PASS repeating.x.animVal.value is 0 +PASS nested.x.animVal.value is 0 +PASS plain.x.animVal.value is 0 +PASS sequential.x.animVal.value is 0 +PASS accumulating.x.animVal.value is 0 +PASS repeating.x.animVal.value is 0 +PASS nested.x.animVal.value is 0 +PASS plain.x.animVal.value is 128 +PASS sequential.x.animVal.value is 128 +PASS accumulating.x.animVal.value is 128 +PASS repeating.x.animVal.value is 128 +PASS nested.x.animVal.value is 128 +PASS plain.x.animVal.value is 0 +PASS sequential.x.animVal.value is 0 +PASS accumulating.x.animVal.value is 0 +PASS repeating.x.animVal.value is 0 +PASS nested.x.animVal.value is 0 +PASS plain.x.animVal.value is 32 +PASS sequential.x.animVal.value is 32 +PASS accumulating.x.animVal.value is 128 +PASS repeating.x.animVal.value is 128 +PASS nested.x.animVal.value is 32 +PASS plain.x.animVal.value is 64 +PASS sequential.x.animVal.value is 32 +PASS accumulating.x.animVal.value is 256 +PASS repeating.x.animVal.value is 0 +PASS nested.x.animVal.value is 64 +PASS plain.x.animVal.value is 96 +PASS sequential.x.animVal.value is 64 +PASS accumulating.x.animVal.value is 192 +PASS repeating.x.animVal.value is 128 +PASS nested.x.animVal.value is 96 +PASS plain.x.animVal.value is 128 +PASS sequential.x.animVal.value is 128 +PASS accumulating.x.animVal.value is 128 +PASS repeating.x.animVal.value is 128 +PASS nested.x.animVal.value is 128 +PASS plain.x.animVal.value is 0 +PASS sequential.x.animVal.value is 0 +PASS accumulating.x.animVal.value is 0 +PASS repeating.x.animVal.value is 0 +PASS nested.x.animVal.value is 0 +PASS plain.x.animVal.value is 0 +PASS sequential.x.animVal.value is 0 +PASS accumulating.x.animVal.value is 0 +PASS repeating.x.animVal.value is 0 +PASS nested.x.animVal.value is 32 +PASS plain.x.animVal.value is 0 +PASS sequential.x.animVal.value is 0 +PASS accumulating.x.animVal.value is 0 +PASS
[webkit-changes] [104720] trunk/Source/WebKit2
Title: [104720] trunk/Source/WebKit2 Revision 104720 Author noam.rosent...@nokia.com Date 2012-01-11 10:06:57 -0800 (Wed, 11 Jan 2012) Log Message [Qt][WK2] Directly-composited images sometimes appear with a wrong geometry https://bugs.webkit.org/show_bug.cgi?id=75882 Reviewed by Simon Hausmann. When assigning a directly composited image to a TextureMapperNode in WebKit2, we take contentsRect() onto account. However, contentsRect() might be changed after the image is already assigned. We have to reassign the image when contentsRect() changes. This is a pretty cheap operation, since the image is already converted to a texture and we simply change the geometric values. * UIProcess/qt/LayerTreeHostProxyQt.cpp: (WebKit::LayerTreeHostProxy::syncLayerParameters): * WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: (WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (104719 => 104720) --- trunk/Source/WebKit2/ChangeLog 2012-01-11 17:54:43 UTC (rev 104719) +++ trunk/Source/WebKit2/ChangeLog 2012-01-11 18:06:57 UTC (rev 104720) @@ -1,3 +1,22 @@ +2012-01-11 No'am Rosenthal noam.rosent...@nokia.com + +[Qt][WK2] Directly-composited images sometimes appear with a wrong geometry +https://bugs.webkit.org/show_bug.cgi?id=75882 + +Reviewed by Simon Hausmann. + +When assigning a directly composited image to a TextureMapperNode in WebKit2, we take +contentsRect() onto account. However, contentsRect() might be changed after the image +is already assigned. +We have to reassign the image when contentsRect() changes. This is a pretty cheap +operation, since the image is already converted to a texture and we simply change the +geometric values. + +* UIProcess/qt/LayerTreeHostProxyQt.cpp: +(WebKit::LayerTreeHostProxy::syncLayerParameters): +* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: +(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly): + 2012-01-11 Kenneth Rohde Christiansen kenn...@webkit.org [Qt] Add the editor rect to the EditorState Modified: trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp (104719 => 104720) --- trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp 2012-01-11 17:54:43 UTC (rev 104719) +++ trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp 2012-01-11 18:06:57 UTC (rev 104720) @@ -245,6 +245,7 @@ ensureLayer(id); LayerMap::iterator it = m_layers.find(id); GraphicsLayer* layer = it-second; +bool needsToUpdateImageTiles = layerInfo.imageIsUpdated || layerInfo.contentsRect != layer-contentsRect(); layer-setName(layerInfo.name); @@ -261,7 +262,7 @@ layer-setContentsRect(layerInfo.contentsRect); layer-setDrawsContent(layerInfo.drawsContent); -if (layerInfo.imageIsUpdated) +if (needsToUpdateImageTiles) assignImageToLayer(layer, layerInfo.imageBackingStoreID); // Never make the root layer clip. Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp (104719 => 104720) --- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp 2012-01-11 17:54:43 UTC (rev 104719) +++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp 2012-01-11 18:06:57 UTC (rev 104720) @@ -415,10 +415,7 @@ m_layerInfo.childrenTransform = childrenTransform(); m_layerInfo.contentsOpaque = contentsOpaque(); m_layerInfo.contentsRect = contentsRect(); - -// In the shadow layer tree we create in the UI process, layers with directly composited images are always considered to draw content. -// Otherwise, we'd have to check whether an layer with drawsContent==false has a directly composited image multiple times. -m_layerInfo.drawsContent = drawsContent() || m_image; +m_layerInfo.drawsContent = drawsContent(); m_layerInfo.mask = toWebLayerID(maskLayer()); m_layerInfo.masksToBounds = masksToBounds(); m_layerInfo.opacity = opacity(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104721] trunk/Source/WebCore
Title: [104721] trunk/Source/WebCore
Revision 104721
Author caio.olive...@openbossa.org
Date 2012-01-11 10:17:57 -0800 (Wed, 11 Jan 2012)
Log Message
Use HashMapOwnPtr for RenderBoxRegionInfo map in RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=75348
Reviewed by Darin Adler.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::logicalWidthChangedInRegions): use OwnPtr.
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRenderBoxRegionInfo): use HashMap::add() instead of
get() potentially followed by set().
(WebCore::RenderRegion::takeRenderBoxRegionInfo): change to return PassOwnPtr.
(WebCore::RenderRegion::removeRenderBoxRegionInfo):
(WebCore::RenderRegion::deleteAllRenderBoxRegionInfo):
* rendering/RenderRegion.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderRegion.cpp
trunk/Source/WebCore/rendering/RenderRegion.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104720 => 104721)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 18:06:57 UTC (rev 104720)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 18:17:57 UTC (rev 104721)
@@ -1,3 +1,20 @@
+2012-01-11 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
+
+Use HashMapOwnPtr for RenderBoxRegionInfo map in RenderRegion
+https://bugs.webkit.org/show_bug.cgi?id=75348
+
+Reviewed by Darin Adler.
+
+* rendering/RenderFlowThread.cpp:
+(WebCore::RenderFlowThread::logicalWidthChangedInRegions): use OwnPtr.
+* rendering/RenderRegion.cpp:
+(WebCore::RenderRegion::setRenderBoxRegionInfo): use HashMap::add() instead of
+get() potentially followed by set().
+(WebCore::RenderRegion::takeRenderBoxRegionInfo): change to return PassOwnPtr.
+(WebCore::RenderRegion::removeRenderBoxRegionInfo):
+(WebCore::RenderRegion::deleteAllRenderBoxRegionInfo):
+* rendering/RenderRegion.h:
+
2012-01-11 Joel Webber j...@google.com
Implement setCurrentTime() and pauseAnimations() on SVGSVGElement
Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (104720 => 104721)
--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2012-01-11 18:06:57 UTC (rev 104720)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2012-01-11 18:17:57 UTC (rev 104721)
@@ -650,13 +650,11 @@
ASSERT(!region-needsLayout());
-RenderBoxRegionInfo* oldInfo = region-takeRenderBoxRegionInfo(block);
+OwnPtrRenderBoxRegionInfo oldInfo = region-takeRenderBoxRegionInfo(block);
if (!oldInfo)
continue;
LayoutUnit oldLogicalWidth = oldInfo-logicalWidth();
-delete oldInfo;
-
RenderBoxRegionInfo* newInfo = block-renderBoxRegionInfo(region, offsetFromLogicalTopOfFirstPage);
if (!newInfo || newInfo-logicalWidth() != oldLogicalWidth)
return true;
Modified: trunk/Source/WebCore/rendering/RenderRegion.cpp (104720 => 104721)
--- trunk/Source/WebCore/rendering/RenderRegion.cpp 2012-01-11 18:06:57 UTC (rev 104720)
+++ trunk/Source/WebCore/rendering/RenderRegion.cpp 2012-01-11 18:17:57 UTC (rev 104721)
@@ -50,11 +50,6 @@
{
}
-RenderRegion::~RenderRegion()
-{
-deleteAllRenderBoxRegionInfo();
-}
-
LayoutRect RenderRegion::regionOverflowRect() const
{
// FIXME: Would like to just use hasOverflowClip() but we aren't a block yet. When RenderRegion is eliminated and
@@ -206,30 +201,27 @@
if (!m_isValid || !m_flowThread)
return 0;
-RenderBoxRegionInfo* existingBoxInfo = m_renderBoxRegionInfo.get(box);
-if (existingBoxInfo) {
-*existingBoxInfo = RenderBoxRegionInfo(logicalLeftInset, logicalRightInset, containingBlockChainIsInset);
-return existingBoxInfo;
-}
-
-RenderBoxRegionInfo* newBoxInfo = new RenderBoxRegionInfo(logicalLeftInset, logicalRightInset, containingBlockChainIsInset);
-m_renderBoxRegionInfo.set(box, newBoxInfo);
-return newBoxInfo;
+OwnPtrRenderBoxRegionInfo boxInfo = m_renderBoxRegionInfo.add(box, nullptr).first-second;
+if (boxInfo)
+*boxInfo = RenderBoxRegionInfo(logicalLeftInset, logicalRightInset, containingBlockChainIsInset);
+else
+boxInfo = adoptPtr(new RenderBoxRegionInfo(logicalLeftInset, logicalRightInset, containingBlockChainIsInset));
+
+return boxInfo.get();
}
-RenderBoxRegionInfo* RenderRegion::takeRenderBoxRegionInfo(const RenderBox* box)
+PassOwnPtrRenderBoxRegionInfo RenderRegion::takeRenderBoxRegionInfo(const RenderBox* box)
{
return m_renderBoxRegionInfo.take(box);
}
void RenderRegion::removeRenderBoxRegionInfo(const RenderBox* box)
{
-delete m_renderBoxRegionInfo.take(box);
+m_renderBoxRegionInfo.remove(box);
}
void RenderRegion::deleteAllRenderBoxRegionInfo()
{
-deleteAllValues(m_renderBoxRegionInfo);
m_renderBoxRegionInfo.clear();
}
Modified: trunk/Source/WebCore/rendering/RenderRegion.h (104720 =>
[webkit-changes] [104715] trunk/LayoutTests
Title: [104715] trunk/LayoutTests Revision 104715 Author commit-qu...@webkit.org Date 2012-01-11 09:19:52 -0800 (Wed, 11 Jan 2012) Log Message REGRESSION(r103130) - svg/W3C-SVG-1.1/animate-elem-*-t.svg asserting https://bugs.webkit.org/show_bug.cgi?id=74788 Unreviewed chromium expectations update, pending a real fix. Patch by Stephen Chenney schen...@chromium.org on 2012-01-11 * platform/chromium/test_expectations.txt: Added animate-elem-60-t.svg linux debug flakey crash Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104714 => 104715) --- trunk/LayoutTests/ChangeLog 2012-01-11 16:35:00 UTC (rev 104714) +++ trunk/LayoutTests/ChangeLog 2012-01-11 17:19:52 UTC (rev 104715) @@ -1,3 +1,12 @@ +2012-01-11 Stephen Chenney schen...@chromium.org + +REGRESSION(r103130) - svg/W3C-SVG-1.1/animate-elem-*-t.svg asserting +https://bugs.webkit.org/show_bug.cgi?id=74788 + +Unreviewed chromium expectations update, pending a real fix. + +* platform/chromium/test_expectations.txt: Added animate-elem-60-t.svg linux debug flakey crash + 2012-01-11 Pavel Feldman pfeld...@google.com Web Inspector: undefined instead of error message in the SourceFrame. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104714 => 104715) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-11 16:35:00 UTC (rev 104714) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-11 17:19:52 UTC (rev 104715) @@ -895,6 +895,7 @@ // (wrong baseline was committed). No idea about when it really started to fail. BUGCR52692 LINUX WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-80-t.svg = IMAGE+TEXT BUGCR52692 BUGWK74788 LINUX WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-80-t.svg = IMAGE+TEXT CRASH +BUGCR52692 BUGWK74788 LINUX WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-60-t.svg = IMAGE+TEXT CRASH BUGWK74788 MAC : svg/W3C-SVG-1.1/animate-elem-80-t.svg = PASS CRASH // Windows and Mac need rebaselining after 53378 patch. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104723] trunk/Source/WebCore
Title: [104723] trunk/Source/WebCore
Revision 104723
Author a...@apple.com
Date 2012-01-11 10:36:40 -0800 (Wed, 11 Jan 2012)
Log Message
Reviewed by Darin Adler. Prepared by Sheriff Bot. Rolling out r94902.
http://trac.webkit.org/changeset/94902
https://bugs.webkit.org/show_bug.cgi?id=75905
Disagrees with general direction for WebKit, and makes
refactoring harder (Requested by ap on #webkit).
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::deprecatedFrameEncoding):
* loader/DocumentWriter.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::addExtraFieldsToRequest):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
* platform/network/ResourceRequestBase.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentWriter.cpp
trunk/Source/WebCore/loader/DocumentWriter.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp
trunk/Source/WebCore/platform/network/ResourceRequestBase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104722 => 104723)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 18:32:00 UTC (rev 104722)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 18:36:40 UTC (rev 104723)
@@ -1,3 +1,23 @@
+2012-01-11 Alexey Proskuryakov a...@apple.com
+
+Reviewed by Darin Adler. Prepared by Sheriff Bot. Rolling out r94902.
+http://trac.webkit.org/changeset/94902
+https://bugs.webkit.org/show_bug.cgi?id=75905
+
+Disagrees with general direction for WebKit, and makes
+refactoring harder (Requested by ap on #webkit).
+
+* loader/DocumentWriter.cpp:
+(WebCore::DocumentWriter::deprecatedFrameEncoding):
+* loader/DocumentWriter.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::addExtraFieldsToRequest):
+* platform/network/ResourceRequestBase.cpp:
+(WebCore::ResourceRequestBase::adopt):
+(WebCore::ResourceRequestBase::copyData):
+(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
+* platform/network/ResourceRequestBase.h:
+
2012-01-11 Eli Fidler efid...@rim.com
Fix OpenGL dependency in CMake build system
Modified: trunk/Source/WebCore/loader/DocumentWriter.cpp (104722 => 104723)
--- trunk/Source/WebCore/loader/DocumentWriter.cpp 2012-01-11 18:32:00 UTC (rev 104722)
+++ trunk/Source/WebCore/loader/DocumentWriter.cpp 2012-01-11 18:36:40 UTC (rev 104723)
@@ -241,7 +241,6 @@
m_encodingWasChosenByUser = userChosen;
}
-#if PLATFORM(MAC) || PLATFORM(WIN)
String DocumentWriter::deprecatedFrameEncoding() const
{
Document* document = m_frame-document();
@@ -256,7 +255,6 @@
return String();
}
-#endif
void DocumentWriter::setDocumentWasLoadedAsPartOfNavigation()
{
Modified: trunk/Source/WebCore/loader/DocumentWriter.h (104722 => 104723)
--- trunk/Source/WebCore/loader/DocumentWriter.h 2012-01-11 18:32:00 UTC (rev 104722)
+++ trunk/Source/WebCore/loader/DocumentWriter.h 2012-01-11 18:36:40 UTC (rev 104723)
@@ -59,11 +59,10 @@
void setEncoding(const String encoding, bool userChosen);
-#if PLATFORM(MAC) || PLATFORM(WIN)
-// This code exists only to service a quirk in the Apple Mac and Windows ports.
-// FIXME: We should remove this code once CFNetwork implements RFC 6266.
+// FIXME: It's really unforunate to need to expose this piece of state.
+// I suspect a better design is to disentangle user-provided encodings,
+// default encodings, and the decoding we're currently using.
String deprecatedFrameEncoding() const;
-#endif
const String mimeType() const { return m_mimeType; }
void setMIMEType(const String type) { m_mimeType = type; }
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (104722 => 104723)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2012-01-11 18:32:00 UTC (rev 104722)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2012-01-11 18:36:40 UTC (rev 104723)
@@ -2585,13 +2585,10 @@
// Make sure we send the Origin header.
addHTTPOriginIfNeeded(request, String());
-#if PLATFORM(MAC) || PLATFORM(WIN)
-// The Apple Mac and Windows ports have decided not to behave like other
-// browsers and instead use a quirky fallback array.
-// FIXME: We should remove this code once CFNetwork implements RFC 6266.
+// Always try UTF-8. If that fails, try frame encoding (if any) and then the default.
+// For a newly opened frame with an empty URL, encoding() should not be used, because this methods asks decoder, which uses ISO-8859-1.
Settings* settings = m_frame-settings();
request.setResponseContentDispositionEncodingFallbackArray(UTF-8,
[webkit-changes] [104724] trunk/Source/WebKit2
Title: [104724] trunk/Source/WebKit2
Revision 104724
Author ander...@apple.com
Date 2012-01-11 10:59:20 -0800 (Wed, 11 Jan 2012)
Log Message
Fix the Mac GCC build.
Work around the fact that GCC doesn't work very well with Blocks and C++ objets.
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::dispatchFunctionOnQueue):
(WebKit::WebProcessProxy::secItemRequest):
(WebKit::WebProcessProxy::secKeychainItemRequest):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebProcessProxyMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (104723 => 104724)
--- trunk/Source/WebKit2/ChangeLog 2012-01-11 18:36:40 UTC (rev 104723)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-11 18:59:20 UTC (rev 104724)
@@ -1,3 +1,14 @@
+2012-01-11 Anders Carlsson ander...@apple.com
+
+Fix the Mac GCC build.
+
+Work around the fact that GCC doesn't work very well with Blocks and C++ objets.
+
+* UIProcess/mac/WebProcessProxyMac.mm:
+(WebKit::dispatchFunctionOnQueue):
+(WebKit::WebProcessProxy::secItemRequest):
+(WebKit::WebProcessProxy::secKeychainItemRequest):
+
2012-01-11 No'am Rosenthal noam.rosent...@nokia.com
[Qt][WK2] Directly-composited images sometimes appear with a wrong geometry
Modified: trunk/Source/WebKit2/UIProcess/mac/WebProcessProxyMac.mm (104723 => 104724)
--- trunk/Source/WebKit2/UIProcess/mac/WebProcessProxyMac.mm 2012-01-11 18:36:40 UTC (rev 104723)
+++ trunk/Source/WebKit2/UIProcess/mac/WebProcessProxyMac.mm 2012-01-11 18:59:20 UTC (rev 104724)
@@ -74,12 +74,25 @@
connection-send(Messages::WebProcess::SecItemResponse(requestID, response), 0);
}
+static void dispatchFunctionOnQueue(dispatch_queue_t queue, const Functionvoid () function)
+{
+#if COMPILER(CLANG)
+dispatch_async(queue, function);
+#else
+Functionvoid ()* functionPtr = new Functionvoid ()(function);
+dispatch_async(queue, ^{
+(*functionPtr)();
+delete functionPtr;
+});
+#endif
+}
+
void WebProcessProxy::secItemRequest(CoreIPC::Connection* connection, uint64_t requestID, const SecItemRequestData request)
{
// Since we don't want the connection work queue to be held up, we do all
// keychain interaction work on a global dispatch queue.
dispatch_queue_t keychainWorkQueue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);
-dispatch_async(keychainWorkQueue, bind(handleSecItemRequest, RefPtrCoreIPC::Connection(connection), requestID, request));
+dispatchFunctionOnQueue(keychainWorkQueue, bind(handleSecItemRequest, RefPtrCoreIPC::Connection(connection), requestID, request));
}
static void handleSecKeychainItemRequest(CoreIPC::Connection* connection, uint64_t requestID, const SecKeychainItemRequestData request)
@@ -128,7 +141,7 @@
// Since we don't want the connection work queue to be held up, we do all
// keychain interaction work on a global dispatch queue.
dispatch_queue_t keychainWorkQueue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);
-dispatch_async(keychainWorkQueue, bind(handleSecKeychainItemRequest, RefPtrCoreIPC::Connection(connection), requestID, request));
+dispatchFunctionOnQueue(keychainWorkQueue, bind(handleSecKeychainItemRequest, RefPtrCoreIPC::Connection(connection), requestID, request));
}
bool WebProcessProxy::fullKeyboardAccessEnabled()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104726] trunk/Source/WebCore
Title: [104726] trunk/Source/WebCore Revision 104726 Author dim...@chromium.org Date 2012-01-11 11:37:25 -0800 (Wed, 11 Jan 2012) Log Message Add new CSS enum value to a switch() in CSSStyleSelector::applyProperty() to fix compile error. https://bugs.webkit.org/show_bug.cgi?id=76081 Reviewed by David Levin. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSStyleSelector.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (104725 => 104726) --- trunk/Source/WebCore/ChangeLog 2012-01-11 19:26:25 UTC (rev 104725) +++ trunk/Source/WebCore/ChangeLog 2012-01-11 19:37:25 UTC (rev 104726) @@ -1,3 +1,13 @@ +2012-01-11 Dmitry Titov dim...@chromium.org + +Add new CSS enum value to a switch() in CSSStyleSelector::applyProperty() to fix compile error. +https://bugs.webkit.org/show_bug.cgi?id=76081 + +Reviewed by David Levin. + +* css/CSSStyleSelector.cpp: +(WebCore::CSSStyleSelector::applyProperty): + 2012-01-11 Alexey Proskuryakov a...@apple.com Reviewed by Darin Adler. Prepared by Sheriff Bot. Rolling out r94902. Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (104725 => 104726) --- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-01-11 19:26:25 UTC (rev 104725) +++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-01-11 19:37:25 UTC (rev 104726) @@ -3813,6 +3813,7 @@ case CSSPropertyWebkitColumnWidth: case CSSPropertyWebkitFlowInto: case CSSPropertyWebkitFlowFrom: +case CSSPropertyWebkitFontKerning: case CSSPropertyWebkitHighlight: case CSSPropertyWebkitHyphenateCharacter: case CSSPropertyWebkitHyphenateLimitAfter: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104727] trunk/Source/WebKit2
Title: [104727] trunk/Source/WebKit2
Revision 104727
Author ander...@apple.com
Date 2012-01-11 11:38:24 -0800 (Wed, 11 Jan 2012)
Log Message
Webpages flash white when switching between windows
https://bugs.webkit.org/show_bug.cgi?id=76080
rdar://problem/9893565
Reviewed by Dan Bernstein.
Introduce a _windowHasValidBackingStore boolean and only paint the background (white or clear)
if it's false.
* UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
Set _windowHasValidBackingStore to false if the new size is different from the old size.
(-[WKView viewDidMoveToWindow]):
Set _windowHasValidBackingStore to false.
(-[WKView _windowDidMiniaturize:]):
Set _windowHasValidBackingStore to false.
(-[WKView _windowDidChangeBackingProperties:]):
Set _windowHasValidBackingStore to false.
(-[WKView drawRect:]):
Only call drawPageBackground if _windowHasValidBackingStore is false. Set it to true after painting.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (104726 => 104727)
--- trunk/Source/WebKit2/ChangeLog 2012-01-11 19:37:25 UTC (rev 104726)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-11 19:38:24 UTC (rev 104727)
@@ -1,5 +1,32 @@
2012-01-11 Anders Carlsson ander...@apple.com
+Webpages flash white when switching between windows
+https://bugs.webkit.org/show_bug.cgi?id=76080
+rdar://problem/9893565
+
+Reviewed by Dan Bernstein.
+
+Introduce a _windowHasValidBackingStore boolean and only paint the background (white or clear)
+if it's false.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView setFrameSize:]):
+Set _windowHasValidBackingStore to false if the new size is different from the old size.
+
+(-[WKView viewDidMoveToWindow]):
+Set _windowHasValidBackingStore to false.
+
+(-[WKView _windowDidMiniaturize:]):
+Set _windowHasValidBackingStore to false.
+
+(-[WKView _windowDidChangeBackingProperties:]):
+Set _windowHasValidBackingStore to false.
+
+(-[WKView drawRect:]):
+Only call drawPageBackground if _windowHasValidBackingStore is false. Set it to true after painting.
+
+2012-01-11 Anders Carlsson ander...@apple.com
+
Fix the Mac GCC build.
Work around the fact that GCC doesn't work very well with Blocks and C++ objets.
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (104726 => 104727)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2012-01-11 19:37:25 UTC (rev 104726)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2012-01-11 19:38:24 UTC (rev 104727)
@@ -187,7 +187,14 @@
NSRect _windowBottomCornerIntersectionRect;
unsigned _frameSizeUpdatesDisabledCount;
+
+// Whether the containing window of the WKView has a valid backing store.
+// The window server invalidates the backing store whenever the window is resized or minimized.
+// We use this flag to determine when we need to paint the background (white or clear)
+// when the web process is unresponsive or takes too long to paint.
+BOOL _windowHasValidBackingStore;
}
+
@end
@implementation WKViewData
@@ -324,6 +331,9 @@
- (void)setFrameSize:(NSSize)size
{
+if (!NSEqualSizes(size, [self frame].size))
+_data-_windowHasValidBackingStore = NO;
+
[super setFrameSize:size];
if (![self frameSizeUpdatesDisabled])
@@ -1818,6 +1828,7 @@
// update the active state first and then make it visible. If the view is about to be hidden, we hide it first and then
// update the active state.
if ([self window]) {
+_data-_windowHasValidBackingStore = NO;
_data-_page-viewStateDidChange(WebPageProxy::ViewWindowIsActive);
_data-_page-viewStateDidChange(WebPageProxy::ViewIsVisible | WebPageProxy::ViewIsInWindow);
[self _updateWindowVisibility];
@@ -1883,6 +1894,8 @@
- (void)_windowDidMiniaturize:(NSNotification *)notification
{
+_data-_windowHasValidBackingStore = NO;
+
[self _updateWindowVisibility];
}
@@ -1919,6 +1932,7 @@
if (oldBackingScaleFactor == newBackingScaleFactor)
return;
+_data-_windowHasValidBackingStore = NO;
_data-_page-setIntrinsicDeviceScaleFactor(newBackingScaleFactor);
}
@@ -1963,9 +1977,15 @@
IntRect rect = enclosingIntRect(rectsBeingDrawn[i]);
drawingArea-paint(context, rect, unpaintedRegion);
-VectorIntRect unpaintedRects = unpaintedRegion.rects();
-for (size_t i = 0; i unpaintedRects.size(); ++i)
-drawPageBackground(context, _data-_page.get(), unpaintedRects[i]);
+// If the window doesn't have a valid backing store, we need to fill the parts of the page that we
+// didn't paint with the background color (white or clear), to avoid garbage in those areas.
+if (!_data-_windowHasValidBackingStore) {
+
[webkit-changes] [104728] trunk/Source/WebCore
Title: [104728] trunk/Source/WebCore
Revision 104728
Author noam.rosent...@nokia.com
Date 2012-01-11 11:49:40 -0800 (Wed, 11 Jan 2012)
Log Message
[Qt][Texmap] LayoutTests/compositing/masks/masked-ancestor does not render correctly.
https://bugs.webkit.org/show_bug.cgi?id=75910
Reviewed by Simon Hausmann.
Handle the mask surface correctly when drawing in two passes. Also, improve the readability
of the code that decides whether to draw in two passes.
LayoutTests/compositing/masks/masked-ancestor.html tests this.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::hasMoreThanOneTile):
(WebCore::TextureMapperNode::paintRecursive):
* platform/graphics/texmap/TextureMapperNode.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104727 => 104728)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 19:38:24 UTC (rev 104727)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 19:49:40 UTC (rev 104728)
@@ -1,3 +1,21 @@
+2012-01-11 No'am Rosenthal noam.rosent...@nokia.com
+
+[Qt][Texmap] LayoutTests/compositing/masks/masked-ancestor does not render correctly.
+https://bugs.webkit.org/show_bug.cgi?id=75910
+
+Reviewed by Simon Hausmann.
+
+Handle the mask surface correctly when drawing in two passes. Also, improve the readability
+of the code that decides whether to draw in two passes.
+
+LayoutTests/compositing/masks/masked-ancestor.html tests this.
+
+* platform/graphics/texmap/TextureMapperNode.cpp:
+(WebCore::TextureMapperNode::computeAllTransforms):
+(WebCore::TextureMapperNode::hasMoreThanOneTile):
+(WebCore::TextureMapperNode::paintRecursive):
+* platform/graphics/texmap/TextureMapperNode.h:
+
2012-01-11 Dmitry Titov dim...@chromium.org
Add new CSS enum value to a switch() in CSSStyleSelector::applyProperty() to fix compile error.
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp (104727 => 104728)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp 2012-01-11 19:38:24 UTC (rev 104727)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp 2012-01-11 19:49:40 UTC (rev 104728)
@@ -112,14 +112,15 @@
computeReplicaTransformIfNeeded();
computePerspectiveTransformIfNeeded();
-m_transforms.target = TransformationMatrix(m_parent ? m_parent-m_transforms.forDescendants : TransformationMatrix()).multiply(m_transforms.local);
+TextureMapperNode* parent = m_parent ? m_parent : m_effectTarget;
+m_transforms.target = TransformationMatrix(parent ? parent-m_transforms.forDescendants : TransformationMatrix()).multiply(m_transforms.local);
m_state.visible = m_state.backfaceVisibility || m_transforms.target.inverse().m33() = 0;
if (!m_state.visible)
return;
// This transform is only applied if using a two-pass for the replica, because the transform needs to be adjusted to the size of the intermediate surface, insteaf of the size of the content layer.
-if (m_parent m_parent-m_state.preserves3D)
+if (parent parent-m_state.preserves3D)
m_transforms.centerZ = m_transforms.target.mapPoint(FloatPoint3D(m_size.width() / 2, m_size.height() / 2, 0)).z();
if (!m_children.size())
@@ -248,6 +249,35 @@
}
#endif
+bool TextureMapperNode::hasMoreThanOneTile() const
+{
+int tiles = 0;
+
+#if USE(TILED_BACKING_STORE)
+if (m_state.tileOwnership == ExternallyManagedTiles) {
+HashMapint, ExternallyManagedTile::const_iterator end = m_externallyManagedTiles.end();
+for (HashMapint, ExternallyManagedTile::const_iterator it = m_externallyManagedTiles.begin(); it != end; ++it) {
+if (it-second.frontBuffer.texture) {
+if (++tiles 1)
+return true;
+}
+}
+
+return false;
+}
+#endif
+
+for (size_t i = 0; i m_ownedTiles.size(); ++i) {
+if (m_ownedTiles[i].texture) {
+if (++tiles 1)
+return true;
+}
+}
+
+return false;
+}
+
+
void TextureMapperNode::renderContent(TextureMapper* textureMapper, GraphicsLayer* layer)
{
#if USE(TILED_BACKING_STORE)
@@ -515,8 +545,14 @@
options.opacity *= m_opacity;
RefPtrBitmapTexture surface;
-const bool needsTwoPass = ((m_state.replicaLayer || m_state.maskLayer) !m_children.isEmpty()) || (m_opacity 0.99 m_state.mightHaveOverlaps) || (m_opacity 0.99 m_state.replicaLayer);
+
+bool hasReplica = m_state.replicaLayer;
+bool hasMask = m_state.maskLayer;
+bool needsBlending = m_opacity 0.99 || hasMask;
+bool paintsMoreThanOneTexture = !m_children.isEmpty() || hasMoreThanOneTile() || (hasMask
[webkit-changes] [104729] trunk/Tools
Title: [104729] trunk/Tools
Revision 104729
Author rn...@webkit.org
Date 2012-01-11 11:53:00 -0800 (Wed, 11 Jan 2012)
Log Message
last-green-revision should give us per-bot information
https://bugs.webkit.org/show_bug.cgi?id=76011
Reviewed by Adam Barth.
Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
we report the latest green run on each bot from the last 100 runs.
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(BuildBot._fetch_builder_page):
(BuildBot):
(BuildBot._green_revision_for_builder):
(BuildBot.last_green_revision):
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(test_green_revision_for_builder):
(test_last_green_revision):
* Scripts/webkitpy/tool/bot/irc_command.py:
(LastGreenRevision.execute):
* Scripts/webkitpy/tool/commands/queries.py:
(LastGreenRevision.execute):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_mock.py
trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py
trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/queries.py
Diff
Modified: trunk/Tools/ChangeLog (104728 => 104729)
--- trunk/Tools/ChangeLog 2012-01-11 19:49:40 UTC (rev 104728)
+++ trunk/Tools/ChangeLog 2012-01-11 19:53:00 UTC (rev 104729)
@@ -1,3 +1,26 @@
+2012-01-11 Ryosuke Niwa rn...@webkit.org
+
+last-green-revision should give us per-bot information
+https://bugs.webkit.org/show_bug.cgi?id=76011
+
+Reviewed by Adam Barth.
+
+Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
+we report the latest green run on each bot from the last 100 runs.
+
+* Scripts/webkitpy/common/net/buildbot/buildbot.py:
+(BuildBot._fetch_builder_page):
+(BuildBot):
+(BuildBot._green_revision_for_builder):
+(BuildBot.last_green_revision):
+* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
+(test_green_revision_for_builder):
+(test_last_green_revision):
+* Scripts/webkitpy/tool/bot/irc_command.py:
+(LastGreenRevision.execute):
+* Scripts/webkitpy/tool/commands/queries.py:
+(LastGreenRevision.execute):
+
2012-01-11 Dirk Pranke dpra...@chromium.org
webkitpy: clean up version detection in webkitpy.layout_tests.port
Modified: trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py (104728 => 104729)
--- trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py 2012-01-11 19:49:40 UTC (rev 104728)
+++ trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py 2012-01-11 19:53:00 UTC (rev 104729)
@@ -432,23 +432,39 @@
return build
build = build.previous_build()
-def last_green_revision(self):
-builds = self._latest_builds_from_builders()
-target_revision = builds[0].revision()
-# An alternate way to do this would be to start at one revision and walk backwards
-# checking builder.build_for_revision, however build_for_revision is very slow on first load.
-while True:
-# Make builds agree on revision
-builds = [self._build_at_or_before_revision(build, target_revision) for build in builds]
-if None in builds: # One of the builds failed to load from the server.
-return None
-min_revision = min(map(lambda build: build.revision(), builds))
-if min_revision != target_revision:
-target_revision = min_revision
-continue # Builds don't all agree on revision, keep searching
-# Check to make sure they're all green
-all_are_green = reduce(operator.and_, map(lambda build: build.is_green(), builds))
-if not all_are_green:
-target_revision -= 1
+def _fetch_builder_page(self, builder):
+builder_page_url = %s/builders/%s?numbuilds=100 % (self.buildbot_url, urllib2.quote(builder.name()))
+return urllib2.urlopen(builder_page_url)
+
+def _green_revision_for_builder(self, builder):
+soup = BeautifulSoup(self._fetch_builder_page(builder))
+revision = None
+number_of_revisions = 0
+for status_row in soup.find('table').findAll('tr'):
+revision_anchor = status_row.find('a')
+table_cells = status_row.findAll('td')
+if not revision_anchor or not table_cells or len(table_cells) 3 or not table_cells[2].string:
continue
-return min_revision
+number_of_revisions += 1
+if revision == None and 'success' in table_cells[2].string:
+revision = int(revision_anchor.string)
+return revision, number_of_revisions
+
+def last_green_revision(self,
[webkit-changes] [104730] branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot .cpp
Title: [104730] branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
Revision 104730
Author le...@chromium.org
Date 2012-01-11 11:57:12 -0800 (Wed, 11 Jan 2012)
Log Message
Rounding accumulatedOffset in nodeAtPoint when entering an SVG context to properly align to the root's actual rendering area
Modified Paths
branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp (104729 => 104730)
--- branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2012-01-11 19:53:00 UTC (rev 104729)
+++ branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2012-01-11 19:57:12 UTC (rev 104730)
@@ -434,7 +434,7 @@
bool RenderSVGRoot::nodeAtPoint(const HitTestRequest request, HitTestResult result, const LayoutPoint pointInContainer, const LayoutPoint accumulatedOffset, HitTestAction hitTestAction)
{
-LayoutPoint pointInParent = pointInContainer - toLayoutSize(accumulatedOffset);
+LayoutPoint pointInParent = pointInContainer - toLayoutSize(roundedIntPoint(accumulatedOffset));
LayoutPoint pointInBorderBox = pointInParent - parentOriginToBorderBox();
// Note: For now, we're ignoring hits to border and padding for svg
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104731] trunk/Tools
Title: [104731] trunk/Tools
Revision 104731
Author o...@chromium.org
Date 2012-01-11 12:01:24 -0800 (Wed, 11 Jan 2012)
Log Message
Be more aggressive about deleting unnecessary results from the test-results-server json files
https://bugs.webkit.org/show_bug.cgi?id=76086
Reviewed by Tony Chang.
Remove any tests that only contain skip/pass/nodata values whose runtime
is less than 5 seconds.
* TestResultServer/model/jsonresults.py:
(JsonResults._normalize_results_json):
* TestResultServer/model/jsonresults_unittest.py:
(JsonResultsTest.test_merge_remove_test):
(JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/model/jsonresults.py
trunk/Tools/TestResultServer/model/jsonresults_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (104730 => 104731)
--- trunk/Tools/ChangeLog 2012-01-11 19:57:12 UTC (rev 104730)
+++ trunk/Tools/ChangeLog 2012-01-11 20:01:24 UTC (rev 104731)
@@ -1,3 +1,19 @@
+2012-01-11 Ojan Vafai o...@chromium.org
+
+Be more aggressive about deleting unnecessary results from the test-results-server json files
+https://bugs.webkit.org/show_bug.cgi?id=76086
+
+Reviewed by Tony Chang.
+
+Remove any tests that only contain skip/pass/nodata values whose runtime
+is less than 5 seconds.
+
+* TestResultServer/model/jsonresults.py:
+(JsonResults._normalize_results_json):
+* TestResultServer/model/jsonresults_unittest.py:
+(JsonResultsTest.test_merge_remove_test):
+(JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
+
2012-01-11 Ryosuke Niwa rn...@webkit.org
last-green-revision should give us per-bot information
Modified: trunk/Tools/TestResultServer/model/jsonresults.py (104730 => 104731)
--- trunk/Tools/TestResultServer/model/jsonresults.py 2012-01-11 19:57:12 UTC (rev 104730)
+++ trunk/Tools/TestResultServer/model/jsonresults.py 2012-01-11 20:01:24 UTC (rev 104731)
@@ -44,8 +44,9 @@
JSON_RESULTS_RESULTS = results
JSON_RESULTS_TIMES = times
JSON_RESULTS_PASS = P
+JSON_RESULTS_SKIP = X
JSON_RESULTS_NO_DATA = N
-JSON_RESULTS_MIN_TIME = 1
+JSON_RESULTS_MIN_TIME = 5
JSON_RESULTS_HIERARCHICAL_VERSION = 4
JSON_RESULTS_MAX_BUILDS = 750
JSON_RESULTS_MAX_BUILDS_SMALL = 200
@@ -208,13 +209,17 @@
aggregated_test[JSON_RESULTS_RESULTS] = cls._remove_items_over_max_number_of_builds(aggregated_test[JSON_RESULTS_RESULTS], num_runs)
aggregated_test[JSON_RESULTS_TIMES] = cls._remove_items_over_max_number_of_builds(aggregated_test[JSON_RESULTS_TIMES], num_runs)
-is_all_pass = cls._is_results_all_of_type(aggregated_test[JSON_RESULTS_RESULTS], JSON_RESULTS_PASS)
-is_all_no_data = cls._is_results_all_of_type(aggregated_test[JSON_RESULTS_RESULTS], JSON_RESULTS_NO_DATA)
+deletable_types = set((JSON_RESULTS_PASS, JSON_RESULTS_NO_DATA, JSON_RESULTS_SKIP))
+for result in aggregated_test[JSON_RESULTS_RESULTS]:
+if result[1] not in deletable_types:
+return
-max_time = max([time[1] for time in aggregated_test[JSON_RESULTS_TIMES]])
-if (is_all_no_data or (is_all_pass and max_time JSON_RESULTS_MIN_TIME)):
-del aggregated_json[test_name]
+for time in aggregated_test[JSON_RESULTS_TIMES]:
+if time[1] = JSON_RESULTS_MIN_TIME:
+return
+del aggregated_json[test_name]
+
@classmethod
def _remove_items_over_max_number_of_builds(cls, encoded_list, num_runs):
num_builds = 0
Modified: trunk/Tools/TestResultServer/model/jsonresults_unittest.py (104730 => 104731)
--- trunk/Tools/TestResultServer/model/jsonresults_unittest.py 2012-01-11 19:57:12 UTC (rev 104730)
+++ trunk/Tools/TestResultServer/model/jsonresults_unittest.py 2012-01-11 20:01:24 UTC (rev 104731)
@@ -384,42 +384,20 @@
results: [[7,F]],
times: [[7,0]]}}})
-def test_merge_remove_test_with_no_data(self):
-# Remove test where there is no data in all runs.
+def test_merge_remove_test(self):
self._test_merge(
# Aggregated results
{builds: [2, 1],
tests: {001.html: {
- results: [[200,N]],
- times: [[200,0]]},
- 002.html: {
- results: [[10,F]],
- times: [[10,0]]}}},
-# Incremental results
-{builds: [3],
- tests: {001.html: {
- results: [[1,N]],
- times: [[1,0]]},
- 002.html: {
- results: [[1,P]],
- times: [[1,0]]}}},
-# Expected results
-{builds: [3, 2, 1],
- tests: {002.html: {
- results: [[1,P],[10,F]],
-
[webkit-changes] [104732] trunk
Title: [104732] trunk
Revision 104732
Author k...@google.com
Date 2012-01-11 12:17:13 -0800 (Wed, 11 Jan 2012)
Log Message
[chromium] Color profiles are incorrect for images without premultiplied alpha
https://bugs.webkit.org/show_bug.cgi?id=75999
Reviewed by Stephen White.
Source/WebCore:
Don't apply the color profile if the user has requested separate alpha.
Test: fast/canvas/webgl/texture-color-profile.html
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::setStatus):
LayoutTests:
Verify that the image's contents don't get destroyed if using both
separate alpha as well as the browser's colorspace conversion.
* fast/canvas/webgl/resources/tan-1x1-with-alpha.png: Added.
* fast/canvas/webgl/texture-color-profile-expected.txt: Added.
* fast/canvas/webgl/texture-color-profile.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp
Added Paths
trunk/LayoutTests/fast/canvas/webgl/resources/tan-1x1-with-alpha.png
trunk/LayoutTests/fast/canvas/webgl/texture-color-profile-expected.txt
trunk/LayoutTests/fast/canvas/webgl/texture-color-profile.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104731 => 104732)
--- trunk/LayoutTests/ChangeLog 2012-01-11 20:01:24 UTC (rev 104731)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 20:17:13 UTC (rev 104732)
@@ -1,3 +1,17 @@
+2012-01-11 Kenneth Russell k...@google.com
+
+[chromium] Color profiles are incorrect for images without premultiplied alpha
+https://bugs.webkit.org/show_bug.cgi?id=75999
+
+Reviewed by Stephen White.
+
+Verify that the image's contents don't get destroyed if using both
+separate alpha as well as the browser's colorspace conversion.
+
+* fast/canvas/webgl/resources/tan-1x1-with-alpha.png: Added.
+* fast/canvas/webgl/texture-color-profile-expected.txt: Added.
+* fast/canvas/webgl/texture-color-profile.html: Added.
+
2012-01-11 Joel Webber j...@google.com
Implement setCurrentTime() and pauseAnimations() on SVGSVGElement
Added: trunk/LayoutTests/fast/canvas/webgl/resources/tan-1x1-with-alpha.png (0 => 104732)
--- trunk/LayoutTests/fast/canvas/webgl/resources/tan-1x1-with-alpha.png (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/resources/tan-1x1-with-alpha.png 2012-01-11 20:17:13 UTC (rev 104732)
@@ -0,0 +1,27 @@
+\x89PNG
+
+
+IHDR ĉ
+OiCCPPhotoshop ICC profile xڝSgTS\xE9=\xF7\xDE\xF4BK\x88\x80\x94KoR RB\x8B\x80\x91*! J\x88!\xA1\xD9Q\xC1EEȠ\x88\x8E\x8E\x80\x8CQ, \x8A
+\xD8\xE4!\xA2\x8E\x83\xA3\x88\x8A\xCA\xFB\xE1{\xA3kּ\xF7\xE6\xCD\xFE\xB5\xD7\xE7\xAC\xF3\x9D\xB3\xCF\xC0 \x96H3Q5\x80 \xA9B \xE0\x83\xC7\xC4\xC6\xE1\xE4.@\x81
+$p \xB3d!s\xFD# \xF8~+\xC0\xBE x\xD3 \xC0M\x9B\xC00 \x87\xFF\xEAB\x99\\x80\x84\xC0t\x918K\x80 @z\x8EB\xA6 @F\x80\x9D\x98S \xA0 `\xCBcb\xE3 P- `'\xE6\xD3 \x80\x9D\xF8\x99{ [\x94!\xA0\x91 e\x88D h; \xAC\xCFV\x8AE X0 fK\xC49 \xD8- 0IWfH \xB0\xB7 \xC0\xCE \xB2 0Q\x88\x85) { `\xC8##x \x84\x99 F\xF2W\xF1+\xAE\xE7* x\x99\xB2\xB9$9E\x81[-qWW. (\xCEI+6aa\x9A@.\xC2y\x992\x814\xE0\xF3\xCC \xA0\x91\xE0\x83\xF3\xFDx\xCE\xAE\xCE\xCE6\x8E\xB6_-\xEA\xBF\xFFbb\xE3\xFE\xE5ϫp@ \xE1t~\xD1\xFE,/\xB3\x80;\x80m\xFE\xA2%\xEEh^ \xA0u\xF7\x8Bf\xB2@\xB5 \xA0\xE9\xDAW\xF3p\xF8~E\xA1\x90\xB9\xD9\xD9\xE5\xE4\xE4\xD8J\xC4B[a\xCAW}\xFEg\xC2_\xC0W\xFDl\xF9~\xFC\xF7\xF5\xE0\xBE\xE2$\x812]\x81G\xF8\xE0\xC2\xCC\xF4L\xA5 ϒ \x84b\xDC\xE6\x8FG\xFC\xB7 \xFF\xFC \xD3\xC4Ib\xB9X*\xE3Qq\x8ED\x9A\x8C\xF32\xA5\x89B\x92)\xC5%\xD2\xFFd\xE2\xDF,\xFB\xDF5 \xB0j{\x91-\xA8]c\xF6K'Xt\xC0\xE2\xF7 \xF2\xBBo\xC1\xD4(\x80h\x83\xE1\xCFw\xFF\xEF?\xFDG\xA0% \x80fI\x92q ^D$.Tʳ?\xC7 D\xA0\x81*\xB0A\xF4\xC1,\xC0 \xC1\xDC\xC1 \xFC`6\x84B$\xC4\xC2BB
+d\x80 r`)\xAC\x82B(\x86Ͱ *`/\xD4@ 4\xC0Qh\x86\x93p.\xC2U\xB8=p\xFAa\x9E\xC1(\xBC\x81 A\xC8a!ڈb\x8AX#\x8E\x99\x85\xF8!\xC1H\x8B$ ɈQK\x915H1R\x8AT UH \xF2=r9\x87\F\xBA\x91;\xC8 2\x82\xFC\x86\xBCG1\x94\x81\xB2Q=\xD4 \xB5C\xB9\xA87\x84F\xA2 \xD0dt1\x9A\x8F\xA0\x9B\xD0r\xB4=\x8C6\xA1\xE7ЫhڏC\xC70\xC0\xE83\xC4l0.\xC6\xC3B\xB18, \x93c˱\xAC \xAB\xC6\xB0V\xAC\xBB\x89\xF5cϱw\x81E\xC0 6wB a AHXLXN\xD8H\xA8 $4\xDA 7 \x84Q\xC2'\x93\xA8K\xB4\xBA\xF9\xC4b21\x87XH,#\xD6\x8F/{\x88C\xC47$\x89C2'\xB9\x90I\xB1\xA4T\xD2\xD2F\xD2nR#\xE9,\xA9\x9B4H#\x93\xC9\xDAdk\xB29\x94, +ȅ\xE4\x9D\xE4\xC3\xE43\xE4\xE4!\xF2[
+\x9Db@q\xA4\xF8S\xE2(R\xCAjJ\xE5\xE54\xE5e\x982AU\xA3\x9ARݨ\xA1T5\x8FZB\xAD\xA1\xB6R\xAFQ\x87\xA84u\x9A9̓IK\xA5\xAD\xA2\x95\xD3hh\xF7i\xAF\xE8t\xBAݕ N\x97\xD0W\xD2\xCB\xE9G\xE8\x97\xE8\xF4w
+\x86\x83Ljg(\x9Bgw\xAF\x98L\xA6Ӌ\xC7T071\xEB\x98\xE7\x99\x99oUX*\xB6*|\x91\xCA
+\x95J\x95\x95*/T\xA9\xAA\xA6\xAAު U\xF3U\xCBT\x8F\xA9^S}\xAEFU3S\xE3\xA9 Ԗ\xABU\xAA\x9DP\xEBSSg\xA9;\xA8\x87\xAAg\xA8oT?\xA4~Y\xFD\x89Y\xC3L\xC3OC\xA4Q\xA0\xB1_\xE3\xBC\xC6 c\xB3x,!k
[webkit-changes] [104733] trunk/Tools
Title: [104733] trunk/Tools
Revision 104733
Author o...@chromium.org
Date 2012-01-11 12:38:36 -0800 (Wed, 11 Jan 2012)
Log Message
Remove gtest normalization code from the test results server
https://bugs.webkit.org/show_bug.cgi?id=76089
Reviewed by Tony Chang.
The normalization now happens on the gtest side.
* TestResultServer/model/jsonresults.py:
(JsonResults.merge):
* TestResultServer/model/jsonresults_unittest.py:
(JsonResultsTest.test_gtest):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/model/jsonresults.py
trunk/Tools/TestResultServer/model/jsonresults_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (104732 => 104733)
--- trunk/Tools/ChangeLog 2012-01-11 20:17:13 UTC (rev 104732)
+++ trunk/Tools/ChangeLog 2012-01-11 20:38:36 UTC (rev 104733)
@@ -1,5 +1,19 @@
2012-01-11 Ojan Vafai o...@chromium.org
+Remove gtest normalization code from the test results server
+https://bugs.webkit.org/show_bug.cgi?id=76089
+
+Reviewed by Tony Chang.
+
+The normalization now happens on the gtest side.
+
+* TestResultServer/model/jsonresults.py:
+(JsonResults.merge):
+* TestResultServer/model/jsonresults_unittest.py:
+(JsonResultsTest.test_gtest):
+
+2012-01-11 Ojan Vafai o...@chromium.org
+
Be more aggressive about deleting unnecessary results from the test-results-server json files
https://bugs.webkit.org/show_bug.cgi?id=76086
Modified: trunk/Tools/TestResultServer/model/jsonresults.py (104732 => 104733)
--- trunk/Tools/TestResultServer/model/jsonresults.py 2012-01-11 20:17:13 UTC (rev 104732)
+++ trunk/Tools/TestResultServer/model/jsonresults.py 2012-01-11 20:38:36 UTC (rev 104733)
@@ -233,24 +233,6 @@
return encoded_list
@classmethod
-def _is_results_all_of_type(cls, results, type):
-return len(results) == 1 and results[0][1] == type
-
-@classmethod
-def _remove_gtest_modifiers(cls, builder, json):
-tests = json[builder][JSON_RESULTS_TESTS]
-new_tests = {}
-for name, test in tests.items():
-new_name = name.replace('.FLAKY_', '.', 1)
-new_name = new_name.replace('.FAILS_', '.', 1)
-new_name = new_name.replace('.MAYBE_', '.', 1)
-new_name = new_name.replace('.DISABLED_', '.', 1)
-if new_name not in new_tests or test[JSON_RESULTS_RESULTS][0][1] != JSON_RESULTS_NO_DATA:
-new_tests[new_name] = test
-
-json[builder][JSON_RESULTS_TESTS] = new_tests
-
-@classmethod
def _check_json(cls, builder, json):
version = json[JSON_RESULTS_VERSION_KEY]
if version JSON_RESULTS_HIERARCHICAL_VERSION:
@@ -289,9 +271,6 @@
if not cls._check_json(builder, incremental_json):
return None
-# FIXME: We should probably avoid doing this for layout tests.
-cls._remove_gtest_modifiers(builder, incremental_json)
-
logging.info(Loading existing aggregated json...)
aggregated_json = cls._load_json(aggregated)
if not aggregated_json:
Modified: trunk/Tools/TestResultServer/model/jsonresults_unittest.py (104732 => 104733)
--- trunk/Tools/TestResultServer/model/jsonresults_unittest.py 2012-01-11 20:17:13 UTC (rev 104732)
+++ trunk/Tools/TestResultServer/model/jsonresults_unittest.py 2012-01-11 20:38:36 UTC (rev 104733)
@@ -655,7 +655,7 @@
# Expected results
{foo: {001.html:{}}, 002.html:{}})
-def test_remove_gtest_modifiers(self):
+def test_gtest(self):
self._test_merge(
# Aggregated results
{builds: [2, 1],
@@ -665,49 +665,30 @@
foo.bar2: {
results: [[100,I]],
times: [[100,0]]},
- foo.FAILS_bar3: {
- results: [[100,I]],
- times: [[100,0]]},
},
version: 3},
# Incremental results
{builds: [3],
- tests: {foo.DISABLED_bar: {
- results: [[1,F]],
- times: [[1,0]]},
- foo.FLAKY_bar2: {
- results: [[1,N]],
- times: [[1,0]]},
- foo.bar2: {
+ tests: {foo.bar2: {
results: [[1,I]],
times: [[1,0]]},
foo.bar3: {
- results: [[1,N]],
+ results: [[1,F]],
times: [[1,0]]},
- foo.FAILS_bar3: {
- results: [[1,I]],
- times: [[1,0]]},
- foo.MAYBE_bar4: {
- results: [[1,I]],
- times: [[1,0]]}},
+ },
version: 4},
[webkit-changes] [104734] trunk/Source/WebCore
Title: [104734] trunk/Source/WebCore
Revision 104734
Author commit-qu...@webkit.org
Date 2012-01-11 12:41:59 -0800 (Wed, 11 Jan 2012)
Log Message
[Coverity] Address some uninit constructor issues in WebCore/dom
https://bugs.webkit.org/show_bug.cgi?id=74977
Patch by Greg Billock gbill...@google.com on 2012-01-11
Reviewed by Ryosuke Niwa.
* css/SelectorChecker.h:
(WebCore::SelectorChecker::ParentStackFrame::ParentStackFrame):
* dom/DeviceMotionData.cpp:
(WebCore::DeviceMotionData::DeviceMotionData):
* dom/DeviceOrientation.cpp:
(WebCore::DeviceOrientation::DeviceOrientation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorChecker.h
trunk/Source/WebCore/dom/DeviceMotionData.cpp
trunk/Source/WebCore/dom/DeviceOrientation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104733 => 104734)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 20:38:36 UTC (rev 104733)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 20:41:59 UTC (rev 104734)
@@ -1,3 +1,17 @@
+2012-01-11 Greg Billock gbill...@google.com
+
+[Coverity] Address some uninit constructor issues in WebCore/dom
+https://bugs.webkit.org/show_bug.cgi?id=74977
+
+Reviewed by Ryosuke Niwa.
+
+* css/SelectorChecker.h:
+(WebCore::SelectorChecker::ParentStackFrame::ParentStackFrame):
+* dom/DeviceMotionData.cpp:
+(WebCore::DeviceMotionData::DeviceMotionData):
+* dom/DeviceOrientation.cpp:
+(WebCore::DeviceOrientation::DeviceOrientation):
+
2012-01-11 Kenneth Russell k...@google.com
[chromium] Color profiles are incorrect for images without premultiplied alpha
Modified: trunk/Source/WebCore/css/SelectorChecker.h (104733 => 104734)
--- trunk/Source/WebCore/css/SelectorChecker.h 2012-01-11 20:38:36 UTC (rev 104733)
+++ trunk/Source/WebCore/css/SelectorChecker.h 2012-01-11 20:41:59 UTC (rev 104734)
@@ -115,7 +115,7 @@
mutable HashSetLinkHash, LinkHashHash m_linksCheckedForVisitedState;
struct ParentStackFrame {
-ParentStackFrame() { }
+ParentStackFrame() : element(0) { }
ParentStackFrame(Element* element) : element(element) { }
Element* element;
Vectorunsigned, 4 identifierHashes;
Modified: trunk/Source/WebCore/dom/DeviceMotionData.cpp (104733 => 104734)
--- trunk/Source/WebCore/dom/DeviceMotionData.cpp 2012-01-11 20:38:36 UTC (rev 104733)
+++ trunk/Source/WebCore/dom/DeviceMotionData.cpp 2012-01-11 20:41:59 UTC (rev 104734)
@@ -76,6 +76,7 @@
DeviceMotionData::DeviceMotionData()
: m_canProvideInterval(false)
+, m_interval(0)
{
}
Modified: trunk/Source/WebCore/dom/DeviceOrientation.cpp (104733 => 104734)
--- trunk/Source/WebCore/dom/DeviceOrientation.cpp 2012-01-11 20:38:36 UTC (rev 104733)
+++ trunk/Source/WebCore/dom/DeviceOrientation.cpp 2012-01-11 20:41:59 UTC (rev 104734)
@@ -43,6 +43,9 @@
: m_canProvideAlpha(false)
, m_canProvideBeta(false)
, m_canProvideGamma(false)
+, m_alpha(0)
+, m_beta(0)
+, m_gamma(0)
{
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104735] trunk/Tools
Title: [104735] trunk/Tools
Revision 104735
Author o...@chromium.org
Date 2012-01-11 12:55:32 -0800 (Wed, 11 Jan 2012)
Log Message
Style skipped tests in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=76091
Reviewed by Tony Chang.
* TestResultServer/static-dashboards/dashboard_base.js:
Removed FLAKY from this list since we don't ever mark individual runs
as flaky. Also deleted an outdated line.
* TestResultServer/static-dashboards/flakiness_dashboard.html:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html
Diff
Modified: trunk/Tools/ChangeLog (104734 => 104735)
--- trunk/Tools/ChangeLog 2012-01-11 20:41:59 UTC (rev 104734)
+++ trunk/Tools/ChangeLog 2012-01-11 20:55:32 UTC (rev 104735)
@@ -1,5 +1,17 @@
2012-01-11 Ojan Vafai o...@chromium.org
+Style skipped tests in the flakiness dashboard
+https://bugs.webkit.org/show_bug.cgi?id=76091
+
+Reviewed by Tony Chang.
+
+* TestResultServer/static-dashboards/dashboard_base.js:
+Removed FLAKY from this list since we don't ever mark individual runs
+as flaky. Also deleted an outdated line.
+* TestResultServer/static-dashboards/flakiness_dashboard.html:
+
+2012-01-11 Ojan Vafai o...@chromium.org
+
Remove gtest normalization code from the test results server
https://bugs.webkit.org/show_bug.cgi?id=76089
Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (104734 => 104735)
--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2012-01-11 20:41:59 UTC (rev 104734)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2012-01-11 20:55:32 UTC (rev 104735)
@@ -67,9 +67,8 @@
var GTEST_EXPECTATIONS_MAP_ = {
'P': 'PASS',
'F': 'FAIL',
-'L': 'FLAKY',
'N': 'NO DATA',
-'X': 'DISABLED'
+'X': 'SKIPPED'
};
var LAYOUT_TEST_EXPECTATIONS_MAP_ = {
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html (104734 => 104735)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2012-01-11 20:41:59 UTC (rev 104734)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2012-01-11 20:55:32 UTC (rev 104735)
@@ -152,6 +152,9 @@
.N {
background-color: #fff;
}
+.X {
+background-color: lightgray;
+}
.C {
background-color: #ffc343;
}
@@ -2464,8 +2467,7 @@
}
var html = 'div id=legend-toggle _onclick_=hideLegend()Hide ' +
-'legend [type esc]/divdivNumber of flaky tests listed next to ' +
-'each builder/divdiv id=legend-contents';
+'legend [type esc]/divdiv id=legend-contents';
for (var expectation in expectationsMap())
html += 'div class=' + expectation + '' + expectationsMap()[expectation] + '/div';
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104736] trunk
Title: [104736] trunk
Revision 104736
Author commit-qu...@webkit.org
Date 2012-01-11 13:06:31 -0800 (Wed, 11 Jan 2012)
Log Message
[v8] Int16Array.set(array, offset) fails on first execution
https://bugs.webkit.org/show_bug.cgi?id=76040
Patch by Ulan Degenbaev u...@chromium.org on 2012-01-11
Reviewed by Kenneth Russell.
* LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt: Added.
* LayoutTests/fast/canvas/webgl/array-set-with-offset.html: Added.
* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h
Added Paths
trunk/LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt
trunk/LayoutTests/fast/canvas/webgl/array-set-with-offset.html
Diff
Modified: trunk/ChangeLog (104735 => 104736)
--- trunk/ChangeLog 2012-01-11 20:55:32 UTC (rev 104735)
+++ trunk/ChangeLog 2012-01-11 21:06:31 UTC (rev 104736)
@@ -1,3 +1,15 @@
+2012-01-11 Ulan Degenbaev u...@chromium.org
+
+[v8] Int16Array.set(array, offset) fails on first execution
+https://bugs.webkit.org/show_bug.cgi?id=76040
+
+Reviewed by Kenneth Russell.
+
+* LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt: Added.
+* LayoutTests/fast/canvas/webgl/array-set-with-offset.html: Added.
+* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
+* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
+
2012-01-11 Eli Fidler efid...@rim.com
Fix OpenGL dependency in CMake build system
Added: trunk/LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt (0 => 104736)
--- trunk/LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt 2012-01-11 21:06:31 UTC (rev 104736)
@@ -0,0 +1,51 @@
+Test setting WebGL array with offset
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+Regression test for https://bugs.webkit.org/show_bug.cgi?id=76040 : Int16Array.set(array, offset) fails on first execution
+Testing Int8Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Uint8Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Int16Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Uint16Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Int32Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Uint32Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Float32Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/canvas/webgl/array-set-with-offset.html (0 => 104736)
--- trunk/LayoutTests/fast/canvas/webgl/array-set-with-offset.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/array-set-with-offset.html 2012-01-11 21:06:31 UTC (rev 104736)
@@ -0,0 +1,45 @@
+html
+head
+script src=""
+script src=""
+/head
+body
+div id=description/div
+div id=console/div
+
+script
+description(Test setting WebGL array with offset);
+
+debug('Regression test for a href="" : codeInt16Array.set(array, offset) fails on first execution/code');
+
+var webGLArray = null;
+var array = null;
+var bounds = null;
+
+function testSetters(typeName, low, high) {
+bounds = [low, high];
+var type = window[typeName];
+var array_buffer = new ArrayBuffer(32);
+webGLArray = new type(array_buffer);
+debug(Testing + typeName);
+array = [1, 2, low, high];
+webGLArray.set(array, 1);
+shouldBe(webGLArray[0], 0);
+shouldBe(webGLArray[1], 1);
+shouldBe(webGLArray[2], 2);
+shouldBe(webGLArray[3], bounds[0]);
+shouldBe(webGLArray[4], bounds[1]);
+}
+
+testSetters(Int8Array, -128, 127);
+testSetters(Uint8Array, 0, 255);
+testSetters(Int16Array, -32768, 32767);
+testSetters(Uint16Array, 0, 65535);
+testSetters(Int32Array, -2147483648, 2147483647);
+testSetters(Uint32Array, 0, 4294967295);
+testSetters(Float32Array, -2.5, 3.5);
+/script
+
+script src=""
+/body
+/html
Modified:
[webkit-changes] [104737] trunk/LayoutTests
Title: [104737] trunk/LayoutTests Revision 104737 Author commit-qu...@webkit.org Date 2012-01-11 13:12:21 -0800 (Wed, 11 Jan 2012) Log Message Webaudio layout tests need to override the WebKitWebAudioEnabled https://bugs.webkit.org/show_bug.cgi?id=76066 Patch by Raymond Toy r...@google.com on 2012-01-11 Reviewed by Tony Chang. * webaudio/convolution-mono-mono.html: Load audio-testing.js to add override for WebKitWebAudioEnabled. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/webaudio/convolution-mono-mono.html Diff Modified: trunk/LayoutTests/ChangeLog (104736 => 104737) --- trunk/LayoutTests/ChangeLog 2012-01-11 21:06:31 UTC (rev 104736) +++ trunk/LayoutTests/ChangeLog 2012-01-11 21:12:21 UTC (rev 104737) @@ -1,3 +1,13 @@ +2012-01-11 Raymond Toy r...@google.com + +Webaudio layout tests need to override the WebKitWebAudioEnabled +https://bugs.webkit.org/show_bug.cgi?id=76066 + +Reviewed by Tony Chang. + +* webaudio/convolution-mono-mono.html: +Load audio-testing.js to add override for WebKitWebAudioEnabled. + 2012-01-11 Kenneth Russell k...@google.com [chromium] Color profiles are incorrect for images without premultiplied alpha Modified: trunk/LayoutTests/webaudio/convolution-mono-mono.html (104736 => 104737) --- trunk/LayoutTests/webaudio/convolution-mono-mono.html 2012-01-11 21:06:31 UTC (rev 104736) +++ trunk/LayoutTests/webaudio/convolution-mono-mono.html 2012-01-11 21:12:21 UTC (rev 104737) @@ -3,6 +3,7 @@ html head link rel=stylesheet href="" +script type=text/_javascript_ src="" script src="" script src="" /head ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104738] trunk/Source/WebKit
Title: [104738] trunk/Source/WebKit
Revision 104738
Author commit-qu...@webkit.org
Date 2012-01-11 13:23:20 -0800 (Wed, 11 Jan 2012)
Log Message
[BlackBerry] ASSERT failure in BackingStorePrivate::blitVisibleContents()
https://bugs.webkit.org/show_bug.cgi?id=76096
Patch by Jacky Jiang zhaji...@rim.com on 2012-01-11
Reviewed by Rob Buis.
We shouldn't blit visible contents for direct rendering. Guard it from
call sites.
* blackberry/Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/blackberry/Api/BackingStore.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (104737 => 104738)
--- trunk/Source/WebKit/ChangeLog 2012-01-11 21:12:21 UTC (rev 104737)
+++ trunk/Source/WebKit/ChangeLog 2012-01-11 21:23:20 UTC (rev 104738)
@@ -1,3 +1,17 @@
+2012-01-11 Jacky Jiang zhaji...@rim.com
+
+[BlackBerry] ASSERT failure in BackingStorePrivate::blitVisibleContents()
+https://bugs.webkit.org/show_bug.cgi?id=76096
+
+Reviewed by Rob Buis.
+
+We shouldn't blit visible contents for direct rendering. Guard it from
+call sites.
+
+* blackberry/Api/BackingStore.cpp:
+(BlackBerry::WebKit::BackingStorePrivate::repaint):
+(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
+
2012-01-11 Rafael Brandao rafael.l...@openbossa.org
[Qt][WK2] Fix the build for newer Qt5
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (104737 => 104738)
--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-01-11 21:12:21 UTC (rev 104737)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-01-11 21:23:20 UTC (rev 104738)
@@ -333,7 +333,7 @@
#endif
if (immediate) {
-if (render(rect))
+if (render(rect) !shouldDirectRenderingToWindow())
blitVisibleContents();
} else
m_renderQueue-addToQueue(RenderQueue::RegularRender, rect);
@@ -354,7 +354,7 @@
Platform::IntRect rect = m_webPage-d-mapToTransformed(m_client-mapFromViewportToContents(windowRect));
if (immediate) {
-if (render(rect) !isSuspended())
+if (render(rect) !isSuspended() !shouldDirectRenderingToWindow())
blitVisibleContents();
} else {
m_renderQueue-addToQueue(RenderQueue::VisibleScroll, rect);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104739] trunk/Tools
Title: [104739] trunk/Tools Revision 104739 Author dpra...@chromium.org Date 2012-01-11 13:36:24 -0800 (Wed, 11 Jan 2012) Log Message webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost https://bugs.webkit.org/show_bug.cgi?id=76084 Reviewed by Adam Barth. This will help make it easier to catch layering violations. This change just refactors test code; there are no changes to production code. * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.make_port): (PortTest.test_find_no_paths_specified): (PortTest.test_find_one_test): (PortTest.test_find_glob): (PortTest.test_find_with_skipped_directories): (PortTest.test_find_with_skipped_directories_2): (PortTest.test_parse_reftest_list): (PortTest.test_httpd_returns_error_code): (PortTest.test_virtual_methods): * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: (ChromiumGpuTest.assert_port_works): (ChromiumGpuTest._assert_baseline_path): (ChromiumGpuTest.test_graphics_type): (ChromiumGpuTest.test_default_tests_paths.test_paths): (ChromiumGpuTest.test_test_files): (ChromiumGpuTest.test_test_files.test_paths): (ChromiumGpuTest): * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: (ChromiumLinuxPortTest.assert_architecture): (ChromiumLinuxPortTest.test_check_illegal_port_names): (ChromiumLinuxPortTest.test_determine_architecture_fails): * Scripts/webkitpy/layout_tests/port/driver_unittest.py: (DriverTest.make_port): (DriverTest): (DriverTest.assertVirtual): (DriverTest._assert_wrapper): (DriverTest.test_virtual_driver_methods): * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: (MockDRTPortTest.make_port): (MockDRTPortTest.test_port_name_in_constructor): (MockDRTTest.assertTest): (MockDRTTest.test_main): (MockChromiumDRTTest.test_pixeltest__fails): * Scripts/webkitpy/layout_tests/port/qt_unittest.py: (QtPortTest._assert_search_path): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (TestWebKitPort.__init__): (WebKitPortUnitTests.test_default_options): (test_runtime_feature_list): (test_test_expectations): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py Diff Modified: trunk/Tools/ChangeLog (104738 => 104739) --- trunk/Tools/ChangeLog 2012-01-11 21:23:20 UTC (rev 104738) +++ trunk/Tools/ChangeLog 2012-01-11 21:36:24 UTC (rev 104739) @@ -1,3 +1,56 @@ +2012-01-11 Dirk Pranke dpra...@chromium.org + +webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost +https://bugs.webkit.org/show_bug.cgi?id=76084 + +Reviewed by Adam Barth. + +This will help make it easier to catch layering violations. This +change just refactors test code; there are no changes to +production code. + +* Scripts/webkitpy/layout_tests/port/base_unittest.py: +(PortTest.make_port): +(PortTest.test_find_no_paths_specified): +(PortTest.test_find_one_test): +(PortTest.test_find_glob): +(PortTest.test_find_with_skipped_directories): +(PortTest.test_find_with_skipped_directories_2): +(PortTest.test_parse_reftest_list): +(PortTest.test_httpd_returns_error_code): +(PortTest.test_virtual_methods): +* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: +(ChromiumGpuTest.assert_port_works): +(ChromiumGpuTest._assert_baseline_path): +(ChromiumGpuTest.test_graphics_type): +(ChromiumGpuTest.test_default_tests_paths.test_paths): +(ChromiumGpuTest.test_test_files): +(ChromiumGpuTest.test_test_files.test_paths): +(ChromiumGpuTest): +* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: +(ChromiumLinuxPortTest.assert_architecture): +(ChromiumLinuxPortTest.test_check_illegal_port_names): +(ChromiumLinuxPortTest.test_determine_architecture_fails): +* Scripts/webkitpy/layout_tests/port/driver_unittest.py: +(DriverTest.make_port): +(DriverTest): +(DriverTest.assertVirtual): +(DriverTest._assert_wrapper): +(DriverTest.test_virtual_driver_methods): +* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: +(MockDRTPortTest.make_port): +(MockDRTPortTest.test_port_name_in_constructor): +(MockDRTTest.assertTest): +(MockDRTTest.test_main): +(MockChromiumDRTTest.test_pixeltest__fails): +* Scripts/webkitpy/layout_tests/port/qt_unittest.py: +(QtPortTest._assert_search_path): +*
[webkit-changes] [104740] trunk/Tools
Title: [104740] trunk/Tools
Revision 104740
Author dpra...@chromium.org
Date 2012-01-11 13:42:22 -0800 (Wed, 11 Jan 2012)
Log Message
test-webkitpy: fix -v and eliminate some spurious warnings
https://bugs.webkit.org/show_bug.cgi?id=76099
Reviewed by Adam Barth.
when we added support for --xml output, we broke the -v flag.
Also, fix the code to swallow a harmless warning from
VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
test-webkitpy is now silent again except for the one known
logging issue.
* Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.commit_message_for_this_commit):
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(test_commit_message_for_this_commit):
* Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONChecker.check):
(JSONChecker.line_number_from_json_exception):
* Scripts/webkitpy/test/main.py:
(Tester.run_tests):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py
trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py
trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
trunk/Tools/Scripts/webkitpy/test/main.py
Diff
Modified: trunk/Tools/ChangeLog (104739 => 104740)
--- trunk/Tools/ChangeLog 2012-01-11 21:36:24 UTC (rev 104739)
+++ trunk/Tools/ChangeLog 2012-01-11 21:42:22 UTC (rev 104740)
@@ -1,5 +1,30 @@
2012-01-11 Dirk Pranke dpra...@chromium.org
+test-webkitpy: fix -v and eliminate some spurious warnings
+https://bugs.webkit.org/show_bug.cgi?id=76099
+
+Reviewed by Adam Barth.
+
+when we added support for --xml output, we broke the -v flag.
+
+Also, fix the code to swallow a harmless warning from
+VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
+
+test-webkitpy is now silent again except for the one known
+logging issue.
+
+* Scripts/webkitpy/common/checkout/checkout.py:
+(Checkout.commit_message_for_this_commit):
+* Scripts/webkitpy/common/checkout/checkout_unittest.py:
+(test_commit_message_for_this_commit):
+* Scripts/webkitpy/style/checkers/jsonchecker.py:
+(JSONChecker.check):
+(JSONChecker.line_number_from_json_exception):
+* Scripts/webkitpy/test/main.py:
+(Tester.run_tests):
+
+2012-01-11 Dirk Pranke dpra...@chromium.org
+
webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
https://bugs.webkit.org/show_bug.cgi?id=76084
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py (104739 => 104740)
--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py 2012-01-11 21:36:24 UTC (rev 104739)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py 2012-01-11 21:42:22 UTC (rev 104740)
@@ -1,9 +1,9 @@
# Copyright (c) 2010 Google Inc. All rights reserved.
-#
+#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
-#
+#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above
@@ -13,7 +13,7 @@
# * Neither the name of Google Inc. nor the names of its
# contributors may be used to endorse or promote products derived from
# this software without specific prior written permission.
-#
+#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
@@ -121,13 +121,13 @@
def modified_non_changelogs(self, git_commit, changed_files=None):
return self._modified_files_matching_predicate(git_commit, lambda path: not self.is_path_to_changelog(path), changed_files=changed_files)
-def commit_message_for_this_commit(self, git_commit, changed_files=None):
+def commit_message_for_this_commit(self, git_commit, changed_files=None, return_stderr=False):
changelog_paths = self.modified_changelogs(git_commit, changed_files)
if not len(changelog_paths):
raise ScriptError(message=Found no modified ChangeLogs, cannot create a commit message.\n
All changes require a ChangeLog. See:\n %s % urls.contribution_guidelines)
-message_text = self._scm.run([self._scm.script_path('commit-log-editor'), '--print-log'] + changelog_paths, return_stderr=False)
+message_text = self._scm.run([self._scm.script_path('commit-log-editor'), '--print-log'] + changelog_paths, return_stderr=return_stderr)
return CommitMessage(message_text.splitlines())
def recent_commit_infos_for_files(self, paths):
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py (104739 => 104740)
--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py 2012-01-11 21:36:24
[webkit-changes] [104742] trunk/Source/WebCore
Title: [104742] trunk/Source/WebCore
Revision 104742
Author commit-qu...@webkit.org
Date 2012-01-11 13:52:38 -0800 (Wed, 11 Jan 2012)
Log Message
[chromium] Make Skia canvas opaque for root layer tiles
https://bugs.webkit.org/show_bug.cgi?id=75939
Patch by Alexandre Elias ael...@google.com on 2012-01-11
Reviewed by James Robinson.
Skia has extra optimizations if a bitmap has the opaque flag -- in
particular, it doesn't do an unnecessary memset at creation time.
Pass down the LayerChromium's opaque flag to Skia.
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::setIsNonCompositedContent):
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::setIsNonCompositedContent):
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::PlatformCanvas):
(WebCore::PlatformCanvas::resize):
* platform/graphics/chromium/PlatformCanvas.h:
(WebCore::PlatformCanvas::setOpaque):
(WebCore::PlatformCanvas::opaque):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setIsNonCompositedContent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp
trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h
trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h
trunk/Source/WebCore/platform/graphics/chromium/PlatformCanvas.cpp
trunk/Source/WebCore/platform/graphics/chromium/PlatformCanvas.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104741 => 104742)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 21:43:15 UTC (rev 104741)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 21:52:38 UTC (rev 104742)
@@ -1,3 +1,30 @@
+2012-01-11 Alexandre Elias ael...@google.com
+
+[chromium] Make Skia canvas opaque for root layer tiles
+https://bugs.webkit.org/show_bug.cgi?id=75939
+
+Reviewed by James Robinson.
+
+Skia has extra optimizations if a bitmap has the opaque flag -- in
+particular, it doesn't do an unnecessary memset at creation time.
+Pass down the LayerChromium's opaque flag to Skia.
+
+* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
+(WebCore::BitmapCanvasLayerTextureUpdater::setIsNonCompositedContent):
+* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
+* platform/graphics/chromium/ContentLayerChromium.cpp:
+(WebCore::ContentLayerChromium::createTextureUpdater):
+* platform/graphics/chromium/LayerTextureUpdater.h:
+(WebCore::LayerTextureUpdater::setIsNonCompositedContent):
+* platform/graphics/chromium/PlatformCanvas.cpp:
+(WebCore::PlatformCanvas::PlatformCanvas):
+(WebCore::PlatformCanvas::resize):
+* platform/graphics/chromium/PlatformCanvas.h:
+(WebCore::PlatformCanvas::setOpaque):
+(WebCore::PlatformCanvas::opaque):
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::setIsNonCompositedContent):
+
2012-01-11 Greg Billock gbill...@google.com
[Coverity] Address some uninit constructor issues in WebCore/dom
Modified: trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp (104741 => 104742)
--- trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp 2012-01-11 21:43:15 UTC (rev 104741)
+++ trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp 2012-01-11 21:52:38 UTC (rev 104742)
@@ -99,5 +99,10 @@
m_texSubImage.upload(locker.pixels(), contentRect(), sourceRect, destRect, texture-format(), context);
}
+void BitmapCanvasLayerTextureUpdater::setOpaque(bool opaque)
+{
+m_canvas.setOpaque(opaque);
+}
+
} // namespace WebCore
#endif // USE(ACCELERATED_COMPOSITING)
Modified: trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h (104741 => 104742)
--- trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h 2012-01-11 21:43:15 UTC (rev 104741)
+++ trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h 2012-01-11 21:52:38 UTC (rev 104742)
@@ -63,6 +63,8 @@
virtual void prepareToUpdate(const IntRect contentRect, const IntSize tileSize, int borderTexels, float contentsScale);
void updateTextureRect(GraphicsContext3D*, TextureAllocator*, ManagedTexture*, const IntRect sourceRect, const IntRect destRect);
+virtual void setOpaque(bool);
+
private:
[webkit-changes] [104743] trunk/Source/WebKit2
Title: [104743] trunk/Source/WebKit2 Revision 104743 Author bfulg...@webkit.org Date 2012-01-11 13:52:44 -0800 (Wed, 11 Jan 2012) Log Message WinCairo build correction. * UIProcess/WebPageProxy.h: Don't define viewWidget for WinCairo port. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebPageProxy.h Diff Modified: trunk/Source/WebKit2/ChangeLog (104742 => 104743) --- trunk/Source/WebKit2/ChangeLog 2012-01-11 21:52:38 UTC (rev 104742) +++ trunk/Source/WebKit2/ChangeLog 2012-01-11 21:52:44 UTC (rev 104743) @@ -1,3 +1,9 @@ +2012-01-11 Brent Fulgham bfulg...@webkit.org + +WinCairo build correction. + +* UIProcess/WebPageProxy.h: Don't define viewWidget for WinCairo port. + 2012-01-11 Anders Carlsson ander...@apple.com Webpages flash white when switching between windows @@ -7,8 +13,6 @@ Reviewed by Dan Bernstein. Introduce a _windowHasValidBackingStore boolean and only paint the background (white or clear) -if it's false. - * UIProcess/API/mac/WKView.mm: (-[WKView setFrameSize:]): Set _windowHasValidBackingStore to false if the new size is different from the old size. Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (104742 => 104743) --- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2012-01-11 21:52:38 UTC (rev 104742) +++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2012-01-11 21:52:44 UTC (rev 104743) @@ -364,7 +364,7 @@ HWND nativeWindow() const; #endif -#if USE(CAIRO) +#if USE(CAIRO) !PLATFORM(WIN_CAIRO) PlatformWidget viewWidget(); #endif #if USE(TILED_BACKING_STORE) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104745] trunk/Tools
Title: [104745] trunk/Tools
Revision 104745
Author joc...@chromium.org
Date 2012-01-11 14:10:18 -0800 (Wed, 11 Jan 2012)
Log Message
[Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
https://bugs.webkit.org/show_bug.cgi?id=75618
Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
Reviewed by Tony Chang.
* DumpRenderTree/chromium/LayoutTestHelper.mm:
(installLayoutTestColorProfile):
(restoreUserColorProfile):
(main):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestHelper.mm
Diff
Modified: trunk/Tools/ChangeLog (104744 => 104745)
--- trunk/Tools/ChangeLog 2012-01-11 22:01:29 UTC (rev 104744)
+++ trunk/Tools/ChangeLog 2012-01-11 22:10:18 UTC (rev 104745)
@@ -1,3 +1,17 @@
+2012-01-11 Jochen Eisinger joc...@chromium.org
+
+[Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
+https://bugs.webkit.org/show_bug.cgi?id=75618
+
+Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
+
+Reviewed by Tony Chang.
+
+* DumpRenderTree/chromium/LayoutTestHelper.mm:
+(installLayoutTestColorProfile):
+(restoreUserColorProfile):
+(main):
+
2012-01-11 Dirk Pranke dpra...@chromium.org
test-webkitpy: fix -v and eliminate some spurious warnings
Modified: trunk/Tools/DumpRenderTree/chromium/LayoutTestHelper.mm (104744 => 104745)
--- trunk/Tools/DumpRenderTree/chromium/LayoutTestHelper.mm 2012-01-11 22:01:29 UTC (rev 104744)
+++ trunk/Tools/DumpRenderTree/chromium/LayoutTestHelper.mm 2012-01-11 22:10:18 UTC (rev 104745)
@@ -38,49 +38,56 @@
// test script, so it can do the job for multiple DumpRenderTree while they are
// running layout tests.
-static CMProfileRef userColorProfile = 0;
+namespace {
-static void saveCurrentColorProfile()
-{
-CGDirectDisplayID displayID = CGMainDisplayID();
-CMProfileRef previousProfile;
-CMError error = CMGetProfileByAVID((UInt32)displayID, previousProfile);
-if (error) {
-NSLog(@failed to get the current color profile, pixmaps won't match.
- @Error: %d, (int)error);
-} else {
-userColorProfile = previousProfile;
-}
-}
+const char colorProfilePath[] = /System/Library/ColorSync/Profiles/Generic RGB Profile.icc;
+CMProfileLocation initialColorProfileLocation; // The locType field is initialized to 0 which is the same as cmNoProfileBase.
+
+} // namespace
+
static void installLayoutTestColorProfile()
{
// To make sure we get consistent colors (not dependent on the Main display),
// we force the generic rgb color profile. This cases a change the user can
// see.
+const CMDeviceScope scope = { kCFPreferencesCurrentUser, kCFPreferencesCurrentHost };
-CGDirectDisplayID displayID = CGMainDisplayID();
-NSColorSpace* genericSpace = [NSColorSpace genericRGBColorSpace];
-CMProfileRef genericProfile = (CMProfileRef)[genericSpace colorSyncProfile];
-CMError error = CMSetProfileByAVID((UInt32)displayID, genericProfile);
+CMProfileRef profile = ""
+int error = CMGetProfileByAVID((CMDisplayIDType)kCGDirectMainDisplay, profile);
+if (!error) {
+UInt32 size = sizeof(initialColorProfileLocation);
+error = NCMGetProfileLocation(profile, initialColorProfileLocation, size);
+CMCloseProfile(profile);
+}
if (error) {
-NSLog(@failed install the generic color profile, pixmaps won't match.
- @Error: %d, (int)error);
+NSLog(@failed to get the current color profile, pixmaps won't match. Error: %d, (int)error);
+initialColorProfileLocation.locType = cmNoProfileBase;
+return;
}
+
+CMProfileLocation location;
+location.locType = cmPathBasedProfile;
+strncpy(location.u.pathLoc.path, colorProfilePath, sizeof(location.u.pathLoc.path));
+error = CMSetDeviceProfile(cmDisplayDeviceClass, (CMDeviceID)kCGDirectMainDisplay, scope, cmDefaultProfileID, location);
+if (error) {
+NSLog(@failed install the generic color profile, pixmaps won't match. Error: %d, (int)error);
+initialColorProfileLocation.locType = cmNoProfileBase;
+}
}
static void restoreUserColorProfile(void)
{
-if (!userColorProfile)
-return;
-CGDirectDisplayID displayID = CGMainDisplayID();
-CMError error = CMSetProfileByAVID((UInt32)displayID, userColorProfile);
-CMCloseProfile(userColorProfile);
-if (error) {
-NSLog(@Failed to restore color profile, use System Preferences -
- @Displays - Color to reset. Error: %d, (int)error);
+// This is used as a signal handler, and thus the calls into ColorSync are unsafe.
+// But we might as well try to restore the user's color profile, we're going down anyway...
+if (initialColorProfileLocation.locType != cmNoProfileBase) {
+const
[webkit-changes] [104746] trunk/Source/WebCore
Title: [104746] trunk/Source/WebCore Revision 104746 Author commit-qu...@webkit.org Date 2012-01-11 14:13:24 -0800 (Wed, 11 Jan 2012) Log Message https://bugs.webkit.org/show_bug.cgi?id=76088 The common case of content type = text/plain is not optimized and the plugin database is initialized instead In the dom/DOMImplementation.cpp file you can find the comment that text/plain is optimized so that the plugin database is not loaded. Unfortunately, this has been regressed since the patch for http://bugs.webkit.org/show_bug.cgi?id=16815 which refactored a bunch of the plugin code. Now, the plugin database is initialized before we handle text/plain. This line in DOMImplementation.cpp triggers the plugin initialization: pluginData = frame-page()-pluginData(); The case of image types != PDF and the case of HTML5 video content type are also not optimized to be handled before plugin initialization. The solution is to refactor so all of these content types are handled before we initialize the plugin database. Patch by Adam Treat atr...@rim.com on 2012-01-11 Reviewed by Adam Treat. * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/DOMImplementation.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (104745 => 104746) --- trunk/Source/WebCore/ChangeLog 2012-01-11 22:10:18 UTC (rev 104745) +++ trunk/Source/WebCore/ChangeLog 2012-01-11 22:13:24 UTC (rev 104746) @@ -1,3 +1,28 @@ +2012-01-11 Adam Treat atr...@rim.com + +https://bugs.webkit.org/show_bug.cgi?id=76088 +The common case of content type = text/plain is not optimized and the plugin database is initialized instead + +In the dom/DOMImplementation.cpp file you can find the comment that text/plain is +optimized so that the plugin database is not loaded. Unfortunately, this has been +regressed since the patch for http://bugs.webkit.org/show_bug.cgi?id=16815 which +refactored a bunch of the plugin code. Now, the plugin database is initialized +before we handle text/plain. This line in DOMImplementation.cpp triggers +the plugin initialization: + +pluginData = frame-page()-pluginData(); + +The case of image types != PDF and the case of HTML5 video content type are also +not optimized to be handled before plugin initialization. + +The solution is to refactor so all of these content types are handled before +we initialize the plugin database. + +Reviewed by Adam Treat. + +* dom/DOMImplementation.cpp: +(WebCore::DOMImplementation::createDocument): + 2012-01-11 Alexandre Elias ael...@google.com [chromium] Make Skia canvas opaque for root layer tiles Modified: trunk/Source/WebCore/dom/DOMImplementation.cpp (104745 => 104746) --- trunk/Source/WebCore/dom/DOMImplementation.cpp 2012-01-11 22:10:18 UTC (rev 104745) +++ trunk/Source/WebCore/dom/DOMImplementation.cpp 2012-01-11 22:13:24 UTC (rev 104746) @@ -318,37 +318,46 @@ // Plugins cannot take HTML and XHTML from us, and we don't even need to initialize the plugin database for those. if (type == text/html) return HTMLDocument::create(frame, url); + +// Plugins cannot take text/plain from us either. +if (type == text/plain) +return TextDocument::create(frame, url); + if (type == application/xhtml+xml) return Document::createXHTML(frame, url); #if ENABLE(FTPDIR) -// Plugins cannot take FTP from us either +// Plugins cannot take FTP from us either. if (type == application/x-ftp-directory) return FTPDirectoryDocument::create(frame, url); #endif +// PDF is the only image type for which a plugin can override built-in support. +if (Image::supportsType(type) type != application/pdf type != text/pdf) +return ImageDocument::create(frame, url); + +#if ENABLE(VIDEO) + // Check to see if the type can be played by our MediaPlayer, if so create a MediaDocument as + // this can not be taken by plugins either. + if (MediaPlayer::supportsType(ContentType(type))) + return MediaDocument::create(frame, url); +#endif + +// The plugin database is initialized at this point if plugins are enabled +// which is non-zero overhead. PluginData* pluginData = 0; if (frame frame-page() frame-loader()-subframeLoader()-allowPlugins(NotAboutToInstantiatePlugin)) pluginData = frame-page()-pluginData(); -// PDF is one image type for which a plugin can override built-in support. -// We do not want QuickTime to take over all image types, obviously. -if ((type == application/pdf || type == text/pdf) pluginData pluginData-supportsMimeType(type)) +// At this point anything that can be supported can be overridden by plugins. +if (pluginData pluginData-supportsMimeType(type)) return PluginDocument::create(frame,
[webkit-changes] [104747] trunk
Title: [104747] trunk
Revision 104747
Author tk...@chromium.org
Date 2012-01-11 14:35:52 -0800 (Wed, 11 Jan 2012)
Log Message
Rename HTMLInputElement::setDefaultName to setInitialName.
https://bugs.webkit.org/show_bug.cgi?id=76039
Reviewed by Darin Adler.
Source/WebCore:
Rename setDefaultName to setInitialName, make it protected, and add two
assertions.
This change should not change any behavior.
Test: fast/forms/isindex-name.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setInitialName):
- Renamed from setDefaultName.
- Add assertions.
* html/HTMLInputElement.h:
Rename setDefaultName to setInitialName, and move it to protected.
* html/HTMLIsIndexElement.cpp:
(WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
Update a setDefaultName callsite.
(WebCore::HTMLIsIndexElement::parseMappedAttribute):
A style fix.
LayoutTests:
* fast/forms/isindex-name-expected.txt: Added.
* fast/forms/isindex-name.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/HTMLIsIndexElement.cpp
Added Paths
trunk/LayoutTests/fast/forms/isindex-name-expected.txt
trunk/LayoutTests/fast/forms/isindex-name.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104746 => 104747)
--- trunk/LayoutTests/ChangeLog 2012-01-11 22:13:24 UTC (rev 104746)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 22:35:52 UTC (rev 104747)
@@ -1,3 +1,13 @@
+2012-01-11 Kent Tamura tk...@chromium.org
+
+Rename HTMLInputElement::setDefaultName to setInitialName.
+https://bugs.webkit.org/show_bug.cgi?id=76039
+
+Reviewed by Darin Adler.
+
+* fast/forms/isindex-name-expected.txt: Added.
+* fast/forms/isindex-name.html: Added.
+
2012-01-11 Raymond Toy r...@google.com
Webaudio layout tests need to override the WebKitWebAudioEnabled
Added: trunk/LayoutTests/fast/forms/isindex-name-expected.txt (0 => 104747)
--- trunk/LayoutTests/fast/forms/isindex-name-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/isindex-name-expected.txt 2012-01-11 22:35:52 UTC (rev 104747)
@@ -0,0 +1,11 @@
+Initial name:
+PASS isindex.name is isindex
+Adding a name attribute:
+PASS isindex.setAttribute(name, foo); isindex.name is foo
+Removing the name attribute:
+PASS isindex.removeAttribute(name); isindex.name is
+PASS successfullyParsed is true
+
+TEST COMPLETE
+This is a searchable index. Enter search keywords:
+
Added: trunk/LayoutTests/fast/forms/isindex-name.html (0 => 104747)
--- trunk/LayoutTests/fast/forms/isindex-name.html (rev 0)
+++ trunk/LayoutTests/fast/forms/isindex-name.html 2012-01-11 22:35:52 UTC (rev 104747)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+isindex id=isindex1
+script
+var isindex = document.getElementById('isindex1');
+debug('Initial name:');
+shouldBeEqualToString('isindex.name', 'isindex');
+
+debug('Adding a name attribute:');
+shouldBeEqualToString('isindex.setAttribute(name, foo); isindex.name', 'foo');
+
+debug('Removing the name attribute:');
+// This behavior is compatible with IE, Firefox, and Opera.
+shouldBeEqualToString('isindex.removeAttribute(name); isindex.name', '');
+/script
+script src=""
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (104746 => 104747)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 22:13:24 UTC (rev 104746)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 22:35:52 UTC (rev 104747)
@@ -1,3 +1,29 @@
+2012-01-11 Kent Tamura tk...@chromium.org
+
+Rename HTMLInputElement::setDefaultName to setInitialName.
+https://bugs.webkit.org/show_bug.cgi?id=76039
+
+Reviewed by Darin Adler.
+
+Rename setDefaultName to setInitialName, make it protected, and add two
+assertions.
+
+This change should not change any behavior.
+
+Test: fast/forms/isindex-name.html
+
+* html/HTMLInputElement.cpp:
+(WebCore::HTMLInputElement::setInitialName):
+- Renamed from setDefaultName.
+- Add assertions.
+* html/HTMLInputElement.h:
+Rename setDefaultName to setInitialName, and move it to protected.
+* html/HTMLIsIndexElement.cpp:
+(WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
+Update a setDefaultName callsite.
+(WebCore::HTMLIsIndexElement::parseMappedAttribute):
+A style fix.
+
2012-01-11 Adam Treat atr...@rim.com
https://bugs.webkit.org/show_bug.cgi?id=76088
Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (104746 => 104747)
--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2012-01-11 22:13:24 UTC (rev 104746)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2012-01-11 22:35:52 UTC (rev 104747)
@@ -1300,8 +1300,10 @@
setAttribute(valueAttr, value);
}
-void HTMLInputElement::setDefaultName(const AtomicString name)
+void
[webkit-changes] [104748] trunk/Source/WebCore
Title: [104748] trunk/Source/WebCore
Revision 104748
Author commit-qu...@webkit.org
Date 2012-01-11 14:44:32 -0800 (Wed, 11 Jan 2012)
Log Message
Switch web intents to use supplemental IDL for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=76092
Patch by Greg Billock gbill...@google.com on 2012-01-11
Reviewed by Adam Barth.
* Modules/intents/DOMWindowIntents.idl: Added.
* WebCore.gypi:
* page/DOMWindow.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/page/DOMWindow.idl
Added Paths
trunk/Source/WebCore/Modules/intents/DOMWindowIntents.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (104747 => 104748)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 22:35:52 UTC (rev 104747)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 22:44:32 UTC (rev 104748)
@@ -1,3 +1,14 @@
+2012-01-11 Greg Billock gbill...@google.com
+
+Switch web intents to use supplemental IDL for DOMWindow
+https://bugs.webkit.org/show_bug.cgi?id=76092
+
+Reviewed by Adam Barth.
+
+* Modules/intents/DOMWindowIntents.idl: Added.
+* WebCore.gypi:
+* page/DOMWindow.idl:
+
2012-01-11 Kent Tamura tk...@chromium.org
Rename HTMLInputElement::setDefaultName to setInitialName.
Added: trunk/Source/WebCore/Modules/intents/DOMWindowIntents.idl (0 => 104748)
--- trunk/Source/WebCore/Modules/intents/DOMWindowIntents.idl (rev 0)
+++ trunk/Source/WebCore/Modules/intents/DOMWindowIntents.idl 2012-01-11 22:44:32 UTC (rev 104748)
@@ -0,0 +1,29 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public License
+ * along with this library; see the file COPYING.LIB. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+module window {
+
+interface [
+Conditional=WEB_INTENTS,
+Supplemental=DOMWindow
+] DOMWindowIntents {
+attribute IntentConstructor Intent;
+};
+
+}
Modified: trunk/Source/WebCore/WebCore.gypi (104747 => 104748)
--- trunk/Source/WebCore/WebCore.gypi 2012-01-11 22:35:52 UTC (rev 104747)
+++ trunk/Source/WebCore/WebCore.gypi 2012-01-11 22:44:32 UTC (rev 104748)
@@ -1149,6 +1149,7 @@
'Modules/gamepad/Gamepad.idl',
'Modules/gamepad/GamepadList.idl',
'Modules/gamepad/NavigatorGamepad.idl',
+'Modules/intents/DOMWindowIntents.idl',
'Modules/intents/Intent.idl',
'Modules/intents/IntentResultCallback.idl',
'Modules/intents/NavigatorIntents.idl',
Modified: trunk/Source/WebCore/page/DOMWindow.idl (104747 => 104748)
--- trunk/Source/WebCore/page/DOMWindow.idl 2012-01-11 22:35:52 UTC (rev 104747)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2012-01-11 22:44:32 UTC (rev 104748)
@@ -603,8 +603,6 @@
attribute [EnabledAtRuntime=webkitVideoTrack] TrackEventConstructor TrackEvent;
#endif
-attribute [Conditional=WEB_INTENTS] IntentConstructor Intent; // Usable with the new operator
-
attribute DOMPluginConstructor Plugin;
attribute DOMPluginArrayConstructor PluginArray;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104749] trunk/LayoutTests
Title: [104749] trunk/LayoutTests Revision 104749 Author o...@chromium.org Date 2012-01-11 15:04:19 -0800 (Wed, 11 Jan 2012) Log Message Fix duplicate expectations from r104715. This was causing the Chromium Windows tests not to run. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104748 => 104749) --- trunk/LayoutTests/ChangeLog 2012-01-11 22:44:32 UTC (rev 104748) +++ trunk/LayoutTests/ChangeLog 2012-01-11 23:04:19 UTC (rev 104749) @@ -1,3 +1,10 @@ +2012-01-11 Ojan Vafai o...@chromium.org + +Fix duplicate expectations from r104715. +This was causing the Chromium Windows tests not to run. + +* platform/chromium/test_expectations.txt: + 2012-01-11 Kent Tamura tk...@chromium.org Rename HTMLInputElement::setDefaultName to setInitialName. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104748 => 104749) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-11 22:44:32 UTC (rev 104748) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-11 23:04:19 UTC (rev 104749) @@ -895,7 +895,7 @@ // (wrong baseline was committed). No idea about when it really started to fail. BUGCR52692 LINUX WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-80-t.svg = IMAGE+TEXT BUGCR52692 BUGWK74788 LINUX WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-80-t.svg = IMAGE+TEXT CRASH -BUGCR52692 BUGWK74788 LINUX WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-60-t.svg = IMAGE+TEXT CRASH +BUGCR52692 BUGWK74788 LINUX DEBUG : svg/W3C-SVG-1.1/animate-elem-60-t.svg = PASS CRASH BUGWK74788 MAC : svg/W3C-SVG-1.1/animate-elem-80-t.svg = PASS CRASH // Windows and Mac need rebaselining after 53378 patch. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104750] trunk
Title: [104750] trunk
Revision 104750
Author commit-qu...@webkit.org
Date 2012-01-11 15:15:20 -0800 (Wed, 11 Jan 2012)
Log Message
Typo in error message: Unexpected token 'defualt'
https://bugs.webkit.org/show_bug.cgi?id=75105
Patch by Eugene Girard gir...@google.com on 2012-01-11
Reviewed by Simon Fraser.
Source/_javascript_Core:
* parser/Parser.h:
(JSC::Parser::getTokenName):
LayoutTests:
* fast/js/reserved-words-as-property-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/reserved-words-as-property-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Parser.h
Diff
Modified: trunk/LayoutTests/ChangeLog (104749 => 104750)
--- trunk/LayoutTests/ChangeLog 2012-01-11 23:04:19 UTC (rev 104749)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 23:15:20 UTC (rev 104750)
@@ -1,3 +1,12 @@
+2012-01-11 Eugene Girard gir...@google.com
+
+Typo in error message: Unexpected token 'defualt'
+https://bugs.webkit.org/show_bug.cgi?id=75105
+
+Reviewed by Simon Fraser.
+
+* fast/js/reserved-words-as-property-expected.txt:
+
2012-01-11 Ojan Vafai o...@chromium.org
Fix duplicate expectations from r104715.
Modified: trunk/LayoutTests/fast/js/reserved-words-as-property-expected.txt (104749 => 104750)
--- trunk/LayoutTests/fast/js/reserved-words-as-property-expected.txt 2012-01-11 23:04:19 UTC (rev 104749)
+++ trunk/LayoutTests/fast/js/reserved-words-as-property-expected.txt 2012-01-11 23:15:20 UTC (rev 104750)
@@ -301,8 +301,8 @@
PASS (function(){/default/.test(function g(default){ })}); true threw exception SyntaxError: Expected an identifier but found 'default' instead.
PASS try{}catch(default){}; true threw exception SyntaxError: Expected an identifier but found 'default' instead.
PASS (function(){try{}catch(default){}; true}); true threw exception SyntaxError: Expected an identifier but found 'default' instead.
-PASS function default(){ }; true threw exception SyntaxError: Unexpected token 'defualt'.
-PASS (function(){function default(){ }; true}); true threw exception SyntaxError: Unexpected token 'defualt'.
+PASS function default(){ }; true threw exception SyntaxError: Unexpected token 'default'.
+PASS (function(){function default(){ }; true}); true threw exception SyntaxError: Unexpected token 'default'.
PASS ({ default: 42 }.default === 42) is true
PASS (function(){({ default: 42 }.default === 42)}); true is true
PASS ({ default: 42 }.default === 42) is true
@@ -319,8 +319,8 @@
PASS (function(){use strict;/default/.test(function g(default){ use strict; })}); true threw exception SyntaxError: Expected an identifier but found 'default' instead.
PASS use strict;try{}catch(default){}; true threw exception SyntaxError: Expected an identifier but found 'default' instead.
PASS (function(){use strict;try{}catch(default){}; true}); true threw exception SyntaxError: Expected an identifier but found 'default' instead.
-PASS use strict;function default(){ use strict; }; true threw exception SyntaxError: Unexpected token 'defualt'.
-PASS (function(){use strict;function default(){ use strict; }; true}); true threw exception SyntaxError: Unexpected token 'defualt'.
+PASS use strict;function default(){ use strict; }; true threw exception SyntaxError: Unexpected token 'default'.
+PASS (function(){use strict;function default(){ use strict; }; true}); true threw exception SyntaxError: Unexpected token 'default'.
PASS use strict;({ default: 42 }.default === 42) is true
PASS (function(){use strict;({ default: 42 }.default === 42)}); true is true
PASS use strict;({ default: 42 }.default === 42) is true
Modified: trunk/Source/_javascript_Core/ChangeLog (104749 => 104750)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-11 23:04:19 UTC (rev 104749)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-11 23:15:20 UTC (rev 104750)
@@ -1,3 +1,13 @@
+2012-01-11 Eugene Girard gir...@google.com
+
+Typo in error message: Unexpected token 'defualt'
+https://bugs.webkit.org/show_bug.cgi?id=75105
+
+Reviewed by Simon Fraser.
+
+* parser/Parser.h:
+(JSC::Parser::getTokenName):
+
2012-01-11 Anders Carlsson ander...@apple.com
Assertion failure in JSC::allocateCell trying to allocate a JSString
Modified: trunk/Source/_javascript_Core/parser/Parser.h (104749 => 104750)
--- trunk/Source/_javascript_Core/parser/Parser.h 2012-01-11 23:04:19 UTC (rev 104749)
+++ trunk/Source/_javascript_Core/parser/Parser.h 2012-01-11 23:15:20 UTC (rev 104750)
@@ -559,7 +559,7 @@
case CASE:
return case;
case DEFAULT:
-return defualt;
+return default;
case FOR:
return for;
case NEW:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104751] trunk/Source/JavaScriptCore
Title: [104751] trunk/Source/_javascript_Core Revision 104751 Author msab...@apple.com Date 2012-01-11 15:27:08 -0800 (Wed, 11 Jan 2012) Log Message v8-regexp spends 35% of its time allocating and copying internal regexp results data https://bugs.webkit.org/show_bug.cgi?id=76079 Reviewed by Geoffrey Garen. Added a new RegExpResults struct that has the input string, the number of subexpressions and the output vector. Changed RegExpConstructor to include a RegExpConstructorPrivate instead of having a reference to one. Changed RegExpMatchesArray to include a RegExpResults instead of a reference to a RegExpConstructorPrivate. Created an overloaded assignment operator to assign a RegExpConstructorPrivate to a RegExpResults. Collectively this change is worth 24% performance improvement to v8-regexp. * runtime/RegExpConstructor.cpp: (JSC::RegExpResult::operator=): (JSC::RegExpConstructor::RegExpConstructor): (JSC::RegExpMatchesArray::RegExpMatchesArray): (JSC::RegExpMatchesArray::finishCreation): (JSC::RegExpMatchesArray::~RegExpMatchesArray): (JSC::RegExpMatchesArray::fillArrayInstance): (JSC::RegExpConstructor::arrayOfMatches): (JSC::RegExpConstructor::getBackref): (JSC::RegExpConstructor::getLastParen): (JSC::RegExpConstructor::getLeftContext): (JSC::RegExpConstructor::getRightContext): (JSC::RegExpConstructor::setInput): (JSC::RegExpConstructor::input): (JSC::RegExpConstructor::setMultiline): (JSC::RegExpConstructor::multiline): * runtime/RegExpConstructor.h: (JSC::RegExpResult::RegExpResult): (JSC::RegExpConstructor::performMatch): * runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::create): (JSC::RegExpMatchesArray::getOwnPropertySlot): (JSC::RegExpMatchesArray::getOwnPropertySlotByIndex): (JSC::RegExpMatchesArray::getOwnPropertyDescriptor): (JSC::RegExpMatchesArray::put): (JSC::RegExpMatchesArray::putByIndex): (JSC::RegExpMatchesArray::deleteProperty): (JSC::RegExpMatchesArray::deletePropertyByIndex): (JSC::RegExpMatchesArray::getOwnPropertyNames): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp trunk/Source/_javascript_Core/runtime/RegExpConstructor.h trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (104750 => 104751) --- trunk/Source/_javascript_Core/ChangeLog 2012-01-11 23:15:20 UTC (rev 104750) +++ trunk/Source/_javascript_Core/ChangeLog 2012-01-11 23:27:08 UTC (rev 104751) @@ -1,3 +1,48 @@ +2012-01-11 Michael Saboff msab...@apple.com + +v8-regexp spends 35% of its time allocating and copying internal regexp results data +https://bugs.webkit.org/show_bug.cgi?id=76079 + +Reviewed by Geoffrey Garen. + +Added a new RegExpResults struct that has the input string, the number of +subexpressions and the output vector. Changed RegExpConstructor to +include a RegExpConstructorPrivate instead of having a reference to one. +Changed RegExpMatchesArray to include a RegExpResults instead of a +reference to a RegExpConstructorPrivate. Created an overloaded assignment +operator to assign a RegExpConstructorPrivate to a RegExpResults. +Collectively this change is worth 24% performance improvement to v8-regexp. + +* runtime/RegExpConstructor.cpp: +(JSC::RegExpResult::operator=): +(JSC::RegExpConstructor::RegExpConstructor): +(JSC::RegExpMatchesArray::RegExpMatchesArray): +(JSC::RegExpMatchesArray::finishCreation): +(JSC::RegExpMatchesArray::~RegExpMatchesArray): +(JSC::RegExpMatchesArray::fillArrayInstance): +(JSC::RegExpConstructor::arrayOfMatches): +(JSC::RegExpConstructor::getBackref): +(JSC::RegExpConstructor::getLastParen): +(JSC::RegExpConstructor::getLeftContext): +(JSC::RegExpConstructor::getRightContext): +(JSC::RegExpConstructor::setInput): +(JSC::RegExpConstructor::input): +(JSC::RegExpConstructor::setMultiline): +(JSC::RegExpConstructor::multiline): +* runtime/RegExpConstructor.h: +(JSC::RegExpResult::RegExpResult): +(JSC::RegExpConstructor::performMatch): +* runtime/RegExpMatchesArray.h: +(JSC::RegExpMatchesArray::create): +(JSC::RegExpMatchesArray::getOwnPropertySlot): +(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex): +(JSC::RegExpMatchesArray::getOwnPropertyDescriptor): +(JSC::RegExpMatchesArray::put): +(JSC::RegExpMatchesArray::putByIndex): +(JSC::RegExpMatchesArray::deleteProperty): +(JSC::RegExpMatchesArray::deletePropertyByIndex): +(JSC::RegExpMatchesArray::getOwnPropertyNames): + 2012-01-11 Eugene Girard gir...@google.com Typo in error message: Unexpected token 'defualt' Modified: trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp (104750 => 104751) ---
[webkit-changes] [104752] trunk/LayoutTests
Title: [104752] trunk/LayoutTests
Revision 104752
Author mikelawt...@chromium.org
Date 2012-01-11 15:27:25 -0800 (Wed, 11 Jan 2012)
Log Message
line height test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75998
Reviewed by Daniel Bates.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
* css3/calc/line-height-expected.txt: Added.
* css3/calc/line-height.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/css3/calc/line-height-expected.txt
trunk/LayoutTests/css3/calc/line-height.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104751 => 104752)
--- trunk/LayoutTests/ChangeLog 2012-01-11 23:27:08 UTC (rev 104751)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 23:27:25 UTC (rev 104752)
@@ -1,3 +1,18 @@
+2012-01-11 Mike Lawther mikelawt...@chromium.org
+
+line height test for CSS3 calc
+https://bugs.webkit.org/show_bug.cgi?id=75998
+
+Reviewed by Daniel Bates.
+
+Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
+
+These tests are expected to 'fail', and will pass once calc() functionality is landed.
+For now, they serve to demonstrate that the current code doesn't crash on these tests.
+
+* css3/calc/line-height-expected.txt: Added.
+* css3/calc/line-height.html: Added.
+
2012-01-11 Eugene Girard gir...@google.com
Typo in error message: Unexpected token 'defualt'
Added: trunk/LayoutTests/css3/calc/line-height-expected.txt (0 => 104752)
--- trunk/LayoutTests/css3/calc/line-height-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/calc/line-height-expected.txt 2012-01-11 23:27:25 UTC (rev 104752)
@@ -0,0 +1,11 @@
+Tests that CSS3 calc() can be used for the line-height property
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+FAIL getComputedStyle(document.getElementById(calc-percent), null).lineHeight should be 32px. Was normal.
+FAIL getComputedStyle(document.getElementById(calc-percent-pixels), null).lineHeight should be 32px. Was normal.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/css3/calc/line-height.html (0 => 104752)
--- trunk/LayoutTests/css3/calc/line-height.html (rev 0)
+++ trunk/LayoutTests/css3/calc/line-height.html 2012-01-11 23:27:25 UTC (rev 104752)
@@ -0,0 +1,26 @@
+!DOCTYPE html
+script src=""
+style
+span { font-size: 16px; }
+#control { line-height: 200%; }
+#calc-percent { line-height: -webkit-calc(100% * 2); }
+#calc-percent-pixels { line-height: -webkit-calc(100% + 16px); }
+/style
+div id=test-container
+span id=controlThe line height of these lines should be identical/spanhr/
+span id=calc-percentThe line height of these lines should be identical/spanhr/
+span id=calc-percent-pixelsThe line height of these lines should be identical/spanhr/
+/div
+script
+description(Tests that CSS3 calc() can be used for the line-height property);
+
+shouldEvaluateTo('getComputedStyle(document.getElementById(calc-percent), null).lineHeight', 'getComputedStyle(document.getElementById(control), null).lineHeight');
+shouldEvaluateTo('getComputedStyle(document.getElementById(calc-percent-pixels), null).lineHeight', 'getComputedStyle(document.getElementById(control), null).lineHeight');
+
+if (window.layoutTestController) {
+var testContainer = document.getElementById(test-container);
+if (testContainer)
+document.body.removeChild(testContainer);
+}
+/script
+script src=""
\ No newline at end of file
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104753] trunk/Tools
Title: [104753] trunk/Tools
Revision 104753
Author dpra...@chromium.org
Date 2012-01-11 15:42:27 -0800 (Wed, 11 Jan 2012)
Log Message
Unreviewed, fix build bustage on win32 introduced by r104725.
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.make_port):
(MockChromiumDRTTest.test_pixeltest__fails):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (104752 => 104753)
--- trunk/Tools/ChangeLog 2012-01-11 23:27:25 UTC (rev 104752)
+++ trunk/Tools/ChangeLog 2012-01-11 23:42:27 UTC (rev 104753)
@@ -1,3 +1,11 @@
+2012-01-11 Dirk Pranke dpra...@chromium.org
+
+Unreviewed, fix build bustage on win32 introduced by r104725.
+
+* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
+(MockDRTPortTest.make_port):
+(MockChromiumDRTTest.test_pixeltest__fails):
+
2012-01-11 Jochen Eisinger joc...@chromium.org
[Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py (104752 => 104753)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py 2012-01-11 23:27:25 UTC (rev 104752)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py 2012-01-11 23:42:27 UTC (rev 104753)
@@ -50,6 +50,8 @@
test.add_unit_tests_to_mock_filesystem(host.filesystem)
if sys.platform == 'win32':
# We use this because the 'win' port doesn't work yet.
+host.platform.os_name = 'win'
+host.platform.os_version = 'xp'
return mock_drt.MockDRTPort(host, port_name='mock-chromium-win', options=options)
return mock_drt.MockDRTPort(host, options=options)
@@ -238,7 +240,11 @@
def test_pixeltest__fails(self):
host = MockSystemHost()
-url = '' % PortFactory(host).get('test').layout_tests_dir()
+url = ''
+if sys.platform == 'win32':
+host = MockSystemHost(os_name='win', os_version='xp')
+url = ''
+url = "" + '%s/failures/expected/checksum.html' % PortFactory(host).get('test').layout_tests_dir()
self.assertTest('failures/expected/checksum.html', pixel_tests=True,
expected_checksum='wrong-checksum',
drt_output=[url + '\n',
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104754] trunk/Tools
Title: [104754] trunk/Tools
Revision 104754
Author rn...@webkit.org
Date 2012-01-11 15:46:53 -0800 (Wed, 11 Jan 2012)
Log Message
last-green-revision should report the revision that succeeded on all bots
https://bugs.webkit.org/show_bug.cgi?id=76109
Reviewed by Adam Barth.
Add an algorithm to find the last known good revision among the specified bots. For a revision to be
considered green by this algorithm, all matching builders must have a successful run at the revision
or two consecutive successful runs before and after the revision.
Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
that resulted in an exception when the user didn't pass BUILDER_NAME argument.
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(BuildBot._revisions_for_builder):
(BuildBot):
(BuildBot._find_green_revision):
(BuildBot.last_green_revision):
* Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
(MockBuildBot.last_green_revision):
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(test_revisions_for_builder):
(test_find_green_revision):
(test_last_green_revision):
* Scripts/webkitpy/tool/bot/irc_command.py:
(LastGreenRevision.execute):
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
(SheriffIRCBotTest.test_lgr):
* Scripts/webkitpy/tool/commands/queries.py:
(LastGreenRevision):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_mock.py
trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py
trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/queries.py
Diff
Modified: trunk/Tools/ChangeLog (104753 => 104754)
--- trunk/Tools/ChangeLog 2012-01-11 23:42:27 UTC (rev 104753)
+++ trunk/Tools/ChangeLog 2012-01-11 23:46:53 UTC (rev 104754)
@@ -1,3 +1,35 @@
+2012-01-11 Ryosuke Niwa rn...@webkit.org
+
+last-green-revision should report the revision that succeeded on all bots
+https://bugs.webkit.org/show_bug.cgi?id=76109
+
+Reviewed by Adam Barth.
+
+Add an algorithm to find the last known good revision among the specified bots. For a revision to be
+considered green by this algorithm, all matching builders must have a successful run at the revision
+or two consecutive successful runs before and after the revision.
+
+Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
+that resulted in an exception when the user didn't pass BUILDER_NAME argument.
+
+* Scripts/webkitpy/common/net/buildbot/buildbot.py:
+(BuildBot._revisions_for_builder):
+(BuildBot):
+(BuildBot._find_green_revision):
+(BuildBot.last_green_revision):
+* Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
+(MockBuildBot.last_green_revision):
+* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
+(test_revisions_for_builder):
+(test_find_green_revision):
+(test_last_green_revision):
+* Scripts/webkitpy/tool/bot/irc_command.py:
+(LastGreenRevision.execute):
+* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
+(SheriffIRCBotTest.test_lgr):
+* Scripts/webkitpy/tool/commands/queries.py:
+(LastGreenRevision):
+
2012-01-11 Dirk Pranke dpra...@chromium.org
Unreviewed, fix build bustage on win32 introduced by r104725.
Modified: trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py (104753 => 104754)
--- trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py 2012-01-11 23:42:27 UTC (rev 104753)
+++ trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py 2012-01-11 23:46:53 UTC (rev 104754)
@@ -436,20 +436,51 @@
builder_page_url = %s/builders/%s?numbuilds=100 % (self.buildbot_url, urllib2.quote(builder.name()))
return urllib2.urlopen(builder_page_url)
-def _green_revision_for_builder(self, builder):
+def _revisions_for_builder(self, builder):
soup = BeautifulSoup(self._fetch_builder_page(builder))
-revision = None
-number_of_revisions = 0
+revisions = []
for status_row in soup.find('table').findAll('tr'):
revision_anchor = status_row.find('a')
table_cells = status_row.findAll('td')
-if not revision_anchor or not table_cells or len(table_cells) 3 or not table_cells[2].string:
+if not table_cells or len(table_cells) 3 or not table_cells[2].string:
continue
-number_of_revisions += 1
-if revision == None and 'success' in table_cells[2].string:
-revision = int(revision_anchor.string)
-return revision, number_of_revisions
+if revision_anchor and revision_anchor.string and
[webkit-changes] [104755] trunk
Title: [104755] trunk
Revision 104755
Author commit-qu...@webkit.org
Date 2012-01-11 15:51:15 -0800 (Wed, 11 Jan 2012)
Log Message
IndexedDB: Version change transaction should abort if constraints fail during createIndex
https://bugs.webkit.org/show_bug.cgi?id=76094
Patch by Joshua Bell jsb...@chromium.org on 2012-01-11
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/index-population.html
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
* storage/IDBIndexBackendImpl.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
* storage/IDBObjectStoreBackendImpl.cpp:
LayoutTests:
* storage/indexeddb/index-population-expected.txt: Added.
* storage/indexeddb/index-population.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBIndexBackendImpl.cpp
trunk/Source/WebCore/storage/IDBIndexBackendImpl.h
trunk/Source/WebCore/storage/IDBLevelDBBackingStore.cpp
trunk/Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp
Added Paths
trunk/LayoutTests/storage/indexeddb/index-population-expected.txt
trunk/LayoutTests/storage/indexeddb/index-population.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104754 => 104755)
--- trunk/LayoutTests/ChangeLog 2012-01-11 23:46:53 UTC (rev 104754)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 23:51:15 UTC (rev 104755)
@@ -1,3 +1,13 @@
+2012-01-11 Joshua Bell jsb...@chromium.org
+
+IndexedDB: Version change transaction should abort if constraints fail during createIndex
+https://bugs.webkit.org/show_bug.cgi?id=76094
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/index-population-expected.txt: Added.
+* storage/indexeddb/index-population.html: Added.
+
2012-01-11 Mike Lawther mikelawt...@chromium.org
line height test for CSS3 calc
Added: trunk/LayoutTests/storage/indexeddb/index-population-expected.txt (0 => 104755)
--- trunk/LayoutTests/storage/indexeddb/index-population-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/index-population-expected.txt 2012-01-11 23:51:15 UTC (rev 104755)
@@ -0,0 +1,52 @@
+Test IndexedDB index population.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+indexedDB = window.indexedDB || window.webkitIndexedDB
+PASS indexedDB != null is true
+IDBIndex = window.IDBIndex || window.webkitIDBIndex
+PASS IDBIndex != null is true
+IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange
+PASS IDBKeyRange != null is true
+indexedDB.deleteDatabase('index-population')
+indexedDB.open('index-population')
+
+doSetVersion1():
+db = event.target.result
+request = db.setVersion('version 1')
+
+setVersion1():
+transaction = request.result
+store = db.createObjectStore('store1')
+store.put({data: 'a', indexKey: 10}, 1)
+store.put({data: 'b', indexKey: 20}, 2)
+store.put({data: 'c', indexKey: 10}, 3)
+store.put({data: 'd', indexKey: 20}, 4)
+index = store.createIndex('index1', 'indexKey')
+PASS index instanceof IDBIndex is true
+PASS index.unique is false
+request = index.count(IDBKeyRange.bound(-Infinity, Infinity))
+PASS request.result is 4
+
+doSetVersion2():
+request = db.setVersion('version 2')
+
+setVersion2():
+transaction = request.result
+store = db.createObjectStore('store2')
+store.put({data: 'a', indexKey: 10}, 1)
+store.put({data: 'b', indexKey: 20}, 2)
+store.put({data: 'c', indexKey: 10}, 3)
+store.put({data: 'd', indexKey: 20}, 4)
+index2 = store.createIndex('index2', 'indexKey', { unique: true })
+PASS index2 instanceof IDBIndex is true
+PASS index2.unique is true
+
+setVersion2Abort():
+PASS db.objectStoreNames.length is 1
+PASS db.objectStoreNames[0] is 'store1'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/storage/indexeddb/index-population.html (0 => 104755)
--- trunk/LayoutTests/storage/indexeddb/index-population.html (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/index-population.html 2012-01-11 23:51:15 UTC (rev 104755)
@@ -0,0 +1,107 @@
+html
+head
+script src=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script
+
+description(Test IndexedDB index population.);
+
+function test()
+{
+evalAndLog(indexedDB = window.indexedDB || window.webkitIndexedDB);
+shouldBeTrue(indexedDB != null);
+evalAndLog(IDBIndex = window.IDBIndex || window.webkitIDBIndex);
+shouldBeTrue(IDBIndex != null);
+evalAndLog(IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange);
+shouldBeTrue(IDBKeyRange != null);
+
+request = evalAndLog(indexedDB.deleteDatabase('index-population'));
+request._onsuccess_ = deleteSuccess;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function deleteSuccess()
+{
+request = evalAndLog(indexedDB.open('index-population'));
+request._onsuccess_ = doSetVersion1;
+request._onerror_ =
[webkit-changes] [104756] trunk/Source/WebCore
Title: [104756] trunk/Source/WebCore
Revision 104756
Author jap...@chromium.org
Date 2012-01-11 15:54:28 -0800 (Wed, 11 Jan 2012)
Log Message
SubresourceLoader cleanup post r100311.
1. Simplify matching incrementRequestCount()/decrementRequestCount() calls.
2. Remove CachedImage custom code from SubresourceLoader.
3. Add a bunch of ASSERTs.
4. Remove the multipart-only call to didReceiveData() from didReceiveResponse(),
since didReceiveData() would get called immediately after anyway.
https://bugs.webkit.org/show_bug.cgi?id=75887
Reviewed by Adam Barth.
No new tests, refactor only.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse): Remove multipart special case, handle it in didReceiveData().
(WebCore::SubresourceLoader::didReceiveData): Handle multipart state here, since we will receive only one
didReceiveData() call per multipart segment, but no didFinishLoading() call.
* loader/SubresourceLoader.h: Add a RequestCountTracker subclass to reduce complexity of ensuring we don't
decrement request count twice on CachedResourceLoader.
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::setResponse): Move CachedImage::clear() call out of SubresourceLoader, since it's
kind of a layering violation as is.
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/loader/SubresourceLoader.h
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/loader/cache/CachedImage.h
trunk/Source/WebCore/loader/cache/CachedResource.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104755 => 104756)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 23:51:15 UTC (rev 104755)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 23:54:28 UTC (rev 104756)
@@ -1,3 +1,29 @@
+2012-01-11 Nate Chapin jap...@chromium.org
+
+SubresourceLoader cleanup post r100311.
+1. Simplify matching incrementRequestCount()/decrementRequestCount() calls.
+2. Remove CachedImage custom code from SubresourceLoader.
+3. Add a bunch of ASSERTs.
+4. Remove the multipart-only call to didReceiveData() from didReceiveResponse(),
+ since didReceiveData() would get called immediately after anyway.
+https://bugs.webkit.org/show_bug.cgi?id=75887
+
+Reviewed by Adam Barth.
+
+No new tests, refactor only.
+
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::didReceiveResponse): Remove multipart special case, handle it in didReceiveData().
+(WebCore::SubresourceLoader::didReceiveData): Handle multipart state here, since we will receive only one
+ didReceiveData() call per multipart segment, but no didFinishLoading() call.
+* loader/SubresourceLoader.h: Add a RequestCountTracker subclass to reduce complexity of ensuring we don't
+decrement request count twice on CachedResourceLoader.
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::setResponse): Move CachedImage::clear() call out of SubresourceLoader, since it's
+kind of a layering violation as is.
+* loader/cache/CachedImage.h:
+* loader/cache/CachedResource.cpp:
+
2012-01-11 Joshua Bell jsb...@chromium.org
IndexedDB: Version change transaction should abort if constraints fail during createIndex
Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (104755 => 104756)
--- trunk/Source/WebCore/loader/SubresourceLoader.cpp 2012-01-11 23:51:15 UTC (rev 104755)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp 2012-01-11 23:54:28 UTC (rev 104756)
@@ -29,7 +29,6 @@
#include config.h
#include SubresourceLoader.h
-#include CachedImage.h
#include CachedResourceLoader.h
#include Document.h
#include DocumentLoader.h
@@ -47,12 +46,25 @@
DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, subresourceLoaderCounter, (SubresourceLoader));
+SubresourceLoader::RequestCountTracker::RequestCountTracker(CachedResourceLoader* cachedResourceLoader, CachedResource* resource)
+: m_cachedResourceLoader(cachedResourceLoader)
+, m_resource(resource)
+{
+m_cachedResourceLoader-incrementRequestCount(m_resource);
+}
+
+SubresourceLoader::RequestCountTracker::~RequestCountTracker()
+{
+m_cachedResourceLoader-decrementRequestCount(m_resource);
+}
+
SubresourceLoader::SubresourceLoader(Frame* frame, CachedResource* resource, const ResourceLoaderOptions options)
: ResourceLoader(frame, options)
, m_resource(resource)
, m_document(frame-document())
, m_loadingMultipartContent(false)
, m_state(Uninitialized)
+, m_requestCountTracker(adoptPtr(new RequestCountTracker(frame-document()-cachedResourceLoader(), resource)))
{
#ifndef NDEBUG
subresourceLoaderCounter.increment();
@@ -61,6 +73,9 @@
SubresourceLoader::~SubresourceLoader()
{
+ASSERT(m_state != Initialized);
+
[webkit-changes] [104757] trunk
Title: [104757] trunk
Revision 104757
Author aba...@webkit.org
Date 2012-01-11 15:56:24 -0800 (Wed, 11 Jan 2012)
Log Message
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=75860
[Chromium Mac] no background is drawn for input elements
Patch by Avi Drissman a...@chromium.org on 2012-01-09
Reviewed by Eric Seidel.
Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
API misbehaves when built with the 10.5 SDK, so we use SPI. For now.
* rendering/RenderThemeChromiumMac.h:
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::paintTextField):
LayoutTests: iframe sandbox doesn't block videos from autoplaying (IETC automatic-feature-block-autoplay-video)
https://bugs.webkit.org/show_bug.cgi?id=76111
Reviewed by Eric Seidel.
Test based on video-no-autoplay.html.
* media/no-auto-play-in-sandbox-expected.txt: Added.
* media/no-auto-play-in-sandbox.html: Added.
* media/resources/no-auto-play-in-sandbox-iframe.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/SecurityContext.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Added Paths
trunk/LayoutTests/media/no-auto-play-in-sandbox-expected.txt
trunk/LayoutTests/media/no-auto-play-in-sandbox.html
trunk/LayoutTests/media/resources/no-auto-play-in-sandbox-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104756 => 104757)
--- trunk/LayoutTests/ChangeLog 2012-01-11 23:54:28 UTC (rev 104756)
+++ trunk/LayoutTests/ChangeLog 2012-01-11 23:56:24 UTC (rev 104757)
@@ -1,3 +1,16 @@
+2012-01-11 Adam Barth aba...@webkit.org
+
+iframe sandbox doesn't block videos from autoplaying (IETC automatic-feature-block-autoplay-video)
+https://bugs.webkit.org/show_bug.cgi?id=76111
+
+Reviewed by Eric Seidel.
+
+Test based on video-no-autoplay.html.
+
+* media/no-auto-play-in-sandbox-expected.txt: Added.
+* media/no-auto-play-in-sandbox.html: Added.
+* media/resources/no-auto-play-in-sandbox-iframe.html: Added.
+
2012-01-11 Joshua Bell jsb...@chromium.org
IndexedDB: Version change transaction should abort if constraints fail during createIndex
Added: trunk/LayoutTests/media/no-auto-play-in-sandbox-expected.txt (0 => 104757)
--- trunk/LayoutTests/media/no-auto-play-in-sandbox-expected.txt (rev 0)
+++ trunk/LayoutTests/media/no-auto-play-in-sandbox-expected.txt 2012-01-11 23:56:24 UTC (rev 104757)
@@ -0,0 +1,12 @@
+
+
+
+Frame: '!--framePath //!--frame0'
+
+Test that play event does not fire when src set with an autoplay attribute in a sandbox.
+
+EXPECTED (video.paused == 'true') OK
+EVENT(canplaythrough)
+EXPECTED (video.paused == 'true') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/no-auto-play-in-sandbox.html (0 => 104757)
--- trunk/LayoutTests/media/no-auto-play-in-sandbox.html (rev 0)
+++ trunk/LayoutTests/media/no-auto-play-in-sandbox.html 2012-01-11 23:56:24 UTC (rev 104757)
@@ -0,0 +1,10 @@
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.dumpChildFramesAsText();
+}
+/script
+iframe
+style=width: 400px; height: 600px
+sandbox=allow-scripts allow-same-origin
+src=""
Added: trunk/LayoutTests/media/resources/no-auto-play-in-sandbox-iframe.html (0 => 104757)
--- trunk/LayoutTests/media/resources/no-auto-play-in-sandbox-iframe.html (rev 0)
+++ trunk/LayoutTests/media/resources/no-auto-play-in-sandbox-iframe.html 2012-01-11 23:56:24 UTC (rev 104757)
@@ -0,0 +1,22 @@
+base href=""
+video autoplay controls/video
+pTest that play event does not fire when src set with an autoplay attribute in a sandbox./p
+script src=""
+script src=""
+script
+testExpected(video.paused, true);
+
+waitForEvent('play', function () {
+logResult(false, PLAY fired);
+endTest();
+} );
+
+function testPaused ()
+{
+testExpected(video.paused, true);
+endTest();
+}
+waitForEvent('canplaythrough', function () { setTimeout(testPaused, 500);} );
+
+video.src = "" content/test);
+/script
Modified: trunk/Source/WebCore/ChangeLog (104756 => 104757)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 23:54:28 UTC (rev 104756)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 23:56:24 UTC (rev 104757)
@@ -1,3 +1,35 @@
+2012-01-09 Avi Drissman a...@chromium.org
+
+https://bugs.webkit.org/show_bug.cgi?id=75860
+[Chromium Mac] no background is drawn for input elements
+
+Reviewed by Eric Seidel.
+
+Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
+API misbehaves when built with the 10.5 SDK, so we use SPI. For now.
+
+* rendering/RenderThemeChromiumMac.h:
+* rendering/RenderThemeChromiumMac.mm:
+(WebCore::RenderThemeChromiumMac::paintTextField):
+
+ .mine
+2012-01-11 Adam Barth aba...@webkit.org
+
+
[webkit-changes] [104759] branches/safari-534.54-branch
Title: [104759] branches/safari-534.54-branch
Revision 104759
Author lforsch...@apple.com
Date 2012-01-11 16:02:15 -0800 (Wed, 11 Jan 2012)
Log Message
Merged r88479.
Modified Paths
branches/safari-534.54-branch/LayoutTests/ChangeLog
branches/safari-534.54-branch/Source/WebCore/ChangeLog
branches/safari-534.54-branch/Source/WebCore/dom/Document.cpp
branches/safari-534.54-branch/Source/WebCore/html/HTMLLinkElement.cpp
branches/safari-534.54-branch/Source/WebCore/html/HTMLLinkElement.h
Added Paths
branches/safari-534.54-branch/LayoutTests/fast/css/link-disabled-attr-expected.txt
branches/safari-534.54-branch/LayoutTests/fast/css/link-disabled-attr.html
Diff
Modified: branches/safari-534.54-branch/LayoutTests/ChangeLog (104758 => 104759)
--- branches/safari-534.54-branch/LayoutTests/ChangeLog 2012-01-11 23:57:39 UTC (rev 104758)
+++ branches/safari-534.54-branch/LayoutTests/ChangeLog 2012-01-12 00:02:15 UTC (rev 104759)
@@ -1,3 +1,21 @@
+2011-1-11 Lucas Forschler lforsch...@apple.com
+
+Merge 88479
+
+2011-06-09 Julien Chaffraix jchaffr...@codeaurora.org
+
+Reviewed by Antti Koivisto.
+
+REGRESSION(84329): Stylesheets on some pages do not load
+https://bugs.webkit.org/show_bug.cgi?id=61400
+
+Adding test to cover the regression. The test actually uncovered
+a bug in the way we handle alternate stylesheet and thus is
+failing some parts.
+
+* fast/css/link-disabled-attr-expected.txt: Added.
+* fast/css/link-disabled-attr.html: Added.
+
2011-1-9 Lucas Forschler lforsch...@apple.com
Merge 102509
Copied: branches/safari-534.54-branch/LayoutTests/fast/css/link-disabled-attr-expected.txt (from rev 88479, trunk/LayoutTests/fast/css/link-disabled-attr-expected.txt) (0 => 104759)
--- branches/safari-534.54-branch/LayoutTests/fast/css/link-disabled-attr-expected.txt (rev 0)
+++ branches/safari-534.54-branch/LayoutTests/fast/css/link-disabled-attr-expected.txt 2012-01-12 00:02:15 UTC (rev 104759)
@@ -0,0 +1,27 @@
+Series of tests to validate behavior of getting/setting link.disabled and link.sheet.disabled.
+Test for bug 61400: REGRESSION(84329): Stylesheets on some pages do not load
+
+notsheet
+PASS link.sheet is null
+PASS link.disabled is false
+sheet
+PASS link.sheet is non-null.
+PASS link.disabled is true
+PASS link.sheet.disabled is true
+PASS getComputedStyle(console).whiteSpace is 'normal'
+PASS link.disabled is false
+PASS link.sheet.disabled is false
+PASS getComputedStyle(console).whiteSpace is 'pre-wrap'
+altsheet
+FAIL link.disabled should be true. Was false.
+PASS link.sheet is non-null.
+FAIL getComputedStyle(console).backgroundColor should be rgb(0, 128, 0). Was rgba(0, 0, 0, 0).
+FAIL link.disabled should be true. Was false.
+PASS getComputedStyle(console).backgroundColor is originalBG
+PASS link.disabled is false
+FAIL getComputedStyle(console).backgroundColor should be rgb(0, 128, 0). Was rgba(0, 0, 0, 0).
+PASS getComputedStyle(console).backgroundColor is originalBG
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: branches/safari-534.54-branch/LayoutTests/fast/css/link-disabled-attr.html (from rev 88479, trunk/LayoutTests/fast/css/link-disabled-attr.html) (0 => 104759)
--- branches/safari-534.54-branch/LayoutTests/fast/css/link-disabled-attr.html (rev 0)
+++ branches/safari-534.54-branch/LayoutTests/fast/css/link-disabled-attr.html 2012-01-12 00:02:15 UTC (rev 104759)
@@ -0,0 +1,103 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link id=sheet rel=stylesheet href=""
+link id=notsheet rel=author href=""
+link id=alt rel=alternate stylesheet title=altset href=""
+script src=""
+/head
+body
+p id=description
+Series of tests to validate behavior of getting/setting link.disabled and link.sheet.disabled.br
+Test for bug a href="" REGRESSION(84329): Stylesheets on some pages do not load
+/p
+div id=console/div
+script
+
+window.jsTestIsAsync = true;
+
+function onSheetLoaded(f, elem, maxtime) {
+if (elem.sheet || maxtime = 0)
+f(elem);
+else
+setTimeout(function () { onSheetLoaded(f, elem, maxtime - 25);}, 25);
+}
+
+
+
+// With a non-stylesheet link, 'disabled' is always false.
+
+var console = document.getElementById(console);
+var originalBG = getComputedStyle(console).backgroundColor;
+var link;
+
+debug(notsheet);
+
+link = document.getElementById(notsheet);
+shouldBeNull(link.sheet);
+link.disabled = true;
+shouldBeFalse(link.disabled);
+
+
+// With a stylesheet link, 'disabled' and 'link.style.disabled' should both
+// work, and be consistent with each other.
+
+debug(sheet);
+
+link = document.getElementById(sheet);
+shouldBeNonNull(link.sheet);
+
+link.sheet.disabled = true;
+shouldBeTrue(link.disabled);
+shouldBeTrue(link.sheet.disabled);
+shouldBe(getComputedStyle(console).whiteSpace, 'normal');
+
+link.disabled = false;
+shouldBeFalse(link.disabled);
[webkit-changes] [104760] trunk/Tools
Title: [104760] trunk/Tools
Revision 104760
Author rn...@webkit.org
Date 2012-01-11 16:07:32 -0800 (Wed, 11 Jan 2012)
Log Message
Sheriffbot build fix. Don't emit empty lines on IRC.
* Scripts/webkitpy/tool/bot/irc_command.py:
(LastGreenRevision.execute):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py
Diff
Modified: trunk/Tools/ChangeLog (104759 => 104760)
--- trunk/Tools/ChangeLog 2012-01-12 00:02:15 UTC (rev 104759)
+++ trunk/Tools/ChangeLog 2012-01-12 00:07:32 UTC (rev 104760)
@@ -1,5 +1,12 @@
2012-01-11 Ryosuke Niwa rn...@webkit.org
+Sheriffbot build fix. Don't emit empty lines on IRC.
+
+* Scripts/webkitpy/tool/bot/irc_command.py:
+(LastGreenRevision.execute):
+
+2012-01-11 Ryosuke Niwa rn...@webkit.org
+
last-green-revision should report the revision that succeeded on all bots
https://bugs.webkit.org/show_bug.cgi?id=76109
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (104759 => 104760)
--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2012-01-12 00:02:15 UTC (rev 104759)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2012-01-12 00:07:32 UTC (rev 104760)
@@ -59,7 +59,8 @@
return %s: Usage: last-green-revision BUILDER_NAME % nick
result = tool.buildbot.last_green_revision(' '.join(args))
for line in result.split('\n'):
-tool.irc().post(%s: %s % (nick, line))
+if line:
+tool.irc().post(%s: %s % (nick, line))
class Restart(IRCCommand):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104761] trunk/LayoutTests
Title: [104761] trunk/LayoutTests Revision 104761 Author aba...@webkit.org Date 2012-01-11 16:08:01 -0800 (Wed, 11 Jan 2012) Log Message IETC audio-interface-inherit.129 claims NETWORK_NO_SOURCE should not be overrideable https://bugs.webkit.org/show_bug.cgi?id=76085 Reviewed by Eric Seidel. As far as I can tell, the IETC test of this feature is wrong. NETWORK_NO_SOURCE should be immutable on the interface object and on the interface prototype object, but _javascript_ should be able to shadow the property on an instance. * media/network-no-source-const-shadow-expected.txt: Added. * media/network-no-source-const-shadow.html: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/media/network-no-source-const-shadow-expected.txt trunk/LayoutTests/media/network-no-source-const-shadow.html Diff Modified: trunk/LayoutTests/ChangeLog (104760 => 104761) --- trunk/LayoutTests/ChangeLog 2012-01-12 00:07:32 UTC (rev 104760) +++ trunk/LayoutTests/ChangeLog 2012-01-12 00:08:01 UTC (rev 104761) @@ -1,5 +1,20 @@ 2012-01-11 Adam Barth aba...@webkit.org +IETC audio-interface-inherit.129 claims NETWORK_NO_SOURCE should not be overrideable +https://bugs.webkit.org/show_bug.cgi?id=76085 + +Reviewed by Eric Seidel. + +As far as I can tell, the IETC test of this feature is wrong. +NETWORK_NO_SOURCE should be immutable on the interface object and on +the interface prototype object, but _javascript_ should be able to shadow +the property on an instance. + +* media/network-no-source-const-shadow-expected.txt: Added. +* media/network-no-source-const-shadow.html: Added. + +2012-01-11 Adam Barth aba...@webkit.org + iframe sandbox doesn't block videos from autoplaying (IETC automatic-feature-block-autoplay-video) https://bugs.webkit.org/show_bug.cgi?id=76111 Added: trunk/LayoutTests/media/network-no-source-const-shadow-expected.txt (0 => 104761) --- trunk/LayoutTests/media/network-no-source-const-shadow-expected.txt (rev 0) +++ trunk/LayoutTests/media/network-no-source-const-shadow-expected.txt 2012-01-12 00:08:01 UTC (rev 104761) @@ -0,0 +1,15 @@ +Test that NETWORK_NO_SOURCE is immutable at the appropriate times + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS HTMLMediaElement.NETWORK_NO_SOURCE is 3 +PASS HTMLMediaElement.prototype.NETWORK_NO_SOURCE is 3 +PASS element.NETWORK_NO_SOURCE is 3 +PASS HTMLMediaElement.NETWORK_NO_SOURCE is 3 +PASS HTMLAudioElement.prototype.NETWORK_NO_SOURCE is 3 +PASS element.NETWORK_NO_SOURCE is 15 +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/media/network-no-source-const-shadow.html (0 => 104761) --- trunk/LayoutTests/media/network-no-source-const-shadow.html (rev 0) +++ trunk/LayoutTests/media/network-no-source-const-shadow.html 2012-01-12 00:08:01 UTC (rev 104761) @@ -0,0 +1,21 @@ +!DOCTYPE html +script src="" +script +description(Test that NETWORK_NO_SOURCE is immutable at the appropriate times); + +shouldBe(HTMLMediaElement.NETWORK_NO_SOURCE, 3); +shouldBe(HTMLMediaElement.prototype.NETWORK_NO_SOURCE, 3); + +var element = document.createElement(audio); + +shouldBe(element.NETWORK_NO_SOURCE, 3); + +HTMLMediaElement.NETWORK_NO_SOURCE = 13; +HTMLMediaElement.prototype.NETWORK_NO_SOURCE = 14; +element.NETWORK_NO_SOURCE = 15; + +shouldBe(HTMLMediaElement.NETWORK_NO_SOURCE, 3); +shouldBe(HTMLAudioElement.prototype.NETWORK_NO_SOURCE, 3); +shouldBe(element.NETWORK_NO_SOURCE, 15); +/script +script src="" ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104762] trunk
Title: [104762] trunk
Revision 104762
Author gga...@apple.com
Date 2012-01-11 16:14:42 -0800 (Wed, 11 Jan 2012)
Log Message
REGRESSION: d3 Bullet Charts demo doesn't work (call with argument assignment is broken)
https://bugs.webkit.org/show_bug.cgi?id=75911
Source/_javascript_Core:
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNodeForLeftHandSide): Cleanup: No need to
explicitly cast to our return type in C++.
* bytecompiler/NodesCodegen.cpp:
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode): Make sure to copy our function
into a temporary register before evaluating our arguments, since argument
evaluation might include function calls or assignments that overwrite our callee by name.
LayoutTests:
Reviewed by Filip Pizlo.
* fast/js/function-argument-evaluation-expected.txt: Added.
* fast/js/function-argument-evaluation.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
Added Paths
trunk/LayoutTests/fast/js/function-argument-evaluation-expected.txt
trunk/LayoutTests/fast/js/function-argument-evaluation.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104761 => 104762)
--- trunk/LayoutTests/ChangeLog 2012-01-12 00:08:01 UTC (rev 104761)
+++ trunk/LayoutTests/ChangeLog 2012-01-12 00:14:42 UTC (rev 104762)
@@ -1,3 +1,13 @@
+2012-01-09 Geoffrey Garen gga...@apple.com
+
+REGRESSION: d3 Bullet Charts demo doesn't work (call with argument assignment is broken)
+https://bugs.webkit.org/show_bug.cgi?id=75911
+
+Reviewed by Filip Pizlo.
+
+* fast/js/function-argument-evaluation-expected.txt: Added.
+* fast/js/function-argument-evaluation.html: Added.
+
2012-01-11 Adam Barth aba...@webkit.org
IETC audio-interface-inherit.129 claims NETWORK_NO_SOURCE should not be overrideable
Added: trunk/LayoutTests/fast/js/function-argument-evaluation-expected.txt (0 => 104762)
--- trunk/LayoutTests/fast/js/function-argument-evaluation-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/js/function-argument-evaluation-expected.txt 2012-01-12 00:14:42 UTC (rev 104762)
@@ -0,0 +1,7 @@
+This page tests function calls whose argument expressions overwrite the callee.
+
+If the test passes, you'll see PASS messages below.
+
+PASS: test1(callback, 1) should be 1 and is.
+PASS: test2(callback, 1) should be 1 and is.
+
Added: trunk/LayoutTests/fast/js/function-argument-evaluation.html (0 => 104762)
--- trunk/LayoutTests/fast/js/function-argument-evaluation.html (rev 0)
+++ trunk/LayoutTests/fast/js/function-argument-evaluation.html 2012-01-12 00:14:42 UTC (rev 104762)
@@ -0,0 +1,48 @@
+pThis page tests function calls whose argument expressions overwrite the callee./p
+pIf the test passes, you'll see PASS messages below.
+/p
+pre id=console/pre
+
+script
+function log(s)
+{
+document.getElementById(console).appendChild(document.createTextNode(s + \n));
+}
+
+function shouldBe(aDescription, a, b)
+{
+if (a === b) {
+log(PASS: + aDescription + should be + b + and is.);
+} else {
+log(FAIL: + aDescription + should be + b + but instead is + a + .);
+}
+}
+
+function test1(callback, x) {
+try {
+return callback.apply(this, [ callback = x ]);
+} catch(e) {
+return e;
+}
+};
+
+function test2(callback, x) {
+try {
+return callback(callback = x);
+} catch(e) {
+return e;
+}
+};
+
+(function () {
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var callback = function callback(x) {
+return x;
+};
+
+shouldBe(test1(callback, 1), test1(callback, 1), 1);
+shouldBe(test2(callback, 1), test2(callback, 1), 1);
+})();
+/script
Modified: trunk/Source/_javascript_Core/ChangeLog (104761 => 104762)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-12 00:08:01 UTC (rev 104761)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-12 00:14:42 UTC (rev 104762)
@@ -1,3 +1,18 @@
+2012-01-09 Geoffrey Garen gga...@apple.com
+
+REGRESSION: d3 Bullet Charts demo doesn't work (call with argument assignment is broken)
+https://bugs.webkit.org/show_bug.cgi?id=75911
+
+* bytecompiler/BytecodeGenerator.h:
+(JSC::BytecodeGenerator::emitNodeForLeftHandSide): Cleanup: No need to
+explicitly cast to our return type in C++.
+
+* bytecompiler/NodesCodegen.cpp:
+(JSC::FunctionCallResolveNode::emitBytecode):
+(JSC::ApplyFunctionCallDotNode::emitBytecode): Make sure to copy our function
+into a temporary register before evaluating our arguments, since argument
+evaluation might include function calls or assignments that overwrite our callee by name.
+
2012-01-11 Michael
[webkit-changes] [104763] trunk/Tools
Title: [104763] trunk/Tools
Revision 104763
Author dpra...@chromium.org
Date 2012-01-11 16:24:39 -0800 (Wed, 11 Jan 2012)
Log Message
Unreviewed, build fix.
Fix chromium-win's version remapping to work correctly on Win 7 SP1.
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.__init__):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
Diff
Modified: trunk/Tools/ChangeLog (104762 => 104763)
--- trunk/Tools/ChangeLog 2012-01-12 00:14:42 UTC (rev 104762)
+++ trunk/Tools/ChangeLog 2012-01-12 00:24:39 UTC (rev 104763)
@@ -1,3 +1,12 @@
+2012-01-11 Dirk Pranke dpra...@chromium.org
+
+Unreviewed, build fix.
+
+Fix chromium-win's version remapping to work correctly on Win 7 SP1.
+
+* Scripts/webkitpy/layout_tests/port/chromium_win.py:
+(ChromiumWinPort.__init__):
+
2012-01-11 Ryosuke Niwa rn...@webkit.org
Sheriffbot build fix. Don't emit empty lines on IRC.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py (104762 => 104763)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py 2012-01-12 00:14:42 UTC (rev 104762)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py 2012-01-12 00:24:39 UTC (rev 104763)
@@ -74,7 +74,7 @@
chromium.ChromiumPort.__init__(self, host, port_name=port_name, **kwargs)
if port_name.endswith('-win'):
assert host.platform.is_win()
-if host.platform.os_version == '7sp0':
+if host.platform.os_version in ('7sp0', '7sp1', 'future'):
self._version = 'win7'
else:
self._version = host.platform.os_version
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104764] trunk
Title: [104764] trunk
Revision 104764
Author commit-qu...@webkit.org
Date 2012-01-11 16:26:57 -0800 (Wed, 11 Jan 2012)
Log Message
implement layout tests for video with media stream
https://bugs.webkit.org/show_bug.cgi?id=74882
Patch by Wei Jia w...@chromium.org on 2012-01-11
Reviewed by Kent Tamura.
Tools:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
(WebKit::WebUserMediaClientMock::create):
(WebKit::WebUserMediaClientMock::IsMockStream):
(WebKit::WebUserMediaClientMock::requestUserMedia):
(WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
* DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
(WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
(WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::userMediaClient):
(WebViewHost::userMediaClientMock):
(WebViewHost::createMediaPlayer):
(WebViewHost::mediaStreamUtil):
(WebViewHost::testMediaStreamClient):
* DumpRenderTree/chromium/WebViewHost.h:
LayoutTests:
* platform/chromium/media/video-capture-preview-expected.txt: Added.
* platform/chromium/media/video-capture-preview.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gypi
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h
Added Paths
trunk/LayoutTests/platform/chromium/media/video-capture-preview-expected.txt
trunk/LayoutTests/platform/chromium/media/video-capture-preview.html
trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp
trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h
Diff
Modified: trunk/LayoutTests/ChangeLog (104763 => 104764)
--- trunk/LayoutTests/ChangeLog 2012-01-12 00:24:39 UTC (rev 104763)
+++ trunk/LayoutTests/ChangeLog 2012-01-12 00:26:57 UTC (rev 104764)
@@ -1,3 +1,13 @@
+2012-01-11 Wei Jia w...@chromium.org
+
+implement layout tests for video with media stream
+https://bugs.webkit.org/show_bug.cgi?id=74882
+
+Reviewed by Kent Tamura.
+
+* platform/chromium/media/video-capture-preview-expected.txt: Added.
+* platform/chromium/media/video-capture-preview.html: Added.
+
2012-01-09 Geoffrey Garen gga...@apple.com
REGRESSION: d3 Bullet Charts demo doesn't work (call with argument assignment is broken)
Added: trunk/LayoutTests/platform/chromium/media/video-capture-preview-expected.txt (0 => 104764)
--- trunk/LayoutTests/platform/chromium/media/video-capture-preview-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/media/video-capture-preview-expected.txt 2012-01-12 00:26:57 UTC (rev 104764)
@@ -0,0 +1,16 @@
+request access to local media
+got a stream
+start preview
+EVENT(loadstart)
+EVENT(loadeddata)
+EVENT(canplay)
+EVENT(canplaythrough)
+EVENT(play)
+restart preview
+EVENT(loadstart)
+EVENT(loadeddata)
+EVENT(canplay)
+EVENT(canplaythrough)
+EVENT(play)
+END OF TEST
+
Added: trunk/LayoutTests/platform/chromium/media/video-capture-preview.html (0 => 104764)
--- trunk/LayoutTests/platform/chromium/media/video-capture-preview.html (rev 0)
+++ trunk/LayoutTests/platform/chromium/media/video-capture-preview.html 2012-01-12 00:26:57 UTC (rev 104764)
@@ -0,0 +1,66 @@
+!DOCTYPE HTML
+html
+head
+script src=""
+script src=""
+script src=""
+
+script type=text/_javascript_
+
+var previewURL = ;
+var localStream = null;
+
+function startPreview()
+{
+video.src = ""
+}
+
+function gotStream(stream)
+{
+consoleWrite(got a stream);
+previewURL = webkitURL.createObjectURL(stream);
+startPreview();
+consoleWrite(start preview);
+localStream = stream;
+var playTimeInMillisecond = 2500;
+var replayIfTimeIsReached = function ()
+{
+startPreview();
+consoleWrite(restart preview);
+setTimeout(endTest, playTimeInMillisecond);
+}
+
+setTimeout(replayIfTimeIsReached, playTimeInMillisecond);
+}
+
+function gotStreamFailed(error)
+{
+consoleWrite(Failed to get access to local media. Error code was + error.code);
+}
+
+function playPreview()
+{
+findMediaElement();
+try {
+consoleWrite(request access to local media);
+navigator.webkitGetUserMedia(video, gotStream, gotStreamFailed);
+} catch (e) {
+consoleWrite(getUserMedia error + ( + e.name + / + e.message + ));
+}
+
+waitForEvent(error);
+waitForEvent(loadstart);
+waitForEvent(loadeddata);
+waitForEvent(canplay);
+waitForEvent(canplaythrough);
+waitForEvent(play);
+}
+
+/script
+/head
+
+body _onload_=playPreview()
+video width=320 height=240 autoplay=autoplay/video
+/body
+/html
+
Modified: trunk/Tools/ChangeLog (104763 => 104764)
--- trunk/Tools/ChangeLog 2012-01-12 00:24:39 UTC (rev 104763)
+++ trunk/Tools/ChangeLog 2012-01-12 00:26:57 UTC (rev 104764)
@@ -1,3 +1,27 @@
+2012-01-11 Wei Jia
[webkit-changes] [104765] branches/chromium/963/Source/WebCore/html/canvas/ WebGLRenderingContext.cpp
Title: [104765] branches/chromium/963/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
Revision 104765
Author k...@google.com
Date 2012-01-11 16:48:41 -0800 (Wed, 11 Jan 2012)
Log Message
Merge 104636 - [chromium] Correctly recreate DrawingBuffer on lost device
https://bugs.webkit.org/show_bug.cgi?id=75912
Patch by John Bauman jbau...@chromium.org on 2012-01-10
Reviewed by Kenneth Russell.
Create new drawing buffer on new context, not old lost context. Also,
make sure to bind new drawing buffer.
No new tests.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::maybeRestoreContext):
TBR=commit-qu...@webkit.org
Review URL: http://codereview.chromium.org/9148050
Modified Paths
branches/chromium/963/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
Diff
Modified: branches/chromium/963/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (104764 => 104765)
--- branches/chromium/963/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2012-01-12 00:26:57 UTC (rev 104764)
+++ branches/chromium/963/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2012-01-12 00:48:41 UTC (rev 104765)
@@ -5025,7 +5025,8 @@
// Construct a new drawing buffer with the new GraphicsContext3D.
if (m_drawingBuffer) {
m_drawingBuffer-discardResources();
-m_drawingBuffer = DrawingBuffer::create(m_context.get(), m_drawingBuffer-size(), !m_attributes.preserveDrawingBuffer);
+m_drawingBuffer = DrawingBuffer::create(context.get(), m_drawingBuffer-size(), !m_attributes.preserveDrawingBuffer);
+m_drawingBuffer-bind();
}
m_context = context;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104766] branches/subpixellayout/LayoutTests
Title: [104766] branches/subpixellayout/LayoutTests
Revision 104766
Author le...@chromium.org
Date 2012-01-11 16:51:14 -0800 (Wed, 11 Jan 2012)
Log Message
Updating and rebaselining remaining failing fast/dom tests.
Modified Paths
branches/subpixellayout/LayoutTests/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt
branches/subpixellayout/LayoutTests/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html
branches/subpixellayout/LayoutTests/fast/dom/Window/webkitConvertPoint-expected.txt
branches/subpixellayout/LayoutTests/fast/dom/Window/webkitConvertPoint.html
branches/subpixellayout/LayoutTests/fast/dom/elementFromPoint-relative-to-viewport-expected.txt
branches/subpixellayout/LayoutTests/fast/dom/elementFromPoint-relative-to-viewport.html
branches/subpixellayout/LayoutTests/platform/mac/fast/dom/HTMLTableElement/createCaption-expected.png
branches/subpixellayout/LayoutTests/platform/mac/fast/dom/HTMLTableElement/createCaption-expected.txt
Diff
Modified: branches/subpixellayout/LayoutTests/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt (104765 => 104766)
--- branches/subpixellayout/LayoutTests/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt 2012-01-12 00:48:41 UTC (rev 104765)
+++ branches/subpixellayout/LayoutTests/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt 2012-01-12 00:51:14 UTC (rev 104766)
@@ -22,13 +22,13 @@
PASS Range.startOffset check (got 14, expected 14)
PASS Range.startContainer check (got [object Text], expected [object Text])
-PASS Range.startOffset check (got 1, expected 1)
+PASS Range.startOffset check (got 0, expected 0)
PASS Range.startContainer check (got [object Text], expected [object Text])
-PASS Range.startOffset check (got 13, expected 13)
+PASS Range.startOffset check (got 6, expected 6)
PASS Range.startContainer check (got [object Text], expected [object Text])
PASS Range.startOffset check (got 4, expected 4)
PASS Range.startContainer check (got [object Text], expected [object Text])
-PASS Range.startOffset check (got 16, expected 16)
+PASS Range.startOffset check (got 10, expected 10)
PASS successfullyParsed is true
Modified: branches/subpixellayout/LayoutTests/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html (104765 => 104766)
--- branches/subpixellayout/LayoutTests/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html 2012-01-12 00:48:41 UTC (rev 104765)
+++ branches/subpixellayout/LayoutTests/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html 2012-01-12 00:51:14 UTC (rev 104766)
@@ -64,10 +64,10 @@
}
if (zoomOrNot == zoom) {
-test(1, 0, 0);
-test(13, 0, 25);
+test(0, 0, 0);
+test(6, 0, 25);
test(4, 50, 0);
-test(16, 50, 25);
+test(10, 50, 25);
} else {
test(0, 0, 0);
test(12, 0, 25);
Modified: branches/subpixellayout/LayoutTests/fast/dom/Window/webkitConvertPoint-expected.txt (104765 => 104766)
--- branches/subpixellayout/LayoutTests/fast/dom/Window/webkitConvertPoint-expected.txt 2012-01-12 00:48:41 UTC (rev 104765)
+++ branches/subpixellayout/LayoutTests/fast/dom/Window/webkitConvertPoint-expected.txt 2012-01-12 00:51:14 UTC (rev 104766)
@@ -38,120 +38,120 @@
Test 1
PASS x is 8
-PASS y is 12
+PASS y is 13
Round Trip of (0,0)
PASS x is 0
PASS y is 0
PASS x is 13
-PASS y is 52
+PASS y is 53
Round Trip of (5,40)
PASS x is 5
PASS y is 40
Test 2
PASS x is 8
-PASS y is 50
+PASS y is 51
Round Trip of (0,0)
PASS x is 0
PASS y is 0
PASS x is 13
-PASS y is 90
+PASS y is 91
Round Trip of (5,40)
PASS x is 5
PASS y is 40
Test 3
PASS x is 8
-PASS y is 84
+PASS y is 85
Round Trip of (0,0)
PASS x is 0
PASS y is 0
PASS x is 13
-PASS y is 124
+PASS y is 125
Round Trip of (5,40)
PASS x is 5
PASS y is 40
Test 4
PASS x is 8
-PASS y is 118
+PASS y is 119
Round Trip of (0,0)
PASS x is 0
PASS y is 0
PASS x is 13
-PASS y is 158
+PASS y is 159
Round Trip of (5,40)
PASS x is 5
PASS y is 40
Test 5
PASS x is 28
-PASS y is 152
+PASS y is 153
Round Trip of (0,0)
PASS x is 0
PASS y is 0
PASS x is 33
-PASS y is 192
+PASS y is 193
Round Trip of (5,40)
PASS x is 5
PASS y is 40
Test 6
PASS x is 28
-PASS y is 186
+PASS y is 187
Round Trip of (0,0)
PASS x is 0
PASS y is 0
PASS x is 33
-PASS y is 226
+PASS y is 227
Round Trip of (5,40)
PASS x is 5
PASS y is 40
Test 7
PASS x is 8
-PASS y is 238
+PASS y is 239
Round Trip of (0,0)
PASS x is 0
PASS y is 0
PASS x is 13
-PASS y is 278
+PASS y is 279
Round Trip of (5,40)
PASS x is 5
PASS y is 40
Test 8
PASS x is 8
-PASS y is 272
+PASS y is 273
Round Trip of (0,0)
PASS x is 0
PASS y is 0
PASS x is 13
-PASS y is 312
+PASS y is 313
Round Trip of (5,40)
PASS x is 5
PASS y is 40
Test 9
PASS x is 28
[webkit-changes] [104767] trunk/Source/WebCore
Title: [104767] trunk/Source/WebCore
Revision 104767
Author hara...@chromium.org
Date 2012-01-11 16:56:24 -0800 (Wed, 11 Jan 2012)
Log Message
Implement the [Supplemental] IDL for custom methods
https://bugs.webkit.org/show_bug.cgi?id=76036
Reviewed by Adam Barth.
We have implemented the [Supplemental] IDL for non-custom methods in bug 75944.
This patch implements it for custom methods. This patch modifies only CodeGeneratorV8.pm,
since CodeGeneratorJS.pm requires no change and other code generators
do not support custom methods.
Test: bindings/scripts/test/TestSupplemental.idl
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/TestSupplemental.idl: Added a custom method with the [Supplemental] IDL.
* bindings/scripts/test/JS/JSTestInterface.cpp: Updated the test result.
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod3):
* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.
(-[DOMTestInterface supplementalMethod3]):
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.mm
trunk/Source/WebCore/bindings/scripts/test/TestSupplemental.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104766 => 104767)
--- trunk/Source/WebCore/ChangeLog 2012-01-12 00:51:14 UTC (rev 104766)
+++ trunk/Source/WebCore/ChangeLog 2012-01-12 00:56:24 UTC (rev 104767)
@@ -1,3 +1,30 @@
+2012-01-11 Kentaro Hara hara...@chromium.org
+
+Implement the [Supplemental] IDL for custom methods
+https://bugs.webkit.org/show_bug.cgi?id=76036
+
+Reviewed by Adam Barth.
+
+We have implemented the [Supplemental] IDL for non-custom methods in bug 75944.
+This patch implements it for custom methods. This patch modifies only CodeGeneratorV8.pm,
+since CodeGeneratorJS.pm requires no change and other code generators
+do not support custom methods.
+
+Test: bindings/scripts/test/TestSupplemental.idl
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateHeader):
+
+* bindings/scripts/test/TestSupplemental.idl: Added a custom method with the [Supplemental] IDL.
+
+* bindings/scripts/test/JS/JSTestInterface.cpp: Updated the test result.
+(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod3):
+* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
+* bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
+* bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.
+(-[DOMTestInterface supplementalMethod3]):
+* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
+
2011-12-21 Shaw Andy andy.s...@digia.com
Fix build issue on Windows when Qt is configured with -ltcg
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (104766 => 104767)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-01-12 00:51:14 UTC (rev 104766)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-01-12 00:56:24 UTC (rev 104767)
@@ -400,7 +400,7 @@
my $name = $function-signature-name;
my $attrExt = $function-signature-extendedAttributes;
-if (($attrExt-{Custom} || $attrExt-{V8Custom}) $function-{overloadIndex} == 1) {
+if (($attrExt-{Custom} || $attrExt-{V8Custom}) !$attrExt-{ImplementedBy} $function-{overloadIndex} == 1) {
push(@headerContent, END);
static v8::Handlev8::Value ${name}Callback(const v8::Arguments);
END
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (104766 => 104767)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2012-01-12 00:51:14 UTC (rev 104766)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2012-01-12 00:56:24 UTC (rev 104767)
@@ -137,10 +137,13 @@
#if ENABLE(Condition11) || ENABLE(Condition12)
{ supplementalMethod2, DontDelete | JSC::Function, (intptr_t)static_castNativeFunction(jsTestInterfacePrototypeFunctionSupplementalMethod2), (intptr_t)2, NoIntrinsic },
#endif
+#if ENABLE(Condition11) || ENABLE(Condition12)
+{ supplementalMethod3, DontDelete | JSC::Function, (intptr_t)static_castNativeFunction(jsTestInterfacePrototypeFunctionSupplementalMethod3), (intptr_t)0, NoIntrinsic },
+#endif
{ 0, 0, 0, 0, NoIntrinsic }
};
-static const HashTable JSTestInterfacePrototypeTable = { 5, 3, JSTestInterfacePrototypeTableValues, 0 };
+static const HashTable JSTestInterfacePrototypeTable = { 8, 7,
[webkit-changes] [104768] trunk/Tools
Title: [104768] trunk/Tools Revision 104768 Author dpra...@chromium.org Date 2012-01-11 16:58:52 -0800 (Wed, 11 Jan 2012) Log Message test-webkitpy: push more logic into webkitpy.test.main, clean up code https://bugs.webkit.org/show_bug.cgi?id=76021 Reviewed by Eric Seidel. I plan to add more functionality to test-webkitpy, but it is difficult to hack on now; this patch is the first of two that brings test-webkitpy more inline with current coding style by pushing more logic into the webkitpy.test.main.Tester class (so that it will be testable itself). There should be no functional changes in this patch. * Scripts/test-webkitpy: (_path_from_webkit_root): * Scripts/webkitpy/test/main.py: (Tester): (Tester.init): (Tester.configure_logging): (Tester.configure_logging.filter): (Tester.clean_packages): (Tester.run_tests): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/test-webkitpy trunk/Tools/Scripts/webkitpy/test/main.py Diff Modified: trunk/Tools/ChangeLog (104767 => 104768) --- trunk/Tools/ChangeLog 2012-01-12 00:56:24 UTC (rev 104767) +++ trunk/Tools/ChangeLog 2012-01-12 00:58:52 UTC (rev 104768) @@ -1,3 +1,28 @@ +2012-01-10 Dirk Pranke dpra...@chromium.org + +test-webkitpy: push more logic into webkitpy.test.main, clean up code +https://bugs.webkit.org/show_bug.cgi?id=76021 + +Reviewed by Eric Seidel. + +I plan to add more functionality to test-webkitpy, but it is +difficult to hack on now; this patch is the first of two that +brings test-webkitpy more inline with current coding style by +pushing more logic into the webkitpy.test.main.Tester class (so +that it will be testable itself). + +There should be no functional changes in this patch. + +* Scripts/test-webkitpy: +(_path_from_webkit_root): +* Scripts/webkitpy/test/main.py: +(Tester): +(Tester.init): +(Tester.configure_logging): +(Tester.configure_logging.filter): +(Tester.clean_packages): +(Tester.run_tests): + 2012-01-11 Wei Jia w...@chromium.org implement layout tests for video with media stream Modified: trunk/Tools/Scripts/test-webkitpy (104767 => 104768) --- trunk/Tools/Scripts/test-webkitpy 2012-01-12 00:56:24 UTC (rev 104767) +++ trunk/Tools/Scripts/test-webkitpy 2012-01-12 00:58:52 UTC (rev 104768) @@ -32,179 +32,36 @@ import os import sys -# We strictly limit what is imported from webkitpy until we get a chance -# to delete any stray *.pyc files. -import webkitpy.common.version_check +# NOTE: We intentionally limit imports from webkitpy here to minimize the +# chances of breaking test-webkitpy itself. +from webkitpy.common import version_check +from webkitpy.test import main + _log = logging.getLogger(test-webkitpy) -# Verbose logging is useful for debugging test-webkitpy code that runs -# before the actual unit tests -- things like autoinstall downloading and -# unit-test auto-detection logic. This is different from verbose logging -# of the unit tests themselves (i.e. the unittest module's --verbose flag). -def configure_logging(is_verbose_logging): -Configure the root logger. - -Configure the root logger not to log any messages from webkitpy -- -except for messages from the autoinstall module. Also set the -logging level as described below. - -Args: - is_verbose_logging: A boolean value of whether logging should be - verbose. If this parameter is true, the logging - level for the handler on the root logger is set to - logging.DEBUG. Otherwise, it is set to logging.INFO. - - -if is_verbose_logging: -logging_level = logging.DEBUG -else: -logging_level = logging.INFO - -handler = logging.StreamHandler(sys.stderr) -# We constrain the level on the handler rather than on the root -# logger itself. This is probably better because the handler is -# configured and known only to this module, whereas the root logger -# is an object shared (and potentially modified) by many modules. -# Modifying the handler, then, is less intrusive and less likely to -# interfere with modifications made by other modules (e.g. in unit -# tests). -handler.setLevel(logging_level) -formatter = logging.Formatter(%(name)s: %(levelname)-8s %(message)s) -handler.setFormatter(formatter) - -logger = logging.getLogger() -logger.addHandler(handler) -logger.setLevel(logging.NOTSET) - -# Filter out most webkitpy messages. -# -# Messages can be selectively re-enabled for this script by updating -# this method accordingly. -def filter(record): -Filter out autoinstall and non-third-party webkitpy messages. -# FIXME: Figure out a way not to use strings here, for example by -#using syntax like webkitpy.test.__name__. We want to be -
[webkit-changes] [104769] branches/chromium/963
Title: [104769] branches/chromium/963
Revision 104769
Author k...@google.com
Date 2012-01-11 17:00:17 -0800 (Wed, 11 Jan 2012)
Log Message
Merge 104732 - [chromium] Color profiles are incorrect for images without premultiplied alpha
https://bugs.webkit.org/show_bug.cgi?id=75999
Reviewed by Stephen White.
Source/WebCore:
Don't apply the color profile if the user has requested separate alpha.
Test: fast/canvas/webgl/texture-color-profile.html
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::setStatus):
LayoutTests:
Verify that the image's contents don't get destroyed if using both
separate alpha as well as the browser's colorspace conversion.
* fast/canvas/webgl/resources/tan-1x1-with-alpha.png: Added.
* fast/canvas/webgl/texture-color-profile-expected.txt: Added.
* fast/canvas/webgl/texture-color-profile.html: Added.
TBR=k...@google.com
Review URL: http://codereview.chromium.org/9187038
Modified Paths
branches/chromium/963/Source/WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp
Added Paths
branches/chromium/963/LayoutTests/fast/canvas/webgl/resources/tan-1x1-with-alpha.png
branches/chromium/963/LayoutTests/fast/canvas/webgl/texture-color-profile-expected.txt
branches/chromium/963/LayoutTests/fast/canvas/webgl/texture-color-profile.html
Diff
Copied: branches/chromium/963/LayoutTests/fast/canvas/webgl/resources/tan-1x1-with-alpha.png (from rev 104732, trunk/LayoutTests/fast/canvas/webgl/resources/tan-1x1-with-alpha.png) (0 => 104769)
--- branches/chromium/963/LayoutTests/fast/canvas/webgl/resources/tan-1x1-with-alpha.png (rev 0)
+++ branches/chromium/963/LayoutTests/fast/canvas/webgl/resources/tan-1x1-with-alpha.png 2012-01-12 01:00:17 UTC (rev 104769)
@@ -0,0 +1,27 @@
+\x89PNG
+
+
+IHDR ĉ
+OiCCPPhotoshop ICC profile xڝSgTS\xE9=\xF7\xDE\xF4BK\x88\x80\x94KoR RB\x8B\x80\x91*! J\x88!\xA1\xD9Q\xC1EEȠ\x88\x8E\x8E\x80\x8CQ, \x8A
+\xD8\xE4!\xA2\x8E\x83\xA3\x88\x8A\xCA\xFB\xE1{\xA3kּ\xF7\xE6\xCD\xFE\xB5\xD7\xE7\xAC\xF3\x9D\xB3\xCF\xC0 \x96H3Q5\x80 \xA9B \xE0\x83\xC7\xC4\xC6\xE1\xE4.@\x81
+$p \xB3d!s\xFD# \xF8~+\xC0\xBE x\xD3 \xC0M\x9B\xC00 \x87\xFF\xEAB\x99\\x80\x84\xC0t\x918K\x80 @z\x8EB\xA6 @F\x80\x9D\x98S \xA0 `\xCBcb\xE3 P- `'\xE6\xD3 \x80\x9D\xF8\x99{ [\x94!\xA0\x91 e\x88D h; \xAC\xCFV\x8AE X0 fK\xC49 \xD8- 0IWfH \xB0\xB7 \xC0\xCE \xB2 0Q\x88\x85) { `\xC8##x \x84\x99 F\xF2W\xF1+\xAE\xE7* x\x99\xB2\xB9$9E\x81[-qWW. (\xCEI+6aa\x9A@.\xC2y\x992\x814\xE0\xF3\xCC \xA0\x91\xE0\x83\xF3\xFDx\xCE\xAE\xCE\xCE6\x8E\xB6_-\xEA\xBF\xFFbb\xE3\xFE\xE5ϫp@ \xE1t~\xD1\xFE,/\xB3\x80;\x80m\xFE\xA2%\xEEh^ \xA0u\xF7\x8Bf\xB2@\xB5 \xA0\xE9\xDAW\xF3p\xF8~E\xA1\x90\xB9\xD9\xD9\xE5\xE4\xE4\xD8J\xC4B[a\xCAW}\xFEg\xC2_\xC0W\xFDl\xF9~\xFC\xF7\xF5\xE0\xBE\xE2$\x812]\x81G\xF8\xE0\xC2\xCC\xF4L\xA5 ϒ \x84b\xDC\xE6\x8FG\xFC\xB7 \xFF\xFC \xD3\xC4Ib\xB9X*\xE3Qq\x8ED\x9A\x8C\xF32\xA5\x89B\x92)\xC5%\xD2\xFFd\xE2\xDF,\xFB\xDF5 \xB0j{\x91-\xA8]c\xF6K'Xt\xC0\xE2\xF7 \xF2\xBBo\xC1\xD4(\x80h\x83\xE1\xCFw\xFF\xEF?\xFDG\xA0% \x80fI\x92q ^D$.Tʳ?\xC7 D\xA0\x81*\xB0A\xF4\xC1,\xC0 \xC1\xDC\xC1 \xFC`6\x84B$\xC4\xC2BB
+d\x80 r`)\xAC\x82B(\x86Ͱ *`/\xD4@ 4\xC0Qh\x86\x93p.\xC2U\xB8=p\xFAa\x9E\xC1(\xBC\x81 A\xC8a!ڈb\x8AX#\x8E\x99\x85\xF8!\xC1H\x8B$ ɈQK\x915H1R\x8AT UH \xF2=r9\x87\F\xBA\x91;\xC8 2\x82\xFC\x86\xBCG1\x94\x81\xB2Q=\xD4 \xB5C\xB9\xA87\x84F\xA2 \xD0dt1\x9A\x8F\xA0\x9B\xD0r\xB4=\x8C6\xA1\xE7ЫhڏC\xC70\xC0\xE83\xC4l0.\xC6\xC3B\xB18, \x93c˱\xAC \xAB\xC6\xB0V\xAC\xBB\x89\xF5cϱw\x81E\xC0 6wB a AHXLXN\xD8H\xA8 $4\xDA 7 \x84Q\xC2'\x93\xA8K\xB4\xBA\xF9\xC4b21\x87XH,#\xD6\x8F/{\x88C\xC47$\x89C2'\xB9\x90I\xB1\xA4T\xD2\xD2F\xD2nR#\xE9,\xA9\x9B4H#\x93\xC9\xDAdk\xB29\x94, +ȅ\xE4\x9D\xE4\xC3\xE43\xE4\xE4!\xF2[
+\x9Db@q\xA4\xF8S\xE2(R\xCAjJ\xE5\xE54\xE5e\x982AU\xA3\x9ARݨ\xA1T5\x8FZB\xAD\xA1\xB6R\xAFQ\x87\xA84u\x9A9̓IK\xA5\xAD\xA2\x95\xD3hh\xF7i\xAF\xE8t\xBAݕ N\x97\xD0W\xD2\xCB\xE9G\xE8\x97\xE8\xF4w
+\x86\x83Ljg(\x9Bgw\xAF\x98L\xA6Ӌ\xC7T071\xEB\x98\xE7\x99\x99oUX*\xB6*|\x91\xCA
+\x95J\x95\x95*/T\xA9\xAA\xA6\xAAު U\xF3U\xCBT\x8F\xA9^S}\xAEFU3S\xE3\xA9 Ԗ\xABU\xAA\x9DP\xEBSSg\xA9;\xA8\x87\xAAg\xA8oT?\xA4~Y\xFD\x89Y\xC3L\xC3OC\xA4Q\xA0\xB1_\xE3\xBC\xC6 c\xB3x,!k
+\xAB\x86u\x815\xC4\xB1\xCD\xD9|v*\xBB\x98\xFD \xBB\x8B=\xAA\xA9\xA19C3J3W\xB3R\xF3\x94f?\xE3\x98q\xF8\x9CtN \xE7(\xA7\x97\xF3~\x8A\xDE\xEF)\xE2)\xA64L\xB91e\k\xAA\x96\x97\x96X\xABH\xABQ\xABG\xEB\xBD6\xAE\x{D9DD}\xA6\xBDE\xBBY\xFB\x81A\xC7J'\'Gg\x8F\xCE\x9D\xE7S\xD9Sݧ
+\xA7M=:\xF5\xAE.\xAAk\xA5\xA1\xBBDw\xBFn\xA7\xBE^\x80\x9ELo\xA7\xDEy\xBD\xE7\xFA }/\xFDT\xFDm\xFA\xA7\xF5G X\xB3 $\xDB \xCE\xC55qo
[webkit-changes] [104770] trunk/Source/JavaScriptCore
Title: [104770] trunk/Source/_javascript_Core
Revision 104770
Author gga...@apple.com
Date 2012-01-11 17:00:58 -0800 (Wed, 11 Jan 2012)
Log Message
Bytecode dumping is broken for call opcodes (due to two new operands)
https://bugs.webkit.org/show_bug.cgi?id=75886
Reviewed by Oliver Hunt.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printCallOp): Made a helper function, so I wouldn't have
to fix this more than once. The helper function skips the extra two operands
at the end of the opcode, used for optimization.
(JSC::CodeBlock::dump): Used the helper function.
* bytecode/CodeBlock.h: Declared the helper function.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (104769 => 104770)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-12 01:00:17 UTC (rev 104769)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-12 01:00:58 UTC (rev 104770)
@@ -1,3 +1,19 @@
+2012-01-11 Geoffrey Garen gga...@apple.com
+
+Bytecode dumping is broken for call opcodes (due to two new operands)
+https://bugs.webkit.org/show_bug.cgi?id=75886
+
+Reviewed by Oliver Hunt.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::printCallOp): Made a helper function, so I wouldn't have
+to fix this more than once. The helper function skips the extra two operands
+at the end of the opcode, used for optimization.
+
+(JSC::CodeBlock::dump): Used the helper function.
+
+* bytecode/CodeBlock.h: Declared the helper function.
+
2012-01-09 Geoffrey Garen gga...@apple.com
REGRESSION: d3 Bullet Charts demo doesn't work (call with argument assignment is broken)
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (104769 => 104770)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2012-01-12 01:00:17 UTC (rev 104769)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2012-01-12 01:00:58 UTC (rev 104770)
@@ -183,6 +183,15 @@
it += 4;
}
+void CodeBlock::printCallOp(ExecState* exec, int location, VectorInstruction::const_iterator it, const char* op) const
+{
+int func = (++it)-u.operand;
+int argCount = (++it)-u.operand;
+int registerOffset = (++it)-u.operand;
+printf([%4d] %s\t %s, %d, %d\n, location, op, registerName(exec, func).data(), argCount, registerOffset);
+it += 2;
+}
+
void CodeBlock::printPutByIdOp(ExecState* exec, int location, VectorInstruction::const_iterator it, const char* op) const
{
int r0 = (++it)-u.operand;
@@ -522,7 +531,7 @@
}
case op_convert_this: {
int r0 = (++it)-u.operand;
-printf([%4d] convert_this %s\n, location, registerName(exec, r0).data());
+printf([%4d] convert_this\t %s\n, location, registerName(exec, r0).data());
break;
}
case op_new_object: {
@@ -1119,17 +1128,11 @@
break;
}
case op_call: {
-int func = (++it)-u.operand;
-int argCount = (++it)-u.operand;
-int registerOffset = (++it)-u.operand;
-printf([%4d] call\t\t %s, %d, %d\n, location, registerName(exec, func).data(), argCount, registerOffset);
+printCallOp(exec, location, it, call);
break;
}
case op_call_eval: {
-int func = (++it)-u.operand;
-int argCount = (++it)-u.operand;
-int registerOffset = (++it)-u.operand;
-printf([%4d] call_eval\t %s, %d, %d\n, location, registerName(exec, func).data(), argCount, registerOffset);
+printCallOp(exec, location, it, call_eval);
break;
}
case op_call_varargs: {
@@ -1148,7 +1151,7 @@
}
case op_tear_off_arguments: {
int r0 = (++it)-u.operand;
-printf([%4d] tear_off_arguments\t %s\n, location, registerName(exec, r0).data());
+printf([%4d] tear_off_arguments %s\n, location, registerName(exec, r0).data());
break;
}
case op_ret: {
@@ -1168,10 +1171,7 @@
break;
}
case op_construct: {
-int func = (++it)-u.operand;
-int argCount = (++it)-u.operand;
-int registerOffset = (++it)-u.operand;
-printf([%4d] construct\t %s, %d, %d\n, location, registerName(exec, func).data(), argCount, registerOffset);
+printCallOp(exec, location, it, construct);
break;
}
case op_strcat: {
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (104769 => 104770)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2012-01-12 01:00:17 UTC (rev 104769)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2012-01-12 01:00:58 UTC (rev 104770)
@@ -989,6 +989,7 @@
void printBinaryOp(ExecState*, int location,
[webkit-changes] [104772] branches/chromium/963
Title: [104772] branches/chromium/963
Revision 104772
Author k...@google.com
Date 2012-01-11 17:15:38 -0800 (Wed, 11 Jan 2012)
Log Message
Merge 104736 - [v8] Int16Array.set(array, offset) fails on first execution
https://bugs.webkit.org/show_bug.cgi?id=76040
Patch by Ulan Degenbaev u...@chromium.org on 2012-01-11
Reviewed by Kenneth Russell.
* LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt: Added.
* LayoutTests/fast/canvas/webgl/array-set-with-offset.html: Added.
* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
TBR=commit-qu...@webkit.org
Review URL: http://codereview.chromium.org/9186030
Modified Paths
branches/chromium/963/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp
branches/chromium/963/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h
Added Paths
branches/chromium/963/LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt
branches/chromium/963/LayoutTests/fast/canvas/webgl/array-set-with-offset.html
Diff
Copied: branches/chromium/963/LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt (from rev 104736, trunk/LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt) (0 => 104772)
--- branches/chromium/963/LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt (rev 0)
+++ branches/chromium/963/LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt 2012-01-12 01:15:38 UTC (rev 104772)
@@ -0,0 +1,51 @@
+Test setting WebGL array with offset
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+Regression test for https://bugs.webkit.org/show_bug.cgi?id=76040 : Int16Array.set(array, offset) fails on first execution
+Testing Int8Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Uint8Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Int16Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Uint16Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Int32Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Uint32Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+Testing Float32Array
+PASS webGLArray[0] is 0
+PASS webGLArray[1] is 1
+PASS webGLArray[2] is 2
+PASS webGLArray[3] is bounds[0]
+PASS webGLArray[4] is bounds[1]
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: branches/chromium/963/LayoutTests/fast/canvas/webgl/array-set-with-offset.html (from rev 104736, trunk/LayoutTests/fast/canvas/webgl/array-set-with-offset.html) (0 => 104772)
--- branches/chromium/963/LayoutTests/fast/canvas/webgl/array-set-with-offset.html (rev 0)
+++ branches/chromium/963/LayoutTests/fast/canvas/webgl/array-set-with-offset.html 2012-01-12 01:15:38 UTC (rev 104772)
@@ -0,0 +1,45 @@
+html
+head
+script src=""
+script src=""
+/head
+body
+div id=description/div
+div id=console/div
+
+script
+description(Test setting WebGL array with offset);
+
+debug('Regression test for a href="" : codeInt16Array.set(array, offset) fails on first execution/code');
+
+var webGLArray = null;
+var array = null;
+var bounds = null;
+
+function testSetters(typeName, low, high) {
+bounds = [low, high];
+var type = window[typeName];
+var array_buffer = new ArrayBuffer(32);
+webGLArray = new type(array_buffer);
+debug(Testing + typeName);
+array = [1, 2, low, high];
+webGLArray.set(array, 1);
+shouldBe(webGLArray[0], 0);
+shouldBe(webGLArray[1], 1);
+shouldBe(webGLArray[2], 2);
+shouldBe(webGLArray[3], bounds[0]);
+shouldBe(webGLArray[4], bounds[1]);
+}
+
+testSetters(Int8Array, -128, 127);
+testSetters(Uint8Array, 0, 255);
+testSetters(Int16Array, -32768, 32767);
+testSetters(Uint16Array, 0, 65535);
+testSetters(Int32Array, -2147483648, 2147483647);
+testSetters(Uint32Array, 0, 4294967295);
+testSetters(Float32Array, -2.5, 3.5);
+/script
+
+script src=""
+/body
+/html
Modified: branches/chromium/963/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp (104771 => 104772)
--- branches/chromium/963/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp 2012-01-12 01:02:49 UTC (rev 104771)
+++ branches/chromium/963/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp 2012-01-12 01:15:38 UTC (rev 104772)
@@ -58,12 +58,18 @@
}
-void copyElements(v8::Handlev8::Object destArray,
[webkit-changes] [104773] trunk/Source
Title: [104773] trunk/Source Revision 104773 Author bda...@apple.com Date 2012-01-11 17:17:47 -0800 (Wed, 11 Jan 2012) Log Message https://bugs.webkit.org/show_bug.cgi?id=75904 WebKit 1: Scrollbar uiStateTransitionProgress requires tracking the mouse all the time -and corresponding- rdar://problem/10498816 Reviewed by Darin Adler. Source/WebCore: This patch gets rid of the optional parameter called onlyUpdateScrollbars for mouseMoved() and instead moves that functionality into its own function called passMouseMovedEventToScrollbars(). * WebCore.exp.in: * page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): (WebCore::EventHandler::passMouseMovedEventToScrollbars): * page/EventHandler.h: * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseMovedEventToScrollbars): Source/WebKit/mac: New ivar trackingAreaForNonKeyWindow stores our NSTrackingArea whenever we have one. * WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): When we know that mouse movements won't affect anything other than scrollbars, call our new function passMouseMovedEventToScrollbars(), otherwise we'll call the old mouseMoved(). (mouseEventIsPartOfClickOrDrag): (-[WebHTMLView _updateMouseoverWithEvent:]): Make sure not to remove the mouse observer when there are legacy scrollbars. (-[WebHTMLView removeMouseMovedObserver]): Set up a tracking area when the window is not key to ensure that the WebView gets the relevant events. Remove it when the window is key again so that we rely on the existing mechanism. (-[WebHTMLView windowDidBecomeKey:]): (-[WebHTMLView windowDidResignKey:]): Source/WebKit2: This patch gets rid of the optional parameter called onlyUpdateScrollbars for WebCore::EventHandler::mouseMoved() and instead moves that functionality into its own function called passMouseMovedEventToScrollbars(). * WebProcess/WebPage/WebPage.cpp: (WebKit::handleMouseEvent): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/EventHandler.h trunk/Source/WebCore/page/mac/EventHandlerMac.mm trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebHTMLView.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (104772 => 104773) --- trunk/Source/WebCore/ChangeLog 2012-01-12 01:15:38 UTC (rev 104772) +++ trunk/Source/WebCore/ChangeLog 2012-01-12 01:17:47 UTC (rev 104773) @@ -1,3 +1,24 @@ +2012-01-11 Beth Dakin bda...@apple.com + +https://bugs.webkit.org/show_bug.cgi?id=75904 +WebKit 1: Scrollbar uiStateTransitionProgress requires tracking the mouse all +the time +-and corresponding- +rdar://problem/10498816 + +Reviewed by Darin Adler. + +This patch gets rid of the optional parameter called onlyUpdateScrollbars for +mouseMoved() and instead moves that functionality into its own function +called passMouseMovedEventToScrollbars(). +* WebCore.exp.in: +* page/EventHandler.cpp: +(WebCore::EventHandler::mouseMoved): +(WebCore::EventHandler::passMouseMovedEventToScrollbars): +* page/EventHandler.h: +* page/mac/EventHandlerMac.mm: +(WebCore::EventHandler::passMouseMovedEventToScrollbars): + 2012-01-11 Joshua Bell jsb...@chromium.org IndexedDB: Methods should throw TRANSACTION_INACTIVE_ERR when transaction is completed/aborted Modified: trunk/Source/WebCore/WebCore.exp.in (104772 => 104773) --- trunk/Source/WebCore/WebCore.exp.in 2012-01-12 01:15:38 UTC (rev 104772) +++ trunk/Source/WebCore/WebCore.exp.in 2012-01-12 01:17:47 UTC (rev 104773) @@ -225,7 +225,7 @@ __ZN7WebCore12ChromeClient23paintCustomOverhangAreaEPNS_15GraphicsContextERKNS_7IntRectES5_S5_ __ZN7WebCore12EditingStyleD1Ev __ZN7WebCore12EventHandler10mouseMovedEP7NSEvent -__ZN7WebCore12EventHandler10mouseMovedERKNS_18PlatformMouseEventEb +__ZN7WebCore12EventHandler10mouseMovedERKNS_18PlatformMouseEventE __ZN7WebCore12EventHandler10wheelEventEP7NSEvent __ZN7WebCore12EventHandler12mouseDraggedEP7NSEvent __ZN7WebCore12EventHandler14currentNSEventEv @@ -237,6 +237,8 @@ __ZN7WebCore12EventHandler21handleMousePressEventERKNS_18PlatformMouseEventE __ZN7WebCore12EventHandler23handleMouseReleaseEventERKNS_18PlatformMouseEventE __ZN7WebCore12EventHandler24logicalScrollRecursivelyENS_22ScrollLogicalDirectionENS_17ScrollGranularityEPNS_4NodeE +__ZN7WebCore12EventHandler31passMouseMovedEventToScrollbarsEP7NSEvent +__ZN7WebCore12EventHandler31passMouseMovedEventToScrollbarsERKNS_18PlatformMouseEventE __ZN7WebCore12EventHandler7mouseUpEP7NSEvent __ZN7WebCore12EventHandler8keyEventEP7NSEvent __ZN7WebCore12EventHandler8keyEventERKNS_21PlatformKeyboardEventE Modified: trunk/Source/WebCore/page/EventHandler.cpp (104772 => 104773) --- trunk/Source/WebCore/page/EventHandler.cpp
[webkit-changes] [104774] trunk/Source/JavaScriptCore
Title: [104774] trunk/Source/_javascript_Core
Revision 104774
Author fpi...@apple.com
Date 2012-01-11 17:23:49 -0800 (Wed, 11 Jan 2012)
Log Message
Code duplication for invoking the JIT and DFG should be reduced
https://bugs.webkit.org/show_bug.cgi?id=76117
rdar://problem/10680189
Rubber stamped by Geoff Garen.
* GNUmakefile.list.am:
* _javascript_Core.xcodeproj/project.pbxproj:
* jit/JITDriver.h: Added.
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/runtime/Executable.cpp
Added Paths
trunk/Source/_javascript_Core/jit/JITDriver.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (104773 => 104774)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-12 01:17:47 UTC (rev 104773)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-12 01:23:49 UTC (rev 104774)
@@ -1,3 +1,22 @@
+2012-01-11 Filip Pizlo fpi...@apple.com
+
+Code duplication for invoking the JIT and DFG should be reduced
+https://bugs.webkit.org/show_bug.cgi?id=76117
+rdar://problem/10680189
+
+Rubber stamped by Geoff Garen.
+
+* GNUmakefile.list.am:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* jit/JITDriver.h: Added.
+(JSC::jitCompileIfAppropriate):
+(JSC::jitCompileFunctionIfAppropriate):
+* runtime/Executable.cpp:
+(JSC::EvalExecutable::compileInternal):
+(JSC::ProgramExecutable::compileInternal):
+(JSC::FunctionExecutable::compileForCallInternal):
+(JSC::FunctionExecutable::compileForConstructInternal):
+
2012-01-11 Geoffrey Garen gga...@apple.com
Bytecode dumping is broken for call opcodes (due to two new operands)
Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (104773 => 104774)
--- trunk/Source/_javascript_Core/GNUmakefile.list.am 2012-01-12 01:17:47 UTC (rev 104773)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2012-01-12 01:23:49 UTC (rev 104774)
@@ -268,6 +268,7 @@
Source/_javascript_Core/jit/JITCall32_64.cpp \
Source/_javascript_Core/jit/JITCall.cpp \
Source/_javascript_Core/jit/JITCode.h \
+ Source/_javascript_Core/jit/JITDriver.h \
Source/_javascript_Core/jit/JIT.cpp \
Source/_javascript_Core/jit/JIT.h \
Source/_javascript_Core/jit/JITExceptions.cpp \
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (104773 => 104774)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2012-01-12 01:17:47 UTC (rev 104773)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2012-01-12 01:23:49 UTC (rev 104774)
@@ -60,6 +60,7 @@
0F0B83B914BCF95F00885B4F /* CallReturnOffsetToBytecodeOffset.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F0B83B814BCF95B00885B4F /* CallReturnOffsetToBytecodeOffset.h */; settings = {ATTRIBUTES = (Private, ); }; };
0F15F15F14B7A73E005DE37D /* CommonSlowPaths.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F15F15D14B7A73A005DE37D /* CommonSlowPaths.h */; settings = {ATTRIBUTES = (Private, ); }; };
0F16D726142C39C000CF784A /* BitVector.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F16D724142C39A200CF784A /* BitVector.cpp */; };
+ 0F21C26814BE5F6800ADC64B /* JITDriver.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F21C26614BE5F5E00ADC64B /* JITDriver.h */; settings = {ATTRIBUTES = (Private, ); }; };
0F242DA713F3B1E8007ADD4C /* WeakReferenceHarvester.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F242DA513F3B1BB007ADD4C /* WeakReferenceHarvester.h */; settings = {ATTRIBUTES = (Private, ); }; };
0F2C556F14738F3100121E4F /* DFGCodeBlocks.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F2C556E14738F2E00121E4F /* DFGCodeBlocks.h */; settings = {ATTRIBUTES = (Private, ); }; };
0F2C557014738F3500121E4F /* DFGCodeBlocks.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F2C556D14738F2E00121E4F /* DFGCodeBlocks.cpp */; };
@@ -827,6 +828,7 @@
0F0B83B814BCF95B00885B4F /* CallReturnOffsetToBytecodeOffset.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CallReturnOffsetToBytecodeOffset.h; sourceTree = group; };
0F15F15D14B7A73A005DE37D /* CommonSlowPaths.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CommonSlowPaths.h; sourceTree = group; };
0F16D724142C39A200CF784A /* BitVector.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = BitVector.cpp; sourceTree = group; };
+ 0F21C26614BE5F5E00ADC64B /* JITDriver.h */ = {isa = PBXFileReference;
[webkit-changes] [104775] trunk
Title: [104775] trunk Revision 104775 Author aba...@webkit.org Date 2012-01-11 17:24:23 -0800 (Wed, 11 Jan 2012) Log Message iframe sandbox doesn't block autofocus (IETC automatic-feature-block-autofocus-form-control) https://bugs.webkit.org/show_bug.cgi?id=76120 Reviewed by Eric Seidel. Source/WebCore: Test: fast/forms/no-autofocus-in-sandbox.html * html/HTMLFormControlElement.cpp: (WebCore::shouldAutofocus): - The HTML5 spec says that we shouldn't autofocus elements when the automatic features are sandboxed. LayoutTests: * fast/forms/no-autofocus-in-sandbox-expected.txt: Added. * fast/forms/no-autofocus-in-sandbox.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLFormControlElement.cpp Added Paths trunk/LayoutTests/fast/forms/no-autofocus-in-sandbox-expected.txt trunk/LayoutTests/fast/forms/no-autofocus-in-sandbox.html Diff Modified: trunk/LayoutTests/ChangeLog (104774 => 104775) --- trunk/LayoutTests/ChangeLog 2012-01-12 01:23:49 UTC (rev 104774) +++ trunk/LayoutTests/ChangeLog 2012-01-12 01:24:23 UTC (rev 104775) @@ -1,3 +1,13 @@ +2012-01-11 Adam Barth aba...@webkit.org + +iframe sandbox doesn't block autofocus (IETC automatic-feature-block-autofocus-form-control) +https://bugs.webkit.org/show_bug.cgi?id=76120 + +Reviewed by Eric Seidel. + +* fast/forms/no-autofocus-in-sandbox-expected.txt: Added. +* fast/forms/no-autofocus-in-sandbox.html: Added. + 2012-01-11 Joshua Bell jsb...@chromium.org IndexedDB: Methods should throw TRANSACTION_INACTIVE_ERR when transaction is completed/aborted Added: trunk/LayoutTests/fast/forms/no-autofocus-in-sandbox-expected.txt (0 => 104775) --- trunk/LayoutTests/fast/forms/no-autofocus-in-sandbox-expected.txt (rev 0) +++ trunk/LayoutTests/fast/forms/no-autofocus-in-sandbox-expected.txt 2012-01-12 01:24:23 UTC (rev 104775) @@ -0,0 +1,2 @@ +ALERT: BODY +This test passes if the activeElement is the body rather than the input element (which it would be if the sandbox didn't succeed in blocking autofocus). Added: trunk/LayoutTests/fast/forms/no-autofocus-in-sandbox.html (0 => 104775) --- trunk/LayoutTests/fast/forms/no-autofocus-in-sandbox.html (rev 0) +++ trunk/LayoutTests/fast/forms/no-autofocus-in-sandbox.html 2012-01-12 01:24:23 UTC (rev 104775) @@ -0,0 +1,8 @@ +script +if (window.layoutTestController) +layoutTestController.dumpAsText(); +/script +This test passes if the activeElement is the body rather than the input element +(which it would be if the sandbox didn't succeed in blocking autofocus). +iframe sandbox=allow-scripts +src="" autofocus onfocusscriptalert(document.activeElement.tagName)/script/iframe Modified: trunk/Source/WebCore/ChangeLog (104774 => 104775) --- trunk/Source/WebCore/ChangeLog 2012-01-12 01:23:49 UTC (rev 104774) +++ trunk/Source/WebCore/ChangeLog 2012-01-12 01:24:23 UTC (rev 104775) @@ -1,3 +1,17 @@ +2012-01-11 Adam Barth aba...@webkit.org + +iframe sandbox doesn't block autofocus (IETC automatic-feature-block-autofocus-form-control) +https://bugs.webkit.org/show_bug.cgi?id=76120 + +Reviewed by Eric Seidel. + +Test: fast/forms/no-autofocus-in-sandbox.html + +* html/HTMLFormControlElement.cpp: +(WebCore::shouldAutofocus): +- The HTML5 spec says that we shouldn't autofocus elements when the + automatic features are sandboxed. + 2012-01-11 Beth Dakin bda...@apple.com https://bugs.webkit.org/show_bug.cgi?id=75904 Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (104774 => 104775) --- trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2012-01-12 01:23:49 UTC (rev 104774) +++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2012-01-12 01:24:23 UTC (rev 104775) @@ -139,6 +139,8 @@ return false; if (element-document()-ignoreAutofocus()) return false; +if (element-document()-isSandboxed(SandboxAutomaticFeatures)) +return false; if (element-hasAutofocused()) return false; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104777] trunk
Title: [104777] trunk
Revision 104777
Author barraclo...@apple.com
Date 2012-01-11 17:30:19 -0800 (Wed, 11 Jan 2012)
Log Message
Object.defineProperty([], 'length', {}) should not make length read-only
https://bugs.webkit.org/show_bug.cgi?id=76097
Reviewed by Oliver Hunt.
Source/_javascript_Core:
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
- We should be checking writablePresent().
LayoutTests:
* fast/js/array-defineOwnProperty-expected.txt:
* fast/js/script-tests/array-defineOwnProperty.js:
- Added test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt
trunk/LayoutTests/fast/js/script-tests/array-defineOwnProperty.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSArray.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (104776 => 104777)
--- trunk/LayoutTests/ChangeLog 2012-01-12 01:29:27 UTC (rev 104776)
+++ trunk/LayoutTests/ChangeLog 2012-01-12 01:30:19 UTC (rev 104777)
@@ -1,3 +1,14 @@
+2012-01-11 Gavin Barraclough barraclo...@apple.com
+
+Object.defineProperty([], 'length', {}) should not make length read-only
+https://bugs.webkit.org/show_bug.cgi?id=76097
+
+Reviewed by Oliver Hunt.
+
+* fast/js/array-defineOwnProperty-expected.txt:
+* fast/js/script-tests/array-defineOwnProperty.js:
+- Added test.
+
2012-01-11 Adam Barth aba...@webkit.org
iframe sandbox doesn't block autofocus (IETC automatic-feature-block-autofocus-form-control)
Modified: trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt (104776 => 104777)
--- trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt 2012-01-12 01:29:27 UTC (rev 104776)
+++ trunk/LayoutTests/fast/js/array-defineOwnProperty-expected.txt 2012-01-12 01:30:19 UTC (rev 104777)
@@ -7,6 +7,7 @@
PASS Object.defineProperty([], 'length', { value: 1 }).length is 1
PASS var a = Object.defineProperty([], 'length', { writable: false }); a[1] = 1; a.length is 0
PASS var a = Object.defineProperty([], 'length', { writable: false }); a.length = 1; a.length is 0
+PASS var a = Object.defineProperty([], 'length', {}); a.length = 1; a.length is 1
PASS Object.defineProperty([], 'length', { get:function(){return true;} }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
PASS Object.defineProperty([], 'length', { enumerable: true }) threw exception TypeError: Attempting to change enumerable attribute of unconfigurable property..
PASS Object.defineProperty([], 'length', { configurable: true }) threw exception TypeError: Attempting to change configurable attribute of unconfigurable property..
Modified: trunk/LayoutTests/fast/js/script-tests/array-defineOwnProperty.js (104776 => 104777)
--- trunk/LayoutTests/fast/js/script-tests/array-defineOwnProperty.js 2012-01-12 01:29:27 UTC (rev 104776)
+++ trunk/LayoutTests/fast/js/script-tests/array-defineOwnProperty.js 2012-01-12 01:30:19 UTC (rev 104777)
@@ -7,6 +7,8 @@
shouldBe(Object.defineProperty([], 'length', { value: 1 }).length, '1');
shouldBe(var a = Object.defineProperty([], 'length', { writable: false }); a[1] = 1; a.length, '0');
shouldBe(var a = Object.defineProperty([], 'length', { writable: false }); a.length = 1; a.length, '0');
+// If writable is not specified, it should not change.
+shouldBe(var a = Object.defineProperty([], 'length', {}); a.length = 1; a.length, '1');
// The length property can be replaced with an accessor, or made either enumerable or configurable.
shouldThrow(Object.defineProperty([], 'length', { get:function(){return true;} }));
Modified: trunk/Source/_javascript_Core/ChangeLog (104776 => 104777)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-12 01:29:27 UTC (rev 104776)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-12 01:30:19 UTC (rev 104777)
@@ -1,3 +1,14 @@
+2012-01-11 Gavin Barraclough barraclo...@apple.com
+
+Object.defineProperty([], 'length', {}) should not make length read-only
+https://bugs.webkit.org/show_bug.cgi?id=76097
+
+Reviewed by Oliver Hunt.
+
+* runtime/JSArray.cpp:
+(JSC::JSArray::defineOwnProperty):
+- We should be checking writablePresent().
+
2012-01-11 Filip Pizlo fpi...@apple.com
Code duplication for invoking the JIT and DFG should be reduced
Modified: trunk/Source/_javascript_Core/runtime/JSArray.cpp (104776 => 104777)
--- trunk/Source/_javascript_Core/runtime/JSArray.cpp 2012-01-12 01:29:27 UTC (rev 104776)
+++ trunk/Source/_javascript_Core/runtime/JSArray.cpp 2012-01-12 01:30:19 UTC (rev 104777)
@@ -531,10 +531,10 @@
if (propertyName == exec-propertyNames().length) {
// All paths through length definition call the default [[DefineOwnProperty]], hence:
// from ES5.1 8.12.9 7.a.
-if (descriptor.configurable())
+if (descriptor.configurablePresent() descriptor.configurable())
[webkit-changes] [104778] trunk/Source/WebCore
Title: [104778] trunk/Source/WebCore
Revision 104778
Author hara...@chromium.org
Date 2012-01-11 17:57:45 -0800 (Wed, 11 Jan 2012)
Log Message
[JSC] Remove redundant arguments from [Supplemental] custom methods
https://bugs.webkit.org/show_bug.cgi?id=76127
Reviewed by Adam Barth.
Since in JSC a callback of custom methods is non-static, we do not need
to pass a pointer of an implementation object.
Before (JSTestInterface.cpp):
JSValue jsTestInterfaceSupplementalStr3(ExecState* exec, JSValue slotBase, ...)
{
JSTestInterface* castedThis = static_castJSTestInterface*(asObject(slotBase));
TestInterface* impl = static_castTestInterface*(castedThis-impl());
return castedThis-supplementalStr3(impl, exec);
}
After (JSTestInterface.cpp):
JSValue jsTestInterfaceSupplementalStr3(ExecState* exec, JSValue slotBase, ...)
{
JSTestInterface* castedThis = static_castJSTestInterface*(asObject(slotBase));
return castedThis-supplementalStr3(exec); // JSTestInterface knows 'impl'.
}
Tests: bindings/scripts/test/TestInterface.idl
http/tests/websocket/tests/*
webaudio/*
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Previously when we specify [CustomGetter, CustomSetter], the header for
the custom setter was not generated. This patch fixes the bug.
(GenerateImplementation):
* bindings/js/JSDOMWindowWebAudioCustom.cpp: Removed redundant DOMWindow* from webkitAudioContext().
(WebCore::JSDOMWindow::webkitAudioContext):
* bindings/js/JSDOMWindowWebSocketCustom.cpp: Removed redundant DOMWindow* from webSocket().
(WebCore::JSDOMWindow::webSocket):
* bindings/scripts/test/JS/JSTestInterface.cpp: Updated the test result.
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalStr3):
* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowWebAudioCustom.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowWebSocketCustom.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104777 => 104778)
--- trunk/Source/WebCore/ChangeLog 2012-01-12 01:30:19 UTC (rev 104777)
+++ trunk/Source/WebCore/ChangeLog 2012-01-12 01:57:45 UTC (rev 104778)
@@ -1,3 +1,47 @@
+2012-01-11 Kentaro Hara hara...@chromium.org
+
+[JSC] Remove redundant arguments from [Supplemental] custom methods
+https://bugs.webkit.org/show_bug.cgi?id=76127
+
+Reviewed by Adam Barth.
+
+Since in JSC a callback of custom methods is non-static, we do not need
+to pass a pointer of an implementation object.
+
+Before (JSTestInterface.cpp):
+JSValue jsTestInterfaceSupplementalStr3(ExecState* exec, JSValue slotBase, ...)
+{
+JSTestInterface* castedThis = static_castJSTestInterface*(asObject(slotBase));
+TestInterface* impl = static_castTestInterface*(castedThis-impl());
+return castedThis-supplementalStr3(impl, exec);
+}
+
+After (JSTestInterface.cpp):
+JSValue jsTestInterfaceSupplementalStr3(ExecState* exec, JSValue slotBase, ...)
+{
+JSTestInterface* castedThis = static_castJSTestInterface*(asObject(slotBase));
+ return castedThis-supplementalStr3(exec); // JSTestInterface knows 'impl'.
+}
+
+Tests: bindings/scripts/test/TestInterface.idl
+ http/tests/websocket/tests/*
+ webaudio/*
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader): Previously when we specify [CustomGetter, CustomSetter], the header for
+the custom setter was not generated. This patch fixes the bug.
+(GenerateImplementation):
+
+* bindings/js/JSDOMWindowWebAudioCustom.cpp: Removed redundant DOMWindow* from webkitAudioContext().
+(WebCore::JSDOMWindow::webkitAudioContext):
+* bindings/js/JSDOMWindowWebSocketCustom.cpp: Removed redundant DOMWindow* from webSocket().
+(WebCore::JSDOMWindow::webSocket):
+
+* bindings/scripts/test/JS/JSTestInterface.cpp: Updated the test result.
+(WebCore::jsTestInterfaceSupplementalStr3):
+(WebCore::setJSTestInterfaceSupplementalStr3):
+* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
+
2012-01-11 Adam Barth aba...@webkit.org
iframe sandbox doesn't block autofocus (IETC automatic-feature-block-autofocus-form-control)
Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowWebAudioCustom.cpp (104777 => 104778)
--- trunk/Source/WebCore/bindings/js/JSDOMWindowWebAudioCustom.cpp 2012-01-12 01:30:19 UTC (rev 104777)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowWebAudioCustom.cpp 2012-01-12 01:57:45 UTC (rev 104778)
@@ -37,7
[webkit-changes] [104780] trunk/Source
Title: [104780] trunk/Source
Revision 104780
Author commit-qu...@webkit.org
Date 2012-01-11 18:26:02 -0800 (Wed, 11 Jan 2012)
Log Message
[chromium] TiledLayerChromium drops invalidates that occur during
LayerTextureUpdater::prepareToUpdate
https://bugs.webkit.org/show_bug.cgi?id=76067
Patch by Scott Violet s...@google.com on 2012-01-11
Reviewed by James Robinson.
Source/WebCore:
Test coverage in TiledLayerChromiumTest.
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
Source/WebKit/chromium:
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(WTF::FakeLayerTextureUpdater::prepareCount):
(WTF::FakeLayerTextureUpdater::clearPrepareCount):
(WTF::FakeLayerTextureUpdater::lastUpdateRect):
(WTF::FakeTiledLayerChromium::fakeLayerTextureUpdater):
(WTF::FakeLayerTextureUpdater::setRectToInvalidate):
(WTF::FakeLayerTextureUpdater::prepareToUpdate):
(WTF::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104779 => 104780)
--- trunk/Source/WebCore/ChangeLog 2012-01-12 02:03:36 UTC (rev 104779)
+++ trunk/Source/WebCore/ChangeLog 2012-01-12 02:26:02 UTC (rev 104780)
@@ -1,3 +1,16 @@
+2012-01-11 Scott Violet s...@google.com
+
+[chromium] TiledLayerChromium drops invalidates that occur during
+LayerTextureUpdater::prepareToUpdate
+https://bugs.webkit.org/show_bug.cgi?id=76067
+
+Reviewed by James Robinson.
+
+Test coverage in TiledLayerChromiumTest.
+
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::prepareToUpdateTiles):
+
2012-01-11 Kentaro Hara hara...@chromium.org
[JSC] Remove redundant arguments from [Supplemental] custom methods
Modified: trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp (104779 => 104780)
--- trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2012-01-12 02:03:36 UTC (rev 104779)
+++ trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2012-01-12 02:26:02 UTC (rev 104780)
@@ -59,7 +59,11 @@
ManagedTexture* managedTexture() { return m_texture-texture(); }
bool isDirty() const { return !m_dirtyRect.isEmpty(); }
-void clearDirty() { m_dirtyRect = IntRect(); }
+void copyAndClearDirty()
+{
+m_updateRect = m_dirtyRect;
+m_dirtyRect = IntRect();
+}
IntRect m_dirtyRect;
IntRect m_updateRect;
@@ -366,7 +370,9 @@
}
// Create tiles as needed, expanding a dirty rect to contain all
-// the dirty regions currently being drawn.
+// the dirty regions currently being drawn. All dirty tiles that are to be painted
+// get their m_updateRect set to m_dirtyRect and m_dirtyRect cleared. This way if
+// invalidateRect is invoked during prepareToUpdate we don't lose the request.
IntRect dirtyLayerRect;
for (int j = top; j = bottom; ++j) {
for (int i = left; i = right; ++i) {
@@ -387,6 +393,7 @@
}
dirtyLayerRect.unite(tile-m_dirtyRect);
+tile-copyAndClearDirty();
}
}
@@ -414,19 +421,17 @@
if (!tile)
CRASH();
-if (!tile-isDirty())
+// Use m_updateRect as copyAndClearDirty above moved the existing dirty rect to m_updateRect.
+const IntRect dirtyRect = tile-m_updateRect;
+if (dirtyRect.isEmpty())
continue;
IntRect sourceRect = m_tiler-tileRect(tile);
-sourceRect.intersect(tile-m_dirtyRect);
+sourceRect.intersect(dirtyRect);
// Paint rect not guaranteed to line up on tile boundaries, so
// make sure that sourceRect doesn't extend outside of it.
sourceRect.intersect(m_paintRect);
-// updateCompositorResources() uses m_updateRect to determine
-// the tiles to update so we can clear the dirty rectangle here.
-tile-clearDirty();
-
tile-m_updateRect = sourceRect;
if (sourceRect.isEmpty())
continue;
Modified: trunk/Source/WebKit/chromium/ChangeLog (104779 => 104780)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-12 02:03:36 UTC (rev 104779)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-12 02:26:02 UTC (rev 104780)
@@ -1,3 +1,21 @@
+2012-01-11 Scott Violet s...@google.com
+
+[chromium] TiledLayerChromium drops invalidates that occur during
+LayerTextureUpdater::prepareToUpdate
+https://bugs.webkit.org/show_bug.cgi?id=76067
+
+Reviewed by James Robinson.
+
+* tests/TiledLayerChromiumTest.cpp:
+(WTF::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
+
[webkit-changes] [104781] trunk/LayoutTests
Title: [104781] trunk/LayoutTests
Revision 104781
Author dim...@chromium.org
Date 2012-01-11 18:30:39 -0800 (Wed, 11 Jan 2012)
Log Message
[Chromium] Rebaseline test images for input controls
after http://src.chromium.org/viewvc/chrome?view=revrevision=117217
https://bugs.webkit.org/show_bug.cgi?id=76134
Unreviewed.
* platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
* platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
* platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
* platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (104780 => 104781)
--- trunk/LayoutTests/ChangeLog 2012-01-12 02:26:02 UTC (rev 104780)
+++ trunk/LayoutTests/ChangeLog 2012-01-12 02:30:39 UTC (rev 104781)
@@ -1,3 +1,23 @@
+2012-01-11 Dmitry Titov dim...@chromium.org
+
+[Chromium] Rebaseline test images for input controls
+after http://src.chromium.org/viewvc/chrome?view=revrevision=117217
+https://bugs.webkit.org/show_bug.cgi?id=76134
+
+Unreviewed.
+
+* platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
+* platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
+* platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
+* platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
+* platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
+* platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.png:
+* platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png:
+* platform/chromium-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png:
+* platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png:
+* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
+* platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
+
2012-01-11 Gavin Barraclough barraclo...@apple.com
Object.defineProperty([], 'length', {}) should not make length read-only
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png
(Binary files differ)
Modified:
[webkit-changes] [104782] trunk
Title: [104782] trunk
Revision 104782
Author e...@google.com
Date 2012-01-11 19:46:47 -0800 (Wed, 11 Jan 2012)
Log Message
Repaint all graphics layers when their renderer offset changes
https://bugs.webkit.org/show_bug.cgi?id=75730
Reviewed by Simon Fraser.
Source/WebCore:
In RenderLayerBacking, only the main graphics layer gets repainted
when the offset changes. If the offset on other graphics layers (e.g.
the foreground layer) changes, they should get repainted as well.
Test: compositing/geometry/foreground-offset-change.html
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::setOffsetFromRenderer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
* platform/graphics/GraphicsLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintContents):
LayoutTests:
* compositing/geometry/foreground-offset-change-expected.png: Added.
* compositing/geometry/foreground-offset-change-expected.txt: Added.
* compositing/geometry/foreground-offset-change.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Added Paths
trunk/LayoutTests/compositing/geometry/foreground-offset-change-expected.png
trunk/LayoutTests/compositing/geometry/foreground-offset-change-expected.txt
trunk/LayoutTests/compositing/geometry/foreground-offset-change.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104781 => 104782)
--- trunk/LayoutTests/ChangeLog 2012-01-12 02:30:39 UTC (rev 104781)
+++ trunk/LayoutTests/ChangeLog 2012-01-12 03:46:47 UTC (rev 104782)
@@ -1,3 +1,14 @@
+2012-01-11 Adrienne Walker e...@google.com
+
+Repaint all graphics layers when their renderer offset changes
+https://bugs.webkit.org/show_bug.cgi?id=75730
+
+Reviewed by Simon Fraser.
+
+* compositing/geometry/foreground-offset-change-expected.png: Added.
+* compositing/geometry/foreground-offset-change-expected.txt: Added.
+* compositing/geometry/foreground-offset-change.html: Added.
+
2012-01-11 Dmitry Titov dim...@chromium.org
[Chromium] Rebaseline test images for input controls
Added: trunk/LayoutTests/compositing/geometry/foreground-offset-change-expected.png (0 => 104782)
--- trunk/LayoutTests/compositing/geometry/foreground-offset-change-expected.png (rev 0)
+++ trunk/LayoutTests/compositing/geometry/foreground-offset-change-expected.png 2012-01-12 03:46:47 UTC (rev 104782)
@@ -0,0 +1,7 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum 919c4609446010053b38c67636334c9a\xAE\x92v\xA1
+\xD1IDATx\x9C\xEDٱ
+\x840As\xBA\xBE\xA0t\xA8\xCCW\xD9
+K\xC7L\xEA䅫\xEFm\xCE9 \xE8|V \xF87 \xB0 b \xB0 b \xB0 b \xF6\xBD{\xB8\xAE\xEB\xC9 \xBC־\xEF\xAB'@\xEC6\xB0\xC6\xC7y5\x80\x97:\x8Fs\xF5\xE8\xF9 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88
[webkit-changes] [104783] trunk/LayoutTests
Title: [104783] trunk/LayoutTests
Revision 104783
Author mikelawt...@chromium.org
Date 2012-01-11 19:53:00 -0800 (Wed, 11 Jan 2012)
Log Message
margin test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76000
Reviewed by Daniel Bates.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
* css3/calc/margin-expected.txt: Added.
* css3/calc/margin.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/css3/calc/margin-expected.txt
trunk/LayoutTests/css3/calc/margin.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104782 => 104783)
--- trunk/LayoutTests/ChangeLog 2012-01-12 03:46:47 UTC (rev 104782)
+++ trunk/LayoutTests/ChangeLog 2012-01-12 03:53:00 UTC (rev 104783)
@@ -1,3 +1,18 @@
+2012-01-11 Mike Lawther mikelawt...@chromium.org
+
+margin test for CSS3 calc
+https://bugs.webkit.org/show_bug.cgi?id=76000
+
+Reviewed by Daniel Bates.
+
+Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
+
+These tests are expected to 'fail', and will pass once calc() functionality is landed.
+For now, they serve to demonstrate that the current code doesn't crash on these tests.
+
+* css3/calc/margin-expected.txt: Added.
+* css3/calc/margin.html: Added.
+
2012-01-11 Adrienne Walker e...@google.com
Repaint all graphics layers when their renderer offset changes
Added: trunk/LayoutTests/css3/calc/margin-expected.txt (0 => 104783)
--- trunk/LayoutTests/css3/calc/margin-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/calc/margin-expected.txt 2012-01-12 03:53:00 UTC (rev 104783)
@@ -0,0 +1,24 @@
+FAIL document.getElementById(simple-all).parentNode.offsetWidth should be 250. Was 200.
+FAIL document.getElementById(simple-all).parentNode.offsetHeight should be 170. Was 120.
+FAIL document.getElementById(simple-left).parentNode.offsetWidth should be 225. Was 200.
+PASS document.getElementById(simple-left).parentNode.offsetHeight is 120
+FAIL document.getElementById(simple-right).parentNode.offsetWidth should be 225. Was 200.
+PASS document.getElementById(simple-right).parentNode.offsetHeight is 120
+PASS document.getElementById(simple-top).parentNode.offsetWidth is 200
+FAIL document.getElementById(simple-top).parentNode.offsetHeight should be 145. Was 120.
+PASS document.getElementById(simple-bottom).parentNode.offsetWidth is 200
+FAIL document.getElementById(simple-bottom).parentNode.offsetHeight should be 145. Was 120.
+FAIL document.getElementById(percent-all).parentNode.offsetWidth should be 250. Was 200.
+FAIL document.getElementById(percent-all).parentNode.offsetHeight should be 170. Was 120.
+FAIL document.getElementById(percent-left).parentNode.offsetWidth should be 225. Was 200.
+PASS document.getElementById(percent-left).parentNode.offsetHeight is 120
+FAIL document.getElementById(percent-right).parentNode.offsetWidth should be 225. Was 200.
+PASS document.getElementById(percent-right).parentNode.offsetHeight is 120
+PASS document.getElementById(percent-top).parentNode.offsetWidth is 200
+FAIL document.getElementById(percent-top).parentNode.offsetHeight should be 145. Was 120.
+PASS document.getElementById(percent-bottom).parentNode.offsetWidth is 200
+FAIL document.getElementById(percent-bottom).parentNode.offsetHeight should be 145. Was 120.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/css3/calc/margin.html (0 => 104783)
--- trunk/LayoutTests/css3/calc/margin.html (rev 0)
+++ trunk/LayoutTests/css3/calc/margin.html 2012-01-12 03:53:00 UTC (rev 104783)
@@ -0,0 +1,86 @@
+!DOCTYPE HTML
+script src=""
+style
+div { display: inline-block; }
+p { width: 200px; height: 120px; margin: 0px; }
+#simple-all { margin: -webkit-calc(13px + 12px); }
+#simple-left { margin-left: -webkit-calc(13px + 12px); }
+#simple-right { margin-right: -webkit-calc(13px + 12px); }
+#simple-top { margin-top: -webkit-calc(13px + 12px); }
+#simple-bottom { margin-bottom: -webkit-calc(13px + 12px); }
+#percent-all { margin: -webkit-calc(10% - 5px); }
+#percent-left { margin-left: -webkit-calc(10% - 5px); }
+#percent-right { margin-right: -webkit-calc(10% - 5px); }
+#percent-top { margin-top: -webkit-calc(10% - 5px); }
+#percent-bottom { margin-bottom: -webkit-calc(10% - 5px); }
+/style
+
+div id=test-container
+divp id=simple-allThis element should have an overall margin of 25 pixels./p/divbr/
+divp id=simple-leftThis element should have a left margin of 25 pixels./p/divbr/
+divp id=simple-rightThis element should have a right margin of 25 pixels./p/divbr/
+divp id=simple-topThis element should have a top margin of 25 pixels./p/divbr/
+divp
[webkit-changes] [104784] trunk/Source/JavaScriptCore
Title: [104784] trunk/Source/_javascript_Core
Revision 104784
Author barraclo...@apple.com
Date 2012-01-11 19:53:22 -0800 (Wed, 11 Jan 2012)
Log Message
Merge 'Getter'/'Setter' attributes into 'Accessor'
https://bugs.webkit.org/show_bug.cgi?id=76141
Reviewed by Filip Pizlo.
These are currently ambiguous (and used inconsistently). It would logically appear
that either being bit set implies that the corresponding type of accessor is present
but (a) we don't correctly enforce this, and (b) this means the attributes would not
be able to distinguish between a data descriptor and an accessor descriptor with
neither a getter nor setter defined (which is a descriptor permissible under the spec).
This ambiguity would lead to unsafe property caching behavior (though this does not
represent an actual current bug, since we are currently unable to create descriptors
that have neither a getter nor setter, it just prevents us from doing so).
* runtime/Arguments.cpp:
(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):
* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::put):
(JSC::JSArray::putDescriptor):
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::finishCreation):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::JSObject::initializeGetterSetterProperty):
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorDefineProperty):
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):
(JSC::PropertyDescriptor::setSetter):
(JSC::PropertyDescriptor::setGetter):
(JSC::PropertyDescriptor::attributesOverridingCurrent):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Arguments.cpp
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/_javascript_Core/runtime/JSBoundFunction.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/ObjectConstructor.cpp
trunk/Source/_javascript_Core/runtime/PropertyDescriptor.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (104783 => 104784)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-12 03:53:00 UTC (rev 104783)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-12 03:53:22 UTC (rev 104784)
@@ -1,5 +1,48 @@
2012-01-11 Gavin Barraclough barraclo...@apple.com
+Merge 'Getter'/'Setter' attributes into 'Accessor'
+https://bugs.webkit.org/show_bug.cgi?id=76141
+
+Reviewed by Filip Pizlo.
+
+These are currently ambiguous (and used inconsistently). It would logically appear
+that either being bit set implies that the corresponding type of accessor is present
+but (a) we don't correctly enforce this, and (b) this means the attributes would not
+be able to distinguish between a data descriptor and an accessor descriptor with
+neither a getter nor setter defined (which is a descriptor permissible under the spec).
+This ambiguity would lead to unsafe property caching behavior (though this does not
+represent an actual current bug, since we are currently unable to create descriptors
+that have neither a getter nor setter, it just prevents us from doing so).
+
+* runtime/Arguments.cpp:
+(JSC::Arguments::createStrictModeCallerIfNecessary):
+(JSC::Arguments::createStrictModeCalleeIfNecessary):
+* runtime/JSArray.cpp:
+(JSC::SparseArrayValueMap::put):
+(JSC::JSArray::putDescriptor):
+* runtime/JSBoundFunction.cpp:
+(JSC::JSBoundFunction::finishCreation):
+* runtime/JSFunction.cpp:
+(JSC::JSFunction::getOwnPropertySlot):
+(JSC::JSFunction::getOwnPropertyDescriptor):
+* runtime/JSObject.cpp:
+(JSC::JSObject::defineGetter):
+(JSC::JSObject::initializeGetterSetterProperty):
+(JSC::JSObject::defineSetter):
+(JSC::putDescriptor):
+(JSC::JSObject::defineOwnProperty):
+* runtime/JSObject.h:
+* runtime/ObjectConstructor.cpp:
+(JSC::objectConstructorDefineProperty):
+* runtime/PropertyDescriptor.cpp:
+(JSC::PropertyDescriptor::setDescriptor):
+(JSC::PropertyDescriptor::setAccessorDescriptor):
+(JSC::PropertyDescriptor::setSetter):
+(JSC::PropertyDescriptor::setGetter):
+(JSC::PropertyDescriptor::attributesOverridingCurrent):
+
+2012-01-11 Gavin Barraclough barraclo...@apple.com
+
Object.defineProperty([], 'length', {}) should not make length read-only
https://bugs.webkit.org/show_bug.cgi?id=76097
Modified:
[webkit-changes] [104785] trunk/LayoutTests
Title: [104785] trunk/LayoutTests
Revision 104785
Author t...@chromium.org
Date 2012-01-11 19:55:38 -0800 (Wed, 11 Jan 2012)
Log Message
Overflow on flexitems doesn't work
https://bugs.webkit.org/show_bug.cgi?id=70979
Reviewed by Ojan Vafai.
Add test cases for flex items that overflow. There should be
non-disabled scrollbars.
* css3/flexbox/child-overflow-expected.html: Added.
* css3/flexbox/child-overflow.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/css3/flexbox/child-overflow-expected.html
trunk/LayoutTests/css3/flexbox/child-overflow.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104784 => 104785)
--- trunk/LayoutTests/ChangeLog 2012-01-12 03:53:22 UTC (rev 104784)
+++ trunk/LayoutTests/ChangeLog 2012-01-12 03:55:38 UTC (rev 104785)
@@ -1,3 +1,16 @@
+2012-01-11 Tony Chang t...@chromium.org
+
+Overflow on flexitems doesn't work
+https://bugs.webkit.org/show_bug.cgi?id=70979
+
+Reviewed by Ojan Vafai.
+
+Add test cases for flex items that overflow. There should be
+non-disabled scrollbars.
+
+* css3/flexbox/child-overflow-expected.html: Added.
+* css3/flexbox/child-overflow.html: Added.
+
2012-01-11 Mike Lawther mikelawt...@chromium.org
margin test for CSS3 calc
Added: trunk/LayoutTests/css3/flexbox/child-overflow-expected.html (0 => 104785)
--- trunk/LayoutTests/css3/flexbox/child-overflow-expected.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/child-overflow-expected.html 2012-01-12 03:55:38 UTC (rev 104785)
@@ -0,0 +1,51 @@
+!DOCTYPE html
+html
+head
+style
+.container {
+display: inline-block;
+margin-right: 5px;
+}
+
+.container div {
+border: 5px solid pink;
+overflow: auto;
+height: 100px;
+width: 100px;
+}
+
+.container div div {
+width: 120px;
+height: 120px;
+background: -webkit-radial-gradient(center, ellipse cover, rgba(30,87,153,1) 0%,rgba(89,148,202,1) 62%,rgba(95,154,207,0.7) 68%,rgba(125,185,232,0) 100%);
+}
+/style
+/head
+body
+pScrollbars should work in all the flexboxes and each row should show four identical boxes./p
+/body
+script
+var origins = ['', 'bottomLeft', 'topRight', ''];
+
+origins.forEach(function(origin) {
+for (var i = 0; i 4; ++i) {
+var containerClass = 'container ' + origin;
+document.body.innerHTML +=
+div class=' + containerClass + ' +
+divdiv/div/div +
+/div;
+}
+document.body.innerHTML += br;
+});
+
+Array.prototype.forEach.call(document.querySelectorAll('.bottomLeft'), function(element) {
+element.firstChild.scrollTop = 1000;
+});
+
+Array.prototype.forEach.call(document.querySelectorAll('.topRight'), function(element) {
+element.firstChild.scrollLeft = 1000;
+});
+
+/script
+/body
+/html
Added: trunk/LayoutTests/css3/flexbox/child-overflow.html (0 => 104785)
--- trunk/LayoutTests/css3/flexbox/child-overflow.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/child-overflow.html 2012-01-12 03:55:38 UTC (rev 104785)
@@ -0,0 +1,82 @@
+!DOCTYPE html
+html
+head
+style
+.container {
+display: inline-block;
+margin-right: 5px;
+}
+
+.horizontal-tb {
+-webkit-writing-mode: horizontal-tb;
+}
+
+.horizontal-bt {
+-webkit-writing-mode: horizontal-bt;
+}
+
+.vertical-rl {
+-webkit-writing-mode: vertical-rl;
+}
+
+.vertical-lr {
+-webkit-writing-mode: vertical-lr;
+}
+
+.row {
+-webkit-flex-direction: row;
+}
+
+.row-reverse {
+-webkit-flex-direction: row-reverse;
+}
+
+.column {
+-webkit-flex-direction: column;
+}
+
+.column-reverse {
+-webkit-flex-direction: column-reverse;
+}
+
+.flexbox {
+border: 5px solid pink;
+display: -webkit-flexbox;
+height: 100px;
+width: 100px;
+}
+
+.flexbox div {
+overflow: auto;
+}
+
+.flexbox div div {
+width: 120px;
+height: 120px;
+background: -webkit-radial-gradient(center, ellipse cover, rgba(30,87,153,1) 0%,rgba(89,148,202,1) 62%,rgba(95,154,207,0.7) 68%,rgba(125,185,232,0) 100%);
+}
+/style
+/head
+body
+pScrollbars should work in all the flexboxes and each row should show four identical boxes./p
+/body
+script
+var writingModes = ['horizontal-tb', 'horizontal-bt', 'vertical-rl', 'vertical-lr'];
+var flexDirections = ['row', 'column', 'row-reverse', 'column-reverse'];
+writingModes.forEach(function(writingMode) {
+flexDirections.forEach(function(flexDirection) {
+var containerClass = 'container ' + writingMode;
+var flexboxClass = 'flexbox ' + flexDirection;
+document.body.innerHTML +=
+div class=' + containerClass + ' +
+div class=' + flexboxClass + ' +
+div style='width: -webkit-flex(0 1 auto); height: -webkit-flex(0 1 auto)'div/div/div +
+/div +
+/div;
+});
+document.body.innerHTML += br;
+});
+
+/script
+/body
+/html
[webkit-changes] [104787] trunk/Source/JavaScriptCore
Title: [104787] trunk/Source/_javascript_Core
Revision 104787
Author fpi...@apple.com
Date 2012-01-11 20:33:10 -0800 (Wed, 11 Jan 2012)
Log Message
CodeBlock::m_executeCounter should be renamed to CodeBlock::m_jitExecuteCounter
https://bugs.webkit.org/show_bug.cgi?id=76144
rdar://problem/10681711
Rubber stamped by Gavin Barraclough.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addressOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecuteCounter):
(JSC::CodeBlock::jitExecuteCounter):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (104786 => 104787)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-12 04:10:01 UTC (rev 104786)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-12 04:33:10 UTC (rev 104787)
@@ -1,3 +1,27 @@
+2012-01-11 Filip Pizlo fpi...@apple.com
+
+CodeBlock::m_executeCounter should be renamed to CodeBlock::m_jitExecuteCounter
+https://bugs.webkit.org/show_bug.cgi?id=76144
+rdar://problem/10681711
+
+Rubber stamped by Gavin Barraclough.
+
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::addressOfJITExecuteCounter):
+(JSC::CodeBlock::offsetOfJITExecuteCounter):
+(JSC::CodeBlock::jitExecuteCounter):
+(JSC::CodeBlock::optimizeNextInvocation):
+(JSC::CodeBlock::dontOptimizeAnytimeSoon):
+(JSC::CodeBlock::optimizeAfterWarmUp):
+(JSC::CodeBlock::optimizeAfterLongWarmUp):
+(JSC::CodeBlock::optimizeSoon):
+* dfg/DFGOSRExitCompiler32_64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* dfg/DFGOSRExitCompiler64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* jit/JIT.cpp:
+(JSC::JIT::emitOptimizationCheck):
+
2012-01-11 Gavin Barraclough barraclo...@apple.com
Merge 'Getter'/'Setter' attributes into 'Accessor'
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (104786 => 104787)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2012-01-12 04:10:01 UTC (rev 104786)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2012-01-12 04:33:10 UTC (rev 104787)
@@ -780,7 +780,7 @@
// Functions for controlling when tiered compilation kicks in. This
// controls both when the optimizing compiler is invoked and when OSR
// entry happens. Two triggers exist: the loop trigger and the return
-// trigger. In either case, when an addition to m_executeCounter
+// trigger. In either case, when an addition to m_jitExecuteCounter
// causes it to become non-negative, the optimizing compiler is
// invoked. This includes a fast check to see if this CodeBlock has
// already been optimized (i.e. replacement() returns a CodeBlock
@@ -821,14 +821,14 @@
return Options::executionCounterValueForOptimizeAfterLongWarmUp reoptimizationRetryCounter();
}
-int32_t* addressOfExecuteCounter()
+int32_t* addressOfJITExecuteCounter()
{
-return m_executeCounter;
+return m_jitExecuteCounter;
}
-static ptrdiff_t offsetOfExecuteCounter() { return OBJECT_OFFSETOF(CodeBlock, m_executeCounter); }
+static ptrdiff_t offsetOfJITExecuteCounter() { return OBJECT_OFFSETOF(CodeBlock, m_jitExecuteCounter); }
-int32_t executeCounter() const { return m_executeCounter; }
+int32_t jitExecuteCounter() const { return m_jitExecuteCounter; }
unsigned optimizationDelayCounter() const { return m_optimizationDelayCounter; }
@@ -837,7 +837,7 @@
// expensive than executing baseline code.
void optimizeNextInvocation()
{
-m_executeCounter = Options::executionCounterValueForOptimizeNextInvocation;
+m_jitExecuteCounter = Options::executionCounterValueForOptimizeNextInvocation;
}
// Call this to prevent optimization from happening again. Note that
@@ -847,7 +847,7 @@
// the future as well.
void dontOptimizeAnytimeSoon()
{
-m_executeCounter = Options::executionCounterValueForDontOptimizeAnytimeSoon;
+m_jitExecuteCounter = Options::executionCounterValueForDontOptimizeAnytimeSoon;
}
// Call this to reinitialize the counter to
[webkit-changes] [104788] tags/Safari-535.16/
Title: [104788] tags/Safari-535.16/ Revision 104788 Author lforsch...@apple.com Date 2012-01-11 21:42:23 -0800 (Wed, 11 Jan 2012) Log Message New Tag. Added Paths tags/Safari-535.16/ Diff Property changes: tags/Safari-535.16 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104789] trunk/Source
Title: [104789] trunk/Source Revision 104789 Author lforsch...@apple.com Date 2012-01-11 21:52:38 -0800 (Wed, 11 Jan 2012) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/_javascript_Glue/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (104788 => 104789) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-01-12 05:42:23 UTC (rev 104788) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-01-12 05:52:38 UTC (rev 104789) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 16; +MINOR_VERSION = 17; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/_javascript_Glue/Configurations/Version.xcconfig (104788 => 104789) --- trunk/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-01-12 05:42:23 UTC (rev 104788) +++ trunk/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-01-12 05:52:38 UTC (rev 104789) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 16; +MINOR_VERSION = 17; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (104788 => 104789) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2012-01-12 05:42:23 UTC (rev 104788) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2012-01-12 05:52:38 UTC (rev 104789) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 16; +MINOR_VERSION = 17; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (104788 => 104789) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-01-12 05:42:23 UTC (rev 104788) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-01-12 05:52:38 UTC (rev 104789) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 16; +MINOR_VERSION = 17; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (104788 => 104789) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-01-12 05:42:23 UTC (rev 104788) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-01-12 05:52:38 UTC (rev 104789) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 16; +MINOR_VERSION = 17; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104790] trunk/LayoutTests
Title: [104790] trunk/LayoutTests
Revision 104790
Author dim...@chromium.org
Date 2012-01-11 22:38:32 -0800 (Wed, 11 Jan 2012)
Log Message
[Chromium] Baseline for new test added in http://trac.webkit.org/changeset/104786
Unreviewed.
* platform/chromium/fast/css/parsing-font-variant-ligatures-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium/fast/css/parsing-font-variant-ligatures-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (104789 => 104790)
--- trunk/LayoutTests/ChangeLog 2012-01-12 05:52:38 UTC (rev 104789)
+++ trunk/LayoutTests/ChangeLog 2012-01-12 06:38:32 UTC (rev 104790)
@@ -1,3 +1,11 @@
+2012-01-11 Dmitry Titov dim...@chromium.org
+
+[Chromium] Baseline for new test added in http://trac.webkit.org/changeset/104786
+
+Unreviewed.
+
+* platform/chromium/fast/css/parsing-font-variant-ligatures-expected.txt: Added.
+
2012-01-11 Dan Bernstein m...@apple.com
rdar://problem/10679035 Implement font-variant-ligatures: {no-}common-ligatures
Added: trunk/LayoutTests/platform/chromium/fast/css/parsing-font-variant-ligatures-expected.txt (0 => 104790)
--- trunk/LayoutTests/platform/chromium/fast/css/parsing-font-variant-ligatures-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/css/parsing-font-variant-ligatures-expected.txt 2012-01-12 06:38:32 UTC (rev 104790)
@@ -0,0 +1,20 @@
+PASS: 'initial' parsed as 'initial' and computed to 'normal'
+PASS: 'inherit' parsed as 'inherit' and computed to 'normal'
+PASS: 'normal' parsed as 'normal' and computed to 'normal'
+PASS: 'large' parsed as '' and computed to 'normal'
+PASS: '25px' parsed as '' and computed to 'normal'
+PASS: 'normal normal' parsed as '' and computed to 'normal'
+PASS: 'normal no-common-ligatures' parsed as '' and computed to 'normal'
+
+PASS: 'no-common-ligatures' parsed as 'no-common-ligatures' and computed to 'no-common-ligatures'
+PASS: 'common-ligatures' parsed as 'common-ligatures' and computed to 'common-ligatures'
+PASS: 'no-discretionary-ligatures' parsed as 'no-discretionary-ligatures' and computed to 'no-discretionary-ligatures'
+PASS: 'discretionary-ligatures' parsed as 'discretionary-ligatures' and computed to 'discretionary-ligatures'
+PASS: 'no-historical-ligatures' parsed as 'no-historical-ligatures' and computed to 'no-historical-ligatures'
+PASS: 'historical-ligatures' parsed as 'historical-ligatures' and computed to 'historical-ligatures'
+
+PASS: 'no-common-ligatures no-common-ligatures' parsed as '' and computed to 'normal'
+PASS: 'common-ligatures no-discretionary-ligatures' parsed as 'common-ligatures no-discretionary-ligatures' and computed to 'common-ligatures no-discretionary-ligatures'
+PASS: 'common-ligatures no-discretionary-ligatures historical-ligatures' parsed as 'common-ligatures no-discretionary-ligatures historical-ligatures' and computed to 'common-ligatures no-discretionary-ligatures historical-ligatures'
+PASS: 'common-ligatures no-discretionary-ligatures normal' parsed as '' and computed to 'normal'
+
Property changes on: trunk/LayoutTests/platform/chromium/fast/css/parsing-font-variant-ligatures-expected.txt
___
Added: svn:eol-style
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104791] trunk/Source/WebKit/chromium
Title: [104791] trunk/Source/WebKit/chromium
Revision 104791
Author commit-qu...@webkit.org
Date 2012-01-11 22:47:47 -0800 (Wed, 11 Jan 2012)
Log Message
Add WebArrayBuffer support in WebSocket to WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=75080
Patch by Takashi Toyoshima toyos...@chromium.org on 2012-01-11
Reviewed by Darin Fisher.
* public/WebSocket.h: Add interface to send WebArrayBuffer, and set and get receiving binary object type.
* public/WebSocketClient.h: Add interface to receive WebArrayBuffer.
(WebKit::WebSocketClient::didReceiveArrayBuffer):
* src/WebSocketImpl.cpp: Add various binary types handling.
(WebKit::WebSocketImpl::WebSocketImpl):
(WebKit::WebSocketImpl::binaryType):
(WebKit::WebSocketImpl::setBinaryType):
(WebKit::WebSocketImpl::sendArrayBuffer):
(WebKit::WebSocketImpl::didReceiveBinaryData):
* src/WebSocketImpl.h: Add methods to handle various binary types.
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSocket.h
trunk/Source/WebKit/chromium/public/WebSocketClient.h
trunk/Source/WebKit/chromium/src/WebSocketImpl.cpp
trunk/Source/WebKit/chromium/src/WebSocketImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (104790 => 104791)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-12 06:38:32 UTC (rev 104790)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-12 06:47:47 UTC (rev 104791)
@@ -1,3 +1,21 @@
+2012-01-11 Takashi Toyoshima toyos...@chromium.org
+
+Add WebArrayBuffer support in WebSocket to WebKit API.
+https://bugs.webkit.org/show_bug.cgi?id=75080
+
+Reviewed by Darin Fisher.
+
+* public/WebSocket.h: Add interface to send WebArrayBuffer, and set and get receiving binary object type.
+* public/WebSocketClient.h: Add interface to receive WebArrayBuffer.
+(WebKit::WebSocketClient::didReceiveArrayBuffer):
+* src/WebSocketImpl.cpp: Add various binary types handling.
+(WebKit::WebSocketImpl::WebSocketImpl):
+(WebKit::WebSocketImpl::binaryType):
+(WebKit::WebSocketImpl::setBinaryType):
+(WebKit::WebSocketImpl::sendArrayBuffer):
+(WebKit::WebSocketImpl::didReceiveBinaryData):
+* src/WebSocketImpl.h: Add methods to handle various binary types.
+
2012-01-11 Scott Violet s...@google.com
[chromium] TiledLayerChromium drops invalidates that occur during
Modified: trunk/Source/WebKit/chromium/public/WebSocket.h (104790 => 104791)
--- trunk/Source/WebKit/chromium/public/WebSocket.h 2012-01-12 06:38:32 UTC (rev 104790)
+++ trunk/Source/WebKit/chromium/public/WebSocket.h 2012-01-12 06:47:47 UTC (rev 104791)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
+ * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -38,6 +38,7 @@
namespace WebKit {
+class WebArrayBuffer;
class WebData;
class WebDocument;
class WebString;
@@ -60,13 +61,31 @@
CloseEventCodeMaximumUserDefined = 4999
};
+// FIXME: Remove BinaryTypeData after a switchover to other types.
+enum BinaryType {
+BinaryTypeBlob = 0,
+BinaryTypeArrayBuffer = 1,
+BinaryTypeData = 2 // Don't use it
+};
+
WEBKIT_EXPORT static WebSocket* create(const WebDocument, WebSocketClient*);
virtual ~WebSocket() { }
+// These functions come from binaryType attribute of the WebSocket API
+// specification. It specifies binary object type for receiving binary
+// frames representation. Receiving text frames are always mapped to
+// WebString type regardless of this attribute.
+// Default type must be BinaryTypeBlob, but currently is BinaryTypeData
+// for a switchover from WebData to WebArrayBuffer.
+// See also, The WebSocket API - http://www.w3.org/TR/websockets/ .
+virtual BinaryType binaryType() const = 0;
+virtual bool setBinaryType(BinaryType) = 0;
+
virtual void connect(const WebURL, const WebString protocol) = 0;
virtual WebString subprotocol() = 0;
-virtual bool sendText(const WebString message) = 0;
-virtual bool sendBinary(const WebData binaryData) = 0;
+virtual bool sendText(const WebString) = 0;
+virtual bool sendBinary(const WebData) = 0;
+virtual bool sendArrayBuffer(const WebArrayBuffer) = 0;
virtual unsigned long bufferedAmount() const = 0;
virtual void close(int code, const WebString reason) = 0;
virtual void fail(const WebString reason) = 0;
Modified: trunk/Source/WebKit/chromium/public/WebSocketClient.h (104790 => 104791)
--- trunk/Source/WebKit/chromium/public/WebSocketClient.h 2012-01-12 06:38:32 UTC (rev 104790)
+++ trunk/Source/WebKit/chromium/public/WebSocketClient.h 2012-01-12 06:47:47 UTC (rev 104791)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
+ * Copyright
