date:20120127

[webkit-changes] [106098] trunk

2012-01-27 Thread commit-queue

Title: [106098] trunk








Revision 106098
Author commit-qu...@webkit.org
Date 2012-01-27 00:03:54 -0800 (Fri, 27 Jan 2012)


Log Message
[EFL] SVG_FONT is not disabled when SVG is disabled.
https://bugs.webkit.org/show_bug.cgi?id=77174

Patch by ChangSeok Oh shivami...@gmail.com on 2012-01-27
Reviewed by Eric Seidel.

SVG_FONTS should be disabled when SVG is disabled. Or else it causes build-break.
Relocated checking ENABLE_GLIB_SUPPORT  ENABLE_VIDEO to avoid duplication.

* Source/cmake/OptionsEfl.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsEfl.cmake




Diff

Modified: trunk/ChangeLog (106097 => 106098)

--- trunk/ChangeLog	2012-01-27 07:52:38 UTC (rev 106097)
+++ trunk/ChangeLog	2012-01-27 08:03:54 UTC (rev 106098)
@@ -1,3 +1,15 @@
+2012-01-27  ChangSeok Oh  shivami...@gmail.com
+
+[EFL] SVG_FONT is not disabled when SVG is disabled.
+https://bugs.webkit.org/show_bug.cgi?id=77174
+
+Reviewed by Eric Seidel.
+
+SVG_FONTS should be disabled when SVG is disabled. Or else it causes build-break.
+Relocated checking ENABLE_GLIB_SUPPORT  ENABLE_VIDEO to avoid duplication.
+
+* Source/cmake/OptionsEfl.cmake:
+
 2012-01-26  Kevin Ollivier  kev...@theolliviers.com
 
 [wx] Unreviewed. Build fix, don't build some sources


Modified: trunk/Source/cmake/OptionsEfl.cmake (106097 => 106098)

--- trunk/Source/cmake/OptionsEfl.cmake	2012-01-27 07:52:38 UTC (rev 106097)
+++ trunk/Source/cmake/OptionsEfl.cmake	2012-01-27 08:03:54 UTC (rev 106098)
@@ -139,17 +139,14 @@
   ENDIF ()
 ENDIF ()
 
+IF (NOT ENABLE_SVG)
+  SET(ENABLE_SVG_FONTS 0)
+ENDIF ()
+
 IF (ENABLE_VIDEO)
   SET(ENABLE_GLIB_SUPPORT 1)
   MESSAGE(Forcing Glib support)
-ENDIF()
 
-IF (ENABLE_GLIB_SUPPORT)
-  FIND_PACKAGE(Glib REQUIRED)
-  FIND_PACKAGE(Gthread REQUIRED)
-ENDIF ()
-
-IF (ENABLE_VIDEO)
   FIND_PACKAGE(GStreamer REQUIRED)
   FIND_PACKAGE(GStreamer-App REQUIRED)
   FIND_PACKAGE(GStreamer-Base REQUIRED)
@@ -161,6 +158,11 @@
   ADD_DEFINITIONS(-DWTF_USE_GSTREAMER=1)
 ENDIF()
 
+IF (ENABLE_GLIB_SUPPORT)
+  FIND_PACKAGE(Glib REQUIRED)
+  FIND_PACKAGE(Gthread REQUIRED)
+ENDIF ()
+
 IF (ENABLE_WEBGL)
   FIND_PACKAGE(OpenGL REQUIRED)
 ENDIF ()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106099] tags/Safari-534.54.11/

2012-01-27 Thread mrowe

Title: [106099] tags/Safari-534.54.11/








Revision 106099
Author mr...@apple.com
Date 2012-01-27 01:20:33 -0800 (Fri, 27 Jan 2012)


Log Message
New tag.

Added Paths

tags/Safari-534.54.11/




Diff

Property changes: tags/Safari-534.54.11



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106100] branches/safari-534.54-branch/Source

2012-01-27 Thread mrowe

Title: [106100] branches/safari-534.54-branch/Source








Revision 106100
Author mr...@apple.com
Date 2012-01-27 01:21:19 -0800 (Fri, 27 Jan 2012)


Log Message
Versioning.

Modified Paths

branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig (106099 => 106100)

--- branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2012-01-27 09:20:33 UTC (rev 106099)
+++ branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2012-01-27 09:21:19 UTC (rev 106100)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 54;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (106099 => 106100)

--- branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2012-01-27 09:20:33 UTC (rev 106099)
+++ branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2012-01-27 09:21:19 UTC (rev 106100)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 54;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig (106099 => 106100)

--- branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig	2012-01-27 09:20:33 UTC (rev 106099)
+++ branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig	2012-01-27 09:21:19 UTC (rev 106100)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 54;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig (106099 => 106100)

--- branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2012-01-27 09:20:33 UTC (rev 106099)
+++ branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2012-01-27 09:21:19 UTC (rev 106100)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 54;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig (106099 => 106100)

--- branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig	2012-01-27 09:20:33 UTC (rev 106099)
+++ branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig	2012-01-27 09:21:19 UTC (rev 106100)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 54;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106104] trunk/Source/WebKit2

2012-01-27 Thread commit-queue

Title: [106104] trunk/Source/WebKit2








Revision 106104
Author commit-qu...@webkit.org
Date 2012-01-27 03:51:10 -0800 (Fri, 27 Jan 2012)


Log Message
[Qt] Re-creating QQuickWebView starts new web process every time
https://bugs.webkit.org/show_bug.cgi?id=77194

Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-01-27
Reviewed by Kenneth Rohde Christiansen.

Since the WebKit::WebContext is never fully destructed due to circular
references, we should use the real shared context instead of re-creating
a new WebContext every time.

* UIProcess/qt/QtWebContext.cpp:
(WebKit::QtWebContext::defaultContext):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtWebContext.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (106103 => 106104)

--- trunk/Source/WebKit2/ChangeLog	2012-01-27 11:36:17 UTC (rev 106103)
+++ trunk/Source/WebKit2/ChangeLog	2012-01-27 11:51:10 UTC (rev 106104)
@@ -1,3 +1,17 @@
+2012-01-27  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt] Re-creating QQuickWebView starts new web process every time
+https://bugs.webkit.org/show_bug.cgi?id=77194
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Since the WebKit::WebContext is never fully destructed due to circular
+references, we should use the real shared context instead of re-creating
+a new WebContext every time.
+
+* UIProcess/qt/QtWebContext.cpp:
+(WebKit::QtWebContext::defaultContext):
+
 2012-01-26  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Add basic printing support to WebKit2


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebContext.cpp (106103 => 106104)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebContext.cpp	2012-01-27 11:36:17 UTC (rev 106103)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebContext.cpp	2012-01-27 11:51:10 UTC (rev 106104)
@@ -69,7 +69,7 @@
 if (s_defaultContext)
 return PassRefPtrQtWebContext(s_defaultContext);
 
-RefPtrWebContext context = WebContext::create(String());
+RefPtrWebContext context = WebContext::sharedProcessContext();
 RefPtrQtWebContext defaultContext = QtWebContext::create(context.get());
 s_defaultContext = defaultContext.get();
 defaultContext-initialize();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106105] trunk/LayoutTests

2012-01-27 Thread ossy

Title: [106105] trunk/LayoutTests








Revision 106105
Author o...@webkit.org
Date 2012-01-27 03:55:54 -0800 (Fri, 27 Jan 2012)


Log Message
[Qt] Unreviewed gardening after r106087.

* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt
trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt
trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106104 => 106105)

--- trunk/LayoutTests/ChangeLog	2012-01-27 11:51:10 UTC (rev 106104)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 11:55:54 UTC (rev 106105)
@@ -1,3 +1,11 @@
+2012-01-27  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] Unreviewed gardening after r106087.
+
+* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
+* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
+* platform/qt/fast/js/global-constructors-expected.txt:
+
 2012-01-27  Nikolas Zimmermann  nzimmerm...@rim.com
 
 svg/repaint/image-with-clip-path.svg is flaky under guard malloc


Modified: trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt (106104 => 106105)

--- trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt	2012-01-27 11:51:10 UTC (rev 106104)
+++ trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt	2012-01-27 11:55:54 UTC (rev 106105)
@@ -61,8 +61,6 @@
 PASS (new inner.XPathEvaluator()).constructor.isInner is true
 PASS (new inner.XSLTProcessor()).isInner is true
 PASS (new inner.XSLTProcessor()).constructor.isInner is true
-PASS (new inner.webkitURL()).isInner is true
-PASS (new inner.webkitURL()).constructor.isInner is true
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt (106104 => 106105)

--- trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt	2012-01-27 11:51:10 UTC (rev 106104)
+++ trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt	2012-01-27 11:55:54 UTC (rev 106105)
@@ -240,7 +240,6 @@
 Never found DOMParser
 Never found DOMSettableTokenList
 Never found DOMStringList
-Never found DOMURL
 Never found Document
 Never found DocumentFragment
 Never found DocumentType


Modified: trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt (106104 => 106105)

--- trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt	2012-01-27 11:51:10 UTC (rev 106104)
+++ trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt	2012-01-27 11:55:54 UTC (rev 106105)
@@ -316,7 +316,6 @@
 PASS XPathException.toString() is '[object XPathExceptionConstructor]'
 PASS XPathResult.toString() is '[object XPathResultConstructor]'
 PASS XSLTProcessor.toString() is '[object XSLTProcessorConstructor]'
-FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].
 PASS successfullyParsed is true
 
 TEST COMPLETE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106106] trunk/LayoutTests

2012-01-27 Thread ossy

Title: [106106] trunk/LayoutTests








Revision 106106
Author o...@webkit.org
Date 2012-01-27 03:56:34 -0800 (Fri, 27 Jan 2012)


Log Message
[Qt] Unreviewed gardening. Try to paint the bots green.

* platform/qt-5.0/Skipped:
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt-5.0/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (106105 => 106106)

--- trunk/LayoutTests/ChangeLog	2012-01-27 11:55:54 UTC (rev 106105)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 11:56:34 UTC (rev 106106)
@@ -1,5 +1,12 @@
 2012-01-27  Csaba Osztrogonác  o...@webkit.org
 
+[Qt] Unreviewed gardening. Try to paint the bots green.
+
+* platform/qt-5.0/Skipped:
+* platform/qt/Skipped:
+
+2012-01-27  Csaba Osztrogonác  o...@webkit.org
+
 [Qt] Unreviewed gardening after r106087.
 
 * platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:


Modified: trunk/LayoutTests/platform/qt/Skipped (106105 => 106106)

--- trunk/LayoutTests/platform/qt/Skipped	2012-01-27 11:55:54 UTC (rev 106105)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-01-27 11:56:34 UTC (rev 106106)
@@ -2488,3 +2488,16 @@
 svg/W3C-SVG-1.1-SE/painting-control-04-f.svg
 svg/custom/zero-path-square-cap-rendering.svg
 svg/stroke/zero-length-arc-linecaps-rendering.svg
+
+# New fails between r106038 - r106051 - need more investigation
+editing/selection/caret-ltr-2-left.html
+editing/selection/caret-ltr-2.html
+editing/selection/caret-ltr-right.html
+editing/selection/caret-ltr.html
+editing/selection/caret-rtl-2-left.html
+editing/selection/caret-rtl-right.html
+fast/multicol/span/span-as-immediate-child-property-removal.html
+fast/multicol/span/span-as-immediate-columns-child-removal.html
+
+# new test introduced in http://trac.webkit.org/changeset/106072 - need more investigation
+fast/parser/nested-fragment-parser-crash.html


Modified: trunk/LayoutTests/platform/qt-5.0/Skipped (106105 => 106106)

--- trunk/LayoutTests/platform/qt-5.0/Skipped	2012-01-27 11:55:54 UTC (rev 106105)
+++ trunk/LayoutTests/platform/qt-5.0/Skipped	2012-01-27 11:56:34 UTC (rev 106106)
@@ -75,3 +75,17 @@
 # [Qt] fast/events/clear-edit-drag-state.html fails with timeout with Qt5-WK1
 # https://bugs.webkit.org/show_bug.cgi?id=76897
 fast/events/clear-edit-drag-state.html
+
+# [Qt] Use ICU if available - fails after http://trac.webkit.org/changeset/105997 - need more investigation
+css1/text_properties/text_transform.html
+editing/execCommand/findString-diacriticals.html
+editing/selection/caret-at-bidi-boundary.html
+editing/selection/caret-bidi-first-and-last-letters.html
+editing/selection/collapse-selection-in-bidi.html
+editing/selection/regional-indicators.html
+fast/css/text-transform-select.html
+fast/text/find-kana.html
+fast/text/find-russian.html
+fast/text/find-soft-hyphen.html
+fast/url/path.html
+svg/as-background-image/background-image-preserveaspectRatio-support.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106107] trunk/LayoutTests

2012-01-27 Thread zimmermann

Title: [106107] trunk/LayoutTests








Revision 106107
Author zimmerm...@webkit.org
Date 2012-01-27 04:02:48 -0800 (Fri, 27 Jan 2012)


Log Message
2012-01-27  Nikolas Zimmermann  nzimmerm...@rim.com

Not reviewed. Update chromium expectations after r106103.

* platform/chromium/test_expectations.txt: Verified using flakiness dashboard, that this is an IMAGE only diff.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106106 => 106107)

--- trunk/LayoutTests/ChangeLog	2012-01-27 11:56:34 UTC (rev 106106)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 12:02:48 UTC (rev 106107)
@@ -1,3 +1,9 @@
+2012-01-27  Nikolas Zimmermann  nzimmerm...@rim.com
+
+Not reviewed. Update chromium expectations after r106103.
+
+* platform/chromium/test_expectations.txt: Verified using flakiness dashboard, that this is an IMAGE only diff.
+
 2012-01-27  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Unreviewed gardening. Try to paint the bots green.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106106 => 106107)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-01-27 11:56:34 UTC (rev 106106)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-01-27 12:02:48 UTC (rev 106107)
@@ -3920,6 +3920,7 @@
 
 // Just needs a rebaseline.
 BUGWK69714 : svg/clip-path/clip-path-tspan-and-stroke.svg = IMAGE+TEXT
+BUGWK77103 : svg/repaint/image-href-change.svg = IMAGE
 
 // Change error (misspelling) underlines from Windows look to Mac look.
 BUG_CARYCLARK MAC : editing/deleting/delete-3928305-fix.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106109] trunk

2012-01-27 Thread jocelyn . turcotte

Title: [106109] trunk








Revision 106109
Author jocelyn.turco...@nokia.com
Date 2012-01-27 04:46:18 -0800 (Fri, 27 Jan 2012)


Log Message
[Qt] WKTR: Use a software rendering pipiline when running tests.
https://bugs.webkit.org/show_bug.cgi?id=76708

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

* platform/graphics/qt/TextureMapperQt.cpp: Allow setting the context to null.
(WebCore::TextureMapperQt::setGraphicsContext):
* platform/graphics/qt/TextureMapperQt.h:
(WebCore::TextureMapperQt::initialize):

Source/WebKit2:

Animation layout tests require the graphics layers tree to be updated
to pass. WebkitTestRunner doesn't show its wrapping QQuickView, which
prevents the rendering pipeline to run and then in turn blocks the web
process from processing further graphics layer updates.

This allows the tests to use a TextureMapperQt to empty the LayerTreeHost's
message queue and render the layers in software on an offscreen buffer.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paint):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::setNeedsDisplay):
(QQuickWebViewExperimental::setRenderToOffscreenBuffer):
(QQuickWebViewExperimental::renderToOffscreenBuffer):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::setRenderToOffscreenBuffer):
(QQuickWebViewPrivate::renderToOffscreenBuffer):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):

Tools:

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::WrapperWindow):
(WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.

LayoutTests:

* platform/qt-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/qt/TextureMapperQt.cpp
trunk/Source/WebCore/platform/graphics/qt/TextureMapperQt.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage_p_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h
trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h
trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h
trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.h
trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp
trunk/Source/WebKit2/UIProcess/qt/QtPageClient.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (106108 => 106109)

--- trunk/LayoutTests/ChangeLog	2012-01-27 12:38:57 UTC (rev 106108)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 12:46:18 UTC (rev 106109)
@@ -1,3 +1,12 @@
+2012-01-26  Jocelyn Turcotte  jocelyn.turco...@nokia.com
+
+[Qt] WKTR: Use a software rendering pipiline when running tests.
+https://bugs.webkit.org/show_bug.cgi?id=76708
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* platform/qt-wk2/Skipped:
+
 2012-01-27 Branimir Lambov blam...@google.com
 
 SVG filters incorrectly move elements


Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (106108 => 106109)

--- trunk/LayoutTests/platform/qt-wk2/Skipped	2012-01-27 12:38:57 UTC (rev 106108)
+++ trunk/LayoutTests/platform/qt-wk2/Skipped	2012-01-27 12:46:18 UTC (rev 106109)
@@ -439,58 +439,6 @@
 tables/mozilla_expected_failures/marvin/backgr_layers-show.html
 tables/mozilla_expected_failures/marvin/backgr_position-table-column.html
 
-# [Qt][WK2] REGRESSION(r105517): It made 49 tests timeout
-# https://bugs.webkit.org/show_bug.cgi?id=76708
-animations/3d/change-transform-in-end-event.html
-animations/3d/replace-filling-transform.html
-animations/3d/state-at-end-event-transform.html
-animations/3d/transform-perspective.html
-animations/additive-transform-animations.html
-animations/animation-direction-normal.html
-animations/animation-end-event-destroy-renderer.html
-animations/animation-hit-test-transform.html
-animations/animation-iteration-event-destroy-renderer.html
-animations/animation-matrix-negative-scale-unmatrix.html
-animations/animation-start-event-destroy-renderer.html
-animations/big-rotation.html
-animations/combo-transform-rotate+scale.html
-animations/combo-transform-translate+scale.html
-animations/dynamic-stylesheet-loading.html
-animations/fill-mode-transform.html
-animations/keyframe-timing-functions-transform.html
-animations/matrix-anim.html
-animations/missing-from-to-transforms.html
-animations/missing-keyframe-properties-repeating.html
-animations/missing-keyframe-properties-timing-function.html
-animations/missing-keyframe-properties.html
-animations/missing-values-first-keyframe.html
-animations/missing-values-last-keyframe.html

[webkit-changes] [106110] trunk

2012-01-27 Thread zimmermann

Title: [106110] trunk








Revision 106110
Author zimmerm...@webkit.org
Date 2012-01-27 04:56:21 -0800 (Fri, 27 Jan 2012)


Log Message
feImage DOM mutation problems
https://bugs.webkit.org/show_bug.cgi?id=77198

Reviewed by Antti Koivisto.

Source/WebCore:

Consider feImage xlink:href="" where rect gets dynamically added to the tree.
Currently feImage doesn't notice this, as it doesn't register itself pending on #rect.

Integrate feImage properly within the pending resources concept, fixing the bug.

Tests: svg/filters/feImage-target-add-to-document.svg
   svg/filters/feImage-target-changes-id.svg
   svg/filters/feImage-target-id-change.svg
   svg/filters/feImage-target-reappend-to-document.svg
   svg/filters/feImage-target-remove-from-document.svg

* svg/SVGFEImageElement.cpp: Rename invalidateImageResource to clearResourceReferences.
(WebCore::SVGFEImageElement::~SVGFEImageElement): Call clearResourceReferences.
(WebCore::SVGFEImageElement::clearResourceReferences): Remove any occurence of m_targetImage, it's no longer used.
(WebCore::SVGFEImageElement::requestImageResource): requestImageResource is now called by buildPendingResource.
(WebCore::SVGFEImageElement::buildPendingResource): Called whenever any element that we depend on gets resolved - now invalidates the filter.
(WebCore::SVGFEImageElement::parseMappedAttribute): Don't start loading from parseMappedAttribute.
(WebCore::SVGFEImageElement::svgAttributeChanged): Start loading from here, for consistency with SVGImageElement.
(WebCore::SVGFEImageElement::insertedIntoDocument): Invoke buildPendingResource(), if we enter the tree.
(WebCore::SVGFEImageElement::removedFromDocument): Clear m_cachedImage as soon as we get removed from the tree.
(WebCore::SVGFEImageElement::build): Clean up this function, m_targetImage is no longer exist.
* svg/SVGFEImageElement.h: Remove OwnPtrImageBuffer m_targetImage, which is no longer used.

LayoutTests:

Add new test cases covering feImage + DOM mutations.

* platform/chromium/test_expectations.txt: Updated expectations.
* svg/filters/feImage-target-add-to-document-expected.png: Added.
* svg/filters/feImage-target-add-to-document-expected.txt: Added.
* svg/filters/feImage-target-add-to-document.svg: Added.
* svg/filters/feImage-target-changes-id-expected.png: Added.
* svg/filters/feImage-target-changes-id-expected.txt: Added.
* svg/filters/feImage-target-changes-id.svg: Added.
* svg/filters/feImage-target-id-change-expected.png: Added.
* svg/filters/feImage-target-id-change-expected.txt: Added.
* svg/filters/feImage-target-id-change.svg: Added.
* svg/filters/feImage-target-reappend-to-document-expected.png: Added.
* svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
* svg/filters/feImage-target-reappend-to-document.svg: Added.
* svg/filters/feImage-target-remove-from-document-expected.png: Added.
* svg/filters/feImage-target-remove-from-document-expected.txt: Added.
* svg/filters/feImage-target-remove-from-document.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGFEImageElement.cpp
trunk/Source/WebCore/svg/SVGFEImageElement.h


Added Paths

trunk/LayoutTests/svg/filters/feImage-target-add-to-document-expected.png
trunk/LayoutTests/svg/filters/feImage-target-add-to-document-expected.txt
trunk/LayoutTests/svg/filters/feImage-target-add-to-document.svg
trunk/LayoutTests/svg/filters/feImage-target-changes-id-expected.png
trunk/LayoutTests/svg/filters/feImage-target-changes-id-expected.txt
trunk/LayoutTests/svg/filters/feImage-target-changes-id.svg
trunk/LayoutTests/svg/filters/feImage-target-id-change-expected.png
trunk/LayoutTests/svg/filters/feImage-target-id-change-expected.txt
trunk/LayoutTests/svg/filters/feImage-target-id-change.svg
trunk/LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.png
trunk/LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.txt
trunk/LayoutTests/svg/filters/feImage-target-reappend-to-document.svg
trunk/LayoutTests/svg/filters/feImage-target-remove-from-document-expected.png
trunk/LayoutTests/svg/filters/feImage-target-remove-from-document-expected.txt
trunk/LayoutTests/svg/filters/feImage-target-remove-from-document.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (106109 => 106110)

--- trunk/LayoutTests/ChangeLog	2012-01-27 12:46:18 UTC (rev 106109)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 12:56:21 UTC (rev 106110)
@@ -1,3 +1,29 @@
+2012-01-27  Nikolas Zimmermann  nzimmerm...@rim.com
+
+feImage DOM mutation problems
+https://bugs.webkit.org/show_bug.cgi?id=77198
+
+Reviewed by Antti Koivisto.
+
+Add new test cases covering feImage + DOM mutations.
+
+* platform/chromium/test_expectations.txt: Updated expectations.
+* svg/filters/feImage-target-add-to-document-expected.png: Added.
+*

[webkit-changes] [106111] trunk/Tools

2012-01-27 Thread vsevik

Title: [106111] trunk/Tools








Revision 106111
Author vse...@chromium.org
Date 2012-01-27 05:26:59 -0800 (Fri, 27 Jan 2012)


Log Message
Add Vsevolod Vlasov to reviewers list.

Reviewed by Pavel Feldman.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (106110 => 106111)

--- trunk/Tools/ChangeLog	2012-01-27 12:56:21 UTC (rev 106110)
+++ trunk/Tools/ChangeLog	2012-01-27 13:26:59 UTC (rev 106111)
@@ -1,3 +1,11 @@
+2012-01-27  Vsevolod Vlasov  vse...@chromium.org
+
+Add Vsevolod Vlasov to reviewers list.
+
+Reviewed by Pavel Feldman.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2012-01-26  No'am Rosenthal  noam.rosent...@nokia.com and Jocelyn Turcotte  jocelyn.turco...@nokia.com
 
 [Qt] WKTR: Use a software rendering pipiline when running tests.


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (106110 => 106111)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-01-27 12:56:21 UTC (rev 106110)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-01-27 13:26:59 UTC (rev 106111)
@@ -339,7 +339,6 @@
 Committer(Victoria Kirst, [v...@chromium.org, v...@google.com], vrk),
 Committer(Vincent Scheib, sch...@chromium.org, scheib),
 Committer(Vitaly Repeshko, vita...@chromium.org),
-Committer(Vsevolod Vlasov, vse...@chromium.org),
 Committer(William Siegrist, wsiegr...@apple.com, wms),
 Committer(W. James MacLean, wjmacl...@chromium.org, wjmaclean),
 Committer(Xianzhu Wang, [wangxian...@chromium.org, phnix...@gmail.com, wangxian...@google.com], wangxianzhu),
@@ -464,6 +463,7 @@
 Reviewer(Tony Gentilcore, to...@chromium.org, tonyg-cr),
 Reviewer(uTor Arne Vestb\u00f8, [ves...@webkit.org, tor.arne.ves...@nokia.com], torarne),
 Reviewer(Vicki Murley, vi...@apple.com),
+Reviewer(Vsevolod Vlasov, vse...@chromium.org, vsevik),
 Reviewer(Xan Lopez, [xan.lo...@gmail.com, x...@gnome.org, x...@webkit.org, xlo...@igalia.com], xan),
 Reviewer(Yury Semikhatsky, yu...@chromium.org, yurys),
 Reviewer(Zack Rusin, z...@kde.org, zackr),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106112] trunk/Source/WebCore

2012-01-27 Thread vsevik

Title: [106112] trunk/Source/WebCore








Revision 106112
Author vse...@chromium.org
Date 2012-01-27 05:46:09 -0800 (Fri, 27 Jan 2012)


Log Message
Web Inspector: Scripts panel: fix event dispatching between FileSelector and EditorContainer.
https://bugs.webkit.org/show_bug.cgi?id=77126

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded.get if):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.FileSelector.prototype.revealUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.revealUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._innerRevealUISourceCode):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goBack):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goForward):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._filesSelectChanged):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._tabSelected):
(WebInspector.TabbedEditorContainer.prototype.reset):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (106111 => 106112)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 13:26:59 UTC (rev 106111)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 13:46:09 UTC (rev 106112)
@@ -1,3 +1,31 @@
+2012-01-26  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Scripts panel: fix event dispatching between FileSelector and EditorContainer.
+https://bugs.webkit.org/show_bug.cgi?id=77126
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded.get if):
+(WebInspector.ScriptsPanel.prototype._reset):
+(WebInspector.ScriptsPanel.prototype._showSourceLine):
+(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
+(WebInspector.ScriptsPanel.prototype._editorClosed):
+(WebInspector.ScriptsPanel.prototype._editorSelected):
+(WebInspector.ScriptsPanel.FileSelector.prototype.revealUISourceCode):
+(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.revealUISourceCode):
+(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._innerRevealUISourceCode):
+(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.insertOrdered):
+(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect):
+(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goBack):
+(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goForward):
+(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._filesSelectChanged):
+* inspector/front-end/TabbedEditorContainer.js:
+(WebInspector.TabbedEditorContainer):
+(WebInspector.TabbedEditorContainer.prototype._tabClosed):
+(WebInspector.TabbedEditorContainer.prototype._tabSelected):
+(WebInspector.TabbedEditorContainer.prototype.reset):
+
 2012-01-27  Nikolas Zimmermann  nzimmerm...@rim.com
 
 feImage DOM mutation problems


Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (106111 => 106112)

--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js	2012-01-27 13:26:59 UTC (rev 106111)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js	2012-01-27 13:46:09 UTC (rev 106112)
@@ -92,6 +92,7 @@
 this._fileSelector.addEventListener(WebInspector.ScriptsPanel.FileSelector.Events.FileSelected, this._fileSelected, this);
 this._fileSelector.addEventListener(WebInspector.ScriptsPanel.FileSelector.Events.ReleasedFocusAfterSelection, this._fileSelectorReleasedFocus, this);
 this._editorContainer.addEventListener(WebInspector.EditorContainer.Events.EditorSelected, this._editorSelected, this);
+this._editorContainer.addEventListener(WebInspector.EditorContainer.Events.EditorClosed, this._editorClosed, this);
 
 this.splitView.mainElement.appendChild(this.debugSidebarResizeWidgetElement);
 
@@ -254,7 +255,6 @@
 // Anonymous sources are shown only when stepping.
 return;
 }
-
 this._fileSelector.addUISourceCode(uiSourceCode);
 
 var lastViewedURL = WebInspector.settings.lastViewedScriptFile.get();
@@ -262,12 +262,12 @@

[webkit-changes] [106114] trunk/Tools

2012-01-27 Thread zoltan

Title: [106114] trunk/Tools








Revision 106114
Author zol...@webkit.org
Date 2012-01-27 06:02:15 -0800 (Fri, 27 Jan 2012)


Log Message
Update committers.py with new contributors.
https://bugs.webkit.org/show_bug.cgi?id=77207

I added six new contributors into committers.py:

- Adam Kallai
- Balazs Ankes
- Janos Badics
- Nandor Huszka
- Roland Takacs
- Szilard Ledan-Muntean

Patch by Roland Takacs takacs.rol...@stud.u-szeged.hu on 2012-01-27

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (106113 => 106114)

--- trunk/Tools/ChangeLog	2012-01-27 13:54:21 UTC (rev 106113)
+++ trunk/Tools/ChangeLog	2012-01-27 14:02:15 UTC (rev 106114)
@@ -1,3 +1,19 @@
+2012-01-27  Roland Takacs  takacs.rol...@stud.u-szeged.hu
+
+Update committers.py with new contributors.
+https://bugs.webkit.org/show_bug.cgi?id=77207
+
+I added six new contributors into committers.py:
+
+- Adam Kallai
+- Balazs Ankes
+- Janos Badics
+- Nandor Huszka
+- Roland Takacs
+- Szilard Ledan-Muntean
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2012-01-27  Vsevolod Vlasov  vse...@chromium.org
 
 Add Vsevolod Vlasov to reviewers list.


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (106113 => 106114)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-01-27 13:54:21 UTC (rev 106113)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-01-27 14:02:15 UTC (rev 106114)
@@ -105,6 +105,7 @@
 
 
 contributors_who_are_not_committers = [
+Contributor(Adam Kallai, kallai.a...@stud.u-szeged.hu, 'kadam'),
 Contributor(Aharon Lanin, aha...@google.com),
 Contributor(Alan Stearns, stea...@adobe.com, 'astearns'),
 Contributor(Alexandre Elias, ael...@chromium.org),
@@ -114,6 +115,7 @@
 Contributor(Anne van Kesteren, annevankesteren+web...@gmail.com, annevk),
 Contributor(Annie Sullivan, sulli...@chromium.org, annie),
 Contributor(Aryeh Gregor, a...@aryeh.name, AryehGregor),
+Contributor(Balazs Ankes, ankes.bal...@stud.u-szeged.hu, 'abalazs'),
 Contributor(Commit Queue, commit-qu...@webkit.org),
 Contributor(Dana Jansens, dan...@chromium.org, danakj),
 Contributor(Daniel Sievers, siev...@chromium.org),
@@ -129,15 +131,19 @@
 Contributor(Greg Simon, gregsi...@chromium.org, gregsimon),
 Contributor(Gregg Tavares, [g...@google.com, g...@chromium.org], gman),
 Contributor(Ian Hickson, i...@hixie.ch, hixie),
+Contributor(Janos Badics, dic...@gmail.hu, 'dicska'),
 Contributor(John Bates, [jba...@google.com, jba...@chromium.org], jbates),
 Contributor(John Bauman, [jbau...@chromium.org, jbau...@google.com], jbauman),
 Contributor(Kaustubh Atrawalkar, [kaust...@motorola.com], silverroots),
 Contributor(Kristof Kosztyo, kkris...@inf.u-szeged.hu, kkristof),
 Contributor(Kulanthaivel Palanichamy, kulanthai...@codeaurora.org, kvel),
+Contributor(Nandor Huszka, huszka.nan...@stud.u-szeged.hu, hnandor),
 Contributor(Oliver Varga, [voli...@inf.u-szeged.hu, varga.oli...@stud.u-szeged.hu], TwistO),
 Contributor(Peter Gal, galpe...@inf.u-szeged.hu, elecro),
 Contributor(Peter Linss, peter.li...@hp.com, plinss),
 Contributor(Radar WebKit Bug Importer, webkit-bug-impor...@group.apple.com),
+Contributor(Roland Takacs, takacs.rol...@stud.u-szeged.hu, rtakacs),
+Contributor(Szilard Ledan-Muntean, muntean-ledan.szil...@stud.u-szeged.hu, szledan),
 Contributor(Tab Atkins, [tabatk...@google.com, jackalm...@gmail.com], tabatkins),
 Contributor(Tamas Czene, [tcz...@inf.u-szeged.hu, czene.ta...@stud.u-szeged.hu], tczene),
 Contributor(WebKit Review Bot, webkit.review@gmail.com, sheriff-bot),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106115] trunk/Source/WebCore

2012-01-27 Thread loislo

Title: [106115] trunk/Source/WebCore








Revision 106115
Author loi...@chromium.org
Date 2012-01-27 06:08:49 -0800 (Fri, 27 Jan 2012)


Log Message
Web Inspector: detailed heap snapshot: Replace (Native objects) root element
with '(Detached DOM trees)' and '(Document DOM trees)'
https://bugs.webkit.org/show_bug.cgi?id=77201

I think it'd be nice to replace one group containing all native objects with
separate groups for different types of native objects.

Reviewed by Yury Semikhatsky.

* bindings/v8/RetainedDOMInfo.cpp:
(WebCore::RetainedDOMInfo::GetGroupLabel):
(WebCore):
* bindings/v8/RetainedDOMInfo.h:
(RetainedDOMInfo):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.cpp
trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106114 => 106115)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 14:02:15 UTC (rev 106114)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 14:08:49 UTC (rev 106115)
@@ -1,3 +1,20 @@
+2012-01-27  Ilya Tikhonovsky  loi...@chromium.org
+
+Web Inspector: detailed heap snapshot: Replace (Native objects) root element
+with '(Detached DOM trees)' and '(Document DOM trees)'
+https://bugs.webkit.org/show_bug.cgi?id=77201
+
+I think it'd be nice to replace one group containing all native objects with
+separate groups for different types of native objects.
+
+Reviewed by Yury Semikhatsky.
+
+* bindings/v8/RetainedDOMInfo.cpp:
+(WebCore::RetainedDOMInfo::GetGroupLabel):
+(WebCore):
+* bindings/v8/RetainedDOMInfo.h:
+(RetainedDOMInfo):
+
 2012-01-27  Nikolas Zimmermann  nzimmerm...@rim.com
 
 feImage doesn't work with local references when using primitiveUnits=objectBoundingBox


Modified: trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.cpp (106114 => 106115)

--- trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.cpp	2012-01-27 14:02:15 UTC (rev 106114)
+++ trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.cpp	2012-01-27 14:08:49 UTC (rev 106115)
@@ -61,6 +61,11 @@
 return reinterpret_castintptr_t(m_root);
 }
 
+const char* RetainedDOMInfo::GetGroupLabel()
+{
+return m_root-inDocument() ? (Document DOM trees) : (Detached DOM trees);
+}
+
 const char* RetainedDOMInfo::GetLabel()
 {
 return m_root-inDocument() ? Document DOM tree : Detached DOM tree;


Modified: trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.h (106114 => 106115)

--- trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.h	2012-01-27 14:02:15 UTC (rev 106114)
+++ trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.h	2012-01-27 14:08:49 UTC (rev 106115)
@@ -45,6 +45,7 @@
 virtual void Dispose();
 virtual bool IsEquivalent(v8::RetainedObjectInfo* other);
 virtual intptr_t GetHash();
+virtual const char* GetGroupLabel();
 virtual const char* GetLabel();
 virtual intptr_t GetElementCount();
 virtual intptr_t GetEquivalenceClass();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106116] trunk/Source/WebKit2

2012-01-27 Thread kenneth

Title: [106116] trunk/Source/WebKit2








Revision 106116
Author kenn...@webkit.org
Date 2012-01-27 06:20:50 -0800 (Fri, 27 Jan 2012)


Log Message
[Qt] Fade out tap highlighting when starting to pan
https://bugs.webkit.org/show_bug.cgi?id=77202

Reviewed by Simon Hausmann.

Basically we need to fade out the potential tap highlighting
when ever the gesture recognition fails or another gesture
is recognized. We do that with this change.

* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::reset):

Remove reset as it does nothing but call code before the
event handler is installed.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (106115 => 106116)

--- trunk/Source/WebKit2/ChangeLog	2012-01-27 14:08:49 UTC (rev 106115)
+++ trunk/Source/WebKit2/ChangeLog	2012-01-27 14:20:50 UTC (rev 106116)
@@ -1,3 +1,22 @@
+2012-01-27  Kenneth Rohde Christiansen  kenn...@webkit.org
+
+[Qt] Fade out tap highlighting when starting to pan
+https://bugs.webkit.org/show_bug.cgi?id=77202
+
+Reviewed by Simon Hausmann.
+
+Basically we need to fade out the potential tap highlighting
+when ever the gesture recognition fails or another gesture
+is recognized. We do that with this change.
+
+* UIProcess/qt/QtTapGestureRecognizer.cpp:
+(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
+(WebKit::QtTapGestureRecognizer::recognize):
+(WebKit::QtTapGestureRecognizer::reset):
+
+Remove reset as it does nothing but call code before the
+event handler is installed.
+
 2012-01-26  No'am Rosenthal  noam.rosent...@nokia.com and Jocelyn Turcotte  jocelyn.turco...@nokia.com
 
 [Qt] WKTR: Use a software rendering pipiline when running tests.


Modified: trunk/Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp (106115 => 106116)

--- trunk/Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp	2012-01-27 14:08:49 UTC (rev 106115)
+++ trunk/Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp	2012-01-27 14:20:50 UTC (rev 106116)
@@ -35,7 +35,6 @@
 : QtGestureRecognizer(eventHandler)
 , m_tapState(NoTap)
 {
-reset();
 }
 
 bool QtTapGestureRecognizer::recognize(const QTouchEvent* event, qint64 eventTimestampMillis)
@@ -87,6 +86,7 @@
 break;
 case QEvent::TouchEnd:
 m_tapAndHoldTimer.stop();
+m_eventHandler-handlePotentialSingleTapEvent(QTouchEvent::TouchPoint());
 
 switch (m_tapState) {
 case DoubleTapCandidate:
@@ -117,9 +117,6 @@
 break;
 }
 
-if (m_tapState == NoTap)
-m_eventHandler-handlePotentialSingleTapEvent(QTouchEvent::TouchPoint());
-
 return false;
 }
 
@@ -149,6 +146,8 @@
 
 void QtTapGestureRecognizer::reset()
 {
+m_eventHandler-handlePotentialSingleTapEvent(QTouchEvent::TouchPoint());
+
 m_tapState = NoTap;
 m_touchBeginEventForTap.clear();
 m_tapAndHoldTimer.stop();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106117] trunk/Source

2012-01-27 Thread carlosgc

Title: [106117] trunk/Source








Revision 106117
Author carlo...@webkit.org
Date 2012-01-27 06:27:24 -0800 (Fri, 27 Jan 2012)


Log Message
[GTK] Add a GKeyFile especialization to GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=77191

Reviewed by Martin Robinson.

Source/_javascript_Core:

* wtf/gobject/GOwnPtr.cpp:
(WTF::GKeyFile): Implement freeOwnedGPtr for GKeyFile.
* wtf/gobject/GOwnPtr.h: Add GKeyFile template.
* wtf/gobject/GTypedefs.h: Add forward declaration for GKeyFile.

Source/WebKit2:

* Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::decodeGKeyFile): Use GOwnPtr for GKeyFile.
(CoreIPC::encode): Ditto.
(CoreIPC::decode): Ditto.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/gobject/GOwnPtr.cpp
trunk/Source/_javascript_Core/wtf/gobject/GOwnPtr.h
trunk/Source/_javascript_Core/wtf/gobject/GTypedefs.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/gtk/ArgumentCodersGtk.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106116 => 106117)

--- trunk/Source/_javascript_Core/ChangeLog	2012-01-27 14:20:50 UTC (rev 106116)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-27 14:27:24 UTC (rev 106117)
@@ -1,3 +1,15 @@
+2012-01-27  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Add a GKeyFile especialization to GOwnPtr
+https://bugs.webkit.org/show_bug.cgi?id=77191
+
+Reviewed by Martin Robinson.
+
+* wtf/gobject/GOwnPtr.cpp:
+(WTF::GKeyFile): Implement freeOwnedGPtr for GKeyFile.
+* wtf/gobject/GOwnPtr.h: Add GKeyFile template.
+* wtf/gobject/GTypedefs.h: Add forward declaration for GKeyFile.
+
 2012-01-25  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: should be possible to open function declaration from script popover


Modified: trunk/Source/_javascript_Core/wtf/gobject/GOwnPtr.cpp (106116 => 106117)

--- trunk/Source/_javascript_Core/wtf/gobject/GOwnPtr.cpp	2012-01-27 14:20:50 UTC (rev 106116)
+++ trunk/Source/_javascript_Core/wtf/gobject/GOwnPtr.cpp	2012-01-27 14:27:24 UTC (rev 106117)
@@ -55,6 +55,12 @@
 g_timer_destroy(ptr);
 }
 
+template  void freeOwnedGPtrGKeyFile(GKeyFile* ptr)
+{
+if (ptr)
+g_key_file_free(ptr);
+}
+
 } // namespace WTF
 
 #endif // ENABLE(GLIB_SUPPORT)


Modified: trunk/Source/_javascript_Core/wtf/gobject/GOwnPtr.h (106116 => 106117)

--- trunk/Source/_javascript_Core/wtf/gobject/GOwnPtr.h	2012-01-27 14:20:50 UTC (rev 106116)
+++ trunk/Source/_javascript_Core/wtf/gobject/GOwnPtr.h	2012-01-27 14:27:24 UTC (rev 106117)
@@ -38,6 +38,7 @@
 template void freeOwnedGPtrGPatternSpec(GPatternSpec*);
 template void freeOwnedGPtrGDir(GDir*);
 template void freeOwnedGPtrGTimer(GTimer*);
+template void freeOwnedGPtrGKeyFile(GKeyFile*);
 
 template typename T class GOwnPtr {
 WTF_MAKE_NONCOPYABLE(GOwnPtr);


Modified: trunk/Source/_javascript_Core/wtf/gobject/GTypedefs.h (106116 => 106117)

--- trunk/Source/_javascript_Core/wtf/gobject/GTypedefs.h	2012-01-27 14:20:50 UTC (rev 106116)
+++ trunk/Source/_javascript_Core/wtf/gobject/GTypedefs.h	2012-01-27 14:27:24 UTC (rev 106117)
@@ -59,6 +59,7 @@
 typedef struct _GVariant GVariant;
 typedef union _GdkEvent GdkEvent;
 typedef struct _GTimer GTimer;
+typedef struct _GKeyFile GKeyFile;
 
 #if USE(CAIRO)
 typedef struct _cairo_surface cairo_surface_t;


Modified: trunk/Source/WebKit2/ChangeLog (106116 => 106117)

--- trunk/Source/WebKit2/ChangeLog	2012-01-27 14:20:50 UTC (rev 106116)
+++ trunk/Source/WebKit2/ChangeLog	2012-01-27 14:27:24 UTC (rev 106117)
@@ -1,3 +1,15 @@
+2012-01-27  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Add a GKeyFile especialization to GOwnPtr
+https://bugs.webkit.org/show_bug.cgi?id=77191
+
+Reviewed by Martin Robinson.
+
+* Shared/gtk/ArgumentCodersGtk.cpp:
+(CoreIPC::decodeGKeyFile): Use GOwnPtr for GKeyFile.
+(CoreIPC::encode): Ditto.
+(CoreIPC::decode): Ditto.
+
 2012-01-27  Kenneth Rohde Christiansen  kenn...@webkit.org
 
 [Qt] Fade out tap highlighting when starting to pan


Modified: trunk/Source/WebKit2/Shared/gtk/ArgumentCodersGtk.cpp (106116 => 106117)

--- trunk/Source/WebKit2/Shared/gtk/ArgumentCodersGtk.cpp	2012-01-27 14:20:50 UTC (rev 106116)
+++ trunk/Source/WebKit2/Shared/gtk/ArgumentCodersGtk.cpp	2012-01-27 14:27:24 UTC (rev 106117)
@@ -226,21 +226,18 @@
 encoder-encode(dataReference);
 }
 
-static bool decodeGKeyFile(ArgumentDecoder* decoder, GKeyFile** keyFile)
+static bool decodeGKeyFile(ArgumentDecoder* decoder, GOwnPtrGKeyFile keyFile)
 {
 DataReference dataReference;
 if (!decoder-decode(dataReference))
 return false;
 
-if (!dataReference.size()) {
-*keyFile = 0;
+if (!dataReference.size())
 return true;
-}
 
-*keyFile = g_key_file_new();
-if (!g_key_file_load_from_data(*keyFile, reinterpret_castconst gchar*(dataReference.data()), dataReference.size(), G_KEY_FILE_NONE, 0)) {
-

[webkit-changes] [106118] trunk

2012-01-27 Thread zeno . albisser

Title: [106118] trunk








Revision 106118
Author zeno.albis...@nokia.com
Date 2012-01-27 06:42:07 -0800 (Fri, 27 Jan 2012)


Log Message
[Qt][Mac] Build fails after adding ICU support (r105997).
https://bugs.webkit.org/show_bug.cgi?id=77118

Source/_javascript_Core:

Use Apple code path for unicode date formats on mac.

Reviewed by Tor Arne Vestbø.

* runtime/DatePrototype.cpp:
():

Source/WebCore:

Use SmareReplaceCF.cpp code path if platform Mac.

Reviewed by Tor Arne Vestbø.

* Target.pri:

Source/WTF:

Link to libicucore if platform Mac.

Reviewed by Tor Arne Vestbø.

* WTF.pri:

Tools:

Define WTF_USE_ICU_UNICODE if we are on mac.

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/features.prf:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/DatePrototype.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.pri
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/features.prf




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106117 => 106118)

--- trunk/Source/_javascript_Core/ChangeLog	2012-01-27 14:27:24 UTC (rev 106117)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-27 14:42:07 UTC (rev 106118)
@@ -1,3 +1,15 @@
+2012-01-27  Zeno Albisser  z...@webkit.org
+
+[Qt][Mac] Build fails after adding ICU support (r105997).
+https://bugs.webkit.org/show_bug.cgi?id=77118
+
+Use Apple code path for unicode date formats on mac.
+
+Reviewed by Tor Arne Vestbø.
+
+* runtime/DatePrototype.cpp:
+():
+
 2012-01-27  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Add a GKeyFile especialization to GOwnPtr


Modified: trunk/Source/_javascript_Core/runtime/DatePrototype.cpp (106117 => 106118)

--- trunk/Source/_javascript_Core/runtime/DatePrototype.cpp	2012-01-27 14:27:24 UTC (rev 106117)
+++ trunk/Source/_javascript_Core/runtime/DatePrototype.cpp	2012-01-27 14:42:07 UTC (rev 106118)
@@ -60,7 +60,7 @@
 #include sys/timeb.h
 #endif
 
-#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(WX)
+#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(WX) || (PLATFORM(QT)  OS(DARWIN))
 #include CoreFoundation/CoreFoundation.h
 #elif USE(ICU_UNICODE)
 #include unicode/udat.h
@@ -130,7 +130,7 @@
 
 enum LocaleDateTimeFormat { LocaleDateAndTime, LocaleDate, LocaleTime };
  
-#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(WX)
+#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(WX) || (PLATFORM(QT)  OS(DARWIN))
 
 // FIXME: Since this is superior to the strftime-based version, why limit this to PLATFORM(MAC)?
 // Instead we should consider using this whenever USE(CF) is true.


Modified: trunk/Source/WTF/ChangeLog (106117 => 106118)

--- trunk/Source/WTF/ChangeLog	2012-01-27 14:27:24 UTC (rev 106117)
+++ trunk/Source/WTF/ChangeLog	2012-01-27 14:42:07 UTC (rev 106118)
@@ -1,3 +1,14 @@
+2012-01-27  Zeno Albisser  z...@webkit.org
+
+[Qt][Mac] Build fails after adding ICU support (r105997).
+https://bugs.webkit.org/show_bug.cgi?id=77118
+
+Link to libicucore if platform Mac.
+
+Reviewed by Tor Arne Vestbø.
+
+* WTF.pri:
+
 2012-01-26  Jesus Sanchez-Palencia  jesus.palen...@openbossa.org
 
 [Qt] Use ICU if available


Modified: trunk/Source/WTF/WTF.pri (106117 => 106118)

--- trunk/Source/WTF/WTF.pri	2012-01-27 14:27:24 UTC (rev 106117)
+++ trunk/Source/WTF/WTF.pri	2012-01-27 14:42:07 UTC (rev 106118)
@@ -17,11 +17,20 @@
 $$OLD_SOURCE_DIR/qt \
 $$OLD_SOURCE_DIR/unicode
 
-haveQt(5):contains(QT_CONFIG,icu) {
-unix:!mac: LIBS += $$system(icu-config --ldflags-searchpath --ldflags-libsonly)
-else: LIBS += -licuin
-} else {
-haveQt(5): error(To build QtWebKit with Qt 5 you need ICU)
+haveQt(5) {
+mac {
+# Mac OS does ship libicu but not the associated header files.
+# Therefore WebKit provides adequate header files.
+INCLUDEPATH += $${ROOT_WEBKIT_DIR}/Source/WTF/icu
+LIBS += -licucore
+} else {
+contains(QT_CONFIG,icu) {
+unix: LIBS += $$system(icu-config --ldflags-searchpath --ldflags-libsonly)
+else: LIBS += -licuin
+} else {
+error(To build QtWebKit with Qt 5 you need ICU)
+}
+}
 }
 
 v8 {


Modified: trunk/Source/WebCore/ChangeLog (106117 => 106118)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 14:27:24 UTC (rev 106117)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 14:42:07 UTC (rev 106118)
@@ -1,3 +1,14 @@
+2012-01-27  Zeno Albisser  z...@webkit.org
+
+[Qt][Mac] Build fails after adding ICU support (r105997).
+https://bugs.webkit.org/show_bug.cgi?id=77118
+
+Use SmareReplaceCF.cpp code path if platform Mac.
+
+Reviewed by Tor Arne Vestbø.
+
+* Target.pri:
+
 2012-01-27  Ilya Tikhonovsky  loi...@chromium.org
 
 Web Inspector: detailed heap snapshot: Replace (Native objects) root element


Modified: trunk/Source/WebCore/Target.pri (106117 =>

[webkit-changes] [106119] trunk/Tools

2012-01-27 Thread abecsi

Title: [106119] trunk/Tools








Revision 106119
Author abe...@webkit.org
Date 2012-01-27 06:53:32 -0800 (Fri, 27 Jan 2012)


Log Message
[Qt][WK2] Enable the automatic touch-mouse mocking on the new Qt5 hashes
https://bugs.webkit.org/show_bug.cgi?id=77122

Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp




Diff

Modified: trunk/Tools/ChangeLog (106118 => 106119)

--- trunk/Tools/ChangeLog	2012-01-27 14:42:07 UTC (rev 106118)
+++ trunk/Tools/ChangeLog	2012-01-27 14:53:32 UTC (rev 106119)
@@ -1,3 +1,13 @@
+2012-01-27  Andras Becsi  andras.be...@nokia.com
+
+[Qt][WK2] Enable the automatic touch-mouse mocking on the new Qt5 hashes
+https://bugs.webkit.org/show_bug.cgi?id=77122
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* MiniBrowser/qt/MiniBrowserApplication.cpp:
+(MiniBrowserApplication::MiniBrowserApplication):
+
 2012-01-27  Zeno Albisser  z...@webkit.org
 
 [Qt][Mac] Build fails after adding ICU support (r105997).


Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp (106118 => 106119)

--- trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp	2012-01-27 14:42:07 UTC (rev 106118)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp	2012-01-27 14:53:32 UTC (rev 106119)
@@ -75,9 +75,6 @@
 setApplicationVersion(0.1);
 
 handleUserOptions();
-
-// FIXME: This should be removed as soon as we can flag touch mock events as synthesized throuch QWindowSystemInterface
-qApp-setAttribute(Qt::AA_SynthesizeMouseForUnhandledTouchEvents, false);
 }
 
 bool MiniBrowserApplication::notify(QObject* target, QEvent* event)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106120] trunk/Source/WebCore

2012-01-27 Thread commit-queue

Title: [106120] trunk/Source/WebCore








Revision 106120
Author commit-qu...@webkit.org
Date 2012-01-27 07:15:50 -0800 (Fri, 27 Jan 2012)


Log Message
Removed unused method from CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=77190

Patch by Thiago Marcos P. Santos tmpsan...@gmail.com on 2012-01-27
Reviewed by Andreas Kling.

* css/CSSStyleSelector.h:
(CSSStyleSelector):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106119 => 106120)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 14:53:32 UTC (rev 106119)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 15:15:50 UTC (rev 106120)
@@ -1,3 +1,13 @@
+2012-01-27  Thiago Marcos P. Santos  tmpsan...@gmail.com
+
+Removed unused method from CSSStyleSelector
+https://bugs.webkit.org/show_bug.cgi?id=77190
+
+Reviewed by Andreas Kling.
+
+* css/CSSStyleSelector.h:
+(CSSStyleSelector):
+
 2012-01-27  Zeno Albisser  z...@webkit.org
 
 [Qt][Mac] Build fails after adding ICU support (r105997).


Modified: trunk/Source/WebCore/css/CSSStyleSelector.h (106119 => 106120)

--- trunk/Source/WebCore/css/CSSStyleSelector.h	2012-01-27 14:53:32 UTC (rev 106119)
+++ trunk/Source/WebCore/css/CSSStyleSelector.h	2012-01-27 15:15:50 UTC (rev 106120)
@@ -203,7 +203,6 @@
 void visitedStateChanged(LinkHash visitedHash) { m_checker.visitedStateChanged(visitedHash); }
 
 void addKeyframeStyle(PassRefPtrWebKitCSSKeyframesRule);
-void addPageStyle(PassRefPtrCSSPageRule);
 
 bool checkRegionStyle(Element* regionElement);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106121] trunk/Source/WebCore

2012-01-27 Thread noam . rosenthal

Title: [106121] trunk/Source/WebCore








Revision 106121
Author noam.rosent...@nokia.com
Date 2012-01-27 07:35:40 -0800 (Fri, 27 Jan 2012)


Log Message
[Qt][WK2] Child layers appear in wrong position when scrolling
https://bugs.webkit.org/show_bug.cgi?id=77063

Reviewed by Simon Fraser.

When using the delegatesScrolling mode in FrameView, the compositor doesn't need
to control the special clip/scroll layers. Also, when we change that mode, we need to let
the compositor reset its backing-stores and rebuild them without scrolling/clipping.

This is tested by compositing tests, when run with Qt in touch mode.

* page/FrameView.cpp:
(WebCore::FrameView::delegatesScrollingDidChange):
(WebCore):
* page/FrameView.h:
(FrameView):
* platform/ScrollView.cpp:
(WebCore::ScrollView::setDelegatesScrolling):
* platform/ScrollView.h:
(WebCore::ScrollView::delegatesScrollingDidChange):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresScrollLayer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106120 => 106121)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 15:15:50 UTC (rev 106120)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 15:35:40 UTC (rev 106121)
@@ -1,3 +1,28 @@
+2012-01-27  No'am Rosenthal  noam.rosent...@nokia.com
+
+[Qt][WK2] Child layers appear in wrong position when scrolling
+https://bugs.webkit.org/show_bug.cgi?id=77063
+
+Reviewed by Simon Fraser.
+
+When using the delegatesScrolling mode in FrameView, the compositor doesn't need
+to control the special clip/scroll layers. Also, when we change that mode, we need to let
+the compositor reset its backing-stores and rebuild them without scrolling/clipping.
+
+This is tested by compositing tests, when run with Qt in touch mode.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::delegatesScrollingDidChange):
+(WebCore):
+* page/FrameView.h:
+(FrameView):
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::setDelegatesScrolling):
+* platform/ScrollView.h:
+(WebCore::ScrollView::delegatesScrollingDidChange):
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::requiresScrollLayer):
+
 2012-01-27  Thiago Marcos P. Santos  tmpsan...@gmail.com
 
 Removed unused method from CSSStyleSelector


Modified: trunk/Source/WebCore/page/FrameView.cpp (106120 => 106121)

--- trunk/Source/WebCore/page/FrameView.cpp	2012-01-27 15:15:50 UTC (rev 106120)
+++ trunk/Source/WebCore/page/FrameView.cpp	2012-01-27 15:35:40 UTC (rev 106121)
@@ -1702,6 +1702,14 @@
 ScrollView::setScrollPosition(scrollPoint);
 }
 
+void FrameView::delegatesScrollingDidChange()
+{
+#if USE(ACCELERATED_COMPOSITING)
+// When we switch to delgatesScrolling mode, we should destroy the scrolling/clipping layers in RenderLayerCompositor.
+clearBackingStores();
+#endif
+}
+
 void FrameView::setFixedVisibleContentRect(const IntRect visibleContentRect)
 {
 IntSize offset = scrollOffset();


Modified: trunk/Source/WebCore/page/FrameView.h (106120 => 106121)

--- trunk/Source/WebCore/page/FrameView.h	2012-01-27 15:15:50 UTC (rev 106120)
+++ trunk/Source/WebCore/page/FrameView.h	2012-01-27 15:35:40 UTC (rev 106121)
@@ -346,6 +346,8 @@
 virtual void contentsResized() OVERRIDE;
 virtual void visibleContentsResized();
 
+virtual void delegatesScrollingDidChange();
+
 // Override ScrollView methods to do point conversion via renderers, in order to
 // take transforms into account.
 virtual IntRect convertToContainingView(const IntRect) const;


Modified: trunk/Source/WebCore/platform/ScrollView.cpp (106120 => 106121)

--- trunk/Source/WebCore/platform/ScrollView.cpp	2012-01-27 15:15:50 UTC (rev 106120)
+++ trunk/Source/WebCore/platform/ScrollView.cpp	2012-01-27 15:35:40 UTC (rev 106121)
@@ -219,7 +219,11 @@
 
 void ScrollView::setDelegatesScrolling(bool delegatesScrolling)
 {
+if (m_delegatesScrolling == delegatesScrolling)
+return;
+
 m_delegatesScrolling = delegatesScrolling;
+delegatesScrollingDidChange();
 }
 
 #if !PLATFORM(GTK)


Modified: trunk/Source/WebCore/platform/ScrollView.h (106120 => 106121)

--- trunk/Source/WebCore/platform/ScrollView.h	2012-01-27 15:15:50 UTC (rev 106120)
+++ trunk/Source/WebCore/platform/ScrollView.h	2012-01-27 15:35:40 UTC (rev 106121)
@@ -301,6 +301,7 @@
 virtual void paintOverhangAreas(GraphicsContext*, const IntRect horizontalOverhangArea, const IntRect verticalOverhangArea, const IntRect dirtyRect);
 
 virtual void visibleContentsResized() = 0;
+virtual void delegatesScrollingDidChange() { }
 
 IntRect fixedVisibleContentRect() const {

[webkit-changes] [106122] trunk/LayoutTests

2012-01-27 Thread knorton

Title: [106122] trunk/LayoutTests








Revision 106122
Author knor...@google.com
Date 2012-01-27 07:36:00 -0800 (Fri, 27 Jan 2012)


Log Message
[chromium] Unreviewed, rebaseline after http://trac.webkit.org/changeset/105613.


* platform/chromium/test_expectations.txt: Enable rebaselined tests

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106121 => 106122)

--- trunk/LayoutTests/ChangeLog	2012-01-27 15:35:40 UTC (rev 106121)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 15:36:00 UTC (rev 106122)
@@ -1,3 +1,9 @@
+2012-01-27  Kelly Norton  knor...@google.com
+
+[chromium] Unreviewed, rebaseline after http://trac.webkit.org/changeset/105613.
+
+* platform/chromium/test_expectations.txt: Enable rebaselined tests
+
 2012-01-27  Nikolas Zimmermann  nzimmerm...@rim.com
 
 feImage doesn't work with local references when using primitiveUnits=objectBoundingBox


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106121 => 106122)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-01-27 15:35:40 UTC (rev 106121)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-01-27 15:36:00 UTC (rev 106122)
@@ -941,10 +941,6 @@
 BUGWK62974 : svg/custom/svg-fonts-with-no-element-reference.html = IMAGE+TEXT IMAGE
 BUGWK62974 MAC : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = IMAGE
 
-// May need new baseline after 76559 lands.
-BUGWK76559 : svg/custom/relative-sized-image.xhtml = IMAGE+TEXT
-BUGWK76559 : svg/repaint/image-with-clip-path.svg = IMAGE
-
 // -
 // End SVG Regressions
 // -






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106123] trunk/LayoutTests

2012-01-27 Thread commit-queue

Title: [106123] trunk/LayoutTests








Revision 106123
Author commit-qu...@webkit.org
Date 2012-01-27 07:58:42 -0800 (Fri, 27 Jan 2012)


Log Message
[Chromium]: Update expectations after r105572
https://bugs.webkit.org/show_bug.cgi?id=77211

Unreviewed Chromium test expectations update.

Patch by Stephen Chenney schen...@chromium.org on 2012-01-27

* platform/chromium/test_expectations.txt: Removed crash flakiness fixed with r105572.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106122 => 106123)

--- trunk/LayoutTests/ChangeLog	2012-01-27 15:36:00 UTC (rev 106122)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 15:58:42 UTC (rev 106123)
@@ -1,3 +1,12 @@
+2012-01-27  Stephen Chenney  schen...@chromium.org
+
+[Chromium]: Update expectations after r105572
+https://bugs.webkit.org/show_bug.cgi?id=77211
+
+Unreviewed Chromium test expectations update.
+
+* platform/chromium/test_expectations.txt: Removed crash flakiness fixed with r105572.
+
 2012-01-27  Kelly Norton  knor...@google.com
 
 [chromium] Unreviewed, rebaseline after http://trac.webkit.org/changeset/105613.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106122 => 106123)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-01-27 15:36:00 UTC (rev 106122)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-01-27 15:58:42 UTC (rev 106123)
@@ -889,10 +889,7 @@
 // Text mismatch since r65370.
 // There was also an unnoticed image mismatch before this revision
 // (wrong baseline was committed). No idea about when it really started to fail.
-BUGCR52692 LINUX WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-80-t.svg = PASS IMAGE+TEXT
-BUGCR52692 BUGWK74788 LINUX WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-80-t.svg = PASS IMAGE+TEXT CRASH
-BUGCR52692 BUGWK74788 LINUX DEBUG : svg/W3C-SVG-1.1/animate-elem-60-t.svg = PASS CRASH
-BUGWK74788 MAC : svg/W3C-SVG-1.1/animate-elem-80-t.svg = PASS CRASH
+BUGCR52692 LINUX WIN : svg/W3C-SVG-1.1/animate-elem-80-t.svg = PASS IMAGE+TEXT
 
 // Windows and Mac need rebaselining after 53378 patch.
 BUGWK53378 WIN MAC : svg/W3C-SVG-1.1/filters-example-01-b.svg = IMAGE
@@ -1508,46 +1505,26 @@
 BUGCR99500 WIN : fast/reflections/reflection-overflow-hidden.html = IMAGE
 BUGCR99500 WIN : fast/repaint/reflection-redraw.html = IMAGE
 BUGCR99500 WIN : printing/width-overflow.html = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-37-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-41-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-46-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-60-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-61-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-62-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-63-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-64-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-65-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-66-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-67-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-68-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-69-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-70-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-81-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-82-t.svg = IMAGE
-BUGCR99500 WIN RELEASE : svg/W3C-SVG-1.1/animate-elem-83-t.svg = IMAGE
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-37-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-41-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-46-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-60-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-61-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-62-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-63-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-64-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500 WIN DEBUG : svg/W3C-SVG-1.1/animate-elem-65-t.svg = IMAGE CRASH
-BUGWK74788 BUGCR99500

[webkit-changes] [106127] trunk/Source/WebCore

2012-01-27 Thread haraken

Title: [106127] trunk/Source/WebCore








Revision 106127
Author hara...@chromium.org
Date 2012-01-27 09:55:38 -0800 (Fri, 27 Jan 2012)


Log Message
Unreviewed. Rebasedlined run-bindings-tests results.

* bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
(WebDOMTestInterface::supplementalMethod1):
(WebDOMTestInterface::supplementalMethod2):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106126 => 106127)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 17:54:13 UTC (rev 106126)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 17:55:38 UTC (rev 106127)
@@ -1,3 +1,11 @@
+2012-01-27  Kentaro Hara  hara...@chromium.org
+
+Unreviewed. Rebasedlined run-bindings-tests results.
+
+* bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
+(WebDOMTestInterface::supplementalMethod1):
+(WebDOMTestInterface::supplementalMethod2):
+
 2012-01-27  No'am Rosenthal  noam.rosent...@nokia.com
 
 [Qt][WK2] Child layers appear in wrong position when scrolling


Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.cpp (106126 => 106127)

--- trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.cpp	2012-01-27 17:54:13 UTC (rev 106126)
+++ trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.cpp	2012-01-27 17:55:38 UTC (rev 106127)
@@ -115,7 +115,7 @@
 if (!impl())
 return;
 
-TestSupplemental::supplementalMethod1(impl());
+WebCore::TestSupplemental::supplementalMethod1(impl());
 }
 
 #endif
@@ -128,7 +128,7 @@
 return WebDOMTestObj();
 
 WebCore::ExceptionCode ec = 0;
-WebDOMTestObj result = toWebKit(WTF::getPtr(TestSupplemental::supplementalMethod2(impl(), strArg, toWebCore(objArg), ec)));
+WebDOMTestObj result = toWebKit(WTF::getPtr(WebCore::TestSupplemental::supplementalMethod2(impl(), strArg, toWebCore(objArg), ec)));
 webDOMRaiseError(static_castWebDOMExceptionCode(ec));
 return result;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106128] branches/safari-534.54-branch/Source/JavaScriptCore

2012-01-27 Thread lforschler

Title: [106128] branches/safari-534.54-branch/Source/_javascript_Core








Revision 106128
Author lforsch...@apple.com
Date 2012-01-27 10:11:49 -0800 (Fri, 27 Jan 2012)


Log Message
Merge 106075.

Modified Paths

branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog
branches/safari-534.54-branch/Source/_javascript_Core/bytecode/CodeBlock.h




Diff

Modified: branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog (106127 => 106128)

--- branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog	2012-01-27 17:55:38 UTC (rev 106127)
+++ branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog	2012-01-27 18:11:49 UTC (rev 106128)
@@ -1,3 +1,20 @@
+2011-01-27  Lucas Forschler  lforsch...@apple.com
+
+Merge 106075
+
+2012-01-26  Oliver Hunt  oli...@apple.com
+
+MSVC bug fix.
+rdar://problem/10703671 MSVC generates bad code for enum compare.
+
+RS=Geoff
+
+Make bitfield large enough to work around MSVC's desire to make enums
+signed types.
+
+* bytecode/CallLinkInfo.h:
+(CallLinkInfo):
+
 2012-01-26  Mark Hahnenberg  mhahnenb...@apple.com
 
 Hang in parallel GC caused by incorrect GCC asm codegen


Modified: branches/safari-534.54-branch/Source/_javascript_Core/bytecode/CodeBlock.h (106127 => 106128)

--- branches/safari-534.54-branch/Source/_javascript_Core/bytecode/CodeBlock.h	2012-01-27 17:55:38 UTC (rev 106127)
+++ branches/safari-534.54-branch/Source/_javascript_Core/bytecode/CodeBlock.h	2012-01-27 18:11:49 UTC (rev 106128)
@@ -140,7 +140,7 @@
 WriteBarrierJSFunction lastSeenCallee;
 bool hasSeenShouldRepatch : 1;
 bool isDFG : 1;
-CallType callType : 2;
+CallType callType : 6;
 unsigned bytecodeIndex;
 
 bool isLinked() { return callee; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106129] trunk

2012-01-27 Thread tony

Title: [106129] trunk








Revision 106129
Author t...@chromium.org
Date 2012-01-27 10:12:05 -0800 (Fri, 27 Jan 2012)


Log Message
flexbox scrollbars don't take flex-direction into account
https://bugs.webkit.org/show_bug.cgi?id=70772

Reviewed by Darin Adler.

Source/WebCore:

This fixes a bug where we always used the logicalScrollbarHeight.
For column flow, this was incorrect.

Also fix a bug where we didn't include the trailing border+padding+scrollbar when computing the
height of a column flow.

Tests: css3/flexbox/cross-axis-scrollbar-expected.html
   css3/flexbox/cross-axis-scrollbar.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::crossAxisScrollbarExtent): Add a direction aware method for getting the scrollbar size.
(WebCore):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Use crossAxisScrollbarExtent.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/cross-axis-scrollbar-expected.html: Added.
* css3/flexbox/cross-axis-scrollbar.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.h


Added Paths

trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html
trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar.html




Diff

Modified: trunk/LayoutTests/ChangeLog (106128 => 106129)

--- trunk/LayoutTests/ChangeLog	2012-01-27 18:11:49 UTC (rev 106128)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 18:12:05 UTC (rev 106129)
@@ -1,3 +1,13 @@
+2012-01-27  Tony Chang  t...@chromium.org
+
+flexbox scrollbars don't take flex-direction into account
+https://bugs.webkit.org/show_bug.cgi?id=70772
+
+Reviewed by Darin Adler.
+
+* css3/flexbox/cross-axis-scrollbar-expected.html: Added.
+* css3/flexbox/cross-axis-scrollbar.html: Added.
+
 2012-01-27  Zan Dobersek  zandober...@gmail.com
 
 REGRESSION (r106036-r106050): 12 tests failing on GTK Linux 64-bit Debug


Added: trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html (0 => 106129)

--- trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html	2012-01-27 18:12:05 UTC (rev 106129)
@@ -0,0 +1,71 @@
+!DOCTYPE html
+html
+head
+style
+body {
+margin: 0;
+}
+
+.testcase {
+position: absolute;
+}
+
+.testcase div {
+background-color: green;
+}
+/style
+/head
+body
+This test passes if no red is showing.
+
+div style=position: relative; background-color: transparent;
+
+div class=testcase style=top:0; left: 0
+div style=width: 100px; height: 50px/div
+div style=width: 100px; overflow-x: scroll/div
+div style=width: 100px; height: 10px/div
+/div
+
+div class=testcase style=height: 50px; -webkit-writing-mode: vertical-lr; top: 0; left: 150px
+div style=width: 100px/div
+div style=overflow-y: scroll/div
+div style=width: 10px/div
+/div
+
+div class=testcase style=height: 50px; -webkit-writing-mode: vertical-lr; top: 0; left: 300px
+div style=width: 100px/div
+div style=overflow-y: scroll/div
+div style=width: 10px/div
+/div
+
+div class=testcase style=top: 0; left: 450px
+div style=width: 100px; height: 50px/div
+div style=width: 100px; overflow-x: scroll/div
+div style=width: 100px; height: 10px/div
+/div
+
+div class=testcase style=top: 100px; left: 0
+div style=width: 100px; height: 50px; /div
+div style=width: 100px; overflow-x: scroll/div
+div style=width: 100px; height: 10px/div
+/div
+
+div class=testcase style=height: 50px; -webkit-writing-mode: vertical-lr; top: 100px; left: 150px
+div style=width: 90px; overflow-y: scroll/div
+div style=width: 10px/div
+/div
+
+div class=testcase style=top: 100px; left: 300px
+div style=width: 100px; height: 40px; overflow-x: scroll/div
+div style=width: 100px; height: 10px/div
+/div
+
+div class=testcase style=height: 50px; -webkit-writing-mode: vertical-lr; top: 100px; left: 450px
+div style=width: 100px/div
+div style=overflow-y: scroll/div
+div style=width: 10px/div
+/div
+
+
+/body
+/html


Added: trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar.html (0 => 106129)

--- trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar.html	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar.html	2012-01-27 18:12:05 UTC (rev 106129)
@@ -0,0 +1,141 @@
+!DOCTYPE html
+html
+head
+style
+body {
+margin: 0;
+}
+
+.flexbox {
+display: -webkit-flexbox;
+background-color: red;
+}
+
+.vertical-rl {
+-webkit-writing-mode: vertical-rl;
+}
+
+.vertical-lr {
+-webkit-writing-mode: vertical-lr;
+}
+
+.column {
+-webkit-flex-direction: column;
+}
+
+.column  div {
+background-color: green;
+width: 100px;
+height: 10px;
+}
+
+.row  div {
+background-color: green;
+width: -webkit-flex(1);
+height:

[webkit-changes] [106130] trunk/Source/WebCore

2012-01-27 Thread inferno

Title: [106130] trunk/Source/WebCore








Revision 106130
Author infe...@chromium.org
Date 2012-01-27 10:19:20 -0800 (Fri, 27 Jan 2012)


Log Message
Crash in DocumentLoader::detachFromFrame.
https://bugs.webkit.org/show_bug.cgi?id=62764

Reviewed by Brady Eidson.

r105556 didn't fix the crash because canceling the
main resource loader blows away both the current
document loader and frame underneath. Both protectors
are also used in stopLoading() when m_mainResourceLoader-cancel()
is called. Also, tested the fix under ASAN.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::detachFromFrame):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106129 => 106130)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 18:12:05 UTC (rev 106129)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 18:19:20 UTC (rev 106130)
@@ -1,3 +1,19 @@
+2012-01-27  Abhishek Arya  infe...@chromium.org
+
+Crash in DocumentLoader::detachFromFrame.
+https://bugs.webkit.org/show_bug.cgi?id=62764
+
+Reviewed by Brady Eidson.
+
+r105556 didn't fix the crash because canceling the
+main resource loader blows away both the current
+document loader and frame underneath. Both protectors
+are also used in stopLoading() when m_mainResourceLoader-cancel()
+is called. Also, tested the fix under ASAN.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::detachFromFrame):
+
 2012-01-27  Tony Chang  t...@chromium.org
 
 flexbox scrollbars don't take flex-direction into account


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (106129 => 106130)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2012-01-27 18:12:05 UTC (rev 106129)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2012-01-27 18:19:20 UTC (rev 106130)
@@ -405,7 +405,8 @@
 void DocumentLoader::detachFromFrame()
 {
 ASSERT(m_frame);
-RefPtrFrame protector(m_frame);
+RefPtrFrame protectFrame(m_frame);
+RefPtrDocumentLoader protectLoader(this);
 
 // It never makes sense to have a document loader that is detached from its
 // frame have any loads active, so go ahead and kill all the loads.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106131] trunk/LayoutTests

2012-01-27 Thread leviw

Title: [106131] trunk/LayoutTests








Revision 106131
Author le...@chromium.org
Date 2012-01-27 10:24:21 -0800 (Fri, 27 Jan 2012)


Log Message
Layout Test fast/dom/navigator-detached-no-crash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=77227

Unreviewed. Marking fast/dom/navigator-detached-no-crash.html as failing on Chromium
due to a Chromium Web Intents change.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106130 => 106131)

--- trunk/LayoutTests/ChangeLog	2012-01-27 18:19:20 UTC (rev 106130)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 18:24:21 UTC (rev 106131)
@@ -1,3 +1,13 @@
+2012-01-27  Levi Weintraub  le...@chromium.org
+
+Layout Test fast/dom/navigator-detached-no-crash.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=77227
+
+Unreviewed. Marking fast/dom/navigator-detached-no-crash.html as failing on Chromium
+due to a Chromium Web Intents change.
+
+* platform/chromium/test_expectations.txt:
+
 2012-01-27  Tony Chang  t...@chromium.org
 
 flexbox scrollbars don't take flex-direction into account


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106130 => 106131)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-01-27 18:19:20 UTC (rev 106130)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-01-27 18:24:21 UTC (rev 106131)
@@ -103,6 +103,7 @@
 // Currently Web Intents is disabled. Tests pass with the proper
 // build flag turned on.
 BUGGBILLOCK SKIP : webintents = FAIL
+BUGWK77227 : fast/dom/navigator-detached-no-crash.html = TEXT
 
 // -
 // WONTFIX TESTS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106132] trunk/Source/WebKit2

2012-01-27 Thread kov

Title: [106132] trunk/Source/WebKit2








Revision 106132
Author k...@webkit.org
Date 2012-01-27 10:27:45 -0800 (Fri, 27 Jan 2012)


Log Message
[GTK] Sometimes fails to build when using make -j
https://bugs.webkit.org/show_bug.cgi?id=77226

Reviewed by Martin Robinson.

* GNUmakefile.am: use a different name for the scripts used to
generate enum files for WebKitGTK+ and WebKit2GTK+, so they do not
clash;

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am




Diff

Modified: trunk/Source/WebKit2/ChangeLog (106131 => 106132)

--- trunk/Source/WebKit2/ChangeLog	2012-01-27 18:24:21 UTC (rev 106131)
+++ trunk/Source/WebKit2/ChangeLog	2012-01-27 18:27:45 UTC (rev 106132)
@@ -1,3 +1,14 @@
+2012-01-27  Gustavo Noronha Silva  g...@gnome.org
+
+[GTK] Sometimes fails to build when using make -j
+https://bugs.webkit.org/show_bug.cgi?id=77226
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am: use a different name for the scripts used to
+generate enum files for WebKitGTK+ and WebKit2GTK+, so they do not
+clash;
+
 2012-01-27  Jocelyn Turcotte  jocelyn.turco...@nokia.com
 
 Fix overridePreference for WebKitHixie76WebSocketProtocolEnabled in WebKitTestRunner.


Modified: trunk/Source/WebKit2/GNUmakefile.am (106131 => 106132)

--- trunk/Source/WebKit2/GNUmakefile.am	2012-01-27 18:24:21 UTC (rev 106131)
+++ trunk/Source/WebKit2/GNUmakefile.am	2012-01-27 18:27:45 UTC (rev 106132)
@@ -1155,9 +1155,9 @@
 		$(libwebkit2gtkinclude_HEADERS) | \
 		sed 's,web_kit,webkit,' | \
 		sed 's,WEBKIT_TYPE_KIT,WEBKIT_TYPE,' \
-		 xgen-gth \
-	 (cmp -s xgen-gth $(webkit2gtk_built_headers_dir)/WebKitEnumTypes.h || cp xgen-gth $(webkit2gtk_built_headers_dir)/WebKitEnumTypes.h) \
-	 rm -f xgen-gth \
+		 wk2-xgen-gth \
+	 (cmp -s wk2-xgen-gth $(webkit2gtk_built_headers_dir)/WebKitEnumTypes.h || cp wk2-xgen-gth $(webkit2gtk_built_headers_dir)/WebKitEnumTypes.h) \
+	 rm -f wk2-xgen-gth \
 	 echo timestamp  $(@F)
 
 $(GENSOURCES_WEBKIT2)/webkit2gtk/webkit2/WebKitEnumTypes.cpp: $(libwebkit2gtkinclude_HEADERS) $(WebKit2)/GNUmakefile.am
@@ -1179,9 +1179,9 @@
 			--ftail }\n \
 		$(libwebkit2gtkinclude_HEADERS) | \
 		sed 's,web_kit,webkit,' \
-		 xgen-gtc \
-	 cp xgen-gtc $@ \
-	 rm -f xgen-gtc
+		 wk2-xgen-gtc \
+	 cp wk2-xgen-gtc $@ \
+	 rm -f wk2-xgen-gtc
 
 WEBKIT2_MARSHAL_LIST = $(WebKit2)/UIProcess/API/gtk/webkit2marshal.list
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106133] branches/safari-534.54-branch/Source/JavaScriptCore

2012-01-27 Thread mhahnenberg

Title: [106133] branches/safari-534.54-branch/Source/_javascript_Core








Revision 106133
Author mhahnenb...@apple.com
Date 2012-01-27 11:01:03 -0800 (Fri, 27 Jan 2012)


Log Message
2012-01-27  Mark Hahnenberg  mhahnenb...@apple.com

32-bit Windows build fix

Unreviewed build fix

rdar://problem/10742649

* wtf/Atomics.h:

Modified Paths

branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog
branches/safari-534.54-branch/Source/_javascript_Core/wtf/Atomics.h




Diff

Modified: branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog (106132 => 106133)

--- branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog	2012-01-27 18:27:45 UTC (rev 106132)
+++ branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog	2012-01-27 19:01:03 UTC (rev 106133)
@@ -1,3 +1,13 @@
+2012-01-27  Mark Hahnenberg  mhahnenb...@apple.com
+
+32-bit Windows build fix
+
+Unreviewed build fix
+
+rdar://problem/10742649
+
+* wtf/Atomics.h:
+
 2011-01-27  Lucas Forschler  lforsch...@apple.com
 
 Merge 106075


Modified: branches/safari-534.54-branch/Source/_javascript_Core/wtf/Atomics.h (106132 => 106133)

--- branches/safari-534.54-branch/Source/_javascript_Core/wtf/Atomics.h	2012-01-27 18:27:45 UTC (rev 106132)
+++ branches/safari-534.54-branch/Source/_javascript_Core/wtf/Atomics.h	2012-01-27 19:01:03 UTC (rev 106133)
@@ -181,10 +181,12 @@
 #endif // ENABLE(COMPARE_AND_SWAP)
 }
 
+#if CPU(X86_64)
 inline bool weakCompareAndSwap(volatile uintptr_t* location, uintptr_t expected, uintptr_t newValue)
 {
 return weakCompareAndSwap(reinterpret_castvoid*volatile*(location), reinterpret_castvoid*(expected), reinterpret_castvoid*(newValue));
 }
+#endif
 
 } // namespace WTF
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106135] trunk/LayoutTests

2012-01-27 Thread leviw

Title: [106135] trunk/LayoutTests








Revision 106135
Author le...@chromium.org
Date 2012-01-27 11:12:19 -0800 (Fri, 27 Jan 2012)


Log Message
Unreviewed gardening. Updating linux expectations after http://trac.webkit.org/changeset/106108

* platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Added.
* platform/chromium-linux/svg/filters/big-sized-filter-expected.png:
* platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/svg/filters/big-sized-filter-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (106134 => 106135)

--- trunk/LayoutTests/ChangeLog	2012-01-27 19:06:41 UTC (rev 106134)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 19:12:19 UTC (rev 106135)
@@ -1,3 +1,11 @@
+2012-01-27  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Updating linux expectations after http://trac.webkit.org/changeset/106108
+
+* platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Added.
+* platform/chromium-linux/svg/filters/big-sized-filter-expected.png:
+* platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
+
 2012-01-24  Vincent Scheib  sch...@chromium.org
 
 Pointer Lock: Implement pointer interface


Added: trunk/LayoutTests/platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png
___

Added: svn:mime-type

Modified: trunk/LayoutTests/platform/chromium-linux/svg/filters/big-sized-filter-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106136] branches/safari-534.54-branch/Source/JavaScriptCore

2012-01-27 Thread lforschler

Title: [106136] branches/safari-534.54-branch/Source/_javascript_Core








Revision 106136
Author lforsch...@apple.com
Date 2012-01-27 11:20:10 -0800 (Fri, 27 Jan 2012)


Log Message
Merged r103674.

Modified Paths

branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog
branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp
branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp
branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
branches/safari-534.54-branch/Source/_javascript_Core/interpreter/CallFrame.h
branches/safari-534.54-branch/Source/_javascript_Core/interpreter/Register.h
branches/safari-534.54-branch/Source/_javascript_Core/jit/JITCall.cpp
branches/safari-534.54-branch/Source/_javascript_Core/jit/JITCall32_64.cpp




Diff

Modified: branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog (106135 => 106136)

--- branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog	2012-01-27 19:12:19 UTC (rev 106135)
+++ branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog	2012-01-27 19:20:10 UTC (rev 106136)
@@ -10,6 +10,44 @@
 
 2011-01-27  Lucas Forschler  lforsch...@apple.com
 
+Merge 103674
+
+2011-12-24  Filip Pizlo  fpi...@apple.com
+
+The ArgumentCount field in the CallFrame should have its tag left blank for other uses
+https://bugs.webkit.org/show_bug.cgi?id=75199
+rdar://problem/10625105
+rdar://problem/10625106
+
+Reviewed by Oliver Hunt.
+
+* dfg/DFGOSRExitCompiler32_64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* dfg/DFGOSRExitCompiler64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::emitCall):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::emitCall):
+* interpreter/CallFrame.h:
+(JSC::ExecState::argumentCountIncludingThis):
+(JSC::ExecState::setArgumentCountIncludingThis):
+* interpreter/Register.h:
+(JSC::Register::unboxedInt32):
+(JSC::Register::unboxedBoolean):
+(JSC::Register::unboxedCell):
+(JSC::Register::payload):
+(JSC::Register::tag):
+* jit/JITCall.cpp:
+(JSC::JIT::compileOpCall):
+* jit/JITCall32_64.cpp:
+(JSC::JIT::compileLoadVarargs):
+(JSC::JIT::compileOpCall):
+
+2011-01-27  Lucas Forschler  lforsch...@apple.com
+
 Merge 106075
 
 2012-01-26  Oliver Hunt  oli...@apple.com


Modified: branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp (106135 => 106136)

--- branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp	2012-01-27 19:12:19 UTC (rev 106135)
+++ branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp	2012-01-27 19:20:10 UTC (rev 106136)
@@ -572,7 +572,6 @@
 m_jit.store32(AssemblyHelpers::Imm32(JSValue::CellTag), AssemblyHelpers::tagFor((VirtualRegister)(inlineCallFrame-stackOffset + RegisterFile::CallerFrame)));
 m_jit.storePtr(callerFrameGPR, AssemblyHelpers::payloadFor((VirtualRegister)(inlineCallFrame-stackOffset + RegisterFile::CallerFrame)));
 m_jit.storePtr(AssemblyHelpers::TrustedImmPtr(jumpTarget), AssemblyHelpers::payloadFor((VirtualRegister)(inlineCallFrame-stackOffset + RegisterFile::ReturnPC)));
-m_jit.store32(AssemblyHelpers::Imm32(JSValue::Int32Tag), AssemblyHelpers::tagFor((VirtualRegister)(inlineCallFrame-stackOffset + RegisterFile::ArgumentCount)));
 m_jit.store32(AssemblyHelpers::Imm32(inlineCallFrame-arguments.size()), AssemblyHelpers::payloadFor((VirtualRegister)(inlineCallFrame-stackOffset + RegisterFile::ArgumentCount)));
 m_jit.store32(AssemblyHelpers::Imm32(JSValue::CellTag), AssemblyHelpers::tagFor((VirtualRegister)(inlineCallFrame-stackOffset + RegisterFile::Callee)));
 m_jit.storePtr(AssemblyHelpers::TrustedImmPtr(inlineCallFrame-callee.get()), AssemblyHelpers::payloadFor((VirtualRegister)(inlineCallFrame-stackOffset + RegisterFile::Callee)));


Modified: branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp (106135 => 106136)

--- branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp	2012-01-27 19:12:19 UTC (rev 106135)
+++ branches/safari-534.54-branch/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp	2012-01-27 19:20:10 UTC (rev 106136)
@@ -577,7 +577,7 @@

[webkit-changes] [106138] trunk/Source/WebCore

2012-01-27 Thread andersca

Title: [106138] trunk/Source/WebCore








Revision 106138
Author ander...@apple.com
Date 2012-01-27 11:32:43 -0800 (Fri, 27 Jan 2012)


Log Message
When threaded scrolling is enabled for a FrameView, always put scrollbars in layers
https://bugs.webkit.org/show_bug.cgi?id=77232
rdar://problem/10766708

Reviewed by Beth Dakin.

* page/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
* page/ScrollingCoordinator.h:
Add a new helper function.

* rendering/RenderLayerCompositor.cpp:
(WebCore::shouldCompositeOverflowControls):
Make this take a FrameView, check with the scrolling coordinator if the overflow controls should be composited.

(WebCore::RenderLayerCompositor::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerCompositor::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerCompositor::requiresScrollCornerLayer):
Update for the change to make shouldCompositeOverflowControls take a FrameView.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/ScrollingCoordinator.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106137 => 106138)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 19:27:43 UTC (rev 106137)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 19:32:43 UTC (rev 106138)
@@ -1,3 +1,25 @@
+2012-01-27  Anders Carlsson  ander...@apple.com
+
+When threaded scrolling is enabled for a FrameView, always put scrollbars in layers
+https://bugs.webkit.org/show_bug.cgi?id=77232
+rdar://problem/10766708
+
+Reviewed by Beth Dakin.
+
+* page/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
+* page/ScrollingCoordinator.h:
+Add a new helper function.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::shouldCompositeOverflowControls):
+Make this take a FrameView, check with the scrolling coordinator if the overflow controls should be composited.
+
+(WebCore::RenderLayerCompositor::requiresHorizontalScrollbarLayer):
+(WebCore::RenderLayerCompositor::requiresVerticalScrollbarLayer):
+(WebCore::RenderLayerCompositor::requiresScrollCornerLayer):
+Update for the change to make shouldCompositeOverflowControls take a FrameView.
+
 2012-01-24  Vincent Scheib  sch...@chromium.org
 
 Pointer Lock: Implement pointer interface


Modified: trunk/Source/WebCore/page/ScrollingCoordinator.cpp (106137 => 106138)

--- trunk/Source/WebCore/page/ScrollingCoordinator.cpp	2012-01-27 19:27:43 UTC (rev 106137)
+++ trunk/Source/WebCore/page/ScrollingCoordinator.cpp	2012-01-27 19:32:43 UTC (rev 106138)
@@ -62,6 +62,18 @@
 m_page = 0;
 }
 
+bool ScrollingCoordinator::coordinatesScrollingForFrameView(FrameView* frameView) const
+{
+ASSERT(isMainThread());
+ASSERT(m_page);
+
+// We currently only handle the main frame.
+if (frameView-frame() != m_page-mainFrame())
+return false;
+
+return true;
+}
+
 void ScrollingCoordinator::syncFrameViewGeometry(FrameView* frameView)
 {
 ASSERT(isMainThread());


Modified: trunk/Source/WebCore/page/ScrollingCoordinator.h (106137 => 106138)

--- trunk/Source/WebCore/page/ScrollingCoordinator.h	2012-01-27 19:27:43 UTC (rev 106137)
+++ trunk/Source/WebCore/page/ScrollingCoordinator.h	2012-01-27 19:32:43 UTC (rev 106138)
@@ -56,6 +56,9 @@
 
 void pageDestroyed();
 
+// Return whether this scrolling coordinator handles scrolling for the given frame view.
+bool coordinatesScrollingForFrameView(FrameView*) const;
+
 // Should be called whenever the scroll layer for the given frame view changes.
 void frameViewScrollLayerDidChange(FrameView*, const GraphicsLayer*);
 


Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (106137 => 106138)

--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2012-01-27 19:27:43 UTC (rev 106137)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2012-01-27 19:32:43 UTC (rev 106138)
@@ -1677,10 +1677,18 @@
 return true;
 }
 
-static bool shouldCompositeOverflowControls(ScrollView* view)
+static bool shouldCompositeOverflowControls(FrameView* view)
 {
 if (view-platformWidget())
 return false;
+
+#if ENABLE(THREADED_SCROLLING)
+if (Page* page = view-frame()-page()) {
+if (ScrollingCoordinator* scrollingCoordinator = page-scrollingCoordinator())
+return scrollingCoordinator-coordinatesScrollingForFrameView(view);
+}
+#endif
+
 #if !PLATFORM(CHROMIUM)
 if (!view-hasOverlayScrollbars())
 return false;
@@ -1690,19 +1698,19 @@
 
 bool RenderLayerCompositor::requiresHorizontalScrollbarLayer() const
 {
-ScrollView* view = m_renderView-frameView();
+FrameView* view = m_renderView-frameView();
 return shouldCompositeOverflowControls(view)  view-horizontalScrollbar();
 }
 
 bool

[webkit-changes] [106139] trunk

2012-01-27 Thread adachan

Title: [106139] trunk








Revision 106139
Author adac...@apple.com
Date 2012-01-27 11:40:22 -0800 (Fri, 27 Jan 2012)


Log Message
Source/WebKit2: Add API to get the parent frame in WKBundleFrameRef
https://bugs.webkit.org/show_bug.cgi?id=77161

Reviewed by Anders Carlsson.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetParentFrame): Get the parent frame by calling WebFrame::parentFrame().
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::parentFrame): Return null if the frame does not have an owner element.
Otherwise, return the owner element's frame.
* WebProcess/WebPage/WebFrame.h:

Tools: Add test for WKBundleFrameGetParentFrame().
https://bugs.webkit.org/show_bug.cgi?id=77161

Reviewed by Anders Carlsson.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
* TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
Make sure the check is successful.
* TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
(TestWebKitAPI):
(ParentFrameTest):
(TestWebKitAPI::ParentFrameTest::ParentFrameTest):
(TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
to the test controller.
(TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.h
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (106138 => 106139)

--- trunk/Source/WebKit2/ChangeLog	2012-01-27 19:32:43 UTC (rev 106138)
+++ trunk/Source/WebKit2/ChangeLog	2012-01-27 19:40:22 UTC (rev 106139)
@@ -1,3 +1,18 @@
+2012-01-27  Ada Chan  adac...@apple.com
+
+Add API to get the parent frame in WKBundleFrameRef
+https://bugs.webkit.org/show_bug.cgi?id=77161
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
+(WKBundleFrameGetParentFrame): Get the parent frame by calling WebFrame::parentFrame().
+* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::parentFrame): Return null if the frame does not have an owner element.
+Otherwise, return the owner element's frame.
+* WebProcess/WebPage/WebFrame.h:
+
 2012-01-27  Gustavo Noronha Silva  g...@gnome.org
 
 [GTK] Sometimes fails to build when using make -j


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp (106138 => 106139)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp	2012-01-27 19:32:43 UTC (rev 106138)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp	2012-01-27 19:40:22 UTC (rev 106139)
@@ -47,6 +47,11 @@
 return toImpl(frameRef)-isMainFrame();
 }
 
+WKBundleFrameRef WKBundleFrameGetParentFrame(WKBundleFrameRef frameRef)
+{
+return toAPI(toImpl(frameRef)-parentFrame());
+}
+
 WKURLRef WKBundleFrameCopyURL(WKBundleFrameRef frameRef)
 {
 return toCopiedURLAPI(toImpl(frameRef)-url());


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.h (106138 => 106139)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.h	2012-01-27 19:32:43 UTC (rev 106138)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.h	2012-01-27 19:40:22 UTC (rev 106139)
@@ -38,6 +38,7 @@
 WK_EXPORT WKTypeID WKBundleFrameGetTypeID();
 
 WK_EXPORT bool WKBundleFrameIsMainFrame(WKBundleFrameRef frame);
+WK_EXPORT WKBundleFrameRef WKBundleFrameGetParentFrame(WKBundleFrameRef frame);
 WK_EXPORT WKArrayRef WKBundleFrameCopyChildFrames(WKBundleFrameRef frame);
 
 WK_EXPORT WKStringRef WKBundleFrameCopyName(WKBundleFrameRef frame);


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp (106138 => 106139)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp	2012-01-27 19:32:43 UTC (rev 106138)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp	2012-01-27 19:40:22 UTC (rev 106139)
@@ -357,6 +357,14 @@
 return m_coreFrame-document()-documentElement()-innerText();
 }
 
+WebFrame* WebFrame::parentFrame() const
+{
+if

[webkit-changes] [106140] trunk/Source/WebCore

2012-01-27 Thread haraken

Title: [106140] trunk/Source/WebCore








Revision 106140
Author hara...@chromium.org
Date 2012-01-27 12:00:34 -0800 (Fri, 27 Jan 2012)


Log Message
Support the [Supplemental] IDL for constants
https://bugs.webkit.org/show_bug.cgi?id=77228

Reviewed by Adam Barth.

We have supported the [Supplemental] IDL for attributes and methods.
This patch supports it for constants.

Test: bindings/scripts/test/TestSupplemental.idl

* bindings/scripts/generate-bindings.pl:
Supported [Supplemental] constants.
Updated some comments.

* bindings/scripts/test/TestSupplemental.idl:
Added test cases for [Supplemental] constants.

* bindings/scripts/test/CPP/WebDOMTestInterface.h: Updated the test results.
* bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
(WebCore::JSTestInterfacePrototype::getOwnPropertySlot):
(WebCore::JSTestInterfacePrototype::getOwnPropertyDescriptor):
(WebCore):
(WebCore::jsTestInterfaceSUPPLEMENTAL_CONSTANT1):
(WebCore::jsTestInterfaceSUPPLEMENTAL_CONSTANT2):
* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
(WebCore):
* bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::ConfigureV8TestInterfaceTemplate):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/generate-bindings.pl
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/TestSupplemental.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106139 => 106140)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 19:40:22 UTC (rev 106139)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 20:00:34 UTC (rev 106140)
@@ -1,3 +1,35 @@
+2012-01-27  Kentaro Hara  hara...@chromium.org
+
+Support the [Supplemental] IDL for constants
+https://bugs.webkit.org/show_bug.cgi?id=77228
+
+Reviewed by Adam Barth.
+
+We have supported the [Supplemental] IDL for attributes and methods.
+This patch supports it for constants.
+
+Test: bindings/scripts/test/TestSupplemental.idl
+
+* bindings/scripts/generate-bindings.pl:
+Supported [Supplemental] constants.
+Updated some comments.
+
+* bindings/scripts/test/TestSupplemental.idl:
+Added test cases for [Supplemental] constants.
+
+* bindings/scripts/test/CPP/WebDOMTestInterface.h: Updated the test results.
+* bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
+(WebCore::JSTestInterfacePrototype::getOwnPropertySlot):
+(WebCore::JSTestInterfacePrototype::getOwnPropertyDescriptor):
+(WebCore):
+(WebCore::jsTestInterfaceSUPPLEMENTAL_CONSTANT1):
+(WebCore::jsTestInterfaceSUPPLEMENTAL_CONSTANT2):
+* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
+(WebCore):
+* bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
+* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
+(WebCore::ConfigureV8TestInterfaceTemplate):
+
 2012-01-27  Anders Carlsson  ander...@apple.com
 
 When threaded scrolling is enabled for a FrameView, always put scrollbars in layers


Modified: trunk/Source/WebCore/bindings/scripts/generate-bindings.pl (106139 => 106140)

--- trunk/Source/WebCore/bindings/scripts/generate-bindings.pl	2012-01-27 19:40:22 UTC (rev 106139)
+++ trunk/Source/WebCore/bindings/scripts/generate-bindings.pl	2012-01-27 20:00:34 UTC (rev 106140)
@@ -148,6 +148,7 @@
 }
 die Not found an interface ${targetInterfaceName} in ${targetInterfaceName}.idl. unless defined $targetDataNode;
 
+# Support [Supplemental] for attributes.
 foreach my $attribute (@{$dataNode-attributes}) {
 # Record that this attribute is implemented by $interfaceName.
 $attribute-signature-extendedAttributes-{ImplementedBy} = $interfaceName;
@@ -160,17 +161,31 @@
 push(@{$targetDataNode-attributes}, $attribute);
 }
 
+# Support [Supplemental] for methods.
 foreach my $function (@{$dataNode-functions}) {
-# Record that this attribute is implemented by $interfaceName.
+# Record that this method is implemented by $interfaceName.
 $function-signature-extendedAttributes-{ImplementedBy} = $interfaceName;
 
-# Add interface-wide extended attributes to each attribute.
+# Add interface-wide extended attributes to each method.
 foreach my $extendedAttributeName (keys %{$dataNode-extendedAttributes}) {
 next if ($extendedAttributeName eq Supplemental);

[webkit-changes] [106141] trunk/LayoutTests

2012-01-27 Thread leviw

Title: [106141] trunk/LayoutTests








Revision 106141
Author le...@chromium.org
Date 2012-01-27 12:04:46 -0800 (Fri, 27 Jan 2012)


Log Message
Update chromium-specific expectation for navigator-detached-no-crash layout test to include startActivity
https://bugs.webkit.org/show_bug.cgi?id=77230

Unreviewed gardening.

Patch by Greg Billock gbill...@google.com on 2012-01-27

* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106140 => 106141)

--- trunk/LayoutTests/ChangeLog	2012-01-27 20:00:34 UTC (rev 106140)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 20:04:46 UTC (rev 106141)
@@ -1,3 +1,13 @@
+2012-01-27  Greg Billock  gbill...@google.com
+
+Update chromium-specific expectation for navigator-detached-no-crash layout test to include startActivity
+https://bugs.webkit.org/show_bug.cgi?id=77230
+
+Unreviewed gardening.
+
+* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
+* platform/chromium/test_expectations.txt:
+
 2012-01-27  Levi Weintraub  le...@chromium.org
 
 Unreviewed gardening. Updating linux expectations after http://trac.webkit.org/changeset/106108


Modified: trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt (106140 => 106141)

--- trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt	2012-01-27 20:00:34 UTC (rev 106140)
+++ trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt	2012-01-27 20:04:46 UTC (rev 106141)
@@ -14,6 +14,7 @@
 navigator.product is OK
 navigator.productSub is OK
 navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
+navigator.startActivity() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
@@ -33,6 +34,7 @@
 navigator.product is OK
 navigator.productSub is OK
 navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
+navigator.startActivity() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106140 => 106141)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-01-27 20:00:34 UTC (rev 106140)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-01-27 20:04:46 UTC (rev 106141)
@@ -103,7 +103,6 @@
 // Currently Web Intents is disabled. Tests pass with the proper
 // build flag turned on.
 BUGGBILLOCK SKIP : webintents = FAIL
-BUGWK77227 : fast/dom/navigator-detached-no-crash.html = TEXT
 
 // -
 // WONTFIX TESTS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106143] trunk/Source/JavaScriptCore

2012-01-27 Thread morrita

Title: [106143] trunk/Source/_javascript_Core








Revision 106143
Author morr...@google.com
Date 2012-01-27 12:53:27 -0800 (Fri, 27 Jan 2012)


Log Message
[WTF] WTFString.h has some extra JS_EXPORT_PRIVATEs
https://bugs.webkit.org/show_bug.cgi?id=77113

Reviewed by Darin Adler.

* wtf/text/WTFString.h: Removed some WTF_EXPORT_PRIVATE attributes which we don't need to export.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/text/WTFString.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106142 => 106143)

--- trunk/Source/_javascript_Core/ChangeLog	2012-01-27 20:15:20 UTC (rev 106142)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-27 20:53:27 UTC (rev 106143)
@@ -1,3 +1,12 @@
+2012-01-27  MORITA Hajime  morr...@google.com
+
+[WTF] WTFString.h has some extra JS_EXPORT_PRIVATEs
+https://bugs.webkit.org/show_bug.cgi?id=77113
+
+Reviewed by Darin Adler.
+
+* wtf/text/WTFString.h: Removed some WTF_EXPORT_PRIVATE attributes which we don't need to export.
+
 2012-01-27  Zeno Albisser  z...@webkit.org
 
 [Qt][Mac] Build fails after adding ICU support (r105997).


Modified: trunk/Source/_javascript_Core/wtf/text/WTFString.h (106142 => 106143)

--- trunk/Source/_javascript_Core/wtf/text/WTFString.h	2012-01-27 20:15:20 UTC (rev 106142)
+++ trunk/Source/_javascript_Core/wtf/text/WTFString.h	2012-01-27 20:53:27 UTC (rev 106143)
@@ -62,9 +62,9 @@
 
 // Declarations of string operations
 
-WTF_EXPORT_PRIVATE int charactersToIntStrict(const LChar*, size_t, bool* ok = 0, int base = 10);
+int charactersToIntStrict(const LChar*, size_t, bool* ok = 0, int base = 10);
 WTF_EXPORT_PRIVATE int charactersToIntStrict(const UChar*, size_t, bool* ok = 0, int base = 10);
-WTF_EXPORT_PRIVATE unsigned charactersToUIntStrict(const LChar*, size_t, bool* ok = 0, int base = 10);
+unsigned charactersToUIntStrict(const LChar*, size_t, bool* ok = 0, int base = 10);
 WTF_EXPORT_PRIVATE unsigned charactersToUIntStrict(const UChar*, size_t, bool* ok = 0, int base = 10);
 int64_t charactersToInt64Strict(const LChar*, size_t, bool* ok = 0, int base = 10);
 int64_t charactersToInt64Strict(const UChar*, size_t, bool* ok = 0, int base = 10);
@@ -84,7 +84,7 @@
 intptr_t charactersToIntPtr(const LChar*, size_t, bool* ok = 0); // ignores trailing garbage
 intptr_t charactersToIntPtr(const UChar*, size_t, bool* ok = 0); // ignores trailing garbage
 
-WTF_EXPORT_PRIVATE double charactersToDouble(const LChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);
+double charactersToDouble(const LChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);
 WTF_EXPORT_PRIVATE double charactersToDouble(const UChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);
 float charactersToFloat(const LChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);
 WTF_EXPORT_PRIVATE float charactersToFloat(const UChar*, size_t, bool* ok = 0, bool* didReadNumber = 0);
@@ -187,7 +187,7 @@
 return m_impl-characters()[index];
 }
 
-WTF_EXPORT_PRIVATE static String number(short);
+static String number(short);
 WTF_EXPORT_PRIVATE static String number(unsigned short);
 WTF_EXPORT_PRIVATE static String number(int);
 WTF_EXPORT_PRIVATE static String number(unsigned);
@@ -301,8 +301,8 @@
 WTF_EXPORT_PRIVATE int toIntStrict(bool* ok = 0, int base = 10) const;
 WTF_EXPORT_PRIVATE unsigned toUIntStrict(bool* ok = 0, int base = 10) const;
 WTF_EXPORT_PRIVATE int64_t toInt64Strict(bool* ok = 0, int base = 10) const;
-WTF_EXPORT_PRIVATE uint64_t toUInt64Strict(bool* ok = 0, int base = 10) const;
-WTF_EXPORT_PRIVATE intptr_t toIntPtrStrict(bool* ok = 0, int base = 10) const;
+uint64_t toUInt64Strict(bool* ok = 0, int base = 10) const;
+intptr_t toIntPtrStrict(bool* ok = 0, int base = 10) const;
 
 WTF_EXPORT_PRIVATE int toInt(bool* ok = 0) const;
 WTF_EXPORT_PRIVATE unsigned toUInt(bool* ok = 0) const;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106144] branches/safari-534.54-branch/Source/WebCore

2012-01-27 Thread lforschler

Title: [106144] branches/safari-534.54-branch/Source/WebCore








Revision 106144
Author lforsch...@apple.com
Date 2012-01-27 13:27:15 -0800 (Fri, 27 Jan 2012)


Log Message
Merged r106130.

Modified Paths

branches/safari-534.54-branch/Source/WebCore/ChangeLog
branches/safari-534.54-branch/Source/WebCore/loader/DocumentLoader.cpp




Diff

Modified: branches/safari-534.54-branch/Source/WebCore/ChangeLog (106143 => 106144)

--- branches/safari-534.54-branch/Source/WebCore/ChangeLog	2012-01-27 20:53:27 UTC (rev 106143)
+++ branches/safari-534.54-branch/Source/WebCore/ChangeLog	2012-01-27 21:27:15 UTC (rev 106144)
@@ -1,3 +1,23 @@
+2011-01-27  Lucas Forschler  lforsch...@apple.com
+
+Merge 106130
+
+2012-01-27  Abhishek Arya  infe...@chromium.org
+
+Crash in DocumentLoader::detachFromFrame.
+https://bugs.webkit.org/show_bug.cgi?id=62764
+
+Reviewed by Brady Eidson.
+
+r105556 didn't fix the crash because canceling the
+main resource loader blows away both the current
+document loader and frame underneath. Both protectors
+are also used in stopLoading() when m_mainResourceLoader-cancel()
+is called. Also, tested the fix under ASAN.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::detachFromFrame):
+
 2012-01-25  Mark Rowe  mr...@apple.com
 
 Merge r105942.


Modified: branches/safari-534.54-branch/Source/WebCore/loader/DocumentLoader.cpp (106143 => 106144)

--- branches/safari-534.54-branch/Source/WebCore/loader/DocumentLoader.cpp	2012-01-27 20:53:27 UTC (rev 106143)
+++ branches/safari-534.54-branch/Source/WebCore/loader/DocumentLoader.cpp	2012-01-27 21:27:15 UTC (rev 106144)
@@ -409,7 +409,8 @@
 void DocumentLoader::detachFromFrame()
 {
 ASSERT(m_frame);
-RefPtrFrame protector(m_frame);
+RefPtrFrame protectFrame(m_frame);
+RefPtrDocumentLoader protectLoader(this);
 
 // It never makes sense to have a document loader that is detached from its
 // frame have any loads active, so go ahead and kill all the loads.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106145] trunk/Source/WebKit2

2012-01-27 Thread mrobinson

Title: [106145] trunk/Source/WebKit2








Revision 106145
Author mrobin...@webkit.org
Date 2012-01-27 13:47:51 -0800 (Fri, 27 Jan 2012)


Log Message
Fix a compilation warning in a WebKit2 GTK+ API test.

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/tests/TestBackForwardList.cpp:
(testBackForwardListLimitAndCache): Use an int instead of size_t
because we want to print them as ints and do subtraction on them.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (106144 => 106145)

--- trunk/Source/WebKit2/ChangeLog	2012-01-27 21:27:15 UTC (rev 106144)
+++ trunk/Source/WebKit2/ChangeLog	2012-01-27 21:47:51 UTC (rev 106145)
@@ -1,5 +1,15 @@
 2012-01-27  Martin Robinson  mrobin...@igalia.com
 
+Fix a compilation warning in a WebKit2 GTK+ API test.
+
+Reviewed by Gustavo Noronha Silva.
+
+* UIProcess/API/gtk/tests/TestBackForwardList.cpp:
+(testBackForwardListLimitAndCache): Use an int instead of size_t
+because we want to print them as ints and do subtraction on them.
+
+2012-01-27  Martin Robinson  mrobin...@igalia.com
+
 [GTK] [WK2] Implement the policy client
 https://bugs.webkit.org/show_bug.cgi?id=76343
 


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp (106144 => 106145)

--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp	2012-01-27 21:27:15 UTC (rev 106144)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp	2012-01-27 21:47:51 UTC (rev 106145)
@@ -27,7 +27,7 @@
 #include webkit2/webkit2.h
 
 // Back forward list limit is 100 by default.
-static const size_t kBackForwardListLimit = 100;
+static const int kBackForwardListLimit = 100;
 
 static WebKitTestServer* kServer;
 
@@ -240,7 +240,7 @@
 
 static void testBackForwardListLimitAndCache(BackForwardListTest* test, gconstpointer)
 {
-for (size_t i = 0; i  kBackForwardListLimit; i++) {
+for (int i = 0; i  kBackForwardListLimit; i++) {
 GOwnPtrchar path(g_strdup_printf(/Page%d, i));
 test-m_changedFlags = BackForwardListTest::CurrentItem | BackForwardListTest::AddedItem;
 test-loadURI(kServer-getURIForPath(path.get()).data());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106146] trunk

2012-01-27 Thread fsamuel

Title: [106146] trunk








Revision 106146
Author fsam...@chromium.org
Date 2012-01-27 13:52:00 -0800 (Fri, 27 Jan 2012)


Log Message
Rename shouldLayoutFixedElementsRelativeToFrame and make it a setting
https://bugs.webkit.org/show_bug.cgi?id=76459

Reviewed by Darin Fisher.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

This should be a setting because it is independent of a particular frame and
should be preserved even if the mainframe changes.

Renamed (set)ShouldLayoutFixedElementsRelativeToFrame to
(set)FixedElementsLayoutRelativeToFrame due to the connotation
the word should may have in this context: If set,
position:fixed elements will ALWAYS be laid out relative to the frame.

* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
(WebCore::FrameView::fixedElementsLayoutRelativeToFrame):
(WebCore):
* page/FrameView.h:
(FrameView):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setFixedElementsLayoutRelativeToFrame):
(WebCore):
* page/Settings.h:
(Settings):
(WebCore::Settings::fixedElementsLayoutRelativeToFrame):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::fixedElementLaysOutRelativeToFrame):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
* rendering/RenderBox.h:
(RenderBox):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setFixedElementsLayoutRelativeToFrame):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit/chromium:

* public/WebSettings.h:
():
* public/WebView.h:
(WebView):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setFixedElementsLayoutRelativeToFrame):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* fast/repaint/fixed-in-page-scale.html:
* fast/repaint/fixed-right-bottom-in-page-scale.html:
* fast/repaint/fixed-right-in-page-scale.html:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/repaint/fixed-in-page-scale.html
trunk/LayoutTests/fast/repaint/fixed-right-bottom-in-page-scale.html
trunk/LayoutTests/fast/repaint/fixed-right-in-page-scale.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def
trunk/Source/WebKit2/win/WebKit2CFLite.def
trunk/Source/autotools/symbols.filter




Diff

Modified: trunk/ChangeLog (106145 => 106146)

--- trunk/ChangeLog	2012-01-27 21:47:51 UTC (rev 106145)
+++ trunk/ChangeLog	2012-01-27 21:52:00 UTC (rev 106146)
@@ -1,3 +1,12 @@
+2012-01-27  Fady Samuel  fsam...@chromium.org
+
+Rename shouldLayoutFixedElementsRelativeToFrame and make it a setting
+https://bugs.webkit.org/show_bug.cgi?id=76459
+
+Reviewed by Darin Fisher.
+
+* Source/autotools/symbols.filter:
+
 2012-01-26  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Add basic printing support to WebKit2


Modified: trunk/LayoutTests/ChangeLog (106145 => 106146)

--- trunk/LayoutTests/ChangeLog	2012-01-27 21:47:51 UTC (rev 106145)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 21:52:00 UTC (rev 106146)
@@ -1,3 +1,14 @@
+2012-01-27  Fady Samuel  fsam...@chromium.org
+
+Rename shouldLayoutFixedElementsRelativeToFrame and make it a setting
+https://bugs.webkit.org/show_bug.cgi?id=76459
+
+Reviewed by Darin Fisher.
+
+* fast/repaint/fixed-in-page-scale.html:
+* fast/repaint/fixed-right-bottom-in-page-scale.html:
+* fast/repaint/fixed-right-in-page-scale.html:
+
 2012-01-27  Greg Billock  gbill...@google.com
 
 Update chromium-specific expectation for navigator-detached-no-crash layout test to include startActivity


Modified: trunk/LayoutTests/fast/repaint/fixed-in-page-scale.html (106145 => 106146)

--- trunk/LayoutTests/fast/repaint/fixed-in-page-scale.html	2012-01-27 21:47:51 UTC (rev 106145)
+++ trunk/LayoutTests/fast/repaint/fixed-in-page-scale.html	2012-01-27 21:52:00 UTC (rev 106146)
@@ -9,7 +9,7 @@
 script
   window.enablePixelTesting

[webkit-changes] [106148] trunk/LayoutTests

2012-01-27 Thread leviw

Title: [106148] trunk/LayoutTests








Revision 106148
Author le...@chromium.org
Date 2012-01-27 14:05:43 -0800 (Fri, 27 Jan 2012)


Log Message
Unreviewed gardening. Adding new windows image expectations for css3/flexbox/cross-axis-scrollbar.html

* platform/chromium-win/css3/flexbox/cross-axis-scrollbar-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-win/css3/flexbox/cross-axis-scrollbar-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (106147 => 106148)

--- trunk/LayoutTests/ChangeLog	2012-01-27 22:03:37 UTC (rev 106147)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 22:05:43 UTC (rev 106148)
@@ -1,3 +1,9 @@
+2012-01-27  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Adding new windows image expectations for css3/flexbox/cross-axis-scrollbar.html
+
+* platform/chromium-win/css3/flexbox/cross-axis-scrollbar-expected.png: Added.
+
 2012-01-27  Fady Samuel  fsam...@chromium.org
 
 Rename shouldLayoutFixedElementsRelativeToFrame and make it a setting


Added: trunk/LayoutTests/platform/chromium-win/css3/flexbox/cross-axis-scrollbar-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/css3/flexbox/cross-axis-scrollbar-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106149] branches/safari-534.54-branch/Source/JavaScriptCore/interpreter/ AbstractPC.cpp

2012-01-27 Thread lforschler

Title: [106149] branches/safari-534.54-branch/Source/_javascript_Core/interpreter/AbstractPC.cpp








Revision 106149
Author lforsch...@apple.com
Date 2012-01-27 14:05:56 -0800 (Fri, 27 Jan 2012)


Log Message
build fix

Modified Paths

branches/safari-534.54-branch/Source/_javascript_Core/interpreter/AbstractPC.cpp




Diff

Modified: branches/safari-534.54-branch/Source/_javascript_Core/interpreter/AbstractPC.cpp (106148 => 106149)

--- branches/safari-534.54-branch/Source/_javascript_Core/interpreter/AbstractPC.cpp	2012-01-27 22:05:43 UTC (rev 106148)
+++ branches/safari-534.54-branch/Source/_javascript_Core/interpreter/AbstractPC.cpp	2012-01-27 22:05:56 UTC (rev 106149)
@@ -35,6 +35,7 @@
 
 AbstractPC::AbstractPC(JSGlobalData globalData, ExecState* exec)
 {
+UNUSED_PARAM(globalData);
 #if ENABLE(JIT)
 if (globalData.canUseJIT()) {
 m_pointer = exec-returnPC().value();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106150] trunk

2012-01-27 Thread commit-queue

Title: [106150] trunk








Revision 106150
Author commit-qu...@webkit.org
Date 2012-01-27 14:26:13 -0800 (Fri, 27 Jan 2012)


Log Message
Crash in updateFirstLetter() from unnecessary anonymous block
https://bugs.webkit.org/show_bug.cgi?id=72675

Patch by Ken Buchanan ke...@chromium.org on 2012-01-27
Reviewed by David Hyatt.

Source/WebCore:

There was a problem with anonymous blocks not getting removed when
their only block flow siblings are removed if they also have non-block
flow first-letter siblings (i.e. floats). This patch modifies
RenderBlock::removeChild() to look for this situation and strip out
unnecessary anonymous container blocks if it occurs.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild): Added
* rendering/RenderBlock.h:
(WebCore::RenderBlock::collapseAnonymousBoxChild): Added

LayoutTests:

Adding tests that cause a div to be removed from between a floating
first-letter block and its remaining text. If the anonymous block is
removed as an immediate consequence of the div removal, this shouldn't
crash.

* fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt: Added
* fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html: Added
* fast/css-generated-content/positioned-div-with-floating-after-content-crash-expected.txt: Added
* fast/css-generated-content/positioned-div-with-floating-after-content-crash.html: Added
* fast/css-generated-content/resources/positioned-div-with-floating-after-content-crash-frame1.html: Added
* fast/css-generated-content/resources/positioned-div-with-floating-after-content-crash-frame2.html: Added

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h


Added Paths

trunk/LayoutTests/fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt
trunk/LayoutTests/fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html
trunk/LayoutTests/fast/css-generated-content/positioned-div-with-floating-after-content-crash-expected.txt
trunk/LayoutTests/fast/css-generated-content/positioned-div-with-floating-after-content-crash.html
trunk/LayoutTests/fast/css-generated-content/resources/positioned-div-with-floating-after-content-crash-frame1.html
trunk/LayoutTests/fast/css-generated-content/resources/positioned-div-with-floating-after-content-crash-frame2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (106149 => 106150)

--- trunk/LayoutTests/ChangeLog	2012-01-27 22:05:56 UTC (rev 106149)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 22:26:13 UTC (rev 106150)
@@ -1,3 +1,22 @@
+2012-01-27  Ken Buchanan  ke...@chromium.org
+
+Crash in updateFirstLetter() from unnecessary anonymous block
+https://bugs.webkit.org/show_bug.cgi?id=72675
+
+Reviewed by David Hyatt.
+
+Adding tests that cause a div to be removed from between a floating
+first-letter block and its remaining text. If the anonymous block is
+removed as an immediate consequence of the div removal, this shouldn't
+crash.
+
+* fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt: Added
+* fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html: Added
+* fast/css-generated-content/positioned-div-with-floating-after-content-crash-expected.txt: Added
+* fast/css-generated-content/positioned-div-with-floating-after-content-crash.html: Added
+* fast/css-generated-content/resources/positioned-div-with-floating-after-content-crash-frame1.html: Added
+* fast/css-generated-content/resources/positioned-div-with-floating-after-content-crash-frame2.html: Added
+
 2012-01-27  Levi Weintraub  le...@chromium.org
 
 Unreviewed gardening. Adding new windows image expectations for css3/flexbox/cross-axis-scrollbar.html


Added: trunk/LayoutTests/fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt (0 => 106150)

--- trunk/LayoutTests/fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt	2012-01-27 22:26:13 UTC (rev 106150)
@@ -0,0 +1 @@
+PASS if no crash or assert


Added: trunk/LayoutTests/fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html (0 => 106150)

--- trunk/LayoutTests/fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html	(rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html	2012-01-27 22:26:13 UTC (rev 106150)
@@ -0,0 +1,34 @@
+style
+.inlineFL::first-letter { overflow: visible; }
+.absolutePosition { position: absolute; }
+.floatFL:first-letter { float:

[webkit-changes] [106151] trunk/Source/JavaScriptCore

2012-01-27 Thread morrita

Title: [106151] trunk/Source/_javascript_Core








Revision 106151
Author morr...@google.com
Date 2012-01-27 14:40:53 -0800 (Fri, 27 Jan 2012)


Log Message
[JSC] Some JS_EXPORTDATA may not be necessary.
https://bugs.webkit.org/show_bug.cgi?id=77145

Reviewed by Darin Adler.

Removed JS_EXPORTDATA attributes whose attributing symbols are
not exported on Mac port.

* runtime/ExceptionHelpers.h:
(InterruptedExecutionError):
* runtime/JSBoundFunction.h:
(JSBoundFunction):
* runtime/RegExp.h:
(RegExp):
* runtime/RegExpMatchesArray.h:
(RegExpMatchesArray):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ExceptionHelpers.h
trunk/Source/_javascript_Core/runtime/JSBoundFunction.h
trunk/Source/_javascript_Core/runtime/RegExp.h
trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106150 => 106151)

--- trunk/Source/_javascript_Core/ChangeLog	2012-01-27 22:26:13 UTC (rev 106150)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-27 22:40:53 UTC (rev 106151)
@@ -1,5 +1,24 @@
 2012-01-27  MORITA Hajime  morr...@google.com
 
+[JSC] Some JS_EXPORTDATA may not be necessary.
+https://bugs.webkit.org/show_bug.cgi?id=77145
+
+Reviewed by Darin Adler.
+
+Removed JS_EXPORTDATA attributes whose attributing symbols are
+not exported on Mac port.
+
+* runtime/ExceptionHelpers.h:
+(InterruptedExecutionError):
+* runtime/JSBoundFunction.h:
+(JSBoundFunction):
+* runtime/RegExp.h:
+(RegExp):
+* runtime/RegExpMatchesArray.h:
+(RegExpMatchesArray):
+
+2012-01-27  MORITA Hajime  morr...@google.com
+
 [WTF] WTFString.h has some extra JS_EXPORT_PRIVATEs
 https://bugs.webkit.org/show_bug.cgi?id=77113
 


Modified: trunk/Source/_javascript_Core/runtime/ExceptionHelpers.h (106150 => 106151)

--- trunk/Source/_javascript_Core/runtime/ExceptionHelpers.h	2012-01-27 22:26:13 UTC (rev 106150)
+++ trunk/Source/_javascript_Core/runtime/ExceptionHelpers.h	2012-01-27 22:40:53 UTC (rev 106151)
@@ -79,7 +79,7 @@
 return Structure::create(globalData, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), s_info);
 }
 
-static JS_EXPORTDATA const ClassInfo s_info;
+static const ClassInfo s_info;
 };
 
 class TerminatedExecutionError : public JSNonFinalObject {


Modified: trunk/Source/_javascript_Core/runtime/JSBoundFunction.h (106150 => 106151)

--- trunk/Source/_javascript_Core/runtime/JSBoundFunction.h	2012-01-27 22:26:13 UTC (rev 106150)
+++ trunk/Source/_javascript_Core/runtime/JSBoundFunction.h	2012-01-27 22:40:53 UTC (rev 106151)
@@ -51,7 +51,7 @@
 return Structure::create(globalData, globalObject, prototype, TypeInfo(JSFunctionType, StructureFlags), s_info); 
 }
 
-static JS_EXPORTDATA const ClassInfo s_info;
+static const ClassInfo s_info;
 
 protected:
 const static unsigned StructureFlags = OverridesHasInstance | OverridesVisitChildren | Base::StructureFlags;


Modified: trunk/Source/_javascript_Core/runtime/RegExp.h (106150 => 106151)

--- trunk/Source/_javascript_Core/runtime/RegExp.h	2012-01-27 22:26:13 UTC (rev 106150)
+++ trunk/Source/_javascript_Core/runtime/RegExp.h	2012-01-27 22:40:53 UTC (rev 106151)
@@ -72,7 +72,7 @@
 return Structure::create(globalData, globalObject, prototype, TypeInfo(LeafType, 0), s_info);
 }
 
-static JS_EXPORTDATA const ClassInfo s_info;
+static const ClassInfo s_info;
 
 RegExpKey key() { return RegExpKey(m_flags, m_patternString); }
 


Modified: trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.h (106150 => 106151)

--- trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.h	2012-01-27 22:26:13 UTC (rev 106150)
+++ trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.h	2012-01-27 22:40:53 UTC (rev 106151)
@@ -39,7 +39,7 @@
 }
 static void destroy(JSCell*);
 
-static JS_EXPORTDATA const ClassInfo s_info;
+static const ClassInfo s_info;
 
 static Structure* createStructure(JSGlobalData globalData, JSGlobalObject* globalObject, JSValue prototype)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106152] tags/Safari-534.54.12/

2012-01-27 Thread lforschler

Title: [106152] tags/Safari-534.54.12/








Revision 106152
Author lforsch...@apple.com
Date 2012-01-27 14:42:05 -0800 (Fri, 27 Jan 2012)


Log Message
New tag.

Added Paths

tags/Safari-534.54.12/




Diff

Property changes: tags/Safari-534.54.12



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106153] trunk/Source/JavaScriptCore

2012-01-27 Thread commit-queue

Title: [106153] trunk/Source/_javascript_Core








Revision 106153
Author commit-qu...@webkit.org
Date 2012-01-27 14:43:34 -0800 (Fri, 27 Jan 2012)


Log Message
[JSC] Asm-originated symbols should be marked as hidden
https://bugs.webkit.org/show_bug.cgi?id=77150

Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-01-27
Reviewed by Filip Pizlo.

* dfg/DFGOperations.cpp: The HIDE_SYMBOLS macros were present in the CPU(ARM) preprocessor branches,
but they were missing in the CPU(X86) and the CPU(X86_64) cases.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106152 => 106153)

--- trunk/Source/_javascript_Core/ChangeLog	2012-01-27 22:42:05 UTC (rev 106152)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-27 22:43:34 UTC (rev 106153)
@@ -1,3 +1,13 @@
+2012-01-27  Simon Hausmann  simon.hausm...@nokia.com
+
+[JSC] Asm-originated symbols should be marked as hidden
+https://bugs.webkit.org/show_bug.cgi?id=77150
+
+Reviewed by Filip Pizlo.
+
+* dfg/DFGOperations.cpp: The HIDE_SYMBOLS macros were present in the CPU(ARM) preprocessor branches,
+but they were missing in the CPU(X86) and the CPU(X86_64) cases.
+
 2012-01-27  MORITA Hajime  morr...@google.com
 
 [JSC] Some JS_EXPORTDATA may not be necessary.


Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (106152 => 106153)

--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2012-01-27 22:42:05 UTC (rev 106152)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2012-01-27 22:43:34 UTC (rev 106153)
@@ -43,6 +43,7 @@
 #define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, register) \
 asm( \
 .globl  SYMBOL_STRING(function) \n \
+HIDE_SYMBOL(function) \n \
 SYMBOL_STRING(function) : \n \
 mov (%rsp), % STRINGIZE(register) \n \
 jmp  SYMBOL_STRING_RELOCATION(function##WithReturnAddress) \n \
@@ -57,6 +58,7 @@
 #define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, offset) \
 asm( \
 .globl  SYMBOL_STRING(function) \n \
+HIDE_SYMBOL(function) \n \
 SYMBOL_STRING(function) : \n \
 mov (%esp), %eax\n \
 mov %eax,  STRINGIZE(offset) (%esp)\n \
@@ -677,6 +679,7 @@
 #if CPU(X86_64)
 asm (
 .globl  SYMBOL_STRING(getHostCallReturnValue) \n
+HIDE_SYMBOL(getHostCallReturnValue) \n
 SYMBOL_STRING(getHostCallReturnValue) : \n
 mov -40(%r13), %r13\n
 mov %r13, %rdi\n
@@ -685,6 +688,7 @@
 #elif CPU(X86)
 asm (
 .globl  SYMBOL_STRING(getHostCallReturnValue) \n
+HIDE_SYMBOL(getHostCallReturnValue) \n
 SYMBOL_STRING(getHostCallReturnValue) : \n
 mov -40(%edi), %edi\n
 mov %edi, 4(%esp)\n






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106154] trunk/Source/WebCore

2012-01-27 Thread benjamin

Title: [106154] trunk/Source/WebCore








Revision 106154
Author benja...@webkit.org
Date 2012-01-27 14:47:39 -0800 (Fri, 27 Jan 2012)


Log Message
Speed up the prefix matching of cssPropertyName()
https://bugs.webkit.org/show_bug.cgi?id=77158

Patch by Benjamin Poulain bpoul...@apple.com on 2012-01-27
Reviewed by Geoffrey Garen.

This patch improves the performance by:
-not checking the PropertyName with all 7 prefix
 (now, in the worse case, 2 prefixes are checked)
-avoiding the conversion 8bits-16bits by using String::operator[]
 instead of ::characters()

To avoid checking every prefix, the code branch based on the first
characters of the propertyName.
The remaining of the prefix is checked character by characters like before.

When accessing CSS property, this gives a 13% improvement when there is no prefix.
There is no performance regression for the matching of prefix, including for the first one
of the previous matching code (css).

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
():
(WebCore::matchesCSSPropertyNamePrefix):
(WebCore):
(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyName):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106153 => 106154)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 22:43:34 UTC (rev 106153)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 22:47:39 UTC (rev 106154)
@@ -1,3 +1,31 @@
+2012-01-27  Benjamin Poulain  bpoul...@apple.com
+
+Speed up the prefix matching of cssPropertyName()
+https://bugs.webkit.org/show_bug.cgi?id=77158
+
+Reviewed by Geoffrey Garen.
+
+This patch improves the performance by:
+-not checking the PropertyName with all 7 prefix
+ (now, in the worse case, 2 prefixes are checked)
+-avoiding the conversion 8bits-16bits by using String::operator[]
+ instead of ::characters()
+
+To avoid checking every prefix, the code branch based on the first
+characters of the propertyName.
+The remaining of the prefix is checked character by characters like before.
+
+When accessing CSS property, this gives a 13% improvement when there is no prefix.
+There is no performance regression for the matching of prefix, including for the first one
+of the previous matching code (css).
+
+* bindings/js/JSCSSStyleDeclarationCustom.cpp:
+():
+(WebCore::matchesCSSPropertyNamePrefix):
+(WebCore):
+(WebCore::getCSSPropertyNamePrefix):
+(WebCore::cssPropertyName):
+
 2012-01-27  Ken Buchanan  ke...@chromium.org
 
 Crash in updateFirstLetter() from unnecessary anonymous block


Modified: trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp (106153 => 106154)

--- trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp	2012-01-27 22:43:34 UTC (rev 106153)
+++ trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp	2012-01-27 22:47:39 UTC (rev 106154)
@@ -56,33 +56,87 @@
 visitor.addOpaqueRoot(root(thisObject-impl()));
 }
 
-// Check for a CSS prefix.
-// Passed prefix is all lowercase.
-// First character of the prefix within the property name may be upper or lowercase.
-// Other characters in the prefix within the property name must be lowercase.
-// The prefix within the property name must be followed by a capital letter.
-static bool hasCSSPropertyNamePrefix(const Identifier propertyName, const char* prefix)
+enum PropertyNamePrefix
 {
+PropertyNamePrefixNone,
+PropertyNamePrefixCSS,
+PropertyNamePrefixPixel,
+PropertyNamePrefixPos,
+PropertyNamePrefixApple,
+PropertyNamePrefixEpub,
+PropertyNamePrefixKHTML,
+PropertyNamePrefixWebKit
+};
+
+templatesize_t prefixCStringLength
+static inline bool matchesCSSPropertyNamePrefix(const StringImpl propertyName, const char (prefix)[prefixCStringLength])
+{
+size_t prefixLength = prefixCStringLength - 1;
+
+ASSERT(toASCIILower(propertyName[0]) == prefix[0]);
+const size_t offset = 1;
+
 #ifndef NDEBUG
-ASSERT(*prefix);
-for (const char* p = prefix; *p; ++p)
-ASSERT(isASCIILower(*p));
+for (size_t i = 0; i  prefixLength; ++i)
+ASSERT(isASCIILower(prefix[i]));
+ASSERT(!prefix[prefixLength]);
 ASSERT(propertyName.length());
 #endif
 
-if (toASCIILower(propertyName.characters()[0]) != prefix[0])
+// The prefix within the property name must be followed by a capital letter.
+// Other characters in the prefix within the property name must be lowercase.
+if (propertyName.length()  (prefixLength + 1))
 return false;
 
-unsigned length = propertyName.length();
-for (unsigned i = 1; i  length; ++i) {
-if (!prefix[i])
-return isASCIIUpper(propertyName.characters()[i]);
-if (propertyName.characters()[i] != prefix[i])
+for (size_t i = offset; i  prefixLength; ++i) {
+if

[webkit-changes] [106155] trunk/Source/WebCore

2012-01-27 Thread mrobinson

Title: [106155] trunk/Source/WebCore








Revision 106155
Author mrobin...@webkit.org
Date 2012-01-27 14:53:44 -0800 (Fri, 27 Jan 2012)


Log Message
Fix a warning in the GTK+ build.

Reviewed by Gustavo Noronha Silva.

No new tests. This should not change behavior.

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformStart): Use reinterpet_cast to convert X11 Windows into void pointers.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106154 => 106155)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 22:47:39 UTC (rev 106154)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 22:53:44 UTC (rev 106155)
@@ -1,3 +1,14 @@
+2012-01-27  Martin Robinson  mrobin...@igalia.com
+
+Fix a warning in the GTK+ build.
+
+Reviewed by Gustavo Noronha Silva.
+
+No new tests. This should not change behavior.
+
+* plugins/gtk/PluginViewGtk.cpp:
+(WebCore::PluginView::platformStart): Use reinterpet_cast to convert X11 Windows into void pointers.
+
 2012-01-27  Benjamin Poulain  bpoul...@apple.com
 
 Speed up the prefix matching of cssPropertyName()


Modified: trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp (106154 => 106155)

--- trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp	2012-01-27 22:47:39 UTC (rev 106154)
+++ trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp	2012-01-27 22:53:44 UTC (rev 106155)
@@ -905,14 +905,14 @@
 if (m_needsXEmbed) {
 GtkWidget* widget = platformPluginWidget();
 gtk_widget_realize(widget);
-m_npWindow.window = (void*)gtk_socket_get_id(GTK_SOCKET(platformPluginWidget()));
+m_npWindow.window = reinterpret_castvoid*(gtk_socket_get_id(GTK_SOCKET(platformPluginWidget(;
 GdkWindow* window = gtk_widget_get_window(widget);
 ws-display = GDK_WINDOW_XDISPLAY(window);
 ws-visual = GDK_VISUAL_XVISUAL(gdk_window_get_visual(window));
 ws-depth = gdk_visual_get_depth(gdk_window_get_visual(window));
 ws-colormap = XCreateColormap(ws-display, GDK_ROOT_WINDOW(), ws-visual, AllocNone);
 } else {
-m_npWindow.window = (void*)GTK_XTBIN(platformPluginWidget())-xtwindow;
+m_npWindow.window = reinterpret_castvoid*((GTK_XTBIN(platformPluginWidget())-xtwindow));
 ws-display = GTK_XTBIN(platformPluginWidget())-xtdisplay;
 ws-visual = GTK_XTBIN(platformPluginWidget())-xtclient.xtvisual;
 ws-depth = GTK_XTBIN(platformPluginWidget())-xtclient.xtdepth;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106156] trunk/Source/WebCore

2012-01-27 Thread eric . carlson

Title: [106156] trunk/Source/WebCore








Revision 106156
Author eric.carl...@apple.com
Date 2012-01-27 14:56:23 -0800 (Fri, 27 Jan 2012)


Log Message
Added the GenericEventQueue class in order to generalize asynchronous
event dispatching in HTMLMediaElement.

In order to support asynchronous events dispatched by HTMLTrackElement
there is a need for a generalized implementation of an event queue to
be used for both HTMLMediaElement and Text Tracks.

https://bugs.webkit.org/show_bug.cgi?id=76110

Patch by Victor Carbune vic...@rosedu.org on 2012-01-27
Reviewed by Eric Carlson.

No new tests. No new functionality, only refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

* dom/GenericEventQueue.cpp: Added. Implements the abstract class EventQueue.
(WebCore::GenericEventQueue::GenericEventQueue):
(WebCore::GenericEventQueue::~GenericEventQueue):
(WebCore::GenericEventQueue::enqueueEvent): Append an event to the current
pending event list.
(WebCore::GenericEventQueue::cancelEvent): Removes an event from the current
pending event list.
(WebCore::GenericEventQueue::timerFired): Callback method when the timer fires.
Dispatches all events that are currently pending.
(WebCore::GenericEventQueue::close): Closes the event queue such that it cannot
be used anymore.
(WebCore::GenericEventQueue::cancelAllEvents): Removes all pending events.
(WebCore::GenericEventQueue::hasPendingEvents): True if there are pending events.
* dom/GenericEventQueue.h: Added.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::scheduleEvent): Refactored method to enqueue
the scheduled event on the GenericEventQueue instance.
(WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks): Ditto.
(WebCore::HTMLMediaElement::hasPendingActivity): Ditto.
(WebCore::HTMLMediaElement::dispatchEvent): This method is overriden
to keep an evidence when a canPlay event is fired.
* html/HTMLMediaElement.h:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h


Added Paths

trunk/Source/WebCore/dom/GenericEventQueue.cpp
trunk/Source/WebCore/dom/GenericEventQueue.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (106155 => 106156)

--- trunk/Source/WebCore/CMakeLists.txt	2012-01-27 22:53:44 UTC (rev 106155)
+++ trunk/Source/WebCore/CMakeLists.txt	2012-01-27 22:56:23 UTC (rev 106156)
@@ -557,6 +557,7 @@
 dom/EventTarget.cpp
 dom/ExceptionBase.cpp
 dom/ExceptionCodePlaceholder.cpp
+dom/GenericEventQueue.cpp
 dom/IconURL.cpp
 dom/KeyboardEvent.cpp
 dom/MessageChannel.cpp


Modified: trunk/Source/WebCore/ChangeLog (106155 => 106156)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 22:53:44 UTC (rev 106155)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 22:56:23 UTC (rev 106156)
@@ -1,3 +1,50 @@
+2012-01-27  Victor Carbune  vic...@rosedu.org
+
+Added the GenericEventQueue class in order to generalize asynchronous
+event dispatching in HTMLMediaElement.
+
+In order to support asynchronous events dispatched by HTMLTrackElement
+there is a need for a generalized implementation of an event queue to
+be used for both HTMLMediaElement and Text Tracks.
+
+https://bugs.webkit.org/show_bug.cgi?id=76110
+
+Reviewed by Eric Carlson.
+
+No new tests. No new functionality, only refactoring.
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* Target.pri:
+* WebCore.gypi:
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+
+* dom/GenericEventQueue.cpp: Added. Implements the abstract class EventQueue.
+(WebCore::GenericEventQueue::GenericEventQueue):
+(WebCore::GenericEventQueue::~GenericEventQueue):
+(WebCore::GenericEventQueue::enqueueEvent): Append an event to the current
+pending event list.
+(WebCore::GenericEventQueue::cancelEvent): Removes an event from the current
+pending event list.
+(WebCore::GenericEventQueue::timerFired): Callback method when the timer fires.
+Dispatches all events that are currently pending.
+(WebCore::GenericEventQueue::close): Closes the event queue such that it cannot
+be used anymore.
+(WebCore::GenericEventQueue::cancelAllEvents): Removes all pending events.
+(WebCore::GenericEventQueue::hasPendingEvents): True if there are pending events.
+* dom/GenericEventQueue.h: Added.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::HTMLMediaElement):
+

[webkit-changes] [106157] trunk/Source/WebCore

2012-01-27 Thread kevino

Title: [106157] trunk/Source/WebCore








Revision 106157
Author kev...@webkit.org
Date 2012-01-27 15:06:33 -0800 (Fri, 27 Jan 2012)


Log Message
[wx] Unreviewed. Build fix, add missing header.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGImageBufferTools.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106156 => 106157)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 22:56:23 UTC (rev 106156)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 23:06:33 UTC (rev 106157)
@@ -1,3 +1,9 @@
+2012-01-27  Kevin Ollivier  kev...@theolliviers.com
+
+[wx] Unreviewed. Build fix, add missing header.
+
+* rendering/svg/SVGImageBufferTools.h:
+
 2012-01-27  Victor Carbune  vic...@rosedu.org
 
 Added the GenericEventQueue class in order to generalize asynchronous


Modified: trunk/Source/WebCore/rendering/svg/SVGImageBufferTools.h (106156 => 106157)

--- trunk/Source/WebCore/rendering/svg/SVGImageBufferTools.h	2012-01-27 22:56:23 UTC (rev 106156)
+++ trunk/Source/WebCore/rendering/svg/SVGImageBufferTools.h	2012-01-27 23:06:33 UTC (rev 106157)
@@ -22,6 +22,7 @@
 
 #if ENABLE(SVG)
 #include ImageBuffer.h
+#include IntRect.h
 #include wtf/Noncopyable.h
 
 namespace WebCore {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106158] trunk/Source/WebCore

2012-01-27 Thread commit-queue

Title: [106158] trunk/Source/WebCore








Revision 106158
Author commit-qu...@webkit.org
Date 2012-01-27 15:13:59 -0800 (Fri, 27 Jan 2012)


Log Message
[chromium] CCLayerTreeHostImpl minor code cleanup
https://bugs.webkit.org/show_bug.cgi?id=77181

Fix a typo in comments and group functions properly.
Replace duplicated content size code with function.

Patch by Tien-Ren Chen trc...@chromium.org on 2012-01-27
Reviewed by James Robinson.

No new tests. No change in behavior.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106157 => 106158)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 23:06:33 UTC (rev 106157)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 23:13:59 UTC (rev 106158)
@@ -1,3 +1,23 @@
+2012-01-27  Tien-Ren Chen  trc...@chromium.org
+
+[chromium] CCLayerTreeHostImpl minor code cleanup
+https://bugs.webkit.org/show_bug.cgi?id=77181
+
+Fix a typo in comments and group functions properly.
+Replace duplicated content size code with function.
+
+Reviewed by James Robinson.
+
+No new tests. No change in behavior.
+
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
+(WebCore::CCLayerTreeHostImpl::contentSize):
+(WebCore):
+(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+(CCLayerTreeHostImpl):
+
 2012-01-27  Kevin Ollivier  kev...@theolliviers.com
 
 [wx] Unreviewed. Build fix, add missing header.


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (106157 => 106158)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp	2012-01-27 23:06:33 UTC (rev 106157)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp	2012-01-27 23:13:59 UTC (rev 106158)
@@ -122,7 +122,7 @@
 IntSize scrollTotal = toSize(m_scrollLayerImpl-scrollPosition() + m_scrollLayerImpl-scrollDelta());
 scrollTotal.scale(m_pageScaleDelta);
 float scaleTotal = m_pageScale * m_pageScaleDelta;
-IntSize scaledContentSize = m_scrollLayerImpl-children()[0]-contentBounds();
+IntSize scaledContentSize = contentSize();
 scaledContentSize.scale(m_pageScaleDelta);
 
 m_pageScaleAnimation = CCPageScaleAnimation::create(scrollTotal, scaleTotal, m_viewportSize, scaledContentSize, startTimeMs);
@@ -244,6 +244,15 @@
 passes[i]-optimizeQuads();
 }
 
+IntSize CCLayerTreeHostImpl::contentSize() const
+{
+// TODO(aelias): Hardcoding the first child here is weird. Think of
+// a cleaner way to get the contentBounds on the Impl side.
+if (!m_scrollLayerImpl || m_scrollLayerImpl-children().isEmpty())
+return IntSize();
+return m_scrollLayerImpl-children()[0]-contentBounds();
+}
+
 void CCLayerTreeHostImpl::drawLayers()
 {
 TRACE_EVENT(CCLayerTreeHostImpl::drawLayers, this, 0);
@@ -440,9 +449,7 @@
 FloatSize viewBounds = m_viewportSize;
 viewBounds.scale(1 / m_pageScaleDelta);
 
-// TODO(aelias): Hardcoding the first child here is weird. Think of
-// a cleaner way to get the contentBounds on the Impl side.
-IntSize maxScroll = m_scrollLayerImpl-children()[0]-contentBounds() - expandedIntSize(viewBounds);
+IntSize maxScroll = contentSize() - expandedIntSize(viewBounds);
 // The viewport may be larger than the contents in some cases, such as
 // having a vertical scrollbar but no horizontal overflow.
 maxScroll.clampNegativeToZero();


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h (106157 => 106158)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h	2012-01-27 23:06:33 UTC (rev 106157)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h	2012-01-27 23:13:59 UTC (rev 106158)
@@ -61,7 +61,7 @@
 static PassOwnPtrCCLayerTreeHostImpl create(const CCSettings, CCLayerTreeHostImplClient*);
 virtual ~CCLayerTreeHostImpl();
 
-// CCInputHandlerTarget implementation
+// CCInputHandlerClient implementation
 virtual void setNeedsRedraw();
 virtual CCInputHandlerClient::ScrollStatus scrollBegin(const IntPoint);
 virtual void scrollBy(const IntSize);
@@ -70,6 +70,7 @@
 virtual void pinchGestureBegin();
 virtual void pinchGestureUpdate(float, const IntPoint);
 virtual void pinchGestureEnd();
+virtual void

[webkit-changes] [106159] trunk/Source/WebCore/ChangeLog

2012-01-27 Thread mrobinson

Title: [106159] trunk/Source/WebCore/ChangeLog








Revision 106159
Author mrobin...@webkit.org
Date 2012-01-27 15:22:11 -0800 (Fri, 27 Jan 2012)


Log Message
Fix a warning in the GTK+ build.

Reviewed by Gustavo Noronha Silva.

No new tests. This should not change behavior.

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformStart): Use reinterpet_cast to convert X11 Windows into void pointers.

Modified Paths

trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (106158 => 106159)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 23:13:59 UTC (rev 106158)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 23:22:11 UTC (rev 106159)
@@ -1,3 +1,14 @@
+2012-01-27  Martin Robinson  mrobin...@igalia.com
+
+Fix a warning in the GTK+ build.
+
+Reviewed by Gustavo Noronha Silva.
+
+No new tests. This should not change behavior.
+
+* plugins/gtk/PluginViewGtk.cpp:
+(WebCore::PluginView::platformStart): Use reinterpet_cast to convert X11 Windows into void pointers.
+
 2012-01-27  Tien-Ren Chen  trc...@chromium.org
 
 [chromium] CCLayerTreeHostImpl minor code cleanup






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106160] trunk/Source

2012-01-27 Thread enne

Title: [106160] trunk/Source








Revision 106160
Author e...@google.com
Date 2012-01-27 15:23:51 -0800 (Fri, 27 Jan 2012)


Log Message
[chromium] Don't ever skip drawing the non-composited content layer
https://bugs.webkit.org/show_bug.cgi?id=77236

Reviewed by James Robinson.

Source/WebCore:

Since the root layer has its textures potentially reserved last in a
front-to-back iteration, don't ever skip drawing it if we can't
reserve its textures. Instead, checkerboard and draw background color
quads instead to fill the viewport. This behavior is tied to the
backgroundFillsViewport setting.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::reset):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):

Source/WebKit/chromium:

This is a tiny fix. If the non-composited content layer never gets
painted, then the background color never gets set and it is just
opaque black.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTilingData.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106159 => 106160)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 23:22:11 UTC (rev 106159)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 23:23:51 UTC (rev 106160)
@@ -1,3 +1,23 @@
+2012-01-27  Adrienne Walker  e...@google.com
+
+[chromium] Don't ever skip drawing the non-composited content layer
+https://bugs.webkit.org/show_bug.cgi?id=77236
+
+Reviewed by James Robinson.
+
+Since the root layer has its textures potentially reserved last in a
+front-to-back iteration, don't ever skip drawing it if we can't
+reserve its textures. Instead, checkerboard and draw background color
+quads instead to fill the viewport. This behavior is tied to the
+backgroundFillsViewport setting.
+
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::prepareToUpdateTiles):
+* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
+(WebCore::CCLayerTilingData::reset):
+* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
+(WebCore::CCTiledLayerImpl::appendQuads):
+
 2012-01-27  Martin Robinson  mrobin...@igalia.com
 
 Fix a warning in the GTK+ build.


Modified: trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp (106159 => 106160)

--- trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp	2012-01-27 23:22:11 UTC (rev 106159)
+++ trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp	2012-01-27 23:23:51 UTC (rev 106160)
@@ -392,7 +392,10 @@
 if (!tile-managedTexture()-reserve(m_tiler-tileSize(), m_textureFormat)) {
 m_skipsIdlePaint = true;
 if (!idle) {
-m_skipsDraw = true;
+// If the background covers the viewport, always draw this
+// layer so that checkerboarded tiles will still draw.
+if (!backgroundCoversViewport())
+m_skipsDraw = true;
 cleanupResources();
 }
 return;


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTilingData.cpp (106159 => 106160)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTilingData.cpp	2012-01-27 23:22:11 UTC (rev 106159)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTilingData.cpp	2012-01-27 23:23:51 UTC (rev 106160)
@@ -96,7 +96,6 @@
 void CCLayerTilingData::reset()
 {
 m_tiles.clear();
-m_tilingData.setTotalSize(0, 0);
 }
 
 void CCLayerTilingData::layerRectToTileIndices(const IntRect layerRect, int left, int top, int right, int bottom) const


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp (106159 => 106160)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp	2012-01-27 23:22:11 UTC (rev 106159)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp	2012-01-27 23:23:51 UTC (rev 106160)
@@ -127,7 +127,7 @@
 
 appendGutterQuads(quadList, sharedQuadState);
 
-if (!m_tiler || m_tiler-isEmpty() || layerRect.isEmpty())
+if (!m_tiler || !m_tiler-numTiles() || layerRect.isEmpty())
 return;
 
 int left, top, right, bottom;


Modified: trunk/Source/WebKit/chromium/ChangeLog (106159 => 106160)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-01-27 23:22:11 UTC (rev 106159)
+++ trunk/Source/WebKit/chromium/ChangeLog

[webkit-changes] [106161] trunk/Source/JavaScriptCore

2012-01-27 Thread morrita

Title: [106161] trunk/Source/_javascript_Core








Revision 106161
Author morr...@google.com
Date 2012-01-27 15:28:19 -0800 (Fri, 27 Jan 2012)


Log Message
[JSC] ThunkGenerators.cpp should hide its asm-defined symbols
https://bugs.webkit.org/show_bug.cgi?id=77244

Reviewed by Filip Pizlo.

* jit/ThunkGenerators.cpp: Added HIDE_SYMBOLS()
* wtf/InlineASM.h: Moved some duplicated macros from ThunkGenerators.cpp

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp
trunk/Source/_javascript_Core/wtf/InlineASM.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106160 => 106161)

--- trunk/Source/_javascript_Core/ChangeLog	2012-01-27 23:23:51 UTC (rev 106160)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-27 23:28:19 UTC (rev 106161)
@@ -1,3 +1,13 @@
+2012-01-27  Hajime Morita  morr...@google.com
+
+[JSC] ThunkGenerators.cpp should hide its asm-defined symbols
+https://bugs.webkit.org/show_bug.cgi?id=77244
+
+Reviewed by Filip Pizlo.
+
+* jit/ThunkGenerators.cpp: Added HIDE_SYMBOLS()
+* wtf/InlineASM.h: Moved some duplicated macros from ThunkGenerators.cpp
+
 2012-01-27  Simon Hausmann  simon.hausm...@nokia.com
 
 [JSC] Asm-originated symbols should be marked as hidden


Modified: trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp (106160 => 106161)

--- trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp	2012-01-27 23:23:51 UTC (rev 106160)
+++ trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp	2012-01-27 23:28:19 UTC (rev 106161)
@@ -27,8 +27,9 @@
 #include ThunkGenerators.h
 
 #include CodeBlock.h
-#include wtf/text/StringImpl.h
+#include InlineASM.h
 #include SpecializedThunkJIT.h
+#include wtf/text/StringImpl.h
 
 #if ENABLE(JIT)
 
@@ -111,21 +112,6 @@
 return jit.finalize(*globalData, globalData-jitStubs-ctiNativeCall());
 }
 
-#if OS(DARWIN) || (OS(WINDOWS)  CPU(X86))
-#define SYMBOL_STRING(name) _ #name
-#else
-#define SYMBOL_STRING(name) #name
-#endif
-
-#if (OS(LINUX) || OS(FREEBSD))  CPU(X86_64)
-#define SYMBOL_STRING_RELOCATION(name) #name @plt
-#elif OS(DARWIN) || (CPU(X86_64)  COMPILER(MINGW)  !GCC_VERSION_AT_LEAST(4, 5, 0))
-#define SYMBOL_STRING_RELOCATION(name) _ #name
-#elif CPU(X86)  COMPILER(MINGW)
-#define SYMBOL_STRING_RELOCATION(name) @ #name @4
-#else
-#define SYMBOL_STRING_RELOCATION(name) #name
-#endif
 
 #define UnaryDoubleOpWrapper(function) function##Wrapper
 enum MathThunkCallingConvention { };
@@ -147,6 +133,7 @@
 asm( \
 .text\n \
 .globl  SYMBOL_STRING(function##Thunk) \n \
+HIDE_SYMBOL(function##Thunk) \n \
 SYMBOL_STRING(function##Thunk) : \n \
 call  SYMBOL_STRING_RELOCATION(function) \n \
 ret\n \
@@ -161,6 +148,7 @@
 asm( \
 .text\n \
 .globl  SYMBOL_STRING(function##Thunk) \n \
+HIDE_SYMBOL(function##Thunk) \n \
 SYMBOL_STRING(function##Thunk) : \n \
 subl $8, %esp\n \
 movsd %xmm0, (%esp) \n \


Modified: trunk/Source/_javascript_Core/wtf/InlineASM.h (106160 => 106161)

--- trunk/Source/_javascript_Core/wtf/InlineASM.h	2012-01-27 23:23:51 UTC (rev 106160)
+++ trunk/Source/_javascript_Core/wtf/InlineASM.h	2012-01-27 23:28:19 UTC (rev 106161)
@@ -44,6 +44,8 @@
 
 #if (OS(LINUX) || OS(FREEBSD))  CPU(X86_64)
 #define SYMBOL_STRING_RELOCATION(name) #name @plt
+#elif OS(DARWIN) || (CPU(X86_64)  COMPILER(MINGW)  !GCC_VERSION_AT_LEAST(4, 5, 0))
+#define SYMBOL_STRING_RELOCATION(name) _ #name
 #elif CPU(X86)  COMPILER(MINGW)
 #define SYMBOL_STRING_RELOCATION(name) @ #name @4
 #else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106162] trunk

2012-01-27 Thread commit-queue

Title: [106162] trunk








Revision 106162
Author commit-qu...@webkit.org
Date 2012-01-27 15:31:35 -0800 (Fri, 27 Jan 2012)


Log Message
Round time to sample frame
https://bugs.webkit.org/show_bug.cgi?id=76659

Source/WebCore:

Three major changes:

1. Modify timeToSampleFrame to round the time to the sample frame
and add support for Visual Studio to round the time in the same
way as on gcc. (The issue is that Visual Studio uses x87
instructions with 80-bit floats.)  This makes Visual Studio more
consistent with the results with gcc.

2. Change the current time variable from keeping time in seconds
to keeping time in sample frames.  This minimizes rounding except
when needed for the _javascript_ API.

3. Update AudioBufferSourceNode::process to use samples (instead
of time) as much as possible to reduce round-off effects.

Patch by Raymond Toy r...@google.com on 2012-01-27
Reviewed by Kenneth Russell.

Tests: Added note-grain-on test to exercise precise
timing. Existing tests (gain and audiobuffersource-playbackrate)
also cover some of these changes, and the equalpower panner test is
modified to enable the tests for the offset of the impulses.

* platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::timeToSampleFrame): Moved from
AudioParamTimeLine and slightly modified, and updated to round
operations consistently.  Add special flags for Visual Studio to
generate code with rounding that is consistent with gcc.
* platform/audio/AudioUtilities.h: Declare new function.
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process): Use new functions to
convert time to sample frame.  Update code to use integer
arithmetic as much as possible.
(WebCore::AudioBufferSourceNode::renderFromBuffer): Use
timeToSampleFrame to convert time to sample frame.
* webaudio/AudioContext.h: Define new currentSample method to get
the current sample.
* webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::provideInput): Use new function to
convert sample frame to time.  Update
* webaudio/AudioDestiationNode.h: Rename m_currentTime to
m_currentSample, add method to return current Sample.  Update
currentTime() method to compute time from the current sample.
* webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): Remove
timeToSampleFrame and use new function in AudioUtilities to
convert time to sample frame.

LayoutTests:

Patch by Raymond Toy r...@google.com on 2012-01-27
Reviewed by Kenneth Russell.

* webaudio/audiobuffersource-playbackrate-expected.wav: Updated.
* webaudio/gain-expected.wav: Updated.
* webaudio/resources/audio-testing.js:
(timeToSampleFrame): Utility to convert time to sample frame, to
be consistent with the actual webaudio implementation.
* webaudio/resources/panner-model-testing.js:
(checkResult): Enable the tests for the offset of the impulses.
Also fix a bug in printing the time where the max error was
found.
* webaudio/note-grain-on-timing.html: New test for noteGrainOn.
Also tests the new currentSample implemenation and
roundToSampleFrame.
* webaudio/note-grain-on-timing-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webaudio/audiobuffersource-playbackrate-expected.wav
trunk/LayoutTests/webaudio/gain-expected.wav
trunk/LayoutTests/webaudio/panner-equalpower-expected.txt
trunk/LayoutTests/webaudio/resources/audio-testing.js
trunk/LayoutTests/webaudio/resources/panner-model-testing.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/AudioUtilities.cpp
trunk/Source/WebCore/platform/audio/AudioUtilities.h
trunk/Source/WebCore/webaudio/AudioBufferSourceNode.cpp
trunk/Source/WebCore/webaudio/AudioContext.h
trunk/Source/WebCore/webaudio/AudioDestinationNode.cpp
trunk/Source/WebCore/webaudio/AudioDestinationNode.h
trunk/Source/WebCore/webaudio/AudioParamTimeline.cpp


Added Paths

trunk/LayoutTests/webaudio/note-grain-on-timing-expected.txt
trunk/LayoutTests/webaudio/note-grain-on-timing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (106161 => 106162)

--- trunk/LayoutTests/ChangeLog	2012-01-27 23:28:19 UTC (rev 106161)
+++ trunk/LayoutTests/ChangeLog	2012-01-27 23:31:35 UTC (rev 106162)
@@ -1,3 +1,24 @@
+2012-01-27  Raymond Toy  r...@google.com
+
+Round time to sample frame
+https://bugs.webkit.org/show_bug.cgi?id=76659
+
+Reviewed by Kenneth Russell.
+
+* webaudio/audiobuffersource-playbackrate-expected.wav: Updated.
+* webaudio/gain-expected.wav: Updated.
+* webaudio/resources/audio-testing.js:
+(timeToSampleFrame): Utility to convert time to sample frame, to
+be consistent with the actual webaudio implementation.
+* webaudio/resources/panner-model-testing.js:
+(checkResult): Enable the tests for the offset of the impulses.
+Also fix a bug in printing the time where the max error was
+found. 
+* webaudio/note-grain-on-timing.html: New test for noteGrainOn.
+Also

[webkit-changes] [106163] trunk/Source/WebCore

2012-01-27 Thread andersca

Title: [106163] trunk/Source/WebCore








Revision 106163
Author ander...@apple.com
Date 2012-01-27 15:34:01 -0800 (Fri, 27 Jan 2012)


Log Message
WebTileLayers should honor the acceleratesDrawing flag
https://bugs.webkit.org/show_bug.cgi?id=77242
rdar://problem/10622128

Reviewed by Dan Bernstein.

* platform/graphics/ca/mac/TileCache.h:
(WebCore::TileCache::acceleratesDrawing):
Add getter.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):
Initialize m_acceleratesDrawing.

(WebCore::TileCache::setAcceleratesDrawing):
Set m_acceleratesDrawing and go through all tile layers and update the flag.

(WebCore::TileCache::createTileLayer):
Call -[CALayer setAcceleratesDrawing:] on the newly created layer.

* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setAcceleratesDrawing:]):
(-[WebTileCacheLayer acceleratesDrawing]):
Call through to the TileCache object.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h
trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm
trunk/Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (106162 => 106163)

--- trunk/Source/WebCore/ChangeLog	2012-01-27 23:31:35 UTC (rev 106162)
+++ trunk/Source/WebCore/ChangeLog	2012-01-27 23:34:01 UTC (rev 106163)
@@ -1,3 +1,30 @@
+2012-01-27  Anders Carlsson  ander...@apple.com
+
+WebTileLayers should honor the acceleratesDrawing flag
+https://bugs.webkit.org/show_bug.cgi?id=77242
+rdar://problem/10622128
+
+Reviewed by Dan Bernstein.
+
+* platform/graphics/ca/mac/TileCache.h:
+(WebCore::TileCache::acceleratesDrawing):
+Add getter.
+
+* platform/graphics/ca/mac/TileCache.mm:
+(WebCore::TileCache::TileCache):
+Initialize m_acceleratesDrawing.
+
+(WebCore::TileCache::setAcceleratesDrawing):
+Set m_acceleratesDrawing and go through all tile layers and update the flag.
+
+(WebCore::TileCache::createTileLayer):
+Call -[CALayer setAcceleratesDrawing:] on the newly created layer.
+
+* platform/graphics/ca/mac/WebTileCacheLayer.mm:
+(-[WebTileCacheLayer setAcceleratesDrawing:]):
+(-[WebTileCacheLayer acceleratesDrawing]):
+Call through to the TileCache object.
+
 2012-01-27  Raymond Toy  r...@google.com
 
 Round time to sample frame


Modified: trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h (106162 => 106163)

--- trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h	2012-01-27 23:31:35 UTC (rev 106162)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h	2012-01-27 23:34:01 UTC (rev 106163)
@@ -52,6 +52,9 @@
 void setNeedsDisplayInRect(const IntRect);
 void drawLayer(WebTileLayer*, CGContextRef);
 
+bool acceleratesDrawing() const { return m_acceleratesDrawing; }
+void setAcceleratesDrawing(bool);
+
 CALayer *tileContainerLayer() const { return m_tileContainerLayer.get(); }
 
 private:
@@ -73,6 +76,8 @@
 
 // Number of tiles in each dimension.
 IntSize m_numTilesInGrid;
+
+bool m_acceleratesDrawing;
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm (106162 => 106163)

--- trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm	2012-01-27 23:31:35 UTC (rev 106162)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm	2012-01-27 23:34:01 UTC (rev 106163)
@@ -35,6 +35,12 @@
 
 using namespace std;
 
+#if !defined(BUILDING_ON_LEOPARD)  !defined(BUILDING_ON_SNOW_LEOPARD)
+@interface CALayer (WebCALayerDetails)
+- (void)setAcceleratesDrawing:(BOOL)flag;
+@end
+#endif
+
 namespace WebCore {
 
 PassOwnPtrTileCache TileCache::create(WebTileCacheLayer* tileCacheLayer, const IntSize tileSize)
@@ -46,6 +52,7 @@
 : m_tileCacheLayer(tileCacheLayer)
 , m_tileSize(tileSize)
 , m_tileContainerLayer(adoptCF([[CALayer alloc] init]))
+, m_acceleratesDrawing(false)
 {
 [CATransaction begin];
 [CATransaction setDisableActions:YES];
@@ -104,6 +111,21 @@
 CGContextRestoreGState(context);
 }
 
+void TileCache::setAcceleratesDrawing(bool acceleratesDrawing)
+{
+#if !defined(BUILDING_ON_LEOPARD)  !defined(BUILDING_ON_SNOW_LEOPARD)
+if (acceleratesDrawing == m_acceleratesDrawing)
+return;
+
+m_acceleratesDrawing = acceleratesDrawing;
+
+for (WebTileLayer* tileLayer in [m_tileContainerLayer.get() sublayers])
+[tileLayer setAcceleratesDrawing:m_acceleratesDrawing];
+#else
+UNUSED_PARAM(acceleratesDrawing);
+#endif
+}
+
 IntRect TileCache::bounds() const
 {
 return IntRect(IntPoint(), IntSize([m_tileCacheLayer bounds].size));
@@ -172,6 +194,10 @@
 [layer.get() setAnchorPoint:CGPointZero];
 [layer.get() setTileCache:this];
 
+#if !defined(BUILDING_ON_LEOPARD)  !defined(BUILDING_ON_SNOW_LEOPARD)
+[layer.get() setAcceleratesDrawing:m_acceleratesDrawing];
+#endif
+
 return

[webkit-changes] [106164] trunk/Source/WebKit/chromium

2012-01-27 Thread commit-queue

Title: [106164] trunk/Source/WebKit/chromium








Revision 106164
Author commit-qu...@webkit.org
Date 2012-01-27 15:42:04 -0800 (Fri, 27 Jan 2012)


Log Message
[chromium] Increase the size of the Ganesh texture cache to prevent performance problems on advanced Canvas2D pages.
The cache was previously 50 MB; it is now 96 MB.

Bug 7 - Ganesh's Texture Cache is too small
https://bugs.webkit.org/show_bug.cgi?id=7

Patch by Jeff Timanus t...@chromium.org on 2012-01-27
Reviewed by Stephen White.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::grContext):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (106163 => 106164)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-01-27 23:34:01 UTC (rev 106163)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-01-27 23:42:04 UTC (rev 106164)
@@ -1,3 +1,16 @@
+2012-01-27  Jeff Timanus  t...@chromium.org
+
+[chromium] Increase the size of the Ganesh texture cache to prevent performance problems on advanced Canvas2D pages.
+The cache was previously 50 MB; it is now 96 MB.
+
+Bug 7 - Ganesh's Texture Cache is too small
+https://bugs.webkit.org/show_bug.cgi?id=7
+
+Reviewed by Stephen White.
+
+* src/GraphicsContext3DChromium.cpp:
+(WebCore::GraphicsContext3DPrivate::grContext):
+
 2012-01-27  Adrienne Walker  e...@google.com
 
 [chromium] Don't ever skip drawing the non-composited content layer


Modified: trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp (106163 => 106164)

--- trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp	2012-01-27 23:34:01 UTC (rev 106163)
+++ trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp	2012-01-27 23:42:04 UTC (rev 106164)
@@ -210,7 +210,7 @@
 // Limit the number of textures we hold in the bitmap-texture cache.
 static const int maxTextureCacheCount = 512;
 // Limit the bytes allocated toward textures in the bitmap-texture cache.
-static const size_t maxTextureCacheBytes = 50 * 1024 * 1024;
+static const size_t maxTextureCacheBytes = 96 * 1024 * 1024;
 
 if (!m_grContext) {
 SkAutoTUnrefGrGLInterface interface(m_impl-createGrGLInterface());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106165] trunk/LayoutTests

2012-01-27 Thread jsbell

Title: [106165] trunk/LayoutTests








Revision 106165
Author jsb...@chromium.org
Date 2012-01-27 16:04:52 -0800 (Fri, 27 Jan 2012)


Log Message
IndexedDB does not update r/w index cursors that are mutated during iteration
https://bugs.webkit.org/show_bug.cgi?id=59822

Added tests to verify that index cursors see updates made to an object store while
iterating, assuming the cursor and updates occur within the same transaction.

Reviewed by Tony Chang.

* storage/indexeddb/mozilla/cursor-mutation-expected.txt: Added.
* storage/indexeddb/mozilla/cursor-mutation.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/storage/indexeddb/mozilla/cursor-mutation-expected.txt
trunk/LayoutTests/storage/indexeddb/mozilla/cursor-mutation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (106164 => 106165)

--- trunk/LayoutTests/ChangeLog	2012-01-27 23:42:04 UTC (rev 106164)
+++ trunk/LayoutTests/ChangeLog	2012-01-28 00:04:52 UTC (rev 106165)
@@ -1,3 +1,16 @@
+2012-01-27  Joshua Bell  jsb...@chromium.org
+
+IndexedDB does not update r/w index cursors that are mutated during iteration
+https://bugs.webkit.org/show_bug.cgi?id=59822
+
+Added tests to verify that index cursors see updates made to an object store while
+iterating, assuming the cursor and updates occur within the same transaction.
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/mozilla/cursor-mutation-expected.txt: Added.
+* storage/indexeddb/mozilla/cursor-mutation.html: Added.
+
 2012-01-27  Raymond Toy  r...@google.com
 
 Round time to sample frame


Added: trunk/LayoutTests/storage/indexeddb/mozilla/cursor-mutation-expected.txt (0 => 106165)

--- trunk/LayoutTests/storage/indexeddb/mozilla/cursor-mutation-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/cursor-mutation-expected.txt	2012-01-28 00:04:52 UTC (rev 106165)
@@ -0,0 +1,138 @@
+Test IndexedDB's cursor mutation
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB
+PASS indexedDB == null is false
+IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException
+PASS IDBDatabaseException == null is false
+IDBTransaction = window.IDBTransaction || window.webkitIDBTransaction
+PASS IDBTransaction == null is false
+
+indexedDB.deleteDatabase(name)
+indexedDB.open(name)
+db = event.target.result
+db.setVersion('1')
+
+setupObjectStoreAndCreateIndex():
+trans = request.result
+objectStore = db.createObjectStore('foo', { keyPath: 'ss' })
+index = objectStore.createIndex('name', 'name', { unique: true })
+objectStoreData = [
+{ ss: '237-23-7732', name: 'Bob' },
+{ ss: '237-23-7733', name: 'Ann' },
+{ ss: '237-23-7734', name: 'Ron' },
+{ ss: '237-23-7735', name: 'Sue' },
+{ ss: '237-23-7736', name: 'Joe' },
+{ ss: '237-23-7737', name: 'Pat' }
+]
+objectStore.add(objectStoreData[0])
+objectStore.add(objectStoreData[1])
+objectStore.add(objectStoreData[2])
+objectStore.add(objectStoreData[3])
+objectStore.add(objectStoreData[4])
+trans._oncomplete_ = checkCursorResults
+
+setupCursor():
+count = 0
+sawAdded = false
+sawRemoved = false
+request = objectStore.openCursor()
+
+iterateCursor():
+cursor = event.target.result
+PASS cursor.value.name is Bob
+sawRemoved = true
+count++
+cursor.continue()
+
+iterateCursor():
+cursor = event.target.result
+PASS cursor.value.name is Ann
+count++
+cursor.continue()
+
+iterateCursor():
+cursor = event.target.result
+PASS cursor.value.name is Ron
+count++
+cursor.continue()
+
+iterateCursor():
+cursor = event.target.result
+PASS cursor.value.name is Sue
+count++
+cursor.continue()
+
+iterateCursor():
+cursor = event.target.result
+PASS cursor.value.name is Joe
+count++
+cursor.continue()
+
+iterateCursor():
+cursor = event.target.result
+
+checkCursorResults():
+PASS count is objectStoreData.length - 1
+PASS sawAdded is false
+PASS sawRemoved is true
+
+setupMutatingCursor():
+count = 0
+sawAdded = false
+sawRemoved = false
+[objectStoreDataNameSort is an array of indexes into objectStoreData in alphabetical order by name]
+objectStoreDataNameSort = [ 1, 4, 5, 2, 3 ]
+
+trans = db.transaction('foo', IDBTransaction.READ_WRITE)
+objectStore = trans.objectStore('foo')
+request = objectStore.index('name').openCursor()
+trans._oncomplete_ = checkMutatingCursorResults
+
+iterateMutatingCursor():
+cursor = event.target.result
+PASS cursor.value.name is Ann
+count++
+
+Mutating the object store:
+Removing Bob
+request = objectStore.delete(objectStoreData[0].ss)
+
+addFinalData():
+Adding Pat
+request = objectStore.add(objectStoreData[objectStoreData.length - 1])
+
+iterateMutatingCursor():
+cursor = event.target.result
+PASS cursor.value.name is Joe
+count++
+
+iterateMutatingCursor():
+cursor = event.target.result
+PASS cursor.value.name is Pat

[webkit-changes] [106167] trunk/Source/JavaScriptCore

2012-01-27 Thread msaboff

Title: [106167] trunk/Source/_javascript_Core








Revision 106167
Author msab...@apple.com
Date 2012-01-27 16:05:51 -0800 (Fri, 27 Jan 2012)


Log Message
StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase
https://bugs.webkit.org/show_bug.cgi?id=76647

Reviewed by Geoffrey Garen.

Changed stringProtoFuncToUpperCase to call StringImpl::upper() is a manor similar
to stringProtoFuncToLowerCase().  Fixed StringImpl::upper() to handle the two
8 bit characters that when converted to upper case become 16 bit characters.

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase): Removed extra trailing whitespace.
(JSC::stringProtoFuncToUpperCase):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106166 => 106167)

--- trunk/Source/_javascript_Core/ChangeLog	2012-01-28 00:05:00 UTC (rev 106166)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-28 00:05:51 UTC (rev 106167)
@@ -1,3 +1,20 @@
+2012-01-27  Michael Saboff  msab...@apple.com
+
+StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase
+https://bugs.webkit.org/show_bug.cgi?id=76647
+
+Reviewed by Geoffrey Garen.
+
+Changed stringProtoFuncToUpperCase to call StringImpl::upper() is a manor similar
+to stringProtoFuncToLowerCase().  Fixed StringImpl::upper() to handle the two
+8 bit characters that when converted to upper case become 16 bit characters.
+
+* runtime/StringPrototype.cpp:
+(JSC::stringProtoFuncToLowerCase): Removed extra trailing whitespace.
+(JSC::stringProtoFuncToUpperCase):
+* wtf/text/StringImpl.cpp:
+(WTF::StringImpl::upper):
+
 2012-01-27  Hajime Morita  morr...@google.com
 
 [JSC] ThunkGenerators.cpp should hide its asm-defined symbols


Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (106166 => 106167)

--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp	2012-01-28 00:05:00 UTC (rev 106166)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp	2012-01-28 00:05:51 UTC (rev 106167)
@@ -1180,7 +1180,7 @@
 if (!sSize)
 return JSValue::encode(sVal);
 
-StringImpl* ourImpl = s.impl();   
+StringImpl* ourImpl = s.impl();
 RefPtrStringImpl lower = ourImpl-lower();
 if (ourImpl == lower.get())
 return JSValue::encode(sVal);
@@ -1199,32 +1199,11 @@
 if (!sSize)
 return JSValue::encode(sVal);
 
-const UChar* sData = s.characters();
-VectorUChar buffer(sSize);
-
-UChar ored = 0;
-for (int i = 0; i  sSize; i++) {
-UChar c = sData[i];
-ored |= c;
-buffer[i] = toASCIIUpper(c);
-}
-if (!(ored  ~0x7f))
-return JSValue::encode(jsString(exec, UString::adopt(buffer)));
-
-bool error;
-int length = Unicode::toUpper(buffer.data(), sSize, sData, sSize, error);
-if (error) {
-buffer.resize(length);
-length = Unicode::toUpper(buffer.data(), length, sData, sSize, error);
-if (error)
-return JSValue::encode(sVal);
-}
-if (length == sSize) {
-if (memcmp(buffer.data(), sData, length * sizeof(UChar)) == 0)
-return JSValue::encode(sVal);
-} else
-buffer.resize(length);
-return JSValue::encode(jsString(exec, UString::adopt(buffer)));
+StringImpl* ourImpl = s.impl();
+RefPtrStringImpl upper = ourImpl-upper();
+if (ourImpl == upper.get())
+return JSValue::encode(sVal);
+return JSValue::encode(jsString(exec, UString(upper.release(;
 }
 
 EncodedJSValue JSC_HOST_CALL stringProtoFuncLocaleCompare(ExecState* exec)


Modified: trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp (106166 => 106167)

--- trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp	2012-01-28 00:05:00 UTC (rev 106166)
+++ trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp	2012-01-28 00:05:51 UTC (rev 106167)
@@ -363,6 +363,8 @@
 CRASH();
 int32_t length = m_length;
 
+const UChar* source16;
+
 if (is8Bit()) {
 LChar* data8;
 RefPtrStringImpl newImpl = createUninitialized(m_length, data8);
@@ -378,19 +380,30 @@
 return newImpl.release();
 
 // Do a slower implementation for cases that include non-ASCII Latin-1 characters.
-for (int32_t i = 0; i  length; i++)
-data8[i] = static_castLChar(Unicode::toUpper(m_data8[i]));
+for (int32_t i = 0; i  length; i++) {
+UChar upper = Unicode::toUpper(m_data8[i]);
+if (UNLIKELY(upper  0xff)) {
+// Have a character that is 16bit when converted to uppercase.
+source16 = characters();
+goto upconvert;
+}
+
+

[webkit-changes] [106168] trunk/Source/JavaScriptCore

2012-01-27 Thread fpizlo

Title: [106168] trunk/Source/_javascript_Core








Revision 106168
Author fpi...@apple.com
Date 2012-01-27 16:40:07 -0800 (Fri, 27 Jan 2012)


Log Message
Build fix for interpreter platforms.

* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/AbstractPC.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106167 => 106168)

--- trunk/Source/_javascript_Core/ChangeLog	2012-01-28 00:05:51 UTC (rev 106167)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-28 00:40:07 UTC (rev 106168)
@@ -1,3 +1,10 @@
+2012-01-27  Filip Pizlo  fpi...@apple.com
+
+Build fix for interpreter platforms.
+
+* interpreter/AbstractPC.cpp:
+(JSC::AbstractPC::AbstractPC):
+
 2012-01-27  Michael Saboff  msab...@apple.com
 
 StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase


Modified: trunk/Source/_javascript_Core/interpreter/AbstractPC.cpp (106167 => 106168)

--- trunk/Source/_javascript_Core/interpreter/AbstractPC.cpp	2012-01-28 00:05:51 UTC (rev 106167)
+++ trunk/Source/_javascript_Core/interpreter/AbstractPC.cpp	2012-01-28 00:40:07 UTC (rev 106168)
@@ -35,6 +35,8 @@
 
 AbstractPC::AbstractPC(JSGlobalData globalData, ExecState* exec)
 {
+UNUSED_PARAM(globalData);
+
 #if ENABLE(JIT)
 if (globalData.canUseJIT()) {
 m_pointer = exec-returnPC().value();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106169] trunk/LayoutTests

2012-01-27 Thread msaboff

Title: [106169] trunk/LayoutTests








Revision 106169
Author msab...@apple.com
Date 2012-01-27 16:54:06 -0800 (Fri, 27 Jan 2012)


Log Message
New Regression Test for r106075
https://bugs.webkit.org/show_bug.cgi?id=77262

Reviewed by Geoffrey Garen.

Added a test that verifies that a function called with less than the
declared number of arguments has the missing arguments filled in
with undefined.  The test makes sure that the called function gets
JIT compiled by calling it several times.  This test verifies that
the problem found in r106075 does not regress.

* fast/js/apply-varargs-expected.txt: Added.
* fast/js/apply-varargs.html: Added.
* fast/js/script-tests/apply-varargs.js: Added.
(callee):
(dummy):
(BaseObj):
(caller):

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/js/apply-varargs-expected.txt
trunk/LayoutTests/fast/js/apply-varargs.html
trunk/LayoutTests/fast/js/script-tests/apply-varargs.js




Diff

Modified: trunk/LayoutTests/ChangeLog (106168 => 106169)

--- trunk/LayoutTests/ChangeLog	2012-01-28 00:40:07 UTC (rev 106168)
+++ trunk/LayoutTests/ChangeLog	2012-01-28 00:54:06 UTC (rev 106169)
@@ -1,3 +1,24 @@
+2012-01-27  Michael Saboff  msab...@apple.com
+
+New Regression Test for r106075
+https://bugs.webkit.org/show_bug.cgi?id=77262
+
+Reviewed by Geoffrey Garen.
+
+Added a test that verifies that a function called with less than the
+declared number of arguments has the missing arguments filled in
+with undefined.  The test makes sure that the called function gets
+JIT compiled by calling it several times.  This test verifies that
+the problem found in r106075 does not regress.
+
+* fast/js/apply-varargs-expected.txt: Added.
+* fast/js/apply-varargs.html: Added.
+* fast/js/script-tests/apply-varargs.js: Added.
+(callee):
+(dummy):
+(BaseObj):
+(caller):
+
 2012-01-27  Joshua Bell  jsb...@chromium.org
 
 IndexedDB does not update r/w index cursors that are mutated during iteration


Added: trunk/LayoutTests/fast/js/apply-varargs-expected.txt (0 => 106169)

--- trunk/LayoutTests/fast/js/apply-varargs-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/js/apply-varargs-expected.txt	2012-01-28 00:54:06 UTC (rev 106169)
@@ -0,0 +1,18 @@
+Test that we properly fill in missing args with undefined in JIT code.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS caller(0) is undefined
+PASS caller(1) is undefined
+PASS caller(2) is undefined
+PASS caller(3) is undefined
+PASS caller(4) is undefined
+PASS caller(5) is undefined
+PASS caller(6) is undefined
+PASS caller(7) is undefined
+PASS caller(8) is undefined
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/js/apply-varargs.html (0 => 106169)

--- trunk/LayoutTests/fast/js/apply-varargs.html	(rev 0)
+++ trunk/LayoutTests/fast/js/apply-varargs.html	2012-01-28 00:54:06 UTC (rev 106169)
@@ -0,0 +1,13 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script src=""
+script src=""
+/body
+/html


Added: trunk/LayoutTests/fast/js/script-tests/apply-varargs.js (0 => 106169)

--- trunk/LayoutTests/fast/js/script-tests/apply-varargs.js	(rev 0)
+++ trunk/LayoutTests/fast/js/script-tests/apply-varargs.js	2012-01-28 00:54:06 UTC (rev 106169)
@@ -0,0 +1,74 @@
+description('Test that we properly fill in missing args with undefined in JIT code.');
+
+// Regression test for rdar://problem/10763509
+
+
+function callee(a1, a2, a3, a4, a5, a6, a7, a8)
+{
+// We expect that the unused actual parameters will be filled
+// with undefined.
+if (a1 !== undefined)
+return Arg1 is wrong;
+if (a2 !== undefined)
+return Arg2 is wrong;
+if (a3 !== undefined)
+return Arg3 is wrong;
+if (a4 !== undefined)
+return Arg4 is wrong;
+if (a5 !== undefined)
+return Arg5 is wrong;
+if (a6 !== undefined)
+return Arg6 is wrong;
+if (a7 !== undefined)
+return Arg7 is wrong;
+if (a8 !== undefined)
+return Arg8 is wrong;
+
+return undefined;
+}
+
+function dummy(a1, a2, a3, a4, a5, a6, a7, a8)
+{
+}
+
+function BaseObj()
+{
+}
+
+function caller(testArgCount)
+{
+var baseObj = new BaseObj();
+
+var allArgs = [0, String, callee, true, null, 2.5, [1, 2, 3], {'a': 1, 'b' : 2}];
+argCounts = [8, testArgCount];
+
+for (argCountIndex = 0; argCountIndex  argCounts.length; argCountIndex++) {
+argCount = argCounts[argCountIndex];
+
+var varArgs = [];
+for (i = 0; i  argCount; i++)
+varArgs[i] = undefined;
+
+for (numCalls = 0; numCalls  10; numCalls++) {
+// Run multiple times so that the JIT kicks in
+

[webkit-changes] [106170] trunk/Source/JavaScriptCore

2012-01-27 Thread commit-queue

Title: [106170] trunk/Source/_javascript_Core








Revision 106170
Author commit-qu...@webkit.org
Date 2012-01-27 17:06:17 -0800 (Fri, 27 Jan 2012)


Log Message
Unreviewed, rolling out r106167.
http://trac.webkit.org/changeset/106167
https://bugs.webkit.org/show_bug.cgi?id=77264

broke LayoutTests/fast/js/string-capitalization.html
(Requested by msaboff on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-01-27

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106169 => 106170)

--- trunk/Source/_javascript_Core/ChangeLog	2012-01-28 00:54:06 UTC (rev 106169)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-28 01:06:17 UTC (rev 106170)
@@ -1,3 +1,18 @@
+2012-01-27  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r106167.
+http://trac.webkit.org/changeset/106167
+https://bugs.webkit.org/show_bug.cgi?id=77264
+
+broke LayoutTests/fast/js/string-capitalization.html
+(Requested by msaboff on #webkit).
+
+* runtime/StringPrototype.cpp:
+(JSC::stringProtoFuncToLowerCase):
+(JSC::stringProtoFuncToUpperCase):
+* wtf/text/StringImpl.cpp:
+(WTF::StringImpl::upper):
+
 2012-01-27  Filip Pizlo  fpi...@apple.com
 
 Build fix for interpreter platforms.


Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (106169 => 106170)

--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp	2012-01-28 00:54:06 UTC (rev 106169)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp	2012-01-28 01:06:17 UTC (rev 106170)
@@ -1180,7 +1180,7 @@
 if (!sSize)
 return JSValue::encode(sVal);
 
-StringImpl* ourImpl = s.impl();
+StringImpl* ourImpl = s.impl();   
 RefPtrStringImpl lower = ourImpl-lower();
 if (ourImpl == lower.get())
 return JSValue::encode(sVal);
@@ -1199,11 +1199,32 @@
 if (!sSize)
 return JSValue::encode(sVal);
 
-StringImpl* ourImpl = s.impl();
-RefPtrStringImpl upper = ourImpl-upper();
-if (ourImpl == upper.get())
-return JSValue::encode(sVal);
-return JSValue::encode(jsString(exec, UString(upper.release(;
+const UChar* sData = s.characters();
+VectorUChar buffer(sSize);
+
+UChar ored = 0;
+for (int i = 0; i  sSize; i++) {
+UChar c = sData[i];
+ored |= c;
+buffer[i] = toASCIIUpper(c);
+}
+if (!(ored  ~0x7f))
+return JSValue::encode(jsString(exec, UString::adopt(buffer)));
+
+bool error;
+int length = Unicode::toUpper(buffer.data(), sSize, sData, sSize, error);
+if (error) {
+buffer.resize(length);
+length = Unicode::toUpper(buffer.data(), length, sData, sSize, error);
+if (error)
+return JSValue::encode(sVal);
+}
+if (length == sSize) {
+if (memcmp(buffer.data(), sData, length * sizeof(UChar)) == 0)
+return JSValue::encode(sVal);
+} else
+buffer.resize(length);
+return JSValue::encode(jsString(exec, UString::adopt(buffer)));
 }
 
 EncodedJSValue JSC_HOST_CALL stringProtoFuncLocaleCompare(ExecState* exec)


Modified: trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp (106169 => 106170)

--- trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp	2012-01-28 00:54:06 UTC (rev 106169)
+++ trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp	2012-01-28 01:06:17 UTC (rev 106170)
@@ -363,8 +363,6 @@
 CRASH();
 int32_t length = m_length;
 
-const UChar* source16;
-
 if (is8Bit()) {
 LChar* data8;
 RefPtrStringImpl newImpl = createUninitialized(m_length, data8);
@@ -380,30 +378,19 @@
 return newImpl.release();
 
 // Do a slower implementation for cases that include non-ASCII Latin-1 characters.
-for (int32_t i = 0; i  length; i++) {
-UChar upper = Unicode::toUpper(m_data8[i]);
-if (UNLIKELY(upper  0xff)) {
-// Have a character that is 16bit when converted to uppercase.
-source16 = characters();
-goto upconvert;
-}
-
-data8[i] = static_castLChar(upper);
-}
+for (int32_t i = 0; i  length; i++)
+data8[i] = static_castLChar(Unicode::toUpper(m_data8[i]));
 
 return newImpl.release();
 }
 
-source16 = m_data16;
-
-upconvert:
 UChar* data16;
 RefPtrStringImpl newImpl = createUninitialized(m_length, data16);
 
 // Do a faster loop for the case where all the characters are ASCII.
 UChar ored = 0;
 for (int i = 0; i  length; i++) {
-UChar c = source16[i];
+UChar c =

[webkit-changes] [106171] trunk/Tools

2012-01-27 Thread enrica

Title: [106171] trunk/Tools








Revision 106171
Author enr...@apple.com
Date 2012-01-27 17:12:41 -0800 (Fri, 27 Jan 2012)


Log Message
DRT pasteboard object should return the correct pasteboard name.
https://bugs.webkit.org/show_bug.cgi?id=77260

Currently the name property always returns nil.
Adding a memeber variable to store the pasteboard name and return its
value from the name method instead of returning nil always.

Reviewed by Dan Bernstein.

* DumpRenderTree/mac/DumpRenderTreePasteboard.m:
(+[DumpRenderTreePasteboard _pasteboardWithName:]):
(-[LocalPasteboard initWithName:]):
(-[LocalPasteboard name]):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m




Diff

Modified: trunk/Tools/ChangeLog (106170 => 106171)

--- trunk/Tools/ChangeLog	2012-01-28 01:06:17 UTC (rev 106170)
+++ trunk/Tools/ChangeLog	2012-01-28 01:12:41 UTC (rev 106171)
@@ -1,3 +1,19 @@
+2012-01-27  Enrica Casucci  enr...@apple.com
+
+DRT pasteboard object should return the correct pasteboard name.
+https://bugs.webkit.org/show_bug.cgi?id=77260
+
+Currently the name property always returns nil.
+Adding a memeber variable to store the pasteboard name and return its
+value from the name method instead of returning nil always.
+
+Reviewed by Dan Bernstein.
+
+* DumpRenderTree/mac/DumpRenderTreePasteboard.m:
+(+[DumpRenderTreePasteboard _pasteboardWithName:]):
+(-[LocalPasteboard initWithName:]):
+(-[LocalPasteboard name]):
+
 2012-01-27  Martin Robinson  mrobin...@igalia.com
 
 [GTK] [WK2] Implement the policy client


Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m (106170 => 106171)

--- trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m	2012-01-28 01:06:17 UTC (rev 106170)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m	2012-01-28 01:12:41 UTC (rev 106171)
@@ -40,7 +40,10 @@
 NSMutableSet *typesSet;
 NSMutableDictionary *dataByType;
 NSInteger changeCount;
+NSString *pasteboardName;
 }
+
+-(id)initWithName:(NSString *)name;
 @end
 
 static NSMutableDictionary *localPasteboards;
@@ -58,7 +61,7 @@
 LocalPasteboard *pasteboard = [localPasteboards objectForKey:name];
 if (pasteboard)
 return pasteboard;
-pasteboard = [[LocalPasteboard alloc] init];
+pasteboard = [[LocalPasteboard alloc] initWithName:name];
 [localPasteboards setObject:pasteboard forKey:name];
 [pasteboard release];
 return pasteboard;
@@ -86,11 +89,12 @@
 return NSAllocateObject(self, 0, 0);
 }
 
-- (id)init
+- (id)initWithName:(NSString *)name
 {
 typesArray = [[NSMutableArray alloc] init];
 typesSet = [[NSMutableSet alloc] init];
 dataByType = [[NSMutableDictionary alloc] init];
+pasteboardName = [NSString stringWithString:name];
 return self;
 }
 
@@ -99,12 +103,13 @@
 [typesArray release];
 [typesSet release];
 [dataByType release];
+[pasteboardName release];
 [super dealloc];
 }
 
 - (NSString *)name
 {
-return nil;
+return pasteboardName;
 }
 
 - (void)releaseGlobally






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106172] trunk/Tools

2012-01-27 Thread enrica

Title: [106172] trunk/Tools








Revision 106172
Author enr...@apple.com
Date 2012-01-27 17:22:26 -0800 (Fri, 27 Jan 2012)


Log Message
Followup to http://trac.webkit.org/changeset/106171.
Dan Bernstein pointed out correctly that I should
have used copy instead of initWithString.

Reviewed by Dan Bernstein.

* DumpRenderTree/mac/DumpRenderTreePasteboard.m:
(-[LocalPasteboard initWithName:]):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m




Diff

Modified: trunk/Tools/ChangeLog (106171 => 106172)

--- trunk/Tools/ChangeLog	2012-01-28 01:12:41 UTC (rev 106171)
+++ trunk/Tools/ChangeLog	2012-01-28 01:22:26 UTC (rev 106172)
@@ -1,5 +1,16 @@
 2012-01-27  Enrica Casucci  enr...@apple.com
 
+Followup to http://trac.webkit.org/changeset/106171.
+Dan Bernstein pointed out correctly that I should
+have used copy instead of initWithString.
+
+Reviewed by Dan Bernstein.
+
+* DumpRenderTree/mac/DumpRenderTreePasteboard.m:
+(-[LocalPasteboard initWithName:]):
+
+2012-01-27  Enrica Casucci  enr...@apple.com
+
 DRT pasteboard object should return the correct pasteboard name.
 https://bugs.webkit.org/show_bug.cgi?id=77260
 


Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m (106171 => 106172)

--- trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m	2012-01-28 01:12:41 UTC (rev 106171)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m	2012-01-28 01:22:26 UTC (rev 106172)
@@ -94,7 +94,7 @@
 typesArray = [[NSMutableArray alloc] init];
 typesSet = [[NSMutableSet alloc] init];
 dataByType = [[NSMutableDictionary alloc] init];
-pasteboardName = [NSString stringWithString:name];
+pasteboardName = [name copy];
 return self;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106173] trunk/Source/WebCore

2012-01-27 Thread crogers

Title: [106173] trunk/Source/WebCore








Revision 106173
Author crog...@google.com
Date 2012-01-27 18:16:19 -0800 (Fri, 27 Jan 2012)


Log Message
HRTFPanner could have high-quality mode for smoother transitions
https://bugs.webkit.org/show_bug.cgi?id=76470

Reviewed by Kenneth Russell.

* platform/audio/HRTFPanner.cpp:
(WebCore):
(WebCore::HRTFPanner::HRTFPanner):
(WebCore::HRTFPanner::reset):
(WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):
(WebCore::HRTFPanner::pan):
* platform/audio/HRTFPanner.h:
(HRTFPanner):
():

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/HRTFPanner.cpp
trunk/Source/WebCore/platform/audio/HRTFPanner.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106172 => 106173)

--- trunk/Source/WebCore/ChangeLog	2012-01-28 01:22:26 UTC (rev 106172)
+++ trunk/Source/WebCore/ChangeLog	2012-01-28 02:16:19 UTC (rev 106173)
@@ -1,3 +1,20 @@
+2012-01-27  Chris Rogers  crog...@google.com
+
+HRTFPanner could have high-quality mode for smoother transitions
+https://bugs.webkit.org/show_bug.cgi?id=76470
+
+Reviewed by Kenneth Russell.
+
+* platform/audio/HRTFPanner.cpp:
+(WebCore):
+(WebCore::HRTFPanner::HRTFPanner):
+(WebCore::HRTFPanner::reset):
+(WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):
+(WebCore::HRTFPanner::pan):
+* platform/audio/HRTFPanner.h:
+(HRTFPanner):
+():
+
 2012-01-27  Mike Lawther  mikelawt...@chromium.org
 
 CSS calc parsing stage


Modified: trunk/Source/WebCore/platform/audio/HRTFPanner.cpp (106172 => 106173)

--- trunk/Source/WebCore/platform/audio/HRTFPanner.cpp	2012-01-28 01:22:26 UTC (rev 106172)
+++ trunk/Source/WebCore/platform/audio/HRTFPanner.cpp	2012-01-28 02:16:19 UTC (rev 106173)
@@ -37,23 +37,37 @@
 #include wtf/RefPtr.h
 
 using namespace std;
- 
+
 namespace WebCore {
 
 // The value of 2 milliseconds is larger than the largest delay which exists in any HRTFKernel from the default HRTFDatabase (0.0136 seconds).
 // We ASSERT the delay values used in process() with this value.
 const double MaxDelayTimeSeconds = 0.002;
 
+const int UninitializedAzimuth = -1;
+const unsigned RenderingQuantum = 128;
+
 HRTFPanner::HRTFPanner(float sampleRate)
 : Panner(PanningModelHRTF)
 , m_sampleRate(sampleRate)
-, m_isFirstRender(true)
-, m_azimuthIndex(0)
-, m_convolverL(fftSizeForSampleRate(sampleRate))
-, m_convolverR(fftSizeForSampleRate(sampleRate))
+, m_crossfadeSelection(CrossfadeSelection1)
+, m_azimuthIndex1(UninitializedAzimuth)
+, m_elevation1(0)
+, m_azimuthIndex2(UninitializedAzimuth)
+, m_elevation2(0)
+, m_crossfadeX(0)
+, m_crossfadeIncr(0)
+, m_convolverL1(fftSizeForSampleRate(sampleRate))
+, m_convolverR1(fftSizeForSampleRate(sampleRate))
+, m_convolverL2(fftSizeForSampleRate(sampleRate))
+, m_convolverR2(fftSizeForSampleRate(sampleRate))
 , m_delayLineL(MaxDelayTimeSeconds, sampleRate)
 , m_delayLineR(MaxDelayTimeSeconds, sampleRate)
-{ 
+, m_tempL1(RenderingQuantum)
+, m_tempR1(RenderingQuantum)
+, m_tempL2(RenderingQuantum)
+, m_tempR2(RenderingQuantum)
+{
 }
 
 HRTFPanner::~HRTFPanner()
@@ -71,31 +85,24 @@
 
 void HRTFPanner::reset()
 {
-m_isFirstRender = true;
-m_convolverL.reset();
-m_convolverR.reset();
+m_convolverL1.reset();
+m_convolverR1.reset();
+m_convolverL2.reset();
+m_convolverR2.reset();
 m_delayLineL.reset();
 m_delayLineR.reset();
 }
 
-static bool wrapDistance(int i, int j, int length)
-{
-int directDistance = abs(i - j);
-int indirectDistance = length - directDistance;
-
-return indirectDistance  directDistance;
-}
-
 int HRTFPanner::calculateDesiredAzimuthIndexAndBlend(double azimuth, double azimuthBlend)
 {
 // Convert the azimuth angle from the range -180 - +180 into the range 0 - 360.
 // The azimuth index may then be calculated from this positive value.
 if (azimuth  0)
 azimuth += 360.0;
-
-HRTFDatabase* database = HRTFDatabaseLoader::defaultHRTFDatabase();
+
+HRTFDatabase* database = HRTFDatabaseLoader::defaultHRTFDatabase();
 ASSERT(database);
-
+
 int numberOfAzimuths = database-numberOfAzimuths();
 const double angleBetweenAzimuths = 360.0 / numberOfAzimuths;
 
@@ -103,7 +110,7 @@
 double desiredAzimuthIndexFloat = azimuth / angleBetweenAzimuths;
 int desiredAzimuthIndex = static_castint(desiredAzimuthIndexFloat);
 azimuthBlend = desiredAzimuthIndexFloat - static_castdouble(desiredAzimuthIndex);
-
+
 // We don't immediately start using this azimuth index, but instead approach this index from the last index we rendered at.
 // This minimizes the clicks and graininess for moving sources which occur otherwise.
 desiredAzimuthIndex = max(0, desiredAzimuthIndex);
@@ -128,7 +135,7 @@
 }
 
 // This code only runs as long as the context is

[webkit-changes] [106174] trunk

2012-01-27 Thread commit-queue

Title: [106174] trunk








Revision 106174
Author commit-qu...@webkit.org
Date 2012-01-27 19:11:43 -0800 (Fri, 27 Jan 2012)


Log Message
AudioPannerNode::setPanningModel() does not update m_panningModel properly
https://bugs.webkit.org/show_bug.cgi?id=66830

Patch by Raymond Toy r...@google.com on 2012-01-27
Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/panner-set-model.html

* webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::setPanningModel):  Update
m_panningModel appropriately.  Also silently do nothing if the
model is invalid.

LayoutTests:

* webaudio/panner-set-model-expected.txt: Added.
* webaudio/panner-set-model.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AudioPannerNode.cpp


Added Paths

trunk/LayoutTests/webaudio/panner-set-model-expected.txt
trunk/LayoutTests/webaudio/panner-set-model.html




Diff

Modified: trunk/LayoutTests/ChangeLog (106173 => 106174)

--- trunk/LayoutTests/ChangeLog	2012-01-28 02:16:19 UTC (rev 106173)
+++ trunk/LayoutTests/ChangeLog	2012-01-28 03:11:43 UTC (rev 106174)
@@ -1,3 +1,13 @@
+2012-01-27  Raymond Toy  r...@google.com
+
+AudioPannerNode::setPanningModel() does not update m_panningModel properly
+https://bugs.webkit.org/show_bug.cgi?id=66830
+
+Reviewed by Kenneth Russell.
+
+* webaudio/panner-set-model-expected.txt: Added.
+* webaudio/panner-set-model.html: Added.
+
 2012-01-27  Michael Saboff  msab...@apple.com
 
 New Regression Test for r106075


Added: trunk/LayoutTests/webaudio/panner-set-model-expected.txt (0 => 106174)

--- trunk/LayoutTests/webaudio/panner-set-model-expected.txt	(rev 0)
+++ trunk/LayoutTests/webaudio/panner-set-model-expected.txt	2012-01-28 03:11:43 UTC (rev 106174)
@@ -0,0 +1,13 @@
+Test if panningModel can be set and read.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+PASS Panner set to EQUALPOWER model and read correctly.
+PASS Panner set to HRTF model and read correctly.
+PASS Panner set to SOUNDFIELD model and read correctly.
+PASS Panner set to invalid model and panningModel did not change.
+PASS Panning model tests passed.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/webaudio/panner-set-model.html (0 => 106174)

--- trunk/LayoutTests/webaudio/panner-set-model.html	(rev 0)
+++ trunk/LayoutTests/webaudio/panner-set-model.html	2012-01-28 03:11:43 UTC (rev 106174)
@@ -0,0 +1,82 @@
+!DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN
+html
+  head
+link rel=stylesheet href=""
+script src=""
+script src=""
+titleTest Panner setPanningModel values./title
+  /head
+
+  body
+div id=description/div
+div id=console/div
+
+script
+  description(Test if panningModel can be set and read.);
+
+  // Test to see if we panningModel is updated when we set it.
+  function runTest() {
+  if (window.layoutTestController) {
+  layoutTestController.dumpAsText();
+  layoutTestController.waitUntilDone();
+  }
+
+  window.jsTestIsAsync = true;
+
+  var context = new webkitAudioContext();
+  var success = true;
+  var panner = context.createPanner();
+
+  // Set the panning model and see if it can be read back
+  // correctly.
+  panner.panningModel = panner.EQUALPOWER;
+  if (panner.panningModel == 0) {
+  testPassed(Panner set to EQUALPOWER model and read correctly.);
+  } else {
+  testFailed(Panner model set to EQUALPOWER (0) but returned  + panner.panningModel);
+  success = false;
+  }
+  
+  panner.panningModel = panner.HRTF;
+  if (panner.panningModel == 1) {
+  testPassed(Panner set to HRTF model and read correctly.);
+  } else {
+  testFailed(Panner model set to HRTF (1) but returned  + panner.panningModel);
+  success = false;
+  }
+  
+  panner.panningModel = panner.SOUNDFIELD;
+  if (panner.panningModel == 2) {
+  testPassed(Panner set to SOUNDFIELD model and read correctly.);
+  } else {
+  testFailed(Panner model set to SOUNDFIELD (2) but returned  + panner.panningModel);
+  success = false;
+  }
+
+  // Set to invalid value and make sure it didn't change from
+  // it's previous setting (of 2).
+  panner.panningModel = 99;
+  if (panner.panningModel == 2) {
+  testPassed(Panner set to invalid model and panningModel did not change.);
+  } else {
+  testFailed(Panner set to invalid model, but the panningModel changed from 2 to  + panner.panningModel);
+  success = false;
+  }
+  
+  if (success) {
+  testPassed(Panning model

[webkit-changes] [106179] trunk/LayoutTests

2012-01-27 Thread mdelaney

Title: [106179] trunk/LayoutTests








Revision 106179
Author mdela...@apple.com
Date 2012-01-27 20:09:04 -0800 (Fri, 27 Jan 2012)


Log Message
Update mac-lion canvas results
https://bugs.webkit.org/show_bug.cgi?id=77178

2d.gradient.interpolate.colouralpha is failing due to one channel's value of one pixel being
off by 4 just outside of the +/-3 range the test allows for tolerance. Upping the tolerance to
+/-4 is reasonable but we've chosen not to modify locally this suite of pulled external tests.

The set-colors test passes other than two color parsing checks. Thus, it's useful to track it
with overall failing results in case any other check changes in the test.

Reviewed by Andy Estes.

* platform/mac-lion/Skipped: Unskipping set-colors and 2d.gradient.interpolate.colouralpha
* platform/mac-lion/canvas: Added.
* platform/mac-lion/canvas/philip: Added.
* platform/mac-lion/canvas/philip/tests: Added.
* platform/mac-lion/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Added.
* platform/mac-snowleopard/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Added.
* platform/mac-snowleopard/fast/canvas/set-colors-expected.txt:
* platform/mac/fast/canvas/set-colors-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/canvas/set-colors-expected.txt
trunk/LayoutTests/platform/mac-lion/Skipped


Added Paths

trunk/LayoutTests/platform/mac-lion/canvas/
trunk/LayoutTests/platform/mac-lion/canvas/philip/
trunk/LayoutTests/platform/mac-lion/canvas/philip/tests/
trunk/LayoutTests/platform/mac-lion/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/fast/canvas/set-colors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106178 => 106179)

--- trunk/LayoutTests/ChangeLog	2012-01-28 04:00:21 UTC (rev 106178)
+++ trunk/LayoutTests/ChangeLog	2012-01-28 04:09:04 UTC (rev 106179)
@@ -1,3 +1,26 @@
+2012-01-27  Matthew Delaney  mdela...@apple.com
+
+Update mac-lion canvas results
+https://bugs.webkit.org/show_bug.cgi?id=77178
+
+2d.gradient.interpolate.colouralpha is failing due to one channel's value of one pixel being
+off by 4 just outside of the +/-3 range the test allows for tolerance. Upping the tolerance to
++/-4 is reasonable but we've chosen not to modify locally this suite of pulled external tests.
+
+The set-colors test passes other than two color parsing checks. Thus, it's useful to track it
+with overall failing results in case any other check changes in the test.
+
+Reviewed by Andy Estes.
+
+* platform/mac-lion/Skipped: Unskipping set-colors and 2d.gradient.interpolate.colouralpha
+* platform/mac-lion/canvas: Added.
+* platform/mac-lion/canvas/philip: Added.
+* platform/mac-lion/canvas/philip/tests: Added.
+* platform/mac-lion/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Added.
+* platform/mac-snowleopard/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Added.
+* platform/mac-snowleopard/fast/canvas/set-colors-expected.txt:
+* platform/mac/fast/canvas/set-colors-expected.txt:
+
 2012-01-27  Gyuyoung Kim  gyuyoung@samsung.com
 
 Unreviewed, EFL css2.1 rebaseline after r101343.


Modified: trunk/LayoutTests/platform/mac/fast/canvas/set-colors-expected.txt (106178 => 106179)

--- trunk/LayoutTests/platform/mac/fast/canvas/set-colors-expected.txt	2012-01-28 04:00:21 UTC (rev 106178)
+++ trunk/LayoutTests/platform/mac/fast/canvas/set-colors-expected.txt	2012-01-28 04:09:04 UTC (rev 106179)
@@ -31,8 +31,8 @@
 PASS testSetFillColor('1, 0.8') is translucentWhite
 PASS testSetFillColor('0, 1, 0, 1') is green
 PASS testSetFillColor('0, 1, 0, 0.8') is translucentGreen
-FAIL testSetFillColor('0, 0, 0, 1, 1') should be #1a1a1a. Was #141414.
-FAIL testSetFillColor('0, 0, 0, 1, 0.8') should be rgba(25, 25, 25, 0.8). Was rgba(20, 20, 20, 0.8).
+FAIL testSetFillColor('0, 0, 0, 1, 1') should be #1a1a1a. Was #1a1919.
+FAIL testSetFillColor('0, 0, 0, 1, 0.8') should be rgba(25, 25, 25, 0.8). Was rgba(26, 25, 25, 0.8).
 PASS testSetFillColor('0, 0, 0, 1, 0') is transparent
 PASS testStrokeStyle('transparent') is transparent
 PASS testStrokeStyle('blue') is blue
@@ -62,8 +62,8 @@
 PASS testSetStrokeColor('1, 0.8') is translucentWhite
 PASS testSetStrokeColor('0, 1, 0, 1') is green
 PASS testSetStrokeColor('0, 1, 0, 0.8') is translucentGreen
-FAIL testSetStrokeColor('0, 0, 0, 1, 1') should be #1a1a1a. Was #141414.
-FAIL testSetStrokeColor('0, 0, 0, 1, 0.8') should be rgba(25, 25, 25, 0.8). Was rgba(20, 20, 20, 0.8).
+FAIL testSetStrokeColor('0, 0, 0, 1, 1') should be #1a1a1a. Was #1a1919.
+FAIL testSetStrokeColor('0, 0, 0, 1, 0.8') should be rgba(25, 25, 25, 0.8). Was

[webkit-changes] [106183] trunk/Tools

2012-01-27 Thread haraken

Title: [106183] trunk/Tools








Revision 106183
Author hara...@chromium.org
Date 2012-01-27 22:24:22 -0800 (Fri, 27 Jan 2012)


Log Message
The cpp parser of prepare-ChangeLog treats if(...) {} as a method
https://bugs.webkit.org/show_bug.cgi?id=77241

Reviewed by Ryosuke Niwa.

The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
in a method in some namespace or class is treated as a method.
This patch fixes the bug.

class C {
void func()
{
if (1) {// This should not be treated as a method.
}
}
};

* Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp):
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
(Class108):
(Class108::func35):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/prepare-ChangeLog
trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt
trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp




Diff

Modified: trunk/Tools/ChangeLog (106182 => 106183)

--- trunk/Tools/ChangeLog	2012-01-28 04:45:29 UTC (rev 106182)
+++ trunk/Tools/ChangeLog	2012-01-28 06:24:22 UTC (rev 106183)
@@ -1,3 +1,29 @@
+2012-01-27  Kentaro Hara  hara...@chromium.org
+
+The cpp parser of prepare-ChangeLog treats if(...) {} as a method
+https://bugs.webkit.org/show_bug.cgi?id=77241
+
+Reviewed by Ryosuke Niwa.
+
+The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
+in a method in some namespace or class is treated as a method.
+This patch fixes the bug.
+
+class C {
+void func()
+{
+if (1) {// This should not be treated as a method.
+}
+}
+};
+
+* Scripts/prepare-ChangeLog:
+(get_function_line_ranges_for_cpp):
+* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
+* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
+(Class108):
+(Class108::func35):
+
 2012-01-27  Enrica Casucci  enr...@apple.com
 
 Followup to http://trac.webkit.org/changeset/106171.


Modified: trunk/Tools/Scripts/prepare-ChangeLog (106182 => 106183)

--- trunk/Tools/Scripts/prepare-ChangeLog	2012-01-28 04:45:29 UTC (rev 106182)
+++ trunk/Tools/Scripts/prepare-ChangeLog	2012-01-28 06:24:22 UTC (rev 106183)
@@ -778,25 +778,27 @@
 if ($1 eq {) {
 $skip_til_brace_or_semicolon = 0;
 
-if ($namespace_start = 0 and $namespace_start  $potential_start) {
-push @ranges, [ $namespace_start . , $potential_start - 1, $name ];
-}
+if (!$in_braces) {
+if ($namespace_start = 0 and $namespace_start  $potential_start) {
+push @ranges, [ $namespace_start . , $potential_start - 1, $name ];
+}
 
-if ($potential_namespace) {
-push @namespaces, $potential_namespace;
-$potential_namespace = ;
-$name = $namespaces[-1];
-$namespace_start = $. + 1;
-next;
-}
+if ($potential_namespace) {
+push @namespaces, $potential_namespace;
+$potential_namespace = ;
+$name = $namespaces[-1];
+$namespace_start = $. + 1;
+next;
+}
 
-# Promote potential name to real function name at the
-# start of the outer level set of braces (function body?).
-if (!$in_braces and $potential_start) {
-$start = $potential_start;
-$name = $potential_name;
-if (@namespaces  $name  (length($name)  2 || substr($name,1,1) ne [)) {
-$name = join ('::', @namespaces, $name);
+# Promote potential name to real function name at the
+# start of the outer level set of braces (function body?).
+if ($potential_start) {
+$start = $potential_start;
+$name = $potential_name;
+if (@namespaces  $name  (length($name)  2 || substr($name,1,1) ne [)) {
+$name = join ('::', @namespaces, $name);
+}
 }
 }
 


Modified: trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt (106182 => 106183)

--- trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt	2012-01-28 04:45:29 UTC (rev 106182)
+++

66 matches

Mail list logo