[webkit-changes] [106340] trunk
Title: [106340] trunk Revision 106340 Author ph...@webkit.org Date 2012-01-31 00:02:56 -0800 (Tue, 31 Jan 2012) Log Message [GStreamer] 0.11 build support https://bugs.webkit.org/show_bug.cgi?id=77085 Reviewed by Martin Robinson. * configure.ac: New --with-gstreamer option, defaulting to 0.10. Modified Paths trunk/ChangeLog trunk/configure.ac Diff Modified: trunk/ChangeLog (106339 => 106340) --- trunk/ChangeLog 2012-01-31 07:50:46 UTC (rev 106339) +++ trunk/ChangeLog 2012-01-31 08:02:56 UTC (rev 106340) @@ -1,3 +1,12 @@ +2012-01-25 Philippe Normand pnorm...@igalia.com + +[GStreamer] 0.11 build support +https://bugs.webkit.org/show_bug.cgi?id=77085 + +Reviewed by Martin Robinson. + +* configure.ac: New --with-gstreamer option, defaulting to 0.10. + 2012-01-30 Ryosuke Niwa rn...@webkit.org Build fix after r106321. Modified: trunk/configure.ac (106339 => 106340) --- trunk/configure.ac 2012-01-31 07:50:46 UTC (rev 106339) +++ trunk/configure.ac 2012-01-31 08:02:56 UTC (rev 106340) @@ -269,6 +269,38 @@ AC_SUBST([HILDON_LIBS]) fi +AC_MSG_CHECKING([the GStreamer version to use]) +AC_ARG_WITH([gstreamer], +[AS_HELP_STRING([--with-gstreamer=0.10|0.11], [the GStreamer version to use (default: 0.10)])], +[case $with_gstreamer in +0.10|0.11) ;; +*) AC_MSG_ERROR([invalid GStreamer version specified]) ;; +esac], +[with_gstreamer=0.10]) +AC_MSG_RESULT([$with_gstreamer]) + +GSTREAMER_0_10_REQUIRED_VERSION=0.10 +GSTREAMER_0_10_PLUGINS_BASE_REQUIRED_VERSION=0.10.30 +GSTREAMER_0_11_REQUIRED_VERSION=0.11 +GSTREAMER_0_11_PLUGINS_BASE_REQUIRED_VERSION=0.11.0.2 + +case $with_gstreamer in + 0.10) GSTREAMER_REQUIRED_VERSION=GSTREAMER_0_10_REQUIRED_VERSION + GSTREAMER_PLUGINS_BASE_REQUIRED_VERSION=GSTREAMER_0_10_PLUGINS_BASE_REQUIRED_VERSION + GST_API_VERSION=0.10 + ;; + 0.11) GSTREAMER_REQUIRED_VERSION=GSTREAMER_0_11_REQUIRED_VERSION + GSTREAMER_PLUGINS_BASE_REQUIRED_VERSION=GSTREAMER_0_11_PLUGINS_BASE_REQUIRED_VERSION + GST_API_VERSION=0.11 + ;; +esac + +AC_SUBST([GST_API_VERSION]) +if test $GST_API_VERSION = 0.11; then +AC_DEFINE([GST_USE_UNSTABLE_API], [1], [Using unstable GStreamer API]) +AC_DEFINE([GST_API_VERSION_1],[1], [Using GStreamer 0.11]) +fi + # minimum base dependencies LIBSOUP_REQUIRED_VERSION=2.37.2.1 CAIRO_REQUIRED_VERSION=1.10 @@ -282,8 +314,6 @@ # optional modules LIBXSLT_REQUIRED_VERSION=1.1.7 SQLITE_REQUIRED_VERSION=3.0 -GSTREAMER_REQUIRED_VERSION=0.10 -GSTREAMER_PLUGINS_BASE_REQUIRED_VERSION=0.10.30 ENCHANT_REQUIRED_VERSION=0.22 LIBFFTW_REQUIRED_VERSION=3.2.2 CLUTTER_REQUIRED_VERSION=1.8.2 @@ -1032,14 +1062,14 @@ # check if gstreamer is available if test $enable_video = yes || test $enable_web_audio = yes; then PKG_CHECK_MODULES([GSTREAMER], - [gstreamer-0.10 = $GSTREAMER_REQUIRED_VERSION - gstreamer-app-0.10 - gstreamer-audio-0.10 - gstreamer-base-0.10 - gstreamer-interfaces-0.10 - gstreamer-pbutils-0.10 - gstreamer-plugins-base-0.10 = $GSTREAMER_PLUGINS_BASE_REQUIRED_VERSION - gstreamer-video-0.10], + [gstreamer-$GST_API_VERSION = $GSTREAMER_REQUIRED_VERSION + gstreamer-app-$GST_API_VERSION + gstreamer-audio-$GST_API_VERSION + gstreamer-base-$GST_API_VERSION + gstreamer-interfaces-$GST_API_VERSION + gstreamer-pbutils-$GST_API_VERSION + gstreamer-plugins-base-$GST_API_VERSION = $GSTREAMER_PLUGINS_BASE_REQUIRED_VERSION + gstreamer-video-$GST_API_VERSION], [have_gstreamer=yes]) AC_SUBST([GSTREAMER_CFLAGS]) @@ -1337,6 +1367,7 @@ GTK+ version : $with_gtk GDK target : $with_target Hildon UI extensions : $with_hildon + GStreamer version: $with_gstreamer Introspection support: $enable_introspection Generate documentation : $enable_gtk_doc ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106341] trunk/LayoutTests
Title: [106341] trunk/LayoutTests Revision 106341 Author o...@webkit.org Date 2012-01-31 00:04:46 -0800 (Tue, 31 Jan 2012) Log Message Typo fix after r106339. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (106340 => 106341) --- trunk/LayoutTests/ChangeLog 2012-01-31 08:02:56 UTC (rev 106340) +++ trunk/LayoutTests/ChangeLog 2012-01-31 08:04:46 UTC (rev 106341) @@ -1,3 +1,9 @@ +2012-01-31 Csaba Osztrogonác o...@webkit.org + +Typo fix after r106339. + +* platform/qt/Skipped: + 2012-01-30 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed gardening. Modified: trunk/LayoutTests/platform/qt/Skipped (106340 => 106341) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-31 08:02:56 UTC (rev 106340) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-31 08:04:46 UTC (rev 106341) @@ -1080,7 +1080,7 @@ # ERROR: LayoutTestController::overridePreference() does not support the 'WebKitPageCacheSupportsPluginsPreferenceKey' preference # http://trac.webkit.org/changeset/106305 -# plugins/crash-restoring-pluging-page-from-page-cache.html +plugins/crash-restoring-pluging-page-from-page-cache.html # = # # Failing SVG tests ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106342] trunk/Source
Title: [106342] trunk/Source
Revision 106342
Author commit-qu...@webkit.org
Date 2012-01-31 00:22:31 -0800 (Tue, 31 Jan 2012)
Log Message
Fix compilation errors on build-webkit --debug --no-workers on mac.
https://bugs.webkit.org/show_bug.cgi?id=75869
Patch by Pablo Flouret pab...@motorola.com on 2012-01-31
Reviewed by Adam Barth.
Source/WebCore:
* WebCore.exp.in:
Source/WebKit/mac:
* Workers/WebWorkersPrivate.mm:
(+[WebWorkersPrivate workerThreadCount]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Workers/WebWorkersPrivate.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106341 => 106342)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 08:04:46 UTC (rev 106341)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 08:22:31 UTC (rev 106342)
@@ -1,3 +1,12 @@
+2012-01-31 Pablo Flouret pab...@motorola.com
+
+Fix compilation errors on build-webkit --debug --no-workers on mac.
+https://bugs.webkit.org/show_bug.cgi?id=75869
+
+Reviewed by Adam Barth.
+
+* WebCore.exp.in:
+
2012-01-30 Konrad Piascik kpias...@rim.com
Web Inspector: [BlackBerry] Add BlackBerry UA Strings to the Inspector's UA switcher
Modified: trunk/Source/WebCore/WebCore.exp.in (106341 => 106342)
--- trunk/Source/WebCore/WebCore.exp.in 2012-01-31 08:04:46 UTC (rev 106341)
+++ trunk/Source/WebCore/WebCore.exp.in 2012-01-31 08:22:31 UTC (rev 106342)
@@ -301,7 +301,9 @@
__ZN7WebCore12TextIterator8subrangeEPNS_5RangeEii
__ZN7WebCore12TextIteratorC1EPKNS_5RangeENS_20TextIteratorBehaviorE
__ZN7WebCore12TextIteratorD1Ev
+#if ENABLE(WORKERS)
__ZN7WebCore12WorkerThread17workerThreadCountEv
+#endif
__ZN7WebCore12cacheStorageEv
__ZN7WebCore12createMarkupEPKNS_4NodeENS_13EChildrenOnlyEPN3WTF6VectorIPS0_Lm0EEENS_13EAbsoluteURLsE
__ZN7WebCore12createMarkupEPKNS_5RangeEPN3WTF6VectorIPNS_4NodeELm0EEENS_23EAnnotateForInterchangeEbNS_13EAbsoluteURLsE
Modified: trunk/Source/WebKit/mac/ChangeLog (106341 => 106342)
--- trunk/Source/WebKit/mac/ChangeLog 2012-01-31 08:04:46 UTC (rev 106341)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-01-31 08:22:31 UTC (rev 106342)
@@ -1,3 +1,13 @@
+2012-01-31 Pablo Flouret pab...@motorola.com
+
+Fix compilation errors on build-webkit --debug --no-workers on mac.
+https://bugs.webkit.org/show_bug.cgi?id=75869
+
+Reviewed by Adam Barth.
+
+* Workers/WebWorkersPrivate.mm:
+(+[WebWorkersPrivate workerThreadCount]):
+
2012-01-30 Beth Dakin bda...@apple.com
https://bugs.webkit.org/show_bug.cgi?id=77263
Modified: trunk/Source/WebKit/mac/Workers/WebWorkersPrivate.mm (106341 => 106342)
--- trunk/Source/WebKit/mac/Workers/WebWorkersPrivate.mm 2012-01-31 08:04:46 UTC (rev 106341)
+++ trunk/Source/WebKit/mac/Workers/WebWorkersPrivate.mm 2012-01-31 08:22:31 UTC (rev 106342)
@@ -36,7 +36,7 @@
+ (unsigned) workerThreadCount
{
-#if ENABLE_WORKERS
+#if defined(ENABLE_WORKERS) ENABLE_WORKERS
return WebCore::WorkerThread::workerThreadCount();
#else
return 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106343] trunk/LayoutTests
Title: [106343] trunk/LayoutTests Revision 106343 Author o...@webkit.org Date 2012-01-31 00:37:26 -0800 (Tue, 31 Jan 2012) Log Message On more (last) typo fix after r106339. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (106342 => 106343) --- trunk/LayoutTests/ChangeLog 2012-01-31 08:22:31 UTC (rev 106342) +++ trunk/LayoutTests/ChangeLog 2012-01-31 08:37:26 UTC (rev 106343) @@ -1,5 +1,11 @@ 2012-01-31 Csaba Osztrogonác o...@webkit.org +On more (last) typo fix after r106339. + +* platform/qt/Skipped: + +2012-01-31 Csaba Osztrogonác o...@webkit.org + Typo fix after r106339. * platform/qt/Skipped: Modified: trunk/LayoutTests/platform/qt/Skipped (106342 => 106343) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-31 08:22:31 UTC (rev 106342) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-31 08:37:26 UTC (rev 106343) @@ -1080,7 +1080,7 @@ # ERROR: LayoutTestController::overridePreference() does not support the 'WebKitPageCacheSupportsPluginsPreferenceKey' preference # http://trac.webkit.org/changeset/106305 -plugins/crash-restoring-pluging-page-from-page-cache.html +plugins/crash-restoring-plugin-page-from-page-cache.html # = # # Failing SVG tests ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106344] trunk/LayoutTests
Title: [106344] trunk/LayoutTests Revision 106344 Author y...@google.com Date 2012-01-31 01:19:24 -0800 (Tue, 31 Jan 2012) Log Message [Chromium] Unreviewed test expectation change. 77412 - [Chromium] Layout Test media/media-blocked-by-beforeload.html fails for LEOPARD * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (106343 => 106344) --- trunk/LayoutTests/ChangeLog 2012-01-31 08:37:26 UTC (rev 106343) +++ trunk/LayoutTests/ChangeLog 2012-01-31 09:19:24 UTC (rev 106344) @@ -1,3 +1,10 @@ +2012-01-31 Yuzo Fujishima y...@google.com + +[Chromium] Unreviewed test expectation change. +77412 - [Chromium] Layout Test media/media-blocked-by-beforeload.html fails for LEOPARD + +* platform/chromium/test_expectations.txt: + 2012-01-31 Csaba Osztrogonác o...@webkit.org On more (last) typo fix after r106339. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106343 => 106344) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-31 08:37:26 UTC (rev 106343) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-31 09:19:24 UTC (rev 106344) @@ -4041,3 +4041,4 @@ BUGWK77239 : storage/indexeddb/structured-clone.html = PASS TEXT BUGWK77397 : plugins/crash-restoring-plugin-page-from-page-cache.html = TIMEOUT TEXT +BUGWK77412 LEOPARD : media/media-blocked-by-beforeload.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106345] trunk/LayoutTests
Title: [106345] trunk/LayoutTests Revision 106345 Author ph...@webkit.org Date 2012-01-31 01:36:07 -0800 (Tue, 31 Jan 2012) Log Message Unreviewed, GTK gardening. * platform/gtk/Skipped: Skipping some new failures. * platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Added. * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: * platform/gtk/fast/js/global-constructors-expected.txt: * platform/gtk/test_expectations.txt: Marked one more svg test as flaky. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt trunk/LayoutTests/platform/gtk/test_expectations.txt Added Paths trunk/LayoutTests/platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (106344 => 106345) --- trunk/LayoutTests/ChangeLog 2012-01-31 09:19:24 UTC (rev 106344) +++ trunk/LayoutTests/ChangeLog 2012-01-31 09:36:07 UTC (rev 106345) @@ -1,3 +1,13 @@ +2012-01-31 Philippe Normand pnorm...@igalia.com + +Unreviewed, GTK gardening. + +* platform/gtk/Skipped: Skipping some new failures. +* platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Added. +* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: +* platform/gtk/fast/js/global-constructors-expected.txt: +* platform/gtk/test_expectations.txt: Marked one more svg test as flaky. + 2012-01-31 Yuzo Fujishima y...@google.com [Chromium] Unreviewed test expectation change. Modified: trunk/LayoutTests/platform/gtk/Skipped (106344 => 106345) --- trunk/LayoutTests/platform/gtk/Skipped 2012-01-31 09:19:24 UTC (rev 106344) +++ trunk/LayoutTests/platform/gtk/Skipped 2012-01-31 09:36:07 UTC (rev 106345) @@ -1629,3 +1629,11 @@ # https://bugs.webkit.org/show_bug.cgi?id=77019 http/tests/media/video-buffering-repaints-controls.html + +# ENABLE(SHADOW_DOM) is disabled +# https://bugs.webkit.org/show_bug.cgi?id=76439 +fast/dom/shadow/content-element-api.html +fast/dom/shadow/content-element-outside-shadow.html + +# https://bugs.webkit.org/show_bug.cgi?id=77413 +fast/parser/nested-fragment-parser-crash.html Added: trunk/LayoutTests/platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt (0 => 106345) --- trunk/LayoutTests/platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt 2012-01-31 09:36:07 UTC (rev 106345) @@ -0,0 +1,69 @@ +Make sure prototypes are set up using the window a property came from, instead of the lexical global object. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS (new inner.Audio()).isInner is true +PASS (new inner.Audio()).constructor.isInner is true +PASS (new inner.BeforeLoadEvent()).isInner is true +PASS (new inner.BeforeLoadEvent()).constructor.isInner is true +PASS (new inner.CloseEvent()).isInner is true +PASS (new inner.CloseEvent()).constructor.isInner is true +PASS (new inner.CustomEvent()).isInner is true +PASS (new inner.CustomEvent()).constructor.isInner is true +PASS (new inner.DOMParser()).isInner is true +PASS (new inner.DOMParser()).constructor.isInner is true +PASS (new inner.ErrorEvent()).isInner is true +PASS (new inner.ErrorEvent()).constructor.isInner is true +PASS (new inner.Event()).isInner is true +PASS (new inner.Event()).constructor.isInner is true +PASS (new inner.FormData()).isInner is true +PASS (new inner.FormData()).constructor.isInner is true +PASS (new inner.HashChangeEvent()).isInner is true +PASS (new inner.HashChangeEvent()).constructor.isInner is true +PASS (new inner.Image()).isInner is true +PASS (new inner.Image()).constructor.isInner is true +PASS (new inner.MediaController()).isInner is true +PASS (new inner.MediaController()).constructor.isInner is true +PASS (new inner.MessageChannel()).isInner is true +PASS (new inner.MessageChannel()).constructor.isInner is true +PASS (new inner.MessageEvent()).isInner is true +PASS (new inner.MessageEvent()).constructor.isInner is true +PASS (new inner.Option()).isInner is true +PASS (new inner.Option()).constructor.isInner is true +PASS (new inner.OverflowEvent()).isInner is true +PASS (new inner.OverflowEvent()).constructor.isInner is true +PASS (new inner.PageTransitionEvent()).isInner is true +PASS (new inner.PageTransitionEvent()).constructor.isInner is true +PASS (new inner.PopStateEvent()).isInner is true +PASS (new inner.PopStateEvent()).constructor.isInner is true +PASS (new inner.ProgressEvent()).isInner is true +PASS (new inner.ProgressEvent()).constructor.isInner is true +PASS (new inner.StorageEvent()).isInner is true +PASS (new inner.StorageEvent()).constructor.isInner is true +PASS (new inner.TrackEvent()).isInner is true +PASS (new
[webkit-changes] [106347] trunk/Source/WebCore
Title: [106347] trunk/Source/WebCore
Revision 106347
Author pfeld...@chromium.org
Date 2012-01-31 02:05:34 -0800 (Tue, 31 Jan 2012)
Log Message
Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
https://bugs.webkit.org/show_bug.cgi?id=77409
Reviewed by Yury Semikhatsky.
* inspector/Inspector.json:
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore):
(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
* inspector/InspectorDOMDebuggerAgent.h:
(InspectorDOMDebuggerAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp
trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (106346 => 106347)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 10:01:23 UTC (rev 106346)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 10:05:34 UTC (rev 106347)
@@ -1,3 +1,34 @@
+2012-01-31 Pavel Feldman pfeld...@google.com
+
+Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
+https://bugs.webkit.org/show_bug.cgi?id=77409
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/Inspector.json:
+* inspector/InspectorDOMDebuggerAgent.cpp:
+(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
+(WebCore):
+(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
+(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
+(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
+(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
+(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
+(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
+* inspector/InspectorDOMDebuggerAgent.h:
+(InspectorDOMDebuggerAgent):
+* inspector/InspectorInstrumentation.cpp:
+(WebCore::InspectorInstrumentation::didInstallTimerImpl):
+(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
+(WebCore::InspectorInstrumentation::willHandleEventImpl):
+(WebCore::InspectorInstrumentation::willFireTimerImpl):
+(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
+* inspector/InspectorInstrumentation.h:
+(InspectorInstrumentation):
+* inspector/front-end/BreakpointsSidebarPane.js:
+(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
+(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
+
2012-01-31 Pablo Flouret pab...@motorola.com
Fix compilation errors on build-webkit --debug --no-workers on mac.
Modified: trunk/Source/WebCore/inspector/Inspector.json (106346 => 106347)
--- trunk/Source/WebCore/inspector/Inspector.json 2012-01-31 10:01:23 UTC (rev 106346)
+++ trunk/Source/WebCore/inspector/Inspector.json 2012-01-31 10:05:34 UTC (rev 106347)
@@ -2268,7 +2268,7 @@
{
name: setEventListenerBreakpoint,
parameters: [
-{ name: eventName, type: string, description: Event name to stop on (any DOM event will do). }
+{ name: eventName, type: string, description: DOM Event name to stop on (any DOM event will do). }
],
description: Sets breakpoint on particular DOM event.
},
@@ -2280,6 +2280,22 @@
description: Removes breakpoint on particular DOM event.
},
{
+name: setInstrumentationBreakpoint,
+parameters: [
+{ name: eventName, type: string, description: Instrumentation name to stop on. }
+
[webkit-changes] [106348] trunk
Title: [106348] trunk
Revision 106348
Author commit-qu...@webkit.org
Date 2012-01-31 02:13:51 -0800 (Tue, 31 Jan 2012)
Log Message
[PerformanceTests] Add landing html for Dromaeo dom-query test
https://bugs.webkit.org/show_bug.cgi?id=77329
Patch by Hajime Morrita morr...@chromium.org on 2012-01-31
Reviewed by Ryosuke Niwa.
PerformanceTests:
Added a landing html which includes actual dromaemo page and
send messages to interact with it. The landing html also dumps the
score in run-perf-tests friendly format.
This test isn't enabled until Dromaemo itself is available for run-perf-tests.
It will happen in a separate change.
* Dromaeo/dom-query.html: Added.
* Dromaeo/resources/dromaeorunner.js: Added.
* Skipped: Skipping this for now.
Tools:
Added some more ignorable output patterns to allow warnings
from a third party test suite.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._should_ignore_line_in_parser_test_result):
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Skipped
trunk/PerformanceTests/resources/runner.js
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
Added Paths
trunk/PerformanceTests/Dromaeo/
trunk/PerformanceTests/Dromaeo/dom-query.html
trunk/PerformanceTests/Dromaeo/resources/
trunk/PerformanceTests/Dromaeo/resources/dromaeorunner.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (106347 => 106348)
--- trunk/PerformanceTests/ChangeLog 2012-01-31 10:05:34 UTC (rev 106347)
+++ trunk/PerformanceTests/ChangeLog 2012-01-31 10:13:51 UTC (rev 106348)
@@ -1,3 +1,21 @@
+2012-01-31 Hajime Morrita morr...@chromium.org
+
+[PerformanceTests] Add landing html for Dromaeo dom-query test
+https://bugs.webkit.org/show_bug.cgi?id=77329
+
+Reviewed by Ryosuke Niwa.
+
+Added a landing html which includes actual dromaemo page and
+send messages to interact with it. The landing html also dumps the
+score in run-perf-tests friendly format.
+
+This test isn't enabled until Dromaemo itself is available for run-perf-tests.
+It will happen in a separate change.
+
+* Dromaeo/dom-query.html: Added.
+* Dromaeo/resources/dromaeorunner.js: Added.
+* Skipped: Skipping this for now.
+
2012-01-30 Ryosuke Niwa rn...@webkit.org
Skip inspector tests since they have been timing out.
Added: trunk/PerformanceTests/Dromaeo/dom-query.html (0 => 106348)
--- trunk/PerformanceTests/Dromaeo/dom-query.html (rev 0)
+++ trunk/PerformanceTests/Dromaeo/dom-query.html 2012-01-31 10:13:51 UTC (rev 106348)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+script src=""
+script
+$(document).ready(function() {
+DRT.setup(dom-query);
+});
+/script
+/head
+body
+pre id=console/pre
+/body
+/html
Added: trunk/PerformanceTests/Dromaeo/resources/dromaeorunner.js (0 => 106348)
--- trunk/PerformanceTests/Dromaeo/resources/dromaeorunner.js (rev 0)
+++ trunk/PerformanceTests/Dromaeo/resources/dromaeorunner.js 2012-01-31 10:13:51 UTC (rev 106348)
@@ -0,0 +1,89 @@
+(function(){
+ var DRT = {
+ baseURL: ./resources/dromaeo/web/index.html,
+
+ computeScores: function (results) {
+ var avg = 0, min = 0, max = 0, stdev = 0, varsum = 0;
+
+ for (var i = 0; i results.length; ++i) {
+ var item = results[i];
+ avg += item.mean;
+ min += item.min;
+ max += item.max;
+ varsum += item.deviation * item.deviation;
+ }
+
+ return {
+ median: 0,
+ avg: avg,
+ min: min,
+ max: max,
+ stdev: Math.sqrt(varsum)
+ };
+ },
+
+ setup: function(testName) {
+ var iframe = document.createElement(iframe);
+ var url = "" + ? + testName;
+ iframe.setAttribute(src, url);
+ document.body.appendChild(iframe);
+ iframe.addEventListener(
+ load, function() {
+ DRT.targetDocument = iframe.contentDocument;
+ DRT.targetWindow = iframe.contentDocument.defaultView;
+ });
+
+ window.addEventListener(
+ message,
+ function(event) {
+ switch(event.data.name) {
+ case dromaeo:ready:
+ DRT.start();
+ break;
+ case dromaeo:progress:
+ DRT.progress(event.data);
+ break;
+ case dromaeo:alldone:
+ DRT.teardown(event.data);
+ break;
+ }
+ });
+ },
+
+ start: function() {
+
[webkit-changes] [106350] trunk/Source/WebKit/chromium
Title: [106350] trunk/Source/WebKit/chromium
Revision 106350
Author commit-qu...@webkit.org
Date 2012-01-31 02:45:33 -0800 (Tue, 31 Jan 2012)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot webkit.review@gmail.com on 2012-01-31
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106349 => 106350)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 10:39:11 UTC (rev 106349)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 10:45:33 UTC (rev 106350)
@@ -1,3 +1,9 @@
+2012-01-31 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-01-30 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r106324.
Modified: trunk/Source/WebKit/chromium/DEPS (106349 => 106350)
--- trunk/Source/WebKit/chromium/DEPS 2012-01-31 10:39:11 UTC (rev 106349)
+++ trunk/Source/WebKit/chromium/DEPS 2012-01-31 10:45:33 UTC (rev 106350)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '119700'
+ 'chromium_rev': '119875'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106354] trunk/Source/WebCore
Title: [106354] trunk/Source/WebCore
Revision 106354
Author commit-qu...@webkit.org
Date 2012-01-31 04:11:35 -0800 (Tue, 31 Jan 2012)
Log Message
Web Inspector: show sizes in bytes instead of KB, MB in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=77199
Patch by Alexei Filippov alex...@chromium.org on 2012-01-31
Reviewed by Pavel Feldman.
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
* inspector/front-end/UIUtils.js:
(Number.withThousandsSeparator):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js
trunk/Source/WebCore/inspector/front-end/UIUtils.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (106353 => 106354)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 11:59:43 UTC (rev 106353)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 12:11:35 UTC (rev 106354)
@@ -1,3 +1,18 @@
+2012-01-31 Alexei Filippov alex...@chromium.org
+
+Web Inspector: show sizes in bytes instead of KB, MB in heap profiler.
+https://bugs.webkit.org/show_bug.cgi?id=77199
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/DetailedHeapshotGridNodes.js:
+(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
+(WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
+(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
+(WebInspector.HeapSnapshotDiffNode.prototype.get data):
+* inspector/front-end/UIUtils.js:
+(Number.withThousandsSeparator):
+
2012-01-26 Hans Wennborg h...@chromium.org
Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js (106353 => 106354)
--- trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js 2012-01-31 11:59:43 UTC (rev 106353)
+++ trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js 2012-01-31 12:11:35 UTC (rev 106354)
@@ -268,8 +268,8 @@
data[object] = { valueStyle: valueStyle, value: value + : @ + this.snapshotNodeId };
var view = this.dataGrid.snapshotView;
-data[shallowSize] = view.showShallowSizeAsPercent ? WebInspector.UIString(%.2f%%, this._shallowSizePercent) : Number.bytesToString(this._shallowSize);
-data[retainedSize] = view.showRetainedSizeAsPercent ? WebInspector.UIString(%.2f%%, this._retainedSizePercent) : Number.bytesToString(this._retainedSize);
+data[shallowSize] = view.showShallowSizeAsPercent ? WebInspector.UIString(%.2f%%, this._shallowSizePercent) : Number.withThousandsSeparator(this._shallowSize);
+data[retainedSize] = view.showRetainedSizeAsPercent ? WebInspector.UIString(%.2f%%, this._retainedSizePercent) : Number.withThousandsSeparator(this._retainedSize);
return this._enhanceData ? this._enhanceData(data) : data;
},
@@ -503,10 +503,10 @@
data[addedCount] = ;
data[addedSize] = ;
data[removedCount] = \u2022;
-data[removedSize] = Number.bytesToString(this._shallowSize);
+data[removedSize] = Number.withThousandsSeparator(this._shallowSize);
} else {
data[addedCount] = \u2022;
-data[addedSize] = Number.bytesToString(this._shallowSize);
+data[addedSize] = Number.withThousandsSeparator(this._shallowSize);
data[removedCount] = ;
data[removedSize] = ;
}
@@ -570,8 +570,8 @@
var data = "" this._name, count: this._count};
var view = this.dataGrid.snapshotView;
data[count] = view.showCountAsPercent ? WebInspector.UIString(%.2f%%, this._countPercent) : this._count;
-data[shallowSize] = view.showShallowSizeAsPercent ? WebInspector.UIString(%.2f%%, this._shallowSizePercent) : Number.bytesToString(this._shallowSize);
-data[retainedSize] = + (view.showRetainedSizeAsPercent ? WebInspector.UIString(%.2f%%, this._retainedSizePercent) : Number.bytesToString(this._retainedSize));
+data[shallowSize] = view.showShallowSizeAsPercent ? WebInspector.UIString(%.2f%%, this._shallowSizePercent) : Number.withThousandsSeparator(this._shallowSize);
+data[retainedSize] = view.showRetainedSizeAsPercent ? ~ + WebInspector.UIString(%.2f%%, this._retainedSizePercent) : Number.withThousandsSeparator(this._retainedSize) + +;
return data;
},
@@ -751,9 +751,9 @@
data[addedCount] = this._addedCount;
data[removedCount] = this._removedCount;
data[countDelta] = WebInspector.UIString(%s%d, this._signForDelta(this._countDelta), Math.abs(this._countDelta));
-data[addedSize] =
[webkit-changes] [106358] trunk/Source/WebCore
Title: [106358] trunk/Source/WebCore
Revision 106358
Author an...@apple.com
Date 2012-01-31 06:58:37 -0800 (Tue, 31 Jan 2012)
Log Message
Parent SVGFontFaceElements style declaration to the rule
https://bugs.webkit.org/show_bug.cgi?id=77421
Reviewed by Adam Roben.
For some reason the declaration is parented to the element which adds a bunch of unnecessary special case code.
The invalidation on mutation is done explicitly by SVGFontFaceElement so that is not affected. The declaration
is not exposed so the change is not observable with a test.
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::~CSSFontFaceRule):
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::createInline):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::parseMappedAttribute):
(WebCore::SVGFontFaceElement::fontFamily):
(WebCore::SVGFontFaceElement::rebuildFontFace):
* svg/SVGFontFaceElement.h:
Remove the unnecessary m_styleDeclaration field, access through m_fontFaceRule instead.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceRule.cpp
trunk/Source/WebCore/css/CSSMutableStyleDeclaration.h
trunk/Source/WebCore/svg/SVGFontFaceElement.cpp
trunk/Source/WebCore/svg/SVGFontFaceElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (106357 => 106358)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 14:28:13 UTC (rev 106357)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 14:58:37 UTC (rev 106358)
@@ -1,3 +1,27 @@
+2012-01-31 Antti Koivisto an...@apple.com
+
+Parent SVGFontFaceElements style declaration to the rule
+https://bugs.webkit.org/show_bug.cgi?id=77421
+
+Reviewed by Adam Roben.
+
+For some reason the declaration is parented to the element which adds a bunch of unnecessary special case code.
+The invalidation on mutation is done explicitly by SVGFontFaceElement so that is not affected. The declaration
+is not exposed so the change is not observable with a test.
+
+* css/CSSFontFaceRule.cpp:
+(WebCore::CSSFontFaceRule::~CSSFontFaceRule):
+* css/CSSMutableStyleDeclaration.h:
+(WebCore::CSSMutableStyleDeclaration::createInline):
+* svg/SVGFontFaceElement.cpp:
+(WebCore::SVGFontFaceElement::SVGFontFaceElement):
+(WebCore::SVGFontFaceElement::parseMappedAttribute):
+(WebCore::SVGFontFaceElement::fontFamily):
+(WebCore::SVGFontFaceElement::rebuildFontFace):
+* svg/SVGFontFaceElement.h:
+
+Remove the unnecessary m_styleDeclaration field, access through m_fontFaceRule instead.
+
2012-01-31 Kenneth Rohde Christiansen kenn...@webkit.org
Tap highlighting: Support better outlines for multiline inlines
Modified: trunk/Source/WebCore/css/CSSFontFaceRule.cpp (106357 => 106358)
--- trunk/Source/WebCore/css/CSSFontFaceRule.cpp 2012-01-31 14:28:13 UTC (rev 106357)
+++ trunk/Source/WebCore/css/CSSFontFaceRule.cpp 2012-01-31 14:58:37 UTC (rev 106358)
@@ -33,8 +33,7 @@
CSSFontFaceRule::~CSSFontFaceRule()
{
-// FIXME: SVGFontFaceElement's style declaration should probably be parented to the rule too.
-if (m_style !m_style-isElementStyleDeclaration())
+if (m_style)
m_style-clearParentRule();
}
Modified: trunk/Source/WebCore/css/CSSMutableStyleDeclaration.h (106357 => 106358)
--- trunk/Source/WebCore/css/CSSMutableStyleDeclaration.h 2012-01-31 14:28:13 UTC (rev 106357)
+++ trunk/Source/WebCore/css/CSSMutableStyleDeclaration.h 2012-01-31 14:58:37 UTC (rev 106358)
@@ -57,10 +57,6 @@
{
return adoptRef(new CSSMutableStyleDeclaration(element, true));
}
-static PassRefPtrCSSMutableStyleDeclaration createForSVGFontFaceElement(StyledElement* element)
-{
-return adoptRef(new CSSMutableStyleDeclaration(element, false));
-}
unsigned propertyCount() const { return m_properties.size(); }
bool isEmpty() const { return m_properties.isEmpty(); }
Modified: trunk/Source/WebCore/svg/SVGFontFaceElement.cpp (106357 => 106358)
--- trunk/Source/WebCore/svg/SVGFontFaceElement.cpp 2012-01-31 14:28:13 UTC (rev 106357)
+++ trunk/Source/WebCore/svg/SVGFontFaceElement.cpp 2012-01-31 14:58:37 UTC (rev 106358)
@@ -49,11 +49,11 @@
inline SVGFontFaceElement::SVGFontFaceElement(const QualifiedName tagName, Document* document)
: SVGElement(tagName, document)
, m_fontFaceRule(CSSFontFaceRule::create())
-, m_styleDeclaration(CSSMutableStyleDeclaration::createForSVGFontFaceElement(this))
{
ASSERT(hasTagName(font_faceTag));
-m_styleDeclaration-setStrictParsing(true);
-m_fontFaceRule-setDeclaration(m_styleDeclaration.get());
+RefPtrCSSMutableStyleDeclaration styleDeclaration = CSSMutableStyleDeclaration::create(m_fontFaceRule.get());
+styleDeclaration-setStrictParsing(true);
+m_fontFaceRule-setDeclaration(styleDeclaration.release());
}
[webkit-changes] [106359] trunk/Tools
Title: [106359] trunk/Tools Revision 106359 Author aro...@apple.com Date 2012-01-31 07:09:33 -0800 (Tue, 31 Jan 2012) Log Message Only call -typingAttributes on WebViews, not WebHTMLViews Looks like this case was just missed in r105908. Fixes http://webkit.org/b/77432 REGRESSION (r105908): WebKit1.InspectorBarTest is crashing Reviewed by Antti Koivisto. * TestWebKitAPI/Tests/mac/InspectorBar.mm: (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines earlier. Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm Diff Modified: trunk/Tools/ChangeLog (106358 => 106359) --- trunk/Tools/ChangeLog 2012-01-31 14:58:37 UTC (rev 106358) +++ trunk/Tools/ChangeLog 2012-01-31 15:09:33 UTC (rev 106359) @@ -1,3 +1,17 @@ +2012-01-31 Adam Roben aro...@apple.com + +Only call -typingAttributes on WebViews, not WebHTMLViews + +Looks like this case was just missed in r105908. + +Fixes http://webkit.org/b/77432 REGRESSION (r105908): WebKit1.InspectorBarTest is crashing + +Reviewed by Antti Koivisto. + +* TestWebKitAPI/Tests/mac/InspectorBar.mm: +(TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines +earlier. + 2012-01-31 Jocelyn Turcotte jocelyn.turco...@nokia.com [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down. Modified: trunk/Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm (106358 => 106359) --- trunk/Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm 2012-01-31 14:58:37 UTC (rev 106358) +++ trunk/Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm 2012-01-31 15:09:33 UTC (rev 106359) @@ -66,7 +66,7 @@ EXPECT_TRUE([webView.get() respondsToSelector:@selector(typingAttributes)]); NSDictionary *attributes = [(id)webView.get() typingAttributes]; [(id)[[[webView.get() mainFrame] frameView] documentView] doCommandBySelector:@selector(bold:)]; -EXPECT_FALSE([attributes isEqual:[(id)[[[webView.get() mainFrame] frameView] documentView] typingAttributes]]); +EXPECT_FALSE([attributes isEqual:[(id)webView.get() typingAttributes]]); [webView.get() selectAll:nil]; NSAttributedString *attrString = [(NSView NSTextInput *)[[[webView.get() mainFrame] frameView] documentView] attributedSubstringFromRange:NSMakeRange(0, 5)]; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106360] trunk/Source/WebCore
Title: [106360] trunk/Source/WebCore Revision 106360 Author vse...@chromium.org Date 2012-01-31 07:35:04 -0800 (Tue, 31 Jan 2012) Log Message Web Inspector: CodeGeneratorInspector.py: reimplement generated array types https://bugs.webkit.org/show_bug.cgi?id=77289 Patch by Peter Rybin peter.ry...@gmail.com on 2012-01-31 Reviewed by Vsevolod Vlasov. Arrays are now rendered as a single template class. Its type-specific details are provided by an additional ArrayItemHelper class that is defined using C++ specialization technique. * inspector/CodeGeneratorInspector.py: (RawTypes.String): (RawTypes.String.get_array_item_raw_c_type_text): (RawTypes.Int): (RawTypes.Int.get_array_item_raw_c_type_text): (RawTypes.Number): (RawTypes.Number.get_array_item_raw_c_type_text): (RawTypes.Bool): (RawTypes.Bool.get_array_item_raw_c_type_text): (RawTypes.Object): (RawTypes.Object.get_array_item_raw_c_type_text): (RawTypes.Any): (RawTypes.Any.get_array_item_raw_c_type_text): (RawTypes.Array): (RawTypes.Array.get_array_item_raw_c_type_text): (RawTypes): (TypeBindings.create_type_declaration_.EnumBinding): (TypeBindings.create_type_declaration_.EnumBinding.get_array_item_c_type_text): (TypeBindings.create_type_declaration_.PlainString): (TypeBindings.create_type_declaration_.PlainString.get_array_item_c_type_text): (TypeBindings.create_type_declaration_.TypedefString): (TypeBindings.create_type_declaration_.TypedefString.get_array_item_c_type_text): (StructItemTraits): (get_array_item_c_type_text): (PlainObjectBinding): (PlainObjectBinding.get_array_item_c_type_text): (AdHocTypeContext): (AdHocTypeContext.get_type_name_fix): (AdHocTypeContext.add_type): (ArrayBinding): (ArrayBinding.resolve_inner): (ArrayBinding.resolve_inner.ResolveData): (ArrayBinding.request_user_runtime_cast): (ArrayBinding.request_internal_runtime_cast): (ArrayBinding.get_code_generator): (ArrayBinding.get_code_generator.CodeGenerator): (ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder): (ArrayBinding.get_code_generator.CodeGenerator.generate_forward_declaration): (ArrayBinding.get_code_generator.CodeGenerator.register_use): (ArrayBinding.get_code_generator.CodeGenerator.get_generate_pass_id): (ArrayBinding.get_validator_call_text): (ArrayBinding.get_in_c_type_text): (ArrayBinding.get_array_item_c_type_text): (ArrayBinding.get_setter_value_expression_pattern): (ArrayBinding.reduce_to_raw_type): (RawTypeBinding.get_array_item_c_type_text): (ArrayItemHelper): (typename): (ArrayOf): (Traits): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/CodeGeneratorInspector.py Diff Modified: trunk/Source/WebCore/ChangeLog (106359 => 106360) --- trunk/Source/WebCore/ChangeLog 2012-01-31 15:09:33 UTC (rev 106359) +++ trunk/Source/WebCore/ChangeLog 2012-01-31 15:35:04 UTC (rev 106360) @@ -1,3 +1,65 @@ +2012-01-31 Peter Rybin peter.ry...@gmail.com + +Web Inspector: CodeGeneratorInspector.py: reimplement generated array types +https://bugs.webkit.org/show_bug.cgi?id=77289 + +Reviewed by Vsevolod Vlasov. + +Arrays are now rendered as a single template class. Its type-specific +details are provided by an additional ArrayItemHelper class that is +defined using C++ specialization technique. + +* inspector/CodeGeneratorInspector.py: +(RawTypes.String): +(RawTypes.String.get_array_item_raw_c_type_text): +(RawTypes.Int): +(RawTypes.Int.get_array_item_raw_c_type_text): +(RawTypes.Number): +(RawTypes.Number.get_array_item_raw_c_type_text): +(RawTypes.Bool): +(RawTypes.Bool.get_array_item_raw_c_type_text): +(RawTypes.Object): +(RawTypes.Object.get_array_item_raw_c_type_text): +(RawTypes.Any): +(RawTypes.Any.get_array_item_raw_c_type_text): +(RawTypes.Array): +(RawTypes.Array.get_array_item_raw_c_type_text): +(RawTypes): +(TypeBindings.create_type_declaration_.EnumBinding): +(TypeBindings.create_type_declaration_.EnumBinding.get_array_item_c_type_text): +(TypeBindings.create_type_declaration_.PlainString): +(TypeBindings.create_type_declaration_.PlainString.get_array_item_c_type_text): +(TypeBindings.create_type_declaration_.TypedefString): +(TypeBindings.create_type_declaration_.TypedefString.get_array_item_c_type_text): +(StructItemTraits): +(get_array_item_c_type_text): +(PlainObjectBinding): +(PlainObjectBinding.get_array_item_c_type_text): +(AdHocTypeContext): +(AdHocTypeContext.get_type_name_fix): +(AdHocTypeContext.add_type): +(ArrayBinding): +(ArrayBinding.resolve_inner): +(ArrayBinding.resolve_inner.ResolveData): +(ArrayBinding.request_user_runtime_cast): +(ArrayBinding.request_internal_runtime_cast): +(ArrayBinding.get_code_generator): +
[webkit-changes] [106361] trunk
Title: [106361] trunk
Revision 106361
Author commit-qu...@webkit.org
Date 2012-01-31 08:44:15 -0800 (Tue, 31 Jan 2012)
Log Message
The spec renamed addTrack() to addTextTrack().
https://bugs.webkit.org/show_bug.cgi?id=77381
Patch by Arko Saha a...@motorola.com on 2012-01-31
Reviewed by Eric Carlson.
Renamed addTrack() to addTextTrack().
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#media-elements
Source/WebCore:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addTextTrack):
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::addTextTrack):
* html/HTMLMediaElement.idl:
LayoutTests:
* media/track/track-add-track-expected.txt:
* media/track/track-add-track.html:
* media/track/track-addtrack-kind-expected.txt:
* media/track/track-addtrack-kind.html:
* media/track/track-text-track-destructor-crash.html:
* media/track/track-texttracks-expected.txt:
* media/track/track-texttracks.html:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/track-add-track-expected.txt
trunk/LayoutTests/media/track/track-add-track.html
trunk/LayoutTests/media/track/track-addtrack-kind-expected.txt
trunk/LayoutTests/media/track/track-addtrack-kind.html
trunk/LayoutTests/media/track/track-text-track-destructor-crash.html
trunk/LayoutTests/media/track/track-texttracks-expected.txt
trunk/LayoutTests/media/track/track-texttracks.html
trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt
trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLMediaElement.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (106360 => 106361)
--- trunk/LayoutTests/ChangeLog 2012-01-31 15:35:04 UTC (rev 106360)
+++ trunk/LayoutTests/ChangeLog 2012-01-31 16:44:15 UTC (rev 106361)
@@ -1,3 +1,23 @@
+2012-01-31 Arko Saha a...@motorola.com
+
+The spec renamed addTrack() to addTextTrack().
+https://bugs.webkit.org/show_bug.cgi?id=77381
+
+Reviewed by Eric Carlson.
+
+Renamed addTrack() to addTextTrack().
+Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#media-elements
+
+* media/track/track-add-track-expected.txt:
+* media/track/track-add-track.html:
+* media/track/track-addtrack-kind-expected.txt:
+* media/track/track-addtrack-kind.html:
+* media/track/track-text-track-destructor-crash.html:
+* media/track/track-texttracks-expected.txt:
+* media/track/track-texttracks.html:
+* platform/gtk/fast/dom/Window/window-properties-expected.txt:
+* platform/mac/fast/dom/Window/window-properties-expected.txt:
+
2012-01-31 Yuzo Fujishima y...@google.com
[Chromium] Unreviewed test expectation change.
Modified: trunk/LayoutTests/media/track/track-add-track-expected.txt (106360 => 106361)
--- trunk/LayoutTests/media/track/track-add-track-expected.txt 2012-01-31 15:35:04 UTC (rev 106360)
+++ trunk/LayoutTests/media/track/track-add-track-expected.txt 2012-01-31 16:44:15 UTC (rev 106361)
@@ -11,8 +11,8 @@
EXPECTED (event instanceof window.TrackEvent == 'true') OK
EXPECTED (event.track == '[object TextTrack]') OK
-** Test a TextTrack created with video.addTrack().
-RUN(tracks.push(video.addTrack('captions', 'Caption Track', 'en')))
+** Test a TextTrack created with video.addTextTrack().
+RUN(tracks.push(video.addTextTrack('captions', 'Caption Track', 'en')))
EXPECTED (video.textTracks.length == '2') OK
EVENT(addtrack)
EXPECTED (event.target == '[object TextTrackList]') OK
Modified: trunk/LayoutTests/media/track/track-add-track.html (106360 => 106361)
--- trunk/LayoutTests/media/track/track-add-track.html 2012-01-31 15:35:04 UTC (rev 106360)
+++ trunk/LayoutTests/media/track/track-add-track.html 2012-01-31 16:44:15 UTC (rev 106361)
@@ -18,8 +18,8 @@
testExpected(event.track, tracks[video.textTracks.length - 1]);
if (video.textTracks.length == 1) {
-consoleWrite(br** Test a TextTrack created with video.addTrack().);
-run(tracks.push(video.addTrack('captions', 'Caption Track', 'en')));
+consoleWrite(br** Test a TextTrack created with video.addTextTrack().);
+run(tracks.push(video.addTextTrack('captions', 'Caption Track', 'en')));
testExpected(video.textTracks.length, 2);
} else {
consoleWrite();
Modified: trunk/LayoutTests/media/track/track-addtrack-kind-expected.txt (106360 => 106361)
--- trunk/LayoutTests/media/track/track-addtrack-kind-expected.txt 2012-01-31 15:35:04 UTC (rev 106360)
+++
[webkit-changes] [106362] trunk/Source/WebKit2
Title: [106362] trunk/Source/WebKit2
Revision 106362
Author commit-qu...@webkit.org
Date 2012-01-31 09:09:13 -0800 (Tue, 31 Jan 2012)
Log Message
Ensure tiles are repainted when scrolling using mouse wheel.
https://bugs.webkit.org/show_bug.cgi?id=77339
A new slot visibleContentRectAndScaleChanged has been added
that is emited by non-animated scrolling code in the
QtViewportInteractionEngine.
Patch by Allan Sandfeld Jensen allan.jen...@nokia.com on 2012-01-31
Reviewed by Kenneth Rohde Christiansen.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::_q_resume):
(QQuickWebViewPrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::updateTouchViewportSize):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::wheelEvent):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (106361 => 106362)
--- trunk/Source/WebKit2/ChangeLog 2012-01-31 16:44:15 UTC (rev 106361)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-31 17:09:13 UTC (rev 106362)
@@ -1,3 +1,28 @@
+2012-01-31 Allan Sandfeld Jensen allan.jen...@nokia.com
+
+Ensure tiles are repainted when scrolling using mouse wheel.
+https://bugs.webkit.org/show_bug.cgi?id=77339
+
+A new slot visibleContentRectAndScaleChanged has been added
+that is emited by non-animated scrolling code in the
+QtViewportInteractionEngine.
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::initializeDesktop):
+(QQuickWebViewPrivate::initializeTouch):
+(QQuickWebViewPrivate::_q_resume):
+(QQuickWebViewPrivate::_q_updateVisibleContentRectAndScale):
+(QQuickWebViewPrivate::updateTouchViewportSize):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/qquickwebview_p_p.h:
+(QQuickWebViewPrivate):
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::QtViewportInteractionEngine::wheelEvent):
+* UIProcess/qt/QtViewportInteractionEngine.h:
+(QtViewportInteractionEngine):
+
2012-01-31 Zeno Albisser z...@webkit.org
[Qt][WK2] Make UIProcess decide about encoding of input data for application URL schemes.
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (106361 => 106362)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-01-31 16:44:15 UTC (rev 106361)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-01-31 17:09:13 UTC (rev 106362)
@@ -137,6 +137,7 @@
QObject::disconnect(interactionEngine.data(), SIGNAL(contentSuspendRequested()), viewport, SLOT(_q_suspend()));
QObject::disconnect(interactionEngine.data(), SIGNAL(contentResumeRequested()), viewport, SLOT(_q_resume()));
QObject::disconnect(interactionEngine.data(), SIGNAL(viewportTrajectoryVectorChanged(const QPointF)), viewport, SLOT(_q_viewportTrajectoryVectorChanged(const QPointF)));
+QObject::disconnect(interactionEngine.data(), SIGNAL(visibleContentRectAndScaleChanged()), viewport, SLOT(_q_updateVisibleContentRectAndScale()));
}
interactionEngine.reset(0);
pageView-d-eventHandler-setViewportInteractionEngine(0);
@@ -152,6 +153,7 @@
QObject::connect(interactionEngine.data(), SIGNAL(contentSuspendRequested()), viewport, SLOT(_q_suspend()));
QObject::connect(interactionEngine.data(), SIGNAL(contentResumeRequested()), viewport, SLOT(_q_resume()));
QObject::connect(interactionEngine.data(), SIGNAL(viewportTrajectoryVectorChanged(const QPointF)), viewport, SLOT(_q_viewportTrajectoryVectorChanged(const QPointF)));
+QObject::connect(interactionEngine.data(), SIGNAL(visibleContentRectAndScaleChanged()), viewport, SLOT(_q_updateVisibleContentRectAndScale()));
updateTouchViewportSize();
}
@@ -214,7 +216,7 @@
postTransitionState-apply();
}
-updateVisibleContentRectAndScale();
+_q_updateVisibleContentRectAndScale();
}
void QQuickWebViewPrivate::didChangeContentsSize(const QSize newSize)
@@ -298,7 +300,7 @@
context-downloadManager()-addDownload(download, downloadItem);
}
-void QQuickWebViewPrivate::updateVisibleContentRectAndScale()
+void QQuickWebViewPrivate::_q_updateVisibleContentRectAndScale()
{
DrawingAreaProxy* drawingArea = webPageProxy-drawingArea();
if (!drawingArea)
@@ -365,7
[webkit-changes] [106363] trunk/Tools
Title: [106363] trunk/Tools
Revision 106363
Author o...@webkit.org
Date 2012-01-31 09:11:45 -0800 (Tue, 31 Jan 2012)
Log Message
If the QTDIR environment variable is set, the build system fails to compile WinCairo
https://bugs.webkit.org/show_bug.cgi?id=77112
Reviewed by Daniel Bates.
* Scripts/webkitdirs.pm:
(determineIsQt):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (106362 => 106363)
--- trunk/Tools/ChangeLog 2012-01-31 17:09:13 UTC (rev 106362)
+++ trunk/Tools/ChangeLog 2012-01-31 17:11:45 UTC (rev 106363)
@@ -1,3 +1,13 @@
+2012-01-31 Csaba Osztrogonác o...@webkit.org
+
+If the QTDIR environment variable is set, the build system fails to compile WinCairo
+https://bugs.webkit.org/show_bug.cgi?id=77112
+
+Reviewed by Daniel Bates.
+
+* Scripts/webkitdirs.pm:
+(determineIsQt):
+
2012-01-31 Adam Roben aro...@apple.com
Only call -typingAttributes on WebViews, not WebHTMLViews
Modified: trunk/Tools/Scripts/webkitdirs.pm (106362 => 106363)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-01-31 17:09:13 UTC (rev 106362)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-01-31 17:11:45 UTC (rev 106363)
@@ -879,12 +879,12 @@
return;
}
-# The presence of QTDIR only means Qt if --gtk or --wx or --efl or --blackberry or --chromium are not on the command-line
-if (isGtk() || isWx() || isEfl() || isBlackBerry() || isChromium()) {
+# The presence of QTDIR only means Qt if --gtk or --wx or --efl or --blackberry or --chromium or --wincairo are not on the command-line
+if (isGtk() || isWx() || isEfl() || isBlackBerry() || isChromium() || isWinCairo()) {
$isQt = 0;
return;
}
-
+
$isQt = defined($ENV{'QTDIR'});
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106364] trunk/Source/WebCore
Title: [106364] trunk/Source/WebCore Revision 106364 Author alexis.men...@openbossa.org Date 2012-01-31 09:29:00 -0800 (Tue, 31 Jan 2012) Log Message Unreviewed include cleanup. Tested locally on Qt and Chromium port. * dom/Node.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Node.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (106363 => 106364) --- trunk/Source/WebCore/ChangeLog 2012-01-31 17:11:45 UTC (rev 106363) +++ trunk/Source/WebCore/ChangeLog 2012-01-31 17:29:00 UTC (rev 106364) @@ -1,3 +1,11 @@ +2012-01-31 Alexis Menard alexis.men...@openbossa.org + +Unreviewed include cleanup. + +Tested locally on Qt and Chromium port. + +* dom/Node.cpp: + 2012-01-31 Arko Saha a...@motorola.com The spec renamed addTrack() to addTextTrack(). Modified: trunk/Source/WebCore/dom/Node.cpp (106363 => 106364) --- trunk/Source/WebCore/dom/Node.cpp 2012-01-31 17:11:45 UTC (rev 106363) +++ trunk/Source/WebCore/dom/Node.cpp 2012-01-31 17:29:00 UTC (rev 106364) @@ -93,8 +93,6 @@ #include TreeScopeAdopter.h #include UIEvent.h #include UIEventWithKeyState.h -#include WebKitAnimationEvent.h -#include WebKitTransitionEvent.h #include WheelEvent.h #include WindowEventContext.h #include XMLNames.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106365] branches/chromium/1025/
Title: [106365] branches/chromium/1025/ Revision 106365 Author kar...@chromium.org Date 2012-01-31 09:39:08 -0800 (Tue, 31 Jan 2012) Log Message branching for chrome m18 Added Paths branches/chromium/1025/ Diff Property changes: branches/chromium/1025 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106366] trunk/Tools
Title: [106366] trunk/Tools
Revision 106366
Author m...@apple.com
Date 2012-01-31 09:39:34 -0800 (Tue, 31 Jan 2012)
Log Message
When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
Reviewed by Anders Carlsson.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
Diff
Modified: trunk/Tools/ChangeLog (106365 => 106366)
--- trunk/Tools/ChangeLog 2012-01-31 17:39:08 UTC (rev 106365)
+++ trunk/Tools/ChangeLog 2012-01-31 17:39:34 UTC (rev 106366)
@@ -1,3 +1,11 @@
+2012-01-31 Dan Bernstein m...@apple.com
+
+When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
+
+Reviewed by Anders Carlsson.
+
+* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+
2012-01-31 Csaba Osztrogonác o...@webkit.org
If the QTDIR environment variable is set, the build system fails to compile WinCairo
Modified: trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj (106365 => 106366)
--- trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2012-01-31 17:39:08 UTC (rev 106365)
+++ trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2012-01-31 17:39:34 UTC (rev 106366)
@@ -545,7 +545,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = mkdir -p \${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitTestRunner\\ncd \${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitTestRunner\\n\nexport WebKitTestRunner=\${SRCROOT}\\nexport WebCoreScripts=\${WEBCORE_PRIVATE_HEADERS_DIR}\\n\nif [ \${ACTION}\ = \build\ -o \${ACTION}\ = \install\ -o \${ACTION}\ = \installhdrs\ ]; then\nmake -f \${WebKitTestRunner}/DerivedSources.make\ -j `/usr/sbin/sysctl -n hw.availcpu`\nfi\n;
+ shellScript = mkdir -p \${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitTestRunner\\ncd \${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitTestRunner\\n\nexport WebKitTestRunner=\${SRCROOT}\\nexport WebCoreScripts=\${WEBCORE_PRIVATE_HEADERS_DIR}\\n\nif [ ! $CC ]; then\ncase $TARGET_GCC_VERSION in\n(GCC_42)\nexport CC=\${DT_TOOLCHAIN_DIR}/usr/bin/gcc-4.2\;;\n(LLVM_GCC_42)\nexport CC=\${DT_TOOLCHAIN_DIR}/usr/bin/llvm-gcc-4.2\;;\n(LLVM_COMPILER)\nexport CC=\${DT_TOOLCHAIN_DIR}/usr/bin/clang\;;\nesac\nfi\n\nif [ \${ACTION}\ = \build\ -o \${ACTION}\ = \install\ -o \${ACTION}\ = \installhdrs\ ]; then\nmake -f \${WebKitTestRunner}/DerivedSources.make\ -j `/usr/sbin/sysctl -n hw.availcpu`\nfi\n;
};
/* End PBXShellScriptBuildPhase section */
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106367] branches/chromium/1025/codereview.settings
Title: [106367] branches/chromium/1025/codereview.settings Revision 106367 Author kar...@chromium.org Date 2012-01-31 09:40:50 -0800 (Tue, 31 Jan 2012) Log Message adding codereview.settings Added Paths branches/chromium/1025/codereview.settings Diff Added: branches/chromium/1025/codereview.settings (0 => 106367) --- branches/chromium/1025/codereview.settings (rev 0) +++ branches/chromium/1025/codereview.settings 2012-01-31 17:40:50 UTC (rev 106367) @@ -0,0 +1,10 @@ +# This file is used by gcl to get repository specific information. +CODE_REVIEW_SERVER: codereview.chromium.org +CC_LIST: chromium-revi...@chromium.org +VIEW_VC: http://src.chromium.org/viewvc/chrome?view=revrevision= +STATUS: http://chromium-status.appspot.com/status +TRY_ON_UPLOAD: True +TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try +GITCL_PREUPLOAD: http://src.chromium.org/viewvc/trunk/tools/depot_tools/git-cl-upload-hook?revision=HEADroot=chrome +GITCL_PREDCOMMIT: http://src.chromium.org/viewvc/trunk/tools/depot_tools/git-cl-upload-hook?revision=HEADroot=chrome +LINT_IGNORE_REGEX: webkit/api/.* ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106368] trunk/Source/JavaScriptCore
Title: [106368] trunk/Source/_javascript_Core
Revision 106368
Author ander...@apple.com
Date 2012-01-31 10:06:23 -0800 (Tue, 31 Jan 2012)
Log Message
VectorT::operator== shouldn't require T to have operator!=
https://bugs.webkit.org/show_bug.cgi?id=77448
Reviewed by Andreas Kling.
Change VectorComparer::compare to use !(a == b) instead of a != b since
it makes more sense for Vector::operator== to use the element's operator==.
* wtf/Vector.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Vector.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (106367 => 106368)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-31 17:40:50 UTC (rev 106367)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-31 18:06:23 UTC (rev 106368)
@@ -1,3 +1,15 @@
+2012-01-31 Anders Carlsson ander...@apple.com
+
+VectorT::operator== shouldn't require T to have operator!=
+https://bugs.webkit.org/show_bug.cgi?id=77448
+
+Reviewed by Andreas Kling.
+
+Change VectorComparer::compare to use !(a == b) instead of a != b since
+it makes more sense for Vector::operator== to use the element's operator==.
+
+* wtf/Vector.h:
+
2012-01-30 Oliver Hunt oli...@apple.com
get_by_val_arguments is broken in the interpreter
Modified: trunk/Source/_javascript_Core/wtf/Vector.h (106367 => 106368)
--- trunk/Source/_javascript_Core/wtf/Vector.h 2012-01-31 17:40:50 UTC (rev 106367)
+++ trunk/Source/_javascript_Core/wtf/Vector.h 2012-01-31 18:06:23 UTC (rev 106368)
@@ -194,7 +194,7 @@
static bool compare(const T* a, const T* b, size_t size)
{
for (size_t i = 0; i size; ++i)
-if (a[i] != b[i])
+if (!(a[i] == b[i]))
return false;
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106369] trunk/Tools
Title: [106369] trunk/Tools
Revision 106369
Author rga...@webkit.org
Date 2012-01-31 11:00:21 -0800 (Tue, 31 Jan 2012)
Log Message
[GTK] build-webkit warning.
https://bugs.webkit.org/show_bug.cgi?id=77411
Reviewed by Philippe Normand.
* Scripts/webkitdirs.pm:
(isCrossCompilation):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (106368 => 106369)
--- trunk/Tools/ChangeLog 2012-01-31 18:06:23 UTC (rev 106368)
+++ trunk/Tools/ChangeLog 2012-01-31 19:00:21 UTC (rev 106369)
@@ -1,3 +1,13 @@
+2012-01-31 Gabor Rapcsanyi rga...@webkit.org
+
+[GTK] build-webkit warning.
+https://bugs.webkit.org/show_bug.cgi?id=77411
+
+Reviewed by Philippe Normand.
+
+* Scripts/webkitdirs.pm:
+(isCrossCompilation):
+
2012-01-31 Dan Bernstein m...@apple.com
When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
Modified: trunk/Tools/Scripts/webkitdirs.pm (106368 => 106369)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-01-31 18:06:23 UTC (rev 106368)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-01-31 19:00:21 UTC (rev 106369)
@@ -1266,7 +1266,7 @@
sub isCrossCompilation()
{
- my $compiler = $ENV{'CC'};
+ my $compiler = unless $ENV{'CC'};
if ($compiler =~ /gcc/) {
my $compiler_options = `$compiler -v 21`;
my @host = $compiler_options =~ m/--host=(.*?)\s/;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106370] trunk/Source/JavaScriptCore
Title: [106370] trunk/Source/_javascript_Core
Revision 106370
Author msab...@apple.com
Date 2012-01-31 11:07:44 -0800 (Tue, 31 Jan 2012)
Log Message
ASSERT(m_jumpsToLink.isEmpty()) failing in ARMv7Assembler dtor
https://bugs.webkit.org/show_bug.cgi?id=77443
Reviewed by Gavin Barraclough.
Removed failing ASSERT() and thus destructor. The ASSERT isn't needed.
We are hitting it in the YARR JIT case where we bail out and go to the
interpreter with a partially JIT'ed function. Since we haven't linked
the JIT'ed code, there is likely to be some unresolved jumps in the vector
when the ARMv7Assembler destructor is called. For the case where we
complete the JIT process, we clear the vector at the end of
LinkBuffer::linkCode (LinkBuffer.h:292).
* assembler/ARMv7Assembler.h:
(ARMv7Assembler):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (106369 => 106370)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-31 19:00:21 UTC (rev 106369)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-31 19:07:44 UTC (rev 106370)
@@ -1,3 +1,21 @@
+2012-01-31 Michael Saboff msab...@apple.com
+
+ASSERT(m_jumpsToLink.isEmpty()) failing in ARMv7Assembler dtor
+https://bugs.webkit.org/show_bug.cgi?id=77443
+
+Reviewed by Gavin Barraclough.
+
+Removed failing ASSERT() and thus destructor. The ASSERT isn't needed.
+We are hitting it in the YARR JIT case where we bail out and go to the
+interpreter with a partially JIT'ed function. Since we haven't linked
+the JIT'ed code, there is likely to be some unresolved jumps in the vector
+when the ARMv7Assembler destructor is called. For the case where we
+complete the JIT process, we clear the vector at the end of
+LinkBuffer::linkCode (LinkBuffer.h:292).
+
+* assembler/ARMv7Assembler.h:
+(ARMv7Assembler):
+
2012-01-31 Anders Carlsson ander...@apple.com
VectorT::operator== shouldn't require T to have operator!=
Modified: trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h (106369 => 106370)
--- trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2012-01-31 19:00:21 UTC (rev 106369)
+++ trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2012-01-31 19:07:44 UTC (rev 106370)
@@ -414,11 +414,6 @@
class ARMv7Assembler {
public:
-~ARMv7Assembler()
-{
-ASSERT(m_jumpsToLink.isEmpty());
-}
-
typedef ARMRegisters::RegisterID RegisterID;
typedef ARMRegisters::FPSingleRegisterID FPSingleRegisterID;
typedef ARMRegisters::FPDoubleRegisterID FPDoubleRegisterID;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106371] trunk
Title: [106371] trunk
Revision 106371
Author pi...@chromium.org
Date 2012-01-31 11:11:54 -0800 (Tue, 31 Jan 2012)
Log Message
Merge WebGraphicsContext3D creation and initialization, and move it to
WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=76593
Reviewed by Darin Fisher.
Source/WebKit/chromium:
* public/WebViewClient.h:
(WebKit::WebViewClient::createGraphicsContext3D):
* public/platform/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::initialize):
* public/platform/WebKitPlatformSupport.h:
* src/GraphicsContext3DChromium.cpp:
Tools:
* DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::initialize):
* DumpRenderTree/chromium/TestWebPlugin.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createGraphicsContext3D):
(WebViewHost::createPlugin):
* DumpRenderTree/chromium/WebViewHost.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebViewClient.h
trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.cpp
trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106370 => 106371)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 19:07:44 UTC (rev 106370)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 19:11:54 UTC (rev 106371)
@@ -1,3 +1,18 @@
+2012-01-31 Antoine Labour pi...@chromium.org
+
+Merge WebGraphicsContext3D creation and initialization, and move it to
+WebViewClient.
+https://bugs.webkit.org/show_bug.cgi?id=76593
+
+Reviewed by Darin Fisher.
+
+* public/WebViewClient.h:
+(WebKit::WebViewClient::createGraphicsContext3D):
+* public/platform/WebGraphicsContext3D.h:
+(WebKit::WebGraphicsContext3D::initialize):
+* public/platform/WebKitPlatformSupport.h:
+* src/GraphicsContext3DChromium.cpp:
+
2012-01-26 Hans Wennborg h...@chromium.org
Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
Modified: trunk/Source/WebKit/chromium/public/WebViewClient.h (106370 => 106371)
--- trunk/Source/WebKit/chromium/public/WebViewClient.h 2012-01-31 19:07:44 UTC (rev 106370)
+++ trunk/Source/WebKit/chromium/public/WebViewClient.h 2012-01-31 19:11:54 UTC (rev 106371)
@@ -42,6 +42,7 @@
#include WebTextDirection.h
#include WebWidgetClient.h
#include platform/WebColor.h
+#include platform/WebGraphicsContext3D.h
#include platform/WebString.h
namespace WebKit {
@@ -109,6 +110,12 @@
// Create a session storage namespace object associated with this WebView.
virtual WebStorageNamespace* createSessionStorageNamespace(unsigned quota) { return 0; }
+// Creates a graphics context associated with the client's WebView.
+// renderDirectlyToWebView means whether the context should be setup to
+// render directly to the WebView (e.g. compositor context), or to an
+// offscreen surface (e.g. WebGL context).
+virtual WebGraphicsContext3D* createGraphicsContext3D(const WebGraphicsContext3D::Attributes, bool renderDirectlyToWebView) { return 0; }
+
// Misc
// A new message was added to the console.
Modified: trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h (106370 => 106371)
--- trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h 2012-01-31 19:07:44 UTC (rev 106370)
+++ trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h 2012-01-31 19:11:54 UTC (rev 106371)
@@ -133,9 +133,8 @@
// This destructor needs to be public so that using classes can destroy instances if initialization fails.
virtual ~WebGraphicsContext3D() {}
-// Initializes the graphics context; should be the first operation performed
-// on newly-constructed instances. Returns true on success.
-virtual bool initialize(Attributes, WebView*, bool renderDirectlyToWebView) = 0;
+// This function is deprecated and will be removed soon.
+virtual bool initialize(Attributes, WebView*, bool renderDirectlyToWebView) { return false; }
// Makes the OpenGL context current on the current thread. Returns true on
// success.
Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (106370 => 106371)
--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2012-01-31 19:07:44 UTC (rev 106370)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2012-01-31 19:11:54 UTC (rev 106371)
@@ -36,6 +36,7 @@
#include WebCommon.h
#include WebData.h
#include WebGamepads.h
+#include WebGraphicsContext3D.h
[webkit-changes] [106374] branches/subpixellayout/Source/WebCore/platform/qt
Title: [106374] branches/subpixellayout/Source/WebCore/platform/qt
Revision 106374
Author e...@chromium.org
Date 2012-01-31 11:50:58 -0800 (Tue, 31 Jan 2012)
Log Message
Fix scrollbar painting on qt (again).
Modified Paths
branches/subpixellayout/Source/WebCore/platform/qt/ScrollbarThemeQt.cpp
branches/subpixellayout/Source/WebCore/platform/qt/ScrollbarThemeQt.h
Diff
Modified: branches/subpixellayout/Source/WebCore/platform/qt/ScrollbarThemeQt.cpp (106373 => 106374)
--- branches/subpixellayout/Source/WebCore/platform/qt/ScrollbarThemeQt.cpp 2012-01-31 19:33:22 UTC (rev 106373)
+++ branches/subpixellayout/Source/WebCore/platform/qt/ScrollbarThemeQt.cpp 2012-01-31 19:50:58 UTC (rev 106374)
@@ -155,11 +155,10 @@
return opt;
}
-bool ScrollbarThemeQt::paint(Scrollbar* scrollbar, GraphicsContext* graphicsContext, const FixedRect damageRect)
+bool ScrollbarThemeQt::paint(Scrollbar* scrollbar, GraphicsContext* graphicsContext, const IntRect damageRect)
{
-IntRect enclosingRect = enclosingIntRect(damageRect);
if (graphicsContext-updatingControlTints()) {
- scrollbar-invalidateRect(enclosingRect);
+ scrollbar-invalidateRect(damageRect);
return false;
}
@@ -170,7 +169,7 @@
p.painter-save();
QStyleOptionSlider* opt = styleOptionSlider(scrollbar, p.widget);
-p.painter-setClipRect(opt-rect.intersected(enclosingRect), Qt::IntersectClip);
+p.painter-setClipRect(opt-rect.intersected(damageRect), Qt::IntersectClip);
#ifdef Q_WS_MAC
// FIXME: We also need to check the widget style but today ScrollbarTheme is not aware of the page so we
Modified: branches/subpixellayout/Source/WebCore/platform/qt/ScrollbarThemeQt.h (106373 => 106374)
--- branches/subpixellayout/Source/WebCore/platform/qt/ScrollbarThemeQt.h 2012-01-31 19:33:22 UTC (rev 106373)
+++ branches/subpixellayout/Source/WebCore/platform/qt/ScrollbarThemeQt.h 2012-01-31 19:50:58 UTC (rev 106374)
@@ -40,7 +40,7 @@
public:
virtual ~ScrollbarThemeQt();
-virtual bool paint(Scrollbar*, GraphicsContext*, const FixedRect damageRect);
+virtual bool paint(Scrollbar*, GraphicsContext*, const IntRect damageRect);
virtual void paintScrollCorner(ScrollView*, GraphicsContext*, const IntRect cornerRect);
virtual ScrollbarPart hitTest(Scrollbar*, const PlatformMouseEvent);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106375] trunk/Source/WebKit2
Title: [106375] trunk/Source/WebKit2
Revision 106375
Author a...@apple.com
Date 2012-01-31 11:58:07 -0800 (Tue, 31 Jan 2012)
Log Message
PluginProcess should be able to use remote open and save panels
https://bugs.webkit.org/show_bug.cgi?id=77461
rdar://problem/10783615
Reviewed by Mark Rowe.
* PluginProcess/mac/PluginProcess.entitlements: Added.
* PluginProcess/mac/add-entitlements.sh: Added.
* WebKit2.xcodeproj/project.pbxproj:
Add appropriate entitlement, plus ad hoc binary signing for it to work.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements
trunk/Source/WebKit2/PluginProcess/mac/add-entitlements.sh
Diff
Modified: trunk/Source/WebKit2/ChangeLog (106374 => 106375)
--- trunk/Source/WebKit2/ChangeLog 2012-01-31 19:50:58 UTC (rev 106374)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-31 19:58:07 UTC (rev 106375)
@@ -1,3 +1,16 @@
+2012-01-31 Alexey Proskuryakov a...@apple.com
+
+PluginProcess should be able to use remote open and save panels
+https://bugs.webkit.org/show_bug.cgi?id=77461
+rdar://problem/10783615
+
+Reviewed by Mark Rowe.
+
+* PluginProcess/mac/PluginProcess.entitlements: Added.
+* PluginProcess/mac/add-entitlements.sh: Added.
+* WebKit2.xcodeproj/project.pbxproj:
+Add appropriate entitlement, plus ad hoc binary signing for it to work.
+
2012-01-31 Allan Sandfeld Jensen allan.jen...@nokia.com
Ensure tiles are repainted when scrolling using mouse wheel.
Added: trunk/Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements (0 => 106375)
--- trunk/Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements (rev 0)
+++ trunk/Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements 2012-01-31 19:58:07 UTC (rev 106375)
@@ -0,0 +1,8 @@
+?xml version=1.0 encoding=UTF-8?
+!DOCTYPE plist PUBLIC -//Apple//DTD PLIST 1.0//EN http://www.apple.com/DTDs/PropertyList-1.0.dtd
+plist version=1.0
+dict
+ keycom.apple.security.files.user-selected.read-write/key
+ true/
+/dict
+/plist
Added: trunk/Source/WebKit2/PluginProcess/mac/add-entitlements.sh (0 => 106375)
--- trunk/Source/WebKit2/PluginProcess/mac/add-entitlements.sh (rev 0)
+++ trunk/Source/WebKit2/PluginProcess/mac/add-entitlements.sh 2012-01-31 19:58:07 UTC (rev 106375)
@@ -0,0 +1,35 @@
+#!/bin/sh
+
+# This script is needed because adding entitlements through Xcode configuration doesn't get dependencies right in some cases, rdar://problem/10783446.
+
+app_path=${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}
+app_binary_path=${BUILT_PRODUCTS_DIR}/${EXECUTABLE_PATH}
+entitlement_file=PluginProcess/mac/PluginProcess.entitlements
+
+if [[ ${CONFIGURATION} == Production ]]; then
+exit
+fi
+
+osx_version=$(sw_vers -productVersion | cut -d. -f 2)
+if (( ${osx_version} = 6 )); then
+exit
+fi
+
+needs_signing=0
+
+# If the signature is invalid (e.g. due to updated resources), we need to re-sign it.
+codesign --verify ${app_path} 2 /dev/null
+if [[ $? != 0 ]]; then
+needs_signing=1
+else
+# If the entitlements file is newer than the binary, we need to re-sign the app.
+if [[ ${entitlement_file} -nt ${app_binary_path} ]]; then
+needs_signing=1
+fi
+fi
+
+if [[ $needs_signing == 0 ]]; then
+exit
+fi
+
+codesign -f -s - --entitlements ${entitlement_file} ${app_path}
Property changes on: trunk/Source/WebKit2/PluginProcess/mac/add-entitlements.sh
___
Added: svn:executable
Added: svn:eol-style
Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (106374 => 106375)
--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2012-01-31 19:50:58 UTC (rev 106374)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2012-01-31 19:58:07 UTC (rev 106375)
@@ -1924,6 +1924,8 @@
E133FD891423DD7F00FC7BFB /* WebKit.icns */ = {isa = PBXFileReference; lastKnownFileType = image.icns; name = WebKit.icns; path = WebProcess/mac/WebKit.icns; sourceTree = group; };
E134F01512EA5D11004EC58D /* WKPrintingView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKPrintingView.h; sourceTree = group; };
E134F01912EA5D99004EC58D /* WKPrintingView.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKPrintingView.mm; sourceTree = group; };
+ E14E99F814D879B4001D221F /* PluginProcess.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = PluginProcess.entitlements; sourceTree = group; };
+ E14E99F914D879C9001D221F /* add-entitlements.sh */ = {isa = PBXFileReference; lastKnownFileType = text.script.sh; path = add-entitlements.sh; sourceTree = group; };
E179FD9B134D38060015B883 /* ArgumentCodersMac.h */ = {isa
[webkit-changes] [106376] trunk
Title: [106376] trunk
Revision 106376
Author commit-qu...@webkit.org
Date 2012-01-31 12:00:09 -0800 (Tue, 31 Jan 2012)
Log Message
WebGL must allocate smaller drawing buffer when the allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=76654
Patch by Yongsheng Zhu yongsheng@intel.com on 2012-01-31
Reviewed by Kenneth Russell.
Test: fast/canvas/webgl/drawingbuffer-test.html
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):
Modified Paths
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp
Diff
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106375 => 106376)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-31 19:58:07 UTC (rev 106375)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-31 20:00:09 UTC (rev 106376)
@@ -3831,8 +3831,6 @@
BUGWK76580 : media/media-document-audio-repaint.html = IMAGE PASS
-BUGWK76562 : fast/canvas/webgl/drawingbuffer-test.html = TEXT
-
// This test is passing, but it doesn't seem possible to add GPU+Leopard specific baselines.
BUGJAMESR LEOPARD GPU : fast/canvas/quadraticCurveTo.xml = IMAGE
Modified: trunk/Source/WebCore/ChangeLog (106375 => 106376)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 19:58:07 UTC (rev 106375)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 20:00:09 UTC (rev 106376)
@@ -1,3 +1,17 @@
+2012-01-31 Yongsheng Zhu yongsheng@intel.com
+
+WebGL must allocate smaller drawing buffer when the allocation fails.
+https://bugs.webkit.org/show_bug.cgi?id=76654
+
+Reviewed by Kenneth Russell.
+
+Test: fast/canvas/webgl/drawingbuffer-test.html
+
+* platform/graphics/gpu/DrawingBuffer.cpp:
+(WebCore):
+(WebCore::DrawingBuffer::create):
+(WebCore::DrawingBuffer::reset):
+
2012-01-25 Eric Seidel e...@webkit.org
HTMLIsIndexElement should not expose HTMLInputElement properties
Modified: trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp (106375 => 106376)
--- trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp 2012-01-31 19:58:07 UTC (rev 106375)
+++ trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp 2012-01-31 20:00:09 UTC (rev 106376)
@@ -49,6 +49,7 @@
static int s_maximumResourceUsePixels = 0;
#endif
static int s_currentResourceUsePixels = 0;
+static const float s_resourceAdjustedRatio = 0.5;
PassRefPtrDrawingBuffer DrawingBuffer::create(GraphicsContext3D* context, const IntSize size, bool separateBackingTexture)
{
@@ -236,19 +237,28 @@
}
int pixelDelta = newSize.width() * newSize.height();
-if (!m_size.isEmpty())
-pixelDelta -= m_size.width() * m_size.height();
+int oldSize = 0;
+if (!m_size.isEmpty()) {
+oldSize = m_size.width() * m_size.height();
+pixelDelta -= oldSize;
+}
-if (s_maximumResourceUsePixels (s_currentResourceUsePixels + pixelDelta) s_maximumResourceUsePixels) {
-clear();
-return false;
+IntSize adjustedSize = newSize;
+if (s_maximumResourceUsePixels) {
+while ((s_currentResourceUsePixels + pixelDelta) s_maximumResourceUsePixels) {
+adjustedSize.scale(s_resourceAdjustedRatio);
+if (adjustedSize.isEmpty()) {
+clear();
+return false;
+}
+pixelDelta = adjustedSize.width() * adjustedSize.height();
+pixelDelta -= oldSize;
+}
}
-s_currentResourceUsePixels += pixelDelta;
const GraphicsContext3D::Attributes attributes = m_context-getContextAttributes();
-if (newSize != m_size) {
-m_size = newSize;
+if (adjustedSize != m_size) {
unsigned internalColorFormat, colorFormat, internalRenderbufferFormat;
if (attributes.alpha) {
@@ -261,47 +271,57 @@
internalRenderbufferFormat = Extensions3D::RGB8_OES;
}
+do {
+m_size = adjustedSize;
-// resize multisample FBO
-if (multisample()) {
-int maxSampleCount = 0;
-
-m_context-getIntegerv(Extensions3D::MAX_SAMPLES, maxSampleCount);
-int sampleCount = std::min(4, maxSampleCount);
+// resize multisample FBO
+if (multisample()) {
+int maxSampleCount = 0;
-m_context-bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, m_multisampleFBO);
+m_context-getIntegerv(Extensions3D::MAX_SAMPLES, maxSampleCount);
+int sampleCount = std::min(4, maxSampleCount);
-m_context-bindRenderbuffer(GraphicsContext3D::RENDERBUFFER, m_multisampleColorBuffer);
-m_context-getExtensions()-renderbufferStorageMultisample(GraphicsContext3D::RENDERBUFFER, sampleCount, internalRenderbufferFormat, m_size.width(),
[webkit-changes] [106377] trunk/Source/WebCore
Title: [106377] trunk/Source/WebCore Revision 106377 Author e...@webkit.org Date 2012-01-31 12:00:37 -0800 (Tue, 31 Jan 2012) Log Message HTMLIsIndexElement should not expose HTMLInputElement properties https://bugs.webkit.org/show_bug.cgi?id=76095 Patch by Rafael Brandao rafael.l...@openbossa.org on 2012-01-31 Reviewed by Eric Seidel. This is a buildfix for r106373. * DerivedSources.pri: Removed reference to HTMLIsIndexElement.idl Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.pri Diff Modified: trunk/Source/WebCore/ChangeLog (106376 => 106377) --- trunk/Source/WebCore/ChangeLog 2012-01-31 20:00:09 UTC (rev 106376) +++ trunk/Source/WebCore/ChangeLog 2012-01-31 20:00:37 UTC (rev 106377) @@ -1,3 +1,14 @@ +2012-01-31 Rafael Brandao rafael.l...@openbossa.org + +HTMLIsIndexElement should not expose HTMLInputElement properties +https://bugs.webkit.org/show_bug.cgi?id=76095 + +Reviewed by Eric Seidel. + +This is a buildfix for r106373. + +* DerivedSources.pri: Removed reference to HTMLIsIndexElement.idl + 2012-01-31 Yongsheng Zhu yongsheng@intel.com WebGL must allocate smaller drawing buffer when the allocation fails. Modified: trunk/Source/WebCore/DerivedSources.pri (106376 => 106377) --- trunk/Source/WebCore/DerivedSources.pri 2012-01-31 20:00:09 UTC (rev 106376) +++ trunk/Source/WebCore/DerivedSources.pri 2012-01-31 20:00:37 UTC (rev 106377) @@ -278,7 +278,6 @@ $$PWD/html/HTMLIFrameElement.idl \ $$PWD/html/HTMLImageElement.idl \ $$PWD/html/HTMLInputElement.idl \ -$$PWD/html/HTMLIsIndexElement.idl \ $$PWD/html/HTMLKeygenElement.idl \ $$PWD/html/HTMLLabelElement.idl \ $$PWD/html/HTMLLegendElement.idl \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106378] trunk/LayoutTests
Title: [106378] trunk/LayoutTests Revision 106378 Author t...@chromium.org Date 2012-01-31 12:05:29 -0800 (Tue, 31 Jan 2012) Log Message [chromium] Fix css3/flexbox/cross-axis-scrollbar-expected to work on chromium win. The scrollbars overflow the bounds of the scrollbar rect (see bug 77368). Work around this by using positioned elements and setting the z-index as negative. It didn't work previously because when the scrollbar was positioned, it clipped the extra pixels. Tested to verify that this works on Chromium Win and Chromium Linux. Unreviewed, test fix. * css3/flexbox/cross-axis-scrollbar-expected.html: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (106377 => 106378) --- trunk/LayoutTests/ChangeLog 2012-01-31 20:00:37 UTC (rev 106377) +++ trunk/LayoutTests/ChangeLog 2012-01-31 20:05:29 UTC (rev 106378) @@ -1,3 +1,19 @@ +2012-01-31 Tony Chang t...@chromium.org + +[chromium] Fix css3/flexbox/cross-axis-scrollbar-expected to work on +chromium win. + +The scrollbars overflow the bounds of the scrollbar rect (see bug 77368). +Work around this by using positioned elements and setting the z-index as +negative. It didn't work previously because when the scrollbar was +positioned, it clipped the extra pixels. Tested to verify that this works +on Chromium Win and Chromium Linux. + +Unreviewed, test fix. + +* css3/flexbox/cross-axis-scrollbar-expected.html: +* platform/chromium/test_expectations.txt: + 2012-01-25 Eric Seidel e...@webkit.org HTMLIsIndexElement should not expose HTMLInputElement properties Modified: trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html (106377 => 106378) --- trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html 2012-01-31 20:00:37 UTC (rev 106377) +++ trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html 2012-01-31 20:05:29 UTC (rev 106378) @@ -22,47 +22,47 @@ div class=testcase style=top:0; left: 0 div style=width: 100px; height: 50px/div -div style=width: 100px; overflow-x: scroll; position: relative; z-index: 1/div +div style=width: 100px; overflow-x: scroll/div div style=width: 100px; height: 10px; position: relative; z-index: -1/div /div div class=testcase style=height: 50px; -webkit-writing-mode: vertical-lr; top: 0; left: 150px div style=width: 100px/div -div style=overflow-y: scroll; position: relative; z-index: 1/div +div style=overflow-y: scroll/div div style=width: 10px; position: relative; z-index: -1/div /div div class=testcase style=height: 50px; -webkit-writing-mode: vertical-lr; top: 0; left: 300px div style=width: 100px/div -div style=overflow-y: scroll; position: relative; z-index: 1/div +div style=overflow-y: scroll/div div style=width: 10px; position: relative; z-index: -1/div /div div class=testcase style=top: 0; left: 450px div style=width: 100px; height: 50px/div -div style=width: 100px; overflow-x: scroll; position: relative; z-index: 1/div +div style=width: 100px; overflow-x: scroll/div div style=width: 100px; height: 10px; position: relative; z-index: -1/div /div div class=testcase style=top: 100px; left: 0 div style=width: 100px; height: 50px; /div -div style=width: 100px; overflow-x: scroll; position: relative; z-index: 1/div +div style=width: 100px; overflow-x: scroll/div div style=width: 100px; height: 10px; position: relative; z-index: -1/div /div div class=testcase style=height: 50px; -webkit-writing-mode: vertical-lr; top: 100px; left: 150px -div style=width: 90px; overflow-y: scroll; position: relative; z-index: 1/div +div style=width: 90px; overflow-y: scroll/div div style=width: 10px; position: relative; z-index: -1/div /div div class=testcase style=top: 100px; left: 300px -div style=width: 100px; height: 40px; overflow-x: scroll; position: relative; z-index: 1/div +div style=width: 100px; height: 40px; overflow-x: scroll/div div style=width: 100px; height: 10px; position: relative; z-index: -1/div /div div class=testcase style=height: 50px; -webkit-writing-mode: vertical-lr; top: 100px; left: 450px div style=width: 100px/div -div style=overflow-y: scroll; position: relative; z-index: 1/div +div style=overflow-y: scroll/div div style=width: 10px; position: relative; z-index: -1/div /div Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106377 => 106378) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-31 20:00:37 UTC (rev 106377) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-31 20:05:29 UTC (rev 106378) @@ -4028,7 +4028,6 @@ BUGWK77303 :
[webkit-changes] [106379] trunk/PerformanceTests
Title: [106379] trunk/PerformanceTests
Revision 106379
Author rn...@webkit.org
Date 2012-01-31 12:05:37 -0800 (Tue, 31 Jan 2012)
Log Message
runner.js in performance tests should define a class
https://bugs.webkit.org/show_bug.cgi?id=77074
Reviewed by Eric Seidel.
Wrap all functions in runner.js by PerfTestRunner and update tests that runner.js accordingly.
Also replace compute* functions in runner.js by more robust code from dom-perf.js.
* Bindings/event-target-wrapper.html:
* DOM/DOMTable.html:
* DOM/resources/dom-perf.js:
(BenchmarkSuite.prototype.RunSingle):
(runBenchmarkSuite):
* Mutation/append-child-deep.html:
* Mutation/append-child.html:
* Mutation/inner-html.html:
* Mutation/remove-child-deep.html:
* Mutation/remove-child.html:
* Parser/html-parser.html:
* Parser/html5-full-render.html:
* Parser/simple-url.html:
* Parser/tiny-innerHTML.html:
* Parser/url-parser.html:
* Parser/xml-parser.html:
* resources/runner.js:
(PerfTestRunner.log):
(PerfTestRunner.logInfo):
(PerfTestRunner.loadFile):
(PerfTestRunner.computeStatistics):
(PerfTestRunner.logStatistics):
(PerfTestRunner._runLoop.else):
(PerfTestRunner._runLoop):
(PerfTestRunner._runner):
Modified Paths
trunk/PerformanceTests/Bindings/event-target-wrapper.html
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/DOM/DOMTable.html
trunk/PerformanceTests/DOM/resources/dom-perf.js
trunk/PerformanceTests/Dromaeo/resources/dromaeorunner.js
trunk/PerformanceTests/Mutation/append-child-deep.html
trunk/PerformanceTests/Mutation/append-child.html
trunk/PerformanceTests/Mutation/inner-html.html
trunk/PerformanceTests/Mutation/remove-child-deep.html
trunk/PerformanceTests/Mutation/remove-child.html
trunk/PerformanceTests/Parser/html-parser.html
trunk/PerformanceTests/Parser/html5-full-render.html
trunk/PerformanceTests/Parser/simple-url.html
trunk/PerformanceTests/Parser/tiny-innerHTML.html
trunk/PerformanceTests/Parser/url-parser.html
trunk/PerformanceTests/Parser/xml-parser.html
trunk/PerformanceTests/resources/runner.js
Diff
Modified: trunk/PerformanceTests/Bindings/event-target-wrapper.html (106378 => 106379)
--- trunk/PerformanceTests/Bindings/event-target-wrapper.html 2012-01-31 20:05:29 UTC (rev 106378)
+++ trunk/PerformanceTests/Bindings/event-target-wrapper.html 2012-01-31 20:05:37 UTC (rev 106379)
@@ -13,12 +13,12 @@
window.evt = event;
event.preventDefault();
-start(20, function() {
+PerfTestRunner.run(function () {
var e = window.evt;
for (var x = 0; x kIteratonsPerTest; x++) {
e.target;
}
-}, 10);
+});
return false;
}, false);
Modified: trunk/PerformanceTests/ChangeLog (106378 => 106379)
--- trunk/PerformanceTests/ChangeLog 2012-01-31 20:05:29 UTC (rev 106378)
+++ trunk/PerformanceTests/ChangeLog 2012-01-31 20:05:37 UTC (rev 106379)
@@ -1,3 +1,39 @@
+2012-01-31 Ryosuke Niwa rn...@webkit.org
+
+runner.js in performance tests should define a class
+https://bugs.webkit.org/show_bug.cgi?id=77074
+
+Reviewed by Eric Seidel.
+
+Wrap all functions in runner.js by PerfTestRunner and update tests that runner.js accordingly.
+Also replace compute* functions in runner.js by more robust code from dom-perf.js.
+
+* Bindings/event-target-wrapper.html:
+* DOM/DOMTable.html:
+* DOM/resources/dom-perf.js:
+(BenchmarkSuite.prototype.RunSingle):
+(runBenchmarkSuite):
+* Mutation/append-child-deep.html:
+* Mutation/append-child.html:
+* Mutation/inner-html.html:
+* Mutation/remove-child-deep.html:
+* Mutation/remove-child.html:
+* Parser/html-parser.html:
+* Parser/html5-full-render.html:
+* Parser/simple-url.html:
+* Parser/tiny-innerHTML.html:
+* Parser/url-parser.html:
+* Parser/xml-parser.html:
+* resources/runner.js:
+(PerfTestRunner.log):
+(PerfTestRunner.logInfo):
+(PerfTestRunner.loadFile):
+(PerfTestRunner.computeStatistics):
+(PerfTestRunner.logStatistics):
+(PerfTestRunner._runLoop.else):
+(PerfTestRunner._runLoop):
+(PerfTestRunner._runner):
+
2012-01-31 Hajime Morrita morr...@chromium.org
[PerformanceTests] Add landing html for Dromaeo dom-query test
Modified: trunk/PerformanceTests/DOM/DOMTable.html (106378 => 106379)
--- trunk/PerformanceTests/DOM/DOMTable.html 2012-01-31 20:05:29 UTC (rev 106378)
+++ trunk/PerformanceTests/DOM/DOMTable.html 2012-01-31 20:05:37 UTC (rev 106379)
@@ -6,6 +6,9 @@
script type=text/_javascript_ src=""
script type=text/_javascript_ src=""
script type=text/_javascript_ src=""
-script runBenchmarkSuite(DOMTableTest); /script
+script
+runBenchmarkSuite(DOMTableTest, 10);
+// runCount = 10 since this test is very slow (~12m per run on Core i5 2.53Hz MacBookPro)
+/script
/body
/html
Modified: trunk/PerformanceTests/DOM/resources/dom-perf.js (106378 => 106379)
[webkit-changes] [106380] trunk
Title: [106380] trunk
Revision 106380
Author rn...@webkit.org
Date 2012-01-31 12:41:05 -0800 (Tue, 31 Jan 2012)
Log Message
Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempting to delete the start block
https://bugs.webkit.org/show_bug.cgi?id=77077
Reviewed by Enrica Casucci.
The crash was caused by a missing null check after removing the position out of the start block.
Fixed the bug by adding an early return.
Tests: editing/deleting/delete-start-block.html
editing/selection/move-into-empty-root-inline-box.html
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
LayoutTests: Crash in previousLinePosition when moving into a root inline box without leaves
https://bugs.webkit.org/show_bug.cgi?id=76812
Reviewed by Enrica Casucci.
Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.
* editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
* editing/selection/move-into-empty-root-inline-box.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp
Added Paths
trunk/LayoutTests/editing/deleting/delete-start-block-expected.txt
trunk/LayoutTests/editing/deleting/delete-start-block.html
Diff
Modified: trunk/LayoutTests/ChangeLog (106379 => 106380)
--- trunk/LayoutTests/ChangeLog 2012-01-31 20:05:37 UTC (rev 106379)
+++ trunk/LayoutTests/ChangeLog 2012-01-31 20:41:05 UTC (rev 106380)
@@ -1,3 +1,15 @@
+2012-01-31 Ryosuke Niwa rn...@webkit.org
+
+Crash in previousLinePosition when moving into a root inline box without leaves
+https://bugs.webkit.org/show_bug.cgi?id=76812
+
+Reviewed by Enrica Casucci.
+
+Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.
+
+* editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
+* editing/selection/move-into-empty-root-inline-box.html: Added.
+
2012-01-31 Tony Chang t...@chromium.org
[chromium] Fix css3/flexbox/cross-axis-scrollbar-expected to work on
Added: trunk/LayoutTests/editing/deleting/delete-start-block-expected.txt (0 => 106380)
--- trunk/LayoutTests/editing/deleting/delete-start-block-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/deleting/delete-start-block-expected.txt 2012-01-31 20:41:05 UTC (rev 106380)
@@ -0,0 +1,5 @@
+This tests removing the start block. WebKit should not crash.
+| div
+| br
+| br
+| br
Added: trunk/LayoutTests/editing/deleting/delete-start-block.html (0 => 106380)
--- trunk/LayoutTests/editing/deleting/delete-start-block.html (rev 0)
+++ trunk/LayoutTests/editing/deleting/delete-start-block.html 2012-01-31 20:41:05 UTC (rev 106380)
@@ -0,0 +1,15 @@
+progressscript src=""
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+document.designMode=on;
+document.execCommand(selectall);
+document.execCommand(justifycenter,false);
+document.body.removeChild(document.body.firstElementChild);
+document.execCommand(insertparagraph);
+
+Markup.description(This tests removing the start block. WebKit should not crash.);
+Markup.dump(document.body);
+
+/script
Modified: trunk/Source/WebCore/ChangeLog (106379 => 106380)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 20:05:37 UTC (rev 106379)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 20:41:05 UTC (rev 106380)
@@ -1,3 +1,19 @@
+2012-01-31 Ryosuke Niwa rn...@webkit.org
+
+Crash in DeleteSelectionCommand::handleGeneralDelete when attempting to delete the start block
+https://bugs.webkit.org/show_bug.cgi?id=77077
+
+Reviewed by Enrica Casucci.
+
+The crash was caused by a missing null check after removing the position out of the start block.
+Fixed the bug by adding an early return.
+
+Tests: editing/deleting/delete-start-block.html
+ editing/selection/move-into-empty-root-inline-box.html
+
+* editing/DeleteSelectionCommand.cpp:
+(WebCore::DeleteSelectionCommand::handleGeneralDelete):
+
2012-01-31 Rafael Brandao rafael.l...@openbossa.org
HTMLIsIndexElement should not expose HTMLInputElement properties
Modified: trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp (106379 => 106380)
--- trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2012-01-31 20:05:37 UTC (rev 106379)
+++ trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2012-01-31 20:41:05 UTC (rev 106380)
@@ -418,6 +418,8 @@
if (startNode == m_startBlock startOffset == 0 canHaveChildrenForEditing(startNode) !startNode-hasTagName(tableTag)) {
startOffset = 0;
startNode = startNode-traverseNextNode();
+if (!startNode)
+return;
}
if (startOffset = caretMaxOffset(startNode) startNode-isTextNode()) {
[webkit-changes] [106381] trunk/Source/WebKit/chromium
Title: [106381] trunk/Source/WebKit/chromium
Revision 106381
Author pi...@chromium.org
Date 2012-01-31 12:49:18 -0800 (Tue, 31 Jan 2012)
Log Message
Add back temporarily WebKitPlatformSupport::createGraphicsContext3D() to fix build
https://bugs.webkit.org/show_bug.cgi?id=77467
Rubber-stamped by Nate Chapin jap...@chromium.org.
* public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::createGraphicsContext3D):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106380 => 106381)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 20:41:05 UTC (rev 106380)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 20:49:18 UTC (rev 106381)
@@ -1,5 +1,16 @@
2012-01-31 Antoine Labour pi...@chromium.org
+Add back temporarily WebKitPlatformSupport::createGraphicsContext3D() to fix build
+https://bugs.webkit.org/show_bug.cgi?id=77467
+
+Rubber-stamped by Nate Chapin jap...@chromium.org.
+
+* public/platform/WebKitPlatformSupport.h:
+(WebKitPlatformSupport):
+(WebKit::WebKitPlatformSupport::createGraphicsContext3D):
+
+2012-01-31 Antoine Labour pi...@chromium.org
+
Merge WebGraphicsContext3D creation and initialization, and move it to
WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=76593
Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (106380 => 106381)
--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2012-01-31 20:41:05 UTC (rev 106380)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2012-01-31 20:49:18 UTC (rev 106381)
@@ -319,6 +319,8 @@
// May return null if GPU is not supported.
// Returns newly allocated and initialized offscreen WebGraphicsContext3D instance.
virtual WebGraphicsContext3D* createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes) { return 0; }
+// Deprecated.
+virtual WebGraphicsContext3D* createGraphicsContext3D() { return 0; }
// Audio --
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106384] trunk/Source/WebCore
Title: [106384] trunk/Source/WebCore
Revision 106384
Author an...@apple.com
Date 2012-01-31 13:24:12 -0800 (Tue, 31 Jan 2012)
Log Message
Remove CSSStyleDeclaration isElementStyleDeclaration bit
https://bugs.webkit.org/show_bug.cgi?id=77460
Reviewed by Andreas Kling.
Inline style declaration is now the only type of style declaration with element parent.
We can remove the bit and the associated logic.
* bindings/js/JSDOMBinding.h:
(WebCore::root):
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::createInline):
(CSSMutableStyleDeclaration):
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
(WebCore):
(WebCore::CSSStyleDeclaration::parentStyleSheet):
* css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::parentRule):
(WebCore::CSSStyleDeclaration::clearParentRule):
(WebCore::CSSStyleDeclaration::parentElement):
(WebCore::CSSStyleDeclaration::clearParentElement):
(CSSStyleDeclaration):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSMutableStyleDeclaration.h
trunk/Source/WebCore/css/CSSStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSStyleDeclaration.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (106383 => 106384)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 21:15:27 UTC (rev 106383)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 21:24:12 UTC (rev 106384)
@@ -1,3 +1,32 @@
+2012-01-31 Antti Koivisto an...@apple.com
+
+Remove CSSStyleDeclaration isElementStyleDeclaration bit
+https://bugs.webkit.org/show_bug.cgi?id=77460
+
+Reviewed by Andreas Kling.
+
+Inline style declaration is now the only type of style declaration with element parent.
+We can remove the bit and the associated logic.
+
+* bindings/js/JSDOMBinding.h:
+(WebCore::root):
+* css/CSSMutableStyleDeclaration.cpp:
+(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
+(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
+* css/CSSMutableStyleDeclaration.h:
+(WebCore::CSSMutableStyleDeclaration::createInline):
+(CSSMutableStyleDeclaration):
+* css/CSSStyleDeclaration.cpp:
+(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
+(WebCore):
+(WebCore::CSSStyleDeclaration::parentStyleSheet):
+* css/CSSStyleDeclaration.h:
+(WebCore::CSSStyleDeclaration::parentRule):
+(WebCore::CSSStyleDeclaration::clearParentRule):
+(WebCore::CSSStyleDeclaration::parentElement):
+(WebCore::CSSStyleDeclaration::clearParentElement):
+(CSSStyleDeclaration):
+
2012-01-31 Dana Jansens dan...@chromium.org
[chromium] Compute occlusion during paint loop
Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (106383 => 106384)
--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2012-01-31 21:15:27 UTC (rev 106383)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2012-01-31 21:24:12 UTC (rev 106384)
@@ -209,8 +209,6 @@
return root(parentRule);
if (CSSStyleSheet* styleSheet = style-parentStyleSheet())
return root(styleSheet);
-// A style declaration with an associated element should've returned a style sheet above.
-ASSERT(!style-isElementStyleDeclaration() || !static_castCSSMutableStyleDeclaration*(style)-parentElement());
return style;
}
Modified: trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp (106383 => 106384)
--- trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp 2012-01-31 21:15:27 UTC (rev 106383)
+++ trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp 2012-01-31 21:24:12 UTC (rev 106384)
@@ -134,7 +134,6 @@
} // namespace
CSSMutableStyleDeclaration::CSSMutableStyleDeclaration()
-: CSSStyleDeclaration(0)
{
// This constructor is used for various inline style declarations, so disable strict parsing.
m_strictParsing = false;
@@ -175,8 +174,8 @@
}
}
-CSSMutableStyleDeclaration::CSSMutableStyleDeclaration(StyledElement* element, bool isInline)
-: CSSStyleDeclaration(element, isInline)
+CSSMutableStyleDeclaration::CSSMutableStyleDeclaration(StyledElement* element)
+: CSSStyleDeclaration(element)
{
}
@@ -643,15 +642,13 @@
void CSSMutableStyleDeclaration::setNeedsStyleRecalc()
{
-if (isElementStyleDeclaration() parentElement()) {
+if (isInlineStyleDeclaration()) {
StyledElement* element = parentElement();
-if (!isInlineStyleDeclaration())
-element-setNeedsStyleRecalc(FullStyleChange);
-else {
-element-setNeedsStyleRecalc(InlineStyleChange);
-element-invalidateStyleAttribute();
-
[webkit-changes] [106385] trunk/Source/WebCore
Title: [106385] trunk/Source/WebCore
Revision 106385
Author ander...@apple.com
Date 2012-01-31 13:31:17 -0800 (Tue, 31 Jan 2012)
Log Message
Inform the tile cache whenever the visible rect changes
https://bugs.webkit.org/show_bug.cgi?id=77470
Reviewed by Andreas Kling.
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::visibleRectChanged):
Add empty function.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::visibleRectChanged):
Call through to the PlatformCALayer.
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::visibleRectChanged):
Call through to the underlying WebTileCacheLayer.
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::visibleRectChanged):
Add empty stub.
(WebCore::TileCache::visibleRect):
Add new (currently unused) helper function that returns the visible rect of the
tile cache layer.
* platform/graphics/ca/mac/WebTileCacheLayer.h:
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer visibleRectChanged]):
Call through to the TielCache object.
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::visibleRectChanged):
Add stub.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
Call GraphicsLayer::visibleRectChanged.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm
trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h
trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm
trunk/Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.h
trunk/Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.mm
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106384 => 106385)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 21:24:12 UTC (rev 106384)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 21:31:17 UTC (rev 106385)
@@ -1,3 +1,43 @@
+2012-01-31 Anders Carlsson ander...@apple.com
+
+Inform the tile cache whenever the visible rect changes
+https://bugs.webkit.org/show_bug.cgi?id=77470
+
+Reviewed by Andreas Kling.
+
+* platform/graphics/GraphicsLayer.h:
+(WebCore::GraphicsLayer::visibleRectChanged):
+Add empty function.
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::visibleRectChanged):
+Call through to the PlatformCALayer.
+
+* platform/graphics/ca/mac/PlatformCALayerMac.mm:
+(PlatformCALayer::visibleRectChanged):
+Call through to the underlying WebTileCacheLayer.
+
+* platform/graphics/ca/mac/TileCache.mm:
+(WebCore::TileCache::visibleRectChanged):
+Add empty stub.
+
+(WebCore::TileCache::visibleRect):
+Add new (currently unused) helper function that returns the visible rect of the
+tile cache layer.
+
+* platform/graphics/ca/mac/WebTileCacheLayer.h:
+* platform/graphics/ca/mac/WebTileCacheLayer.mm:
+(-[WebTileCacheLayer visibleRectChanged]):
+Call through to the TielCache object.
+
+* platform/graphics/ca/win/PlatformCALayerWin.cpp:
+(PlatformCALayer::visibleRectChanged):
+Add stub.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::frameViewDidScroll):
+Call GraphicsLayer::visibleRectChanged.
+
2012-01-31 Antti Koivisto an...@apple.com
Remove CSSStyleDeclaration isElementStyleDeclaration bit
Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.h (106384 => 106385)
--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.h 2012-01-31 21:24:12 UTC (rev 106384)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.h 2012-01-31 21:31:17 UTC (rev 106385)
@@ -408,6 +408,9 @@
bool usingTiledLayer() const { return m_usingTiledLayer; }
+// Called whenever the visible rect of the given GraphicsLayer changed.
+virtual void visibleRectChanged() { }
+
#if PLATFORM(QT) || PLATFORM(GTK)
// This allows several alternative GraphicsLayer implementations in the same port,
// e.g. if a different GraphicsLayer implementation is needed in WebKit1 vs. WebKit2.
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (106384 => 106385)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2012-01-31 21:24:12 UTC (rev 106384)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2012-01-31 21:31:17 UTC (rev 106385)
@@ -843,6 +843,11 @@
commitLayerChangesAfterSublayers();
}
+void GraphicsLayerCA::visibleRectChanged()
+{
+m_layer-visibleRectChanged();
+}
[webkit-changes] [106386] trunk/PerformanceTests
Title: [106386] trunk/PerformanceTests Revision 106386 Author rn...@webkit.org Date 2012-01-31 13:35:51 -0800 (Tue, 31 Jan 2012) Log Message PerfTestRunner should automatically create pre#log https://bugs.webkit.org/show_bug.cgi?id=77469 Reviewed by Tony Chang. Automatically generate pre id=log/pre if there isn't one. * Bindings/event-target-wrapper.html: * DOM/Accessors.html: * DOM/CloneNodes.html: * DOM/CreateNodes.html: * DOM/DOMDivWalk.html: * DOM/DOMTable.html: * DOM/DOMWalk.html: * DOM/Events.html: * DOM/GetElement.html: * DOM/GridSort.html: * DOM/Template.html: * Dromaeo/dom-query.html: * Dromaeo/resources/dromaeorunner.js: * Parser/html-parser.html: * Parser/html5-full-render.html: * Parser/simple-url.html: * Parser/tiny-innerHTML.html: * Parser/url-parser.html: * Parser/xml-parser.html: * resources/runner.js: (PerfTestRunner.log): (PerfTestRunner.printStatistics): Modified Paths trunk/PerformanceTests/Bindings/event-target-wrapper.html trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/DOM/Accessors.html trunk/PerformanceTests/DOM/CloneNodes.html trunk/PerformanceTests/DOM/CreateNodes.html trunk/PerformanceTests/DOM/DOMDivWalk.html trunk/PerformanceTests/DOM/DOMTable.html trunk/PerformanceTests/DOM/DOMWalk.html trunk/PerformanceTests/DOM/Events.html trunk/PerformanceTests/DOM/GetElement.html trunk/PerformanceTests/DOM/GridSort.html trunk/PerformanceTests/DOM/Template.html trunk/PerformanceTests/Dromaeo/dom-query.html trunk/PerformanceTests/Dromaeo/resources/dromaeorunner.js trunk/PerformanceTests/Parser/html-parser.html trunk/PerformanceTests/Parser/html5-full-render.html trunk/PerformanceTests/Parser/simple-url.html trunk/PerformanceTests/Parser/tiny-innerHTML.html trunk/PerformanceTests/Parser/url-parser.html trunk/PerformanceTests/Parser/xml-parser.html trunk/PerformanceTests/resources/runner.js Diff Modified: trunk/PerformanceTests/Bindings/event-target-wrapper.html (106385 => 106386) --- trunk/PerformanceTests/Bindings/event-target-wrapper.html 2012-01-31 21:31:17 UTC (rev 106385) +++ trunk/PerformanceTests/Bindings/event-target-wrapper.html 2012-01-31 21:35:51 UTC (rev 106386) @@ -1,6 +1,5 @@ !DOCTYPE html body -pre id=log/pre script src="" a href="" here to start/a script Modified: trunk/PerformanceTests/ChangeLog (106385 => 106386) --- trunk/PerformanceTests/ChangeLog 2012-01-31 21:31:17 UTC (rev 106385) +++ trunk/PerformanceTests/ChangeLog 2012-01-31 21:35:51 UTC (rev 106386) @@ -1,5 +1,37 @@ 2012-01-31 Ryosuke Niwa rn...@webkit.org +PerfTestRunner should automatically create pre#log +https://bugs.webkit.org/show_bug.cgi?id=77469 + +Reviewed by Tony Chang. + +Automatically generate pre id=log/pre if there isn't one. + +* Bindings/event-target-wrapper.html: +* DOM/Accessors.html: +* DOM/CloneNodes.html: +* DOM/CreateNodes.html: +* DOM/DOMDivWalk.html: +* DOM/DOMTable.html: +* DOM/DOMWalk.html: +* DOM/Events.html: +* DOM/GetElement.html: +* DOM/GridSort.html: +* DOM/Template.html: +* Dromaeo/dom-query.html: +* Dromaeo/resources/dromaeorunner.js: +* Parser/html-parser.html: +* Parser/html5-full-render.html: +* Parser/simple-url.html: +* Parser/tiny-innerHTML.html: +* Parser/url-parser.html: +* Parser/xml-parser.html: +* resources/runner.js: +(PerfTestRunner.log): +(PerfTestRunner.printStatistics): + +2012-01-31 Ryosuke Niwa rn...@webkit.org + runner.js in performance tests should define a class https://bugs.webkit.org/show_bug.cgi?id=77074 Modified: trunk/PerformanceTests/DOM/Accessors.html (106385 => 106386) --- trunk/PerformanceTests/DOM/Accessors.html 2012-01-31 21:31:17 UTC (rev 106385) +++ trunk/PerformanceTests/DOM/Accessors.html 2012-01-31 21:35:51 UTC (rev 106386) @@ -2,7 +2,6 @@ html body div id=containerspan id=benchmark_content/span/div -pre id=log/pre script type=text/_javascript_ src="" script type=text/_javascript_ src="" script type=text/_javascript_ src="" Modified: trunk/PerformanceTests/DOM/CloneNodes.html (106385 => 106386) --- trunk/PerformanceTests/DOM/CloneNodes.html 2012-01-31 21:31:17 UTC (rev 106385) +++ trunk/PerformanceTests/DOM/CloneNodes.html 2012-01-31 21:35:51 UTC (rev 106386) @@ -2,7 +2,6 @@ html body div id=containerspan id=benchmark_content/span/div -pre id=log/pre script type=text/_javascript_ src="" script type=text/_javascript_ src="" script type=text/_javascript_ src="" Modified: trunk/PerformanceTests/DOM/CreateNodes.html (106385 => 106386) --- trunk/PerformanceTests/DOM/CreateNodes.html 2012-01-31 21:31:17 UTC (rev 106385) +++ trunk/PerformanceTests/DOM/CreateNodes.html 2012-01-31 21:35:51 UTC (rev 106386) @@ -2,7 +2,6 @@ html body div id=containerspan id=benchmark_content/span/div -pre id=log/pre script type=text/_javascript_ src="" script
[webkit-changes] [106387] trunk
Title: [106387] trunk
Revision 106387
Author jsb...@chromium.org
Date 2012-01-31 13:39:33 -0800 (Tue, 31 Jan 2012)
Log Message
IndexedDB: IDBCursor.update() should raise exception if key changed
https://bugs.webkit.org/show_bug.cgi?id=76952
Source/WebCore:
Move the test from the async task to the synchronous call, per spec. Also re-ordered the tests
done during the synchronous call and the asynchronous task to follow the spec order.
Reviewed by Tony Chang.
Tests: storage/indexeddb/cursor-update.html
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put): Added check during update() call, order checks per spec.
(WebCore::IDBObjectStoreBackendImpl::putInternal): Move effective key calculation inline.
* storage/IDBObjectStoreBackendImpl.h: Removed selectKeyForPut method.
LayoutTests:
Reviewed by Tony Chang.
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/cursor-update.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/cursor-update-expected.txt
trunk/LayoutTests/storage/indexeddb/cursor-update.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp
trunk/Source/WebCore/storage/IDBObjectStoreBackendImpl.h
Diff
Modified: trunk/LayoutTests/ChangeLog (106386 => 106387)
--- trunk/LayoutTests/ChangeLog 2012-01-31 21:35:51 UTC (rev 106386)
+++ trunk/LayoutTests/ChangeLog 2012-01-31 21:39:33 UTC (rev 106387)
@@ -1,3 +1,13 @@
+2012-01-31 Joshua Bell jsb...@chromium.org
+
+IndexedDB: IDBCursor.update() should raise exception if key changed
+https://bugs.webkit.org/show_bug.cgi?id=76952
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/cursor-update-expected.txt:
+* storage/indexeddb/cursor-update.html:
+
2012-01-31 Ryosuke Niwa rn...@webkit.org
Crash in previousLinePosition when moving into a root inline box without leaves
Modified: trunk/LayoutTests/storage/indexeddb/cursor-update-expected.txt (106386 => 106387)
--- trunk/LayoutTests/storage/indexeddb/cursor-update-expected.txt 2012-01-31 21:35:51 UTC (rev 106386)
+++ trunk/LayoutTests/storage/indexeddb/cursor-update-expected.txt 2012-01-31 21:39:33 UTC (rev 106387)
@@ -104,28 +104,28 @@
PASS counter is 5
trans.objectStore('keyPathStore').openCursor(keyRange)
keyPathUpdateCursor()
-event.target.result.update({id: 100 + counter, number: 100 + counter})
-PASS event.target.errorCode is webkitIDBDatabaseException.DATA_ERR
-event.preventDefault()
-event.target.source.update({id: counter, number: 100 + counter++})
+Expecting exception from event.target.result.update({id: 100 + counter, number: 100 + counter})
+PASS Exception was thrown.
+PASS code is webkitIDBDatabaseException.DATA_ERR
+event.target.result.update({id: counter, number: 100 + counter++})
event.target.source.continue()
keyPathUpdateCursor()
-event.target.result.update({id: 100 + counter, number: 100 + counter})
-PASS event.target.errorCode is webkitIDBDatabaseException.DATA_ERR
-event.preventDefault()
-event.target.source.update({id: counter, number: 100 + counter++})
+Expecting exception from event.target.result.update({id: 100 + counter, number: 100 + counter})
+PASS Exception was thrown.
+PASS code is webkitIDBDatabaseException.DATA_ERR
+event.target.result.update({id: counter, number: 100 + counter++})
event.target.source.continue()
keyPathUpdateCursor()
-event.target.result.update({id: 100 + counter, number: 100 + counter})
-PASS event.target.errorCode is webkitIDBDatabaseException.DATA_ERR
-event.preventDefault()
-event.target.source.update({id: counter, number: 100 + counter++})
+Expecting exception from event.target.result.update({id: 100 + counter, number: 100 + counter})
+PASS Exception was thrown.
+PASS code is webkitIDBDatabaseException.DATA_ERR
+event.target.result.update({id: counter, number: 100 + counter++})
event.target.source.continue()
keyPathUpdateCursor()
-event.target.result.update({id: 100 + counter, number: 100 + counter})
-PASS event.target.errorCode is webkitIDBDatabaseException.DATA_ERR
-event.preventDefault()
-event.target.source.update({id: counter, number: 100 + counter++})
+Expecting exception from event.target.result.update({id: 100 + counter, number: 100 + counter})
+PASS Exception was thrown.
+PASS code is webkitIDBDatabaseException.DATA_ERR
+event.target.result.update({id: counter, number: 100 + counter++})
event.target.source.continue()
keyPathUpdateCursor()
PASS counter is 5
Modified: trunk/LayoutTests/storage/indexeddb/cursor-update.html (106386 => 106387)
--- trunk/LayoutTests/storage/indexeddb/cursor-update.html 2012-01-31 21:35:51 UTC (rev 106386)
+++ trunk/LayoutTests/storage/indexeddb/cursor-update.html 2012-01-31 21:39:33 UTC (rev 106387)
@@ -163,17 +163,11 @@
return;
}
-request = evalAndLog(event.target.result.update({id: 100 + counter, number: 100 + counter}));
-request._onsuccess_ = unexpectedSuccessCallback;
-
[webkit-changes] [106388] trunk
Title: [106388] trunk
Revision 106388
Author jon...@apple.com
Date 2012-01-31 13:43:56 -0800 (Tue, 31 Jan 2012)
Log Message
Hidden form elements do not save their state prior to form submission
https://bugs.webkit.org/show_bug.cgi?id=77391
rdar://problem/10563108
Reviewed by Brady Eidson.
Source/WebCore:
Test: fast/forms/state-restore-hidden.html
* html/HiddenInputType.cpp: Teach hidden inputs to save and restore their state.
(WebCore::HiddenInputType::saveFormControlState):
(WebCore::HiddenInputType::restoreFormControlState):
* html/HiddenInputType.h:
(HiddenInputType):
LayoutTests:
The test changes the value of the hidden input element via _javascript_ prior to
submitting the form. The form action goes back one page, and we check to see
that the hidden input value is what it was set to by _javascript_, rather than what
it was originally assigned.
* fast/forms/state-restore-hidden-expected.txt: Added.
* fast/forms/state-restore-hidden.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HiddenInputType.cpp
trunk/Source/WebCore/html/HiddenInputType.h
Added Paths
trunk/LayoutTests/fast/forms/state-restore-hidden-expected.txt
trunk/LayoutTests/fast/forms/state-restore-hidden.html
Diff
Modified: trunk/LayoutTests/ChangeLog (106387 => 106388)
--- trunk/LayoutTests/ChangeLog 2012-01-31 21:39:33 UTC (rev 106387)
+++ trunk/LayoutTests/ChangeLog 2012-01-31 21:43:56 UTC (rev 106388)
@@ -1,3 +1,19 @@
+2012-01-31 Jon Lee jon...@apple.com
+
+Hidden form elements do not save their state prior to form submission
+https://bugs.webkit.org/show_bug.cgi?id=77391
+rdar://problem/10563108
+
+Reviewed by Brady Eidson.
+
+The test changes the value of the hidden input element via _javascript_ prior to
+submitting the form. The form action goes back one page, and we check to see
+that the hidden input value is what it was set to by _javascript_, rather than what
+it was originally assigned.
+
+* fast/forms/state-restore-hidden-expected.txt: Added.
+* fast/forms/state-restore-hidden.html: Added.
+
2012-01-31 Joshua Bell jsb...@chromium.org
IndexedDB: IDBCursor.update() should raise exception if key changed
Added: trunk/LayoutTests/fast/forms/state-restore-hidden-expected.txt (0 => 106388)
--- trunk/LayoutTests/fast/forms/state-restore-hidden-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/state-restore-hidden-expected.txt 2012-01-31 21:43:56 UTC (rev 106388)
@@ -0,0 +1,11 @@
+Bug 77391 - Hidden form elements do not save their state prior to form submission
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS document.f.hidden.value is after
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+
Added: trunk/LayoutTests/fast/forms/state-restore-hidden.html (0 => 106388)
--- trunk/LayoutTests/fast/forms/state-restore-hidden.html (rev 0)
+++ trunk/LayoutTests/fast/forms/state-restore-hidden.html 2012-01-31 21:43:56 UTC (rev 106388)
@@ -0,0 +1,45 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body _onload_=runTest()
+
+div id=console/div
+
+input id=emptyOnFirstVisit /
+form action="" name=f
+input type=hidden name=hidden value=before /
+/form
+
+script
+description(Bug 77391 - Hidden form elements do not save their state prior to form submission);
+
+function runTest() {
+var state = document.getElementById(emptyOnFirstVisit);
+if (!state.value) {
+// First visit.
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+state.value = visited;
+
+document.f.hidden.value = after;
+// Submit form in a timeout to make sure that we create a new back/forward list item.
+setTimeout(function() {document.f.submit();}, 0);
+} else {
+// Second visit.
+shouldBeEqualToString(document.f.hidden.value, after);
+successfullyParsed = true;
+
+var script = document.createElement('script');
+script.src = ""
+script.type = text/_javascript_;
+script._onload_ = function() {
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+};
+document.body.appendChild(script);
+}
+}
+/script
+/body
Modified: trunk/Source/WebCore/ChangeLog (106387 => 106388)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 21:39:33 UTC (rev 106387)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 21:43:56 UTC (rev 106388)
@@ -1,3 +1,19 @@
+2012-01-31 Jon Lee jon...@apple.com
+
+Hidden form elements do not save their state prior to form submission
+https://bugs.webkit.org/show_bug.cgi?id=77391
+rdar://problem/10563108
+
+Reviewed by Brady Eidson.
+
+Test: fast/forms/state-restore-hidden.html
+
+* html/HiddenInputType.cpp: Teach hidden
[webkit-changes] [106389] trunk/Tools
Title: [106389] trunk/Tools
Revision 106389
Author o...@chromium.org
Date 2012-01-31 13:46:09 -0800 (Tue, 31 Jan 2012)
Log Message
Unreviewed, rolling out r106302.
http://trac.webkit.org/changeset/106302
https://bugs.webkit.org/show_bug.cgi?id=77472
Broke building DRT before running the tests (Requested by ojan
on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-01-31
* Scripts/webkit-build-directory:
* Scripts/webkitpy/layout_tests/port/config.py:
(Config.build_directory):
* Scripts/webkitpy/layout_tests/port/config_standalone.py:
(main):
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.assert_configuration):
(ConfigTest.test_build_directory.mock_webkit_build_directory):
(ConfigTest.test_build_directory):
(ConfigTest.test_default_configuration__notfound):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._build_path):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkit-build-directory
trunk/Tools/Scripts/webkitpy/layout_tests/port/config.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/config_standalone.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
Diff
Modified: trunk/Tools/ChangeLog (106388 => 106389)
--- trunk/Tools/ChangeLog 2012-01-31 21:43:56 UTC (rev 106388)
+++ trunk/Tools/ChangeLog 2012-01-31 21:46:09 UTC (rev 106389)
@@ -1,3 +1,25 @@
+2012-01-31 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r106302.
+http://trac.webkit.org/changeset/106302
+https://bugs.webkit.org/show_bug.cgi?id=77472
+
+Broke building DRT before running the tests (Requested by ojan
+on #webkit).
+
+* Scripts/webkit-build-directory:
+* Scripts/webkitpy/layout_tests/port/config.py:
+(Config.build_directory):
+* Scripts/webkitpy/layout_tests/port/config_standalone.py:
+(main):
+* Scripts/webkitpy/layout_tests/port/config_unittest.py:
+(ConfigTest.assert_configuration):
+(ConfigTest.test_build_directory.mock_webkit_build_directory):
+(ConfigTest.test_build_directory):
+(ConfigTest.test_default_configuration__notfound):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitPort._build_path):
+
2012-01-31 Antoine Labour pi...@chromium.org
Merge WebGraphicsContext3D creation and initialization, and move it to
Modified: trunk/Tools/Scripts/webkit-build-directory (106388 => 106389)
--- trunk/Tools/Scripts/webkit-build-directory 2012-01-31 21:43:56 UTC (rev 106388)
+++ trunk/Tools/Scripts/webkit-build-directory 2012-01-31 21:46:09 UTC (rev 106389)
@@ -57,16 +57,13 @@
'help|h' = \$showHelp,
);
-if (!$getOptionsResult || $showHelp) {
+if (!$getOptionsResult || $showHelp || (!$showConfigurationDirectory !$showTopLevelDirectory)) {
print STDERR $usage;
exit 1;
}
-if (!$showConfigurationDirectory !$showTopLevelDirectory) {
+if ($showTopLevelDirectory) {
print baseProductDir() . \n;
-print productDir() . \n;
-} elsif ($showTopLevelDirectory) {
-print baseProductDir() . \n;
} else {
print productDir() . \n;
}
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/config.py (106388 => 106389)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/config.py 2012-01-31 21:43:56 UTC (rev 106388)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/config.py 2012-01-31 21:46:09 UTC (rev 106389)
@@ -74,20 +74,13 @@
flags = [--configuration, self.flag_for_configuration(configuration)]
else:
configuration =
-flags = []
+flags = [--top-level]
if not self._build_directories.get(configuration):
args = [perl, self.script_path(webkit-build-directory)] + flags
-output = self._executive.run_command(args, cwd=self.webkit_base_dir()).rstrip()
-parts = output.split(\n)
-self._build_directories[configuration] = parts[0]
+self._build_directories[configuration] = (
+self._executive.run_command(args, cwd=self.webkit_base_dir()).rstrip())
-if len(parts) == 2:
-default_configuration = parts[1][len(parts[0]):]
-if default_configuration.startswith(/):
-default_configuration = default_configuration[1:]
-self._build_directories[default_configuration] = parts[1]
-
return self._build_directories[configuration]
def flag_for_configuration(self, configuration):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/config_standalone.py (106388 => 106389)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/config_standalone.py 2012-01-31 21:43:56 UTC (rev 106388)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/config_standalone.py 2012-01-31 21:46:09 UTC (rev 106389)
@@ -57,7 +57,7 @@
argv = sys.argv
if len(argv) == 3 and argv[1] ==
[webkit-changes] [106391] trunk/Source
Title: [106391] trunk/Source
Revision 106391
Author commit-qu...@webkit.org
Date 2012-01-31 14:00:10 -0800 (Tue, 31 Jan 2012)
Log Message
[Chromium] Remove references to gyp cygwin build target
https://bugs.webkit.org/show_bug.cgi?id=77253
Patch by Scott Graham scot...@chromium.org on 2012-01-31
Reviewed by Julien Chaffraix.
Target dependency is no longer required, it's done earlier in the
build process.
Source/_javascript_Core:
* _javascript_Core.gyp/_javascript_Core.gyp:
Source/WebCore:
* WebCore.gyp/WebCore.gyp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (106390 => 106391)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-31 21:57:01 UTC (rev 106390)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-31 22:00:10 UTC (rev 106391)
@@ -1,3 +1,15 @@
+2012-01-31 Scott Graham scot...@chromium.org
+
+[Chromium] Remove references to gyp cygwin build target
+https://bugs.webkit.org/show_bug.cgi?id=77253
+
+Reviewed by Julien Chaffraix.
+
+Target dependency is no longer required, it's done earlier in the
+build process.
+
+* _javascript_Core.gyp/_javascript_Core.gyp:
+
2012-01-31 Michael Saboff msab...@apple.com
ASSERT(m_jumpsToLink.isEmpty()) failing in ARMv7Assembler dtor
Modified: trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp (106390 => 106391)
--- trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp 2012-01-31 21:57:01 UTC (rev 106390)
+++ trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp 2012-01-31 22:00:10 UTC (rev 106391)
@@ -198,11 +198,6 @@
'dependencies': [
'wtf',
],
- 'conditions': [
-['OS==win', {
- 'dependencies': ['(chromium_src_dir)/build/win/system.gyp:cygwin'],
-}],
- ],
'variables': { 'optimize': 'max' },
'actions': [
{
Modified: trunk/Source/WebCore/ChangeLog (106390 => 106391)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 21:57:01 UTC (rev 106390)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 22:00:10 UTC (rev 106391)
@@ -1,3 +1,15 @@
+2012-01-31 Scott Graham scot...@chromium.org
+
+[Chromium] Remove references to gyp cygwin build target
+https://bugs.webkit.org/show_bug.cgi?id=77253
+
+Reviewed by Julien Chaffraix.
+
+Target dependency is no longer required, it's done earlier in the
+build process.
+
+* WebCore.gyp/WebCore.gyp:
+
2012-01-31 Jon Lee jon...@apple.com
Hidden form elements do not save their state prior to form submission
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (106390 => 106391)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-01-31 21:57:01 UTC (rev 106390)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-01-31 22:00:10 UTC (rev 106391)
@@ -1134,9 +1134,6 @@
],
}],
['OS==win', {
- 'dependencies': [
-'(chromium_src_dir)/build/win/system.gyp:cygwin'
- ],
'defines': [
'WEBCORE_NAVIGATOR_PLATFORM=Win32',
'__PRETTY_FUNCTION__=__FUNCTION__',
@@ -1339,12 +1336,6 @@
},
}],
['OS==win', {
- 'dependencies': [
-'(chromium_src_dir)/build/win/system.gyp:cygwin'
- ],
- 'export_dependent_settings': [
-'(chromium_src_dir)/build/win/system.gyp:cygwin'
- ],
'direct_dependent_settings': {
'defines': [
# Match Safari and Mozilla on Windows.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106392] trunk/LayoutTests
Title: [106392] trunk/LayoutTests
Revision 106392
Author dgro...@chromium.org
Date 2012-01-31 14:05:31 -0800 (Tue, 31 Jan 2012)
Log Message
IndexedDB: refactor basics layout test so that it can be run on workers.
https://bugs.webkit.org/show_bug.cgi?id=76683
Reviewed by Tony Chang.
* storage/indexeddb/basics-workers-expected.txt: Added.
* storage/indexeddb/basics-workers.html: Added.
* storage/indexeddb/basics.html:
* storage/indexeddb/resources/basics.js: Copied from LayoutTests/storage/indexeddb/basics.html.
(test):
(openCallback):
* storage/indexeddb/resources/idb-worker-common.js: Added.
(debug):
(finishJSTest):
(description):
(testPassed):
(testFailed):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/basics-expected.txt
trunk/LayoutTests/storage/indexeddb/basics.html
trunk/LayoutTests/storage/indexeddb/resources/shared.js
Added Paths
trunk/LayoutTests/storage/indexeddb/basics-workers-expected.txt
trunk/LayoutTests/storage/indexeddb/basics-workers.html
trunk/LayoutTests/storage/indexeddb/resources/basics.js
trunk/LayoutTests/storage/indexeddb/resources/idb-worker-common.js
Diff
Modified: trunk/LayoutTests/ChangeLog (106391 => 106392)
--- trunk/LayoutTests/ChangeLog 2012-01-31 22:00:10 UTC (rev 106391)
+++ trunk/LayoutTests/ChangeLog 2012-01-31 22:05:31 UTC (rev 106392)
@@ -1,3 +1,23 @@
+2012-01-31 David Grogan dgro...@chromium.org
+
+IndexedDB: refactor basics layout test so that it can be run on workers.
+https://bugs.webkit.org/show_bug.cgi?id=76683
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/basics-workers-expected.txt: Added.
+* storage/indexeddb/basics-workers.html: Added.
+* storage/indexeddb/basics.html:
+* storage/indexeddb/resources/basics.js: Copied from LayoutTests/storage/indexeddb/basics.html.
+(test):
+(openCallback):
+* storage/indexeddb/resources/idb-worker-common.js: Added.
+(debug):
+(finishJSTest):
+(description):
+(testPassed):
+(testFailed):
+
2012-01-31 Eric Seidel e...@webkit.org
Rebaseline results after http://trac.webkit.org/changeset/106373
Modified: trunk/LayoutTests/storage/indexeddb/basics-expected.txt (106391 => 106392)
--- trunk/LayoutTests/storage/indexeddb/basics-expected.txt 2012-01-31 22:00:10 UTC (rev 106391)
+++ trunk/LayoutTests/storage/indexeddb/basics-expected.txt 2012-01-31 22:05:31 UTC (rev 106392)
@@ -3,9 +3,9 @@
On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-PASS 'webkitIndexedDB' in window is true
+PASS 'webkitIndexedDB' in self is true
PASS webkitIndexedDB == null is false
-PASS 'webkitIDBCursor' in window is true
+PASS 'webkitIDBCursor' in self is true
PASS webkitIDBCursor == null is false
webkitIndexedDB.open('basics')
PASS 'result' in request is true
Added: trunk/LayoutTests/storage/indexeddb/basics-workers-expected.txt (0 => 106392)
--- trunk/LayoutTests/storage/indexeddb/basics-workers-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/basics-workers-expected.txt 2012-01-31 22:05:31 UTC (rev 106392)
@@ -0,0 +1,55 @@
+[Worker] Test IndexedDB's basics.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Starting worker: resources/basics.js
+PASS [Worker] 'webkitIndexedDB' in self is true
+PASS [Worker] webkitIndexedDB == null is false
+PASS [Worker] 'webkitIDBCursor' in self is true
+PASS [Worker] webkitIDBCursor == null is false
+[Worker] webkitIndexedDB.open('basics')
+PASS [Worker] 'result' in request is true
+[Worker] Expecting exception from request.result
+PASS [Worker] Exception was thrown.
+PASS [Worker] code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
+PASS [Worker] 'errorCode' in request is true
+[Worker] Expecting exception from request.errorCode
+PASS [Worker] Exception was thrown.
+PASS [Worker] code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
+PASS [Worker] 'webkitErrorMessage' in request is true
+[Worker] Expecting exception from request.webkitErrorMessage
+PASS [Worker] Exception was thrown.
+PASS [Worker] code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
+PASS [Worker] 'source' in request is true
+PASS [Worker] request.source is webkitIndexedDB
+PASS [Worker] 'transaction' in request is true
+PASS [Worker] request.transaction is null
+PASS [Worker] 'readyState' in request is true
+PASS [Worker] request.readyState is webkitIDBRequest.LOADING
+PASS [Worker] 'onsuccess' in request is true
+PASS [Worker] request.onsuccess is null
+PASS [Worker] 'onerror' in request is true
+PASS [Worker] request.onerror is null
+PASS [Worker] request.LOADING is 1
+PASS [Worker] request.DONE is 2
+PASS [Worker] 'result' in event.target is true
+PASS [Worker] !!event.target.result is true
+PASS [Worker] 'errorCode' in event.target is true
+PASS [Worker] event.target.errorCode is 0
+PASS [Worker] 'webkitErrorMessage' in event.target is true
+PASS
[webkit-changes] [106393] trunk/Source/WebCore
Title: [106393] trunk/Source/WebCore
Revision 106393
Author an...@apple.com
Date 2012-01-31 14:30:22 -0800 (Tue, 31 Jan 2012)
Log Message
Make CSSOM style() return CSSStyleDeclaration*
https://bugs.webkit.org/show_bug.cgi?id=77475
Reviewed by Anders Carlsson
CSSStyleRule::style() and some other places return CSSMutableStyleDeclaration.
They should return the plain CSSOM type instead.
CSSMutableStyleDeclaration* should be available through non-CSSOM function.
* css/CSSFontFaceRule.h:
(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::declaration):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSStyleRule.h:
(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::declaration):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForKeyframe):
* css/WebKitCSSKeyframeRule.h:
(WebCore):
(WebCore::WebKitCSSKeyframeRule::style):
(WebCore::WebKitCSSKeyframeRule::declaration):
(WebKitCSSKeyframeRule):
* editing/EditingStyle.cpp:
(WebCore::styleFromMatchedRulesForElement):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::revalidateStyle):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForCSSRule):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::parseMappedAttribute):
(WebCore::SVGFontFaceElement::fontFamily):
(WebCore::SVGFontFaceElement::rebuildFontFace):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceRule.h
trunk/Source/WebCore/css/CSSFontSelector.cpp
trunk/Source/WebCore/css/CSSStyleRule.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/WebKitCSSKeyframeRule.h
trunk/Source/WebCore/editing/EditingStyle.cpp
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp
trunk/Source/WebCore/page/PageSerializer.cpp
trunk/Source/WebCore/svg/SVGFontFaceElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106392 => 106393)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 22:05:31 UTC (rev 106392)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 22:30:22 UTC (rev 106393)
@@ -1,3 +1,41 @@
+2012-01-31 Antti Koivisto an...@apple.com
+
+Make CSSOM style() return CSSStyleDeclaration*
+https://bugs.webkit.org/show_bug.cgi?id=77475
+
+Reviewed by Anders Carlsson
+
+CSSStyleRule::style() and some other places return CSSMutableStyleDeclaration.
+They should return the plain CSSOM type instead.
+
+CSSMutableStyleDeclaration* should be available through non-CSSOM function.
+
+* css/CSSFontFaceRule.h:
+(WebCore::CSSFontFaceRule::style):
+(WebCore::CSSFontFaceRule::declaration):
+* css/CSSFontSelector.cpp:
+(WebCore::CSSFontSelector::addFontFaceRule):
+* css/CSSStyleRule.h:
+(WebCore::CSSStyleRule::style):
+(WebCore::CSSStyleRule::declaration):
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::styleForKeyframe):
+* css/WebKitCSSKeyframeRule.h:
+(WebCore):
+(WebCore::WebKitCSSKeyframeRule::style):
+(WebCore::WebKitCSSKeyframeRule::declaration):
+(WebKitCSSKeyframeRule):
+* editing/EditingStyle.cpp:
+(WebCore::styleFromMatchedRulesForElement):
+* inspector/InspectorStyleSheet.cpp:
+(WebCore::InspectorStyleSheet::revalidateStyle):
+* page/PageSerializer.cpp:
+(WebCore::PageSerializer::retrieveResourcesForCSSRule):
+* svg/SVGFontFaceElement.cpp:
+(WebCore::SVGFontFaceElement::parseMappedAttribute):
+(WebCore::SVGFontFaceElement::fontFamily):
+(WebCore::SVGFontFaceElement::rebuildFontFace):
+
2012-01-31 Scott Graham scot...@chromium.org
[Chromium] Remove references to gyp cygwin build target
Modified: trunk/Source/WebCore/css/CSSFontFaceRule.h (106392 => 106393)
--- trunk/Source/WebCore/css/CSSFontFaceRule.h 2012-01-31 22:05:31 UTC (rev 106392)
+++ trunk/Source/WebCore/css/CSSFontFaceRule.h 2012-01-31 22:30:22 UTC (rev 106393)
@@ -42,10 +42,11 @@
~CSSFontFaceRule();
-CSSMutableStyleDeclaration* style() const { return m_style.get(); }
+CSSStyleDeclaration* style() const { return m_style.get(); }
String cssText() const;
+CSSMutableStyleDeclaration* declaration() const { return m_style.get(); }
void setDeclaration(PassRefPtrCSSMutableStyleDeclaration style) { m_style = style; }
void addSubresourceStyleURLs(ListHashSetKURL urls);
Modified: trunk/Source/WebCore/css/CSSFontSelector.cpp (106392 => 106393)
--- trunk/Source/WebCore/css/CSSFontSelector.cpp 2012-01-31 22:05:31 UTC (rev 106392)
+++ trunk/Source/WebCore/css/CSSFontSelector.cpp 2012-01-31 22:30:22 UTC (rev 106393)
@@ -86,7 +86,7 @@
void CSSFontSelector::addFontFaceRule(const CSSFontFaceRule* fontFaceRule)
{
// Obtain the font-family property and the src property. Both must be defined.
-const CSSMutableStyleDeclaration* style = fontFaceRule-style();
+const
[webkit-changes] [106394] trunk/Source/WebKit/chromium
Title: [106394] trunk/Source/WebKit/chromium
Revision 106394
Author fsam...@chromium.org
Date 2012-01-31 14:40:19 -0800 (Tue, 31 Jan 2012)
Log Message
[Chromium] Expose setLayoutFallbackWidth as a WebSetting
https://bugs.webkit.org/show_bug.cgi?id=77431
Reviewed by Darin Fisher.
The layout fallback width is the default fixed layout width
set for desktop web pages that lack a viewport tag. This width
can vary from platform to platform and can depend on other factors,
and so it should be a setting exposed to Chromium.
* public/WebSettings.h:
():
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setLayoutFallbackWidth):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106393 => 106394)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 22:30:22 UTC (rev 106393)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 22:40:19 UTC (rev 106394)
@@ -1,3 +1,23 @@
+2012-01-31 Fady Samuel fsam...@chromium.org
+
+[Chromium] Expose setLayoutFallbackWidth as a WebSetting
+https://bugs.webkit.org/show_bug.cgi?id=77431
+
+Reviewed by Darin Fisher.
+
+The layout fallback width is the default fixed layout width
+set for desktop web pages that lack a viewport tag. This width
+can vary from platform to platform and can depend on other factors,
+and so it should be a setting exposed to Chromium.
+
+* public/WebSettings.h:
+():
+* src/WebSettingsImpl.cpp:
+(WebKit::WebSettingsImpl::setLayoutFallbackWidth):
+(WebKit):
+* src/WebSettingsImpl.h:
+(WebSettingsImpl):
+
2012-01-31 Dana Jansens dan...@chromium.org
[chromium] Compute occlusion during paint loop
Modified: trunk/Source/WebKit/chromium/public/WebSettings.h (106393 => 106394)
--- trunk/Source/WebKit/chromium/public/WebSettings.h 2012-01-31 22:30:22 UTC (rev 106393)
+++ trunk/Source/WebKit/chromium/public/WebSettings.h 2012-01-31 22:40:19 UTC (rev 106394)
@@ -120,6 +120,7 @@
virtual void setAcceleratedFiltersEnabled(bool) = 0;
virtual void setMemoryInfoEnabled(bool) = 0;
virtual void setHyperlinkAuditingEnabled(bool) = 0;
+virtual void setLayoutFallbackWidth(int) = 0;
virtual void setAsynchronousSpellCheckingEnabled(bool) = 0;
virtual void setUnifiedTextCheckerEnabled(bool) = 0;
virtual void setCaretBrowsingEnabled(bool) = 0;
Modified: trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp (106393 => 106394)
--- trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp 2012-01-31 22:30:22 UTC (rev 106393)
+++ trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp 2012-01-31 22:40:19 UTC (rev 106394)
@@ -393,6 +393,11 @@
m_settings-setHyperlinkAuditingEnabled(enabled);
}
+void WebSettingsImpl::setLayoutFallbackWidth(int width)
+{
+m_settings-setLayoutFallbackWidth(width);
+}
+
void WebSettingsImpl::setAsynchronousSpellCheckingEnabled(bool enabled)
{
m_settings-setAsynchronousSpellCheckingEnabled(enabled);
Modified: trunk/Source/WebKit/chromium/src/WebSettingsImpl.h (106393 => 106394)
--- trunk/Source/WebKit/chromium/src/WebSettingsImpl.h 2012-01-31 22:30:22 UTC (rev 106393)
+++ trunk/Source/WebKit/chromium/src/WebSettingsImpl.h 2012-01-31 22:40:19 UTC (rev 106394)
@@ -112,6 +112,7 @@
virtual void setAcceleratedFiltersEnabled(bool);
virtual void setMemoryInfoEnabled(bool);
virtual void setHyperlinkAuditingEnabled(bool);
+virtual void setLayoutFallbackWidth(int);
virtual void setAsynchronousSpellCheckingEnabled(bool);
virtual void setUnifiedTextCheckerEnabled(bool);
virtual void setCaretBrowsingEnabled(bool);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106395] trunk/Source/WebKit/chromium
Title: [106395] trunk/Source/WebKit/chromium
Revision 106395
Author fsam...@chromium.org
Date 2012-01-31 14:42:26 -0800 (Tue, 31 Jan 2012)
Log Message
[Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called in Google News
https://bugs.webkit.org/show_bug.cgi?id=77429
Reviewed by Darin Fisher.
m_webView-isPageScaleFactorSet() is tested in ChromeClientImpl::layoutUpdated, and it is never true,
because WebViewImpl::setPageScaleFactorPreservingScrollOffset is called repeatedly and exits early
and thus never calls WebViewImpl::setPageScaleFactor which sets the flag.
The simplest solution is to simply get rid of the early return in
WebViewImpl::setPageScaleFactorPreservingScrollOffset.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106394 => 106395)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 22:40:19 UTC (rev 106394)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 22:42:26 UTC (rev 106395)
@@ -1,5 +1,22 @@
2012-01-31 Fady Samuel fsam...@chromium.org
+[Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called in Google News
+https://bugs.webkit.org/show_bug.cgi?id=77429
+
+Reviewed by Darin Fisher.
+
+m_webView-isPageScaleFactorSet() is tested in ChromeClientImpl::layoutUpdated, and it is never true,
+because WebViewImpl::setPageScaleFactorPreservingScrollOffset is called repeatedly and exits early
+and thus never calls WebViewImpl::setPageScaleFactor which sets the flag.
+
+The simplest solution is to simply get rid of the early return in
+WebViewImpl::setPageScaleFactorPreservingScrollOffset.
+
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
+
+2012-01-31 Fady Samuel fsam...@chromium.org
+
[Chromium] Expose setLayoutFallbackWidth as a WebSetting
https://bugs.webkit.org/show_bug.cgi?id=77431
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (106394 => 106395)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-01-31 22:40:19 UTC (rev 106394)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-01-31 22:42:26 UTC (rev 106395)
@@ -2030,8 +2030,6 @@
{
// Pick a scale factor that is within the expected limits
scaleFactor = clampPageScaleFactorToLimits(scaleFactor);
-if (scaleFactor == pageScaleFactor())
-return;
IntPoint scrollOffsetAtNewScale(mainFrame()-scrollOffset().width, mainFrame()-scrollOffset().height);
float deltaScale = scaleFactor / pageScaleFactor();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106396] trunk/Tools
Title: [106396] trunk/Tools
Revision 106396
Author e...@webkit.org
Date 2012-01-31 14:45:22 -0800 (Tue, 31 Jan 2012)
Log Message
webkit-patch apply-from-bug should work regardless of your CWD
https://bugs.webkit.org/show_bug.cgi?id=77482
Reviewed by Adam Barth.
webkit-patch only ever works with patches made from the root
directory. We should pass the CWD to svn-apply in the case
where we're running not from the webkit root. I believe
this used to work in the past and regressed.
* Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.apply_patch):
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CheckoutTest.test_apply_patch):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py
trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (106395 => 106396)
--- trunk/Tools/ChangeLog 2012-01-31 22:42:26 UTC (rev 106395)
+++ trunk/Tools/ChangeLog 2012-01-31 22:45:22 UTC (rev 106396)
@@ -1,3 +1,20 @@
+2012-01-31 Eric Seidel e...@webkit.org
+
+webkit-patch apply-from-bug should work regardless of your CWD
+https://bugs.webkit.org/show_bug.cgi?id=77482
+
+Reviewed by Adam Barth.
+
+webkit-patch only ever works with patches made from the root
+directory. We should pass the CWD to svn-apply in the case
+where we're running not from the webkit root. I believe
+this used to work in the past and regressed.
+
+* Scripts/webkitpy/common/checkout/checkout.py:
+(Checkout.apply_patch):
+* Scripts/webkitpy/common/checkout/checkout_unittest.py:
+(CheckoutTest.test_apply_patch):
+
2012-01-31 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r106302.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py (106395 => 106396)
--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py 2012-01-31 22:42:26 UTC (rev 106395)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py 2012-01-31 22:45:22 UTC (rev 106396)
@@ -158,7 +158,7 @@
args = [self._scm.script_path('svn-apply'), --force]
if patch.reviewer():
args += ['--reviewer', patch.reviewer().full_name]
-self._executive.run_command(args, input=patch.contents())
+self._executive.run_command(args, input=patch.contents(), cwd=self._scm.checkout_root)
def apply_reverse_diff(self, revision):
self._scm.apply_reverse_diff(revision)
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py (106395 => 106396)
--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py 2012-01-31 22:42:26 UTC (rev 106395)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py 2012-01-31 22:45:22 UTC (rev 106396)
@@ -261,5 +261,5 @@
mock_patch = Mock()
mock_patch.contents = lambda: foo
mock_patch.reviewer = lambda: None
-expected_stderr = MOCK run_command: ['svn-apply', '--force'], cwd=None\n
+expected_stderr = MOCK run_command: ['svn-apply', '--force'], cwd=/mock-checkout\n
OutputCapture().assert_outputs(self, checkout.apply_patch, [mock_patch], expected_stderr=expected_stderr)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106397] trunk/Source/WebCore
Title: [106397] trunk/Source/WebCore Revision 106397 Author ander...@apple.com Date 2012-01-31 14:46:39 -0800 (Tue, 31 Jan 2012) Log Message Put tiles in a HashMap https://bugs.webkit.org/show_bug.cgi?id=77480 Reviewed by Antti Koivisto. Put tiles in a hash map keyed off the tile index. * platform/graphics/ca/mac/TileCache.h: Shuffle member variables around so the order makes more sense. Add the tile map. * platform/graphics/ca/mac/TileCache.mm: (WebCore::TileCache::TileCache): Update member initializers. (WebCore::TileCache::setNeedsDisplayInRect): Call tileLayerAtIndex instead of tileLayerAtPosition. (WebCore::TileCache::setAcceleratesDrawing): (WebCore::TileCache::setTileDebugBorderWidth): (WebCore::TileCache::setTileDebugBorderColor): Iterate over the hash map instead of the sublayers. (WebCore::TileCache::resizeTileGrid): Add the created layers to the map. (WebCore::TileCache::tileLayerAtIndex): Rename from tileLayerAtPoint to better reflect that this member function returns a tile layer at the given index and not the given point. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm Diff Modified: trunk/Source/WebCore/ChangeLog (106396 => 106397) --- trunk/Source/WebCore/ChangeLog 2012-01-31 22:45:22 UTC (rev 106396) +++ trunk/Source/WebCore/ChangeLog 2012-01-31 22:46:39 UTC (rev 106397) @@ -1,3 +1,35 @@ +2012-01-31 Anders Carlsson ander...@apple.com + +Put tiles in a HashMap +https://bugs.webkit.org/show_bug.cgi?id=77480 + +Reviewed by Antti Koivisto. + +Put tiles in a hash map keyed off the tile index. + +* platform/graphics/ca/mac/TileCache.h: +Shuffle member variables around so the order makes more sense. +Add the tile map. + +* platform/graphics/ca/mac/TileCache.mm: +(WebCore::TileCache::TileCache): +Update member initializers. + +(WebCore::TileCache::setNeedsDisplayInRect): +Call tileLayerAtIndex instead of tileLayerAtPosition. + +(WebCore::TileCache::setAcceleratesDrawing): +(WebCore::TileCache::setTileDebugBorderWidth): +(WebCore::TileCache::setTileDebugBorderColor): +Iterate over the hash map instead of the sublayers. + +(WebCore::TileCache::resizeTileGrid): +Add the created layers to the map. + +(WebCore::TileCache::tileLayerAtIndex): +Rename from tileLayerAtPoint to better reflect that this member function +returns a tile layer at the given index and not the given point. + 2012-01-31 Antti Koivisto an...@apple.com Make CSSOM style() return CSSStyleDeclaration* Modified: trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h (106396 => 106397) --- trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h 2012-01-31 22:45:22 UTC (rev 106396) +++ trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h 2012-01-31 22:46:39 UTC (rev 106397) @@ -26,7 +26,9 @@ #ifndef TileCache_h #define TileCache_h +#include IntPointHash.h #include IntSize.h +#include wtf/HashMap.h #include wtf/Noncopyable.h #include wtf/PassOwnPtr.h #include wtf/RetainPtr.h @@ -66,6 +68,8 @@ void setTileDebugBorderColor(CGColorRef); private: +typedef IntPoint TileIndex; + TileCache(WebTileCacheLayer*, const IntSize tileSize); FloatRect visibleRect() const; @@ -76,23 +80,25 @@ IntSize numTilesForGridSize(const IntSize) const; void resizeTileGrid(const IntSize numTiles); -WebTileLayer* tileLayerAtPosition(const IntPoint) const; +WebTileLayer* tileLayerAtIndex(const TileIndex) const; RetainPtrWebTileLayer createTileLayer(); bool shouldShowRepaintCounters() const; WebTileCacheLayer* m_tileCacheLayer; +RetainPtrCALayer m_tileContainerLayer; const IntSize m_tileSize; -RetainPtrCALayer m_tileContainerLayer; - -RetainPtrCGColorRef m_tileDebugBorderColor; -float m_tileDebugBorderWidth; - // Number of tiles in each dimension. IntSize m_numTilesInGrid; +typedef HashMapTileIndex, RetainPtrWebTileLayer TileMap; +TileMap m_tiles; + bool m_acceleratesDrawing; + +RetainPtrCGColorRef m_tileDebugBorderColor; +float m_tileDebugBorderWidth; }; } // namespace WebCore Modified: trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm (106396 => 106397) --- trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm 2012-01-31 22:45:22 UTC (rev 106396) +++ trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm 2012-01-31 22:46:39 UTC (rev 106397) @@ -50,10 +50,10 @@ TileCache::TileCache(WebTileCacheLayer* tileCacheLayer, const IntSize tileSize) : m_tileCacheLayer(tileCacheLayer) +, m_tileContainerLayer(adoptCF([[CALayer alloc] init])) , m_tileSize(tileSize) -, m_tileContainerLayer(adoptCF([[CALayer alloc] init])) +, m_acceleratesDrawing(false) ,
[webkit-changes] [106399] trunk/Source/WebKit/chromium
Title: [106399] trunk/Source/WebKit/chromium Revision 106399 Author nd...@chromium.org Date 2012-01-31 14:57:20 -0800 (Tue, 31 Jan 2012) Log Message [chromium] Import PaintAggregator https://bugs.webkit.org/show_bug.cgi?id=53715 Reviewed by Darin Fisher. * WebKit.gyp: * WebKit.gypi: * src/painting/PaintAggregator.cpp: Added. (WebKit::calculateArea): (WebKit::subtractIntersection): (WebKit::sharesEdge): (WebKit::PaintAggregator::PendingUpdate::PendingUpdate): (WebKit::PaintAggregator::PendingUpdate::~PendingUpdate): (WebKit::PaintAggregator::PendingUpdate::calculateScrollDamage): (WebKit::PaintAggregator::PendingUpdate::calculatePaintBounds): (WebKit::PaintAggregator::hasPendingUpdate): (WebKit::PaintAggregator::clearPendingUpdate): (WebKit::PaintAggregator::popPendingUpdate): (WebKit::PaintAggregator::invalidateRect): (WebKit::PaintAggregator::scrollRect): (WebKit::PaintAggregator::scrollPaintRect): (WebKit::PaintAggregator::shouldInvalidateScrollRect): (WebKit::PaintAggregator::invalidateScrollRect): (WebKit::PaintAggregator::combinePaintRects): * src/painting/PaintAggregator.h: Added. * tests/PaintAggregatorTest.cpp: Added. (WebKit::TEST): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/WebKit.gypi Added Paths trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp trunk/Source/WebKit/chromium/src/painting/PaintAggregator.h trunk/Source/WebKit/chromium/tests/PaintAggregatorTest.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (106398 => 106399) --- trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 22:55:00 UTC (rev 106398) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 22:57:20 UTC (rev 106399) @@ -1,3 +1,33 @@ +2012-01-31 Nat Duca nd...@chromium.org + +[chromium] Import PaintAggregator +https://bugs.webkit.org/show_bug.cgi?id=53715 + +Reviewed by Darin Fisher. + +* WebKit.gyp: +* WebKit.gypi: +* src/painting/PaintAggregator.cpp: Added. +(WebKit::calculateArea): +(WebKit::subtractIntersection): +(WebKit::sharesEdge): +(WebKit::PaintAggregator::PendingUpdate::PendingUpdate): +(WebKit::PaintAggregator::PendingUpdate::~PendingUpdate): +(WebKit::PaintAggregator::PendingUpdate::calculateScrollDamage): +(WebKit::PaintAggregator::PendingUpdate::calculatePaintBounds): +(WebKit::PaintAggregator::hasPendingUpdate): +(WebKit::PaintAggregator::clearPendingUpdate): +(WebKit::PaintAggregator::popPendingUpdate): +(WebKit::PaintAggregator::invalidateRect): +(WebKit::PaintAggregator::scrollRect): +(WebKit::PaintAggregator::scrollPaintRect): +(WebKit::PaintAggregator::shouldInvalidateScrollRect): +(WebKit::PaintAggregator::invalidateScrollRect): +(WebKit::PaintAggregator::combinePaintRects): +* src/painting/PaintAggregator.h: Added. +* tests/PaintAggregatorTest.cpp: Added. +(WebKit::TEST): + 2012-01-31 Fady Samuel fsam...@chromium.org [Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called in Google News Modified: trunk/Source/WebKit/chromium/WebKit.gyp (106398 => 106399) --- trunk/Source/WebKit/chromium/WebKit.gyp 2012-01-31 22:55:00 UTC (rev 106398) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-01-31 22:57:20 UTC (rev 106399) @@ -445,6 +445,8 @@ 'src/NotificationPresenterImpl.h', 'src/NotificationPresenterImpl.cpp', 'src/painting/GraphicsContextBuilder.h', +'src/painting/PaintAggregator.h', +'src/painting/PaintAggregator.cpp', 'src/PageOverlay.cpp', 'src/PageOverlay.h', 'src/PageOverlayList.cpp', Modified: trunk/Source/WebKit/chromium/WebKit.gypi (106398 => 106399) --- trunk/Source/WebKit/chromium/WebKit.gypi 2012-01-31 22:55:00 UTC (rev 106398) +++ trunk/Source/WebKit/chromium/WebKit.gypi 2012-01-31 22:57:20 UTC (rev 106399) @@ -101,6 +101,7 @@ 'tests/KURLTest.cpp', 'tests/LayerChromiumTest.cpp', 'tests/LayerTextureUpdaterTest.cpp', +'tests/PaintAggregatorTest.cpp', 'tests/PODArenaTest.cpp', 'tests/PODIntervalTreeTest.cpp', 'tests/PODRedBlackTreeTest.cpp', Added: trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp (0 => 106399) --- trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp (rev 0) +++ trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp 2012-01-31 22:57:20 UTC (rev 106399) @@ -0,0 +1,374 @@ +/* + * Copyright (C) 2011 Google Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are + * met: + * + * * Redistributions of source code must retain the
[webkit-changes] [106401] trunk/Source/WebKit/chromium
Title: [106401] trunk/Source/WebKit/chromium
Revision 106401
Author tha...@chromium.org
Date 2012-01-31 15:02:14 -0800 (Tue, 31 Jan 2012)
Log Message
[chromium] Expose windowResizerRectChanged() on WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=77453
Needed for http://crbug.com/111266
Reviewed by Darin Fisher.
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::didChangeWindowResizerRect):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::didChangeWindowResizerRect):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106400 => 106401)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 22:58:23 UTC (rev 106400)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 23:02:14 UTC (rev 106401)
@@ -1,3 +1,21 @@
+2012-01-31 Nico Weber tha...@chromium.org
+
+[chromium] Expose windowResizerRectChanged() on WebWidget.
+https://bugs.webkit.org/show_bug.cgi?id=77453
+
+Needed for http://crbug.com/111266
+
+Reviewed by Darin Fisher.
+
+* public/WebWidget.h:
+(WebWidget):
+(WebKit::WebWidget::didChangeWindowResizerRect):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::didChangeWindowResizerRect):
+(WebKit):
+* src/WebViewImpl.h:
+(WebViewImpl):
+
2012-01-31 Nat Duca nd...@chromium.org
[chromium] Import PaintAggregator
Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (106400 => 106401)
--- trunk/Source/WebKit/chromium/public/WebWidget.h 2012-01-31 22:58:23 UTC (rev 106400)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h 2012-01-31 23:02:14 UTC (rev 106401)
@@ -181,6 +181,12 @@
// reasons such as the user exiting lock, window focus changing, etc.
virtual void didLosePointerLock() { }
+// Informs the WebWidget that the resizer rect changed. Happens for example
+// on mac, when a widget appears below the WebWidget without changing the
+// WebWidget's size (WebWidget::resize() automatically checks the resizer
+// rect.)
+virtual void didChangeWindowResizerRect() { }
+
protected:
~WebWidget() { }
};
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (106400 => 106401)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-01-31 22:58:23 UTC (rev 106400)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-01-31 23:02:14 UTC (rev 106401)
@@ -1776,6 +1776,12 @@
#endif
}
+void WebViewImpl::didChangeWindowResizerRect()
+{
+if (mainFrameImpl()-frameView())
+mainFrameImpl()-frameView()-windowResizerRectChanged();
+}
+
// WebView
WebSettings* WebViewImpl::settings()
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (106400 => 106401)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2012-01-31 22:58:23 UTC (rev 106400)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2012-01-31 23:02:14 UTC (rev 106401)
@@ -132,6 +132,7 @@
virtual void didAcquirePointerLock();
virtual void didNotAcquirePointerLock();
virtual void didLosePointerLock();
+virtual void didChangeWindowResizerRect();
// WebView methods:
virtual void initializeMainFrame(WebFrameClient*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106402] trunk/Source/WebKit/qt
Title: [106402] trunk/Source/WebKit/qt
Revision 106402
Author an...@apple.com
Date 2012-01-31 15:07:49 -0800 (Tue, 31 Jan 2012)
Log Message
Try to fix Qt build.
Not reviewed.
* Api/qwebelement.cpp:
(QWebElement::styleProperty):
Modified Paths
trunk/Source/WebKit/qt/Api/qwebelement.cpp
trunk/Source/WebKit/qt/ChangeLog
Diff
Modified: trunk/Source/WebKit/qt/Api/qwebelement.cpp (106401 => 106402)
--- trunk/Source/WebKit/qt/Api/qwebelement.cpp 2012-01-31 23:02:14 UTC (rev 106401)
+++ trunk/Source/WebKit/qt/Api/qwebelement.cpp 2012-01-31 23:07:49 UTC (rev 106402)
@@ -866,11 +866,11 @@
for (int i = rules-length(); i 0; --i) {
CSSStyleRule* rule = static_castCSSStyleRule*(rules-item(i - 1));
-if (rule-style()-getPropertyPriority(propID))
-return rule-style()-getPropertyValue(propID);
+if (rule-declaration()-getPropertyPriority(propID))
+return rule-declaration()-getPropertyValue(propID);
if (style-getPropertyValue(propID).isEmpty())
-style = rule-style();
+style = rule-declaration();
}
}
Modified: trunk/Source/WebKit/qt/ChangeLog (106401 => 106402)
--- trunk/Source/WebKit/qt/ChangeLog 2012-01-31 23:02:14 UTC (rev 106401)
+++ trunk/Source/WebKit/qt/ChangeLog 2012-01-31 23:07:49 UTC (rev 106402)
@@ -1,3 +1,12 @@
+2012-01-31 Antti Koivisto an...@apple.com
+
+Try to fix Qt build.
+
+Not reviewed.
+
+* Api/qwebelement.cpp:
+(QWebElement::styleProperty):
+
2012-01-30 Antti Koivisto an...@apple.com
Reduce non-CSSOM API of CSSStyleDeclaration
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106403] trunk/LayoutTests
Title: [106403] trunk/LayoutTests Revision 106403 Author kbal...@webkit.org Date 2012-01-31 15:09:51 -0800 (Tue, 31 Jan 2012) Log Message [Qt][WK2] bot lacks mobility https://bugs.webkit.org/show_bug.cgi?id=68243 Unreviewed gardening. Removing tests from skipped list. These tests are no longer failing since the Qt5 tree we use includes the required modules that used to live in mobility. * platform/qt-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (106402 => 106403) --- trunk/LayoutTests/ChangeLog 2012-01-31 23:07:49 UTC (rev 106402) +++ trunk/LayoutTests/ChangeLog 2012-01-31 23:09:51 UTC (rev 106403) @@ -1,3 +1,15 @@ +2012-01-31 Balazs Kelemen kbal...@webkit.org + +[Qt][WK2] bot lacks mobility +https://bugs.webkit.org/show_bug.cgi?id=68243 + +Unreviewed gardening. +Removing tests from skipped list. These tests are no +longer failing since the Qt5 tree we use includes +the required modules that used to live in mobility. + +* platform/qt-wk2/Skipped: + 2012-01-31 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r106376. Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (106402 => 106403) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-31 23:07:49 UTC (rev 106402) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-31 23:09:51 UTC (rev 106403) @@ -266,20 +266,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=67607 fast/inline/absolute-positioned-inline-in-centred-block.html -# [Qt][WK2] bot lucks mobility -# https://bugs.webkit.org/show_bug.cgi?id=68243 -fast/dom/DeviceMotion/create-event.html -fast/dom/DeviceMotion/optional-event-properties.html -fast/dom/DeviceMotion/window-property.html -fast/dom/DeviceOrientation/create-event.html -fast/dom/DeviceOrientation/optional-event-properties.html -fast/dom/DeviceOrientation/window-property.html -fast/dom/Geolocation/enabled.html -fast/dom/Geolocation/not-enough-arguments.html -fast/dom/Orientation/create-event-orientationchange.html -fast/dom/Window/window-properties-device-orientation.html -fast/dom/Window/window-properties-geolocation.html - # New editing tests introduced in r95335, r95337 and r95645 fail on Qt-WK2 platform editing/deleting/merge-paragraph-from-address.html editing/deleting/merge-paragraph-from-h6-with-style.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106405] trunk/LayoutTests
Title: [106405] trunk/LayoutTests
Revision 106405
Author jsb...@chromium.org
Date 2012-01-31 15:17:25 -0800 (Tue, 31 Jan 2012)
Log Message
IndexedDB: Re-enable structured-clone test
https://bugs.webkit.org/show_bug.cgi?id=77239
This test was landed disabled, since it was failing. Turns out Date serialization
differs (PST vs. Pacific Standard Time) across machines, so debug statements
in the test were removed.
Reviewed by Tony Chang.
* platform/chromium/test_expectations.txt:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/storage/indexeddb/structured-clone-expected.txt
trunk/LayoutTests/storage/indexeddb/structured-clone.html
Diff
Modified: trunk/LayoutTests/ChangeLog (106404 => 106405)
--- trunk/LayoutTests/ChangeLog 2012-01-31 23:11:13 UTC (rev 106404)
+++ trunk/LayoutTests/ChangeLog 2012-01-31 23:17:25 UTC (rev 106405)
@@ -1,3 +1,18 @@
+2012-01-31 Joshua Bell jsb...@chromium.org
+
+IndexedDB: Re-enable structured-clone test
+https://bugs.webkit.org/show_bug.cgi?id=77239
+
+This test was landed disabled, since it was failing. Turns out Date serialization
+differs (PST vs. Pacific Standard Time) across machines, so debug statements
+in the test were removed.
+
+Reviewed by Tony Chang.
+
+* platform/chromium/test_expectations.txt:
+* storage/indexeddb/structured-clone-expected.txt:
+* storage/indexeddb/structured-clone.html:
+
2012-01-31 Balazs Kelemen kbal...@webkit.org
[Qt][WK2] bot lacks mobility
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106404 => 106405)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-31 23:11:13 UTC (rev 106404)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-31 23:17:25 UTC (rev 106405)
@@ -4037,8 +4037,6 @@
BUGWK77315 WIN MAC : fast/events/touch/touch-gesture-scroll.html = PASS TEXT
BUGWK77324 WIN MAC DEBUG SLOW : fast/js/dfg-int32array.html = PASS
-BUGWK77239 : storage/indexeddb/structured-clone.html = PASS TEXT
-
BUGWK77397 : plugins/crash-restoring-plugin-page-from-page-cache.html = TIMEOUT TEXT
BUGWK77412 LEOPARD : media/media-blocked-by-beforeload.html = TEXT
BUGWK77416 LINUX : inspector/timeline/timeline-receive-response-event.html = PASS TEXT
Modified: trunk/LayoutTests/storage/indexeddb/structured-clone-expected.txt (106404 => 106405)
--- trunk/LayoutTests/storage/indexeddb/structured-clone-expected.txt 2012-01-31 23:11:13 UTC (rev 106404)
+++ trunk/LayoutTests/storage/indexeddb/structured-clone-expected.txt 2012-01-31 23:17:25 UTC (rev 106405)
@@ -22,7 +22,6 @@
Testing: undefined
transaction = db.transaction('storeName', IDBTransaction.READ_WRITE)
store = transaction.objectStore('storeName')
-value is: undefined (type: undefined)
store.put(value, 'key')
store.get('key')
PASS is(test_data, result) is true
@@ -31,7 +30,6 @@
Testing: null
transaction = db.transaction('storeName', IDBTransaction.READ_WRITE)
store = transaction.objectStore('storeName')
-value is: null (type: object)
store.put(value, 'key')
store.get('key')
PASS is(test_data, result) is true
@@ -42,7 +40,6 @@
Testing: true
transaction = db.transaction('storeName', IDBTransaction.READ_WRITE)
store = transaction.objectStore('storeName')
-value is: true (type: boolean)
store.put(value, 'key')
store.get('key')
PASS is(test_data, result) is true
@@ -50,7 +47,6 @@
Testing: false
transaction = db.transaction('storeName', IDBTransaction.READ_WRITE)
store = transaction.objectStore('storeName')
-value is: false (type: boolean)
store.put(value, 'key')
store.get('key')
PASS is(test_data, result) is true
@@ -61,7 +57,6 @@
Testing: NaN
transaction = db.transaction('storeName', IDBTransaction.READ_WRITE)
store = transaction.objectStore('storeName')
-value is: NaN (type: number)
store.put(value, 'key')
store.get('key')
PASS is(test_data, result) is true
@@ -69,7 +64,6 @@
Testing: -Infinity
transaction = db.transaction('storeName', IDBTransaction.READ_WRITE)
store = transaction.objectStore('storeName')
-value is: -Infinity (type: number)
store.put(value, 'key')
store.get('key')
PASS is(test_data, result) is true
@@ -77,7 +71,6 @@
Testing: -Number.MAX_VALUE
transaction = db.transaction('storeName', IDBTransaction.READ_WRITE)
store = transaction.objectStore('storeName')
-value is: -1.7976931348623157e+308 (type: number)
store.put(value, 'key')
store.get('key')
PASS is(test_data, result) is true
@@ -85,7 +78,6 @@
Testing: -Number.MIN_VALUE
transaction = db.transaction('storeName', IDBTransaction.READ_WRITE)
store = transaction.objectStore('storeName')
-value is: -5e-324 (type: number)
store.put(value, 'key')
store.get('key')
PASS is(test_data, result) is true
@@ -93,7 +85,6 @@
Testing: -0
transaction = db.transaction('storeName',
[webkit-changes] [106406] trunk/Source/WebCore
Title: [106406] trunk/Source/WebCore Revision 106406 Author commit-qu...@webkit.org Date 2012-01-31 15:20:32 -0800 (Tue, 31 Jan 2012) Log Message [chromium] Compositor debug borders are not scaled correctly https://bugs.webkit.org/show_bug.cgi?id=77468 Use CCLayerImpl::contentBounds() instead of CCLayerImpl::bounds() to calculate debug border geometry so that the borders are properly scaled. Patch by Sami Kyostila skyos...@chromium.org on 2012-01-31 Reviewed by James Robinson. * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::appendDebugBorderQuad): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (106405 => 106406) --- trunk/Source/WebCore/ChangeLog 2012-01-31 23:17:25 UTC (rev 106405) +++ trunk/Source/WebCore/ChangeLog 2012-01-31 23:20:32 UTC (rev 106406) @@ -1,3 +1,16 @@ +2012-01-31 Sami Kyostila skyos...@chromium.org + +[chromium] Compositor debug borders are not scaled correctly +https://bugs.webkit.org/show_bug.cgi?id=77468 + +Use CCLayerImpl::contentBounds() instead of CCLayerImpl::bounds() to calculate debug +border geometry so that the borders are properly scaled. + +Reviewed by James Robinson. + +* platform/graphics/chromium/cc/CCLayerImpl.cpp: +(WebCore::CCLayerImpl::appendDebugBorderQuad): + 2012-01-31 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r106376. Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp (106405 => 106406) --- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp 2012-01-31 23:17:25 UTC (rev 106405) +++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp 2012-01-31 23:20:32 UTC (rev 106406) @@ -170,7 +170,7 @@ if (!hasDebugBorders()) return; -IntRect layerRect(IntPoint(), bounds()); +IntRect layerRect(IntPoint(), contentBounds()); quadList.append(CCDebugBorderDrawQuad::create(sharedQuadState, layerRect, debugBorderColor(), debugBorderWidth())); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106408] trunk/Source/WebCore
Title: [106408] trunk/Source/WebCore
Revision 106408
Author commit-qu...@webkit.org
Date 2012-01-31 15:36:06 -0800 (Tue, 31 Jan 2012)
Log Message
Add contains() test to Region
https://bugs.webkit.org/show_bug.cgi?id=72294
Patch by Dana Jansens dan...@chromium.org on 2012-01-31
Reviewed by Anders Carlsson.
* platform/graphics/Region.cpp:
(WebCore::Region::contains):
(WebCore):
* platform/graphics/Region.h:
(Region):
(Shape):
(WebCore::operator==):
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Region.cpp
trunk/Source/WebCore/platform/graphics/Region.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (106407 => 106408)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 23:24:55 UTC (rev 106407)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 23:36:06 UTC (rev 106408)
@@ -1,3 +1,19 @@
+2012-01-31 Dana Jansens dan...@chromium.org
+
+Add contains() test to Region
+https://bugs.webkit.org/show_bug.cgi?id=72294
+
+Reviewed by Anders Carlsson.
+
+* platform/graphics/Region.cpp:
+(WebCore::Region::contains):
+(WebCore):
+* platform/graphics/Region.h:
+(Region):
+(Shape):
+(WebCore::operator==):
+(WebCore):
+
2012-01-31 Sami Kyostila skyos...@chromium.org
[chromium] Compositor debug borders are not scaled correctly
Modified: trunk/Source/WebCore/platform/graphics/Region.cpp (106407 => 106408)
--- trunk/Source/WebCore/platform/graphics/Region.cpp 2012-01-31 23:24:55 UTC (rev 106407)
+++ trunk/Source/WebCore/platform/graphics/Region.cpp 2012-01-31 23:36:06 UTC (rev 106408)
@@ -65,6 +65,11 @@
return rects;
}
+bool Region::contains(const Region region) const
+{
+return WebCore::intersect(region, *this) == region;
+}
+
Region::Shape::Shape()
{
}
Modified: trunk/Source/WebCore/platform/graphics/Region.h (106407 => 106408)
--- trunk/Source/WebCore/platform/graphics/Region.h 2012-01-31 23:24:55 UTC (rev 106407)
+++ trunk/Source/WebCore/platform/graphics/Region.h 2012-01-31 23:36:06 UTC (rev 106408)
@@ -47,6 +47,9 @@
void translate(const IntSize);
+// Returns true if the query region is a subset of this region.
+bool contains(const Region) const;
+
#ifndef NDEBUG
void dump() const;
#endif
@@ -104,13 +107,18 @@
bool canCoalesce(SegmentIterator begin, SegmentIterator end);
-// FIXME: These vectors should have inline sizes. Figure out a good optimal value.
-Vectorint m_segments;
-VectorSpan m_spans;
+Vectorint, 32 m_segments;
+VectorSpan, 16 m_spans;
+
+friend bool operator==(const Shape, const Shape);
};
IntRect m_bounds;
Shape m_shape;
+
+friend bool operator==(const Region, const Region);
+friend bool operator==(const Shape, const Shape);
+friend bool operator==(const Span, const Span);
};
static inline Region intersect(const Region a, const Region b)
@@ -137,6 +145,21 @@
return result;
}
+inline bool operator==(const Region a, const Region b)
+{
+return a.m_bounds == b.m_bounds a.m_shape == b.m_shape;
+}
+
+inline bool operator==(const Region::Shape a, const Region::Shape b)
+{
+return a.m_spans == b.m_spans a.m_segments == b.m_segments;
+}
+
+inline bool operator==(const Region::Span a, const Region::Span b)
+{
+return a.y == b.y a.segmentIndex == b.segmentIndex;
+}
+
} // namespace WebCore
#endif // Region_h
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106410] trunk/Source/WebKit/chromium
Title: [106410] trunk/Source/WebKit/chromium
Revision 106410
Author commit-qu...@webkit.org
Date 2012-01-31 15:55:39 -0800 (Tue, 31 Jan 2012)
Log Message
[chromium] enable -Wexit-time-destructors for webkit unit tests
https://bugs.webkit.org/show_bug.cgi?id=77300
Fix the only extant violation (verified by building webkit_unit_tests in static build).
Patch by Ami Fischman fisch...@chromium.org on 2012-01-31
Reviewed by Tony Chang.
* WebKitUnitTests.gyp:
* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::defaultWebFrameClient):
(WebKit::FrameTestHelpers::defaultWebViewClient):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKitUnitTests.gyp
trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106409 => 106410)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 23:49:32 UTC (rev 106409)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 23:55:39 UTC (rev 106410)
@@ -1,3 +1,16 @@
+2012-01-31 Ami Fischman fisch...@chromium.org
+
+[chromium] enable -Wexit-time-destructors for webkit unit tests
+https://bugs.webkit.org/show_bug.cgi?id=77300
+Fix the only extant violation (verified by building webkit_unit_tests in static build).
+
+Reviewed by Tony Chang.
+
+* WebKitUnitTests.gyp:
+* tests/FrameTestHelpers.cpp:
+(WebKit::FrameTestHelpers::defaultWebFrameClient):
+(WebKit::FrameTestHelpers::defaultWebViewClient):
+
2012-01-31 Nico Weber tha...@chromium.org
[chromium] Expose windowResizerRectChanged() on WebWidget.
Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (106409 => 106410)
--- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-01-31 23:49:32 UTC (rev 106409)
+++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-01-31 23:55:39 UTC (rev 106410)
@@ -51,6 +51,7 @@
{
'target_name': 'webkit_unit_tests',
'type': 'executable',
+'variables': { 'enable_wexit_time_destructors': 1, },
'msvs_guid': '7CEFE800-8403-418A-AD6A-2D52C6FC3EAD',
'dependencies': [
'WebKit.gyp:webkit',
Modified: trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp (106409 => 106410)
--- trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp 2012-01-31 23:49:32 UTC (rev 106409)
+++ trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp 2012-01-31 23:55:39 UTC (rev 106410)
@@ -31,6 +31,7 @@
#include config.h
#include FrameTestHelpers.h
+#include StdLibExtras.h
#include WebFrame.h
#include WebFrameClient.h
#include WebSettings.h
@@ -71,7 +72,7 @@
static WebFrameClient* defaultWebFrameClient()
{
-static TestWebFrameClient client;
+DEFINE_STATIC_LOCAL(TestWebFrameClient, client, ());
return client;
}
@@ -80,7 +81,7 @@
static WebViewClient* defaultWebViewClient()
{
-static TestWebViewClient client;
+DEFINE_STATIC_LOCAL(TestWebViewClient, client, ());
return client;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106411] trunk/Source/WebCore
Title: [106411] trunk/Source/WebCore
Revision 106411
Author ander...@apple.com
Date 2012-01-31 15:58:04 -0800 (Tue, 31 Jan 2012)
Log Message
TileCache::setNeedsDisplayInRect cleanup
https://bugs.webkit.org/show_bug.cgi?id=77486
Reviewed by Andreas Kling.
* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setNeedsDisplayInRect):
TileCache::tileLayerAtIndex can in the future return nil, so cope with that. Also, replace
nested if statements with continue statements.
(WebCore::TileCache::getTileIndexRangeForRect):
Rename this to better indicate that it returns a range of indices.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h
trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106410 => 106411)
--- trunk/Source/WebCore/ChangeLog 2012-01-31 23:55:39 UTC (rev 106410)
+++ trunk/Source/WebCore/ChangeLog 2012-01-31 23:58:04 UTC (rev 106411)
@@ -1,3 +1,19 @@
+2012-01-31 Anders Carlsson ander...@apple.com
+
+TileCache::setNeedsDisplayInRect cleanup
+https://bugs.webkit.org/show_bug.cgi?id=77486
+
+Reviewed by Andreas Kling.
+
+* platform/graphics/ca/mac/TileCache.h:
+* platform/graphics/ca/mac/TileCache.mm:
+(WebCore::TileCache::setNeedsDisplayInRect):
+TileCache::tileLayerAtIndex can in the future return nil, so cope with that. Also, replace
+nested if statements with continue statements.
+
+(WebCore::TileCache::getTileIndexRangeForRect):
+Rename this to better indicate that it returns a range of indices.
+
2012-01-31 Dana Jansens dan...@chromium.org
Add contains() test to Region
Modified: trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h (106410 => 106411)
--- trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h 2012-01-31 23:55:39 UTC (rev 106410)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h 2012-01-31 23:58:04 UTC (rev 106411)
@@ -75,7 +75,7 @@
FloatRect visibleRect() const;
IntRect bounds() const;
-void getTileRangeForRect(const IntRect, IntPoint topLeft, IntPoint bottomRight);
+void getTileIndexRangeForRect(const IntRect, TileIndex topLeft, TileIndex bottomRight);
IntSize numTilesForGridSize(const IntSize) const;
void resizeTileGrid(const IntSize numTiles);
Modified: trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm (106410 => 106411)
--- trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm 2012-01-31 23:55:39 UTC (rev 106410)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm 2012-01-31 23:58:04 UTC (rev 106411)
@@ -81,24 +81,26 @@
return;
// Find the tiles that need to be invalidated.
-IntPoint topLeft;
-IntPoint bottomRight;
-getTileRangeForRect(rect, topLeft, bottomRight);
+TileIndex topLeft;
+TileIndex bottomRight;
+getTileIndexRangeForRect(rect, topLeft, bottomRight);
for (int y = topLeft.y(); y = bottomRight.y(); ++y) {
for (int x = topLeft.x(); x = bottomRight.x(); ++x) {
-WebTileLayer* tileLayer = tileLayerAtIndex(IntPoint(x, y));
+WebTileLayer* tileLayer = tileLayerAtIndex(TileIndex(x, y));
+if (!tileLayer)
+continue;
CGRect tileRect = [m_tileCacheLayer convertRect:rect toLayer:tileLayer];
+if (CGRectIsEmpty(tileRect))
+continue;
-if (!CGRectIsEmpty(tileRect)) {
-[tileLayer setNeedsDisplayInRect:tileRect];
+[tileLayer setNeedsDisplayInRect:tileRect];
-if (shouldShowRepaintCounters()) {
-CGRect bounds = [tileLayer bounds];
-CGRect indicatorRect = CGRectMake(bounds.origin.x, bounds.origin.y, 52, 27);
-[tileLayer setNeedsDisplayInRect:indicatorRect];
-}
+if (shouldShowRepaintCounters()) {
+CGRect bounds = [tileLayer bounds];
+CGRect indicatorRect = CGRectMake(bounds.origin.x, bounds.origin.y, 52, 27);
+[tileLayer setNeedsDisplayInRect:indicatorRect];
}
}
}
@@ -217,7 +219,7 @@
return IntRect(IntPoint(), IntSize([m_tileCacheLayer bounds].size));
}
-void TileCache::getTileRangeForRect(const IntRect rect, IntPoint topLeft, IntPoint bottomRight)
+void TileCache::getTileIndexRangeForRect(const IntRect rect, TileIndex topLeft, TileIndex bottomRight)
{
topLeft.setX(max(rect.x() / m_tileSize.width(), 0));
topLeft.setY(max(rect.y() / m_tileSize.height(), 0));
@@ -246,10 +248,10 @@
if (x m_numTilesInGrid.width() y m_numTilesInGrid.height()) {
// We can reuse the tile layer at this index.
-tileLayer = tileLayerAtIndex(IntPoint(x, y));
+tileLayer = tileLayerAtIndex(TileIndex(x, y));
}
[webkit-changes] [106412] trunk/Tools
Title: [106412] trunk/Tools
Revision 106412
Author o...@chromium.org
Date 2012-01-31 16:32:57 -0800 (Tue, 31 Jan 2012)
Log Message
run-webkit-tests calls out to webkit-build-directory twice
https://bugs.webkit.org/show_bug.cgi?id=77248
Reviewed by Dirk Pranke.
* Scripts/webkit-build-directory:
If called with no arguments, print out both the top-level directory and the
configuration directory
* Scripts/webkitpy/layout_tests/port/config.py:
(Config.build_directory):
When called with no arguments, get and cache both the top-level and configuration directories.
* Scripts/webkitpy/layout_tests/port/config_standalone.py:
(main):
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.assert_configuration):
(ConfigTest.test_build_directory.mock_webkit_build_directory):
(ConfigTest.test_build_directory):
(ConfigTest.test_default_configuration__notfound):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._build_path):
Cache the build directory in the options object so that other users
of the options object don't need to call out to webkit-build-directory.
Also, properly support the existing --build-directory argument.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkit-build-directory
trunk/Tools/Scripts/webkitpy/layout_tests/port/config.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/config_standalone.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
Diff
Modified: trunk/Tools/ChangeLog (106411 => 106412)
--- trunk/Tools/ChangeLog 2012-01-31 23:58:04 UTC (rev 106411)
+++ trunk/Tools/ChangeLog 2012-02-01 00:32:57 UTC (rev 106412)
@@ -1,3 +1,31 @@
+2012-01-31 Ojan Vafai o...@chromium.org
+
+run-webkit-tests calls out to webkit-build-directory twice
+https://bugs.webkit.org/show_bug.cgi?id=77248
+
+Reviewed by Dirk Pranke.
+
+* Scripts/webkit-build-directory:
+If called with no arguments, print out both the top-level directory and the
+configuration directory
+
+* Scripts/webkitpy/layout_tests/port/config.py:
+(Config.build_directory):
+When called with no arguments, get and cache both the top-level and configuration directories.
+
+* Scripts/webkitpy/layout_tests/port/config_standalone.py:
+(main):
+* Scripts/webkitpy/layout_tests/port/config_unittest.py:
+(ConfigTest.assert_configuration):
+(ConfigTest.test_build_directory.mock_webkit_build_directory):
+(ConfigTest.test_build_directory):
+(ConfigTest.test_default_configuration__notfound):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitPort._build_path):
+Cache the build directory in the options object so that other users
+of the options object don't need to call out to webkit-build-directory.
+Also, properly support the existing --build-directory argument.
+
2012-01-31 Ryosuke Niwa rn...@webkit.org
Bump up the timeout for performance tests since DOM/DOMTable.html
Modified: trunk/Tools/Scripts/webkit-build-directory (106411 => 106412)
--- trunk/Tools/Scripts/webkit-build-directory 2012-01-31 23:58:04 UTC (rev 106411)
+++ trunk/Tools/Scripts/webkit-build-directory 2012-02-01 00:32:57 UTC (rev 106412)
@@ -57,13 +57,16 @@
'help|h' = \$showHelp,
);
-if (!$getOptionsResult || $showHelp || (!$showConfigurationDirectory !$showTopLevelDirectory)) {
+if (!$getOptionsResult || $showHelp) {
print STDERR $usage;
exit 1;
}
-if ($showTopLevelDirectory) {
+if (!$showConfigurationDirectory !$showTopLevelDirectory) {
print baseProductDir() . \n;
+print productDir() . \n;
+} elsif ($showTopLevelDirectory) {
+print baseProductDir() . \n;
} else {
print productDir() . \n;
}
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/config.py (106411 => 106412)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/config.py 2012-01-31 23:58:04 UTC (rev 106411)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/config.py 2012-02-01 00:32:57 UTC (rev 106412)
@@ -74,13 +74,20 @@
flags = [--configuration, self.flag_for_configuration(configuration)]
else:
configuration =
-flags = [--top-level]
+flags = []
if not self._build_directories.get(configuration):
args = [perl, self.script_path(webkit-build-directory)] + flags
-self._build_directories[configuration] = (
-self._executive.run_command(args, cwd=self.webkit_base_dir()).rstrip())
+output = self._executive.run_command(args, cwd=self.webkit_base_dir()).rstrip()
+parts = output.split(\n)
+self._build_directories[configuration] = parts[0]
+if len(parts) == 2:
+default_configuration = parts[1][len(parts[0]):]
+if default_configuration.startswith(/):
+
[webkit-changes] [106413] trunk/LayoutTests
Title: [106413] trunk/LayoutTests Revision 106413 Author y...@google.com Date 2012-01-31 17:09:25 -0800 (Tue, 31 Jan 2012) Log Message [Chromium] Unreviewed test expectation change. fast/replaced/width100percent-searchfield.html is failing on MAC. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (106412 => 106413) --- trunk/LayoutTests/ChangeLog 2012-02-01 00:32:57 UTC (rev 106412) +++ trunk/LayoutTests/ChangeLog 2012-02-01 01:09:25 UTC (rev 106413) @@ -1,3 +1,10 @@ +2012-01-31 Yuzo Fujishima y...@google.com + +[Chromium] Unreviewed test expectation change. +fast/replaced/width100percent-searchfield.html is failing on MAC. + +* platform/chromium/test_expectations.txt: + 2012-01-31 Oliver Hunt oli...@apple.com Implement Error.stack Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106412 => 106413) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-01 00:32:57 UTC (rev 106412) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-01 01:09:25 UTC (rev 106413) @@ -4044,3 +4044,6 @@ BUGWK77397 : plugins/crash-restoring-plugin-page-from-page-cache.html = TIMEOUT TEXT BUGWK77412 LEOPARD : media/media-blocked-by-beforeload.html = TEXT BUGWK77416 LINUX : inspector/timeline/timeline-receive-response-event.html = PASS TEXT + +// Started failing at WK r106383 or r106384. +BUGWK77494 MAC : fast/replaced/width100percent-searchfield.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106415] trunk
Title: [106415] trunk Revision 106415 Author mdela...@apple.com Date 2012-01-31 17:21:32 -0800 (Tue, 31 Jan 2012) Log Message Failing 2d.shadow.enable.off.2.html on Lion https://bugs.webkit.org/show_bug.cgi?id=77489 Reviewed by Dan Bernstein. Source/WebCore: The canvas spec requires that shadows not be drawn under certain circumstances outlined here: http://www.whatwg.org/specs/web-apps/current-work/#shadows This patch adds in those checks which allows us to pass now (on Lion) the philip canvas test that was checking that constraint. No new tests. Unskipping the test on Lion that this patch fixes. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::shouldDrawShadows): * html/canvas/CanvasRenderingContext2D.h: (CanvasRenderingContext2D): LayoutTests: * platform/mac-lion/Skipped: We can unskip this test now that this patch has us passing this test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-lion/Skipped trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h Diff Modified: trunk/LayoutTests/ChangeLog (106414 => 106415) --- trunk/LayoutTests/ChangeLog 2012-02-01 01:18:38 UTC (rev 106414) +++ trunk/LayoutTests/ChangeLog 2012-02-01 01:21:32 UTC (rev 106415) @@ -1,3 +1,12 @@ +2012-01-31 Matthew Delaney mdela...@apple.com + +Failing 2d.shadow.enable.off.2.html on Lion +https://bugs.webkit.org/show_bug.cgi?id=77489 + +Reviewed by Dan Bernstein. + +* platform/mac-lion/Skipped: We can unskip this test now that this patch has us passing this test. + 2012-01-31 Oliver Hunt oli...@apple.com Remove unneeded sourceId property Modified: trunk/LayoutTests/platform/mac-lion/Skipped (106414 => 106415) --- trunk/LayoutTests/platform/mac-lion/Skipped 2012-02-01 01:18:38 UTC (rev 106414) +++ trunk/LayoutTests/platform/mac-lion/Skipped 2012-02-01 01:21:32 UTC (rev 106415) @@ -1,8 +1,5 @@ # --- Canvas --- -# rdar://problem/9121810 -canvas/philip/tests/2d.shadow.enable.off.2.html - # This test incorrectly checks the shadow blur's distance and needs to be fixed # rdar://problem/9326220 fast/canvas/canvas-scale-shadowBlur.html Modified: trunk/Source/WebCore/ChangeLog (106414 => 106415) --- trunk/Source/WebCore/ChangeLog 2012-02-01 01:18:38 UTC (rev 106414) +++ trunk/Source/WebCore/ChangeLog 2012-02-01 01:21:32 UTC (rev 106415) @@ -1,3 +1,25 @@ +2012-01-31 Matthew Delaney mdela...@apple.com + +Failing 2d.shadow.enable.off.2.html on Lion +https://bugs.webkit.org/show_bug.cgi?id=77489 + +Reviewed by Dan Bernstein. + +The canvas spec requires that shadows not be drawn under certain +circumstances outlined here: http://www.whatwg.org/specs/web-apps/current-work/#shadows +This patch adds in those checks which allows us to pass now (on Lion) +the philip canvas test that was checking that constraint. + +No new tests. Unskipping the test on Lion that this patch fixes. + +* html/canvas/CanvasRenderingContext2D.cpp: +(WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): +(WebCore::CanvasRenderingContext2D::setShadow): +(WebCore::CanvasRenderingContext2D::applyShadow): +(WebCore::CanvasRenderingContext2D::shouldDrawShadows): +* html/canvas/CanvasRenderingContext2D.h: +(CanvasRenderingContext2D): + 2012-01-31 Anders Carlsson ander...@apple.com TileCache::setNeedsDisplayInRect cleanup Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (106414 => 106415) --- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2012-02-01 01:18:38 UTC (rev 106414) +++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2012-02-01 01:21:32 UTC (rev 106415) @@ -315,7 +315,7 @@ if (!context) return; -context-setLegacyShadow(FloatSize(), 0, Color::transparent, ColorSpaceDeviceRGB); +applyShadow(); context-setAlpha(1); context-setCompositeOperation(CompositeSourceOver); } @@ -1150,7 +1150,7 @@ if (!c) return; -c-setLegacyShadow(FloatSize(width, -height), state().m_shadowBlur, state().m_shadowColor, ColorSpaceDeviceRGB); +applyShadow(); } void CanvasRenderingContext2D::setShadow(float width, float height, float blur, const String color, float alpha) @@ -1168,7 +1168,7 @@ if (!c) return; -c-setLegacyShadow(FloatSize(width, -height), state().m_shadowBlur, state().m_shadowColor, ColorSpaceDeviceRGB); +applyShadow(); } void CanvasRenderingContext2D::setShadow(float width, float height, float blur, float grayLevel, float alpha) @@ -1181,7 +1181,7 @@ if (!c) return; -
[webkit-changes] [106416] trunk/Tools
Title: [106416] trunk/Tools Revision 106416 Author dpra...@chromium.org Date 2012-01-31 17:41:35 -0800 (Tue, 31 Jan 2012) Log Message nrwt: fix the mock port to work with DriverProxy, reftests https://bugs.webkit.org/show_bug.cgi?id=77170 Reviewed by Eric Seidel. The DryrunPort used for benchmarking and testing NRWT has been broken since we added the DriverProxy code. It isn't really needed any more, so I've removed it. The MockDRT port was also broken by DriverProxy, and moreover, never worked w/ reftests. Since we don't exercise this module in the unit tests, the code had also bitrotted some. I have cleaned it up and made it use DriverInput and DriverOutput for consistency. * Scripts/webkitpy/layout_tests/port/dryrun.py: (DryRunPort.__init__): (DryRunPort): (DryRunPort.real_name): (DryRunPort.create_driver): (DryRunPort.driver_cmd_line): (DryRunPort._driver_class): (DryrunDriver): (DryrunDriver.run_test): * Scripts/webkitpy/layout_tests/port/mock_drt.py: (MockDRTPort.create_driver): (MockChromiumDRT.run_one_test): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py trunk/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py Removed Paths trunk/Tools/Scripts/webkitpy/layout_tests/port/dryrun.py Diff Modified: trunk/Tools/ChangeLog (106415 => 106416) --- trunk/Tools/ChangeLog 2012-02-01 01:21:32 UTC (rev 106415) +++ trunk/Tools/ChangeLog 2012-02-01 01:41:35 UTC (rev 106416) @@ -1,3 +1,33 @@ +2012-01-31 Dirk Pranke dpra...@chromium.org + +nrwt: fix the mock port to work with DriverProxy, reftests +https://bugs.webkit.org/show_bug.cgi?id=77170 + +Reviewed by Eric Seidel. + +The DryrunPort used for benchmarking and testing NRWT has been +broken since we added the DriverProxy code. It isn't really +needed any more, so I've removed it. + +The MockDRT port was also broken by DriverProxy, and moreover, +never worked w/ reftests. Since we don't exercise this module in +the unit tests, the code had also bitrotted some. I have cleaned +it up and made it use DriverInput and DriverOutput for +consistency. + +* Scripts/webkitpy/layout_tests/port/dryrun.py: +(DryRunPort.__init__): +(DryRunPort): +(DryRunPort.real_name): +(DryRunPort.create_driver): +(DryRunPort.driver_cmd_line): +(DryRunPort._driver_class): +(DryrunDriver): +(DryrunDriver.run_test): +* Scripts/webkitpy/layout_tests/port/mock_drt.py: +(MockDRTPort.create_driver): +(MockChromiumDRT.run_one_test): + 2012-01-31 Ojan Vafai o...@chromium.org run-webkit-tests calls out to webkit-build-directory twice Deleted: trunk/Tools/Scripts/webkitpy/layout_tests/port/dryrun.py (106415 => 106416) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/dryrun.py 2012-02-01 01:21:32 UTC (rev 106415) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/dryrun.py 2012-02-01 01:41:35 UTC (rev 106416) @@ -1,136 +0,0 @@ -#!/usr/bin/env python -# Copyright (C) 2010 Google Inc. All rights reserved. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions are -# met: -# -# * Redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer. -# * Redistributions in binary form must reproduce the above -# copyright notice, this list of conditions and the following disclaimer -# in the documentation and/or other materials provided with the -# distribution. -# * Neither the Google name nor the names of its -# contributors may be used to endorse or promote products derived from -# this software without specific prior written permission. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -# AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR -# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT -# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT -# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, -# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - -This is a test implementation of the Port interface that generates the - correct output for every test. It can be used for perf testing, because - it
[webkit-changes] [106417] trunk/Source/JavaScriptCore
Title: [106417] trunk/Source/_javascript_Core
Revision 106417
Author msab...@apple.com
Date 2012-01-31 17:49:15 -0800 (Tue, 31 Jan 2012)
Log Message
StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase
https://bugs.webkit.org/show_bug.cgi?id=76647
Reviewed by Darin Adler.
Changed stringProtoFuncToUpperCase to call StringImpl::upper() in a manor similar
to stringProtoFuncToLowerCase(). Fixed StringImpl::upper() to handle to special
cases. One case is s-sharp (0xdf) which converts to SS. The other case is
for characters which become 16 bit values when converted to upper case. For
those, we up convert the the source string and use the 16 bit path.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToUpperCase):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):
* wtf/unicode/CharacterNames.h:
(smallLetterSharpS): New constant
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp
trunk/Source/_javascript_Core/wtf/unicode/CharacterNames.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (106416 => 106417)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-01 01:41:35 UTC (rev 106416)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-01 01:49:15 UTC (rev 106417)
@@ -1,3 +1,23 @@
+2012-01-31 Michael Saboff msab...@apple.com
+
+StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase
+https://bugs.webkit.org/show_bug.cgi?id=76647
+
+Reviewed by Darin Adler.
+
+Changed stringProtoFuncToUpperCase to call StringImpl::upper() in a manor similar
+to stringProtoFuncToLowerCase(). Fixed StringImpl::upper() to handle to special
+cases. One case is s-sharp (0xdf) which converts to SS. The other case is
+for characters which become 16 bit values when converted to upper case. For
+those, we up convert the the source string and use the 16 bit path.
+
+* runtime/StringPrototype.cpp:
+(JSC::stringProtoFuncToUpperCase):
+* wtf/text/StringImpl.cpp:
+(WTF::StringImpl::upper):
+* wtf/unicode/CharacterNames.h:
+(smallLetterSharpS): New constant
+
2012-01-31 Oliver Hunt oli...@apple.com
Remove unneeded sourceId property
Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (106416 => 106417)
--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2012-02-01 01:41:35 UTC (rev 106416)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2012-02-01 01:49:15 UTC (rev 106417)
@@ -1184,9 +1184,9 @@
if (!sSize)
return JSValue::encode(sVal);
-StringImpl* ourImpl = s.impl();
+StringImpl* ourImpl = s.impl();
RefPtrStringImpl lower = ourImpl-lower();
-if (ourImpl == lower.get())
+if (ourImpl == lower)
return JSValue::encode(sVal);
return JSValue::encode(jsString(exec, UString(lower.release(;
}
@@ -1203,32 +1203,11 @@
if (!sSize)
return JSValue::encode(sVal);
-const UChar* sData = s.characters();
-VectorUChar buffer(sSize);
-
-UChar ored = 0;
-for (int i = 0; i sSize; i++) {
-UChar c = sData[i];
-ored |= c;
-buffer[i] = toASCIIUpper(c);
-}
-if (!(ored ~0x7f))
-return JSValue::encode(jsString(exec, UString::adopt(buffer)));
-
-bool error;
-int length = Unicode::toUpper(buffer.data(), sSize, sData, sSize, error);
-if (error) {
-buffer.resize(length);
-length = Unicode::toUpper(buffer.data(), length, sData, sSize, error);
-if (error)
-return JSValue::encode(sVal);
-}
-if (length == sSize) {
-if (memcmp(buffer.data(), sData, length * sizeof(UChar)) == 0)
-return JSValue::encode(sVal);
-} else
-buffer.resize(length);
-return JSValue::encode(jsString(exec, UString::adopt(buffer)));
+StringImpl* sImpl = s.impl();
+RefPtrStringImpl upper = sImpl-upper();
+if (sImpl == upper)
+return JSValue::encode(sVal);
+return JSValue::encode(jsString(exec, UString(upper.release(;
}
EncodedJSValue JSC_HOST_CALL stringProtoFuncLocaleCompare(ExecState* exec)
Modified: trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp (106416 => 106417)
--- trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp 2012-02-01 01:41:35 UTC (rev 106416)
+++ trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp 2012-02-01 01:49:15 UTC (rev 106417)
@@ -30,7 +30,9 @@
#include StringHash.h
#include wtf/StdLibExtras.h
#include wtf/WTFThreadData.h
+#include wtf/unicode/CharacterNames.h
+
using namespace std;
namespace WTF {
@@ -378,19 +380,53 @@
return newImpl.release();
// Do a slower implementation for cases that include non-ASCII Latin-1 characters.
-for (int32_t i = 0; i length; i++)
-data8[i] =
[webkit-changes] [106418] trunk
Title: [106418] trunk
Revision 106418
Author ad...@chromium.org
Date 2012-01-31 17:54:09 -0800 (Tue, 31 Jan 2012)
Log Message
ProcessingInstruction should not be a ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=75141
Reviewed by Darin Adler.
Source/WebCore:
Per the DOM spec, ProcessingInstruction can't have any children.
And the WebCore behavior already matches the spec by always returning
false for childTypeAllowed(). This change simplifies
ProcessingInstruction's implementation by making it subclass Node
instead of ContainerNode.
Test: fast/dom/processing-instruction-appendChild-exceptions.xhtml
* dom/ContainerNode.cpp: Moved dispatchBeforeLoadEvent up to Node.
* dom/ContainerNode.h:
* dom/Node.cpp:
(WebCore::Node::dispatchBeforeLoadEvent): Moved up from ContainerNode
since it's used both by ProcessingInstruction and various Element
subclasses.
* dom/Node.h:
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::ProcessingInstruction): Call Node constructor.
(WebCore::ProcessingInstruction::insertedIntoDocument): Call Node impl.
(WebCore::ProcessingInstruction::removedFromDocument): ditto.
(WebCore::ProcessingInstruction::finishParsingChildren): ditto.
* dom/ProcessingInstruction.h:
LayoutTests:
* fast/dom/processing-instruction-appendChild-exceptions-expected.txt: Added.
* fast/dom/processing-instruction-appendChild-exceptions.xhtml: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/ProcessingInstruction.cpp
trunk/Source/WebCore/dom/ProcessingInstruction.h
Added Paths
trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions-expected.txt
trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml
Diff
Modified: trunk/LayoutTests/ChangeLog (106417 => 106418)
--- trunk/LayoutTests/ChangeLog 2012-02-01 01:49:15 UTC (rev 106417)
+++ trunk/LayoutTests/ChangeLog 2012-02-01 01:54:09 UTC (rev 106418)
@@ -1,3 +1,13 @@
+2012-01-31 Adam Klein ad...@chromium.org
+
+ProcessingInstruction should not be a ContainerNode
+https://bugs.webkit.org/show_bug.cgi?id=75141
+
+Reviewed by Darin Adler.
+
+* fast/dom/processing-instruction-appendChild-exceptions-expected.txt: Added.
+* fast/dom/processing-instruction-appendChild-exceptions.xhtml: Added.
+
2012-01-31 Matthew Delaney mdela...@apple.com
Failing 2d.shadow.enable.off.2.html on Lion
Added: trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions-expected.txt (0 => 106418)
--- trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions-expected.txt 2012-02-01 01:54:09 UTC (rev 106418)
@@ -0,0 +1,12 @@
+Test that appropriate exceptions are thrown when adding children to a ProcessingInstruction.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS pi.appendChild(null) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
+PASS pi.appendChild(div) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
+PASS pi.appendChild(textNode) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml (0 => 106418)
--- trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml (rev 0)
+++ trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml 2012-02-01 01:54:09 UTC (rev 106418)
@@ -0,0 +1,17 @@
+html xmlns=http://www.w3.org/1999/xhtml
+body
+script src=""
+script
+![CDATA[
+description(Test that appropriate exceptions are thrown when adding children to a ProcessingInstruction.);
+var pi = document.createProcessingInstruction('target', 'data');
+shouldThrow(pi.appendChild(null), 'Error: HIERARCHY_REQUEST_ERR: DOM Exception 3');
+var div = document.createElement('div');
+shouldThrow(pi.appendChild(div), 'Error: HIERARCHY_REQUEST_ERR: DOM Exception 3');
+var textNode = document.createTextNode('sometext');
+shouldThrow(pi.appendChild(textNode), 'Error: HIERARCHY_REQUEST_ERR: DOM Exception 3');
+]]
+/script
+script src=""
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (106417 => 106418)
--- trunk/Source/WebCore/ChangeLog 2012-02-01 01:49:15 UTC (rev 106417)
+++ trunk/Source/WebCore/ChangeLog 2012-02-01 01:54:09 UTC (rev 106418)
@@ -1,3 +1,32 @@
+2012-01-31 Adam Klein ad...@chromium.org
+
+ProcessingInstruction should not be a ContainerNode
+https://bugs.webkit.org/show_bug.cgi?id=75141
+
+Reviewed by Darin Adler.
+
+Per the DOM spec, ProcessingInstruction can't have any children.
+And
[webkit-changes] [106419] trunk/PerformanceTests
Title: [106419] trunk/PerformanceTests Revision 106419 Author rn...@webkit.org Date 2012-01-31 17:55:03 -0800 (Tue, 31 Jan 2012) Log Message Fix Parser/html5-full-render.html after r106379. * Parser/html5-full-render.html: Modified Paths trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/Parser/html5-full-render.html Diff Modified: trunk/PerformanceTests/ChangeLog (106418 => 106419) --- trunk/PerformanceTests/ChangeLog 2012-02-01 01:54:09 UTC (rev 106418) +++ trunk/PerformanceTests/ChangeLog 2012-02-01 01:55:03 UTC (rev 106419) @@ -1,5 +1,11 @@ 2012-01-31 Ryosuke Niwa rn...@webkit.org +Fix Parser/html5-full-render.html after r106379. + +* Parser/html5-full-render.html: + +2012-01-31 Ryosuke Niwa rn...@webkit.org + PerfTestRunner should automatically create pre#log https://bugs.webkit.org/show_bug.cgi?id=77469 Modified: trunk/PerformanceTests/Parser/html5-full-render.html (106418 => 106419) --- trunk/PerformanceTests/Parser/html5-full-render.html 2012-02-01 01:54:09 UTC (rev 106418) +++ trunk/PerformanceTests/Parser/html5-full-render.html 2012-02-01 01:55:03 UTC (rev 106419) @@ -2,7 +2,7 @@ body script src="" script -var spec = loadFile(resources/html5.html); +var spec = PerfTestRunner.loadFile(resources/html5.html); var chunks = []; // The smaller the chunks the more style resolves we do. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106420] trunk/Source/WebCore
Title: [106420] trunk/Source/WebCore
Revision 106420
Author commit-qu...@webkit.org
Date 2012-01-31 19:04:48 -0800 (Tue, 31 Jan 2012)
Log Message
Clean up m_processLock logic in AudioBasicProcessorNode and AudioGainNode
https://bugs.webkit.org/show_bug.cgi?id=76772
Patch by Raymond Liu raymond@intel.com on 2012-01-31
Reviewed by Kenneth Russell.
No new tests required.
* webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::process):
(WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
* webaudio/AudioBasicProcessorNode.h:
* webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::process):
(WebCore::AudioGainNode::checkNumberOfChannelsForInput):
* webaudio/AudioGainNode.h:
(AudioGainNode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.cpp
trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.h
trunk/Source/WebCore/webaudio/AudioGainNode.cpp
trunk/Source/WebCore/webaudio/AudioGainNode.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (106419 => 106420)
--- trunk/Source/WebCore/ChangeLog 2012-02-01 01:55:03 UTC (rev 106419)
+++ trunk/Source/WebCore/ChangeLog 2012-02-01 03:04:48 UTC (rev 106420)
@@ -1,3 +1,22 @@
+2012-01-31 Raymond Liu raymond@intel.com
+
+Clean up m_processLock logic in AudioBasicProcessorNode and AudioGainNode
+https://bugs.webkit.org/show_bug.cgi?id=76772
+
+Reviewed by Kenneth Russell.
+
+No new tests required.
+
+* webaudio/AudioBasicProcessorNode.cpp:
+(WebCore::AudioBasicProcessorNode::process):
+(WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
+* webaudio/AudioBasicProcessorNode.h:
+* webaudio/AudioGainNode.cpp:
+(WebCore::AudioGainNode::process):
+(WebCore::AudioGainNode::checkNumberOfChannelsForInput):
+* webaudio/AudioGainNode.h:
+(AudioGainNode):
+
2012-01-31 Adam Klein ad...@chromium.org
ProcessingInstruction should not be a ContainerNode
Modified: trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.cpp (106419 => 106420)
--- trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.cpp 2012-02-01 01:55:03 UTC (rev 106419)
+++ trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.cpp 2012-02-01 03:04:48 UTC (rev 106420)
@@ -71,24 +71,16 @@
{
AudioBus* destinationBus = output(0)-bus();
-// The realtime thread can't block on this lock, so we call tryLock() instead.
-if (m_processLock.tryLock()) {
-if (!isInitialized() || !processor())
-destinationBus-zero();
-else {
-AudioBus* sourceBus = input(0)-bus();
+if (!isInitialized() || !processor())
+destinationBus-zero();
+else {
+AudioBus* sourceBus = input(0)-bus();
-// FIXME: if we take tail time into account, then we can avoid calling processor()-process() once the tail dies down.
-if (!input(0)-isConnected())
-sourceBus-zero();
-
-processor()-process(sourceBus, destinationBus, framesToProcess);
-}
+// FIXME: if we take tail time into account, then we can avoid calling processor()-process() once the tail dies down.
+if (!input(0)-isConnected())
+sourceBus-zero();
-m_processLock.unlock();
-} else {
-// Too bad - the tryLock() failed. We must be in the middle of re-connecting and were already outputting silence anyway...
-destinationBus-zero();
+processor()-process(sourceBus, destinationBus, framesToProcess);
}
}
@@ -124,8 +116,6 @@
if (isInitialized() numberOfChannels != output(0)-numberOfChannels()) {
// We're already initialized but the channel count has changed.
-// We need to be careful since we may be actively processing right now, so synchronize with process().
-MutexLocker locker(m_processLock);
uninitialize();
}
Modified: trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.h (106419 => 106420)
--- trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.h 2012-02-01 01:55:03 UTC (rev 106419)
+++ trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.h 2012-02-01 03:04:48 UTC (rev 106420)
@@ -57,10 +57,6 @@
protected:
AudioProcessor* processor() { return m_processor.get(); }
OwnPtrAudioProcessor m_processor;
-
-private:
-// This synchronizes live channel count changes which require an uninitialization / re-initialization.
-mutable Mutex m_processLock;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/webaudio/AudioGainNode.cpp (106419 => 106420)
--- trunk/Source/WebCore/webaudio/AudioGainNode.cpp 2012-02-01 01:55:03 UTC (rev 106419)
+++ trunk/Source/WebCore/webaudio/AudioGainNode.cpp 2012-02-01 03:04:48 UTC (rev 106420)
@@ -59,31 +59,23 @@
AudioBus* outputBus = output(0)-bus();
ASSERT(outputBus);
-// The realtime thread can't block on this lock,
[webkit-changes] [106423] trunk/Source/WebCore
Title: [106423] trunk/Source/WebCore
Revision 106423
Author commit-qu...@webkit.org
Date 2012-01-31 19:23:12 -0800 (Tue, 31 Jan 2012)
Log Message
Dynamic allocate AudioBus with required number of channels for AudioNodeInput
https://bugs.webkit.org/show_bug.cgi?id=76516
Patch by Raymond Liu raymond@intel.com on 2012-01-31
Reviewed by Kenneth Russell.
No new tests required.
* webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
* webaudio/AudioChannelMerger.cpp:
(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput):
* webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::checkNumberOfChannelsForInput):
* webaudio/AudioNode.cpp:
(WebCore::AudioNode::checkNumberOfChannelsForInput):
* webaudio/AudioNode.h:
* webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):
(WebCore::AudioNodeInput::internalSummingBus):
* webaudio/AudioNodeInput.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.cpp
trunk/Source/WebCore/webaudio/AudioChannelMerger.cpp
trunk/Source/WebCore/webaudio/AudioGainNode.cpp
trunk/Source/WebCore/webaudio/AudioNode.cpp
trunk/Source/WebCore/webaudio/AudioNode.h
trunk/Source/WebCore/webaudio/AudioNodeInput.cpp
trunk/Source/WebCore/webaudio/AudioNodeInput.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (106422 => 106423)
--- trunk/Source/WebCore/ChangeLog 2012-02-01 03:21:24 UTC (rev 106422)
+++ trunk/Source/WebCore/ChangeLog 2012-02-01 03:23:12 UTC (rev 106423)
@@ -1,3 +1,27 @@
+2012-01-31 Raymond Liu raymond@intel.com
+
+Dynamic allocate AudioBus with required number of channels for AudioNodeInput
+https://bugs.webkit.org/show_bug.cgi?id=76516
+
+Reviewed by Kenneth Russell.
+
+No new tests required.
+
+* webaudio/AudioBasicProcessorNode.cpp:
+(WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
+* webaudio/AudioChannelMerger.cpp:
+(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput):
+* webaudio/AudioGainNode.cpp:
+(WebCore::AudioGainNode::checkNumberOfChannelsForInput):
+* webaudio/AudioNode.cpp:
+(WebCore::AudioNode::checkNumberOfChannelsForInput):
+* webaudio/AudioNode.h:
+* webaudio/AudioNodeInput.cpp:
+(WebCore::AudioNodeInput::AudioNodeInput):
+(WebCore::AudioNodeInput::updateInternalBus):
+(WebCore::AudioNodeInput::internalSummingBus):
+* webaudio/AudioNodeInput.h:
+
2012-01-31 Alexey Proskuryakov a...@apple.com
REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
Modified: trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.cpp (106422 => 106423)
--- trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.cpp 2012-02-01 03:21:24 UTC (rev 106422)
+++ trunk/Source/WebCore/webaudio/AudioBasicProcessorNode.cpp 2012-02-01 03:23:12 UTC (rev 106423)
@@ -127,6 +127,8 @@
processor()-setNumberOfChannels(numberOfChannels);
initialize();
}
+
+AudioNode::checkNumberOfChannelsForInput(input);
}
unsigned AudioBasicProcessorNode::numberOfChannels()
Modified: trunk/Source/WebCore/webaudio/AudioChannelMerger.cpp (106422 => 106423)
--- trunk/Source/WebCore/webaudio/AudioChannelMerger.cpp 2012-02-01 03:21:24 UTC (rev 106422)
+++ trunk/Source/WebCore/webaudio/AudioChannelMerger.cpp 2012-02-01 03:23:12 UTC (rev 106423)
@@ -89,7 +89,7 @@
// Any time a connection or disconnection happens on any of our inputs, we potentially need to change the
// number of channels of our output.
-void AudioChannelMerger::checkNumberOfChannelsForInput(AudioNodeInput*)
+void AudioChannelMerger::checkNumberOfChannelsForInput(AudioNodeInput* input)
{
ASSERT(context()-isAudioThread() context()-isGraphOwner());
@@ -105,6 +105,8 @@
AudioNodeOutput* output = this-output(0);
ASSERT(output);
output-setNumberOfChannels(numberOfOutputChannels);
+
+AudioNode::checkNumberOfChannelsForInput(input);
}
} // namespace WebCore
Modified: trunk/Source/WebCore/webaudio/AudioGainNode.cpp (106422 => 106423)
--- trunk/Source/WebCore/webaudio/AudioGainNode.cpp 2012-02-01 03:21:24 UTC (rev 106422)
+++ trunk/Source/WebCore/webaudio/AudioGainNode.cpp 2012-02-01 03:23:12 UTC (rev 106423)
@@ -110,6 +110,8 @@
output(0)-setNumberOfChannels(numberOfChannels);
initialize();
}
+
+AudioNode::checkNumberOfChannelsForInput(input);
}
} // namespace WebCore
Modified: trunk/Source/WebCore/webaudio/AudioNode.cpp (106422 => 106423)
--- trunk/Source/WebCore/webaudio/AudioNode.cpp 2012-02-01 03:21:24 UTC (rev 106422)
+++ trunk/Source/WebCore/webaudio/AudioNode.cpp 2012-02-01 03:23:12 UTC (rev 106423)
@@ -182,6 +182,17 @@
}
}
+void AudioNode::checkNumberOfChannelsForInput(AudioNodeInput* input)
+{
+ASSERT(context()-isAudioThread() context()-isGraphOwner());
+
[webkit-changes] [106424] trunk/Source/WebKit/efl
Title: [106424] trunk/Source/WebKit/efl
Revision 106424
Author commit-qu...@webkit.org
Date 2012-01-31 19:38:27 -0800 (Tue, 31 Jan 2012)
Log Message
[EFL] Set content hint information for ewk_view_single.
https://bugs.webkit.org/show_bug.cgi?id=77319
Patch by KwangHyuk Kim hyuki@samsung.com on 2012-01-31
Reviewed by Ryosuke Niwa.
The content hint information corresponding to opengl_x11 engine is set
for the image object which ewk_view_single owns when evas is based on
opengl_x11 engine.
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_backing_store_add):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (106423 => 106424)
--- trunk/Source/WebKit/efl/ChangeLog 2012-02-01 03:23:12 UTC (rev 106423)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-02-01 03:38:27 UTC (rev 106424)
@@ -1,3 +1,17 @@
+2012-01-31 KwangHyuk Kim hyuki@samsung.com
+
+[EFL] Set content hint information for ewk_view_single.
+https://bugs.webkit.org/show_bug.cgi?id=77319
+
+Reviewed by Ryosuke Niwa.
+
+The content hint information corresponding to opengl_x11 engine is set
+for the image object which ewk_view_single owns when evas is based on
+opengl_x11 engine.
+
+* ewk/ewk_view_single.cpp:
+(_ewk_view_single_smart_backing_store_add):
+
2012-01-30 Eunsol Park eunsol47.p...@samsung.com
[EFL] Define the names of view smart class
Modified: trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp (106423 => 106424)
--- trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp 2012-02-01 03:23:12 UTC (rev 106423)
+++ trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp 2012-02-01 03:38:27 UTC (rev 106424)
@@ -25,6 +25,7 @@
#include ewk_logging.h
#include ewk_private.h
+#include Ecore_Evas.h
#include Evas.h
#include eina_safety_checks.h
#include string.h
@@ -57,6 +58,12 @@
static Evas_Object* _ewk_view_single_smart_backing_store_add(Ewk_View_Smart_Data* smartData)
{
Evas_Object* bs = evas_object_image_add(smartData-base.evas);
+EINA_SAFETY_ON_NULL_RETURN_VAL(bs, 0);
+const Ecore_Evas* ecoreEvas = ecore_evas_ecore_evas_get(smartData-base.evas);
+const char* engine = ecore_evas_engine_name_get(ecoreEvas);
+if (!strncmp(engine, opengl_x11, strlen(opengl_x11)))
+evas_object_image_content_hint_set(bs, EVAS_IMAGE_CONTENT_HINT_DYNAMIC);
+
evas_object_image_alpha_set(bs, false);
evas_object_image_smooth_scale_set(bs, smartData-zoom_weak_smooth_scale);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106426] trunk
Title: [106426] trunk Revision 106426 Author aba...@webkit.org Date 2012-01-31 20:07:52 -0800 (Tue, 31 Jan 2012) Log Message HTMLPreloadScanner should understand the base element https://bugs.webkit.org/show_bug.cgi?id=77231 Reviewed by Eric Seidel. Source/WebCore: Previously, the HTMLPreloadScanner would ignore the base element when preloading resources. If there was a base tag, this could cause the preload scanner to make a bunch of useless requests. This patch teaches the preload scanner to use base tags to better predict which URLs will be used by the document. Tests: fast/preloader/first-base-tag-scanned-wins.html fast/preloader/first-base-tag-wins.html fast/preloader/understands-base-tag.html * dom/Document.cpp: (WebCore::Document::completeURL): (WebCore): * dom/Document.h: (Document): (WebCore::Document::baseElementURL): * html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::PreloadTask): (WebCore::HTMLNames::PreloadTask::processAttributes): (WebCore::HTMLNames::PreloadTask::preload): (WebCore::HTMLNames::PreloadTask::baseElementHref): (PreloadTask): (WebCore::HTMLPreloadScanner::scan): (WebCore::HTMLPreloadScanner::processToken): (WebCore::HTMLPreloadScanner::updatePredictedBaseElementURL): (WebCore): * html/parser/HTMLPreloadScanner.h: (HTMLPreloadScanner): LayoutTests: These tests ensure that we understand the base element and that we understand that the first base element is the one that maters. * fast/preloader/first-base-tag-scanned-wins-expected.txt: Added. * fast/preloader/first-base-tag-scanned-wins.html: Added. * fast/preloader/first-base-tag-wins-expected.txt: Added. * fast/preloader/first-base-tag-wins.html: Added. * fast/preloader/resources/base-image1.png: Copied from LayoutTests/fast/preloader/resources/image1.png. * fast/preloader/resources/base-image2.png: Copied from LayoutTests/fast/preloader/resources/image1.png. * fast/preloader/resources/base-image3.png: Copied from LayoutTests/fast/preloader/resources/image1.png. * fast/preloader/understands-base-tag-expected.txt: Added. * fast/preloader/understands-base-tag.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp trunk/Source/WebCore/html/parser/HTMLPreloadScanner.h Added Paths trunk/LayoutTests/fast/preloader/first-base-tag-scanned-wins-expected.txt trunk/LayoutTests/fast/preloader/first-base-tag-scanned-wins.html trunk/LayoutTests/fast/preloader/first-base-tag-wins-expected.txt trunk/LayoutTests/fast/preloader/first-base-tag-wins.html trunk/LayoutTests/fast/preloader/resources/base-image1.png trunk/LayoutTests/fast/preloader/resources/base-image2.png trunk/LayoutTests/fast/preloader/resources/base-image3.png trunk/LayoutTests/fast/preloader/understands-base-tag-expected.txt trunk/LayoutTests/fast/preloader/understands-base-tag.html Diff Modified: trunk/LayoutTests/ChangeLog (106425 => 106426) --- trunk/LayoutTests/ChangeLog 2012-02-01 03:51:23 UTC (rev 106425) +++ trunk/LayoutTests/ChangeLog 2012-02-01 04:07:52 UTC (rev 106426) @@ -1,3 +1,23 @@ +2012-01-31 Adam Barth aba...@webkit.org + +HTMLPreloadScanner should understand the base element +https://bugs.webkit.org/show_bug.cgi?id=77231 + +Reviewed by Eric Seidel. + +These tests ensure that we understand the base element and that we +understand that the first base element is the one that maters. + +* fast/preloader/first-base-tag-scanned-wins-expected.txt: Added. +* fast/preloader/first-base-tag-scanned-wins.html: Added. +* fast/preloader/first-base-tag-wins-expected.txt: Added. +* fast/preloader/first-base-tag-wins.html: Added. +* fast/preloader/resources/base-image1.png: Copied from LayoutTests/fast/preloader/resources/image1.png. +* fast/preloader/resources/base-image2.png: Copied from LayoutTests/fast/preloader/resources/image1.png. +* fast/preloader/resources/base-image3.png: Copied from LayoutTests/fast/preloader/resources/image1.png. +* fast/preloader/understands-base-tag-expected.txt: Added. +* fast/preloader/understands-base-tag.html: Added. + 2012-01-31 Adam Klein ad...@chromium.org ProcessingInstruction should not be a ContainerNode Added: trunk/LayoutTests/fast/preloader/first-base-tag-scanned-wins-expected.txt (0 => 106426) --- trunk/LayoutTests/fast/preloader/first-base-tag-scanned-wins-expected.txt (rev 0) +++ trunk/LayoutTests/fast/preloader/first-base-tag-scanned-wins-expected.txt 2012-02-01 04:07:52 UTC (rev 106426) @@ -0,0 +1,7 @@ +base-image3.png has MIME type image/png +This test requires DumpRenderTree to see the log of what resources are loaded. + +base href="" +base href="" +img src="" + Added: trunk/LayoutTests/fast/preloader/first-base-tag-scanned-wins.html (0 => 106426) ---
[webkit-changes] [106428] trunk/LayoutTests
Title: [106428] trunk/LayoutTests Revision 106428 Author y...@google.com Date 2012-01-31 21:19:38 -0800 (Tue, 31 Jan 2012) Log Message [Chromium] Unreviewed test expectation change. LayoutTest platform/mac/fast/events/non-roman-key-code.html crashes at r106422. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (106427 => 106428) --- trunk/LayoutTests/ChangeLog 2012-02-01 04:31:26 UTC (rev 106427) +++ trunk/LayoutTests/ChangeLog 2012-02-01 05:19:38 UTC (rev 106428) @@ -1,3 +1,10 @@ +2012-01-31 Yuzo Fujishima y...@google.com + +[Chromium] Unreviewed test expectation change. +LayoutTest platform/mac/fast/events/non-roman-key-code.html crashes at r106422. + +* platform/chromium/test_expectations.txt: + 2012-01-31 Adam Barth aba...@webkit.org HTMLPreloadScanner should understand the base element Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106427 => 106428) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-01 04:31:26 UTC (rev 106427) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-01 05:19:38 UTC (rev 106428) @@ -4047,3 +4047,6 @@ // Started failing at WK r106383 or r106384. BUGWK77494 MAC : fast/replaced/width100percent-searchfield.html = IMAGE + +// Started crashing at WK r106422. +BUGWK77508 SKIP : platform/mac/fast/events/non-roman-key-code.html = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106429] trunk/Source/JavaScriptCore
Title: [106429] trunk/Source/_javascript_Core Revision 106429 Author gga...@apple.com Date 2012-01-31 21:25:09 -0800 (Tue, 31 Jan 2012) Log Message Stop using -fomit-frame-pointer https://bugs.webkit.org/show_bug.cgi?id=77403 Reviewed by Filip Pizlo. _javascript_Core is too fast. I'm just the man to fix it. * Configurations/_javascript_Core.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (106428 => 106429) --- trunk/Source/_javascript_Core/ChangeLog 2012-02-01 05:19:38 UTC (rev 106428) +++ trunk/Source/_javascript_Core/ChangeLog 2012-02-01 05:25:09 UTC (rev 106429) @@ -1,3 +1,14 @@ +2012-01-31 Geoffrey Garen gga...@apple.com + +Stop using -fomit-frame-pointer +https://bugs.webkit.org/show_bug.cgi?id=77403 + +Reviewed by Filip Pizlo. + +_javascript_Core is too fast. I'm just the man to fix it. + +* Configurations/_javascript_Core.xcconfig: + 2012-01-31 Michael Saboff msab...@apple.com StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (106428 => 106429) --- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2012-02-01 05:19:38 UTC (rev 106428) +++ trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2012-02-01 05:25:09 UTC (rev 106429) @@ -48,7 +48,3 @@ INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR); DYLIB_INSTALL_NAME_BASE = $(NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR); PRODUCT_NAME = _javascript_Core; - -OTHER_CFLAGS = $(OTHER_CFLAGS_$(CONFIGURATION)_$(CURRENT_VARIANT)); -OTHER_CFLAGS_Release_normal = -fomit-frame-pointer -funwind-tables; -OTHER_CFLAGS_Production_normal = $(OTHER_CFLAGS_Release_normal); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106430] trunk
Title: [106430] trunk
Revision 106430
Author commit-qu...@webkit.org
Date 2012-01-31 21:37:49 -0800 (Tue, 31 Jan 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=76801
Listboxes incorrectly display contents when cleared and then re-populated.
Whenever the number of items in the listbox is less than the size of listbox (number of visible items the listbox can accomodate),
we set the listbox scroll-offset to zero. The scroll-offset of the Scrollbar should also be set to 0 so that when the listbox is re-populated,
scrollbar position and the content inside the listbox are in sync.
Source/WebCore:
Patch by Joe Thomas joetho...@motorola.com on 2012-01-31
Reviewed by Andreas Kling.
Tests: fast/forms/listbox-clear-restore.html
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computeLogicalHeight): Setting the scroll-offset of the Scrollbar to 0 when scrollbar is not needed.
LayoutTests:
Added test case.
Patch by Joe Thomas joetho...@motorola.com on 2012-01-31
Reviewed by Andreas Kling.
* fast/forms/listbox-clear-restore-expected.html: Added.
* fast/forms/listbox-clear-restore.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListBox.cpp
Added Paths
trunk/LayoutTests/fast/forms/listbox-clear-restore-expected.html
trunk/LayoutTests/fast/forms/listbox-clear-restore.html
Diff
Modified: trunk/LayoutTests/ChangeLog (106429 => 106430)
--- trunk/LayoutTests/ChangeLog 2012-02-01 05:25:09 UTC (rev 106429)
+++ trunk/LayoutTests/ChangeLog 2012-02-01 05:37:49 UTC (rev 106430)
@@ -1,3 +1,19 @@
+2012-01-31 Joe Thomas joetho...@motorola.com
+
+https://bugs.webkit.org/show_bug.cgi?id=76801
+Listboxes incorrectly display contents when cleared and then re-populated.
+
+Whenever the number of items in the listbox is less than the size of listbox (number of visible items the listbox can accomodate),
+we set the listbox scroll-offset to zero. The scroll-offset of the Scrollbar should also be set to 0 so that when the listbox is re-populated,
+scrollbar position and the content inside the listbox are in sync.
+
+Added test case.
+
+Reviewed by Andreas Kling.
+
+* fast/forms/listbox-clear-restore-expected.html: Added.
+* fast/forms/listbox-clear-restore.html: Added.
+
2012-01-31 Yuzo Fujishima y...@google.com
[Chromium] Unreviewed test expectation change.
Added: trunk/LayoutTests/fast/forms/listbox-clear-restore-expected.html (0 => 106430)
--- trunk/LayoutTests/fast/forms/listbox-clear-restore-expected.html (rev 0)
+++ trunk/LayoutTests/fast/forms/listbox-clear-restore-expected.html 2012-02-01 05:37:49 UTC (rev 106430)
@@ -0,0 +1,25 @@
+!DOCTYPE
+html
+body _onload_=test()
+select id=myList size=10 multiple/select
+script
+function populateList()
+{
+var myList = document.getElementById(myList);
+var item;
+
+for (var ii = 0; ii 20; ii++) {
+item = document.createElement(option);
+item.value = ii;
+item.appendChild(document.createTextNode(Item # + ii));
+myList.appendChild(item);
+}
+}
+
+function test()
+{
+populateList();
+}
+/script
+/body
+/html
Added: trunk/LayoutTests/fast/forms/listbox-clear-restore.html (0 => 106430)
--- trunk/LayoutTests/fast/forms/listbox-clear-restore.html (rev 0)
+++ trunk/LayoutTests/fast/forms/listbox-clear-restore.html 2012-02-01 05:37:49 UTC (rev 106430)
@@ -0,0 +1,54 @@
+!DOCTYPE
+html
+body _onload_=test()
+select id=myList size=10 multiple/select
+script
+function populateList()
+{
+var myList = document.getElementById(myList);
+var item;
+
+for (var ii = 0; ii 20; ii++) {
+item = document.createElement(option);
+item.value = ii;
+item.appendChild(document.createTextNode(Item # + ii));
+myList.appendChild(item);
+}
+}
+
+function clearList()
+{
+var myList = document.getElementById(myList);
+var items = myList.getElementsByTagName(option);
+
+for (var ii = items.length-1; ii = 0; ii--) {
+myList.removeChild(items[ii]);
+}
+}
+
+function populateListTimeout()
+{
+populateList();
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+function clearListTimeout()
+{
+clearList();
+setTimeout(populateListTimeout, 0);
+}
+
+function test()
+{
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+populateList();
+document.getElementById(myList).selectedIndex = 19;
+window.setTimeout(clearListTimeout, 0);
+}
+
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (106429 => 106430)
--- trunk/Source/WebCore/ChangeLog 2012-02-01 05:25:09 UTC (rev 106429)
+++ trunk/Source/WebCore/ChangeLog 2012-02-01 05:37:49 UTC (rev 106430)
@@ -1,3 +1,19 @@
+2012-01-31 Joe Thomas joetho...@motorola.com
+
+
[webkit-changes] [106432] trunk
Title: [106432] trunk
Revision 106432
Author commit-qu...@webkit.org
Date 2012-01-31 22:39:11 -0800 (Tue, 31 Jan 2012)
Log Message
Content element should be able to be dynamically added/removed/replaced in a shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=76611
Patch by Shinya Kawanaka shin...@google.com on 2012-01-31
Reviewed by Hajime Morita.
Source/WebCore:
When a content element is added/removed/replaced in a shadow tree, we have to recreate
the shadow tree to recalculate inclusions of content elements. Currently we didn't recalculate it
when content element is removed. (When added, it is recalculated.)
This patch enables us to recalcurate the shadow tree when content element is removed.
Test: fast/dom/shadow/content-element-move.html
* dom/Element.cpp:
(WebCore::Element::attach):
If a shadow root exists, attaches shadow tree before attaching child elements.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcShadowTreeStyle):
Recalculates light children and shadow tree.
(WebCore::ShadowRoot::reattachHostChildrenAndShadow):
Detaches shadow tree and host light children, and attaches them again.
* dom/ShadowRoot.h:
Added a flag to recalculate shadow tree.
(WebCore::ShadowRoot::setNeedsShadowTreeStyleRecalc):
(WebCore::ShadowRoot::clearNeedsShadowTreeStyleRecalc):
(WebCore::ShadowRoot::needsShadowTreeStyleRecalc):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
Does not need to detach included elements, because they are not attached in ContainerNode anymore.
(WebCore::HTMLContentElement::detach):
When a content element detached, reattaches a shadow tree.
LayoutTests:
Test cases for appending/removing/replacing content element in a shadow tree.
* fast/dom/shadow/content-element-move-expected.txt: Added.
* fast/dom/shadow/content-element-move.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/dom/ShadowRoot.h
trunk/Source/WebCore/html/shadow/HTMLContentElement.cpp
Added Paths
trunk/LayoutTests/fast/dom/shadow/content-element-move-expected.txt
trunk/LayoutTests/fast/dom/shadow/content-element-move.html
Diff
Modified: trunk/LayoutTests/ChangeLog (106431 => 106432)
--- trunk/LayoutTests/ChangeLog 2012-02-01 05:46:30 UTC (rev 106431)
+++ trunk/LayoutTests/ChangeLog 2012-02-01 06:39:11 UTC (rev 106432)
@@ -1,3 +1,15 @@
+2012-01-31 Shinya Kawanaka shin...@google.com
+
+Content element should be able to be dynamically added/removed/replaced in a shadow tree.
+https://bugs.webkit.org/show_bug.cgi?id=76611
+
+Reviewed by Hajime Morita.
+
+Test cases for appending/removing/replacing content element in a shadow tree.
+
+* fast/dom/shadow/content-element-move-expected.txt: Added.
+* fast/dom/shadow/content-element-move.html: Added.
+
2012-01-31 Ryuan Choi ryuan.c...@samsung.com
[EFL] Add basic DRT/Efl implementation to support viewport test.
Added: trunk/LayoutTests/fast/dom/shadow/content-element-move-expected.txt (0 => 106432)
--- trunk/LayoutTests/fast/dom/shadow/content-element-move-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-move-expected.txt 2012-02-01 06:39:11 UTC (rev 106432)
@@ -0,0 +1,24 @@
+testRemoveContent
+PASS
+testRemoveContentToRecalc1
+PASS
+testRemoveContentToRecalc2
+PASS
+testRemoveContentAndRemoveLightChildren
+PASS
+testRemoveContentAndRemoveShadowRoot1
+PASS
+testRemoveContentAndRemoveShadowRoot2
+PASS
+testAppendContent1
+PASS
+testAppendContent2
+PASS
+testAppendContent3
+PASS
+testChangeOrderOfContent
+PASS
+testMoveLightChildOut
+PASS
+TEST COMPLETED
+
Added: trunk/LayoutTests/fast/dom/shadow/content-element-move.html (0 => 106432)
--- trunk/LayoutTests/fast/dom/shadow/content-element-move.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-move.html 2012-02-01 06:39:11 UTC (rev 106432)
@@ -0,0 +1,504 @@
+ !DOCTYPE html
+html
+head
+style
+/* relative positioning ensures underlying RenderLayer */
+.container {
+position: relative;
+}
+
+.span {
+display: boxed-inline;
+margin: 2px;
+border: solid;
+}
+/style
+script
+function log(message) {
+document.getElementById('console').innerHTML += (message + \n);
+}
+
+function removeAllChildren(elem) {
+while (elem.firstChild)
+elem.removeChild(elem.firstChild);
+}
+
+function cleanUp() {
+removeAllChildren(document.getElementById('actual-container'));
+removeAllChildren(document.getElementById('expect-container'));
+}
+
+function removeContainerLines(text) {
+var lines = text.split('\n');
+lines.splice(0, 2);
+return lines.join('\n');
+}
+
+function check() {
+var refContainerRenderTree = internals.elementRenderTreeAsText(document.getElementById('expect-container'));
+var refRenderTree =
[webkit-changes] [106433] trunk/Source/JavaScriptCore
Title: [106433] trunk/Source/_javascript_Core
Revision 106433
Author commit-qu...@webkit.org
Date 2012-01-31 22:49:26 -0800 (Tue, 31 Jan 2012)
Log Message
Add missing JS_PRIVATE_EXPORTs
https://bugs.webkit.org/show_bug.cgi?id=77507
Patch by Hajime Morrita morr...@chromium.org on 2012-01-31
Reviewed by Kevin Ollivier.
* heap/MarkedSpace.h:
(MarkedSpace):
* interpreter/Interpreter.h:
(Interpreter):
* runtime/JSValue.h:
(JSValue):
* wtf/text/AtomicString.h:
(WTF::AtomicString::add):
* wtf/text/WTFString.h:
(WTF):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MarkedSpace.h
trunk/Source/_javascript_Core/interpreter/Interpreter.h
trunk/Source/_javascript_Core/runtime/JSValue.h
trunk/Source/_javascript_Core/wtf/text/AtomicString.h
trunk/Source/_javascript_Core/wtf/text/WTFString.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (106432 => 106433)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-01 06:39:11 UTC (rev 106432)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-01 06:49:26 UTC (rev 106433)
@@ -1,3 +1,21 @@
+2012-01-31 Hajime Morrita morr...@chromium.org
+
+Add missing JS_PRIVATE_EXPORTs
+https://bugs.webkit.org/show_bug.cgi?id=77507
+
+Reviewed by Kevin Ollivier.
+
+* heap/MarkedSpace.h:
+(MarkedSpace):
+* interpreter/Interpreter.h:
+(Interpreter):
+* runtime/JSValue.h:
+(JSValue):
+* wtf/text/AtomicString.h:
+(WTF::AtomicString::add):
+* wtf/text/WTFString.h:
+(WTF):
+
2012-01-31 Geoffrey Garen gga...@apple.com
Stop using -fomit-frame-pointer
Modified: trunk/Source/_javascript_Core/heap/MarkedSpace.h (106432 => 106433)
--- trunk/Source/_javascript_Core/heap/MarkedSpace.h 2012-02-01 06:39:11 UTC (rev 106432)
+++ trunk/Source/_javascript_Core/heap/MarkedSpace.h 2012-02-01 06:49:26 UTC (rev 106433)
@@ -87,7 +87,7 @@
void freeBlocks(MarkedBlock* head);
private:
-void* allocateSlowCase(SizeClass);
+JS_EXPORT_PRIVATE void* allocateSlowCase(SizeClass);
void* tryAllocateHelper(MarkedSpace::SizeClass);
void* tryAllocate(MarkedSpace::SizeClass);
MarkedBlock* allocateBlock(size_t, AllocationEffort);
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.h (106432 => 106433)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.h 2012-02-01 06:39:11 UTC (rev 106432)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.h 2012-02-01 06:49:26 UTC (rev 106433)
@@ -206,7 +206,7 @@
NEVER_INLINE HandlerInfo* throwException(CallFrame*, JSValue, unsigned bytecodeOffset);
NEVER_INLINE void debug(CallFrame*, DebugHookID, int firstLine, int lastLine);
static const UString getTraceLine(CallFrame*, StackFrameCodeType, const UString, int);
-static void getStackTrace(JSGlobalData*, int line, VectorStackFrame results);
+JS_EXPORT_PRIVATE static void getStackTrace(JSGlobalData*, int line, VectorStackFrame results);
void dumpSampleData(ExecState* exec);
void startSampling();
Modified: trunk/Source/_javascript_Core/runtime/JSValue.h (106432 => 106433)
--- trunk/Source/_javascript_Core/runtime/JSValue.h 2012-02-01 06:39:11 UTC (rev 106432)
+++ trunk/Source/_javascript_Core/runtime/JSValue.h 2012-02-01 06:49:26 UTC (rev 106433)
@@ -244,7 +244,7 @@
inline const JSValue asValue() const { return *this; }
JS_EXPORT_PRIVATE double toNumberSlowCase(ExecState*) const;
-JSString* toStringSlowCase(ExecState*) const;
+JS_EXPORT_PRIVATE JSString* toStringSlowCase(ExecState*) const;
JS_EXPORT_PRIVATE JSObject* toObjectSlowCase(ExecState*, JSGlobalObject*) const;
JS_EXPORT_PRIVATE JSObject* toThisObjectSlowCase(ExecState*) const;
Modified: trunk/Source/_javascript_Core/wtf/text/AtomicString.h (106432 => 106433)
--- trunk/Source/_javascript_Core/wtf/text/AtomicString.h 2012-02-01 06:39:11 UTC (rev 106432)
+++ trunk/Source/_javascript_Core/wtf/text/AtomicString.h 2012-02-01 06:49:26 UTC (rev 106433)
@@ -127,7 +127,7 @@
ALWAYS_INLINE static PassRefPtrStringImpl add(const char* s, unsigned length) { return add(reinterpret_castconst char*(s), length); };
WTF_EXPORT_PRIVATE static PassRefPtrStringImpl add(const UChar*, unsigned length, unsigned existingHash);
WTF_EXPORT_PRIVATE static PassRefPtrStringImpl add(const UChar*);
-static PassRefPtrStringImpl add(StringImpl*, unsigned offset, unsigned length);
+WTF_EXPORT_PRIVATE static PassRefPtrStringImpl add(StringImpl*, unsigned offset, unsigned length);
ALWAYS_INLINE static PassRefPtrStringImpl add(StringImpl* r)
{
if (!r || r-isAtomic())
Modified: trunk/Source/_javascript_Core/wtf/text/WTFString.h (106432 => 106433)
--- trunk/Source/_javascript_Core/wtf/text/WTFString.h 2012-02-01 06:39:11 UTC (rev 106432)
+++ trunk/Source/_javascript_Core/wtf/text/WTFString.h 2012-02-01 06:49:26 UTC (rev
[webkit-changes] [106435] trunk/Source/WebCore
Title: [106435] trunk/Source/WebCore
Revision 106435
Author kl...@webkit.org
Date 2012-01-31 23:36:21 -0800 (Tue, 31 Jan 2012)
Log Message
Make elements that don't have attributes smaller.
http://webkit.org/b/76876
Reviewed by Sam Weinig and Antti Koivisto.
Move the inline style declaration from StyledElement to ElementAttributeData, since having
an inline style declaration also implies having a style attribute on the element.
This saves one CPU word per element that has no attributes.
This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
HTML5 spec at http://whatwg.org/c.
This was rolled out once because of a performance regression which has been averted this
time around by adding an Element::ensureAttributeMap() so we can force creation of the
NamedNodeMap without also serializing the inline style for the style attribute.
* dom/Element.h:
(Element):
(WebCore::Element::ensureAttributeMap):
(WebCore):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ensureInlineStyleDecl):
(WebCore):
(WebCore::NamedNodeMap::destroyInlineStyleDecl):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::inlineStyleDecl):
(NamedNodeMap):
* dom/StyledElement.cpp:
(WebCore::StyledElement::addSubresourceAttributeURLs):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(StyledElement):
(WebCore::StyledElement::destroyInlineStyleDecl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ElementAttributeData.h
trunk/Source/WebCore/dom/NamedNodeMap.cpp
trunk/Source/WebCore/dom/NamedNodeMap.h
trunk/Source/WebCore/dom/StyledElement.cpp
trunk/Source/WebCore/dom/StyledElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (106434 => 106435)
--- trunk/Source/WebCore/ChangeLog 2012-02-01 06:55:17 UTC (rev 106434)
+++ trunk/Source/WebCore/ChangeLog 2012-02-01 07:36:21 UTC (rev 106435)
@@ -1,3 +1,42 @@
+2012-01-31 Andreas Kling awesomekl...@apple.com
+
+Make elements that don't have attributes smaller.
+http://webkit.org/b/76876
+
+Reviewed by Sam Weinig and Antti Koivisto.
+
+Move the inline style declaration from StyledElement to ElementAttributeData, since having
+an inline style declaration also implies having a style attribute on the element.
+This saves one CPU word per element that has no attributes.
+
+This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
+HTML5 spec at http://whatwg.org/c.
+
+This was rolled out once because of a performance regression which has been averted this
+time around by adding an Element::ensureAttributeMap() so we can force creation of the
+NamedNodeMap without also serializing the inline style for the style attribute.
+
+* dom/Element.h:
+(Element):
+(WebCore::Element::ensureAttributeMap):
+(WebCore):
+* dom/ElementAttributeData.h:
+(ElementAttributeData):
+* dom/NamedNodeMap.cpp:
+(WebCore::NamedNodeMap::ensureInlineStyleDecl):
+(WebCore):
+(WebCore::NamedNodeMap::destroyInlineStyleDecl):
+* dom/NamedNodeMap.h:
+(WebCore::NamedNodeMap::inlineStyleDecl):
+(NamedNodeMap):
+* dom/StyledElement.cpp:
+(WebCore::StyledElement::addSubresourceAttributeURLs):
+* dom/StyledElement.h:
+(WebCore::StyledElement::inlineStyleDecl):
+(WebCore::StyledElement::ensureInlineStyleDecl):
+(StyledElement):
+(WebCore::StyledElement::destroyInlineStyleDecl):
+
2012-01-31 Hayato Ito hay...@chromium.org
Add APIs, getElementsByXXX family, to ShadowRoot IDL.
Modified: trunk/Source/WebCore/dom/Element.h (106434 => 106435)
--- trunk/Source/WebCore/dom/Element.h 2012-02-01 06:55:17 UTC (rev 106434)
+++ trunk/Source/WebCore/dom/Element.h 2012-02-01 07:36:21 UTC (rev 106435)
@@ -223,6 +223,7 @@
void parserSetAttributeMap(PassOwnPtrNamedNodeMap, FragmentScriptingPermission);
NamedNodeMap* attributeMap() const { return m_attributeMap.get(); }
+NamedNodeMap* ensureAttributeMap();
ElementAttributeData* attributeData() const { return m_attributeMap ? m_attributeMap-attributeData() : 0; }
ElementAttributeData* ensureAttributeData() const { return attributes()-attributeData(); }
@@ -597,6 +598,13 @@
setAttribute(document()-idAttributeName(), value);
}
+inline NamedNodeMap* Element::ensureAttributeMap()
+{
+if (!m_attributeMap)
+createAttributeMap();
+return m_attributeMap.get();
+}
+
inline Element* firstElementChild(const ContainerNode* container)
{
ASSERT_ARG(container, container);
Modified: trunk/Source/WebCore/dom/ElementAttributeData.h (106434 => 106435)
--- trunk/Source/WebCore/dom/ElementAttributeData.h 2012-02-01 06:55:17 UTC (rev 106434)
+++
[webkit-changes] [106436] trunk
Title: [106436] trunk
Revision 106436
Author rn...@webkit.org
Date 2012-01-31 23:47:08 -0800 (Tue, 31 Jan 2012)
Log Message
webkit-perf.appspot.com should accept test results without medians
https://bugs.webkit.org/show_bug.cgi?id=77513
Reviewed by Hajime Morita.
Don't store 0s when values are not in JSON.
* Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post._float_or_none):
(ReportHandler.post):
Modified Paths
trunk/ChangeLog
trunk/Websites/webkit-perf.appspot.com/report_handler.py
Diff
Modified: trunk/ChangeLog (106435 => 106436)
--- trunk/ChangeLog 2012-02-01 07:36:21 UTC (rev 106435)
+++ trunk/ChangeLog 2012-02-01 07:47:08 UTC (rev 106436)
@@ -1,3 +1,16 @@
+2012-01-31 Ryosuke Niwa rn...@webkit.org
+
+webkit-perf.appspot.com should accept test results without medians
+https://bugs.webkit.org/show_bug.cgi?id=77513
+
+Reviewed by Hajime Morita.
+
+Don't store 0s when values are not in JSON.
+
+* Websites/webkit-perf.appspot.com/report_handler.py:
+(ReportHandler.post._float_or_none):
+(ReportHandler.post):
+
2012-01-31 Kenneth Rohde Christiansen kenn...@webkit.org
Tap highlighting: Support better outlines for multiline inlines
Modified: trunk/Websites/webkit-perf.appspot.com/report_handler.py (106435 => 106436)
--- trunk/Websites/webkit-perf.appspot.com/report_handler.py 2012-02-01 07:36:21 UTC (rev 106435)
+++ trunk/Websites/webkit-perf.appspot.com/report_handler.py 2012-02-01 07:47:08 UTC (rev 106436)
@@ -86,12 +86,18 @@
if not build:
return
+def _float_or_none(dictionary, key):
+value = dictionary.get(key)
+if value:
+return float(value)
+return None
+
for test_name, result in self._body['results'].iteritems():
test = self._add_test_if_needed(test_name, branch, platform)
memcache.delete(Test.cache_key(test.id, branch.id, platform.id))
if isinstance(result, dict):
-TestResult(name=test_name, build=build, value=float(result.get('avg', 0)), valueMedian=float(result.get('median', 0)),
-valueStdev=float(result.get('stdev', 0)), valueMin=float(result.get('min', 0)), valueMax=float(result.get('max', 0))).put()
+TestResult(name=test_name, build=build, value=float(result['avg']), valueMedian=_float_or_none(result, 'median'),
+valueStdev=_float_or_none(result, 'stdev'), valueMin=_float_or_none(result, 'min'), valueMax=_float_or_none(result, 'max')).put()
else:
TestResult(name=test_name, build=build, value=float(result)).put()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
