[webkit-changes] [112367] trunk/Tools

[ossy]

Title: [112367] trunk/Tools








Revision 112367
Author o...@webkit.org
Date 2012-03-27 23:43:30 -0700 (Tue, 27 Mar 2012)


Log Message
kill-old-processes doesn't do anything on linux
https://bugs.webkit.org/show_bug.cgi?id=82388

Disable kill-old-processes on the Qt bots not to kill each others.

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(Factory.__init__):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (112366 => 112367)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-03-28 06:40:46 UTC (rev 112366)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-03-28 06:43:30 UTC (rev 112367)
@@ -699,7 +699,9 @@
 factory.BuildFactory.__init__(self)
 self.addStep(ConfigureBuild, platform=platform, configuration=configuration, architecture=" ".join(architectures), buildOnly=buildOnly, features=features)
 self.addStep(CheckOutSource)
-self.addStep(KillOldProcesses)
+# There are multiple Qt slaves running on same machines, so buildslaves shouldn't kill the processes of other slaves.
+if platform != "qt":
+self.addStep(KillOldProcesses)
 if platform == "win":
 self.addStep(InstallWin32Dependencies)
 if platform.startswith("chromium"):


Modified: trunk/Tools/ChangeLog (112366 => 112367)

--- trunk/Tools/ChangeLog	2012-03-28 06:40:46 UTC (rev 112366)
+++ trunk/Tools/ChangeLog	2012-03-28 06:43:30 UTC (rev 112367)
@@ -1,3 +1,15 @@
+2012-03-27  Csaba Osztrogonác  
+
+kill-old-processes doesn't do anything on linux
+https://bugs.webkit.org/show_bug.cgi?id=82388
+
+Disable kill-old-processes on the Qt bots not to kill each others.
+
+Reviewed by Ryosuke Niwa.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(Factory.__init__):
+
 2012-03-27  Hao Zheng  
 
 Handle DRT crash caused by Android OOM.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112365] trunk/LayoutTests

[pfeldman]

Title: [112365] trunk/LayoutTests








Revision 112365
Author pfeld...@chromium.org
Date 2012-03-27 23:12:21 -0700 (Tue, 27 Mar 2012)


Log Message
Not reviewed: rebaselined chromium expectations.

* platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.png:
* platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112364 => 112365)

--- trunk/LayoutTests/ChangeLog	2012-03-28 06:08:16 UTC (rev 112364)
+++ trunk/LayoutTests/ChangeLog	2012-03-28 06:12:21 UTC (rev 112365)
@@ -1,3 +1,10 @@
+2012-03-27  Pavel Feldman  
+
+Not reviewed: rebaselined chromium expectations.
+
+* platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.png:
+* platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.txt: Added.
+
 2012-03-27  Dirk Pranke  
 
 More flaky tests!


Modified: trunk/LayoutTests/platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.png

(Binary files differ)


Added: trunk/LayoutTests/platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.txt (0 => 112365)

--- trunk/LayoutTests/platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.txt	2012-03-28 06:12:21 UTC (rev 112365)
@@ -0,0 +1,26 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+  RenderBlock {P} at (0,0) size 784x54
+RenderText {#text} at (0,0) size 775x54
+  text run at (0,0) width 496: "This page ensures that WebKit can render unicode variation selector correctly. "
+  text run at (496,0) width 254: "On platforms which support UVSes, the"
+  text run at (0,18) width 676: "glyphs of U+845B should be different. On platforms which don't support UVSes, they should be identical. "
+  text run at (676,18) width 99: "In addition, any"
+  text run at (0,36) width 579: "glyphs (including the last resort glyph) should not appear after the U+845B on all platforms."
+  RenderBlock {DIV} at (0,70) size 784x24
+RenderText {#text} at (0,3) size 289x18
+  text run at (0,3) width 289: "Glyph for code point U+845B without UVS: "
+RenderInline {SPAN} at (0,0) size 16x18
+  RenderText {#text} at (289,3) size 16x18
+text run at (289,3) width 16: "\x{845B}"
+RenderText {#text} at (0,0) size 0x0
+  RenderBlock {DIV} at (0,94) size 784x24
+RenderText {#text} at (0,3) size 269x18
+  text run at (0,3) width 269: "Glyph for code point U+845B with UVS: "
+RenderInline {SPAN} at (0,0) size 32x18
+  RenderText {#text} at (269,3) size 32x18
+text run at (269,3) width 32: "\x{845B}\x{DB40}\x{DD00}"
+RenderText {#text} at (0,0) size 0x0
Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.txt
___


Added: svn:eol-style




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112363] trunk/Source/WebKit/chromium

[commit-queue]

Title: [112363] trunk/Source/WebKit/chromium








Revision 112363
Author commit-qu...@webkit.org
Date 2012-03-27 21:27:18 -0700 (Tue, 27 Mar 2012)


Log Message
[chromium] Send wheel events to main thread even if we think nothing is scrollable
https://bugs.webkit.org/show_bug.cgi?id=82408

Patch by James Robinson  on 2012-03-27
Reviewed by Adrienne Walker.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (112362 => 112363)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 04:19:05 UTC (rev 112362)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 04:27:18 UTC (rev 112363)
@@ -1,3 +1,13 @@
+2012-03-27  James Robinson  
+
+[chromium] Send wheel events to main thread even if we think nothing is scrollable
+https://bugs.webkit.org/show_bug.cgi?id=82408
+
+Reviewed by Adrienne Walker.
+
+* src/WebCompositorInputHandlerImpl.cpp:
+(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
+
 2012-03-27  Nat Duca  
 
 [chromium] Route monotonic clock up from compositor


Modified: trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp (112362 => 112363)

--- trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2012-03-28 04:19:05 UTC (rev 112362)
+++ trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2012-03-28 04:27:18 UTC (rev 112363)
@@ -188,7 +188,9 @@
 return DidHandle;
 }
 case CCInputHandlerClient::ScrollIgnored:
-return DropEvent;
+// FIXME: This should be DropEvent, but in cases where we fail to properly sync scrollability it's safer to send the
+// event to the main thread. Change back to DropEvent once we have synchronization bugs sorted out.
+return DidNotHandle; 
 case CCInputHandlerClient::ScrollFailed:
 return DidNotHandle;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112362] trunk

[rniwa]

Title: [112362] trunk








Revision 112362
Author rn...@webkit.org
Date 2012-03-27 21:19:05 -0700 (Tue, 27 Mar 2012)


Log Message
Perf-o-matic build fix.

* Websites/webkit-perf.appspot.com/controller.py:
(RunsChartHandler.post):
* Websites/webkit-perf.appspot.com/models.py:
(Runs.chart_params):

Modified Paths

trunk/ChangeLog
trunk/Websites/webkit-perf.appspot.com/controller.py
trunk/Websites/webkit-perf.appspot.com/models.py




Diff

Modified: trunk/ChangeLog (112361 => 112362)

--- trunk/ChangeLog	2012-03-28 03:47:00 UTC (rev 112361)
+++ trunk/ChangeLog	2012-03-28 04:19:05 UTC (rev 112362)
@@ -1,3 +1,12 @@
+2012-03-27  Ryosuke Niwa  
+
+Perf-o-matic build fix.
+
+* Websites/webkit-perf.appspot.com/controller.py:
+(RunsChartHandler.post):
+* Websites/webkit-perf.appspot.com/models.py:
+(Runs.chart_params):
+
 2012-03-27  Dave Tu  
 
 Show image diffs for gpu_tests on flakiness dashboard


Modified: trunk/Websites/webkit-perf.appspot.com/controller.py (112361 => 112362)

--- trunk/Websites/webkit-perf.appspot.com/controller.py	2012-03-28 03:47:00 UTC (rev 112361)
+++ trunk/Websites/webkit-perf.appspot.com/controller.py	2012-03-28 04:19:05 UTC (rev 112362)
@@ -147,6 +147,8 @@
 assert test
 
 params = Runs.update_or_insert(branch, platform, test).chart_params(display_days)
+if not params:
+return
 dashboard_chart_file = urllib.urlopen('http://chart.googleapis.com/chart', urllib.urlencode(params))
 
 DashboardImage.create(branch.id, platform.id, test.id, display_days, dashboard_chart_file.read())


Modified: trunk/Websites/webkit-perf.appspot.com/models.py (112361 => 112362)

--- trunk/Websites/webkit-perf.appspot.com/models.py	2012-03-28 03:47:00 UTC (rev 112361)
+++ trunk/Websites/webkit-perf.appspot.com/models.py	2012-03-28 04:19:05 UTC (rev 112362)
@@ -435,6 +435,9 @@
 chart_data_x.append(timestamp)
 chart_data_y.append(value)
 
+if not chart_data_y:
+return None
+
 dates = [end_time - timedelta(display_days / 7.0 * (7 - i)) for i in range(0, 8)]
 
 y_max = max(chart_data_y) * 1.1






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112361] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [112361] trunk/Source/WebKit/blackberry








Revision 112361
Author commit-qu...@webkit.org
Date 2012-03-27 20:47:00 -0700 (Tue, 27 Mar 2012)


Log Message
[BlackBerry] Text selection - selection gets broken in test.com/individuals.htm
https://bugs.webkit.org/show_bug.cgi?id=82292

Change to check and avoid text selection across frames.

Internal reviewed by Mike Fenton

Patch by Sean Wang  on 2012-03-27
Reviewed by Rob Buis.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
support selection across frames, so check if the *framePoint* is in
the *frame*.
(BlackBerry::WebKit::SelectionHandler::setSelection):
function returns a null VisablePosition, it stands for a invalid position
or a position in the different frames, therefor we don't execute setting
handle's position.

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (112360 => 112361)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-03-28 03:15:57 UTC (rev 112360)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-03-28 03:47:00 UTC (rev 112361)
@@ -1,3 +1,23 @@
+2012-03-27  Sean Wang  
+
+[BlackBerry] Text selection - selection gets broken in test.com/individuals.htm
+https://bugs.webkit.org/show_bug.cgi?id=82292
+
+Change to check and avoid text selection across frames.
+
+Internal reviewed by Mike Fenton
+
+Reviewed by Rob Buis.
+
+* WebKitSupport/SelectionHandler.cpp:
+(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
+support selection across frames, so check if the *framePoint* is in
+the *frame*.
+(BlackBerry::WebKit::SelectionHandler::setSelection):
+function returns a null VisablePosition, it stands for a invalid position
+or a position in the different frames, therefor we don't execute setting
+handle's position.
+
 2012-03-27  Andrew Lo  
 
 [BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (112360 => 112361)

--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2012-03-28 03:15:57 UTC (rev 112360)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2012-03-28 03:47:00 UTC (rev 112361)
@@ -138,7 +138,7 @@
 HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, true /* allowShadowContent */, true /* ignoreClipping */);
 
 Node* node = result.innerNode();
-if (!node)
+if (!node || node->document() != frame.document())
 return VisiblePosition();
 
 RenderObject* renderer = node->renderer();
@@ -450,24 +450,31 @@
 if (!controller->selection().isBaseFirst())
 controller->setSelection(VisibleSelection(controller->selection().start(), controller->selection().end(), true /* isDirectional */));
 
+// We don't return early in the following, so that we can do input field scrolling if the
+// handle is outside the bounds of the field. This can be extended to handle sub-region
+// scrolling as well
 if (startIsValid) {
 relativeStart = DOMSupport::convertPointToFrame(m_webPage->mainFrame(), focusedFrame, start);
 
-// Set the selection with validation.
-newSelection.setBase(visiblePositionForPointIgnoringClipping(*focusedFrame, clipPointToVisibleContainer(start)));
-
-// Reset the selection using the existing extent without validation.
-newSelection.setWithoutValidation(newSelection.base(), controller->selection().end());
+VisiblePosition base = visiblePositionForPointIgnoringClipping(*focusedFrame, clipPointToVisibleContainer(start));
+if (base.isNotNull()) {
+// The function setBase validates the "base"
+newSelection.setBase(base);
+newSelection.setWithoutValidation(newSelection.base(), controller->selection().end());
+// Don't return early.
+}
 }
 
 if (m_lastUpdatedEndPointIsValid) {
 relativeEnd = DOMSupport::convertPointToFrame(m_webPage->mainFrame(), focusedFrame, end);
 
-// Set the selection with validation.
-newSelection.setExtent(visiblePositionForPointIgnoringClipping(*focusedFrame, clipPointToVisibleContainer(end)));
-
-// Reset the selection using the existing base without validation.
-newSelection.setWithoutValidation(controller->selection().start(), newSelection.extent());
+VisiblePosition extent = visiblePositionForPointIgnoringClipping(*focusedFrame, clipPointToVisibleContainer(end));
+if (extent.isNotNull()) {
+// The function setExtent validates the "extent"
+newSelection.setExtent(extent);
+newSelection.setWithoutValidation(controller->select

[webkit-changes] [112360] trunk/Source

[nduca]

Title: [112360] trunk/Source








Revision 112360
Author nd...@chromium.org
Date 2012-03-27 20:15:57 -0700 (Tue, 27 Mar 2012)


Log Message
[chromium] Route monotonic clock up from compositor
https://bugs.webkit.org/show_bug.cgi?id=82154

Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateAnimations):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

* public/WebWidget.h:
(WebKit::WebWidget::animate):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::updateAnimations):
* src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/FakeCCLayerTreeHostClient.h:
(WebCore::FakeCCLayerTreeHostClient::updateAnimations):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebLayerTreeViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebLayerTreeViewImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Source/WebKit/chromium/tests/FakeCCLayerTreeHostClient.h




Diff

Modified: trunk/Source/Platform/ChangeLog (112359 => 112360)

--- trunk/Source/Platform/ChangeLog	2012-03-28 03:05:31 UTC (rev 112359)
+++ trunk/Source/Platform/ChangeLog	2012-03-28 03:15:57 UTC (rev 112360)
@@ -1,3 +1,13 @@
+2012-03-27  Nat Duca  
+
+[chromium] Route monotonic clock up from compositor
+https://bugs.webkit.org/show_bug.cgi?id=82154
+
+Reviewed by James Robinson.
+
+* chromium/public/WebLayerTreeViewClient.h:
+(WebLayerTreeViewClient):
+
 2012-03-26  Nat Duca  
 
 [chromium] Add isInputThrottled/didBecomeReadyForAdditionalInput to WebWidget


Modified: trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h (112359 => 112360)

--- trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h	2012-03-28 03:05:31 UTC (rev 112359)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h	2012-03-28 03:15:57 UTC (rev 112360)
@@ -42,7 +42,7 @@
 
 // Updates animation and layout. These are called before the compositing
 // pass so that layers can be updated at the given frame time.
-virtual void updateAnimations(double frameBeginTime) = 0;
+virtual void updateAnimations(double monotonicFrameBeginTime) = 0;
 virtual void layout() = 0;
 
 // Applies a scroll delta to the root layer, which is bundled with a page


Modified: trunk/Source/WebCore/ChangeLog (112359 => 112360)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 03:05:31 UTC (rev 112359)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 03:15:57 UTC (rev 112360)
@@ -1,3 +1,21 @@
+2012-03-27  Nat Duca  
+
+[chromium] Route monotonic clock up from compositor
+https://bugs.webkit.org/show_bug.cgi?id=82154
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::updateAnimations):
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+(CCLayerTreeHost):
+* platform/graphics/chromium/cc/CCThreadProxy.cpp:
+(WebCore::CCThreadProxy::scheduledActionBeginFrame):
+(WebCore::CCThreadProxy::beginFrame):
+* platform/graphics/chromium/cc/CCThreadProxy.h:
+(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
+(BeginFrameAndCommitState):
+
 2012-03-27  Robin Cao  
 
 [BlackBerry] Upstream LayerAnimation.{cpp, h}


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (112359 => 112360)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2012-03-28 03:05:31 UTC (rev 112359)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2012-03-28 03:15:57 UTC (rev 112360)
@@ -181,11 +181,11 @@
 m_contentsTextureManager->evictAndDeleteAllTextures(allocator);
 }
 
-void CCLayerTreeHost::updateAnimations(double wallClockTime)
+void CCLayerTreeHost::updateAnimations(double monotonicFrameBeg

[webkit-changes] [112359] trunk/Tools

[commit-queue]

Title: [112359] trunk/Tools








Revision 112359
Author commit-qu...@webkit.org
Date 2012-03-27 20:05:31 -0700 (Tue, 27 Mar 2012)


Log Message
Handle DRT crash caused by Android OOM.
https://bugs.webkit.org/show_bug.cgi?id=82310

Patch by Hao Zheng  on 2012-03-27
Reviewed by Tony Chang.

When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
is stopped silently and regarded as crashed. Re-run the test for
such crash.

Add some debug log to NRWT.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
(ChromiumAndroidPort.get_last_stacktrace):
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver._get_drt_return_value):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py




Diff

Modified: trunk/Tools/ChangeLog (112358 => 112359)

--- trunk/Tools/ChangeLog	2012-03-28 02:56:42 UTC (rev 112358)
+++ trunk/Tools/ChangeLog	2012-03-28 03:05:31 UTC (rev 112359)
@@ -1,3 +1,26 @@
+2012-03-27  Hao Zheng  
+
+Handle DRT crash caused by Android OOM.
+https://bugs.webkit.org/show_bug.cgi?id=82310
+
+Reviewed by Tony Chang.
+
+When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
+is stopped silently and regarded as crashed. Re-run the test for
+such crash.
+
+Add some debug log to NRWT.
+
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumDriver.run_test):
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidPort.__init__):
+(ChromiumAndroidPort.get_last_stacktrace):
+(ChromiumAndroidDriver.__init__):
+(ChromiumAndroidDriver._start):
+(ChromiumAndroidDriver.run_test):
+(ChromiumAndroidDriver._get_drt_return_value):
+
 2012-03-27  Ojan Vafai  
 
 Fix expected results for some unittest failures.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (112358 => 112359)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-03-28 02:56:42 UTC (rev 112358)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-03-28 03:05:31 UTC (rev 112359)
@@ -576,6 +576,8 @@
 
 line, crash = self._write_command_and_read_line(input=None)
 
+if crash and line is not None:
+error.append(line)
 run_time = time.time() - start_time
 output_image = self._output_image_with_retry()
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (112358 => 112359)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-03-28 02:56:42 UTC (rev 112358)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-03-28 03:05:31 UTC (rev 112359)
@@ -27,6 +27,9 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import logging
+import re
+import signal
+import time
 
 from webkitpy.layout_tests.port import chromium
 from webkitpy.layout_tests.port import factory
@@ -152,6 +155,7 @@
 adb_args = self.get_option('adb_args')
 if adb_args:
 self._adb_command += shlex.split(adb_args)
+self._drt_retry_after_killed = 0
 
 def default_test_timeout_ms(self):
 # Android platform has less computing power than desktop platforms.
@@ -361,9 +365,10 @@
 
 def get_last_stacktrace(self):
 tombstones = self._run_adb_command(['shell', 'ls', '-n', '/data/tombstones'])
-tombstones = tombstones.rstrip().split('\n')
 if not tombstones:
+_log.error('DRT crashed, but no tombstone found!')
 return ''
+tombstones = tombstones.rstrip().split('\n')
 last_tombstone = tombstones[0].split()
 for tombstone in tombstones[1:]:
 # Format of fields:
@@ -397,6 +402,7 @@
 def __init__(self, port, worker_number, pixel_tests, no_timeout=False):
 chromium.ChromiumDriver.__init__(self, port, worker_number, pixel_tests, no_timeout)
 self._device_image_path = None
+self._drt_return_parser = re.compile('#DRT_RETURN (\d+)')
 
 def _start(self, pixel_tests, per_test_args):
 # Convert the original command line into to two parts:
@@ -440,7 +446,7 @@
 # the process. Sleep 1 second (long enough for debuggerd to dump
 # stack) before exiting the shell to ensure the process has quit,
 # otherwise the exit will fail because "You have stopped jobs".
-drt_cmd = '%s %s 2>%s;sleep 1;exit\n' % (DEVICE_DRT_PATH, ' '.join(drt_args), DEVICE_DRT_STDERR)
+drt_cmd = '%s %s 2>%s;echo "#DRT_RETURN $?";sleep 1;exit\n' % (DEVICE_DRT_PATH, ' '.join(drt_args), DEVICE_DRT_STDERR)
 _log.debug('Starting DumpRenderTree: ' + drt_cmd)
 

[webkit-changes] [112358] trunk/Source/WebCore

[commit-queue]

Title: [112358] trunk/Source/WebCore








Revision 112358
Author commit-qu...@webkit.org
Date 2012-03-27 19:56:42 -0700 (Tue, 27 Mar 2012)


Log Message
[BlackBerry] Upstream LayerAnimation.{cpp, h}
https://bugs.webkit.org/show_bug.cgi?id=80123

Patch by Robin Cao  on 2012-03-27
Reviewed by Rob Buis.

Initial upstream, no new tests.

* platform/graphics/blackberry/LayerAnimation.cpp: Added.
(WebCore):
(WebCore::solveEpsilon):
(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):
(WebCore::timingFunctionForAnimationValue):
(WebCore::progress):
(WebCore::fetchIntervalEndpoints):
(WebCore::LayerAnimation::apply):
(WebCore::LayerAnimation::blendTransform):
(WebCore::LayerAnimation::blendOpacity):
(WebCore::LayerAnimation::validateTransformLists):
* platform/graphics/blackberry/LayerAnimation.h: Added.
(WebCore):
(LayerAnimation):
(WebCore::LayerAnimation::create):
(WebCore::LayerAnimation::clone):
(WebCore::LayerAnimation::~LayerAnimation):
(WebCore::LayerAnimation::name):
(WebCore::LayerAnimation::setStartTime):
(WebCore::LayerAnimation::idFromAnimation):
(WebCore::LayerAnimation::isEqualToAnimation):
(WebCore::LayerAnimation::id):
(WebCore::LayerAnimation::property):
(WebCore::LayerAnimation::boxSize):
(WebCore::LayerAnimation::timeOffset):
(WebCore::LayerAnimation::startTime):
(WebCore::LayerAnimation::valueCount):
(WebCore::LayerAnimation::timingFunction):
(WebCore::LayerAnimation::duration):
(WebCore::LayerAnimation::iterationCount):
(WebCore::LayerAnimation::direction):
(WebCore::LayerAnimation::valueAt):
(WebCore::LayerAnimation::LayerAnimation):

Modified Paths

trunk/Source/WebCore/ChangeLog


Added Paths

trunk/Source/WebCore/platform/graphics/blackberry/LayerAnimation.cpp
trunk/Source/WebCore/platform/graphics/blackberry/LayerAnimation.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112357 => 112358)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 02:42:05 UTC (rev 112357)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 02:56:42 UTC (rev 112358)
@@ -1,3 +1,47 @@
+2012-03-27  Robin Cao  
+
+[BlackBerry] Upstream LayerAnimation.{cpp, h}
+https://bugs.webkit.org/show_bug.cgi?id=80123
+
+Reviewed by Rob Buis.
+
+Initial upstream, no new tests.
+
+* platform/graphics/blackberry/LayerAnimation.cpp: Added.
+(WebCore):
+(WebCore::solveEpsilon):
+(WebCore::solveCubicBezierFunction):
+(WebCore::solveStepsFunction):
+(WebCore::timingFunctionForAnimationValue):
+(WebCore::progress):
+(WebCore::fetchIntervalEndpoints):
+(WebCore::LayerAnimation::apply):
+(WebCore::LayerAnimation::blendTransform):
+(WebCore::LayerAnimation::blendOpacity):
+(WebCore::LayerAnimation::validateTransformLists):
+* platform/graphics/blackberry/LayerAnimation.h: Added.
+(WebCore):
+(LayerAnimation):
+(WebCore::LayerAnimation::create):
+(WebCore::LayerAnimation::clone):
+(WebCore::LayerAnimation::~LayerAnimation):
+(WebCore::LayerAnimation::name):
+(WebCore::LayerAnimation::setStartTime):
+(WebCore::LayerAnimation::idFromAnimation):
+(WebCore::LayerAnimation::isEqualToAnimation):
+(WebCore::LayerAnimation::id):
+(WebCore::LayerAnimation::property):
+(WebCore::LayerAnimation::boxSize):
+(WebCore::LayerAnimation::timeOffset):
+(WebCore::LayerAnimation::startTime):
+(WebCore::LayerAnimation::valueCount):
+(WebCore::LayerAnimation::timingFunction):
+(WebCore::LayerAnimation::duration):
+(WebCore::LayerAnimation::iterationCount):
+(WebCore::LayerAnimation::direction):
+(WebCore::LayerAnimation::valueAt):
+(WebCore::LayerAnimation::LayerAnimation):
+
 2012-03-27  Kenichi Ishibashi  
 
 [Chromium] Uninitialized access in SimpleFontDataSkia::platformInit


Added: trunk/Source/WebCore/platform/graphics/blackberry/LayerAnimation.cpp (0 => 112358)

--- trunk/Source/WebCore/platform/graphics/blackberry/LayerAnimation.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/graphics/blackberry/LayerAnimation.cpp	2012-03-28 02:56:42 UTC (rev 112358)
@@ -0,0 +1,316 @@
+/*
+ * Copyright (C) 2011, 2012 Research In Motion Limited. All rights reserved.
+ * Copyright (C) 2007, 2008, 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
+ * 

[webkit-changes] [112357] trunk/Source/WebCore

[bashi]

Title: [112357] trunk/Source/WebCore








Revision 112357
Author ba...@chromium.org
Date 2012-03-27 19:42:05 -0700 (Tue, 27 Mar 2012)


Log Message
[Chromium] Uninitialized access in SimpleFontDataSkia::platformInit
https://bugs.webkit.org/show_bug.cgi?id=82411

Reviewed by Kent Tamura.

SimpleFontDataSkia::platformInit() could call widthForGlyph(), which
accesses m_zeroWidthSpaceGlyph. This causes a valgrind memcheck error
because m_zeroWidthSpaceGlyph isn't initialized at this point.
Initialize m_zeroWidthSpaceGlyph with zero so that widthForGlyph() can
return appropriate value(The value zero here means "unknown glyph").

No new tests. I manually confirmed this change fixes the valgrind
memcheck error.

* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformInit):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/SimpleFontDataSkia.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112356 => 112357)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 02:29:21 UTC (rev 112356)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 02:42:05 UTC (rev 112357)
@@ -1,3 +1,22 @@
+2012-03-27  Kenichi Ishibashi  
+
+[Chromium] Uninitialized access in SimpleFontDataSkia::platformInit
+https://bugs.webkit.org/show_bug.cgi?id=82411
+
+Reviewed by Kent Tamura.
+
+SimpleFontDataSkia::platformInit() could call widthForGlyph(), which
+accesses m_zeroWidthSpaceGlyph. This causes a valgrind memcheck error
+because m_zeroWidthSpaceGlyph isn't initialized at this point.
+Initialize m_zeroWidthSpaceGlyph with zero so that widthForGlyph() can
+return appropriate value(The value zero here means "unknown glyph").
+
+No new tests. I manually confirmed this change fixes the valgrind
+memcheck error.
+
+* platform/graphics/skia/SimpleFontDataSkia.cpp:
+(WebCore::SimpleFontData::platformInit):
+
 2012-03-27  YoungTaeck Song  
 
 [EFL][WK2] Add RunLoopEfl and WorkQueueEfl


Modified: trunk/Source/WebCore/platform/graphics/skia/SimpleFontDataSkia.cpp (112356 => 112357)

--- trunk/Source/WebCore/platform/graphics/skia/SimpleFontDataSkia.cpp	2012-03-28 02:29:21 UTC (rev 112356)
+++ trunk/Source/WebCore/platform/graphics/skia/SimpleFontDataSkia.cpp	2012-03-28 02:42:05 UTC (rev 112357)
@@ -139,8 +139,14 @@
 static const UChar32 xChar = 'x';
 const Glyph xGlyph = glyphPageZero->glyphDataForCharacter(xChar).glyph;
 
-if (xGlyph)
+if (xGlyph) {
+// In widthForGlyph(), xGlyph will be compared with
+// m_zeroWidthSpaceGlyph, which isn't initialized yet here.
+// Initialize it with zero to make sure widthForGlyph() returns
+// the right width.
+m_zeroWidthSpaceGlyph = 0;
 m_avgCharWidth = widthForGlyph(xGlyph);
+}
 }
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112356] trunk/Source/WebKit/chromium

[commit-queue]

Title: [112356] trunk/Source/WebKit/chromium








Revision 112356
Author commit-qu...@webkit.org
Date 2012-03-27 19:29:21 -0700 (Tue, 27 Mar 2012)


Log Message
webkit_unit_tests crashing on chromium lion in CCLayerTreeHostTestCompositeAndReadbackWhileInvisible
https://bugs.webkit.org/show_bug.cgi?id=82382

Patch by James Robinson  on 2012-03-27
Reviewed by Adrienne Walker.

Use UnsignedWithZeroKeyHashTraits trait for the HashSet m_usedTextures in
CompositorFakeWebGraphicsContext3DWithTextureTracking. This set is used to track all textures that are bound in
a given context during a test. During ..CompositeAndReadback.. we bind texture id 0. By default, HashSet
where T is an unsigned does not allow 0 as a value. WebGLId is typedef'd to unsigned.

* tests/CCLayerTreeHostTest.cpp:
(CompositorFakeWebGraphicsContext3DWithTextureTracking):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (112355 => 112356)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 02:08:49 UTC (rev 112355)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 02:29:21 UTC (rev 112356)
@@ -1,5 +1,20 @@
 2012-03-27  James Robinson  
 
+webkit_unit_tests crashing on chromium lion in CCLayerTreeHostTestCompositeAndReadbackWhileInvisible
+https://bugs.webkit.org/show_bug.cgi?id=82382
+
+Reviewed by Adrienne Walker.
+
+Use UnsignedWithZeroKeyHashTraits trait for the HashSet m_usedTextures in
+CompositorFakeWebGraphicsContext3DWithTextureTracking. This set is used to track all textures that are bound in
+a given context during a test. During ..CompositeAndReadback.. we bind texture id 0. By default, HashSet
+where T is an unsigned does not allow 0 as a value. WebGLId is typedef'd to unsigned.
+
+* tests/CCLayerTreeHostTest.cpp:
+(CompositorFakeWebGraphicsContext3DWithTextureTracking):
+
+2012-03-27  James Robinson  
+
 webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer
 https://bugs.webkit.org/show_bug.cgi?id=82381
 


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (112355 => 112356)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp	2012-03-28 02:08:49 UTC (rev 112355)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp	2012-03-28 02:29:21 UTC (rev 112356)
@@ -209,7 +209,7 @@
 }
 
 Vector m_textures;
-HashSet m_usedTextures;
+HashSet::Hash, UnsignedWithZeroKeyHashTraits > m_usedTextures;
 };
 
 // Implementation of CCLayerTreeHost callback interface.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112355] trunk/Tools

[ojan]

Title: [112355] trunk/Tools








Revision 112355
Author o...@chromium.org
Date 2012-03-27 19:08:49 -0700 (Tue, 27 Mar 2012)


Log Message
Fix expected results for some unittest failures.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js (112354 => 112355)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js	2012-03-28 02:06:54 UTC (rev 112354)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js	2012-03-28 02:08:49 UTC (rev 112355)
@@ -89,7 +89,7 @@
 equal(grid.outerHTML, '' +
 'typereleasedebug' +
 '' +
-'' +
+'' +
 'TEXT' +
 '' +
 'lucid64-bit' +
@@ -106,7 +106,7 @@
 'leopard' +
 '' +
 '' +
-'' +
+'' +
 'TEXT' +
 '' +
 'lucid64-bit' +
@@ -118,12 +118,12 @@
 equal(grid.outerHTML, '' +
 'typereleasedebug' +
 '' +
-'' +
+'' +
 'IMAGE+TEXT' +
 'leopard' +
 '' +
 '' +
-'' +
+'' +
 'TEXT' +
 '' +
 'lucid64-bit' +


Modified: trunk/Tools/ChangeLog (112354 => 112355)

--- trunk/Tools/ChangeLog	2012-03-28 02:06:54 UTC (rev 112354)
+++ trunk/Tools/ChangeLog	2012-03-28 02:08:49 UTC (rev 112355)
@@ -1,3 +1,9 @@
+2012-03-27  Ojan Vafai  
+
+Fix expected results for some unittest failures.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
+
 2012-03-27  Adrienne Walker  
 
 [chromium] Fix --enabled-threaded-compositing flag in DRT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112354] trunk/Tools

[enne]

Title: [112354] trunk/Tools








Revision 112354
Author e...@google.com
Date 2012-03-27 19:06:54 -0700 (Tue, 27 Mar 2012)


Log Message
[chromium] Fix --enabled-threaded-compositing flag in DRT
https://bugs.webkit.org/show_bug.cgi?id=82405

Reviewed by James Robinson.

--enable-threaded-compositing wasn't working because there was no way
to set the value before it was used in the TestShell constructor.

To avoid adding yet another boolean parameter to TestShell's
constructor, add an explicit initialize function that can operate on
any boolean settings that are set post-constructor.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
(TestShell::setTestShellMode):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.h




Diff

Modified: trunk/Tools/ChangeLog (112353 => 112354)

--- trunk/Tools/ChangeLog	2012-03-28 02:02:18 UTC (rev 112353)
+++ trunk/Tools/ChangeLog	2012-03-28 02:06:54 UTC (rev 112354)
@@ -1,3 +1,26 @@
+2012-03-27  Adrienne Walker  
+
+[chromium] Fix --enabled-threaded-compositing flag in DRT
+https://bugs.webkit.org/show_bug.cgi?id=82405
+
+Reviewed by James Robinson.
+
+--enable-threaded-compositing wasn't working because there was no way
+to set the value before it was used in the TestShell constructor.
+
+To avoid adding yet another boolean parameter to TestShell's
+constructor, add an explicit initialize function that can operate on
+any boolean settings that are set post-constructor.
+
+* DumpRenderTree/chromium/DumpRenderTree.cpp:
+(main):
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::TestShell):
+(TestShell::initialize):
+* DumpRenderTree/chromium/TestShell.h:
+(TestShell):
+(TestShell::setTestShellMode):
+
 2012-03-27  Dirk Pranke  
 
 new-run-webkit-tests: suppress debug output from run-safari on results file


Modified: trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp (112353 => 112354)

--- trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp	2012-03-28 02:02:18 UTC (rev 112353)
+++ trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp	2012-03-28 02:06:54 UTC (rev 112354)
@@ -234,7 +234,8 @@
 openStartupDialog();
 
 { // Explicit scope for the TestShell instance.
-TestShell shell(testShellMode);
+TestShell shell;
+shell.setTestShellMode(testShellMode);
 shell.setAllowExternalPages(allowExternalPages);
 shell.setAcceleratedCompositingForVideoEnabled(acceleratedCompositingForVideoEnabled);
 shell.setThreadedCompositingEnabled(threadedCompositingEnabled);
@@ -251,6 +252,7 @@
 // 0x2000ms is big enough for the purpose to avoid timeout in debugging.
 shell.setLayoutTestTimeout(0x2000);
 }
+shell.initialize();
 if (serverMode && !tests.size()) {
 #if OS(ANDROID)
 // Send a signal to host to indicate DRT is ready to process commands.


Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (112353 => 112354)

--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2012-03-28 02:02:18 UTC (rev 112353)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2012-03-28 02:06:54 UTC (rev 112354)
@@ -98,11 +98,11 @@
 }
 }
 
-TestShell::TestShell(bool testShellMode)
+TestShell::TestShell()
 : m_testIsPending(false)
 , m_testIsPreparing(false)
 , m_focusedWidget(0)
-, m_testShellMode(testShellMode)
+, m_testShellMode(false)
 , m_devTools(0)
 , m_allowExternalPages(false)
 , m_acceleratedCompositingForVideoEnabled(false)
@@ -131,7 +131,10 @@
 WebRuntimeFeatures::enableShadowDOM(true);
 WebRuntimeFeatures::enableStyleScoped(true);
 WebRuntimeFeatures::enableScriptedSpeech(true);
+}
 
+void TestShell::initialize()
+{
 m_webPermissions = adoptPtr(new WebPermissions(this));
 m_accessibilityController = adoptPtr(new AccessibilityController(this));
 m_gamepadController = adoptPtr(new GamepadController(this));
@@ -151,7 +154,6 @@
 } else
 WebCompositor::initialize(0);
 
-
 // 30 second is the same as the value in Mac DRT.
 // If we use a value smaller than the timeout value of
 // (new-)run-webkit-tests, (new-)run-webkit-tests misunderstands that a


Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.h (112353 => 112354)

--- trunk/Tools/DumpRenderTree/chromium/TestShell.h	2012-03-28 02:02:18 UTC (rev 112353)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.h	2012-03-28 02:06:54 UTC (rev 112354)
@@ -82,9 +82,11 @@
 
 class TestShell {
 public:
-TestShell(bool testShellMode);
+TestShell();
 ~TestShell();
 
+void initialize();
+
 // The 

[webkit-changes] [112353] trunk/Source

[commit-queue]

Title: [112353] trunk/Source








Revision 112353
Author commit-qu...@webkit.org
Date 2012-03-27 19:02:18 -0700 (Tue, 27 Mar 2012)


Log Message
[EFL][WK2] Add RunLoopEfl and WorkQueueEfl
https://bugs.webkit.org/show_bug.cgi?id=62777

Patch by YoungTaeck Song  on 2012-03-27
Reviewed by Hajime Morita.

Source/WebCore:

Add initial version RunLoopEfl for WebKit2 Efl.

* platform/RunLoop.h:
(TimerBase):
(RunLoop):
* platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore):
(WebCore::RunLoop::run):
(WebCore::RunLoop::stop):
(WebCore::RunLoop::wakeUpEvent):
(WebCore::RunLoop::wakeUp):
(WebCore::RunLoop::TimerBase::TimerBase):
(WebCore::RunLoop::TimerBase::~TimerBase):
(WebCore::RunLoop::TimerBase::timerFired):
(WebCore::RunLoop::TimerBase::start):
(WebCore::RunLoop::TimerBase::stop):
(WebCore::RunLoop::TimerBase::isActive):

Source/WebKit2:

Add initial version WorkQueueEfl for WebKit2 Efl.

* Platform/CoreIPC/Connection.h:
* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open):
* Platform/PlatformProcessIdentifier.h:
(WebKit):
* Platform/WorkQueue.h:
(WorkQueue):
* Platform/efl/WorkQueueEfl.cpp: Added.
(TimerWorkItem):
(TimerWorkItem::TimerWorkItem):
(TimerWorkItem::~TimerWorkItem):
(TimerWorkItem::function):
(TimerWorkItem::queue):
(TimerWorkItem::timerID):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::performWork):
(WorkQueue::performFdWork):
(WorkQueue::sendMessageToThread):
(WorkQueue::workQueueThread):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::timerFired):
(WorkQueue::dispatchAfterDelay):
* PlatformEfl.cmake:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/RunLoop.h
trunk/Source/WebCore/platform/efl/RunLoopEfl.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/Connection.h
trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp
trunk/Source/WebKit2/Platform/PlatformProcessIdentifier.h
trunk/Source/WebKit2/Platform/WorkQueue.h
trunk/Source/WebKit2/PlatformEfl.cmake


Added Paths

trunk/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112352 => 112353)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 01:58:32 UTC (rev 112352)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 02:02:18 UTC (rev 112353)
@@ -1,3 +1,30 @@
+2012-03-27  YoungTaeck Song  
+
+[EFL][WK2] Add RunLoopEfl and WorkQueueEfl
+https://bugs.webkit.org/show_bug.cgi?id=62777
+
+Reviewed by Hajime Morita.
+
+Add initial version RunLoopEfl for WebKit2 Efl.
+
+* platform/RunLoop.h:
+(TimerBase):
+(RunLoop):
+* platform/efl/RunLoopEfl.cpp:
+(WebCore::RunLoop::RunLoop):
+(WebCore::RunLoop::~RunLoop):
+(WebCore):
+(WebCore::RunLoop::run):
+(WebCore::RunLoop::stop):
+(WebCore::RunLoop::wakeUpEvent):
+(WebCore::RunLoop::wakeUp):
+(WebCore::RunLoop::TimerBase::TimerBase):
+(WebCore::RunLoop::TimerBase::~TimerBase):
+(WebCore::RunLoop::TimerBase::timerFired):
+(WebCore::RunLoop::TimerBase::start):
+(WebCore::RunLoop::TimerBase::stop):
+(WebCore::RunLoop::TimerBase::isActive):
+
 2012-03-27  Benjamin Poulain  
 
 Reinforce Geolocation to prevent accidental leak of the user position


Modified: trunk/Source/WebCore/platform/RunLoop.h (112352 => 112353)

--- trunk/Source/WebCore/platform/RunLoop.h	2012-03-28 01:58:32 UTC (rev 112352)
+++ trunk/Source/WebCore/platform/RunLoop.h	2012-03-28 02:02:18 UTC (rev 112353)
@@ -39,6 +39,10 @@
 #include 
 #endif
 
+#if PLATFORM(EFL)
+#include 
+#endif
+
 namespace WebCore {
 
 class RunLoop {
@@ -95,6 +99,10 @@
 void clearTimerSource();
 GRefPtr m_timerSource;
 gboolean m_isRepeating;
+#elif PLATFORM(EFL)
+static bool timerFired(void* data);
+OwnPtr m_timer;
+bool m_isRepeating;
 #endif
 };
 
@@ -157,6 +165,10 @@
 private:
 GRefPtr m_runLoopContext;
 Vector > m_runLoopMainLoops;
+#elif PLATFORM(EFL)
+bool m_initEfl;
+OwnPtr m_pipe;
+static void wakeUpEvent(void* data, void*, unsigned int);
 #endif
 };
 


Modified: trunk/Source/WebCore/platform/efl/RunLoopEfl.cpp (112352 => 112353)

--- trunk/Source/WebCore/platform/efl/RunLoopEfl.cpp	2012-03-28 01:58:32 UTC (rev 112352)
+++ trunk/Source/WebCore/platform/efl/RunLoopEfl.cpp	2012-03-28 02:02:18 UTC (rev 112353)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2012 ProFUSION embedded systems. All rights reserved.
+ * Copyright (C) 2012 Samsung Electronics
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -26,23 +27,122 @@
 #include "config.h"
 #include "RunLoop.h"
 
-#include "NotImplemented.h"
+#include 
+#include 
+#include 
+#inclu

[webkit-changes] [112352] trunk/LayoutTests

[dpranke]

Title: [112352] trunk/LayoutTests








Revision 112352
Author dpra...@chromium.org
Date 2012-03-27 18:58:32 -0700 (Tue, 27 Mar 2012)


Log Message
More flaky tests!

Unreviewed, expectations changes.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112351 => 112352)

--- trunk/LayoutTests/ChangeLog	2012-03-28 01:56:30 UTC (rev 112351)
+++ trunk/LayoutTests/ChangeLog	2012-03-28 01:58:32 UTC (rev 112352)
@@ -1,5 +1,13 @@
 2012-03-27  Dirk Pranke  
 
+More flaky tests!
+
+Unreviewed, expectations changes.
+
+* platform/chromium/test_expectations.txt:
+
+2012-03-27  Dirk Pranke  
+
 Restore a couple of leopard/snowleopard expectations I overzealously deleted.
 
 Unreviewed, expectations change.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112351 => 112352)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 01:56:30 UTC (rev 112351)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 01:58:32 UTC (rev 112352)
@@ -2824,6 +2824,7 @@
 BUGNONE SLOW WIN DEBUG : platform/chromium/virtual/gpu/fast/canvas/canvas-getImageData.html = PASS
 
 BUGWK55968 MAC WIN DEBUG : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE
+BUGWK82412 LION RELEASE : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE PASS
 
 BUGWK53868 : fast/notifications/notifications-document-close-crash.html = PASS TEXT
 
@@ -3931,7 +3932,7 @@
 BUGWK75568 LEOPARD SNOWLEOPARD : fast/repaint/subtree-root-clip.html = IMAGE
 BUGWK75568 LEOPARD SNOWLEOPARD : fast/repaint/subtree-root-skipped.html = IMAGE
 BUGWK75568 LEOPARD SNOWLEOPARD : fast/replaced/replaced-breaking.html = IMAGE
-BUGWK75568 LEOPARD SNOWLEOPARD : fast/replaced/width100percent-searchfield.html = IMAGE
+BUGWK75568 LEOPARD SNOWLEOPARD : fast/replaced/width100percent-searchfield.html = IMAGE PASS
 BUGWK75568 MAC DEBUG : fast/text/textIteratorNilRenderer.html = IMAGE PASS
 BUGWK75568 SLOW MAC RELEASE : fast/text/textIteratorNilRenderer.html = IMAGE PASS
 
@@ -4308,3 +4309,17 @@
 
 // this test appears to consistently fail during the main run but usually passes on a retry.
 BUGWK82404 LINUX LEOPARD SNOWLEOPARD : plugins/netscape-dom-access-and-reload.html = PASS TEXT 
+
+BUGWK82409 LINUX RELEASE : inspector/styles/css-live-edit.html = PASS TIMEOUT
+
+BUGWK82410 : css2.1/20110323/abspos-containing-block-initial-004b.htm = PASS IMAGE
+BUGWK82410 : css2.1/20110323/abspos-containing-block-initial-004d.htm = PASS IMAGE
+
+BUGWK82415 : transforms/no_transform_hit_testing.html = PASS IMAGE
+
+BUGWK82416 : svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml = PASS IMAGE
+
+BUGWK82413 LINUX : fast/filesystem/workers/async-operations.html = PASS TIMEOUT
+BUGWK82413 MAC DEBUG : fast/filesystem/workers/async-operations.html = PASS TIMEOUT
+
+BUGWK82417 LINUX SLOW : fast/frames/set-unloaded-frame-location.html = PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112351] trunk/Source/WebKit/chromium

[commit-queue]

Title: [112351] trunk/Source/WebKit/chromium








Revision 112351
Author commit-qu...@webkit.org
Date 2012-03-27 18:56:30 -0700 (Tue, 27 Mar 2012)


Log Message
webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer
https://bugs.webkit.org/show_bug.cgi?id=82381

Patch by James Robinson  on 2012-03-27
Reviewed by Adrienne Walker.

Use the mock scrollbar theme for this unit test. The real ScrollbarThemeMac isn't compatible with the mocks this
test uses and the test isn't designed to cover the theming code, only code inside the compositor.

* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::TEST):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (112350 => 112351)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 01:16:21 UTC (rev 112350)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 01:56:30 UTC (rev 112351)
@@ -1,3 +1,16 @@
+2012-03-27  James Robinson  
+
+webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer
+https://bugs.webkit.org/show_bug.cgi?id=82381
+
+Reviewed by Adrienne Walker.
+
+Use the mock scrollbar theme for this unit test. The real ScrollbarThemeMac isn't compatible with the mocks this
+test uses and the test isn't designed to cover the theming code, only code inside the compositor.
+
+* tests/ScrollbarLayerChromiumTest.cpp:
+(WebCore::TEST):
+
 2012-03-27  Dirk Pranke  
 
 Unreviewed, rolling out r112339.


Modified: trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp (112350 => 112351)

--- trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp	2012-03-28 01:16:21 UTC (rev 112350)
+++ trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp	2012-03-28 01:56:30 UTC (rev 112351)
@@ -27,6 +27,7 @@
 #include "ScrollbarLayerChromium.h"
 
 #include "Scrollbar.h"
+#include "Settings.h"
 #include "TreeSynchronizer.h"
 #include "cc/CCScrollbarLayerImpl.h"
 #include "cc/CCSingleThreadProxy.h"
@@ -90,6 +91,7 @@
 {
 DebugScopedSetImplThread impl;
 
+Settings::setMockScrollbarsEnabled(true);
 {
 RefPtr scrollbar = adoptRef(new MockScrollbar);
 RefPtr layerTreeRoot = LayerChromium::create();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112350] trunk/LayoutTests

[dpranke]

Title: [112350] trunk/LayoutTests








Revision 112350
Author dpra...@chromium.org
Date 2012-03-27 18:16:21 -0700 (Tue, 27 Mar 2012)


Log Message
Restore a couple of leopard/snowleopard expectations I overzealously deleted.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112349 => 112350)

--- trunk/LayoutTests/ChangeLog	2012-03-28 01:10:37 UTC (rev 112349)
+++ trunk/LayoutTests/ChangeLog	2012-03-28 01:16:21 UTC (rev 112350)
@@ -1,5 +1,13 @@
 2012-03-27  Dirk Pranke  
 
+Restore a couple of leopard/snowleopard expectations I overzealously deleted.
+
+Unreviewed, expectations change.
+
+* platform/chromium/test_expectations.txt:
+
+2012-03-27  Dirk Pranke  
+
 Remove move tests passing on win and linux.
 
 Unreviewed, expectations change.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112349 => 112350)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 01:10:37 UTC (rev 112349)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 01:16:21 UTC (rev 112350)
@@ -1250,13 +1250,13 @@
 // Appears elsewhere commented
 BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-36-t.svg = TEXT
 // Appears elsewhere commented
-BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-39-t.svg = TEXT
+BUGWK75968 WIN LEOPARD SNOWLEOPARD : svg/W3C-SVG-1.1/animate-elem-39-t.svg = TEXT
 // Appears elsewhere commented
 BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-40-t.svg = TEXT
 // Appears elsewhere commented
 BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-41-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
-BUGWK75968 WIN SNOWLEOPARD : svg/W3C-SVG-1.1/animate-elem-46-t.svg = IMAGE+TEXT TEXT
+BUGWK75968 WIN LEOPARD SNOWLEOPARD : svg/W3C-SVG-1.1/animate-elem-46-t.svg = IMAGE+TEXT TEXT
 // Appears elsewhere commented
 BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-61-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
@@ -1352,7 +1352,9 @@
 // or might be expected and that we should either go with the buildbot output
 // or change the test upstream to specify explicitly what font to use.
 // The mask part of this test is totally wrong.
-BUGCR3244 WIN LINUX SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = FAIL
+BUGCR3244 WIN LINUX LEOPARD : svg/as-background-image/svg-as-background-6.html = FAIL
+BUGCR3244 SNOWLEOPARD RELEASE : svg/as-background-image/svg-as-background-6.html = FAIL
+BUGCR3244 SNOWLEOPARD DEBUG : svg/as-background-image/svg-as-background-6.html = FAIL CRASH
 
 // Our gradients are wrong here.
 BUGCR19559 LINUX WIN : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = FAIL






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112349] trunk/LayoutTests

[dpranke]

Title: [112349] trunk/LayoutTests








Revision 112349
Author dpra...@chromium.org
Date 2012-03-27 18:10:37 -0700 (Tue, 27 Mar 2012)


Log Message
Remove move tests passing on win and linux.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112348 => 112349)

--- trunk/LayoutTests/ChangeLog	2012-03-28 01:01:40 UTC (rev 112348)
+++ trunk/LayoutTests/ChangeLog	2012-03-28 01:10:37 UTC (rev 112349)
@@ -1,5 +1,13 @@
 2012-03-27  Dirk Pranke  
 
+Remove move tests passing on win and linux.
+
+Unreviewed, expectations change.
+
+* platform/chromium/test_expectations.txt:
+
+2012-03-27  Dirk Pranke  
+
 Remove more tests passing on lion
 
 Unreviewed, expectations change.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112348 => 112349)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 01:01:40 UTC (rev 112348)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 01:10:37 UTC (rev 112349)
@@ -1468,11 +1468,6 @@
 // Other failures
 // -
 
-// These fail the pixel tests in debug mode because they have
-// unpainted space (filled red in Debug but not in Release).
-// https://bugs.webkit.org/show_bug.cgi?id=8423
-BUGCR24204 LINUX WIN LEOPARD SNOWLEOPARD : tables/mozilla_expected_failures/bugs/bug178855.xml = IMAGE+TEXT TEXT
-
 // Fails on webkit windows as well.
 BUGCR24207 : fast/events/attempt-scroll-with-no-scrollbars.html = FAIL
 
@@ -3791,9 +3786,6 @@
 
 BUGV8_1948 : fast/js/dfg-put-by-id-prototype-check.html = TEXT
 
-BUGWK78561 WIN : css3/filters/crash-hw-sw-switch.html = MISSING
-BUGWK78561 WIN : css3/filters/filter-empty-element-crash.html = MISSING
-
 // Still flaky:
 BUGWK78830 DEBUG : svg/custom/mask-invalidation.svg = IMAGE PASS
 
@@ -3891,7 +3883,7 @@
 BUGWK78684 WIN LINUX : fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html = FAIL
 
 // New test; landed at r109779 but results look wrong on most Chrome platforms.
-BUGSENORBLANCO : http/tests/incremental/partial-jpeg.html = FAIL
+BUGSENORBLANCO : http/tests/incremental/partial-jpeg.html = FAIL PASS
 
 // Since r109914, flaky crash
 BUGWK80481 MAC : canvas/philip/tests/2d.text-custom-font-load-crash.html = CRASH PASS
@@ -4047,7 +4039,6 @@
 BUGWK81145 LION : fast/events/scrollbar-double-click.html = TEXT
 
 // Migrated from chromium's downstream test_expectations
-BUGYANGGUO LINUX X86_64 : fast/repaint/moving-shadow-on-container.html = TEXT
 BUGYANGGUO MAC : fast/repaint/moving-shadow-on-container.html = TEXT
 BUGYANGGUO LEOPARD SNOWLEOPARD : fast/repaint/moving-shadow-on-path.html = TEXT
 BUGYANGGUO LION : svg/css/stars-with-shadow.html = TEXT
@@ -4064,7 +4055,7 @@
 
 BUGWK77368 WIN : css3/flexbox/child-overflow.html = IMAGE
 
-BUGWK81537 : fast/events/touch/gesture/pad-gesture-fling.html = TEXT
+BUGWK81537 : fast/events/touch/gesture/pad-gesture-fling.html = TEXT PASS
 
 BUGWK81544 : fast/text/international/font-fallback-to-common-script.html = IMAGE PASS
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112348] trunk/LayoutTests

[dpranke]

Title: [112348] trunk/LayoutTests








Revision 112348
Author dpra...@chromium.org
Date 2012-03-27 18:01:40 -0700 (Tue, 27 Mar 2012)


Log Message
Remove more tests passing on lion

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112347 => 112348)

--- trunk/LayoutTests/ChangeLog	2012-03-28 00:58:20 UTC (rev 112347)
+++ trunk/LayoutTests/ChangeLog	2012-03-28 01:01:40 UTC (rev 112348)
@@ -1,5 +1,13 @@
 2012-03-27  Dirk Pranke  
 
+Remove more tests passing on lion
+
+Unreviewed, expectations change.
+
+* platform/chromium/test_expectations.txt:
+
+2012-03-27  Dirk Pranke  
+
 Add suppression for flaky plugins/netscape-dom-access-and-reload.html on mac and linux.
 
 Unreviewed, expectations change.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112347 => 112348)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 00:58:20 UTC (rev 112347)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 01:01:40 UTC (rev 112348)
@@ -51,7 +51,7 @@
 // See BUGCR104797
 
 // V8 roll to 3.9.24.1. Remember to remove WIN LINUX from the line below upon fixing.
-BUGCR119915 MAC : fast/js/dfg-double-vote-fuzz.html = TEXT
+BUGCR119915 MAC SLOW : fast/js/dfg-double-vote-fuzz.html = PASS
 BUGWK77184 DEBUG WIN LINUX SLOW : fast/js/dfg-double-vote-fuzz.html = PASS
 BUGWK77069 DEBUG SLOW : fast/js/dfg-uint32array-overflow-values.html = PASS
 BUGWK74787 DEBUG SLOW : fast/js/dfg-poison-fuzz.html = PASS
@@ -1284,7 +1284,7 @@
 BUGWK75968 WIN LEOPARD SNOWLEOPARD : svg/W3C-SVG-1.1/text-text-05-t.svg = IMAGE+TEXT TEXT
 // This may be unrelated.
 BUGWK75968 LION : svg/css/group-with-shadow.svg = IMAGE
-BUGWK75968 MAC : svg/text/text-text-05-t.svg = TEXT
+BUGWK75968 LEOPARD SNOWLEOPARD : svg/text/text-text-05-t.svg = TEXT
 
 // Flaky on Linux after http://trac.webkit.org/changeset/112022
 BUGWK82217 LINUX : svg/zoom/text/zoom-foreignObject.svg = IMAGE PASS
@@ -1536,10 +1536,6 @@
 BUGWK80335 : fast/js/mozilla/strict/15.4.4.12.html = TEXT
 BUGWK80335 : fast/js/mozilla/strict/15.4.4.13.html = TEXT
 
-// We print to stderr when a failure happens while importing XSL;
-// should disable this in libxml.
-BUGCR10347 MAC : fast/xsl/transform-xhr-doc.xhtml = FAIL
-
 // V8 should implement the length property of constructors
 BUGWK78657 : fast/js/constructor-length.html = FAIL
 
@@ -1612,8 +1608,6 @@
 // Broken pixel tests
 
 // Widget location is just slightly off
-BUGCR23496 MAC : css1/box_properties/acid_test.html = IMAGE
-BUGCR23496 MAC : css2.1/t09-c5526c-display-00-e.html = IMAGE
 BUGCR23496 MAC : fast/forms/001.html = IMAGE
 BUGCR23496 MAC : fast/forms/form-element-geometry.html = IMAGE+TEXT
 BUGCR23496 MAC : fast/forms/formmove.html = IMAGE
@@ -1639,7 +1633,6 @@
 BUGCR10364 MAC : http/tests/navigation/reload-subframe-object.html = FAIL
 
 // Text declared as "monospace" with no size is bigger in Chromium
-BUGCR23494 MAC : css1/font_properties/font_family.html = IMAGE
 BUGCR23494 LEOPARD : css2.1/t1503-c522-font-family-00-b.html = IMAGE
 BUGCR23494 LEOPARD : fast/text/monospace-width-cache.html = IMAGE
 
@@ -2441,7 +2434,7 @@
 BUGWK44199 BUGWK63057 RELEASE SLOW : perf/array-binary-search.html = MISSING PASS TEXT
 BUGWK72901 RELEASE SLOW : perf/array-push-pop.html = PASS
 BUGWK44199 RELEASE : perf/array-reverse.html = PASS TIMEOUT
-BUGWK63057 RELEASE : perf/adding-radio-buttons.html = MISSING FAIL
+BUGWK63057 RELEASE : perf/adding-radio-buttons.html = MISSING FAIL PASS
 
 // Failing after http://trac.webkit.org/changeset/65665/
 BUGWK44278 : svg/transforms/text-with-mask-with-svg-transform.svg = IMAGE+TEXT IMAGE
@@ -2799,7 +2792,7 @@
 BUGWK77550 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html = TEXT
 
 // These will have slight differences on the edges of antialiased paths and need rebaseling
-BUGBSALOMON : platform/chromium/virtual/gpu/fast/canvas/arc360.html = IMAGE
+BUGBSALOMON WIN LINUX : platform/chromium/virtual/gpu/fast/canvas/arc360.html = IMAGE
 BUGBSALOMON : platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip.html = IMAGE
 BUGBSALOMON : platform/chromium/virtual/gpu/fast/canvas/canvas-composite.html = IMAGE
 BUGBSALOMON : platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed.html = IMAGE
@@ -3179,7 +3172,7 @@
 BUGCR85293 LINUX : svg/text/foreignObject-text-clipping-bug.xml = PASS IMAGE
 
 BUGWK81310 : fast/dom/shadow/content-element-in-media-element.html = TEXT
-BUGWK81311 : fast/dom/shadow/content-element-in-meter-element.html = TEXT
+BUGWK81311 WIN LINUX : fast/dom/shadow/content-element-in-meter-element.html = TEXT
 
 // CSS Grid Layout is not enabled yet.
 BUGWK60731 SKIP : fast/css-grid-layout = PASS
@@ -3328,7 +3321,7 @@
 
 BUGWK65462 VISTA : http/tests/cache/history-only-

[webkit-changes] [112347] trunk/Source/WebCore

[benjamin]

Title: [112347] trunk/Source/WebCore








Revision 112347
Author benja...@webkit.org
Date 2012-03-27 17:58:20 -0700 (Tue, 27 Mar 2012)


Log Message
Reinforce Geolocation to prevent accidental leak of the user position
https://bugs.webkit.org/show_bug.cgi?id=82396

Patch by Benjamin Poulain  on 2012-03-27
Reviewed by Adam Barth.

It is very important not to provide the position of the user to a page
unless the user authorize it.

The code used to make it easy to cause such problems, because any part
of the Geolocation object could invoke the success callback directly.

This patch add encapsulation for all the attributes of GeoNotifier,
and add extra guards for the two callbacks.

In the case of the success callback, we do one extra check before sending
the value to the bindings.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::runSuccessCallback):
(WebCore::Geolocation::GeoNotifier::runErrorCallback):
(WebCore):
(WebCore::Geolocation::GeoNotifier::stopTimer):
(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::sendError):
(WebCore::Geolocation::sendPosition):
(WebCore::Geolocation::stopTimer):
(WebCore::Geolocation::extractNotifiersWithCachedPosition):
(WebCore::Geolocation::startUpdating):
* Modules/geolocation/Geolocation.h:
(WebCore::Geolocation::isAllowed):
(Geolocation):
(GeoNotifier):
(WebCore::Geolocation::GeoNotifier::options):
(WebCore::Geolocation::GeoNotifier::useCachedPosition):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp
trunk/Source/WebCore/Modules/geolocation/Geolocation.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112346 => 112347)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 00:52:40 UTC (rev 112346)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 00:58:20 UTC (rev 112347)
@@ -1,3 +1,41 @@
+2012-03-27  Benjamin Poulain  
+
+Reinforce Geolocation to prevent accidental leak of the user position
+https://bugs.webkit.org/show_bug.cgi?id=82396
+
+Reviewed by Adam Barth.
+
+It is very important not to provide the position of the user to a page
+unless the user authorize it.
+
+The code used to make it easy to cause such problems, because any part
+of the Geolocation object could invoke the success callback directly.
+
+This patch add encapsulation for all the attributes of GeoNotifier,
+and add extra guards for the two callbacks.
+
+In the case of the success callback, we do one extra check before sending
+the value to the bindings.
+
+* Modules/geolocation/Geolocation.cpp:
+(WebCore::Geolocation::GeoNotifier::runSuccessCallback):
+(WebCore::Geolocation::GeoNotifier::runErrorCallback):
+(WebCore):
+(WebCore::Geolocation::GeoNotifier::stopTimer):
+(WebCore::Geolocation::GeoNotifier::timerFired):
+(WebCore::Geolocation::startRequest):
+(WebCore::Geolocation::sendError):
+(WebCore::Geolocation::sendPosition):
+(WebCore::Geolocation::stopTimer):
+(WebCore::Geolocation::extractNotifiersWithCachedPosition):
+(WebCore::Geolocation::startUpdating):
+* Modules/geolocation/Geolocation.h:
+(WebCore::Geolocation::isAllowed):
+(Geolocation):
+(GeoNotifier):
+(WebCore::Geolocation::GeoNotifier::options):
+(WebCore::Geolocation::GeoNotifier::useCachedPosition):
+
 2012-03-27  Kausalya Madhusudhanan  
 
 [Coverity] Address some uninitialized constructor values.


Modified: trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp (112346 => 112347)

--- trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp	2012-03-28 00:52:40 UTC (rev 112346)
+++ trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp	2012-03-28 00:58:20 UTC (rev 112347)
@@ -120,15 +120,33 @@
 
 void Geolocation::GeoNotifier::runSuccessCallback(Geoposition* position)
 {
+// If we are here and the Geolocation permission is not approved, something has
+// gone horribly wrong.
+// We bail out to avoid any privacy issue.
+ASSERT(m_geolocation->isAllowed());
+if (!m_geolocation->isAllowed())
+return;
+
 m_successCallback->handleEvent(position);
 }
 
+void Geolocation::GeoNotifier::runErrorCallback(PositionError* error)
+{
+if (m_errorCallback)
+m_errorCallback->handleEvent(error);
+}
+
 void Geolocation::GeoNotifier::startTimerIfNeeded()
 {
 if (m_options->hasTimeout())
 m_timer.startOneShot(m_options->timeout() / 1000.0);
 }
 
+void Geolocation::GeoNotifier::stopTimer()
+{
+m_timer.stop();
+}
+
 void Geolocation::GeoNotifier::timerFired(Timer*)
 {
 m_timer.stop();
@@ -140,8 +158,7 @@
 // Test for fatal error first. This is required for the case where the Frame is
 // disconnected and requests are cancelled.
 if (m_fatalError) {
-if (m_errorCallback)
-m_errorCal

[webkit-changes] [112346] trunk/Source/WebKit/chromium

[dpranke]

Title: [112346] trunk/Source/WebKit/chromium








Revision 112346
Author dpra...@chromium.org
Date 2012-03-27 17:52:40 -0700 (Tue, 27 Mar 2012)


Log Message
Unreviewed, rolling out r112339.
http://trac.webkit.org/changeset/112339
https://bugs.webkit.org/show_bug.cgi?id=82354

webkit_unit_tests crashing on chromium mac bots

* src/AssociatedURLLoader.cpp:
(AssociatedURLLoader::ClientAdapter):
* tests/AssociatedURLLoaderTest.cpp:
(WebKit::AssociatedURLLoaderTest::TearDown):
(WebKit):
(WebKit::TEST_F):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp
trunk/Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (112345 => 112346)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 00:49:33 UTC (rev 112345)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 00:52:40 UTC (rev 112346)
@@ -1,3 +1,18 @@
+2012-03-27  Dirk Pranke  
+
+Unreviewed, rolling out r112339.
+http://trac.webkit.org/changeset/112339
+https://bugs.webkit.org/show_bug.cgi?id=82354
+
+webkit_unit_tests crashing on chromium mac bots
+
+* src/AssociatedURLLoader.cpp:
+(AssociatedURLLoader::ClientAdapter):
+* tests/AssociatedURLLoaderTest.cpp:
+(WebKit::AssociatedURLLoaderTest::TearDown):
+(WebKit):
+(WebKit::TEST_F):
+
 2012-03-27  Kausalya Madhusudhanan  
 
 [Coverity] Address some uninitialized constructor values.


Modified: trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp (112345 => 112346)

--- trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp	2012-03-28 00:49:33 UTC (rev 112345)
+++ trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp	2012-03-28 00:52:40 UTC (rev 112346)
@@ -140,7 +140,6 @@
 virtual void didReceiveCachedMetadata(const char*, int /*dataLength*/);
 virtual void didFinishLoading(unsigned long /*identifier*/, double /*finishTime*/);
 virtual void didFail(const ResourceError&);
-virtual void didFailRedirectCheck();
 
 virtual bool isDocumentThreadableLoaderClient() { return true; }
 
@@ -264,11 +263,6 @@
 notifyError(&m_errorTimer);
 }
 
-void AssociatedURLLoader::ClientAdapter::didFailRedirectCheck()
-{
-m_loader->cancel();
-}
-
 void AssociatedURLLoader::ClientAdapter::setDelayedError(const ResourceError& error)
 {
 didFail(error);


Modified: trunk/Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp (112345 => 112346)

--- trunk/Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp	2012-03-28 00:49:33 UTC (rev 112345)
+++ trunk/Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp	2012-03-28 00:52:40 UTC (rev 112346)
@@ -104,6 +104,7 @@
 
 void TearDown()
 {
+webkit_support::UnregisterAllMockedURLs();
 m_webView->close();
 }
 
@@ -431,66 +432,23 @@
 EXPECT_TRUE(m_didFinishLoading);
 }
 
-// Test that a cross origin redirect response without CORS headers fails.
-TEST_F(AssociatedURLLoaderTest, RedirectCrossOriginWithAccessControlFailure)
+// Test a successful redirect and cross-origin load using CORS.
+// FIXME: Enable this when DocumentThreadableLoader supports cross-origin redirects.
+TEST_F(AssociatedURLLoaderTest, DISABLED_RedirectCrossOriginWithAccessControlSuccess)
 {
-GURL url = ""
-char redirect[] = "http://www.other.com/RedirectCrossOriginWithAccessControlFailure2.html";  // Cross-origin
-GURL redirectURL = GURL(redirect);
-
-WebURLRequest request;
-request.initialize();
-request.setURL(url);
-
-// Create a redirect response without CORS headers.
-m_expectedRedirectResponse = WebURLResponse();
-m_expectedRedirectResponse.initialize();
-m_expectedRedirectResponse.setMIMEType("text/html");
-m_expectedRedirectResponse.setHTTPStatusCode(301);
-m_expectedRedirectResponse.setHTTPHeaderField("Location", redirect);
-webkit_support::RegisterMockedURL(url, m_expectedRedirectResponse, m_frameFilePath);
-
-m_expectedNewRequest = WebURLRequest();
-m_expectedNewRequest.initialize();
-m_expectedNewRequest.setURL(redirectURL);
-
-m_expectedResponse = WebURLResponse();
-m_expectedResponse.initialize();
-m_expectedResponse.setMIMEType("text/html");
-m_expectedResponse.addHTTPHeaderField("access-control-allow-origin", "*");
-webkit_support::RegisterMockedURL(redirectURL, m_expectedResponse, m_frameFilePath);
-
-WebURLLoaderOptions options;
-options.crossOriginRequestPolicy = WebURLLoaderOptions::CrossOriginRequestPolicyUseAccessControl;
-m_expectedLoader = createAssociatedURLLoader(options);
-EXPECT_TRUE(m_expectedLoader);
-m_expectedLoader->loadAsynchronously(request, this);
-serveRequests();
-// We should not receive a notification for the redirect or any response.
-EXPECT_FALSE(m_willSendRequest);
-EXPECT_FALSE(m_didReceiveResponse);
-EXPECT_FALSE(m_didReceiveData);
-EXPECT_FALSE(m_didFail);
-}

[webkit-changes] [112345] branches/safari-534.56-branch/Source

[lforschler]

Title: [112345] branches/safari-534.56-branch/Source








Revision 112345
Author lforsch...@apple.com
Date 2012-03-27 17:49:33 -0700 (Tue, 27 Mar 2012)


Log Message
Versioning.

Modified Paths

branches/safari-534.56-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.56-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.56-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.56-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.56-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-534.56-branch/Source/_javascript_Core/Configurations/Version.xcconfig (112344 => 112345)

--- branches/safari-534.56-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2012-03-28 00:47:43 UTC (rev 112344)
+++ branches/safari-534.56-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2012-03-28 00:49:33 UTC (rev 112345)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 56;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.56-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (112344 => 112345)

--- branches/safari-534.56-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2012-03-28 00:47:43 UTC (rev 112344)
+++ branches/safari-534.56-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2012-03-28 00:49:33 UTC (rev 112345)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 56;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.56-branch/Source/WebCore/Configurations/Version.xcconfig (112344 => 112345)

--- branches/safari-534.56-branch/Source/WebCore/Configurations/Version.xcconfig	2012-03-28 00:47:43 UTC (rev 112344)
+++ branches/safari-534.56-branch/Source/WebCore/Configurations/Version.xcconfig	2012-03-28 00:49:33 UTC (rev 112345)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 56;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.56-branch/Source/WebKit/mac/Configurations/Version.xcconfig (112344 => 112345)

--- branches/safari-534.56-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2012-03-28 00:47:43 UTC (rev 112344)
+++ branches/safari-534.56-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2012-03-28 00:49:33 UTC (rev 112345)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 56;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.56-branch/Source/WebKit2/Configurations/Version.xcconfig (112344 => 112345)

--- branches/safari-534.56-branch/Source/WebKit2/Configurations/Version.xcconfig	2012-03-28 00:47:43 UTC (rev 112344)
+++ branches/safari-534.56-branch/Source/WebKit2/Configurations/Version.xcconfig	2012-03-28 00:49:33 UTC (rev 112345)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 56;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112344] trunk/LayoutTests

[dpranke]

Title: [112344] trunk/LayoutTests








Revision 112344
Author dpra...@chromium.org
Date 2012-03-27 17:47:43 -0700 (Tue, 27 Mar 2012)


Log Message
Add suppression for flaky plugins/netscape-dom-access-and-reload.html on mac and linux.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112343 => 112344)

--- trunk/LayoutTests/ChangeLog	2012-03-28 00:37:41 UTC (rev 112343)
+++ trunk/LayoutTests/ChangeLog	2012-03-28 00:47:43 UTC (rev 112344)
@@ -1,5 +1,13 @@
 2012-03-27  Dirk Pranke  
 
+Add suppression for flaky plugins/netscape-dom-access-and-reload.html on mac and linux.
+
+Unreviewed, expectations change.
+
+* platform/chromium/test_expectations.txt:
+
+2012-03-27  Dirk Pranke  
+
 Remove more passing tests, tighten overly broad expectations.
 
 Unreviewed, expectations change.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112343 => 112344)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 00:37:41 UTC (rev 112343)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 00:47:43 UTC (rev 112344)
@@ -4321,3 +4321,6 @@
 BUGWK82372 LINUX X86 RELEASE : css3/filters/custom/effect-custom-parameters.html = IMAGE
 
 BUGWK82269 DEBUG: media/track/track-delete-during-setup.html = CRASH
+
+// this test appears to consistently fail during the main run but usually passes on a retry.
+BUGWK82404 LINUX LEOPARD SNOWLEOPARD : plugins/netscape-dom-access-and-reload.html = PASS TEXT 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112343] trunk/Source

[commit-queue]

Title: [112343] trunk/Source








Revision 112343
Author commit-qu...@webkit.org
Date 2012-03-27 17:37:41 -0700 (Tue, 27 Mar 2012)


Log Message
[Coverity] Address some uninitialized constructor values.
https://bugs.webkit.org/show_bug.cgi?id=82376

Patch by Kausalya Madhusudhanan  on 2012-03-27
Reviewed by James Robinson.

Source/WebCore:

New tests are not required since I did not modify any code behavior.

* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
* inspector/InspectorIndexedDBAgent.h:
(InspectorIndexedDBAgent):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* storage/StorageTask.cpp:
(WebCore::StorageTask::StorageTask):

Source/WebKit/chromium:

New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.

* src/WebCompositorInputHandlerImpl.cpp:
(WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp
trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp
trunk/Source/WebCore/platform/chromium/DataTransferItemChromium.cpp
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
trunk/Source/WebCore/storage/StorageTask.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112342 => 112343)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 00:37:41 UTC (rev 112343)
@@ -1,3 +1,29 @@
+2012-03-27  Kausalya Madhusudhanan  
+
+[Coverity] Address some uninitialized constructor values.
+https://bugs.webkit.org/show_bug.cgi?id=82376
+
+Reviewed by James Robinson.
+
+New tests are not required since I did not modify any code behavior.
+
+* html/shadow/MediaControlRootElementChromium.cpp:
+(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
+* inspector/InspectorIndexedDBAgent.h:
+(InspectorIndexedDBAgent):
+* inspector/InspectorTimelineAgent.cpp:
+(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::ScrollingCoordinator):
+* platform/ScrollAnimatorNone.cpp:
+(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
+* platform/chromium/DataTransferItemChromium.cpp:
+(WebCore::DataTransferItemChromium::DataTransferItemChromium):
+* platform/graphics/skia/ImageBufferSkia.cpp:
+(WebCore::ImageBuffer::ImageBuffer):
+* storage/StorageTask.cpp:
+(WebCore::StorageTask::StorageTask):
+
 2012-03-27  Alexis Menard  
 
 Simplify CSSPropertyBorderSpacing parsing.


Modified: trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp (112342 => 112343)

--- trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp	2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp	2012-03-28 00:37:41 UTC (rev 112343)
@@ -58,6 +58,7 @@
 , m_panel(0)
 #if ENABLE(VIDEO_TRACK)
 , m_textDisplayContainer(0)
+, m_textTrackDisplay(0)
 #endif
 , m_opaque(true)
 , m_isMouseOverControls(false)


Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h (112342 => 112343)

--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h	2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h	2012-03-28 00:37:41 UTC (rev 112343)
@@ -70,7 +70,6 @@
 InjectedScriptManager* m_injectedScriptManager;
 InspectorPageAgent* m_pageAgent;
 RefPtr m_frontendProvider;
-bool m_enabled;
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (112342 => 112343)

--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2012-03-28 00:28:07 UTC (rev 112342)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2012-03-28 00:37:41 UTC (rev 112343)
@@ -436,6 +436,7 @@
 InspectorTimelineAgent::InspectorTimelineAgent(InstrumentingAgents* instrumentingAgents, InspectorState* state, InspectorType type)
 : InspectorBaseAgen

[webkit-changes] [112342] trunk/Source/WebKit/chromium

[dpranke]

Title: [112342] trunk/Source/WebKit/chromium








Revision 112342
Author dpra...@chromium.org
Date 2012-03-27 17:28:07 -0700 (Tue, 27 Mar 2012)


Log Message
Roll chromium DEPS to r129300.

Unreviewed, deps change.

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (112341 => 112342)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 00:27:27 UTC (rev 112341)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 00:28:07 UTC (rev 112342)
@@ -1,3 +1,11 @@
+2012-03-27  Dirk Pranke  
+
+Roll chromium DEPS to r129300.
+
+Unreviewed, deps change.
+
+* DEPS:
+
 2012-03-27  Bill Budge  
 
 AssociatedURLLoader does not support Cross Origin Redirects when using


Modified: trunk/Source/WebKit/chromium/DEPS (112341 => 112342)

--- trunk/Source/WebKit/chromium/DEPS	2012-03-28 00:27:27 UTC (rev 112341)
+++ trunk/Source/WebKit/chromium/DEPS	2012-03-28 00:28:07 UTC (rev 112342)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '128426'
+  'chromium_rev': '129300'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112341] trunk/Source/WebCore

[alexis . menard]

Title: [112341] trunk/Source/WebCore








Revision 112341
Author alexis.men...@openbossa.org
Date 2012-03-27 17:27:27 -0700 (Tue, 27 Mar 2012)


Log Message
Simplify CSSPropertyBorderSpacing parsing.
https://bugs.webkit.org/show_bug.cgi?id=82397

Reviewed by Benjamin Poulain.

Remove the local array of longhand properties as it doesn't really
bring much in this simple parsing algorithm.

No new tests, no functionality change intended.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112340 => 112341)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 00:21:13 UTC (rev 112340)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 00:27:27 UTC (rev 112341)
@@ -1,3 +1,18 @@
+2012-03-27  Alexis Menard  
+
+Simplify CSSPropertyBorderSpacing parsing.
+https://bugs.webkit.org/show_bug.cgi?id=82397
+
+Reviewed by Benjamin Poulain.
+
+Remove the local array of longhand properties as it doesn't really
+bring much in this simple parsing algorithm.
+
+No new tests, no functionality change intended.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseValue):
+
 2012-03-27  Anders Carlsson  
 
 Fix race condition when initializing the scrolling thread


Modified: trunk/Source/WebCore/css/CSSParser.cpp (112340 => 112341)

--- trunk/Source/WebCore/css/CSSParser.cpp	2012-03-28 00:21:13 UTC (rev 112340)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-03-28 00:27:27 UTC (rev 112341)
@@ -1538,19 +1538,17 @@
 return parseFontWeight(important);
 
 case CSSPropertyBorderSpacing: {
-const int properties[2] = { CSSPropertyWebkitBorderHorizontalSpacing,
-CSSPropertyWebkitBorderVerticalSpacing };
 if (num == 1) {
 ShorthandScope scope(this, CSSPropertyBorderSpacing);
-if (!parseValue(properties[0], important))
+if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important))
 return false;
 CSSValue* value = m_parsedProperties.last().value();
-addProperty(properties[1], value, important);
+addProperty(CSSPropertyWebkitBorderVerticalSpacing, value, important);
 return true;
 }
 else if (num == 2) {
 ShorthandScope scope(this, CSSPropertyBorderSpacing);
-if (!parseValue(properties[0], important) || !parseValue(properties[1], important))
+if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important) || !parseValue(CSSPropertyWebkitBorderVerticalSpacing, important))
 return false;
 return true;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112340] trunk/Source/WebCore

[andersca]

Title: [112340] trunk/Source/WebCore








Revision 112340
Author ander...@apple.com
Date 2012-03-27 17:21:13 -0700 (Tue, 27 Mar 2012)


Log Message
Fix race condition when initializing the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=82398


Reviewed by Sam Weinig.

Lock m_initializeRunLoopConditionMutex when assigning m_threadIdentifier since we're
asserting that it's not null in the scrolling thread.

* page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::createThreadIfNeeded):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingThread.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112339 => 112340)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 00:19:47 UTC (rev 112339)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 00:21:13 UTC (rev 112340)
@@ -1,3 +1,17 @@
+2012-03-27  Anders Carlsson  
+
+Fix race condition when initializing the scrolling thread
+https://bugs.webkit.org/show_bug.cgi?id=82398
+
+
+Reviewed by Sam Weinig.
+
+Lock m_initializeRunLoopConditionMutex when assigning m_threadIdentifier since we're
+asserting that it's not null in the scrolling thread.
+
+* page/scrolling/ScrollingThread.cpp:
+(WebCore::ScrollingThread::createThreadIfNeeded):
+
 2012-03-27  Luke Macpherson  
 
 Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging.


Modified: trunk/Source/WebCore/page/scrolling/ScrollingThread.cpp (112339 => 112340)

--- trunk/Source/WebCore/page/scrolling/ScrollingThread.cpp	2012-03-28 00:19:47 UTC (rev 112339)
+++ trunk/Source/WebCore/page/scrolling/ScrollingThread.cpp	2012-03-28 00:21:13 UTC (rev 112340)
@@ -66,11 +66,12 @@
 if (m_threadIdentifier)
 return;
 
-m_threadIdentifier = createThread(threadCallback, this, "WebCore: Scrolling");
-
 // Wait for the thread to initialize the run loop.
 {
 MutexLocker locker(m_initializeRunLoopConditionMutex);
+
+m_threadIdentifier = createThread(threadCallback, this, "WebCore: Scrolling");
+
 #if PLATFORM(MAC)
 while (!m_threadRunLoop)
 m_initializeRunLoopCondition.wait(m_initializeRunLoopConditionMutex);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112339] trunk/Source/WebKit/chromium

[bbudge]

Title: [112339] trunk/Source/WebKit/chromium








Revision 112339
Author bbu...@chromium.org
Date 2012-03-27 17:19:47 -0700 (Tue, 27 Mar 2012)


Log Message
AssociatedURLLoader does not support Cross Origin Redirects when using
Access Control.
https://bugs.webkit.org/show_bug.cgi?id=82354

AssociatedURLLoader's internal adapter now overrides didFailRedirectCheck,
which cancels the load, causing didFail to notify the client that the
load failed. AssociatedURLLoaderTest adds test cases for CORS requests
that receive redirects and pass or fail the redirect access check.

Reviewed by Adam Barth.

* src/AssociatedURLLoader.cpp:
(AssociatedURLLoader::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
(WebKit):
* tests/AssociatedURLLoaderTest.cpp:
(WebKit::TEST_F):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp
trunk/Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (112338 => 112339)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 00:16:52 UTC (rev 112338)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-28 00:19:47 UTC (rev 112339)
@@ -1,3 +1,23 @@
+2012-03-27  Bill Budge  
+
+AssociatedURLLoader does not support Cross Origin Redirects when using
+Access Control.
+https://bugs.webkit.org/show_bug.cgi?id=82354
+
+AssociatedURLLoader's internal adapter now overrides didFailRedirectCheck,
+which cancels the load, causing didFail to notify the client that the
+load failed. AssociatedURLLoaderTest adds test cases for CORS requests
+that receive redirects and pass or fail the redirect access check.
+
+Reviewed by Adam Barth.
+
+* src/AssociatedURLLoader.cpp:
+(AssociatedURLLoader::ClientAdapter):
+(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
+(WebKit):
+* tests/AssociatedURLLoaderTest.cpp:
+(WebKit::TEST_F):
+
 2012-03-27  Dana Jansens  
 
 [chromium] Unknown transforms should be treated as non-axis aligned on main thread


Modified: trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp (112338 => 112339)

--- trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp	2012-03-28 00:16:52 UTC (rev 112338)
+++ trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp	2012-03-28 00:19:47 UTC (rev 112339)
@@ -140,6 +140,7 @@
 virtual void didReceiveCachedMetadata(const char*, int /*dataLength*/);
 virtual void didFinishLoading(unsigned long /*identifier*/, double /*finishTime*/);
 virtual void didFail(const ResourceError&);
+virtual void didFailRedirectCheck();
 
 virtual bool isDocumentThreadableLoaderClient() { return true; }
 
@@ -263,6 +264,11 @@
 notifyError(&m_errorTimer);
 }
 
+void AssociatedURLLoader::ClientAdapter::didFailRedirectCheck()
+{
+m_loader->cancel();
+}
+
 void AssociatedURLLoader::ClientAdapter::setDelayedError(const ResourceError& error)
 {
 didFail(error);


Modified: trunk/Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp (112338 => 112339)

--- trunk/Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp	2012-03-28 00:16:52 UTC (rev 112338)
+++ trunk/Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp	2012-03-28 00:19:47 UTC (rev 112339)
@@ -104,7 +104,6 @@
 
 void TearDown()
 {
-webkit_support::UnregisterAllMockedURLs();
 m_webView->close();
 }
 
@@ -432,23 +431,66 @@
 EXPECT_TRUE(m_didFinishLoading);
 }
 
-// Test a successful redirect and cross-origin load using CORS.
-// FIXME: Enable this when DocumentThreadableLoader supports cross-origin redirects.
-TEST_F(AssociatedURLLoaderTest, DISABLED_RedirectCrossOriginWithAccessControlSuccess)
+// Test that a cross origin redirect response without CORS headers fails.
+TEST_F(AssociatedURLLoaderTest, RedirectCrossOriginWithAccessControlFailure)
 {
+GURL url = ""
+char redirect[] = "http://www.other.com/RedirectCrossOriginWithAccessControlFailure2.html";  // Cross-origin
+GURL redirectURL = GURL(redirect);
+
+WebURLRequest request;
+request.initialize();
+request.setURL(url);
+
+// Create a redirect response without CORS headers.
+m_expectedRedirectResponse = WebURLResponse();
+m_expectedRedirectResponse.initialize();
+m_expectedRedirectResponse.setMIMEType("text/html");
+m_expectedRedirectResponse.setHTTPStatusCode(301);
+m_expectedRedirectResponse.setHTTPHeaderField("Location", redirect);
+webkit_support::RegisterMockedURL(url, m_expectedRedirectResponse, m_frameFilePath);
+
+m_expectedNewRequest = WebURLRequest();
+m_expectedNewRequest.initialize();
+m_expectedNewRequest.setURL(redirectURL);
+
+m_expectedResponse = WebURLResponse();
+m_expectedResponse.initialize();
+m_expectedResponse.setMIMEType("text/html");
+m_expectedResponse.addHTTPHeaderField("access-control-allow-ori

[webkit-changes] [112338] trunk/Source/WebKit2

[andersca]

Title: [112338] trunk/Source/WebKit2








Revision 112338
Author ander...@apple.com
Date 2012-03-27 17:16:52 -0700 (Tue, 27 Mar 2012)


Log Message
Plug-ins using the Core Animation drawing model should work when hosting the layer tree in the window server
https://bugs.webkit.org/show_bug.cgi?id=82387


Reviewed by Sam Weinig.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::initialize):
Remove m_pluginCreationParameters; it was used by the old NPRuntime short-circuit code.
Make platformInitialize take creation parameters.

* PluginProcess/PluginControllerProxy.messages.in:
Add SetLayerHostingMode message.

* PluginProcess/gtk/PluginControllerProxyGtk.cpp:
(WebKit::PluginControllerProxy::platformInitialize):
Make platformInitialize take creation parameters.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::platformInitialize):
Call updateLayerHostingContext.

(WebKit::PluginControllerProxy::setLayerHostingMode):
Call updateLayerHostingContext and send back the new context ID.

(WebKit::PluginControllerProxy::updateLayerHostingContext):
Create a new LayerHostingContext given the layer hosting mode.

* PluginProcess/qt/PluginControllerProxyQt.cpp:
(WebKit::PluginControllerProxy::platformInitialize):
Make platformInitialize take creation parameters.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::setLayerHostingMode):
Add stub.

* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::makeRenderLayer):
Add helper function for creating a new render layer.

(WebKit::PluginProxy::pluginLayer):
Call makeRenderLayer.

(WebKit::PluginProxy::setLayerHostingMode):
Send a message to the plug-in process.

(WebKit::PluginProxy::setLayerHostingContextID):
Update the context ID and make a new render layer.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::setLayerHostingMode):
Add stub.
* WebProcess/Plugins/PDF/BuiltInPDFView.h:

* WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):
* WebProcess/Plugins/Plugin.h:
Add the layer hosting mode as a parameter. Add a new setLayerHostingMode pure virtual member function.

* WebProcess/Plugins/PluginProxy.messages.in:
Add a SetLayerHostingContextID message.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setLayerHostingMode):
Call down to the plug-in.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
Set the layer hosting mode of the page.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Initialize m_layerHostingMode to false.

* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::layerHostingMode):
Add m_layerHostingMode and a getter.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):
Call WebPage::setLayerHostingMode.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setLayerHostingMode):
Tell all plug-ins that the layer hosting mode changed.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.messages.in
trunk/Source/WebKit2/PluginProcess/gtk/PluginControllerProxyGtk.cpp
trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm
trunk/Source/WebKit2/PluginProcess/qt/PluginControllerProxyQt.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (112337 => 112338)

--- trunk/Source/WebKit2/ChangeLog	2012-03-28 00:12:57 UTC (rev 112337)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-28 00:16:52 UTC (rev 112338)
@@ -1,3 +1,94 @@
+2012-03-27  Anders Carlsson  
+
+Plug-ins using the Core Animation drawing model should work when hosting the layer tree in the window server
+https://bugs.webkit.org/show_bug.cgi?id=82387

[webkit-changes] [112337] trunk/Tools

[dpranke]

Title: [112337] trunk/Tools








Revision 112337
Author dpra...@chromium.org
Date 2012-03-27 17:12:57 -0700 (Tue, 27 Mar 2012)


Log Message
new-run-webkit-tests: suppress debug output from run-safari on results file
https://bugs.webkit.org/show_bug.cgi?id=82400

Reviewed by Ryosuke Niwa.

Send the run-safari output to /dev/null rather than the console.

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.show_results_html_file):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py




Diff

Modified: trunk/Tools/ChangeLog (112336 => 112337)

--- trunk/Tools/ChangeLog	2012-03-28 00:12:30 UTC (rev 112336)
+++ trunk/Tools/ChangeLog	2012-03-28 00:12:57 UTC (rev 112337)
@@ -1,3 +1,15 @@
+2012-03-27  Dirk Pranke  
+
+new-run-webkit-tests: suppress debug output from run-safari on results file
+https://bugs.webkit.org/show_bug.cgi?id=82400
+
+Reviewed by Ryosuke Niwa.
+
+Send the run-safari output to /dev/null rather than the console.
+
+* Scripts/webkitpy/layout_tests/port/mac.py:
+(MacPort.show_results_html_file):
+
 2012-03-27  Simon Fraser  
 
 Improve error reporting in run-_javascript_core-tests


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (112336 => 112337)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py	2012-03-28 00:12:30 UTC (rev 112336)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py	2012-03-28 00:12:57 UTC (rev 112337)
@@ -27,6 +27,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import logging
+import os
 import re
 import subprocess
 import time
@@ -146,7 +147,8 @@
 # We don't use self._run_script() because we don't want to wait for the script
 # to exit and we want the output to show up on stdout in case there are errors
 # launching the browser.
-self._executive.popen([self._config.script_path('run-safari')] + self._arguments_for_configuration() + ['--no-saved-state', '-NSOpen', results_filename], cwd=self._config.webkit_base_dir())
+self._executive.popen([self._config.script_path('run-safari')] + self._arguments_for_configuration() + ['--no-saved-state', '-NSOpen', results_filename],
+cwd=self._config.webkit_base_dir(), stdout=file(os.devnull), stderr=file(os.devnull))
 
 # FIXME: The next two routines turn off the http locking in order
 # to work around failures on the bots caused when the slave restarts.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112336] trunk/Source/WebCore

[macpherson]

Title: [112336] trunk/Source/WebCore








Revision 112336
Author macpher...@chromium.org
Date 2012-03-27 17:12:30 -0700 (Tue, 27 Mar 2012)


Log Message
Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging.
https://bugs.webkit.org/show_bug.cgi?id=82393

Reviewed by Eric Seidel.

No new tests / adding assetions only.

* css/LengthFunctions.cpp:
(WebCore::valueForLength):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/LengthFunctions.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112335 => 112336)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 00:05:13 UTC (rev 112335)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 00:12:30 UTC (rev 112336)
@@ -1,3 +1,17 @@
+2012-03-27  Luke Macpherson  
+
+Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging.
+https://bugs.webkit.org/show_bug.cgi?id=82393
+
+Reviewed by Eric Seidel.
+
+No new tests / adding assetions only.
+
+* css/LengthFunctions.cpp:
+(WebCore::valueForLength):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
+
 2012-03-27  Tony Chang  
 
 use the correct size when computing flex-pack space


Modified: trunk/Source/WebCore/css/LengthFunctions.cpp (112335 => 112336)

--- trunk/Source/WebCore/css/LengthFunctions.cpp	2012-03-28 00:05:13 UTC (rev 112335)
+++ trunk/Source/WebCore/css/LengthFunctions.cpp	2012-03-28 00:12:30 UTC (rev 112336)
@@ -80,9 +80,13 @@
 return minimumValueForLength(length, maximumValue, renderView, roundPercentages);
 case Auto:
 return maximumValue;
+// multiple assertions are used below to provide more useful debug output.
 case Relative:
+ASSERT_NOT_REACHED();
 case Intrinsic:
+ASSERT_NOT_REACHED();
 case MinIntrinsic:
+ASSERT_NOT_REACHED();
 case Undefined:
 ASSERT_NOT_REACHED();
 return 0;


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (112335 => 112336)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2012-03-28 00:05:13 UTC (rev 112335)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2012-03-28 00:12:30 UTC (rev 112336)
@@ -1845,6 +1845,8 @@
 else
 logicalWidth = styleToUse->logicalMaxWidth();
 
+ASSERT(!logicalWidth.isUndefined());
+
 if (logicalWidth.isIntrinsicOrAuto()) {
 RenderView* renderView = view();
 LayoutUnit marginStart = minimumValueForLength(styleToUse->marginStart(), availableLogicalWidth, renderView);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112334] trunk/LayoutTests

[dpranke]

Title: [112334] trunk/LayoutTests








Revision 112334
Author dpra...@chromium.org
Date 2012-03-27 17:02:34 -0700 (Tue, 27 Mar 2012)


Log Message
Remove more passing tests, tighten overly broad expectations.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112333 => 112334)

--- trunk/LayoutTests/ChangeLog	2012-03-27 23:56:11 UTC (rev 112333)
+++ trunk/LayoutTests/ChangeLog	2012-03-28 00:02:34 UTC (rev 112334)
@@ -1,3 +1,11 @@
+2012-03-27  Dirk Pranke  
+
+Remove more passing tests, tighten overly broad expectations.
+
+Unreviewed, expectations change.
+
+* platform/chromium/test_expectations.txt:
+
 2012-03-27  Tony Chang  
 
 use the correct size when computing flex-pack space


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112333 => 112334)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-27 23:56:11 UTC (rev 112333)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-28 00:02:34 UTC (rev 112334)
@@ -1225,9 +1225,6 @@
 BUGWK34714 : svg/text/select-textLength-spacing-squeeze-2.svg = IMAGE IMAGE+TEXT
 
 // New test, needs a rebaseline
-BUGWK77903 MAC : svg/repaint/inner-svg-change-viewBox-contract.svg = IMAGE IMAGE+TEXT
-
-// New test, needs a rebaseline
 BUGWK78631 : svg/dom/SVGLocatable-getCTM-svg-root.html = IMAGE
 
 // Still failing on LinuxC. Possibly an out-of-date baseline that was not noticed
@@ -1246,47 +1243,47 @@
 // Appears elsewhere commented
 BUGWK79568 : svg/W3C-SVG-1.1/animate-elem-80-t.svg = FAIL
 // Appears elsewhere commented
-BUGWK79568 : svg/W3C-SVG-1.1/struct-symbol-01-b.svg = FAIL
+BUGWK79568 WIN LINUX : svg/W3C-SVG-1.1/struct-symbol-01-b.svg = FAIL
 BUGWK79568 : svg/W3C-SVG-1.1/struct-use-01-t.svg = FAIL
-BUGWK79568 LINUX : svg/W3C-SVG-1.1/animate-elem-77-t.svg = IMAGE
-BUGWK79568 MAC : svg/W3C-SVG-1.1/animate-elem-77-t.svg = TEXT
-BUGWK79568 : svg/clip-path/clip-path-text-and-shape.svg = TEXT
-BUGWK79568 : svg/clip-path/clip-path-with-text-clipped.svg = TEXT
+BUGWK79568 WIN LINUX : svg/clip-path/clip-path-text-and-shape.svg = TEXT
+BUGWK79568 WIN LINUX : svg/clip-path/clip-path-with-text-clipped.svg = TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-41-t.svg = IMAGE+TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-36-t.svg = TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-46-t.svg = IMAGE+TEXT TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-39-t.svg = TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-61-t.svg = IMAGE+TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-40-t.svg = TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-63-t.svg = IMAGE+TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-41-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-64-t.svg = IMAGE+TEXT
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-65-t.svg = IMAGE+TEXT
+BUGWK75968 WIN SNOWLEOPARD : svg/W3C-SVG-1.1/animate-elem-46-t.svg = IMAGE+TEXT TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-66-t.svg = IMAGE+TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-61-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-67-t.svg = IMAGE+TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-63-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-68-t.svg = IMAGE+TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-64-t.svg = IMAGE+TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-65-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-69-t.svg = IMAGE+TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-66-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-70-t.svg = IMAGE+TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-67-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/filters-morph-01-f.svg = IMAGE+TEXT IMAGE
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-68-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/text-path-01-b.svg = IMAGE+TEXT
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-69-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/text-text-05-t.svg = IMAGE+TEXT TEXT
-// This may be unrelated.
-BUGWK75968 LION : svg/css/group-with-shadow.svg = IMAGE
+BUGWK75968 WIN : svg/W3C-SVG-1.1/animate-elem-70-t.svg = IMAGE+TEXT
 // Appears elsewhere commented
-BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-36-t.svg = TEXT
+BUGWK79568 LINUX : svg/W3C-SVG-1.1/animate-elem-77-t.svg = IMAGE
+BUGWK79568 LEOPARD SNOWLEOPARD : svg/W3C-SVG-1.1/animate-elem-77-t.svg = TEXT
+BUGWK75968 : svg/W3C-SVG-1.1

[webkit-changes] [112333] trunk

[tony]

Title: [112333] trunk








Revision 112333
Author t...@chromium.org
Date 2012-03-27 16:56:11 -0700 (Tue, 27 Mar 2012)


Log Message
use the correct size when computing flex-pack space
https://bugs.webkit.org/show_bug.cgi?id=82378

Reviewed by Ojan Vafai.

Source/WebCore:

Fix 2 bugs:
- We weren't properly updating available space before computing
  packing space. If a min/max is not hit, we still need to adjust
  the available free space.
- For flex-pack:end, we need to put the overflow in the start edge.

New test cases in css3/flexbox/flex-pack.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
(WebCore::initialPackingOffset):

LayoutTests:

* css3/flexbox/flex-pack-expected.txt:
* css3/flexbox/flex-pack.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/flex-pack-expected.txt
trunk/LayoutTests/css3/flexbox/flex-pack.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (112332 => 112333)

--- trunk/LayoutTests/ChangeLog	2012-03-27 23:49:04 UTC (rev 112332)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 23:56:11 UTC (rev 112333)
@@ -1,3 +1,13 @@
+2012-03-27  Tony Chang  
+
+use the correct size when computing flex-pack space
+https://bugs.webkit.org/show_bug.cgi?id=82378
+
+Reviewed by Ojan Vafai.
+
+* css3/flexbox/flex-pack-expected.txt:
+* css3/flexbox/flex-pack.html:
+
 2012-03-27  Dirk Pranke  
 
 Remove a bunch of lines that are no longer failing.


Modified: trunk/LayoutTests/css3/flexbox/flex-pack-expected.txt (112332 => 112333)

--- trunk/LayoutTests/css3/flexbox/flex-pack-expected.txt	2012-03-27 23:49:04 UTC (rev 112332)
+++ trunk/LayoutTests/css3/flexbox/flex-pack-expected.txt	2012-03-27 23:56:11 UTC (rev 112333)
@@ -8,3 +8,8 @@
 PASS
 PASS
 PASS
+PASS
+PASS
+PASS
+PASS
+PASS


Modified: trunk/LayoutTests/css3/flexbox/flex-pack.html (112332 => 112333)

--- trunk/LayoutTests/css3/flexbox/flex-pack.html	2012-03-27 23:49:04 UTC (rev 112332)
+++ trunk/LayoutTests/css3/flexbox/flex-pack.html	2012-03-27 23:56:11 UTC (rev 112333)
@@ -49,12 +49,29 @@
   
 
 
+
+  
+  
+  
+
+
+
+
+  
+
+
 
   
   
   
 
 
+
+  
+  
+  
+
+
 
 
   
@@ -71,6 +88,11 @@
   
 
 
+
+
+  
+
+
 
 
 
@@ -88,5 +110,12 @@
   
 
 
+
+
+  
+  
+  
+
+
 
 


Modified: trunk/Source/WebCore/ChangeLog (112332 => 112333)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 23:49:04 UTC (rev 112332)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 23:56:11 UTC (rev 112333)
@@ -1,3 +1,22 @@
+2012-03-27  Tony Chang  
+
+use the correct size when computing flex-pack space
+https://bugs.webkit.org/show_bug.cgi?id=82378
+
+Reviewed by Ojan Vafai.
+
+Fix 2 bugs:
+- We weren't properly updating available space before computing
+  packing space. If a min/max is not hit, we still need to adjust
+  the available free space.
+- For flex-pack:end, we need to put the overflow in the start edge.
+
+New test cases in css3/flexbox/flex-pack.html
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
+(WebCore::initialPackingOffset):
+
 2012-03-27  Dana Jansens  
 
 [chromium] Unknown transforms should be treated as non-axis aligned on main thread


Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (112332 => 112333)

--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2012-03-27 23:49:04 UTC (rev 112332)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2012-03-27 23:56:11 UTC (rev 112333)
@@ -769,6 +769,7 @@
 childSizes.clear();
 LayoutUnit flexboxAvailableContentExtent = mainAxisContentExtent();
 LayoutUnit totalViolation = 0;
+LayoutUnit usedFreeSpace = 0;
 WTF::Vector minViolations;
 WTF::Vector maxViolations;
 for (size_t i = 0; i < children.size(); ++i) {
@@ -781,7 +782,8 @@
 if (inflexibleItems.contains(child))
 childSizes.append(inflexibleItems.get(child));
 else {
-LayoutUnit childSize = preferredMainAxisContentExtentForChild(child);
+LayoutUnit preferredChildSize = preferredMainAxisContentExtentForChild(child);
+LayoutUnit childSize = preferredChildSize;
 if (availableFreeSpace > 0 && totalPositiveFlexibility > 0 && flexSign == PositiveFlexibility)
 childSize += lroundf(availableFreeSpace * positiveFlexForChild(child) / totalPositiveFlexibility);
 else if (availableFreeSpace < 0 && totalNegativeFlexibility > 0  && flexSign == NegativeFlexibility)
@@ -789,6 +791,7 @@
 
 LayoutUnit adjustedChildSize = adjustChildSizeForMinAndMax(child, childSize, flexboxAvailableContentExtent);
 childSizes.append(adjustedChildSize);
+usedFreeSpace += adjustedChildSize - preferredChildSize;
 
 LayoutUnit violation = adjustedChildS

[webkit-changes] [112332] trunk/Source

[commit-queue]

Title: [112332] trunk/Source








Revision 112332
Author commit-qu...@webkit.org
Date 2012-03-27 16:49:04 -0700 (Tue, 27 Mar 2012)


Log Message
[chromium] Unknown transforms should be treated as non-axis aligned on main thread
https://bugs.webkit.org/show_bug.cgi?id=82370

Patch by Dana Jansens  on 2012-03-27
Reviewed by Adrienne Walker.

Source/WebCore:

On main thread, animating transforms have "unknown" values as they are changing
out of sync on the impl thread. So treat them as non-axis-aligned since they
may be, when deciding to create a render surface.

In addition, since surfaces are cheap on main thread, create one for all layers
with animating transforms and a drawing descendant, as this allows paint culling
within the layer's subtree (the animated transform won't affect drawTransforms
inside the subtree).

Also renamed the layerIsInAnimatingSubtreeFor* to animatingTransformTo*.
The old name made me pause and think what it meant and I'm the one who
created it. Hopefully this is more clear.

Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::transformToParentIsKnown):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112331 => 112332)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 23:39:44 UTC (rev 112331)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 23:49:04 UTC (rev 112332)
@@ -1,3 +1,31 @@
+2012-03-27  Dana Jansens  
+
+[chromium] Unknown transforms should be treated as non-axis aligned on main thread
+https://bugs.webkit.org/show_bug.cgi?id=82370
+
+Reviewed by Adrienne Walker.
+
+On main thread, animating transforms have "unknown" values as they are changing
+out of sync on the impl thread. So treat them as non-axis-aligned since they
+may be, when deciding to create a render surface.
+
+In addition, since surfaces are cheap on main thread, create one for all layers
+with animating transforms and a drawing descendant, as this allows paint culling
+within the layer's subtree (the animated transform won't affect drawTransforms
+inside the subtree).
+
+Also renamed the layerIsInAnimatingSubtreeFor* to animatingTransformTo*.
+The old name made me pause and think what it meant and I'm the one who
+created it. Hopefully this is more clear.
+
+Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy
+
+* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
+(WebCore::transformToParentIsKnown):
+(WebCore):
+(WebCore::subtreeShouldRenderToSeparateSurface):
+(WebCore::calculateDrawTransformsAndVisibilityInternal):
+
 2012-03-27  Dirk Pranke  
 
 Re-land r112277; reverting it doesn't seem to have fixed anything.


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp (112331 => 112332)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp	2012-03-27 23:39:44 UTC (rev 112331)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp	2012-03-27 23:49:04 UTC (rev 112332)
@@ -139,6 +139,16 @@
 return layer->opacity() == 1 && !layer->opacityIsAnimating();
 }
 
+static inline bool transformToParentIsKnown(CCLayerImpl*)
+{
+return true;
+}
+
+static inline bool transformToParentIsKnown(LayerChromium* layer)
+{
+return !layer->transformIsAnimating();
+}
+
 template
 static bool subtreeShouldRenderToSeparateSurface(LayerType* layer, bool axisAlignedWithRespectToParent)
 {
@@ -171,6 +181,12 @@
 if (layer->parent() && layer->parent()->preserves3D() && !layer->preserves3D() && descendantDrawsContent)
 return true;
 
+// On the main thread side, animating transforms are unknown, and may cause a RenderSurface on the impl side.
+// Since they are cheap, we create a rendersurface for all animating transforms to cover these cases, and so
+// that we can consider descendants as not animating relative to their target to aid culling.
+if (!transformToParentIsKnown(layer) && descendantDrawsContent)
+return true;
+
 // If the layer clips its descendants but it is not axis-aligned with respect to its parent.
 if (layer->masksToBounds() && !axisAlignedWithRespectToParent && descendantDrawsContent)
 return true;
@@ -315,11 +331,11 @@
 TransformationMatrix combinedTransform = parentMatrix;
 combinedTransform = combinedTransform.multiply(layerLocalTransform);
 
-bo

[webkit-changes] [112331] tags/Safari-534.56.3/

[lforschler]

Title: [112331] tags/Safari-534.56.3/








Revision 112331
Author lforsch...@apple.com
Date 2012-03-27 16:39:44 -0700 (Tue, 27 Mar 2012)


Log Message
New tag.

Added Paths

tags/Safari-534.56.3/




Diff

Property changes: tags/Safari-534.56.3



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112330] branches/subpixellayout/Source/WebCore/rendering/svg/ SVGImageBufferTools.cpp

[eae]

Title: [112330] branches/subpixellayout/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp








Revision 112330
Author e...@chromium.org
Date 2012-03-27 16:25:25 -0700 (Tue, 27 Mar 2012)


Log Message
Update SVGImageBufferTools on branch to match trunk.

Removed Paths

branches/subpixellayout/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp




Diff

Deleted: branches/subpixellayout/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp (112329 => 112330)

--- branches/subpixellayout/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp	2012-03-27 23:21:14 UTC (rev 112329)
+++ branches/subpixellayout/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp	2012-03-27 23:25:25 UTC (rev 112330)
@@ -1,165 +0,0 @@
-/*
- * Copyright (C) Research In Motion Limited 2010. All rights reserved.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#include "config.h"
-
-#if ENABLE(SVG)
-#include "SVGImageBufferTools.h"
-
-#include "FrameView.h"
-#include "GraphicsContext.h"
-#include "RenderObject.h"
-#include "RenderSVGContainer.h"
-#include "RenderSVGRoot.h"
-
-static int kMaxImageBufferSize = 4096;
-
-namespace WebCore {
-
-static AffineTransform& currentContentTransformation()
-{
-DEFINE_STATIC_LOCAL(AffineTransform, s_currentContentTransformation, ());
-return s_currentContentTransformation;
-}
-
-void SVGImageBufferTools::calculateTransformationToOutermostSVGCoordinateSystem(const RenderObject* renderer, AffineTransform& absoluteTransform)
-{
-const RenderObject* current = renderer;
-ASSERT(current);
-
-absoluteTransform = currentContentTransformation();
-while (current) {
-absoluteTransform = current->localToParentTransform() * absoluteTransform;
-if (current->isSVGRoot())
-break;
-current = current->parent();
-}
-}
-
-bool SVGImageBufferTools::createImageBuffer(const FloatRect& targetRect, const AffineTransform& absoluteTransform, OwnPtr& imageBuffer, ColorSpace colorSpace, RenderingMode renderingMode)
-{
-IntRect paintRect = calculateImageBufferRect(targetRect, absoluteTransform);
-// Don't create empty ImageBuffers.
-if (paintRect.isEmpty())
-return false;
-
-IntSize clampedSize = clampedAbsoluteSize(paintRect.size());
-OwnPtr image = ImageBuffer::create(clampedSize, 1, colorSpace, renderingMode);
-if (!image)
-return false;
-
-GraphicsContext* imageContext = image->context();
-ASSERT(imageContext);
-
-// This is done in absolute coordinates.
-imageContext->translate(-paintRect.x(), -paintRect.y());
-
-imageContext->concatCTM(absoluteTransform);
-
-// This happens in local coordinates.
-imageContext->scale(FloatSize(static_cast(clampedSize.width()) / paintRect.width(),
-  static_cast(clampedSize.height()) / paintRect.height()));
-
-imageBuffer = image.release();
-return true;
-}
-
-bool SVGImageBufferTools::createImageBufferForPattern(const FloatRect& absoluteTargetRect, const FloatRect& clampedAbsoluteTargetRect, OwnPtr& imageBuffer, ColorSpace colorSpace, RenderingMode renderingMode)
-{
-IntSize imageSize(roundedIntSize(clampedAbsoluteTargetRect.size()));
-IntSize unclampedImageSize(roundedIntSize(absoluteTargetRect.size()));
-
-// Don't create empty ImageBuffers.
-if (imageSize.isEmpty())
-return false;
-
-OwnPtr image = ImageBuffer::create(imageSize, 1, colorSpace, renderingMode);
-if (!image)
-return false;
-
-GraphicsContext* imageContext = image->context();
-ASSERT(imageContext);
-
-// Compensate rounding effects, as the absolute target rect is using floating-point numbers and the image buffer size is integer.
-imageContext->scale(FloatSize(unclampedImageSize.width() / absoluteTargetRect.width(), unclampedImageSize.height() / absoluteTargetRect.height()));
-
-imageBuffer = image.release();
-return true;
-}
-
-void SVGImageBufferTools::renderSubtreeToImageBuffer(ImageBuffer* image, RenderObject* item, const AffineTransform& subtreeContentTransformation)
-{
-ASSERT(item);
-ASSERT(image);
-ASSERT(image->context());
-
-PaintInfo info(image->context(), IntRect(PaintInfo::infiniteRect()), PaintPhaseForeground, 0, 0, 0, 0);
-
-

[webkit-changes] [112329] trunk/Source/WebCore

[dpranke]

Title: [112329] trunk/Source/WebCore








Revision 112329
Author dpra...@chromium.org
Date 2012-03-27 16:21:14 -0700 (Tue, 27 Mar 2012)


Log Message
Re-land r112277; reverting it doesn't seem to have fixed anything.

Unreviewed, build fix.

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):
* xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp
trunk/Source/WebCore/xml/XMLErrors.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112328 => 112329)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 23:12:21 UTC (rev 112328)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 23:21:14 UTC (rev 112329)
@@ -1,3 +1,17 @@
+2012-03-27  Dirk Pranke  
+
+Re-land r112277; reverting it doesn't seem to have fixed anything.
+
+Unreviewed, build fix.
+
+* svg/SVGUseElement.cpp:
+(WebCore::SVGUseElement::insertedIntoDocument):
+(WebCore::SVGUseElement::svgAttributeChanged):
+(WebCore::SVGUseElement::willRecalcStyle):
+(WebCore::SVGUseElement::finishParsingChildren):
+* xml/XMLErrors.cpp:
+(WebCore::XMLErrors::insertErrorMessageBlock):
+
 2012-03-27  Dana Jansens  
 
 [chromium] Rename opaqueContentsRegion() to visibleContentOpaqueRegion()


Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (112328 => 112329)

--- trunk/Source/WebCore/svg/SVGUseElement.cpp	2012-03-27 23:12:21 UTC (rev 112328)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp	2012-03-27 23:21:14 UTC (rev 112329)
@@ -181,7 +181,8 @@
 SVGStyledTransformableElement::insertedIntoDocument();
 ASSERT(!m_targetElementInstance || !isWellFormedDocument(document()));
 ASSERT(!hasPendingResources() || !isWellFormedDocument(document()));
-buildPendingResource();
+if (!m_wasInsertedByParser)
+buildPendingResource();
 SVGExternalResourcesRequired::insertedIntoDocument(this);
 }
 
@@ -252,7 +253,8 @@
 m_cachedDocument->removeClient(this);
 m_cachedDocument = 0;
 }
-buildPendingResource();
+if (!m_wasInsertedByParser)
+buildPendingResource();
 return;
 }
 
@@ -270,7 +272,7 @@
 
 bool SVGUseElement::willRecalcStyle(StyleChange)
 {
-if (m_needsShadowTreeRecreation && renderer() && needsStyleRecalc())
+if (!m_wasInsertedByParser && m_needsShadowTreeRecreation && renderer() && needsStyleRecalc())
 buildPendingResource();
 return true;
 }
@@ -953,6 +955,10 @@
 {
 SVGStyledTransformableElement::finishParsingChildren();
 SVGExternalResourcesRequired::finishParsingChildren();
+if (m_wasInsertedByParser) {
+buildPendingResource();
+m_wasInsertedByParser = false;
+}
 }
 
 }


Modified: trunk/Source/WebCore/xml/XMLErrors.cpp (112328 => 112329)

--- trunk/Source/WebCore/xml/XMLErrors.cpp	2012-03-27 23:12:21 UTC (rev 112328)
+++ trunk/Source/WebCore/xml/XMLErrors.cpp	2012-03-27 23:21:14 UTC (rev 112329)
@@ -144,11 +144,10 @@
 body->parserAddChild(documentElement);
 m_document->parserAddChild(rootElement.get());
 
-if (m_document->attached()) {
-// rootElement shouldn't be attached right now, but in some cases might be.
-// See https://bugs.webkit.org/show_bug.cgi?id=81985
+if (m_document->attached())
+// In general, rootElement shouldn't be attached right now, but it will be if there is a style element
+// in the SVG content.
 rootElement->reattach();
-}
 
 documentElement = body.get();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112327] trunk/Source

[commit-queue]

Title: [112327] trunk/Source








Revision 112327
Author commit-qu...@webkit.org
Date 2012-03-27 15:46:36 -0700 (Tue, 27 Mar 2012)


Log Message
[chromium] Rename opaqueContentsRegion() to visibleContentOpaqueRegion()
https://bugs.webkit.org/show_bug.cgi?id=81689

Patch by Dana Jansens  on 2012-03-27
Reviewed by Adrienne Walker.

Source/WebCore:

The return value from this function is a region of opaque pixels in the
layer's content space that intersect with its visible rect. Rather than
adding a comment to this effect, renaming the method to make it clear.

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::visibleContentOpaqueRegion):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::TestLayerChromium::opaqueVisibleContents):
* tests/CCOcclusionTrackerTest.cpp:
(WebCore::TestContentLayerChromium::opaqueVisibleContents):
(WebCore::TestContentLayerImpl::opaqueVisibleContents):
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
trunk/Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp
trunk/Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112326 => 112327)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 22:29:21 UTC (rev 112326)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 22:46:36 UTC (rev 112327)
@@ -1,3 +1,28 @@
+2012-03-27  Dana Jansens  
+
+[chromium] Rename opaqueContentsRegion() to visibleContentOpaqueRegion()
+https://bugs.webkit.org/show_bug.cgi?id=81689
+
+Reviewed by Adrienne Walker.
+
+The return value from this function is a region of opaque pixels in the
+layer's content space that intersect with its visible rect. Rather than
+adding a comment to this effect, renaming the method to make it clear.
+
+* platform/graphics/chromium/LayerChromium.h:
+(WebCore::LayerChromium::visibleContentOpaqueRegion):
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
+* platform/graphics/chromium/TiledLayerChromium.h:
+* platform/graphics/chromium/cc/CCLayerImpl.h:
+(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
+* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
+(WebCore::computeOcclusionBehindLayer):
+* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
+(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):
+* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
+(CCTiledLayerImpl):
+
 2012-03-27  James Robinson  
 
 Scrollable plugins not registered properly in ScrollingCoordinator


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h (112326 => 112327)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h	2012-03-27 22:29:21 UTC (rev 112326)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h	2012-03-27 22:46:36 UTC (rev 112327)
@@ -246,7 +246,7 @@
 
 void notifyAnimationStarted(const CCAnimationStartedEvent&, double wallClockTime);
 
-virtual Region opaqueContentsRegion() const { return Region(); };
+virtual Region visibleContentOpaqueRegion() const { return Region(); };
 
 virtual ScrollbarLayerChromium* toScrollbarLayerChromium() { return 0; }
 


Modified: trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp (112326 => 112327)

--- trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp	2012-03-27 22:29:21 UTC (rev 112326)
+++ trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp	2012-03-27 22:46:36 UTC (rev 112327)
@@ -578,7 +578,7 @@
 }
 }
 
-Region TiledLayerChromium::opaqueContentsRegion() const
+Region TiledLayerChromium::visibleContentOpaqueRegion() const
 {
 if (m_skipsDraw)
 return Regio

[webkit-changes] [112326] trunk/Source/WebKit/chromium

[commit-queue]

Title: [112326] trunk/Source/WebKit/chromium








Revision 112326
Author commit-qu...@webkit.org
Date 2012-03-27 15:29:21 -0700 (Tue, 27 Mar 2012)


Log Message
[chromium] A unit test to verify clipping is honored when moving occlusion to parent surface
https://bugs.webkit.org/show_bug.cgi?id=81783

Patch by Dana Jansens  on 2012-03-27
Reviewed by Adrienne Walker.

* tests/CCOcclusionTrackerTest.cpp:
(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebCore):
(CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping):
(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (112325 => 112326)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-27 22:24:36 UTC (rev 112325)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-27 22:29:21 UTC (rev 112326)
@@ -1,3 +1,16 @@
+2012-03-27  Dana Jansens  
+
+[chromium] A unit test to verify clipping is honored when moving occlusion to parent surface
+https://bugs.webkit.org/show_bug.cgi?id=81783
+
+Reviewed by Adrienne Walker.
+
+* tests/CCOcclusionTrackerTest.cpp:
+(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
+(WebCore):
+(CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping):
+(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
+
 2012-03-27  James Robinson  
 
 Scrollable plugins not registered properly in ScrollingCoordinator


Modified: trunk/Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp (112325 => 112326)

--- trunk/Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp	2012-03-27 22:24:36 UTC (rev 112325)
+++ trunk/Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp	2012-03-27 22:29:21 UTC (rev 112326)
@@ -1889,13 +1889,35 @@
 EXPECT_EQ(1u, occlusion.occlusionInScreenSpace().rects().size());
 EXPECT_EQ_RECT(IntRect(0, 0, 400, 400), occlusion.occlusionInTargetSurface().bounds());
 EXPECT_EQ(1u, occlusion.occlusionInTargetSurface().rects().size());
+}
+};
 
-EXPECT_EQ_RECT(occlusion.occlusionInScreenSpace().bounds(), occlusion.occlusionInTargetSurface().bounds());
+MAIN_AND_IMPL_THREAD_TEST(CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent);
+
+template
+class CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping : public CCOcclusionTrackerTest {
+protected:
+void runMyTest()
+{
+typename Types::ContentLayerType* parent = this->createRoot(this->identityMatrix, FloatPoint(0, 0), IntSize(300, 300));
+typename Types::ContentLayerType* surface = this->createDrawingSurface(parent, this->identityMatrix, FloatPoint(0, 0), IntSize(500, 300), false);
+surface->setOpaqueContentsRect(IntRect(0, 0, 400, 200));
+this->calcDrawEtc(parent);
+
+TestCCOcclusionTrackerBase occlusion(IntRect(0, 0, 1000, 1000));
+
+occlusion.enterTargetRenderSurface(surface->renderSurface());
+occlusion.markOccludedBehindLayer(surface);
+occlusion.finishedTargetRenderSurface(surface, surface->renderSurface());
+occlusion.leaveToTargetRenderSurface(parent->renderSurface());
+
+EXPECT_EQ_RECT(IntRect(0, 0, 300, 200), occlusion.occlusionInScreenSpace().bounds());
 EXPECT_EQ(1u, occlusion.occlusionInScreenSpace().rects().size());
+EXPECT_EQ_RECT(IntRect(0, 0, 300, 200), occlusion.occlusionInTargetSurface().bounds());
 EXPECT_EQ(1u, occlusion.occlusionInTargetSurface().rects().size());
 }
 };
 
-MAIN_AND_IMPL_THREAD_TEST(CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent);
+MAIN_AND_IMPL_THREAD_TEST(CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping);
 
 } // namespace






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112325] trunk/Source

[commit-queue]

Title: [112325] trunk/Source








Revision 112325
Author commit-qu...@webkit.org
Date 2012-03-27 15:24:36 -0700 (Tue, 27 Mar 2012)


Log Message
Scrollable plugins not registered properly in ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=82163

Patch by James Robinson  on 2012-03-27
Reviewed by Anders Carlsson.

Source/WebCore:

Whenever a ScrollableArea is added or removed from a FrameView's ScrollableAreaSet, we have to recalculate the
nonFastScrollableRegion. This can happen for certain types of plugins that are scrollable.

This also reverts 112142 which was a not quite right way to handle these plugins.

* page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
(WebCore):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* plugins/PluginViewBase.h:

Source/WebKit/chromium:

Since ScrollbarGroups are ScrollableAreas, they need to be able to report their bounds for the
ScrollingCoordinator's calculateNonFastScrollableRegion. This also changes ScrollbarGroups to only be registered
as ScrollableAreas on the FrameView's set when they actually have Scrollbars.

* src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):
(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
(WebKit::ScrollbarGroup::setFrameRect):
(WebKit):
(WebKit::ScrollbarGroup::scrollableAreaBoundingBox):
* src/ScrollbarGroup.h:
(ScrollbarGroup):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::reportGeometry):
(WebKit):
(WebKit::WebPluginContainerImpl::scrollbarGroup):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h
trunk/Source/WebCore/plugins/PluginViewBase.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ScrollbarGroup.cpp
trunk/Source/WebKit/chromium/src/ScrollbarGroup.h
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112324 => 112325)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 22:21:11 UTC (rev 112324)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 22:24:36 UTC (rev 112325)
@@ -1,3 +1,26 @@
+2012-03-27  James Robinson  
+
+Scrollable plugins not registered properly in ScrollingCoordinator
+https://bugs.webkit.org/show_bug.cgi?id=82163
+
+Reviewed by Anders Carlsson.
+
+Whenever a ScrollableArea is added or removed from a FrameView's ScrollableAreaSet, we have to recalculate the
+nonFastScrollableRegion. This can happen for certain types of plugins that are scrollable.
+
+This also reverts 112142 which was a not quite right way to handle these plugins.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::addScrollableArea):
+(WebCore::FrameView::removeScrollableArea):
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::computeNonFastScrollableRegion):
+(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
+(WebCore):
+* page/scrolling/ScrollingCoordinator.h:
+(ScrollingCoordinator):
+* plugins/PluginViewBase.h:
+
 2012-03-27  Adam Klein  
 
 Hold a reference to refChild in insertBefore before calling collectChildrenAndRemoveFromOldParent


Modified: trunk/Source/WebCore/page/FrameView.cpp (112324 => 112325)

--- trunk/Source/WebCore/page/FrameView.cpp	2012-03-27 22:21:11 UTC (rev 112324)
+++ trunk/Source/WebCore/page/FrameView.cpp	2012-03-27 22:24:36 UTC (rev 112325)
@@ -3385,6 +3385,11 @@
 if (!m_scrollableAreas)
 m_scrollableAreas = adoptPtr(new ScrollableAreaSet);
 m_scrollableAreas->add(scrollableArea);
+
+if (Page* page = m_frame->page()) {
+if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator())
+scrollingCoordinator->frameViewScrollableAreasDidChange(this);
+}
 }
 
 void FrameView::removeScrollableArea(ScrollableArea* scrollableArea)
@@ -3392,6 +3397,11 @@
 if (!m_scrollableAreas)
 return;
 m_scrollableAreas->remove(scrollableArea);
+
+if (Page* page = m_frame->page()) {
+if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator())
+scrollingCoordinator->frameViewScrollableAreasDidChange(this);
+}
 }
 
 bool FrameView::containsScrollableArea(ScrollableArea* scrollableArea) const


Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (112324 => 112325)

--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2012-03-27 22:21:11 UTC (rev

[webkit-changes] [112324] trunk/LayoutTests

[dpranke]

Title: [112324] trunk/LayoutTests








Revision 112324
Author dpra...@chromium.org
Date 2012-03-27 15:21:11 -0700 (Tue, 27 Mar 2012)


Log Message
Remove a bunch of lines that are no longer failing.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112323 => 112324)

--- trunk/LayoutTests/ChangeLog	2012-03-27 22:13:06 UTC (rev 112323)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 22:21:11 UTC (rev 112324)
@@ -1,3 +1,11 @@
+2012-03-27  Dirk Pranke  
+
+Remove a bunch of lines that are no longer failing.
+
+Unreviewed, expectations change.
+
+* platform/chromium/test_expectations.txt:
+
 2012-03-27  Adam Klein  
 
 Hold a reference to refChild in insertBefore before calling collectChildrenAndRemoveFromOldParent


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112323 => 112324)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-27 22:13:06 UTC (rev 112323)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-27 22:21:11 UTC (rev 112324)
@@ -1212,18 +1212,12 @@
 // Chromium failure needs investigation
 BUGWK79068 : svg/transforms/transform-origin-css-property.xhtml = FAIL
 
-// New test requires rebaseline
-BUGWK77535 : svg/repaint/inner-svg-change-viewPort-relative.svg = IMAGE IMAGE+TEXT
-
 // Updated test, needs a rebaseline
 BUGWK78613 : svg/custom/circle-move-invalidation.svg = IMAGE IMAGE+TEXT
 
 // Has been crashing since it was added.
 BUGWK81796 SNOWLEOPARD DEBUG : svg/custom/fill-opacity-update.svg = CRASH
 
-// Updated test, needs a rebaseline
-BUGWK81219 : svg/filters/feColorMatrix-invalid-animation.svg = TEXT
-
 // Needs a rebaseline after https://bugs.webkit.org/show_bug.cgi?id=82085
 BUGWK82085 : svg/filters/filterRes.svg = IMAGE
 
@@ -1286,7 +1280,7 @@
 // Appears elsewhere commented
 BUGWK75968 : svg/W3C-SVG-1.1/text-text-05-t.svg = IMAGE+TEXT TEXT
 // This may be unrelated.
-BUGWK75968 : svg/css/group-with-shadow.svg = IMAGE
+BUGWK75968 LION : svg/css/group-with-shadow.svg = IMAGE
 // Appears elsewhere commented
 BUGWK75968 : svg/W3C-SVG-1.1/animate-elem-36-t.svg = TEXT
 // Appears elsewhere commented
@@ -1465,7 +1459,6 @@
 // Rebaseline after SK_ENABLE_FAST_SHADERMASK is enabled in skia.gyp
 // the image change should be very slight (only in low-bits of color components)
 //
-BUGCR105305 : fast/backgrounds/size/contain-and-cover-zoomed.html = IMAGE
 BUGCR105305 LINUX MAC : svg/W3C-SVG-1.1/pservers-grad-11-b.svg = IMAGE
 BUGCR105305 : svg/css/composite-shadow-text.svg = IMAGE
 BUGCR105305 : svg/css/text-gradient-shadow.svg = IMAGE
@@ -1781,14 +1774,7 @@
 // Rebaseline to take advantage of skia ColorFilter optimization.
 // Note that two of tests below are broken on Leopard for other reasons (search
 // elsewhere within this file) and thus should not be blindly rebaselined there.
-BUGCR104128 : fast/box-shadow/box-shadow-radius.html = IMAGE
-BUGCR104128 : fast/box-shadow/inset-box-shadow-radius.html = IMAGE
 // Need TEXT rebaseline after BUGWK75568
-BUGCR104128 : fast/box-shadow/shadow-buffer-partial.html = IMAGE+TEXT
-BUGCR104128 : fast/canvas/shadow-offset-4.html = IMAGE
-BUGCR104128 : fast/canvas/shadow-offset-5.html = IMAGE
-BUGCR104128 : fast/canvas/shadow-offset-6.html = IMAGE
-BUGCR104128 : fast/canvas/shadow-offset-7.html = IMAGE
 BUGCR104128 : fast/repaint/box-shadow-h.html = IMAGE
 BUGCR104128 : fast/repaint/box-shadow-v.html = IMAGE
 BUGCR104128 LINUX MAC : fast/repaint/text-shadow-horizontal.html = IMAGE
@@ -1900,13 +1886,6 @@
 BUGCR9798 WIN RELEASE : http/tests/xmlhttprequest/small-chunks-response-text.html = PASS TIMEOUT
 
 // Rebaseline once fixed sampling matrixproc lands in Skia
-BUGCR117799 : fast/borders/border-image-massive-scale.html = IMAGE
-BUGCR117799 : fast/borders/border-image-outset-in-shorthand.html = IMAGE
-BUGCR117799 : fast/borders/border-image-outset.html = IMAGE
-BUGCR117799 : fast/borders/border-image-rotate-transform.html = IMAGE
-BUGCR117799 : fast/borders/border-image-scaled-gradient.html = IMAGE
-BUGCR117799 : fast/borders/border-image-scaled.html = IMAGE
-BUGCR117799 : fast/canvas/canvas-bg-zoom.html = IMAGE
 BUGCR117799 : fast/gradients/background-clipped.html = IMAGE
 BUGCR117799 : fast/repaint/background-misaligned.html = IMAGE
 BUGCR117799 : fast/repaint/backgroundSizeRepaint.html = IMAGE
@@ -1955,7 +1934,6 @@
 BUGCR15270 WIN : fast/js/excessive-comma-usage.html = CRASH TIMEOUT FAIL
 
 // rebaseline after skia rev. 2527 lands
-BUGCR101797 : fast/backgrounds/size/contain-and-cover.html = IMAGE
 BUGCR101797 SLOW DEBUG : svg/as-background-image/svg-as-background-5.html = IMAGE
 BUGCR101797 RELEASE : svg/as-background-image/svg-as-background-5.html = IMAGE
 BUGCR101797 : svg/filters/subRegion-one-effect.svg = IMAGE
@@ -2210,8 +2188,6 @@
 BUGCR41206 : fast/history/multiple-classes-visited.ht

[webkit-changes] [112323] trunk

[adamk]

Title: [112323] trunk








Revision 112323
Author ad...@chromium.org
Date 2012-03-27 15:13:06 -0700 (Tue, 27 Mar 2012)


Log Message
Hold a reference to refChild in insertBefore before calling collectChildrenAndRemoveFromOldParent
https://bugs.webkit.org/show_bug.cgi?id=82377

Reviewed by Ryosuke Niwa.

Source/WebCore:

This fixes a regression from r111925.

Test: fast/dom/insertBefore-refChild-crash.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore): Move the 'next' RefPtr above the call to
collectChildrenAndRemoveFromOldParent and rename refChildPreviousSibling
to 'prev' (matching appendChild and replaceChild).

LayoutTests:

* fast/dom/insertBefore-refChild-crash-expected.txt: Added.
* fast/dom/insertBefore-refChild-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp


Added Paths

trunk/LayoutTests/fast/dom/insertBefore-refChild-crash-expected.txt
trunk/LayoutTests/fast/dom/insertBefore-refChild-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (112322 => 112323)

--- trunk/LayoutTests/ChangeLog	2012-03-27 22:07:18 UTC (rev 112322)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 22:13:06 UTC (rev 112323)
@@ -1,3 +1,13 @@
+2012-03-27  Adam Klein  
+
+Hold a reference to refChild in insertBefore before calling collectChildrenAndRemoveFromOldParent
+https://bugs.webkit.org/show_bug.cgi?id=82377
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/insertBefore-refChild-crash-expected.txt: Added.
+* fast/dom/insertBefore-refChild-crash.html: Added.
+
 2012-03-27  Ryosuke Niwa  
 
 cssText should not generate literal 'initial' in shorthand properties


Added: trunk/LayoutTests/fast/dom/insertBefore-refChild-crash-expected.txt (0 => 112323)

--- trunk/LayoutTests/fast/dom/insertBefore-refChild-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/insertBefore-refChild-crash-expected.txt	2012-03-27 22:13:06 UTC (rev 112323)
@@ -0,0 +1,2 @@
+Test passes if it does not crash.
+


Added: trunk/LayoutTests/fast/dom/insertBefore-refChild-crash.html (0 => 112323)

--- trunk/LayoutTests/fast/dom/insertBefore-refChild-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/insertBefore-refChild-crash.html	2012-03-27 22:13:06 UTC (rev 112323)
@@ -0,0 +1,18 @@
+Test passes if it does not crash.
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var container = document.getElementById('container');
+var newChild = document.getElementById('newChild');
+newChild.addEventListener('DOMNodeRemoved', function() {
+container.innerHTML = '';
+gc();
+}, false);
+var range = document.createRange();
+range.selectNodeContents(container);
+range.insertNode(newChild);
+


Modified: trunk/Source/WebCore/ChangeLog (112322 => 112323)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 22:07:18 UTC (rev 112322)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 22:13:06 UTC (rev 112323)
@@ -1,3 +1,19 @@
+2012-03-27  Adam Klein  
+
+Hold a reference to refChild in insertBefore before calling collectChildrenAndRemoveFromOldParent
+https://bugs.webkit.org/show_bug.cgi?id=82377
+
+Reviewed by Ryosuke Niwa.
+
+This fixes a regression from r111925.
+
+Test: fast/dom/insertBefore-refChild-crash.html
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::insertBefore): Move the 'next' RefPtr above the call to
+collectChildrenAndRemoveFromOldParent and rename refChildPreviousSibling
+to 'prev' (matching appendChild and replaceChild).
+
 2012-03-27  Ryosuke Niwa  
 
 cssText should not generate literal 'initial' in shorthand properties


Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (112322 => 112323)

--- trunk/Source/WebCore/dom/ContainerNode.cpp	2012-03-27 22:07:18 UTC (rev 112322)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp	2012-03-27 22:13:06 UTC (rev 112323)
@@ -142,6 +142,8 @@
 if (refChild->previousSibling() == newChild || refChild == newChild) // nothing to do
 return true;
 
+RefPtr next = refChild;
+
 NodeVector targets;
 collectChildrenAndRemoveFromOldParent(newChild.get(), targets, ec);
 if (ec)
@@ -153,8 +155,7 @@
 ChildListMutationScope mutation(this);
 #endif
 
-RefPtr next = refChild;
-RefPtr refChildPreviousSibling = refChild->previousSibling();
+RefPtr prev = next->previousSibling();
 for (NodeVector::const_iterator it = targets.begin(); it != targets.end(); ++it) {
 Node* child = it->get();
 
@@ -176,7 +177,7 @@
 insertBeforeCommon(next.get(), child);
 
 // Send notification about the children change.
-childrenChanged(false, refChildPreviousSibling.get(), next.get(), 1);
+childrenChanged(false, prev.get(), next.get(), 1);
 notifyChildInserted(child);
 
 // Add child to the rendering tree.






___

[webkit-changes] [112322] trunk/Tools

[simon . fraser]

Title: [112322] trunk/Tools








Revision 112322
Author simon.fra...@apple.com
Date 2012-03-27 15:07:18 -0700 (Tue, 27 Mar 2012)


Log Message
Improve error reporting in run-_javascript_core-tests
https://bugs.webkit.org/show_bug.cgi?id=82379

Reviewed by Jessie Berlin.

When the script dies, have it print out the reason for dying.

* Scripts/run-_javascript_core-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests




Diff

Modified: trunk/Tools/ChangeLog (112321 => 112322)

--- trunk/Tools/ChangeLog	2012-03-27 22:01:03 UTC (rev 112321)
+++ trunk/Tools/ChangeLog	2012-03-27 22:07:18 UTC (rev 112322)
@@ -1,3 +1,14 @@
+2012-03-27  Simon Fraser  
+
+Improve error reporting in run-_javascript_core-tests
+https://bugs.webkit.org/show_bug.cgi?id=82379
+
+Reviewed by Jessie Berlin.
+
+When the script dies, have it print out the reason for dying.
+
+* Scripts/run-_javascript_core-tests:
+
 2012-03-27  Eric Seidel  
 
 Add Dave Barton to the Contributors list so I can more easily CC him on bugs


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (112321 => 112322)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2012-03-27 22:01:03 UTC (rev 112321)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2012-03-27 22:07:18 UTC (rev 112322)
@@ -124,7 +124,7 @@
 #run api tests
 if (isAppleMacWebKit() || isAppleWinWebKit()) {
 chdirWebKit();
-chdir($productDir) or die;
+chdir($productDir) or die "Failed to switch directory to '$productDir'\n";
 my $path = testapiPath($productDir);
 # Use an "indirect object" so that system() won't get confused if the path
 # contains spaces (see perldoc -f exec).
@@ -135,14 +135,14 @@
 # Find _javascript_Core directory
 chdirWebKit();
 chdir("Source/_javascript_Core");
-chdir "tests/mozilla" or die;
+chdir "tests/mozilla" or die "Failed to switch directory to 'tests/mozilla'\n";
 printf "Running: jsDriver.pl -e squirrelfish -s %s -f actual.html %s\n", jscPath($productDir), join(" ", @jsArgs);
 my $result = system "perl", "jsDriver.pl", "-e", "squirrelfish", "-s", jscPath($productDir), "-f", "actual.html", @jsArgs;
 exit exitStatus($result)  if $result;
 
 my %failures;
 
-open EXPECTED, "expected.html" or die;
+open EXPECTED, "expected.html" or die "Failed to open 'expected.html'\n";
 while () {
 last if /failures reported\.$/;
 }
@@ -154,7 +154,7 @@
 
 my %newFailures;
 
-open ACTUAL, "actual.html" or die;
+open ACTUAL, "actual.html" or die "Failed to open 'actual.html'";
 while () {
 last if /failures reported\.$/;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112321] trunk

[rniwa]

Title: [112321] trunk








Revision 112321
Author rn...@webkit.org
Date 2012-03-27 15:01:03 -0700 (Tue, 27 Mar 2012)


Log Message
cssText should not generate literal 'initial' in shorthand properties
https://bugs.webkit.org/show_bug.cgi?id=82364

Reviewed by Antti Koivisto.

Source/WebCore: 

Fixed the bug by treating initial value as if the value is not set.
While this is incorrect for properties that inherits by default,
it's strictly better than generating unparsable value as we do today.

The proper fix is for CSSInitialValue::cssText to fetch the respective
default value from what's currently in CSSStyleSelector code but that requires
a considerable amount of refactoring and work.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):

LayoutTests: 

* fast/css/cssText-shorthand-expected.txt: Rebaselined.
* fast/css/cssText-shorthand.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt
trunk/LayoutTests/fast/css/cssText-shorthand.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StylePropertySet.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (112320 => 112321)

--- trunk/LayoutTests/ChangeLog	2012-03-27 21:54:40 UTC (rev 112320)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 22:01:03 UTC (rev 112321)
@@ -1,3 +1,13 @@
+2012-03-27  Ryosuke Niwa  
+
+cssText should not generate literal 'initial' in shorthand properties
+https://bugs.webkit.org/show_bug.cgi?id=82364
+
+Reviewed by Antti Koivisto.
+
+* fast/css/cssText-shorthand-expected.txt: Rebaselined.
+* fast/css/cssText-shorthand.html:
+
 2012-03-27  Dirk Pranke  
 
 Change media/track/track-delete-during-startup bug #


Modified: trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt (112320 => 112321)

--- trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt	2012-03-27 21:54:40 UTC (rev 112320)
+++ trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt	2012-03-27 22:01:03 UTC (rev 112321)
@@ -3,16 +3,16 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS normalizeCssText(element.style.cssText) is "border: 1px initial initial"
+PASS normalizeCssText(element.style.cssText) is "border: 1px"
 PASS normalizeCssText(element.style.cssText) is "border: 1px solid red"
-PASS normalizeCssText(element.style.cssText) is "border: 1px initial red"
-PASS normalizeCssText(element.style.cssText) is "border: initial initial red"
-PASS normalizeCssText(element.style.cssText) is "border: 1px initial initial"
+PASS normalizeCssText(element.style.cssText) is "border: 1px red"
+PASS normalizeCssText(element.style.cssText) is "border: red"
+PASS normalizeCssText(element.style.cssText) is "border: 1px"
 PASS normalizeCssText(element.style.cssText) is "border-bottom-width: 3px; border-left-width: 4px; border-right-width: 2px; border-top-width: 1px"
 PASS normalizeCssText(element.style.cssText) is "border-bottom-width: 1px; border-left-width: 1px; border-right-width: 1px; border-top-width: 2px"
 PASS normalizeCssText(element.style.cssText) is "border-bottom-width: 1px; border-left-width: 1px; border-right-width: 1px; border-top-width: 1px !important"
 PASS normalizeCssText(element.style.cssText) is "border-bottom-width: 1px; border-left-width: 1px; border-right-width: 1px; border-top-color: red; border-top-width: 1px"
-PASS normalizeCssText(element.style.cssText) is "border: initial dotted initial"
+PASS normalizeCssText(element.style.cssText) is "border: dotted"
 PASS normalizeCssText(element.style.cssText) is "border-spacing: 1px 2px"
 PASS normalizeCssText(element.style.cssText) is "font-family: sans-serif; font-size: 3em; font-style: italic; font-weight: bold; line-height: 2em"
 PASS normalizeCssText(element.style.cssText) is "list-style: circle inside"


Modified: trunk/LayoutTests/fast/css/cssText-shorthand.html (112320 => 112321)

--- trunk/LayoutTests/fast/css/cssText-shorthand.html	2012-03-27 21:54:40 UTC (rev 112320)
+++ trunk/LayoutTests/fast/css/cssText-shorthand.html	2012-03-27 22:01:03 UTC (rev 112321)
@@ -8,11 +8,11 @@
 
 var tests = [
 // FIXME: This exhibits a bug. We shouldn't be outputing border-image here.
-['border: 1px; border-top: 1px;', 'border: 1px initial initial;'],
+['border: 1px; border-top: 1px;', 'border: 1px;'],
 ['border: 1px solid red;', 'border: 1px solid red;'],
-['border: 1px red;', 'border: 1px initial red;'],
-['border: red;', 'border: initial initial red;'],
-['border-top: 1px; border-right: 1px; border-bottom: 1px; border-left: 1px;', 'border: 1px initial initial;'],
+['border: 1px red;', 'border: 1px red;'],
+['border: red;', 'border: red;'],
+['border-top: 1px; border-right: 1px; border-bottom: 1px; border-left: 1px;', 'border: 1px;'],
 ['border-top: 1px; border-right: 2px; border-bottom: 3px; border-left: 4px;',
 'border-top-width: 1px; border-righ

[webkit-changes] [112320] trunk/Source/JavaScriptCore

[fpizlo]

Title: [112320] trunk/Source/_javascript_Core








Revision 112320
Author fpi...@apple.com
Date 2012-03-27 14:54:40 -0700 (Tue, 27 Mar 2012)


Log Message
DFG OSR exit should not generate an exit for variables of inlinees if the
inlinees are not in scope
https://bugs.webkit.org/show_bug.cgi?id=82312

Reviewed by Oliver Hunt.

* bytecode/CodeBlock.h:
(JSC::baselineCodeBlockForInlineCallFrame):
(JSC):
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::computeNumVariablesForCodeOrigin):
(DFG):
(JSC::DFG::OSRExit::OSRExit):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (112319 => 112320)

--- trunk/Source/_javascript_Core/ChangeLog	2012-03-27 21:39:35 UTC (rev 112319)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-03-27 21:54:40 UTC (rev 112320)
@@ -1,3 +1,20 @@
+2012-03-27  Filip Pizlo  
+
+DFG OSR exit should not generate an exit for variables of inlinees if the
+inlinees are not in scope
+https://bugs.webkit.org/show_bug.cgi?id=82312
+
+Reviewed by Oliver Hunt.
+
+* bytecode/CodeBlock.h:
+(JSC::baselineCodeBlockForInlineCallFrame):
+(JSC):
+(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
+* dfg/DFGOSRExit.cpp:
+(JSC::DFG::computeNumVariablesForCodeOrigin):
+(DFG):
+(JSC::DFG::OSRExit::OSRExit):
+
 2012-03-27  Matt Lilek  
 
 Stop compiling Interpreter.cpp with -fno-var-tracking


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (112319 => 112320)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2012-03-27 21:39:35 UTC (rev 112319)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2012-03-27 21:54:40 UTC (rev 112320)
@@ -1385,13 +1385,18 @@
 #endif
 };
 
+inline CodeBlock* baselineCodeBlockForInlineCallFrame(InlineCallFrame* inlineCallFrame)
+{
+ASSERT(inlineCallFrame);
+ExecutableBase* executable = inlineCallFrame->executable.get();
+ASSERT(executable->structure()->classInfo() == &FunctionExecutable::s_info);
+return static_cast(executable)->baselineCodeBlockFor(inlineCallFrame->isCall ? CodeForCall : CodeForConstruct);
+}
+
 inline CodeBlock* baselineCodeBlockForOriginAndBaselineCodeBlock(const CodeOrigin& codeOrigin, CodeBlock* baselineCodeBlock)
 {
-if (codeOrigin.inlineCallFrame) {
-ExecutableBase* executable = codeOrigin.inlineCallFrame->executable.get();
-ASSERT(executable->structure()->classInfo() == &FunctionExecutable::s_info);
-return static_cast(executable)->baselineCodeBlockFor(codeOrigin.inlineCallFrame->isCall ? CodeForCall : CodeForConstruct);
-}
+if (codeOrigin.inlineCallFrame)
+return baselineCodeBlockForInlineCallFrame(codeOrigin.inlineCallFrame);
 return baselineCodeBlock;
 }
 


Modified: trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp (112319 => 112320)

--- trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp	2012-03-27 21:39:35 UTC (rev 112319)
+++ trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp	2012-03-27 21:54:40 UTC (rev 112320)
@@ -33,6 +33,16 @@
 
 namespace JSC { namespace DFG {
 
+static unsigned computeNumVariablesForCodeOrigin(
+CodeBlock* codeBlock, const CodeOrigin& codeOrigin)
+{
+if (!codeOrigin.inlineCallFrame)
+return codeBlock->m_numCalleeRegisters;
+return
+codeOrigin.inlineCallFrame->stackOffset +
+baselineCodeBlockForInlineCallFrame(codeOrigin.inlineCallFrame)->m_numCalleeRegisters;
+}
+
 OSRExit::OSRExit(ExitKind kind, JSValueSource jsValueSource, MethodOfGettingAValueProfile valueProfile, MacroAssembler::Jump check, SpeculativeJIT* jit, unsigned recoveryIndex)
 : m_jsValueSource(jsValueSource)
 , m_valueProfile(valueProfile)
@@ -43,7 +53,7 @@
 , m_kind(kind)
 , m_count(0)
 , m_arguments(jit->m_arguments.size())
-, m_variables(jit->m_variables.size())
+, m_variables(computeNumVariablesForCodeOrigin(jit->m_jit.graph().m_profiledBlock, jit->m_codeOriginForOSR))
 , m_lastSetOperand(jit->m_lastSetOperand)
 {
 ASSERT(m_codeOrigin.isSet());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112319] trunk/Tools

[eric]

Title: [112319] trunk/Tools








Revision 112319
Author e...@webkit.org
Date 2012-03-27 14:39:35 -0700 (Tue, 27 Mar 2012)


Log Message
Add Dave Barton to the Contributors list so I can more easily CC him on bugs
https://bugs.webkit.org/show_bug.cgi?id=82373

Reviewed by Ryosuke Niwa.

Dave's committer-status in in-progress, so until then
list him as a Contributor so at least I can more easily CC him on bugs.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (112318 => 112319)

--- trunk/Tools/ChangeLog	2012-03-27 21:38:33 UTC (rev 112318)
+++ trunk/Tools/ChangeLog	2012-03-27 21:39:35 UTC (rev 112319)
@@ -1,3 +1,15 @@
+2012-03-27  Eric Seidel  
+
+Add Dave Barton to the Contributors list so I can more easily CC him on bugs
+https://bugs.webkit.org/show_bug.cgi?id=82373
+
+Reviewed by Ryosuke Niwa.
+
+Dave's committer-status in in-progress, so until then
+list him as a Contributor so at least I can more easily CC him on bugs.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2012-03-26  Raphael Kubo da Costa  
 
 [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (112318 => 112319)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-03-27 21:38:33 UTC (rev 112318)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-03-27 21:39:35 UTC (rev 112319)
@@ -119,6 +119,7 @@
 Contributor("Commit Queue", "commit-qu...@webkit.org"),
 Contributor("Dana Jansens", "dan...@chromium.org", "danakj"),
 Contributor("Daniel Sievers", "siev...@chromium.org"),
+Contributor("Dave Barton", "dbar...@mathscribe.com"),
 Contributor("David Barr", "davidb...@chromium.org", "barrbrain"),
 Contributor("David Dorwin", "ddor...@chromium.org", "ddorwin"),
 Contributor("David Reveman", "reve...@chromium.org", "reveman"),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112318] trunk/Source/WebCore

[adamk]

Title: [112318] trunk/Source/WebCore








Revision 112318
Author ad...@chromium.org
Date 2012-03-27 14:38:33 -0700 (Tue, 27 Mar 2012)


Log Message
Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256

Reviewed by Adam Barth.

This moves leakRef() calls out of generated code, centralizing them in
V8DOMWrapper implementation. Ideally, WeakReferenceMap::set would take
PassRefPtrs, but that's tricky given that some WeakReferenceMap's KeyType is 'void'
(which clearly can't be wrapped in a PassRefPtr).

Updated binding tests to reflect changes in CodeGeneratorV8.pm, no change in behavior.

Relanding r112207 with setJSWrapperForDOMSVGElementInstance defined
out-of-line to avoid SVG header dependencies.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Use GetDomMapFunction instead of custom logic.
(GenerateNamedConstructorCallback): ditto.
(GenerateToV8Converters): Call V8DOMWrapper::setJSWrapper* method
instead of directly accessing the wrapper maps and calling set.
(GetDomMapFunction): Refactored to call new GetDomWrapperMapName function.
(GetDomWrapperMapName): Helper pulled out of GetDomMapFunction.
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
* bindings/v8/V8DOMWrapper.cpp: Moved setJSWrapperForDOMNode method to header to inline it.
(WebCore::V8DOMWrapper::setJSWrapperForDOMSVGElementInstance): New helper method for SVGElementInstances.
Not inline to avoid header dependency on SVGElementInstance.h.
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Made inline.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): ditto.
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Refactored into two methods;
this one handles non-active Nodes.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): Pulled out of previouse
DOMNode method, now handles only active Nodes.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112317 => 112318)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 21:34:55 UTC (rev 112317)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 21:38:33 UTC (rev 112318)
@@ -1,3 +1,59 @@
+2012-03-26  Adam Klein  
+
+Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
+https://bugs.webkit.org/show_bug.cgi?id=82256
+
+Reviewed by Adam Barth.
+
+This moves leakRef() calls out of generated code, centralizing them in
+V8DOMWrapper implementation. Ideally, WeakReferenceMap::set would take
+PassRefPtrs, but that's tricky given that some WeakReferenceMap's KeyType is 'void'
+(which clearly can't be wrapped in a PassRefPtr).
+
+Updated binding tests to reflect changes in CodeGeneratorV8.pm, no change in behavior.
+
+Relanding r112207 with setJSWrapperForDOMSVGElementInstance defined
+out-of-line to avoid SVG header dependencies.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateConstructorCallback): Use GetDomMapFunction instead of custom logic.
+(GenerateNamedConstructorCallback): ditto.
+(GenerateT

[webkit-changes] [112317] trunk/Source/WebKit/chromium

[commit-queue]

Title: [112317] trunk/Source/WebKit/chromium








Revision 112317
Author commit-qu...@webkit.org
Date 2012-03-27 14:34:55 -0700 (Tue, 27 Mar 2012)


Log Message
[chromium] Make use of common animation unit test methods
https://bugs.webkit.org/show_bug.cgi?id=82357

Patch by Dana Jansens  on 2012-03-27
Reviewed by Adrienne Walker.

* tests/CCAnimationTestCommon.cpp:
(WebKitTests::addAnimatedTransformToController):
(WebKitTests):
* tests/CCAnimationTestCommon.h:
(WebKitTests):
* tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCAnimationTestCommon.cpp
trunk/Source/WebKit/chromium/tests/CCAnimationTestCommon.h
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp
trunk/Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (112316 => 112317)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-27 21:34:21 UTC (rev 112316)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-27 21:34:55 UTC (rev 112317)
@@ -1,3 +1,23 @@
+2012-03-27  Dana Jansens  
+
+[chromium] Make use of common animation unit test methods
+https://bugs.webkit.org/show_bug.cgi?id=82357
+
+Reviewed by Adrienne Walker.
+
+* tests/CCAnimationTestCommon.cpp:
+(WebKitTests::addAnimatedTransformToController):
+(WebKitTests):
+* tests/CCAnimationTestCommon.h:
+(WebKitTests):
+* tests/CCLayerTreeHostCommonTest.cpp:
+(WebKitTests::TEST):
+* tests/CCOcclusionTrackerTest.cpp:
+(WebKitTests):
+(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
+(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
+(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
+
 2012-03-27  Sami Kyostila  
 
 [chromium] Add TextureCopier for copying texture contents


Modified: trunk/Source/WebKit/chromium/tests/CCAnimationTestCommon.cpp (112316 => 112317)

--- trunk/Source/WebKit/chromium/tests/CCAnimationTestCommon.cpp	2012-03-27 21:34:21 UTC (rev 112316)
+++ trunk/Source/WebKit/chromium/tests/CCAnimationTestCommon.cpp	2012-03-27 21:34:55 UTC (rev 112317)
@@ -148,6 +148,11 @@
 addOpacityTransition(controller, duration, startOpacity, endOpacity, useTimingFunction);
 }
 
+void addAnimatedTransformToController(WebCore::CCLayerAnimationController& controller, double duration, int deltaX, int deltaY)
+{
+addAnimatedTransform(controller, duration, deltaX, deltaY);
+}
+
 void addOpacityTransitionToLayer(WebCore::LayerChromium& layer, double duration, float startOpacity, float endOpacity, bool useTimingFunction)
 {
 addOpacityTransition(layer, duration, startOpacity, endOpacity, useTimingFunction);


Modified: trunk/Source/WebKit/chromium/tests/CCAnimationTestCommon.h (112316 => 112317)

--- trunk/Source/WebKit/chromium/tests/CCAnimationTestCommon.h	2012-03-27 21:34:21 UTC (rev 112316)
+++ trunk/Source/WebKit/chromium/tests/CCAnimationTestCommon.h	2012-03-27 21:34:55 UTC (rev 112317)
@@ -97,6 +97,7 @@
 };
 
 void addOpacityTransitionToController(WebCore::CCLayerAnimationController&, double duration, float startOpacity, float endOpacity, bool useTimingFunction);
+void addAnimatedTransformToController(WebCore::CCLayerAnimationController&, double duration, int deltaX, int deltaY);
 
 void addOpacityTransitionToLayer(WebCore::LayerChromium&, double duration, float startOpacity, float endOpacity, bool useTimingFunction);
 void addOpacityTransitionToLayer(WebCore::CCLayerImpl&, double duration, float startOpacity, float endOpacity, bool useTimingFunction);


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp (112316 => 112317)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp	2012-03-27 21:34:21 UTC (rev 112316)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp	2012-03-27 21:34:55 UTC (rev 112317)
@@ -26,6 +26,7 @@
 
 #include "cc/CCLayerTreeHostCommon.h"
 
+#include "CCAnimationTestCommon.h"
 #include "CCLayerTreeTestCommon.h"
 #include "LayerChromium.h"
 #include "TransformationMatrix.h"
@@ -36,6 +37,7 @@
 #include 
 
 using namespace WebCore;
+using namespace WebKitTests;
 
 namespace {
 
@@ -651,38 +653,6 @@
 EXPECT_EQ(child->id(), renderSurfaceLayerList[1]->id());
 }
 
-static int addOpacityAnimationToLayer(LayerChromium* layer, float startValue, float endValue, double duration)
-{
-static int id = 0;
-WebCore::KeyframeValueList values(AnimatedPropertyOpacity);
-values.insert(new FloatAnimationValue(0, startValue));
-values.insert(new Fl

[webkit-changes] [112316] trunk/Source/WebCore

[leviw]

Title: [112316] trunk/Source/WebCore








Revision 112316
Author le...@chromium.org
Date 2012-03-27 14:34:21 -0700 (Tue, 27 Mar 2012)


Log Message
Correct LayoutUnit usage in virtual function layoutBlock in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=82344

Reviewed by Eric Seidel.

Correcting the signature of RenderFlexibleBox::layoutBlock to use a LayoutUnit
for the page height, and avoiding assigning the renderer's size to an IntSize.

No new tests. No change in behavior.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112315 => 112316)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 21:29:41 UTC (rev 112315)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 21:34:21 UTC (rev 112316)
@@ -1,3 +1,20 @@
+2012-03-27  Levi Weintraub  
+
+Correct LayoutUnit usage in virtual function layoutBlock in RenderFlexibleBox
+https://bugs.webkit.org/show_bug.cgi?id=82344
+
+Reviewed by Eric Seidel.
+
+Correcting the signature of RenderFlexibleBox::layoutBlock to use a LayoutUnit
+for the page height, and avoiding assigning the renderer's size to an IntSize.
+
+No new tests. No change in behavior.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::layoutBlock):
+* rendering/RenderFlexibleBox.h:
+(RenderFlexibleBox):
+
 2012-03-27  Timothy Hatcher  
 
 Make WebKit properly load a staged framework when soft linking.


Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (112315 => 112316)

--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2012-03-27 21:29:41 UTC (rev 112315)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2012-03-27 21:34:21 UTC (rev 112316)
@@ -230,7 +230,7 @@
 setPreferredLogicalWidthsDirty(false);
 }
 
-void RenderFlexibleBox::layoutBlock(bool relayoutChildren, int, BlockLayoutPass)
+void RenderFlexibleBox::layoutBlock(bool relayoutChildren, LayoutUnit, BlockLayoutPass)
 {
 ASSERT(needsLayout());
 
@@ -247,7 +247,7 @@
 }
 computeInitialRegionRangeForBlock();
 
-IntSize previousSize = size();
+LayoutSize previousSize = size();
 
 setLogicalHeight(0);
 computeLogicalWidth();


Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.h (112315 => 112316)

--- trunk/Source/WebCore/rendering/RenderFlexibleBox.h	2012-03-27 21:29:41 UTC (rev 112315)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.h	2012-03-27 21:34:21 UTC (rev 112316)
@@ -44,7 +44,7 @@
 
 virtual bool isFlexibleBox() const { return true; }
 virtual void computePreferredLogicalWidths();
-virtual void layoutBlock(bool relayoutChildren, int pageLogicalHeight = 0, BlockLayoutPass = NormalLayoutPass);
+virtual void layoutBlock(bool relayoutChildren, LayoutUnit pageLogicalHeight = 0, BlockLayoutPass = NormalLayoutPass);
 
 bool isHorizontalFlow() const;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112315] trunk/Source/WebCore/platform/mac/SoftLinking.h

[timothy]

Title: [112315] trunk/Source/WebCore/platform/mac/SoftLinking.h








Revision 112315
Author timo...@apple.com
Date 2012-03-27 14:29:41 -0700 (Tue, 27 Mar 2012)


Log Message
Fix a missing block call that was found post review.

Modified Paths

trunk/Source/WebCore/platform/mac/SoftLinking.h




Diff

Modified: trunk/Source/WebCore/platform/mac/SoftLinking.h (112314 => 112315)

--- trunk/Source/WebCore/platform/mac/SoftLinking.h	2012-03-27 21:29:05 UTC (rev 112314)
+++ trunk/Source/WebCore/platform/mac/SoftLinking.h	2012-03-27 21:29:41 UTC (rev 112315)
@@ -60,7 +60,7 @@
 if (!result) \
 result = dlopen("/System/Library/StagedFrameworks/Safari/" #framework ".framework/" #framework, RTLD_LAZY); \
 return result; \
-}; \
+}(); \
 return frameworkLibrary; \
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112314] trunk/LayoutTests

[dpranke]

Title: [112314] trunk/LayoutTests








Revision 112314
Author dpra...@chromium.org
Date 2012-03-27 14:29:05 -0700 (Tue, 27 Mar 2012)


Log Message
Change media/track/track-delete-during-startup bug #

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112313 => 112314)

--- trunk/LayoutTests/ChangeLog	2012-03-27 21:15:43 UTC (rev 112313)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 21:29:05 UTC (rev 112314)
@@ -1,5 +1,13 @@
 2012-03-27  Dirk Pranke  
 
+Change media/track/track-delete-during-startup bug #
+
+Unreviewed, expectations change.
+
+* platform/chromium/test_expectations.txt:
+
+2012-03-27  Dirk Pranke  
+
 Mark media/track/track-delete-during-startup as crashing in debug.
 
 Unreviewed, expectations change.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112313 => 112314)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-27 21:15:43 UTC (rev 112313)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-27 21:29:05 UTC (rev 112314)
@@ -4387,4 +4387,4 @@
 BUGWK82372 LINUX X86_64 DEBUG : css3/filters/custom/effect-custom-parameters.html = IMAGE
 BUGWK82372 LINUX X86 RELEASE : css3/filters/custom/effect-custom-parameters.html = IMAGE
 
-BUGWK82374 DEBUG: media/track/track-delete-during-setup.html = CRASH
+BUGWK82269 DEBUG: media/track/track-delete-during-setup.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112313] trunk/Source/JavaScriptCore

[mlilek]

Title: [112313] trunk/Source/_javascript_Core








Revision 112313
Author mli...@apple.com
Date 2012-03-27 14:15:43 -0700 (Tue, 27 Mar 2012)


Log Message
Stop compiling Interpreter.cpp with -fno-var-tracking
https://bugs.webkit.org/show_bug.cgi?id=82299

Reviewed by Anders Carlsson.

* _javascript_Core.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (112312 => 112313)

--- trunk/Source/_javascript_Core/ChangeLog	2012-03-27 20:44:18 UTC (rev 112312)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-03-27 21:15:43 UTC (rev 112313)
@@ -1,3 +1,12 @@
+2012-03-27  Matt Lilek  
+
+Stop compiling Interpreter.cpp with -fno-var-tracking
+https://bugs.webkit.org/show_bug.cgi?id=82299
+
+Reviewed by Anders Carlsson.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+
 2012-03-27  Pratik Solanki  
 
 Compiler warning when JIT is not enabled


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (112312 => 112313)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2012-03-27 20:44:18 UTC (rev 112312)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2012-03-27 21:15:43 UTC (rev 112313)
@@ -201,7 +201,7 @@
 		14280870107EC1340013E7B2 /* JSWrapperObject.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 65C7A1710A8EAACB00FA37EA /* JSWrapperObject.cpp */; };
 		14280875107EC13E0013E7B2 /* JSLock.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 65EA4C99092AF9E20093D800 /* JSLock.cpp */; };
 		1429D77C0ED20D7300B89619 /* Interpreter.h in Headers */ = {isa = PBXBuildFile; fileRef = 1429D77B0ED20D7300B89619 /* Interpreter.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		1429D7D40ED2128200B89619 /* Interpreter.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1429D7D30ED2128200B89619 /* Interpreter.cpp */; settings = {COMPILER_FLAGS = "-fno-var-tracking"; }; };
+		1429D7D40ED2128200B89619 /* Interpreter.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1429D7D30ED2128200B89619 /* Interpreter.cpp */; };
 		1429D8780ED21ACD00B89619 /* ExceptionHelpers.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1429D8770ED21ACD00B89619 /* ExceptionHelpers.cpp */; };
 		1429D8850ED21C3D00B89619 /* SamplingTool.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1429D8830ED21C3D00B89619 /* SamplingTool.cpp */; };
 		1429D8860ED21C3D00B89619 /* SamplingTool.h in Headers */ = {isa = PBXBuildFile; fileRef = 1429D8840ED21C3D00B89619 /* SamplingTool.h */; settings = {ATTRIBUTES = (Private, ); }; };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112312] trunk/Source

[timothy]

Title: [112312] trunk/Source








Revision 112312
Author timo...@apple.com
Date 2012-03-27 13:44:18 -0700 (Tue, 27 Mar 2012)


Log Message
Make WebKit properly load a staged framework when soft linking.

https://webkit.org/b/82371
rdar://problem/11125989

Reviewed by Dan Bernstein.

Source/WebCore:

* platform/mac/SoftLinking.h: Replaced SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL with
SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL and made it use the StagedFrameworks path
if the first dlopen failed.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly
load the WebInspector framework.

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly
load the WebInspector framework.
* WebProcess/WebPage/mac/WebInspectorMac.mm: Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/SoftLinking.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/WebInspectorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (112311 => 112312)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 20:33:31 UTC (rev 112311)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 20:44:18 UTC (rev 112312)
@@ -1,3 +1,16 @@
+2012-03-27  Timothy Hatcher  
+
+Make WebKit properly load a staged framework when soft linking.
+
+https://webkit.org/b/82371
+rdar://problem/11125989
+
+Reviewed by Dan Bernstein.
+
+* platform/mac/SoftLinking.h: Replaced SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL with
+SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL and made it use the StagedFrameworks path
+if the first dlopen failed.
+
 2012-03-26  Dirk Schulze  
 
 Use enumeration for CSS parser mode


Modified: trunk/Source/WebCore/platform/mac/SoftLinking.h (112311 => 112312)

--- trunk/Source/WebCore/platform/mac/SoftLinking.h	2012-03-27 20:33:31 UTC (rev 112311)
+++ trunk/Source/WebCore/platform/mac/SoftLinking.h	2012-03-27 20:44:18 UTC (rev 112312)
@@ -52,10 +52,15 @@
 return frameworkLibrary; \
 }
 
-#define SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL(framework) \
+#define SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL(framework, unstagedLocation) \
 static void* framework##Library() \
 { \
-static void* frameworkLibrary = dlopen("/System/Library/PrivateFrameworks/" #framework ".framework/" #framework, RTLD_NOW); \
+static void* frameworkLibrary = ^{ \
+void* result = dlopen("/System/Library/" #unstagedLocation "/" #framework ".framework/" #framework, RTLD_LAZY); \
+if (!result) \
+result = dlopen("/System/Library/StagedFrameworks/Safari/" #framework ".framework/" #framework, RTLD_LAZY); \
+return result; \
+}; \
 return frameworkLibrary; \
 }
 


Modified: trunk/Source/WebKit/mac/ChangeLog (112311 => 112312)

--- trunk/Source/WebKit/mac/ChangeLog	2012-03-27 20:33:31 UTC (rev 112311)
+++ trunk/Source/WebKit/mac/ChangeLog	2012-03-27 20:44:18 UTC (rev 112312)
@@ -1,3 +1,15 @@
+2012-03-27  Timothy Hatcher  
+
+Make WebKit properly load a staged framework when soft linking.
+
+https://webkit.org/b/82371
+rdar://problem/11125989
+
+Reviewed by Dan Bernstein.
+
+* WebCoreSupport/WebInspectorClient.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly
+load the WebInspector framework.
+
 2012-03-26  Adam Barth  
 
 FrameLoader::shouldAllowNavigation uses Frame for context rather than Document


Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (112311 => 112312)

--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm	2012-03-27 20:33:31 UTC (rev 112311)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm	2012-03-27 20:44:18 UTC (rev 112312)
@@ -46,7 +46,7 @@
 #import 
 #import 
 
-SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL(WebInspector)
+SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL(WebInspector, PrivateFrameworks)
 
 using namespace WebCore;
 


Modified: trunk/Source/WebKit2/ChangeLog (112311 => 112312)

--- trunk/Source/WebKit2/ChangeLog	2012-03-27 20:33:31 UTC (rev 112311)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-27 20:44:18 UTC (rev 112312)
@@ -1,3 +1,16 @@
+2012-03-27  Timothy Hatcher  
+
+Make WebKit properly load a staged framework when soft linking.
+
+https://webkit.org/b/82371
+rdar://problem/11125989
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/mac/WebInspectorProxyMac.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly
+load the WebInspector framework.
+* WebProcess/WebPage/mac/WebInspectorMac.mm: Ditto.
+
 2012-03-27  Anders Carlsson  
 
 Don't update the layer hosting state unless the WKView is added to a window


Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspec

[webkit-changes] [112311] trunk/LayoutTests

[dpranke]

Title: [112311] trunk/LayoutTests








Revision 112311
Author dpra...@chromium.org
Date 2012-03-27 13:33:31 -0700 (Tue, 27 Mar 2012)


Log Message
Mark media/track/track-delete-during-startup as crashing in debug.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112310 => 112311)

--- trunk/LayoutTests/ChangeLog	2012-03-27 20:33:27 UTC (rev 112310)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 20:33:31 UTC (rev 112311)
@@ -1,7 +1,15 @@
 2012-03-27  Dirk Pranke  
 
+Mark media/track/track-delete-during-startup as crashing in debug.
+
 Unreviewed, expectations change.
 
+* platform/chromium/test_expectations.txt:
+
+2012-03-27  Dirk Pranke  
+
+Unreviewed, expectations change.
+
 Mark css3/filters/custom/effect-custom-parameters.html as an image failure on linux debug, 32-bit
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112310 => 112311)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-27 20:33:27 UTC (rev 112310)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-27 20:33:31 UTC (rev 112311)
@@ -4386,3 +4386,5 @@
 
 BUGWK82372 LINUX X86_64 DEBUG : css3/filters/custom/effect-custom-parameters.html = IMAGE
 BUGWK82372 LINUX X86 RELEASE : css3/filters/custom/effect-custom-parameters.html = IMAGE
+
+BUGWK82374 DEBUG: media/track/track-delete-during-setup.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112309] trunk/Tools

[kubo]

Title: [112309] trunk/Tools








Revision 112309
Author k...@profusion.mobi
Date 2012-03-27 13:33:07 -0700 (Tue, 27 Mar 2012)


Log Message
[jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
https://bugs.webkit.org/show_bug.cgi?id=82252

Reviewed by Gustavo Noronha Silva.

Appending the directory containing common.py may be problematic if
another path in sys.path also contains either a common.py or a
common/ module, so prepend to select our version instead. This is
the case with fail2ban, which has a common/ directory which may
end up being in Python's default path.

* efl/jhbuildrc:
* gtk/jhbuildrc:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuildrc
trunk/Tools/gtk/jhbuildrc




Diff

Modified: trunk/Tools/ChangeLog (112308 => 112309)

--- trunk/Tools/ChangeLog	2012-03-27 20:30:28 UTC (rev 112308)
+++ trunk/Tools/ChangeLog	2012-03-27 20:33:07 UTC (rev 112309)
@@ -1,3 +1,19 @@
+2012-03-26  Raphael Kubo da Costa  
+
+[jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
+https://bugs.webkit.org/show_bug.cgi?id=82252
+
+Reviewed by Gustavo Noronha Silva.
+
+Appending the directory containing common.py may be problematic if
+another path in sys.path also contains either a common.py or a
+common/ module, so prepend to select our version instead. This is
+the case with fail2ban, which has a common/ directory which may
+end up being in Python's default path.
+
+* efl/jhbuildrc:
+* gtk/jhbuildrc:
+
 2012-03-27  Dirk Pranke  
 
 test-webkitpy: prepare for better test run output


Modified: trunk/Tools/efl/jhbuildrc (112308 => 112309)

--- trunk/Tools/efl/jhbuildrc	2012-03-27 20:30:28 UTC (rev 112308)
+++ trunk/Tools/efl/jhbuildrc	2012-03-27 20:33:07 UTC (rev 112309)
@@ -20,7 +20,7 @@
 import sys
 
 __efl_tools_directory = os.path.abspath(os.path.dirname(__file__))
-sys.path.append(__efl_tools_directory)
+sys.path = [__efl_tools_directory] + sys.path
 import common
 
 build_policy = 'updated'


Modified: trunk/Tools/gtk/jhbuildrc (112308 => 112309)

--- trunk/Tools/gtk/jhbuildrc	2012-03-27 20:30:28 UTC (rev 112308)
+++ trunk/Tools/gtk/jhbuildrc	2012-03-27 20:33:07 UTC (rev 112309)
@@ -19,7 +19,7 @@
 import sys
 
 __gtk_tools_directory = os.path.abspath(os.path.dirname(__file__))
-sys.path.append(__gtk_tools_directory)
+sys.path = [__gtk_tools_directory] + sys.path
 import common
 
 build_policy = 'updated'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112308] trunk/Source/WebCore

[japhet]

Title: [112308] trunk/Source/WebCore








Revision 112308
Author jap...@chromium.org
Date 2012-03-27 13:30:28 -0700 (Tue, 27 Mar 2012)


Log Message
2012-03-27  Nate Chapin  

Don't manually set an identifier for main resource
loads in FrameLoader. ResourceLoader::willSendRequest()
will set an identifier for the request if one isn't found,
so this code appears to be unnecessary duplication.
https://bugs.webkit.org/show_bug.cgi?id=82248

Reviewed by Adam Barth.

No new tests, no functionality change intended.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Mark navigation start
here, since it's conceptually part of starting the main resource load.
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Remove duplicate identifier
logic, and move navigation timing call to startLoadingMainResource, since
it fits better logically there.
* loader/ResourceLoader.h: No callers of setIdentifier() remain, so delete it.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/DocumentLoader.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/ResourceLoader.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112307 => 112308)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 20:20:38 UTC (rev 112307)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 20:30:28 UTC (rev 112308)
@@ -1,3 +1,25 @@
+2012-03-27  Nate Chapin  
+
+Don't manually set an identifier for main resource
+loads in FrameLoader. ResourceLoader::willSendRequest()
+will set an identifier for the request if one isn't found,
+so this code appears to be unnecessary duplication.
+https://bugs.webkit.org/show_bug.cgi?id=82248
+
+Reviewed by Adam Barth.
+
+No new tests, no functionality change intended.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::startLoadingMainResource): Mark navigation start
+here, since it's conceptually part of starting the main resource load.
+* loader/DocumentLoader.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Remove duplicate identifier
+logic, and move navigation timing call to startLoadingMainResource, since
+it fits better logically there.
+* loader/ResourceLoader.h: No callers of setIdentifier() remain, so delete it.
+
 2012-03-27  Dirk Pranke  
 
 Unreviewed, rolling out r112277.


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (112307 => 112308)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2012-03-27 20:20:38 UTC (rev 112307)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2012-03-27 20:30:28 UTC (rev 112308)
@@ -791,11 +791,11 @@
 return m_mainResourceLoader && m_mainResourceLoader->isLoadingMultipartContent();
 }
 
-void DocumentLoader::startLoadingMainResource(unsigned long identifier)
+void DocumentLoader::startLoadingMainResource()
 {
+timing()->markNavigationStart(m_frame);
 ASSERT(!m_mainResourceLoader);
 m_mainResourceLoader = MainResourceLoader::create(m_frame);
-m_mainResourceLoader->setIdentifier(identifier);
 
 // FIXME: Is there any way the extra fields could have not been added by now?
 // If not, it would be great to remove this line of code.


Modified: trunk/Source/WebCore/loader/DocumentLoader.h (112307 => 112308)

--- trunk/Source/WebCore/loader/DocumentLoader.h	2012-03-27 20:20:38 UTC (rev 112307)
+++ trunk/Source/WebCore/loader/DocumentLoader.h	2012-03-27 20:30:28 UTC (rev 112308)
@@ -193,7 +193,7 @@
 
 void setDefersLoading(bool);
 
-void startLoadingMainResource(unsigned long identifier);
+void startLoadingMainResource();
 void cancelMainResourceLoad(const ResourceError&);
 
 // Support iconDatabase in synchronous mode.


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (112307 => 112308)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2012-03-27 20:20:38 UTC (rev 112307)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2012-03-27 20:30:28 UTC (rev 112308)
@@ -2226,16 +2226,7 @@
 return;
 
 m_loadingFromCachedPage = false;
-
-unsigned long identifier = 0;
-
-if (Page* page = m_frame->page()) {
-identifier = page->progress()->createUniqueIdentifier();
-notifier()->assignIdentifierToInitialRequest(identifier, m_provisionalDocumentLoader.get(), m_provisionalDocumentLoader->originalRequest());
-}
-
-m_provisionalDocumentLoader->timing()->markNavigationStart(frame());
-m_provisionalDocumentLoader->startLoadingMainResource(identifier);
+m_provisionalDocumentLoader->startLoadingMainResource();
 }
 
 static KURL originatingURLFromBackForwardList(

[webkit-changes] [112307] trunk/LayoutTests

[dpranke]

Title: [112307] trunk/LayoutTests








Revision 112307
Author dpra...@chromium.org
Date 2012-03-27 13:20:38 -0700 (Tue, 27 Mar 2012)


Log Message
Unreviewed, expectations change.

Mark css3/filters/custom/effect-custom-parameters.html as an image failure on linux debug, 32-bit

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112306 => 112307)

--- trunk/LayoutTests/ChangeLog	2012-03-27 20:18:09 UTC (rev 112306)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 20:20:38 UTC (rev 112307)
@@ -1,3 +1,11 @@
+2012-03-27  Dirk Pranke  
+
+Unreviewed, expectations change.
+
+Mark css3/filters/custom/effect-custom-parameters.html as an image failure on linux debug, 32-bit
+
+* platform/chromium/test_expectations.txt:
+
 2012-03-27  Joe Thomas  
 
 Implement vw/vh/vmin (viewport sizes) from CSS3 Values and Units


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112306 => 112307)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-27 20:18:09 UTC (rev 112306)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-27 20:20:38 UTC (rev 112307)
@@ -4383,3 +4383,6 @@
 
 BUGWK82300 SNOWLEOPARD : compositing/color-matching/pdf-image-match.html = IMAGE
 BUGWK82300 SNOWLEOPARD : compositing/images/direct-pdf-image.html = IMAGE
+
+BUGWK82372 LINUX X86_64 DEBUG : css3/filters/custom/effect-custom-parameters.html = IMAGE
+BUGWK82372 LINUX X86 RELEASE : css3/filters/custom/effect-custom-parameters.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112306] trunk/Source/WebCore

[dpranke]

Title: [112306] trunk/Source/WebCore








Revision 112306
Author dpra...@chromium.org
Date 2012-03-27 13:18:09 -0700 (Tue, 27 Mar 2012)


Log Message
Unreviewed, rolling out r112277.
http://trac.webkit.org/changeset/112277
https://bugs.webkit.org/show_bug.cgi?id=81985

possibly causing crashes?

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):
* xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp
trunk/Source/WebCore/xml/XMLErrors.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112305 => 112306)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 20:08:07 UTC (rev 112305)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 20:18:09 UTC (rev 112306)
@@ -1,3 +1,19 @@
+2012-03-27  Dirk Pranke  
+
+Unreviewed, rolling out r112277.
+http://trac.webkit.org/changeset/112277
+https://bugs.webkit.org/show_bug.cgi?id=81985
+
+possibly causing crashes?
+
+* svg/SVGUseElement.cpp:
+(WebCore::SVGUseElement::insertedIntoDocument):
+(WebCore::SVGUseElement::svgAttributeChanged):
+(WebCore::SVGUseElement::willRecalcStyle):
+(WebCore::SVGUseElement::finishParsingChildren):
+* xml/XMLErrors.cpp:
+(WebCore::XMLErrors::insertErrorMessageBlock):
+
 2012-03-27  Joseph Pecoraro  
 
  Web Inspector: Provide private -[DOMNode inspect]


Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (112305 => 112306)

--- trunk/Source/WebCore/svg/SVGUseElement.cpp	2012-03-27 20:08:07 UTC (rev 112305)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp	2012-03-27 20:18:09 UTC (rev 112306)
@@ -181,8 +181,7 @@
 SVGStyledTransformableElement::insertedIntoDocument();
 ASSERT(!m_targetElementInstance || !isWellFormedDocument(document()));
 ASSERT(!hasPendingResources() || !isWellFormedDocument(document()));
-if (!m_wasInsertedByParser)
-buildPendingResource();
+buildPendingResource();
 SVGExternalResourcesRequired::insertedIntoDocument(this);
 }
 
@@ -253,8 +252,7 @@
 m_cachedDocument->removeClient(this);
 m_cachedDocument = 0;
 }
-if (!m_wasInsertedByParser)
-buildPendingResource();
+buildPendingResource();
 return;
 }
 
@@ -272,7 +270,7 @@
 
 bool SVGUseElement::willRecalcStyle(StyleChange)
 {
-if (!m_wasInsertedByParser && m_needsShadowTreeRecreation && renderer() && needsStyleRecalc())
+if (m_needsShadowTreeRecreation && renderer() && needsStyleRecalc())
 buildPendingResource();
 return true;
 }
@@ -955,10 +953,6 @@
 {
 SVGStyledTransformableElement::finishParsingChildren();
 SVGExternalResourcesRequired::finishParsingChildren();
-if (m_wasInsertedByParser) {
-buildPendingResource();
-m_wasInsertedByParser = false;
-}
 }
 
 }


Modified: trunk/Source/WebCore/xml/XMLErrors.cpp (112305 => 112306)

--- trunk/Source/WebCore/xml/XMLErrors.cpp	2012-03-27 20:08:07 UTC (rev 112305)
+++ trunk/Source/WebCore/xml/XMLErrors.cpp	2012-03-27 20:18:09 UTC (rev 112306)
@@ -144,10 +144,11 @@
 body->parserAddChild(documentElement);
 m_document->parserAddChild(rootElement.get());
 
-if (m_document->attached())
-// In general, rootElement shouldn't be attached right now, but it will be if there is a style element
-// in the SVG content.
+if (m_document->attached()) {
+// rootElement shouldn't be attached right now, but in some cases might be.
+// See https://bugs.webkit.org/show_bug.cgi?id=81985
 rootElement->reattach();
+}
 
 documentElement = body.get();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112305] trunk/Source/WebCore

[commit-queue]

Title: [112305] trunk/Source/WebCore








Revision 112305
Author commit-qu...@webkit.org
Date 2012-03-27 13:08:07 -0700 (Tue, 27 Mar 2012)


Log Message
 Web Inspector: Provide private -[DOMNode inspect]

Patch by Joseph Pecoraro  on 2012-03-27
Reviewed by Timothy Hatcher.

No new tests, this is only an ObjC SPI.

* bindings/objc/DOM.mm:
* bindings/objc/DOMPrivate.h:
(-[DOMNode inspect]):
Call through to InspectorController inspect for the node.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::inspect):
Whenever we inspect an element, clear the node search.
The frontend already takes this approach.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/objc/DOM.mm
trunk/Source/WebCore/bindings/objc/DOMPrivate.h
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112304 => 112305)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 20:06:14 UTC (rev 112304)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 20:08:07 UTC (rev 112305)
@@ -1,3 +1,22 @@
+2012-03-27  Joseph Pecoraro  
+
+ Web Inspector: Provide private -[DOMNode inspect]
+
+Reviewed by Timothy Hatcher.
+
+No new tests, this is only an ObjC SPI.
+
+* bindings/objc/DOM.mm:
+* bindings/objc/DOMPrivate.h:
+(-[DOMNode inspect]):
+Call through to InspectorController inspect for the node.
+
+* inspector/InspectorDOMAgent.cpp:
+(WebCore::InspectorDOMAgent::handleMousePress):
+(WebCore::InspectorDOMAgent::inspect):
+Whenever we inspect an element, clear the node search.
+The frontend already takes this approach.
+
 2012-03-27  Joe Mason  
 
 [BlackBerry] fix confusing destruction sequence in LayerCompositingThread


Modified: trunk/Source/WebCore/bindings/objc/DOM.mm (112304 => 112305)

--- trunk/Source/WebCore/bindings/objc/DOM.mm	2012-03-27 20:06:14 UTC (rev 112304)
+++ trunk/Source/WebCore/bindings/objc/DOM.mm	2012-03-27 20:08:07 UTC (rev 112305)
@@ -44,6 +44,11 @@
 #import "WebScriptObjectPrivate.h"
 #import 
 
+#if ENABLE(INSPECTOR)
+#import "InspectorController.h"
+#import "Page.h"
+#endif
+
 #if ENABLE(SVG_DOM_OBJC_BINDINGS)
 #import "DOMSVG.h"
 #import "SVGElementInstance.h"
@@ -389,6 +394,18 @@
 range->textRects(rects);
 return kit(rects);
 }
+
+- (void)inspect
+{
+#if ENABLE(INSPECTOR)
+WebCore::Node* node = core(self);
+if (WebCore::Document* document = node->document()) {
+if (WebCore::Page* page = document->page())
+page->inspectorController()->inspect(node);
+}
+#endif
+}
+
 @end
 
 @implementation DOMRange (DOMRangeExtensions)


Modified: trunk/Source/WebCore/bindings/objc/DOMPrivate.h (112304 => 112305)

--- trunk/Source/WebCore/bindings/objc/DOMPrivate.h	2012-03-27 20:06:14 UTC (rev 112304)
+++ trunk/Source/WebCore/bindings/objc/DOMPrivate.h	2012-03-27 20:08:07 UTC (rev 112305)
@@ -29,6 +29,7 @@
 @interface DOMNode (DOMNodeExtensionsPendingPublic)
 - (NSImage *)renderedImage;
 - (NSArray *)textRects;
+- (void)inspect;
 @end
 
 // FIXME: this should be removed as soon as all internal Apple uses of it have been replaced with


Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (112304 => 112305)

--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2012-03-27 20:06:14 UTC (rev 112304)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2012-03-27 20:08:07 UTC (rev 112305)
@@ -914,7 +914,6 @@
 
 if (m_highlightData && m_highlightData->node) {
 RefPtr node = m_highlightData->node;
-setSearchingForNode(false, 0);
 inspect(node.get());
 }
 return true;
@@ -922,6 +921,8 @@
 
 void InspectorDOMAgent::inspect(Node* node)
 {
+setSearchingForNode(false, 0);
+
 if (node->nodeType() != Node::ELEMENT_NODE && node->nodeType() != Node::DOCUMENT_NODE)
 node = node->parentNode();
 m_nodeToFocus = node;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112304] trunk/Source/WebCore

[commit-queue]

Title: [112304] trunk/Source/WebCore








Revision 112304
Author commit-qu...@webkit.org
Date 2012-03-27 13:06:14 -0700 (Tue, 27 Mar 2012)


Log Message
[BlackBerry] fix confusing destruction sequence in LayerCompositingThread
https://bugs.webkit.org/show_bug.cgi?id=81706

Patch by Joe Mason  on 2012-03-27
Reviewed by Rob Buis.

LayerCompositingThread has a destructor that does a synchronous
dispatch to the compositing thread and then does the actual cleanup
from a helper function. This is confusing.It should be the
opposite: the helper function dispatches to the compositing thread,
which calls delete.

No new tests since the existing animation tests will exercise this
code.

* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::destroyOnCompositingThread):
(WebCore):
(WebCore::LayerCompositingThread::~LayerCompositingThread):
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
(WTF):
(WTFderef):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp
trunk/Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112303 => 112304)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 19:36:20 UTC (rev 112303)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 20:06:14 UTC (rev 112304)
@@ -1,3 +1,28 @@
+2012-03-27  Joe Mason  
+
+[BlackBerry] fix confusing destruction sequence in LayerCompositingThread
+https://bugs.webkit.org/show_bug.cgi?id=81706
+
+Reviewed by Rob Buis.
+
+LayerCompositingThread has a destructor that does a synchronous
+dispatch to the compositing thread and then does the actual cleanup
+from a helper function. This is confusing.It should be the
+opposite: the helper function dispatches to the compositing thread,
+which calls delete.
+
+No new tests since the existing animation tests will exercise this
+code.
+
+* platform/graphics/blackberry/LayerCompositingThread.cpp:
+(WebCore::LayerCompositingThread::destroyOnCompositingThread):
+(WebCore):
+(WebCore::LayerCompositingThread::~LayerCompositingThread):
+* platform/graphics/blackberry/LayerCompositingThread.h:
+(LayerCompositingThread):
+(WTF):
+(WTFderef):
+
 2012-03-27  Alexey Proskuryakov  
 
 [Mac] Stop using NSMapTable in FormDataStreamMac.mm


Modified: trunk/Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp (112303 => 112304)

--- trunk/Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp	2012-03-27 19:36:20 UTC (rev 112303)
+++ trunk/Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp	2012-03-27 20:06:14 UTC (rev 112304)
@@ -71,14 +71,6 @@
 {
 }
 
-LayerCompositingThread::~LayerCompositingThread()
-{
-// Unfortunately, ThreadSafeShared is hardwired to call T::~T().
-// To switch threads in case the last reference is released on the
-// WebKit thread, we send a sync message to the compositing thread.
-destroyOnCompositingThread();
-}
-
 void LayerCompositingThread::destroyOnCompositingThread()
 {
 if (!isCompositingThread()) {
@@ -88,6 +80,13 @@
 return;
 }
 
+delete this;
+}
+
+LayerCompositingThread::~LayerCompositingThread()
+{
+ASSERT(isCompositingThread());
+
 m_tiler->layerCompositingThreadDestroyed();
 
 ASSERT(!superlayer());


Modified: trunk/Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h (112303 => 112304)

--- trunk/Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h	2012-03-27 19:36:20 UTC (rev 112303)
+++ trunk/Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h	2012-03-27 20:06:14 UTC (rev 112304)
@@ -53,7 +53,6 @@
 
 namespace WebCore {
 
-class DestroyOnCompositingThread;
 class LayerRenderer;
 
 class LayerCompositingThread : public ThreadSafeRefCounted, public LayerData, public BlackBerry::Platform::GuardedPointerBase {
@@ -145,7 +144,7 @@
 private:
 LayerCompositingThread(LayerType, PassRefPtr);
 
-friend class DestroyOnCompositingThread;
+friend class WTF::ThreadSafeRefCounted;
 void destroyOnCompositingThread();
 
 void updateTileContents(const IntRect& tile);
@@ -188,8 +187,25 @@
 RefPtr m_tiler;
 };
 
+} // namespace WebCore
+
+namespace WTF {
+
+// LayerCompositingThread objects must be destroyed on the compositing thread.
+// But it's possible for the last reference to be held by the WebKit thread.
+// So we create a custom specialization of ThreadSafeRefCounted which calls a
+// function that ensures the destructor is called on the correct thread, rather
+// than calling delete directly.
+template<>
+inline void ThreadSafeRefCounted::deref()
+{
+if (derefBase())
+static_cast(this)->destroyOnCompositingThread();
 }
 
+} // namespace WTF
+
+
 #endif // USE(ACCELERA

[webkit-changes] [112303] trunk

[commit-queue]

Title: [112303] trunk








Revision 112303
Author commit-qu...@webkit.org
Date 2012-03-27 12:36:20 -0700 (Tue, 27 Mar 2012)


Log Message
Show image diffs for gpu_tests on flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=81848

Patch by Dave Tu  on 2012-03-27
Reviewed by Ojan Vafai.

Add a new results layout for gpu_tests that pulls the image diffs in
addition to the text output. Also add new gpu_tests builders.

* Tools/TestResultServer/static-dashboards/builders.js: Update
gpu_tests builders.
* Tools/TestResultServer/static-dashboards/dashboard_base.js: Add a
function to check for GPU test type.
* Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:
Add new GPU results layout.

Modified Paths

trunk/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/builders.js
trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html




Diff

Modified: trunk/ChangeLog (112302 => 112303)

--- trunk/ChangeLog	2012-03-27 19:32:36 UTC (rev 112302)
+++ trunk/ChangeLog	2012-03-27 19:36:20 UTC (rev 112303)
@@ -1,3 +1,20 @@
+2012-03-27  Dave Tu  
+
+Show image diffs for gpu_tests on flakiness dashboard
+https://bugs.webkit.org/show_bug.cgi?id=81848
+
+Reviewed by Ojan Vafai.
+
+Add a new results layout for gpu_tests that pulls the image diffs in
+addition to the text output. Also add new gpu_tests builders.
+
+* Tools/TestResultServer/static-dashboards/builders.js: Update
+gpu_tests builders.
+* Tools/TestResultServer/static-dashboards/dashboard_base.js: Add a
+function to check for GPU test type.
+* Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:
+Add new GPU results layout.
+
 2012-03-26  Ryosuke Niwa  
 
 Trigger a build on Chromium Linux boxes to see if clean builds succeed or not.


Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (112302 => 112303)

--- trunk/Tools/TestResultServer/static-dashboards/builders.js	2012-03-27 19:32:36 UTC (rev 112302)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js	2012-03-27 19:36:20 UTC (rev 112303)
@@ -51,6 +51,7 @@
 'Chromium': '@DEPS - chromium.org',
 'ChromiumChromiumOS': '@DEPS CrOS - chromium.org',
 'ChromiumGPU': '@DEPS - chromium.org',
+'ChromiumGPUFYI': '@DEPS FYI - chromium.org',
 'ChromiumWebkit': '@ToT - chromium.org',
 'webkit.org': '@ToT - webkit.org'
 };
@@ -161,11 +162,15 @@
 ['Mac Release (ATI)'],
 ['Linux Release (ATI)'],
 ['Linux Release (Intel)'],
+['Win7 Audio'],
+['Linux Audio'],
 ];
 associateBuildersWithMaster(CHROMIUM_GPU_FYI_GTESTS_DEPS_BUILDERS, CHROMIUM_GPU_FYI_BUILDER_MASTER);
 
 var CHROMIUM_GPU_GTESTS_TOT_BUILDERS = [
-['GPU Win7 (dbg) (NVIDIA)', BuilderGroup.DEFAULT_BUILDER],
+['GPU Win7 (NVIDIA)', BuilderGroup.DEFAULT_BUILDER],
+['GPU Win7 (dbg) (NVIDIA)'],
+['GPU Mac'],
 ['GPU Mac (dbg)'],
 ['GPU Linux (dbg) (NVIDIA)'],
 ];


Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (112302 => 112303)

--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2012-03-27 19:32:36 UTC (rev 112302)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2012-03-27 19:36:20 UTC (rev 112303)
@@ -422,6 +422,11 @@
 return g_currentState.testType == 'layout-tests';
 }
 
+function isGPUTestResults()
+{
+return g_currentState.testType == 'gpu_tests';
+}
+
 function currentBuilderGroupCategory(opt_state)
 {
 var state = opt_state || g_currentState;


Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html (112302 => 112303)

--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html	2012-03-27 19:32:36 UTC (rev 112302)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html	2012-03-27 19:36:20 UTC (rev 112303)
@@ -262,6 +262,9 @@
 .non-webkit-results {
 width: 99%;
 }
+.gpu-test-results {
+width: 400px;
+}
 .used-platform {
 float: right;
 color: darkblue;
@@ -1213,8 +1216,8 @@
 console.error('Index exceeds number of results: ' + index);
 }
 
-// Returns an array of buildNumbers for all builds where this test failed.
-function buildNumbersForFailures(builder, testName)
+// Returns an array of indexes for all builds where this test failed.
+function indexesForFailures(builder, testName)
 {
 var rawResults = g_resultsByBuilder[builder].tests[testName].results;
 var buildNumbers = g_resultsByBuilder[builder].buildNumbers;
@@ -1224,7 +1227,7 @@
 var numResults = rawResults[i][RLE.LENGTH];
 if (isFailingResult(rawResults[i][RLE.VALUE])) {
 for (var j = 0; j < numResults; j++)
-failures.push(buildNumbers[index + j]);
+failures.push(index + j);
 }
 index += numResults;
 }
@@ -1829,16 +1832,17 @@
 html += '' +
 linkHTM

[webkit-changes] [112302] trunk/Source/WebCore

[ap]

Title: [112302] trunk/Source/WebCore








Revision 112302
Author a...@apple.com
Date 2012-03-27 12:32:36 -0700 (Tue, 27 Mar 2012)


Log Message
[Mac] Stop using NSMapTable in FormDataStreamMac.mm
https://bugs.webkit.org/show_bug.cgi?id=82358

Reviewed by Darin Adler.

* platform/network/mac/FormDataStreamMac.mm: Use WTF::HashMap, as we always do. All accesses
are protected with a mutex anyway.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/FormDataStreamMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (112301 => 112302)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 19:19:59 UTC (rev 112301)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 19:32:36 UTC (rev 112302)
@@ -1,3 +1,13 @@
+2012-03-27  Alexey Proskuryakov  
+
+[Mac] Stop using NSMapTable in FormDataStreamMac.mm
+https://bugs.webkit.org/show_bug.cgi?id=82358
+
+Reviewed by Darin Adler.
+
+* platform/network/mac/FormDataStreamMac.mm: Use WTF::HashMap, as we always do. All accesses
+are protected with a mutex anyway.
+
 2012-03-27  Joe Thomas  
 
 Implement vw/vh/vmin (viewport sizes) from CSS3 Values and Units


Modified: trunk/Source/WebCore/platform/network/mac/FormDataStreamMac.mm (112301 => 112302)

--- trunk/Source/WebCore/platform/network/mac/FormDataStreamMac.mm	2012-03-27 19:19:59 UTC (rev 112301)
+++ trunk/Source/WebCore/platform/network/mac/FormDataStreamMac.mm	2012-03-27 19:32:36 UTC (rev 112302)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005, 2006, 2008, 2011 Apple Inc. All rights reserved.
+ * Copyright (C) 2005, 2006, 2008, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -57,12 +57,6 @@
 return staticMutex;
 }
 
-static NSMapTable *streamFieldsMap()
-{
-static NSMapTable *streamFieldsMap = NSCreateMapTable(NSNonRetainedObjectMapKeyCallBacks, NSNonOwnedPointerMapValueCallBacks, 1);
-return streamFieldsMap;
-}
-
 static void formEventCallback(CFReadStreamRef stream, CFStreamEventType type, void* context);
 
 struct FormContext {
@@ -84,6 +78,13 @@
 unsigned long long bytesSent;
 };
 
+typedef HashMap StreamFieldsMap;
+static StreamFieldsMap& streamFieldsMap()
+{
+DEFINE_STATIC_LOCAL(StreamFieldsMap, streamFieldsMap, ());
+return streamFieldsMap;
+}
+
 static void closeCurrentStream(FormStreamFields *form)
 {
 if (form->currentStream) {
@@ -189,8 +190,8 @@
 newInfo->remainingElements.append(newInfo->formData->elements()[size - i - 1]);
 
 MutexLocker locker(streamFieldsMapMutex());
-ASSERT(!NSMapGet(streamFieldsMap(), stream));
-NSMapInsertKnownAbsent(streamFieldsMap(), stream, newInfo);
+ASSERT(!streamFieldsMap().contains(stream));
+streamFieldsMap().add(stream, newInfo);
 
 return newInfo;
 }
@@ -209,13 +210,13 @@
 MutexLocker locker(streamFieldsMapMutex());
 
 ASSERT(form->formStream == stream);
-ASSERT(NSMapGet(streamFieldsMap(), stream) == context);
+ASSERT(streamFieldsMap().get(stream) == context);
 
 // Do this right away because the CFReadStreamRef is being deallocated.
 // We can't wait to remove this from the map until we finish finalizing
 // on the main thread because in theory the freed memory could be reused
 // for a new CFReadStream before that runs.
-NSMapRemove(streamFieldsMap(), stream);
+streamFieldsMap().remove(stream);
 
 callOnMainThread(formFinishFinalizationOnMainThread, form);
 }
@@ -435,7 +436,7 @@
 FormData* httpBodyFromStream(NSInputStream* stream)
 {
 MutexLocker locker(streamFieldsMapMutex());
-FormStreamFields* formStream = static_cast(NSMapGet(streamFieldsMap(), stream));
+FormStreamFields* formStream = streamFieldsMap().get(reinterpret_cast(stream));
 if (!formStream)
 return 0;
 return formStream->formData.get();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112298] trunk/Tools

[dpranke]

Title: [112298] trunk/Tools








Revision 112298
Author dpra...@chromium.org
Date 2012-03-27 12:15:53 -0700 (Tue, 27 Mar 2012)


Log Message
test-webkitpy: prepare for better test run output
https://bugs.webkit.org/show_bug.cgi?id=82290

Reviewed by Adam Barth.

This code basically re-implements the output of the TextTestRunner default
runner code from unittest, although the implementation is quite
different, in preparation for changing the test output to be
metered and possibly running in parallel.

The output is almost identical to before, except that instead of
logging "test_regular (webkitpy.main.RunnerTest) passed" we log
"webkitpy.main.RunnerTest.test_regular passed". It has always
annoyed me that they invert the names to be harder to read and
so that you can't copy & paste back to the input for
test-webkitpy.

This patch is provided to add a skeleton for unit tests and for
comparison to an upcoming patch that will actually add new
functionality.

* Scripts/webkitpy/test/main.py:
(Tester.__init__):
(Tester._configure_logging):
(Tester._run_tests):
* Scripts/webkitpy/test/runner.py: Added.
(TestRunner):
(TestRunner.__init__):
(TestRunner.test_name):
(TestRunner.all_test_names):
(TestRunner.run):
(TestRunner.write_result):
(TestRunner.write_summary):
* Scripts/webkitpy/test/runner_unittest.py: Added.
(FakeModuleSuite):
(FakeModuleSuite.__init__):
(FakeModuleSuite.__str__):
(FakeModuleSuite.run):
(FakeTopSuite):
(FakeTopSuite.__init__):
(FakeLoader):
(FakeLoader.__init__):
(FakeLoader.top_suite):
(FakeLoader.loadTestsFromName):
(RunnerTest):
(RunnerTest.test_regular):
(RunnerTest.test_verbose):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/test/main.py


Added Paths

trunk/Tools/Scripts/webkitpy/test/runner.py
trunk/Tools/Scripts/webkitpy/test/runner_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (112297 => 112298)

--- trunk/Tools/ChangeLog	2012-03-27 19:08:02 UTC (rev 112297)
+++ trunk/Tools/ChangeLog	2012-03-27 19:15:53 UTC (rev 112298)
@@ -1,3 +1,53 @@
+2012-03-27  Dirk Pranke  
+
+test-webkitpy: prepare for better test run output
+https://bugs.webkit.org/show_bug.cgi?id=82290
+
+Reviewed by Adam Barth.
+
+This code basically re-implements the output of the TextTestRunner default
+runner code from unittest, although the implementation is quite
+different, in preparation for changing the test output to be
+metered and possibly running in parallel.
+
+The output is almost identical to before, except that instead of
+logging "test_regular (webkitpy.main.RunnerTest) passed" we log
+"webkitpy.main.RunnerTest.test_regular passed". It has always
+annoyed me that they invert the names to be harder to read and
+so that you can't copy & paste back to the input for
+test-webkitpy.
+
+This patch is provided to add a skeleton for unit tests and for
+comparison to an upcoming patch that will actually add new
+functionality.
+
+* Scripts/webkitpy/test/main.py:
+(Tester.__init__):
+(Tester._configure_logging):
+(Tester._run_tests):
+* Scripts/webkitpy/test/runner.py: Added.
+(TestRunner):
+(TestRunner.__init__):
+(TestRunner.test_name):
+(TestRunner.all_test_names):
+(TestRunner.run):
+(TestRunner.write_result):
+(TestRunner.write_summary):
+* Scripts/webkitpy/test/runner_unittest.py: Added.
+(FakeModuleSuite):
+(FakeModuleSuite.__init__):
+(FakeModuleSuite.__str__):
+(FakeModuleSuite.run):
+(FakeTopSuite):
+(FakeTopSuite.__init__):
+(FakeLoader):
+(FakeLoader.__init__):
+(FakeLoader.top_suite):
+(FakeLoader.loadTestsFromName):
+(RunnerTest):
+(RunnerTest.test_regular):
+(RunnerTest.test_verbose):
+
 2012-03-27  Gustavo Noronha Silva  
 
 [GTK] Build gnutls without p11-kit support


Modified: trunk/Tools/Scripts/webkitpy/test/main.py (112297 => 112298)

--- trunk/Tools/Scripts/webkitpy/test/main.py	2012-03-27 19:08:02 UTC (rev 112297)
+++ trunk/Tools/Scripts/webkitpy/test/main.py	2012-03-27 19:15:53 UTC (rev 112298)
@@ -32,6 +32,7 @@
 
 from webkitpy.common.system.filesystem import FileSystem
 from webkitpy.test.test_finder import TestFinder
+from webkitpy.test.runner import TestRunner
 
 _log = logging.getLogger(__name__)
 
@@ -40,6 +41,7 @@
 def __init__(self, filesystem=None):
 self._verbosity = 1
 self.finder = TestFinder(filesystem or FileSystem())
+self.stream = sys.stderr
 
 def add_tree(self, top_directory, starting_subdirectory=None):
 self.finder.add_tree(top_directory, starting_subdirectory)
@@ -92,7 +94,7 @@
 except for messages from the autoinstall module.  Also set the
 logging level as described below.
 """
-handler = logging.StreamHandler(sys.stderr)
+

[webkit-changes] [112297] releases/WebKitGTK/webkit-1.7.92/

[mrobinson]

Title: [112297] releases/WebKitGTK/webkit-1.7.92/








Revision 112297
Author mrobin...@webkit.org
Date 2012-03-27 12:08:02 -0700 (Tue, 27 Mar 2012)


Log Message
Tagging the WebKitGTK+ 1.7.92 release

Added Paths

releases/WebKitGTK/webkit-1.7.92/




Diff

Property changes: releases/WebKitGTK/webkit-1.7.92



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112296] releases/WebKitGTK/webkit-1.8.0/webkit-1.8/

[mrobinson]

Title: [112296] releases/WebKitGTK/webkit-1.8.0/webkit-1.8/








Revision 112296
Author mrobin...@webkit.org
Date 2012-03-27 12:07:07 -0700 (Tue, 27 Mar 2012)


Log Message
Removing improperly tagged WebKitGTK+ release

Removed Paths

releases/WebKitGTK/webkit-1.8.0/webkit-1.8/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112295] releases/WebKitGTK/webkit-1.7.91/

[mrobinson]

Title: [112295] releases/WebKitGTK/webkit-1.7.91/








Revision 112295
Author mrobin...@webkit.org
Date 2012-03-27 11:59:04 -0700 (Tue, 27 Mar 2012)


Log Message
Tagging the WebKitGTK+ 1.7.91 release

Added Paths

releases/WebKitGTK/webkit-1.7.91/




Diff

Property changes: releases/WebKitGTK/webkit-1.7.91



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112294] trunk/Tools

[kov]

Title: [112294] trunk/Tools








Revision 112294
Author k...@webkit.org
Date 2012-03-27 11:58:08 -0700 (Tue, 27 Mar 2012)


Log Message
[GTK] Build gnutls without p11-kit support
https://bugs.webkit.org/show_bug.cgi?id=82212

Reviewed by Martin Robinson.

* gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
configure, to avoid requiring that dependency, which is not used
by libsoup and WebKit anyway

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (112293 => 112294)

--- trunk/Tools/ChangeLog	2012-03-27 18:56:38 UTC (rev 112293)
+++ trunk/Tools/ChangeLog	2012-03-27 18:58:08 UTC (rev 112294)
@@ -1,3 +1,14 @@
+2012-03-27  Gustavo Noronha Silva  
+
+[GTK] Build gnutls without p11-kit support
+https://bugs.webkit.org/show_bug.cgi?id=82212
+
+Reviewed by Martin Robinson.
+
+* gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
+configure, to avoid requiring that dependency, which is not used
+by libsoup and WebKit anyway
+
 2012-03-27  Csaba Osztrogonác  
 
 [Qt] Make debug build work on 32 bit


Modified: trunk/Tools/gtk/jhbuild.modules (112293 => 112294)

--- trunk/Tools/gtk/jhbuild.modules	2012-03-27 18:56:38 UTC (rev 112293)
+++ trunk/Tools/gtk/jhbuild.modules	2012-03-27 18:58:08 UTC (rev 112294)
@@ -134,7 +134,7 @@
   
 
   - autogenargs="--enable-ld-version-script --enable-cxx --without-lzo --with-libgcrypt">
+ autogenargs="--enable-ld-version-script --enable-cxx --without-lzo --with-libgcrypt --without-p11-kit">
  repo="gnu.org"
 hash="sha256:5ee72ba6de7a23cf315792561954451e022dac8730149ca95f93c61e95be2ce3"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112293] releases/WebKitGTK/webkit-1.8.0/webkit-1.8/

[mrobinson]

Title: [112293] releases/WebKitGTK/webkit-1.8.0/webkit-1.8/








Revision 112293
Author mrobin...@webkit.org
Date 2012-03-27 11:56:38 -0700 (Tue, 27 Mar 2012)


Log Message
Tagging the 1.8.0 release

Added Paths

releases/WebKitGTK/webkit-1.8.0/webkit-1.8/




Diff

Property changes: releases/WebKitGTK/webkit-1.8.0/webkit-1.8



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112292] releases/WebKitGTK/webkit-1.8.0/

[mrobinson]

Title: [112292] releases/WebKitGTK/webkit-1.8.0/








Revision 112292
Author mrobin...@webkit.org
Date 2012-03-27 11:54:21 -0700 (Tue, 27 Mar 2012)


Log Message
Tagging the 1.8.0 release

Added Paths

releases/WebKitGTK/webkit-1.8.0/




Diff

Property changes: releases/WebKitGTK/webkit-1.8.0



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112291] tags/Safari-536.4.1/Source

[lforschler]

Title: [112291] tags/Safari-536.4.1/Source








Revision 112291
Author lforsch...@apple.com
Date 2012-03-27 11:49:52 -0700 (Tue, 27 Mar 2012)


Log Message
Merge 111898.

Modified Paths

tags/Safari-536.4.1/Source/_javascript_Core/ChangeLog
tags/Safari-536.4.1/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_CoreSubmit.sln
tags/Safari-536.4.1/Source/WTF/ChangeLog


Added Paths

tags/Safari-536.4.1/Source/WTF/WTF.vcproj/WTF.make
tags/Safari-536.4.1/Source/WTF/WTF.vcproj/WTF.sln




Diff

Modified: tags/Safari-536.4.1/Source/_javascript_Core/ChangeLog (112290 => 112291)

--- tags/Safari-536.4.1/Source/_javascript_Core/ChangeLog	2012-03-27 18:45:28 UTC (rev 112290)
+++ tags/Safari-536.4.1/Source/_javascript_Core/ChangeLog	2012-03-27 18:49:52 UTC (rev 112291)
@@ -1,3 +1,16 @@
+2012-03-27  Lucas Forschler  
+
+Merge 111898
+
+2012-03-23  Steve Falkenburg  
+
+Update Apple Windows build files for WTF move
+https://bugs.webkit.org/show_bug.cgi?id=82069
+
+Reviewed by Jessie Berlin.
+
+* _javascript_Core.vcproj/_javascript_CoreSubmit.sln: Removed WTF and WTFGenerated.
+
 2012-03-21  Filip Pizlo  
 
 DFG speculation on booleans should be rationalized


Modified: tags/Safari-536.4.1/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_CoreSubmit.sln (112290 => 112291)

--- tags/Safari-536.4.1/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_CoreSubmit.sln	2012-03-27 18:45:28 UTC (rev 112290)
+++ tags/Safari-536.4.1/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_CoreSubmit.sln	2012-03-27 18:49:52 UTC (rev 112291)
@@ -7,22 +7,12 @@
 	EndProjectSection
 EndProject
 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "_javascript_CoreGenerated", "_javascript_Core\_javascript_CoreGenerated.vcproj", "{4FF5BA11-59EC-4C24-8F52-F235C2E7D43A}"
-	ProjectSection(ProjectDependencies) = postProject
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6} = {AA8A5A85-592B-4357-BC60-E0E91E026AF6}
-	EndProjectSection
 EndProject
 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "jsc", "jsc\jsc.vcproj", "{C59E5129-B453-49B7-A52B-1E104715F76E}"
 	ProjectSection(ProjectDependencies) = postProject
 		{011D10F1-B656-4A1B-A0C3-3842F02122C5} = {011D10F1-B656-4A1B-A0C3-3842F02122C5}
 	EndProjectSection
 EndProject
-Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "WTF", "..\..\WTF\WTF.vcproj\WTF.vcproj", "{AA8A5A85-592B-4357-BC60-E0E91E026AF6}"
-	ProjectSection(ProjectDependencies) = postProject
-		{5AE5F5E4-782D-4F63-B4D7-3977B52B9950} = {5AE5F5E4-782D-4F63-B4D7-3977B52B9950}
-	EndProjectSection
-EndProject
-Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "WTFGenerated", "..\..\WTF\WTF.vcproj\WTFGenerated.vcproj", "{5AE5F5E4-782D-4F63-B4D7-3977B52B9950}"
-EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug_All|Win32 = Debug_All|Win32
@@ -83,38 +73,6 @@
 		{C59E5129-B453-49B7-A52B-1E104715F76E}.Release_PGO|Win32.Build.0 = Release_PGO|Win32
 		{C59E5129-B453-49B7-A52B-1E104715F76E}.Release|Win32.ActiveCfg = Release|Win32
 		{C59E5129-B453-49B7-A52B-1E104715F76E}.Release|Win32.Build.0 = Release|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Debug_All|Win32.ActiveCfg = Debug_All|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Debug_All|Win32.Build.0 = Debug_All|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Debug_Cairo_CFLite|Win32.ActiveCfg = Debug_Cairo_CFLite|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Debug_Cairo_CFLite|Win32.Build.0 = Debug_Cairo_CFLite|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Debug|Win32.ActiveCfg = Debug|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Debug|Win32.Build.0 = Debug|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Production|Win32.ActiveCfg = Production|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Production|Win32.Build.0 = Production|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Release_Cairo_CFLite|Win32.ActiveCfg = Release_Cairo_CFLite|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Release_Cairo_CFLite|Win32.Build.0 = Release_Cairo_CFLite|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Release_PGO_Optimize|Win32.ActiveCfg = Production|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Release_PGO_Optimize|Win32.Build.0 = Production|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Release_PGO|Win32.ActiveCfg = Production|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Release_PGO|Win32.Build.0 = Production|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Release|Win32.ActiveCfg = Release|Win32
-		{AA8A5A85-592B-4357-BC60-E0E91E026AF6}.Release|Win32.Build.0 = Release|Win32
-		{5AE5F5E4-782D-4F63-B4D7-3977B52B9950}.Debug_All|Win32.ActiveCfg = Debug_All|Win32
-		{5AE5F5E4-782D-4F63-B4D7-3977B52B9950}.Debug_All|Win32.Build.0 = Debug_All|Win32
-		{5AE5F5E4-782D-4F63-B4D7-3977B52B9950}.Debug_Cairo_CFLite|Win32.ActiveCfg = Debug_Cairo_CFLite|Win32
-		{5AE5F5E4-782D-4F63-B4D7-3977B52B9950}.Debug_Cairo_CFLite|Win32.Build.0 = Debug_Cairo_CFLite|Win32
-		{5AE5F5E4

[webkit-changes] [112290] tags/Safari-536.4.1/Source

[lforschler]

Title: [112290] tags/Safari-536.4.1/Source








Revision 112290
Author lforsch...@apple.com
Date 2012-03-27 11:45:28 -0700 (Tue, 27 Mar 2012)


Log Message
Versioning.

Modified Paths

tags/Safari-536.4.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-536.4.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-536.4.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-536.4.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-536.4.1/Source/_javascript_Core/Configurations/Version.xcconfig (112289 => 112290)

--- tags/Safari-536.4.1/Source/_javascript_Core/Configurations/Version.xcconfig	2012-03-27 18:42:02 UTC (rev 112289)
+++ tags/Safari-536.4.1/Source/_javascript_Core/Configurations/Version.xcconfig	2012-03-27 18:45:28 UTC (rev 112290)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 536;
 MINOR_VERSION = 4;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-536.4.1/Source/WebCore/Configurations/Version.xcconfig (112289 => 112290)

--- tags/Safari-536.4.1/Source/WebCore/Configurations/Version.xcconfig	2012-03-27 18:42:02 UTC (rev 112289)
+++ tags/Safari-536.4.1/Source/WebCore/Configurations/Version.xcconfig	2012-03-27 18:45:28 UTC (rev 112290)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 536;
 MINOR_VERSION = 4;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-536.4.1/Source/WebKit/mac/Configurations/Version.xcconfig (112289 => 112290)

--- tags/Safari-536.4.1/Source/WebKit/mac/Configurations/Version.xcconfig	2012-03-27 18:42:02 UTC (rev 112289)
+++ tags/Safari-536.4.1/Source/WebKit/mac/Configurations/Version.xcconfig	2012-03-27 18:45:28 UTC (rev 112290)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 536;
 MINOR_VERSION = 4;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-536.4.1/Source/WebKit2/Configurations/Version.xcconfig (112289 => 112290)

--- tags/Safari-536.4.1/Source/WebKit2/Configurations/Version.xcconfig	2012-03-27 18:42:02 UTC (rev 112289)
+++ tags/Safari-536.4.1/Source/WebKit2/Configurations/Version.xcconfig	2012-03-27 18:45:28 UTC (rev 112290)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 536;
 MINOR_VERSION = 4;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112289] trunk/Source/WebKit2

[andersca]

Title: [112289] trunk/Source/WebKit2








Revision 112289
Author ander...@apple.com
Date 2012-03-27 11:42:02 -0700 (Tue, 27 Mar 2012)


Log Message
Don't update the layer hosting state unless the WKView is added to a window
https://bugs.webkit.org/show_bug.cgi?id=82359

Reviewed by Sam Weinig.

This avoids thrashing the layer hosting state when switching tabs.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (112288 => 112289)

--- trunk/Source/WebKit2/ChangeLog	2012-03-27 18:41:01 UTC (rev 112288)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-27 18:42:02 UTC (rev 112289)
@@ -1,3 +1,15 @@
+2012-03-27  Anders Carlsson  
+
+Don't update the layer hosting state unless the WKView is added to a window
+https://bugs.webkit.org/show_bug.cgi?id=82359
+
+Reviewed by Sam Weinig.
+
+This avoids thrashing the layer hosting state when switching tabs.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::viewStateDidChange):
+
 2012-03-27  Carlos Garcia Campos  
 
 Implement WebFrameNetworkingContext for soup in WebKit2


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (112288 => 112289)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2012-03-27 18:41:01 UTC (rev 112288)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2012-03-27 18:42:02 UTC (rev 112289)
@@ -778,10 +778,12 @@
 process()->send(Messages::WebPage::SetIsInWindow(isInWindow), m_pageID);
 }
 
-LayerHostingMode layerHostingMode = m_pageClient->viewLayerHostingMode();
-if (m_layerHostingMode != layerHostingMode) {
-m_layerHostingMode = layerHostingMode;
-m_drawingArea->layerHostingModeDidChange();
+if (isInWindow) {
+LayerHostingMode layerHostingMode = m_pageClient->viewLayerHostingMode();
+if (m_layerHostingMode != layerHostingMode) {
+m_layerHostingMode = layerHostingMode;
+m_drawingArea->layerHostingModeDidChange();
+}
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112288] tags/Safari-536.4.1/

[lforschler]

Title: [112288] tags/Safari-536.4.1/








Revision 112288
Author lforsch...@apple.com
Date 2012-03-27 11:41:01 -0700 (Tue, 27 Mar 2012)


Log Message
New Tag.

Added Paths

tags/Safari-536.4.1/




Diff

Property changes: tags/Safari-536.4.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112287] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [112287] trunk/Source/WebKit/blackberry








Revision 112287
Author commit-qu...@webkit.org
Date 2012-03-27 11:39:59 -0700 (Tue, 27 Mar 2012)


Log Message
[BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer
https://bugs.webkit.org/show_bug.cgi?id=82350

Switch timer in WebPageCompositor to use AnimationFrameRateController.

Patch by Andrew Lo  on 2012-03-27
Reviewed by Rob Buis.

* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp
trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp (112286 => 112287)

--- trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp	2012-03-27 18:18:42 UTC (rev 112286)
+++ trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp	2012-03-27 18:39:59 UTC (rev 112287)
@@ -43,17 +43,14 @@
 WebPageCompositorPrivate::WebPageCompositorPrivate(WebPagePrivate* page, WebPageCompositorClient* client)
 : m_client(client)
 , m_webPage(page)
-, m_animationTimer(this, &WebPageCompositorPrivate::animationTimerFired)
-, m_timerClient(new Platform::GenericTimerClient(Platform::userInterfaceThreadTimerClient()))
 , m_pendingAnimationFrame(0.0)
 {
-m_animationTimer.setClient(m_timerClient);
+setOneShot(true); // one-shot animation client
 }
 
 WebPageCompositorPrivate::~WebPageCompositorPrivate()
 {
-m_animationTimer.stop();
-delete m_timerClient;
+Platform::AnimationFrameRateController::instance()->removeClient(this);
 }
 
 void WebPageCompositorPrivate::setContext(Platform::Graphics::GLES2Context* context)
@@ -130,7 +127,7 @@
 if (m_client)
 m_pendingAnimationFrame = m_client->requestAnimationFrame();
 else {
-m_animationTimer.start(1.0 / 60.0);
+Platform::AnimationFrameRateController::instance()->addClient(this);
 m_webPage->updateDelegatedOverlays();
 }
 }
@@ -143,7 +140,7 @@
 m_layerRenderer->releaseLayerResources();
 }
 
-void WebPageCompositorPrivate::animationTimerFired()
+void WebPageCompositorPrivate::animationFrameChanged()
 {
 BackingStore* backingStore = m_webPage->m_backingStore;
 if (!backingStore) {


Modified: trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h (112286 => 112287)

--- trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h	2012-03-27 18:18:42 UTC (rev 112286)
+++ trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h	2012-03-27 18:39:59 UTC (rev 112287)
@@ -24,8 +24,8 @@
 #include "LayerCompositingThread.h"
 #include "LayerRenderer.h"
 
+#include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -41,7 +41,7 @@
 class WebPagePrivate;
 
 // This class may only be used on the compositing thread. So it does not need to be threadsaferefcounted.
-class WebPageCompositorPrivate : public RefCounted {
+class WebPageCompositorPrivate : public RefCounted, public Platform::AnimationFrameRateClient {
 public:
 static PassRefPtr create(WebPagePrivate* page, WebPageCompositorClient* client)
 {
@@ -86,7 +86,7 @@
 WebPageCompositorPrivate(WebPagePrivate*, WebPageCompositorClient*);
 
 private:
-void animationTimerFired();
+void animationFrameChanged();
 
 WebPageCompositorClient* m_client;
 WebPagePrivate* m_webPage;
@@ -96,8 +96,6 @@
 WebCore::IntRect m_layoutRectForCompositing;
 WebCore::IntSize m_contentsSizeForCompositing;
 WebCore::LayerRenderingResults m_lastCompositingResults;
-BlackBerry::Platform::Timer m_animationTimer;
-BlackBerry::Platform::TimerClient* m_timerClient;
 double m_pendingAnimationFrame;
 };
 


Modified: trunk/Source/WebKit/blackberry/ChangeLog (112286 => 112287)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-03-27 18:18:42 UTC (rev 112286)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-03-27 18:39:59 UTC (rev 112287)
@@ -1,3 +1,20 @@
+2012-03-27  Andrew Lo  
+
+[BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer
+https://bugs.webkit.org/show_bug.cgi?id=82350
+
+Switch timer in WebPageCompositor to use AnimationFrameRateController.
+
+Reviewed by Rob Buis.
+
+* Api/WebPageCompositor.cpp:
+(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
+(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
+(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
+(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
+* Api/WebPageComposit

[webkit-changes] [112285] trunk/Source/JavaScriptCore

[psolanki]

Title: [112285] trunk/Source/_javascript_Core








Revision 112285
Author psola...@apple.com
Date 2012-03-27 11:06:21 -0700 (Tue, 27 Mar 2012)


Log Message
Compiler warning when JIT is not enabled
https://bugs.webkit.org/show_bug.cgi?id=82352

Reviewed by Filip Pizlo.

* runtime/JSFunction.cpp:
(JSC::JSFunction::create):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSFunction.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (112284 => 112285)

--- trunk/Source/_javascript_Core/ChangeLog	2012-03-27 18:03:32 UTC (rev 112284)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-03-27 18:06:21 UTC (rev 112285)
@@ -1,3 +1,13 @@
+2012-03-27  Pratik Solanki  
+
+Compiler warning when JIT is not enabled
+https://bugs.webkit.org/show_bug.cgi?id=82352
+
+Reviewed by Filip Pizlo.
+
+* runtime/JSFunction.cpp:
+(JSC::JSFunction::create):
+
 2012-03-26  Thouraya ANDOLSI  
 
 Unaligned userspace access for SH4 platforms


Modified: trunk/Source/_javascript_Core/runtime/JSFunction.cpp (112284 => 112285)

--- trunk/Source/_javascript_Core/runtime/JSFunction.cpp	2012-03-27 18:03:32 UTC (rev 112284)
+++ trunk/Source/_javascript_Core/runtime/JSFunction.cpp	2012-03-27 18:06:21 UTC (rev 112285)
@@ -62,7 +62,9 @@
 JSFunction* JSFunction::create(ExecState* exec, JSGlobalObject* globalObject, int length, const Identifier& name, NativeFunction nativeFunction, Intrinsic intrinsic, NativeFunction nativeConstructor)
 {
 NativeExecutable* executable;
-#if ENABLE(JIT)
+#if !ENABLE(JIT)
+UNUSED_PARAM(intrinsic);
+#else
 if (intrinsic != NoIntrinsic && exec->globalData().canUseJIT()) {
 ASSERT(nativeConstructor == callHostFunctionAsConstructor);
 executable = exec->globalData().getHostFunction(nativeFunction, intrinsic);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112284] trunk/Source/WebCore

[leviw]

Title: [112284] trunk/Source/WebCore








Revision 112284
Author le...@chromium.org
Date 2012-03-27 11:03:32 -0700 (Tue, 27 Mar 2012)


Log Message
Correct SVG paint functions that are still using IntPoints
https://bugs.webkit.org/show_bug.cgi?id=82343

Reviewed by Eric Seidel.

Two small corrections to SVG paint functions that should use LayoutPoint instead
of IntPoint.

No new tests. No change in behavior.

* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::paint):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112283 => 112284)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 18:00:50 UTC (rev 112283)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 18:03:32 UTC (rev 112284)
@@ -1,3 +1,20 @@
+2012-03-27  Levi Weintraub  
+
+Correct SVG paint functions that are still using IntPoints
+https://bugs.webkit.org/show_bug.cgi?id=82343
+
+Reviewed by Eric Seidel.
+
+Two small corrections to SVG paint functions that should use LayoutPoint instead
+of IntPoint.
+
+No new tests. No change in behavior.
+
+* rendering/svg/RenderSVGShape.cpp:
+(WebCore::RenderSVGShape::paint):
+* rendering/svg/RenderSVGText.cpp:
+(WebCore::RenderSVGText::paint):
+
 2012-03-27  Zalan Bujtas  
 
 Frame flattening: childframe in FrameView::layout() needs protector.


Modified: trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp (112283 => 112284)

--- trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp	2012-03-27 18:00:50 UTC (rev 112283)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp	2012-03-27 18:03:32 UTC (rev 112284)
@@ -318,7 +318,7 @@
 
 }
 
-void RenderSVGShape::paint(PaintInfo& paintInfo, const IntPoint&)
+void RenderSVGShape::paint(PaintInfo& paintInfo, const LayoutPoint&)
 {
 if (paintInfo.context->paintingDisabled() || style()->visibility() == HIDDEN || isEmpty())
 return;


Modified: trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp (112283 => 112284)

--- trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp	2012-03-27 18:00:50 UTC (rev 112283)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp	2012-03-27 18:03:32 UTC (rev 112284)
@@ -333,7 +333,7 @@
 PaintInfo blockInfo(paintInfo);
 GraphicsContextStateSaver stateSaver(*blockInfo.context);
 blockInfo.applyTransform(localToParentTransform());
-RenderBlock::paint(blockInfo, IntPoint());
+RenderBlock::paint(blockInfo, LayoutPoint());
 }
 
 FloatRect RenderSVGText::strokeBoundingBox() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112283] trunk/Source/WebCore

[commit-queue]

Title: [112283] trunk/Source/WebCore








Revision 112283
Author commit-qu...@webkit.org
Date 2012-03-27 11:00:50 -0700 (Tue, 27 Mar 2012)


Log Message
Frame flattening: childframe in FrameView::layout() needs protector.
https://bugs.webkit.org/show_bug.cgi?id=82345

Patch by Zalan Bujtas  on 2012-03-27
Reviewed by Kenneth Rohde Christiansen.

RefPtr protector(this) is supposed to protect the current frameview in
FrameView::layout() from being destroyed by recalcStyle().
However, when frame flattening is on and a child frame is re-starting layout from
the topmost parent, the protection is missing and parent's recalcStyle()
can destroy the child frame.
Moving the protector before the layout re-starting is initiated makes the child frame
safe.

No new tests. Unable to create a test case, where this scenario is reproducible.

* page/FrameView.cpp:
(WebCore::FrameView::layout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112282 => 112283)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 17:47:39 UTC (rev 112282)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 18:00:50 UTC (rev 112283)
@@ -1,3 +1,23 @@
+2012-03-27  Zalan Bujtas  
+
+Frame flattening: childframe in FrameView::layout() needs protector.
+https://bugs.webkit.org/show_bug.cgi?id=82345
+
+Reviewed by Kenneth Rohde Christiansen.
+
+RefPtr protector(this) is supposed to protect the current frameview in
+FrameView::layout() from being destroyed by recalcStyle().
+However, when frame flattening is on and a child frame is re-starting layout from
+the topmost parent, the protection is missing and parent's recalcStyle()
+can destroy the child frame.
+Moving the protector before the layout re-starting is initiated makes the child frame
+safe.
+
+No new tests. Unable to create a test case, where this scenario is reproducible.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::layout):
+
 2012-03-27  Antti Koivisto  
 
 Construct CSSCharsetRule on CSSOM API access only 


Modified: trunk/Source/WebCore/page/FrameView.cpp (112282 => 112283)

--- trunk/Source/WebCore/page/FrameView.cpp	2012-03-27 17:47:39 UTC (rev 112282)
+++ trunk/Source/WebCore/page/FrameView.cpp	2012-03-27 18:00:50 UTC (rev 112283)
@@ -916,6 +916,9 @@
 if (m_inLayout)
 return;
 
+// Protect the view from being deleted during layout (in recalcStyle)
+RefPtr protector(this);
+
 bool inChildFrameLayoutWithFrameFlattening = isInChildFrameWithFrameFlattening();
 
 if (inChildFrameLayoutWithFrameFlattening) {
@@ -936,9 +939,6 @@
 m_delayedLayout = false;
 m_setNeedsLayoutWasDeferred = false;
 
-// Protect the view from being deleted during layout (in recalcStyle)
-RefPtr protector(this);
-
 if (!m_frame) {
 // FIXME: Do we need to set m_size.width here?
 // FIXME: Should we set m_size.height here too?






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112282] trunk/Tools

[ossy]

Title: [112282] trunk/Tools








Revision 112282
Author o...@webkit.org
Date 2012-03-27 10:47:39 -0700 (Tue, 27 Mar 2012)


Log Message
[Qt] Make debug build work on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=82331

Use --no-keep-memory option of ld not to cache the symbol tables of input files in
memory to avoid memory exhaustion during the linking phase for x86-debug builds.

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/unix/default_post.prf:
* qmake/mkspecs/features/unix/default_pre.prf:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/unix/default_post.prf
trunk/Tools/qmake/mkspecs/features/unix/default_pre.prf




Diff

Modified: trunk/Tools/ChangeLog (112281 => 112282)

--- trunk/Tools/ChangeLog	2012-03-27 17:46:59 UTC (rev 112281)
+++ trunk/Tools/ChangeLog	2012-03-27 17:47:39 UTC (rev 112282)
@@ -1,3 +1,16 @@
+2012-03-27  Csaba Osztrogonác  
+
+[Qt] Make debug build work on 32 bit
+https://bugs.webkit.org/show_bug.cgi?id=82331
+
+Use --no-keep-memory option of ld not to cache the symbol tables of input files in
+memory to avoid memory exhaustion during the linking phase for x86-debug builds.
+
+Reviewed by Tor Arne Vestbø.
+
+* qmake/mkspecs/features/unix/default_post.prf:
+* qmake/mkspecs/features/unix/default_pre.prf:
+
 2012-03-23  Balazs Ankes  
 
 Add png checking to check-webkit-style


Modified: trunk/Tools/qmake/mkspecs/features/unix/default_post.prf (112281 => 112282)

--- trunk/Tools/qmake/mkspecs/features/unix/default_post.prf	2012-03-27 17:46:59 UTC (rev 112281)
+++ trunk/Tools/qmake/mkspecs/features/unix/default_post.prf	2012-03-27 17:47:39 UTC (rev 112282)
@@ -30,4 +30,13 @@
 
 contains(TEMPLATE, app): CONFIG += rpath
 
+isEqual(QT_ARCH,i386):CONFIG(debug, debug|release) {
+  # Make ld don't cache the symbol tables of input files in memory to avoid memory exhaustion during the linking phase.
+  # We have to use ld, because --no-keep-memory isn't supported by ld.gold.
+  QMAKE_LFLAGS += -Wl,--no-keep-memory
+} else {
+  # Use gold if available
+  !scratchbox:!mac:exists(/usr/bin/ld.gold): QMAKE_LFLAGS += -fuse-ld=gold
+}
+
 load(default_post)


Modified: trunk/Tools/qmake/mkspecs/features/unix/default_pre.prf (112281 => 112282)

--- trunk/Tools/qmake/mkspecs/features/unix/default_pre.prf	2012-03-27 17:46:59 UTC (rev 112281)
+++ trunk/Tools/qmake/mkspecs/features/unix/default_pre.prf	2012-03-27 17:47:39 UTC (rev 112282)
@@ -12,9 +12,6 @@
 SBOX_CHECK = $$(_SBOX_DIR)
 !isEmpty(SBOX_CHECK): CONFIG += scratchbox
 
-# Use gold if available
-!scratchbox:!mac:exists(/usr/bin/ld.gold): QMAKE_LFLAGS += -fuse-ld=gold
-
 # If Qt is configured with embedded or QPA we set a convenience config
 # flag that can be used to test for either of these situations.
 contains(QT_CONFIG, qpa)|contains(QT_CONFIG, embedded): CONFIG += embedded






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112281] trunk/Source/WebCore

[antti]

Title: [112281] trunk/Source/WebCore








Revision 112281
Author an...@apple.com
Date 2012-03-27 10:46:59 -0700 (Tue, 27 Mar 2012)


Log Message
Construct CSSCharsetRule on CSSOM API access only 
https://bugs.webkit.org/show_bug.cgi?id=82332

Reviewed by Andreas Kling.

Charset is just a string. There is usually no need to construct CSSCharsetRule at all.

- Make CSS parser to return encoding string instead of CSSCharsetRule object. This
  string is used for constructing CSSCharsetRule if it is needed (and nothing else,
  @charset has no effect after string decoding).
- Remove internal interface for adding and removing rules. It has no clients.

* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore):
* css/CSSParser.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::parserAppendRule):
(WebCore::CSSStyleSheet::ensureCharsetRule):
(WebCore):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::clearCharsetRule):
(WebCore::CSSStyleSheet::clearRules):
(WebCore::CSSStyleSheet::parserSetEncodingFromCharsetRule):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::deleteRule):
* css/CSSStyleSheet.h:
(WebCore):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::ruleVector):
(WebCore::CSSStyleSheet::hasCharsetRule):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::reparseStyleSheet):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParser.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSheet.cpp
trunk/Source/WebCore/css/CSSStyleSheet.h
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112280 => 112281)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 17:44:28 UTC (rev 112280)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 17:46:59 UTC (rev 112281)
@@ -1,3 +1,45 @@
+2012-03-27  Antti Koivisto  
+
+Construct CSSCharsetRule on CSSOM API access only 
+https://bugs.webkit.org/show_bug.cgi?id=82332
+
+Reviewed by Andreas Kling.
+
+Charset is just a string. There is usually no need to construct CSSCharsetRule at all.
+
+- Make CSS parser to return encoding string instead of CSSCharsetRule object. This
+  string is used for constructing CSSCharsetRule if it is needed (and nothing else,
+  @charset has no effect after string decoding).
+- Remove internal interface for adding and removing rules. It has no clients.
+
+* css/CSSGrammar.y:
+* css/CSSParser.cpp:
+(WebCore):
+* css/CSSParser.h:
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+* css/CSSStyleSheet.cpp:
+(WebCore::CSSStyleSheet::~CSSStyleSheet):
+(WebCore::CSSStyleSheet::parserAppendRule):
+(WebCore::CSSStyleSheet::ensureCharsetRule):
+(WebCore):
+(WebCore::CSSStyleSheet::length):
+(WebCore::CSSStyleSheet::item):
+(WebCore::CSSStyleSheet::clearCharsetRule):
+(WebCore::CSSStyleSheet::clearRules):
+(WebCore::CSSStyleSheet::parserSetEncodingFromCharsetRule):
+(WebCore::CSSStyleSheet::rules):
+(WebCore::CSSStyleSheet::insertRule):
+(WebCore::CSSStyleSheet::addRule):
+(WebCore::CSSStyleSheet::deleteRule):
+* css/CSSStyleSheet.h:
+(WebCore):
+(CSSStyleSheet):
+(WebCore::CSSStyleSheet::ruleVector):
+(WebCore::CSSStyleSheet::hasCharsetRule):
+* inspector/InspectorStyleSheet.cpp:
+(WebCore::InspectorStyleSheet::reparseStyleSheet):
+
 2012-03-27  Stephen White  
 
 [chromium] Fix filter context creation to be more conservative.


Modified: trunk/Source/WebCore/css/CSSGrammar.y (112280 => 112281)

--- trunk/Source/WebCore/css/CSSGrammar.y	2012-03-27 17:44:28 UTC (rev 112280)
+++ trunk/Source/WebCore/css/CSSGrammar.y	2012-03-27 17:46:59 UTC (rev 112281)
@@ -375,9 +375,9 @@
 charset:
   CHARSET_SYM maybe_space STRING maybe_space ';' {
  CSSParser* p = static_cast(parser);
- $$ = static_cast(parser)->createCharsetRule($3);
- if ($$ && p->m_styleSheet)
- p->m_styleSheet->append($$);
+ if (p->m_styleSheet)
+ p->m_styleSheet->parserSetEncodingFromCharsetRule($3);
+ $$ = 0;
   }
   | CHARSET_SYM error invalid_block {
   }
@@ -397,7 +397,7 @@
  | rule_list rule maybe_sgml {
  CSSParser* p = static_cast(parser);
  if ($2 && p->m_styleSheet)
- p->m_styleSheet->append($2);
+ p->m_styleSheet->parserAppendRule($2);
  }
  ;
 


Modified: trunk/Source/WebCore/css/CSSParser.cpp (112280 => 112281)

--- trunk/Source/WebCore/css/CSSParser.cpp	20

[webkit-changes] [112280] trunk/LayoutTests

[kling]

Title: [112280] trunk/LayoutTests








Revision 112280
Author kl...@webkit.org
Date 2012-03-27 10:44:28 -0700 (Tue, 27 Mar 2012)


Log Message
Unreviewed, skip fast/events/dropzone-005.html on mac-wk1.

It has been failing since its introduction and is skipped for every
port but chromium.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (112279 => 112280)

--- trunk/LayoutTests/ChangeLog	2012-03-27 17:38:49 UTC (rev 112279)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 17:44:28 UTC (rev 112280)
@@ -1,3 +1,12 @@
+2012-03-27  Andreas Kling  
+
+Unreviewed, skip fast/events/dropzone-005.html on mac-wk1.
+
+It has been failing since its introduction and is skipped for every
+port but chromium.
+
+* platform/mac/Skipped:
+
 2012-03-27  Pavel Podivilov  
 
 Web Inspector: testSourceMapCouldNotBeLoaded logs different error messages on different platforms.


Modified: trunk/LayoutTests/platform/mac/Skipped (112279 => 112280)

--- trunk/LayoutTests/platform/mac/Skipped	2012-03-27 17:38:49 UTC (rev 112279)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-03-27 17:44:28 UTC (rev 112280)
@@ -620,3 +620,6 @@
 
 # The inner  should now grow to take the full cell's height.
 fast/table/colspanMinWidth-vertical.html
+
+# Has failed since its introduction in r105826. Skipped everywhere but chromium.
+fast/events/dropzone-005.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112279] releases/WebKitGTK/webkit-1.8

[mrobinson]

Title: [112279] releases/WebKitGTK/webkit-1.8








Revision 112279
Author mrobin...@webkit.org
Date 2012-03-27 10:38:49 -0700 (Tue, 27 Mar 2012)


Log Message
Update the NEWS and version for the impending 1.8.0 release.

Reviewed by Gustavo Noronha Silva.

.: 

* configure.ac: Update the version.

Source/WebKit/gtk: 

* NEWS: Update the news.

Modified Paths

releases/WebKitGTK/webkit-1.8/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-1.8/configure.ac




Diff

Modified: releases/WebKitGTK/webkit-1.8/ChangeLog (112278 => 112279)

--- releases/WebKitGTK/webkit-1.8/ChangeLog	2012-03-27 17:02:51 UTC (rev 112278)
+++ releases/WebKitGTK/webkit-1.8/ChangeLog	2012-03-27 17:38:49 UTC (rev 112279)
@@ -1,3 +1,11 @@
+2012-03-27  Martin Robinson  
+
+Update the NEWS and version for the impending 1.8.0 release.
+
+Reviewed by Gustavo Noronha Silva.
+
+* configure.ac: Update the version.
+
 2012-03-19  Martin Robinson  
 
 Update the NEWS and version for the WebKitGTK+ 1.7.92 release.


Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog (112278 => 112279)

--- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog	2012-03-27 17:02:51 UTC (rev 112278)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog	2012-03-27 17:38:49 UTC (rev 112279)
@@ -1,3 +1,11 @@
+2012-03-27  Martin Robinson  
+
+Update the NEWS and version for the impending 1.8.0 release.
+
+Reviewed by Gustavo Noronha Silva.
+
+* NEWS: Update the news.
+
 2012-03-26  Gary Kramlich  
 
 WebKitWebView signals with GError parameters cause crashes when using GObject Introspection


Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/NEWS (112278 => 112279)

--- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/NEWS	2012-03-27 17:02:51 UTC (rev 112278)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/NEWS	2012-03-27 17:38:49 UTC (rev 112279)
@@ -1,4 +1,15 @@
 =
+WebKitGTK+ 1.8.0
+=
+
+What's new in WebKitGTK+ 1.8.0?
+
+ - Merge WebCore and _javascript_Core regressions committed after the branch point.
+ - Fix several crashes in script bindings by adjusting incorrect signal signatures.
+ - Fix --disable-geolocation build.
+ - Update translations.
+
+=
 WebKitGTK+ 1.7.92
 =
 


Modified: releases/WebKitGTK/webkit-1.8/configure.ac (112278 => 112279)

--- releases/WebKitGTK/webkit-1.8/configure.ac	2012-03-27 17:02:51 UTC (rev 112278)
+++ releases/WebKitGTK/webkit-1.8/configure.ac	2012-03-27 17:38:49 UTC (rev 112279)
@@ -1,8 +1,8 @@
 AC_PREREQ(2.59)
 
 m4_define([webkit_major_version], [1])
-m4_define([webkit_minor_version], [7])
-m4_define([webkit_micro_version], [92])
+m4_define([webkit_minor_version], [8])
+m4_define([webkit_micro_version], [0])
 
 # This is the version we'll be using as part of our User-Agent string
 # e.g., AppleWebKit/$(webkit_user_agent_version) ...
@@ -35,7 +35,7 @@
 
 dnl # Libtool library version, not to confuse with API version
 dnl # see http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
-LIBWEBKITGTK_VERSION=13:0:13
+LIBWEBKITGTK_VERSION=13:1:13
 AC_SUBST([LIBWEBKITGTK_VERSION])
 
 AM_INIT_AUTOMAKE([foreign subdir-objects dist-xz no-dist-gzip tar-ustar])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112278] trunk/Source

[senorblanco]

Title: [112278] trunk/Source








Revision 112278
Author senorbla...@chromium.org
Date 2012-03-27 10:02:51 -0700 (Tue, 27 Mar 2012)


Log Message
Source/WebCore: [chromium] Fix filter context creation to be more conservative.
https://bugs.webkit.org/show_bug.cgi?id=82349

Reviewed by James Robinson.

Covered by webkit_unit_tests, and css3/filters layout tests.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setFilters):
Only request a filter context if the filter lists is non-empty.
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setNeedsFilterContext):
Add a bool param, so tests can cancel a request for filter contexts.

Source/WebKit/chromium: [chromium] Fix filter context usage in webkit_unit_tests.
https://bugs.webkit.org/show_bug.cgi?id=82349

Reviewed by James Robinson.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
Cancel request for filter context after test run.
(WTF::TEST_F):
* tests/CCOcclusionTrackerTest.cpp:
Re-enable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
(WebCore::CCOcclusionTrackerTest::TearDown):
Cancel request for filter context after test run.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
trunk/Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112277 => 112278)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 15:58:03 UTC (rev 112277)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 17:02:51 UTC (rev 112278)
@@ -1,3 +1,19 @@
+2012-03-27  Stephen White  
+
+[chromium] Fix filter context creation to be more conservative.
+https://bugs.webkit.org/show_bug.cgi?id=82349
+
+Reviewed by James Robinson.
+
+Covered by webkit_unit_tests, and css3/filters layout tests.
+
+* platform/graphics/chromium/LayerChromium.cpp:
+(WebCore::LayerChromium::setFilters):
+Only request a filter context if the filter lists is non-empty.
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+(WebCore::CCLayerTreeHost::setNeedsFilterContext):
+Add a bool param, so tests can cancel a request for filter contexts.
+
 2012-03-27  Stephen Chenney  
 
  elements in the parser can create elements not marked as created by the parser


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp (112277 => 112278)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp	2012-03-27 15:58:03 UTC (rev 112277)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp	2012-03-27 17:02:51 UTC (rev 112278)
@@ -318,7 +318,8 @@
 return;
 m_filters = filters;
 setNeedsCommit();
-CCLayerTreeHost::setNeedsFilterContext();
+if (!filters.isEmpty())
+CCLayerTreeHost::setNeedsFilterContext(true);
 }
 
 void LayerChromium::setOpacity(float opacity)


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h (112277 => 112278)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h	2012-03-27 15:58:03 UTC (rev 112277)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h	2012-03-27 17:02:51 UTC (rev 112278)
@@ -131,7 +131,7 @@
 static bool anyLayerTreeHostInstanceExists();
 
 static bool needsFilterContext() { return s_needsFilterContext; }
-static void setNeedsFilterContext() { s_needsFilterContext = true; }
+static void setNeedsFilterContext(bool needsFilterContext) { s_needsFilterContext = needsFilterContext; }
 
 // CCLayerTreeHost interface to CCProxy.
 void willBeginFrame() { m_client->willBeginFrame(); }


Modified: trunk/Source/WebKit/chromium/ChangeLog (112277 => 112278)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-27 15:58:03 UTC (rev 112277)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-27 17:02:51 UTC (rev 112278)
@@ -1,3 +1,19 @@
+2012-03-27  Stephen White  
+
+[chromium] Fix filter context usage in webkit_unit_tests.
+https://bugs.webkit.org/show_bug.cgi?id=82349
+
+Reviewed by James Robinson.
+
+* tests/CCLayerTreeHostTest.cpp:
+(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
+Cancel request for filter context after test run.
+(WTF::TEST_F):
+* tests/CCOcclusionTrackerTest.cpp:
+Re-enable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
+(WebCore::CCOcclusionTrackerTest::TearDown):
+Cancel request for filter context after test run.
+
 2012-03-26  Stephen White  
 
 Disable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (112277 => 112278)

--- trunk/Source/WebKit/chromium/tests/

[webkit-changes] [112277] trunk/Source/WebCore

[schenney]

Title: [112277] trunk/Source/WebCore








Revision 112277
Author schen...@chromium.org
Date 2012-03-27 08:58:03 -0700 (Tue, 27 Mar 2012)


Log Message
 elements in the parser can create elements not marked as created by the parser
https://bugs.webkit.org/show_bug.cgi?id=81985

Reviewed by Adam Barth.

The SVGUseElement was creating its shadow tree immediately upon
demand. This resulted in nodes being created that were not marked as
"createdByParser", even during parsing. As it happens, there is
already code in there to track "createdByParser" in the SVGUseElement,
it was just being ignored all the time. This may even have been
inefficient. Now we delay creating the shadow dom tree until children
are finished, which is the standard time to handle the createdByParser
flag.

I also verified that other SVG classes that derived from core DOM
classes that use the createdByParser flag do correctly pass this flag
on.

No new tests as this is covered by existing tests and does not have new behavior.

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):
* xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp
trunk/Source/WebCore/xml/XMLErrors.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112276 => 112277)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 15:56:39 UTC (rev 112276)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 15:58:03 UTC (rev 112277)
@@ -1,3 +1,33 @@
+2012-03-27  Stephen Chenney  
+
+ elements in the parser can create elements not marked as created by the parser
+https://bugs.webkit.org/show_bug.cgi?id=81985
+
+Reviewed by Adam Barth.
+
+The SVGUseElement was creating its shadow tree immediately upon
+demand. This resulted in nodes being created that were not marked as
+"createdByParser", even during parsing. As it happens, there is
+already code in there to track "createdByParser" in the SVGUseElement,
+it was just being ignored all the time. This may even have been
+inefficient. Now we delay creating the shadow dom tree until children
+are finished, which is the standard time to handle the createdByParser
+flag.
+
+I also verified that other SVG classes that derived from core DOM
+classes that use the createdByParser flag do correctly pass this flag
+on.
+
+No new tests as this is covered by existing tests and does not have new behavior.
+
+* svg/SVGUseElement.cpp:
+(WebCore::SVGUseElement::insertedIntoDocument):
+(WebCore::SVGUseElement::svgAttributeChanged):
+(WebCore::SVGUseElement::willRecalcStyle):
+(WebCore::SVGUseElement::finishParsingChildren):
+* xml/XMLErrors.cpp:
+(WebCore::XMLErrors::insertErrorMessageBlock):
+
 2012-03-27  Ming Xie  
 
 [BlackBerry] Disable DisallowCType.h usage


Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (112276 => 112277)

--- trunk/Source/WebCore/svg/SVGUseElement.cpp	2012-03-27 15:56:39 UTC (rev 112276)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp	2012-03-27 15:58:03 UTC (rev 112277)
@@ -181,7 +181,8 @@
 SVGStyledTransformableElement::insertedIntoDocument();
 ASSERT(!m_targetElementInstance || !isWellFormedDocument(document()));
 ASSERT(!hasPendingResources() || !isWellFormedDocument(document()));
-buildPendingResource();
+if (!m_wasInsertedByParser)
+buildPendingResource();
 SVGExternalResourcesRequired::insertedIntoDocument(this);
 }
 
@@ -252,7 +253,8 @@
 m_cachedDocument->removeClient(this);
 m_cachedDocument = 0;
 }
-buildPendingResource();
+if (!m_wasInsertedByParser)
+buildPendingResource();
 return;
 }
 
@@ -270,7 +272,7 @@
 
 bool SVGUseElement::willRecalcStyle(StyleChange)
 {
-if (m_needsShadowTreeRecreation && renderer() && needsStyleRecalc())
+if (!m_wasInsertedByParser && m_needsShadowTreeRecreation && renderer() && needsStyleRecalc())
 buildPendingResource();
 return true;
 }
@@ -953,6 +955,10 @@
 {
 SVGStyledTransformableElement::finishParsingChildren();
 SVGExternalResourcesRequired::finishParsingChildren();
+if (m_wasInsertedByParser) {
+buildPendingResource();
+m_wasInsertedByParser = false;
+}
 }
 
 }


Modified: trunk/Source/WebCore/xml/XMLErrors.cpp (112276 => 112277)

--- trunk/Source/WebCore/xml/XMLErrors.cpp	2012-03-27 15:56:39 UTC (rev 112276)
+++ trunk/Source/WebCore/xml/XMLErrors.cpp	2012-03-27 15:58:03 UTC (rev 112277)
@@ -144,11 +144,10 @@
 body->parserAddChild(documentElement);
 m_document->parserAddChild(rootElement.get());
 
-if (m_document->attached()) {
-// rootElement shouldn't be 

[webkit-changes] [112276] branches/subpixellayout/Source/WebCore

[leviw]

Title: [112276] branches/subpixellayout/Source/WebCore








Revision 112276
Author le...@chromium.org
Date 2012-03-27 08:56:39 -0700 (Tue, 27 Mar 2012)


Log Message
Shrinking our patch by moving PaintRect::infiniteRect to LayoutRect::infiniteRect, and cleaning up SubframeLoader.

Modified Paths

branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp
branches/subpixellayout/Source/WebCore/rendering/PaintInfo.h
branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderLayerBacking.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderLayerCompositor.cpp
branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGText.cpp
branches/subpixellayout/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp (112275 => 112276)

--- branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp	2012-03-27 15:44:16 UTC (rev 112275)
+++ branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp	2012-03-27 15:56:39 UTC (rev 112276)
@@ -171,7 +171,7 @@
 IntSize size;
 
 if (renderer)
-size = roundedIntSize(renderer->contentBoxRect());
+size = roundedIntSize(LayoutSize(renderer->contentWidth(), renderer->contentHeight()));
 else if (mediaElement->isVideo())
 size = RenderVideo::defaultSize();
 
@@ -360,7 +360,7 @@
 if (!frameLoader->checkIfRunInsecureContent(document()->securityOrigin(), url))
 return false;
 
-IntSize contentSize = roundedIntSize(renderer->contentBoxRect().size());
+IntSize contentSize = roundedIntSize(LayoutSize(renderer->contentWidth(), renderer->contentHeight()));
 bool loadManually = document()->isPluginDocument() && !m_containsPlugins && toPluginDocument(document())->shouldLoadPluginManually();
 RefPtr widget = frameLoader->client()->createPlugin(contentSize,
 pluginElement, url, paramNames, paramValues, mimeType, loadManually);


Modified: branches/subpixellayout/Source/WebCore/rendering/PaintInfo.h (112275 => 112276)

--- branches/subpixellayout/Source/WebCore/rendering/PaintInfo.h	2012-03-27 15:44:16 UTC (rev 112275)
+++ branches/subpixellayout/Source/WebCore/rendering/PaintInfo.h	2012-03-27 15:56:39 UTC (rev 112276)
@@ -98,7 +98,7 @@
 }
 #endif
 
-static IntRect infiniteRect() { return IntRect(std::numeric_limits::min() / 2, std::numeric_limits::min() / 2, std::numeric_limits::max(), std::numeric_limits::max()); }
+static IntRect infiniteRect() { return IntRect(LayoutRect::infiniteRect()); }
 
 // FIXME: Introduce setters/getters at some point. Requires a lot of changes throughout rendering/.
 GraphicsContext* context;


Modified: branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp (112275 => 112276)

--- branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp	2012-03-27 15:44:16 UTC (rev 112275)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp	2012-03-27 15:56:39 UTC (rev 112276)
@@ -3634,7 +3634,7 @@
 {
 if (!parent()) {
 // The root layer's clip rect is always infinite.
-clipRects.reset(LayoutRect::infiniteRect());
+clipRects.reset(PaintInfo::infiniteRect());
 return;
 }
 
@@ -3649,7 +3649,7 @@
 else
 parentLayer->calculateClipRects(rootLayer, region, clipRects);
 } else
-clipRects.reset(LayoutRect::infiniteRect());
+clipRects.reset(PaintInfo::infiniteRect());
 
 // A fixed object is essentially the root of its containing block hierarchy, so when
 // we encounter such an object, we reset our clip rects to the fixedClipRect.


Modified: branches/subpixellayout/Source/WebCore/rendering/RenderLayerBacking.cpp (112275 => 112276)

--- branches/subpixellayout/Source/WebCore/rendering/RenderLayerBacking.cpp	2012-03-27 15:44:16 UTC (rev 112275)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderLayerBacking.cpp	2012-03-27 15:56:39 UTC (rev 112276)
@@ -366,7 +366,7 @@
 
 static IntRect clipBox(RenderBox* renderer)
 {
-LayoutRect result = LayoutRect::infiniteRect();
+LayoutRect result = PaintInfo::infiniteRect();
 if (renderer->hasOverflowClip())
 result = renderer->overflowClipRect(LayoutPoint(), 0); // FIXME: Incorrect for CSS regions.
 
@@ -438,7 +438,7 @@
 // layer. Note that we call it with temporaryClipRects = true because normally when computing clip rects
 // for a compositing layer, rootLayer is the layer itself.
 IntRect parentClipRect = pixelSnappedIntRect(m_owningLayer->backgroundClipRect(compAncestor, 0, true).rect()); // FIXME: Incorrect for CSS regions.
-ASSERT(parentClipRect != LayoutRect::infiniteRect());
+ASSERT(parentClipRect != PaintInfo::infiniteRect());
 m_ancestorClippingLayer->setPosition(FloatPoint() + (parentClipRect.location() - graphicsLayerParentLocation));
 m_ancestorClippingLayer->setSize(parentClipRect

[webkit-changes] [112275] trunk/Source/WebCore

[commit-queue]

Title: [112275] trunk/Source/WebCore








Revision 112275
Author commit-qu...@webkit.org
Date 2012-03-27 08:44:16 -0700 (Tue, 27 Mar 2012)


Log Message
[BlackBerry] Disable DisallowCType.h usage
https://bugs.webkit.org/show_bug.cgi?id=82211

Patch by Ming Xie  on 2012-03-27
Reviewed by Rob Buis.

Build fix: QNX port does use ctype.h, so we should not
include  in WebCore/config.h

No new tests - Build Fix

* config.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/config.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112274 => 112275)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 15:41:04 UTC (rev 112274)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 15:44:16 UTC (rev 112275)
@@ -1,3 +1,17 @@
+2012-03-27  Ming Xie  
+
+[BlackBerry] Disable DisallowCType.h usage
+https://bugs.webkit.org/show_bug.cgi?id=82211
+
+Reviewed by Rob Buis.
+
+Build fix: QNX port does use ctype.h, so we should not
+include  in WebCore/config.h
+
+No new tests - Build Fix
+
+* config.h:
+
 2012-03-27  Hao Zheng  
 
 Change default position attribute of media control panel to relative for Android.


Modified: trunk/Source/WebCore/config.h (112274 => 112275)

--- trunk/Source/WebCore/config.h	2012-03-27 15:41:04 UTC (rev 112274)
+++ trunk/Source/WebCore/config.h	2012-03-27 15:44:16 UTC (rev 112275)
@@ -92,7 +92,7 @@
 // are used from wx headers. On GTK+ for Mac many GTK+ files include 
 // or , which in turn include  which uses
 // isacii(). 
-#if !PLATFORM(QT) && !PLATFORM(WX) && !PLATFORM(CHROMIUM) && !(OS(DARWIN) && PLATFORM(GTK)) && !defined(_LIBCPP_VERSION)
+#if !PLATFORM(QT) && !PLATFORM(WX) && !PLATFORM(CHROMIUM) && !(OS(DARWIN) && PLATFORM(GTK)) && !OS(QNX) && !defined(_LIBCPP_VERSION)
 #include 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112274] trunk/LayoutTests

[podivilov]

Title: [112274] trunk/LayoutTests








Revision 112274
Author podivi...@chromium.org
Date 2012-03-27 08:41:04 -0700 (Tue, 27 Mar 2012)


Log Message
Web Inspector: testSourceMapCouldNotBeLoaded logs different error messages on different platforms.
https://bugs.webkit.org/show_bug.cgi?id=82314

Reviewed by Vsevolod Vlasov.

* http/tests/inspector/compiler-script-mapping.html:
* platform/gtk/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html
trunk/LayoutTests/platform/gtk/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (112273 => 112274)

--- trunk/LayoutTests/ChangeLog	2012-03-27 15:22:56 UTC (rev 112273)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 15:41:04 UTC (rev 112274)
@@ -1,3 +1,13 @@
+2012-03-27  Pavel Podivilov  
+
+Web Inspector: testSourceMapCouldNotBeLoaded logs different error messages on different platforms.
+https://bugs.webkit.org/show_bug.cgi?id=82314
+
+Reviewed by Vsevolod Vlasov.
+
+* http/tests/inspector/compiler-script-mapping.html:
+* platform/gtk/Skipped:
+
 2012-03-27  Yury Semikhatsky  
 
 Web Inspector: simplify heap profiler front-end


Modified: trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html (112273 => 112274)

--- trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html	2012-03-27 15:22:56 UTC (rev 112273)
+++ trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html	2012-03-27 15:41:04 UTC (rev 112274)
@@ -190,12 +190,14 @@
 
 function testSourceMapCouldNotBeLoaded(next)
 {
+WebInspector.settings.sourceMapsEnabled.set(true);
 WebInspector.debuggerModel._scripts = [];
 var mainScriptMapping = new WebInspector.MainScriptMapping();
 mainScriptMapping.addEventListener(WebInspector.MainScriptMapping.Events.UISourceCodeListChanged, uiSourceCodeListChanged);
 
 var script = InspectorTest.createScriptMock("compiled.js", 0, 0, true, "");
 script.sourceMapURL = "http://localhost:8000/inspector/resources/source-map.json_";
+console.error = function() {}; // Error message is platform dependent.
 mainScriptMapping.addScript(script);
 
 function uiSourceCodeListChanged(event)


Modified: trunk/LayoutTests/platform/gtk/Skipped (112273 => 112274)

--- trunk/LayoutTests/platform/gtk/Skipped	2012-03-27 15:22:56 UTC (rev 112273)
+++ trunk/LayoutTests/platform/gtk/Skipped	2012-03-27 15:41:04 UTC (rev 112274)
@@ -1633,7 +1633,3 @@
 # https://bugs.webkit.org/show_bug.cgi?id=82309
 http/tests/xmlhttprequest/basic-auth-default.html
 http/tests/xmlhttprequest/re-login-async.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=82314
-http/tests/inspector/compiler-script-mapping.html
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112273] trunk/Source/WebKit2

[carlosgc]

Title: [112273] trunk/Source/WebKit2








Revision 112273
Author carlo...@webkit.org
Date 2012-03-27 08:22:56 -0700 (Tue, 27 Mar 2012)


Log Message
Implement WebFrameNetworkingContext for soup in WebKit2

[SOUP] Implement WebFrameNetworkingContext for soup in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=82081

Reviewed by Martin Robinson.

* GNUmakefile.am: Add new files to compilation
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h.
(WebKit::WebFrameNetworkingContext::soupSession): Return the
default SoupSession.
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h.
(WebKit):
(WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::create): Create a new
WebFrameNetworkingContext().
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am


Added Paths

trunk/Source/WebKit2/WebProcess/WebCoreSupport/soup/
trunk/Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h


Removed Paths

trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (112272 => 112273)

--- trunk/Source/WebKit2/ChangeLog	2012-03-27 15:17:42 UTC (rev 112272)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-27 15:22:56 UTC (rev 112273)
@@ -1,3 +1,23 @@
+2012-03-27  Carlos Garcia Campos  
+
+Implement WebFrameNetworkingContext for soup in WebKit2
+
+[SOUP] Implement WebFrameNetworkingContext for soup in WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=82081
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am: Add new files to compilation
+* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h.
+(WebKit::WebFrameNetworkingContext::soupSession): Return the
+default SoupSession.
+* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h.
+(WebKit):
+(WebFrameNetworkingContext):
+(WebKit::WebFrameNetworkingContext::create): Create a new
+WebFrameNetworkingContext().
+(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
+
 2012-03-27  Yael Aharon  
 
 [Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect


Modified: trunk/Source/WebKit2/GNUmakefile.am (112272 => 112273)

--- trunk/Source/WebKit2/GNUmakefile.am	2012-03-27 15:17:42 UTC (rev 112272)
+++ trunk/Source/WebKit2/GNUmakefile.am	2012-03-27 15:22:56 UTC (rev 112273)
@@ -909,8 +909,9 @@
 	Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp \
 	Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp \
 	Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp \
-	Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h \
 	Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp \
+	Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp \
+	Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h \
 	Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp \
 	Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h \
 	Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp \
@@ -1045,6 +1046,7 @@
 	-I$(srcdir)/Source/WebKit2/WebProcess/Plugins/Netscape/gtk \
 	-I$(srcdir)/Source/WebKit2/WebProcess/WebCoreSupport \
 	-I$(srcdir)/Source/WebKit2/WebProcess/WebCoreSupport/gtk \
+	-I$(srcdir)/Source/WebKit2/WebProcess/WebCoreSupport/soup \
 	-I$(srcdir)/Source/WebKit2/WebProcess/WebPage \
 	-I$(srcdir)/Source/WebKit2/WebProcess/WebPage/gtk \
 	-I$(top_builddir)/DerivedSources/WebKit2 \


Deleted: trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h (112272 => 112273)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h	2012-03-27 15:17:42 UTC (rev 112272)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h	2012-03-27 15:22:56 UTC (rev 112273)
@@ -1,53 +0,0 @@
-/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
- * Portions Copyright (c) 2010 Motorola Mobility, Inc.  All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following

[webkit-changes] [112272] trunk/Source/WebCore

[commit-queue]

Title: [112272] trunk/Source/WebCore








Revision 112272
Author commit-qu...@webkit.org
Date 2012-03-27 08:17:42 -0700 (Tue, 27 Mar 2012)


Log Message
Change default position attribute of media control panel to relative for Android.
https://bugs.webkit.org/show_bug.cgi?id=82303

Patch by Hao Zheng  on 2012-03-27
Reviewed by Eric Carlson.

Follow up https://bugs.webkit.org/show_bug.cgi?id=79746 .

* css/mediaControlsChromiumAndroid.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mediaControlsChromiumAndroid.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (112271 => 112272)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 15:15:18 UTC (rev 112271)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 15:17:42 UTC (rev 112272)
@@ -1,3 +1,15 @@
+2012-03-27  Hao Zheng  
+
+Change default position attribute of media control panel to relative for Android.
+https://bugs.webkit.org/show_bug.cgi?id=82303
+
+Reviewed by Eric Carlson.
+
+Follow up https://bugs.webkit.org/show_bug.cgi?id=79746 .
+
+* css/mediaControlsChromiumAndroid.css:
+(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
+
 2012-03-27  Alexei Filippov  
 
 Web Inspector: Speed up snapshot parsing.


Modified: trunk/Source/WebCore/css/mediaControlsChromiumAndroid.css (112271 => 112272)

--- trunk/Source/WebCore/css/mediaControlsChromiumAndroid.css	2012-03-27 15:15:18 UTC (rev 112271)
+++ trunk/Source/WebCore/css/mediaControlsChromiumAndroid.css	2012-03-27 15:17:42 UTC (rev 112272)
@@ -40,7 +40,7 @@
 
 audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel {
 -webkit-user-select: none;
-position: absolute;
+position: relative;
 overflow: visible;
 bottom: 0;
 width: 100%;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112271] trunk/Source/WebCore

[yurys]

Title: [112271] trunk/Source/WebCore








Revision 112271
Author yu...@chromium.org
Date 2012-03-27 08:15:18 -0700 (Tue, 27 Mar 2012)


Log Message
Web Inspector: Speed up snapshot parsing.
https://bugs.webkit.org/show_bug.cgi?id=82325

Replacing the iterators with raw nodes/edges access speeds up
some phases phasses up to 10 times, taking down the whole init
time to less than 6 sec.

Patch by Alexei Filippov  on 2012-03-27
Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (112270 => 112271)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 15:03:44 UTC (rev 112270)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 15:15:18 UTC (rev 112271)
@@ -1,3 +1,19 @@
+2012-03-27  Alexei Filippov  
+
+Web Inspector: Speed up snapshot parsing.
+https://bugs.webkit.org/show_bug.cgi?id=82325
+
+Replacing the iterators with raw nodes/edges access speeds up
+some phases phasses up to 10 times, taking down the whole init
+time to less than 6 sec.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/HeapSnapshot.js:
+(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
+(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
+(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
+
 2012-03-27  Antti Koivisto  
 
 Assertion failure in acid2.


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (112270 => 112271)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-03-27 15:03:44 UTC (rev 112270)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-03-27 15:15:18 UTC (rev 112271)
@@ -1029,41 +1029,6 @@
 return aggregates;
 },
 
-_buildReverseIndex: function(indexArrayName, backRefsArrayName, indexCallback, dataCallback)
-{
-// Builds up two arrays:
-//  - "backRefsArray" is a continuous array, where each node owns an
-//interval (can be empty) with corresponding back references.
-//  - "indexArray" is an array of indexes in the "backRefsArray"
-//with the same positions as in the _nodeIndex.
-var indexArray = this[indexArrayName] = new Uint32Array(this._nodeIndex.length);
-var nodeIndexes = this.nodeIndexes;
-var nodeCount = this.nodeCount;
-var node = new WebInspector.HeapSnapshotNode(this, nodeIndexes[0]);
-for (var i = 0; i < nodeCount; ++i) {
-node.nodeIndex = nodeIndexes[i];
-indexCallback(node, function (position) { ++indexArray[position]; });
-}
-var backRefsCount = 0;
-for (i = 0, l = indexArray.length; i < l; ++i)
-backRefsCount += indexArray[i];
-var backRefsArray = this[backRefsArrayName] = new Uint32Array(backRefsCount + 1);
-// Put in the first slot of each backRefsArray slice the count of entries
-// that will be filled.
-var backRefsPosition = 0;
-for (i = 0, l = indexArray.length; i < l; ++i) {
-backRefsCount = backRefsArray[backRefsPosition] = indexArray[i];
-indexArray[i] = backRefsPosition;
-backRefsPosition += backRefsCount;
-}
-for (var i = 0; i < nodeCount; ++i) {
-node.nodeIndex = nodeIndexes[i];
-dataCallback(node,
- function (backRefIndex) { return backRefIndex + (--backRefsArray[backRefIndex]); },
- function (backRefIndex, destIndex) { backRefsArray[backRefIndex] = destIndex; });
-}
-},
-
 _buildRetainers: function()
 {
 var nodeIndexes = this.nodeIndexes;
@@ -1076,7 +1041,7 @@
 //interval (can be empty) with corresponding back references.
 //  - "indexArray" is an array of indexes in the "backRefsArray"
 //with the same positions as in the _nodeIndex.
-var indexArray = this._retainerIndex = new Int32Array(nodeCount + 1);
+var indexArray = this._retainerIndex = new Uint32Array(nodeCount + 1);
 var edgesCountOffset = this._edgesCountOffset;
 var firstEdgeOffset = this._firstEdgeOffset;
 var edgeFieldsCount = this._edgeFieldsCount;
@@ -1093,7 +1058,7 @@
   ++indexArray[nodePositions[targetNodeIndex]];
 }
 }
-var backRefsArray = this._retainers = new Int32Array(backRefsCount);
+var backRefsArray = this._retainers = new Uint32Array(backRefsCount);
 // Put in the first slot of each backRefsArray slice the count of entries
 // that will be filled.
 var backRefsPosition = 0;
@@ -1256,13 +1221,18 @@
 _buildNodeInde

[webkit-changes] [112269] trunk/Source/WebCore

[antti]

Title: [112269] trunk/Source/WebCore








Revision 112269
Author an...@apple.com
Date 2012-03-27 08:01:00 -0700 (Tue, 27 Mar 2012)


Log Message
Assertion failure in acid2.

Rubber-stamped by Andreas Kling.

Remove assert added in http://trac.webkit.org/changeset/112258. It seems insertedInto/removedFromDocument
don't always pair.

* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112268 => 112269)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 14:55:27 UTC (rev 112268)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 15:01:00 UTC (rev 112269)
@@ -1,3 +1,15 @@
+2012-03-27  Antti Koivisto  
+
+Assertion failure in acid2.
+
+Rubber-stamped by Andreas Kling.
+
+Remove assert added in http://trac.webkit.org/changeset/112258. It seems insertedInto/removedFromDocument
+don't always pair.
+
+* svg/SVGDocumentExtensions.cpp:
+(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
+
 2012-03-27  Yury Semikhatsky  
 
 Web Inspector: simplify heap profiler front-end


Modified: trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp (112268 => 112269)

--- trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp	2012-03-27 14:55:27 UTC (rev 112268)
+++ trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp	2012-03-27 15:01:00 UTC (rev 112269)
@@ -50,8 +50,6 @@
 
 SVGDocumentExtensions::~SVGDocumentExtensions()
 {
-ASSERT(m_svgFontFaceElements.isEmpty());
-
 deleteAllValues(m_animatedElements);
 deleteAllValues(m_pendingResources);
 deleteAllValues(m_pendingResourcesForRemoval);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112268] trunk

[yurys]

Title: [112268] trunk








Revision 112268
Author yu...@chromium.org
Date 2012-03-27 07:55:27 -0700 (Tue, 27 Mar 2012)


Log Message
Web Inspector: simplify heap profiler front-end
https://bugs.webkit.org/show_bug.cgi?id=82338

Source/WebCore:

Simplify constructors of WebInspector.HeapSnapshotArraySlice and
WebInspector.HeapSnapshotEdgesProvider.

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotArraySlice):
(WebInspector.HeapSnapshotArraySlice.prototype.item):
(WebInspector.HeapSnapshotArraySlice.prototype.slice):
(WebInspector.HeapSnapshotNode.prototype.get rawEdges):
(WebInspector.HeapSnapshot.prototype._retainersForNode):
(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotEdgesProvider):

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/profiler/heap-snapshot.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/profiler/heap-snapshot.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js




Diff

Modified: trunk/LayoutTests/ChangeLog (112267 => 112268)

--- trunk/LayoutTests/ChangeLog	2012-03-27 14:51:03 UTC (rev 112267)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 14:55:27 UTC (rev 112268)
@@ -1,3 +1,12 @@
+2012-03-27  Yury Semikhatsky  
+
+Web Inspector: simplify heap profiler front-end
+https://bugs.webkit.org/show_bug.cgi?id=82338
+
+Reviewed by Pavel Feldman.
+
+* inspector/profiler/heap-snapshot.html:
+
 2012-03-27  Pavel Podivilov  
 
 Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.


Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot.html (112267 => 112268)

--- trunk/LayoutTests/inspector/profiler/heap-snapshot.html	2012-03-27 14:51:03 UTC (rev 112267)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot.html	2012-03-27 14:55:27 UTC (rev 112268)
@@ -216,7 +216,7 @@
 return edge.name === "b";
 }
  
-var provider = new WebInspector.HeapSnapshotEdgesProvider(snapshot, snapshot.rootNodeIndex, edgeFilter);
+var provider = snapshot.createEdgesProvider(snapshot.rootNodeIndex, edgeFilter);
 InspectorTest.assertEquals(1, provider.length, "edges provider length");
 provider.sort(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.createComparator(["!edgeName", false, "id", false]), 0, 0, 1);
 InspectorTest.assertEquals(1, provider.length, "edges provider length");


Modified: trunk/Source/WebCore/ChangeLog (112267 => 112268)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 14:51:03 UTC (rev 112267)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 14:55:27 UTC (rev 112268)
@@ -1,3 +1,23 @@
+2012-03-27  Yury Semikhatsky  
+
+Web Inspector: simplify heap profiler front-end
+https://bugs.webkit.org/show_bug.cgi?id=82338
+
+Simplify constructors of WebInspector.HeapSnapshotArraySlice and
+WebInspector.HeapSnapshotEdgesProvider.
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/HeapSnapshot.js:
+(WebInspector.HeapSnapshotArraySlice):
+(WebInspector.HeapSnapshotArraySlice.prototype.item):
+(WebInspector.HeapSnapshotArraySlice.prototype.slice):
+(WebInspector.HeapSnapshotNode.prototype.get rawEdges):
+(WebInspector.HeapSnapshot.prototype._retainersForNode):
+(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
+(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
+(WebInspector.HeapSnapshotEdgesProvider):
+
 2012-03-27  Vsevolod Vlasov  
 
 Web Inspector: Tabbed pane should set focus on its contents on tab click.


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (112267 => 112268)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-03-27 14:51:03 UTC (rev 112267)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-03-27 14:55:27 UTC (rev 112268)
@@ -211,12 +211,9 @@
 }
 };
 
-WebInspector.HeapSnapshotArraySlice = function(snapshot, arrayName, start, end)
+WebInspector.HeapSnapshotArraySlice = function(array, start, end)
 {
-// Note: we don't reference snapshot contents directly to avoid
-// holding references to big chunks of data.
-this._snapshot = snapshot;
-this._arrayName = arrayName;
+this._array = array;
 this._start = start;
 this.length = end - start;
 }
@@ -224,14 +221,14 @@
 WebInspector.HeapSnapshotArraySlice.prototype = {
 item: function(index)
 {
-return this._snapshot[this._arrayName][this._start + index];
+return this._array[this._start + index];
 },
 
 slice: function(start, end)
 {
 if (typeof end === "undefined")
 end = this.length;
-return this._snapshot[this._arrayName].subarray(this._start + start, this._start + end);
+

[webkit-changes] [112267] trunk/Source/WebCore

[vsevik]

Title: [112267] trunk/Source/WebCore








Revision 112267
Author vse...@chromium.org
Date 2012-03-27 07:51:03 -0700 (Tue, 27 Mar 2012)


Log Message
Web Inspector: Tabbed pane should set focus on its contents on tab click.
https://bugs.webkit.org/show_bug.cgi?id=82323

Reviewed by Pavel Feldman.

Otherwise selected tab does not have focus.
Also added tabIndex on tabElements to prevent pasting on closing middle click.

* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.focus):
(WebInspector.TabbedPane.prototype.selectTab):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TabbedPane.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (112266 => 112267)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 14:43:46 UTC (rev 112266)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 14:51:03 UTC (rev 112267)
@@ -1,3 +1,20 @@
+2012-03-27  Vsevolod Vlasov  
+
+Web Inspector: Tabbed pane should set focus on its contents on tab click.
+https://bugs.webkit.org/show_bug.cgi?id=82323
+
+Reviewed by Pavel Feldman.
+
+Otherwise selected tab does not have focus.
+Also added tabIndex on tabElements to prevent pasting on closing middle click.
+
+* inspector/front-end/TabbedPane.js:
+(WebInspector.TabbedPane):
+(WebInspector.TabbedPane.prototype.focus):
+(WebInspector.TabbedPane.prototype.selectTab):
+(WebInspector.TabbedPaneTab.prototype._createTabElement):
+(WebInspector.TabbedPaneTab.prototype._tabClicked):
+
 2012-03-27  Pavel Podivilov  
 
 Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.


Modified: trunk/Source/WebCore/inspector/front-end/TabbedPane.js (112266 => 112267)

--- trunk/Source/WebCore/inspector/front-end/TabbedPane.js	2012-03-27 14:43:46 UTC (rev 112266)
+++ trunk/Source/WebCore/inspector/front-end/TabbedPane.js	2012-03-27 14:51:03 UTC (rev 112267)
@@ -86,6 +86,16 @@
 this._closeableTabs = closeableTabs;
 },
 
+focus: function()
+{
+if (!this.visibleView)
+return;
+if (typeof(this.visibleView.focus) === "function")
+this.visibleView.focus();
+else
+this.visibleView.element.focus();
+},
+
 /**
  * @param {string} id
  * @param {string} tabTitle
@@ -172,7 +182,7 @@
 this._tabsHistory.splice(0, 0, tab);
 
 this._updateTabElements();
-
+
 var eventData = { tabId: id, view: tab.view, isUserGesture: userGesture };
 this.dispatchEventToListeners(WebInspector.TabbedPane.EventTypes.TabSelected, eventData);
 return true;
@@ -588,6 +598,7 @@
 {
 var tabElement = document.createElement("div");
 tabElement.addStyleClass("tabbed-pane-header-tab");
+tabElement.tabIndex = -1;
 
 var titleElement = tabElement.createChild("span", "tabbed-pane-header-tab-title");
 titleElement.textContent = this.title;
@@ -627,5 +638,6 @@
 this._tabbedPane.closeTab(this.id, true);
 else
 this._tabbedPane.selectTab(this.id, true);
+this._tabbedPane.focus();
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112266] trunk

[podivilov]

Title: [112266] trunk








Revision 112266
Author podivi...@chromium.org
Date 2012-03-27 07:43:46 -0700 (Tue, 27 Mar 2012)


Log Message
Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82318

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Breakpoint-added and breakpoint-removed events are always related to specific UISourceCode.
See bug 82224 for more details.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.UISourceCodeImpl.prototype.breakpointAdded):
(WebInspector.UISourceCodeImpl.prototype.breakpointRemoved):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._addBreakpointListeners):
(WebInspector.ScriptsPanel.prototype._removeBreakpointListeners):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
* inspector/front-end/UISourceCode.js:

LayoutTests:

* inspector/debugger/breakpoint-manager.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/breakpoint-manager.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js




Diff

Modified: trunk/LayoutTests/ChangeLog (112265 => 112266)

--- trunk/LayoutTests/ChangeLog	2012-03-27 14:42:47 UTC (rev 112265)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 14:43:46 UTC (rev 112266)
@@ -1,3 +1,12 @@
+2012-03-27  Pavel Podivilov  
+
+Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.
+https://bugs.webkit.org/show_bug.cgi?id=82318
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/debugger/breakpoint-manager.html:
+
 2012-03-27  Alexei Filippov  
 
 Web Inspector: Fix missing objects in the dominators view.


Modified: trunk/LayoutTests/inspector/debugger/breakpoint-manager.html (112265 => 112266)

--- trunk/LayoutTests/inspector/debugger/breakpoint-manager.html	2012-03-27 14:42:47 UTC (rev 112265)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-manager.html	2012-03-27 14:43:46 UTC (rev 112266)
@@ -13,15 +13,17 @@
 };
 
 var uiBreakpoints = {};
-function breakpointAdded(breakpoint)
+function breakpointAdded(event)
 {
+var breakpoint = event.data;
 InspectorTest.addResult("breakpointAdded(" + [breakpoint.uiSourceCode.id, breakpoint.lineNumber, breakpoint.condition, breakpoint.enabled].join(", ") + ")");
 var breakpointId = breakpoint.uiSourceCode.id + ":" + breakpoint.lineNumber;
 InspectorTest.assertTrue(!(breakpointId in uiBreakpoints));
 uiBreakpoints[breakpointId] = breakpoint.condition + "|" + breakpoint.enabled;
 }
-function breakpointRemoved(breakpoint)
+function breakpointRemoved(event)
 {
+var breakpoint = event.data;
 InspectorTest.addResult("breakpointRemoved(" + [breakpoint.uiSourceCode.id, breakpoint.lineNumber].join(", ") + ")");
 var breakpointId = breakpoint.uiSourceCode.id + ":" + breakpoint.lineNumber;
 InspectorTest.assertTrue(breakpointId in uiBreakpoints);
@@ -59,15 +61,12 @@
 serializedBreakpoints.push(createBreakpoint("b.js", 3, "", true));
 
 function createUISourceCode(id, url) { return new WebInspector.UISourceCodeImpl(id, url, null); }
-var uiSourceCodeA = createUISourceCode("a.js", "a.js");
-var uiSourceCodeB = createUISourceCode("b.js", "b.js");
 
 var scriptMapping = {};
 scriptMapping.rawLocationToUILocation = function(rawLocation) { return rawLocation; };
 scriptMapping.uiLocationToRawLocation = function(uiSourceCode, lineNumber)
 {
-scriptId = uiSourceCode === uiSourceCodeA ? "a.js" : "b.js";
-return { scriptId: scriptId, lineNumber: lineNumber, columnNumber: 0 };
+return { scriptId: uiSourceCode.id, lineNumber: lineNumber, columnNumber: 0 };
 }
 
 function createBreakpointManager(breakpoints, scriptMapping)
@@ -76,15 +75,22 @@
 uiBreakpoints = {};
 debuggerBreakpoints = {};
 debuggerModel.removeAllListeners();
-return new WebInspector.BreakpointManager(breakpointStorage, breakpointAdded, breakpointRemoved, debuggerModel, scriptMapping);
+return new WebInspector.BreakpointManager(breakpointStorage, debuggerModel, scriptMapping);
 }
 
+function addUISourceCode(breakpointManager, uiSourceCode)
+{
+uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.BreakpointAdded, breakpointAdded);
+uiSourceCode.add

[webkit-changes] [112265] trunk/Source/WebKit2

[yael . aharon]

Title: [112265] trunk/Source/WebKit2








Revision 112265
Author yael.aha...@nokia.com
Date 2012-03-27 07:42:47 -0700 (Tue, 27 Mar 2012)


Log Message
[Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=82289

Reviewed by Kenneth Rohde Christiansen.

As we scroll, we constantly send 2 messages. Those 2 messages can be merged into one.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
* UIProcess/WebPageProxy.cpp:
(WebKit):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentsRect):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (112264 => 112265)

--- trunk/Source/WebKit2/ChangeLog	2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-27 14:42:47 UTC (rev 112265)
@@ -1,3 +1,22 @@
+2012-03-27  Yael Aharon  
+
+[Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect
+https://bugs.webkit.org/show_bug.cgi?id=82289
+
+Reviewed by Kenneth Rohde Christiansen.
+
+As we scroll, we constantly send 2 messages. Those 2 messages can be merged into one.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
+* UIProcess/WebPageProxy.cpp:
+(WebKit):
+* UIProcess/WebPageProxy.h:
+(WebPageProxy):
+* WebProcess/WebPage/WebPage.messages.in:
+* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
+(WebKit::LayerTreeHostQt::setVisibleContentsRect):
+
 2012-03-27  Carlos Garcia Campos  
 
 [SOUP] Implement missing methods in CookieJarSoup


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (112264 => 112265)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-03-27 14:42:47 UTC (rev 112265)
@@ -642,7 +642,6 @@
 float scale = pageView->contentsScale();
 
 drawingArea->setVisibleContentsRect(visibleRect, scale, trajectoryVector);
-webPageProxy->setFixedVisibleContentRect(visibleRect);
 }
 
 void QQuickWebViewFlickablePrivate::_q_suspend()


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (112264 => 112265)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2012-03-27 14:42:47 UTC (rev 112265)
@@ -844,14 +844,6 @@
 }
 
 #if USE(TILED_BACKING_STORE)
-void WebPageProxy::setFixedVisibleContentRect(const IntRect& rect)
-{
-if (!isValid())
-return;
-
-process()->send(Messages::WebPage::SetFixedVisibleContentRect(rect), m_pageID);
-}
-
 void WebPageProxy::setViewportSize(const IntSize& size)
 {
 if (!isValid())


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (112264 => 112265)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2012-03-27 14:42:47 UTC (rev 112265)
@@ -378,7 +378,6 @@
 PlatformWidget viewWidget();
 #endif
 #if USE(TILED_BACKING_STORE)
-void setFixedVisibleContentRect(const WebCore::IntRect&);
 void setViewportSize(const WebCore::IntSize&);
 #endif
 


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in (112264 => 112265)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in	2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in	2012-03-27 14:42:47 UTC (rev 112265)
@@ -105,7 +105,6 @@
 ResumeActiveDOMObjectsAndAnimations()
 
 #if USE(TILED_BACKING_STORE)
-SetFixedVisibleContentRect(WebCore::IntRect rect)
 SetViewportSize(WebCore::IntSize size)
 #endif
 


Modified: trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp (112264 => 112265)

--- trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp	2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp	2012-03-27 14:42:47 UTC (rev 112265)
@@ -443,6 +443,8 @@
 }
 
 scheduleLayerFlush();
+if (m_webPage->useFixedLayout())
+m_webPage->setFixedVisibleContentRect(rect);
 }
 
 void LayerTreeHostQt::renderNextFrame()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112264] trunk/Source/WebCore

[commit-queue]

Title: [112264] trunk/Source/WebCore








Revision 112264
Author commit-qu...@webkit.org
Date 2012-03-27 07:32:49 -0700 (Tue, 27 Mar 2012)


Log Message
[BlackBerry]Cleanup WTF string in platform/network/blackberry
https://bugs.webkit.org/show_bug.cgi?id=82005

Patch by Jason Liu  on 2012-03-27
Reviewed by Rob Buis.

No new tests. Just replace WTF::String with String.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyDataReceived):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112263 => 112264)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 14:30:29 UTC (rev 112263)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 14:32:49 UTC (rev 112264)
@@ -1,3 +1,15 @@
+2012-03-27  Jason Liu  
+
+[BlackBerry]Cleanup WTF string in platform/network/blackberry
+https://bugs.webkit.org/show_bug.cgi?id=82005
+
+Reviewed by Rob Buis.
+
+No new tests. Just replace WTF::String with String.
+
+* platform/network/blackberry/NetworkJob.cpp:
+(WebCore::NetworkJob::handleNotifyDataReceived):
+
 2012-03-27  Alexander Pavlov  
 
 Web Inspector: Enable "number" parameters in the web inspector protocol methods


Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (112263 => 112264)

--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-03-27 14:30:29 UTC (rev 112263)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-03-27 14:32:49 UTC (rev 112264)
@@ -394,9 +394,9 @@
 // is on a file system if it has a MIME mappable file extension.
 // The file extension is likely to be correct.
 if (m_isFile) {
-WTF::String urlFilename = m_response.url().lastPathComponent();
+String urlFilename = m_response.url().lastPathComponent();
 size_t pos = urlFilename.reverseFind('.');
-if (pos != WTF::notFound) {
+if (pos != notFound) {
 String extension = urlFilename.substring(pos + 1);
 String mimeType = MIMETypeRegistry::getMIMETypeForExtension(extension);
 if (!mimeType.isEmpty())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112263] trunk/Source/WebCore

[apavlov]

Title: [112263] trunk/Source/WebCore








Revision 112263
Author apav...@chromium.org
Date 2012-03-27 07:30:29 -0700 (Tue, 27 Mar 2012)


Log Message
Web Inspector: Enable "number" parameters in the web inspector protocol methods
https://bugs.webkit.org/show_bug.cgi?id=82334

The generated protocol dispatcher does not understand protocol method parameters of type "number"
(mapped to "double" in the native code.)

Reviewed by Vsevolod Vlasov.

* inspector/CodeGeneratorInspector.py:
(RawTypes.Number.get_getter_name):
(RawTypes.Number.get_c_initializer):
(RawTypes.Number.get_js_bind_type):
(RawTypes.Number.get_validate_method_params.ValidateMethodParams):
(RawTypes.Number.get_validate_method_params):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py




Diff

Modified: trunk/Source/WebCore/ChangeLog (112262 => 112263)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 14:23:22 UTC (rev 112262)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 14:30:29 UTC (rev 112263)
@@ -1,3 +1,20 @@
+2012-03-27  Alexander Pavlov  
+
+Web Inspector: Enable "number" parameters in the web inspector protocol methods
+https://bugs.webkit.org/show_bug.cgi?id=82334
+
+The generated protocol dispatcher does not understand protocol method parameters of type "number"
+(mapped to "double" in the native code.)
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/CodeGeneratorInspector.py:
+(RawTypes.Number.get_getter_name):
+(RawTypes.Number.get_c_initializer):
+(RawTypes.Number.get_js_bind_type):
+(RawTypes.Number.get_validate_method_params.ValidateMethodParams):
+(RawTypes.Number.get_validate_method_params):
+
 2012-03-27  Alexei Filippov  
 
 Web Inspector: Fix missing objects in the dominators view.


Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (112262 => 112263)

--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-03-27 14:23:22 UTC (rev 112262)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-03-27 14:30:29 UTC (rev 112263)
@@ -338,7 +338,7 @@
 class Number(BaseType):
 @staticmethod
 def get_getter_name():
-return "Object"
+return "Double"
 
 @staticmethod
 def get_setter_name():
@@ -346,15 +346,19 @@
 
 @staticmethod
 def get_c_initializer():
-raise Exception("Unsupported")
+return "0"
 
 @staticmethod
 def get_js_bind_type():
-raise Exception("Unsupported")
+return "number"
 
 @staticmethod
 def get_validate_method_params():
-raise Exception("TODO")
+class ValidateMethodParams:
+name = "Double"
+var_type = "double"
+as_method_name = "Number"
+return ValidateMethodParams
 
 @staticmethod
 def get_output_pass_model():
@@ -1881,6 +1885,7 @@
 static R getPropertyValueImpl(InspectorObject* object, const String& name, bool* valueFound, InspectorArray* protocolErrors, V0 initial_value, bool (*as_method)(InspectorValue*, V*), const char* type_name);
 
 static int getInt(InspectorObject* object, const String& name, bool* valueFound, InspectorArray* protocolErrors);
+static double getDouble(InspectorObject* object, const String& name, bool* valueFound, InspectorArray* protocolErrors);
 static String getString(InspectorObject* object, const String& name, bool* valueFound, InspectorArray* protocolErrors);
 static bool getBoolean(InspectorObject* object, const String& name, bool* valueFound, InspectorArray* protocolErrors);
 static PassRefPtr getObject(InspectorObject* object, const String& name, bool* valueFound, InspectorArray* protocolErrors);
@@ -2049,6 +2054,7 @@
 
 struct AsMethodBridges {
 static bool asInt(InspectorValue* value, int* output) { return value->asNumber(output); }
+static bool asDouble(InspectorValue* value, double* output) { return value->asNumber(output); }
 static bool asString(InspectorValue* value, String* output) { return value->asString(output); }
 static bool asBoolean(InspectorValue* value, bool* output) { return value->asBoolean(output); }
 static bool asObject(InspectorValue* value, RefPtr* output) { return value->asObject(output); }
@@ -2060,6 +2066,11 @@
 return getPropertyValueImpl(object, name, valueFound, protocolErrors, 0, AsMethodBridges::asInt, "Number");
 }
 
+double InspectorBackendDispatcherImpl::getDouble(InspectorObject* object, const String& name, bool* valueFound, InspectorArray* protocolErrors)
+{
+return getPropertyValueImpl(object, name, valueFound, protocolErrors, 0, AsMethodBridges::asDouble, "Number");
+}
+
 String InspectorBackendDispatcherImpl::getString(InspectorObject* object, const String& name, bool* valueFound, InspectorArray* protocolErrors)
 {
 return getPropertyValueImpl(object, nam

[webkit-changes] [112262] trunk

[yurys]

Title: [112262] trunk








Revision 112262
Author yu...@chromium.org
Date 2012-03-27 07:23:22 -0700 (Tue, 27 Mar 2012)


Log Message
Web Inspector: Fix missing objects in the dominators view.
https://bugs.webkit.org/show_bug.cgi?id=82194

Due to the nature of dominators tree it is not possible to hide internal
objects there because they may happen to contain user objects that can't
be hidden.
Besides that it fixes a small bug in HeapSnapshotArraySlice.slice
function.

Patch by Alexei Filippov  on 2012-03-27
Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotArraySlice.prototype.slice):

LayoutTests:

* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt
trunk/LayoutTests/inspector/profiler/heap-snapshot.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js




Diff

Modified: trunk/LayoutTests/ChangeLog (112261 => 112262)

--- trunk/LayoutTests/ChangeLog	2012-03-27 13:37:43 UTC (rev 112261)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 14:23:22 UTC (rev 112262)
@@ -1,3 +1,19 @@
+2012-03-27  Alexei Filippov  
+
+Web Inspector: Fix missing objects in the dominators view.
+https://bugs.webkit.org/show_bug.cgi?id=82194
+
+Due to the nature of dominators tree it is not possible to hide internal
+objects there because they may happen to contain user objects that can't
+be hidden.
+Besides that it fixes a small bug in HeapSnapshotArraySlice.slice
+function.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/profiler/heap-snapshot-expected.txt:
+* inspector/profiler/heap-snapshot.html:
+
 2012-03-27  Alexis Menard  
 
 Increase code sharing between CSSComputedStyleDeclaration and CSSPropertyLonghand.


Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt (112261 => 112262)

--- trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt	2012-03-27 13:37:43 UTC (rev 112261)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt	2012-03-27 14:23:22 UTC (rev 112262)
@@ -19,6 +19,8 @@
 
 Running: heapSnapshotFlagsTest
 
+Running: heapSnapshotArraySliceTest
+
 Running: heapSnapshotNodesProviderTest
 
 Running: heapSnapshotEdgesProviderTest


Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot.html (112261 => 112262)

--- trunk/LayoutTests/inspector/profiler/heap-snapshot.html	2012-03-27 13:37:43 UTC (rev 112261)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot.html	2012-03-27 14:23:22 UTC (rev 112262)
@@ -172,6 +172,20 @@
 next();
 },
 
+function heapSnapshotArraySliceTest(next)
+{
+var snapshot = new WebInspector.HeapSnapshot(InspectorTest.createHeapSnapshotMock());
+var root = snapshot.rootNode;
+var rawEdges = root.rawEdges;
+InspectorTest.assertEquals(6, rawEdges.length);
+InspectorTest.assertEquals(6, rawEdges.slice(0).length);
+InspectorTest.assertEquals(3, rawEdges.slice(3).length);
+InspectorTest.assertEquals(3, rawEdges.slice(3, 6).length);
+InspectorTest.assertEquals(3, rawEdges.slice(0, 3).length);
+InspectorTest.assertEquals(0, rawEdges.slice(3, 3).length);
+next();
+},
+
 function heapSnapshotNodesProviderTest(next)
 {
 var snapshot = new WebInspector.HeapSnapshot(InspectorTest.createHeapSnapshotMock());


Modified: trunk/Source/WebCore/ChangeLog (112261 => 112262)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 13:37:43 UTC (rev 112261)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 14:23:22 UTC (rev 112262)
@@ -1,3 +1,21 @@
+2012-03-27  Alexei Filippov  
+
+Web Inspector: Fix missing objects in the dominators view.
+https://bugs.webkit.org/show_bug.cgi?id=82194
+
+Due to the nature of dominators tree it is not possible to hide internal
+objects there because they may happen to contain user objects that can't
+be hidden.
+Besides that it fixes a small bug in HeapSnapshotArraySlice.slice
+function.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DetailedHeapshotGridNodes.js:
+(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
+* inspector/front-end/HeapSnapshot.js:
+(WebInspector.HeapSnapshotArraySlice.prototype.slice):
+
 2012-03-27  Antti Koivisto  
 
 Remove Document::mappedElementSheet() 


Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js (112261 => 112262)

--- trunk/Source/WebCore

[webkit-changes] [112261] trunk/Tools

[carlosgc]

Title: [112261] trunk/Tools








Revision 112261
Author carlo...@webkit.org
Date 2012-03-27 06:37:43 -0700 (Tue, 27 Mar 2012)


Log Message
Unreviewed. Skip GTK+ unit tests that fail in the bots

* Scripts/run-gtk-tests:
(TestRunner): Add failing tests to the skipped list.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests




Diff

Modified: trunk/Tools/ChangeLog (112260 => 112261)

--- trunk/Tools/ChangeLog	2012-03-27 13:22:18 UTC (rev 112260)
+++ trunk/Tools/ChangeLog	2012-03-27 13:37:43 UTC (rev 112261)
@@ -1,5 +1,12 @@
 2012-03-27  Carlos Garcia Campos  
 
+Unreviewed. Skip GTK+ unit tests that fail in the bots
+
+* Scripts/run-gtk-tests:
+(TestRunner): Add failing tests to the skipped list.
+
+2012-03-27  Carlos Garcia Campos  
+
 Unreviewed. Unskip all GTK+ unit test.
 
 Currently, skipped tests contains the list of unit tests that have


Modified: trunk/Tools/Scripts/run-gtk-tests (112260 => 112261)

--- trunk/Tools/Scripts/run-gtk-tests	2012-03-27 13:22:18 UTC (rev 112260)
+++ trunk/Tools/Scripts/run-gtk-tests	2012-03-27 13:37:43 UTC (rev 112261)
@@ -29,7 +29,15 @@
 class TestRunner:
 
 TEST_DIRS = [ "unittests", "WebKit2APITests" ]
-SKIPPED = []
+# FIXME: https://bugs.webkit.org/show_bug.cgi?id=74717
+SKIPPED = [
+# https://bugs.webkit.org/show_bug.cgi?id=82329
+"unittests/testdownload",
+# https://bugs.webkit.org/show_bug.cgi?id=82328
+"unittests/testwebview",
+# https://bugs.webkit.org/show_bug.cgi?id=82330
+"unittests/testwebresource"
+]
 
 def __init__(self, options, tests=[]):
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112260] branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp

[leviw]

Title: [112260] branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp








Revision 112260
Author le...@chromium.org
Date 2012-03-27 06:22:18 -0700 (Tue, 27 Mar 2012)


Log Message
Plugins are always positioned at integer boundaries, so the size can be rounded. Correcting unnecessary pixel snapping in SubframeLoader.

Modified Paths

branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp (112259 => 112260)

--- branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp	2012-03-27 12:45:46 UTC (rev 112259)
+++ branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp	2012-03-27 13:22:18 UTC (rev 112260)
@@ -171,7 +171,7 @@
 IntSize size;
 
 if (renderer)
-size = renderer->contentBoxRect().pixelSnappedSize();
+size = roundedIntSize(renderer->contentBoxRect());
 else if (mediaElement->isVideo())
 size = RenderVideo::defaultSize();
 
@@ -360,7 +360,7 @@
 if (!frameLoader->checkIfRunInsecureContent(document()->securityOrigin(), url))
 return false;
 
-IntSize contentSize = renderer->contentBoxRect().pixelSnappedSize();
+IntSize contentSize = roundedIntSize(renderer->contentBoxRect().size());
 bool loadManually = document()->isPluginDocument() && !m_containsPlugins && toPluginDocument(document())->shouldLoadPluginManually();
 RefPtr widget = frameLoader->client()->createPlugin(contentSize,
 pluginElement, url, paramNames, paramValues, mimeType, loadManually);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112259] trunk/Source/WebCore/ChangeLog

[antti]

Title: [112259] trunk/Source/WebCore/ChangeLog








Revision 112259
Author an...@apple.com
Date 2012-03-27 05:45:46 -0700 (Tue, 27 Mar 2012)


Log Message
Fix Kling's name.

Modified Paths

trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (112258 => 112259)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 12:40:38 UTC (rev 112258)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 12:45:46 UTC (rev 112259)
@@ -3,7 +3,7 @@
 Remove Document::mappedElementSheet() 
 https://bugs.webkit.org/show_bug.cgi?id=82242
 
-Reviewed by Anreas Kling and Nikolas Zimmermann.
+Reviewed by Andreas Kling and Nikolas Zimmermann.
 
 The only thing this is used for anymore is SVGFontFaceElement. That can be handled without
 the confusing extra stylesheet.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112258] trunk/Source/WebCore

[antti]

Title: [112258] trunk/Source/WebCore








Revision 112258
Author an...@apple.com
Date 2012-03-27 05:40:38 -0700 (Tue, 27 Mar 2012)


Log Message
Remove Document::mappedElementSheet() 
https://bugs.webkit.org/show_bug.cgi?id=82242

Reviewed by Anreas Kling and Nikolas Zimmermann.

The only thing this is used for anymore is SVGFontFaceElement. That can be handled without
the confusing extra stylesheet.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
* css/CSSStyleSelector.h:
(CSSStyleSelector):

- Add font face rules from registered SVGFontFaceElements.
- Simplify the constructor signature. Stylesheets are part of the document.

* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::createStyleSelector):
(WebCore):
(WebCore::Document::updateBaseURL):
* dom/Document.h:
(WebCore):
(WebCore::Document::documentUserSheets):
(Document):

- Remove mappedElementSheet
- Adapt to the CSSStyleSelector constructor signature changes.

* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::svgFontFaceElements):
(WebCore):
(WebCore::SVGDocumentExtensions::registerSVGFontFaceElement):
(WebCore::SVGDocumentExtensions::unregisterSVGFontFaceElement):
* svg/SVGDocumentExtensions.h:
(WebCore):
(SVGDocumentExtensions):

- Add map for SVGFontFaceElements

* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):
(WebCore):
* svg/SVGFontFaceElement.h:
(SVGFontFaceElement):
(WebCore::SVGFontFaceElement::fontFaceRule):

- Switch to updating svgFontFaceElements map.
- Use elementSheet as the parent sheet (nothing is ever added to the elementSheet, it is used for
  resolving relative URLs only).

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp
trunk/Source/WebCore/svg/SVGDocumentExtensions.h
trunk/Source/WebCore/svg/SVGFontFaceElement.cpp
trunk/Source/WebCore/svg/SVGFontFaceElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112257 => 112258)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 12:32:06 UTC (rev 112257)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 12:40:38 UTC (rev 112258)
@@ -1,3 +1,57 @@
+2012-03-27  Antti Koivisto  
+
+Remove Document::mappedElementSheet() 
+https://bugs.webkit.org/show_bug.cgi?id=82242
+
+Reviewed by Anreas Kling and Nikolas Zimmermann.
+
+The only thing this is used for anymore is SVGFontFaceElement. That can be handled without
+the confusing extra stylesheet.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::CSSStyleSelector):
+* css/CSSStyleSelector.h:
+(CSSStyleSelector):
+
+- Add font face rules from registered SVGFontFaceElements.
+- Simplify the constructor signature. Stylesheets are part of the document.
+
+* dom/Document.cpp:
+(WebCore::Document::~Document):
+(WebCore::Document::createStyleSelector):
+(WebCore):
+(WebCore::Document::updateBaseURL):
+* dom/Document.h:
+(WebCore):
+(WebCore::Document::documentUserSheets):
+(Document):
+
+- Remove mappedElementSheet
+- Adapt to the CSSStyleSelector constructor signature changes.
+
+* svg/SVGDocumentExtensions.cpp:
+(WebCore::SVGDocumentExtensions::svgFontFaceElements):
+(WebCore):
+(WebCore::SVGDocumentExtensions::registerSVGFontFaceElement):
+(WebCore::SVGDocumentExtensions::unregisterSVGFontFaceElement):
+* svg/SVGDocumentExtensions.h:
+(WebCore):
+(SVGDocumentExtensions):
+
+- Add map for SVGFontFaceElements
+
+* svg/SVGFontFaceElement.cpp:
+(WebCore::SVGFontFaceElement::insertedIntoDocument):
+(WebCore::SVGFontFaceElement::removedFromDocument):
+(WebCore):
+* svg/SVGFontFaceElement.h:
+(SVGFontFaceElement):
+(WebCore::SVGFontFaceElement::fontFaceRule):
+
+- Switch to updating svgFontFaceElements map.
+- Use elementSheet as the parent sheet (nothing is ever added to the elementSheet, it is used for
+  resolving relative URLs only).
+
 2012-03-27  Vsevolod Vlasov  
 
 Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before.


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (112257 => 112258)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-03-27 12:32:06 UTC (rev 112257)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-03-27 12:40:38 UTC (rev 112258)
@@ -91,6 +91,8 @@
 #include "RenderTheme.h"
 #include "RotateTransformOperation.h"
 #inc