[webkit-changes] [113415] trunk/Source/WebCore
Title: [113415] trunk/Source/WebCore
Revision 113415
Author ad...@apple.com
Date 2012-04-05 22:23:25 -0700 (Thu, 05 Apr 2012)
Log Message
and https://bugs.webkit.org/show_bug.cgi?id=74129
REGRESSION (SnowLeopard, 5.1.4): All WK2 horizontal scrollbars look broken
Patch by Dan Bernstein, Reviewed by Beth Dakin.
This code assumed that the current CTM wouldn't have extraneous operations built into it,
but this bug is evidence that that assumption was wrong. We should just get the base CTM instead
and apply the device scale factor to it.
No tests added since the SnowLeopard-style scrollbars aren't testable in our regression tests right now.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
* platform/graphics/GraphicsContext.h: (GraphicsContext):
* platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (113414 => 113415)
--- trunk/Source/WebCore/ChangeLog 2012-04-06 05:16:05 UTC (rev 113414)
+++ trunk/Source/WebCore/ChangeLog 2012-04-06 05:23:25 UTC (rev 113415)
@@ -1,3 +1,22 @@
+2012-04-05 Adele Peterson
+
+ and https://bugs.webkit.org/show_bug.cgi?id=74129
+REGRESSION (SnowLeopard, 5.1.4): All WK2 horizontal scrollbars look broken
+
+Patch by Dan Bernstein, Reviewed by Beth Dakin.
+
+This code assumed that the current CTM wouldn't have extraneous operations built into it,
+but this bug is evidence that that assumption was wrong. We should just get the base CTM instead
+and apply the device scale factor to it.
+
+No tests added since the SnowLeopard-style scrollbars aren't testable in our regression tests right now.
+
+* platform/graphics/GraphicsContext.cpp:
+(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
+(WebCore::GraphicsContext::applyDeviceScaleFactor):
+* platform/graphics/GraphicsContext.h: (GraphicsContext):
+* platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
+
2012-04-05 Yuta Kitamura
Leak in WebSocketChannel with workers/worker-reload.html
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (113414 => 113415)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp 2012-04-06 05:16:05 UTC (rev 113414)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp 2012-04-06 05:23:25 UTC (rev 113415)
@@ -765,7 +765,7 @@
}
#if !USE(CG)
-void GraphicsContext::platformApplyDeviceScaleFactor()
+void GraphicsContext::platformApplyDeviceScaleFactor(float)
{
}
#endif
@@ -773,7 +773,7 @@
void GraphicsContext::applyDeviceScaleFactor(float deviceScaleFactor)
{
scale(FloatSize(deviceScaleFactor, deviceScaleFactor));
-platformApplyDeviceScaleFactor();
+platformApplyDeviceScaleFactor(deviceScaleFactor);
}
void GraphicsContext::fillEllipse(const FloatRect& ellipse)
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (113414 => 113415)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h 2012-04-06 05:16:05 UTC (rev 113414)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h 2012-04-06 05:23:25 UTC (rev 113415)
@@ -427,7 +427,7 @@
// This function applies the device scale factor to the context, making the context capable of
// acting as a base-level context for a HiDPI environment.
void applyDeviceScaleFactor(float);
-void platformApplyDeviceScaleFactor();
+void platformApplyDeviceScaleFactor(float);
#if OS(WINCE) && !PLATFORM(QT)
void setBitmap(PassRefPtr);
Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (113414 => 113415)
--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2012-04-06 05:16:05 UTC (rev 113414)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2012-04-06 05:23:25 UTC (rev 113415)
@@ -65,9 +65,9 @@
#endif
-// Undocumented CGContextSetCTM function, available at least since 10.4.
extern "C" {
CG_EXTERN void CGContextSetCTM(CGContextRef, CGAffineTransform);
+CG_EXTERN CGAffineTransform CGContextGetBaseCTM(CGContextRef);
};
using namespace std;
@@ -1628,12 +1628,12 @@
CGContextSetBlendMode(platformContext(), target);
}
-void GraphicsContext::platformApplyDeviceScaleFactor()
+void GraphicsContext::platformApplyDeviceScaleFactor(float deviceScaleFactor)
{
// CoreGraphics expects the base CTM of a HiDPI context to have the scale factor applied to it.
// Failing to change the base level CTM will cause certain CG features, such as focus rings,
/
[webkit-changes] [113414] trunk/Source/WebCore
Title: [113414] trunk/Source/WebCore
Revision 113414
Author yu...@chromium.org
Date 2012-04-05 22:16:05 -0700 (Thu, 05 Apr 2012)
Log Message
Leak in WebSocketChannel with workers/worker-reload.html
https://bugs.webkit.org/show_bug.cgi?id=83345
Reviewed by David Levin.
A speculative fix of memory leaks caused by worker-reload.html.
No new tests, as this change imposes no functional change.
* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
Receive the peer as PassOwnPtr<> so the destructor of the task object can
delete the peer even if the task didn't run before main thread's cleanup period.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp
trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (113413 => 113414)
--- trunk/Source/WebCore/ChangeLog 2012-04-06 04:57:45 UTC (rev 113413)
+++ trunk/Source/WebCore/ChangeLog 2012-04-06 05:16:05 UTC (rev 113414)
@@ -1,3 +1,22 @@
+2012-04-05 Yuta Kitamura
+
+Leak in WebSocketChannel with workers/worker-reload.html
+https://bugs.webkit.org/show_bug.cgi?id=83345
+
+Reviewed by David Levin.
+
+A speculative fix of memory leaks caused by worker-reload.html.
+
+No new tests, as this change imposes no functional change.
+
+* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
+(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
+Receive the peer as PassOwnPtr<> so the destructor of the task object can
+delete the peer even if the task didn't run before main thread's cleanup period.
+(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
+* Modules/websockets/WorkerThreadableWebSocketChannel.h:
+(WorkerThreadableWebSocketChannel):
+
2012-04-05 Lu Guanqun
combine two arrays (coreExceptionNames and coreExceptionDescriptions) into one array
Modified: trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp (113413 => 113414)
--- trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp 2012-04-06 04:57:45 UTC (rev 113413)
+++ trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp 2012-04-06 05:16:05 UTC (rev 113414)
@@ -568,22 +568,23 @@
m_loaderProxy.postTaskToLoader(createCallbackTask(&WorkerThreadableWebSocketChannel::mainThreadFail, AllowCrossThreadAccess(m_peer), reason));
}
-void WorkerThreadableWebSocketChannel::mainThreadDestroy(ScriptExecutionContext* context, Peer* peer)
+void WorkerThreadableWebSocketChannel::mainThreadDestroy(ScriptExecutionContext* context, PassOwnPtr peer)
{
ASSERT(isMainThread());
ASSERT_UNUSED(context, context->isDocument());
-ASSERT(peer);
+ASSERT_UNUSED(peer, peer);
-delete peer;
+// Peer object will be deleted even if the task does not run in the main thread's cleanup period, because
+// the destructor for the task object (created by createCallbackTask()) will automatically delete the peer.
}
void WorkerThreadableWebSocketChannel::Bridge::disconnect()
{
clearClientWrapper();
if (m_peer) {
-Peer* peer = m_peer;
+OwnPtr peer = adoptPtr(m_peer);
m_peer = 0;
-m_loaderProxy.postTaskToLoader(createCallbackTask(&mainThreadDestroy, AllowCrossThreadAccess(peer)));
+m_loaderProxy.postTaskToLoader(createCallbackTask(&WorkerThreadableWebSocketChannel::mainThreadDestroy, peer.release()));
}
m_workerContext = 0;
}
Modified: trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h (113413 => 113414)
--- trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h 2012-04-06 04:57:45 UTC (rev 113413)
+++ trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h 2012-04-06 05:16:05 UTC (rev 113414)
@@ -177,7 +177,7 @@
static void mainThreadBufferedAmount(ScriptExecutionContext*, Peer*);
static void mainThreadClose(ScriptExecutionContext*, Peer*, int code, const String& reason);
static void mainThreadFail(ScriptExecutionContext*, Peer*, const String& reason);
-static void mainThreadDestroy(ScriptExecutionContext*, Peer*);
+static void mainThreadDestroy(ScriptExecutionContext*, PassOwnPtr);
static void mainThreadSuspend(ScriptExecutionContext*, Peer*);
static void mainThreadResume(ScriptExecutionContext*, Peer*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [113413] trunk/Source/WebCore
Title: [113413] trunk/Source/WebCore
Revision 113413
Author commit-qu...@webkit.org
Date 2012-04-05 21:57:45 -0700 (Thu, 05 Apr 2012)
Log Message
combine two arrays (coreExceptionNames and coreExceptionDescriptions) into one array
https://bugs.webkit.org/show_bug.cgi?id=83141
Patch by Lu Guanqun on 2012-04-05
Reviewed by Adam Barth.
No new tests required.
* dom/DOMCoreException.cpp:
(CoreException):
(WebCore):
(WebCore::DOMCoreException::initializeDescription):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMCoreException.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (113412 => 113413)
--- trunk/Source/WebCore/ChangeLog 2012-04-06 04:49:34 UTC (rev 113412)
+++ trunk/Source/WebCore/ChangeLog 2012-04-06 04:57:45 UTC (rev 113413)
@@ -1,3 +1,17 @@
+2012-04-05 Lu Guanqun
+
+combine two arrays (coreExceptionNames and coreExceptionDescriptions) into one array
+https://bugs.webkit.org/show_bug.cgi?id=83141
+
+Reviewed by Adam Barth.
+
+No new tests required.
+
+* dom/DOMCoreException.cpp:
+(CoreException):
+(WebCore):
+(WebCore::DOMCoreException::initializeDescription):
+
2012-04-05 David Barton
Remove intrinsic padding from contentBoxRect(), etc.
Modified: trunk/Source/WebCore/dom/DOMCoreException.cpp (113412 => 113413)
--- trunk/Source/WebCore/dom/DOMCoreException.cpp 2012-04-06 04:49:34 UTC (rev 113412)
+++ trunk/Source/WebCore/dom/DOMCoreException.cpp 2012-04-06 04:57:45 UTC (rev 113413)
@@ -31,77 +31,49 @@
namespace WebCore {
-// FIXME: This should be an array of structs to pair the names and descriptions.
-static const char* const coreExceptionNames[] = {
-"INDEX_SIZE_ERR",
-"DOMSTRING_SIZE_ERR",
-"HIERARCHY_REQUEST_ERR",
-"WRONG_DOCUMENT_ERR",
-"INVALID_CHARACTER_ERR",
-"NO_DATA_ALLOWED_ERR",
-"NO_MODIFICATION_ALLOWED_ERR",
-"NOT_FOUND_ERR",
-"NOT_SUPPORTED_ERR",
-"INUSE_ATTRIBUTE_ERR",
-"INVALID_STATE_ERR",
-"SYNTAX_ERR",
-"INVALID_MODIFICATION_ERR",
-"NAMESPACE_ERR",
-"INVALID_ACCESS_ERR",
-"VALIDATION_ERR",
-"TYPE_MISMATCH_ERR",
-"SECURITY_ERR",
-"NETWORK_ERR",
-"ABORT_ERR",
-"URL_MISMATCH_ERR",
-"QUOTA_EXCEEDED_ERR",
-"TIMEOUT_ERR",
-"INVALID_NODE_TYPE_ERR",
-"DATA_CLONE_ERR"
-};
-
-static const char* const coreExceptionDescriptions[] = {
-"Index or size was negative, or greater than the allowed value.",
-"The specified range of text did not fit into a DOMString.",
-"A Node was inserted somewhere it doesn't belong.",
-"A Node was used in a different document than the one that created it (that doesn't support it).",
-"An invalid or illegal character was specified, such as in an XML name.",
-"Data was specified for a Node which does not support data.",
-"An attempt was made to modify an object where modifications are not allowed.",
-"An attempt was made to reference a Node in a context where it does not exist.",
-"The implementation did not support the requested type of object or operation.",
-"An attempt was made to add an attribute that is already in use elsewhere.",
-"An attempt was made to use an object that is not, or is no longer, usable.",
-"An invalid or illegal string was specified.",
-"An attempt was made to modify the type of the underlying object.",
-"An attempt was made to create or change an object in a way which is incorrect with regard to namespaces.",
-"A parameter or an operation was not supported by the underlying object.",
-"A call to a method such as insertBefore or removeChild would make the Node invalid with respect to \"partial validity\", this exception would be raised and the operation would not be done.",
-"The type of an object was incompatible with the expected type of the parameter associated to the object.",
-"An attempt was made to break through the security policy of the user agent.",
+static struct CoreException {
+const char* const name;
+const char* const description;
+} coreExceptions[] = {
+{ "INDEX_SIZE_ERR", "Index or size was negative, or greater than the allowed value." },
+{ "DOMSTRING_SIZE_ERR", "The specified range of text did not fit into a DOMString." },
+{ "HIERARCHY_REQUEST_ERR", "A Node was inserted somewhere it doesn't belong." },
+{ "WRONG_DOCUMENT_ERR", "A Node was used in a different document than the one that created it (that doesn't support it)." },
+{ "INVALID_CHARACTER_ERR", "An invalid or illegal character was specified, such as in an XML name." },
+{ "NO_DATA_ALLOWED_ERR", "Data was specified for a Node which does not support data." },
+{ "NO_MODIFICATION_ALLOWED_ERR", "An attempt was made to modify an object where modifications are not allowed." },
+{ "NOT_FOUND_ERR", "An attempt was made to reference a Node in a context where it does not exist." },
+{ "NOT_SUPPORTED_ERR", "The implementation d
[webkit-changes] [113412] trunk/LayoutTests
Title: [113412] trunk/LayoutTests
Revision 113412
Author mrobin...@webkit.org
Date 2012-04-05 21:49:34 -0700 (Thu, 05 Apr 2012)
Log Message
Rebaseline a couple tests for GTK+.
* platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
* platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt
trunk/LayoutTests/platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (113411 => 113412)
--- trunk/LayoutTests/ChangeLog 2012-04-06 04:26:50 UTC (rev 113411)
+++ trunk/LayoutTests/ChangeLog 2012-04-06 04:49:34 UTC (rev 113412)
@@ -1,3 +1,10 @@
+2012-04-05 Martin Robinson
+
+Rebaseline a couple tests for GTK+.
+
+* platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
+* platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
+
2012-04-05 Raphael Kubo da Costa
[EFL] Gardening; update expctations in fast/css-generated-content.
Modified: trunk/LayoutTests/platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt (113411 => 113412)
--- trunk/LayoutTests/platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt 2012-04-06 04:26:50 UTC (rev 113411)
+++ trunk/LayoutTests/platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt 2012-04-06 04:49:34 UTC (rev 113412)
@@ -3,14 +3,15 @@
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x576 [bgcolor=#008000]
- RenderBlock {P} at (0,0) size 784x19
-RenderText {#text} at (0,0) size 432x19
- text run at (0,0) width 432: "Test for iframe flattening. The flattening only works inside the DRT."
- RenderBlock {P} at (0,35) size 784x19
-RenderText {#text} at (0,0) size 778x19
- text run at (0,0) width 434: "This inner frame should be 200px in each direction, disregarding the "
- text run at (434,0) width 344: "border, and it must not be scrollable or have scrollbars."
- RenderBlock {P} at (0,70) size 784x204
+ RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 441x17
+ text run at (0,0) width 441: "Test for iframe flattening. The flattening only works inside the DRT."
+ RenderBlock {P} at (0,34) size 784x36
+RenderText {#text} at (0,0) size 725x35
+ text run at (0,0) width 443: "This inner frame should be 200px in each direction, disregarding the "
+ text run at (442,0) width 283: "border, and it must not be scrollable or have"
+ text run at (0,18) width 67: "scrollbars."
+ RenderBlock {P} at (0,86) size 784x204
RenderPartObject {IFRAME} at (0,0) size 204x204 [border: (2px inset #00)]
layer at (0,0) size 400x400
RenderView at (0,0) size 200x200
Modified: trunk/LayoutTests/platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt (113411 => 113412)
--- trunk/LayoutTests/platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt 2012-04-06 04:26:50 UTC (rev 113411)
+++ trunk/LayoutTests/platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt 2012-04-06 04:49:34 UTC (rev 113412)
@@ -7,20 +7,20 @@
RenderPartObject {IFRAME} at (0,0) size 502x402 [bgcolor=#FF] [border: (1px solid #00)]
layer at (0,0) size 500x400
RenderView at (0,0) size 500x400
- layer at (0,0) size 500x235
-RenderBlock {HTML} at (0,0) size 500x235
- RenderBody {BODY} at (8,16) size 484x211
-RenderBlock {P} at (0,0) size 484x19
- RenderText {#text} at (0,0) size 186x19
-text run at (0,0) width 186: "This is the intermediate frame"
-RenderBlock (anonymous) at (0,35) size 484x176
+ layer at (0,0) size 500x234
+RenderBlock {HTML} at (0,0) size 500x234
+ RenderBody {BODY} at (8,16) size 484x210
+RenderBlock {P} at (0,0) size 484x18
+ RenderText {#text} at (0,0) size 192x17
+text run at (0,0) width 192: "This is the intermediate frame"
+RenderBlock (anonymous) at (0,34) size 484x176
RenderPartObject {IFRAME} at (0,0) size 252x172 [border: (1px solid #00)]
layer at (0,0) size 250x170
RenderView at (0,0) size 250x170
-layer at (0,0) size 250x51
- RenderBlock {HTML} at (0,0) size 250x51
-RenderBody {BODY} at (8,16) size
[webkit-changes] [113411] trunk/LayoutTests
Title: [113411] trunk/LayoutTests
Revision 113411
Author rak...@webkit.org
Date 2012-04-05 21:26:50 -0700 (Thu, 05 Apr 2012)
Log Message
[EFL] Gardening; update expctations in fast/css-generated-content.
Mostly adapt to the size changes after the jhbuild and font
commits.
* platform/efl/fast/css-generated-content/003-expected.txt:
* platform/efl/fast/css-generated-content/009-expected.png:
* platform/efl/fast/css-generated-content/009-expected.txt:
* platform/efl/fast/css-generated-content/013-expected.png:
* platform/efl/fast/css-generated-content/013-expected.txt:
* platform/efl/fast/css-generated-content/014-expected.png:
* platform/efl/fast/css-generated-content/014-expected.txt:
* platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.png:
* platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.txt:
* platform/efl/fast/css-generated-content/inline-display-types-expected.png:
* platform/efl/fast/css-generated-content/inline-display-types-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/fast/css-generated-content/003-expected.txt
trunk/LayoutTests/platform/efl/fast/css-generated-content/009-expected.png
trunk/LayoutTests/platform/efl/fast/css-generated-content/009-expected.txt
trunk/LayoutTests/platform/efl/fast/css-generated-content/013-expected.png
trunk/LayoutTests/platform/efl/fast/css-generated-content/013-expected.txt
trunk/LayoutTests/platform/efl/fast/css-generated-content/014-expected.png
trunk/LayoutTests/platform/efl/fast/css-generated-content/014-expected.txt
trunk/LayoutTests/platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.png
trunk/LayoutTests/platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.txt
trunk/LayoutTests/platform/efl/fast/css-generated-content/inline-display-types-expected.png
trunk/LayoutTests/platform/efl/fast/css-generated-content/inline-display-types-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (113410 => 113411)
--- trunk/LayoutTests/ChangeLog 2012-04-06 04:26:27 UTC (rev 113410)
+++ trunk/LayoutTests/ChangeLog 2012-04-06 04:26:50 UTC (rev 113411)
@@ -1,5 +1,24 @@
2012-04-05 Raphael Kubo da Costa
+[EFL] Gardening; update expctations in fast/css-generated-content.
+
+Mostly adapt to the size changes after the jhbuild and font
+commits.
+
+* platform/efl/fast/css-generated-content/003-expected.txt:
+* platform/efl/fast/css-generated-content/009-expected.png:
+* platform/efl/fast/css-generated-content/009-expected.txt:
+* platform/efl/fast/css-generated-content/013-expected.png:
+* platform/efl/fast/css-generated-content/013-expected.txt:
+* platform/efl/fast/css-generated-content/014-expected.png:
+* platform/efl/fast/css-generated-content/014-expected.txt:
+* platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.png:
+* platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.txt:
+* platform/efl/fast/css-generated-content/inline-display-types-expected.png:
+* platform/efl/fast/css-generated-content/inline-display-types-expected.txt:
+
+2012-04-05 Raphael Kubo da Costa
+
[EFL] Gardening after r110072.
* platform/efl/fast/clip/008-expected.png:
Modified: trunk/LayoutTests/platform/efl/fast/css-generated-content/003-expected.txt (113410 => 113411)
--- trunk/LayoutTests/platform/efl/fast/css-generated-content/003-expected.txt 2012-04-06 04:26:27 UTC (rev 113410)
+++ trunk/LayoutTests/platform/efl/fast/css-generated-content/003-expected.txt 2012-04-06 04:26:50 UTC (rev 113411)
@@ -3,7 +3,7 @@
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {DIV} at (0,0) size 784x19
+ RenderBlock {DIV} at (0,0) size 784x18
RenderBlock (floating) at (0,0) size 15x52
RenderText {#text} at (0,0) size 15x51
text run at (0,0) width 15: "I"
Modified: trunk/LayoutTests/platform/efl/fast/css-generated-content/009-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/efl/fast/css-generated-content/009-expected.txt (113410 => 113411)
--- trunk/LayoutTests/platform/efl/fast/css-generated-content/009-expected.txt 2012-04-06 04:26:27 UTC (rev 113410)
+++ trunk/LayoutTests/platform/efl/fast/css-generated-content/009-expected.txt 2012-04-06 04:26:50 UTC (rev 113411)
@@ -3,7 +3,7 @@
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x19
+ RenderBlock {P} at (0,0) size 784x18
RenderText {#text} at (0,0) size 67x19
text run at (0,0) width 67: "All of this "
RenderInline {SPAN} at (0,0) size 88x19
@@ -11,20 +11,20 @@
text run at (67,0) width 88: "text should
[webkit-changes] [113410] trunk/LayoutTests
Title: [113410] trunk/LayoutTests
Revision 113410
Author rak...@webkit.org
Date 2012-04-05 21:26:27 -0700 (Thu, 05 Apr 2012)
Log Message
[EFL] Gardening after r110072.
* platform/efl/fast/clip/008-expected.png:
* platform/efl/fast/clip/008-expected.txt:
* platform/efl/fast/clip/011-expected.png:
* platform/efl/fast/clip/011-expected.txt:
* platform/efl/fast/clip/012-expected.png:
* platform/efl/fast/clip/012-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/fast/clip/008-expected.png
trunk/LayoutTests/platform/efl/fast/clip/008-expected.txt
trunk/LayoutTests/platform/efl/fast/clip/011-expected.png
trunk/LayoutTests/platform/efl/fast/clip/011-expected.txt
trunk/LayoutTests/platform/efl/fast/clip/012-expected.png
trunk/LayoutTests/platform/efl/fast/clip/012-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (113409 => 113410)
--- trunk/LayoutTests/ChangeLog 2012-04-06 04:26:08 UTC (rev 113409)
+++ trunk/LayoutTests/ChangeLog 2012-04-06 04:26:27 UTC (rev 113410)
@@ -1,5 +1,16 @@
2012-04-05 Raphael Kubo da Costa
+[EFL] Gardening after r110072.
+
+* platform/efl/fast/clip/008-expected.png:
+* platform/efl/fast/clip/008-expected.txt:
+* platform/efl/fast/clip/011-expected.png:
+* platform/efl/fast/clip/011-expected.txt:
+* platform/efl/fast/clip/012-expected.png:
+* platform/efl/fast/clip/012-expected.txt:
+
+2012-04-05 Raphael Kubo da Costa
+
[EFL] Gardening after r112112.
* platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
Modified: trunk/LayoutTests/platform/efl/fast/clip/008-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/efl/fast/clip/008-expected.txt (113409 => 113410)
--- trunk/LayoutTests/platform/efl/fast/clip/008-expected.txt 2012-04-06 04:26:08 UTC (rev 113409)
+++ trunk/LayoutTests/platform/efl/fast/clip/008-expected.txt 2012-04-06 04:26:27 UTC (rev 113410)
@@ -15,5 +15,4 @@
RenderBlock (positioned) {DIV} at (8,62) size 100x100
layer at (100,100) size 100x100
RenderBlock (positioned) {DIV} at (100,100) size 100x100
-layer at (200,200) size 100x100
- RenderBlock {DIV} at (100,100) size 100x100 [bgcolor=#008000]
+RenderBlock {DIV} at (100,100) size 100x100 [bgcolor=#008000]
Modified: trunk/LayoutTests/platform/efl/fast/clip/011-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/efl/fast/clip/011-expected.txt (113409 => 113410)
--- trunk/LayoutTests/platform/efl/fast/clip/011-expected.txt 2012-04-06 04:26:08 UTC (rev 113409)
+++ trunk/LayoutTests/platform/efl/fast/clip/011-expected.txt 2012-04-06 04:26:27 UTC (rev 113410)
@@ -12,3 +12,4 @@
layer at (8,44) size 100x100
RenderBlock (positioned) {DIV} at (8,44) size 100x100 [bgcolor=#008000]
RenderBlock {DIV} at (100,100) size 100x100 [bgcolor=#FF]
+RenderBlock {DIV} at (100,300) size 100x100 [bgcolor=#FF]
Modified: trunk/LayoutTests/platform/efl/fast/clip/012-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/efl/fast/clip/012-expected.txt (113409 => 113410)
--- trunk/LayoutTests/platform/efl/fast/clip/012-expected.txt 2012-04-06 04:26:08 UTC (rev 113409)
+++ trunk/LayoutTests/platform/efl/fast/clip/012-expected.txt 2012-04-06 04:26:27 UTC (rev 113410)
@@ -12,3 +12,4 @@
layer at (8,44) size 100x100
RenderBlock (positioned) {DIV} at (8,44) size 100x100 [bgcolor=#008000]
RenderBlock {DIV} at (100,100) size 100x100 [bgcolor=#FF]
+RenderBlock {DIV} at (100,300) size 100x100 [bgcolor=#FF]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [113409] trunk/LayoutTests
Title: [113409] trunk/LayoutTests
Revision 113409
Author rak...@webkit.org
Date 2012-04-05 21:26:08 -0700 (Thu, 05 Apr 2012)
Log Message
[EFL] Gardening after r112112.
* platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (113408 => 113409)
--- trunk/LayoutTests/ChangeLog 2012-04-06 04:08:16 UTC (rev 113408)
+++ trunk/LayoutTests/ChangeLog 2012-04-06 04:26:08 UTC (rev 113409)
@@ -1,5 +1,11 @@
2012-04-05 Raphael Kubo da Costa
+[EFL] Gardening after r112112.
+
+* platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
+
+2012-04-05 Raphael Kubo da Costa
+
[EFL] Gardening. Update baselines and expectations in
fast/backgrounds, fast/block, fast/box-shadow and fast/box-sizing.
Added: trunk/LayoutTests/platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt (0 => 113409)
--- trunk/LayoutTests/platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt 2012-04-06 04:26:08 UTC (rev 113409)
@@ -0,0 +1,82 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x428
+ RenderBlock {HTML} at (0,0) size 800x428
+RenderBody {BODY} at (8,16) size 784x396
+ RenderBlock {P} at (0,0) size 784x18 [color=#80]
+RenderText {#text} at (0,0) size 226x19
+ text run at (0,0) width 226: "This sentence should be underlined."
+ RenderBlock {P} at (0,34) size 784x18 [color=#80]
+RenderText {#text} at (0,0) size 218x19
+ text run at (0,0) width 218: "This sentence should be overlined."
+ RenderBlock {P} at (0,68) size 784x18 [color=#80]
+RenderText {#text} at (0,0) size 232x19
+ text run at (0,0) width 232: "This sentence should be stricken out."
+ RenderBlock {P} at (0,102) size 784x18 [color=#80]
+RenderText {#text} at (0,0) size 369x19
+ text run at (0,0) width 369: "This sentence should be blinking (if the UA supports that)."
+ RenderBlock {P} at (0,136) size 784x18 [color=#80]
+RenderText {#text} at (0,0) size 227x19
+ text run at (0,0) width 227: "The sentence should be underlined. "
+RenderInline {B} at (0,0) size 238x19
+ RenderText {#text} at (227,0) size 238x19
+text run at (227,0) width 238: "This sentence should be underlined"
+RenderText {#text} at (465,0) size 4x19
+ text run at (465,0) width 4: "."
+ RenderBlock {P} at (0,170) size 784x18 [color=#80]
+RenderText {#text} at (0,0) size 316x19
+ text run at (0,0) width 316: "This sentence should be underlined and overlined."
+ RenderBlock {P} at (0,204) size 784x18 [color=#80]
+RenderText {#text} at (0,0) size 377x19
+ text run at (0,0) width 377: "This sentence should be underlined, overlined, and stricken."
+ RenderBlock {DIV} at (0,238) size 784x0 [color=#FF]
+ RenderBlock {P} at (0,238) size 784x18 [color=#80]
+RenderText {#text} at (0,0) size 285x19
+ text run at (0,0) width 285: "There should be no red at the end of this line."
+RenderImage {IMG} at (285,0) size 15x15 [color=#FF]
+RenderText {#text} at (300,0) size 4x19
+ text run at (300,0) width 4: " "
+ RenderBlock {P} at (0,272) size 784x38 [color=#80]
+RenderText {#text} at (0,2) size 199x19
+ text run at (0,2) width 199: "The text of this sentence and all"
+RenderInline {SPAN} at (0,0) size 4x19
+ RenderText {#text} at (199,2) size 4x19
+text run at (199,2) width 4: " "
+RenderText {#text} at (203,2) size 14x19
+ text run at (203,2) width 14: "its"
+RenderInline {SPAN} at (0,0) size 4x19
+ RenderText {#text} at (217,2) size 4x19
+text run at (217,2) width 4: " "
+RenderText {#text} at (221,2) size 308x19
+ text run at (221,2) width 308: "spaces (including the space between the images) "
+RenderImage {IMG} at (529,0) size 17x17 [color=#FF]
+RenderText {#text} at (546,2) size 4x19
+ text run at (546,2) width 4: " "
+RenderImage {IMG} at (550,0) size 17x17 [color=#FF]
+RenderText {#text} at (567,2) size 754x37
+ text run at (567,2) width 4: " "
+ text run at (571,2) width 183: "should be underlined, but the"
+ text run at (0,20) width 167: "images themselves should "
+RenderInline {EM} at (0,0) size 20x19
+ RenderText {#text} at (167,20) size 20x19
+text run at (167,20) width 20: "not"
+RenderText {#text} at (187,20) size 94x19
+ text run at (187,20) width 94: " be
[webkit-changes] [113407] trunk/Source/WebCore
Title: [113407] trunk/Source/WebCore Revision 113407 Author commit-qu...@webkit.org Date 2012-04-05 20:04:45 -0700 (Thu, 05 Apr 2012) Log Message Remove intrinsic padding from contentBoxRect(), etc. https://bugs.webkit.org/show_bug.cgi?id=83092 Patch by David Barton on 2012-04-05 Reviewed by Julien Chaffraix. "Intrinsic padding" does not count as CSS padding, but is treated as padding by basic layout and rendering code, e.g. RenderBlock::layout(). A lot of code relies on the equation border-box = content-box + padding + border (+ scrollbars). To keep this valid, change 5 functions in RenderBox.h to not include intrinsic padding in the content box, thus reverting to their behavior before the patch for bug 33593. Instead, have sizingBox(renderer) in CSSComputedStyleDeclaration.cpp explicitly put the intrinsic padding in computed CSS content-box values [for _javascript_ getComputedStyle()], so the above equation still also holds for CSS computed values. This seems more consistent with how the padding...() functions behave since the patch for bug 23487, and will work better for MathML. For instance, a block's contentLogicalWidth() will be the availableLogicalWidth() for use by child elements. No new tests. The only real observable changes are illustrated in the bug 83092 attached test case and discussion. These are minor and hard to automate. * css/CSSComputedStyleDeclaration.cpp: (WebCore::sizingBox): * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode): * rendering/RenderBox.h: (WebCore::RenderBox::contentBoxRect): (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::contentLogicalWidth): (WebCore::RenderBox::contentLogicalHeight): - Change these 5 functions to omit intrinsic padding from the content box. * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::cellBaselinePosition): * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::firstLineBoxBaseline): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderTableCell.cpp trunk/Source/WebCore/rendering/RenderTableSection.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (113406 => 113407) --- trunk/Source/WebCore/ChangeLog 2012-04-06 02:51:07 UTC (rev 113406) +++ trunk/Source/WebCore/ChangeLog 2012-04-06 03:04:45 UTC (rev 113407) @@ -1,3 +1,41 @@ +2012-04-05 David Barton + +Remove intrinsic padding from contentBoxRect(), etc. +https://bugs.webkit.org/show_bug.cgi?id=83092 + +Reviewed by Julien Chaffraix. + +"Intrinsic padding" does not count as CSS padding, but is treated as padding by basic +layout and rendering code, e.g. RenderBlock::layout(). A lot of code relies on the +equation border-box = content-box + padding + border (+ scrollbars). To keep this valid, +change 5 functions in RenderBox.h to not include intrinsic padding in the content box, +thus reverting to their behavior before the patch for bug 33593. Instead, have +sizingBox(renderer) in CSSComputedStyleDeclaration.cpp explicitly put the intrinsic +padding in computed CSS content-box values [for _javascript_ getComputedStyle()], so the +above equation still also holds for CSS computed values. This seems more consistent with +how the padding...() functions behave since the patch for bug 23487, and will work +better for MathML. For instance, a block's contentLogicalWidth() will be the +availableLogicalWidth() for use by child elements. + +No new tests. The only real observable changes are illustrated in the bug 83092 attached +test case and discussion. These are minor and hard to automate. + +* css/CSSComputedStyleDeclaration.cpp: +(WebCore::sizingBox): +* editing/DeleteSelectionCommand.cpp: +(WebCore::DeleteSelectionCommand::removeNode): +* rendering/RenderBox.h: +(WebCore::RenderBox::contentBoxRect): +(WebCore::RenderBox::contentWidth): +(WebCore::RenderBox::contentHeight): +(WebCore::RenderBox::contentLogicalWidth): +(WebCore::RenderBox::contentLogicalHeight): +- Change these 5 functions to omit intrinsic padding from the content box. +* rendering/RenderTableCell.cpp: +(WebCore::RenderTableCell::cellBaselinePosition): +* rendering/RenderTableSection.cpp: +(WebCore::RenderTableSection::firstLineBoxBaseline): + 2012-04-05 Hironori Bono [Chromium] moving a cursor on a misspelled word should not remove a misspelled underline Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (113406 => 113407) --- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2012-04-06 02:51:07 UTC (rev 113406) +++ trunk/Source/WebCore/css
[webkit-changes] [113406] trunk
Title: [113406] trunk
Revision 113406
Author commit-qu...@webkit.org
Date 2012-04-05 19:51:07 -0700 (Thu, 05 Apr 2012)
Log Message
[BlackBerry] Empty Referrer should not be set into ResourceRequest when loading a main resource.
https://bugs.webkit.org/show_bug.cgi?id=83252
Patch by Jason Liu on 2012-04-05
Reviewed by George Staikos.
Test: http/tests/misc/resources/referrer-main-resource.php
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
Modified Paths
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog
Added Paths
trunk/LayoutTests/http/tests/misc/resources/referrer-main-resource-expected.txt
trunk/LayoutTests/http/tests/misc/resources/referrer-main-resource.php
Diff
Added: trunk/LayoutTests/http/tests/misc/resources/referrer-main-resource-expected.txt (0 => 113406)
--- trunk/LayoutTests/http/tests/misc/resources/referrer-main-resource-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/misc/resources/referrer-main-resource-expected.txt 2012-04-06 02:51:07 UTC (rev 113406)
@@ -0,0 +1 @@
+PASS: The server didn't receive a referrer.
Added: trunk/LayoutTests/http/tests/misc/resources/referrer-main-resource.php (0 => 113406)
--- trunk/LayoutTests/http/tests/misc/resources/referrer-main-resource.php (rev 0)
+++ trunk/LayoutTests/http/tests/misc/resources/referrer-main-resource.php 2012-04-06 02:51:07 UTC (rev 113406)
@@ -0,0 +1,20 @@
+
+
+
+function runTest() {
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+;
+
+}
+
+
+
+
+
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (113405 => 113406)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-04-06 02:48:37 UTC (rev 113405)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-04-06 02:51:07 UTC (rev 113406)
@@ -534,7 +534,7 @@
if (isInitial)
NetworkManager::instance()->setInitialURL(kurl);
-ResourceRequest request(kurl, "" /* referrer */);
+ResourceRequest request(kurl);
request.setToken(networkToken);
if (isInitial || mustHandleInternally)
request.setMustHandleInternally(true);
Modified: trunk/Source/WebKit/blackberry/ChangeLog (113405 => 113406)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-04-06 02:48:37 UTC (rev 113405)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-04-06 02:51:07 UTC (rev 113406)
@@ -1,3 +1,15 @@
+2012-04-05 Jason Liu
+
+[BlackBerry] Empty Referrer should not be set into ResourceRequest when loading a main resource.
+https://bugs.webkit.org/show_bug.cgi?id=83252
+
+Reviewed by George Staikos.
+
+Test: http/tests/misc/resources/referrer-main-resource.php
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::load):
+
2012-04-05 George Staikos
Add a vibration client for BlackBerry and enable it.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [113405] trunk
Title: [113405] trunk
Revision 113405
Author hb...@chromium.org
Date 2012-04-05 19:48:37 -0700 (Thu, 05 Apr 2012)
Log Message
[Chromium] moving a cursor on a misspelled word should not remove a misspelled underline
https://bugs.webkit.org/show_bug.cgi?id=83214
Reviewed by Ryosuke Niwa.
When Chrome enables asynchronous spellchecking, it adds Spelling markers in the
background. For this case, moving a cursor should not remove these markers
because it requires Chrome to spellcheck text again. This change prevents
removing Spelling markers added by spellcheckers asynchronously.
Source/WebCore:
Test: platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):
Source/WebKit/chromium:
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): use marker descriptions instead of spellchecking text when Chrome enables asynchronous spellchecking.
LayoutTests:
* platform/chromium/editing/spelling/move-cursor-to-misspelled-word-expected.txt: Added.
* platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
Added Paths
trunk/LayoutTests/platform/chromium/editing/spelling/move-cursor-to-misspelled-word-expected.txt
trunk/LayoutTests/platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html
Diff
Modified: trunk/LayoutTests/ChangeLog (113404 => 113405)
--- trunk/LayoutTests/ChangeLog 2012-04-06 02:27:31 UTC (rev 113404)
+++ trunk/LayoutTests/ChangeLog 2012-04-06 02:48:37 UTC (rev 113405)
@@ -1,3 +1,18 @@
+2012-04-05 Hironori Bono
+
+[Chromium] moving a cursor on a misspelled word should not remove a misspelled underline
+https://bugs.webkit.org/show_bug.cgi?id=83214
+
+Reviewed by Ryosuke Niwa.
+
+When Chrome enables asynchronous spellchecking, it adds Spelling markers in the
+background. For this case, moving a cursor should not remove these markers
+because it requires Chrome to spellcheck text again. This change prevents
+removing Spelling markers added by spellcheckers asynchronously.
+
+* platform/chromium/editing/spelling/move-cursor-to-misspelled-word-expected.txt: Added.
+* platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html: Added.
+
2012-04-05 Martin Robinson
Unskip a test that should now be passing after r113004
Added: trunk/LayoutTests/platform/chromium/editing/spelling/move-cursor-to-misspelled-word-expected.txt (0 => 113405)
--- trunk/LayoutTests/platform/chromium/editing/spelling/move-cursor-to-misspelled-word-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/editing/spelling/move-cursor-to-misspelled-word-expected.txt 2012-04-06 02:48:37 UTC (rev 113405)
@@ -0,0 +1,12 @@
+Test if Chrome WebKit does not remove a misspelled marker when moving a cursor on a misspelled word.To test manually, type a misspelled word "zz " and type a left-arrow key to move the cursor on it.This test succeeds when "zz" is marked as misspelled.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS internals.hasSpellingMarker(document, 0, 2) is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+zz
+
+
Added: trunk/LayoutTests/platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html (0 => 113405)
--- trunk/LayoutTests/platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html (rev 0)
+++ trunk/LayoutTests/platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html 2012-04-06 02:48:37 UTC (rev 113405)
@@ -0,0 +1,25 @@
+
+
+
+Testing moving cursor to a misspelled word
+
+
+
+
+description('Test if Chrome WebKit does not remove a misspelled marker when moving a cursor on a misspelled word.' +
+'To test manually, type a misspelled word "zz " and type a left-arrow key to move the cursor on it.' +
+'This test succeeds when "zz" is marked as misspelled.');
+
+layoutTestController.setAsynchronousSpellCheckingEnabled(true);
+var node = document.getElementById('src');
+node.focus();
+document.execCommand("InsertText", false, 'z');
+document.execCommand("InsertText", false, 'z');
+document.execCommand("InsertText", false, ' ');
+window.getSelection().modify('move', 'backward', 'character');
+shouldBeTrue('internals.hasSpellingMarker(document, 0, 2)');
+layoutTestController.setAsynchronousSpellCheckingEnabled(false);
+
+
[webkit-changes] [113404] trunk
Title: [113404] trunk
Revision 113404
Author stai...@webkit.org
Date 2012-04-05 19:27:31 -0700 (Thu, 05 Apr 2012)
Log Message
.: Compile the vibration module for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83340
Reviewed by Rob Buis.
* Source/cmake/OptionsBlackBerry.cmake:
Source/WebKit: Add the vibration client for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83340
Reviewed by Rob Buis.
* PlatformBlackBerry.cmake:
Source/WebKit/blackberry: Add a vibration client for BlackBerry and enable it.
https://bugs.webkit.org/show_bug.cgi?id=83340
Reviewed by Rob Buis.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init): enable the client
* WebCoreSupport/VibrationClientBlackBerry.cpp: Added.
(WebCore):
(WebCore::VibrationClientBlackBerry::VibrationClientBlackBerry):
(WebCore::VibrationClientBlackBerry::vibrate):
(WebCore::VibrationClientBlackBerry::cancelVibration):
(WebCore::VibrationClientBlackBerry::vibrationDestroyed):
* WebCoreSupport/VibrationClientBlackBerry.h: Added.
(WebCore):
(VibrationClientBlackBerry):
(WebCore::VibrationClientBlackBerry::~VibrationClientBlackBerry):
Modified Paths
trunk/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformBlackBerry.cmake
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/cmake/OptionsBlackBerry.cmake
Added Paths
trunk/Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.h
Diff
Modified: trunk/ChangeLog (113403 => 113404)
--- trunk/ChangeLog 2012-04-06 01:29:16 UTC (rev 113403)
+++ trunk/ChangeLog 2012-04-06 02:27:31 UTC (rev 113404)
@@ -1,3 +1,12 @@
+2012-04-05 George Staikos
+
+Compile the vibration module for BlackBerry.
+https://bugs.webkit.org/show_bug.cgi?id=83340
+
+Reviewed by Rob Buis.
+
+* Source/cmake/OptionsBlackBerry.cmake:
+
2012-04-05 Ryosuke Niwa
perf-o-matic should include unit in runs JSON responses
Modified: trunk/Source/WebKit/ChangeLog (113403 => 113404)
--- trunk/Source/WebKit/ChangeLog 2012-04-06 01:29:16 UTC (rev 113403)
+++ trunk/Source/WebKit/ChangeLog 2012-04-06 02:27:31 UTC (rev 113404)
@@ -1,3 +1,12 @@
+2012-04-05 George Staikos
+
+Add the vibration client for BlackBerry.
+https://bugs.webkit.org/show_bug.cgi?id=83340
+
+Reviewed by Rob Buis.
+
+* PlatformBlackBerry.cmake:
+
2012-04-05 Jia Pu
Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
Modified: trunk/Source/WebKit/PlatformBlackBerry.cmake (113403 => 113404)
--- trunk/Source/WebKit/PlatformBlackBerry.cmake 2012-04-06 01:29:16 UTC (rev 113403)
+++ trunk/Source/WebKit/PlatformBlackBerry.cmake 2012-04-06 02:27:31 UTC (rev 113404)
@@ -17,6 +17,7 @@
"${WEBCORE_DIR}/platform/graphics/skia"
"${WEBCORE_DIR}/platform/network/blackberry"
"${WEBCORE_DIR}/websockets"
+"${WEBCORE_DIR}/Modules/vibration"
"${WEBKIT_DIR}/blackberry/Api"
"${WEBKIT_DIR}/blackberry/WebCoreSupport"
"${WEBKIT_DIR}/blackberry/WebKitSupport"
@@ -65,6 +66,7 @@
blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp
blackberry/WebCoreSupport/_javascript_DebuggerBlackBerry.cpp
blackberry/WebCoreSupport/NotificationPresenterImpl.cpp
+blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp
blackberry/WebKitSupport/BackingStoreCompositingSurface.cpp
blackberry/WebKitSupport/BackingStoreTile.cpp
blackberry/WebKitSupport/BackingStoreClient.cpp
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (113403 => 113404)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-04-06 01:29:16 UTC (rev 113403)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-04-06 02:27:31 UTC (rev 113404)
@@ -102,6 +102,9 @@
#include "ThreadCheck.h"
#include "TouchEventHandler.h"
#include "TransformationMatrix.h"
+#if ENABLE(VIBRATION)
+#include "VibrationClientBlackBerry.h"
+#endif
#include "VisiblePosition.h"
#if ENABLE(WEBDOM)
#include "WebDOMDocument.h"
@@ -443,6 +446,9 @@
#endif
WebCore::provideDeviceOrientationTo(m_page, new DeviceOrientationClientBlackBerry(this));
WebCore::provideDeviceMotionTo(m_page, new DeviceMotionClientBlackBerry(this));
+#if ENABLE(VIBRATION)
+WebCore::provideVibrationTo(m_page, new VibrationClientBlackBerry());
+#endif
#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
WebCore::provideNotification(m_page, NotificationPresenterImpl::instance());
Modified: trunk/Source/WebKit/blackberry/ChangeLog (113403 => 113404)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-04-06 01:29:16 UTC (rev 113403)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-04-06 02:27:31 UTC (rev 113404)
@@ -1,3 +1,23 @@
+2012-04-05 George Staikos
+
+Add a vibration client for BlackBerry and enable it.
+https://bugs.webkit.org/show_bug.cgi?id=83340
+
+
[webkit-changes] [113403] branches/subpixellayout/Source/WebCore
Title: [113403] branches/subpixellayout/Source/WebCore
Revision 113403
Author e...@chromium.org
Date 2012-04-05 18:29:16 -0700 (Thu, 05 Apr 2012)
Log Message
Removed abs(LayoutUnit) on branch as it confused the chromium linux and gtk builds.
Modified Paths
branches/subpixellayout/Source/WebCore/editing/Editor.cpp
branches/subpixellayout/Source/WebCore/page/SpatialNavigation.cpp
branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h
branches/subpixellayout/Source/WebCore/rendering/RenderBlockLineLayout.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderLineBoxList.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderObject.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/editing/Editor.cpp (113402 => 113403)
--- branches/subpixellayout/Source/WebCore/editing/Editor.cpp 2012-04-06 01:25:17 UTC (rev 113402)
+++ branches/subpixellayout/Source/WebCore/editing/Editor.cpp 2012-04-06 01:29:16 UTC (rev 113403)
@@ -2556,12 +2556,12 @@
ASSERT(range->startContainer());
ASSERT(range->endContainer());
-LayoutRect startCaretRect = RenderedPosition(VisiblePosition(range->startPosition()).deepEquivalent(), DOWNSTREAM).absoluteRect(extraWidthToEndOfLine);
-if (startCaretRect == LayoutRect())
+IntRect startCaretRect = pixelSnappedIntRect(RenderedPosition(VisiblePosition(range->startPosition()).deepEquivalent(), DOWNSTREAM).absoluteRect(extraWidthToEndOfLine));
+if (startCaretRect == IntRect())
return IntRect();
-LayoutRect endCaretRect = RenderedPosition(VisiblePosition(range->endPosition()).deepEquivalent(), UPSTREAM).absoluteRect();
-if (endCaretRect == LayoutRect())
+IntRect endCaretRect = pixelSnappedIntRect(RenderedPosition(VisiblePosition(range->endPosition()).deepEquivalent(), UPSTREAM).absoluteRect());
+if (endCaretRect == IntRect())
return IntRect();
if (startCaretRect.y() == endCaretRect.y()) {
Modified: branches/subpixellayout/Source/WebCore/page/SpatialNavigation.cpp (113402 => 113403)
--- branches/subpixellayout/Source/WebCore/page/SpatialNavigation.cpp 2012-04-06 01:25:17 UTC (rev 113402)
+++ branches/subpixellayout/Source/WebCore/page/SpatialNavigation.cpp 2012-04-06 01:29:16 UTC (rev 113403)
@@ -645,19 +645,19 @@
switch (direction) {
case FocusDirectionLeft:
sameAxisDistance = exitPoint.x() - entryPoint.x();
-otherAxisDistance = abs(exitPoint.y() - entryPoint.y());
+otherAxisDistance = (exitPoint.y() - entryPoint.y()).abs();
break;
case FocusDirectionUp:
sameAxisDistance = exitPoint.y() - entryPoint.y();
-otherAxisDistance = abs(exitPoint.x() - entryPoint.x());
+otherAxisDistance = (exitPoint.x() - entryPoint.x()).abs();
break;
case FocusDirectionRight:
sameAxisDistance = entryPoint.x() - exitPoint.x();
-otherAxisDistance = abs(entryPoint.y() - exitPoint.y());
+otherAxisDistance = (entryPoint.y() - exitPoint.y()).abs();
break;
case FocusDirectionDown:
sameAxisDistance = entryPoint.y() - exitPoint.y();
-otherAxisDistance = abs(entryPoint.x() - exitPoint.x());
+otherAxisDistance = (entryPoint.x() - exitPoint.x()).abs();
break;
default:
ASSERT_NOT_REACHED();
Modified: branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h (113402 => 113403)
--- branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h 2012-04-06 01:25:17 UTC (rev 113402)
+++ branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h 2012-04-06 01:29:16 UTC (rev 113403)
@@ -532,11 +532,6 @@
return (location + size).round() - location.round();
}
-inline FractionalLayoutUnit abs(const FractionalLayoutUnit& a)
-{
-return a.abs();
-}
-
} // namespace WebCore
namespace std {
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBlockLineLayout.cpp (113402 => 113403)
--- branches/subpixellayout/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2012-04-06 01:25:17 UTC (rev 113402)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2012-04-06 01:29:16 UTC (rev 113403)
@@ -1757,7 +1757,7 @@
while (RootInlineBox* nextLine = lastLine->nextRootBox())
lastLine = nextLine;
-LayoutUnit logicalBottom = lastLine->lineBottomWithLeading() + abs(lineDelta);
+LayoutUnit logicalBottom = lastLine->lineBottomWithLeading() + lineDelta.abs();
const FloatingObjectSet& floatingObjectSet = m_floatingObjects->set();
FloatingObjectSetIterator end = floatingObjectSet.end();
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderLineBoxList.cpp (113402 => 113403)
--- branches/subpixellayout/Source/WebCore/rendering/RenderLineBoxList.cpp 2012-04-06 01:25:17 UTC (rev 113402)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderLineBoxList.cpp 2012-04-06 01:29:16 UTC (rev 113403)
@@ -155,7 +155,7 @@
block = renderer->
[webkit-changes] [113402] trunk/LayoutTests
Title: [113402] trunk/LayoutTests Revision 113402 Author mrobin...@webkit.org Date 2012-04-05 18:25:17 -0700 (Thu, 05 Apr 2012) Log Message Unskip a test that should now be passing after r113004 * platform/gtk/Skipped: Unskip a test that should now be passing. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (113401 => 113402) --- trunk/LayoutTests/ChangeLog 2012-04-06 01:22:48 UTC (rev 113401) +++ trunk/LayoutTests/ChangeLog 2012-04-06 01:25:17 UTC (rev 113402) @@ -1,5 +1,11 @@ 2012-04-05 Martin Robinson +Unskip a test that should now be passing after r113004 + +* platform/gtk/Skipped: Unskip a test that should now be passing. + +2012-04-05 Martin Robinson + Unskip some tests on GTK+ that should now be passing. * platform/gtk/Skipped: Modified: trunk/LayoutTests/platform/gtk/Skipped (113401 => 113402) --- trunk/LayoutTests/platform/gtk/Skipped 2012-04-06 01:22:48 UTC (rev 113401) +++ trunk/LayoutTests/platform/gtk/Skipped 2012-04-06 01:25:17 UTC (rev 113402) @@ -1653,9 +1653,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=82886 inspector/styles/override-screen-size.html -# https://bugs.webkit.org/show_bug.cgi?id=83006 -fast/events/drop-handler-should-not-stop-navigate.html - # https://bugs.webkit.org/show_bug.cgi?id=72434 inspector/styles/svg-style.xhtml ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [113401] trunk/LayoutTests
Title: [113401] trunk/LayoutTests Revision 113401 Author mrobin...@webkit.org Date 2012-04-05 18:22:48 -0700 (Thu, 05 Apr 2012) Log Message Unskip some tests on GTK+ that should now be passing. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (113400 => 113401) --- trunk/LayoutTests/ChangeLog 2012-04-06 01:18:10 UTC (rev 113400) +++ trunk/LayoutTests/ChangeLog 2012-04-06 01:22:48 UTC (rev 113401) @@ -1,3 +1,9 @@ +2012-04-05 Martin Robinson + +Unskip some tests on GTK+ that should now be passing. + +* platform/gtk/Skipped: + 2012-04-05 Hans Muller CSS Exclusions polygon shape arguments should be comma separated Modified: trunk/LayoutTests/platform/gtk/Skipped (113400 => 113401) --- trunk/LayoutTests/platform/gtk/Skipped 2012-04-06 01:18:10 UTC (rev 113400) +++ trunk/LayoutTests/platform/gtk/Skipped 2012-04-06 01:22:48 UTC (rev 113401) @@ -1428,11 +1428,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=71465 http/tests/security/xssAuditor/script-tag-with-callbacks.html -# ASSERT(!needsLayout()) in frame flattening test -# https://bugs.webkit.org/show_bug.cgi?id=80155 -fast/frames/flattening/iframe-flattening-nested.html -fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html - # https://bugs.webkit.org/show_bug.cgi?id=72248 editing/spelling/spelling-unified-emulation.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [113400] trunk
Title: [113400] trunk
Revision 113400
Author commit-qu...@webkit.org
Date 2012-04-05 18:18:10 -0700 (Thu, 05 Apr 2012)
Log Message
CSS Exclusions polygon shape arguments should be comma separated
https://bugs.webkit.org/show_bug.cgi?id=82368
Patch by Hans Muller on 2012-04-05
Reviewed by Ryosuke Niwa.
Source/WebCore:
Changed the CSS Parser to accept a conventional comma separated argument list for the
polygon exclusion shape. The syntax had used spaces to separate x,y coordinates, like:
polygon(10px,20px 30px,40px). Now commas separate points: polygon(10px 20px, 30px 40px).
This change is per the draft exclusions spec, http://dev.w3.org/csswg/css3-exclusions.
Additional relevant information about CSS argument list syntax can be found
here: http://dev.w3.org/csswg/css3-values/#component-whitespace.
Factored comma recognition idiom in CSSParser.cpp into isComma() utility function.
The existing tests have been updated.
* css/CSSParser.cpp:
(WebCore::isComma)
(WebCore::CSSParser::parseFillPosition)
(WebCore::CSSParser::parseFillRepeat)
(WebCore::CSSParser::parseFillProperty)
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue)
(WebCore::CSSParser::parseAnimationTimingFunction)
(WebCore::CSSParser::parseAnimationProperty)
(WebCore::CSSParser::parseExclusionShapePolygon)
(WebCore::CSSParser::parseDeprecatedGradient)
(WebCore::CSSParser::parseRadialGradient)
(WebCore::CSSParser::parseGradientColorStops)
(WebCore::CSSParser::parseImageSet)
(WebCore::filterInfoForName)
(WebCore::CSSParser::parseCustomFilter)
(WebCore::CSSParser::parseFontFeatureSettings)
* css/CSSWrapShapes.cpp:
(WebCore::CSSWrapShapePolygon::cssText):
LayoutTests:
Updated the tests to match the polygon syntax defined by the draft exclusions
spec - http://dev.w3.org/csswg/css3-exclusions.
* fast/exclusions/parsing-wrap-shape-inside-expected.txt:
* fast/exclusions/parsing-wrap-shape-outside-expected.txt:
* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
* fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/exclusions/parsing-wrap-shape-inside-expected.txt
trunk/LayoutTests/fast/exclusions/parsing-wrap-shape-outside-expected.txt
trunk/LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-inside.js
trunk/LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-outside.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSWrapShapes.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (113399 => 113400)
--- trunk/LayoutTests/ChangeLog 2012-04-06 01:14:05 UTC (rev 113399)
+++ trunk/LayoutTests/ChangeLog 2012-04-06 01:18:10 UTC (rev 113400)
@@ -1,3 +1,18 @@
+2012-04-05 Hans Muller
+
+CSS Exclusions polygon shape arguments should be comma separated
+https://bugs.webkit.org/show_bug.cgi?id=82368
+
+Reviewed by Ryosuke Niwa.
+
+Updated the tests to match the polygon syntax defined by the draft exclusions
+spec - http://dev.w3.org/csswg/css3-exclusions.
+
+* fast/exclusions/parsing-wrap-shape-inside-expected.txt:
+* fast/exclusions/parsing-wrap-shape-outside-expected.txt:
+* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
+* fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
+
2012-04-05 Ami Fischman
http/tests/media/media-can-load-when-hidden.html doesn't need to be an HTTP test, and is racy
Modified: trunk/LayoutTests/fast/exclusions/parsing-wrap-shape-inside-expected.txt (113399 => 113400)
--- trunk/LayoutTests/fast/exclusions/parsing-wrap-shape-inside-expected.txt 2012-04-06 01:14:05 UTC (rev 113399)
+++ trunk/LayoutTests/fast/exclusions/parsing-wrap-shape-inside-expected.txt 2012-04-06 01:18:10 UTC (rev 113400)
@@ -15,12 +15,12 @@
PASS testComputedStyle("circle(10px, 20px, 30px)") is "circle(10px, 20px, 30px)"
PASS testCSSText("ellipse(10px, 20px, 30px, 40px)") is "ellipse(10px, 20px, 30px, 40px)"
PASS testComputedStyle("ellipse(10px, 20px, 30px, 40px)") is "ellipse(10px, 20px, 30px, 40px)"
-PASS testCSSText("polygon(10px, 20px 30px, 40px 40px, 50px)") is "polygon(nonzero, 10px, 20px 30px, 40px 40px, 50px)"
-PASS testComputedStyle("polygon(10px, 20px 30px, 40px 40px, 50px)") is "polygon(nonzero, 10px, 20px 30px, 40px 40px, 50px)"
-PASS testCSSText("polygon(evenodd, 10px, 20px 30px, 40px 40px, 50px)") is "polygon(evenodd, 10px, 20px 30px, 40px 40px, 50px)"
-PASS testComputedStyle("polygon(evenodd, 10px, 20px 30px, 40px 40px, 50px)") is "polygon(evenodd, 10px, 20px 30px, 40px 40px, 50px)"
-PASS testCSSText("polygon(nonzero, 10px, 20px 30px, 40px 40px, 50px)") is "polygon(nonzero, 10px, 20px 30px, 40px 40px, 50px)"
-PASS testComputedStyle("polygon(nonzero, 10px, 20px 30px, 40px 40px, 50px)") is "polygon(nonzero, 10px, 20px 30px, 40px 40px, 50px)"
+PASS testCSSText("polygon(10px 20px, 30px 40px, 40px 50px)") is "polygon(nonzero, 10px 20px, 30px 40px, 40px 50px)"
+PASS testComp
[webkit-changes] [113399] trunk/Tools
Title: [113399] trunk/Tools
Revision 113399
Author dpra...@chromium.org
Date 2012-04-05 18:14:05 -0700 (Thu, 05 Apr 2012)
Log Message
nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230
Reviewed by Ojan Vafai.
This should fix things properly; FileUploader() was setting the
socket default timeout value, and apparently that doesn't work
properly with urllib. Also, the class had a bad try/finally
block that was causing the exceptions to be swallowed :(.
* Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.__init__):
(FileUploader._upload_data.callback):
(FileUploader):
(FileUploader._upload_data):
* Scripts/webkitpy/common/net/networktransaction.py:
(NetworkTimeout.__str__):
(NetworkTransaction.run):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase.upload_json_files):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/file_uploader.py
trunk/Tools/Scripts/webkitpy/common/net/networktransaction.py
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py
Diff
Modified: trunk/Tools/ChangeLog (113398 => 113399)
--- trunk/Tools/ChangeLog 2012-04-06 01:06:57 UTC (rev 113398)
+++ trunk/Tools/ChangeLog 2012-04-06 01:14:05 UTC (rev 113399)
@@ -1,3 +1,26 @@
+2012-04-05 Dirk Pranke
+
+nrwt is failing to upload test results on the chromium-mac-leopard bots
+https://bugs.webkit.org/show_bug.cgi?id=83230
+
+Reviewed by Ojan Vafai.
+
+This should fix things properly; FileUploader() was setting the
+socket default timeout value, and apparently that doesn't work
+properly with urllib. Also, the class had a bad try/finally
+block that was causing the exceptions to be swallowed :(.
+
+* Scripts/webkitpy/common/net/file_uploader.py:
+(FileUploader.__init__):
+(FileUploader._upload_data.callback):
+(FileUploader):
+(FileUploader._upload_data):
+* Scripts/webkitpy/common/net/networktransaction.py:
+(NetworkTimeout.__str__):
+(NetworkTransaction.run):
+* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
+(JSONResultsGeneratorBase.upload_json_files):
+
2012-04-05 Patrick Gansterer
[Qt] Correct include paths.
Modified: trunk/Tools/Scripts/webkitpy/common/net/file_uploader.py (113398 => 113399)
--- trunk/Tools/Scripts/webkitpy/common/net/file_uploader.py 2012-04-06 01:06:57 UTC (rev 113398)
+++ trunk/Tools/Scripts/webkitpy/common/net/file_uploader.py 2012-04-06 01:14:05 UTC (rev 113399)
@@ -28,17 +28,13 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
import codecs
-import logging
import mimetypes
-import socket
+import time
import urllib2
-from webkitpy.common.net.networktransaction import NetworkTransaction
+from webkitpy.common.net.networktransaction import NetworkTransaction, NetworkTimeout
-_log = logging.getLogger(__name__)
-
-
def get_mime_type(filename):
return mimetypes.guess_type(filename)[0] or 'application/octet-stream'
@@ -86,10 +82,10 @@
class FileUploader(object):
-def __init__(self, url, timeout_seconds, debug=False):
+def __init__(self, url, timeout_seconds):
self._url = url
self._timeout_seconds = timeout_seconds
-self._debug = debug
+self._deadline = time.time() + self._timeout_seconds
def upload_single_text_file(self, filesystem, content_type, filename):
return self._upload_data(content_type, filesystem.read_text_file(filename))
@@ -107,19 +103,11 @@
def _upload_data(self, content_type, data):
def callback():
-if self._debug:
-_log.debug("uploading %d bytes to '%s', content-type '%s'" % (len(data), self._url, content_type))
+now = time.time()
+if now > self._deadline:
+# This shouldn't happen, but just to be safe ...
+raise NetworkTimeout()
request = urllib2.Request(self._url, data, {"Content-Type": content_type})
-return urllib2.urlopen(request)
+return urllib2.urlopen(request, timeout=(self._deadline - now))
-orig_timeout = socket.getdefaulttimeout()
-response = None
-try:
-# FIXME: We shouldn't mutate global static state.
-# FIXME: clean this up once we understand what's going on on chromium leopard bots.
-if not self._debug:
-socket.setdefaulttimeout(self._timeout_seconds)
-return NetworkTransaction(timeout_seconds=self._timeout_seconds).run(callback)
-finally:
-if not self._debug:
-socket.setdefaulttimeout(orig_timeout)
+return NetworkTransaction(timeout_seconds=self._timeout_seconds).run(callback)
Modified: trunk/Tools/Scripts/webkitpy/common/net/networktransaction
[webkit-changes] [113398] trunk/Source/WebKit2
Title: [113398] trunk/Source/WebKit2
Revision 113398
Author ander...@apple.com
Date 2012-04-05 18:06:57 -0700 (Thu, 05 Apr 2012)
Log Message
Crash when switching to a tab with plug-ins
https://bugs.webkit.org/show_bug.cgi?id=83339
Reviewed by Oliver Hunt.
Add an additional check so we don't try to call into plug-ins that haven't yet been initialized.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setLayerHostingMode):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (113397 => 113398)
--- trunk/Source/WebKit2/ChangeLog 2012-04-06 00:56:04 UTC (rev 113397)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-06 01:06:57 UTC (rev 113398)
@@ -1,3 +1,16 @@
+2012-04-05 Anders Carlsson
+
+Crash when switching to a tab with plug-ins
+https://bugs.webkit.org/show_bug.cgi?id=83339
+
+
+Reviewed by Oliver Hunt.
+
+Add an additional check so we don't try to call into plug-ins that haven't yet been initialized.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::setLayerHostingMode):
+
2012-04-05 Dean Jackson
[mac] requestAnimationFrame sometimes stuck when page loads in a background tab
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (113397 => 113398)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-04-06 00:56:04 UTC (rev 113397)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-04-06 01:06:57 UTC (rev 113398)
@@ -436,7 +436,7 @@
void PluginView::setLayerHostingMode(LayerHostingMode layerHostingMode)
{
-if (!m_plugin)
+if (!m_isInitialized || !m_plugin)
return;
m_plugin->setLayerHostingMode(layerHostingMode);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [113397] trunk/LayoutTests
Title: [113397] trunk/LayoutTests
Revision 113397
Author fisch...@chromium.org
Date 2012-04-05 17:56:04 -0700 (Thu, 05 Apr 2012)
Log Message
http/tests/media/media-can-load-when-hidden.html doesn't need to be an HTTP test, and is racy
https://bugs.webkit.org/show_bug.cgi?id=83296
Reviewed by Eric Carlson.
* media/media-can-load-when-hidden-expected.txt: Renamed from LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt.
* media/media-can-load-when-hidden.html: Renamed from LayoutTests/http/tests/media/media-can-load-when-hidden.html.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/efl/Skipped
Added Paths
trunk/LayoutTests/media/media-can-load-when-hidden-expected.txt
trunk/LayoutTests/media/media-can-load-when-hidden.html
Removed Paths
trunk/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt
trunk/LayoutTests/http/tests/media/media-can-load-when-hidden.html
Diff
Modified: trunk/LayoutTests/ChangeLog (113396 => 113397)
--- trunk/LayoutTests/ChangeLog 2012-04-06 00:12:25 UTC (rev 113396)
+++ trunk/LayoutTests/ChangeLog 2012-04-06 00:56:04 UTC (rev 113397)
@@ -1,3 +1,15 @@
+2012-04-05 Ami Fischman
+
+http/tests/media/media-can-load-when-hidden.html doesn't need to be an HTTP test, and is racy
+https://bugs.webkit.org/show_bug.cgi?id=83296
+
+Reviewed by Eric Carlson.
+
+* media/media-can-load-when-hidden-expected.txt: Renamed from LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt.
+* media/media-can-load-when-hidden.html: Renamed from LayoutTests/http/tests/media/media-can-load-when-hidden.html.
+* platform/chromium/test_expectations.txt:
+* platform/efl/Skipped:
+
2012-04-05 Joshua Bell
IndexedDB: Support string.length in keyPaths
Deleted: trunk/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt (113396 => 113397)
--- trunk/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt 2012-04-06 00:12:25 UTC (rev 113396)
+++ trunk/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt 2012-04-06 00:56:04 UTC (rev 113397)
@@ -1,5 +0,0 @@
-Test HTMLMediaElement to be sure that the video is getting loaded even if the element is hidden.
-
-EVENT(durationchange)
-END OF TEST
-
Deleted: trunk/LayoutTests/http/tests/media/media-can-load-when-hidden.html (113396 => 113397)
--- trunk/LayoutTests/http/tests/media/media-can-load-when-hidden.html 2012-04-06 00:12:25 UTC (rev 113396)
+++ trunk/LayoutTests/http/tests/media/media-can-load-when-hidden.html 2012-04-06 00:56:04 UTC (rev 113397)
@@ -1,27 +0,0 @@
-
-
-
-video {display:none; background-color: yellow; width: 320px; height: 240px;}
-
-
-function start()
-{
-video = document.getElementsByTagName('video')[0];
-var mediaFile = findMediaFile("video", "resources/test");
-video.src = "" + mediaFile;
-waitForEvent('durationchange', function() { endTest(); });
-}
-
-
-
-
-
-
-
-Test HTMLMediaElement to be sure that the video is getting loaded even if the element
-is hidden.
-
-
-
Copied: trunk/LayoutTests/media/media-can-load-when-hidden-expected.txt (from rev 113396, trunk/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt) (0 => 113397)
--- trunk/LayoutTests/media/media-can-load-when-hidden-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-can-load-when-hidden-expected.txt 2012-04-06 00:56:04 UTC (rev 113397)
@@ -0,0 +1,5 @@
+Test HTMLMediaElement to be sure that the video is getting loaded even if the element is hidden.
+
+EVENT(durationchange)
+END OF TEST
+
Copied: trunk/LayoutTests/media/media-can-load-when-hidden.html (from rev 113396, trunk/LayoutTests/http/tests/media/media-can-load-when-hidden.html) (0 => 113397)
--- trunk/LayoutTests/media/media-can-load-when-hidden.html (rev 0)
+++ trunk/LayoutTests/media/media-can-load-when-hidden.html 2012-04-06 00:56:04 UTC (rev 113397)
@@ -0,0 +1,24 @@
+
+
+
+video {display:none; background-color: yellow; width: 320px; height: 240px;}
+
+
+
+
+
+
+Test HTMLMediaElement to be sure that the video is getting loaded even if the element
+is hidden.
+
+function start()
+{
+video = document.getElementsByTagName('video')[0];
+waitForEvent('durationchange', function() { endTest(); });
+video.src = "" "content/test");
+}
+
+
+
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (113396 => 113397)
--- trunk/LayoutTests/platform/chromium/test_expectations.tx
[webkit-changes] [113396] trunk/Source/JavaScriptCore
Title: [113396] trunk/Source/_javascript_Core
Revision 113396
Author benja...@webkit.org
Date 2012-04-05 17:12:25 -0700 (Thu, 05 Apr 2012)
Log Message
Speed up the conversion from JSValue to String for bulk operations
https://bugs.webkit.org/show_bug.cgi?id=83243
Patch by Benjamin Poulain on 2012-04-05
Reviewed by Geoffrey Garen.
When making operations on primitive types, we loose some time converting
values to JSString in order to extract the string.
This patch speeds up some basic Array operations by avoiding the creation
of intermediary JSString when possible.
For the cases where we need to convert a lot of JSValue in a tight loop,
an inline conversion is used.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncSort):
* runtime/CommonIdentifiers.h:
* runtime/JSArray.cpp:
(JSC::JSArray::sort):
* runtime/JSString.h:
(JSC::JSValue::toUString):
(JSC):
(JSC::inlineJSValueNotStringtoUString):
(JSC::JSValue::toUStringInline):
* runtime/JSValue.cpp:
(JSC::JSValue::toUStringSlowCase):
(JSC):
* runtime/JSValue.h:
(JSValue):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
trunk/Source/_javascript_Core/runtime/CommonIdentifiers.h
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/_javascript_Core/runtime/JSString.h
trunk/Source/_javascript_Core/runtime/JSValue.cpp
trunk/Source/_javascript_Core/runtime/JSValue.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (113395 => 113396)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-05 23:54:06 UTC (rev 113395)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-06 00:12:25 UTC (rev 113396)
@@ -1,5 +1,41 @@
2012-04-05 Benjamin Poulain
+Speed up the conversion from JSValue to String for bulk operations
+https://bugs.webkit.org/show_bug.cgi?id=83243
+
+Reviewed by Geoffrey Garen.
+
+When making operations on primitive types, we loose some time converting
+values to JSString in order to extract the string.
+
+This patch speeds up some basic Array operations by avoiding the creation
+of intermediary JSString when possible.
+
+For the cases where we need to convert a lot of JSValue in a tight loop,
+an inline conversion is used.
+
+* runtime/ArrayPrototype.cpp:
+(JSC::arrayProtoFuncToString):
+(JSC::arrayProtoFuncToLocaleString):
+(JSC::arrayProtoFuncJoin):
+(JSC::arrayProtoFuncPush):
+(JSC::arrayProtoFuncSort):
+* runtime/CommonIdentifiers.h:
+* runtime/JSArray.cpp:
+(JSC::JSArray::sort):
+* runtime/JSString.h:
+(JSC::JSValue::toUString):
+(JSC):
+(JSC::inlineJSValueNotStringtoUString):
+(JSC::JSValue::toUStringInline):
+* runtime/JSValue.cpp:
+(JSC::JSValue::toUStringSlowCase):
+(JSC):
+* runtime/JSValue.h:
+(JSValue):
+
+2012-04-05 Benjamin Poulain
+
Use QuickSort when sorting primitive values by string representation
https://bugs.webkit.org/show_bug.cgi?id=83312
Modified: trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp (113395 => 113396)
--- trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp 2012-04-05 23:54:06 UTC (rev 113395)
+++ trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp 2012-04-06 00:12:25 UTC (rev 113396)
@@ -281,7 +281,7 @@
if (element.isUndefinedOrNull())
continue;
-UString str = element.toString(exec)->value(exec);
+UString str = element.toUString(exec);
strBuffer[k] = str.impl();
totalSize += str.length();
allStrings8Bit = allStrings8Bit && str.is8Bit();
@@ -358,9 +358,9 @@
CallData callData;
CallType callType = getCallData(conversionFunction, callData);
if (callType != CallTypeNone)
-str = call(exec, conversionFunction, callType, callData, element, exec->emptyList()).toString(exec)->value(exec);
+str = call(exec, conversionFunction, callType, callData, element, exec->emptyList()).toUString(exec);
else
-str = element.toString(exec)->value(exec);
+str = element.toUString(exec);
if (exec->hadException())
return JSValue::encode(jsUndefined());
stringJoiner.append(str);
@@ -383,7 +383,7 @@
UString separator;
if (!exec->argument(0).isUndefined())
-separator = exec->argument(0).toString(exec)->value(exec);
+separator = exec->argument(0).toUString(exec);
if (separator.isNull())
separator = UString(",");
@@ -399,7 +399,7 @@
JSValue element = array->getIndex(k);
if (!element.isUndefinedOrNull())
-stringJoiner.append(element.toString(exec)->value(exec))
[webkit-changes] [113395] trunk
Title: [113395] trunk
Revision 113395
Author jsb...@chromium.org
Date 2012-04-05 16:54:06 -0700 (Thu, 05 Apr 2012)
Log Message
IndexedDB: Support string.length in keyPaths
https://bugs.webkit.org/show_bug.cgi?id=83221
Source/WebCore:
Special case in the IDB spec - keyPaths can reference the |length| property
of string values. Other instrinsic properties (|length| of Array, etc) are
handled automagically. Relevant section of the updated spec is:
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-path-construct
Reviewed by Kentaro Hara.
Test: storage/indexeddb/keypath-intrinsic-properties.html
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore):
LayoutTests:
Reviewed by Kentaro Hara.
* storage/indexeddb/keypath-intrinsic-properties-expected.txt: Added.
* storage/indexeddb/keypath-intrinsic-properties.html: Added.
* storage/indexeddb/resources/keypath-intrinsic-properties.js: Added.
(test.request.onsuccess):
(test):
(openSuccess.request.onsuccess):
(openSuccess):
(testKeyPaths.checkStringLengths.request.onsuccess):
(testKeyPaths.checkStringLengths):
(testKeyPaths.checkArrayLengths.request.onsuccess):
(testKeyPaths.checkArrayLengths):
(testKeyPaths):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp
Added Paths
trunk/LayoutTests/storage/indexeddb/keypath-intrinsic-properties-expected.txt
trunk/LayoutTests/storage/indexeddb/keypath-intrinsic-properties.html
trunk/LayoutTests/storage/indexeddb/resources/keypath-intrinsic-properties.js
Diff
Modified: trunk/LayoutTests/ChangeLog (113394 => 113395)
--- trunk/LayoutTests/ChangeLog 2012-04-05 23:40:48 UTC (rev 113394)
+++ trunk/LayoutTests/ChangeLog 2012-04-05 23:54:06 UTC (rev 113395)
@@ -1,3 +1,23 @@
+2012-04-05 Joshua Bell
+
+IndexedDB: Support string.length in keyPaths
+https://bugs.webkit.org/show_bug.cgi?id=83221
+
+Reviewed by Kentaro Hara.
+
+* storage/indexeddb/keypath-intrinsic-properties-expected.txt: Added.
+* storage/indexeddb/keypath-intrinsic-properties.html: Added.
+* storage/indexeddb/resources/keypath-intrinsic-properties.js: Added.
+(test.request.onsuccess):
+(test):
+(openSuccess.request.onsuccess):
+(openSuccess):
+(testKeyPaths.checkStringLengths.request.onsuccess):
+(testKeyPaths.checkStringLengths):
+(testKeyPaths.checkArrayLengths.request.onsuccess):
+(testKeyPaths.checkArrayLengths):
+(testKeyPaths):
+
2012-04-05 Tony Chang
[chromium] Unreviewed gardening. Remove some tests that are passing consistently.
Added: trunk/LayoutTests/storage/indexeddb/keypath-intrinsic-properties-expected.txt (0 => 113395)
--- trunk/LayoutTests/storage/indexeddb/keypath-intrinsic-properties-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/keypath-intrinsic-properties-expected.txt 2012-04-05 23:54:06 UTC (rev 113395)
@@ -0,0 +1,41 @@
+Test IndexedDB keyPath with intrinsic properties
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+indexedDB.deleteDatabase('keypath-intrinsic-properties')
+indexedDB.open('keypath-intrinsic-properties')
+
+openSuccess():
+db = event.target.result
+request = db.setVersion('1')
+store = db.createObjectStore('store', {keyPath: 'id'})
+store.createIndex('string length', 'string.length')
+store.createIndex('array length', 'array.length')
+
+testKeyPaths():
+transaction = db.transaction('store', IDBTransaction.READ_WRITE)
+store = transaction.objectStore('store')
+store.put({"id":"id#0","string":"","array":[]})
+store.put({"id":"id#1","string":"xx","array":["x","x","x"]})
+store.put({"id":"id#2","string":"","array":["x","x","x","x","x","x"]})
+store.put({"id":"id#3","string":"xx","array":["x","x","x","x","x","x","x","x","x"]})
+store.put({"id":"id#4","string":"","array":["x","x","x","x","x","x","x","x","x","x","x","x"]})
+request = store.index('string length').openCursor()
+PASS cursor.key is cursor.value.string.length
+PASS cursor.key is cursor.value.string.length
+PASS cursor.key is cursor.value.string.length
+PASS cursor.key is cursor.value.string.length
+PASS cursor.key is cursor.value.string.length
+request = store.index('array length').openCursor()
+PASS cursor.key is cursor.value.array.length
+PASS cursor.key is cursor.value.array.length
+PASS cursor.key is cursor.value.array.length
+PASS cursor.key is cursor.value.array.length
+PASS cursor.key is cursor.value.array.length
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/storage/indexeddb/keypath-intrinsic-properties.html (0 => 113395)
--- trunk/LayoutTests/storage/indexeddb/keypath-intrinsic-properties.html (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/keypath-intr
[webkit-changes] [113394] trunk/LayoutTests
Title: [113394] trunk/LayoutTests Revision 113394 Author t...@chromium.org Date 2012-04-05 16:40:48 -0700 (Thu, 05 Apr 2012) Log Message [chromium] Unreviewed gardening. Remove some tests that are passing consistently. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (113393 => 113394) --- trunk/LayoutTests/ChangeLog 2012-04-05 23:28:21 UTC (rev 113393) +++ trunk/LayoutTests/ChangeLog 2012-04-05 23:40:48 UTC (rev 113394) @@ -1,5 +1,11 @@ 2012-04-05 Tony Chang +[chromium] Unreviewed gardening. Remove some tests that are passing consistently. + +* platform/chromium/test_expectations.txt: + +2012-04-05 Tony Chang + [chromium] Unreviewed gardening. fast/js/cross-global-object-inline-global-var.html is flakey on win debug and fast/forms/select-style.html is consistently passing. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (113393 => 113394) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-05 23:28:21 UTC (rev 113393) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-05 23:40:48 UTC (rev 113394) @@ -1377,8 +1377,6 @@ // GURL doesn't handle switching from standard URL to path URL correctly BUGWK27914 WIN : fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html = TEXT -BUGWK66467 : fast/dom/HTMLInputElement/input-image-alt-text.html = FAIL - BUGWK80227 : editing/selection/select-line-break-with-opposite-directionality.html = PASS TEXT // This test isn't hanging, it just takes 12-13 seconds to run. @@ -1499,8 +1497,6 @@ // Unexpected gray BUGCR23476 MAC : fast/frames/inline-object-inside-frameset.html = IMAGE BUGCR23476 MAC : fast/text/font-initial.html = IMAGE -// Expectation changed at r99653 (IMAGE -> IMAGE+TEXT). -BUGCR23476 BUGWK70765 MAC : fast/forms/listbox-clip.html = IMAGE IMAGE+TEXT // Disagreeing XML parsing error messages BUGCR88911 LEOPARD : fast/xsl/xslt-extra-content-at-end.xml = IMAGE+TEXT @@ -2898,7 +2894,7 @@ BUGWK74137 MAC : fast/regions/position-writing-modes-in-variable-width-regions.html = PASS TEXT // CSS custom() filters are not currently supported -BUGWK71392 WIN : css3/filters/custom = FAIL +BUGWK71392 WIN : css3/filters/custom = FAIL PASS BUGWK82783 SKIP : css3/filters/filter-change-repaint-composited.html = FAIL BUGWK82783 SKIP : css3/filters/filter-change-repaint.html = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [113393] branches/chromium/1084
Title: [113393] branches/chromium/1084
Revision 113393
Author a...@chromium.org
Date 2012-04-05 16:28:21 -0700 (Thu, 05 Apr 2012)
Log Message
Merge 113086 - [v8] Fix memory leak in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=83057
Reviewed by Ojan Vafai.
Source/WebCore:
This also brings the V8 and JSC implementation closer. The timing when we first lookup
the form element is now same in JSC and V8 (but different from Mozilla).
This also clears the strings once the code has been parsed and the function created.
Tests: fast/dom/inline-event-attributes-moved.html
fast/dom/inline-event-attributes-release.html
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8LazyEventListener.h:
(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):
LayoutTests:
* fast/dom/inline-event-attributes-moved-expected.txt: Added.
* fast/dom/inline-event-attributes-moved.html: Added.
* fast/dom/inline-event-attributes-release-expected.txt: Added.
* fast/dom/inline-event-attributes-release.html: Added.
TBR=a...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10007027
Modified Paths
branches/chromium/1084/LayoutTests/ChangeLog
branches/chromium/1084/Source/WebCore/bindings/v8/V8LazyEventListener.cpp
branches/chromium/1084/Source/WebCore/bindings/v8/V8LazyEventListener.h
Added Paths
branches/chromium/1084/LayoutTests/fast/dom/inline-event-attributes-moved-expected.txt
branches/chromium/1084/LayoutTests/fast/dom/inline-event-attributes-moved.html
branches/chromium/1084/LayoutTests/fast/dom/inline-event-attributes-release-expected.txt
branches/chromium/1084/LayoutTests/fast/dom/inline-event-attributes-release.html
Diff
Modified: branches/chromium/1084/LayoutTests/ChangeLog (113392 => 113393)
--- branches/chromium/1084/LayoutTests/ChangeLog 2012-04-05 23:20:31 UTC (rev 113392)
+++ branches/chromium/1084/LayoutTests/ChangeLog 2012-04-05 23:28:21 UTC (rev 113393)
@@ -12,6 +12,18 @@
* webintents/web-intents-api.html:
* webintents/web-intents-invoke.html:
+2012-04-03 Erik Arvidsson
+
+[v8] Fix memory leak in V8LazyEventListener
+https://bugs.webkit.org/show_bug.cgi?id=83057
+
+Reviewed by Ojan Vafai.
+
+* fast/dom/inline-event-attributes-moved-expected.txt: Added.
+* fast/dom/inline-event-attributes-moved.html: Added.
+* fast/dom/inline-event-attributes-release-expected.txt: Added.
+* fast/dom/inline-event-attributes-release.html: Added.
+
2012-03-27 Dirk Pranke
Remove a bunch of lines that are no longer failing.
Copied: branches/chromium/1084/LayoutTests/fast/dom/inline-event-attributes-moved-expected.txt (from rev 113086, trunk/LayoutTests/fast/dom/inline-event-attributes-moved-expected.txt) (0 => 113393)
--- branches/chromium/1084/LayoutTests/fast/dom/inline-event-attributes-moved-expected.txt (rev 0)
+++ branches/chromium/1084/LayoutTests/fast/dom/inline-event-attributes-moved-expected.txt 2012-04-05 23:28:21 UTC (rev 113393)
@@ -0,0 +1,10 @@
+Tests that we have the expected form in scope
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS expected is "undefined"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: branches/chromium/1084/LayoutTests/fast/dom/inline-event-attributes-moved.html (from rev 113086, trunk/LayoutTests/fast/dom/inline-event-attributes-moved.html) (0 => 113393)
--- branches/chromium/1084/LayoutTests/fast/dom/inline-event-attributes-moved.html (rev 0)
+++ branches/chromium/1084/LayoutTests/fast/dom/inline-event-attributes-moved.html 2012-04-05 23:28:21 UTC (rev 113393)
@@ -0,0 +1,25 @@
+
+
+
+description('Tests that we have the expected form in scope');
+
+function dispatchClick(element)
+{
+var clickEvent = document.createEvent('MouseEvent');
+clickEvent.initMouseEvent('click', true, false, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
+element.dispatchEvent(clickEvent);
+}
+
+var expected;
+var f = document.createElement('form');
+var i = f.appendChild(document.createElement('input'));
+i.setAttribute('onclick', 'expected = typeof action');
+f.removeChild(i);
+f = null;
+gc();
+dispatchClick(i);
+shouldBeEqualToString('expected', 'undefined');
+
+
+\ No newline at end of file
