[webkit-changes] [114610] releases/WebKitGTK/webkit-1.8/Source/WebCore
Title: [114610] releases/WebKitGTK/webkit-1.8/Source/WebCore
Revision 114610
Author mrobin...@webkit.org
Date 2012-04-18 23:33:52 -0700 (Wed, 18 Apr 2012)
Log Message
Fix a failed merge.
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/ApplyStyleCommand.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLMediaElement.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLMediaElement.h
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderBlock.h
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderText.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderTextFragment.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/ApplyStyleCommand.cpp (114609 => 114610)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/ApplyStyleCommand.cpp 2012-04-19 05:40:08 UTC (rev 114609)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/ApplyStyleCommand.cpp 2012-04-19 06:33:52 UTC (rev 114610)
@@ -704,7 +704,7 @@
return false;
}
-void ApplyStyleCommand::applyInlineStyleToNodeRange(EditingStyle* style, Node* node, Node* pastEndNode)
+void ApplyStyleCommand::applyInlineStyleToNodeRange(EditingStyle* style, PassRefPtrNode startNode, PassRefPtrNode pastEndNode)
{
if (m_removeOnly)
return;
@@ -723,7 +723,7 @@
if (pastEndNode pastEndNode-isDescendantOf(node.get()))
break;
// Add to this element's inline style and skip over its contents.
-HTMLElement* element = toHTMLElement(node);
+HTMLElement* element = toHTMLElement(node.get());
RefPtrStylePropertySet inlineStyle = element-ensureInlineStyleDecl()-copy();
inlineStyle-merge(style-style());
setNodeAttribute(element, styleAttr, inlineStyle-asText());
@@ -737,7 +737,7 @@
if (node-childNodeCount()) {
if (node-contains(pastEndNode.get()) || containsNonEditableRegion(node.get()) || !node-parentNode()-rendererIsEditable())
continue;
-if (editingIgnoresContent(node)) {
+if (editingIgnoresContent(node.get())) {
next = node-traverseNextSibling();
continue;
}
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLMediaElement.cpp (114609 => 114610)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLMediaElement.cpp 2012-04-19 05:40:08 UTC (rev 114609)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLMediaElement.cpp 2012-04-19 06:33:52 UTC (rev 114610)
@@ -2552,16 +2552,23 @@
KURL mediaURL;
Node* node;
HTMLSourceElement* source = 0;
+String type;
bool lookingForStartNode = m_nextChildNodeToConsider;
-bool canUse = false;
+bool canUseSourceElement = false;
+bool okToLoadSourceURL;
-for (node = firstChild(); !canUse node; node = node-nextSibling()) {
+NodeVector potentialSourceNodes;
+getChildNodes(this, potentialSourceNodes);
+for (unsigned i = 0; !canUseSourceElement i potentialSourceNodes.size(); ++i) {
+node = potentialSourceNodes[i].get();
if (lookingForStartNode m_nextChildNodeToConsider != node)
continue;
lookingForStartNode = false;
-
+
if (!node-hasTagName(sourceTag))
continue;
+if (node-parentNode() != this)
+continue;
source = static_castHTMLSourceElement*(node);
@@ -2595,34 +2602,41 @@
}
// Is it safe to load this url?
-if (!isSafeToLoadURL(mediaURL, actionIfInvalid) || !dispatchBeforeLoadEvent(mediaURL.string()))
+okToLoadSourceURL = isSafeToLoadURL(mediaURL, actionIfInvalid) dispatchBeforeLoadEvent(mediaURL.string());
+
+// A 'beforeload' event handler can mutate the DOM, so check to see if the source element is still a child node.
+if (node-parentNode() != this) {
+LOG(Media, HTMLMediaElement::selectNextSourceChild : 'beforeload' removed current element);
+source = 0;
goto check_again;
+}
+if (!okToLoadSourceURL)
+goto check_again;
+
// Making it this far means the source looks reasonable.
-canUse = true;
+canUseSourceElement = true;
check_again:
-if (!canUse actionIfInvalid == Complain)
+if (!canUseSourceElement actionIfInvalid == Complain source)
source-scheduleErrorEvent();
}
-if (canUse) {
+if (canUseSourceElement) {
if (contentType)
*contentType = ContentType(source-type());
m_currentSourceNode = source;
m_nextChildNodeToConsider = source-nextSibling();
-if (!m_nextChildNodeToConsider)
-m_nextChildNodeToConsider = sourceChildEndOfListValue();
} else {
m_currentSourceNode = 0;
-m_nextChildNodeToConsider = sourceChildEndOfListValue();
+m_nextChildNodeToConsider = 0;
}
[webkit-changes] [114611] releases/WebKitGTK/webkit-1.8
Title: [114611] releases/WebKitGTK/webkit-1.8
Revision 114611
Author mrobin...@webkit.org
Date 2012-04-18 23:35:04 -0700 (Wed, 18 Apr 2012)
Log Message
Merging r110323
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderBoxModelObject.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderListMarker.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderObject.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderObject.h
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderReplaced.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderText.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderView.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderWidget.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/first-letter-selection-crash-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/first-letter-selection-crash.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (114610 => 114611)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-04-19 06:33:52 UTC (rev 114610)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-04-19 06:35:04 UTC (rev 114611)
@@ -1,3 +1,13 @@
+2012-04-18 Abhishek Arya infe...@chromium.org
+
+Crash due to accessing removed parent lineboxes when clearing selection.
+https://bugs.webkit.org/show_bug.cgi?id=79264
+
+Reviewed by Dave Hyatt.
+
+* editing/selection/first-letter-selection-crash-expected.txt: Added.
+* editing/selection/first-letter-selection-crash.html: Added.
+
2012-04-18 Ken Buchanan ke...@chromium.org
Crash due to floating object lists not properly being cleared
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/first-letter-selection-crash-expected.txt (0 => 114611)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/first-letter-selection-crash-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/first-letter-selection-crash-expected.txt 2012-04-19 06:35:04 UTC (rev 114611)
@@ -0,0 +1 @@
+PASS
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/first-letter-selection-crash-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/first-letter-selection-crash.html (0 => 114611)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/first-letter-selection-crash.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/first-letter-selection-crash.html 2012-04-19 06:35:04 UTC (rev 114611)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+body
+style
+#test2:first-letter { display: block; }
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+window._onload_ = function() {
+test1 = document.createElement('div');
+document.body.appendChild(test1);
+test2 = document.createElement('div');
+test2.setAttribute('id', 'test2');
+test2.appendChild(document.createTextNode('aaa'));
+test2.style.display = 'inline-block';
+test1.appendChild(test2);
+test1.appendChild(document.createTextNode('a'));
+document.execCommand('selectall');
+document.body.offsetTop;
+document.styleSheets[0].insertRule(#test2 { text-transform: uppercase });
+document.body.offsetTop;
+document.body.innerHTML = PASS;
+}
+/script
+/body
+/html
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/first-letter-selection-crash.html
___
Added: svn:executable
Added: svn:eol-style
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (114610 => 114611)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-19 06:33:52 UTC (rev 114610)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-19 06:35:04 UTC (rev 114611)
@@ -1,3 +1,53 @@
+2012-04-18 Abhishek Arya infe...@chromium.org
+
+Crash due to accessing removed parent lineboxes when clearing selection.
+https://bugs.webkit.org/show_bug.cgi?id=79264
+
+Reviewed by Dave Hyatt.
+
+Test: editing/selection/first-letter-selection-crash.html
+
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::setSelectionState):
+1. No need of checking if we are being set to same selection state.
+Now tested by setSelectionStateIfNeeded. Rename 's' with 'state' and
+'cb' with 'containingBlock'.
+* rendering/RenderListMarker.cpp:
+(WebCore::RenderListMarker::setSelectionState):
+1. Add check to canUpdateSelectionOnRootLineBoxes
[webkit-changes] [114612] trunk/LayoutTests
Title: [114612] trunk/LayoutTests Revision 114612 Author toyos...@chromium.org Date 2012-04-18 23:35:57 -0700 (Wed, 18 Apr 2012) Log Message Unrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html * platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (114611 => 114612) --- trunk/LayoutTests/ChangeLog 2012-04-19 06:35:04 UTC (rev 114611) +++ trunk/LayoutTests/ChangeLog 2012-04-19 06:35:57 UTC (rev 114612) @@ -1,3 +1,9 @@ +2012-04-18 Takashi Toyoshima toyos...@chromium.org + +Unrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html + +* platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: + 2012-04-18 Jason Liu jason@torchmobile.com.cn [BlackBerry] Parsed Cookie's m_hasDefaultDomain is not needed. Modified: trunk/LayoutTests/platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114613] releases/WebKitGTK/webkit-1.8
Title: [114613] releases/WebKitGTK/webkit-1.8
Revision 114613
Author mrobin...@webkit.org
Date 2012-04-18 23:38:13 -0700 (Wed, 18 Apr 2012)
Log Message
Merging r111899
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderObject.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderSelectionInfo.h
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/clear-selection-crash-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/clear-selection-crash.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (114612 => 114613)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-04-19 06:35:57 UTC (rev 114612)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-04-19 06:38:13 UTC (rev 114613)
@@ -1,6 +1,16 @@
2012-04-18 Abhishek Arya infe...@chromium.org
Crash due to accessing removed parent lineboxes when clearing selection.
+https://bugs.webkit.org/show_bug.cgi?id=81359
+
+Reviewed by Eric Seidel.
+
+* editing/selection/clear-selection-crash-expected.txt: Added.
+* editing/selection/clear-selection-crash.html: Added.
+
+2012-04-18 Abhishek Arya infe...@chromium.org
+
+Crash due to accessing removed parent lineboxes when clearing selection.
https://bugs.webkit.org/show_bug.cgi?id=79264
Reviewed by Dave Hyatt.
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/clear-selection-crash-expected.txt (0 => 114613)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/clear-selection-crash-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/clear-selection-crash-expected.txt 2012-04-19 06:38:13 UTC (rev 114613)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/clear-selection-crash-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/clear-selection-crash.html (0 => 114613)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/clear-selection-crash.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/clear-selection-crash.html 2012-04-19 06:38:13 UTC (rev 114613)
@@ -0,0 +1,27 @@
+!DOCTYPE html
+html
+body
+div style=display: -webkit-inline-box
+div id=start style=display: -webkit-inline-box
+i
+div style=display: run-in; height: 1px/div
+span id=span1 style=width: 1pxA/span
+/i
+/div
+iB/i
+/div
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+document.body.offsetTop;
+document.designMode = 'on';
+document.execCommand('selectall');
+document.body.offsetTop;
+span1.style.display = 'block';
+
+document.body.offsetTop;
+document.body.innerHTML = PASS. WebKit didn't crash.;
+/script
+/body
+/html
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/clear-selection-crash.html
___
Added: svn:executable
Added: svn:eol-style
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (114612 => 114613)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-19 06:35:57 UTC (rev 114612)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-19 06:38:13 UTC (rev 114613)
@@ -1,6 +1,24 @@
2012-04-18 Abhishek Arya infe...@chromium.org
Crash due to accessing removed parent lineboxes when clearing selection.
+https://bugs.webkit.org/show_bug.cgi?id=81359
+
+Reviewed by Eric Seidel.
+
+Similar to r110323, adds the canUpdateSelectionOnRootLineBoxes
+check to more places.
+
+Test: editing/selection/clear-selection-crash.html
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::canUpdateSelectionOnRootLineBoxes):
+* rendering/RenderSelectionInfo.h:
+(WebCore::RenderSelectionInfo::RenderSelectionInfo):
+(WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):
+
+2012-04-18 Abhishek Arya infe...@chromium.org
+
+Crash due to accessing removed parent lineboxes when clearing selection.
https://bugs.webkit.org/show_bug.cgi?id=79264
Reviewed by Dave Hyatt.
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderObject.cpp (114612 => 114613)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderObject.cpp 2012-04-19 06:35:57 UTC (rev 114612)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderObject.cpp 2012-04-19 06:38:13 UTC (rev 114613)
@@ -2802,6 +2802,9 @@
bool RenderObject::canUpdateSelectionOnRootLineBoxes()
{
+if
[webkit-changes] [114615] releases/WebKitGTK/webkit-1.8/Source/WebCore
Title: [114615] releases/WebKitGTK/webkit-1.8/Source/WebCore
Revision 114615
Author mrobin...@webkit.org
Date 2012-04-18 23:54:05 -0700 (Wed, 18 Apr 2012)
Log Message
Merging r110374
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (114614 => 114615)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-19 06:42:07 UTC (rev 114614)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-19 06:54:05 UTC (rev 114615)
@@ -1,3 +1,27 @@
+2012-04-18 MORITA Hajime morr...@google.com
+
+ShadowTree uses weak iteration patterns
+https://bugs.webkit.org/show_bug.cgi?id=80572
+
+Reviewed by Dimitri Glazkov.
+
+Patch by Adam Barth.
+
+This patch moves various ShadowTree to using a better iteration pattern
+in which we collect all the ShadowRoots we're planning to iterate into
+a vector and then iterate over them.
+
+* dom/ShadowTree.cpp:
+(ShadowRootVector):
+(WebCore::ShadowRootVector::ShadowRootVector):
+(WebCore):
+(WebCore::ShadowTree::removeAllShadowRoots):
+(WebCore::ShadowTree::insertedIntoDocument):
+(WebCore::ShadowTree::removedFromDocument):
+(WebCore::ShadowTree::insertedIntoTree):
+(WebCore::ShadowTree::removedFromTree):
+(WebCore::ShadowTree::willRemove):
+
2012-04-18 Stephen Chenney schen...@chromium.org
SVG layout leaves objects still needing layout
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp (114614 => 114615)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp 2012-04-19 06:42:07 UTC (rev 114614)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp 2012-04-19 06:54:05 UTC (rev 114615)
@@ -34,6 +34,15 @@
namespace WebCore {
+class ShadowRootVector : public VectorRefPtrShadowRoot {
+public:
+explicit ShadowRootVector(ShadowTree* tree)
+{
+for (ShadowRoot* root = tree-youngestShadowRoot(); root; root = root-olderShadowRoot())
+append(root);
+}
+};
+
ShadowRootList::ShadowRootList()
{
}
@@ -65,32 +74,37 @@
void ShadowRootList::insertedIntoDocument()
{
-for (ShadowRoot* root = youngestShadowRoot(); root; root = root-olderShadowRoot())
-root-insertedIntoDocument();
+ShadowRootVector roots(this);
+for (size_t i = 0; i roots.size(); ++i)
+roots[i]-insertedIntoDocument();
}
void ShadowRootList::removedFromDocument()
{
-for (ShadowRoot* root = youngestShadowRoot(); root; root = root-olderShadowRoot())
-root-removedFromDocument();
+ShadowRootVector roots(this);
+for (size_t i = 0; i roots.size(); ++i)
+roots[i]-removedFromDocument();
}
void ShadowRootList::insertedIntoTree(bool deep)
{
-for (ShadowRoot* root = youngestShadowRoot(); root; root = root-olderShadowRoot())
-root-insertedIntoTree(deep);
+ShadowRootVector roots(this);
+for (size_t i = 0; i roots.size(); ++i)
+roots[i]-insertedIntoTree(deep);
}
void ShadowRootList::removedFromTree(bool deep)
{
-for (ShadowRoot* root = youngestShadowRoot(); root; root = root-olderShadowRoot())
-root-removedFromTree(deep);
+ShadowRootVector roots(this);
+for (size_t i = 0; i roots.size(); ++i)
+roots[i]-removedFromTree(deep);
}
void ShadowRootList::willRemove()
{
-for (ShadowRoot* root = youngestShadowRoot(); root; root = root-olderShadowRoot())
-root-willRemove();
+ShadowRootVector roots(this);
+for (size_t i = 0; i roots.size(); ++i)
+roots[i]-willRemove();
}
void ShadowRootList::hostChildrenChanged()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114617] releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList. cpp
Title: [114617] releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp
Revision 114617
Author mrobin...@webkit.org
Date 2012-04-18 23:59:47 -0700 (Wed, 18 Apr 2012)
Log Message
Fix failed merge
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp (114616 => 114617)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp 2012-04-19 06:56:22 UTC (rev 114616)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp 2012-04-19 06:59:47 UTC (rev 114617)
@@ -36,9 +36,9 @@
class ShadowRootVector : public VectorRefPtrShadowRoot {
public:
-explicit ShadowRootVector(ShadowTree* tree)
+explicit ShadowRootVector(ShadowRootList* list)
{
-for (ShadowRoot* root = tree-youngestShadowRoot(); root; root = root-olderShadowRoot())
+for (ShadowRoot* root = list-youngestShadowRoot(); root; root = root-olderShadowRoot())
append(root);
}
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114618] releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/ RenderSVGResourceContainer.cpp
Title: [114618] releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp Revision 114618 Author mrobin...@webkit.org Date 2012-04-19 00:05:35 -0700 (Thu, 19 Apr 2012) Log Message Fix failed merge Modified Paths releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp Diff Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp (114617 => 114618) --- releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2012-04-19 06:59:47 UTC (rev 114617) +++ releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2012-04-19 07:05:35 UTC (rev 114618) @@ -22,6 +22,7 @@ #if ENABLE(SVG) #include RenderSVGResourceContainer.h +#include RenderSVGRoot.h #include RenderSVGShadowTreeRootContainer.h #include RenderView.h #include SVGResourcesCache.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114619] trunk/LayoutTests
Title: [114619] trunk/LayoutTests Revision 114619 Author toyos...@chromium.org Date 2012-04-19 00:07:22 -0700 (Thu, 19 Apr 2012) Log Message Unreviewed, add expected.txt for cookies-wrong-domain-rejected-result.php . * http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (114618 => 114619) --- trunk/LayoutTests/ChangeLog 2012-04-19 07:05:35 UTC (rev 114618) +++ trunk/LayoutTests/ChangeLog 2012-04-19 07:07:22 UTC (rev 114619) @@ -1,5 +1,11 @@ 2012-04-18 Takashi Toyoshima toyos...@chromium.org +Unreviewed, add expected.txt for cookies-wrong-domain-rejected-result.php . + +* http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt: Added. + +2012-04-18 Takashi Toyoshima toyos...@chromium.org + Unrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html * platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added: trunk/LayoutTests/http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt (0 => 114619) --- trunk/LayoutTests/http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt 2012-04-19 07:07:22 UTC (rev 114619) @@ -0,0 +1 @@ +PASS: User agent rejected the cookie with a wrong domain. Property changes on: trunk/LayoutTests/http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt ___ Added: svn:eol-style ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114620] releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg
Title: [114620] releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg
Revision 114620
Author mrobin...@webkit.org
Date 2012-04-19 00:09:09 -0700 (Thu, 19 Apr 2012)
Log Message
Finish merge of r111601
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGRoot.h
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp (114619 => 114620)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp 2012-04-19 07:07:22 UTC (rev 114619)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp 2012-04-19 07:09:09 UTC (rev 114620)
@@ -26,6 +26,7 @@
#include GraphicsContext.h
#include RenderSVGContainer.h
+#include RenderSVGRoot.h
#include SVGElement.h
#include SVGMarkerElement.h
#include SVGRenderSupport.h
@@ -49,7 +50,7 @@
{
// Invalidate all resources if our layout changed.
if (everHadLayout() selfNeedsLayout())
-removeAllClientsFromCache();
+RenderSVGRoot::addResourceForClientInvalidation(this);
// RenderSVGHiddenContainer overwrites layout(). We need the
// layouting of RenderSVGContainer for calculating local
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGRoot.cpp (114619 => 114620)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2012-04-19 07:07:22 UTC (rev 114619)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2012-04-19 07:09:09 UTC (rev 114620)
@@ -200,6 +200,8 @@
{
ASSERT(needsLayout());
+m_resourcesNeedingToInvalidateClients.clear();
+
// Arbitrary affine transforms are incompatible with LayoutState.
LayoutStateDisabler layoutStateDisabler(view());
@@ -215,6 +217,16 @@
m_isLayoutSizeChanged = needsLayout || (svg-hasRelativeLengths() oldSize != size());
SVGRenderSupport::layoutChildren(this, needsLayout || SVGRenderSupport::filtersForceContainerLayout(this));
+if (!m_resourcesNeedingToInvalidateClients.isEmpty()) {
+// Invalidate resource clients, which may mark some nodes for layout.
+HashSetRenderSVGResourceContainer*::iterator end = m_resourcesNeedingToInvalidateClients.end();
+for (HashSetRenderSVGResourceContainer*::iterator it = m_resourcesNeedingToInvalidateClients.begin(); it != end; ++it)
+(*it)-removeAllClientsFromCache();
+
+m_isLayoutSizeChanged = false;
+SVGRenderSupport::layoutChildren(this, false);
+}
+
// At this point LayoutRepainter already grabbed the old bounds,
// recalculate them now so repaintAfterLayout() uses the new bounds.
if (m_needsBoundariesOrTransformUpdate) {
@@ -401,6 +413,16 @@
return false;
}
+void RenderSVGRoot::addResourceForClientInvalidation(RenderSVGResourceContainer* resource)
+{
+RenderObject* svgRoot = resource-parent();
+while (svgRoot !svgRoot-isSVGRoot())
+svgRoot = svgRoot-parent();
+if (!svgRoot)
+return;
+static_castRenderSVGRoot*(svgRoot)-m_resourcesNeedingToInvalidateClients.add(resource);
}
+}
+
#endif // ENABLE(SVG)
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGRoot.h (114619 => 114620)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGRoot.h 2012-04-19 07:07:22 UTC (rev 114619)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGRoot.h 2012-04-19 07:09:09 UTC (rev 114620)
@@ -53,6 +53,10 @@
IntSize containerSize() const { return m_containerSize; }
void setContainerSize(const IntSize containerSize) { m_containerSize = containerSize; }
+// The flag is cleared at the beginning of each layout() pass. Elements then call this
+// method during layout when they are invalidated by a filter.
+static void addResourceForClientInvalidation(RenderSVGResourceContainer*);
+
private:
virtual RenderObjectChildList* virtualChildren() { return children(); }
virtual const RenderObjectChildList* virtualChildren() const { return children(); }
@@ -98,6 +102,7 @@
FloatRect m_repaintBoundingBox;
mutable AffineTransform m_localToParentTransform;
AffineTransform m_localToBorderBoxTransform;
+HashSetRenderSVGResourceContainer* m_resourcesNeedingToInvalidateClients;
bool m_isLayoutSizeChanged : 1;
bool m_needsBoundariesOrTransformUpdate : 1;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114621] trunk/Source/WebCore
Title: [114621] trunk/Source/WebCore
Revision 114621
Author commit-qu...@webkit.org
Date 2012-04-19 00:20:36 -0700 (Thu, 19 Apr 2012)
Log Message
Optimize for DARWIN in DirectConvolver::process()
https://bugs.webkit.org/show_bug.cgi?id=80256
Patch by Xingnan Wang xingnan.w...@intel.com on 2012-04-19
Reviewed by Chris Rogers.
* platform/audio/DirectConvolver.cpp:
(WebCore::DirectConvolver::process):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/DirectConvolver.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114620 => 114621)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 07:09:09 UTC (rev 114620)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 07:20:36 UTC (rev 114621)
@@ -1,3 +1,13 @@
+2012-04-19 Xingnan Wang xingnan.w...@intel.com
+
+Optimize for DARWIN in DirectConvolver::process()
+https://bugs.webkit.org/show_bug.cgi?id=80256
+
+Reviewed by Chris Rogers.
+
+* platform/audio/DirectConvolver.cpp:
+(WebCore::DirectConvolver::process):
+
2012-04-18 Noel Gordon noel.gor...@gmail.com
[CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG
Modified: trunk/Source/WebCore/platform/audio/DirectConvolver.cpp (114620 => 114621)
--- trunk/Source/WebCore/platform/audio/DirectConvolver.cpp 2012-04-19 07:09:09 UTC (rev 114620)
+++ trunk/Source/WebCore/platform/audio/DirectConvolver.cpp 2012-04-19 07:20:36 UTC (rev 114621)
@@ -32,6 +32,10 @@
#include DirectConvolver.h
+#if OS(DARWIN)
+#include Accelerate/Accelerate.h
+#endif
+
#include VectorMath.h
namespace WebCore {
@@ -49,9 +53,6 @@
void DirectConvolver::process(AudioFloatArray* convolutionKernel, const float* sourceP, float* destP, size_t framesToProcess)
{
-// FIXME: Optimize for DARWIN, conv() function in Accelerate.framework can be used here.
-// https://bugs.webkit.org/show_bug.cgi?id=80256
-
ASSERT(framesToProcess == m_inputBlockSize);
if (framesToProcess != m_inputBlockSize)
return;
@@ -88,6 +89,13 @@
// Copy samples to 2nd half of input buffer.
memcpy(inputP, sourceP, sizeof(float) * framesToProcess);
+#if OS(DARWIN)
+#if defined(__ppc__) || defined(__i386__)
+conv(inputP - kernelSize + 1, 1, kernelP + kernelSize - 1, -1, destP, 1, framesToProcess, kernelSize);
+#else
+vDSP_conv(inputP - kernelSize + 1, 1, kernelP + kernelSize - 1, -1, destP, 1, framesToProcess, kernelSize);
+#endif // defined(__ppc__) || defined(__i386__)
+#else
// FIXME: The macro can be further optimized to avoid pipeline stalls. One possibility is to maintain 4 separate sums and change the macro to CONVOLVE_FOUR_SAMPLES.
#define CONVOLVE_ONE_SAMPLE \
sum += inputP[i - j] * kernelP[j]; \
@@ -357,6 +365,7 @@
}
destP[i++] = sum;
}
+#endif // OS(DARWIN)
// Copy 2nd half of input buffer to 1st half.
memcpy(m_buffer.data(), inputP, sizeof(float) * framesToProcess);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114622] trunk/Source/JavaScriptCore
Title: [114622] trunk/Source/_javascript_Core
Revision 114622
Author commit-qu...@webkit.org
Date 2012-04-19 02:08:18 -0700 (Thu, 19 Apr 2012)
Log Message
[CMake] Build fix after r114575
https://bugs.webkit.org/show_bug.cgi?id=84322
Patch by Dominik Röttsches dominik.rottsc...@linux.intel.com on 2012-04-19
Reviewed by Simon Hausmann.
Build fix, adding WTF when linking jsc shell.
* shell/CMakeLists.txt:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/CMakeLists.txt
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (114621 => 114622)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-19 07:20:36 UTC (rev 114621)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-19 09:08:18 UTC (rev 114622)
@@ -1,3 +1,14 @@
+2012-04-19 Dominik Röttsches dominik.rottsc...@linux.intel.com
+
+[CMake] Build fix after r114575
+https://bugs.webkit.org/show_bug.cgi?id=84322
+
+Reviewed by Simon Hausmann.
+
+Build fix, adding WTF when linking jsc shell.
+
+* shell/CMakeLists.txt:
+
2012-04-18 Filip Pizlo fpi...@apple.com
JSC testing should have complete coverage over typed array types
Modified: trunk/Source/_javascript_Core/shell/CMakeLists.txt (114621 => 114622)
--- trunk/Source/_javascript_Core/shell/CMakeLists.txt 2012-04-19 07:20:36 UTC (rev 114621)
+++ trunk/Source/_javascript_Core/shell/CMakeLists.txt 2012-04-19 09:08:18 UTC (rev 114622)
@@ -3,6 +3,7 @@
)
SET(JSC_LIBRARIES
+${WTF_LIBRARY_NAME}
${_javascript_Core_LIBRARY_NAME}
)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114623] trunk
Title: [114623] trunk
Revision 114623
Author pfeld...@chromium.org
Date 2012-04-19 04:39:50 -0700 (Thu, 19 Apr 2012)
Log Message
Web Inspector: reuse ParsedUrl in the UISourceCode
https://bugs.webkit.org/show_bug.cgi?id=84326
Reviewed by Yury Semikhatsky.
Source/WebCore:
Migrated UISourceCode to ParsedURL, moved the displayName logic into its only client:
TabbedEditorContainer.
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.SourceMapParser.prototype._canonicalizeURL):
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
* inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get parsedURL):
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/ui-source-code-display-name.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/debugger-test.js
trunk/LayoutTests/inspector/debugger/ui-source-code-display-name.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js
trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js
trunk/Source/WebCore/inspector/front-end/ResourceUtils.js
trunk/Source/WebCore/inspector/front-end/ScriptsNavigator.js
trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (114622 => 114623)
--- trunk/LayoutTests/ChangeLog 2012-04-19 09:08:18 UTC (rev 114622)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 11:39:50 UTC (rev 114623)
@@ -1,3 +1,14 @@
+2012-04-19 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: reuse ParsedUrl in the UISourceCode
+https://bugs.webkit.org/show_bug.cgi?id=84326
+
+Reviewed by Yury Semikhatsky.
+
+* http/tests/inspector/debugger-test.js:
+(initialize_DebuggerTest):
+* inspector/debugger/ui-source-code-display-name.html:
+
2012-04-18 Takashi Toyoshima toyos...@chromium.org
Unreviewed, add expected.txt for cookies-wrong-domain-rejected-result.php .
Modified: trunk/LayoutTests/http/tests/inspector/debugger-test.js (114622 => 114623)
--- trunk/LayoutTests/http/tests/inspector/debugger-test.js 2012-04-19 09:08:18 UTC (rev 114622)
+++ trunk/LayoutTests/http/tests/inspector/debugger-test.js 2012-04-19 11:39:50 UTC (rev 114623)
@@ -157,7 +157,7 @@
{
var uiSourceCodes = panel._presentationModel.uiSourceCodes();
for (var i = 0; i uiSourceCodes.length; ++i) {
-if (uiSourceCodes[i].fileName === scriptName) {
+if (uiSourceCodes[i].parsedURL.lastPathComponent === scriptName || uiSourceCodes[i].parsedURL.url ="" scriptName) {
panel.showUISourceCode(uiSourceCodes[i]);
var sourceFrame = panel.visibleView;
if (sourceFrame.loaded)
Modified: trunk/LayoutTests/inspector/debugger/ui-source-code-display-name.html (114622 => 114623)
--- trunk/LayoutTests/inspector/debugger/ui-source-code-display-name.html 2012-04-19 09:08:18 UTC (rev 114622)
+++ trunk/LayoutTests/inspector/debugger/ui-source-code-display-name.html 2012-04-19 11:39:50 UTC (rev 114623)
@@ -7,7 +7,7 @@
function dumpUISourceCodeDisplayName(url)
{
var uiSourceCode = new WebInspector.UISourceCode(id, url, null, null);
-InspectorTest.addResult(UISourceCode display name for url \ + url + \ is \ + uiSourceCode.displayName + \.);
+InspectorTest.addResult(UISourceCode display name for url \ + url + \ is \ + WebInspector.TabbedEditorContainer.prototype._titleForFile(uiSourceCode) + \.);
}
const baseURL = http://localhost:8080/folder/;
Modified: trunk/Source/WebCore/ChangeLog (114622 => 114623)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 09:08:18 UTC (rev 114622)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 11:39:50 UTC (rev 114623)
@@ -1,3 +1,32 @@
+2012-04-19 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: reuse ParsedUrl in the UISourceCode
+https://bugs.webkit.org/show_bug.cgi?id=84326
+
+Reviewed by Yury Semikhatsky.
+
+Migrated UISourceCode to ParsedURL, moved the displayName logic into its only client:
+TabbedEditorContainer.
+
+* inspector/front-end/CompilerScriptMapping.js:
+(WebInspector.SourceMapParser.prototype._canonicalizeURL):
+*
[webkit-changes] [114624] trunk/Source/WebKit/blackberry
Title: [114624] trunk/Source/WebKit/blackberry
Revision 114624
Author commit-qu...@webkit.org
Date 2012-04-19 04:44:21 -0700 (Thu, 19 Apr 2012)
Log Message
[BlackBerry] Always use the AnimationFrameRateController for accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=84323
Patch by Arvid Nilsson anils...@rim.com on 2012-04-19
Reviewed by Antonio Gomes.
PR 150750
Regardless of whether there's a WebPageCompositorClient, we want the
AnimationFrameRateController to manage animation frames.
Reviewed internally by Andrew Lo.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
Modified Paths
trunk/Source/WebKit/blackberry/Api/BackingStore.cpp
trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp
trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h
trunk/Source/WebKit/blackberry/ChangeLog
Diff
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (114623 => 114624)
--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-04-19 11:39:50 UTC (rev 114623)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-04-19 11:44:21 UTC (rev 114624)
@@ -1258,7 +1258,7 @@
// If there's a WebPageCompositorClient, let it schedule the blit.
if (WebPageCompositorPrivate* compositor = m_webPage-d-compositor()) {
if (WebPageCompositorClient* client = compositor-client()) {
-client-invalidate(compositor-animationFrameTimestamp());
+client-invalidate(0);
return;
}
}
Modified: trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp (114623 => 114624)
--- trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp 2012-04-19 11:39:50 UTC (rev 114623)
+++ trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp 2012-04-19 11:44:21 UTC (rev 114624)
@@ -43,7 +43,6 @@
WebPageCompositorPrivate::WebPageCompositorPrivate(WebPagePrivate* page, WebPageCompositorClient* client)
: m_client(client)
, m_webPage(page)
-, m_pendingAnimationFrame(0.0)
, m_drawsRootLayer(false)
{
setOneShot(true); // one-shot animation client
@@ -118,8 +117,6 @@
if (!m_layerRenderer)
return false;
-m_pendingAnimationFrame = 0.0;
-
bool shouldClear = drawsRootLayer();
if (BackingStore* backingStore = m_webPage-m_backingStore)
shouldClear = shouldClear || !backingStore-d-isOpenGLCompositing();
@@ -129,13 +126,8 @@
m_lastCompositingResults = m_layerRenderer-lastRenderingResults();
if (m_lastCompositingResults.needsAnimationFrame) {
-// Using a timeout of 0 actually won't start a timer, it will send a message.
-if (m_client)
-m_pendingAnimationFrame = m_client-requestAnimationFrame();
-else {
-Platform::AnimationFrameRateController::instance()-addClient(this);
-m_webPage-updateDelegatedOverlays();
-}
+Platform::AnimationFrameRateController::instance()-addClient(this);
+m_webPage-updateDelegatedOverlays();
}
return true;
Modified: trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h (114623 => 114624)
--- trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h 2012-04-19 11:39:50 UTC (rev 114623)
+++ trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h 2012-04-19 11:44:21 UTC (rev 114624)
@@ -79,8 +79,6 @@
WebCore::LayerRenderingResults lastCompositingResults() const { return m_lastCompositingResults; }
void setLastCompositingResults(const WebCore::LayerRenderingResults results) { m_lastCompositingResults = results; }
-double animationFrameTimestamp() const { return m_pendingAnimationFrame; }
-
void releaseLayerResources();
WebPagePrivate* page() const { return m_webPage; }
@@ -101,7 +99,6 @@
WebCore::IntRect m_layoutRectForCompositing;
WebCore::IntSize m_contentsSizeForCompositing;
WebCore::LayerRenderingResults m_lastCompositingResults;
-double m_pendingAnimationFrame;
bool m_drawsRootLayer;
};
Modified: trunk/Source/WebKit/blackberry/ChangeLog (114623 => 114624)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-04-19 11:39:50 UTC (rev 114623)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-04-19 11:44:21 UTC (rev 114624)
@@ -1,3 +1,23 @@
+2012-04-19 Arvid Nilsson anils...@rim.com
+
+[BlackBerry] Always use the AnimationFrameRateController for accelerated animations
+https://bugs.webkit.org/show_bug.cgi?id=84323
+
+Reviewed by Antonio Gomes.
+
+PR 150750
+Regardless of whether there's a WebPageCompositorClient, we want the
+AnimationFrameRateController to manage animation frames.
+Reviewed internally by Andrew Lo.
+
+* Api/BackingStore.cpp:
+
[webkit-changes] [114626] trunk
Title: [114626] trunk
Revision 114626
Author vse...@chromium.org
Date 2012-04-19 05:08:39 -0700 (Thu, 19 Apr 2012)
Log Message
Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265
Source/WebCore:
Reviewed by Pavel Feldman.
InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.
Test: http/tests/inspector/network/network-image-404.html
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::httpStatusCode):
(WebCore):
* inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
(ResourceData):
(NetworkResourcesData):
* inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):
LayoutTests:
* http/tests/inspector/network/network-image-404-expected.txt: Added.
* http/tests/inspector/network/network-image-404.html: Added.
* http/tests/inspector/network/resources/404.php: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp
trunk/Source/WebCore/inspector/NetworkResourcesData.cpp
trunk/Source/WebCore/inspector/NetworkResourcesData.h
trunk/Source/WebCore/inspector/front-end/RequestView.js
Added Paths
trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-image-404.html
trunk/LayoutTests/http/tests/inspector/network/resources/404.php
Diff
Modified: trunk/LayoutTests/ChangeLog (114625 => 114626)
--- trunk/LayoutTests/ChangeLog 2012-04-19 11:55:10 UTC (rev 114625)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 12:08:39 UTC (rev 114626)
@@ -1,3 +1,12 @@
+2012-04-18 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: No response body available for cached resource requests with error status codes.
+https://bugs.webkit.org/show_bug.cgi?id=84265
+
+* http/tests/inspector/network/network-image-404-expected.txt: Added.
+* http/tests/inspector/network/network-image-404.html: Added.
+* http/tests/inspector/network/resources/404.php: Added.
+
2012-04-19 Ádám Kallai ka...@inf.u-szeged.hu
[Qt] Gardening. Skip failing reftest after 114574.
Added: trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt (0 => 114626)
--- trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt 2012-04-19 12:08:39 UTC (rev 114626)
@@ -0,0 +1,9 @@
+CONSOLE MESSAGE: line 15: Done.
+Tests content is available for failed image request.
+
+Bug 84265
+http://127.0.0.1:8000/inspector/network/resources/404.php
+resource.type: image
+resource.content before requesting content: undefined
+resource.content after requesting content: 404 - resource was not found.
+
Property changes on: trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/inspector/network/network-image-404.html (0 => 114626)
--- trunk/LayoutTests/http/tests/inspector/network/network-image-404.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-image-404.html 2012-04-19 12:08:39 UTC (rev 114626)
@@ -0,0 +1,54 @@
+html
+head
+script src=""
+script src=""
+script
+function loadData()
+{
+var image = new Image();
+image.src = ""
+image._onerror_ = resourceLoaded;
+}
+
+function resourceLoaded()
+{
+console.log(Done.);
+}
+
+function test()
+{
+// Since this test could be run together with other inspector backend cache
+// tests, we need to reset size limits to default ones.
+InspectorTest.resetInspectorResourcesData(step1);
+
+function step1()
+{
+InspectorTest.addConsoleSniffer(step2);
+InspectorTest.evaluateInPage(loadData());
+}
+
+function step2()
+{
+var request1 = WebInspector.panels.network.requests[WebInspector.panels.network.requests.length - 1];
+InspectorTest.addResult(request1.url);
+InspectorTest.addResult(resource.type: + request1.type);
+InspectorTest.addResult(resource.content before requesting content: + request1.content);
+InspectorTest.assertTrue(!request1.failed, Resource loading failed.);
+request1.requestContent(step3);
+}
+
+function step3()
+{
+var request1 = WebInspector.panels.network.requests[WebInspector.panels.network.requests.length - 1];
+InspectorTest.addResult(resource.content after requesting content: +
[webkit-changes] [114627] trunk/Source/WebCore
Title: [114627] trunk/Source/WebCore
Revision 114627
Author noam.rosent...@nokia.com
Date 2012-04-19 06:11:39 -0700 (Thu, 19 Apr 2012)
Log Message
[Qt] Fix Qt-Mac build after libxml patch
https://bugs.webkit.org/show_bug.cgi?id=84313
Use direct include/library paths instead of PKGCONFIG when on Mac.
Reviewed by Simon Hausmann.
No new tests, build fix.
* WebCore.pri:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.pri
Diff
Modified: trunk/Source/WebCore/ChangeLog (114626 => 114627)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 12:08:39 UTC (rev 114626)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 13:11:39 UTC (rev 114627)
@@ -1,3 +1,16 @@
+2012-04-19 No'am Rosenthal noam.rosent...@nokia.com
+
+[Qt] Fix Qt-Mac build after libxml patch
+https://bugs.webkit.org/show_bug.cgi?id=84313
+
+Use direct include/library paths instead of PKGCONFIG when on Mac.
+
+Reviewed by Simon Hausmann.
+
+No new tests, build fix.
+
+* WebCore.pri:
+
2012-04-18 Vsevolod Vlasov vse...@chromium.org
Web Inspector: No response body available for cached resource requests with error status codes.
Modified: trunk/Source/WebCore/WebCore.pri (114626 => 114627)
--- trunk/Source/WebCore/WebCore.pri 2012-04-19 12:08:39 UTC (rev 114626)
+++ trunk/Source/WebCore/WebCore.pri 2012-04-19 13:11:39 UTC (rev 114627)
@@ -113,7 +113,12 @@
contains(DEFINES, ENABLE_XSLT=1) {
contains(DEFINES, WTF_USE_LIBXML2=1) {
-PKGCONFIG += libxslt
+mac {
+INCLUDEPATH += /usr/include/libxml2
+LIBS += -lxml2 -lxslt
+} else {
+PKGCONFIG += libxslt
+}
} else {
QT *= xmlpatterns
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114628] trunk/Source/WebCore
Title: [114628] trunk/Source/WebCore Revision 114628 Author vse...@chromium.org Date 2012-04-19 06:28:25 -0700 (Thu, 19 Apr 2012) Log Message Web Inspector: x-frame security errors logged when typing in the console are annoying. https://bugs.webkit.org/show_bug.cgi?id=81970 Reviewed by Pavel Feldman. Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole. Added this parameter to Runtime.callFunctionOn() and passed true in all call sites. Added this parameter to Debugger.evaluateOnCallFrame(). Added a flag to console that mutes all messages unless they have ConsoleAPI message source. This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls. * inspector/Inspector.json: * inspector/InspectorDebuggerAgent.cpp: (WebCore::asBool): (WebCore): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): * inspector/InspectorDebuggerAgent.h: (InspectorDebuggerAgent): * inspector/InspectorRuntimeAgent.cpp: (WebCore): (WebCore::setPauseOnExceptionsState): (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::callFunctionOn): (WebCore::InspectorRuntimeAgent::getProperties): * inspector/InspectorRuntimeAgent.h: (InspectorRuntimeAgent): * inspector/PageDebuggerAgent.cpp: (WebCore::PageDebuggerAgent::muteConsole): (WebCore): (WebCore::PageDebuggerAgent::unmuteConsole): * inspector/PageDebuggerAgent.h: (PageDebuggerAgent): * inspector/PageRuntimeAgent.cpp: (WebCore::PageRuntimeAgent::muteConsole): (WebCore): (WebCore::PageRuntimeAgent::unmuteConsole): * inspector/PageRuntimeAgent.h: (PageRuntimeAgent): * inspector/WorkerDebuggerAgent.cpp: (WebCore::WorkerDebuggerAgent::muteConsole): (WebCore): (WebCore::WorkerDebuggerAgent::unmuteConsole): * inspector/WorkerDebuggerAgent.h: (WorkerDebuggerAgent): * inspector/WorkerRuntimeAgent.cpp: (WebCore::WorkerRuntimeAgent::muteConsole): (WebCore): (WebCore::WorkerRuntimeAgent::unmuteConsole): * inspector/WorkerRuntimeAgent.h: (WorkerRuntimeAgent): * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.evalInInspectedWindow): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame): (WebInspector.PresentationCallFrame.prototype.evaluate): * inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.setPropertyValue): (WebInspector.RemoteObject.prototype.callFunction): (WebInspector.RemoteObject.prototype.callFunctionJSON): * inspector/front-end/WorkerManager.js: * page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::warn): (WebCore): (WebCore::Console::mute): (WebCore::Console::unmute): * page/Console.h: (Console): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/Inspector.json trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h trunk/Source/WebCore/inspector/InspectorRuntimeAgent.cpp trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp trunk/Source/WebCore/inspector/PageDebuggerAgent.h trunk/Source/WebCore/inspector/PageRuntimeAgent.cpp trunk/Source/WebCore/inspector/PageRuntimeAgent.h trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp trunk/Source/WebCore/inspector/WorkerDebuggerAgent.h trunk/Source/WebCore/inspector/WorkerRuntimeAgent.cpp trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h trunk/Source/WebCore/inspector/front-end/ConsoleView.js trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js trunk/Source/WebCore/inspector/front-end/RemoteObject.js trunk/Source/WebCore/inspector/front-end/WorkerManager.js trunk/Source/WebCore/page/Console.cpp trunk/Source/WebCore/page/Console.h Diff Modified: trunk/Source/WebCore/ChangeLog (114627 => 114628) --- trunk/Source/WebCore/ChangeLog 2012-04-19 13:11:39 UTC (rev 114627) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 13:28:25 UTC (rev 114628) @@ -1,3 +1,74 @@ +2012-04-19 Vsevolod Vlasov vse...@chromium.org + +Web Inspector: x-frame security errors logged when typing in the console are annoying. +https://bugs.webkit.org/show_bug.cgi?id=81970 + +Reviewed by Pavel Feldman. + +Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole. +Added this parameter to Runtime.callFunctionOn() and passed true in all call sites. +Added this parameter to Debugger.evaluateOnCallFrame(). +Added a flag to console that mutes all messages unless they have ConsoleAPI message source. +This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls. + +* inspector/Inspector.json: +* inspector/InspectorDebuggerAgent.cpp: +(WebCore::asBool): +(WebCore): +(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): +*
[webkit-changes] [114629] trunk/LayoutTests
Title: [114629] trunk/LayoutTests Revision 114629 Author schen...@chromium.org Date 2012-04-19 06:42:42 -0700 (Thu, 19 Apr 2012) Log Message Add expectation for flaky svg/custom/foreign-object-skew.svg Unreviewed Chromium expectations fix. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (114628 => 114629) --- trunk/LayoutTests/ChangeLog 2012-04-19 13:28:25 UTC (rev 114628) +++ trunk/LayoutTests/ChangeLog 2012-04-19 13:42:42 UTC (rev 114629) @@ -1,3 +1,11 @@ +2012-04-19 Stephen Chenney schen...@chromium.org + +Add expectation for flaky svg/custom/foreign-object-skew.svg + +Unreviewed Chromium expectations fix. + +* platform/chromium/test_expectations.txt: + 2012-04-18 Vsevolod Vlasov vse...@chromium.org Web Inspector: No response body available for cached resource requests with error status codes. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (114628 => 114629) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-19 13:28:25 UTC (rev 114628) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-19 13:42:42 UTC (rev 114629) @@ -1281,7 +1281,7 @@ BUGWK83717 MAC : svg/W3C-SVG-1.1/masking-mask-01-b.svg = IMAGE PASS BUGWK83717 MAC : svg/as-border-image/svg-as-border-image-2.html = IMAGE PASS BUGWK83717 MAC : svg/as-border-image/svg-as-border-image.html = IMAGE PASS -BUGWK83717 LEOPARD : svg/custom/foreign-object-skew.svg = IMAGE +BUGWK83717 MAC : svg/custom/foreign-object-skew.svg = IMAGE PASS BUGWK83875 LINUX : svg/text/font-size-below-point-five.svg = PASS TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114630] trunk/Source/WebCore
Title: [114630] trunk/Source/WebCore Revision 114630 Author commit-qu...@webkit.org Date 2012-04-19 07:46:33 -0700 (Thu, 19 Apr 2012) Log Message Unreviewed, rolling out r114628. http://trac.webkit.org/changeset/114628 https://bugs.webkit.org/show_bug.cgi?id=84341 Breaks EFL and GTK builds (Requested by pfeldman on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-04-19 * inspector/Inspector.json: * inspector/InspectorDebuggerAgent.cpp: (WebCore): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): * inspector/InspectorDebuggerAgent.h: (InspectorDebuggerAgent): * inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::callFunctionOn): (WebCore::InspectorRuntimeAgent::getProperties): * inspector/InspectorRuntimeAgent.h: (InspectorRuntimeAgent): * inspector/PageDebuggerAgent.cpp: * inspector/PageDebuggerAgent.h: (PageDebuggerAgent): * inspector/PageRuntimeAgent.cpp: * inspector/PageRuntimeAgent.h: (PageRuntimeAgent): * inspector/WorkerDebuggerAgent.cpp: * inspector/WorkerDebuggerAgent.h: (WorkerDebuggerAgent): * inspector/WorkerRuntimeAgent.cpp: * inspector/WorkerRuntimeAgent.h: (WorkerRuntimeAgent): * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.evalInInspectedWindow): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame): (WebInspector.PresentationCallFrame.prototype.evaluate): * inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.setPropertyValue): (WebInspector.RemoteObject.prototype.callFunction): (WebInspector.RemoteObject.prototype.callFunctionJSON): * inspector/front-end/WorkerManager.js: * page/Console.cpp: (WebCore): (WebCore::Console::addMessage): (WebCore::Console::warn): * page/Console.h: (Console): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/Inspector.json trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h trunk/Source/WebCore/inspector/InspectorRuntimeAgent.cpp trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp trunk/Source/WebCore/inspector/PageDebuggerAgent.h trunk/Source/WebCore/inspector/PageRuntimeAgent.cpp trunk/Source/WebCore/inspector/PageRuntimeAgent.h trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp trunk/Source/WebCore/inspector/WorkerDebuggerAgent.h trunk/Source/WebCore/inspector/WorkerRuntimeAgent.cpp trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h trunk/Source/WebCore/inspector/front-end/ConsoleView.js trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js trunk/Source/WebCore/inspector/front-end/RemoteObject.js trunk/Source/WebCore/inspector/front-end/WorkerManager.js trunk/Source/WebCore/page/Console.cpp trunk/Source/WebCore/page/Console.h Diff Modified: trunk/Source/WebCore/ChangeLog (114629 => 114630) --- trunk/Source/WebCore/ChangeLog 2012-04-19 13:42:42 UTC (rev 114629) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 14:46:33 UTC (rev 114630) @@ -1,3 +1,52 @@ +2012-04-19 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r114628. +http://trac.webkit.org/changeset/114628 +https://bugs.webkit.org/show_bug.cgi?id=84341 + +Breaks EFL and GTK builds (Requested by pfeldman on #webkit). + +* inspector/Inspector.json: +* inspector/InspectorDebuggerAgent.cpp: +(WebCore): +(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): +* inspector/InspectorDebuggerAgent.h: +(InspectorDebuggerAgent): +* inspector/InspectorRuntimeAgent.cpp: +(WebCore::InspectorRuntimeAgent::evaluate): +(WebCore::InspectorRuntimeAgent::callFunctionOn): +(WebCore::InspectorRuntimeAgent::getProperties): +* inspector/InspectorRuntimeAgent.h: +(InspectorRuntimeAgent): +* inspector/PageDebuggerAgent.cpp: +* inspector/PageDebuggerAgent.h: +(PageDebuggerAgent): +* inspector/PageRuntimeAgent.cpp: +* inspector/PageRuntimeAgent.h: +(PageRuntimeAgent): +* inspector/WorkerDebuggerAgent.cpp: +* inspector/WorkerDebuggerAgent.h: +(WorkerDebuggerAgent): +* inspector/WorkerRuntimeAgent.cpp: +* inspector/WorkerRuntimeAgent.h: +(WorkerRuntimeAgent): +* inspector/front-end/ConsoleView.js: +(WebInspector.ConsoleView.prototype.evalInInspectedWindow): +* inspector/front-end/DebuggerPresentationModel.js: +(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame): +(WebInspector.PresentationCallFrame.prototype.evaluate): +* inspector/front-end/RemoteObject.js: +(WebInspector.RemoteObject.prototype.setPropertyValue): +(WebInspector.RemoteObject.prototype.callFunction): +
[webkit-changes] [114631] trunk/Source/WebKit2
Title: [114631] trunk/Source/WebKit2
Revision 114631
Author commit-qu...@webkit.org
Date 2012-04-19 08:26:32 -0700 (Thu, 19 Apr 2012)
Log Message
[Qt][WK2] Zoom out on the second double click does not always scale right.
https://bugs.webkit.org/show_bug.cgi?id=84332
Patch by Zalan Bujtas zbuj...@gmail.com on 2012-04-19
Reviewed by Simon Hausmann.
Zoom out to the minimum scale value instead of the fixed 1.
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (114630 => 114631)
--- trunk/Source/WebKit2/ChangeLog 2012-04-19 14:46:33 UTC (rev 114630)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-19 15:26:32 UTC (rev 114631)
@@ -1,3 +1,15 @@
+2012-04-19 Zalan Bujtas zbuj...@gmail.com
+
+[Qt][WK2] Zoom out on the second double click does not always scale right.
+https://bugs.webkit.org/show_bug.cgi?id=84332
+
+Reviewed by Simon Hausmann.
+
+Zoom out to the minimum scale value instead of the fixed 1.
+
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
+
2012-04-18 Jer Noble jer.no...@apple.com
Full Screen mode does not preserve CALayer ordering after exiting.
Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp (114630 => 114631)
--- trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp 2012-04-19 14:46:33 UTC (rev 114630)
+++ trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp 2012-04-19 15:26:32 UTC (rev 114631)
@@ -370,7 +370,7 @@
// Zoom back out on a second double click, but still center on the new touch point.
if (m_zoomedToArea) {
m_zoomedToArea = false;
-endItemScale = 1.0;
+endItemScale = itemScaleFromCSS(m_minimumScale);
} else
m_zoomedToArea = true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114632] trunk/Source/WebCore
Title: [114632] trunk/Source/WebCore Revision 114632 Author vse...@chromium.org Date 2012-04-19 08:34:31 -0700 (Thu, 19 Apr 2012) Log Message Web Inspector: x-frame security errors logged when typing in the console are annoying. https://bugs.webkit.org/show_bug.cgi?id=81970 Reviewed by Pavel Feldman. Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole. Added this parameter to Runtime.callFunctionOn() and passed true in all call sites. Added this parameter to Debugger.evaluateOnCallFrame(). Added a flag to console that mutes all messages unless they have ConsoleAPI message source. This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls. * inspector/Inspector.json: * inspector/InspectorDebuggerAgent.cpp: (WebCore::asBool): (WebCore): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): * inspector/InspectorDebuggerAgent.h: (InspectorDebuggerAgent): * inspector/InspectorRuntimeAgent.cpp: (WebCore): (WebCore::setPauseOnExceptionsState): (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::callFunctionOn): (WebCore::InspectorRuntimeAgent::getProperties): * inspector/InspectorRuntimeAgent.h: (InspectorRuntimeAgent): * inspector/PageDebuggerAgent.cpp: (WebCore::PageDebuggerAgent::muteConsole): (WebCore): (WebCore::PageDebuggerAgent::unmuteConsole): * inspector/PageDebuggerAgent.h: (PageDebuggerAgent): * inspector/PageRuntimeAgent.cpp: (WebCore::PageRuntimeAgent::muteConsole): (WebCore): (WebCore::PageRuntimeAgent::unmuteConsole): * inspector/PageRuntimeAgent.h: (PageRuntimeAgent): * inspector/WorkerDebuggerAgent.cpp: (WebCore::WorkerDebuggerAgent::muteConsole): (WebCore): (WebCore::WorkerDebuggerAgent::unmuteConsole): * inspector/WorkerDebuggerAgent.h: (WorkerDebuggerAgent): * inspector/WorkerRuntimeAgent.cpp: (WebCore::WorkerRuntimeAgent::muteConsole): (WebCore): (WebCore::WorkerRuntimeAgent::unmuteConsole): * inspector/WorkerRuntimeAgent.h: (WorkerRuntimeAgent): * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.evalInInspectedWindow): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame): (WebInspector.PresentationCallFrame.prototype.evaluate): * inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.setPropertyValue): (WebInspector.RemoteObject.prototype.callFunction): (WebInspector.RemoteObject.prototype.callFunctionJSON): * inspector/front-end/WorkerManager.js: * page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::warn): (WebCore): (WebCore::Console::mute): (WebCore::Console::unmute): * page/Console.h: (Console): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/Inspector.json trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h trunk/Source/WebCore/inspector/InspectorRuntimeAgent.cpp trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp trunk/Source/WebCore/inspector/PageDebuggerAgent.h trunk/Source/WebCore/inspector/PageRuntimeAgent.cpp trunk/Source/WebCore/inspector/PageRuntimeAgent.h trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp trunk/Source/WebCore/inspector/WorkerDebuggerAgent.h trunk/Source/WebCore/inspector/WorkerRuntimeAgent.cpp trunk/Source/WebCore/inspector/WorkerRuntimeAgent.h trunk/Source/WebCore/inspector/front-end/ConsoleView.js trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js trunk/Source/WebCore/inspector/front-end/RemoteObject.js trunk/Source/WebCore/inspector/front-end/WorkerManager.js trunk/Source/WebCore/page/Console.cpp trunk/Source/WebCore/page/Console.h Diff Modified: trunk/Source/WebCore/ChangeLog (114631 => 114632) --- trunk/Source/WebCore/ChangeLog 2012-04-19 15:26:32 UTC (rev 114631) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 15:34:31 UTC (rev 114632) @@ -1,3 +1,74 @@ +2012-04-19 Vsevolod Vlasov vse...@chromium.org + +Web Inspector: x-frame security errors logged when typing in the console are annoying. +https://bugs.webkit.org/show_bug.cgi?id=81970 + +Reviewed by Pavel Feldman. + +Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole. +Added this parameter to Runtime.callFunctionOn() and passed true in all call sites. +Added this parameter to Debugger.evaluateOnCallFrame(). +Added a flag to console that mutes all messages unless they have ConsoleAPI message source. +This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls. + +* inspector/Inspector.json: +* inspector/InspectorDebuggerAgent.cpp: +(WebCore::asBool): +(WebCore): +(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): +*
[webkit-changes] [114633] trunk
Title: [114633] trunk
Revision 114633
Author commit-qu...@webkit.org
Date 2012-04-19 08:37:16 -0700 (Thu, 19 Apr 2012)
Log Message
[EFL] dispatchDidCancelClientRedirect needs implementation
https://bugs.webkit.org/show_bug.cgi?id=83669
Patch by Christophe Dumez christophe.du...@intel.com on 2012-04-19
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Emit a new redirect,cancelled signal on the ewk_frame when a
redirect is cancelled. This is needed by EFL's DumpRenderTree to dump
frame load callbacks information.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidCancelClientRedirect):
* ewk/ewk_frame.cpp:
(ewk_frame_redirect_cancelled):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:
Tools:
Catch the new ewk_frame redirect,cancelled signal in EFL's DRT and
and print out information that is expected by several test cases if
LayoutTestController's dumpFrameLoadCallback() returns true.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameRedirectCancelled):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
trunk/Source/WebKit/efl/ewk/ewk_frame.h
trunk/Source/WebKit/efl/ewk/ewk_private.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.h
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (114632 => 114633)
--- trunk/Source/WebKit/efl/ChangeLog 2012-04-19 15:34:31 UTC (rev 114632)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-04-19 15:37:16 UTC (rev 114633)
@@ -1,3 +1,21 @@
+2012-04-19 Christophe Dumez christophe.du...@intel.com
+
+[EFL] dispatchDidCancelClientRedirect needs implementation
+https://bugs.webkit.org/show_bug.cgi?id=83669
+
+Reviewed by Antonio Gomes.
+
+Emit a new redirect,cancelled signal on the ewk_frame when a
+redirect is cancelled. This is needed by EFL's DumpRenderTree to dump
+frame load callbacks information.
+
+* WebCoreSupport/FrameLoaderClientEfl.cpp:
+(WebCore::FrameLoaderClientEfl::dispatchDidCancelClientRedirect):
+* ewk/ewk_frame.cpp:
+(ewk_frame_redirect_cancelled):
+* ewk/ewk_frame.h:
+* ewk/ewk_private.h:
+
2012-04-17 Christophe Dumez christophe.du...@intel.com
EFL's LayoutTestController does not implement callShouldCloseOnWebView
Modified: trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp (114632 => 114633)
--- trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp 2012-04-19 15:34:31 UTC (rev 114632)
+++ trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp 2012-04-19 15:37:16 UTC (rev 114633)
@@ -548,7 +548,7 @@
void FrameLoaderClientEfl::dispatchDidCancelClientRedirect()
{
-notImplemented();
+ewk_frame_redirect_cancelled(m_frame);
}
void FrameLoaderClientEfl::dispatchWillPerformClientRedirect(const KURL, double, double)
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (114632 => 114633)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2012-04-19 15:34:31 UTC (rev 114632)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2012-04-19 15:37:16 UTC (rev 114633)
@@ -1203,6 +1203,19 @@
/**
* @internal
+ * Reports cancellation of a client redirect.
+ *
+ * @param ewkFrame Frame.
+ *
+ * Emits signal: redirect,cancelled
+ */
+void ewk_frame_redirect_cancelled(Evas_Object* ewkFrame)
+{
+evas_object_smart_callback_call(ewkFrame, redirect,cancelled, 0);
+}
+
+/**
+ * @internal
* Reports a resource will be requested. User may override behavior of webkit by
* changing values in @param request.
*
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.h (114632 => 114633)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.h 2012-04-19 15:34:31 UTC (rev 114632)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.h 2012-04-19 15:37:16 UTC (rev 114633)
@@ -56,6 +56,7 @@
* - mixedcontent,displayed, void: frame has loaded and displayed mixed content.
* - mixedcontent,run, void: frame has loaded and run mixed content.
* - navigation,first, void: first navigation was occurred.
+ * - redirect,cancelled, void: client redirect was cancelled.
* - resource,request,new, Ewk_Frame_Resource_Request*: reports that
*there's a new resource request.
* - resource,request,willsend, Ewk_Frame_Resource_Request*: a resource will
Modified: trunk/Source/WebKit/efl/ewk/ewk_private.h (114632 => 114633)
--- trunk/Source/WebKit/efl/ewk/ewk_private.h 2012-04-19 15:34:31 UTC (rev 114632)
+++ trunk/Source/WebKit/efl/ewk/ewk_private.h 2012-04-19 15:37:16 UTC (rev 114633)
@@ -222,6 +222,7 @@
void ewk_frame_load_error(Evas_Object* ewkFrame, const char* errorDomain, int errorCode, bool isCancellation, const char* errorDescription, const char* failingUrl);
[webkit-changes] [114634] trunk/Source/WebKit/chromium
Title: [114634] trunk/Source/WebKit/chromium
Revision 114634
Author pilg...@chromium.org
Date 2012-04-19 08:51:26 -0700 (Thu, 19 Apr 2012)
Log Message
[Chromium] Call audioHardwareSampleRate directly
https://bugs.webkit.org/show_bug.cgi?id=84335
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestination::hardwareSampleRate):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (114633 => 114634)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 15:37:16 UTC (rev 114633)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 15:51:26 UTC (rev 114634)
@@ -1,3 +1,15 @@
+2012-04-19 Mark Pilgrim pilg...@chromium.org
+
+[Chromium] Call audioHardwareSampleRate directly
+https://bugs.webkit.org/show_bug.cgi?id=84335
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/AudioDestinationChromium.cpp:
+(WebCore::AudioDestination::hardwareSampleRate):
+
2012-04-18 Nico Weber tha...@chromium.org
[chromium/mac] Fix build.
Modified: trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp (114633 => 114634)
--- trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp 2012-04-19 15:37:16 UTC (rev 114633)
+++ trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp 2012-04-19 15:51:26 UTC (rev 114634)
@@ -35,6 +35,8 @@
#include WebKit.h
#include platform/WebKitPlatformSupport.h
+#include public/Platform.h
+
using namespace WebKit;
namespace WebCore {
@@ -102,7 +104,7 @@
float AudioDestination::hardwareSampleRate()
{
-return static_castfloat(webKitPlatformSupport()-audioHardwareSampleRate());
+return static_castfloat(WebKit::Platform::current()-audioHardwareSampleRate());
}
// Pulls on our provider to get the rendered audio stream.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114635] trunk/Source
Title: [114635] trunk/Source
Revision 114635
Author pilg...@chromium.org
Date 2012-04-19 08:57:26 -0700 (Thu, 19 Apr 2012)
Log Message
[Chromium] Call sampleGamepads directly
https://bugs.webkit.org/show_bug.cgi?id=84339
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
* platform/chromium/GamepadsChromium.cpp:
(WebCore::sampleGamepads):
* platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::injectIDBKeyIntoSerializedValue):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/GamepadsChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114634 => 114635)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 15:51:26 UTC (rev 114634)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 15:57:26 UTC (rev 114635)
@@ -1,3 +1,18 @@
+2012-04-19 Mark Pilgrim pilg...@chromium.org
+
+[Chromium] Call sampleGamepads directly
+https://bugs.webkit.org/show_bug.cgi?id=84339
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/GamepadsChromium.cpp:
+(WebCore::sampleGamepads):
+* platform/chromium/PlatformSupport.h:
+(WebCore):
+(PlatformSupport):
+
2012-04-19 Vsevolod Vlasov vse...@chromium.org
Web Inspector: x-frame security errors logged when typing in the console are annoying.
Modified: trunk/Source/WebCore/platform/chromium/GamepadsChromium.cpp (114634 => 114635)
--- trunk/Source/WebCore/platform/chromium/GamepadsChromium.cpp 2012-04-19 15:51:26 UTC (rev 114634)
+++ trunk/Source/WebCore/platform/chromium/GamepadsChromium.cpp 2012-04-19 15:57:26 UTC (rev 114635)
@@ -29,15 +29,34 @@
#if ENABLE(GAMEPAD)
#include GamepadList.h
-#include PlatformSupport.h
+#include public/Platform.h
+
namespace WebCore {
class GamepadList;
void sampleGamepads(GamepadList* into)
{
-PlatformSupport::sampleGamepads(into);
+WebKit::WebGamepads gamepads;
+
+WebKit::Platform::current()-sampleGamepads(gamepads);
+
+for (unsigned i = 0; i WebKit::WebGamepads::itemsLengthCap; ++i) {
+WebKit::WebGamepad webGamepad = gamepads.items[i];
+if (i gamepads.length webGamepad.connected) {
+RefPtrGamepad gamepad = into-item(i);
+if (!gamepad)
+gamepad = Gamepad::create();
+gamepad-id(webGamepad.id);
+gamepad-index(i);
+gamepad-timestamp(webGamepad.timestamp);
+gamepad-axes(webGamepad.axesLength, webGamepad.axes);
+gamepad-buttons(webGamepad.buttonsLength, webGamepad.buttons);
+into-set(i, gamepad);
+} else
+into-set(i, 0);
+}
}
}
Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (114634 => 114635)
--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-04-19 15:51:26 UTC (rev 114634)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-04-19 15:57:26 UTC (rev 114635)
@@ -72,7 +72,6 @@
class Cursor;
class Document;
class Frame;
-class GamepadList;
class GeolocationServiceBridge;
class GeolocationServiceChromium;
class GraphicsContext;
@@ -188,9 +187,6 @@
// Injects key via keyPath into value. Returns true on success.
static PassRefPtrSerializedScriptValue injectIDBKeyIntoSerializedValue(PassRefPtrIDBKey, PassRefPtrSerializedScriptValue, const String keyPath);
-// Gamepad ---
-static void sampleGamepads(GamepadList* into);
-
// _javascript_ -
static void notifyJSOutOfMemory(Frame*);
static bool allowScriptDespiteSettings(const KURL documentURL);
Modified: trunk/Source/WebKit/chromium/ChangeLog (114634 => 114635)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 15:51:26 UTC (rev 114634)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 15:57:26 UTC (rev 114635)
@@ -1,5 +1,17 @@
2012-04-19 Mark Pilgrim pilg...@chromium.org
+[Chromium] Call sampleGamepads directly
+https://bugs.webkit.org/show_bug.cgi?id=84339
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/PlatformSupport.cpp:
+(WebCore::PlatformSupport::injectIDBKeyIntoSerializedValue):
+
+2012-04-19 Mark Pilgrim pilg...@chromium.org
+
[Chromium] Call audioHardwareSampleRate directly
https://bugs.webkit.org/show_bug.cgi?id=84335
Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (114634 => 114635)
--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp 2012-04-19 15:51:26 UTC (rev 114634)
+++
[webkit-changes] [114636] trunk/Source/WebCore
Title: [114636] trunk/Source/WebCore
Revision 114636
Author vse...@chromium.org
Date 2012-04-19 09:16:45 -0700 (Thu, 19 Apr 2012)
Log Message
Follow up to r114632: build fix.
* inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114635 => 114636)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 15:57:26 UTC (rev 114635)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 16:16:45 UTC (rev 114636)
@@ -1,3 +1,11 @@
+2012-04-19 Vsevolod Vlasov vse...@chromium.org
+
+Follow up to r114632: build fix.
+
+* inspector/InspectorDebuggerAgent.cpp:
+(WebCore):
+(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
+
2012-04-19 Mark Pilgrim pilg...@chromium.org
[Chromium] Call sampleGamepads directly
Modified: trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp (114635 => 114636)
--- trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp 2012-04-19 15:57:26 UTC (rev 114635)
+++ trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp 2012-04-19 16:16:45 UTC (rev 114636)
@@ -59,11 +59,6 @@
const char* InspectorDebuggerAgent::backtraceObjectGroup = backtrace-object-group;
-static bool asBool(const bool* const b)
-{
-return b ? *b : false;
-}
-
InspectorDebuggerAgent::InspectorDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorState* inspectorState, InjectedScriptManager* injectedScriptManager)
: InspectorBaseAgentInspectorDebuggerAgent(Debugger, instrumentingAgents, inspectorState)
, m_injectedScriptManager(injectedScriptManager)
@@ -490,15 +485,15 @@
}
ScriptDebugServer::PauseOnExceptionsState previousPauseOnExceptionsState = scriptDebugServer().pauseOnExceptionsState();
-if (asBool(doNotPauseOnExceptionsAndMuteConsole)) {
+if (doNotPauseOnExceptionsAndMuteConsole ? *doNotPauseOnExceptionsAndMuteConsole : false) {
if (previousPauseOnExceptionsState != ScriptDebugServer::DontPauseOnExceptions)
scriptDebugServer().setPauseOnExceptionsState(ScriptDebugServer::DontPauseOnExceptions);
muteConsole();
}
-injectedScript.evaluateOnCallFrame(errorString, m_currentCallStack, callFrameId, _expression_, objectGroup ? *objectGroup : , asBool(includeCommandLineAPI), asBool(returnByValue), result, wasThrown);
+injectedScript.evaluateOnCallFrame(errorString, m_currentCallStack, callFrameId, _expression_, objectGroup ? *objectGroup : , includeCommandLineAPI ? *includeCommandLineAPI : false, returnByValue ? *returnByValue : false, result, wasThrown);
-if (asBool(doNotPauseOnExceptionsAndMuteConsole)) {
+if (doNotPauseOnExceptionsAndMuteConsole ? *doNotPauseOnExceptionsAndMuteConsole : false) {
unmuteConsole();
if (scriptDebugServer().pauseOnExceptionsState() != previousPauseOnExceptionsState)
scriptDebugServer().setPauseOnExceptionsState(previousPauseOnExceptionsState);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114637] trunk/Source/WebCore
Title: [114637] trunk/Source/WebCore Revision 114637 Author pfeld...@chromium.org Date 2012-04-19 09:19:59 -0700 (Thu, 19 Apr 2012) Log Message Web Inspector: introduce styles panel as an experiment https://bugs.webkit.org/show_bug.cgi?id=84331 Reviewed by Vsevolod Vlasov. This change introduces new Styles panel that looks like the Scripts one, but operates stylesheets. This is happening under the experimental flag. * English.lproj/localizedStrings.js: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/compile-front-end.py: * inspector/front-end/Panel.js: (WebInspector.Panel.prototype.showAnchorLocation): * inspector/front-end/ResourceView.js: (WebInspector.EditableResourceSourceFrame.prototype.didEditContent): * inspector/front-end/ScriptsNavigator.js: (WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown): * inspector/front-end/ScriptsPanel.js: * inspector/front-end/Settings.js: (WebInspector.ExperimentsSettings): * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._clearLineHighlight): * inspector/front-end/StylesPanel.js: Added. (WebInspector.StylesPanel): (WebInspector.StylesPanel.prototype.wasShown): (WebInspector.StylesPanel.prototype._initialize): (WebInspector.StylesPanel.prototype._populateResourceTree.populateFrame): (WebInspector.StylesPanel.prototype._populateResourceTree): (WebInspector.StylesPanel.prototype._resourceAdded): (WebInspector.StylesPanel.prototype._reset): (WebInspector.StylesPanel.prototype._cachedResourcesLoaded): (WebInspector.StylesPanel.prototype.get toolbarItemLabel): (WebInspector.StylesPanel.prototype.viewForFile.get if): (WebInspector.StylesPanel.prototype.viewForFile): (WebInspector.StylesPanel.prototype._textEdited): (WebInspector.StylesPanel.prototype._scriptSelected): (WebInspector.StylesPanel.prototype._showFile): (WebInspector.StylesPanel.prototype.canShowAnchorLocation): * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype._createRuleOriginNode): * inspector/front-end/TabbedEditorContainer.js: (WebInspector.TabbedEditorContainer): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: * inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector._showAnchorLocationInPanel): * inspector/front-end/scriptsPanel.css: * inspector/front-end/splitView.css: (.sidebar-overlay): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/compile-front-end.py trunk/Source/WebCore/inspector/front-end/Panel.js trunk/Source/WebCore/inspector/front-end/ResourceView.js trunk/Source/WebCore/inspector/front-end/ScriptsNavigator.js trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js trunk/Source/WebCore/inspector/front-end/Settings.js trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js trunk/Source/WebCore/inspector/front-end/WebKit.qrc trunk/Source/WebCore/inspector/front-end/inspector.html trunk/Source/WebCore/inspector/front-end/inspector.js trunk/Source/WebCore/inspector/front-end/scriptsPanel.css trunk/Source/WebCore/inspector/front-end/splitView.css Added Paths trunk/Source/WebCore/inspector/front-end/StylesPanel.js Diff Modified: trunk/Source/WebCore/ChangeLog (114636 => 114637) --- trunk/Source/WebCore/ChangeLog 2012-04-19 16:16:45 UTC (rev 114636) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 16:19:59 UTC (rev 114637) @@ -1,3 +1,58 @@ +2012-04-19 Pavel Feldman pfeld...@chromium.org + +Web Inspector: introduce styles panel as an experiment +https://bugs.webkit.org/show_bug.cgi?id=84331 + +Reviewed by Vsevolod Vlasov. + +This change introduces new Styles panel that looks like the Scripts one, +but operates stylesheets. This is happening under the experimental flag. + +* English.lproj/localizedStrings.js: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* inspector/compile-front-end.py: +* inspector/front-end/Panel.js: +(WebInspector.Panel.prototype.showAnchorLocation): +* inspector/front-end/ResourceView.js: +(WebInspector.EditableResourceSourceFrame.prototype.didEditContent): +* inspector/front-end/ScriptsNavigator.js: +(WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown): +* inspector/front-end/ScriptsPanel.js: +* inspector/front-end/Settings.js: +(WebInspector.ExperimentsSettings): +* inspector/front-end/SourceFrame.js: +(WebInspector.SourceFrame.prototype._clearLineHighlight): +* inspector/front-end/StylesPanel.js: Added. +(WebInspector.StylesPanel): +(WebInspector.StylesPanel.prototype.wasShown): +
[webkit-changes] [114638] branches/chromium/1084/Source/WebCore/inspector/ InspectorIndexedDBAgent.cpp
Title: [114638] branches/chromium/1084/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp
Revision 114638
Author vse...@chromium.org
Date 2012-04-19 09:20:08 -0700 (Thu, 19 Apr 2012)
Log Message
Merge 114373 - Web Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
https://bugs.webkit.org/show_bug.cgi?id=84035
Reviewed by Pavel Feldman.
Added a check that m_idbCursor is not null before calling postSuccessHandlerCallback() on it.
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
TBR=vse...@chromium.org
BUG=121578
Review URL: https://chromiumcodereview.appspot.com/10125008
Modified Paths
branches/chromium/1084/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp
Diff
Modified: branches/chromium/1084/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp (114637 => 114638)
--- branches/chromium/1084/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2012-04-19 16:19:59 UTC (rev 114637)
+++ branches/chromium/1084/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2012-04-19 16:20:08 UTC (rev 114638)
@@ -465,7 +465,8 @@
if (!m_frontendProvider-frontend())
return;
-m_idbCursor-postSuccessHandlerCallback();
+if (m_idbCursor)
+m_idbCursor-postSuccessHandlerCallback();
m_idbTransaction-didCompleteTaskEvents();
switch (m_cursorType) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114640] trunk
Title: [114640] trunk
Revision 114640
Author commit-qu...@webkit.org
Date 2012-04-19 09:27:25 -0700 (Thu, 19 Apr 2012)
Log Message
Display a TextTrackCue when snap-to-lines flag is not set
https://bugs.webkit.org/show_bug.cgi?id=79750
Patch by Victor Carbune vcarb...@adobe.com on 2012-04-19
Reviewed by Eric Carlson.
Source/WebCore:
Support for positioning of a cue on top of the video element when snap-to-lines is not set.
Test: media/track/track-cue-rendering-snap-to-lines-not-set.html
* css/mediaControls.css:
(video::-webkit-media-text-track-container): Marked the container as
flexible box in order to use all the available space on top of the controls.
(video::-webkit-media-text-track-background): Added background default settings.
(video::-webkit-media-text-track-display): Added default position.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Updated comments.
* html/track/TextTrackCue.cpp:
(WebCore):
(WebCore::TextTrackCue::TextTrackCue): Updated constructor to calculate
the computed line position.
(WebCore::TextTrackCue::setLine): Updated call to calculate the computed line
position.
(WebCore::TextTrackCue::setPosition):
(WebCore::TextTrackCue::calculateComputedLinePosition): Partial calculation of the
computated line position.
(WebCore::TextTrackCue::calculateDisplayParameters): Updated display parameter computations
required by the spec.
(WebCore::TextTrackCue::getDisplayTree): Updated positioning attributes when snap-to-lines
is not set. Added extra anonymous box for background, because setting position:absolute
on the display tree determines the background to cover the whole block, not just inline.
(WebCore::TextTrackCue::getPositionCoordinates): Determine coordinates as required by the spec.
* html/track/TextTrackCue.h:
(TextTrackCue):
LayoutTests:
Added tests to support positioning of cues when snap-to-lines set.
* media/media-controls.js:
(textTrackDisplayElement): Added an extra parameter, to return the display
box of the N-th active cue.
* media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt: Added.
* media/track/track-cue-rendering-expected.txt: Updated background color check.
* media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Added.
* media/track/track-cue-rendering-snap-to-lines-not-set.html: Added.
* media/track/track-cue-rendering.html: Updated background color check.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/media-controls.js
trunk/LayoutTests/media/track/track-cue-rendering-expected.txt
trunk/LayoutTests/media/track/track-cue-rendering.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mediaControls.css
trunk/Source/WebCore/html/shadow/MediaControlElements.cpp
trunk/Source/WebCore/html/track/TextTrackCue.cpp
trunk/Source/WebCore/html/track/TextTrackCue.h
Added Paths
trunk/LayoutTests/media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt
trunk/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt
trunk/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html
Diff
Modified: trunk/LayoutTests/ChangeLog (114639 => 114640)
--- trunk/LayoutTests/ChangeLog 2012-04-19 16:23:44 UTC (rev 114639)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 16:27:25 UTC (rev 114640)
@@ -1,3 +1,21 @@
+2012-04-19 Victor Carbune vcarb...@adobe.com
+
+Display a TextTrackCue when snap-to-lines flag is not set
+https://bugs.webkit.org/show_bug.cgi?id=79750
+
+Reviewed by Eric Carlson.
+
+Added tests to support positioning of cues when snap-to-lines set.
+
+* media/media-controls.js:
+(textTrackDisplayElement): Added an extra parameter, to return the display
+box of the N-th active cue.
+* media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt: Added.
+* media/track/track-cue-rendering-expected.txt: Updated background color check.
+* media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Added.
+* media/track/track-cue-rendering-snap-to-lines-not-set.html: Added.
+* media/track/track-cue-rendering.html: Updated background color check.
+
2012-04-19 Filip Pizlo fpi...@apple.com
JSC testing should have complete coverage over typed array types
Modified: trunk/LayoutTests/media/media-controls.js (114639 => 114640)
--- trunk/LayoutTests/media/media-controls.js 2012-04-19 16:23:44 UTC (rev 114639)
+++ trunk/LayoutTests/media/media-controls.js 2012-04-19 16:27:25 UTC (rev 114640)
@@ -32,7 +32,7 @@
return new Array(x, y);
}
-function textTrackDisplayElement(parentElement, id)
+function textTrackDisplayElement(parentElement, id, cueNumber)
{
var textTrackContainerID = -webkit-media-text-track-container;
var containerElement = mediaControlsElement(internals.shadowRoot(parentElement).firstChild, -webkit-media-text-track-container);
@@ -49,5 +49,13 @@
if (!displayElement)
[webkit-changes] [114641] trunk/Source
Title: [114641] trunk/Source
Revision 114641
Author pilg...@chromium.org
Date 2012-04-19 09:40:28 -0700 (Thu, 19 Apr 2012)
Log Message
[Chromium] Call mimeRegistry directly
https://bugs.webkit.org/show_bug.cgi?id=84334
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::layoutTestMode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114640 => 114641)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 16:27:25 UTC (rev 114640)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 16:40:28 UTC (rev 114641)
@@ -1,3 +1,22 @@
+2012-04-19 Mark Pilgrim pilg...@chromium.org
+
+[Chromium] Call mimeRegistry directly
+https://bugs.webkit.org/show_bug.cgi?id=84334
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/MIMETypeRegistryChromium.cpp:
+(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
+(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
+(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
+(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
+(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
+(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
2012-04-19 Victor Carbune vcarb...@adobe.com
Display a TextTrackCue when snap-to-lines flag is not set
Modified: trunk/Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp (114640 => 114641)
--- trunk/Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp 2012-04-19 16:27:25 UTC (rev 114640)
+++ trunk/Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp 2012-04-19 16:40:28 UTC (rev 114641)
@@ -32,26 +32,28 @@
#include MIMETypeRegistry.h
#include MediaPlayer.h
-#include PlatformSupport.h
#include PluginDataChromium.h
+
+#include public/Platform.h
+#include public/WebMimeRegistry.h
#include wtf/text/CString.h
// NOTE: Unlike other ports, we don't use the shared implementation in
// MIMETypeRegistry.cpp. Instead, we need to route most functions via
-// the PlatformSupport to the embedder.
+// Platform.h to the embedder.
namespace WebCore {
String MIMETypeRegistry::getMIMETypeForExtension(const String ext)
{
-return PlatformSupport::mimeTypeForExtension(ext);
+return WebKit::Platform::current()-mimeRegistry()-mimeTypeForExtension(ext);
}
#if ENABLE(FILE_SYSTEM)
String MIMETypeRegistry::getWellKnownMIMETypeForExtension(const String ext)
{
// This method must be thread safe and should not consult the OS/registry.
-return PlatformSupport::wellKnownMimeTypeForExtension(ext);
+return WebKit::Platform::current()-mimeRegistry()-wellKnownMimeTypeForExtension(ext);
}
#endif
@@ -63,7 +65,7 @@
// FIXME: Is this really necessary??
String mimeType = type.substring(0, static_castunsigned(type.find(';')));
-String ext = PlatformSupport::preferredExtensionForMIMEType(type);
+String ext = WebKit::Platform::current()-mimeRegistry()-preferredExtensionForMIMEType(type);
if (!ext.isEmpty() ext[0] == '.')
ext = ext.substring(1);
@@ -89,7 +91,8 @@
bool MIMETypeRegistry::isSupportedImageMIMEType(const String mimeType)
{
-return PlatformSupport::isSupportedImageMIMEType(mimeType);
+return WebKit::Platform::current()-mimeRegistry()-supportsImageMIMEType(mimeType)
+!= WebKit::WebMimeRegistry::IsNotSupported;
}
bool MIMETypeRegistry::isSupportedImageResourceMIMEType(const String mimeType)
@@ -110,12 +113,14 @@
bool MIMETypeRegistry::isSupportedJavaScriptMIMEType(const String mimeType)
{
-return PlatformSupport::isSupportedJavaScriptMIMEType(mimeType);
+return WebKit::Platform::current()-mimeRegistry()-supportsJavaScriptMIMEType(mimeType)
+!= WebKit::WebMimeRegistry::IsNotSupported;
}
bool MIMETypeRegistry::isSupportedNonImageMIMEType(const String mimeType)
{
-return PlatformSupport::isSupportedNonImageMIMEType(mimeType);
+return WebKit::Platform::current()-mimeRegistry()-supportsNonImageMIMEType(mimeType)
+
[webkit-changes] [114643] branches/chromium/1084/Source/WebKit/chromium/src/ WebPluginContainerImpl.cpp
Title: [114643] branches/chromium/1084/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp Revision 114643 Author jsc...@chromium.org Date 2012-04-19 09:53:14 -0700 (Thu, 19 Apr 2012) Log Message Merge 114275 BUG=27086 TBR=ray...@chromium.org Review URL: https://chromiumcodereview.appspot.com/10113012 Modified Paths branches/chromium/1084/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp Diff Modified: branches/chromium/1084/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (114642 => 114643) --- branches/chromium/1084/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-04-19 16:40:59 UTC (rev 114642) +++ branches/chromium/1084/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-04-19 16:53:14 UTC (rev 114643) @@ -453,10 +453,10 @@ // hitTestResultAtPoint() takes a padding rectangle. // FIXME: We'll be off by 1 when the width or height is even. -IntRect windowRect = convertToContainingWindow(static_castIntRect(rect)); -LayoutPoint center = windowRect.center(); +IntRect documentRect(x() + rect.x, y() + rect.y, rect.width, rect.height); +LayoutPoint center = documentRect.center(); // Make the rect we're checking (the point surrounded by padding rects) contained inside the requested rect. (Note that -1/2 is 0.) -LayoutSize padding((windowRect.width() - 1) / 2, (windowRect.height() - 1) / 2); +LayoutSize padding((documentRect.width() - 1) / 2, (documentRect.height() - 1) / 2); HitTestResult result = page-mainFrame()-eventHandler()-hitTestResultAtPoint(center, false, false, DontHitTestScrollbars, HitTestRequest::ReadOnly | HitTestRequest::Active, padding); const HitTestResult::NodeSet nodes = result.rectBasedTestResult(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114644] trunk
Title: [114644] trunk
Revision 114644
Author vse...@chromium.org
Date 2012-04-19 09:59:34 -0700 (Thu, 19 Apr 2012)
Log Message
Unreviewed, rolling out r114626.
http://trac.webkit.org/changeset/114626
https://bugs.webkit.org/show_bug.cgi?id=84349
caused new assertions in debug builds (Requested by smfr_ on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-04-19
Source/WebCore:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::responseReceived):
* inspector/NetworkResourcesData.h:
(ResourceData):
(NetworkResourcesData):
* inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):
LayoutTests:
* http/tests/inspector/network/network-image-404-expected.txt: Removed.
* http/tests/inspector/network/network-image-404.html: Removed.
* http/tests/inspector/network/resources/404.php: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp
trunk/Source/WebCore/inspector/NetworkResourcesData.cpp
trunk/Source/WebCore/inspector/NetworkResourcesData.h
trunk/Source/WebCore/inspector/front-end/RequestView.js
Removed Paths
trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-image-404.html
trunk/LayoutTests/http/tests/inspector/network/resources/404.php
Diff
Modified: trunk/LayoutTests/ChangeLog (114643 => 114644)
--- trunk/LayoutTests/ChangeLog 2012-04-19 16:53:14 UTC (rev 114643)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 16:59:34 UTC (rev 114644)
@@ -1,3 +1,16 @@
+2012-04-19 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r114626.
+http://trac.webkit.org/changeset/114626
+https://bugs.webkit.org/show_bug.cgi?id=84349
+
+caused new assertions in debug builds (Requested by smfr_ on
+#webkit).
+
+* http/tests/inspector/network/network-image-404-expected.txt: Removed.
+* http/tests/inspector/network/network-image-404.html: Removed.
+* http/tests/inspector/network/resources/404.php: Removed.
+
2012-04-19 Victor Carbune vcarb...@adobe.com
Display a TextTrackCue when snap-to-lines flag is not set
Deleted: trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt (114643 => 114644)
--- trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt 2012-04-19 16:53:14 UTC (rev 114643)
+++ trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt 2012-04-19 16:59:34 UTC (rev 114644)
@@ -1,9 +0,0 @@
-CONSOLE MESSAGE: line 15: Done.
-Tests content is available for failed image request.
-
-Bug 84265
-http://127.0.0.1:8000/inspector/network/resources/404.php
-resource.type: image
-resource.content before requesting content: undefined
-resource.content after requesting content: 404 - resource was not found.
-
Deleted: trunk/LayoutTests/http/tests/inspector/network/network-image-404.html (114643 => 114644)
--- trunk/LayoutTests/http/tests/inspector/network/network-image-404.html 2012-04-19 16:53:14 UTC (rev 114643)
+++ trunk/LayoutTests/http/tests/inspector/network/network-image-404.html 2012-04-19 16:59:34 UTC (rev 114644)
@@ -1,54 +0,0 @@
-html
-head
-script src=""
-script src=""
-script
-function loadData()
-{
-var image = new Image();
-image.src = ""
-image._onerror_ = resourceLoaded;
-}
-
-function resourceLoaded()
-{
-console.log(Done.);
-}
-
-function test()
-{
-// Since this test could be run together with other inspector backend cache
-// tests, we need to reset size limits to default ones.
-InspectorTest.resetInspectorResourcesData(step1);
-
-function step1()
-{
-InspectorTest.addConsoleSniffer(step2);
-InspectorTest.evaluateInPage(loadData());
-}
-
-function step2()
-{
-var request1 = WebInspector.panels.network.requests[WebInspector.panels.network.requests.length - 1];
-InspectorTest.addResult(request1.url);
-InspectorTest.addResult(resource.type: + request1.type);
-InspectorTest.addResult(resource.content before requesting content: + request1.content);
-InspectorTest.assertTrue(!request1.failed, Resource loading failed.);
-request1.requestContent(step3);
-}
-
-function step3()
-{
-var request1 = WebInspector.panels.network.requests[WebInspector.panels.network.requests.length - 1];
-InspectorTest.addResult(resource.content after requesting content: + request1.content);
-
-InspectorTest.completeTest();
-}
-}
-/script
-/head
-body _onload_=runTest()
-pTests content is available for failed image request./p
-a href="" 84265/a
-/body
-/html
Deleted: trunk/LayoutTests/http/tests/inspector/network/resources/404.php (114643 => 114644)
---
[webkit-changes] [114645] trunk/Source/WebCore
Title: [114645] trunk/Source/WebCore
Revision 114645
Author hara...@chromium.org
Date 2012-04-19 10:00:21 -0700 (Thu, 19 Apr 2012)
Log Message
Unreviewed, rolling out r114421.
http://trac.webkit.org/changeset/114421
https://bugs.webkit.org/show_bug.cgi?id=84103
Chromium crash
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):
* bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr):
* bindings/v8/V8Binding.h:
(WebCore::v8ExternalString):
(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (114644 => 114645)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 16:59:34 UTC (rev 114644)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 17:00:21 UTC (rev 114645)
@@ -1,3 +1,40 @@
+2012-04-19 Kentaro Hara hara...@chromium.org
+
+Unreviewed, rolling out r114421.
+http://trac.webkit.org/changeset/114421
+https://bugs.webkit.org/show_bug.cgi?id=84103
+
+Chromium crash
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateNormalAttrGetter):
+(GenerateFunctionCallString):
+(NativeToJSValue):
+* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
+(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
+(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
+* bindings/scripts/test/V8/V8TestInterface.cpp:
+(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
+(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
+(WebCore::TestObjV8Internal::stringAttrAttrGetter):
+(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
+(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
+(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
+(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
+(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
+(WebCore::TestObjV8Internal::hashAttrGetter):
+(WebCore::TestObjV8Internal::conditionalMethod1Callback):
+* bindings/v8/V8Binding.cpp:
+(WebCore::getElementStringAttr):
+* bindings/v8/V8Binding.h:
+(WebCore::v8ExternalString):
+(WebCore::v8String):
+(WebCore::v8StringOrNull):
+(WebCore::v8StringOrUndefined):
+(WebCore::v8StringOrFalse):
+
2012-04-19 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r114626.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (114644 => 114645)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-04-19 16:59:34 UTC (rev 114644)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-04-19 17:00:21 UTC (rev 114645)
@@ -1009,7 +1009,7 @@
return value;
END
} else {
-push(@implContentDecls, . ReturnNativeToJSValue($attribute-signature, $result, info.GetIsolate()).;\n);
+push(@implContentDecls, . ReturnNativeToJSValue($attribute-signature, $result).;\n);
}
}
@@ -3340,7 +3340,7 @@
}
$return .= .release() if ($returnIsRef);
-$result .= $indent . ReturnNativeToJSValue($function-signature, $return, args.GetIsolate()) . ;\n;
+$result .= $indent . ReturnNativeToJSValue($function-signature, $return) . ;\n;
return $result;
}
@@ -3757,7 +3757,6 @@
{
my $signature = shift;
my $value
[webkit-changes] [114646] trunk/Tools
Title: [114646] trunk/Tools
Revision 114646
Author lforsch...@apple.com
Date 2012-04-19 10:00:28 -0700 (Thu, 19 Apr 2012)
Log Message
Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (114645 => 114646)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-04-19 17:00:21 UTC (rev 114645)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-04-19 17:00:28 UTC (rev 114646)
@@ -9,6 +9,7 @@
{ name: apple-xserve-8, platform: mac-snowleopard },
{ name: apple-xserve-9, platform: mac-snowleopard },
{ name: apple-macpro-7, platform: mac-snowleopard },
+{ name: apple-xserve-10, platform: mac-snowleopard },
{ name: apple-macpro-3, platform: mac-lion },
{ name: apple-macpro-4, platform: mac-lion },
@@ -18,7 +19,6 @@
{ name: apple-xserve-1, platform: mac-lion },
{ name: apple-xserve-2, platform: mac-lion },
{ name: apple-xserve-3, platform: mac-lion },
-{ name: apple-xserve-10, platform: mac-lion },
{ name: apple-xserve-11, platform: mac-lion },
{ name: apple-windows-1, platform: win},
@@ -81,7 +81,7 @@
{ name: SnowLeopard Intel Debug (Build), type: Build, builddir: snowleopard-intel-debug,
platform: mac-snowleopard, configuration: debug, architectures: [x86_64],
triggers: [snowleopard-intel-debug-tests, snowleopard-intel-debug-tests-wk2],
- slavenames: [apple-xserve-9]
+ slavenames: [apple-xserve-9, apple-xserve-10]
},
{ name: SnowLeopard Intel Release (Tests), type: Test, builddir: snowleopard-intel-release-tests,
platform: mac-snowleopard, configuration: release, architectures: [x86_64],
@@ -123,7 +123,7 @@
},
{ name: Lion Release (Tests), type: Test, builddir: lion-intel-release-tests,
platform: mac-lion, configuration: release, architectures: [x86_64],
- slavenames: [apple-macpro-5, apple-xserve-10]
+ slavenames: [apple-macpro-5]
},
{ name: Lion Release (WebKit2 Tests), type: TestWebKit2, builddir: lion-intel-release-tests-wk2,
platform: mac-lion, configuration: release, architectures: [x86_64],
Modified: trunk/Tools/ChangeLog (114645 => 114646)
--- trunk/Tools/ChangeLog 2012-04-19 17:00:21 UTC (rev 114645)
+++ trunk/Tools/ChangeLog 2012-04-19 17:00:28 UTC (rev 114646)
@@ -1,3 +1,9 @@
+2012-04-19 Lucas Forschler lforsch...@apple.com
+
+Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
2012-04-19 Christophe Dumez christophe.du...@intel.com
[EFL] dispatchDidCancelClientRedirect needs implementation
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114647] trunk/Source/WebKit/chromium
Title: [114647] trunk/Source/WebKit/chromium
Revision 114647
Author commit-qu...@webkit.org
Date 2012-04-19 10:05:36 -0700 (Thu, 19 Apr 2012)
Log Message
IndexedDB: Stub out IDBCursor.advance for landing
https://bugs.webkit.org/show_bug.cgi?id=84280
Patch by Alec Flett alecfl...@chromium.org on 2012-04-19
Reviewed by Dimitri Glazkov.
Just a stub method so it can be implemented on chromium
* public/WebIDBCursor.h:
(WebKit::WebIDBCursor::advance):
* src/WebIDBCursorImpl.cpp:
(WebKit::WebIDBCursorImpl::advance):
(WebKit):
* src/WebIDBCursorImpl.h:
(WebIDBCursorImpl):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBCursor.h
trunk/Source/WebKit/chromium/src/WebIDBCursorImpl.cpp
trunk/Source/WebKit/chromium/src/WebIDBCursorImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (114646 => 114647)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 17:00:28 UTC (rev 114646)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 17:05:36 UTC (rev 114647)
@@ -1,3 +1,20 @@
+2012-04-19 Alec Flett alecfl...@chromium.org
+
+IndexedDB: Stub out IDBCursor.advance for landing
+https://bugs.webkit.org/show_bug.cgi?id=84280
+
+Reviewed by Dimitri Glazkov.
+
+Just a stub method so it can be implemented on chromium
+
+* public/WebIDBCursor.h:
+(WebKit::WebIDBCursor::advance):
+* src/WebIDBCursorImpl.cpp:
+(WebKit::WebIDBCursorImpl::advance):
+(WebKit):
+* src/WebIDBCursorImpl.h:
+(WebIDBCursorImpl):
+
2012-04-19 Mark Pilgrim pilg...@chromium.org
[Chromium] Call mimeRegistry directly
Modified: trunk/Source/WebKit/chromium/public/WebIDBCursor.h (114646 => 114647)
--- trunk/Source/WebKit/chromium/public/WebIDBCursor.h 2012-04-19 17:00:28 UTC (rev 114646)
+++ trunk/Source/WebKit/chromium/public/WebIDBCursor.h 2012-04-19 17:05:36 UTC (rev 114647)
@@ -62,6 +62,7 @@
}
virtual void update(const WebSerializedScriptValue, WebIDBCallbacks*, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
+virtual void advance(unsigned long, WebIDBCallbacks*, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void continueFunction(const WebIDBKey, WebIDBCallbacks*, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void deleteFunction(WebIDBCallbacks*, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void prefetchContinue(int numberToFetch, WebIDBCallbacks*, WebExceptionCode) { WEBKIT_ASSERT_NOT_REACHED(); }
Modified: trunk/Source/WebKit/chromium/src/WebIDBCursorImpl.cpp (114646 => 114647)
--- trunk/Source/WebKit/chromium/src/WebIDBCursorImpl.cpp 2012-04-19 17:00:28 UTC (rev 114646)
+++ trunk/Source/WebKit/chromium/src/WebIDBCursorImpl.cpp 2012-04-19 17:05:36 UTC (rev 114647)
@@ -72,6 +72,11 @@
m_idbCursorBackend-update(value, IDBCallbacksProxy::create(adoptPtr(callbacks)), ec);
}
+void WebIDBCursorImpl::advance(unsigned long count, WebIDBCallbacks* callbacks, WebExceptionCode ec)
+{
+// FIXME: not implemented in indexeddb yet
+}
+
void WebIDBCursorImpl::continueFunction(const WebIDBKey key, WebIDBCallbacks* callbacks, WebExceptionCode ec)
{
m_idbCursorBackend-continueFunction(key, IDBCallbacksProxy::create(adoptPtr(callbacks)), ec);
Modified: trunk/Source/WebKit/chromium/src/WebIDBCursorImpl.h (114646 => 114647)
--- trunk/Source/WebKit/chromium/src/WebIDBCursorImpl.h 2012-04-19 17:00:28 UTC (rev 114646)
+++ trunk/Source/WebKit/chromium/src/WebIDBCursorImpl.h 2012-04-19 17:05:36 UTC (rev 114647)
@@ -49,6 +49,7 @@
virtual WebIDBKey primaryKey() const;
virtual WebSerializedScriptValue value() const;
virtual void update(const WebSerializedScriptValue, WebIDBCallbacks*, WebExceptionCode);
+virtual void advance(unsigned long, WebIDBCallbacks*, WebExceptionCode);
virtual void continueFunction(const WebIDBKey, WebIDBCallbacks*, WebExceptionCode);
virtual void deleteFunction(WebIDBCallbacks*, WebExceptionCode);
virtual void prefetchContinue(int numberToFetch, WebIDBCallbacks*, WebExceptionCode);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114648] trunk/LayoutTests
Title: [114648] trunk/LayoutTests Revision 114648 Author commit-qu...@webkit.org Date 2012-04-19 10:07:10 -0700 (Thu, 19 Apr 2012) Log Message [EFL] [DRT] Unskip KeyEvent related tests which are passing now https://bugs.webkit.org/show_bug.cgi?id=84345 Unreviewed, unskip passing KeyEvent tests. Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-04-19 * platform/efl/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (114647 => 114648) --- trunk/LayoutTests/ChangeLog 2012-04-19 17:05:36 UTC (rev 114647) +++ trunk/LayoutTests/ChangeLog 2012-04-19 17:07:10 UTC (rev 114648) @@ -1,3 +1,12 @@ +2012-04-19 Sudarsana Nagineni sudarsana.nagin...@linux.intel.com + +[EFL] [DRT] Unskip KeyEvent related tests which are passing now +https://bugs.webkit.org/show_bug.cgi?id=84345 + +Unreviewed, unskip passing KeyEvent tests. + +* platform/efl/Skipped: + 2012-04-19 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r114626. Modified: trunk/LayoutTests/platform/efl/Skipped (114647 => 114648) --- trunk/LayoutTests/platform/efl/Skipped 2012-04-19 17:05:36 UTC (rev 114647) +++ trunk/LayoutTests/platform/efl/Skipped 2012-04-19 17:07:10 UTC (rev 114648) @@ -1278,16 +1278,11 @@ fast/events/key-events-in-input-button.html fast/events/key-events-in-input-text.html fast/events/keydown-numpad-keys.html -fast/events/onsearch-enter.html fast/events/option-tab.html fast/events/special-key-events-in-input-text.html -fast/forms/button-enter-click.html fast/forms/button-spacebar-click.html fast/forms/enter-clicks-buttons.html fast/forms/input-search-press-escape-key.html -fast/forms/input-text-enter.html -fast/forms/textinput-not-fired-on-enter-in-input.html -http/tests/misc/isindex-with-no-form.html # BUG: mouse-related bugs in the EventSender-PlatformMouseEventEfl interaction fast/events/mouse-click-events.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114649] trunk
Title: [114649] trunk Revision 114649 Author yu...@chromium.org Date 2012-04-19 10:11:15 -0700 (Thu, 19 Apr 2012) Log Message Web Inspector: make constructors and diff heap snapshot data grids use viewport https://bugs.webkit.org/show_bug.cgi?id=84348 HeapSnapshotViewportDataGrid is introduced which allows to add to the tbody only visible rows. HeapSnapshotConstructorsDataGrid and HeapSnapshotDiffDataGrid are inherited from this class which makes them operate well on large amounts of nodes. Reviewed by Pavel Feldman. Source/WebCore: * inspector/front-end/DataGrid.js: (WebInspector.DataGridNode.prototype.nodeHeight): (WebInspector.DataGridNode.prototype._attach): * inspector/front-end/HeapSnapshotDataGrids.js: (WebInspector.HeapSnapshotSortableDataGrid): (WebInspector.HeapSnapshotSortableDataGrid.prototype.nodesForNameFilter): (WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter): (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting): (WebInspector.HeapSnapshotSortableDataGrid.prototype.appendChildAfterSorting): (WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes): (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter): (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave): (WebInspector.HeapSnapshotViewportDataGrid): (WebInspector.HeapSnapshotViewportDataGrid.prototype.nodesForNameFilter): (WebInspector.HeapSnapshotViewportDataGrid.prototype.appendChildAfterSorting): (WebInspector.HeapSnapshotViewportDataGrid.prototype.updateVisibleNodes): (WebInspector.HeapSnapshotViewportDataGrid.prototype.appendTopLevelNode): (WebInspector.HeapSnapshotViewportDataGrid.prototype._addPaddingRows): (WebInspector.HeapSnapshotViewportDataGrid.prototype._removePaddingRows): (WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize): (WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll): (WebInspector.HeapSnapshotPaddingNode): (WebInspector.HeapSnapshotPaddingNode.prototype.setHeight): (WebInspector.HeapSnapshotPaddingNode.prototype.removeFromTable): (WebInspector.HeapSnapshotConstructorsDataGrid): (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren): (WebInspector.HeapSnapshotDiffDataGrid): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren): * inspector/front-end/HeapSnapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode): (WebInspector.HeapSnapshotGridNode.prototype.collapse): (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate): (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort): (WebInspector.HeapSnapshotGridNode.prototype.sort): (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode): (WebInspector.HeapSnapshotObjectNode.prototype.comparator): (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode): (WebInspector.HeapSnapshotInstanceNode.prototype.comparator): (WebInspector.HeapSnapshotConstructorNode): (WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode): (WebInspector.HeapSnapshotConstructorNode.prototype.comparator): (WebInspector.HeapSnapshotDiffNode): (WebInspector.HeapSnapshotDiffNode.prototype._createChildNode): (WebInspector.HeapSnapshotDiffNode.prototype.comparator): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode): (WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator): * inspector/front-end/ShowMoreDataGridNode.js: (WebInspector.ShowMoreDataGridNode.prototype.createCells): (WebInspector.ShowMoreDataGridNode.prototype.nodeHeight): LayoutTests: * inspector/profiler/heap-snapshot-test.js: since summary and containment views are now viewports, we should make sure all lazy clean up is done before collecting visible rows content. (initialize_HeapSnapshotTest): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/DataGrid.js trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js trunk/Source/WebCore/inspector/front-end/ShowMoreDataGridNode.js Diff Modified: trunk/LayoutTests/ChangeLog (114648 => 114649) --- trunk/LayoutTests/ChangeLog 2012-04-19 17:07:10 UTC (rev 114648) +++ trunk/LayoutTests/ChangeLog 2012-04-19 17:11:15 UTC (rev 114649) @@ -1,3 +1,19 @@ +2012-04-19 Yury Semikhatsky yu...@chromium.org + +Web Inspector: make constructors and diff heap snapshot data grids use viewport +https://bugs.webkit.org/show_bug.cgi?id=84348 + +HeapSnapshotViewportDataGrid is introduced which allows to add to the tbody only +visible rows. HeapSnapshotConstructorsDataGrid and
[webkit-changes] [114650] trunk/LayoutTests
Title: [114650] trunk/LayoutTests Revision 114650 Author ann...@chromium.org Date 2012-04-19 10:53:37 -0700 (Thu, 19 Apr 2012) Log Message Space out captions-fast.vtt to prevent flakiness in media/track/track-mode.html. https://bugs.webkit.org/show_bug.cgi?id=83878 Reviewed by Eric Carlson. * media/track/captions-webvtt/captions-fast.vtt: * media/track/track-mode-expected.txt: * media/track/track-mode.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/track/captions-webvtt/captions-fast.vtt trunk/LayoutTests/media/track/track-mode-expected.txt trunk/LayoutTests/media/track/track-mode.html Diff Modified: trunk/LayoutTests/ChangeLog (114649 => 114650) --- trunk/LayoutTests/ChangeLog 2012-04-19 17:11:15 UTC (rev 114649) +++ trunk/LayoutTests/ChangeLog 2012-04-19 17:53:37 UTC (rev 114650) @@ -1,3 +1,14 @@ +2012-04-19 Anna Cavender ann...@chromium.org + +Space out captions-fast.vtt to prevent flakiness in media/track/track-mode.html. +https://bugs.webkit.org/show_bug.cgi?id=83878 + +Reviewed by Eric Carlson. + +* media/track/captions-webvtt/captions-fast.vtt: +* media/track/track-mode-expected.txt: +* media/track/track-mode.html: + 2012-04-19 Yury Semikhatsky yu...@chromium.org Web Inspector: make constructors and diff heap snapshot data grids use viewport Modified: trunk/LayoutTests/media/track/captions-webvtt/captions-fast.vtt (114649 => 114650) --- trunk/LayoutTests/media/track/captions-webvtt/captions-fast.vtt 2012-04-19 17:11:15 UTC (rev 114649) +++ trunk/LayoutTests/media/track/captions-webvtt/captions-fast.vtt 2012-04-19 17:53:37 UTC (rev 114650) @@ -1,17 +1,13 @@ WEBVTT 1 -00:00:00.000 -- 00:00:00.200 +00:00:00.000 -- 00:00:00.300 Lorem 2 -00:00:00.200 -- 00:00:00.500 +00:00:00.300 -- 00:00:00.700 ipsum 3 -00:00:00.800 -- 00:00:01.100 +00:00:01.200 -- 00:00:01.500 dolor - -4 -00:00:01.400 -- 00:00:01.700 -sit Modified: trunk/LayoutTests/media/track/track-mode-expected.txt (114649 => 114650) --- trunk/LayoutTests/media/track/track-mode-expected.txt 2012-04-19 17:11:15 UTC (rev 114649) +++ trunk/LayoutTests/media/track/track-mode-expected.txt 2012-04-19 17:53:37 UTC (rev 114650) @@ -23,15 +23,15 @@ RUN(textTrack.mode = '1') EXPECTED (textTrack.mode == '1') OK EXPECTED (video.textTracks[0].mode == '1') OK -EXPECTED (textTrack.cues.length == '4') OK +EXPECTED (textTrack.cues.length == '3') OK ++ 'TextTrack.SHOWING' RUN(textTrack.mode = '2') EXPECTED (textTrack.mode == '2') OK EXPECTED (video.textTracks[0].mode == '2') OK -EXPECTED (textTrack.cues.length == '4') OK +EXPECTED (textTrack.cues.length == '3') OK -++ 6 events expected while mode = TextTrack.SHOWING +++ 4 events expected while mode = TextTrack.SHOWING EVENT(cuechange) Cue entered: ipsum EXPECTED (textTrack.activeCues.length == '1') OK @@ -42,10 +42,5 @@ EXPECTED (textTrack.activeCues.length == '1') OK EVENT(cuechange) EXPECTED (textTrack.activeCues.length == '0') OK -EVENT(cuechange) -Cue entered: sit -EXPECTED (textTrack.activeCues.length == '1') OK -EVENT(cuechange) -EXPECTED (textTrack.activeCues.length == '0') OK END OF TEST Modified: trunk/LayoutTests/media/track/track-mode.html (114649 => 114650) --- trunk/LayoutTests/media/track/track-mode.html 2012-04-19 17:11:15 UTC (rev 114649) +++ trunk/LayoutTests/media/track/track-mode.html 2012-04-19 17:53:37 UTC (rev 114650) @@ -48,7 +48,7 @@ video.src = "" ../content/test); video.play(); // Wait for end of first cue (no events should fire while track is disabled). -setTimeout(testHiddenAndShowing, 300); +setTimeout(testHiddenAndShowing, 400); consoleWrite(++ 0 events expected while mode = TextTrack.DISABLED); consoleWrite(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114652] trunk/Source/WebCore
Title: [114652] trunk/Source/WebCore
Revision 114652
Author yu...@chromium.org
Date 2012-04-19 11:11:31 -0700 (Thu, 19 Apr 2012)
Log Message
Web Inspector: nodes are not removed from the summary view when switching between allocation ranges
https://bugs.webkit.org/show_bug.cgi?id=84354
Clear all top level nodes not only those visible in the viewport when populating
the constructors view with new content.
Reviewed by Pavel Feldman.
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.topLevelNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.topLevelNodes):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.removeTopLevelNodes):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (114651 => 114652)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 18:03:46 UTC (rev 114651)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 18:11:31 UTC (rev 114652)
@@ -1,3 +1,22 @@
+2012-04-19 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: nodes are not removed from the summary view when switching between allocation ranges
+https://bugs.webkit.org/show_bug.cgi?id=84354
+
+Clear all top level nodes not only those visible in the viewport when populating
+the constructors view with new content.
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/HeapSnapshotDataGrids.js:
+(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
+(WebInspector.HeapSnapshotSortableDataGrid.prototype.topLevelNodes):
+(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
+(WebInspector.HeapSnapshotViewportDataGrid.prototype.topLevelNodes):
+(WebInspector.HeapSnapshotViewportDataGrid.prototype.removeTopLevelNodes):
+(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
+(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
+
2012-04-19 Sami Kyostila skyos...@chromium.org
[chromium] Allow scrolling non-root layers in the compositor thread
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js (114651 => 114652)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js 2012-04-19 18:03:46 UTC (rev 114651)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js 2012-04-19 18:11:31 UTC (rev 114652)
@@ -41,8 +41,9 @@
WebInspector.HeapSnapshotSortableDataGrid.prototype = {
dispose: function()
{
-for (var i = 0, l = this.rootNode().children.length; i l; ++i)
-this.rootNode().children[i].dispose();
+var children = this.topLevelNodes();
+for (var i = 0, l = children.length; i l; ++i)
+children[i].dispose();
},
resetSortingCache: function()
@@ -51,7 +52,7 @@
delete this._lastSortAscending;
},
-nodesForNameFilter: function()
+topLevelNodes: function()
{
return this.rootNode().children;
},
@@ -59,7 +60,7 @@
changeNameFilter: function(filter)
{
filter = filter.toLowerCase();
-var children = this.nodesForNameFilter();
+var children = this.topLevelNodes();
for (var i = 0, l = children.length; i l; ++i) {
var node = children[i];
if (node.depth === 0)
@@ -160,7 +161,7 @@
}
WebInspector.HeapSnapshotViewportDataGrid.prototype = {
-nodesForNameFilter: function()
+topLevelNodes: function()
{
return this._topLevelNodes;
},
@@ -218,6 +219,12 @@
this._topLevelNodes.push(node);
},
+removeTopLevelNodes: function()
+{
+this.rootNode().removeChildren();
+this._topLevelNodes = [];
+},
+
_addPaddingRows: function(top, bottom)
{
if (this._topPadding.element.parentNode !== this.dataTableBody)
@@ -429,7 +436,7 @@
}
this.dispose();
-this.rootNode().removeChildren();
+this.removeTopLevelNodes();
this.resetSortingCache();
var key = this._profileIndex === -1 ? allObjects : this._minNodeId + .. + this._maxNodeId;
@@ -506,7 +513,7 @@
{
this.baseSnapshot = baseSnapshot;
this.dispose();
-this.rootNode().removeChildren();
+this.removeTopLevelNodes();
this.resetSortingCache();
if (this.baseSnapshot === this.snapshot) {
this.dispatchEventToListeners(sorting complete);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [114653] trunk
Title: [114653] trunk Revision 114653 Author commit-qu...@webkit.org Date 2012-04-19 11:17:58 -0700 (Thu, 19 Apr 2012) Log Message [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92 https://bugs.webkit.org/show_bug.cgi?id=82484 Patch by Dominik Röttsches dominik.rottsc...@linux.intel.com on 2012-04-19 Reviewed by Martin Robinson. Tools: Bumping libsoup to version 2.38.1 which fixes the above WebKit bug. * efl/jhbuild.modules: * gtk/jhbuild.modules: LayoutTests: Unskipping tests that were previously failing due to a bug in libsoup. * platform/gtk/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/test_expectations.txt trunk/Tools/ChangeLog trunk/Tools/efl/jhbuild.modules trunk/Tools/gtk/jhbuild.modules Diff Modified: trunk/LayoutTests/ChangeLog (114652 => 114653) --- trunk/LayoutTests/ChangeLog 2012-04-19 18:11:31 UTC (rev 114652) +++ trunk/LayoutTests/ChangeLog 2012-04-19 18:17:58 UTC (rev 114653) @@ -1,3 +1,14 @@ +2012-04-19 Dominik Röttsches dominik.rottsc...@linux.intel.com + +[GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92 +https://bugs.webkit.org/show_bug.cgi?id=82484 + +Reviewed by Martin Robinson. + +Unskipping tests that were previously failing due to a bug in libsoup. + +* platform/gtk/test_expectations.txt: + 2012-04-19 Anna Cavender ann...@chromium.org Space out captions-fast.vtt to prevent flakiness in media/track/track-mode.html. Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (114652 => 114653) --- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-19 18:11:31 UTC (rev 114652) +++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-19 18:17:58 UTC (rev 114653) @@ -532,11 +532,6 @@ BUGWK79757 : fast/selectors/selection-window-inactive.html = IMAGE FAIL -// Started to fail after upgrading libsoup to 2.37.92 -BUGWK82484 : fast/encoding/percent-escaping.html = TEXT -BUGWK82484 : fast/loader/file-URL-with-port-number.html = TEXT -BUGWK82484 : fast/loader/location-port.html = TEXT - BUGWKGTK : accessibility/aria-hidden.html = FAIL BUGWKGTK : accessibility/aria-hidden-with-elements.html = FAIL BUGWKGTK : accessibility/aria-invalid.html = FAIL Modified: trunk/Tools/ChangeLog (114652 => 114653) --- trunk/Tools/ChangeLog 2012-04-19 18:11:31 UTC (rev 114652) +++ trunk/Tools/ChangeLog 2012-04-19 18:17:58 UTC (rev 114653) @@ -1,3 +1,15 @@ +2012-04-19 Dominik Röttsches dominik.rottsc...@linux.intel.com + +[GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92 +https://bugs.webkit.org/show_bug.cgi?id=82484 + +Reviewed by Martin Robinson. + +Bumping libsoup to version 2.38.1 which fixes the above WebKit bug. + +* efl/jhbuild.modules: +* gtk/jhbuild.modules: + 2012-04-19 Lucas Forschler lforsch...@apple.com Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build Modified: trunk/Tools/efl/jhbuild.modules (114652 => 114653) --- trunk/Tools/efl/jhbuild.modules 2012-04-19 18:11:31 UTC (rev 114652) +++ trunk/Tools/efl/jhbuild.modules 2012-04-19 18:17:58 UTC (rev 114653) @@ -142,9 +142,9 @@ dependencies dep package=glib-networking/ /dependencies -branch module=libsoup version=2.37.92 +branch module=libsoup version=2.38.1 repo=git.gnome.org -tag=afcff7115a6c36ca3de5bc88994174f5a0e01956/ +tag=LIBSOUP_2_38_1/ /autotools autotools id=fontconfig autogen-sh=configure Modified: trunk/Tools/gtk/jhbuild.modules (114652 => 114653) --- trunk/Tools/gtk/jhbuild.modules 2012-04-19 18:11:31 UTC (rev 114652) +++ trunk/Tools/gtk/jhbuild.modules 2012-04-19 18:17:58 UTC (rev 114653) @@ -160,9 +160,9 @@ dependencies dep package=glib-networking/ /dependencies -branch module=libsoup version=2.37.92 +branch module=libsoup version=2.38.1 repo=git.gnome.org -tag=afcff7115a6c36ca3de5bc88994174f5a0e01956/ +tag=LIBSOUP_2_38_1/ /autotools autotools id=fontconfig autogen-sh=configure ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114654] trunk/Source/WebCore
Title: [114654] trunk/Source/WebCore
Revision 114654
Author yu...@chromium.org
Date 2012-04-19 11:18:01 -0700 (Thu, 19 Apr 2012)
Log Message
Web Inspector: exception when hovering object while paused
https://bugs.webkit.org/show_bug.cgi?id=84358
Added missing boolean parameter to the call site of evaluate method
on call frame.
Reviewed by Vsevolod Vlasov.
* inspector/front-end/AdvancedSearchController.js:
* inspector/front-end/DebuggerPresentationModel.js: annotated slectedCallFrame
method so that closure compiler catches errors like in the bug report.
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype._resolveObjectForPopover):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (114653 => 114654)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 18:17:58 UTC (rev 114653)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 18:18:01 UTC (rev 114654)
@@ -1,5 +1,22 @@
2012-04-19 Yury Semikhatsky yu...@chromium.org
+Web Inspector: exception when hovering object while paused
+https://bugs.webkit.org/show_bug.cgi?id=84358
+
+Added missing boolean parameter to the call site of evaluate method
+on call frame.
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/AdvancedSearchController.js:
+* inspector/front-end/DebuggerPresentationModel.js: annotated slectedCallFrame
+method so that closure compiler catches errors like in the bug report.
+(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame.prototype._resolveObjectForPopover):
+
+2012-04-19 Yury Semikhatsky yu...@chromium.org
+
Web Inspector: nodes are not removed from the summary view when switching between allocation ranges
https://bugs.webkit.org/show_bug.cgi?id=84354
Modified: trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js (114653 => 114654)
--- trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js 2012-04-19 18:17:58 UTC (rev 114653)
+++ trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js 2012-04-19 18:18:01 UTC (rev 114654)
@@ -450,7 +450,7 @@
/**
* @param {WebInspector.SearchConfig} searchConfig
- * @return WebInspector.SearchResultsPane}
+ * @return {WebInspector.SearchResultsPane}
*/
createSearchResultsPane: function(searchConfig) { }
}
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (114653 => 114654)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-04-19 18:17:58 UTC (rev 114653)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-04-19 18:18:01 UTC (rev 114654)
@@ -453,6 +453,9 @@
this._executionLineLiveLocation.init();
},
+/**
+ * @return {?WebInspector.PresentationCallFrame}
+ */
get selectedCallFrame()
{
return this._selectedCallFrame;
@@ -470,14 +473,14 @@
{
/**
* @param {?RuntimeAgent.RemoteObject} result
- * @param {boolean} wasThrown
+ * @param {boolean=} wasThrown
*/
function didEvaluate(result, wasThrown)
{
if (returnByValue)
-callback(null, wasThrown, wasThrown ? null : result);
+callback(null, !!wasThrown, wasThrown ? null : result);
else
-callback(WebInspector.RemoteObject.fromPayload(result), wasThrown);
+callback(WebInspector.RemoteObject.fromPayload(result), !!wasThrown);
if (objectGroup === console)
this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.ConsoleCommandEvaluatedInSelectedCallFrame);
Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (114653 => 114654)
--- trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2012-04-19 18:17:58 UTC (rev 114653)
+++ trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2012-04-19 18:18:01 UTC (rev 114654)
@@ -263,6 +263,10 @@
{
this._highlightElement = this._highlightExpression(element);
+/**
+ * @param {?RuntimeAgent.RemoteObject} result
+ * @param {boolean=} wasThrown
+ */
function showObjectPopover(result, wasThrown)
{
if (!this._model.paused) {
@@ -276,7 +280,7 @@
}
var selectedCallFrame = this._model.selectedCallFrame;
-
[webkit-changes] [114655] trunk/Source/WebCore
Title: [114655] trunk/Source/WebCore
Revision 114655
Author macpher...@chromium.org
Date 2012-04-19 11:20:08 -0700 (Thu, 19 Apr 2012)
Log Message
Fix potential null pointer dereference in RuleSet::addRulesFromSheet().
https://bugs.webkit.org/show_bug.cgi?id=84258
Reviewed by Andreas Kling.
Fix variable that is dereferenced without null check here, but checked in code above and below.
No new test / code cleanup from coverity analysis.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114654 => 114655)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 18:18:01 UTC (rev 114654)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 18:20:08 UTC (rev 114655)
@@ -1,3 +1,17 @@
+2012-04-19 Luke Macpherson macpher...@chromium.org
+
+Fix potential null pointer dereference in RuleSet::addRulesFromSheet().
+https://bugs.webkit.org/show_bug.cgi?id=84258
+
+Reviewed by Andreas Kling.
+
+Fix variable that is dereferenced without null check here, but checked in code above and below.
+
+No new test / code cleanup from coverity analysis.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+
2012-04-19 Yury Semikhatsky yu...@chromium.org
Web Inspector: exception when hovering object while paused
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (114654 => 114655)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-04-19 18:18:01 UTC (rev 114654)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-04-19 18:20:08 UTC (rev 114655)
@@ -2526,7 +2526,7 @@
const StyleRuleFontFace* fontFaceRule = static_castStyleRuleFontFace*(rule);
styleSelector-fontSelector()-addFontFaceRule(fontFaceRule);
styleSelector-invalidateMatchedPropertiesCache();
-} else if (rule-isKeyframesRule()) {
+} else if (rule-isKeyframesRule() styleSelector) {
// FIXME (BUG 72462): We don't add @keyframe rules of scoped style sheets for the moment.
if (scope)
continue;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114656] trunk/Source/WebCore
Title: [114656] trunk/Source/WebCore
Revision 114656
Author beid...@apple.com
Date 2012-04-19 11:25:44 -0700 (Thu, 19 Apr 2012)
Log Message
rdar://problem/10664148 and https://bugs.webkit.org/show_bug.cgi?id=84360 StorageThread should have an autorelease pool in place for Cocoa clients
Reviewed by Eric Carlson.
No new tests. (Not practical to test this with current tools)
* storage/StorageThread.cpp:
(WebCore::StorageThread::threadEntryPoint): Include an AutodrainedPool and cycle it after each message.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/StorageThread.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114655 => 114656)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 18:20:08 UTC (rev 114655)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 18:25:44 UTC (rev 114656)
@@ -1,3 +1,15 @@
+2012-04-19 Brady Eidson beid...@apple.com
+
+rdar://problem/10664148 and https://bugs.webkit.org/show_bug.cgi?id=84360
+StorageThread should have an autorelease pool in place for Cocoa clients
+
+Reviewed by Eric Carlson.
+
+No new tests. (Not practical to test this with current tools)
+
+* storage/StorageThread.cpp:
+(WebCore::StorageThread::threadEntryPoint): Include an AutodrainedPool and cycle it after each message.
+
2012-04-19 Luke Macpherson macpher...@chromium.org
Fix potential null pointer dereference in RuleSet::addRulesFromSheet().
Modified: trunk/Source/WebCore/storage/StorageThread.cpp (114655 => 114656)
--- trunk/Source/WebCore/storage/StorageThread.cpp 2012-04-19 18:20:08 UTC (rev 114655)
+++ trunk/Source/WebCore/storage/StorageThread.cpp 2012-04-19 18:25:44 UTC (rev 114656)
@@ -26,6 +26,7 @@
#include config.h
#include StorageThread.h
+#include AutodrainedPool.h
#include StorageTask.h
#include StorageAreaSync.h
#include wtf/MainThread.h
@@ -64,8 +65,12 @@
void StorageThread::threadEntryPoint()
{
ASSERT(!isMainThread());
-while (OwnPtrStorageTask task = m_queue.waitForMessage())
+AutodrainedPool pool;
+
+while (OwnPtrStorageTask task = m_queue.waitForMessage()) {
task-performTask();
+pool.cycle();
+}
}
void StorageThread::scheduleTask(PassOwnPtrStorageTask task)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114657] trunk/LayoutTests
Title: [114657] trunk/LayoutTests Revision 114657 Author a...@apple.com Date 2012-04-19 11:27:45 -0700 (Thu, 19 Apr 2012) Log Message AVFoundation: media/video-size-intrinsic-scale.html test fails, and the movie is drawn incorrectly https://bugs.webkit.org/show_bug.cgi?id=66601 Reviewed by Eric Carlson. * platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt: Added. Copied passing result, since this doesn't fail on Snow Leopard. * platform/mac/media/video-size-intrinsic-scale-expected.txt: Added a failing results to make bots green. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (114656 => 114657) --- trunk/LayoutTests/ChangeLog 2012-04-19 18:25:44 UTC (rev 114656) +++ trunk/LayoutTests/ChangeLog 2012-04-19 18:27:45 UTC (rev 114657) @@ -1,3 +1,16 @@ +2012-04-19 Alexey Proskuryakov a...@apple.com + +AVFoundation: media/video-size-intrinsic-scale.html test fails, and the movie is drawn incorrectly +https://bugs.webkit.org/show_bug.cgi?id=66601 + +Reviewed by Eric Carlson. + +* platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt: Added. +Copied passing result, since this doesn't fail on Snow Leopard. + +* platform/mac/media/video-size-intrinsic-scale-expected.txt: Added a failing results to make +bots green. + 2012-04-19 Dominik Röttsches dominik.rottsc...@linux.intel.com [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92 Added: trunk/LayoutTests/platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt (0 => 114657) --- trunk/LayoutTests/platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt 2012-04-19 18:27:45 UTC (rev 114657) @@ -0,0 +1,20 @@ +Test size before movie is open: +EXPECTED (video.videoWidth == '0') OK +EXPECTED (video.videoHeight == '0') OK + +Loading content/scaled-matrix.mov. Movie saved with a non identity matrix. +EVENT(loadstart) +EVENT(durationchange) +EVENT(loadedmetadata) +EXPECTED (video.videoWidth == '640') OK +EXPECTED (video.videoHeight == '480') OK + +Loading content/720x576i-anamorphic.mov. Movie encoded with PAL non-square pixels, clean aperture corrects pixel aspect ratio when displayed. +EVENT(loadstart) +EVENT(durationchange) +EVENT(loadedmetadata) +EXPECTED (video.videoWidth == '1024') OK +EXPECTED (video.videoHeight == '576') OK + +END OF TEST + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114658] trunk/Source/WebCore
Title: [114658] trunk/Source/WebCore
Revision 114658
Author yu...@chromium.org
Date 2012-04-19 11:38:34 -0700 (Thu, 19 Apr 2012)
Log Message
Web Inspector / Heap snapshots: Objects allocated ... views are empty
https://bugs.webkit.org/show_bug.cgi?id=84347
Pass parsed maxJSObjectId value to the profile header constructor.
Reviewed by Pavel Feldman.
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (114657 => 114658)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 18:27:45 UTC (rev 114657)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 18:38:34 UTC (rev 114658)
@@ -1,3 +1,18 @@
+2012-04-19 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector / Heap snapshots: Objects allocated ... views are empty
+https://bugs.webkit.org/show_bug.cgi?id=84347
+
+Pass parsed maxJSObjectId value to the profile header constructor.
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ProfilesPanel.js:
+(WebInspector.ProfileHeader):
+(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
+(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
+(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
+
2012-04-19 Brady Eidson beid...@apple.com
rdar://problem/10664148 and https://bugs.webkit.org/show_bug.cgi?id=84360
Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (114657 => 114658)
--- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2012-04-19 18:27:45 UTC (rev 114657)
+++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2012-04-19 18:38:34 UTC (rev 114658)
@@ -103,16 +103,16 @@
* @param {string} profileType
* @param {string} title
* @param {number} uid
+ * @param {number} maxJSObjectId
* @param {boolean} isTemporary
*/
-WebInspector.ProfileHeader = function(profileType, title, uid, isTemporary)
+WebInspector.ProfileHeader = function(profileType, title, uid, maxJSObjectId, isTemporary)
{
this.typeId = profileType,
this.title = title;
this.uid = uid;
this.isTemporary = isTemporary;
-
-this.maxJSObjectId = 0;
+this.maxJSObjectId = maxJSObjectId;
}
/**
@@ -847,7 +847,7 @@
this.getProfileType(profileType).setRecordingProfile(isProfiling);
if (this.hasTemporaryProfile(profileType) !== isProfiling) {
if (!this._temporaryRecordingProfile)
-this._temporaryRecordingProfile = new WebInspector.ProfileHeader(profileType, WebInspector.UIString(Recording\u2026), -1, true);
+this._temporaryRecordingProfile = new WebInspector.ProfileHeader(profileType, WebInspector.UIString(Recording\u2026), -1, -1, true);
if (isProfiling) {
this.addProfileHeader(this._temporaryRecordingProfile);
if (profileType === WebInspector.CPUProfileType.TypeId)
@@ -865,6 +865,7 @@
WebInspector.HeapSnapshotProfileType.TypeId,
WebInspector.UIString(Snapshotting\u2026),
-1,
+-1,
true);
}
this.addProfileHeader(this._temporaryRecordingProfile);
@@ -906,7 +907,7 @@
*/
addProfileHeader: function(profile)
{
-this._profiler.addProfileHeader(new WebInspector.ProfileHeader(profile[typeId], profile[title], profile[uid], false));
+this._profiler.addProfileHeader(new WebInspector.ProfileHeader(profile[typeId], profile[title], profile[uid], profile[maxJSObjectId], false));
},
addHeapSnapshotChunk: function(uid, chunk)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114659] trunk
Title: [114659] trunk
Revision 114659
Author wangxian...@chromium.org
Date 2012-04-19 11:42:00 -0700 (Thu, 19 Apr 2012)
Log Message
DevTools highlights elements in frames at un-scaled positions
https://bugs.webkit.org/show_bug.cgi?id=84181
Source/WebCore:
On mobile platforms (e.g. chromium-android), normally pages are scaled,
thus the coordinations of highlight rect inside of a frame needs to
consider not only the offset, but also the scale. The change uses
FrameView::contentsToRootView() to map the coordinates of a node in
a frame to the coordinates in the main frame, instead of calculating
by only the offset.
Reviewed by Pavel Feldman.
Test: inspector/elements/highlight-node-scaled.html
* inspector/DOMNodeHighlighter.cpp:
LayoutTests:
The new test case is a scaled web page containing an iframe. It tests
if the highlight rect of an element in the iframe is correct.
Reviewed by Pavel Feldman.
* inspector/elements/highlight-node-scaled-expected.txt: Added.
* inspector/elements/highlight-node-scaled.html: Added.
* inspector/elements/resources/highlight-node-scaled-iframe.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp
Added Paths
trunk/LayoutTests/inspector/elements/highlight-node-scaled-expected.txt
trunk/LayoutTests/inspector/elements/highlight-node-scaled.html
trunk/LayoutTests/inspector/elements/resources/highlight-node-scaled-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (114658 => 114659)
--- trunk/LayoutTests/ChangeLog 2012-04-19 18:38:34 UTC (rev 114658)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 18:42:00 UTC (rev 114659)
@@ -1,3 +1,17 @@
+2012-04-19 Xianzhu Wang wangxian...@chromium.org
+
+DevTools highlights elements in frames at un-scaled positions
+https://bugs.webkit.org/show_bug.cgi?id=84181
+
+The new test case is a scaled web page containing an iframe. It tests
+if the highlight rect of an element in the iframe is correct.
+
+Reviewed by Pavel Feldman.
+
+* inspector/elements/highlight-node-scaled-expected.txt: Added.
+* inspector/elements/highlight-node-scaled.html: Added.
+* inspector/elements/resources/highlight-node-scaled-iframe.html: Added.
+
2012-04-19 Alexey Proskuryakov a...@apple.com
AVFoundation: media/video-size-intrinsic-scale.html test fails, and the movie is drawn incorrectly
Added: trunk/LayoutTests/inspector/elements/highlight-node-scaled-expected.txt (0 => 114659)
--- trunk/LayoutTests/inspector/elements/highlight-node-scaled-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/elements/highlight-node-scaled-expected.txt 2012-04-19 18:42:00 UTC (rev 114659)
@@ -0,0 +1,6 @@
+
+margin rect is 166 x 188 at (154, 192)
+border rect is 138 x 160 at (168, 206)
+padding rect is 118 x 140 at (178, 216)
+content rect is 66 x 88 at (204, 242)
+
Added: trunk/LayoutTests/inspector/elements/highlight-node-scaled.html (0 => 114659)
--- trunk/LayoutTests/inspector/elements/highlight-node-scaled.html (rev 0)
+++ trunk/LayoutTests/inspector/elements/highlight-node-scaled.html 2012-04-19 18:42:00 UTC (rev 114659)
@@ -0,0 +1,65 @@
+html
+head
+
+style
+
+body {
+margin: 0;
+}
+
+iframe {
+position: absolute;
+left: 83px;
+top: 53px;
+width: 200px;
+height: 200px;
+}
+
+/style
+
+script src=""
+script src=""
+script
+
+function dumpInspectorHighlightRects()
+{
+var rectNames = [margin, border, padding, content];
+var rects = window.internals.inspectorHighlightRects(document);
+for (var i = 0; i rects.length; i++)
+{
+var rectName = (i rectNames.length ? rectNames[i] : untitled);
+var rect = rects.item(i);
+var line = rectName + rect is + rect.width + x + rect.height + at ( + rect.top + , + rect.left + )br/;
+document.getElementById(console).innerHTML += line;
+}
+}
+
+function onload()
+{
+if (window.internals)
+window.internals.settings.setPageScaleFactor(2, 0, 0);
+runTest();
+}
+
+function test()
+{
+WebInspector.inspectorView.setCurrentPanel(WebInspector.panels.elements);
+WebInspector.panels.elements.treeOutline.addEventListener(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged, selectedNodeChanged, this);
+
+function selectedNodeChanged(event)
+{
+var node = event.data;
+if (node.getAttribute(id) == div)
+RuntimeAgent.evaluate(dumpInspectorHighlightRects(), InspectorTest.completeTest);
+}
+InspectorTest.evaluateInConsole(inspect(iframeDivElement));
+}
+
+/script
+/head
+
+body _onload_=onload()
+iframe src=""
+div id=console/div
+/body
+/html
Added: trunk/LayoutTests/inspector/elements/resources/highlight-node-scaled-iframe.html (0 => 114659)
--- trunk/LayoutTests/inspector/elements/resources/highlight-node-scaled-iframe.html (rev 0)
+++
[webkit-changes] [114660] trunk/Source/JavaScriptCore
Title: [114660] trunk/Source/_javascript_Core
Revision 114660
Author fpi...@apple.com
Date 2012-04-19 11:44:04 -0700 (Thu, 19 Apr 2012)
Log Message
It should be possible to load from Float64 arrays on ARMv7 without crashing
https://bugs.webkit.org/show_bug.cgi?id=84361
Reviewed by Oliver Hunt.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::storeDouble):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (114659 => 114660)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-19 18:42:00 UTC (rev 114659)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-19 18:44:04 UTC (rev 114660)
@@ -1,3 +1,14 @@
+2012-04-19 Filip Pizlo fpi...@apple.com
+
+It should be possible to load from Float64 arrays on ARMv7 without crashing
+https://bugs.webkit.org/show_bug.cgi?id=84361
+
+Reviewed by Oliver Hunt.
+
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::loadDouble):
+(JSC::MacroAssemblerARMv7::storeDouble):
+
2012-04-19 Dominik Röttsches dominik.rottsc...@linux.intel.com
[CMake] Build fix after r114575
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (114659 => 114660)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2012-04-19 18:42:00 UTC (rev 114659)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2012-04-19 18:44:04 UTC (rev 114660)
@@ -765,9 +765,10 @@
void loadDouble(BaseIndex address, FPRegisterID dest)
{
-UNUSED_PARAM(address);
-UNUSED_PARAM(dest);
-unreachableForPlatform();
+move(address.index, addressTempRegister);
+lshift32(TrustedImm32(address.scale), addressTempRegister);
+add32(address.base, addressTempRegister);
+loadDouble(Address(addressTempRegister, address.offset), dest);
}
void loadFloat(BaseIndex address, FPRegisterID dest)
@@ -813,7 +814,7 @@
void storeDouble(FPRegisterID src, BaseIndex address)
{
move(address.index, addressTempRegister);
-mul32(TrustedImm32(1 address.scale), addressTempRegister, addressTempRegister);
+lshift32(TrustedImm32(address.scale), addressTempRegister);
add32(address.base, addressTempRegister);
storeDouble(src, Address(addressTempRegister, address.offset));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114661] trunk/Source/WebCore
Title: [114661] trunk/Source/WebCore
Revision 114661
Author bda...@apple.com
Date 2012-04-19 11:47:27 -0700 (Thu, 19 Apr 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=80534
REGRESSION: When Safari is not frontmost, pages should not get mouse moves or
hover
Reviewed by Adele Peterson.
This patch just adds some code back that was removed by
http://trac.webkit.org/changeset/102632 This particular code was unrelated to that
bug and should not have been removed.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114660 => 114661)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 18:44:04 UTC (rev 114660)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 18:47:27 UTC (rev 114661)
@@ -1,3 +1,17 @@
+2012-04-19 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=80536
+REGRESSION: When Safari is not frontmost, pages should not get mouse moves or
+hover
+
+Reviewed by Adele Peterson.
+
+This patch just adds some code back that was removed by
+http://trac.webkit.org/changeset/102632 This particular code was unrelated to that
+bug and should not have been removed.
+* page/EventHandler.cpp:
+(WebCore::EventHandler::handleMouseMoveEvent):
+
2012-04-19 Xianzhu Wang wangxian...@chromium.org
DevTools highlights elements in frames at un-scaled positions
Modified: trunk/Source/WebCore/page/EventHandler.cpp (114660 => 114661)
--- trunk/Source/WebCore/page/EventHandler.cpp 2012-04-19 18:44:04 UTC (rev 114660)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2012-04-19 18:47:27 UTC (rev 114661)
@@ -1746,6 +1746,13 @@
HitTestRequest::HitTestRequestType hitType = HitTestRequest::Move;
if (m_mousePressed)
hitType |= HitTestRequest::Active;
+else if (onlyUpdateScrollbars) {
+// Mouse events should be treated as read-only if we're updating only scrollbars. This
+// means that :hover and :active freeze in the state they were in, rather than updating
+// for nodes the mouse moves while the window is not key (which will be the case if
+// onlyUpdateScrollbars is true).
+hitType |= HitTestRequest::ReadOnly;
+}
#if ENABLE(TOUCH_EVENTS)
// Treat any mouse move events as readonly if the user is currently touching the screen.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114662] trunk/Source/WebCore
Title: [114662] trunk/Source/WebCore
Revision 114662
Author yu...@chromium.org
Date 2012-04-19 11:50:44 -0700 (Thu, 19 Apr 2012)
Log Message
Web Inspector / Heap snapshots: Object's retaining tree view doesn't get cleared when navigating between objects
https://bugs.webkit.org/show_bug.cgi?id=84337
When DataGrid root node is reset, make sure all existing rows are removed.
Reviewed by Vsevolod Vlasov.
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.setRootNode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DataGrid.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (114661 => 114662)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 18:47:27 UTC (rev 114661)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 18:50:44 UTC (rev 114662)
@@ -1,3 +1,15 @@
+2012-04-19 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector / Heap snapshots: Object's retaining tree view doesn't get cleared when navigating between objects
+https://bugs.webkit.org/show_bug.cgi?id=84337
+
+When DataGrid root node is reset, make sure all existing rows are removed.
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/DataGrid.js:
+(WebInspector.DataGrid.prototype.setRootNode):
+
2012-04-19 Beth Dakin bda...@apple.com
https://bugs.webkit.org/show_bug.cgi?id=80536
Modified: trunk/Source/WebCore/inspector/front-end/DataGrid.js (114661 => 114662)
--- trunk/Source/WebCore/inspector/front-end/DataGrid.js 2012-04-19 18:47:27 UTC (rev 114661)
+++ trunk/Source/WebCore/inspector/front-end/DataGrid.js 2012-04-19 18:50:44 UTC (rev 114662)
@@ -241,6 +241,7 @@
setRootNode: function(rootNode)
{
if (this._rootNode) {
+this._rootNode.removeChildren();
this._rootNode.dataGrid = null;
this._rootNode._isRoot = false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114663] trunk
Title: [114663] trunk
Revision 114663
Author vse...@chromium.org
Date 2012-04-19 11:56:01 -0700 (Thu, 19 Apr 2012)
Log Message
Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265
Reviewed by Pavel Feldman.
Source/WebCore:
InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.
Test: http/tests/inspector/network/network-image-404.html
* inspector/InspectorResourceAgent.cpp:
(WebCore::isErrorStatusCode):
(WebCore):
(WebCore::InspectorResourceAgent::didReceiveData):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::purgeContent):
(WebCore):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceContent):
* inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
* inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):
LayoutTests:
* http/tests/inspector/network/network-image-404-expected.txt: Added.
* http/tests/inspector/network/network-image-404.html: Added.
* http/tests/inspector/network/resources/404.php: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp
trunk/Source/WebCore/inspector/NetworkResourcesData.cpp
trunk/Source/WebCore/inspector/NetworkResourcesData.h
trunk/Source/WebCore/inspector/front-end/RequestView.js
Added Paths
trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-image-404.html
trunk/LayoutTests/http/tests/inspector/network/resources/404.php
Diff
Modified: trunk/LayoutTests/ChangeLog (114662 => 114663)
--- trunk/LayoutTests/ChangeLog 2012-04-19 18:50:44 UTC (rev 114662)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 18:56:01 UTC (rev 114663)
@@ -1,3 +1,14 @@
+2012-04-19 vse...@chromium.org vse...@chromium.org
+
+Web Inspector: No response body available for cached resource requests with error status codes.
+https://bugs.webkit.org/show_bug.cgi?id=84265
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/network/network-image-404-expected.txt: Added.
+* http/tests/inspector/network/network-image-404.html: Added.
+* http/tests/inspector/network/resources/404.php: Added.
+
2012-04-19 Xianzhu Wang wangxian...@chromium.org
DevTools highlights elements in frames at un-scaled positions
Added: trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt (0 => 114663)
--- trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt 2012-04-19 18:56:01 UTC (rev 114663)
@@ -0,0 +1,9 @@
+CONSOLE MESSAGE: line 15: Done.
+Tests content is available for failed image request.
+
+Bug 84265
+http://127.0.0.1:8000/inspector/network/resources/404.php
+resource.type: image
+resource.content before requesting content: undefined
+resource.content after requesting content: 404 - resource was not found.
+
Property changes on: trunk/LayoutTests/http/tests/inspector/network/network-image-404-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/inspector/network/network-image-404.html (0 => 114663)
--- trunk/LayoutTests/http/tests/inspector/network/network-image-404.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-image-404.html 2012-04-19 18:56:01 UTC (rev 114663)
@@ -0,0 +1,54 @@
+html
+head
+script src=""
+script src=""
+script
+function loadData()
+{
+var image = new Image();
+image.src = ""
+image._onerror_ = resourceLoaded;
+}
+
+function resourceLoaded()
+{
+console.log(Done.);
+}
+
+function test()
+{
+// Since this test could be run together with other inspector backend cache
+// tests, we need to reset size limits to default ones.
+InspectorTest.resetInspectorResourcesData(step1);
+
+function step1()
+{
+InspectorTest.addConsoleSniffer(step2);
+InspectorTest.evaluateInPage(loadData());
+}
+
+function step2()
+{
+var request1 = WebInspector.panels.network.requests[WebInspector.panels.network.requests.length - 1];
+InspectorTest.addResult(request1.url);
+InspectorTest.addResult(resource.type: + request1.type);
+InspectorTest.addResult(resource.content before requesting content: + request1.content);
+InspectorTest.assertTrue(!request1.failed, Resource loading failed.);
+request1.requestContent(step3);
+}
+
+function
[webkit-changes] [114664] trunk/Source/JavaScriptCore
Title: [114664] trunk/Source/_javascript_Core Revision 114664 Author fpi...@apple.com Date 2012-04-19 12:08:58 -0700 (Thu, 19 Apr 2012) Log Message LLInt no-JIT fallback native call trampoline's exception handler incorrectly assumes that the PB/PC has been preserved https://bugs.webkit.org/show_bug.cgi?id=84367 Reviewed by Oliver Hunt. * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm Diff Modified: trunk/Source/_javascript_Core/ChangeLog (114663 => 114664) --- trunk/Source/_javascript_Core/ChangeLog 2012-04-19 18:56:01 UTC (rev 114663) +++ trunk/Source/_javascript_Core/ChangeLog 2012-04-19 19:08:58 UTC (rev 114664) @@ -1,5 +1,16 @@ 2012-04-19 Filip Pizlo fpi...@apple.com +LLInt no-JIT fallback native call trampoline's exception handler incorrectly assumes that +the PB/PC has been preserved +https://bugs.webkit.org/show_bug.cgi?id=84367 + +Reviewed by Oliver Hunt. + +* llint/LowLevelInterpreter32_64.asm: +* llint/LowLevelInterpreter64.asm: + +2012-04-19 Filip Pizlo fpi...@apple.com + It should be possible to load from Float64 arrays on ARMv7 without crashing https://bugs.webkit.org/show_bug.cgi?id=84361 Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (114663 => 114664) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2012-04-19 18:56:01 UTC (rev 114663) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2012-04-19 19:08:58 UTC (rev 114664) @@ -1701,6 +1701,7 @@ ret .exception: preserveReturnAddressAfterCall(t1) # This is really only needed on X86 +loadi ArgumentCount + TagOffset[cfr], PC callSlowPath(_llint_throw_from_native_call) jmp _llint_throw_from_slow_path_trampoline end Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (114663 => 114664) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm 2012-04-19 18:56:01 UTC (rev 114663) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm 2012-04-19 19:08:58 UTC (rev 114664) @@ -1530,6 +1530,9 @@ ret .exception: preserveReturnAddressAfterCall(t1) +loadi ArgumentCount + TagOffset[cfr], PC +loadp CodeBlock[cfr], PB +loadp CodeBlock::m_instructions[PB], PB callSlowPath(_llint_throw_from_native_call) jmp _llint_throw_from_slow_path_trampoline end ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114665] trunk/Source/WebKit2
Title: [114665] trunk/Source/WebKit2
Revision 114665
Author commit-qu...@webkit.org
Date 2012-04-19 12:12:42 -0700 (Thu, 19 Apr 2012)
Log Message
DevTools: assertion failure upon devtools window reopen.
https://bugs.webkit.org/show_bug.cgi?id=53493
Patch by Vivek Galatage vivekgalat...@gmail.com on 2012-04-19
Reviewed by Pavel Feldman.
The pointers pointed to by WebInspector must be reset explicitly
in WebInspector::didClose() method
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::closeInspectorFrontend):
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::didClose):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (114664 => 114665)
--- trunk/Source/WebKit2/ChangeLog 2012-04-19 19:08:58 UTC (rev 114664)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-19 19:12:42 UTC (rev 114665)
@@ -1,3 +1,18 @@
+2012-04-19 Vivek Galatage vivekgalat...@gmail.com
+
+DevTools: assertion failure upon devtools window reopen.
+https://bugs.webkit.org/show_bug.cgi?id=53493
+
+Reviewed by Pavel Feldman.
+
+The pointers pointed to by WebInspector must be reset explicitly
+in WebInspector::didClose() method
+
+* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+(WebKit::WebInspectorClient::closeInspectorFrontend):
+* WebProcess/WebPage/WebInspector.cpp:
+(WebKit::WebInspector::didClose):
+
2012-04-19 Zalan Bujtas zbuj...@gmail.com
[Qt][WK2] Zoom out on the second double click does not always scale right.
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp (114664 => 114665)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2012-04-19 19:08:58 UTC (rev 114664)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2012-04-19 19:12:42 UTC (rev 114665)
@@ -53,7 +53,6 @@
{
if (m_page-inspector()) {
m_page-inspector()-didClose();
-m_page-inspector()-destroyInspectorPage();
}
}
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp (114664 => 114665)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2012-04-19 19:08:58 UTC (rev 114664)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2012-04-19 19:12:42 UTC (rev 114665)
@@ -102,6 +102,7 @@
void WebInspector::didClose()
{
WebProcess::shared().connection()-send(Messages::WebInspectorProxy::DidClose(), m_page-pageID());
+destroyInspectorPage();
}
void WebInspector::bringToFront()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114666] trunk
Title: [114666] trunk Revision 114666 Author commit-qu...@webkit.org Date 2012-04-19 13:15:18 -0700 (Thu, 19 Apr 2012) Log Message Positioned children of ruby runs not handled correctly during layout https://bugs.webkit.org/show_bug.cgi?id=84157 Patch by Ken Buchanan ke...@chromium.org on 2012-04-19 Reviewed by Julien Chaffraix. Source/WebCore: A positioned ruby text causes a problem because it is excluded from normal layout by its parent and instead gets layout from RenderRubyRun::layoutSpecialExcludedChild; however this means it gets skipped over during the loop in RenderBlock::layoutBlockChildren, which is where positioned RenderBlocks get added to the appropriate positioned object lists. As a result, a dirty positioned ruby text will not get layout again unless the RenderRubyRun also needs layout which is not guaranteed. This patch disqualifies ruby text elements from being positioned. If it is necessary to support this in future, ruby text layout will have to be modified to ensure the renderers are added to the appropriate block lists. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): * rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::rubyText): LayoutTests: * fast/ruby/modify-positioned-ruby-text-crash-expected.txt: Added * fast/ruby/modify-positioned-ruby-text-crash.html: Exercises the crash condition in but 84157 relating to positioned ruby text. This is being added in case support for positioned ruby text is added in future, so that we can guard against regression. * fast/ruby/floating-ruby-text-expected.png: Added * fast/ruby/floating-ruby-text-expected.txt: Added * fast/ruby/floating-ruby-text.html: Creates a positioned ruby text. The position should be ignored. * fast/ruby/positioned-ruby-text-expected.png: Added * fast/ruby/positioned-ruby-text-expected.txt: Added * fast/ruby/positioned-ruby-text.html: Creates a floating ruby text. The float should be ignored. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/rendering/RenderRubyRun.cpp Added Paths trunk/LayoutTests/fast/ruby/floating-ruby-text-expected.png trunk/LayoutTests/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/fast/ruby/floating-ruby-text.html trunk/LayoutTests/fast/ruby/modify-positioned-ruby-text-crash-expected.txt trunk/LayoutTests/fast/ruby/modify-positioned-ruby-text-crash.html trunk/LayoutTests/fast/ruby/positioned-ruby-text-expected.png trunk/LayoutTests/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/fast/ruby/positioned-ruby-text.html Diff Modified: trunk/LayoutTests/ChangeLog (114665 => 114666) --- trunk/LayoutTests/ChangeLog 2012-04-19 19:12:42 UTC (rev 114665) +++ trunk/LayoutTests/ChangeLog 2012-04-19 20:15:18 UTC (rev 114666) @@ -1,3 +1,24 @@ +2012-04-19 Ken Buchanan ke...@chromium.org + +Positioned children of ruby runs not handled correctly during layout +https://bugs.webkit.org/show_bug.cgi?id=84157 + +Reviewed by Julien Chaffraix. + +* fast/ruby/modify-positioned-ruby-text-crash-expected.txt: Added +* fast/ruby/modify-positioned-ruby-text-crash.html: Exercises the crash condition +in but 84157 relating to positioned ruby text. This is being added +in case support for positioned ruby text is added in future, so that +we can guard against regression. +* fast/ruby/floating-ruby-text-expected.png: Added +* fast/ruby/floating-ruby-text-expected.txt: Added +* fast/ruby/floating-ruby-text.html: Creates a positioned ruby text. The +position should be ignored. +* fast/ruby/positioned-ruby-text-expected.png: Added +* fast/ruby/positioned-ruby-text-expected.txt: Added +* fast/ruby/positioned-ruby-text.html: Creates a floating ruby text. The +float should be ignored. + 2012-04-19 vse...@chromium.org vse...@chromium.org Web Inspector: No response body available for cached resource requests with error status codes. Added: trunk/LayoutTests/fast/ruby/floating-ruby-text-expected.png (0 => 114666) --- trunk/LayoutTests/fast/ruby/floating-ruby-text-expected.png (rev 0) +++ trunk/LayoutTests/fast/ruby/floating-ruby-text-expected.png 2012-04-19 20:15:18 UTC (rev 114666) @@ -0,0 +1,6 @@ +\x89PNG + + +IHDR X ' )tEXtchecksum 853de00567d121bea0b7bece66a5d61c`7\xFF\xFB +\xAAIDATx\x9C\xED\xD6\xC1 \xC00u\xFF\x9D\xCF% +\x82$\xF4\xD9=3 \x80\xCEy
[webkit-changes] [114667] trunk/LayoutTests
Title: [114667] trunk/LayoutTests Revision 114667 Author ph...@webkit.org Date 2012-04-19 13:34:13 -0700 (Thu, 19 Apr 2012) Log Message Unreviewed, GTK test_expectations update after r114640. * platform/gtk/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (114666 => 114667) --- trunk/LayoutTests/ChangeLog 2012-04-19 20:15:18 UTC (rev 114666) +++ trunk/LayoutTests/ChangeLog 2012-04-19 20:34:13 UTC (rev 114667) @@ -1,3 +1,9 @@ +2012-04-19 Philippe Normand pnorm...@igalia.com + +Unreviewed, GTK test_expectations update after r114640. + +* platform/gtk/test_expectations.txt: + 2012-04-19 Ken Buchanan ke...@chromium.org Positioned children of ruby runs not handled correctly during layout Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (114666 => 114667) --- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-19 20:15:18 UTC (rev 114666) +++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-19 20:34:13 UTC (rev 114667) @@ -1551,6 +1551,8 @@ BUGWK73744 : fast/table/td-width-fifty-percent-regression.html = FAIL +BUGWK84378 : media/track/track-cue-rendering-snap-to-lines-not-set.html = FAIL + // // End of Tests failing // ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114668] trunk/Source/WebKit/chromium
Title: [114668] trunk/Source/WebKit/chromium
Revision 114668
Author pilg...@chromium.org
Date 2012-04-19 13:53:03 -0700 (Thu, 19 Apr 2012)
Log Message
[Chromium] Call audioHardwareBufferSize directly
https://bugs.webkit.org/show_bug.cgi?id=84370
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (114667 => 114668)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 20:34:13 UTC (rev 114667)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 20:53:03 UTC (rev 114668)
@@ -1,3 +1,15 @@
+2012-04-19 Mark Pilgrim pilg...@chromium.org
+
+[Chromium] Call audioHardwareBufferSize directly
+https://bugs.webkit.org/show_bug.cgi?id=84370
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/AudioDestinationChromium.cpp:
+(WebCore::AudioDestinationChromium::AudioDestinationChromium):
+
2012-04-19 Sami Kyostila skyos...@chromium.org
[chromium] Add tests for scrolling non-root layers in the compositor thread
Modified: trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp (114667 => 114668)
--- trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp 2012-04-19 20:34:13 UTC (rev 114667)
+++ trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp 2012-04-19 20:53:03 UTC (rev 114668)
@@ -63,7 +63,7 @@
, m_isPlaying(false)
{
// Use the optimal buffer size recommended by the audio backend.
-m_callbackBufferSize = webKitPlatformSupport()-audioHardwareBufferSize();
+m_callbackBufferSize = WebKit::Platform::current()-audioHardwareBufferSize();
// Quick exit if the requested size is too large.
ASSERT(m_callbackBufferSize + renderBufferSize = fifoSize);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114669] trunk/Source/WebCore
Title: [114669] trunk/Source/WebCore
Revision 114669
Author macpher...@chromium.org
Date 2012-04-19 14:20:23 -0700 (Thu, 19 Apr 2012)
Log Message
Initialize all member variables in CSSImageSetValue's copy constructor.
https://bugs.webkit.org/show_bug.cgi?id=84379
Reviewed by Simon Fraser.
No new tests / code cleanup only.
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::CSSImageSetValue):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSImageSetValue.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114668 => 114669)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 20:53:03 UTC (rev 114668)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 21:20:23 UTC (rev 114669)
@@ -1,3 +1,15 @@
+2012-04-19 Luke Macpherson macpher...@chromium.org
+
+Initialize all member variables in CSSImageSetValue's copy constructor.
+https://bugs.webkit.org/show_bug.cgi?id=84379
+
+Reviewed by Simon Fraser.
+
+No new tests / code cleanup only.
+
+* css/CSSImageSetValue.cpp:
+(WebCore::CSSImageSetValue::CSSImageSetValue):
+
2012-04-19 Ken Buchanan ke...@chromium.org
Positioned children of ruby runs not handled correctly during layout
Modified: trunk/Source/WebCore/css/CSSImageSetValue.cpp (114668 => 114669)
--- trunk/Source/WebCore/css/CSSImageSetValue.cpp 2012-04-19 20:53:03 UTC (rev 114668)
+++ trunk/Source/WebCore/css/CSSImageSetValue.cpp 2012-04-19 21:20:23 UTC (rev 114669)
@@ -142,6 +142,7 @@
CSSImageSetValue::CSSImageSetValue(const CSSImageSetValue cloneFrom)
: CSSValueList(cloneFrom)
, m_accessedBestFitImage(false)
+, m_scaleFactor(1)
{
// Non-CSSValueList data is not accessible through CSS OM, no need to clone.
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114670] trunk/Source/WebCore
Title: [114670] trunk/Source/WebCore Revision 114670 Author macpher...@chromium.org Date 2012-04-19 14:22:29 -0700 (Thu, 19 Apr 2012) Log Message Remove unnecessary assignment in CSSParser::parseCubicBezierTimingFunctionValue(). https://bugs.webkit.org/show_bug.cgi?id=84368 Reviewed by Simon Fraser. No new tests / code cleanup only. * css/CSSParser.cpp: (WebCore::CSSParser::parseCubicBezierTimingFunctionValue): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSParser.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (114669 => 114670) --- trunk/Source/WebCore/ChangeLog 2012-04-19 21:20:23 UTC (rev 114669) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 21:22:29 UTC (rev 114670) @@ -1,5 +1,17 @@ 2012-04-19 Luke Macpherson macpher...@chromium.org +Remove unnecessary assignment in CSSParser::parseCubicBezierTimingFunctionValue(). +https://bugs.webkit.org/show_bug.cgi?id=84368 + +Reviewed by Simon Fraser. + +No new tests / code cleanup only. + +* css/CSSParser.cpp: +(WebCore::CSSParser::parseCubicBezierTimingFunctionValue): + +2012-04-19 Luke Macpherson macpher...@chromium.org + Initialize all member variables in CSSImageSetValue's copy constructor. https://bugs.webkit.org/show_bug.cgi?id=84379 Modified: trunk/Source/WebCore/css/CSSParser.cpp (114669 => 114670) --- trunk/Source/WebCore/css/CSSParser.cpp 2012-04-19 21:20:23 UTC (rev 114669) +++ trunk/Source/WebCore/css/CSSParser.cpp 2012-04-19 21:22:29 UTC (rev 114670) @@ -3658,7 +3658,7 @@ return true; if (!isComma(v)) return false; -v = args-next(); +args-next(); return true; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114671] trunk/Source
Title: [114671] trunk/Source
Revision 114671
Author pilg...@chromium.org
Date 2012-04-19 14:24:09 -0700 (Thu, 19 Apr 2012)
Log Message
[Chromium] Call signedPublicKeyAndChallengeString directly
https://bugs.webkit.org/show_bug.cgi?id=84372
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/SSLKeyGeneratorChromium.cpp:
(WebCore::signedPublicKeyAndChallengeString):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/chromium/SSLKeyGeneratorChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114670 => 114671)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 21:22:29 UTC (rev 114670)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 21:24:09 UTC (rev 114671)
@@ -1,3 +1,17 @@
+2012-04-19 Mark Pilgrim pilg...@chromium.org
+
+[Chromium] Call signedPublicKeyAndChallengeString directly
+https://bugs.webkit.org/show_bug.cgi?id=84372
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/chromium/SSLKeyGeneratorChromium.cpp:
+(WebCore::signedPublicKeyAndChallengeString):
+
2012-04-19 Luke Macpherson macpher...@chromium.org
Remove unnecessary assignment in CSSParser::parseCubicBezierTimingFunctionValue().
Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (114670 => 114671)
--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-04-19 21:22:29 UTC (rev 114670)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-04-19 21:24:09 UTC (rev 114671)
@@ -191,9 +191,6 @@
static void notifyJSOutOfMemory(Frame*);
static bool allowScriptDespiteSettings(const KURL documentURL);
-// Keygen -
-static String signedPublicKeyAndChallengeString(unsigned keySizeIndex, const String challenge, const KURL);
-
// Language ---
static String computedDefaultLanguage();
Modified: trunk/Source/WebCore/platform/chromium/SSLKeyGeneratorChromium.cpp (114670 => 114671)
--- trunk/Source/WebCore/platform/chromium/SSLKeyGeneratorChromium.cpp 2012-04-19 21:22:29 UTC (rev 114670)
+++ trunk/Source/WebCore/platform/chromium/SSLKeyGeneratorChromium.cpp 2012-04-19 21:24:09 UTC (rev 114671)
@@ -31,9 +31,12 @@
#include config.h
#include SSLKeyGenerator.h
-#include PlatformSupport.h
#include PlatformString.h
+#include public/Platform.h
+#include public/WebString.h
+#include public/WebURL.h
+
namespace WebCore {
// These are defined in webkit/api/src/LocalizedStrings.cpp.
@@ -49,7 +52,9 @@
String signedPublicKeyAndChallengeString(unsigned keySizeIndex, const String challengeString, const KURL url)
{
-return PlatformSupport::signedPublicKeyAndChallengeString(keySizeIndex, challengeString, url);
+return WebKit::Platform::current()-signedPublicKeyAndChallengeString(keySizeIndex,
+ WebKit::WebString(challengeString),
+ WebKit::WebURL(url));
}
} // namespace WebCore
Modified: trunk/Source/WebKit/chromium/ChangeLog (114670 => 114671)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 21:22:29 UTC (rev 114670)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 21:24:09 UTC (rev 114671)
@@ -1,5 +1,17 @@
2012-04-19 Mark Pilgrim pilg...@chromium.org
+[Chromium] Call signedPublicKeyAndChallengeString directly
+https://bugs.webkit.org/show_bug.cgi?id=84372
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/PlatformSupport.cpp:
+(WebCore):
+
+2012-04-19 Mark Pilgrim pilg...@chromium.org
+
[Chromium] Call audioHardwareBufferSize directly
https://bugs.webkit.org/show_bug.cgi?id=84370
Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (114670 => 114671)
--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp 2012-04-19 21:22:29 UTC (rev 114670)
+++ trunk/Source/WebKit/chromium/src/PlatformSupport.cpp 2012-04-19 21:24:09 UTC (rev 114671)
@@ -539,16 +539,6 @@
return webKitPlatformSupport()-injectIDBKeyIntoSerializedValue(key, value, keyPath);
}
-// Keygen -
-
-String PlatformSupport::signedPublicKeyAndChallengeString(
-unsigned keySizeIndex, const String challenge, const KURL url)
-{
-return
[webkit-changes] [114673] trunk/LayoutTests
Title: [114673] trunk/LayoutTests Revision 114673 Author barraclo...@apple.com Date 2012-04-19 14:29:41 -0700 (Thu, 19 Apr 2012) Log Message Check in correct expectations for some passing tests. Rubber stamped by Oliver Hunt. * platform/mac/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (114672 => 114673) --- trunk/LayoutTests/ChangeLog 2012-04-19 21:26:45 UTC (rev 114672) +++ trunk/LayoutTests/ChangeLog 2012-04-19 21:29:41 UTC (rev 114673) @@ -1,3 +1,11 @@ +2012-04-19 Gavin Barraclough barraclo...@apple.com + +Check in correct expectations for some passing tests. + +Rubber stamped by Oliver Hunt. + +* platform/mac/test_expectations.txt: + 2012-04-19 David Grogan dgro...@chromium.org Remove description from calls to indexedDB.open Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (114672 => 114673) --- trunk/LayoutTests/platform/mac/test_expectations.txt 2012-04-19 21:26:45 UTC (rev 114672) +++ trunk/LayoutTests/platform/mac/test_expectations.txt 2012-04-19 21:29:41 UTC (rev 114673) @@ -21,8 +21,6 @@ BUGWK57688 : fast/text/international/bidi-CS-after-AN.html = PASS TEXT BUGWK57688 : fast/text/international/thai-line-breaks.html = PASS TEXT -BUGWK58192 : plugins/npp-set-window-called-during-destruction.html = TEXT - // Flaky tests when run multi-process BUGWK58192 : fast/dom/frame-loading-via-document-write.html = TEXT PASS BUGWK58192 : http/tests/appcache/fail-on-update-2.html = TEXT PASS @@ -163,7 +161,6 @@ // Those tests need a text baseline after lazily allocating layers. // The change should only be layer removal. -BUGWK75568 : animations/combo-transform-translate+scale.html = TEXT BUGWK75568 : editing/spelling/inline_spelling_markers.html = TEXT BUGWK75568 : fast/forms/form-element-geometry.html = TEXT BUGWK75568 : fast/forms/input-value.html = TEXT @@ -235,9 +232,7 @@ BUGWK75568 : fast/forms/input-appearance-disabled.html = TEXT BUGWK75568 : fast/forms/input-appearance-focus.html = TEXT BUGWK75568 : fast/forms/input-appearance-height.html = TEXT -BUGWK75568 : fast/forms/input-appearance-preventDefault.html = TEXT BUGWK75568 : fast/forms/input-appearance-readonly.html = TEXT -BUGWK75568 : fast/forms/input-appearance-selection.html = TEXT BUGWK75568 : fast/forms/input-appearance-visibility.html = TEXT BUGWK75568 : fast/forms/input-appearance-width.html = TEXT BUGWK75568 : fast/forms/input-baseline.html = TEXT @@ -261,7 +256,6 @@ BUGWK75568 : fast/forms/plaintext-mode-2.html = TEXT BUGWK75568 : fast/forms/search-cancel-button-style-sharing.html = TEXT BUGWK75568 : fast/forms/search-display-none-cancel-button.html = TEXT -BUGWK75568 : fast/forms/search-rtl.html = TEXT BUGWK75568 : fast/forms/search-styled.html = TEXT BUGWK75568 : fast/forms/search-vertical-alignment.html = TEXT BUGWK75568 : fast/forms/searchfield-heights.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114674] trunk/LayoutTests
Title: [114674] trunk/LayoutTests
Revision 114674
Author jer.no...@apple.com
Date 2012-04-19 14:32:41 -0700 (Thu, 19 Apr 2012)
Log Message
REGRESSION (r114666): fast/ruby/floating-ruby-text.html, fast/ruby/positioned-ruby-text.html failing on Lion Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84384
Add platform/mac baselines for new ruby tests.
* platform/mac/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/mac/fast/ruby/floating-ruby-text-expected.txt
trunk/LayoutTests/platform/mac/fast/ruby/positioned-ruby-text-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (114673 => 114674)
--- trunk/LayoutTests/ChangeLog 2012-04-19 21:29:41 UTC (rev 114673)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 21:32:41 UTC (rev 114674)
@@ -1,3 +1,13 @@
+2012-04-19 Jer Noble jer.no...@apple.com
+
+REGRESSION (r114666): fast/ruby/floating-ruby-text.html, fast/ruby/positioned-ruby-text.html failing on Lion Release (Tests)
+https://bugs.webkit.org/show_bug.cgi?id=84384
+
+Add platform/mac baselines for new ruby tests.
+
+* platform/mac/fast/ruby/floating-ruby-text-expected.txt: Added.
+* platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Added.
+
2012-04-19 Gavin Barraclough barraclo...@apple.com
Check in correct expectations for some passing tests.
Added: trunk/LayoutTests/platform/mac/fast/ruby/floating-ruby-text-expected.txt (0 => 114674)
--- trunk/LayoutTests/platform/mac/fast/ruby/floating-ruby-text-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/ruby/floating-ruby-text-expected.txt 2012-04-19 21:32:41 UTC (rev 114674)
@@ -0,0 +1,15 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x43
+ RenderBlock {HTML} at (0,0) size 800x43
+RenderBody {BODY} at (8,8) size 784x27
+ RenderRuby (inline) {RUBY} at (0,0) size 784x10 [color=#FF]
+RenderRubyRun (anonymous) at (0,5) size 784x20
+ RenderRubyText {RT} at (0,-5) size 784x5
+RenderText {#text} at (372,0) size 40x5
+ text run at (372,0) width 40: rubytext
+ RenderRubyBase (anonymous) at (0,0) size 784x20
+RenderText {#text} at (0,0) size 784x20
+ text run at (0,0) width 784: Attempt to create a floating ruby text element. Float is not supported for
+ text run at (0,10) width 784: ruby text, which should be apparent from the resulting render tree.
+ RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/platform/mac/fast/ruby/positioned-ruby-text-expected.txt (0 => 114674)
--- trunk/LayoutTests/platform/mac/fast/ruby/positioned-ruby-text-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/ruby/positioned-ruby-text-expected.txt 2012-04-19 21:32:41 UTC (rev 114674)
@@ -0,0 +1,16 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x53
+ RenderBlock {HTML} at (0,0) size 800x53
+RenderBody {BODY} at (8,8) size 784x37
+ RenderRuby (inline) {RUBY} at (0,0) size 784x10 [color=#FF]
+RenderRubyRun (anonymous) at (0,5) size 784x30
+ RenderRubyText {RT} at (0,-5) size 784x5
+RenderText {#text} at (372,0) size 40x5
+ text run at (372,0) width 40: rubytext
+ RenderRubyBase (anonymous) at (0,0) size 784x30
+RenderText {#text} at (0,0) size 784x30
+ text run at (0,0) width 784: Attempt to create a positioned ruby text element. Non-static position is not
+ text run at (0,10) width 784: supported for ruby text, which should be apparent from the resulting render
+ text run at (0,20) width 50: tree.
+ RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114675] trunk/Source/JavaScriptCore
Title: [114675] trunk/Source/_javascript_Core
Revision 114675
Author fpi...@apple.com
Date 2012-04-19 14:55:00 -0700 (Thu, 19 Apr 2012)
Log Message
It should be possible to perform debugCall on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84381
Reviewed by Oliver Hunt.
debugCall() was clobbering the argument to the call it was making, leading to a
corrupt ExecState*. This change fixes that issue by using a scratch register that
does not clobber arguments, and it also introduces more assertions that we have
a valid call frame.
* dfg/DFGAssemblyHelpers.cpp:
(DFG):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::selectScratchGPR):
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::selectScratchGPR):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.cpp
trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (114674 => 114675)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-19 21:32:41 UTC (rev 114674)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-19 21:55:00 UTC (rev 114675)
@@ -1,5 +1,33 @@
2012-04-19 Filip Pizlo fpi...@apple.com
+It should be possible to perform debugCall on ARMv7
+https://bugs.webkit.org/show_bug.cgi?id=84381
+
+Reviewed by Oliver Hunt.
+
+debugCall() was clobbering the argument to the call it was making, leading to a
+corrupt ExecState*. This change fixes that issue by using a scratch register that
+does not clobber arguments, and it also introduces more assertions that we have
+a valid call frame.
+
+* dfg/DFGAssemblyHelpers.cpp:
+(DFG):
+(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
+* dfg/DFGAssemblyHelpers.h:
+(JSC::DFG::AssemblyHelpers::selectScratchGPR):
+(AssemblyHelpers):
+(JSC::DFG::AssemblyHelpers::debugCall):
+(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::linkOSRExits):
+* dfg/DFGOSRExitCompiler.cpp:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::selectScratchGPR):
+
+2012-04-19 Filip Pizlo fpi...@apple.com
+
LLInt no-JIT fallback native call trampoline's exception handler incorrectly assumes that
the PB/PC has been preserved
https://bugs.webkit.org/show_bug.cgi?id=84367
Modified: trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.cpp (114674 => 114675)
--- trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.cpp 2012-04-19 21:32:41 UTC (rev 114674)
+++ trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.cpp 2012-04-19 21:55:00 UTC (rev 114675)
@@ -140,6 +140,13 @@
checkCell.link(this);
}
#endif // USE(JSVALUE32_64)
+
+void AssemblyHelpers::jitAssertHasValidCallFrame()
+{
+Jump checkCFR = branchTestPtr(Zero, GPRInfo::callFrameRegister, TrustedImm32(7));
+breakpoint();
+checkCFR.link(this);
+}
#endif // DFG_ENABLE(JIT_ASSERT)
} } // namespace JSC::DFG
Modified: trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h (114674 => 114675)
--- trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h 2012-04-19 21:32:41 UTC (rev 114674)
+++ trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h 2012-04-19 21:55:00 UTC (rev 114675)
@@ -150,6 +150,23 @@
return branch8(Below, Address(structureReg, Structure::typeInfoTypeOffset()), TrustedImm32(ObjectType));
}
+static GPRReg selectScratchGPR(GPRReg preserve1 = InvalidGPRReg, GPRReg preserve2 = InvalidGPRReg, GPRReg preserve3 = InvalidGPRReg, GPRReg preserve4 = InvalidGPRReg)
+{
+if (preserve1 != GPRInfo::regT0 preserve2 != GPRInfo::regT0 preserve3 != GPRInfo::regT0 preserve4 != GPRInfo::regT0)
+return GPRInfo::regT0;
+
+if (preserve1 != GPRInfo::regT1 preserve2 != GPRInfo::regT1 preserve3 != GPRInfo::regT1 preserve4 != GPRInfo::regT1)
+return GPRInfo::regT1;
+
+if (preserve1 != GPRInfo::regT2 preserve2 != GPRInfo::regT2 preserve3 != GPRInfo::regT2 preserve4 != GPRInfo::regT2)
+return GPRInfo::regT2;
+
+if (preserve1 != GPRInfo::regT3 preserve2 != GPRInfo::regT3 preserve3 != GPRInfo::regT3 preserve4 != GPRInfo::regT3)
+return
[webkit-changes] [114676] trunk/Source/WebCore
Title: [114676] trunk/Source/WebCore
Revision 114676
Author macpher...@chromium.org
Date 2012-04-19 14:56:59 -0700 (Thu, 19 Apr 2012)
Log Message
Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
https://bugs.webkit.org/show_bug.cgi?id=84369
Reviewed by Simon Fraser.
No new tests / code cleanup only.
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::MediaQueryExp):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/MediaQueryExp.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114675 => 114676)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 21:55:00 UTC (rev 114675)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 21:56:59 UTC (rev 114676)
@@ -1,3 +1,15 @@
+2012-04-19 Luke Macpherson macpher...@chromium.org
+
+Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
+https://bugs.webkit.org/show_bug.cgi?id=84369
+
+Reviewed by Simon Fraser.
+
+No new tests / code cleanup only.
+
+* css/MediaQueryExp.cpp:
+(WebCore::MediaQueryExp::MediaQueryExp):
+
2012-04-19 Mark Pilgrim pilg...@chromium.org
[Chromium] Call signedPublicKeyAndChallengeString directly
Modified: trunk/Source/WebCore/css/MediaQueryExp.cpp (114675 => 114676)
--- trunk/Source/WebCore/css/MediaQueryExp.cpp 2012-04-19 21:55:00 UTC (rev 114675)
+++ trunk/Source/WebCore/css/MediaQueryExp.cpp 2012-04-19 21:56:59 UTC (rev 114676)
@@ -59,10 +59,10 @@
// currently accepts only integer/integer
RefPtrCSSValueList list = CSSValueList::createCommaSeparated();
-CSSParserValue* value = 0;
+CSSParserValue* value = valueList-current();
bool isValid = true;
-while ((value = valueList-current()) isValid) {
+while (value isValid) {
if (value-unit == CSSParserValue::Operator value-iValue == '/')
list-append(CSSPrimitiveValue::create(/, CSSPrimitiveValue::CSS_STRING));
else if (value-unit == CSSPrimitiveValue::CSS_NUMBER)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114677] trunk
Title: [114677] trunk
Revision 114677
Author macpher...@chromium.org
Date 2012-04-19 15:00:09 -0700 (Thu, 19 Apr 2012)
Log Message
Fix null-pointer dereference in ApplyPropertyZoom::applyValue().
https://bugs.webkit.org/show_bug.cgi?id=84279
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/css/zoom-on-unattached.html
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyZoom::applyValue):
LayoutTests:
* fast/css/zoom-on-unattached-expected.txt: Added.
* fast/css/zoom-on-unattached.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
Added Paths
trunk/LayoutTests/fast/css/zoom-on-unattached-expected.txt
trunk/LayoutTests/fast/css/zoom-on-unattached.html
Diff
Modified: trunk/LayoutTests/ChangeLog (114676 => 114677)
--- trunk/LayoutTests/ChangeLog 2012-04-19 21:56:59 UTC (rev 114676)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 22:00:09 UTC (rev 114677)
@@ -1,3 +1,13 @@
+2012-04-19 Luke Macpherson macpher...@chromium.org
+
+Fix null-pointer dereference in ApplyPropertyZoom::applyValue().
+https://bugs.webkit.org/show_bug.cgi?id=84279
+
+Reviewed by Simon Fraser.
+
+* fast/css/zoom-on-unattached-expected.txt: Added.
+* fast/css/zoom-on-unattached.html: Added.
+
2012-04-19 Jer Noble jer.no...@apple.com
REGRESSION (r114666): fast/ruby/floating-ruby-text.html, fast/ruby/positioned-ruby-text.html failing on Lion Release (Tests)
Added: trunk/LayoutTests/fast/css/zoom-on-unattached-expected.txt (0 => 114677)
--- trunk/LayoutTests/fast/css/zoom-on-unattached-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/zoom-on-unattached-expected.txt 2012-04-19 22:00:09 UTC (rev 114677)
@@ -0,0 +1 @@
+This test passes if it does not crash.
Added: trunk/LayoutTests/fast/css/zoom-on-unattached.html (0 => 114677)
--- trunk/LayoutTests/fast/css/zoom-on-unattached.html (rev 0)
+++ trunk/LayoutTests/fast/css/zoom-on-unattached.html 2012-04-19 22:00:09 UTC (rev 114677)
@@ -0,0 +1,15 @@
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+root = document.createElement(body);
+d = document.implementation.createDocument();
+d.adoptNode(root);
+node = document.createElement(title);
+root.appendChild(node);
+node.setAttribute(style, zoom:document;)
+node.appendChild(node.cloneNode());
+/script
+body
+This test passes if it does not crash.
+/body
Modified: trunk/Source/WebCore/ChangeLog (114676 => 114677)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 21:56:59 UTC (rev 114676)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 22:00:09 UTC (rev 114677)
@@ -1,5 +1,17 @@
2012-04-19 Luke Macpherson macpher...@chromium.org
+Fix null-pointer dereference in ApplyPropertyZoom::applyValue().
+https://bugs.webkit.org/show_bug.cgi?id=84279
+
+Reviewed by Simon Fraser.
+
+Test: fast/css/zoom-on-unattached.html
+
+* css/CSSStyleApplyProperty.cpp:
+(WebCore::ApplyPropertyZoom::applyValue):
+
+2012-04-19 Luke Macpherson macpher...@chromium.org
+
Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
https://bugs.webkit.org/show_bug.cgi?id=84369
Modified: trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp (114676 => 114677)
--- trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp 2012-04-19 21:56:59 UTC (rev 114676)
+++ trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp 2012-04-19 22:00:09 UTC (rev 114677)
@@ -1637,7 +1637,7 @@
selector-setEffectiveZoom(RenderStyle::initialZoom());
selector-setZoom(RenderStyle::initialZoom());
} else if (primitiveValue-getIdent() == CSSValueDocument) {
-float docZoom = selector-document()-renderer()-style()-zoom();
+float docZoom = selector-rootElementStyle() ? selector-rootElementStyle()-zoom() : RenderStyle::initialZoom();
selector-setEffectiveZoom(docZoom);
selector-setZoom(docZoom);
} else if (primitiveValue-isPercentage()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114678] trunk/Source/WebCore
Title: [114678] trunk/Source/WebCore
Revision 114678
Author macpher...@chromium.org
Date 2012-04-19 15:03:01 -0700 (Thu, 19 Apr 2012)
Log Message
Eliminate potential null pointer dereference in CSSStyleSelector::containsUncommonAttributeSelector().
https://bugs.webkit.org/show_bug.cgi?id=84366
Reviewed by Kentaro Hara.
No new tests / code cleanup only.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114677 => 114678)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 22:00:09 UTC (rev 114677)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 22:03:01 UTC (rev 114678)
@@ -1,5 +1,17 @@
2012-04-19 Luke Macpherson macpher...@chromium.org
+Eliminate potential null pointer dereference in CSSStyleSelector::containsUncommonAttributeSelector().
+https://bugs.webkit.org/show_bug.cgi?id=84366
+
+Reviewed by Kentaro Hara.
+
+No new tests / code cleanup only.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+
+2012-04-19 Luke Macpherson macpher...@chromium.org
+
Fix null-pointer dereference in ApplyPropertyZoom::applyValue().
https://bugs.webkit.org/show_bug.cgi?id=84279
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (114677 => 114678)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-04-19 22:00:09 UTC (rev 114677)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-04-19 22:03:01 UTC (rev 114678)
@@ -2307,18 +2307,19 @@
static inline bool containsUncommonAttributeSelector(const CSSSelector* selector)
{
-while (selector) {
+for (; selector; selector = selector-tagHistory()) {
// Allow certain common attributes (used in the default style) in the selectors that match the current element.
if (selector-isAttributeSelector() !isCommonAttributeSelectorAttribute(selector-attribute()))
return true;
if (selectorListContainsUncommonAttributeSelector(selector))
return true;
-if (selector-relation() != CSSSelector::SubSelector)
+if (selector-relation() != CSSSelector::SubSelector) {
+selector = selector-tagHistory();
break;
-selector = selector-tagHistory();
-};
+}
+}
-for (selector = selector-tagHistory(); selector; selector = selector-tagHistory()) {
+for (; selector; selector = selector-tagHistory()) {
if (selector-isAttributeSelector())
return true;
if (selectorListContainsUncommonAttributeSelector(selector))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114679] trunk/Source/WebCore
Title: [114679] trunk/Source/WebCore
Revision 114679
Author commit-qu...@webkit.org
Date 2012-04-19 15:05:38 -0700 (Thu, 19 Apr 2012)
Log Message
Canvas more precisely makes the bounding rect for stroke rendering.
https://bugs.webkit.org/show_bug.cgi?id=75792
Patch by Huang Dongsung luxte...@company100.net on 2012-04-19
Reviewed by Simon Fraser.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
(WebCore::CanvasRenderingContext2D::inflateStrokeRect):
(WebCore):
* html/canvas/CanvasRenderingContext2D.h:
(CanvasRenderingContext2D):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (114678 => 114679)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 22:03:01 UTC (rev 114678)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 22:05:38 UTC (rev 114679)
@@ -1,3 +1,18 @@
+2012-04-19 Huang Dongsung luxte...@company100.net
+
+Canvas more precisely makes the bounding rect for stroke rendering.
+https://bugs.webkit.org/show_bug.cgi?id=75792
+
+Reviewed by Simon Fraser.
+
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::stroke):
+(WebCore::CanvasRenderingContext2D::drawTextInternal):
+(WebCore::CanvasRenderingContext2D::inflateStrokeRect):
+(WebCore):
+* html/canvas/CanvasRenderingContext2D.h:
+(CanvasRenderingContext2D):
+
2012-04-19 Luke Macpherson macpher...@chromium.org
Eliminate potential null pointer dereference in CSSStyleSelector::containsUncommonAttributeSelector().
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (114678 => 114679)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2012-04-19 22:03:01 UTC (rev 114678)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2012-04-19 22:05:38 UTC (rev 114679)
@@ -949,10 +949,7 @@
if (!m_path.isEmpty()) {
FloatRect dirtyRect = m_path.fastBoundingRect();
-// Fast approximation of the stroke's bounding rect.
-// This yields a slightly oversized rect but is very fast
-// compared to Path::strokeBoundingRect().
-dirtyRect.inflate(state().m_miterLimit + state().m_lineWidth);
+inflateStrokeRect(dirtyRect);
c-strokePath(m_path);
didDraw(dirtyRect);
@@ -2102,12 +2099,11 @@
FloatRect textRect = FloatRect(location.x() - fontMetrics.height() / 2, location.y() - fontMetrics.ascent() - fontMetrics.lineGap(),
width + fontMetrics.height(), fontMetrics.lineSpacing());
if (!fill)
-textRect.inflate(c-strokeThickness() / 2);
+inflateStrokeRect(textRect);
#if USE(CG)
CanvasStyle* drawStyle = fill ? state().m_fillStyle.get() : state().m_strokeStyle.get();
if (drawStyle-canvasGradient() || drawStyle-canvasPattern()) {
-// FIXME: The rect is not big enough for miters on stroked text.
IntRect maskRect = enclosingIntRect(textRect);
#if USE(IOSURFACE_CANVAS_BACKING_STORE)
@@ -2162,19 +2158,28 @@
} else
c-drawBidiText(font, textRun, location);
-if (fill)
-didDraw(textRect);
-else {
-// When stroking text, pointy miters can extend outside of textRect, so we
-// punt and dirty the whole canvas.
-didDraw(FloatRect(0, 0, canvas()-width(), canvas()-height()));
-}
+didDraw(textRect);
#if PLATFORM(QT)
Font::setCodePath(oldCodePath);
#endif
}
+void CanvasRenderingContext2D::inflateStrokeRect(FloatRect rect) const
+{
+// Fast approximation of the stroke's bounding rect.
+// This yields a slightly oversized rect but is very fast
+// compared to Path::strokeBoundingRect().
+static const float root2 = sqrt(2);
+float delta = state().m_lineWidth / 2;
+if (state().m_lineJoin == MiterJoin)
+delta *= state().m_miterLimit;
+else if (state().m_lineCap == SquareCap)
+delta *= root2;
+
+rect.inflate(delta);
+}
+
const Font CanvasRenderingContext2D::accessFont()
{
canvas()-document()-updateStyleIfNeeded();
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h (114678 => 114679)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h 2012-04-19 22:03:01 UTC (rev 114678)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h 2012-04-19 22:05:38 UTC (rev 114679)
@@ -312,6 +312,8 @@
PassOwnPtrImageBuffer createCompositingBuffer(const IntRect);
void compositeBuffer(ImageBuffer*, const IntRect, CompositeOperator);
+void inflateStrokeRect(FloatRect) const;
+
templateclass T void fullCanvasCompositedFill(const T);
templateclass T void fullCanvasCompositedDrawImage(T*, ColorSpace, const FloatRect, const FloatRect,
[webkit-changes] [114680] trunk/LayoutTests
Title: [114680] trunk/LayoutTests
Revision 114680
Author commit-qu...@webkit.org
Date 2012-04-19 15:07:51 -0700 (Thu, 19 Apr 2012)
Log Message
Canvas more precisely makes the bounding rect for stroke rendering.
https://bugs.webkit.org/show_bug.cgi?id=75792
Patch by Huang Dongsung luxte...@company100.net on 2012-04-19
Reviewed by Simon Fraser.
* fast/canvas/canvas-strokePath-cap-join-expected.txt: Added.
* fast/canvas/canvas-strokePath-cap-join.html: Added.
* fast/canvas/script-tests/canvas-strokePath-cap-join.js: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/canvas/canvas-strokePath-cap-join-expected.txt
trunk/LayoutTests/fast/canvas/canvas-strokePath-cap-join.html
trunk/LayoutTests/fast/canvas/script-tests/canvas-strokePath-cap-join.js
Diff
Modified: trunk/LayoutTests/ChangeLog (114679 => 114680)
--- trunk/LayoutTests/ChangeLog 2012-04-19 22:05:38 UTC (rev 114679)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 22:07:51 UTC (rev 114680)
@@ -1,3 +1,14 @@
+2012-04-19 Huang Dongsung luxte...@company100.net
+
+Canvas more precisely makes the bounding rect for stroke rendering.
+https://bugs.webkit.org/show_bug.cgi?id=75792
+
+Reviewed by Simon Fraser.
+
+* fast/canvas/canvas-strokePath-cap-join-expected.txt: Added.
+* fast/canvas/canvas-strokePath-cap-join.html: Added.
+* fast/canvas/script-tests/canvas-strokePath-cap-join.js: Added.
+
2012-04-19 Luke Macpherson macpher...@chromium.org
Fix null-pointer dereference in ApplyPropertyZoom::applyValue().
Added: trunk/LayoutTests/fast/canvas/canvas-strokePath-cap-join-expected.txt (0 => 114680)
--- trunk/LayoutTests/fast/canvas/canvas-strokePath-cap-join-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-strokePath-cap-join-expected.txt 2012-04-19 22:07:51 UTC (rev 114680)
@@ -0,0 +1,43 @@
+Ensure correct behavior of canvas with path stroke with cap and join
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS data[0] is 0
+PASS data[0] is 255
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/canvas/canvas-strokePath-cap-join.html (0 => 114680)
--- trunk/LayoutTests/fast/canvas/canvas-strokePath-cap-join.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-strokePath-cap-join.html 2012-04-19 22:07:51 UTC (rev 114680)
@@ -0,0 +1,10 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+script src=""
+script src=""
+/body
+/html
Added: trunk/LayoutTests/fast/canvas/script-tests/canvas-strokePath-cap-join.js (0 => 114680)
--- trunk/LayoutTests/fast/canvas/script-tests/canvas-strokePath-cap-join.js (rev 0)
+++ trunk/LayoutTests/fast/canvas/script-tests/canvas-strokePath-cap-join.js 2012-04-19 22:07:51 UTC (rev 114680)
@@ -0,0 +1,252 @@
+description(Ensure correct behavior of canvas with path stroke with cap and join);
+
+var canvas = document.createElement('canvas');
+document.body.appendChild(canvas);
+canvas.setAttribute('width', '700');
+canvas.setAttribute('height', '200');
+var ctx = canvas.getContext('2d');
+
+ctx.miterLimit = 5;
+ctx.lineWidth = 15;
+
+ctx.fillStyle=rgba(255, 255, 255, 1.0);
+ctx.fillRect(0, 0, 700, 200);
+
+ctx.strokeStyle=rgba(0, 0, 0, 1.0);
+ctx.lineJoin = miter;
+ctx.lineCap = round;
+
+ctx.translate(0, 50);
+ctx.save();
+
+ctx.beginPath();
+ctx.moveTo(10, 100);
+ctx.lineTo(30, 2);
+ctx.lineTo(50, 100);
+ctx.stroke();
+
+ctx.translate(60 ,0);
+ctx.beginPath();
+ctx.moveTo(10, 100);
+ctx.lineTo(30, 3);
+ctx.lineTo(50, 100);
+ctx.stroke();
+
+ctx.translate(90 ,0);
+ctx.save();
+ctx.rotate(0.2);
+ctx.beginPath();
+ctx.moveTo(10, 100);
+ctx.lineTo(30, 3);
+ctx.lineTo(50, 100);
+ctx.closePath();
+ctx.stroke();
+ctx.restore();
+
+ctx.restore();
+
+ctx.lineJoin = bevel;
+ctx.lineCap = square;
+
+ctx.translate(200, 0);
+ctx.save();
+
+ctx.beginPath();
+ctx.moveTo(10, 100);
+ctx.lineTo(30, 2);
+ctx.lineTo(50, 100);
+ctx.stroke();
+
+ctx.translate(60 ,0);
+ctx.beginPath();
+ctx.moveTo(10, 100);
+ctx.lineTo(30, 3);
+ctx.lineTo(50, 100);
+ctx.stroke();
+
+ctx.translate(90 ,0);
+ctx.save();
+ctx.rotate(0.2);
+ctx.beginPath();
+ctx.moveTo(10, 100);
+ctx.lineTo(30, 3);
+ctx.lineTo(50, 100);
+ctx.closePath();
[webkit-changes] [114681] trunk/Websites/webkit.org
Title: [114681] trunk/Websites/webkit.org Revision 114681 Author dba...@webkit.org Date 2012-04-19 15:10:11 -0700 (Thu, 19 Apr 2012) Log Message Update Build Location notice on Mac debug instructions to reflect changes in Xcode 4.3.2 https://bugs.webkit.org/show_bug.cgi?id=84364 Reviewed by Eric Seidel. As of Xcode 4.3.2, the build location Locations Specified by Targets has been renamed to Legacy. * building/debug-mac-uiprocess.html: * building/debug.html: Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/building/debug-mac-uiprocess.html trunk/Websites/webkit.org/building/debug.html Diff Modified: trunk/Websites/webkit.org/ChangeLog (114680 => 114681) --- trunk/Websites/webkit.org/ChangeLog 2012-04-19 22:07:51 UTC (rev 114680) +++ trunk/Websites/webkit.org/ChangeLog 2012-04-19 22:10:11 UTC (rev 114681) @@ -1,3 +1,16 @@ +2012-04-19 Daniel Bates dba...@webkit.org + +Update Build Location notice on Mac debug instructions to reflect changes in Xcode 4.3.2 +https://bugs.webkit.org/show_bug.cgi?id=84364 + +Reviewed by Eric Seidel. + +As of Xcode 4.3.2, the build location Locations Specified by Targets has been renamed to +Legacy. + +* building/debug-mac-uiprocess.html: +* building/debug.html: + 2012-03-13 Rebecca Hauck rha...@adobe.com Working With Code Installing Developer Tools needs to be updated with OS X Lion App Store details Modified: trunk/Websites/webkit.org/building/debug-mac-uiprocess.html (114680 => 114681) --- trunk/Websites/webkit.org/building/debug-mac-uiprocess.html 2012-04-19 22:07:51 UTC (rev 114680) +++ trunk/Websites/webkit.org/building/debug-mac-uiprocess.html 2012-04-19 22:10:11 UTC (rev 114681) @@ -8,7 +8,7 @@ ol lipOpen the WebKit2 Xcode project/p/li /ol -pNote, the Xcode project file depends on the build location specified in the project itself. In Xcode 4, choose Xcode Preferences Locations, click Locations, click the Advanced button, and ensure that the build location is Locations Specified by Targets./p +pNote, the Xcode project file depends on the build location specified in the project itself. In Xcode 4, choose Xcode Preferences Locations, click Locations, click the Advanced button, and ensure that the build location is Legacy./p ol start=2 lipSet the project's build products location/p pTo find the WebKit you built, Xcode needs to know the build products location that codebuild-webkit/code used. You can set the build products location in the project's build settings editor./p Modified: trunk/Websites/webkit.org/building/debug.html (114680 => 114681) --- trunk/Websites/webkit.org/building/debug.html 2012-04-19 22:07:51 UTC (rev 114680) +++ trunk/Websites/webkit.org/building/debug.html 2012-04-19 22:10:11 UTC (rev 114681) @@ -5,7 +5,7 @@ div class=mac-instructions h2Debugging on Mac OS X/h2 -pEach WebKit component -- _javascript_Core, WebCore, and WebKit2 -- contains its own Xcode project that depends on the build location specified in the project itself. In Xcode 4, choose Xcode Preferences Locations, click Locations, click the Advanced button, and ensure that the build location is Locations Specified by Targets./p +pEach WebKit component -- _javascript_Core, WebCore, and WebKit2 -- contains its own Xcode project that depends on the build location specified in the project itself. In Xcode 4, choose Xcode Preferences Locations, click Locations, click the Advanced button, and ensure that the build location is Legacy./p h3Debugging UIProcess/h3 pFollow the instructions on the a href="" UIProcess/a page./p h3Debugging WebProcess/h3 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114682] trunk/Tools
Title: [114682] trunk/Tools
Revision 114682
Author commit-qu...@webkit.org
Date 2012-04-19 15:12:42 -0700 (Thu, 19 Apr 2012)
Log Message
[EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
https://bugs.webkit.org/show_bug.cgi?id=84169
All databases were being created inside ~/.webkit which was causing
flaky tests when running multiple tests in parallel, specially timeouts
due to concurrency.
Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-04-19
Reviewed by Eric Seidel.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
Diff
Modified: trunk/Tools/ChangeLog (114681 => 114682)
--- trunk/Tools/ChangeLog 2012-04-19 22:10:11 UTC (rev 114681)
+++ trunk/Tools/ChangeLog 2012-04-19 22:12:42 UTC (rev 114682)
@@ -1,3 +1,17 @@
+2012-04-19 Thiago Marcos P. Santos thiago.san...@intel.com
+
+[EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
+https://bugs.webkit.org/show_bug.cgi?id=84169
+
+All databases were being created inside ~/.webkit which was causing
+flaky tests when running multiple tests in parallel, specially timeouts
+due to concurrency.
+
+Reviewed by Eric Seidel.
+
+* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+(DumpRenderTreeChrome::initialize):
+
2012-04-19 Dominik Röttsches dominik.rottsc...@linux.intel.com
[GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (114681 => 114682)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-04-19 22:10:11 UTC (rev 114681)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-04-19 22:12:42 UTC (rev 114682)
@@ -141,6 +141,15 @@
m_mainFrame = ewk_view_frame_main_get(m_mainView);
+char* drtTemp = getenv(DUMPRENDERTREE_TEMP);
+if (drtTemp) {
+char path[2048];
+eina_str_join(path, sizeof(path), '/', drtTemp, LocalStorage);
+ewk_settings_local_storage_path_set(path);
+eina_str_join(path, sizeof(path), '/', drtTemp, Databases);
+ewk_settings_web_database_path_set(path);
+}
+
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114683] trunk/Source/WebCore
Title: [114683] trunk/Source/WebCore
Revision 114683
Author psola...@apple.com
Date 2012-04-19 15:33:30 -0700 (Thu, 19 Apr 2012)
Log Message
Incorrect inter-caps in “ShouldSkipMetaData” etc.
https://bugs.webkit.org/show_bug.cgi?id=72159
Reviewed by Dan Bernstein.
No new tests since no change in functionality.
* platform/graphics/ImageSource.h:
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::imageSourceOptions):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ImageSource.h
trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114682 => 114683)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 22:12:42 UTC (rev 114682)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 22:33:30 UTC (rev 114683)
@@ -1,3 +1,23 @@
+2012-04-19 Pratik Solanki psola...@apple.com
+
+Incorrect inter-caps in “ShouldSkipMetaData” etc.
+https://bugs.webkit.org/show_bug.cgi?id=72159
+
+Reviewed by Dan Bernstein.
+
+No new tests since no change in functionality.
+
+* platform/graphics/ImageSource.h:
+* platform/graphics/cg/ImageSourceCG.cpp:
+(WebCore::imageSourceOptions):
+(WebCore::ImageSource::isSizeAvailable):
+(WebCore::ImageSource::frameSizeAtIndex):
+(WebCore::ImageSource::orientationAtIndex):
+(WebCore::ImageSource::getHotSpot):
+(WebCore::ImageSource::repetitionCount):
+(WebCore::ImageSource::createFrameAtIndex):
+(WebCore::ImageSource::frameDurationAtIndex):
+
2012-04-19 Huang Dongsung luxte...@company100.net
Canvas more precisely makes the bounding rect for stroke rendering.
Modified: trunk/Source/WebCore/platform/graphics/ImageSource.h (114682 => 114683)
--- trunk/Source/WebCore/platform/graphics/ImageSource.h 2012-04-19 22:12:42 UTC (rev 114682)
+++ trunk/Source/WebCore/platform/graphics/ImageSource.h 2012-04-19 22:33:30 UTC (rev 114683)
@@ -134,9 +134,9 @@
};
#if USE(CG)
-enum ShouldSkipMetaData {
-DoNotSkipMetaData,
-SkipMetaData
+enum ShouldSkipMetadata {
+DoNotSkipMetadata,
+SkipMetadata
};
#endif
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp (114682 => 114683)
--- trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp 2012-04-19 22:12:42 UTC (rev 114682)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp 2012-04-19 22:33:30 UTC (rev 114683)
@@ -109,7 +109,7 @@
setData(data, allDataReceived);
}
-static CFDictionaryRef imageSourceOptions(ImageSource::ShouldSkipMetaData skipMetaData)
+static CFDictionaryRef imageSourceOptions(ImageSource::ShouldSkipMetadata skipMetadata)
{
static CFDictionaryRef options;
@@ -121,13 +121,13 @@
// and incorrectly return cached metadata if an image is queried once with kCGImageSourceSkipMetaData true
// and then subsequently with kCGImageSourceSkipMetaData false.
// rdar://problem/11148192
-UNUSED_PARAM(skipMetaData);
-const CFBooleanRef imageSourceSkipMetaData = kCFBooleanFalse;
+UNUSED_PARAM(skipMetadata);
+const CFBooleanRef imageSourceSkipMetadata = kCFBooleanFalse;
#else
-const CFBooleanRef imageSourceSkipMetaData = (skipMetaData == ImageSource::SkipMetaData) ? kCFBooleanTrue : kCFBooleanFalse;
+const CFBooleanRef imageSourceSkipMetadata = (skipMetadata == ImageSource::SkipMetadata) ? kCFBooleanTrue : kCFBooleanFalse;
#endif
const void* keys[numOptions] = { kCGImageSourceShouldCache, kCGImageSourceShouldPreferRGB32, kCGImageSourceSkipMetaData };
-const void* values[numOptions] = { kCFBooleanTrue, kCFBooleanTrue, imageSourceSkipMetaData };
+const void* values[numOptions] = { kCFBooleanTrue, kCFBooleanTrue, imageSourceSkipMetadata };
options = CFDictionaryCreate(NULL, keys, values, numOptions,
kCFTypeDictionaryKeyCallBacks, kCFTypeDictionaryValueCallBacks);
}
@@ -185,7 +185,7 @@
// Ragnaros yells: TOO SOON! You have awakened me TOO SOON, Executus!
if (imageSourceStatus = kCGImageStatusIncomplete) {
-RetainPtrCFDictionaryRef image0Properties(AdoptCF, CGImageSourceCopyPropertiesAtIndex(m_decoder, 0, imageSourceOptions(SkipMetaData)));
+RetainPtrCFDictionaryRef image0Properties(AdoptCF, CGImageSourceCopyPropertiesAtIndex(m_decoder, 0, imageSourceOptions(SkipMetadata)));
if (image0Properties) {
CFNumberRef widthNumber = (CFNumberRef)CFDictionaryGetValue(image0Properties.get(), kCGImagePropertyPixelWidth);
CFNumberRef heightNumber =
[webkit-changes] [114684] trunk/Source/JavaScriptCore
Title: [114684] trunk/Source/_javascript_Core
Revision 114684
Author commit-qu...@webkit.org
Date 2012-04-19 15:44:40 -0700 (Thu, 19 Apr 2012)
Log Message
KeywordLookupGenerator.py should take an output file as an argument
https://bugs.webkit.org/show_bug.cgi?id=84292
Patch by Don Olmstead don.olmst...@am.sony.com on 2012-04-19
Reviewed by Eric Seidel.
Extended KeywordLookupGenerator to accept an additional argument specifying an output file. If this argument is found stdout is redirected to a file for the duration of the script.
* KeywordLookupGenerator.py:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/KeywordLookupGenerator.py
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (114683 => 114684)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-19 22:33:30 UTC (rev 114683)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-19 22:44:40 UTC (rev 114684)
@@ -1,3 +1,14 @@
+2012-04-19 Don Olmstead don.olmst...@am.sony.com
+
+KeywordLookupGenerator.py should take an output file as an argument
+https://bugs.webkit.org/show_bug.cgi?id=84292
+
+Reviewed by Eric Seidel.
+
+Extended KeywordLookupGenerator to accept an additional argument specifying an output file. If this argument is found stdout is redirected to a file for the duration of the script.
+
+* KeywordLookupGenerator.py:
+
2012-04-19 Filip Pizlo fpi...@apple.com
It should be possible to perform debugCall on ARMv7
Modified: trunk/Source/_javascript_Core/KeywordLookupGenerator.py (114683 => 114684)
--- trunk/Source/_javascript_Core/KeywordLookupGenerator.py 2012-04-19 22:33:30 UTC (rev 114683)
+++ trunk/Source/_javascript_Core/KeywordLookupGenerator.py 2012-04-19 22:44:40 UTC (rev 114684)
@@ -1,4 +1,5 @@
# Copyright (C) 2011 Apple Inc. All rights reserved.
+# Copyright (C) 2012 Sony Network Entertainment. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -27,6 +28,15 @@
keywordsText = open(sys.argv[1]).read()
+# A second argument signifies that the output
+# should be redirected to a file
+redirect_to_file = len(sys.argv) 2
+
+# Change stdout to point to the file if requested
+if redirect_to_file:
+file_output = open(sys.argv[-1], w)
+sys.stdout = file_output
+
# Observed weights of the most common keywords, rounded to 2.s.d
keyWordWeights = {
catch: 0.01,
@@ -288,3 +298,8 @@
)
trie.printAsC()
+
+# Close the redirected file if requested
+if (redirect_to_file):
+file_output.close()
+sys.stdout = sys.__stdout__
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114685] trunk/LayoutTests
Title: [114685] trunk/LayoutTests
Revision 114685
Author commit-qu...@webkit.org
Date 2012-04-19 15:49:04 -0700 (Thu, 19 Apr 2012)
Log Message
New ruby tests broken on Mac
https://bugs.webkit.org/show_bug.cgi?id=84382
Patch by Ken Buchanan ke...@chromium.org on 2012-04-19
Reviewed by Eric Seidel.
Tweaking new tests to make them render the same on all platforms.
* fast/ruby/floating-ruby-text-expected.txt:
* fast/ruby/floating-ruby-text.html:
* fast/ruby/positioned-ruby-text-expected.txt:
* fast/ruby/positioned-ruby-text.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/ruby/floating-ruby-text-expected.txt
trunk/LayoutTests/fast/ruby/floating-ruby-text.html
trunk/LayoutTests/fast/ruby/positioned-ruby-text-expected.txt
trunk/LayoutTests/fast/ruby/positioned-ruby-text.html
Diff
Modified: trunk/LayoutTests/ChangeLog (114684 => 114685)
--- trunk/LayoutTests/ChangeLog 2012-04-19 22:44:40 UTC (rev 114684)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 22:49:04 UTC (rev 114685)
@@ -1,3 +1,17 @@
+2012-04-19 Ken Buchanan ke...@chromium.org
+
+New ruby tests broken on Mac
+https://bugs.webkit.org/show_bug.cgi?id=84382
+
+Reviewed by Eric Seidel.
+
+Tweaking new tests to make them render the same on all platforms.
+
+* fast/ruby/floating-ruby-text-expected.txt:
+* fast/ruby/floating-ruby-text.html:
+* fast/ruby/positioned-ruby-text-expected.txt:
+* fast/ruby/positioned-ruby-text.html:
+
2012-04-19 Huang Dongsung luxte...@company100.net
Canvas more precisely makes the bounding rect for stroke rendering.
Modified: trunk/LayoutTests/fast/ruby/floating-ruby-text-expected.txt (114684 => 114685)
--- trunk/LayoutTests/fast/ruby/floating-ruby-text-expected.txt 2012-04-19 22:44:40 UTC (rev 114684)
+++ trunk/LayoutTests/fast/ruby/floating-ruby-text-expected.txt 2012-04-19 22:49:04 UTC (rev 114685)
@@ -1,9 +1,9 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x44
- RenderBlock {HTML} at (0,0) size 800x44
-RenderBody {BODY} at (8,8) size 784x28
- RenderRuby (inline) {RUBY} at (0,0) size 784x10 [color=#FF]
+layer at (0,0) size 800x41
+ RenderBlock {HTML} at (0,0) size 800x41 [color=#FF]
+RenderBody {BODY} at (8,8) size 784x25
+ RenderRuby (inline) {RUBY} at (0,0) size 784x10
RenderRubyRun (anonymous) at (0,5) size 784x20
RenderRubyText {RT} at (0,-5) size 784x5
RenderText {#text} at (372,0) size 40x5
Modified: trunk/LayoutTests/fast/ruby/floating-ruby-text.html (114684 => 114685)
--- trunk/LayoutTests/fast/ruby/floating-ruby-text.html 2012-04-19 22:44:40 UTC (rev 114684)
+++ trunk/LayoutTests/fast/ruby/floating-ruby-text.html 2012-04-19 22:49:04 UTC (rev 114685)
@@ -1,4 +1,4 @@
!DOCTYPE html
-html
-ruby style=font-family: ahem; font-size: 10px; -webkit-font-smoothing: none; color: white;Attempt to create a floating ruby text element. Float is not supported for ruby text, which should be apparent from the resulting render tree.rt style=float:leftrubytext/rt/ruby
+html style=font-family: ahem; font-size: 10px; -webkit-font-smoothing: none; color: white;
+rubyAttempt to create a floating ruby text element. Float is not supported for ruby text, which should be apparent from the resulting render tree.rt style=float:leftrubytext/rt/ruby
/html
Modified: trunk/LayoutTests/fast/ruby/positioned-ruby-text-expected.txt (114684 => 114685)
--- trunk/LayoutTests/fast/ruby/positioned-ruby-text-expected.txt 2012-04-19 22:44:40 UTC (rev 114684)
+++ trunk/LayoutTests/fast/ruby/positioned-ruby-text-expected.txt 2012-04-19 22:49:04 UTC (rev 114685)
@@ -1,9 +1,9 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x54
- RenderBlock {HTML} at (0,0) size 800x54
-RenderBody {BODY} at (8,8) size 784x38
- RenderRuby (inline) {RUBY} at (0,0) size 784x10 [color=#FF]
+layer at (0,0) size 800x51
+ RenderBlock {HTML} at (0,0) size 800x51 [color=#FF]
+RenderBody {BODY} at (8,8) size 784x35
+ RenderRuby (inline) {RUBY} at (0,0) size 784x10
RenderRubyRun (anonymous) at (0,5) size 784x30
RenderRubyText {RT} at (0,-5) size 784x5
RenderText {#text} at (372,0) size 40x5
Modified: trunk/LayoutTests/fast/ruby/positioned-ruby-text.html (114684 => 114685)
--- trunk/LayoutTests/fast/ruby/positioned-ruby-text.html 2012-04-19 22:44:40 UTC (rev 114684)
+++ trunk/LayoutTests/fast/ruby/positioned-ruby-text.html 2012-04-19 22:49:04 UTC (rev 114685)
@@ -1,4 +1,4 @@
!DOCTYPE html
-html
-ruby style=font-family: ahem; font-size: 10px; -webkit-font-smoothing: none; color: white;Attempt to create a positioned ruby text element. Non-static position is not supported for ruby text, which should be apparent from the resulting render tree.rt style=position: fixedrubytext/rt/ruby
+html style=font-family: ahem; font-size: 10px; -webkit-font-smoothing: none;
[webkit-changes] [114686] trunk/Source/WebKit/chromium
Title: [114686] trunk/Source/WebKit/chromium
Revision 114686
Author kl...@webkit.org
Date 2012-04-19 15:59:58 -0700 (Thu, 19 Apr 2012)
Log Message
[chromium] Add simplified API for iterating over a WebElement's attributes.
http://webkit.org/b/84183
Reviewed by Dimitri Glazkov.
Add attributeCount(), attributeLocalName(index) and attributeValue(index) to the
WebElement API so that call sites currently using WebNamedNodeMap can be
converted, which will ultimately allow us to refactor WebCore::Attribute
on http://webkit.org/b/83440.
* public/WebElement.h:
* src/WebElement.cpp:
(WebKit::WebElement::attributeCount):
(WebKit::WebElement::attributeLocalName):
(WebKit::WebElement::attributeValue):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebElement.h
trunk/Source/WebKit/chromium/src/WebElement.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (114685 => 114686)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 22:49:04 UTC (rev 114685)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-19 22:59:58 UTC (rev 114686)
@@ -1,3 +1,21 @@
+2012-04-19 Andreas Kling kl...@webkit.org
+
+[chromium] Add simplified API for iterating over a WebElement's attributes.
+http://webkit.org/b/84183
+
+Reviewed by Dimitri Glazkov.
+
+Add attributeCount(), attributeLocalName(index) and attributeValue(index) to the
+WebElement API so that call sites currently using WebNamedNodeMap can be
+converted, which will ultimately allow us to refactor WebCore::Attribute
+on http://webkit.org/b/83440.
+
+* public/WebElement.h:
+* src/WebElement.cpp:
+(WebKit::WebElement::attributeCount):
+(WebKit::WebElement::attributeLocalName):
+(WebKit::WebElement::attributeValue):
+
2012-04-19 Mark Pilgrim pilg...@chromium.org
[Chromium] Call signedPublicKeyAndChallengeString directly
Modified: trunk/Source/WebKit/chromium/public/WebElement.h (114685 => 114686)
--- trunk/Source/WebKit/chromium/public/WebElement.h 2012-04-19 22:49:04 UTC (rev 114685)
+++ trunk/Source/WebKit/chromium/public/WebElement.h 2012-04-19 22:59:58 UTC (rev 114686)
@@ -61,6 +61,9 @@
WEBKIT_EXPORT WebString innerText();
WEBKIT_EXPORT WebDocument document() const;
WEBKIT_EXPORT void requestFullScreen();
+WEBKIT_EXPORT WebString attributeLocalName(unsigned index) const;
+WEBKIT_EXPORT WebString attributeValue(unsigned index) const;
+WEBKIT_EXPORT unsigned attributeCount() const;
// Returns the language code specified for this element. This attribute
// is inherited, so the returned value is drawn from the closest parent
Modified: trunk/Source/WebKit/chromium/src/WebElement.cpp (114685 => 114686)
--- trunk/Source/WebKit/chromium/src/WebElement.cpp 2012-04-19 22:49:04 UTC (rev 114685)
+++ trunk/Source/WebKit/chromium/src/WebElement.cpp 2012-04-19 22:59:58 UTC (rev 114686)
@@ -83,6 +83,27 @@
return !exceptionCode;
}
+unsigned WebElement::attributeCount() const
+{
+if (!constUnwrapElement()-hasAttributes())
+return 0;
+return constUnwrapElement()-attributeCount();
+}
+
+WebString WebElement::attributeLocalName(unsigned index) const
+{
+if (index = attributeCount())
+return WebString();
+return constUnwrapElement()-attributeItem(index)-localName();
+}
+
+WebString WebElement::attributeValue(unsigned index) const
+{
+if (index = attributeCount())
+return WebString();
+return constUnwrapElement()-attributeItem(index)-value();
+}
+
WebNamedNodeMap WebElement::attributes() const
{
return WebNamedNodeMap(m_private-attributes());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114687] trunk/LayoutTests
Title: [114687] trunk/LayoutTests Revision 114687 Author mahesh.kulka...@nokia.com Date 2012-04-19 16:00:06 -0700 (Thu, 19 Apr 2012) Log Message [Qt][Wk2] unskip page-reload-cancel-permission-requests from geolocation for wk2 https://bugs.webkit.org/show_bug.cgi?id=84293 Reviewed by Tor Arne Vestbø. Unskipped page-reload-cancel-permission-requests after r105988. * platform/qt-5.0-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-5.0-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (114686 => 114687) --- trunk/LayoutTests/ChangeLog 2012-04-19 22:59:58 UTC (rev 114686) +++ trunk/LayoutTests/ChangeLog 2012-04-19 23:00:06 UTC (rev 114687) @@ -1,3 +1,14 @@ +2012-04-18 Mahesh Kulkarni mahesh.kulka...@nokia.com + +[Qt][Wk2] unskip page-reload-cancel-permission-requests from geolocation for wk2 +https://bugs.webkit.org/show_bug.cgi?id=84293 + +Reviewed by Tor Arne Vestbø. + +Unskipped page-reload-cancel-permission-requests after r105988. + +* platform/qt-5.0-wk2/Skipped: + 2012-04-19 Ken Buchanan ke...@chromium.org New ruby tests broken on Mac Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (114686 => 114687) --- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-04-19 22:59:58 UTC (rev 114686) +++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-04-19 23:00:06 UTC (rev 114687) @@ -105,10 +105,6 @@ http/tests/inspector inspector -# WebKitTestRunner needs layoutTestController.setGeolocationPermission -# https://bugs.webkit.org/show_bug.cgi?id=42545 -fast/dom/Geolocation/page-reload-cancel-permission-requests.html - # NOT YET TRACKED BY BUG REPORTS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114688] trunk/Source/WebCore
Title: [114688] trunk/Source/WebCore Revision 114688 Author dba...@webkit.org Date 2012-04-19 16:01:48 -0700 (Thu, 19 Apr 2012) Log Message Remove empty directory Source/WebCore/webaudio Changeset 111474 http://trac.webkit.org/changeset/111474 moved all the files in Source/WebCore/webaudio to Source/WebCore/Modules/webaudio. We should remove the empty directory Source/WebCore/webaudio. * webaudio: Removed. Modified Paths trunk/Source/WebCore/ChangeLog Removed Paths trunk/Source/WebCore/webaudio/ Diff Modified: trunk/Source/WebCore/ChangeLog (114687 => 114688) --- trunk/Source/WebCore/ChangeLog 2012-04-19 23:00:06 UTC (rev 114687) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 23:01:48 UTC (rev 114688) @@ -1,3 +1,13 @@ +2012-04-19 Daniel Bates dba...@webkit.org + +Remove empty directory Source/WebCore/webaudio + +Changeset 111474 http://trac.webkit.org/changeset/111474 moved all the files in +Source/WebCore/webaudio to Source/WebCore/Modules/webaudio. We should remove the +empty directory Source/WebCore/webaudio. + +* webaudio: Removed. + 2012-04-19 Pratik Solanki psola...@apple.com Incorrect inter-caps in “ShouldSkipMetaData” etc. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114689] trunk/Source/WebCore
Title: [114689] trunk/Source/WebCore Revision 114689 Author alexis.men...@openbossa.org Date 2012-04-19 16:27:28 -0700 (Thu, 19 Apr 2012) Log Message Unreviewed Qt build warning fix. The file editing/StringHelper.h does not exist. * Target.pri: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Target.pri Diff Modified: trunk/Source/WebCore/ChangeLog (114688 => 114689) --- trunk/Source/WebCore/ChangeLog 2012-04-19 23:01:48 UTC (rev 114688) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 23:27:28 UTC (rev 114689) @@ -1,3 +1,11 @@ +2012-04-19 Alexis Menard alexis.men...@openbossa.org + +Unreviewed Qt build warning fix. + +The file editing/StringHelper.h does not exist. + +* Target.pri: + 2012-04-19 Daniel Bates dba...@webkit.org Remove empty directory Source/WebCore/webaudio Modified: trunk/Source/WebCore/Target.pri (114688 => 114689) --- trunk/Source/WebCore/Target.pri 2012-04-19 23:01:48 UTC (rev 114688) +++ trunk/Source/WebCore/Target.pri 2012-04-19 23:27:28 UTC (rev 114689) @@ -1821,7 +1821,6 @@ editing/SplitElementCommand.h \ editing/SplitTextNodeCommand.h \ editing/SplitTextNodeContainingElementCommand.h \ -editing/StringHelper.h \ editing/TextInsertionBaseCommand.h \ editing/TextIterator.h \ editing/TypingCommand.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114690] trunk/Source/WebCore
Title: [114690] trunk/Source/WebCore
Revision 114690
Author commit-qu...@webkit.org
Date 2012-04-19 16:30:28 -0700 (Thu, 19 Apr 2012)
Log Message
Default to null value for HistoryItem::m_pageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=84385
Patch by Alexandre Elias ael...@google.com on 2012-04-19
Reviewed by Nate Chapin.
Previously, HistoryItem::m_pageScaleFactor defaulted to a value
of 1, making it impossible to determine whether this value was never
set, or intentionally set to 1. This patch introduces a default value
of 0 and makes restoreScrollPositionAndViewState not touch the page
scale factor if this value is still present at time of reload.
This is a no-op change for common navigation scenarios. The
motivation for this change is the corner case of syncing history items
from a desktop browser to a mobile device. In that case, we need a
way to specify that the history item does not contain a
pageScaleFactor so that the mobile device does not display the page
overly zoomed in.
No new tests.
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
* loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/HistoryItem.cpp
trunk/Source/WebCore/loader/HistoryController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114689 => 114690)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 23:27:28 UTC (rev 114689)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 23:30:28 UTC (rev 114690)
@@ -1,3 +1,30 @@
+2012-04-19 Alexandre Elias ael...@google.com
+
+Default to null value for HistoryItem::m_pageScaleFactor
+https://bugs.webkit.org/show_bug.cgi?id=84385
+
+Reviewed by Nate Chapin.
+
+Previously, HistoryItem::m_pageScaleFactor defaulted to a value
+of 1, making it impossible to determine whether this value was never
+set, or intentionally set to 1. This patch introduces a default value
+of 0 and makes restoreScrollPositionAndViewState not touch the page
+scale factor if this value is still present at time of reload.
+
+This is a no-op change for common navigation scenarios. The
+motivation for this change is the corner case of syncing history items
+from a desktop browser to a mobile device. In that case, we need a
+way to specify that the history item does not contain a
+pageScaleFactor so that the mobile device does not display the page
+overly zoomed in.
+
+No new tests.
+
+* history/HistoryItem.cpp:
+(WebCore::HistoryItem::HistoryItem):
+* loader/HistoryController.cpp:
+(WebCore::HistoryController::restoreScrollPositionAndViewState):
+
2012-04-19 Alexis Menard alexis.men...@openbossa.org
Unreviewed Qt build warning fix.
Modified: trunk/Source/WebCore/history/HistoryItem.cpp (114689 => 114690)
--- trunk/Source/WebCore/history/HistoryItem.cpp 2012-04-19 23:27:28 UTC (rev 114689)
+++ trunk/Source/WebCore/history/HistoryItem.cpp 2012-04-19 23:30:28 UTC (rev 114690)
@@ -61,7 +61,7 @@
HistoryItem::HistoryItem()
: m_lastVisitedTime(0)
, m_lastVisitWasHTTPNonGet(false)
-, m_pageScaleFactor(1)
+, m_pageScaleFactor(0)
, m_lastVisitWasFailure(false)
, m_isTargetItem(false)
, m_visitCount(0)
@@ -78,7 +78,7 @@
, m_title(title)
, m_lastVisitedTime(time)
, m_lastVisitWasHTTPNonGet(false)
-, m_pageScaleFactor(1)
+, m_pageScaleFactor(0)
, m_lastVisitWasFailure(false)
, m_isTargetItem(false)
, m_visitCount(0)
@@ -97,7 +97,7 @@
, m_displayTitle(alternateTitle)
, m_lastVisitedTime(time)
, m_lastVisitWasHTTPNonGet(false)
-, m_pageScaleFactor(1)
+, m_pageScaleFactor(0)
, m_lastVisitWasFailure(false)
, m_isTargetItem(false)
, m_visitCount(0)
@@ -117,7 +117,7 @@
, m_title(title)
, m_lastVisitedTime(0)
, m_lastVisitWasHTTPNonGet(false)
-, m_pageScaleFactor(1)
+, m_pageScaleFactor(0)
, m_lastVisitWasFailure(false)
, m_isTargetItem(false)
, m_visitCount(0)
Modified: trunk/Source/WebCore/loader/HistoryController.cpp (114689 => 114690)
--- trunk/Source/WebCore/loader/HistoryController.cpp 2012-04-19 23:27:28 UTC (rev 114689)
+++ trunk/Source/WebCore/loader/HistoryController.cpp 2012-04-19 23:30:28 UTC (rev 114690)
@@ -126,7 +126,7 @@
if (!view-wasScrolledByUser()) {
view-setScrollPosition(m_currentItem-scrollPoint());
Page* page = m_frame-page();
-if (page page-mainFrame() == m_frame)
+if (page page-mainFrame() == m_frame m_currentItem-pageScaleFactor())
page-setPageScaleFactor(m_currentItem-pageScaleFactor(), m_currentItem-scrollPoint());
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [114691] trunk/Source/WebCore
Title: [114691] trunk/Source/WebCore Revision 114691 Author pe...@chromium.org Date 2012-04-19 16:38:47 -0700 (Thu, 19 Apr 2012) Log Message Use sqrtf instead of sqrt in CanvasRenderingContext2D.cpp https://bugs.webkit.org/show_bug.cgi?id=84403 Reviewed by Andreas Kling. r114679 broke Chromium Win and Android bots due to call ambiguity between a double and float argument. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::inflateStrokeRect): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (114690 => 114691) --- trunk/Source/WebCore/ChangeLog 2012-04-19 23:30:28 UTC (rev 114690) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 23:38:47 UTC (rev 114691) @@ -1,3 +1,16 @@ +2012-04-19 Peter Beverloo pe...@chromium.org + +Use sqrtf instead of sqrt in CanvasRenderingContext2D.cpp +https://bugs.webkit.org/show_bug.cgi?id=84403 + +Reviewed by Andreas Kling. + +r114679 broke Chromium Win and Android bots due to call +ambiguity between a double and float argument. + +* html/canvas/CanvasRenderingContext2D.cpp: +(WebCore::CanvasRenderingContext2D::inflateStrokeRect): + 2012-04-19 Alexandre Elias ael...@google.com Default to null value for HistoryItem::m_pageScaleFactor Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (114690 => 114691) --- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2012-04-19 23:30:28 UTC (rev 114690) +++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2012-04-19 23:38:47 UTC (rev 114691) @@ -2170,7 +2170,7 @@ // Fast approximation of the stroke's bounding rect. // This yields a slightly oversized rect but is very fast // compared to Path::strokeBoundingRect(). -static const float root2 = sqrt(2); +static const float root2 = sqrtf(2); float delta = state().m_lineWidth / 2; if (state().m_lineJoin == MiterJoin) delta *= state().m_miterLimit; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114692] trunk/LayoutTests
Title: [114692] trunk/LayoutTests Revision 114692 Author jam...@google.com Date 2012-04-19 16:41:01 -0700 (Thu, 19 Apr 2012) Log Message [chromium] Unreviewed, update chromium expectations for various compositing layout tests * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Removed Paths trunk/LayoutTests/platform/chromium/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt trunk/LayoutTests/platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (114691 => 114692) --- trunk/LayoutTests/ChangeLog 2012-04-19 23:38:47 UTC (rev 114691) +++ trunk/LayoutTests/ChangeLog 2012-04-19 23:41:01 UTC (rev 114692) @@ -1,3 +1,9 @@ +2012-04-19 James Robinson jam...@chromium.org + +[chromium] Unreviewed, update chromium expectations for various compositing layout tests + +* platform/chromium/test_expectations.txt: + 2012-04-18 Mahesh Kulkarni mahesh.kulka...@nokia.com [Qt][Wk2] unskip page-reload-cancel-permission-requests from geolocation for wk2 Deleted: trunk/LayoutTests/platform/chromium/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt (114691 => 114692) --- trunk/LayoutTests/platform/chromium/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt 2012-04-19 23:38:47 UTC (rev 114691) +++ trunk/LayoutTests/platform/chromium/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt 2012-04-19 23:41:01 UTC (rev 114692) @@ -1 +0,0 @@ - Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (114691 => 114692) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-19 23:38:47 UTC (rev 114691) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-19 23:41:01 UTC (rev 114692) @@ -853,7 +853,7 @@ BUGCR8941 WIN : http/tests/xmlhttprequest/web-apps/012.html = FAIL // Has a 150ms setTimeout and seems racy -BUGWK72402 MAC DEBUG : compositing/layer-creation/overflow-scroll-overlap.html = TEXT +BUGWK72402 DEBUG : compositing/layer-creation/overflow-scroll-overlap.html = TEXT // Incrorect results, in incorrect international font metrics. BUGCR20521 WIN : fast/text/atsui-multiple-renderers.html = IMAGE+TEXT @@ -3076,8 +3076,6 @@ BUGWK70641 SNOWLEOPARD : fast/frames/sandboxed-iframe-scripting.html = PASS CRASH -BUGWK70837 : compositing/video/video-poster.html = PASS TIMEOUT TEXT - BUGWK70866 LINUX MAC DEBUG : fast/forms/form-associated-element-crash3.html = TIMEOUT PASS BUGWK72039 RELEASE : fast/forms/form-associated-element-crash3.html = MISSING PASS BUGWK72039 LINUX RELEASE : fast/forms/form-associated-element-crash.html = MISSING PASS @@ -3270,7 +3268,6 @@ BUGWK78159 DEBUG WIN MAC LINUX : compositing/iframes/scrolling-iframe.html = PASS TEXT -BUGWK78175 LEOPARD SNOWLEOPARD : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE BUGV8_1948 : fast/js/dfg-put-by-id-prototype-check.html = TEXT @@ -3682,10 +3679,6 @@ BUGCR121442 LINUX DEBUG : plugins/iframe-shims.html = CRASH TEXT PASS -BUGWK82994 : compositing/reflections/backface-hidden-reflection.html = PASS CRASH - -BUGWK83019 WIN DEBUG : compositing/reflections/nested-reflection-transformed2.html = PASS CRASH - BUGWK83185 MAC DEBUG : fast/writing-mode/relative-positioning-percentages.html = CRASH BUGWK83219 LION : fonts/cursive.html = PASS IMAGE+TEXT BUGWK83324 WIN DEBUG : fast/js/cross-global-object-inline-global-var.html = PASS TEXT Deleted: trunk/LayoutTests/platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png (Binary files differ) Deleted: trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114693] trunk/LayoutTests
Title: [114693] trunk/LayoutTests Revision 114693 Author commit-qu...@webkit.org Date 2012-04-19 16:46:20 -0700 (Thu, 19 Apr 2012) Log Message transforms/no_transform_hit_testing.html is flaky https://bugs.webkit.org/show_bug.cgi?id=82415 Patch by Florin Malita fmal...@google.com on 2012-04-19 Reviewed by Simon Fraser. Convert the test to text-only (dumpAsText) to avoid inconsistent pixel results. * platform/chromium-linux/transforms/no_transform_hit_testing-expected.png: Removed. * platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed. * platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Removed. * platform/chromium-mac/transforms/no_transform_hit_testing-expected.png: Removed. * platform/chromium-win/transforms/no_transform_hit_testing-expected.png: Removed. * platform/chromium-win/transforms/no_transform_hit_testing-expected.txt: Removed. * platform/chromium/test_expectations.txt: * platform/efl/transforms/no_transform_hit_testing-expected.png: Removed. * platform/efl/transforms/no_transform_hit_testing-expected.txt: Removed. * platform/gtk/transforms/no_transform_hit_testing-expected.txt: Removed. * platform/mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed. * platform/mac/transforms/no_transform_hit_testing-expected.png: Removed. * platform/mac/transforms/no_transform_hit_testing-expected.txt: Removed. * platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Removed. * platform/qt/transforms/no_transform_hit_testing-expected.png: Removed. * platform/qt/transforms/no_transform_hit_testing-expected.txt: Removed. * transforms/no_transform_hit_testing-expected.txt: Added. * transforms/no_transform_hit_testing.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/transforms/no_transform_hit_testing.html Added Paths trunk/LayoutTests/transforms/no_transform_hit_testing-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-linux/transforms/no_transform_hit_testing-expected.png trunk/LayoutTests/platform/chromium-mac/transforms/no_transform_hit_testing-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png trunk/LayoutTests/platform/chromium-win/transforms/no_transform_hit_testing-expected.png trunk/LayoutTests/platform/chromium-win/transforms/no_transform_hit_testing-expected.txt trunk/LayoutTests/platform/efl/transforms/no_transform_hit_testing-expected.png trunk/LayoutTests/platform/efl/transforms/no_transform_hit_testing-expected.txt trunk/LayoutTests/platform/gtk/transforms/no_transform_hit_testing-expected.txt trunk/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.png trunk/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.txt trunk/LayoutTests/platform/mac-leopard/transforms/no_transform_hit_testing-expected.png trunk/LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.png trunk/LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.txt trunk/LayoutTests/platform/qt-mac/transforms/no_transform_hit_testing-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (114692 => 114693) --- trunk/LayoutTests/ChangeLog 2012-04-19 23:41:01 UTC (rev 114692) +++ trunk/LayoutTests/ChangeLog 2012-04-19 23:46:20 UTC (rev 114693) @@ -1,3 +1,31 @@ +2012-04-19 Florin Malita fmal...@google.com + +transforms/no_transform_hit_testing.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=82415 + +Reviewed by Simon Fraser. + +Convert the test to text-only (dumpAsText) to avoid inconsistent pixel results. + +* platform/chromium-linux/transforms/no_transform_hit_testing-expected.png: Removed. +* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed. +* platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Removed. +* platform/chromium-mac/transforms/no_transform_hit_testing-expected.png: Removed. +* platform/chromium-win/transforms/no_transform_hit_testing-expected.png: Removed. +* platform/chromium-win/transforms/no_transform_hit_testing-expected.txt: Removed. +* platform/chromium/test_expectations.txt: +* platform/efl/transforms/no_transform_hit_testing-expected.png: Removed. +* platform/efl/transforms/no_transform_hit_testing-expected.txt: Removed. +* platform/gtk/transforms/no_transform_hit_testing-expected.txt: Removed. +* platform/mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed. +* platform/mac/transforms/no_transform_hit_testing-expected.png: Removed. +* platform/mac/transforms/no_transform_hit_testing-expected.txt: Removed. +*
[webkit-changes] [114694] trunk
Title: [114694] trunk
Revision 114694
Author commit-qu...@webkit.org
Date 2012-04-19 16:50:39 -0700 (Thu, 19 Apr 2012)
Log Message
[EFL] DRT console messages should contain only the file name part of local URIs
https://bugs.webkit.org/show_bug.cgi?id=84236
Patch by Christophe Dumez christophe.du...@intel.com on 2012-04-19
Reviewed by Kentaro Hara.
Tools:
Process console messages before printing them in EFL's DumpRenderTree
them so that they contain only the file name part of local URIs. This
is what is expected by test cases.
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(urlSuitableForTestResult):
(onConsoleMessage):
LayoutTests:
Remove from the skip list the tests which expect only the file name
part of local URIs to be displayed in console messages now that it has
been fixed in EFL's DumpRenderTree.
* platform/efl/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (114693 => 114694)
--- trunk/LayoutTests/ChangeLog 2012-04-19 23:46:20 UTC (rev 114693)
+++ trunk/LayoutTests/ChangeLog 2012-04-19 23:50:39 UTC (rev 114694)
@@ -1,3 +1,16 @@
+2012-04-19 Christophe Dumez christophe.du...@intel.com
+
+[EFL] DRT console messages should contain only the file name part of local URIs
+https://bugs.webkit.org/show_bug.cgi?id=84236
+
+Reviewed by Kentaro Hara.
+
+Remove from the skip list the tests which expect only the file name
+part of local URIs to be displayed in console messages now that it has
+been fixed in EFL's DumpRenderTree.
+
+* platform/efl/Skipped:
+
2012-04-19 Florin Malita fmal...@google.com
transforms/no_transform_hit_testing.html is flaky
Modified: trunk/LayoutTests/platform/efl/Skipped (114693 => 114694)
--- trunk/LayoutTests/platform/efl/Skipped 2012-04-19 23:46:20 UTC (rev 114693)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-04-19 23:50:39 UTC (rev 114694)
@@ -1636,20 +1636,6 @@
# BUG: square button is not being drawn as a square
fast/css/square-button-appearance.html
-# BUG: The whole file path is being shown in the console message instead of only the file name.
-http/tests/misc/image-blocked-src-change.html
-http/tests/misc/image-blocked-src-no-change.html
-http/tests/misc/unloadable-script.html
-http/tests/security/frame-loading-via-document-write.html
-http/tests/security/local-CSS-from-remote.html
-http/tests/security/local-_javascript_-from-remote.html
-http/tests/security/local-iFrame-from-remote.html
-http/tests/security/local-image-from-remote.html
-http/tests/security/local-video-poster-from-remote.html
-http/tests/security/local-video-source-from-remote.html
-http/tests/security/local-video-src-from-remote.html
-media/csp-blocks-video.html
-
# BUG: Only works if --gui is passed (due to the current implementation of PlatformScreenEfl::screenRect).
fast/media/invalid-lengths.html
fast/media/matchmedium-query-api.html
Modified: trunk/Tools/ChangeLog (114693 => 114694)
--- trunk/Tools/ChangeLog 2012-04-19 23:46:20 UTC (rev 114693)
+++ trunk/Tools/ChangeLog 2012-04-19 23:50:39 UTC (rev 114694)
@@ -1,3 +1,18 @@
+2012-04-19 Christophe Dumez christophe.du...@intel.com
+
+[EFL] DRT console messages should contain only the file name part of local URIs
+https://bugs.webkit.org/show_bug.cgi?id=84236
+
+Reviewed by Kentaro Hara.
+
+Process console messages before printing them in EFL's DumpRenderTree
+them so that they contain only the file name part of local URIs. This
+is what is expected by test cases.
+
+* DumpRenderTree/efl/DumpRenderTreeView.cpp:
+(urlSuitableForTestResult):
+(onConsoleMessage):
+
2012-04-19 Thiago Marcos P. Santos thiago.san...@intel.com
[EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp (114693 => 114694)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp 2012-04-19 23:46:20 UTC (rev 114693)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp 2012-04-19 23:50:39 UTC (rev 114694)
@@ -35,17 +35,37 @@
#include Evas.h
#include cstdio
#include cstdlib
+#include wtf/NotFound.h
+#include wtf/text/CString.h
+#include wtf/text/WTFString.h
using namespace std;
static Ewk_View_Smart_Class gParentSmartClass = EWK_VIEW_SMART_CLASS_INIT_NULL;
+static WTF::String urlSuitableForTestResult(const WTF::String uriString)
+{
+if (uriString.isEmpty() || !uriString.startsWith(file://))
+return uriString;
+
+const size_t index = uriString.reverseFind('/');
+return (index == WTF::notFound) ? uriString : uriString.substring(index + 1);
+}
+
static void onConsoleMessage(Ewk_View_Smart_Data*, const char* message, unsigned int lineNumber, const char*)
{
+// Tests expect only the filename part of local URIs
+
[webkit-changes] [114695] trunk/Source/JavaScriptCore
Title: [114695] trunk/Source/_javascript_Core
Revision 114695
Author fpi...@apple.com
Date 2012-04-19 16:52:46 -0700 (Thu, 19 Apr 2012)
Log Message
MacroAssemblerARMv7::branchTruncateDoubleToUint32 should obey the overflow signal
https://bugs.webkit.org/show_bug.cgi?id=84401
Reviewed by Gavin Barraclough.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (114694 => 114695)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-19 23:50:39 UTC (rev 114694)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-19 23:52:46 UTC (rev 114695)
@@ -1,3 +1,13 @@
+2012-04-19 Filip Pizlo fpi...@apple.com
+
+MacroAssemblerARMv7::branchTruncateDoubleToUint32 should obey the overflow signal
+https://bugs.webkit.org/show_bug.cgi?id=84401
+
+Reviewed by Gavin Barraclough.
+
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):
+
2012-04-19 Don Olmstead don.olmst...@am.sony.com
KeywordLookupGenerator.py should take an output file as an argument
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (114694 => 114695)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2012-04-19 23:50:39 UTC (rev 114694)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2012-04-19 23:52:46 UTC (rev 114695)
@@ -995,8 +995,17 @@
{
m_assembler.vcvt_floatingPointToSigned(fpTempRegisterAsSingle(), src);
m_assembler.vmov(dest, fpTempRegisterAsSingle());
+
+Jump overflow = branch32(Equal, dest, TrustedImm32(0x7fff));
+Jump success = branch32(GreaterThanOrEqual, dest, TrustedImm32(0));
+overflow.link(this);
-return branch32(branchType ? GreaterThanOrEqual : LessThan, dest, TrustedImm32(0));
+if (branchType == BranchIfTruncateSuccessful)
+return success;
+
+Jump failure = jump();
+success.link(this);
+return failure;
}
// Result is undefined if the value is outside of the integer range.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114696] trunk/Source/WebCore
Title: [114696] trunk/Source/WebCore
Revision 114696
Author commit-qu...@webkit.org
Date 2012-04-19 16:54:49 -0700 (Thu, 19 Apr 2012)
Log Message
[Cairo] Remove rgb24-hacks.txt and scale-removal.txt
https://bugs.webkit.org/show_bug.cgi?id=83475
Patch by Martin Robinson mrobin...@igalia.com on 2012-04-19
Reviewed by Daniel Bates.
No new tests. This does not change functionality.
Remove some obsolete patch files for Cairo that were used in some
very old versions of Safari for Windows.
* platform/graphics/cairo/rgb24-hacks.txt: Removed.
* platform/graphics/cairo/scale-removal.txt: Removed.
Modified Paths
trunk/Source/WebCore/ChangeLog
Removed Paths
trunk/Source/WebCore/platform/graphics/cairo/rgb24-hacks.txt
trunk/Source/WebCore/platform/graphics/cairo/scale-removal.txt
Diff
Modified: trunk/Source/WebCore/ChangeLog (114695 => 114696)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 23:52:46 UTC (rev 114695)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 23:54:49 UTC (rev 114696)
@@ -1,3 +1,18 @@
+2012-04-19 Martin Robinson mrobin...@igalia.com
+
+[Cairo] Remove rgb24-hacks.txt and scale-removal.txt
+https://bugs.webkit.org/show_bug.cgi?id=83475
+
+Reviewed by Daniel Bates.
+
+No new tests. This does not change functionality.
+
+Remove some obsolete patch files for Cairo that were used in some
+very old versions of Safari for Windows.
+
+* platform/graphics/cairo/rgb24-hacks.txt: Removed.
+* platform/graphics/cairo/scale-removal.txt: Removed.
+
2012-04-19 Peter Beverloo pe...@chromium.org
Use sqrtf instead of sqrt in CanvasRenderingContext2D.cpp
Deleted: trunk/Source/WebCore/platform/graphics/cairo/rgb24-hacks.txt (114695 => 114696)
--- trunk/Source/WebCore/platform/graphics/cairo/rgb24-hacks.txt 2012-04-19 23:52:46 UTC (rev 114695)
+++ trunk/Source/WebCore/platform/graphics/cairo/rgb24-hacks.txt 2012-04-19 23:54:49 UTC (rev 114696)
@@ -1,32 +0,0 @@
-Index: cairo/src/cairo-win32-surface.c
-===
cairo/src/cairo-win32-surface.c (revision 14498)
-+++ cairo/src/cairo-win32-surface.c (working copy)
-@@ -824,8 +824,13 @@
- * to figure out when we can use GDI. We don't have that checking
- * anywhere at the moment, so just bail and use the fallback
- * paths. */
--if (surface-format != CAIRO_FORMAT_RGB24)
-- return CAIRO_INT_STATUS_UNSUPPORTED;
-+//if (surface-format != CAIRO_FORMAT_RGB24)
-+// return CAIRO_INT_STATUS_UNSUPPORTED;
-+// FIXME: We'll go ahead and optimize this now and just assume we're ok if
-+// the color has no alpha. Probably need to check various composite operators to
-+// get this exactly right.
-+if (color-alpha != 1.0)
-+return CAIRO_INT_STATUS_UNSUPPORTED;
-
- /* Optimize for no destination alpha (surface-pixman_image is non-NULL for all
- * surfaces with alpha.)
-@@ -1016,8 +1021,9 @@
-
- /* We can only handle operator SOURCE or OVER with the destination
- * having no alpha */
--if ((op != CAIRO_OPERATOR_SOURCE op != CAIRO_OPERATOR_OVER) ||
-- (dst-format != CAIRO_FORMAT_RGB24))
-+if ((op != CAIRO_OPERATOR_SOURCE op != CAIRO_OPERATOR_OVER))
-+// FIXME: It's not clear why ExtTextOut can't be called when the
-+// destination has alpha. Remove the RGB24 restriction. || (dst-format != CAIRO_FORMAT_RGB24))
- return CAIRO_INT_STATUS_UNSUPPORTED;
-
- /* If we have a fallback mask clip set on the dst, we have
Deleted: trunk/Source/WebCore/platform/graphics/cairo/scale-removal.txt (114695 => 114696)
--- trunk/Source/WebCore/platform/graphics/cairo/scale-removal.txt 2012-04-19 23:52:46 UTC (rev 114695)
+++ trunk/Source/WebCore/platform/graphics/cairo/scale-removal.txt 2012-04-19 23:54:49 UTC (rev 114696)
@@ -1,13 +0,0 @@
-Index: cairo/src/cairo-win32-private.h
-===
cairo/src/cairo-win32-private.h (revision 14582)
-+++ cairo/src/cairo-win32-private.h (working copy)
-@@ -39,7 +39,7 @@
- #include cairo-win32.h
- #include cairoint.h
-
--#define WIN32_FONT_LOGICAL_SCALE 32
-+#define WIN32_FONT_LOGICAL_SCALE 1
-
- typedef struct _cairo_win32_surface {
- cairo_surface_t base;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114699] trunk
Title: [114699] trunk
Revision 114699
Author commit-qu...@webkit.org
Date 2012-04-19 17:08:22 -0700 (Thu, 19 Apr 2012)
Log Message
REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216
Patch by David Barr davidb...@chromium.org on 2012-04-19
Reviewed by Ryosuke Niwa.
Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.
No new tests; updated existing tests that should have caught this.
Source/WebCore:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
LayoutTests:
* css3/flexbox/css-properties.html:
* fast/css/cssText-shorthand.html:
* fast/css/uri-token-parsing-expected.txt:
* fast/css/uri-token-parsing.html:
* fast/dom/css-dom-read-2-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/css-properties.html
trunk/LayoutTests/fast/css/cssText-shorthand.html
trunk/LayoutTests/fast/css/uri-token-parsing-expected.txt
trunk/LayoutTests/fast/css/uri-token-parsing.html
trunk/LayoutTests/fast/dom/css-dom-read-2-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/StylePropertySet.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (114698 => 114699)
--- trunk/LayoutTests/ChangeLog 2012-04-20 00:05:37 UTC (rev 114698)
+++ trunk/LayoutTests/ChangeLog 2012-04-20 00:08:22 UTC (rev 114699)
@@ -1,3 +1,21 @@
+2012-04-19 David Barr davidb...@chromium.org
+
+REGRESSION(r112177): Numbered list item rendered bulleted
+https://bugs.webkit.org/show_bug.cgi?id=84216
+
+Reviewed by Ryosuke Niwa.
+
+Shorthands that imply omitted values cannot be derived from
+an incomplete set of longhand rules.
+
+No new tests; updated existing tests that should have caught this.
+
+* css3/flexbox/css-properties.html:
+* fast/css/cssText-shorthand.html:
+* fast/css/uri-token-parsing-expected.txt:
+* fast/css/uri-token-parsing.html:
+* fast/dom/css-dom-read-2-expected.txt:
+
2012-04-19 Christophe Dumez christophe.du...@intel.com
[EFL] DRT console messages should contain only the file name part of local URIs
Modified: trunk/LayoutTests/css3/flexbox/css-properties.html (114698 => 114699)
--- trunk/LayoutTests/css3/flexbox/css-properties.html 2012-04-20 00:05:37 UTC (rev 114698)
+++ trunk/LayoutTests/css3/flexbox/css-properties.html 2012-04-20 00:08:22 UTC (rev 114699)
@@ -249,6 +249,7 @@
shouldBeEqualToString('flexbox.style.webkitFlexFlow', '');
shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexFlow', 'row none');
flexbox.style.webkitFlexDirection = 'column';
+flexbox.style.webkitFlexWrap = 'initial';
shouldBeEqualToString('flexbox.style.webkitFlexFlow', 'column');
shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexFlow', 'column none');
flexbox.style.webkitFlexWrap = 'wrap';
Modified: trunk/LayoutTests/fast/css/cssText-shorthand.html (114698 => 114699)
--- trunk/LayoutTests/fast/css/cssText-shorthand.html 2012-04-20 00:05:37 UTC (rev 114698)
+++ trunk/LayoutTests/fast/css/cssText-shorthand.html 2012-04-20 00:08:22 UTC (rev 114699)
@@ -29,7 +29,7 @@
['font-family: sans-serif; line-height: 2em; font-size: 3em; font-style: italic; font-weight: bold;',
'font-family: sans-serif; line-height: 2em; font-size: 3em; font-style: italic; font-weight: bold;'],
-['list-style-type: circle; list-style-position: inside;', 'list-style: circle inside;'],
+['list-style-type: circle; list-style-position: inside; list-style-image: initial;', 'list-style: circle inside;'],
['margin-top: 1px; margin-right: 2px; margin-bottom: 3px; margin-left: 4px;', 'margin: 1px 2px 3px 4px;'],
['outline-width: 2px; outline-style: dotted; outline-color: blue;', 'outline: blue dotted 2px;'],
['overflow-x: scroll; overflow-y: hidden;', 'overflow: scroll hidden;'],
Modified: trunk/LayoutTests/fast/css/uri-token-parsing-expected.txt (114698 => 114699)
--- trunk/LayoutTests/fast/css/uri-token-parsing-expected.txt 2012-04-20 00:05:37 UTC (rev 114698)
+++ trunk/LayoutTests/fast/css/uri-token-parsing-expected.txt 2012-04-20 00:08:22 UTC (rev 114699)
@@ -19,7 +19,7 @@
#o { content: url(f); }
#p { content: url('url(g)'); }
#q { cursor: url('url(q)'); }
-#r { list-style: url('url(r)'); }
+#r { list-style-image: url('url(r)'); }
#s { background-image: url('url(s)'); }
#t { -webkit-mask: url('url(t)'); }
#u { -webkit-border-image: url('url(u)') 1 2 3 4 fill stretch round; }
@@ -44,7 +44,7 @@
#o { content: url(f); }
#p { content: url('url(g)'); }
#q { cursor: url('url(q)'); }
-#r { list-style: url('url(r)'); }
+#r { list-style-image: url('url(r)'); }
#s { background-image: url('url(s)'); }
#t { -webkit-mask: url('url(t)'); }
#u { -webkit-border-image:
[webkit-changes] [114700] trunk/Source/WebCore
Title: [114700] trunk/Source/WebCore
Revision 114700
Author kl...@webkit.org
Date 2012-04-19 17:11:11 -0700 (Thu, 19 Apr 2012)
Log Message
ElementAttributeData should be fast-malloc'd.
http://webkit.org/b/84405
Reviewed by Antti Koivisto.
Sprinkle missing WTF_MAKE_FAST_ALLOCATED.
* dom/ElementAttributeData.h:
(ElementAttributeData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ElementAttributeData.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (114699 => 114700)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 00:08:22 UTC (rev 114699)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 00:11:11 UTC (rev 114700)
@@ -1,3 +1,15 @@
+2012-04-19 Andreas Kling kl...@webkit.org
+
+ElementAttributeData should be fast-malloc'd.
+http://webkit.org/b/84405
+
+Reviewed by Antti Koivisto.
+
+Sprinkle missing WTF_MAKE_FAST_ALLOCATED.
+
+* dom/ElementAttributeData.h:
+(ElementAttributeData):
+
2012-04-19 David Barr davidb...@chromium.org
REGRESSION(r112177): Numbered list item rendered bulleted
Modified: trunk/Source/WebCore/dom/ElementAttributeData.h (114699 => 114700)
--- trunk/Source/WebCore/dom/ElementAttributeData.h 2012-04-20 00:08:22 UTC (rev 114699)
+++ trunk/Source/WebCore/dom/ElementAttributeData.h 2012-04-20 00:11:11 UTC (rev 114700)
@@ -83,6 +83,7 @@
enum EInUpdateStyleAttribute { NotInUpdateStyleAttribute, InUpdateStyleAttribute };
class ElementAttributeData {
+WTF_MAKE_FAST_ALLOCATED;
public:
static PassOwnPtrElementAttributeData create()
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114701] trunk/LayoutTests
Title: [114701] trunk/LayoutTests Revision 114701 Author dim...@chromium.org Date 2012-04-19 17:12:17 -0700 (Thu, 19 Apr 2012) Log Message [Chromium] Rebaselining new tests added in http://trac.webkit.org/changeset/114666 Not reviewed. * platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt: Added. * platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt: Added. * platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Added. * platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Added. * platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Added. * platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Added. * platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Added. * platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Added. * platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Added. * platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Added. * platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Added. * platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Added. * platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Added. * platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Added. * platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Added. * platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-linux-x86/fast/ruby/ trunk/LayoutTests/platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-win-vista/fast/ruby/ trunk/LayoutTests/platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (114700 => 114701) --- trunk/LayoutTests/ChangeLog 2012-04-20 00:11:11 UTC (rev 114700) +++ trunk/LayoutTests/ChangeLog 2012-04-20 00:12:17 UTC (rev 114701) @@ -1,3 +1,25 @@ +2012-04-19 Dmitry Titov dim...@chromium.org + +[Chromium] Rebaselining new tests added in http://trac.webkit.org/changeset/114666 +Not reviewed. + +* platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt: Added. +* platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt: Added. +* platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Added. +* platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Added. +* platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Added. +* platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Added. +* platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Added. +* platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Added. +* platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Added. +* platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Added. +* platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Added. +* platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Added. +* platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Added. +* platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Added. +* platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Added. +* platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Added. + 2012-04-19 David Barr davidb...@chromium.org REGRESSION(r112177): Numbered
[webkit-changes] [114703] trunk/Source/WebCore
Title: [114703] trunk/Source/WebCore
Revision 114703
Author dim...@chromium.org
Date 2012-04-19 17:33:05 -0700 (Thu, 19 Apr 2012)
Log Message
Unreviewed, rolling out r114690.
http://trac.webkit.org/changeset/114690
https://bugs.webkit.org/show_bug.cgi?id=84408
Broke GlueSerializeTest.BackwardsCompatibleTest in Chromium
test_shell_tests (Requested by dimich on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-04-19
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
* loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/HistoryItem.cpp
trunk/Source/WebCore/loader/HistoryController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114702 => 114703)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 00:17:41 UTC (rev 114702)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 00:33:05 UTC (rev 114703)
@@ -1,3 +1,17 @@
+2012-04-19 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r114690.
+http://trac.webkit.org/changeset/114690
+https://bugs.webkit.org/show_bug.cgi?id=84408
+
+Broke GlueSerializeTest.BackwardsCompatibleTest in Chromium
+test_shell_tests (Requested by dimich on #webkit).
+
+* history/HistoryItem.cpp:
+(WebCore::HistoryItem::HistoryItem):
+* loader/HistoryController.cpp:
+(WebCore::HistoryController::restoreScrollPositionAndViewState):
+
2012-04-19 Andreas Kling kl...@webkit.org
ElementAttributeData should be fast-malloc'd.
Modified: trunk/Source/WebCore/history/HistoryItem.cpp (114702 => 114703)
--- trunk/Source/WebCore/history/HistoryItem.cpp 2012-04-20 00:17:41 UTC (rev 114702)
+++ trunk/Source/WebCore/history/HistoryItem.cpp 2012-04-20 00:33:05 UTC (rev 114703)
@@ -61,7 +61,7 @@
HistoryItem::HistoryItem()
: m_lastVisitedTime(0)
, m_lastVisitWasHTTPNonGet(false)
-, m_pageScaleFactor(0)
+, m_pageScaleFactor(1)
, m_lastVisitWasFailure(false)
, m_isTargetItem(false)
, m_visitCount(0)
@@ -78,7 +78,7 @@
, m_title(title)
, m_lastVisitedTime(time)
, m_lastVisitWasHTTPNonGet(false)
-, m_pageScaleFactor(0)
+, m_pageScaleFactor(1)
, m_lastVisitWasFailure(false)
, m_isTargetItem(false)
, m_visitCount(0)
@@ -97,7 +97,7 @@
, m_displayTitle(alternateTitle)
, m_lastVisitedTime(time)
, m_lastVisitWasHTTPNonGet(false)
-, m_pageScaleFactor(0)
+, m_pageScaleFactor(1)
, m_lastVisitWasFailure(false)
, m_isTargetItem(false)
, m_visitCount(0)
@@ -117,7 +117,7 @@
, m_title(title)
, m_lastVisitedTime(0)
, m_lastVisitWasHTTPNonGet(false)
-, m_pageScaleFactor(0)
+, m_pageScaleFactor(1)
, m_lastVisitWasFailure(false)
, m_isTargetItem(false)
, m_visitCount(0)
Modified: trunk/Source/WebCore/loader/HistoryController.cpp (114702 => 114703)
--- trunk/Source/WebCore/loader/HistoryController.cpp 2012-04-20 00:17:41 UTC (rev 114702)
+++ trunk/Source/WebCore/loader/HistoryController.cpp 2012-04-20 00:33:05 UTC (rev 114703)
@@ -126,7 +126,7 @@
if (!view-wasScrolledByUser()) {
view-setScrollPosition(m_currentItem-scrollPoint());
Page* page = m_frame-page();
-if (page page-mainFrame() == m_frame m_currentItem-pageScaleFactor())
+if (page page-mainFrame() == m_frame)
page-setPageScaleFactor(m_currentItem-pageScaleFactor(), m_currentItem-scrollPoint());
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114704] trunk/LayoutTests
Title: [114704] trunk/LayoutTests Revision 114704 Author jer.no...@apple.com Date 2012-04-19 17:33:11 -0700 (Thu, 19 Apr 2012) Log Message Partial rollout of r114673. Test plugins/npp-set-window-called-during-destruction.html passes on mac-wk2, but fails on mac. Update test_expectations so that both results are expected. * platform/mac/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (114703 => 114704) --- trunk/LayoutTests/ChangeLog 2012-04-20 00:33:05 UTC (rev 114703) +++ trunk/LayoutTests/ChangeLog 2012-04-20 00:33:11 UTC (rev 114704) @@ -1,3 +1,12 @@ +2012-04-19 Jer Noble jer.no...@apple.com + +Partial rollout of r114673. + +Test plugins/npp-set-window-called-during-destruction.html passes on mac-wk2, +but fails on mac. Update test_expectations so that both results are expected. + +* platform/mac/test_expectations.txt: + 2012-04-19 Oliver Hunt oli...@apple.com Exception stack traces aren't complete when the exception starts in native code Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (114703 => 114704) --- trunk/LayoutTests/platform/mac/test_expectations.txt 2012-04-20 00:33:05 UTC (rev 114703) +++ trunk/LayoutTests/platform/mac/test_expectations.txt 2012-04-20 00:33:11 UTC (rev 114704) @@ -21,6 +21,9 @@ BUGWK57688 : fast/text/international/bidi-CS-after-AN.html = PASS TEXT BUGWK57688 : fast/text/international/thai-line-breaks.html = PASS TEXT +// Fails on WK1, but passes on WK2. (No syntax available for this situation.) +BUGWK58192 : plugins/npp-set-window-called-during-destruction.html = TEXT PASS + // Flaky tests when run multi-process BUGWK58192 : fast/dom/frame-loading-via-document-write.html = TEXT PASS BUGWK58192 : http/tests/appcache/fail-on-update-2.html = TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114705] trunk/Source/WebKit2
Title: [114705] trunk/Source/WebKit2
Revision 114705
Author ostapenko.viatches...@nokia.com
Date 2012-04-19 17:37:02 -0700 (Thu, 19 Apr 2012)
Log Message
[Qt] ASSERT(m_thread == currentThread()) on Mac when threaded rendering is enabled for the Qt scenegraph
https://bugs.webkit.org/show_bug.cgi?id=84278
Reviewed by Noam Rosenthal.
Delete the whole layer tree on UI side when paint node is deleted and force resync of the layers when
page becomes visible again.
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::purgeBackingStores):
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
(WebKit::WebLayerTreeRenderer::appendUpdate):
(WebKit::WebLayerTreeRenderer::setActive):
(WebKit):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::ContentsSGNode):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::purgeBackingStores):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp
trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp
trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (114704 => 114705)
--- trunk/Source/WebKit2/ChangeLog 2012-04-20 00:33:11 UTC (rev 114704)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-20 00:37:02 UTC (rev 114705)
@@ -1,3 +1,28 @@
+2012-04-19 Viatcheslav Ostapenko ostapenko.viatches...@nokia.com
+
+[Qt] ASSERT(m_thread == currentThread()) on Mac when threaded rendering is enabled for the Qt scenegraph
+https://bugs.webkit.org/show_bug.cgi?id=84278
+
+Reviewed by Noam Rosenthal.
+
+Delete the whole layer tree on UI side when paint node is deleted and force resync of the layers when
+page becomes visible again.
+
+* UIProcess/LayerTreeHostProxy.cpp:
+(WebKit::LayerTreeHostProxy::purgeBackingStores):
+* UIProcess/WebLayerTreeRenderer.cpp:
+(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
+(WebKit::WebLayerTreeRenderer::purgeGLResources):
+(WebKit::WebLayerTreeRenderer::appendUpdate):
+(WebKit::WebLayerTreeRenderer::setActive):
+(WebKit):
+* UIProcess/WebLayerTreeRenderer.h:
+(WebLayerTreeRenderer):
+* UIProcess/qt/QtWebPageSGNode.cpp:
+(WebKit::ContentsSGNode::ContentsSGNode):
+* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
+(WebCore::WebGraphicsLayer::purgeBackingStores):
+
2012-04-19 Vivek Galatage vivekgalat...@gmail.com
DevTools: assertion failure upon devtools window reopen.
Modified: trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp (114704 => 114705)
--- trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp 2012-04-20 00:33:11 UTC (rev 114704)
+++ trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp 2012-04-20 00:37:02 UTC (rev 114705)
@@ -134,6 +134,7 @@
void LayerTreeHostProxy::purgeBackingStores()
{
+m_renderer-setActive(false);
m_drawingAreaProxy-page()-process()-send(Messages::LayerTreeHost::PurgeBackingStores(), m_drawingAreaProxy-page()-pageID());
}
Modified: trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp (114704 => 114705)
--- trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp 2012-04-20 00:33:11 UTC (rev 114704)
+++ trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp 2012-04-20 00:37:02 UTC (rev 114705)
@@ -86,7 +86,8 @@
WebLayerTreeRenderer::WebLayerTreeRenderer(LayerTreeHostProxy* layerTreeHostProxy)
: m_layerTreeHostProxy(layerTreeHostProxy)
-, m_rootLayerID(0)
+, m_rootLayerID(InvalidWebLayerID)
+, m_isActive(false)
{
}
@@ -400,6 +401,12 @@
layer-clearBackingStoresRecursive();
m_directlyCompositedImages.clear();
+
+m_rootLayer-removeAllChildren();
+m_rootLayer.clear();
+m_rootLayerID = InvalidWebLayerID;
+m_layers.clear();
+m_fixedLayers.clear();
m_textureMapper.clear();
m_backingStoresWithPendingBuffers.clear();
@@ -419,9 +426,24 @@
void WebLayerTreeRenderer::appendUpdate(const Functionvoid() function)
{
+if (!m_isActive)
+return;
+
m_renderQueue.append(function);
}
+void WebLayerTreeRenderer::setActive(bool active)
+{
+if (m_isActive == active)
+return;
+
+// Have to clear render queue in both cases.
+// If there are some updates in queue during activation then those updates are from previous instance of paint node
+// and cannot be applied to the newly created instance.
+m_renderQueue.clear();
+m_isActive = active;
+}
+
} // namespace WebKit
#endif // USE(UI_SIDE_COMPOSITING)
Modified: trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.h (114704 => 114705)
---
[webkit-changes] [114706] trunk/LayoutTests
Title: [114706] trunk/LayoutTests
Revision 114706
Author jer.no...@apple.com
Date 2012-04-19 17:48:27 -0700 (Thu, 19 Apr 2012)
Log Message
Rollout r114674.
New tests added in http://trac.webkit.org/changeset/114685 made the
platform results added in http://trac.webkit.org/changeset/114674
unnecessary.
* platform/mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/platform/mac/fast/ruby/floating-ruby-text-expected.txt
trunk/LayoutTests/platform/mac/fast/ruby/positioned-ruby-text-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (114705 => 114706)
--- trunk/LayoutTests/ChangeLog 2012-04-20 00:37:02 UTC (rev 114705)
+++ trunk/LayoutTests/ChangeLog 2012-04-20 00:48:27 UTC (rev 114706)
@@ -1,5 +1,16 @@
2012-04-19 Jer Noble jer.no...@apple.com
+Rollout r114674.
+
+New tests added in http://trac.webkit.org/changeset/114685 made the
+platform results added in http://trac.webkit.org/changeset/114674
+unnecessary.
+
+* platform/mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
+* platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
+
+2012-04-19 Jer Noble jer.no...@apple.com
+
Partial rollout of r114673.
Test plugins/npp-set-window-called-during-destruction.html passes on mac-wk2,
Deleted: trunk/LayoutTests/platform/mac/fast/ruby/floating-ruby-text-expected.txt (114705 => 114706)
--- trunk/LayoutTests/platform/mac/fast/ruby/floating-ruby-text-expected.txt 2012-04-20 00:37:02 UTC (rev 114705)
+++ trunk/LayoutTests/platform/mac/fast/ruby/floating-ruby-text-expected.txt 2012-04-20 00:48:27 UTC (rev 114706)
@@ -1,15 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x43
- RenderBlock {HTML} at (0,0) size 800x43
-RenderBody {BODY} at (8,8) size 784x27
- RenderRuby (inline) {RUBY} at (0,0) size 784x10 [color=#FF]
-RenderRubyRun (anonymous) at (0,5) size 784x20
- RenderRubyText {RT} at (0,-5) size 784x5
-RenderText {#text} at (372,0) size 40x5
- text run at (372,0) width 40: rubytext
- RenderRubyBase (anonymous) at (0,0) size 784x20
-RenderText {#text} at (0,0) size 784x20
- text run at (0,0) width 784: Attempt to create a floating ruby text element. Float is not supported for
- text run at (0,10) width 784: ruby text, which should be apparent from the resulting render tree.
- RenderText {#text} at (0,0) size 0x0
Deleted: trunk/LayoutTests/platform/mac/fast/ruby/positioned-ruby-text-expected.txt (114705 => 114706)
--- trunk/LayoutTests/platform/mac/fast/ruby/positioned-ruby-text-expected.txt 2012-04-20 00:37:02 UTC (rev 114705)
+++ trunk/LayoutTests/platform/mac/fast/ruby/positioned-ruby-text-expected.txt 2012-04-20 00:48:27 UTC (rev 114706)
@@ -1,16 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x53
- RenderBlock {HTML} at (0,0) size 800x53
-RenderBody {BODY} at (8,8) size 784x37
- RenderRuby (inline) {RUBY} at (0,0) size 784x10 [color=#FF]
-RenderRubyRun (anonymous) at (0,5) size 784x30
- RenderRubyText {RT} at (0,-5) size 784x5
-RenderText {#text} at (372,0) size 40x5
- text run at (372,0) width 40: rubytext
- RenderRubyBase (anonymous) at (0,0) size 784x30
-RenderText {#text} at (0,0) size 784x30
- text run at (0,0) width 784: Attempt to create a positioned ruby text element. Non-static position is not
- text run at (0,10) width 784: supported for ruby text, which should be apparent from the resulting render
- text run at (0,20) width 50: tree.
- RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114707] trunk/Source/WebCore
Title: [114707] trunk/Source/WebCore
Revision 114707
Author ander...@apple.com
Date 2012-04-19 17:50:19 -0700 (Thu, 19 Apr 2012)
Log Message
Focus ring on wikipedia gets blobs when you type
https://bugs.webkit.org/show_bug.cgi?id=84407
rdar://problem/11011847
Reviewed by Dan Bernstein.
Make it possible to override the focus ring visible rect from layer drawing code.
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
Call ThemeMac::setFocusRingClipRect to set the focus ring clip rect while drawing.
* platform/mac/ThemeMac.h:
* platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _focusRingVisibleRect]):
If there's an active focus ring visible rect, use it. Otherwise, fall back to the previous behavior
and just return the view's visible rect.
(WebCore::ThemeMac::setFocusRingClipRect):
Update the focus clip rect.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm
trunk/Source/WebCore/platform/mac/ThemeMac.h
trunk/Source/WebCore/platform/mac/ThemeMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (114706 => 114707)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 00:48:27 UTC (rev 114706)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 00:50:19 UTC (rev 114707)
@@ -1,3 +1,26 @@
+2012-04-19 Anders Carlsson ander...@apple.com
+
+Focus ring on wikipedia gets blobs when you type
+https://bugs.webkit.org/show_bug.cgi?id=84407
+rdar://problem/11011847
+
+Reviewed by Dan Bernstein.
+
+Make it possible to override the focus ring visible rect from layer drawing code.
+
+* platform/graphics/mac/WebLayer.mm:
+(drawLayerContents):
+Call ThemeMac::setFocusRingClipRect to set the focus ring clip rect while drawing.
+
+* platform/mac/ThemeMac.h:
+* platform/mac/ThemeMac.mm:
+(-[WebCoreFlippedView _focusRingVisibleRect]):
+If there's an active focus ring visible rect, use it. Otherwise, fall back to the previous behavior
+and just return the view's visible rect.
+
+(WebCore::ThemeMac::setFocusRingClipRect):
+Update the focus clip rect.
+
2012-04-19 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r114690.
Modified: trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm (114706 => 114707)
--- trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm 2012-04-20 00:48:27 UTC (rev 114706)
+++ trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm 2012-04-20 00:50:19 UTC (rev 114707)
@@ -32,6 +32,7 @@
#import GraphicsContext.h
#import GraphicsLayerCA.h
#import PlatformCALayer.h
+#import ThemeMac.h
#import objc/objc-runtime.h
#import QuartzCore/QuartzCore.h
#import wtf/UnusedParam.h
@@ -79,6 +80,9 @@
// smaller than the layer bounds (e.g. tiled layers)
FloatRect clipBounds = CGContextGetClipBoundingBox(context);
+// The focus ring machinery needs to know the exact clip rect in a flipped, non-transformed coordinate system.
+ThemeMac::setFocusRingClipRect(FloatRect(clipBounds.x(), layerBounds.size.height - clipBounds.maxY(), clipBounds.width(), clipBounds.height()));
+
#if !defined(BUILDING_ON_SNOW_LEOPARD)
__block GraphicsContext* ctx = graphicsContext;
@@ -97,6 +101,8 @@
layerContents-platformCALayerPaintContents(graphicsContext, clip);
#endif
+ThemeMac::setFocusRingClipRect(FloatRect());
+
[NSGraphicsContext restoreGraphicsState];
// Re-fetch the layer owner, since rdar://problem/9125151 indicates that it might have been destroyed during painting.
Modified: trunk/Source/WebCore/platform/mac/ThemeMac.h (114706 => 114707)
--- trunk/Source/WebCore/platform/mac/ThemeMac.h 2012-04-20 00:48:27 UTC (rev 114706)
+++ trunk/Source/WebCore/platform/mac/ThemeMac.h 2012-04-20 00:50:19 UTC (rev 114707)
@@ -52,6 +52,7 @@
// FIXME: Once RenderThemeMac is converted over to use Theme then this can be internal to ThemeMac.
static NSView* ensuredView(ScrollView*);
+static void setFocusRingClipRect(const FloatRect);
};
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/mac/ThemeMac.mm (114706 => 114707)
--- trunk/Source/WebCore/platform/mac/ThemeMac.mm 2012-04-20 00:48:27 UTC (rev 114706)
+++ trunk/Source/WebCore/platform/mac/ThemeMac.mm 2012-04-20 00:50:19 UTC (rev 114707)
@@ -36,6 +36,8 @@
using namespace std;
+NSRect focusRingClipRect;
+
// This is a view whose sole purpose is to tell AppKit that it's flipped.
@interface WebCoreFlippedView : NSControl
@end
@@ -59,7 +61,13 @@
- (NSRect)_focusRingVisibleRect
{
-return [self visibleRect];
+if (NSIsEmptyRect(focusRingClipRect))
+return [self visibleRect];
+
+NSRect rect = focusRingClipRect;
+rect.origin.y = [self bounds].size.height - NSMaxY(rect);
+
+return rect;
}
- (NSView *)_focusRingClipAncestor
@@ -584,7 +592,12 @@
return flippedView;
}
-
+
+void ThemeMac::setFocusRingClipRect(const FloatRect rect)
+{
+focusRingClipRect =
[webkit-changes] [114708] trunk/Source/WebKit/chromium
Title: [114708] trunk/Source/WebKit/chromium
Revision 114708
Author jsb...@chromium.org
Date 2012-04-19 17:58:09 -0700 (Thu, 19 Apr 2012)
Log Message
[Chromium] IndexedDB: Prep for changing keyPath return type
https://bugs.webkit.org/show_bug.cgi?id=84208
To introduce Array-type key paths (see http://webkit.org/b/84207) the keyPath() accessors
on WebIDBObjectStore and WebIDBIndex need to change return type. To do so requires temporarily
changing the method names to keyPathString with compatibility shims (on the WebKit side)
then switching the implementation in the Chromium port in a follow-up patch.
Reviewed by Kent Tamura.
* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath):
(WebKit::WebIDBIndex::keyPathString):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath):
(WebKit::WebIDBObjectStore::keyPathString):
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::keyPathString):
* src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::keyPathString):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBIndex.h
trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h
trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.cpp
trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.h
trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp
trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (114707 => 114708)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-20 00:50:19 UTC (rev 114707)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-20 00:58:09 UTC (rev 114708)
@@ -1,3 +1,30 @@
+2012-04-19 Joshua Bell jsb...@chromium.org
+
+[Chromium] IndexedDB: Prep for changing keyPath return type
+https://bugs.webkit.org/show_bug.cgi?id=84208
+
+To introduce Array-type key paths (see http://webkit.org/b/84207) the keyPath() accessors
+on WebIDBObjectStore and WebIDBIndex need to change return type. To do so requires temporarily
+changing the method names to keyPathString with compatibility shims (on the WebKit side)
+then switching the implementation in the Chromium port in a follow-up patch.
+
+Reviewed by Kent Tamura.
+
+* public/WebIDBIndex.h:
+(WebKit::WebIDBIndex::keyPath):
+(WebKit::WebIDBIndex::keyPathString):
+* public/WebIDBObjectStore.h:
+(WebKit::WebIDBObjectStore::keyPath):
+(WebKit::WebIDBObjectStore::keyPathString):
+* src/WebIDBIndexImpl.cpp:
+(WebKit::WebIDBIndexImpl::keyPathString):
+* src/WebIDBIndexImpl.h:
+(WebIDBIndexImpl):
+* src/WebIDBObjectStoreImpl.cpp:
+(WebKit::WebIDBObjectStoreImpl::keyPathString):
+* src/WebIDBObjectStoreImpl.h:
+(WebIDBObjectStoreImpl):
+
2012-04-19 Andreas Kling kl...@webkit.org
[chromium] Add simplified API for iterating over a WebElement's attributes.
Modified: trunk/Source/WebKit/chromium/public/WebIDBIndex.h (114707 => 114708)
--- trunk/Source/WebKit/chromium/public/WebIDBIndex.h 2012-04-20 00:50:19 UTC (rev 114707)
+++ trunk/Source/WebKit/chromium/public/WebIDBIndex.h 2012-04-20 00:58:09 UTC (rev 114708)
@@ -53,6 +53,12 @@
}
virtual WebString keyPath() const
{
+return keyPathString();
+}
+virtual WebString keyPathString() const
+{
+// FIXME: Temporary to allow keyPath()'s return type to change.
+// http://webkit.org/b/84207
WEBKIT_ASSERT_NOT_REACHED();
return WebString();
}
Modified: trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h (114707 => 114708)
--- trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h 2012-04-20 00:50:19 UTC (rev 114707)
+++ trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h 2012-04-20 00:58:09 UTC (rev 114708)
@@ -50,6 +50,12 @@
}
virtual WebString keyPath() const
{
+return keyPathString();
+}
+virtual WebString keyPathString() const
+{
+// FIXME: Temporary to allow keyPath()'s return type to change.
+// http://webkit.org/b/84207
WEBKIT_ASSERT_NOT_REACHED();
return WebString();
}
Modified: trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.cpp (114707 => 114708)
--- trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.cpp 2012-04-20 00:50:19 UTC (rev 114707)
+++ trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.cpp 2012-04-20 00:58:09 UTC (rev 114708)
@@ -58,7 +58,7 @@
return m_backend-storeName();
}
-WebString WebIDBIndexImpl::keyPath() const
+WebString WebIDBIndexImpl::keyPathString() const
{
return m_backend-keyPath();
}
Modified: trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.h (114707 => 114708)
--- trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.h 2012-04-20 00:50:19 UTC (rev 114707)
+++ trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.h
[webkit-changes] [114697] trunk/Source/WebCore
Title: [114697] trunk/Source/WebCore
Revision 114697
Author pe...@chromium.org
Date 2012-04-19 17:05:36 -0700 (Thu, 19 Apr 2012)
Log Message
[Chromium] Don't compile FontCacheSkia for Android
https://bugs.webkit.org/show_bug.cgi?id=84392
Reviewed by Kent Tamura.
Chromium for the Android platform uses its own FontCacheAndroid
implementation. Compile errors show up when trying to build the
content shell.
* WebCore.gyp/WebCore.gyp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114696 => 114697)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 23:54:49 UTC (rev 114696)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 00:05:36 UTC (rev 114697)
@@ -1,3 +1,16 @@
+2012-04-19 Peter Beverloo pe...@chromium.org
+
+[Chromium] Don't compile FontCacheSkia for Android
+https://bugs.webkit.org/show_bug.cgi?id=84392
+
+Reviewed by Kent Tamura.
+
+Chromium for the Android platform uses its own FontCacheAndroid
+implementation. Compile errors show up when trying to build the
+content shell.
+
+* WebCore.gyp/WebCore.gyp:
+
2012-04-19 Martin Robinson mrobin...@igalia.com
[Cairo] Remove rgb24-hacks.txt and scale-removal.txt
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (114696 => 114697)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-04-19 23:54:49 UTC (rev 114696)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-04-20 00:05:36 UTC (rev 114697)
@@ -1684,6 +1684,7 @@
['include', 'platform/graphics/harfbuzz/FontPlatformDataHarfBuzz\\.cpp$'],
['include', 'platform/graphics/harfbuzz/HarfBuzzSkia\\.cpp$'],
['include', 'platform/graphics/harfbuzz/HarfBuzzShaperBase\\.cpp$'],
+['exclude', 'platform/graphics/skia/FontCacheSkia\\.cpp$'],
['include', 'platform/graphics/skia/SimpleFontDataSkia\\.cpp$'],
],
}, { # OS!=android
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114710] branches/chromium/1084/Source/WebCore/css/CSSImportRule.cpp
Title: [114710] branches/chromium/1084/Source/WebCore/css/CSSImportRule.cpp
Revision 114710
Author hb...@chromium.org
Date 2012-04-19 18:40:15 -0700 (Thu, 19 Apr 2012)
Log Message
Merge 114350 - Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545
Patch by David Barr davidb...@chromium.org on 2012-04-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: http/tests/css/css-imports-redirect-cycle.html
* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
LayoutTests:
* http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
* http/tests/css/css-imports-redirect-cycle.css: Added.
* http/tests/css/css-imports-redirect-cycle.html: Added.
BUG=122606
TBR=commit-qu...@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10143006
Modified Paths
branches/chromium/1084/Source/WebCore/css/CSSImportRule.cpp
Diff
Modified: branches/chromium/1084/Source/WebCore/css/CSSImportRule.cpp (114709 => 114710)
--- branches/chromium/1084/Source/WebCore/css/CSSImportRule.cpp 2012-04-20 01:14:26 UTC (rev 114709)
+++ branches/chromium/1084/Source/WebCore/css/CSSImportRule.cpp 2012-04-20 01:40:15 UTC (rev 114710)
@@ -140,7 +140,7 @@
CSSStyleSheet* rootSheet = parentSheet;
for (CSSStyleSheet* sheet = parentSheet; sheet; sheet = sheet-parentStyleSheet()) {
// FIXME: This is wrong if the finalURL was updated via document::updateBaseURL.
-if (absHref == sheet-finalURL().string())
+if (absHref == sheet-finalURL().string() || absHref == sheet-href())
return;
rootSheet = sheet;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114711] trunk/Source/WebCore
Title: [114711] trunk/Source/WebCore
Revision 114711
Author ander...@apple.com
Date 2012-04-19 18:40:56 -0700 (Thu, 19 Apr 2012)
Log Message
computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
rdar://problem/11285741
Reviewed by Dan Bernstein.
Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
Traverse the entire frame tree looking for scrollable areas. Also, remove the scrollability checks because scrollable areas will only be
in the set if they have scrollbars that are enabled.
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
computeNonFastScrollableRegion now takes the main frame.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114710 => 114711)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 01:40:15 UTC (rev 114710)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 01:40:56 UTC (rev 114711)
@@ -1,5 +1,25 @@
2012-04-19 Anders Carlsson ander...@apple.com
+computeNonFastScrollableRegion needs to traverse the entire frame tree
+https://bugs.webkit.org/show_bug.cgi?id=84409
+rdar://problem/11285741
+
+Reviewed by Dan Bernstein.
+
+Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
+areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
+
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::computeNonFastScrollableRegion):
+Traverse the entire frame tree looking for scrollable areas. Also, remove the scrollability checks because scrollable areas will only be
+in the set if they have scrollbars that are enabled.
+
+(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
+(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
+computeNonFastScrollableRegion now takes the main frame.
+
+2012-04-19 Anders Carlsson ander...@apple.com
+
Focus ring on wikipedia gets blobs when you type
https://bugs.webkit.org/show_bug.cgi?id=84407
rdar://problem/11011847
Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (114710 => 114711)
--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2012-04-20 01:40:15 UTC (rev 114710)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2012-04-20 01:40:56 UTC (rev 114711)
@@ -105,27 +105,21 @@
#endif
}
-static Region computeNonFastScrollableRegion(FrameView* frameView)
+static Region computeNonFastScrollableRegion(Frame* mainFrame)
{
Region nonFastScrollableRegion;
-HashSetFrameView* childFrameViews;
-for (HashSetRefPtrWidget ::const_iterator it = frameView-children()-begin(), end = frameView-children()-end(); it != end; ++it) {
-if ((*it)-isFrameView())
-childFrameViews.add(static_castFrameView*(it-get()));
-}
-
-if (const FrameView::ScrollableAreaSet* scrollableAreas = frameView-scrollableAreas()) {
+for (Frame* frame = mainFrame; frame; frame = frame-tree()-traverseNext()) {
+FrameView* frameView = frame-view();
+if (!frameView)
+continue;
+
+const FrameView::ScrollableAreaSet* scrollableAreas = frameView-scrollableAreas();
+if (!scrollableAreas)
+continue;
+
for (FrameView::ScrollableAreaSet::const_iterator it = scrollableAreas-begin(), end = scrollableAreas-end(); it != end; ++it) {
ScrollableArea* scrollableArea = *it;
-
-// Check if this area can be scrolled at all.
-// If this scrollable area is a frame view that itself has scrollable areas, then we need to add it to the region.
-if ((!scrollableArea-horizontalScrollbar() || !scrollableArea-horizontalScrollbar()-enabled())
- (!scrollableArea-verticalScrollbar() || !scrollableArea-verticalScrollbar()-enabled())
- (!childFrameViews.contains(static_castFrameView*(scrollableArea)) || !static_castFrameView*(scrollableArea)-scrollableAreas()))
-continue;
-
nonFastScrollableRegion.unite(scrollableArea-scrollableAreaBoundingBox());
}
}
@@ -141,7 +135,7 @@
// Compute the region of the page that we can't do fast scrolling for. This currently includes
// all scrollable areas, such as subframes, overflow divs and list boxes. We need to do this even if the
// frame view whose
[webkit-changes] [114712] trunk/LayoutTests
Title: [114712] trunk/LayoutTests Revision 114712 Author dim...@chromium.org Date 2012-04-19 19:07:51 -0700 (Thu, 19 Apr 2012) Log Message Not reviewed, re-update baselines for new tests added in http://trac.webkit.org/changeset/114666 and then modified in http://trac.webkit.org/changeset/114685 * platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Removed. * platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Removed. * platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Removed. * platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Removed. * platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Removed. * platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Removed. * platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Removed. * platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Removed. * platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Removed. * platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Removed. * platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Removed. * platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Removed. * platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt. * platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium/fast/ruby/positioned-ruby-text-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt trunk/LayoutTests/platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (114711 => 114712) --- trunk/LayoutTests/ChangeLog 2012-04-20 01:40:56 UTC (rev 114711) +++ trunk/LayoutTests/ChangeLog 2012-04-20 02:07:51 UTC (rev 114712) @@ -1,3 +1,24 @@ +2012-04-19 Dmitry Titov dim...@chromium.org + +Not reviewed, re-update baselines for new tests +added in http://trac.webkit.org/changeset/114666 +and then modified in http://trac.webkit.org/changeset/114685 + +* platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Removed. +* platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Removed. +* platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Removed. +* platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Removed. +* platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Removed. +* platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Removed. +* platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Removed. +* platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Removed. +* platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Removed. +* platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Removed. +* platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Removed. +* platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Removed. +* platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt. +* platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt. + 2012-04-19 Jer Noble
[webkit-changes] [114713] trunk/Source/WebCore
Title: [114713] trunk/Source/WebCore
Revision 114713
Author dim...@chromium.org
Date 2012-04-19 19:32:34 -0700 (Thu, 19 Apr 2012)
Log Message
Unreviewed, rolling out r114711.
http://trac.webkit.org/changeset/114711
https://bugs.webkit.org/show_bug.cgi?id=84412
Many tests crash in RenderObject::container() (Requested by
dimich on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-04-19
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114712 => 114713)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 02:07:51 UTC (rev 114712)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 02:32:34 UTC (rev 114713)
@@ -1,3 +1,17 @@
+2012-04-19 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r114711.
+http://trac.webkit.org/changeset/114711
+https://bugs.webkit.org/show_bug.cgi?id=84412
+
+Many tests crash in RenderObject::container() (Requested by
+dimich on #webkit).
+
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::computeNonFastScrollableRegion):
+(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
+(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
+
2012-04-19 Anders Carlsson ander...@apple.com
computeNonFastScrollableRegion needs to traverse the entire frame tree
Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (114712 => 114713)
--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2012-04-20 02:07:51 UTC (rev 114712)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2012-04-20 02:32:34 UTC (rev 114713)
@@ -105,21 +105,27 @@
#endif
}
-static Region computeNonFastScrollableRegion(Frame* mainFrame)
+static Region computeNonFastScrollableRegion(FrameView* frameView)
{
Region nonFastScrollableRegion;
-for (Frame* frame = mainFrame; frame; frame = frame-tree()-traverseNext()) {
-FrameView* frameView = frame-view();
-if (!frameView)
-continue;
-
-const FrameView::ScrollableAreaSet* scrollableAreas = frameView-scrollableAreas();
-if (!scrollableAreas)
-continue;
-
+HashSetFrameView* childFrameViews;
+for (HashSetRefPtrWidget ::const_iterator it = frameView-children()-begin(), end = frameView-children()-end(); it != end; ++it) {
+if ((*it)-isFrameView())
+childFrameViews.add(static_castFrameView*(it-get()));
+}
+
+if (const FrameView::ScrollableAreaSet* scrollableAreas = frameView-scrollableAreas()) {
for (FrameView::ScrollableAreaSet::const_iterator it = scrollableAreas-begin(), end = scrollableAreas-end(); it != end; ++it) {
ScrollableArea* scrollableArea = *it;
+
+// Check if this area can be scrolled at all.
+// If this scrollable area is a frame view that itself has scrollable areas, then we need to add it to the region.
+if ((!scrollableArea-horizontalScrollbar() || !scrollableArea-horizontalScrollbar()-enabled())
+ (!scrollableArea-verticalScrollbar() || !scrollableArea-verticalScrollbar()-enabled())
+ (!childFrameViews.contains(static_castFrameView*(scrollableArea)) || !static_castFrameView*(scrollableArea)-scrollableAreas()))
+continue;
+
nonFastScrollableRegion.unite(scrollableArea-scrollableAreaBoundingBox());
}
}
@@ -135,7 +141,7 @@
// Compute the region of the page that we can't do fast scrolling for. This currently includes
// all scrollable areas, such as subframes, overflow divs and list boxes. We need to do this even if the
// frame view whose layout was updated is not the main frame.
-Region nonFastScrollableRegion = computeNonFastScrollableRegion(m_page-mainFrame());
+Region nonFastScrollableRegion = computeNonFastScrollableRegion(m_page-mainFrame()-view());
setNonFastScrollableRegion(nonFastScrollableRegion);
if (!coordinatesScrollingForFrameView(frameView))
@@ -155,7 +161,7 @@
ASSERT(isMainThread());
ASSERT(m_page);
-Region nonFastScrollableRegion = computeNonFastScrollableRegion(m_page-mainFrame());
+Region nonFastScrollableRegion = computeNonFastScrollableRegion(m_page-mainFrame()-view());
setNonFastScrollableRegion(nonFastScrollableRegion);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114715] trunk/Source/WebCore
Title: [114715] trunk/Source/WebCore
Revision 114715
Author commit-qu...@webkit.org
Date 2012-04-19 20:35:56 -0700 (Thu, 19 Apr 2012)
Log Message
[BlackBerry] Update HTTP connection per host limit in ResourceRequestBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=84380
Patch by Tay Grigg tgr...@rim.com on 2012-04-19
Reviewed by George Staikos.
Reviewed Internally by: George Rizkalla, Lyon Chen
Set the limit on the http connection count per host to the default
of 1, queue the requests in the networking layer instead,
this should increase parallelism at the WebKit layer to remove
any potential bottlenecks.
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114714 => 114715)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 03:29:35 UTC (rev 114714)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 03:35:56 UTC (rev 114715)
@@ -1,3 +1,20 @@
+2012-04-19 Tay Grigg tgr...@rim.com
+
+[BlackBerry] Update HTTP connection per host limit in ResourceRequestBlackBerry
+https://bugs.webkit.org/show_bug.cgi?id=84380
+
+Reviewed by George Staikos.
+
+Reviewed Internally by: George Rizkalla, Lyon Chen
+
+Set the limit on the http connection count per host to the default
+of 1, queue the requests in the networking layer instead,
+this should increase parallelism at the WebKit layer to remove
+any potential bottlenecks.
+
+* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
+(WebCore::initializeMaximumHTTPConnectionCountPerHost):
+
2012-04-19 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r114711.
Modified: trunk/Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp (114714 => 114715)
--- trunk/Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp 2012-04-20 03:29:35 UTC (rev 114714)
+++ trunk/Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp 2012-04-20 03:35:56 UTC (rev 114715)
@@ -32,7 +32,7 @@
unsigned initializeMaximumHTTPConnectionCountPerHost()
{
-return 6;
+return 1;
}
static inline NetworkRequest::CachePolicy platformCachePolicyForRequest(const ResourceRequest request)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114716] tags/Safari-536.8/
Title: [114716] tags/Safari-536.8/ Revision 114716 Author lforsch...@apple.com Date 2012-04-19 22:23:11 -0700 (Thu, 19 Apr 2012) Log Message New Tag. Added Paths tags/Safari-536.8/ Diff Property changes: tags/Safari-536.8 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114717] trunk/Source
Title: [114717] trunk/Source Revision 114717 Author lforsch...@apple.com Date 2012-04-19 22:35:07 -0700 (Thu, 19 Apr 2012) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (114716 => 114717) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-04-20 05:23:11 UTC (rev 114716) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-04-20 05:35:07 UTC (rev 114717) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 536; -MINOR_VERSION = 8; +MINOR_VERSION = 9; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (114716 => 114717) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2012-04-20 05:23:11 UTC (rev 114716) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2012-04-20 05:35:07 UTC (rev 114717) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 536; -MINOR_VERSION = 8; +MINOR_VERSION = 9; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (114716 => 114717) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-04-20 05:23:11 UTC (rev 114716) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-04-20 05:35:07 UTC (rev 114717) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 536; -MINOR_VERSION = 8; +MINOR_VERSION = 9; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (114716 => 114717) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-04-20 05:23:11 UTC (rev 114716) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-04-20 05:35:07 UTC (rev 114717) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 536; -MINOR_VERSION = 8; +MINOR_VERSION = 9; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
