[webkit-changes] [120410] trunk/Source
Title: [120410] trunk/Source Revision 120410 Author tk...@chromium.org Date 2012-06-14 23:38:25 -0700 (Thu, 14 Jun 2012) Log Message Support file extensions in HTMLInputElement::accept https://bugs.webkit.org/show_bug.cgi?id=88298 Reviewed by Hajime Morita. Source/WebCore: The WHATWG specification added file extensions supoprt for HTMLInputElement::accept recently. In the WebCore FileChooser interface, we rejected invalid MIME type strings in HTMLInputElement::acceptMIMETypes(), and platform file choosers don't expect that it containts file extensions. So, this patch introduces additional member "acceptFileExtensions" to FileChooserSettings, and it contains only file extensions specified by an accept attribute. * html/FileInputType.cpp: Sets HTMLInputElement::acceptFileExtensions() to FileChooserSettings::acceptFileExtensions. (WebCore::FileInputType::handleDOMActivateEvent): (WebCore::FileInputType::receiveDropForDirectoryUpload): * html/HTMLInputElement.cpp: (WebCore::isValidFileExtension): Added. (WebCore::parseAcceptAttribute): Common part for acceptMIMETyps() and acceptFileExtensions(). (WebCore::HTMLInputElement::acceptMIMETypes): Uses parseAcceptAttribute() with isValidMIMEType(). (WebCore::HTMLInputElement::acceptFileExtensions): Added. Uses parseAcceptAttribute() with isValidFileExtension(). * html/HTMLInputElement.h: (HTMLInputElement): Add acceptFileExtensions(). * platform/FileChooser.h: (FileChooserSettings): Add acceptFileExtensions and acceptTypes(). * platform/FileChooser.cpp: (WebCore::FileChooserSettings::acceptTypes): Added. Source/WebKit/chromium: * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runOpenPanel): Use FileChooserSettings::acceptTypes() to get both of MIME types and file extensions. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/FileInputType.cpp trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLInputElement.h trunk/Source/WebCore/platform/FileChooser.cpp trunk/Source/WebCore/platform/FileChooser.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (120409 => 120410) --- trunk/Source/WebCore/ChangeLog 2012-06-15 06:35:42 UTC (rev 120409) +++ trunk/Source/WebCore/ChangeLog 2012-06-15 06:38:25 UTC (rev 120410) @@ -1,3 +1,40 @@ +2012-06-14 Kent Tamura + +Support file extensions in HTMLInputElement::accept +https://bugs.webkit.org/show_bug.cgi?id=88298 + +Reviewed by Hajime Morita. + +The WHATWG specification added file extensions supoprt for +HTMLInputElement::accept recently. + +In the WebCore FileChooser interface, we rejected invalid MIME type +strings in HTMLInputElement::acceptMIMETypes(), and platform file +choosers don't expect that it containts file extensions. So, this patch +introduces additional member "acceptFileExtensions" to +FileChooserSettings, and it contains only file extensions specified by +an accept attribute. + +* html/FileInputType.cpp: +Sets HTMLInputElement::acceptFileExtensions() to +FileChooserSettings::acceptFileExtensions. +(WebCore::FileInputType::handleDOMActivateEvent): +(WebCore::FileInputType::receiveDropForDirectoryUpload): +* html/HTMLInputElement.cpp: +(WebCore::isValidFileExtension): Added. +(WebCore::parseAcceptAttribute): +Common part for acceptMIMETyps() and acceptFileExtensions(). +(WebCore::HTMLInputElement::acceptMIMETypes): +Uses parseAcceptAttribute() with isValidMIMEType(). +(WebCore::HTMLInputElement::acceptFileExtensions): +Added. Uses parseAcceptAttribute() with isValidFileExtension(). +* html/HTMLInputElement.h: +(HTMLInputElement): Add acceptFileExtensions(). +* platform/FileChooser.h: +(FileChooserSettings): Add acceptFileExtensions and acceptTypes(). +* platform/FileChooser.cpp: +(WebCore::FileChooserSettings::acceptTypes): Added. + 2012-06-14 James Robinson [chromium] Remove unused CanvasLayerChromium.h/cpp from the tree Modified: trunk/Source/WebCore/html/FileInputType.cpp (120409 => 120410) --- trunk/Source/WebCore/html/FileInputType.cpp 2012-06-15 06:35:42 UTC (rev 120409) +++ trunk/Source/WebCore/html/FileInputType.cpp 2012-06-15 06:38:25 UTC (rev 120410) @@ -188,6 +188,7 @@ settings.allowsMultipleFiles = input->fastHasAttribute(multipleAttr); #endif settings.acceptMIMETypes = input->acceptMIMETypes(); +settings.acceptFileExtensions = input->acceptFileExtensions(); settings.selectedFiles = m_fileList->paths(); #if ENABLE(MEDIA_CAPTURE) settings.capture = input->capture(); @@ -375,6 +376,7 @@ settings.allowsMultipleFiles = true; settings.selectedFiles.append(paths[0]); settings.acceptMIMETypes = input->acceptMIMETypes(); +
[webkit-changes] [120409] trunk/LayoutTests
Title: [120409] trunk/LayoutTests
Revision 120409
Author e...@chromium.org
Date 2012-06-14 23:35:42 -0700 (Thu, 14 Jun 2012)
Log Message
Unreviewed rebaseline for mac chromium following r120403.
* platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (120408 => 120409)
--- trunk/LayoutTests/ChangeLog 2012-06-15 06:33:25 UTC (rev 120408)
+++ trunk/LayoutTests/ChangeLog 2012-06-15 06:35:42 UTC (rev 120409)
@@ -1,3 +1,9 @@
+2012-06-14 Emil A Eklund
+
+Unreviewed rebaseline for mac chromium following r120403.
+
+* platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Removed.
+
2012-06-14 Ryosuke Niwa
Use testRunner instead of layoutTestController in battery status and canvas tests
Deleted: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt (120408 => 120409)
--- trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt 2012-06-15 06:33:25 UTC (rev 120408)
+++ trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt 2012-06-15 06:35:42 UTC (rev 120409)
@@ -1,111 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x288
- RenderBlock {HTML} at (0,0) size 800x288
-RenderBody {BODY} at (8,8) size 784x272 [bgcolor=#FF]
- RenderTable {TABLE} at (0,0) size 172x272
-RenderTableSection {TBODY} at (0,0) size 172x272
- RenderTableRow {TR} at (0,0) size 172x34
-RenderTableCell {TD} at (0,0) size 43x35 [border: (1px solid #00)] [r=0 c=0 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (43,0) size 43x35 [border: (1px solid #00)] [r=0 c=1 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (86,0) size 43x35 [border: (1px solid #00)] [r=0 c=2 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (129,0) size 43x35 [border: (1px solid #00)] [r=0 c=3 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
- RenderTableRow {TR} at (0,34) size 172x34
-RenderTableCell {TD} at (0,34) size 43x35 [border: (1px solid #00)] [r=1 c=0 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (43,34) size 43x35 [border: (1px solid #00)] [r=1 c=1 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (86,34) size 43x35 [border: (1px solid #00)] [r=1 c=2 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (129,34) size 43x35 [border: (1px solid #00)] [r=1 c=3 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
- RenderTableRow {TR} at (0,68) size 172x34
-RenderTableCell {TD} at (0,68) size 43x35 [border: (1px solid #00)] [r=2 c=0 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (43,68) size 43x35 [border: (1px solid #00)] [r=2 c=1 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (86,68) size 43x35 [border: (1px solid #00)] [r=2 c=2 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (129,68) size 43x35 [border: (1px solid #00)] [r=2 c=3 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
- RenderTableRow {TR} at (0,102) size 172x34
-RenderTableCell {TD} at (0,102) size 43x35 [border: (1px solid #00)] [r=3 c=0 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (43,102) size 43x35 [border: (1px solid #00)] [r=3 c=1 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-text run at (8,8) width 27: "blah"
-RenderTableCell {TD} at (86,102) size 43x35 [border: (1px solid #00)] [r=3 c=2 rs=1 cs=1]
- RenderText {#text} at (8,8) size 27x18
-tex
[webkit-changes] [120407] trunk/LayoutTests
Title: [120407] trunk/LayoutTests Revision 120407 Author rn...@webkit.org Date 2012-06-14 23:23:21 -0700 (Thu, 14 Jun 2012) Log Message Use testRunner instead of layoutTestController in battery status and canvas tests https://bugs.webkit.org/show_bug.cgi?id=88761 Reviewed by Tony Chang. * batterystatus/resources/event-after-navigation-new.html: * batterystatus/script-tests/event-after-navigation.js: * canvas/philip/tests.js: (_addTest.endTest): (_addTest.window.onload): (_addTest): * canvas/philip/tests/2d.text-custom-font-load-crash.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/batterystatus/resources/event-after-navigation-new.html trunk/LayoutTests/batterystatus/script-tests/event-after-navigation.js trunk/LayoutTests/canvas/philip/tests/2d.text-custom-font-load-crash.html trunk/LayoutTests/canvas/philip/tests.js Diff Modified: trunk/LayoutTests/ChangeLog (120406 => 120407) --- trunk/LayoutTests/ChangeLog 2012-06-15 06:18:18 UTC (rev 120406) +++ trunk/LayoutTests/ChangeLog 2012-06-15 06:23:21 UTC (rev 120407) @@ -1,3 +1,18 @@ +2012-06-14 Ryosuke Niwa + +Use testRunner instead of layoutTestController in battery status and canvas tests +https://bugs.webkit.org/show_bug.cgi?id=88761 + +Reviewed by Tony Chang. + +* batterystatus/resources/event-after-navigation-new.html: +* batterystatus/script-tests/event-after-navigation.js: +* canvas/philip/tests.js: +(_addTest.endTest): +(_addTest.window.onload): +(_addTest): +* canvas/philip/tests/2d.text-custom-font-load-crash.html: + 2012-06-14 Emil A Eklund Cast paddings to int in RenderTableCell Modified: trunk/LayoutTests/batterystatus/resources/event-after-navigation-new.html (120406 => 120407) --- trunk/LayoutTests/batterystatus/resources/event-after-navigation-new.html 2012-06-15 06:18:18 UTC (rev 120406) +++ trunk/LayoutTests/batterystatus/resources/event-after-navigation-new.html 2012-06-15 06:23:21 UTC (rev 120407) @@ -7,7 +7,7 @@ SUCCESSinternals.setBatteryStatus(document, 'chargingchange', true, 3000, Number.POSITIVE_INFINITY, 0.5);-layoutTestController.notifyDone();+testRunner.notifyDone(); - \ No newline at end of file + Modified: trunk/LayoutTests/batterystatus/script-tests/event-after-navigation.js (120406 => 120407) --- trunk/LayoutTests/batterystatus/script-tests/event-after-navigation.js 2012-06-15 06:18:18 UTC (rev 120406) +++ trunk/LayoutTests/batterystatus/script-tests/event-after-navigation.js 2012-06-15 06:23:21 UTC (rev 120407) @@ -1,7 +1,7 @@ description('Tests for a crash where an event is fired after the page has been navigated away when the original page is in the page cache.'); -if (window.layoutTestController) -layoutTestController.overridePreference('WebKitUsesPageCachePreferenceKey', 1); +if (window.testRunner) +testRunner.overridePreference('WebKitUsesPageCachePreferenceKey', 1); else debug('This test can not be run without the LayoutTestController'); Modified: trunk/LayoutTests/canvas/philip/tests/2d.text-custom-font-load-crash.html (120406 => 120407) --- trunk/LayoutTests/canvas/philip/tests/2d.text-custom-font-load-crash.html 2012-06-15 06:18:18 UTC (rev 120406) +++ trunk/LayoutTests/canvas/philip/tests/2d.text-custom-font-load-crash.html 2012-06-15 06:23:21 UTC (rev 120407) @@ -12,8 +12,8 @@
[webkit-changes] [120406] trunk/Source/WebCore
Title: [120406] trunk/Source/WebCore
Revision 120406
Author commit-qu...@webkit.org
Date 2012-06-14 23:18:18 -0700 (Thu, 14 Jun 2012)
Log Message
[chromium] Remove unused CanvasLayerChromium.h/cpp from the tree
https://bugs.webkit.org/show_bug.cgi?id=89152
Patch by James Robinson on 2012-06-14
Reviewed by Adrienne Walker.
These files have been unused and not in the build system since r119769
* platform/graphics/chromium/CanvasLayerChromium.cpp: Removed.
* platform/graphics/chromium/CanvasLayerChromium.h: Removed.
Modified Paths
trunk/Source/WebCore/ChangeLog
Removed Paths
trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (120405 => 120406)
--- trunk/Source/WebCore/ChangeLog 2012-06-15 06:17:57 UTC (rev 120405)
+++ trunk/Source/WebCore/ChangeLog 2012-06-15 06:18:18 UTC (rev 120406)
@@ -1,3 +1,15 @@
+2012-06-14 James Robinson
+
+[chromium] Remove unused CanvasLayerChromium.h/cpp from the tree
+https://bugs.webkit.org/show_bug.cgi?id=89152
+
+Reviewed by Adrienne Walker.
+
+These files have been unused and not in the build system since r119769
+
+* platform/graphics/chromium/CanvasLayerChromium.cpp: Removed.
+* platform/graphics/chromium/CanvasLayerChromium.h: Removed.
+
2012-06-14 Emil A Eklund
Cast paddings to int in RenderTableCell
Deleted: trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.cpp (120405 => 120406)
--- trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.cpp 2012-06-15 06:17:57 UTC (rev 120405)
+++ trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.cpp 2012-06-15 06:18:18 UTC (rev 120406)
@@ -1,52 +0,0 @@
-/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-
-#if USE(ACCELERATED_COMPOSITING)
-
-#include "CanvasLayerChromium.h"
-
-#include "cc/CCTextureLayerImpl.h"
-
-namespace WebCore {
-
-CanvasLayerChromium::CanvasLayerChromium()
-: LayerChromium()
-{
-}
-
-PassOwnPtr CanvasLayerChromium::createCCLayerImpl()
-{
-return CCTextureLayerImpl::create(m_layerId);
-}
-
-}
-#endif // USE(ACCELERATED_COMPOSITING)
Deleted: trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.h (120405 => 120406)
--- trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.h 2012-06-15 06:17:57 UTC (rev 120405)
+++ trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.h 2012-06-15 06:18:18 UTC (rev 120406)
@@ -1,53 +0,0 @@
-/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTR
[webkit-changes] [120405] trunk/LayoutTests
Title: [120405] trunk/LayoutTests Revision 120405 Author morr...@google.com Date 2012-06-14 23:17:57 -0700 (Thu, 14 Jun 2012) Log Message Cast paddings to int in RenderTableCell https://bugs.webkit.org/show_bug.cgi?id=88918 Patch by Emil A Eklund on 2012-06-14 Reviewed by Levi Weintraub. Add test ensuring that table cells does not wrap when using fractional paddings. * fast/sub-pixel/table-cells-with-padding-do-not-wrap-expected.txt: Added. * fast/sub-pixel/table-cells-with-padding-do-not-wrap.html: Added. * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png: * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120404 => 120405) --- trunk/LayoutTests/ChangeLog 2012-06-15 06:16:14 UTC (rev 120404) +++ trunk/LayoutTests/ChangeLog 2012-06-15 06:17:57 UTC (rev 120405) @@ -22,6 +22,12 @@ 2012-06-14 MORITA Hajime +Unreviewed typo fix. + +* platform/chromium/TestExpectations: + +2012-06-14 MORITA Hajime + Unreviewed expectation update. - Marked cross-domain-message-event-dispatch.html and track-cue-rendering-snap-to-lines-not-set.html Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120404 => 120405) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-15 06:16:14 UTC (rev 120404) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-15 06:17:57 UTC (rev 120405) @@ -3733,10 +3733,13 @@ BUGWK89149 : http/tests/fileapi/create-blob-url-from-data-url.html = TEXT -// Flaky BUGWK89166 : http/tests/messaging/cross-domain-message-event-dispatch.html : TEXT BUGWK89167 : media/track/track-cue-rendering-snap-to-lines-not-set.html : TEXT +// Flaky +BUGWK89166 : http/tests/messaging/cross-domain-message-event-dispatch.html = TEXT +BUGWK89167 : media/track/track-cue-rendering-snap-to-lines-not-set.html = TEXT + // Temporarily mark as failing on mac and windows until they can be rebaselined. BUG_EAE MAC WIN : LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml = PASS IMAGE TEXT IMAGE+TEXT BUG_EAE MAC WIN : LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml = PASS IMAGE TEXT IMAGE+TEXT @@ -3746,3 +3749,4 @@ BUG_EAE MAC WIN : LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml = PASS IMAGE TEXT IMAGE+TEXT BUG_EAE MAC WIN : tables/mozilla_expected_failures/bugs/bug89315.html = PASS IMAGE TEXT IMAGE+TEXT BUG_EAE MAC WIN : tables/mozilla_expected_failures/bugs/bug89315.html = PASS IMAGE TEXT IMAGE+TEXT + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120404] trunk/Source/WebKit/blackberry
Title: [120404] trunk/Source/WebKit/blackberry Revision 120404 Author commit-qu...@webkit.org Date 2012-06-14 23:16:14 -0700 (Thu, 14 Jun 2012) Log Message [BlackBerry] Selection - Crash when manipulating selection by dragging handle https://bugs.webkit.org/show_bug.cgi?id=89160 RIMBUG:164970 Avoid to set position in shadow tree to the new selection's base. It crashes when setting a shadow position to a selection' base. Patch by Sean Wang on 2012-06-14 Reviewed by Antonio Gomes. * WebKitSupport/SelectionHandler.cpp: (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping): Modified Paths trunk/Source/WebKit/blackberry/ChangeLog trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp Diff Modified: trunk/Source/WebKit/blackberry/ChangeLog (120403 => 120404) --- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-15 06:07:24 UTC (rev 120403) +++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-15 06:16:14 UTC (rev 120404) @@ -1,3 +1,17 @@ +2012-06-14 Sean Wang + +[BlackBerry] Selection - Crash when manipulating selection by dragging handle +https://bugs.webkit.org/show_bug.cgi?id=89160 + +RIMBUG:164970 +Avoid to set position in shadow tree to the new selection's base. It +crashes when setting a shadow position to a selection' base. + +Reviewed by Antonio Gomes. + +* WebKitSupport/SelectionHandler.cpp: +(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping): + 2012-06-14 Mary Wu [BlackBerry] empty plugin cause browser hang Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (120403 => 120404) --- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-06-15 06:07:24 UTC (rev 120403) +++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-06-15 06:16:14 UTC (rev 120404) @@ -152,7 +152,7 @@ // outside the visible rect. To work around the bug, this is a copy of // visiblePositionAtPoint which which passes ignoreClipping=true. // See RIM Bug #4315. -HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, true /* allowShadowContent */, true /* ignoreClipping */); +HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, false /* allowShadowContent */, true /* ignoreClipping */); Node* node = result.innerNode(); if (!node || node->document() != frame.document()) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120402] trunk/Source/WebCore
Title: [120402] trunk/Source/WebCore Revision 120402 Author ba...@chromium.org Date 2012-06-14 22:55:42 -0700 (Thu, 14 Jun 2012) Log Message [Chromium] Check the result of FontCache::getCachedFontPlatformData() https://bugs.webkit.org/show_bug.cgi?id=89141 Reviewed by Kent Tamura. The value of FontCache::getCachedFontPlatformData() could be invalid, so we should check the value before use it. No new tests. No new functionality. * platform/graphics/skia/FontCacheSkia.cpp: (WebCore::FontCache::getFontDataForCharacters): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (120401 => 120402) --- trunk/Source/WebCore/ChangeLog 2012-06-15 05:53:52 UTC (rev 120401) +++ trunk/Source/WebCore/ChangeLog 2012-06-15 05:55:42 UTC (rev 120402) @@ -1,3 +1,18 @@ +2012-06-14 Kenichi Ishibashi + +[Chromium] Check the result of FontCache::getCachedFontPlatformData() +https://bugs.webkit.org/show_bug.cgi?id=89141 + +Reviewed by Kent Tamura. + +The value of FontCache::getCachedFontPlatformData() could be invalid, +so we should check the value before use it. + +No new tests. No new functionality. + +* platform/graphics/skia/FontCacheSkia.cpp: +(WebCore::FontCache::getFontDataForCharacters): + 2012-06-14 Gregg Tavares Fix framebuffer completeness test Modified: trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp (120401 => 120402) --- trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp 2012-06-15 05:53:52 UTC (rev 120401) +++ trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp 2012-06-15 05:55:42 UTC (rev 120402) @@ -84,7 +84,10 @@ description.setItalic(FontItalicOff); } -FontPlatformData platformData = FontPlatformData(*getCachedFontPlatformData(description, atomicFamily, DoNotRetain)); +FontPlatformData* substitutePlatformData = getCachedFontPlatformData(description, atomicFamily, DoNotRetain); +if (!substitutePlatformData) +return 0; +FontPlatformData platformData = FontPlatformData(*substitutePlatformData); platformData.setFakeBold(shouldSetFakeBold); platformData.setFakeItalic(shouldSetFakeItalic); return getCachedFontData(&platformData, DoNotRetain); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120401] trunk
Title: [120401] trunk
Revision 120401
Author commit-qu...@webkit.org
Date 2012-06-14 22:53:52 -0700 (Thu, 14 Jun 2012)
Log Message
Fix framebuffer completeness test
https://bugs.webkit.org/show_bug.cgi?id=89127
Patch by Gregg Tavares on 2012-06-14
Reviewed by Kenneth Russell.
No new tests just fixing failing tests.
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::initializeAttachments):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
(WebCore):
(WebCore::GraphicsContext3D::getClearBitsByFormat):
(WebCore::GraphicsContext3D::getChannelBitsByFormat):
* platform/graphics/GraphicsContext3D.h:
Modified Paths
trunk/LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLFramebuffer.cpp
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h
Diff
Modified: trunk/LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt (120400 => 120401)
--- trunk/LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt 2012-06-15 05:29:54 UTC (rev 120400)
+++ trunk/LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt 2012-06-15 05:53:52 UTC (rev 120401)
@@ -3,7 +3,6 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Testing alpha = true
-PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS getError was expected value: NO_ERROR : should be no errors
PASS gl = getWebGL(1, 1, { alpha: true, depth: false, stencil: false, antialias: false }, [ 0, 0, 0, 0 ], 1, 0) is non-null.
PASS gl.getParameter(gl.ALPHA_BITS) >= 8 is true
@@ -17,7 +16,6 @@
PASS pixel is correctColor
PASS Math.abs(pixel[0] - 127) <= 1 && Math.abs(pixel[1] - 127) <= 1 && Math.abs(pixel[2] - 127) <= 1 && Math.abs(pixel[3] - 127) <= 1 is true
Testing alpha = false
-PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS getError was expected value: NO_ERROR : should be no errors
PASS gl = getWebGL(1, 1, { alpha: false, depth: false, stencil: false, antialias: false }, [ 0, 0, 0, 0 ], 1, 0) is non-null.
PASS gl.getParameter(gl.ALPHA_BITS) == 0 is true
@@ -31,7 +29,6 @@
PASS pixel is correctColor
PASS Math.abs(pixel[0] - 127) <= 1 && Math.abs(pixel[1] - 127) <= 1 && Math.abs(pixel[2] - 127) <= 1 && Math.abs(pixel[3] - 127) <= 1 is true
Testing depth = true
-PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS getError was expected value: NO_ERROR : should be no errors
PASS gl = getWebGL(1, 1, { stencil: false, antialias: false }, [ 0, 0, 0, 1 ], 1, 0) is non-null.
PASS gl.getParameter(gl.DEPTH_BITS) >= 16 is true
@@ -41,8 +38,8 @@
PASS gl.getParameter(gl.ALPHA_BITS) >= 8 is true
PASS contextAttribs = gl.getContextAttributes() is non-null.
PASS pixel is correctColor
+PASS pixel is [0, 0, 0, 255]
Testing depth = false
-PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS getError was expected value: NO_ERROR : should be no errors
PASS gl = getWebGL(1, 1, { depth: false, stencil: false, antialias: false }, [ 0, 0, 0, 1 ], 1, 0) is non-null.
PASS gl.getParameter(gl.DEPTH_BITS) == 0 is true
@@ -52,8 +49,8 @@
PASS gl.getParameter(gl.ALPHA_BITS) >= 8 is true
PASS contextAttribs = gl.getContextAttributes() is non-null.
PASS pixel is correctColor
+PASS pixel is [0, 0, 0, 255]
Testing stencil = true, depth = false
-PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS getError was expected value: NO_ERROR : should be no errors
PASS gl = getWebGL(1, 1, { depth: false, stencil: true, antialias: false }, [ 0, 0, 0, 1 ], 1, 0) is non-null.
PASS gl.getParameter(gl.RED_BITS) >= 8 is true
@@ -64,8 +61,8 @@
PASS gl.getParameter(gl.STENCIL_BITS) >= 8 is true
PASS contextAttribs = gl.getContextAttributes() is non-null.
PASS pixel is correctColor
+PASS pixel is [0, 0, 0, 255]
Testing stencil = false, depth = false
-PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS getError was expected value: NO_ERROR : should be no errors
PASS gl = getWebGL(1, 1, { depth: false, stencil: false, antialias: false }, [ 0, 0, 0, 1 ], 1, 0) is non-null.
PASS gl.getParameter(gl.RED_BITS) >= 8 is true
@@ -76,8 +73,8 @@
PASS gl.getParameter(gl.STENCIL_BITS) == 0 is true
PASS contextAttribs = gl.getContextAttributes() is non-null.
PASS pixel is correctColor
+PASS pixel is [0, 0, 0, 255]
Testing stencil = true, depth = true
-PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS getError was expected value: NO_E
[webkit-changes] [120400] trunk/LayoutTests
Title: [120400] trunk/LayoutTests Revision 120400 Author morr...@google.com Date 2012-06-14 22:29:54 -0700 (Thu, 14 Jun 2012) Log Message Unreviewed expectation update. - Marked cross-domain-message-event-dispatch.html and track-cue-rendering-snap-to-lines-not-set.html * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120399 => 120400) --- trunk/LayoutTests/ChangeLog 2012-06-15 05:24:21 UTC (rev 120399) +++ trunk/LayoutTests/ChangeLog 2012-06-15 05:29:54 UTC (rev 120400) @@ -1,3 +1,10 @@ +2012-06-14 MORITA Hajime + +Unreviewed expectation update. +- Marked cross-domain-message-event-dispatch.html and track-cue-rendering-snap-to-lines-not-set.html + +* platform/chromium/TestExpectations: + 2012-06-14 Kent Tamura Validate form state strings in FormController::setStateForNewFormElements() Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120399 => 120400) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-15 05:24:21 UTC (rev 120399) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-15 05:29:54 UTC (rev 120400) @@ -3732,3 +3732,7 @@ BUGCR132898 : http/tests/websocket/tests/hybi/workers/close.html = TEXT BUGWK89149 : http/tests/fileapi/create-blob-url-from-data-url.html = TEXT + +// Flaky +BUGWK89166 : http/tests/messaging/cross-domain-message-event-dispatch.html : TEXT +BUGWK89167 : media/track/track-cue-rendering-snap-to-lines-not-set.html : TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120399] trunk/Source/WebKit/blackberry
Title: [120399] trunk/Source/WebKit/blackberry
Revision 120399
Author mary...@torchmobile.com.cn
Date 2012-06-14 22:24:21 -0700 (Thu, 14 Jun 2012)
Log Message
[BlackBerry] empty plugin cause browser hang
https://bugs.webkit.org/show_bug.cgi?id=89091
Reviewed by Rob Buis.
Add check before clean pluginView in FrameLoaderBlackBerry in case
it didn't have any content.
RIM PR# 165336
Reviewed internally by George Staikos
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::finishedLoading):
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (120398 => 120399)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-15 04:59:37 UTC (rev 120398)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-15 05:24:21 UTC (rev 120399)
@@ -1,3 +1,18 @@
+2012-06-14 Mary Wu
+
+[BlackBerry] empty plugin cause browser hang
+https://bugs.webkit.org/show_bug.cgi?id=89091
+
+Reviewed by Rob Buis.
+
+Add check before clean pluginView in FrameLoaderBlackBerry in case
+it didn't have any content.
+RIM PR# 165336
+Reviewed internally by George Staikos
+
+* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+(WebCore::FrameLoaderClientBlackBerry::finishedLoading):
+
2012-06-14 Genevieve Mak
Always convert touch events to mouse events if the
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (120398 => 120399)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-06-15 04:59:37 UTC (rev 120398)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-06-15 05:24:21 UTC (rev 120399)
@@ -369,7 +369,8 @@
void FrameLoaderClientBlackBerry::finishedLoading(DocumentLoader*)
{
if (m_pluginView) {
-m_pluginView->didFinishLoading();
+if (m_hasSentResponseToPlugin)
+m_pluginView->didFinishLoading();
m_pluginView = 0;
m_hasSentResponseToPlugin = false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120398] trunk/Source/WebCore
Title: [120398] trunk/Source/WebCore
Revision 120398
Author e...@google.com
Date 2012-06-14 21:59:37 -0700 (Thu, 14 Jun 2012)
Log Message
[chromium] Make TiledLayerChromium robust to unexpected null tiles
https://bugs.webkit.org/show_bug.cgi?id=89143
Reviewed by James Robinson.
Although there shouldn't ever be null tiles in the map, it appears to
be occurring frequently enough to show up in crash reports. In the
short term, be robust to this so the tiler doesn't crash. This should
eventually be reverted.
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120397 => 120398)
--- trunk/Source/WebCore/ChangeLog 2012-06-15 04:34:25 UTC (rev 120397)
+++ trunk/Source/WebCore/ChangeLog 2012-06-15 04:59:37 UTC (rev 120398)
@@ -1,3 +1,22 @@
+2012-06-14 Adrienne Walker
+
+[chromium] Make TiledLayerChromium robust to unexpected null tiles
+https://bugs.webkit.org/show_bug.cgi?id=89143
+
+Reviewed by James Robinson.
+
+Although there shouldn't ever be null tiles in the map, it appears to
+be occurring frequently enough to show up in crash reports. In the
+short term, be robust to this so the tiler doesn't crash. This should
+eventually be reverted.
+
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::pushPropertiesTo):
+(WebCore::TiledLayerChromium::setLayerTreeHost):
+(WebCore::TiledLayerChromium::invalidateRect):
+(WebCore::TiledLayerChromium::updateTiles):
+(WebCore::TiledLayerChromium::resetUpdateState):
+
2012-06-14 Kent Tamura
Validate form state strings in FormController::setStateForNewFormElements()
Modified: trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp (120397 => 120398)
--- trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2012-06-15 04:34:25 UTC (rev 120397)
+++ trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2012-06-15 04:59:37 UTC (rev 120398)
@@ -216,6 +216,9 @@
int i = iter->first.first;
int j = iter->first.second;
UpdatableTile* tile = static_cast(iter->second.get());
+// FIXME: This should not ever be null.
+if (!tile)
+continue;
tile->isInUseOnImpl = false;
if (!tile->managedTexture()->isValid(m_tiler->tileSize(), m_textureFormat)) {
invalidTiles.append(tile);
@@ -243,6 +246,9 @@
if (host && host != layerTreeHost()) {
for (CCLayerTilingData::TileMap::const_iterator iter = m_tiler->tiles().begin(); iter != m_tiler->tiles().end(); ++iter) {
UpdatableTile* tile = static_cast(iter->second.get());
+// FIXME: This should not ever be null.
+if (!tile)
+continue;
tile->managedTexture()->setTextureManager(host->contentsTextureManager());
}
}
@@ -303,6 +309,9 @@
for (CCLayerTilingData::TileMap::const_iterator iter = m_tiler->tiles().begin(); iter != m_tiler->tiles().end(); ++iter) {
UpdatableTile* tile = static_cast(iter->second.get());
ASSERT(tile);
+// FIXME: This should not ever be null.
+if (!tile)
+continue;
IntRect bound = m_tiler->tileRect(tile);
bound.intersect(layerRect);
tile->dirtyRect.unite(bound);
@@ -418,8 +427,9 @@
for (int j = top; j <= bottom; ++j) {
for (int i = left; i <= right; ++i) {
UpdatableTile* tile = tileAt(i, j);
+// FIXME: This should not ever be null.
if (!tile)
-CRASH();
+continue;
if (tile->updated)
tile->copyAndClearDirty();
else if (!idle && occlusion && tile->isDirty())
@@ -451,6 +461,9 @@
for (int j = top; j <= bottom; ++j) {
for (int i = left; i <= right; ++i) {
UpdatableTile* tile = tileAt(i, j);
+// FIXME: This should not ever be null.
+if (!tile)
+continue;
IntRect tileRect = m_tiler->tileBounds(i, j);
@@ -560,6 +573,9 @@
CCLayerTilingData::TileMap::const_iterator end = m_tiler->tiles().end();
for (CCLayerTilingData::TileMap::const_iterator iter = m_tiler->tiles().begin(); iter != end; ++iter) {
UpdatableTile* tile = static_cast(iter->second.get());
+// FIXME: This should not ever be null.
+if (!tile)
+continue;
tile->updateRect = IntRect();
tile->partialUpdate = false;
tile->updated = false;
_
[webkit-changes] [120397] trunk
Title: [120397] trunk
Revision 120397
Author tk...@chromium.org
Date 2012-06-14 21:34:25 -0700 (Thu, 14 Jun 2012)
Log Message
Validate form state strings in FormController::setStateForNewFormElements()
https://bugs.webkit.org/show_bug.cgi?id=88768
Reviewed by Hajime Morita.
.:
* Source/autotools/symbols.filter: Expose some symbols used by Internals.cpp.
Source/WebCore:
Reject invalid form state vectors. This state vectors are generated by
WebKit itself. However it can be invalid because
- Serialized state vectors can be corrupted
- A future version of WebKit might change the format
So we had better reject unexpected state vectors as possible.
Test: fast/forms/state-restore-broken-state.html
* WebCore.exp.in: Expose some symbols used by Internals.cpp.
* html/FormController.cpp:
(WebCore::isNotFormControlTypeCharacter): A helper for state validation.
(WebCore::FormController::setStateForNewFormElements):
Reject state vectors of which size is not a multiple of 3, or a type name is invalid.
* testing/Internals.cpp:
(WebCore::Internals::formControlStateOfPreviousHistoryItem):
Returns a form state vector of the previous document.
(WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
Sets a form state vector for the previous document.
* testing/Internals.h: Declare new functions.
* testing/Internals.idl: ditto.
Source/WebKit2:
* win/WebKit2.def: Expose some symbols used by Internals.cpp.
* win/WebKit2CFLite.def: ditto.
LayoutTests:
* fast/forms/resources/state-restore-broken-state-1.html: Added.
* fast/forms/resources/state-restore-broken-state-2.html: Added.
* fast/forms/state-restore-broken-state-expected.txt: Added.
* fast/forms/state-restore-broken-state.html: Added.
Modified Paths
trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/html/FormController.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def
trunk/Source/WebKit2/win/WebKit2CFLite.def
trunk/Source/autotools/symbols.filter
Added Paths
trunk/LayoutTests/fast/forms/resources/state-restore-broken-state-1.html
trunk/LayoutTests/fast/forms/resources/state-restore-broken-state-2.html
trunk/LayoutTests/fast/forms/state-restore-broken-state-expected.txt
trunk/LayoutTests/fast/forms/state-restore-broken-state.html
Diff
Modified: trunk/ChangeLog (120396 => 120397)
--- trunk/ChangeLog 2012-06-15 04:21:38 UTC (rev 120396)
+++ trunk/ChangeLog 2012-06-15 04:34:25 UTC (rev 120397)
@@ -1,3 +1,12 @@
+2012-06-14 Kent Tamura
+
+Validate form state strings in FormController::setStateForNewFormElements()
+https://bugs.webkit.org/show_bug.cgi?id=88768
+
+Reviewed by Hajime Morita.
+
+* Source/autotools/symbols.filter: Expose some symbols used by Internals.cpp.
+
2012-06-14 Chris Guan
[Blackberry] add a new Api named setAllowNotification
Modified: trunk/LayoutTests/ChangeLog (120396 => 120397)
--- trunk/LayoutTests/ChangeLog 2012-06-15 04:21:38 UTC (rev 120396)
+++ trunk/LayoutTests/ChangeLog 2012-06-15 04:34:25 UTC (rev 120397)
@@ -1,3 +1,15 @@
+2012-06-14 Kent Tamura
+
+Validate form state strings in FormController::setStateForNewFormElements()
+https://bugs.webkit.org/show_bug.cgi?id=88768
+
+Reviewed by Hajime Morita.
+
+* fast/forms/resources/state-restore-broken-state-1.html: Added.
+* fast/forms/resources/state-restore-broken-state-2.html: Added.
+* fast/forms/state-restore-broken-state-expected.txt: Added.
+* fast/forms/state-restore-broken-state.html: Added.
+
2012-06-14 Sheriff Bot
Unreviewed, rolling out r120393.
Added: trunk/LayoutTests/fast/forms/resources/state-restore-broken-state-1.html (0 => 120397)
--- trunk/LayoutTests/fast/forms/resources/state-restore-broken-state-1.html (rev 0)
+++ trunk/LayoutTests/fast/forms/resources/state-restore-broken-state-1.html 2012-06-15 04:34:25 UTC (rev 120397)
@@ -0,0 +1,18 @@
+
+
+
+
+
+
+function handleLoad() {
+if (!parent.isGoingBack) {
+document.f.name1.value = 'modified';
+setTimeout(function() {
+window.location.href = '';
+}, 0);
+} else {
+parent.didSecondLoad();
+}
+}
+
+
Property changes on: trunk/LayoutTests/fast/forms/resources/state-restore-broken-state-1.html
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/forms/resources/state-restore-broken-state-2.html (0 => 120397)
--- trunk/LayoutTests/fast/forms/resources/state-restore-broken-state-2.html (rev 0)
+++ trunk/LayoutTests/fast/forms/resources/state-restore-broken-state-2.html 2012-06-15 04:34:25 UTC (rev 120397)
@@ -0,0 +1,9 @@
+
+setTimeout(function() {
+console.log('Generated st
[webkit-changes] [120396] trunk
Title: [120396] trunk Revision 120396 Author commit-qu...@webkit.org Date 2012-06-14 21:21:38 -0700 (Thu, 14 Jun 2012) Log Message Unreviewed, rolling out r120393. http://trac.webkit.org/changeset/120393 https://bugs.webkit.org/show_bug.cgi?id=89163 breaks cr-mac build (Requested by morrita on #webkit). Patch by Sheriff Bot on 2012-06-14 Source/WebCore: * WebCore.gyp/WebCore.gyp: * platform/image-decoders/ImageDecoder.h: (ImageFrame): (ImageDecoder): * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (turboSwizzled): (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::close): (WebCore::JPEGImageReader::decode): (JPEGImageReader): (WebCore::JPEGImageDecoder::outputScanlines): * platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): (PNGImageReader): (WebCore::PNGImageReader::decodingSizeOnly): (WebCore::PNGImageReader::interlaceBuffer): (WebCore::PNGImageReader::hasAlpha): (WebCore::PNGImageReader::setHasAlpha): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable): * platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore): (WebCore::resolveColorSpace): (WebCore::createColorSpace): (WebCore::ImageFrame::setColorProfile): (WebCore::ImageFrame::setStatus): Source/WTF: * wtf/Platform.h: LayoutTests: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gyp/WebCore.gyp trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp trunk/Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp trunk/Source/WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp Diff Modified: trunk/LayoutTests/ChangeLog (120395 => 120396) --- trunk/LayoutTests/ChangeLog 2012-06-15 04:17:39 UTC (rev 120395) +++ trunk/LayoutTests/ChangeLog 2012-06-15 04:21:38 UTC (rev 120396) @@ -1,5 +1,15 @@ 2012-06-14 Sheriff Bot +Unreviewed, rolling out r120393. +http://trac.webkit.org/changeset/120393 +https://bugs.webkit.org/show_bug.cgi?id=89163 + +breaks cr-mac build (Requested by morrita on #webkit). + +* platform/chromium/TestExpectations: + +2012-06-14 Sheriff Bot + Unreviewed, rolling out r120384. http://trac.webkit.org/changeset/120384 https://bugs.webkit.org/show_bug.cgi?id=89157 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120395 => 120396) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-15 04:17:39 UTC (rev 120395) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-15 04:21:38 UTC (rev 120396) @@ -1174,6 +1174,10 @@ // test_shell, DRT do not correctly schedule paints when invalidating. BUGCR62433 WIN : fast/images/gif-loop-count.html = IMAGE +// Implement color profile support. +BUGCR143 : fast/images/jpeg-with-color-profile.html = MISSING +BUGCR143 : fast/images/png-with-color-profile.html = MISSING + // - // SVG TESTS // - @@ -3533,98 +3537,6 @@ BUGWK68744 : fast/block/float/float-not-removed-from-next-sibling4.html = IMAGE -// Needs to be rebaselined. -BUGWK87761 MAC LINUX WIN : compositing/color-matching/image-color-matching.html = IMAGE -BUGWK87761 MAC : compositing/masks/direct-image-mask.html = IMAGE -BUGWK87761 MAC : compositing/reflections/simple-composited-reflections.html = IMAGE -BUGWK87761 MAC : compositing/visibility/visibility-image-layers.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/crash-filter-change.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/crash-hw-sw-switch.html = IMAGE -BUGWK87761 LINUX : css3/filters/custom/custom-filter-shader-cache.html = IMAGE -BUGWK87761 MAC : css3/filters/custom/effect-color-check.html = IMAGE -BUGWK87761 LINUX : css3/filters/custom/effect-custom-combined-missing.html = IMAGE -BUGWK87761 LINUX : css3/filters/custom/effect-custom.html = IMAGE -BUGWK87761 MAC LINUX : css3/filters/custom/missing-custom-filter-shader.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/effect-blur-hw.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/effect-blur.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/effect-brightness-hw.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/effect-brightness.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/effect-combined-hw.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/effect-combined.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/effect-contrast-hw.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/effect-contrast.html = IMAGE -BUGWK87761 MAC LINUX WIN : css3/filters/effect-drop-
[webkit-changes] [120395] trunk/Source/WebCore
Title: [120395] trunk/Source/WebCore Revision 120395 Author jchaffr...@webkit.org Date 2012-06-14 21:17:39 -0700 (Thu, 14 Jun 2012) Log Message RenderLayer subtrees without any self-painting layer shouldn't be walked during painting https://bugs.webkit.org/show_bug.cgi?id=8 Reviewed by Simon Fraser. Performance optimization, covered by existing tests. The gist of this change is to add a has-self-painting-layer-descendant flag (including an invalidation logic) that is used to avoid walking subtrees without any self-painting layer. On http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows by 100 columns table, it brings the paint time during scrolling from ~45ms to ~6ms on my machine. The test case is a pathologic example here but the optimization should apply in other cases. The new update logic piggy-backs on top of the existing updateVisibilityStatus() one that got repurposed and renamed as part of this change. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::styleChanged): These functions were updated to dirty / set the new flag. (WebCore::RenderLayer::dirtyAncestorChainHasSelfPaintingLayerDescendantStatus): (WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant): Added those functions to handle setting / invalidating the new flag. (WebCore::RenderLayer::updateSelfPaintingLayerAfterStyleChange): Added this function to handle style update. (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::paintLayerContentsAndReflection): (WebCore::RenderLayer::paintLayerContents): (WebCore::RenderLayer::paintList): Changed this logic to bail out if we have no self-painting descendants. This is what is giving the performance improvement. Also added some performance ASSERTs to ensure the methods are not called when they shouldn't. (WebCore::RenderLayer::updateDescendantDependentFlags): Renamed from updateVisibilityStatus to account for the new usage. (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateLayerPositionsAfterScroll): (WebCore::RenderLayer::collectLayers): * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Updated after updateVisibilityStatus rename. * rendering/RenderLayer.h: (WebCore::RenderLayer::hasSelfPaintingLayerDescendant): Added the declaration of the new functions as well as the new flag and dirty bit. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h trunk/Source/WebCore/rendering/RenderLayerBacking.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (120394 => 120395) --- trunk/Source/WebCore/ChangeLog 2012-06-15 03:06:53 UTC (rev 120394) +++ trunk/Source/WebCore/ChangeLog 2012-06-15 04:17:39 UTC (rev 120395) @@ -1,3 +1,59 @@ +2012-06-14 Julien Chaffraix + +RenderLayer subtrees without any self-painting layer shouldn't be walked during painting +https://bugs.webkit.org/show_bug.cgi?id=8 + +Reviewed by Simon Fraser. + +Performance optimization, covered by existing tests. + +The gist of this change is to add a has-self-painting-layer-descendant flag (including an +invalidation logic) that is used to avoid walking subtrees without any self-painting layer. + +On http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows +by 100 columns table, it brings the paint time during scrolling from ~45ms to ~6ms +on my machine. The test case is a pathologic example here but the optimization should +apply in other cases. + +The new update logic piggy-backs on top of the existing updateVisibilityStatus() one that +got repurposed and renamed as part of this change. + +* rendering/RenderLayer.cpp: +(WebCore::RenderLayer::RenderLayer): +(WebCore::RenderLayer::addChild): +(WebCore::RenderLayer::removeChild): +(WebCore::RenderLayer::styleChanged): +These functions were updated to dirty / set the new flag. + +(WebCore::RenderLayer::dirtyAncestorChainHasSelfPaintingLayerDescendantStatus): +(WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant): +Added those functions to handle setting / invalidating the new flag. + +(WebCore::RenderLayer::updateSelfPaintingLayerAfterStyleChange): +Added this function to handle style update. + +(WebCore::RenderLayer::paintLayer): +(WebCore::RenderLayer::paintLayerContentsAndReflection): +(WebCore::RenderLayer::paintLayerContents): +(WebCore::RenderLayer::paintList): +Changed this logic to bail out if we have no self-painting descendants. This is what +is giving the performance improvement. Also added some performance ASSERTs to ensure +the methods are not called when they sh
[webkit-changes] [120394] trunk
Title: [120394] trunk
Revision 120394
Author wangxian...@chromium.org
Date 2012-06-14 20:06:53 -0700 (Thu, 14 Jun 2012)
Log Message
[Chromium-Android] Initialize font rendering in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=89133
Reviewed by Adam Barth.
Source/WebKit/chromium:
* src/linuxish/WebFontRendering.cpp:
(WebKit::WebFontRendering::setSubpixelPositioning): Now calls WebFontInfo::setSubpixelPositioning to avoid API users from calling both and simplify platform differences at call sites.
Tools:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
* DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120393 => 120394)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-15 02:53:17 UTC (rev 120393)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-15 03:06:53 UTC (rev 120394)
@@ -1,3 +1,13 @@
+2012-06-14 Xianzhu Wang
+
+[Chromium-Android] Initialize font rendering in DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=89133
+
+Reviewed by Adam Barth.
+
+* src/linuxish/WebFontRendering.cpp:
+(WebKit::WebFontRendering::setSubpixelPositioning): Now calls WebFontInfo::setSubpixelPositioning to avoid API users from calling both and simplify platform differences at call sites.
+
2012-06-14 Tony Chang
[chromium] Port IFrameRedirectTest.Test from test_shell_tests to webkit_unit_tests
Modified: trunk/Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp (120393 => 120394)
--- trunk/Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp 2012-06-15 02:53:17 UTC (rev 120393)
+++ trunk/Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp 2012-06-15 03:06:53 UTC (rev 120394)
@@ -33,6 +33,10 @@
#include "FontPlatformData.h"
+#if OS(LINUX)
+#include "WebFontInfo.h"
+#endif
+
using WebCore::FontPlatformData;
namespace WebKit {
@@ -71,6 +75,9 @@
void WebFontRendering::setSubpixelPositioning(bool useSubpixelPositioning)
{
FontPlatformData::setSubpixelPositioning(useSubpixelPositioning);
+#if OS(LINUX)
+WebFontInfo::setSubpixelPositioning(useSubpixelPositioning);
+#endif
}
// static
Modified: trunk/Tools/ChangeLog (120393 => 120394)
--- trunk/Tools/ChangeLog 2012-06-15 02:53:17 UTC (rev 120393)
+++ trunk/Tools/ChangeLog 2012-06-15 03:06:53 UTC (rev 120394)
@@ -1,3 +1,16 @@
+2012-06-14 Xianzhu Wang
+
+[Chromium-Android] Initialize font rendering in DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=89133
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/LayoutTestController.cpp:
+(LayoutTestController::reset):
+(LayoutTestController::setTextSubpixelPositioning):
+* DumpRenderTree/chromium/TestShellAndroid.cpp:
+(platformInit):
+
2012-06-14 Dongwoo Im
[EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
Modified: trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp (120393 => 120394)
--- trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp 2012-06-15 02:53:17 UTC (rev 120393)
+++ trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp 2012-06-15 03:06:53 UTC (rev 120394)
@@ -78,9 +78,8 @@
#include
#endif
-#if OS(LINUX)
-#include "linux/WebFontInfo.h"
-#include "linux/WebFontRendering.h"
+#if OS(LINUX) || OS(ANDROID)
+#include "linuxish/WebFontRendering.h"
#endif
using namespace WebCore;
@@ -702,8 +701,7 @@
m_taskList.revokeAll();
m_shouldStayOnPageAfterHandlingBeforeUnload = false;
m_hasCustomFullScreenBehavior = false;
-#if OS(LINUX)
-WebFontInfo::setSubpixelPositioning(false);
+#if OS(LINUX) || OS(ANDROID)
WebFontRendering::setSubpixelPositioning(false);
#endif
}
@@ -2196,13 +2194,11 @@
void LayoutTestController::setTextSubpixelPositioning(const CppArgumentList& arguments, CppVariant* result)
{
-#if OS(LINUX)
+#if OS(LINUX) || OS(ANDROID)
// Since FontConfig doesn't provide a variable to control subpixel positioning, we'll fall back
// to setting it globally for all fonts.
-if (arguments.size() > 0 && arguments[0].isBool()) {
-WebFontInfo::setSubpixelPositioning(arguments[0].value.boolValue);
+if (arguments.size() > 0 && arguments[0].isBool())
WebFontRendering::setSubpixelPositioning(arguments[0].value.boolValue);
-}
#endif
result->setNull();
}
Modified: trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp (120393 => 120394)
--- trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp 2012-06-15 02:53:17 UTC (rev 120393)
+++ trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp 201
[webkit-changes] [120393] trunk
Title: [120393] trunk Revision 120393 Author commit-qu...@webkit.org Date 2012-06-14 19:53:17 -0700 (Thu, 14 Jun 2012) Log Message Source/WebCore:[chromium] Add iccjpeg and qcms to chromium port https://bugs.webkit.org/show_bug.cgi?id=81974 Reviewed by Adam Barth. Covered by existing layout tests which will be rebaselined. * WebCore.gyp/WebCore.gyp: Add qcms to the build. * platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile. On OSX, return the default RGB profile. Add FIXME to use the user's monitor profile and verify that profile for other platforms. * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the two known output color spaces for which the decoder uses a data swizzle. (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For libjpeg-turbo, alpha may be present in the swizzled output color space. (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::close): (WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform to use during decoding, and ensure we switch to inputing RGBA data to qcms even if the desired output data is BGRA: outputScanlines() sends BGRA data to the frame buffer following color correction if needed. (JPEGImageReader): (WebCore::JPEGImageReader::colorTransform): qcms color transform getter. (WebCore::JPEGImageReader::createColorTransform): Create color transform. Release the existing transform (if any) and assign to the color transform created from the color profile data. (WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color transform to each decoded image row. * platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other setters and getters. (WebCore::PNGImageReader::decodingSizeOnly): Ditto. (WebCore::PNGImageReader::setHasAlpha): Ditto. (WebCore::PNGImageReader::hasAlpha): Ditto. (WebCore::PNGImageReader::interlaceBuffer): Ditto. (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer, used when a color transform is applied to the decoded image pixels. (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer. (WebCore::PNGImageReader::colorTransform): qcms color transform getter. (WebCore::PNGImageReader::createColorTransform): Create color transform. Release the existing transform (if any) and assign to the color transform created from the color profile data. (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color transform to use for decoding. Clear m_colorProfile (not used anymore). (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if a color transform is needed for decoding. Apply color transform to each decoded image row. * platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no longer used. Add a FIXME to remove the old implementation. (WebCore::ImageFrame::setStatus): Remove old color correction code. Patch by Tony Payne on 2012-06-14 Source/WTF: [chromium] Add iccjpeg and qcms to chromium port. https://bugs.webkit.org/show_bug.cgi?id=81974 Patch by Tony Payne on 2012-06-14 * wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB to each Chromium platform, excluding Android. Reviewed by Adam Barth. Modified Paths trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gyp/WebCore.gyp trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp trunk/Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp trunk/Source/WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp Diff Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120392 => 120393) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-15 02:50:55 UTC (rev 120392) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-15 02:53:17 UTC (rev 120393) @@ -1174,10 +1174,6 @@ // test_shell, DRT do not correctly schedule paints when invalidating. BUGCR62433 WIN : fast/images/gif-loop-count.html = IMAGE -// Implement color profile support. -BUGCR143 : fast/images/jpeg-with-color-profile.html = MISSING -BUGCR143 : fast/images/png-with-color-profile.html = MISSING - // -
[webkit-changes] [120392] trunk
Title: [120392] trunk
Revision 120392
Author commit-qu...@webkit.org
Date 2012-06-14 19:50:55 -0700 (Thu, 14 Jun 2012)
Log Message
Unreviewed, rolling out r120384.
http://trac.webkit.org/changeset/120384
https://bugs.webkit.org/show_bug.cgi?id=89157
breaks create-blob-url-from-data-url.html (Requested by
morrita on #webkit).
Patch by Sheriff Bot on 2012-06-14
Source/WebCore:
* fileapi/Blob.cpp:
(WebCore::Blob::Blob):
* fileapi/BlobURL.cpp:
(WebCore::BlobURL::createBlobURL):
* fileapi/BlobURL.h:
(BlobURL):
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
* fileapi/ThreadableBlobRegistry.h:
(WebCore):
(ThreadableBlobRegistry):
* html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::create):
LayoutTests:
* fast/files/file-reader-file-url-expected.txt: Removed.
* fast/files/file-reader-file-url.html: Removed.
* fast/files/resources/file-reader-file-url-iframe.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/Blob.cpp
trunk/Source/WebCore/fileapi/BlobURL.cpp
trunk/Source/WebCore/fileapi/BlobURL.h
trunk/Source/WebCore/fileapi/FileReaderLoader.cpp
trunk/Source/WebCore/fileapi/ThreadableBlobRegistry.cpp
trunk/Source/WebCore/fileapi/ThreadableBlobRegistry.h
trunk/Source/WebCore/html/DOMURL.cpp
trunk/Source/WebCore/page/SecurityOrigin.cpp
Removed Paths
trunk/LayoutTests/fast/files/file-reader-file-url-expected.txt
trunk/LayoutTests/fast/files/file-reader-file-url.html
trunk/LayoutTests/fast/files/resources/file-reader-file-url-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (120391 => 120392)
--- trunk/LayoutTests/ChangeLog 2012-06-15 02:46:41 UTC (rev 120391)
+++ trunk/LayoutTests/ChangeLog 2012-06-15 02:50:55 UTC (rev 120392)
@@ -1,3 +1,16 @@
+2012-06-14 Sheriff Bot
+
+Unreviewed, rolling out r120384.
+http://trac.webkit.org/changeset/120384
+https://bugs.webkit.org/show_bug.cgi?id=89157
+
+breaks create-blob-url-from-data-url.html (Requested by
+morrita on #webkit).
+
+* fast/files/file-reader-file-url-expected.txt: Removed.
+* fast/files/file-reader-file-url.html: Removed.
+* fast/files/resources/file-reader-file-url-iframe.html: Removed.
+
2012-06-14 Dale Curtis
Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
Deleted: trunk/LayoutTests/fast/files/file-reader-file-url-expected.txt (120391 => 120392)
--- trunk/LayoutTests/fast/files/file-reader-file-url-expected.txt 2012-06-15 02:46:41 UTC (rev 120391)
+++ trunk/LayoutTests/fast/files/file-reader-file-url-expected.txt 2012-06-15 02:50:55 UTC (rev 120392)
@@ -1,3 +0,0 @@
-CONSOLE MESSAGE: line 9: Received data: 0123456789
-
-Test that FileReader works under the file URL with file path separation enforced.
Deleted: trunk/LayoutTests/fast/files/file-reader-file-url.html (120391 => 120392)
--- trunk/LayoutTests/fast/files/file-reader-file-url.html 2012-06-15 02:46:41 UTC (rev 120391)
+++ trunk/LayoutTests/fast/files/file-reader-file-url.html 2012-06-15 02:50:55 UTC (rev 120392)
@@ -1,17 +0,0 @@
-
-
-
-if (window.layoutTestController) {
-layoutTestController.setAllowUniversalAccessFromFileURLs(false);
-layoutTestController.setAllowFileAccessFromFileURLs(false);
-layoutTestController.dumpAsText();
-layoutTestController.waitUntilDone();
-}
-
-
-
-
-Test that FileReader works under the file URL with file path separation enforced.
-
-
Deleted: trunk/LayoutTests/fast/files/resources/file-reader-file-url-iframe.html (120391 => 120392)
--- trunk/LayoutTests/fast/files/resources/file-reader-file-url-iframe.html 2012-06-15 02:46:41 UTC (rev 120391)
+++ trunk/LayoutTests/fast/files/resources/file-reader-file-url-iframe.html 2012-06-15 02:50:55 UTC (rev 120392)
@@ -1,25 +0,0 @@
-
-
-
-function runTest()
-{
-var blob = new Blob(["0123456789"]);
-var reader = new FileReader();
-reader._onload_ = function(event) {
-console.log("Received data: " + event.target.result);
-}
-reader._onloadend_ = function() {
-if (window.layoutTestController)
-layoutTestController.notifyDone();
-}
-reader._onerror_ = function(event) {
-console.log("Received error event: " + event.target.error.code);
-};
-reader.readAsText(blob);
-}
-
-
-
-
-
-
Modified: trunk/Source/WebCore/ChangeLog (120391 => 120392)
--- trunk/Source/WebCore/ChangeLog 2012-06-15 02:46:41 UTC (rev 120391)
+++ trunk/Source/WebCore/ChangeLog 2012-06-15 02:50:55 UTC (rev 120392)
@@ -1,3 +1,32 @@
+2012-06-14 Sheriff Bot
+
+Unreviewed, rolling out r120384.
+http://trac.webkit.org/changeset/120384
+https://bugs.webkit.org/show_bug.cgi?id=89157
+
+breaks create-blo
[webkit-changes] [120391] trunk/Source/WebKit/chromium
Title: [120391] trunk/Source/WebKit/chromium
Revision 120391
Author t...@chromium.org
Date 2012-06-14 19:46:41 -0700 (Thu, 14 Jun 2012)
Log Message
[chromium] Port IFrameRedirectTest.Test from test_shell_tests to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=89132
Reviewed by Adam Barth.
This test is currently in src/webkit/glue/iframe_redirect_unittest.cc
and uses test_shell's layoutTestController. Moving this will make
it easier to get rid of layoutTestController in test_shell.
* tests/WebFrameTest.cpp:
(WebKit::TEST_F):
(WebKit):
* tests/data/iframe_redirect.html: Added.
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp
Added Paths
trunk/Source/WebKit/chromium/tests/data/iframe_redirect.html
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120390 => 120391)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-15 02:25:15 UTC (rev 120390)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-15 02:46:41 UTC (rev 120391)
@@ -1,3 +1,19 @@
+2012-06-14 Tony Chang
+
+[chromium] Port IFrameRedirectTest.Test from test_shell_tests to webkit_unit_tests
+https://bugs.webkit.org/show_bug.cgi?id=89132
+
+Reviewed by Adam Barth.
+
+This test is currently in src/webkit/glue/iframe_redirect_unittest.cc
+and uses test_shell's layoutTestController. Moving this will make
+it easier to get rid of layoutTestController in test_shell.
+
+* tests/WebFrameTest.cpp:
+(WebKit::TEST_F):
+(WebKit):
+* tests/data/iframe_redirect.html: Added.
+
2012-06-14 David Reveman
[Chromium] Sub-pixel text rendering is incorrectly used for WebView with transparent background.
Modified: trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp (120390 => 120391)
--- trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-06-15 02:25:15 UTC (rev 120390)
+++ trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-06-15 02:46:41 UTC (rev 120391)
@@ -36,6 +36,7 @@
#include "FrameTestHelpers.h"
#include "FrameView.h"
#include "ResourceError.h"
+#include "WebDataSource.h"
#include "WebDocument.h"
#include "WebFindOptions.h"
#include "WebFormElement.h"
@@ -396,6 +397,28 @@
webkit_support::ServeAsynchronousMockedRequests();
}
+TEST_F(WebFrameTest, IframeRedirect)
+{
+registerMockedHttpURLLoad("iframe_redirect.html");
+registerMockedHttpURLLoad("visible_iframe.html");
+
+WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "iframe_redirect.html", true);
+webkit_support::RunAllPendingMessages(); // Queue the iframe.
+webkit_support::ServeAsynchronousMockedRequests(); // Load the iframe.
+
+WebFrame* iframe = webView->findFrameByName(WebString::fromUTF8("ifr"));
+ASSERT_TRUE(iframe);
+WebDataSource* iframeDataSource = iframe->dataSource();
+ASSERT_TRUE(iframeDataSource);
+WebVector redirects;
+iframeDataSource->redirectChain(redirects);
+ASSERT_EQ(2U, redirects.size());
+EXPECT_EQ(GURL("about:blank"), GURL(redirects[0]));
+EXPECT_EQ(GURL("http://www.test.com/visible_iframe.html"), GURL(redirects[1]));
+
+webView->close();
+}
+
TEST_F(WebFrameTest, ClearFocusedNodeTest)
{
registerMockedHttpURLLoad("iframe_clear_focused_node_test.html");
Added: trunk/Source/WebKit/chromium/tests/data/iframe_redirect.html (0 => 120391)
--- trunk/Source/WebKit/chromium/tests/data/iframe_redirect.html (rev 0)
+++ trunk/Source/WebKit/chromium/tests/data/iframe_redirect.html 2012-06-15 02:46:41 UTC (rev 120391)
@@ -0,0 +1,10 @@
+
+
+
+
+
+ var ifr = document.getElementById('ifr');
+ ifr.contentWindow.document.location = "visible_iframe.html";
+
+
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120390] trunk/Source/WebCore
Title: [120390] trunk/Source/WebCore
Revision 120390
Author yo...@chromium.org
Date 2012-06-14 19:25:15 -0700 (Thu, 14 Jun 2012)
Log Message
[Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=89155
Reviewed by Kent Tamura.
This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
and .h with just "cp" code. New files aren't compiled until bug 88980.
No new tests. This patch doesn't change behavior.
* rendering/RenderSearchField.cpp: Added.
(WebCore::RenderTextControlInnerBlock::positionForPoint):
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::containerElement):
(WebCore::RenderTextControlSingleLine::innerBlockElement):
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
(WebCore::RenderTextControlSingleLine::resultsButtonElement):
(WebCore::RenderTextControlSingleLine::cancelButtonElement):
(WebCore::RenderTextControlSingleLine::textBaseStyle):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::paint):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
(WebCore::RenderTextControlSingleLine::hasControlClip):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::computeControlHeight):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
(WebCore::RenderTextControlSingleLine::autosaveName):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::itemText):
(WebCore::RenderTextControlSingleLine::itemLabel):
(WebCore::RenderTextControlSingleLine::itemIcon):
(WebCore::RenderTextControlSingleLine::itemIsEnabled):
(WebCore::RenderTextControlSingleLine::itemStyle):
(WebCore::RenderTextControlSingleLine::menuStyle):
(WebCore::RenderTextControlSingleLine::clientInsetLeft):
(WebCore::RenderTextControlSingleLine::clientInsetRight):
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
(WebCore::RenderTextControlSingleLine::listSize):
(WebCore::RenderTextControlSingleLine::selectedIndex):
(WebCore::RenderTextControlSingleLine::popupDidHide):
(WebCore::RenderTextControlSingleLine::itemIsSeparator):
(WebCore::RenderTextControlSingleLine::itemIsLabel):
(WebCore::RenderTextControlSingleLine::itemIsSelected):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::fontSelector):
(WebCore::RenderTextControlSingleLine::hostWindow):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):
(WebCore::RenderTextControlSingleLine::createScrollbar):
(WebCore::RenderTextControlSingleLine::inputElement):
* rendering/RenderSearchField.h: Added.
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::popupIsVisible):
(WebCore::RenderTextControlSingleLine::isTextField):
(WebCore::toRenderTextControlSingleLine):
(RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
Modified Paths
trunk/Source/WebCore/ChangeLog
Added Paths
trunk/Source/WebCore/rendering/RenderSearchField.cpp
trunk/Source/WebCore/rendering/RenderSearchField.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (120389 => 120390)
--- trunk/Source/WebCore/ChangeLog 2012-06-15 02:11:28 UTC (rev 120389)
+++ trunk/Source/WebCore/ChangeLog 2012-06-15 02:25:15 UTC (rev 120390)
@@ -1,3 +1,85 @@
+2012-06-14 Yoshifumi Inoue
+
+[Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
+https://bugs.webkit.org/show_bug.cgi?id=89155
+
+Reviewed by Kent Tamura.
+
+This patch copies RenderTextControlSingleLine.cpp and .h in
[webkit-changes] [120389] trunk/Source/WebCore
Title: [120389] trunk/Source/WebCore
Revision 120389
Author tk...@chromium.org
Date 2012-06-14 19:11:28 -0700 (Thu, 14 Jun 2012)
Log Message
[JSC/V8] "DOMString[]" for function return values should not be null
https://bugs.webkit.org/show_bug.cgi?id=89151
Reviewed by Kentaro Hara.
jsArray and v8Array are used for "DOMString[]", not "DOMString[]?". So
we should not return _javascript_ null object.
No new tests. We have no plan to use this code in production code for
now. It will be used for window.internals functions.
* bindings/js/JSDOMBinding.cpp:
(WebCore::jsArray): For null input, returns an empty array, not null.
* bindings/v8/V8Binding.cpp:
(WebCore::v8Array): Implement DOMStringList -> _javascript_ array conversion.
Like jsArray(), we don't return null object.
* bindings/v8/V8Binding.h:
(WebCore): Declare v8Array().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (120388 => 120389)
--- trunk/Source/WebCore/ChangeLog 2012-06-15 02:04:43 UTC (rev 120388)
+++ trunk/Source/WebCore/ChangeLog 2012-06-15 02:11:28 UTC (rev 120389)
@@ -1,3 +1,24 @@
+2012-06-14 Kent Tamura
+
+[JSC/V8] "DOMString[]" for function return values should not be null
+https://bugs.webkit.org/show_bug.cgi?id=89151
+
+Reviewed by Kentaro Hara.
+
+jsArray and v8Array are used for "DOMString[]", not "DOMString[]?". So
+we should not return _javascript_ null object.
+
+No new tests. We have no plan to use this code in production code for
+now. It will be used for window.internals functions.
+
+* bindings/js/JSDOMBinding.cpp:
+(WebCore::jsArray): For null input, returns an empty array, not null.
+* bindings/v8/V8Binding.cpp:
+(WebCore::v8Array): Implement DOMStringList -> _javascript_ array conversion.
+Like jsArray(), we don't return null object.
+* bindings/v8/V8Binding.h:
+(WebCore): Declare v8Array().
+
2012-06-14 Dale Curtis
Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp (120388 => 120389)
--- trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2012-06-15 02:04:43 UTC (rev 120388)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2012-06-15 02:11:28 UTC (rev 120389)
@@ -149,11 +149,11 @@
JSC::JSValue jsArray(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, PassRefPtr stringList)
{
-if (!stringList)
-return jsNull();
JSC::MarkedArgumentBuffer list;
-for (unsigned i = 0; i < stringList->length(); ++i)
-list.append(jsString(exec, stringList->item(i)));
+if (stringList) {
+for (unsigned i = 0; i < stringList->length(); ++i)
+list.append(jsString(exec, stringList->item(i)));
+}
return JSC::constructArray(exec, globalObject, list);
}
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.cpp (120388 => 120389)
--- trunk/Source/WebCore/bindings/v8/V8Binding.cpp 2012-06-15 02:04:43 UTC (rev 120388)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.cpp 2012-06-15 02:11:28 UTC (rev 120389)
@@ -212,6 +212,16 @@
return v8NonStringValueToAtomicWebCoreString(value);
}
+v8::Handle v8Array(PassRefPtr stringList, v8::Isolate* isolate)
+{
+if (!stringList)
+return v8::Array::New();
+v8::Local result = v8::Array::New(stringList->length());
+for (unsigned i = 0; i < stringList->length(); ++i)
+result->Set(v8::Integer::New(i), v8String(stringList->item(i), isolate));
+return result;
+}
+
int toInt32(v8::Handle value, bool& ok)
{
ok = true;
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (120388 => 120389)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-06-15 02:04:43 UTC (rev 120388)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-06-15 02:11:28 UTC (rev 120389)
@@ -315,6 +315,8 @@
return array;
}
+v8::Handle v8Array(PassRefPtr, v8::Isolate*);
+
template
Vector toNativeArray(v8::Handle value)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120388] trunk
Title: [120388] trunk
Revision 120388
Author commit-qu...@webkit.org
Date 2012-06-14 19:04:43 -0700 (Thu, 14 Jun 2012)
Log Message
Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
https://bugs.webkit.org/show_bug.cgi?id=89129
Source/WebCore:
As titled, click-to-pause and double-click-to-play behavior are unwanted on Chromium. A
long standing issue (~3 years) has been to disable this feature.
Patch by Dale Curtis on 2012-06-14
Reviewed by Eric Carlson.
Uses existing click/double-click test.
* html/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
LayoutTests:
Fixes layout test to actually test what it says it tests. Previously it was
testing the opposite behavior and passing because MediaDocument auto-plays.
Additionally failing one half of the test would still allow you to pass the
other half. Both issues have been fixed.
Updates the test expectations for Chromium to reflect a failure.
Patch by Dale Curtis on 2012-06-14
Reviewed by Eric Carlson.
* media/video-click-dblckick-standalone-expected.txt:
* media/video-click-dblckick-standalone.html:
* platform/chromium/media/video-click-dblckick-standalone-expected.txt: Copied from LayoutTests/media/video-click-dblckick-standalone-expected.txt.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-click-dblckick-standalone-expected.txt
trunk/LayoutTests/media/video-click-dblckick-standalone.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/MediaDocument.cpp
Added Paths
trunk/LayoutTests/platform/chromium/media/video-click-dblckick-standalone-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (120387 => 120388)
--- trunk/LayoutTests/ChangeLog 2012-06-15 01:45:44 UTC (rev 120387)
+++ trunk/LayoutTests/ChangeLog 2012-06-15 02:04:43 UTC (rev 120388)
@@ -1,3 +1,22 @@
+2012-06-14 Dale Curtis
+
+Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
+https://bugs.webkit.org/show_bug.cgi?id=89129
+
+Fixes layout test to actually test what it says it tests. Previously it was
+testing the opposite behavior and passing because MediaDocument auto-plays.
+
+Additionally failing one half of the test would still allow you to pass the
+other half. Both issues have been fixed.
+
+Updates the test expectations for Chromium to reflect a failure.
+
+Reviewed by Eric Carlson.
+
+* media/video-click-dblckick-standalone-expected.txt:
+* media/video-click-dblckick-standalone.html:
+* platform/chromium/media/video-click-dblckick-standalone-expected.txt: Copied from LayoutTests/media/video-click-dblckick-standalone-expected.txt.
+
2012-06-14 Jian Li
Unreviewed. Skip the failed test due to r120384 for future investigation.
Modified: trunk/LayoutTests/media/video-click-dblckick-standalone-expected.txt (120387 => 120388)
--- trunk/LayoutTests/media/video-click-dblckick-standalone-expected.txt 2012-06-15 01:45:44 UTC (rev 120387)
+++ trunk/LayoutTests/media/video-click-dblckick-standalone-expected.txt 2012-06-15 02:04:43 UTC (rev 120388)
@@ -1,6 +1,6 @@
This tests that clicking on a standalone video will pause and double-clicking will play.
+PASS: video is paused.
PASS: video is playing
-PASS: video is paused
Modified: trunk/LayoutTests/media/video-click-dblckick-standalone.html (120387 => 120388)
--- trunk/LayoutTests/media/video-click-dblckick-standalone.html 2012-06-15 01:45:44 UTC (rev 120387)
+++ trunk/LayoutTests/media/video-click-dblckick-standalone.html 2012-06-15 02:04:43 UTC (rev 120388)
@@ -12,7 +12,7 @@
{
document.getElementById('console').appendChild(document.createTextNode(msg + "\n"));
}
-
+
function test()
{
video = document.getElementById('fr').contentDocument.getElementsByTagName('video')[0];
@@ -23,20 +23,27 @@
}
function test2()
{
+var click = document.createEvent("MouseEvents");
+click.initMouseEvent("click", true, true, window, 1, 0, 0, 0, 0, false, false, false, false, 0, document);
+video.dispatchEvent(click);
+if (video.paused) {
+log("PASS: video is paused.");
+test3();
+} else {
+log("FAIL: video should be paused");
+video.addEventListener('pause', test3);
+video.pause();
+}
+}
+function test3()
+{
var doubleClick = document.createEvent("MouseEvents");
doubleClick.initMouseEvent("dblclick", true, true, window, 2, 0, 0, 0, 0, false, false, false, false, 0, document);
-var click = document.createEvent("MouseEvents");
-click.initMouseEvent("click", true, true, window, 1, 0, 0, 0, 0, false, false, false, false, 0, document);
video.dispatchEvent(doubleClick);
[webkit-changes] [120387] trunk/LayoutTests
Title: [120387] trunk/LayoutTests Revision 120387 Author jia...@chromium.org Date 2012-06-14 18:45:44 -0700 (Thu, 14 Jun 2012) Log Message Unreviewed. Skip the failed test due to r120384 for future investigation. * platform/chromium/TestExpectations: * platform/efl/Skipped: * platform/gtk/TestExpectations: * platform/mac/Skipped: * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (120386 => 120387) --- trunk/LayoutTests/ChangeLog 2012-06-15 01:32:35 UTC (rev 120386) +++ trunk/LayoutTests/ChangeLog 2012-06-15 01:45:44 UTC (rev 120387) @@ -1,5 +1,15 @@ 2012-06-14 Jian Li +Unreviewed. Skip the failed test due to r120384 for future investigation. + +* platform/chromium/TestExpectations: +* platform/efl/Skipped: +* platform/gtk/TestExpectations: +* platform/mac/Skipped: +* platform/qt/Skipped: + +2012-06-14 Jian Li + FileReader is dysfunctional in documents with "null" origin string https://bugs.webkit.org/show_bug.cgi?id=78648 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120386 => 120387) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-15 01:32:35 UTC (rev 120386) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-15 01:45:44 UTC (rev 120387) @@ -3730,3 +3730,5 @@ BUGWK88856 : fast/events/constructors/speech-recognition-event-constructor.html = TEXT BUGCR132898 : http/tests/websocket/tests/hybi/workers/close.html = TEXT + +BUGWK89149 : http/tests/fileapi/create-blob-url-from-data-url.html = TEXT Modified: trunk/LayoutTests/platform/efl/Skipped (120386 => 120387) --- trunk/LayoutTests/platform/efl/Skipped 2012-06-15 01:32:35 UTC (rev 120386) +++ trunk/LayoutTests/platform/efl/Skipped 2012-06-15 01:45:44 UTC (rev 120387) @@ -1179,3 +1179,6 @@ # Fail until ENABLE_XHR_RESPONSE_BLOB is enabled after r120042 # https://bugs.webkit.org/show_bug.cgi?id=88859 http/tests/xmlhttprequest/response-blob-size.html + +# https://bugs.webkit.org/show_bug.cgi?id=89149 +http/tests/fileapi/create-blob-url-from-data-url.html Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120386 => 120387) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-15 01:32:35 UTC (rev 120386) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-15 01:45:44 UTC (rev 120387) @@ -1300,6 +1300,8 @@ BUGWK88138 : http/tests/media/video-buffered.html = TEXT +BUGWK89149 : http/tests/fileapi/create-blob-url-from-data-url.html = TEXT + // // End of Tests failing // Modified: trunk/LayoutTests/platform/mac/Skipped (120386 => 120387) --- trunk/LayoutTests/platform/mac/Skipped 2012-06-15 01:32:35 UTC (rev 120386) +++ trunk/LayoutTests/platform/mac/Skipped 2012-06-15 01:45:44 UTC (rev 120387) @@ -894,3 +894,6 @@ # Fail until ENABLE_XHR_RESPONSE_BLOB is enabled after r120042 # https://bugs.webkit.org/show_bug.cgi?id=88859 http/tests/xmlhttprequest/response-blob-size.html + +# https://bugs.webkit.org/show_bug.cgi?id=89149 +http/tests/fileapi/create-blob-url-from-data-url.html Modified: trunk/LayoutTests/platform/qt/Skipped (120386 => 120387) --- trunk/LayoutTests/platform/qt/Skipped 2012-06-15 01:32:35 UTC (rev 120386) +++ trunk/LayoutTests/platform/qt/Skipped 2012-06-15 01:45:44 UTC (rev 120387) @@ -2515,3 +2515,6 @@ # [Qt]REGRESSION(r120107): It made http/tests/xmlhttprequest/origin-exact-matching.html fails # https://bugs.webkit.org/show_bug.cgi?id=88913 http/tests/xmlhttprequest/origin-exact-matching.html + +# https://bugs.webkit.org/show_bug.cgi?id=89149 +http/tests/fileapi/create-blob-url-from-data-url.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120386] trunk/Tools
Title: [120386] trunk/Tools Revision 120386 Author commit-qu...@webkit.org Date 2012-06-14 18:32:35 -0700 (Thu, 14 Jun 2012) Log Message [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=88622 Patch by Dongwoo Im on 2012-06-14 Reviewed by Philippe Normand. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default. (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp Diff Modified: trunk/Tools/ChangeLog (120385 => 120386) --- trunk/Tools/ChangeLog 2012-06-15 01:26:01 UTC (rev 120385) +++ trunk/Tools/ChangeLog 2012-06-15 01:32:35 UTC (rev 120386) @@ -1,3 +1,13 @@ +2012-06-14 Dongwoo Im + +[EFL] [DRT] Reset the WebAudio setting on DumpRenderTree +https://bugs.webkit.org/show_bug.cgi?id=88622 + +Reviewed by Philippe Normand. + +* DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default. +(DumpRenderTreeChrome::resetDefaultsToConsistentValues): + 2012-06-14 Xianzhu Wang [Chromium-Android] Should retry a few times when failed to start DumpRenderTree Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (120385 => 120386) --- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-06-15 01:26:01 UTC (rev 120385) +++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-06-15 01:32:35 UTC (rev 120386) @@ -247,6 +247,7 @@ ewk_view_setting_enable_hyperlink_auditing_set(mainView(), EINA_FALSE); ewk_view_setting_include_links_in_focus_chain_set(mainView(), EINA_FALSE); ewk_view_setting_scripts_can_access_clipboard_set(mainView(), EINA_TRUE); +ewk_view_setting_web_audio_set(mainView(), EINA_FALSE); ewk_view_zoom_set(mainView(), 1.0, 0, 0); ewk_view_scale_set(mainView(), 1.0, 0, 0); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120385] trunk/Tools
Title: [120385] trunk/Tools
Revision 120385
Author wangxian...@chromium.org
Date 2012-06-14 18:26:01 -0700 (Thu, 14 Jun 2012)
Log Message
[Chromium-Android] Should retry a few times when failed to start DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=89124
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver._start_once):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
Diff
Modified: trunk/Tools/ChangeLog (120384 => 120385)
--- trunk/Tools/ChangeLog 2012-06-15 00:57:27 UTC (rev 120384)
+++ trunk/Tools/ChangeLog 2012-06-15 01:26:01 UTC (rev 120385)
@@ -1,3 +1,15 @@
+2012-06-14 Xianzhu Wang
+
+[Chromium-Android] Should retry a few times when failed to start DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=89124
+
+Reviewed by Dirk Pranke.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidDriver._start):
+(ChromiumAndroidDriver):
+(ChromiumAndroidDriver._start_once):
+
2012-06-14 Tony Gentilcore
Update webpagereplay to 1.1.2
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (120384 => 120385)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-06-15 00:57:27 UTC (rev 120384)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-06-15 01:26:01 UTC (rev 120385)
@@ -483,9 +483,23 @@
ChromiumAndroidDriver._started_driver = self
+retries = 0
+while not self._start_once(pixel_tests, per_test_args):
+_log.error('Failed to start DumpRenderTree application. Log:\n' + self._port._get_logcat())
+retries += 1
+if retries >= 3:
+raise AssertionError('Failed to start DumpRenderTree application multiple times. Give up.')
+self.stop()
+time.sleep(2)
+
+def _start_once(self, pixel_tests, per_test_args):
self._port._run_adb_command(['logcat', '-c'])
self._port._run_adb_command(['shell', 'echo'] + self.cmd_line(pixel_tests, per_test_args) + ['>', COMMAND_LINE_FILE])
-self._port._run_adb_command(['shell', 'am', 'start', '-n', DRT_ACTIVITY_FULL_NAME])
+start_result = self._port._run_adb_command(['shell', 'am', 'start', '-n', DRT_ACTIVITY_FULL_NAME])
+if start_result.find('Exception') != -1:
+_log.error('Failed to start DumpRenderTree application. Exception:\n' + start_result)
+return False
+
seconds = 0
while (not self._file_exists_on_device(self._in_fifo_path) or
not self._file_exists_on_device(self._out_fifo_path) or
@@ -493,8 +507,7 @@
time.sleep(1)
seconds += 1
if seconds >= DRT_START_STOP_TIMEOUT_SECS:
-_log.error('Failed to start DumpRenderTreeApplication. Log:\n' + self._port._get_logcat())
-raise AssertionError('Failed to start DumpRenderTree application.')
+return False
shell_cmd = self._port._adb_command + ['shell']
executive = self._port._executive
@@ -537,7 +550,7 @@
else:
# Inform the deadlock detector that the startup is successful without deadlock.
normal_startup_event.set()
-return
+return True
def run_test(self, driver_input):
driver_output = chromium.ChromiumDriver.run_test(self, driver_input)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120384] trunk
Title: [120384] trunk
Revision 120384
Author jia...@chromium.org
Date 2012-06-14 17:57:27 -0700 (Thu, 14 Jun 2012)
Log Message
FileReader is dysfunctional in documents with "null" origin string
https://bugs.webkit.org/show_bug.cgi?id=78648
Reviewed by Adam Barth.
Source/WebCore:
The fix is to keep in-memory map from blob URL to SecurityOrigin for the
unique origin case.
Test: fast/files/file-reader-file-url.html
* fileapi/Blob.cpp:
(WebCore::Blob::Blob):
* fileapi/BlobURL.cpp:
(WebCore::BlobURL::getOrigin): Return the origin string embeded in the blob URL.
(WebCore):
(WebCore::BlobURL::createBlobURL): Remove the check for null origin string since it is handled now.
* fileapi/BlobURL.h:
(BlobURL):
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore):
(WebCore::originMap): Thread-specific in-memory map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::registerBlobURL): Add the map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::unregisterBlobURL): Remove the map for the unregistered blob URL.
(WebCore::ThreadableBlobRegistry::cachedOrigin): Retrieve the origin associated with the blob URL.
* fileapi/ThreadableBlobRegistry.h:
(WebCore):
(ThreadableBlobRegistry):
* html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
* page/SecurityOrigin.cpp:
(WebCore::cachedOrigin): Return the cached origin for the blob URL if it exists.
(WebCore):
(WebCore::SecurityOrigin::create): Call cachedOrigin to get the cached origin first.
LayoutTests:
* fast/files/file-reader-file-url-expected.txt: Added.
* fast/files/file-reader-file-url.html: Added.
* fast/files/resources/file-reader-file-url-iframe.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/Blob.cpp
trunk/Source/WebCore/fileapi/BlobURL.cpp
trunk/Source/WebCore/fileapi/BlobURL.h
trunk/Source/WebCore/fileapi/FileReaderLoader.cpp
trunk/Source/WebCore/fileapi/ThreadableBlobRegistry.cpp
trunk/Source/WebCore/fileapi/ThreadableBlobRegistry.h
trunk/Source/WebCore/html/DOMURL.cpp
trunk/Source/WebCore/page/SecurityOrigin.cpp
Added Paths
trunk/LayoutTests/fast/files/file-reader-file-url-expected.txt
trunk/LayoutTests/fast/files/file-reader-file-url.html
trunk/LayoutTests/fast/files/resources/file-reader-file-url-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (120383 => 120384)
--- trunk/LayoutTests/ChangeLog 2012-06-15 00:56:38 UTC (rev 120383)
+++ trunk/LayoutTests/ChangeLog 2012-06-15 00:57:27 UTC (rev 120384)
@@ -1,3 +1,14 @@
+2012-06-14 Jian Li
+
+FileReader is dysfunctional in documents with "null" origin string
+https://bugs.webkit.org/show_bug.cgi?id=78648
+
+Reviewed by Adam Barth.
+
+* fast/files/file-reader-file-url-expected.txt: Added.
+* fast/files/file-reader-file-url.html: Added.
+* fast/files/resources/file-reader-file-url-iframe.html: Added.
+
2012-06-14 Mike West
Add test cases for header/footer elements' AXRoleDescription
Added: trunk/LayoutTests/fast/files/file-reader-file-url-expected.txt (0 => 120384)
--- trunk/LayoutTests/fast/files/file-reader-file-url-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/files/file-reader-file-url-expected.txt 2012-06-15 00:57:27 UTC (rev 120384)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 9: Received data: 0123456789
+
+Test that FileReader works under the file URL with file path separation enforced.
Added: trunk/LayoutTests/fast/files/file-reader-file-url.html (0 => 120384)
--- trunk/LayoutTests/fast/files/file-reader-file-url.html (rev 0)
+++ trunk/LayoutTests/fast/files/file-reader-file-url.html 2012-06-15 00:57:27 UTC (rev 120384)
@@ -0,0 +1,17 @@
+
+
+
+if (window.layoutTestController) {
+layoutTestController.setAllowUniversalAccessFromFileURLs(false);
+layoutTestController.setAllowFileAccessFromFileURLs(false);
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+
+
+
+Test that FileReader works under the file URL with file path separation enforced.
+
+
Added: trunk/LayoutTests/fast/files/resources/file-reader-file-url-iframe.html (0 => 120384)
--- trunk/LayoutTests/fast/files/resources/file-reader-file-url-iframe.html (rev 0)
+++ trunk/LayoutTests/fast/files/resources/file-reader-file-url-iframe.html 2012-06-15 00:57:27 UTC (rev 120384)
@@ -0,0 +1,25 @@
+
+
+
+function runTest()
+{
+var blob = new Blob(["0123456789"]);
+var reader = new FileReader();
+reader._onload_ = function(event) {
+console.log("Received data: " + event.target.result);
+}
+reader._onloadend_ = function() {
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+reader._onerror_ = function(event) {
+console.log("Received error event: " + event.target.error.code);
+};
+reader.readAsText
[webkit-changes] [120383] trunk/LayoutTests
Title: [120383] trunk/LayoutTests
Revision 120383
Author commit-qu...@webkit.org
Date 2012-06-14 17:56:38 -0700 (Thu, 14 Jun 2012)
Log Message
Add test cases for header/footer elements' AXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=88911
Header and footer elements change their accessibility roles depending
on the elements which contain them. Specifically, they are described
as "banner" or "footer" in the general case, and fall back to
generic "group" role descriptions when contained in either article or
section elements. This patch simply tests that existing behavior on
Mac.
Patch by Mike West on 2012-06-14
Reviewed by Chris Fleizach.
* platform/mac/accessibility/footer-expected.txt: Added.
* platform/mac/accessibility/footer.html: Added.
* platform/mac/accessibility/header-expected.txt: Added.
* platform/mac/accessibility/header.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/mac/accessibility/footer-expected.txt
trunk/LayoutTests/platform/mac/accessibility/footer.html
trunk/LayoutTests/platform/mac/accessibility/header-expected.txt
trunk/LayoutTests/platform/mac/accessibility/header.html
Diff
Modified: trunk/LayoutTests/ChangeLog (120382 => 120383)
--- trunk/LayoutTests/ChangeLog 2012-06-15 00:51:07 UTC (rev 120382)
+++ trunk/LayoutTests/ChangeLog 2012-06-15 00:56:38 UTC (rev 120383)
@@ -1,3 +1,22 @@
+2012-06-14 Mike West
+
+Add test cases for header/footer elements' AXRoleDescription
+https://bugs.webkit.org/show_bug.cgi?id=88911
+
+Header and footer elements change their accessibility roles depending
+on the elements which contain them. Specifically, they are described
+as "banner" or "footer" in the general case, and fall back to
+generic "group" role descriptions when contained in either article or
+section elements. This patch simply tests that existing behavior on
+Mac.
+
+Reviewed by Chris Fleizach.
+
+* platform/mac/accessibility/footer-expected.txt: Added.
+* platform/mac/accessibility/footer.html: Added.
+* platform/mac/accessibility/header-expected.txt: Added.
+* platform/mac/accessibility/header.html: Added.
+
2012-06-14 Ryosuke Niwa
Fix Chromium test expectation after r120371.
Added: trunk/LayoutTests/platform/mac/accessibility/footer-expected.txt (0 => 120383)
--- trunk/LayoutTests/platform/mac/accessibility/footer-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/footer-expected.txt 2012-06-15 00:56:38 UTC (rev 120383)
@@ -0,0 +1,13 @@
+PASS accessibilityController.focusedElement.role is "AXRole: AXGroup"
+PASS accessibilityController.focusedElement.roleDescription is "AXRoleDescription: footer"
+PASS accessibilityController.focusedElement.role is "AXRole: AXGroup"
+PASS accessibilityController.focusedElement.roleDescription is "AXRoleDescription: group"
+PASS accessibilityController.focusedElement.role is "AXRole: AXGroup"
+PASS accessibilityController.focusedElement.roleDescription is "AXRoleDescription: group"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+Footer outside section and article elements.
+Footer inside an article.
+Footer inside a section.
+
Added: trunk/LayoutTests/platform/mac/accessibility/footer.html (0 => 120383)
--- trunk/LayoutTests/platform/mac/accessibility/footer.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/footer.html 2012-06-15 00:56:38 UTC (rev 120383)
@@ -0,0 +1,36 @@
+
+
+
+
+
+
+Footer outside section and article elements.
+
+Footer inside an article.
+
+
+Footer inside a section.
+
+
+
+function log(str) {
+var result = document.querySelector('#result');
+result.appendChild(document.createTextNode(str));
+}
+
+function expectRole(expectedRole, expectedDescription, id) {
+if (!window.accessibilityController)
+return;
+var el = document.querySelector(id);
+el.focus();
+shouldBeEqualToString('accessibilityController.focusedElement.role', "AXRole: " + expectedRole);
+shouldBeEqualToString('accessibilityController.focusedElement.roleDescription', "AXRoleDescription: " + expectedDescription);
+}
+
+expectRole('AXGroup', 'footer', '#footer01');
+expectRole('AXGroup', 'group', '#footer02');
+expectRole('AXGroup', 'group', '#footer03');
+
+
+
+
Added: trunk/LayoutTests/platform/mac/accessibility/header-expected.txt (0 => 120383)
--- trunk/LayoutTests/platform/mac/accessibility/header-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/header-expected.txt 2012-06-15 00:56:38 UTC (rev 120383)
@@ -0,0 +1,13 @@
+PASS accessibilityController.focusedElement.role is "AXRole: AXGroup"
+PASS accessibilityController.focusedElement.roleD
[webkit-changes] [120382] trunk/Source/WebCore
Title: [120382] trunk/Source/WebCore Revision 120382 Author commit-qu...@webkit.org Date 2012-06-14 17:51:07 -0700 (Thu, 14 Jun 2012) Log Message [CMAKE] Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake https://bugs.webkit.org/show_bug.cgi?id=89015 Patch by Sudarsana Nagineni on 2012-06-14 Reviewed by Antonio Gomes. Include JSDeprecatedPeerConnectionCustom.cpp in UseJSC.cmake instead of CMakeLists.txt. No change in functionality so no new tests. * CMakeLists.txt: * UseJSC.cmake: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/UseJSC.cmake Diff Modified: trunk/Source/WebCore/CMakeLists.txt (120381 => 120382) --- trunk/Source/WebCore/CMakeLists.txt 2012-06-15 00:43:09 UTC (rev 120381) +++ trunk/Source/WebCore/CMakeLists.txt 2012-06-15 00:51:07 UTC (rev 120382) @@ -2489,7 +2489,6 @@ Modules/mediastream/UserMediaController.cpp Modules/mediastream/UserMediaRequest.cpp -bindings/js/JSDeprecatedPeerConnectionCustom.cpp platform/mediastream/IceCandidateDescriptor.cpp platform/mediastream/IceOptions.cpp platform/mediastream/MediaHints.cpp Modified: trunk/Source/WebCore/ChangeLog (120381 => 120382) --- trunk/Source/WebCore/ChangeLog 2012-06-15 00:43:09 UTC (rev 120381) +++ trunk/Source/WebCore/ChangeLog 2012-06-15 00:51:07 UTC (rev 120382) @@ -1,3 +1,18 @@ +2012-06-14 Sudarsana Nagineni + +[CMAKE] Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake +https://bugs.webkit.org/show_bug.cgi?id=89015 + +Reviewed by Antonio Gomes. + +Include JSDeprecatedPeerConnectionCustom.cpp in UseJSC.cmake +instead of CMakeLists.txt. + +No change in functionality so no new tests. + +* CMakeLists.txt: +* UseJSC.cmake: + 2012-06-14 Xianzhu Wang [Chromium] Add setAutoHint() and setUseBitmaps() in WebFontRendering Modified: trunk/Source/WebCore/UseJSC.cmake (120381 => 120382) --- trunk/Source/WebCore/UseJSC.cmake 2012-06-15 00:43:09 UTC (rev 120381) +++ trunk/Source/WebCore/UseJSC.cmake 2012-06-15 00:51:07 UTC (rev 120382) @@ -49,6 +49,7 @@ bindings/js/JSCoordinatesCustom.cpp bindings/js/JSCustomVoidCallback.cpp bindings/js/JSCustomXPathNSResolver.cpp +bindings/js/JSDeprecatedPeerConnectionCustom.cpp bindings/js/JSDictionary.cpp bindings/js/JSDOMBinding.cpp bindings/js/JSDOMFormDataCustom.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120381] trunk/Source/WebKit/chromium
Title: [120381] trunk/Source/WebKit/chromium
Revision 120381
Author commit-qu...@webkit.org
Date 2012-06-14 17:43:09 -0700 (Thu, 14 Jun 2012)
Log Message
[Chromium] Sub-pixel text rendering is incorrectly used for WebView with transparent background.
https://bugs.webkit.org/show_bug.cgi?id=89033
Patch by David Reveman on 2012-06-14
Reviewed by James Robinson.
Add canvas background argument to PageWidgetDelegate::paint and call
PlatformCanvasSkia::setDrawingToImageBuffer to ensure that sub-pixel
rendering is only used when WebView has opaque background.
* src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::paint):
* src/PageWidgetDelegate.h:
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::paint):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PageWidgetDelegate.cpp
trunk/Source/WebKit/chromium/src/PageWidgetDelegate.h
trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120380 => 120381)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-15 00:35:53 UTC (rev 120380)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-15 00:43:09 UTC (rev 120381)
@@ -1,3 +1,22 @@
+2012-06-14 David Reveman
+
+[Chromium] Sub-pixel text rendering is incorrectly used for WebView with transparent background.
+https://bugs.webkit.org/show_bug.cgi?id=89033
+
+Reviewed by James Robinson.
+
+Add canvas background argument to PageWidgetDelegate::paint and call
+PlatformCanvasSkia::setDrawingToImageBuffer to ensure that sub-pixel
+rendering is only used when WebView has opaque background.
+
+* src/PageWidgetDelegate.cpp:
+(WebKit::PageWidgetDelegate::paint):
+* src/PageWidgetDelegate.h:
+* src/WebPagePopupImpl.cpp:
+(WebKit::WebPagePopupImpl::paint):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::paint):
+
2012-06-14 Shawn Singh
[chromium] CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer failing in debug
Modified: trunk/Source/WebKit/chromium/src/PageWidgetDelegate.cpp (120380 => 120381)
--- trunk/Source/WebKit/chromium/src/PageWidgetDelegate.cpp 2012-06-15 00:35:53 UTC (rev 120380)
+++ trunk/Source/WebKit/chromium/src/PageWidgetDelegate.cpp 2012-06-15 00:43:09 UTC (rev 120381)
@@ -82,12 +82,13 @@
view->updateLayoutAndStyleIfNeededRecursive();
}
-void PageWidgetDelegate::paint(Page* page, PageOverlayList* overlays, WebCanvas* canvas, const WebRect& rect)
+void PageWidgetDelegate::paint(Page* page, PageOverlayList* overlays, WebCanvas* canvas, const WebRect& rect, CanvasBackground background)
{
if (rect.isEmpty())
return;
GraphicsContextBuilder builder(canvas);
GraphicsContext& gc = builder.context();
+gc.platformContext()->setDrawingToImageBuffer(background == Opaque ? false : true);
gc.applyDeviceScaleFactor(page->deviceScaleFactor());
IntRect dirtyRect(rect);
gc.save();
Modified: trunk/Source/WebKit/chromium/src/PageWidgetDelegate.h (120380 => 120381)
--- trunk/Source/WebKit/chromium/src/PageWidgetDelegate.h 2012-06-15 00:35:53 UTC (rev 120380)
+++ trunk/Source/WebKit/chromium/src/PageWidgetDelegate.h 2012-06-15 00:43:09 UTC (rev 120381)
@@ -73,9 +73,13 @@
// Common implementation of WebViewImpl and WebPagePopupImpl.
class PageWidgetDelegate {
public:
+enum CanvasBackground {
+Opaque,
+Translucent,
+};
static void animate(WebCore::Page*, double monotonicFrameBeginTime);
static void layout(WebCore::Page*);
-static void paint(WebCore::Page*, PageOverlayList*, WebCanvas*, const WebRect&);
+static void paint(WebCore::Page*, PageOverlayList*, WebCanvas*, const WebRect&, CanvasBackground);
static bool handleInputEvent(WebCore::Page*, PageWidgetEventHandler&, const WebInputEvent&);
private:
Modified: trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp (120380 => 120381)
--- trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp 2012-06-15 00:35:53 UTC (rev 120380)
+++ trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp 2012-06-15 00:43:09 UTC (rev 120381)
@@ -237,7 +237,7 @@
void WebPagePopupImpl::paint(WebCanvas* canvas, const WebRect& rect)
{
-PageWidgetDelegate::paint(m_page.get(), 0, canvas, rect);
+PageWidgetDelegate::paint(m_page.get(), 0, canvas, rect, PageWidgetDelegate::Opaque);
}
void WebPagePopupImpl::resize(const WebSize& newSize)
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (120380 => 120381)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-06-15 00:35:53 UTC (rev 120380)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-06-15 00:43:09 UTC (rev 120381)
@@ -1572,7 +1572,7 @@
#endif
} else {
double paintStart = currentTime();
-PageWidgetDelegate::paint(m_page.get(), pageOverlays(), canvas,
[webkit-changes] [120380] trunk/Source/WebKit/chromium
Title: [120380] trunk/Source/WebKit/chromium
Revision 120380
Author shawnsi...@chromium.org
Date 2012-06-14 17:35:53 -0700 (Thu, 14 Jun 2012)
Log Message
[chromium] CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer failing in debug
https://bugs.webkit.org/show_bug.cgi?id=89065
Reviewed by James Robinson.
A debug assertion was being triggered in the hit-testing unit
tests because I accidentally forgot to set the
DebugScopedSetImplThread for the tests.
This patch also re-enables the disabled broken test.
* tests/CCLayerTreeHostCommonTest.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120379 => 120380)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-15 00:12:40 UTC (rev 120379)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-15 00:35:53 UTC (rev 120380)
@@ -1,3 +1,18 @@
+2012-06-14 Shawn Singh
+
+[chromium] CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer failing in debug
+https://bugs.webkit.org/show_bug.cgi?id=89065
+
+Reviewed by James Robinson.
+
+A debug assertion was being triggered in the hit-testing unit
+tests because I accidentally forgot to set the
+DebugScopedSetImplThread for the tests.
+
+This patch also re-enables the disabled broken test.
+
+* tests/CCLayerTreeHostCommonTest.cpp:
+
2012-06-14 Xianzhu Wang
[Chromium] Add setAutoHint() and setUseBitmaps() in WebFontRendering
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp (120379 => 120380)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp 2012-06-15 00:12:40 UTC (rev 120379)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp 2012-06-15 00:35:53 UTC (rev 120380)
@@ -2913,6 +2913,7 @@
TEST(CCLayerTreeHostCommonTest, verifyHitTestingForEmptyLayerList)
{
// Hit testing on an empty renderSurfaceLayerList should return a null pointer.
+DebugScopedSetImplThread thisScopeIsOnImplThread;
Vector renderSurfaceLayerList;
@@ -2925,8 +2926,10 @@
EXPECT_FALSE(resultLayer);
}
-TEST(CCLayerTreeHostCommonTest, DISABLED_verifyHitTestingForSingleLayer)
+TEST(CCLayerTreeHostCommonTest, verifyHitTestingForSingleLayer)
{
+DebugScopedSetImplThread thisScopeIsOnImplThread;
+
OwnPtr root = CCLayerImpl::create(12345);
root->createRenderSurface();
root->renderSurface()->setContentRect(IntRect(IntPoint::zero(), IntSize(100, 100)));
@@ -3038,6 +3041,8 @@
TEST(CCLayerTreeHostCommonTest, verifyHitTestingForSinglePositionedLayer)
{
+DebugScopedSetImplThread thisScopeIsOnImplThread;
+
OwnPtr root = CCLayerImpl::create(12345);
root->createRenderSurface();
root->renderSurface()->setContentRect(IntRect(IntPoint::zero(), IntSize(100, 100)));
@@ -3084,6 +3089,8 @@
TEST(CCLayerTreeHostCommonTest, verifyHitTestingForSingleRotatedLayer)
{
+DebugScopedSetImplThread thisScopeIsOnImplThread;
+
OwnPtr root = CCLayerImpl::create(12345);
root->createRenderSurface();
root->renderSurface()->setContentRect(IntRect(IntPoint::zero(), IntSize(100, 100)));
@@ -3138,6 +3145,8 @@
TEST(CCLayerTreeHostCommonTest, verifyHitTestingForSinglePerspectiveLayer)
{
+DebugScopedSetImplThread thisScopeIsOnImplThread;
+
OwnPtr root = CCLayerImpl::create(12345);
root->createRenderSurface();
root->renderSurface()->setContentRect(IntRect(IntPoint::zero(), IntSize(100, 100)));
@@ -3204,6 +3213,7 @@
// contentsScale is ignored, then hit testing will mis-interpret the visibleLayerRect
// as being larger than the actual bounds of the layer.
//
+DebugScopedSetImplThread thisScopeIsOnImplThread;
OwnPtr root = CCLayerImpl::create(12345);
root->createRenderSurface();
@@ -3258,6 +3268,7 @@
{
// Test that hit-testing will only work for the visible portion of a layer, and not
// the entire layer bounds. Here we just test the simple axis-aligned case.
+DebugScopedSetImplThread thisScopeIsOnImplThread;
OwnPtr root = CCLayerImpl::create(123);
root->createRenderSurface();
@@ -3325,6 +3336,7 @@
// combined create a triangle. The rotatedLeaf will only be visible where it overlaps
// this triangle.
//
+DebugScopedSetImplThread thisScopeIsOnImplThread;
OwnPtr root = CCLayerImpl::create(123);
root->createRenderSurface();
@@ -3427,6 +3439,8 @@
TEST(CCLayerTreeHostCommonTest, verifyHitTestingForMultipleLayers)
{
+DebugScopedSetImplThread thisScopeIsOnImplThread;
+
OwnPtr root = CCLayerImpl::create(1);
root->createRenderSurface();
root->renderSurface()->setContentRect(IntRect(IntPoint::zero(), IntSize(100, 100)));
@@ -3535,6 +3549,7 @@
// The geometry is set up similarly to the previous case, but
// all layers are forced to be renderSurfaces now.
//
+DebugScopedSetImplThread th
[webkit-changes] [120379] trunk/Source
Title: [120379] trunk/Source
Revision 120379
Author wangxian...@chromium.org
Date 2012-06-14 17:12:40 -0700 (Thu, 14 Jun 2012)
Log Message
[Chromium] Add setAutoHint() and setUseBitmaps() in WebFontRendering
https://bugs.webkit.org/show_bug.cgi?id=89014
Reviewed by James Robinson.
Source/WebCore:
No new tests because of no change of functionality.
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore):
(WebCore::FontPlatformData::setAutoHint):
(WebCore::FontPlatformData::setUseBitmaps):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontPlatformData::setupPaint):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
Source/WebKit/chromium:
* public/linuxish/WebFontRendering.h:
(WebFontRendering):
* src/linuxish/WebFontRendering.cpp:
(WebKit):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/linuxish/WebFontRendering.h
trunk/Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120378 => 120379)
--- trunk/Source/WebCore/ChangeLog 2012-06-15 00:06:55 UTC (rev 120378)
+++ trunk/Source/WebCore/ChangeLog 2012-06-15 00:12:40 UTC (rev 120379)
@@ -1,3 +1,21 @@
+2012-06-14 Xianzhu Wang
+
+[Chromium] Add setAutoHint() and setUseBitmaps() in WebFontRendering
+https://bugs.webkit.org/show_bug.cgi?id=89014
+
+Reviewed by James Robinson.
+
+No new tests because of no change of functionality.
+
+* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
+(WebCore):
+(WebCore::FontPlatformData::setAutoHint):
+(WebCore::FontPlatformData::setUseBitmaps):
+(WebCore::FontPlatformData::setAntiAlias):
+(WebCore::FontPlatformData::setupPaint):
+* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
+(FontPlatformData):
+
2012-06-14 Ryuan Choi
[EFL] Move cursor related code from WidgetEfl to ewk_view and EflScreenUtilities.
Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp (120378 => 120379)
--- trunk/Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp 2012-06-15 00:06:55 UTC (rev 120378)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp 2012-06-15 00:12:40 UTC (rev 120379)
@@ -45,7 +45,9 @@
namespace WebCore {
static SkPaint::Hinting skiaHinting = SkPaint::kNormal_Hinting;
-static bool isSkiaAntiAlias = true;
+static bool useSkiaAutoHint = true;
+static bool useSkiaBitmaps = true;
+static bool useSkiaAntiAlias = true;
static bool useSkiaSubpixelRendering = false;
static bool useSkiaSubpixelPositioning = false;
@@ -54,11 +56,21 @@
skiaHinting = hinting;
}
-void FontPlatformData::setAntiAlias(bool isAntiAlias)
+void FontPlatformData::setAutoHint(bool useAutoHint)
{
-isSkiaAntiAlias = isAntiAlias;
+useSkiaAutoHint = useAutoHint;
}
+void FontPlatformData::setUseBitmaps(bool useBitmaps)
+{
+useSkiaBitmaps = useBitmaps;
+}
+
+void FontPlatformData::setAntiAlias(bool useAntiAlias)
+{
+useSkiaAntiAlias = useAntiAlias;
+}
+
void FontPlatformData::setSubpixelRendering(bool useSubpixelRendering)
{
useSkiaSubpixelRendering = useSubpixelRendering;
@@ -165,7 +177,7 @@
{
const float ts = m_textSize >= 0 ? m_textSize : 12;
-paint->setAntiAlias(m_style.useAntiAlias == FontRenderStyle::NoPreference ? isSkiaAntiAlias : m_style.useAntiAlias);
+paint->setAntiAlias(m_style.useAntiAlias == FontRenderStyle::NoPreference ? useSkiaAntiAlias : m_style.useAntiAlias);
switch (m_style.useHinting) {
case FontRenderStyle::NoPreference:
paint->setHinting(skiaHinting);
@@ -178,15 +190,15 @@
break;
}
-paint->setEmbeddedBitmapText(m_style.useBitmaps);
+paint->setEmbeddedBitmapText(m_style.useBitmaps == FontRenderStyle::NoPreference ? useSkiaBitmaps : m_style.useBitmaps);
paint->setTextSize(SkFloatToScalar(ts));
paint->setTypeface(m_typeface);
paint->setFakeBoldText(m_fakeBold);
paint->setTextSkewX(m_fakeItalic ? -SK_Scalar1 / 4 : 0);
-paint->setAutohinted(m_style.useAutoHint);
+paint->setAutohinted(m_style.useAutoHint == FontRenderStyle::NoPreference ? useSkiaAutoHint : m_style.useAutoHint);
paint->setSubpixelText(m_style.useSubpixelPositioning == FontRenderStyle::NoPreference ? useSkiaSubpixelPositioning : m_style.useSubpixelPositioning);
-if (m_style.useAntiAlias == 1 || (m_style.useAntiAlias == FontRenderStyle::NoPreference && isSkiaAntiAlias))
+if (m_style.useAntiAlias == 1 || (m_style.useAntiAlias == FontRenderStyle::NoPreference && useSkiaAntiAlias))
[webkit-changes] [120378] branches/safari-536-branch/Source/WebCore
Title: [120378] branches/safari-536-branch/Source/WebCore
Revision 120378
Author lforsch...@apple.com
Date 2012-06-14 17:06:55 -0700 (Thu, 14 Jun 2012)
Log Message
Merged r120364 ->
Modified Paths
branches/safari-536-branch/Source/WebCore/ChangeLog
branches/safari-536-branch/Source/WebCore/loader/icon/IconDatabase.cpp
Diff
Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (120377 => 120378)
--- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-06-15 00:03:51 UTC (rev 120377)
+++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-06-15 00:06:55 UTC (rev 120378)
@@ -1,5 +1,26 @@
2012-06-12 Lucas Forschler
+Merge 120364
+
+2012-06-14 Andreas Kling
+
+Crashes below IconDatabase::performPendingRetainAndReleaseOperations().
+
+
+
+Reviewed by Brady Eidson.
+
+Put isolatedCopy() strings in the retain/release operation queues to make sure it's safe
+for secondary threads to ref/deref them in performPendingRetainAndReleaseOperations().
+Also added assertions as appropriate.
+
+* loader/icon/IconDatabase.cpp:
+(WebCore::IconDatabase::retainIconForPageURL):
+(WebCore::IconDatabase::releaseIconForPageURL):
+(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):
+
+2012-06-12 Lucas Forschler
+
Merge 120357
2012-06-14 Jia Pu
Modified: branches/safari-536-branch/Source/WebCore/loader/icon/IconDatabase.cpp (120377 => 120378)
--- branches/safari-536-branch/Source/WebCore/loader/icon/IconDatabase.cpp 2012-06-15 00:03:51 UTC (rev 120377)
+++ branches/safari-536-branch/Source/WebCore/loader/icon/IconDatabase.cpp 2012-06-15 00:06:55 UTC (rev 120378)
@@ -400,7 +400,7 @@
{
MutexLocker locker(m_urlsToRetainOrReleaseLock);
-m_urlsToRetain.add(pageURL);
+m_urlsToRetain.add(pageURL.isolatedCopy());
m_retainOrReleaseIconRequested = true;
}
@@ -453,7 +453,7 @@
{
MutexLocker locker(m_urlsToRetainOrReleaseLock);
-m_urlsToRelease.add(pageURL);
+m_urlsToRelease.add(pageURL.isolatedCopy());
m_retainOrReleaseIconRequested = true;
}
scheduleOrDeferSyncTimer();
@@ -1528,10 +1528,15 @@
m_retainOrReleaseIconRequested = false;
}
-for (HashCountedSet::const_iterator it = toRetain.begin(), end = toRetain.end(); it != end; ++it)
+for (HashCountedSet::const_iterator it = toRetain.begin(), end = toRetain.end(); it != end; ++it) {
+ASSERT(!it->first.impl() || it->first.impl()->hasOneRef());
performRetainIconForPageURL(it->first, it->second);
-for (HashCountedSet::const_iterator it = toRelease.begin(), end = toRelease.end(); it != end; ++it)
+}
+
+for (HashCountedSet::const_iterator it = toRelease.begin(), end = toRelease.end(); it != end; ++it) {
+ASSERT(!it->first.impl() || it->first.impl()->hasOneRef());
performReleaseIconForPageURL(it->first, it->second);
+}
}
bool IconDatabase::readFromDatabase()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120377] branches/safari-536-branch/Source/WebKit2
Title: [120377] branches/safari-536-branch/Source/WebKit2 Revision 120377 Author lforsch...@apple.com Date 2012-06-14 17:03:51 -0700 (Thu, 14 Jun 2012) Log Message Merged r120329 -> Modified Paths branches/safari-536-branch/Source/WebKit2/ChangeLog branches/safari-536-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: branches/safari-536-branch/Source/WebKit2/ChangeLog (120376 => 120377) --- branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-06-15 00:03:44 UTC (rev 120376) +++ branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-06-15 00:03:51 UTC (rev 120377) @@ -1,5 +1,29 @@ 2012-06-12 Lucas Forschler +Merge 120329 + +2012-06-13 Andreas Kling + +Chinese IM receives incorrect/duplicated key events in text fields in webpages in Safari. + + + +Reviewed by Darin Adler. + +Send the DidReceiveEvent message with the DispatchMessageEvenWhenWaitingForSyncReply flag +for keyboard events. This ensures that it always arrives before the corresponding synchronous +InterpretQueuedKeyEvent message. + +The problem was that we relied on DidReceiveEvent / InterpretQueuedKeyEvent always arriving in +the same order they were sent. This was not always true, since DidReceiveEvent (async) would +get deferred during an unrelated waitForSyncReply() whereas InterpretQueuedKeyEvent (sync) +gets dispatched right away. + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::keyEvent): + +2012-06-12 Lucas Forschler + Merge 120357 2012-06-14 Jia Pu Modified: branches/safari-536-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (120376 => 120377) --- branches/safari-536-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-06-15 00:03:44 UTC (rev 120376) +++ branches/safari-536-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-06-15 00:03:51 UTC (rev 120377) @@ -1411,7 +1411,9 @@ if (!handled) handled = performDefaultBehaviorForKeyEvent(keyboardEvent); -send(Messages::WebPageProxy::DidReceiveEvent(static_cast(keyboardEvent.type()), handled)); +// The receiving end relies on DidReceiveEvent and InterpretQueuedKeyEvent arriving in the same order they are sent +// (for keyboard events.) We set the DispatchMessageEvenWhenWaitingForSyncReply flag to ensure consistent ordering. +connection()->send(Messages::WebPageProxy::DidReceiveEvent(static_cast(keyboardEvent.type()), handled), m_pageID, CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply); } void WebPage::keyEventSyncForTesting(const WebKeyboardEvent& keyboardEvent, bool& handled) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120376] trunk/Source/WebKit2
Title: [120376] trunk/Source/WebKit2 Revision 120376 Author timothy_hor...@apple.com Date 2012-06-14 17:03:44 -0700 (Thu, 14 Jun 2012) Log Message DrawingArea: Painting is being resumed while the view is not visible https://bugs.webkit.org/show_bug.cgi?id=88940 Reviewed by Dean Jackson. Using requestAnimationFrame and the fullscreen API on a DrawingArea-backed window would cause rAF to permanently suspend animations after entering full-screen mode, because of the following: 0. _javascript_ causes fullscreen transition to start. 1. Painting (and rAF) are suspended. 2. The page changes size. a. DrawingAreaProxyImpl::sizeDidChange() calls DrawingAreaImpl::updateBackingStoreState, which calls DrawingAreaImpl::resumePainting. b. DrawingAreaImpl::resumePainting resumes painting, but does *not* resume rAF, because windowIsVisible is (legitimately) false. 3. The view becomes visible, windowIsVisible is updated to true. 4. visibilityDidChange() calls resumePainting again, but this time it early exits because painting is not suspended. Notice that because of the early exit in 4, rAF is never resumed. To solve this and prevent any further bugs caused by these unnecessary calls to resume/suspendPainting, temporarily stop sending SuspendPainting/ResumePainting messages from DrawingAreaProxyImpl::visibilityDidChange during the window animations that occur while entering and exiting full-screen. * UIProcess/API/mac/WKViewInternal.h: * UIProcess/API/mac/WKView.mm: (-[WKView setAutomaticallySuspendAndResumePainting:]): (-[WKView automaticallySuspendAndResumePainting]): * UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::visibilityDidChange): * UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::setShouldSuspendAndResumePainting): (WebKit::WebPageProxy::shouldSuspendAndResumePainting): * UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): (-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (120375 => 120376) --- trunk/Source/WebKit2/ChangeLog 2012-06-14 23:59:44 UTC (rev 120375) +++ trunk/Source/WebKit2/ChangeLog 2012-06-15 00:03:44 UTC (rev 120376) @@ -1,3 +1,41 @@ +2012-06-14 Tim Horton + +DrawingArea: Painting is being resumed while the view is not visible +https://bugs.webkit.org/show_bug.cgi?id=88940 + + +Reviewed by Dean Jackson. + +Using requestAnimationFrame and the fullscreen API on a DrawingArea-backed window would cause +rAF to permanently suspend animations after entering full-screen mode, because of the following: + +0. _javascript_ causes fullscreen transition to start. +1. Painting (and rAF) are suspended. +2. The page changes size. +a. DrawingAreaProxyImpl::sizeDidChange() calls DrawingAreaImpl::updateBackingStoreState, which calls DrawingAreaImpl::resumePainting. +b. DrawingAreaImpl::resumePainting resumes painting, but does *not* resume rAF, because windowIsVisible is (legitimately) false. +3. The view becomes visible, windowIsVisible is updated to true. +4. visibilityDidChange() calls resumePainting again, but this time it early exits because painting is not suspended. + +Notice that because of the early exit in 4, rAF is never resumed. + +To solve this and prevent any further bugs caused by these unnecessary calls to resume/suspendPainting, +temporarily stop sending SuspendPainting/ResumePainting messages from DrawingAreaProxyImpl::visibilityDidChange +during the window animations that occur while entering and exiting full-screen. + +* UIProcess/API/mac/WKViewInternal.h: +* UIProcess/API/mac/WKView.mm: +(-[WKView setAutomaticallySuspendAndResumePainting:]): +(-[WKView automaticallySuspendAndResumePainting]): +* UIProcess/DrawingAreaProxyImpl.cpp: +(WebKit::DrawingAreaProxyImpl::visibilityDidChange): +* UIProcess/WebPageProxy.h: +(WebKit::WebPageProxy::setShouldSuspendAndResumePainting): +(WebKit::WebPageProxy::shouldSuspendAndResumePainting): +* UIProcess/mac/WKFullScreenWindowController.mm: +(-[WKFullScreenWindowController enterFullScreen:]): +(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): + 2012-06-14 Jia Pu Mark text with text alternative with blue underline. Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (120375 => 120376) --- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2
[webkit-changes] [120375] trunk/LayoutTests
Title: [120375] trunk/LayoutTests Revision 120375 Author rn...@webkit.org Date 2012-06-14 16:59:44 -0700 (Thu, 14 Jun 2012) Log Message Fix Chromium test expectation after r120371. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120374 => 120375) --- trunk/LayoutTests/ChangeLog 2012-06-14 23:54:03 UTC (rev 120374) +++ trunk/LayoutTests/ChangeLog 2012-06-14 23:59:44 UTC (rev 120375) @@ -1,3 +1,9 @@ +2012-06-14 Ryosuke Niwa + +Fix Chromium test expectation after r120371. + +* platform/chromium/TestExpectations: + 2012-06-14 Andrew Wilson Unreviewed update of chromium TestExpectations to mark hybi/workers/close.html as failing. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120374 => 120375) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-14 23:54:03 UTC (rev 120374) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-14 23:59:44 UTC (rev 120375) @@ -2988,24 +2988,24 @@ BUGWK83882 : media/track/track-mode.html = PASS TEXT TIMEOUT // Need rebaseline. -BUGWK87683 : fast/layers/video-layer.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : fullscreen/full-screen-stacking-context.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/audio-controls-rendering.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/audio-repaint.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/controls-after-reload.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/controls-layout-direction.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/controls-strict.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/controls-styling.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/controls-without-preload.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/media-controls-clone.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/media-document-audio-repaint.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/video-controls-rendering.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/video-display-toggle.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/video-empty-source.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/video-no-audio.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/video-playing-and-pause.html = TEXT IMAGE TEXT+IMAGE -BUGWK87683 : media/video-zoom-controls.html = TEXT IMAGE TEXT+IMAGE -BUGWK87835 : http/tests/media/video-buffered-range-contains-currentTime.html = TEXT IMAGE TEXT+IMAGE +BUGWK87683 : fast/layers/video-layer.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : fullscreen/full-screen-stacking-context.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/audio-controls-rendering.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/audio-repaint.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/controls-after-reload.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/controls-layout-direction.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/controls-strict.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/controls-styling.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/controls-without-preload.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/media-controls-clone.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/media-document-audio-repaint.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/video-controls-rendering.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/video-display-toggle.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/video-empty-source.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/video-no-audio.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/video-playing-and-pause.html = TEXT IMAGE IMAGE+TEXT +BUGWK87683 : media/video-zoom-controls.html = TEXT IMAGE IMAGE+TEXT +BUGWK87835 : http/tests/media/video-buffered-range-contains-currentTime.html = TEXT IMAGE IMAGE+TEXT BUGWK72271 SNOWLEOPARD DEBUG : fast/dom/node-iterator-reference-node-moved-crash.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120374] trunk/Tools
Title: [120374] trunk/Tools
Revision 120374
Author to...@chromium.org
Date 2012-06-14 16:54:03 -0700 (Thu, 14 Jun 2012)
Log Message
Update webpagereplay to 1.1.2
https://bugs.webkit.org/show_bug.cgi?id=89118
This includes the following patch which avoids pkg_resources import errors:
http://code.google.com/p/web-page-replay/source/detail?r=476
Reviewed by Dirk Pranke.
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._install_webpagereplay):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py
Diff
Modified: trunk/Tools/ChangeLog (120373 => 120374)
--- trunk/Tools/ChangeLog 2012-06-14 23:53:33 UTC (rev 120373)
+++ trunk/Tools/ChangeLog 2012-06-14 23:54:03 UTC (rev 120374)
@@ -1,3 +1,16 @@
+2012-06-14 Tony Gentilcore
+
+Update webpagereplay to 1.1.2
+https://bugs.webkit.org/show_bug.cgi?id=89118
+
+This includes the following patch which avoids pkg_resources import errors:
+http://code.google.com/p/web-page-replay/source/detail?r=476
+
+Reviewed by Dirk Pranke.
+
+* Scripts/webkitpy/thirdparty/__init__.py:
+(AutoinstallImportHook._install_webpagereplay):
+
2012-06-14 Ryosuke Niwa
Get rid of FAIL test expectation
Modified: trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py (120373 => 120374)
--- trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py 2012-06-14 23:53:33 UTC (rev 120373)
+++ trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py 2012-06-14 23:54:03 UTC (rev 120374)
@@ -135,8 +135,8 @@
def _install_webpagereplay(self):
if not self._fs.exists(self._fs.join(_AUTOINSTALLED_DIR, "webpagereplay")):
-self._install("http://web-page-replay.googlecode.com/files/webpagereplay-1.1.1.tar.gz", "webpagereplay-1.1.1")
-self._fs.move(self._fs.join(_AUTOINSTALLED_DIR, "webpagereplay-1.1.1"), self._fs.join(_AUTOINSTALLED_DIR, "webpagereplay"))
+self._install("http://web-page-replay.googlecode.com/files/webpagereplay-1.1.2.tar.gz", "webpagereplay-1.1.2")
+self._fs.move(self._fs.join(_AUTOINSTALLED_DIR, "webpagereplay-1.1.2"), self._fs.join(_AUTOINSTALLED_DIR, "webpagereplay"))
init_path = self._fs.join(_AUTOINSTALLED_DIR, "webpagereplay", "__init__.py")
if not self._fs.exists(init_path):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120373] trunk/Source/WebKit/blackberry
Title: [120373] trunk/Source/WebKit/blackberry
Revision 120373
Author commit-qu...@webkit.org
Date 2012-06-14 16:53:33 -0700 (Thu, 14 Jun 2012)
Log Message
Always convert touch events to mouse events if the
meta-tag TouchEventMode::PureWithMouseConversion is set.
Minor style fix.
https://bugs.webkit.org/show_bug.cgi?id=89115
Patch by Genevieve Mak on 2012-06-14
Reviewed by Antonio Gomes.
Reviewed Internally by Antonio Gomes.
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (120372 => 120373)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-14 23:39:12 UTC (rev 120372)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-14 23:53:33 UTC (rev 120373)
@@ -1,3 +1,18 @@
+2012-06-14 Genevieve Mak
+
+Always convert touch events to mouse events if the
+meta-tag TouchEventMode::PureWithMouseConversion is set.
+Minor style fix.
+https://bugs.webkit.org/show_bug.cgi?id=89115
+
+Reviewed by Antonio Gomes.
+
+Reviewed Internally by Antonio Gomes.
+
+* WebKitSupport/TouchEventHandler.cpp:
+(BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
+(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
+
2012-06-14 Chris Guan
[Blackberry] add a new Api named setAllowNotification
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp (120372 => 120373)
--- trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-06-14 23:39:12 UTC (rev 120372)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-06-14 23:53:33 UTC (rev 120373)
@@ -126,11 +126,11 @@
{
m_webPage->m_inputHandler->processPendingKeyboardVisibilityChange();
-if (!shouldSuppressMouseDownOnTouchDown()) {
-// Input elements delay mouse down and do not need to be released on touch cancel.
+// Input elements delay mouse down and do not need to be released on touch cancel.
+if (!shouldSuppressMouseDownOnTouchDown())
m_webPage->m_page->focusController()->focusedOrMainFrame()->eventHandler()->setMousePressed(false);
-}
-m_convertTouchToMouse = false;
+
+m_convertTouchToMouse = m_webPage->m_touchEventMode == PureTouchEventsWithMouseConversion;
m_didCancelTouch = true;
// If we cancel a single touch event, we need to also clean up any hover
@@ -172,6 +172,7 @@
{
// Enable input mode on any touch event.
m_webPage->m_inputHandler->enableInputMode();
+bool pureWithMouseConversion = m_webPage->m_touchEventMode == PureTouchEventsWithMouseConversion;
switch (point.m_state) {
case Platform::TouchPoint::TouchPressed:
@@ -192,7 +193,7 @@
// Set or reset the touch mode.
Element* possibleTargetNodeForMouseMoveEvents = static_cast(m_lastFatFingersResult.positionWasAdjusted() ? elementUnderFatFinger : m_lastFatFingersResult.node());
-m_convertTouchToMouse = shouldConvertTouchToMouse(possibleTargetNodeForMouseMoveEvents);
+m_convertTouchToMouse = pureWithMouseConversion ? true : shouldConvertTouchToMouse(possibleTargetNodeForMouseMoveEvents);
if (elementUnderFatFinger)
drawTapHighlight();
@@ -230,7 +231,7 @@
IntPoint adjustedPoint;
if (m_convertTouchToMouse) {
adjustedPoint = point.m_pos;
-m_convertTouchToMouse = false;
+m_convertTouchToMouse = pureWithMouseConversion;
} else // Fat finger point in viewport coordinates.
adjustedPoint = m_webPage->mapFromContentsToViewport(m_lastFatFingersResult.adjustedPosition());
@@ -249,7 +250,7 @@
PlatformMouseEvent mouseEvent(point.m_pos, m_lastScreenPoint, PlatformEvent::MouseMoved, 1, LeftButton, TouchScreen);
m_lastScreenPoint = point.m_screenPos;
if (!m_webPage->handleMouseEvent(mouseEvent)) {
-m_convertTouchToMouse = false;
+m_convertTouchToMouse = pureWithMouseConversion;
return false;
}
return true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120372] trunk/LayoutTests
Title: [120372] trunk/LayoutTests Revision 120372 Author atwil...@chromium.org Date 2012-06-14 16:39:12 -0700 (Thu, 14 Jun 2012) Log Message Unreviewed update of chromium TestExpectations to mark hybi/workers/close.html as failing. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120371 => 120372) --- trunk/LayoutTests/ChangeLog 2012-06-14 23:28:33 UTC (rev 120371) +++ trunk/LayoutTests/ChangeLog 2012-06-14 23:39:12 UTC (rev 120372) @@ -1,3 +1,9 @@ +2012-06-14 Andrew Wilson + +Unreviewed update of chromium TestExpectations to mark hybi/workers/close.html as failing. + +* platform/chromium/TestExpectations: + 2012-06-14 Ryosuke Niwa Get rid of FAIL test expectation Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120371 => 120372) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-14 23:28:33 UTC (rev 120371) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-14 23:39:12 UTC (rev 120372) @@ -3729,4 +3729,4 @@ BUGWK88856 : fast/events/constructors/speech-recognition-event-constructor.html = TEXT -// Need rebaselining because of text gradient fill rendering fix. +BUGCR132898 : http/tests/websocket/tests/hybi/workers/close.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120371] trunk
Title: [120371] trunk Revision 120371 Author rn...@webkit.org Date 2012-06-14 16:28:33 -0700 (Thu, 14 Jun 2012) Log Message Get rid of FAIL test expectation https://bugs.webkit.org/show_bug.cgi?id=89137 Reviewed by Dirk Pranke. Tools: * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ResultSummaryTest.test_summarized_results_wontfix): * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: (JSONLayoutResultsGenerator): * Scripts/webkitpy/layout_tests/models/test_expectations.py: (result_was_expected): (suffixes_for_expectations): (TestExpectationsModel._add_test): (TestExpectations): (TestExpectations.get_rebaselining_failures): (TestExpectations.remove_configuration_from_test): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (FunctionsTest.test_result_was_expected): (FunctionsTest.test_suffixes_for_expectations): (TestExpectationSerializerTests.test_parsed_expectations_string): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (test_test_expectations): * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: (TestExpectationsTestCase.test_valid_expectations): LayoutTests: * platform/chromium/TestExpectations: * platform/efl/TestExpectations: * platform/mac/TestExpectations: * platform/qt/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/qt/TestExpectations trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py Diff Modified: trunk/LayoutTests/ChangeLog (120370 => 120371) --- trunk/LayoutTests/ChangeLog 2012-06-14 23:18:09 UTC (rev 120370) +++ trunk/LayoutTests/ChangeLog 2012-06-14 23:28:33 UTC (rev 120371) @@ -1,5 +1,17 @@ 2012-06-14 Ryosuke Niwa +Get rid of FAIL test expectation +https://bugs.webkit.org/show_bug.cgi?id=89137 + +Reviewed by Dirk Pranke. + +* platform/chromium/TestExpectations: +* platform/efl/TestExpectations: +* platform/mac/TestExpectations: +* platform/qt/TestExpectations: + +2012-06-14 Ryosuke Niwa + Radio node lists do not get updated when inserted back into a document https://bugs.webkit.org/show_bug.cgi?id=88825 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120370 => 120371) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-14 23:18:09 UTC (rev 120370) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-14 23:28:33 UTC (rev 120371) @@ -156,7 +156,7 @@ BUGWK85580 SKIP : fast/css/variables = PASS // CSS image-resolution is not yet enabled. -BUGWK85262 SKIP : fast/css/image-resolution = PASS FAIL +BUGWK85262 SKIP : fast/css/image-resolution = PASS // Chromium needs larger media files to test buffering this way. BUGWK88172 SKIP : http/tests/media/video-buffered.html = PASS @@ -465,7 +465,7 @@ // These tests are based on the JSC _javascript_ profiler. The V8 _javascript_ // profiler is in development and will use a different approach than JSC and // most likely these tests will always be JSC specific. -WONTFIX SKIP : fast/profiler = FAIL TIMEOUT +WONTFIX SKIP : fast/profiler = PASS // StorageTracker isn't used by Chromium and not all requisite platform code // is implemented. @@ -775,9 +775,9 @@ WONTFIX SKIP : media/video-does-not-loop.html = TIMEOUT // Doesn't apply to Chromium any longer - volume slider is inline with video controls. -WONTFIX SKIP : media/video-volume-slider.html = FAIL -WONTFIX SKIP : media/media-volume-slider-rendered-below.html = FAIL -WONTFIX SKIP : media/media-volume-slider-rendered-normal.html = FAIL +WONTFIX SKIP : media/video-volume-slider.html = PASS +WONTFIX SKIP : media/media-volume-slider-rendered-below.html = PASS +WONTFIX SKIP : media/media-volume-slider-rendered-normal.html = PASS // QuickTime reference movies not supported. WONTFIX SKIP : http/tests/media/video-cross-site.html = PASS @@ -2988,24 +2988,24 @@ BUGWK83882 : media/track/track-mode.html = PASS TEXT TIMEOUT // Need rebaseline. -BUGWK87683 : fast/layers/video-layer.html = FAIL -BUGWK87683 : fullscreen/full-screen-stacking-context.html = FAIL -BUGWK87683 : media/audio-controls-rendering.html = FAIL -BUGWK87683 : media/audio-repaint.html = FAIL -BUGWK87683 : media/control
[webkit-changes] [120370] trunk/Tools
Title: [120370] trunk/Tools Revision 120370 Author dpra...@chromium.org Date 2012-06-14 16:18:09 -0700 (Thu, 14 Jun 2012) Log Message webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default() https://bugs.webkit.org/show_bug.cgi?id=89135 Reviewed by Ryosuke Niwa. This patch is just some minor cleanup and simplification. There should be no functional changes here. * Scripts/webkitpy/layout_tests/port/base.py: (Port.__init__): (Port.get_option): (Port.set_option_default): * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: (ChromiumWinTest.test_setup_environ_for_server_register_cygwin): * Scripts/webkitpy/style/checkers/test_expectations.py: (TestExpectationsChecker._determine_port_from_expectations_path): * Scripts/webkitpy/tool/mocktool.py: (MockOptions.ensure_value): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations.py trunk/Tools/Scripts/webkitpy/tool/mocktool.py Diff Modified: trunk/Tools/ChangeLog (120369 => 120370) --- trunk/Tools/ChangeLog 2012-06-14 23:09:44 UTC (rev 120369) +++ trunk/Tools/ChangeLog 2012-06-14 23:18:09 UTC (rev 120370) @@ -1,3 +1,24 @@ +2012-06-14 Dirk Pranke + +webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default() +https://bugs.webkit.org/show_bug.cgi?id=89135 + +Reviewed by Ryosuke Niwa. + +This patch is just some minor cleanup and simplification. There +should be no functional changes here. + +* Scripts/webkitpy/layout_tests/port/base.py: +(Port.__init__): +(Port.get_option): +(Port.set_option_default): +* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: +(ChromiumWinTest.test_setup_environ_for_server_register_cygwin): +* Scripts/webkitpy/style/checkers/test_expectations.py: +(TestExpectationsChecker._determine_port_from_expectations_path): +* Scripts/webkitpy/tool/mocktool.py: +(MockOptions.ensure_value): + 2012-06-14 Ian Vollick [chromium] Certain settings in CCSettings could be global Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (120369 => 120370) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-06-14 23:09:44 UTC (rev 120369) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-06-14 23:18:09 UTC (rev 120370) @@ -34,6 +34,7 @@ import difflib import errno import os +import optparse import re try: @@ -61,19 +62,6 @@ _log = logutils.get_logger(__file__) -class DummyOptions(object): -"""Fake implementation of optparse.Values. Cloned from webkitpy.tool.mocktool.MockOptions.""" - -def __init__(self, *args, **kwargs): -# The caller can set option values using keyword arguments. We don't -# set any values by default because we don't know how this -# object will be used. Generally speaking unit tests should -# subclass this or provider wrapper functions that set a common -# set of options. -for key, value in kwargs.items(): -self.__dict__[key] = value - - # FIXME: This class should merge with WebKitPort now that Chromium behaves mostly like other webkit ports. class Port(object): """Abstract class for Port-specific hooks for the layout_test package.""" @@ -111,7 +99,7 @@ # FIXME: Ideally we'd have a package-wide way to get a # well-formed options object that had all of the necessary # options defined on it. -self._options = options or DummyOptions() +self._options = options or optparse.Values() self.host = host self._executive = host.executive @@ -678,18 +666,10 @@ return self._architecture def get_option(self, name, default_value=None): -# FIXME: Eventually we should not have to do a test for -# hasattr(), and we should be able to just do -# self.options.value. See additional FIXME in the constructor. -if hasattr(self._options, name): -return getattr(self._options, name) -return default_value +return getattr(self._options, name, default_value) def set_option_default(self, name, default_value): -# FIXME: Callers could also use optparse_parser.Values.ensure_value, -# since this should always be a optparse_parser.Values object. -if not hasattr(self._options, name) or getattr(self._options, name) is None: -return setattr(self._options, name, default_value) +return self._options.ensure_value(name, default_value) def path_from_webkit_base(self, *comps): """Returns the full path to path made by joining the top of the Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py (120369 =>
[webkit-changes] [120368] trunk/Source/WTF
Title: [120368] trunk/Source/WTF
Revision 120368
Author commit-qu...@webkit.org
Date 2012-06-14 16:00:02 -0700 (Thu, 14 Jun 2012)
Log Message
[BlackBerry] Implement computeRAMSize for QNX
https://bugs.webkit.org/show_bug.cgi?id=89110
Patch by Yong Li on 2012-06-14
Reviewed by Rob Buis.
* wtf/RAMSize.cpp:
(WTF::computeRAMSize):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/RAMSize.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (120367 => 120368)
--- trunk/Source/WTF/ChangeLog 2012-06-14 22:38:41 UTC (rev 120367)
+++ trunk/Source/WTF/ChangeLog 2012-06-14 23:00:02 UTC (rev 120368)
@@ -1,3 +1,13 @@
+2012-06-14 Yong Li
+
+[BlackBerry] Implement computeRAMSize for QNX
+https://bugs.webkit.org/show_bug.cgi?id=89110
+
+Reviewed by Rob Buis.
+
+* wtf/RAMSize.cpp:
+(WTF::computeRAMSize):
+
2012-06-14 Geoffrey Garen
ARMv7 should support spinlocks
Modified: trunk/Source/WTF/wtf/RAMSize.cpp (120367 => 120368)
--- trunk/Source/WTF/wtf/RAMSize.cpp 2012-06-14 22:38:41 UTC (rev 120367)
+++ trunk/Source/WTF/wtf/RAMSize.cpp 2012-06-14 23:00:02 UTC (rev 120368)
@@ -35,6 +35,8 @@
#include
#elif OS(WINDOWS)
#include
+#elif OS(QNX)
+#include
#endif
namespace WTF {
@@ -75,6 +77,11 @@
if (!result)
return ramSizeGuess;
return status.ullTotalPhys;
+#elif OS(QNX)
+struct stat mst;
+if (stat("/proc", &mst))
+return ramSizeGuess;
+return mst.st_size;
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120367] trunk
Title: [120367] trunk Revision 120367 Author rn...@webkit.org Date 2012-06-14 15:38:41 -0700 (Thu, 14 Jun 2012) Log Message Radio node lists do not get updated when inserted back into a document https://bugs.webkit.org/show_bug.cgi?id=88825 Reviewed by Darin Adler. Source/WebCore: The bug was caused by RadioNodeList's m_node not being adjusted back to a document after it was removed from the document and inserted back. While we could be doing this adjustment again when the HTMLFormElement is inserted back into the document, this whole approach is fragile because adds a maintenance burden on root elements of RadioNodeList. Change the approach to the problem instead and detect when m_node is detached from the document. Now RadioNodeList and LabelsNodeList will always use its root element as m_node and DynamicSubtreeNodeList's node() will then determine whether it should use its document or not based on the flag (rootedAtDocument) passed by the constructor of the node list and m_node->inDocument(). Also invalidate node lists rooted at the document level regardless where the DOM mutation took place. * dom/ClassNodeList.cpp: (WebCore::ClassNodeList::~ClassNodeList): * dom/Document.cpp: (WebCore::Document::registerDynamicSubtreeNodeList): Moved from Node. (WebCore::Document::unregisterDynamicSubtreeNodeList): Ditto. * dom/Document.h: (Document): * dom/DynamicNodeList.cpp: (WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList): Takes DynamicNodeListRootType which tell us whether node() should return m_node's document by default or not. (WebCore::DynamicSubtreeNodeList::length): Refactor code to avoid node() multiple times. (WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent): Ditto. (WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent): Ditto. (WebCore::DynamicNodeList::itemWithName): Ditto. * dom/DynamicNodeList.h: (WebCore::DynamicNodeList::DynamicNodeList): (WebCore::DynamicNodeList::node): Returns m_node->document() if m_node is still in the document and the node list was rooted at document. (WebCore::DynamicNodeList::Caches::Caches): (Caches): (DynamicNodeList): (DynamicSubtreeNodeList): * dom/NameNodeList.cpp: (WebCore::NameNodeList::~NameNodeList): * dom/Node.cpp: (WebCore): (WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Invalidate m_listsInvalidatedAtDocument at document instead of trying to invalidate it on every ancestor we traverse. (WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Ditto. (WebCore::NodeListsNodeData::invalidateCachesForDocument): Extracted from invalidateCachesThatDependOnAttributes. (WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): (WebCore::Node::radioNodeList): * dom/Node.h: (Node): * dom/NodeRareData.h: (NodeListsNodeData): * dom/TagNodeList.cpp: (WebCore::TagNodeList::~TagNodeList): * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::removedFrom): * html/LabelsNodeList.cpp: (WebCore::LabelsNodeList::LabelsNodeList): * html/RadioNodeList.cpp: (WebCore::RadioNodeList::RadioNodeList): Takes Element* first since that's the order we use elsewhere. * html/RadioNodeList.h: (WebCore::RadioNodeList::create): (RadioNodeList): LayoutTests: Add a test case to an existing test. * fast/forms/radionodelist-whose-form-element-detached-from-domtree-expected.txt: * fast/forms/radionodelist-whose-form-element-detached-from-domtree.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/radionodelist-whose-form-element-detached-from-domtree-expected.txt trunk/LayoutTests/fast/forms/radionodelist-whose-form-element-detached-from-domtree.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/ClassNodeList.cpp trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/DynamicNodeList.cpp trunk/Source/WebCore/dom/DynamicNodeList.h trunk/Source/WebCore/dom/NameNodeList.cpp trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/Node.h trunk/Source/WebCore/dom/NodeRareData.h trunk/Source/WebCore/dom/TagNodeList.cpp trunk/Source/WebCore/html/HTMLFormElement.cpp trunk/Source/WebCore/html/LabelsNodeList.cpp trunk/Source/WebCore/html/RadioNodeList.cpp trunk/Source/WebCore/html/RadioNodeList.h Diff Modified: trunk/LayoutTests/ChangeLog (120366 => 120367) --- trunk/LayoutTests/ChangeLog 2012-06-14 22:33:20 UTC (rev 120366) +++ trunk/LayoutTests/ChangeLog 2012-06-14 22:38:41 UTC (rev 120367) @@ -1,3 +1,15 @@ +2012-06-14 Ryosuke Niwa + +Radio node lists do not get updated when inserted back into a document +https://bugs.webkit.org/show_bug.cgi?id=88825 + +Reviewed by Darin Adler. + +Add a test case to an existing test. + +* fast/forms/radionodelist-whose-form-element-detached-from-domtree-expected.txt: +* fast/forms/radionodelist-whose-form-element-detached-from-domtree.html: + 2012-06-14 Jia Pu Mark text with text alternative wit
[webkit-changes] [120366] trunk/Source/WebCore
Title: [120366] trunk/Source/WebCore
Revision 120366
Author t...@chromium.org
Date 2012-06-14 15:33:20 -0700 (Thu, 14 Jun 2012)
Log Message
Fix bit packing of StyleRareInheritedData on Windows
https://bugs.webkit.org/show_bug.cgi?id=89112
Reviewed by Ryosuke Niwa.
On my machine (64 bit Chromium Linux), StyleRareInheritedData is 168 bytes.
No new tests, added a compile assert to ensure correctness going forward.
* rendering/style/StyleRareInheritedData.cpp:
(SameSizeAsStyleRareInheritedData):
(WebCore):
* rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp
trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (120365 => 120366)
--- trunk/Source/WebCore/ChangeLog 2012-06-14 22:24:26 UTC (rev 120365)
+++ trunk/Source/WebCore/ChangeLog 2012-06-14 22:33:20 UTC (rev 120366)
@@ -1,3 +1,20 @@
+2012-06-14 Tony Chang
+
+Fix bit packing of StyleRareInheritedData on Windows
+https://bugs.webkit.org/show_bug.cgi?id=89112
+
+Reviewed by Ryosuke Niwa.
+
+On my machine (64 bit Chromium Linux), StyleRareInheritedData is 168 bytes.
+
+No new tests, added a compile assert to ensure correctness going forward.
+
+* rendering/style/StyleRareInheritedData.cpp:
+(SameSizeAsStyleRareInheritedData):
+(WebCore):
+* rendering/style/StyleRareInheritedData.h:
+(StyleRareInheritedData):
+
2012-06-14 Andreas Kling
Crashes below IconDatabase::performPendingRetainAndReleaseOperations().
Modified: trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp (120365 => 120366)
--- trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp 2012-06-14 22:24:26 UTC (rev 120365)
+++ trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp 2012-06-14 22:33:20 UTC (rev 120366)
@@ -30,6 +30,35 @@
namespace WebCore {
+struct SameSizeAsStyleRareInheritedData : public RefCounted {
+Color firstColor;
+float firstFloat;
+Color colors[5];
+void* ownPtrs[1];
+AtomicString atomicStrings[5];
+void* refPtrs[2];
+Length lengths[1];
+float secondFloat;
+unsigned m_bitfields[2];
+short pagedMediaShorts[2];
+unsigned unsigneds[1];
+short hyphenationShorts[3];
+
+#if ENABLE(CSS_IMAGE_RESOLUTION)
+float imageResolutionFloats;
+#endif
+
+#if ENABLE(TOUCH_EVENTS)
+Color touchColors;
+#endif
+
+#if ENABLE(CSS_VARIABLES)
+void* variableDataRefs[1];
+#endif
+};
+
+COMPILE_ASSERT(sizeof(StyleRareInheritedData) == sizeof(SameSizeAsStyleRareInheritedData), StyleRareInheritedData_should_bit_pack);
+
StyleRareInheritedData::StyleRareInheritedData()
: textStrokeWidth(RenderStyle::initialTextStrokeWidth())
, indent(RenderStyle::initialTextIndent())
Modified: trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h (120365 => 120366)
--- trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h 2012-06-14 22:24:26 UTC (rev 120365)
+++ trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h 2012-06-14 22:33:20 UTC (rev 120366)
@@ -84,7 +84,7 @@
unsigned wordWrap : 1; // EWordWrap
unsigned nbspMode : 1; // ENBSPMode
unsigned khtmlLineBreak : 1; // EKHTMLLineBreak
-bool textSizeAdjust : 1; // An Apple extension.
+unsigned textSizeAdjust : 1; // An Apple extension.
unsigned resize : 2; // EResize
unsigned userSelect : 1; // EUserSelect
unsigned colorSpace : 1; // ColorSpace
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120364] trunk/Source/WebCore
Title: [120364] trunk/Source/WebCore
Revision 120364
Author kl...@webkit.org
Date 2012-06-14 15:21:45 -0700 (Thu, 14 Jun 2012)
Log Message
Crashes below IconDatabase::performPendingRetainAndReleaseOperations().
Reviewed by Brady Eidson.
Put isolatedCopy() strings in the retain/release operation queues to make sure it's safe
for secondary threads to ref/deref them in performPendingRetainAndReleaseOperations().
Also added assertions as appropriate.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/icon/IconDatabase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120363 => 120364)
--- trunk/Source/WebCore/ChangeLog 2012-06-14 22:00:58 UTC (rev 120363)
+++ trunk/Source/WebCore/ChangeLog 2012-06-14 22:21:45 UTC (rev 120364)
@@ -1,3 +1,20 @@
+2012-06-14 Andreas Kling
+
+Crashes below IconDatabase::performPendingRetainAndReleaseOperations().
+
+
+
+Reviewed by Brady Eidson.
+
+Put isolatedCopy() strings in the retain/release operation queues to make sure it's safe
+for secondary threads to ref/deref them in performPendingRetainAndReleaseOperations().
+Also added assertions as appropriate.
+
+* loader/icon/IconDatabase.cpp:
+(WebCore::IconDatabase::retainIconForPageURL):
+(WebCore::IconDatabase::releaseIconForPageURL):
+(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):
+
2012-06-14 Shawn Singh
[chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it.
Modified: trunk/Source/WebCore/loader/icon/IconDatabase.cpp (120363 => 120364)
--- trunk/Source/WebCore/loader/icon/IconDatabase.cpp 2012-06-14 22:00:58 UTC (rev 120363)
+++ trunk/Source/WebCore/loader/icon/IconDatabase.cpp 2012-06-14 22:21:45 UTC (rev 120364)
@@ -400,7 +400,7 @@
{
MutexLocker locker(m_urlsToRetainOrReleaseLock);
-m_urlsToRetain.add(pageURL);
+m_urlsToRetain.add(pageURL.isolatedCopy());
m_retainOrReleaseIconRequested = true;
}
@@ -453,7 +453,7 @@
{
MutexLocker locker(m_urlsToRetainOrReleaseLock);
-m_urlsToRelease.add(pageURL);
+m_urlsToRelease.add(pageURL.isolatedCopy());
m_retainOrReleaseIconRequested = true;
}
scheduleOrDeferSyncTimer();
@@ -1528,10 +1528,15 @@
m_retainOrReleaseIconRequested = false;
}
-for (HashCountedSet::const_iterator it = toRetain.begin(), end = toRetain.end(); it != end; ++it)
+for (HashCountedSet::const_iterator it = toRetain.begin(), end = toRetain.end(); it != end; ++it) {
+ASSERT(!it->first.impl() || it->first.impl()->hasOneRef());
performRetainIconForPageURL(it->first, it->second);
-for (HashCountedSet::const_iterator it = toRelease.begin(), end = toRelease.end(); it != end; ++it)
+}
+
+for (HashCountedSet::const_iterator it = toRelease.begin(), end = toRelease.end(); it != end; ++it) {
+ASSERT(!it->first.impl() || it->first.impl()->hasOneRef());
performReleaseIconForPageURL(it->first, it->second);
+}
}
bool IconDatabase::readFromDatabase()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120363] trunk/Source/WebKit/chromium
Title: [120363] trunk/Source/WebKit/chromium
Revision 120363
Author commit-qu...@webkit.org
Date 2012-06-14 15:00:58 -0700 (Thu, 14 Jun 2012)
Log Message
[chromium/linux] Drop deprecated WebFontRenderStyle::useSubpixel
https://bugs.webkit.org/show_bug.cgi?id=88263
Patch by Daniel Erat on 2012-06-14
Reviewed by Adam Barth.
This removes the useSubpixel member, which was replaced by
useSubpixelRendering. Chrome has been updated to set only the
useSubpixelRendering field.
No test updates since the existing behavior shouldn't change.
* public/linux/WebFontInfo.h:
(WebFontInfo):
* public/linux/WebFontRenderStyle.h:
* src/linux/WebFontInfo.cpp:
(WebKit::WebFontInfo::renderStyleForStrike):
* src/linux/WebFontRenderStyle.cpp:
(WebKit::WebFontRenderStyle::toFontRenderStyle):
(WebKit::WebFontRenderStyle::setDefaults):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/linux/WebFontInfo.h
trunk/Source/WebKit/chromium/public/linux/WebFontRenderStyle.h
trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp
trunk/Source/WebKit/chromium/src/linux/WebFontRenderStyle.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120362 => 120363)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-14 21:45:21 UTC (rev 120362)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-14 22:00:58 UTC (rev 120363)
@@ -1,3 +1,25 @@
+2012-06-14 Daniel Erat
+
+[chromium/linux] Drop deprecated WebFontRenderStyle::useSubpixel
+https://bugs.webkit.org/show_bug.cgi?id=88263
+
+Reviewed by Adam Barth.
+
+This removes the useSubpixel member, which was replaced by
+useSubpixelRendering. Chrome has been updated to set only the
+useSubpixelRendering field.
+
+No test updates since the existing behavior shouldn't change.
+
+* public/linux/WebFontInfo.h:
+(WebFontInfo):
+* public/linux/WebFontRenderStyle.h:
+* src/linux/WebFontInfo.cpp:
+(WebKit::WebFontInfo::renderStyleForStrike):
+* src/linux/WebFontRenderStyle.cpp:
+(WebKit::WebFontRenderStyle::toFontRenderStyle):
+(WebKit::WebFontRenderStyle::setDefaults):
+
2012-06-14 Shawn Singh
[chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it.
Modified: trunk/Source/WebKit/chromium/public/linux/WebFontInfo.h (120362 => 120363)
--- trunk/Source/WebKit/chromium/public/linux/WebFontInfo.h 2012-06-14 21:45:21 UTC (rev 120362)
+++ trunk/Source/WebKit/chromium/public/linux/WebFontInfo.h 2012-06-14 22:00:58 UTC (rev 120363)
@@ -60,7 +60,7 @@
WEBKIT_EXPORT static void familyForChars(const WebUChar* characters, size_t numCharacters, const char* preferredLocale, WebFontFamily*);
// Fill out the given WebFontRenderStyle with the user's preferences for
-// rendering the given font at the given size.
+// rendering the given font at the given size (in pixels).
// family: i.e. "Times New Roman"
// sizeAndStyle:
// 332211
Modified: trunk/Source/WebKit/chromium/public/linux/WebFontRenderStyle.h (120362 => 120363)
--- trunk/Source/WebKit/chromium/public/linux/WebFontRenderStyle.h 2012-06-14 21:45:21 UTC (rev 120362)
+++ trunk/Source/WebKit/chromium/public/linux/WebFontRenderStyle.h 2012-06-14 22:00:58 UTC (rev 120363)
@@ -47,7 +47,6 @@
char useHinting; // hint glyphs to the pixel grid
char hintStyle; // level of hinting, 0..3
char useAntiAlias; // antialias glyph shapes
-char useSubpixel; // DEPRECATED: replaced by useSubpixelRendering
char useSubpixelRendering; // use subpixel rendering (partially-filled pixels)
char useSubpixelPositioning; // use subpixel positioning (fractional X positions for glyphs)
Modified: trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp (120362 => 120363)
--- trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp 2012-06-14 21:45:21 UTC (rev 120362)
+++ trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp 2012-06-14 22:00:58 UTC (rev 120363)
@@ -192,19 +192,16 @@
if (FcPatternGetInteger(match, FC_RGBA, 0, &i) == FcResultMatch) {
switch (i) {
case FC_RGBA_NONE:
-out->useSubpixel = 0;
out->useSubpixelRendering = 0;
break;
case FC_RGBA_RGB:
case FC_RGBA_BGR:
case FC_RGBA_VRGB:
case FC_RGBA_VBGR:
-out->useSubpixel = 1;
out->useSubpixelRendering = 1;
break;
default:
// This includes FC_RGBA_UNKNOWN.
-out->useSubpixel = 2;
out->useSubpixelRendering = 2;
break;
}
Modified: trunk/Source/WebKit/chromium/src/linux/WebFontRenderStyle.cpp (120362 => 120363)
--- trunk/Source/WebKit/chromium/src/linux/WebFontRenderStyle.cpp 2012-06-14 21:45:21 UTC (rev 120362)
+++ trunk/Source/WebKit/chromium/src/linux/WebFontRenderStyle.cpp 2012-06-14 22:00
[webkit-changes] [120362] trunk/Source
Title: [120362] trunk/Source
Revision 120362
Author shawnsi...@chromium.org
Date 2012-06-14 14:45:21 -0700 (Thu, 14 Jun 2012)
Log Message
[chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it.
https://bugs.webkit.org/show_bug.cgi?id=89049
Reviewed by Adrienne Walker.
Source/WebCore:
Unit test added to CCLayerTreeHostCommonTest.cpp:
CCLayerTreeHostCommonTest.verifyHitTestingForUninvertibleTransform
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::pointHitsRect):
Source/WebKit/chromium:
* tests/CCLayerTreeHostCommonTest.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120361 => 120362)
--- trunk/Source/WebCore/ChangeLog 2012-06-14 21:15:52 UTC (rev 120361)
+++ trunk/Source/WebCore/ChangeLog 2012-06-14 21:45:21 UTC (rev 120362)
@@ -1,3 +1,16 @@
+2012-06-14 Shawn Singh
+
+[chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it.
+https://bugs.webkit.org/show_bug.cgi?id=89049
+
+Reviewed by Adrienne Walker.
+
+Unit test added to CCLayerTreeHostCommonTest.cpp:
+ CCLayerTreeHostCommonTest.verifyHitTestingForUninvertibleTransform
+
+* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
+(WebCore::pointHitsRect):
+
2012-06-14 Maciej Stachowiak
The whole world rebuilds when you touch any IDL file
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp (120361 => 120362)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp 2012-06-14 21:15:52 UTC (rev 120361)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp 2012-06-14 21:45:21 UTC (rev 120362)
@@ -874,6 +874,10 @@
static bool pointHitsRect(const IntPoint& viewportPoint, const WebTransformationMatrix& localSpaceToScreenSpaceTransform, FloatRect localSpaceRect)
{
+// If the transform is not invertible, then assume that this point doesn't hit this rect.
+if (!localSpaceToScreenSpaceTransform.isInvertible())
+return false;
+
// Transform the hit test point from screen space to the local space of the given rect.
bool clipped = false;
FloatPoint hitTestPointInLocalSpace = CCMathUtil::projectPoint(localSpaceToScreenSpaceTransform.inverse(), FloatPoint(viewportPoint), clipped);
Modified: trunk/Source/WebKit/chromium/ChangeLog (120361 => 120362)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-14 21:15:52 UTC (rev 120361)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-14 21:45:21 UTC (rev 120362)
@@ -1,3 +1,12 @@
+2012-06-14 Shawn Singh
+
+[chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it.
+https://bugs.webkit.org/show_bug.cgi?id=89049
+
+Reviewed by Adrienne Walker.
+
+* tests/CCLayerTreeHostCommonTest.cpp:
+
2012-06-14 Ian Vollick
[chromium] Certain settings in CCSettings could be global
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp (120361 => 120362)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp 2012-06-14 21:15:52 UTC (rev 120361)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp 2012-06-14 21:45:21 UTC (rev 120362)
@@ -2970,6 +2970,72 @@
EXPECT_EQ(12345, resultLayer->id());
}
+TEST(CCLayerTreeHostCommonTest, verifyHitTestingForUninvertibleTransform)
+{
+DebugScopedSetImplThread thisScopeIsOnImplThread;
+
+OwnPtr root = CCLayerImpl::create(12345);
+root->createRenderSurface();
+root->renderSurface()->setContentRect(IntRect(IntPoint::zero(), IntSize(100, 100)));
+
+WebTransformationMatrix uninvertibleTransform;
+uninvertibleTransform.setM11(0);
+uninvertibleTransform.setM22(0);
+uninvertibleTransform.setM33(0);
+uninvertibleTransform.setM44(0);
+ASSERT_FALSE(uninvertibleTransform.isInvertible());
+
+WebTransformationMatrix identityMatrix;
+FloatPoint anchor(0, 0);
+FloatPoint position(0, 0);
+IntSize bounds(100, 100);
+setLayerPropertiesForTesting(root.get(), uninvertibleTransform, identityMatrix, anchor, position, bounds, false);
+root->setDrawsContent(true);
+
+Vector renderSurfaceLayerList;
+Vector dummyLayerList;
+int dummyMaxTextureSize = 512;
+renderSurfaceLayerList.append(root.get());
+CCLayerTreeHostCommon::calculateDrawTransforms(root.get(), root.get(), identityMatrix, identityMatrix, renderSurfaceLayerList, dummyLayerList, 0, dummyMaxTextureSize);
+CCLayerTreeHostCommon::calculateVisibleAndScissorRects(renderSurfaceLayerList, FloatRect()); // empty scissorRect will he
[webkit-changes] [120361] trunk/Source/WebCore
Title: [120361] trunk/Source/WebCore Revision 120361 Author m...@apple.com Date 2012-06-14 14:15:52 -0700 (Thu, 14 Jun 2012) Log Message The whole world rebuilds when you touch any IDL file https://bugs.webkit.org/show_bug.cgi?id=89125 Reviewed by Sam Weinig. No new tests; this only changes the build system and its dependencies. * bindings/scripts/preprocess-idls.pl: Optionally generate the dependencies for supplemental IDLs in Makefile format. * DerivedSources.make: Use the new feature of preprocess-idls.pl to generate the correct IDL dependencies created by Supplemental, then include it. This way, we avoid the situation where every bindings file implicitly depends on every single IDL file in the project. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl Diff Modified: trunk/Source/WebCore/ChangeLog (120360 => 120361) --- trunk/Source/WebCore/ChangeLog 2012-06-14 20:41:02 UTC (rev 120360) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 21:15:52 UTC (rev 120361) @@ -1,3 +1,19 @@ +2012-06-14 Maciej Stachowiak + +The whole world rebuilds when you touch any IDL file +https://bugs.webkit.org/show_bug.cgi?id=89125 + +Reviewed by Sam Weinig. + +No new tests; this only changes the build system and its dependencies. + +* bindings/scripts/preprocess-idls.pl: Optionally generate the +dependencies for supplemental IDLs in Makefile format. +* DerivedSources.make: Use the new feature of preprocess-idls.pl to generate +the correct IDL dependencies created by Supplemental, then include it. This way, +we avoid the situation where every bindings file implicitly depends on every single +IDL file in the project. + 2012-06-14 Ian Vollick [chromium] Certain settings in CCSettings could be global Modified: trunk/Source/WebCore/DerivedSources.make (120360 => 120361) --- trunk/Source/WebCore/DerivedSources.make 2012-06-14 20:41:02 UTC (rev 120360) +++ trunk/Source/WebCore/DerivedSources.make 2012-06-14 21:15:52 UTC (rev 120361) @@ -615,6 +615,7 @@ endif # BUILDING_WX all : \ +$(SUPPLEMENTAL_DEPENDENCY_FILE) \ $(JS_DOM_HEADERS) \ $(WEB_DOM_HEADERS) \ \ @@ -949,7 +950,8 @@ JS_BINDINGS_SCRIPTS = $(GENERATE_SCRIPTS) bindings/scripts/CodeGeneratorJS.pm -SUPPLEMENTAL_DEPENDENCY_FILE = ./supplemental_dependency.tmp +SUPPLEMENTAL_DEPENDENCY_FILE = ./SupplementalDependencies.txt +SUPPLEMENTAL_MAKEFILE_DEPS = ./SupplementalDependencies.dep IDL_FILES_TMP = ./idl_files.tmp ADDITIONAL_IDLS = $(WebCore)/inspector/_javascript_CallFrame.idl IDL_ATTRIBUTES_FILE = $(WebCore)/bindings/scripts/IDLAttributes.txt @@ -959,14 +961,15 @@ space := space += -$(SUPPLEMENTAL_DEPENDENCY_FILE) : $(PREPROCESS_IDLS_SCRIPTS) $(BINDING_IDLS) $(ADDITIONAL_IDLS) $(IDL_ATTRIBUTES_FILE) +$(SUPPLEMENTAL_MAKEFILE_DEPS) : $(PREPROCESS_IDLS_SCRIPTS) $(BINDING_IDLS) $(ADDITIONAL_IDLS) $(IDL_ATTRIBUTES_FILE) printf "$(subst $(space),,$(patsubst %,%\n,$(BINDING_IDLS) $(ADDITIONAL_IDLS)))" > $(IDL_FILES_TMP) - $(call preprocess_idls_script, $(PREPROCESS_IDLS_SCRIPTS)) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT" --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@ --idlAttributesFile $(IDL_ATTRIBUTES_FILE) + $(call preprocess_idls_script, $(PREPROCESS_IDLS_SCRIPTS)) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT" --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) --supplementalMakefileDeps $@ --idlAttributesFile $(IDL_ATTRIBUTES_FILE) rm -f $(IDL_FILES_TMP) -JS%.h : %.idl $(JS_BINDINGS_SCRIPTS) $(SUPPLEMENTAL_DEPENDENCY_FILE) +JS%.h : %.idl $(JS_BINDINGS_SCRIPTS) $(call generator_script, $(JS_BINDINGS_SCRIPTS)) $(IDL_COMMON_ARGS) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT" --generator JS --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) $< +include $(SUPPLEMENTAL_MAKEFILE_DEPS) # Inspector interfaces generator @@ -997,7 +1000,7 @@ ifeq ($(findstring BUILDING_WX,$(FEATURE_DEFINES)), BUILDING_WX) CPP_BINDINGS_SCRIPTS = $(GENERATE_SCRIPTS) bindings/scripts/CodeGeneratorCPP.pm -WebDOM%.h : %.idl $(CPP_BINDINGS_SCRIPTS) $(SUPPLEMENTAL_DEPENDENCY_FILE) +WebDOM%.h : %.idl $(CPP_BINDINGS_SCRIPTS) $(call generator_script, $(CPP_BINDINGS_SCRIPTS)) $(IDL_COMMON_ARGS) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_CPP" --generator CPP --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) $< endif # BUILDING_WX @@ -1040,7 +1043,7 @@ # Objective-C bindings DOM_BINDINGS_SCRIPTS = $(GENERATE_BINDING_SCRIPTS) bindings/scripts/CodeGeneratorObjC.pm -DOM%.h : %.idl $(DOM_BINDINGS_SCRIPTS) $(SUPPLEMENTAL_DEPENDENCY_FILE) bindings/objc/PublicDOMInterfaces.h +DOM%.h : %.idl $(DOM_BINDINGS_SCRIPTS) bindings/objc/PublicDOMInterfaces.h $(call gener
[webkit-changes] [120359] trunk/Source
Title: [120359] trunk/Source Revision 120359 Author a...@webkit.org Date 2012-06-14 13:36:15 -0700 (Thu, 14 Jun 2012) Log Message 2012-06-14 Alejandro G. Castro [GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path https://bugs.webkit.org/show_bug.cgi?id=73634 Add the new graphics layer client that uses cairo to render the composition. The cairo transformations do not support perspective so in perspective cases we have just a representation not the real perspective transformation. This patch adds a new implementation of already tested cases. Reviewed by Martin Robinson. * GNUmakefile.am: * WebCoreSupport/AcceleratedCompositingContext.h: (AcceleratedCompositingContext): * WebCoreSupport/AcceleratedCompositingContextCairo.cpp: Added. * WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::invalidateWidgetRect): We need to invalidate the widget in this case because we do not directly render to a texture but to the widget surface. (WebKit::ChromeClient::paint): We can not render here, we have to invalidate and wait for the widget rendering. * webkit/webkitwebview.cpp: (webkit_web_view_draw): In this case the renderLayersToWindow requires the graphics context used to render in the window. (webkit_web_view_realize): Small cleanup of the priv variable definition. 2012-06-14 Alejandro G. Castro [GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path https://bugs.webkit.org/show_bug.cgi?id=73634 Remove the TextureMapperCairo classes, now we use TextureMapperImageBuffer to implement the software fallback. Add implementation for the 3D transformations in the 2D cairo graphics context. Reviewed by Martin Robinson. This patch adds a new implementation of already tested cases. * GNUmakefile.list.am: * platform/graphics/cairo/GraphicsContext3DPrivate.cpp: (WebCore): (WebCore::GraphicsContext3DPrivate::paintToTextureMapper): Required for compilation when WebGL is enabled. * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::get3DTransform): (WebCore::GraphicsContext::concat3DTransform): (WebCore::GraphicsContext::set3DTransform): * platform/graphics/cairo/TextureMapperCairo.cpp: Removed. * platform/graphics/cairo/TextureMapperCairo.h: Removed. * platform/graphics/texmap/TextureMapperImageBuffer.cpp: (WebCore::BitmapTextureImageBuffer::updateContents): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp trunk/Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/GNUmakefile.am trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp Added Paths trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextCairo.cpp Removed Paths trunk/Source/WebCore/platform/graphics/cairo/TextureMapperCairo.cpp trunk/Source/WebCore/platform/graphics/cairo/TextureMapperCairo.h Diff Modified: trunk/Source/WebCore/ChangeLog (120358 => 120359) --- trunk/Source/WebCore/ChangeLog 2012-06-14 20:23:41 UTC (rev 120358) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 20:36:15 UTC (rev 120359) @@ -1,3 +1,31 @@ +2012-06-14 Alejandro G. Castro + +[GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path +https://bugs.webkit.org/show_bug.cgi?id=73634 + +Remove the TextureMapperCairo classes, now we use +TextureMapperImageBuffer to implement the software fallback. Add +implementation for the 3D transformations in the 2D cairo graphics +context. + +Reviewed by Martin Robinson. + +This patch adds a new implementation of already tested cases. + +* GNUmakefile.list.am: +* platform/graphics/cairo/GraphicsContext3DPrivate.cpp: +(WebCore): +(WebCore::GraphicsContext3DPrivate::paintToTextureMapper): +Required for compilation when WebGL is enabled. +* platform/graphics/cairo/GraphicsContextCairo.cpp: +(WebCore::GraphicsContext::get3DTransform): +(WebCore::GraphicsContext::concat3DTransform): +(WebCore::GraphicsContext::set3DTransform): +* platform/graphics/cairo/TextureM
[webkit-changes] [120358] trunk/Tools
Title: [120358] trunk/Tools
Revision 120358
Author o...@webkit.org
Date 2012-06-14 13:23:41 -0700 (Thu, 14 Jun 2012)
Log Message
Unreviewed, rolling out r120352.
http://trac.webkit.org/changeset/120352
https://bugs.webkit.org/show_bug.cgi?id=89120
It seems something is still wrong with it :/ (Requested by
Ossy on #webkit).
Patch by Sheriff Bot on 2012-06-14
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(Factory.__init__):
(BuildFactory.__init__):
(TestFactory.__init__):
(BuildAndTestFactory.__init__):
(BuildAndPerfTestFactory.__init__):
(BuildAndPerfTestWebKit2Factory.__init__):
(DownloadAndPerfTestFactory.__init__):
(DownloadAndPerfTestWebKit2Factory.__init__):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (120357 => 120358)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-06-14 20:22:56 UTC (rev 120357)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-06-14 20:23:41 UTC (rev 120358)
@@ -661,29 +661,29 @@
class Factory(factory.BuildFactory):
def __init__(self, platform, configuration, architectures, buildOnly):
factory.BuildFactory.__init__(self)
-self.addStep(ConfigureBuild(platform=platform, configuration=configuration, architecture=" ".join(architectures), buildOnly=buildOnly))
-self.addStep(CheckOutSource())
+self.addStep(ConfigureBuild, platform=platform, configuration=configuration, architecture=" ".join(architectures), buildOnly=buildOnly)
+self.addStep(CheckOutSource)
# There are multiple Qt slaves running on same machines, so buildslaves shouldn't kill the processes of other slaves.
if not platform.startswith("qt"):
-self.addStep(KillOldProcesses())
+self.addStep(KillOldProcesses)
if platform == "win":
-self.addStep(InstallWin32Dependencies())
+self.addStep(InstallWin32Dependencies)
if platform.startswith("chromium"):
-self.addStep(InstallChromiumDependencies())
+self.addStep(InstallChromiumDependencies)
if platform == "gtk":
-self.addStep(InstallGtkDependencies())
+self.addStep(InstallGtkDependencies)
if platform == "efl":
-self.addStep(InstallEflDependencies())
+self.addStep(InstallEflDependencies)
class BuildFactory(Factory):
def __init__(self, platform, configuration, architectures, triggers=None):
Factory.__init__(self, platform, configuration, architectures, True)
-self.addStep(CompileWebKit())
+self.addStep(CompileWebKit)
if triggers:
-self.addStep(ArchiveBuiltProduct())
-self.addStep(UploadBuiltProduct())
-self.addStep(trigger.Trigger(schedulerNames=triggers))
+self.addStep(ArchiveBuiltProduct)
+self.addStep(UploadBuiltProduct)
+self.addStep(trigger.Trigger, schedulerNames=triggers)
def unitTestsSupported(configuration, platform):
if platform.startswith('mac') and configuration == "release":
@@ -700,30 +700,30 @@
def __init__(self, platform, configuration, architectures):
Factory.__init__(self, platform, configuration, architectures, False)
if platform.startswith("chromium"):
-self.addStep(CleanupChromiumCrashLogs())
-self.addStep(DownloadBuiltProduct())
-self.addStep(ExtractBuiltProduct())
+self.addStep(CleanupChromiumCrashLogs)
+self.addStep(DownloadBuiltProduct)
+self.addStep(ExtractBuiltProduct)
if not platform.startswith("chromium"):
-self.addStep(RunJavaScriptCoreTests(buildJSCTool=False))
+self.addStep(RunJavaScriptCoreTests, buildJSCTool=False)
if platform.startswith("chromium"):
-self.addStep(RunChromiumWebKitUnitTests())
-self.addStep(self.TestClass(buildJSCTool=(platform != 'win')))
+self.addStep(RunChromiumWebKitUnitTests)
+self.addStep(self.TestClass, buildJSCTool=(platform != 'win'))
if unitTestsSupported(configuration, platform):
-self.addStep(RunUnitTests())
-self.addStep(RunPythonTests())
+self.addStep(RunUnitTests)
+self.addStep(RunPythonTests)
# Chromium Win runs in non-Cygwin environment, which is not yet fit
# for running tests. This can be removed once bug 48166 is fixed.
if platform != "chromium-win":
-self.addStep(RunPerlTests())
-self.addStep(RunBindingsTests())
-self.addStep(ArchiveTestResults())
-self.addStep(UploadTestResults())
-self.addStep(self.ExtractTestResultsClass())
+self.addStep(RunPerlTests)
+self.addStep(RunBindingsTests)
+self.addStep(ArchiveTestResults)
+self.addStep(UploadT
[webkit-changes] [120356] trunk/Source/WTF
Title: [120356] trunk/Source/WTF
Revision 120356
Author gga...@apple.com
Date 2012-06-14 13:18:23 -0700 (Thu, 14 Jun 2012)
Log Message
ARMv7 should support spinlocks
https://bugs.webkit.org/show_bug.cgi?id=88957
Reviewed by Darin Adler.
More info @ http://infocenter.arm.com/help/topic/
com.arm.doc.genc007826/Barrier_Litmus_Tests_and_Cookbook_A08.pdf
* wtf/Atomics.h:
(WTF::memoryBarrierAfterLock):
(WTF::memoryBarrierBeforeUnlock): Added memory barrier primitives since
ARMv7 has a weakly ordered memory model.
* wtf/Platform.h: Enabled compare-and-swap on Windows so our spinlock
implementation would continue working on Windows.
* wtf/TCSpinLock.h:
(TCMalloc_SpinLock::Lock):
(TCMalloc_SpinLock::Unlock):
(TCMalloc_SpinLock): Use our compare-and-swap helper function to avoid
rewriting it in assembly here.
Added memory barriers since ARMv7 needs them.
Removed PPC support because our helper function doesn't support PPC.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Atomics.h
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WTF/wtf/TCSpinLock.h
Diff
Modified: trunk/Source/WTF/ChangeLog (120355 => 120356)
--- trunk/Source/WTF/ChangeLog 2012-06-14 20:15:46 UTC (rev 120355)
+++ trunk/Source/WTF/ChangeLog 2012-06-14 20:18:23 UTC (rev 120356)
@@ -1,3 +1,31 @@
+2012-06-14 Geoffrey Garen
+
+ARMv7 should support spinlocks
+https://bugs.webkit.org/show_bug.cgi?id=88957
+
+Reviewed by Darin Adler.
+
+More info @ http://infocenter.arm.com/help/topic/
+com.arm.doc.genc007826/Barrier_Litmus_Tests_and_Cookbook_A08.pdf
+
+* wtf/Atomics.h:
+(WTF::memoryBarrierAfterLock):
+(WTF::memoryBarrierBeforeUnlock): Added memory barrier primitives since
+ARMv7 has a weakly ordered memory model.
+
+* wtf/Platform.h: Enabled compare-and-swap on Windows so our spinlock
+implementation would continue working on Windows.
+
+* wtf/TCSpinLock.h:
+(TCMalloc_SpinLock::Lock):
+(TCMalloc_SpinLock::Unlock):
+(TCMalloc_SpinLock): Use our compare-and-swap helper function to avoid
+rewriting it in assembly here.
+
+Added memory barriers since ARMv7 needs them.
+
+Removed PPC support because our helper function doesn't support PPC.
+
2012-06-13 Arnaud Renevier
make sure headers are included only once per file
Modified: trunk/Source/WTF/wtf/Atomics.h (120355 => 120356)
--- trunk/Source/WTF/wtf/Atomics.h 2012-06-14 20:15:46 UTC (rev 120355)
+++ trunk/Source/WTF/wtf/Atomics.h 2012-06-14 20:18:23 UTC (rev 120356)
@@ -206,6 +206,25 @@
return weakCompareAndSwap(reinterpret_cast(location), reinterpret_cast(expected), reinterpret_cast(newValue));
}
+#if CPU(ARM_THUMB2)
+
+inline void memoryBarrierAfterLock()
+{
+asm volatile("dmb" ::: "memory");
+}
+
+inline void memoryBarrierBeforeUnlock()
+{
+asm volatile("dmb" ::: "memory");
+}
+
+#else
+
+inline void memoryBarrierAfterLock() { }
+inline void memoryBarrierBeforeUnlock() { }
+
+#endif
+
} // namespace WTF
#if USE(LOCKFREE_THREADSAFEREFCOUNTED)
Modified: trunk/Source/WTF/wtf/Platform.h (120355 => 120356)
--- trunk/Source/WTF/wtf/Platform.h 2012-06-14 20:15:46 UTC (rev 120355)
+++ trunk/Source/WTF/wtf/Platform.h 2012-06-14 20:18:23 UTC (rev 120356)
@@ -1068,7 +1068,7 @@
#define WTF_USE_UNIX_DOMAIN_SOCKETS 1
#endif
-#if !defined(ENABLE_COMPARE_AND_SWAP) && COMPILER(GCC) && (CPU(X86) || CPU(X86_64) || CPU(ARM_THUMB2))
+#if !defined(ENABLE_COMPARE_AND_SWAP) && (OS(WINDOWS) || (COMPILER(GCC) && (CPU(X86) || CPU(X86_64) || CPU(ARM_THUMB2
#define ENABLE_COMPARE_AND_SWAP 1
#endif
Modified: trunk/Source/WTF/wtf/TCSpinLock.h (120355 => 120356)
--- trunk/Source/WTF/wtf/TCSpinLock.h 2012-06-14 20:15:46 UTC (rev 120355)
+++ trunk/Source/WTF/wtf/TCSpinLock.h 2012-06-14 20:18:23 UTC (rev 120356)
@@ -34,182 +34,54 @@
#ifndef TCMALLOC_INTERNAL_SPINLOCK_H__
#define TCMALLOC_INTERNAL_SPINLOCK_H__
-#if (CPU(X86) || CPU(X86_64) || CPU(PPC)) && (COMPILER(GCC) || COMPILER(MSVC))
-
-#include
-#include/* For nanosleep() */
-
-#if OS(WINDOWS)
-#ifndef WIN32_LEAN_AND_MEAN
-#define WIN32_LEAN_AND_MEAN
+#include
+#if OS(UNIX)
+#include
#endif
-#include
-#else
-#include /* For sched_yield() */
-#endif
-static void TCMalloc_SlowLock(volatile unsigned int* lockword);
+#if ENABLE(COMPARE_AND_SWAP)
+static void TCMalloc_SlowLock(unsigned* lockword);
+
// The following is a struct so that it can be initialized at compile time
struct TCMalloc_SpinLock {
+void Lock() {
+ if (!WTF::weakCompareAndSwap(&lockword_, 0, 1))
+TCMalloc_SlowLock(&lockword_);
+ WTF::memoryBarrierAfterLock();
+}
- inline void Lock() {
-int r;
-#if COMPILER(GCC)
-#if CPU(X86) || CPU(X86_64)
-__asm__ __volatile__
- ("xchgl %0, %1"
- : "=r"(r), "=m"(lockword_)
- : "0"(1), "m"(lockword_)
- : "memory");
-#else
-volatile unsigned int *lockword_ptr = &lockw
[webkit-changes] [120355] trunk/Tools
Title: [120355] trunk/Tools Revision 120355 Author o...@webkit.org Date 2012-06-14 13:15:46 -0700 (Thu, 14 Jun 2012) Log Message Unreviewed, rolling out r120353. http://trac.webkit.org/changeset/120353 https://bugs.webkit.org/show_bug.cgi?id=89119 It seems we still need this workaround (Requested by Ossy on #webkit). Patch by Sheriff Bot on 2012-06-14 * BuildSlaveSupport/build.webkit.org-config/master.cfg: (loadBuilderConfig): Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (120354 => 120355) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-06-14 20:08:26 UTC (rev 120354) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-06-14 20:15:46 UTC (rev 120355) @@ -820,6 +820,9 @@ # unicode strings from json.load, so we map all keys to str objects. scheduler = dict(map(lambda key_value_pair: (str(key_value_pair[0]), key_value_pair[1]), scheduler.items())) +# BaseScheduler asserts if given unicode objects instead of strs. +# http://trac.buildbot.net/ticket/2075 +scheduler['builderNames'] = map(str, scheduler['builderNames']) c['schedulers'].append(kls(**scheduler)) c['builders'] = [] Modified: trunk/Tools/ChangeLog (120354 => 120355) --- trunk/Tools/ChangeLog 2012-06-14 20:08:26 UTC (rev 120354) +++ trunk/Tools/ChangeLog 2012-06-14 20:15:46 UTC (rev 120355) @@ -1,3 +1,15 @@ +2012-06-14 Sheriff Bot + +Unreviewed, rolling out r120353. +http://trac.webkit.org/changeset/120353 +https://bugs.webkit.org/show_bug.cgi?id=89119 + +It seems we still need this workaround (Requested by Ossy on +#webkit). + +* BuildSlaveSupport/build.webkit.org-config/master.cfg: +(loadBuilderConfig): + 2012-06-14 Csaba Osztrogonác master.cfg cleanup, remove unnecessary workaround ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120354] trunk
Title: [120354] trunk Revision 120354 Author e...@chromium.org Date 2012-06-14 13:08:26 -0700 (Thu, 14 Jun 2012) Log Message Change RenderTableSection::calcRowLogicalHeight to round rather than floor height https://bugs.webkit.org/show_bug.cgi?id=88813 Reviewed by Julien Chaffraix. Source/WebCore: Change RenderTableSection::calcRowLogicalHeight to round the logicalHeight instead of flooring it. This matches our rounding logic elsewhere and results in table rows better matching the expected height. Test: fast/sub-pixel/table-rows-have-stable-height.html * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowLogicalHeight): LayoutTests: Add new test ensuring that rows are laid out the desired height when given a height that maps to a device pixel value. * fast/sub-pixel/table-rows-have-stable-height-expected.txt: Added. * fast/sub-pixel/table-rows-have-stable-height.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderTableSection.cpp Added Paths trunk/LayoutTests/fast/sub-pixel/table-rows-have-stable-height-expected.txt trunk/LayoutTests/fast/sub-pixel/table-rows-have-stable-height.html Diff Modified: trunk/LayoutTests/ChangeLog (120353 => 120354) --- trunk/LayoutTests/ChangeLog 2012-06-14 20:02:31 UTC (rev 120353) +++ trunk/LayoutTests/ChangeLog 2012-06-14 20:08:26 UTC (rev 120354) @@ -1,3 +1,16 @@ +2012-06-14 Emil A Eklund + +Change RenderTableSection::calcRowLogicalHeight to round rather than floor height +https://bugs.webkit.org/show_bug.cgi?id=88813 + +Reviewed by Julien Chaffraix. + +Add new test ensuring that rows are laid out the desired height when +given a height that maps to a device pixel value. + +* fast/sub-pixel/table-rows-have-stable-height-expected.txt: Added. +* fast/sub-pixel/table-rows-have-stable-height.html: Added. + 2012-06-14 Zan Dobersek [Gtk] Add support in DumpRenderTree for tracking repaints Added: trunk/LayoutTests/fast/sub-pixel/table-rows-have-stable-height-expected.txt (0 => 120354) --- trunk/LayoutTests/fast/sub-pixel/table-rows-have-stable-height-expected.txt (rev 0) +++ trunk/LayoutTests/fast/sub-pixel/table-rows-have-stable-height-expected.txt 2012-06-14 20:08:26 UTC (rev 120354) @@ -0,0 +1,15 @@ +PASS At 50% zoom all heights matched. +PASS At 75% zoom all heights matched. +PASS At 90% zoom all heights matched. +PASS At 110% zoom all heights matched. +PASS At 125% zoom all heights matched. +PASS At 133% zoom all heights matched. +PASS At 150% zoom all heights matched. +PASS At 175% zoom all heights matched. +PASS At 200% zoom all heights matched. +PASS At 100% zoom all heights matched. +This tests whether table row heights are stable by measuring the height of a row, assigning that height to another row and then measuring it. For each row the numbers in the three cells should be the same. + +Bug 88813 + + Added: trunk/LayoutTests/fast/sub-pixel/table-rows-have-stable-height.html (0 => 120354) --- trunk/LayoutTests/fast/sub-pixel/table-rows-have-stable-height.html (rev 0) +++ trunk/LayoutTests/fast/sub-pixel/table-rows-have-stable-height.html 2012-06-14 20:08:26 UTC (rev 120354) @@ -0,0 +1,126 @@ + + + + +body { +margin: 5px; +} +table { +border-collapse: collapse; +} +td { +background: skyblue; +border: 1px solid black; +} +#measure { +position: absolute; +top: -500px; +visibility: hidden; +} + + + ++
++ +style.height +rect.height +rect.bottom - rect.top ++ a b c + a b c + a b c + a b c + a b c + a b c + a b c + a b c + a b c +This tests whether table row heights are stable by measuring the +height of a row, assigning that height to another row and then +measuring it. +For each row the numbers in the three cells should be the same. +
++ +
+ ++
Measurement table ...
[webkit-changes] [120353] trunk/Tools
Title: [120353] trunk/Tools Revision 120353 Author o...@webkit.org Date 2012-06-14 13:02:31 -0700 (Thu, 14 Jun 2012) Log Message master.cfg cleanup, remove unnecessary workaround https://bugs.webkit.org/show_bug.cgi?id=88994 Reviewed by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (loadBuilderConfig): Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (120352 => 120353) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-06-14 20:02:16 UTC (rev 120352) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-06-14 20:02:31 UTC (rev 120353) @@ -820,9 +820,6 @@ # unicode strings from json.load, so we map all keys to str objects. scheduler = dict(map(lambda key_value_pair: (str(key_value_pair[0]), key_value_pair[1]), scheduler.items())) -# BaseScheduler asserts if given unicode objects instead of strs. -# http://trac.buildbot.net/ticket/2075 -scheduler['builderNames'] = map(str, scheduler['builderNames']) c['schedulers'].append(kls(**scheduler)) c['builders'] = [] Modified: trunk/Tools/ChangeLog (120352 => 120353) --- trunk/Tools/ChangeLog 2012-06-14 20:02:16 UTC (rev 120352) +++ trunk/Tools/ChangeLog 2012-06-14 20:02:31 UTC (rev 120353) @@ -1,5 +1,15 @@ 2012-06-14 Csaba Osztrogonác +master.cfg cleanup, remove unnecessary workaround +https://bugs.webkit.org/show_bug.cgi?id=88994 + +Reviewed by Lucas Forschler. + +* BuildSlaveSupport/build.webkit.org-config/master.cfg: +(loadBuilderConfig): + +2012-06-14 Csaba Osztrogonác + master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses https://bugs.webkit.org/show_bug.cgi?id=89001 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120352] trunk/Tools
Title: [120352] trunk/Tools Revision 120352 Author o...@webkit.org Date 2012-06-14 13:02:16 -0700 (Thu, 14 Jun 2012) Log Message master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses https://bugs.webkit.org/show_bug.cgi?id=89001 Reviewed by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (Factory.__init__): (BuildFactory.__init__): (TestFactory.__init__): (BuildAndTestFactory.__init__): (BuildAndPerfTestFactory.__init__): (BuildAndPerfTestWebKit2Factory.__init__): (DownloadAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit2Factory.__init__): Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (120351 => 120352) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-06-14 20:02:01 UTC (rev 120351) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-06-14 20:02:16 UTC (rev 120352) @@ -661,29 +661,29 @@ class Factory(factory.BuildFactory): def __init__(self, platform, configuration, architectures, buildOnly): factory.BuildFactory.__init__(self) -self.addStep(ConfigureBuild, platform=platform, configuration=configuration, architecture=" ".join(architectures), buildOnly=buildOnly) -self.addStep(CheckOutSource) +self.addStep(ConfigureBuild(platform=platform, configuration=configuration, architecture=" ".join(architectures), buildOnly=buildOnly)) +self.addStep(CheckOutSource()) # There are multiple Qt slaves running on same machines, so buildslaves shouldn't kill the processes of other slaves. if not platform.startswith("qt"): -self.addStep(KillOldProcesses) +self.addStep(KillOldProcesses()) if platform == "win": -self.addStep(InstallWin32Dependencies) +self.addStep(InstallWin32Dependencies()) if platform.startswith("chromium"): -self.addStep(InstallChromiumDependencies) +self.addStep(InstallChromiumDependencies()) if platform == "gtk": -self.addStep(InstallGtkDependencies) +self.addStep(InstallGtkDependencies()) if platform == "efl": -self.addStep(InstallEflDependencies) +self.addStep(InstallEflDependencies()) class BuildFactory(Factory): def __init__(self, platform, configuration, architectures, triggers=None): Factory.__init__(self, platform, configuration, architectures, True) -self.addStep(CompileWebKit) +self.addStep(CompileWebKit()) if triggers: -self.addStep(ArchiveBuiltProduct) -self.addStep(UploadBuiltProduct) -self.addStep(trigger.Trigger, schedulerNames=triggers) +self.addStep(ArchiveBuiltProduct()) +self.addStep(UploadBuiltProduct()) +self.addStep(trigger.Trigger(schedulerNames=triggers)) def unitTestsSupported(configuration, platform): if platform.startswith('mac') and configuration == "release": @@ -700,30 +700,30 @@ def __init__(self, platform, configuration, architectures): Factory.__init__(self, platform, configuration, architectures, False) if platform.startswith("chromium"): -self.addStep(CleanupChromiumCrashLogs) -self.addStep(DownloadBuiltProduct) -self.addStep(ExtractBuiltProduct) +self.addStep(CleanupChromiumCrashLogs()) +self.addStep(DownloadBuiltProduct()) +self.addStep(ExtractBuiltProduct()) if not platform.startswith("chromium"): -self.addStep(RunJavaScriptCoreTests, buildJSCTool=False) +self.addStep(RunJavaScriptCoreTests(buildJSCTool=False)) if platform.startswith("chromium"): -self.addStep(RunChromiumWebKitUnitTests) -self.addStep(self.TestClass, buildJSCTool=(platform != 'win')) +self.addStep(RunChromiumWebKitUnitTests()) +self.addStep(self.TestClass(buildJSCTool=(platform != 'win'))) if unitTestsSupported(configuration, platform): -self.addStep(RunUnitTests) -self.addStep(RunPythonTests) +self.addStep(RunUnitTests()) +self.addStep(RunPythonTests()) # Chromium Win runs in non-Cygwin environment, which is not yet fit # for running tests. This can be removed once bug 48166 is fixed. if platform != "chromium-win": -self.addStep(RunPerlTests) -self.addStep(RunBindingsTests) -self.addStep(ArchiveTestResults) -self.addStep(UploadTestResults) -self.addStep(self.ExtractTestResultsClass) +self.addStep(RunPerlTests()) +self.addStep(RunBindingsTests()) +self.addStep(ArchiveTestResults()) +self.addStep(UploadTestResults()) +self.addStep(self.ExtractTestResultsClass()) if platf
[webkit-changes] [120351] trunk/Tools
Title: [120351] trunk/Tools Revision 120351 Author o...@webkit.org Date 2012-06-14 13:02:01 -0700 (Thu, 14 Jun 2012) Log Message Unhide login form on the build.webkit.org https://bugs.webkit.org/show_bug.cgi?id=88981 Reviewed by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/public_html/default.css: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css (120350 => 120351) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css 2012-06-14 19:52:56 UTC (rev 120350) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css 2012-06-14 20:02:01 UTC (rev 120351) @@ -1,362 +1,367 @@ -div.header { display: none; } body > hr { display: none; } div.content h1 { display: none; } body.interface { - background: url(bg_gradient.jpg) repeat-x; - font-family: Verdana, Cursor; - font-size: 10px; - font-weight: bold; - background-color: #fff; - color: #333; +background: url(bg_gradient.jpg) repeat-x; +font-family: Verdana, Cursor; +font-size: 10px; +font-weight: bold; +background-color: #fff; +color: #333; } +.auth { +position: absolute; +top: 5px; +right: 40px; +} + a:link,a:visited,a:active { - color: #444; +color: #444; } table { - border-spacing: 1px 1px; +border-spacing: 1px 1px; } table td { - padding: 3px 2px 3px 2px; +padding: 3px 2px 3px 2px; } .Project { - min-width: 6em; +min-width: 6em; } .LastBuild,.Activity { - padding: 0 0 0 4px; +padding: 0 0 0 4px; } /* Chromium Specific styles */ div.BuildResultInfo { - color: #444; +color: #444; } div.Announcement { - margin-bottom: 1em; +margin-bottom: 1em; } div.Announcement>a:hover { - color: black; +color: black; } div.Announcement>div.Notice { - background-color: #afdaff; - padding: 0.5em; - font-size: 16px; - text-align: center; +background-color: #afdaff; +padding: 0.5em; +font-size: 16px; +text-align: center; } div.Announcement>div.Open { - border: 3px solid #8fdf5f; - padding: 0.5em; - font-size: 16px; - text-align: center; +border: 3px solid #8fdf5f; +padding: 0.5em; +font-size: 16px; +text-align: center; } div.Announcement>div.Closed { - border: 5px solid #e98080; - padding: 0.5em; - font-size: 24px; - font-weight: bold; - text-align: center; +border: 5px solid #e98080; +padding: 0.5em; +font-size: 24px; +font-weight: bold; +text-align: center; } td.Time { - color: #000; - border-bottom: 1px solid #aaa; - background-color: #eee; +color: #000; +border-bottom: 1px solid #aaa; +background-color: #eee; } td.Activity,td.Change,td.Builder { - color: #33; - background-color: #CC; +color: #33; +background-color: #CC; } td.Change { - border-radius: 5px; - -webkit-border-radius: 5px; - -moz-border-radius: 5px; +border-radius: 5px; +-webkit-border-radius: 5px; +-moz-border-radius: 5px; } td.Event { - color: #777; - background-color: #ddd; - border-radius: 5px; - -webkit-border-radius: 5px; - -moz-border-radius: 5px; +color: #777; +background-color: #ddd; +border-radius: 5px; +-webkit-border-radius: 5px; +-moz-border-radius: 5px; } td.Activity { - border-top-left-radius: 10px; - -webkit-border-top-left-radius: 10px; - -moz-border-radius-topleft: 10px; - min-height: 20px; - padding: 2px 0 2px 0; +border-top-left-radius: 10px; +-webkit-border-top-left-radius: 10px; +-moz-border-radius-topleft: 10px; +min-height: 20px; +padding: 2px 0 2px 0; } td.idle,td.waiting,td.offline,td.building { - border-top-left-radius: 0px; - -webkit-border-top-left-radius: 0px; - -moz-border-radius-topleft: 0px; +border-top-left-radius: 0px; +-webkit-border-top-left-radius: 0px; +-moz-border-radius-topleft: 0px; } .LastBuild { - border-top-left-radius: 5px; - -webkit-border-top-left-radius: 5px; - -moz-border-radius-topleft: 5px; - border-top-right-radius: 5px; - -webkit-border-top-right-radius: 5px; - -moz-border-radius-topright: 5px; +border-top-left-radius: 5px; +-webkit-border-top-left-radius: 5px; +-moz-border-radius-topleft: 5px; +border-top-right-radius: 5px; +-webkit-border-top-right-radius: 5px; +-moz-border-radius-topright: 5px; } /* Console view styles */ td.DevRev { - padding: 4px 8px 4px 8px; - color: #33; - border-top-left-radius: 5px; - -webkit-border-top-left-radius: 5px; - -moz-border-radius-topleft: 5px; - background-color: #eee; - width: 1%; +padding: 4px 8px 4px 8px; +color: #33; +border-top-left-radius: 5px; +-webkit-border-top-left-radius: 5px; +-moz-border-radius-topleft: 5px; +background-color: #eee; +width: 1%; } td.DevRevCollapse { - border-bottom-left-radius: 5px; - -webkit-borde
[webkit-changes] [120349] trunk/Tools
Title: [120349] trunk/Tools Revision 120349 Author dpra...@chromium.org Date 2012-06-14 12:43:05 -0700 (Thu, 14 Jun 2012) Log Message new-run-webkit-tests doesn't find similar platform tests for a keyword https://bugs.webkit.org/show_bug.cgi?id=37956 Reviewed by Ryosuke Niwa. This patches adds support for NRWT so that if you type "new-run-webkit-tests foo" it will run all the tests in foo as well as platform/foo for all of the platforms that are normally searched (this only applies to directories, not to individual tests). * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.collect_tests): * Scripts/webkitpy/layout_tests/port/base.py: (Port.tests): (Port): (Port._expanded_paths): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_no_http_tests): (MainTest): (MainTest.test_platform_tests_are_found): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py Diff Modified: trunk/Tools/ChangeLog (120348 => 120349) --- trunk/Tools/ChangeLog 2012-06-14 19:40:06 UTC (rev 120348) +++ trunk/Tools/ChangeLog 2012-06-14 19:43:05 UTC (rev 120349) @@ -1,5 +1,28 @@ 2012-06-14 Dirk Pranke +new-run-webkit-tests doesn't find similar platform tests for a keyword +https://bugs.webkit.org/show_bug.cgi?id=37956 + +Reviewed by Ryosuke Niwa. + +This patches adds support for NRWT so that if you type +"new-run-webkit-tests foo" it will run all the tests in foo as +well as platform/foo for all of the platforms that are normally +searched (this only applies to directories, not to individual tests). + +* Scripts/webkitpy/layout_tests/controllers/manager.py: +(Manager.collect_tests): +* Scripts/webkitpy/layout_tests/port/base.py: +(Port.tests): +(Port): +(Port._expanded_paths): +* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: +(MainTest.test_no_http_tests): +(MainTest): +(MainTest.test_platform_tests_are_found): + +2012-06-14 Dirk Pranke + NRWT should honor --skipped=[default|ignore|only], like ORWT does https://bugs.webkit.org/show_bug.cgi?id=66308 Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (120348 => 120349) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-06-14 19:40:06 UTC (rev 120348) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-06-14 19:43:05 UTC (rev 120349) @@ -496,9 +496,23 @@ return reftest_list.get(self._filesystem.join(self.layout_tests_dir(), test_name), []) def tests(self, paths): -"""Return the list of tests found.""" -return self._real_tests(paths).union(self._virtual_tests(paths, self.populated_virtual_test_suites())) +"""Return the list of tests found. Both generic and platform-specific tests matching paths should be returned.""" +expanded_paths = self._expanded_paths(paths) +return self._real_tests(expanded_paths).union(self._virtual_tests(expanded_paths, self.populated_virtual_test_suites())) +def _expanded_paths(self, paths): +expanded_paths = [] +fs = self._filesystem +all_platform_dirs = [path for path in fs.glob(fs.join(self.layout_tests_dir(), 'platform', '*')) if fs.isdir(path)] +for path in paths: +expanded_paths.append(path) +if self.test_isdir(path) and not path.startswith('platform'): +for platform_dir in all_platform_dirs: +if fs.isdir(fs.join(platform_dir, path)): +expanded_paths.append(self.relative_test_filename(fs.join(platform_dir, path))) + +return expanded_paths + def _real_tests(self, paths): # When collecting test cases, skip these directories skipped_directories = set(['.svn', '_svn', 'resources', 'script-tests', 'reference', 'reftest']) Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (120348 => 120349) --- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2012-06-14 19:40:06 UTC (rev 120348) +++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2012-06-14 19:43:05 UTC (rev 120349) @@ -881,7 +881,11 @@ self.assertTrue(MainTest.has_test_of_type(batch_tests_run_http, 'http')) self.assertTrue(MainTest.has_test_of_type(batch_tests_run_http, 'websocket')) +def test_platform_tests_are_found(self): +tests_run = get_tests_run(['http'], tests_included=True, flatten_batches=True) +self.assertTrue('platform/test-snow-leopard/http/test.html' in tests_run) + class EndToEndTest(unittest.TestCase): def parse_full_results(self, full_results_text): json_to_eval = full_results_text.replace("ADD_RESULTS(", "").replace(");", "") __
[webkit-changes] [120348] trunk/Tools
Title: [120348] trunk/Tools Revision 120348 Author dpra...@chromium.org Date 2012-06-14 12:40:06 -0700 (Thu, 14 Jun 2012) Log Message NRWT should honor --skipped=[default|ignore|only], like ORWT does https://bugs.webkit.org/show_bug.cgi?id=66308 Reviewed by Ryosuke Niwa. This patch adds support for ORWT's --skipped=(default|ignore|only) flag and cleans up the interaction between that and --ignore. Individual tests (but not directories) explicitly listed on the command line will always be run regardless of what is passed for --skipped and --ignore. This patch also changes the "found" and "running" log messages since it wasn't clear how the skipped tests were included in those numbers. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.__init__): (Manager.collect_tests): (Manager.prepare_lists_and_print_output): * Scripts/webkitpy/layout_tests/port/test.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): (parse_args): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_ignore_flag): (MainTest): (MainTest.test_skipped_flag): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py Diff Modified: trunk/Tools/ChangeLog (120347 => 120348) --- trunk/Tools/ChangeLog 2012-06-14 19:24:35 UTC (rev 120347) +++ trunk/Tools/ChangeLog 2012-06-14 19:40:06 UTC (rev 120348) @@ -1,3 +1,33 @@ +2012-06-14 Dirk Pranke + +NRWT should honor --skipped=[default|ignore|only], like ORWT does +https://bugs.webkit.org/show_bug.cgi?id=66308 + +Reviewed by Ryosuke Niwa. + +This patch adds support for ORWT's --skipped=(default|ignore|only) +flag and cleans up the interaction between that and --ignore. + +Individual tests (but not directories) explicitly listed on the +command line will always be run regardless of what is passed +for --skipped and --ignore. + +This patch also changes the "found" and "running" log messages +since it wasn't clear how the skipped tests were included in those numbers. + +* Scripts/webkitpy/layout_tests/controllers/manager.py: +(Manager.__init__): +(Manager.collect_tests): +(Manager.prepare_lists_and_print_output): +* Scripts/webkitpy/layout_tests/port/test.py: +* Scripts/webkitpy/layout_tests/run_webkit_tests.py: +(_set_up_derived_options): +(parse_args): +* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: +(MainTest.test_ignore_flag): +(MainTest): +(MainTest.test_skipped_flag): + 2012-06-14 Takashi Toyoshima new-run-webkit-websocketserver must handle TLS related arguments Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (120347 => 120348) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-06-14 19:24:35 UTC (rev 120347) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-06-14 19:40:06 UTC (rev 120348) @@ -316,6 +316,8 @@ # a set of test files, and the same tests as a list +self._paths = set() + # FIXME: Rename to test_names. self._test_files = set() self._test_files_list = None @@ -340,6 +342,7 @@ paths = self._strip_test_dir_prefixes(args) if self._options.test_list: paths += self._strip_test_dir_prefixes(read_test_files(self._filesystem, self._options.test_list, self._port.TEST_PATH_SEPARATOR)) +self._paths = set(paths) self._test_files = self._port.tests(paths) def _strip_test_dir_prefixes(self, paths): @@ -456,25 +459,41 @@ # Remove skipped - both fixable and ignored - files from the # top-level list of files to test. +found_test_files = set(self._test_files) num_all_test_files = len(self._test_files) -self._printer.print_expected("Found: %d tests" % (len(self._test_files))) + +skipped = self._expectations.get_tests_with_result_type(test_expectations.SKIP) +if not self._options.http: +skipped.update(set(self._http_tests())) + +if self._options.skipped == 'only': +self._test_files = self._test_files.intersection(skipped) +elif self._options.skipped == 'default': +self._test_files -= skipped +elif self._options.skipped == 'ignore': +pass # just to be clear that we're ignoring the skip list. + +if self._options.skip_failing_tests: +self._test_files -= self._expectations.get_tests_with_result_type(test_expectations.FAIL) +self._test_files -= self._expectations.get_tests_with_result_type(test_expectations.FLAKY) + +# now
[webkit-changes] [120347] trunk/Source/WebCore
Title: [120347] trunk/Source/WebCore Revision 120347 Author commit-qu...@webkit.org Date 2012-06-14 12:24:35 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: Remove devtoolsInjectedScript hidden property https://bugs.webkit.org/show_bug.cgi?id=89087 We use the devtoolsInjectedScript hidden property to reference a InjectedScript object for a given ScriptState, but we also have the same reference in the InjectedScriptManager's hash maps. Just use the hash maps and remove the hidden property from the global object. Patch by Andrey Adaikin on 2012-06-14 Reviewed by Pavel Feldman. * bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren): * bindings/js/JSDOMGlobalObject.h: (JSDOMGlobalObject): * bindings/js/JSInjectedScriptManager.cpp: (WebCore::InjectedScriptManager::createInjectedScript): * bindings/v8/V8HiddenPropertyName.h: (WebCore): * bindings/v8/custom/V8InjectedScriptManager.cpp: * inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::discardInjectedScripts): (WebCore::InjectedScriptManager::discardInjectedScriptsFor): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore): (WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation): * inspector/InjectedScriptManager.h: (InjectedScriptManager): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.h trunk/Source/WebCore/bindings/js/JSInjectedScriptManager.cpp trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptManager.cpp trunk/Source/WebCore/inspector/InjectedScriptManager.cpp trunk/Source/WebCore/inspector/InjectedScriptManager.h Diff Modified: trunk/Source/WebCore/ChangeLog (120346 => 120347) --- trunk/Source/WebCore/ChangeLog 2012-06-14 18:54:13 UTC (rev 120346) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 19:24:35 UTC (rev 120347) @@ -1,3 +1,32 @@ +2012-06-14 Andrey Adaikin + +Web Inspector: Remove devtoolsInjectedScript hidden property +https://bugs.webkit.org/show_bug.cgi?id=89087 + +We use the devtoolsInjectedScript hidden property to reference a InjectedScript object +for a given ScriptState, but we also have the same reference in the InjectedScriptManager's +hash maps. Just use the hash maps and remove the hidden property from the global object. + +Reviewed by Pavel Feldman. + +* bindings/js/JSDOMGlobalObject.cpp: +(WebCore::JSDOMGlobalObject::visitChildren): +* bindings/js/JSDOMGlobalObject.h: +(JSDOMGlobalObject): +* bindings/js/JSInjectedScriptManager.cpp: +(WebCore::InjectedScriptManager::createInjectedScript): +* bindings/v8/V8HiddenPropertyName.h: +(WebCore): +* bindings/v8/custom/V8InjectedScriptManager.cpp: +* inspector/InjectedScriptManager.cpp: +(WebCore::InjectedScriptManager::discardInjectedScripts): +(WebCore::InjectedScriptManager::discardInjectedScriptsFor): +(WebCore::InjectedScriptManager::injectedScriptFor): +(WebCore): +(WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation): +* inspector/InjectedScriptManager.h: +(InjectedScriptManager): + 2012-06-14 James Robinson [chromium] Move opaque rectangle tracking logic out of compositor core Modified: trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp (120346 => 120347) --- trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp 2012-06-14 18:54:13 UTC (rev 120346) +++ trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp 2012-06-14 19:24:35 UTC (rev 120347) @@ -20,7 +20,7 @@ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * */ @@ -93,9 +93,6 @@ JSDOMConstructorMap::iterator end2 = thisObject->constructors().end(); for (JSDOMConstructorMap::iterator it2 = thisObject->constructors().begin(); it2 != end2; ++it2) visitor.append(&it2->second); - -if (thisObject->m_injectedScript) -visitor.append(&thisObject->m_injectedScript); } void JSDOMGlobalObject::setCurrentEvent(Event* currentEvent) @@ -108,16 +105,6 @@ return m_currentEvent; } -void JSDOMGlobalObject::setInjectedScript(JSObject* injectedScript) -{ -m_injectedScript.setMayBeNull(globalData(), this, injectedScript); -} - -JSObject* JSDOMGlobalObject::injectedScript() const -{ -return m_injectedScript.get(); -} - JSDOMGlobalObject* toJSDOMGlobalObject(Document* document, JSC::ExecState* exec) { return toJSDOMWindow(document->frame(), currentWorld(exec)); Modified: trunk/Source/WebCore/bindin
[webkit-changes] [120345] trunk/LayoutTests
Title: [120345] trunk/LayoutTests Revision 120345 Author simon.fra...@apple.com Date 2012-06-14 11:37:41 -0700 (Thu, 14 Jun 2012) Log Message Rebaseline some Mac results after r120246. * platform/mac/media/audio-controls-rendering-expected.txt: * platform/mac/media/controls-after-reload-expected.txt: * platform/mac/media/controls-strict-expected.txt: * platform/mac/media/video-colorspace-yuv420-expected.txt: * platform/mac/media/video-colorspace-yuv422-expected.txt: * platform/mac/media/video-controls-rendering-expected.txt: * platform/mac/media/video-display-toggle-expected.txt: * platform/mac/media/video-no-audio-expected.txt: * platform/mac/media/video-playing-and-pause-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/media/audio-controls-rendering-expected.txt trunk/LayoutTests/platform/mac/media/controls-after-reload-expected.txt trunk/LayoutTests/platform/mac/media/controls-strict-expected.txt trunk/LayoutTests/platform/mac/media/video-colorspace-yuv420-expected.txt trunk/LayoutTests/platform/mac/media/video-colorspace-yuv422-expected.txt trunk/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt trunk/LayoutTests/platform/mac/media/video-display-toggle-expected.txt trunk/LayoutTests/platform/mac/media/video-no-audio-expected.txt trunk/LayoutTests/platform/mac/media/video-playing-and-pause-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (120344 => 120345) --- trunk/LayoutTests/ChangeLog 2012-06-14 18:33:03 UTC (rev 120344) +++ trunk/LayoutTests/ChangeLog 2012-06-14 18:37:41 UTC (rev 120345) @@ -1,3 +1,17 @@ +2012-06-14 Simon Fraser + +Rebaseline some Mac results after r120246. + +* platform/mac/media/audio-controls-rendering-expected.txt: +* platform/mac/media/controls-after-reload-expected.txt: +* platform/mac/media/controls-strict-expected.txt: +* platform/mac/media/video-colorspace-yuv420-expected.txt: +* platform/mac/media/video-colorspace-yuv422-expected.txt: +* platform/mac/media/video-controls-rendering-expected.txt: +* platform/mac/media/video-display-toggle-expected.txt: +* platform/mac/media/video-no-audio-expected.txt: +* platform/mac/media/video-playing-and-pause-expected.txt: + 2012-06-14 Justin Novosad [Chromium] webkitImageSmoothingEnabled canvas property does not work on redraw Modified: trunk/LayoutTests/platform/mac/media/audio-controls-rendering-expected.txt (120344 => 120345) --- trunk/LayoutTests/platform/mac/media/audio-controls-rendering-expected.txt 2012-06-14 18:33:03 UTC (rev 120344) +++ trunk/LayoutTests/platform/mac/media/audio-controls-rendering-expected.txt 2012-06-14 18:37:41 UTC (rev 120345) @@ -23,11 +23,10 @@ RenderDeprecatedFlexibleBox {DIV} at (49,5) size 126x15 RenderSlider {INPUT} at (0,2) size 126x13 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 126x13 - RenderBlock {DIV} at (0,2) size 116x8 - RenderBlock {DIV} at (116,2) size 10x8 + RenderBlock {DIV} at (0,0) size 116x13 +RenderBlock {DIV} at (0,0) size 10x8 + RenderBlock {DIV} at (116,0) size 10x8 RenderBlock {DIV} at (175,6) size 25x12 -layer at (57,51) size 10x8 - RenderBlock (relative positioned) {DIV} at (0,0) size 10x8 layer at (185,48) size 14x12 RenderButton zI: 1 {INPUT} at (2,0) size 14x12 layer at (8,85) size 320x25 @@ -39,8 +38,9 @@ RenderDeprecatedFlexibleBox {DIV} at (49,5) size 246x15 RenderSlider {INPUT} at (45,2) size 156x13 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 156x13 - RenderBlock {DIV} at (0,2) size 146x8 - RenderBlock {DIV} at (146,2) size 10x8 + RenderBlock {DIV} at (0,0) size 146x13 +RenderBlock {DIV} at (0,0) size 10x8 + RenderBlock {DIV} at (146,0) size 10x8 RenderBlock {DIV} at (295,6) size 25x12 layer at (57,92) size 45x11 RenderDeprecatedFlexibleBox {DIV} at (0,2) size 45x11 [color=#FF] @@ -52,8 +52,6 @@ RenderBlock (anonymous) at (7,0) size 31x11 RenderText {#text} at (0,0) size 31x11 text run at (0,0) width 31: "-00:07" -layer at (102,94) size 10x8 - RenderBlock (relative positioned) {DIV} at (0,0) size 10x8 layer at (305,91) size 14x12 RenderButton zI: 1 {INPUT} at (2,0) size 14x12 layer at (8,128) size 320x100 @@ -67,8 +65,9 @@ RenderDeprecatedFlexibleBox {DIV} at (49,5) size 246x15 RenderSlider {INPUT} at (45,2) size 156x13 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 156x13 - RenderBlock {DIV} at (0,2) size 146x8 - RenderBlock {DIV} at (146,2) size 10x8 + RenderBlock {DIV} at (0,0) size 146x13 +RenderBlock {DIV} at (0,0) size 10x8 + RenderBlock {DIV} at (146,0) size 10x8 RenderBlock {DIV} at (295,6) size 25x12 layer at (57,210) size 45x11 RenderDeprecatedFlexibleBox {DIV} at (0,2) size 45x11 [color=#FF] @@ -80,7 +79,5
[webkit-changes] [120344] trunk
Title: [120344] trunk Revision 120344 Author commit-qu...@webkit.org Date 2012-06-14 11:33:03 -0700 (Thu, 14 Jun 2012) Log Message [Chromium] webkitImageSmoothingEnabled canvas property does not work on redraw https://bugs.webkit.org/show_bug.cgi?id=89018 Patch by Justin Novosad on 2012-06-14 Reviewed by Stephen White. Source/WebCore: Test: fast/canvas/canvas-imageSmoothingEnabled-repaint.html When an accelerated canvas layer prepares its texture for the compositor, it must send a notification to skia to invalidate texture proprties that are cached by skia, since the compositor may modify them. The use case this fixes is when a canvas to canvas copy is performed with webkitImageSmoothingEnabled=false on the destination canvas. The backing texture of the source canvas will be set to "nearest" filtering by skia in order to perform the copy. Then, the compositor sets filtering back to "linear" when the source canvas is drawn. Skia is designed to only update GL attributes when required, so errors occur when the skia-side GL state cache is out of sync. * platform/graphics/chromium/Canvas2DLayerBridge.cpp: (WebCore::Canvas2DLayerBridge::prepareTexture): Source/WebKit/chromium: Rolling chromium DEPS to 141884 * DEPS: LayoutTests: New layout test that verifies that disabling image smoothing on a 2d canvas continues to work after multiple paint cycles. * fast/canvas/canvas-imageSmoothingEnabled-repaint-expected.txt: Added. * fast/canvas/canvas-imageSmoothingEnabled-repaint.html: Added. * fast/canvas/script-tests/canvas-imageSmoothingEnabled-repaint.js: Added. (draw): (testResult): (TestControllerPaint): (BrowserPaint): (onLoadHandler): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/DEPS Added Paths trunk/LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-repaint-expected.txt trunk/LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-repaint.html trunk/LayoutTests/fast/canvas/script-tests/canvas-imageSmoothingEnabled-repaint.js Diff Modified: trunk/LayoutTests/ChangeLog (120343 => 120344) --- trunk/LayoutTests/ChangeLog 2012-06-14 18:23:09 UTC (rev 120343) +++ trunk/LayoutTests/ChangeLog 2012-06-14 18:33:03 UTC (rev 120344) @@ -1,3 +1,22 @@ +2012-06-14 Justin Novosad + +[Chromium] webkitImageSmoothingEnabled canvas property does not work on redraw +https://bugs.webkit.org/show_bug.cgi?id=89018 + +Reviewed by Stephen White. + +New layout test that verifies that disabling image smoothing on a 2d +canvas continues to work after multiple paint cycles. + +* fast/canvas/canvas-imageSmoothingEnabled-repaint-expected.txt: Added. +* fast/canvas/canvas-imageSmoothingEnabled-repaint.html: Added. +* fast/canvas/script-tests/canvas-imageSmoothingEnabled-repaint.js: Added. +(draw): +(testResult): +(TestControllerPaint): +(BrowserPaint): +(onLoadHandler): + 2012-06-14 Stephen Chenney [svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations Added: trunk/LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-repaint-expected.txt (0 => 120344) --- trunk/LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-repaint-expected.txt (rev 0) +++ trunk/LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-repaint-expected.txt 2012-06-14 18:33:03 UTC (rev 120344) @@ -0,0 +1,16 @@ +Tests that disabling the imageSmoothingEnabled attribute still works after multiple repaints + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +Test that the image is not filtered +PASS left_of_center_pixel.data[0] is 255 +PASS left_of_center_pixel.data[1] is 0 +PASS left_of_center_pixel.data[2] is 0 +PASS right_of_center_pixel.data[0] is 0 +PASS right_of_center_pixel.data[1] is 255 +PASS right_of_center_pixel.data[2] is 0 +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-repaint.html (0 => 120344) --- trunk/LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-repaint.html (rev 0) +++ trunk/LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-repaint.html 2012-06-14 18:33:03 UTC (rev 120344) @@ -0,0 +1,12 @@ + + + +
[webkit-changes] [120343] trunk/LayoutTests
Title: [120343] trunk/LayoutTests Revision 120343 Author schen...@chromium.org Date 2012-06-14 11:23:09 -0700 (Thu, 14 Jun 2012) Log Message [svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations https://bugs.webkit.org/show_bug.cgi?id=64966 Unreviewed suppression of crashing tests: svg/batik/text/textDecoration.svg svg/batik/text/textEffect3.svg * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120342 => 120343) --- trunk/LayoutTests/ChangeLog 2012-06-14 18:06:39 UTC (rev 120342) +++ trunk/LayoutTests/ChangeLog 2012-06-14 18:23:09 UTC (rev 120343) @@ -1,3 +1,14 @@ +2012-06-14 Stephen Chenney + +[svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations +https://bugs.webkit.org/show_bug.cgi?id=64966 + +Unreviewed suppression of crashing tests: +svg/batik/text/textDecoration.svg +svg/batik/text/textEffect3.svg + +* platform/chromium/TestExpectations: + 2012-06-14 Jon Honeycutt Unskip some now-passing tests. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120342 => 120343) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-14 18:06:39 UTC (rev 120342) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-14 18:23:09 UTC (rev 120343) @@ -1200,6 +1200,9 @@ BUGWK60118 MAC : svg/dom/SVGScriptElement/script-set-href.svg = PASS TEXT +BUGWK64966 DEBUG : svg/batik/text/textDecoration.svg = CRASH +BUGWK64966 DEBUG : svg/batik/text/textEffect3.svg = CRASH + // Introduced due to BUGWK53512, fails under Skia right now BUGWK65939 : svg/custom/getBBox-path.svg = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120342] trunk/Tools
Title: [120342] trunk/Tools Revision 120342 Author toyos...@chromium.org Date 2012-06-14 11:06:39 -0700 (Thu, 14 Jun 2012) Log Message new-run-webkit-websocketserver must handle TLS related arguments https://bugs.webkit.org/show_bug.cgi?id=89079 Reviewed by Dirk Pranke. PyWebSocket class must accept private_key, certificate, and ca_certificate arguments and pass them to launching pywebsocket. Also add ca_certificate handling to new-run-webkit-websocketserver. * Scripts/new-run-webkit-websocketserver: (main): * Scripts/webkitpy/layout_tests/servers/websocket_server.py: (PyWebSocket.__init__): (PyWebSocket._prepare_config): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/new-run-webkit-websocketserver trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py Diff Modified: trunk/Tools/ChangeLog (120341 => 120342) --- trunk/Tools/ChangeLog 2012-06-14 18:02:05 UTC (rev 120341) +++ trunk/Tools/ChangeLog 2012-06-14 18:06:39 UTC (rev 120342) @@ -1,3 +1,20 @@ +2012-06-14 Takashi Toyoshima + +new-run-webkit-websocketserver must handle TLS related arguments +https://bugs.webkit.org/show_bug.cgi?id=89079 + +Reviewed by Dirk Pranke. + +PyWebSocket class must accept private_key, certificate, and +ca_certificate arguments and pass them to launching pywebsocket. +Also add ca_certificate handling to new-run-webkit-websocketserver. + +* Scripts/new-run-webkit-websocketserver: +(main): +* Scripts/webkitpy/layout_tests/servers/websocket_server.py: +(PyWebSocket.__init__): +(PyWebSocket._prepare_config): + 2012-06-14 Qi Zhang Unreviewed. Update my email. Modified: trunk/Tools/Scripts/new-run-webkit-websocketserver (120341 => 120342) --- trunk/Tools/Scripts/new-run-webkit-websocketserver 2012-06-14 18:02:05 UTC (rev 120341) +++ trunk/Tools/Scripts/new-run-webkit-websocketserver 2012-06-14 18:06:39 UTC (rev 120342) @@ -55,6 +55,9 @@ default='', help='TLS private key file.') option_parser.add_option('-c', '--certificate', dest='certificate', default='', help='TLS certificate file.') +option_parser.add_option('--ca-certificate', dest='ca_certificate', + default='', help='TLS CA certificate file for ' + 'client authentication.') option_parser.add_option('--chromium', action='', dest='chromium', default=False, @@ -88,6 +91,8 @@ kwds['private_key'] = options.private_key if options.certificate: kwds['certificate'] = options.certificate +if options.ca_certificate: +kwds['ca_certificate'] = options.ca_certificate if options.pidfile: kwds['pidfile'] = options.pidfile Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py (120341 => 120342) --- trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2012-06-14 18:02:05 UTC (rev 120341) +++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2012-06-14 18:06:39 UTC (rev 120342) @@ -51,6 +51,7 @@ class PyWebSocket(http_server.Lighttpd): def __init__(self, port_obj, output_dir, port=_DEFAULT_WS_PORT, root=None, use_tls=False, + private_key=None, certificate=None, ca_certificate=None, pidfile=None): """Args: output_dir: the absolute path to the layout test result directory @@ -70,8 +71,15 @@ if self._use_tls: self._name = 'pywebsocket_secure' -self._private_key = self._pem_file -self._certificate = self._pem_file +if private_key: +self._private_key = private_key +else: +self._private_key = self._pem_file +if certificate: +self._certificate = certificate +else: +self._certificate = self._pem_file +self._ca_certificate = ca_certificate if self._port: self._port = int(self._port) self._wsin = None @@ -137,6 +145,9 @@ if self._use_tls: start_cmd.extend(['-t', '-k', self._private_key, '-c', self._certificate]) +if self._ca_certificate: +start_cmd.append('--ca-certificate') +start_cmd.append(self._ca_certificate) self._start_cmd = start_cmd server_name = self._filesystem.basename(pywebsocket_script) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120341] trunk
Title: [120341] trunk Revision 120341 Author jhoneyc...@apple.com Date 2012-06-14 11:02:05 -0700 (Thu, 14 Jun 2012) Log Message 2012-06-14 Jon Honeycutt Fix some failing tests on Windows by resetting the page scale factor between tests. https://bugs.webkit.org/show_bug.cgi?id=89078 Reviewed by Dirk Pranke. WebCore: * testing/Internals.cpp: (WebCore::Internals::reset): Set the scale factor to 1.0. LayoutTests: Unskip some now-passing tests. https://bugs.webkit.org/show_bug.cgi?id=89078 * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/testing/Internals.cpp Diff Modified: trunk/LayoutTests/ChangeLog (120340 => 120341) --- trunk/LayoutTests/ChangeLog 2012-06-14 17:45:05 UTC (rev 120340) +++ trunk/LayoutTests/ChangeLog 2012-06-14 18:02:05 UTC (rev 120341) @@ -1,3 +1,10 @@ +2012-06-14 Jon Honeycutt + +Unskip some now-passing tests. +https://bugs.webkit.org/show_bug.cgi?id=89078 + +* platform/win/Skipped: + 2012-06-14 Alexey Proskuryakov [CFNetwork] XMLHttpRequest incorrectly returns cached responses even when there is a Vary header field Modified: trunk/LayoutTests/platform/win/Skipped (120340 => 120341) --- trunk/LayoutTests/platform/win/Skipped 2012-06-14 17:45:05 UTC (rev 120340) +++ trunk/LayoutTests/platform/win/Skipped 2012-06-14 18:02:05 UTC (rev 120341) @@ -1875,321 +1875,18 @@ # https://bugs.webkit.org/show_bug.cgi?id=85811 fast/events/message-port-clone.html -# Need rebaseling / checking - skipped en masse to get the bots green again -css1/basic/comments.html -css1/basic/containment.html -css1/basic/id_as_selector.html -css1/basic/inheritance.html -css1/box_properties/border_bottom.html -css1/box_properties/border_bottom_width.html -css1/box_properties/border_left.html -css1/box_properties/border_left_width.html -css1/box_properties/border_right_inline.html -css1/box_properties/border_right_width.html -css1/box_properties/border_top.html -css1/box_properties/border_top_width.html -css1/box_properties/border_width.html -css1/box_properties/clear.html -css1/box_properties/clear_float.html -css1/box_properties/float_elements_in_series.html -css1/box_properties/height.html -css1/box_properties/margin.html -css1/box_properties/margin_inline.html -css1/box_properties/margin_left.html -css1/box_properties/margin_right.html -css1/box_properties/padding_inline.html -css1/box_properties/padding_left.html -css1/box_properties/padding_right.html -css1/cascade/cascade_order.html -css1/classification/display.html -css1/classification/white_space.html -css1/color_and_background/background.html -css1/color_and_background/background_attachment.html -css1/color_and_background/background_repeat.html -css1/font_properties/font_weight.html -css1/formatting_model/horizontal_formatting.html -css1/formatting_model/inline_elements.html -css1/pseudo/anchor.html -css1/pseudo/firstletter.html -css1/pseudo/firstline.html -css1/pseudo/multiple_pseudo_elements.html -css1/text_properties/text_decoration.html -css1/text_properties/text_transform.html -css1/text_properties/word_spacing.html -css2.1/t0803-c5502-mrgn-r-02-c.html -css2.1/t0803-c5505-mrgn-02-c.html -css2.1/t0905-c5525-fltclr-00-c-ag.html -css2.1/t0905-c5525-fltmrgn-00-c-ag.html -css2.1/t0905-c5525-fltwidth-00-c-g.html -css2.1/t0905-c5526-fltclr-00-c-ag.html -css2.1/t1002-c5523-width-02-b-g.html -css2.1/t1202-counters-08-b.html -css2.1/t1508-c527-font-07-b.html -css2.1/t080301-c411-vt-mrgn-00-b.html +# Need rebaselining / checking - skipped en masse to get the bots green again css2.1/20110323/c543-txt-decor-000.html fast/block/float/float-in-float-hit-testing.html fast/block/float/overhanging-tall-block.html -fast/block/positioning/fixed-position-stacking-context.html fast/css/align-positioned-object-on-resize.html fast/css/text-transform-select.html fast/css/zoom-body-scroll.html fast/dom/34176.html -fast/dom/importNodeHTML.html -fast/dom/importNodeXML.xhtml -fast/dom/inner-text.html -fast/dom/isindex-001.html -fast/dom/isindex-002.html -fast/dom/outerText.html -fast/dom/replaced-image-map.html -fast/dom/right-overflow-in-rtl.html -fast/dom/row-inner-text.html -fast/dom/rtl-scroll-to-leftmost-and-resize.html -fast/dom/scroll-element-to-rect-centered.html -fast/dom/scroll-element-to-rect.html -fast/dom/scroll-reveal-left-overflow.html -fast/dom/scroll-reveal-top-overflow.html -fast/dom/tab-in-right-alignment.html fast/dom/title-directionality-removeChild.html -fast/dom/vertical-scrollbar-in-rtl.html -fast/dom/window-inner-size-scaling.html fast/dom/zoom-scroll-page-test.html -fast/dom/Document/CaretRangeFromPoint/basic.html -fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html -fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html -fast/dom/Doc
[webkit-changes] [120340] trunk/Source
Title: [120340] trunk/Source Revision 120340 Author commit-qu...@webkit.org Date 2012-06-14 10:45:05 -0700 (Thu, 14 Jun 2012) Log Message Register fixed position layers with ScrollingCoordinator https://bugs.webkit.org/show_bug.cgi?id=78864 Patch by Sami Kyostila on 2012-06-14 Reviewed by James Robinson. This patch makes ScrollingCoordinator aware of page elements that are either fixed positioned directly or through their ancestors and that also have their own composited backing layers. This allows the ScrollingCoordinator implementation to potentially enable fast scrolling even if there are fixed elements on the page, because the compositor can automatically reposition the fixed element layers after scrolling. Since fixed position layers need to be explicitly supported by the ScrollingCoordinator implementation, we add a new supportsFixedPositionLayers() query for checking this. * page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject): * page/FrameView.h: (FrameView): (WebCore::FrameView::fixedObjects): (WebCore::FrameView::hasFixedObjects): * page/scrolling/ScrollingCoordinator.cpp: (WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange): (WebCore::ScrollingCoordinator::hasNonLayerFixedObjects): (WebCore): (WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread): (WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPosition): (WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer): * page/scrolling/ScrollingCoordinator.h: (ScrollingCoordinator): * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: (WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPosition): (WebCore): (WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer): * rendering/RenderBox.cpp: (WebCore::RenderBox::willBeDestroyed): (WebCore::RenderBox::styleWillChange): * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore): (WebCore::RenderLayerCompositor::fixedPositionedByAncestor): (WebCore::RenderLayerCompositor::ensureRootLayer): * rendering/RenderLayerCompositor.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/FrameView.h trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h trunk/Source/WebCore/page/scrolling/ScrollingCoordinatorNone.cpp trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderLayerBacking.cpp trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp trunk/Source/WebCore/rendering/RenderLayerCompositor.h trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (120339 => 120340) --- trunk/Source/WebCore/ChangeLog 2012-06-14 17:42:18 UTC (rev 120339) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 17:45:05 UTC (rev 120340) @@ -1,3 +1,56 @@ +2012-06-14 Sami Kyostila + +Register fixed position layers with ScrollingCoordinator +https://bugs.webkit.org/show_bug.cgi?id=78864 + +Reviewed by James Robinson. + +This patch makes ScrollingCoordinator aware of page elements that are +either fixed positioned directly or through their ancestors and that +also have their own composited backing layers. This allows the +ScrollingCoordinator implementation to potentially enable fast +scrolling even if there are fixed elements on the page, because the +compositor can automatically reposition the fixed element layers after +scrolling. + +Since fixed position layers need to be explicitly supported by the +ScrollingCoordinator implementation, we add a new +supportsFixedPositionLayers() query for checking this. + +* page/FrameView.cpp: +(WebCore::FrameView::FrameView): +(WebCore::FrameView::useSlowRepaints): +(WebCore::FrameView::addFixedObject): +(WebCore::FrameView::removeFixedObject): +* page/FrameView.h: +(FrameView): +(WebCore::FrameView::fixedObjects): +(WebCore::FrameView::hasFixedObjects): +* page/scrolling/ScrollingCoordinator.cpp: +(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange): +(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects): +(WebCore): +
[webkit-changes] [120339] trunk
Title: [120339] trunk Revision 120339 Author a...@apple.com Date 2012-06-14 10:42:18 -0700 (Thu, 14 Jun 2012) Log Message [CFNetwork] XMLHttpRequest incorrectly returns cached responses even when there is a Vary header field https://bugs.webkit.org/show_bug.cgi?id=88925 Reviewed by David Kilzer. Test: http/tests/cache/xhr-vary-header.html * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willCacheResponse): Don't cache the response at all if there is a Vary header field. CFNetwork won't look at it if we allowed the response cached. * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::createNSURLConnection): [NSURLResponse copy] is mutable in practice, but we should be nice, and use -mutableCopy. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Same fix as in CFNet code. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm Added Paths trunk/LayoutTests/http/tests/cache/resources/xhr-vary-header-response.php trunk/LayoutTests/http/tests/cache/resources/xhr-vary-header-subframe.html trunk/LayoutTests/http/tests/cache/xhr-vary-header-expected.txt trunk/LayoutTests/http/tests/cache/xhr-vary-header.html Diff Modified: trunk/LayoutTests/ChangeLog (120338 => 120339) --- trunk/LayoutTests/ChangeLog 2012-06-14 17:06:45 UTC (rev 120338) +++ trunk/LayoutTests/ChangeLog 2012-06-14 17:42:18 UTC (rev 120339) @@ -1,3 +1,15 @@ +2012-06-14 Alexey Proskuryakov + +[CFNetwork] XMLHttpRequest incorrectly returns cached responses even when there is a Vary header field +https://bugs.webkit.org/show_bug.cgi?id=88925 + +Reviewed by David Kilzer. + +* http/tests/cache/resources/xhr-vary-header-response.php: Added. +* http/tests/cache/resources/xhr-vary-header-subframe.html: Added. +* http/tests/cache/xhr-vary-header-expected.txt: Added. +* http/tests/cache/xhr-vary-header.html: Added. + 2012-06-14 Simon Pena [GTK] Update TestExpectations with tests crashing in 64bits Debug build Added: trunk/LayoutTests/http/tests/cache/resources/xhr-vary-header-response.php (0 => 120339) --- trunk/LayoutTests/http/tests/cache/resources/xhr-vary-header-response.php (rev 0) +++ trunk/LayoutTests/http/tests/cache/resources/xhr-vary-header-response.php 2012-06-14 17:42:18 UTC (rev 120339) @@ -0,0 +1,11 @@ + +response \ No newline at end of file Added: trunk/LayoutTests/http/tests/cache/resources/xhr-vary-header-subframe.html (0 => 120339) --- trunk/LayoutTests/http/tests/cache/resources/xhr-vary-header-subframe.html (rev 0) +++ trunk/LayoutTests/http/tests/cache/resources/xhr-vary-header-subframe.html 2012-06-14 17:42:18 UTC (rev 120339) @@ -0,0 +1,13 @@ + +function testSameOrigin() +{ +var req = new XMLHttpRequest; +req.open("GET", "xhr-vary-header-response.php"); +req._onload_=function() { parent.postMessage(req.responseText, "http://127.0.0.1:8000") } +req.send(); +} + +window._onmessage_ = function() { testSameOrigin() } + + +Make same origin request Property changes on: trunk/LayoutTests/http/tests/cache/resources/xhr-vary-header-subframe.html ___ Added: svn:mime-type Added: trunk/LayoutTests/http/tests/cache/xhr-vary-header-expected.txt (0 => 120339) --- trunk/LayoutTests/http/tests/cache/xhr-vary-header-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/cache/xhr-vary-header-expected.txt 2012-06-14 17:42:18 UTC (rev 120339) @@ -0,0 +1,11 @@ +Test that XMLHttpRequest doesn't return a wrong cached answer when there is a Vary header in response. + +Make cross origin request + +PASS responseText is 'Cross origin response' +PASS responseText is 'Same origin response' +PASS responseText is 'Cross origin response' +PASS successfullyParsed is true + +TEST COMPLETE + Property changes on: trunk/LayoutTests/http/tests/cache/xhr-vary-header-expected.txt ___ Added: svn:mime-type Added: svn:eol-style Added: trunk/LayoutTests/http/tests/cache/xhr-vary-header.html (0 => 120339) --- trunk/LayoutTests/http/tests/cache/xhr-vary-header.html (rev 0) +++ trunk/LayoutTests/http/tests/cache/xhr-vary-header.html 2012-06-14 17:42:18 UTC (rev 120339) @@ -0,0 +1,60 @@ +Test that XMLHttpRequest doesn't return a wrong cached answer when there is a Vary header in response. + + +window.jsTestIsAsync = true; + +if (location.protocol != "http:" || location.host != "127.0.0.1:8000") +debug("This test must be run from http://127.0.0.1:8000"); + +var testStep = 1; + +function testCrossOrigin() +{ +var req = new XMLHttpRequest; +req.ope
[webkit-changes] [120337] trunk/Source/WebCore
Title: [120337] trunk/Source/WebCore Revision 120337 Author commit-qu...@webkit.org Date 2012-06-14 10:00:38 -0700 (Thu, 14 Jun 2012) Log Message Change mute button and volume slider behaviour for new Chromium video controls. https://bugs.webkit.org/show_bug.cgi?id=88743 Patch by Silvia Pfeiffer on 2012-06-14 Reviewed by Eric Carlson. No new tests, final patch will contain the rebaselined tests. The Chrome video controls are receiving a visual update. This patch makes the mute button and the volume slider interact with each other. When the user mutes the video through clicking the mute button, the volume slider animates to 0% volume. Upon unmute, the previous volume level is restored. Further, when the user drags the volume slider thumb or clicks on the slider and the video is muted, the video unmutes and sets the volume to the user's chosen level. * html/shadow/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Add a member field to the volume slider to allow user interaction to unmute the video. (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Add the logic to unmute the video if the m_clearMutedOnUserInteraction member field is true. (WebCore::MediaControlVolumeSliderElement::setClearMutedOnUserInteraction): Add a member function to change the value of the m_clearMutedOnUserInteraction member field. * html/shadow/MediaControlElements.h: (MediaControlVolumeSliderElement): Add the setClearMutedOnUserInteraction member function and the m_clearMutedOnUserInteraction member field. * html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::create): Activate unmute on user interaction on the Chromium video volume slider. (WebCore::MediaControlRootElementChromium::changedMute): Add logic to set volume slider to 0 when muted and reset to volume when unmuted. * rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaVolumeSlider): Add logic to paint the volume slider active area as 0 when muted. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/shadow/MediaControlElements.cpp trunk/Source/WebCore/html/shadow/MediaControlElements.h trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp trunk/Source/WebCore/rendering/RenderMediaControlsChromium.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (120336 => 120337) --- trunk/Source/WebCore/ChangeLog 2012-06-14 16:58:05 UTC (rev 120336) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 17:00:38 UTC (rev 120337) @@ -1,3 +1,37 @@ +2012-06-14 Silvia Pfeiffer + +Change mute button and volume slider behaviour for new Chromium video controls. +https://bugs.webkit.org/show_bug.cgi?id=88743 + +Reviewed by Eric Carlson. + +No new tests, final patch will contain the rebaselined tests. + +The Chrome video controls are receiving a visual update. This patch makes the mute button and +the volume slider interact with each other. When the user mutes the video through clicking the +mute button, the volume slider animates to 0% volume. Upon unmute, the previous volume level +is restored. Further, when the user drags the volume slider thumb or clicks on the slider and +the video is muted, the video unmutes and sets the volume to the user's chosen level. + +* html/shadow/MediaControlElements.cpp: +(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): +Add a member field to the volume slider to allow user interaction to unmute the video. +(WebCore::MediaControlVolumeSliderElement::defaultEventHandler): +Add the logic to unmute the video if the m_clearMutedOnUserInteraction member field is true. +(WebCore::MediaControlVolumeSliderElement::setClearMutedOnUserInteraction): +Add a member function to change the value of the m_clearMutedOnUserInteraction member field. +* html/shadow/MediaControlElements.h: +(MediaControlVolumeSliderElement): +Add the setClearMutedOnUserInteraction member function and the m_clearMutedOnUserInteraction member field. +* html/shadow/MediaControlRootElementChromium.cpp: +(WebCore::MediaControlRootElementChromium::create): +Activate unmute on user interaction on the Chromium video volume slider. +(WebCore::MediaControlRootElementChromium::changedMute): +Add logic to set volume slider to 0 when muted and reset to volume when unmuted. +* rendering/RenderMediaControlsChromium.cpp: +(WebCore::paintMediaVolumeSlider): +Add logic to paint the volume slider active area as 0 when muted. + 2012-06-14 Vsevolod Vlasov Web Inspector: Breakpoints should not be set when UISourceCode content is diverged from VM version of the script. Modified: trunk/Source/WebCore/html/shadow/MediaControlElements.cpp (120336 => 120337) --- trunk/Source/WebCore/html/shadow/MediaContr
[webkit-changes] [120336] trunk/Source/WebCore
Title: [120336] trunk/Source/WebCore Revision 120336 Author vse...@chromium.org Date 2012-06-14 09:58:05 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: Breakpoints should not be set when UISourceCode content is diverged from VM version of the script. https://bugs.webkit.org/show_bug.cgi?id=89109 Reviewed by Pavel Feldman. * inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint): * inspector/front-end/_javascript_Source.js: (WebInspector._javascript_Source.prototype.isDivergedFromVM): (WebInspector._javascript_Source.prototype.workingCopyCommitted): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/BreakpointManager.js trunk/Source/WebCore/inspector/front-end/_javascript_Source.js Diff Modified: trunk/Source/WebCore/ChangeLog (120335 => 120336) --- trunk/Source/WebCore/ChangeLog 2012-06-14 16:57:15 UTC (rev 120335) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 16:58:05 UTC (rev 120336) @@ -1,5 +1,18 @@ 2012-06-14 Vsevolod Vlasov +Web Inspector: Breakpoints should not be set when UISourceCode content is diverged from VM version of the script. +https://bugs.webkit.org/show_bug.cgi?id=89109 + +Reviewed by Pavel Feldman. + +* inspector/front-end/BreakpointManager.js: +(WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint): +* inspector/front-end/_javascript_Source.js: +(WebInspector._javascript_Source.prototype.isDivergedFromVM): +(WebInspector._javascript_Source.prototype.workingCopyCommitted): + +2012-06-14 Vsevolod Vlasov + Web Inspector: DebuggerModel should support setting breakpoints without script by sourceURL only. https://bugs.webkit.org/show_bug.cgi?id=88988 Modified: trunk/Source/WebCore/inspector/front-end/BreakpointManager.js (120335 => 120336) --- trunk/Source/WebCore/inspector/front-end/BreakpointManager.js 2012-06-14 16:57:15 UTC (rev 120335) +++ trunk/Source/WebCore/inspector/front-end/BreakpointManager.js 2012-06-14 16:58:05 UTC (rev 120336) @@ -356,7 +356,7 @@ this._condition = condition; this._breakpointManager._storage._updateBreakpoint(this); -if (this._enabled) { +if (this._enabled && !this._primaryUILocation.uiSourceCode.isDivergedFromVM()) { this._setInDebugger(); return; } Modified: trunk/Source/WebCore/inspector/front-end/_javascript_Source.js (120335 => 120336) --- trunk/Source/WebCore/inspector/front-end/_javascript_Source.js 2012-06-14 16:57:15 UTC (rev 120335) +++ trunk/Source/WebCore/inspector/front-end/_javascript_Source.js 2012-06-14 16:58:05 UTC (rev 120336) @@ -180,11 +180,29 @@ }, /** + * @return {boolean} + */ +isDivergedFromVM: function() +{ +// FIXME: We should return true if this._isDivergedFromVM is set as well once we provide a way to set breakpoints after LiveEdit failure. +return this.isDirty(); +}, + +/** * @param {function(?string)} callback */ workingCopyCommitted: function(callback) { -WebInspector.DebuggerResourceBinding.setScriptSource(this, this.workingCopy(), callback); +/** + * @param {?string} error + */ +function innerCallback(error) +{ +this._isDivergedFromVM = !!error; +callback(error); +} + +WebInspector.DebuggerResourceBinding.setScriptSource(this, this.workingCopy(), innerCallback.bind(this)); }, /** ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120335] trunk/Source/WebCore
Title: [120335] trunk/Source/WebCore Revision 120335 Author vse...@chromium.org Date 2012-06-14 09:57:15 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: DebuggerModel should support setting breakpoints without script by sourceURL only. https://bugs.webkit.org/show_bug.cgi?id=88988 Reviewed by Pavel Feldman. This change allows setting all saved breakpoints in debugger model by url before the site with corresponding scripts was loaded (allows breaking in onload handler on first load). This change also simplifies implementation of snippets debugging. * inspector/front-end/BreakpointManager.js: * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/BreakpointManager.js trunk/Source/WebCore/inspector/front-end/DebuggerModel.js Diff Modified: trunk/Source/WebCore/ChangeLog (120334 => 120335) --- trunk/Source/WebCore/ChangeLog 2012-06-14 16:53:38 UTC (rev 120334) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 16:57:15 UTC (rev 120335) @@ -1,3 +1,18 @@ +2012-06-14 Vsevolod Vlasov + +Web Inspector: DebuggerModel should support setting breakpoints without script by sourceURL only. +https://bugs.webkit.org/show_bug.cgi?id=88988 + +Reviewed by Pavel Feldman. + +This change allows setting all saved breakpoints in debugger model by url before the site +with corresponding scripts was loaded (allows breaking in onload handler on first load). +This change also simplifies implementation of snippets debugging. + +* inspector/front-end/BreakpointManager.js: +* inspector/front-end/DebuggerModel.js: +(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation): + 2012-06-14 Pavel Feldman Web Inspector: refactor settings screen to move user agent and experiments out of general tab. Modified: trunk/Source/WebCore/inspector/front-end/BreakpointManager.js (120334 => 120335) --- trunk/Source/WebCore/inspector/front-end/BreakpointManager.js 2012-06-14 16:53:38 UTC (rev 120334) +++ trunk/Source/WebCore/inspector/front-end/BreakpointManager.js 2012-06-14 16:57:15 UTC (rev 120335) @@ -375,7 +375,11 @@ { var rawLocation = this._primaryUILocation.uiLocationToRawLocation(); var debuggerModelLocation = /** @type {WebInspector.DebuggerModel.Location} */ rawLocation; -this._breakpointManager._debuggerModel.setBreakpointByScriptLocation(debuggerModelLocation, this._condition, didSetBreakpoint.bind(this)); +if (debuggerModelLocation) +this._breakpointManager._debuggerModel.setBreakpointByScriptLocation(debuggerModelLocation, this._condition, didSetBreakpoint.bind(this)); +else +this._breakpointManager._debuggerModel.setBreakpointByURL(this._primaryUILocation.uiSourceCode.url, this._primaryUILocation.lineNumber, 0, this._condition, didSetBreakpoint.bind(this)); + /** * @this {WebInspector.BreakpointManager.Breakpoint} * @param {?DebuggerAgent.BreakpointId} breakpointId Modified: trunk/Source/WebCore/inspector/front-end/DebuggerModel.js (120334 => 120335) --- trunk/Source/WebCore/inspector/front-end/DebuggerModel.js 2012-06-14 16:53:38 UTC (rev 120334) +++ trunk/Source/WebCore/inspector/front-end/DebuggerModel.js 2012-06-14 16:57:15 UTC (rev 120335) @@ -135,7 +135,7 @@ { var script = this.scriptForId(rawLocation.scriptId); if (script.sourceURL) -this.setBreakpoint(script.sourceURL, rawLocation.lineNumber, rawLocation.columnNumber, condition, callback); +this.setBreakpointByURL(script.sourceURL, rawLocation.lineNumber, rawLocation.columnNumber, condition, callback); else this.setBreakpointBySourceId(rawLocation, condition, callback); }, @@ -147,7 +147,7 @@ * @param {string=} condition * @param {function(?DebuggerAgent.BreakpointId, Array.)=} callback */ -setBreakpoint: function(url, lineNumber, columnNumber, condition, callback) +setBreakpointByURL: function(url, lineNumber, columnNumber, condition, callback) { // Adjust column if needed. var minColumnNumber = 0; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120334] trunk/LayoutTests
Title: [120334] trunk/LayoutTests Revision 120334 Author ph...@webkit.org Date 2012-06-14 09:53:38 -0700 (Thu, 14 Jun 2012) Log Message [GTK] Update TestExpectations with tests crashing in 64bits Debug build https://bugs.webkit.org/show_bug.cgi?id=89105 Unreviewed gardening. Mark svg/batik/text/textDecoration.svg and svg/batik/text/textEffect3.svg as crashing in DEBUG. Patch by Simon Pena on 2012-06-14 * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120333 => 120334) --- trunk/LayoutTests/ChangeLog 2012-06-14 16:53:04 UTC (rev 120333) +++ trunk/LayoutTests/ChangeLog 2012-06-14 16:53:38 UTC (rev 120334) @@ -1,5 +1,17 @@ 2012-06-14 Simon Pena +[GTK] Update TestExpectations with tests crashing in 64bits Debug build +https://bugs.webkit.org/show_bug.cgi?id=89105 + +Unreviewed gardening. + +Mark svg/batik/text/textDecoration.svg and +svg/batik/text/textEffect3.svg as crashing in DEBUG. + +* platform/gtk/TestExpectations: + +2012-06-14 Simon Pena + [GTK] Update TestExpectations with non-passing tests https://bugs.webkit.org/show_bug.cgi?id=89100 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120333 => 120334) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-14 16:53:04 UTC (rev 120333) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-14 16:53:38 UTC (rev 120334) @@ -357,6 +357,9 @@ BUGWK86176 DEBUG : ietestcenter/css3/valuesandunits/units-000.htm = CRASH +BUGWK89104 DEBUG : svg/batik/text/textDecoration.svg = CRASH +BUGWK89104 DEBUG : svg/batik/text/textEffect3.svg = CRASH + // // End of Crashing tests // ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120333] trunk/LayoutTests
Title: [120333] trunk/LayoutTests Revision 120333 Author ph...@webkit.org Date 2012-06-14 09:53:04 -0700 (Thu, 14 Jun 2012) Log Message [GTK] Update TestExpectations with non-passing tests https://bugs.webkit.org/show_bug.cgi?id=89100 Unreviewed gardening. Mark plugins/plugin-initiate-popup-window.html as flaky and svg/transforms/transformed-text-fill-pattern.html as failing. Patch by Simon Pena on 2012-06-14 * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120332 => 120333) --- trunk/LayoutTests/ChangeLog 2012-06-14 16:49:39 UTC (rev 120332) +++ trunk/LayoutTests/ChangeLog 2012-06-14 16:53:04 UTC (rev 120333) @@ -1,3 +1,15 @@ +2012-06-14 Simon Pena + +[GTK] Update TestExpectations with non-passing tests +https://bugs.webkit.org/show_bug.cgi?id=89100 + +Unreviewed gardening. + +Mark plugins/plugin-initiate-popup-window.html as flaky and +svg/transforms/transformed-text-fill-pattern.html as failing. + +* platform/gtk/TestExpectations: + 2012-06-14 Tony Chang [Qt] New css3/flexbox/flexitem.html fails Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120332 => 120333) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-14 16:49:39 UTC (rev 120332) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-14 16:53:04 UTC (rev 120333) @@ -397,6 +397,7 @@ BUGWK37562 : plugins/update-widgets-crash.html = PASS TEXT BUGWK37572 : plugins/open-and-close-window-with-plugin.html = PASS TEXT +BUGWK89097 : plugins/plugin-initiate-popup-window.html = PASS TEXT BUGWK53995 : editing/selection/end-of-document.html = PASS TEXT BUGWK51325 : editing/selection/extend-by-character-003.html = PASS TEXT @@ -1268,6 +1269,7 @@ BUGWK86971 : svg/hittest/svg-shapes-non-scale-stroke.html = TEXT BUGWK86971 : svg/custom/non-scaling-stroke-markers.svg = TEXT PASS +BUGWK89099 : svg/transforms/transformed-text-fill-pattern.html = IMAGE BUGWK87088 : fast/js/names.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120332] trunk/Tools
Title: [120332] trunk/Tools Revision 120332 Author qi.2.zh...@nokia.com Date 2012-06-14 09:49:39 -0700 (Thu, 14 Jun 2012) Log Message Unreviewed. Update my email. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (120331 => 120332) --- trunk/Tools/ChangeLog 2012-06-14 16:49:10 UTC (rev 120331) +++ trunk/Tools/ChangeLog 2012-06-14 16:49:39 UTC (rev 120332) @@ -1,3 +1,9 @@ +2012-06-14 Qi Zhang + +Unreviewed. Update my email. + +* Scripts/webkitpy/common/config/committers.py: + 2012-06-14 Takashi Toyoshima Update pywebsocket to 0.7.6 from 0.7.4 Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (120331 => 120332) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-06-14 16:49:10 UTC (rev 120331) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-06-14 16:49:39 UTC (rev 120332) @@ -343,7 +343,7 @@ Committer("Pierre-Olivier Latour", "p...@apple.com", "pol"), Committer("Pierre Rossi", "pierre.ro...@gmail.com", "elproxy"), Committer("Pratik Solanki", "psola...@apple.com", "psolanki"), -Committer("Qi Zhang", ["qi.2.zh...@nokia.com", "qi.zhang02...@gmail.com"], "qi"), +Committer("Qi Zhang", "qi.zhang02...@gmail.com", "qi"), Committer("Rafael Antognolli", "antogno...@profusion.mobi", "antognolli"), Committer("Rafael Brandao", "rafael.l...@openbossa.org", "rafaelbrandao"), Committer("Rafael Weinstein", "rafa...@chromium.org", "rafaelw"), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120331] trunk/Source/WebCore
Title: [120331] trunk/Source/WebCore Revision 120331 Author pfeld...@chromium.org Date 2012-06-14 09:49:10 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: refactor settings screen to move user agent and experiments out of general tab. https://bugs.webkit.org/show_bug.cgi?id=89101 Reviewed by Vsevolod Vlasov. See image attached to the bug. * English.lproj/localizedStrings.js: * inspector/front-end/SettingsScreen.js: (WebInspector.SettingsScreen.prototype.selectTab): (WebInspector.SettingsScreen.prototype._tabSelected): (WebInspector.SettingsScreen.prototype.set wasShown): (WebInspector.SettingsScreen.prototype.willHide): (WebInspector.SettingsTab): (WebInspector.SettingsTab.prototype._appendSection): (WebInspector.SettingsTab.prototype._createCustomSetting): (WebInspector.GenericSettingsTab): (WebInspector.GenericSettingsTab.prototype._showPaintRectsChanged): (WebInspector.GenericSettingsTab.prototype.get _updateScriptDisabledCheckbox): (WebInspector.GenericSettingsTab.prototype._javaScriptDisabledChanged): (WebInspector.UserAgentSettingsTab): (WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.get const): (WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.textDoubleClicked): (WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.textChanged): (WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.set checkboxClicked): (WebInspector.UserAgentSettingsTab.prototype._createDeviceMetricsElement): (WebInspector.ExperimentsSettingsTab): (WebInspector.ExperimentsSettingsTab.prototype._createExperimentsWarningSubsection): (WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox.listener): (WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox): * inspector/front-end/ShortcutsScreen.js: * inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane.prototype.get headerContentsElement): * inspector/front-end/helpScreen.css: (.settings-tab.help-container): (.settings-tab .help-block): (.help-content fieldset): (#settings-screen .tabbed-pane-header-tabs): (#settings-screen .tabbed-pane-header-tab): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/inspector/front-end/SettingsScreen.js trunk/Source/WebCore/inspector/front-end/ShortcutsScreen.js trunk/Source/WebCore/inspector/front-end/TabbedPane.js trunk/Source/WebCore/inspector/front-end/helpScreen.css trunk/Source/WebCore/inspector/front-end/inspector.js Diff Modified: trunk/Source/WebCore/ChangeLog (120330 => 120331) --- trunk/Source/WebCore/ChangeLog 2012-06-14 16:44:25 UTC (rev 120330) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 16:49:10 UTC (rev 120331) @@ -1,3 +1,45 @@ +2012-06-14 Pavel Feldman + +Web Inspector: refactor settings screen to move user agent and experiments out of general tab. +https://bugs.webkit.org/show_bug.cgi?id=89101 + +Reviewed by Vsevolod Vlasov. + +See image attached to the bug. + +* English.lproj/localizedStrings.js: +* inspector/front-end/SettingsScreen.js: +(WebInspector.SettingsScreen.prototype.selectTab): +(WebInspector.SettingsScreen.prototype._tabSelected): +(WebInspector.SettingsScreen.prototype.set wasShown): +(WebInspector.SettingsScreen.prototype.willHide): +(WebInspector.SettingsTab): +(WebInspector.SettingsTab.prototype._appendSection): +(WebInspector.SettingsTab.prototype._createCustomSetting): +(WebInspector.GenericSettingsTab): +(WebInspector.GenericSettingsTab.prototype._showPaintRectsChanged): +(WebInspector.GenericSettingsTab.prototype.get _updateScriptDisabledCheckbox): +(WebInspector.GenericSettingsTab.prototype._javaScriptDisabledChanged): +(WebInspector.UserAgentSettingsTab): +(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.get const): +(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.textDoubleClicked): +(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.textChanged): +(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.set checkboxClicked): +(WebInspector.UserAgentSettingsTab.prototype._createDeviceMetricsElement): +(WebInspector.ExperimentsSettingsTab): +(WebInspector.ExperimentsSettingsTab.prototype._createExperimentsWarningSubsection): +(WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox.listener): +(WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox): +* inspector/front-end/ShortcutsScreen.js: +* inspector/front-end/TabbedPane.js: +(WebInspector.TabbedPane.prototype.get headerContentsElement): +* inspector/front-end/helpScreen.css: +(.settings-tab.help-container): +(.setti
[webkit-changes] [120330] trunk/LayoutTests
Title: [120330] trunk/LayoutTests Revision 120330 Author t...@chromium.org Date 2012-06-14 09:44:25 -0700 (Thu, 14 Jun 2012) Log Message [Qt] New css3/flexbox/flexitem.html fails https://bugs.webkit.org/show_bug.cgi?id=88963 Reviewed by Hajime Morita. * css3/flexbox/flexitem.html: The height of the alt text was taller than the height of the missing image placeholder graphic on Qt. To get the same results, force the font size to something small. The test still fails on Qt so leaving it in the Skipped file for now. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/flexbox/flexitem.html Diff Modified: trunk/LayoutTests/ChangeLog (120329 => 120330) --- trunk/LayoutTests/ChangeLog 2012-06-14 15:52:28 UTC (rev 120329) +++ trunk/LayoutTests/ChangeLog 2012-06-14 16:44:25 UTC (rev 120330) @@ -1,3 +1,15 @@ +2012-06-14 Tony Chang + +[Qt] New css3/flexbox/flexitem.html fails +https://bugs.webkit.org/show_bug.cgi?id=88963 + +Reviewed by Hajime Morita. + +* css3/flexbox/flexitem.html: The height of the alt text was taller +than the height of the missing image placeholder graphic on Qt. To +get the same results, force the font size to something small. +The test still fails on Qt so leaving it in the Skipped file for now. + 2012-06-14 Alexander Pavlov Web Inspector: Selector list start position is not extracted for style rules inside @media rules Modified: trunk/LayoutTests/css3/flexbox/flexitem.html (120329 => 120330) --- trunk/LayoutTests/css3/flexbox/flexitem.html 2012-06-14 15:52:28 UTC (rev 120329) +++ trunk/LayoutTests/css3/flexbox/flexitem.html 2012-06-14 16:44:25 UTC (rev 120330) @@ -13,6 +13,7 @@ margin: 0; border: 0; padding: 0; +font-size: 12px; }
[webkit-changes] [120329] trunk/Source/WebKit2
Title: [120329] trunk/Source/WebKit2 Revision 120329 Author kl...@webkit.org Date 2012-06-14 08:52:28 -0700 (Thu, 14 Jun 2012) Log Message Chinese IM receives incorrect/duplicated key events in text fields in webpages in Safari. Reviewed by Darin Adler. Send the DidReceiveEvent message with the DispatchMessageEvenWhenWaitingForSyncReply flag for keyboard events. This ensures that it always arrives before the corresponding synchronous InterpretQueuedKeyEvent message. The problem was that we relied on DidReceiveEvent / InterpretQueuedKeyEvent always arriving in the same order they were sent. This was not always true, since DidReceiveEvent (async) would get deferred during an unrelated waitForSyncReply() whereas InterpretQueuedKeyEvent (sync) gets dispatched right away. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::keyEvent): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (120328 => 120329) --- trunk/Source/WebKit2/ChangeLog 2012-06-14 15:39:34 UTC (rev 120328) +++ trunk/Source/WebKit2/ChangeLog 2012-06-14 15:52:28 UTC (rev 120329) @@ -1,3 +1,23 @@ +2012-06-13 Andreas Kling + +Chinese IM receives incorrect/duplicated key events in text fields in webpages in Safari. + + + +Reviewed by Darin Adler. + +Send the DidReceiveEvent message with the DispatchMessageEvenWhenWaitingForSyncReply flag +for keyboard events. This ensures that it always arrives before the corresponding synchronous +InterpretQueuedKeyEvent message. + +The problem was that we relied on DidReceiveEvent / InterpretQueuedKeyEvent always arriving in +the same order they were sent. This was not always true, since DidReceiveEvent (async) would +get deferred during an unrelated waitForSyncReply() whereas InterpretQueuedKeyEvent (sync) +gets dispatched right away. + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::keyEvent): + 2012-06-14 Carlos Garcia Campos [GTK] Add input methods submenu item to the default context menu for editable content Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (120328 => 120329) --- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-06-14 15:39:34 UTC (rev 120328) +++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-06-14 15:52:28 UTC (rev 120329) @@ -1423,7 +1423,9 @@ if (!handled) handled = performDefaultBehaviorForKeyEvent(keyboardEvent); -send(Messages::WebPageProxy::DidReceiveEvent(static_cast(keyboardEvent.type()), handled)); +// The receiving end relies on DidReceiveEvent and InterpretQueuedKeyEvent arriving in the same order they are sent +// (for keyboard events.) We set the DispatchMessageEvenWhenWaitingForSyncReply flag to ensure consistent ordering. +connection()->send(Messages::WebPageProxy::DidReceiveEvent(static_cast(keyboardEvent.type()), handled), m_pageID, CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply); } void WebPage::keyEventSyncForTesting(const WebKeyboardEvent& keyboardEvent, bool& handled) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120328] trunk/Source/WebCore
Title: [120328] trunk/Source/WebCore Revision 120328 Author mhahnenb...@apple.com Date 2012-06-14 08:39:34 -0700 (Thu, 14 Jun 2012) Log Message Worker tear-down can re-enter JSC during GC finalization pt. 2 https://bugs.webkit.org/show_bug.cgi?id=88601 Reviewed by David Levin. No new tests. Current regression tests are sufficient. * workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): (WebCore::WorkerMessagingProxy::workerObjectDestroyed): We clear the m_workerObject here because we don't want anybody else trying to send messages to the Worker now that it has been destroyed. We also queue the asynchronous task for the various other cleanup that still needs to be done. This allows us to avoid the problem of re-entrant JS code execution during GC. (WebCore): (WebCore::WorkerMessagingProxy::workerObjectDestroyedInternal): Here we set m_mayBeDestroyed to true. This is the point after which deleting the WorkerMessagingProxy in workerContextDestroyedInternal() is okay. It could happen during this function call if the worker thread has been shutdown already, or it could be called later after we shut down the worker thread. (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): We check m_mayBeDestroyed here instead of checking m_workerObject. This change effectively orthogonalizes the roles that m_workerObject was filling. Since we were eagerly clearing m_workerObject, but we wanted to asynchronously call workerObjectDestroyed(), we needed to make sure we didn't accidentally try to delete the WorkerMessagingProxy twice (once from destroying the Worker and once from destroying the WorkerContext). This boolean field should fix that issue--we set it lazily like we wanted to do without being in danger of causing use-after-free issues with m_workerObject. * workers/WorkerMessagingProxy.h: Added the new field and function. (WorkerMessagingProxy): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp trunk/Source/WebCore/workers/WorkerMessagingProxy.h Diff Modified: trunk/Source/WebCore/ChangeLog (120327 => 120328) --- trunk/Source/WebCore/ChangeLog 2012-06-14 15:34:05 UTC (rev 120327) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 15:39:34 UTC (rev 120328) @@ -1,3 +1,33 @@ +2012-06-13 Mark Hahnenberg + +Worker tear-down can re-enter JSC during GC finalization pt. 2 +https://bugs.webkit.org/show_bug.cgi?id=88601 + +Reviewed by David Levin. + +No new tests. Current regression tests are sufficient. + +* workers/WorkerMessagingProxy.cpp: +(WebCore::WorkerMessagingProxy::WorkerMessagingProxy): +(WebCore::WorkerMessagingProxy::workerObjectDestroyed): We clear the m_workerObject here because +we don't want anybody else trying to send messages to the Worker now that it has been destroyed. +We also queue the asynchronous task for the various other cleanup that still needs to be done. +This allows us to avoid the problem of re-entrant JS code execution during GC. +(WebCore): +(WebCore::WorkerMessagingProxy::workerObjectDestroyedInternal): Here we set m_mayBeDestroyed to true. +This is the point after which deleting the WorkerMessagingProxy in workerContextDestroyedInternal() +is okay. It could happen during this function call if the worker thread has been shutdown already, or +it could be called later after we shut down the worker thread. +(WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): We check m_mayBeDestroyed here +instead of checking m_workerObject. This change effectively orthogonalizes the roles that m_workerObject +was filling. Since we were eagerly clearing m_workerObject, but we wanted to asynchronously call +workerObjectDestroyed(), we needed to make sure we didn't accidentally try to delete the WorkerMessagingProxy +twice (once from destroying the Worker and once from destroying the WorkerContext). This boolean field +should fix that issue--we set it lazily like we wanted to do without being in danger of causing use-after-free +issues with m_workerObject. +* workers/WorkerMessagingProxy.h: Added the new field and function. +(WorkerMessagingProxy): + 2012-06-14 Alexander Pavlov Web Inspector: Selector list start position is not extracted for style rules inside @media rules Modified: trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp (120327 => 120328) --- trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp 2012-06-14 15:34:05 UTC (rev 120327) +++ trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp 2012-06-14 15:39:34 UTC (rev 120328) @@ -250,6 +250,7 @@ WorkerMessagingProxy::WorkerMessagingProxy(Worker* workerObject) : m_scriptExecutionContext(workerObject->scriptExecutionContext()) , m_workerObject(workerObject) +, m_mayBeDestroyed(false) , m
[webkit-changes] [120327] trunk
Title: [120327] trunk Revision 120327 Author apav...@chromium.org Date 2012-06-14 08:34:05 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: Selector list start position is not extracted for style rules inside @media rules https://bugs.webkit.org/show_bug.cgi?id=89094 Reviewed by Pavel Feldman. Source/WebCore: Selector list start is now marked inside the "ruleset" rule rather than separately, before its invocation(s). * css/CSSGrammar.y: LayoutTests: * inspector/audits/audits-panel-functional.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/audits/audits-panel-functional.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSGrammar.y Diff Modified: trunk/LayoutTests/ChangeLog (120326 => 120327) --- trunk/LayoutTests/ChangeLog 2012-06-14 14:57:10 UTC (rev 120326) +++ trunk/LayoutTests/ChangeLog 2012-06-14 15:34:05 UTC (rev 120327) @@ -1,3 +1,12 @@ +2012-06-14 Alexander Pavlov + +Web Inspector: Selector list start position is not extracted for style rules inside @media rules +https://bugs.webkit.org/show_bug.cgi?id=89094 + +Reviewed by Pavel Feldman. + +* inspector/audits/audits-panel-functional.html: + 2012-06-14 Mikhail Pozdnyakov [EFL] Tests rebaselining after r120167, r120246 Modified: trunk/LayoutTests/inspector/audits/audits-panel-functional.html (120326 => 120327) --- trunk/LayoutTests/inspector/audits/audits-panel-functional.html 2012-06-14 14:57:10 UTC (rev 120326) +++ trunk/LayoutTests/inspector/audits/audits-panel-functional.html 2012-06-14 15:34:05 UTC (rev 120327) @@ -2,11 +2,17 @@+@media all { + +/* This is a comment to use some space before the unused rule */ + .unused { color: green; -webkit-opacity: 1; opacity: 1; } + +}
[webkit-changes] [120326] trunk/Source/WebCore
Title: [120326] trunk/Source/WebCore Revision 120326 Author commit-qu...@webkit.org Date 2012-06-14 07:57:10 -0700 (Thu, 14 Jun 2012) Log Message [chromium] Fix race condition where animations start, finish and are deleted on the composite thread, all before the start even arrives on the main thread. https://bugs.webkit.org/show_bug.cgi?id=88439 Patch by Eric Penner on 2012-06-14 Reviewed by James Robinson. Scheduling behavior covered by existing tests. * platform/graphics/chromium/cc/CCActiveAnimation.cpp: (WebCore::CCActiveAnimation::isFinishedAt): * platform/graphics/chromium/cc/CCActiveAnimation.h: (WebCore::CCActiveAnimation::isFinished): * platform/graphics/chromium/cc/CCLayerAnimationController.cpp: (WebCore::CCLayerAnimationController::suspendAnimations): (WebCore::CCLayerAnimationController::pushAnimationUpdatesTo): (WebCore::CCLayerAnimationController::animate): (WebCore::CCLayerAnimationController::hasActiveAnimation): (WebCore): (WebCore::CCLayerAnimationController::markAnimationsForDeletion): (WebCore::CCLayerAnimationController::purgeAnimationsMarkedForDeletion): * platform/graphics/chromium/cc/CCLayerAnimationController.h: (CCLayerAnimationController): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.h Diff Modified: trunk/Source/WebCore/ChangeLog (120325 => 120326) --- trunk/Source/WebCore/ChangeLog 2012-06-14 14:44:37 UTC (rev 120325) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 14:57:10 UTC (rev 120326) @@ -1,3 +1,27 @@ +2012-06-14 Eric Penner + +[chromium] Fix race condition where animations start, finish and are deleted on the composite thread, all before the start even arrives on the main thread. +https://bugs.webkit.org/show_bug.cgi?id=88439 + +Reviewed by James Robinson. + +Scheduling behavior covered by existing tests. + +* platform/graphics/chromium/cc/CCActiveAnimation.cpp: +(WebCore::CCActiveAnimation::isFinishedAt): +* platform/graphics/chromium/cc/CCActiveAnimation.h: +(WebCore::CCActiveAnimation::isFinished): +* platform/graphics/chromium/cc/CCLayerAnimationController.cpp: +(WebCore::CCLayerAnimationController::suspendAnimations): +(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo): +(WebCore::CCLayerAnimationController::animate): +(WebCore::CCLayerAnimationController::hasActiveAnimation): +(WebCore): +(WebCore::CCLayerAnimationController::markAnimationsForDeletion): +(WebCore::CCLayerAnimationController::purgeAnimationsMarkedForDeletion): +* platform/graphics/chromium/cc/CCLayerAnimationController.h: +(CCLayerAnimationController): + 2012-06-14 Vsevolod Vlasov Web Inspector: ConsoleView.evaluateUsingTextPrompt should evaluate without command line API. Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.cpp (120325 => 120326) --- trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.cpp 2012-06-14 14:44:37 UTC (rev 120325) +++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.cpp 2012-06-14 14:57:10 UTC (rev 120326) @@ -84,7 +84,7 @@ bool CCActiveAnimation::isFinishedAt(double monotonicTime) const { -if (m_runState == Finished || m_runState == Aborted) +if (isFinished()) return true; if (m_needsSynchronizedStartTime) Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h (120325 => 120326) --- trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h 2012-06-14 14:44:37 UTC (rev 120325) +++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h 2012-06-14 14:57:10 UTC (rev 120326) @@ -52,6 +52,7 @@ WaitingForNextTick = 1, WaitingForTargetAvailability, WaitingForStartTime, +WaitingForDeletion, Running, Paused, Finished, @@ -95,7 +96,9 @@ void setAlternatesDirection(bool alternates) { m_alternatesDirection = alternates; } bool isFinishedAt(double monotonicTime) const; -bool isFinished() const { return m_runState == Finished || m_runState == Aborted; } +bool isFinished() const { return m_runState == Finished + || m_runState == Aborted + || m_runState == WaitingForDeletion; } CCAnimationCurve* curve() { return m_curve.get(); } const CCAnimationCurve* curve() const { return m_curve.get(); } Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp (120325 => 120326) --- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp 2012
[webkit-changes] [120325] trunk/Source/WebCore
Title: [120325] trunk/Source/WebCore Revision 120325 Author vse...@chromium.org Date 2012-06-14 07:44:37 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: ConsoleView.evaluateUsingTextPrompt should evaluate without command line API. https://bugs.webkit.org/show_bug.cgi?id=89096 Reviewed by Pavel Feldman. * inspector/front-end/ConsoleView.js: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/ConsoleView.js Diff Modified: trunk/Source/WebCore/ChangeLog (120324 => 120325) --- trunk/Source/WebCore/ChangeLog 2012-06-14 14:35:12 UTC (rev 120324) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 14:44:37 UTC (rev 120325) @@ -1,3 +1,12 @@ +2012-06-14 Vsevolod Vlasov + +Web Inspector: ConsoleView.evaluateUsingTextPrompt should evaluate without command line API. +https://bugs.webkit.org/show_bug.cgi?id=89096 + +Reviewed by Pavel Feldman. + +* inspector/front-end/ConsoleView.js: + 2012-06-14 Silvia Pfeiffer Update the time display of the new Chromium media controls. Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (120324 => 120325) --- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2012-06-14 14:35:12 UTC (rev 120324) +++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2012-06-14 14:44:37 UTC (rev 120325) @@ -733,7 +733,7 @@ this._appendConsoleMessage(new WebInspector.ConsoleCommandResult(result, wasThrown, commandMessage, this._linkifier)); } -this.evalInInspectedWindow(text, "console", true, false, false, printResult.bind(this)); +this.evalInInspectedWindow(text, "console", useCommandLineAPI, false, false, printResult.bind(this)); WebInspector.userMetrics.ConsoleEvaluated.record(); }, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120324] trunk/Source/WebKit/chromium
Title: [120324] trunk/Source/WebKit/chromium Revision 120324 Author apav...@chromium.org Date 2012-06-14 07:35:12 -0700 (Thu, 14 Jun 2012) Log Message [Chromium] Unreviewed, build fix for Mac 10.5 * src/WebDevToolsAgentImpl.cpp: (WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (120323 => 120324) --- trunk/Source/WebKit/chromium/ChangeLog 2012-06-14 14:15:12 UTC (rev 120323) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-14 14:35:12 UTC (rev 120324) @@ -1,3 +1,10 @@ +2012-06-14 Alexander Pavlov + +[Chromium] Unreviewed, build fix for Mac 10.5 + +* src/WebDevToolsAgentImpl.cpp: +(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth): + 2012-06-14 Eugene Klyuchnikov Web Inspector: Refactor message loop instrumentation. Modified: trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp (120323 => 120324) --- trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2012-06-14 14:15:12 UTC (rev 120323) +++ trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2012-06-14 14:35:12 UTC (rev 120324) @@ -233,7 +233,6 @@ return; frame->setTextZoomFactor(m_webView->emulatedTextZoomFactor()); -WebSize scaledFrameSize = scaledEmulatedFrameSize(frame->view()); ensureOriginalZoomFactor(frame->view()); frame->setPageAndTextZoomFactors(m_originalZoomFactor, m_webView->emulatedTextZoomFactor()); Document* doc = frame->document(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120323] trunk/LayoutTests
Title: [120323] trunk/LayoutTests Revision 120323 Author commit-qu...@webkit.org Date 2012-06-14 07:15:12 -0700 (Thu, 14 Jun 2012) Log Message [EFL] Tests rebaselining after r120167, r120246 https://bugs.webkit.org/show_bug.cgi?id=89069 Unreviewed EFL gardening after r120246 and r120167, updating baselines. Patch by Mikhail Pozdnyakov on 2012-06-14 * platform/efl/fast/layers/video-layer-expected.txt: * platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt: * platform/efl/media/audio-controls-rendering-expected.txt: * platform/efl/media/audio-repaint-expected.txt: * platform/efl/media/controls-after-reload-expected.txt: * platform/efl/media/controls-strict-expected.txt: * platform/efl/media/controls-styling-expected.txt: * platform/efl/media/controls-without-preload-expected.txt: * platform/efl/media/media-controls-clone-expected.txt: * platform/efl/media/media-document-audio-repaint-expected.txt: * platform/efl/media/video-controls-rendering-expected.txt: * platform/efl/media/video-display-toggle-expected.txt: * platform/efl/media/video-empty-source-expected.txt: * platform/efl/media/video-zoom-controls-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/fast/layers/video-layer-expected.txt trunk/LayoutTests/platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt trunk/LayoutTests/platform/efl/media/audio-controls-rendering-expected.txt trunk/LayoutTests/platform/efl/media/audio-repaint-expected.txt trunk/LayoutTests/platform/efl/media/controls-after-reload-expected.txt trunk/LayoutTests/platform/efl/media/controls-strict-expected.txt trunk/LayoutTests/platform/efl/media/controls-styling-expected.txt trunk/LayoutTests/platform/efl/media/controls-without-preload-expected.txt trunk/LayoutTests/platform/efl/media/media-controls-clone-expected.txt trunk/LayoutTests/platform/efl/media/media-document-audio-repaint-expected.txt trunk/LayoutTests/platform/efl/media/video-controls-rendering-expected.txt trunk/LayoutTests/platform/efl/media/video-display-toggle-expected.txt trunk/LayoutTests/platform/efl/media/video-empty-source-expected.txt trunk/LayoutTests/platform/efl/media/video-zoom-controls-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (120322 => 120323) --- trunk/LayoutTests/ChangeLog 2012-06-14 14:01:36 UTC (rev 120322) +++ trunk/LayoutTests/ChangeLog 2012-06-14 14:15:12 UTC (rev 120323) @@ -1,3 +1,25 @@ +2012-06-14 Mikhail Pozdnyakov + +[EFL] Tests rebaselining after r120167, r120246 +https://bugs.webkit.org/show_bug.cgi?id=89069 + +Unreviewed EFL gardening after r120246 and r120167, updating baselines. + +* platform/efl/fast/layers/video-layer-expected.txt: +* platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt: +* platform/efl/media/audio-controls-rendering-expected.txt: +* platform/efl/media/audio-repaint-expected.txt: +* platform/efl/media/controls-after-reload-expected.txt: +* platform/efl/media/controls-strict-expected.txt: +* platform/efl/media/controls-styling-expected.txt: +* platform/efl/media/controls-without-preload-expected.txt: +* platform/efl/media/media-controls-clone-expected.txt: +* platform/efl/media/media-document-audio-repaint-expected.txt: +* platform/efl/media/video-controls-rendering-expected.txt: +* platform/efl/media/video-display-toggle-expected.txt: +* platform/efl/media/video-empty-source-expected.txt: +* platform/efl/media/video-zoom-controls-expected.txt: + 2012-06-14 Alexander Pavlov Unreviewed, test rebaseline after r120317. Modified: trunk/LayoutTests/platform/efl/fast/layers/video-layer-expected.txt (120322 => 120323) --- trunk/LayoutTests/platform/efl/fast/layers/video-layer-expected.txt 2012-06-14 14:01:36 UTC (rev 120322) +++ trunk/LayoutTests/platform/efl/fast/layers/video-layer-expected.txt 2012-06-14 14:15:12 UTC (rev 120323) @@ -28,12 +28,11 @@ text run at (0,0) width 55: "00:00 / 00:00" RenderSlider {INPUT} at (63,0) size 157x20 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 157x20 - RenderBlock {DIV} at (0,4) size 145x12 - RenderBlock {DIV} at (145,4) size 12x12 + RenderBlock {DIV} at (0,0) size 145x20 +RenderBlock {DIV} at (0,0) size 12x12 + RenderBlock {DIV} at (145,0) size 12x12 RenderButton {INPUT} at (240,0) size 20x20 RenderButton {INPUT} at (260,0) size 20x20 RenderBlock {DIV} at (280,0) size 20x20 -layer at (142,245) size 12x12 - RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 layer at (339,241) size 20x20 RenderButton zI: 2 {INPUT} at (0,0) size 20x20 Modified: trunk/LayoutTests/platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt (120322 => 120323) --- trunk/LayoutTests/platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt 2012-06-14 1
[webkit-changes] [120322] trunk/Source/WebCore
Title: [120322] trunk/Source/WebCore Revision 120322 Author commit-qu...@webkit.org Date 2012-06-14 07:01:36 -0700 (Thu, 14 Jun 2012) Log Message Update the time display of the new Chromium media controls. https://bugs.webkit.org/show_bug.cgi?id=88724 Patch by Silvia Pfeiffer on 2012-06-14 Reviewed by Eric Carlson. No new tests, final patch will contain the rebaselined tests. The Chrome video controls are receiving a visual update. This patch changes the format of the time digits that are displayed. They are different for media files of different duration. For non-autoplaying videos, the duration is shown before playback is started. * css/mediaControlsChromium.css: (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): Format the new duration display the same as the current time display. * html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium): Add a member field for the duration display. (WebCore::MediaControlRootElementChromium::create): Add an element for the duration display and initially hide the current time display. (WebCore::MediaControlRootElementChromium::setMediaController): Add the duration display to the controller. (WebCore::MediaControlRootElementChromium::reset): Add reset functionality for the duration display. (WebCore::MediaControlRootElementChromium::playbackStarted): Show the current time display and hide the duration display upon playback start. (WebCore::MediaControlRootElementChromium::updateTimeDisplay): Show the current time display and hide the duration display when current time is non-zero. * html/shadow/MediaControlRootElementChromium.h: (WebCore): Add the MediaControlTimeRemainingDisplayElement which provides use with the duration display. (MediaControlRootElementChromium): Add a duration member field, reusing the existing MediaControlTimeRemainingDisplayElement. * rendering/RenderMediaControlsChromium.cpp: (WebCore::formatChromiumMediaControlsTime): Formats a given time under the condition of a given duration. (WebCore::RenderMediaControlsChromium::formatMediaControlsTime): When formatting a single time, assume it to also provide the duration conditions. (WebCore::RenderMediaControlsChromium::formatMediaControlsCurrentTime): Format the current time given the duration. (WebCore::RenderMediaControlsChromium::formatMediaControlsRemainingTime): Format the remaining time from the current time given the duration. * rendering/RenderMediaControlsChromium.h: (RenderMediaControlsChromium): Declare the time formatting member functions. * rendering/RenderThemeChromiumMac.h: (RenderThemeChromiumMac): Declare the time formatting member functions for Chromium on the Mac. * rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::formatMediaControlsTime): (WebCore::RenderThemeChromiumMac::formatMediaControlsCurrentTime): (WebCore::RenderThemeChromiumMac::formatMediaControlsRemainingTime): Call the time formatting member functions of RenderMediaControlsChromium on the Mac. * rendering/RenderThemeChromiumSkia.cpp: (WebCore::formatMediaControlsTime): (WebCore::formatMediaControlsCurrentTime): (WebCore::formatMediaControlsRemainingTime): Call the time formatting member functions of RenderMediaControlsChromium on Skia. * rendering/RenderThemeChromiumSkia.h: (RenderThemeChromiumSkia): Declare the time formatting member functions for Chromium Skia. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/mediaControlsChromium.css trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.h trunk/Source/WebCore/rendering/RenderMediaControlsChromium.cpp trunk/Source/WebCore/rendering/RenderMediaControlsChromium.h trunk/Source/WebCore/rendering/RenderThemeChromiumMac.h trunk/Source/WebCore/rendering/RenderThemeChromiumMac.mm trunk/Source/WebCore/rendering/RenderThemeChromiumSkia.cpp trunk/Source/WebCore/rendering/RenderThemeChromiumSkia.h Diff Modified: trunk/Source/WebCore/ChangeLog (120321 => 120322) --- trunk/Source/WebCore/ChangeLog 2012-06-14 13:58:01 UTC (rev 120321) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 14:01:36 UTC (rev 120322) @@ -1,3 +1,67 @@ +2012-06-14 Silvia Pfeiffer + +Update the time display of the new Chromium media controls. +https://bugs.webkit.org/show_bug.cgi?id=88724 + +Reviewed by Eric Carlson. + +No new tests, final patch will contain the rebaselined tests. + +The Chrome video controls are receiving a visual update. This patch changes +the format of the time digits that are displayed. They are different for media +files of different duration. For non-autoplaying videos, the duration is shown +before playback is started. + +* css/mediaControlsChromium.css: +(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-tim
[webkit-changes] [120321] trunk/LayoutTests
Title: [120321] trunk/LayoutTests Revision 120321 Author apav...@chromium.org Date 2012-06-14 06:58:01 -0700 (Thu, 14 Jun 2012) Log Message Unreviewed, test rebaseline after r120317. * inspector/styles/override-screen-size-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/styles/override-screen-size-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (120320 => 120321) --- trunk/LayoutTests/ChangeLog 2012-06-14 13:54:45 UTC (rev 120320) +++ trunk/LayoutTests/ChangeLog 2012-06-14 13:58:01 UTC (rev 120321) @@ -1,3 +1,9 @@ +2012-06-14 Alexander Pavlov + +Unreviewed, test rebaseline after r120317. + +* inspector/styles/override-screen-size-expected.txt: + 2012-06-14 Simon Pena [GTK] Mark fast/forms/text-input-event.html as flaky in TestExpectations Modified: trunk/LayoutTests/inspector/styles/override-screen-size-expected.txt (120320 => 120321) --- trunk/LayoutTests/inspector/styles/override-screen-size-expected.txt 2012-06-14 13:54:45 UTC (rev 120320) +++ trunk/LayoutTests/inspector/styles/override-screen-size-expected.txt 2012-06-14 13:58:01 UTC (rev 120321) @@ -2,8 +2,8 @@ Override: 480x800 Screen from page: 480x800 -Window from page: 480x800 -Body from page: 480x800 +Window from page: 351x585 +Body from page: 351x585 Main style: [expanded] element.style { () @@ -22,8 +22,8 @@ Override: 800x480 Screen from page: 800x480 -Window from page: 800x480 -Body from page: 800x480 +Window from page: 785x471 +Body from page: 785x471 Main style: [expanded] element.style { () @@ -40,8 +40,8 @@ Override: 480x-1 => ERROR Current dimensions: Screen from page: 800x480 -Window from page: 800x480 -Body from page: 800x480 +Window from page: 785x471 +Body from page: 785x471 Disable PageAgent: Screen size same as original - OK Enable PageAgent: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120320] trunk/LayoutTests
Title: [120320] trunk/LayoutTests Revision 120320 Author commit-qu...@webkit.org Date 2012-06-14 06:54:45 -0700 (Thu, 14 Jun 2012) Log Message [GTK] Mark fast/forms/text-input-event.html as flaky in TestExpectations https://bugs.webkit.org/show_bug.cgi?id=89085 Unreviewed gardening. Mark test as flaky. Patch by Simon Pena on 2012-06-14 * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120319 => 120320) --- trunk/LayoutTests/ChangeLog 2012-06-14 13:52:30 UTC (rev 120319) +++ trunk/LayoutTests/ChangeLog 2012-06-14 13:54:45 UTC (rev 120320) @@ -1,3 +1,12 @@ +2012-06-14 Simon Pena + +[GTK] Mark fast/forms/text-input-event.html as flaky in TestExpectations +https://bugs.webkit.org/show_bug.cgi?id=89085 + +Unreviewed gardening. Mark test as flaky. + +* platform/gtk/TestExpectations: + 2012-06-14 Stephen Chenney [svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120319 => 120320) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-14 13:52:30 UTC (rev 120319) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-14 13:54:45 UTC (rev 120320) @@ -440,6 +440,7 @@ BUGWK76831 : svg/hixie/error/012.xml = PASS TEXT BUGWK77636 : fast/forms/radio/radio-group.html = PASS TEXT +BUGWK89084 : fast/forms/text-input-event.html = PASS TEXT BUGWK78344 : fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120319] trunk/LayoutTests
Title: [120319] trunk/LayoutTests Revision 120319 Author schen...@chromium.org Date 2012-06-14 06:52:30 -0700 (Thu, 14 Jun 2012) Log Message [svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations https://bugs.webkit.org/show_bug.cgi?id=64966 Unreviewed Chromium test expectations update. Bug fixed by Dominik Röttsches. * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: * platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png: * platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png: * platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png: * platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png: * platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png: * platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png: * platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png: Removed. * platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: * platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png: * platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png: * platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png: * platform/chromium-mac/svg/custom/text-rotated-gradient-expected.png: * platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: * platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png: * platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png: * platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png: * platform/chromium-win/svg/custom/text-rotated-gradient-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png trunk/LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png trunk/LayoutTests/platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png trunk/LayoutTests/platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png trunk/LayoutTests/platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png trunk/LayoutTests/platform/chromium-mac/svg/custom/text-rotated-gradient-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/text-rotated-gradient-expected.png trunk/LayoutTests/platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png Removed Paths trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (120318 => 120319) --- trunk/LayoutTests/ChangeLog 2012-06-14 13:26:51 UTC (rev 120318) +++ trunk/LayoutTests/ChangeLog 2012-06-14 13:52:30 UTC (rev 120319) @@ -1,3 +1,33 @@ +2012-06-14 Stephen Chenney + +[svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations +https://bugs.webkit.org/show_bug.cgi?id=64966 + +Unreviewed Chromium test expectations update. + +Bug fixed by Dominik Röttsches. + +* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: +* platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png: +* platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png: +* platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png: +* platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png: +* platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png: +* platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png: +* platform/chromium-mac-
[webkit-changes] [120318] trunk/Source
Title: [120318] trunk/Source Revision 120318 Author commit-qu...@webkit.org Date 2012-06-14 06:26:51 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: Refactor message loop instrumentation. https://bugs.webkit.org/show_bug.cgi?id=88978 Patch by Eugene Klyuchnikov on 2012-06-14 Reviewed by Pavel Feldman. 1) Remove "messageLoop" term 2) Reuse WebThread::TaskObserver interface 3) Move implementation (from embedder) to platform code. Source/Platform: * chromium/public/WebThread.h: (TaskObserver): add "willProcessTask" method. Source/WebCore: * inspector/InspectorClient.h: (WebCore::InspectorClient::startMainThreadMonitoring): Renamed method. (WebCore::InspectorClient::stopMainThreadMonitoring): Ditto. * inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::start): (WebCore::InspectorTimelineAgent::stop): Source/WebKit/chromium: * public/WebDevToolsAgent.h: (WebDevToolsAgent): * public/WebDevToolsAgentClient.h: (WebDevToolsAgentClient): (WebKit::WebDevToolsAgentClient::startMainThreadMonitoring): Renamed medthod. (WebKit::WebDevToolsAgentClient::stopMainThreadMonitoring): Ditto. * src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::startMainThreadMonitoring): Ditto. (WebKit::InspectorClientImpl::stopMainThreadMonitoring): Ditto. * src/InspectorClientImpl.h: (InspectorClientImpl): * src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::startMainThreadMonitoring): Use platform threading. (WebKit::WebDevToolsAgentImpl::stopMainThreadMonitoring): Ditto. (WebKit::WebDevToolsAgentImpl::willProcessTask): Renamed medthod. (WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto. * src/WebDevToolsAgentImpl.h: (WebDevToolsAgentImpl): * src/WebKit.cpp: Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/chromium/public/WebThread.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorClient.h trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebDevToolsAgent.h trunk/Source/WebKit/chromium/public/WebDevToolsAgentClient.h trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp trunk/Source/WebKit/chromium/src/InspectorClientImpl.h trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h trunk/Source/WebKit/chromium/src/WebKit.cpp Diff Modified: trunk/Source/Platform/ChangeLog (120317 => 120318) --- trunk/Source/Platform/ChangeLog 2012-06-14 13:05:00 UTC (rev 120317) +++ trunk/Source/Platform/ChangeLog 2012-06-14 13:26:51 UTC (rev 120318) @@ -1,3 +1,17 @@ +2012-06-14 Eugene Klyuchnikov + +Web Inspector: Refactor message loop instrumentation. +https://bugs.webkit.org/show_bug.cgi?id=88978 + +Reviewed by Pavel Feldman. + +1) Remove "messageLoop" term +2) Reuse WebThread::TaskObserver interface +3) Move implementation (from embedder) to platform code. + +* chromium/public/WebThread.h: +(TaskObserver): add "willProcessTask" method. + 2012-06-13 Sheriff Bot Unreviewed, rolling out r120268. Modified: trunk/Source/Platform/chromium/public/WebThread.h (120317 => 120318) --- trunk/Source/Platform/chromium/public/WebThread.h 2012-06-14 13:05:00 UTC (rev 120317) +++ trunk/Source/Platform/chromium/public/WebThread.h 2012-06-14 13:26:51 UTC (rev 120318) @@ -46,6 +46,7 @@ class TaskObserver { public: virtual ~TaskObserver() { } +virtual void willProcessTask() = 0; virtual void didProcessTask() = 0; }; Modified: trunk/Source/WebCore/ChangeLog (120317 => 120318) --- trunk/Source/WebCore/ChangeLog 2012-06-14 13:05:00 UTC (rev 120317) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 13:26:51 UTC (rev 120318) @@ -1,3 +1,21 @@ +2012-06-14 Eugene Klyuchnikov + +Web Inspector: Refactor message loop instrumentation. +https://bugs.webkit.org/show_bug.cgi?id=88978 + +Reviewed by Pavel Feldman. + +1) Remove "messageLoop" term +2) Reuse WebThread::TaskObserver interface +3) Move implementation (from embedder) to platform code. + +* inspector/InspectorClient.h: +(WebCore::InspectorClient::startMainThreadMonitoring): Renamed method. +(WebCore::InspectorClient::stopMainThreadMonitoring): Ditto. +* inspector/InspectorTimelineAgent.cpp: +(WebCore::InspectorTimelineAgent::start): +(WebCore::InspectorTimelineAgent::stop): + 2012-06-14 Dominik Röttsches [svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations Modified: trunk/Source/WebCore/inspector/InspectorClient.h (120317 => 120318) --- trunk/Source/WebCore/inspector/InspectorClient.h 2012-06-14 13:05:00 UTC (rev 120317) +++ trunk/Source/WebCore/inspector/InspectorClient.h 2012-06-14 13:26:51 UTC (rev 120318) @@ -55,8 +55,8 @@ virtual void clearBrowserCache() { } virtual bool canClearBrowserCo
[webkit-changes] [120317] trunk
Title: [120317] trunk Revision 120317 Author apav...@chromium.org Date 2012-06-14 06:05:00 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: [Device Metrics] "Fit window" results in duplicate rescaling in WebDevToolsAgentImpl::autoZoomPageToFitWidth() https://bugs.webkit.org/show_bug.cgi?id=89092 Reviewed by Pavel Feldman. Source/WebKit/chromium: Do not apply the sizeRatio after it has been applied in scaledEmulatedFrameSize(). * src/WebDevToolsAgentImpl.cpp: (WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth): (WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor): LayoutTests: * platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt: * platform/chromium/inspector/styles/device-metrics-fit-window.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt trunk/LayoutTests/platform/chromium/inspector/styles/device-metrics-fit-window.html trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp Diff Modified: trunk/LayoutTests/ChangeLog (120316 => 120317) --- trunk/LayoutTests/ChangeLog 2012-06-14 12:51:27 UTC (rev 120316) +++ trunk/LayoutTests/ChangeLog 2012-06-14 13:05:00 UTC (rev 120317) @@ -1,3 +1,13 @@ +2012-06-14 Alexander Pavlov + +Web Inspector: [Device Metrics] "Fit window" results in duplicate rescaling in WebDevToolsAgentImpl::autoZoomPageToFitWidth() +https://bugs.webkit.org/show_bug.cgi?id=89092 + +Reviewed by Pavel Feldman. + +* platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt: +* platform/chromium/inspector/styles/device-metrics-fit-window.html: + 2012-06-14 Kristóf Kosztyó [Qt] Unreviewed gardening after r120314. Modified: trunk/LayoutTests/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt (120316 => 120317) --- trunk/LayoutTests/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt 2012-06-14 12:51:27 UTC (rev 120316) +++ trunk/LayoutTests/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt 2012-06-14 13:05:00 UTC (rev 120317) @@ -1,5 +1,6 @@ Tests that emulating device metrics with "Fit window" for a small FrameView correctly downscales page content. -123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 -document: 780x585, #main: 1024x84 +123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123
[webkit-changes] [120315] trunk/Tools
Title: [120315] trunk/Tools Revision 120315 Author toyos...@chromium.org Date 2012-06-14 05:40:32 -0700 (Thu, 14 Jun 2012) Log Message Update pywebsocket to 0.7.6 from 0.7.4 https://bugs.webkit.org/show_bug.cgi?id=88975 Reviewed by Kent Tamura. This new version of pywebsocket introduce following features. - Allow handlers to send a close frame with empty body in response of a client initiated closing handshake - Implement perframe compression extension - Support client certificate authentication * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: (_create_control_frame): (Stream._receive_frame): (Stream.send_message): (Stream.receive_message): (Stream._send_closing_handshake): (Stream.close_connection): * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: (ExtensionParsingException): (ExtensionParsingException.__init__): (_parse_extension_param): (_parse_extension): (parse_extensions): (format_extension): (format_extensions): * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: (_parse_compression_method): (_create_accepted_method_desc): (PerFrameCompressionExtensionProcessor): (PerFrameCompressionExtensionProcessor.__init__): (PerFrameCompressionExtensionProcessor._lookup_compression_processor): (PerFrameCompressionExtensionProcessor._get_compression_processor_response): (PerFrameCompressionExtensionProcessor.get_extension_response): (PerFrameCompressionExtensionProcessor.setup_stream_options): (PerFrameCompressionExtensionProcessor.get_compression_processor): * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: (parse_token_list): * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: (Handshaker._parse_extensions): (Handshaker._send_handshake): * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: (WebSocketServer._create_sockets): (_get_logger_from_class): (_configure_logging): (_build_option_parser): (_main.if): * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: (RepeatedXorMasker.mask): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING trunk/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py trunk/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py trunk/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py trunk/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py trunk/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py trunk/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py trunk/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py Diff Modified: trunk/Tools/ChangeLog (120314 => 120315) --- trunk/Tools/ChangeLog 2012-06-14 12:18:15 UTC (rev 120314) +++ trunk/Tools/ChangeLog 2012-06-14 12:40:32 UTC (rev 120315) @@ -1,3 +1,56 @@ +2012-06-14 Takashi Toyoshima + +Update pywebsocket to 0.7.6 from 0.7.4 +https://bugs.webkit.org/show_bug.cgi?id=88975 + +Reviewed by Kent Tamura. + +This new version of pywebsocket introduce following features. + - Allow handlers to send a close frame with empty body in response of + a client initiated closing handshake + - Implement perframe compression extension + - Support client certificate authentication + +* Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: +* Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: +(_create_control_frame): +(Stream._receive_frame): +(Stream.send_message): +(Stream.receive_message): +(Stream._send_closing_handshake): +(Stream.close_connection): +* Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: +(ExtensionParsingException): +(ExtensionParsingException.__init__): +(_parse_extension_param): +(_parse_extension): +(parse_extensions): +(format_extension): +(format_extensions): +* Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: +(_parse_compression_method): +(_create_accepted_method_desc): +(PerFrameCompressionExtensionProcessor): +(PerFrameCompressionExtensionProcessor.__init__): +(PerFrameCompressionExtensionProcessor._lookup_compression_processor): +(PerFrameCompressionExtensionProcessor._get_compression_processor_response): +(PerFrameCompressionExtensionProcessor.get_extension_response): +(PerFrameCompressionExtensionProcessor.setup_stream_options): +(PerFrameCompressionExtensionProcessor.get_compression_processor): +* Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: +(parse_token_list): +* Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: +(Handshaker._parse_extensions): +(Handshaker._send_handshake): +* Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: +(WebSocketServer._cr
[webkit-changes] [120314] trunk
Title: [120314] trunk Revision 120314 Author commit-qu...@webkit.org Date 2012-06-14 05:18:15 -0700 (Thu, 14 Jun 2012) Log Message [svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations https://bugs.webkit.org/show_bug.cgi?id=64966 Patch by Dominik Röttsches on 2012-06-14 Reviewed by Nikolas Zimmermann. Source/WebCore: SVGInlineTextBox::paintTextWithShadows for non-CG implementations resets the scale aspect of the currently applied CTM. This leads to patterns and gradients being incorrectly downscaled. This way of resetting the CTM and drawing fonts "natively" scaled was introduced in r77485 to fix a number of issues with SVG font scaling. Unfortunately, this breaks scaling of patterns and gradients. To fix it, we need to push the transformation back into the pattern/gradient space transformation. Tests: svg/transforms/transformed-text-fill-gradient.html svg/transforms/transformed-text-fill-pattern.html * rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): Moving the scaling factor calculation out into SVGRenderingContext. * rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::shouldTransformOnTextPainting): Reusing the scaling factor calculation from SVGRenderingContext. (WebCore): * rendering/svg/RenderSVGResourceContainer.h: (RenderSVGResourceContainer): * rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource): If needed, push down transformation into gradient space. * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): If needed, push transformation into pattern space. * rendering/svg/SVGRenderingContext.cpp: (WebCore::SVGRenderingContext::calculateScreenFontSizeScalingFactor): Common scaling factor calculation for RenderSVGInlineText and RenderSVGResourceContainer. * rendering/svg/SVGRenderingContext.h: (SVGRenderingContext): LayoutTests: For Pattern: RefTest that compare a scaled rectangle with a scaled block of Ahem characters. The pattern or gradient should scale in the same way for the text and the rectangle. This approach needs a clipping path hack to work around micro gaps between Ahem characters due to rounding. For Gradient: Scaling text at two different scale factors and adjusting font size to yield the same effective text size. Gradient fill should be identical in both cases. * platform/chromium/TestExpectations: Added 3 tests that need rebaselining for text gradient fills. * svg/transforms/transformed-text-fill-gradient-expected.html: Added. * svg/transforms/transformed-text-fill-gradient.html: Added. * svg/transforms/transformed-text-fill-pattern-expected.html: Added. * svg/transforms/transformed-text-fill-pattern.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.h trunk/Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp trunk/Source/WebCore/rendering/svg/SVGRenderingContext.h Added Paths trunk/LayoutTests/svg/transforms/transformed-text-fill-gradient-expected.html trunk/LayoutTests/svg/transforms/transformed-text-fill-gradient.html trunk/LayoutTests/svg/transforms/transformed-text-fill-pattern-expected.html trunk/LayoutTests/svg/transforms/transformed-text-fill-pattern.html Diff Modified: trunk/LayoutTests/ChangeLog (120313 => 120314) --- trunk/LayoutTests/ChangeLog 2012-06-14 11:53:43 UTC (rev 120313) +++ trunk/LayoutTests/ChangeLog 2012-06-14 12:18:15 UTC (rev 120314) @@ -1,3 +1,23 @@ +2012-06-14 Dominik Röttsches + +[svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations +https://bugs.webkit.org/show_bug.cgi?id=64966 + +Reviewed by Nikolas Zimmermann. + +For Pattern: RefTest that compare a scaled rectangle with a scaled block of Ahem characters. +The pattern or gradient should scale in the same way for the text and the rectangle. +This approach needs a clipping path hack to work around micro gaps between Ahem characters +due to rounding. +For Gradient: Scaling text at two different scale factors and adjusting font size to yield the same effective text size. +Gradient fill should be identical in both cases. + +* platform/chromium/TestExpectations: Added 3 tests that need rebaselining for text gradient fills. +* svg/transforms/transformed-text-fill-gradient-expected.html: Added. +* svg/transforms/transformed-text-fill-gradient.html: Added. +* svg/transforms/transformed-text-fill-pattern-expected.html: Added. +
[webkit-changes] [120312] trunk/Source/WebKit/chromium
Title: [120312] trunk/Source/WebKit/chromium Revision 120312 Author yo...@chromium.org Date 2012-06-14 03:57:37 -0700 (Thu, 14 Jun 2012) Log Message [Chromium][Forms] We should remove ENABLE_INPUT_TYPE_TIME=0 and so on to allows us to override them by ~/.gyp/include.gypi https://bugs.webkit.org/show_bug.cgi?id=89062 Reviewed by Kent Tamura. This patch removes ENABLE_INPUT_TYPE_*=0 from default entry of feature_defines to allows us overriding by ~/.gyp/include.gypi * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME=0, ENABLE_INPUT_TYPE_DATETIMELOCAL=0, and so on. Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/features.gypi Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (120311 => 120312) --- trunk/Source/WebKit/chromium/ChangeLog 2012-06-14 10:34:26 UTC (rev 120311) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-14 10:57:37 UTC (rev 120312) @@ -1,3 +1,16 @@ +2012-06-14 Yoshifumi Inoue + +[Chromium][Forms] We should remove ENABLE_INPUT_TYPE_TIME=0 and so on to allows us to override them by ~/.gyp/include.gypi +https://bugs.webkit.org/show_bug.cgi?id=89062 + +Reviewed by Kent Tamura. + +This patch removes ENABLE_INPUT_TYPE_*=0 from default entry of feature_defines to +allows us overriding by ~/.gyp/include.gypi + +* features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME=0, ENABLE_INPUT_TYPE_DATETIMELOCAL=0, +and so on. + 2012-06-14 Min Qin Remove the const keyword from MediaPlayerPrivate::enterFullscreen() Modified: trunk/Source/WebKit/chromium/features.gypi (120311 => 120312) --- trunk/Source/WebKit/chromium/features.gypi 2012-06-14 10:34:26 UTC (rev 120311) +++ trunk/Source/WebKit/chromium/features.gypi 2012-06-14 10:57:37 UTC (rev 120312) @@ -163,11 +163,6 @@ 'ENABLE_FONT_BOOSTING=0', 'ENABLE_FULLSCREEN_MEDIA_CONTROLS=0', 'ENABLE_INPUT_SPEECH=1', - 'ENABLE_INPUT_TYPE_DATETIME=0', - 'ENABLE_INPUT_TYPE_DATETIMELOCAL=0', - 'ENABLE_INPUT_TYPE_MONTH=0', - 'ENABLE_INPUT_TYPE_TIME=0', - 'ENABLE_INPUT_TYPE_WEEK=0', 'ENABLE_JAVASCRIPT_I18N_API=1', 'ENABLE_LEGACY_NOTIFICATIONS=1', 'ENABLE_MEDIA_CAPTURE=0', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120311] trunk
Title: [120311] trunk Revision 120311 Author commit-qu...@webkit.org Date 2012-06-14 03:34:26 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: Implement ExtensionPanel.show() method https://bugs.webkit.org/show_bug.cgi?id=88473 Source/WebCore: Implemented ExtensionPanel.show() API method to allow extension developers to show their panel when needed. Patch by Jan Keromnes on 2012-06-14 Reviewed by Pavel Feldman. Tests for this method are in: LayoutTests/inspector/extensions/extensions-panel.html * inspector/front-end/ExtensionAPI.js: (defineCommonExtensionSymbols): (injectedExtensionAPI.ExtensionPanelImpl.prototype.createStatusBarButton): (injectedExtensionAPI.ExtensionPanelImpl.prototype.show): * inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onShowPanel): LayoutTests: Add output for ExtensionPanel callbacks, and use ExtensionPanel.show() to show the panel. Fix expected. Patch by Jan Keromnes on 2012-06-14 Reviewed by Pavel Feldman. * inspector/extensions/extensions-panel-expected.txt: * inspector/extensions/extensions-panel.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/extensions/extensions-panel-expected.txt trunk/LayoutTests/inspector/extensions/extensions-panel.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js trunk/Source/WebCore/inspector/front-end/ExtensionServer.js Diff Modified: trunk/LayoutTests/ChangeLog (120310 => 120311) --- trunk/LayoutTests/ChangeLog 2012-06-14 10:31:33 UTC (rev 120310) +++ trunk/LayoutTests/ChangeLog 2012-06-14 10:34:26 UTC (rev 120311) @@ -1,3 +1,16 @@ +2012-06-14 Jan Keromnes + +Web Inspector: Implement ExtensionPanel.show() method +https://bugs.webkit.org/show_bug.cgi?id=88473 + +Add output for ExtensionPanel callbacks, and use ExtensionPanel.show() +to show the panel. Fix expected. + +Reviewed by Pavel Feldman. + +* inspector/extensions/extensions-panel-expected.txt: +* inspector/extensions/extensions-panel.html: + 2012-06-14 David Barr Add dpcm to css3-images image-resolution Modified: trunk/LayoutTests/inspector/extensions/extensions-panel-expected.txt (120310 => 120311) --- trunk/LayoutTests/inspector/extensions/extensions-panel-expected.txt 2012-06-14 10:31:33 UTC (rev 120310) +++ trunk/LayoutTests/inspector/extensions/extensions-panel-expected.txt 2012-06-14 10:34:26 UTC (rev 120311) @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: line 8: hello Tests WebInspector extension API Started extension. @@ -18,8 +19,10 @@ removeListener : } createStatusBarButton : +show : } Extension panel size correct +Panel shown RUNNING TEST: extension_testStatusBarButtons Created a status bar button, dump follows: { @@ -29,6 +32,7 @@ } update : } +Panel hidden button1 clicked Status bar buttons state: status bar item 0, icon: .../inspector/resources/button1.png, tooltip: 'Button One tooltip', disabled: false Modified: trunk/LayoutTests/inspector/extensions/extensions-panel.html (120310 => 120311) --- trunk/LayoutTests/inspector/extensions/extensions-panel.html 2012-06-14 10:31:33 UTC (rev 120310) +++ trunk/LayoutTests/inspector/extensions/extensions-panel.html 2012-06-14 10:34:26 UTC (rev 120311) @@ -3,6 +3,10 @@
[webkit-changes] [120310] trunk/Tools
Title: [120310] trunk/Tools Revision 120310 Author zol...@webkit.org Date 2012-06-14 03:31:33 -0700 (Thu, 14 Jun 2012) Log Message [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore Reviewed by Noam Rosenthal. * qmake/mkspecs/features/features.prf: Modified Paths trunk/Tools/ChangeLog trunk/Tools/qmake/mkspecs/features/features.prf Property Changed trunk/Tools/qmake/mkspecs/features/features.prf Diff Modified: trunk/Tools/ChangeLog (120309 => 120310) --- trunk/Tools/ChangeLog 2012-06-14 10:27:18 UTC (rev 120309) +++ trunk/Tools/ChangeLog 2012-06-14 10:31:33 UTC (rev 120310) @@ -1,3 +1,11 @@ +2012-06-14 Zoltan Horvath + +[Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore + +Reviewed by Noam Rosenthal. + +* qmake/mkspecs/features/features.prf: + 2012-06-14 Christophe Dumez [WK2] Add implementation for registerIntentService in WebFrameLoaderClient Modified: trunk/Tools/qmake/mkspecs/features/features.prf (120309 => 120310) --- trunk/Tools/qmake/mkspecs/features/features.prf 2012-06-14 10:27:18 UTC (rev 120309) +++ trunk/Tools/qmake/mkspecs/features/features.prf 2012-06-14 10:31:33 UTC (rev 120310) @@ -78,8 +78,6 @@ haveQt(5):contains(config_test_libzlib, yes): DEFINES += WTF_USE_ZLIB=1 } -!contains(DEFINES, WTF_USE_QT_IMAGE_DECODER=.): DEFINES += WTF_USE_QT_IMAGE_DECODER=1 - # Tiled Backing Store support !contains(DEFINES, WTF_USE_TILED_BACKING_STORE=.): DEFINES += WTF_USE_TILED_BACKING_STORE=1 Property changes on: trunk/Tools/qmake/mkspecs/features/features.prf ___ Added: svn:executable ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120309] trunk/Source/WebCore
Title: [120309] trunk/Source/WebCore Revision 120309 Author tk...@chromium.org Date 2012-06-14 03:27:18 -0700 (Thu, 14 Jun 2012) Log Message Fix a typo in r120304. https://bugs.webkit.org/show_bug.cgi?id=89070 * bindings/scripts/CodeGeneratorV8.pm: (NativeToJSValue): * bindings/scripts/test/V8/V8TestObj.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (120308 => 120309) --- trunk/Source/WebCore/ChangeLog 2012-06-14 10:20:51 UTC (rev 120308) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 10:27:18 UTC (rev 120309) @@ -1,3 +1,12 @@ +2012-06-14 Kent Tamura + +Fix a typo in r120304. +https://bugs.webkit.org/show_bug.cgi?id=89070 + +* bindings/scripts/CodeGeneratorV8.pm: +(NativeToJSValue): +* bindings/scripts/test/V8/V8TestObj.cpp: + 2012-06-14 David Barr Add dpcm to css3-images image-resolution Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (120308 => 120309) --- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-06-14 10:20:51 UTC (rev 120308) +++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-06-14 10:27:18 UTC (rev 120309) @@ -3867,7 +3867,7 @@ if ($arrayType) { if ($type eq "DOMString[]") { AddToImplIncludes("V8DOMStringList.h"); -AddToImplIncludes("DOMStrignList.h"); +AddToImplIncludes("DOMStringList.h"); } elsif (!$codeGenerator->SkipIncludeHeader($arrayType)) { AddToImplIncludes("V8$arrayType.h"); AddToImplIncludes("$arrayType.h"); Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (120308 => 120309) --- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-06-14 10:20:51 UTC (rev 120308) +++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-06-14 10:27:18 UTC (rev 120309) @@ -22,7 +22,7 @@ #include "V8TestObj.h" #include "ContextFeatures.h" -#include "DOMStrignList.h" +#include "DOMStringList.h" #include "Dictionary.h" #include "ExceptionCode.h" #include "HTMLNames.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120308] trunk
Title: [120308] trunk Revision 120308 Author commit-qu...@webkit.org Date 2012-06-14 03:20:51 -0700 (Thu, 14 Jun 2012) Log Message Add dpcm to css3-images image-resolution https://bugs.webkit.org/show_bug.cgi?id=85442 Patch by David Barr on 2012-06-14 Reviewed by Tony Chang. Source/WebCore: The css3-images module is at candidate recommendation. http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-resolution No new tests; extended fast/css/image-resolution/image-resolution.html * css/CSSGrammar.y: Add DPCM token and unary term. * css/CSSParser.cpp: Extend range of units accepted for resolution and tokenize "dpcm". (WebCore::CSSParser::validUnit): Accept CSSPrimitiveValue::CSS_DPCM. (WebCore::CSSParser::createPrimitiveNumericValue): Accept CSSPrimitiveValue::CSS_DPCM. (WebCore::unitFromString): Map "dpcm" to CSSPrimitiveValue::CSS_DPCM. (WebCore::CSSParser::parseValidPrimitive): Accept CSSPrimitiveValue::CSS_DPCM. (WebCore::CSSParser::detectNumberToken): Map "dpcm" to CSSPrimitiveValue::CSS_DPCM. * css/CSSPrimitiveValue.cpp: Add CSSPrimitiveValue::CSS_DPCM as a numeric unit. (WebCore::isValidCSSUnitTypeForDoubleConversion): Accept CSSPrimitiveValue::CSS_DPCM. (WebCore::unitCategory): Map CSSPrimitiveValue::CSS_DPCM to CSSPrimitiveValue::UResolution. (WebCore::conversionToCanonicalUnitsScaleFactor): Scale CSSPrimitiveValue::CSS_DPCM to CSSPrimitiveValue::CSS_DPPX. (WebCore::CSSPrimitiveValue::customCssText): Format CSSPrimitiveValue::CSS_DPCM as "dpcm". (WebCore::CSSPrimitiveValue::cloneForCSSOM): Accept CSSPrimitiveValue::CSS_DPCM as numeric unit. * css/CSSPrimitiveValue.h: Add CSSPrimitiveValue::CSS_DPCM. LayoutTests: * fast/css/image-resolution/image-resolution-expected.txt: * fast/css/image-resolution/image-resolution.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/image-resolution/image-resolution-expected.txt trunk/LayoutTests/fast/css/image-resolution/image-resolution.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSGrammar.y trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSPrimitiveValue.cpp trunk/Source/WebCore/css/CSSPrimitiveValue.h Diff Modified: trunk/LayoutTests/ChangeLog (120307 => 120308) --- trunk/LayoutTests/ChangeLog 2012-06-14 10:16:42 UTC (rev 120307) +++ trunk/LayoutTests/ChangeLog 2012-06-14 10:20:51 UTC (rev 120308) @@ -1,3 +1,13 @@ +2012-06-14 David Barr + +Add dpcm to css3-images image-resolution +https://bugs.webkit.org/show_bug.cgi?id=85442 + +Reviewed by Tony Chang. + +* fast/css/image-resolution/image-resolution-expected.txt: +* fast/css/image-resolution/image-resolution.html: + 2012-06-14 Matt Falkenhagen LocaleToScriptMappingDefault.cpp should also do what scriptCodeForFontSelection does in LocaleToScriptMappingICU.cpp Modified: trunk/LayoutTests/fast/css/image-resolution/image-resolution-expected.txt (120307 => 120308) --- trunk/LayoutTests/fast/css/image-resolution/image-resolution-expected.txt 2012-06-14 10:16:42 UTC (rev 120307) +++ trunk/LayoutTests/fast/css/image-resolution/image-resolution-expected.txt 2012-06-14 10:20:51 UTC (rev 120308) @@ -55,6 +55,24 @@ PASS img.style.cssText is "image-resolution: 600dpi; " PASS img.offsetWidth is 2 PASS img.offsetHeight is 2 +TEST "0dpcm" +PASS img.style.cssText is "" +TEST "37.7dpcm" +PASS img.style.cssText is "image-resolution: 37.7dpcm; " +PASS img.offsetWidth is 16 +PASS img.offsetHeight is 16 +TEST "75.5dpcm" +PASS img.style.cssText is "image-resolution: 75.5dpcm; " +PASS img.offsetWidth is 8 +PASS img.offsetHeight is 8 +TEST "113.3dpcm" +PASS img.style.cssText is "image-resolution: 113.3dpcm; " +PASS img.offsetWidth is 5 +PASS img.offsetHeight is 5 +TEST "151.1dpcm" +PASS img.style.cssText is "image-resolution: 151.1dpcm; " +PASS img.offsetWidth is 4 +PASS img.offsetHeight is 4 TEST "" PASS img.style.cssText is "" PASS successfullyParsed is true Modified: trunk/LayoutTests/fast/css/image-resolution/image-resolution.html (120307 => 120308) --- trunk/LayoutTests/fast/css/image-resolution/image-resolution.html 2012-06-14 10:16:42 UTC (rev 120307) +++ trunk/LayoutTests/fast/css/image-resolution/image-resolution.html 2012-06-14 10:20:51 UTC (rev 120308) @@ -61,7 +61,8 @@ var resolutions = ['0dppx', '1dppx', '2dppx', '3dppx', '4dppx', '0dpi', '96dpi', '192dpi', '288dpi', '384dpi', - '150dpi', '300dpi', '450dpi', '600dpi', '']; + '150dpi', '300dpi', '450dpi', '600dpi', + '0dpcm', '37.7dpcm', '75.5dpcm', '113.3dpcm', '151.1dpcm', '']; img._onload_ = function() { resolutions.forEach(function(test) { Modified: trunk/Source/WebCore/ChangeLog (120307 => 120308) --- trunk/Source/WebCore/ChangeLog 2012-06-14 10:16:42 UTC (rev 120307) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 10:20:51 UTC (rev 120308) @@ -1,3 +1,30 @@ +2012-06-14 David Barr + +Add dpcm to css3-images image-resol
[webkit-changes] [120307] branches/chromium/1132/Source/WebCore/inspector/front-end/ DebuggerPresentationModel.js
Title: [120307] branches/chromium/1132/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js Revision 120307 Author vse...@chromium.org Date 2012-06-14 03:16:42 -0700 (Thu, 14 Jun 2012) Log Message Merge 120214 - Web Inspector: Errors when pending console messages are attached to _javascript_SourceFrame. https://bugs.webkit.org/show_bug.cgi?id=88712 Reviewed by Pavel Feldman. * inspector/front-end/PresentationConsoleMessageHelper.js: (WebInspector.PresentationConsoleMessageHelper): (WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage): (WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource): TBR=vse...@chromium.org BUG=132449 ---All lines above this line become the description. ---Repository Root: /home/vsevik/webkit_merges/drover_120214_1132/1132 ---Paths in this changelist (120214): ---Paths modified but not in any changelist: ! Source/WebCore/inspector/front-end/PresentationConsoleMessageHelper.js Review URL: https://chromiumcodereview.appspot.com/10548044 Modified Paths branches/chromium/1132/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js Diff Modified: branches/chromium/1132/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (120306 => 120307) --- branches/chromium/1132/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-06-14 10:13:16 UTC (rev 120306) +++ branches/chromium/1132/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-06-14 10:16:42 UTC (rev 120307) @@ -256,7 +256,7 @@ var message = messages[i]; var rawLocation = message.location(); if (script.scriptId === rawLocation.scriptId) -this._addConsoleMessageToScript(messages, rawLocation); +this._addConsoleMessageToScript(message, rawLocation); else pendingMessages.push(message); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120306] trunk/Source/WebCore
Title: [120306] trunk/Source/WebCore Revision 120306 Author loi...@chromium.org Date 2012-06-14 03:13:16 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: REGRESSION HeapProfiler can't remove heap snapshot from the list if Dominators view has been opened. https://bugs.webkit.org/show_bug.cgi?id=89080 There was no dispose method on artificial ShowMoreDataGrid node. Reviewed by Pavel Feldman. * inspector/front-end/ShowMoreDataGridNode.js: (WebInspector.ShowMoreDataGridNode.prototype.nodeHeight): (WebInspector.ShowMoreDataGridNode.prototype.dispose): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/ShowMoreDataGridNode.js Diff Modified: trunk/Source/WebCore/ChangeLog (120305 => 120306) --- trunk/Source/WebCore/ChangeLog 2012-06-14 10:10:05 UTC (rev 120305) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 10:13:16 UTC (rev 120306) @@ -1,3 +1,16 @@ +2012-06-14 Ilya Tikhonovsky + +Web Inspector: REGRESSION HeapProfiler can't remove heap snapshot from the list if Dominators view has been opened. +https://bugs.webkit.org/show_bug.cgi?id=89080 + +There was no dispose method on artificial ShowMoreDataGrid node. + +Reviewed by Pavel Feldman. + +* inspector/front-end/ShowMoreDataGridNode.js: +(WebInspector.ShowMoreDataGridNode.prototype.nodeHeight): +(WebInspector.ShowMoreDataGridNode.prototype.dispose): + 2012-06-14 Kent Tamura [JSC/V8] Improve DOMString[] support Modified: trunk/Source/WebCore/inspector/front-end/ShowMoreDataGridNode.js (120305 => 120306) --- trunk/Source/WebCore/inspector/front-end/ShowMoreDataGridNode.js 2012-06-14 10:10:05 UTC (rev 120305) +++ trunk/Source/WebCore/inspector/front-end/ShowMoreDataGridNode.js 2012-06-14 10:13:16 UTC (rev 120306) @@ -136,6 +136,10 @@ nodeHeight: function() { return 32; +}, + +dispose: function() +{ } }; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120305] trunk/Source/WebKit2
Title: [120305] trunk/Source/WebKit2 Revision 120305 Author carlo...@webkit.org Date 2012-06-14 03:10:05 -0700 (Thu, 14 Jun 2012) Log Message [GTK] Add input methods submenu item to the default context menu for editable content https://bugs.webkit.org/show_bug.cgi?id=80600 Reviewed by Martin Robinson. * GNUmakefile.am: Add new files to compilation. * UIProcess/API/gtk/WebKitContextMenuClient.cpp: Added. (getContextMenuFromProposedMenu): Call webkitWebViewContextMenu(). (attachContextMenuClientToView): Add implementation for getContextMenuFromProposedMenu callback. * UIProcess/API/gtk/WebKitContextMenuClient.h: Added. * UIProcess/API/gtk/WebKitWebView.cpp: (webkitWebViewConstructed): Attach context menu client to view. (webkitWebViewCreateAndAppendDefaultMenuItems): Helper function to add default context menu items to the new context menu items vector. (webkitWebViewShouldShowInputMethodsMenu): Helper function to check whether to show the input methods submenu according to the gtk-show-input-method-menu GTK+ setting. (webkitWebViewCreateAndAppendInputMethodsMenuItem): Helper function to add input methods submenu to the new context menu items vector. (webkitWebViewContextMenu): Create a new context menu items vector containing default items and input methods submenu in case of editable content. The active content menu is populated using that new vector. * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseSetActiveContextMenu): Set the active context menu. (webkitWebViewBaseGetActiveContextMenu): Get the active context menu. * UIProcess/API/gtk/WebKitWebViewBasePrivate.h: * UIProcess/API/gtk/WebKitWebViewPrivate.h: * UIProcess/gtk/WebContextMenuProxyGtk.cpp: (WebKit::WebContextMenuProxyGtk::append): Helper method to add a new item to the context menu. (WebKit::WebContextMenuProxyGtk::populate): Add items to the context menu. (WebKit::WebContextMenuProxyGtk::showContextMenu): Populate the menu with the given items and popup the menu if it's not empty. (WebKit::WebContextMenuProxyGtk::hideContextMenu): Get the GtkMenu from the WebCore ContextMenu to popdown it. (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Call webkitWebViewBaseSetActiveContextMenu() to set the menu as the current active one for the view. (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Call webkitWebViewBaseSetActiveContextMenu() with NULL to reset the current active context of the view. GtkMenu is destroyed by WebCore ContextMenu in its destructor. * UIProcess/gtk/WebContextMenuProxyGtk.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.list.am trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h Added Paths trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuClient.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuClient.h Diff Modified: trunk/Source/WebKit2/ChangeLog (120304 => 120305) --- trunk/Source/WebKit2/ChangeLog 2012-06-14 09:59:20 UTC (rev 120304) +++ trunk/Source/WebKit2/ChangeLog 2012-06-14 10:10:05 UTC (rev 120305) @@ -1,3 +1,53 @@ +2012-06-14 Carlos Garcia Campos + +[GTK] Add input methods submenu item to the default context menu for editable content +https://bugs.webkit.org/show_bug.cgi?id=80600 + +Reviewed by Martin Robinson. + +* GNUmakefile.am: Add new files to compilation. +* UIProcess/API/gtk/WebKitContextMenuClient.cpp: Added. +(getContextMenuFromProposedMenu): Call webkitWebViewContextMenu(). +(attachContextMenuClientToView): Add implementation for +getContextMenuFromProposedMenu callback. +* UIProcess/API/gtk/WebKitContextMenuClient.h: Added. +* UIProcess/API/gtk/WebKitWebView.cpp: +(webkitWebViewConstructed): Attach context menu client to view. +(webkitWebViewCreateAndAppendDefaultMenuItems): Helper function to +add default context menu items to the new context menu items vector. +(webkitWebViewShouldShowInputMethodsMenu): Helper function to +check whether to show the input methods submenu according to the +gtk-show-input-method-menu GTK+ setting. +(webkitWebViewCreateAndAppendInputMethodsMenuItem): Helper +function to add input methods submenu to the new context menu +items vector. +(webkitWebViewContextMenu): Create a new context menu items vector +containing default items and input methods submenu in case of +editable content. The active content menu is populated using that +new vector. +* UIProcess/API/gtk/WebKitWebViewBase.cpp: +(webkitWebViewBaseSetActiveContextMenu): Set the active context menu. +(
[webkit-changes] [120304] trunk/Source/WebCore
Title: [120304] trunk/Source/WebCore Revision 120304 Author tk...@chromium.org Date 2012-06-14 02:59:20 -0700 (Thu, 14 Jun 2012) Log Message [JSC/V8] Improve DOMString[] support https://bugs.webkit.org/show_bug.cgi?id=89070 Reviewed by Kentaro Hara. Tests: new test case in TestObj.idl * bindings/js/JSDOMBinding.cpp: (WebCore::jsArray): Implement jsArray() for DOMStringList. * bindings/js/JSDOMBinding.h: Declare jsArray() for DOMStringList. * bindings/scripts/CodeGeneratorJS.pm: (NativeToJSValue): Avoid to include JSDOMString.h and DOMString.h. * bindings/scripts/CodeGeneratorV8.pm: (GetNativeType): Move a check for DOMString[] because it's a RefPtr type and we'd like to avoid to generate RefPtr (%non_wrapper_types): DOMString[] is not a wrapper type. This is needed to avoid to generate unnecessary custom function template. (NativeToJSValue): Avoid to include V8DOMString.h and DOMString.h. * bindings/scripts/test/TestObj.idl: Add non-overload function using DOMString[]. * bindings/scripts/test/JS/JSTestObj.cpp: Update expectation. * bindings/scripts/test/JS/JSTestObj.h: ditto. * bindings/scripts/test/V8/V8TestObj.cpp: ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp trunk/Source/WebCore/bindings/js/JSDOMBinding.h trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h trunk/Source/WebCore/bindings/scripts/test/TestObj.idl trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (120303 => 120304) --- trunk/Source/WebCore/ChangeLog 2012-06-14 09:56:06 UTC (rev 120303) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 09:59:20 UTC (rev 120304) @@ -1,3 +1,29 @@ +2012-06-14 Kent Tamura + +[JSC/V8] Improve DOMString[] support +https://bugs.webkit.org/show_bug.cgi?id=89070 + +Reviewed by Kentaro Hara. + +Tests: new test case in TestObj.idl + +* bindings/js/JSDOMBinding.cpp: +(WebCore::jsArray): Implement jsArray() for DOMStringList. +* bindings/js/JSDOMBinding.h: Declare jsArray() for DOMStringList. +* bindings/scripts/CodeGeneratorJS.pm: +(NativeToJSValue): Avoid to include JSDOMString.h and DOMString.h. +* bindings/scripts/CodeGeneratorV8.pm: +(GetNativeType): Move a check for DOMString[] because it's a RefPtr type +and we'd like to avoid to generate RefPtr +(%non_wrapper_types): DOMString[] is not a wrapper type. This is needed +to avoid to generate unnecessary custom function template. +(NativeToJSValue): Avoid to include V8DOMString.h and DOMString.h. + +* bindings/scripts/test/TestObj.idl: Add non-overload function using DOMString[]. +* bindings/scripts/test/JS/JSTestObj.cpp: Update expectation. +* bindings/scripts/test/JS/JSTestObj.h: ditto. +* bindings/scripts/test/V8/V8TestObj.cpp: ditto. + 2012-06-14 Matt Falkenhagen LocaleToScriptMappingDefault.cpp should also do what scriptCodeForFontSelection does in LocaleToScriptMappingICU.cpp Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp (120303 => 120304) --- trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2012-06-14 09:56:06 UTC (rev 120303) +++ trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2012-06-14 09:59:20 UTC (rev 120304) @@ -22,6 +22,7 @@ #include "JSDOMBinding.h" #include "DOMObjectHashTableMap.h" +#include "DOMStringList.h" #include "ExceptionCode.h" #include "ExceptionHeaders.h" #include "ExceptionInterfaces.h" @@ -146,6 +147,16 @@ return static_cast(value.toObject(exec))->internalNumber(); } +JSC::JSValue jsArray(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, PassRefPtr stringList) +{ +if (!stringList) +return jsNull(); +JSC::MarkedArgumentBuffer list; +for (unsigned i = 0; i < stringList->length(); ++i) +list.append(jsString(exec, stringList->item(i))); +return JSC::constructArray(exec, globalObject, list); +} + void reportException(ExecState* exec, JSValue exception) { if (isTerminatedExecutionException(exception)) Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (120303 => 120304) --- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2012-06-14 09:56:06 UTC (rev 120303) +++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2012-06-14 09:59:20 UTC (rev 120304) @@ -44,6 +44,8 @@ namespace WebCore { +class DOMStringList; + enum ParameterDefaultPolicy { DefaultIsUndefined, DefaultIsNullString @@ -291,6 +293,8 @@ return JSC::constructArray(exec, globalObject, list); } +JSC::JSValue jsArray(JSC::ExecState*, JSDOMGlobalObject*, PassRefPtr); + template<> inline JSC::JSValue jsArray(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, const Vector& iterator)
[webkit-changes] [120303] trunk
Title: [120303] trunk Revision 120303 Author commit-qu...@webkit.org Date 2012-06-14 02:56:06 -0700 (Thu, 14 Jun 2012) Log Message LocaleToScriptMappingDefault.cpp should also do what scriptCodeForFontSelection does in LocaleToScriptMappingICU.cpp https://bugs.webkit.org/show_bug.cgi?id=88845 Patch by Matt Falkenhagen on 2012-06-14 Reviewed by Kent Tamura. Source/WebCore: Test: fast/text/international/jpan-script-equivalence.html * platform/text/LocaleToScriptMappingDefault.cpp: (WebCore::scriptNameToCode): LayoutTests: * fast/text/international/jpan-script-equivalence-expected.html: Added. * fast/text/international/jpan-script-equivalence.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp Added Paths trunk/LayoutTests/fast/text/international/jpan-script-equivalence-expected.html trunk/LayoutTests/fast/text/international/jpan-script-equivalence.html Diff Modified: trunk/LayoutTests/ChangeLog (120302 => 120303) --- trunk/LayoutTests/ChangeLog 2012-06-14 09:52:50 UTC (rev 120302) +++ trunk/LayoutTests/ChangeLog 2012-06-14 09:56:06 UTC (rev 120303) @@ -1,3 +1,13 @@ +2012-06-14 Matt Falkenhagen + +LocaleToScriptMappingDefault.cpp should also do what scriptCodeForFontSelection does in LocaleToScriptMappingICU.cpp +https://bugs.webkit.org/show_bug.cgi?id=88845 + +Reviewed by Kent Tamura. + +* fast/text/international/jpan-script-equivalence-expected.html: Added. +* fast/text/international/jpan-script-equivalence.html: Added. + 2012-06-14 Edaena Salinas Jasso el.getAttribute('type') returns 'null' when setting el.type to null Added: trunk/LayoutTests/fast/text/international/jpan-script-equivalence-expected.html (0 => 120303) --- trunk/LayoutTests/fast/text/international/jpan-script-equivalence-expected.html (rev 0) +++ trunk/LayoutTests/fast/text/international/jpan-script-equivalence-expected.html 2012-06-14 09:56:06 UTC (rev 120303) @@ -0,0 +1,15 @@ + + + + + + +this is ahem font +this is ahem font +this is ahem font +this is ahem font +this is ahem font +this is ahem font + + + Added: trunk/LayoutTests/fast/text/international/jpan-script-equivalence.html (0 => 120303) --- trunk/LayoutTests/fast/text/international/jpan-script-equivalence.html (rev 0) +++ trunk/LayoutTests/fast/text/international/jpan-script-equivalence.html 2012-06-14 09:56:06 UTC (rev 120303) @@ -0,0 +1,25 @@ + + + + +if (window.internals) { +window.internals.settings.setStandardFontFamily("Ahem", "Hrkt"); +window.internals.settings.setStandardFontFamily("Ahem", "Hang"); +} + + + + + +this is ahem font +this is ahem font +this is ahem font +this is ahem font +this is ahem font +this is ahem font + + + Modified: trunk/Source/WebCore/ChangeLog (120302 => 120303) --- trunk/Source/WebCore/ChangeLog 2012-06-14 09:52:50 UTC (rev 120302) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 09:56:06 UTC (rev 120303) @@ -1,3 +1,15 @@ +2012-06-14 Matt Falkenhagen + +LocaleToScriptMappingDefault.cpp should also do what scriptCodeForFontSelection does in LocaleToScriptMappingICU.cpp +https://bugs.webkit.org/show_bug.cgi?id=88845 + +Reviewed by Kent Tamura. + +Test: fast/text/international/jpan-script-equivalence.html + +* platform/text/LocaleToScriptMappingDefault.cpp: +(WebCore::scriptNameToCode): + 2012-06-14 Pavel Feldman Web Inspector: render dock-to-right icon in status bar. Modified: trunk/Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp (120302 => 120303) --- trunk/Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp 2012-06-14 09:52:50 UTC (rev 120302) +++ trunk/Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp 2012-06-14 09:56:06 UTC (rev 120303) @@ -44,6 +44,10 @@ UScriptCode code; }; +// This generally maps an ISO 15924 script code to its UScriptCode, but certain families of script codes are +// treated as a single script for assigning a per-script font in Settings. For example, "hira" is mapped to +// USCRIPT_KATAKANA_OR_HIRAGANA instead of USCRIPT_HIRAGANA, since we want all Japanese scripts to be rendered +// using the same font setting. static const ScriptNameCode scriptNameCodeList[] = { { "zyyy", USCRIPT_COMMON }, { "qaai", USCRIPT_INHERITED }, @@ -65,9 +69,9 @@ { "hani", USCRIPT_HAN }, { "hang", USCRIPT_HANGUL }, { "hebr", USCRIPT_HEBREW }, -{ "hira", USCRIPT_HIRAGANA }, +{ "hira", USCRIPT_KATAKANA_OR_HIRAGANA }, { "knda", USCRIPT_KANNADA }, -{ "kana", USCRIPT_KATAKANA }, +{ "kana", USCRIPT_KATAKANA_OR_HIRAGANA }, { "khmr", USCRIPT_KHMER }, { "laoo", USCRIPT_LAO }, { "latn", USCRIPT_LATIN }, @@ -147,6 +151,8 @@ { "vaii", USCRIPT_VAI },
[webkit-changes] [120302] trunk/Source/WebCore
Title: [120302] trunk/Source/WebCore Revision 120302 Author pfeld...@chromium.org Date 2012-06-14 02:52:50 -0700 (Thu, 14 Jun 2012) Log Message Web Inspector: render dock-to-right icon in status bar. https://bugs.webkit.org/show_bug.cgi?id=89040 Reviewed by Vsevolod Vlasov. Today we render dock to bottom icon for both actions (dock to bottom and dock to right). * inspector/front-end/Images/statusbarButtonGlyphs.png: * inspector/front-end/inspector.css: (button.dock-status-bar-item.status-bar-item.toggled-undock .glyph): (button.dock-status-bar-item.status-bar-item.toggled-bottom .glyph): (button.dock-status-bar-item.status-bar-item.toggled-right .glyph): * inspector/front-end/inspector.js: (WebInspector._createGlobalStatusBarItems): (WebInspector._installDockToRight.listener): (windowLoaded): (WebInspector.setDockingUnavailable): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/Images/statusbarButtonGlyphs.png trunk/Source/WebCore/inspector/front-end/inspector.css trunk/Source/WebCore/inspector/front-end/inspector.js Diff Modified: trunk/Source/WebCore/ChangeLog (120301 => 120302) --- trunk/Source/WebCore/ChangeLog 2012-06-14 09:43:25 UTC (rev 120301) +++ trunk/Source/WebCore/ChangeLog 2012-06-14 09:52:50 UTC (rev 120302) @@ -1,5 +1,25 @@ 2012-06-14 Pavel Feldman +Web Inspector: render dock-to-right icon in status bar. +https://bugs.webkit.org/show_bug.cgi?id=89040 + +Reviewed by Vsevolod Vlasov. + +Today we render dock to bottom icon for both actions (dock to bottom and dock to right). + +* inspector/front-end/Images/statusbarButtonGlyphs.png: +* inspector/front-end/inspector.css: +(button.dock-status-bar-item.status-bar-item.toggled-undock .glyph): +(button.dock-status-bar-item.status-bar-item.toggled-bottom .glyph): +(button.dock-status-bar-item.status-bar-item.toggled-right .glyph): +* inspector/front-end/inspector.js: +(WebInspector._createGlobalStatusBarItems): +(WebInspector._installDockToRight.listener): +(windowLoaded): +(WebInspector.setDockingUnavailable): + +2012-06-14 Pavel Feldman + Web Inspector: clear execution live before the text edit. https://bugs.webkit.org/show_bug.cgi?id=89016 Modified: trunk/Source/WebCore/inspector/front-end/Images/statusbarButtonGlyphs.png (Binary files differ) Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (120301 => 120302) --- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-06-14 09:43:25 UTC (rev 120301) +++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-06-14 09:52:50 UTC (rev 120302) @@ -568,15 +568,20 @@ -webkit-mask-image: url(Images/statusbarButtonGlyphs.png); } -button.dock-status-bar-item.status-bar-item .glyph { +button.dock-status-bar-item.status-bar-item.toggled-undock .glyph { -webkit-mask-position: 0 -48px; } -button.dock-status-bar-item.status-bar-item.toggled-on .glyph { +button.dock-status-bar-item.status-bar-item.toggled-bottom .glyph { -webkit-mask-position: -32px -24px; background-color: rgba(0, 0, 0, 0.75); } +button.dock-status-bar-item.status-bar-item.toggled-right .glyph { +-webkit-mask-position: -256px -48px; +background-color: rgba(0, 0, 0, 0.75); +} + button.settings-status-bar-item { position: absolute; right: 0; Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (120301 => 120302) --- trunk/Source/WebCore/inspector/front-end/inspector.js 2012-06-14 09:43:25 UTC (rev 120301) +++ trunk/Source/WebCore/inspector/front-end/inspector.js 2012-06-14 09:52:50 UTC (rev 120302) @@ -70,10 +70,9 @@ _createGlobalStatusBarItems: function() { -this._dockToggleButton = new WebInspector.StatusBarButton(this._dockButtonTitle(), "dock-status-bar-item"); +this._dockToggleButton = new WebInspector.StatusBarButton("", "dock-status-bar-item", 3); this._dockToggleButton.addEventListener("click", this._toggleAttach.bind(this), false); -this._dockToggleButton.toggled = !this.attached; -WebInspector.updateDockToggleButton(); +this._updateDockButtonState(); var anchoredStatusBar = document.getElementById("anchored-status-bar-items"); anchoredStatusBar.appendChild(this._dockToggleButton.element); @@ -87,9 +86,20 @@ anchoredStatusBar.appendChild(this.settingsController.statusBarItem); }, -_dockButtonTitle: function() +_updateDockButtonState: function() { -return this.attached ? WebInspector.UIString("Undock into separate window.") : WebInspector.UIString("Dock to main window."); +if (!this._dockToggleButton) +return; + +if (this.attached) { +this._dockToggleButton.disabled = false; +this._dockToggleButton.state = "undock"; +this._dockToggleButton.title = WebInspector.UIString("Un
[webkit-changes] [120301] trunk
Title: [120301] trunk Revision 120301 Author commit-qu...@webkit.org Date 2012-06-14 02:43:25 -0700 (Thu, 14 Jun 2012) Log Message [WK2] Add implementation for registerIntentService in WebFrameLoaderClient https://bugs.webkit.org/show_bug.cgi?id=88399 Patch by Christophe Dumez on 2012-06-14 Reviewed by Kenneth Rohde Christiansen. Source/WebKit2: Add implementation for registerIntentService() in WebFrameLoaderClient. * CMakeLists.txt: * GNUmakefile.list.am: * Shared/API/c/WKBase.h: * Shared/APIClientTraits.h: * Shared/APIObject.h: * Shared/IntentServiceInfo.cpp: Added. (WebKit): (WebKit::IntentServiceInfo::encode): (WebKit::IntentServiceInfo::decode): * Shared/IntentServiceInfo.h: Added. (CoreIPC): (WebKit): (IntentServiceInfo): * Target.pri: * UIProcess/API/C/WKAPICast.h: (WebKit): * UIProcess/API/C/WKPage.h: * UIProcess/API/gtk/WebKitLoaderClient.cpp: (attachLoaderClientToView): * UIProcess/WebIntentServiceInfo.cpp: Added. (WebKit): (WebKit::WebIntentServiceInfo::WebIntentServiceInfo): * UIProcess/WebIntentServiceInfo.h: Added. (WebKit): (WebIntentServiceInfo): (WebKit::WebIntentServiceInfo::create): (WebKit::WebIntentServiceInfo::~WebIntentServiceInfo): (WebKit::WebIntentServiceInfo::action): (WebKit::WebIntentServiceInfo::payloadType): (WebKit::WebIntentServiceInfo::href): (WebKit::WebIntentServiceInfo::title): (WebKit::WebIntentServiceInfo::disposition): (WebKit::WebIntentServiceInfo::type): * UIProcess/WebLoaderClient.cpp: (WebKit): (WebKit::WebLoaderClient::registerIntentServiceForFrame): * UIProcess/WebLoaderClient.h: (WebKit): (WebLoaderClient): * UIProcess/WebPageProxy.cpp: (WebKit): (WebKit::WebPageProxy::registerIntentServiceForFrame): * UIProcess/WebPageProxy.h: (WebKit): (WebPageProxy): * UIProcess/WebPageProxy.messages.in: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit): (WebKit::WebFrameLoaderClient::registerIntentService): * WebProcess/WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient): Tools: Update initialization of WKPageLoaderClient. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Modified Paths trunk/Source/WebKit2/CMakeLists.txt trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.list.am trunk/Source/WebKit2/Shared/API/c/WKBase.h trunk/Source/WebKit2/Shared/APIObject.h trunk/Source/WebKit2/Target.pri trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h trunk/Source/WebKit2/UIProcess/API/C/WKPage.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp trunk/Source/WebKit2/UIProcess/WebLoaderClient.cpp trunk/Source/WebKit2/UIProcess/WebLoaderClient.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/mac/BrowserWindowController.m trunk/Tools/WebKitTestRunner/TestController.cpp Added Paths trunk/Source/WebKit2/Shared/IntentServiceInfo.cpp trunk/Source/WebKit2/Shared/IntentServiceInfo.h trunk/Source/WebKit2/UIProcess/WebIntentServiceInfo.cpp trunk/Source/WebKit2/UIProcess/WebIntentServiceInfo.h Diff Modified: trunk/Source/WebKit2/CMakeLists.txt (120300 => 120301) --- trunk/Source/WebKit2/CMakeLists.txt 2012-06-14 09:32:37 UTC (rev 120300) +++ trunk/Source/WebKit2/CMakeLists.txt 2012-06-14 09:43:25 UTC (rev 120301) @@ -123,6 +123,7 @@ Shared/ImmutableArray.cpp Shared/ImmutableDictionary.cpp Shared/IntentData.cpp +Shared/IntentServiceInfo.cpp Shared/MutableArray.cpp Shared/MutableDictionary.cpp Shared/OriginAndDatabases.cpp @@ -238,6 +239,7 @@ UIProcess/WebIconDatabaseClient.cpp UIProcess/WebInspectorProxy.cpp UIProcess/WebIntentData.cpp +UIProcess/WebIntentServiceInfo.cpp UIProcess/WebKeyValueStorageManagerProxy.cpp UIProcess/WebLayerTreeRenderer.cpp UIProcess/WebLoaderClient.cpp Modified: trunk/Source/WebKit2/ChangeLog (120300 => 120301) --- trunk/Source/WebKit2/ChangeLog 2012-06-14 09:32:37 UTC (rev 120300) +++ trunk/Source/WebKit2/ChangeLog 2012-06-14 09:43:25 UTC (rev 120301) @@ -1,3 +1,65 @@ +2012-06-14 Christophe Dumez + +[WK2] Add implementation for registerIntentService in WebFrameLoaderClient +https://bugs.webkit.org/show_bug.cgi?id=88399 + +Reviewed by Kenneth Rohde Christiansen. + +Add implementation for registerIntentService() in +WebFrameLoaderClient. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Shared/API/c/WKBase.h: +* Shared/APIClientTraits.h: +* Shared/APIObject.h: +* Shared/IntentServiceInfo.cpp: Added. +(WebKit): +(WebKit::IntentServiceInfo::encode): +(WebKit::IntentServiceInfo::decode): +* Shared/IntentServiceInfo
[webkit-changes] [120300] trunk
Title: [120300] trunk Revision 120300 Author commit-qu...@webkit.org Date 2012-06-14 02:32:37 -0700 (Thu, 14 Jun 2012) Log Message [Blackberry] add a new Api named setAllowNotification https://bugs.webkit.org/show_bug.cgi?id=88950 Patch by Chris Guan on 2012-06-14 Reviewed by Antonio Gomes. .: Add a new API named setAllowNotification in webpage class to let client set those allowed domains into notifications. Test case: * ManualTests/blackberry/notification.html: Added. Source/WebKit/blackberry: * Api/WebPage.cpp: (BlackBerry::WebKit::WebPage::setAllowNotification): (WebKit): * Api/WebPage.h: Modified Paths trunk/ChangeLog trunk/Source/WebKit/blackberry/Api/WebPage.cpp trunk/Source/WebKit/blackberry/Api/WebPage.h trunk/Source/WebKit/blackberry/ChangeLog Added Paths trunk/ManualTests/blackberry/notification.html Diff Modified: trunk/ChangeLog (120299 => 120300) --- trunk/ChangeLog 2012-06-14 09:31:22 UTC (rev 120299) +++ trunk/ChangeLog 2012-06-14 09:32:37 UTC (rev 120300) @@ -1,3 +1,16 @@ +2012-06-14 Chris Guan + +[Blackberry] add a new Api named setAllowNotification +https://bugs.webkit.org/show_bug.cgi?id=88950 + +Reviewed by Antonio Gomes. + +Add a new API named setAllowNotification in webpage class to +let client set those allowed domains into notifications. + +Test case: +* ManualTests/blackberry/notification.html: Added. + 2012-06-13 Zan Dobersek [Gtk] Enable link prefetch support in the developer builds Added: trunk/ManualTests/blackberry/notification.html (0 => 120300) --- trunk/ManualTests/blackberry/notification.html (rev 0) +++ trunk/ManualTests/blackberry/notification.html 2012-06-14 09:32:37 UTC (rev 120300) @@ -0,0 +1,53 @@ + + + +var n; +function setNotification() +{ +if (window.webkitNotifications.checkPermission() != 0) { +alert("you don't have permission to post notifications, please allow notifications by clicking that link"); +document.getElementById('allowNotificationLink').style.backgroundColor = 'Red'; +return 0; +} +n = window.webkitNotifications.createNotification(window.location.href + '/favicon.ico', 'Notify me', 'This is the notification body'); +log = document.getElementById("place"); +n._onshow_ = function() { log.innerText = "notification showing"; } +n._onclick_ = function() { log.innerText = "notification clicked"; } +n._onerror_ = function() { log.innerText = "notification error"; } +n._onclose_ = function() { log.innerText = "notification closed"; } +n.show(); +log.innerText = "Did you notice the notification ? There are 3 ways the notification will go away:\n 1. It automically goes away in 30 seconds;\n 2. you can click the close button on the notification to close it;\n 3. Click above link 'Click to cancel the notification.\n\n Please verify all work; Whenever the icon is clicked, cancelled, closed, etc. there will be corresponding log is this area, please notice if they show up."; + +setTimeout(timeout, 3); +function timeout() { +n.cancel(); +} +} + +function setAllowNotification() +{ +window.webkitNotifications.requestPermission(permissionGranted); +} + +function permissionGranted() +{ +if (window.webkitNotifications.checkPermission() == 0) +alert("you now have permission to post Notifications"); +else +alert("you don't have permission to post Notifications"); +} + + + + + + + + + + + + + + + Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (120299 => 120300) --- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-06-14 09:31:22 UTC (rev 120299) +++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-06-14 09:32:37 UTC (rev 120300) @@ -6350,6 +6350,16 @@ return ""; } +void WebPage::setAllowNotification(const WebString& domain, bool allow) +{ +#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) +static_cast(NotificationPresenterImpl::instance())->onPermission(domain.utf8(), allow); +#else +UNUSED_PARAM(domain); +UNUSED_PARAM(allow); +#endif +} + void WebPage::setJavaScriptCanAccessClipboard(bool enabled) { d->m_page->settings()->setJavaScriptCanAccessClipboard(enabled); Modified: trunk/Source/WebKit/blackberry/Api/WebPage.h (120299 => 120300) --- trunk/Source/WebKit/blackberry/Api/WebPage.h 2012-06-14 09:31:22 UTC (rev 120299) +++ trunk/Source/WebKit/blackberry/Api/WebPage.h 2012-06-14 09:32:37 UTC (rev 120300) @@ -266,6 +266,8 @@ WebString textHasAttribute(const WebString& query) const; +void setAllowNotification(const WebString& domain, bool allow); + Platform::WebContext webContext(TargetDetectionStrategy) const; typedef intptr_t BackForwardId; Modified: trunk/Source/WebKit/blackberry/ChangeLog (120299 => 120300) --- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-14 09:31:22 UTC (rev 120299) +++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-14
1 2 >
