[webkit-changes] [121321] trunk/Source/WebCore

[yosin]

Title: [121321] trunk/Source/WebCore








Revision 121321
Author yo...@chromium.org
Date 2012-06-26 23:03:35 -0700 (Tue, 26 Jun 2012)


Log Message
[Platform] Change implementation of LocaleICU class to support more UDateFormat.
https://bugs.webkit.org/show_bug.cgi?id=89967

Reviewed by Kent Tamura.

This patch changes internal functions of LocaleICU class to process
multiple ICU date time format handles in addition to short date time
format handle.

This patch is a part of implementing input type time. I'll add time
format related ICU date time format handles.

No new tests. This patch doesn't change behavior.

* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeShortDateFormat): Changed to use openDateFormat().
(WebCore::LocaleICU::openDateFormat): Added for common usage of udt_open().
(WebCore::getDateFormatPattern): Added for common usage of udt_toPattern().
(WebCore::localizeFormat): Changed to take String parameter.
(WebCore::LocaleICU::initializeLocalizedDateFormatText): Changed to use getDateFormatPattern.
(WebCore::LocaleICU::createLabelVector): Changed to take UDateFormat parameter.
(WebCore::LocaleICU::initializeCalendar): Changed for helper functions.
* platform/text/LocaleICU.h:
(LocaleICU):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/LocaleICU.cpp
trunk/Source/WebCore/platform/text/LocaleICU.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (121320 => 121321)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 05:40:18 UTC (rev 121320)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 06:03:35 UTC (rev 121321)
@@ -1,3 +1,30 @@
+2012-06-26  Yoshifumi Inoue  yo...@chromium.org
+
+[Platform] Change implementation of LocaleICU class to support more UDateFormat.
+https://bugs.webkit.org/show_bug.cgi?id=89967
+
+Reviewed by Kent Tamura.
+
+This patch changes internal functions of LocaleICU class to process
+multiple ICU date time format handles in addition to short date time
+format handle.
+
+This patch is a part of implementing input type time. I'll add time
+format related ICU date time format handles.
+
+No new tests. This patch doesn't change behavior.
+
+* platform/text/LocaleICU.cpp:
+(WebCore::LocaleICU::initializeShortDateFormat): Changed to use openDateFormat().
+(WebCore::LocaleICU::openDateFormat): Added for common usage of udt_open().
+(WebCore::getDateFormatPattern): Added for common usage of udt_toPattern().
+(WebCore::localizeFormat): Changed to take String parameter.
+(WebCore::LocaleICU::initializeLocalizedDateFormatText): Changed to use getDateFormatPattern.
+(WebCore::LocaleICU::createLabelVector): Changed to take UDateFormat parameter.
+(WebCore::LocaleICU::initializeCalendar): Changed for helper functions.
+* platform/text/LocaleICU.h:
+(LocaleICU):
+
 2012-06-26  Luke Macpherson  macpher...@chromium.org
 
 Return correct value for css variables enabled runtime flag.


Modified: trunk/Source/WebCore/platform/text/LocaleICU.cpp (121320 => 121321)

--- trunk/Source/WebCore/platform/text/LocaleICU.cpp	2012-06-27 05:40:18 UTC (rev 121320)
+++ trunk/Source/WebCore/platform/text/LocaleICU.cpp	2012-06-27 06:03:35 UTC (rev 121321)
@@ -272,13 +272,18 @@
 {
 if (m_didCreateShortDateFormat)
 return m_shortDateFormat;
-const UChar gmtTimezone[3] = {'G', 'M', 'T'};
-UErrorCode status = U_ZERO_ERROR;
-m_shortDateFormat = udat_open(UDAT_NONE, UDAT_SHORT, m_locale.data(), gmtTimezone, WTF_ARRAY_LENGTH(gmtTimezone), 0, -1, status);
+m_shortDateFormat = openDateFormat(UDAT_NONE, UDAT_SHORT);
 m_didCreateShortDateFormat = true;
 return m_shortDateFormat;
 }
 
+UDateFormat* LocaleICU::openDateFormat(UDateFormatStyle timeStyle, UDateFormatStyle dateStyle) const
+{
+const UChar gmtTimezone[3] = {'G', 'M', 'T'};
+UErrorCode status = U_ZERO_ERROR;
+return udat_open(timeStyle, dateStyle, m_locale.data(), gmtTimezone, WTF_ARRAY_LENGTH(gmtTimezone), 0, -1, status);
+}
+
 double LocaleICU::parseLocalizedDate(const String input)
 {
 if (!initializeShortDateFormat())
@@ -313,6 +318,23 @@
 }
 
 #if ENABLE(CALENDAR_PICKER)
+static String getDateFormatPattern(const UDateFormat* dateFormat)
+{
+if (!dateFormat)
+return emptyString();
+
+UErrorCode status = U_ZERO_ERROR;
+int32_t length = udat_toPattern(dateFormat, TRUE, 0, 0, status);
+if (status != U_BUFFER_OVERFLOW_ERROR || !length)
+return emptyString();
+VectorUChar buffer(length);
+status = U_ZERO_ERROR;
+udat_toPattern(dateFormat, TRUE, buffer.data(), length, status);
+if (U_FAILURE(status))
+return emptyString();
+return String::adopt(buffer);
+}
+
 static inline bool isICUYearSymbol(UChar letter)
 {
 return letter == 'y' || letter == 'Y';
@@ -330,12 +352,12 @@
 
 // Specification of the input:
 // 

[webkit-changes] [121322] trunk/Source/WebKit/chromium

[commit-queue]

Title: [121322] trunk/Source/WebKit/chromium








Revision 121322
Author commit-qu...@webkit.org
Date 2012-06-26 23:37:55 -0700 (Tue, 26 Jun 2012)


Log Message
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot webkit.review@gmail.com on 2012-06-26

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (121321 => 121322)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-06-27 06:03:35 UTC (rev 121321)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-06-27 06:37:55 UTC (rev 121322)
@@ -1,3 +1,9 @@
+2012-06-26  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed.  Rolled DEPS.
+
+* DEPS:
+
 2012-06-26  James Robinson  jam...@chromium.org
 
 [chromium] Remove WebView::graphicsContext3D getter


Modified: trunk/Source/WebKit/chromium/DEPS (121321 => 121322)

--- trunk/Source/WebKit/chromium/DEPS	2012-06-27 06:03:35 UTC (rev 121321)
+++ trunk/Source/WebKit/chromium/DEPS	2012-06-27 06:37:55 UTC (rev 121322)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '144049'
+  'chromium_rev': '144160'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121323] trunk/Source/WebKit2

[hausmann]

Title: [121323] trunk/Source/WebKit2








Revision 121323
Author hausm...@webkit.org
Date 2012-06-27 00:09:30 -0700 (Wed, 27 Jun 2012)


Log Message
[Qt] Avoid use of deprecated Qt API

Reviewed by Tor Arne Vestbø.

QGuiApplication::inputPanel() has been deprecated in favour of
inputMethod().

* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::~QtWebPageEventHandler):
(WebKit::setInputPanelVisible):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::updateTextInputState):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (121322 => 121323)

--- trunk/Source/WebKit2/ChangeLog	2012-06-27 06:37:55 UTC (rev 121322)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-27 07:09:30 UTC (rev 121323)
@@ -1,3 +1,19 @@
+2012-06-26  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt] Avoid use of deprecated Qt API
+
+Reviewed by Tor Arne Vestbø.
+
+QGuiApplication::inputPanel() has been deprecated in favour of
+inputMethod().
+
+* UIProcess/qt/QtWebPageEventHandler.cpp:
+(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
+(WebKit::QtWebPageEventHandler::~QtWebPageEventHandler):
+(WebKit::setInputPanelVisible):
+(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
+(WebKit::QtWebPageEventHandler::updateTextInputState):
+
 2012-06-26  Christophe Dumez  christophe.du...@intel.com
 
 [WK2][GTK] Uninitialized variable in TextCheckerGtk.cpp


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp (121322 => 121323)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp	2012-06-27 06:37:55 UTC (rev 121322)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp	2012-06-27 07:09:30 UTC (rev 121323)
@@ -31,7 +31,7 @@
 #include QCursor
 #include QDrag
 #include QGuiApplication
-#include QInputPanel
+#include QInputMethod
 #include QMimeData
 #include QtQuick/QQuickCanvas
 #include QStyleHints
@@ -100,12 +100,12 @@
 , m_postponeTextInputStateChanged(false)
 , m_isTapHighlightActive(false)
 {
-connect(qApp-inputPanel(), SIGNAL(visibleChanged()), this, SLOT(inputPanelVisibleChanged()));
+connect(qApp-inputMethod(), SIGNAL(visibleChanged()), this, SLOT(inputPanelVisibleChanged()));
 }
 
 QtWebPageEventHandler::~QtWebPageEventHandler()
 {
-disconnect(qApp-inputPanel(), SIGNAL(visibleChanged()), this, SLOT(inputPanelVisibleChanged()));
+disconnect(qApp-inputMethod(), SIGNAL(visibleChanged()), this, SLOT(inputPanelVisibleChanged()));
 }
 
 void QtWebPageEventHandler::handleMouseMoveEvent(QMouseEvent* ev)
@@ -390,10 +390,10 @@
 
 static void setInputPanelVisible(bool visible)
 {
-if (qApp-inputPanel()-visible() == visible)
+if (qApp-inputMethod()-visible() == visible)
 return;
 
-qApp-inputPanel()-setVisible(visible);
+qApp-inputMethod()-setVisible(visible);
 }
 
 void QtWebPageEventHandler::inputPanelVisibleChanged()
@@ -402,7 +402,7 @@
 return;
 
 // We only respond to the input panel becoming visible.
-if (!m_webView-hasActiveFocus() || !qApp-inputPanel()-visible())
+if (!m_webView-hasActiveFocus() || !qApp-inputMethod()-visible())
 return;
 
 const EditorState editor = m_webPageProxy-editorState();
@@ -422,7 +422,7 @@
 if (!m_webView-hasActiveFocus())
 return;
 
-qApp-inputPanel()-update(Qt::ImQueryInput | Qt::ImEnabled);
+qApp-inputMethod()-update(Qt::ImQueryInput | Qt::ImEnabled);
 
 setInputPanelVisible(editor.isContentEditable);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121325] trunk/LayoutTests

[zandobersek]

Title: [121325] trunk/LayoutTests








Revision 121325
Author zandober...@gmail.com
Date 2012-06-27 00:26:35 -0700 (Wed, 27 Jun 2012)


Log Message
Unreviewed GTK gardening, updating baselines after r121303.

* platform/gtk/editing/deleting/delete-br-002-expected.txt:
* platform/gtk/editing/deleting/delete-br-004-expected.txt:
* platform/gtk/editing/deleting/delete-br-005-expected.txt:
* platform/gtk/editing/deleting/delete-br-006-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-002-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-004-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-005-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-006-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (121324 => 121325)

--- trunk/LayoutTests/ChangeLog	2012-06-27 07:26:34 UTC (rev 121324)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 07:26:35 UTC (rev 121325)
@@ -1,3 +1,12 @@
+2012-06-27  Zan Dobersek  zandober...@gmail.com
+
+Unreviewed GTK gardening, updating baselines after r121303.
+
+* platform/gtk/editing/deleting/delete-br-002-expected.txt:
+* platform/gtk/editing/deleting/delete-br-004-expected.txt:
+* platform/gtk/editing/deleting/delete-br-005-expected.txt:
+* platform/gtk/editing/deleting/delete-br-006-expected.txt:
+
 2012-06-26  Xueqing Huang  huangxueq...@baidu.com
 
 DragData::asFilenames should not push same file names to result in Windows.


Modified: trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-002-expected.txt (121324 => 121325)

--- trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-002-expected.txt	2012-06-27 07:26:34 UTC (rev 121324)
+++ trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-002-expected.txt	2012-06-27 07:26:35 UTC (rev 121325)
@@ -24,6 +24,7 @@
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 2 of SPAN  DIV  BODY  HTML  #document to 3 of SPAN  DIV  BODY  HTML  #document
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of SPAN  DIV  BODY  HTML  #document to 3 of SPAN  DIV  BODY  HTML  #document toDOMRange:range from 2 of SPAN  DIV  BODY  HTML  #document to 2 of SPAN  DIV  BODY  HTML  #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
 layer at (0,0) size 800x600


Modified: trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-004-expected.txt (121324 => 121325)

--- trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-004-expected.txt	2012-06-27 07:26:34 UTC (rev 121324)
+++ trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-004-expected.txt	2012-06-27 07:26:35 UTC (rev 121325)
@@ -25,6 +25,7 @@
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 3 of SPAN  DIV  BODY  HTML  #document to 4 of SPAN  DIV  BODY  HTML  #document
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 9 of #text  SPAN  DIV  BODY  HTML  #document to 9 of #text  SPAN  DIV  BODY  HTML  #document toDOMRange:range from 3 of SPAN  DIV  BODY  HTML  #document to 3 of SPAN  DIV  BODY  HTML  #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
 layer at (0,0) size 800x600
@@ -42,5 +43,4 @@
   RenderBR {BR} at (14,42) size 0x28
   RenderText {#text} at (14,70) size 92x28
 text run at (14,70) width 92: years ago
-RenderText {#text} at (0,0) size 0x0
 caret: position 0 of child 3 {#text} of child 1 {SPAN} of child 1 {DIV} of body


Modified: trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-005-expected.txt (121324 => 121325)

--- trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-005-expected.txt	2012-06-27 07:26:34 UTC (rev 121324)
+++ trunk/LayoutTests/platform/gtk/editing/deleting/delete-br-005-expected.txt	2012-06-27 07:26:35 UTC (rev 121325)
@@ -25,9 +25,11 @@
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 3 of SPAN  DIV  BODY  HTML  #document to 4 of SPAN  DIV  BODY  HTML  #document
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 9 of #text  SPAN  DIV  BODY  HTML  #document to 9 of #text  SPAN  DIV  BODY  HTML  #document toDOMRange:range from 3 of SPAN  DIV  BODY  HTML  #document to 3 

[webkit-changes] [121324] trunk/Source/WebKit/qt

[hausmann]

Title: [121324] trunk/Source/WebKit/qt








Revision 121324
Author hausm...@webkit.org
Date 2012-06-27 00:26:34 -0700 (Wed, 27 Jun 2012)


Log Message
[Qt] Fix compilation of example platform plugin with Qt 5

Reviewed by Kenneth Christiansen.

Use QLatin1String where appropriate and use the Qt 5 plugin
system with Qt 5.

* examples/platformplugin/WebPlugin.cpp:
(SingleSelectionPopup::SingleSelectionPopup):
(MultipleItemListDelegate::MultipleItemListDelegate):
(MultipleSelectionPopup::MultipleSelectionPopup):
* examples/platformplugin/WebPlugin.h:
(WebPlugin):

Modified Paths

trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/examples/platformplugin/WebPlugin.cpp
trunk/Source/WebKit/qt/examples/platformplugin/WebPlugin.h




Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (121323 => 121324)

--- trunk/Source/WebKit/qt/ChangeLog	2012-06-27 07:09:30 UTC (rev 121323)
+++ trunk/Source/WebKit/qt/ChangeLog	2012-06-27 07:26:34 UTC (rev 121324)
@@ -1,3 +1,19 @@
+2012-06-27  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt] Fix compilation of example platform plugin with Qt 5
+
+Reviewed by Kenneth Christiansen.
+
+Use QLatin1String where appropriate and use the Qt 5 plugin
+system with Qt 5.
+
+* examples/platformplugin/WebPlugin.cpp:
+(SingleSelectionPopup::SingleSelectionPopup):
+(MultipleItemListDelegate::MultipleItemListDelegate):
+(MultipleSelectionPopup::MultipleSelectionPopup):
+* examples/platformplugin/WebPlugin.h:
+(WebPlugin):
+
 2012-06-26  Tony Chang  t...@chromium.org
 
 [Qt] Enable grid layout LayoutTests


Modified: trunk/Source/WebKit/qt/examples/platformplugin/WebPlugin.cpp (121323 => 121324)

--- trunk/Source/WebKit/qt/examples/platformplugin/WebPlugin.cpp	2012-06-27 07:09:30 UTC (rev 121323)
+++ trunk/Source/WebKit/qt/examples/platformplugin/WebPlugin.cpp	2012-06-27 07:26:34 UTC (rev 121324)
@@ -126,7 +126,7 @@
 if (qstrcmp(title, weba_ti_texlist_single))
 setWindowTitle(QString::fromUtf8(title));
 else
-setWindowTitle(Select item);
+setWindowTitle(QLatin1String(Select item));
 
 QHBoxLayout* hLayout = new QHBoxLayout(this);
 hLayout-setContentsMargins(0, 0, 0, 0);
@@ -150,7 +150,7 @@
 MultipleItemListDelegate(QObject* parent = 0)
: QStyledItemDelegate(parent)
 {
-tickMark = QIcon::fromTheme(widgets_tickmark_list).pixmap(48, 48);
+tickMark = QIcon::fromTheme(QLatin1String(widgets_tickmark_list)).pixmap(48, 48);
 }
 
 void paint(QPainter* painter, const QStyleOptionViewItem option, const QModelIndex index) const
@@ -172,7 +172,7 @@
 if (qstrcmp(title, weba_ti_textlist_multi))
 setWindowTitle(QString::fromUtf8(title));
 else
-setWindowTitle(Select items);
+setWindowTitle(QLatin1String(Select items));
 
 QHBoxLayout* hLayout = new QHBoxLayout(this);
 hLayout-setContentsMargins(0, 0, 0, 0);
@@ -197,7 +197,7 @@
 if (qstrcmp(title, wdgt_bd_done))
 done-setText(QString::fromUtf8(title));
 else
-done-setText(Done);
+done-setText(QLatin1String(Done));
 
 done-setMinimumWidth(178);
 vLayout-addWidget(done);
@@ -315,4 +315,6 @@
 }
 }
 
+#if QT_VERSION  QT_VERSION_CHECK(5, 0, 0)
 Q_EXPORT_PLUGIN2(platformplugin, WebPlugin)
+#endif


Modified: trunk/Source/WebKit/qt/examples/platformplugin/WebPlugin.h (121323 => 121324)

--- trunk/Source/WebKit/qt/examples/platformplugin/WebPlugin.h	2012-06-27 07:09:30 UTC (rev 121323)
+++ trunk/Source/WebKit/qt/examples/platformplugin/WebPlugin.h	2012-06-27 07:26:34 UTC (rev 121324)
@@ -137,6 +137,9 @@
 {
 Q_OBJECT
 Q_INTERFACES(QWebKitPlatformPlugin)
+#if QT_VERSION = 0x05
+Q_PLUGIN_METADATA(IID org.qt-project.QtWebKit.PlatformPluginInterface)
+#endif
 public:
 virtual bool supportsExtension(Extension extension) const;
 virtual QObject* createExtension(Extension extension) const;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121326] trunk/Source/WebCore

[haraken]

Title: [121326] trunk/Source/WebCore








Revision 121326
Author hara...@chromium.org
Date 2012-06-27 00:28:31 -0700 (Wed, 27 Jun 2012)


Log Message
[V8] Refactor V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get()
https://bugs.webkit.org/show_bug.cgi?id=90044

Reviewed by Adam Barth.

'static_castV8BindingPerIsolateData*(isolate-GetData())' is duplicated
in V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get().
This patch removes the duplication.

No tests. No change in behavior.

* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::current):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Binding.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (121325 => 121326)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 07:26:35 UTC (rev 121325)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 07:28:31 UTC (rev 121326)
@@ -1,3 +1,19 @@
+2012-06-27  Kentaro Hara  hara...@chromium.org
+
+[V8] Refactor V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get()
+https://bugs.webkit.org/show_bug.cgi?id=90044
+
+Reviewed by Adam Barth.
+
+'static_castV8BindingPerIsolateData*(isolate-GetData())' is duplicated
+in V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get().
+This patch removes the duplication.
+
+No tests. No change in behavior.
+
+* bindings/v8/V8Binding.h:
+(WebCore::V8BindingPerIsolateData::current):
+
 2012-06-26  Yoshifumi Inoue  yo...@chromium.org
 
 [Platform] Change implementation of LocaleICU class to support more UDateFormat.


Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (121325 => 121326)

--- trunk/Source/WebCore/bindings/v8/V8Binding.h	2012-06-27 07:26:35 UTC (rev 121325)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h	2012-06-27 07:28:31 UTC (rev 121326)
@@ -120,16 +120,13 @@
 public:
 static V8BindingPerIsolateData* create(v8::Isolate*);
 static void ensureInitialized(v8::Isolate*);
-static V8BindingPerIsolateData* get(v8::Isolate* isolate)
+static V8BindingPerIsolateData* current(v8::Isolate* isolate = 0)
 {
+if (UNLIKELY(!isolate))
+isolate = v8::Isolate::GetCurrent();
 ASSERT(isolate-GetData());
 return static_castV8BindingPerIsolateData*(isolate-GetData()); 
 }
-
-static V8BindingPerIsolateData* current(v8::Isolate* isolate = 0)
-{
-return isolate ? static_castV8BindingPerIsolateData*(isolate-GetData()) : get(v8::Isolate::GetCurrent());
-}
 static void dispose(v8::Isolate*);
 
 typedef HashMapWrapperTypeInfo*, v8::Persistentv8::FunctionTemplate  TemplateMap;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121327] trunk/Source/WebCore

[haraken]

Title: [121327] trunk/Source/WebCore








Revision 121327
Author hara...@chromium.org
Date 2012-06-27 00:48:24 -0700 (Wed, 27 Jun 2012)


Log Message
LabelableElement.cpp should include not ElementRareData.h but NodeRareData.h
https://bugs.webkit.org/show_bug.cgi?id=90047

Reviewed by Kent Tamura.

This is a simple refactoring. What LabelableElement uses is
not ElementRareData but NodeRareData.

No tests. No change in behavior.

* html/LabelableElement.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/LabelableElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121326 => 121327)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 07:28:31 UTC (rev 121326)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 07:48:24 UTC (rev 121327)
@@ -1,5 +1,19 @@
 2012-06-27  Kentaro Hara  hara...@chromium.org
 
+LabelableElement.cpp should include not ElementRareData.h but NodeRareData.h
+https://bugs.webkit.org/show_bug.cgi?id=90047
+
+Reviewed by Kent Tamura.
+
+This is a simple refactoring. What LabelableElement uses is
+not ElementRareData but NodeRareData.
+
+No tests. No change in behavior.
+
+* html/LabelableElement.cpp:
+
+2012-06-27  Kentaro Hara  hara...@chromium.org
+
 [V8] Refactor V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get()
 https://bugs.webkit.org/show_bug.cgi?id=90044
 


Modified: trunk/Source/WebCore/html/LabelableElement.cpp (121326 => 121327)

--- trunk/Source/WebCore/html/LabelableElement.cpp	2012-06-27 07:28:31 UTC (rev 121326)
+++ trunk/Source/WebCore/html/LabelableElement.cpp	2012-06-27 07:48:24 UTC (rev 121327)
@@ -25,8 +25,8 @@
 #include config.h
 #include LabelableElement.h
 
-#include ElementRareData.h
 #include LabelsNodeList.h
+#include NodeRareData.h
 #include RenderStyle.h
 
 namespace WebCore {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121328] trunk/Tools

[ossy]

Title: [121328] trunk/Tools








Revision 121328
Author o...@webkit.org
Date 2012-06-27 01:27:02 -0700 (Wed, 27 Jun 2012)


Log Message
Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
https://bugs.webkit.org/show_bug.cgi?id=89564

Reviewed by Tony Chang.

* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(BuildStepsConstructorTest):
(BuildStepsConstructorTest.generateTests):
(BuildStepsConstructorTest.createTest):
(BuildStepsConstructorTest.createTest.doTest):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py (121327 => 121328)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py	2012-06-27 07:48:24 UTC (rev 121327)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py	2012-06-27 08:27:02 UTC (rev 121328)
@@ -328,7 +328,30 @@
 )
 
 
+class BuildStepsConstructorTest(unittest.TestCase):
+# Passing a BuildStep subclass to factory.addStep is deprecated. Please pass a BuildStep instance instead.  Support will be dropped in v0.8.7.
+# It checks if all builder's all buildsteps can be insantiated after migration.
+# https://bugs.webkit.org/show_bug.cgi?id=89001
+# http://buildbot.net/buildbot/docs/0.8.6p1/manual/customization.html#writing-buildstep-constructors
 
+@staticmethod
+def generateTests():
+for builderNumber, builder in enumerate(c['builders']):
+for stepNumber, step in enumerate(builder['factory'].steps):
+builderName = builder['name'].encode('ascii', 'ignore')
+setattr(BuildStepsConstructorTest, 'test_builder%02d_step%02d' % (builderNumber, stepNumber), BuildStepsConstructorTest.createTest(builderName, step))
+
+@staticmethod
+def createTest(builderName, step):
+def doTest(self):
+try:
+buildStepFactory, kwargs = step
+buildStepFactory(**kwargs)
+except TypeError as e:
+buildStepName = str(buildStepFactory).split('.')[-1]
+self.fail(Error during instantiation %s buildstep for %s builder: %s\n % (buildStepName, builderName, e))
+return doTest
+
 # FIXME: We should run this file as part of test-webkitpy.
 # Unfortunately test-webkitpy currently requires that unittests
 # be located in a directory with a valid module name.
@@ -336,4 +359,5 @@
 # so for now this is a stand-alone test harness.
 if __name__ == '__main__':
 BuildBotConfigLoader().load_config('master.cfg')
+BuildStepsConstructorTest.generateTests()
 unittest.main()


Modified: trunk/Tools/ChangeLog (121327 => 121328)

--- trunk/Tools/ChangeLog	2012-06-27 07:48:24 UTC (rev 121327)
+++ trunk/Tools/ChangeLog	2012-06-27 08:27:02 UTC (rev 121328)
@@ -1,3 +1,16 @@
+2012-06-27  Csaba Osztrogonác  o...@webkit.org
+
+Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
+https://bugs.webkit.org/show_bug.cgi?id=89564
+
+Reviewed by Tony Chang.
+
+* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
+(BuildStepsConstructorTest):
+(BuildStepsConstructorTest.generateTests):
+(BuildStepsConstructorTest.createTest):
+(BuildStepsConstructorTest.createTest.doTest):
+
 2012-06-26  Mark Hahnenberg  mhahnenb...@apple.com
 
 Add support for preciseTime() to WebKitTestRunner






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121330] trunk/Source/WebCore

[haraken]

Title: [121330] trunk/Source/WebCore








Revision 121330
Author hara...@chromium.org
Date 2012-06-27 01:54:43 -0700 (Wed, 27 Jun 2012)


Log Message
Rename rareSVGData() to svgRareData()
https://bugs.webkit.org/show_bug.cgi?id=90051

Reviewed by Nikolas Zimmermann.

Since rareSVGData() returns SVGRareData, it would make sense to
rename rareSVGData() to svgRareData(). Similarly, we can rename
ensureRareSVGData() to ensureSVGRareData(), and hasRareSVGData()
to hasSVGRareData().

c.f. bug 90050 is trying to introduce elementRareData() and
ensureElementRareData().

No tests. No change in behavior.

* WebCore.order:
* dom/Node.h:
(WebCore::Node::hasSVGRareData):
(WebCore::Node::setHasSVGRareData):
(WebCore::Node::clearHasSVGRareData):
* svg/SVGElement.cpp:
(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::willRecalcStyle):
(WebCore::SVGElement::svgRareData):
(WebCore::SVGElement::ensureSVGRareData):
(WebCore::SVGElement::mapInstanceToElement):
(WebCore::SVGElement::removeInstanceMapping):
(WebCore::SVGElement::instancesForElement):
(WebCore::SVGElement::setCursorElement):
(WebCore::SVGElement::cursorElementRemoved):
(WebCore::SVGElement::setCursorImageValue):
(WebCore::SVGElement::cursorImageValueRemoved):
(WebCore::SVGElement::correspondingElement):
(WebCore::SVGElement::setCorrespondingElement):
(WebCore::SVGElement::animatedSMILStyleProperties):
(WebCore::SVGElement::ensureAnimatedSMILStyleProperties):
(WebCore::SVGElement::setUseOverrideComputedStyle):
(WebCore::SVGElement::computedStyle):
* svg/SVGElement.h:
(SVGElement):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::instanceUpdatesBlocked):
(WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
(WebCore::SVGStyledElement::hasPendingResources):
(WebCore::SVGStyledElement::setHasPendingResources):
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.order
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/svg/SVGElement.cpp
trunk/Source/WebCore/svg/SVGElement.h
trunk/Source/WebCore/svg/SVGStyledElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121329 => 121330)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 08:30:09 UTC (rev 121329)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 08:54:43 UTC (rev 121330)
@@ -1,5 +1,54 @@
 2012-06-27  Kentaro Hara  hara...@chromium.org
 
+Rename rareSVGData() to svgRareData()
+https://bugs.webkit.org/show_bug.cgi?id=90051
+
+Reviewed by Nikolas Zimmermann.
+
+Since rareSVGData() returns SVGRareData, it would make sense to
+rename rareSVGData() to svgRareData(). Similarly, we can rename
+ensureRareSVGData() to ensureSVGRareData(), and hasRareSVGData()
+to hasSVGRareData().
+
+c.f. bug 90050 is trying to introduce elementRareData() and
+ensureElementRareData().
+
+No tests. No change in behavior.
+
+* WebCore.order:
+* dom/Node.h:
+(WebCore::Node::hasSVGRareData):
+(WebCore::Node::setHasSVGRareData):
+(WebCore::Node::clearHasSVGRareData):
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::~SVGElement):
+(WebCore::SVGElement::willRecalcStyle):
+(WebCore::SVGElement::svgRareData):
+(WebCore::SVGElement::ensureSVGRareData):
+(WebCore::SVGElement::mapInstanceToElement):
+(WebCore::SVGElement::removeInstanceMapping):
+(WebCore::SVGElement::instancesForElement):
+(WebCore::SVGElement::setCursorElement):
+(WebCore::SVGElement::cursorElementRemoved):
+(WebCore::SVGElement::setCursorImageValue):
+(WebCore::SVGElement::cursorImageValueRemoved):
+(WebCore::SVGElement::correspondingElement):
+(WebCore::SVGElement::setCorrespondingElement):
+(WebCore::SVGElement::animatedSMILStyleProperties):
+(WebCore::SVGElement::ensureAnimatedSMILStyleProperties):
+(WebCore::SVGElement::setUseOverrideComputedStyle):
+(WebCore::SVGElement::computedStyle):
+* svg/SVGElement.h:
+(SVGElement):
+* svg/SVGStyledElement.cpp:
+(WebCore::SVGStyledElement::instanceUpdatesBlocked):
+(WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
+(WebCore::SVGStyledElement::hasPendingResources):
+(WebCore::SVGStyledElement::setHasPendingResources):
+(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible):
+
+2012-06-27  Kentaro Hara  hara...@chromium.org
+
 LabelableElement.cpp should include not ElementRareData.h but NodeRareData.h
 https://bugs.webkit.org/show_bug.cgi?id=90047
 


Modified: trunk/Source/WebCore/WebCore.order (121329 => 121330)

--- trunk/Source/WebCore/WebCore.order	2012-06-27 08:30:09 UTC (rev 121329)
+++ trunk/Source/WebCore/WebCore.order	2012-06-27 08:54:43 UTC (rev 121330)
@@ -28887,7 +28887,7 @@
 __ZN7WebCore14SVGRenderStyle20setMarkerEndResourceERKN3WTF6StringE
 

[webkit-changes] [121331] trunk

[rniwa]

Title: [121331] trunk








Revision 121331
Author rn...@webkit.org
Date 2012-06-27 02:15:18 -0700 (Wed, 27 Jun 2012)


Log Message
Fix gcc build after r121302
https://bugs.webkit.org/show_bug.cgi?id=90055

Reviewed by Mark Rowe.

Source/ThirdParty: 

Assume RTTI is disabled so that gtest builds under XCode 3.2.6.

* gtest/xcode/Config/General.xcconfig:

Tools: 

Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.

It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.

* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
(TestWebKitAPI::AcceptsFirstMouse::runTest):

Modified Paths

trunk/Source/ThirdParty/ChangeLog
trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig
trunk/Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm




Diff

Modified: trunk/Source/ThirdParty/ChangeLog (121330 => 121331)

--- trunk/Source/ThirdParty/ChangeLog	2012-06-27 08:54:43 UTC (rev 121330)
+++ trunk/Source/ThirdParty/ChangeLog	2012-06-27 09:15:18 UTC (rev 121331)
@@ -1,3 +1,14 @@
+2012-06-27  Ryosuke Niwa  rn...@webkit.org
+
+Fix gcc build after r121302
+https://bugs.webkit.org/show_bug.cgi?id=90055
+
+Reviewed by Mark Rowe.
+
+Assume RTTI is disabled so that gtest builds under XCode 3.2.6.
+
+* gtest/xcode/Config/General.xcconfig:
+
 2012-04-30  Carlos Garcia Campos  cgar...@igalia.com
 
 Unreviewed. Fix make distcheck.


Modified: trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig (121330 => 121331)

--- trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig	2012-06-27 08:54:43 UTC (rev 121330)
+++ trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig	2012-06-27 09:15:18 UTC (rev 121331)
@@ -36,7 +36,7 @@
 // Turn on position dependent code for most cases (overridden where appropriate)
 GCC_DYNAMIC_NO_PIC = YES
 
-GCC_PREPROCESSOR_DEFINITIONS = $(GCC_PREPROCESSOR_DEFINITIONS) GTEST_HAS_TR1_TUPLE=0;
+GCC_PREPROCESSOR_DEFINITIONS = $(GCC_PREPROCESSOR_DEFINITIONS) GTEST_HAS_TR1_TUPLE=0 GTEST_HAS_RTTI=0;
 
 CLANG_CXX_LIBRARY = $(CLANG_CXX_LIBRARY_$(TARGET_MAC_OS_X_VERSION_MAJOR));
 CLANG_CXX_LIBRARY_1060 = libstdc++;
@@ -71,6 +71,5 @@
 SDKROOT_1090_1070 = macosx10.7;
 SDKROOT_1090_1080 = macosx10.8;
 
-
 // VERSIONING BUILD SETTINGS (used in Info.plist)
 GTEST_VERSIONINFO_ABOUT =  © 2008 Google Inc.


Modified: trunk/Tools/ChangeLog (121330 => 121331)

--- trunk/Tools/ChangeLog	2012-06-27 08:54:43 UTC (rev 121330)
+++ trunk/Tools/ChangeLog	2012-06-27 09:15:18 UTC (rev 121331)
@@ -1,3 +1,18 @@
+2012-06-27  Ryosuke Niwa  rn...@webkit.org
+
+Fix gcc build after r121302
+https://bugs.webkit.org/show_bug.cgi?id=90055
+
+Reviewed by Mark Rowe.
+
+Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.
+
+It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.
+
+* TestWebKitAPI/Configurations/Base.xcconfig:
+* TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
+(TestWebKitAPI::AcceptsFirstMouse::runTest):
+
 2012-06-27  Csaba Osztrogonác  o...@webkit.org
 
 Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses


Modified: trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig (121330 => 121331)

--- trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig	2012-06-27 08:54:43 UTC (rev 121330)
+++ trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig	2012-06-27 09:15:18 UTC (rev 121331)
@@ -26,7 +26,7 @@
 CLANG_WARN_CXX0X_EXTENSIONS = NO;
 HEADER_SEARCH_PATHS = ${BUILT_PRODUCTS_DIR}/usr/local/include $(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders $(WEBCORE_PRIVATE_HEADERS_DIR)/icu;
 FRAMEWORK_SEARCH_PATHS = $(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks $(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks $(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks;
-GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) ENABLE_DASHBOARD_SUPPORT WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST GTEST_HAS_TR1_TUPLE=0;
+GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) ENABLE_DASHBOARD_SUPPORT WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST GTEST_HAS_TR1_TUPLE=0 GTEST_HAS_RTTI=0;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
 PREBINDING = NO
 GCC_C_LANGUAGE_STANDARD = gnu99


Modified: trunk/Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm (121330 => 121331)

--- trunk/Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm	2012-06-27 08:54:43 UTC (rev 121330)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm	2012-06-27 09:15:18 UTC (rev 121331)
@@ -48,16 +48,16 @@
 void AcceptsFirstMouse::runTest(View view)
 {
 RetainPtrNSWindow window(AdoptNS, [[NSWindow alloc] initWithContentRect:view.frame styleMask:NSBorderlessWindowMask 

[webkit-changes] [121332] trunk

[zandobersek]

Title: [121332] trunk








Revision 121332
Author zandober...@gmail.com
Date 2012-06-27 02:19:15 -0700 (Wed, 27 Jun 2012)


Log Message
[Gtk] Add support for the Gamepad API
https://bugs.webkit.org/show_bug.cgi?id=87503

Reviewed by Carlos Garcia Campos.

.: 

Only enable the Gamepad feature on Linux as support
for other operating systems is not present.

Check for the GIO Unix and GUdev dependencies when the
Gamepad feature is enabled.

* configure.ac:

Source/WebCore: 

Add support for the Gamepad feature on the GTK port.

The support is available only on Linux, with each gamepad device being presented
through a GamepadDeviceLinux object. The implementation of this class relies on
the Linux kernel joystick API.

Gamepad devices are recognized through the GamepadsGtk class, of which implementation
is based on GUdev. This way devices are properly registered on connection as objects of
the GamepadDeviceGtk class which inherits GamepadDeviceLinux. GamepadDeviceGtk reads the
joystick data through GIO pollable streams and updates the device state accordingly. The
GamepadsGtk object is then polled for gamepads data through the sampleGamepads method.

No new tests - tests already exist but require additional testing infrastructure.

* GNUmakefile.am:
* GNUmakefile.list.am:
* bindings/gobject/GNUmakefile.am:
* bindings/js/JSDOMBinding.h: Add the jsArray method that operates on a Vector of floats.
(WebCore):
(WebCore::jsArray):
* platform/gtk/GamepadsGtk.cpp: Added.
(WebCore):
(GamepadDeviceGtk):
(WebCore::GamepadDeviceGtk::create):
(WebCore::GamepadDeviceGtk::GamepadDeviceGtk):
(WebCore::GamepadDeviceGtk::~GamepadDeviceGtk):
(WebCore::GamepadDeviceGtk::readCallback):
(GamepadsGtk):
(WebCore::GamepadsGtk::GamepadsGtk):
(WebCore::GamepadsGtk::~GamepadsGtk):
(WebCore::GamepadsGtk::registerDevice):
(WebCore::GamepadsGtk::unregisterDevice):
(WebCore::GamepadsGtk::updateGamepadList):
(WebCore::GamepadsGtk::onUEventCallback):
(WebCore::GamepadsGtk::isGamepadDevice):
(WebCore::sampleGamepads):
* platform/linux/GamepadDeviceLinux.cpp: Added.
(WebCore):
(WebCore::GamepadDeviceLinux::GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::~GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::updateForEvent):
(WebCore::GamepadDeviceLinux::normalizeAxisValue):
(WebCore::GamepadDeviceLinux::normalizeButtonValue):
* platform/linux/GamepadDeviceLinux.h: Added.
(WebCore):
(GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::connected):
(WebCore::GamepadDeviceLinux::id):
(WebCore::GamepadDeviceLinux::timestamp):
(WebCore::GamepadDeviceLinux::axesCount):
(WebCore::GamepadDeviceLinux::axesData):
(WebCore::GamepadDeviceLinux::buttonsCount):
(WebCore::GamepadDeviceLinux::buttonsData):

Source/WebKit/gtk: 

Add the Gamepad feature dependencies libraries to the LIBADD
list for the libwebkitgtk library.

* GNUmakefile.am:

Source/WebKit2: 

Add the Gamepad feature dependencies libraries to the LIBADD
list for the libwebkitgtk2 library.

* GNUmakefile.am:

Tools: 

Enable the gamepad support for the GTK port.

* Scripts/webkitperl/FeatureList.pm:

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/bindings/gobject/GNUmakefile.am
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/GNUmakefile.am
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
trunk/configure.ac


Added Paths

trunk/Source/WebCore/platform/gtk/GamepadsGtk.cpp
trunk/Source/WebCore/platform/linux/
trunk/Source/WebCore/platform/linux/GamepadDeviceLinux.cpp
trunk/Source/WebCore/platform/linux/GamepadDeviceLinux.h




Diff

Modified: trunk/ChangeLog (121331 => 121332)

--- trunk/ChangeLog	2012-06-27 09:15:18 UTC (rev 121331)
+++ trunk/ChangeLog	2012-06-27 09:19:15 UTC (rev 121332)
@@ -1,3 +1,18 @@
+2012-06-27  Zan Dobersek  zandober...@gmail.com
+
+[Gtk] Add support for the Gamepad API
+https://bugs.webkit.org/show_bug.cgi?id=87503
+
+Reviewed by Carlos Garcia Campos.
+
+Only enable the Gamepad feature on Linux as support
+for other operating systems is not present.
+
+Check for the GIO Unix and GUdev dependencies when the
+Gamepad feature is enabled.
+
+* configure.ac:
+
 2012-06-25  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Make it possible to build WebKit without QtWidgets


Modified: trunk/Source/WebCore/ChangeLog (121331 => 121332)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 09:15:18 UTC (rev 121331)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 09:19:15 UTC (rev 121332)
@@ -1,3 +1,64 @@
+2012-06-27  Zan Dobersek  zandober...@gmail.com
+
+[Gtk] Add support for the Gamepad API
+https://bugs.webkit.org/show_bug.cgi?id=87503
+
+Reviewed by Carlos Garcia Campos.
+
+Add support for the Gamepad feature on the GTK port.
+
+

[webkit-changes] [121333] trunk/Source/WebCore

[commit-queue]

Title: [121333] trunk/Source/WebCore








Revision 121333
Author commit-qu...@webkit.org
Date 2012-06-27 02:26:03 -0700 (Wed, 27 Jun 2012)


Log Message
Unreviewed, rolling out r121271.
http://trac.webkit.org/changeset/121271
https://bugs.webkit.org/show_bug.cgi?id=90056

Broke a whole bunch of tests and also caused crashes in some
tests (Requested by rniwa on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-06-27

* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121332 => 121333)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 09:19:15 UTC (rev 121332)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 09:26:03 UTC (rev 121333)
@@ -1,3 +1,15 @@
+2012-06-27  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r121271.
+http://trac.webkit.org/changeset/121271
+https://bugs.webkit.org/show_bug.cgi?id=90056
+
+Broke a whole bunch of tests and also caused crashes in some
+tests (Requested by rniwa on #webkit).
+
+* editing/Editor.cpp:
+(WebCore::Editor::markAndReplaceFor):
+
 2012-06-27  Zan Dobersek  zandober...@gmail.com
 
 [Gtk] Add support for the Gamepad API


Modified: trunk/Source/WebCore/editing/Editor.cpp (121332 => 121333)

--- trunk/Source/WebCore/editing/Editor.cpp	2012-06-27 09:19:15 UTC (rev 121332)
+++ trunk/Source/WebCore/editing/Editor.cpp	2012-06-27 09:26:03 UTC (rev 121333)
@@ -2085,7 +2085,7 @@
 if (result-type == TextCheckingTypeLink  selectionOffset  resultLocation + resultLength + 1)
 continue;
 
-if (!(shouldPerformReplacement || shouldCheckForCorrection || shouldMarkLink) || !doReplacement)
+if (!(shouldPerformReplacement || shouldShowCorrectionPanel || shouldMarkLink) || !doReplacement)
 continue;
 
 String replacedString = plainText(rangeToReplace.get());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121334] trunk/Source

[dominicc]

Title: [121334] trunk/Source








Revision 121334
Author domin...@chromium.org
Date 2012-06-27 02:44:31 -0700 (Wed, 27 Jun 2012)


Log Message
[Chromium] Remove unused build scripts and empty folders for _javascript_Core w/ gyp
https://bugs.webkit.org/show_bug.cgi?id=90029

Source/_javascript_Core: 

Reviewed by Adam Barth.

* gyp: Removed.
* gyp/generate-derived-sources.sh: Removed.
* gyp/generate-dtrace-header.sh: Removed.
* gyp/run-if-exists.sh: Removed.
* gyp/update-info-plist.sh: Removed.

Source/WebCore: 

* gyp: Removed empty dir.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WebCore/ChangeLog


Removed Paths

trunk/Source/_javascript_Core/gyp/
trunk/Source/WebCore/gyp/




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121333 => 121334)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-27 09:26:03 UTC (rev 121333)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-27 09:44:31 UTC (rev 121334)
@@ -1,3 +1,16 @@
+2012-06-26  Dominic Cooney  domin...@chromium.org
+
+[Chromium] Remove unused build scripts and empty folders for _javascript_Core w/ gyp
+https://bugs.webkit.org/show_bug.cgi?id=90029
+
+Reviewed by Adam Barth.
+
+* gyp: Removed.
+* gyp/generate-derived-sources.sh: Removed.
+* gyp/generate-dtrace-header.sh: Removed.
+* gyp/run-if-exists.sh: Removed.
+* gyp/update-info-plist.sh: Removed.
+
 2012-06-26  Geoffrey Garen  gga...@apple.com
 
 Reduced (but did not eliminate) use of berzerker GC


Modified: trunk/Source/WebCore/ChangeLog (121333 => 121334)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 09:26:03 UTC (rev 121333)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 09:44:31 UTC (rev 121334)
@@ -1,3 +1,10 @@
+2012-06-26  Dominic Cooney  domin...@chromium.org
+
+[Chromium] Remove unused build scripts and empty folders for _javascript_Core w/ gyp
+https://bugs.webkit.org/show_bug.cgi?id=90029
+
+* gyp: Removed empty dir.
+
 2012-06-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r121271.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121335] trunk/Source/WebCore

[haraken]

Title: [121335] trunk/Source/WebCore








Revision 121335
Author hara...@chromium.org
Date 2012-06-27 03:21:55 -0700 (Wed, 27 Jun 2012)


Log Message
Rename Element::rareData() to Element::elementRareData(), and Element::ensureRareData() to Element::ensureElementRareData()
https://bugs.webkit.org/show_bug.cgi?id=90050

Reviewed by Ryosuke Niwa.

Element::rareData()/Element::ensureRareData() and
Node::rareData()/Node::ensureRareData() are confusing. They are not virtual
methods. For clarification, we can rename Element::rareData() to
Element::elementRareData(), and Element::ensureRareData() to
Element::ensureElementRareData().

c.f. SVGRareData uses SVGElement::rareSVGData() and SVGElement::ensureRareSVGData().
(We might want to rename them to SVGElement::svgRareData() and
SVGElement::ensureSVGRareData() in a follow-up patch.)

No tests. No change in behavior.

* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::elementRareData):
(WebCore::Element::ensureElementRareData):
(WebCore::Element::attributes):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::shadow):
(WebCore::Element::ensureShadow):
(WebCore::Element::shadowPseudoId):
(WebCore::Element::setShadowPseudoId):
(WebCore::Element::focus):
(WebCore::Element::minimumSizeForResizing):
(WebCore::Element::setMinimumSizeForResizing):
(WebCore::Element::computedStyle):
(WebCore::Element::setStyleAffectedByEmpty):
(WebCore::Element::styleAffectedByEmpty):
(WebCore::Element::cancelFocusAppearanceUpdate):
(WebCore::Element::classList):
(WebCore::Element::optionalClassList):
(WebCore::Element::dataset):
(WebCore::Element::containsFullScreenElement):
(WebCore::Element::setContainsFullScreenElement):
(WebCore::Element::hasNamedNodeMap):
(WebCore::Element::ensureCachedHTMLCollection):
(WebCore::Element::savedLayerScrollOffset):
(WebCore::Element::setSavedLayerScrollOffset):
* dom/Element.h:
(Element):
* html/LabelableElement.cpp:
(WebCore::LabelableElement::labels):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/html/LabelableElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121334 => 121335)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 09:44:31 UTC (rev 121334)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 10:21:55 UTC (rev 121335)
@@ -1,3 +1,55 @@
+2012-06-27  Kentaro Hara  hara...@chromium.org
+
+Rename Element::rareData() to Element::elementRareData(), and Element::ensureRareData() to Element::ensureElementRareData()
+https://bugs.webkit.org/show_bug.cgi?id=90050
+
+Reviewed by Ryosuke Niwa.
+
+Element::rareData()/Element::ensureRareData() and
+Node::rareData()/Node::ensureRareData() are confusing. They are not virtual
+methods. For clarification, we can rename Element::rareData() to
+Element::elementRareData(), and Element::ensureRareData() to
+Element::ensureElementRareData().
+
+c.f. SVGRareData uses SVGElement::rareSVGData() and SVGElement::ensureRareSVGData().
+(We might want to rename them to SVGElement::svgRareData() and
+SVGElement::ensureSVGRareData() in a follow-up patch.)
+
+No tests. No change in behavior.
+
+* dom/Element.cpp:
+(WebCore::Element::~Element):
+(WebCore::Element::elementRareData):
+(WebCore::Element::ensureElementRareData):
+(WebCore::Element::attributes):
+(WebCore::Element::attach):
+(WebCore::Element::detach):
+(WebCore::Element::recalcStyle):
+(WebCore::Element::shadow):
+(WebCore::Element::ensureShadow):
+(WebCore::Element::shadowPseudoId):
+(WebCore::Element::setShadowPseudoId):
+(WebCore::Element::focus):
+(WebCore::Element::minimumSizeForResizing):
+(WebCore::Element::setMinimumSizeForResizing):
+(WebCore::Element::computedStyle):
+(WebCore::Element::setStyleAffectedByEmpty):
+(WebCore::Element::styleAffectedByEmpty):
+(WebCore::Element::cancelFocusAppearanceUpdate):
+(WebCore::Element::classList):
+(WebCore::Element::optionalClassList):
+(WebCore::Element::dataset):
+(WebCore::Element::containsFullScreenElement):
+(WebCore::Element::setContainsFullScreenElement):
+(WebCore::Element::hasNamedNodeMap):
+(WebCore::Element::ensureCachedHTMLCollection):
+(WebCore::Element::savedLayerScrollOffset):
+(WebCore::Element::setSavedLayerScrollOffset):
+* dom/Element.h:
+(Element):
+* html/LabelableElement.cpp:
+(WebCore::LabelableElement::labels):
+
 2012-06-26  Dominic Cooney  domin...@chromium.org
 
 [Chromium] Remove unused build scripts and empty folders for _javascript_Core w/ gyp


Modified: trunk/Source/WebCore/dom/Element.cpp (121334 => 121335)

--- trunk/Source/WebCore/dom/Element.cpp	

[webkit-changes] [121336] trunk/Source

[vestbo]

Title: [121336] trunk/Source








Revision 121336
Author ves...@webkit.org
Date 2012-06-27 04:30:42 -0700 (Wed, 27 Jun 2012)


Log Message
[Qt] Add missing heades to HEADERS

For _javascript_Core there aren't any Qt specific files, so we include all
headers for easy editing in Qt Creator.

Reviewed by Simon Hausmann.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Target.pri
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.pro
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121335 => 121336)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-27 10:21:55 UTC (rev 121335)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-27 11:30:42 UTC (rev 121336)
@@ -1,3 +1,14 @@
+2012-06-26  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+[Qt] Add missing heades to HEADERS
+
+For _javascript_Core there aren't any Qt specific files, so we include all
+headers for easy editing in Qt Creator.
+
+Reviewed by Simon Hausmann.
+
+* Target.pri:
+
 2012-06-26  Dominic Cooney  domin...@chromium.org
 
 [Chromium] Remove unused build scripts and empty folders for _javascript_Core w/ gyp


Modified: trunk/Source/_javascript_Core/Target.pri (121335 => 121336)

--- trunk/Source/_javascript_Core/Target.pri	2012-06-27 10:21:55 UTC (rev 121335)
+++ trunk/Source/_javascript_Core/Target.pri	2012-06-27 11:30:42 UTC (rev 121336)
@@ -248,6 +248,8 @@
 tools/CodeProfiling.cpp \
 yarr/YarrJIT.cpp \
 
+HEADERS += $$files(*.h, true)
+
 *sh4* {
 QMAKE_CXXFLAGS += -mieee -w
 QMAKE_CFLAGS   += -mieee -w


Modified: trunk/Source/WTF/ChangeLog (121335 => 121336)

--- trunk/Source/WTF/ChangeLog	2012-06-27 10:21:55 UTC (rev 121335)
+++ trunk/Source/WTF/ChangeLog	2012-06-27 11:30:42 UTC (rev 121336)
@@ -1,3 +1,14 @@
+2012-06-26  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+[Qt] Add missing heades to HEADERS
+
+For _javascript_Core there aren't any Qt specific files, so we include all
+headers for easy editing in Qt Creator.
+
+Reviewed by Simon Hausmann.
+
+* WTF.pro:
+
 2012-06-25  Kent Tamura  tk...@chromium.org
 
 Unreviewed, rolling out r121145.


Modified: trunk/Source/WTF/WTF.pro (121335 => 121336)

--- trunk/Source/WTF/WTF.pro	2012-06-27 10:21:55 UTC (rev 121335)
+++ trunk/Source/WTF/WTF.pro	2012-06-27 11:30:42 UTC (rev 121336)
@@ -52,6 +52,7 @@
 dtoa/utils.h \
 DynamicAnnotations.h \
 Encoder.h \
+ExportMacros.h \
 FastAllocBase.h \
 FastMalloc.h \
 FixedArray.h \


Modified: trunk/Source/WebCore/ChangeLog (121335 => 121336)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 10:21:55 UTC (rev 121335)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 11:30:42 UTC (rev 121336)
@@ -1,3 +1,14 @@
+2012-06-26  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+[Qt] Add missing heades to HEADERS
+
+For _javascript_Core there aren't any Qt specific files, so we include all
+headers for easy editing in Qt Creator.
+
+Reviewed by Simon Hausmann.
+
+* Target.pri:
+
 2012-06-27  Kentaro Hara  hara...@chromium.org
 
 Rename Element::rareData() to Element::elementRareData(), and Element::ensureRareData() to Element::ensureElementRareData()


Modified: trunk/Source/WebCore/Target.pri (121335 => 121336)

--- trunk/Source/WebCore/Target.pri	2012-06-27 10:21:55 UTC (rev 121335)
+++ trunk/Source/WebCore/Target.pri	2012-06-27 11:30:42 UTC (rev 121336)
@@ -2385,6 +2385,7 @@
 platform/network/ResourceResponseBase.h \
 platform/network/qt/DnsPrefetchHelper.h \
 platform/network/qt/NetworkStateNotifierPrivate.h \
+platform/PlatformExportMacros.h \
 platform/PlatformTouchEvent.h \
 platform/PlatformTouchPoint.h \
 platform/PopupMenu.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121337] trunk

[apavlov]

Title: [121337] trunk








Revision 121337
Author apav...@chromium.org
Date 2012-06-27 04:35:06 -0700 (Wed, 27 Jun 2012)


Log Message
Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs
https://bugs.webkit.org/show_bug.cgi?id=89980

Reviewed by Antti Koivisto.

Source/WebCore:

Use the closing_brace at the end of font_face rather than the explicit '}' maybe_space.

Test: fast/css/font-face-unexpected-end.html

* css/CSSGrammar.y:

LayoutTests:

* fast/css/font-face-unexpected-end-expected.html: Added.
* fast/css/font-face-unexpected-end.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y


Added Paths

trunk/LayoutTests/fast/css/font-face-unexpected-end-expected.html
trunk/LayoutTests/fast/css/font-face-unexpected-end.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121336 => 121337)

--- trunk/LayoutTests/ChangeLog	2012-06-27 11:30:42 UTC (rev 121336)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 11:35:06 UTC (rev 121337)
@@ -1,3 +1,13 @@
+2012-06-27  Alexander Pavlov  apav...@chromium.org
+
+Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs
+https://bugs.webkit.org/show_bug.cgi?id=89980
+
+Reviewed by Antti Koivisto.
+
+* fast/css/font-face-unexpected-end-expected.html: Added.
+* fast/css/font-face-unexpected-end.html: Added.
+
 2012-06-27  Zoltan Arvai  zar...@inf.u-szeged.hu
 
 [Qt] Unreviewed gardening, rebaseline after r121303.


Added: trunk/LayoutTests/fast/css/font-face-unexpected-end-expected.html (0 => 121337)

--- trunk/LayoutTests/fast/css/font-face-unexpected-end-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css/font-face-unexpected-end-expected.html	2012-06-27 11:35:06 UTC (rev 121337)
@@ -0,0 +1,14 @@
+style
+@font-face {
+font-family: ahem-family;
+src: url(../../resources/Ahem.otf);
+}
+/style
+p
+Test for ia href="" Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs/i.
+/p
+pCheck if a @font-face rule without a closing brace is accepted./p
+span style=font-family: ahem-family0123456789ABCDEF/span
+script
+document.body.offsetTop;
+/script


Added: trunk/LayoutTests/fast/css/font-face-unexpected-end.html (0 => 121337)

--- trunk/LayoutTests/fast/css/font-face-unexpected-end.html	(rev 0)
+++ trunk/LayoutTests/fast/css/font-face-unexpected-end.html	2012-06-27 11:35:06 UTC (rev 121337)
@@ -0,0 +1,14 @@
+style
+@font-face {
+font-family: ahem-family;
+src: url(../../resources/Ahem.otf);
+/* The @font-face rule has no closing brace, so the style sheet is terminated unexpectedly. */
+/style
+p
+Test for ia href="" Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs/i.
+/p
+pCheck if a @font-face rule without a closing brace is accepted./p
+span style=font-family: ahem-family0123456789ABCDEF/span
+script
+document.body.offsetTop;
+/script


Modified: trunk/Source/WebCore/ChangeLog (121336 => 121337)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 11:30:42 UTC (rev 121336)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 11:35:06 UTC (rev 121337)
@@ -1,3 +1,16 @@
+2012-06-27  Alexander Pavlov  apav...@chromium.org
+
+Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs
+https://bugs.webkit.org/show_bug.cgi?id=89980
+
+Reviewed by Antti Koivisto.
+
+Use the closing_brace at the end of font_face rather than the explicit '}' maybe_space.
+
+Test: fast/css/font-face-unexpected-end.html
+
+* css/CSSGrammar.y:
+
 2012-06-26  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Add missing heades to HEADERS


Modified: trunk/Source/WebCore/css/CSSGrammar.y (121336 => 121337)

--- trunk/Source/WebCore/css/CSSGrammar.y	2012-06-27 11:30:42 UTC (rev 121336)
+++ trunk/Source/WebCore/css/CSSGrammar.y	2012-06-27 11:35:06 UTC (rev 121337)
@@ -101,7 +101,7 @@
 
 %}
 
-%expect 63
+%expect 62
 
 %nonassoc LOWEST_PREC
 
@@ -789,7 +789,7 @@
 
 font_face:
 FONT_FACE_SYM maybe_space
-'{' maybe_space declaration_list '}'  maybe_space {
+'{' maybe_space declaration_list closing_brace {
 $$ = static_castCSSParser*(parser)-createFontFaceRule();
 }
 | FONT_FACE_SYM error invalid_block {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121338] trunk/Source/JavaScriptCore

[vestbo]

Title: [121338] trunk/Source/_javascript_Core








Revision 121338
Author ves...@webkit.org
Date 2012-06-27 06:02:03 -0700 (Wed, 27 Jun 2012)


Log Message
[Qt] Remove redundant c++11 warning suppression code

This is already handled in default_post.

Patch by Oswald Buddenhagen oswald.buddenha...@nokia.com on 2012-06-27
Reviewed by Tor Arne Vestbø.

* Target.pri:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Target.pri




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121337 => 121338)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-27 11:35:06 UTC (rev 121337)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-27 13:02:03 UTC (rev 121338)
@@ -1,3 +1,13 @@
+2012-06-27  Oswald Buddenhagen  oswald.buddenha...@nokia.com
+
+[Qt] Remove redundant c++11 warning suppression code
+
+This is already handled in default_post.
+
+Reviewed by Tor Arne Vestbø.
+
+* Target.pri:
+
 2012-06-26  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Add missing heades to HEADERS


Modified: trunk/Source/_javascript_Core/Target.pri (121337 => 121338)

--- trunk/Source/_javascript_Core/Target.pri	2012-06-27 11:35:06 UTC (rev 121337)
+++ trunk/Source/_javascript_Core/Target.pri	2012-06-27 13:02:03 UTC (rev 121338)
@@ -261,15 +261,4 @@
 # Disable C++0x mode in JSC for those who enabled it in their Qt's mkspec.
 *-g++*:QMAKE_CXXFLAGS -= -std=c++0x -std=gnu++0x
 }
-
-# GCC 4.6 and after.
-greaterThan(QT_GCC_MINOR_VERSION, 5) {
-if (!contains(QMAKE_CXXFLAGS, -std=c++0x)  !contains(QMAKE_CXXFLAGS, -std=gnu++0x)) {
-# We need to deactivate those warnings because some names conflicts with upcoming c++0x types (e.g.nullptr).
-QMAKE_CFLAGS_WARN_ON += -Wno-c++0x-compat
-QMAKE_CXXFLAGS_WARN_ON += -Wno-c++0x-compat
-QMAKE_CFLAGS += -Wno-c++0x-compat
-QMAKE_CXXFLAGS += -Wno-c++0x-compat
-}
-}
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121339] trunk/Tools

[vestbo]

Title: [121339] trunk/Tools








Revision 121339
Author ves...@webkit.org
Date 2012-06-27 06:05:43 -0700 (Wed, 27 Jun 2012)


Log Message
[Qt] Fix lookup location for sqlite sources

Don't look in the install dir - we are unlikely to find anything there
unless we are doing a developer build.

Patch by Oswald Buddenhagen oswald.buddenha...@nokia.com on 2012-06-27
Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/features.prf:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/features.prf




Diff

Modified: trunk/Tools/ChangeLog (121338 => 121339)

--- trunk/Tools/ChangeLog	2012-06-27 13:02:03 UTC (rev 121338)
+++ trunk/Tools/ChangeLog	2012-06-27 13:05:43 UTC (rev 121339)
@@ -1,3 +1,14 @@
+2012-06-27  Oswald Buddenhagen  oswald.buddenha...@nokia.com
+
+[Qt] Fix lookup location for sqlite sources
+
+Don't look in the install dir - we are unlikely to find anything there
+unless we are doing a developer build.
+
+Reviewed by Tor Arne Vestbø.
+
+* qmake/mkspecs/features/features.prf:
+
 2012-06-27  Zan Dobersek  zandober...@gmail.com
 
 [Gtk] Add support for the Gamepad API


Modified: trunk/Tools/qmake/mkspecs/features/features.prf (121338 => 121339)

--- trunk/Tools/qmake/mkspecs/features/features.prf	2012-06-27 13:02:03 UTC (rev 121338)
+++ trunk/Tools/qmake/mkspecs/features/features.prf	2012-06-27 13:05:43 UTC (rev 121339)
@@ -23,7 +23,7 @@
 # Try to locate sqlite3 source
 SQLITE3SRCDIR = $$(SQLITE3SRCDIR)
 isEmpty(SQLITE3SRCDIR) {
-SQLITE3SRCDIR = $$[QT_INSTALL_PREFIX]/src/3rdparty/sqlite/
+SQLITE3SRCDIR = $$QT.core.sources/../3rdparty/sqlite/
 }
 
 # -- Dynamically detect optional features -






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121340] trunk/Tools

[vestbo]

Title: [121340] trunk/Tools








Revision 121340
Author ves...@webkit.org
Date 2012-06-27 07:24:56 -0700 (Wed, 27 Jun 2012)


Log Message
[Qt] No need to save and restore TEMPLATE in a function

This was a leftover from when the logic was not in its own function scope.

QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
will surprisingly affect the global scope as well, so we have to save and restore it.

Original patch by Oswald Buddenhagen oswald.buddenha...@nokia.com on 2012-06-27

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/functions.prf:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/functions.prf




Diff

Modified: trunk/Tools/ChangeLog (121339 => 121340)

--- trunk/Tools/ChangeLog	2012-06-27 13:05:43 UTC (rev 121339)
+++ trunk/Tools/ChangeLog	2012-06-27 14:24:56 UTC (rev 121340)
@@ -1,3 +1,18 @@
+2012-06-27  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+[Qt] No need to save and restore TEMPLATE in a function
+
+This was a leftover from when the logic was not in its own function scope.
+
+QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
+will surprisingly affect the global scope as well, so we have to save and restore it.
+
+Original patch by Oswald Buddenhagen oswald.buddenha...@nokia.com on 2012-06-27
+
+Reviewed by Tor Arne Vestbø.
+
+* qmake/mkspecs/features/functions.prf:
+
 2012-06-27  Oswald Buddenhagen  oswald.buddenha...@nokia.com
 
 [Qt] Fix lookup location for sqlite sources


Modified: trunk/Tools/qmake/mkspecs/features/functions.prf (121339 => 121340)

--- trunk/Tools/qmake/mkspecs/features/functions.prf	2012-06-27 13:05:43 UTC (rev 121339)
+++ trunk/Tools/qmake/mkspecs/features/functions.prf	2012-06-27 14:24:56 UTC (rev 121340)
@@ -234,13 +234,13 @@
 defineReplace(resolveFinalLibraryName) {
 !debug_and_release: return($$1)
 
-original_template = $$TEMPLATE
 original_framework_name = $$QMAKE_FRAMEWORK_BUNDLE_NAME
 
 TEMPLATE = lib # So that qtLibraryTarget works
 target = $$qtLibraryTarget($$1)
 
-TEMPLATE = $$original_template
+# qtLibraryTarget will export QMAKE_FRAMEWORK_BUNDLE_NAME, which gets
+# exported not only to this function scope, but to our call site.
 QMAKE_FRAMEWORK_BUNDLE_NAME = $$original_framework_name
 export(QMAKE_FRAMEWORK_BUNDLE_NAME)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121341] trunk/Source/WebCore

[vestbo]

Title: [121341] trunk/Source/WebCore








Revision 121341
Author ves...@webkit.org
Date 2012-06-27 07:27:00 -0700 (Wed, 27 Jun 2012)


Log Message
[Qt] Remove redundant NDEBUG definition

Already handled in default_post.prf.

Patch by Oswald Buddenhagen oswald.buddenha...@nokia.com on 2012-06-27
Reviewed by Tor Arne Vestbø.

* WebCore.pri:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (121340 => 121341)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 14:24:56 UTC (rev 121340)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 14:27:00 UTC (rev 121341)
@@ -1,3 +1,13 @@
+2012-06-27  Oswald Buddenhagen  oswald.buddenha...@nokia.com
+
+[Qt] Remove redundant NDEBUG definition
+
+Already handled in default_post.prf.
+
+Reviewed by Tor Arne Vestbø.
+
+* WebCore.pri:
+
 2012-06-27  Alexander Pavlov  apav...@chromium.org
 
 Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs


Modified: trunk/Source/WebCore/WebCore.pri (121340 => 121341)

--- trunk/Source/WebCore/WebCore.pri	2012-06-27 14:24:56 UTC (rev 121340)
+++ trunk/Source/WebCore/WebCore.pri	2012-06-27 14:27:00 UTC (rev 121341)
@@ -230,7 +230,6 @@
 !system-sqlite:exists( $${SQLITE3SRCDIR}/sqlite3.c ) {
 INCLUDEPATH += $${SQLITE3SRCDIR}
 DEFINES += SQLITE_CORE SQLITE_OMIT_LOAD_EXTENSION SQLITE_OMIT_COMPLETE
-CONFIG(release, debug|release): DEFINES *= NDEBUG
 } else {
 INCLUDEPATH += $${SQLITE3SRCDIR}
 LIBS += -lsqlite3






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121342] trunk/Source/WebKit/chromium

[rjkroege]

Title: [121342] trunk/Source/WebKit/chromium








Revision 121342
Author rjkro...@chromium.org
Date 2012-06-27 07:55:13 -0700 (Wed, 27 Jun 2012)


Log Message
[chromium] out-of-order assert in WebViewImpl setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=90006

The assert in WebViewImpl::setDeviceScaleFactor should test for non-scaling
after we have set both m_DeviceScaleInCompositor and page()-deviceScaleFactor()
instead of in between.

Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setDeviceScaleFactor):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (121341 => 121342)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-06-27 14:27:00 UTC (rev 121341)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-06-27 14:55:13 UTC (rev 121342)
@@ -1,3 +1,17 @@
+2012-06-27  Robert Kroeger  rjkro...@chromium.org
+
+[chromium] out-of-order assert in WebViewImpl setDeviceScaleFactor
+https://bugs.webkit.org/show_bug.cgi?id=90006
+
+The assert in WebViewImpl::setDeviceScaleFactor should test for non-scaling
+after we have set both m_DeviceScaleInCompositor and page()-deviceScaleFactor()
+instead of in between.
+
+Reviewed by James Robinson.
+
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::setDeviceScaleFactor):
+
 2012-06-26  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed.  Rolled DEPS.


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (121341 => 121342)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-06-27 14:27:00 UTC (rev 121341)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-06-27 14:55:13 UTC (rev 121342)
@@ -2551,16 +2551,16 @@
 
 page()-setDeviceScaleFactor(scaleFactor);
 
+if (!m_layerTreeView.isNull()  m_webSettings-applyDefaultDeviceScaleFactorInCompositor()) {
+m_deviceScaleInCompositor = page()-deviceScaleFactor();
+m_layerTreeView.setDeviceScaleFactor(m_deviceScaleInCompositor);
+}
 if (m_deviceScaleInCompositor != 1) {
 // Don't allow page scaling when compositor scaling is being used,
 // as they are currently incompatible. This means the deviceScale
 // needs to match the one in the compositor.
 ASSERT(scaleFactor == m_deviceScaleInCompositor);
 }
-if (!m_layerTreeView.isNull()  m_webSettings-applyDefaultDeviceScaleFactorInCompositor()) {
-m_deviceScaleInCompositor = page()-deviceScaleFactor();
-m_layerTreeView.setDeviceScaleFactor(m_deviceScaleInCompositor);
-}
 }
 
 bool WebViewImpl::isFixedLayoutModeEnabled() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121343] trunk/Source/WebCore

[reed]

Title: [121343] trunk/Source/WebCore








Revision 121343
Author r...@google.com
Date 2012-06-27 08:06:24 -0700 (Wed, 27 Jun 2012)


Log Message
Cleanup scaling code in text-decorations for SVG InlineText. Use scale() instead of getCTM/normalizeTransform/setCTM
to use more standard pattern for scaling, and to allow for these operations to be recorded and played back later
(potentially with a different starting matrix). This effectively reverts change# 78704.
https://bugs.webkit.org/show_bug.cgi?id=89888

Reviewed by Nikolas Zimmermann.

No new tests. Current layouttests exercise this code path.

* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
(WebCore::SVGInlineTextBox::paintTextWithShadows):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121342 => 121343)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 14:55:13 UTC (rev 121342)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 15:06:24 UTC (rev 121343)
@@ -1,3 +1,18 @@
+2012-06-27  Mike Reed  r...@google.com
+
+Cleanup scaling code in text-decorations for SVG InlineText. Use scale() instead of getCTM/normalizeTransform/setCTM
+to use more standard pattern for scaling, and to allow for these operations to be recorded and played back later
+(potentially with a different starting matrix). This effectively reverts change# 78704.
+https://bugs.webkit.org/show_bug.cgi?id=89888
+
+Reviewed by Nikolas Zimmermann.
+
+No new tests. Current layouttests exercise this code path.
+
+* rendering/svg/SVGInlineTextBox.cpp:
+(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
+(WebCore::SVGInlineTextBox::paintTextWithShadows):
+
 2012-06-27  Oswald Buddenhagen  oswald.buddenha...@nokia.com
 
 [Qt] Remove redundant NDEBUG definition


Modified: trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp (121342 => 121343)

--- trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp	2012-06-27 14:55:13 UTC (rev 121342)
+++ trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp	2012-06-27 15:06:24 UTC (rev 121343)
@@ -547,29 +547,6 @@
 }
 }
 
-static inline void normalizeTransform(AffineTransform transform)
-{
-// Obtain consistent numerical results for the AffineTransform on both 32/64bit platforms.
-// Tested with SnowLeopard on Core Duo vs. Core 2 Duo.
-static const float s_floatEpsilon = std::numeric_limitsfloat::epsilon();
-
-if (fabs(transform.a() - 1) = s_floatEpsilon)
-transform.setA(1);
-else if (fabs(transform.a() + 1) = s_floatEpsilon)
-transform.setA(-1);
-
-if (fabs(transform.d() - 1) = s_floatEpsilon)
-transform.setD(1);
-else if (fabs(transform.d() + 1) = s_floatEpsilon)
-transform.setD(-1);
-
-if (fabs(transform.e()) = s_floatEpsilon)
-transform.setE(0);
-
-if (fabs(transform.f()) = s_floatEpsilon)
-transform.setF(0);
-}
-
 void SVGInlineTextBox::paintDecorationWithStyle(GraphicsContext* context, ETextDecoration decoration, const SVGTextFragment fragment, RenderObject* decorationRenderer)
 {
 ASSERT(!m_paintingResource);
@@ -597,12 +574,7 @@
 if (scalingFactor != 1) {
 width *= scalingFactor;
 decorationOrigin.scale(scalingFactor, scalingFactor);
-
-AffineTransform newTransform = context-getCTM();
-newTransform.scale(1 / scalingFactor);
-normalizeTransform(newTransform);
-
-context-setCTM(newTransform);
+context-scale(FloatSize(1 / scalingFactor, 1 / scalingFactor));
 }
 
 decorationOrigin.move(0, -scaledFontMetrics.floatAscent() + positionOffsetForDecoration(decoration, scaledFontMetrics, thickness));
@@ -643,21 +615,12 @@
 if (shadow)
 extraOffset = applyShadowToGraphicsContext(context, shadow, shadowRect, false /* stroked */, true /* opaque */, true /* horizontal */);
 
-AffineTransform originalTransform;
-if (scalingFactor != 1) {
-originalTransform = context-getCTM();
+context-save();
+context-scale(FloatSize(1 / scalingFactor, 1 / scalingFactor));
 
-AffineTransform newTransform = originalTransform;
-newTransform.scale(1 / scalingFactor);
-normalizeTransform(newTransform);
-
-context-setCTM(newTransform);
-}
-
 scaledFont.drawText(context, textRun, textOrigin + extraOffset, startPosition, endPosition);
 
-if (scalingFactor != 1)
-context-setCTM(originalTransform);
+context-restore();
 
 restoreGraphicsContextAfterTextPainting(context, textRun);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121344] trunk/Source/WebCore

[shinyak]

Title: [121344] trunk/Source/WebCore








Revision 121344
Author shin...@chromium.org
Date 2012-06-27 08:18:07 -0700 (Wed, 27 Jun 2012)


Log Message
HTMLStyleElement::removedFrom seems incorrect.
https://bugs.webkit.org/show_bug.cgi?id=89986

Reviewed by Hajime Morita.

This is a follow-up patch for Bug 88495. The Same bug as Bug 88495 seems to exist on
HTMLStyleElement::removedFrom().

No new tests, hard to write a test case.

* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::removedFrom):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLStyleElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121343 => 121344)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 15:06:24 UTC (rev 121343)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 15:18:07 UTC (rev 121344)
@@ -1,3 +1,18 @@
+2012-06-27  Shinya Kawanaka  shin...@chromium.org
+
+HTMLStyleElement::removedFrom seems incorrect.
+https://bugs.webkit.org/show_bug.cgi?id=89986
+
+Reviewed by Hajime Morita.
+
+This is a follow-up patch for Bug 88495. The Same bug as Bug 88495 seems to exist on
+HTMLStyleElement::removedFrom().
+
+No new tests, hard to write a test case.
+
+* html/HTMLStyleElement.cpp:
+(WebCore::HTMLStyleElement::removedFrom):
+
 2012-06-27  Mike Reed  r...@google.com
 
 Cleanup scaling code in text-decorations for SVG InlineText. Use scale() instead of getCTM/normalizeTransform/setCTM


Modified: trunk/Source/WebCore/html/HTMLStyleElement.cpp (121343 => 121344)

--- trunk/Source/WebCore/html/HTMLStyleElement.cpp	2012-06-27 15:06:24 UTC (rev 121343)
+++ trunk/Source/WebCore/html/HTMLStyleElement.cpp	2012-06-27 15:18:07 UTC (rev 121344)
@@ -199,9 +199,13 @@
 // Now, if we want to register style scoped even if it's not inDocument,
 // we'd need to find a way to discern whether that is the case, or whether style scoped itself is about to be removed.
 if (m_scopedStyleRegistrationState != NotRegistered) {
-ContainerNode* scope = parentNode()? parentNode() : insertionPoint;
-if (m_scopedStyleRegistrationState == RegisteredInShadowRoot)
-scope = scope-shadowRoot();
+ContainerNode* scope;
+if (m_scopedStyleRegistrationState == RegisteredInShadowRoot) {
+scope = shadowRoot();
+if (!scope)
+scope = insertionPoint-shadowRoot();
+} else
+scope = parentNode() ? parentNode() : insertionPoint;
 unregisterWithScopingNode(scope);
 }
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121345] trunk/Tools

[sergio]

Title: [121345] trunk/Tools








Revision 121345
Author ser...@webkit.org
Date 2012-06-27 08:52:00 -0700 (Wed, 27 Jun 2012)


Log Message
[WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
https://bugs.webkit.org/show_bug.cgi?id=90061

Reviewed by Gustavo Noronha Silva.

Add -no-install -no-fast-install to the LDFLAGS in bots. With
this flag libtool tells the linker to set the rpath for the output
file to the full path of the .libs directory, instead of using a
wrapper script to set up the LD_LIBRARY_PATH. This will allow us
to directly reuse builds in the pure testing bots.

* BuildSlaveSupport/gtk/daemontools-buildbot.conf:

Modified Paths

trunk/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf (121344 => 121345)

--- trunk/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf	2012-06-27 15:18:07 UTC (rev 121344)
+++ trunk/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf	2012-06-27 15:52:00 UTC (rev 121345)
@@ -40,5 +40,6 @@
 #
 env_CFLAGS=-pipe
 env_CXXFLAGS=-pipe
+env_LDFLAGS=-no-install -no-fast-install
 env_WEBKIT_TESTFONTS=/home/${buildbot_user}/testfonts
 


Modified: trunk/Tools/ChangeLog (121344 => 121345)

--- trunk/Tools/ChangeLog	2012-06-27 15:18:07 UTC (rev 121344)
+++ trunk/Tools/ChangeLog	2012-06-27 15:52:00 UTC (rev 121345)
@@ -1,3 +1,18 @@
+2012-06-27  Sergio Villar Senin  svil...@igalia.com
+
+[WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
+https://bugs.webkit.org/show_bug.cgi?id=90061
+
+Reviewed by Gustavo Noronha Silva.
+
+Add -no-install -no-fast-install to the LDFLAGS in bots. With
+this flag libtool tells the linker to set the rpath for the output
+file to the full path of the .libs directory, instead of using a
+wrapper script to set up the LD_LIBRARY_PATH. This will allow us
+to directly reuse builds in the pure testing bots.
+
+* BuildSlaveSupport/gtk/daemontools-buildbot.conf:
+
 2012-06-27  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] No need to save and restore TEMPLATE in a function






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121346] trunk/Tools

[ossy]

Title: [121346] trunk/Tools








Revision 121346
Author o...@webkit.org
Date 2012-06-27 09:55:51 -0700 (Wed, 27 Jun 2012)


Log Message
[Qt] REGRESSION(r121339): It broke the build on the Qt Windows bots
https://bugs.webkit.org/show_bug.cgi?id=90081

Buildfix for Qt 4.8 Windows. Use the former path for Qt 4.8, and the newer one for Qt 5.

Reviewed by Noam Rosenthal.

* qmake/mkspecs/features/features.prf:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/features.prf




Diff

Modified: trunk/Tools/ChangeLog (121345 => 121346)

--- trunk/Tools/ChangeLog	2012-06-27 15:52:00 UTC (rev 121345)
+++ trunk/Tools/ChangeLog	2012-06-27 16:55:51 UTC (rev 121346)
@@ -1,3 +1,14 @@
+2012-06-27  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] REGRESSION(r121339): It broke the build on the Qt Windows bots
+https://bugs.webkit.org/show_bug.cgi?id=90081
+
+Buildfix for Qt 4.8 Windows. Use the former path for Qt 4.8, and the newer one for Qt 5.
+
+Reviewed by Noam Rosenthal.
+
+* qmake/mkspecs/features/features.prf:
+
 2012-06-27  Sergio Villar Senin  svil...@igalia.com
 
 [WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files


Modified: trunk/Tools/qmake/mkspecs/features/features.prf (121345 => 121346)

--- trunk/Tools/qmake/mkspecs/features/features.prf	2012-06-27 15:52:00 UTC (rev 121345)
+++ trunk/Tools/qmake/mkspecs/features/features.prf	2012-06-27 16:55:51 UTC (rev 121346)
@@ -23,7 +23,8 @@
 # Try to locate sqlite3 source
 SQLITE3SRCDIR = $$(SQLITE3SRCDIR)
 isEmpty(SQLITE3SRCDIR) {
-SQLITE3SRCDIR = $$QT.core.sources/../3rdparty/sqlite/
+haveQt(5):SQLITE3SRCDIR = $$QT.core.sources/../3rdparty/sqlite/
+else:SQLITE3SRCDIR = $$[QT_INSTALL_PREFIX]/src/3rdparty/sqlite/
 }
 
 # -- Dynamically detect optional features -






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121347] trunk/Source/WebCore

[kling]

Title: [121347] trunk/Source/WebCore








Revision 121347
Author kl...@webkit.org
Date 2012-06-27 10:22:30 -0700 (Wed, 27 Jun 2012)


Log Message
REGRESSION(r121296): New zero-size background tests asserting on Mac.
http://webkit.org/b/90071

Reviewed by Dan Bernstein.

Remove ASSERT(patternTransform.isInvertible()) as this is now a valid scenario.

* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/ImageCG.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121346 => 121347)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 16:55:51 UTC (rev 121346)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 17:22:30 UTC (rev 121347)
@@ -1,3 +1,15 @@
+2012-06-27  Andreas Kling  kl...@webkit.org
+
+REGRESSION(r121296): New zero-size background tests asserting on Mac.
+http://webkit.org/b/90071
+
+Reviewed by Dan Bernstein.
+
+Remove ASSERT(patternTransform.isInvertible()) as this is now a valid scenario.
+
+* platform/graphics/cg/ImageCG.cpp:
+(WebCore::Image::drawPattern):
+
 2012-06-27  Shinya Kawanaka  shin...@chromium.org
 
 HTMLStyleElement::removedFrom seems incorrect.


Modified: trunk/Source/WebCore/platform/graphics/cg/ImageCG.cpp (121346 => 121347)

--- trunk/Source/WebCore/platform/graphics/cg/ImageCG.cpp	2012-06-27 16:55:51 UTC (rev 121346)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageCG.cpp	2012-06-27 17:22:30 UTC (rev 121347)
@@ -229,9 +229,7 @@
 if (!nativeImageForCurrentFrame())
 return;
 
-ASSERT(patternTransform.isInvertible());
 if (!patternTransform.isInvertible())
-// Avoid a hang under CGContextDrawTiledImage on release builds.
 return;
 
 CGContextRef context = ctxt-platformContext();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121348] trunk

[achicu]

Title: [121348] trunk








Revision 121348
Author ach...@adobe.com
Date 2012-06-27 10:38:05 -0700 (Wed, 27 Jun 2012)


Log Message
Blur filter causes issues when scrolling
https://bugs.webkit.org/show_bug.cgi?id=89475

Reviewed by Simon Fraser.

Source/WebCore:

This patch disables the fast scrolling when there is a fixed postioned element that
has a filter applied on its parent layer. Otherwise the scroll blitting will just
copy the outsets of the blur effect.

Test: css3/filters/blur-filter-page-scroll.html

* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):

LayoutTests:

Checking that the fixed positioned element repaints correctly when there is a blur filter
applied on its parent layer.

* css3/filters/blur-filter-page-scroll.html: Added.
* platform/chromium/css3/filters/blur-filter-page-scroll-expected.png: Added.
* platform/chromium/css3/filters/blur-filter-page-scroll-expected.txt: Added.
* platform/chromium/TestExpectations: The new test needs to be checked on Windows.
* platform/mac/css3/filters/blur-filter-page-scroll-expected.png: Added.
* platform/mac/css3/filters/blur-filter-page-scroll-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp


Added Paths

trunk/LayoutTests/css3/filters/blur-filter-page-scroll.html
trunk/LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-expected.png
trunk/LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-expected.txt
trunk/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-expected.png
trunk/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (121347 => 121348)

--- trunk/LayoutTests/ChangeLog	2012-06-27 17:22:30 UTC (rev 121347)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 17:38:05 UTC (rev 121348)
@@ -1,3 +1,20 @@
+2012-06-27  Alexandru Chiculita  ach...@adobe.com
+
+Blur filter causes issues when scrolling
+https://bugs.webkit.org/show_bug.cgi?id=89475
+
+Reviewed by Simon Fraser.
+
+Checking that the fixed positioned element repaints correctly when there is a blur filter
+applied on its parent layer.
+
+* css3/filters/blur-filter-page-scroll.html: Added.
+* platform/chromium/css3/filters/blur-filter-page-scroll-expected.png: Added.
+* platform/chromium/css3/filters/blur-filter-page-scroll-expected.txt: Added.
+* platform/chromium/TestExpectations: The new test needs to be checked on Windows.
+* platform/mac/css3/filters/blur-filter-page-scroll-expected.png: Added.
+* platform/mac/css3/filters/blur-filter-page-scroll-expected.txt: Added.
+
 2012-06-27  Alexander Pavlov  apav...@chromium.org
 
 Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs


Added: trunk/LayoutTests/css3/filters/blur-filter-page-scroll.html (0 => 121348)

--- trunk/LayoutTests/css3/filters/blur-filter-page-scroll.html	(rev 0)
+++ trunk/LayoutTests/css3/filters/blur-filter-page-scroll.html	2012-06-27 17:38:05 UTC (rev 121348)
@@ -0,0 +1,59 @@
+!-- This test asserts that blit-scrolling is disabled when blur is applied on a layer 
+that contains a fixed positioned object.
+One fixed black bar should be visible at the top of the page. The page should be scrolled
+100px and no red should be visible. The rest of the page should be green.
+ --
+!DOCTYPE html
+html
+head
+script
+if (window.testRunner) {
+// Force software rendering mode.
+window.testRunner.overridePreference(WebKitAcceleratedCompositingEnabled, 0);
+}
+/script
+!-- Make sure the mock scrollbars are enabled after the call to overridePreference, otherwise the setting will be overwritten. --
+script src=""
+style
+body {
+margin: 0px;
+border: 0px;
+padding: 0px;
+}
+
+.blur {
+-webkit-filter: blur(1px);
+}
+
+#fixedBox {
+position: fixed;
+background-color: #00;
+height: 100px;
+width: 100%;
+}
+
+#redBox {
+background-color: red; 
+height: 200px;
+}
+
+#greenBox {
+background-color: green;
+height: 1000px;
+}
+/style
+script src=""
+script type=text/_javascript_
+function repaintTest() {
+window.scrollTo(0, 100);
+}
+/script
+/head
+body _onload_=runRepaintTest()
+div class=blur
+div id=fixedBox/div
+div id=redBox/div
+div id=greenBox/div
+/div
+   

[webkit-changes] [121349] trunk/Source/WebCore

[commit-queue]

Title: [121349] trunk/Source/WebCore








Revision 121349
Author commit-qu...@webkit.org
Date 2012-06-27 10:45:24 -0700 (Wed, 27 Jun 2012)


Log Message
Move CSSWrapShape style resolution from StyleResolver to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=89668

Patch by Hans Muller hmul...@adobe.com on 2012-06-27
Reviewed by Andreas Kling.

Moved the resolution of the shapeInside and shapeOutside CSS properties
from the StyleResolver class to StyleBuilder. This is just refactoring
in preparation for fixing https://bugs.webkit.org/show_bug.cgi?id=89670.

No new tests were required.

* css/StyleBuilder.cpp:
(WebCore):
(ApplyPropertyWrapShape):
(WebCore::ApplyPropertyWrapShape::setValue):
(WebCore::ApplyPropertyWrapShape::applyValue):
(WebCore::ApplyPropertyWrapShape::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleBuilder.cpp
trunk/Source/WebCore/css/StyleResolver.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121348 => 121349)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 17:38:05 UTC (rev 121348)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 17:45:24 UTC (rev 121349)
@@ -1,3 +1,26 @@
+2012-06-27  Hans Muller  hmul...@adobe.com
+
+Move CSSWrapShape style resolution from StyleResolver to StyleBuilder
+https://bugs.webkit.org/show_bug.cgi?id=89668
+
+Reviewed by Andreas Kling.
+
+Moved the resolution of the shapeInside and shapeOutside CSS properties
+from the StyleResolver class to StyleBuilder. This is just refactoring
+in preparation for fixing https://bugs.webkit.org/show_bug.cgi?id=89670.
+
+No new tests were required.
+
+* css/StyleBuilder.cpp:
+(WebCore):
+(ApplyPropertyWrapShape):
+(WebCore::ApplyPropertyWrapShape::setValue):
+(WebCore::ApplyPropertyWrapShape::applyValue):
+(WebCore::ApplyPropertyWrapShape::createHandler):
+(WebCore::StyleBuilder::StyleBuilder):
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::collectMatchingRulesForList):
+
 2012-06-27  Alexandru Chiculita  ach...@adobe.com
 
 Blur filter causes issues when scrolling


Modified: trunk/Source/WebCore/css/StyleBuilder.cpp (121348 => 121349)

--- trunk/Source/WebCore/css/StyleBuilder.cpp	2012-06-27 17:38:05 UTC (rev 121348)
+++ trunk/Source/WebCore/css/StyleBuilder.cpp	2012-06-27 17:45:24 UTC (rev 121349)
@@ -1780,6 +1780,29 @@
 
 };
 
+#if ENABLE(CSS_EXCLUSIONS)
+template CSSWrapShape* (RenderStyle::*getterFunction)() const, void (RenderStyle::*setterFunction)(PassRefPtrCSSWrapShape), CSSWrapShape* (*initialFunction)()
+class ApplyPropertyWrapShape {
+public:
+static void setValue(RenderStyle* style, PassRefPtrCSSWrapShape value) { (style-*setterFunction)(value); }
+static void applyValue(StyleResolver* styleResolver, CSSValue* value)
+{
+if (value-isPrimitiveValue()) {
+CSSPrimitiveValue* primitiveValue = static_castCSSPrimitiveValue*(value);
+if (primitiveValue-getIdent() == CSSValueAuto)
+setValue(styleResolver-style(), 0);
+else if (primitiveValue-isShape())
+setValue(styleResolver-style(), primitiveValue-getShapeValue());
+}
+}
+static PropertyHandler createHandler()
+{
+PropertyHandler handler = ApplyPropertyDefaultBaseCSSWrapShape*, getterFunction, PassRefPtrCSSWrapShape, setterFunction, CSSWrapShape*, initialFunction::createHandler();
+return PropertyHandler(handler.inheritFunction(), handler.initialFunction(), applyValue);
+}
+};
+#endif
+
 #if ENABLE(CSS_IMAGE_RESOLUTION)
 class ApplyPropertyImageResolution {
 public:
@@ -2094,6 +2117,8 @@
 setPropertyHandler(CSSPropertyWebkitWrapMargin, ApplyPropertyLengthRenderStyle::wrapMargin, RenderStyle::setWrapMargin, RenderStyle::initialWrapMargin::createHandler());
 setPropertyHandler(CSSPropertyWebkitWrapPadding, ApplyPropertyLengthRenderStyle::wrapPadding, RenderStyle::setWrapPadding, RenderStyle::initialWrapPadding::createHandler());
 setPropertyHandler(CSSPropertyWebkitWrapThrough, ApplyPropertyDefaultWrapThrough, RenderStyle::wrapThrough, WrapThrough, RenderStyle::setWrapThrough, WrapThrough, RenderStyle::initialWrapThrough::createHandler());
+setPropertyHandler(CSSPropertyWebkitShapeInside, ApplyPropertyWrapShapeRenderStyle::wrapShapeInside, RenderStyle::setWrapShapeInside, RenderStyle::initialWrapShapeInside::createHandler());
+setPropertyHandler(CSSPropertyWebkitShapeOutside, ApplyPropertyWrapShapeRenderStyle::wrapShapeOutside, RenderStyle::setWrapShapeOutside, RenderStyle::initialWrapShapeOutside::createHandler());
 #endif
 setPropertyHandler(CSSPropertyWhiteSpace, ApplyPropertyDefaultEWhiteSpace, RenderStyle::whiteSpace, EWhiteSpace, RenderStyle::setWhiteSpace, EWhiteSpace, 

[webkit-changes] [121350] trunk/LayoutTests

[shinyak]

Title: [121350] trunk/LayoutTests








Revision 121350
Author shin...@chromium.org
Date 2012-06-27 10:48:23 -0700 (Wed, 27 Jun 2012)


Log Message
[Shadow] Triggers assertion in VisibleSelection::adjustSelectionToAvoidCrossingBoundaries()
https://bugs.webkit.org/show_bug.cgi?id=89918

Reviewed by Ryosuke Niwa.

This patch adds a testcase of selection from Shadow DOM to some elements outside of shadow host.
r121303, which is a patch for another issue, fixed this issue.

* editing/shadow/breaking-editing-boundaries-2-expected.txt: Added.
* editing/shadow/breaking-editing-boundaries-2.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/editing/shadow/breaking-editing-boundaries-2-expected.txt
trunk/LayoutTests/editing/shadow/breaking-editing-boundaries-2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121349 => 121350)

--- trunk/LayoutTests/ChangeLog	2012-06-27 17:45:24 UTC (rev 121349)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 17:48:23 UTC (rev 121350)
@@ -1,3 +1,16 @@
+2012-06-27  Shinya Kawanaka  shin...@chromium.org
+
+[Shadow] Triggers assertion in VisibleSelection::adjustSelectionToAvoidCrossingBoundaries()
+https://bugs.webkit.org/show_bug.cgi?id=89918
+
+Reviewed by Ryosuke Niwa.
+
+This patch adds a testcase of selection from Shadow DOM to some elements outside of shadow host.
+r121303, which is a patch for another issue, fixed this issue.
+
+* editing/shadow/breaking-editing-boundaries-2-expected.txt: Added.
+* editing/shadow/breaking-editing-boundaries-2.html: Added.
+
 2012-06-27  Alexandru Chiculita  ach...@adobe.com
 
 Blur filter causes issues when scrolling


Added: trunk/LayoutTests/editing/shadow/breaking-editing-boundaries-2-expected.txt (0 => 121350)

--- trunk/LayoutTests/editing/shadow/breaking-editing-boundaries-2-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/shadow/breaking-editing-boundaries-2-expected.txt	2012-06-27 17:48:23 UTC (rev 121350)
@@ -0,0 +1,5 @@
+When selecting from a child of ShadowRoot to an element outside of shadow host, a crash should not be caused.
+
+To test manually, select from 'before shadow' to 'after host'.
+
+PASS


Added: trunk/LayoutTests/editing/shadow/breaking-editing-boundaries-2.html (0 => 121350)

--- trunk/LayoutTests/editing/shadow/breaking-editing-boundaries-2.html	(rev 0)
+++ trunk/LayoutTests/editing/shadow/breaking-editing-boundaries-2.html	2012-06-27 17:48:23 UTC (rev 121350)
@@ -0,0 +1,41 @@
+!DOCTYPE html
+html
+body
+script src=""
+
+pWhen selecting from a child of ShadowRoot to an element outside of shadow host, a crash should not be caused./p
+pTo test manually, select from 'before shadow' to 'after host'./p
+
+div id=container contenteditable
+divpbefore host/p/div
+div id=hosthost/div 
+div id=destinationafter host/div
+/div
+
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var shadowRoot = new WebKitShadowRoot(host);
+var div = document.createElement('div');
+div.setAttribute('contenteditable', 'true');
+shadowRoot.appendChild(div);
+div.innerHTML = div id='source'before shadow/divshadow/shadowdivafter shadow/div;
+
+var nestedShadowRoot = new WebKitShadowRoot(div);
+nestedShadowRoot.innerHTML = div contenteditablebefore nestedshadow/shadowafter nested/div;
+
+var source = shadowRoot.getElementById('source');
+var destination = document.getElementById('destination');
+
+if (window.eventSender) {
+eventSender.mouseMoveTo(source.offsetLeft + 20, source.offsetTop + source.offsetHeight / 2);
+eventSender.mouseDown();
+eventSender.mouseMoveTo(destination.offsetLeft + 20, destination.offsetTop + destination.offsetHeight / 2);
+eventSender.mouseUp();
+
+container.innerHTML = PASS;
+}
+/script
+/body
+/html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121351] trunk

[mikelawther]

Title: [121351] trunk








Revision 121351
Author mikelawt...@chromium.org
Date 2012-06-27 11:23:09 -0700 (Wed, 27 Jun 2012)


Log Message
CSS3 calc: blending involving expressions
https://bugs.webkit.org/show_bug.cgi?id=86160

Reviewed by Tony Chang.

Source/WebCore:

If either endpoint of a blend involves a calc _expression_, we create a new
_expression_ to perform the blend calculation.

Test: css3/calc/transitions.html
  css3/calc/transitions-dependent.html

* platform/Length.cpp:
(WebCore):
(WebCore::Length::blendCalculation):
* platform/Length.h:
(WebCore::Length::blend):
(Length):

LayoutTests:

Removed existing test as it was folded into transitions.html.

* css3/calc/transition-start-end-with-calc-expected.txt: Removed.
* css3/calc/transition-start-end-with-calc.html: Removed.
* css3/calc/transitions-dependent-expected.txt: Added.
* css3/calc/transitions-dependent.html: Added.
* css3/calc/transitions-expected.txt: Added.
* css3/calc/transitions.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Length.cpp
trunk/Source/WebCore/platform/Length.h


Added Paths

trunk/LayoutTests/css3/calc/transitions-dependent-expected.txt
trunk/LayoutTests/css3/calc/transitions-dependent.html
trunk/LayoutTests/css3/calc/transitions-expected.txt
trunk/LayoutTests/css3/calc/transitions.html


Removed Paths

trunk/LayoutTests/css3/calc/transition-start-end-with-calc-expected.txt
trunk/LayoutTests/css3/calc/transition-start-end-with-calc.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121350 => 121351)

--- trunk/LayoutTests/ChangeLog	2012-06-27 17:48:23 UTC (rev 121350)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 18:23:09 UTC (rev 121351)
@@ -1,3 +1,19 @@
+2012-06-27  Mike Lawther  mikelawt...@chromium.org
+
+CSS3 calc: blending involving expressions
+https://bugs.webkit.org/show_bug.cgi?id=86160
+
+Reviewed by Tony Chang.
+
+Removed existing test as it was folded into transitions.html.
+
+* css3/calc/transition-start-end-with-calc-expected.txt: Removed.
+* css3/calc/transition-start-end-with-calc.html: Removed.
+* css3/calc/transitions-dependent-expected.txt: Added.
+* css3/calc/transitions-dependent.html: Added.
+* css3/calc/transitions-expected.txt: Added.
+* css3/calc/transitions.html: Added.
+
 2012-06-27  Shinya Kawanaka  shin...@chromium.org
 
 [Shadow] Triggers assertion in VisibleSelection::adjustSelectionToAvoidCrossingBoundaries()


Deleted: trunk/LayoutTests/css3/calc/transition-start-end-with-calc-expected.txt (121350 => 121351)

--- trunk/LayoutTests/css3/calc/transition-start-end-with-calc-expected.txt	2012-06-27 17:48:23 UTC (rev 121350)
+++ trunk/LayoutTests/css3/calc/transition-start-end-with-calc-expected.txt	2012-06-27 18:23:09 UTC (rev 121351)
@@ -1,4 +0,0 @@
-This tests that transitions beginning and ending with calc() expressions move to the final state.
-PASS - width property for rect element at 0.0s was: 51
-PASS - width property for rect element at 1s saw something close to: 400
-


Deleted: trunk/LayoutTests/css3/calc/transition-start-end-with-calc.html (121350 => 121351)

--- trunk/LayoutTests/css3/calc/transition-start-end-with-calc.html	2012-06-27 17:48:23 UTC (rev 121350)
+++ trunk/LayoutTests/css3/calc/transition-start-end-with-calc.html	2012-06-27 18:23:09 UTC (rev 121351)
@@ -1,45 +0,0 @@
-!DOCTYPE html
-style
-#rect {
-background-color: green;
-height: 100px;
--webkit-transition: all 1s;
--moz-transition: all 1s;
-width: -webkit-calc(10% + 1px);
-width: -moz-calc(10% + 1px);
-}
-#rect.go {
-width: -webkit-calc(100% - 100px);
-width: -moz-calc(100% - 100px);
-}
-/style
-
-This tests that transitions beginning and ending with calc() expressions move to the final state.
-div style=width:500px; border: 1px solid black;
-div id=rect/div
-/div
-div id=result/div
-
-script src=""
-script
-const expectedValues = [
-  // [time, element-id, property, expected-value, tolerance]
-  [1.0, 'rect', 'width', 400, 0],
-];
-
-function setupTest()
-{
-var expectedStartWidth = 51; // (10% + 1px) where 100% = 500px
-var rect = document.getElementById(rect);
-var width = rect.offsetWidth;
-if (width == expectedStartWidth)
-rect.innerHTML += 'PASS - width property for rect element at 0.0s was: ' + width;
-else
-rect.innerHTML += 'FAIL  - width property for rect element at 0.0s expected: ' + expectedStartWidth + 'but saw: ' + width;
-
-rect.className = go;
-}
-
-runTransitionTest(expectedValues, setupTest, true, false /* pixel test */);
-
-/script


Added: trunk/LayoutTests/css3/calc/transitions-dependent-expected.txt (0 => 121351)

--- trunk/LayoutTests/css3/calc/transitions-dependent-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/calc/transitions-dependent-expected.txt	2012-06-27 18:23:09 UTC (rev 121351)
@@ -0,0 +1,12 @@
+This tests 

[webkit-changes] [121352] trunk

[commit-queue]

Title: [121352] trunk








Revision 121352
Author commit-qu...@webkit.org
Date 2012-06-27 11:25:16 -0700 (Wed, 27 Jun 2012)


Log Message
[CSSRegions]Change display values that allow regions
https://bugs.webkit.org/show_bug.cgi?id=89759

Patch by Andrei Onea o...@adobe.com on 2012-06-27
Reviewed by Tony Chang.

Source/WebCore:

Allow only elements with display values of block, inline-block,
table-cell, table-caption and list-item to become regions, as per
CSSRegions spec: http://dev.w3.org/csswg/css3-regions .
Also added test for checking whether regions are destroyed and/or created
when changing display value.

Test: fast/regions/region-element-display-change.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/style/RenderStyle.h:

LayoutTests:

Added checks for more display values, and modified results to reflect proper values that can become
regions. Also created new test for dynamically changing display values, making sure regions are
created or destroyed correctly.
* fast/regions/region-element-display-change-expected.txt: Added.
* fast/regions/region-element-display-change.html: Added.
* fast/regions/region-element-display-restriction-expected.txt:
* fast/regions/script-tests/region-element-display-change.js: Added.
(testElement):
* fast/regions/script-tests/region-element-display-restriction.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/regions/region-element-display-restriction-expected.txt
trunk/LayoutTests/fast/regions/script-tests/region-element-display-restriction.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h


Added Paths

trunk/LayoutTests/fast/regions/region-element-display-change-expected.txt
trunk/LayoutTests/fast/regions/region-element-display-change.html
trunk/LayoutTests/fast/regions/script-tests/region-element-display-change.js




Diff

Modified: trunk/LayoutTests/ChangeLog (121351 => 121352)

--- trunk/LayoutTests/ChangeLog	2012-06-27 18:23:09 UTC (rev 121351)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 18:25:16 UTC (rev 121352)
@@ -1,3 +1,20 @@
+2012-06-27  Andrei Onea  o...@adobe.com
+
+[CSSRegions]Change display values that allow regions
+https://bugs.webkit.org/show_bug.cgi?id=89759
+
+Reviewed by Tony Chang.
+
+Added checks for more display values, and modified results to reflect proper values that can become
+regions. Also created new test for dynamically changing display values, making sure regions are
+created or destroyed correctly.
+* fast/regions/region-element-display-change-expected.txt: Added.
+* fast/regions/region-element-display-change.html: Added.
+* fast/regions/region-element-display-restriction-expected.txt:
+* fast/regions/script-tests/region-element-display-change.js: Added.
+(testElement):
+* fast/regions/script-tests/region-element-display-restriction.js:
+
 2012-06-27  Mike Lawther  mikelawt...@chromium.org
 
 CSS3 calc: blending involving expressions


Added: trunk/LayoutTests/fast/regions/region-element-display-change-expected.txt (0 => 121352)

--- trunk/LayoutTests/fast/regions/region-element-display-change-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/regions/region-element-display-change-expected.txt	2012-06-27 18:25:16 UTC (rev 121352)
@@ -0,0 +1,24 @@
+Test that RenderObject is recreated correctly after changing display type.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS testElement(element, none) is false
+PASS testElement(element, block) is true
+PASS testElement(element, inline-block) is true
+PASS testElement(element, run-in) is false
+PASS testElement(element, compact) is false
+PASS testElement(element, inline) is false
+PASS testElement(element, table) is false
+PASS testElement(element, inline-table) is false
+PASS testElement(element, table-cell) is true
+PASS testElement(element, table-caption) is true
+PASS testElement(element, list-item) is true
+PASS testElement(element, -webkit-box) is false
+PASS testElement(element, -webkit-inline-box) is false
+PASS testElement(element, -webkit-flex) is false
+PASS testElement(element, -webkit-inline-flex) is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/regions/region-element-display-change.html (0 => 121352)

--- trunk/LayoutTests/fast/regions/region-element-display-change.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/region-element-display-change.html	2012-06-27 18:25:16 UTC (rev 121352)
@@ -0,0 +1,10 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+script src=""
+script src=""
+/body
+/html


Modified: trunk/LayoutTests/fast/regions/region-element-display-restriction-expected.txt (121351 => 121352)

--- 

[webkit-changes] [121353] trunk/LayoutTests

[ojan]

Title: [121353] trunk/LayoutTests








Revision 121353
Author o...@chromium.org
Date 2012-06-27 11:28:20 -0700 (Wed, 27 Jun 2012)


Log Message
Fix some styling errors in the TestExpecations files.
There were automatically fixed when trying to make
webkit-patch rebaseline-expectations work for non-Chromium ports.

* platform/efl/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (121352 => 121353)

--- trunk/LayoutTests/ChangeLog	2012-06-27 18:25:16 UTC (rev 121352)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 18:28:20 UTC (rev 121353)
@@ -1,3 +1,13 @@
+2012-06-27  Ojan Vafai  o...@chromium.org
+
+Fix some styling errors in the TestExpecations files.
+There were automatically fixed when trying to make
+webkit-patch rebaseline-expectations work for non-Chromium ports.
+
+* platform/efl/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/qt/TestExpectations:
+
 2012-06-27  Andrei Onea  o...@adobe.com
 
 [CSSRegions]Change display values that allow regions


Modified: trunk/LayoutTests/platform/efl/TestExpectations (121352 => 121353)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-06-27 18:25:16 UTC (rev 121352)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-06-27 18:28:20 UTC (rev 121353)
@@ -515,7 +515,7 @@
 BUGWK85492 : css3/zoom-coords.xhtml = TEXT
 
 // Occasionally missing chunks of output
-BUGWK66873:  http/tests/loading/redirect-methods.html = TEXT
+BUGWK66873 : http/tests/loading/redirect-methods.html = TEXT
 
 // IETC flexbox failures
 BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE


Modified: trunk/LayoutTests/platform/mac/TestExpectations (121352 => 121353)

--- trunk/LayoutTests/platform/mac/TestExpectations	2012-06-27 18:25:16 UTC (rev 121352)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2012-06-27 18:28:20 UTC (rev 121353)
@@ -165,13 +165,13 @@
 
 // Need rebaselining. Only TEXT is suppressed because that is all the buildbots check, however
 // images need to be rebaselined too.
-BUGWK69210 SKIP: fast/encoding/utf-16-big-endian.html = TEXT
-BUGWK69210: fast/encoding/utf-16-little-endian.html = TEXT
-BUGWK69210: fast/inline/continuation-outlines-with-layers-2.html = TEXT
+BUGWK69210 SKIP : fast/encoding/utf-16-big-endian.html = TEXT
+BUGWK69210 : fast/encoding/utf-16-little-endian.html = TEXT
+BUGWK69210 : fast/inline/continuation-outlines-with-layers-2.html = TEXT
 // https://bugs.webkit.org/show_bug.cgi?id=81276
 // Allowed to regress to fix a crash.
-BUGWK69210 SKIP: fast/inline/continuation-outlines-with-layers.html = TEXT
-BUGWK69210: fast/repaint/transform-absolute-in-positioned-container.html = TEXT
+BUGWK69210 SKIP : fast/inline/continuation-outlines-with-layers.html = TEXT
+BUGWK69210 : fast/repaint/transform-absolute-in-positioned-container.html = TEXT
 
 // Tiled-layer compositing tests are flakey.
 BUGWK82546 : compositing/tiling/crash-reparent-tiled-layer.html = PASS TEXT


Modified: trunk/LayoutTests/platform/qt/TestExpectations (121352 => 121353)

--- trunk/LayoutTests/platform/qt/TestExpectations	2012-06-27 18:25:16 UTC (rev 121352)
+++ trunk/LayoutTests/platform/qt/TestExpectations	2012-06-27 18:28:20 UTC (rev 121353)
@@ -2,15 +2,15 @@
 //
 // See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
 
-BUGWK64526 DEBUG: svg/animations/svgtransform-animation-1.html = CRASH PASS
+BUGWK64526 DEBUG : svg/animations/svgtransform-animation-1.html = CRASH PASS
 
 // Slow tests
 // FIXME: File bugs.
-BUG_QT_SLOW SLOW DEBUG: editing/selection/empty-cell-right-click.html = PASS
-BUG_QT_SLOW SLOW DEBUG: editing/selection/dump-as-markup.html = PASS
-BUG_QT_SLOW DEBUG: fast/js/array-sort-modifying-tostring.html = TIMEOUT PASS
-BUG_QT_SLOW SLOW DEBUG: fast/overflow/lots-of-sibling-inline-boxes.html = PASS
-BUG_QT_SLOW SLOW DEBUG: fast/js/dfg-inline-function-dot-caller.html = PASS
+BUG_QT_SLOW SLOW DEBUG : editing/selection/empty-cell-right-click.html = PASS
+BUG_QT_SLOW SLOW DEBUG : editing/selection/dump-as-markup.html = PASS
+BUG_QT_SLOW DEBUG : fast/js/array-sort-modifying-tostring.html = TIMEOUT PASS
+BUG_QT_SLOW SLOW DEBUG : fast/overflow/lots-of-sibling-inline-boxes.html = PASS
+BUG_QT_SLOW SLOW DEBUG : fast/js/dfg-inline-function-dot-caller.html = PASS
 
 BUGWK62662 DEBUG : inspector/cookie-parser.html = CRASH PASS
 
@@ -86,7 +86,7 @@
 BUGWK86441 : fast/multicol/shadow-breaking.html = IMAGE
 
 // Requires rebaseline after https://bugs.webkit.org/show_bug.cgi?id=85405
-BUGWK85405 SKIP: tables/mozilla/bugs/bug10296-1.html = TEXT
+BUGWK85405 SKIP : tables/mozilla/bugs/bug10296-1.html = TEXT
 
 // Paletted PNG with ICC color profiles not working.
 BUGWK86722 SKIP : 

[webkit-changes] [121354] trunk/Source/WebKit2

[beidson]

Title: [121354] trunk/Source/WebKit2








Revision 121354
Author beid...@apple.com
Date 2012-06-27 11:28:52 -0700 (Wed, 27 Jun 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=87513
WebBackForwardList needs an overhaul to consistently and clearly handle error conditions.

Reviewed by Darin Adler.

- We think a null entry might somehow be getting in the list so we now try to prevent that.
- We think a null entry might somehow be in the list so we now null check when indexing into m_entries.
- A lot of index math - especially tracking no current index - was implicit or wrong.
- Operating on a WebBackForwardList whose page has been closed is now an explicit no-op.
- The session state data reading and writing code was fragile and needed an overhaul.
- This includes adding a new V1 format of the session data that is easier to validate when reading back in.

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::~WebBackForwardList):
(WebKit::WebBackForwardList::pageClosed):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

* UIProcess/WebBackForwardList.h:
(WebBackForwardList):

* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::createEmptySessionHistoryDictionary):
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromV0CFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromV1CFDictionaryRepresentation):
(WebKit::extractBackForwardListEntriesFromArray):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp
trunk/Source/WebKit2/UIProcess/WebBackForwardList.h
trunk/Source/WebKit2/UIProcess/cf/WebBackForwardListCF.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (121353 => 121354)

--- trunk/Source/WebKit2/ChangeLog	2012-06-27 18:28:20 UTC (rev 121353)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-27 18:28:52 UTC (rev 121354)
@@ -1,3 +1,39 @@
+2012-06-27  Brady Eidson  beid...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=87513
+WebBackForwardList needs an overhaul to consistently and clearly handle error conditions.
+
+Reviewed by Darin Adler.
+
+- We think a null entry might somehow be getting in the list so we now try to prevent that.
+- We think a null entry might somehow be in the list so we now null check when indexing into m_entries.
+- A lot of index math - especially tracking no current index - was implicit or wrong.
+- Operating on a WebBackForwardList whose page has been closed is now an explicit no-op.
+- The session state data reading and writing code was fragile and needed an overhaul.
+- This includes adding a new V1 format of the session data that is easier to validate when reading back in.
+
+* UIProcess/WebBackForwardList.cpp:
+(WebKit::WebBackForwardList::~WebBackForwardList):
+(WebKit::WebBackForwardList::pageClosed):
+(WebKit::WebBackForwardList::addItem):
+(WebKit::WebBackForwardList::goToItem):
+(WebKit::WebBackForwardList::backListCount):
+(WebKit::WebBackForwardList::forwardListCount):
+(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
+(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
+(WebKit::WebBackForwardList::clear):
+
+* UIProcess/WebBackForwardList.h:
+(WebBackForwardList):
+
+* UIProcess/cf/WebBackForwardListCF.cpp:
+(WebKit::createEmptySessionHistoryDictionary):
+(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
+(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):
+(WebKit::WebBackForwardList::restoreFromV0CFDictionaryRepresentation):
+(WebKit::WebBackForwardList::restoreFromV1CFDictionaryRepresentation):
+(WebKit::extractBackForwardListEntriesFromArray):
+
 2012-06-27  Zan Dobersek  zandober...@gmail.com
 
 [Gtk] Add support for the Gamepad API


Modified: trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp (121353 => 121354)

--- trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp	2012-06-27 18:28:20 UTC (rev 121353)
+++ trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp	2012-06-27 18:28:52 UTC (rev 121354)
@@ -43,17 +43,28 @@
 
 WebBackForwardList::~WebBackForwardList()
 {
+// A WebBackForwardList should never be destroyed unless it's associated page has been closed or is invalid.
+ASSERT((!m_page  !m_hasCurrentIndex) || !m_page-isValid());
 }
 
 void WebBackForwardList::pageClosed()
 {
+// We should have always started out with an m_page and we should never close the 

[webkit-changes] [121355] trunk/Source/WebKit/blackberry

[zhajiang]

Title: [121355] trunk/Source/WebKit/blackberry








Revision 121355
Author zhaji...@rim.com
Date 2012-06-27 11:44:52 -0700 (Wed, 27 Jun 2012)


Log Message
Scale was incorrect when reloading a simple web page after initial load https://bugs.webkit.org/show_bug.cgi?id=9

Reviewed by Antonio Gomes.
Patch by Jacky Jiang zhaji...@rim.com

PR: 164442
For FrameLoadTypeStandard load, the layout timer can be fired which can
call dispatchDidFirstVisuallyNonEmptyLayout() after the load Finished
state, in which case the web page will have no chance to zoom to
initial scale. We should give it a chance as well as FrameLoadTypeSame
load.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (121354 => 121355)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-27 18:28:52 UTC (rev 121354)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-27 18:44:52 UTC (rev 121355)
@@ -1638,12 +1638,13 @@
 
 bool WebPagePrivate::shouldZoomToInitialScaleOnLoad() const
 {
-// For FrameLoadTypeSame load, the first layout timer can be fired after the load Finished state. We should
-// zoom to initial scale for this case as well, otherwise the scale of the web page can be incorrect.
+// For FrameLoadTypeSame or FrameLoadTypeStandard load, the layout timer can be fired which can call dispatchDidFirstVisuallyNonEmptyLayout()
+// after the load Finished state, in which case the web page will have no chance to zoom to initial scale. So we should give it a chance,
+// otherwise the scale of the web page can be incorrect.
 FrameLoadType frameLoadType = FrameLoadTypeStandard;
 if (m_mainFrame  m_mainFrame-loader())
 frameLoadType = m_mainFrame-loader()-loadType();
-if (m_loadState == Committed || (m_loadState == Finished  frameLoadType == FrameLoadTypeSame))
+if (m_loadState == Committed || (m_loadState == Finished  (frameLoadType == FrameLoadTypeSame || frameLoadType == FrameLoadTypeStandard)))
 return true;
 return false;
 }


Modified: trunk/Source/WebKit/blackberry/ChangeLog (121354 => 121355)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-06-27 18:28:52 UTC (rev 121354)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-06-27 18:44:52 UTC (rev 121355)
@@ -1,3 +1,20 @@
+2012-06-27  Jacky Jiang  zhaji...@rim.com
+
+[BlackBerry] Scale was incorrect when reloading a simple web page after initial load
+https://bugs.webkit.org/show_bug.cgi?id=9
+
+Reviewed by Antonio Gomes.
+
+PR: 164442
+For FrameLoadTypeStandard load, the layout timer can be fired which can
+call dispatchDidFirstVisuallyNonEmptyLayout() after the load Finished
+state, in which case the web page will have no chance to zoom to
+initial scale. We should give it a chance as well as FrameLoadTypeSame
+load.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
+
 2012-06-26  Mike Fenton  mifen...@rim.com
 
 [BlackBerry] Add WebPage interface for Async spell check.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121356] trunk/LayoutTests

[hclam]

Title: [121356] trunk/LayoutTests








Revision 121356
Author hc...@chromium.org
Date 2012-06-27 11:45:01 -0700 (Wed, 27 Jun 2012)


Log Message
[Chromium] Rebaseline svg/text/scaled-font.svg and svg/text/scaling-font-with-geometric-precision.html caused by r121343.

Not reviewed. Build fix.

* platform/chromium-mac-snowleopard/svg/text/scaling-font-with-geometric-precision-expected.png:
* platform/chromium-mac/svg/text/scaled-font-expected.png:
* platform/chromium-mac/svg/text/scaling-font-with-geometric-precision-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/svg/text/scaled-font-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/text/scaling-font-with-geometric-precision-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/text/scaling-font-with-geometric-precision-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (121355 => 121356)

--- trunk/LayoutTests/ChangeLog	2012-06-27 18:44:52 UTC (rev 121355)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 18:45:01 UTC (rev 121356)
@@ -1,3 +1,13 @@
+2012-06-27  Alpha Lam  hc...@chromium.org
+
+[Chromium] Rebaseline svg/text/scaled-font.svg and svg/text/scaling-font-with-geometric-precision.html caused by r121343.
+
+Not reviewed. Build fix.
+
+* platform/chromium-mac-snowleopard/svg/text/scaling-font-with-geometric-precision-expected.png:
+* platform/chromium-mac/svg/text/scaled-font-expected.png:
+* platform/chromium-mac/svg/text/scaling-font-with-geometric-precision-expected.png:
+
 2012-06-27  Ojan Vafai  o...@chromium.org
 
 Fix some styling errors in the TestExpecations files.


Modified: trunk/LayoutTests/platform/chromium-mac/svg/text/scaled-font-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/svg/text/scaling-font-with-geometric-precision-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/text/scaling-font-with-geometric-precision-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121357] trunk

[rniwa]

Title: [121357] trunk








Revision 121357
Author rn...@webkit.org
Date 2012-06-27 12:42:22 -0700 (Wed, 27 Jun 2012)


Log Message
REGRESSION (Safari 5?): Pasting a line into textarea inserts two newlines
https://bugs.webkit.org/show_bug.cgi?id=49288

Reviewed by Tony Chang.

Source/WebCore: 

The bug was caused by positionAvoidingPrecedingNodes getting out of a block when the insertion point is at a line break.
It caused the subsequent code to be misinformed of the insertion position and ended up not pruning the extra line break.

Fixed the bug by checking this special case and bailing out so that we don't crawl out of the enclosing block.
It's similar to checks several lines below it.

Test: editing/pasteboard/copy-paste-pre-line-content.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::positionAvoidingPrecedingNodes):

LayoutTests: 

Add a test regerssion test for copying  pasting a line in pre into textarea twice.

* editing/pasteboard/copy-paste-pre-line-content-expected.txt: Added.
* editing/pasteboard/copy-paste-pre-line-content.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp


Added Paths

trunk/LayoutTests/editing/pasteboard/copy-paste-pre-line-content-expected.txt
trunk/LayoutTests/editing/pasteboard/copy-paste-pre-line-content.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121356 => 121357)

--- trunk/LayoutTests/ChangeLog	2012-06-27 18:45:01 UTC (rev 121356)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 19:42:22 UTC (rev 121357)
@@ -1,3 +1,15 @@
+2012-06-27  Ryosuke Niwa  rn...@webkit.org
+
+REGRESSION (Safari 5?): Pasting a line into textarea inserts two newlines
+https://bugs.webkit.org/show_bug.cgi?id=49288
+
+Reviewed by Tony Chang.
+
+Add a test regerssion test for copying  pasting a line in pre into textarea twice.
+
+* editing/pasteboard/copy-paste-pre-line-content-expected.txt: Added.
+* editing/pasteboard/copy-paste-pre-line-content.html: Added.
+
 2012-06-27  Alpha Lam  hc...@chromium.org
 
 [Chromium] Rebaseline svg/text/scaled-font.svg and svg/text/scaling-font-with-geometric-precision.html caused by r121343.


Added: trunk/LayoutTests/editing/pasteboard/copy-paste-pre-line-content-expected.txt (0 => 121357)

--- trunk/LayoutTests/editing/pasteboard/copy-paste-pre-line-content-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-pre-line-content-expected.txt	2012-06-27 19:42:22 UTC (rev 121357)
@@ -0,0 +1,8 @@
+This tests pasting two lines of text copied from pre content. To manually test, copy the selected text (including the new line) and paste it into textarea twice. There should be no blank line between two pasted lines.
+
+A line of text
+some other text
+
+A line of text
+A line of text
+


Added: trunk/LayoutTests/editing/pasteboard/copy-paste-pre-line-content.html (0 => 121357)

--- trunk/LayoutTests/editing/pasteboard/copy-paste-pre-line-content.html	(rev 0)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-pre-line-content.html	2012-06-27 19:42:22 UTC (rev 121357)
@@ -0,0 +1,34 @@
+!DOCTYPE html
+html
+body
+pThis tests pasting two lines of text copied from pre content.
+To manually test, copy the selected text (including the new line) and paste it into textarea twice.
+There should be no blank line between two pasted lines./p
+pre _oncopy_=setTimeout(function () { textarea.focus(); }, 0);A line of text
+some other text
+/pre
+
+textarea cols=10 rows=5 _oninput_=document.getElementById('console').textContent = textarea.value;/textarea
+pre id=console/pre
+script
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var textarea = document.querySelector('textarea');
+
+getSelection().collapse(document.querySelector('pre'), 0);
+getSelection().modify('extend', 'forward', 'line');
+
+if (document.queryCommandSupported('paste')) {
+document.execCommand('copy', false, null);
+
+textarea.focus();
+document.execCommand('paste', false, null);
+document.execCommand('paste', false, null);
+}
+
+
+/script
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (121356 => 121357)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 18:45:01 UTC (rev 121356)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 19:42:22 UTC (rev 121357)
@@ -1,3 +1,21 @@
+2012-06-27  Ryosuke Niwa  rn...@webkit.org
+
+REGRESSION (Safari 5?): Pasting a line into textarea inserts two newlines
+https://bugs.webkit.org/show_bug.cgi?id=49288
+
+Reviewed by Tony Chang.
+
+The bug was caused by positionAvoidingPrecedingNodes getting out of a block when the insertion point is at a line break.
+It caused the subsequent code to be misinformed of the insertion position and ended up not pruning the extra line break.
+
+Fixed the bug by checking this special case and bailing out so that we don't crawl out of the enclosing block.

[webkit-changes] [121358] trunk/Source/WebCore

[rniwa]

Title: [121358] trunk/Source/WebCore








Revision 121358
Author rn...@webkit.org
Date 2012-06-27 12:50:52 -0700 (Wed, 27 Jun 2012)


Log Message
Let Xcode have its own way.

* WebCore.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (121357 => 121358)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 19:42:22 UTC (rev 121357)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 19:50:52 UTC (rev 121358)
@@ -1,5 +1,11 @@
 2012-06-27  Ryosuke Niwa  rn...@webkit.org
 
+Let Xcode have its own way.
+
+* WebCore.xcodeproj/project.pbxproj:
+
+2012-06-27  Ryosuke Niwa  rn...@webkit.org
+
 REGRESSION (Safari 5?): Pasting a line into textarea inserts two newlines
 https://bugs.webkit.org/show_bug.cgi?id=49288
 


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (121357 => 121358)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2012-06-27 19:42:22 UTC (rev 121357)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2012-06-27 19:50:52 UTC (rev 121358)
@@ -1428,10 +1428,10 @@
 		4F1534DE11B532EC0021FD86 /* EditingBehavior.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F1534DD11B532EC0021FD86 /* EditingBehavior.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		4F1534E011B533020021FD86 /* EditingBehaviorTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F1534DF11B533020021FD86 /* EditingBehaviorTypes.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		4F2D205412EAE7B3005C2874 /* InspectorAgent.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F2D205212EAE7B3005C2874 /* InspectorAgent.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		4F32BB1B14FA85E800F6C1A3 /* MemoryInstrumentation.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F32BB1A14FA85AA00F6C1A3 /* MemoryInstrumentation.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		4F2D205512EAE7B3005C2874 /* InspectorAgent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4F2D205312EAE7B3005C2874 /* InspectorAgent.cpp */; };
 		4F3289B511A42AAB005ABE7E /* InspectorValues.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4F3289B311A42AAB005ABE7E /* InspectorValues.cpp */; };
 		4F3289B611A42AAB005ABE7E /* InspectorValues.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F3289B411A42AAB005ABE7E /* InspectorValues.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		4F32BB1B14FA85E800F6C1A3 /* MemoryInstrumentation.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F32BB1A14FA85AA00F6C1A3 /* MemoryInstrumentation.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		4F4F5FFB11CBD2E100A186BF /* InspectorFrontend.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4F4F5FFA11CBD2D200A186BF /* InspectorFrontend.cpp */; };
 		4F6FDD641341DEDD001F8EE3 /* InspectorPageAgent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4F6FDD621341DEDD001F8EE3 /* InspectorPageAgent.cpp */; };
 		4F6FDD651341DEDD001F8EE3 /* InspectorPageAgent.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F6FDD631341DEDD001F8EE3 /* InspectorPageAgent.h */; };
@@ -8504,10 +8504,10 @@
 		4F1534DD11B532EC0021FD86 /* EditingBehavior.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EditingBehavior.h; sourceTree = group; };
 		4F1534DF11B533020021FD86 /* EditingBehaviorTypes.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EditingBehaviorTypes.h; sourceTree = group; };
 		4F2D205212EAE7B3005C2874 /* InspectorAgent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorAgent.h; sourceTree = group; };
-		4F32BB1A14FA85AA00F6C1A3 /* MemoryInstrumentation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MemoryInstrumentation.h; sourceTree = group; };
 		4F2D205312EAE7B3005C2874 /* InspectorAgent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorAgent.cpp; sourceTree = group; };
 		4F3289B311A42AAB005ABE7E /* InspectorValues.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorValues.cpp; sourceTree = group; };
 		4F3289B411A42AAB005ABE7E /* InspectorValues.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorValues.h; sourceTree = group; };
+		4F32BB1A14FA85AA00F6C1A3 /* MemoryInstrumentation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MemoryInstrumentation.h; sourceTree = group; };
 		4F4F5FFA11CBD2D200A186BF /* InspectorFrontend.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorFrontend.cpp; sourceTree = group; };
 		4F4F5FFC11CBD30100A186BF /* InspectorFrontend.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 

[webkit-changes] [121359] trunk/Source

[commit-queue]

Title: [121359] trunk/Source








Revision 121359
Author commit-qu...@webkit.org
Date 2012-06-27 12:54:48 -0700 (Wed, 27 Jun 2012)


Log Message
Web Inspector [JSC]: Implement ScriptCallStack::stackTrace
https://bugs.webkit.org/show_bug.cgi?id=40118

Patch by Anthony Scian asc...@rim.com on 2012-06-27
Reviewed by Yong Li.

Source/_javascript_Core:

Added member functions to expose function name, urlString, and line #.
Refactored toString to make use of these member functions to reduce
duplicated code for future maintenance.

Manually tested refactoring of toString by tracing thrown exceptions.

* interpreter/Interpreter.h:
(StackFrame):
(JSC::StackFrame::toString):
(JSC::StackFrame::friendlySourceURL):
(JSC::StackFrame::friendlyFunctionName):
(JSC::StackFrame::friendlyLineNumber):

Source/WebCore:

Implemented stub for createScriptCallStack to call into
Interpreter and extract the current stack frames, iterate
through the frames and create the return result required.

No new tests, manually tested thrown exception and inspector
tracebacks.

* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121358 => 121359)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-27 19:50:52 UTC (rev 121358)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-27 19:54:48 UTC (rev 121359)
@@ -1,3 +1,23 @@
+2012-06-27  Anthony Scian  asc...@rim.com
+
+Web Inspector [JSC]: Implement ScriptCallStack::stackTrace
+https://bugs.webkit.org/show_bug.cgi?id=40118
+
+Reviewed by Yong Li.
+
+Added member functions to expose function name, urlString, and line #.
+Refactored toString to make use of these member functions to reduce
+duplicated code for future maintenance.
+
+Manually tested refactoring of toString by tracing thrown exceptions.
+
+* interpreter/Interpreter.h:
+(StackFrame):
+(JSC::StackFrame::toString):
+(JSC::StackFrame::friendlySourceURL):
+(JSC::StackFrame::friendlyFunctionName):
+(JSC::StackFrame::friendlyLineNumber):
+
 2012-06-27  Oswald Buddenhagen  oswald.buddenha...@nokia.com
 
 [Qt] Remove redundant c++11 warning suppression code


Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.h (121358 => 121359)

--- trunk/Source/_javascript_Core/interpreter/Interpreter.h	2012-06-27 19:50:52 UTC (rev 121358)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.h	2012-06-27 19:54:48 UTC (rev 121359)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
+ * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -39,6 +40,7 @@
 #include RegisterFile.h
 
 #include wtf/HashMap.h
+#include wtf/text/StringBuilder.h
 
 namespace JSC {
 
@@ -80,46 +82,62 @@
 UString sourceURL;
 UString toString(CallFrame* callFrame) const
 {
-bool hasSourceURLInfo = !sourceURL.isNull()  !sourceURL.isEmpty();
-bool hasLineInfo = line  -1;
+StringBuilder traceBuild;
+String functionName = friendlyFunctionName(callFrame);
+String sourceURL = friendlySourceURL();
+traceBuild.append(functionName);
+if (!functionName.isEmpty()  !sourceURL.isEmpty())
+traceBuild.append('@');
+traceBuild.append(sourceURL);
+if (line  -1) {
+traceBuild.append(':');
+traceBuild.append(String::number(line));
+}
+return traceBuild.toString().impl();
+}
+String friendlySourceURL() const
+{
 String traceLine;
-JSObject* stackFrameCallee = callee.get();
 
 switch (codeType) {
 case StackFrameEvalCode:
-if (hasSourceURLInfo) {
-traceLine = hasLineInfo ? String::format(eval code@%s:%d, sourceURL.ascii().data(), line) 
-: String::format(eval code@%s, sourceURL.ascii().data());
-} else
-traceLine = String::format(eval code);
+case StackFrameFunctionCode:
+case StackFrameGlobalCode:
+if (!sourceURL.isEmpty())
+traceLine = sourceURL.impl();
 break;
-case StackFrameNativeCode: {
-if (callee) {
-UString functionName = getCalculatedDisplayName(callFrame, stackFrameCallee);
-traceLine = String::format(%s@[native code], functionName.ascii().data());
-} 

[webkit-changes] [121360] trunk/Source/WebKit/gtk

[commit-queue]

Title: [121360] trunk/Source/WebKit/gtk








Revision 121360
Author commit-qu...@webkit.org
Date 2012-06-27 13:22:32 -0700 (Wed, 27 Jun 2012)


Log Message
[gtk] Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118

Patch by Martin Robinson mrobin...@igalia.com on 2012-06-27
Reviewed by Gustavo Noronha Silva.

Work-around a bug in Pango by trying to detect apostrophes
that create contractions. This work-around is similar to one
found in gtkspell.

* webkit/webkitspellcheckerenchant.cpp:
(wordEndIsAContractionApostrophe): Added this helper which tries to detect
situations where a word end is both an apostrophe and followed by a alphabetic
character.
(checkSpellingOfString): When searching for the end of a word, skip over
apostrophes that appear to be part of contractions.

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (121359 => 121360)

--- trunk/Source/WebKit/gtk/ChangeLog	2012-06-27 19:54:48 UTC (rev 121359)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-06-27 20:22:32 UTC (rev 121360)
@@ -1,3 +1,21 @@
+2012-06-27  Martin Robinson  mrobin...@igalia.com
+
+[gtk] Spell checker doesn't recognize contractions (apostrophes)
+https://bugs.webkit.org/show_bug.cgi?id=86118
+
+Reviewed by Gustavo Noronha Silva.
+
+Work-around a bug in Pango by trying to detect apostrophes
+that create contractions. This work-around is similar to one
+found in gtkspell.
+
+* webkit/webkitspellcheckerenchant.cpp:
+(wordEndIsAContractionApostrophe): Added this helper which tries to detect
+situations where a word end is both an apostrophe and followed by a alphabetic
+character.
+(checkSpellingOfString): When searching for the end of a word, skip over
+apostrophes that appear to be part of contractions.
+
 2012-06-27  Zan Dobersek  zandober...@gmail.com
 
 [Gtk] Add support for the Gamepad API


Modified: trunk/Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp (121359 => 121360)

--- trunk/Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp	2012-06-27 19:54:48 UTC (rev 121359)
+++ trunk/Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp	2012-06-27 20:22:32 UTC (rev 121360)
@@ -88,6 +88,18 @@
 priv-enchantDicts = 0;
 }
 
+static bool wordEndIsAContractionApostrophe(const char* string, long offset)
+{
+if (g_utf8_get_char(g_utf8_offset_to_pointer(string, offset)) != g_utf8_get_char('))
+return false;
+
+// If this is the last character in the string, it cannot be the apostrophe part of a contraction.
+if (offset == g_utf8_strlen(string, -1))
+return false;
+
+return g_unichar_isalpha(g_utf8_get_char(g_utf8_offset_to_pointer(string, offset + 1)));
+}
+
 static void checkSpellingOfString(WebKitSpellChecker* checker, const char* string, int* misspellingLocation, int* misspellingLength)
 {
 WebKitSpellCheckerEnchantPrivate* priv = WEBKIT_SPELL_CHECKER_ENCHANT(checker)-priv;
@@ -113,7 +125,7 @@
 int end = i;
 int wordLength;
 
-while (attrs.get()[end].is_word_end  1)
+while (attrs.get()[end].is_word_end  1 || wordEndIsAContractionApostrophe(string, end))
 end++;
 
 wordLength = end - start;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121361] trunk/Source/WebCore

[commit-queue]

Title: [121361] trunk/Source/WebCore








Revision 121361
Author commit-qu...@webkit.org
Date 2012-06-27 13:31:27 -0700 (Wed, 27 Jun 2012)


Log Message
[chromium] Allow screen space rects and occluding rects to be visualized for debugging.
https://bugs.webkit.org/show_bug.cgi?id=90012

Patch by Ian Vollick voll...@chromium.org on 2012-06-27
Reviewed by Adrienne Walker.

No new tests. No new functionality.

* platform/graphics/chromium/cc/CCDebugRectHistory.cpp:
(WebCore::CCDebugRectHistory::enabled):
(WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):
(WebCore::CCDebugRectHistory::saveScreenSpaceRects):
(WebCore):
(WebCore::CCDebugRectHistory::saveOccludingRects):
* platform/graphics/chromium/cc/CCDebugRectHistory.h:
(WebCore):
(CCDebugRectHistory):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::showDebugRects):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawDebugRects):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCoreCCOcclusionTrackerBase):
(WebCore::addOcclusionBehindLayer):
(WebCoremarkOccludedBehindLayer):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::setOccludingScreenSpaceRectsContainer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDebugRectHistory.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDebugRectHistory.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (121360 => 121361)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 20:22:32 UTC (rev 121360)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 20:31:27 UTC (rev 121361)
@@ -1,3 +1,41 @@
+2012-06-27  Ian Vollick  voll...@chromium.org
+
+[chromium] Allow screen space rects and occluding rects to be visualized for debugging.
+https://bugs.webkit.org/show_bug.cgi?id=90012
+
+Reviewed by Adrienne Walker.
+
+No new tests. No new functionality.
+
+* platform/graphics/chromium/cc/CCDebugRectHistory.cpp:
+(WebCore::CCDebugRectHistory::enabled):
+(WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):
+(WebCore::CCDebugRectHistory::saveScreenSpaceRects):
+(WebCore):
+(WebCore::CCDebugRectHistory::saveOccludingRects):
+* platform/graphics/chromium/cc/CCDebugRectHistory.h:
+(WebCore):
+(CCDebugRectHistory):
+* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
+(WebCore::CCHeadsUpDisplay::showDebugRects):
+(WebCore::CCHeadsUpDisplay::draw):
+(WebCore::CCHeadsUpDisplay::drawDebugRects):
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
+(CCLayerTreeSettings):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
+(WebCore::CCLayerTreeHostImpl::drawLayers):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+(FrameData):
+* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
+(WebCoreCCOcclusionTrackerBase):
+(WebCore::addOcclusionBehindLayer):
+(WebCoremarkOccludedBehindLayer):
+* platform/graphics/chromium/cc/CCOcclusionTracker.h:
+(CCOcclusionTrackerBase):
+(WebCore::CCOcclusionTrackerBase::setOccludingScreenSpaceRectsContainer):
+
 2012-06-27  Anthony Scian  asc...@rim.com
 
 Web Inspector [JSC]: Implement ScriptCallStack::stackTrace


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCDebugRectHistory.cpp (121360 => 121361)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCDebugRectHistory.cpp	2012-06-27 20:22:32 UTC (rev 121360)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCDebugRectHistory.cpp	2012-06-27 20:31:27 UTC (rev 121361)
@@ -40,10 +40,10 @@
 
 bool CCDebugRectHistory::enabled(const CCLayerTreeSettings settings)
 {
-return settings.showPaintRects || settings.showPropertyChangedRects || settings.showSurfaceDamageRects;
+return settings.showPaintRects || settings.showPropertyChangedRects || 

[webkit-changes] [121362] trunk/Source/WebKit/blackberry

[zhajiang]

Title: [121362] trunk/Source/WebKit/blackberry








Revision 121362
Author zhaji...@rim.com
Date 2012-06-27 13:38:54 -0700 (Wed, 27 Jun 2012)


Log Message
[BlackBerry] Wrong scale after leaving fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=89546

Reviewed by Antonio Gomes.
Patch by Jacky Jiang zhaji...@rim.com

PR: 164948
When we were entering fullscreen, the current scale A was clamped to a
greater minimum scale B as we relayouted the contents during the change
of the viewport size. When leaving fullscreen, we still used that scale
B as the current scale which was incorrect.
To fix this, we can save the current scale when entering fullscreen and
restore it when leaving fullscreen.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
* Api/WebPage_p.h:
(WebPagePrivate):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (121361 => 121362)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-27 20:31:27 UTC (rev 121361)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-27 20:38:54 UTC (rev 121362)
@@ -371,8 +371,9 @@
 , m_touchEventModePriorGoingFullScreen(ProcessedTouchEvents)
 #endif
 #endif
-#if ENABLE(FULLSCREEN_API)
-, m_xScrollOffsetPriorGoingFullScreen(-1)
+#if ENABLE(FULLSCREEN_API)  ENABLE(VIDEO)
+, m_scaleBeforeFullScreen(-1.0)
+, m_xScrollOffsetBeforeFullScreen(-1)
 #endif
 , m_currentCursor(Platform::CursorNone)
 , m_dumpRenderTree(0) // Lazy initialization.
@@ -6209,13 +6210,18 @@
 // we temporarily scroll the WebPage to x:0 so that the wrapper gets properly
 // positioned. The original scroll position is restored once element leaves fullscreen.
 WebCore::IntPoint scrollPosition = m_mainFrame-view()-scrollPosition();
-m_xScrollOffsetPriorGoingFullScreen = scrollPosition.x();
+m_xScrollOffsetBeforeFullScreen = scrollPosition.x();
 m_mainFrame-view()-setScrollPosition(WebCore::IntPoint(0, scrollPosition.y()));
 
 #if ENABLE(EVENT_MODE_METATAGS)
 m_touchEventModePriorGoingFullScreen = m_touchEventMode;
 didReceiveTouchEventMode(PureTouchEventsWithMouseConversion);
 #endif
+// The current scale can be clamped to a greater minimum scale when we relayout contents during
+// the change of the viewport size. Cache the current scale so that we can restore it when
+// leaving fullscreen. Otherwise, it is possible that we will use the wrong scale.
+m_scaleBeforeFullScreen = currentScale();
+
 // No fullscreen video widget has been made available by the Browser
 // chrome, or this is not a video element. The webkitRequestFullScreen
 // _javascript_ call is often made on a div element.
@@ -6237,16 +6243,27 @@
 exitFullscreenForNode(element);
 } else {
 // When leaving fullscreen mode, we need to restore the 'x' scroll position
-// prior going full screen.
+// before fullscreen.
+// FIXME: We may need to respect 'y' position as well, because the web page always scrolls to
+// the top when leaving fullscreen mode.
 WebCore::IntPoint scrollPosition = m_mainFrame-view()-scrollPosition();
 m_mainFrame-view()-setScrollPosition(
-WebCore::IntPoint(m_xScrollOffsetPriorGoingFullScreen, scrollPosition.y()));
-m_xScrollOffsetPriorGoingFullScreen = -1;
+WebCore::IntPoint(m_xScrollOffsetBeforeFullScreen, scrollPosition.y()));
+m_xScrollOffsetBeforeFullScreen = -1;
 
 #if ENABLE(EVENT_MODE_METATAGS)
 didReceiveTouchEventMode(m_touchEventModePriorGoingFullScreen);
 m_touchEventModePriorGoingFullScreen = ProcessedTouchEvents;
 #endif
+if (m_scaleBeforeFullScreen  0) {
+// Restore the scale when leaving fullscreen. We can't use TransformationMatrix::scale(double) here, as it
+// will multiply the scale rather than set the scale.
+// FIXME: We can refactor this into setCurrentScale(double) if it is useful in the future.
+m_transformationMatrix-setM11(m_scaleBeforeFullScreen);
+m_transformationMatrix-setM22(m_scaleBeforeFullScreen);
+m_scaleBeforeFullScreen = -1.0;
+}
+
 // This is where we would restore the browser's chrome
 // if hidden above.
 client()-fullscreenStop();


Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (121361 => 121362)

--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h	2012-06-27 20:31:27 UTC (rev 121361)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h	2012-06-27 20:38:54 UTC (rev 121362)
@@ -498,8 +498,11 @@
 #if ENABLE(EVENT_MODE_METATAGS)
 WebCore::TouchEventMode 

[webkit-changes] [121363] trunk/Tools

[dpranke]

Title: [121363] trunk/Tools








Revision 121363
Author dpra...@chromium.org
Date 2012-06-27 13:52:58 -0700 (Wed, 27 Jun 2012)


Log Message
Derive ChromiumPort from WebKitPort to add support for missing symbols to skip tests
https://bugs.webkit.org/show_bug.cgi?id=89706

Reviewed by Adam Barth.

Based on the original patch by Raymond Toy.

This patch changes ChromiumPort to derive from webkit.WebKitPort
instead of base.Port. This is a long-awaited change and a
precursor to merging base.Port and webkit.WebKitPort, but is
driven by the desire to dynamically detect whether the MP3 and
AAC codecs are compiled into DRT on Chromium, for which we
wanted to re-use the existing logic in WebKit port for determine
what to skip at compile time.

Most of the changes are shuffling things around so that we don't
change any other logic and so we override the necessary methods
in WebKitPort (and try to follow the same method definition
order where possible).

Also, on the Chromium port the mp3 and aac codecs are actually
defined in a separate library, so scanning webcore isn't
sufficient. This patch generalizes the symbol lookup to handle
multiple libraries, and uses different libraries as appropriate
for Chromium.

The only functional/visible changes should be in the value
returned for skipped_layout_tests().

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
(ChromiumPort.__init__):
(ChromiumPort.driver_name):
(ChromiumPort._driver_class):
(ChromiumPort._missing_symbol_to_skipped_tests):
(ChromiumPort.skipped_layout_tests):
(ChromiumPort.setup_test_run):
(ChromiumPort._path_to_image_diff):
(ChromiumPort._convert_path):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_missing_symbol_to_skipped_tests):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._modules_to_search_for_symbols):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumLinuxPort._modules_to_search_for_symbols):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumLinuxPort._modules_to_search_for_symbols):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort):
(WebKitPort.__init__):
(WebKitPort._symbols_string):
(WebKitPort._modules_to_search_for_symbols):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (121362 => 121363)

--- trunk/Tools/ChangeLog	2012-06-27 20:38:54 UTC (rev 121362)
+++ trunk/Tools/ChangeLog	2012-06-27 20:52:58 UTC (rev 121363)
@@ -1,3 +1,58 @@
+2012-06-27  Dirk Pranke  dpra...@chromium.org
+
+Derive ChromiumPort from WebKitPort to add support for missing symbols to skip tests
+https://bugs.webkit.org/show_bug.cgi?id=89706
+
+Reviewed by Adam Barth.
+
+Based on the original patch by Raymond Toy.
+
+This patch changes ChromiumPort to derive from webkit.WebKitPort
+instead of base.Port. This is a long-awaited change and a
+precursor to merging base.Port and webkit.WebKitPort, but is
+driven by the desire to dynamically detect whether the MP3 and
+AAC codecs are compiled into DRT on Chromium, for which we
+wanted to re-use the existing logic in WebKit port for determine
+what to skip at compile time.
+
+Most of the changes are shuffling things around so that we don't
+change any other logic and so we override the necessary methods
+in WebKitPort (and try to follow the same method definition
+order where possible).
+
+Also, on the Chromium port the mp3 and aac codecs are actually
+defined in a separate library, so scanning webcore isn't
+sufficient. This patch generalizes the symbol lookup to handle
+multiple libraries, and uses different libraries as appropriate
+for Chromium.
+
+The only functional/visible changes should be in the value
+returned for skipped_layout_tests().
+
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumPort):
+(ChromiumPort.__init__):
+(ChromiumPort.driver_name):
+(ChromiumPort._driver_class):
+(ChromiumPort._missing_symbol_to_skipped_tests):
+(ChromiumPort.skipped_layout_tests):
+(ChromiumPort.setup_test_run):
+(ChromiumPort._path_to_image_diff):
+(ChromiumPort._convert_path):
+* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+(ChromiumPortTest.test_missing_symbol_to_skipped_tests):
+* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
+

[webkit-changes] [121364] trunk/Source/WebKit/chromium

[commit-queue]

Title: [121364] trunk/Source/WebKit/chromium








Revision 121364
Author commit-qu...@webkit.org
Date 2012-06-27 14:00:59 -0700 (Wed, 27 Jun 2012)


Log Message
[chromium] Expose device scale factor in WebPluginContainer
https://bugs.webkit.org/show_bug.cgi?id=87874

Patch by Josh Horwich jhorw...@chromium.org on 2012-06-27
Reviewed by Adam Barth.

* public/WebPluginContainer.h:
(WebPluginContainer):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::deviceScaleFactor):
(WebKit):
(WebKit::WebPluginContainerImpl::pageScaleFactor):
(WebKit::WebPluginContainerImpl::pageZoomFactor):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebPluginContainer.h
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (121363 => 121364)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-06-27 20:52:58 UTC (rev 121363)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-06-27 21:00:59 UTC (rev 121364)
@@ -1,3 +1,20 @@
+2012-06-27  Josh Horwich  jhorw...@chromium.org
+
+[chromium] Expose device scale factor in WebPluginContainer
+https://bugs.webkit.org/show_bug.cgi?id=87874
+
+Reviewed by Adam Barth.
+
+* public/WebPluginContainer.h:
+(WebPluginContainer):
+* src/WebPluginContainerImpl.cpp:
+(WebKit::WebPluginContainerImpl::deviceScaleFactor):
+(WebKit):
+(WebKit::WebPluginContainerImpl::pageScaleFactor):
+(WebKit::WebPluginContainerImpl::pageZoomFactor):
+* src/WebPluginContainerImpl.h:
+(WebPluginContainerImpl):
+
 2012-06-27  Robert Kroeger  rjkro...@chromium.org
 
 [chromium] out-of-order assert in WebViewImpl setDeviceScaleFactor


Modified: trunk/Source/WebKit/chromium/public/WebPluginContainer.h (121363 => 121364)

--- trunk/Source/WebKit/chromium/public/WebPluginContainer.h	2012-06-27 20:52:58 UTC (rev 121363)
+++ trunk/Source/WebKit/chromium/public/WebPluginContainer.h	2012-06-27 21:00:59 UTC (rev 121364)
@@ -98,6 +98,7 @@
 const WebURLRequest, const WebString target, bool notifyNeeded, void* notifyData) = 0;
 
 // Notifies that the zoom level has changed.
+// Note, this does NOT affect pageScaleFactor or pageZoomFactor
 virtual void zoomLevelChanged(double zoomLevel) = 0;
 
 // Notifies whether the contents of the plugin are entirely opaque.
@@ -113,6 +114,10 @@
 virtual WebPlugin* plugin() = 0;
 virtual void setPlugin(WebPlugin*) = 0;
 
+virtual float deviceScaleFactor() = 0;
+virtual float pageScaleFactor() = 0;
+virtual float pageZoomFactor() = 0;
+
 protected:
 ~WebPluginContainer() { }
 };


Modified: trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (121363 => 121364)

--- trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp	2012-06-27 20:52:58 UTC (rev 121363)
+++ trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp	2012-06-27 21:00:59 UTC (rev 121364)
@@ -245,6 +245,30 @@
 }
 }
 
+float WebPluginContainerImpl::deviceScaleFactor()
+{
+Page* page = m_element-document()-page();
+if (!page)
+return 1.0;
+return page-deviceScaleFactor();
+}
+
+float WebPluginContainerImpl::pageScaleFactor()
+{
+Page* page = m_element-document()-page();
+if (!page)
+return 1.0;
+return page-pageScaleFactor();
+}
+
+float WebPluginContainerImpl::pageZoomFactor()
+{
+Frame* frame = m_element-document()-frame();
+if (!frame)
+return 1.0;
+return frame-pageZoomFactor();
+}
+
 bool WebPluginContainerImpl::supportsPaginatedPrint() const
 {
 return m_webPlugin-supportsPaginatedPrint();


Modified: trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h (121363 => 121364)

--- trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h	2012-06-27 20:52:58 UTC (rev 121363)
+++ trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h	2012-06-27 21:00:59 UTC (rev 121364)
@@ -116,6 +116,10 @@
 WebPlugin* plugin() { return m_webPlugin; }
 void setPlugin(WebPlugin*);
 
+virtual float deviceScaleFactor();
+virtual float pageScaleFactor();
+virtual float pageZoomFactor();
+
 // Printing interface. The plugin can support custom printing
 // (which means it controls the layout, number of pages etc).
 // Whether the plugin supports its own paginated print. The other print






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121365] trunk/Tools

[mhahnenberg]

Title: [121365] trunk/Tools








Revision 121365
Author mhahnenb...@apple.com
Date 2012-06-27 14:02:28 -0700 (Wed, 27 Jun 2012)


Log Message
Moving from committers to reviewers :-)

Rubber stamped by Filip Pizlo.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (121364 => 121365)

--- trunk/Tools/ChangeLog	2012-06-27 21:00:59 UTC (rev 121364)
+++ trunk/Tools/ChangeLog	2012-06-27 21:02:28 UTC (rev 121365)
@@ -1,3 +1,11 @@
+2012-06-27  Mark Hahnenberg  mhahnenb...@apple.com
+
+Moving from committers to reviewers :-)
+
+Rubber stamped by Filip Pizlo.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2012-06-27  Dirk Pranke  dpra...@chromium.org
 
 Derive ChromiumPort from WebKitPort to add support for missing symbols to skip tests


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (121364 => 121365)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-06-27 21:00:59 UTC (rev 121364)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-06-27 21:02:28 UTC (rev 121365)
@@ -312,7 +312,6 @@
 Committer(Mahesh Kulkarni, [mahesh.kulka...@nokia.com, mahe...@webkit.org], maheshk),
 Committer(Marcus Voltis Bulach, bul...@chromium.org),
 Committer(Mario Sanchez Prada, [msanc...@igalia.com, ma...@webkit.org], msanchez),
-Committer(Mark Hahnenberg, mhahnenb...@apple.com),
 Committer(Mary Wu, [mary...@torchmobile.com.cn, wwendy2...@gmail.com], marywu),
 Committer(Matt Delaney, mdela...@apple.com),
 Committer(Matt Lilek, [mli...@apple.com, web...@mattlilek.com, pewtermo...@webkit.org], pewtermoose),
@@ -483,6 +482,7 @@
 Reviewer(Levi Weintraub, [le...@chromium.org, le...@google.com, lweintr...@apple.com], leviw),
 Reviewer(Luiz Agostini, [l...@webkit.org, luiz.agost...@openbossa.org], lca),
 Reviewer(Maciej Stachowiak, m...@apple.com, othermaciej),
+Reviewer(Mark Hahnenberg, mhahnenb...@apple.com, mhahnenberg),
 Reviewer(Mark Rowe, mr...@apple.com, bdash),
 Reviewer(Martin Robinson, [mrobin...@webkit.org, mrobin...@igalia.com, martin.james.robin...@gmail.com], mrobinson),
 Reviewer(Michael Saboff, msab...@apple.com, msaboff),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121366] trunk/Source/WebKit/chromium

[jsbell]

Title: [121366] trunk/Source/WebKit/chromium








Revision 121366
Author jsb...@chromium.org
Date 2012-06-27 14:05:44 -0700 (Wed, 27 Jun 2012)


Log Message
[Chromium] IndexedDB: Expose WebIDBTransaction::commit() method in public API
https://bugs.webkit.org/show_bug.cgi?id=90089

Reviewed by James Robinson.

Prep work for http://webkit.org/b/89379 which requires empty transactions to
trigger a commit from the front-end.

* public/WebIDBTransaction.h:
(WebKit::WebIDBTransaction::commit):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBTransaction.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (121365 => 121366)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-06-27 21:02:28 UTC (rev 121365)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-06-27 21:05:44 UTC (rev 121366)
@@ -1,3 +1,16 @@
+2012-06-27  Joshua Bell  jsb...@chromium.org
+
+[Chromium] IndexedDB: Expose WebIDBTransaction::commit() method in public API
+https://bugs.webkit.org/show_bug.cgi?id=90089
+
+Reviewed by James Robinson.
+
+Prep work for http://webkit.org/b/89379 which requires empty transactions to
+trigger a commit from the front-end.
+
+* public/WebIDBTransaction.h:
+(WebKit::WebIDBTransaction::commit):
+
 2012-06-27  Josh Horwich  jhorw...@chromium.org
 
 [chromium] Expose device scale factor in WebPluginContainer


Modified: trunk/Source/WebKit/chromium/public/WebIDBTransaction.h (121365 => 121366)

--- trunk/Source/WebKit/chromium/public/WebIDBTransaction.h	2012-06-27 21:02:28 UTC (rev 121365)
+++ trunk/Source/WebKit/chromium/public/WebIDBTransaction.h	2012-06-27 21:05:44 UTC (rev 121366)
@@ -51,6 +51,7 @@
 WEBKIT_ASSERT_NOT_REACHED();
 return 0;
 }
+virtual void commit() { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void abort() { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void didCompleteTaskEvents() { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void setCallbacks(WebIDBTransactionCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121367] trunk/Tools

[dpranke]

Title: [121367] trunk/Tools








Revision 121367
Author dpra...@chromium.org
Date 2012-06-27 14:09:36 -0700 (Wed, 27 Jun 2012)


Log Message
Fix typo introduced in r121363.

Unreviewed, build fix.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._symbols_string):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (121366 => 121367)

--- trunk/Tools/ChangeLog	2012-06-27 21:05:44 UTC (rev 121366)
+++ trunk/Tools/ChangeLog	2012-06-27 21:09:36 UTC (rev 121367)
@@ -1,3 +1,12 @@
+2012-06-27  Dirk Pranke  dpra...@chromium.org
+
+Fix typo introduced in r121363.
+
+Unreviewed, build fix.
+
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitPort._symbols_string):
+
 2012-06-27  Mark Hahnenberg  mhahnenb...@apple.com
 
 Moving from committers to reviewers :-)


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (121366 => 121367)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-06-27 21:05:44 UTC (rev 121366)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-06-27 21:09:36 UTC (rev 121367)
@@ -276,7 +276,7 @@
 symbols = ''
 for path_to_module in self._modules_to_search_for_symbols():
 try:
-symbols += self._executive.run_command([self.nm_command(), path_o_module], error_handler=Executive.ignore_error)
+symbols += self._executive.run_command([self.nm_command(), path_to_module], error_handler=Executive.ignore_error)
 except OSError, e:
 _log.warn(Failed to run nm: %s.  Can't determine supported features correctly. % e)
 return symbols






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121368] trunk/LayoutTests

[zandobersek]

Title: [121368] trunk/LayoutTests








Revision 121368
Author zandober...@gmail.com
Date 2012-06-27 14:12:46 -0700 (Wed, 27 Jun 2012)


Log Message
Unreviewed GTK gardening, adding a new baseline that's required
after the Gamepad API has been turned on in r121332.

* platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (121367 => 121368)

--- trunk/LayoutTests/ChangeLog	2012-06-27 21:09:36 UTC (rev 121367)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 21:12:46 UTC (rev 121368)
@@ -1,3 +1,10 @@
+2012-06-27  Zan Dobersek  zandober...@gmail.com
+
+Unreviewed GTK gardening, adding a new baseline that's required
+after the Gamepad API has been turned on in r121332.
+
+* platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Added.
+
 2012-06-27  Ryosuke Niwa  rn...@webkit.org
 
 REGRESSION (Safari 5?): Pasting a line into textarea inserts two newlines


Added: trunk/LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt (0 => 121368)

--- trunk/LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt	2012-06-27 21:12:46 UTC (rev 121368)
@@ -0,0 +1,37 @@
+This tests that the navigator object of a deleted frame is disconnected properly. Accessing fields or methods shouldn't crash the browser. 
+ Check Navigator
+navigator.appCodeName is OK
+navigator.appName is OK
+navigator.appVersion is OK
+navigator.cookieEnabled is OK
+navigator.getStorageUpdates() is OK
+navigator.javaEnabled() is OK
+navigator.language is OK
+navigator.mimeTypes is OK
+navigator.onLine is OK
+navigator.platform is OK
+navigator.plugins is OK
+navigator.product is OK
+navigator.productSub is OK
+navigator.userAgent is OK
+navigator.vendor is OK
+navigator.vendorSub is OK
+navigator.webkitGamepads is OK
+navigator.appCodeName is OK
+navigator.appName is OK
+navigator.appVersion is OK
+navigator.cookieEnabled is OK
+navigator.getStorageUpdates() is OK
+navigator.javaEnabled() is OK
+navigator.language is OK
+navigator.mimeTypes is OK
+navigator.onLine is OK
+navigator.platform is OK
+navigator.plugins is OK
+navigator.product is OK
+navigator.productSub is OK
+navigator.userAgent is OK
+navigator.vendor is OK
+navigator.vendorSub is OK
+navigator.webkitGamepads is OK
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121369] trunk/Tools

[abarth]

Title: [121369] trunk/Tools








Revision 121369
Author aba...@webkit.org
Date 2012-06-27 14:14:11 -0700 (Wed, 27 Jun 2012)


Log Message
[Chromium] DumpRenderTree on Android should call SkUseTestFontConfigFile once available
https://bugs.webkit.org/show_bug.cgi?id=89801

Reviewed by Nate Chapin.

Let's call SkUseTestFontConfigFile now that it exists.

* DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp




Diff

Modified: trunk/Tools/ChangeLog (121368 => 121369)

--- trunk/Tools/ChangeLog	2012-06-27 21:12:46 UTC (rev 121368)
+++ trunk/Tools/ChangeLog	2012-06-27 21:14:11 UTC (rev 121369)
@@ -1,3 +1,15 @@
+2012-06-27  Adam Barth  aba...@webkit.org
+
+[Chromium] DumpRenderTree on Android should call SkUseTestFontConfigFile once available
+https://bugs.webkit.org/show_bug.cgi?id=89801
+
+Reviewed by Nate Chapin.
+
+Let's call SkUseTestFontConfigFile now that it exists.
+
+* DumpRenderTree/chromium/TestShellAndroid.cpp:
+(platformInit):
+
 2012-06-27  Dirk Pranke  dpra...@chromium.org
 
 Fix typo introduced in r121363.


Modified: trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp (121368 => 121369)

--- trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp	2012-06-27 21:12:46 UTC (rev 121368)
+++ trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp	2012-06-27 21:14:11 UTC (rev 121369)
@@ -102,9 +102,7 @@
 void platformInit(int* argc, char*** argv)
 {
 // Initialize skia with customized font config files.
-// FIXME: Add this call once SkUseTestFontConfigFile is added to Skia and
-// visible to WebKit. See https://bugs.webkit.org/show_bug.cgi?id=89801
-// SkUseTestFontConfigFile(fontMainConfigFile, fontFallbackConfigFile, fontsDir);
+SkUseTestFontConfigFile(fontMainConfigFile, fontFallbackConfigFile, fontsDir);
 
 const char* inFIFO = 0;
 const char* outFIFO = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121370] trunk/Source/WebKit2

[commit-queue]

Title: [121370] trunk/Source/WebKit2








Revision 121370
Author commit-qu...@webkit.org
Date 2012-06-27 14:18:53 -0700 (Wed, 27 Jun 2012)


Log Message
REGRESSION(r121135): It made qmltests::WebViewColorChooser::test_accept() fail
https://bugs.webkit.org/show_bug.cgi?id=89871

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-06-27
Reviewed by Simon Hausmann.

Added proper event synchronization to the test case.

* UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/colorChooser.html




Diff

Modified: trunk/Source/WebKit2/ChangeLog (121369 => 121370)

--- trunk/Source/WebKit2/ChangeLog	2012-06-27 21:14:11 UTC (rev 121369)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-27 21:18:53 UTC (rev 121370)
@@ -1,3 +1,14 @@
+2012-06-27  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+REGRESSION(r121135): It made qmltests::WebViewColorChooser::test_accept() fail
+https://bugs.webkit.org/show_bug.cgi?id=89871
+
+Reviewed by Simon Hausmann.
+
+Added proper event synchronization to the test case.
+
+* UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml:
+
 2012-06-27  Brady Eidson  beid...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=87513


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml (121369 => 121370)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml	2012-06-27 21:14:11 UTC (rev 121369)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml	2012-06-27 21:18:53 UTC (rev 121370)
@@ -46,14 +46,23 @@
 webView.url = ""
 verify(webView.waitForLoadSucceeded())
 
+while (webView.title != Feature enabled  webView.title != Feature disabled)
+wait(0)
+
 webView.featureEnabled = (webView.title == Feature enabled)
+if (!webView.featureEnabled)
+return
 
 titleSpy.clear()
 
-webView.shouldReject = false;
-webView.shouldAcceptCurrent = false;
+webView.shouldReject = false
+webView.shouldAcceptCurrent = false
 }
 
+function cleanup() {
+titleSpy.clear()
+}
+
 function test_accept() {
 if (!webView.featureEnabled)
 return
@@ -64,8 +73,8 @@
 // pick a new color with the chooser.
 webView.selectedColor = #020020
 openColorChooser()
-titleSpy.wait()
-compare(titleSpy.count, 2)
+while (titleSpy.count != 2)
+wait(0)
 compare(webView.title, #020020)
 }
 


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/colorChooser.html (121369 => 121370)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/colorChooser.html	2012-06-27 21:14:11 UTC (rev 121369)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/colorChooser.html	2012-06-27 21:18:53 UTC (rev 121370)
@@ -1,13 +1,15 @@
 !DOCTYPE html
 html
 head
-titleFeature disabled/title
+titleTitle/title
 script
 function detectInputTypeColorEnabled() {
 var element = document.getElementById('test')
 element.value = 'should sanitize';
 if (element.value != 'should sanitize')
 document.title = 'Feature enabled';
+else
+document.title = 'Feature disabled';
 }
 function updateTitle(element) {
 document.title = element.value;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121371] trunk

[wjmaclean]

Title: [121371] trunk








Revision 121371
Author wjmacl...@chromium.org
Date 2012-06-27 14:24:54 -0700 (Wed, 27 Jun 2012)


Log Message
[chromium] ScrollbarLayerChromium should support painting forward-track and back-track in different styles.
https://bugs.webkit.org/show_bug.cgi?id=89908

Reviewed by Adrienne Walker.

Source/WebCore:

Test: platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html

Adds support for accelerated drawing (impl thread) of scrollbars with different styles for the
forward-track and back-track parts.

* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarBackgroundPainter::create):
(WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
(ScrollbarBackgroundPainter):
(WebCore::ScrollbarLayerChromium::setLayerTreeHost):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::update):
* platform/graphics/chromium/ScrollbarLayerChromium.h:
(ScrollbarLayerChromium):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore):
(WebCore::CCScrollbarLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(WebCore::CCScrollbarLayerImpl::setBackTrackTextureId):
(WebCore::CCScrollbarLayerImpl::setForeTrackTextureId):
(CCScrollbarLayerImpl):

LayoutTests:

Adds support for accelerated drawing (impl thread) of scrollbars with different styles for the
forward-track and back-track parts.

* platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
* platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.txt: Added.
* platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/ScrollbarLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/ScrollbarLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.h


Added Paths

trunk/LayoutTests/platform/chromium/compositing/scrollbars/
trunk/LayoutTests/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png
trunk/LayoutTests/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.txt
trunk/LayoutTests/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121370 => 121371)

--- trunk/LayoutTests/ChangeLog	2012-06-27 21:18:53 UTC (rev 121370)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 21:24:54 UTC (rev 121371)
@@ -1,3 +1,17 @@
+2012-06-27  W. James MacLean  wjmacl...@chromium.org
+
+[chromium] ScrollbarLayerChromium should support painting forward-track and back-track in different styles.
+https://bugs.webkit.org/show_bug.cgi?id=89908
+
+Reviewed by Adrienne Walker.
+
+Adds support for accelerated drawing (impl thread) of scrollbars with different styles for the
+forward-track and back-track parts.
+
+* platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
+* platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.txt: Added.
+* platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html: Added.
+
 2012-06-27  Zan Dobersek  zandober...@gmail.com
 
 Unreviewed GTK gardening, adding a new baseline that's required


Added: trunk/LayoutTests/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png (0 => 121371)

--- trunk/LayoutTests/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png	(rev 0)
+++ trunk/LayoutTests/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png	2012-06-27 21:24:54 UTC (rev 121371)
@@ -0,0 +1,5 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksum510b4bd3b00e1396fd976e7c03f1cceb\xA4!\xF3IDATx\x9C\xED\xDDAR*I@Q\xCA`5_\xD7ӓ\xEF^l\xF6\xF2ݑ\xF6\xA4\x93=\xC0\xA8\x81(Wᜉ\x98Qbo\xBC\xAA\x84i\x8C\xB1
\xE0\xA8iz{16o\xAF\xA6\xCD\xF8le\xFB\xAD[\xF8\xB1\xE6\x90\xFA\xF0\xD7yeڌ\xBB\xEF\xDB\xC0mX\xA7Ϋ\x8E\)\xB0b \xB0N\x9BO.\xB9R`
\xC4@L`
\x9C\xE6!\xC0\x9A@L`
\x9C\xE6!\xC0\x9A|\xD93\xC0\xFB!\xD6\xFC\xB4\xFB\xD3:\\x99\xC6X:\xEF\xB8Y\xBBi\xB7\xFCb\xB7
b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB6]{\x9Bv\xD3\xDA[\xE0ʍ\xA7\xB1\xF6\xB8ZX\xB1

[webkit-changes] [121372] trunk/Source/JavaScriptCore

[fpizlo]

Title: [121372] trunk/Source/_javascript_Core








Revision 121372
Author fpi...@apple.com
Date 2012-06-27 14:25:23 -0700 (Wed, 27 Jun 2012)


Log Message
Add a comment clarifying Options::showDisassembly versus Options::showDFGDisassembly.

Rubber stamped by Mark Hahnenberg.

* runtime/Options.cpp:
(JSC::Options::initializeOptions):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121371 => 121372)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-27 21:24:54 UTC (rev 121371)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-27 21:25:23 UTC (rev 121372)
@@ -1,3 +1,12 @@
+2012-06-27  Filip Pizlo  fpi...@apple.com
+
+Add a comment clarifying Options::showDisassembly versus Options::showDFGDisassembly.
+
+Rubber stamped by Mark Hahnenberg.
+
+* runtime/Options.cpp:
+(JSC::Options::initializeOptions):
+
 2012-06-27  Anthony Scian  asc...@rim.com
 
 Web Inspector [JSC]: Implement ScriptCallStack::stackTrace


Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (121371 => 121372)

--- trunk/Source/_javascript_Core/runtime/Options.cpp	2012-06-27 21:24:54 UTC (rev 121371)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp	2012-06-27 21:25:23 UTC (rev 121372)
@@ -172,7 +172,7 @@
 SET(useJIT, true);
 
 SET(showDisassembly, false);
-SET(showDFGDisassembly, false);
+SET(showDFGDisassembly, false); // DFG disassembly is shown if showDisassembly || showDFGDisassembly
 
 SET(maximumOptimizationCandidateInstructionCount, 1);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121373] trunk/Tools

[dpranke]

Title: [121373] trunk/Tools








Revision 121373
Author dpra...@chromium.org
Date 2012-06-27 14:25:33 -0700 (Wed, 27 Jun 2012)


Log Message
webkitpy: fix a couple of issues running under cygwin
https://bugs.webkit.org/show_bug.cgi?id=90035

Reviewed by Eric Seidel.

These were causing unit tests to fail on cygwin (apple win bot).

* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/performance_tests/perftest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py




Diff

Modified: trunk/Tools/ChangeLog (121372 => 121373)

--- trunk/Tools/ChangeLog	2012-06-27 21:25:23 UTC (rev 121372)
+++ trunk/Tools/ChangeLog	2012-06-27 21:25:33 UTC (rev 121373)
@@ -1,3 +1,15 @@
+2012-06-27  Dirk Pranke  dpra...@chromium.org
+
+webkitpy: fix a couple of issues running under cygwin
+https://bugs.webkit.org/show_bug.cgi?id=90035
+
+Reviewed by Eric Seidel.
+
+These were causing unit tests to fail on cygwin (apple win bot).
+
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+* Scripts/webkitpy/performance_tests/perftest.py:
+
 2012-06-27  Adam Barth  aba...@webkit.org
 
 [Chromium] DumpRenderTree on Android should call SkUseTestFontConfigFile once available


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (121372 => 121373)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-06-27 21:25:23 UTC (rev 121372)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-06-27 21:25:33 UTC (rev 121373)
@@ -39,6 +39,7 @@
 import time
 
 from webkitpy.common.system import executive
+from webkitpy.common.system.path import cygpath
 from webkitpy.layout_tests.models.test_configuration import TestConfiguration
 from webkitpy.layout_tests.port.base import Port, VirtualTestSuite
 from webkitpy.layout_tests.port.driver import DriverOutput


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py (121372 => 121373)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2012-06-27 21:25:23 UTC (rev 121372)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2012-06-27 21:25:33 UTC (rev 121373)
@@ -40,7 +40,7 @@
 import time
 
 # Import for auto-install
-if sys.platform != 'win32':
+if sys.platform not in ('cygwin', 'win32'):
 # FIXME: webpagereplay doesn't work on win32. See https://bugs.webkit.org/show_bug.cgi?id=88279.
 import webkitpy.thirdparty.autoinstalled.webpagereplay.replay
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121374] trunk/Source/JavaScriptCore

[fpizlo]

Title: [121374] trunk/Source/_javascript_Core








Revision 121374
Author fpi...@apple.com
Date 2012-06-27 14:45:08 -0700 (Wed, 27 Jun 2012)


Log Message
x86 disassembler confuses immediates with addresses
https://bugs.webkit.org/show_bug.cgi?id=90099

Reviewed by Mark Hahnenberg.

Prepend $ to immediates to disambiguate between immediates and addresses. This is in
accordance with the gas and ATT syntax.

* disassembler/udis86/udis86_syn-att.c:
(gen_operand):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/disassembler/udis86/udis86_syn-att.c




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121373 => 121374)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-27 21:25:33 UTC (rev 121373)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-27 21:45:08 UTC (rev 121374)
@@ -1,5 +1,18 @@
 2012-06-27  Filip Pizlo  fpi...@apple.com
 
+x86 disassembler confuses immediates with addresses
+https://bugs.webkit.org/show_bug.cgi?id=90099
+
+Reviewed by Mark Hahnenberg.
+
+Prepend $ to immediates to disambiguate between immediates and addresses. This is in
+accordance with the gas and ATT syntax.
+
+* disassembler/udis86/udis86_syn-att.c:
+(gen_operand):
+
+2012-06-27  Filip Pizlo  fpi...@apple.com
+
 Add a comment clarifying Options::showDisassembly versus Options::showDFGDisassembly.
 
 Rubber stamped by Mark Hahnenberg.


Modified: trunk/Source/_javascript_Core/disassembler/udis86/udis86_syn-att.c (121373 => 121374)

--- trunk/Source/_javascript_Core/disassembler/udis86/udis86_syn-att.c	2012-06-27 21:25:33 UTC (rev 121373)
+++ trunk/Source/_javascript_Core/disassembler/udis86/udis86_syn-att.c	2012-06-27 21:45:08 UTC (rev 121374)
@@ -109,7 +109,7 @@
 }
 if ( sext_size  64 )
 sext_mask = ( 1ull  sext_size ) - 1;
-mkasm( u, 0x FMT64 x, imm  sext_mask ); 
+mkasm( u, $0x FMT64 x, imm  sext_mask ); 
 
 		break;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121376] trunk

[arv]

Title: [121376] trunk








Revision 121376
Author a...@chromium.org
Date 2012-06-27 15:00:55 -0700 (Wed, 27 Jun 2012)


Log Message
[V8] Improve variable resolution order on window
https://bugs.webkit.org/show_bug.cgi?id=84247

Reviewed by Ojan Vafai.

This changes the V8 flag to turn on es52_globals and updates the layout tests to reflect the fixed behavior.

This is the second (third?) try. Last time there was a bug in the V8 code related to the split window.
I added a test that tests the failure that caused this to be rolled back last time.

Source/WebCore:

Tests: fast/dom/Window/es52-globals.html
   fast/dom/Window/window-property-shadowing-onclick.html

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate):

LayoutTests:

* fast/dom/Window/es52-globals-expected.txt: Added.
* fast/dom/Window/es52-globals.html: Added.
* fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
* fast/dom/Window/window-property-shadowing-onclick.html: Added.
* platform/chromium/fast/dom/Window/es52-globals-expected.txt: Added.
* platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Added.
* platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp


Added Paths

trunk/LayoutTests/fast/dom/Window/es52-globals-expected.txt
trunk/LayoutTests/fast/dom/Window/es52-globals.html
trunk/LayoutTests/fast/dom/Window/window-property-shadowing-onclick-expected.txt
trunk/LayoutTests/fast/dom/Window/window-property-shadowing-onclick.html
trunk/LayoutTests/platform/chromium/fast/dom/Window/es52-globals-expected.txt
trunk/LayoutTests/platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt
trunk/LayoutTests/platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (121375 => 121376)

--- trunk/LayoutTests/ChangeLog	2012-06-27 21:50:49 UTC (rev 121375)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 22:00:55 UTC (rev 121376)
@@ -1,3 +1,23 @@
+2012-06-27  Erik Arvidsson  a...@chromium.org
+
+[V8] Improve variable resolution order on window
+https://bugs.webkit.org/show_bug.cgi?id=84247
+
+Reviewed by Ojan Vafai.
+
+This changes the V8 flag to turn on es52_globals and updates the layout tests to reflect the fixed behavior.
+
+This is the second (third?) try. Last time there was a bug in the V8 code related to the split window.
+I added a test that tests the failure that caused this to be rolled back last time.
+
+* fast/dom/Window/es52-globals-expected.txt: Added.
+* fast/dom/Window/es52-globals.html: Added.
+* fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
+* fast/dom/Window/window-property-shadowing-onclick.html: Added.
+* platform/chromium/fast/dom/Window/es52-globals-expected.txt: Added.
+* platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Added.
+* platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
+
 2012-06-27  W. James MacLean  wjmacl...@chromium.org
 
 [chromium] ScrollbarLayerChromium should support painting forward-track and back-track in different styles.


Added: trunk/LayoutTests/fast/dom/Window/es52-globals-expected.txt (0 => 121376)

--- trunk/LayoutTests/fast/dom/Window/es52-globals-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/Window/es52-globals-expected.txt	2012-06-27 22:00:55 UTC (rev 121376)
@@ -0,0 +1,16 @@
+PASS window.hasOwnProperty(Element) is true
+PASS window.hasOwnProperty(x) is true
+FAIL window.hasOwnProperty(y) should be false. Was true.
+PASS window.hasOwnProperty(f) is true
+PASS window.hasOwnProperty(div) is true
+FAIL window.hasOwnProperty(a) should be true. Was false.
+PASS Element is not undefined
+PASS x is 1
+FAIL y should be undefined. Was 2
+FAIL f should be undefined. Was [object Window]
+FAIL div should be undefined. Was [object HTMLDivElement]
+PASS a is undefined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/Window/es52-globals.html (0 => 121376)

--- trunk/LayoutTests/fast/dom/Window/es52-globals.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/Window/es52-globals.html	2012-06-27 22:00:55 UTC (rev 121376)
@@ -0,0 +1,43 @@
+!DOCTYPE html
+script src=""
+div id=div/div
+iframe name=f/iframe
+a href="" name=a/a
+script
+
+window.x = 1;
+Object.getPrototypeOf(window).y = 2;
+
+/script
+script
+
+shouldBeTrue('window.hasOwnProperty(Element)');
+shouldBeTrue('window.hasOwnProperty(x)');
+shouldBeFalse('window.hasOwnProperty(y)');

[webkit-changes] [121377] trunk/Source/WebCore

[commit-queue]

Title: [121377] trunk/Source/WebCore








Revision 121377
Author commit-qu...@webkit.org
Date 2012-06-27 15:13:53 -0700 (Wed, 27 Jun 2012)


Log Message
IndexedDB: make IDBKey immutable
https://bugs.webkit.org/show_bug.cgi?id=90016

Patch by Alec Flett alecfl...@chromium.org on 2012-06-27
Reviewed by Tony Chang.

Make all members of IDBKey const, so that this can be considered
an immutable, and thus safe to copy and/or stop ref-counting.

No new tests, existing tests show this works.

* Modules/indexeddb/IDBKey.cpp:
(WebCore::IDBKey::compare):
* Modules/indexeddb/IDBKey.h:
(WebCore::IDBKey::createInvalid):
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createString):
(WebCore::IDBKey::createDate):
(WebCore::IDBKey::createMultiEntryArray):
(WebCore::IDBKey::createArray):
(WebCore::IDBKey::date):
(WebCore::IDBKey::IDBKey):
(IDBKey):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBKey.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBKey.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (121376 => 121377)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 22:00:55 UTC (rev 121376)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 22:13:53 UTC (rev 121377)
@@ -1,3 +1,28 @@
+2012-06-27  Alec Flett  alecfl...@chromium.org
+
+IndexedDB: make IDBKey immutable
+https://bugs.webkit.org/show_bug.cgi?id=90016
+
+Reviewed by Tony Chang.
+
+Make all members of IDBKey const, so that this can be considered
+an immutable, and thus safe to copy and/or stop ref-counting.
+
+No new tests, existing tests show this works.
+
+* Modules/indexeddb/IDBKey.cpp:
+(WebCore::IDBKey::compare):
+* Modules/indexeddb/IDBKey.h:
+(WebCore::IDBKey::createInvalid):
+(WebCore::IDBKey::createNumber):
+(WebCore::IDBKey::createString):
+(WebCore::IDBKey::createDate):
+(WebCore::IDBKey::createMultiEntryArray):
+(WebCore::IDBKey::createArray):
+(WebCore::IDBKey::date):
+(WebCore::IDBKey::IDBKey):
+(IDBKey):
+
 2012-06-27  Erik Arvidsson  a...@chromium.org
 
 [V8] Improve variable resolution order on window


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKey.cpp (121376 => 121377)

--- trunk/Source/WebCore/Modules/indexeddb/IDBKey.cpp	2012-06-27 22:00:55 UTC (rev 121376)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKey.cpp	2012-06-27 22:13:53 UTC (rev 121377)
@@ -30,12 +30,6 @@
 
 namespace WebCore {
 
-IDBKey::IDBKey()
-: m_type(InvalidType)
-, m_sizeEstimate(kOverheadSize)
-{
-}
-
 IDBKey::~IDBKey()
 {
 }
@@ -75,8 +69,6 @@
 case StringType:
 return -codePointCompare(other-m_string, m_string);
 case DateType:
-return (m_date  other-m_date) ? -1 :
-(m_date  other-m_date) ? 1 : 0;
 case NumberType:
 return (m_number  other-m_number) ? -1 :
 (m_number  other- m_number) ? 1 : 0;


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKey.h (121376 => 121377)

--- trunk/Source/WebCore/Modules/indexeddb/IDBKey.h	2012-06-27 22:00:55 UTC (rev 121376)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKey.h	2012-06-27 22:13:53 UTC (rev 121377)
@@ -41,44 +41,29 @@
 
 static PassRefPtrIDBKey createInvalid()
 {
-RefPtrIDBKey idbKey = adoptRef(new IDBKey());
-idbKey-m_type = InvalidType;
-return idbKey.release();
+return adoptRef(new IDBKey());
 }
 
 static PassRefPtrIDBKey createNumber(double number)
 {
-RefPtrIDBKey idbKey = adoptRef(new IDBKey());
-idbKey-m_type = NumberType;
-idbKey-m_number = number;
-idbKey-m_sizeEstimate += sizeof(double);
-return idbKey.release();
+return adoptRef(new IDBKey(NumberType, number));
 }
 
 static PassRefPtrIDBKey createString(const String string)
 {
-RefPtrIDBKey idbKey = adoptRef(new IDBKey());
-idbKey-m_type = StringType;
-idbKey-m_string = string;
-idbKey-m_sizeEstimate += string.length() * sizeof(UChar);
-return idbKey.release();
+return adoptRef(new IDBKey(string));
 }
 
 static PassRefPtrIDBKey createDate(double date)
 {
-RefPtrIDBKey idbKey = adoptRef(new IDBKey());
-idbKey-m_type = DateType;
-idbKey-m_date = date;
-idbKey-m_sizeEstimate += sizeof(double);
-return idbKey.release();
+return adoptRef(new IDBKey(DateType, date));
 }
 
 static PassRefPtrIDBKey createMultiEntryArray(const KeyArray array)
 {
-RefPtrIDBKey idbKey = adoptRef(new IDBKey());
-idbKey-m_type = ArrayType;
-KeyArray result = idbKey-m_array;
+KeyArray result;
 
+size_t sizeEstimate = 0;
 for (size_t i = 0; i  array.size(); i++) {
 if (!array[i]-isValid())
 continue;
@@ -92,23 +77,21 @@
 }
 if (!skip) {
 result.append(array[i]);
-

[webkit-changes] [121378] trunk/Source/WebCore

[jamesr]

Title: [121378] trunk/Source/WebCore








Revision 121378
Author jam...@google.com
Date 2012-06-27 15:16:49 -0700 (Wed, 27 Jun 2012)


Log Message
[chromium] Delete unused includes and forward declarations from compositor code
https://bugs.webkit.org/show_bug.cgi?id=90102

Reviewed by Adrienne Walker.

* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/ShaderChromium.h:
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp
trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp
trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/ShaderChromium.h
trunk/Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (121377 => 121378)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 22:13:53 UTC (rev 121377)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 22:16:49 UTC (rev 121378)
@@ -1,3 +1,24 @@
+2012-06-27  James Robinson  jam...@chromium.org
+
+[chromium] Delete unused includes and forward declarations from compositor code
+https://bugs.webkit.org/show_bug.cgi?id=90102
+
+Reviewed by Adrienne Walker.
+
+* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
+* platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
+* platform/graphics/chromium/ContentLayerChromium.h:
+* platform/graphics/chromium/ImageLayerChromium.cpp:
+* platform/graphics/chromium/LayerChromium.cpp:
+* platform/graphics/chromium/LayerChromium.h:
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+* platform/graphics/chromium/ShaderChromium.h:
+* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::updateTiles):
+* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
+* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
+
 2012-06-27  Alec Flett  alecfl...@chromium.org
 
 IndexedDB: make IDBKey immutable


Modified: trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp (121377 => 121378)

--- trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp	2012-06-27 22:13:53 UTC (rev 121377)
+++ trunk/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp	2012-06-27 22:16:49 UTC (rev 121378)
@@ -32,7 +32,6 @@
 
 #include LayerPainterChromium.h
 #include PlatformColor.h
-#include PlatformContextSkia.h
 #include skia/ext/platform_canvas.h
 
 namespace WebCore {


Modified: trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp (121377 => 121378)

--- trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp	2012-06-27 22:13:53 UTC (rev 121377)
+++ trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp	2012-06-27 22:16:49 UTC (rev 121378)
@@ -30,9 +30,7 @@
 
 #include CanvasLayerTextureUpdater.h
 
-#include GraphicsContext.h
 #include LayerPainterChromium.h
-#include PlatformContextSkia.h
 #include SkCanvas.h
 #include SkPaint.h
 #include SkRect.h


Modified: trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h (121377 => 121378)

--- trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h	2012-06-27 22:13:53 UTC (rev 121377)
+++ trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h	2012-06-27 22:16:49 UTC (rev 121378)
@@ -40,7 +40,6 @@
 
 namespace WebCore {
 
-class GraphicsContext;
 class IntRect;
 class LayerTextureUpdater;
 


Modified: trunk/Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp (121377 => 121378)

--- 

[webkit-changes] [121379] trunk/Source/WebCore

[haraken]

Title: [121379] trunk/Source/WebCore








Revision 121379
Author hara...@chromium.org
Date 2012-06-27 15:51:47 -0700 (Wed, 27 Jun 2012)


Log Message
Make Element::elementRareData() and Element::ensureElementRareData() private
https://bugs.webkit.org/show_bug.cgi?id=90060

Reviewed by Andreas Kling.

This is a simple refactoring. Element::elementRareData() and
Element::ensureElementRareData() can be private methods.

No tests. No change in behavior.

* dom/Element.h:
(Element):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (121378 => 121379)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 22:16:49 UTC (rev 121378)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 22:51:47 UTC (rev 121379)
@@ -1,3 +1,18 @@
+2012-06-27  Kentaro Hara  hara...@chromium.org
+
+Make Element::elementRareData() and Element::ensureElementRareData() private
+https://bugs.webkit.org/show_bug.cgi?id=90060
+
+Reviewed by Andreas Kling.
+
+This is a simple refactoring. Element::elementRareData() and
+Element::ensureElementRareData() can be private methods.
+
+No tests. No change in behavior.
+
+* dom/Element.h:
+(Element):
+
 2012-06-27  James Robinson  jam...@chromium.org
 
 [chromium] Delete unused includes and forward declarations from compositor code


Modified: trunk/Source/WebCore/dom/Element.h (121378 => 121379)

--- trunk/Source/WebCore/dom/Element.h	2012-06-27 22:16:49 UTC (rev 121378)
+++ trunk/Source/WebCore/dom/Element.h	2012-06-27 22:51:47 UTC (rev 121379)
@@ -489,9 +489,6 @@
 QualifiedName m_tagName;
 virtual OwnPtrNodeRareData createRareData();
 
-ElementRareData* elementRareData() const;
-ElementRareData* ensureElementRareData();
-
 SpellcheckAttributeState spellcheckAttributeState() const;
 
 void updateNamedItemRegistration(const AtomicString oldName, const AtomicString newName);
@@ -500,6 +497,9 @@
 void unregisterNamedFlowContentNode();
 
 private:
+ElementRareData* elementRareData() const;
+ElementRareData* ensureElementRareData();
+
 mutable OwnPtrElementAttributeData m_attributeData;
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121382] trunk/Source/JavaScriptCore

[fpizlo]

Title: [121382] trunk/Source/_javascript_Core








Revision 121382
Author fpi...@apple.com
Date 2012-06-27 16:16:10 -0700 (Wed, 27 Jun 2012)


Log Message
DFG disassembly should be easier to read
https://bugs.webkit.org/show_bug.cgi?id=90106

Reviewed by Mark Hahnenberg.

Did a few things:

- Options::showDFGDisassembly now shows OSR exit disassembly as well.

- Phi node dumping doesn't attempt to do line wrapping since it just made the dump harder
  to read.

- DFG graph disassembly view shows a few additional node types that turn out to be
  essential for understanding OSR exits.

Put together, these changes reinforce the philosophy that anything needed for computing
OSR exit is just as important as the machine code itself. Of course, we still don't take
that philosophy to its full extreme - for example Phantom nodes are not dumped. We may
revisit that in the future.

* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
* assembler/LinkBuffer.h:
(JSC):
* dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::dump):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dumpBlockHeader):
* dfg/DFGNode.h:
(JSC::DFG::Node::willHaveCodeGenOrOSR):
* dfg/DFGOSRExitCompiler.cpp:
* jit/JIT.cpp:
(JSC::JIT::privateCompile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp
trunk/Source/_javascript_Core/assembler/LinkBuffer.h
trunk/Source/_javascript_Core/dfg/DFGDisassembler.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121381 => 121382)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-27 23:08:26 UTC (rev 121381)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-27 23:16:10 UTC (rev 121382)
@@ -1,3 +1,39 @@
+2012-06-27  Filip Pizlo  fpi...@apple.com
+
+DFG disassembly should be easier to read
+https://bugs.webkit.org/show_bug.cgi?id=90106
+
+Reviewed by Mark Hahnenberg.
+
+Did a few things:
+
+- Options::showDFGDisassembly now shows OSR exit disassembly as well.
+
+- Phi node dumping doesn't attempt to do line wrapping since it just made the dump harder
+  to read.
+
+- DFG graph disassembly view shows a few additional node types that turn out to be
+  essential for understanding OSR exits.
+
+Put together, these changes reinforce the philosophy that anything needed for computing
+OSR exit is just as important as the machine code itself. Of course, we still don't take
+that philosophy to its full extreme - for example Phantom nodes are not dumped. We may
+revisit that in the future.
+
+* assembler/LinkBuffer.cpp:
+(JSC::LinkBuffer::finalizeCodeWithDisassembly):
+* assembler/LinkBuffer.h:
+(JSC):
+* dfg/DFGDisassembler.cpp:
+(JSC::DFG::Disassembler::dump):
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::dumpBlockHeader):
+* dfg/DFGNode.h:
+(JSC::DFG::Node::willHaveCodeGenOrOSR):
+* dfg/DFGOSRExitCompiler.cpp:
+* jit/JIT.cpp:
+(JSC::JIT::privateCompile):
+
 2012-06-25  Mark Hahnenberg  mhahnenb...@apple.com
 
 JSLock should be per-JSGlobalData


Modified: trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp (121381 => 121382)

--- trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp	2012-06-27 23:08:26 UTC (rev 121381)
+++ trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp	2012-06-27 23:16:10 UTC (rev 121382)
@@ -41,7 +41,7 @@
 
 LinkBuffer::CodeRef LinkBuffer::finalizeCodeWithDisassembly(const char* format, ...)
 {
-ASSERT(Options::showDisassembly);
+ASSERT(Options::showDisassembly || Options::showDFGDisassembly);
 
 CodeRef result = finalizeCodeWithoutDisassembly();
 


Modified: trunk/Source/_javascript_Core/assembler/LinkBuffer.h (121381 => 121382)

--- trunk/Source/_javascript_Core/assembler/LinkBuffer.h	2012-06-27 23:08:26 UTC (rev 121381)
+++ trunk/Source/_javascript_Core/assembler/LinkBuffer.h	2012-06-27 23:16:10 UTC (rev 121382)
@@ -257,6 +257,11 @@
 #endif
 };
 
+#define FINALIZE_CODE_IF(condition, linkBufferReference, dataLogArgumentsForHeading)  \
+(UNLIKELY((condition))  \
+ ? ((linkBufferReference).finalizeCodeWithDisassembly dataLogArgumentsForHeading) \
+ : (linkBufferReference).finalizeCodeWithoutDisassembly())
+
 // Use this to finalize code, like so:
 //
 // CodeRef code = FINALIZE_CODE(linkBuffer, (my super thingy number %d, number));
@@ -274,9 +279,7 @@
 // is true, so you can hide expensive disassembly-only computations inside there.
 
 #define FINALIZE_CODE(linkBufferReference, dataLogArgumentsForHeading)  \
-(UNLIKELY(Options::showDisassembly) 

[webkit-changes] [121383] trunk/LayoutTests

[hclam]

Title: [121383] trunk/LayoutTests








Revision 121383
Author hc...@chromium.org
Date 2012-06-27 16:27:48 -0700 (Wed, 27 Jun 2012)


Log Message
[chromium] Rebase image mismatch caused by 121371.

Rebase test results for:
platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html

Not reviewed.

* platform/chromium-mac-snowleopard/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac/platform/chromium/compositing/scrollbars/
trunk/LayoutTests/platform/chromium-mac/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/compositing/scrollbars/
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png
trunk/LayoutTests/platform/chromium-win/platform/chromium/compositing/scrollbars/
trunk/LayoutTests/platform/chromium-win/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (121382 => 121383)

--- trunk/LayoutTests/ChangeLog	2012-06-27 23:16:10 UTC (rev 121382)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 23:27:48 UTC (rev 121383)
@@ -1,3 +1,16 @@
+2012-06-27  Alpha Lam  hc...@chromium.org
+
+[chromium] Rebase image mismatch caused by 121371.
+
+Rebase test results for:
+platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html
+
+Not reviewed.
+
+* platform/chromium-mac-snowleopard/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
+* platform/chromium-mac/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
+* platform/chromium-win/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
+
 2012-06-27  Tony Chang  t...@chromium.org
 
 Split flex into flex-grow/flex-shrink/flex-basis


Added: trunk/LayoutTests/platform/chromium-mac/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-win/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121384] trunk/Tools

[dpranke]

Title: [121384] trunk/Tools








Revision 121384
Author dpra...@chromium.org
Date 2012-06-27 16:49:47 -0700 (Wed, 27 Jun 2012)


Log Message
nrwt: default timeout for debug bots broke in r121363
https://bugs.webkit.org/show_bug.cgi?id=90112

Unreviewed, build fix.

I forgot to account for release and debug having different
default values :(.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.default_test_timeout_ms):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort):
(WebKitPort.default_test_timeout_ms):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitPortUnitTests.test_default_options):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (121383 => 121384)

--- trunk/Tools/ChangeLog	2012-06-27 23:27:48 UTC (rev 121383)
+++ trunk/Tools/ChangeLog	2012-06-27 23:49:47 UTC (rev 121384)
@@ -1,5 +1,23 @@
 2012-06-27  Dirk Pranke  dpra...@chromium.org
 
+nrwt: default timeout for debug bots broke in r121363
+https://bugs.webkit.org/show_bug.cgi?id=90112
+
+Unreviewed, build fix.
+
+I forgot to account for release and debug having different
+default values :(.
+
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumPort.default_test_timeout_ms):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitPort):
+(WebKitPort.default_test_timeout_ms):
+* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+(WebKitPortUnitTests.test_default_options):
+
+2012-06-27  Dirk Pranke  dpra...@chromium.org
+
 webkitpy: fix a couple of issues running under cygwin
 https://bugs.webkit.org/show_bug.cgi?id=90035
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (121383 => 121384)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-06-27 23:27:48 UTC (rev 121383)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-06-27 23:49:47 UTC (rev 121384)
@@ -52,7 +52,6 @@
 class ChromiumPort(WebKitPort):
 Abstract base class for Chromium implementations of the Port class.
 pixel_tests_option_default = True
-time_out_ms_option_default = 6 * 1000
 
 ALL_SYSTEMS = (
 ('leopard', 'x86'),
@@ -113,6 +112,9 @@
 # All sub-classes override this, but we need an initial value for testing.
 self._chromium_base_dir_path = None
 
+def default_test_timeout_ms(self):
+return 6 * 1000
+
 def _check_file_exists(self, path_to_file, file_description,
override_step=None, logging=True):
 Verify the file is present where expected or log an error.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (121383 => 121384)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-06-27 23:27:48 UTC (rev 121383)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-06-27 23:49:47 UTC (rev 121384)
@@ -52,16 +52,20 @@
 
 class WebKitPort(Port):
 pixel_tests_option_default = False  # FIXME: Disable until they are run by default on build.webkit.org.
-time_out_ms_option_default = 35 * 1000
 
 def __init__(self, host, port_name=None, **kwargs):
 Port.__init__(self, host, port_name=port_name, **kwargs)
 self.set_option_default(pixel_tests, self.pixel_tests_option_default)
 
-# FIXME: --guard-malloc is only supported on Mac, so this logic should be in mac.py.
+def default_test_timeout_ms(self):
 if self.get_option('guard_malloc'):
-self.time_out_ms_option_default = 350 * 1000
-self.set_option_default(time_out_ms, self.time_out_ms_option_default)
+# FIXME: --guard-malloc is only supported on Mac, so this logic should be in mac.py.
+return 350 * 1000
+if self.get_option.configuration == 'Debug':
+# FIXME: the generic code in run_webkit_tests.py multiplies this by 2 :(.
+# We want to use the same timeout for both release and debug.
+return 17.5 * 1000
+return 35 * 1000
 
 def driver_name(self):
 if self.get_option('webkit_test_runner'):


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (121383 => 121384)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py	2012-06-27 23:27:48 UTC (rev 121383)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py	2012-06-27 23:49:47 UTC (rev 121384)
@@ -66,16 +66,14 @@
 class WebKitPortUnitTests(unittest.TestCase):
 def test_default_options(self):
 # The WebKit ports override new-run-webkit-test default options.
-options = MockOptions(pixel_tests=None, time_out_ms=None)
+options = MockOptions(pixel_tests=None)
 port = WebKitPort(MockSystemHost(), 

[webkit-changes] [121385] trunk/LayoutTests

[jpfau]

Title: [121385] trunk/LayoutTests








Revision 121385
Author jp...@apple.com
Date 2012-06-27 16:50:13 -0700 (Wed, 27 Jun 2012)


Log Message
[Mac] Fix test expectation introduced in r121299

Unreviewed.

* platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (121384 => 121385)

--- trunk/LayoutTests/ChangeLog	2012-06-27 23:49:47 UTC (rev 121384)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 23:50:13 UTC (rev 121385)
@@ -1,3 +1,11 @@
+2012-06-27  Jeffrey Pfau  jp...@apple.com
+
+[Mac] Fix test expectation introduced in r121299
+
+Unreviewed.
+
+* platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
+
 2012-06-27  Alpha Lam  hc...@chromium.org
 
 [chromium] Rebase image mismatch caused by 121371.


Modified: trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt (121384 => 121385)

--- trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt	2012-06-27 23:49:47 UTC (rev 121384)
+++ trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt	2012-06-27 23:50:13 UTC (rev 121385)
@@ -1,4 +1,5 @@
-This test checks that markers are correct when auto correcting in the blockquote. If you type n and  , there should be blue dots under information, but is off by one.
+This test checks that markers are correct when auto correcting in the blockquote. If you type n and  , there should be blue dots under information, but is off by one. 
+Note, this test can fail due to user specific spell checking data. If the user has previously dismissed 'notational' as the correct spelling of 'notationl' several times, the spell checker will not provide 'information' as a suggestion anymore. To fix this, remove all files in ~/Library/Spelling.
 
 PASS internals.hasAutocorrectedMarker(document, 0, 1) is true
 PASS successfullyParsed is true






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121386] trunk/Source/WebCore

[commit-queue]

Title: [121386] trunk/Source/WebCore








Revision 121386
Author commit-qu...@webkit.org
Date 2012-06-27 16:53:16 -0700 (Wed, 27 Jun 2012)


Log Message
HTMLFieldSetElement::m_documentVersion is not initialized
https://bugs.webkit.org/show_bug.cgi?id=90038

Patch by Rakesh KN rakesh...@motorola.com on 2012-06-27
Reviewed by Kent Tamura.

Initialised m_documentVersion member as HTMLFieldSetElement::elements can return an wrong collection.

Covered by existing tests.

* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
Initialised m_documentVersion.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFieldSetElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121385 => 121386)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 23:50:13 UTC (rev 121385)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 23:53:16 UTC (rev 121386)
@@ -1,3 +1,18 @@
+2012-06-27  Rakesh KN  rakesh...@motorola.com
+
+HTMLFieldSetElement::m_documentVersion is not initialized
+https://bugs.webkit.org/show_bug.cgi?id=90038
+
+Reviewed by Kent Tamura.
+
+Initialised m_documentVersion member as HTMLFieldSetElement::elements can return an wrong collection.
+
+Covered by existing tests.
+
+* html/HTMLFieldSetElement.cpp:
+(WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
+Initialised m_documentVersion.
+
 2012-06-25  Mark Hahnenberg  mhahnenb...@apple.com
 
 JSLock should be per-JSGlobalData


Modified: trunk/Source/WebCore/html/HTMLFieldSetElement.cpp (121385 => 121386)

--- trunk/Source/WebCore/html/HTMLFieldSetElement.cpp	2012-06-27 23:50:13 UTC (rev 121385)
+++ trunk/Source/WebCore/html/HTMLFieldSetElement.cpp	2012-06-27 23:53:16 UTC (rev 121386)
@@ -38,6 +38,7 @@
 
 inline HTMLFieldSetElement::HTMLFieldSetElement(const QualifiedName tagName, Document* document, HTMLFormElement* form)
 : HTMLFormControlElement(tagName, document, form)
+, m_documentVersion(0)
 {
 ASSERT(hasTagName(fieldsetTag));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121388] trunk

[dcheng]

Title: [121388] trunk








Revision 121388
Author dch...@chromium.org
Date 2012-06-27 17:09:03 -0700 (Wed, 27 Jun 2012)


Log Message
Fix crash in Frame::nodeImage.
https://bugs.webkit.org/show_bug.cgi?id=89911

Reviewed by Abhishek Arya.

Source/WebCore:

We were caching a pointer to a RenderObject and then calling updateLayout(). Instead, we
need to get a pointer to the RenderObject again after updateLayout().

Test: fast/events/drag-display-none-element.html

* page/Frame.cpp:
(WebCore::Frame::nodeImage):
* page/mac/FrameMac.mm:
(WebCore::Frame::snapshotDragImage):
(WebCore::Frame::nodeImage):

LayoutTests:

* fast/events/drag-display-none-element-expected.txt: Added.
* fast/events/drag-display-none-element.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/page/mac/FrameMac.mm
trunk/Source/WebCore/page/win/FrameCGWin.cpp


Added Paths

trunk/LayoutTests/fast/events/drag-display-none-element-expected.txt
trunk/LayoutTests/fast/events/drag-display-none-element.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121387 => 121388)

--- trunk/LayoutTests/ChangeLog	2012-06-28 00:04:32 UTC (rev 121387)
+++ trunk/LayoutTests/ChangeLog	2012-06-28 00:09:03 UTC (rev 121388)
@@ -1,3 +1,13 @@
+2012-06-27  Daniel Cheng  dch...@chromium.org
+
+Fix crash in Frame::nodeImage.
+https://bugs.webkit.org/show_bug.cgi?id=89911
+
+Reviewed by Abhishek Arya.
+
+* fast/events/drag-display-none-element-expected.txt: Added.
+* fast/events/drag-display-none-element.html: Added.
+
 2012-06-27  Tony Chang  t...@chromium.org
 
 Unreviewed, rolling out r121380.


Added: trunk/LayoutTests/fast/events/drag-display-none-element-expected.txt (0 => 121388)

--- trunk/LayoutTests/fast/events/drag-display-none-element-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/drag-display-none-element-expected.txt	2012-06-28 00:09:03 UTC (rev 121388)
@@ -0,0 +1,2 @@
+To test, try dragging this div around. It shouldn't crash, and PASS should appear below when you end the drag.
+PASS
Property changes on: trunk/LayoutTests/fast/events/drag-display-none-element-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/events/drag-display-none-element.html (0 => 121388)

--- trunk/LayoutTests/fast/events/drag-display-none-element.html	(rev 0)
+++ trunk/LayoutTests/fast/events/drag-display-none-element.html	2012-06-28 00:09:03 UTC (rev 121388)
@@ -0,0 +1,39 @@
+!DOCTYPE html
+html
+head
+style
+#dragme:-webkit-drag
+{
+display: none;
+}
+/style
+script
+function runTest()
+{
+var dragme = document.getElementById('dragme');
+dragme.addEventListener('dragend', function () {
+if (window.testRunner)
+testRunner.notifyDone();
+document.getElementById('console').appendChild(document.createTextNode('PASS'));
+});
+
+if (!window.testRunner)
+return;
+
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+
+eventSender.mouseMoveTo(dragme.offsetLeft + dragme.offsetWidth / 2, dragme.offsetTop + dragme.offsetHeight / 2);
+eventSender.mouseDown();
+eventSender.leapForward(100);
+eventSender.mouseMoveTo(0, 0);
+eventSender.mouseUp();
+}
+window.addEventListener('load', runTest);
+/script
+/head
+body
+div id=dragme draggable=trueTo test, try dragging this div around. It shouldn't crash, and PASS should appear below when you end the drag./div
+div id=console/div
+/body
+/html
Property changes on: trunk/LayoutTests/fast/events/drag-display-none-element.html
___


Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (121387 => 121388)

--- trunk/Source/WebCore/ChangeLog	2012-06-28 00:04:32 UTC (rev 121387)
+++ trunk/Source/WebCore/ChangeLog	2012-06-28 00:09:03 UTC (rev 121388)
@@ -1,3 +1,21 @@
+2012-06-27  Daniel Cheng  dch...@chromium.org
+
+Fix crash in Frame::nodeImage.
+https://bugs.webkit.org/show_bug.cgi?id=89911
+
+Reviewed by Abhishek Arya.
+
+We were caching a pointer to a RenderObject and then calling updateLayout(). Instead, we
+need to get a pointer to the RenderObject again after updateLayout().
+
+Test: fast/events/drag-display-none-element.html
+
+* page/Frame.cpp:
+(WebCore::Frame::nodeImage):
+* page/mac/FrameMac.mm:
+(WebCore::Frame::snapshotDragImage):
+(WebCore::Frame::nodeImage):
+
 2012-06-27  Tony Chang  t...@chromium.org
 
 Unreviewed, rolling out r121380.


Modified: trunk/Source/WebCore/page/Frame.cpp (121387 => 121388)

--- trunk/Source/WebCore/page/Frame.cpp	2012-06-28 00:04:32 UTC (rev 121387)
+++ trunk/Source/WebCore/page/Frame.cpp	2012-06-28 00:09:03 UTC (rev 121388)
@@ -1047,38 +1047,39 @@
 
 #if !PLATFORM(MAC)  

[webkit-changes] [121389] trunk/LayoutTests

[hclam]

Title: [121389] trunk/LayoutTests








Revision 121389
Author hc...@chromium.org
Date 2012-06-27 17:32:02 -0700 (Wed, 27 Jun 2012)


Log Message
[chromium] Rebase image mismatch caused by 121371.

Rebase test results for:
platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html

Not reviewed.

* platform/chromium-linux/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/scrollbars/
trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (121388 => 121389)

--- trunk/LayoutTests/ChangeLog	2012-06-28 00:09:03 UTC (rev 121388)
+++ trunk/LayoutTests/ChangeLog	2012-06-28 00:32:02 UTC (rev 121389)
@@ -1,3 +1,14 @@
+2012-06-27  Alpha Lam  hc...@chromium.org
+
+[chromium] Rebase image mismatch caused by 121371.
+
+Rebase test results for:
+platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html
+
+Not reviewed.
+
+* platform/chromium-linux/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
+
 2012-06-27  Daniel Cheng  dch...@chromium.org
 
 Fix crash in Frame::nodeImage.


Added: trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121390] trunk/Tools

[dpranke]

Title: [121390] trunk/Tools








Revision 121390
Author dpra...@chromium.org
Date 2012-06-27 17:48:05 -0700 (Wed, 27 Jun 2012)


Log Message
Fix typo in r121384 :(

Unreviewed, build fix.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort.default_test_timeout_ms):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (121389 => 121390)

--- trunk/Tools/ChangeLog	2012-06-28 00:32:02 UTC (rev 121389)
+++ trunk/Tools/ChangeLog	2012-06-28 00:48:05 UTC (rev 121390)
@@ -1,5 +1,14 @@
 2012-06-27  Dirk Pranke  dpra...@chromium.org
 
+Fix typo in r121384 :(
+
+Unreviewed, build fix.
+
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitPort.default_test_timeout_ms):
+
+2012-06-27  Dirk Pranke  dpra...@chromium.org
+
 nrwt: default timeout for debug bots broke in r121363
 https://bugs.webkit.org/show_bug.cgi?id=90112
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (121389 => 121390)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-06-28 00:32:02 UTC (rev 121389)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-06-28 00:48:05 UTC (rev 121390)
@@ -61,7 +61,7 @@
 if self.get_option('guard_malloc'):
 # FIXME: --guard-malloc is only supported on Mac, so this logic should be in mac.py.
 return 350 * 1000
-if self.get_option.configuration == 'Debug':
+if self.get_option('configuration') == 'Debug':
 # FIXME: the generic code in run_webkit_tests.py multiplies this by 2 :(.
 # We want to use the same timeout for both release and debug.
 return 17.5 * 1000






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121391] trunk

[fpizlo]

Title: [121391] trunk








Revision 121391
Author fpi...@apple.com
Date 2012-06-27 17:49:55 -0700 (Wed, 27 Jun 2012)


Log Message
_javascript_ SHA-512 gives wrong hash on second and subsequent runs unless Web Inspector _javascript_ Debugging is on
https://bugs.webkit.org/show_bug.cgi?id=90053
rdar://problem/11764613

Source/_javascript_Core: 

Reviewed by Mark Hahnenberg.

The problem is that the code was assuming that the recovery should be Undefined if the source of
the SetLocal was !shouldGenerate(). But that's wrong, since the DFG optimizer may skip around a
UInt32ToNumber node (hence making it !shouldGenerate()) and keep the source of that node alive.
In that case we should base the recovery on the source of the UInt32ToNumber. The logic for this
was already in place but the fast check for !shouldGenerate() broke it.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

LayoutTests: 

Reviewed by Mark Hahnenberg.

* fast/js/dfg-uint32-to-number-skip-then-exit-expected.txt: Added.
* fast/js/dfg-uint32-to-number-skip-then-exit.html: Added.
* fast/js/script-tests/dfg-uint32-to-number-skip-then-exit.js: Added.
(foo):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp


Added Paths

trunk/LayoutTests/fast/js/dfg-uint32-to-number-skip-then-exit-expected.txt
trunk/LayoutTests/fast/js/dfg-uint32-to-number-skip-then-exit.html
trunk/LayoutTests/fast/js/script-tests/dfg-uint32-to-number-skip-then-exit.js




Diff

Modified: trunk/LayoutTests/ChangeLog (121390 => 121391)

--- trunk/LayoutTests/ChangeLog	2012-06-28 00:48:05 UTC (rev 121390)
+++ trunk/LayoutTests/ChangeLog	2012-06-28 00:49:55 UTC (rev 121391)
@@ -1,3 +1,16 @@
+2012-06-27  Filip Pizlo  fpi...@apple.com
+
+_javascript_ SHA-512 gives wrong hash on second and subsequent runs unless Web Inspector _javascript_ Debugging is on
+https://bugs.webkit.org/show_bug.cgi?id=90053
+rdar://problem/11764613
+
+Reviewed by Mark Hahnenberg.
+
+* fast/js/dfg-uint32-to-number-skip-then-exit-expected.txt: Added.
+* fast/js/dfg-uint32-to-number-skip-then-exit.html: Added.
+* fast/js/script-tests/dfg-uint32-to-number-skip-then-exit.js: Added.
+(foo):
+
 2012-06-27  Alpha Lam  hc...@chromium.org
 
 [chromium] Rebase image mismatch caused by 121371.


Added: trunk/LayoutTests/fast/js/dfg-uint32-to-number-skip-then-exit-expected.txt (0 => 121391)

--- trunk/LayoutTests/fast/js/dfg-uint32-to-number-skip-then-exit-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/js/dfg-uint32-to-number-skip-then-exit-expected.txt	2012-06-28 00:49:55 UTC (rev 121391)
@@ -0,0 +1,209 @@
+This tests that a skipped conversion of uint32 to number does not confuse OSR exit into thinking that the conversion is dead.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS foo(i, 1, o) is 42
+PASS foo(i, 1, o) is 42
+PASS foo(i, 1, o) is 43
+PASS foo(i, 1, o) is 43
+PASS foo(i, 1, o) is 44
+PASS foo(i, 1, o) is 44
+PASS foo(i, 1, o) is 45
+PASS foo(i, 1, o) is 45
+PASS foo(i, 1, o) is 46
+PASS foo(i, 1, o) is 46
+PASS foo(i, 1, o) is 47
+PASS foo(i, 1, o) is 47
+PASS foo(i, 1, o) is 48
+PASS foo(i, 1, o) is 48
+PASS foo(i, 1, o) is 49
+PASS foo(i, 1, o) is 49
+PASS foo(i, 1, o) is 50
+PASS foo(i, 1, o) is 50
+PASS foo(i, 1, o) is 51
+PASS foo(i, 1, o) is 51
+PASS foo(i, 1, o) is 52
+PASS foo(i, 1, o) is 52
+PASS foo(i, 1, o) is 53
+PASS foo(i, 1, o) is 53
+PASS foo(i, 1, o) is 54
+PASS foo(i, 1, o) is 54
+PASS foo(i, 1, o) is 55
+PASS foo(i, 1, o) is 55
+PASS foo(i, 1, o) is 56
+PASS foo(i, 1, o) is 56
+PASS foo(i, 1, o) is 57
+PASS foo(i, 1, o) is 57
+PASS foo(i, 1, o) is 58
+PASS foo(i, 1, o) is 58
+PASS foo(i, 1, o) is 59
+PASS foo(i, 1, o) is 59
+PASS foo(i, 1, o) is 60
+PASS foo(i, 1, o) is 60
+PASS foo(i, 1, o) is 61
+PASS foo(i, 1, o) is 61
+PASS foo(i, 1, o) is 62
+PASS foo(i, 1, o) is 62
+PASS foo(i, 1, o) is 63
+PASS foo(i, 1, o) is 63
+PASS foo(i, 1, o) is 64
+PASS foo(i, 1, o) is 64
+PASS foo(i, 1, o) is 65
+PASS foo(i, 1, o) is 65
+PASS foo(i, 1, o) is 66
+PASS foo(i, 1, o) is 66
+PASS foo(i, 1, o) is 67
+PASS foo(i, 1, o) is 67
+PASS foo(i, 1, o) is 68
+PASS foo(i, 1, o) is 68
+PASS foo(i, 1, o) is 69
+PASS foo(i, 1, o) is 69
+PASS foo(i, 1, o) is 70
+PASS foo(i, 1, o) is 70
+PASS foo(i, 1, o) is 71
+PASS foo(i, 1, o) is 71
+PASS foo(i, 1, o) is 72
+PASS foo(i, 1, o) is 72
+PASS foo(i, 1, o) is 73
+PASS foo(i, 1, o) is 73
+PASS foo(i, 1, o) is 74
+PASS foo(i, 1, o) is 74
+PASS foo(i, 1, o) is 75
+PASS foo(i, 1, o) is 75
+PASS foo(i, 1, o) is 76
+PASS foo(i, 1, o) is 76
+PASS foo(i, 1, o) is 77
+PASS foo(i, 1, o) is 77
+PASS foo(i, 1, o) is 78
+PASS foo(i, 1, o) is 78
+PASS foo(i, 1, o) is 79
+PASS foo(i, 1, o) is 79
+PASS foo(i, 1, o) is 80
+PASS foo(i, 1, o) is 80
+PASS foo(i, 1, o) is 81
+PASS foo(i, 1, o) is 81
+PASS foo(i, 1, 

[webkit-changes] [121392] trunk

[alexis . menard]

Title: [121392] trunk








Revision 121392
Author alexis.men...@openbossa.org
Date 2012-06-27 18:05:27 -0700 (Wed, 27 Jun 2012)


Log Message
Implement selectedOptions attribute of HTMLSelectElement.
https://bugs.webkit.org/show_bug.cgi?id=80631

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a new collection as a member of HTMLSelectElement which is
used to store the selected elements. Extend HTMLCollection to
support the new collection type needed by this feature. Make sure
that we invalidate the collection when the select state of an
option changes as the select state change does not trigger a dom
tree version change.

Reference : http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-select-selectedoptions

Test: fast/dom/HTMLSelectElement/select-selectedOptions.html

* html/CollectionType.h:
* html/HTMLCollection.cpp:
(WebCore::shouldIncludeChildren):
(WebCore::HTMLCollection::clearCache):
(WebCore):
(WebCore::HTMLCollection::isAcceptableElement):
* html/HTMLCollection.h:
(HTMLCollection):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setSelectedState):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectedOptions):
(WebCore):
(WebCore::HTMLSelectElement::invalidateSelectedItems):
(WebCore::HTMLSelectElement::setRecalcListItems):
* html/HTMLSelectElement.h:
(WebCore):
(HTMLSelectElement):
* html/HTMLSelectElement.idl:

LayoutTests:

New tests to cover the feature.

* fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
* fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
* fast/dom/htmlcollection-non-html-expected.txt:
* fast/dom/htmlcollection-non-html.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/htmlcollection-non-html-expected.txt
trunk/LayoutTests/fast/dom/htmlcollection-non-html.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/CollectionType.h
trunk/Source/WebCore/html/HTMLCollection.cpp
trunk/Source/WebCore/html/HTMLCollection.h
trunk/Source/WebCore/html/HTMLOptionElement.cpp
trunk/Source/WebCore/html/HTMLSelectElement.cpp
trunk/Source/WebCore/html/HTMLSelectElement.h
trunk/Source/WebCore/html/HTMLSelectElement.idl


Added Paths

trunk/LayoutTests/fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt
trunk/LayoutTests/fast/dom/HTMLSelectElement/select-selectedOptions.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121391 => 121392)

--- trunk/LayoutTests/ChangeLog	2012-06-28 00:49:55 UTC (rev 121391)
+++ trunk/LayoutTests/ChangeLog	2012-06-28 01:05:27 UTC (rev 121392)
@@ -1,3 +1,17 @@
+2012-06-27  Alexis Menard  alexis.men...@openbossa.org
+
+Implement selectedOptions attribute of HTMLSelectElement.
+https://bugs.webkit.org/show_bug.cgi?id=80631
+
+Reviewed by Ryosuke Niwa.
+
+New tests to cover the feature.
+
+* fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
+* fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
+* fast/dom/htmlcollection-non-html-expected.txt:
+* fast/dom/htmlcollection-non-html.html:
+
 2012-06-27  Filip Pizlo  fpi...@apple.com
 
 _javascript_ SHA-512 gives wrong hash on second and subsequent runs unless Web Inspector _javascript_ Debugging is on


Added: trunk/LayoutTests/fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt (0 => 121392)

--- trunk/LayoutTests/fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt	2012-06-28 01:05:27 UTC (rev 121392)
@@ -0,0 +1,51 @@
+
+1) Initial there is no selected options.
+PASS optionsLength is 2
+PASS selectedOptions.length is 0
+2) Select an option should update the selected options collection.
+PASS optionsLength is 2
+PASS selectedOptions.length is 1
+PASS selectedOptions[0].text is 'one'
+3) Select two options should update the selected options collection.
+PASS optionsLength is 2
+PASS selectedOptions.length is 2
+PASS selectedOptions[0].text is 'one'
+PASS selectedOptions[1].text is 'two'
+4) Adding a non selected option should not change the selected options collection.
+PASS optionsLength is 3
+PASS selectedOptions.length is 1
+PASS selectedOptions[0].text is 'one'
+5) Adding a selected option should change the selected options collection.
+PASS optionsLength is 4
+PASS selectedOptions.length is 2
+PASS selectedOptions[0].text is 'one'
+PASS selectedOptions[1].text is 'five'
+6) Unselect an option should update the selected options collection.
+PASS optionsLength is 4
+PASS selectedOptions.length is 1
+PASS selectedOptions[0].text is 'five'
+7) Remove an option unselected should not update the selected options collection.
+PASS optionsLength is 3
+PASS selectedOptions.length is 1
+PASS selectedOptions[0].text is 'five'
+8) Remove an option selected should update the selected options collection.
+PASS optionsLength is 2
+PASS 

[webkit-changes] [121393] trunk/Source

[commit-queue]

Title: [121393] trunk/Source








Revision 121393
Author commit-qu...@webkit.org
Date 2012-06-27 18:09:22 -0700 (Wed, 27 Jun 2012)


Log Message
Unreviewed, rolling out r121359.
http://trac.webkit.org/changeset/121359
https://bugs.webkit.org/show_bug.cgi?id=90115

Broke many inspector tests (Requested by jpfau on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-06-27

Source/_javascript_Core:

* interpreter/Interpreter.h:
(JSC::StackFrame::toString):

Source/WebCore:

* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121392 => 121393)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-28 01:05:27 UTC (rev 121392)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-28 01:09:22 UTC (rev 121393)
@@ -1,3 +1,14 @@
+2012-06-27  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r121359.
+http://trac.webkit.org/changeset/121359
+https://bugs.webkit.org/show_bug.cgi?id=90115
+
+Broke many inspector tests (Requested by jpfau on #webkit).
+
+* interpreter/Interpreter.h:
+(JSC::StackFrame::toString):
+
 2012-06-27  Filip Pizlo  fpi...@apple.com
 
 _javascript_ SHA-512 gives wrong hash on second and subsequent runs unless Web Inspector _javascript_ Debugging is on


Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.h (121392 => 121393)

--- trunk/Source/_javascript_Core/interpreter/Interpreter.h	2012-06-28 01:05:27 UTC (rev 121392)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.h	2012-06-28 01:09:22 UTC (rev 121393)
@@ -1,6 +1,5 @@
 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
- * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -40,7 +39,6 @@
 #include RegisterFile.h
 
 #include wtf/HashMap.h
-#include wtf/text/StringBuilder.h
 
 namespace JSC {
 
@@ -82,62 +80,46 @@
 UString sourceURL;
 UString toString(CallFrame* callFrame) const
 {
-StringBuilder traceBuild;
-String functionName = friendlyFunctionName(callFrame);
-String sourceURL = friendlySourceURL();
-traceBuild.append(functionName);
-if (!functionName.isEmpty()  !sourceURL.isEmpty())
-traceBuild.append('@');
-traceBuild.append(sourceURL);
-if (line  -1) {
-traceBuild.append(':');
-traceBuild.append(String::number(line));
-}
-return traceBuild.toString().impl();
-}
-String friendlySourceURL() const
-{
+bool hasSourceURLInfo = !sourceURL.isNull()  !sourceURL.isEmpty();
+bool hasLineInfo = line  -1;
 String traceLine;
+JSObject* stackFrameCallee = callee.get();
 
 switch (codeType) {
 case StackFrameEvalCode:
-case StackFrameFunctionCode:
-case StackFrameGlobalCode:
-if (!sourceURL.isEmpty())
-traceLine = sourceURL.impl();
+if (hasSourceURLInfo) {
+traceLine = hasLineInfo ? String::format(eval code@%s:%d, sourceURL.ascii().data(), line) 
+: String::format(eval code@%s, sourceURL.ascii().data());
+} else
+traceLine = String::format(eval code);
 break;
-case StackFrameNativeCode:
-traceLine = [native code];
+case StackFrameNativeCode: {
+if (callee) {
+UString functionName = getCalculatedDisplayName(callFrame, stackFrameCallee);
+traceLine = String::format(%s@[native code], functionName.ascii().data());
+} else
+traceLine = [native code];
 break;
 }
-return traceLine.isNull() ? emptyString() : traceLine;
-}
-String friendlyFunctionName(CallFrame* callFrame) const
-{
-String traceLine;
-JSObject* stackFrameCallee = callee.get();
-
-switch (codeType) {
-case StackFrameEvalCode:
-traceLine = eval code;
+case StackFrameFunctionCode: {
+UString functionName = getCalculatedDisplayName(callFrame, stackFrameCallee);
+if (hasSourceURLInfo) {
+traceLine = hasLineInfo ? String::format(%s@%s:%d, functionName.ascii().data(), sourceURL.ascii().data(), line)
+: 

[webkit-changes] [121394] trunk/Source/JavaScriptCore

[msaboff]

Title: [121394] trunk/Source/_javascript_Core








Revision 121394
Author msab...@apple.com
Date 2012-06-27 18:14:20 -0700 (Wed, 27 Jun 2012)


Log Message
[Win] jscore-tests flakey
https://bugs.webkit.org/show_bug.cgi?id=88118

Reviewed by Jessie Berlin.

jsDriver.pl on windows intermittently doesn't get the returned value from jsc,
instead it gets 126.  Added a new option to jsc (-x) which prints the exit
code before exiting.  jsDriver.pl uses this option on Windows and parses the
exit code output for the exit code, removing it before comparing the actual
and expected outputs.  Filed a follow on FIXME defect:
[WIN] Intermittent failure for jsc return value to propagate through jsDriver.pl
https://bugs.webkit.org/show_bug.cgi?id=90119

* jsc.cpp:
(CommandLine::CommandLine):
(CommandLine):
(printUsageStatement):
(parseArguments):
(jscmain):
* tests/mozilla/jsDriver.pl:
(execute_tests):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/tests/mozilla/jsDriver.pl




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121393 => 121394)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-28 01:09:22 UTC (rev 121393)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-28 01:14:20 UTC (rev 121394)
@@ -1,3 +1,27 @@
+2012-06-27  Michael Saboff  msab...@apple.com
+
+[Win] jscore-tests flakey
+https://bugs.webkit.org/show_bug.cgi?id=88118
+
+Reviewed by Jessie Berlin.
+
+jsDriver.pl on windows intermittently doesn't get the returned value from jsc,
+instead it gets 126.  Added a new option to jsc (-x) which prints the exit
+code before exiting.  jsDriver.pl uses this option on Windows and parses the
+exit code output for the exit code, removing it before comparing the actual
+and expected outputs.  Filed a follow on FIXME defect:
+[WIN] Intermittent failure for jsc return value to propagate through jsDriver.pl
+https://bugs.webkit.org/show_bug.cgi?id=90119
+
+* jsc.cpp:
+(CommandLine::CommandLine):
+(CommandLine):
+(printUsageStatement):
+(parseArguments):
+(jscmain):
+* tests/mozilla/jsDriver.pl:
+(execute_tests):
+
 2012-06-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r121359.


Modified: trunk/Source/_javascript_Core/jsc.cpp (121393 => 121394)

--- trunk/Source/_javascript_Core/jsc.cpp	2012-06-28 01:09:22 UTC (rev 121393)
+++ trunk/Source/_javascript_Core/jsc.cpp	2012-06-28 01:14:20 UTC (rev 121394)
@@ -117,11 +117,13 @@
 CommandLine()
 : interactive(false)
 , dump(false)
+, exitCode(false)
 {
 }
 
 bool interactive;
 bool dump;
+bool exitCode;
 VectorScript scripts;
 VectorUString arguments;
 };
@@ -611,6 +613,7 @@
 #if HAVE(SIGNAL_H)
 fprintf(stderr,   -s Installs signal handlers that exit on a crash (Unix platforms only)\n);
 #endif
+fprintf(stderr,   -x Output exit code before terminating\n);
 
 exit(help ? EXIT_SUCCESS : EXIT_FAILURE);
 }
@@ -649,6 +652,10 @@
 #endif
 continue;
 }
+if (!strcmp(arg, -x)) {
+options.exitCode = true;
+continue;
+}
 if (!strcmp(arg, --)) {
 ++i;
 break;
@@ -667,9 +674,9 @@
 
 int jscmain(int argc, char** argv)
 {
-
 RefPtrJSGlobalData globalData = JSGlobalData::create(ThreadStackTypeLarge, LargeHeap);
 JSLockHolder lock(globalData.get());
+int result;
 
 CommandLine options;
 parseArguments(argc, argv, options);
@@ -679,7 +686,12 @@
 if (options.interactive  success)
 runInteractive(globalObject);
 
-return success ? 0 : 3;
+result = success ? 0 : 3;
+
+if (options.exitCode)
+printf(jsc exiting %d\n, result);
+
+return result;
 }
 
 static bool fillBufferWithContentsOfFile(const UString fileName, Vectorchar buffer)


Modified: trunk/Source/_javascript_Core/tests/mozilla/jsDriver.pl (121393 => 121394)

--- trunk/Source/_javascript_Core/tests/mozilla/jsDriver.pl	2012-06-28 01:09:22 UTC (rev 121393)
+++ trunk/Source/_javascript_Core/tests/mozilla/jsDriver.pl	2012-06-28 01:14:20 UTC (rev 121394)
@@ -164,6 +164,7 @@
 my $failure_lines;
 my $bug_number;
 my $status_lines;
+my @jsc_exit_code;
 
 # user selected [Q]uit from ^C handler.
 if ($user_exit) {
@@ -177,7 +178,20 @@
 $shell_command = $opt_arch .  ;
 
 $shell_command .= xp_path($engine_command)  .  -s ;
-
+
+# FIXME: https://bugs.webkit.org/show_bug.cgi?id=90119
+# Sporadically on Windows, the exit code returned after close() in $?
+# is 126 (after the appropraite shifting, even though jsc exits with
+# 0 or 3). To work around this, a -x option was added to jsc that will
+# output the exit value right before exiting.  We parse that value and
+# 

[webkit-changes] [121395] trunk/Source

[charles . wei]

Title: [121395] trunk/Source








Revision 121395
Author charles@torchmobile.com.cn
Date 2012-06-27 18:58:22 -0700 (Wed, 27 Jun 2012)


Log Message
IndexedDB: should make the LevelDB persistant to the directory indicated in PageGroupSettings::indexedDBDataBasePath
https://bugs.webkit.org/show_bug.cgi?id=88338

Reviewed by David Levin.

Source/WebCore:

If the indexedDB runs in main thread it can access the GroupSettings via the document;
otherwise, we need to pass the page GroupSettings to the worker thread so that accessible
to the indexedDB running in WorkerContext.

* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
* workers/DedicatedWorkerThread.h:
(DedicatedWorkerThread):
* workers/DefaultSharedWorkerRepository.cpp:
(SharedWorkerProxy):
(WebCore::SharedWorkerProxy::groupSettings):
(WebCore):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
* workers/SharedWorkerThread.h:
(SharedWorkerThread):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WorkerThreadStartupData):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::groupSettings):
(WebCore):
* workers/WorkerThread.h:
(WorkerThread):

Source/WebKit/chromium:

* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::startWorkerContext):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp
trunk/Source/WebCore/workers/DedicatedWorkerThread.cpp
trunk/Source/WebCore/workers/DedicatedWorkerThread.h
trunk/Source/WebCore/workers/DefaultSharedWorkerRepository.cpp
trunk/Source/WebCore/workers/SharedWorkerThread.cpp
trunk/Source/WebCore/workers/SharedWorkerThread.h
trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp
trunk/Source/WebCore/workers/WorkerThread.cpp
trunk/Source/WebCore/workers/WorkerThread.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121394 => 121395)

--- trunk/Source/WebCore/ChangeLog	2012-06-28 01:14:20 UTC (rev 121394)
+++ trunk/Source/WebCore/ChangeLog	2012-06-28 01:58:22 UTC (rev 121395)
@@ -1,3 +1,43 @@
+2012-06-27  Charles Wei  charles@torchmobile.com.cn
+
+IndexedDB: should make the LevelDB persistant to the directory indicated in PageGroupSettings::indexedDBDataBasePath
+https://bugs.webkit.org/show_bug.cgi?id=88338
+
+Reviewed by David Levin.
+
+If the indexedDB runs in main thread it can access the GroupSettings via the document;
+otherwise, we need to pass the page GroupSettings to the worker thread so that accessible
+to the indexedDB running in WorkerContext.
+
+* Modules/indexeddb/IDBFactory.cpp:
+(WebCore::IDBFactory::open):
+* workers/DedicatedWorkerThread.cpp:
+(WebCore::DedicatedWorkerThread::create):
+(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
+* workers/DedicatedWorkerThread.h:
+(DedicatedWorkerThread):
+* workers/DefaultSharedWorkerRepository.cpp:
+(SharedWorkerProxy):
+(WebCore::SharedWorkerProxy::groupSettings):
+(WebCore):
+(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
+* workers/SharedWorkerThread.cpp:
+(WebCore::SharedWorkerThread::create):
+(WebCore::SharedWorkerThread::SharedWorkerThread):
+* workers/SharedWorkerThread.h:
+(SharedWorkerThread):
+* workers/WorkerMessagingProxy.cpp:
+(WebCore::WorkerMessagingProxy::startWorkerContext):
+* workers/WorkerThread.cpp:
+(WebCore::WorkerThreadStartupData::create):
+(WorkerThreadStartupData):
+(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
+(WebCore::WorkerThread::WorkerThread):
+(WebCore::WorkerThread::groupSettings):
+(WebCore):
+* workers/WorkerThread.h:
+(WorkerThread):
+
 2012-06-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r121359.


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp (121394 => 121395)

--- trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp	2012-06-28 01:14:20 UTC (rev 121394)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp	2012-06-28 01:58:22 UTC (rev 121395)
@@ -94,12 +94,14 @@
 return 0;
 Frame* frame = document-frame();
 RefPtrIDBRequest request = IDBRequest::create(context, 

[webkit-changes] [121397] trunk/Source/WebKit/chromium

[commit-queue]

Title: [121397] trunk/Source/WebKit/chromium








Revision 121397
Author commit-qu...@webkit.org
Date 2012-06-27 19:06:13 -0700 (Wed, 27 Jun 2012)


Log Message
[chromium] Improve keyboardEvent() so a web page could receive a DOM3 spec compliant keyboard event.
https://bugs.webkit.org/show_bug.cgi?id=89637

Patch by Yusuke Sato yusu...@chromium.org on 2012-06-27
Reviewed by Tony Chang.

This is a Gtk port of http://crrev.com/142209.

Normalizes event-state to make it Windows/Mac compatible. Since the
way of setting modifier mask on X is very different than Windows/Mac
as shown in http://crbug.com/127142#c8, the normalization is necessary.

* src/gtk/WebInputEventFactory.cpp:
(WebKit):
(WebKit::normalizeEventState):
(WebKit::WebInputEventFactory::keyboardEvent):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/gtk/WebInputEventFactory.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (121396 => 121397)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-06-28 02:03:24 UTC (rev 121396)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-06-28 02:06:13 UTC (rev 121397)
@@ -1,3 +1,21 @@
+2012-06-27  Yusuke Sato  yusu...@chromium.org
+
+[chromium] Improve keyboardEvent() so a web page could receive a DOM3 spec compliant keyboard event.
+https://bugs.webkit.org/show_bug.cgi?id=89637
+
+Reviewed by Tony Chang.
+
+This is a Gtk port of http://crrev.com/142209.
+
+Normalizes event-state to make it Windows/Mac compatible. Since the
+way of setting modifier mask on X is very different than Windows/Mac
+as shown in http://crbug.com/127142#c8, the normalization is necessary.
+
+* src/gtk/WebInputEventFactory.cpp:
+(WebKit):
+(WebKit::normalizeEventState):
+(WebKit::WebInputEventFactory::keyboardEvent):
+
 2012-06-27  James Robinson  jam...@chromium.org
 
 [chromium] Use SkColor in compositor internals


Modified: trunk/Source/WebKit/chromium/src/gtk/WebInputEventFactory.cpp (121396 => 121397)

--- trunk/Source/WebKit/chromium/src/gtk/WebInputEventFactory.cpp	2012-06-28 02:03:24 UTC (rev 121396)
+++ trunk/Source/WebKit/chromium/src/gtk/WebInputEventFactory.cpp	2012-06-28 02:06:13 UTC (rev 121397)
@@ -272,6 +272,39 @@
 return WebCore::windowsKeyCodeForKeyEvent(event-keyval);
 }
 
+// Normalizes event-state to make it Windows/Mac compatible. Since the way
+// of setting modifier mask on X is very different than Windows/Mac as shown
+// in http://crbug.com/127142#c8, the normalization is necessary.
+static guint normalizeEventState(const GdkEventKey* event)
+{
+guint mask = 0;
+switch (gdkEventToWindowsKeyCode(event)) {
+case WebCore::VKEY_CONTROL:
+case WebCore::VKEY_LCONTROL:
+case WebCore::VKEY_RCONTROL:
+mask = GDK_CONTROL_MASK;
+break;
+case WebCore::VKEY_SHIFT:
+case WebCore::VKEY_LSHIFT:
+case WebCore::VKEY_RSHIFT:
+mask = GDK_SHIFT_MASK;
+break;
+case WebCore::VKEY_MENU:
+case WebCore::VKEY_LMENU:
+case WebCore::VKEY_RMENU:
+mask = GDK_MOD1_MASK;
+break;
+case WebCore::VKEY_CAPITAL:
+mask = GDK_LOCK_MASK;
+break;
+default:
+return event-state;
+}
+if (event-type == GDK_KEY_PRESS)
+return event-state | mask;
+return event-state  ~mask;
+}
+
 // Gets the corresponding control character of a specified key code. See:
 // http://en.wikipedia.org/wiki/Control_characters
 // We emulate Windows behavior here.
@@ -325,7 +358,7 @@
 WebKeyboardEvent result;
 
 result.timeStampSeconds = gdkEventTimeToWebEventTime(event-time);
-result.modifiers = gdkStateToWebEventModifiers(event-state);
+result.modifiers = gdkStateToWebEventModifiers(normalizeEventState(event));
 
 switch (event-type) {
 case GDK_KEY_RELEASE:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121398] trunk/Source/WebKit

[commit-queue]

Title: [121398] trunk/Source/WebKit








Revision 121398
Author commit-qu...@webkit.org
Date 2012-06-27 19:17:40 -0700 (Wed, 27 Jun 2012)


Log Message
Source/WebKit: [EFL] Add support for Unit Tests, based on the gtest library.
https://bugs.webkit.org/show_bug.cgi?id=68509

Patch by Krzysztof Czech k.cz...@samsung.com on 2012-06-27
Reviewed by Chang Shu.

Add configuration for building gtest library, testing framework and unit tests.

* PlatformEfl.cmake:

Source/WebKit/efl: [EFL] Implementation of testing framework and unit tests for WebKit-EFL port.
https://bugs.webkit.org/show_bug.cgi?id=68509

Patch by Krzysztof Czech k.cz...@samsung.com on 2012-06-27
Reviewed by Chang Shu.

Testing framework is based on gtest library. Gtest library is part of the WebKit project. Framework is devided into base part and view part.
Base part takes care of efl initialization, defines test macros and prepares test to run. View part is a context of each test.

* tests/UnitTestUtils/EWKTestBase.cpp: Added.
(EWKUnitTests):
(EWKUnitTests::EWKTestBase::init):
(EWKUnitTests::EWKTestBase::shutdown):
(EWKUnitTests::EWKTestBase::shutdownAll):
(EWKUnitTests::EWKTestBase::startTest):
(EWKUnitTests::EWKTestBase::endTest):
(EWKUnitTests::EWKTestBase::createTest):
(EWKUnitTests::EWKTestBase::runTest):
* tests/UnitTestUtils/EWKTestBase.h: Added.
(EWKUnitTests):
(EWKTestBase):
* tests/UnitTestUtils/EWKTestConfig.h: Added.
(Config):
* tests/UnitTestUtils/EWKTestView.cpp: Added.
(EWKUnitTests):
(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
(EWKUnitTests::EWKTestEcoreEvas::evas):
(EWKUnitTests::EWKTestEcoreEvas::show):
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init):
(EWKUnitTests::EWKTestView::show):
(EWKUnitTests::EWKTestView::mainFrame):
(EWKUnitTests::EWKTestView::evas):
(EWKUnitTests::EWKTestView::bindEvents):
* tests/UnitTestUtils/EWKTestView.h: Added.
(EWKUnitTests):
(EWKTestEcoreEvas):
(EWKTestView):
(EWKUnitTests::EWKTestView::webView):
* tests/resources/default_test_page.html: Added.
* tests/test_ewk_view.cpp: Added.
(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):
* tests/test_runner.cpp: Added.
(parseCustomArguments):
(main):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformEfl.cmake
trunk/Source/WebKit/efl/ChangeLog


Added Paths

trunk/Source/WebKit/efl/tests/
trunk/Source/WebKit/efl/tests/UnitTestUtils/
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.h
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestConfig.h
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h
trunk/Source/WebKit/efl/tests/resources/
trunk/Source/WebKit/efl/tests/resources/default_test_page.html
trunk/Source/WebKit/efl/tests/test_ewk_view.cpp
trunk/Source/WebKit/efl/tests/test_runner.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (121397 => 121398)

--- trunk/Source/WebKit/ChangeLog	2012-06-28 02:06:13 UTC (rev 121397)
+++ trunk/Source/WebKit/ChangeLog	2012-06-28 02:17:40 UTC (rev 121398)
@@ -1,3 +1,14 @@
+2012-06-27  Krzysztof Czech  k.cz...@samsung.com
+
+[EFL] Add support for Unit Tests, based on the gtest library.
+https://bugs.webkit.org/show_bug.cgi?id=68509
+
+Reviewed by Chang Shu.
+
+Add configuration for building gtest library, testing framework and unit tests.
+
+* PlatformEfl.cmake:
+
 2012-06-26  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt][Win] Symbols are not exported in QtWebKit5.dll


Modified: trunk/Source/WebKit/PlatformEfl.cmake (121397 => 121398)

--- trunk/Source/WebKit/PlatformEfl.cmake	2012-06-28 02:06:13 UTC (rev 121397)
+++ trunk/Source/WebKit/PlatformEfl.cmake	2012-06-28 02:17:40 UTC (rev 121398)
@@ -293,3 +293,83 @@
 
 INSTALL(FILES ${WebKit_THEME}
 DESTINATION ${DATA_INSTALL_DIR}/themes)
+
+INCLUDE_DIRECTORIES(${THIRDPARTY_DIR}/gtest
+${THIRDPARTY_DIR}/gtest/include
+)
+
+SET(GTEST_SOURCES ${THIRDPARTY_DIR}/gtest/src)
+
+ADD_LIBRARY(gtest
+${GTEST_SOURCES}/gtest.cc
+${GTEST_SOURCES}/gtest-death-test.cc
+${GTEST_SOURCES}/gtest_main.cc
+${GTEST_SOURCES}/gtest-filepath.cc
+${GTEST_SOURCES}/gtest-port.cc
+${GTEST_SOURCES}/gtest-test-part.cc
+${GTEST_SOURCES}/gtest-typed-test.cc
+)
+
+SET(EWKUnitTests_LIBRARIES
+${_javascript_Core_LIBRARY_NAME}
+${WebCore_LIBRARY_NAME}
+${WebKit_LIBRARY_NAME}
+${ECORE_LIBRARIES}
+${ECORE_EVAS_LIBRARIES}
+${EVAS_LIBRARIES}
+${EDJE_LIBRARIES}
+)
+
+SET(EWKUnitTests_INCLUDE_DIRECTORIES
+${CMAKE_SOURCE_DIR}/Source
+${WEBKIT_DIR}/efl/ewk
+${WEBKIT_DIR}/efl/tests/src/UnitTestUtils
+${_javascript_CORE_DIR}
+${WTF_DIR}
+${WTF_DIR}/wtf
+${ECORE_INCLUDE_DIRS}
+${ECORE_EVAS_INCLUDE_DIRS}
+${EVAS_INCLUDE_DIRS}
+${EDJE_INCLUDE_DIRS}
+)
+
+SET(EWKUnitTests_LINK_FLAGS
+${ECORE_LDFLAGS}
+${ECORE_EVAS_LDFLAGS}
+${EVAS_LDFLAGS}
+  

[webkit-changes] [121399] branches/chromium/1180

[yosin]

Title: [121399] branches/chromium/1180








Revision 121399
Author yo...@chromium.org
Date 2012-06-27 20:22:40 -0700 (Wed, 27 Jun 2012)


Log Message
Merge 121019 - REGRESSION(r117738):[Forms] validationMessage IDL attribute should not have range overflow message if value isn't range overflow
https://bugs.webkit.org/show_bug.cgi?id=89736

Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/forms/date/input-date-validation-message.html
   fast/forms/number/input-number-validation-message.html
   fast/forms/range/input-range-validation-message.html

This patch changes comparison operator for range overflow message in
InputType::validationMessage().

* html/InputType.cpp:
(WebCore::InputType::validationMessage):

LayoutTests:

Tests for HTMLInputElement.validationMessage attribute.

* fast/forms/date/input-date-validation-message-expected.txt: Added.
* fast/forms/date/input-date-validation-message.html: Added.
* fast/forms/number/input-number-validation-message-expected.txt: Added.
* fast/forms/number/input-number-validation-message.html: Added.
* fast/forms/range/input-range-validation-message-expected.txt: Added.
* fast/forms/range/input-range-validation-message.html: Added.


TBR=yo...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10695026

Modified Paths

branches/chromium/1180/Source/WebCore/html/InputType.cpp


Added Paths

branches/chromium/1180/LayoutTests/fast/forms/date/input-date-validation-message-expected.txt
branches/chromium/1180/LayoutTests/fast/forms/date/input-date-validation-message.html
branches/chromium/1180/LayoutTests/fast/forms/number/input-number-validation-message-expected.txt
branches/chromium/1180/LayoutTests/fast/forms/number/input-number-validation-message.html
branches/chromium/1180/LayoutTests/fast/forms/range/input-range-validation-message-expected.txt
branches/chromium/1180/LayoutTests/fast/forms/range/input-range-validation-message.html




Diff

Copied: branches/chromium/1180/LayoutTests/fast/forms/date/input-date-validation-message-expected.txt (from rev 121019, trunk/LayoutTests/fast/forms/date/input-date-validation-message-expected.txt) (0 => 121399)

--- branches/chromium/1180/LayoutTests/fast/forms/date/input-date-validation-message-expected.txt	(rev 0)
+++ branches/chromium/1180/LayoutTests/fast/forms/date/input-date-validation-message-expected.txt	2012-06-28 03:22:40 UTC (rev 121399)
@@ -0,0 +1,21 @@
+Test for validationMessage IDL attribute for input type=date
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+No message
+PASS testIt(, , ) is 
+Value missing
+PASS testIt(, , ) is value missing
+Type mismatch
+PASS testIt(foo, , ) is 
+Range overflow
+PASS testIt(1982-11-02, , 1970-12-31) is range overflow
+Range underflow
+PASS testIt(1982-11-02, 1990-05-25, 1990-12-24) is range underflow
+Step mismatch
+PASS testIt(1982-11-02, , , 123) is step mismatch
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Copied: branches/chromium/1180/LayoutTests/fast/forms/date/input-date-validation-message.html (from rev 121019, trunk/LayoutTests/fast/forms/date/input-date-validation-message.html) (0 => 121399)

--- branches/chromium/1180/LayoutTests/fast/forms/date/input-date-validation-message.html	(rev 0)
+++ branches/chromium/1180/LayoutTests/fast/forms/date/input-date-validation-message.html	2012-06-28 03:22:40 UTC (rev 121399)
@@ -0,0 +1,46 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+script
+description('Test for validationMessage IDL attribute for lt;input type=date');
+var parent = document.createElement('div');
+document.body.appendChild(parent);
+parent.innerHTML = 'input type=date id=date maxlength=1 pattern=x';
+var input = document.getElementById('date');
+
+function testIt(value, min, max, step)
+{
+input.setAttribute(max, max);
+input.setAttribute(min, min);
+input.setAttribute(step, step);
+input.setAttribute(value, value);
+return input.validationMessage;
+}
+
+debug('No message')
+shouldBeEqualToString('testIt(, , )', '');
+
+debug('Value missing')
+input.setAttribute(required, );
+shouldBeEqualToString('testIt(, , )', 'value missing');
+input.removeAttribute(required);
+
+debug('Type mismatch');
+shouldBeEqualToString('testIt(foo, , )', '');
+
+debug('Range overflow')
+shouldBeEqualToString('testIt(1982-11-02, , 1970-12-31)', 'range overflow');
+
+debug('Range underflow')
+shouldBeEqualToString('testIt(1982-11-02, 1990-05-25, 1990-12-24)', 'range underflow');
+
+debug('Step mismatch')
+shouldBeEqualToString('testIt(1982-11-02, , , 123)', 'step mismatch');
+
+/script
+script src=""
+/body
+/html


Copied: branches/chromium/1180/LayoutTests/fast/forms/number/input-number-validation-message-expected.txt (from rev 121019, trunk/LayoutTests/fast/forms/number/input-number-validation-message-expected.txt) (0 => 121399)

--- 

[webkit-changes] [121400] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [121400] trunk/Source/WebKit/blackberry








Revision 121400
Author commit-qu...@webkit.org
Date 2012-06-27 20:33:01 -0700 (Wed, 27 Jun 2012)


Log Message
[BlackBerry] Selection overlay can become visible after it has been hidden
https://bugs.webkit.org/show_bug.cgi?id=90105

Patch by Andrew Lo a...@rim.com on 2012-06-27
Reviewed by George Staikos.

When SelectionOverlay::hide is called from UI thread,
rather than setting the override opacity, dispatch to the
WebKit thread, which removes the overlay (normal case).

Internal PR164183.
Internally Reviewed by: Arvid Nilsson.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPage::selectionOverlay):
* Api/WebPage_p.h:
(WebPagePrivate):
* Api/WebSelectionOverlay.h:
* WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::hide):
* WebKitSupport/SelectionOverlay.h:
(BlackBerry::WebKit::SelectionOverlay::create):
(SelectionOverlay):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/Api/WebSelectionOverlay.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.h




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (121399 => 121400)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-28 03:22:40 UTC (rev 121399)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-28 03:33:01 UTC (rev 121400)
@@ -456,6 +456,11 @@
 delete m_dumpRenderTree;
 m_dumpRenderTree = 0;
 #endif
+
+#if USE(ACCELERATED_COMPOSITING)
+deleteGuardedObject(m_selectionOverlay);
+m_selectionOverlay = 0;
+#endif
 }
 
 WebPage::~WebPage()
@@ -6478,7 +6483,7 @@
 
 WebSelectionOverlay* WebPage::selectionOverlay() const
 {
-return d-m_selectionOverlay.get();
+return d-m_selectionOverlay;
 }
 
 void WebPage::addOverlay(WebOverlay* overlay)


Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (121399 => 121400)

--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h	2012-06-28 03:22:40 UTC (rev 121399)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h	2012-06-28 03:33:01 UTC (rev 121400)
@@ -447,7 +447,7 @@
 RefPtrWebCore::Node m_currentContextNode;
 WebSettings* m_webSettings;
 OwnPtrWebTapHighlight m_tapHighlight;
-OwnPtrWebSelectionOverlay m_selectionOverlay;
+WebSelectionOverlay* m_selectionOverlay;
 
 #if ENABLE(_javascript__DEBUGGER)
 OwnPtrWebCore::_javascript_DebuggerBlackBerry m_scriptDebugger;


Modified: trunk/Source/WebKit/blackberry/Api/WebSelectionOverlay.h (121399 => 121400)

--- trunk/Source/WebKit/blackberry/Api/WebSelectionOverlay.h	2012-06-28 03:22:40 UTC (rev 121399)
+++ trunk/Source/WebKit/blackberry/Api/WebSelectionOverlay.h	2012-06-28 03:33:01 UTC (rev 121400)
@@ -21,12 +21,13 @@
 
 #include BlackBerryGlobal.h
 
+#include BlackBerryPlatformGuardedPointer.h
 #include BlackBerryPlatformIntRectRegion.h
 
 namespace BlackBerry {
 namespace WebKit {
 
-class BLACKBERRY_EXPORT WebSelectionOverlay {
+class BLACKBERRY_EXPORT WebSelectionOverlay : public BlackBerry::Platform::GuardedPointerBase {
 public:
 virtual ~WebSelectionOverlay() { }
 


Modified: trunk/Source/WebKit/blackberry/ChangeLog (121399 => 121400)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-06-28 03:22:40 UTC (rev 121399)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-06-28 03:33:01 UTC (rev 121400)
@@ -1,3 +1,30 @@
+2012-06-27  Andrew Lo  a...@rim.com
+
+[BlackBerry] Selection overlay can become visible after it has been hidden
+https://bugs.webkit.org/show_bug.cgi?id=90105
+
+Reviewed by George Staikos.
+
+When SelectionOverlay::hide is called from UI thread,
+rather than setting the override opacity, dispatch to the
+WebKit thread, which removes the overlay (normal case).
+
+Internal PR164183.
+Internally Reviewed by: Arvid Nilsson.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
+(BlackBerry::WebKit::WebPage::selectionOverlay):
+* Api/WebPage_p.h:
+(WebPagePrivate):
+* Api/WebSelectionOverlay.h:
+* WebKitSupport/SelectionOverlay.cpp:
+(BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
+(BlackBerry::WebKit::SelectionOverlay::hide):
+* WebKitSupport/SelectionOverlay.h:
+(BlackBerry::WebKit::SelectionOverlay::create):
+(SelectionOverlay):
+
 2012-06-25  Mark Hahnenberg  mhahnenb...@apple.com
 
 JSLock should be per-JSGlobalData


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.cpp (121399 => 121400)

--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.cpp	2012-06-28 03:22:40 UTC (rev 121399)
+++ 

[webkit-changes] [121401] trunk

[commit-queue]

Title: [121401] trunk








Revision 121401
Author commit-qu...@webkit.org
Date 2012-06-27 20:58:02 -0700 (Wed, 27 Jun 2012)


Log Message
pattern= should only accept the empty string
https://bugs.webkit.org/show_bug.cgi?id=89569

Patch by Pablo Flouret pab...@motorola.com on 2012-06-27
Reviewed by Kent Tamura.

Source/WebCore:

An empty pattern attribute was being treated essentially as if the
pattern wasn't present.

No new tests. Covered by existing tests (plus a modified one).

* html/BaseTextInputType.cpp:
(WebCore::BaseTextInputType::patternMismatch):
Check if the pattern attribute is present. If it is then use the
pattern as is (in the particular case of this bug, an empty pattern
will only match an empty value).

LayoutTests:

* fast/forms/ValidityState-patternMismatch-expected.txt:
* fast/forms/ValidityState-patternMismatch.html:
Modified the test to check the results of an empty pattern both with an empty
value, and with some value specified.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/ValidityState-patternMismatch-expected.txt
trunk/LayoutTests/fast/forms/ValidityState-patternMismatch.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/BaseTextInputType.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (121400 => 121401)

--- trunk/LayoutTests/ChangeLog	2012-06-28 03:33:01 UTC (rev 121400)
+++ trunk/LayoutTests/ChangeLog	2012-06-28 03:58:02 UTC (rev 121401)
@@ -1,3 +1,15 @@
+2012-06-27  Pablo Flouret  pab...@motorola.com
+
+pattern= should only accept the empty string
+https://bugs.webkit.org/show_bug.cgi?id=89569
+
+Reviewed by Kent Tamura.
+
+* fast/forms/ValidityState-patternMismatch-expected.txt:
+* fast/forms/ValidityState-patternMismatch.html:
+Modified the test to check the results of an empty pattern both with an empty
+value, and with some value specified.
+
 2012-06-27  Alexis Menard  alexis.men...@openbossa.org
 
 Implement selectedOptions attribute of HTMLSelectElement.


Modified: trunk/LayoutTests/fast/forms/ValidityState-patternMismatch-expected.txt (121400 => 121401)

--- trunk/LayoutTests/fast/forms/ValidityState-patternMismatch-expected.txt	2012-06-28 03:33:01 UTC (rev 121400)
+++ trunk/LayoutTests/fast/forms/ValidityState-patternMismatch-expected.txt	2012-06-28 03:58:02 UTC (rev 121401)
@@ -51,7 +51,8 @@
 PASS patternMismatchFor(mismatch-18) is true
 PASS patternMismatchFor(mismatch-19) is true
 PASS patternMismatchFor(mismatch-20) is true
-PASS patternMismatchFor(empty-pattern) is false
+PASS patternMismatchFor(empty-pattern-match) is false
+PASS patternMismatchFor(empty-pattern-mismatch) is true
 PASS patternMismatchFor(disabled) is false
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/fast/forms/ValidityState-patternMismatch.html (121400 => 121401)

--- trunk/LayoutTests/fast/forms/ValidityState-patternMismatch.html	2012-06-28 03:33:01 UTC (rev 121400)
+++ trunk/LayoutTests/fast/forms/ValidityState-patternMismatch.html	2012-06-28 03:58:02 UTC (rev 121401)
@@ -31,6 +31,7 @@
 /input id=match-17 type=text pattern=foobar value= /
 input id=match-18 type=text pattern=[0-9]|10|11|12 value=10 /
 input id=match-19 type=text pattern=10|11|12|[0-9] value=12 /
+input id=empty-pattern-match type=text pattern= value= /
 input id=wrong-gray-or-grey type=text pattern=gr[ae]y value=Wrong!
 /input id=gray type=text pattern=gr[ae]y value=gray
 /input id=grey type=text pattern=gr[ae]y value=grey
@@ -55,7 +56,7 @@
 /input id=mismatch-18 type=text pattern=foo\\ value=food
 /input id=mismatch-19 type=text pattern=^ value=wrong
 /input id=mismatch-20 type=text pattern=$ value=wrong
-/input id=empty-pattern type=text pattern= value=Lorem Ipsum
+/input id=empty-pattern-mismatch type=text pattern= value=Lorem Ipsum
 /input id=disabled pattern=[0-9][A-Z]{3} value=00AA disabled //div
 script language=_javascript_ type=text/_javascript_
 function patternMismatchFor(id) {
@@ -116,7 +117,8 @@
 shouldBeTrue('patternMismatchFor(mismatch-19)');
 shouldBeTrue('patternMismatchFor(mismatch-20)');
 
-shouldBeFalse('patternMismatchFor(empty-pattern)');
+shouldBeFalse('patternMismatchFor(empty-pattern-match)');
+shouldBeTrue('patternMismatchFor(empty-pattern-mismatch)');
 
 shouldBeFalse('patternMismatchFor(disabled)');
 


Modified: trunk/Source/WebCore/ChangeLog (121400 => 121401)

--- trunk/Source/WebCore/ChangeLog	2012-06-28 03:33:01 UTC (rev 121400)
+++ trunk/Source/WebCore/ChangeLog	2012-06-28 03:58:02 UTC (rev 121401)
@@ -1,3 +1,21 @@
+2012-06-27  Pablo Flouret  pab...@motorola.com
+
+pattern= should only accept the empty string
+https://bugs.webkit.org/show_bug.cgi?id=89569
+
+Reviewed by Kent Tamura.
+
+An empty pattern attribute was being treated essentially as if the
+pattern wasn't present.
+
+No new tests. Covered by existing tests (plus a modified one).
+
+* html/BaseTextInputType.cpp:
+   

[webkit-changes] [121402] trunk/WebKitLibraries

[bfulgham]

Title: [121402] trunk/WebKitLibraries








Revision 121402
Author bfulg...@webkit.org
Date 2012-06-27 21:08:58 -0700 (Wed, 27 Jun 2012)


Log Message
[WinCairo] Unreviewed build correction.  Resync feature defines with
Apple port. Things have drifted apart a little.

* win/tools/vsprops/FeatureDefinesCairo.vsprops: Update to match
Apple port, define some missing features.

Modified Paths

trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops




Diff

Modified: trunk/WebKitLibraries/ChangeLog (121401 => 121402)

--- trunk/WebKitLibraries/ChangeLog	2012-06-28 03:58:02 UTC (rev 121401)
+++ trunk/WebKitLibraries/ChangeLog	2012-06-28 04:08:58 UTC (rev 121402)
@@ -1,3 +1,11 @@
+2012-06-27  Brent Fulgham  bfulg...@webkit.org
+
+[WinCairo] Unreviewed build correction.  Resync feature defines with
+Apple port. Things have drifted apart a little.
+
+* win/tools/vsprops/FeatureDefinesCairo.vsprops: Update to match
+Apple port, define some missing features.
+
 2012-06-19  Mike West  mk...@chromium.org
 
 Introduce ENABLE_CSP_NEXT configuration flag.


Modified: trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops (121401 => 121402)

--- trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops	2012-06-28 03:58:02 UTC (rev 121401)
+++ trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops	2012-06-28 04:08:58 UTC (rev 121402)
@@ -9,7 +9,7 @@
 	
   Tool
 		Name=VCCLCompilerTool
-		PreprocessorDefinitions=$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CSS3_FLEXBOX);$(ENABLE_CSS_BOX_DECORATION_BREAK);$(ENABLE_CSS_FILTERS);$(ENABLE_CSS_GRID_LAYOUT);$(ENABLE_CSS_SHADERS);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_CUSTOM_SCHEME_HANDLER);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_FONT_BOOSTING);$(ENABLE_FULLSCREEN_API);$(ENABLE_GAMEPAD);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_TYPE_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_INPUT_TYPE_DATE);$(ENABLE_INPUT_TYPE_DATETIME);$(ENABLE_INPUT_TYPE_DATETIMELOCAL);$(ENABLE_INPUT_TYPE_MONTH);$(ENABLE_INPUT_TYPE_TIME);$(ENABLE_INPUT_TYPE_WEEK);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LEGACY_NOTIFICATIONS);$(ENABLE_LINK_PREFETCH);$(ENABLE_LINK_PRERENDER);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_MICRODATA);$(ENABLE_MUTATION_OBSERVERS);$(ENABLE_NOTIFICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SCRIPTED_SPEECH);$(ENABLE_SHADOW_DOM);$(ENABLE_SHARED_WORKERS);$(ENABLE_STYLE_SCOPED);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_UNDO_MANAGER);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XSLT)
+		PreprocessorDefinitions=$(ENABLE_IFRAME_SEAMLESS);$(ENABLE_REQUEST_ANIMATION_FRAME);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CSS3_FLEXBOX);$(ENABLE_CSS_BOX_DECORATION_BREAK);$(ENABLE_CSS_FILTERS);$(ENABLE_CSS_GRID_LAYOUT);$(ENABLE_CSS_SHADERS);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_CUSTOM_SCHEME_HANDLER);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_FONT_BOOSTING);$(ENABLE_FULLSCREEN_API);$(ENABLE_GAMEPAD);$(ENABLE_GEOLOCATION);$(ENABLE_HIGH_DPI_CANVAS);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_TYPE_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_INPUT_TYPE_DATE);$(ENABLE_INPUT_TYPE_DATETIME);$(ENABLE_INPUT_TYPE_DATETIMELOCAL);$(ENABLE_INPUT_TYPE_MONTH);$(ENABLE_INPUT_TYPE_TIME);$(ENABLE_INPUT_TYPE_WEEK);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LEGACY_CSS_VENDOR_PREFIXES);$(ENABLE_LEGACY_NOTIFICATIONS);$(ENABLE_LINK_PREFETCH);$(ENABLE_LINK_PRERENDER);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_MICRODATA);$(ENABLE_MUTATION_OBSERVERS);$(ENABLE_NOTIFICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SCRIPTED_SPEECH);$(ENABLE_SHADOW_DOM);$(ENABLE_SHARED_WORKERS);$(ENABLE_STYLE_SCOPED);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_UNDO_MANAGER);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XSLT)
 	/
   UserMacro
 		Name=ENABLE_3D_RENDERING
@@ -43,7 +43,7 @@
 	/
   UserMacro
 		Name=ENABLE_CSS_BOX_DECORATION_BREAK
-		Value=
+		Value=ENABLE_CSS_BOX_DECORATION_BREAK
 		PerformEnvironmentSet=true
 	/
   UserMacro
@@ -53,7 +53,7 @@
 	/
   

[webkit-changes] [121403] trunk/Source/WebCore

[commit-queue]

Title: [121403] trunk/Source/WebCore








Revision 121403
Author commit-qu...@webkit.org
Date 2012-06-27 21:49:53 -0700 (Wed, 27 Jun 2012)


Log Message
Add OVERRIDE to functions in UnthrottledTextureUploader class
https://bugs.webkit.org/show_bug.cgi?id=90130

Patch by Lu Guanqun guanqun...@intel.com on 2012-06-27
Reviewed by James Robinson.

No new tests required.

* platform/graphics/chromium/LayerRendererChromium.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121402 => 121403)

--- trunk/Source/WebCore/ChangeLog	2012-06-28 04:08:58 UTC (rev 121402)
+++ trunk/Source/WebCore/ChangeLog	2012-06-28 04:49:53 UTC (rev 121403)
@@ -1,3 +1,14 @@
+2012-06-27  Lu Guanqun  guanqun...@intel.com
+
+Add OVERRIDE to functions in UnthrottledTextureUploader class
+https://bugs.webkit.org/show_bug.cgi?id=90130
+
+Reviewed by James Robinson.
+
+No new tests required.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+
 2012-06-27  Pablo Flouret  pab...@motorola.com
 
 pattern= should only accept the empty string


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (121402 => 121403)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2012-06-28 04:08:58 UTC (rev 121402)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2012-06-28 04:49:53 UTC (rev 121403)
@@ -132,10 +132,10 @@
 }
 virtual ~UnthrottledTextureUploader() { }
 
-virtual bool isBusy() { return false; }
-virtual void beginUploads() { }
-virtual void endUploads() { }
-virtual void uploadTexture(CCGraphicsContext* context, LayerTextureUpdater::Texture* texture, TextureAllocator* allocator, const IntRect sourceRect, const IntRect destRect) { texture-updateRect(context, allocator, sourceRect, destRect); }
+virtual bool isBusy() OVERRIDE { return false; }
+virtual void beginUploads() OVERRIDE { }
+virtual void endUploads() OVERRIDE { }
+virtual void uploadTexture(CCGraphicsContext* context, LayerTextureUpdater::Texture* texture, TextureAllocator* allocator, const IntRect sourceRect, const IntRect destRect) OVERRIDE { texture-updateRect(context, allocator, sourceRect, destRect); }
 
 protected:
 UnthrottledTextureUploader() { }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121404] trunk/Source

[yosin]

Title: [121404] trunk/Source








Revision 121404
Author yo...@chromium.org
Date 2012-06-27 21:58:07 -0700 (Wed, 27 Jun 2012)


Log Message
[Platform] Implement localizedDecimalSeparator function
https://bugs.webkit.org/show_bug.cgi?id=90036

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces new function localizedDecimalSeparator() when
ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS). It will be used for
displaying millisecond for time fields UI.

Test: WebKit/chromium/tests/LocalizedNumberICUTest.cpp

* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::localizedDecimalSeparator): Added
* platform/text/LocaleICU.h:
(LocaleICU): Added localizedDecimalSeparator.
* platform/text/LocalizedNumber.h:
* platform/text/LocalizedNumberICU.cpp:
(WebCore::localizedDecimalSeparator): Added.
* platform/text/LocalizedNumberNone.cpp:
(WebCore::localizedDecimalSeparator): Added.
* platform/text/mac/LocalizedNumberMac.mm:
(WebCore::localizedDecimalSeparator): Added.

Source/WebKit/chromium:

This patch adds test case for localizedDecimalSeparator().

* tests/LocalizedNumberICUTest.cpp:
(testDecimalSeparator):
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/LocaleICU.cpp
trunk/Source/WebCore/platform/text/LocaleICU.h
trunk/Source/WebCore/platform/text/LocalizedNumber.h
trunk/Source/WebCore/platform/text/LocalizedNumberICU.cpp
trunk/Source/WebCore/platform/text/LocalizedNumberNone.cpp
trunk/Source/WebCore/platform/text/mac/LocalizedNumberMac.mm
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp


Property Changed

trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (121403 => 121404)

--- trunk/Source/WebCore/ChangeLog	2012-06-28 04:49:53 UTC (rev 121403)
+++ trunk/Source/WebCore/ChangeLog	2012-06-28 04:58:07 UTC (rev 121404)
@@ -1,3 +1,28 @@
+2012-06-27  Yoshifumi Inoue  yo...@chromium.org
+
+[Platform] Implement localizedDecimalSeparator function
+https://bugs.webkit.org/show_bug.cgi?id=90036
+
+Reviewed by Kent Tamura.
+
+This patch introduces new function localizedDecimalSeparator() when
+ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS). It will be used for
+displaying millisecond for time fields UI.
+
+Test: WebKit/chromium/tests/LocalizedNumberICUTest.cpp
+
+* platform/text/LocaleICU.cpp:
+(WebCore::LocaleICU::localizedDecimalSeparator): Added
+* platform/text/LocaleICU.h:
+(LocaleICU): Added localizedDecimalSeparator.
+* platform/text/LocalizedNumber.h:
+* platform/text/LocalizedNumberICU.cpp:
+(WebCore::localizedDecimalSeparator): Added.
+* platform/text/LocalizedNumberNone.cpp:
+(WebCore::localizedDecimalSeparator): Added.
+* platform/text/mac/LocalizedNumberMac.mm:
+(WebCore::localizedDecimalSeparator): Added.
+
 2012-06-27  Lu Guanqun  guanqun...@intel.com
 
 Add OVERRIDE to functions in UnthrottledTextureUploader class
Property changes on: trunk/Source/WebCore/ChangeLog
___


Deleted: svn:executable

Modified: trunk/Source/WebCore/platform/text/LocaleICU.cpp (121403 => 121404)

--- trunk/Source/WebCore/platform/text/LocaleICU.cpp	2012-06-28 04:49:53 UTC (rev 121403)
+++ trunk/Source/WebCore/platform/text/LocaleICU.cpp	2012-06-28 04:58:07 UTC (rev 121404)
@@ -493,5 +493,15 @@
 }
 #endif
 
+#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
+
+String LocaleICU::localizedDecimalSeparator()
+{
+initializeDecimalFormat();
+return m_decimalSymbols[DecimalSeparatorIndex];
+}
+
+#endif
+
 } // namespace WebCore
 


Modified: trunk/Source/WebCore/platform/text/LocaleICU.h (121403 => 121404)

--- trunk/Source/WebCore/platform/text/LocaleICU.h	2012-06-28 04:49:53 UTC (rev 121403)
+++ trunk/Source/WebCore/platform/text/LocaleICU.h	2012-06-28 04:58:07 UTC (rev 121404)
@@ -52,6 +52,9 @@
 // For LocalizedNumber
 String convertToLocalizedNumber(const String);
 String convertFromLocalizedNumber(const String);
+#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
+String localizedDecimalSeparator();
+#endif
 
 // For LocalizedDate
 double parseLocalizedDate(const String);


Modified: trunk/Source/WebCore/platform/text/LocalizedNumber.h (121403 => 121404)

--- trunk/Source/WebCore/platform/text/LocalizedNumber.h	2012-06-28 04:49:53 UTC (rev 121403)
+++ trunk/Source/WebCore/platform/text/LocalizedNumber.h	2012-06-28 04:58:07 UTC (rev 121404)
@@ -50,6 +50,12 @@
 // responsible to check the format of the resultant string.
 String convertFromLocalizedNumber(const String);
 
+
+#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
+// Returns localized decimal separator, e.g. . for English, , for French.
+String localizedDecimalSeparator();
+#endif
+
 } // namespace WebCore
 
 #endif // LocalizedNumber_h


Modified: trunk/Source/WebCore/platform/text/LocalizedNumberICU.cpp (121403 => 121404)

--- 

[webkit-changes] [121406] trunk/Tools

[ossy]

Title: [121406] trunk/Tools








Revision 121406
Author o...@webkit.org
Date 2012-06-27 22:15:45 -0700 (Wed, 27 Jun 2012)


Log Message
Unreviewed, rolling out r121363, r121367, r121384, and
r121390.
http://trac.webkit.org/changeset/121363
http://trac.webkit.org/changeset/121367
http://trac.webkit.org/changeset/121384
http://trac.webkit.org/changeset/121390
https://bugs.webkit.org/show_bug.cgi?id=90134

It broke debug NRWT on GTK and on Qt (Requested by Ossy_NIGHT
on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-06-27

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
(ChromiumPort.__init__):
(ChromiumPort._check_file_exists):
(ChromiumPort.default_results_directory):
(ChromiumPort._driver_class):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort.__init__):
(WebKitPort._webcore_symbols_string):
(WebKitPort._skipped_tests_for_unsupported_features):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(TestWebKitPort._webcore_symbols_string):
(WebKitPortUnitTests.test_default_options):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (121405 => 121406)

--- trunk/Tools/ChangeLog	2012-06-28 05:00:42 UTC (rev 121405)
+++ trunk/Tools/ChangeLog	2012-06-28 05:15:45 UTC (rev 121406)
@@ -1,3 +1,40 @@
+2012-06-27  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r121363, r121367, r121384, and
+r121390.
+http://trac.webkit.org/changeset/121363
+http://trac.webkit.org/changeset/121367
+http://trac.webkit.org/changeset/121384
+http://trac.webkit.org/changeset/121390
+https://bugs.webkit.org/show_bug.cgi?id=90134
+
+It broke debug NRWT on GTK and on Qt (Requested by Ossy_NIGHT
+on #webkit).
+
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumPort):
+(ChromiumPort.__init__):
+(ChromiumPort._check_file_exists):
+(ChromiumPort.default_results_directory):
+(ChromiumPort._driver_class):
+(ChromiumPort._build_path):
+(ChromiumPort._path_to_image_diff):
+* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
+(ChromiumLinuxPort.baseline_search_path):
+* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
+(ChromiumMacPort.baseline_search_path):
+* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+(ChromiumPortTest):
+* Scripts/webkitpy/layout_tests/port/chromium_win.py:
+(ChromiumWinPort.baseline_search_path):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitPort.__init__):
+(WebKitPort._webcore_symbols_string):
+(WebKitPort._skipped_tests_for_unsupported_features):
+* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+(TestWebKitPort._webcore_symbols_string):
+(WebKitPortUnitTests.test_default_options):
+
 2012-06-27  Dirk Pranke  dpra...@chromium.org
 
 Fix typo in r121384 :(


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (121405 => 121406)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-06-28 05:00:42 UTC (rev 121405)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-06-28 05:15:45 UTC (rev 121406)
@@ -43,15 +43,14 @@
 from webkitpy.layout_tests.models.test_configuration import TestConfiguration
 from webkitpy.layout_tests.port.base import Port, VirtualTestSuite
 from webkitpy.layout_tests.port.driver import DriverOutput
-from webkitpy.layout_tests.port.webkit import WebKitPort, WebKitDriver
+from webkitpy.layout_tests.port.webkit import WebKitDriver
 
 
 _log = logging.getLogger(__name__)
 
 
-class ChromiumPort(WebKitPort):
+class ChromiumPort(Port):
 Abstract base class for Chromium implementations of the Port class.
-pixel_tests_option_default = True
 
 ALL_SYSTEMS = (
 ('leopard', 'x86'),
@@ -108,13 +107,10 @@
 return module_path[0:offset]
 
 def __init__(self, host, port_name, **kwargs):
-super(ChromiumPort, self).__init__(host, port_name, **kwargs)
+

[webkit-changes] [121407] trunk/WebKitLibraries

[bfulgham]

Title: [121407] trunk/WebKitLibraries








Revision 121407
Author bfulg...@webkit.org
Date 2012-06-27 22:17:08 -0700 (Wed, 27 Jun 2012)


Log Message
[WinCairo] Unreviewed build correction.  Accidentally turned on
CSS_FILTERS, which is not available in tree.

* win/tools/vsprops/FeatureDefinesCairo.vsprops: Turn CSS_FILTERS
back off for WinCairo target.

Modified Paths

trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops




Diff

Modified: trunk/WebKitLibraries/ChangeLog (121406 => 121407)

--- trunk/WebKitLibraries/ChangeLog	2012-06-28 05:15:45 UTC (rev 121406)
+++ trunk/WebKitLibraries/ChangeLog	2012-06-28 05:17:08 UTC (rev 121407)
@@ -1,5 +1,13 @@
 2012-06-27  Brent Fulgham  bfulg...@webkit.org
 
+[WinCairo] Unreviewed build correction.  Accidentally turned on
+CSS_FILTERS, which is not available in tree.
+
+* win/tools/vsprops/FeatureDefinesCairo.vsprops: Turn CSS_FILTERS
+back off for WinCairo target.
+
+2012-06-27  Brent Fulgham  bfulg...@webkit.org
+
 [WinCairo] Unreviewed build correction.  Resync feature defines with
 Apple port. Things have drifted apart a little.
 


Modified: trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops (121406 => 121407)

--- trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops	2012-06-28 05:15:45 UTC (rev 121406)
+++ trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops	2012-06-28 05:17:08 UTC (rev 121407)
@@ -53,7 +53,7 @@
 	/
   UserMacro
 		Name=ENABLE_CSS_FILTERS
-		Value=ENABLE_CSS_FILTERS
+		Value=
 		PerformEnvironmentSet=true
 	/
   UserMacro






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes