[webkit-changes] [121884] trunk/Source/WebCore
Title: [121884] trunk/Source/WebCore
Revision 121884
Author commit-qu...@webkit.org
Date 2012-07-04 23:53:59 -0700 (Wed, 04 Jul 2012)
Log Message
Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
https://bugs.webkit.org/show_bug.cgi?id=90447
Patch by Huang Dongsung on 2012-07-04
Reviewed by Alexey Proskuryakov.
No new tests. This patch doesn't change behavior.
* platform/graphics/BitmapImage.h:
(BitmapImage):
* platform/graphics/qt/StillImageQt.h:
(StillImage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.h
trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (121883 => 121884)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 06:45:37 UTC (rev 121883)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 06:53:59 UTC (rev 121884)
@@ -1,3 +1,17 @@
+2012-07-04 Huang Dongsung
+
+Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
+https://bugs.webkit.org/show_bug.cgi?id=90447
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests. This patch doesn't change behavior.
+
+* platform/graphics/BitmapImage.h:
+(BitmapImage):
+* platform/graphics/qt/StillImageQt.h:
+(StillImage):
+
2012-07-04 Mike West
Implement the script-nonce Content Security Policy directive.
Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.h (121883 => 121884)
--- trunk/Source/WebCore/platform/graphics/BitmapImage.h 2012-07-05 06:45:37 UTC (rev 121883)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.h 2012-07-05 06:53:59 UTC (rev 121884)
@@ -112,7 +112,7 @@
{
return adoptRef(new BitmapImage(observer));
}
-~BitmapImage();
+virtual ~BitmapImage();
virtual bool isBitmapImage() const;
Modified: trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h (121883 => 121884)
--- trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h 2012-07-05 06:45:37 UTC (rev 121883)
+++ trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h 2012-07-05 06:53:59 UTC (rev 121884)
@@ -58,7 +58,7 @@
private:
StillImage(const QPixmap& pixmap);
StillImage(const QPixmap* pixmap);
-~StillImage();
+virtual ~StillImage();
const QPixmap* m_pixmap;
bool m_ownsPixmap;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121883] trunk
Title: [121883] trunk Revision 121883 Author commit-qu...@webkit.org Date 2012-07-04 23:45:37 -0700 (Wed, 04 Jul 2012) Log Message Implement the script-nonce Content Security Policy directive. https://bugs.webkit.org/show_bug.cgi?id=89577 Patch by Mike West on 2012-07-04 Reviewed by Adam Barth. Source/WebCore: This patch implements the (experimental) script-nonce Content Security Policy directive from the 1.1 spec, which allows for selective execution of script by specifying a "nonce" attribute for the script tag. Script is only loaded and executed if it both matches the nonce and matches the script-src whitelist (if present). The implementation is gated on the ENABLE_CSP_NEXT flag, which is currently disabled for all ports other than Chromium. Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#script-nonce--experimental Tests: http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html * dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript): (WebCore::ScriptElement::executeScript): Passing the nonce attribute through to check against CSP. * html/HTMLAttributeNames.in: * html/HTMLScriptElement.idl: Adding the `nonce` attribute to the script tag. * page/ContentSecurityPolicy.cpp: (CSPDirectiveList): (WebCore::CSPDirectiveList::logInvalidNonce): (WebCore): (WebCore::CSPDirectiveList::checkNonceAndReportViolation): (WebCore::CSPDirectiveList::allowJavaScriptURLs): (WebCore::CSPDirectiveList::allowInlineEventHandlers): If a nonce is set, deny _javascript_ URLs and inline event handlers. (WebCore::CSPDirectiveList::allowScriptNonce): (WebCore::CSPDirectiveList::parseScriptNonce): (WebCore::CSPDirectiveList::addDirective): (WebCore::isAllowedByAllWithNonce): (WebCore::ContentSecurityPolicy::allowScriptNonce): * page/ContentSecurityPolicy.h: (WebCore): LayoutTests: * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed-expected.txt: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce-expected.txt: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-expected.txt: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce-expected.txt: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked-expected.txt: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html: Added. * http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl: Adding noncy goodness to the echo script. * http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js: (test): * platform/gtk/TestExpectations: Skipping 1.1 tests on GTK (missed it in r121879). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/ScriptElement.cpp trunk/Source/WebCore/html/HTMLAttributeNames.in trunk/Source/WebCore/html/HTMLScriptElement.idl trunk/Source/WebCore/page/ContentSecurityPolicy.cpp trunk/Source/WebCore/page/ContentSecurityPolicy.h Added Paths trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html Diff Modified: trunk/Layout
[webkit-changes] [121881] trunk/Tools
Title: [121881] trunk/Tools
Revision 121881
Author yo...@chromium.org
Date 2012-07-04 22:35:14 -0700 (Wed, 04 Jul 2012)
Log Message
Unreviewed Chromium gardening, Disable always failed python tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=90587
PortTest.qt_linux and mac_lion are always failed on Chromium Windows at
creating child process.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_qt_linux):
(PortTest.disabled_test_mac_lion):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
Diff
Modified: trunk/Tools/ChangeLog (121880 => 121881)
--- trunk/Tools/ChangeLog 2012-07-05 04:27:26 UTC (rev 121880)
+++ trunk/Tools/ChangeLog 2012-07-05 05:35:14 UTC (rev 121881)
@@ -1,5 +1,17 @@
2012-07-04 Yoshifumi Inoue
+Unreviewed Chromium gardening, Disable always failed python tests on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=90587
+
+PortTest.qt_linux and mac_lion are always failed on Chromium Windows at
+creating child process.
+
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+(PortTest.disabled_test_qt_linux):
+(PortTest.disabled_test_mac_lion):
+
+2012-07-04 Yoshifumi Inoue
+
[Tools] webkit_unittest.py got assertion
https://bugs.webkit.org/show_bug.cgi?id=90579
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (121880 => 121881)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2012-07-05 04:27:26 UTC (rev 121880)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2012-07-05 05:35:14 UTC (rev 121881)
@@ -1036,10 +1036,10 @@
def disabled_test_chromium_mac_lion_in_test_shell_mode(self):
self.assert_mock_port_works('chromium-mac-lion', args=['--additional-drt-flag=--test-shell'])
-def test_qt_linux(self):
+def disabled_test_qt_linux(self):
self.assert_mock_port_works('qt-linux')
-def test_mac_lion(self):
+def disabled_test_mac_lion(self):
self.assert_mock_port_works('mac-lion')
if __name__ == '__main__':
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121880] trunk/Source/WebKit/chromium
Title: [121880] trunk/Source/WebKit/chromium
Revision 121880
Author yo...@chromium.org
Date 2012-07-04 21:27:26 -0700 (Wed, 04 Jul 2012)
Log Message
Unreviewed, Chromium gardening. Roll Chromium DEPS.
* DEPS: chromium_rev: 145322 => 145501
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (121879 => 121880)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-05 04:04:55 UTC (rev 121879)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-05 04:27:26 UTC (rev 121880)
@@ -1,3 +1,9 @@
+2012-07-04 Yoshifumi Inoue
+
+Unreviewed, Chromium gardening. Roll Chromium DEPS.
+
+* DEPS: chromium_rev: 145322 => 145501
+
2012-07-04 Dana Jansens
[chromium] Respect memory needed for RenderSurfaces when reserving contents textures
Modified: trunk/Source/WebKit/chromium/DEPS (121879 => 121880)
--- trunk/Source/WebKit/chromium/DEPS 2012-07-05 04:04:55 UTC (rev 121879)
+++ trunk/Source/WebKit/chromium/DEPS 2012-07-05 04:27:26 UTC (rev 121880)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '145322'
+ 'chromium_rev': '145501'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121879] trunk/LayoutTests
Title: [121879] trunk/LayoutTests Revision 121879 Author commit-qu...@webkit.org Date 2012-07-04 21:04:55 -0700 (Wed, 04 Jul 2012) Log Message Skip CSP 1.1 tests on ports where it's disabled. https://bugs.webkit.org/show_bug.cgi?id=90564 Patch by Mike West on 2012-07-04 Reviewed by Adam Barth. * platform/efl/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: * platform/wincairo/Skipped: * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/win/Skipped trunk/LayoutTests/platform/wincairo/Skipped trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (121878 => 121879) --- trunk/LayoutTests/ChangeLog 2012-07-05 03:48:03 UTC (rev 121878) +++ trunk/LayoutTests/ChangeLog 2012-07-05 04:04:55 UTC (rev 121879) @@ -1,3 +1,17 @@ +2012-07-04 Mike West + +Skip CSP 1.1 tests on ports where it's disabled. +https://bugs.webkit.org/show_bug.cgi?id=90564 + +Reviewed by Adam Barth. + +* platform/efl/Skipped: +* platform/mac/Skipped: +* platform/qt/Skipped: +* platform/win/Skipped: +* platform/wincairo/Skipped: +* platform/wk2/Skipped: + 2012-07-04 Li Yin AudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode Modified: trunk/LayoutTests/platform/efl/Skipped (121878 => 121879) --- trunk/LayoutTests/platform/efl/Skipped 2012-07-05 03:48:03 UTC (rev 121878) +++ trunk/LayoutTests/platform/efl/Skipped 2012-07-05 04:04:55 UTC (rev 121879) @@ -737,6 +737,10 @@ # Tests for features under development # +# Content Security Policy 1.1 (ENABLE_CSP_NEXT) is not enabled +# https://bugs.webkit.org/show_bug.cgi?id=85558 +http/tests/security/contentSecurityPolicy/1.1 + # ENABLE_INPUT_TYPE_* are not enabled. # https://bugs.webkit.org/show_bug.cgi?id=29359 # https://bugs.webkit.org/show_bug.cgi?id=68971 Modified: trunk/LayoutTests/platform/mac/Skipped (121878 => 121879) --- trunk/LayoutTests/platform/mac/Skipped 2012-07-05 03:48:03 UTC (rev 121878) +++ trunk/LayoutTests/platform/mac/Skipped 2012-07-05 04:04:55 UTC (rev 121879) @@ -262,6 +262,10 @@ http/tests/misc/webtiming-two-redirects.php fast/performance/ +# Content Security Policy 1.1 (ENABLE_CSP_NEXT) is not enabled +# https://bugs.webkit.org/show_bug.cgi?id=85558 +http/tests/security/contentSecurityPolicy/1.1 + # Still working out flakiness issues with the perf tests. # https://bugs.webkit.org/show_bug.cgi?id=44199 perf/ Modified: trunk/LayoutTests/platform/qt/Skipped (121878 => 121879) --- trunk/LayoutTests/platform/qt/Skipped 2012-07-05 03:48:03 UTC (rev 121878) +++ trunk/LayoutTests/platform/qt/Skipped 2012-07-05 04:04:55 UTC (rev 121879) @@ -442,6 +442,10 @@ # No CORS support for media elements is implemented yet. http/tests/security/video-cross-origin-readback.html +# Content Security Policy 1.1 (ENABLE_CSP_NEXT) is not enabled +# https://bugs.webkit.org/show_bug.cgi?id=85558 +http/tests/security/contentSecurityPolicy/1.1 + # === # # Drag and Drop Support in DRT. # # === # Modified: trunk/LayoutTests/platform/win/Skipped (121878 => 121879) --- trunk/LayoutTests/platform/win/Skipped 2012-07-05 03:48:03 UTC (rev 121878) +++ trunk/LayoutTests/platform/win/Skipped 2012-07-05 04:04:55 UTC (rev 121879) @@ -1945,3 +1945,7 @@ svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg svg/W3C-SVG-1.1-SE/text-intro-05-t.svg + +# Content Security Policy 1.1 (ENABLE_CSP_NEXT) is not enabled +# https://bugs.webkit.org/show_bug.cgi?id=85558 +http/tests/security/contentSecurityPolicy/1.1 Modified: trunk/LayoutTests/platform/wincairo/Skipped (121878 => 121879) --- trunk/LayoutTests/platform/wincairo/Skipped 2012-07-05 03:48:03 UTC (rev 121878) +++ trunk/LayoutTests/platform/wincairo/Skipped 2012-07-05 04:04:55 UTC (rev 121879) @@ -2121,3 +2121,7 @@ # https://bugs.webkit.org/show_bug.cgi?id=86000 http/tests/security/referrer-policy-redirect-link.html + +# Content Security Policy 1.1 (ENABLE_CSP_NEXT) is not enabled +# https://bugs.webkit.org/show_bug.cgi?id=85558 +http/tests/security/contentSecurityPolicy/1.1 Modified: trunk/LayoutTests/platform/wk2/Skipped (121878 => 121879) --- trunk/LayoutTests/platform/wk2/Skipped 2012-07-05 03:48:03 UTC (rev 121878) +++ trunk/LayoutTests/platform/wk2/Skipped 2012-07-05 04:04:55 UTC (rev 121879) @@ -1058,6 +1058,10 @@ # No CORS support for media elements is implemented yet. http/tests/security/video-cross-origin-readback.html +# Content Security Policy 1.1 (ENABLE_CSP_NEXT) is not enabled +# https://bugs.w
[webkit-changes] [121878] trunk/Tools
Title: [121878] trunk/Tools Revision 121878 Author yo...@chromium.org Date 2012-07-04 20:48:03 -0700 (Wed, 04 Jul 2012) Log Message [Tools] webkit_unittest.py got assertion https://bugs.webkit.org/show_bug.cgi?id=90579 Reviewed by Hajime Morita. This patch updates expectation of assertion in test_skipped_directories_for_symbols(). r121874 added new (exclude) directory (inspector/styles/variables), however it didn't update one of two assertions. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py Diff Modified: trunk/Tools/ChangeLog (121877 => 121878) --- trunk/Tools/ChangeLog 2012-07-05 03:30:32 UTC (rev 121877) +++ trunk/Tools/ChangeLog 2012-07-05 03:48:03 UTC (rev 121878) @@ -1,3 +1,16 @@ +2012-07-04 Yoshifumi Inoue + +[Tools] webkit_unittest.py got assertion +https://bugs.webkit.org/show_bug.cgi?id=90579 + +Reviewed by Hajime Morita. + +This patch updates expectation of assertion in test_skipped_directories_for_symbols(). +r121874 added new (exclude) directory (inspector/styles/variables), however it didn't +update one of two assertions. + +* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: + 2012-07-04 Balazs Ankes webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (121877 => 121878) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2012-07-05 03:30:32 UTC (rev 121877) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2012-07-05 03:48:03 UTC (rev 121878) @@ -113,7 +113,7 @@ 0124f670 s __ZZN7WebCore13GraphicsLayer13addChildBelowEPS0_S1_E19__PRETTY_FUNCTION__ """ # Note 'compositing' is not in the list of skipped directories (hence the parsing of GraphicsLayer worked): -expected_directories = set(['mathml', 'transforms/3d', 'compositing/webgl', 'fast/canvas/webgl', 'animations/3d', 'mhtml', 'http/tests/canvas/webgl', 'fast/css/variables']) +expected_directories = set(['mathml', 'transforms/3d', 'compositing/webgl', 'fast/canvas/webgl', 'animations/3d', 'mhtml', 'http/tests/canvas/webgl', 'fast/css/variables', 'inspector/styles/variables']) result_directories = set(TestWebKitPort(symbols_string, None)._skipped_tests_for_unsupported_features(test_list=['mathml/foo.html'])) self.assertEqual(result_directories, expected_directories) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121877] trunk/LayoutTests
Title: [121877] trunk/LayoutTests
Revision 121877
Author commit-qu...@webkit.org
Date 2012-07-04 20:30:32 -0700 (Wed, 04 Jul 2012)
Log Message
AudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=90578
Patch by Li Yin on 2012-07-04
Reviewed by Chris Rogers.
Spec: http://www.w3.org/TR/webaudio/#AudioDestinationNode-section
An AudioSourceNode has no inputs and a single output.
An AudioDestinationNode has one input and no outputs.
Currently, the test webaudio/audionode.html has covered AudioSourceNode,
it is still required to cover AudioDestinationNode.
* webaudio/audionode-expected.txt:
* webaudio/audionode.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webaudio/audionode-expected.txt
trunk/LayoutTests/webaudio/audionode.html
Diff
Modified: trunk/LayoutTests/ChangeLog (121876 => 121877)
--- trunk/LayoutTests/ChangeLog 2012-07-05 01:54:50 UTC (rev 121876)
+++ trunk/LayoutTests/ChangeLog 2012-07-05 03:30:32 UTC (rev 121877)
@@ -1,3 +1,19 @@
+2012-07-04 Li Yin
+
+AudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode
+https://bugs.webkit.org/show_bug.cgi?id=90578
+
+Reviewed by Chris Rogers.
+
+Spec: http://www.w3.org/TR/webaudio/#AudioDestinationNode-section
+An AudioSourceNode has no inputs and a single output.
+An AudioDestinationNode has one input and no outputs.
+Currently, the test webaudio/audionode.html has covered AudioSourceNode,
+it is still required to cover AudioDestinationNode.
+
+* webaudio/audionode-expected.txt:
+* webaudio/audionode.html:
+
2012-07-04 Yoshifumi Inoue
Unreviewed Chromium gardening, drop test expectations for
Modified: trunk/LayoutTests/webaudio/audionode-expected.txt (121876 => 121877)
--- trunk/LayoutTests/webaudio/audionode-expected.txt 2012-07-05 01:54:50 UTC (rev 121876)
+++ trunk/LayoutTests/webaudio/audionode-expected.txt 2012-07-05 03:30:32 UTC (rev 121877)
@@ -7,6 +7,8 @@
PASS audioNode.noteOff() threw exception TypeError: Not enough arguments.
PASS Source AudioNode has no inputs.
PASS Source AudioNode has one output.
+PASS Destination AudioNode has one input.
+PASS Destination AudioNode has no outputs.
PASS connect() exception thrown for illegal destination AudioNode.
PASS connect() exception thrown for illegal output index.
PASS connect() exception thrown for illegal input index.
Modified: trunk/LayoutTests/webaudio/audionode.html (121876 => 121877)
--- trunk/LayoutTests/webaudio/audionode.html 2012-07-05 01:54:50 UTC (rev 121876)
+++ trunk/LayoutTests/webaudio/audionode.html 2012-07-05 03:30:32 UTC (rev 121877)
@@ -31,17 +31,28 @@
shouldThrow("audioNode.noteGrainOn()");
shouldThrow("audioNode.noteOff()");
-// Check number of inputs and outputs.
-if (audioNode.numberOfInputs == 0)
+// Check input and output numbers of AudioSourceNode.
+if (audioNode.numberOfInputs === 0)
testPassed("Source AudioNode has no inputs.");
else
testFailed("Source AudioNode should not have inputs.");
-if (audioNode.numberOfOutputs == 1)
+if (audioNode.numberOfOutputs === 1)
testPassed("Source AudioNode has one output.");
else
testFailed("Source AudioNode should have one output.");
+// Check input and output numbers of AudioDestinationNode
+if (context.destination.numberOfInputs === 1)
+testPassed("Destination AudioNode has one input.");
+else
+testFailed("Destination AudioNode should have one input.");
+
+if (context.destination.numberOfOutputs === 0)
+testPassed("Destination AudioNode has no outputs.");
+else
+testFailed("Destination AudioNode should have no outputs.");
+
// Try calling connect() method with illegal values.
try {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121876] trunk/LayoutTests
Title: [121876] trunk/LayoutTests Revision 121876 Author yo...@chromium.org Date 2012-07-04 18:54:50 -0700 (Wed, 04 Jul 2012) Log Message Unreviewed Chromium gardening, drop test expectations for Chromium-Linux and Chromium-Win. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (121875 => 121876) --- trunk/LayoutTests/ChangeLog 2012-07-05 01:25:08 UTC (rev 121875) +++ trunk/LayoutTests/ChangeLog 2012-07-05 01:54:50 UTC (rev 121876) @@ -1,3 +1,10 @@ +2012-07-04 Yoshifumi Inoue + +Unreviewed Chromium gardening, drop test expectations for +Chromium-Linux and Chromium-Win. + +* platform/chromium/TestExpectations: + 2012-07-04 Anthony Scian Web Inspector [JSC]: Implement ScriptCallStack::stackTrace Modified: trunk/LayoutTests/platform/chromium/TestExpectations (121875 => 121876) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-05 01:25:08 UTC (rev 121875) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-05 01:54:50 UTC (rev 121876) @@ -887,7 +887,7 @@ BUGWK66377 : fast/dom/StyleSheet/gc-parent-rule.html = TEXT BUGWK66377 : fast/dom/StyleSheet/gc-parent-stylesheet.html = TEXT BUGWK66377 : fast/dom/StyleSheet/gc-rule-children-wrappers.html = TEXT -BUGWK66377 : fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml = TEXT +BUGWK66377 MAC : fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml = TEXT // These tests don't work with fast timers due to setTimeout // races. See https://bugs.webkit.org/show_bug.cgi?id=21536 @@ -3061,7 +3061,7 @@ BUGWK78159 DEBUG WIN MAC LINUX : compositing/iframes/scrolling-iframe.html = PASS TEXT -BUGV8_1948 : fast/js/dfg-put-by-id-prototype-check.html = TEXT +BUGV8_1948 MAC : fast/js/dfg-put-by-id-prototype-check.html = TEXT // Tests Error.stack behavior. We aren't consistent with JSC and do not intend to become so. WONTFIX : fast/js/stack-trace.html = TEXT @@ -3394,16 +3394,16 @@ BUGWK84759 : ietestcenter/css3/multicolumn/column-containing-block-001.htm = IMAGE BUGWK84760 : ietestcenter/css3/multicolumn/column-containing-block-002.htm = IMAGE BUGWK84761 : ietestcenter/css3/multicolumn/column-filling-001.htm = IMAGE -BUGWK84764 : ietestcenter/css3/multicolumn/column-width-applies-to-001.htm = IMAGE -BUGWK84767 : ietestcenter/css3/multicolumn/column-width-applies-to-002.htm = IMAGE -BUGWK84768 : ietestcenter/css3/multicolumn/column-width-applies-to-003.htm = IMAGE -BUGWK84769 : ietestcenter/css3/multicolumn/column-width-applies-to-004.htm = IMAGE +BUGWK84764 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-001.htm = IMAGE +BUGWK84767 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-002.htm = IMAGE +BUGWK84768 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-003.htm = IMAGE +BUGWK84769 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-004.htm = IMAGE BUGWK84770 : ietestcenter/css3/multicolumn/column-width-applies-to-007.htm = IMAGE BUGWK84771 : ietestcenter/css3/multicolumn/column-width-applies-to-009.htm = IMAGE BUGWK84772 : ietestcenter/css3/multicolumn/column-width-applies-to-010.htm = IMAGE BUGWK84773 : ietestcenter/css3/multicolumn/column-width-applies-to-012.htm = IMAGE -BUGWK84775 : ietestcenter/css3/multicolumn/column-width-applies-to-013.htm = IMAGE -BUGWK84776 : ietestcenter/css3/multicolumn/column-width-applies-to-014.htm = IMAGE +BUGWK84775 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-013.htm = IMAGE +BUGWK84776 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-014.htm = IMAGE BUGWK84777 : ietestcenter/css3/multicolumn/column-width-applies-to-015.htm = IMAGE BUGWK84778 : ietestcenter/css3/multicolumn/column-width-negative-001.htm = IMAGE // IETC flexbox failures @@ -3545,7 +3545,7 @@ BUGWK86592 LINUX : fast/loader/unload-form-about-blank.html = TIMEOUT PASS BUGWK86592 LINUX : http/tests/xmlhttprequest/zero-length-response-sync.html = TIMEOUT PASS -BUGWK89126 : platform/chromium/compositing/accelerated-drawing/svg-filters.html = IMAGE +BUGWK89126 MAC : platform/chromium/compositing/accelerated-drawing/svg-filters.html = IMAGE // strange "Unexpected no expected results found" on cr-linux ews BUGWK86600 LINUX : http/tests/cache/loaded-from-cache-after-reload-within-iframe.html = MISSING PASS @@ -3667,7 +3667,7 @@ BUGCR132898 : http/tests/websocket/tests/hybi/workers/close.html = PASS TEXT // Flaky -BUGWK89166 : http/tests/messaging/cross-domain-message-event-dispatch.html = TEXT +BUGWK89166 MAC : http/tests/messaging/cross-domain-message-event-dispatch.html = TEXT BUGWK89167 : media/track/track-cue-rendering-snap-to-lines-not-set.html = TEXT // Needs Rebaseline after bug 86942 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121875] trunk/Source/WebCore
Title: [121875] trunk/Source/WebCore
Revision 121875
Author hay...@chromium.org
Date 2012-07-04 18:25:08 -0700 (Wed, 04 Jul 2012)
Log Message
Remove inline keywords from functions which can not be inlined in ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=90432
Reviewed by Hajime Morita.
No new tests - no functional changes.
* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (121874 => 121875)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 00:15:54 UTC (rev 121874)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 01:25:08 UTC (rev 121875)
@@ -1,3 +1,16 @@
+2012-07-04 Hayato Ito
+
+Remove inline keywords from functions which can not be inlined in ComposedShadowTreeWalker
+https://bugs.webkit.org/show_bug.cgi?id=90432
+
+Reviewed by Hajime Morita.
+
+No new tests - no functional changes.
+
+* dom/ComposedShadowTreeWalker.cpp:
+(WebCore::ComposedShadowTreeWalker::traverseParent):
+(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
+
2012-07-04 Luke Macpherson
Inspector crashes when trying to inspect a page with CSS variables
Modified: trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp (121874 => 121875)
--- trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp 2012-07-05 00:15:54 UTC (rev 121874)
+++ trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp 2012-07-05 01:25:08 UTC (rev 121875)
@@ -220,7 +220,9 @@
assertPostcondition();
}
-inline Node* ComposedShadowTreeWalker::traverseParent(const Node* node, ParentTranversalDetails* details) const
+// FIXME: Use an iterative algorithm so that it can be inlined.
+// https://bugs.webkit.org/show_bug.cgi?id=90415
+Node* ComposedShadowTreeWalker::traverseParent(const Node* node, ParentTranversalDetails* details) const
{
if (!canCrossUpperBoundary() && node->isShadowRoot()) {
ASSERT(toShadowRoot(node)->isYoungest());
@@ -248,7 +250,7 @@
return 0;
}
-inline Node* ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost(const ShadowRoot* shadowRoot, ParentTranversalDetails* details) const
+Node* ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost(const ShadowRoot* shadowRoot, ParentTranversalDetails* details) const
{
ASSERT(shadowRoot);
if (shadowRoot->isYoungest()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121874] trunk
Title: [121874] trunk
Revision 121874
Author macpher...@chromium.org
Date 2012-07-04 17:15:54 -0700 (Wed, 04 Jul 2012)
Log Message
Inspector crashes when trying to inspect a page with CSS variables
https://bugs.webkit.org/show_bug.cgi?id=89818
Reviewed by Antti Koivisto.
Patch works by fixing treating handling of CSSPropertyID == CSSPropertyVariable as a special case,
and looking up the author-defined property name from the CSSValue.
Added test inspector/styles/variables/css-variables.html that inspects an element using CSS variables.
Test is skipped when variables are compiled out.
* css/CSSProperty.cpp:
(WebCore::CSSProperty::cssName):
(WebCore):
(WebCore::CSSProperty::cssText):
* css/CSSProperty.h:
(CSSProperty):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::item):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateAllProperties):
Modified Paths
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSProperty.cpp
trunk/Source/WebCore/css/CSSProperty.h
trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
trunk/Source/WebCore/css/StylePropertySet.cpp
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py
Added Paths
trunk/LayoutTests/inspector/styles/variables/
trunk/LayoutTests/inspector/styles/variables/css-variables-expected.txt
trunk/LayoutTests/inspector/styles/variables/css-variables.html
Diff
Added: trunk/LayoutTests/inspector/styles/variables/css-variables-expected.txt (0 => 121874)
--- trunk/LayoutTests/inspector/styles/variables/css-variables-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/styles/variables/css-variables-expected.txt 2012-07-05 00:15:54 UTC (rev 121874)
@@ -0,0 +1,24 @@
+Tests that webkit css variables can be loaded correctly.
+
+Text
+[expanded]
+color: green;
+#inspected - -webkit-var(a) css-variables.html:7
+display: block;
+div - block user agent stylesheet
+
+[expanded]
+element.style { ()
+
+ Matched CSS Rules
+[expanded]
+#inspected { (css-variables.html:7)
+-webkit-var-a: green;
+color: -webkit-var(a);
+
+[expanded]
+div { (user agent stylesheet)
+display: block;
+
+
+
Added: trunk/LayoutTests/inspector/styles/variables/css-variables.html (0 => 121874)
--- trunk/LayoutTests/inspector/styles/variables/css-variables.html (rev 0)
+++ trunk/LayoutTests/inspector/styles/variables/css-variables.html 2012-07-05 00:15:54 UTC (rev 121874)
@@ -0,0 +1,40 @@
+
+
+
+internals.settings.setCSSVariablesEnabled(true);
+
+
+#inspected {
+-webkit-var-a: green;
+color: -webkit-var(a);
+}
+
+
+
+
+function test()
+{
+WebInspector.showPanel("elements");
+InspectorTest.selectNodeAndWaitForStylesWithComputed("inspected", dumpAllStyles);
+
+function dumpAllStyles()
+{
+InspectorTest.dumpSelectedElementStyles();
+InspectorTest.completeTest();
+}
+}
+
+
+
+
+
+
+Tests that webkit css variables can be loaded correctly.
+
+
+Text
+
+
+
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (121873 => 121874)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-04 22:41:17 UTC (rev 121873)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-05 00:15:54 UTC (rev 121874)
@@ -158,6 +158,7 @@
// CSS Variables are not yet enabled.
BUGWK85580 SKIP : fast/css/variables = PASS
+BUGWK85580 SKIP : inspector/styles/variables = PASS
// CSS image-resolution is not yet enabled.
BUGWK85262 SKIP : fast/css/image-resolution = PASS
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (121873 => 121874)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-04 22:41:17 UTC (rev 121873)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-05 00:15:54 UTC (rev 121874)
@@ -318,6 +318,7 @@
// CSS Variables are not yet enabled.
BUGWK85580 SKIP : fast/css/variables = PASS TEXT
+BUGWK85580 SKIP : inspector/styles/variables = PASS
// CSS image-resolution is not yet enabled.
BUGWK85262 SKIP : fast/css/image-resolution = PASS TEXT
Modified: trunk/LayoutTests/platform/mac/TestExpectations (121873 => 121874)
--- trunk/LayoutTests/platform/mac/TestExpectations 2012-07-04 22:41:17 UTC (rev 121873)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2012-07-05 00:15:54 UTC (rev 121874)
@@ -11,6 +11,7 @@
// CSS Variables are not yet enabled.
BUGWK85580 SKIP : fast/css/variables = PASS
+BUGWK85580 SKIP : inspector/styles/variables = PASS
// UndoManager is not yet enabled.
BUGWK87908
[webkit-changes] [121873] trunk/Tools
Title: [121873] trunk/Tools
Revision 121873
Author commit-qu...@webkit.org
Date 2012-07-04 15:41:17 -0700 (Wed, 04 Jul 2012)
Log Message
webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
https://bugs.webkit.org/show_bug.cgi?id=67935
Patch by Balazs Ankes on 2012-07-04
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.set_reviewer):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_set_reviewer):
(test_set_short_description_and_bug_url):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py
trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (121872 => 121873)
--- trunk/Tools/ChangeLog 2012-07-04 22:06:39 UTC (rev 121872)
+++ trunk/Tools/ChangeLog 2012-07-04 22:41:17 UTC (rev 121873)
@@ -1,3 +1,16 @@
+2012-07-04 Balazs Ankes
+
+webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
+https://bugs.webkit.org/show_bug.cgi?id=67935
+
+Reviewed by Ryosuke Niwa.
+
+* Scripts/webkitpy/common/checkout/changelog.py:
+(ChangeLog.set_reviewer):
+* Scripts/webkitpy/common/checkout/changelog_unittest.py:
+(test_set_reviewer):
+(test_set_short_description_and_bug_url):
+
2012-07-04 Sheriff Bot
Unreviewed, rolling out r121862.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py (121872 => 121873)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2012-07-04 22:06:39 UTC (rev 121872)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2012-07-04 22:41:17 UTC (rev 121873)
@@ -345,11 +345,29 @@
print line,
def set_reviewer(self, reviewer):
-# inplace=1 creates a backup file and re-directs stdout to the file
-for line in fileinput.FileInput(self.path, inplace=1):
-# Trailing comma suppresses printing newline
-print line.replace("NOBODY (OOPS!)", reviewer.encode("utf-8")),
+latest_entry = self.latest_entry()
+latest_entry_contents = latest_entry.contents()
+reviewer_text = latest_entry.reviewer()
+found_nobody = re.search("NOBODY\s*\(OOPS!\)", latest_entry_contents, re.MULTILINE)
+if not found_nobody and not reviewer_text:
+bug_url_number_of_items = len(re.findall(config_urls.bug_url_long, latest_entry_contents, re.MULTILINE))
+bug_url_number_of_items += len(re.findall(config_urls.bug_url_short, latest_entry_contents, re.MULTILINE))
+for line in fileinput.FileInput(self.path, inplace=1):
+found_bug_url = re.search(config_urls.bug_url_long, line)
+if not found_bug_url:
+found_bug_url = re.search(config_urls.bug_url_short, line)
+print line,
+if found_bug_url:
+if bug_url_number_of_items == 1:
+print "\nReviewed by %s." % (reviewer.encode("utf-8"))
+bug_url_number_of_items -= 1
+else:
+# inplace=1 creates a backup file and re-directs stdout to the file
+for line in fileinput.FileInput(self.path, inplace=1):
+# Trailing comma suppresses printing newline
+print line.replace("NOBODY (OOPS!)", reviewer.encode("utf-8")),
+
def set_short_description_and_bug_url(self, short_description, bug_url):
message = "%s\n%s" % (short_description, bug_url)
for line in fileinput.FileInput(self.path, inplace=1):
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py (121872 => 121873)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2012-07-04 22:06:39 UTC (rev 121872)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2012-07-04 22:41:17 UTC (rev 121873)
@@ -496,8 +496,46 @@
* Scripts/bugzilla-tool:
'''
+_new_entry_boilerplate_with_bugurl = '''2009-08-19 Eric Seidel
+
+Need a short description and bug URL (OOPS!)
+https://bugs.webkit.org/show_bug.cgi?id=12345
+
+Reviewed by NOBODY (OOPS!).
+
+* Scripts/bugzilla-tool:
+'''
+
+_new_entry_boilerplate_with_multiple_bugurl = '''2009-08-19 Eric Seidel
+
+Need a short description and bug URL (OOPS!)
+https://bugs.webkit.org/show_bug.cgi?id=12345
+http://webkit.org/b/12345
+
+Reviewed by NOBODY (OOPS!).
+
+* Scripts/bugzilla-tool:
+'''
+
+_new_entry_boilerplate_without_reviewer_line = '''2009-08-19 Eric Seidel
+
+Need a short description and bug URL (OOPS!)
+https://bugs.webkit.org/show_bug.cgi?id=12345
+
+* Scripts/bugzilla-tool:
+'''
+
+_new_entry_boilerplate_without_reviewer_multiple_bugurl = '''2009-08-19 Eric Seidel
+
+Need a short description and bug URL (OOPS!)
+https://bugs.webk
[webkit-changes] [121872] trunk/Source/WebKit/blackberry
Title: [121872] trunk/Source/WebKit/blackberry
Revision 121872
Author commit-qu...@webkit.org
Date 2012-07-04 15:06:39 -0700 (Wed, 04 Jul 2012)
Log Message
[BlackBerry] Implement device metrics for blackberry.
https://bugs.webkit.org/show_bug.cgi?id=90494
RIM PR #159034
Patch by Hanna Ma on 2012-07-04
Reviewed by Rob Buis.
Implement calls to the application to change the device metrics for
the web inspector.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::applySizeOverride):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setTextZoomFactor):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::InspectorClientBlackBerry):
(WebCore::InspectorClientBlackBerry::canOverrideDeviceMetrics):
(WebCore):
(WebCore::InspectorClientBlackBerry::overrideDeviceMetrics):
(WebCore::InspectorClientBlackBerry::supportsFrameInstrumentation):
* WebCoreSupport/InspectorClientBlackBerry.h:
(InspectorClientBlackBerry):
Modified Paths
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPageClient.h
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (121871 => 121872)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-07-04 21:36:52 UTC (rev 121871)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-07-04 22:06:39 UTC (rev 121872)
@@ -6600,5 +6600,17 @@
}
}
+void WebPagePrivate::applySizeOverride(int overrideWidth, int overrideHeight)
+{
+m_client->requestUpdateViewport(overrideWidth, overrideHeight);
}
+
+void WebPagePrivate::setTextZoomFactor(float textZoomFactor)
+{
+if (!m_mainFrame)
+return;
+
+m_mainFrame->setTextZoomFactor(textZoomFactor);
}
+}
+}
Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (121871 => 121872)
--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-07-04 21:36:52 UTC (rev 121871)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-07-04 22:06:39 UTC (rev 121872)
@@ -126,6 +126,8 @@
virtual void scrollChanged(const Platform::IntPoint&) const = 0;
virtual void zoomChanged(bool isMinZoomed, bool isMaxZoomed, bool isAtInitialZoom, double newZoom) const = 0;
+virtual void requestUpdateViewport(int width, int height) = 0;
+
virtual void setPageTitle(const unsigned short* title, unsigned titleLength) = 0;
virtual Platform::Graphics::Window* window() const = 0;
Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (121871 => 121872)
--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-07-04 21:36:52 UTC (rev 121871)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-07-04 22:06:39 UTC (rev 121872)
@@ -440,6 +440,9 @@
void setInspectorOverlayClient(WebCore::InspectorOverlay::InspectorOverlayClient*);
+void applySizeOverride(int overrideWidth, int overrideHeight);
+void setTextZoomFactor(float);
+
WebPage* m_webPage;
WebPageClient* m_client;
WebCore::Page* m_page;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (121871 => 121872)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-07-04 21:36:52 UTC (rev 121871)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-07-04 22:06:39 UTC (rev 121872)
@@ -1,3 +1,29 @@
+2012-07-04 Hanna Ma
+
+[BlackBerry] Implement device metrics for blackberry.
+https://bugs.webkit.org/show_bug.cgi?id=90494
+RIM PR #159034
+
+Reviewed by Rob Buis.
+
+Implement calls to the application to change the device metrics for
+the web inspector.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::applySizeOverride):
+(WebKit):
+(BlackBerry::WebKit::WebPagePrivate::setTextZoomFactor):
+* Api/WebPage_p.h:
+(WebPagePrivate):
+* WebCoreSupport/InspectorClientBlackBerry.cpp:
+(WebCore::InspectorClientBlackBerry::InspectorClientBlackBerry):
+(WebCore::InspectorClientBlackBerry::canOverrideDeviceMetrics):
+(WebCore):
+(WebCore::InspectorClientBlackBerry::overrideDeviceMetrics):
+(WebCore::InspectorClientBlackBerry::supportsFrameInstrumentation):
+* WebCoreSupport/InspectorClientBlackBerry.h:
+(InspectorClientBlackBerry):
+
2012-07-03 Leo Yang
[BlackBerry] Checkerboard shown when clicking on error page buttons
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp (121871 => 121872)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp 2012-07-04 21:36:52 UTC (rev 121871)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp 2012-07-04 22:06:39 UTC (rev 121872)
@@ -85,6 +85,23 @@
m_webPagePrivate->m_client->clearCookies(
[webkit-changes] [121871] trunk
Title: [121871] trunk Revision 121871 Author commit-qu...@webkit.org Date 2012-07-04 14:36:52 -0700 (Wed, 04 Jul 2012) Log Message Web Inspector [JSC]: Implement ScriptCallStack::stackTrace https://bugs.webkit.org/show_bug.cgi?id=40118 Patch by Anthony Scian on 2012-07-04 Reviewed by Yong Li. Source/_javascript_Core: Added member functions to expose function name, urlString, and line #. Refactored toString to make use of these member functions to reduce duplicated code for future maintenance. Manually tested refactoring of toString by tracing thrown exceptions. * interpreter/Interpreter.h: (JSC::StackFrame::toString): (JSC::StackFrame::friendlySourceURL): (JSC::StackFrame::friendlyFunctionName): (JSC::StackFrame::friendlyLineNumber): Source/WebCore: Implemented stub for createScriptCallStack to call into Interpreter and extract the current stack frames, iterate through the frames and create the return result required. No new tests, manually tested thrown exception and inspector tracebacks. * bindings/js/ScriptCallStackFactory.cpp: (WebCore::createScriptCallStack): LayoutTests: Updated test results now that createScriptCallStack is functional. * http/tests/inspector/console-resource-errors-expected.txt: * http/tests/inspector/console-xhr-logging-async-expected.txt: * http/tests/inspector/console-xhr-logging-expected.txt: * http/tests/inspector/network/script-as-text-loading-expected.txt: * inspector/timeline/timeline-animation-frame-expected.txt: * inspector/timeline/timeline-layout-expected.txt: * inspector/timeline/timeline-mark-timeline-expected.txt: * inspector/timeline/timeline-network-resource-expected.txt: * inspector/timeline/timeline-paint-expected.txt: * inspector/timeline/timeline-parse-html-expected.txt: * inspector/timeline/timeline-time-stamp-expected.txt: * inspector/timeline/timeline-timer-expected.txt: * platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/console-resource-errors-expected.txt trunk/LayoutTests/http/tests/inspector/console-xhr-logging-async-expected.txt trunk/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt trunk/LayoutTests/http/tests/inspector/network/script-as-text-loading-expected.txt trunk/LayoutTests/inspector/timeline/timeline-animation-frame-expected.txt trunk/LayoutTests/inspector/timeline/timeline-layout-expected.txt trunk/LayoutTests/inspector/timeline/timeline-mark-timeline-expected.txt trunk/LayoutTests/inspector/timeline/timeline-network-resource-expected.txt trunk/LayoutTests/inspector/timeline/timeline-paint-expected.txt trunk/LayoutTests/inspector/timeline/timeline-parse-html-expected.txt trunk/LayoutTests/inspector/timeline/timeline-time-stamp-expected.txt trunk/LayoutTests/inspector/timeline/timeline-timer-expected.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/interpreter/Interpreter.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.cpp Added Paths trunk/LayoutTests/platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (121870 => 121871) --- trunk/LayoutTests/ChangeLog 2012-07-04 20:50:54 UTC (rev 121870) +++ trunk/LayoutTests/ChangeLog 2012-07-04 21:36:52 UTC (rev 121871) @@ -1,3 +1,26 @@ +2012-07-04 Anthony Scian + +Web Inspector [JSC]: Implement ScriptCallStack::stackTrace +https://bugs.webkit.org/show_bug.cgi?id=40118 + +Reviewed by Yong Li. + +Updated test results now that createScriptCallStack is functional. + +* http/tests/inspector/console-resource-errors-expected.txt: +* http/tests/inspector/console-xhr-logging-async-expected.txt: +* http/tests/inspector/console-xhr-logging-expected.txt: +* http/tests/inspector/network/script-as-text-loading-expected.txt: +* inspector/timeline/timeline-animation-frame-expected.txt: +* inspector/timeline/timeline-layout-expected.txt: +* inspector/timeline/timeline-mark-timeline-expected.txt: +* inspector/timeline/timeline-network-resource-expected.txt: +* inspector/timeline/timeline-paint-expected.txt: +* inspector/timeline/timeline-parse-html-expected.txt: +* inspector/timeline/timeline-time-stamp-expected.txt: +* inspector/timeline/timeline-timer-expected.txt: +* platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt: + 2012-07-04 Zan Dobersek Unreviewed GTK gardening, skip another two http tests that Modified: trunk/LayoutTests/http/tests/inspector/console-resource-errors-expected.txt (121870 => 121871) --- trunk/LayoutTests/http/tests/inspector/console-resource-errors-expected.txt 2012-07-04 20:50:54 UTC (rev 121870) +++ trunk/LayoutTests/http/tests/inspector/console-resource-errors-expected.txt 2012-07-04 21:36:52 UTC (rev 121871) @@ -4,5 +4,5 @@
[webkit-changes] [121869] trunk/Source
Title: [121869] trunk/Source Revision 121869 Author wi...@igalia.com Date 2012-07-04 13:32:26 -0700 (Wed, 04 Jul 2012) Log Message [GTK] Enable parallel GC https://bugs.webkit.org/show_bug.cgi?id=90568 Reviewed by Martin Robinson. Source/_javascript_Core: * runtime/Options.cpp: Include for std::min. Source/WTF: * wtf/Platform.h: Add GTK to the ENABLE_PARALLEL_GC party. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/Options.cpp trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (121868 => 121869) --- trunk/Source/_javascript_Core/ChangeLog 2012-07-04 19:23:21 UTC (rev 121868) +++ trunk/Source/_javascript_Core/ChangeLog 2012-07-04 20:32:26 UTC (rev 121869) @@ -1,3 +1,12 @@ +2012-07-04 Andy Wingo + +[GTK] Enable parallel GC +https://bugs.webkit.org/show_bug.cgi?id=90568 + +Reviewed by Martin Robinson. + +* runtime/Options.cpp: Include for std::min. + 2012-07-04 John Mellor Text Autosizing: Add compile flag and runtime setting Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (121868 => 121869) --- trunk/Source/_javascript_Core/runtime/Options.cpp 2012-07-04 19:23:21 UTC (rev 121868) +++ trunk/Source/_javascript_Core/runtime/Options.cpp 2012-07-04 20:32:26 UTC (rev 121869) @@ -26,6 +26,7 @@ #include "config.h" #include "Options.h" +#include #include #include #include Modified: trunk/Source/WTF/ChangeLog (121868 => 121869) --- trunk/Source/WTF/ChangeLog 2012-07-04 19:23:21 UTC (rev 121868) +++ trunk/Source/WTF/ChangeLog 2012-07-04 20:32:26 UTC (rev 121869) @@ -1,3 +1,12 @@ +2012-07-04 Andy Wingo + +[GTK] Enable parallel GC +https://bugs.webkit.org/show_bug.cgi?id=90568 + +Reviewed by Martin Robinson. + +* wtf/Platform.h: Add GTK to the ENABLE_PARALLEL_GC party. + 2012-07-04 Tor Arne Vestbø [Qt] Get rid of un-needed QT += declarative for Qt 5 Modified: trunk/Source/WTF/wtf/Platform.h (121868 => 121869) --- trunk/Source/WTF/wtf/Platform.h 2012-07-04 19:23:21 UTC (rev 121868) +++ trunk/Source/WTF/wtf/Platform.h 2012-07-04 20:32:26 UTC (rev 121869) @@ -1075,7 +1075,7 @@ #define ENABLE_OBJECT_MARK_LOGGING 0 -#if !defined(ENABLE_PARALLEL_GC) && !ENABLE(OBJECT_MARK_LOGGING) && (PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || PLATFORM(BLACKBERRY)) && ENABLE(COMPARE_AND_SWAP) +#if !defined(ENABLE_PARALLEL_GC) && !ENABLE(OBJECT_MARK_LOGGING) && (PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || PLATFORM(BLACKBERRY) || PLATFORM(GTK)) && ENABLE(COMPARE_AND_SWAP) #define ENABLE_PARALLEL_GC 1 #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121868] trunk/LayoutTests
Title: [121868] trunk/LayoutTests Revision 121868 Author zandober...@gmail.com Date 2012-07-04 12:23:21 -0700 (Wed, 04 Jul 2012) Log Message Unreviewed GTK gardening, skip another two http tests that timeout and just extend the complete build cycle. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (121867 => 121868) --- trunk/LayoutTests/ChangeLog 2012-07-04 17:47:41 UTC (rev 121867) +++ trunk/LayoutTests/ChangeLog 2012-07-04 19:23:21 UTC (rev 121868) @@ -1,3 +1,10 @@ +2012-07-04 Zan Dobersek + +Unreviewed GTK gardening, skip another two http tests that +timeout and just extend the complete build cycle. + +* platform/gtk/TestExpectations: + 2012-07-04 Andrey Kosyakov Unreviewed, rolling out r121767. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (121867 => 121868) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-04 17:47:41 UTC (rev 121867) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-04 19:23:21 UTC (rev 121868) @@ -558,6 +558,7 @@ BUGWKGTK : fast/loader/reload-policy-delegate.html = TEXT BUGWKGTK : fast/loader/stop-provisional-loads.html = TEXT BUGWKGTK : fast/loader/subframe-removes-itself.html = TEXT +BUGWKGTK SKIP : http/tests/security/feed-urls-from-remote.html = TEXT // This policy delegate is implemented, but it needs the DOM node path in the output. BUGWKGTK : fast/encoding/mailto-always-utf-8.html = TEXT @@ -708,6 +709,7 @@ // Needs to make sure the redirect-chain scenario in https://bugs.webkit.org/show_bug.cgi?id=31410 works BUGWK35300 : http/tests/loading/307-after-303-after-post.html = TEXT +BUGWK35300 SKIP : http/tests/navigation/post-307-response.html = TEXT // mouseScrollBy() and continuousMouseScrollBy() are not yet implemented in the GTK EventSender API. BUGWK36003 : fast/events/remove-child-onscroll.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121867] trunk/Tools
Title: [121867] trunk/Tools
Revision 121867
Author commit-qu...@webkit.org
Date 2012-07-04 10:47:41 -0700 (Wed, 04 Jul 2012)
Log Message
Unreviewed, rolling out r121862.
http://trac.webkit.org/changeset/121862
https://bugs.webkit.org/show_bug.cgi?id=90569
It broke built-product-archive for GTK, Qt and EFL (Requested
by svillar on #webkit).
Patch by Sheriff Bot on 2012-07-04
* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
Modified Paths
trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (121866 => 121867)
--- trunk/Tools/BuildSlaveSupport/built-product-archive 2012-07-04 17:43:12 UTC (rev 121866)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive 2012-07-04 17:47:41 UTC (rev 121867)
@@ -147,7 +147,7 @@
neededDirectories = ["Programs", ".libs", "Libraries"]
for dirname in neededDirectories:
-fromDir = os.path.join(configurationBuildDirectory, dirname)
+fromDir = os.path.join(configurationBuildDirectory, dirname, "*")
toDir = os.path.join(thinDirectory, dirname)
os.makedirs(toDir)
if subprocess.call('cp -R %s %s' % (fromDir, toDir), shell=True):
Modified: trunk/Tools/ChangeLog (121866 => 121867)
--- trunk/Tools/ChangeLog 2012-07-04 17:43:12 UTC (rev 121866)
+++ trunk/Tools/ChangeLog 2012-07-04 17:47:41 UTC (rev 121867)
@@ -1,3 +1,15 @@
+2012-07-04 Sheriff Bot
+
+Unreviewed, rolling out r121862.
+http://trac.webkit.org/changeset/121862
+https://bugs.webkit.org/show_bug.cgi?id=90569
+
+It broke built-product-archive for GTK, Qt and EFL (Requested
+by svillar on #webkit).
+
+* BuildSlaveSupport/built-product-archive:
+(archiveBuiltProduct):
+
2012-07-04 Sergio Villar Senin
Hidden dirs are not copied when creating the built product archive
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121866] trunk/Source/WebCore
Title: [121866] trunk/Source/WebCore Revision 121866 Author commit-qu...@webkit.org Date 2012-07-04 10:43:12 -0700 (Wed, 04 Jul 2012) Log Message Text Autosizing: Add basic framework https://bugs.webkit.org/show_bug.cgi?id=88655 This adds a highly simplified foundation that subsequent Text Autosizing patches can build upon. I've refactored this code (since the earlier combined diff uploaded to http://webkit.org/b/84186) to touch as few files as possible. Patch by John Mellor on 2012-07-04 Reviewed by Adam Barth. No new tests. I plan to add a test framework as my next Text Autosizing patch. * WebCore.gypi: * dom/Document.cpp: (WebCore::Document::Document): * dom/Document.h: (WebCore): (Document): (WebCore::Document::textAutosizer): * page/FrameView.cpp: (WebCore::FrameView::layout): * rendering/TextAutosizer.cpp: Added. (WebCore): (WebCore::TextAutosizer::TextAutosizer): (WebCore::TextAutosizer::~TextAutosizer): (WebCore::TextAutosizer::create): (WebCore::TextAutosizer::boostSubtree): (WebCore::TextAutosizer::boostBlock): (WebCore::TextAutosizer::boostText): (WebCore::TextAutosizer::treatAsInline): (WebCore::TextAutosizer::traverseNext): (WebCore::TextAutosizer::cloneRenderStyleWithState): * rendering/TextAutosizer.h: Added. (WebCore): (TextAutosizer): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/page/FrameView.cpp Added Paths trunk/Source/WebCore/rendering/TextAutosizer.cpp trunk/Source/WebCore/rendering/TextAutosizer.h Diff Modified: trunk/Source/WebCore/ChangeLog (121865 => 121866) --- trunk/Source/WebCore/ChangeLog 2012-07-04 17:39:26 UTC (rev 121865) +++ trunk/Source/WebCore/ChangeLog 2012-07-04 17:43:12 UTC (rev 121866) @@ -1,3 +1,40 @@ +2012-07-04 John Mellor + +Text Autosizing: Add basic framework +https://bugs.webkit.org/show_bug.cgi?id=88655 + +This adds a highly simplified foundation that subsequent Text Autosizing patches +can build upon. I've refactored this code (since the earlier combined diff +uploaded to http://webkit.org/b/84186) to touch as few files as possible. + +Reviewed by Adam Barth. + +No new tests. I plan to add a test framework as my next Text Autosizing patch. + +* WebCore.gypi: +* dom/Document.cpp: +(WebCore::Document::Document): +* dom/Document.h: +(WebCore): +(Document): +(WebCore::Document::textAutosizer): +* page/FrameView.cpp: +(WebCore::FrameView::layout): +* rendering/TextAutosizer.cpp: Added. +(WebCore): +(WebCore::TextAutosizer::TextAutosizer): +(WebCore::TextAutosizer::~TextAutosizer): +(WebCore::TextAutosizer::create): +(WebCore::TextAutosizer::boostSubtree): +(WebCore::TextAutosizer::boostBlock): +(WebCore::TextAutosizer::boostText): +(WebCore::TextAutosizer::treatAsInline): +(WebCore::TextAutosizer::traverseNext): +(WebCore::TextAutosizer::cloneRenderStyleWithState): +* rendering/TextAutosizer.h: Added. +(WebCore): +(TextAutosizer): + 2012-07-04 Andrey Kosyakov Unreviewed, rolling out r121767. Modified: trunk/Source/WebCore/WebCore.gypi (121865 => 121866) --- trunk/Source/WebCore/WebCore.gypi 2012-07-04 17:39:26 UTC (rev 121865) +++ trunk/Source/WebCore/WebCore.gypi 2012-07-04 17:43:12 UTC (rev 121866) @@ -4630,6 +4630,8 @@ 'rendering/FixedTableLayout.h', 'rendering/FlowThreadController.cpp', 'rendering/FlowThreadController.h', +'rendering/TextAutosizer.cpp', +'rendering/TextAutosizer.h', 'rendering/HitTestingTransformState.cpp', 'rendering/HitTestingTransformState.h', 'rendering/HitTestResult.cpp', Modified: trunk/Source/WebCore/dom/Document.cpp (121865 => 121866) --- trunk/Source/WebCore/dom/Document.cpp 2012-07-04 17:39:26 UTC (rev 121865) +++ trunk/Source/WebCore/dom/Document.cpp 2012-07-04 17:43:12 UTC (rev 121866) @@ -216,6 +216,10 @@ #include "Prerenderer.h" #endif +#if ENABLE(TEXT_AUTOSIZING) +#include "TextAutosizer.h" +#endif + using namespace std; using namespace WTF; using namespace Unicode; @@ -516,6 +520,9 @@ #if ENABLE(LINK_PRERENDER) m_prerenderer = Prerenderer::create(this); #endif +#if ENABLE(TEXT_AUTOSIZING) +m_textAutosizer = TextAutosizer::create(this); +#endif m_visuallyOrdered = false; m_bParsing = false; m_wellFormed = false; Modified: trunk/Source/WebCore/dom/Document.h (121865 => 121866) --- trunk/Source/WebCore/dom/Document.h 2012-07-04 17:39:26 UTC (rev 121865) +++ trunk/Source/WebCore/dom/Document.h 2012-07-04 17:43:12 UTC (rev 121866) @@ -173,6 +173,10 @@ class Prerenderer; #endif +#if ENABLE(TEXT_AUTOSIZING) +class TextAutosizer; +#endif + typedef int ExceptionCode; enum Pageshow
[webkit-changes] [121865] trunk
Title: [121865] trunk
Revision 121865
Author ca...@chromium.org
Date 2012-07-04 10:39:26 -0700 (Wed, 04 Jul 2012)
Log Message
Unreviewed, rolling out r121767.
http://trac.webkit.org/changeset/121767
https://bugs.webkit.org/show_bug.cgi?id=89584
Crashes inspected page while recording timeline due to
conflict with BeginFrame in record stack
Source/WebCore:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willProcessTask):
(WebCore::InspectorTimelineAgent::didProcessTask):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onRecordAdded):
* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord):
(WebInspector.TimelineCategoryStrips.prototype.update):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.recordStyle):
(WebInspector.TimelinePresentationModel.categoryForRecord):
(WebInspector.TimelinePresentationModel.forAllRecords):
(WebInspector.TimelinePresentationModel.prototype.addRecord):
LayoutTests:
* inspector/timeline-dfs-expected.txt: Removed.
* inspector/timeline-dfs.html: Removed.
* inspector/timeline/timeline-enum-stability-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebCore/inspector/front-end/MemoryStatistics.js
trunk/Source/WebCore/inspector/front-end/TimelineFrameController.js
trunk/Source/WebCore/inspector/front-end/TimelineModel.js
trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
Removed Paths
trunk/LayoutTests/inspector/timeline-dfs-expected.txt
trunk/LayoutTests/inspector/timeline-dfs.html
Diff
Modified: trunk/LayoutTests/ChangeLog (121864 => 121865)
--- trunk/LayoutTests/ChangeLog 2012-07-04 17:27:20 UTC (rev 121864)
+++ trunk/LayoutTests/ChangeLog 2012-07-04 17:39:26 UTC (rev 121865)
@@ -1,3 +1,16 @@
+2012-07-04 Andrey Kosyakov
+
+Unreviewed, rolling out r121767.
+http://trac.webkit.org/changeset/121767
+https://bugs.webkit.org/show_bug.cgi?id=89584
+
+Crashes inspected page while recording timeline due to
+conflict with BeginFrame in record stack
+
+* inspector/timeline-dfs-expected.txt: Removed.
+* inspector/timeline-dfs.html: Removed.
+* inspector/timeline/timeline-enum-stability-expected.txt:
+
2012-07-04 Alexander Pavlov
Web Inspector: Emulate pseudo styles (hover etc.) of non-selected elements
Modified: trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt (121864 => 121865)
--- trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt 2012-07-04 17:27:20 UTC (rev 121864)
+++ trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt 2012-07-04 17:39:26 UTC (rev 121865)
@@ -4,7 +4,6 @@
{
Root : "Root"
-Program : "Program"
EventDispatch : "EventDispatch"
BeginFrame : "BeginFrame"
Layout : "Layout"
Deleted: trunk/LayoutTests/inspector/timeline-dfs-expected.txt (121864 => 121865)
--- trunk/LayoutTests/inspector/timeline-dfs-expected.txt 2012-07-04 17:27:20 UTC (rev 121864)
+++ trunk/LayoutTests/inspector/timeline-dfs-expected.txt 2012-07-04 17:39:26 UTC (rev 121865)
@@ -1,34 +0,0 @@
-Tests TimelinePresentationModel.forAllRecords function.
-
-DFS preorder:
-a
-aa
-aaa
-aab
-ab
-aba
-abb
-b
-ba
-baa
-bab
-bb
-bba
-bbb
-
-DFS postorder:
-aaa
-aab
-aa
-aba
-abb
-ab
-a
-baa
-bab
-ba
-bba
-bbb
-bb
-b
-
Deleted: trunk/LayoutTests/inspector/timeline-dfs.html (121864 => 121865)
--- trunk/LayoutTests/inspector/timeline-dfs.html 2012-07-04 17:27:20 UTC (rev 121864)
+++ trunk/LayoutTests/inspector/timeline-dfs.html 2012-07-04 17:39:26 UTC (rev 121865)
@@ -1,50 +0,0 @@
-
-
-
-
-var test = function()
-{
-function dumper(record)
-{
-InspectorTest.addResult(record.name);
-}
-
-var records = [
-{"name" : "a", "children" : [
-{"name" : "aa", "children": [
-{"name" : "aaa"},
-{"name" : "aab"},
-
[webkit-changes] [121864] trunk/Source
Title: [121864] trunk/Source
Revision 121864
Author dan...@chromium.org
Date 2012-07-04 10:27:20 -0700 (Wed, 04 Jul 2012)
Log Message
[chromium] Clear RenderSurfaces still when no idle paint will be done
https://bugs.webkit.org/show_bug.cgi?id=90553
Reviewed by Adrienne Walker.
Source/WebCore:
Currently if idle painting is disabled, updateLayers() will early-out.
But this prevents it from doing cleanup and clearing all RenderSurface
pointers, leaving the layer tree in an unexpected state.
Tests: CCLayerTreeHostTestCompositeAndReadbackCleanup
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
Source/WebKit/chromium:
* tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestCompositeAndReadbackCleanup):
(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::CCLayerTreeHostTestCompositeAndReadbackCleanup):
(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::beginTest):
(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::afterTest):
(WTF):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (121863 => 121864)
--- trunk/Source/WebCore/ChangeLog 2012-07-04 17:18:17 UTC (rev 121863)
+++ trunk/Source/WebCore/ChangeLog 2012-07-04 17:27:20 UTC (rev 121864)
@@ -1,3 +1,19 @@
+2012-07-04 Dana Jansens
+
+[chromium] Clear RenderSurfaces still when no idle paint will be done
+https://bugs.webkit.org/show_bug.cgi?id=90553
+
+Reviewed by Adrienne Walker.
+
+Currently if idle painting is disabled, updateLayers() will early-out.
+But this prevents it from doing cleanup and clearing all RenderSurface
+pointers, leaving the layer tree in an unexpected state.
+
+Tests: CCLayerTreeHostTestCompositeAndReadbackCleanup
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::updateLayers):
+
2012-07-04 John Mellor
Text Autosizing: Add compile flag and runtime setting
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (121863 => 121864)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2012-07-04 17:18:17 UTC (rev 121863)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2012-07-04 17:27:20 UTC (rev 121864)
@@ -493,13 +493,13 @@
prioritizeTextures(updateList);
paintLayerContents(updateList, PaintVisible, updater);
-if (!m_triggerIdlePaints)
-return;
-// The second (idle) paint will be a no-op in layers where painting already occured above.
-// FIXME: This pass can be merged with the visible pass now that textures
-//are prioritized above.
-paintLayerContents(updateList, PaintIdle, updater);
+if (m_triggerIdlePaints) {
+// The second (idle) paint will be a no-op in layers where painting already occured above.
+// FIXME: This pass can be merged with the visible pass now that textures
+//are prioritized above.
+paintLayerContents(updateList, PaintIdle, updater);
+}
for (size_t i = 0; i < updateList.size(); ++i)
updateList[i]->clearRenderSurface();
Modified: trunk/Source/WebKit/chromium/ChangeLog (121863 => 121864)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-04 17:18:17 UTC (rev 121863)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-04 17:27:20 UTC (rev 121864)
@@ -1,5 +1,19 @@
2012-07-04 Dana Jansens
+[chromium] Clear RenderSurfaces still when no idle paint will be done
+https://bugs.webkit.org/show_bug.cgi?id=90553
+
+Reviewed by Adrienne Walker.
+
+* tests/CCLayerTreeHostTest.cpp:
+(CCLayerTreeHostTestCompositeAndReadbackCleanup):
+(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::CCLayerTreeHostTestCompositeAndReadbackCleanup):
+(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::beginTest):
+(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::afterTest):
+(WTF):
+
+2012-07-04 Dana Jansens
+
[chromium] Remove CCLayerTreeHostTestThreadOnly class to cleanup CCLayerTreeHostTests
https://bugs.webkit.org/show_bug.cgi?id=90556
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (121863 => 121864)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2012-07-04 17:18:17 UTC (rev 121863)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2012-07-04 17:27:20 UTC (rev 121864)
@@ -2251,4 +2251,26 @@
runTest(true);
}
+class CCLayerTreeHostTestCompositeAndReadbackCleanup : public CCLayerTreeHostTest {
+public:
+CCLayerTreeHostTestCompositeAndReadbackCleanup() { }
+
+virtual void beginTest()
+{
+LayerChromium* rootLayer = m_layerTreeHost->rootLayer();
+
+OwnArrayPtr pixels
[webkit-changes] [121863] trunk/Source/WebKit/chromium
Title: [121863] trunk/Source/WebKit/chromium
Revision 121863
Author dan...@chromium.org
Date 2012-07-04 10:18:17 -0700 (Wed, 04 Jul 2012)
Log Message
[chromium] Remove CCLayerTreeHostTestThreadOnly class to cleanup CCLayerTreeHostTests
https://bugs.webkit.org/show_bug.cgi?id=90556
Reviewed by Adrienne Walker.
Currently many tests that run both single and threaded versions subclass
from CCLayerTreeHostTestThreadOnly just from copy/pasting. The class
only adds a runTestThreaded() which calls runTest(true). Many other
tests do run only in threaded mode call runTest(true) themselves, making
for an inconsistent mess.
We remove CCLayerTreeHostTestThreadOnly class, so we don't have tests
inheriting it that are not thread-only. And now all tests that are
thread-only call runTest(true) consistently.
* tests/CCLayerTreeHostTest.cpp:
(WTF::TEST_F):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (121862 => 121863)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-04 16:43:03 UTC (rev 121862)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-04 17:18:17 UTC (rev 121863)
@@ -1,3 +1,23 @@
+2012-07-04 Dana Jansens
+
+[chromium] Remove CCLayerTreeHostTestThreadOnly class to cleanup CCLayerTreeHostTests
+https://bugs.webkit.org/show_bug.cgi?id=90556
+
+Reviewed by Adrienne Walker.
+
+Currently many tests that run both single and threaded versions subclass
+from CCLayerTreeHostTestThreadOnly just from copy/pasting. The class
+only adds a runTestThreaded() which calls runTest(true). Many other
+tests do run only in threaded mode call runTest(true) themselves, making
+for an inconsistent mess.
+
+We remove CCLayerTreeHostTestThreadOnly class, so we don't have tests
+inheriting it that are not thread-only. And now all tests that are
+thread-only call runTest(true) consistently.
+
+* tests/CCLayerTreeHostTest.cpp:
+(WTF::TEST_F):
+
2012-07-04 John Mellor
Text Autosizing: Add compile flag and runtime setting
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (121862 => 121863)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2012-07-04 16:43:03 UTC (rev 121862)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2012-07-04 17:18:17 UTC (rev 121863)
@@ -57,7 +57,6 @@
namespace {
class CCLayerTreeHostTest : public CCThreadedTest { };
-class CCLayerTreeHostTestThreadOnly : public CCThreadedTestThreadOnly { };
// Shortlived layerTreeHosts shouldn't die.
class CCLayerTreeHostTestShortlived1 : public CCLayerTreeHostTest {
@@ -125,7 +124,7 @@
SINGLE_AND_MULTI_THREAD_TEST_F(CCLayerTreeHostTestShortlived3)
// Test interleaving of redraws and commits
-class CCLayerTreeHostTestCommitingWithContinuousRedraw : public CCLayerTreeHostTestThreadOnly {
+class CCLayerTreeHostTestCommitingWithContinuousRedraw : public CCLayerTreeHostTest {
public:
CCLayerTreeHostTestCommitingWithContinuousRedraw()
: m_numCompleteCommits(0)
@@ -164,12 +163,12 @@
TEST_F(CCLayerTreeHostTestCommitingWithContinuousRedraw, runMultiThread)
{
-runTestThreaded();
+runTest(true);
}
// Two setNeedsCommits in a row should lead to at least 1 commit and at least 1
// draw with frame 0.
-class CCLayerTreeHostTestSetNeedsCommit1 : public CCLayerTreeHostTestThreadOnly {
+class CCLayerTreeHostTestSetNeedsCommit1 : public CCLayerTreeHostTest {
public:
CCLayerTreeHostTestSetNeedsCommit1()
: m_numCommits(0)
@@ -208,12 +207,12 @@
TEST_F(CCLayerTreeHostTestSetNeedsCommit1, DISABLED_runMultiThread)
{
-runTestThreaded();
+runTest(true);
}
// A setNeedsCommit should lead to 1 commit. Issuing a second commit after that
// first committed frame draws should lead to another commit.
-class CCLayerTreeHostTestSetNeedsCommit2 : public CCLayerTreeHostTestThreadOnly {
+class CCLayerTreeHostTestSetNeedsCommit2 : public CCLayerTreeHostTest {
public:
CCLayerTreeHostTestSetNeedsCommit2()
: m_numCommits(0)
@@ -257,12 +256,12 @@
TEST_F(CCLayerTreeHostTestSetNeedsCommit2, runMultiThread)
#endif
{
-runTestThreaded();
+runTest(true);
}
// 1 setNeedsRedraw after the first commit has completed should lead to 1
// additional draw.
-class CCLayerTreeHostTestSetNeedsRedraw : public CCLayerTreeHostTestThreadOnly {
+class CCLayerTreeHostTestSetNeedsRedraw : public CCLayerTreeHostTest {
public:
CCLayerTreeHostTestSetNeedsRedraw()
: m_numCommits(0)
@@ -304,11 +303,11 @@
TEST_F(CCLayerTreeHostTestSetNeedsRedraw, runMultiThread)
{
-runTestThreaded();
+runTest(true);
}
// If the layerTreeHost says it can't draw, then we should not try to draw.
-class CCLayerTreeHostTestCanDrawBlocksDrawing : public CCLayerTreeHostTestThreadOnly {
+class CCLayerTreeHostTestCanDrawBlocksDrawing :
[webkit-changes] [121862] trunk/Tools
Title: [121862] trunk/Tools
Revision 121862
Author ser...@webkit.org
Date 2012-07-04 09:43:03 -0700 (Wed, 04 Jul 2012)
Log Message
Hidden dirs are not copied when creating the built product archive
https://bugs.webkit.org/show_bug.cgi?id=90559
Reviewed by Carlos Garcia Campos.
Hidden dirs are not copied inside the built product archive because
the recursive copy command was ignoring them. We need those hidden
directories for the GTK WebKit2 testing bot to work fine.
* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): removed the trailing "*" from the copy
command.
Modified Paths
trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (121861 => 121862)
--- trunk/Tools/BuildSlaveSupport/built-product-archive 2012-07-04 16:16:01 UTC (rev 121861)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive 2012-07-04 16:43:03 UTC (rev 121862)
@@ -147,7 +147,7 @@
neededDirectories = ["Programs", ".libs", "Libraries"]
for dirname in neededDirectories:
-fromDir = os.path.join(configurationBuildDirectory, dirname, "*")
+fromDir = os.path.join(configurationBuildDirectory, dirname)
toDir = os.path.join(thinDirectory, dirname)
os.makedirs(toDir)
if subprocess.call('cp -R %s %s' % (fromDir, toDir), shell=True):
Modified: trunk/Tools/ChangeLog (121861 => 121862)
--- trunk/Tools/ChangeLog 2012-07-04 16:16:01 UTC (rev 121861)
+++ trunk/Tools/ChangeLog 2012-07-04 16:43:03 UTC (rev 121862)
@@ -1,3 +1,18 @@
+2012-07-04 Sergio Villar Senin
+
+Hidden dirs are not copied when creating the built product archive
+https://bugs.webkit.org/show_bug.cgi?id=90559
+
+Reviewed by Carlos Garcia Campos.
+
+Hidden dirs are not copied inside the built product archive because
+the recursive copy command was ignoring them. We need those hidden
+directories for the GTK WebKit2 testing bot to work fine.
+
+* BuildSlaveSupport/built-product-archive:
+(archiveBuiltProduct): removed the trailing "*" from the copy
+command.
+
2012-07-04 John Mellor
Text Autosizing: Add compile flag and runtime setting
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121859] trunk/Source/WebCore
Title: [121859] trunk/Source/WebCore Revision 121859 Author pfeld...@chromium.org Date 2012-07-04 08:36:28 -0700 (Wed, 04 Jul 2012) Log Message Web Inspector: fix search on the network panel. https://bugs.webkit.org/show_bug.cgi?id=90557 Reviewed by Vsevolod Vlasov. * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/NetworkPanel.js Diff Modified: trunk/Source/WebCore/ChangeLog (121858 => 121859) --- trunk/Source/WebCore/ChangeLog 2012-07-04 15:31:53 UTC (rev 121858) +++ trunk/Source/WebCore/ChangeLog 2012-07-04 15:36:28 UTC (rev 121859) @@ -1,3 +1,13 @@ +2012-07-04 Pavel Feldman + +Web Inspector: fix search on the network panel. +https://bugs.webkit.org/show_bug.cgi?id=90557 + +Reviewed by Vsevolod Vlasov. + +* inspector/front-end/NetworkPanel.js: +(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest): + 2012-07-04 Kwang Yul Seo Stop tracking line number in tokenizer Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (121858 => 121859) --- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-07-04 15:31:53 UTC (rev 121858) +++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-07-04 15:36:28 UTC (rev 121859) @@ -1135,7 +1135,7 @@ this._highlightedSubstringChanges = node._highlightMatchedSubstring(this._searchRegExp); if (reveal) node.reveal(); -this._currentMatcRequestrceIndex = matchedRequestIndex; +this._currentMatchedRequestIndex = matchedRequestIndex; } this.dispatchEventToListeners(WebInspector.NetworkLogView.EventTypes.SearchIndexUpdated, this._currentMatchedRequestIndex); }, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121858] trunk/Source/WebCore
Title: [121858] trunk/Source/WebCore Revision 121858 Author k...@webkit.org Date 2012-07-04 08:31:53 -0700 (Wed, 04 Jul 2012) Log Message Stop tracking line number in tokenizer https://bugs.webkit.org/show_bug.cgi?id=90544 Reviewed by Adam Barth. Because SegmentedString knows how to track the current line and column, a tokenizer does not need to keep track of the current line by itself. No behavior change, so no new tests. * html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::lineNumber): (WebCore::HTMLDocumentParser::textPosition): * html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::flushBufferedEndTag): (WebCore): (WebCore::HTMLTokenizer::nextToken): * html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processScriptStartTag): * html/track/WebVTTTokenizer.cpp: (WebCore::WebVTTTokenizer::reset): (WebCore::WebVTTTokenizer::nextToken): * platform/text/SegmentedString.cpp: (WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase): * platform/text/SegmentedString.h: (WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber): (WebCore::SegmentedString::advanceAndUpdateLineNumber): (SegmentedString): * xml/parser/MarkupTokenizerBase.h: (WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek): (WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance): (WebCore::MarkupTokenizerBase::emitAndResumeIn): (WebCore::MarkupTokenizerBase::emitEndOfFile): (WebCore::MarkupTokenizerBase::reset): (MarkupTokenizerBase): * xml/parser/MarkupTokenizerInlineMethods.h: (WebCore): * xml/parser/XMLTokenizer.cpp: (WebCore::XMLTokenizer::nextToken): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp trunk/Source/WebCore/html/track/WebVTTTokenizer.cpp trunk/Source/WebCore/platform/text/SegmentedString.cpp trunk/Source/WebCore/platform/text/SegmentedString.h trunk/Source/WebCore/xml/parser/MarkupTokenizerBase.h trunk/Source/WebCore/xml/parser/MarkupTokenizerInlineMethods.h trunk/Source/WebCore/xml/parser/XMLTokenizer.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (121857 => 121858) --- trunk/Source/WebCore/ChangeLog 2012-07-04 15:25:35 UTC (rev 121857) +++ trunk/Source/WebCore/ChangeLog 2012-07-04 15:31:53 UTC (rev 121858) @@ -1,3 +1,46 @@ +2012-07-04 Kwang Yul Seo + +Stop tracking line number in tokenizer +https://bugs.webkit.org/show_bug.cgi?id=90544 + +Reviewed by Adam Barth. + +Because SegmentedString knows how to track the current line and column, +a tokenizer does not need to keep track of the current line by itself. +No behavior change, so no new tests. + +* html/parser/HTMLDocumentParser.cpp: +(WebCore::HTMLDocumentParser::pumpTokenizer): +(WebCore::HTMLDocumentParser::lineNumber): +(WebCore::HTMLDocumentParser::textPosition): +* html/parser/HTMLTokenizer.cpp: +(WebCore::HTMLTokenizer::reset): +(WebCore::HTMLTokenizer::flushBufferedEndTag): +(WebCore): +(WebCore::HTMLTokenizer::nextToken): +* html/parser/HTMLTreeBuilder.cpp: +(WebCore::HTMLTreeBuilder::processScriptStartTag): +* html/track/WebVTTTokenizer.cpp: +(WebCore::WebVTTTokenizer::reset): +(WebCore::WebVTTTokenizer::nextToken): +* platform/text/SegmentedString.cpp: +(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase): +* platform/text/SegmentedString.h: +(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber): +(WebCore::SegmentedString::advanceAndUpdateLineNumber): +(SegmentedString): +* xml/parser/MarkupTokenizerBase.h: +(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek): +(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance): +(WebCore::MarkupTokenizerBase::emitAndResumeIn): +(WebCore::MarkupTokenizerBase::emitEndOfFile): +(WebCore::MarkupTokenizerBase::reset): +(MarkupTokenizerBase): +* xml/parser/MarkupTokenizerInlineMethods.h: +(WebCore): +* xml/parser/XMLTokenizer.cpp: +(WebCore::XMLTokenizer::nextToken): + 2012-07-04 Ryuan Choi [CMAKE] Add GENERATE_BINDINGS macro to share the codes which use generate-bindings.pl. Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (121857 => 121858) --- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2012-07-04 15:25:35 UTC (rev 121857) +++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2012-07-04 15:31:53 UTC (rev 121858) @@ -258,7 +258,7 @@ // FIXME: m_input.current().length() is only accurate if we // end up parsing the whole buffer in this pump. We should pass how // much we parsed as part of didWriteHTML instead of willWri
[webkit-changes] [121856] trunk/Tools
Title: [121856] trunk/Tools
Revision 121856
Author ves...@webkit.org
Date 2012-07-04 08:19:33 -0700 (Wed, 04 Jul 2012)
Log Message
[Qt] Replace deprecated IN_PWD with PWD
Reviewed by Csaba Osztrogonác.
* qmake/mkspecs/features/default_pre.prf:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_pre.prf
Diff
Modified: trunk/Tools/ChangeLog (121855 => 121856)
--- trunk/Tools/ChangeLog 2012-07-04 15:14:01 UTC (rev 121855)
+++ trunk/Tools/ChangeLog 2012-07-04 15:19:33 UTC (rev 121856)
@@ -1,5 +1,13 @@
2012-07-04 Tor Arne Vestbø
+[Qt] Replace deprecated IN_PWD with PWD
+
+Reviewed by Csaba Osztrogonác.
+
+* qmake/mkspecs/features/default_pre.prf:
+
+2012-07-04 Tor Arne Vestbø
+
[Qt] Don't try to build WTR twice
Reviewed by Csaba Osztrogonác.
Modified: trunk/Tools/qmake/mkspecs/features/default_pre.prf (121855 => 121856)
--- trunk/Tools/qmake/mkspecs/features/default_pre.prf 2012-07-04 15:14:01 UTC (rev 121855)
+++ trunk/Tools/qmake/mkspecs/features/default_pre.prf 2012-07-04 15:19:33 UTC (rev 121856)
@@ -23,7 +23,7 @@
}
# Resolve root directories for source and build
-ROOT_WEBKIT_DIR = $$replace(IN_PWD, /Tools/qmake/mkspecs/features$,)
+ROOT_WEBKIT_DIR = $$replace(PWD, /Tools/qmake/mkspecs/features$,)
WEBKIT_SUBDIR = $$replace(_PRO_FILE_PWD_, $${ROOT_WEBKIT_DIR},)
ROOT_BUILD_DIR = $$replace(OUT_PWD, $${WEBKIT_SUBDIR}$,)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121855] trunk/Source/WebCore
Title: [121855] trunk/Source/WebCore
Revision 121855
Author vse...@chromium.org
Date 2012-07-04 08:14:01 -0700 (Wed, 04 Jul 2012)
Log Message
Web Inspector: UISourceCode should take care of adding revision after committing working copy.
https://bugs.webkit.org/show_bug.cgi?id=90549
Reviewed by Pavel Feldman.
Revision is now added in UISourceCode.commitWorkingCopy synchronously even if saving to JS VM or CSS model failed.
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding.prototype.setStyleContent):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
* inspector/front-end/_javascript_Source.js:
(WebInspector._javascript_Source.prototype.workingCopyCommitted):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype._callOrSetTimeout):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
* inspector/front-end/Workspace.js:
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodeForURL):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js
trunk/Source/WebCore/inspector/front-end/ExtensionServer.js
trunk/Source/WebCore/inspector/front-end/_javascript_Source.js
trunk/Source/WebCore/inspector/front-end/StylesPanel.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
trunk/Source/WebCore/inspector/front-end/Workspace.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (121854 => 121855)
--- trunk/Source/WebCore/ChangeLog 2012-07-04 15:13:24 UTC (rev 121854)
+++ trunk/Source/WebCore/ChangeLog 2012-07-04 15:14:01 UTC (rev 121855)
@@ -1,3 +1,27 @@
+2012-07-04 Vsevolod Vlasov
+
+Web Inspector: UISourceCode should take care of adding revision after committing working copy.
+https://bugs.webkit.org/show_bug.cgi?id=90549
+
+Reviewed by Pavel Feldman.
+
+Revision is now added in UISourceCode.commitWorkingCopy synchronously even if saving to JS VM or CSS model failed.
+
+* inspector/front-end/CSSStyleModel.js:
+(WebInspector.CSSStyleModelResourceBinding.prototype.setStyleContent):
+* inspector/front-end/ExtensionServer.js:
+(WebInspector.ExtensionServer.prototype._handleOpenURL):
+(WebInspector.ExtensionServer.prototype._onGetResourceContent):
+(WebInspector.ExtensionServer.prototype._onSetResourceContent):
+* inspector/front-end/_javascript_Source.js:
+(WebInspector._javascript_Source.prototype.workingCopyCommitted):
+* inspector/front-end/StylesPanel.js:
+(WebInspector.StyleSource.prototype._callOrSetTimeout):
+* inspector/front-end/UISourceCode.js:
+(WebInspector.UISourceCode.prototype.commitWorkingCopy):
+* inspector/front-end/Workspace.js:
+(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodeForURL):
+
2012-07-04 Pavel Feldman
Web Inspector: move settings button back to the right.
Modified: trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js (121854 => 121855)
--- trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js 2012-07-04 15:13:24 UTC (rev 121854)
+++ trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js 2012-07-04 15:14:01 UTC (rev 121855)
@@ -955,23 +955,10 @@
{
var resource = styleSource.resource();
if (this._styleSheetIdForResource(resource)) {
-this._innerSetContent(resource, content, majorChange, innerCallback, null);
+this._innerSetContent(resource, content, majorChange, userCallback, null);
return;
}
-this._loadStyleSheetHeaders(this._innerSetContent.bind(this, resource, content, majorChange, innerCallback));
-
-function innerCallback(error)
-{
-if (error) {
-userCallback(error);
-return;
-}
-
-if (majorChange)
-resource.addRevision(content);
-
-userCallback(null);
-}
+this._loadStyleSheetHeaders(this._innerSetContent.bind(this, resource, content, majorChange, userCallback));
},
/**
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionServer.js (121854 => 121855)
--- trunk/Source/WebCore/inspector/front-end/ExtensionServer.js 2012-07-04 15:13:24 UTC (rev 121854)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionServer.js 2012-07-04 15:14:01 UTC (rev 121855)
@@ -290,7 +290,7 @@
_handleOpenURL: function(port, details)
{
-var url = "" @type {String} */ details.url;
+var url = "" @type {string} */ details.url;
var contentProvider = WebInspector.workspace.uiSourceCodeForURL(url) || WebInspector.resourceForURL(url);
if (!contentProvider)
return false;
@@ -482,7 +482,7 @@
_o
[webkit-changes] [121854] trunk/Tools
Title: [121854] trunk/Tools
Revision 121854
Author ves...@webkit.org
Date 2012-07-04 08:13:24 -0700 (Wed, 04 Jul 2012)
Log Message
[Qt] Don't try to build WTR twice
Reviewed by Csaba Osztrogonác.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Tools.pro
Diff
Modified: trunk/Tools/ChangeLog (121853 => 121854)
--- trunk/Tools/ChangeLog 2012-07-04 15:06:41 UTC (rev 121853)
+++ trunk/Tools/ChangeLog 2012-07-04 15:13:24 UTC (rev 121854)
@@ -1,3 +1,11 @@
+2012-07-04 Tor Arne Vestbø
+
+[Qt] Don't try to build WTR twice
+
+Reviewed by Csaba Osztrogonác.
+
+* Tools.pro:
+
2012-07-04 Sheriff Bot
Unreviewed, rolling out r121821.
Modified: trunk/Tools/Tools.pro (121853 => 121854)
--- trunk/Tools/Tools.pro 2012-07-04 15:06:41 UTC (rev 121853)
+++ trunk/Tools/Tools.pro 2012-07-04 15:13:24 UTC (rev 121854)
@@ -14,12 +14,11 @@
}
!no_webkit2 {
-SUBDIRS += MiniBrowser/qt/MiniBrowser.pro
-SUBDIRS += WebKitTestRunner/WebKitTestRunner.pro
-SUBDIRS += MiniBrowser/qt/raw/MiniBrowserRaw.pro
-
# WTR's InjectedBundle depends currently on WK1's DumpRenderTreeSupport
!no_webkit1: SUBDIRS += WebKitTestRunner/WebKitTestRunner.pro
+
+SUBDIRS += MiniBrowser/qt/MiniBrowser.pro
+SUBDIRS += MiniBrowser/qt/raw/MiniBrowserRaw.pro
}
# FIXME: with Qt 5 the test plugin cause some trouble during layout tests.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121853] trunk/Source/WebCore
Title: [121853] trunk/Source/WebCore
Revision 121853
Author pfeld...@chromium.org
Date 2012-07-04 08:06:41 -0700 (Wed, 04 Jul 2012)
Log Message
Web Inspector: move settings button back to the right.
https://bugs.webkit.org/show_bug.cgi?id=90552
Reviewed by Vsevolod Vlasov.
* inspector/front-end/inspector.css:
(button.status-bar-item:active, button.status-bar-item.emulate-active):
(button.settings-status-bar-item):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (121852 => 121853)
--- trunk/Source/WebCore/ChangeLog 2012-07-04 14:59:39 UTC (rev 121852)
+++ trunk/Source/WebCore/ChangeLog 2012-07-04 15:06:41 UTC (rev 121853)
@@ -1,3 +1,14 @@
+2012-07-04 Pavel Feldman
+
+Web Inspector: move settings button back to the right.
+https://bugs.webkit.org/show_bug.cgi?id=90552
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/inspector.css:
+(button.status-bar-item:active, button.status-bar-item.emulate-active):
+(button.settings-status-bar-item):
+
2012-07-04 Vsevolod Vlasov
Web Inspector: Get rid of ResourceDomainModelBinding and DebuggerResourceBinding, make Resource.setContent private.
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (121852 => 121853)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-07-04 14:59:39 UTC (rev 121852)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-07-04 15:06:41 UTC (rev 121853)
@@ -538,7 +538,7 @@
background-position: 0 0;
}
-button.status-bar-item:active:not(.emulate-inactive), button.status-bar-item.emulate-active {
+button.status-bar-item:active, button.status-bar-item.emulate-active {
background-position: 32px 0 !important;
}
@@ -595,9 +595,14 @@
background-color: rgba(0, 0, 0, 0.75);
}
+button.settings-status-bar-item {
+position: absolute;
+right: 0;
+}
+
.alternate-status-bar-buttons-bar {
position: absolute;
-width: 32px;
+width: 31px;
bottom: -3px;
margin-left: 1px;
background: white;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121852] trunk/Tools
Title: [121852] trunk/Tools
Revision 121852
Author commit-qu...@webkit.org
Date 2012-07-04 07:59:39 -0700 (Wed, 04 Jul 2012)
Log Message
Unreviewed, rolling out r121821.
http://trac.webkit.org/changeset/121821
https://bugs.webkit.org/show_bug.cgi?id=90551
This patch did not receive a high-quality review and has a
number of errors (Requested by abarth on #webkit).
Patch by Sheriff Bot on 2012-07-04
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Build.results_url):
* Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
(ChromiumBuilder.accumulated_results_url):
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand.__init__):
(Rebaseline):
(Rebaseline._builder_to_pull_from):
(Rebaseline._tests_to_update):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline.mock_builder_to_pull_from):
(test_rebaseline):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
trunk/Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (121851 => 121852)
--- trunk/Tools/ChangeLog 2012-07-04 14:21:59 UTC (rev 121851)
+++ trunk/Tools/ChangeLog 2012-07-04 14:59:39 UTC (rev 121852)
@@ -1,3 +1,27 @@
+2012-07-04 Sheriff Bot
+
+Unreviewed, rolling out r121821.
+http://trac.webkit.org/changeset/121821
+https://bugs.webkit.org/show_bug.cgi?id=90551
+
+This patch did not receive a high-quality review and has a
+number of errors (Requested by abarth on #webkit).
+
+* Scripts/webkitpy/common/net/buildbot/buildbot.py:
+(Build.results_url):
+* Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
+(ChromiumBuilder.accumulated_results_url):
+* Scripts/webkitpy/layout_tests/port/builders.py:
+* Scripts/webkitpy/tool/commands/rebaseline.py:
+(AbstractParallelRebaselineCommand.__init__):
+(Rebaseline):
+(Rebaseline._builder_to_pull_from):
+(Rebaseline._tests_to_update):
+(Rebaseline.execute):
+* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
+(test_rebaseline.mock_builder_to_pull_from):
+(test_rebaseline):
+
2012-07-04 Tor Arne Vestbø
[Qt] Get rid of un-needed QT += declarative for Qt 5
Modified: trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py (121851 => 121852)
--- trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py 2012-07-04 14:21:59 UTC (rev 121851)
+++ trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py 2012-07-04 14:59:39 UTC (rev 121852)
@@ -239,8 +239,7 @@
return self.build_url(self.builder(), self._number)
def results_url(self):
-# FIXME: We should probably have a better way of determining chromium builders than checking if the name starts with 'Webkit'.
-results_directory = "results/layout-test-results" if self._builder.name().startswith('Webkit') else "r%s (%s)" % (self.revision(), self._number)
+results_directory = "r%s (%s)" % (self.revision(), self._number)
return "%s/%s" % (self._builder.results_url(), urllib.quote(results_directory))
def results_zip_url(self):
Modified: trunk/Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py (121851 => 121852)
--- trunk/Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py 2012-07-04 14:21:59 UTC (rev 121851)
+++ trunk/Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py 2012-07-04 14:59:39 UTC (rev 121852)
@@ -41,17 +41,7 @@
def accumulated_results_url(self):
return self.results_url() + "/results/layout-test-results"
-# We override Builder.latest_cached_build because it relies on functions that assume too much about
-# the information provided on the buildbot pages.
-# FIXME: Have Builder and ChromiumBuilder actually provide a unified inteface that they both support.
-def latest_cached_build(self):
-for builder_status in self._buildbot.builder_statuses():
-if builder_status["name"] == self.name():
-build_number = builder_status["build_number"]
-break
-return self.build(build_number)
-
class ChromiumBuildBot(BuildBot):
_builder_factory = ChromiumBuilder
_default_url = config_urls.chromium_buildbot_url
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py (121851 => 121852)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py 2012-07-04 14:21:59 UTC (rev 121851)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py 2012-07-04 14:59:39 UTC (rev 121852)
@@ -96,10 +96,12 @@
return re.sub(r'[\s().]', '_', builder_name)
+@memoized
def
[webkit-changes] [121851] trunk
Title: [121851] trunk
Revision 121851
Author ves...@webkit.org
Date 2012-07-04 07:21:59 -0700 (Wed, 04 Jul 2012)
Log Message
[Qt] Get rid of un-needed QT += declarative for Qt 5
The declarative module has been renamed to quick1 in Qt 5, and the
engine-only module for Qt 5 is named 'qml'. For many of the instances
we could just remove 'declarative', since the project file was only
used for Qt5/WebKit2 builds. In the other cases the module was wrapped
in a haveQt(4) scope.
Reviewed by Csaba Osztrogonác.
Modified Paths
trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.pri
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/declarative/experimental/experimental.pri
trunk/Source/WebKit/qt/declarative/public.pri
trunk/Source/api.pri
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/MiniBrowser.pro
trunk/Tools/WebKitTestRunner/InjectedBundle/Target.pri
trunk/Tools/WebKitTestRunner/Target.pri
Diff
Modified: trunk/ChangeLog (121850 => 121851)
--- trunk/ChangeLog 2012-07-04 14:07:43 UTC (rev 121850)
+++ trunk/ChangeLog 2012-07-04 14:21:59 UTC (rev 121851)
@@ -1,3 +1,17 @@
+2012-07-04 Tor Arne Vestbø
+
+[Qt] Get rid of un-needed QT += declarative for Qt 5
+
+The declarative module has been renamed to quick1 in Qt 5, and the
+engine-only module for Qt 5 is named 'qml'. For many of the instances
+we could just remove 'declarative', since the project file was only
+used for Qt5/WebKit2 builds. In the other cases the module was wrapped
+in a haveQt(4) scope.
+
+Reviewed by Csaba Osztrogonác.
+
+* Source/api.pri:
+
2012-07-03 Christophe Dumez
[EFL] Enable CSS variables support at compile time
Modified: trunk/Source/WTF/ChangeLog (121850 => 121851)
--- trunk/Source/WTF/ChangeLog 2012-07-04 14:07:43 UTC (rev 121850)
+++ trunk/Source/WTF/ChangeLog 2012-07-04 14:21:59 UTC (rev 121851)
@@ -1,3 +1,17 @@
+2012-07-04 Tor Arne Vestbø
+
+[Qt] Get rid of un-needed QT += declarative for Qt 5
+
+The declarative module has been renamed to quick1 in Qt 5, and the
+engine-only module for Qt 5 is named 'qml'. For many of the instances
+we could just remove 'declarative', since the project file was only
+used for Qt5/WebKit2 builds. In the other cases the module was wrapped
+in a haveQt(4) scope.
+
+Reviewed by Csaba Osztrogonác.
+
+* WTF.pri:
+
2012-07-03 Yong Li
[BlackBerry] Turn on DFGJIT in Platform.h
Modified: trunk/Source/WTF/WTF.pri (121850 => 121851)
--- trunk/Source/WTF/WTF.pri 2012-07-04 14:07:43 UTC (rev 121850)
+++ trunk/Source/WTF/WTF.pri 2012-07-04 14:21:59 UTC (rev 121851)
@@ -28,7 +28,7 @@
!haveQt(5): error("To build QtWebKit+V8 you need to use Qt 5")
DEFINES *= WTF_USE_V8=1
INCLUDEPATH += $${ROOT_WEBKIT_DIR}/Source/WebKit/qt/v8/ForwardingHeaders
-QT += v8-private declarative
+QT += v8-private
}
linux-*:contains(DEFINES, WTF_USE_GSTREAMER=1) {
Modified: trunk/Source/WebKit/qt/ChangeLog (121850 => 121851)
--- trunk/Source/WebKit/qt/ChangeLog 2012-07-04 14:07:43 UTC (rev 121850)
+++ trunk/Source/WebKit/qt/ChangeLog 2012-07-04 14:21:59 UTC (rev 121851)
@@ -1,3 +1,18 @@
+2012-07-04 Tor Arne Vestbø
+
+[Qt] Get rid of un-needed QT += declarative for Qt 5
+
+The declarative module has been renamed to quick1 in Qt 5, and the
+engine-only module for Qt 5 is named 'qml'. For many of the instances
+we could just remove 'declarative', since the project file was only
+used for Qt5/WebKit2 builds. In the other cases the module was wrapped
+in a haveQt(4) scope.
+
+Reviewed by Csaba Osztrogonác.
+
+* declarative/experimental/experimental.pri:
+* declarative/public.pri:
+
2012-07-03 Tor Arne Vestbø
[Qt] Make use of .qmake.cache for caching features
Modified: trunk/Source/WebKit/qt/declarative/experimental/experimental.pri (121850 => 121851)
--- trunk/Source/WebKit/qt/declarative/experimental/experimental.pri 2012-07-04 14:07:43 UTC (rev 121850)
+++ trunk/Source/WebKit/qt/declarative/experimental/experimental.pri 2012-07-04 14:21:59 UTC (rev 121851)
@@ -24,7 +24,7 @@
wince*:LIBS += $$QMAKE_LIBS_GUI
-QT += declarative widgets network quick quick-private webkit webkit-private
+QT += widgets network quick quick-private webkit webkit-private
DESTDIR = $${ROOT_BUILD_DIR}/imports/$${TARGET.module_name}
Modified: trunk/Source/WebKit/qt/declarative/public.pri (121850 => 121851)
--- trunk/Source/WebKit/qt/declarative/public.pri 2012-07-04 14:07:43 UTC (rev 121850)
+++ trunk/Source/WebKit/qt/declarative/public.pri 2012-07-04 14:21:59 UTC (rev 121851)
@@ -24,7 +24,8 @@
wince*:LIBS += $$QMAKE_LIBS_GUI
-QT += declarative webkit webkit-private
+QT += webkit webkit-private
+haveQt(4): QT += declarative
haveQt(5): QT += widgets quick quick-private
contains(DEFINES, HAVE_QQUICK1=1) {
Modified: trunk/Source/api
[webkit-changes] [121850] trunk/Source/WebCore
Title: [121850] trunk/Source/WebCore Revision 121850 Author vse...@chromium.org Date 2012-07-04 07:07:43 -0700 (Wed, 04 Jul 2012) Log Message Web Inspector: Get rid of ResourceDomainModelBinding and DebuggerResourceBinding, make Resource.setContent private. https://bugs.webkit.org/show_bug.cgi?id=90531 Reviewed by Pavel Feldman. Resource.setContent made private. It is delegating now to UISourceCodes which take care of domain specific actions. DebuggerResourceBinding was be removed and DebuggerResourceBinding.setScriptSource was moved to _javascript_Source. ResourceDomainModelBinding was removed as well. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/compile-front-end.py: * inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModelResourceBinding): * inspector/front-end/DebuggerResourceBinding.js: Removed. * inspector/front-end/_javascript_Source.js: (WebInspector._javascript_Source.prototype.workingCopyCommitted): (WebInspector._javascript_Source.prototype._setScriptSource.didEditScriptSource): (WebInspector._javascript_Source.prototype._setScriptSource): * inspector/front-end/Resource.js: (WebInspector.Resource.prototype._setContent): (WebInspector.Resource.prototype.revertToOriginal): (WebInspector.Resource.prototype.revertAndClearHistory): (WebInspector.ResourceRevision.prototype.revertToThis): * inspector/front-end/StylesPanel.js: (WebInspector.StyleSource.prototype.isEditable): * inspector/front-end/UISourceCode.js: * inspector/front-end/WebKit.qrc: * inspector/front-end/Workspace.js: (WebInspector.Workspace): * inspector/front-end/inspector.html: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/compile-front-end.py trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js trunk/Source/WebCore/inspector/front-end/_javascript_Source.js trunk/Source/WebCore/inspector/front-end/Resource.js trunk/Source/WebCore/inspector/front-end/StylesPanel.js trunk/Source/WebCore/inspector/front-end/UISourceCode.js trunk/Source/WebCore/inspector/front-end/WebKit.qrc trunk/Source/WebCore/inspector/front-end/Workspace.js trunk/Source/WebCore/inspector/front-end/inspector.html Removed Paths trunk/Source/WebCore/inspector/front-end/DebuggerResourceBinding.js Diff Modified: trunk/Source/WebCore/ChangeLog (121849 => 121850) --- trunk/Source/WebCore/ChangeLog 2012-07-04 13:55:10 UTC (rev 121849) +++ trunk/Source/WebCore/ChangeLog 2012-07-04 14:07:43 UTC (rev 121850) @@ -1,3 +1,37 @@ +2012-07-04 Vsevolod Vlasov + +Web Inspector: Get rid of ResourceDomainModelBinding and DebuggerResourceBinding, make Resource.setContent private. +https://bugs.webkit.org/show_bug.cgi?id=90531 + +Reviewed by Pavel Feldman. + +Resource.setContent made private. It is delegating now to UISourceCodes which take care of domain specific actions. +DebuggerResourceBinding was be removed and DebuggerResourceBinding.setScriptSource was moved to _javascript_Source. +ResourceDomainModelBinding was removed as well. + +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* inspector/compile-front-end.py: +* inspector/front-end/CSSStyleModel.js: +(WebInspector.CSSStyleModelResourceBinding): +* inspector/front-end/DebuggerResourceBinding.js: Removed. +* inspector/front-end/_javascript_Source.js: +(WebInspector._javascript_Source.prototype.workingCopyCommitted): +(WebInspector._javascript_Source.prototype._setScriptSource.didEditScriptSource): +(WebInspector._javascript_Source.prototype._setScriptSource): +* inspector/front-end/Resource.js: +(WebInspector.Resource.prototype._setContent): +(WebInspector.Resource.prototype.revertToOriginal): +(WebInspector.Resource.prototype.revertAndClearHistory): +(WebInspector.ResourceRevision.prototype.revertToThis): +* inspector/front-end/StylesPanel.js: +(WebInspector.StyleSource.prototype.isEditable): +* inspector/front-end/UISourceCode.js: +* inspector/front-end/WebKit.qrc: +* inspector/front-end/Workspace.js: +(WebInspector.Workspace): +* inspector/front-end/inspector.html: + 2012-07-04 'Pavel Feldman' Not reviewed: follow up to r121843, reduce inspector dock timeout to 200ms. Modified: trunk/Source/WebCore/WebCore.gypi (121849 => 121850) --- trunk/Source/WebCore/WebCore.gypi 2012-07-04 13:55:10 UTC (rev 121849) +++ trunk/Source/WebCore/WebCore.gypi 2012-07-04 14:07:43 UTC (rev 121850) @@ -6256,7 +6256,6 @@ 'inspector/front-end/DatabaseTableView.js', 'inspector/front-end/DataGrid.js', 'inspector/front-end/DebuggerModel.js', -'inspector/front-end/DebuggerResourceBinding.js', 'inspector/front-end/DebuggerScriptMapping.js', 'inspector/front-end/Dialog.js',
[webkit-changes] [121849] trunk/Source/WebCore
Title: [121849] trunk/Source/WebCore
Revision 121849
Author pfeld...@chromium.org
Date 2012-07-04 06:55:10 -0700 (Wed, 04 Jul 2012)
Log Message
Not reviewed: follow up to r121843, reduce inspector dock timeout to 200ms.
* inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseDown):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/StatusBarButton.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (121848 => 121849)
--- trunk/Source/WebCore/ChangeLog 2012-07-04 13:54:43 UTC (rev 121848)
+++ trunk/Source/WebCore/ChangeLog 2012-07-04 13:55:10 UTC (rev 121849)
@@ -1,3 +1,10 @@
+2012-07-04 'Pavel Feldman'
+
+Not reviewed: follow up to r121843, reduce inspector dock timeout to 200ms.
+
+* inspector/front-end/StatusBarButton.js:
+(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseDown):
+
2012-07-04 Ian Vollick
[chromium] Correctly reject accelerated animations with certain rotations.
Modified: trunk/Source/WebCore/inspector/front-end/StatusBarButton.js (121848 => 121849)
--- trunk/Source/WebCore/inspector/front-end/StatusBarButton.js 2012-07-04 13:54:43 UTC (rev 121848)
+++ trunk/Source/WebCore/inspector/front-end/StatusBarButton.js 2012-07-04 13:55:10 UTC (rev 121849)
@@ -172,7 +172,7 @@
{
if (e.which !== 1)
return;
-this._showOptionsTimer = setTimeout(this._showOptions.bind(this, buttonsProvider), 500);
+this._showOptionsTimer = setTimeout(this._showOptions.bind(this, buttonsProvider), 200);
}
function mouseUp(e)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121848] trunk
Title: [121848] trunk Revision 121848 Author ves...@webkit.org Date 2012-07-04 06:54:43 -0700 (Wed, 04 Jul 2012) Log Message [Qt] Remove a few un-needed load(features) after r121777 The features are computed by configure.pro and cached in .qmake.cache. Reviewed by Jocelyn Turcotte. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebKit1.pro trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/qt/raw/Target.pri Diff Modified: trunk/Source/WebKit/ChangeLog (121847 => 121848) --- trunk/Source/WebKit/ChangeLog 2012-07-04 13:48:44 UTC (rev 121847) +++ trunk/Source/WebKit/ChangeLog 2012-07-04 13:54:43 UTC (rev 121848) @@ -1,5 +1,15 @@ 2012-07-04 Tor Arne Vestbø +[Qt] Remove a few un-needed load(features) after r121777 + +The features are computed by configure.pro and cached in .qmake.cache. + +Reviewed by Jocelyn Turcotte. + +* WebKit1.pro: + +2012-07-04 Tor Arne Vestbø + [Qt] Fix broken OR-operator in project file Qmake expects |, not ||. The result was that the block was entered, even Modified: trunk/Source/WebKit/WebKit1.pro (121847 => 121848) --- trunk/Source/WebKit/WebKit1.pro 2012-07-04 13:48:44 UTC (rev 121847) +++ trunk/Source/WebKit/WebKit1.pro 2012-07-04 13:54:43 UTC (rev 121848) @@ -7,8 +7,6 @@ TEMPLATE = lib TARGET = WebKit1 -load(features) - include(WebKit1.pri) WEBKIT += wtf _javascript_core webcore Modified: trunk/Tools/ChangeLog (121847 => 121848) --- trunk/Tools/ChangeLog 2012-07-04 13:48:44 UTC (rev 121847) +++ trunk/Tools/ChangeLog 2012-07-04 13:54:43 UTC (rev 121848) @@ -1,5 +1,15 @@ 2012-07-04 Tor Arne Vestbø +[Qt] Remove a few un-needed load(features) after r121777 + +The features are computed by configure.pro and cached in .qmake.cache. + +Reviewed by Jocelyn Turcotte.. + +* MiniBrowser/qt/raw/Target.pri: + +2012-07-04 Tor Arne Vestbø + [Qt] Use haveQtModule() in project files instead of manual checks Reviewed by Jocelyn Turcotte. Modified: trunk/Tools/MiniBrowser/qt/raw/Target.pri (121847 => 121848) --- trunk/Tools/MiniBrowser/qt/raw/Target.pri 2012-07-04 13:48:44 UTC (rev 121847) +++ trunk/Tools/MiniBrowser/qt/raw/Target.pri 2012-07-04 13:54:43 UTC (rev 121848) @@ -11,6 +11,4 @@ QT = core gui network webkit -load(features) - WEBKIT += wtf _javascript_core webkit2 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121847] trunk/Tools
Title: [121847] trunk/Tools
Revision 121847
Author ves...@webkit.org
Date 2012-07-04 06:48:44 -0700 (Wed, 04 Jul 2012)
Log Message
[Qt] Use haveQtModule() in project files instead of manual checks
Reviewed by Jocelyn Turcotte.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_pre.prf
trunk/Tools/qmake/mkspecs/features/features.prf
Diff
Modified: trunk/Tools/ChangeLog (121846 => 121847)
--- trunk/Tools/ChangeLog 2012-07-04 13:44:15 UTC (rev 121846)
+++ trunk/Tools/ChangeLog 2012-07-04 13:48:44 UTC (rev 121847)
@@ -1,5 +1,14 @@
2012-07-04 Tor Arne Vestbø
+[Qt] Use haveQtModule() in project files instead of manual checks
+
+Reviewed by Jocelyn Turcotte.
+
+* qmake/mkspecs/features/default_pre.prf:
+* qmake/mkspecs/features/features.prf:
+
+2012-07-04 Tor Arne Vestbø
+
[Qt] Fix haveQtModule() check
Without {} brackets we were pulling out the value of the module.name variable.
Modified: trunk/Tools/qmake/mkspecs/features/default_pre.prf (121846 => 121847)
--- trunk/Tools/qmake/mkspecs/features/default_pre.prf 2012-07-04 13:44:15 UTC (rev 121846)
+++ trunk/Tools/qmake/mkspecs/features/default_pre.prf 2012-07-04 13:48:44 UTC (rev 121847)
@@ -107,7 +107,7 @@
}
haveQt(5): {
-isEmpty(QT.widgets.name)|isEmpty(QT.printsupport.name) {
+!haveQtModule(widgets)|!haveQtModule(printsupport) {
root_project_file: message("WebKit1 requires the QtWidgets and QtPrintSupport modules. Disabling WebKit1.")
CONFIG += no_webkit1
}
Modified: trunk/Tools/qmake/mkspecs/features/features.prf (121846 => 121847)
--- trunk/Tools/qmake/mkspecs/features/features.prf 2012-07-04 13:44:15 UTC (rev 121846)
+++ trunk/Tools/qmake/mkspecs/features/features.prf 2012-07-04 13:48:44 UTC (rev 121847)
@@ -105,7 +105,7 @@
}
# QStyle detection
-haveQt(4)|!isEmpty(QT.widgets.name): DEFINES += HAVE_QSTYLE=1
+haveQt(4)|haveQtModule(widgets): DEFINES += HAVE_QSTYLE=1
# WebGL support
!contains(DEFINES, ENABLE_WEBGL=.) {
@@ -129,7 +129,7 @@
# orientation support
haveQt(5) {
-!isEmpty(QT.sensors.name) {
+haveQtModule(sensors) {
!contains(DEFINES, ENABLE_ORIENTATION_EVENTS=.): DEFINES += ENABLE_ORIENTATION_EVENTS=1
!contains(DEFINES, ENABLE_DEVICE_ORIENTATION=.): DEFINES += ENABLE_DEVICE_ORIENTATION=1
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121846] trunk/Tools
Title: [121846] trunk/Tools
Revision 121846
Author ves...@webkit.org
Date 2012-07-04 06:44:15 -0700 (Wed, 04 Jul 2012)
Log Message
[Qt] Fix haveQtModule() check
Without {} brackets we were pulling out the value of the module.name variable.
Reviewed by Jocelyn Turcotte.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/functions.prf
Diff
Modified: trunk/Tools/ChangeLog (121845 => 121846)
--- trunk/Tools/ChangeLog 2012-07-04 13:41:19 UTC (rev 121845)
+++ trunk/Tools/ChangeLog 2012-07-04 13:44:15 UTC (rev 121846)
@@ -1,3 +1,13 @@
+2012-07-04 Tor Arne Vestbø
+
+[Qt] Fix haveQtModule() check
+
+Without {} brackets we were pulling out the value of the module.name variable.
+
+Reviewed by Jocelyn Turcotte.
+
+* qmake/mkspecs/features/functions.prf:
+
2012-07-04 Sergio Villar Senin
[WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
Modified: trunk/Tools/qmake/mkspecs/features/functions.prf (121845 => 121846)
--- trunk/Tools/qmake/mkspecs/features/functions.prf 2012-07-04 13:41:19 UTC (rev 121845)
+++ trunk/Tools/qmake/mkspecs/features/functions.prf 2012-07-04 13:44:15 UTC (rev 121846)
@@ -207,8 +207,9 @@
defineTest(haveQtModule) {
unset(module)
module = $$1
-haveQt(4):contains(QT_CONFIG, $$module): return(true)
-haveQt(5):!isEmpty(QT.$$module.name): return(true)
+
+haveQt(4):contains(QT_CONFIG, $${module}): return(true)
+haveQt(5):!isEmpty(QT.$${module}.name): return(true)
return(false)
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121845] trunk/Source/WebKit
Title: [121845] trunk/Source/WebKit
Revision 121845
Author ves...@webkit.org
Date 2012-07-04 06:41:19 -0700 (Wed, 04 Jul 2012)
Log Message
[Qt] Fix broken OR-operator in project file
Qmake expects |, not ||. The result was that the block was entered, even
if none of the two defines were set to 1.
Reviewed by Jocelyn Turcotte.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit1.pri
Diff
Modified: trunk/Source/WebKit/ChangeLog (121844 => 121845)
--- trunk/Source/WebKit/ChangeLog 2012-07-04 12:57:58 UTC (rev 121844)
+++ trunk/Source/WebKit/ChangeLog 2012-07-04 13:41:19 UTC (rev 121845)
@@ -1,3 +1,14 @@
+2012-07-04 Tor Arne Vestbø
+
+[Qt] Fix broken OR-operator in project file
+
+Qmake expects |, not ||. The result was that the block was entered, even
+if none of the two defines were set to 1.
+
+Reviewed by Jocelyn Turcotte.
+
+* WebKit1.pri:
+
2012-07-03 Christophe Dumez
[EFL] Move BatteryClientEfl from WebKit to WebCore
Modified: trunk/Source/WebKit/WebKit1.pri (121844 => 121845)
--- trunk/Source/WebKit/WebKit1.pri 2012-07-04 12:57:58 UTC (rev 121844)
+++ trunk/Source/WebKit/WebKit1.pri 2012-07-04 13:41:19 UTC (rev 121845)
@@ -27,7 +27,7 @@
}
}
-contains(DEFINES, ENABLE_DEVICE_ORIENTATION=1) || contains(DEFINES, ENABLE_ORIENTATION_EVENTS=1) {
+contains(DEFINES, ENABLE_DEVICE_ORIENTATION=1)|contains(DEFINES, ENABLE_ORIENTATION_EVENTS=1) {
haveQt(5) {
QT += sensors
} else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121844] trunk/Source
Title: [121844] trunk/Source
Revision 121844
Author voll...@chromium.org
Date 2012-07-04 05:57:58 -0700 (Wed, 04 Jul 2012)
Log Message
[chromium] Correctly reject accelerated animations with certain rotations.
https://bugs.webkit.org/show_bug.cgi?id=89768
Reviewed by James Robinson.
Source/WebCore:
UnitTests:
GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
GraphicsLayerChromiumTest.createTransformAnimationWithRotationInvolvingNegativeAngles
GraphicsLayerChromiumTest.createTransformAnimationWithSmallRotationInvolvingLargeAngles
* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::appendKeyframe):
(WebCore::isRotationType):
(WebCore):
(WebCore::causesRotationOfAtLeast180Degrees):
(WebCore::CCKeyframedTransformAnimationCurve):
(WebCore::createActiveAnimation):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::addAnimation):
Source/WebKit/chromium:
* tests/GraphicsLayerChromiumTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (121843 => 121844)
--- trunk/Source/WebCore/ChangeLog 2012-07-04 12:53:48 UTC (rev 121843)
+++ trunk/Source/WebCore/ChangeLog 2012-07-04 12:57:58 UTC (rev 121844)
@@ -1,3 +1,25 @@
+2012-07-04 Ian Vollick
+
+[chromium] Correctly reject accelerated animations with certain rotations.
+https://bugs.webkit.org/show_bug.cgi?id=89768
+
+Reviewed by James Robinson.
+
+UnitTests:
+ GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
+ GraphicsLayerChromiumTest.createTransformAnimationWithRotationInvolvingNegativeAngles
+ GraphicsLayerChromiumTest.createTransformAnimationWithSmallRotationInvolvingLargeAngles
+
+* platform/graphics/chromium/AnimationTranslationUtil.cpp:
+(WebCore::appendKeyframe):
+(WebCore::isRotationType):
+(WebCore):
+(WebCore::causesRotationOfAtLeast180Degrees):
+(WebCore::CCKeyframedTransformAnimationCurve):
+(WebCore::createActiveAnimation):
+* platform/graphics/chromium/GraphicsLayerChromium.cpp:
+(WebCore::GraphicsLayerChromium::addAnimation):
+
2012-07-04 Pavel Feldman
Web Inspector: "Dock to right" shouldn't be in the settings dialog
Modified: trunk/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp (121843 => 121844)
--- trunk/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp 2012-07-04 12:53:48 UTC (rev 121843)
+++ trunk/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp 2012-07-04 12:57:58 UTC (rev 121844)
@@ -122,15 +122,54 @@
}
template
-bool appendKeyframe(Curve& curve, double keyTime, const Value* value, PassOwnPtr timingFunction, const FloatSize&)
+bool appendKeyframe(Curve& curve, double keyTime, const Value* value, const Value* lastValue, PassOwnPtr timingFunction, const FloatSize&)
{
curve.addKeyframe(Keyframe::create(keyTime, value->value(), timingFunction));
return true;
}
+bool isRotationType(TransformOperation::OperationType transformType)
+{
+return transformType == TransformOperation::ROTATE
+|| transformType == TransformOperation::ROTATE_X
+|| transformType == TransformOperation::ROTATE_Y
+|| transformType == TransformOperation::ROTATE_Z
+|| transformType == TransformOperation::ROTATE_3D;
+}
+
+bool causesRotationOfAtLeast180Degrees(const TransformAnimationValue* value, const TransformAnimationValue* lastValue)
+{
+if (!lastValue)
+return false;
+
+const TransformOperations& operations = *value->value();
+const TransformOperations& lastOperations = *lastValue->value();
+
+// We'll be doing matrix interpolation in this case. No risk of incorrect
+// rotations here.
+if (!operations.operationsMatch(lastOperations))
+return false;
+
+for (size_t i = 0; i < operations.size(); ++i) {
+if (!isRotationType(operations.operations()[i]->getOperationType()))
+continue;
+
+RotateTransformOperation* rotation = static_cast(operations.operations()[i].get());
+RotateTransformOperation* lastRotation = static_cast(lastOperations.operations()[i].get());
+
+if (fabs(rotation->angle() - lastRotation->angle()) >= 180)
+return true;
+}
+
+return false;
+}
+
template <>
-bool appendKeyframe(CCKeyframedTransformAnimationCurve& curve, double keyTime, const TransformAnimationValue* value, PassOwnPtr timingFunction, const FloatSize& boxSize)
+bool appendKeyframe(CCKeyframedTransformAnimationCurve& curve, double keyTime, const TransformAnimationValue* value, co
[webkit-changes] [121843] trunk/Source/WebCore
Title: [121843] trunk/Source/WebCore
Revision 121843
Author pfeld...@chromium.org
Date 2012-07-04 05:53:48 -0700 (Wed, 04 Jul 2012)
Log Message
Web Inspector: "Dock to right" shouldn't be in the settings dialog
https://bugs.webkit.org/show_bug.cgi?id=76917
Reviewed by Vsevolod Vlasov.
Introduced 'long click-enabled' options for status bar buttons. Made dock/undock one of them.
* inspector/front-end/Images/statusbarButtonGlyphs.png:
* inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarButton.prototype._clicked):
(WebInspector.StatusBarButton.prototype.set visible):
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseDown):
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseUp):
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled):
(WebInspector.StatusBarButton.prototype._showOptions.mouseOver):
(WebInspector.StatusBarButton.prototype._showOptions.mouseOut):
(WebInspector.StatusBarButton.prototype._showOptions.mouseUp):
(WebInspector.StatusBarButton.prototype._showOptions):
* inspector/front-end/UIUtils.js:
(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.GlassPane):
(WebInspector.GlassPane.prototype.dispose):
* inspector/front-end/inspector.css:
(.long-click-glyph):
(.long-click-glyph.shadow):
(button.status-bar-item:active:not(.emulate-inactive), button.status-bar-item.emulate-active):
(.alternate-status-bar-buttons-bar):
(.alternate-status-bar-buttons-bar .status-bar-item):
* inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector._createDockOptions.onClick.set else):
(WebInspector._createDockOptions.onClick):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Images/statusbarButtonGlyphs.png
trunk/Source/WebCore/inspector/front-end/StatusBarButton.js
trunk/Source/WebCore/inspector/front-end/UIUtils.js
trunk/Source/WebCore/inspector/front-end/inspector.css
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (121842 => 121843)
--- trunk/Source/WebCore/ChangeLog 2012-07-04 12:32:57 UTC (rev 121842)
+++ trunk/Source/WebCore/ChangeLog 2012-07-04 12:53:48 UTC (rev 121843)
@@ -1,3 +1,39 @@
+2012-07-04 Pavel Feldman
+
+Web Inspector: "Dock to right" shouldn't be in the settings dialog
+https://bugs.webkit.org/show_bug.cgi?id=76917
+
+Reviewed by Vsevolod Vlasov.
+
+Introduced 'long click-enabled' options for status bar buttons. Made dock/undock one of them.
+
+* inspector/front-end/Images/statusbarButtonGlyphs.png:
+* inspector/front-end/StatusBarButton.js:
+(WebInspector.StatusBarButton.prototype._clicked):
+(WebInspector.StatusBarButton.prototype.set visible):
+(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseDown):
+(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseUp):
+(WebInspector.StatusBarButton.prototype.makeLongClickEnabled):
+(WebInspector.StatusBarButton.prototype._showOptions.mouseOver):
+(WebInspector.StatusBarButton.prototype._showOptions.mouseOut):
+(WebInspector.StatusBarButton.prototype._showOptions.mouseUp):
+(WebInspector.StatusBarButton.prototype._showOptions):
+* inspector/front-end/UIUtils.js:
+(WebInspector.elementDragStart):
+(WebInspector.elementDragEnd):
+(WebInspector.GlassPane):
+(WebInspector.GlassPane.prototype.dispose):
+* inspector/front-end/inspector.css:
+(.long-click-glyph):
+(.long-click-glyph.shadow):
+(button.status-bar-item:active:not(.emulate-inactive), button.status-bar-item.emulate-active):
+(.alternate-status-bar-buttons-bar):
+(.alternate-status-bar-buttons-bar .status-bar-item):
+* inspector/front-end/inspector.js:
+(WebInspector._createGlobalStatusBarItems):
+(WebInspector._createDockOptions.onClick.set else):
+(WebInspector._createDockOptions.onClick):
+
2012-07-04 Sheriff Bot
Unreviewed, rolling out r121813.
Modified: trunk/Source/WebCore/inspector/front-end/Images/statusbarButtonGlyphs.png
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/StatusBarButton.js (121842 => 121843)
--- trunk/Source/WebCore/inspector/front-end/StatusBarButton.js 2012-07-04 12:32:57 UTC (rev 121842)
+++ trunk/Source/WebCore/inspector/front-end/StatusBarButton.js 2012-07-04 12:53:48 UTC (rev 121843)
@@ -65,6 +65,8 @@
_clicked: function()
{
this.dispatchEventToListeners("click");
+if (this._showOptionsTimer)
+clearTimeout(this._showOptionsTimer);
},
get disabled()
@@ -147,6 +149,94 @@
else
this.element.addStyleClass("hidden");
this._visible = x;
+},
+
+/**
+ * @param {function():Array.} buttonsProvider
+ */
+makeLongClickEnabled: function(buttonsProvider)
+
[webkit-changes] [121842] trunk/LayoutTests
Title: [121842] trunk/LayoutTests
Revision 121842
Author vse...@chromium.org
Date 2012-07-04 05:32:57 -0700 (Wed, 04 Jul 2012)
Log Message
REGRESSION(r121792): inspector/extensions/extensions-resources.html fails
https://bugs.webkit.org/show_bug.cgi?id=90530
Reviewed by Pavel Feldman.
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest.disableDebugger):
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest.debuggerDisabled):
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest):
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.completeTest):
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest):
* inspector/extensions/extensions-resources-expected.txt:
* inspector/extensions/extensions-resources.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/debugger-test.js
trunk/LayoutTests/inspector/extensions/extensions-resources-expected.txt
trunk/LayoutTests/inspector/extensions/extensions-resources.html
trunk/LayoutTests/platform/qt/Skipped
Diff
Modified: trunk/LayoutTests/ChangeLog (121841 => 121842)
--- trunk/LayoutTests/ChangeLog 2012-07-04 12:09:52 UTC (rev 121841)
+++ trunk/LayoutTests/ChangeLog 2012-07-04 12:32:57 UTC (rev 121842)
@@ -1,3 +1,19 @@
+2012-07-04 Vsevolod Vlasov
+
+REGRESSION(r121792): inspector/extensions/extensions-resources.html fails
+https://bugs.webkit.org/show_bug.cgi?id=90530
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/debugger-test.js:
+(initialize_DebuggerTest.InspectorTest.finishDebuggerTest.disableDebugger):
+(initialize_DebuggerTest.InspectorTest.finishDebuggerTest.debuggerDisabled):
+(initialize_DebuggerTest.InspectorTest.finishDebuggerTest):
+(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.completeTest):
+(initialize_DebuggerTest.InspectorTest.completeDebuggerTest):
+* inspector/extensions/extensions-resources-expected.txt:
+* inspector/extensions/extensions-resources.html:
+
2012-07-04 Zan Dobersek
Unreviewed GTK gardening, updating baselines after r121789.
Modified: trunk/LayoutTests/http/tests/inspector/debugger-test.js (121841 => 121842)
--- trunk/LayoutTests/http/tests/inspector/debugger-test.js 2012-07-04 12:09:52 UTC (rev 121841)
+++ trunk/LayoutTests/http/tests/inspector/debugger-test.js 2012-07-04 12:32:57 UTC (rev 121842)
@@ -22,7 +22,7 @@
}
};
-InspectorTest.completeDebuggerTest = function()
+InspectorTest.finishDebuggerTest = function(callback)
{
var scriptsPanel = WebInspector.panels.scripts;
@@ -34,18 +34,23 @@
if (!scriptsPanel._debuggerEnabled)
completeTest();
else {
-InspectorTest.addSniffer(WebInspector.debuggerModel, "_debuggerWasDisabled", completeTest);
+InspectorTest.addSniffer(WebInspector.debuggerModel, "_debuggerWasDisabled", debuggerDisabled);
scriptsPanel.toggleDebugging(false);
}
}
-function completeTest()
+function debuggerDisabled()
{
InspectorTest.addResult("Debugger was disabled.");
-InspectorTest.completeTest();
+callback();
}
};
+InspectorTest.completeDebuggerTest = function()
+{
+InspectorTest.finishDebuggerTest(InspectorTest.completeTest.bind(InspectorTest));
+};
+
InspectorTest.runDebuggerTestSuite = function(testSuite)
{
var testSuiteTests = testSuite.slice();
Modified: trunk/LayoutTests/inspector/extensions/extensions-resources-expected.txt (121841 => 121842)
--- trunk/LayoutTests/inspector/extensions/extensions-resources-expected.txt 2012-07-04 12:09:52 UTC (rev 121841)
+++ trunk/LayoutTests/inspector/extensions/extensions-resources-expected.txt 2012-07-04 12:32:57 UTC (rev 121842)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 11: don't panic!
+CONSOLE MESSAGE: line 12: don't panic!
Tests resource-related methods of WebInspector extension API
@@ -60,6 +60,7 @@
content committed for resource .../audits-style1.css (type: stylesheet), new content: div.test { width: 220px; height: 42px; }
Revision content: div.test { width: 220px; height: 42px; }
RUNNING TEST: extension_testOnResourceAdded
+Debugger was enabled.
resource added:
{
0 : {
@@ -69,6 +70,7 @@
setContent :
}
}
+Debugger was disabled.
RUNNING TEST: extension_testOpenResourceHandler
handleOpenResource() invoked [this should only appear once!]:
{
@@ -78,7 +80,7 @@
getContent :
setContent :
}
-1 : 11
+1 : 12
}
RUNNING TEST: extension_testSetResourceContent
div.test width after stylesheet edited (should be 126): 126
Modified: trunk/LayoutTests/inspector/extensions/extensions-resources.html (121841 => 121842)
--- trunk/LayoutTests/inspector/extensions/extensions-resources.html 2012-07-04 12:09:52 UTC (rev 121841)
+++ trunk/LayoutTests/inspector/extensions/extensions-resources.html 2012-07-04 12:32:57 UTC (re
[webkit-changes] [121841] trunk/LayoutTests
Title: [121841] trunk/LayoutTests
Revision 121841
Author zandober...@gmail.com
Date 2012-07-04 05:09:52 -0700 (Wed, 04 Jul 2012)
Log Message
Unreviewed GTK gardening, updating baselines after r121789.
* platform/gtk/TestExpectations:
* platform/gtk/css1/formatting_model/floating_elements-expected.png: Added.
* platform/gtk/css1/formatting_model/floating_elements-expected.txt:
* platform/gtk/fast/block/float/010-expected.png:
* platform/gtk/fast/block/float/010-expected.txt:
* platform/gtk/fast/block/float/independent-align-positioning-expected.png:
* platform/gtk/fast/block/float/independent-align-positioning-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/css1/formatting_model/floating_elements-expected.txt
trunk/LayoutTests/platform/gtk/fast/block/float/010-expected.png
trunk/LayoutTests/platform/gtk/fast/block/float/010-expected.txt
trunk/LayoutTests/platform/gtk/fast/block/float/independent-align-positioning-expected.png
trunk/LayoutTests/platform/gtk/fast/block/float/independent-align-positioning-expected.txt
Added Paths
trunk/LayoutTests/platform/gtk/css1/formatting_model/floating_elements-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (121840 => 121841)
--- trunk/LayoutTests/ChangeLog 2012-07-04 11:06:47 UTC (rev 121840)
+++ trunk/LayoutTests/ChangeLog 2012-07-04 12:09:52 UTC (rev 121841)
@@ -1,3 +1,15 @@
+2012-07-04 Zan Dobersek
+
+Unreviewed GTK gardening, updating baselines after r121789.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/css1/formatting_model/floating_elements-expected.png: Added.
+* platform/gtk/css1/formatting_model/floating_elements-expected.txt:
+* platform/gtk/fast/block/float/010-expected.png:
+* platform/gtk/fast/block/float/010-expected.txt:
+* platform/gtk/fast/block/float/independent-align-positioning-expected.png:
+* platform/gtk/fast/block/float/independent-align-positioning-expected.txt:
+
2012-07-04 Zoltan Arvai
[Qt] Unreviewed gardening. Skip failing test.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (121840 => 121841)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-04 11:06:47 UTC (rev 121840)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-04 12:09:52 UTC (rev 121841)
@@ -1243,11 +1243,6 @@
BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
-// Require rebaseline after bug 88171
-BUGWK88171 : fast/block/float/independent-align-positioning.html = TEXT
-BUGWK88171 : fast/block/float/010.html = TEXT
-BUGWK88171 : css1/formatting_model/floating_elements.html = TEXT
-
//
// End of Tests failing
//
Added: trunk/LayoutTests/platform/gtk/css1/formatting_model/floating_elements-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/gtk/css1/formatting_model/floating_elements-expected.png
___
Added: svn:mime-type
Modified: trunk/LayoutTests/platform/gtk/css1/formatting_model/floating_elements-expected.txt (121840 => 121841)
--- trunk/LayoutTests/platform/gtk/css1/formatting_model/floating_elements-expected.txt 2012-07-04 11:06:47 UTC (rev 121840)
+++ trunk/LayoutTests/platform/gtk/css1/formatting_model/floating_elements-expected.txt 2012-07-04 12:09:52 UTC (rev 121841)
@@ -1,8 +1,8 @@
-layer at (0,0) size 785x6285
+layer at (0,0) size 785x6281
RenderView at (0,0) size 785x600
-layer at (0,0) size 785x6285
- RenderBlock {HTML} at (0,0) size 785x6285
-RenderBody {BODY} at (8,8) size 769x6269 [bgcolor=#CC]
+layer at (0,0) size 785x6281
+ RenderBlock {HTML} at (0,0) size 785x6281
+RenderBody {BODY} at (8,8) size 769x6265 [bgcolor=#CC]
RenderBlock {P} at (0,0) size 769x18
RenderText {#text} at (0,0) size 355x19
text run at (0,0) width 355: "The style declarations which apply to the text below are:"
@@ -108,7 +108,7 @@
text run at (45,149) width 307: "The first two should be side by side, whereas the"
text run at (5,167) width 213: "third should be on the next \"line.\""
RenderBlock {HR} at (24,976) size 578x2 [border: (1px inset #00)]
- RenderBlock {DIV} at (2,1002) size 314x352 [border: (5px solid #800080)]
+ RenderBlock {DIV} at (2,1002) size 314x350 [border: (5px solid #800080)]
RenderBlock (floating) {P} at (5,5) size 194x88 [bgcolor=#C0C0C0] [border: (1px solid #00FF00)]
RenderText {#text} at (17,17) size 130x55
text run at (17,17) width 130: "This is a left-floating"
@@ -119,50 +119,47 @@
text run at (17,17) width 139: "This is a right-floating"
text run at (17,35) wi
[webkit-changes] [121840] trunk/Tools
Title: [121840] trunk/Tools Revision 121840 Author ser...@webkit.org Date 2012-07-04 04:06:47 -0700 (Wed, 04 Jul 2012) Log Message [WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library https://bugs.webkit.org/show_bug.cgi?id=90541 Reviewed by Carlos Garcia Campos. We must add the contents of WebKitBuild/*/Libraries/ directory to the file to be uploaded to b.w.o to successfully run WebKit2 tests in the WebKit2 testing bot. * BuildSlaveSupport/built-product-archive: (archiveBuiltProduct): appended Libraries to the list of neededDirectories. Modified Paths trunk/Tools/BuildSlaveSupport/built-product-archive trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (121839 => 121840) --- trunk/Tools/BuildSlaveSupport/built-product-archive 2012-07-04 09:02:41 UTC (rev 121839) +++ trunk/Tools/BuildSlaveSupport/built-product-archive 2012-07-04 11:06:47 UTC (rev 121840) @@ -144,7 +144,7 @@ if platform == 'qt' or platform == 'efl': neededDirectories = ["bin", "lib"] elif platform == 'gtk': -neededDirectories = ["Programs", ".libs"] +neededDirectories = ["Programs", ".libs", "Libraries"] for dirname in neededDirectories: fromDir = os.path.join(configurationBuildDirectory, dirname, "*") Modified: trunk/Tools/ChangeLog (121839 => 121840) --- trunk/Tools/ChangeLog 2012-07-04 09:02:41 UTC (rev 121839) +++ trunk/Tools/ChangeLog 2012-07-04 11:06:47 UTC (rev 121840) @@ -1,5 +1,20 @@ 2012-07-04 Sergio Villar Senin +[WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library +https://bugs.webkit.org/show_bug.cgi?id=90541 + +Reviewed by Carlos Garcia Campos. + +We must add the contents of WebKitBuild/*/Libraries/ directory to +the file to be uploaded to b.w.o to successfully run WebKit2 tests +in the WebKit2 testing bot. + +* BuildSlaveSupport/built-product-archive: +(archiveBuiltProduct): appended Libraries to the list of +neededDirectories. + +2012-07-04 Sergio Villar Senin + [GTK] WebKit2 testing bot unable to find the build directory https://bugs.webkit.org/show_bug.cgi?id=90523 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121838] trunk/LayoutTests
Title: [121838] trunk/LayoutTests Revision 121838 Author ser...@webkit.org Date 2012-07-04 01:31:23 -0700 (Wed, 04 Jul 2012) Log Message Unreviewed GTK gardening. Removed some tests from TestExpectations as they were passing in the tree bots. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (121837 => 121838) --- trunk/LayoutTests/ChangeLog 2012-07-04 08:05:18 UTC (rev 121837) +++ trunk/LayoutTests/ChangeLog 2012-07-04 08:31:23 UTC (rev 121838) @@ -1,3 +1,10 @@ +2012-07-04 Sergio Villar Senin + +Unreviewed GTK gardening. Removed some tests from TestExpectations +as they were passing in the tree bots. + +* platform/gtk/TestExpectations: + 2012-07-04 Sheriff Bot Unreviewed, rolling out r121813. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (121837 => 121838) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-04 08:05:18 UTC (rev 121837) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-04 08:31:23 UTC (rev 121838) @@ -304,6 +304,7 @@ // These tests require subpixel layout to be enabled BUGWK85532 : fast/sub-pixel = TEXT IMAGE BUGWK85532 : fast/sub-pixel/float-containing-block-with-margin.html = PASS +BUGWK85532 : fast/sub-pixel/float-with-margin-in-container.html = PASS BUGWK85532 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS BUGWK85532 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS BUGWK85532 : fast/sub-pixel/inline-block-with-margin.html = PASS @@ -953,8 +954,6 @@ BUGWK50740 : editing/spelling/spellcheck-sequencenum.html = TEXT BUGWK50740 : editing/spelling/spellcheck-async-mutation.html = TEXT -BUGWK82675 : http/tests/local/link-stylesheet-load-order.html = TEXT - // DRT does not obey layoutTestController.addURLToRedirect() BUGWKGTK : http/tests/loading/cross-origin-XHR-willLoadRequest.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121837] trunk/Tools
Title: [121837] trunk/Tools Revision 121837 Author ser...@webkit.org Date 2012-07-04 01:05:18 -0700 (Wed, 04 Jul 2012) Log Message [GTK] WebKit2 testing bot unable to find the build directory https://bugs.webkit.org/show_bug.cgi?id=90523 Reviewed by Carlos Garcia Campos. The presence of GNUmakefile was used to determine whether a given directory was a valid build directory or not. That's not correct for testing bots as we export only the minimum required stuff to run the tests. * gtk/common.py: (get_build_path.is_valid_build_directory): added an extra check.: Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/common.py Diff Modified: trunk/Tools/ChangeLog (121836 => 121837) --- trunk/Tools/ChangeLog 2012-07-04 07:53:20 UTC (rev 121836) +++ trunk/Tools/ChangeLog 2012-07-04 08:05:18 UTC (rev 121837) @@ -1,3 +1,18 @@ +2012-07-04 Sergio Villar Senin + +[GTK] WebKit2 testing bot unable to find the build directory +https://bugs.webkit.org/show_bug.cgi?id=90523 + +Reviewed by Carlos Garcia Campos. + +The presence of GNUmakefile was used to determine whether a given +directory was a valid build directory or not. That's not correct for +testing bots as we export only the minimum required stuff to run the +tests. + +* gtk/common.py: +(get_build_path.is_valid_build_directory): added an extra check.: + 2012-07-04 Joe Thomas Adding myself to committers list. Modified: trunk/Tools/gtk/common.py (121836 => 121837) --- trunk/Tools/gtk/common.py 2012-07-04 07:53:20 UTC (rev 121836) +++ trunk/Tools/gtk/common.py 2012-07-04 08:05:18 UTC (rev 121837) @@ -40,7 +40,8 @@ return build_dir def is_valid_build_directory(path): -return os.path.exists(os.path.join(path, 'GNUmakefile')) +return os.path.exists(os.path.join(path, 'GNUmakefile')) or \ +os.path.exists(os.path.join(path, 'Programs', 'DumpRenderTree')) if len(sys.argv[1:]) > 1 and os.path.exists(sys.argv[-1]) and is_valid_build_directory(sys.argv[-1]): return sys.argv[-1] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121836] trunk
Title: [121836] trunk
Revision 121836
Author commit-qu...@webkit.org
Date 2012-07-04 00:53:20 -0700 (Wed, 04 Jul 2012)
Log Message
Unreviewed, rolling out r121813.
http://trac.webkit.org/changeset/121813
https://bugs.webkit.org/show_bug.cgi?id=90522
Causes browser_tests failure:
ErrorPageTest.DNSError_GoBack2{Forward2,AndForward} on
Chromium {Linux,Mac,Win} (Requested by yosin on #webkit).
Patch by Sheriff Bot on 2012-07-04
Source/WebCore:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
LayoutTests:
* http/tests/multipart/multipart-replace-non-html-content-expected.txt: Removed.
* http/tests/multipart/multipart-replace-non-html-content.php: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp
Removed Paths
trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt
trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content.php
Diff
Modified: trunk/LayoutTests/ChangeLog (121835 => 121836)
--- trunk/LayoutTests/ChangeLog 2012-07-04 07:33:41 UTC (rev 121835)
+++ trunk/LayoutTests/ChangeLog 2012-07-04 07:53:20 UTC (rev 121836)
@@ -1,3 +1,16 @@
+2012-07-04 Sheriff Bot
+
+Unreviewed, rolling out r121813.
+http://trac.webkit.org/changeset/121813
+https://bugs.webkit.org/show_bug.cgi?id=90522
+
+Causes browser_tests failure:
+ErrorPageTest.DNSError_GoBack2{Forward2,AndForward} on
+Chromium {Linux,Mac,Win} (Requested by yosin on #webkit).
+
+* http/tests/multipart/multipart-replace-non-html-content-expected.txt: Removed.
+* http/tests/multipart/multipart-replace-non-html-content.php: Removed.
+
2012-07-04 Kihong Kwon
[EFL] Change format of return value of navigator.language
Deleted: trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt (121835 => 121836)
--- trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt 2012-07-04 07:33:41 UTC (rev 121835)
+++ trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt 2012-07-04 07:53:20 UTC (rev 121836)
@@ -1,3 +0,0 @@
-This text should only appear once 10
[webkit-changes] [121835] trunk/Source/WebKit2
Title: [121835] trunk/Source/WebKit2
Revision 121835
Author commit-qu...@webkit.org
Date 2012-07-04 00:33:41 -0700 (Wed, 04 Jul 2012)
Log Message
[EFL][WK2] Ewk_View should report load errors
https://bugs.webkit.org/show_bug.cgi?id=90479
Patch by Christophe Dumez on 2012-07-04
Reviewed by Kenneth Rohde Christiansen.
The Ewk_View now emits a "load,error" signal when the
main frame fails loading. Information about the error
is provided via the new Ewk_Web_Error type.
* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_load_error):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didFailLoadWithErrorForFrame):
(ewk_view_loader_client_attach):
* UIProcess/API/efl/ewk_view_private.h:
* UIProcess/API/efl/ewk_web_error.cpp: Added.
(_Ewk_Web_Error):
(ewk_web_error_free):
(ewk_web_error_domain_get):
(ewk_web_error_url_get):
(ewk_web_error_code_get):
(ewk_web_error_description_get):
(ewk_web_error_cancellation_get):
(ewk_web_error_new):
* UIProcess/API/efl/ewk_web_error.h: Added.
* UIProcess/API/efl/ewk_web_error_private.h: Added.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_loader_client.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_private.h
Added Paths
trunk/Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_web_error.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_web_error_private.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (121834 => 121835)
--- trunk/Source/WebKit2/ChangeLog 2012-07-04 07:30:11 UTC (rev 121834)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-04 07:33:41 UTC (rev 121835)
@@ -1,3 +1,35 @@
+2012-07-04 Christophe Dumez
+
+[EFL][WK2] Ewk_View should report load errors
+https://bugs.webkit.org/show_bug.cgi?id=90479
+
+Reviewed by Kenneth Rohde Christiansen.
+
+The Ewk_View now emits a "load,error" signal when the
+main frame fails loading. Information about the error
+is provided via the new Ewk_Web_Error type.
+
+* PlatformEfl.cmake:
+* UIProcess/API/efl/EWebKit2.h:
+* UIProcess/API/efl/ewk_view.cpp:
+(ewk_view_load_error):
+* UIProcess/API/efl/ewk_view.h:
+* UIProcess/API/efl/ewk_view_loader_client.cpp:
+(didFailLoadWithErrorForFrame):
+(ewk_view_loader_client_attach):
+* UIProcess/API/efl/ewk_view_private.h:
+* UIProcess/API/efl/ewk_web_error.cpp: Added.
+(_Ewk_Web_Error):
+(ewk_web_error_free):
+(ewk_web_error_domain_get):
+(ewk_web_error_url_get):
+(ewk_web_error_code_get):
+(ewk_web_error_description_get):
+(ewk_web_error_cancellation_get):
+(ewk_web_error_new):
+* UIProcess/API/efl/ewk_web_error.h: Added.
+* UIProcess/API/efl/ewk_web_error_private.h: Added.
+
2012-07-03 Christophe Dumez
[WK2][EFL] Ewk_View should report the load progress
Modified: trunk/Source/WebKit2/PlatformEfl.cmake (121834 => 121835)
--- trunk/Source/WebKit2/PlatformEfl.cmake 2012-07-04 07:30:11 UTC (rev 121834)
+++ trunk/Source/WebKit2/PlatformEfl.cmake 2012-07-04 07:33:41 UTC (rev 121835)
@@ -36,6 +36,7 @@
UIProcess/API/efl/ewk_intent_service.cpp
UIProcess/API/efl/ewk_view.cpp
UIProcess/API/efl/ewk_view_loader_client.cpp
+UIProcess/API/efl/ewk_web_error.cpp
UIProcess/cairo/BackingStoreCairo.cpp
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h (121834 => 121835)
--- trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h 2012-07-04 07:30:11 UTC (rev 121834)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h 2012-07-04 07:33:41 UTC (rev 121835)
@@ -31,5 +31,6 @@
#include "ewk_intent.h"
#include "ewk_intent_service.h"
#include "ewk_view.h"
+#include "ewk_web_error.h"
#endif // EWebKit2_h
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (121834 => 121835)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-07-04 07:30:11 UTC (rev 121834)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-07-04 07:33:41 UTC (rev 121835)
@@ -678,6 +678,18 @@
evas_object_image_data_copy_set(smartData->image, imageData);
}
+/**
+ * @internal
+ * Reports load failed with error information.
+ *
+ * Emits signal: "load,error" with pointer to Ewk_Web_Error.
+ */
+void ewk_view_load_error(Evas_Object* ewkView, const Ewk_Web_Error* error)
+{
+evas_object_smart_callback_call(ewkView, "load,error", const_cast(error));
+}
+
+
#if ENABLE(WEB_INTENTS_TAG)
/**
* @internal
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h (121834 => 121835)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-07-04 07:30:11 UTC (rev 121834)
+++ trunk/Sourc
[webkit-changes] [121833] trunk
Title: [121833] trunk
Revision 121833
Author commit-qu...@webkit.org
Date 2012-07-04 00:29:30 -0700 (Wed, 04 Jul 2012)
Log Message
[EFL] Change format of return value of navigator.language
https://bugs.webkit.org/show_bug.cgi?id=89639
Patch by Kihong Kwon on 2012-07-04
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Remove encoding type from return value of navigator.language.
For example, from en-US.UTF-8 to en-US.
Use exist test case (fast/js/navigator-language.html).
* platform/efl/LanguageEfl.cpp:
(WebCore::platformLanguage):
LayoutTests:
* platform/efl/TestExpectations: Remove fast/js/navigator-language.html
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/LanguageEfl.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (121832 => 121833)
--- trunk/LayoutTests/ChangeLog 2012-07-04 07:03:24 UTC (rev 121832)
+++ trunk/LayoutTests/ChangeLog 2012-07-04 07:29:30 UTC (rev 121833)
@@ -1,3 +1,12 @@
+2012-07-04 Kihong Kwon
+
+[EFL] Change format of return value of navigator.language
+https://bugs.webkit.org/show_bug.cgi?id=89639
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* platform/efl/TestExpectations: Remove fast/js/navigator-language.html
+
2012-07-04 Yoshifumi Inoue
[Chromium] Unreviewed gardening for Mac
Modified: trunk/LayoutTests/platform/efl/TestExpectations (121832 => 121833)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-07-04 07:03:24 UTC (rev 121832)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-07-04 07:29:30 UTC (rev 121833)
@@ -679,9 +679,6 @@
// EFL port does not support hyphenation
BUGWK89830 : fast/text/hyphen-min-preferred-width.html = IMAGE
-// EFL format for navigator.language should be adapted
-BUGWK89639 : fast/js/navigator-language.html = TEXT
-
// EFL's LayoutTestController does not implement setAsynchronousSpellCheckingEnabled
BUGWK86637 : editing/spelling/spellcheck-async.html = TEXT
BUGWK86637 : editing/spelling/spellcheck-async-mutation.html = TEXT
Modified: trunk/Source/WebCore/ChangeLog (121832 => 121833)
--- trunk/Source/WebCore/ChangeLog 2012-07-04 07:03:24 UTC (rev 121832)
+++ trunk/Source/WebCore/ChangeLog 2012-07-04 07:29:30 UTC (rev 121833)
@@ -1,3 +1,18 @@
+2012-07-04 Kihong Kwon
+
+[EFL] Change format of return value of navigator.language
+https://bugs.webkit.org/show_bug.cgi?id=89639
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Remove encoding type from return value of navigator.language.
+For example, from en-US.UTF-8 to en-US.
+
+Use exist test case (fast/js/navigator-language.html).
+
+* platform/efl/LanguageEfl.cpp:
+(WebCore::platformLanguage):
+
2012-07-03 Carlos Garcia Campos
[GTK] Don't show accel labels in context menu items
Modified: trunk/Source/WebCore/platform/efl/LanguageEfl.cpp (121832 => 121833)
--- trunk/Source/WebCore/platform/efl/LanguageEfl.cpp 2012-07-04 07:03:24 UTC (rev 121832)
+++ trunk/Source/WebCore/platform/efl/LanguageEfl.cpp 2012-07-04 07:29:30 UTC (rev 121833)
@@ -43,7 +43,13 @@
if (!localeDefault)
return String("c");
-return String(localeDefault).replace('_', '-');
+String locale = String(localeDefault);
+locale.replace('_', '-');
+size_t position = locale.find('.');
+if (position != notFound)
+locale = locale.left(position);
+
+return locale;
}
Vector platformUserPreferredLanguages()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121832] trunk/LayoutTests
Title: [121832] trunk/LayoutTests Revision 121832 Author yo...@chromium.org Date 2012-07-04 00:03:24 -0700 (Wed, 04 Jul 2012) Log Message [Chromium] Unreviewed gardening for Mac https://bugs.webkit.org/show_bug.cgi?id=90430 * platform/chromium/TestExpectations: Add TIMEOUT to inspector/timeline/timeline-receive-response-event.html Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (121831 => 121832) --- trunk/LayoutTests/ChangeLog 2012-07-04 06:52:33 UTC (rev 121831) +++ trunk/LayoutTests/ChangeLog 2012-07-04 07:03:24 UTC (rev 121832) @@ -1,3 +1,10 @@ +2012-07-04 Yoshifumi Inoue + +[Chromium] Unreviewed gardening for Mac +https://bugs.webkit.org/show_bug.cgi?id=90430 + +* platform/chromium/TestExpectations: Add TIMEOUT to inspector/timeline/timeline-receive-response-event.html + 2012-07-03 Yoshifumi Inoue [Chromium] Unreviewed gardening for Win build Modified: trunk/LayoutTests/platform/chromium/TestExpectations (121831 => 121832) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-04 06:52:33 UTC (rev 121831) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-04 07:03:24 UTC (rev 121832) @@ -3716,7 +3716,7 @@ BUGWK90207 SLOW LINUX DEBUG : fast/forms/select/select-state-restore.html = PASS TEXT // Flaky -BUGWK90430 : inspector/timeline/timeline-receive-response-event.html = PASS TEXT +BUGWK90430 : inspector/timeline/timeline-receive-response-event.html = PASS TEXT TIMEOUT // Flaky on windows BUGWK90469 WIN : storage/indexeddb/mozilla/indexes.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
