[webkit-changes] [121883] trunk
Title: [121883] trunk Revision 121883 Author commit-qu...@webkit.org Date 2012-07-04 23:45:37 -0700 (Wed, 04 Jul 2012) Log Message Implement the script-nonce Content Security Policy directive. https://bugs.webkit.org/show_bug.cgi?id=89577 Patch by Mike West mk...@chromium.org on 2012-07-04 Reviewed by Adam Barth. Source/WebCore: This patch implements the (experimental) script-nonce Content Security Policy directive from the 1.1 spec, which allows for selective execution of script by specifying a nonce attribute for the script tag. Script is only loaded and executed if it both matches the nonce and matches the script-src whitelist (if present). The implementation is gated on the ENABLE_CSP_NEXT flag, which is currently disabled for all ports other than Chromium. Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#script-nonce--experimental Tests: http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html * dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript): (WebCore::ScriptElement::executeScript): Passing the nonce attribute through to check against CSP. * html/HTMLAttributeNames.in: * html/HTMLScriptElement.idl: Adding the `nonce` attribute to the script tag. * page/ContentSecurityPolicy.cpp: (CSPDirectiveList): (WebCore::CSPDirectiveList::logInvalidNonce): (WebCore): (WebCore::CSPDirectiveList::checkNonceAndReportViolation): (WebCore::CSPDirectiveList::allowJavaScriptURLs): (WebCore::CSPDirectiveList::allowInlineEventHandlers): If a nonce is set, deny _javascript_ URLs and inline event handlers. (WebCore::CSPDirectiveList::allowScriptNonce): (WebCore::CSPDirectiveList::parseScriptNonce): (WebCore::CSPDirectiveList::addDirective): (WebCore::isAllowedByAllWithNonce): (WebCore::ContentSecurityPolicy::allowScriptNonce): * page/ContentSecurityPolicy.h: (WebCore): LayoutTests: * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed-expected.txt: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce-expected.txt: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-expected.txt: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce-expected.txt: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked-expected.txt: Added. * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html: Added. * http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl: Adding noncy goodness to the echo script. * http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js: (test): * platform/gtk/TestExpectations: Skipping 1.1 tests on GTK (missed it in r121879). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/ScriptElement.cpp trunk/Source/WebCore/html/HTMLAttributeNames.in trunk/Source/WebCore/html/HTMLScriptElement.idl trunk/Source/WebCore/page/ContentSecurityPolicy.cpp trunk/Source/WebCore/page/ContentSecurityPolicy.h Added Paths trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html Diff
[webkit-changes] [121884] trunk/Source/WebCore
Title: [121884] trunk/Source/WebCore
Revision 121884
Author commit-qu...@webkit.org
Date 2012-07-04 23:53:59 -0700 (Wed, 04 Jul 2012)
Log Message
Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
https://bugs.webkit.org/show_bug.cgi?id=90447
Patch by Huang Dongsung luxte...@company100.net on 2012-07-04
Reviewed by Alexey Proskuryakov.
No new tests. This patch doesn't change behavior.
* platform/graphics/BitmapImage.h:
(BitmapImage):
* platform/graphics/qt/StillImageQt.h:
(StillImage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.h
trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (121883 => 121884)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 06:45:37 UTC (rev 121883)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 06:53:59 UTC (rev 121884)
@@ -1,3 +1,17 @@
+2012-07-04 Huang Dongsung luxte...@company100.net
+
+Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
+https://bugs.webkit.org/show_bug.cgi?id=90447
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests. This patch doesn't change behavior.
+
+* platform/graphics/BitmapImage.h:
+(BitmapImage):
+* platform/graphics/qt/StillImageQt.h:
+(StillImage):
+
2012-07-04 Mike West mk...@chromium.org
Implement the script-nonce Content Security Policy directive.
Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.h (121883 => 121884)
--- trunk/Source/WebCore/platform/graphics/BitmapImage.h 2012-07-05 06:45:37 UTC (rev 121883)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.h 2012-07-05 06:53:59 UTC (rev 121884)
@@ -112,7 +112,7 @@
{
return adoptRef(new BitmapImage(observer));
}
-~BitmapImage();
+virtual ~BitmapImage();
virtual bool isBitmapImage() const;
Modified: trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h (121883 => 121884)
--- trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h 2012-07-05 06:45:37 UTC (rev 121883)
+++ trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h 2012-07-05 06:53:59 UTC (rev 121884)
@@ -58,7 +58,7 @@
private:
StillImage(const QPixmap pixmap);
StillImage(const QPixmap* pixmap);
-~StillImage();
+virtual ~StillImage();
const QPixmap* m_pixmap;
bool m_ownsPixmap;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121886] trunk/Tools
Title: [121886] trunk/Tools
Revision 121886
Author ser...@webkit.org
Date 2012-07-05 00:24:21 -0700 (Thu, 05 Jul 2012)
Log Message
Hidden dirs are not copied when creating the built product archive
https://bugs.webkit.org/show_bug.cgi?id=90559
Reviewed by Carlos Garcia Campos.
Hidden dirs are not copied inside the built product archive
because the recursive copy command was ignoring them. We need those
hidden directories for the GTK WebKit2 testing bot to work fine.
* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): replaced * by . to include hidden
dirs/files.
Modified Paths
trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (121885 => 121886)
--- trunk/Tools/BuildSlaveSupport/built-product-archive 2012-07-05 07:04:16 UTC (rev 121885)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive 2012-07-05 07:24:21 UTC (rev 121886)
@@ -147,7 +147,7 @@
neededDirectories = [Programs, .libs, Libraries]
for dirname in neededDirectories:
-fromDir = os.path.join(configurationBuildDirectory, dirname, *)
+fromDir = os.path.join(configurationBuildDirectory, dirname, .)
toDir = os.path.join(thinDirectory, dirname)
os.makedirs(toDir)
if subprocess.call('cp -R %s %s' % (fromDir, toDir), shell=True):
Modified: trunk/Tools/ChangeLog (121885 => 121886)
--- trunk/Tools/ChangeLog 2012-07-05 07:04:16 UTC (rev 121885)
+++ trunk/Tools/ChangeLog 2012-07-05 07:24:21 UTC (rev 121886)
@@ -1,3 +1,18 @@
+2012-07-05 Sergio Villar Senin svil...@igalia.com
+
+Hidden dirs are not copied when creating the built product archive
+https://bugs.webkit.org/show_bug.cgi?id=90559
+
+Reviewed by Carlos Garcia Campos.
+
+Hidden dirs are not copied inside the built product archive
+because the recursive copy command was ignoring them. We need those
+hidden directories for the GTK WebKit2 testing bot to work fine.
+
+* BuildSlaveSupport/built-product-archive:
+(archiveBuiltProduct): replaced * by . to include hidden
+dirs/files.
+
2012-07-04 Yoshifumi Inoue yo...@chromium.org
Unreviewed Chromium gardening, Disable always failed python tests on Windows.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121887] trunk/Source/JavaScriptCore
Title: [121887] trunk/Source/_javascript_Core
Revision 121887
Author zherc...@webkit.org
Date 2012-07-05 00:53:51 -0700 (Thu, 05 Jul 2012)
Log Message
[Qt] Unreviewed buildfix after r121886. Typo fix.
* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (121886 => 121887)
--- trunk/Source/_javascript_Core/ChangeLog 2012-07-05 07:24:21 UTC (rev 121886)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-07-05 07:53:51 UTC (rev 121887)
@@ -1,5 +1,12 @@
2012-07-05 Zoltan Herczeg zherc...@webkit.org
+[Qt] Unreviewed buildfix after r121886. Typo fix.
+
+* assembler/MacroAssemblerARM.cpp:
+(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
+
+2012-07-05 Zoltan Herczeg zherc...@webkit.org
+
Port DFG JIT to traditional ARM
https://bugs.webkit.org/show_bug.cgi?id=90198
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.cpp (121886 => 121887)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.cpp 2012-07-05 07:24:21 UTC (rev 121886)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.cpp 2012-07-05 07:53:51 UTC (rev 121887)
@@ -77,18 +77,18 @@
if (address.offset = 0 address.offset + 0x2 = 0xff) {
m_assembler.add_r(ARMRegisters::S0, address.base, op2);
-m_assembler.dtrh_u(LoadUint16, dest, ARMRegisters::S0, ARMAssembler::getOp2Half(address.offset));
-m_assembler.dtrh_u(LoadUint16, ARMRegisters::S0, ARMRegisters::S0, ARMAssembler::getOp2Half(address.offset + 0x2));
+m_assembler.dtrh_u(ARMAssembler::LoadUint16, dest, ARMRegisters::S0, ARMAssembler::getOp2Half(address.offset));
+m_assembler.dtrh_u(ARMAssembler::LoadUint16, ARMRegisters::S0, ARMRegisters::S0, ARMAssembler::getOp2Half(address.offset + 0x2));
} else if (address.offset 0 address.offset = -0xff) {
m_assembler.add_r(ARMRegisters::S0, address.base, op2);
-m_assembler.dtrh_d(LoadUint16, dest, ARMRegisters::S0, ARMAssembler::getOp2Byte(-address.offset));
-m_assembler.dtrh_d(LoadUint16, ARMRegisters::S0, ARMRegisters::S0, ARMAssembler::getOp2Byte(-address.offset - 0x2));
+m_assembler.dtrh_d(ARMAssembler::LoadUint16, dest, ARMRegisters::S0, ARMAssembler::getOp2Byte(-address.offset));
+m_assembler.dtrh_d(ARMAssembler::LoadUint16, ARMRegisters::S0, ARMRegisters::S0, ARMAssembler::getOp2Byte(-address.offset - 0x2));
} else {
m_assembler.moveImm(address.offset, ARMRegisters::S0);
m_assembler.add_r(ARMRegisters::S0, ARMRegisters::S0, op2);
-m_assembler.dtrh_r(true, TYPE_UH, dest, address.base, ARMRegisters::S0);
+m_assembler.dtrh_ur(ARMAssembler::LoadUint16, dest, address.base, ARMRegisters::S0);
m_assembler.add_r(ARMRegisters::S0, ARMRegisters::S0, ARMAssembler::OP2_IMM | 0x2);
-m_assembler.dtrh_r(true, TYPE_UH, ARMRegisters::S0, address.base, ARMRegisters::S0);
+m_assembler.dtrh_ur(ARMAssembler::LoadUint16, ARMRegisters::S0, address.base, ARMRegisters::S0);
}
m_assembler.orr_r(dest, dest, m_assembler.lsl(ARMRegisters::S0, 16));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121888] trunk/LayoutTests
Title: [121888] trunk/LayoutTests Revision 121888 Author zandober...@gmail.com Date 2012-07-05 00:58:58 -0700 (Thu, 05 Jul 2012) Log Message Unreviewed GTK gardening, marking a test as a flaky crasher after r121869. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (121887 => 121888) --- trunk/LayoutTests/ChangeLog 2012-07-05 07:53:51 UTC (rev 121887) +++ trunk/LayoutTests/ChangeLog 2012-07-05 07:58:58 UTC (rev 121888) @@ -1,3 +1,9 @@ +2012-07-05 Zan Dobersek zandober...@gmail.com + +Unreviewed GTK gardening, marking a test as a flaky crasher after r121869. + +* platform/gtk/TestExpectations: + 2012-07-04 Mike West mk...@chromium.org Implement the script-nonce Content Security Policy directive. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (121887 => 121888) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-05 07:53:51 UTC (rev 121887) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-05 07:58:58 UTC (rev 121888) @@ -368,6 +368,8 @@ BUGWK89954 DEBUG : http/tests/xmlhttprequest/reentrant-cancel.html = CRASH +BUGWK90589 RELEASE : fast/css/user-drag-none.html = CRASH TIMEOUT + // // End of Crashing tests // ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121889] trunk/Source/WebKit2
Title: [121889] trunk/Source/WebKit2 Revision 121889 Author commit-qu...@webkit.org Date 2012-07-05 00:59:25 -0700 (Thu, 05 Jul 2012) Log Message [WK2][EFL] Ewk_View needs to report new resource requests https://bugs.webkit.org/show_bug.cgi?id=90577 Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-05 Reviewed by Kenneth Rohde Christiansen. Add new resource,request,new signal to Ewk_View to notify clients of the resource requests being initiated. New Ewk_Url_Request and Ewk_Web_Resource types are introduced in order to provide the clients with the needed information regarding the resource requests. * PlatformEfl.cmake: * UIProcess/API/efl/EWebKit2.h: * UIProcess/API/efl/ewk_url_request.cpp: Added. (_Ewk_Url_Request): (ewk_url_request_ref): (ewk_url_request_unref): (ewk_url_request_url_get): (ewk_request_first_party_get): (ewk_url_request_http_method_get): (ewk_url_request_new): * UIProcess/API/efl/ewk_url_request.h: Added. * UIProcess/API/efl/ewk_url_request_private.h: Added. * UIProcess/API/efl/ewk_view.cpp: (ewk_view_base_add): (ewk_view_resource_load_initiated): * UIProcess/API/efl/ewk_view.h: * UIProcess/API/efl/ewk_view_private.h: * UIProcess/API/efl/ewk_view_resource_load_client.cpp: Added. (didInitiateLoadForResource): (ewk_view_resource_load_client_attach): * UIProcess/API/efl/ewk_view_resource_load_client_private.h: Added. * UIProcess/API/efl/ewk_web_resource.cpp: Added. (_Ewk_Web_Resource): (ewk_web_resource_ref): (ewk_web_resource_unref): (ewk_web_resource_uri_get): (ewk_web_resource_new): (ewk_web_resource_main_get): * UIProcess/API/efl/ewk_web_resource.h: Added. * UIProcess/API/efl/ewk_web_resource_private.h: Added. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/PlatformEfl.cmake trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_private.h Added Paths trunk/Source/WebKit2/UIProcess/API/efl/ewk_url_request.cpp trunk/Source/WebKit2/UIProcess/API/efl/ewk_url_request.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_url_request_private.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_resource_load_client.cpp trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_resource_load_client_private.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_web_resource.cpp trunk/Source/WebKit2/UIProcess/API/efl/ewk_web_resource.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_web_resource_private.h Diff Modified: trunk/Source/WebKit2/ChangeLog (121888 => 121889) --- trunk/Source/WebKit2/ChangeLog 2012-07-05 07:58:58 UTC (rev 121888) +++ trunk/Source/WebKit2/ChangeLog 2012-07-05 07:59:25 UTC (rev 121889) @@ -1,3 +1,47 @@ +2012-07-05 Christophe Dumez christophe.du...@intel.com + +[WK2][EFL] Ewk_View needs to report new resource requests +https://bugs.webkit.org/show_bug.cgi?id=90577 + +Reviewed by Kenneth Rohde Christiansen. + +Add new resource,request,new signal to Ewk_View to +notify clients of the resource requests being initiated. +New Ewk_Url_Request and Ewk_Web_Resource types are +introduced in order to provide the clients with the +needed information regarding the resource requests. + +* PlatformEfl.cmake: +* UIProcess/API/efl/EWebKit2.h: +* UIProcess/API/efl/ewk_url_request.cpp: Added. +(_Ewk_Url_Request): +(ewk_url_request_ref): +(ewk_url_request_unref): +(ewk_url_request_url_get): +(ewk_request_first_party_get): +(ewk_url_request_http_method_get): +(ewk_url_request_new): +* UIProcess/API/efl/ewk_url_request.h: Added. +* UIProcess/API/efl/ewk_url_request_private.h: Added. +* UIProcess/API/efl/ewk_view.cpp: +(ewk_view_base_add): +(ewk_view_resource_load_initiated): +* UIProcess/API/efl/ewk_view.h: +* UIProcess/API/efl/ewk_view_private.h: +* UIProcess/API/efl/ewk_view_resource_load_client.cpp: Added. +(didInitiateLoadForResource): +(ewk_view_resource_load_client_attach): +* UIProcess/API/efl/ewk_view_resource_load_client_private.h: Added. +* UIProcess/API/efl/ewk_web_resource.cpp: Added. +(_Ewk_Web_Resource): +(ewk_web_resource_ref): +(ewk_web_resource_unref): +(ewk_web_resource_uri_get): +(ewk_web_resource_new): +(ewk_web_resource_main_get): +* UIProcess/API/efl/ewk_web_resource.h: Added. +* UIProcess/API/efl/ewk_web_resource_private.h: Added. + 2012-07-04 John Mellor joh...@chromium.org Text Autosizing: Add compile flag and runtime setting Modified: trunk/Source/WebKit2/PlatformEfl.cmake (121888 => 121889) --- trunk/Source/WebKit2/PlatformEfl.cmake 2012-07-05 07:58:58 UTC (rev 121888) +++ trunk/Source/WebKit2/PlatformEfl.cmake 2012-07-05 07:59:25 UTC (rev 121889) @@ -34,9 +34,12 @@
[webkit-changes] [121890] trunk
Title: [121890] trunk
Revision 121890
Author commit-qu...@webkit.org
Date 2012-07-05 01:14:58 -0700 (Thu, 05 Jul 2012)
Log Message
[WK2][EFL] Ewk_View needs API to load HTML data
https://bugs.webkit.org/show_bug.cgi?id=90540
Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Add method to Ewk_View to load provided HTML data.
This is used for e.g. when an URL cannot be reached
and we need to display an error page.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_html_load):
* UIProcess/API/efl/ewk_view.h:
Tools:
Update EFL MiniBrowser to catch the load,error signal
on the view and display an error page.
* MiniBrowser/efl/main.c:
(on_error):
(browserCreate):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/efl/main.c
Diff
Modified: trunk/Source/WebKit2/ChangeLog (121889 => 121890)
--- trunk/Source/WebKit2/ChangeLog 2012-07-05 07:59:25 UTC (rev 121889)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-05 08:14:58 UTC (rev 121890)
@@ -1,5 +1,20 @@
2012-07-05 Christophe Dumez christophe.du...@intel.com
+[WK2][EFL] Ewk_View needs API to load HTML data
+https://bugs.webkit.org/show_bug.cgi?id=90540
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add method to Ewk_View to load provided HTML data.
+This is used for e.g. when an URL cannot be reached
+and we need to display an error page.
+
+* UIProcess/API/efl/ewk_view.cpp:
+(ewk_view_html_load):
+* UIProcess/API/efl/ewk_view.h:
+
+2012-07-05 Christophe Dumez christophe.du...@intel.com
+
[WK2][EFL] Ewk_View needs to report new resource requests
https://bugs.webkit.org/show_bug.cgi?id=90577
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (121889 => 121890)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-07-05 07:59:25 UTC (rev 121889)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-07-05 08:14:58 UTC (rev 121890)
@@ -705,7 +705,20 @@
evas_object_smart_callback_call(ewkView, load,error, const_castEwk_Web_Error*(error));
}
+Eina_Bool ewk_view_html_string_load(Evas_Object* ewkView, const char* html, const char* baseUrl, const char* unreachableUrl)
+{
+EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
+EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
+EINA_SAFETY_ON_NULL_RETURN_VAL(html, false);
+if (unreachableUrl *unreachableUrl)
+priv-pageClient-page()-loadAlternateHTMLString(String::fromUTF8(html), baseUrl ? String::fromUTF8(baseUrl) : , String::fromUTF8(unreachableUrl));
+else
+priv-pageClient-page()-loadHTMLString(String::fromUTF8(html), baseUrl ? String::fromUTF8(baseUrl) : );
+
+return true;
+}
+
#if ENABLE(WEB_INTENTS_TAG)
/**
* @internal
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h (121889 => 121890)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-07-05 07:59:25 UTC (rev 121889)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-07-05 08:14:58 UTC (rev 121890)
@@ -283,6 +283,25 @@
*/
EAPI double ewk_view_load_progress_get(const Evas_Object *o);
+/**
+ * Loads the specified @a html string as the content of the view.
+ *
+ * External objects such as stylesheets or images referenced in the HTML
+ * document are located relative to @a baseUrl.
+ *
+ * If an @a unreachableUrl is passed it is used as the url for the loaded
+ * content. This is typically used to display error pages for a failed
+ * load.
+ *
+ * @param o view object to load the HTML into
+ * @param html HTML data to load
+ * @param baseUrl Base URL used for relative paths to external objects (optional)
+ * @param unreachableUrl URL that could not be reached (optional)
+ *
+ * @return @c EINA_TRUE if it the HTML was successfully loaded, @c EINA_FALSE otherwise
+ */
+EAPI Eina_Bool ewk_view_html_string_load(Evas_Object *o, const char *html, const char *baseUrl, const char *unreachableUrl);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Tools/ChangeLog (121889 => 121890)
--- trunk/Tools/ChangeLog 2012-07-05 07:59:25 UTC (rev 121889)
+++ trunk/Tools/ChangeLog 2012-07-05 08:14:58 UTC (rev 121890)
@@ -1,3 +1,17 @@
+2012-07-05 Christophe Dumez christophe.du...@intel.com
+
+[WK2][EFL] Ewk_View needs API to load HTML data
+https://bugs.webkit.org/show_bug.cgi?id=90540
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Update EFL MiniBrowser to catch the load,error signal
+on the view and display an error page.
+
+* MiniBrowser/efl/main.c:
+(on_error):
+(browserCreate):
+
2012-07-05 Sergio Villar Senin svil...@igalia.com
Hidden dirs are not copied when creating the built product archive
Modified: trunk/Tools/MiniBrowser/efl/main.c (121889 => 121890)
---
[webkit-changes] [121891] trunk/Source/WebCore
Title: [121891] trunk/Source/WebCore
Revision 121891
Author commit-qu...@webkit.org
Date 2012-07-05 01:19:51 -0700 (Thu, 05 Jul 2012)
Log Message
Web Inspector: [JSC] support JS execution in the context of an isolated world
https://bugs.webkit.org/show_bug.cgi?id=85709
Patch by Peter Wang peter.w...@torchmobile.com.cn on 2012-07-05
Reviewed by Gavin Barraclough.
No new test case for this bug.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (121890 => 121891)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 08:14:58 UTC (rev 121890)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 08:19:51 UTC (rev 121891)
@@ -1,3 +1,16 @@
+2012-07-05 Peter Wang peter.w...@torchmobile.com.cn
+
+Web Inspector: [JSC] support JS execution in the context of an isolated world
+https://bugs.webkit.org/show_bug.cgi?id=85709
+
+Reviewed by Gavin Barraclough.
+
+No new test case for this bug.
+
+* bindings/js/ScriptController.cpp:
+(WebCore::ScriptController::collectIsolatedContexts):
+(WebCore):
+
2012-07-04 Huang Dongsung luxte...@company100.net
Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
Modified: trunk/Source/WebCore/bindings/js/ScriptController.cpp (121890 => 121891)
--- trunk/Source/WebCore/bindings/js/ScriptController.cpp 2012-07-05 08:14:58 UTC (rev 121890)
+++ trunk/Source/WebCore/bindings/js/ScriptController.cpp 2012-07-05 08:19:51 UTC (rev 121891)
@@ -336,10 +336,15 @@
{
}
-void ScriptController::collectIsolatedContexts(Vectorstd::pairJSC::ExecState*, SecurityOrigin* )
+void ScriptController::collectIsolatedContexts(Vectorstd::pairJSC::ExecState*, SecurityOrigin* result)
{
-// FIXME(85709): support isolated contexts inspection for JSC.
+for (ShellMap::iterator iter = m_windowShells.begin(); iter != m_windowShells.end(); ++iter) {
+JSC::ExecState* exec = iter-second-window()-globalExec();
+SecurityOrigin* origin = iter-second-window()-impl()-securityOrigin();
+result.append(std::pairScriptState*, SecurityOrigin*(exec, origin));
+}
}
+
#endif
#if ENABLE(NETSCAPE_PLUGIN_API)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121892] trunk/Source/WebKit2
Title: [121892] trunk/Source/WebKit2
Revision 121892
Author commit-qu...@webkit.org
Date 2012-07-05 01:36:39 -0700 (Thu, 05 Jul 2012)
Log Message
[EFL][WK2] Add ewk_view_reload_bypass_cache API.
https://bugs.webkit.org/show_bug.cgi?id=89413
Patch by Hyerim Bae hyerim@samsung.com on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Add API, which is for reloading documents without cache.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_reload_bypass_cache):
* UIProcess/API/efl/ewk_view.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (121891 => 121892)
--- trunk/Source/WebKit2/ChangeLog 2012-07-05 08:19:51 UTC (rev 121891)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-05 08:36:39 UTC (rev 121892)
@@ -1,3 +1,16 @@
+2012-07-05 Hyerim Bae hyerim@samsung.com
+
+[EFL][WK2] Add ewk_view_reload_bypass_cache API.
+https://bugs.webkit.org/show_bug.cgi?id=89413
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add API, which is for reloading documents without cache.
+
+* UIProcess/API/efl/ewk_view.cpp:
+(ewk_view_reload_bypass_cache):
+* UIProcess/API/efl/ewk_view.h:
+
2012-07-05 Christophe Dumez christophe.du...@intel.com
[WK2][EFL] Ewk_View needs API to load HTML data
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (121891 => 121892)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-07-05 08:19:51 UTC (rev 121891)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-07-05 08:36:39 UTC (rev 121892)
@@ -540,6 +540,16 @@
return true;
}
+Eina_Bool ewk_view_reload_bypass_cache(Evas_Object* ewkView)
+{
+EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
+EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
+
+WKPageReloadFromOrigin(toAPI(priv-pageClient-page()));
+
+return true;
+}
+
Eina_Bool ewk_view_stop(Evas_Object* ewkView)
{
EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h (121891 => 121892)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-07-05 08:19:51 UTC (rev 121891)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-07-05 08:36:39 UTC (rev 121892)
@@ -198,11 +198,20 @@
*
* @return @c EINA_TRUE on success or @c EINA_FALSE otherwise
*
- * @see ewk_view_reload_full()
+ * @see ewk_view_reload_bypass_cache()
*/
EAPI Eina_Boolewk_view_reload(Evas_Object *o);
/**
+ * Reloads the current page's document without cache.
+ *
+ * @param o view object to reload current document
+ *
+ * @return @c EINA_TRUE on success or @c EINA_FALSE otherwise
+ */
+EAPI Eina_Bool ewk_view_reload_bypass_cache(Evas_Object *o);
+
+/**
* Asks the main frame to stop loading.
*
* @param o view object to stop loading
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121895] trunk/Source/WebCore
Title: [121895] trunk/Source/WebCore
Revision 121895
Author zandober...@gmail.com
Date 2012-07-05 02:34:46 -0700 (Thu, 05 Jul 2012)
Log Message
Add Gamepad logging channel
https://bugs.webkit.org/show_bug.cgi?id=90570
Reviewed by Carlos Garcia Campos.
Add a new logging channel for logging significant
events that are related to Gamepad API implementation.
No new tests - no new testable functionality.
* platform/Logging.cpp:
(WebCore):
(WebCore::getChannelFromName):
* platform/Logging.h:
(WebCore):
* platform/gtk/GamepadsGtk.cpp: Log when a device is
registered or unregistered.
(WebCore::GamepadsGtk::registerDevice):
(WebCore::GamepadsGtk::unregisterDevice):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Logging.cpp
trunk/Source/WebCore/platform/Logging.h
trunk/Source/WebCore/platform/gtk/GamepadsGtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (121894 => 121895)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 09:22:58 UTC (rev 121894)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 09:34:46 UTC (rev 121895)
@@ -1,3 +1,25 @@
+2012-07-05 Zan Dobersek zandober...@gmail.com
+
+Add Gamepad logging channel
+https://bugs.webkit.org/show_bug.cgi?id=90570
+
+Reviewed by Carlos Garcia Campos.
+
+Add a new logging channel for logging significant
+events that are related to Gamepad API implementation.
+
+No new tests - no new testable functionality.
+
+* platform/Logging.cpp:
+(WebCore):
+(WebCore::getChannelFromName):
+* platform/Logging.h:
+(WebCore):
+* platform/gtk/GamepadsGtk.cpp: Log when a device is
+registered or unregistered.
+(WebCore::GamepadsGtk::registerDevice):
+(WebCore::GamepadsGtk::unregisterDevice):
+
2012-07-05 Peter Wang peter.w...@torchmobile.com.cn
Web Inspector: [JSC] support JS execution in the context of an isolated world
Modified: trunk/Source/WebCore/platform/Logging.cpp (121894 => 121895)
--- trunk/Source/WebCore/platform/Logging.cpp 2012-07-05 09:22:58 UTC (rev 121894)
+++ trunk/Source/WebCore/platform/Logging.cpp 2012-07-05 09:34:46 UTC (rev 121895)
@@ -65,6 +65,7 @@
WTFLogChannel LogWebAudio = { 0x2000, WebCoreLogLevel, WTFLogChannelOff };
WTFLogChannel LogCompositing = { 0x4000, WebCoreLogLevel, WTFLogChannelOff };
+WTFLogChannel LogGamepad = { 0x8000, WebCoreLogLevel, WTFLogChannelOff };
WTFLogChannel* getChannelFromName(const String channelName)
@@ -147,6 +148,9 @@
if (equalIgnoringCase(channelName, String(Compositing)))
return LogCompositing;
+if (equalIgnoringCase(channelName, String(Gamepad)))
+return LogGamepad;
+
return 0;
}
Modified: trunk/Source/WebCore/platform/Logging.h (121894 => 121895)
--- trunk/Source/WebCore/platform/Logging.h 2012-07-05 09:22:58 UTC (rev 121894)
+++ trunk/Source/WebCore/platform/Logging.h 2012-07-05 09:34:46 UTC (rev 121895)
@@ -63,6 +63,7 @@
extern WTFLogChannel LogFileAPI;
extern WTFLogChannel LogWebAudio;
extern WTFLogChannel LogCompositing;
+extern WTFLogChannel LogGamepad;
void initializeLoggingChannelsIfNecessary();
WTFLogChannel* getChannelFromName(const String channelName);
Modified: trunk/Source/WebCore/platform/gtk/GamepadsGtk.cpp (121894 => 121895)
--- trunk/Source/WebCore/platform/gtk/GamepadsGtk.cpp 2012-07-05 09:22:58 UTC (rev 121894)
+++ trunk/Source/WebCore/platform/gtk/GamepadsGtk.cpp 2012-07-05 09:34:46 UTC (rev 121895)
@@ -30,12 +30,14 @@
#include GamepadDeviceLinux.h
#include GamepadList.h
+#include Logging.h
#include gio/gunixinputstream.h
#include gudev/gudev.h
#include wtf/HashMap.h
#include wtf/PassOwnPtr.h
#include wtf/gobject/GOwnPtr.h
#include wtf/gobject/GRefPtr.h
+#include wtf/text/CString.h
#include wtf/text/StringHash.h
namespace WebCore {
@@ -138,6 +140,7 @@
void GamepadsGtk::registerDevice(String deviceFile)
{
+LOG(Gamepad, GamepadsGtk::registerDevice %s, deviceFile.ascii().data());
ASSERT(!m_deviceMap.contains(deviceFile));
for (unsigned index = 0; index m_slots.size(); index++) {
@@ -151,6 +154,7 @@
void GamepadsGtk::unregisterDevice(String deviceFile)
{
+LOG(Gamepad, GamepadsGtk::unregisterDevice %s, deviceFile.ascii().data());
ASSERT(m_deviceMap.contains(deviceFile));
GamepadDeviceGtk* gamepadDevice = m_deviceMap.take(deviceFile);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121896] trunk/Source/WebCore
Title: [121896] trunk/Source/WebCore
Revision 121896
Author commit-qu...@webkit.org
Date 2012-07-05 03:33:54 -0700 (Thu, 05 Jul 2012)
Log Message
Web Inspector: Having a Scroll into view for nodes through web inspector.
https://bugs.webkit.org/show_bug.cgi?id=89554
Added options for scrolling-into-view the element node through web
inspector.
Patch by Sam D dsam2...@gmail.com on 2012-07-05
Reviewed by Pavel Feldman.
No new tests. UI change.
* English.lproj/localizedStrings.js:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(.):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.callFunction):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
trunk/Source/WebCore/inspector/front-end/RemoteObject.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (121895 => 121896)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 09:34:46 UTC (rev 121895)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 10:33:54 UTC (rev 121896)
@@ -1,3 +1,22 @@
+2012-07-05 Sam D dsam2...@gmail.com
+
+Web Inspector: Having a Scroll into view for nodes through web inspector.
+https://bugs.webkit.org/show_bug.cgi?id=89554
+
+Added options for scrolling-into-view the element node through web
+inspector.
+
+Reviewed by Pavel Feldman.
+
+No new tests. UI change.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/ElementsTreeOutline.js:
+(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
+(.):
+* inspector/front-end/RemoteObject.js:
+(WebInspector.RemoteObject.prototype.callFunction):
+
2012-07-05 Zan Dobersek zandober...@gmail.com
Add Gamepad logging channel
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (121895 => 121896)
--- trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-07-05 09:34:46 UTC (rev 121895)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-07-05 10:33:54 UTC (rev 121896)
@@ -356,6 +356,8 @@
localizedStrings[Script] = Script;
localizedStrings[Scripting] = Scripting;
localizedStrings[Scripts Panel] = Scripts Panel;
+localizedStrings[Scroll into view] = Scroll into view;
+localizedStrings[Scroll Into View] = Scroll Into View;
localizedStrings[Source Code Panel] = Source Code Panel;
localizedStrings[Scripts] = Scripts;
localizedStrings[Source Code] = Source Code;
Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (121895 => 121896)
--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-07-05 09:34:46 UTC (rev 121895)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-07-05 10:33:54 UTC (rev 121896)
@@ -1162,6 +1162,9 @@
this._populateNodeContextMenu(contextMenu);
this.treeOutline._populateContextMenu(contextMenu, this.representedObject);
+
+contextMenu.appendSeparator();
+contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? Scroll into view : Scroll Into View), this._scrollIntoView.bind(this));
},
_populateForcedPseudoStateItems: function(subMenu)
@@ -1912,6 +1915,22 @@
this._highlightResult = [];
WebInspector.highlightSearchResults(this.listItemElement, matchRanges, this._highlightResult);
+},
+
+_scrollIntoView: function()
+{
+function scrollIntoViewCallback(object)
+{
+function scrollIntoView()
+{
+this.scrollIntoViewIfNeeded(true);
+}
+
+if (object)
+object.callFunction(scrollIntoView);
+}
+
+WebInspector.RemoteObject.resolveNode(this.representedObject, , scrollIntoViewCallback);
}
}
Modified: trunk/Source/WebCore/inspector/front-end/RemoteObject.js (121895 => 121896)
--- trunk/Source/WebCore/inspector/front-end/RemoteObject.js 2012-07-05 09:34:46 UTC (rev 121895)
+++ trunk/Source/WebCore/inspector/front-end/RemoteObject.js 2012-07-05 10:33:54 UTC (rev 121896)
@@ -272,8 +272,8 @@
/**
* @param {function(this:Object)} functionDeclaration
- * @param {Array.RuntimeAgent.CallArgument|undefined} args
- * @param {function(?WebInspector.RemoteObject)} callback
+ * @param {Array.RuntimeAgent.CallArgument=} args
+ * @param {function(?WebInspector.RemoteObject)=} callback
*/
callFunction: function(functionDeclaration, args, callback)
{
@@ -284,6 +284,9 @@
*/
function mycallback(error, result, wasThrown)
{
+if (!callback)
+return;
+
callback((error || wasThrown) ? null : WebInspector.RemoteObject.fromPayload(result));
}
___
webkit-changes mailing list
[webkit-changes] [121897] trunk
Title: [121897] trunk
Revision 121897
Author commit-qu...@webkit.org
Date 2012-07-05 03:52:48 -0700 (Thu, 05 Jul 2012)
Log Message
[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
https://bugs.webkit.org/show_bug.cgi?id=88608
Patch by Dongwoo Im dw...@samsung.com on 2012-07-05
Reviewed by Hajime Morita.
.:
* Source/cmake/OptionsEfl.cmake: Enable the CUSTOM_SCHEME_HANDLER feature as default.
Source/WebKit2:
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::isProtocolHandlerRegistered): Add a stub function.
(WebKit::WebChromeClient::unregisterProtocolHandler): Add a stub function.
(WebChromeClient):
Tools:
* Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.
LayoutTests:
* platform/efl/fast/dom/unregister-protocol-handler-expected.txt: Expected result of the EFL port.
Modified Paths
trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/cmake/OptionsEfl.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
Added Paths
trunk/LayoutTests/platform/efl/fast/dom/unregister-protocol-handler-expected.txt
Diff
Modified: trunk/ChangeLog (121896 => 121897)
--- trunk/ChangeLog 2012-07-05 10:33:54 UTC (rev 121896)
+++ trunk/ChangeLog 2012-07-05 10:52:48 UTC (rev 121897)
@@ -1,3 +1,12 @@
+2012-07-05 Dongwoo Im dw...@samsung.com
+
+[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+https://bugs.webkit.org/show_bug.cgi?id=88608
+
+Reviewed by Hajime Morita.
+
+* Source/cmake/OptionsEfl.cmake: Enable the CUSTOM_SCHEME_HANDLER feature as default.
+
2012-07-05 Ryuan Choi ryuan.c...@samsung.com
[Wk2][EFL] EFL needs a WebKitTestRunner
Modified: trunk/LayoutTests/ChangeLog (121896 => 121897)
--- trunk/LayoutTests/ChangeLog 2012-07-05 10:33:54 UTC (rev 121896)
+++ trunk/LayoutTests/ChangeLog 2012-07-05 10:52:48 UTC (rev 121897)
@@ -1,3 +1,12 @@
+2012-07-05 Dongwoo Im dw...@samsung.com
+
+[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+https://bugs.webkit.org/show_bug.cgi?id=88608
+
+Reviewed by Hajime Morita.
+
+* platform/efl/fast/dom/unregister-protocol-handler-expected.txt: Expected result of the EFL port.
+
2012-07-05 Kristóf Kosztyó kkris...@inf.u-szeged.hu
[Qt] Unreviewed gardening after r121891.
Added: trunk/LayoutTests/platform/efl/fast/dom/unregister-protocol-handler-expected.txt (0 => 121897)
--- trunk/LayoutTests/platform/efl/fast/dom/unregister-protocol-handler-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/dom/unregister-protocol-handler-expected.txt 2012-07-05 10:52:48 UTC (rev 121897)
@@ -0,0 +1,20 @@
+This test makes sure that navigator.unregisterProtocolHandler throws the proper exceptions and has no-op default implementation.
+
+Pass: window.navigator.unregisterProtocolHandler is defined.
+Pass: Invalid protocol http threw SECURITY_ERR exception.
+Pass: Invalid protocol https threw SECURITY_ERR exception.
+Pass: Invalid protocol file threw SECURITY_ERR exception.
+Pass: Valid protocol irc allowed.
+Pass: Valid protocol mailto allowed.
+Pass: Valid protocol mms allowed.
+Pass: Valid protocol news allowed.
+Pass: Valid protocol nntp allowed.
+Pass: Valid protocol sms allowed.
+Pass: Valid protocol smsto allowed.
+Pass: Valid protocol tel allowed.
+Pass: Valid protocol urn allowed.
+Pass: Valid protocol webcal allowed.
+Pass: Invalid url threw SYNTAX_ERR exception.
+Pass: Invalid url %S threw SYNTAX_ERR exception.
+Pass: Valid call succeeded.
+
Modified: trunk/Source/WebKit2/ChangeLog (121896 => 121897)
--- trunk/Source/WebKit2/ChangeLog 2012-07-05 10:33:54 UTC (rev 121896)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-05 10:52:48 UTC (rev 121897)
@@ -1,3 +1,15 @@
+2012-07-05 Dongwoo Im dw...@samsung.com
+
+[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+https://bugs.webkit.org/show_bug.cgi?id=88608
+
+Reviewed by Hajime Morita.
+
+* WebProcess/WebCoreSupport/WebChromeClient.h:
+(WebKit::WebChromeClient::isProtocolHandlerRegistered): Add a stub function.
+(WebKit::WebChromeClient::unregisterProtocolHandler): Add a stub function.
+(WebChromeClient):
+
2012-07-05 Ryuan Choi ryuan.c...@samsung.com
[Wk2][EFL] EFL needs a WebKitTestRunner
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h (121896 => 121897)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2012-07-05 10:33:54 UTC (rev 121896)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2012-07-05 10:52:48 UTC (rev 121897)
@@ -220,6 +220,11 @@
virtual void registerProtocolHandler(const String scheme, const String baseURL, const String url, const String title) OVERRIDE { }
#endif
+#if ENABLE(CUSTOM_SCHEME_HANDLER)
+virtual
[webkit-changes] [121898] trunk/Source/WebKit
Title: [121898] trunk/Source/WebKit Revision 121898 Author commit-qu...@webkit.org Date 2012-07-05 03:54:01 -0700 (Thu, 05 Jul 2012) Log Message [EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl. https://bugs.webkit.org/show_bug.cgi?id=90542 Patch by Kihong Kwon kihong.k...@samsung.com on 2012-07-05 Reviewed by Kenneth Rohde Christiansen. Source/WebKit: NotificationClientEfl.cpp is changed to NotificationPresenterClientEfl.cpp to be in line with other ports(qt, chromium, gtk). * PlatformEfl.cmake: Source/WebKit/efl: Change class name from NotificationClientEfl to NotificationPresenterClientEfl to be in line with other ports.(qt, chromium, blackberry) * WebCoreSupport/ChromeClientEfl.cpp: * WebCoreSupport/NotificationPresenterClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp. (WebCore): (WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl): (WebCore::NotificationPresenterClientEfl::~NotificationPresenterClientEfl): (WebCore::NotificationPresenterClientEfl::show): (WebCore::NotificationPresenterClientEfl::cancel): (WebCore::NotificationPresenterClientEfl::notificationObjectDestroyed): (WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed): (WebCore::NotificationPresenterClientEfl::requestPermission): (WebCore::NotificationPresenterClientEfl::checkPermission): (WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission): * WebCoreSupport/NotificationPresenterClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h. (WebCore): (NotificationPresenterClientEfl): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/PlatformEfl.cmake trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp Added Paths trunk/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h Removed Paths trunk/Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h Diff Modified: trunk/Source/WebKit/ChangeLog (121897 => 121898) --- trunk/Source/WebKit/ChangeLog 2012-07-05 10:52:48 UTC (rev 121897) +++ trunk/Source/WebKit/ChangeLog 2012-07-05 10:54:01 UTC (rev 121898) @@ -1,3 +1,15 @@ +2012-07-05 Kihong Kwon kihong.k...@samsung.com + +[EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl. +https://bugs.webkit.org/show_bug.cgi?id=90542 + +Reviewed by Kenneth Rohde Christiansen. + +NotificationClientEfl.cpp is changed to NotificationPresenterClientEfl.cpp +to be in line with other ports(qt, chromium, gtk). + +* PlatformEfl.cmake: + 2012-07-04 Tor Arne Vestbø tor.arne.ves...@nokia.com [Qt] Remove a few un-needed load(features) after r121777 Modified: trunk/Source/WebKit/PlatformEfl.cmake (121897 => 121898) --- trunk/Source/WebKit/PlatformEfl.cmake 2012-07-05 10:52:48 UTC (rev 121897) +++ trunk/Source/WebKit/PlatformEfl.cmake 2012-07-05 10:54:01 UTC (rev 121898) @@ -103,7 +103,7 @@ efl/WebCoreSupport/IconDatabaseClientEfl.cpp efl/WebCoreSupport/StorageTrackerClientEfl.cpp efl/WebCoreSupport/InspectorClientEfl.cpp -efl/WebCoreSupport/NotificationClientEfl.cpp +efl/WebCoreSupport/NotificationPresenterClientEfl.cpp efl/WebCoreSupport/PageClientEfl.cpp efl/WebCoreSupport/PlatformStrategiesEfl.cpp Modified: trunk/Source/WebKit/efl/ChangeLog (121897 => 121898) --- trunk/Source/WebKit/efl/ChangeLog 2012-07-05 10:52:48 UTC (rev 121897) +++ trunk/Source/WebKit/efl/ChangeLog 2012-07-05 10:54:01 UTC (rev 121898) @@ -1,3 +1,29 @@ +2012-07-05 Kihong Kwon kihong.k...@samsung.com + +[EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl. +https://bugs.webkit.org/show_bug.cgi?id=90542 + +Reviewed by Kenneth Rohde Christiansen. + +Change class name from NotificationClientEfl to NotificationPresenterClientEfl +to be in line with other ports.(qt, chromium, blackberry) + +* WebCoreSupport/ChromeClientEfl.cpp: +* WebCoreSupport/NotificationPresenterClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp. +(WebCore): +(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl): +(WebCore::NotificationPresenterClientEfl::~NotificationPresenterClientEfl): +(WebCore::NotificationPresenterClientEfl::show): +(WebCore::NotificationPresenterClientEfl::cancel): +(WebCore::NotificationPresenterClientEfl::notificationObjectDestroyed): +(WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed): +(WebCore::NotificationPresenterClientEfl::requestPermission): +(WebCore::NotificationPresenterClientEfl::checkPermission): +
[webkit-changes] [121899] trunk/Source/WebKit2
Title: [121899] trunk/Source/WebKit2
Revision 121899
Author kbal...@webkit.org
Date 2012-07-05 04:21:47 -0700 (Thu, 05 Jul 2012)
Log Message
[Qt] WTR crashes if a URL is passed as a parameter
https://bugs.webkit.org/show_bug.cgi?id=88093
Reviewed by Zoltan Herczeg.
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedURLAPI):
Don't special case null string. It's handled
fine by WebURL and passing 0 is not suitable
to the API.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (121898 => 121899)
--- trunk/Source/WebKit2/ChangeLog 2012-07-05 10:54:01 UTC (rev 121898)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-05 11:21:47 UTC (rev 121899)
@@ -1,3 +1,16 @@
+2012-07-05 Balazs Kelemen kbal...@webkit.org
+
+[Qt] WTR crashes if a URL is passed as a parameter
+https://bugs.webkit.org/show_bug.cgi?id=88093
+
+Reviewed by Zoltan Herczeg.
+
+* Shared/API/c/WKSharedAPICast.h:
+(WebKit::toCopiedURLAPI):
+Don't special case null string. It's handled
+fine by WebURL and passing 0 is not suitable
+to the API.
+
2012-07-05 Dongwoo Im dw...@samsung.com
[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
Modified: trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h (121898 => 121899)
--- trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h 2012-07-05 10:54:01 UTC (rev 121898)
+++ trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h 2012-07-05 11:21:47 UTC (rev 121899)
@@ -159,8 +159,6 @@
inline WKURLRef toCopiedURLAPI(const String string)
{
-if (!string)
-return 0;
RefPtrWebURL webURL = WebURL::create(string);
return toAPI(webURL.release().leakRef());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121900] trunk/Source/WebCore
Title: [121900] trunk/Source/WebCore Revision 121900 Author rga...@webkit.org Date 2012-07-05 05:31:56 -0700 (Thu, 05 Jul 2012) Log Message NEON intrinsics should be used with gaussian blur filter https://bugs.webkit.org/show_bug.cgi?id=90166 Reviewed by Zoltan Herczeg. Rewrite inline assembly to NEON intrinsics for better portabilty and readibility. Remove unnecessary FEGaussianBlurNEON.cpp and add NEONHelpers.h to the project which will contains the shared NEON code of the filters. Existing tests cover this issue. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplyGeneric): (WebCore::FEGaussianBlur::platformApplyWorker): * platform/graphics/filters/FEGaussianBlur.h: (FEGaussianBlur): * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Removed. * platform/graphics/filters/arm/FEGaussianBlurNEON.h: (WebCore::boxBlurNEON): * platform/graphics/filters/arm/NEONHelpers.h: Added. (WebCore): (WebCore::loadRGBA8AsFloat): (WebCore::storeFloatAsRGBA8): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h Added Paths trunk/Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h Removed Paths trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (121899 => 121900) --- trunk/Source/WebCore/CMakeLists.txt 2012-07-05 11:21:47 UTC (rev 121899) +++ trunk/Source/WebCore/CMakeLists.txt 2012-07-05 12:31:56 UTC (rev 121900) @@ -1239,8 +1239,8 @@ platform/graphics/filters/SourceAlpha.cpp platform/graphics/filters/SourceGraphic.cpp +platform/graphics/filters/arm/NEONHelpers.h platform/graphics/filters/arm/FECompositeArithmeticNEON.h -platform/graphics/filters/arm/FEGaussianBlurNEON.cpp platform/graphics/filters/arm/FEGaussianBlurNEON.h platform/graphics/filters/arm/FELightingNEON.cpp platform/graphics/filters/arm/FELightingNEON.h Modified: trunk/Source/WebCore/ChangeLog (121899 => 121900) --- trunk/Source/WebCore/ChangeLog 2012-07-05 11:21:47 UTC (rev 121899) +++ trunk/Source/WebCore/ChangeLog 2012-07-05 12:31:56 UTC (rev 121900) @@ -1,3 +1,36 @@ +2012-07-05 Gabor Rapcsanyi rga...@webkit.org + +NEON intrinsics should be used with gaussian blur filter +https://bugs.webkit.org/show_bug.cgi?id=90166 + +Reviewed by Zoltan Herczeg. + +Rewrite inline assembly to NEON intrinsics for better portabilty +and readibility. Remove unnecessary FEGaussianBlurNEON.cpp and add +NEONHelpers.h to the project which will contains the shared +NEON code of the filters. + +Existing tests cover this issue. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* platform/graphics/filters/FEGaussianBlur.cpp: +(WebCore::FEGaussianBlur::platformApplyGeneric): +(WebCore::FEGaussianBlur::platformApplyWorker): +* platform/graphics/filters/FEGaussianBlur.h: +(FEGaussianBlur): +* platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Removed. +* platform/graphics/filters/arm/FEGaussianBlurNEON.h: +(WebCore::boxBlurNEON): +* platform/graphics/filters/arm/NEONHelpers.h: Added. +(WebCore): +(WebCore::loadRGBA8AsFloat): +(WebCore::storeFloatAsRGBA8): + 2012-07-05 Sam D dsam2...@gmail.com Web Inspector: Having a Scroll into view for nodes through web inspector. Modified: trunk/Source/WebCore/GNUmakefile.list.am (121899 => 121900) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-07-05 11:21:47 UTC (rev 121899) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-07-05 12:31:56 UTC (rev 121900) @@ -3284,8 +3284,8 @@ Source/WebCore/platform/graphics/filters/SourceGraphic.h \ Source/WebCore/platform/graphics/filters/SpotLightSource.cpp \ Source/WebCore/platform/graphics/filters/SpotLightSource.h \ + Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h \ Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h \ - Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.cpp \ Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h \ Source/WebCore/platform/graphics/filters/arm/FELightingNEON.cpp \
[webkit-changes] [121901] trunk/Tools
Title: [121901] trunk/Tools
Revision 121901
Author ves...@webkit.org
Date 2012-07-05 06:10:04 -0700 (Thu, 05 Jul 2012)
Log Message
[Qt] Remove rpath-hacks in qt_webkit.pri
Having it in qt_webkit.pri meant that all client apps would inherit the rpath,
even if they were not using QtWebKit.
This is a regression for people who build client apps against a non-installed
QtWebKit, as the client app will be missing a rpath to the standalone WebKit
build dir. This can be solved by LD_LIBRARY_PATH or custom QMAKE_RPATHDIR
logic, until the real issue is fixed in Qt.
Reviewed by Csaba Osztrogonác.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/rpath.prf
trunk/Tools/qmake/qt_webkit.pri
Diff
Modified: trunk/Tools/ChangeLog (121900 => 121901)
--- trunk/Tools/ChangeLog 2012-07-05 12:31:56 UTC (rev 121900)
+++ trunk/Tools/ChangeLog 2012-07-05 13:10:04 UTC (rev 121901)
@@ -1,3 +1,20 @@
+2012-07-05 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Remove rpath-hacks in qt_webkit.pri
+
+Having it in qt_webkit.pri meant that all client apps would inherit the rpath,
+even if they were not using QtWebKit.
+
+This is a regression for people who build client apps against a non-installed
+QtWebKit, as the client app will be missing a rpath to the standalone WebKit
+build dir. This can be solved by LD_LIBRARY_PATH or custom QMAKE_RPATHDIR
+logic, until the real issue is fixed in Qt.
+
+Reviewed by Csaba Osztrogonác.
+
+* qmake/mkspecs/features/rpath.prf:
+* qmake/qt_webkit.pri:
+
2012-07-05 Dongwoo Im dw...@samsung.com
[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
Modified: trunk/Tools/qmake/mkspecs/features/rpath.prf (121900 => 121901)
--- trunk/Tools/qmake/mkspecs/features/rpath.prf 2012-07-05 12:31:56 UTC (rev 121900)
+++ trunk/Tools/qmake/mkspecs/features/rpath.prf 2012-07-05 13:10:04 UTC (rev 121901)
@@ -1,23 +1,25 @@
# ---
# Set rpath for the application/library we're building
#
-# Only used by Qt4.
-#
# See 'Tools/qmake/README' for an overview of the build system
# ---
-haveQt(4) {
-equals(ROOT_BUILD_DIR, $$dirname(DESTDIR)): RPATHDIR_RELATIVE_TO_DESTDIR = ../lib
+equals(ROOT_BUILD_DIR, $$dirname(DESTDIR)): RPATHDIR_RELATIVE_TO_DESTDIR = ../lib
-linux-*:!isEmpty(RPATHDIR_RELATIVE_TO_DESTDIR) {
-# Do the rpath by hand since it's not possible to use ORIGIN in QMAKE_RPATHDIR
-# this expands to $ORIGIN (after qmake and make), it does NOT read a qmake var.
-QMAKE_RPATHDIR = \$\$ORIGIN/$${RPATHDIR_RELATIVE_TO_DESTDIR} $${QMAKE_RPATHDIR}
-RPATH = $$join(QMAKE_RPATHDIR, :)
+linux-*:!isEmpty(RPATHDIR_RELATIVE_TO_DESTDIR) {
+# Do the rpath by hand since it's not possible to use ORIGIN in QMAKE_RPATHDIR
+# this expands to $ORIGIN (after qmake and make), it does NOT read a qmake var.
+QMAKE_RPATHDIR = \$\$ORIGIN/$${RPATHDIR_RELATIVE_TO_DESTDIR} $${QMAKE_RPATHDIR}
+RPATH = $$join(QMAKE_RPATHDIR, :)
-QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${RPATH}\'
-QMAKE_RPATHDIR =
-} else {
-QMAKE_RPATHDIR = $${ROOT_BUILD_DIR}/lib $${QMAKE_RPATHDIR}
-}
+QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${RPATH}\'
+QMAKE_RPATHDIR =
+} else {
+QMAKE_RPATHDIR = $${ROOT_BUILD_DIR}/lib $${QMAKE_RPATHDIR}
}
+
+# FIXME: For Qt5 this will only give correct rpath for the tools that come with WebKit
+# Any client application built against a developer-build of Qt + WebKit (that does
+# QT += webkit) will not get the rpath pointing to the stand-alone WebKit-build,
+# and will have to set LD_LIBRARY_PATH or do their own rpath logic. This needs
+# to be fixed on the Qt side.
Modified: trunk/Tools/qmake/qt_webkit.pri (121900 => 121901)
--- trunk/Tools/qmake/qt_webkit.pri 2012-07-05 12:31:56 UTC (rev 121900)
+++ trunk/Tools/qmake/qt_webkit.pri 2012-07-05 13:10:04 UTC (rev 121901)
@@ -27,15 +27,3 @@
QT_WEBKIT_MAJOR_VERSION = $$QT.webkit.MAJOR_VERSION
QT_WEBKIT_MINOR_VERSION = $$QT.webkit.MINOR_VERSION
QT_WEBKIT_PATCH_VERSION = $$QT.webkit.PATCH_VERSION
-
-unix:!mac {
-!isEmpty(QT_MODULE_LIB_BASE):!equals(QT_MODULE_LIB_BASE, $$[QT_INSTALL_LIBS]) {
-# We are loading the qt_webkit.pri forwarding file from the
-# local webkit build directory, so set up rpath to point to
-# to the local build. This ensures that any of the WebKit tools
-# such as WebKitTestRunner and QtTestBrowser will link to the
-# non-installed QtWebKit library. The same applies to third-
-# party applications that set QMAKE_EXTRA_MODULE_FORWARDS.
-QMAKE_LFLAGS *= $${QMAKE_LFLAGS_RPATH}$${QT_MODULE_LIB_BASE}
-}
-}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [121902] trunk/Source/WebCore
Title: [121902] trunk/Source/WebCore
Revision 121902
Author commit-qu...@webkit.org
Date 2012-07-05 07:19:54 -0700 (Thu, 05 Jul 2012)
Log Message
Web Inspector: Add support for keyboard increment / decrement on numbers in attributes in Elements Panel
https://bugs.webkit.org/show_bug.cgi?id=89586
Patch by Vivek Galatage vivekgalat...@gmail.com on 2012-07-05
Reviewed by Pavel Feldman
Refactoring the key events while editing style property values. Migrated the code to UIUtils.js and referred
from StylesSidebarPane.js, ElementsTreeOutline.js and MetricsSidebarPane.js.
No new tests as code refactoring and UI feature added to ElementsTreeOutline.js
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute.handleKeyDownEvents):
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown.finishHandler):
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown.customNumberHandler):
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._handleNameOrValueUpDown.finishHandler):
(WebInspector.StylesSidebarPane.prototype._handleNameOrValueUpDown):
* inspector/front-end/UIUtils.js:
(WebInspector._modifiedHexValue):
(WebInspector._modifiedFloatNumber):
(WebInspector.handleElementValueModifications):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
trunk/Source/WebCore/inspector/front-end/MetricsSidebarPane.js
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
trunk/Source/WebCore/inspector/front-end/UIUtils.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (121901 => 121902)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 13:10:04 UTC (rev 121901)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 14:19:54 UTC (rev 121902)
@@ -1,3 +1,30 @@
+2012-07-05 Vivek Galatage vivekgalat...@gmail.com
+
+Web Inspector: Add support for keyboard increment / decrement on numbers in attributes in Elements Panel
+https://bugs.webkit.org/show_bug.cgi?id=89586
+
+Reviewed by Pavel Feldman
+
+Refactoring the key events while editing style property values. Migrated the code to UIUtils.js and referred
+from StylesSidebarPane.js, ElementsTreeOutline.js and MetricsSidebarPane.js.
+
+No new tests as code refactoring and UI feature added to ElementsTreeOutline.js
+
+* inspector/front-end/ElementsTreeOutline.js:
+(WebInspector.ElementsTreeElement.prototype._startEditingAttribute.handleKeyDownEvents):
+(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
+* inspector/front-end/MetricsSidebarPane.js:
+(WebInspector.MetricsSidebarPane.prototype._handleKeyDown.finishHandler):
+(WebInspector.MetricsSidebarPane.prototype._handleKeyDown.customNumberHandler):
+(WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
+* inspector/front-end/StylesSidebarPane.js:
+(WebInspector.StylesSidebarPane.prototype._handleNameOrValueUpDown.finishHandler):
+(WebInspector.StylesSidebarPane.prototype._handleNameOrValueUpDown):
+* inspector/front-end/UIUtils.js:
+(WebInspector._modifiedHexValue):
+(WebInspector._modifiedFloatNumber):
+(WebInspector.handleElementValueModifications):
+
2012-07-05 Gabor Rapcsanyi rga...@webkit.org
NEON intrinsics should be used with gaussian blur filter
Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (121901 => 121902)
--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-07-05 13:10:04 UTC (rev 121901)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-07-05 14:19:54 UTC (rev 121902)
@@ -1277,6 +1277,26 @@
removeZeroWidthSpaceRecursive(attribute);
var config = new WebInspector.EditingConfig(this._attributeEditingCommitted.bind(this), this._editingCancelled.bind(this), attributeName);
+
+function handleKeyDownEvents(event)
+{
+var isMetaOrCtrl = WebInspector.isMac() ?
+event.metaKey !event.shiftKey !event.ctrlKey !event.altKey :
+event.ctrlKey !event.shiftKey !event.metaKey !event.altKey;
+if (isEnterKey(event) (event.isMetaOrCtrlForTest || !config.multiline || isMetaOrCtrl))
+return commit;
+else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Esc.code || event.keyIdentifier === U+001B)
+return cancel;
+else if (event.keyIdentifier === U+0009) // Tab key
+return move- + (event.shiftKey ? backward : forward);
+else {
+WebInspector.handleElementValueModifications(event, attribute);
+return ;
+}
+
[webkit-changes] [121905] trunk/Source/WebCore
Title: [121905] trunk/Source/WebCore
Revision 121905
Author ca...@chromium.org
Date 2012-07-05 08:17:43 -0700 (Thu, 05 Jul 2012)
Log Message
Web Inspector: incorrect height of main timeline pane after switching to memory mode
https://bugs.webkit.org/show_bug.cgi?id=90387
Reviewed by Pavel Feldman.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._splitterDragging):
(WebInspector.TimelinePanel.prototype.set _setSplitterPosition):
(WebInspector.TimelinePanel.prototype._overviewModeChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (121904 => 121905)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 14:23:45 UTC (rev 121904)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 15:17:43 UTC (rev 121905)
@@ -1,3 +1,15 @@
+2012-07-04 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: incorrect height of main timeline pane after switching to memory mode
+https://bugs.webkit.org/show_bug.cgi?id=90387
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelinePanel.prototype._splitterDragging):
+(WebInspector.TimelinePanel.prototype.set _setSplitterPosition):
+(WebInspector.TimelinePanel.prototype._overviewModeChanged):
+
2012-07-05 Vivek Galatage vivekgalat...@gmail.com
Web Inspector: Add support for keyboard increment / decrement on numbers in attributes in Elements Panel
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (121904 => 121905)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-07-05 14:23:45 UTC (rev 121904)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-07-05 15:17:43 UTC (rev 121905)
@@ -157,7 +157,6 @@
var top = event.pageY + this._dragOffset
this._setSplitterPosition(top);
event.preventDefault();
-this._refresh();
},
/**
@@ -181,6 +180,7 @@
this._timelineMemorySplitter.style.top = (top - 2) + px;
this._memoryStatistics.setTopPosition(top);
this._containerElementHeight = this._containerElement.clientHeight;
+this.onResize();
},
get calculator()
@@ -437,13 +437,13 @@
this._memoryStatistics.hide();
this.splitView.element.style.height = auto;
this.splitView.element.style.bottom = 0;
+this.onResize();
} else {
this._timelineMemorySplitter.removeStyleClass(hidden);
this._memoryStatistics.show();
this.splitView.element.style.bottom = auto;
this._setSplitterPosition(WebInspector.settings.memoryCounterGraphsHeight.get());
}
-this._refresh();
},
_toggleTimelineButtonClicked: function()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121906] trunk/Source/WebCore
Title: [121906] trunk/Source/WebCore
Revision 121906
Author ca...@chromium.org
Date 2012-07-05 08:27:26 -0700 (Thu, 05 Jul 2012)
Log Message
Web Inspector: timeline events in the vicinity of event dividers some times are tricky to expand
https://bugs.webkit.org/show_bug.cgi?id=90572
Reviewed by Pavel Feldman.
- do not use resources-event-divider-padding;
- make dividers larger and use border-color to visualize them;
- move resources-color-divider to timelinePanel.css, as they're not used outside of timeline;
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.createEventDivider):
* inspector/front-end/inspectorCommon.css:
* inspector/front-end/timelinePanel.css:
(.timeline .resources-event-divider):
(.resources-red-divider):
(.resources-blue-divider):
(.resources-orange-divider):
(.resources-divider.last):
(.timeline .resources-event-divider.timeline-frame-divider):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
trunk/Source/WebCore/inspector/front-end/inspectorCommon.css
trunk/Source/WebCore/inspector/front-end/timelinePanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (121905 => 121906)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 15:17:43 UTC (rev 121905)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 15:27:26 UTC (rev 121906)
@@ -1,5 +1,27 @@
2012-07-04 Andrey Kosyakov ca...@chromium.org
+Web Inspector: timeline events in the vicinity of event dividers some times are tricky to expand
+https://bugs.webkit.org/show_bug.cgi?id=90572
+
+Reviewed by Pavel Feldman.
+
+- do not use resources-event-divider-padding;
+- make dividers larger and use border-color to visualize them;
+- move resources-color-divider to timelinePanel.css, as they're not used outside of timeline;
+
+* inspector/front-end/TimelinePresentationModel.js:
+(WebInspector.TimelinePresentationModel.createEventDivider):
+* inspector/front-end/inspectorCommon.css:
+* inspector/front-end/timelinePanel.css:
+(.timeline .resources-event-divider):
+(.resources-red-divider):
+(.resources-blue-divider):
+(.resources-orange-divider):
+(.resources-divider.last):
+(.timeline .resources-event-divider.timeline-frame-divider):
+
+2012-07-04 Andrey Kosyakov ca...@chromium.org
+
Web Inspector: incorrect height of main timeline pane after switching to memory mode
https://bugs.webkit.org/show_bug.cgi?id=90387
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js (121905 => 121906)
--- trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js 2012-07-05 15:17:43 UTC (rev 121905)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js 2012-07-05 15:27:26 UTC (rev 121906)
@@ -147,9 +147,6 @@
eventDivider.className = resources-event-divider;
var recordTypes = WebInspector.TimelineModel.RecordType;
-var eventDividerPadding = document.createElement(div);
-eventDividerPadding.className = resources-event-divider-padding;
-
if (recordType === recordTypes.MarkDOMContent)
eventDivider.className += resources-blue-divider;
else if (recordType === recordTypes.MarkLoad)
@@ -160,10 +157,9 @@
eventDivider.className += timeline-frame-divider;
if (title)
-eventDividerPadding.title = title;
+eventDivider.title = title;
-eventDividerPadding.appendChild(eventDivider);
-return eventDividerPadding;
+return eventDivider;
}
WebInspector.TimelinePresentationModel.prototype = {
Modified: trunk/Source/WebCore/inspector/front-end/inspectorCommon.css (121905 => 121906)
--- trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2012-07-05 15:17:43 UTC (rev 121905)
+++ trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2012-07-05 15:27:26 UTC (rev 121906)
@@ -115,22 +115,6 @@
z-index: 300;
}
-.resources-red-divider {
-background-color: rgba(255, 0, 0, 0.5);
-}
-
-.resources-blue-divider {
-background-color: rgba(0, 0, 255, 0.5);
-}
-
-.resources-orange-divider {
-background-color: rgba(255, 178, 23, 0.5);
-}
-
-.resources-divider.last {
-background-color: transparent;
-}
-
.resources-divider-label {
position: absolute;
top: 4px;
Modified: trunk/Source/WebCore/inspector/front-end/timelinePanel.css (121905 => 121906)
--- trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2012-07-05 15:17:43 UTC (rev 121905)
+++ trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2012-07-05 15:27:26 UTC (rev 121906)
@@ -572,9 +572,29 @@
.timeline .resources-event-divider {
height: 19px;
+width: 8px;
+border-left-width: 2px;
+border-left-style: solid;
bottom: auto;
+pointer-events: auto;
}
+.resources-red-divider {
+border-color: rgba(255, 0, 0, 0.5);
+}
+
[webkit-changes] [121907] trunk
Title: [121907] trunk
Revision 121907
Author commit-qu...@webkit.org
Date 2012-07-05 08:38:10 -0700 (Thu, 05 Jul 2012)
Log Message
Text Autosizing: Add test framework and simple test.
https://bugs.webkit.org/show_bug.cgi?id=90561
Source/WebCore:
Exposes methods allowing Layout Tests to enable Text Autosizing and
get the same results as if they were running on a mobile device.
Patch by John Mellor joh...@chromium.org on 2012-07-05
Reviewed by Adam Barth.
Test: fast/text-autosizing/simple-paragraph.html
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore):
(WebCore::Settings::setTextAutosizingWindowSizeOverride):
* page/Settings.h:
(Settings):
(WebCore::Settings::textAutosizingWindowSizeOverride):
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::boostSubtree):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setTextAutosizingEnabled):
(WebCore):
(WebCore::InternalSettings::setTextAutosizingWindowSizeOverride):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:
Source/WebKit/chromium:
ENABLE(TEXT_AUTOSIZING) is now on in Chromium (but disabled at runtime).
This allows it to be used in Layout Tests (and in future by Web
Inspector's mobile device emulation).
Patch by John Mellor joh...@chromium.org on 2012-07-05
Reviewed by Adam Barth.
* features.gypi:
LayoutTests:
Added a RefTest checking that Text Autosizing is active.
Skipped the text-autosizing test directory on platforms that
currently disable ENABLE(TEXT_AUTOSIZING).
Patch by John Mellor joh...@chromium.org on 2012-07-05
Reviewed by Adam Barth.
* fast/text-autosizing/simple-paragraph-expected.html: Added.
* fast/text-autosizing/simple-paragraph.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/rendering/TextAutosizer.cpp
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
Added Paths
trunk/LayoutTests/fast/text-autosizing/
trunk/LayoutTests/fast/text-autosizing/simple-paragraph-expected.html
trunk/LayoutTests/fast/text-autosizing/simple-paragraph.html
Diff
Modified: trunk/LayoutTests/ChangeLog (121906 => 121907)
--- trunk/LayoutTests/ChangeLog 2012-07-05 15:27:26 UTC (rev 121906)
+++ trunk/LayoutTests/ChangeLog 2012-07-05 15:38:10 UTC (rev 121907)
@@ -1,3 +1,24 @@
+2012-07-05 John Mellor joh...@chromium.org
+
+Text Autosizing: Add test framework and simple test.
+https://bugs.webkit.org/show_bug.cgi?id=90561
+
+Added a RefTest checking that Text Autosizing is active.
+Skipped the text-autosizing test directory on platforms that
+currently disable ENABLE(TEXT_AUTOSIZING).
+
+Reviewed by Adam Barth.
+
+* fast/text-autosizing/simple-paragraph-expected.html: Added.
+* fast/text-autosizing/simple-paragraph.html: Added.
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/qt/TestExpectations:
+* platform/win/Skipped:
+* platform/wincairo/Skipped:
+* platform/wk2/Skipped:
+
2012-07-05 Dongwoo Im dw...@samsung.com
[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
Added: trunk/LayoutTests/fast/text-autosizing/simple-paragraph-expected.html (0 => 121907)
--- trunk/LayoutTests/fast/text-autosizing/simple-paragraph-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text-autosizing/simple-paragraph-expected.html 2012-07-05 15:38:10 UTC (rev 121907)
@@ -0,0 +1,16 @@
+html
+head
+
+meta name=viewport content=width=800
+style type=text/css
+body { width: 800px; margin: 0; }
+/style
+
+/head
+body
+
+!-- The font-size change is intentional; the line-height change is a known FIXME; the margin-top change is a bug --
+p style=font-size: 2.5rem; line-height: 0.6; margin-top: 0.8remLorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur sapien sapien, tempus id egestas a, consectetur et felis. Ut pharetra mi eget lectus laoreet rutrum. Mauris tellus odio, egestas vitae sodales in, vehicula eget ante. Pellentesque id egestas arcu. Quisque tellus
[webkit-changes] [121908] trunk/Source/WebCore
Title: [121908] trunk/Source/WebCore
Revision 121908
Author ca...@chromium.org
Date 2012-07-05 09:13:48 -0700 (Thu, 05 Jul 2012)
Log Message
Web Inspector: added low-level instrumentation support for TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90264
Patch by Sergey Rogulenko rogule...@google.com on 2012-07-05
Reviewed by Pavel Feldman.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::timelineAgentForOrphanEvents):
(WebCore::InspectorInstrumentation::setTimelineAgentForOrphanEvents):
(WebCore::InspectorInstrumentation::threadSpecificTimelineAgentForOrphanEvents):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (121907 => 121908)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 15:38:10 UTC (rev 121907)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 16:13:48 UTC (rev 121908)
@@ -1,3 +1,23 @@
+2012-07-05 Sergey Rogulenko rogule...@google.com
+
+Web Inspector: added low-level instrumentation support for TimelineAgent
+https://bugs.webkit.org/show_bug.cgi?id=90264
+
+Reviewed by Pavel Feldman.
+
+* inspector/InspectorInstrumentation.cpp:
+(WebCore::InspectorInstrumentation::timelineAgentForOrphanEvents):
+(WebCore::InspectorInstrumentation::setTimelineAgentForOrphanEvents):
+(WebCore::InspectorInstrumentation::threadSpecificTimelineAgentForOrphanEvents):
+* inspector/InspectorInstrumentation.h:
+(InspectorInstrumentation):
+* inspector/InspectorTimelineAgent.cpp:
+(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
+(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
+(WebCore::InspectorTimelineAgent::pushCurrentRecord):
+* inspector/InspectorTimelineAgent.h:
+(InspectorTimelineAgent):
+
2012-07-05 John Mellor joh...@chromium.org
Text Autosizing: Add test framework and simple test.
Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (121907 => 121908)
--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2012-07-05 15:38:10 UTC (rev 121907)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2012-07-05 16:13:48 UTC (rev 121908)
@@ -68,6 +68,7 @@
#include WorkerThread.h
#include XMLHttpRequest.h
#include wtf/StdLibExtras.h
+#include wtf/ThreadSpecific.h
#include wtf/text/CString.h
namespace WebCore {
@@ -1136,6 +1137,22 @@
timelineAgent-didFireAnimationFrame();
}
+InspectorTimelineAgent* InspectorInstrumentation::timelineAgentForOrphanEvents()
+{
+return *threadSpecificTimelineAgentForOrphanEvents();
+}
+
+void InspectorInstrumentation::setTimelineAgentForOrphanEvents(InspectorTimelineAgent* inspectorTimelineAgent)
+{
+*threadSpecificTimelineAgentForOrphanEvents() = inspectorTimelineAgent;
+}
+
+WTF::ThreadSpecificInspectorTimelineAgent* InspectorInstrumentation::threadSpecificTimelineAgentForOrphanEvents()
+{
+AtomicallyInitializedStatic(WTF::ThreadSpecificInspectorTimelineAgent**, instance = new WTF::ThreadSpecificInspectorTimelineAgent*());
+return *instance;
+}
+
InspectorTimelineAgent* InspectorInstrumentation::retrieveTimelineAgent(const InspectorInstrumentationCookie cookie)
{
if (!cookie.first)
Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (121907 => 121908)
--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2012-07-05 15:38:10 UTC (rev 121907)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2012-07-05 16:13:48 UTC (rev 121908)
@@ -252,6 +252,8 @@
static bool hasFrontends() { return s_frontendCounter; }
static bool hasFrontendForScriptContext(ScriptExecutionContext*);
static bool collectingHTMLParseErrors(Page*);
+static InspectorTimelineAgent* timelineAgentForOrphanEvents();
+static void setTimelineAgentForOrphanEvents(InspectorTimelineAgent*);
#else
static bool hasFrontends() { return false; }
static bool hasFrontendForScriptContext(ScriptExecutionContext*) { return false; }
@@ -260,6 +262,8 @@
private:
#if ENABLE(INSPECTOR)
+static WTF::ThreadSpecificInspectorTimelineAgent* threadSpecificTimelineAgentForOrphanEvents();
+
static void didClearWindowObjectInWorldImpl(InstrumentingAgents*, Frame*, DOMWrapperWorld*);
static bool isDebuggerPausedImpl(InstrumentingAgents*);
Modified:
[webkit-changes] [121909] trunk
Title: [121909] trunk
Revision 121909
Author sch...@chromium.org
Date 2012-07-05 09:21:43 -0700 (Thu, 05 Jul 2012)
Log Message
[Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=90391
Source/WebKit/chromium:
WebViewImpl::handleInputEvent was keeping a pointer to an input event that would
later be accessed. When in pointer lock, that pointer was not being cleared.
Code modified to use TemporaryChange to automatically clear the pointer at all
method exit points.
Reviewed by Abhishek Arya.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
LayoutTests:
Test that reproduces bug 90391:
Enable pointer lock, receive mouse move, call window.open, don't crash.
Reviewed by Abhishek Arya.
* pointer-lock/bug90391-move-then-window-open-crash-expected.txt: Added.
* pointer-lock/bug90391-move-then-window-open-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Added Paths
trunk/LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-expected.txt
trunk/LayoutTests/pointer-lock/bug90391-move-then-window-open-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (121908 => 121909)
--- trunk/LayoutTests/ChangeLog 2012-07-05 16:13:48 UTC (rev 121908)
+++ trunk/LayoutTests/ChangeLog 2012-07-05 16:21:43 UTC (rev 121909)
@@ -1,3 +1,16 @@
+2012-07-05 Vincent Scheib sch...@chromium.org
+
+[Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent().
+https://bugs.webkit.org/show_bug.cgi?id=90391
+
+Test that reproduces bug 90391:
+Enable pointer lock, receive mouse move, call window.open, don't crash.
+
+Reviewed by Abhishek Arya.
+
+* pointer-lock/bug90391-move-then-window-open-crash-expected.txt: Added.
+* pointer-lock/bug90391-move-then-window-open-crash.html: Added.
+
2012-07-05 John Mellor joh...@chromium.org
Text Autosizing: Add test framework and simple test.
Added: trunk/LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-expected.txt (0 => 121909)
--- trunk/LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-expected.txt 2012-07-05 16:21:43 UTC (rev 121909)
@@ -0,0 +1,15 @@
+bug 90391: pointer lock mouse move events then window.open should not crash.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+ Locking targetdiv1.
+PASS document.onwebkitpointerlockchange event received.
+ Sending mouse move events.
+ Calling window.open.
+PASS Didn't crash
+PASS successfullyParsed is true
+
+TEST COMPLETE
+doNextStep for manual testing
+
Property changes on: trunk/LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/pointer-lock/bug90391-move-then-window-open-crash.html (0 => 121909)
--- trunk/LayoutTests/pointer-lock/bug90391-move-then-window-open-crash.html (rev 0)
+++ trunk/LayoutTests/pointer-lock/bug90391-move-then-window-open-crash.html 2012-07-05 16:21:43 UTC (rev 121909)
@@ -0,0 +1,64 @@
+!DOCTYPE HTML
+html
+head
+script src=""
+/head
+body
+div
+ button _onclick_=doNextStep('manual');doNextStep for manual testing/button
+ div id=target1/div
+/div
+script
+description(bug 90391: pointer lock mouse move events then window.open should not crash.)
+window.jsTestIsAsync = true;
+
+targetdiv1 = document.getElementById(target1);
+
+currentStep = 0;
+function doNextStep(manual)
+{
+if (!window.layoutTestController !manual)
+return;
+if (currentStep todo.length)
+setTimeout(function () { todo[currentStep++](); }, 0);
+else if (currentStep++ == todo.length)
+setTimeout(function () { finishJSTest(); }, 0);
+}
+todo = [
+function () {
+debug( Locking targetdiv1.)
+targetdiv1.webkitRequestPointerLock();
+document._onwebkitpointerlockchange_ = function () {
+document._onwebkitpointerlockchange_ = null;
+testPassed(document.onwebkitpointerlockchange event received.);
+doNextStep('manual');
+};
+},
+function () {
+debug( Sending mouse move events.)
+var mouseMoveEvents = 0;
+targetdiv1._onmousemove_ = function () {
+if (++mouseMoveEvents == 2) {
+targetdiv1._onmousemove_ = null;
+doNextStep('manual');
+}
+}
+if (window.eventSender) {
+ eventSender.mouseMoveTo(100, 100);
+ eventSender.mouseMoveTo(200, 200);
+
[webkit-changes] [121910] trunk
Title: [121910] trunk
Revision 121910
Author ves...@webkit.org
Date 2012-07-05 09:39:54 -0700 (Thu, 05 Jul 2012)
Log Message
[Qt] Move Webkit1 before WebKit2 in the build order
Reviewed by Csaba Osztrogonác.
* WebKit.pro:
Modified Paths
trunk/ChangeLog
trunk/WebKit.pro
Diff
Modified: trunk/ChangeLog (121909 => 121910)
--- trunk/ChangeLog 2012-07-05 16:21:43 UTC (rev 121909)
+++ trunk/ChangeLog 2012-07-05 16:39:54 UTC (rev 121910)
@@ -1,3 +1,11 @@
+2012-07-05 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Move Webkit1 before WebKit2 in the build order
+
+Reviewed by Csaba Osztrogonác.
+
+* WebKit.pro:
+
2012-07-05 Ryuan Choi ryuan.c...@samsung.com
[CMAKE] Unreviewd typo fix after r121857
Modified: trunk/WebKit.pro (121909 => 121910)
--- trunk/WebKit.pro 2012-07-05 16:21:43 UTC (rev 121909)
+++ trunk/WebKit.pro 2012-07-05 16:39:54 UTC (rev 121910)
@@ -28,18 +28,18 @@
WebCore.makefile = Makefile.WebCore
SUBDIRS += WebCore
+!no_webkit1 {
+webkit1.file = Source/WebKit/WebKit1.pro
+webkit1.makefile = Makefile.WebKit1
+SUBDIRS += webkit1
+}
+
!no_webkit2 {
webkit2.file = Source/WebKit2/WebKit2.pro
webkit2.makefile = Makefile.WebKit2
SUBDIRS += webkit2
}
-!no_webkit1 {
-webkit1.file = Source/WebKit/WebKit1.pro
-webkit1.makefile = Makefile.WebKit1
-SUBDIRS += webkit1
-}
-
QtWebKit.file = Source/QtWebKit.pro
QtWebKit.makefile = Makefile.QtWebKit
SUBDIRS += QtWebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121911] trunk/Source/WebCore
Title: [121911] trunk/Source/WebCore Revision 121911 Author pfeld...@chromium.org Date 2012-07-05 09:44:46 -0700 (Thu, 05 Jul 2012) Log Message Web Inspector: move search field to the bottom of the page. https://bugs.webkit.org/show_bug.cgi?id=90610 Reviewed by Vsevolod Vlasov. This is the first step in the Search/replace implementation. This change moves search field from the inspector toolbar to the inspector view footer that is visible upon Cmd/Ctrl+F. * English.lproj/localizedStrings.js: * inspector/front-end/InspectorView.js: (WebInspector.InspectorView): (WebInspector.InspectorView.prototype._pushToHistory): (WebInspector.InspectorView.prototype.panelsElement): (WebInspector.InspectorView.prototype.setFooterElement): * inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset): * inspector/front-end/SearchController.js: (WebInspector.SearchController): (WebInspector.SearchController.prototype.updateSearchLabel): (WebInspector.SearchController.prototype.cancelSearch): (WebInspector.SearchController.prototype._updateSearchNavigationButtonState): (WebInspector.SearchController.prototype.focusSearchField): (WebInspector.SearchController.prototype._onKeyDown): (WebInspector.SearchController.prototype._onNextButtonSearch): (WebInspector.SearchController.prototype._onPrevButtonSearch): (WebInspector.SearchController.prototype._performSearch): * inspector/front-end/inspector.css: (#search): (.toolbar-search-container): (.toolbar-search-navigation): (.toolbar-search-navigation:hover): (.toolbar-search-navigation.toolbar-search-navigation-prev): (.toolbar-search-navigation.toolbar-search-navigation-next): (.toolbar-search-navigation-hidden): (.status-bar): (.search-drawer-header input[type=search].search-config-search): (.inspector-footer): (.inspector-footer div): * inspector/front-end/inspector.html: * inspector/front-end/inspector.js: (WebInspector.get _setCompactMode): (WebInspector.postDocumentKeyDown): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/inspector/front-end/InspectorView.js trunk/Source/WebCore/inspector/front-end/Panel.js trunk/Source/WebCore/inspector/front-end/SearchController.js trunk/Source/WebCore/inspector/front-end/inspector.css trunk/Source/WebCore/inspector/front-end/inspector.html trunk/Source/WebCore/inspector/front-end/inspector.js Diff Modified: trunk/Source/WebCore/ChangeLog (121910 => 121911) --- trunk/Source/WebCore/ChangeLog 2012-07-05 16:39:54 UTC (rev 121910) +++ trunk/Source/WebCore/ChangeLog 2012-07-05 16:44:46 UTC (rev 121911) @@ -1,3 +1,50 @@ +2012-07-05 Pavel Feldman pfeld...@chromium.org + +Web Inspector: move search field to the bottom of the page. +https://bugs.webkit.org/show_bug.cgi?id=90610 + +Reviewed by Vsevolod Vlasov. + +This is the first step in the Search/replace implementation. This change moves search +field from the inspector toolbar to the inspector view footer that is visible upon Cmd/Ctrl+F. + +* English.lproj/localizedStrings.js: +* inspector/front-end/InspectorView.js: +(WebInspector.InspectorView): +(WebInspector.InspectorView.prototype._pushToHistory): +(WebInspector.InspectorView.prototype.panelsElement): +(WebInspector.InspectorView.prototype.setFooterElement): +* inspector/front-end/Panel.js: +(WebInspector.Panel.prototype.show): +* inspector/front-end/ProfilesPanel.js: +(WebInspector.ProfilesPanel.prototype._reset): +* inspector/front-end/SearchController.js: +(WebInspector.SearchController): +(WebInspector.SearchController.prototype.updateSearchLabel): +(WebInspector.SearchController.prototype.cancelSearch): +(WebInspector.SearchController.prototype._updateSearchNavigationButtonState): +(WebInspector.SearchController.prototype.focusSearchField): +(WebInspector.SearchController.prototype._onKeyDown): +(WebInspector.SearchController.prototype._onNextButtonSearch): +(WebInspector.SearchController.prototype._onPrevButtonSearch): +(WebInspector.SearchController.prototype._performSearch): +* inspector/front-end/inspector.css: +(#search): +(.toolbar-search-container): +(.toolbar-search-navigation): +(.toolbar-search-navigation:hover): +(.toolbar-search-navigation.toolbar-search-navigation-prev): +(.toolbar-search-navigation.toolbar-search-navigation-next): +(.toolbar-search-navigation-hidden): +(.status-bar): +(.search-drawer-header input[type=search].search-config-search): +(.inspector-footer): +(.inspector-footer div): +* inspector/front-end/inspector.html: +* inspector/front-end/inspector.js: +(WebInspector.get _setCompactMode): +
[webkit-changes] [121912] trunk
Title: [121912] trunk Revision 121912 Author jap...@chromium.org Date 2012-07-05 10:19:13 -0700 (Thu, 05 Jul 2012) Log Message Source/WebCore: REGRESSION (r115654): Sometimes does not replace content for multipart/x-mixed-replace https://bugs.webkit.org/show_bug.cgi?id=88436 Reviewed by Brady Eidson. Test: http/tests/multipart/multipart-replace-non-html-content.php * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData): We should only send receivedFirstData() once per main resource load, rather than multiple times in a multipart load. (WebCore::DocumentLoader::setupForReplaceByMIMEType): m_gotFirstByte isn't set to true until data is actually committed, and multipart data is often not committed until the part is finished. Check whether the SharedBuffer is non-null instead. * testing/js/WebCoreTestSupport.cpp: (WebCoreTestSupport::resetInternalsObject): The JSInternals object my have already been cleared if the window shell was cleared as part of creation of a new Document. Check it before using it. LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=88436. Reviewed by Brady Eidson. * http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added. * http/tests/multipart/multipart-replace-non-html-content.php: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentLoader.cpp trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp Added Paths trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content.php Diff Modified: trunk/LayoutTests/ChangeLog (121911 => 121912) --- trunk/LayoutTests/ChangeLog 2012-07-05 16:44:46 UTC (rev 121911) +++ trunk/LayoutTests/ChangeLog 2012-07-05 17:19:13 UTC (rev 121912) @@ -1,3 +1,12 @@ +2012-07-05 Nate Chapin jap...@chromium.org + +Test for https://bugs.webkit.org/show_bug.cgi?id=88436. + +Reviewed by Brady Eidson. + +* http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added. +* http/tests/multipart/multipart-replace-non-html-content.php: Added. + 2012-07-05 Vincent Scheib sch...@chromium.org [Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent(). Added: trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt (0 => 121912) --- trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt 2012-07-05 17:19:13 UTC (rev 121912) @@ -0,0 +1,3 @@ +This text should only appear once 10
[webkit-changes] [121913] trunk
Title: [121913] trunk Revision 121913 Author a...@apple.com Date 2012-07-05 10:37:35 -0700 (Thu, 05 Jul 2012) Log Message [Mac][WK2] Enable HTTPS tests https://bugs.webkit.org/show_bug.cgi?id=90600 Reviewed by Brady Eidson. Tools: * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment. It explained why we were doing this here instead of a frame load delegate, but that's just history, not an explanation of why we need this code. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed for tests, it seems appropriate to have platform specific solutions in every WTR, and not add a WebKit2 API. LayoutTests: Unskip in common wk2 skipped file, re-skip everywhere besides Mac. * platform/gtk-wk2/Skipped: * platform/qt-5.0-wk2/Skipped: * platform/win-wk2/Skipped: * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk-wk2/Skipped trunk/LayoutTests/platform/qt-5.0-wk2/Skipped trunk/LayoutTests/platform/win-wk2/Skipped trunk/LayoutTests/platform/wk2/Skipped trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm Diff Modified: trunk/LayoutTests/ChangeLog (121912 => 121913) --- trunk/LayoutTests/ChangeLog 2012-07-05 17:19:13 UTC (rev 121912) +++ trunk/LayoutTests/ChangeLog 2012-07-05 17:37:35 UTC (rev 121913) @@ -1,3 +1,17 @@ +2012-07-05 Alexey Proskuryakov a...@apple.com + +[Mac][WK2] Enable HTTPS tests +https://bugs.webkit.org/show_bug.cgi?id=90600 + +Reviewed by Brady Eidson. + +Unskip in common wk2 skipped file, re-skip everywhere besides Mac. + +* platform/gtk-wk2/Skipped: +* platform/qt-5.0-wk2/Skipped: +* platform/win-wk2/Skipped: +* platform/wk2/Skipped: + 2012-07-05 Nate Chapin jap...@chromium.org Test for https://bugs.webkit.org/show_bug.cgi?id=88436. Modified: trunk/LayoutTests/platform/gtk-wk2/Skipped (121912 => 121913) --- trunk/LayoutTests/platform/gtk-wk2/Skipped 2012-07-05 17:19:13 UTC (rev 121912) +++ trunk/LayoutTests/platform/gtk-wk2/Skipped 2012-07-05 17:37:35 UTC (rev 121913) @@ -320,6 +320,9 @@ http/tests/navigation/ping-cross-origin.html http/tests/navigation/ping-cookie.html +# WebKitTestRunner needs to allow self-signed certificates for localhost. +http/tests/ssl + ### # TESTS FAILING ### Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (121912 => 121913) --- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-07-05 17:19:13 UTC (rev 121912) +++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-07-05 17:37:35 UTC (rev 121913) @@ -392,3 +392,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=89473 editing/pasteboard/copy-in-password-field.html editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html + +# WebKitTestRunner needs to allow self-signed certificates for localhost. +http/tests/ssl Modified: trunk/LayoutTests/platform/win-wk2/Skipped (121912 => 121913) --- trunk/LayoutTests/platform/win-wk2/Skipped 2012-07-05 17:19:13 UTC (rev 121912) +++ trunk/LayoutTests/platform/win-wk2/Skipped 2012-07-05 17:37:35 UTC (rev 121913) @@ -949,3 +949,6 @@ # HiDPI tests require test infrastructure enhancements fast/hidpi + +# WebKitTestRunner needs to allow self-signed certificates for localhost. +http/tests/ssl Modified: trunk/LayoutTests/platform/wk2/Skipped (121912 => 121913) --- trunk/LayoutTests/platform/wk2/Skipped 2012-07-05 17:19:13 UTC (rev 121912) +++ trunk/LayoutTests/platform/wk2/Skipped 2012-07-05 17:37:35 UTC (rev 121913) @@ -1177,9 +1177,6 @@ http/tests/navigation/history-back-across-form-submission-to-fragment.html http/tests/security/cross-frame-access-put.html http/tests/security/originHeader/origin-header-for-https.html -http/tests/ssl/referer-301.html -http/tests/ssl/referer-303.html -http/tests/ssl/verify-ssl-enabled.php http/tests/storage/callbacks-are-called-in-correct-context.html media/controls-after-reload.html media/controls-styling.html Modified: trunk/Tools/ChangeLog (121912 => 121913) --- trunk/Tools/ChangeLog 2012-07-05 17:19:13 UTC (rev 121912) +++ trunk/Tools/ChangeLog 2012-07-05 17:37:35 UTC (rev 121913) @@ -1,3 +1,19 @@ +2012-07-05 Alexey Proskuryakov a...@apple.com + +[Mac][WK2] Enable HTTPS tests +https://bugs.webkit.org/show_bug.cgi?id=90600 + +Reviewed by Brady Eidson. + +* DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment. +It explained why we were doing this here instead of a frame load delegate, but that's +just history, not an explanation of why we need this code. + +*
[webkit-changes] [121914] trunk
Title: [121914] trunk Revision 121914 Author rwlb...@webkit.org Date 2012-07-05 10:46:09 -0700 (Thu, 05 Jul 2012) Log Message [CMake] Fix some CMake warnings https://bugs.webkit.org/show_bug.cgi?id=90558 Fix WebKit options so they match with FeatureList.pm. Reviewed by Dan Bates. * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: Modified Paths trunk/ChangeLog trunk/Source/cmake/WebKitFeatures.cmake trunk/Source/cmakeconfig.h.cmake Diff Modified: trunk/ChangeLog (121913 => 121914) --- trunk/ChangeLog 2012-07-05 17:37:35 UTC (rev 121913) +++ trunk/ChangeLog 2012-07-05 17:46:09 UTC (rev 121914) @@ -1,3 +1,15 @@ +2012-07-05 Rob Buis rb...@rim.com + +[CMake] Fix some CMake warnings +https://bugs.webkit.org/show_bug.cgi?id=90558 + +Fix WebKit options so they match with FeatureList.pm. + +Reviewed by Dan Bates. + +* Source/cmake/WebKitFeatures.cmake: +* Source/cmakeconfig.h.cmake: + 2012-07-05 Tor Arne Vestbø tor.arne.ves...@nokia.com [Qt] Move Webkit1 before WebKit2 in the build order Modified: trunk/Source/cmake/WebKitFeatures.cmake (121913 => 121914) --- trunk/Source/cmake/WebKitFeatures.cmake 2012-07-05 17:37:35 UTC (rev 121913) +++ trunk/Source/cmake/WebKitFeatures.cmake 2012-07-05 17:46:09 UTC (rev 121914) @@ -62,6 +62,7 @@ WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION Toogle legacy viewport adaption OFF) WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_WEBKIT_BLOB_BUILDER Toggle Legacy WebKit Blob Builder Support OFF) WEBKIT_OPTION_DEFINE(ENABLE_LINK_PREFETCH Toggle pre fetching support OFF) +WEBKIT_OPTION_DEFINE(ENABLE_LINK_PRERENDER Toggle pre rendering support OFF) WEBKIT_OPTION_DEFINE(ENABLE_MATHML Toggle MathML support ON) WEBKIT_OPTION_DEFINE(ENABLE_MEDIA_SOURCE Toggle Media Source support OFF) WEBKIT_OPTION_DEFINE(ENABLE_MEDIA_STATISTICS Toggle Media Statistics support OFF) @@ -104,8 +105,8 @@ WEBKIT_OPTION_DEFINE(ENABLE_WORKERS Toggle Web Workers support OFF) WEBKIT_OPTION_DEFINE(ENABLE_XSLT Toggle XSLT support ON) WEBKIT_OPTION_DEFINE(USE_SYSTEM_MALLOC Toggle system allocator instead of TCmalloc OFF) -WEBKIT_OPTION_DEFINE(USE_TILED_BACKING_STORE Toggle Tiled Backing Store support OFF) -WEBKIT_OPTION_DEFINE(USE_WTFURL Toogle the use of WTFURL for URL parsing OFF) +WEBKIT_OPTION_DEFINE(WTF_USE_TILED_BACKING_STORE Toggle Tiled Backing Store support OFF) +WEBKIT_OPTION_DEFINE(WTF_USE_WTFURL Toogle the use of WTFURL for URL parsing OFF) ENDMACRO () MACRO (WEBKIT_OPTION_END) Modified: trunk/Source/cmakeconfig.h.cmake (121913 => 121914) --- trunk/Source/cmakeconfig.h.cmake 2012-07-05 17:37:35 UTC (rev 121913) +++ trunk/Source/cmakeconfig.h.cmake 2012-07-05 17:46:09 UTC (rev 121914) @@ -51,6 +51,8 @@ #cmakedefine01 ENABLE_JAVASCRIPT_DEBUGGER #cmakedefine01 ENABLE_JIT #cmakedefine01 ENABLE_LEGACY_NOTIFICATIONS +#cmakedefine01 ENABLE_LINK_PREFETCH +#cmakedefine01 ENABLE_LINK_PRERENDER #cmakedefine01 ENABLE_LEGACY_WEBKIT_BLOB_BUILDER #cmakedefine01 ENABLE_MATHML #cmakedefine01 ENABLE_MEDIA_STREAM @@ -90,5 +92,7 @@ #cmakedefine01 ENABLE_WORKERS #cmakedefine01 ENABLE_XSLT #cmakedefine01 USE_SYSTEM_MALLOC +#cmakedefine01 WTF_USE_TILED_BACKING_STORE +#cmakedefine01 WTF_USE_WTFURL #endif /* CMAKECONFIG_H */ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121915] trunk/Tools
Title: [121915] trunk/Tools Revision 121915 Author dth...@codeaurora.org Date 2012-07-05 10:54:46 -0700 (Thu, 05 Jul 2012) Log Message Adding myself as committer to committers.py Unreviewed. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (121914 => 121915) --- trunk/Tools/ChangeLog 2012-07-05 17:46:09 UTC (rev 121914) +++ trunk/Tools/ChangeLog 2012-07-05 17:54:46 UTC (rev 121915) @@ -1,3 +1,11 @@ +2012-07-05 Dave Tharp dth...@codeaurora.org + +Adding myself as committer to committers.py + +Unreviewed. + +* Scripts/webkitpy/common/config/committers.py: + 2012-07-05 Alexey Proskuryakov a...@apple.com [Mac][WK2] Enable HTTPS tests Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (121914 => 121915) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-07-05 17:46:09 UTC (rev 121914) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-07-05 17:54:46 UTC (rev 121915) @@ -122,7 +122,6 @@ Contributor(Brian Salomon, bsalo...@google.com), Contributor(Commit Queue, commit-qu...@webkit.org), Contributor(Daniel Sievers, siev...@chromium.org), -Contributor(Dave Tharp, dth...@codeaurora.org, dtharp), Contributor(David Barr, davidb...@chromium.org, barrbrain), Contributor(David Dorwin, ddor...@chromium.org, ddorwin), Contributor(David Reveman, reve...@chromium.org, reveman), @@ -223,6 +222,7 @@ Committer(Dana Jansens, dan...@chromium.org, danakj), Committer(Daniel Cheng, dch...@chromium.org, dcheng), Committer(Dave Barton, dbar...@mathscribe.com, dbarton), +Committer(Dave Tharp, dth...@codeaurora.org, dtharp), Committer(David Grogan, [dgro...@chromium.org, dgro...@google.com], dgrogan), Committer(David Smith, [catfish@gmail.com, dsm...@webkit.org], catfishman), Committer(Diego Gonzalez, [diego...@webkit.org, diego.gonza...@openbossa.org], diegohcg), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121916] trunk/Source/WebKit2
Title: [121916] trunk/Source/WebKit2
Revision 121916
Author commit-qu...@webkit.org
Date 2012-07-05 11:01:10 -0700 (Thu, 05 Jul 2012)
Log Message
Unreviewed, rolling out r121899.
http://trac.webkit.org/changeset/121899
https://bugs.webkit.org/show_bug.cgi?id=90623
Unauthorized WK2 API breakage (Requested by andersca on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-07-05
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedURLAPI):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (121915 => 121916)
--- trunk/Source/WebKit2/ChangeLog 2012-07-05 17:54:46 UTC (rev 121915)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-05 18:01:10 UTC (rev 121916)
@@ -1,3 +1,15 @@
+2012-07-05 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r121899.
+http://trac.webkit.org/changeset/121899
+https://bugs.webkit.org/show_bug.cgi?id=90623
+
+Unauthorized WK2 API breakage (Requested by andersca on
+#webkit).
+
+* Shared/API/c/WKSharedAPICast.h:
+(WebKit::toCopiedURLAPI):
+
2012-07-05 Balazs Kelemen kbal...@webkit.org
[Qt] WTR crashes if a URL is passed as a parameter
Modified: trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h (121915 => 121916)
--- trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h 2012-07-05 17:54:46 UTC (rev 121915)
+++ trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h 2012-07-05 18:01:10 UTC (rev 121916)
@@ -159,6 +159,8 @@
inline WKURLRef toCopiedURLAPI(const String string)
{
+if (!string)
+return 0;
RefPtrWebURL webURL = WebURL::create(string);
return toAPI(webURL.release().leakRef());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121917] trunk
Title: [121917] trunk
Revision 121917
Author commit-qu...@webkit.org
Date 2012-07-05 11:20:42 -0700 (Thu, 05 Jul 2012)
Log Message
Subpixel layout broken with spans with CSS position other than static
https://bugs.webkit.org/show_bug.cgi?id=90097
Patch by Behdad Esfahbod beh...@behdad.org on 2012-07-05
Reviewed by Eric Seidel.
In InlineBox, don't truncate size to integers when returning.
In RenderBlock, don't round-up width to next integer. Round-up to
next LayoutUnit instead.
Test: Added fast/sub-pixel/size-of-span-with-different-positions.html
Adjust expected outputs affected by the rounding changes.
* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::fromFloatCeil):
(FractionalLayoutUnit):
* rendering/InlineBox.h:
(WebCore::InlineBox::size):
* rendering/RenderBlock.cpp:
(WebCore::updatePreferredWidth):
Modified Paths
trunk/LayoutTests/platform/chromium-linux/fast/html/details-marker-style-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/html/details-marker-style-expected.txt
trunk/LayoutTests/platform/chromium-linux/media/video-zoom-controls-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/FractionalLayoutUnit.h
trunk/Source/WebCore/rendering/InlineBox.h
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/fast/sub-pixel/size-of-span-with-different-positions-expected.txt
trunk/LayoutTests/fast/sub-pixel/size-of-span-with-different-positions.html
trunk/LayoutTests/platform/chromium-linux/media/video-zoom-controls-expected.txt
trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt
Diff
Added: trunk/LayoutTests/fast/sub-pixel/size-of-span-with-different-positions-expected.txt (0 => 121917)
--- trunk/LayoutTests/fast/sub-pixel/size-of-span-with-different-positions-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/size-of-span-with-different-positions-expected.txt 2012-07-05 18:20:42 UTC (rev 121917)
@@ -0,0 +1,9 @@
+Test case for bug 90097. This tests span sizes with different CSS position attributes.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/sub-pixel/size-of-span-with-different-positions.html (0 => 121917)
--- trunk/LayoutTests/fast/sub-pixel/size-of-span-with-different-positions.html (rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/size-of-span-with-different-positions.html 2012-07-05 18:20:42 UTC (rev 121917)
@@ -0,0 +1,31 @@
+html
+head
+style
+.testContent {
+font-face: Arial; font-size: 16px;
+}
+/style
+/head
+body
+div id=testContent
+span id=span-position-static style=position:staticT/span
+span id=span-position-fixedstyle=position:fixedT/span
+span id=span-position-absolute style=position:absoluteT/span
+span id=span-position-relative style=position:relativeT/span
+/div
+script src=""
+script
+description(Test case for bug 90097. This tests span sizes with different CSS position attributes.);
+var spans = testContent.querySelectorAll('span');
+var expected_width = document.getElementById('span-position-static').getBoundingClientRect().width;
+// if expected_width is integral, all should match, otherwise should be close
+var tolerance = expected_width % 1.0 == 0.0 ? 0.0 : 1.0 / 60;
+
+shouldBeCloseTo('document.getElementById(span-position-fixed).getBoundingClientRect().width', expected_width, tolerance, true);
+shouldBeCloseTo('document.getElementById(span-position-absolute).getBoundingClientRect().width', expected_width, tolerance, true);
+shouldBeCloseTo('document.getElementById(span-position-relative).getBoundingClientRect().width', expected_width, tolerance, true);
+document.getElementById(testContent).style.display = 'none';
+/script
+script src=""
+/body
+/html
Modified: trunk/LayoutTests/platform/chromium-linux/fast/html/details-marker-style-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-linux/fast/html/details-marker-style-expected.txt (121916 => 121917)
--- trunk/LayoutTests/platform/chromium-linux/fast/html/details-marker-style-expected.txt 2012-07-05 18:01:10 UTC (rev 121916)
+++ trunk/LayoutTests/platform/chromium-linux/fast/html/details-marker-style-expected.txt 2012-07-05 18:20:42 UTC (rev 121917)
@@ -15,13 +15,13 @@
RenderDetailsMarker {DIV} at (9,0) size 112x80 [border: (8px solid
[webkit-changes] [121918] trunk/Source/WebCore
Title: [121918] trunk/Source/WebCore
Revision 121918
Author pfeld...@chromium.org
Date 2012-07-05 12:44:04 -0700 (Thu, 05 Jul 2012)
Log Message
Web Inspector: move cursor to the current search match.
https://bugs.webkit.org/show_bug.cgi?id=90621
Reviewed by Vsevolod Vlasov.
After closing the search dialog, the cursor should be at the latest search match location.
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.markAndRevealRange):
(WebInspector.TextEditor.prototype._handleFocused):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TextEditor.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (121917 => 121918)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 18:20:42 UTC (rev 121917)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 19:44:04 UTC (rev 121918)
@@ -1,3 +1,16 @@
+2012-07-05 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: move cursor to the current search match.
+https://bugs.webkit.org/show_bug.cgi?id=90621
+
+Reviewed by Vsevolod Vlasov.
+
+After closing the search dialog, the cursor should be at the latest search match location.
+
+* inspector/front-end/TextEditor.js:
+(WebInspector.TextEditor.prototype.markAndRevealRange):
+(WebInspector.TextEditor.prototype._handleFocused):
+
2012-07-05 Behdad Esfahbod beh...@behdad.org
Subpixel layout broken with spans with CSS position other than static
Modified: trunk/Source/WebCore/inspector/front-end/TextEditor.js (121917 => 121918)
--- trunk/Source/WebCore/inspector/front-end/TextEditor.js 2012-07-05 18:20:42 UTC (rev 121917)
+++ trunk/Source/WebCore/inspector/front-end/TextEditor.js 2012-07-05 19:44:04 UTC (rev 121918)
@@ -158,6 +158,8 @@
*/
markAndRevealRange: function(range)
{
+if (range)
+this._lastMarkedRange = range;
this._mainPanel.markAndRevealRange(range);
},
@@ -410,6 +412,12 @@
_handleFocused: function()
{
+// Convert last marked range into a selection upon focus. This is needed to focus the search result.
+if (this._lastMarkedRange) {
+this._lastSelection = this._lastMarkedRange;
+delete this._lastMarkedRange;
+}
+
if (this._lastSelection) {
// We do not restore selection after focus lost to avoid selection blinking. We restore only cursor position instead.
// FIXME: consider adding selection decoration to blurred editor.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121919] trunk/Source/WebKit2
Title: [121919] trunk/Source/WebKit2 Revision 121919 Author commit-qu...@webkit.org Date 2012-07-05 12:49:56 -0700 (Thu, 05 Jul 2012) Log Message [WK2] Add C API for Battery Status API https://bugs.webkit.org/show_bug.cgi?id=90545 Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-05 Reviewed by Anders Carlsson. Add C API for WKBatteryManager and WKBatteryStatus so that clients can support the Battery Status API in WebKit2. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * UIProcess/API/C/WKBatteryManager.cpp: (WKBatteryManagerProviderDidChangeBatteryStatus): (WKBatteryManagerProviderUpdateBatteryStatus): * UIProcess/API/C/WKBatteryStatus.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp. (WKBatteryStatusGetTypeID): (WKBatteryStatusCreate): * UIProcess/API/C/WKBatteryStatus.h: Copied from Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp. Modified Paths trunk/Source/WebKit2/CMakeLists.txt trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.list.am trunk/Source/WebKit2/Target.pri trunk/Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp trunk/Source/WebKit2/UIProcess/API/C/WKBatteryManager.h Added Paths trunk/Source/WebKit2/UIProcess/API/C/WKBatteryStatus.cpp trunk/Source/WebKit2/UIProcess/API/C/WKBatteryStatus.h Diff Modified: trunk/Source/WebKit2/CMakeLists.txt (121918 => 121919) --- trunk/Source/WebKit2/CMakeLists.txt 2012-07-05 19:44:04 UTC (rev 121918) +++ trunk/Source/WebKit2/CMakeLists.txt 2012-07-05 19:49:56 UTC (rev 121919) @@ -269,6 +269,7 @@ UIProcess/API/C/WKBackForwardList.cpp UIProcess/API/C/WKBackForwardListItem.cpp UIProcess/API/C/WKBatteryManager.cpp +UIProcess/API/C/WKBatteryStatus.cpp UIProcess/API/C/WKContext.cpp UIProcess/API/C/WKCookieManager.cpp UIProcess/API/C/WKCredential.cpp Modified: trunk/Source/WebKit2/ChangeLog (121918 => 121919) --- trunk/Source/WebKit2/ChangeLog 2012-07-05 19:44:04 UTC (rev 121918) +++ trunk/Source/WebKit2/ChangeLog 2012-07-05 19:49:56 UTC (rev 121919) @@ -1,3 +1,25 @@ +2012-07-05 Christophe Dumez christophe.du...@intel.com + +[WK2] Add C API for Battery Status API +https://bugs.webkit.org/show_bug.cgi?id=90545 + +Reviewed by Anders Carlsson. + +Add C API for WKBatteryManager and WKBatteryStatus +so that clients can support the Battery Status API +in WebKit2. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* UIProcess/API/C/WKBatteryManager.cpp: +(WKBatteryManagerProviderDidChangeBatteryStatus): +(WKBatteryManagerProviderUpdateBatteryStatus): +* UIProcess/API/C/WKBatteryStatus.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp. +(WKBatteryStatusGetTypeID): +(WKBatteryStatusCreate): +* UIProcess/API/C/WKBatteryStatus.h: Copied from Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp. + 2012-07-05 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r121899. Modified: trunk/Source/WebKit2/GNUmakefile.list.am (121918 => 121919) --- trunk/Source/WebKit2/GNUmakefile.list.am 2012-07-05 19:44:04 UTC (rev 121918) +++ trunk/Source/WebKit2/GNUmakefile.list.am 2012-07-05 19:49:56 UTC (rev 121919) @@ -48,6 +48,7 @@ $(WebKit2)/UIProcess/API/C/WKBackForwardList.h \ $(WebKit2)/UIProcess/API/C/WKBackForwardListItem.h \ $(WebKit2)/UIProcess/API/C/WKBatteryManager.h \ + $(WebKit2)/UIProcess/API/C/WKBatteryStatus.h \ $(WebKit2)/UIProcess/API/C/WKContext.h \ $(WebKit2)/UIProcess/API/C/WKContextPrivate.h \ $(WebKit2)/UIProcess/API/C/WKCookieManager.h \ @@ -514,6 +515,8 @@ Source/WebKit2/UIProcess/API/C/WKBackForwardListItem.h \ Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp \ Source/WebKit2/UIProcess/API/C/WKBatteryManager.h \ + Source/WebKit2/UIProcess/API/C/WKBatteryStatus.cpp \ + Source/WebKit2/UIProcess/API/C/WKBatteryStatus.h \ Source/WebKit2/UIProcess/API/C/WKContext.cpp \ Source/WebKit2/UIProcess/API/C/WKContext.h \ Source/WebKit2/UIProcess/API/C/WKContextPrivate.h \ Modified: trunk/Source/WebKit2/Target.pri (121918 => 121919) --- trunk/Source/WebKit2/Target.pri 2012-07-05 19:44:04 UTC (rev 121918) +++ trunk/Source/WebKit2/Target.pri 2012-07-05 19:49:56 UTC (rev 121919) @@ -147,6 +147,7 @@ UIProcess/API/C/WKBackForwardList.h \ UIProcess/API/C/WKBackForwardListItem.h \ UIProcess/API/C/WKBatteryManager.h \ +UIProcess/API/C/WKBatteryStatus.h \ UIProcess/API/C/WKContext.h \ UIProcess/API/C/WKContextPrivate.h \ UIProcess/API/C/WKCredential.h \ @@ -517,6 +518,7 @@ UIProcess/API/C/WKBackForwardList.cpp \ UIProcess/API/C/WKBackForwardListItem.cpp \ UIProcess/API/C/WKBatteryManager.cpp \ +UIProcess/API/C/WKBatteryStatus.cpp \ UIProcess/API/C/WKContext.cpp \ UIProcess/API/C/WKCredential.cpp \ UIProcess/API/C/WKDatabaseManager.cpp \ Modified:
[webkit-changes] [121920] trunk/Source/WebCore
Title: [121920] trunk/Source/WebCore
Revision 121920
Author commit-qu...@webkit.org
Date 2012-07-05 12:57:22 -0700 (Thu, 05 Jul 2012)
Log Message
Text Autosizing: Add basic framework
https://bugs.webkit.org/show_bug.cgi?id=88655
Follow-up patch tweaking method signatures.
Patch by John Mellor joh...@chromium.org on 2012-07-05
Reviewed by Simon Fraser.
No functional change, so no new tests.
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processBlock):
(WebCore::TextAutosizer::processText):
(WebCore):
* rendering/TextAutosizer.h:
(TextAutosizer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/TextAutosizer.cpp
trunk/Source/WebCore/rendering/TextAutosizer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (121919 => 121920)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 19:49:56 UTC (rev 121919)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 19:57:22 UTC (rev 121920)
@@ -1,3 +1,24 @@
+2012-07-05 John Mellor joh...@chromium.org
+
+Text Autosizing: Add basic framework
+https://bugs.webkit.org/show_bug.cgi?id=88655
+
+Follow-up patch tweaking method signatures.
+
+Reviewed by Simon Fraser.
+
+No functional change, so no new tests.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::layout):
+* rendering/TextAutosizer.cpp:
+(WebCore::TextAutosizer::processSubtree):
+(WebCore::TextAutosizer::processBlock):
+(WebCore::TextAutosizer::processText):
+(WebCore):
+* rendering/TextAutosizer.h:
+(TextAutosizer):
+
2012-07-05 Pavel Feldman pfeld...@chromium.org
Web Inspector: move cursor to the current search match.
Modified: trunk/Source/WebCore/page/FrameView.cpp (121919 => 121920)
--- trunk/Source/WebCore/page/FrameView.cpp 2012-07-05 19:49:56 UTC (rev 121919)
+++ trunk/Source/WebCore/page/FrameView.cpp 2012-07-05 19:57:22 UTC (rev 121920)
@@ -1116,8 +1116,8 @@
forceLayoutParentViewIfNeeded();
root-layout();
#if ENABLE(TEXT_AUTOSIZING)
-bool boosted = document-textAutosizer()-boostSubtree(root);
-if (boosted root-needsLayout())
+bool autosized = document-textAutosizer()-processSubtree(root);
+if (autosized root-needsLayout())
root-layout();
#endif
endDeferredRepaints();
Modified: trunk/Source/WebCore/rendering/TextAutosizer.cpp (121919 => 121920)
--- trunk/Source/WebCore/rendering/TextAutosizer.cpp 2012-07-05 19:49:56 UTC (rev 121919)
+++ trunk/Source/WebCore/rendering/TextAutosizer.cpp 2012-07-05 19:57:22 UTC (rev 121920)
@@ -42,7 +42,7 @@
{
}
-bool TextAutosizer::boostSubtree(RenderObject* layoutRoot)
+bool TextAutosizer::processSubtree(RenderObject* layoutRoot)
{
// FIXME: Text Autosizing should only be enabled when m_document-page()-mainFrame()-view()-useFixedLayout()
// is true, but for now it's useful to ignore this so that it can be tested on desktop.
@@ -58,38 +58,38 @@
for (RenderObject* descendant = traverseNext(layoutRoot, layoutRoot); descendant; descendant = traverseNext(descendant, layoutRoot)) {
if (!treatAsInline(descendant))
-boostBlock(toRenderBlock(descendant), windowSize);
+processBlock(toRenderBlock(descendant), windowSize);
}
return true;
}
-void TextAutosizer::boostBlock(RenderBlock* block, LayoutSize windowSize)
+void TextAutosizer::processBlock(RenderBlock* block, const IntSize windowSize)
{
-float windowLogicalWidth = block-isHorizontalWritingMode() ? windowSize.width() : windowSize.height();
-float multiplier = block-logicalWidth() / windowLogicalWidth; // FIXME: This is overly simplistic.
+int windowLogicalWidth = block-isHorizontalWritingMode() ? windowSize.width() : windowSize.height();
+float multiplier = static_castfloat(block-logicalWidth()) / windowLogicalWidth; // FIXME: This is overly simplistic.
if (multiplier 1)
return;
for (RenderObject* descendant = traverseNext(block, block, treatAsInline); descendant; descendant = traverseNext(descendant, block, treatAsInline)) {
if (descendant-isText())
-boostText(toRenderText(descendant), multiplier);
+processText(toRenderText(descendant), multiplier);
}
}
-void TextAutosizer::boostText(RenderText* text, float multiplier)
+void TextAutosizer::processText(RenderText* text, float multiplier)
{
float specifiedSize = text-style()-fontDescription().specifiedSize();
-float boostedSize = specifiedSize * multiplier; // FIXME: This is overly simplistic.
+float newSize = specifiedSize * multiplier; // FIXME: This is overly simplistic.
RefPtrRenderStyle style = RenderStyle::clone(text-style());
FontDescription fontDescription(style-fontDescription());
-
[webkit-changes] [121921] trunk
Title: [121921] trunk
Revision 121921
Author leandrogra...@chromium.org
Date 2012-07-05 13:03:40 -0700 (Thu, 05 Jul 2012)
Log Message
Character iterators should not advance if they are at end
https://bugs.webkit.org/show_bug.cgi?id=90560
Reviewed by Ryosuke Niwa.
Source/WebCore:
CharacterIterator and BackwardsCharacterIterator try to advance their
internal TextIterator without checking if they already are at end.
This can cause crashes in TextIterator::advance.
Test: platform/chromium/editing/surrounding-text/surrounding-text.html
* editing/SurroundingText.cpp:
(WebCore::SurroundingText::SurroundingText):
* editing/TextIterator.cpp:
(WebCore::CharacterIterator::advance):
(WebCore::BackwardsCharacterIterator::advance):
LayoutTests:
Add a new test case where character iterators are already at end when
trying to advance. This was caught by Chromium's address sanitizer
here: http://code.google.com/p/chromium/issues/detail?id=135705
* platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
* platform/chromium/editing/surrounding-text/surrounding-text.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text-expected.txt
trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/SurroundingText.cpp
trunk/Source/WebCore/editing/TextIterator.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (121920 => 121921)
--- trunk/LayoutTests/ChangeLog 2012-07-05 19:57:22 UTC (rev 121920)
+++ trunk/LayoutTests/ChangeLog 2012-07-05 20:03:40 UTC (rev 121921)
@@ -1,3 +1,17 @@
+2012-07-05 Leandro Gracia Gil leandrogra...@chromium.org
+
+Character iterators should not advance if they are at end
+https://bugs.webkit.org/show_bug.cgi?id=90560
+
+Reviewed by Ryosuke Niwa.
+
+Add a new test case where character iterators are already at end when
+trying to advance. This was caught by Chromium's address sanitizer
+here: http://code.google.com/p/chromium/issues/detail?id=135705
+
+* platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
+* platform/chromium/editing/surrounding-text/surrounding-text.html:
+
2012-07-05 Alexey Proskuryakov a...@apple.com
[Mac][WK2] Enable HTTPS tests
Modified: trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text-expected.txt (121920 => 121921)
--- trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text-expected.txt 2012-07-05 19:57:22 UTC (rev 121920)
+++ trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text-expected.txt 2012-07-05 20:03:40 UTC (rev 121921)
@@ -15,6 +15,7 @@
PASS surroundingText('button./buttondiv id=here012345678901234567890123456789/divbutton./button', 15, 12) is 901234567890
PASS surroundingText('option./option12345button id=heretest/buttonoption./option', 0, 100) is
PASS surroundingText('option./option12345buttontespan id=herest/span/buttonoption./option', 0, 100) is
+PASS surroundingText('p id=here.', 0, 2) is .
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text.html (121920 => 121921)
--- trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text.html 2012-07-05 19:57:22 UTC (rev 121920)
+++ trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text.html 2012-07-05 20:03:40 UTC (rev 121921)
@@ -40,6 +40,7 @@
shouldBeEqualToString('surroundingText(\'button./buttondiv id=here012345678901234567890123456789/divbutton./button\', 15, 12)', '901234567890');
shouldBeEqualToString('surroundingText(\'option./option12345button id=heretest/buttonoption./option\', 0, 100)', '');
shouldBeEqualToString('surroundingText(\'option./option12345buttontespan id=herest/span/buttonoption./option\', 0, 100)', '');
+shouldBeEqualToString('surroundingText(\'p id=here.\', 0, 2)', '.');
document.body.removeChild(document.getElementById('test'));
finishJSTest();
Modified: trunk/Source/WebCore/ChangeLog (121920 => 121921)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 19:57:22 UTC (rev 121920)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 20:03:40 UTC (rev 121921)
@@ -1,3 +1,22 @@
+2012-07-05 Leandro Gracia Gil leandrogra...@chromium.org
+
+Character iterators should not advance if they are at end
+https://bugs.webkit.org/show_bug.cgi?id=90560
+
+Reviewed by Ryosuke Niwa.
+
+CharacterIterator and BackwardsCharacterIterator try to advance their
+internal TextIterator without checking if they already are at end.
+This can cause crashes in TextIterator::advance.
+
+Test: platform/chromium/editing/surrounding-text/surrounding-text.html
+
+* editing/SurroundingText.cpp:
+(WebCore::SurroundingText::SurroundingText):
+
[webkit-changes] [121923] trunk/Source/WebCore
Title: [121923] trunk/Source/WebCore
Revision 121923
Author commit-qu...@webkit.org
Date 2012-07-05 13:19:08 -0700 (Thu, 05 Jul 2012)
Log Message
Code refactoring: move mimeTypeFromUTITree to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=90619
We should move UTI handling related code to a separate file.
Patch by Yongjun Zhang yongjun_zh...@apple.com on 2012-07-05
Reviewed by David Kilzer.
* WebCore.xcodeproj/project.pbxproj: Add UTIUtilities.h/UTIUtilities.mm to xcode project, and drive-by fix
that happened when editing the Xcode project file.
* platform/network/mac/UTIUtilities.h: Added.
(WebCore):
* platform/network/mac/UTIUtilities.mm: Added. move mimeTypeFromUTITree to UTIUtilities.mm.
(WebCore):
(WebCore::mimeTypeFromUTITree):
* platform/network/mac/WebCoreURLResponse.mm: include UTIUtilities.h to use mimeTypeFromUTITree.
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/network/mac/WebCoreURLResponse.mm
Added Paths
trunk/Source/WebCore/platform/network/mac/UTIUtilities.h
trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (121922 => 121923)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 20:07:55 UTC (rev 121922)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 20:19:08 UTC (rev 121923)
@@ -1,3 +1,22 @@
+2012-07-05 Yongjun Zhang yongjun_zh...@apple.com
+
+Code refactoring: move mimeTypeFromUTITree to a separate file.
+https://bugs.webkit.org/show_bug.cgi?id=90619
+
+We should move UTI handling related code to a separate file.
+
+Reviewed by David Kilzer.
+
+* WebCore.xcodeproj/project.pbxproj: Add UTIUtilities.h/UTIUtilities.mm to xcode project, and drive-by fix
+that happened when editing the Xcode project file.
+* platform/network/mac/UTIUtilities.h: Added.
+(WebCore):
+* platform/network/mac/UTIUtilities.mm: Added. move mimeTypeFromUTITree to UTIUtilities.mm.
+(WebCore):
+(WebCore::mimeTypeFromUTITree):
+* platform/network/mac/WebCoreURLResponse.mm: include UTIUtilities.h to use mimeTypeFromUTITree.
+(WebCore):
+
2012-07-05 Leandro Gracia Gil leandrogra...@chromium.org
Character iterators should not advance if they are at end
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (121922 => 121923)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2012-07-05 20:07:55 UTC (rev 121922)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2012-07-05 20:19:08 UTC (rev 121923)
@@ -669,6 +669,8 @@
1F3C3BEA135CAF3C00B8C1AC /* MediaControls.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1F3C3BE8135CAF3C00B8C1AC /* MediaControls.cpp */; };
1F3C3BEB135CAF3C00B8C1AC /* MediaControls.h in Headers */ = {isa = PBXBuildFile; fileRef = 1F3C3BE9135CAF3C00B8C1AC /* MediaControls.h */; };
1F3F19531499CA7600A5AEA7 /* PODFreeListArena.h in Headers */ = {isa = PBXBuildFile; fileRef = 1F3F19521499CA7600A5AEA7 /* PODFreeListArena.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 1FAFBF1815A5FA6E00083A20 /* UTIUtilities.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1FAFBF1715A5FA5200083A20 /* UTIUtilities.mm */; };
+ 1FAFBF1915A5FA7400083A20 /* UTIUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 1FAFBF1615A5FA5200083A20 /* UTIUtilities.h */; };
20D629261253690B00081543 /* InspectorInstrumentation.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 20D629241253690B00081543 /* InspectorInstrumentation.cpp */; };
20D629271253690B00081543 /* InspectorInstrumentation.h in Headers */ = {isa = PBXBuildFile; fileRef = 20D629251253690B00081543 /* InspectorInstrumentation.h */; };
22601345DEA9008EA455 /* InspectorFrontendChannel.h in Headers */ = {isa = PBXBuildFile; fileRef = 225F1345DEA9008EA455 /* InspectorFrontendChannel.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -7654,6 +7656,8 @@
1F3C3BE8135CAF3C00B8C1AC /* MediaControls.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MediaControls.cpp; sourceTree = group; };
1F3C3BE9135CAF3C00B8C1AC /* MediaControls.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MediaControls.h; sourceTree = group; };
1F3F19521499CA7600A5AEA7 /* PODFreeListArena.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PODFreeListArena.h; sourceTree = group; };
+ 1FAFBF1615A5FA5200083A20 /* UTIUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UTIUtilities.h; sourceTree = group; };
+ 1FAFBF1715A5FA5200083A20 /* UTIUtilities.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = UTIUtilities.mm; sourceTree = group; };
20D629241253690B00081543 /* InspectorInstrumentation.cpp */ = {isa =
[webkit-changes] [121924] trunk/Source/JavaScriptCore
Title: [121924] trunk/Source/_javascript_Core Revision 121924 Author oli...@apple.com Date 2012-07-05 13:36:37 -0700 (Thu, 05 Jul 2012) Log Message JSObjectCallAsFunction should thisConvert the provided thisObject https://bugs.webkit.org/show_bug.cgi?id=90628 Reviewed by Gavin Barraclough. Perform this conversion on the provided this object. * API/JSObjectRef.cpp: (JSObjectCallAsFunction): Modified Paths trunk/Source/_javascript_Core/API/JSObjectRef.cpp trunk/Source/_javascript_Core/ChangeLog Diff Modified: trunk/Source/_javascript_Core/API/JSObjectRef.cpp (121923 => 121924) --- trunk/Source/_javascript_Core/API/JSObjectRef.cpp 2012-07-05 20:19:08 UTC (rev 121923) +++ trunk/Source/_javascript_Core/API/JSObjectRef.cpp 2012-07-05 20:36:37 UTC (rev 121924) @@ -428,6 +428,8 @@ if (!jsThisObject) jsThisObject = exec-globalThisValue(); +jsThisObject = jsThisObject-methodTable()-toThisObject(jsThisObject, exec); + MarkedArgumentBuffer argList; for (size_t i = 0; i argumentCount; i++) argList.append(toJS(exec, arguments[i])); Modified: trunk/Source/_javascript_Core/ChangeLog (121923 => 121924) --- trunk/Source/_javascript_Core/ChangeLog 2012-07-05 20:19:08 UTC (rev 121923) +++ trunk/Source/_javascript_Core/ChangeLog 2012-07-05 20:36:37 UTC (rev 121924) @@ -1,3 +1,15 @@ +2012-07-05 Oliver Hunt oli...@apple.com + +JSObjectCallAsFunction should thisConvert the provided thisObject +https://bugs.webkit.org/show_bug.cgi?id=90628 + +Reviewed by Gavin Barraclough. + +Perform this conversion on the provided this object. + +* API/JSObjectRef.cpp: +(JSObjectCallAsFunction): + 2012-07-05 Zoltan Herczeg zherc...@webkit.org [Qt] Unreviewed buildfix after r121886. Typo fix. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121926] trunk/Source/WebCore
Title: [121926] trunk/Source/WebCore
Revision 121926
Author simon.fra...@apple.com
Date 2012-07-05 16:14:29 -0700 (Thu, 05 Jul 2012)
Log Message
Add a utility method for hasOverflowClip() or hasClip()
https://bugs.webkit.org/show_bug.cgi?id=90635
Reviewed by Dean Jackson.
Add RenderObject::hasClipOrOverflowClip() as a convenience method
since we end up calling hasOverfFlowClip() || hasClip() a lot in the layer code.
No new tests; refactoring only.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::calculateRects):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer):
(WebCore::RenderLayerCompositor::clipsCompositingDescendants):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasClipOrOverflowClip):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderObject.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (121925 => 121926)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 22:55:51 UTC (rev 121925)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 23:14:29 UTC (rev 121926)
@@ -1,3 +1,24 @@
+2012-07-05 Simon Fraser simon.fra...@apple.com
+
+Add a utility method for hasOverflowClip() or hasClip()
+https://bugs.webkit.org/show_bug.cgi?id=90635
+
+Reviewed by Dean Jackson.
+
+Add RenderObject::hasClipOrOverflowClip() as a convenience method
+since we end up calling hasOverfFlowClip() || hasClip() a lot in the layer code.
+
+No new tests; refactoring only.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::calculateClipRects):
+(WebCore::RenderLayer::calculateRects):
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer):
+(WebCore::RenderLayerCompositor::clipsCompositingDescendants):
+* rendering/RenderObject.h:
+(WebCore::RenderObject::hasClipOrOverflowClip):
+
2012-07-05 Yongjun Zhang yongjun_zh...@apple.com
Code refactoring: move mimeTypeFromUTITree to a separate file.
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (121925 => 121926)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-07-05 22:55:51 UTC (rev 121925)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-07-05 23:14:29 UTC (rev 121926)
@@ -3903,7 +3903,7 @@
clipRects.setOverflowClipRect(clipRects.posClipRect());
// Update the clip rects that will be passed to child layers.
-if (renderer()-hasOverflowClip() || renderer()-hasClip()) {
+if (renderer()-hasClipOrOverflowClip()) {
// This layer establishes a clip of some kind.
// This offset cannot use convertToLayerCoords, because sometimes our rootLayer may be across
@@ -3990,7 +3990,7 @@
layerBounds = LayoutRect(offset, size());
// Update the clip rects that will be passed to child layers.
-if (renderer()-hasOverflowClip() || renderer()-hasClip()) {
+if (renderer()-hasClipOrOverflowClip()) {
// This layer establishes a clip of some kind.
if (renderer()-hasOverflowClip()) {
foregroundRect.intersect(toRenderBox(renderer())-overflowClipRect(offset, region, relevancy));
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (121925 => 121926)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2012-07-05 22:55:51 UTC (rev 121925)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2012-07-05 23:14:29 UTC (rev 121926)
@@ -637,7 +637,7 @@
if (curr-isStackingContext())
return 0;
-if (curr-renderer()-hasOverflowClip() || curr-renderer()-hasClip())
+if (curr-renderer()-hasClipOrOverflowClip())
return curr;
}
return 0;
@@ -1610,8 +1610,7 @@
// into the hierarchy between this layer and its children in the z-order hierarchy.
bool RenderLayerCompositor::clipsCompositingDescendants(const RenderLayer* layer) const
{
-return layer-hasCompositingDescendant()
- (layer-renderer()-hasOverflowClip() || layer-renderer()-hasClip());
+return layer-hasCompositingDescendant() layer-renderer()-hasClipOrOverflowClip();
}
// Return true if there is an ancestor layer that is fixed positioned to the view.
Modified: trunk/Source/WebCore/rendering/RenderObject.h (121925 => 121926)
--- trunk/Source/WebCore/rendering/RenderObject.h 2012-07-05 22:55:51 UTC (rev 121925)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2012-07-05 23:14:29 UTC (rev 121926)
@@ -541,6 +541,7 @@
bool hasClip() const { return isOutOfFlowPositioned() style()-hasClip(); }
bool hasOverflowClip() const { return m_bitfields.hasOverflowClip(); }
+bool hasClipOrOverflowClip() const { return hasClip() || hasOverflowClip(); }
bool hasTransform() const { return
[webkit-changes] [121927] trunk/Source/WTF
Title: [121927] trunk/Source/WTF Revision 121927 Author fpi...@apple.com Date 2012-07-05 16:31:00 -0700 (Thu, 05 Jul 2012) Log Message INLINE_ARM_FUNCTION(thingy) should make thingy be thumb2 if we're using thumb2 https://bugs.webkit.org/show_bug.cgi?id=90644 Reviewed by Mark Hahnenberg. Fix breakage introduced in http://trac.webkit.org/changeset/121885 * wtf/InlineASM.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/InlineASM.h Diff Modified: trunk/Source/WTF/ChangeLog (121926 => 121927) --- trunk/Source/WTF/ChangeLog 2012-07-05 23:14:29 UTC (rev 121926) +++ trunk/Source/WTF/ChangeLog 2012-07-05 23:31:00 UTC (rev 121927) @@ -1,3 +1,14 @@ +2012-07-05 Filip Pizlo fpi...@apple.com + +INLINE_ARM_FUNCTION(thingy) should make thingy be thumb2 if we're using thumb2 +https://bugs.webkit.org/show_bug.cgi?id=90644 + +Reviewed by Mark Hahnenberg. + +Fix breakage introduced in http://trac.webkit.org/changeset/121885 + +* wtf/InlineASM.h: + 2012-07-05 Zoltan Herczeg zherc...@webkit.org Port DFG JIT to traditional ARM Modified: trunk/Source/WTF/wtf/InlineASM.h (121926 => 121927) --- trunk/Source/WTF/wtf/InlineASM.h 2012-07-05 23:14:29 UTC (rev 121926) +++ trunk/Source/WTF/wtf/InlineASM.h 2012-07-05 23:31:00 UTC (rev 121927) @@ -83,7 +83,7 @@ #define LOCAL_LABEL_STRING(name) .L #name #endif -#if CPU(ARM_TRADITIONAL) (defined(thumb2) || defined(__thumb2__) || defined(__thumb) || defined(__thumb__)) +#if (CPU(ARM_TRADITIONAL) (defined(thumb2) || defined(__thumb2__) || defined(__thumb) || defined(__thumb__))) || CPU(ARM_THUMB2) #define INLINE_ARM_FUNCTION(name) .thumb \n .thumb_func THUMB_FUNC_PARAM(name) \n #else #define INLINE_ARM_FUNCTION(name) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121928] trunk/Source/JavaScriptCore
Title: [121928] trunk/Source/_javascript_Core
Revision 121928
Author msab...@apple.com
Date 2012-07-05 17:04:05 -0700 (Thu, 05 Jul 2012)
Log Message
JSString::tryHashConstLock() fails to get exclusive lock
https://bugs.webkit.org/show_bug.cgi?id=90639
Reviewed by Oliver Hunt.
Added check that the string is already locked even before compare and swap.
* heap/MarkStack.cpp:
(JSC::JSString::tryHashConstLock):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MarkStack.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (121927 => 121928)
--- trunk/Source/_javascript_Core/ChangeLog 2012-07-05 23:31:00 UTC (rev 121927)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-07-06 00:04:05 UTC (rev 121928)
@@ -1,3 +1,15 @@
+2012-07-05 Michael Saboff msab...@apple.com
+
+JSString::tryHashConstLock() fails to get exclusive lock
+https://bugs.webkit.org/show_bug.cgi?id=90639
+
+Reviewed by Oliver Hunt.
+
+Added check that the string is already locked even before compare and swap.
+
+* heap/MarkStack.cpp:
+(JSC::JSString::tryHashConstLock):
+
2012-07-04 Filip Pizlo fpi...@apple.com
Inline property storage should not be wasted when it is exhausted
Modified: trunk/Source/_javascript_Core/heap/MarkStack.cpp (121927 => 121928)
--- trunk/Source/_javascript_Core/heap/MarkStack.cpp 2012-07-05 23:31:00 UTC (rev 121927)
+++ trunk/Source/_javascript_Core/heap/MarkStack.cpp 2012-07-06 00:04:05 UTC (rev 121928)
@@ -546,6 +546,10 @@
{
#if ENABLE(PARALLEL_GC)
unsigned currentFlags = m_flags;
+
+if (currentFlags HashConstLock)
+return false;
+
unsigned newFlags = currentFlags | HashConstLock;
if (!WTF::weakCompareAndSwap(m_flags, currentFlags, newFlags))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121929] trunk
Title: [121929] trunk
Revision 121929
Author benja...@webkit.org
Date 2012-07-05 17:20:44 -0700 (Thu, 05 Jul 2012)
Log Message
Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=90431
Patch by Benjamin Poulain bpoul...@apple.com on 2012-07-05
Reviewed by Anders Carlsson.
Source/WebCore:
In ResourceLoader::didFinishLoadingOnePart(), we invoke didFinishLoad() on the WebKit client. If WebKit
causes the current frame to cancel the load synchronously, the resources are already freed when
ResourceLoader::didFinishLoadingOnePart() ends.
When ResourceLoader::didFinishLoading() subsequently invokes releaseResources(), we are releasing the
resources a second time.
This patch add a second check for cancellation after invoking ResourceLoader::didFinishLoadingOnePart() to
avoid such issues.
The previous check at the beginning of ResourceLoader::didFinishLoading() has been removed because it is
redundant with ResourceLoader::didFinishLoadingOnePart().
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFinishLoadingOnePart):
Tools:
Add a Mac API test.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html: Added.
* TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm: Added.
(-[CancelLoadFromResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[CancelLoadFromResourceLoadDelegateFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html
trunk/Tools/TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (121928 => 121929)
--- trunk/Source/WebCore/ChangeLog 2012-07-06 00:04:05 UTC (rev 121928)
+++ trunk/Source/WebCore/ChangeLog 2012-07-06 00:20:44 UTC (rev 121929)
@@ -1,3 +1,26 @@
+2012-07-05 Benjamin Poulain bpoul...@apple.com
+
+Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
+https://bugs.webkit.org/show_bug.cgi?id=90431
+
+Reviewed by Anders Carlsson.
+
+In ResourceLoader::didFinishLoadingOnePart(), we invoke didFinishLoad() on the WebKit client. If WebKit
+causes the current frame to cancel the load synchronously, the resources are already freed when
+ResourceLoader::didFinishLoadingOnePart() ends.
+When ResourceLoader::didFinishLoading() subsequently invokes releaseResources(), we are releasing the
+resources a second time.
+
+This patch add a second check for cancellation after invoking ResourceLoader::didFinishLoadingOnePart() to
+avoid such issues.
+
+The previous check at the beginning of ResourceLoader::didFinishLoading() has been removed because it is
+redundant with ResourceLoader::didFinishLoadingOnePart().
+
+* loader/ResourceLoader.cpp:
+(WebCore::ResourceLoader::didFinishLoading):
+(WebCore::ResourceLoader::didFinishLoadingOnePart):
+
2012-07-05 Simon Fraser simon.fra...@apple.com
Add a utility method for hasOverflowClip() or hasClip()
Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (121928 => 121929)
--- trunk/Source/WebCore/loader/ResourceLoader.cpp 2012-07-06 00:04:05 UTC (rev 121928)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp 2012-07-06 00:20:44 UTC (rev 121929)
@@ -288,18 +288,19 @@
void ResourceLoader::didFinishLoading(double finishTime)
{
-// If load has been cancelled after finishing (which could happen with a
-// _javascript_ that changes the window location), do nothing.
+didFinishLoadingOnePart(finishTime);
+
+// If the load has been cancelled by a delegate in response to didFinishLoad(), do not release
+// the resources a second time, they have been released by cancel.
if (m_cancelled)
return;
-ASSERT(!m_reachedTerminalState);
-
-didFinishLoadingOnePart(finishTime);
releaseResources();
}
void ResourceLoader::didFinishLoadingOnePart(double finishTime)
{
+// If load has been cancelled after finishing (which could happen with a
+// _javascript_ that changes the window location), do nothing.
if (m_cancelled)
return;
ASSERT(!m_reachedTerminalState);
Modified: trunk/Tools/ChangeLog (121928 => 121929)
--- trunk/Tools/ChangeLog 2012-07-06 00:04:05 UTC (rev 121928)
+++ trunk/Tools/ChangeLog 2012-07-06 00:20:44 UTC (rev 121929)
@@ -1,3 +1,20 @@
+2012-07-05 Benjamin Poulain bpoul...@apple.com
+
+Double release of resources if the load is canceled in a callback of
[webkit-changes] [121930] trunk
Title: [121930] trunk
Revision 121930
Author hay...@chromium.org
Date 2012-07-05 17:26:39 -0700 (Thu, 05 Jul 2012)
Log Message
t/fuzzer-mouse-crash
patch description
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
Added Paths
trunk/LayoutTests/fast/events/display-none-on-focus-crash-expected.txt
trunk/LayoutTests/fast/events/display-none-on-focus-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (121929 => 121930)
--- trunk/LayoutTests/ChangeLog 2012-07-06 00:20:44 UTC (rev 121929)
+++ trunk/LayoutTests/ChangeLog 2012-07-06 00:26:39 UTC (rev 121930)
@@ -1,3 +1,13 @@
+2012-07-05 Hayato Ito hay...@chromium.org
+
+[Crash] Click an element which will be 'display: none' on focus.
+https://bugs.webkit.org/show_bug.cgi?id=90516
+
+Reviewed by Hajime Morita.
+
+* fast/events/display-none-on-focus-crash-expected.txt: Added.
+* fast/events/display-none-on-focus-crash.html: Added.
+
2012-07-05 Leandro Gracia Gil leandrogra...@chromium.org
Character iterators should not advance if they are at end
Added: trunk/LayoutTests/fast/events/display-none-on-focus-crash-expected.txt (0 => 121930)
--- trunk/LayoutTests/fast/events/display-none-on-focus-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/display-none-on-focus-crash-expected.txt 2012-07-06 00:26:39 UTC (rev 121930)
@@ -0,0 +1,2 @@
+Test passes if it does not crash.
+
Property changes on: trunk/LayoutTests/fast/events/display-none-on-focus-crash-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/events/display-none-on-focus-crash.html (0 => 121930)
--- trunk/LayoutTests/fast/events/display-none-on-focus-crash.html (rev 0)
+++ trunk/LayoutTests/fast/events/display-none-on-focus-crash.html 2012-07-06 00:26:39 UTC (rev 121930)
@@ -0,0 +1,29 @@
+!DOCTYPE html
+head
+style
+.c3 { padding-top: 200px; }
+.c3:focus { display: none; }
+/style
+/head
+body/body
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+var iframe1;
+function boom() {
+iframe1 = document.createElement('iframe');
+document.documentElement.appendChild(iframe1);
+document.documentElement.appendChild(document.createElement('li'));
+document.documentElement.appendChild(document.createElement('iframe'));
+iframe1.setAttribute('class', 'c3');
+eventSender.mouseMoveTo(1000, 100);
+eventSender.mouseDown();
+eventSender.mouseUp();
+eventSender.mouseDown();
+eventSender.mouseUp();
+eventSender.mouseMoveTo(100, 100);
+eventSender.mouseDown();
+document.body.innerHTML = 'Test passes if it does not crash.'
+}
+window._onload_ = boom;
+/script
Property changes on: trunk/LayoutTests/fast/events/display-none-on-focus-crash.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (121929 => 121930)
--- trunk/Source/WebCore/ChangeLog 2012-07-06 00:20:44 UTC (rev 121929)
+++ trunk/Source/WebCore/ChangeLog 2012-07-06 00:26:39 UTC (rev 121930)
@@ -1,3 +1,25 @@
+2012-07-05 Hayato Ito hay...@chromium.org
+
+[Crash] Click an element which will be 'display: none' on focus.
+https://bugs.webkit.org/show_bug.cgi?id=90516
+
+Reviewed by Hajime Morita.
+
+EventHandler::handleMousePressEventSingleClick checks whether
+innerNode has a renderer in the beginning of the function. But
+the renderer may disappear in the middle of the function since its
+style has just become 'display:none'. As a result, it touches null renderer
+in EventHandler.cpp:517:
+VisiblePosition visiblePos(innerNode-renderer()-positionForPoint(event.localPoint()));
+In the case of 'display:none', we don't have to continue. So call
+updateLayoutIgnorePendingStylesheets() in the beginning so that we
+can early exit and do not touch null renderer.
+
+Test: fast/events/display-none-on-focus-crash.html
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::handleMousePressEventSingleClick):
+
2012-07-05 Benjamin Poulain bpoul...@apple.com
Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
Modified: trunk/Source/WebCore/page/EventHandler.cpp (121929 => 121930)
--- trunk/Source/WebCore/page/EventHandler.cpp 2012-07-06 00:20:44 UTC (rev 121929)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2012-07-06 00:26:39 UTC (rev 121930)
@@ -496,6 +496,7 @@
bool EventHandler::handleMousePressEventSingleClick(const MouseEventWithHitTestResults event)
{
+m_frame-document()-updateLayoutIgnorePendingStylesheets();
Node* innerNode = targetNode(event);
if (!(innerNode innerNode-renderer() m_mouseDownMayStartSelect))
return false;
[webkit-changes] [121931] trunk/Source/WebKit/blackberry
Title: [121931] trunk/Source/WebKit/blackberry
Revision 121931
Author charles@torchmobile.com.cn
Date 2012-07-05 18:05:46 -0700 (Thu, 05 Jul 2012)
Log Message
[BlackBerry] Fix the build error introduced by enabling CUSTOM_THEME_HANDLER
https://bugs.webkit.org/show_bug.cgi?id=90588
Reviewed by Rob Buis.
Fix the build error introduced by enabling CUSTOM_THEME_HANDLER.
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (121930 => 121931)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-07-06 00:26:39 UTC (rev 121930)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-07-06 01:05:46 UTC (rev 121931)
@@ -1,3 +1,14 @@
+2012-07-05 Charles Wei charles@torchmobile.com.cn
+
+[BlackBerry] Fix the build error introduced by enabling CUSTOM_THEME_HANDLER
+https://bugs.webkit.org/show_bug.cgi?id=90588
+
+Reviewed by Rob Buis.
+
+Fix the build error introduced by enabling CUSTOM_THEME_HANDLER.
+* WebCoreSupport/ChromeClientBlackBerry.cpp:
+(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
+
2012-07-04 Hanna Ma ha...@rim.com
[BlackBerry] Implement device metrics for blackberry.
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (121930 => 121931)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-07-06 00:26:39 UTC (rev 121930)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-07-06 01:05:46 UTC (rev 121931)
@@ -810,9 +810,9 @@
}
#if ENABLE(CUSTOM_SCHEME_HANDLER)
-CustomHandlersState ChromeClientBlackBerry::isProtocolHandlerRegistered(const String, const String, const String)
+ChromeClient::CustomHandlersState ChromeClientBlackBerry::isProtocolHandlerRegistered(const String, const String, const String)
{
-return CustomHandlersDeclined;
+return ChromeClient::CustomHandlersDeclined;
}
void ChromeClientBlackBerry::unregisterProtocolHandler(const String, const String, const String)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121932] trunk/Source
Title: [121932] trunk/Source Revision 121932 Author ander...@apple.com Date 2012-07-05 18:24:38 -0700 (Thu, 05 Jul 2012) Log Message Type-ahead doesn't work in options inside optgroups https://bugs.webkit.org/show_bug.cgi?id=90647 rdar://problem/5604894 Reviewed by Dan Bernstein. Set the title of the menu item to a string that doesn't contain any leading or trailing whitespace. Source/WebCore: * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenuMac::populate): Source/WebKit2: * UIProcess/mac/WebPopupMenuProxyMac.mm: (WebKit::WebPopupMenuProxyMac::populate): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/mac/PopupMenuMac.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (121931 => 121932) --- trunk/Source/WebCore/ChangeLog 2012-07-06 01:05:46 UTC (rev 121931) +++ trunk/Source/WebCore/ChangeLog 2012-07-06 01:24:38 UTC (rev 121932) @@ -1,3 +1,16 @@ +2012-07-05 Anders Carlsson ander...@apple.com + +Type-ahead doesn't work in options inside optgroups +https://bugs.webkit.org/show_bug.cgi?id=90647 +rdar://problem/5604894 + +Reviewed by Dan Bernstein. + +Set the title of the menu item to a string that doesn't contain any leading or trailing whitespace. + +* platform/mac/PopupMenuMac.mm: +(WebCore::PopupMenuMac::populate): + 2012-07-05 Hayato Ito hay...@chromium.org [Crash] Click an element which will be 'display: none' on focus. Modified: trunk/Source/WebCore/platform/mac/PopupMenuMac.mm (121931 => 121932) --- trunk/Source/WebCore/platform/mac/PopupMenuMac.mm 2012-07-06 01:05:46 UTC (rev 121931) +++ trunk/Source/WebCore/platform/mac/PopupMenuMac.mm 2012-07-06 01:24:38 UTC (rev 121932) @@ -119,6 +119,9 @@ [m_popup.get() addItemWithTitle:@]; NSMenuItem *menuItem = [m_popup.get() lastItem]; [menuItem setAttributedTitle:string]; +// We set the title as well as the attributed title here. The attributed title will be displayed in the menu, +// but typeahead will use the non-attributed string that doesn't contain any leading or trailing whitespace. +[menuItem setTitle:[[string string] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceCharacterSet]]]; [menuItem setEnabled:client()-itemIsEnabled(i)]; [menuItem setToolTip:client()-itemToolTip(i)]; [string release]; Modified: trunk/Source/WebKit2/ChangeLog (121931 => 121932) --- trunk/Source/WebKit2/ChangeLog 2012-07-06 01:05:46 UTC (rev 121931) +++ trunk/Source/WebKit2/ChangeLog 2012-07-06 01:24:38 UTC (rev 121932) @@ -1,3 +1,16 @@ +2012-07-05 Anders Carlsson ander...@apple.com + +Type-ahead doesn't work in options inside optgroups +https://bugs.webkit.org/show_bug.cgi?id=90647 +rdar://problem/5604894 + +Reviewed by Dan Bernstein. + +Set the title of the menu item to a string that doesn't contain any leading or trailing whitespace. + +* UIProcess/mac/WebPopupMenuProxyMac.mm: +(WebKit::WebPopupMenuProxyMac::populate): + 2012-07-05 Christophe Dumez christophe.du...@intel.com [WK2] Add C API for Battery Status API Modified: trunk/Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm (121931 => 121932) --- trunk/Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm 2012-07-06 01:05:46 UTC (rev 121931) +++ trunk/Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm 2012-07-06 01:24:38 UTC (rev 121932) @@ -87,6 +87,9 @@ RetainPtrNSAttributedString string(AdoptNS, [[NSAttributedString alloc] initWithString:nsStringFromWebCoreString(items[i].m_text) attributes:attributes.get()]); [menuItem setAttributedTitle:string.get()]; +// We set the title as well as the attributed title here. The attributed title will be displayed in the menu, +// but typeahead will use the non-attributed string that doesn't contain any leading or trailing whitespace. +[menuItem setTitle:[[string.get() string] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceCharacterSet]]]; [menuItem setEnabled:items[i].m_isEnabled]; [menuItem setToolTip:nsStringFromWebCoreString(items[i].m_toolTip)]; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121933] trunk
Title: [121933] trunk
Revision 121933
Author commit-qu...@webkit.org
Date 2012-07-05 18:27:35 -0700 (Thu, 05 Jul 2012)
Log Message
Unreviewed, rolling out r121921.
http://trac.webkit.org/changeset/121921
https://bugs.webkit.org/show_bug.cgi?id=90648
caused hundreds of crashes on Mac (Requested by pizlo on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-07-05
Source/WebCore:
* editing/SurroundingText.cpp:
(WebCore::SurroundingText::SurroundingText):
* editing/TextIterator.cpp:
(WebCore::CharacterIterator::advance):
(WebCore::BackwardsCharacterIterator::advance):
LayoutTests:
* platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
* platform/chromium/editing/surrounding-text/surrounding-text.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text-expected.txt
trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/SurroundingText.cpp
trunk/Source/WebCore/editing/TextIterator.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (121932 => 121933)
--- trunk/LayoutTests/ChangeLog 2012-07-06 01:24:38 UTC (rev 121932)
+++ trunk/LayoutTests/ChangeLog 2012-07-06 01:27:35 UTC (rev 121933)
@@ -1,3 +1,15 @@
+2012-07-05 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r121921.
+http://trac.webkit.org/changeset/121921
+https://bugs.webkit.org/show_bug.cgi?id=90648
+
+caused hundreds of crashes on Mac (Requested by pizlo on
+#webkit).
+
+* platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
+* platform/chromium/editing/surrounding-text/surrounding-text.html:
+
2012-07-05 Hayato Ito hay...@chromium.org
[Crash] Click an element which will be 'display: none' on focus.
Modified: trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text-expected.txt (121932 => 121933)
--- trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text-expected.txt 2012-07-06 01:24:38 UTC (rev 121932)
+++ trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text-expected.txt 2012-07-06 01:27:35 UTC (rev 121933)
@@ -15,7 +15,6 @@
PASS surroundingText('button./buttondiv id=here012345678901234567890123456789/divbutton./button', 15, 12) is 901234567890
PASS surroundingText('option./option12345button id=heretest/buttonoption./option', 0, 100) is
PASS surroundingText('option./option12345buttontespan id=herest/span/buttonoption./option', 0, 100) is
-PASS surroundingText('p id=here.', 0, 2) is .
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text.html (121932 => 121933)
--- trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text.html 2012-07-06 01:24:38 UTC (rev 121932)
+++ trunk/LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text.html 2012-07-06 01:27:35 UTC (rev 121933)
@@ -40,7 +40,6 @@
shouldBeEqualToString('surroundingText(\'button./buttondiv id=here012345678901234567890123456789/divbutton./button\', 15, 12)', '901234567890');
shouldBeEqualToString('surroundingText(\'option./option12345button id=heretest/buttonoption./option\', 0, 100)', '');
shouldBeEqualToString('surroundingText(\'option./option12345buttontespan id=herest/span/buttonoption./option\', 0, 100)', '');
-shouldBeEqualToString('surroundingText(\'p id=here.\', 0, 2)', '.');
document.body.removeChild(document.getElementById('test'));
finishJSTest();
Modified: trunk/Source/WebCore/ChangeLog (121932 => 121933)
--- trunk/Source/WebCore/ChangeLog 2012-07-06 01:24:38 UTC (rev 121932)
+++ trunk/Source/WebCore/ChangeLog 2012-07-06 01:27:35 UTC (rev 121933)
@@ -1,3 +1,18 @@
+2012-07-05 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r121921.
+http://trac.webkit.org/changeset/121921
+https://bugs.webkit.org/show_bug.cgi?id=90648
+
+caused hundreds of crashes on Mac (Requested by pizlo on
+#webkit).
+
+* editing/SurroundingText.cpp:
+(WebCore::SurroundingText::SurroundingText):
+* editing/TextIterator.cpp:
+(WebCore::CharacterIterator::advance):
+(WebCore::BackwardsCharacterIterator::advance):
+
2012-07-05 Anders Carlsson ander...@apple.com
Type-ahead doesn't work in options inside optgroups
Modified: trunk/Source/WebCore/editing/SurroundingText.cpp (121932 => 121933)
--- trunk/Source/WebCore/editing/SurroundingText.cpp 2012-07-06 01:24:38 UTC (rev 121932)
+++ trunk/Source/WebCore/editing/SurroundingText.cpp 2012-07-06 01:27:35 UTC (rev 121933)
@@ -45,8 +45,7 @@
{
const unsigned halfMaxLength = maxLength / 2;
CharacterIterator forwardIterator(makeRange(visiblePosition, endOfDocument(visiblePosition)).get(),
[webkit-changes] [121934] trunk/Source/WebKit2
Title: [121934] trunk/Source/WebKit2
Revision 121934
Author commit-qu...@webkit.org
Date 2012-07-05 18:47:55 -0700 (Thu, 05 Jul 2012)
Log Message
[WK2][EFL] Ewk_View should provide API to set/get device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=90590
Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Add API to Ewk_View so retrieve and set the device
pixel ratio.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
* UIProcess/API/efl/ewk_view.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (121933 => 121934)
--- trunk/Source/WebKit2/ChangeLog 2012-07-06 01:27:35 UTC (rev 121933)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-06 01:47:55 UTC (rev 121934)
@@ -1,3 +1,18 @@
+2012-07-05 Christophe Dumez christophe.du...@intel.com
+
+[WK2][EFL] Ewk_View should provide API to set/get device pixel ratio
+https://bugs.webkit.org/show_bug.cgi?id=90590
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add API to Ewk_View so retrieve and set the device
+pixel ratio.
+
+* UIProcess/API/efl/ewk_view.cpp:
+(ewk_view_device_pixel_ratio_set):
+(ewk_view_device_pixel_ratio_get):
+* UIProcess/API/efl/ewk_view.h:
+
2012-07-05 Anders Carlsson ander...@apple.com
Type-ahead doesn't work in options inside optgroups
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (121933 => 121934)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-07-06 01:27:35 UTC (rev 121933)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-07-06 01:47:55 UTC (rev 121934)
@@ -603,6 +603,23 @@
return WKPageGetEstimatedProgress(toAPI(priv-pageClient-page()));
}
+Eina_Bool ewk_view_device_pixel_ratio_set(Evas_Object* ewkView, float ratio)
+{
+EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
+EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
+
+priv-pageClient-page()-setCustomDeviceScaleFactor(ratio);
+return true;
+}
+
+float ewk_view_device_pixel_ratio_get(const Evas_Object* ewkView)
+{
+EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 1);
+EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, 1);
+
+return priv-pageClient-page()-deviceScaleFactor();
+}
+
/**
* @internal
* Reports load progress changed.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h (121933 => 121934)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-07-06 01:27:35 UTC (rev 121933)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-07-06 01:47:55 UTC (rev 121934)
@@ -311,6 +311,54 @@
*/
EAPI Eina_Bool ewk_view_html_string_load(Evas_Object *o, const char *html, const char *baseUrl, const char *unreachableUrl);
+/**
+ * Queries the ratio between the CSS units and device pixels when the content is unscaled.
+ *
+ * When designing touch-friendly contents, knowing the approximated target size on a device
+ * is important for contents providers in order to get the intented layout and element
+ * sizes.
+ *
+ * As most first generation touch devices had a PPI of approximately 160, this became a
+ * de-facto value, when used in conjunction with the viewport meta tag.
+ *
+ * Devices with a higher PPI learning towards 240 or 320, applies a pre-scaling on all
+ * content, of either 1.5 or 2.0, not affecting the CSS scale or pinch zooming.
+ *
+ * This value can be set using this property and it is exposed to CSS media queries using
+ * the -webkit-device-pixel-ratio query.
+ *
+ * For instance, if you want to load an image without having it upscaled on a web view
+ * using a device pixel ratio of 2.0 it can be done by loading an image of say 100x100
+ * pixels but showing it at half the size.
+ *
+ * @media (-webkit-min-device-pixel-ratio: 1.5) {
+ * .icon {
+ * width: 50px;
+ * height: 50px;
+ * url: /images/i...@2x.png; // This is actually a 100x100 image
+ * }
+ * }
+ *
+ * If the above is used on a device with device pixel ratio of 1.5, it will be scaled
+ * down but still provide a better looking image.
+ *
+ * @param o view object to get device pixel ratio
+ *
+ * @return the ratio between the CSS units and device pixels.
+ */
+EAPI float ewk_view_device_pixel_ratio_get(const Evas_Object *o);
+
+/**
+ * Sets the ratio between the CSS units and device pixels when the content is unscaled.
+ *
+ * @param o view object to set device pixel ratio
+ *
+ * @return @c EINA_TRUE if the device pixel ratio was set, @c EINA_FALSE otherwise
+ *
+ * @see ewk_view_device_pixel_ratio_get()
+ */
+EAPI Eina_Bool ewk_view_device_pixel_ratio_set(Evas_Object *o, float ratio);
+
#ifdef __cplusplus
}
#endif
___
webkit-changes mailing list
[webkit-changes] [121935] trunk/LayoutTests
Title: [121935] trunk/LayoutTests Revision 121935 Author fpi...@apple.com Date 2012-07-05 18:55:14 -0700 (Thu, 05 Jul 2012) Log Message Unreviewed, skipping failing tests. * platform/mac/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (121934 => 121935) --- trunk/LayoutTests/ChangeLog 2012-07-06 01:47:55 UTC (rev 121934) +++ trunk/LayoutTests/ChangeLog 2012-07-06 01:55:14 UTC (rev 121935) @@ -1,3 +1,9 @@ +2012-07-05 Filip Pizlo fpi...@apple.com + +Unreviewed, skipping failing tests. + +* platform/mac/Skipped: + 2012-07-05 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r121921. Modified: trunk/LayoutTests/platform/mac/Skipped (121934 => 121935) --- trunk/LayoutTests/platform/mac/Skipped 2012-07-06 01:47:55 UTC (rev 121934) +++ trunk/LayoutTests/platform/mac/Skipped 2012-07-06 01:55:14 UTC (rev 121935) @@ -903,3 +903,7 @@ # https://bugs.webkit.org/show_bug.cgi?id=89845 fast/forms/input-set-composition-scroll.html + +# https://bugs.webkit.org/show_bug.cgi?id=90649 +fast/canvas/webgl/tex-image-with-format-and-type.html +fast/canvas/webgl/tex-sub-image-2d.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121936] trunk
Title: [121936] trunk
Revision 121936
Author commit-qu...@webkit.org
Date 2012-07-05 19:50:57 -0700 (Thu, 05 Jul 2012)
Log Message
Multiple Content Security Policy headers are correctly processed as separate headers.
https://bugs.webkit.org/show_bug.cgi?id=90629
Source/WebCore:
Headers of the same name are normalized into a single, comma-separated
string as per RFC2616, section 4.2. We didn't correctly account for this
in ContentSecurityPolicy::didReceiveHeader. Now we do by walking through
the header string, looking for commas and processing each block in turn.
This oversight bit Firefox as well, and was patched in February:
https://bugzilla.mozilla.org/show_bug.cgi?id=717511
Patch by Mike West mk...@chromium.org on 2012-07-05
Reviewed by Adam Barth.
Test: http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
LayoutTests:
Patch by Mike West mk...@chromium.org on 2012-07-05
Reviewed by Adam Barth.
* http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html: Added.
* http/tests/security/contentSecurityPolicy/resources/echo-multiple-headers.pl: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ContentSecurityPolicy.cpp
Added Paths
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-multiple-headers.pl
Diff
Modified: trunk/LayoutTests/ChangeLog (121935 => 121936)
--- trunk/LayoutTests/ChangeLog 2012-07-06 01:55:14 UTC (rev 121935)
+++ trunk/LayoutTests/ChangeLog 2012-07-06 02:50:57 UTC (rev 121936)
@@ -1,3 +1,14 @@
+2012-07-05 Mike West mk...@chromium.org
+
+Multiple Content Security Policy headers are correctly processed as separate headers.
+https://bugs.webkit.org/show_bug.cgi?id=90629
+
+Reviewed by Adam Barth.
+
+* http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt: Added.
+* http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html: Added.
+* http/tests/security/contentSecurityPolicy/resources/echo-multiple-headers.pl: Added.
+
2012-07-05 Filip Pizlo fpi...@apple.com
Unreviewed, skipping failing tests.
Added: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt (0 => 121936)
--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt 2012-07-06 02:50:57 UTC (rev 121936)
@@ -0,0 +1,12 @@
+CONSOLE MESSAGE: Unrecognized Content-Security-Policy directive 'allow'.
+
+CONSOLE MESSAGE: Refused to load the script 'http://localhost:8000/security/contentSecurityPolicy/resources/script.js' because it violates the following Content Security Policy directive: default-src 'self'.
+
+This script should not execute even through the second CSP header would allow it.
+
+
+
+
+Frame: '!--framePath //!--frame0'
+
+PASS
Added: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html (0 => 121936)
--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html (rev 0)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html 2012-07-06 02:50:57 UTC (rev 121936)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+head
+script
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.dumpChildFramesAsText();
+}
+/script
+/head
+body
+ p
+This script should not execute even through the second CSP header would allow it.
+ /p
+ iframe src=""
+/body
+/html
Added: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-multiple-headers.pl (0 => 121936)
--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-multiple-headers.pl (rev 0)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-multiple-headers.pl 2012-07-06 02:50:57 UTC (rev 121936)
@@ -0,0 +1,22 @@
+#!/usr/bin/perl -wT
+use strict;
+use CGI;
+
+my $cgi = new CGI;
+
+print Content-Type: text/html; charset=UTF-8\n;
+print X-WebKit-CSP: .$cgi-param('csp1').\n;
+print X-WebKit-CSP: .$cgi-param('csp2').\n\n;
+
+my ($text, $replacement) = (FAIL, PASS);
+($text, $replacement) = ($replacement, $text) if $cgi-param('should_run') eq 'no';
+
+print !DOCTYPE html\n;
+print html\n;
+print
[webkit-changes] [121937] trunk/Source/WebKit/chromium
Title: [121937] trunk/Source/WebKit/chromium
Revision 121937
Author yo...@chromium.org
Date 2012-07-05 20:33:47 -0700 (Thu, 05 Jul 2012)
Log Message
Unreviewed Chromium gardening - Disable WebAnimationTest for Linux and Windows.
https://bugs.webkit.org/show_bug.cgi?id=90651
* tests/WebAnimationTest.cpp:
(WebKit):
(WebKit::TEST):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/WebAnimationTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (121936 => 121937)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-06 02:50:57 UTC (rev 121936)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-06 03:33:47 UTC (rev 121937)
@@ -1,3 +1,12 @@
+2012-07-05 Yoshifumi Inoue yo...@chromium.org
+
+Unreviewed Chromium gardening - Disable WebAnimationTest for Linux and Windows.
+https://bugs.webkit.org/show_bug.cgi?id=90651
+
+* tests/WebAnimationTest.cpp:
+(WebKit):
+(WebKit::TEST):
+
2012-07-05 Ian Vollick voll...@chromium.org
[chromium] Create a WebKit::Web* wrapper for the cc animation classes
Modified: trunk/Source/WebKit/chromium/tests/WebAnimationTest.cpp (121936 => 121937)
--- trunk/Source/WebKit/chromium/tests/WebAnimationTest.cpp 2012-07-06 02:50:57 UTC (rev 121936)
+++ trunk/Source/WebKit/chromium/tests/WebAnimationTest.cpp 2012-07-06 03:33:47 UTC (rev 121937)
@@ -35,7 +35,16 @@
namespace {
-TEST(WebAnimationTest, DefaultSettings)
+// Linux/Win bots failed on this test.
+// https://bugs.webkit.org/show_bug.cgi?id=90651
+#if OS(WINDOWS)
+#define MAYBE_DefaultSettings DISABLED_DefaultSettings
+#elif OS(LINUX)
+#define MAYBE_DefaultSettings DISABLED_DefaultSettings
+#else
+#define MAYBE_DefaultSettings DefaultSettings
+#endif
+TEST(WebAnimationTest, MAYBE_DefaultSettings)
{
WebFloatAnimationCurve curve;
WebAnimation animation(curve, WebAnimation::WebAnimationOpacity);
@@ -47,7 +56,16 @@
EXPECT_FALSE(animation.alternatesDirection());
}
-TEST(WebAnimationTest, ModifiedSettings)
+// Linux/Win bots failed on this test.
+// https://bugs.webkit.org/show_bug.cgi?id=90651
+#if OS(WINDOWS)
+#define MAYBE_ModifiedSettings DISABLED_ModifiedSettings
+#elif OS(LINUX)
+#define MAYBE_ModifiedSettings DISABLED_ModifiedSettings
+#else
+#define MAYBE_ModifiedSettings ModifiedSettings
+#endif
+TEST(WebAnimationTest, MAYBE_ModifiedSettings)
{
WebFloatAnimationCurve curve;
WebAnimation animation(curve, WebAnimation::WebAnimationOpacity);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121938] trunk/Source/WebCore
Title: [121938] trunk/Source/WebCore Revision 121938 Author commit-qu...@webkit.org Date 2012-07-05 20:47:27 -0700 (Thu, 05 Jul 2012) Log Message [EFL] Unreviewed, Fix build break when WEB_AUDIO is enabled. https://bugs.webkit.org/show_bug.cgi?id=90653 Unreviewed build fix. A new file, AudioFIFO.cpp, is added for the Web Audio fearure. This file should be included into the CMakeLists.txt file. Patch by Dongwoo Im dw...@samsung.com on 2012-07-05 * CMakeLists.txt: Add the newly created file into the CMakeLists.txt Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/CMakeLists.txt (121937 => 121938) --- trunk/Source/WebCore/CMakeLists.txt 2012-07-06 03:33:47 UTC (rev 121937) +++ trunk/Source/WebCore/CMakeLists.txt 2012-07-06 03:47:27 UTC (rev 121938) @@ -2589,6 +2589,7 @@ platform/audio/AudioBus.cpp platform/audio/AudioChannel.cpp platform/audio/AudioDSPKernelProcessor.cpp +platform/audio/AudioFIFO.cpp platform/audio/AudioPullFIFO.cpp platform/audio/AudioResampler.cpp platform/audio/AudioResamplerKernel.cpp Modified: trunk/Source/WebCore/ChangeLog (121937 => 121938) --- trunk/Source/WebCore/ChangeLog 2012-07-06 03:33:47 UTC (rev 121937) +++ trunk/Source/WebCore/ChangeLog 2012-07-06 03:47:27 UTC (rev 121938) @@ -1,3 +1,15 @@ +2012-07-05 Dongwoo Im dw...@samsung.com + +[EFL] Unreviewed, Fix build break when WEB_AUDIO is enabled. +https://bugs.webkit.org/show_bug.cgi?id=90653 + +Unreviewed build fix. + +A new file, AudioFIFO.cpp, is added for the Web Audio fearure. +This file should be included into the CMakeLists.txt file. + +* CMakeLists.txt: Add the newly created file into the CMakeLists.txt + 2012-07-05 Mike West mk...@chromium.org Multiple Content Security Policy headers are correctly processed as separate headers. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121939] trunk/LayoutTests
Title: [121939] trunk/LayoutTests Revision 121939 Author yo...@chromium.org Date 2012-07-05 20:57:04 -0700 (Thu, 05 Jul 2012) Log Message Unreviewed Chromium gardening - Rebaseline for r121917. * platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed. * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed. * platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: * platform/chromium-mac/fast/html/details-marker-style-expected.png: * platform/chromium-mac/fast/html/details-marker-style-expected.txt: * platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: * platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: * platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: * platform/chromium-win/fast/html/details-marker-style-expected.png: * platform/chromium-win/fast/html/details-marker-style-expected.txt: * platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: * platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: * platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/fast/html/details-marker-style-expected.png trunk/LayoutTests/platform/chromium-mac/fast/html/details-marker-style-expected.txt trunk/LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt trunk/LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png trunk/LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png trunk/LayoutTests/platform/chromium-win/fast/html/details-marker-style-expected.png trunk/LayoutTests/platform/chromium-win/fast/html/details-marker-style-expected.txt trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (121938 => 121939) --- trunk/LayoutTests/ChangeLog 2012-07-06 03:47:27 UTC (rev 121938) +++ trunk/LayoutTests/ChangeLog 2012-07-06 03:57:04 UTC (rev 121939) @@ -1,3 +1,21 @@ +2012-07-05 Yoshifumi Inoue yo...@chromium.org + +Unreviewed Chromium gardening - Rebaseline for r121917. + +* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed. +* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed. +* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: +* platform/chromium-mac/fast/html/details-marker-style-expected.png: +* platform/chromium-mac/fast/html/details-marker-style-expected.txt: +* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: +* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: +* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: +* platform/chromium-win/fast/html/details-marker-style-expected.png: +* platform/chromium-win/fast/html/details-marker-style-expected.txt: +* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: +* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: +* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: + 2012-07-05 Mike West mk...@chromium.org Multiple Content Security Policy headers are correctly processed as separate headers. Deleted: trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt (121938 => 121939) --- trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt 2012-07-06 03:47:27 UTC (rev 121938) +++ trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt 2012-07-06 03:57:04 UTC (rev 121939) @@ -1,62 +0,0 @@ -layer at (0,0) size 800x600 - RenderView at (0,0) size 800x600
[webkit-changes] [121940] trunk/Source/WebKit/chromium
Title: [121940] trunk/Source/WebKit/chromium
Revision 121940
Author yo...@chromium.org
Date 2012-07-05 21:09:40 -0700 (Thu, 05 Jul 2012)
Log Message
Unreviewed Chromium gardening. Roll Chromium DEPS
* DEPS: 145501 = 145569
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (121939 => 121940)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-06 03:57:04 UTC (rev 121939)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-06 04:09:40 UTC (rev 121940)
@@ -1,5 +1,11 @@
2012-07-05 Yoshifumi Inoue yo...@chromium.org
+Unreviewed Chromium gardening. Roll Chromium DEPS
+
+* DEPS: 145501 = 145569
+
+2012-07-05 Yoshifumi Inoue yo...@chromium.org
+
Unreviewed Chromium gardening - Disable WebAnimationTest for Linux and Windows.
https://bugs.webkit.org/show_bug.cgi?id=90651
Modified: trunk/Source/WebKit/chromium/DEPS (121939 => 121940)
--- trunk/Source/WebKit/chromium/DEPS 2012-07-06 03:57:04 UTC (rev 121939)
+++ trunk/Source/WebKit/chromium/DEPS 2012-07-06 04:09:40 UTC (rev 121940)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '145501'
+ 'chromium_rev': '145569'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121941] trunk/Tools
Title: [121941] trunk/Tools Revision 121941 Author jason@torchmobile.com.cn Date 2012-07-05 21:25:11 -0700 (Thu, 05 Jul 2012) Log Message Add Jason Liu to committers.py. https://bugs.webkit.org/show_bug.cgi?id=90654 Unreviewed. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (121940 => 121941) --- trunk/Tools/ChangeLog 2012-07-06 04:09:40 UTC (rev 121940) +++ trunk/Tools/ChangeLog 2012-07-06 04:25:11 UTC (rev 121941) @@ -1,3 +1,12 @@ +2012-07-05 Jason Liu jason@torchmobile.com.cn + +Add Jason Liu to committers.py. +https://bugs.webkit.org/show_bug.cgi?id=90654 + +Unreviewed. + +* Scripts/webkitpy/common/config/committers.py: + 2012-07-05 Benjamin Poulain bpoul...@apple.com Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (121940 => 121941) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-07-06 04:09:40 UTC (rev 121940) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-07-06 04:25:11 UTC (rev 121941) @@ -267,6 +267,7 @@ Committer(James Kozianski, [k...@chromium.org, k...@google.com], koz), Committer(James Simonsen, simon...@chromium.org, simonjam), Committer(Jarred Nicholls, [jar...@webkit.org, jar...@sencha.com], jarrednicholls), +Committer(Jason Liu, [jason@torchmobile.com.cn, jasonliuweb...@gmail.com], jasonliu), Committer(Jay Civelli, jcive...@chromium.org, jcivelli), Committer(Jeff Miller, je...@apple.com, jeffm7), Committer(Jeffrey Pfau, [jeff...@endrift.com, jp...@apple.com], jpfau), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121942] trunk/Source/WebKit2
Title: [121942] trunk/Source/WebKit2 Revision 121942 Author commit-qu...@webkit.org Date 2012-07-05 21:31:26 -0700 (Thu, 05 Jul 2012) Log Message [Qt] Transform should be applied to the clip rect in QRawWebView::paint https://bugs.webkit.org/show_bug.cgi?id=90652 Patch by Luiz Agostini luiz.agost...@nokia.com on 2012-07-05 Reviewed by Kenneth Rohde Christiansen. Applying the transformation matrix to the clip rect in QRawWebView::paint. * UIProcess/API/qt/raw/qrawwebview.cpp: (QRawWebView::paint): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (121941 => 121942) --- trunk/Source/WebKit2/ChangeLog 2012-07-06 04:25:11 UTC (rev 121941) +++ trunk/Source/WebKit2/ChangeLog 2012-07-06 04:31:26 UTC (rev 121942) @@ -1,3 +1,15 @@ +2012-07-05 Luiz Agostini luiz.agost...@nokia.com + +[Qt] Transform should be applied to the clip rect in QRawWebView::paint +https://bugs.webkit.org/show_bug.cgi?id=90652 + +Reviewed by Kenneth Rohde Christiansen. + +Applying the transformation matrix to the clip rect in QRawWebView::paint. + +* UIProcess/API/qt/raw/qrawwebview.cpp: +(QRawWebView::paint): + 2012-07-05 Christophe Dumez christophe.du...@intel.com [WK2][EFL] Ewk_View should provide API to set/get device pixel ratio Modified: trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp (121941 => 121942) --- trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp 2012-07-06 04:25:11 UTC (rev 121941) +++ trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp 2012-07-06 04:31:26 UTC (rev 121942) @@ -360,7 +360,7 @@ WebCore::FloatRect rect(0, 0, d-m_size.width(), d-m_size.height()); -renderer-paintToCurrentGLContext(transform, opacity, rect, paintFlags); +renderer-paintToCurrentGLContext(transform, opacity, transform.mapRect(rect), paintFlags); } void QRawWebView::sendKeyEvent(QKeyEvent* event) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121943] trunk/Source/JavaScriptCore
Title: [121943] trunk/Source/_javascript_Core Revision 121943 Author o...@webkit.org Date 2012-07-05 21:52:26 -0700 (Thu, 05 Jul 2012) Log Message [Qt] Unreviewed 64 bit buildfix after r121925. * bytecode/PutByIdStatus.cpp: (JSC::PutByIdStatus::computeFromLLInt): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/PutByIdStatus.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (121942 => 121943) --- trunk/Source/_javascript_Core/ChangeLog 2012-07-06 04:31:26 UTC (rev 121942) +++ trunk/Source/_javascript_Core/ChangeLog 2012-07-06 04:52:26 UTC (rev 121943) @@ -1,3 +1,10 @@ +2012-07-05 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed 64 bit buildfix after r121925. + +* bytecode/PutByIdStatus.cpp: +(JSC::PutByIdStatus::computeFromLLInt): + 2012-07-05 Michael Saboff msab...@apple.com JSString::tryHashConstLock() fails to get exclusive lock Modified: trunk/Source/_javascript_Core/bytecode/PutByIdStatus.cpp (121942 => 121943) --- trunk/Source/_javascript_Core/bytecode/PutByIdStatus.cpp 2012-07-06 04:31:26 UTC (rev 121942) +++ trunk/Source/_javascript_Core/bytecode/PutByIdStatus.cpp 2012-07-06 04:52:26 UTC (rev 121943) @@ -72,7 +72,7 @@ return PutByIdStatus(SimpleTransition, structure, newStructure, chain, offset); #else -return PutByIdStatus(NoInformation, 0, 0, 0, notFound); +return PutByIdStatus(NoInformation, 0, 0, 0, invalidOffset); #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
