[webkit-changes] [129098] trunk/LayoutTests

[commit-queue]

Title: [129098] trunk/LayoutTests








Revision 129098
Author commit-qu...@webkit.org
Date 2012-09-19 23:56:08 -0700 (Wed, 19 Sep 2012)


Log Message
[EFL] Unskip JS tests that are no longer crashing after r129065
https://bugs.webkit.org/show_bug.cgi?id=97174

Unreviewed EFL gardening.

Unskip several JS tests that are no longer crashing now that
the fix has landed.

Patch by Christophe Dumez  on 2012-09-19

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129097 => 129098)

--- trunk/LayoutTests/ChangeLog	2012-09-20 06:55:54 UTC (rev 129097)
+++ trunk/LayoutTests/ChangeLog	2012-09-20 06:56:08 UTC (rev 129098)
@@ -1,3 +1,15 @@
+2012-09-19  Christophe Dumez  
+
+[EFL] Unskip JS tests that are no longer crashing after r129065
+https://bugs.webkit.org/show_bug.cgi?id=97174
+
+Unreviewed EFL gardening.
+
+Unskip several JS tests that are no longer crashing now that
+the fix has landed.
+
+* platform/efl/TestExpectations:
+
 2012-09-19  Noel Gordon  
 
 Unreviewed test expectations update.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (129097 => 129098)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-09-20 06:55:54 UTC (rev 129097)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-09-20 06:56:08 UTC (rev 129098)
@@ -174,15 +174,6 @@
 # CRASHES
 #
 
-# REGRESSION(r128802): It made some JS tests crash
-webkit.org/b/97001 [ Debug ] fast/dom/message-port-deleted-by-accessor.html [ Crash Pass ]
-webkit.org/b/97001 [ Debug ] fast/js/Object-defineProperty.html [ Crash ]
-webkit.org/b/97001 [ Debug ] fast/js/array-bad-time.html [ Crash ]
-webkit.org/b/97001 [ Debug ] fast/js/array-slow-put.html [ Crash ]
-webkit.org/b/97001 [ Debug ] fast/js/object-bad-time.html [ Crash ]
-webkit.org/b/97001 [ Debug ] ietestcenter/_javascript_/15.4.4.14-9-b-i-5.html [ Crash ]
-webkit.org/b/97001 [ Debug ] ietestcenter/_javascript_/15.4.4.15-8-b-i-5.html [ Crash ]
-
 #
 # FLAKY TESTS
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129097] trunk/Source

[mitz]

Title: [129097] trunk/Source








Revision 129097
Author m...@apple.com
Date 2012-09-19 23:55:54 -0700 (Wed, 19 Sep 2012)


Log Message
Source/WebCore: WebCore part of adding a setting and API for disabling screen font substitution
https://bugs.webkit.org/show_bug.cgi?id=97168

Reviewed by Tim Horton.

* WebCore.exp.in: Added an entry for Settings::setScreenFontSubstitutionEnabled.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use printer fonts if
screen font substitution is not enabled.
* page/Settings.cpp:
(WebCore::Settings::Settings): Added initializer for new m_screenFontSubstitutionEnabled
member variable. The initial value is true, matching existing behavior.
(WebCore::Settings::setScreenFontSubstitutionEnabled): Added this setter, which updated the
member variable and forces a style recalc in all pages using this Settings.
* page/Settings.h:
(Settings): Added m_screenFontSubstitutionEnabled boolean member variable.
(WebCore::Settings::screenFontSubstitutionEnabled): Added this getter.

Source/WebKit/mac: WebKit/mac part of adding a setting and API for disabling screen font substitution
https://bugs.webkit.org/show_bug.cgi?id=97168

Reviewed by Tim Horton.

* WebView/WebPreferenceKeysPrivate.h: Defined WebKitScreenFontSubstitutionEnabledKey.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Added a default value of YES for the new preference key.
(-[WebPreferences setScreenFontSubstitutionEnabled:]): Added this setter.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Added a call to Settings::setScreenFontSubstitutionEnabled
to push the preference down to Settings.

Source/WebKit2: WebKit2 part of adding a setting and API for disabling screen font substitution
https://bugs.webkit.org/show_bug.cgi?id=97168

Reviewed by Tim Horton.

* Shared/WebPreferencesStore.h:
(WebKit): Defined ScreenFontSubstitutionEnabled key with a default value of true.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetScreenFontSubstitutionEnabled): Added this setter.
(WKPreferencesGetScreenFontSubstitutionEnabled): Added this getter.
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Added a call to Settings::setScreenFontSubstitutionEnabled
to push the preference into Settings.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129096 => 129097)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 06:52:56 UTC (rev 129096)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 06:55:54 UTC (rev 129097)
@@ -1,3 +1,23 @@
+2012-09-19  Dan Bernstein  
+
+WebCore part of adding a setting and API for disabling screen font substitution
+https://bugs.webkit.org/show_bug.cgi?id=97168
+
+Reviewed by Tim Horton.
+
+* WebCore.exp.in: Added an entry for Settings::setScreenFontSubstitutionEnabled.
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use printer fonts if
+screen font substitution is not enabled.
+* page/Settings.cpp:
+(WebCore::Settings::Settings): Added initializer for new m_screenFontSubstitutionEnabled
+member variable. The initial value is true, matching existing behavior.
+(WebCore::Settings::setScreenFontSubstitutionEnabled): Added this setter, which updated the
+member variable and forces a style recalc in all pages using this Settings.
+* page/Settings.h:
+(Settings): Added m_screenFontSubstitutionEnabled boolean member variable.
+(WebCore::Settings::screenFontSubstitutionEnabled): Added this getter.
+
 2012-09-19  Yoshifumi Inoue  
 
 [Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed


Modified: trunk/Source/WebCore/WebCore.exp.in (129096 => 129097)

--- trunk/Source/WebCore/WebCore.exp.in	2012-09-20 06:52:56 UTC (rev 129096)
+++ trunk/Source/WebCore/WebCore.exp.in	2012-09-20 06:55:54 UTC (rev 129097)
@@ -914,6 +914,7 @@
 __ZN7WebCore8Settings31setShrinksStandaloneImagesToFitEb
 __ZN7WebCore8Settings32setAcceleratedCompositingEnabledEb
 __ZN7WebCore8Settings32setNeedsAdobeFrameReloadingQuirkEb
+__ZN7WebCore8Settings32setScreenFontSubstitutionEnabledEb
 __ZN7WebC

[webkit-changes] [129095] trunk/Source/WebCore

[yosin]

Title: [129095] trunk/Source/WebCore








Revision 129095
Author yo...@chromium.org
Date 2012-09-19 23:13:37 -0700 (Wed, 19 Sep 2012)


Log Message
[Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed
https://bugs.webkit.org/show_bug.cgi?id=97169

Reviewed by Kent Tamura.

This patch makes multiple fields time input UI calls notifyFormStateChanged()
when field value is changed as other input types do.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. We can't test this change in WebKit test tools. Test script
will be implemented in Chromium side.

* html/TimeInputType.cpp:
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/TimeInputType.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129094 => 129095)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 06:02:30 UTC (rev 129094)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 06:13:37 UTC (rev 129095)
@@ -1,3 +1,22 @@
+2012-09-19  Yoshifumi Inoue  
+
+[Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed
+https://bugs.webkit.org/show_bug.cgi?id=97169
+
+Reviewed by Kent Tamura.
+
+This patch makes multiple fields time input UI calls notifyFormStateChanged()
+when field value is changed as other input types do.
+
+This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
+ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
+
+No new tests. We can't test this change in WebKit test tools. Test script
+will be implemented in Chromium side.
+
+* html/TimeInputType.cpp:
+(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):
+
 2012-09-19  Keishi Hattori  
 
 REGRESSION(r127727): Calendar picker focus ring should be hidden until key event


Modified: trunk/Source/WebCore/html/TimeInputType.cpp (129094 => 129095)

--- trunk/Source/WebCore/html/TimeInputType.cpp	2012-09-20 06:02:30 UTC (rev 129094)
+++ trunk/Source/WebCore/html/TimeInputType.cpp	2012-09-20 06:13:37 UTC (rev 129095)
@@ -152,6 +152,7 @@
 input->setNeedsStyleRecalc();
 input->dispatchFormControlInputEvent();
 input->dispatchFormControlChangeEvent();
+input->notifyFormStateChanged();
 }
 
 bool TimeInputType::hasCustomFocusLogic() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129094] trunk/Source/WebCore

[keishi]

Title: [129094] trunk/Source/WebCore








Revision 129094
Author kei...@webkit.org
Date 2012-09-19 23:02:30 -0700 (Wed, 19 Sep 2012)


Log Message
REGRESSION(r127727): Calendar picker focus ring should be hidden until key event
https://bugs.webkit.org/show_bug.cgi?id=97165

Reviewed by Kent Tamura.

The regression was caused because NoFocusRing class was being removed
from then main element inside resetMain().

No new tests. Covered by calendar-picker-appearance.html.

* Resources/pagepopups/calendarPicker.js:
(initialize):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):
(CalendarPicker.prototype.maybeUpdateFocusStyle): Make this a method of CalendarPicker because we don't use it for other pickers.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (129093 => 129094)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 05:52:12 UTC (rev 129093)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 06:02:30 UTC (rev 129094)
@@ -1,3 +1,23 @@
+2012-09-19  Keishi Hattori  
+
+REGRESSION(r127727): Calendar picker focus ring should be hidden until key event
+https://bugs.webkit.org/show_bug.cgi?id=97165
+
+Reviewed by Kent Tamura.
+
+The regression was caused because NoFocusRing class was being removed
+from then main element inside resetMain().
+
+No new tests. Covered by calendar-picker-appearance.html.
+
+* Resources/pagepopups/calendarPicker.js:
+(initialize):
+(CalendarPicker):
+(CalendarPicker.prototype._layout):
+(DaysTable.prototype._handleKey):
+(CalendarPicker.prototype._handleBodyKeyDown):
+(CalendarPicker.prototype.maybeUpdateFocusStyle): Make this a method of CalendarPicker because we don't use it for other pickers.
+
 2012-09-19  David Grogan  
 
 IndexedDB: Print console warning about setVersion


Modified: trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js (129093 => 129094)

--- trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js	2012-09-20 05:52:12 UTC (rev 129093)
+++ trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js	2012-09-20 06:02:30 UTC (rev 129094)
@@ -72,7 +72,6 @@
  */
 var global = {
 argumentsReceived: false,
-hadKeyEvent: false,
 params: null
 };
 
@@ -267,11 +266,9 @@
  * @param {!Object} args
  */
 function initialize(args) {
-var main = $("main");
-main.classList.add(ClassNames.NoFocusRing);
-
 var errorString = validateArguments(args);
 if (errorString) {
+var main = $("main");
 main.textContent = "Internal error: " + errorString;
 resizeWindow(main.offsetWidth, main.offsetHeight);
 } else {
@@ -305,6 +302,7 @@
 this.step = (typeof this._config.step !== undefined) ? this._config.step * CalendarPicker.BaseStep : CalendarPicker.BaseStep;
 this.yearMonthController = new YearMonthController(this);
 this.daysTable = new DaysTable(this);
+this._hadKeyEvent = false;
 this._layout();
 var initialDate = parseDateString(this._config.currentValue);
 if (initialDate < this.minimumDate)
@@ -328,6 +326,8 @@
 this.yearMonthController.attachTo(this._element);
 this.daysTable.attachTo(this._element);
 this._layoutButtons();
+// DaysTable will have focus but we don't want to show its focus ring until the first key event.
+this._element.classList.add(ClassNames.NoFocusRing);
 };
 
 CalendarPicker.prototype.handleToday = function() {
@@ -1056,7 +1056,7 @@
  * @param {Event} event
  */
 DaysTable.prototype._handleKey = function(event) {
-maybeUpdateFocusStyle();
+this.picker.maybeUpdateFocusStyle();
 var x = this._x;
 var y = this._y;
 var key = event.keyIdentifier;
@@ -1156,7 +1156,7 @@
  * @param {!Event} event
  */
 CalendarPicker.prototype._handleBodyKeyDown = function(event) {
-maybeUpdateFocusStyle();
+this.maybeUpdateFocusStyle();
 var key = event.keyIdentifier;
 if (key == "U+0009") {
 if (!event.shiftKey && document.activeElement == global.lastFocusableControl) {
@@ -1178,11 +1178,11 @@
 this.handleCancel();
 }
 
-function maybeUpdateFocusStyle() {
-if (global.hadKeyEvent)
+CalendarPicker.prototype.maybeUpdateFocusStyle = function() {
+if (this._hadKeyEvent)
 return;
-global.hadKeyEvent = true;
-$("main").classList.remove(ClassNames.NoFocusRing);
+this._hadKeyEvent = true;
+this._element.classList.remove(ClassNames.NoFocusRing);
 }
 
 if (window.dialogArguments) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129092] trunk/Tools

[ossy]

Title: [129092] trunk/Tools








Revision 129092
Author o...@webkit.org
Date 2012-09-19 22:50:25 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed, rolling out r129007.
http://trac.webkit.org/changeset/129007
https://bugs.webkit.org/show_bug.cgi?id=97172

It broke the build on the Qt bots (Requested by Ossy on
#webkit).

Patch by Sheriff Bot  on 2012-09-19

* qmake/config.tests/gccdepends/empty.cpp:
* qmake/config.tests/gccdepends/gccdepends.pro:
* qmake/mkspecs/features/default_pre.prf:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/config.tests/gccdepends/gccdepends.pro
trunk/Tools/qmake/mkspecs/features/default_pre.prf


Removed Paths

trunk/Tools/qmake/config.tests/gccdepends/empty.cpp




Diff

Modified: trunk/Tools/ChangeLog (129091 => 129092)

--- trunk/Tools/ChangeLog	2012-09-20 05:14:16 UTC (rev 129091)
+++ trunk/Tools/ChangeLog	2012-09-20 05:50:25 UTC (rev 129092)
@@ -1,3 +1,16 @@
+2012-09-19  Sheriff Bot  
+
+Unreviewed, rolling out r129007.
+http://trac.webkit.org/changeset/129007
+https://bugs.webkit.org/show_bug.cgi?id=97172
+
+It broke the build on the Qt bots (Requested by Ossy on
+#webkit).
+
+* qmake/config.tests/gccdepends/empty.cpp:
+* qmake/config.tests/gccdepends/gccdepends.pro:
+* qmake/mkspecs/features/default_pre.prf:
+
 2012-09-19  Ryosuke Niwa  
 
 run-perf-tests should record indivisual value instead of statistics


Deleted: trunk/Tools/qmake/config.tests/gccdepends/empty.cpp (129091 => 129092)

--- trunk/Tools/qmake/config.tests/gccdepends/empty.cpp	2012-09-20 05:14:16 UTC (rev 129091)
+++ trunk/Tools/qmake/config.tests/gccdepends/empty.cpp	2012-09-20 05:50:25 UTC (rev 129092)
@@ -1,2 +0,0 @@
-
-int main() { return 0; }


Modified: trunk/Tools/qmake/config.tests/gccdepends/gccdepends.pro (129091 => 129092)

--- trunk/Tools/qmake/config.tests/gccdepends/gccdepends.pro	2012-09-20 05:14:16 UTC (rev 129091)
+++ trunk/Tools/qmake/config.tests/gccdepends/gccdepends.pro	2012-09-20 05:50:25 UTC (rev 129092)
@@ -1,8 +1,6 @@
-TEMPLATE = app
+TEMPLATE = aux
 OBJECTS_DIR = obj
-CONFIG += GNUmake gcc_MD_depends
-QMAKE_CXXFLAGS += -MP
-TARGET = empty
+QMAKE_CXXFLAGS += -MD
 
 base_filename = empty
 object_file = $$OBJECTS_DIR/$${base_filename}.o


Modified: trunk/Tools/qmake/mkspecs/features/default_pre.prf (129091 => 129092)

--- trunk/Tools/qmake/mkspecs/features/default_pre.prf	2012-09-20 05:14:16 UTC (rev 129091)
+++ trunk/Tools/qmake/mkspecs/features/default_pre.prf	2012-09-20 05:50:25 UTC (rev 129092)
@@ -87,9 +87,6 @@
 # We have a compiler that supports the -MD option (and neither
 # teambuilder nor icecream is messing up the .d file output).
 CONFIG += GNUmake gcc_MD_depends
-# This should really be added to qmake, but for now we add it here.
-QMAKE_CXXFLAGS += -MP
-QMAKE_CFLAGS += -MP
 }
 
 !haveQt(5):!recursive_include: error("Building WebKit with Qt versions older than 5.0 is not supported.")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129091] trunk

[rniwa]

Title: [129091] trunk








Revision 129091
Author rn...@webkit.org
Date 2012-09-19 22:14:16 -0700 (Wed, 19 Sep 2012)


Log Message
run-perf-tests should record indivisual value instead of statistics
https://bugs.webkit.org/show_bug.cgi?id=97155

Reviewed by Hajime Morita.

PerformanceTests: 

Report the list of values as "values" so that run-perf-tests can parse them.

* resources/runner.js:
(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):

Tools: 

Parse the list of indivisual value reported by tests and include them as "values".
We strip "values" from the output JSON when uploading it to the perf-o-matic
since it doesn't know how to parse "values" or ignore it.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output): Parse and report "values".
(PageLoadingPerfTest.run): Report indivisual page loading time in "values".
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results): Strip "values" from each result
until we update perf-o-matic.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_memory_test):
(test_run_with_json_output):
(test_run_with_description):
(test_run_with_slave_config_json):
(test_run_with_multiple_repositories):

LayoutTests: 

The expected result now contains indivisual value.

* fast/harness/perftests/runs-per-second-log-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/harness/perftests/runs-per-second-log-expected.txt
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/resources/runner.js
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py




Diff

Modified: trunk/LayoutTests/ChangeLog (129090 => 129091)

--- trunk/LayoutTests/ChangeLog	2012-09-20 04:49:43 UTC (rev 129090)
+++ trunk/LayoutTests/ChangeLog	2012-09-20 05:14:16 UTC (rev 129091)
@@ -1,3 +1,14 @@
+2012-09-19  Ryosuke Niwa  
+
+run-perf-tests should record indivisual value instead of statistics
+https://bugs.webkit.org/show_bug.cgi?id=97155
+
+Reviewed by Hajime Morita.
+
+The expected result now contains indivisual value.
+
+* fast/harness/perftests/runs-per-second-log-expected.txt:
+
 2012-09-19  David Grogan  
 
 IndexedDB: Print console warning about setVersion


Modified: trunk/LayoutTests/fast/harness/perftests/runs-per-second-log-expected.txt (129090 => 129091)

--- trunk/LayoutTests/fast/harness/perftests/runs-per-second-log-expected.txt	2012-09-20 04:49:43 UTC (rev 129090)
+++ trunk/LayoutTests/fast/harness/perftests/runs-per-second-log-expected.txt	2012-09-20 05:14:16 UTC (rev 129091)
@@ -9,6 +9,7 @@
 5 runs/s
 
 Time:
+values 1, 2, 3, 4, 5 runs/s
 avg 3 runs/s
 median 3 runs/s
 stdev 1.41 runs/s


Modified: trunk/PerformanceTests/ChangeLog (129090 => 129091)

--- trunk/PerformanceTests/ChangeLog	2012-09-20 04:49:43 UTC (rev 129090)
+++ trunk/PerformanceTests/ChangeLog	2012-09-20 05:14:16 UTC (rev 129091)
@@ -1,3 +1,16 @@
+2012-09-19  Ryosuke Niwa  
+
+run-perf-tests should record indivisual value instead of statistics
+https://bugs.webkit.org/show_bug.cgi?id=97155
+
+Reviewed by Hajime Morita.
+
+Report the list of values as "values" so that run-perf-tests can parse them.
+
+* resources/runner.js:
+(PerfTestRunner.computeStatistics):
+(PerfTestRunner.printStatistics):
+
 2012-09-17  Ryosuke Niwa  
 
 Perf test results is incomprehensive


Modified: trunk/PerformanceTests/resources/runner.js (129090 => 129091)

--- trunk/PerformanceTests/resources/runner.js	2012-09-20 04:49:43 UTC (rev 129090)
+++ trunk/PerformanceTests/resources/runner.js	2012-09-20 05:14:16 UTC (rev 129091)
@@ -74,6 +74,7 @@
 
 // Compute the mean and variance using a numerically stable algorithm.
 var squareSum = 0;
+result.values = times;
 result.mean = data[0];
 result.sum = data[0];
 for (var i = 1; i < data.length; ++i) {
@@ -99,6 +100,7 @@
 PerfTestRunner.printStatistics = function (statistics, title) {
 this.log("");
 this.log(title);
+this.log("values " + statistics.values.join(', ') + " " + statistics.unit)
 this.log("avg " + statistics.mean + " " + statistics.unit);
 this.log("median " + statistics.median + " " + statistics.unit);
 this.log("stdev " + statistics.stdev + " " + statistics.unit);


Modified: trunk/Tools/ChangeLog (129090 => 129091)

--- trunk/Tools/ChangeLog	2012-09-20 04:49:43 UTC (rev 129090)
+++ trunk/Tools/ChangeLog	2012-09-20 05:14:16 UTC (rev 129091)
@@ -1,3 +1,32 @@
+2012-09-19  Ryosuke Niwa  
+

[webkit-changes] [129089] trunk/Source

[ggaren]

Title: [129089] trunk/Source








Revision 129089
Author gga...@apple.com
Date 2012-09-19 21:44:43 -0700 (Wed, 19 Sep 2012)


Log Message
OSR exit sometimes neglects to create the arguments object
https://bugs.webkit.org/show_bug.cgi?id=97162

Reviewed by Filip Pizlo.

../_javascript_Core: 

No performance change.

I don't know of any case where this is a real problem in TOT, but it
will become a problem if we start compiling eval, with, or catch, and/or
sometimes stop doing arguments optimizations in the bytecode.

* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run): Account for a
CreateArguments that has transformed into PhantomArguments. We used to
clear our reference to the CreateArguments node, but now we hold onto it, 
so we need to account for it transforming.

Don't replace a SetLocal(CreateArguments) with a SetLocal(JSValue())
because that doesn't leave enough information behind for OSR exit to do
the right thing. Instead, maintain our reference to CreateArguments, and
rely on CreateArguments transforming into PhantomArguments after
optimization. SetLocal(PhantomArguments) is efficient, and it's a marker
for OSR exit to create the arguments object.

Don't ASSERT that all PhantomArguments are unreferenced because we now
leave them in the graph as SetLocal(PhantomArguments), and that's harmless.

* dfg/DFGArgumentsSimplificationPhase.h:
(NullableHashTraits):
(JSC::DFG::NullableHashTraits::emptyValue): Export our special hash table
for inline call frames so the OSR exit compiler can use it.

* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit): Don't load the 'arguments'
register to decide if we need to create the arguments object. Optimization
may have eliminated the initializing store to this register, in which
case we'll load garbage. Instead, use the global knowledge that all call
frames that optimized out 'arguments' now need to create it, and use a hash
table to make sure we do so only once per call frame.

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): SetLocal(PhantomArguments) is unique
because we haven't just changed a value's format or elided a load or store;
instead, we've replaced an object with JSValue(). We could try to account
for this in a general way, but for now it's a special-case optimization,
so we give it a specific OSR hint instead.

../WTF: 

* wtf/HashTraits.h:
(NullableHashTraits):
(WTF::NullableHashTraits::emptyValue):
(WTF):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGArgumentsSimplificationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashTraits.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (129088 => 129089)

--- trunk/Source/_javascript_Core/ChangeLog	2012-09-20 04:27:46 UTC (rev 129088)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-20 04:44:43 UTC (rev 129089)
@@ -1,3 +1,54 @@
+2012-09-19  Geoffrey Garen  
+
+OSR exit sometimes neglects to create the arguments object
+https://bugs.webkit.org/show_bug.cgi?id=97162
+
+Reviewed by Filip Pizlo.
+
+No performance change.
+
+I don't know of any case where this is a real problem in TOT, but it
+will become a problem if we start compiling eval, with, or catch, and/or
+sometimes stop doing arguments optimizations in the bytecode.
+
+* dfg/DFGArgumentsSimplificationPhase.cpp:
+(JSC::DFG::ArgumentsSimplificationPhase::run): Account for a
+CreateArguments that has transformed into PhantomArguments. We used to
+clear our reference to the CreateArguments node, but now we hold onto it, 
+so we need to account for it transforming.
+
+Don't replace a SetLocal(CreateArguments) with a SetLocal(JSValue())
+because that doesn't leave enough information behind for OSR exit to do
+the right thing. Instead, maintain our reference to CreateArguments, and
+rely on CreateArguments transforming into PhantomArguments after
+optimization. SetLocal(PhantomArguments) is efficient, and it's a marker
+for OSR exit to create the arguments object.
+
+Don't ASSERT that all PhantomArguments are unreferenced because we now
+leave them in the graph as SetLocal(PhantomArguments), and that's harmless.
+
+* dfg/DFGArgumentsSimplificationPhase.h:
+(NullableHashTraits):
+(JSC::DFG::NullableHashTraits::emptyValue): Export our special hash table
+for inline call frames so the OSR exit compiler can use it.
+
+* dfg/DFGOSRExitCompiler32_64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+ 

[webkit-changes] [129087] trunk/Source

[commit-queue]

Title: [129087] trunk/Source








Revision 129087
Author commit-qu...@webkit.org
Date 2012-09-19 19:34:43 -0700 (Wed, 19 Sep 2012)


Log Message
[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
https://bugs.webkit.org/show_bug.cgi?id=96362

Patch by Sean Wang  on 2012-09-19
Reviewed by Rob Buis.

Source/WebCore:

This patch enable reading credentials from the persistent credential storage
when it is not private browsing mode and there is not a credential in the RAM
for the requested resource.

Since we don't load persistent stored credentials into RAM at the starting time,
even we have saved the credentials at the last browsing, after restarting the browser,
it will still challenge for credentials for the requesting resources.

No new tests, it uses the original authentication tests. There is no way to
clear all credentials or restarting browsers to test this feature.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::getProtectionSpace):
(WebCore):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):

Source/WebKit/blackberry:

Make the FrameLoaderClient use credential storage according to the macro
BLACKBERRY_CREDENTIAL_PERSIST

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
(WebCore):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp
trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.h
trunk/Source/WebCore/platform/network/blackberry/NetworkManager.cpp
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (129086 => 129087)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 02:07:27 UTC (rev 129086)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 02:34:43 UTC (rev 129087)
@@ -1,3 +1,29 @@
+2012-09-19  Sean Wang  
+
+[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
+https://bugs.webkit.org/show_bug.cgi?id=96362
+
+Reviewed by Rob Buis.
+
+This patch enable reading credentials from the persistent credential storage
+when it is not private browsing mode and there is not a credential in the RAM
+for the requested resource.
+
+Since we don't load persistent stored credentials into RAM at the starting time,
+even we have saved the credentials at the last browsing, after restarting the browser,
+it will still challenge for credentials for the requesting resources.
+
+No new tests, it uses the original authentication tests. There is no way to
+clear all credentials or restarting browsers to test this feature.
+
+* platform/network/blackberry/CredentialBackingStore.cpp:
+(WebCore::CredentialBackingStore::getProtectionSpace):
+(WebCore):
+* platform/network/blackberry/CredentialBackingStore.h:
+(CredentialBackingStore):
+* platform/network/blackberry/NetworkManager.cpp:
+(WebCore::NetworkManager::startJob):
+
 2012-09-19  Shinya Kawanaka  
 
 [Refactoring] ButtonInputType of  element should have innerElement to make  AuthorShadowDOM-ready


Modified: trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp (129086 => 129087)

--- trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp	2012-09-20 02:07:27 UTC (rev 129086)
+++ trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp	2012-09-20 02:34:43 UTC (rev 129087)
@@ -253,6 +253,32 @@
 return false;
 }
 
+ProtectionSpace CredentialBackingStore::getProtectionSpace(const KURL& url)
+{
+ASSERT(m_database.isOpen());
+ASSERT(m_database.tableExists("logins"));
+
+if (!m_getLoginByURLStatement)
+return ProtectionSpace();
+
+m_getLoginByURLStatement->bindText(1, url.string());
+
+int result = m_getLoginByURLStatement->step();
+String username = m_getLoginByURLStatement->getColumnText(0);
+String password = m_usingCertManager ? "" : m_getLoginByURLStatement->getColumnBlobAsString(1);
+String host = m_getLoginByURLStatement->getColumnText(2);
+int port = m_getLoginByURLStatement->getColumnInt(3);
+int serviceType = m_getLoginByURLStatement->getColumnInt(4);
+String realm = m_getLoginByURLStatement->getColumnText(5);
+int authenticationScheme = m_getLoginByURLStatement->getColumnInt(6);
+m_getLoginByURLStatement->reset();
+HANDLE_SQL_EXEC_FAILURE(result != SQLResultRow, ProtectionSpace(),
+

[webkit-changes] [129086] trunk/Source/WebCore

[shinyak]

Title: [129086] trunk/Source/WebCore








Revision 129086
Author shin...@chromium.org
Date 2012-09-19 19:07:27 -0700 (Wed, 19 Sep 2012)


Log Message
[Refactoring] ButtonInputType of  element should have innerElement to make  AuthorShadowDOM-ready
https://bugs.webkit.org/show_bug.cgi?id=95939

Reviewed by Dimitri Glazkov.

We had 2 ways to show text in RenderButton. One is to use RenderButton::setText() and the other is to add renderer
as a child of RenderButton.  used the former one, and  used the latter one.
The former makes RenderButton a bit messy, and also prevents from making  AuthorShadowDOM ready.

So we remove RenderButton::setText() and refactor  to use a Shadow DOM to show text.

Since the text in  should create RenderTextFragment, we introduce TextForButtonInputType
class. RenderText will allow us to select the inner text of , but it should not.

No new tests, existing tests should cover the change.

* html/BaseButtonInputType.cpp:
(TextForButtonInputType): Special Text node which creates RenderTextFragment.
(WebCore):
(WebCore::TextForButtonInputType::create):
(WebCore::TextForButtonInputType::TextForButtonInputType):
(WebCore::TextForButtonInputType::createRenderer):
(WebCore::BaseButtonInputType::BaseButtonInputType):
(WebCore::BaseButtonInputType::createShadowSubtree):
(WebCore::BaseButtonInputType::destroyShadowSubtree):
(WebCore::BaseButtonInputType::valueAttributeChanged): When a button value is changed, we reflect the value to
the text node in ShadowDOM.
* html/BaseButtonInputType.h:
(BaseButtonInputType):
* html/FileInputType.cpp:
(WebCore::UploadButtonElement::create): Creates Shadow DOM subtree.
(WebCore::UploadButtonElement::createForMultiple): Creates Shadow DOM subtree.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
* html/InputType.cpp:
(WebCore::InputType::valueAttributeChanged):
(WebCore):
* html/InputType.h:
(InputType):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::styleDidChange): Removed unnecessary text related code.
* rendering/RenderButton.h:
(RenderButton):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/BaseButtonInputType.cpp
trunk/Source/WebCore/html/BaseButtonInputType.h
trunk/Source/WebCore/html/FileInputType.cpp
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/InputType.cpp
trunk/Source/WebCore/html/InputType.h
trunk/Source/WebCore/rendering/RenderButton.cpp
trunk/Source/WebCore/rendering/RenderButton.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (129085 => 129086)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 02:05:09 UTC (rev 129085)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 02:07:27 UTC (rev 129086)
@@ -1,3 +1,50 @@
+2012-09-19  Shinya Kawanaka  
+
+[Refactoring] ButtonInputType of  element should have innerElement to make  AuthorShadowDOM-ready
+https://bugs.webkit.org/show_bug.cgi?id=95939
+
+Reviewed by Dimitri Glazkov.
+
+We had 2 ways to show text in RenderButton. One is to use RenderButton::setText() and the other is to add renderer
+as a child of RenderButton.  used the former one, and  used the latter one.
+The former makes RenderButton a bit messy, and also prevents from making  AuthorShadowDOM ready.
+
+So we remove RenderButton::setText() and refactor  to use a Shadow DOM to show text.
+
+Since the text in  should create RenderTextFragment, we introduce TextForButtonInputType
+class. RenderText will allow us to select the inner text of , but it should not.
+
+No new tests, existing tests should cover the change.
+
+* html/BaseButtonInputType.cpp:
+(TextForButtonInputType): Special Text node which creates RenderTextFragment.
+(WebCore):
+(WebCore::TextForButtonInputType::create):
+(WebCore::TextForButtonInputType::TextForButtonInputType):
+(WebCore::TextForButtonInputType::createRenderer):
+(WebCore::BaseButtonInputType::BaseButtonInputType):
+(WebCore::BaseButtonInputType::createShadowSubtree):
+(WebCore::BaseButtonInputType::destroyShadowSubtree):
+(WebCore::BaseButtonInputType::valueAttributeChanged): When a button value is changed, we reflect the value to
+the text node in ShadowDOM.
+* html/BaseButtonInputType.h:
+(BaseButtonInputType):
+* html/FileInputType.cpp:
+(WebCore::UploadButtonElement::create): Creates Shadow DOM subtree.
+(WebCore::UploadButtonElement::createForMultiple): Creates Shadow DOM subtree.
+* html/HTMLInputElement.cpp:
+(WebCore::HTMLInputElement::parseAttribute):
+* html/InputType.cpp:
+(WebCore::InputType::valueAttributeChanged):
+(WebCore):
+* html/InputType.h:
+(InputType):
+* rendering/RenderButton.cpp:
+(WebCore::RenderButton::RenderButton):
+(WebCore::RenderButton::styleDidChange): Removed unnecessary

[webkit-changes] [129085] trunk/Source/WebKit/chromium

[abarth]

Title: [129085] trunk/Source/WebKit/chromium








Revision 129085
Author aba...@webkit.org
Date 2012-09-19 19:05:09 -0700 (Wed, 19 Sep 2012)


Log Message
Remove webkitPostMessage
https://bugs.webkit.org/show_bug.cgi?id=96577

Reviewed by Ojan Vafai.

Actually disable webkitPostMessage. See
http://trac.webkit.org/changeset/128658 for more information.

* features.gypi:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129084 => 129085)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-20 02:05:05 UTC (rev 129084)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-20 02:05:09 UTC (rev 129085)
@@ -1,3 +1,15 @@
+2012-09-19  Adam Barth  
+
+Remove webkitPostMessage
+https://bugs.webkit.org/show_bug.cgi?id=96577
+
+Reviewed by Ojan Vafai.
+
+Actually disable webkitPostMessage. See
+http://trac.webkit.org/changeset/128658 for more information.
+
+* features.gypi:
+
 2012-09-19  Joshua Bell  
 
 IndexedDB: Remove "current transaction" concept from backing store


Modified: trunk/Source/WebKit/chromium/features.gypi (129084 => 129085)

--- trunk/Source/WebKit/chromium/features.gypi	2012-09-20 02:05:05 UTC (rev 129084)
+++ trunk/Source/WebKit/chromium/features.gypi	2012-09-20 02:05:09 UTC (rev 129085)
@@ -77,7 +77,7 @@
   'ENABLE_JAVASCRIPT_DEBUGGER=1',
   'ENABLE_LEGACY_CSS_VENDOR_PREFIXES=0',
   'ENABLE_LEGACY_VIEWPORT_ADAPTION=1',
-  'ENABLE_LEGACY_VENDOR_PREFIXES=1',
+  'ENABLE_LEGACY_VENDOR_PREFIXES=0',
   'ENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1',
   'ENABLE_LINK_PREFETCH=1',
   'ENABLE_LINK_PRERENDER=1',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129084] trunk/Source/WebCore

[jason . liu]

Title: [129084] trunk/Source/WebCore








Revision 129084
Author jason@torchmobile.com.cn
Date 2012-09-19 19:05:05 -0700 (Wed, 19 Sep 2012)


Log Message
[BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
https://bugs.webkit.org/show_bug.cgi?id=96994

Reviewed by Rob Buis.

We should remove the wrong credentials before calling sendRequestWithCredentials again.
#PR 200226
Reviewed internally by Jonathan Dong.

No new tests. It is covered by ManualTests/blackberry/http-auth-challenge.html.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129083 => 129084)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 01:52:02 UTC (rev 129083)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 02:05:05 UTC (rev 129084)
@@ -1,3 +1,20 @@
+2012-09-19  Jason Liu  
+
+[BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
+https://bugs.webkit.org/show_bug.cgi?id=96994
+
+Reviewed by Rob Buis.
+
+We should remove the wrong credentials before calling sendRequestWithCredentials again.
+#PR 200226
+Reviewed internally by Jonathan Dong.
+
+No new tests. It is covered by ManualTests/blackberry/http-auth-challenge.html.
+
+
+* platform/network/blackberry/NetworkJob.cpp:
+(WebCore::NetworkJob::notifyAuthReceived):
+
 2012-09-19  Adam Barth  
 
 Remove Blob.webkitSlice


Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (129083 => 129084)

--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-09-20 01:52:02 UTC (rev 129083)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-09-20 02:05:05 UTC (rev 129084)
@@ -294,9 +294,10 @@
 }
 storeCredentials();
 return;
-} else if (serverType != ProtectionSpaceProxyHTTP)
-// If a wifi proxy auth failed, there is no point of trying anymore because the credentials are wrong.
+} else {
+purgeCredentials();
 m_newJobWithCredentialsStarted = sendRequestWithCredentials(serverType, scheme, realm, requireCredentials);
+}
 }
 
 void NetworkJob::notifyStringHeaderReceived(const String& key, const String& value)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129083] trunk/Tools

[dpranke]

Title: [129083] trunk/Tools








Revision 129083
Author dpra...@chromium.org
Date 2012-09-19 18:52:02 -0700 (Wed, 19 Sep 2012)


Log Message
Fix regex groups for bug matching in flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=97152

Unreviewed, build fix.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(htmlForBugs):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js




Diff

Modified: trunk/Tools/ChangeLog (129082 => 129083)

--- trunk/Tools/ChangeLog	2012-09-20 01:41:03 UTC (rev 129082)
+++ trunk/Tools/ChangeLog	2012-09-20 01:52:02 UTC (rev 129083)
@@ -1,5 +1,15 @@
 2012-09-19  Dirk Pranke  
 
+Fix regex groups for bug matching in flakiness dashboard.
+https://bugs.webkit.org/show_bug.cgi?id=97152
+
+Unreviewed, build fix.
+
+* TestResultServer/static-dashboards/flakiness_dashboard.js:
+(htmlForBugs):
+
+2012-09-19  Dirk Pranke  
+
 nrwt: print unexpected results using new TestExpectations syntax
 https://bugs.webkit.org/show_bug.cgi?id=97159
 


Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (129082 => 129083)

--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js	2012-09-20 01:41:03 UTC (rev 129082)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js	2012-09-20 01:52:02 UTC (rev 129083)
@@ -972,18 +972,16 @@
 
 
 var BUG_URL_PREFIX = '-var BUG_URL_POSTFIX = '/$2">crbug.com/$2 ';
-var WEBKIT_BUG_URL_POSTFIX = '/$2">webkit.org/b/$2 ';
+var BUG_URL_POSTFIX = '/$1">crbug.com/$1 ';
+var WEBKIT_BUG_URL_POSTFIX = '/$1">webkit.org/b/$1 ';
 var INTERNAL_BUG_REPLACE_VALUE = BUG_URL_PREFIX + 'b' + BUG_URL_POSTFIX;
 var EXTERNAL_BUG_REPLACE_VALUE = BUG_URL_PREFIX + 'crbug.com' + BUG_URL_POSTFIX;
 var WEBKIT_BUG_REPLACE_VALUE = BUG_URL_PREFIX + 'webkit.org/b' + WEBKIT_BUG_URL_POSTFIX;
 
 function htmlForBugs(bugs)
 {
-// FIXME: do we still need the INTERNAL_BUG replacements? They're
-// broken temporarily.
 bugs = bugs.replace(/crbug.com\/(\d+)(\ |$)/g, EXTERNAL_BUG_REPLACE_VALUE);
-bugs = bugs.replace(/webkit.org\/b\/(\d{5}\d*?)(\ |$)/g, WEBKIT_BUG_REPLACE_VALUE);
+bugs = bugs.replace(/webkit.org\/b\/(\d+)(\ |$)/g, WEBKIT_BUG_REPLACE_VALUE);
 return bugs;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129082] trunk/Source/WebCore

[abarth]

Title: [129082] trunk/Source/WebCore








Revision 129082
Author aba...@webkit.org
Date 2012-09-19 18:41:03 -0700 (Wed, 19 Sep 2012)


Log Message
Remove Blob.webkitSlice
https://bugs.webkit.org/show_bug.cgi?id=96715

Reviewed by Darin Fisher.

Based on these usage metrics, it appears that it is safe to remove
Blob.webkitSlice. Folks that were previously calling webkitSlice should
just call slice instead. They do the same thing.

Ratio of Blob.webkitSlice calls to Blob.slice: 14.87%
Ratio of Blob.webkitSlice calls to Document creation: 0.0053%

* fileapi/Blob.cpp:
(WebCore::Blob::slice):
* fileapi/Blob.h:
(Blob):
* fileapi/Blob.idl:
* fileapi/File.h:
(File):
* inspector/front-end/FileUtils.js:
(WebInspector.ChunkedFileReader.prototype._loadChunk):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/Blob.cpp
trunk/Source/WebCore/fileapi/Blob.h
trunk/Source/WebCore/fileapi/Blob.idl
trunk/Source/WebCore/fileapi/File.h
trunk/Source/WebCore/inspector/front-end/FileUtils.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (129081 => 129082)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 01:34:02 UTC (rev 129081)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 01:41:03 UTC (rev 129082)
@@ -1,3 +1,27 @@
+2012-09-19  Adam Barth  
+
+Remove Blob.webkitSlice
+https://bugs.webkit.org/show_bug.cgi?id=96715
+
+Reviewed by Darin Fisher.
+
+Based on these usage metrics, it appears that it is safe to remove
+Blob.webkitSlice. Folks that were previously calling webkitSlice should
+just call slice instead. They do the same thing.
+
+Ratio of Blob.webkitSlice calls to Blob.slice: 14.87%
+Ratio of Blob.webkitSlice calls to Document creation: 0.0053%
+
+* fileapi/Blob.cpp:
+(WebCore::Blob::slice):
+* fileapi/Blob.h:
+(Blob):
+* fileapi/Blob.idl:
+* fileapi/File.h:
+(File):
+* inspector/front-end/FileUtils.js:
+(WebInspector.ChunkedFileReader.prototype._loadChunk):
+
 2012-09-19  Julien Chaffraix  
 
 The collapsing border code needs direction-aware border getters


Modified: trunk/Source/WebCore/fileapi/Blob.cpp (129081 => 129082)

--- trunk/Source/WebCore/fileapi/Blob.cpp	2012-09-20 01:34:02 UTC (rev 129081)
+++ trunk/Source/WebCore/fileapi/Blob.cpp	2012-09-20 01:41:03 UTC (rev 129082)
@@ -89,21 +89,6 @@
 #if ENABLE(BLOB)
 PassRefPtr Blob::slice(long long start, long long end, const String& contentType) const
 {
-HistogramSupport::histogramEnumeration("WebCore.Blob.slice", SliceWithoutPrefix, SliceHistogramEnumMax);
-return sliceInternal(start, end, contentType);
-}
-
-PassRefPtr Blob::webkitSlice(ScriptExecutionContext* context, long long start, long long end, const String& contentType) const
-{
-String message("Blob.webkitSlice() is deprecated. Use Blob.slice() instead.");
-context->addConsoleMessage(JSMessageSource, LogMessageType, WarningMessageLevel, message);
-
-HistogramSupport::histogramEnumeration("WebCore.Blob.slice", SliceWithPrefix, SliceHistogramEnumMax);
-return sliceInternal(start, end, contentType);
-}
-
-PassRefPtr Blob::sliceInternal(long long start, long long end, const String& contentType) const
-{
 // When we slice a file for the first time, we obtain a snapshot of the file by capturing its current size and modification time.
 // The modification time will be used to verify if the file has been changed or not, when the underlying data are accessed.
 long long size;


Modified: trunk/Source/WebCore/fileapi/Blob.h (129081 => 129082)

--- trunk/Source/WebCore/fileapi/Blob.h	2012-09-20 01:34:02 UTC (rev 129081)
+++ trunk/Source/WebCore/fileapi/Blob.h	2012-09-20 01:41:03 UTC (rev 129082)
@@ -71,10 +71,6 @@
 
 #if ENABLE(BLOB)
 PassRefPtr slice(long long start = 0, long long end = std::numeric_limits::max(), const String& contentType = String()) const;
-
-// Prefixed version is deprecated. This internally calls sliceInternal() (as slice() does) after showing a deprecation message.
-PassRefPtr webkitSlice(ScriptExecutionContext*, long long start = 0, long long end = std::numeric_limits::max(), const String& contentType = String()) const;
-
 #endif
 
 protected:
@@ -84,10 +80,6 @@
 // For deserialization.
 Blob(const KURL& srcURL, const String& type, long long size);
 
-#if ENABLE(BLOB)
-PassRefPtr sliceInternal(long long start, long long end, const String& contentType) const;
-#endif
-
 // This is an internal URL referring to the blob data associated with this object. It serves
 // as an identifier for this blob. The internal URL is never used to source the blob's content
 // into an HTML or for FileRead'ing, public blob URLs must be used for those purposes.


Modified: trunk/Source/WebCore/fileapi/Blob.idl (129081 => 129082)

--- trunk/Source/WebCore/fileapi/Blob.idl	2012-09-20 01:34:02 UTC (rev 129081)
+++ trunk/Source/WebCore/fileapi/Blob.idl	2012-09-20 01:41:03 UTC (rev

[webkit-changes] [129081] trunk/Tools

[dpranke]

Title: [129081] trunk/Tools








Revision 129081
Author dpra...@chromium.org
Date 2012-09-19 18:34:02 -0700 (Wed, 19 Sep 2012)


Log Message
nrwt: print unexpected results using new TestExpectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97159

Unreviewed, build fix.

Change new-run-webkit-tests to print out failures using the new
syntax when there are unexpected results, e.g.:

52 tests ran as expected, 19 didn't:

Regressions: Unexpected failures : (2)
  failures/flaky/text.html [ Failure ]
  failures/unexpected/text-image-checksum.html [ Failure ]

and so forth

* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_unexpected_results):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py




Diff

Modified: trunk/Tools/ChangeLog (129080 => 129081)

--- trunk/Tools/ChangeLog	2012-09-20 01:13:32 UTC (rev 129080)
+++ trunk/Tools/ChangeLog	2012-09-20 01:34:02 UTC (rev 129081)
@@ -1,5 +1,27 @@
 2012-09-19  Dirk Pranke  
 
+nrwt: print unexpected results using new TestExpectations syntax
+https://bugs.webkit.org/show_bug.cgi?id=97159
+
+Unreviewed, build fix.
+
+Change new-run-webkit-tests to print out failures using the new
+syntax when there are unexpected results, e.g.:
+
+52 tests ran as expected, 19 didn't:
+
+
+Regressions: Unexpected failures : (2)
+  failures/flaky/text.html [ Failure ]
+  failures/unexpected/text-image-checksum.html [ Failure ]
+
+and so forth
+
+* Scripts/webkitpy/layout_tests/views/printing.py:
+(Printer._print_unexpected_results):
+
+2012-09-19  Dirk Pranke  
+
 update flakiness dashboard after cutover to new test expectations syntax
 https://bugs.webkit.org/show_bug.cgi?id=97152
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py (129080 => 129081)

--- trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py	2012-09-20 01:13:32 UTC (rev 129080)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py	2012-09-20 01:34:02 UTC (rev 129081)
@@ -35,7 +35,7 @@
 from webkitpy.tool import grammar
 from webkitpy.common.net import resultsjsonparser
 from webkitpy.layout_tests.models import test_expectations
-from webkitpy.layout_tests.models.test_expectations import TestExpectations
+from webkitpy.layout_tests.models.test_expectations import TestExpectations, TestExpectationParser
 from webkitpy.layout_tests.views.metered_stream import MeteredStream
 
 
@@ -455,8 +455,9 @@
 actual = result['actual'].split(" ")
 expected = result['expected'].split(" ")
 result = TestExpectations.EXPECTATIONS[key.lower()]
-new_expectations_list = list(set(actual) | set(expected))
-self._print_for_bot("  %s = %s" % (test, " ".join(new_expectations_list)))
+# FIXME: clean this up once the old syntax is gone
+new_expectations_list = [TestExpectationParser._inverted_expectation_tokens[exp] for exp in list(set(actual) | set(expected))]
+self._print_for_bot("  %s [ %s ]" % (test, " ".join(new_expectations_list)))
 self._print_for_bot("")
 self._print_for_bot("")
 
@@ -467,7 +468,7 @@
 self._print_for_bot("Regressions: Unexpected %s : (%d)" % (descriptions[result][0], len(tests)))
 tests.sort()
 for test in tests:
-self._print_for_bot("  %s = %s" % (test, key))
+self._print_for_bot("  %s [ %s ] " % (test, TestExpectationParser._inverted_expectation_tokens[key]))
 self._print_for_bot("")
 
 if len(unexpected_results['tests']) and self._options.debug_rwt_logging:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129080] trunk/Tools

[dpranke]

Title: [129080] trunk/Tools








Revision 129080
Author dpra...@chromium.org
Date 2012-09-19 18:13:32 -0700 (Wed, 19 Sep 2012)


Log Message
update flakiness dashboard after cutover to new test expectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97152

Unreviewed, build fix.

Handle (??) the new Bug notations as well. Hopefully we don't
still need the old ones.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(filterBugs):
(htmlForBugs):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js




Diff

Modified: trunk/Tools/ChangeLog (129079 => 129080)

--- trunk/Tools/ChangeLog	2012-09-20 00:59:24 UTC (rev 129079)
+++ trunk/Tools/ChangeLog	2012-09-20 01:13:32 UTC (rev 129080)
@@ -3,6 +3,21 @@
 update flakiness dashboard after cutover to new test expectations syntax
 https://bugs.webkit.org/show_bug.cgi?id=97152
 
+Unreviewed, build fix.
+
+Handle (??) the new Bug notations as well. Hopefully we don't
+still need the old ones.
+
+* TestResultServer/static-dashboards/flakiness_dashboard.js:
+(filterBugs):
+(htmlForBugs):
+* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+
+2012-09-19  Dirk Pranke  
+
+update flakiness dashboard after cutover to new test expectations syntax
+https://bugs.webkit.org/show_bug.cgi?id=97152
+
 Reviewed by Ryosuke Niwa.
 
 This change clones the TestExpectation parsing state machine


Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (129079 => 129080)

--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js	2012-09-20 00:59:24 UTC (rev 129079)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js	2012-09-20 01:13:32 UTC (rev 129080)
@@ -505,7 +505,7 @@
 
 function filterBugs(modifiers)
 {
-var bugs = modifiers.match(/\bBUG\S*/g);
+var bugs = modifiers.match(/\b(Bug|webkit.org|crbug.com|code.google.com)\S*/g);
 if (!bugs)
 return {bugs: '', modifiers: modifiers};
 for (var j = 0; j < bugs.length; j++)
@@ -610,7 +610,7 @@
 'Release': 'RELEASE',
 'Debug': 'DEBUG',
 'Mac': 'MAC',
-'Win': 'Win',
+'Win': 'WIN',
 'Linux': 'LINUX',
 'SnowLeopard': 'SNOWLEOPARD',
 'Lion': 'LION',
@@ -980,12 +980,10 @@
 
 function htmlForBugs(bugs)
 {
-bugs = bugs.replace(/BUG(CR)?(\d{4})(\ |$)/g, EXTERNAL_BUG_REPLACE_VALUE);
-bugs = bugs.replace(/BUG(CR)?(\d{5})(\ |$)/g, EXTERNAL_BUG_REPLACE_VALUE);
-bugs = bugs.replace(/BUG(CR)?(1\d{5})(\ |$)/g, EXTERNAL_BUG_REPLACE_VALUE);
-bugs = bugs.replace(/BUG(CR)?([2-9]\d{5})(\ |$)/g, INTERNAL_BUG_REPLACE_VALUE);
-bugs = bugs.replace(/BUG(CR)?(\d{7})(\ |$)/g, INTERNAL_BUG_REPLACE_VALUE);
-bugs = bugs.replace(/BUG(WK)(\d{5}\d*?)(\ |$)/g, WEBKIT_BUG_REPLACE_VALUE);
+// FIXME: do we still need the INTERNAL_BUG replacements? They're
+// broken temporarily.
+bugs = bugs.replace(/crbug.com\/(\d+)(\ |$)/g, EXTERNAL_BUG_REPLACE_VALUE);
+bugs = bugs.replace(/webkit.org\/b\/(\d{5}\d*?)(\ |$)/g, WEBKIT_BUG_REPLACE_VALUE);
 return bugs;
 }
 


Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (129079 => 129080)

--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js	2012-09-20 00:59:24 UTC (rev 129079)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js	2012-09-20 01:13:32 UTC (rev 129080)
@@ -197,12 +197,12 @@
 });
 
 test('filterBugs',4, function() {
-var filtered = filterBugs('SKIP BUG123 BUGCR123 BUGWK123 SLOW BUG_TONY DEBUG')
-equal(filtered.modifiers, 'SKIP SLOW DEBUG');
-equal(filtered.bugs, 'BUG123 BUGCR123 BUGWK123 BUG_TONY');
+var filtered = filterBugs('Skip crbug.com/123 webkit.org/b/123 Slow Bug(Tony) Debug')
+equal(filtered.modifiers, 'Skip Slow Debug');
+equal(filtered.bugs, 'crbug.com/123 webkit.org/b/123 Bug(Tony)');
 
-filtered = filterBugs('SKIP SLOW DEBUG')
-equal(filtered.modifiers, 'SKIP SLOW DEBUG');
+filtered = filterBugs('Skip Slow Debug')
+equal(filtered.modifiers, 'Skip Slow Debug');
 equal(filtered.bugs, '');
 });
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129079] trunk/Tools

[dpranke]

Title: [129079] trunk/Tools








Revision 129079
Author dpra...@chromium.org
Date 2012-09-19 17:59:24 -0700 (Wed, 19 Sep 2012)


Log Message
update flakiness dashboard after cutover to new test expectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97152

Reviewed by Ryosuke Niwa.

This change clones the TestExpectation parsing state machine
from python into _javascript_.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(parsedExpectations.lines.forEach):
(parsedExpectations):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js




Diff

Modified: trunk/Tools/ChangeLog (129078 => 129079)

--- trunk/Tools/ChangeLog	2012-09-20 00:58:58 UTC (rev 129078)
+++ trunk/Tools/ChangeLog	2012-09-20 00:59:24 UTC (rev 129079)
@@ -1,3 +1,18 @@
+2012-09-19  Dirk Pranke  
+
+update flakiness dashboard after cutover to new test expectations syntax
+https://bugs.webkit.org/show_bug.cgi?id=97152
+
+Reviewed by Ryosuke Niwa.
+
+This change clones the TestExpectation parsing state machine
+from python into _javascript_.
+
+* TestResultServer/static-dashboards/flakiness_dashboard.js:
+(parsedExpectations.lines.forEach):
+(parsedExpectations):
+* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+
 2012-09-19  Dana Jansens  
 
 Add bac...@chromium.org as contributor


Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (129078 => 129079)

--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js	2012-09-20 00:58:58 UTC (rev 129078)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js	2012-09-20 00:59:24 UTC (rev 129079)
@@ -588,22 +588,99 @@
 var lines = g_expectations.split('\n');
 lines.forEach(function(line) {
 line = trimString(line);
-if (!line || startsWith(line, '//'))
+if (!line || startsWith(line, '#'))
 return;
 
-// FIXME: Make this robust against not having modifiers and/or expectations.
-// Right now, run-webkit-tests doesn't allow such lines, but it may in the future.
-var match = line.match(/([^:]+)*:([^=]+)=(.*)/);
-if (!match) {
-console.error('Line could not be parsed: ' + line);
-return;
+// This code mimics _tokenize_line_using_new_format() in
+// Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
+//
+// FIXME: consider doing more error checking here.
+//
+// FIXME: Clean this all up once we've fully cut over to the new syntax.
+var tokens = line.split(/\s+/)
+var parsed_bugs = [];
+var parsed_modifiers = [];
+var parsed_path;
+var parsed_expectations = [];
+var state = 'start';
+
+// This clones _configuration_tokens_list in test_expectations.py.
+// FIXME: unify with the platforms constants at the top of the file.
+var configuration_tokens = {
+'Release': 'RELEASE',
+'Debug': 'DEBUG',
+'Mac': 'MAC',
+'Win': 'Win',
+'Linux': 'LINUX',
+'SnowLeopard': 'SNOWLEOPARD',
+'Lion': 'LION',
+'MountainLion': 'MOUNTAINLION',
+'Win7': 'WIN7',
+'XP': 'XP',
+'Vista': 'VISTA',
+'Android': 'ANDROID',
+};
+
+var expectation_tokens = {
+'Crash': 'CRASH',
+'Failure': 'FAIL',
+'ImageOnlyFailure': 'IMAGE',
+'Missing': 'MISSING',
+'Pass': 'PASS',
+'Rebaseline': 'REBASELINE',
+'Skip': 'SKIP',
+'Slow': 'SLOW',
+'Timeout': 'TIMEOUT',
+'WontFix': 'WONTFIX',
+};
+
+
+tokens.forEach(function(token) {
+  if (token.indexOf('Bug') != -1 ||
+  token.indexOf('webkit.org') != -1 ||
+  token.indexOf('crbug.com') != -1 ||
+  token.indexOf('code.google.com') != -1) {
+  parsed_bugs.push(token);
+  } else if (token == '[') {
+  if (state == 'start') {
+  state = 'configuration';
+  } else if (state == 'name_found') {
+  state = 'expectations';
+  }
+  } else if (token == ']') {
+  if (state == 'configuration') {
+  state = 'name';
+  } else if (state == 'expectations') {
+  state = 'done';
+  }
+  } else if (state == 'configuration') {
+  parsed_modifiers.push(configuration_tokens[token]);
+  } else if (state == 'expectations') {
+  if (token == 'Rebaseline' || token == 'Skip' || token =

[webkit-changes] [129078] trunk/Source/WebCore

[jchaffraix]

Title: [129078] trunk/Source/WebCore








Revision 129078
Author jchaffr...@webkit.org
Date 2012-09-19 17:58:58 -0700 (Wed, 19 Sep 2012)


Log Message
The collapsing border code needs direction-aware border getters
https://bugs.webkit.org/show_bug.cgi?id=96710

Reviewed by Ojan Vafai.

This refactoring is needed to extend our collapsing border support for mixed directionality
at the table cell level (we currently wrongly ignore any direction below the row-group). For
now, the new helpers are dumb and return exactly the old result but they will be made
direction-aware in a follow-up change.

Refactoring covered by existing tests.

* rendering/RenderBox.h:
(WebCore::RenderBox::hasSameDirectionAs):
Added this helper function. For now, it's only used to compare against
the table direction but we will reuse it to compare the current cell
direction against the other table parts.

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Transitioned those 2 functions to using the new direction-aware functions.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Updated those call sites to use RenderBox::hasSameDirectionAs.

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::borderAdjoiningNextCell):
(WebCore::RenderTableCell::borderAdjoiningPreviousCell):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::borderAdjoiningCellStartBorder):
(WebCore::RenderTableCol::borderAdjoiningCellEndBorder):
(WebCore::RenderTableCol::borderAdjoiningCellBefore):
(WebCore::RenderTableCol::borderAdjoiningCellAfter):
* rendering/RenderTableCol.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::borderAdjoiningStartCell):
(WebCore::RenderTableRow::borderAdjoiningEndCell):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::borderAdjoiningStartCell):
(WebCore::RenderTableSection::borderAdjoiningEndCell):
New direction-aware functions. Added some ASSERT to ensure
we don't call them with the wrong parameters.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/RenderTableCell.cpp
trunk/Source/WebCore/rendering/RenderTableCell.h
trunk/Source/WebCore/rendering/RenderTableCol.cpp
trunk/Source/WebCore/rendering/RenderTableCol.h
trunk/Source/WebCore/rendering/RenderTableRow.cpp
trunk/Source/WebCore/rendering/RenderTableRow.h
trunk/Source/WebCore/rendering/RenderTableSection.cpp
trunk/Source/WebCore/rendering/RenderTableSection.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (129077 => 129078)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 00:41:26 UTC (rev 129077)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 00:58:58 UTC (rev 129078)
@@ -1,3 +1,63 @@
+2012-09-19  Julien Chaffraix  
+
+The collapsing border code needs direction-aware border getters
+https://bugs.webkit.org/show_bug.cgi?id=96710
+
+Reviewed by Ojan Vafai.
+
+This refactoring is needed to extend our collapsing border support for mixed directionality
+at the table cell level (we currently wrongly ignore any direction below the row-group). For
+now, the new helpers are dumb and return exactly the old result but they will be made
+direction-aware in a follow-up change.
+
+Refactoring covered by existing tests.
+
+* rendering/RenderBox.h:
+(WebCore::RenderBox::hasSameDirectionAs):
+Added this helper function. For now, it's only used to compare against
+the table direction but we will reuse it to compare the current cell
+direction against the other table parts.
+
+* rendering/RenderTableCell.h:
+(WebCore::RenderTableCell::computeCollapsedStartBorder):
+(WebCore::RenderTableCell::computeCollapsedEndBorder):
+Transitioned those 2 functions to using the new direction-aware functions.
+
+* rendering/RenderTable.cpp:
+(WebCore::RenderTable::tableStartBorderAdjoiningCell):
+(WebCore::RenderTable::tableEndBorderAdjoiningCell):
+* rendering/RenderTableSection.cpp:
+(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
+(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
+* rende

[webkit-changes] [129077] trunk/Source/WebCore

[haraken]

Title: [129077] trunk/Source/WebCore








Revision 129077
Author hara...@chromium.org
Date 2012-09-19 17:41:26 -0700 (Wed, 19 Sep 2012)


Log Message
[V8] ScriptController::compileAndRunScript() can crash
https://bugs.webkit.org/show_bug.cgi?id=96567

Reviewed by Adam Barth.

See chromium bug: http://code.google.com/p/chromium/issues/detail?id=146776

The root cause is that v8::PreCompile() can return 0 when the stack of
V8's parser overflows (c.f. http://code.google.com/codesearch#OAMlx_jo-ck/src/v8/src/parser.cc&exact_package=chromium&q=kPreParseStackOverflow&type=cs&l=6021).

This patch adds the 0 check to the caller side. Given that precompileScript()
is just trying to speculatively precompile a script, it's OK to give up
precompiling for such edge cases.

Manually tested with the html generated by the following shell script:

  echo '

[webkit-changes] [129076] trunk/Source/WebCore

[jsbell]

Title: [129076] trunk/Source/WebCore








Revision 129076
Author jsb...@chromium.org
Date 2012-09-19 17:12:51 -0700 (Wed, 19 Sep 2012)


Log Message
IndexedDB: Pending call cleanup
https://bugs.webkit.org/show_bug.cgi?id=96952

Reviewed by Tony Chang.

Replace RefPtr usage with OwnPtr for PendingXXXCalls (since they're never referenced twice)
and replace queue of "second half open" calls with a single item.

No new tests - no functional changes.

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (129075 => 129076)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 00:06:28 UTC (rev 129075)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 00:12:51 UTC (rev 129076)
@@ -1,3 +1,28 @@
+2012-09-19  Joshua Bell  
+
+IndexedDB: Pending call cleanup
+https://bugs.webkit.org/show_bug.cgi?id=96952
+
+Reviewed by Tony Chang.
+
+Replace RefPtr usage with OwnPtr for PendingXXXCalls (since they're never referenced twice)
+and replace queue of "second half open" calls with a single item.
+
+No new tests - no functional changes.
+
+* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
+(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
+(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
+(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
+(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
+(WebCore::IDBDatabaseBackendImpl::setVersion):
+(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
+(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
+(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
+(WebCore::IDBDatabaseBackendImpl::close):
+* Modules/indexeddb/IDBDatabaseBackendImpl.h:
+(IDBDatabaseBackendImpl):
+
 2012-09-19  Kenichi Ishibashi  
 
 [Chromium] Improve glyph positioning of HarfBuzzShaper


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp (129075 => 129076)

--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp	2012-09-20 00:06:28 UTC (rev 129075)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp	2012-09-20 00:12:51 UTC (rev 129076)
@@ -39,11 +39,11 @@
 
 namespace WebCore {
 
-class IDBDatabaseBackendImpl::PendingOpenCall : public RefCounted {
+class IDBDatabaseBackendImpl::PendingOpenCall {
 public:
-static PassRefPtr create(PassRefPtr callbacks, PassRefPtr databaseCallbacks)
+static PassOwnPtr create(PassRefPtr callbacks, PassRefPtr databaseCallbacks)
 {
-return adoptRef(new PendingOpenCall(callbacks, databaseCallbacks));
+return adoptPtr(new PendingOpenCall(callbacks, databaseCallbacks));
 }
 PassRefPtr callbacks() { return m_callbacks; }
 PassRefPtr databaseCallbacks() { return m_databaseCallbacks; }
@@ -59,11 +59,11 @@
 RefPtr m_databaseCallbacks;
 };
 
-class IDBDatabaseBackendImpl::PendingOpenWithVersionCall : public RefCounted {
+class IDBDatabaseBackendImpl::PendingOpenWithVersionCall {
 public:
-static PassRefPtr create(PassRefPtr callbacks, PassRefPtr databaseCallbacks, int64_t version)
+static PassOwnPtr create(PassRefPtr callbacks, PassRefPtr databaseCallbacks, int64_t version)
 {
-return adoptRef(new PendingOpenWithVersionCall(callbacks, databaseCallbacks, version));
+return adoptPtr(new PendingOpenWithVersionCall(callbacks, databaseCallbacks, version));
 }
 PassRefPtr callbacks() { return m_callbacks; }
 PassRefPtr databaseCallbacks() { return m_databaseCallbacks; }
@@ -81,11 +81,11 @@
 int64_t m_version;
 };
 
-class IDBDatabaseBackendImpl::PendingDeleteCall : public RefCounted {
+class IDBDatabaseBackendImpl::PendingDeleteCall {
 public:
-static PassRefPtr create(PassRefPtr callbacks)
+static PassOwnPtr create(PassRefPtr callbacks)
 {
-return adoptRef(new PendingDeleteCall(callbacks));
+return adoptPtr(new PendingDeleteCall(callbacks));
 }
 PassRefPtr callbacks() { return m_callbacks; }
 
@@ -97,11 +97,11 @@
 RefPtr m_callbacks;
 };
 
-class IDBDatabaseBacke

[webkit-changes] [129074] trunk/Source/WebCore

[bashi]

Title: [129074] trunk/Source/WebCore








Revision 129074
Author ba...@chromium.org
Date 2012-09-19 17:00:45 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Improve glyph positioning of HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=97093

Reviewed by Tony Chang.

For proper positioning, HarfBuzzShaper requires the positions(offsets and advance)
of the previous glyph. This mean we need to shape all HarfBuzzRuns before glyph positioning.
Collect and shape HarfBuzzRuns, then set positions of glyphs.

No new tests. Tests that uses spacing for complex text (e.g. fast/text/atsui-negative-spacing-features.html)
should close in the expectations. (not the identical, maybe there are subtle differences between
harfbuzz old and harfbuzz ng)

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Allocate m_offsets.
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions): Renamed and set offset too.
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::shape): Call fillGlyphBuffer() if we need to fill glyphBuffer.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Removed glyph positioning code.
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Ditto.
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun): Added.
(WebCore):
(WebCore::HarfBuzzShaper::fillGlyphBuffer): Added.
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::offsets): Added.
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphToCharacterIndexes): Added.
(HarfBuzzShaper):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (129073 => 129074)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 23:59:01 UTC (rev 129073)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 00:00:45 UTC (rev 129074)
@@ -1,3 +1,34 @@
+2012-09-19  Kenichi Ishibashi  
+
+[Chromium] Improve glyph positioning of HarfBuzzShaper
+https://bugs.webkit.org/show_bug.cgi?id=97093
+
+Reviewed by Tony Chang.
+
+For proper positioning, HarfBuzzShaper requires the positions(offsets and advance)
+of the previous glyph. This mean we need to shape all HarfBuzzRuns before glyph positioning.
+Collect and shape HarfBuzzRuns, then set positions of glyphs.
+
+No new tests. Tests that uses spacing for complex text (e.g. fast/text/atsui-negative-spacing-features.html)
+should close in the expectations. (not the identical, maybe there are subtle differences between
+harfbuzz old and harfbuzz ng)
+
+* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
+(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Allocate m_offsets.
+(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions): Renamed and set offset too.
+(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
+(WebCore::HarfBuzzShaper::shape): Call fillGlyphBuffer() if we need to fill glyphBuffer.
+(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Removed glyph positioning code.
+(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Ditto.
+(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun): Added.
+(WebCore):
+(WebCore::HarfBuzzShaper::fillGlyphBuffer): Added.
+* platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
+(HarfBuzzRun):
+(WebCore::HarfBuzzShaper::HarfBuzzRun::offsets): Added.
+(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphToCharacterIndexes): Added.
+(HarfBuzzShaper):
+
 2012-09-19  James Simonsen  
 
 [Chromium] Disable resource load scheduling


Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp (129073 => 129074)

--- trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp	2012-09-19 23:59:01 UTC (rev 129073)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp	2012-09-20 00:00:45 UTC (rev 129074)
@@ -85,12 +85,13 @@
 m_numGlyphs = hb_buffer_get_length(harfbuzzBuffer);
 m_glyphs.resize(m_numGlyphs);
 m_advances.resize(m_numGlyphs);
-m_glyphToCharacterIndex.resize(m_numGlyphs);
+m_glyphToCharacterIndexes.resize(m_numGlyphs);
 m_logClusters.resize(m_numCharacters);
+m_offsets.resize(m_numGlyphs);
 
 hb_glyph_info_t* infos = hb_buffer_get_glyph_infos(harfbuzzBuffer, 0);
 for (unsigned i = 0; i < m_numGlyphs; ++i)
-m_glyphToCharacterIndex[i] = infos[i].cluster;
+m_glyphToCharacterIndexes[i] = infos[i].cluster;
 
 // Fill logical clusters
 unsigned index = 0;
@@ -111,10 +112,11 @@
 }
 }
 
-void HarfBuzzShaper::HarfBuzzRun::setGlyphAndAdvance(unsigned index, uint16_t glyphId, float advance)
+void HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions(unsigned index,

[webkit-changes] [129073] trunk/Tools

[danakj]

Title: [129073] trunk/Tools








Revision 129073
Author dan...@chromium.org
Date 2012-09-19 16:59:01 -0700 (Wed, 19 Sep 2012)


Log Message
Add bac...@chromium.org as contributor
https://bugs.webkit.org/show_bug.cgi?id=97150

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (129072 => 129073)

--- trunk/Tools/ChangeLog	2012-09-19 23:58:07 UTC (rev 129072)
+++ trunk/Tools/ChangeLog	2012-09-19 23:59:01 UTC (rev 129073)
@@ -1,3 +1,10 @@
+2012-09-19  Dana Jansens  
+
+Add bac...@chromium.org as contributor
+https://bugs.webkit.org/show_bug.cgi?id=97150
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2012-09-19  Dirk Pranke  
 
 fix MISSING after TestExpectations conversion


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (129072 => 129073)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-09-19 23:58:07 UTC (rev 129072)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-09-19 23:59:01 UTC (rev 129073)
@@ -137,6 +137,7 @@
 Contributor("Hao Zheng", "zheng...@chromium.org"),
 Contributor("Ian Hickson", "i...@hixie.ch", "hixie"),
 Contributor("Janos Badics", "jbad...@inf.u-szeged.hu", 'dicska'),
+Contributor("Jonathan Backer", "bac...@chromium.org", 'backer'),
 Contributor("Jeff Timanus", ["t...@chromium.org", "t...@google.com"], "twiz"),
 Contributor("Jing Zhao", "jingz...@chromium.org"),
 Contributor("John Bates", ["jba...@google.com", "jba...@chromium.org"], "jbates"),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129072] trunk/LayoutTests

[dpranke]

Title: [129072] trunk/LayoutTests








Revision 129072
Author dpra...@chromium.org
Date 2012-09-19 16:58:07 -0700 (Wed, 19 Sep 2012)


Log Message
[chromium] Fix expectation conflict on fast/hidpi/video-controls-in-hidpi.html

Unreviewed, exepectations change.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129071 => 129072)

--- trunk/LayoutTests/ChangeLog	2012-09-19 23:55:02 UTC (rev 129071)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 23:58:07 UTC (rev 129072)
@@ -1,5 +1,13 @@
 2012-09-19  Dirk Pranke  
 
+[chromium] Fix expectation conflict on fast/hidpi/video-controls-in-hidpi.html
+
+Unreviewed, exepectations change.
+
+* platform/chromium/TestExpectations:
+
+2012-09-19  Dirk Pranke  
+
 Fix v8 bug urls after syntax conversion
 
 Unreviewed, expectations change.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129071 => 129072)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 23:55:02 UTC (rev 129071)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 23:58:07 UTC (rev 129072)
@@ -2608,7 +2608,7 @@
 crbug.com/150682 platform/chromium/virtual/gpu/fast/hidpi/image-set-simple.html [ ImageOnlyFailure ]
 crbug.com/150682 platform/chromium/virtual/gpu/fast/hidpi/image-set-without-specified-width.html [ ImageOnlyFailure ]
 crbug.com/150682 platform/chromium/virtual/gpu/fast/hidpi/resize-corner-hidpi.html [ ImageOnlyFailure ]
-crbug.com/150682 platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html [ ImageOnlyFailure ]
+crbug.com/150682 [ Win Linux ] platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html [ ImageOnlyFailure ]
 crbug.com/150682 compositing/geometry/fixed-position-composited-page-scale.html [ ImageOnlyFailure ]
 crbug.com/150682 compositing/geometry/fixed-position-iframe-composited-page-scale-down.html [ ImageOnlyFailure ]
 crbug.com/150682 compositing/geometry/fixed-position-iframe-composited-page-scale.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129071] trunk/LayoutTests

[dpranke]

Title: [129071] trunk/LayoutTests








Revision 129071
Author dpra...@chromium.org
Date 2012-09-19 16:55:02 -0700 (Wed, 19 Sep 2012)


Log Message
Fix v8 bug urls after syntax conversion

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129070 => 129071)

--- trunk/LayoutTests/ChangeLog	2012-09-19 23:53:31 UTC (rev 129070)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 23:55:02 UTC (rev 129071)
@@ -1,3 +1,11 @@
+2012-09-19  Dirk Pranke  
+
+Fix v8 bug urls after syntax conversion
+
+Unreviewed, expectations change.
+
+* platform/chromium/TestExpectations:
+
 2012-09-19  James Simonsen  
 
 [Chromium] Disable resource load scheduling


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129070 => 129071)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 23:53:31 UTC (rev 129070)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 23:55:02 UTC (rev 129071)
@@ -2084,7 +2084,7 @@
 crbug.com/63921 fast/canvas/canvas-fillPath-shadow.html [ Failure ]
 
 # FIXME: Need to add tooling support for V8 bugs.
-Bug(v8_953) fast/regex/pcre-test-1.html [ Timeout ]
+code.google.com/p/v8/issues/detail?id=953 fast/regex/pcre-test-1.html [ Timeout ]
 
 webkit.org/b/50282 [ Android Linux Win ] fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html [ Failure ]
 webkit.org/b/50282 [ Android Linux Win ] fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html [ Failure ]
@@ -2249,9 +2249,9 @@
 webkit.org/b/54322 [ SnowLeopard ] fast/loader/loadInProgress.html [ Pass Slow ]
 webkit.org/b/54322 [ SnowLeopard ] transitions/transition-end-event-rendering.html [ Failure Pass ]
 
-Bug(v8_1168) fast/js/mozilla/strict/10.6.html [ Failure ]
-Bug(v8_1168) fast/js/mozilla/strict/15.5.5.2.html [ Failure ]
-Bug(v8_1168) fast/js/mozilla/strict/B.1.2.html [ Failure ]
+code.google.com/p/v8/issues/detail?id=1168 fast/js/mozilla/strict/10.6.html [ Failure ]
+code.google.com/p/v8/issues/detail?id=1168 fast/js/mozilla/strict/15.5.5.2.html [ Failure ]
+code.google.com/p/v8/issues/detail?id=1168 fast/js/mozilla/strict/B.1.2.html [ Failure ]
 
 webkit.org/b/55117 fast/js/i18n-bindings-locale.html [ Failure ]
 
@@ -2531,7 +2531,7 @@
 webkit.org/b/66419 http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html [ Failure Timeout ]
 webkit.org/b/66419 http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html [ Failure Timeout ]
 
-Bug(v8_1634) fast/js/const.html [ Failure ]
+code.google.com/p/v8/issues/detail?id=1634 fast/js/const.html [ Failure ]
 
 webkit.org/b/66795 [ Android Linux Mac ] fast/js/reentrant-caching.html [ Pass Slow ]
 
@@ -2689,8 +2689,8 @@
 webkit.org/b/75932 fast/js/array-defineOwnProperty.html [ Failure ]
 webkit.org/b/75932 fast/js/mozilla/strict/15.4.4.6.html [ Failure ]
 
-Bug(v8_1900) [ Linux Debug ] inspector/debugger/watch-expressions-panel-switch.html [ Pass Slow ]
-Bug(v8_1900) [ Linux Debug ] inspector/debugger/debugger-breakpoints-not-activated-on-reload.html [ Pass Timeout ]
+code.google.com/p/v8/issues/detail?id=1900 [ Linux Debug ] inspector/debugger/watch-expressions-panel-switch.html [ Pass Slow ]
+code.google.com/p/v8/issues/detail?id=1900 [ Linux Debug ] inspector/debugger/debugger-breakpoints-not-activated-on-reload.html [ Pass Timeout ]
 
 # New reftest failing on Win7.
 webkit.org/b/76050 [ Win7 ] fast/text/font-kerning.html [ ImageOnlyFailure ]
@@ -2746,7 +2746,7 @@
 webkit.org/b/79862 fast/js/primitive-property-access-edge-cases.html [ Failure ]
 webkit.org/b/79862 fast/js/read-modify-eval.html [ Failure ]
 
-Bug(v8_1973) fast/js/caller-property.html [ Failure ]
+code.google.com/p/v8/issues/detail?id=1973 fast/js/caller-property.html [ Failure ]
 
 webkit.org/b/78684 fast/block/basic/fieldset-stretch-to-legend.html [ Failure ]
 webkit.org/b/78684 fast/borders/fieldsetBorderRadius.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129070] trunk

[simonjam]

Title: [129070] trunk








Revision 129070
Author simon...@chromium.org
Date 2012-09-19 16:53:31 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Disable resource load scheduling
https://bugs.webkit.org/show_bug.cgi?id=97131

Reviewed by Nate Chapin.

Source/WebCore:

We'll use Chrome's network stack for scheduling instead.

No new tests.

* loader/ResourceLoadScheduler.cpp:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):

LayoutTests:

The preload scanner loads resources sooner and these tests are affected.

* platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
* platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceLoadScheduler.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp


Added Paths

trunk/LayoutTests/platform/chromium/http/tests/css/
trunk/LayoutTests/platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt
trunk/LayoutTests/platform/chromium/http/tests/inspector/network/network-initiator-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (129069 => 129070)

--- trunk/LayoutTests/ChangeLog	2012-09-19 23:49:55 UTC (rev 129069)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 23:53:31 UTC (rev 129070)
@@ -1,3 +1,15 @@
+2012-09-19  James Simonsen  
+
+[Chromium] Disable resource load scheduling
+https://bugs.webkit.org/show_bug.cgi?id=97131
+
+Reviewed by Nate Chapin.
+
+The preload scanner loads resources sooner and these tests are affected.
+
+* platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
+* platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.
+
 2012-09-19  Dirk Pranke  
 
 fix MISSING after TestExpectations conversion


Added: trunk/LayoutTests/platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt (0 => 129070)

--- trunk/LayoutTests/platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt	2012-09-19 23:53:31 UTC (rev 129070)
@@ -0,0 +1,19 @@
+Test that HTMLLinkElement's disabled attribute is properly cached while set when loading a stylesheet.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Testing value of 'disabled' prior to load just after setting them
+PASS mainSheetLink.sheet is non-null.
+FAIL alternateSheetLink.sheet should be null. Was [object CSSStyleSheet].
+PASS mainSheetLink.disabled is true
+PASS alternateSheetLink.disabled is false
+Testing the values when the alternate sheet is loaded (as this is the only one that has sheet() === null)
+PASS mainSheetLink.sheet is non-null.
+PASS alternateSheetLink.sheet is non-null.
+PASS mainSheetLink.disabled is true
+PASS alternateSheetLink.disabled is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/platform/chromium/http/tests/inspector/network/network-initiator-expected.txt (0 => 129070)

--- trunk/LayoutTests/platform/chromium/http/tests/inspector/network/network-initiator-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/inspector/network/network-initiator-expected.txt	2012-09-19 23:53:31 UTC (rev 129070)
@@ -0,0 +1,18 @@
+CONSOLE MESSAGE: line 34: Done.
+Tests resources initiator for images initiated by IMG tag, static CSS, CSS class added from _javascript_ and XHR.
+
+Bug 65105 
+This div has background image set from CSS.
+This div will have background image set from _javascript_.
+Page reloaded.
+http://127.0.0.1:8000/inspector/network/resources/initiator.css: parser
+http://127.0.0.1:8000/inspector/network/network-initiator.html 3
+http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&size=100: parser
+http://127.0.0.1:8000/inspector/network/network-initiator.html 4
+http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&size=200: parser
+http://127.0.0.1:8000/inspector/network/network-initiator.html 108
+http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&size=300: script
+addClassToDivStep2 http://127.0.0.1:8000/inspector/network/network-initiator.html 17
+http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&size=400: script
+loadData http://127.0.0.1:8000/inspector/network/network-initiator.html 29
+


Modified: trunk/Source/WebCore/ChangeLog (129069 => 129070)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 23:49:55 UTC (rev 129069)
+++ trunk/Source/WebCore/ChangeLog	201

[webkit-changes] [129069] trunk

[dpranke]

Title: [129069] trunk








Revision 129069
Author dpra...@chromium.org
Date 2012-09-19 16:49:55 -0700 (Wed, 19 Sep 2012)


Log Message
fix MISSING after TestExpectations conversion
https://bugs.webkit.org/show_bug.cgi?id=97148

Tools:

Unreviewed, expectations change / build fix.

* Scripts/convert-test-expectations:
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):

LayoutTests:

Unreviewed, expectations change.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt-4.8/TestExpectations
trunk/LayoutTests/platform/qt-mac/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/Scripts/convert-test-expectations
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py




Diff

Modified: trunk/LayoutTests/ChangeLog (129068 => 129069)

--- trunk/LayoutTests/ChangeLog	2012-09-19 23:37:36 UTC (rev 129068)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 23:49:55 UTC (rev 129069)
@@ -1,3 +1,16 @@
+2012-09-19  Dirk Pranke  
+
+fix MISSING after TestExpectations conversion
+https://bugs.webkit.org/show_bug.cgi?id=97148
+
+Unreviewed, expectations change.
+
+* platform/chromium/TestExpectations:
+* platform/efl/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/qt-4.8/TestExpectations:
+* platform/qt-mac/TestExpectations:
+
 2012-09-19  Dan Bernstein  
 
 When kerning is enabled, word spacing is doubly accounted for in RenderText::computePreferredLogicalWidths


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129068 => 129069)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 23:37:36 UTC (rev 129068)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 23:49:55 UTC (rev 129069)
@@ -195,10 +195,10 @@
 platform/gtk [ Failure ImageOnlyFailure Pass WontFix ]
 platform/mac [ Failure ImageOnlyFailure Pass Timeout WontFix ]
 platform/mac-wk2 [ Failure ImageOnlyFailure Pass Timeout WontFix ]
-platform/qt [ Failure ImageOnlyFailure MISSING Pass WontFix ]
+platform/qt [ Failure ImageOnlyFailure Missing Pass WontFix ]
 platform/qt/plugins/qt-qwidget-plugin.html [ Pass Skip WontFix ]
 platform/qt/fast/forms [ Pass Skip WontFix ]
-[ Mac Win ] platform/chromium-linux [ Failure ImageOnlyFailure MISSING WontFix ]
+[ Mac Win ] platform/chromium-linux [ Failure ImageOnlyFailure Missing WontFix ]
 [ Linux Mac ] platform/win [ Pass Skip WontFix ]
 [ Linux Win Mac ] platform/chromium-android [ Pass Skip WontFix ]
 
@@ -1932,9 +1932,9 @@
 crbug.com/49970 platform/chromium/plugins/call-as-function.html [ Failure Pass ]
 
 # Application Cache Quotas are N/A to the chromium port.
-webkit.org/b/43459 http/tests/appcache/origin-quota.html [ Failure MISSING WontFix ]
-webkit.org/b/43459 http/tests/appcache/origin-quota-continued-download.html [ Failure MISSING WontFix ]
-webkit.org/b/43459 http/tests/appcache/origin-quota-continued-download-multiple-manifests.html [ Failure MISSING WontFix ]
+webkit.org/b/43459 http/tests/appcache/origin-quota.html [ Failure Missing WontFix ]
+webkit.org/b/43459 http/tests/appcache/origin-quota-continued-download.html [ Failure Missing WontFix ]
+webkit.org/b/43459 http/tests/appcache/origin-quota-continued-download-multiple-manifests.html [ Failure Missing WontFix ]
 
 # Need to support DeviceMotion.
 crbug.com/51416 fast/dom/DeviceMotion/window-property.html [ Failure ]
@@ -2451,9 +2451,9 @@
 webkit.org/b/83824 [ Mac ] fast/regions/region-overflow-break.html [ ImageOnlyFailure ]
 webkit.org/b/74137 fast/regions/float-pushed-width-change.html [ ImageOnlyFailure Pass ]
 webkit.org/b/74137 [ SnowLeopard ] fast/regions/region-overflow-auto-overflow-hidden.html [ Failure ]
-webkit.org/b/74137 [ Lion Win ] fast/regions/region-overflow-auto-overflow-hidden.html [ MISSING ]
+webkit.org/b/74137 [ Lion Win ] fast/regions/region-overflow-auto-overflow-hidden.html [ Missing ]
 webkit.org/b/74137 [ SnowLeopard ] fast/regions/region-overflow-auto-overflow-visible.html [ Failure ]
-webkit.org/b/74137 [ Lion Win ] fast/regions/region-overflow-auto-overflow-visible.html [ MISSING ]
+webkit.org/b/74137 [ Lion Win ] fast/regions/region-overflow-auto-overflow-visible.html [ Missing ]
 
 # CSS Regions tests for region styling and scoped styles
 webkit.org/b/49142 fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html [ ImageOnlyFailure ]
@@ -2504,8 +2504,8 @@
 webkit.org/b/93546 compositing/plugins/no-backing-store.html [ Failure Pass ]
 
 # For some reason, these tests are running as pixel tests most of the time instead of dumping as text.
-webkit.org/b/74694 http/tests/cache/history-only-c

[webkit-changes] [129068] trunk

[mitz]

Title: [129068] trunk








Revision 129068
Author m...@apple.com
Date 2012-09-19 16:37:36 -0700 (Wed, 19 Sep 2012)


Log Message
When kerning is enabled, word spacing is doubly accounted for in RenderText::computePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=97146

Reviewed by Anders Carlsson.

Source/WebCore: 

Test: fast/text/word-space-with-kerning.html

* rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths): When kerning is enabled, words are
measured with their trailing space, if there is one, then the width of a space is subtracted.
Changed that width, stored in the local variable wordTrailingSpaceWidth, to include the
word spacing, since it is included in the result of widthFromCache().

LayoutTests: 

* fast/text/word-space-with-kerning-expected.html: Added.
* fast/text/word-space-with-kerning.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderText.cpp


Added Paths

trunk/LayoutTests/fast/text/word-space-with-kerning-expected.html
trunk/LayoutTests/fast/text/word-space-with-kerning.html




Diff

Modified: trunk/LayoutTests/ChangeLog (129067 => 129068)

--- trunk/LayoutTests/ChangeLog	2012-09-19 23:29:41 UTC (rev 129067)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 23:37:36 UTC (rev 129068)
@@ -1,3 +1,13 @@
+2012-09-19  Dan Bernstein  
+
+When kerning is enabled, word spacing is doubly accounted for in RenderText::computePreferredLogicalWidths
+https://bugs.webkit.org/show_bug.cgi?id=97146
+
+Reviewed by Anders Carlsson.
+
+* fast/text/word-space-with-kerning-expected.html: Added.
+* fast/text/word-space-with-kerning.html: Added.
+
 2012-09-19  Dirk Pranke  
 
 Fix lines missed (??) in mac-wk2/TestExpectations


Added: trunk/LayoutTests/fast/text/word-space-with-kerning-expected.html (0 => 129068)

--- trunk/LayoutTests/fast/text/word-space-with-kerning-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/word-space-with-kerning-expected.html	2012-09-19 23:37:36 UTC (rev 129068)
@@ -0,0 +1,8 @@
+
+
+a b c d  e
+
+
+a b c d  e
+
+


Added: trunk/LayoutTests/fast/text/word-space-with-kerning.html (0 => 129068)

--- trunk/LayoutTests/fast/text/word-space-with-kerning.html	(rev 0)
+++ trunk/LayoutTests/fast/text/word-space-with-kerning.html	2012-09-19 23:37:36 UTC (rev 129068)
@@ -0,0 +1,8 @@
+
+
+a b c d  e
+
+
+a b c d  e
+
+


Modified: trunk/Source/WebCore/ChangeLog (129067 => 129068)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 23:29:41 UTC (rev 129067)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 23:37:36 UTC (rev 129068)
@@ -1,3 +1,18 @@
+2012-09-19  Dan Bernstein  
+
+When kerning is enabled, word spacing is doubly accounted for in RenderText::computePreferredLogicalWidths
+https://bugs.webkit.org/show_bug.cgi?id=97146
+
+Reviewed by Anders Carlsson.
+
+Test: fast/text/word-space-with-kerning.html
+
+* rendering/RenderText.cpp:
+(WebCore::RenderText::computePreferredLogicalWidths): When kerning is enabled, words are
+measured with their trailing space, if there is one, then the width of a space is subtracted.
+Changed that width, stored in the local variable wordTrailingSpaceWidth, to include the
+word spacing, since it is included in the result of widthFromCache().
+
 2012-09-19  Joshua Bell  
 
 IndexedDB: Remove "current transaction" concept from backing store


Modified: trunk/Source/WebCore/rendering/RenderText.cpp (129067 => 129068)

--- trunk/Source/WebCore/rendering/RenderText.cpp	2012-09-19 23:29:41 UTC (rev 129067)
+++ trunk/Source/WebCore/rendering/RenderText.cpp	2012-09-19 23:37:36 UTC (rev 129068)
@@ -966,7 +966,7 @@
 
 // Non-zero only when kerning is enabled, in which case we measure words with their trailing
 // space, then subtract its width.
-float wordTrailingSpaceWidth = f.typesettingFeatures() & Kerning ? f.width(RenderBlock::constructTextRun(this, f, &space, 1, styleToUse)) : 0;
+float wordTrailingSpaceWidth = f.typesettingFeatures() & Kerning ? f.width(RenderBlock::constructTextRun(this, f, &space, 1, styleToUse)) + wordSpacing : 0;
 
 // If automatic hyphenation is allowed, we keep track of the width of the widest word (or word
 // fragment) encountered so far, and only try hyphenating words that are wider.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129067] trunk/LayoutTests

[dpranke]

Title: [129067] trunk/LayoutTests








Revision 129067
Author dpra...@chromium.org
Date 2012-09-19 16:29:41 -0700 (Wed, 19 Sep 2012)


Log Message
Fix lines missed (??) in mac-wk2/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97143

Unreviewed, expectations change.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129066 => 129067)

--- trunk/LayoutTests/ChangeLog	2012-09-19 23:27:20 UTC (rev 129066)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 23:29:41 UTC (rev 129067)
@@ -1,5 +1,14 @@
 2012-09-19  Dirk Pranke  
 
+Fix lines missed (??) in mac-wk2/TestExpectations
+https://bugs.webkit.org/show_bug.cgi?id=97143
+
+Unreviewed, expectations change.
+
+* platform/mac-wk2/TestExpectations:
+
+2012-09-19  Dirk Pranke  
+
 convert chromium android TestExpectations to the new syntax
 https://bugs.webkit.org/show_bug.cgi?id=97145
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (129066 => 129067)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-19 23:27:20 UTC (rev 129066)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-19 23:29:41 UTC (rev 129067)
@@ -10,6 +10,7 @@
 webkit.org/b/96580 css3/filters/custom/filter-fallback-to-software.html [ ImageOnlyFailure ]
 
 # new fast/load tests fail https://bugs.webkit.org/show_bug.cgi?id=96832
-BUGWK96832 : fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html = FAIL
-BUGWK96832 : fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html = FAIL
+webkit.org/b/96832 fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html [ Failure ]
+webkit.org/b/96832 fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html [ Failure ]
 
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129065] trunk/Source/JavaScriptCore

[fpizlo]

Title: [129065] trunk/Source/_javascript_Core








Revision 129065
Author fpi...@apple.com
Date 2012-09-19 16:27:00 -0700 (Wed, 19 Sep 2012)


Log Message
REGRESSION(r128802): It made some JS tests crash
https://bugs.webkit.org/show_bug.cgi?id=97001

Reviewed by Mark Hahnenberg.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (129064 => 129065)

--- trunk/Source/_javascript_Core/ChangeLog	2012-09-19 23:25:50 UTC (rev 129064)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-19 23:27:00 UTC (rev 129065)
@@ -1,5 +1,15 @@
 2012-09-19  Filip Pizlo  
 
+REGRESSION(r128802): It made some JS tests crash
+https://bugs.webkit.org/show_bug.cgi?id=97001
+
+Reviewed by Mark Hahnenberg.
+
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::visitChildren):
+
+2012-09-19  Filip Pizlo  
+
 DFG should not assume that a ByVal access is generic just because it was unprofiled
 https://bugs.webkit.org/show_bug.cgi?id=97088
 


Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp (129064 => 129065)

--- trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2012-09-19 23:25:50 UTC (rev 129064)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2012-09-19 23:27:00 UTC (rev 129065)
@@ -482,6 +482,7 @@
 visitor.append(&thisObject->m_nameScopeStructure);
 visitor.append(&thisObject->m_argumentsStructure);
 visitor.append(&thisObject->m_arrayStructure);
+visitor.append(&thisObject->m_arrayStructureForSlowPut);
 visitor.append(&thisObject->m_booleanObjectStructure);
 visitor.append(&thisObject->m_callbackConstructorStructure);
 visitor.append(&thisObject->m_callbackFunctionStructure);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129064] trunk/LayoutTests

[dpranke]

Title: [129064] trunk/LayoutTests








Revision 129064
Author dpra...@chromium.org
Date 2012-09-19 16:25:50 -0700 (Wed, 19 Sep 2012)


Log Message
convert chromium android TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97145

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/chromium-android/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-android/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129063 => 129064)

--- trunk/LayoutTests/ChangeLog	2012-09-19 23:23:02 UTC (rev 129063)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 23:25:50 UTC (rev 129064)
@@ -1,5 +1,16 @@
 2012-09-19  Dirk Pranke  
 
+convert chromium android TestExpectations to the new syntax
+https://bugs.webkit.org/show_bug.cgi?id=97145
+
+Unreviewed, expectations change.
+
+Files converted with Tools/Scripts/convert-test-expectations.
+
+* platform/chromium-android/TestExpectations:
+
+2012-09-19  Dirk Pranke  
+
 nrwt: convert chromium TestExpectations to the new syntax
 https://bugs.webkit.org/show_bug.cgi?id=97139
 


Modified: trunk/LayoutTests/platform/chromium-android/TestExpectations (129063 => 129064)

--- trunk/LayoutTests/platform/chromium-android/TestExpectations	2012-09-19 23:23:02 UTC (rev 129063)
+++ trunk/LayoutTests/platform/chromium-android/TestExpectations	2012-09-19 23:25:50 UTC (rev 129064)
@@ -1,86 +1,87 @@
-// This file should contain only the rules to skip tests about the features not supported
-// or not testable on Android.
-//
-// Other rules should be in TestExpectations.
+# This file should contain only the rules to skip tests about the features not supported
+# or not testable on Android.
+#
+# Other rules should be in TestExpectations.
 
-// Skip tests of other platforms to save time.
-WONTFIX SKIP : platform/gtk = PASS
-WONTFIX SKIP : platform/mac = PASS
-WONTFIX SKIP : platform/mac-wk2 = PASS
-WONTFIX SKIP : platform/qt = PASS
-WONTFIX SKIP : platform/win = PASS
+# Skip tests of other platforms to save time.
+platform/gtk [ Pass Skip WontFix ]
+platform/mac [ Pass Skip WontFix ]
+platform/mac-wk2 [ Pass Skip WontFix ]
+platform/qt [ Pass Skip WontFix ]
+platform/win [ Pass Skip WontFix ]
 
-// Features not supported: http://crbug.com/145338.
-BUGCR145338 SKIP : compositing/plugins = PASS
-BUGCR145338 SKIP : plugins = PASS
-BUGCR145338 SKIP : http/tests/plugins = PASS
-BUGCR145338 SKIP : platform/chromium/compositing/plugins = PASS
-BUGCR145338 SKIP : platform/chromium/plugins = PASS
+# Features not supported: http://crbug.com/145338.
+crbug.com/145338 compositing/plugins
+crbug.com/145338 plugins
+crbug.com/145338 http/tests/plugins
+crbug.com/145338 platform/chromium/compositing/plugins
+crbug.com/145338 platform/chromium/plugins
 
-BUGCR145338 SKIP : fast/dom/Window/Plug-ins.html = PASS
-BUGCR145338 SKIP : fast/frames/sandboxed-iframe-about-blank.html = PASS
-BUGCR145338 SKIP : fast/frames/sandboxed-iframe-navigation-allowed.html = PASS
-BUGCR145338 SKIP : fast/frames/sandboxed-iframe-plugins.html = PASS
-BUGCR145338 SKIP : fast/replaced/invalid-object-with-fallback.html = PASS
-BUGCR145338 SKIP : fast/replaced/object-with-embed-url-param.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/object-src-none-allowed.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/object-src-none-blocked.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/object-src-url-allowed.html = PASS
-BUGCR145338 SKIP : http/tests/security/contentSecurityPolicy/object-src-url-blocked.html = PASS
-BUGCR145338 SKIP : http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html = PASS
-BUGCR145338 SKIP : platform/chromium/permissionclient/plugin-permission.html = PASS
-BUGCR145338 SKIP : userscripts/user-script-plugin-document.html = PASS
+crbug.com/145338 fast/dom/Window/Plug-ins.html
+crbug.com/145338 fast/frames/sandboxed-iframe-about-blank.html
+crbug.com/145338 fast/frames/sandboxed-iframe-navigation-allowed.html
+crbug.com/145338 fast/frames/sandboxed-ifr

[webkit-changes] [129062] trunk/LayoutTests

[dpranke]

Title: [129062] trunk/LayoutTests








Revision 129062
Author dpra...@chromium.org
Date 2012-09-19 16:19:44 -0700 (Wed, 19 Sep 2012)


Log Message
convert apple win TestExpectations files to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97144

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/win-wk2/TestExpectations:
* platform/win-xp/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/win-wk2/TestExpectations
trunk/LayoutTests/platform/win-xp/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129061 => 129062)

--- trunk/LayoutTests/ChangeLog	2012-09-19 23:17:44 UTC (rev 129061)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 23:19:44 UTC (rev 129062)
@@ -1,5 +1,18 @@
 2012-09-19  Dirk Pranke  
 
+convert apple win TestExpectations files to the new syntax
+https://bugs.webkit.org/show_bug.cgi?id=97144
+
+Unreviewed, expectations change.
+
+Files converted with Tools/Scripts/convert-test-expectations.
+
+* platform/win-wk2/TestExpectations:
+* platform/win-xp/TestExpectations:
+* platform/win/TestExpectations:
+
+2012-09-19  Dirk Pranke  
+
 convert apple mac TestExpectations files to the new syntax
 https://bugs.webkit.org/show_bug.cgi?id=97143
 


Modified: trunk/LayoutTests/platform/win/TestExpectations (129061 => 129062)

--- trunk/LayoutTests/platform/win/TestExpectations	2012-09-19 23:17:44 UTC (rev 129061)
+++ trunk/LayoutTests/platform/win/TestExpectations	2012-09-19 23:19:44 UTC (rev 129062)
@@ -1,2 +1,3 @@
-// This file is intentionally left blank. Until the Apple win port supports new-run-webkit-tests (https://bugs.webkit.org/show_bug.cgi?id=38756)
-// this file does nothing.
+# This file is intentionally left blank. Until the Apple win port supports new-run-webkit-tests (https://bugs.webkit.org/show_bug.cgi?id=38756)
+# this file does nothing.
+


Modified: trunk/LayoutTests/platform/win-wk2/TestExpectations (129061 => 129062)

--- trunk/LayoutTests/platform/win-wk2/TestExpectations	2012-09-19 23:17:44 UTC (rev 129061)
+++ trunk/LayoutTests/platform/win-wk2/TestExpectations	2012-09-19 23:19:44 UTC (rev 129062)
@@ -1,2 +1,3 @@
-// This file should contain entries for expectations that are specific
-// to the Apple Windows port running the WebKit2 variant (--webkit-test-runner)
+# This file should contain entries for expectations that are specific
+# to the Apple Windows port running the WebKit2 variant (--webkit-test-runner)
+


Modified: trunk/LayoutTests/platform/win-xp/TestExpectations (129061 => 129062)

--- trunk/LayoutTests/platform/win-xp/TestExpectations	2012-09-19 23:17:44 UTC (rev 129061)
+++ trunk/LayoutTests/platform/win-xp/TestExpectations	2012-09-19 23:19:44 UTC (rev 129062)
@@ -1,2 +1,3 @@
-// This file should contain entries for expectations that are specific
-// to the Apple Windows port running on Windows XP.
+# This file should contain entries for expectations that are specific
+# to the Apple Windows port running on Windows XP.
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129057] trunk

[dpranke]

Title: [129057] trunk








Revision 129057
Author dpra...@chromium.org
Date 2012-09-19 16:00:37 -0700 (Wed, 19 Sep 2012)


Log Message
nrwt: convert chromium TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97139

Tools:

Reviewed by Ryosuke Niwa.

Add in a file temporarily that does the conversion of
test expectations formats

* Tools/Scripts/convert-test-expectations: Added.

LayoutTests:

Reviewed by Ryosuke Niwa.

This does a wholesale change of the file from

  BUGS MODIFIERS : test = EXPECTATIONS

to

  Bugs [ Modifiers] test [ Expectations ]

as per the new syntax.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Tools/ChangeLog


Added Paths

trunk/Tools/Scripts/convert-test-expectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129056 => 129057)

--- trunk/LayoutTests/ChangeLog	2012-09-19 22:53:20 UTC (rev 129056)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 23:00:37 UTC (rev 129057)
@@ -1,3 +1,22 @@
+2012-09-19  Dirk Pranke  
+
+nrwt: convert chromium TestExpectations to the new syntax
+https://bugs.webkit.org/show_bug.cgi?id=97139
+
+Reviewed by Ryosuke Niwa.
+
+This does a wholesale change of the file from
+
+  BUGS MODIFIERS : test = EXPECTATIONS
+
+to
+
+  Bugs [ Modifiers] test [ Expectations ]
+
+as per the new syntax.
+
+* platform/chromium/TestExpectations:
+
 2012-09-19  Joshua Bell  
 
 Unreviewed - remove debugging code from a pair of tests.


Modified: trunk/Tools/ChangeLog (129056 => 129057)

--- trunk/Tools/ChangeLog	2012-09-19 22:53:20 UTC (rev 129056)
+++ trunk/Tools/ChangeLog	2012-09-19 23:00:37 UTC (rev 129057)
@@ -1,3 +1,15 @@
+2012-09-19  Dirk Pranke  
+
+nrwt: convert chromium TestExpectations to the new syntax
+https://bugs.webkit.org/show_bug.cgi?id=97139
+
+Reviewed by Ryosuke Niwa.
+
+Add in a file temporarily that does the conversion of
+test expectations formats
+
+* Tools/Scripts/convert-test-expectations: Added.
+
 2012-09-19  Ryosuke Niwa  
 
 REGRESSION: run-perf-tests no longer reports the total test time


Added: trunk/Tools/Scripts/convert-test-expectations (0 => 129057)

--- trunk/Tools/Scripts/convert-test-expectations	(rev 0)
+++ trunk/Tools/Scripts/convert-test-expectations	2012-09-19 23:00:37 UTC (rev 129057)
@@ -0,0 +1,17 @@
+#!/usr/bin/python
+
+import sys
+
+from webkitpy.common.host import Host
+from webkitpy.layout_tests.models.test_expectations import TestExpectationParser
+
+host = Host()
+port = host.port_factory.get(sys.argv[1])
+filename = sys.argv[2]
+contents = host.filesystem.read_text_file(filename)
+
+parser = TestExpectationParser(port, [], False)
+expectation_lines = parser.parse(filename, contents)
+for line in expectation_lines:
+new_line = line.to_string(parser._test_configuration_converter)
+print new_line
Property changes on: trunk/Tools/Scripts/convert-test-expectations
___


Added: svn:executable




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129056] trunk/LayoutTests

[jsbell]

Title: [129056] trunk/LayoutTests








Revision 129056
Author jsb...@chromium.org
Date 2012-09-19 15:53:20 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed - remove debugging code from a pair of tests.

During development these tests had their own timers to terminate early
rather than timing out, so partial script output could be seen. Removing,
as it could cause the tests to flake under load.

* storage/indexeddb/lazy-index-population.html:
* storage/indexeddb/resources/cursor-finished.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/lazy-index-population.html
trunk/LayoutTests/storage/indexeddb/resources/cursor-finished.js




Diff

Modified: trunk/LayoutTests/ChangeLog (129055 => 129056)

--- trunk/LayoutTests/ChangeLog	2012-09-19 22:48:03 UTC (rev 129055)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 22:53:20 UTC (rev 129056)
@@ -1,3 +1,14 @@
+2012-09-19  Joshua Bell  
+
+Unreviewed - remove debugging code from a pair of tests.
+
+During development these tests had their own timers to terminate early
+rather than timing out, so partial script output could be seen. Removing,
+as it could cause the tests to flake under load.
+
+* storage/indexeddb/lazy-index-population.html:
+* storage/indexeddb/resources/cursor-finished.js:
+
 2012-09-19  Terry Anderson  
 
 [chromium] Store the contents scale factor in PlatformContextSkia on initialization


Modified: trunk/LayoutTests/storage/indexeddb/lazy-index-population.html (129055 => 129056)

--- trunk/LayoutTests/storage/indexeddb/lazy-index-population.html	2012-09-19 22:48:03 UTC (rev 129055)
+++ trunk/LayoutTests/storage/indexeddb/lazy-index-population.html	2012-09-19 22:53:20 UTC (rev 129056)
@@ -2,7 +2,7 @@
 

[webkit-changes] [129055] trunk/Tools

[rniwa]

Title: [129055] trunk/Tools








Revision 129055
Author rn...@webkit.org
Date 2012-09-19 15:48:03 -0700 (Wed, 19 Sep 2012)


Log Message
REGRESSION: run-perf-tests no longer reports the total test time
https://bugs.webkit.org/show_bug.cgi?id=97138

Reviewed by Tony Chang.

Report the finished time as a info-level log as opposed to a debug level log.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_memory_test):
(_test_run_with_json_output):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (129054 => 129055)

--- trunk/Tools/ChangeLog	2012-09-19 22:43:51 UTC (rev 129054)
+++ trunk/Tools/ChangeLog	2012-09-19 22:48:03 UTC (rev 129055)
@@ -1,3 +1,21 @@
+2012-09-19  Ryosuke Niwa  
+
+REGRESSION: run-perf-tests no longer reports the total test time
+https://bugs.webkit.org/show_bug.cgi?id=97138
+
+Reviewed by Tony Chang.
+
+Report the finished time as a info-level log as opposed to a debug level log.
+
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner._run_single_test):
+* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+(MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
+(test_run_test_pause_before_testing):
+(test_run_test_set_for_parser_tests):
+(test_run_memory_test):
+(_test_run_with_json_output):
+
 2012-09-19  Dirk Pranke  
 
 Support new TestExpectations format alongside old one


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (129054 => 129055)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py	2012-09-19 22:43:51 UTC (rev 129054)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py	2012-09-19 22:48:03 UTC (rev 129055)
@@ -317,6 +317,6 @@
 else:
 _log.error('FAILED')
 
-_log.debug("Finished: %f s" % (time.time() - start_time))
+_log.info("Finished: %f s" % (time.time() - start_time))
 
 return new_results != None


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (129054 => 129055)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py	2012-09-19 22:43:51 UTC (rev 129054)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py	2012-09-19 22:48:03 UTC (rev 129055)
@@ -31,6 +31,7 @@
 
 import StringIO
 import json
+import re
 import unittest
 
 from webkitpy.common.host_mock import MockHost
@@ -48,6 +49,9 @@
 def assertWritten(self, stream, contents):
 self.assertEquals(stream.buflist, contents)
 
+def normalizeFinishedTime(self, log):
+return re.sub(r'Finished: [0-9\.]+ s', 'Finished: 0.1 s', log)
+
 class TestDriver:
 def run_test(self, driver_input, stop_when_done):
 text = ''
@@ -234,7 +238,8 @@
 finally:
 stdout, stderr, log = output.restore_output()
 self.assertEqual(stderr, "Ready to run test?\n")
-self.assertEqual(log, "Running inspector/pass.html (1 of 1)\nRESULT group_name: test_name= 42 ms\n\n")
+self.assertEqual(self.normalizeFinishedTime(log),
+"Running inspector/pass.html (1 of 1)\nRESULT group_name: test_name= 42 ms\nFinished: 0.1 s\n\n")
 
 def test_run_test_set_for_parser_tests(self):
 runner, port = self.create_runner()
@@ -246,13 +251,15 @@
 finally:
 stdout, stderr, log = output.restore_output()
 self.assertEqual(unexpected_result_count, 0)
-self.assertEqual(log, '\n'.join(['Running Bindings/event-target-wrapper.html (1 of 2)',
+self.assertEqual(self.normalizeFinishedTime(log), '\n'.join(['Running Bindings/event-target-wrapper.html (1 of 2)',
 'RESULT Bindings: event-target-wrapper= 1489.05 ms',
 'median= 1487.0 ms, stdev= 14.46 ms, min= 1471.0 ms, max= 1510.0 ms',
+'Finished: 0.1 s',
 '',
 'Running Parser/some-parser.html (2 of 2)',
 'RESULT Parser: some-parser= 1100.0 ms',
 'median= 1101.0 ms, stdev= 11.0 ms, min= 1080.0 ms, max= 1120.0 ms',
+'Finished: 0.1 s',
 '', '']))
 
 def test_run_memory_test(self):
@@ -267,7 +274,7 @@
 finally:
 stdout, stderr, log = output.restore_output()
 self.assertEqual(unexpected_result_count, 0)
-self.assertEqual(log, '\n'.join([
+self.assertEqual(self.normalizeFinishedTime(log), '\n'.join([
 'Running 1 tests',
 'Running Parser/memo

[webkit-changes] [129054] trunk

[commit-queue]

Title: [129054] trunk








Revision 129054
Author commit-qu...@webkit.org
Date 2012-09-19 15:43:51 -0700 (Wed, 19 Sep 2012)


Log Message
[chromium] Store the contents scale factor in PlatformContextSkia on initialization
https://bugs.webkit.org/show_bug.cgi?id=96137

Patch by Terry Anderson  on 2012-09-19
Reviewed by Stephen White.

Source/WebCore:

When the compositor creates a PlatformContextSkia, the scale on |canvas| will
be equal to the content scale factor (which, without pinch-to-zoom, will be
the same as the device scale factor). Set this value as a member on PlatformContextSkia,
which will be used to correctly render glyphs when hinting is used and the device
scale factor is not 1.

Tests: added two new unit tests.

* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setupPaintCommon):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::setHintingScaleFactor):
(WebCore::PlatformContextSkia::hintingScaleFactor):

Source/WebKit/chromium:

Define SK_SUPPORT_HINTING_SCALE_FACTOR by default. This is also used
for the skia patch here: https://codereview.appspot.com/6506099/.
Also added two new unit tests.

* features.gypi:
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore):
(WebCore::HintingScaleCallback::HintingScaleCallback):
(HintingScaleCallback):
(WebCore::HintingScaleCallback::operator()):
(WebCore::TEST_F):
* tests/PlatformContextSkiaTest.cpp:
(WebCore):
(WebCore::TEST):

LayoutTests:

These tests will fail due to a font hinting/rasterization issue with
chromium DRT pixel tests having a page/device scale factor of 2.
See crbug.com/150682.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
trunk/Source/WebKit/chromium/tests/OpaqueRectTrackingContentLayerDelegateTest.cpp
trunk/Source/WebKit/chromium/tests/PlatformContextSkiaTest.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (129053 => 129054)

--- trunk/LayoutTests/ChangeLog	2012-09-19 22:36:44 UTC (rev 129053)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 22:43:51 UTC (rev 129054)
@@ -1,3 +1,16 @@
+2012-09-19  Terry Anderson  
+
+[chromium] Store the contents scale factor in PlatformContextSkia on initialization
+https://bugs.webkit.org/show_bug.cgi?id=96137
+
+Reviewed by Stephen White.
+
+These tests will fail due to a font hinting/rasterization issue with
+chromium DRT pixel tests having a page/device scale factor of 2.
+See crbug.com/150682.
+
+* platform/chromium/TestExpectations:
+
 2012-09-19  Dirk Pranke  
 
 nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129053 => 129054)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 22:36:44 UTC (rev 129053)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 22:43:51 UTC (rev 129054)
@@ -2595,6 +2595,24 @@
 BUGCR146756 LINUX WIN ANDROID MAC : platform/chromium/virtual/gpu/fast/hidpi/broken-image-icon-hidpi.html = IMAGE
 BUGCR146756 LINUX WIN ANDROID MAC : platform/chromium/virtual/gpu/fast/hidpi/broken-image-with-size-hidpi.html = IMAGE
 
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/clip-text-in-hidpi.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-as-background.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-background-repeat-without-size.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-background-repeat.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-border-image-comparison.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-border-image-dynamic.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-border-image-simple.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-in-content-dynamic.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-out-of-order.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-simple.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fast/hidpi/image-set-without-specified-width.html = IMAGE
+BUGCR150682 : platform/chromium/virtual/gpu/fa

[webkit-changes] [129053] trunk/Source/JavaScriptCore

[fpizlo]

Title: [129053] trunk/Source/_javascript_Core








Revision 129053
Author fpi...@apple.com
Date 2012-09-19 15:36:44 -0700 (Wed, 19 Sep 2012)


Log Message
DFG should not assume that a ByVal access is generic just because it was unprofiled
https://bugs.webkit.org/show_bug.cgi?id=97088

Reviewed by Geoffrey Garen.

We were not disambiguating between "Undecided" in the sense that the array profile
has no useful information versus "Undecided" in the sense that the array profile
knows that the access has not executed. That's an important distinction, since
the former form of "Undecided" means that we should consult value profiling, while
the latter means that we should force exit unless the value profiling indicates
that the access must be generic (base is not cell or property is not int).

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArrayMode.cpp:
(JSC::DFG::fromObserved):
(JSC::DFG::refineArrayMode):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
* dfg/DFGArrayMode.h:
(JSC::DFG::canCSEStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):
(JSC::DFG::benefitsFromStructureCheck):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp
trunk/Source/_javascript_Core/dfg/DFGArrayMode.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (129052 => 129053)

--- trunk/Source/_javascript_Core/ChangeLog	2012-09-19 22:36:35 UTC (rev 129052)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-19 22:36:44 UTC (rev 129053)
@@ -1,5 +1,32 @@
 2012-09-19  Filip Pizlo  
 
+DFG should not assume that a ByVal access is generic just because it was unprofiled
+https://bugs.webkit.org/show_bug.cgi?id=97088
+
+Reviewed by Geoffrey Garen.
+
+We were not disambiguating between "Undecided" in the sense that the array profile
+has no useful information versus "Undecided" in the sense that the array profile
+knows that the access has not executed. That's an important distinction, since
+the former form of "Undecided" means that we should consult value profiling, while
+the latter means that we should force exit unless the value profiling indicates
+that the access must be generic (base is not cell or property is not int).
+
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::execute):
+* dfg/DFGArrayMode.cpp:
+(JSC::DFG::fromObserved):
+(JSC::DFG::refineArrayMode):
+(JSC::DFG::modeAlreadyChecked):
+(JSC::DFG::modeToString):
+* dfg/DFGArrayMode.h:
+(JSC::DFG::canCSEStorage):
+(JSC::DFG::modeIsSpecific):
+(JSC::DFG::modeSupportsLength):
+(JSC::DFG::benefitsFromStructureCheck):
+
+2012-09-19  Filip Pizlo  
+
 DFG should not emit PutByVal hole case unless it has to
 https://bugs.webkit.org/show_bug.cgi?id=97080
 


Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (129052 => 129053)

--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp	2012-09-19 22:36:35 UTC (rev 129052)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp	2012-09-19 22:36:44 UTC (rev 129053)
@@ -841,6 +841,7 @@
 node.setCanExit(true);
 switch (node.arrayMode()) {
 case Array::Undecided:
+case Array::Unprofiled:
 ASSERT_NOT_REACHED();
 break;
 case Array::ForceExit:


Modified: trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp (129052 => 129053)

--- trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp	2012-09-19 22:36:35 UTC (rev 129052)
+++ trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp	2012-09-19 22:36:44 UTC (rev 129053)
@@ -36,7 +36,7 @@
 {
 switch (profile->observedArrayModes()) {
 case 0:
-return Array::Undecided;
+return Array::Unprofiled;
 case asArrayModes(NonArray):
 if (action == Array::Write && !profile->mayInterceptIndexedAccesses())
 return Array::BlankToArrayStorage; // FIXME: we don't know whether to go to slow put mode, or not. This is a decent guess.
@@ -87,6 +87,12 @@
 if (!isInt32Speculation(index) || !isCellSpeculation(base))
 return Array::Generic;
 
+if (arrayMode == Array::Unprofiled) {
+// If the indexing type wasn't recorded in the array profile but the values are
+// base=cell property=int, then we know that this access didn't execute.
+return Array::ForceExit;
+}
+
 if (arrayMode != Array::Undecided)
 return arrayMode;
 
@@ -198,6 +204,7 @@
 return isFloat64ArraySpeculation(value.m_type);
 
 case Array::Undecided:
+case Array::Unprofiled:
 break;
 }
 
@@ -210,6 +217,8 @@
 switch (mode) {
 case Array::Undecided:
 return "Undecided";
+case Array::Unprofiled:
+return "Unprofiled";
 case Array::Generic

[webkit-changes] [129051] trunk/Tools

[dpranke]

Title: [129051] trunk/Tools








Revision 129051
Author dpra...@chromium.org
Date 2012-09-19 15:29:45 -0700 (Wed, 19 Sep 2012)


Log Message
implement first part of support for the new TestExpectations syntax
https://bugs.webkit.org/show_bug.cgi?id=96569

Reviewed by Ryosuke Niwa.

This patch implements support for parsing a line of the new
format for the TestExpectations file and converting it back into
the old format for compatibility. This routine is not yet used
by anything.

The new format is documented at:
  http://trac.webkit.org/wiki/TestExpectations

but, in short:

  [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]

- Comments are indicated with "#" instead of "//"
- If no expectations are specified we default to Skip for
  compatibility with the Skipped files (these two changes make
  Skipped files a subset of TestExpectations files)

- All of the tokens are now CamelCase instead of ALLCAPS.
- FAIL -> Failure
- IMAGE -> ImageOnlyFailure
- WONTFIX -> WontFix
- modifiers refer to just the platforms and configurations
  (release/debug) that the line applies to.
- WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
  expectations
- expectations will typically be written out in lexicographic order
- We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
  instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectationParser._tokenize_line_using_new_format):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(NewExpectationSyntaxTests):
(NewExpectationSyntaxTests.assert_exp):
(NewExpectationSyntaxTests.test_bare_name):
(NewExpectationSyntaxTests.test_bare_name_and_bugs):
(NewExpectationSyntaxTests.test_comments):
(NewExpectationSyntaxTests.test_config_modifiers):
(NewExpectationSyntaxTests.test_unknown_config):
(NewExpectationSyntaxTests.test_unknown_expectation):
(NewExpectationSyntaxTests.test_skip):
(NewExpectationSyntaxTests.test_slow):
(NewExpectationSyntaxTests.test_wontfix):
(NewExpectationSyntaxTests.test_blank_line):
(NewExpectationSyntaxTests.test_warnings):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (129050 => 129051)

--- trunk/Tools/ChangeLog	2012-09-19 22:29:05 UTC (rev 129050)
+++ trunk/Tools/ChangeLog	2012-09-19 22:29:45 UTC (rev 129051)
@@ -1,5 +1,59 @@
 2012-09-19  Dirk Pranke  
 
+implement first part of support for the new TestExpectations syntax
+https://bugs.webkit.org/show_bug.cgi?id=96569
+
+Reviewed by Ryosuke Niwa.
+
+This patch implements support for parsing a line of the new
+format for the TestExpectations file and converting it back into
+the old format for compatibility. This routine is not yet used
+by anything.
+
+The new format is documented at:
+  http://trac.webkit.org/wiki/TestExpectations
+
+but, in short:
+
+  [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
+
+- Comments are indicated with "#" instead of "//"
+- If no expectations are specified we default to Skip for
+  compatibility with the Skipped files (these two changes make
+  Skipped files a subset of TestExpectations files)
+
+- All of the tokens are now CamelCase instead of ALLCAPS.
+- FAIL -> Failure
+- IMAGE -> ImageOnlyFailure
+- WONTFIX -> WontFix
+- modifiers refer to just the platforms and configurations
+  (release/debug) that the line applies to.
+- WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
+  expectations
+- expectations will typically be written out in lexicographic order
+- We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
+  instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
+
+* Scripts/webkitpy/layout_tests/models/test_expectations.py:
+(TestExpectationParser):
+(TestExpectationParser._tokenize_line_using_new_format):
+* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
+(NewExpectationSyntaxTests):
+(NewExpectationSyntaxTests.assert_exp):
+(NewExpectationSyntaxTests.test_bare_name):
+(NewExpectationSyntaxTests.test_bare_name_and_bugs):
+(NewExpectationSyntaxTests.test_comments):
+(NewExpectationSyntaxTests.test_config_modifiers):
+(NewExpectationSyntaxTests.test_unknown_config):
+(NewExpectationSyntaxTests.test_unknown_expectation):
+(NewExpectationSyntaxTests.test_skip):
+(NewExpectationSyntaxTests.test_slow):
+(NewExpectationSyntaxTests.test_wontfix):
+(NewExpectationSyntaxTests.test_blank_line):
+(NewExpectationSyntaxTests.test_warnings):
+
+2012-09-1

[webkit-changes] [129050] trunk/Source/WebCore

[bashi]

Title: [129050] trunk/Source/WebCore








Revision 129050
Author ba...@chromium.org
Date 2012-09-19 15:29:05 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] HarfBuzzShaper should take into account combining characters
https://bugs.webkit.org/show_bug.cgi?id=97069

Reviewed by Tony Chang.

When dividing a text run into HarfBuzzRuns, try to find suitable SimpleFontData for
combining character sequence if there are one or more mark characters are followed.
If there is no combined glyphs in the font, use fallback font for mark characters.

No new tests.
In platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html,
U+0947 (devanagari vowel sign e) should be displayed.
In fast/text/wide-zero-width-space.html, é and eĭ should look identical.

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore):
(WebCore::fontDataForCombiningCharacterSequence): Added.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns): See above description.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129049 => 129050)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 22:23:25 UTC (rev 129049)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 22:29:05 UTC (rev 129050)
@@ -1,3 +1,24 @@
+2012-09-19  Kenichi Ishibashi  
+
+[Chromium] HarfBuzzShaper should take into account combining characters
+https://bugs.webkit.org/show_bug.cgi?id=97069
+
+Reviewed by Tony Chang.
+
+When dividing a text run into HarfBuzzRuns, try to find suitable SimpleFontData for
+combining character sequence if there are one or more mark characters are followed.
+If there is no combined glyphs in the font, use fallback font for mark characters.
+
+No new tests.
+In platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html,
+U+0947 (devanagari vowel sign e) should be displayed.
+In fast/text/wide-zero-width-space.html, é and eĭ should look identical.
+
+* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
+(WebCore):
+(WebCore::fontDataForCombiningCharacterSequence): Added.
+(WebCore::HarfBuzzShaper::collectHarfBuzzRuns): See above description.
+
 2012-09-19  Tony Chang  
 
 Remove RenderIFrame::updateLogicalHeight and RenderIFrame::updateLogicalWidth


Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp (129049 => 129050)

--- trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp	2012-09-19 22:23:25 UTC (rev 129049)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp	2012-09-19 22:29:05 UTC (rev 129050)
@@ -229,8 +229,23 @@
 return point + m_startOffset;
 }
 
+static const SimpleFontData* fontDataForCombiningCharacterSequence(const Font* font, const UChar* characters, size_t length)
+{
+UErrorCode error = U_ZERO_ERROR;
+Vector normalizedCharacters(length);
+int32_t normalizedLength = unorm_normalize(characters, length, UNORM_NFC, UNORM_UNICODE_3_2, &normalizedCharacters[0], length, &error);
+// Should fallback if we have an error or no composition occurred.
+if (U_FAILURE(error) || (static_cast(normalizedLength) == length))
+return 0;
+UChar32 normalizedCharacter;
+size_t index = 0;
+U16_NEXT(&normalizedCharacters[0], index, static_cast(normalizedLength), normalizedCharacter);
+return font->glyphDataForCharacter(normalizedCharacter, false).fontData;
+}
+
 bool HarfBuzzShaper::collectHarfBuzzRuns()
 {
+const UChar* normalizedBufferEnd = m_normalizedBuffer.get() + m_normalizedBufferLength;
 SurrogatePairAwareTextIterator iterator(m_normalizedBuffer.get(), 0, m_normalizedBufferLength, m_normalizedBufferLength);
 UChar32 character;
 unsigned clusterLength = 0;
@@ -245,18 +260,40 @@
 return false;
 
 do {
+const UChar* currentCharacterPosition = iterator.characters();
 const SimpleFontData* currentFontData = nextFontData;
 UScriptCode currentScript = nextScript;
 
 for (iterator.advance(clusterLength); iterator.consume(character, clusterLength); iterator.advance(clusterLength)) {
-nextFontData = m_font->glyphDataForCharacter(character, false).fontData;
-if (nextFontData != currentFontData)
-break;
+if (Font::treatAsZeroWidthSpace(character))
+continue;
+if (U_GET_GC_MASK(character) & U_GC_M_MASK) {
+int markLength = clusterLength;
+const UChar* markCharactersEnd = iterator.characters() + clusterLength;
+while (markCharactersEnd < normalizedBufferEnd) {
+UChar32 nextCharacter;
+int nextCharacterLength = 0;
+U16_NEXT(markCharactersEnd, nextCharacterLength, normalizedBufferEnd - markCharactersEnd, nextCharacter);
+if (!(U_G

[webkit-changes] [129049] trunk/Source/WebKit2

[psolanki]

Title: [129049] trunk/Source/WebKit2








Revision 129049
Author psola...@apple.com
Date 2012-09-19 15:23:25 -0700 (Wed, 19 Sep 2012)


Log Message
Warning in SandboxExtension.h if WEB_PROCESS_SANDBOX is not enabled
https://bugs.webkit.org/show_bug.cgi?id=97137

Reviewed by Benjamin Poulain.

m_size is only used when WEB_PROCESS_SANDBOX is enabled, so move its declaration inside
#if ENABLE(WEB_PROCESS_SANDBOX).

* Shared/SandboxExtension.h:
(HandleArray):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/SandboxExtension.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (129048 => 129049)

--- trunk/Source/WebKit2/ChangeLog	2012-09-19 22:01:09 UTC (rev 129048)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-19 22:23:25 UTC (rev 129049)
@@ -1,3 +1,16 @@
+2012-09-19  Pratik Solanki  
+
+Warning in SandboxExtension.h if WEB_PROCESS_SANDBOX is not enabled
+https://bugs.webkit.org/show_bug.cgi?id=97137
+
+Reviewed by Benjamin Poulain.
+
+m_size is only used when WEB_PROCESS_SANDBOX is enabled, so move its declaration inside
+#if ENABLE(WEB_PROCESS_SANDBOX).
+
+* Shared/SandboxExtension.h:
+(HandleArray):
+
 2012-09-19  Sudarsana Nagineni  
 
 [WTR] Memory leaks in TestRunner::deliverWebIntent()


Modified: trunk/Source/WebKit2/Shared/SandboxExtension.h (129048 => 129049)

--- trunk/Source/WebKit2/Shared/SandboxExtension.h	2012-09-19 22:01:09 UTC (rev 129048)
+++ trunk/Source/WebKit2/Shared/SandboxExtension.h	2012-09-19 22:23:25 UTC (rev 129049)
@@ -84,10 +84,10 @@
 private:
 #if ENABLE(WEB_PROCESS_SANDBOX)
 Handle* m_data;
+size_t m_size;
 #else
 Handle m_emptyHandle;
 #endif
-size_t m_size;
 };
 
 static PassRefPtr create(const Handle&);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129048] trunk/Source/WebKit/chromium

[dgrogan]

Title: [129048] trunk/Source/WebKit/chromium








Revision 129048
Author dgro...@chromium.org
Date 2012-09-19 15:01:09 -0700 (Wed, 19 Sep 2012)


Log Message
Disable some failing IDB tests
https://bugs.webkit.org/show_bug.cgi?id=97135

Reviewed by Nate Chapin.

They were broken in r129037.

* tests/IDBDatabaseBackendTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129047 => 129048)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 21:51:57 UTC (rev 129047)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 22:01:09 UTC (rev 129048)
@@ -1,3 +1,14 @@
+2012-09-19  David Grogan  
+
+Disable some failing IDB tests
+https://bugs.webkit.org/show_bug.cgi?id=97135
+
+Reviewed by Nate Chapin.
+
+They were broken in r129037.
+
+* tests/IDBDatabaseBackendTest.cpp:
+
 2012-09-19  Alpha Lam  
 
 [chromium] Unreviewed. Build fix.


Modified: trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp (129047 => 129048)

--- trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp	2012-09-19 21:51:57 UTC (rev 129047)
+++ trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp	2012-09-19 22:01:09 UTC (rev 129048)
@@ -113,7 +113,7 @@
 FakeIDBDatabaseCallbacks() { }
 };
 
-TEST(IDBDatabaseBackendTest, ConnectionLifecycle)
+TEST(IDBDatabaseBackendTest, DISABLED_ConnectionLifecycle)
 {
 RefPtr backingStore = adoptRef(new IDBFakeBackingStore());
 EXPECT_TRUE(backingStore->hasOneRef());
@@ -172,7 +172,7 @@
 WebIDBDatabaseImpl& m_webDatabase;
 };
 
-TEST(IDBDatabaseBackendTest, ForcedClose)
+TEST(IDBDatabaseBackendTest, DISABLED_ForcedClose)
 {
 RefPtr backingStore = adoptRef(new IDBFakeBackingStore());
 EXPECT_TRUE(backingStore->hasOneRef());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129046] trunk/Source/WebCore

[tony]

Title: [129046] trunk/Source/WebCore








Revision 129046
Author t...@chromium.org
Date 2012-09-19 14:47:40 -0700 (Wed, 19 Sep 2012)


Log Message
Remove RenderIFrame::updateLogicalHeight and RenderIFrame::updateLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=97049

Reviewed by Ojan Vafai.

This is an incremental step in making updateLogicalHeight non-virtual so it's
possible to call computeLogicalHeight on any RenderBox and get the right
version of the function.

The code in RenderIFrame::layout was calling flattenFrame(), which would
query it's bounding box size.  Since we hadn't done a layout yet, the size
is unknown.  The fix is to only call flattenFrame() after calling
updateLogicalWidth and updateLogicalHeight. We can then fixup the size of
the iframe.

No new tests, existing tests in fast/frames/flattening should continue to pass.

* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::layout):
* rendering/RenderIFrame.h:
(RenderIFrame):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderIFrame.cpp
trunk/Source/WebCore/rendering/RenderIFrame.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (129045 => 129046)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 21:43:10 UTC (rev 129045)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 21:47:40 UTC (rev 129046)
@@ -1,3 +1,27 @@
+2012-09-19  Tony Chang  
+
+Remove RenderIFrame::updateLogicalHeight and RenderIFrame::updateLogicalWidth
+https://bugs.webkit.org/show_bug.cgi?id=97049
+
+Reviewed by Ojan Vafai.
+
+This is an incremental step in making updateLogicalHeight non-virtual so it's
+possible to call computeLogicalHeight on any RenderBox and get the right
+version of the function.
+
+The code in RenderIFrame::layout was calling flattenFrame(), which would
+query it's bounding box size.  Since we hadn't done a layout yet, the size
+is unknown.  The fix is to only call flattenFrame() after calling
+updateLogicalWidth and updateLogicalHeight. We can then fixup the size of
+the iframe.
+
+No new tests, existing tests in fast/frames/flattening should continue to pass.
+
+* rendering/RenderIFrame.cpp:
+(WebCore::RenderIFrame::layout):
+* rendering/RenderIFrame.h:
+(RenderIFrame):
+
 2012-09-19  Joshua Bell  
 
 IndexedDB: Free up resources used by completed cursors earlier


Modified: trunk/Source/WebCore/rendering/RenderIFrame.cpp (129045 => 129046)

--- trunk/Source/WebCore/rendering/RenderIFrame.cpp	2012-09-19 21:43:10 UTC (rev 129045)
+++ trunk/Source/WebCore/rendering/RenderIFrame.cpp	2012-09-19 21:47:40 UTC (rev 129046)
@@ -43,46 +43,6 @@
 {
 }
 
-void RenderIFrame::updateLogicalHeight()
-{
-RenderPart::updateLogicalHeight();
-if (!flattenFrame())
- return;
-
-HTMLIFrameElement* frame = static_cast(node());
-bool isScrollable = frame->scrollingMode() != ScrollbarAlwaysOff;
-
-if (isScrollable || !style()->height().isFixed()) {
-FrameView* view = static_cast(widget());
-if (!view)
-return;
-int border = borderTop() + borderBottom();
-setHeight(max(height(), view->contentsHeight() + border));
-}
-}
-
-void RenderIFrame::updateLogicalWidth()
-{
-// When we're seamless, we behave like a block. Thankfully RenderBox has all the right logic for this.
-if (isSeamless())
-return RenderBox::updateLogicalWidth();
-
-RenderPart::updateLogicalWidth();
-if (!flattenFrame())
-return;
-
-HTMLIFrameElement* frame = static_cast(node());
-bool isScrollable = frame->scrollingMode() != ScrollbarAlwaysOff;
-
-if (isScrollable || !style()->width().isFixed()) {
-FrameView* view = static_cast(widget());
-if (!view)
-return;
-LayoutUnit border = borderLeft() + borderRight();
-setWidth(max(width(), view->contentsWidth() + border));
-}
-}
-
 bool RenderIFrame::shouldComputeSizeAsReplaced() const
 {
 // When we're seamless, we use normal block/box sizing code except when inline.
@@ -189,19 +149,16 @@
 {
 ASSERT(needsLayout());
 
-if (flattenFrame()) {
-RenderPart::updateLogicalWidth();
-RenderPart::updateLogicalHeight();
-layoutWithFlattening(style()->width().isFixed(), style()->height().isFixed());
-// FIXME: Is early return really OK here? What about transform/overflow code below?
-return;
-} else if (isSeamless()) {
+if (isSeamless()) {
 layoutSeamlessly();
 // Do not return so as to share the layer and overflow updates below.
 } else {
 updateLogicalWidth();
 // No kids to layout as a replaced element.
 updateLogicalHeight();
+
+if (flattenFrame())
+layoutWithFlattening(style()->width().isFixed(), style()->height().isFixed());
 }
 
 m_overflow.clear();


Modified: trunk/Source/WebCore/rendering/RenderIFrame.h (

[webkit-changes] [129045] trunk/Source/JavaScriptCore

[fpizlo]

Title: [129045] trunk/Source/_javascript_Core








Revision 129045
Author fpi...@apple.com
Date 2012-09-19 14:43:10 -0700 (Wed, 19 Sep 2012)


Log Message
DFG should not emit PutByVal hole case unless it has to
https://bugs.webkit.org/show_bug.cgi?id=97080

Reviewed by Geoffrey Garen.

This causes us to generate less code for typical PutByVal's. But if profiling tells us
that the hole case is being hit, we generate the same code as we would have generated
before. This seems like a slight speed-up across the board.

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::store8):
(MacroAssemblerARMv7):
* assembler/MacroAssemblerX86.h:
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::store8):
* assembler/MacroAssemblerX86_64.h:
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::store8):
* assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::movb_i8m):
* bytecode/ArrayProfile.h:
(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::addressOfMayStoreToHole):
(JSC::ArrayProfile::mayStoreToHole):
(ArrayProfile):
* dfg/DFGArrayMode.cpp:
(JSC::DFG::fromObserved):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
* dfg/DFGArrayMode.h:
(DFG):
(JSC::DFG::mayStoreToHole):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.h:
(JIT):
* jit/JITInlineMethods.h:
(JSC::JIT::emitArrayProfileStoreToHoleSpecialCase):
(JSC):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h
trunk/Source/_javascript_Core/assembler/X86Assembler.h
trunk/Source/_javascript_Core/bytecode/ArrayProfile.h
trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp
trunk/Source/_javascript_Core/dfg/DFGArrayMode.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITInlineMethods.h
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (129044 => 129045)

--- trunk/Source/_javascript_Core/ChangeLog	2012-09-19 21:35:01 UTC (rev 129044)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-19 21:43:10 UTC (rev 129045)
@@ -1,3 +1,54 @@
+2012-09-19  Filip Pizlo  
+
+DFG should not emit PutByVal hole case unless it has to
+https://bugs.webkit.org/show_bug.cgi?id=97080
+
+Reviewed by Geoffrey Garen.
+
+This causes us to generate less code for typical PutByVal's. But if profiling tells us
+that the hole case is being hit, we generate the same code as we would have generated
+before. This seems like a slight speed-up across the board.
+
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::store8):
+(MacroAssemblerARMv7):
+* assembler/MacroAssemblerX86.h:
+(MacroAssemblerX86):
+(JSC::MacroAssemblerX86::store8):
+* assembler/MacroAssemblerX86_64.h:
+(MacroAssemblerX86_64):
+(JSC::MacroAssemblerX86_64::store8):
+* assembler/X86Assembler.h:
+(X86Assembler):
+(JSC::X86Assembler::movb_i8m):
+* bytecode/ArrayProfile.h:
+(JSC::ArrayProfile::ArrayProfile):
+(JSC::ArrayProfile::addressOfMayStoreToHole):
+(JSC::ArrayProfile::mayStoreToHole):
+(ArrayProfile):
+* dfg/DFGArrayMode.cpp:
+(JSC::DFG::fromObserved):
+(JSC::DFG::modeAlreadyChecked):
+(JSC::DFG::modeToString):
+* dfg/DFGArrayMode.h:
+(DFG):
+(JSC::DFG::mayStoreToHole):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* jit/JIT.h:
+(JIT):
+* jit/JITInlineMethods.h:
+(JSC::JIT::emitArrayProfileStoreToHoleSpecialCase):
+(JSC):
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::emit_op_put_by_val):
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::emit_op_put_by_val):
+* llint/LowLevelInterpreter32_64.asm:
+* llint/LowLevelInterpreter64.asm:
+
 2012-09-18  Filip Pizlo  
 
 DFG should not call out to C++ every time that it tries to put to an object that doesn't yet have array storage


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (129044 => 129045)

--- trunk/So

[webkit-changes] [129044] trunk/Source/WebKit/blackberry

[mifenton]

Title: [129044] trunk/Source/WebKit/blackberry








Revision 129044
Author mifen...@rim.com
Date 2012-09-19 14:35:01 -0700 (Wed, 19 Sep 2012)


Log Message
[BlackBerry] After zooming into an input field, zoom out when focus is lost.
https://bugs.webkit.org/show_bug.cgi?id=97128

Reviewed by Rob Buis.

When the page has automatically zoomed in for input
focus, unzoom it when input focus is lost or keyboard hidden.

Reviewed Internally by Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
* WebKitSupport/InputHandler.h:
(InputHandler):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (129043 => 129044)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-19 21:10:14 UTC (rev 129043)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-19 21:35:01 UTC (rev 129044)
@@ -1,3 +1,21 @@
+2012-09-19  Mike Fenton  
+
+[BlackBerry] After zooming into an input field, zoom out when focus is lost.
+https://bugs.webkit.org/show_bug.cgi?id=97128
+
+Reviewed by Rob Buis.
+
+When the page has automatically zoomed in for input
+focus, unzoom it when input focus is lost or keyboard hidden.
+
+Reviewed Internally by Gen Mak.
+
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::InputHandler::InputHandler):
+(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
+* WebKitSupport/InputHandler.h:
+(InputHandler):
+
 2012-09-19  Nima Ghanavatian  
 
 [BlackBerry] Clean up the SpellingLog output


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (129043 => 129044)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-09-19 21:10:14 UTC (rev 129043)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-09-19 21:35:01 UTC (rev 129044)
@@ -138,6 +138,7 @@
 , m_delayKeyboardVisibilityChange(false)
 , m_request(0)
 , m_processingTransactionId(-1)
+, m_focusZoomScale(0.0)
 {
 }
 
@@ -1125,8 +1126,14 @@
 // If the text is too small, zoom in to make it a minimum size.
 // The minimum size being defined as 3 mm is a good value based on my observations.
 static const int s_minimumTextHeightInPixels = Graphics::Screen::primaryScreen()->widthInMMToPixels(3);
-if (fontHeight && fontHeight < s_minimumTextHeightInPixels)
-m_webPage->zoomAboutPoint(s_minimumTextHeightInPixels / fontHeight, selectionFocusRect.location());
+if (fontHeight && fontHeight < s_minimumTextHeightInPixels) {
+m_focusZoomScale = s_minimumTextHeightInPixels / fontHeight;
+m_focusZoomLocation = selectionFocusRect.location();
+m_webPage->zoomAboutPoint(m_focusZoomScale, m_focusZoomLocation);
+} else {
+m_focusZoomScale = 0.0;
+m_focusZoomLocation = WebCore::IntPoint();
+}
 }
 
 void InputHandler::ensureFocusPluginElementVisible()


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h (129043 => 129044)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h	2012-09-19 21:10:14 UTC (rev 129043)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h	2012-09-19 21:35:01 UTC (rev 129044)
@@ -19,6 +19,7 @@
 #ifndef InputHandler_h
 #define InputHandler_h
 
+#include "FloatPoint.h"
 #include "TextChecking.h"
 
 #include 
@@ -221,6 +222,9 @@
 
 RefPtr m_request;
 int32_t m_processingTransactionId;
+
+double m_focusZoomScale;
+WebCore::FloatPoint m_focusZoomLocation;
 };
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129043] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [129043] trunk/Source/WebKit/blackberry








Revision 129043
Author commit-qu...@webkit.org
Date 2012-09-19 14:10:14 -0700 (Wed, 19 Sep 2012)


Log Message
[BlackBerry] Clean up the SpellingLog output
https://bugs.webkit.org/show_bug.cgi?id=97129

Patch by Nima Ghanavatian  on 2012-09-19
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (129042 => 129043)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-19 21:09:01 UTC (rev 129042)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-19 21:10:14 UTC (rev 129043)
@@ -1,3 +1,16 @@
+2012-09-19  Nima Ghanavatian  
+
+[BlackBerry] Clean up the SpellingLog output
+https://bugs.webkit.org/show_bug.cgi?id=97129
+
+Reviewed by Rob Buis.
+
+Internally reviewed by Mike Fenton.
+
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
+(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
+
 2012-09-19  Mike Fenton  
 
 [BlackBerry] Add SpellingLog for spell checking options request.


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (129042 => 129043)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-09-19 21:09:01 UTC (rev 129042)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-09-19 21:10:14 UTC (rev 129043)
@@ -603,18 +603,21 @@
 
 void InputHandler::spellCheckingRequestCancelled(int32_t transactionId)
 {
-if (transactionId != m_processingTransactionId)
-SpellingLog(LogLevelWarn, "InputHandler::spellCheckingRequestCancelled We are out of sync with input service. Expected transaction id %d, received %d.", m_processingTransactionId, transactionId);
-else
-SpellingLog(LogLevelWarn, "InputHandler::spellCheckingRequestCancelled Request with transaction id %d has been cancelled.", transactionId);
+SpellingLog(LogLevelWarn, "InputHandler::spellCheckingRequestCancelled Expected transaction id %d, received %d. %s"
+, transactionId
+, m_processingTransactionId
+, transactionId == m_processingTransactionId ? "" : "We are out of sync with input service.");
+
 m_request->didCancel();
 m_processingTransactionId = -1;
 }
 
 void InputHandler::spellCheckingRequestProcessed(int32_t transactionId, spannable_string_t* spannableString)
 {
-if (transactionId != m_processingTransactionId)
-SpellingLog(LogLevelWarn, "InputHandler::spellCheckingRequestProcessed We are out of sync with input service. Expected transaction id %d, received %d.", m_processingTransactionId, transactionId);
+SpellingLog(LogLevelWarn, "InputHandler::spellCheckingRequestProcessed Expected transaction id %d, received %d. %s"
+, transactionId
+, m_processingTransactionId
+, transactionId == m_processingTransactionId ? "" : "We are out of sync with input service.");
 
 if (!spannableString || !isActiveTextEdit()) {
 SpellingLog(LogLevelWarn, "InputHandler::spellCheckingRequestProcessed Cancelling request with transactionId %d.", transactionId);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129042] trunk/LayoutTests

[commit-queue]

Title: [129042] trunk/LayoutTests








Revision 129042
Author commit-qu...@webkit.org
Date 2012-09-19 14:09:01 -0700 (Wed, 19 Sep 2012)


Log Message
[chromium] compositing/geometry/fixed-position-iframe-composited-page-scale-down test needs rebaseline for r129023.
https://bugs.webkit.org/show_bug.cgi?id=97130

Patch by Robert Flack  on 2012-09-19
Reviewed by Nate Chapin.

Rebaseline compositing/geometry/fixed-position-iframe-composited-page-scale-down.html.

* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (129041 => 129042)

--- trunk/LayoutTests/ChangeLog	2012-09-19 20:52:43 UTC (rev 129041)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 21:09:01 UTC (rev 129042)
@@ -1,3 +1,15 @@
+2012-09-19  Robert Flack  
+
+[chromium] compositing/geometry/fixed-position-iframe-composited-page-scale-down test needs rebaseline for r129023.
+https://bugs.webkit.org/show_bug.cgi?id=97130
+
+Reviewed by Nate Chapin.
+
+Rebaseline compositing/geometry/fixed-position-iframe-composited-page-scale-down.html.
+
+* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
+* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
+
 2012-09-19  Joshua Bell  
 
 IndexedDB: Free up resources used by completed cursors earlier


Modified: trunk/LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129038] trunk

[jsbell]

Title: [129038] trunk








Revision 129038
Author jsb...@chromium.org
Date 2012-09-19 13:35:19 -0700 (Wed, 19 Sep 2012)


Log Message
IndexedDB: Free up resources used by completed cursors earlier
https://bugs.webkit.org/show_bug.cgi?id=97023

Reviewed by Tony Chang.

Source/WebCore:

Prior to this patch, IDBCursor objects are kept around by their parent
IDBTransaction until the transaction finishes. It's possible to release
references to them earlier, when the cursor has been "run to the end",
as no further events will fire and all calls to continue() etc should fail.

This change tells the cursor it's done when "null" finally comes through in
the IDBRequest, and the cursor then lets transaction know it can be
forgotten.

The added test doesn't distinguish the new behavior, but does exercise
"finished" cursors and apparently we didn't have tests for these before.

Test: storage/indexeddb/cursor-finished.html

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::close): Make idempotent; notify transaction.
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess): Tell cursor it's finished before releasing.
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::OpenCursorNotifier::~OpenCursorNotifier):
(WebCore):
(WebCore::IDBTransaction::OpenCursorNotifier::cursorFinished): New method for explicit notification.
* Modules/indexeddb/IDBTransaction.h:
(OpenCursorNotifier):

LayoutTests:

Test to exercise cursor methods after the cursor has been run to the end.

* storage/indexeddb/cursor-finished-expected.txt: Added.
* storage/indexeddb/cursor-finished.html: Added.
* storage/indexeddb/resources/cursor-finished.js: Added.
(test):
(prepareDatabase):
(onDeleteSuccess):
(onUpgradeNeeded):
(onOpenSuccess):
(onCursorSuccess):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h


Added Paths

trunk/LayoutTests/storage/indexeddb/cursor-finished-expected.txt
trunk/LayoutTests/storage/indexeddb/cursor-finished.html
trunk/LayoutTests/storage/indexeddb/resources/cursor-finished.js




Diff

Modified: trunk/LayoutTests/ChangeLog (129037 => 129038)

--- trunk/LayoutTests/ChangeLog	2012-09-19 20:28:35 UTC (rev 129037)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 20:35:19 UTC (rev 129038)
@@ -1,3 +1,22 @@
+2012-09-19  Joshua Bell  
+
+IndexedDB: Free up resources used by completed cursors earlier
+https://bugs.webkit.org/show_bug.cgi?id=97023
+
+Reviewed by Tony Chang.
+
+Test to exercise cursor methods after the cursor has been run to the end.
+
+* storage/indexeddb/cursor-finished-expected.txt: Added.
+* storage/indexeddb/cursor-finished.html: Added.
+* storage/indexeddb/resources/cursor-finished.js: Added.
+(test):
+(prepareDatabase):
+(onDeleteSuccess):
+(onUpgradeNeeded):
+(onOpenSuccess):
+(onCursorSuccess):
+
 2012-09-19  David Grogan  
 
 IndexedDB: fire upgradeneeded even without an explicit integer version


Added: trunk/LayoutTests/storage/indexeddb/cursor-finished-expected.txt (0 => 129038)

--- trunk/LayoutTests/storage/indexeddb/cursor-finished-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/cursor-finished-expected.txt	2012-09-19 20:35:19 UTC (rev 129038)
@@ -0,0 +1,72 @@
+Ensure cursor calls behave as expected after cursor has run to the end.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+dbname = "cursor-finished.html"
+
+prepareDatabase():
+indexedDB.deleteDatabase(dbname)
+
+onDeleteSuccess():
+indexedDB.open(dbname, 1)
+
+onUpgradeNeeded():
+db = event.target.result
+store = db.createObjectStore('store')
+store.put(1, 1)
+store.put(2, 2)
+
+onOpenSuccess():
+db = event.target.result
+transaction = db.transaction('store', 'readwrite')
+store = transaction.objectStore('store')
+count = 0
+cursorRequest = store.openCursor()
+
+onCursorSuccess():
+cursor = event.target.result
+PASS cursor is non-null.
+count++
+savedCursor = cursor
+cursor.continue()
+
+onCursorSuccess():
+cursor = event.target.result
+PASS cursor is non-null.
+count++
+savedCursor = cursor
+cursor.continue()
+
+onCursorSuccess():
+cursor = event.target.result
+PASS cursor is null
+PASS savedCursor is non-null.
+
+Expecting exception from savedCursor.update('value')
+PASS Exception was thrown.
+PASS code is DOMException.INVALID_STATE_ERR
+PASS ename is 'InvalidStateError'
+Expecting exception from savedCursor.advance(1)
+PASS Exception was thrown.
+PASS code is DOMException.INVALID_STATE_ERR
+PASS ename is 'InvalidStateError'
+Expecting exception from savedCursor.continue()

[webkit-changes] [129039] trunk/Source/WebKit/chromium

[hclam]

Title: [129039] trunk/Source/WebKit/chromium








Revision 129039
Author hc...@chromium.org
Date 2012-09-19 13:35:30 -0700 (Wed, 19 Sep 2012)


Log Message
[chromium] Unreviewed. Build fix.

Not building WebImageTest.cpp for component build.

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129038 => 129039)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 20:35:19 UTC (rev 129038)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 20:35:30 UTC (rev 129039)
@@ -1,5 +1,13 @@
 2012-09-19  Alpha Lam  
 
+[chromium] Unreviewed. Build fix.
+
+Not building WebImageTest.cpp for component build.
+
+* WebKit.gyp:
+
+2012-09-19  Alpha Lam  
+
 [chromium] WebImage should use ImageDecoder directly
 https://bugs.webkit.org/show_bug.cgi?id=96135
 


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (129038 => 129039)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-09-19 20:35:19 UTC (rev 129038)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-09-19 20:35:30 UTC (rev 129039)
@@ -720,6 +720,7 @@
 'tests/RenderTableRowTest.cpp',
 'tests/URLTestHelpers.cpp',
 'tests/WebFrameTest.cpp',
+'tests/WebImageTest.cpp',
 'tests/WebPageNewSerializerTest.cpp',
 'tests/WebPageSerializerTest.cpp',
 'tests/WebViewTest.cpp',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129040] trunk/Source/WebKit/blackberry

[mifenton]

Title: [129040] trunk/Source/WebKit/blackberry








Revision 129040
Author mifen...@rim.com
Date 2012-09-19 13:43:54 -0700 (Wed, 19 Sep 2012)


Log Message
[BlackBerry] Add SpellingLog for spell checking options request.
https://bugs.webkit.org/show_bug.cgi?id=97125

Reviewed by Rob Buis.

Add spell checking log to indicate the calculated
text position for spell checking option requests.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (129039 => 129040)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-19 20:35:30 UTC (rev 129039)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-19 20:43:54 UTC (rev 129040)
@@ -1,3 +1,18 @@
+2012-09-19  Mike Fenton  
+
+[BlackBerry] Add SpellingLog for spell checking options request.
+https://bugs.webkit.org/show_bug.cgi?id=97125
+
+Reviewed by Rob Buis.
+
+Add spell checking log to indicate the calculated
+text position for spell checking option requests.
+
+Reviewed Internally by Nima Ghanavatian.
+
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
+
 2012-09-19  Jonathan Dong  
 
 [BlackBerry] Add function playerId() in class PageClientBlackBerry


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (129039 => 129040)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-09-19 20:35:30 UTC (rev 129039)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-09-19 20:43:54 UTC (rev 129040)
@@ -696,6 +696,11 @@
 spellCheckingOptionRequest.startTextPosition = marker->startOffset();
 spellCheckingOptionRequest.endTextPosition = marker->endOffset();
 
+SpellingLog(LogLevelInfo, "InputHandler::shouldRequestSpellCheckingOptionsForPoint spellCheckingOptionRequest\ntop %d, %d\nbottom %d %d\nMarker start %d end %d"
+, spellCheckingOptionRequest.caret_rect.caret_top_x, spellCheckingOptionRequest.caret_rect.caret_top_y
+, spellCheckingOptionRequest.caret_rect.caret_bottom_x, spellCheckingOptionRequest.caret_rect.caret_bottom_y
+, spellCheckingOptionRequest.startTextPosition, spellCheckingOptionRequest.endTextPosition);
+
 return true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129041] trunk/Source/WebCore

[rwlbuis]

Title: [129041] trunk/Source/WebCore








Revision 129041
Author rwlb...@webkit.org
Date 2012-09-19 13:52:43 -0700 (Wed, 19 Sep 2012)


Log Message
[BlackBerry] Fix vertical positioning problem for 'X' in search field
https://bugs.webkit.org/show_bug.cgi?id=97126

Reviewed by Antonio Gomes.

We have the same problem as described in bug 30245, so integrate that code.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::convertToPaintingRect):
(WebCore):
(WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129040 => 129041)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 20:43:54 UTC (rev 129040)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 20:52:43 UTC (rev 129041)
@@ -146,6 +146,20 @@
 
 2012-09-19  Rob Buis  
 
+[BlackBerry] Fix vertical positioning problem for 'X' in search field
+https://bugs.webkit.org/show_bug.cgi?id=97126
+
+Reviewed by Antonio Gomes.
+
+We have the same problem as described in bug 30245, so integrate that code.
+
+* platform/blackberry/RenderThemeBlackBerry.cpp:
+(WebCore::RenderThemeBlackBerry::convertToPaintingRect):
+(WebCore):
+(WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
+
+2012-09-19  Rob Buis  
+
 [BlackBerry] Remove custom painting code for searchCancel
 https://bugs.webkit.org/show_bug.cgi?id=97119
 


Modified: trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp (129040 => 129041)

--- trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp	2012-09-19 20:43:54 UTC (rev 129040)
+++ trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp	2012-09-19 20:52:43 UTC (rev 129041)
@@ -332,28 +332,42 @@
 return paintTextFieldOrTextAreaOrSearchField(object, info, rect);
 }
 
-bool RenderThemeBlackBerry::paintSearchFieldCancelButton(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
+IntRect RenderThemeBlackBerry::convertToPaintingRect(RenderObject* inputRenderer, const RenderObject* partRenderer, LayoutRect partRect, const IntRect& localOffset) const
 {
-ASSERT(object->parent());
-if (!object->parent() || !object->parent()->isBox())
+// Compute an offset between the part renderer and the input renderer.
+LayoutSize offsetFromInputRenderer = -partRenderer->offsetFromAncestorContainer(inputRenderer);
+// Move the rect into partRenderer's coords.
+partRect.move(offsetFromInputRenderer);
+// Account for the local drawing offset.
+partRect.move(localOffset.x(), localOffset.y());
+
+return pixelSnappedIntRect(partRect);
+}
+
+
+bool RenderThemeBlackBerry::paintSearchFieldCancelButton(RenderObject* cancelButtonObject, const PaintInfo& paintInfo, const IntRect& r)
+{
+Node* input = cancelButtonObject->node()->shadowAncestorNode();
+if (!input->renderer()->isBox())
 return false;
 
-RenderBox* parentRenderBox = toRenderBox(object->parent());
+RenderBox* inputRenderBox = toRenderBox(input->renderer());
+LayoutRect inputContentBox = inputRenderBox->contentBoxRect();
 
-IntRect parentBox = parentRenderBox->absoluteContentBox();
-IntRect bounds = rect;
-// Make sure the scaled button stays square and fits in its parent's box.
-bounds.setHeight(std::min(parentBox.width(), std::min(parentBox.height(), bounds.height(;
-bounds.setWidth(bounds.height());
+// Make sure the scaled button stays square and will fit in its parent's box.
+LayoutUnit cancelButtonSize = std::min(inputContentBox.width(), std::min(inputContentBox.height(), r.height()));
+// Calculate cancel button's coordinates relative to the input element.
+// Center the button vertically. Round up though, so if it has to be one pixel off-center, it will
+// be one pixel closer to the bottom of the field. This tends to look better with the text.
+LayoutRect cancelButtonRect(cancelButtonObject->offsetFromAncestorContainer(inputRenderBox).width(),
+inputContentBox.y() + (inputContentBox.height() - cancelButtonSize + 1) / 2,
+cancelButtonSize, cancelButtonSize);
+IntRect paintingRect = convertToPaintingRect(inputRenderBox, cancelButtonObject, cancelButtonRect, r);
 
-// Put the button in the middle vertically, and round up the value.
-// So if it has to be one pixel off-center, it would be one pixel closer
-// to the bottom of the field. This would look better with the text.
-bounds.setY(parentBox.y() + (parentBox.height() - bounds.height() + 1) / 2);
-
 static Image* cancelImage = Image::loadPlatformResource("searchCancel").leakRef();
 static Image* cancelPressedImage = Image::loadPlatformResource("searchCancelPressed").leakRef();
-paintInfo.context->drawImage(isPressed(object

[webkit-changes] [129036] trunk

[dmazzoni]

Title: [129036] trunk








Revision 129036
Author dmazz...@google.com
Date 2012-09-19 12:55:19 -0700 (Wed, 19 Sep 2012)


Log Message
AX: A few control types are returning the wrong answer for isReadOnly
https://bugs.webkit.org/show_bug.cgi?id=96735

Reviewed by Chris Fleizach.

Source/WebCore:

All input types should be read-only except ones that
are text fields. The previous logic was marking things like
checkboxes as not read-only.

Tests: platform/chromium/accessibility/readonly.html
   platform/mac/accessibility/form-control-value-settable.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isReadOnly):

Tools:

Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.

* DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isReadOnlyGetterCallback):
* DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
(AccessibilityUIElement):

LayoutTests:

Adds a new test to make sure that readonly is exposed correctly on
all elements.

* platform/chromium/accessibility/readonly-expected.txt: Added.
* platform/chromium/accessibility/readonly.html: Added.
* platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
* platform/mac/accessibility/form-control-value-settable.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h


Added Paths

trunk/LayoutTests/platform/chromium/accessibility/readonly-expected.txt
trunk/LayoutTests/platform/chromium/accessibility/readonly.html
trunk/LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt
trunk/LayoutTests/platform/mac/accessibility/form-control-value-settable.html




Diff

Modified: trunk/LayoutTests/ChangeLog (129035 => 129036)

--- trunk/LayoutTests/ChangeLog	2012-09-19 19:49:45 UTC (rev 129035)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 19:55:19 UTC (rev 129036)
@@ -1,3 +1,18 @@
+2012-09-19  Dominic Mazzoni  
+
+AX: A few control types are returning the wrong answer for isReadOnly
+https://bugs.webkit.org/show_bug.cgi?id=96735
+
+Reviewed by Chris Fleizach.
+
+Adds a new test to make sure that readonly is exposed correctly on
+all elements.
+
+* platform/chromium/accessibility/readonly-expected.txt: Added.
+* platform/chromium/accessibility/readonly.html: Added.
+* platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
+* platform/mac/accessibility/form-control-value-settable.html: Added.
+
 2012-09-19  Nate Chapin  
 
 Chromium gardening.


Added: trunk/LayoutTests/platform/chromium/accessibility/readonly-expected.txt (0 => 129036)

--- trunk/LayoutTests/platform/chromium/accessibility/readonly-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/accessibility/readonly-expected.txt	2012-09-19 19:55:19 UTC (rev 129036)
@@ -0,0 +1,89 @@
+Link  Button 
+Focusable
+Heading
+
+ARIA button
+ARIA toggle button
+ARIA link
+Button
+This tests which elements expose themselves as readonly. Readonly here refers to whether the item is not editable, not whether a control value can be changed vs if it's unavailable.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+link1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+button1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+text1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is false
+
+checkbox1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+number1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is false
+
+radio1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+slider1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+submit1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+combobox1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+listbox1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+textarea1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is false
+
+focusable1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+heading1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+aria-button1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+aria-togglebutton1
+PASS document.activeElement == el

[webkit-changes] [129035] trunk/LayoutTests

[japhet]

Title: [129035] trunk/LayoutTests








Revision 129035
Author jap...@chromium.org
Date 2012-09-19 12:49:45 -0700 (Wed, 19 Sep 2012)


Log Message
2012-09-19  Nate Chapin  

Chromium gardening.

A test is mistakenly marked as both SLOW and TIMEOUT.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129034 => 129035)

--- trunk/LayoutTests/ChangeLog	2012-09-19 19:33:51 UTC (rev 129034)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 19:49:45 UTC (rev 129035)
@@ -1,3 +1,11 @@
+2012-09-19  Nate Chapin  
+
+Chromium gardening.
+
+A test is mistakenly marked as both SLOW and TIMEOUT.
+
+* platform/chromium/TestExpectations:
+
 2012-09-19  Brent Fulgham  
 
 [WinCairo] Unreviewed build correction to update Skipped list


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129034 => 129035)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 19:33:51 UTC (rev 129034)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 19:49:45 UTC (rev 129035)
@@ -3008,7 +3008,7 @@
 
 BUGWK84802 LINUX WIN DEBUG SLOW : fast/js/random-array-gc-stress.html = PASS
 BUGWK93631 ANDROID SLOW : fast/js/random-array-gc-stress.html = PASS
-BUGWK84802 MAC DEBUG SLOW : fast/js/random-array-gc-stress.html = PASS TIMEOUT
+BUGWK84802 MAC DEBUG : fast/js/random-array-gc-stress.html = PASS TIMEOUT
 
 BUGWK84847 WIN RELEASE : inspector/timeline/timeline-start-time.html = TEXT PASS
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129033] branches/chromium/1229

[leviw]

Title: [129033] branches/chromium/1229








Revision 129033
Author le...@chromium.org
Date 2012-09-19 12:19:51 -0700 (Wed, 19 Sep 2012)


Log Message
Merge 128346 - Inline repainting can be off-by-one with sub-pixel enabled
https://bugs.webkit.org/show_bug.cgi?id=95882

Reviewed by Eric Seidel.

Source/WebCore: 

With sub-pixel layout enabled, context accumulated from containing renderers is used to properly
pixel snap. Selection repaint rects are stored outside the affected renderers, and are handed to
the embedder without the context to correctly determine the snapped values. This can result in
repaint areas smaller than what's needed.

This could be fixed three ways:
- by changing selection repaint rects to an IntRect and pixel snapping the values before storing
  them outside the render tree. This is the narrowest solution.
- by adapting layout to store pixel snapping hints along with the size/location of the renderer.
  This is the best possible solution, as it would help solve a lot of pixel snapping issues and
  reduce complexity of handling. I eventually intend on implementing this.
- by reverting repaintUsingContainer to IntRects and using pixel snapping when possible, and
  enclosingIntRect where we lack context.

This implements the last solution, as it's the least invasive, but can potentially fix numerous
sub-pixel repaint issues.

Test: fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::repaintIncludingNonCompositingDescendants):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderObject.h:
(RenderObject):
* rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::repaint):
(WebCore::RenderBlockSelectionInfo::repaint):

LayoutTests: 

Test that we properly repaint selection gaps inside tables with sub-pixel offsets.

* fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
* fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html: Added.
* platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:


TBR=le...@chromium.org

Modified Paths

branches/chromium/1229/LayoutTests/platform/mac/Skipped
branches/chromium/1229/LayoutTests/platform/mac-lion/Skipped
branches/chromium/1229/LayoutTests/platform/mac-snowleopard/Skipped
branches/chromium/1229/LayoutTests/platform/mac-wk2/Skipped
branches/chromium/1229/LayoutTests/platform/qt/Skipped
branches/chromium/1229/LayoutTests/platform/qt-4.8/Skipped
branches/chromium/1229/LayoutTests/platform/win/Skipped
branches/chromium/1229/LayoutTests/platform/win-wk2/Skipped
branches/chromium/1229/LayoutTests/platform/win-xp/Skipped
branches/chromium/1229/LayoutTests/platform/wincairo/Skipped
branches/chromium/1229/LayoutTests/platform/wk2/Skipped
branches/chromium/1229/Source/WebCore/rendering/RenderBlockLineLayout.cpp
branches/chromium/1229/Source/WebCore/rendering/RenderLayer.cpp
branches/chromium/1229/Source/WebCore/rendering/RenderObject.cpp
branches/chromium/1229/Source/WebCore/rendering/RenderObject.h
branches/chromium/1229/Source/WebCore/rendering/RenderSelectionInfo.h


Added Paths

branches/chromium/1229/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt
branches/chromium/1229/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html
branches/chromium/1229/LayoutTests/platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png




Diff

Copied: branches/chromium/1229/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt (from rev 128346, trunk/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt) (0 => 129033)

--- branches/chromium/1229/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt	(rev 0)
+++ branches/chromium/1229/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt	2012-09-19 19:19:51 UTC (rev 129033)
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x8
+  RenderBlock {HTML} at (0,0) size 800x8
+RenderBody {BODY} at (8,8) size 784x0
+layer at (8,2) size 321x43
+  RenderTable {TABLE} at (8,1) size 321x44
+RenderTableSection {TBODY} at (0,0) s

[webkit-changes] [129032] trunk/Source/WebKit/chromium

[hclam]

Title: [129032] trunk/Source/WebKit/chromium








Revision 129032
Author hc...@chromium.org
Date 2012-09-19 12:17:47 -0700 (Wed, 19 Sep 2012)


Log Message
[chromium] WebImage should use ImageDecoder directly
https://bugs.webkit.org/show_bug.cgi?id=96135

Reviewed by Adam Barth.

This patch is for preparation of deferred image decoding.
ImageSource will be used as a portal to access deferred image decoder
by BitmapImage, it should not be accessible through WebKit APIs.

WebImage now calls ImageDecoder directly which is the actual
implementation of an image decoder.

Tests: WebImageTest.PNGImage
   WebImageTest.ICOImage
   WebImageTest.BadImage

* WebKit.gypi:
* src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
* tests/WebImageTest.cpp: Added.
(WebKit):
(WebKit::readFile):
(WebKit::TEST):
* tests/data/black-and-white.ico: Added.
* tests/data/white-1x1.png: Added.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
trunk/Source/WebKit/chromium/src/WebImageSkia.cpp


Added Paths

trunk/Source/WebKit/chromium/tests/WebImageTest.cpp
trunk/Source/WebKit/chromium/tests/data/black-and-white.ico
trunk/Source/WebKit/chromium/tests/data/white-1x1.png




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129031 => 129032)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 19:15:28 UTC (rev 129031)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 19:17:47 UTC (rev 129032)
@@ -1,3 +1,32 @@
+2012-09-19  Alpha Lam  
+
+[chromium] WebImage should use ImageDecoder directly
+https://bugs.webkit.org/show_bug.cgi?id=96135
+
+Reviewed by Adam Barth.
+
+This patch is for preparation of deferred image decoding.
+ImageSource will be used as a portal to access deferred image decoder
+by BitmapImage, it should not be accessible through WebKit APIs.
+
+WebImage now calls ImageDecoder directly which is the actual
+implementation of an image decoder.
+
+Tests: WebImageTest.PNGImage
+   WebImageTest.ICOImage
+   WebImageTest.BadImage
+
+* WebKit.gypi:
+* src/WebImageSkia.cpp:
+(WebKit::WebImage::fromData):
+(WebKit::WebImage::framesFromData):
+* tests/WebImageTest.cpp: Added.
+(WebKit):
+(WebKit::readFile):
+(WebKit::TEST):
+* tests/data/black-and-white.ico: Added.
+* tests/data/white-1x1.png: Added.
+
 2012-09-19  Oli Lan  
 
 [chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.


Modified: trunk/Source/WebKit/chromium/WebKit.gypi (129031 => 129032)

--- trunk/Source/WebKit/chromium/WebKit.gypi	2012-09-19 19:15:28 UTC (rev 129031)
+++ trunk/Source/WebKit/chromium/WebKit.gypi	2012-09-19 19:17:47 UTC (rev 129032)
@@ -103,6 +103,7 @@
 'tests/WebCompositorInputHandlerImplTest.cpp',
 'tests/WebFrameTest.cpp',
 'tests/WebInputEventConversionTest.cpp',
+'tests/WebImageTest.cpp',
 'tests/WebMediaPlayerClientImplTest.cpp',
 'tests/WebPageNewSerializerTest.cpp',
 'tests/WebPageSerializerTest.cpp',


Modified: trunk/Source/WebKit/chromium/src/WebImageSkia.cpp (129031 => 129032)

--- trunk/Source/WebKit/chromium/src/WebImageSkia.cpp	2012-09-19 19:15:28 UTC (rev 129031)
+++ trunk/Source/WebKit/chromium/src/WebImageSkia.cpp	2012-09-19 19:17:47 UTC (rev 129032)
@@ -31,7 +31,7 @@
 #include "config.h"
 
 #include "Image.h"
-#include "ImageSource.h"
+#include "ImageDecoder.h"
 #include "NativeImageSkia.h"
 #include "SharedBuffer.h"
 
@@ -51,19 +51,23 @@
 
 WebImage WebImage::fromData(const WebData& data, const WebSize& desiredSize)
 {
-ImageSource source;
-source.setData(PassRefPtr(data).get(), true);
-if (!source.isSizeAvailable())
+RefPtr buffer = PassRefPtr(data);
+OwnPtr decoder(adoptPtr(ImageDecoder::create(*buffer.get(), ImageSource::AlphaPremultiplied, ImageSource::GammaAndColorProfileApplied)));
+if (!decoder)
 return WebImage();
 
+decoder->setData(buffer.get(), true);
+if (!decoder->isSizeAvailable())
+return WebImage();
+
 // Frames are arranged by decreasing size, then decreasing bit depth.
 // Pick the frame closest to |desiredSize|'s area without being smaller,
 // which has the highest bit depth.
-const size_t frameCount = source.frameCount();
+const size_t frameCount = decoder->frameCount();
 size_t index = 0;  // Default to first frame if none are large enough.
 int frameAreaAtIndex = 0;
 for (size_t i = 0; i < frameCount; ++i) {
-const IntSize frameSize = source.frameSizeAtIndex(i);
+const IntSize frameSize = decoder->frameSizeAtIndex(i);
 if (WebSize(frameSize) == desiredSize) {
 index = i;
 break;  // Perfect match.
@@ -79,11 +83,15 @@
 }
 }
 
-OwnPtr frame = adoptPtr

[webkit-changes] [129031] trunk/LayoutTests

[japhet]

Title: [129031] trunk/LayoutTests








Revision 129031
Author jap...@chromium.org
Date 2012-09-19 12:15:28 -0700 (Wed, 19 Sep 2012)


Log Message
2012-09-19  Nate Chapin  

Chromium gardening.
Mark a consistently passing test as such, tweak flakiness
of several tests based on recent build results.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129030 => 129031)

--- trunk/LayoutTests/ChangeLog	2012-09-19 19:12:49 UTC (rev 129030)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 19:15:28 UTC (rev 129031)
@@ -1,5 +1,13 @@
 2012-09-19  Nate Chapin  
 
+Chromium gardening.
+Mark a consistently passing test as such, tweak flakiness
+of several tests based on recent build results.
+
+* platform/chromium/TestExpectations:
+
+2012-09-19  Nate Chapin  
+
 Chromium gardening, remove flaky tests that don't appear to
 actually be flaky.
 https://bugs.webkit.org/show_bug.cgi?id=78725


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129030 => 129031)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 19:12:49 UTC (rev 129030)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 19:15:28 UTC (rev 129031)
@@ -2044,7 +2044,7 @@
 BUGCR65877 ANDROID : fast/writing-mode/border-vertical-lr.html = IMAGE+TEXT
 BUGCR65877 : fast/writing-mode/japanese-ruby-vertical-lr.html = PASS IMAGE+TEXT
 BUGCR65877 : fast/writing-mode/japanese-ruby-vertical-rl.html = PASS IMAGE+TEXT
-BUGCR65877 LINUX ANDROID : fast/writing-mode/japanese-ruby-horizontal-bt.html = PASS IMAGE+TEXT
+BUGCR65877 LINUX ANDROID WIN : fast/writing-mode/japanese-ruby-horizontal-bt.html = PASS IMAGE+TEXT
 BUGCR65877 LINUX : fast/writing-mode/broken-ideographic-font.html = IMAGE+TEXT
 BUGCR65877 ANDROID : fast/writing-mode/vertical-font-fallback.html = IMAGE+TEXT
 //BUGCR65877 LINUX ANDROID WIN : fast/writing-mode/broken-ideograph-small-caps.html = IMAGE
@@ -2605,8 +2605,8 @@
 BUGWK72039 LINUX ANDROID RELEASE : fast/forms/formaction-attribute.html = MISSING PASS
 BUGWK78620 LINUX ANDROID DEBUG SLOW : fast/forms/formaction-attribute.html = PASS TEXT
 
-BUGWK70988 SNOWLEOPARD DEBUG : fast/forms/submit-to-blank-multiple-times.html = PASS TEXT
-BUGWK70988 SNOWLEOPARD DEBUG : fast/overflow/003.xml = PASS TEXT
+BUGWK70988 MAC WIN DEBUG : fast/forms/submit-to-blank-multiple-times.html = PASS TEXT
+BUGWK70988 MAC DEBUG : fast/overflow/003.xml = PASS TEXT
 
 BUGWK70988 MAC : jquery/traversing.html = PASS TIMEOUT
 
@@ -2769,7 +2769,7 @@
 
 BUGWK81537 : fast/events/touch/gesture/pad-gesture-fling.html = TEXT PASS
 
-BUGWK81638 SNOWLEOPARD DEBUG : editing/selection/iframe.html = IMAGE PASS
+BUGWK81638 MAC DEBUG : editing/selection/iframe.html = IMAGE PASS
 
 BUGWK81276 WIN LINUX ANDROID : fast/inline/continuation-outlines-with-layers.html = IMAGE
 
@@ -2794,7 +2794,7 @@
 BUGWK81803 MAC : platform/chromium/compositing/rubberbanding/transform-overhang-sw.html = PASS IMAGE
 BUGWK81803 MAC : platform/chromium/compositing/rubberbanding/transform-overhang-w.html = PASS IMAGE
 
-BUGWK81931 SNOWLEOPARD WIN DEBUG : fast/images/destroyed-image-load-event.html = PASS TIMEOUT
+BUGWK81931 MAC WIN DEBUG : fast/images/destroyed-image-load-event.html = PASS TIMEOUT
 
 
 // The majority of these are only failing on the debug bots
@@ -3006,10 +3006,9 @@
 
 BUGWK84735 WIN : http/tests/inspector/change-iframe-src.html = TIMEOUT PASS
 
-// This test has its own idea of "timeout", which is to crash.
 BUGWK84802 LINUX WIN DEBUG SLOW : fast/js/random-array-gc-stress.html = PASS
 BUGWK93631 ANDROID SLOW : fast/js/random-array-gc-stress.html = PASS
-BUGWK84802 MAC DEBUG SLOW : fast/js/random-array-gc-stress.html = PASS CRASH
+BUGWK84802 MAC DEBUG SLOW : fast/js/random-array-gc-stress.html = PASS TIMEOUT
 
 BUGWK84847 WIN RELEASE : inspector/timeline/timeline-start-time.html = TEXT PASS
 
@@ -3320,7 +3319,6 @@
 BUGWK94002 WIN7 : inspector/debugger = PASS TIMEOUT
 
 // Added by bug 89826
-BUGWK94008 WIN : fast/css/word-spacing-characters.html = IMAGE
 BUGWK94003 WIN : fast/css/word-spacing-characters-complex-text.html = IMAGE
 
 BUGWK94010 DEBUG : fast/regex/unicodeCaseInsensitive.html = PASS CRASH
@@ -3472,8 +3470,7 @@
 
 BUGWK95588 MAC : fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html = IMAGE
 
-BUGWK95070 LINUX DEBUG : inspector/styles/media-queries.html = TEXT
-BUGWK95070 WIN LINUX RELEASE : inspector/styles/media-queries.html = PASS TEXT
+BUGWK95070 WIN RELEASE : inspector/styles/media-queries.html = PASS TEXT
 
 BUGWK95101 SNOWLEOPARD : fast/text/atsui-bidi-control.html = PASS TIMEOUT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129030] trunk/Source/WebCore

[pilgrim]

Title: [129030] trunk/Source/WebCore








Revision 129030
Author pilg...@chromium.org
Date 2012-09-19 12:12:49 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Remove unused PlatformSupport reference in V8GCController
https://bugs.webkit.org/show_bug.cgi?id=97118

Reviewed by Ryosuke Niwa.

Part of a refactoring series. See tracking bug 82948.

* bindings/v8/V8GCController.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8GCController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129029 => 129030)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 19:07:39 UTC (rev 129029)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 19:12:49 UTC (rev 129030)
@@ -1,5 +1,16 @@
 2012-09-19  Mark Pilgrim  
 
+[Chromium] Remove unused PlatformSupport reference in V8GCController
+https://bugs.webkit.org/show_bug.cgi?id=97118
+
+Reviewed by Ryosuke Niwa.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* bindings/v8/V8GCController.cpp:
+
+2012-09-19  Mark Pilgrim  
+
 [Chromium] Remove unused PlatformSupport reference in V8DOMWindowShell
 https://bugs.webkit.org/show_bug.cgi?id=97117
 


Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (129029 => 129030)

--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp	2012-09-19 19:07:39 UTC (rev 129029)
+++ trunk/Source/WebCore/bindings/v8/V8GCController.cpp	2012-09-19 19:12:49 UTC (rev 129030)
@@ -39,7 +39,6 @@
 #include "HTMLNames.h"
 #include "MemoryUsageSupport.h"
 #include "MessagePort.h"
-#include "PlatformSupport.h"
 #include "RetainedDOMInfo.h"
 #include "RetainedObjectInfo.h"
 #include "V8AbstractEventListener.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129029] trunk/Source/WebKit/chromium

[commit-queue]

Title: [129029] trunk/Source/WebKit/chromium








Revision 129029
Author commit-qu...@webkit.org
Date 2012-09-19 12:07:39 -0700 (Wed, 19 Sep 2012)


Log Message
[chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
https://bugs.webkit.org/show_bug.cgi?id=96112

Patch by Oli Lan  on 2012-09-19
Reviewed by Adam Barth.

Adds a new method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.

This will be used by the Android port to implement platform-specific gesture behaviour.

This is tested by the new test WebViewTest.ClientTapHandlers.

* public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::didHandleGestureEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
* tests/WebViewTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebViewClient.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/WebViewTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129028 => 129029)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 19:03:06 UTC (rev 129028)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 19:07:39 UTC (rev 129029)
@@ -1,3 +1,23 @@
+2012-09-19  Oli Lan  
+
+[chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
+https://bugs.webkit.org/show_bug.cgi?id=96112
+
+Reviewed by Adam Barth.
+
+Adds a new method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
+
+This will be used by the Android port to implement platform-specific gesture behaviour.
+
+This is tested by the new test WebViewTest.ClientTapHandlers.
+
+* public/WebViewClient.h:
+(WebViewClient):
+(WebKit::WebViewClient::didHandleGestureEvent):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::handleGestureEvent):
+* tests/WebViewTest.cpp:
+
 2012-09-19  Robert Flack  
 
 [chromium] Support high DPI scroll bar on top level web frame.


Modified: trunk/Source/WebKit/chromium/public/WebViewClient.h (129028 => 129029)

--- trunk/Source/WebKit/chromium/public/WebViewClient.h	2012-09-19 19:03:06 UTC (rev 129028)
+++ trunk/Source/WebKit/chromium/public/WebViewClient.h	2012-09-19 19:07:39 UTC (rev 129029)
@@ -142,6 +142,9 @@
 // Called to retrieve the provider of desktop notifications.
 virtual WebNotificationPresenter* notificationPresenter() { return 0; }
 
+// Called when a gesture event is handled.
+virtual void didHandleGestureEvent(const WebGestureEvent& event, bool eventSwallowed) { }
+
 // Called to request an icon for the specified filenames.
 // The icon is shown in a file upload control.
 virtual bool queryIconForFiles(const WebVector& filenames, WebIconLoadingCompletion*) { return false; }


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (129028 => 129029)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-09-19 19:03:06 UTC (rev 129028)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-09-19 19:07:39 UTC (rev 129029)
@@ -682,6 +682,7 @@
 #if ENABLE(GESTURE_EVENTS)
 bool WebViewImpl::handleGestureEvent(const WebGestureEvent& event)
 {
+bool eventSwallowed = false;
 switch (event.type) {
 case WebInputEvent::GestureFlingStart: {
 m_client->cancelScheduledContentIntents();
@@ -692,18 +693,21 @@
 OwnPtr flingCurve = PlatformGestureCurveFactory::get()->createCurve(event.data.flingStart.sourceDevice, FloatPoint(event.data.flingStart.velocityX, event.data.flingStart.velocityY));
 m_gestureAnimation = ActivePlatformGestureAnimation::create(flingCurve.release(), this);
 scheduleAnimation();
-return true;
+eventSwallowed = true;
+break;
 }
 case WebInputEvent::GestureFlingCancel:
 if (m_gestureAnimation) {
 m_gestureAnimation.clear();
-return true;
+eventSwallowed = true;
 }
-return false;
+break;
 case WebInputEvent::GestureTap: {
 m_client->cancelScheduledContentIntents();
-if (detectContentOnTouch(WebPoint(event.x, event.y), event.type))
-return true;
+if (detectContentOnTouch(WebPoint(event.x, event.y), event.type)) {
+eventSwallowed = true;
+break;
+}
 
 RefPtr selectPopup;
 selectPopup = m_selectPopup;
@@ -716,12 +720,14 @@
 findGoodTouchTargets(boundingBox, mainFrameImpl()->frame(), pageScaleFactor(), goodTargets);
 // FIXME: replace touch adjustment code when numberOfGoodTargets == 1?
 // Single candidate case is currently handled by: https://bugs.webkit.org/show_bug.cgi?id=85101
-if (goodTargets.size() >= 2 && m_client && m_client->didTapMultipleTargets(event, goodTargets))
-return true;

[webkit-changes] [129027] trunk/Source/WebCore

[pilgrim]

Title: [129027] trunk/Source/WebCore








Revision 129027
Author pilg...@chromium.org
Date 2012-09-19 11:56:31 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Remove unused PlatformSupport reference in V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=97117

Reviewed by Ryosuke Niwa.

Part of a refactoring series. See tracking bug 82948.

* bindings/v8/V8DOMWindowShell.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129026 => 129027)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 18:52:18 UTC (rev 129026)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 18:56:31 UTC (rev 129027)
@@ -1,3 +1,14 @@
+2012-09-19  Mark Pilgrim  
+
+[Chromium] Remove unused PlatformSupport reference in V8DOMWindowShell
+https://bugs.webkit.org/show_bug.cgi?id=97117
+
+Reviewed by Ryosuke Niwa.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* bindings/v8/V8DOMWindowShell.cpp:
+
 2012-09-19  Kentaro Hara  
 
 [V8] Remove WorkerContextExecutionProxy::runScript()


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (129026 => 129027)

--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2012-09-19 18:52:18 UTC (rev 129026)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2012-09-19 18:56:31 UTC (rev 129027)
@@ -41,7 +41,6 @@
 #include "MemoryUsageSupport.h"
 #include "Page.h"
 #include "PageGroup.h"
-#include "PlatformSupport.h"
 #include "RuntimeEnabledFeatures.h"
 #include "ScriptCallStack.h"
 #include "ScriptCallStackFactory.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129026] trunk/Source/WebCore

[haraken]

Title: [129026] trunk/Source/WebCore








Revision 129026
Author hara...@chromium.org
Date 2012-09-19 11:52:18 -0700 (Wed, 19 Sep 2012)


Log Message
[V8] Remove WorkerContextExecutionProxy::runScript()
https://bugs.webkit.org/show_bug.cgi?id=97060

Reviewed by Adam Barth.

To kill WorkerContextExecutionProxy, this patch removes
WorkerContextExecutionProxy::runScript() by replacing it
with ScriptRunner::runCompiledScript().

For the replacement, this patch moves TryCatch logic in
runCompiledScript() to the caller side. The reason why
we have to avoid nesting TryCatches is a V8 bug:
http://code.google.com/p/v8/issues/detail?id=2166

No tests. No change in behavior.

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
* bindings/v8/ScriptRunner.cpp:
(WebCore::ScriptRunner::runCompiledScript):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
* bindings/v8/WorkerContextExecutionProxy.h:
(WorkerContextExecutionProxy):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
trunk/Source/WebCore/bindings/v8/ScriptRunner.cpp
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (129025 => 129026)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 18:04:16 UTC (rev 129025)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 18:52:18 UTC (rev 129026)
@@ -1,3 +1,30 @@
+2012-09-19  Kentaro Hara  
+
+[V8] Remove WorkerContextExecutionProxy::runScript()
+https://bugs.webkit.org/show_bug.cgi?id=97060
+
+Reviewed by Adam Barth.
+
+To kill WorkerContextExecutionProxy, this patch removes
+WorkerContextExecutionProxy::runScript() by replacing it
+with ScriptRunner::runCompiledScript().
+
+For the replacement, this patch moves TryCatch logic in
+runCompiledScript() to the caller side. The reason why
+we have to avoid nesting TryCatches is a V8 bug:
+http://code.google.com/p/v8/issues/detail?id=2166
+
+No tests. No change in behavior.
+
+* bindings/v8/ScriptController.cpp:
+(WebCore::ScriptController::compileAndRunScript):
+* bindings/v8/ScriptRunner.cpp:
+(WebCore::ScriptRunner::runCompiledScript):
+* bindings/v8/WorkerContextExecutionProxy.cpp:
+(WebCore::WorkerContextExecutionProxy::evaluate):
+* bindings/v8/WorkerContextExecutionProxy.h:
+(WorkerContextExecutionProxy):
+
 2012-09-19  Rob Buis  
 
 [BlackBerry] Remove custom painting code for searchCancel


Modified: trunk/Source/WebCore/bindings/v8/ScriptController.cpp (129025 => 129026)

--- trunk/Source/WebCore/bindings/v8/ScriptController.cpp	2012-09-19 18:04:16 UTC (rev 129025)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.cpp	2012-09-19 18:52:18 UTC (rev 129026)
@@ -281,6 +281,7 @@
 // Keep Frame (and therefore ScriptController) alive.
 RefPtr protect(m_frame);
 result = ScriptRunner::runCompiledScript(script, m_frame->document());
+ASSERT(!tryCatch.HasCaught() || result.IsEmpty());
 }
 
 InspectorInstrumentation::didEvaluateScript(cookie);


Modified: trunk/Source/WebCore/bindings/v8/ScriptRunner.cpp (129025 => 129026)

--- trunk/Source/WebCore/bindings/v8/ScriptRunner.cpp	2012-09-19 18:04:16 UTC (rev 129025)
+++ trunk/Source/WebCore/bindings/v8/ScriptRunner.cpp	2012-09-19 18:52:18 UTC (rev 129026)
@@ -47,8 +47,6 @@
 
 // Run the script and keep track of the current recursion depth.
 v8::Local result;
-v8::TryCatch tryCatch;
-tryCatch.SetVerbose(true);
 {
 V8RecursionScope recursionScope(context);
 result = script->Run();
@@ -57,12 +55,6 @@
 if (handleOutOfMemory())
 ASSERT(result.IsEmpty());
 
-// Handle V8 internal error situation.
-if (tryCatch.HasCaught()) {
-ASSERT(result.IsEmpty());
-return v8::Local();
-}
-
 if (result.IsEmpty())
 return v8::Local();
 


Modified: trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp (129025 => 129026)

--- trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp	2012-09-19 18:04:16 UTC (rev 129025)
+++ trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp	2012-09-19 18:52:18 UTC (rev 129026)
@@ -38,6 +38,7 @@
 #include "DedicatedWorkerContext.h"
 #include "Event.h"
 #include "ScriptCallStack.h"
+#include "ScriptRunner.h"
 #include "ScriptSourceCode.h"
 #include "SharedWorker.h"
 #include "SharedWorkerContext.h"
@@ -223,7 +224,7 @@
 
 v8::Local scriptString = v8ExternalString(script);
 v8::Handle compiledScript = ScriptSourceCode::compileScript(scriptString, fileName, scriptStartPosition);
-v8::Local result = runScript(compiledScript);
+v8::Local result = ScriptRunner::runCompiledScript(compiledScript, m_workerContext);
 
 if (!exceptionCatcher.C

[webkit-changes] [129025] trunk/LayoutTests

[japhet]

Title: [129025] trunk/LayoutTests








Revision 129025
Author jap...@chromium.org
Date 2012-09-19 11:04:16 -0700 (Wed, 19 Sep 2012)


Log Message
2012-09-19  Nate Chapin  

Chromium gardening, remove flaky tests that don't appear to
actually be flaky.
https://bugs.webkit.org/show_bug.cgi?id=78725

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129024 => 129025)

--- trunk/LayoutTests/ChangeLog	2012-09-19 18:03:48 UTC (rev 129024)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 18:04:16 UTC (rev 129025)
@@ -1,3 +1,11 @@
+2012-09-19  Nate Chapin  
+
+Chromium gardening, remove flaky tests that don't appear to
+actually be flaky.
+https://bugs.webkit.org/show_bug.cgi?id=78725
+
+* platform/chromium/TestExpectations:
+
 2012-09-19  Christophe Dumez  
 
 [EFL][WK2] fast/forms/select-writing-direction-natural.html is failing


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129024 => 129025)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 18:03:48 UTC (rev 129024)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 18:04:16 UTC (rev 129025)
@@ -2657,9 +2657,6 @@
 BUGWK74746 WIN : http/tests/xmlhttprequest/workers/methods.html = TEXT TIMEOUT
 BUGWK74746 WIN : http/tests/xmlhttprequest/workers/methods-async.html = TEXT
 
-BUGWK78725 : http/tests/filesystem/workers/resolve-url-sync.html = PASS TIMEOUT
-BUGWK78725 : http/tests/filesystem/workers/resolve-url.html = PASS TIMEOUT
-
 BUGWK75111 : fast/workers/storage/use-same-database-in-page-and-workers.html = PASS TEXT TIMEOUT
 
 // Crashes due to an OOM error on V8.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129024] trunk/Source/WebCore

[rwlbuis]

Title: [129024] trunk/Source/WebCore








Revision 129024
Author rwlb...@webkit.org
Date 2012-09-19 11:03:48 -0700 (Wed, 19 Sep 2012)


Log Message
[BlackBerry] Remove custom painting code for searchCancel
https://bugs.webkit.org/show_bug.cgi?id=97119

Reviewed by Antonio Gomes.

Remove the dynamic painting code for searchCancel, we use a png file now.

* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::Image::loadPlatformResource):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129023 => 129024)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 17:58:04 UTC (rev 129023)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 18:03:48 UTC (rev 129024)
@@ -1,3 +1,15 @@
+2012-09-19  Rob Buis  
+
+[BlackBerry] Remove custom painting code for searchCancel
+https://bugs.webkit.org/show_bug.cgi?id=97119
+
+Reviewed by Antonio Gomes.
+
+Remove the dynamic painting code for searchCancel, we use a png file now.
+
+* platform/graphics/blackberry/ImageBlackBerry.cpp:
+(WebCore::Image::loadPlatformResource):
+
 2012-09-19  Mark Pilgrim  
 
 [Chromium] Move notifyJSOutOfMemory out of PlatformSupport


Modified: trunk/Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp (129023 => 129024)

--- trunk/Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp	2012-09-19 17:58:04 UTC (rev 129023)
+++ trunk/Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp	2012-09-19 18:03:48 UTC (rev 129024)
@@ -27,40 +27,11 @@
 
 PassRefPtr Image::loadPlatformResource(const char *name)
 {
-if (!strcmp(name, "searchCancel") || !strcmp(name, "searchCancelPressed")) {
-OwnPtr imageBuffer = ImageBuffer::create(IntSize(16, 16));
-if (!imageBuffer)
-return 0;
-
-// Draw a more subtle, gray x-shaped icon.
-GraphicsContext* context = imageBuffer->context();
-context->save();
-
-context->fillRect(FloatRect(0, 0, 16, 16), Color::white, ColorSpaceDeviceRGB);
-
-if (!strcmp(name, "searchCancel"))
-context->setFillColor(Color(128, 128, 128), ColorSpaceDeviceRGB);
-else
-context->setFillColor(Color(64, 64, 64), ColorSpaceDeviceRGB);
-
-context->translate(8, 8);
-
-context->rotate(piDouble / 4.0);
-context->fillRect(FloatRect(-1, -7, 2, 14));
-
-context->rotate(-piDouble / 2.0);
-context->fillRect(FloatRect(-1, -7, 2, 14));
-
-context->restore();
-return imageBuffer->copyImage();
-}
-
 // RESOURCE_PATH is set by CMake in OptionsBlackBerry.cmake
 String fullPath(RESOURCE_PATH);
 String extension(".png");
 
-fullPath += name;
-fullPath += extension;
+fullPath = fullPath + name + extension;
 
 RefPtr buffer = SharedBuffer::createWithContentsOfFile(fullPath);
 if (!buffer)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129023] trunk/Source/WebKit/chromium

[commit-queue]

Title: [129023] trunk/Source/WebKit/chromium








Revision 129023
Author commit-qu...@webkit.org
Date 2012-09-19 10:58:04 -0700 (Wed, 19 Sep 2012)


Log Message
[chromium] Support high DPI scroll bar on top level web frame.
https://bugs.webkit.org/show_bug.cgi?id=95134

Patch by Robert Flack  on 2012-09-19
Reviewed by Adrienne Walker.

Calls setAppliesPageScale(true) on root scrollbar layers as these are not scaled.

* src/NonCompositedContentHost.cpp:
(WebKit::setScrollbarBoundsContainPageScale):
(WebKit):
(WebKit::NonCompositedContentHost::setViewport):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129022 => 129023)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 17:57:29 UTC (rev 129022)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 17:58:04 UTC (rev 129023)
@@ -1,3 +1,17 @@
+2012-09-19  Robert Flack  
+
+[chromium] Support high DPI scroll bar on top level web frame.
+https://bugs.webkit.org/show_bug.cgi?id=95134
+
+Reviewed by Adrienne Walker.
+
+Calls setAppliesPageScale(true) on root scrollbar layers as these are not scaled.
+
+* src/NonCompositedContentHost.cpp:
+(WebKit::setScrollbarBoundsContainPageScale):
+(WebKit):
+(WebKit::NonCompositedContentHost::setViewport):
+
 2012-09-19  Mark Pilgrim  
 
 [Chromium] Move notifyJSOutOfMemory out of PlatformSupport


Modified: trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp (129022 => 129023)

--- trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp	2012-09-19 17:57:29 UTC (rev 129022)
+++ trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp	2012-09-19 17:58:04 UTC (rev 129023)
@@ -88,6 +88,20 @@
 ASSERT(haveScrollLayer());
 }
 
+static void setScrollbarBoundsContainPageScale(WebCore::GraphicsLayer* layer, WebCore::GraphicsLayer* clipLayer)
+{
+// Scrollbars are attached outside the root clip rect, so skip the
+// clipLayer subtree.
+if (layer == clipLayer)
+return;
+
+for (size_t i = 0; i < layer->children().size(); ++i)
+setScrollbarBoundsContainPageScale(layer->children()[i], clipLayer);
+
+if (layer->children().isEmpty())
+layer->setAppliesPageScale(true);
+}
+
 void NonCompositedContentHost::setViewport(const WebCore::IntSize& viewportSize, const WebCore::IntSize& contentsSize, const WebCore::IntPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin)
 {
 if (!haveScrollLayer())
@@ -119,6 +133,12 @@
 m_graphicsLayer->setNeedsDisplay();
 } else if (visibleRectChanged)
 m_graphicsLayer->setNeedsDisplay();
+
+WebCore::GraphicsLayer* clipLayer = m_graphicsLayer->parent()->parent();
+WebCore::GraphicsLayer* rootLayer = clipLayer;
+while (rootLayer->parent())
+rootLayer = rootLayer->parent();
+setScrollbarBoundsContainPageScale(rootLayer, clipLayer);
 }
 
 bool NonCompositedContentHost::haveScrollLayer()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129022] trunk

[commit-queue]

Title: [129022] trunk








Revision 129022
Author commit-qu...@webkit.org
Date 2012-09-19 10:57:29 -0700 (Wed, 19 Sep 2012)


Log Message
[WTR] Memory leaks in TestRunner::deliverWebIntent()
https://bugs.webkit.org/show_bug.cgi?id=97111

Patch by Sudarsana Nagineni  on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Fix memory leaks in WKBundleIntentCreate() by adopting strings
created with WKStringCreateWithUTF8CString().

* WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp:
(WKBundleIntentCreate):

Tools:

Fix memory leaks in deliverWebIntent() by adopting strings
created with WKStringCreateWithUTF8CString().

* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::deliverWebIntent):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (129021 => 129022)

--- trunk/Source/WebKit2/ChangeLog	2012-09-19 17:56:34 UTC (rev 129021)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-19 17:57:29 UTC (rev 129022)
@@ -1,3 +1,16 @@
+2012-09-19  Sudarsana Nagineni  
+
+[WTR] Memory leaks in TestRunner::deliverWebIntent()
+https://bugs.webkit.org/show_bug.cgi?id=97111
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Fix memory leaks in WKBundleIntentCreate() by adopting strings
+created with WKStringCreateWithUTF8CString().
+
+* WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp:
+(WKBundleIntentCreate):
+
 2012-09-19  Christophe Dumez  
 
 [EFL][WK2] fast/forms/select-writing-direction-natural.html is failing


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp (129021 => 129022)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp	2012-09-19 17:56:34 UTC (rev 129021)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp	2012-09-19 17:57:29 UTC (rev 129022)
@@ -33,6 +33,7 @@
 #include "WKAPICast.h"
 #include "WKBundleAPICast.h"
 #include "WKDictionary.h"
+#include "WKRetainPtr.h"
 #include "WKString.h"
 #include "WebSerializedScriptValue.h"
 
@@ -52,11 +53,14 @@
 WKBundleIntentRef WKBundleIntentCreate(WKDictionaryRef dictionaryRef)
 {
 #if ENABLE(WEB_INTENTS)
-WKStringRef action = "" WKStringCreateWithUTF8CString("action")));
+WKRetainPtr actionKey(AdoptWK, WKStringCreateWithUTF8CString("action"));
+WKStringRef action = "" actionKey.get()));
 ASSERT(action);
-WKStringRef type = static_cast(WKDictionaryGetItemForKey(dictionaryRef, WKStringCreateWithUTF8CString("type")));
+WKRetainPtr typeKey(AdoptWK, WKStringCreateWithUTF8CString("type"));
+WKStringRef type = static_cast(WKDictionaryGetItemForKey(dictionaryRef, typeKey.get()));
 ASSERT(type);
-WKSerializedScriptValueRef data = "" WKStringCreateWithUTF8CString("data")));
+WKRetainPtr dataKey(AdoptWK, WKStringCreateWithUTF8CString("data"));
+WKSerializedScriptValueRef data = "" dataKey.get()));
 MessagePortArray dummyPorts;
 ExceptionCode ec;
 


Modified: trunk/Tools/ChangeLog (129021 => 129022)

--- trunk/Tools/ChangeLog	2012-09-19 17:56:34 UTC (rev 129021)
+++ trunk/Tools/ChangeLog	2012-09-19 17:57:29 UTC (rev 129022)
@@ -1,3 +1,16 @@
+2012-09-19  Sudarsana Nagineni  
+
+[WTR] Memory leaks in TestRunner::deliverWebIntent()
+https://bugs.webkit.org/show_bug.cgi?id=97111
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Fix memory leaks in deliverWebIntent() by adopting strings
+created with WKStringCreateWithUTF8CString().
+
+* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+(WTR::TestRunner::deliverWebIntent):
+
 2012-09-19  Simon Hausmann  
 
 [Qt] Fix incremental builds with all-in-one-files and gccdepends


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (129021 => 129022)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp	2012-09-19 17:56:34 UTC (rev 129021)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp	2012-09-19 17:57:29 UTC (rev 129022)
@@ -691,10 +691,15 @@
 WKRetainPtr dataWK(AdoptWK, WKSerializedScriptValueCreate(context, JSValueMakeString(context, data), 0));
 
 WKRetainPtr intentInitDict(AdoptWK, WKMutableDictionaryCreate());
-WKDictionaryAddItem(intentInitDict.get(), WKStringCreateWithUTF8CString("action"), actionWK.get());
-WKDictionaryAddItem(intentInitDict.get(), WKStringCreateWithUTF8CString("type"), typeWK.get());
-WKDictionaryAddItem(intentInitDict.get(), WKStringCreateWithUTF8CString("data"), dataWK.get());
+WKRetainPtr actionKey(AdoptWK, WKStringCreateWithUTF8CString("action"));
+WKDictionaryAddItem(intentInitDict.get(), actionKey.get(), actionWK.get());
 
+WKRetainPtr typeKey(AdoptWK, WKStringCreateWithUTF8CString("type"));
+WKDictionaryAddItem(intentInitDict.get(), typeKey.get(), typeWK.g

[webkit-changes] [129021] trunk/LayoutTests

[japhet]

Title: [129021] trunk/LayoutTests








Revision 129021
Author jap...@chromium.org
Date 2012-09-19 10:56:34 -0700 (Wed, 19 Sep 2012)


Log Message
2012-09-19  Nate Chapin  

Chromium gardening.
fast/filesystem/workers/detached-frame-crash.html does not appear to be
flakily crashing anymore.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129020 => 129021)

--- trunk/LayoutTests/ChangeLog	2012-09-19 17:53:48 UTC (rev 129020)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 17:56:34 UTC (rev 129021)
@@ -31,6 +31,14 @@
 
 2012-09-19  Nate Chapin  
 
+Chromium gardening.
+fast/filesystem/workers/detached-frame-crash.html does not appear to be
+flakily crashing anymore.
+
+* platform/chromium/TestExpectations:
+
+2012-09-19  Nate Chapin  
+
 chromium TestExpectations update.
 fast/filesystem/file-writer-write-overlapped.html and
 fast/filesystem/workers/file-writer-write-overlapped.html


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129020 => 129021)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 17:53:48 UTC (rev 129020)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 17:56:34 UTC (rev 129021)
@@ -3510,8 +3510,6 @@
 
 BUGWK96227 SKIP : fast/js/function-dot-arguments-identity.html = TEXT
 
-BUGWK96524 WIN LINUX DEBUG : fast/filesystem/workers/detached-frame-crash.html = PASS CRASH
-
 BUGWK96835 : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = TEXT PASS
 BUGWK96835 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage.html = TEXT PASS
 BUGWK96836 ANDROID LINUX WIN : inspector/debugger/xhr-breakpoints.html = TEXT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129018] trunk

[krit]

Title: [129018] trunk








Revision 129018
Author k...@webkit.org
Date 2012-09-19 10:50:26 -0700 (Wed, 19 Sep 2012)


Log Message
Implement 'mask-type' for 
https://bugs.webkit.org/show_bug.cgi?id=97011

Reviewed by Andreas Kling.

Source/WebCore:

The CSS Masking specification defines the presentation attribute 'mask-type' to
switch between luminance and alpha masking. 'mask-type' just affects the SVG
mask element. The luminance masking is the current behavior of of SVG masking.
Alpha masking is simular to '-webkit-mask-image'.

This patch implements this property and make it possible to switch between both
masking modes. Since the default value is 'luminance', this does not break
exisiting content which is tested with exisiting tests.

http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html#the-mask-type

Tests: svg/css/mask-type.html
   svg/masking/mask-type-alpha-expected.svg
   svg/masking/mask-type-alpha.svg
   svg/masking/mask-type-luminance-expected.svg
   svg/masking/mask-type-luminance.svg
   svg/masking/mask-type-not-set-expected.svg
   svg/masking/mask-type-not-set.svg

* css/CSSComputedStyleDeclaration.cpp: Add mask-type property.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EMaskType):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSPropertyNames.in: Add mask-type.
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/SVGCSSValueKeywords.in:
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::diff):
* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialMaskType):
(WebCore::SVGRenderStyle::setMaskType):
(SVGRenderStyle):
(WebCore::SVGRenderStyle::maskType):
(WebCore::SVGRenderStyle::setBitDefaults):
* rendering/style/SVGRenderStyleDefs.h:
* rendering/svg/RenderSVGResourceMasker.cpp:

Switch between the two masking modes according to the
computed value of mask-type.

(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
(WebCore::cssPropertyToTypeMap):
* svg/svgattrs.in: Add the new attribute to the attribute list.

LayoutTests:

Added new tests for switching the masking mode on  element with 'mask-type'.

* svg/css/mask-type-expected.txt: Added.
* svg/css/mask-type.html: Added.
* svg/masking/mask-type-alpha-expected.svg: Added.
* svg/masking/mask-type-alpha.svg: Added.
* svg/masking/mask-type-luminance-expected.svg: Added.
* svg/masking/mask-type-luminance.svg: Added.
* svg/masking/mask-type-not-set-expected.svg: Added.
* svg/masking/mask-type-not-set.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSProperty.cpp
trunk/Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/SVGCSSParser.cpp
trunk/Source/WebCore/css/SVGCSSPropertyNames.in
trunk/Source/WebCore/css/SVGCSSStyleSelector.cpp
trunk/Source/WebCore/css/SVGCSSValueKeywords.in
trunk/Source/WebCore/rendering/style/SVGRenderStyle.cpp
trunk/Source/WebCore/rendering/style/SVGRenderStyle.h
trunk/Source/WebCore/rendering/style/SVGRenderStyleDefs.h
trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
trunk/Source/WebCore/svg/SVGStyledElement.cpp
trunk/Source/WebCore/svg/svgattrs.in


Added Paths

trunk/LayoutTests/svg/css/mask-type-expected.txt
trunk/LayoutTests/svg/css/mask-type.html
trunk/LayoutTests/svg/masking/
trunk/LayoutTests/svg/masking/mask-type-alpha-expected.svg
trunk/LayoutTests/svg/masking/mask-type-alpha.svg
trunk/LayoutTests/svg/masking/mask-type-luminance-expected.svg
trunk/LayoutTests/svg/masking/mask-type-luminance.svg
trunk/LayoutTests/svg/masking/mask-type-not-set-expected.svg
trunk/LayoutTests/svg/masking/mask-type-not-set.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (129017 => 129018)

--- trunk/LayoutTests/ChangeLog	2012-09-19 17:47:21 UTC (rev 129017)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 17:50:26 UTC (rev 129018)
@@ -1,3 +1,21 @@
+2012-09-18  Dirk Schulze  
+
+Implement 'mask-type' for 
+https://bugs.webkit.org/show_bug.cgi?id=97011
+
+Reviewed by Andreas Kling.
+
+Added new tests for switching the masking mode on  element with 'mask-type'.
+
+* svg/css/mask-type-expected.txt: Added.
+* svg/css/mask-type.html: Added.
+* svg/masking/mask-type-alpha-expected.svg: Added.
+* svg/masking/mask-type-alpha.svg: Added.
+* svg/masking/mask-type-luminance-expected.svg: Added.
+* svg/masking/mask-

[webkit-changes] [129020] trunk/Source

[pilgrim]

Title: [129020] trunk/Source








Revision 129020
Author pilg...@chromium.org
Date 2012-09-19 10:53:48 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97116

Reviewed by Adam Barth.

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.

* bindings/v8/V8Binding.cpp:
(WebCore::handleOutOfMemory):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didExhaustMemoryAvailableForScript):
(FrameLoaderClient):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didExhaustMemoryAvailableForScript):
(WebKit):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/loader/FrameLoaderClient.h
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129019 => 129020)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 17:52:14 UTC (rev 129019)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 17:53:48 UTC (rev 129020)
@@ -1,3 +1,20 @@
+2012-09-19  Mark Pilgrim  
+
+[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97116
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* bindings/v8/V8Binding.cpp:
+(WebCore::handleOutOfMemory):
+* loader/FrameLoaderClient.h:
+(WebCore::FrameLoaderClient::didExhaustMemoryAvailableForScript):
+(FrameLoaderClient):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
 2012-09-18  Dirk Schulze  
 
 Implement 'mask-type' for 


Modified: trunk/Source/WebCore/bindings/v8/V8Binding.cpp (129019 => 129020)

--- trunk/Source/WebCore/bindings/v8/V8Binding.cpp	2012-09-19 17:52:14 UTC (rev 129019)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.cpp	2012-09-19 17:53:48 UTC (rev 129020)
@@ -35,7 +35,8 @@
 #include "DOMStringList.h"
 #include "Element.h"
 #include "Frame.h"
-#include "PlatformSupport.h"
+#include "FrameLoader.h"
+#include "FrameLoaderClient.h"
 #include "QualifiedName.h"
 #include "Settings.h"
 #include "V8DOMStringList.h"
@@ -332,7 +333,7 @@
 frame->script()->windowShell()->destroyGlobal();
 
 #if PLATFORM(CHROMIUM)
-PlatformSupport::notifyJSOutOfMemory(frame);
+frame->loader()->client()->didExhaustMemoryAvailableForScript();
 #endif
 
 if (Settings* settings = frame->settings())


Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (129019 => 129020)

--- trunk/Source/WebCore/loader/FrameLoaderClient.h	2012-09-19 17:52:14 UTC (rev 129019)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h	2012-09-19 17:53:48 UTC (rev 129020)
@@ -278,6 +278,8 @@
 virtual void documentElementAvailable() = 0;
 virtual void didPerformFirstNavigation() const = 0; // "Navigation" here means a transition from one page to another that ends up in the back/forward list.
 
+virtual void didExhaustMemoryAvailableForScript() { };
+
 #if USE(V8)
 virtual void didCreateScriptContext(v8::Handle, int extensionGroup, int worldId) = 0;
 virtual void willReleaseScriptContext(v8::Handle, int worldId) = 0;


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (129019 => 129020)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-19 17:52:14 UTC (rev 129019)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-19 17:53:48 UTC (rev 129020)
@@ -113,9 +113,6 @@
 // IndexedDB --
 static PassRefPtr idbFactory();
 
-// _javascript_ -
-static void notifyJSOutOfMemory(Frame*);
-
 // Plugin -
 static bool plugins(bool refresh, Vector*);
 static NPObject* pluginScriptableObject(Widget*);


Modified: trunk/Source/WebKit/chromium/ChangeLog (129019 => 129020)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 17:52:14 UTC (rev 129019)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 17:53:48 UTC (rev 129020)
@@ -1,5 +1,22 @@
 2012-09-19  Mark Pilgrim  
 
+[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97116
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/FrameLoaderClientImpl.cpp:
+(WebKit::FrameLoaderClientImpl::didExh

[webkit-changes] [129019] trunk

[commit-queue]

Title: [129019] trunk








Revision 129019
Author commit-qu...@webkit.org
Date 2012-09-19 10:52:14 -0700 (Wed, 19 Sep 2012)


Log Message
[EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
https://bugs.webkit.org/show_bug.cgi?id=97082

Patch by Christophe Dumez  on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

WebChromeClient::selectItemWritingDirectionIsNatural() now returns
true for EFL-WK2, consistently with EFL-WK1, so that the style
is properly adjusted in RenderMenuList::adjustInnerStyle().

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):

LayoutTests:

Rebaseline fast/forms/select-writing-direction-natural.html and
unskip it for efl-wk2.

* platform/efl-wk2/TestExpectations:
* platform/efl/fast/forms/select-writing-direction-natural-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/fast/forms/select-writing-direction-natural-expected.png
trunk/LayoutTests/platform/efl-wk2/TestExpectations
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (129018 => 129019)

--- trunk/LayoutTests/ChangeLog	2012-09-19 17:50:26 UTC (rev 129018)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 17:52:14 UTC (rev 129019)
@@ -1,3 +1,16 @@
+2012-09-19  Christophe Dumez  
+
+[EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=97082
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Rebaseline fast/forms/select-writing-direction-natural.html and
+unskip it for efl-wk2.
+
+* platform/efl-wk2/TestExpectations:
+* platform/efl/fast/forms/select-writing-direction-natural-expected.png:
+
 2012-09-18  Dirk Schulze  
 
 Implement 'mask-type' for 


Modified: trunk/LayoutTests/platform/efl/fast/forms/select-writing-direction-natural-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (129018 => 129019)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-19 17:50:26 UTC (rev 129018)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-19 17:52:14 UTC (rev 129019)
@@ -194,7 +194,6 @@
 BUGWKEFL : editing/input/emacs-ctrl-o.html = TEXT
 BUGWKEFL : fast/block/float/float-in-float-hit-testing.html = TEXT
 BUGWKEFL : fast/dom/Window/mozilla-focus-blur.html = TEXT
-BUGWKEFL : fast/forms/select-writing-direction-natural.html = TEXT
 BUGWKEFL : fast/frames/flattening/iframe-tiny.html = TEXT
 BUGWKEFL : fast/replaced/no-focus-ring-embed.html = TEXT
 BUGWKEFL : fast/replaced/no-focus-ring-object.html = TEXT


Modified: trunk/Source/WebKit2/ChangeLog (129018 => 129019)

--- trunk/Source/WebKit2/ChangeLog	2012-09-19 17:50:26 UTC (rev 129018)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-19 17:52:14 UTC (rev 129019)
@@ -1,3 +1,17 @@
+2012-09-19  Christophe Dumez  
+
+[EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=97082
+
+Reviewed by Kenneth Rohde Christiansen.
+
+WebChromeClient::selectItemWritingDirectionIsNatural() now returns
+true for EFL-WK2, consistently with EFL-WK1, so that the style
+is properly adjusted in RenderMenuList::adjustInnerStyle().
+
+* WebProcess/WebCoreSupport/WebChromeClient.cpp:
+(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
+
 2012-09-19  Carlos Garcia Campos  
 
 [GTK] Add API to get/set the security policy of a given URI scheme to WebKit2 GTK+


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (129018 => 129019)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp	2012-09-19 17:50:26 UTC (rev 129018)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp	2012-09-19 17:52:14 UTC (rev 129019)
@@ -658,7 +658,7 @@
 
 bool WebChromeClient::selectItemWritingDirectionIsNatural()
 {
-#if PLATFORM(WIN)
+#if PLATFORM(WIN) || PLATFORM(EFL)
 return true;
 #else
 return false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129017] branches/chromium/1271/codereview.settings

[kareng]

Title: [129017] branches/chromium/1271/codereview.settings








Revision 129017
Author kar...@chromium.org
Date 2012-09-19 10:47:21 -0700 (Wed, 19 Sep 2012)


Log Message
adding for easy droverin

Added Paths

branches/chromium/1271/codereview.settings




Diff

Added: branches/chromium/1271/codereview.settings (0 => 129017)

--- branches/chromium/1271/codereview.settings	(rev 0)
+++ branches/chromium/1271/codereview.settings	2012-09-19 17:47:21 UTC (rev 129017)
@@ -0,0 +1,10 @@
+# This file is used by gcl to get repository specific information.
+CODE_REVIEW_SERVER: codereview.chromium.org
+CC_LIST: chromium-revi...@chromium.org
+VIEW_VC: http://src.chromium.org/viewvc/chrome?view=rev&revision=
+STATUS: http://chromium-status.appspot.com/status
+TRY_ON_UPLOAD: True
+TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try
+GITCL_PREUPLOAD: http://src.chromium.org/viewvc/trunk/tools/depot_tools/git-cl-upload-hook?revision=HEAD&root=chrome
+GITCL_PREDCOMMIT: http://src.chromium.org/viewvc/trunk/tools/depot_tools/git-cl-upload-hook?revision=HEAD&root=chrome
+LINT_IGNORE_REGEX: webkit/api/.*






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129016] trunk/Source

[pilgrim]

Title: [129016] trunk/Source








Revision 129016
Author pilg...@chromium.org
Date 2012-09-19 10:45:55 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Remove unused popupsAllowed function from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96521

Reviewed by Eric Seidel.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* bindings/v8/NPV8Object.cpp:
(WebCore::v8ObjectToNPObject):
(_NPN_Evaluate):
(_NPN_GetProperty):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/NPV8Object.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129015 => 129016)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 17:45:55 UTC (rev 129016)
@@ -1,3 +1,19 @@
+2012-09-19  Mark Pilgrim  
+
+[Chromium] Remove unused popupsAllowed function from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=96521
+
+Reviewed by Eric Seidel.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* bindings/v8/NPV8Object.cpp:
+(WebCore::v8ObjectToNPObject):
+(_NPN_Evaluate):
+(_NPN_GetProperty):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
 2012-09-19  Jonathan Dong  
 
 [BlackBerry] Add function playerId() in class PageClientBlackBerry


Modified: trunk/Source/WebCore/bindings/v8/NPV8Object.cpp (129015 => 129016)

--- trunk/Source/WebCore/bindings/v8/NPV8Object.cpp	2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebCore/bindings/v8/NPV8Object.cpp	2012-09-19 17:45:55 UTC (rev 129016)
@@ -28,7 +28,6 @@
 
 #include "NPV8Object.h"
 
-#include "PlatformSupport.h"
 #include "DOMWindow.h"
 #include "Frame.h"
 #include "NPObjectWrapper.h"
@@ -296,7 +295,8 @@
 
 bool _NPN_Evaluate(NPP npp, NPObject* npObject, NPString* npScript, NPVariant* result)
 {
-bool popupsAllowed = PlatformSupport::popupsAllowed(npp);
+// FIXME: Give the embedder a way to control this.
+bool popupsAllowed = false;
 return _NPN_EvaluateHelper(npp, popupsAllowed, npObject, npScript, result);
 }
 


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (129015 => 129016)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-19 17:45:55 UTC (rev 129016)
@@ -119,7 +119,6 @@
 // Plugin -
 static bool plugins(bool refresh, Vector*);
 static NPObject* pluginScriptableObject(Widget*);
-static bool popupsAllowed(NPP);
 
 // Screen -
 static int screenHorizontalDPI(Widget*);


Modified: trunk/Source/WebKit/chromium/ChangeLog (129015 => 129016)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 17:45:55 UTC (rev 129016)
@@ -1,3 +1,15 @@
+2012-09-19  Mark Pilgrim  
+
+[Chromium] Remove unused popupsAllowed function from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=96521
+
+Reviewed by Eric Seidel.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/PlatformSupport.cpp:
+(WebCore):
+
 2012-09-19  Kent Tamura  
 
 [Chromium] Fix crash in WebFrameImpl::loadHistoryItem


Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (129015 => 129016)

--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-09-19 17:45:55 UTC (rev 129016)
@@ -566,12 +566,6 @@
 return client->screenInfo().availableRect;
 }
 
-bool PlatformSupport::popupsAllowed(NPP npp)
-{
-// FIXME: Give the embedder a way to control this.
-return false;
-}
-
 #if ENABLE(WORKERS)
 WorkerContextProxy* WorkerContextProxy::create(Worker* worker)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129015] branches/chromium/1271/

[kareng]

Title: [129015] branches/chromium/1271/








Revision 129015
Author kar...@chromium.org
Date 2012-09-19 10:45:33 -0700 (Wed, 19 Sep 2012)


Log Message
creating chromium branch for m23

Added Paths

branches/chromium/1271/




Diff

Property changes: branches/chromium/1271



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129014] trunk/LayoutTests

[japhet]

Title: [129014] trunk/LayoutTests








Revision 129014
Author jap...@chromium.org
Date 2012-09-19 10:37:53 -0700 (Wed, 19 Sep 2012)


Log Message
2012-09-19  Nate Chapin  

chromium TestExpectations update.
fast/filesystem/file-writer-write-overlapped.html and
fast/filesystem/workers/file-writer-write-overlapped.html
are flaky in WIN DEBUG only.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129013 => 129014)

--- trunk/LayoutTests/ChangeLog	2012-09-19 17:25:59 UTC (rev 129013)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 17:37:53 UTC (rev 129014)
@@ -1,5 +1,14 @@
 2012-09-19  Nate Chapin  
 
+chromium TestExpectations update.
+fast/filesystem/file-writer-write-overlapped.html and
+fast/filesystem/workers/file-writer-write-overlapped.html
+are flaky in WIN DEBUG only.
+
+* platform/chromium/TestExpectations:
+
+2012-09-19  Nate Chapin  
+
 TextExpectations update, remove entries for consistently passing tests.
 https://bugs.webkit.org/show_bug.cgi?id=74746
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129013 => 129014)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 17:25:59 UTC (rev 129013)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 17:37:53 UTC (rev 129014)
@@ -2372,7 +2372,8 @@
 BUGWK56702 WIN DEBUG : http/tests/navigation/ping-cross-origin-from-https.html = PASS TIMEOUT
 
 BUGCR86338 : fast/loader/file-protocol-fragment.html = TEXT
-BUGCR86340 : fast/filesystem/file-writer-write-overlapped.html = PASS TEXT
+BUGCR86340 WIN DEBUG : fast/filesystem/file-writer-write-overlapped.html = PASS TEXT
+BUGCR86340 WIN DEBUG : fast/filesystem/workers/file-writer-write-overlapped.html = PASS TEXT
 
 // These seem to be minor differences (used to be debug only, started failing in release since about r116225).
 BUGWK60135 SNOWLEOPARD : fast/text/international/thai-line-breaks.html = PASS IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129013] trunk/LayoutTests

[japhet]

Title: [129013] trunk/LayoutTests








Revision 129013
Author jap...@chromium.org
Date 2012-09-19 10:25:59 -0700 (Wed, 19 Sep 2012)


Log Message
2012-09-19  Nate Chapin  

TextExpectations update, remove entries for consistently passing tests.
https://bugs.webkit.org/show_bug.cgi?id=74746

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129012 => 129013)

--- trunk/LayoutTests/ChangeLog	2012-09-19 17:14:00 UTC (rev 129012)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 17:25:59 UTC (rev 129013)
@@ -1,3 +1,10 @@
+2012-09-19  Nate Chapin  
+
+TextExpectations update, remove entries for consistently passing tests.
+https://bugs.webkit.org/show_bug.cgi?id=74746
+
+* platform/chromium/TestExpectations:
+
 2012-09-19  Zan Dobersek  
 
 Unreviewed GTK gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129012 => 129013)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 17:14:00 UTC (rev 129012)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-19 17:25:59 UTC (rev 129013)
@@ -2653,10 +2653,8 @@
 
 BUGWK74662 WIN LINUX ANDROID : fast/text/unicode-variation-selector.html = IMAGE+TEXT
 
-BUGWK74746 : fast/filesystem/workers/file-from-file-entry-sync.html = PASS TIMEOUT
-BUGWK74746 : fast/filesystem/workers/file-entry-to-uri-sync.html = PASS TIMEOUT
 BUGWK74746 WIN : http/tests/xmlhttprequest/workers/methods.html = TEXT TIMEOUT
-BUGWK74746 WIN : http/tests/xmlhttprequest/workers/methods-async.html = TEXT TIMEOUT
+BUGWK74746 WIN : http/tests/xmlhttprequest/workers/methods-async.html = TEXT
 
 BUGWK78725 : http/tests/filesystem/workers/resolve-url-sync.html = PASS TIMEOUT
 BUGWK78725 : http/tests/filesystem/workers/resolve-url.html = PASS TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129012] trunk/LayoutTests

[zandobersek]

Title: [129012] trunk/LayoutTests








Revision 129012
Author zandober...@gmail.com
Date 2012-09-19 10:14:00 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed GTK gardening.

Adding another flaky crasher expectation after r128802.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129011 => 129012)

--- trunk/LayoutTests/ChangeLog	2012-09-19 16:49:05 UTC (rev 129011)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 17:14:00 UTC (rev 129012)
@@ -4,6 +4,14 @@
 
 Adding another flaky crasher expectation after r128802.
 
+* platform/gtk/TestExpectations:
+
+2012-09-19  Zan Dobersek  
+
+Unreviewed GTK gardening.
+
+Adding another flaky crasher expectation after r128802.
+
 Adding platform-specific baselines after r128861.
 
 * platform/gtk/TestExpectations:


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (129011 => 129012)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-09-19 16:49:05 UTC (rev 129011)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-09-19 17:14:00 UTC (rev 129012)
@@ -471,6 +471,7 @@
 
 BUGWK97001 : storage/websql/execute-sql-args.html = CRASH PASS
 BUGWK97001 DEBUG : fast/dom/message-port-deleted-by-accessor.html = CRASH PASS
+BUGWK97001 DEBUG : fast/js/array-bad-time.html = CRASH PASS
 BUGWK97001 DEBUG : fast/js/array-slow-put.html = CRASH PASS
 BUGWK97001 DEBUG : fast/js/object-bad-time.html = CRASH PASS
 BUGWK97001 DEBUG : fast/js/Object-defineProperty.html = CRASH PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129011] trunk/Source/WebKit/efl

[commit-queue]

Title: [129011] trunk/Source/WebKit/efl








Revision 129011
Author commit-qu...@webkit.org
Date 2012-09-19 09:49:05 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed, rolling out r128995.
http://trac.webkit.org/changeset/128995
https://bugs.webkit.org/show_bug.cgi?id=97114

Causes the api tests to segfault. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot  on 2012-09-19

* tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::init):
(EWKUnitTests::EWKTestBase::shutdownAll):
(EWKUnitTests::EWKTestBase::startTest):
(EWKUnitTests::EWKTestBase::endTest):
(EWKUnitTests::EWKTestBase::createTest):
(EWKUnitTests):
(EWKUnitTests::EWKTestBase::runTest):
* tests/UnitTestUtils/EWKTestBase.h:
(EWKUnitTests):
(EWKTestBase):
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
(EWKUnitTests::EWKTestEcoreEvas::evas):
(EWKUnitTests):
(EWKUnitTests::EWKTestEcoreEvas::show):
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init):
(EWKUnitTests::EWKTestView::show):
(EWKUnitTests::EWKTestView::mainFrame):
(EWKUnitTests::EWKTestView::evas):
(EWKUnitTests::EWKTestView::bindEvents):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestEcoreEvas):
(EWKUnitTests):
(EWKTestView):
* tests/test_ewk_view.cpp:
(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):
* tests/test_runner.cpp:
(main):

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.h
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h
trunk/Source/WebKit/efl/tests/test_ewk_view.cpp
trunk/Source/WebKit/efl/tests/test_runner.cpp




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (129010 => 129011)

--- trunk/Source/WebKit/efl/ChangeLog	2012-09-19 15:54:15 UTC (rev 129010)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-09-19 16:49:05 UTC (rev 129011)
@@ -1,3 +1,45 @@
+2012-09-19  Sheriff Bot  
+
+Unreviewed, rolling out r128995.
+http://trac.webkit.org/changeset/128995
+https://bugs.webkit.org/show_bug.cgi?id=97114
+
+Causes the api tests to segfault. (Requested by rakuco on
+#webkit).
+
+* tests/UnitTestUtils/EWKTestBase.cpp:
+(EWKUnitTests::EWKTestBase::init):
+(EWKUnitTests::EWKTestBase::shutdownAll):
+(EWKUnitTests::EWKTestBase::startTest):
+(EWKUnitTests::EWKTestBase::endTest):
+(EWKUnitTests::EWKTestBase::createTest):
+(EWKUnitTests):
+(EWKUnitTests::EWKTestBase::runTest):
+* tests/UnitTestUtils/EWKTestBase.h:
+(EWKUnitTests):
+(EWKTestBase):
+* tests/UnitTestUtils/EWKTestView.cpp:
+(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
+(EWKUnitTests::EWKTestEcoreEvas::evas):
+(EWKUnitTests):
+(EWKUnitTests::EWKTestEcoreEvas::show):
+(EWKUnitTests::EWKTestView::EWKTestView):
+(EWKUnitTests::EWKTestView::init):
+(EWKUnitTests::EWKTestView::show):
+(EWKUnitTests::EWKTestView::mainFrame):
+(EWKUnitTests::EWKTestView::evas):
+(EWKUnitTests::EWKTestView::bindEvents):
+* tests/UnitTestUtils/EWKTestView.h:
+(EWKTestEcoreEvas):
+(EWKUnitTests):
+(EWKTestView):
+* tests/test_ewk_view.cpp:
+(ewkViewEditableGetCb):
+(TEST):
+(ewkViewUriGetCb):
+* tests/test_runner.cpp:
+(main):
+
 2012-09-19  Krzysztof Czech  
 
 [EFL][UT] Refactoring an implementation of testing framework for wk1.


Modified: trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp (129010 => 129011)

--- trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp	2012-09-19 15:54:15 UTC (rev 129010)
+++ trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp	2012-09-19 16:49:05 UTC (rev 129011)
@@ -19,7 +19,10 @@
 #include "config.h"
 #include "EWKTestBase.h"
 
+#include "EWKTestConfig.h"
+#include "EWKTestView.h"
 #include 
+
 #include 
 #include 
 
@@ -27,52 +30,73 @@
 
 namespace EWKUnitTests {
 
-EWKTestBase::EWKTestBase()
-: m_ewkTestView(0)
+bool EWKTestBase::init()
 {
-}
+if (!ecore_evas_init())
+return false;
 
-Evas_Object* EWKTestBase::webView()
-{
-return m_ewkTestView->webView();
+if (!edje_init()) {
+ecore_evas_shutdown();
+return false;
+}
+
+int ret = ewk_init();
+const char* proxyUri = getenv("http_proxy");
+
+if (ret && proxyUri)
+ewk_network_proxy_uri_set(proxyUri);
+
+return ret;
 }
 
-void EWKTestBase::SetUp()
+void EWKTestBase::shutdownAll()
 {
-ASSERT_GT(ecore_evas_init(), 0);
-ASSERT_GT(ewk_init(), 0);
+int count = 0;
 
-const char* proxyUrl = getenv("http_proxy");
-if (proxyUrl)
-ewk_network_proxy_uri_set(proxyUrl);
-
-m_ewkTestView = new EWKTestView();
+while ((count = ecore_evas_shutdown()) > 0) { }
+while ((count = edje_shutdown()

[webkit-changes] [129010] trunk/Source

[commit-queue]

Title: [129010] trunk/Source








Revision 129010
Author commit-qu...@webkit.org
Date 2012-09-19 08:54:15 -0700 (Wed, 19 Sep 2012)


Log Message
[BlackBerry] Add function playerId() in class PageClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=97099

Patch by Jonathan Dong  on 2012-09-19
Reviewed by Yong Li.

Source/WebCore:

Added function playerID() in class PageClientBlackBerry.

Internally reviewed by Charles Wei.

No new tests since there's no functional change.

* platform/blackberry/PageClientBlackBerry.h:

Source/WebKit/blackberry:

Implemented PageClientBlackBerry::playerID() in class WebPagePrivate,
and replaced the implementation of FrameLoaderClientBlackBerry::playerId().

Internally reviewed by Charles Wei.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::playerID):
(WebKit):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::playerId):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/PageClientBlackBerry.h
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129009 => 129010)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 15:30:43 UTC (rev 129009)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 15:54:15 UTC (rev 129010)
@@ -1,3 +1,18 @@
+2012-09-19  Jonathan Dong  
+
+[BlackBerry] Add function playerId() in class PageClientBlackBerry
+https://bugs.webkit.org/show_bug.cgi?id=97099
+
+Reviewed by Yong Li.
+
+Added function playerID() in class PageClientBlackBerry.
+
+Internally reviewed by Charles Wei.
+
+No new tests since there's no functional change.
+
+* platform/blackberry/PageClientBlackBerry.h:
+
 2012-09-19  Raul Hudea  
 
 [CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined


Modified: trunk/Source/WebCore/platform/blackberry/PageClientBlackBerry.h (129009 => 129010)

--- trunk/Source/WebCore/platform/blackberry/PageClientBlackBerry.h	2012-09-19 15:30:43 UTC (rev 129009)
+++ trunk/Source/WebCore/platform/blackberry/PageClientBlackBerry.h	2012-09-19 15:54:15 UTC (rev 129010)
@@ -49,6 +49,7 @@
 SaveCredentialYes
 };
 
+virtual int playerID() const = 0;
 virtual void setCursor(WebCore::PlatformCursor) = 0;
 virtual BlackBerry::Platform::NetworkStreamFactory* networkStreamFactory() = 0;
 virtual BlackBerry::Platform::Graphics::Window* platformWindow() const = 0;


Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (129009 => 129010)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-09-19 15:30:43 UTC (rev 129009)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-09-19 15:54:15 UTC (rev 129010)
@@ -2058,6 +2058,11 @@
 return true; // Needs re-layout!
 }
 
+int WebPagePrivate::playerID() const
+{
+return m_client ? m_client->getInstanceId() : 0;
+}
+
 void WebPagePrivate::setCursor(PlatformCursor handle)
 {
 if (m_currentCursor.type() != handle.type()) {


Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (129009 => 129010)

--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h	2012-09-19 15:30:43 UTC (rev 129009)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h	2012-09-19 15:54:15 UTC (rev 129010)
@@ -179,6 +179,7 @@
 WebCore::IntSize absoluteVisibleOverflowSize() const;
 
 // Virtual functions inherited from PageClientBlackBerry.
+virtual int playerID() const;
 virtual void setCursor(WebCore::PlatformCursor);
 virtual Platform::NetworkStreamFactory* networkStreamFactory();
 virtual Platform::Graphics::Window* platformWindow() const;


Modified: trunk/Source/WebKit/blackberry/ChangeLog (129009 => 129010)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-19 15:30:43 UTC (rev 129009)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-19 15:54:15 UTC (rev 129010)
@@ -1,3 +1,23 @@
+2012-09-19  Jonathan Dong  
+
+[BlackBerry] Add function playerId() in class PageClientBlackBerry
+https://bugs.webkit.org/show_bug.cgi?id=97099
+
+Reviewed by Yong Li.
+
+Implemented PageClientBlackBerry::playerID() in class WebPagePrivate,
+and replaced the implementation of FrameLoaderClientBlackBerry::playerId().
+
+Internally reviewed by Charles Wei.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::playerID):
+(WebKit):
+* Api/WebPage_p.h:
+(WebPagePrivate):
+* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+(WebCore::FrameLoaderClientBlackBerry::playerId):
+
 2012-09-19  Abbas Sherawala  
 
 [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic


Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.

[webkit-changes] [129009] trunk/Source/WebCore

[commit-queue]

Title: [129009] trunk/Source/WebCore








Revision 129009
Author commit-qu...@webkit.org
Date 2012-09-19 08:30:43 -0700 (Wed, 19 Sep 2012)


Log Message
[CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined
https://bugs.webkit.org/show_bug.cgi?id=96300

Patch by Raul Hudea  on 2012-09-19
Reviewed by Yury Semikhatsky.

All CSS Regions APIs should be exposed only if CSS_REGIONS is enabled

No new tests because of no behavior changes.

* css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage): Fix compile without CSS_REGIONS enabled and added an ASSERT_NOT_REACHED as in other functions
* dom/Element.cpp: Compile webkitRegionOverset only if CSS_REGIONS is enabled
(WebCore):
* dom/Element.h:
* dom/Element.idl: Expose webkitRegionOverset only if CSS_REGIONS is enabled

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleRule.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/Element.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (129008 => 129009)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 15:12:46 UTC (rev 129008)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 15:30:43 UTC (rev 129009)
@@ -1,3 +1,21 @@
+2012-09-19  Raul Hudea  
+
+[CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined
+https://bugs.webkit.org/show_bug.cgi?id=96300
+
+Reviewed by Yury Semikhatsky.
+
+All CSS Regions APIs should be exposed only if CSS_REGIONS is enabled
+
+No new tests because of no behavior changes.
+
+* css/StyleRule.cpp:
+(WebCore::StyleRuleBase::reportMemoryUsage): Fix compile without CSS_REGIONS enabled and added an ASSERT_NOT_REACHED as in other functions
+* dom/Element.cpp: Compile webkitRegionOverset only if CSS_REGIONS is enabled
+(WebCore):
+* dom/Element.h:
+* dom/Element.idl: Expose webkitRegionOverset only if CSS_REGIONS is enabled
+
 2012-09-19  Patrick Gansterer  
 
 Remove all usages of M_PI from WebCore


Modified: trunk/Source/WebCore/css/StyleRule.cpp (129008 => 129009)

--- trunk/Source/WebCore/css/StyleRule.cpp	2012-09-19 15:12:46 UTC (rev 129008)
+++ trunk/Source/WebCore/css/StyleRule.cpp	2012-09-19 15:30:43 UTC (rev 129009)
@@ -81,7 +81,10 @@
 case Unknown:
 case Charset:
 case Keyframe:
-MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::CSS);
+#if !ENABLE(CSS_REGIONS)
+case Region:
+#endif
+ASSERT_NOT_REACHED();
 return;
 }
 ASSERT_NOT_REACHED();


Modified: trunk/Source/WebCore/dom/Element.cpp (129008 => 129009)

--- trunk/Source/WebCore/dom/Element.cpp	2012-09-19 15:12:46 UTC (rev 129008)
+++ trunk/Source/WebCore/dom/Element.cpp	2012-09-19 15:30:43 UTC (rev 129009)
@@ -2033,6 +2033,8 @@
 return 0;
 }
 
+#if ENABLE(CSS_REGIONS)
+
 const AtomicString& Element::webkitRegionOverset() const
 {
 document()->updateLayoutIgnorePendingStylesheets();
@@ -2062,8 +2064,6 @@
 return undefinedState;
 }
 
-#if ENABLE(CSS_REGIONS)
-
 Vector > Element::webkitGetRegionFlowRanges() const
 {
 document()->updateLayoutIgnorePendingStylesheets();


Modified: trunk/Source/WebCore/dom/Element.h (129008 => 129009)

--- trunk/Source/WebCore/dom/Element.h	2012-09-19 15:12:46 UTC (rev 129008)
+++ trunk/Source/WebCore/dom/Element.h	2012-09-19 15:30:43 UTC (rev 129009)
@@ -426,8 +426,8 @@
 PassRefPtr styleForRenderer();
 
 RenderRegion* renderRegion() const;
+#if ENABLE(CSS_REGIONS)
 const AtomicString& webkitRegionOverset() const;
-#if ENABLE(CSS_REGIONS)
 Vector > webkitGetRegionFlowRanges() const;
 #endif
 


Modified: trunk/Source/WebCore/dom/Element.idl (129008 => 129009)

--- trunk/Source/WebCore/dom/Element.idl	2012-09-19 15:12:46 UTC (rev 129008)
+++ trunk/Source/WebCore/dom/Element.idl	2012-09-19 15:30:43 UTC (rev 129009)
@@ -143,7 +143,7 @@
 [Conditional=POINTER_LOCK, V8EnabledAtRuntime=pointerLock] void webkitRequestPointerLock();
 
 // CSS Regions API
-readonly attribute DOMString webkitRegionOverset;
+readonly attribute [Conditional=CSS_REGIONS] DOMString webkitRegionOverset;
 [Conditional=CSS_REGIONS] sequence webkitGetRegionFlowRanges();
 
 #if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129008] trunk/LayoutTests

[zandobersek]

Title: [129008] trunk/LayoutTests








Revision 129008
Author zandober...@gmail.com
Date 2012-09-19 08:12:46 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed GTK gardening.

Adding another flaky crasher expectation after r128802.

Adding platform-specific baselines after r128861.

* platform/gtk/TestExpectations:
* platform/gtk/fast/regions/autoheight-regions-mark-expected.png: Added.
* platform/gtk/fast/regions/autoheight-regions-mark-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/platform/gtk/fast/regions/autoheight-regions-mark-expected.png
trunk/LayoutTests/platform/gtk/fast/regions/autoheight-regions-mark-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (129007 => 129008)

--- trunk/LayoutTests/ChangeLog	2012-09-19 15:05:15 UTC (rev 129007)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 15:12:46 UTC (rev 129008)
@@ -1,3 +1,15 @@
+2012-09-19  Zan Dobersek  
+
+Unreviewed GTK gardening.
+
+Adding another flaky crasher expectation after r128802.
+
+Adding platform-specific baselines after r128861.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/regions/autoheight-regions-mark-expected.png: Added.
+* platform/gtk/fast/regions/autoheight-regions-mark-expected.txt: Added.
+
 2012-09-19  Christophe Dumez  
 
 [EFL] Rebaseline a few mozilla/table/bugs tests that were missed


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (129007 => 129008)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-09-19 15:05:15 UTC (rev 129007)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-09-19 15:12:46 UTC (rev 129008)
@@ -470,6 +470,7 @@
 BUGWK94458 DEBUG : fast/events/message-port-context-destroyed.html = CRASH PASS
 
 BUGWK97001 : storage/websql/execute-sql-args.html = CRASH PASS
+BUGWK97001 DEBUG : fast/dom/message-port-deleted-by-accessor.html = CRASH PASS
 BUGWK97001 DEBUG : fast/js/array-slow-put.html = CRASH PASS
 BUGWK97001 DEBUG : fast/js/object-bad-time.html = CRASH PASS
 BUGWK97001 DEBUG : fast/js/Object-defineProperty.html = CRASH PASS


Added: trunk/LayoutTests/platform/gtk/fast/regions/autoheight-regions-mark-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/gtk/fast/regions/autoheight-regions-mark-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/gtk/fast/regions/autoheight-regions-mark-expected.txt (0 => 129008)

--- trunk/LayoutTests/platform/gtk/fast/regions/autoheight-regions-mark-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/regions/autoheight-regions-mark-expected.txt	2012-09-19 15:12:46 UTC (rev 129008)
@@ -0,0 +1,38 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x116
+  RenderBlock {HTML} at (0,0) size 800x116
+RenderBody {BODY} at (8,8) size 784x100
+  RenderRegion {DIV} at (0,0) size 50x50
+  RenderRegion {DIV} at (0,50) size 50x0
+  RenderRegion {DIV} at (0,50) size 50x0
+  RenderRegion {DIV} at (0,50) size 50x50
+Flow Threads
+  Thread with flow-name 'flow'
+layer at (0,0) size 50x50
+  RenderNamedFlowThread at (0,0) size 50x50
+  Regions for flow 'flow'
+RenderRegion {DIV} #region
+  Thread with flow-name 'flow2'
+  Regions for flow 'flow2'
+RenderRegion {DIV} #region2 hasAutoLogicalHeight
+  Thread with flow-name 'flow3'
+  Regions for flow 'flow3'
+RenderRegion {DIV} #region3
+  Thread with flow-name 'flow4'
+  Regions for flow 'flow4'
+RenderRegion {DIV} #region4
+  Thread with flow-name 'flow5'
+  Regions for flow 'flow5'
+RenderRegion {DIV} #region5 hasAutoLogicalHeight
+  Thread with flow-name 'flow6'
+layer at (0,0) size 50x50
+  RenderNamedFlowThread at (0,0) size 50x50
+  Regions for flow 'flow6'
+RenderRegion {DIV} #region6
+  Thread with flow-name 'flow8'
+  Regions for flow 'flow8'
+RenderRegion {DIV} #region8 invalid
+  Thread with flow-name 'flow7'
+  Regions for flow 'flow7'
+RenderRegion {DIV} #region7 hasAutoLogicalHeight






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129007] trunk/Tools

[hausmann]

Title: [129007] trunk/Tools








Revision 129007
Author hausm...@webkit.org
Date 2012-09-19 08:05:15 -0700 (Wed, 19 Sep 2012)


Log Message
[Qt] Fix incremental builds with all-in-one-files and gccdepends

Reviewed by Tor Arne Vestbø.

Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
are not only created for header files but also for .cpp files. AllInOne.cpp files
include other .cpp files, and when those are removed we need those dummy rules to
avoid a "No rule to make Foo.cpp required by AllInOne.o" error.

* qmake/config.tests/gccdepends/empty.cpp:
(main):
* qmake/config.tests/gccdepends/gccdepends.pro:
* qmake/mkspecs/features/default_pre.prf:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/config.tests/gccdepends/empty.cpp
trunk/Tools/qmake/config.tests/gccdepends/gccdepends.pro
trunk/Tools/qmake/mkspecs/features/default_pre.prf




Diff

Modified: trunk/Tools/ChangeLog (129006 => 129007)

--- trunk/Tools/ChangeLog	2012-09-19 14:52:08 UTC (rev 129006)
+++ trunk/Tools/ChangeLog	2012-09-19 15:05:15 UTC (rev 129007)
@@ -1,3 +1,19 @@
+2012-09-19  Simon Hausmann  
+
+[Qt] Fix incremental builds with all-in-one-files and gccdepends
+
+Reviewed by Tor Arne Vestbø.
+
+Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
+are not only created for header files but also for .cpp files. AllInOne.cpp files
+include other .cpp files, and when those are removed we need those dummy rules to
+avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
+
+* qmake/config.tests/gccdepends/empty.cpp:
+(main):
+* qmake/config.tests/gccdepends/gccdepends.pro:
+* qmake/mkspecs/features/default_pre.prf:
+
 2012-09-19  Rick Byers  
 
 Do touch adjustment on GestureTapDown


Modified: trunk/Tools/qmake/config.tests/gccdepends/empty.cpp (129006 => 129007)

--- trunk/Tools/qmake/config.tests/gccdepends/empty.cpp	2012-09-19 14:52:08 UTC (rev 129006)
+++ trunk/Tools/qmake/config.tests/gccdepends/empty.cpp	2012-09-19 15:05:15 UTC (rev 129007)
@@ -0,0 +1,2 @@
+
+int main() { return 0; }


Modified: trunk/Tools/qmake/config.tests/gccdepends/gccdepends.pro (129006 => 129007)

--- trunk/Tools/qmake/config.tests/gccdepends/gccdepends.pro	2012-09-19 14:52:08 UTC (rev 129006)
+++ trunk/Tools/qmake/config.tests/gccdepends/gccdepends.pro	2012-09-19 15:05:15 UTC (rev 129007)
@@ -1,6 +1,8 @@
-TEMPLATE = aux
+TEMPLATE = app
 OBJECTS_DIR = obj
-QMAKE_CXXFLAGS += -MD
+CONFIG += GNUmake gcc_MD_depends
+QMAKE_CXXFLAGS += -MP
+TARGET = empty
 
 base_filename = empty
 object_file = $$OBJECTS_DIR/$${base_filename}.o


Modified: trunk/Tools/qmake/mkspecs/features/default_pre.prf (129006 => 129007)

--- trunk/Tools/qmake/mkspecs/features/default_pre.prf	2012-09-19 14:52:08 UTC (rev 129006)
+++ trunk/Tools/qmake/mkspecs/features/default_pre.prf	2012-09-19 15:05:15 UTC (rev 129007)
@@ -87,6 +87,9 @@
 # We have a compiler that supports the -MD option (and neither
 # teambuilder nor icecream is messing up the .d file output).
 CONFIG += GNUmake gcc_MD_depends
+# This should really be added to qmake, but for now we add it here.
+QMAKE_CXXFLAGS += -MP
+QMAKE_CFLAGS += -MP
 }
 
 !haveQt(5):!recursive_include: error("Building WebKit with Qt versions older than 5.0 is not supported.")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129006] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [129006] trunk/Source/WebKit/blackberry








Revision 129006
Author commit-qu...@webkit.org
Date 2012-09-19 07:52:08 -0700 (Wed, 19 Sep 2012)


Log Message
[BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
Added a missing 'if' statement.
https://bugs.webkit.org/show_bug.cgi?id=96925

PR #180866

Internally Reviewed by Antonio Gomes.

Adding an 'if' statement which should have been in PR # 180866 (SHA:b9c06af395c22e)

Patch by Abbas Sherawala  on 2012-09-19
Reviewed by Antonio Gomes.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

Modified Paths

trunk/Source/WebKit/blackberry/Api/BackingStore.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (129005 => 129006)

--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2012-09-19 14:42:52 UTC (rev 129005)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2012-09-19 14:52:08 UTC (rev 129006)
@@ -360,6 +360,8 @@
 --m_suspendScreenUpdates;
 BlackBerry::Platform::userInterfaceThreadMessageClient()->syncToCurrentMessage();
 
+if (op == BackingStore::None)
+return;
 #if USE(ACCELERATED_COMPOSITING)
 // This will also blit since we set the OSDS flag above.
 m_webPage->d->commitRootLayerIfNeeded();


Modified: trunk/Source/WebKit/blackberry/ChangeLog (129005 => 129006)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-19 14:42:52 UTC (rev 129005)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-19 14:52:08 UTC (rev 129006)
@@ -1,3 +1,20 @@
+2012-09-19  Abbas Sherawala  
+
+[BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
+Added a missing 'if' statement.
+https://bugs.webkit.org/show_bug.cgi?id=96925
+
+PR #180866
+
+Internally Reviewed by Antonio Gomes.
+
+Adding an 'if' statement which should have been in PR # 180866 (SHA:b9c06af395c22e)
+
+Reviewed by Antonio Gomes.
+
+* Api/BackingStore.cpp:
+(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
+
 2012-09-18  Nima Ghanavatian  
 
 [BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129005] trunk/Source/WebCore

[paroga]

Title: [129005] trunk/Source/WebCore








Revision 129005
Author par...@webkit.org
Date 2012-09-19 07:42:52 -0700 (Wed, 19 Sep 2012)


Log Message
Remove all usages of M_PI from WebCore
https://bugs.webkit.org/show_bug.cgi?id=93109

Reviewed by Dirk Schulze.

 implements many functions dealing with M_PI.
Use them in WebCore instead of duplicating the functionality.

* platform/blackberry/PlatformTouchEventBlackBerry.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
* platform/graphics/wx/FontPlatformDataWxMac.mm:
* platform/mac/WebWindowAnimation.mm:
(-[WebWindowScaleAnimation currentValue]):
* platform/wx/wxcode/gdiplus/non-kerned-drawing.cpp:
(DegToRad):
(RadToDeg):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/PlatformTouchEventBlackBerry.cpp
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/wx/FontPlatformDataWxMac.mm
trunk/Source/WebCore/platform/mac/WebWindowAnimation.mm
trunk/Source/WebCore/platform/wx/wxcode/gdiplus/non-kerned-drawing.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129004 => 129005)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 14:37:11 UTC (rev 129004)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 14:42:52 UTC (rev 129005)
@@ -1,3 +1,27 @@
+2012-09-19  Patrick Gansterer  
+
+Remove all usages of M_PI from WebCore
+https://bugs.webkit.org/show_bug.cgi?id=93109
+
+Reviewed by Dirk Schulze.
+
+ implements many functions dealing with M_PI.
+Use them in WebCore instead of duplicating the functionality.
+
+* platform/blackberry/PlatformTouchEventBlackBerry.cpp:
+(WebCore::PlatformTouchEvent::PlatformTouchEvent):
+* platform/graphics/ca/mac/PlatformCALayerMac.mm:
+(PlatformCALayer::setFilters):
+* platform/graphics/cairo/GraphicsContextCairo.cpp:
+(WebCore::GraphicsContext::drawEllipse):
+(WebCore::GraphicsContext::strokeArc):
+* platform/graphics/wx/FontPlatformDataWxMac.mm:
+* platform/mac/WebWindowAnimation.mm:
+(-[WebWindowScaleAnimation currentValue]):
+* platform/wx/wxcode/gdiplus/non-kerned-drawing.cpp:
+(DegToRad):
+(RadToDeg):
+
 2012-09-10  Vsevolod Vlasov  
 
 Web Inspector: Network request headers text fallback has typo.


Modified: trunk/Source/WebCore/platform/blackberry/PlatformTouchEventBlackBerry.cpp (129004 => 129005)

--- trunk/Source/WebCore/platform/blackberry/PlatformTouchEventBlackBerry.cpp	2012-09-19 14:37:11 UTC (rev 129004)
+++ trunk/Source/WebCore/platform/blackberry/PlatformTouchEventBlackBerry.cpp	2012-09-19 14:42:52 UTC (rev 129005)
@@ -22,12 +22,12 @@
 #include "config.h"
 #include "PlatformTouchEvent.h"
 
+#if ENABLE(TOUCH_EVENTS)
+
 #include 
-
 #include 
+#include 
 
-#if ENABLE(TOUCH_EVENTS)
-
 namespace WebCore {
 
 static PlatformEvent::Type touchEventType(BlackBerry::Platform::TouchEvent* event)
@@ -66,7 +66,7 @@
 if (event->hasGesture(BlackBerry::Platform::Gesture::Pinch, &pinch)) {
 BlackBerry::Platform::PinchGestureData* data = ""
 if (data) {
-m_rotation = data->m_angle * 180 / M_PI;
+m_rotation = rad2deg(data->m_angle);
 m_scale = data->m_scale;
 }
 } else if (event->hasGesture(BlackBerry::Platform::Gesture::DoubleTap))


Modified: trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm (129004 => 129005)

--- trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm	2012-09-19 14:37:11 UTC (rev 129004)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm	2012-09-19 14:42:52 UTC (rev 129005)
@@ -42,6 +42,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 
 using std::min;
@@ -755,7 +756,7 @@
 [caFilter setDefaults];
 
 // The CIHueAdjust value is in radians
-[caFilter setValue:[NSNumber numberWithFloat:op->amount() * M_PI * 2 / 360] forKey:@"inputAngle"];
+[caFilter setValue:[NSNumber numberWithFloat:deg2rad(op->amount())] forKey:@"inputAngle"];
 [caFilter setName:filterName];
 [array.get() addObject:caFilter];
 break;


Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp (129004 => 129005)

--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp	2012-09-19 14:37:11 UTC (rev 129004)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp	2012-09-19 14:42:52 UTC (rev 129005)
@@ -65,10 +65,6 @@
 
 using namespace std;
 
-#ifndef M_PI
-#define M_PI 3.14159265358979323846
-#endif
-
 namespace WebCore {
 
 // A helper which quickly fills a

[webkit-changes] [129004] trunk/LayoutTests

[commit-queue]

Title: [129004] trunk/LayoutTests








Revision 129004
Author commit-qu...@webkit.org
Date 2012-09-19 07:37:11 -0700 (Wed, 19 Sep 2012)


Log Message
[EFL] Rebaseline a few mozilla/table/bugs tests that were missed
https://bugs.webkit.org/show_bug.cgi?id=97107

Unreviewed EFL rebaseline.

Rebaseline a few tables/mozilla/bugs tests that
were forgotten during my massive tables/mozilla
rebaseline.

Patch by Christophe Dumez  on 2012-09-19

* platform/efl/TestExpectations:
* platform/efl/tables/mozilla/bugs/45621-expected.png:
* platform/efl/tables/mozilla/bugs/bug9072-expected.png:
* platform/efl/tables/mozilla/bugs/bug9123-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug9123-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug92143-expected.png:
* platform/efl/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug9271-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug9271-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug92868-expected.png:
* platform/efl/tables/mozilla/bugs/bug93363-expected.png:
* platform/efl/tables/mozilla/bugs/bug963-expected.png:
* platform/efl/tables/mozilla/bugs/bug96334-expected.png:
* platform/efl/tables/mozilla/bugs/bug96343-expected.png:
* platform/efl/tables/mozilla/bugs/bug965-expected.png:
* platform/efl/tables/mozilla/bugs/bug97138-expected.png:
* platform/efl/tables/mozilla/bugs/bug98196-expected.png:
* platform/efl/tables/mozilla/bugs/bug9879-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug99923-expected.png:
* platform/efl/tables/mozilla/bugs/bug99948-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/45621-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug9072-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug9123-1-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug9123-2-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug92143-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug92647-2-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug9271-1-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug9271-2-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug92868-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug93363-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug963-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug96334-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug96343-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug965-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug97138-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug98196-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug9879-1-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug99923-expected.png
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug99948-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (129003 => 129004)

--- trunk/LayoutTests/ChangeLog	2012-09-19 14:26:34 UTC (rev 129003)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 14:37:11 UTC (rev 129004)
@@ -1,3 +1,35 @@
+2012-09-19  Christophe Dumez  
+
+[EFL] Rebaseline a few mozilla/table/bugs tests that were missed
+https://bugs.webkit.org/show_bug.cgi?id=97107
+
+Unreviewed EFL rebaseline.
+
+Rebaseline a few tables/mozilla/bugs tests that
+were forgotten during my massive tables/mozilla
+rebaseline.
+
+* platform/efl/TestExpectations:
+* platform/efl/tables/mozilla/bugs/45621-expected.png:
+* platform/efl/tables/mozilla/bugs/bug9072-expected.png:
+* platform/efl/tables/mozilla/bugs/bug9123-1-expected.png:
+* platform/efl/tables/mozilla/bugs/bug9123-2-expected.png:
+* platform/efl/tables/mozilla/bugs/bug92143-expected.png:
+* platform/efl/tables/mozilla/bugs/bug92647-2-expected.png:
+* platform/efl/tables/mozilla/bugs/bug9271-1-expected.png:
+* platform/efl/tables/mozilla/bugs/bug9271-2-expected.png:
+* platform/efl/tables/mozilla/bugs/bug92868-expected.png:
+* platform/efl/tables/mozilla/bugs/bug93363-expected.png:
+* platform/efl/tables/mozilla/bugs/bug963-expected.png:
+* platform/efl/tables/mozilla/bugs/bug96334-expected.png:
+* platform/efl/tables/mozilla/bugs/bug96343-expected.png:
+* platform/efl/tables/mozilla/bugs/bug965-expected.png:
+* platform/efl/tables/mozilla/bugs/bug97138-expected.png:
+* platform/efl/tables/mozilla/bugs/bug98196-expected.png:
+* platform/efl/tables/mozilla/bugs/bug9879-1-expected.png:
+* platform/efl/tables/mozilla/bugs/bug99923-expected.png:
+* platform/efl/tables/mozilla/bugs/bug99948-expected.png:
+
 2012-09-19  Jochen Eisinger  
 
 [chromium] Update tes

[webkit-changes] [129003] trunk/Source/WebCore

[vsevik]

Title: [129003] trunk/Source/WebCore








Revision 129003
Author vse...@chromium.org
Date 2012-09-19 07:26:34 -0700 (Wed, 19 Sep 2012)


Log Message
Web Inspector: Network request headers text fallback has typo.
https://bugs.webkit.org/show_bug.cgi?id=96280

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkRequest.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (129002 => 129003)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 14:12:37 UTC (rev 129002)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 14:26:34 UTC (rev 129003)
@@ -1,3 +1,14 @@
+2012-09-10  Vsevolod Vlasov  
+
+Web Inspector: Network request headers text fallback has typo.
+https://bugs.webkit.org/show_bug.cgi?id=96280
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/NetworkRequest.js:
+(WebInspector.NetworkRequest.prototype.get requestHeadersText):
+(WebInspector.NetworkRequest.prototype.get responseHeadersText):
+
 2012-09-19  Jonathan Dong  
 
 [BlackBerry] remove static_cast which will cause video crash


Modified: trunk/Source/WebCore/inspector/front-end/NetworkRequest.js (129002 => 129003)

--- trunk/Source/WebCore/inspector/front-end/NetworkRequest.js	2012-09-19 14:12:37 UTC (rev 129002)
+++ trunk/Source/WebCore/inspector/front-end/NetworkRequest.js	2012-09-19 14:26:34 UTC (rev 129003)
@@ -420,9 +420,9 @@
  */
 get requestHeadersText()
 {
-if (this._requestHeadersText === undefined) {
+if (typeof this._requestHeadersText === "undefined") {
 this._requestHeadersText = this.requestMethod + " " + this.url + " HTTP/1.1\r\n";
-for (var i = 0; i < this.requestHeaders; ++i)
+for (var i = 0; i < this.requestHeaders.length; ++i)
 this._requestHeadersText += this.requestHeaders[i].name + ": " + this.requestHeaders[i].value + "\r\n";
 }
 return this._requestHeadersText;
@@ -522,9 +522,9 @@
  */
 get responseHeadersText()
 {
-if (this._responseHeadersText === undefined) {
+if (typeof this._responseHeadersText === "undefined") {
 this._responseHeadersText = "HTTP/1.1 " + this.statusCode + " " + this.statusText + "\r\n";
-for (var i = 0; i < this.requestHeaders; ++i)
+for (var i = 0; i < this.responseHeaders.length; ++i)
 this._responseHeadersText += this.responseHeaders[i].name + ": " + this.responseHeaders[i].value + "\r\n";
 }
 return this._responseHeadersText;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128999] trunk

[commit-queue]

Title: [128999] trunk








Revision 128999
Author commit-qu...@webkit.org
Date 2012-09-19 07:08:21 -0700 (Wed, 19 Sep 2012)


Log Message
Do touch adjustment on GestureTapDown
https://bugs.webkit.org/show_bug.cgi?id=96677

Patch by Rick Byers  on 2012-09-19
Reviewed by Antonio Gomes.

Source/WebCore:

Do touch adjustment on GestureTapDown exactly as for GestureTap today.

Test: touchadjustment/touch-links-active.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::adjustGesturePosition):

Tools:

Allow radius to be set for GestureTapDown events.
* DumpRenderTree/chromium/TestRunner/EventSender.cpp:
(EventSender::gestureEvent):

LayoutTests:

Make a few tweaks to the touchadjustment.js infrastructure to make it
simpler and easier to use.  Add a test for touch-adjustment of
GestureTapDown events (based on touch-links-longpress).

* touchadjustment/resources/touchadjustment.js:
(touchPoint.return.left.x.radiusX.top.y.radiusY.width.radiusX.2.height.radiusY.2.get x):
(touchPoint.return.get y):
(touchPoint):
(offsetTouchPoint):
* touchadjustment/touch-links-active-expected.txt: Added.
* touchadjustment/touch-links-active.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/touchadjustment/resources/touchadjustment.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp


Added Paths

trunk/LayoutTests/touchadjustment/touch-links-active-expected.txt
trunk/LayoutTests/touchadjustment/touch-links-active.html




Diff

Modified: trunk/LayoutTests/ChangeLog (128998 => 128999)

--- trunk/LayoutTests/ChangeLog	2012-09-19 14:04:58 UTC (rev 128998)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 14:08:21 UTC (rev 128999)
@@ -1,3 +1,22 @@
+2012-09-19  Rick Byers  
+
+Do touch adjustment on GestureTapDown
+https://bugs.webkit.org/show_bug.cgi?id=96677
+
+Reviewed by Antonio Gomes.
+
+Make a few tweaks to the touchadjustment.js infrastructure to make it
+simpler and easier to use.  Add a test for touch-adjustment of
+GestureTapDown events (based on touch-links-longpress).
+
+* touchadjustment/resources/touchadjustment.js:
+(touchPoint.return.left.x.radiusX.top.y.radiusY.width.radiusX.2.height.radiusY.2.get x):
+(touchPoint.return.get y):
+(touchPoint):
+(offsetTouchPoint):
+* touchadjustment/touch-links-active-expected.txt: Added.
+* touchadjustment/touch-links-active.html: Added.
+
 2012-09-19  Christophe Dumez  
 
 [EFL] Skip fast/dom/message-port-deleted-by-accessor.html


Modified: trunk/LayoutTests/platform/qt/Skipped (128998 => 128999)

--- trunk/LayoutTests/platform/qt/Skipped	2012-09-19 14:04:58 UTC (rev 128998)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-09-19 14:08:21 UTC (rev 128999)
@@ -425,6 +425,10 @@
 # https://bugs.webkit.org/show_bug.cgi?id=87088
 fast/js/names.html
 
+# Don't have GestureLongPress, GestureTapCancel event types
+touchadjustment/touch-links-longpress.html
+touchadjustment/touch-links-active.html
+
 # === #
 #   Feature not yet supported.#
 # === #
@@ -2738,9 +2742,6 @@
 # ENABLE(WIDGET_REGION) is disabled
 fast/css/widget-region-parser.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=92914
-touchadjustment/touch-links-longpress.html
-
 # [Qt][GTK] REGRESSION(r125251): It made svg/custom/use-instanceRoot-as-event-target.xhtml assert and flakey
 # https://bugs.webkit.org/show_bug.cgi?id=93812
 svg/custom/use-instanceRoot-as-event-target.xhtml


Modified: trunk/LayoutTests/touchadjustment/resources/touchadjustment.js (128998 => 128999)

--- trunk/LayoutTests/touchadjustment/resources/touchadjustment.js	2012-09-19 14:04:58 UTC (rev 128998)
+++ trunk/LayoutTests/touchadjustment/resources/touchadjustment.js	2012-09-19 14:08:21 UTC (rev 128999)
@@ -96,12 +96,15 @@
 {
 if (!radiusY)
 radiusY = radiusX;
-var touchpoint = new Object();
-touchpoint.left = x - radiusX;
-touchpoint.top = y - radiusY;
-touchpoint.width = radiusX * 2;
-touchpoint.height = radiusY * 2;
-return touchpoint;
+
+return {
+left: x - radiusX,
+top: y - radiusY,
+width: radiusX * 2,
+height: radiusY * 2,
+get x() { return this.left + this.width/2; },
+get y() { return this.top + this.height/2; }
+};
 }
 
 function offsetTouchPoint(bounds, relativePosition, touchOffset, touchRadiusX, touchRadiusY)
@@ -109,9 +112,10 @@
 if (!touchRadiusY)
 touchRadiusY = touchRadiusX;
 
-var touchpoint = {left : bounds.left, top: bounds.top };
+// Start with the center of the touch at the top-left of the bounds.
+var touchpoi

[webkit-changes] [129002] trunk/LayoutTests

[jochen]

Title: [129002] trunk/LayoutTests








Revision 129002
Author joc...@chromium.org
Date 2012-09-19 07:12:37 -0700 (Wed, 19 Sep 2012)


Log Message
[chromium] Update test expectation for indexeddb test that is currently only run using content_browsertests

Unreviewed gardening.

* storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (129001 => 129002)

--- trunk/LayoutTests/ChangeLog	2012-09-19 14:11:48 UTC (rev 129001)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 14:12:37 UTC (rev 129002)
@@ -1,3 +1,11 @@
+2012-09-19  Jochen Eisinger  
+
+[chromium] Update test expectation for indexeddb test that is currently only run using content_browsertests
+
+Unreviewed gardening.
+
+* storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt:
+
 2012-09-19  Rick Byers  
 
 Do touch adjustment on GestureTapDown


Modified: trunk/LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt (129001 => 129002)

--- trunk/LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt	2012-09-19 14:11:48 UTC (rev 129001)
+++ trunk/LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt	2012-09-19 14:12:37 UTC (rev 129002)
@@ -39,3 +39,4 @@
 PASS successfullyParsed is true
 
 TEST COMPLETE
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129001] trunk/Source/WebCore

[commit-queue]

Title: [129001] trunk/Source/WebCore








Revision 129001
Author commit-qu...@webkit.org
Date 2012-09-19 07:11:48 -0700 (Wed, 19 Sep 2012)


Log Message
[BlackBerry] remove static_cast which will cause video crash
https://bugs.webkit.org/show_bug.cgi?id=97070

Patch by Jonathan Dong  on 2012-09-19
Reviewed by Antonio Gomes.

Removed the static_cast to avoid layering violation which
will cause a runtime crash.
We won't create a real MediaPlayerPrivate object before we call
MediaPlayer::load(), so if we use player()->implementation()
before calling load() in some cases, it points to a
NullMediaPlayerPrivate object. Here we should not use static_cast,
instead we should use HTMLMediaElement::percentLoaded() to
avoid layering violation as we don't have the buffering bug which
the deleted comment refers to.

Internally reviewed by Max Feil.

Test case: media/video-size.html

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129000 => 129001)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 14:09:03 UTC (rev 129000)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 14:11:48 UTC (rev 129001)
@@ -1,3 +1,27 @@
+2012-09-19  Jonathan Dong  
+
+[BlackBerry] remove static_cast which will cause video crash
+https://bugs.webkit.org/show_bug.cgi?id=97070
+
+Reviewed by Antonio Gomes.
+
+Removed the static_cast to avoid layering violation which
+will cause a runtime crash.
+We won't create a real MediaPlayerPrivate object before we call
+MediaPlayer::load(), so if we use player()->implementation()
+before calling load() in some cases, it points to a
+NullMediaPlayerPrivate object. Here we should not use static_cast,
+instead we should use HTMLMediaElement::percentLoaded() to
+avoid layering violation as we don't have the buffering bug which
+the deleted comment refers to.
+
+Internally reviewed by Max Feil.
+
+Test case: media/video-size.html
+
+* platform/blackberry/RenderThemeBlackBerry.cpp:
+(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
+
 2012-09-19  Rick Byers  
 
 Do touch adjustment on GestureTapDown


Modified: trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp (129000 => 129001)

--- trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp	2012-09-19 14:09:03 UTC (rev 129000)
+++ trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp	2012-09-19 14:11:48 UTC (rev 129001)
@@ -921,12 +921,7 @@
 return false;
 
 float fullScreenMultiplier = determineFullScreenMultiplier(mediaElement);
-float loaded = 0;
-// FIXME: replace loaded with commented out one when buffer bug is fixed (see comment in
-// MediaPlayerPrivateMMrenderer::percentLoaded).
-// loaded = mediaElement->percentLoaded();
-if (mediaElement->player() && mediaElement->player()->implementation())
-loaded = static_cast(mediaElement->player()->implementation())->percentLoaded();
+float loaded = mediaElement->percentLoaded();
 float position = mediaElement->duration() > 0 ? (mediaElement->currentTime() / mediaElement->duration()) : 0;
 
 int x = ceil(rect.x() + 2 * fullScreenMultiplier - fullScreenMultiplier / 2);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129000] trunk/Source/WebKit/gtk

[commit-queue]

Title: [129000] trunk/Source/WebKit/gtk








Revision 129000
Author commit-qu...@webkit.org
Date 2012-09-19 07:09:03 -0700 (Wed, 19 Sep 2012)


Log Message
[gtk] add enable-media-stream to websettings
https://bugs.webkit.org/show_bug.cgi?id=94361

Patch by Danilo Cesar Lemes de Paula  on 2012-09-19
Reviewed by Martin Robinson.

Applications should be allowed to enable/disable MediaStream on webkitwebsettings.

* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
* webkit/webkitwebsettingsprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp
trunk/Source/WebKit/gtk/webkit/webkitwebsettingsprivate.h
trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (128999 => 129000)

--- trunk/Source/WebKit/gtk/ChangeLog	2012-09-19 14:08:21 UTC (rev 128999)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-09-19 14:09:03 UTC (rev 129000)
@@ -1,3 +1,20 @@
+2012-09-19  Danilo Cesar Lemes de Paula  
+
+[gtk] add enable-media-stream to websettings
+https://bugs.webkit.org/show_bug.cgi?id=94361
+
+Reviewed by Martin Robinson.
+
+Applications should be allowed to enable/disable MediaStream on webkitwebsettings.
+
+* webkit/webkitwebsettings.cpp:
+(webkit_web_settings_class_init):
+(webkit_web_settings_set_property):
+(webkit_web_settings_get_property):
+* webkit/webkitwebsettingsprivate.h:
+* webkit/webkitwebview.cpp:
+(webkit_web_view_update_settings):
+
 2012-09-14  Zan Dobersek  
 
 [GTK] Clear application cache between tests in DumpRenderTree


Modified: trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp (128999 => 129000)

--- trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp	2012-09-19 14:08:21 UTC (rev 128999)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp	2012-09-19 14:09:03 UTC (rev 129000)
@@ -114,6 +114,7 @@
 PROP_ENABLE_FULLSCREEN,
 PROP_ENABLE_DNS_PREFETCHING,
 PROP_ENABLE_WEBGL,
+PROP_ENABLE_MEDIA_STREAM,
 PROP_ENABLE_WEB_AUDIO,
 PROP_ENABLE_ACCELERATED_COMPOSITING,
 PROP_ENABLE_SMOOTH_SCROLLING,
@@ -889,6 +890,25 @@
  _("Whether WebKit prefetches domain names"),
  TRUE,
  flags));
+/**
+* WebKitWebSettings:enable-media-stream:
+*
+* Enable or disable support for Media Stream on pages. Media Stream is
+* an experimental proposal for allowing web pages to access local video and
+* audio input devices.  The standard is currently a work-in-progress as part
+* of the Web Applications 1.0 specification from WHATWG.
+*
+* See also http://www.w3.org/TR/mediacapture-streams/
+*
+* Since: 1.10.0
+*/
+g_object_class_install_property(gobject_class,
+PROP_ENABLE_MEDIA_STREAM,
+g_param_spec_boolean("enable-media-stream",
+ _("Enable Media Stream"),
+ _("Whether Media Stream should be enabled"),
+ FALSE,
+ flags));
 
 /**
 * WebKitWebSettings:enable-smooth-scrolling
@@ -1130,6 +1150,9 @@
 case PROP_ENABLE_WEBGL:
 priv->enableWebgl = g_value_get_boolean(value);
 break;
+case PROP_ENABLE_MEDIA_STREAM:
+priv->enableMediaStream = g_value_get_boolean(value);
+break;
 case PROP_ENABLE_WEB_AUDIO:
 priv->enableWebAudio = g_value_get_boolean(value);
 break;
@@ -1307,6 +1330,9 @@
 case PROP_ENABLE_WEBGL:
 g_value_set_boolean(value, priv->enableWebgl);
 break;
+case PROP_ENABLE_MEDIA_STREAM:
+g_value_set_boolean(value, priv->enableMediaStream);
+break;
 case PROP_ENABLE_WEB_AUDIO:
 g_value_set_boolean(value, priv->enableWebAudio);
 break;


Modified: trunk/Source/WebKit/gtk/webkit/webkitwebsettingsprivate.h (128999 => 129000)

--- trunk/Source/WebKit/gtk/webkit/webkitwebsettingsprivate.h	2012-09-19 14:08:21 UTC (rev 128999)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebsettingsprivate.h	2012-09-19 14:09:03 UTC (rev 129000)
@@ -78,6 +78,7 @@
 gboolean enableFullscreen;
 gboolean enableDNSPrefetching;
 gboolean enableWebgl;
+gboolean enableMediaStream;
 gboolean enableWebAudio;
 gboolean enableAcceleratedCompositing;
 gboolean enableSmoothScrolling;


Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (128999 => 129000)

--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp	2012-09-19 14:0

[webkit-changes] [128998] trunk/LayoutTests

[commit-queue]

Title: [128998] trunk/LayoutTests








Revision 128998
Author commit-qu...@webkit.org
Date 2012-09-19 07:04:58 -0700 (Wed, 19 Sep 2012)


Log Message
[EFL] Skip fast/dom/message-port-deleted-by-accessor.html
https://bugs.webkit.org/show_bug.cgi?id=97105

Unreviewed EFL gardening.

Add fast/dom/message-port-deleted-by-accessor.html to
TestExpectations because it sometimes crashes on debug
build bots after r128802.

Patch by Christophe Dumez  on 2012-09-19

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128997 => 128998)

--- trunk/LayoutTests/ChangeLog	2012-09-19 14:03:52 UTC (rev 128997)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 14:04:58 UTC (rev 128998)
@@ -1,5 +1,18 @@
 2012-09-19  Christophe Dumez  
 
+[EFL] Skip fast/dom/message-port-deleted-by-accessor.html
+https://bugs.webkit.org/show_bug.cgi?id=97105
+
+Unreviewed EFL gardening.
+
+Add fast/dom/message-port-deleted-by-accessor.html to
+TestExpectations because it sometimes crashes on debug
+build bots after r128802.
+
+* platform/efl/TestExpectations:
+
+2012-09-19  Christophe Dumez  
+
 [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
 https://bugs.webkit.org/show_bug.cgi?id=97100
 


Modified: trunk/LayoutTests/platform/efl/TestExpectations (128997 => 128998)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-09-19 14:03:52 UTC (rev 128997)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-09-19 14:04:58 UTC (rev 128998)
@@ -174,7 +174,8 @@
 // CRASHES
 //
 
-// REGRESSION(r128802): It made some JS tests crash 
+// REGRESSION(r128802): It made some JS tests crash
+BUGWK97001 DEBUG : fast/dom/message-port-deleted-by-accessor.html = CRASH PASS
 BUGWK97001 DEBUG : fast/js/Object-defineProperty.html = CRASH
 BUGWK97001 DEBUG : fast/js/array-bad-time.html = CRASH
 BUGWK97001 DEBUG : fast/js/array-slow-put.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128997] trunk/Source/WebCore

[vsevik]

Title: [128997] trunk/Source/WebCore








Revision 128997
Author vse...@chromium.org
Date 2012-09-19 07:03:52 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed another follow up Apple Win build fix for r128992.

* inspector/InspectorAllInOne.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorAllInOne.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128996 => 128997)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 14:00:50 UTC (rev 128996)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 14:03:52 UTC (rev 128997)
@@ -1,3 +1,9 @@
+2012-09-19  Vsevolod Vlasov  
+
+Unreviewed another follow up Apple Win build fix for r128992.
+
+* inspector/InspectorAllInOne.cpp:
+
 2012-09-19  Carlos Garcia Campos  
 
 [GTK] REGRESSION(r128907): it broke several WebKit2 API tests


Modified: trunk/Source/WebCore/inspector/InspectorAllInOne.cpp (128996 => 128997)

--- trunk/Source/WebCore/inspector/InspectorAllInOne.cpp	2012-09-19 14:00:50 UTC (rev 128996)
+++ trunk/Source/WebCore/inspector/InspectorAllInOne.cpp	2012-09-19 14:03:52 UTC (rev 128997)
@@ -32,8 +32,10 @@
 #include "IdentifiersFactory.cpp"
 #include "InjectedScript.cpp"
 #include "InjectedScriptBase.cpp"
+#include "InjectedScriptCanvasModule.cpp"
 #include "InjectedScriptHost.cpp"
 #include "InjectedScriptManager.cpp"
+#include "InjectedScriptModule.cpp"
 #include "InspectorAgent.cpp"
 #include "InspectorApplicationCacheAgent.cpp"
 #include "InspectorBaseAgent.cpp"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128996] trunk/Source/WebCore

[carlosgc]

Title: [128996] trunk/Source/WebCore








Revision 128996
Author carlo...@webkit.org
Date 2012-09-19 07:00:50 -0700 (Wed, 19 Sep 2012)


Log Message
[GTK] REGRESSION(r128907): it broke several WebKit2 API tests
https://bugs.webkit.org/show_bug.cgi?id=97092

Reviewed by Martin Robinson.

Calling resizeLater() from the constructor of
RedirectedXCompositeWindow can cause the callback to be called
later by the main loop after the RedirectedXCompositeWindow object
has been destroyed. Instead of calling resizeLater(), initialize
the usable size to the given initial size.

* platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128995 => 128996)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 13:53:47 UTC (rev 128995)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 14:00:50 UTC (rev 128996)
@@ -1,3 +1,19 @@
+2012-09-19  Carlos Garcia Campos  
+
+[GTK] REGRESSION(r128907): it broke several WebKit2 API tests
+https://bugs.webkit.org/show_bug.cgi?id=97092
+
+Reviewed by Martin Robinson.
+
+Calling resizeLater() from the constructor of
+RedirectedXCompositeWindow can cause the callback to be called
+later by the main loop after the RedirectedXCompositeWindow object
+has been destroyed. Instead of calling resizeLater(), initialize
+the usable size to the given initial size.
+
+* platform/gtk/RedirectedXCompositeWindow.cpp:
+(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
+
 2012-09-19  Vsevolod Vlasov  
 
 Unreviewed follow up Apple Win build fix for r128992.


Modified: trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp (128995 => 128996)

--- trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp	2012-09-19 13:53:47 UTC (rev 128995)
+++ trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp	2012-09-19 14:00:50 UTC (rev 128996)
@@ -44,7 +44,8 @@
 }
 
 RedirectedXCompositeWindow::RedirectedXCompositeWindow(const IntSize& size)
-: m_window(0)
+: m_usableSize(size)
+, m_window(0)
 , m_parentWindow(0)
 , m_pixmap(0)
 , m_surface(0)
@@ -91,7 +92,6 @@
 XCompositeRedirectWindow(display, m_window, CompositeRedirectManual);
 
 resize(size);
-resizeLater(); // Force update of the usable area.
 }
 
 RedirectedXCompositeWindow::~RedirectedXCompositeWindow()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128995] trunk/Source/WebKit/efl

[commit-queue]

Title: [128995] trunk/Source/WebKit/efl








Revision 128995
Author commit-qu...@webkit.org
Date 2012-09-19 06:53:47 -0700 (Wed, 19 Sep 2012)


Log Message
[EFL][UT] Refactoring an implementation of testing framework for wk1.
https://bugs.webkit.org/show_bug.cgi?id=94925

Patch by Krzysztof Czech  on 2012-09-19
Reviewed by Gyuyoung Kim.

The reason of changing, was to adjust current implementation to use gtest features
related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods
and lastly to make framework easier to use.

* tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::EWKTestBase): Added to initialize test view.
(EWKUnitTests::EWKTestBase::webView): Returns current webview.
(EWKUnitTests::EWKTestBase::SetUp):
Before test is started, SetUp is called.
Used this to initialize efl and test view.
(EWKUnitTests::EWKTestBase::TearDown):
TearDown is called as soon as test is completed.
Used this to properly shutdown efl and clean test view.
(EWKUnitTests::EWKTestBase::onLoadFinished):
(EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded.
(EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page.
* tests/UnitTestUtils/EWKTestBase.h:
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init): Initialize test view.
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):
* tests/test_ewk_view.cpp:
(TEST_F):
* tests/test_runner.cpp:
(main):

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.h
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h
trunk/Source/WebKit/efl/tests/test_ewk_view.cpp
trunk/Source/WebKit/efl/tests/test_runner.cpp




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (128994 => 128995)

--- trunk/Source/WebKit/efl/ChangeLog	2012-09-19 13:50:11 UTC (rev 128994)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-09-19 13:53:47 UTC (rev 128995)
@@ -1,3 +1,37 @@
+2012-09-19  Krzysztof Czech  
+
+[EFL][UT] Refactoring an implementation of testing framework for wk1.
+https://bugs.webkit.org/show_bug.cgi?id=94925
+
+Reviewed by Gyuyoung Kim.
+
+The reason of changing, was to adjust current implementation to use gtest features
+related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods
+and lastly to make framework easier to use.
+
+* tests/UnitTestUtils/EWKTestBase.cpp:
+(EWKUnitTests::EWKTestBase::EWKTestBase): Added to initialize test view.
+(EWKUnitTests::EWKTestBase::webView): Returns current webview.
+(EWKUnitTests::EWKTestBase::SetUp):
+Before test is started, SetUp is called.
+Used this to initialize efl and test view.
+(EWKUnitTests::EWKTestBase::TearDown):
+TearDown is called as soon as test is completed.
+Used this to properly shutdown efl and clean test view.
+(EWKUnitTests::EWKTestBase::onLoadFinished):
+(EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded.
+(EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page.
+* tests/UnitTestUtils/EWKTestBase.h:
+* tests/UnitTestUtils/EWKTestView.cpp:
+(EWKUnitTests::EWKTestView::EWKTestView):
+(EWKUnitTests::EWKTestView::init): Initialize test view.
+* tests/UnitTestUtils/EWKTestView.h:
+(EWKTestView):
+* tests/test_ewk_view.cpp:
+(TEST_F):
+* tests/test_runner.cpp:
+(main):
+
 2012-09-19  Christophe Dumez  
 
 [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference


Modified: trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp (128994 => 128995)

--- trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp	2012-09-19 13:50:11 UTC (rev 128994)
+++ trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp	2012-09-19 13:53:47 UTC (rev 128995)
@@ -19,10 +19,7 @@
 #include "config.h"
 #include "EWKTestBase.h"
 
-#include "EWKTestConfig.h"
-#include "EWKTestView.h"
 #include 
-
 #include 
 #include 
 
@@ -30,73 +27,52 @@
 
 namespace EWKUnitTests {
 
-bool EWKTestBase::init()
+EWKTestBase::EWKTestBase()
+: m_ewkTestView(0)
 {
-if (!ecore_evas_init())
-return false;
+}
 
-if (!edje_init()) {
-ecore_evas_shutdown();
-return false;
-}
-
-int ret = ewk_init();
-const char* proxyUri = getenv("http_proxy");
-
-if (ret && proxyUri)
-ewk_network_proxy_uri_set(proxyUri);
-
-return ret;
+Evas_Object* EWKTestBase::webView()
+{
+return m_ewkTestView->webView();
 }
 
-void EWKTestBase::shutdownAll()
+void EWKTestBase::SetUp()
 {
-int count = 0;
+ASSERT_GT(ecore_evas_init(), 0);
+ASSERT_GT(ewk_init(), 0);
 
-while ((count = ecore_ev

[webkit-changes] [128994] trunk/Source/WebCore

[vsevik]

Title: [128994] trunk/Source/WebCore








Revision 128994
Author vse...@chromium.org
Date 2012-09-19 06:50:11 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed follow up Apple Win build fix for r128992.

* inspector/InspectorAllInOne.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorAllInOne.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128993 => 128994)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 13:32:12 UTC (rev 128993)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 13:50:11 UTC (rev 128994)
@@ -1,3 +1,9 @@
+2012-09-19  Vsevolod Vlasov  
+
+Unreviewed follow up Apple Win build fix for r128992.
+
+* inspector/InspectorAllInOne.cpp:
+
 2012-09-19  Andrey Adaikin  
 
 Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent


Modified: trunk/Source/WebCore/inspector/InspectorAllInOne.cpp (128993 => 128994)

--- trunk/Source/WebCore/inspector/InspectorAllInOne.cpp	2012-09-19 13:32:12 UTC (rev 128993)
+++ trunk/Source/WebCore/inspector/InspectorAllInOne.cpp	2012-09-19 13:50:11 UTC (rev 128994)
@@ -38,6 +38,7 @@
 #include "InspectorApplicationCacheAgent.cpp"
 #include "InspectorBaseAgent.cpp"
 #include "InspectorCSSAgent.cpp"
+#include "InspectorCanvasAgent.cpp"
 #include "InspectorClient.cpp"
 #include "InspectorConsoleAgent.cpp"
 #include "InspectorController.cpp"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128993] trunk

[commit-queue]

Title: [128993] trunk








Revision 128993
Author commit-qu...@webkit.org
Date 2012-09-19 06:32:12 -0700 (Wed, 19 Sep 2012)


Log Message
[EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
https://bugs.webkit.org/show_bug.cgi?id=97100

Patch by Christophe Dumez  on 2012-09-19
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Add DumpRenderTree support method to set the
'WebKitCSSRegionsEnabled' preference.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSRegionsEnabled):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
preference, in order to match WebKitTestRunner functionality.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::overridePreference):

LayoutTests:

Rebaseline and unskip several test cases now that EFL's DRT
supports overriding 'WebKitCSSRegionsEnabled' preference.

* platform/efl/Skipped:
* platform/efl/TestExpectations:
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/efl/fast/repaint/region-painting-invalidation-expected.png: Added.
* platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Added.
* platform/efl/fast/repaint/region-painting-via-layout-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png
trunk/LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt
trunk/LayoutTests/platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png
trunk/LayoutTests/platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt
trunk/LayoutTests/platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt
trunk/LayoutTests/platform/efl/fast/repaint/region-painting-via-layout-expected.txt
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
trunk/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp


Added Paths

trunk/LayoutTests/platform/efl/fast/repaint/region-painting-invalidation-expected.png
trunk/LayoutTests/platform/efl/fast/repaint/region-painting-invalidation-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (128992 => 128993)

--- trunk/LayoutTests/ChangeLog	2012-09-19 13:07:15 UTC (rev 128992)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 13:32:12 UTC (rev 128993)
@@ -1,3 +1,24 @@
+2012-09-19  Christophe Dumez  
+
+[EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
+https://bugs.webkit.org/show_bug.cgi?id=97100
+
+Reviewed by Gyuyoung Kim.
+
+Rebaseline and unskip several test cases now that EFL's DRT
+supports overriding 'WebKitCSSRegionsEnabled' preference.
+
+* platform/efl/Skipped:
+* platform/efl/TestExpectations:
+* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
+* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
+* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
+* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
+* platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
+* platform/efl/fast/repaint/region-painting-invalidation-expected.png: Added.
+* platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Added.
+* platform/efl/fast/repaint/region-painting-via-layout-expected.txt:
+
 2012-09-19  Andrey Adaikin  
 
 Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent


Modified: trunk/LayoutTests/platform/efl/Skipped (128992 => 128993)

--- trunk/LayoutTests/platform/efl/Skipped	2012-09-19 13:07:15 UTC (rev 128992)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-09-19 13:32:12 UTC (rev 128993)
@@ -433,9 +433,6 @@
 fast/inline/continuation-outlines-with-layers.html
 fast/invalid/residual-style.html
 fast/js/constructor-length.html
-fast/repaint/japanese-rl-selection-repaint-in-regions.html
-fast/repaint/overflow-flipped-writing-mode-block-in-regions.html
-fast/repaint/region-painting-via-layout.html
 fast/table/prepend-in-anonymous-table.html
 fast/text/basic/011.html
 fast/text/basic/013.htm

[webkit-changes] [128987] trunk/Source/WebCore

[hausmann]

Title: [128987] trunk/Source/WebCore








Revision 128987
Author hausm...@webkit.org
Date 2012-09-19 04:12:40 -0700 (Wed, 19 Sep 2012)


Log Message
[Qt] Link failure with bfd linker on --minimal build
https://bugs.webkit.org/show_bug.cgi?id=97075

Reviewed by Tor Arne Vestbø.

Fix two dependency errors triggered by --minimal:

- GStreamerVersioning.cpp uses functions from libgstvideo (gst_video_format_parse_caps), so we need to pull
that module not only when video is enabled by generally when using gstreamer.
- GraphicsSurfaceGLX depends on Xlib (XOpenDisplay, etc.), so we need to do CONFIG += x11 to get that and not
implicitly rely on x11 netscape plugins being enabled.

* WebCore.pri:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (128986 => 128987)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 10:55:28 UTC (rev 128986)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 11:12:40 UTC (rev 128987)
@@ -1,3 +1,19 @@
+2012-09-19  Simon Hausmann  
+
+[Qt] Link failure with bfd linker on --minimal build
+https://bugs.webkit.org/show_bug.cgi?id=97075
+
+Reviewed by Tor Arne Vestbø.
+
+Fix two dependency errors triggered by --minimal:
+
+- GStreamerVersioning.cpp uses functions from libgstvideo (gst_video_format_parse_caps), so we need to pull
+that module not only when video is enabled by generally when using gstreamer.
+- GraphicsSurfaceGLX depends on Xlib (XOpenDisplay, etc.), so we need to do CONFIG += x11 to get that and not
+implicitly rely on x11 netscape plugins being enabled.
+
+* WebCore.pri:
+
 2012-09-19  Tommy Widenflycht  
 
 MediaStream API: Rename the RTCIceServer uri parameter to url.


Modified: trunk/Source/WebCore/WebCore.pri (128986 => 128987)

--- trunk/Source/WebCore/WebCore.pri	2012-09-19 10:55:28 UTC (rev 128986)
+++ trunk/Source/WebCore/WebCore.pri	2012-09-19 11:12:40 UTC (rev 128987)
@@ -130,7 +130,7 @@
 # Note: XP_MACOSX is defined in npapi.h
 } else {
 xlibAvailable() {
-CONFIG += x11
+CONFIG *= x11
 LIBS += -lXrender
 DEFINES += MOZ_X11
 }
@@ -167,7 +167,7 @@
 
 use?(GSTREAMER) {
 DEFINES += ENABLE_GLIB_SUPPORT=1
-PKGCONFIG += glib-2.0 gio-2.0 gstreamer-0.10 gstreamer-app-0.10 gstreamer-base-0.10 gstreamer-interfaces-0.10 gstreamer-pbutils-0.10 gstreamer-plugins-base-0.10
+PKGCONFIG += glib-2.0 gio-2.0 gstreamer-0.10 gstreamer-app-0.10 gstreamer-base-0.10 gstreamer-interfaces-0.10 gstreamer-pbutils-0.10 gstreamer-plugins-base-0.10 gstreamer-video-0.10
 }
 
 enable?(VIDEO) {
@@ -193,7 +193,6 @@
 }
 } else:use?(GSTREAMER) {
 INCLUDEPATH += $$SOURCE_DIR/platform/graphics/gstreamer
-PKGCONFIG += gstreamer-video-0.10
 } else:use?(QT_MULTIMEDIA) {
 CONFIG   *= mobility
 MOBILITY *= multimedia
@@ -212,9 +211,12 @@
 contains(QT_CONFIG, opengles2):!win32: LIBS += -lEGL
 }
 
-use?(graphics_surface) {
+use?(GRAPHICS_SURFACE) {
 mac: LIBS += -framework IOSurface -framework CoreFoundation
-linux-*: LIBS += -lXcomposite -lXrender
+linux-*: {
+LIBS += -lXcomposite -lXrender
+CONFIG *= x11
+}
 }
 
 !system-sqlite:exists( $${SQLITE3SRCDIR}/sqlite3.c ) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128986] trunk/LayoutTests

[sergio]

Title: [128986] trunk/LayoutTests








Revision 128986
Author ser...@webkit.org
Date 2012-09-19 03:55:28 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed GTK gardening.

Updated expectations for the WK2 GTK bot.

* platform/gtk-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128985 => 128986)

--- trunk/LayoutTests/ChangeLog	2012-09-19 10:52:59 UTC (rev 128985)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 10:55:28 UTC (rev 128986)
@@ -1,3 +1,11 @@
+2012-09-19  Sergio Villar Senin  
+
+Unreviewed GTK gardening.
+
+Updated expectations for the WK2 GTK bot.
+
+* platform/gtk-wk2/TestExpectations:
+
 2012-09-19  Christophe Dumez  
 
 [EFL] tables/mozilla tests need rebaseline (Part 3)


Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (128985 => 128986)

--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2012-09-19 10:52:59 UTC (rev 128985)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2012-09-19 10:55:28 UTC (rev 128986)
@@ -248,11 +248,6 @@
 // Crashing tests
 //
 
-// accessibility tests failing in WK1 but crashing in WK2
-BUGWKGTK : accessibility/aria-hidden-with-elements.html = CRASH
-BUGWKGTK : accessibility/inline-continuations.html = CRASH
-BUGWKGTK : accessibility/loading-iframe-sends-notification.html = CRASH
-
 BUGWKGTK : plugins/document-open.html = CRASH
 
 //
@@ -272,6 +267,8 @@
 BUGWK72698 : media/audio-garbage-collect.html = TEXT PASS
 
 // Tests showing flakiness in the bot
+BUGWKGTK : editing/pasteboard/smart-paste-004.html = TEXT PASS
+BUGWKGTK : editing/selection/5057506.html = TEXT PASS
 BUGWKGTK : editing/selection/click-in-margins-inside-editable-div.html = TEXT PASS
 BUGWKGTK : fast/events/dispatch-message-string-data.html = TEXT PASS
 BUGWKGTK : fast/events/domactivate-sets-underlying-click-event-as-handled.html = TEXT PASS
@@ -305,11 +302,30 @@
 BUGWKGTK : fast/writing-mode/japanese-ruby-horizontal-bt.html = TEXT PASS
 BUGWKGTK : fast/writing-mode/japanese-ruby-vertical-lr.html = TEXT PASS
 BUGWKGTK : fast/writing-mode/japanese-ruby-vertical-rl.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/change-version-handle-reuse-worker.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/change-version-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/empty-statement-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/execute-sql-args-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/execute-sql-args-worker.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/multiple-transactions.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/multiple-transactions-on-different-handles.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/multiple-transactions-on-different-handles-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/open-database-empty-version-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/open-database-set-empty-version-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/open-database-while-transaction-in-progress.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/open-database-while-transaction-in-progress-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/read-and-write-transactions-dont-run-together.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/sql-data-types-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/test-authorizer.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/test-authorizer-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/transaction-in-transaction-sync.html = TEXT PASS
+BUGWKGTK : http/tests/security/cross-origin-plugin-allowed.html = TEXT PASS
 BUGWKGTK : http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html = TEXT PASS
 BUGWKGTK : media/video-transformed.html = TEXT PASS
 BUGWKGTK : media/W3C/audio/networkState/networkState_during_loadstart.html = TEXT PASS
 BUGWKGTK : svg/custom/gradient-attr-update.svg = TEXT PASS
 BUGWKGTK : svg/custom/pointer-events-on-svg-with-pointer.xhtml = TEXT PASS
+BUGWKGTK : svg/custom/pointer-events-on-svg-without-pointer.xhtml = TEXT PASS
 BUGWKGTK : svg/stroke/non-scaling-stroke-pattern.svg = IMAGE PASS
 
 //
@@ -425,6 +441,7 @@
 BUGWKGTK : accessibility/ignore-spacer-elements.html = TEXT
 BUGWKGTK : accessibility/img-fallsback-to-title.html = TEXT
 BUGWKGTK : accessibility/inline-continuations.html = TEXT
+BUGWKGTK : accessibility/legend.html = TEXT
 BUGWKGTK : accessibility/loading-iframe-sends-notification.html = TEXT
 BUGWKGTK : accessibility/media-element.html = TEXT
 BUGWKGTK : editing/deleting/delete-ligature-003.html = TEXT
@@ -460,7 +477,7 @@
 BUGWKGTK : fast/forms/mailto/formenctype-attribute-button-html.htm

[webkit-changes] [128982] trunk

[tommyw]

Title: [128982] trunk








Revision 128982
Author tom...@google.com
Date 2012-09-19 02:43:27 -0700 (Wed, 19 Sep 2012)


Log Message
MediaStream API: Rename the RTCIceServer uri parameter to url.
https://bugs.webkit.org/show_bug.cgi?id=97086

Reviewed by Hajime Morita.

Source/WebCore:

Either the standard has changed or I can't read.
http://dev.w3.org/2011/webrtc/editor/webrtc.html#dictionary-rtciceserver-members

Existing tests changed to cover this patch.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::parseConfiguration):

LayoutTests:

* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/RTCPeerConnection.html:
* fast/mediastream/constructors-expected.txt:
* fast/mediastream/constructors.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html
trunk/LayoutTests/fast/mediastream/constructors-expected.txt
trunk/LayoutTests/fast/mediastream/constructors.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (128981 => 128982)

--- trunk/LayoutTests/ChangeLog	2012-09-19 09:39:17 UTC (rev 128981)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 09:43:27 UTC (rev 128982)
@@ -1,3 +1,15 @@
+2012-09-19  Tommy Widenflycht  
+
+MediaStream API: Rename the RTCIceServer uri parameter to url.
+https://bugs.webkit.org/show_bug.cgi?id=97086
+
+Reviewed by Hajime Morita.
+
+* fast/mediastream/RTCPeerConnection-expected.txt:
+* fast/mediastream/RTCPeerConnection.html:
+* fast/mediastream/constructors-expected.txt:
+* fast/mediastream/constructors.html:
+
 2012-09-19  Balazs Ankes  
 
 [Qt] REGRESSION(r128910): inspector/extensions/extensions-panel.html fails


Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt (128981 => 128982)

--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt	2012-09-19 09:39:17 UTC (rev 128981)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt	2012-09-19 09:43:27 UTC (rev 128982)
@@ -11,9 +11,9 @@
 PASS new webkitRTCPeerConnection(''); threw exception TypeError: Not an object..
 PASS new webkitRTCPeerConnection(null, ''); threw exception TypeError: Not an object..
 PASS new webkitRTCPeerConnection({iceServers:[]}, null); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{uri:'stun:foo.com'}]}, null); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{uri:'turn:foo.com', credential:'x'}]}, null); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{uri:'turn:foo.com', credential:'x'},{uri:'stun:bar.com'}]}, null); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}, null); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'}]}, null); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]}, null); did not throw exception.
 PASS new webkitRTCPeerConnection({fooServers:[]}, null); threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
 PASS new webkitRTCPeerConnection({iceServers:true}, null); threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
 PASS new webkitRTCPeerConnection({iceServers:[1, 2, 3]}, null); threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.


Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html (128981 => 128982)

--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html	2012-09-19 09:39:17 UTC (rev 128981)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html	2012-09-19 09:43:27 UTC (rev 128982)
@@ -16,9 +16,9 @@
 shouldThrow("new webkitRTCPeerConnection(null, '');");
 
 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]}, null);");
-shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{uri:'stun:foo.com'}]}, null);");
-shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{uri:'turn:foo.com', credential:'x'}]}, null);");
-shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{uri:'turn:foo.com', credential:'x'},{uri:'stun:bar.com'}]}, null);");
+shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}, null);");
+shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'}]}, null);");
+shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]}, null);");
 shouldThrow("new webkitRTCPeerConnection({fooServers:[]}, null);");
 shouldThrow("new webkitRTCPeerConnection({iceServers:true}, null);");
 shouldThrow("new webkitRTCPeerConnection({iceServers:[1, 2, 3]}, null);");


Modified: trunk/LayoutTests/fast/mediastream/constructors-expected.txt (128981 => 128982)

--- trunk/LayoutTests/fast/mediastream/c

[webkit-changes] [128981] trunk/LayoutTests

[rgabor]

Title: [128981] trunk/LayoutTests








Revision 128981
Author rga...@webkit.org
Date 2012-09-19 02:39:17 -0700 (Wed, 19 Sep 2012)


Log Message
[Qt] REGRESSION(r128910): inspector/extensions/extensions-panel.html fails
https://bugs.webkit.org/show_bug.cgi?id=97084

Unreviewed gardeing.

Patch by Balazs Ankes  on 2012-09-19

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (128980 => 128981)

--- trunk/LayoutTests/ChangeLog	2012-09-19 09:10:33 UTC (rev 128980)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 09:39:17 UTC (rev 128981)
@@ -1,3 +1,12 @@
+2012-09-19  Balazs Ankes  
+
+[Qt] REGRESSION(r128910): inspector/extensions/extensions-panel.html fails
+https://bugs.webkit.org/show_bug.cgi?id=97084
+
+Unreviewed gardeing.
+
+* platform/qt/Skipped:
+
 2012-09-19  Sheriff Bot  
 
 Unreviewed, rolling out r128976.


Modified: trunk/LayoutTests/platform/qt/Skipped (128980 => 128981)

--- trunk/LayoutTests/platform/qt/Skipped	2012-09-19 09:10:33 UTC (rev 128980)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-09-19 09:39:17 UTC (rev 128981)
@@ -2803,3 +2803,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=96931
 http/tests/inspector/network/network-xhr-replay.html
 
+# [Qt] REGRESSION(r128910): inspector/extensions/extensions-panel.html fails
+# https://bugs.webkit.org/show_bug.cgi?id=97084
+inspector/extensions/extensions-panel.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128980] trunk/Source/WebKit2

[kbalazs]

Title: [128980] trunk/Source/WebKit2








Revision 128980
Author kbal...@webkit.org
Date 2012-09-19 02:10:33 -0700 (Wed, 19 Sep 2012)


Log Message
[Texmap] Potential crash in TextureMapperLayer because of referencing deleted mask/replica layer
https://bugs.webkit.org/show_bug.cgi?id=96919

Reviewed by Noam Rosenthal.

Delay syncing deleted layers until flushPendingLayerChanges so the UI side state
will contain all changes related to the deletion of a layer. This saves us from
referencing a deleted layer.

* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::detachLayer):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (128979 => 128980)

--- trunk/Source/WebKit2/ChangeLog	2012-09-19 08:50:01 UTC (rev 128979)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-19 09:10:33 UTC (rev 128980)
@@ -1,3 +1,20 @@
+2012-09-19  Balazs Kelemen  
+
+[Texmap] Potential crash in TextureMapperLayer because of referencing deleted mask/replica layer
+https://bugs.webkit.org/show_bug.cgi?id=96919
+
+Reviewed by Noam Rosenthal.
+
+Delay syncing deleted layers until flushPendingLayerChanges so the UI side state
+will contain all changes related to the deletion of a layer. This saves us from
+referencing a deleted layer.
+
+* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
+(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
+(WebKit::LayerTreeCoordinator::detachLayer):
+* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
+(LayerTreeCoordinator):
+
 2012-09-19  Byungwoo Lee  
 
 [EFL][WK2] waitUntilTitleChangedTo() and waitUntilLoadFinished() needs timeout.


Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp (128979 => 128980)

--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp	2012-09-19 08:50:01 UTC (rev 128979)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp	2012-09-19 09:10:33 UTC (rev 128980)
@@ -255,6 +255,11 @@
 return false;
 
 m_shouldSyncFrame = false;
+
+for (size_t i = 0; i < m_detachedLayers.size(); ++i)
+m_webPage->send(Messages::LayerTreeCoordinatorProxy::DeleteCompositingLayer(m_detachedLayers[i]));
+m_detachedLayers.clear();
+
 bool didSync = m_webPage->corePage()->mainFrame()->view()->syncCompositingStateIncludingSubframes();
 m_nonCompositedContentLayer->syncCompositingStateForThisLayerOnly();
 if (m_pageOverlayLayer)
@@ -326,7 +331,8 @@
 {
 m_registeredLayers.remove(layer);
 m_shouldSyncFrame = true;
-m_webPage->send(Messages::LayerTreeCoordinatorProxy::DeleteCompositingLayer(layer->id()));
+m_detachedLayers.append(layer->id());
+scheduleLayerFlush();
 }
 
 static void updateOffsetFromViewportForSelf(RenderLayer* renderLayer)


Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h (128979 => 128980)

--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h	2012-09-19 08:50:01 UTC (rev 128979)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h	2012-09-19 09:10:33 UTC (rev 128980)
@@ -127,6 +127,7 @@
 OwnPtr m_pageOverlayLayer;
 
 HashSet m_registeredLayers;
+Vector m_detachedLayers;
 HashMap m_directlyCompositedImageRefCounts;
 Vector > m_updateAtlases;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128978] trunk/Source/WebCore

[commit-queue]

Title: [128978] trunk/Source/WebCore








Revision 128978
Author commit-qu...@webkit.org
Date 2012-09-19 01:43:33 -0700 (Wed, 19 Sep 2012)


Log Message
[Qt][Win] Fix rendering of flash content when scrolling
https://bugs.webkit.org/show_bug.cgi?id=92905

Patch by Simon Hausmann  on 2012-09-19
Reviewed by Jocelyn Turcotte.

Fix rendering offset similar to r121441.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paint):
(WebCore::PluginView::setNPWindowRect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/win/PluginViewWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128977 => 128978)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 08:30:50 UTC (rev 128977)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 08:43:33 UTC (rev 128978)
@@ -1,3 +1,16 @@
+2012-09-19  Simon Hausmann  
+
+[Qt][Win] Fix rendering of flash content when scrolling
+https://bugs.webkit.org/show_bug.cgi?id=92905
+
+Reviewed by Jocelyn Turcotte.
+
+Fix rendering offset similar to r121441.
+
+* plugins/win/PluginViewWin.cpp:
+(WebCore::PluginView::paint):
+(WebCore::PluginView::setNPWindowRect):
+
 2012-09-19  Andrey Adaikin  
 
 Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent


Modified: trunk/Source/WebCore/plugins/win/PluginViewWin.cpp (128977 => 128978)

--- trunk/Source/WebCore/plugins/win/PluginViewWin.cpp	2012-09-19 08:30:50 UTC (rev 128977)
+++ trunk/Source/WebCore/plugins/win/PluginViewWin.cpp	2012-09-19 08:43:33 UTC (rev 128978)
@@ -640,9 +640,9 @@
 
 ASSERT(parent()->isFrameView());
 
-// In the GTK port we draw in an offscreen buffer and don't want to use the window
+// In the GTK and Qt ports we draw in an offscreen buffer and don't want to use the window
 // coordinates.
-#if PLATFORM(GTK)
+#if PLATFORM(GTK) || PLATFORM(QT)
 IntRect rectInWindow(rect);
 rectInWindow.intersect(frameRect());
 #else
@@ -831,9 +831,9 @@
 m_npWindow.clipRect.right = r.width();
 m_npWindow.clipRect.bottom = r.height();
 #else
-// In the GTK port we draw in an offscreen buffer and don't want to use the window
+// In the GTK and Qt ports we draw in an offscreen buffer and don't want to use the window
 // coordinates.
-# if PLATFORM(GTK)
+# if PLATFORM(GTK) || PLATFORM(QT)
 IntPoint p = rect.location();
 # else
 IntPoint p = static_cast(parent())->contentsToWindow(rect.location());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128977] trunk/LayoutTests

[sergio]

Title: [128977] trunk/LayoutTests








Revision 128977
Author ser...@webkit.org
Date 2012-09-19 01:30:50 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed GTK gardening.

Updated the recently added TestExpectations file for WK2 with the
actual failures from the bot.

* platform/gtk-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128976 => 128977)

--- trunk/LayoutTests/ChangeLog	2012-09-19 08:08:22 UTC (rev 128976)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 08:30:50 UTC (rev 128977)
@@ -1,3 +1,12 @@
+2012-09-19  Sergio Villar Senin  
+
+Unreviewed GTK gardening.
+
+Updated the recently added TestExpectations file for WK2 with the
+actual failures from the bot.
+
+* platform/gtk-wk2/TestExpectations:
+
 2012-09-19  Andrey Adaikin  
 
 Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent


Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (128976 => 128977)

--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2012-09-19 08:08:22 UTC (rev 128976)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2012-09-19 08:30:50 UTC (rev 128977)
@@ -37,6 +37,7 @@
 // Tests that require new results.
 //
 
+BUGWKGTK SKIP : fast/regions/autoheight-regions-mark.html = TEXT
 BUGWKGTK SKIP : http/tests/security/resources/drag-drop-allowed.html = TEXT
 
 //
@@ -56,7 +57,6 @@
 BUGWK63706 : editing/pasteboard/drag-and-drop-image-contenteditable.html = TEXT TIMEOUT
 BUGWK63706 : editing/pasteboard/drag-and-drop-inputimage-contenteditable.html = TEXT TIMEOUT
 BUGWK63706 : editing/pasteboard/drag-and-drop-objectimage-contenteditable.html = TEXT TIMEOUT
-BUGWK63706 : editing/pasteboard/drag-drop-dead-frame.html = TEXT
 BUGWK63706 : editing/pasteboard/drag-drop-input-textarea.html = TEXT
 BUGWK63706 : editing/pasteboard/drag-drop-modifies-page.html = TEXT
 BUGWK63706 : editing/pasteboard/drag-drop-url-text.html = TEXT
@@ -76,7 +76,6 @@
 BUGWK63706 : editing/selection/drag-text-delay.html = TEXT
 BUGWK63706 : editing/undo/undo-smart-delete-word.html = TEXT
 BUGWK63706 : fast/block/float/float-in-float-hit-testing.html = TEXT
-BUGWK63706 : fast/events/autoscroll.html = TEXT
 BUGWK63706 : fast/events/bogus-dropEffect-effectAllowed.html = TEXT
 BUGWK63706 : fast/events/content-changed-during-drop.html = TEXT
 BUGWK63706 : fast/events/crash-on-mutate-during-drop.html = TEXT
@@ -96,24 +95,13 @@
 BUGWK63706 : fast/forms/drag-into-textarea.html = TEXT
 BUGWK63706 : fast/forms/drag-out-of-textarea.html = TEXT
 BUGWK63706 : fast/forms/file/input-file-write-files.html = TEXT TIMEOUT
-BUGWK63706 : fast/forms/input-readonly-autoscroll.html = TEXT
-BUGWK63706 : fast/forms/input-text-drag-down.html = TEXT
 BUGWK63706 : fast/forms/range/slider-delete-while-dragging-thumb.html = TEXT
-BUGWK63706 : fast/forms/select-listbox-multiple-no-focusring.html = TEXT
 BUGWK63706 : fast/lists/drag-into-marker.html = TEXT
-BUGWK63706 : fast/repaint/repaint-across-writing-mode-boundary.html = TEXT
-BUGWK63706 : fast/repaint/selection-rl.html = TEXT
-BUGWK63706 : fast/text/atsui-rtl-override-selection.html = TEXT
-BUGWK63706 : fast/writing-mode/horizontal-bt-replaced-selection.html = TEXT
-BUGWK63706 : fast/writing-mode/vertical-lr-replaced-selection.html = TEXT
-BUGWK63706 : fast/writing-mode/vertical-rl-replaced-selection.html = TEXT
 BUGWK63706 : http/tests/misc/bubble-drag-events.html = TEXT
 BUGWK63706 : http/tests/security/drag-over-remote-content-iframe.html = TEXT
 BUGWK63706 : plugins/mouse-events-fixedpos.html = TEXT
 BUGWK63706 : plugins/mouse-events.html = TEXT
-BUGWK63706 : svg/custom/mouse-move-on-svg-container-standalone.svg = TEXT
 BUGWK63706 : svg/custom/mouse-move-on-svg-container.xhtml = TEXT TIMEOUT
-BUGWK63706 : svg/custom/mouse-move-on-svg-root-standalone.svg = TEXT
 BUGWK63706 : svg/custom/mouse-move-on-svg-root.xhtml = TEXT TIMEOUT
 
 // WebKit2 needs layoutTestController.setSmartInsertDeleteEnabled
@@ -122,9 +110,6 @@
 BUGWKGTK : editing/selection/doubleclick-whitespace-crash.html = TEXT
 BUGWKGTK : editing/selection/doubleclick-whitespace-img-crash.html = TEXT
 
-// WebKit2 needs layoutTestController.setSpatialNavigationEnabled
-BUGWKGTK : fast/spatial-navigation/snav-multiple-select-focusring.html = TEXT
-
 // WebKit2 needs layoutTestController.addMockSpeechInputResult
 BUGWKGTK : fast/speech/input-onspeechchange-event.html = TEXT
 BUGWKGTK : fast/speech/input-ontextinput-event.html = TEXT
@@ -147,21 +132,12 @@
 // WebKit2 needs textInputController.selectedRange
 BUGWKGTK : editing/selection/mixed-editability-10.html = TEXT
 
-// WebKit2 needs layoutTestController.overridePreference
-// https://bugs.webkit.org/show_bug.cgi?id=42197
-BUGWKGTK : fast/repaint/no-caret-repaint

[webkit-changes] [128975] trunk/Source/WebKit2

[commit-queue]

Title: [128975] trunk/Source/WebKit2








Revision 128975
Author commit-qu...@webkit.org
Date 2012-09-19 01:04:40 -0700 (Wed, 19 Sep 2012)


Log Message
[EFL][WK2] waitUntilTitleChangedTo() and waitUntilLoadFinished() needs timeout.
https://bugs.webkit.org/show_bug.cgi?id=96910

Patch by Byungwoo Lee  on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.

Currently, the waitUntilTitleChangedTo() and waitUntilLoadFinished()
functions doesn't handle timeout by itself.
And if there are some failed cases that loading is not finished or
title is not changed to the expected string, test case just stopped
with timeout and there is no more information about this such as line
number.

To handle timeout status more properly, timeout parameter is added to
these functions.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::LoadFinishedData::LoadFinishedData):
(LoadFinishedData):
(EWK2UnitTest::LoadFinishedData::~LoadFinishedData):
(EWK2UnitTest):
(EWK2UnitTest::onLoadFinished):
(EWK2UnitTest::timeOutWhileWaitingUntilLoadFinished):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilLoadFinished):
(EWK2UnitTest::TitleChangedData::TitleChangedData):
(TitleChangedData):
(EWK2UnitTest::TitleChangedData::~TitleChangedData):
(EWK2UnitTest::onTitleChanged):
(EWK2UnitTest::timeOutWhileWaitingUntilTitleChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (128974 => 128975)

--- trunk/Source/WebKit2/ChangeLog	2012-09-19 08:00:33 UTC (rev 128974)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-19 08:04:40 UTC (rev 128975)
@@ -1,3 +1,37 @@
+2012-09-19  Byungwoo Lee  
+
+[EFL][WK2] waitUntilTitleChangedTo() and waitUntilLoadFinished() needs timeout.
+https://bugs.webkit.org/show_bug.cgi?id=96910
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Currently, the waitUntilTitleChangedTo() and waitUntilLoadFinished()
+functions doesn't handle timeout by itself.
+And if there are some failed cases that loading is not finished or
+title is not changed to the expected string, test case just stopped
+with timeout and there is no more information about this such as line
+number.
+
+To handle timeout status more properly, timeout parameter is added to
+these functions.
+
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
+(EWK2UnitTest::LoadFinishedData::LoadFinishedData):
+(LoadFinishedData):
+(EWK2UnitTest::LoadFinishedData::~LoadFinishedData):
+(EWK2UnitTest):
+(EWK2UnitTest::onLoadFinished):
+(EWK2UnitTest::timeOutWhileWaitingUntilLoadFinished):
+(EWK2UnitTest::EWK2UnitTestBase::waitUntilLoadFinished):
+(EWK2UnitTest::TitleChangedData::TitleChangedData):
+(TitleChangedData):
+(EWK2UnitTest::TitleChangedData::~TitleChangedData):
+(EWK2UnitTest::onTitleChanged):
+(EWK2UnitTest::timeOutWhileWaitingUntilTitleChangedTo):
+(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo):
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
+(EWK2UnitTestBase):
+
 2012-09-18  Byungwoo Lee  
 
 [EFL][WK2] Add _javascript_ popup API.


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp (128974 => 128975)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2012-09-19 08:00:33 UTC (rev 128974)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2012-09-19 08:04:40 UTC (rev 128975)
@@ -29,15 +29,6 @@
 
 namespace EWK2UnitTest {
 
-static void onLoadFinished(void* userData, Evas_Object* webView, void* eventInfo)
-{
-UNUSED_PARAM(webView);
-UNUSED_PARAM(eventInfo);
-
-bool* loadFinished = static_cast(userData);
-*loadFinished = true;
-}
-
 static Ewk_View_Smart_Class ewk2UnitTestBrowserViewSmartClass()
 {
 static Ewk_View_Smart_Class ewkViewClass = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("Browser_View");
@@ -89,40 +80,135 @@
 waitUntilLoadFinished();
 }
 
-void EWK2UnitTestBase::waitUntilLoadFinished()
+struct LoadFinishedData {
+LoadFinishedData(double timeoutSeconds, Ecore_Task_Cb callback)
+: loadFinished(false)
+, timer(0)
+, didTimeOut(false)
+{
+if (timeoutSeconds >= 0)
+timer = ecore_timer_add(timeoutSeconds, callback, this);
+}
+
+~LoadFinishedData()
+{
+if (timer)
+ecore_timer_del(timer);
+}
+
+bool loadFinished;
+Ecore_Timer* timer;
+bool didTimeOut;
+};
+
+static void onLoadFinished(void* userData, Evas_Object* webView, void* 

[webkit-changes] [128973] trunk/LayoutTests

[commit-queue]

Title: [128973] trunk/LayoutTests








Revision 128973
Author commit-qu...@webkit.org
Date 2012-09-19 00:26:49 -0700 (Wed, 19 Sep 2012)


Log Message
[EFL] Skip inspector/extensions/extensions-panel.html
https://bugs.webkit.org/show_bug.cgi?id=97078

Unreviewed EFL gardening.

Skip inspector/extensions/extensions-panel.html for
EFL port since it started failing after r128910.

Patch by Christophe Dumez  on 2012-09-19

* platform/efl-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128972 => 128973)

--- trunk/LayoutTests/ChangeLog	2012-09-19 07:20:40 UTC (rev 128972)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 07:26:49 UTC (rev 128973)
@@ -1,3 +1,15 @@
+2012-09-19  Christophe Dumez  
+
+[EFL] Skip inspector/extensions/extensions-panel.html
+https://bugs.webkit.org/show_bug.cgi?id=97078
+
+Unreviewed EFL gardening.
+
+Skip inspector/extensions/extensions-panel.html for
+EFL port since it started failing after r128910.
+
+* platform/efl-wk1/TestExpectations:
+
 2012-09-18  Christophe Dumez  
 
 [EFL] Skip several JS tests that crash after r128802


Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (128972 => 128973)

--- trunk/LayoutTests/platform/efl-wk1/TestExpectations	2012-09-19 07:20:40 UTC (rev 128972)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations	2012-09-19 07:26:49 UTC (rev 128973)
@@ -51,6 +51,9 @@
 // EFL's DumpRenderTree should support LayoutTestController's dumpEditingCallbacks()
 BUGWK84835 : editing/execCommand/indent-paragraphs.html = TEXT
 
+// Frame does not get focus as expected
+BUGWK97077 : inspector/extensions/extensions-panel.html = TEXT
+
 // Custom font loading delaying text drawing on Canvas
 BUGWK87355 : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128972] trunk/Source/WebKit/chromium

[tkent]

Title: [128972] trunk/Source/WebKit/chromium








Revision 128972
Author tk...@chromium.org
Date 2012-09-19 00:20:40 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Fix crash in WebFrameImpl::loadHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=96352

Reviewed by Adam Barth.

We have some crash reports with the following stack:
  - HistoryItem::shouldDoSameDocumentNavigationTo.
  - WebFrameImpl::loadHistoryItem
  ...

We don't have reproducible steps, and not sure what's the root
cause. Anyway we should check nullness of currentItem because
HistoryController::m_currentItem can be 0.

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadHistoryItem):
Check nullness of currentItem.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (128971 => 128972)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 07:00:15 UTC (rev 128971)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 07:20:40 UTC (rev 128972)
@@ -1,3 +1,23 @@
+2012-09-19  Kent Tamura  
+
+[Chromium] Fix crash in WebFrameImpl::loadHistoryItem
+https://bugs.webkit.org/show_bug.cgi?id=96352
+
+Reviewed by Adam Barth.
+
+We have some crash reports with the following stack:
+  - HistoryItem::shouldDoSameDocumentNavigationTo.
+  - WebFrameImpl::loadHistoryItem
+  ...
+
+We don't have reproducible steps, and not sure what's the root
+cause. Anyway we should check nullness of currentItem because
+HistoryController::m_currentItem can be 0.
+
+* src/WebFrameImpl.cpp:
+(WebKit::WebFrameImpl::loadHistoryItem):
+Check nullness of currentItem.
+
 2012-09-18  Sailesh Agrawal  
 
 Chromium: Scrollbar with tickmarks doesn't respond to clicks


Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (128971 => 128972)

--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp	2012-09-19 07:00:15 UTC (rev 128971)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp	2012-09-19 07:20:40 UTC (rev 128972)
@@ -1029,7 +1029,7 @@
 
 m_frame->loader()->prepareForHistoryNavigation();
 RefPtr currentItem = m_frame->loader()->history()->currentItem();
-m_inSameDocumentHistoryLoad = currentItem->shouldDoSameDocumentNavigationTo(historyItem.get());
+m_inSameDocumentHistoryLoad = currentItem && currentItem->shouldDoSameDocumentNavigationTo(historyItem.get());
 m_frame->page()->goToItem(historyItem.get(),
   FrameLoadTypeIndexedBackForward);
 m_inSameDocumentHistoryLoad = false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes