[webkit-changes] [137259] trunk/LayoutTests
Title: [137259] trunk/LayoutTests Revision 137259 Author christophe.du...@intel.com Date 2012-12-10 23:49:12 -0800 (Mon, 10 Dec 2012) Log Message [chromium] Unreviewed gardening https://bugs.webkit.org/show_bug.cgi?id=84432 fast/filesystem/op-restricted-names.html fast/filesystem/op-restricted-unicode.html fast/filesystem/read-directory.html fast/filesystem/simple-readonly-file-object.html Patch by Noel Gordon on 2012-12-10 * platform/chromium/TestExpectations: These have been passing on WIN for over a month. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137258 => 137259) --- trunk/LayoutTests/ChangeLog 2012-12-11 07:46:32 UTC (rev 137258) +++ trunk/LayoutTests/ChangeLog 2012-12-11 07:49:12 UTC (rev 137259) @@ -14,6 +14,15 @@ Unreviewed EFL gardening. +Mark new compositing/repaint/resize-repaint.html test introduced in +r137215 as failing on EFL WK2. + +* platform/efl-wk2/TestExpectations: + +2012-12-10 Christophe Dumez + +Unreviewed EFL gardening. + Rebaseline fast/js/global-constructors.html after r137243. * platform/efl/fast/js/global-constructors-expected.txt: Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (137258 => 137259) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-12-11 07:46:32 UTC (rev 137258) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-12-11 07:49:12 UTC (rev 137259) @@ -369,6 +369,9 @@ webkit.org/b/104476 compositing/background-color/background-color-padding-change.html [ ImageOnlyFailure ] webkit.org/b/104476 compositing/background-color/background-color-text-change.html [ ImageOnlyFailure ] +# New compositing test introduced in r137215 that is failing on WK2 EFL. +webkit.org/b/104637 compositing/repaint/resize-repaint.html [ Failure ] + # NPP_SetWindow is not called during plugin destruction on X11. webkit.org/b/63261 plugins/npp-set-window-called-during-destruction.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137258] trunk/Source/Platform
Title: [137258] trunk/Source/Platform
Revision 137258
Author dan...@chromium.org
Date 2012-12-10 23:46:32 -0800 (Mon, 10 Dec 2012)
Log Message
[chromium] Remove WebCompositorFrame(Ack) as these classes are not needed now that they are passed through cc::OutputSurface.
https://bugs.webkit.org/show_bug.cgi?id=104635
Reviewed by James Robinson.
These have been supplanted by cc::CompositorFrame(Ack) which do not
need to inherit from them.
* chromium/public/WebCompositorFrame.h: Removed.
* chromium/public/WebCompositorFrameAck.h: Removed.
Modified Paths
trunk/Source/Platform/ChangeLog
Removed Paths
trunk/Source/Platform/chromium/public/WebCompositorFrame.h
trunk/Source/Platform/chromium/public/WebCompositorFrameAck.h
Diff
Modified: trunk/Source/Platform/ChangeLog (137257 => 137258)
--- trunk/Source/Platform/ChangeLog 2012-12-11 07:46:20 UTC (rev 137257)
+++ trunk/Source/Platform/ChangeLog 2012-12-11 07:46:32 UTC (rev 137258)
@@ -1,5 +1,18 @@
2012-12-10 Dana Jansens
+[chromium] Remove WebCompositorFrame(Ack) as these classes are not needed now that they are passed through cc::OutputSurface.
+https://bugs.webkit.org/show_bug.cgi?id=104635
+
+Reviewed by James Robinson.
+
+These have been supplanted by cc::CompositorFrame(Ack) which do not
+need to inherit from them.
+
+* chromium/public/WebCompositorFrame.h: Removed.
+* chromium/public/WebCompositorFrameAck.h: Removed.
+
+2012-12-10 Dana Jansens
+
[chromium] Remove WebCompositorOutputSurface implementations from DRT
https://bugs.webkit.org/show_bug.cgi?id=104046
Deleted: trunk/Source/Platform/chromium/public/WebCompositorFrame.h (137257 => 137258)
--- trunk/Source/Platform/chromium/public/WebCompositorFrame.h 2012-12-11 07:46:20 UTC (rev 137257)
+++ trunk/Source/Platform/chromium/public/WebCompositorFrame.h 2012-12-11 07:46:32 UTC (rev 137258)
@@ -1,44 +0,0 @@
-/*
- * Copyright (C) 2012 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef WebCompositorFrame_h
-#define WebCompositorFrame_h
-
-namespace WebKit {
-
-// This class represents data, opaque to WebKit, representing the data
-// comprising a compositor frame when transferring it to a parent compositor.
-// See WebCompositorOutputSurface and WebDelegatedRendererLayer.
-struct WebCompositorFrame {
-};
-
-} // namespace WebKit
-
-#endif
Deleted: trunk/Source/Platform/chromium/public/WebCompositorFrameAck.h (137257 => 137258)
--- trunk/Source/Platform/chromium/public/WebCompositorFrameAck.h 2012-12-11 07:46:20 UTC (rev 137257)
+++ trunk/Source/Platform/chromium/public/WebCompositorFrameAck.h 2012-12-11 07:46:32 UTC (rev 137258)
@@ -1,44 +0,0 @@
-/*
- * Copyright (C) 2012 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written p
[webkit-changes] [137256] trunk
Title: [137256] trunk
Revision 137256
Author dan...@chromium.org
Date 2012-12-10 23:45:17 -0800 (Mon, 10 Dec 2012)
Log Message
[chromium] Remove WebCompositorOutputSurface implementations from DRT
https://bugs.webkit.org/show_bug.cgi?id=104046
Reviewed by Darin Fisher.
Source/Platform:
Remove now-unused definitions for these classes. The cc::OutputSurface
and its related classes have replaced these, with the
WebCompositorOutputSurface class as an empty base class.
* Platform.gypi:
* chromium/public/WebCompositorOutputSurface.h:
(WebKit):
* chromium/public/WebCompositorOutputSurfaceClient.h: Removed.
* chromium/public/WebCompositorSoftwareOutputDevice.h: Removed.
Source/WebKit/chromium:
Use WebCompositorSupport to create an OutputSurface.
* WebKit.gypi:
* src/WebViewImpl.cpp:
(WebKit):
* tests/Canvas2DLayerBridgeTest.cpp:
* tests/FakeWebCompositorOutputSurface.h: Removed.
* tests/WebLayerTreeViewTestCommon.h:
Tools:
The classes are now provided through WebCompositorSupport.
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):
* DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Removed.
* DumpRenderTree/chromium/WebViewHostOutputSurface.h: Removed.
* DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Removed.
* DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Removed.
Modified Paths
trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/Platform/chromium/public/WebCompositorOutputSurface.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/Canvas2DLayerBridgeTest.cpp
trunk/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp
trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gypi
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
Removed Paths
trunk/Source/Platform/chromium/public/WebCompositorOutputSurfaceClient.h
trunk/Source/Platform/chromium/public/WebCompositorSoftwareOutputDevice.h
trunk/Source/WebKit/chromium/tests/FakeWebCompositorOutputSurface.h
trunk/Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.h
trunk/Tools/DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h
Diff
Modified: trunk/Source/Platform/ChangeLog (137255 => 137256)
--- trunk/Source/Platform/ChangeLog 2012-12-11 07:33:01 UTC (rev 137255)
+++ trunk/Source/Platform/ChangeLog 2012-12-11 07:45:17 UTC (rev 137256)
@@ -1,3 +1,20 @@
+2012-12-10 Dana Jansens
+
+[chromium] Remove WebCompositorOutputSurface implementations from DRT
+https://bugs.webkit.org/show_bug.cgi?id=104046
+
+Reviewed by Darin Fisher.
+
+Remove now-unused definitions for these classes. The cc::OutputSurface
+and its related classes have replaced these, with the
+WebCompositorOutputSurface class as an empty base class.
+
+* Platform.gypi:
+* chromium/public/WebCompositorOutputSurface.h:
+(WebKit):
+* chromium/public/WebCompositorOutputSurfaceClient.h: Removed.
+* chromium/public/WebCompositorSoftwareOutputDevice.h: Removed.
+
2012-12-10 Mark Pilgrim
[Chromium] Move getPluginsList out of PlatformSupport
Modified: trunk/Source/Platform/Platform.gypi (137255 => 137256)
--- trunk/Source/Platform/Platform.gypi 2012-12-11 07:33:01 UTC (rev 137255)
+++ trunk/Source/Platform/Platform.gypi 2012-12-11 07:45:17 UTC (rev 137256)
@@ -45,9 +45,7 @@
'chromium/public/WebColor.h',
'chromium/public/WebCommon.h',
'chromium/public/WebCompositorSupport.h',
-'chromium/public/WebCompositorSoftwareOutputDevice.h',
'chromium/public/WebCompositorOutputSurface.h',
-'chromium/public/WebCompositorOutputSurfaceClient.h',
'chromium/public/WebContentLayer.h',
'chromium/public/WebContentLayerClient.h',
'chromium/public/WebCookie.h',
Modified: trunk/Source/Platform/chromium/public/WebCompositorOutputSurface.h (137255 => 137256)
--- trunk/Source/Platform/chromium/public/WebCompositorOutputSurface.h 2012-12-11 07:33:01 UTC (rev 137255)
+++ trunk/Source/Platform/chromium/public/WebCompositorOutputSurface.h 2012-12-11 07:45:17 UTC (rev 137256)
@@ -28,52 +28,9 @@
namespace WebKit {
-struct WebCompositorFrame;
-class WebGraphicsContext3D;
-class WebCompositorSoftwareOutputDevice;
-class WebCompositorOutputSurfaceClient;
-
-#ifdef USE_CC_OUTPUT_SURFACE
+// An empty base class for cc::OutputSurface in chromium.
class WebCompositorOutputSurface { };
-#else
-// Represents the output surface for a compositor. The compositor owns
-// and manages its destruction. Its lifetime is:
-// 1. Created on the
[webkit-changes] [137255] trunk/Source/WebKit2
Title: [137255] trunk/Source/WebKit2
Revision 137255
Author a...@apple.com
Date 2012-12-10 23:33:01 -0800 (Mon, 10 Dec 2012)
Log Message
[WK2] Add a user default to limit the number of web processes
https://bugs.webkit.org/show_bug.cgi?id=104606
Reviewed by Sam Weinig.
When the limit is reached, we'll reuse an existing process with fewest pages.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize m_webProcessCountLimit.
(WebKit::WebContext::platformInitialize): Added a hook for reading the preference,
empty implementation on most platforms.
(WebKit::WebContext::createNewWebProcess): Changed to return a raw pointer. The new
process is put into a vector anyway, so there is no ownership transfer.
(WebKit::WebContext::warmInitialProcess): Don't create a new process if that would
exceed the limit.
(WebKit::WebContext::createNewWebProcessRespectingProcessCountLimit): Added a new
function that wither creates a new process, or picks an existing one.
(WebKit::WebContext::createWebPage): Call the above new function instead of
unconditionally creating a process.
* UIProcess/WebContext.h: createNewWebProcess is no private. All clients should
respect the process count limit.
* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcess):
Respect the process count limit.
* UIProcess/mac/WebContextMac.mm:
(WebKit::registerUserDefaultsIfNeeded): Register the new default.
(WebKit::WebContext::platformInitialize): Read the default into a WebContext
member variable.
(WebKit::WebContext::platformInitializeWebProcess): Moved registerUserDefaultsIfNeeded()
from here to platformInitialize(), as that's a better place for it. Also added a
FIXME for an unrelated issue.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137254 => 137255)
--- trunk/Source/WebKit2/ChangeLog 2012-12-11 07:31:17 UTC (rev 137254)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-11 07:33:01 UTC (rev 137255)
@@ -1,3 +1,39 @@
+2012-12-10 Alexey Proskuryakov
+
+[WK2] Add a user default to limit the number of web processes
+https://bugs.webkit.org/show_bug.cgi?id=104606
+
+Reviewed by Sam Weinig.
+
+When the limit is reached, we'll reuse an existing process with fewest pages.
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::WebContext): Initialize m_webProcessCountLimit.
+(WebKit::WebContext::platformInitialize): Added a hook for reading the preference,
+empty implementation on most platforms.
+(WebKit::WebContext::createNewWebProcess): Changed to return a raw pointer. The new
+process is put into a vector anyway, so there is no ownership transfer.
+(WebKit::WebContext::warmInitialProcess): Don't create a new process if that would
+exceed the limit.
+(WebKit::WebContext::createNewWebProcessRespectingProcessCountLimit): Added a new
+function that wither creates a new process, or picks an existing one.
+(WebKit::WebContext::createWebPage): Call the above new function instead of
+unconditionally creating a process.
+
+* UIProcess/WebContext.h: createNewWebProcess is no private. All clients should
+respect the process count limit.
+
+* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcess):
+Respect the process count limit.
+
+* UIProcess/mac/WebContextMac.mm:
+(WebKit::registerUserDefaultsIfNeeded): Register the new default.
+(WebKit::WebContext::platformInitialize): Read the default into a WebContext
+member variable.
+(WebKit::WebContext::platformInitializeWebProcess): Moved registerUserDefaultsIfNeeded()
+from here to platformInitialize(), as that's a better place for it. Also added a
+FIXME for an unrelated issue.
+
2012-12-10 Jon Lee
Build fix.
Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (137254 => 137255)
--- trunk/Source/WebKit2/UIProcess/WebContext.cpp 2012-12-11 07:31:17 UTC (rev 137254)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp 2012-12-11 07:33:01 UTC (rev 137255)
@@ -120,6 +120,7 @@
WebContext::WebContext(ProcessModel processModel, const String& injectedBundlePath)
: m_processModel(processModel)
+, m_webProcessCountLimit(UINT_MAX)
, m_haveInitialEmptyProcess(false)
, m_defaultPageGroup(WebPageGroup::create())
, m_injectedBundlePath(injectedBundlePath)
@@ -139,6 +140,8 @@
, m_usesNetworkProcess(false)
#endif
{
+platformInitialize();
+
addMessageReceiver(Messages::WebContext::messageReceiverName(), this);
addMessageReceiver(CoreIPC::MessageKindTraits::messageReceiverName(), this);
@@ -184,6 +187,12 @@
#endif
}
+#if !PLATFORM(MAC)
+void WebContext::p
[webkit-changes] [137254] trunk/LayoutTests
Title: [137254] trunk/LayoutTests Revision 137254 Author christophe.du...@intel.com Date 2012-12-10 23:31:17 -0800 (Mon, 10 Dec 2012) Log Message Unreviewed EFL gardening. Rebaseline fast/js/global-constructors.html after r137243. * platform/efl/fast/js/global-constructors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (137253 => 137254) --- trunk/LayoutTests/ChangeLog 2012-12-11 07:20:52 UTC (rev 137253) +++ trunk/LayoutTests/ChangeLog 2012-12-11 07:31:17 UTC (rev 137254) @@ -1,3 +1,11 @@ +2012-12-10 Christophe Dumez + +Unreviewed EFL gardening. + +Rebaseline fast/js/global-constructors.html after r137243. + +* platform/efl/fast/js/global-constructors-expected.txt: + 2012-12-10 Noel Gordon [chromium] Unreviewed gardening Modified: trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt (137253 => 137254) --- trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt 2012-12-11 07:20:52 UTC (rev 137253) +++ trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt 2012-12-11 07:31:17 UTC (rev 137254) @@ -325,9 +325,7 @@ PASS UIEvent.toString() is '[object UIEventConstructor]' PASS URL.toString() is '[object URLConstructor]' PASS WebGLContextEvent.toString() is '[object WebGLContextEventConstructor]' -PASS WebKitAnimation.toString() is '[object WebKitAnimationConstructor]' PASS WebKitAnimationEvent.toString() is '[object WebKitAnimationEventConstructor]' -PASS WebKitAnimationList.toString() is '[object WebKitAnimationListConstructor]' PASS WebKitCSSKeyframeRule.toString() is '[object WebKitCSSKeyframeRuleConstructor]' PASS WebKitCSSKeyframesRule.toString() is '[object WebKitCSSKeyframesRuleConstructor]' PASS WebKitCSSMatrix.toString() is '[object WebKitCSSMatrixConstructor]' ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137250] trunk
Title: [137250] trunk
Revision 137250
Author commit-qu...@webkit.org
Date 2012-12-10 22:44:15 -0800 (Mon, 10 Dec 2012)
Log Message
REGRESSION (r137006): CSS clip on solid color composited div broken
https://bugs.webkit.org/show_bug.cgi?id=104604
Patch by No'am Rosenthal on 2012-12-10
Reviewed by Simon Fraser.
Source/WebCore:
Disable direct compositing of background color for clipping layers.
Test: compositing/geometry/clip-inside.html
* rendering/RenderLayerBacking.cpp:
(WebCore::supportsDirectBoxDecorationsComposition):
Never allow direct background composition if there is a clip.
LayoutTests:
Added a new test (by Simon Fraser) to make sure background color doesn't break clipping.
* compositing/geometry/clip-inside-expected.txt: Added.
* compositing/geometry/clip-inside.html: Added.
* compositing/geometry/clip-expected:
New result.
* platform/chromium/compositing/geometry/clip-inside-expected.txt
Adjust Chromium expected result for new test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/geometry/clip-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Added Paths
trunk/LayoutTests/compositing/geometry/clip-inside-expected.txt
trunk/LayoutTests/compositing/geometry/clip-inside.html
trunk/LayoutTests/platform/chromium/compositing/geometry/clip-inside-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (137249 => 137250)
--- trunk/LayoutTests/ChangeLog 2012-12-11 06:07:15 UTC (rev 137249)
+++ trunk/LayoutTests/ChangeLog 2012-12-11 06:44:15 UTC (rev 137250)
@@ -1,3 +1,20 @@
+2012-12-10 No'am Rosenthal
+
+REGRESSION (r137006): CSS clip on solid color composited div broken
+https://bugs.webkit.org/show_bug.cgi?id=104604
+
+Reviewed by Simon Fraser.
+
+Added a new test (by Simon Fraser) to make sure background color doesn't break clipping.
+
+* compositing/geometry/clip-inside-expected.txt: Added.
+* compositing/geometry/clip-inside.html: Added.
+* compositing/geometry/clip-expected:
+New result.
+
+* platform/chromium/compositing/geometry/clip-inside-expected.txt
+Adjust Chromium expected result for new test.
+
2012-12-10 Noel Gordon
[chromium] Unreviewed gardening after http://trac.webkit.org/changeset/137243
Modified: trunk/LayoutTests/compositing/geometry/clip-expected.txt (137249 => 137250)
--- trunk/LayoutTests/compositing/geometry/clip-expected.txt 2012-12-11 06:07:15 UTC (rev 137249)
+++ trunk/LayoutTests/compositing/geometry/clip-expected.txt 2012-12-11 06:44:15 UTC (rev 137250)
@@ -15,7 +15,7 @@
(GraphicsLayer
(position 220.00 20.00)
(bounds 100.00 100.00)
- (backgroundColor #808080)
+ (drawsContent 1)
)
(GraphicsLayer
(position 215.00 15.00)
Copied: trunk/LayoutTests/compositing/geometry/clip-inside-expected.txt (from rev 137249, trunk/LayoutTests/compositing/geometry/clip-expected.txt) (0 => 137250)
--- trunk/LayoutTests/compositing/geometry/clip-inside-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/geometry/clip-inside-expected.txt 2012-12-11 06:44:15 UTC (rev 137250)
@@ -0,0 +1,37 @@
+Test CSS clip with composited layers. Left and right sides should look the same.
+
+(GraphicsLayer
+ (bounds 800.00 600.00)
+ (children 1
+(GraphicsLayer
+ (bounds 800.00 600.00)
+ (children 3
+(GraphicsLayer
+ (position 25.00 35.00)
+ (anchor 0.50 0.44)
+ (bounds 90.00 80.00)
+ (drawsContent 1)
+ (transform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 0.00] [0.00 0.00 1.00 1.00])
+)
+(GraphicsLayer
+ (position 225.00 35.00)
+ (bounds 90.00 80.00)
+ (drawsContent 1)
+)
+(GraphicsLayer
+ (position 225.00 35.00)
+ (bounds 90.00 80.00)
+ (children 1
+(GraphicsLayer
+ (position -15.00 -25.00)
+ (bounds 120.00 120.00)
+ (backgroundColor #0033)
+ (transform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 0.00] [0.00 0.00 1.00 1.00])
+)
+ )
+)
+ )
+)
+ )
+)
+
Added: trunk/LayoutTests/compositing/geometry/clip-inside.html (0 => 137250)
--- trunk/LayoutTests/compositing/geometry/clip-inside.html (rev 0)
+++ trunk/LayoutTests/compositing/geometry/clip-inside.html 2012-12-11 06:44:15 UTC (rev 137250)
@@ -0,0 +1,60 @@
+
+
+
+.box {
+ position: absolute;
+ width: 100px;
+ height: 100px;
+ top: 20px;
+ left: 20px;
+ background-color: gray;
+ clip: rect(15px, 95px, 95px, 5px);
+}
+
+.inner {
+ position: relative;
+ width: 120px;
+ height: 120px;
+ top: -10px;
+ left: -10px;
+ background-color:
[webkit-changes] [137248] trunk
Title: [137248] trunk
Revision 137248
Author simon.fra...@apple.com
Date 2012-12-10 21:54:06 -0800 (Mon, 10 Dec 2012)
Log Message
Source/WebCore: REGRESSION (r137215): WebKit stretches and shrinks a part of screen on scroll
https://bugs.webkit.org/show_bug.cgi?id=104626
Reviewed by Beth Dakin.
r137215 removed a compositing layer repaint on size changes. However, there
are cases where the compositing code constrains layer size by clipping
with the viewport and a clipping ancestor. When that happens, we must
invalidate the layer on a size change to avoid showing stretched or
shrunken content.
Test: compositing/repaint/clipped-layer-size-change.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
LayoutTests: REGRESSION(r137215): WebKit stretches and shrinks a part of screen on scroll
https://bugs.webkit.org/show_bug.cgi?id=104626
Reviewed by Beth Dakin.
Testcase that scrolls an overflow area containing a compositing layer.
* compositing/repaint/clipped-layer-size-change-expected.html: Added.
* compositing/repaint/clipped-layer-size-change.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h
Added Paths
trunk/LayoutTests/compositing/repaint/clipped-layer-size-change-expected.html
trunk/LayoutTests/compositing/repaint/clipped-layer-size-change.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137247 => 137248)
--- trunk/LayoutTests/ChangeLog 2012-12-11 05:22:49 UTC (rev 137247)
+++ trunk/LayoutTests/ChangeLog 2012-12-11 05:54:06 UTC (rev 137248)
@@ -1,3 +1,15 @@
+2012-12-10 Simon Fraser
+
+REGRESSION(r137215): WebKit stretches and shrinks a part of screen on scroll
+https://bugs.webkit.org/show_bug.cgi?id=104626
+
+Reviewed by Beth Dakin.
+
+Testcase that scrolls an overflow area containing a compositing layer.
+
+* compositing/repaint/clipped-layer-size-change-expected.html: Added.
+* compositing/repaint/clipped-layer-size-change.html: Added.
+
2012-12-10 Noel Gordon
[chromium] fast/dom/HTMLMeterElement/meter-boundary-values.html is flaky
Added: trunk/LayoutTests/compositing/repaint/clipped-layer-size-change-expected.html (0 => 137248)
--- trunk/LayoutTests/compositing/repaint/clipped-layer-size-change-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/repaint/clipped-layer-size-change-expected.html 2012-12-11 05:54:06 UTC (rev 137248)
@@ -0,0 +1,43 @@
+
+
+
+
+
+#container {
+width: 200px;
+height: 200px;
+overflow: hidden;
+border: 1px solid black;
+}
+
+.scroll-content {
+height: 600px;
+}
+
+.inner {
+position: relative;
+width: 150px;
+height: 150px;
+margin-top: -10px; /* force overlap with the composited element */
+margin-left: 10px;
+box-sizing: border-box;
+border: 40px solid black;
+}
+
+.composited {
+height: 50px;
+width: 100px;
+-webkit-transform: translateZ(0);
+}
+
+
+
+
+
+
+
+
+
+
+
+
Added: trunk/LayoutTests/compositing/repaint/clipped-layer-size-change.html (0 => 137248)
--- trunk/LayoutTests/compositing/repaint/clipped-layer-size-change.html (rev 0)
+++ trunk/LayoutTests/compositing/repaint/clipped-layer-size-change.html 2012-12-11 05:54:06 UTC (rev 137248)
@@ -0,0 +1,59 @@
+
+
+
+
+
+#container {
+width: 200px;
+height: 200px;
+overflow: hidden;
+border: 1px solid black;
+}
+
+.scroll-content {
+height: 600px;
+}
+
+.inner {
+position: relative;
+width: 150px;
+height: 150px;
+margin-top: -10px; /* force overlap with the composited element */
+margin-left: 10px;
+box-sizing: border-box;
+border: 40px solid black;
+}
+
+.composited {
+height: 150px;
+width: 100px;
+-webkit-transform: translateZ(0);
+}
+
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function doTest()
+{
+window.setTimeout(function() {
+var container = document.getElementById('container');
+window.console.log('scrolling')
+container.scrollTop = 100;
+if (window.testRunner)
+testRunner.notifyDone()
[webkit-changes] [137247] trunk/Source/JavaScriptCore
Title: [137247] trunk/Source/_javascript_Core
Revision 137247
Author fpi...@apple.com
Date 2012-12-10 21:22:49 -0800 (Mon, 10 Dec 2012)
Log Message
Don't OSR exit just because a string is a rope
https://bugs.webkit.org/show_bug.cgi?id=104621
Reviewed by Michael Saboff.
Slight SunSpider speed-up at around the 0.7% level. This patch does the obvious
thing of calling a slow path to resolve ropes rather than OSR exiting if the
string is a rope.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::getIndexedPropertyStorageMayTriggerGC):
(ArrayMode):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::putStructureStoreElimination):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGArrayMode.h
trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (137246 => 137247)
--- trunk/Source/_javascript_Core/ChangeLog 2012-12-11 05:17:49 UTC (rev 137246)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-12-11 05:22:49 UTC (rev 137247)
@@ -1,3 +1,28 @@
+2012-12-10 Filip Pizlo
+
+Don't OSR exit just because a string is a rope
+https://bugs.webkit.org/show_bug.cgi?id=104621
+
+Reviewed by Michael Saboff.
+
+Slight SunSpider speed-up at around the 0.7% level. This patch does the obvious
+thing of calling a slow path to resolve ropes rather than OSR exiting if the
+string is a rope.
+
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::execute):
+* dfg/DFGArrayMode.h:
+(JSC::DFG::ArrayMode::getIndexedPropertyStorageMayTriggerGC):
+(ArrayMode):
+* dfg/DFGCSEPhase.cpp:
+(JSC::DFG::CSEPhase::putStructureStoreElimination):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::callOperation):
+
2012-12-10 Gustavo Noronha Silva
Unreviewed distcheck fix.
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (137246 => 137247)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-12-11 05:17:49 UTC (rev 137246)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-12-11 05:22:49 UTC (rev 137247)
@@ -1598,16 +1598,7 @@
break;
}
case GetIndexedPropertyStorage: {
-switch (node.arrayMode().type()) {
-case Array::String:
-// Strings are weird - we may spec fail if the string was a rope. That is of course
-// stupid, and we should fix that, but for now let's at least be honest about it.
-node.setCanExit(true);
-break;
-default:
-node.setCanExit(false);
-break;
-}
+node.setCanExit(false);
forNode(nodeIndex).clear();
break;
}
Modified: trunk/Source/_javascript_Core/dfg/DFGArrayMode.h (137246 => 137247)
--- trunk/Source/_javascript_Core/dfg/DFGArrayMode.h 2012-12-11 05:17:49 UTC (rev 137246)
+++ trunk/Source/_javascript_Core/dfg/DFGArrayMode.h 2012-12-11 05:22:49 UTC (rev 137247)
@@ -383,6 +383,11 @@
}
}
+bool getIndexedPropertyStorageMayTriggerGC() const
+{
+return type() == Array::String;
+}
+
bool operator==(const ArrayMode& other) const
{
return type() == other.type()
Modified: trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp (137246 => 137247)
--- trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp 2012-12-11 05:17:49 UTC (rev 137246)
+++ trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp 2012-12-11 05:22:49 UTC (rev 137247)
@@ -564,6 +564,11 @@
case ReallocatePropertyStorage:
return NoNode;
+case GetIndexedPropertyStorage:
+if (node.arrayMode().getIndexedPropertyStorageMayTriggerGC())
+return NoNode;
+break;
+
default:
break;
}
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (137246 => 137247)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-12-11 05:17:49 UTC (rev 137246)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-12-11 05:22:49 UTC (rev 137247)
@@ -1460,6 +1460,14 @@
return reinterpret_cast(object->ensureArrayStorage(globalData));
[webkit-changes] [137246] trunk/Source/WebKit/win
Title: [137246] trunk/Source/WebKit/win
Revision 137246
Author commit-qu...@webkit.org
Date 2012-12-10 21:17:49 -0800 (Mon, 10 Dec 2012)
Log Message
ASSERTION failed in Windows: css3/css3-modsel-33.html
https://bugs.webkit.org/show_bug.cgi?id=104472
Patch by Xueqing Huang on 2012-12-10
Reviewed by Tim Horton.
In WebFrameLoaderClient::dispatchDidLayout, milestones maybe
DidFirstLayout & DidFirstVisualNonEmptyLayout, we should
use seperate COMPtrs for the two cases rather than reuse one.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidLayout):
Modified Paths
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (137245 => 137246)
--- trunk/Source/WebKit/win/ChangeLog 2012-12-11 04:44:19 UTC (rev 137245)
+++ trunk/Source/WebKit/win/ChangeLog 2012-12-11 05:17:49 UTC (rev 137246)
@@ -1,3 +1,17 @@
+2012-12-10 Xueqing Huang
+
+ASSERTION failed in Windows: css3/css3-modsel-33.html
+https://bugs.webkit.org/show_bug.cgi?id=104472
+
+Reviewed by Tim Horton.
+
+In WebFrameLoaderClient::dispatchDidLayout, milestones maybe
+DidFirstLayout & DidFirstVisualNonEmptyLayout, we should
+use seperate COMPtrs for the two cases rather than reuse one.
+
+* WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebFrameLoaderClient::dispatchDidLayout):
+
2012-12-08 Seokju Kwon
Remove unused headers
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp (137245 => 137246)
--- trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp 2012-12-11 04:44:19 UTC (rev 137245)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp 2012-12-11 05:17:49 UTC (rev 137246)
@@ -419,14 +419,15 @@
void WebFrameLoaderClient::dispatchDidLayout(LayoutMilestones milestones)
{
WebView* webView = m_webFrame->webView();
-COMPtr frameLoadDelegatePrivate;
if (milestones & DidFirstLayout) {
+COMPtr frameLoadDelegatePrivate;
if (SUCCEEDED(webView->frameLoadDelegatePrivate(&frameLoadDelegatePrivate)) && frameLoadDelegatePrivate)
frameLoadDelegatePrivate->didFirstLayoutInFrame(webView, m_webFrame);
}
if (milestones & DidFirstVisuallyNonEmptyLayout) {
+COMPtr frameLoadDelegatePrivate;
if (SUCCEEDED(webView->frameLoadDelegatePrivate(&frameLoadDelegatePrivate)) && frameLoadDelegatePrivate)
frameLoadDelegatePrivate->didFirstVisuallyNonEmptyLayoutInFrame(webView, m_webFrame);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137245] trunk/Source/WebCore/ChangeLog
Title: [137245] trunk/Source/WebCore/ChangeLog Revision 137245 Author d...@apple.com Date 2012-12-10 20:44:19 -0800 (Mon, 10 Dec 2012) Log Message Change Tab's affiliation in ChangeLog on recent patch. Modified Paths trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/ChangeLog (137244 => 137245) --- trunk/Source/WebCore/ChangeLog 2012-12-11 04:31:59 UTC (rev 137244) +++ trunk/Source/WebCore/ChangeLog 2012-12-11 04:44:19 UTC (rev 137245) @@ -631,7 +631,7 @@ * bindings/js/JSDictionary.h: (WebCore::JSDictionary::tryGetPropertyAndResult): -2012-12-10 Tab Atkins +2012-12-10 Tab Atkins Deprecate prefixed linear-gradient and radial-gradient functions https://bugs.webkit.org/show_bug.cgi?id=104591 @@ -33249,7 +33249,7 @@ (WebCore::RenderThemeMacShared::fileListNameForWidth): (WebCore::RenderThemeMacShared::paintPlugInSnapshotOverlay): -2012-11-13 Tab Atkins +2012-11-13 Tab Atkins CSS @charset parsing is too loose, doesn't match other browsers https://bugs.webkit.org/show_bug.cgi?id=101527 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137242] trunk/Source/WebKit/chromium
Title: [137242] trunk/Source/WebKit/chromium
Revision 137242
Author senorbla...@chromium.org
Date 2012-12-10 19:53:49 -0800 (Mon, 10 Dec 2012)
Log Message
[Chromium] Re-enable a failing test. Disabling it just seemed to
move the problem to another test. Unreviewed.
* tests/GraphicsLayerChromiumTest.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (137241 => 137242)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-11 03:34:03 UTC (rev 137241)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-11 03:53:49 UTC (rev 137242)
@@ -1,3 +1,10 @@
+2012-12-10 Stephen White
+
+[Chromium] Re-enable a failing test. Disabling it just seemed to
+move the problem to another test. Unreviewed.
+
+* tests/GraphicsLayerChromiumTest.cpp:
+
2012-12-10 David Grogan
IndexedDB: Propagate more leveldb errors to script
Modified: trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp (137241 => 137242)
--- trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp 2012-12-11 03:34:03 UTC (rev 137241)
+++ trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp 2012-12-11 03:53:49 UTC (rev 137242)
@@ -88,7 +88,7 @@
MockGraphicsLayerClient m_client;
};
-TEST_F(GraphicsLayerChromiumTest, DISABLED_updateLayerPreserves3DWithAnimations)
+TEST_F(GraphicsLayerChromiumTest, updateLayerPreserves3DWithAnimations)
{
ASSERT_FALSE(m_platformLayer->hasActiveAnimation());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137241] trunk/Source/WebKit2
Title: [137241] trunk/Source/WebKit2
Revision 137241
Author jon...@apple.com
Date 2012-12-10 19:34:03 -0800 (Mon, 10 Dec 2012)
Log Message
Build fix.
* WebProcess/WebCoreSupport/WebPlugInClient.cpp:
(WebKit::WebPlugInClient::WebPlugInClient): Remove unneeded m_page variable.
* WebProcess/WebCoreSupport/WebPlugInClient.h:
(WebPlugInClient):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137240 => 137241)
--- trunk/Source/WebKit2/ChangeLog 2012-12-11 03:10:41 UTC (rev 137240)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-11 03:34:03 UTC (rev 137241)
@@ -1,5 +1,14 @@
2012-12-10 Jon Lee
+Build fix.
+
+* WebProcess/WebCoreSupport/WebPlugInClient.cpp:
+(WebKit::WebPlugInClient::WebPlugInClient): Remove unneeded m_page variable.
+* WebProcess/WebCoreSupport/WebPlugInClient.h:
+(WebPlugInClient):
+
+2012-12-10 Jon Lee
+
Keep track of plug-in snapshots clicked by user
https://bugs.webkit.org/show_bug.cgi?id=103206
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.cpp (137240 => 137241)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.cpp 2012-12-11 03:10:41 UTC (rev 137240)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.cpp 2012-12-11 03:34:03 UTC (rev 137241)
@@ -33,8 +33,7 @@
namespace WebKit {
-WebPlugInClient::WebPlugInClient(WebPage* page)
-: m_page(page)
+WebPlugInClient::WebPlugInClient(WebPage*)
{
}
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.h (137240 => 137241)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.h 2012-12-11 03:10:41 UTC (rev 137240)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.h 2012-12-11 03:34:03 UTC (rev 137241)
@@ -41,8 +41,6 @@
virtual void pageDestroyed();
virtual bool isAutoStartOrigin(unsigned plugInOriginHash);
virtual void addAutoStartOrigin(const String& pageOrigin, unsigned plugInOriginHash);
-
-WebPage *m_page;
};
} // namespace WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137240] trunk/Source/WebCore
Title: [137240] trunk/Source/WebCore Revision 137240 Author jber...@webkit.org Date 2012-12-10 19:10:41 -0800 (Mon, 10 Dec 2012) Log Message Fix the Mac build after r137233 * html/shadow/HTMLShadowElement.h: Remove a declaration of a member variable that was moved to the InsertionPoint superclass. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/shadow/HTMLShadowElement.h Diff Modified: trunk/Source/WebCore/ChangeLog (137239 => 137240) --- trunk/Source/WebCore/ChangeLog 2012-12-11 02:37:23 UTC (rev 137239) +++ trunk/Source/WebCore/ChangeLog 2012-12-11 03:10:41 UTC (rev 137240) @@ -1,3 +1,10 @@ +2012-12-10 Jessie Berlin + +Fix the Mac build after r137233 + +* html/shadow/HTMLShadowElement.h: +Remove a declaration of a member variable that was moved to the InsertionPoint superclass. + 2012-12-10 KyungTae Kim Build fix after r137221 Modified: trunk/Source/WebCore/html/shadow/HTMLShadowElement.h (137239 => 137240) --- trunk/Source/WebCore/html/shadow/HTMLShadowElement.h 2012-12-11 02:37:23 UTC (rev 137239) +++ trunk/Source/WebCore/html/shadow/HTMLShadowElement.h 2012-12-11 03:10:41 UTC (rev 137240) @@ -51,8 +51,6 @@ HTMLShadowElement(const QualifiedName&, Document*); static const CSSSelectorList& emptySelectorList(); - -bool m_registeredWithShadowRoot; }; inline bool isHTMLShadowElement(const Node* node) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137239] trunk/LayoutTests
Title: [137239] trunk/LayoutTests
Revision 137239
Author commit-qu...@webkit.org
Date 2012-12-10 18:37:23 -0800 (Mon, 10 Dec 2012)
Log Message
[EFL] Rebaseline expected results for "visibility:hidden; position: absolute;" cases
https://bugs.webkit.org/show_bug.cgi?id=104620
Unreviewed, EFL gardening.
This is a following rebaseline of BUG 104195.
This patch sets AC ON as a default expected result of EFL.
Patch by Kangil Han on 2012-12-10
* platform/efl-wk1/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Copied from LayoutTests/platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt.
* platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Copied from LayoutTests/platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt.
* platform/efl-wk1/fast/block/basic/020-expected.txt: Copied from LayoutTests/platform/efl/fast/block/basic/020-expected.txt.
* platform/efl-wk2/fast/block/basic/020-expected.txt: Removed.
* platform/efl/TestExpectations:
* platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
* platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
* platform/efl/fast/block/basic/020-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt
trunk/LayoutTests/platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt
trunk/LayoutTests/platform/efl/fast/block/basic/020-expected.txt
Added Paths
trunk/LayoutTests/platform/efl-wk1/editing/
trunk/LayoutTests/platform/efl-wk1/editing/input/
trunk/LayoutTests/platform/efl-wk1/editing/input/caret-at-the-edge-of-contenteditable-expected.txt
trunk/LayoutTests/platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt
trunk/LayoutTests/platform/efl-wk1/fast/block/basic/
trunk/LayoutTests/platform/efl-wk1/fast/block/basic/020-expected.txt
Removed Paths
trunk/LayoutTests/platform/efl-wk2/fast/block/basic/020-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (137238 => 137239)
--- trunk/LayoutTests/ChangeLog 2012-12-11 02:06:01 UTC (rev 137238)
+++ trunk/LayoutTests/ChangeLog 2012-12-11 02:37:23 UTC (rev 137239)
@@ -1,3 +1,22 @@
+2012-12-10 Kangil Han
+
+[EFL] Rebaseline expected results for "visibility:hidden; position: absolute;" cases
+https://bugs.webkit.org/show_bug.cgi?id=104620
+
+Unreviewed, EFL gardening.
+
+This is a following rebaseline of BUG 104195.
+This patch sets AC ON as a default expected result of EFL.
+
+* platform/efl-wk1/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Copied from LayoutTests/platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt.
+* platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Copied from LayoutTests/platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt.
+* platform/efl-wk1/fast/block/basic/020-expected.txt: Copied from LayoutTests/platform/efl/fast/block/basic/020-expected.txt.
+* platform/efl-wk2/fast/block/basic/020-expected.txt: Removed.
+* platform/efl/TestExpectations:
+* platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
+* platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
+* platform/efl/fast/block/basic/020-expected.txt:
+
2012-12-10 Adam Klein
Fix expectations lint errors in r137231
Modified: trunk/LayoutTests/platform/efl/TestExpectations (137238 => 137239)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-12-11 02:06:01 UTC (rev 137238)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-12-11 02:37:23 UTC (rev 137239)
@@ -1579,8 +1579,6 @@
Bug(EFL) compositing/iframes/scroll-grandchild-iframe.html [ ImageOnlyFailure ]
Bug(EFL) compositing/repaint/invalidations-on-composited-layers.html [ Failure ]
Bug(EFL) compositing/visibility/visibility-composited.html [ Failure ]
-Bug(EFL) editing/input/caret-at-the-edge-of-contenteditable.html [ Failure ]
-Bug(EFL) editing/input/reveal-caret-of-multiline-contenteditable.html [ Failure ]
Bug(EFL) editing/selection/caret-rtl.html [ Failure Pass ]
Bug(EFL) editing/selection/caret-at-bidi-boundary.html [ Crash Pass ]
Bug(EFL) editing/selection/caret-ltr.html [ Failure Pass ]
Modified: trunk/LayoutTests/platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt (137238 => 137239)
--- trunk/LayoutTests/platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt 2012-12-11 02:06:01 UTC (rev 137238)
+++ trunk/LayoutTests/platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt 2012-12-11 02:37:23 UTC (rev 137239)
@@ -11,4 +11,8 @@
RenderBlock {DIV} at (0,36)
[webkit-changes] [137238] trunk/LayoutTests
Title: [137238] trunk/LayoutTests Revision 137238 Author ad...@chromium.org Date 2012-12-10 18:06:01 -0800 (Mon, 10 Dec 2012) Log Message Fix expectations lint errors in r137231 Unreviewed gardening. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137237 => 137238) --- trunk/LayoutTests/ChangeLog 2012-12-11 02:00:26 UTC (rev 137237) +++ trunk/LayoutTests/ChangeLog 2012-12-11 02:06:01 UTC (rev 137238) @@ -1,5 +1,12 @@ 2012-12-10 Adam Klein +Fix expectations lint errors in r137231 +Unreviewed gardening. + +* platform/chromium/TestExpectations: + +2012-12-10 Adam Klein + Rewrite last occurrences of "Image" in TestExpectations to "ImageOnlyFailure". Unreviewed test expectations update. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137237 => 137238) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 02:00:26 UTC (rev 137237) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 02:06:01 UTC (rev 137238) @@ -3847,8 +3847,8 @@ webkit.org/b/96628 [ Lion MountainLion ] fast/frames/calculate-order.html [ Failure Pass ] webkit.org/b/96550 http/tests/media/media-source/seek-to-end-after-duration-change.html [ Pass Timeout ] -webkit.org/b/104584 http/tests/media/media-source/video-media-source-seek.html [ Skip ] -webkit.org/b/104584 http/tests/media/media-source/video-media-source-state-changes.html [ Skip ] +webkit.org/b/104584 [ Win Mac Linux ] http/tests/media/media-source/video-media-source-seek.html [ Skip ] +webkit.org/b/104584 [ Win Mac Linux ] http/tests/media/media-source/video-media-source-state-changes.html [ Skip ] crbug.com/63921 platform/chromium/virtual/gpu/fast/canvas/canvas-fillPath-shadow.html [ Failure ] webkit.org/b/77550 platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137237] trunk/Tools
Title: [137237] trunk/Tools
Revision 137237
Author dpra...@chromium.org
Date 2012-12-10 18:00:26 -0800 (Mon, 10 Dec 2012)
Log Message
change --no-launch-safari to --no-show-results in scripts
https://bugs.webkit.org/show_bug.cgi?id=104298
Reviewed by Eric Seidel.
Since Safari only exists on the Apple ports, NRWT calls the
command line flag --[no-]show-results instead. This updates
the scripts to use the new flag (but not the buildbot config yet).
* Scripts/generate-coverage-data:
* Scripts/webkit-tools-completion.sh:
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/generate-coverage-data
trunk/Tools/Scripts/webkit-tools-completion.sh
trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py
trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (137236 => 137237)
--- trunk/Tools/ChangeLog 2012-12-11 01:59:13 UTC (rev 137236)
+++ trunk/Tools/ChangeLog 2012-12-11 02:00:26 UTC (rev 137237)
@@ -1,5 +1,22 @@
2012-12-10 Dirk Pranke
+change --no-launch-safari to --no-show-results in scripts
+https://bugs.webkit.org/show_bug.cgi?id=104298
+
+Reviewed by Eric Seidel.
+
+Since Safari only exists on the Apple ports, NRWT calls the
+command line flag --[no-]show-results instead. This updates
+the scripts to use the new flag (but not the buildbot config yet).
+
+* Scripts/generate-coverage-data:
+* Scripts/webkit-tools-completion.sh:
+* Scripts/webkitpy/tool/steps/runtests.py:
+(RunTests.run):
+* Scripts/webkitpy/tool/steps/runtests_unittest.py:
+
+2012-12-10 Dirk Pranke
+
nrwt: fix mapping of AUDIO onto FAIL when printing unexpected results
https://bugs.webkit.org/show_bug.cgi?id=104597
Modified: trunk/Tools/Scripts/generate-coverage-data (137236 => 137237)
--- trunk/Tools/Scripts/generate-coverage-data 2012-12-11 01:59:13 UTC (rev 137236)
+++ trunk/Tools/Scripts/generate-coverage-data 2012-12-11 02:00:26 UTC (rev 137237)
@@ -60,7 +60,7 @@
print "Building and testing\n";
system("Tools/Scripts/build-webkit", "--coverage", @ARGV) == 0 or die;
-system "Tools/Scripts/new-run-webkit-tests", "--no-launch-safari";
+system "Tools/Scripts/new-run-webkit-tests", "--no-show-results";
system "Tools/Scripts/run-_javascript_core-tests", "--coverage", @ARGV;
# Collect the data and generate a report
Modified: trunk/Tools/Scripts/webkit-tools-completion.sh (137236 => 137237)
--- trunk/Tools/Scripts/webkit-tools-completion.sh 2012-12-11 01:59:13 UTC (rev 137236)
+++ trunk/Tools/Scripts/webkit-tools-completion.sh 2012-12-11 02:00:26 UTC (rev 137237)
@@ -111,4 +111,4 @@
complete -o default -W "--continue --fix-merged --help --no-continue --no-warnings --warnings -c -f -h -w" resolve-ChangeLogs
complete -o default -W "--bug --diff --git-commit --git-index --git-reviewer --help --no-update --no-write --open --update --write -d -h -o" prepare-ChangeLog
complete -W "--clean --debug --help -h" build-webkit
-complete -o default -W "--add-platform-exceptions --complex-text --configuration --guard-malloc --help --http --ignore-tests --launch-safari --leaks --merge-leak-depth --new-test-results --no-http --no-launch-safari --no-new-test-results --no-sample-on-timeout --no-strip-editing-callbacks --pixel-tests --platform --port --quiet --random --reset-results --results-directory --reverse --root --sample-on-timeout --singly --skipped --slowest --strict --strip-editing-callbacks --threaded --timeout --tolerance --use-remote-links-to-tests --valgrind --verbose -1 -c -g -h -i -l -m -o -p -q -t -v" run-webkit-tests
+complete -o default -W "--add-platform-exceptions --complex-text --configuration --guard-malloc --help --http --ignore-tests --launch-safari --leaks --merge-leak-depth --new-test-results --no-http --no-show-results --no-new-test-results --no-sample-on-timeout --no-strip-editing-callbacks --pixel-tests --platform --port --quiet --random --reset-results --results-directory --reverse --root --sample-on-timeout --singly --skipped --slowest --strict --strip-editing-callbacks --threaded --timeout --tolerance --use-remote-links-to-tests --valgrind --verbose -1 -c -g -h -i -l -m -o -p -q -t -v" run-webkit-tests
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (137236 => 137237)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2012-12-11 01:59:13 UTC (rev 137236)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2012-12-11 02:00:26 UTC (rev 137237)
@@ -1,9 +1,9 @@
# Copyright (C) 2010 Google Inc. All rights reserved.
-#
+#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
-#
+#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer
[webkit-changes] [137236] trunk/Source/WebCore
Title: [137236] trunk/Source/WebCore Revision 137236 Author commit-qu...@webkit.org Date 2012-12-10 17:59:13 -0800 (Mon, 10 Dec 2012) Log Message Build fix after r137221 https://bugs.webkit.org/show_bug.cgi?id=104617 Unreviewed build fix Patch by KyungTae Kim on 2012-12-10 * html/HTMLPropertiesCollection.cpp: (WebCore::nextNodeWithProperty): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (137235 => 137236) --- trunk/Source/WebCore/ChangeLog 2012-12-11 01:54:16 UTC (rev 137235) +++ trunk/Source/WebCore/ChangeLog 2012-12-11 01:59:13 UTC (rev 137236) @@ -1,3 +1,13 @@ +2012-12-10 KyungTae Kim + +Build fix after r137221 +https://bugs.webkit.org/show_bug.cgi?id=104617 + +Unreviewed build fix + +* html/HTMLPropertiesCollection.cpp: +(WebCore::nextNodeWithProperty): + 2012-12-10 Hajime Morrita [Shadow DOM][Refactoring] HTMLContentElement,HTMLShadowElement::m_registeredWithShadowRoot should be moved to InsertionPoint Modified: trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp (137235 => 137236) --- trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp 2012-12-11 01:54:16 UTC (rev 137235) +++ trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp 2012-12-11 01:59:13 UTC (rev 137236) @@ -77,8 +77,8 @@ // that declares the property. If the property has an itemscope attribute specified then we need // to traverse the next sibling. return previous == ownerNode || (previous->isHTMLElement() && !toHTMLElement(previous)->fastHasAttribute(itemscopeAttr)) -? previous->NodeTraversal::next(rootNode) -: previous->NodeTraversal::nextSkippingChildren(rootNode); +? NodeTraversal::next(previous, rootNode) +: NodeTraversal::nextSkippingChildren(previous, rootNode); } Element* HTMLPropertiesCollection::virtualItemAfter(unsigned& offsetInArray, Element* previousItem) const ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137235] trunk/LayoutTests
Title: [137235] trunk/LayoutTests Revision 137235 Author ad...@chromium.org Date 2012-12-10 17:54:16 -0800 (Mon, 10 Dec 2012) Log Message Rewrite last occurrences of "Image" in TestExpectations to "ImageOnlyFailure". Unreviewed test expectations update. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137234 => 137235) --- trunk/LayoutTests/ChangeLog 2012-12-11 01:48:10 UTC (rev 137234) +++ trunk/LayoutTests/ChangeLog 2012-12-11 01:54:16 UTC (rev 137235) @@ -1,5 +1,12 @@ 2012-12-10 Adam Klein +Rewrite last occurrences of "Image" in TestExpectations to "ImageOnlyFailure". +Unreviewed test expectations update. + +* platform/chromium/TestExpectations: + +2012-12-10 Adam Klein + Expand flakiness of move-by-line-001.html. Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137234 => 137235) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 01:48:10 UTC (rev 137234) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 01:54:16 UTC (rev 137235) @@ -4043,7 +4043,7 @@ webkit.org/b/79446 svg/repaint/image-with-clip-path.svg [ Pass ImageOnlyFailure ] -# Image is incorrect: feSpecularLighting sample has a Y-flip. +# ImageOnlyFailure is incorrect: feSpecularLighting sample has a Y-flip. webkit.org/b/104289 css3/filters/effect-reference-hw.html [ Failure ImageOnlyFailure ] # Only ready for JSC so far, not fixed in v8 yet. @@ -4092,11 +4092,11 @@ webkit.org/b/90022 fast/canvas/canvas-as-image-hidpi.html [ WontFix ] webkit.org/b/90022 platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-hidpi.html [ WontFix ] webkit.org/b/101986 [ Linux Win ] platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html [ Text ] -webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-3.html [ Pass Image ] -webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-origins.html [ Pass Image ] -webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Pass Image ] -webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html [ Pass Image ] -webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping.html [ Pass Image ] +webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-3.html [ Pass ImageOnlyFailure ] +webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-origins.html [ Pass ImageOnlyFailure ] +webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Pass ImageOnlyFailure ] +webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html [ Pass ImageOnlyFailure ] +webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping.html [ Pass ImageOnlyFailure ] webkit.org/b/102131 [ Win ] fast/workers/worker-exception-during-navigation.html [ Pass Crash ] webkit.org/b/102264 [ Debug ] css3/filters/custom/custom-filter-property-computed-style.html [ Pass Timeout ] webkit.org/b/102277 fast/events/frame-scroll-fake-mouse-move.html [ Pass Text ] @@ -4107,7 +4107,6 @@ # This test is consistently leaking state into the next test. webkit.org/b/85522 http/tests/security/sandboxed-iframe-form-top.html [ Skip ] -webkit.org/b/102542 [ Win7 ] platform/chromium/virtual/softwarecompositing/checkerboard.html [ Image ] webkit.org/b/102542 [ Linux Mac Win ] compositing/checkerboard.html [ ImageOnlyFailure ] webkit.org/b/102724 [ Linux ] svg/carto.net/colourpicker.svg [ ImageOnlyFailure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137234] trunk/Tools
Title: [137234] trunk/Tools
Revision 137234
Author dpra...@chromium.org
Date 2012-12-10 17:48:10 -0800 (Mon, 10 Dec 2012)
Log Message
nrwt: fix mapping of AUDIO onto FAIL when printing unexpected results
https://bugs.webkit.org/show_bug.cgi?id=104597
Reviewed by Ojan Vafai.
This was broken in the recent printer refactoring.
* Scripts/webkitpy/layout_tests/views/buildbot_results.py:
(BuildBotPrinter.print_unexpected_results.add_result.is_expected):
* Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
(BuildBotPrinterTests.get_result):
(BuildBotPrinterTests.test_print_unexpected_results):
(BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
(BuildBotPrinterTests):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py
trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (137233 => 137234)
--- trunk/Tools/ChangeLog 2012-12-11 01:42:16 UTC (rev 137233)
+++ trunk/Tools/ChangeLog 2012-12-11 01:48:10 UTC (rev 137234)
@@ -1,5 +1,22 @@
2012-12-10 Dirk Pranke
+nrwt: fix mapping of AUDIO onto FAIL when printing unexpected results
+https://bugs.webkit.org/show_bug.cgi?id=104597
+
+Reviewed by Ojan Vafai.
+
+This was broken in the recent printer refactoring.
+
+* Scripts/webkitpy/layout_tests/views/buildbot_results.py:
+(BuildBotPrinter.print_unexpected_results.add_result.is_expected):
+* Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
+(BuildBotPrinterTests.get_result):
+(BuildBotPrinterTests.test_print_unexpected_results):
+(BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
+(BuildBotPrinterTests):
+
+2012-12-10 Dirk Pranke
+
old-run-webkit-tests: add --show-results properly
https://bugs.webkit.org/show_bug.cgi?id=104608
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py (137233 => 137234)
--- trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py 2012-12-11 01:42:16 UTC (rev 137233)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py 2012-12-11 01:48:10 UTC (rev 137234)
@@ -102,7 +102,7 @@
expected = results['expected'].split(" ")
def is_expected(result):
-return (result in expected) or (result in ('TEXT', 'IMAGE+TEXT') and 'FAIL' in expected)
+return (result in expected) or (result in ('AUDIO', 'TEXT', 'IMAGE+TEXT') and 'FAIL' in expected)
if all(is_expected(actual_result) for actual_result in actual):
# Don't print anything for tests that ran as expected.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py (137233 => 137234)
--- trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py 2012-12-11 01:42:16 UTC (rev 137233)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py 2012-12-11 01:48:10 UTC (rev 137234)
@@ -58,6 +58,8 @@
failures = [test_failures.FailureTimeout()]
elif result_type == test_expectations.CRASH:
failures = [test_failures.FailureCrash()]
+elif result_type == test_expectations.AUDIO:
+failures = [test_failures.FailureAudioMismatch()]
return test_results.TestResult(test_name, failures=failures, test_run_time=run_time)
def get_result_summary(self, port, test_names, expectations_str):
@@ -78,7 +80,7 @@
#
# FIXME: Plus, the fact that we're having to call into
# run_webkit_tests is clearly a layering inversion.
-tests = ['passes/text.html', 'failures/expected/timeout.html', 'failures/expected/crash.html']
+tests = ['passes/text.html', 'failures/expected/timeout.html', 'failures/expected/crash.html', 'failures/expected/audio.html']
expectations = ''
def get_unexpected_results(expected, passing, flaky):
@@ -101,20 +103,24 @@
paths, rs, exp = self.get_result_summary(port, tests, expectations)
if expected:
rs.add(self.get_result('passes/text.html', test_expectations.PASS), expected, test_is_slow)
+rs.add(self.get_result('failures/expected/audio.html', test_expectations.AUDIO), expected, test_is_slow)
rs.add(self.get_result('failures/expected/timeout.html', test_expectations.TIMEOUT), expected, test_is_slow)
rs.add(self.get_result('failures/expected/crash.html', test_expectations.CRASH), expected, test_is_slow)
elif passing:
rs.add(self.get_result('passes/text.html'), expected, test_is_slow)
+rs.add(self.get_result('failures/expected/audio.html'), expected, test_is_slow)
rs.add(self.get_result('failures/expected/timeout.html'), expected, test_is_slow)
[webkit-changes] [137233] trunk/Source/WebCore
Title: [137233] trunk/Source/WebCore
Revision 137233
Author morr...@google.com
Date 2012-12-10 17:42:16 -0800 (Mon, 10 Dec 2012)
Log Message
[Shadow DOM][Refactoring] HTMLContentElement,HTMLShadowElement::m_registeredWithShadowRoot should be moved to InsertionPoint
https://bugs.webkit.org/show_bug.cgi?id=104516
Reviewed by Dimitri Glazkov.
This change pulls duplicated code in removedFrom() and
insertedInto() of both both HTMLShadowElement and
HTMLContentElement to their super class InsertionPoint.
This is a part of effor that encapsulate node distribution algorithm to
ContentDistributor and its family.
No new tests, no behavior change.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::registerInsertionPoint): Added.
(WebCore::ShadowRoot::unregisterInsertionPoint): Added.
* dom/ShadowRoot.h:
(ShadowRoot):
* html/shadow/ContentDistributor.cpp:
(WebCore::ShadowRootContentDistributionData::regiterInsertionPoint): Generalized two methods for and .
(WebCore):
(WebCore::ShadowRootContentDistributionData::unregisterInsertionPoint): Ditto.
* html/shadow/ContentDistributor.h:
(ShadowRootContentDistributionData):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::HTMLContentElement):
* html/shadow/HTMLContentElement.h:
* html/shadow/HTMLShadowElement.cpp:
(WebCore::HTMLShadowElement::HTMLShadowElement):
* html/shadow/HTMLShadowElement.h:
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::insertedInto): Pulled up from subclasses
(WebCore::InsertionPoint::removedFrom): Pulled up from subclasses
* html/shadow/InsertionPoint.h:
(InsertionPoint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/dom/ShadowRoot.h
trunk/Source/WebCore/html/shadow/ContentDistributor.cpp
trunk/Source/WebCore/html/shadow/ContentDistributor.h
trunk/Source/WebCore/html/shadow/HTMLContentElement.cpp
trunk/Source/WebCore/html/shadow/HTMLContentElement.h
trunk/Source/WebCore/html/shadow/HTMLShadowElement.cpp
trunk/Source/WebCore/html/shadow/HTMLShadowElement.h
trunk/Source/WebCore/html/shadow/InsertionPoint.cpp
trunk/Source/WebCore/html/shadow/InsertionPoint.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (137232 => 137233)
--- trunk/Source/WebCore/ChangeLog 2012-12-11 01:40:46 UTC (rev 137232)
+++ trunk/Source/WebCore/ChangeLog 2012-12-11 01:42:16 UTC (rev 137233)
@@ -1,3 +1,43 @@
+2012-12-10 Hajime Morrita
+
+[Shadow DOM][Refactoring] HTMLContentElement,HTMLShadowElement::m_registeredWithShadowRoot should be moved to InsertionPoint
+https://bugs.webkit.org/show_bug.cgi?id=104516
+
+Reviewed by Dimitri Glazkov.
+
+This change pulls duplicated code in removedFrom() and
+insertedInto() of both both HTMLShadowElement and
+HTMLContentElement to their super class InsertionPoint.
+
+This is a part of effor that encapsulate node distribution algorithm to
+ContentDistributor and its family.
+
+No new tests, no behavior change.
+
+* dom/ShadowRoot.cpp:
+(WebCore::ShadowRoot::registerInsertionPoint): Added.
+(WebCore::ShadowRoot::unregisterInsertionPoint): Added.
+* dom/ShadowRoot.h:
+(ShadowRoot):
+* html/shadow/ContentDistributor.cpp:
+(WebCore::ShadowRootContentDistributionData::regiterInsertionPoint): Generalized two methods for and .
+(WebCore):
+(WebCore::ShadowRootContentDistributionData::unregisterInsertionPoint): Ditto.
+* html/shadow/ContentDistributor.h:
+(ShadowRootContentDistributionData):
+* html/shadow/HTMLContentElement.cpp:
+(WebCore::HTMLContentElement::HTMLContentElement):
+* html/shadow/HTMLContentElement.h:
+* html/shadow/HTMLShadowElement.cpp:
+(WebCore::HTMLShadowElement::HTMLShadowElement):
+* html/shadow/HTMLShadowElement.h:
+* html/shadow/InsertionPoint.cpp:
+(WebCore::InsertionPoint::InsertionPoint):
+(WebCore::InsertionPoint::insertedInto): Pulled up from subclasses
+(WebCore::InsertionPoint::removedFrom): Pulled up from subclasses
+* html/shadow/InsertionPoint.h:
+(InsertionPoint):
+
2012-12-10 Jon Lee
Keep track of plug-in snapshots clicked by user
Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (137232 => 137233)
--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-12-11 01:40:46 UTC (rev 137232)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-12-11 01:42:16 UTC (rev 137233)
@@ -358,14 +358,14 @@
return m_distributionData.get();
}
-void ShadowRoot::registerShadowElement()
+void ShadowRoot::registerInsertionPoint(InsertionPoint* point)
{
-ensureDistributionData()->incrementNumberOfShadowElementChildren();
+ensureDistributionData()->regiterInsertionPoint(this, point);
}
-void ShadowRoot::unregisterShadowElement()
+void ShadowRoot::unregisterInsertionPoint(InsertionPoint* point)
{
-distrib
[webkit-changes] [137232] trunk/LayoutTests
Title: [137232] trunk/LayoutTests Revision 137232 Author ad...@chromium.org Date 2012-12-10 17:40:46 -0800 (Mon, 10 Dec 2012) Log Message Expand flakiness of move-by-line-001.html. Unreviewed gardening. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137231 => 137232) --- trunk/LayoutTests/ChangeLog 2012-12-11 01:35:28 UTC (rev 137231) +++ trunk/LayoutTests/ChangeLog 2012-12-11 01:40:46 UTC (rev 137232) @@ -1,3 +1,10 @@ +2012-12-10 Adam Klein + +Expand flakiness of move-by-line-001.html. +Unreviewed gardening. + +* platform/chromium/TestExpectations: + 2012-12-10 Aaron Colwell Temporarily disable video-media-source-seek.html & video-media-source-state-changes.html Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137231 => 137232) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 01:35:28 UTC (rev 137231) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 01:40:46 UTC (rev 137232) @@ -3677,7 +3677,8 @@ webkit.org/b/94017 [ Win ] css2.1/20110323/c541-word-sp-000.htm [ ImageOnlyFailure ] webkit.org/b/94059 [ Debug ] editing/selection/move-by-line-001.html [ Failure Pass ] -webkit.org/b/94059 [ Lion Release ] editing/selection/move-by-line-001.html [ Failure Pass ] +webkit.org/b/94059 [ Linux Release ] editing/selection/move-by-line-001.html [ Failure Pass ] +webkit.org/b/94059 [ Lion Release ] editing/selection/move-by-line-001.html [ Failure ImageOnlyFailure Pass ] webkit.org/b/94078 [ Win Release ] http/tests/inspector/web-socket-frame-error.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137231] trunk/LayoutTests
Title: [137231] trunk/LayoutTests Revision 137231 Author acolw...@chromium.org Date 2012-12-10 17:35:28 -0800 (Mon, 10 Dec 2012) Log Message Temporarily disable video-media-source-seek.html & video-media-source-state-changes.html https://bugs.webkit.org/show_bug.cgi?id=104584 Reviewed by Dirk Pranke. Changes in Chromium needed for Bug 104581 and Bug 104583 will break these tests so they are being temporarily disabled until the Chromium & WebKit changes are both landed. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137230 => 137231) --- trunk/LayoutTests/ChangeLog 2012-12-11 01:33:15 UTC (rev 137230) +++ trunk/LayoutTests/ChangeLog 2012-12-11 01:35:28 UTC (rev 137231) @@ -1,3 +1,15 @@ +2012-12-10 Aaron Colwell + +Temporarily disable video-media-source-seek.html & video-media-source-state-changes.html +https://bugs.webkit.org/show_bug.cgi?id=104584 + +Reviewed by Dirk Pranke. + +Changes in Chromium needed for Bug 104581 and Bug 104583 will break these tests so they are +being temporarily disabled until the Chromium & WebKit changes are both landed. + +* platform/chromium/TestExpectations: + 2012-12-10 Adam Klein Mark an encrypted media test as failing after http://crrev.com/172175 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137230 => 137231) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 01:33:15 UTC (rev 137230) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 01:35:28 UTC (rev 137231) @@ -3845,7 +3845,10 @@ webkit.org/b/96549 [ Android ] platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html [ ImageOnlyFailure ] webkit.org/b/96628 [ Lion MountainLion ] fast/frames/calculate-order.html [ Failure Pass ] webkit.org/b/96550 http/tests/media/media-source/seek-to-end-after-duration-change.html [ Pass Timeout ] -webkit.org/b/96725 [ Linux Mac Win ] http/tests/media/media-source/video-media-source-state-changes.html [ Pass Timeout ] + +webkit.org/b/104584 http/tests/media/media-source/video-media-source-seek.html [ Skip ] +webkit.org/b/104584 http/tests/media/media-source/video-media-source-state-changes.html [ Skip ] + crbug.com/63921 platform/chromium/virtual/gpu/fast/canvas/canvas-fillPath-shadow.html [ Failure ] webkit.org/b/77550 platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137229] trunk/Source/WebKit2
Title: [137229] trunk/Source/WebKit2
Revision 137229
Author ander...@apple.com
Date 2012-12-10 17:18:03 -0800 (Mon, 10 Dec 2012)
Log Message
Add WKPageSetInvalidMessageFunction stub
https://bugs.webkit.org/show_bug.cgi?id=104614
Reviewed by Mark Rowe.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetInvalidMessageFunction):
* UIProcess/API/C/WKPagePrivate.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137228 => 137229)
--- trunk/Source/WebKit2/ChangeLog 2012-12-11 01:13:19 UTC (rev 137228)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-11 01:18:03 UTC (rev 137229)
@@ -1,3 +1,15 @@
+2012-12-10 Anders Carlsson
+
+Add WKPageSetInvalidMessageFunction stub
+https://bugs.webkit.org/show_bug.cgi?id=104614
+
+
+Reviewed by Mark Rowe.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetInvalidMessageFunction):
+* UIProcess/API/C/WKPagePrivate.h:
+
2012-12-09 Antti Koivisto
Factor node traversal into standalone functions
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (137228 => 137229)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2012-12-11 01:13:19 UTC (rev 137228)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2012-12-11 01:18:03 UTC (rev 137229)
@@ -769,3 +769,8 @@
{
toImpl(pageRef)->setMayStartMediaWhenInWindow(mayStartMedia);
}
+
+void WKPageSetInvalidMessageFunction(WKPageInvalidMessageFunction)
+{
+// FIXME: Remove this function when doing so won't break WebKit nightlies.
+}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h (137228 => 137229)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h 2012-12-11 01:13:19 UTC (rev 137228)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h 2012-12-11 01:18:03 UTC (rev 137229)
@@ -97,6 +97,9 @@
WK_EXPORT WKArrayRef WKPageCopyRelatedPages(WKPageRef page);
+typedef void (*WKPageInvalidMessageFunction)(uint32_t messageID);
+WK_EXPORT void WKPageSetInvalidMessageFunction(WKPageInvalidMessageFunction function);
+
#ifdef __cplusplus
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137228] trunk/Tools
Title: [137228] trunk/Tools
Revision 137228
Author dpra...@chromium.org
Date 2012-12-10 17:13:19 -0800 (Mon, 10 Dec 2012)
Log Message
old-run-webkit-tests: add --show-results properly
https://bugs.webkit.org/show_bug.cgi?id=104608
Reviewed by Eric Seidel.
Rework r137219 / bug 104601 to use the correct perl idiom.
* Scripts/old-run-webkit-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/old-run-webkit-tests
Diff
Modified: trunk/Tools/ChangeLog (137227 => 137228)
--- trunk/Tools/ChangeLog 2012-12-11 01:03:08 UTC (rev 137227)
+++ trunk/Tools/ChangeLog 2012-12-11 01:13:19 UTC (rev 137228)
@@ -1,3 +1,14 @@
+2012-12-10 Dirk Pranke
+
+old-run-webkit-tests: add --show-results properly
+https://bugs.webkit.org/show_bug.cgi?id=104608
+
+Reviewed by Eric Seidel.
+
+Rework r137219 / bug 104601 to use the correct perl idiom.
+
+* Scripts/old-run-webkit-tests:
+
2012-12-10 Aaron Colwell
Unreviewed. Adding Aaron Colwell to the contributor list.
Modified: trunk/Tools/Scripts/old-run-webkit-tests (137227 => 137228)
--- trunk/Tools/Scripts/old-run-webkit-tests 2012-12-11 01:03:08 UTC (rev 137227)
+++ trunk/Tools/Scripts/old-run-webkit-tests 2012-12-11 01:13:19 UTC (rev 137228)
@@ -347,7 +347,6 @@
'merge-leak-depth|m:5' => \$mergeDepth,
'new-test-results!' => \$generateNewResults,
'no-build' => \$noBuildDumpTool,
-'no-show-results' => sub { $launchSafari = 0; },
'nthly=i' => \$testsPerDumpTool,
'pixel-tests|p' => \$pixelTests,
'platform=s' => \$platform,
@@ -360,7 +359,7 @@
'reverse' => \$reverseTests,
'root=s' => \$root,
'sample-on-timeout!' => \$runSample,
-'show-results' => sub { $launchSafari = 1; },
+'show-results!' => \$launchSafari,
'singly|1' => sub { $testsPerDumpTool = 1; },
'skipped=s' => \&validateSkippedArg,
'slowest' => \$report10Slowest,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137227] trunk/Source/WebCore
Title: [137227] trunk/Source/WebCore
Revision 137227
Author an...@apple.com
Date 2012-12-10 17:03:08 -0800 (Mon, 10 Dec 2012)
Log Message
Not reviewed.
Build fix.
* html/HTMLPropertiesCollection.cpp:
(WebCore::nextNodeWithProperty):
* page/TouchDisambiguation.cpp:
(WebCore::boundingBoxForEventNodes):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp
trunk/Source/WebCore/page/TouchDisambiguation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (137226 => 137227)
--- trunk/Source/WebCore/ChangeLog 2012-12-11 01:02:42 UTC (rev 137226)
+++ trunk/Source/WebCore/ChangeLog 2012-12-11 01:03:08 UTC (rev 137227)
@@ -1,3 +1,14 @@
+2012-12-10 Antti Koivisto
+
+Not reviewed.
+
+Build fix.
+
+* html/HTMLPropertiesCollection.cpp:
+(WebCore::nextNodeWithProperty):
+* page/TouchDisambiguation.cpp:
+(WebCore::boundingBoxForEventNodes):
+
2012-12-10 Beth Dakin
https://bugs.webkit.org/show_bug.cgi?id=104602
Modified: trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp (137226 => 137227)
--- trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp 2012-12-11 01:02:42 UTC (rev 137226)
+++ trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp 2012-12-11 01:03:08 UTC (rev 137227)
@@ -39,6 +39,7 @@
#include "HTMLElement.h"
#include "HTMLNames.h"
#include "Node.h"
+#include "NodeTraversal.h"
#include "PropertyNodeList.h"
namespace WebCore {
@@ -77,7 +78,7 @@
// to traverse the next sibling.
return previous == ownerNode || (previous->isHTMLElement() && !toHTMLElement(previous)->fastHasAttribute(itemscopeAttr))
? previous->NodeTraversal::next(rootNode)
-: previous->NodeTraversal::nextSibling(rootNode);
+: previous->NodeTraversal::nextSkippingChildren(rootNode);
}
Element* HTMLPropertiesCollection::virtualItemAfter(unsigned& offsetInArray, Element* previousItem) const
Modified: trunk/Source/WebCore/page/TouchDisambiguation.cpp (137226 => 137227)
--- trunk/Source/WebCore/page/TouchDisambiguation.cpp 2012-12-11 01:02:42 UTC (rev 137226)
+++ trunk/Source/WebCore/page/TouchDisambiguation.cpp 2012-12-11 01:03:08 UTC (rev 137227)
@@ -56,7 +56,7 @@
while (node) {
// Skip the whole sub-tree if the node doesn't propagate events.
if (node != eventNode && node->willRespondToMouseClickEvents()) {
-node = NodeTraversal::nextSibling(node, eventNode);
+node = NodeTraversal::nextSkippingChildren(node, eventNode);
continue;
}
result.unite(node->pixelSnappedBoundingBox());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137226] trunk/Tools
Title: [137226] trunk/Tools
Revision 137226
Author acolw...@chromium.org
Date 2012-12-10 17:02:42 -0800 (Mon, 10 Dec 2012)
Log Message
Unreviewed. Adding Aaron Colwell to the contributor list.
* Scripts/webkitpy/common/config/committers.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/ChangeLog (137225 => 137226)
--- trunk/Tools/ChangeLog 2012-12-11 00:43:37 UTC (rev 137225)
+++ trunk/Tools/ChangeLog 2012-12-11 01:02:42 UTC (rev 137226)
@@ -1,3 +1,9 @@
+2012-12-10 Aaron Colwell
+
+Unreviewed. Adding Aaron Colwell to the contributor list.
+
+* Scripts/webkitpy/common/config/committers.py:
+
2012-12-10 Anders Carlsson
Remove WebKit2 tests on Windows
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (137225 => 137226)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-12-11 00:43:37 UTC (rev 137225)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-12-11 01:02:42 UTC (rev 137226)
@@ -183,6 +183,7 @@
committers_unable_to_review = [
Committer("Aaron Boodman", "a...@chromium.org", "aboodman"),
+Committer("Aaron Colwell", "acolw...@chromium.org", "acolwell"),
Committer("Adam Bergkvist", "adam.bergkv...@ericsson.com", "adambe"),
Committer("Adam Kallai", "ka...@inf.u-szeged.hu", "kadam"),
Committer("Adam Klein", "ad...@chromium.org", "aklein"),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137225] trunk/LayoutTests
Title: [137225] trunk/LayoutTests Revision 137225 Author ad...@chromium.org Date 2012-12-10 16:43:37 -0800 (Mon, 10 Dec 2012) Log Message Mark an encrypted media test as failing after http://crrev.com/172175 Unreviewed gardening. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137224 => 137225) --- trunk/LayoutTests/ChangeLog 2012-12-11 00:32:01 UTC (rev 137224) +++ trunk/LayoutTests/ChangeLog 2012-12-11 00:43:37 UTC (rev 137225) @@ -1,3 +1,10 @@ +2012-12-10 Adam Klein + +Mark an encrypted media test as failing after http://crrev.com/172175 +Unreviewed gardening. + +* platform/chromium/TestExpectations: + 2012-12-10 Min Qin Sending multi-touch events to the same Iframe Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137224 => 137225) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 00:32:01 UTC (rev 137224) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 00:43:37 UTC (rev 137225) @@ -4222,3 +4222,6 @@ # Failing differently since r137152, probably just need rebaselines webkit.org/b/104567 [ XP ] fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html [ Failure ] webkit.org/b/104567 [ XP ] fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html [ Failure ] + +# Broken by Chromium r172175 +crbug.com/165315 media/encrypted-media/encrypted-media-can-play-type-webm.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137224] trunk/Source/WebCore
Title: [137224] trunk/Source/WebCore
Revision 137224
Author bda...@apple.com
Date 2012-12-10 16:32:01 -0800 (Mon, 10 Dec 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=104602
DidHitRelevantRepaintedObjectsAreaThreshold LayoutMilestone fires too
early on some pages with iframes
Reviewed by Simon Fraser.
This change makes it so that any RenderObjects inside iframes are not
considered relevant.
* page/Page.cpp:
(WebCore::Page::addRelevantRepaintedObject):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (137223 => 137224)
--- trunk/Source/WebCore/ChangeLog 2012-12-11 00:21:14 UTC (rev 137223)
+++ trunk/Source/WebCore/ChangeLog 2012-12-11 00:32:01 UTC (rev 137224)
@@ -1,3 +1,16 @@
+2012-12-10 Beth Dakin
+
+https://bugs.webkit.org/show_bug.cgi?id=104602
+DidHitRelevantRepaintedObjectsAreaThreshold LayoutMilestone fires too
+early on some pages with iframes
+
+Reviewed by Simon Fraser.
+
+This change makes it so that any RenderObjects inside iframes are not
+considered relevant.
+* page/Page.cpp:
+(WebCore::Page::addRelevantRepaintedObject):
+
2012-12-10 David Grogan
IndexedDB: Propagate more leveldb errors to script
Modified: trunk/Source/WebCore/page/Page.cpp (137223 => 137224)
--- trunk/Source/WebCore/page/Page.cpp 2012-12-11 00:21:14 UTC (rev 137223)
+++ trunk/Source/WebCore/page/Page.cpp 2012-12-11 00:32:01 UTC (rev 137224)
@@ -1181,11 +1181,17 @@
if (!isCountingRelevantRepaintedObjects())
return;
+// Objects inside sub-frames are not considered to be relevant.
+if (object->document()->frame() != mainFrame())
+return;
+
+RenderView* view = object->view();
+if (!view)
+return;
+
// The objects are only relevant if they are being painted within the viewRect().
-if (RenderView* view = object->view()) {
-if (!objectPaintRect.intersects(pixelSnappedIntRect(view->viewRect(
-return;
-}
+if (!objectPaintRect.intersects(pixelSnappedIntRect(view->viewRect(
+return;
IntRect snappedPaintRect = pixelSnappedIntRect(objectPaintRect);
@@ -1198,10 +1204,6 @@
}
m_relevantPaintedRegion.unite(snappedPaintRect);
-
-RenderView* view = object->view();
-if (!view)
-return;
float viewArea = view->viewRect().width() * view->viewRect().height();
float ratioOfViewThatIsPainted = m_relevantPaintedRegion.totalArea() / viewArea;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137223] trunk/Source
Title: [137223] trunk/Source
Revision 137223
Author dgro...@chromium.org
Date 2012-12-10 16:21:14 -0800 (Mon, 10 Dec 2012)
Log Message
IndexedDB: Propagate more leveldb errors to script
https://bugs.webkit.org/show_bug.cgi?id=104422
Reviewed by Tony Chang.
Source/WebCore:
These are the last places that ignore leveldb errors that can get the
usual ok/found treatment.
Nothing called getBool, so it is deleted.
* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore):
(WebCore::getInt):
(WebCore::isSchemaKnown):
(WebCore::setUpMetadata):
(WebCore::getMaxObjectStoreId):
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::getNewDatabaseId):
(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
(WebCore::setMaxObjectStoreId):
(WebCore::getNewVersionNumber):
(WebCore::IDBBackingStore::putRecord):
(WebCore::setMaxIndexId):
* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):
Source/WebKit/chromium:
* tests/IDBFakeBackingStore.h:
Delete method override that doesn't match new signature.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.h
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/IDBFakeBackingStore.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (137222 => 137223)
--- trunk/Source/WebCore/ChangeLog 2012-12-11 00:17:53 UTC (rev 137222)
+++ trunk/Source/WebCore/ChangeLog 2012-12-11 00:21:14 UTC (rev 137223)
@@ -1,3 +1,35 @@
+2012-12-10 David Grogan
+
+IndexedDB: Propagate more leveldb errors to script
+https://bugs.webkit.org/show_bug.cgi?id=104422
+
+Reviewed by Tony Chang.
+
+These are the last places that ignore leveldb errors that can get the
+usual ok/found treatment.
+
+Nothing called getBool, so it is deleted.
+
+* Modules/indexeddb/IDBBackingStore.cpp:
+(WebCore):
+(WebCore::getInt):
+(WebCore::isSchemaKnown):
+(WebCore::setUpMetadata):
+(WebCore::getMaxObjectStoreId):
+(WebCore::IDBBackingStore::open):
+(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
+(WebCore::getNewDatabaseId):
+(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
+(WebCore::setMaxObjectStoreId):
+(WebCore::getNewVersionNumber):
+(WebCore::IDBBackingStore::putRecord):
+(WebCore::setMaxIndexId):
+* Modules/indexeddb/IDBBackingStore.h:
+(IDBBackingStore):
+* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
+(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
+(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):
+
2012-12-09 Antti Koivisto
Factor node traversal into standalone functions
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp (137222 => 137223)
--- trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp 2012-12-11 00:17:53 UTC (rev 137222)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp 2012-12-11 00:21:14 UTC (rev 137223)
@@ -68,6 +68,10 @@
IDBLevelDBBackingStoreReadErrorKeyExistsInIndex,
IDBLevelDBBackingStoreReadErrorVersionExists,
IDBLevelDBBackingStoreReadErrorDeleteObjectStore,
+IDBLevelDBBackingStoreReadErrorSetMaxObjectStoreId,
+IDBLevelDBBackingStoreReadErrorSetMaxIndexId,
+IDBLevelDBBackingStoreReadErrorGetNewDatabaseId,
+IDBLevelDBBackingStoreReadErrorGetNewVersionNumber,
IDBLevelDBBackingStoreInternalErrorMax,
};
static inline void recordInternalError(IDBLevelDBBackingStoreInternalErrorType type)
@@ -84,32 +88,20 @@
recordInternalError(type); \
} while (0)
-template
-static bool getBool(DBOrTransaction* db, const LevelDBSlice& key, bool& foundBool)
-{
-Vector result;
-if (!db->get(key, result))
-return false;
-
-foundBool = decodeBool(result.begin(), result.end());
-return true;
-}
-
static void putBool(LevelDBTransaction* transaction, const LevelDBSlice& key, bool value)
{
transaction->put(key, encodeBool(value));
}
template
-static bool getInt(DBOrTransaction* db, const LevelDBSlice& key, int64_t& foundInt)
+static bool getInt(DBOrTransaction* db, const LevelDBSlice& key, int64_t& foundInt, bool& found)
{
Vector result;
-bool found = false;
bool ok = db->safeGet(key, result, found);
-// FIXME: Notify the caller if !ok.
-ASSERT_UNUSED(ok, ok);
+if (!ok)
+return false;
if (!found)
-return false;
+return true;
foundInt = decodeInt(result.begin(), result.end());
return true;
@@ -185,26 +177,42 @@
// 1 - Adds UserIntVersion to Database
[webkit-changes] [137220] trunk
Title: [137220] trunk Revision 137220 Author commit-qu...@webkit.org Date 2012-12-10 16:08:09 -0800 (Mon, 10 Dec 2012) Log Message Sending multi-touch events to the same Iframe https://bugs.webkit.org/show_bug.cgi?id=97973 Patch by Min Qin on 2012-12-10 Reviewed by Dimitri Glazkov. Source/WebCore: Multi-Touch in different iframe can give both documents access to each other. This could cause cross-origin access. To solve this, all the touch events should be sent to the iframe where the first touchstart happens. Test: fast/events/touch/multi-touch-inside-iframes.html fast/events/touch/multi-touch-inside-nested-iframes.html * page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): * page/EventHandler.h: LayoutTests: Check that all multi-touch events are sent to the same iframe. * fast/events/touch/multi-touch-inside-iframes-expected.txt: Added. * fast/events/touch/multi-touch-inside-iframes.html: Added. * fast/events/touch/resources/multi-touch-inside-iframes2.html: Added. * fast/events/touch/multi-touch-inside-nested-iframes-expected.txt: Added. * fast/events/touch/multi-touch-inside-nested-iframes.html: Added. * fast/events/touch/resources/multi-touch-inside-nested-iframes2.html: Added. * fast/events/touch/resources/multi-touch-inside-nested-iframes3.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/EventHandler.h Added Paths trunk/LayoutTests/fast/events/touch/multi-touch-inside-iframes-expected.txt trunk/LayoutTests/fast/events/touch/multi-touch-inside-iframes.html trunk/LayoutTests/fast/events/touch/multi-touch-inside-nested-iframes-expected.txt trunk/LayoutTests/fast/events/touch/multi-touch-inside-nested-iframes.html trunk/LayoutTests/fast/events/touch/resources/multi-touch-inside-iframes2.html trunk/LayoutTests/fast/events/touch/resources/multi-touch-inside-nested-iframes2.html trunk/LayoutTests/fast/events/touch/resources/multi-touch-inside-nested-iframes3.html Diff Modified: trunk/LayoutTests/ChangeLog (137219 => 137220) --- trunk/LayoutTests/ChangeLog 2012-12-10 23:56:02 UTC (rev 137219) +++ trunk/LayoutTests/ChangeLog 2012-12-11 00:08:09 UTC (rev 137220) @@ -1,3 +1,20 @@ +2012-12-10 Min Qin + +Sending multi-touch events to the same Iframe +https://bugs.webkit.org/show_bug.cgi?id=97973 + +Reviewed by Dimitri Glazkov. + +Check that all multi-touch events are sent to the same iframe. + +* fast/events/touch/multi-touch-inside-iframes-expected.txt: Added. +* fast/events/touch/multi-touch-inside-iframes.html: Added. +* fast/events/touch/resources/multi-touch-inside-iframes2.html: Added. +* fast/events/touch/multi-touch-inside-nested-iframes-expected.txt: Added. +* fast/events/touch/multi-touch-inside-nested-iframes.html: Added. +* fast/events/touch/resources/multi-touch-inside-nested-iframes2.html: Added. +* fast/events/touch/resources/multi-touch-inside-nested-iframes3.html: Added. + 2012-12-10 Simon Fraser When converting a layer into a tiled layer, ensure that we update the visible rect Added: trunk/LayoutTests/fast/events/touch/multi-touch-inside-iframes-expected.txt (0 => 137220) --- trunk/LayoutTests/fast/events/touch/multi-touch-inside-iframes-expected.txt (rev 0) +++ trunk/LayoutTests/fast/events/touch/multi-touch-inside-iframes-expected.txt 2012-12-11 00:08:09 UTC (rev 137220) @@ -0,0 +1,70 @@ + +Test multi-touch is sent to the same iframe. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +First touch is on iframe1. +PASS document.elementFromPoint(101, 101).id is "iframe1" +PASS ev.type is "touchstart" +PASS touchreceiver is "iframe1" +PASS ev.changedTouches.length is 1 +PASS ev.touches.length is 1 +PASS ev.targetTouches.length is 1 +PASS ev.touches[0].pageX is 50 +PASS ev.touches[0].pageY is 50 +PASS ev.touches[0].target.ownerDocument.title is "iframe1" +PASS ev.changedTouches[0].target.ownerDocument.title is "iframe1" +PASS ev.targetTouches[0].target.ownerDocument.title is "iframe1" + +Second touch is on iframe2, nothing should happen. +PASS document.elementFromPoint(251, 101).id is "iframe2" + +Moves the first touch outside iframe1. +PASS ev.type is "touchmove" +PASS touchreceiver is "iframe1" +PASS ev.changedTouches.length is 1 +PASS ev.touches.length is 1 +PASS ev.targetTouches.length is 1 +PASS ev.touches[0].pageX is 150 +PASS ev.touches[0].pageY is 150 +PASS ev.touches[0].target.ownerDocument.title is "iframe1" +PASS ev.changedTouches[0].target.ownerDocument.title is "iframe1" +PASS ev.targetTouches[0].target.ownerDocument.title is "iframe1" + +Release the first touch. +PASS ev.type is "touchend" +PASS touchreceiver is "iframe1" +PASS ev.changedTouches.length is 1 +PASS ev.touches.length is 0 +PASS ev.targetTouches.length is 0 +PASS ev.changedTouches[0].target.ownerDo
[webkit-changes] [137219] trunk/Tools
Title: [137219] trunk/Tools
Revision 137219
Author dpra...@chromium.org
Date 2012-12-10 15:56:02 -0800 (Mon, 10 Dec 2012)
Log Message
old-run-webkit-tests: support --no-show-results for compatibility w/ NRWT
https://bugs.webkit.org/show_bug.cgi?id=104601
Reviewed by Eric Siedel.
This flag is being added so we can move all of the calling scripts
over to using --no-show-results instead of --no-launch-safari.
* Scripts/old-run-webkit-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/old-run-webkit-tests
Diff
Modified: trunk/Tools/ChangeLog (137218 => 137219)
--- trunk/Tools/ChangeLog 2012-12-10 23:55:07 UTC (rev 137218)
+++ trunk/Tools/ChangeLog 2012-12-10 23:56:02 UTC (rev 137219)
@@ -1,5 +1,17 @@
2012-12-10 Dirk Pranke
+old-run-webkit-tests: support --no-show-results for compatibility w/ NRWT
+https://bugs.webkit.org/show_bug.cgi?id=104601
+
+Reviewed by Eric Siedel.
+
+This flag is being added so we can move all of the calling scripts
+over to using --no-show-results instead of --no-launch-safari.
+
+* Scripts/old-run-webkit-tests:
+
+2012-12-10 Dirk Pranke
+
nrwt: use the default logic for skipping platform-specific tests for chromium
https://bugs.webkit.org/show_bug.cgi?id=104403
Modified: trunk/Tools/Scripts/old-run-webkit-tests (137218 => 137219)
--- trunk/Tools/Scripts/old-run-webkit-tests 2012-12-10 23:55:07 UTC (rev 137218)
+++ trunk/Tools/Scripts/old-run-webkit-tests 2012-12-10 23:56:02 UTC (rev 137219)
@@ -293,6 +293,7 @@
-i|--ignore-tests Comma-separated list of directories or tests to ignore
--iterations n Number of times to run the set of tests (e.g. ABCABCABC)
--[no-]launch-safariLaunch (or do not launch) Safari to display test results (default: $launchSafariDefault)
+ --[no-]show-results Same as --[no-]launch-safari
-l|--leaks Enable leaks checking
--[no-]new-test-results Generate results for new tests
--nthly n Restart DumpRenderTree every n tests (default: $testsPerDumpTool)
@@ -346,6 +347,7 @@
'merge-leak-depth|m:5' => \$mergeDepth,
'new-test-results!' => \$generateNewResults,
'no-build' => \$noBuildDumpTool,
+'no-show-results' => sub { $launchSafari = 0; },
'nthly=i' => \$testsPerDumpTool,
'pixel-tests|p' => \$pixelTests,
'platform=s' => \$platform,
@@ -358,6 +360,7 @@
'reverse' => \$reverseTests,
'root=s' => \$root,
'sample-on-timeout!' => \$runSample,
+'show-results' => sub { $launchSafari = 1; },
'singly|1' => sub { $testsPerDumpTool = 1; },
'skipped=s' => \&validateSkippedArg,
'slowest' => \$report10Slowest,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137218] trunk/Source/WebCore
Title: [137218] trunk/Source/WebCore
Revision 137218
Author commit-qu...@webkit.org
Date 2012-12-10 15:55:07 -0800 (Mon, 10 Dec 2012)
Log Message
[soup] Fix build warning in ResourceHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=104605
Patch by KyungTae Kim on 2012-12-10
Reviewed by Martin Robinson.
The nextMultipartResponsePartCallback has unused parameter 'source',
comment out it to fix 'unused parameter' build warning.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::nextMultipartResponsePartCallback):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (137217 => 137218)
--- trunk/Source/WebCore/ChangeLog 2012-12-10 23:43:55 UTC (rev 137217)
+++ trunk/Source/WebCore/ChangeLog 2012-12-10 23:55:07 UTC (rev 137218)
@@ -1,3 +1,16 @@
+2012-12-10 KyungTae Kim
+
+[soup] Fix build warning in ResourceHandleSoup.cpp
+https://bugs.webkit.org/show_bug.cgi?id=104605
+
+Reviewed by Martin Robinson.
+
+The nextMultipartResponsePartCallback has unused parameter 'source',
+comment out it to fix 'unused parameter' build warning.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::nextMultipartResponsePartCallback):
+
2012-12-10 Simon Fraser
Fix frame border painting in tiled drawing mode
Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (137217 => 137218)
--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2012-12-10 23:43:55 UTC (rev 137217)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2012-12-10 23:55:07 UTC (rev 137218)
@@ -491,7 +491,7 @@
return true;
}
-static void nextMultipartResponsePartCallback(GObject* source, GAsyncResult* result, gpointer data)
+static void nextMultipartResponsePartCallback(GObject* /*source*/, GAsyncResult* result, gpointer data)
{
RefPtr handle = static_cast(data);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137217] trunk/Source/WebCore
Title: [137217] trunk/Source/WebCore
Revision 137217
Author simon.fra...@apple.com
Date 2012-12-10 15:43:55 -0800 (Mon, 10 Dec 2012)
Log Message
Fix frame border painting in tiled drawing mode
https://bugs.webkit.org/show_bug.cgi?id=104453
Reviewed by Dan Bernstein.
Frame borders were not correctly invalidated when in tiled drawing mode, because
RenderFrameSet::layout() invalidated directly on the view, which skips the tile
cache.
Fix by invalidating like all other renderers, via the repaint container.
Also, the layer transform should be updated before the invalidation, and
we make use of RenderObject::updateLayerTransform() which has the same behavior
as the old code.
Attempts to make a layout test failed. Resizing composited framesets repainted
via layer resizing, and an attempt to make a ref test in tiled drawing mode
failed (the test passed without the patch).
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFrameSet.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (137216 => 137217)
--- trunk/Source/WebCore/ChangeLog 2012-12-10 23:43:50 UTC (rev 137216)
+++ trunk/Source/WebCore/ChangeLog 2012-12-10 23:43:55 UTC (rev 137217)
@@ -1,5 +1,30 @@
2012-12-10 Simon Fraser
+Fix frame border painting in tiled drawing mode
+https://bugs.webkit.org/show_bug.cgi?id=104453
+
+
+Reviewed by Dan Bernstein.
+
+Frame borders were not correctly invalidated when in tiled drawing mode, because
+RenderFrameSet::layout() invalidated directly on the view, which skips the tile
+cache.
+
+Fix by invalidating like all other renderers, via the repaint container.
+
+Also, the layer transform should be updated before the invalidation, and
+we make use of RenderObject::updateLayerTransform() which has the same behavior
+as the old code.
+
+Attempts to make a layout test failed. Resizing composited framesets repainted
+via layer resizing, and an attempt to make a ref test in tiled drawing mode
+failed (the test passed without the patch).
+
+* rendering/RenderFrameSet.cpp:
+(WebCore::RenderFrameSet::layout):
+
+2012-12-10 Simon Fraser
+
When converting a layer into a tiled layer, ensure that we update the visible rect
https://bugs.webkit.org/show_bug.cgi?id=104467
Modified: trunk/Source/WebCore/rendering/RenderFrameSet.cpp (137216 => 137217)
--- trunk/Source/WebCore/rendering/RenderFrameSet.cpp 2012-12-10 23:43:50 UTC (rev 137216)
+++ trunk/Source/WebCore/rendering/RenderFrameSet.cpp 2012-12-10 23:43:55 UTC (rev 137217)
@@ -466,8 +466,11 @@
bool doFullRepaint = selfNeedsLayout() && checkForRepaintDuringLayout();
LayoutRect oldBounds;
-if (doFullRepaint)
-oldBounds = absoluteClippedOverflowRect();
+RenderLayerModelObject* repaintContainer = 0;
+if (doFullRepaint) {
+repaintContainer = containerForRepaint();
+oldBounds = clippedOverflowRectForRepaint(repaintContainer);
+}
if (!parent()->isFrameSet() && !document()->printing()) {
setWidth(view()->viewWidth());
@@ -495,19 +498,15 @@
computeEdgeInfo();
+updateLayerTransform();
+
if (doFullRepaint) {
-view()->repaintViewRectangle(oldBounds);
-LayoutRect newBounds = absoluteClippedOverflowRect();
+repaintUsingContainer(repaintContainer, pixelSnappedIntRect(oldBounds));
+LayoutRect newBounds = clippedOverflowRectForRepaint(repaintContainer);
if (newBounds != oldBounds)
-view()->repaintViewRectangle(newBounds);
+repaintUsingContainer(repaintContainer, pixelSnappedIntRect(newBounds));
}
-// If this FrameSet has a transform matrix then we need to recompute it
-// because the transform origin is a function the size of the RenderFrameSet
-// which may not be computed until it is attached to the render tree.
-if (layer() && hasTransform())
-layer()->updateTransform();
-
setNeedsLayout(false);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137216] trunk
Title: [137216] trunk
Revision 137216
Author simon.fra...@apple.com
Date 2012-12-10 15:43:50 -0800 (Mon, 10 Dec 2012)
Log Message
When converting a layer into a tiled layer, ensure that we update the visible rect
https://bugs.webkit.org/show_bug.cgi?id=104467
Reviewed by Darin Adler.
Source/WebCore:
When a GraphicsLayerCA toggles to use a TileCache, we have to ensure that the
layer's visible rect (which is used to ensure tile coverage) is updated in
the same commit. Otherwise we can get blank layers until something else causes
the visible rect to be updated.
Test: compositing/tiling/tiled-layer-resize.html
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::dumpAdditionalProperties): With the debug flag, dump the TiledBacking
address for ease of debugging.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Set the VisibleRectChanged bit in
m_uncommittedChanges if we've just switched to a tiled layer.
LayoutTests:
Test that resizes a layer over the tiled layer threshold, then dumps layer data.
Mac-specific results added because only Mac dumps tile cache info.
* compositing/tiling/tiled-layer-resize-expected.txt: Added.
* compositing/tiling/tiled-layer-resize.html: Added.
* platform/mac/compositing/tiling/tiled-layer-resize-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
Added Paths
trunk/LayoutTests/compositing/tiling/tiled-layer-resize-expected.txt
trunk/LayoutTests/compositing/tiling/tiled-layer-resize.html
trunk/LayoutTests/platform/mac/compositing/tiling/tiled-layer-resize-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (137215 => 137216)
--- trunk/LayoutTests/ChangeLog 2012-12-10 23:43:43 UTC (rev 137215)
+++ trunk/LayoutTests/ChangeLog 2012-12-10 23:43:50 UTC (rev 137216)
@@ -1,5 +1,20 @@
2012-12-10 Simon Fraser
+When converting a layer into a tiled layer, ensure that we update the visible rect
+https://bugs.webkit.org/show_bug.cgi?id=104467
+
+Reviewed by Darin Adler.
+
+Test that resizes a layer over the tiled layer threshold, then dumps layer data.
+
+Mac-specific results added because only Mac dumps tile cache info.
+
+* compositing/tiling/tiled-layer-resize-expected.txt: Added.
+* compositing/tiling/tiled-layer-resize.html: Added.
+* platform/mac/compositing/tiling/tiled-layer-resize-expected.txt: Added.
+
+2012-12-10 Simon Fraser
+
Don't unconditionally repaint compositing layers when their size changes
https://bugs.webkit.org/show_bug.cgi?id=104461
Added: trunk/LayoutTests/compositing/tiling/tiled-layer-resize-expected.txt (0 => 137216)
--- trunk/LayoutTests/compositing/tiling/tiled-layer-resize-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/tiling/tiled-layer-resize-expected.txt 2012-12-10 23:43:50 UTC (rev 137216)
@@ -0,0 +1,17 @@
+Tiled layer
+(GraphicsLayer
+ (bounds 808.00 2121.00)
+ (children 1
+(GraphicsLayer
+ (bounds 808.00 2121.00)
+ (children 1
+(GraphicsLayer
+ (position 8.00 8.00)
+ (bounds 800.00 2100.00)
+ (drawsContent 1)
+)
+ )
+)
+ )
+)
+
Property changes on: trunk/LayoutTests/compositing/tiling/tiled-layer-resize-expected.txt
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Added: trunk/LayoutTests/compositing/tiling/tiled-layer-resize.html (0 => 137216)
--- trunk/LayoutTests/compositing/tiling/tiled-layer-resize.html (rev 0)
+++ trunk/LayoutTests/compositing/tiling/tiled-layer-resize.html 2012-12-10 23:43:50 UTC (rev 137216)
@@ -0,0 +1,36 @@
+
+
+
+
+
+#tiled {
+width: 800px;
+height: 1800px;
+background-color: silver;
+-webkit-transform: translateZ(00);
+}
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function doTest()
+{
+// Force compositing update before changing layer size.
+if (window.internals)
+window.internals.layerTreeAsText(document);
+
+document.getElementById('tiled').style.height = '2100px';
+
+if (window.internals)
+document.getElementById('layers').textContent = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_TILE_CACHES);
+}
+window.addEventListener('load', doTest, false);
+
+
+
+
+Tiled layer
+
+
+
Property changes on: trunk/LayoutTests/compositing/tiling/tiled-layer-resize.html
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Added: trunk/LayoutTests/platform/mac/compositing/tiling/tiled-layer-resize-expected.txt (0 => 137216)
--- trunk/LayoutTests/p
[webkit-changes] [137215] trunk
Title: [137215] trunk
Revision 137215
Author simon.fra...@apple.com
Date 2012-12-10 15:43:43 -0800 (Mon, 10 Dec 2012)
Log Message
Don't unconditionally repaint compositing layers when their size changes
https://bugs.webkit.org/show_bug.cgi?id=104461
Reviewed by Sam Weinig.
Source/WebCore:
RenderLayerBacking always repainted the entire compositing layer when its size
changed. This was done to fix repaint issues when outline widths changes, but
that issue is now solved by repainting in GraphicsLayer::setOffsetFromRenderer(),
add in r134628. I believe this is no longer necessary.
Always repainting when the size changes is terrible for the tile cache when
loading large documents, as all tiles repaint every time the document gets
longer.
Test: compositing/repaint/resize-repaint.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
LayoutTests:
Test that dumps repaint rects after adding content to a compositing layer.
* compositing/repaint/resize-repaint-expected.txt: Added.
* compositing/repaint/resize-repaint.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Added Paths
trunk/LayoutTests/compositing/repaint/resize-repaint-expected.txt
trunk/LayoutTests/compositing/repaint/resize-repaint.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137214 => 137215)
--- trunk/LayoutTests/ChangeLog 2012-12-10 23:34:32 UTC (rev 137214)
+++ trunk/LayoutTests/ChangeLog 2012-12-10 23:43:43 UTC (rev 137215)
@@ -1,3 +1,15 @@
+2012-12-10 Simon Fraser
+
+Don't unconditionally repaint compositing layers when their size changes
+https://bugs.webkit.org/show_bug.cgi?id=104461
+
+Reviewed by Sam Weinig.
+
+Test that dumps repaint rects after adding content to a compositing layer.
+
+* compositing/repaint/resize-repaint-expected.txt: Added.
+* compositing/repaint/resize-repaint.html: Added.
+
2012-12-10 Ojan Vafai
Unreviewed, rolling out r134150.
Added: trunk/LayoutTests/compositing/repaint/resize-repaint-expected.txt (0 => 137215)
--- trunk/LayoutTests/compositing/repaint/resize-repaint-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/repaint/resize-repaint-expected.txt 2012-12-10 23:43:43 UTC (rev 137215)
@@ -0,0 +1,23 @@
+(repaint rects
+ (rect 8 10 784 205)
+ (rect 0 23 800 205)
+)
+(GraphicsLayer
+ (bounds 800.00 600.00)
+ (children 1
+(GraphicsLayer
+ (bounds 800.00 600.00)
+ (children 1
+(GraphicsLayer
+ (position 8.00 8.00)
+ (bounds 402.00 207.00)
+ (drawsContent 1)
+ (repaint rects
+(rect 0.00 1.00 402.00 1.00)
+ )
+)
+ )
+)
+ )
+)
+
Property changes on: trunk/LayoutTests/compositing/repaint/resize-repaint-expected.txt
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Added: trunk/LayoutTests/compositing/repaint/resize-repaint.html (0 => 137215)
--- trunk/LayoutTests/compositing/repaint/resize-repaint.html (rev 0)
+++ trunk/LayoutTests/compositing/repaint/resize-repaint.html 2012-12-10 23:43:43 UTC (rev 137215)
@@ -0,0 +1,55 @@
+
+
+
+
+
+#resizing {
+width: 400px;
+border: 1px solid black;
+-webkit-transform: translateZ(0);
+}
+
+#resizing > div {
+height: 50px;
+margin: 1px;
+background-color: silver;
+}
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function doTest()
+{
+// Force compositing update before changing layer size.
+window.internals.layerTreeAsText(document);
+
+var resizingDiv = document.getElementById('resizing');
+
+for (var i = 0; i < 2; ++i) {
+var newDiv = document.createElement('div');
+resizingDiv.appendChild(newDiv);
+}
+
+if (window.internals)
+window.internals.startTrackingRepaints(document);
+
+for (var i = 0; i < 2; ++i) {
+var newDiv = document.createElement('div');
+resizingDiv.appendChild(newDiv);
+}
+
+if (window.internals)
+document.getElementById('layers').textContent = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_REPAINT_RECTS);
+}
+
+window.addEventListener('load', doTest, false);
+
+
+
+
+
+
+
+
+
Property changes on: trunk/LayoutTests/compositing/repaint/resize-repaint.html
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (137214 => 137215)
--- trunk/S
[webkit-changes] [137214] trunk
Title: [137214] trunk
Revision 137214
Author o...@chromium.org
Date 2012-12-10 15:34:32 -0800 (Mon, 10 Dec 2012)
Log Message
Unreviewed, rolling out r134150.
http://trac.webkit.org/changeset/134150
https://bugs.webkit.org/show_bug.cgi?id=99940
Caused JS-based tooltips to remain during scroll on Facebook
and Gmail. Rollout until I have time to experiment with less
aggresive approaches.
Source/WebCore:
* page/EventHandler.cpp:
(WebCore):
(WebCore::MaximumDurationTracker::MaximumDurationTracker):
(WebCore::MaximumDurationTracker::~MaximumDurationTracker):
(MaximumDurationTracker):
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
* page/EventHandler.h:
(EventHandler):
* platform/Timer.h:
LayoutTests:
* fast/scrolling/fake-mouse-event-throttling-expected.txt: Removed.
* fast/scrolling/fake-mouse-event-throttling.html: Removed.
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebCore/platform/Timer.h
Removed Paths
trunk/LayoutTests/fast/scrolling/fake-mouse-event-throttling-expected.txt
trunk/LayoutTests/fast/scrolling/fake-mouse-event-throttling.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137213 => 137214)
--- trunk/LayoutTests/ChangeLog 2012-12-10 23:30:36 UTC (rev 137213)
+++ trunk/LayoutTests/ChangeLog 2012-12-10 23:34:32 UTC (rev 137214)
@@ -1,3 +1,17 @@
+2012-12-10 Ojan Vafai
+
+Unreviewed, rolling out r134150.
+http://trac.webkit.org/changeset/134150
+https://bugs.webkit.org/show_bug.cgi?id=99940
+
+Caused JS-based tooltips to remain during scroll on Facebook
+and Gmail. Rollout until I have time to experiment with less
+aggresive approaches.
+
+* fast/scrolling/fake-mouse-event-throttling-expected.txt: Removed.
+* fast/scrolling/fake-mouse-event-throttling.html: Removed.
+* platform/mac/TestExpectations:
+
2012-12-10 Yi Shen
Keyboard caret movement in textarea with RTL Override Character can make tab unresponsive
Deleted: trunk/LayoutTests/fast/scrolling/fake-mouse-event-throttling-expected.txt (137213 => 137214)
--- trunk/LayoutTests/fast/scrolling/fake-mouse-event-throttling-expected.txt 2012-12-10 23:30:36 UTC (rev 137213)
+++ trunk/LayoutTests/fast/scrolling/fake-mouse-event-throttling-expected.txt 2012-12-10 23:34:32 UTC (rev 137214)
@@ -1,4 +0,0 @@
-PASS numberOfMouseMoves is 0
-PASS numberOfMouseMoves is 1
-PASS numberOfMouseMoves is 2
-
Deleted: trunk/LayoutTests/fast/scrolling/fake-mouse-event-throttling.html (137213 => 137214)
--- trunk/LayoutTests/fast/scrolling/fake-mouse-event-throttling.html 2012-12-10 23:30:36 UTC (rev 137213)
+++ trunk/LayoutTests/fast/scrolling/fake-mouse-event-throttling.html 2012-12-10 23:34:32 UTC (rev 137214)
@@ -1,63 +0,0 @@
-
-
-body {
-overflow: scroll;
-}
-div {
-height: 100px;
-}
-.pointer {
-cursor: pointer;
-background-color: salmon;
-}
-.plain {
-background-color: orange;
-}
-
-
-
-