[webkit-changes] [137569] trunk/Source/WebCore

2012-12-12 Thread macpherson 
Title: [137569] trunk/Source/WebCore








Revision 137569
Author macpher...@chromium.org
Date 2012-12-12 22:15:10 -0800 (Wed, 12 Dec 2012)


Log Message
Add ASSERTions to ensure that CSSPropertys that are variables only ever refer to CSSValues that are variables.
https://bugs.webkit.org/show_bug.cgi?id=104876

Reviewed by Steve Block.

Add assertions to CSSProperty constructors to make that if it is initialized with CSSPropertyVariable that
the value type associated with it is also a variable. This is already asserted at read time, but ASSERTing
here will produce a more useful backtrace.

No new tests as functionality unchanged.

* css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSProperty.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (137568 => 137569)

--- trunk/Source/WebCore/ChangeLog	2012-12-13 05:51:43 UTC (rev 137568)
+++ trunk/Source/WebCore/ChangeLog	2012-12-13 06:15:10 UTC (rev 137569)
@@ -1,3 +1,19 @@
+2012-12-12  Luke Macpherson   
+
+Add ASSERTions to ensure that CSSPropertys that are variables only ever refer to CSSValues that are variables.
+https://bugs.webkit.org/show_bug.cgi?id=104876
+
+Reviewed by Steve Block.
+
+Add assertions to CSSProperty constructors to make that if it is initialized with CSSPropertyVariable that
+the value type associated with it is also a variable. This is already asserted at read time, but ASSERTing
+here will produce a more useful backtrace.
+
+No new tests as functionality unchanged.
+
+* css/CSSProperty.h:
+(WebCore::CSSProperty::CSSProperty):
+
 2012-12-12  Gyuyoung Kim  
 
 NetworkInfoController needs to support destructor


Modified: trunk/Source/WebCore/css/CSSProperty.h (137568 => 137569)

--- trunk/Source/WebCore/css/CSSProperty.h	2012-12-13 05:51:43 UTC (rev 137568)
+++ trunk/Source/WebCore/css/CSSProperty.h	2012-12-13 06:15:10 UTC (rev 137569)
@@ -57,6 +57,9 @@
 : m_metadata(propertyID, shorthandID, important, implicit, isInheritedProperty(propertyID))
 , m_value(value)
 {
+#if ENABLE(CSS_VARIABLES)
+ASSERT((propertyID == CSSPropertyVariable) == (value && value->isVariableValue()));
+#endif
 }
 
 // FIXME: Remove this.
@@ -64,6 +67,9 @@
 : m_metadata(metadata)
 , m_value(value)
 {
+#if ENABLE(CSS_VARIABLES)
+ASSERT((metadata.m_propertyID == CSSPropertyVariable) == (value && value->isVariableValue()));
+#endif
 }
 
 CSSPropertyID id() const { return static_cast(m_metadata.m_propertyID); }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137567] tags/Safari-537.21/Source

2012-12-12 Thread lforschler 
Title: [137567] tags/Safari-537.21/Source








Revision 137567
Author lforsch...@apple.com
Date 2012-12-12 21:48:58 -0800 (Wed, 12 Dec 2012)


Log Message
Versioning

Modified Paths

tags/Safari-537.21/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-537.21/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-537.21/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-537.21/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-537.21/Source/_javascript_Core/Configurations/Version.xcconfig (137566 => 137567)

--- tags/Safari-537.21/Source/_javascript_Core/Configurations/Version.xcconfig	2012-12-13 05:45:26 UTC (rev 137566)
+++ tags/Safari-537.21/Source/_javascript_Core/Configurations/Version.xcconfig	2012-12-13 05:48:58 UTC (rev 137567)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 22;
+MINOR_VERSION = 21;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: tags/Safari-537.21/Source/WebCore/Configurations/Version.xcconfig (137566 => 137567)

--- tags/Safari-537.21/Source/WebCore/Configurations/Version.xcconfig	2012-12-13 05:45:26 UTC (rev 137566)
+++ tags/Safari-537.21/Source/WebCore/Configurations/Version.xcconfig	2012-12-13 05:48:58 UTC (rev 137567)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 22;
+MINOR_VERSION = 21;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: tags/Safari-537.21/Source/WebKit/mac/Configurations/Version.xcconfig (137566 => 137567)

--- tags/Safari-537.21/Source/WebKit/mac/Configurations/Version.xcconfig	2012-12-13 05:45:26 UTC (rev 137566)
+++ tags/Safari-537.21/Source/WebKit/mac/Configurations/Version.xcconfig	2012-12-13 05:48:58 UTC (rev 137567)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 22;
+MINOR_VERSION = 21;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: tags/Safari-537.21/Source/WebKit2/Configurations/Version.xcconfig (137566 => 137567)

--- tags/Safari-537.21/Source/WebKit2/Configurations/Version.xcconfig	2012-12-13 05:45:26 UTC (rev 137566)
+++ tags/Safari-537.21/Source/WebKit2/Configurations/Version.xcconfig	2012-12-13 05:48:58 UTC (rev 137567)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 22;
+MINOR_VERSION = 21;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137566] tags/Safari-537.21/

2012-12-12 Thread lforschler 
Title: [137566] tags/Safari-537.21/








Revision 137566
Author lforsch...@apple.com
Date 2012-12-12 21:45:26 -0800 (Wed, 12 Dec 2012)


Log Message
New Tag.

Added Paths

tags/Safari-537.21/




Diff

Property changes: tags/Safari-537.21



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137565] trunk

2012-12-12 Thread tkent 
Title: [137565] trunk








Revision 137565
Author tk...@chromium.org
Date 2012-12-12 21:44:01 -0800 (Wed, 12 Dec 2012)


Log Message
Validity of a radio button is not updated correctly when it is detached from an invalid radio group
https://bugs.webkit.org/show_bug.cgi?id=104873

Reviewed by Kentaro Hara.

Source/WebCore:

When a radio button is detached from an invalid radio group,
A) we should update button's validity, and
B) it should be valid.

A is handled by the following code in RadioButtonGroup::remove.
if (!wasValid) {
// A radio button not in a group is always valid. We need to make it
// valid only if the group was invalid.
button->setNeedsValidityCheck();

B was incomplete.
bool RadioInputType::valueMissing(const String&) const
{
return element()->isInRequiredRadioButtonGroup() && !element()->checkedRadioButtonForGroup();
isInRequiredRadioButtonGroup checked required state of a group with the
name attribute value even if the radio button was already detached from
the group. isInRequiredRadioButtonGroup should check membership of the
radio button precisely.

Tests: Update fast/forms/radio/radio-live-validation-style.html

* dom/CheckedRadioButtons.cpp:
(RadioButtonGroup): Declare contains.
(WebCore::RadioButtonGroup::contains): Added.
(WebCore::CheckedRadioButtons::isInRequiredGroup): Renamed from
isRequiredGroup. This function takes HTMLInputElement* argument.
* dom/CheckedRadioButtons.h:
(CheckedRadioButtons): Rename isRequiredGroup to isInRequiredGroup.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isInRequiredRadioButtonGroup):
Make this non-const becaues RadioButtonGroup::m_members needs non-const
pointers. Use CheckedRadioButtons::isInRequiredGroup.
* html/HTMLInputElement.h:
(HTMLInputElement): Make isInRequiredRadioButtonGroup non-const.

LayoutTests:

* fast/forms/radio/radio-live-validation-style-expected.txt:
* fast/forms/radio/radio-live-validation-style.html: Add a test case.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/radio/radio-live-validation-style-expected.txt
trunk/LayoutTests/fast/forms/radio/radio-live-validation-style.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/CheckedRadioButtons.cpp
trunk/Source/WebCore/dom/CheckedRadioButtons.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h




Diff

Modified: trunk/LayoutTests/ChangeLog (137564 => 137565)

--- trunk/LayoutTests/ChangeLog	2012-12-13 05:31:24 UTC (rev 137564)
+++ trunk/LayoutTests/ChangeLog	2012-12-13 05:44:01 UTC (rev 137565)
@@ -1,3 +1,13 @@
+2012-12-12  Kent Tamura  
+
+Validity of a radio button is not updated correctly when it is detached from an invalid radio group
+https://bugs.webkit.org/show_bug.cgi?id=104873
+
+Reviewed by Kentaro Hara.
+
+* fast/forms/radio/radio-live-validation-style-expected.txt:
+* fast/forms/radio/radio-live-validation-style.html: Add a test case.
+
 2012-12-12  Kunihiko Sakamoto  
 
 Milliseconds field of date/time input UI should respect step attribute


Modified: trunk/LayoutTests/fast/forms/radio/radio-live-validation-style-expected.txt (137564 => 137565)

--- trunk/LayoutTests/fast/forms/radio/radio-live-validation-style-expected.txt	2012-12-13 05:31:24 UTC (rev 137564)
+++ trunk/LayoutTests/fast/forms/radio/radio-live-validation-style-expected.txt	2012-12-13 05:44:01 UTC (rev 137565)
@@ -6,6 +6,8 @@
 Removing a checked radio button from a required radio button group by a DOM tree mutation:
 PASS backgroundOf($("radio1")) is validColor
 PASS parent.removeChild($("radio2")); backgroundOf($("radio1")) is invalidColor
+PASS $("radio1").remove(); radio2.webkitMatchesSelector(":valid") is false
+PASS radio2.remove(); radio2.webkitMatchesSelector(":valid") is true
 
 Removing a checked radio button from a required radio button group by name attribute change:
 PASS $("radio2").name = "group2"; backgroundOf($("radio1")) is invalidColor


Modified: trunk/LayoutTests/fast/forms/radio/radio-live-validation-style.html (137564 => 137565)

--- trunk/LayoutTests/fast/forms/radio/radio-live-validation-style.html	2012-12-13 05:31:24 UTC (rev 137564)
+++ trunk/LayoutTests/fast/forms/radio/radio-live-validation-style.html	2012-12-13 05:44:01 UTC (rev 137565)
@@ -30,6 +30,12 @@
 '';
 shouldBe('backgroundOf($("radio1"))', 'validColor');
 shouldBe('parent.removeChild($("radio2")); backgroundOf($("radio1"))', 'invalidColor');
+parent.innerHTML = '' +
+'' +
+'';
+var radio2 = $('radio2');
+shouldBeFalse('$("radio1").remove(); radio2.webkitMatchesSelector(":valid")');
+shouldBeTrue('radio2.remove(); radio2.webkitMatchesSelector(":valid")');
 debug('');
 
 debug('Removing a checked radio button from a required radio button group by name attribute change:');


Modified: trunk/Source/WebCore/ChangeLog (137564 => 137565)

--- trunk/Source/WebCore/ChangeLog	2012-12-13 05:31:24 UTC (rev 137564)
+++ trunk/Sourc

[webkit-changes] [137564] trunk/Source/WebCore

2012-12-12 Thread shinyak 
Title: [137564] trunk/Source/WebCore








Revision 137564
Author shin...@chromium.org
Date 2012-12-12 21:31:24 -0800 (Wed, 12 Dec 2012)


Log Message
ContainerNodeAlgorithm::notifyInsertedIntoDocument is not used
https://bugs.webkit.org/show_bug.cgi?id=104874

Reviewed by Hajime Morita.

ContainerNodeAlgorithm::notifyInsertedIntoDocument() is not used by anyone. We can remove it safely.

No new tests, no change in behavior.

* dom/ContainerNodeAlgorithms.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (137563 => 137564)

--- trunk/Source/WebCore/ChangeLog	2012-12-13 04:10:24 UTC (rev 137563)
+++ trunk/Source/WebCore/ChangeLog	2012-12-13 05:31:24 UTC (rev 137564)
@@ -1,3 +1,16 @@
+2012-12-12  Shinya Kawanaka  
+
+ContainerNodeAlgorithm::notifyInsertedIntoDocument is not used
+https://bugs.webkit.org/show_bug.cgi?id=104874
+
+Reviewed by Hajime Morita.
+
+ContainerNodeAlgorithm::notifyInsertedIntoDocument() is not used by anyone. We can remove it safely.
+
+No new tests, no change in behavior.
+
+* dom/ContainerNodeAlgorithms.h:
+
 2012-12-12  Kunihiko Sakamoto  
 
 Milliseconds field of date/time input UI should respect step attribute


Modified: trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h (137563 => 137564)

--- trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h	2012-12-13 04:10:24 UTC (rev 137563)
+++ trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h	2012-12-13 05:31:24 UTC (rev 137564)
@@ -38,7 +38,6 @@
 {
 }
 
-void notifyInsertedIntoDocument(Node*);
 void notify(Node*);
 
 private:
@@ -211,11 +210,6 @@
 notifyDescendantInsertedIntoTree(node);
 }
 
-inline void ChildNodeInsertionNotifier::notifyInsertedIntoDocument(Node* node)
-{
-notifyNodeInsertedIntoDocument(node);
-}
-
 inline void ChildNodeInsertionNotifier::notify(Node* node)
 {
 ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137563] branches/chromium/1312/Source/WebCore/html/shadow/ DateTimeEditElement.cpp

2012-12-12 Thread tkent 
Title: [137563] branches/chromium/1312/Source/WebCore/html/shadow/DateTimeEditElement.cpp








Revision 137563
Author tk...@chromium.org
Date 2012-12-12 20:10:24 -0800 (Wed, 12 Dec 2012)


Log Message
Another build fix.

WebCore:
* html/shadow/DateTimeEditElement.cpp: Include TextRun.h

Modified Paths

branches/chromium/1312/Source/WebCore/html/shadow/DateTimeEditElement.cpp




Diff

Modified: branches/chromium/1312/Source/WebCore/html/shadow/DateTimeEditElement.cpp (137562 => 137563)

--- branches/chromium/1312/Source/WebCore/html/shadow/DateTimeEditElement.cpp	2012-12-13 03:58:01 UTC (rev 137562)
+++ branches/chromium/1312/Source/WebCore/html/shadow/DateTimeEditElement.cpp	2012-12-13 04:10:24 UTC (rev 137563)
@@ -41,6 +41,7 @@
 #include "RenderStyle.h"
 #include "StyleResolver.h"
 #include "Text.h"
+#include "TextRun.h"
 #include 
 #include 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137562] branches/chromium/1312/Source/WebCore/html/shadow

2012-12-12 Thread tkent 
Title: [137562] branches/chromium/1312/Source/WebCore/html/shadow








Revision 137562
Author tk...@chromium.org
Date 2012-12-12 19:58:01 -0800 (Wed, 12 Dec 2012)


Log Message
Try to fix chromium/1312 build.

WebCore:
* html/shadow/DateTimeSymbolicFieldElement.cpp: Include TextRun.h
	* html/shadow/DateTimeNumericFieldElement.cpp: Ditto.

Modified Paths

branches/chromium/1312/Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp
branches/chromium/1312/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp




Diff

Modified: branches/chromium/1312/Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp (137561 => 137562)

--- branches/chromium/1312/Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp	2012-12-13 03:02:04 UTC (rev 137561)
+++ branches/chromium/1312/Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp	2012-12-13 03:58:01 UTC (rev 137562)
@@ -32,6 +32,7 @@
 #include "Font.h"
 #include "KeyboardEvent.h"
 #include "PlatformLocale.h"
+#include "TextRun.h"
 #include 
 
 using namespace WTF::Unicode;


Modified: branches/chromium/1312/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp (137561 => 137562)

--- branches/chromium/1312/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp	2012-12-13 03:02:04 UTC (rev 137561)
+++ branches/chromium/1312/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp	2012-12-13 03:58:01 UTC (rev 137562)
@@ -30,6 +30,7 @@
 #include "Font.h"
 #include "KeyboardEvent.h"
 #include "TextBreakIterator.h"
+#include "TextRun.h"
 #include 
 #include 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137561] trunk

2012-12-12 Thread commit-queue 
Title: [137561] trunk








Revision 137561
Author commit-qu...@webkit.org
Date 2012-12-12 19:02:04 -0800 (Wed, 12 Dec 2012)


Log Message
Milliseconds field of date/time input UI should respect step attribute
https://bugs.webkit.org/show_bug.cgi?id=104628

Patch by Kunihiko Sakamoto  on 2012-12-12
Reviewed by Kent Tamura.

Source/WebCore:

This patch makes step-up/-down UI of the milliseconds fields respect step attribute
in a special case when the step is divisible by 1000 milliseconds.

Test: fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html

* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitField):
If step of the element (in milliseconds) is divisible by 1000, use it as the step of the milliseconds field. Otherwise, the millisecond field has step 1.
* html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement): Add step and stepBase arguments.
(WebCore::DateTimeMillisecondFieldElement::create): Ditto.
* html/shadow/DateTimeFieldElements.h:
(DateTimeMillisecondFieldElement): Ditto.
* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement): Ditto.
(WebCore::DateTimeNumericFieldElement::stepDown): Changed to compute next allowed value using roundDown().
(WebCore::DateTimeNumericFieldElement::stepUp): Changed to compute next allowed value using roundUp().
(WebCore::DateTimeNumericFieldElement::roundDown): Added.
(WebCore::DateTimeNumericFieldElement::roundUp): Added.
* html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Add m_step and m_stepBase fields.

LayoutTests:

* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
Changed to use eventSender.keyDown() instead of making keydown event because we need delete-key handling.
Added new helper function test() and changed stepUp/stepDown to use it.
Added test cases for milliseconds field with various step values and step baees.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt
trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp
trunk/Source/WebCore/html/shadow/DateTimeFieldElements.cpp
trunk/Source/WebCore/html/shadow/DateTimeFieldElements.h
trunk/Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp
trunk/Source/WebCore/html/shadow/DateTimeNumericFieldElement.h




Diff

Modified: trunk/LayoutTests/ChangeLog (137560 => 137561)

--- trunk/LayoutTests/ChangeLog	2012-12-13 02:49:54 UTC (rev 137560)
+++ trunk/LayoutTests/ChangeLog	2012-12-13 03:02:04 UTC (rev 137561)
@@ -1,3 +1,16 @@
+2012-12-12  Kunihiko Sakamoto  
+
+Milliseconds field of date/time input UI should respect step attribute
+https://bugs.webkit.org/show_bug.cgi?id=104628
+
+Reviewed by Kent Tamura.
+
+* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
+* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
+Changed to use eventSender.keyDown() instead of making keydown event because we need delete-key handling.
+Added new helper function test() and changed stepUp/stepDown to use it.
+Added test cases for milliseconds field with various step values and step baees.
+
 2012-12-12  Julien Chaffraix  
 
 [CSS Grid Layout] Include paddings and borders into the grid element's logical height / width


Modified: trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt (137560 => 137561)

--- trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt	2012-12-13 02:49:54 UTC (rev 137560)
+++ trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt	2012-12-13 03:02:04 UTC (rev 137561)
@@ -3,12 +3,33 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Function arguments are (value, step, {min or max}, [stepCount]).
+Function arguments are (value, step, min, max, [keySequence]).
 Normal cases
-PASS stepUp("07:13", null, null) is "07:14"
-PASS stepDown("07:13", null, null) is "07:12"
-PASS stepUp("07:13", null, null, 10) is "07:23"
-PASS stepDown("07:13", null, null, 11) is "07:02"
+PASS stepUp("07:13", null, null, null) is "07:14"
+PASS stepDown("07:13", null, null, null) is "07:12"
+PASS test("07:13", null, null, null, ["upArrow", "upArrow", "upArrow"]) is "07:16"
+PASS test("07:13", null, null, null, ["downArrow", "downArrow", "downArrow"]) is "07:10"
+Milliseconds
+PASS

[webkit-changes] [137560] trunk

2012-12-12 Thread jchaffraix 
Title: [137560] trunk








Revision 137560
Author jchaffr...@webkit.org
Date 2012-12-12 18:49:54 -0800 (Wed, 12 Dec 2012)


Log Message
[CSS Grid Layout] Include paddings and borders into the grid element's logical height / width
https://bugs.webkit.org/show_bug.cgi?id=104818

Reviewed by Tony Chang.

Source/WebCore:

This change makes RenderGrid add the borders and paddings in the right direction during layout
so that the grid element's size accounts them like any other renderer.

Test: fast/css-grid-layout/grid-element-padding-margin.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredLogicalWidths):
(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

* fast/css-grid-layout/grid-element-padding-margin-expected.txt: Added.
* fast/css-grid-layout/grid-element-padding-margin.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp


Added Paths

trunk/LayoutTests/fast/css-grid-layout/grid-element-padding-margin-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-element-padding-margin.html




Diff

Modified: trunk/LayoutTests/ChangeLog (137559 => 137560)

--- trunk/LayoutTests/ChangeLog	2012-12-13 02:44:41 UTC (rev 137559)
+++ trunk/LayoutTests/ChangeLog	2012-12-13 02:49:54 UTC (rev 137560)
@@ -1,3 +1,13 @@
+2012-12-12  Julien Chaffraix  
+
+[CSS Grid Layout] Include paddings and borders into the grid element's logical height / width
+https://bugs.webkit.org/show_bug.cgi?id=104818
+
+Reviewed by Tony Chang.
+
+* fast/css-grid-layout/grid-element-padding-margin-expected.txt: Added.
+* fast/css-grid-layout/grid-element-padding-margin.html: Added.
+
 2012-12-12  Shinya Kawanaka  
 
 [Shadow] HTMLContentElement::getDistributedNodes() doesn't work correctly if not in document tree.


Added: trunk/LayoutTests/fast/css-grid-layout/grid-element-padding-margin-expected.txt (0 => 137560)

--- trunk/LayoutTests/fast/css-grid-layout/grid-element-padding-margin-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-element-padding-margin-expected.txt	2012-12-13 02:49:54 UTC (rev 137560)
@@ -0,0 +1,8 @@
+Test that paddings and borders are added to a grid element's size.
+
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS


Added: trunk/LayoutTests/fast/css-grid-layout/grid-element-padding-margin.html (0 => 137560)

--- trunk/LayoutTests/fast/css-grid-layout/grid-element-padding-margin.html	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-element-padding-margin.html	2012-12-13 02:49:54 UTC (rev 137560)
@@ -0,0 +1,44 @@
+
+
+
+if (window.testRunner)
+testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
+
+
+.grid {
+display: -webkit-grid;
+background-color: grey;
+-webkit-grid-columns: 100px;
+-webkit-grid-rows: 50px;
+/* Force the grid element to be shrink-to-fit. */
+position: absolute;
+}
+
+.padding {
+padding: 20px 10px 30px 50px;
+}
+
+.border {
+border-style: solid;
+border-color: green;
+border-width: 10px 20px 30px 40px;
+}
+
+.verticalRL {
+-webkit-writing-mode: vertical-rl;
+}
+
+

[webkit-changes] [137559] trunk/Source/WebKit2

2012-12-12 Thread aestes 
Title: [137559] trunk/Source/WebKit2








Revision 137559
Author aes...@apple.com
Date 2012-12-12 18:44:41 -0800 (Wed, 12 Dec 2012)


Log Message
Rename currentMousePosition() to lastKnownMousePosition() and mark it as OVERRIDE.

* WebProcess/Plugins/PDF/PDFPlugin.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (137558 => 137559)

--- trunk/Source/WebKit2/ChangeLog	2012-12-13 02:43:12 UTC (rev 137558)
+++ trunk/Source/WebKit2/ChangeLog	2012-12-13 02:44:41 UTC (rev 137559)
@@ -1,3 +1,9 @@
+2012-12-12  Andy Estes  
+
+Rename currentMousePosition() to lastKnownMousePosition() and mark it as OVERRIDE.
+
+* WebProcess/Plugins/PDF/PDFPlugin.h:
+
 2012-12-12  Seokju Kwon  
 
 [EFL] Refactor duplicate code into EflInspectorUtilities


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h (137558 => 137559)

--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h	2012-12-13 02:43:12 UTC (rev 137558)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h	2012-12-13 02:44:41 UTC (rev 137559)
@@ -96,7 +96,7 @@
 virtual void setScrollOffset(const WebCore::IntPoint&) OVERRIDE;
 virtual void invalidateScrollbarRect(WebCore::Scrollbar*, const WebCore::IntRect&) OVERRIDE;
 virtual void invalidateScrollCornerRect(const WebCore::IntRect&) OVERRIDE;
-virtual WebCore::IntPoint currentMousePosition() const { return m_lastMousePositionInPluginCoordinates; }
+virtual WebCore::IntPoint lastKnownMousePosition() const OVERRIDE { return m_lastMousePositionInPluginCoordinates; }
 
 NSEvent *nsEventForWebMouseEvent(const WebMouseEvent&);
 WebCore::IntPoint convertFromPluginToPDFView(const WebCore::IntPoint&) const;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137558] trunk/Tools

2012-12-12 Thread roger_fong 
Title: [137558] trunk/Tools








Revision 137558
Author roger_f...@apple.com
Date 2012-12-12 18:43:12 -0800 (Wed, 12 Dec 2012)


Log Message
Unreviewed. Fix typo in NRWT.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.is_reference_html_file):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py




Diff

Modified: trunk/Tools/ChangeLog (137557 => 137558)

--- trunk/Tools/ChangeLog	2012-12-13 02:33:52 UTC (rev 137557)
+++ trunk/Tools/ChangeLog	2012-12-13 02:43:12 UTC (rev 137558)
@@ -1,5 +1,12 @@
 2012-12-12  Roger Fong  
 
+Unreviewed. Fix typo in NRWT.
+
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.is_reference_html_file):
+
+2012-12-12  Roger Fong  
+
 Fix detection of ref test files in old and new run webkit tests.
 https://bugs.webkit.org/show_bug.cgi?id=104850.
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (137557 => 137558)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2012-12-13 02:33:52 UTC (rev 137557)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2012-12-13 02:43:12 UTC (rev 137558)
@@ -607,7 +607,7 @@
 @staticmethod
 # If any changes are made here be sure to update the isUsedInReftest method in old-run-webkit-tests as well.
 def is_reference_html_file(filesystem, dirname, filename):
-if filename.startswith('ref-') or filename.startsWith('notref-'):
+if filename.startswith('ref-') or filename.startswith('notref-'):
 return True
 filename_wihout_ext, unused = filesystem.splitext(filename)
 for suffix in ['-expected', '-expected-mismatch', '-ref', '-notref']:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137557] trunk/Source/WebCore

2012-12-12 Thread roger_fong 
Title: [137557] trunk/Source/WebCore








Revision 137557
Author roger_f...@apple.com
Date 2012-12-12 18:33:52 -0800 (Wed, 12 Dec 2012)


Log Message
Include Apple Windows in GraphicsLayer::supportsBackgroundColorContent().
https://bugs.webkit.org/show_bug.cgi?id=104852.

Reviewed by Simon Fraser.

* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::supportsBackgroundColorContent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (137556 => 137557)

--- trunk/Source/WebCore/ChangeLog	2012-12-13 02:26:22 UTC (rev 137556)
+++ trunk/Source/WebCore/ChangeLog	2012-12-13 02:33:52 UTC (rev 137557)
@@ -1,3 +1,13 @@
+2012-12-12  Roger Fong  
+
+Include Apple Windows in GraphicsLayer::supportsBackgroundColorContent().
+https://bugs.webkit.org/show_bug.cgi?id=104852.
+
+Reviewed by Simon Fraser.
+
+* platform/graphics/GraphicsLayer.h:
+(WebCore::GraphicsLayer::supportsBackgroundColorContent):
+
 2012-12-12  KyungTae Kim  
 
 Unused parameters on TextureMapperImageBuffer.cpp


Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.h (137556 => 137557)

--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.h	2012-12-13 02:26:22 UTC (rev 137556)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.h	2012-12-13 02:33:52 UTC (rev 137557)
@@ -427,7 +427,7 @@
 
 static bool supportsBackgroundColorContent()
 {
-#if PLATFORM(MAC) || USE(TEXTURE_MAPPER)
+#if USE(CA) || USE(TEXTURE_MAPPER)
 return true;
 #else
 return false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137556] trunk/Source/WebKit/chromium

2012-12-12 Thread aestes 
Title: [137556] trunk/Source/WebKit/chromium








Revision 137556
Author aes...@apple.com
Date 2012-12-12 18:26:22 -0800 (Wed, 12 Dec 2012)


Log Message
Fix the Chromium build after r137539.

* src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::lastKnownMousePosition): Renamed from currentMousePosition().
* src/ScrollbarGroup.h: Ditto.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ScrollbarGroup.cpp
trunk/Source/WebKit/chromium/src/ScrollbarGroup.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (137555 => 137556)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-13 02:17:49 UTC (rev 137555)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-13 02:26:22 UTC (rev 137556)
@@ -1,3 +1,11 @@
+2012-12-12  Andy Estes  
+
+Fix the Chromium build after r137539.
+
+* src/ScrollbarGroup.cpp:
+(WebKit::ScrollbarGroup::lastKnownMousePosition): Renamed from currentMousePosition().
+* src/ScrollbarGroup.h: Ditto.
+
 2012-12-12  Sheriff Bot  
 
 Unreviewed.  Rolled DEPS.


Modified: trunk/Source/WebKit/chromium/src/ScrollbarGroup.cpp (137555 => 137556)

--- trunk/Source/WebKit/chromium/src/ScrollbarGroup.cpp	2012-12-13 02:17:49 UTC (rev 137555)
+++ trunk/Source/WebKit/chromium/src/ScrollbarGroup.cpp	2012-12-13 02:26:22 UTC (rev 137556)
@@ -242,7 +242,7 @@
 return IntSize();
 }
 
-IntPoint ScrollbarGroup::currentMousePosition() const
+IntPoint ScrollbarGroup::lastKnownMousePosition() const
 {
 return m_lastMousePosition;
 }


Modified: trunk/Source/WebKit/chromium/src/ScrollbarGroup.h (137555 => 137556)

--- trunk/Source/WebKit/chromium/src/ScrollbarGroup.h	2012-12-13 02:17:49 UTC (rev 137555)
+++ trunk/Source/WebKit/chromium/src/ScrollbarGroup.h	2012-12-13 02:26:22 UTC (rev 137556)
@@ -69,7 +69,7 @@
 virtual int visibleWidth() const OVERRIDE;
 virtual WebCore::IntSize contentsSize() const OVERRIDE;
 virtual WebCore::IntSize overhangAmount() const OVERRIDE;
-virtual WebCore::IntPoint currentMousePosition() const OVERRIDE;
+virtual WebCore::IntPoint lastKnownMousePosition() const OVERRIDE;
 virtual bool shouldSuspendScrollAnimations() const OVERRIDE;
 virtual void scrollbarStyleChanged(int newStyle, bool forceUpdate) OVERRIDE;
 virtual bool scrollbarsCanBeActive() const OVERRIDE;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137555] trunk/Source/WebCore

2012-12-12 Thread commit-queue 
Title: [137555] trunk/Source/WebCore








Revision 137555
Author commit-qu...@webkit.org
Date 2012-12-12 18:17:49 -0800 (Wed, 12 Dec 2012)


Log Message
Unused parameters on TextureMapperImageBuffer.cpp
https://bugs.webkit.org/show_bug.cgi?id=104857

Patch by KyungTae Kim  on 2012-12-12
Reviewed by Kentaro Hara.

The updateContents has unused parameter 'textureMapper',
remove the parameter name to fix 'unused parameter' build warning.

* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::updateContents):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (137554 => 137555)

--- trunk/Source/WebCore/ChangeLog	2012-12-13 02:13:13 UTC (rev 137554)
+++ trunk/Source/WebCore/ChangeLog	2012-12-13 02:17:49 UTC (rev 137555)
@@ -1,3 +1,16 @@
+2012-12-12  KyungTae Kim  
+
+Unused parameters on TextureMapperImageBuffer.cpp
+https://bugs.webkit.org/show_bug.cgi?id=104857
+
+Reviewed by Kentaro Hara.
+
+The updateContents has unused parameter 'textureMapper',
+remove the parameter name to fix 'unused parameter' build warning. 
+
+* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
+(WebCore::BitmapTextureImageBuffer::updateContents):
+
 2012-12-12  Shinya Kawanaka  
 
 [Shadow] HTMLContentElement::getDistributedNodes() doesn't work correctly if not in document tree.


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp (137554 => 137555)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp	2012-12-13 02:13:13 UTC (rev 137554)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp	2012-12-13 02:17:49 UTC (rev 137555)
@@ -57,7 +57,7 @@
 #endif
 }
 
-void BitmapTextureImageBuffer::updateContents(TextureMapper* textureMapper, GraphicsLayer* sourceLayer, const IntRect& targetRect, const IntPoint& sourceOffset, UpdateContentsFlag)
+void BitmapTextureImageBuffer::updateContents(TextureMapper*, GraphicsLayer* sourceLayer, const IntRect& targetRect, const IntPoint& sourceOffset, UpdateContentsFlag)
 {
 GraphicsContext* context = m_image->context();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137554] trunk/Source/WebKit/chromium

2012-12-12 Thread commit-queue 
Title: [137554] trunk/Source/WebKit/chromium








Revision 137554
Author commit-qu...@webkit.org
Date 2012-12-12 18:13:13 -0800 (Wed, 12 Dec 2012)


Log Message
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot  on 2012-12-12

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (137553 => 137554)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-13 02:12:07 UTC (rev 137553)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-13 02:13:13 UTC (rev 137554)
@@ -1,3 +1,9 @@
+2012-12-12  Sheriff Bot  
+
+Unreviewed.  Rolled DEPS.
+
+* DEPS:
+
 2012-12-12  Charlie Reis  
 
 [chromium] Expose quickRedirectComing via WebDataSource


Modified: trunk/Source/WebKit/chromium/DEPS (137553 => 137554)

--- trunk/Source/WebKit/chromium/DEPS	2012-12-13 02:12:07 UTC (rev 137553)
+++ trunk/Source/WebKit/chromium/DEPS	2012-12-13 02:13:13 UTC (rev 137554)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '172470'
+  'chromium_rev': '172732'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137553] trunk/Tools

2012-12-12 Thread roger_fong 
Title: [137553] trunk/Tools








Revision 137553
Author roger_f...@apple.com
Date 2012-12-12 18:12:07 -0800 (Wed, 12 Dec 2012)


Log Message
Fix detection of ref test files in old and new run webkit tests.
https://bugs.webkit.org/show_bug.cgi?id=104850.

Reviewed by Timothy Horton.

* Scripts/old-run-webkit-tests:
(isUsedInReftest): 
Add notref and ref prefix and suffix cases to isUsedinReftest.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port):
(Port.is_reference_html_file): 
Typo in NRWT.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/old-run-webkit-tests
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py




Diff

Modified: trunk/Tools/ChangeLog (137552 => 137553)

--- trunk/Tools/ChangeLog	2012-12-13 02:11:01 UTC (rev 137552)
+++ trunk/Tools/ChangeLog	2012-12-13 02:12:07 UTC (rev 137553)
@@ -1,3 +1,18 @@
+2012-12-12  Roger Fong  
+
+Fix detection of ref test files in old and new run webkit tests.
+https://bugs.webkit.org/show_bug.cgi?id=104850.
+
+Reviewed by Timothy Horton.
+
+* Scripts/old-run-webkit-tests:
+(isUsedInReftest): 
+Add notref and ref prefix and suffix cases to isUsedinReftest.
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port):
+(Port.is_reference_html_file): 
+Typo in NRWT.
+
 2012-12-12  Dirk Pranke  
 
 rework ChromiumAndroidDriver.start() et. al to avoid funky layering


Modified: trunk/Tools/Scripts/old-run-webkit-tests (137552 => 137553)

--- trunk/Tools/Scripts/old-run-webkit-tests	2012-12-13 02:11:01 UTC (rev 137552)
+++ trunk/Tools/Scripts/old-run-webkit-tests	2012-12-13 02:12:07 UTC (rev 137553)
@@ -201,6 +201,8 @@
 
 my $expectedTag = "expected";
 my $mismatchTag = "mismatch";
+my $refTag = "ref";
+my $notrefTag = "notref";
 my $actualTag = "actual";
 my $prettyDiffTag = "pretty-diff";
 my $diffsTag = "diffs";
@@ -2632,15 +2634,18 @@
 my $filename = $_[0];
 my @extensions = ('html','shtml','xml','xhtml','htm','php','svg','mht','pl');
 my $extensionsJoined = join("|", @extensions);
-my $extensionExpression = "-$expectedTag(-$mismatchTag)?\\.(".$extensionsJoined.")\$";
-
-if ($filename =~ /$extensionExpression/) {
+my $suffixExtensionExpression = "-($expectedTag|$refTag|$notrefTag)(-$mismatchTag)?\\.(".$extensionsJoined.")\$";
+my $prefixExtensionExpression = "^($refTag|$notrefTag)-";
+if ($filename =~ /$suffixExtensionExpression/ || $filename =~ /$prefixExtensionExpression/) {
 return 1;
 }
 my $base = stripExtension($filename);
-
+
 foreach my $extension (@extensions) {
-if (-f "$base-$expectedTag.$extension" || -f "$base-$expectedTag-$mismatchTag.$extension") {
+if (-f "$base-$expectedTag.$extension" || 
+-f "$base-$refTag.$extension" || -f "$base-$notrefTag.$extension" ||
+-f "$base-$expectedTag-$mismatchTag.$extension" ||
+-f "$refTag-$base.$extension" || -f "$notrefTag-$base.$extension") {
 return 1;
 }
 }


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (137552 => 137553)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2012-12-13 02:11:01 UTC (rev 137552)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2012-12-13 02:12:07 UTC (rev 137553)
@@ -605,8 +605,9 @@
   '.htm', '.php', '.svg', '.mht'])
 
 @staticmethod
+# If any changes are made here be sure to update the isUsedInReftest method in old-run-webkit-tests as well.
 def is_reference_html_file(filesystem, dirname, filename):
-if filename.startswith('ref-') or filename.endswith('notref-'):
+if filename.startswith('ref-') or filename.startsWith('notref-'):
 return True
 filename_wihout_ext, unused = filesystem.splitext(filename)
 for suffix in ['-expected', '-expected-mismatch', '-ref', '-notref']:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137552] trunk

2012-12-12 Thread shinyak 
Title: [137552] trunk








Revision 137552
Author shin...@chromium.org
Date 2012-12-12 18:11:01 -0800 (Wed, 12 Dec 2012)


Log Message
[Shadow] HTMLContentElement::getDistributedNodes() doesn't work correctly if not in document tree.
https://bugs.webkit.org/show_bug.cgi?id=104345

Reviewed by Hajime Morita.

Source/WebCore:

Since document->updateLayout() does affect nodes in Document, distribution will not occur in
InsertionPoints out of Document. We have to find the element in document tree scope, and start distribution from it.

Test: fast/dom/shadow/get-distributed-nodes-orphan.html

* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::getDistributedNodes):

LayoutTests:

* fast/dom/shadow/get-distributed-nodes-orphan-expected.txt: Added.
* fast/dom/shadow/get-distributed-nodes-orphan.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/InsertionPoint.cpp


Added Paths

trunk/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan-expected.txt
trunk/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan.html




Diff

Modified: trunk/LayoutTests/ChangeLog (137551 => 137552)

--- trunk/LayoutTests/ChangeLog	2012-12-13 02:09:01 UTC (rev 137551)
+++ trunk/LayoutTests/ChangeLog	2012-12-13 02:11:01 UTC (rev 137552)
@@ -1,3 +1,13 @@
+2012-12-12  Shinya Kawanaka  
+
+[Shadow] HTMLContentElement::getDistributedNodes() doesn't work correctly if not in document tree.
+https://bugs.webkit.org/show_bug.cgi?id=104345
+
+Reviewed by Hajime Morita.
+
+* fast/dom/shadow/get-distributed-nodes-orphan-expected.txt: Added.
+* fast/dom/shadow/get-distributed-nodes-orphan.html: Added.
+
 2012-12-12  Emil A Eklund  
 
 Unreviewed chromium rebaseline for fast/repaint/delete-into-nested-block.html


Added: trunk/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan-expected.txt (0 => 137552)

--- trunk/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan-expected.txt	2012-12-13 02:11:01 UTC (rev 137552)
@@ -0,0 +1,29 @@
+getDistributedNodes() should work out of Document
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+getDistributedNodes() should work out of Document
+PASS nodeList.length is expectedNodes.length
+PASS nodeList.item(0) is expectedNodes[0]
+
+When a content element is disconnected from ShadowRoot, it should not work.
+PASS nodeList.length is expectedNodes.length
+
+Reprojection case
+PASS nodeList.length is expectedNodes.length
+PASS nodeList.item(0) is expectedNodes[0]
+PASS nodeList.length is expectedNodes.length
+PASS nodeList.item(0) is expectedNodes[0]
+PASS nodeList.item(1) is expectedNodes[1]
+
+rootChild is disconnected. Now content became inactive, so content element itself should be distributed.
+PASS nodeList.length is expectedNodes.length
+PASS nodeList.length is expectedNodes.length
+PASS nodeList.item(0) is expectedNodes[0]
+PASS nodeList.item(1) is expectedNodes[1]
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan.html (0 => 137552)

--- trunk/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan.html	2012-12-13 02:11:01 UTC (rev 137552)
@@ -0,0 +1,64 @@
+
+
+
+
+
+
+

+

+
+