[webkit-changes] [137718] trunk/Source/WebKit2
Title: [137718] trunk/Source/WebKit2 Revision 137718 Author kenn...@webkit.org Date 2012-12-14 00:01:10 -0800 (Fri, 14 Dec 2012) Log Message [EFL][WK2] Do not pass size to updateViewportSize https://bugs.webkit.org/show_bug.cgi?id=104994 Reviewed by Gyuyoung Kim. There is no need to pass size to updateViewportSize as we have direct access to it. This makes the code differ less from Qt. * UIProcess/API/efl/ewk_view.cpp: (_ewk_view_smart_calculate): * UIProcess/PageViewportController.cpp: (WebKit::PageViewportController::pageDidRequestScroll): * UIProcess/efl/PageClientBase.h: (PageClientBase): * UIProcess/efl/PageClientDefaultImpl.cpp: (WebKit::PageClientDefaultImpl::updateViewportSize): * UIProcess/efl/PageClientDefaultImpl.h: (PageClientDefaultImpl): * UIProcess/efl/PageClientLegacyImpl.cpp: (WebKit::PageClientLegacyImpl::updateViewportSize): * UIProcess/efl/PageClientLegacyImpl.h: (PageClientLegacyImpl): * UIProcess/efl/PageViewportControllerClientEfl.cpp: (WebKit::PageViewportControllerClientEfl::updateViewportSize): * UIProcess/efl/PageViewportControllerClientEfl.h: (PageViewportControllerClientEfl): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp trunk/Source/WebKit2/UIProcess/PageViewportController.cpp trunk/Source/WebKit2/UIProcess/efl/PageClientBase.h trunk/Source/WebKit2/UIProcess/efl/PageClientDefaultImpl.cpp trunk/Source/WebKit2/UIProcess/efl/PageClientDefaultImpl.h trunk/Source/WebKit2/UIProcess/efl/PageClientLegacyImpl.cpp trunk/Source/WebKit2/UIProcess/efl/PageClientLegacyImpl.h trunk/Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.cpp trunk/Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.h Diff Modified: trunk/Source/WebKit2/ChangeLog (137717 => 137718) --- trunk/Source/WebKit2/ChangeLog 2012-12-14 07:45:46 UTC (rev 137717) +++ trunk/Source/WebKit2/ChangeLog 2012-12-14 08:01:10 UTC (rev 137718) @@ -1,3 +1,33 @@ +2012-12-13 Kenneth Rohde Christiansen + +[EFL][WK2] Do not pass size to updateViewportSize +https://bugs.webkit.org/show_bug.cgi?id=104994 + +Reviewed by Gyuyoung Kim. + +There is no need to pass size to updateViewportSize as we +have direct access to it. This makes the code differ less +from Qt. + +* UIProcess/API/efl/ewk_view.cpp: +(_ewk_view_smart_calculate): +* UIProcess/PageViewportController.cpp: +(WebKit::PageViewportController::pageDidRequestScroll): +* UIProcess/efl/PageClientBase.h: +(PageClientBase): +* UIProcess/efl/PageClientDefaultImpl.cpp: +(WebKit::PageClientDefaultImpl::updateViewportSize): +* UIProcess/efl/PageClientDefaultImpl.h: +(PageClientDefaultImpl): +* UIProcess/efl/PageClientLegacyImpl.cpp: +(WebKit::PageClientLegacyImpl::updateViewportSize): +* UIProcess/efl/PageClientLegacyImpl.h: +(PageClientLegacyImpl): +* UIProcess/efl/PageViewportControllerClientEfl.cpp: +(WebKit::PageViewportControllerClientEfl::updateViewportSize): +* UIProcess/efl/PageViewportControllerClientEfl.h: +(PageViewportControllerClientEfl): + 2012-12-13 Sanghyup Lee Fix build warning Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (137717 => 137718) --- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-12-14 07:45:46 UTC (rev 137717) +++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-12-14 08:01:10 UTC (rev 137718) @@ -390,7 +390,7 @@ impl->setNeedsSurfaceResize(); #endif #if USE(TILED_BACKING_STORE) -impl->pageClient()->updateViewportSize(IntSize(width, height)); +impl->pageClient()->updateViewportSize(); #endif } } Modified: trunk/Source/WebKit2/UIProcess/PageViewportController.cpp (137717 => 137718) --- trunk/Source/WebKit2/UIProcess/PageViewportController.cpp 2012-12-14 07:45:46 UTC (rev 137717) +++ trunk/Source/WebKit2/UIProcess/PageViewportController.cpp 2012-12-14 08:01:10 UTC (rev 137718) @@ -226,7 +226,6 @@ FloatPoint position = pixelAlignedFloatPoint(FloatPoint(cssPosition)); FloatPoint boundPosition = boundContentsPosition(position); - FloatRect endVisibleContentRect(boundPosition, visibleContentsSize()); if (m_lastFrameCoveredRect.intersects(endVisibleContentRect)) Modified: trunk/Source/WebKit2/UIProcess/efl/PageClientBase.h (137717 => 137718) --- trunk/Source/WebKit2/UIProcess/efl/PageClientBase.h 2012-12-14 07:45:46 UTC (rev 137717) +++ trunk/Source/WebKit2/UIProcess/efl/PageClientBase.h 2012-12-14 08:01:10 UTC (rev 137718) @@ -40,7 +40,7 @@ // Called from the view virtual void didCommitLoad() = 0; -virtual void updateViewportSize(const WebCore::IntSize&) = 0; +virtual void updateViewportSize() = 0; virtual void didChangeContentsSize(const WebCore::IntSize&) = 0; EwkViewImpl* viewImpl() const; Modified: trunk/Source/WebKit2/UIProcess/efl/PageCl
[webkit-changes] [137717] trunk/Source/WebCore
Title: [137717] trunk/Source/WebCore
Revision 137717
Author morr...@google.com
Date 2012-12-13 23:45:46 -0800 (Thu, 13 Dec 2012)
Log Message
ContentDistributor and ShadowRootContentDistributionData should use RefPtr to hold elements.
https://bugs.webkit.org/show_bug.cgi?id=104918
Reviewed by Kentaro Hara.
This change turns some raw pointers to RefPtrs.
No new tests. Hard to write reliable fast tests since the error
reproduction needs GC to run in certain timing. Although original
report has a repdocution, it takes a few seconds before crash and
isn't suited for a layout test.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::insertionPointList):
* dom/ShadowRoot.h:
(ShadowRoot):
* html/shadow/ContentDistributor.cpp:
(WebCore::ShadowRootContentDistributionData::ensureInsertionPointList):
(WebCore::ContentDistributor::findInsertionPointFor):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
* html/shadow/ContentDistributor.h:
(ShadowRootContentDistributionData):
(ContentDistributor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/dom/ShadowRoot.h
trunk/Source/WebCore/html/shadow/ContentDistributor.cpp
trunk/Source/WebCore/html/shadow/ContentDistributor.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (137716 => 137717)
--- trunk/Source/WebCore/ChangeLog 2012-12-14 07:30:53 UTC (rev 137716)
+++ trunk/Source/WebCore/ChangeLog 2012-12-14 07:45:46 UTC (rev 137717)
@@ -1,5 +1,32 @@
2012-12-13 Hajime Morrita
+ContentDistributor and ShadowRootContentDistributionData should use RefPtr to hold elements.
+https://bugs.webkit.org/show_bug.cgi?id=104918
+
+Reviewed by Kentaro Hara.
+
+This change turns some raw pointers to RefPtrs.
+
+No new tests. Hard to write reliable fast tests since the error
+reproduction needs GC to run in certain timing. Although original
+report has a repdocution, it takes a few seconds before crash and
+isn't suited for a layout test.
+
+* dom/ShadowRoot.cpp:
+(WebCore::ShadowRoot::insertionPointList):
+* dom/ShadowRoot.h:
+(ShadowRoot):
+* html/shadow/ContentDistributor.cpp:
+(WebCore::ShadowRootContentDistributionData::ensureInsertionPointList):
+(WebCore::ContentDistributor::findInsertionPointFor):
+(WebCore::ContentDistributor::distribute):
+(WebCore::ContentDistributor::invalidate):
+* html/shadow/ContentDistributor.h:
+(ShadowRootContentDistributionData):
+(ContentDistributor):
+
+2012-12-13 Hajime Morrita
+
NodeRenderingContext is slow due to ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=104332
Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (137716 => 137717)
--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-12-14 07:30:53 UTC (rev 137716)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-12-14 07:45:46 UTC (rev 137717)
@@ -328,9 +328,9 @@
owner()->invalidateDistribution();
}
-const Vector& ShadowRoot::insertionPointList()
+const Vector >& ShadowRoot::insertionPointList()
{
-typedef Vector InsertionPointVector;
+typedef Vector > InsertionPointVector;
DEFINE_STATIC_LOCAL(InsertionPointVector, emptyVector, ());
return distributionData() ? distributionData()->ensureInsertionPointList(this) : emptyVector;
Modified: trunk/Source/WebCore/dom/ShadowRoot.h (137716 => 137717)
--- trunk/Source/WebCore/dom/ShadowRoot.h 2012-12-14 07:30:53 UTC (rev 137716)
+++ trunk/Source/WebCore/dom/ShadowRoot.h 2012-12-14 07:45:46 UTC (rev 137717)
@@ -102,7 +102,7 @@
bool hasElementShadow() const;
unsigned countElementShadow() const;
-const Vector& insertionPointList();
+const Vector >& insertionPointList();
virtual void registerScopedHTMLStyleChild() OVERRIDE;
virtual void unregisterScopedHTMLStyleChild() OVERRIDE;
Modified: trunk/Source/WebCore/html/shadow/ContentDistributor.cpp (137716 => 137717)
--- trunk/Source/WebCore/html/shadow/ContentDistributor.cpp 2012-12-14 07:30:53 UTC (rev 137716)
+++ trunk/Source/WebCore/html/shadow/ContentDistributor.cpp 2012-12-14 07:45:46 UTC (rev 137717)
@@ -91,7 +91,7 @@
m_insertionPointList.clear();
}
-const Vector& ShadowRootContentDistributionData::ensureInsertionPointList(ShadowRoot* shadowRoot)
+const Vector >& ShadowRootContentDistributionData::ensureInsertionPointList(ShadowRoot* shadowRoot)
{
if (m_insertionPointListIsValid)
return m_insertionPointList;
@@ -155,7 +155,7 @@
InsertionPoint* ContentDistributor::findInsertionPointFor(const Node* key) const
{
-return m_nodeToInsertionPoint.get(key);
+return m_nodeToInsertionPoint.get(key).get();
}
void ContentDistributor::populate(Node* node, ContentDistribution& pool)
@@ -193,9 +193,9 @@
for (ShadowRoot* root = host->youngestShadowRoot(); root; root = root->olderShadowRoot()) {
HTMLShado
[webkit-changes] [137716] trunk/Source/WebKit2
Title: [137716] trunk/Source/WebKit2 Revision 137716 Author commit-qu...@webkit.org Date 2012-12-13 23:30:53 -0800 (Thu, 13 Dec 2012) Log Message Fix build warning https://bugs.webkit.org/show_bug.cgi?id=104978 Patch by Sanghyup Lee on 2012-12-13 Reviewed by Kentaro Hara. Initialize parameter 'downloadID' to fix 'unused parameter' build warning. * WebProcess/Downloads/Download.cpp: (WebKit::Download::Download): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (137715 => 137716) --- trunk/Source/WebKit2/ChangeLog 2012-12-14 06:50:52 UTC (rev 137715) +++ trunk/Source/WebKit2/ChangeLog 2012-12-14 07:30:53 UTC (rev 137716) @@ -1,3 +1,15 @@ +2012-12-13 Sanghyup Lee + +Fix build warning +https://bugs.webkit.org/show_bug.cgi?id=104978 + +Reviewed by Kentaro Hara. + +Initialize parameter 'downloadID' to fix 'unused parameter' build warning. + +* WebProcess/Downloads/Download.cpp: +(WebKit::Download::Download): + 2012-12-13 Alexey Proskuryakov Resource loads sometimes stall Modified: trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp (137715 => 137716) --- trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp 2012-12-14 06:50:52 UTC (rev 137715) +++ trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp 2012-12-14 07:30:53 UTC (rev 137716) @@ -46,6 +46,7 @@ Download::Download(DownloadManager& downloadManager, uint64_t downloadID, const ResourceRequest& request) : m_downloadManager(downloadManager) +, m_downloadID(downloadID) , m_request(request) #if USE(CFNETWORK) , m_allowOverwrite(false) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137714] trunk/Tools
Title: [137714] trunk/Tools
Revision 137714
Author e...@webkit.org
Date 2012-12-13 22:41:24 -0800 (Thu, 13 Dec 2012)
Log Message
Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
https://bugs.webkit.org/show_bug.cgi?id=104891
Reviewed by Ryosuke Niwa.
I also implemented a very simple "Sample" Profiler using
Mac OS X's /usr/bin/sample command line tool.
The real reason for this abstraction is to make it easy
to support both perf and pprof on linux which seem to
be about equally popular among those I ask in the Chrome team.
* Scripts/webkitpy/common/system/profiler.py:
(ProfilerFactory.create_profiler):
(ProfilerFactory):
(ProfilerFactory.available_profilers_by_name):
(ProfilerFactory.default_profiler_name):
(Sample):
(Sample.__init__):
(Sample.attach_to_pid):
(Sample.profile_after_exit):
(IProfiler.attach_to_pid):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.__init__):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/profiler.py
trunk/Tools/Scripts/webkitpy/common/system/profiler_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
Diff
Modified: trunk/Tools/ChangeLog (137713 => 137714)
--- trunk/Tools/ChangeLog 2012-12-14 05:43:03 UTC (rev 137713)
+++ trunk/Tools/ChangeLog 2012-12-14 06:41:24 UTC (rev 137714)
@@ -1,5 +1,34 @@
2012-12-13 Eric Seidel
+Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
+https://bugs.webkit.org/show_bug.cgi?id=104891
+
+Reviewed by Ryosuke Niwa.
+
+I also implemented a very simple "Sample" Profiler using
+Mac OS X's /usr/bin/sample command line tool.
+
+The real reason for this abstraction is to make it easy
+to support both perf and pprof on linux which seem to
+be about equally popular among those I ask in the Chrome team.
+
+* Scripts/webkitpy/common/system/profiler.py:
+(ProfilerFactory.create_profiler):
+(ProfilerFactory):
+(ProfilerFactory.available_profilers_by_name):
+(ProfilerFactory.default_profiler_name):
+(Sample):
+(Sample.__init__):
+(Sample.attach_to_pid):
+(Sample.profile_after_exit):
+(IProfiler.attach_to_pid):
+* Scripts/webkitpy/layout_tests/port/driver.py:
+(Driver.__init__):
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner._parse_args):
+
+2012-12-13 Eric Seidel
+
Unreviewed, fixing typo in python unittest.
I changed the default profiler on linux from pprof to perf in
Modified: trunk/Tools/Scripts/webkitpy/common/system/profiler.py (137713 => 137714)
--- trunk/Tools/Scripts/webkitpy/common/system/profiler.py 2012-12-14 05:43:03 UTC (rev 137713)
+++ trunk/Tools/Scripts/webkitpy/common/system/profiler.py 2012-12-14 06:41:24 UTC (rev 137714)
@@ -28,19 +28,44 @@
import logging
import re
+import itertools
_log = logging.getLogger(__name__)
class ProfilerFactory(object):
@classmethod
-def create_profiler(cls, host, executable_path, output_dir, identifier=None):
-if host.platform.is_mac():
-return IProfiler(host, executable_path, output_dir, identifier)
-return Perf(host, executable_path, output_dir, identifier)
+def create_profiler(cls, host, executable_path, output_dir, profiler_name=None, identifier=None):
+profilers = cls.profilers_for_platform(host.platform)
+if not profilers:
+return None
+profiler_name = profiler_name or cls.default_profiler_name(host.platform)
+profiler_class = next(itertools.ifilter(lambda profiler: profiler.name == profiler_name, profilers), None)
+if not profiler_class:
+return None
+return profilers[0](host, executable_path, output_dir, identifier)
+@classmethod
+def default_profiler_name(cls, platform):
+profilers = cls.profilers_for_platform(platform)
+return profilers[0].name if profilers else None
+@classmethod
+def profilers_for_platform(cls, platform):
+# GooglePProf requires TCMalloc/google-perftools, but is available everywhere.
+profilers_by_os_name = {
+'mac': [IProfiler, Sample, GooglePProf],
+'linux': [Perf, GooglePProf],
+# Note: freebsd, win32 have no profilers defined yet, thus --profile will be ignored
+# by default, but a profiler can be selected with --profiler=PROFILER explicitly.
+}
+return profilers_by_os_name.get(platform.os_name, [])
+
+
class Profiler(object):
+# Used by ProfilerFactory to lookup a profiler from the --profiler=NAME option.
+name = None
+
def __init__(self, hos
[webkit-changes] [137713] trunk/Source/WebCore
Title: [137713] trunk/Source/WebCore
Revision 137713
Author tk...@chromium.org
Date 2012-12-13 21:43:03 -0800 (Thu, 13 Dec 2012)
Log Message
Refactoring: Fix indentation of ChromeClient.h
https://bugs.webkit.org/show_bug.cgi?id=104989
Reviewed by Kentaro Hara.
The contents of an outermost namespace block should not be indented.
http://www.webkit.org/coding/coding-style.html#indentation-namespace
No behavior change.
* page/ChromeClient.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ChromeClient.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (137712 => 137713)
--- trunk/Source/WebCore/ChangeLog 2012-12-14 04:56:22 UTC (rev 137712)
+++ trunk/Source/WebCore/ChangeLog 2012-12-14 05:43:03 UTC (rev 137713)
@@ -1,3 +1,17 @@
+2012-12-13 Kent Tamura
+
+Refactoring: Fix indentation of ChromeClient.h
+https://bugs.webkit.org/show_bug.cgi?id=104989
+
+Reviewed by Kentaro Hara.
+
+The contents of an outermost namespace block should not be indented.
+http://www.webkit.org/coding/coding-style.html#indentation-namespace
+
+No behavior change.
+
+* page/ChromeClient.h:
+
2012-12-13 Kunihiko Sakamoto
Seconds/Minutes field of date/time input UI should respect step attribute
Modified: trunk/Source/WebCore/page/ChromeClient.h (137712 => 137713)
--- trunk/Source/WebCore/page/ChromeClient.h 2012-12-14 04:56:22 UTC (rev 137712)
+++ trunk/Source/WebCore/page/ChromeClient.h 2012-12-14 05:43:03 UTC (rev 137713)
@@ -49,341 +49,330 @@
namespace WebCore {
-class AccessibilityObject;
-class DateTimeChooser;
-class DateTimeChooserClient;
-class Element;
-class FileChooser;
-class FileIconLoader;
-class FloatRect;
-class Frame;
-class Geolocation;
-class GraphicsLayer;
-class HTMLInputElement;
-class HitTestResult;
-class IntRect;
-class NavigationAction;
-class Node;
-class Page;
-class PagePopup;
-class PagePopupClient;
-class PagePopupDriver;
-class PopupMenuClient;
-class SecurityOrigin;
-class GraphicsContext3D;
-class Widget;
+class AccessibilityObject;
+class ColorChooser;
+class ColorChooserClient;
+class DateTimeChooser;
+class DateTimeChooserClient;
+class Element;
+class FileChooser;
+class FileIconLoader;
+class FloatRect;
+class Frame;
+class Geolocation;
+class GraphicsContext3D;
+class GraphicsLayer;
+class GraphicsLayerFactory;
+class HitTestResult;
+class HTMLInputElement;
+class IntRect;
+class NavigationAction;
+class Node;
+class Page;
+class PagePopup;
+class PagePopupClient;
+class PagePopupDriver;
+class PopupMenuClient;
+class SecurityOrigin;
+class Widget;
-struct DateTimeChooserParameters;
-struct FrameLoadRequest;
-struct ViewportArguments;
-struct WindowFeatures;
+struct DateTimeChooserParameters;
+struct FrameLoadRequest;
+struct GraphicsDeviceAdapter;
+struct ViewportArguments;
+struct WindowFeatures;
-#if USE(ACCELERATED_COMPOSITING)
-class GraphicsLayer;
-class GraphicsLayerFactory;
-#endif
+class ChromeClient {
+public:
+virtual void chromeDestroyed() = 0;
-#if ENABLE(INPUT_TYPE_COLOR)
-class ColorChooser;
-class ColorChooserClient;
-#endif
+virtual void setWindowRect(const FloatRect&) = 0;
+virtual FloatRect windowRect() = 0;
-#if PLATFORM(WIN) && USE(AVFOUNDATION)
-struct GraphicsDeviceAdapter;
-#endif
+virtual FloatRect pageRect() = 0;
-class ChromeClient {
-public:
-virtual void chromeDestroyed() = 0;
-
-virtual void setWindowRect(const FloatRect&) = 0;
-virtual FloatRect windowRect() = 0;
-
-virtual FloatRect pageRect() = 0;
-
-virtual void focus() = 0;
-virtual void unfocus() = 0;
+virtual void focus() = 0;
+virtual void unfocus() = 0;
-virtual bool canTakeFocus(FocusDirection) = 0;
-virtual void takeFocus(FocusDirection) = 0;
+virtual bool canTakeFocus(FocusDirection) = 0;
+virtual void takeFocus(FocusDirection) = 0;
-virtual void focusedNodeChanged(Node*) = 0;
-virtual void focusedFrameChanged(Frame*) = 0;
+virtual void focusedNodeChanged(Node*) = 0;
+virtual void focusedFrameChanged(Frame*) = 0;
-// The Frame pointer provides the ChromeClient with context about which
-// Frame wants to create the new Page. Also, the newly created window
-// should not be shown to the user until the ChromeClient of the newly
-// created Page has its show method called.
-// The FrameLoadRequest parameter is only for ChromeClient to check if the
-// request could be fulfilled. The ChromeClient should not load the request.
-virtual Page* createWindow(Frame*, const FrameLoadRequest&, const WindowFeatures&, const NavigationAction&) = 0;
-virtual void show() = 0;
+// The Frame pointer provides the ChromeClient with context about whi
[webkit-changes] [137712] trunk
Title: [137712] trunk
Revision 137712
Author commit-qu...@webkit.org
Date 2012-12-13 20:56:22 -0800 (Thu, 13 Dec 2012)
Log Message
Seconds/Minutes field of date/time input UI should respect step attribute
https://bugs.webkit.org/show_bug.cgi?id=104985
Patch by Kunihiko Sakamoto on 2012-12-13
Reviewed by Kent Tamura.
Source/WebCore:
This patch makes step-up/-down UI of the seconds and minutes fields respect
step attribute when possible.
Test: fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField): Compute step parameters for seconds and minutes fields, and pass it to the field element constructors.
(WebCore::DateTimeEditBuilder::createNumericFieldParameters): Added.
* html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement): Use Parameters instead of step and stepBase.
(WebCore::DateTimeMillisecondFieldElement::create): Ditto.
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement): Add Parameters argument.
(WebCore::DateTimeMinuteFieldElement::create): Ditto.
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement): Ditto.
(WebCore::DateTimeSecondFieldElement::create): Ditto.
* html/shadow/DateTimeFieldElements.h:
(DateTimeMillisecondFieldElement): Use Parameters instead of step and stepBase.
(DateTimeMinuteFieldElement): Add Parameters argument.
(DateTimeSecondFieldElement): Ditto.
* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement): Use Parameters instead of step and stepBase.
* html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::Parameters::Parameters):
(Parameters): Added.
LayoutTests:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
Added test cases for seconds and minutes fields.
Update an expectation for milliseconds: value=07:13:00.500, step=0 should round to 07:13:00.000
(setInputAttributes): Set value attribute first to avoid the focused field becomes read-only and unfocused.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt
trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp
trunk/Source/WebCore/html/shadow/DateTimeFieldElements.cpp
trunk/Source/WebCore/html/shadow/DateTimeFieldElements.h
trunk/Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp
trunk/Source/WebCore/html/shadow/DateTimeNumericFieldElement.h
Diff
Modified: trunk/LayoutTests/ChangeLog (137711 => 137712)
--- trunk/LayoutTests/ChangeLog 2012-12-14 04:52:43 UTC (rev 137711)
+++ trunk/LayoutTests/ChangeLog 2012-12-14 04:56:22 UTC (rev 137712)
@@ -1,3 +1,16 @@
+2012-12-13 Kunihiko Sakamoto
+
+Seconds/Minutes field of date/time input UI should respect step attribute
+https://bugs.webkit.org/show_bug.cgi?id=104985
+
+Reviewed by Kent Tamura.
+
+* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
+* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
+Added test cases for seconds and minutes fields.
+Update an expectation for milliseconds: value=07:13:00.500, step=0 should round to 07:13:00.000
+(setInputAttributes): Set value attribute first to avoid the focused field becomes read-only and unfocused.
+
2012-12-13 Ian Vollick
[chromium] Add a virtual test suite for enabling opt-in to composited scrolling
Modified: trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt (137711 => 137712)
--- trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt 2012-12-14 04:52:43 UTC (rev 137711)
+++ trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt 2012-12-14 04:56:22 UTC (rev 137712)
@@ -22,14 +22,66 @@
PASS stepDown("07:13:00.101", 0.100, null, null) is "07:13:00.100"
PASS stepUp("07:13:00.500", 0.0001, null, null) is "07:13:00.501"
PASS stepDown("07:13:00.500", 0.0001, null, null) is "07:13:00.499"
-PASS stepUp("07:13:00.500", 0, null, null) is "07:13:00.501"
-PASS stepDown("07:13:00.500", 0, null, null) is "07:13:00.499"
+PASS stepUp("07:13:00.500", 0, null, null) is "07:13"
+PASS stepDown("07:13:00.500", 0, null, null) is "07:13"
+PASS stepUp("07:13:00.500", 60, null, null) is "07:13"
+PASS stepDown("07:13:00.500", 60, null, null) is "07:13"
PASS stepUp
[webkit-changes] [137711] trunk/Tools
Title: [137711] trunk/Tools Revision 137711 Author e...@webkit.org Date 2012-12-13 20:52:43 -0800 (Thu, 13 Dec 2012) Log Message Unreviewed, fixing typo in python unittest. I changed the default profiler on linux from pprof to perf in bug 104971. I failed to update the unittest results at that time. * Scripts/webkitpy/common/system/profiler_unittest.py: (ProfilerFactoryTest.test_basic): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/system/profiler_unittest.py Diff Modified: trunk/Tools/ChangeLog (137710 => 137711) --- trunk/Tools/ChangeLog 2012-12-14 04:48:11 UTC (rev 137710) +++ trunk/Tools/ChangeLog 2012-12-14 04:52:43 UTC (rev 137711) @@ -1,3 +1,13 @@ +2012-12-13 Eric Seidel + +Unreviewed, fixing typo in python unittest. + +I changed the default profiler on linux from pprof to perf in +bug 104971. I failed to update the unittest results at that time. + +* Scripts/webkitpy/common/system/profiler_unittest.py: +(ProfilerFactoryTest.test_basic): + 2012-12-13 Ian Vollick [chromium] Add a virtual test suite for enabling opt-in to composited scrolling Modified: trunk/Tools/Scripts/webkitpy/common/system/profiler_unittest.py (137710 => 137711) --- trunk/Tools/Scripts/webkitpy/common/system/profiler_unittest.py 2012-12-14 04:48:11 UTC (rev 137710) +++ trunk/Tools/Scripts/webkitpy/common/system/profiler_unittest.py 2012-12-14 04:52:43 UTC (rev 137711) @@ -43,7 +43,7 @@ host.platform.os_name = 'linux' profiler = ProfilerFactory.create_profiler(host, '/bin/executable', '/tmp/output') -self.assertEquals(profiler._output_path, "/tmp/output/test.pprof") +self.assertEquals(profiler._output_path, "/tmp/output/test.data") def test_pprof_output_regexp(self): pprof_output = """ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137710] trunk
Title: [137710] trunk Revision 137710 Author voll...@chromium.org Date 2012-12-13 20:48:11 -0800 (Thu, 13 Dec 2012) Log Message [chromium] Add a virtual test suite for enabling opt-in to composited scrolling https://bugs.webkit.org/show_bug.cgi?id=104911 Reviewed by Dirk Pranke. Tools: Adds two virtual tests suites to run the tests in compositing/overflow/ and scrollbars/ with the flag --enable-accelerated-overflow-scroll, which I've also plumbed through in the usual way. * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: (WebPreferences): * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: (WebTestRunner::WebPreferences::reset): (WebTestRunner::WebPreferences::applyTo): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings): * DumpRenderTree/chromium/TestShell.h: (TestShell::setAcceleratedCompositingForOverflowScrollEnabled): (TestShell): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort.virtual_test_suites): LayoutTests: Updated the test expectations for the virtual test suite to match the usual chromium test expectations. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp trunk/Tools/DumpRenderTree/chromium/TestShell.cpp trunk/Tools/DumpRenderTree/chromium/TestShell.h trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py Diff Modified: trunk/LayoutTests/ChangeLog (137709 => 137710) --- trunk/LayoutTests/ChangeLog 2012-12-14 04:41:58 UTC (rev 137709) +++ trunk/LayoutTests/ChangeLog 2012-12-14 04:48:11 UTC (rev 137710) @@ -1,3 +1,15 @@ +2012-12-13 Ian Vollick + +[chromium] Add a virtual test suite for enabling opt-in to composited scrolling +https://bugs.webkit.org/show_bug.cgi?id=104911 + +Reviewed by Dirk Pranke. + +Updated the test expectations for the virtual test suite to match the +usual chromium test expectations. + +* platform/chromium/TestExpectations: + 2012-12-13 Takashi Sakamoto [Shadow DOM]: scoped styles are not applied in the cascade order. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137709 => 137710) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-14 04:41:58 UTC (rev 137709) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-14 04:48:11 UTC (rev 137710) @@ -3626,8 +3626,11 @@ webkit.org/b/85856 [ Win Mac Android ] fast/block/float/026.html [ ImageOnlyFailure ] webkit.org/b/85856 [ Win Mac Android ] fast/overflow/unreachable-overflow-rtl-bug.html [ Failure ImageOnlyFailure ] webkit.org/b/85856 [ Linux Win SnowLeopard ] scrollbars/rtl/div-absolute.html [ Failure ] +webkit.org/b/85856 [ Linux Win SnowLeopard ] platform/chromium/virtual/gpu/compositedscrolling/scrollbars/rtl/div-absolute.html [ Failure ] webkit.org/b/85856 [ Lion MountainLion ] scrollbars/rtl/div-absolute.html [ Failure Pass ] +webkit.org/b/85856 [ Lion MountainLion ] platform/chromium/virtual/gpu/compositedscrolling/scrollbars/rtl/div-absolute.html [ Failure Pass ] webkit.org/b/85856 scrollbars/rtl/div-horizontal.html [ Failure ] +webkit.org/b/85856 platform/chromium/virtual/gpu/compositedscrolling/scrollbars/rtl/div-horizontal.html [ Failure ] # Bug 93148 changed this to a testRunner test and it started timing out on Mac. webkit.org/b/93148 [ Mac ] fast/css/nested-layers-with-hover.html [ Timeout ] @@ -3693,20 +3696,26 @@ # ENABLE_ACCELERATED_OVERFLOW_SCROLLING is not currently enabled in Chromium. webkit.org/b/94353 compositing/overflow/scrolling-content-clip-to-viewport.html [ Failure ] webkit.org/b/94353 platform/chromium/virtual/softwarecompositing/overflow/scrolling-content-clip-to-viewport.html [ Failure ] +webkit.org/b/94353 platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-content-clip-to-viewport.html [ Failure ] webkit.org/b/94353 compositing/overflow/scrolling-without-painting.html [ Failure ] webkit.org/b/94353 platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting.html [ Failure ] +webkit.org/b/94353 platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting.html [ Failure ] webkit.org/b/94353 compositing/overflow/updating-scrolling-content.html [ Failure ] webkit.org/b/94353 platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content.html [ Failure ] +webkit.org/b/94353 platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content.html [ Failure ] webkit.org/b/94353 compositing/overflow/textarea-scroll-touch.html [ Failure ] webkit.org/b/94353 platform/chromium/virtual/softwarecompositing/overflow/textarea-s
[webkit-changes] [137709] trunk/Source
Title: [137709] trunk/Source
Revision 137709
Author fpi...@apple.com
Date 2012-12-13 20:41:58 -0800 (Thu, 13 Dec 2012)
Log Message
Attempt to rationalize and simplify WTF::binarySearch
https://bugs.webkit.org/show_bug.cgi?id=104890
Reviewed by Maciej Stachowiak.
Source/_javascript_Core:
Switch to using the new binarySearch() API. No change in behavior.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::codeOriginForReturn):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getStubInfo):
(JSC::CodeBlock::getByValInfo):
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
(JSC::CodeBlock::specialFastCaseProfileForBytecodeOffset):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
* dfg/DFGMinifiedGraph.h:
(JSC::DFG::MinifiedGraph::at):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::indexForBytecodeIndex):
Source/WebCore:
Switch to using the new binarySearch() API. No change in behavior, so no new tests.
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::findInstanceTime):
Source/WTF:
Binary search now has three modes:
The default: assert that the key was found, but return an adjacent element if it
wasn't found, if asserts are turned off.
tryBinarySearch: return 0 if the key wasn't found.
approximateBinarySearch: if the key is not found, return an adjacent element (either
the left or right; no guarantee which).
This also reduces the number of variants of binarySearch. The functor variant is now
gone because binarySearch now always uses a functor for the key extractor. The
generic variant is now gone because binarySearch always expects an array type that
can do operator[].
* wtf/StdLibExtras.h:
(WTF::binarySearchImpl):
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGMinifiedGraph.h
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/profiler/ProfilerBytecodeSequence.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/StdLibExtras.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (137708 => 137709)
--- trunk/Source/_javascript_Core/ChangeLog 2012-12-14 04:40:47 UTC (rev 137708)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-12-14 04:41:58 UTC (rev 137709)
@@ -1,5 +1,38 @@
2012-12-13 Filip Pizlo
+Attempt to rationalize and simplify WTF::binarySearch
+https://bugs.webkit.org/show_bug.cgi?id=104890
+
+Reviewed by Maciej Stachowiak.
+
+Switch to using the new binarySearch() API. No change in behavior.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::bytecodeOffset):
+(JSC::CodeBlock::codeOriginForReturn):
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::getStubInfo):
+(JSC::CodeBlock::getByValInfo):
+(JSC::CodeBlock::getCallLinkInfo):
+(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):
+(JSC::CodeBlock::valueProfileForBytecodeOffset):
+(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
+(JSC::CodeBlock::specialFastCaseProfileForBytecodeOffset):
+* dfg/DFGGraph.h:
+(JSC::DFG::Graph::blockIndexForBytecodeOffset):
+* dfg/DFGMinifiedGraph.h:
+(JSC::DFG::MinifiedGraph::at):
+* dfg/DFGOSRExitCompiler32_64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* dfg/DFGOSRExitCompiler64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::LLINT_SLOW_PATH_DECL):
+* profiler/ProfilerBytecodeSequence.cpp:
+(JSC::Profiler::BytecodeSequence::indexForBytecodeIndex):
+
+2012-12-13 Filip Pizlo
+
Don't assert that flags <= 0x3ff in JSTypeInfo
https://bugs.webkit.org/show_bug.cgi?id=104988
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (137708 => 137709)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2012-12-14 04:40:47 UTC (rev 137708)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2012-12-14 04:41:58 UTC (rev 137709)
@@ -2791,7 +2791,8 @@
if (getJITCode().getExecutableMemory()->contains(returnAddress.value())) {
unsigned callReturnOffs
[webkit-changes] [137708] trunk
Title: [137708] trunk Revision 137708 Author ta...@google.com Date 2012-12-13 20:40:47 -0800 (Thu, 13 Dec 2012) Log Message [Shadow DOM]: scoped styles are not applied in the cascade order. https://bugs.webkit.org/show_bug.cgi?id=103239 Reviewed by Dimitri Glazkov. Source/WebCore: If the scoping elements of two declarations have an ancestor/ descendant relationship, the declaration whose scoping element is the descendant should win. c.f. http://dev.w3.org/csswg/css3-cascade/#cascade Test: fast/css/style-scoped/style-scoped-nested.html fast/css/style-scoped/style-scoped-with-important-rule.html * css/RuleSet.cpp: (WebCore::RuleSet::addRule): Removed specificity for @host @-rules. Now @host @-rules use the cascading order instead. * css/RuleSet.h: Removed increaseSpecificity. The method is used by only @host @-rules. * css/StyleResolver.cpp: (WebCore::StyleResolver::matchScopedAuthorRules): (WebCore::StyleResolver::matchHostRules): (WebCore::StyleResolver::matchAuthorRules): Modified to invoke sortAndTransferMatchedRules per scoping element. The order of "matchXXXRules" must be the same as the cascading order. So matchHostRules was invoked after collecting all scoped author rules. * css/StyleScopeResolver.cpp: (WebCore::StyleScopeResolver::addHostRule): Removed RuleIsHostRule. We don't need the flag. * html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::registerWithScopingNode): Needs to pass the last test case of style-scoped-nested.html. When appending some style element to a shadow root, we should recalc styles of all elements in the shadow dom tree. And if the style element has @host @-rules, we have to update the host's style. LayoutTests: * fast/css/style-scoped/style-scoped-nested-expected.txt: Added. * fast/css/style-scoped/style-scoped-nested.html: Added. * fast/css/style-scoped/style-scoped-with-important-rule-expected.txt: Added. * fast/css/style-scoped/style-scoped-with-important-rule.html: Added. * fast/regions/style-scoped-in-flow-override-region-styling-expected.html: * fast/regions/style-scoped-in-flow-override-region-styling.html: Changed the test's expectation. Since @region's scoping element is :root but scoped styles' scoping element is a descendant element of :root, scoped styles should win. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-expected.html trunk/LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/RuleSet.cpp trunk/Source/WebCore/css/RuleSet.h trunk/Source/WebCore/css/StyleResolver.cpp trunk/Source/WebCore/css/StyleScopeResolver.cpp trunk/Source/WebCore/html/HTMLStyleElement.cpp Added Paths trunk/LayoutTests/fast/css/style-scoped/style-scoped-nested-expected.txt trunk/LayoutTests/fast/css/style-scoped/style-scoped-nested.html trunk/LayoutTests/fast/css/style-scoped/style-scoped-with-important-rule-expected.txt trunk/LayoutTests/fast/css/style-scoped/style-scoped-with-important-rule.html Diff Modified: trunk/LayoutTests/ChangeLog (137707 => 137708) --- trunk/LayoutTests/ChangeLog 2012-12-14 04:38:20 UTC (rev 137707) +++ trunk/LayoutTests/ChangeLog 2012-12-14 04:40:47 UTC (rev 137708) @@ -1,3 +1,20 @@ +2012-12-13 Takashi Sakamoto + +[Shadow DOM]: scoped styles are not applied in the cascade order. +https://bugs.webkit.org/show_bug.cgi?id=103239 + +Reviewed by Dimitri Glazkov. + +* fast/css/style-scoped/style-scoped-nested-expected.txt: Added. +* fast/css/style-scoped/style-scoped-nested.html: Added. +* fast/css/style-scoped/style-scoped-with-important-rule-expected.txt: Added. +* fast/css/style-scoped/style-scoped-with-important-rule.html: Added. +* fast/regions/style-scoped-in-flow-override-region-styling-expected.html: +* fast/regions/style-scoped-in-flow-override-region-styling.html: +Changed the test's expectation. +Since @region's scoping element is :root but scoped styles' scoping +element is a descendant element of :root, scoped styles should win. + 2012-12-13 Kentaro Hara ChildNodesLazySnapshot::nextNode() can crash Added: trunk/LayoutTests/fast/css/style-scoped/style-scoped-nested-expected.txt (0 => 137708) --- trunk/LayoutTests/fast/css/style-scoped/style-scoped-nested-expected.txt (rev 0) +++ trunk/LayoutTests/fast/css/style-scoped/style-scoped-nested-expected.txt 2012-12-14 04:40:47 UTC (rev 137708) @@ -0,0 +1,17 @@ +Test whether scoped styles are applied in the cascade order or not. +If this test passes, rules which are declared in descendant scoping element are applied to a target element. +c.f. https://bugs.webkit.org/show_bug.cgi?id=103239 +Only document.style is applied to the target. +PASS window.getComputedStyle(target).color is "rgb(255, 0, 0)" +A new scoped style is inserted into the grandparent node of the target. A class rule in the
[webkit-changes] [137707] trunk/Source/WebCore
Title: [137707] trunk/Source/WebCore
Revision 137707
Author fpi...@apple.com
Date 2012-12-13 20:38:20 -0800 (Thu, 13 Dec 2012)
Log Message
MediaPlayerPrivateAVFoundation::m_inbandTrackConfigurationPending is unused except when HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=104987
Rubber stamped by Michael Saboff.
No change in behavior so no new tests.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (137706 => 137707)
--- trunk/Source/WebCore/ChangeLog 2012-12-14 04:30:20 UTC (rev 137706)
+++ trunk/Source/WebCore/ChangeLog 2012-12-14 04:38:20 UTC (rev 137707)
@@ -1,3 +1,17 @@
+2012-12-13 Filip Pizlo
+
+MediaPlayerPrivateAVFoundation::m_inbandTrackConfigurationPending is unused except when HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT)
+https://bugs.webkit.org/show_bug.cgi?id=104987
+
+Rubber stamped by Michael Saboff.
+
+No change in behavior so no new tests.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
+(MediaPlayerPrivateAVFoundation):
+
2012-12-13 Kentaro Hara
Unreviewed. Rebaselined run-bindings-tests results.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (137706 => 137707)
--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2012-12-14 04:30:20 UTC (rev 137706)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2012-12-14 04:38:20 UTC (rev 137707)
@@ -74,7 +74,9 @@
, m_ignoreLoadStateChanges(false)
, m_haveReportedFirstVideoFrame(false)
, m_playWhenFramesAvailable(false)
+#if HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT)
, m_inbandTrackConfigurationPending(false)
+#endif
{
LOG(Media, "MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation(%p)", this);
}
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h (137706 => 137707)
--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h 2012-12-14 04:30:20 UTC (rev 137706)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h 2012-12-14 04:38:20 UTC (rev 137707)
@@ -296,7 +296,9 @@
bool m_ignoreLoadStateChanges;
bool m_haveReportedFirstVideoFrame;
bool m_playWhenFramesAvailable;
+#if HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT)
bool m_inbandTrackConfigurationPending;
+#endif
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137706] trunk/Tools
Title: [137706] trunk/Tools Revision 137706 Author e...@webkit.org Date 2012-12-13 20:30:20 -0800 (Thu, 13 Dec 2012) Log Message Use 'perf' to profile on linux instead of google-pprof by default https://bugs.webkit.org/show_bug.cgi?id=104971 Reviewed by Dirk Pranke. This makes Chromium Linux match Chromium Android and use the perf tool by default. Once https://bugs.webkit.org/show_bug.cgi?id=104891 lands it will be possible to use pprof again on Linux. This is slightly more advanced than the AndroidPerf profiler as instead of using a timeout on "perf record" I instead watch for the termination of the target process and then control-C the 'perf record' process. This required me to add two new methods to Executive, one to have a limited-time wait() and the second to be able to send a control-C. I chose to add these to Executive to make them easier to mock/fix-for-win32 at a later time if needed. * Scripts/webkitpy/common/system/executive.py: (Executive.wait_limited): (Executive.interrupt): * Scripts/webkitpy/common/system/profiler.py: (ProfilerFactory.create_profiler): (Perf): (Perf.__init__): (Perf._perf_path): (Perf.attach_to_pid): (Perf._first_ten_lines_of_profile): (Perf.profile_after_exit): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/system/executive.py trunk/Tools/Scripts/webkitpy/common/system/profiler.py Diff Modified: trunk/Tools/ChangeLog (137705 => 137706) --- trunk/Tools/ChangeLog 2012-12-14 04:19:09 UTC (rev 137705) +++ trunk/Tools/ChangeLog 2012-12-14 04:30:20 UTC (rev 137706) @@ -1,3 +1,35 @@ +2012-12-13 Eric Seidel + +Use 'perf' to profile on linux instead of google-pprof by default +https://bugs.webkit.org/show_bug.cgi?id=104971 + +Reviewed by Dirk Pranke. + +This makes Chromium Linux match Chromium Android and use the perf +tool by default. Once https://bugs.webkit.org/show_bug.cgi?id=104891 +lands it will be possible to use pprof again on Linux. + +This is slightly more advanced than the AndroidPerf profiler as +instead of using a timeout on "perf record" I instead watch +for the termination of the target process and then control-C +the 'perf record' process. This required me to add two new +methods to Executive, one to have a limited-time wait() and +the second to be able to send a control-C. I chose to add +these to Executive to make them easier to mock/fix-for-win32 +at a later time if needed. + +* Scripts/webkitpy/common/system/executive.py: +(Executive.wait_limited): +(Executive.interrupt): +* Scripts/webkitpy/common/system/profiler.py: +(ProfilerFactory.create_profiler): +(Perf): +(Perf.__init__): +(Perf._perf_path): +(Perf.attach_to_pid): +(Perf._first_ten_lines_of_profile): +(Perf.profile_after_exit): + 2012-12-13 Julie Parent Dashboard cleanup: remove usage of global g_builders. Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (137705 => 137706) --- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2012-12-14 04:19:09 UTC (rev 137705) +++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2012-12-14 04:30:20 UTC (rev 137706) @@ -304,6 +304,13 @@ while self.check_running_pid(pid): time.sleep(0.25) +def wait_limited(self, pid, limit_in_seconds=None, check_frequency_in_seconds=None): +seconds_left = limit_in_seconds or 10 +sleep_length = check_frequency_in_seconds or 1 +while seconds_left > 0 and self.check_running_pid(pid): +seconds_left -= sleep_length +time.sleep(sleep_length) + def _windows_image_name(self, process_name): name, extension = os.path.splitext(process_name) if not extension: @@ -312,6 +319,17 @@ process_name = "%s.exe" % name return process_name +def interrupt(self, pid): +interrupt_signal = signal.SIGINT +# FIXME: The python docs seem to imply that platform == 'win32' may need to use signal.CTRL_C_EVENT +# http://docs.python.org/2/library/signal.html +try: +os.kill(pid, interrupt_signal) +except OSError: +# Silently ignore when the pid doesn't exist. +# It's impossible for callers to avoid race conditions with process shutdown. +pass + def kill_all(self, process_name): """Attempts to kill processes matching process_name. Will fail silently if no process are found.""" Modified: trunk/Tools/Scripts/webkitpy/common/system/profiler.py (137705 => 137706) --- trunk/Tools/Scripts/webkitpy/common/system/profiler.py 2012-12-14 04:19:09 UTC (rev 137705) +++ trunk/Tools/Scripts/webkitpy/common/system/profiler.py 2012-12-14 04:30:20 UTC (rev 137706) @@ -37,7 +37,7 @@ def create_profiler(cls, host, executable_path, output_dir, identifier
[webkit-changes] [137705] trunk/Source/JavaScriptCore
Title: [137705] trunk/Source/_javascript_Core
Revision 137705
Author fpi...@apple.com
Date 2012-12-13 20:19:09 -0800 (Thu, 13 Dec 2012)
Log Message
Don't assert that flags <= 0x3ff in JSTypeInfo
https://bugs.webkit.org/show_bug.cgi?id=104988
Reviewed by Sam Weinig.
This assertion doesn't accomplish anything other than crashes.
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSTypeInfo.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (137704 => 137705)
--- trunk/Source/_javascript_Core/ChangeLog 2012-12-14 04:04:11 UTC (rev 137704)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-12-14 04:19:09 UTC (rev 137705)
@@ -1,5 +1,17 @@
2012-12-13 Filip Pizlo
+Don't assert that flags <= 0x3ff in JSTypeInfo
+https://bugs.webkit.org/show_bug.cgi?id=104988
+
+Reviewed by Sam Weinig.
+
+This assertion doesn't accomplish anything other than crashes.
+
+* runtime/JSTypeInfo.h:
+(JSC::TypeInfo::TypeInfo):
+
+2012-12-13 Filip Pizlo
+
Named lookups on HTML documents produce inconsistent results in _javascript_Core bindings
https://bugs.webkit.org/show_bug.cgi?id=104623
Modified: trunk/Source/_javascript_Core/runtime/JSTypeInfo.h (137704 => 137705)
--- trunk/Source/_javascript_Core/runtime/JSTypeInfo.h 2012-12-14 04:04:11 UTC (rev 137704)
+++ trunk/Source/_javascript_Core/runtime/JSTypeInfo.h 2012-12-14 04:19:09 UTC (rev 137705)
@@ -55,7 +55,6 @@
, m_flags(flags & 0xff)
, m_flags2(flags >> 8)
{
-ASSERT(flags <= 0x3ff);
ASSERT(static_cast(type) <= 0xff);
ASSERT(type >= CompoundType || !(flags & OverridesVisitChildren));
// No object that doesn't ImplementsHasInstance should override it!
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137704] trunk/Source/WebCore
Title: [137704] trunk/Source/WebCore Revision 137704 Author hara...@chromium.org Date 2012-12-13 20:04:11 -0800 (Thu, 13 Dec 2012) Log Message Unreviewed. Rebaselined run-bindings-tests results. * bindings/scripts/test/JS/JSTestCustomNamedGetter.h: (JSTestCustomNamedGetter): * bindings/scripts/test/JS/JSTestEventTarget.h: (JSTestEventTarget): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.h trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h Diff Modified: trunk/Source/WebCore/ChangeLog (137703 => 137704) --- trunk/Source/WebCore/ChangeLog 2012-12-14 03:47:00 UTC (rev 137703) +++ trunk/Source/WebCore/ChangeLog 2012-12-14 04:04:11 UTC (rev 137704) @@ -1,3 +1,12 @@ +2012-12-13 Kentaro Hara + +Unreviewed. Rebaselined run-bindings-tests results. + +* bindings/scripts/test/JS/JSTestCustomNamedGetter.h: +(JSTestCustomNamedGetter): +* bindings/scripts/test/JS/JSTestEventTarget.h: +(JSTestEventTarget): + 2012-12-13 Yoshifumi Inoue Unreviewed, rolling out r137691. Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.h (137703 => 137704) --- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.h 2012-12-14 03:47:00 UTC (rev 137703) +++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.h 2012-12-14 04:04:11 UTC (rev 137704) @@ -63,7 +63,7 @@ protected: JSTestCustomNamedGetter(JSC::Structure*, JSDOMGlobalObject*, PassRefPtr); void finishCreation(JSC::JSGlobalData&); -static const unsigned StructureFlags = JSC::OverridesGetOwnPropertySlot | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | Base::StructureFlags; +static const unsigned StructureFlags = JSC::OverridesGetOwnPropertySlot | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::HasImpureGetOwnPropertySlot | Base::StructureFlags; private: static bool canGetItemsForName(JSC::ExecState*, TestCustomNamedGetter*, JSC::PropertyName); static JSC::JSValue nameGetter(JSC::ExecState*, JSC::JSValue, JSC::PropertyName); Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h (137703 => 137704) --- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h 2012-12-14 03:47:00 UTC (rev 137703) +++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h 2012-12-14 04:04:11 UTC (rev 137704) @@ -67,7 +67,7 @@ protected: JSTestEventTarget(JSC::Structure*, JSDOMGlobalObject*, PassRefPtr); void finishCreation(JSC::JSGlobalData&); -static const unsigned StructureFlags = JSC::OverridesGetPropertyNames | JSC::OverridesGetOwnPropertySlot | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesVisitChildren | JSC::MasqueradesAsUndefined | Base::StructureFlags; +static const unsigned StructureFlags = JSC::OverridesGetPropertyNames | JSC::OverridesGetOwnPropertySlot | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesVisitChildren | JSC::MasqueradesAsUndefined | JSC::HasImpureGetOwnPropertySlot | Base::StructureFlags; static JSC::JSValue indexGetter(JSC::ExecState*, JSC::JSValue, unsigned); private: static bool canGetItemsForName(JSC::ExecState*, TestEventTarget*, JSC::PropertyName); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137703] trunk/Source/WebCore
Title: [137703] trunk/Source/WebCore Revision 137703 Author yo...@chromium.org Date 2012-12-13 19:47:00 -0800 (Thu, 13 Dec 2012) Log Message Unreviewed, rolling out r137691. http://trac.webkit.org/changeset/137691 https://bugs.webkit.org/show_bug.cgi?id=104764 panscroll test on AppleWin failed * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * page/AutoscrollController.cpp: Removed. * page/AutoscrollController.h: Removed. * page/EventHandler.cpp: (WebCore): (WebCore::EventHandler::EventHandler): (WebCore::canAutoscroll): (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::handleAutoscroll): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::startPanScrolling): (WebCore::EventHandler::updatePanScrollState): (WebCore::EventHandler::autoscrollRenderer): (WebCore::EventHandler::updateAutoscrollRenderer): (WebCore::EventHandler::setAutoscrollRenderer): (WebCore::EventHandler::startAutoscrollTimer): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::keyEvent): * page/EventHandler.h: (EventHandler): (WebCore::EventHandler::autoscrollInProgress): * rendering/RenderBox.cpp: * rendering/RenderBox.h: (RenderBox): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/EventHandler.h trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h Removed Paths trunk/Source/WebCore/page/AutoscrollController.cpp trunk/Source/WebCore/page/AutoscrollController.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (137702 => 137703) --- trunk/Source/WebCore/CMakeLists.txt 2012-12-14 03:42:14 UTC (rev 137702) +++ trunk/Source/WebCore/CMakeLists.txt 2012-12-14 03:47:00 UTC (rev 137703) @@ -1719,7 +1719,6 @@ mathml/MathMLMathElement.cpp mathml/MathMLTextElement.cpp -page/AutoscrollController.cpp page/BarInfo.cpp page/Chrome.cpp page/Console.cpp Modified: trunk/Source/WebCore/ChangeLog (137702 => 137703) --- trunk/Source/WebCore/ChangeLog 2012-12-14 03:42:14 UTC (rev 137702) +++ trunk/Source/WebCore/ChangeLog 2012-12-14 03:47:00 UTC (rev 137703) @@ -1,3 +1,44 @@ +2012-12-13 Yoshifumi Inoue + +Unreviewed, rolling out r137691. +http://trac.webkit.org/changeset/137691 +https://bugs.webkit.org/show_bug.cgi?id=104764 + +panscroll test on AppleWin failed + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* page/AutoscrollController.cpp: Removed. +* page/AutoscrollController.h: Removed. +* page/EventHandler.cpp: +(WebCore): +(WebCore::EventHandler::EventHandler): +(WebCore::canAutoscroll): +(WebCore::EventHandler::handleMouseDraggedEvent): +(WebCore::EventHandler::handleMouseReleaseEvent): +(WebCore::EventHandler::handleAutoscroll): +(WebCore::EventHandler::autoscrollTimerFired): +(WebCore::EventHandler::startPanScrolling): +(WebCore::EventHandler::updatePanScrollState): +(WebCore::EventHandler::autoscrollRenderer): +(WebCore::EventHandler::updateAutoscrollRenderer): +(WebCore::EventHandler::setAutoscrollRenderer): +(WebCore::EventHandler::startAutoscrollTimer): +(WebCore::EventHandler::stopAutoscrollTimer): +(WebCore::EventHandler::selectCursor): +(WebCore::EventHandler::handleMousePressEvent): +(WebCore::EventHandler::keyEvent): +* page/EventHandler.h: +(EventHandler): +(WebCore::EventHandler::autoscrollInProgress): +* rendering/RenderBox.cpp: +* rendering/RenderBox.h: +(RenderBox): + 2012-12-13 Kentaro Hara ChildNodesLazySnapshot::nextNode() can crash Modified: trunk/Source/WebCore/GNUmakefile.list.am (137702 => 137703) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-12-14 03:42:14 UTC (rev 137702) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-12-14 03:47:00 UTC (rev 137703) @@ -4002,8 +4002,6 @@ Source/WebCore/page/animation/KeyframeAnimation.h \ Source/WebCore/page/AdjustViewSizeOrNot.h \ Source/WebCore/page/AlternativeTextClient.h \ - Source/WebCore/page/AutoscrollController.cpp \ - Source/WebCore/page/AutoscrollController.h \ Source/WebCore/page/BarInfo.cpp \ Source/WebCore/page/BarInfo.h \ Source/WebCore/page/Chrome.cpp \ Modified: trunk/Sou
[webkit-changes] [137702] trunk
Title: [137702] trunk
Revision 137702
Author hara...@chromium.org
Date 2012-12-13 19:42:14 -0800 (Thu, 13 Dec 2012)
Log Message
ChildNodesLazySnapshot::nextNode() can crash
https://bugs.webkit.org/show_bug.cgi?id=104982
Reviewed by Hajime Morita.
ChildNodesLazySnapshot::nextNode() can crash for
fast/dom/insertedIntoDocument-no-crash.html.
The root cause is that ChildNodesLazySnapshot::m_currentNode
was not a RefPtr. This patch changes it to a RefPtr.
Test: fast/dom/insertedIntoDocument-no-crash.html
Source/WebCore:
* dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::nextNode):
(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(ChildNodesLazySnapshot):
LayoutTests:
* fast/dom/insertedIntoDocument-no-crash-expected.txt: Added.
* fast/dom/insertedIntoDocument-no-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.h
Added Paths
trunk/LayoutTests/fast/dom/insertedIntoDocument-no-crash-expected.txt
trunk/LayoutTests/fast/dom/insertedIntoDocument-no-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137701 => 137702)
--- trunk/LayoutTests/ChangeLog 2012-12-14 03:28:45 UTC (rev 137701)
+++ trunk/LayoutTests/ChangeLog 2012-12-14 03:42:14 UTC (rev 137702)
@@ -1,3 +1,20 @@
+2012-12-13 Kentaro Hara
+
+ChildNodesLazySnapshot::nextNode() can crash
+https://bugs.webkit.org/show_bug.cgi?id=104982
+
+Reviewed by Hajime Morita.
+
+ChildNodesLazySnapshot::nextNode() can crash for
+fast/dom/insertedIntoDocument-no-crash.html.
+The root cause is that ChildNodesLazySnapshot::m_currentNode
+was not a RefPtr. This patch changes it to a RefPtr.
+
+Test: fast/dom/insertedIntoDocument-no-crash.html
+
+* fast/dom/insertedIntoDocument-no-crash-expected.txt: Added.
+* fast/dom/insertedIntoDocument-no-crash.html: Added.
+
2012-12-13 Philip Rogers
Clear m_timeContainer on SVGSMILElement removal.
Added: trunk/LayoutTests/fast/dom/insertedIntoDocument-no-crash-expected.txt (0 => 137702)
--- trunk/LayoutTests/fast/dom/insertedIntoDocument-no-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/insertedIntoDocument-no-crash-expected.txt 2012-12-14 03:42:14 UTC (rev 137702)
@@ -0,0 +1,8 @@
+CONSOLE MESSAGE: line 14: Uncaught Error: NotFoundError: DOM Exception 8
+This test must not crash.
+
+foo
+
+f1();
+
+foo
Added: trunk/LayoutTests/fast/dom/insertedIntoDocument-no-crash.html (0 => 137702)
--- trunk/LayoutTests/fast/dom/insertedIntoDocument-no-crash.html (rev 0)
+++ trunk/LayoutTests/fast/dom/insertedIntoDocument-no-crash.html 2012-12-14 03:42:14 UTC (rev 137702)
@@ -0,0 +1,27 @@
+
+This test must not crash.
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function f1() {
+document.write('
[webkit-changes] [137701] trunk
Title: [137701] trunk
Revision 137701
Author p...@google.com
Date 2012-12-13 19:28:45 -0800 (Thu, 13 Dec 2012)
Log Message
Clear m_timeContainer on SVGSMILElement removal.
https://bugs.webkit.org/show_bug.cgi?id=104972
Reviewed by Abhishek Arya.
Source/WebCore:
This patch fixes a regression introduced by r137509 where we did not clear
m_timeContainer in SVGSMILElement::removedFrom.
Test: svg/custom/removed-from-animation-crash.html
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::removedFrom):
LayoutTests:
* svg/custom/removed-from-animation-crash-expected.txt: Added.
* svg/custom/removed-from-animation-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp
Added Paths
trunk/LayoutTests/svg/custom/removed-from-animation-crash-expected.txt
trunk/LayoutTests/svg/custom/removed-from-animation-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137700 => 137701)
--- trunk/LayoutTests/ChangeLog 2012-12-14 03:24:28 UTC (rev 137700)
+++ trunk/LayoutTests/ChangeLog 2012-12-14 03:28:45 UTC (rev 137701)
@@ -1,3 +1,13 @@
+2012-12-13 Philip Rogers
+
+Clear m_timeContainer on SVGSMILElement removal.
+https://bugs.webkit.org/show_bug.cgi?id=104972
+
+Reviewed by Abhishek Arya.
+
+* svg/custom/removed-from-animation-crash-expected.txt: Added.
+* svg/custom/removed-from-animation-crash.html: Added.
+
2012-12-13 Filip Pizlo
Named lookups on HTML documents produce inconsistent results in _javascript_Core bindings
Added: trunk/LayoutTests/svg/custom/removed-from-animation-crash-expected.txt (0 => 137701)
--- trunk/LayoutTests/svg/custom/removed-from-animation-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/removed-from-animation-crash-expected.txt 2012-12-14 03:28:45 UTC (rev 137701)
@@ -0,0 +1 @@
+PASS: test did not crash
Added: trunk/LayoutTests/svg/custom/removed-from-animation-crash.html (0 => 137701)
--- trunk/LayoutTests/svg/custom/removed-from-animation-crash.html (rev 0)
+++ trunk/LayoutTests/svg/custom/removed-from-animation-crash.html 2012-12-14 03:28:45 UTC (rev 137701)
@@ -0,0 +1,35 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+ }
+
+ function crash() {
+var notInDocRect = document.createElementNS("http://www.w3.org/2000/svg", "rect");
+setTimeout(function() {
+ var g2 = document.getElementById('g2');
+ g2.parentNode.removeChild(g2);
+ document.getElementById('g1').appendChild(document.getElementById('animate'));
+ notInDocRect.appendChild(document.getElementById('rect1'));
+ document.getElementById('body').innerHTML = "PASS: test did not crash";
+
+ if (window.testRunner)
+testRunner.notifyDone();
+}, 1);
+ }
+
+
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (137700 => 137701)
--- trunk/Source/WebCore/ChangeLog 2012-12-14 03:24:28 UTC (rev 137700)
+++ trunk/Source/WebCore/ChangeLog 2012-12-14 03:28:45 UTC (rev 137701)
@@ -1,3 +1,18 @@
+2012-12-13 Philip Rogers
+
+Clear m_timeContainer on SVGSMILElement removal.
+https://bugs.webkit.org/show_bug.cgi?id=104972
+
+Reviewed by Abhishek Arya.
+
+This patch fixes a regression introduced by r137509 where we did not clear
+m_timeContainer in SVGSMILElement::removedFrom.
+
+Test: svg/custom/removed-from-animation-crash.html
+
+* svg/animation/SVGSMILElement.cpp:
+(WebCore::SVGSMILElement::removedFrom):
+
2012-12-13 Filip Pizlo
Named lookups on HTML documents produce inconsistent results in _javascript_Core bindings
Modified: trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp (137700 => 137701)
--- trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2012-12-14 03:24:28 UTC (rev 137700)
+++ trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2012-12-14 03:28:45 UTC (rev 137701)
@@ -278,6 +278,7 @@
setTargetElement(0);
setAttributeName(anyQName());
animationAttributeChanged();
+m_timeContainer = 0;
}
SVGElement::removedFrom(rootParent);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137700] trunk
Title: [137700] trunk Revision 137700 Author fpi...@apple.com Date 2012-12-13 19:24:28 -0800 (Thu, 13 Dec 2012) Log Message Named lookups on HTML documents produce inconsistent results in _javascript_Core bindings https://bugs.webkit.org/show_bug.cgi?id=104623 Reviewed by Geoffrey Garen. Source/_javascript_Core: Add the notion of objects that HasImpureGetOwnPropertySlot, and use that to inhibit prototype chain caching in some cases. This appears to be perf-neutral on benchmarks that we track. * dfg/DFGRepatch.cpp: (JSC::DFG::tryCacheGetByID): (JSC::DFG::tryBuildGetByIDProtoList): * jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION): * runtime/JSTypeInfo.h: (JSC): (JSC::TypeInfo::hasImpureGetOwnPropertySlot): * runtime/Operations.h: (JSC::normalizePrototypeChainForChainAccess): Source/WebCore: All DOM objects that have named getters or directly override getOwnPropertySlot are now marked as HasImpureGetOwnPropertySlot. Tests: fast/js/prototype-chain-caching-with-impure-get-own-property-slot-traps fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): LayoutTests: * fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Added. * fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Added. * fast/js/prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Added. * fast/js/prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Added. * fast/js/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Added. (f): * fast/js/script-tests/prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Added. (f): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGRepatch.cpp trunk/Source/_javascript_Core/jit/JITStubs.cpp trunk/Source/_javascript_Core/runtime/JSTypeInfo.h trunk/Source/_javascript_Core/runtime/Operations.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm Added Paths trunk/LayoutTests/fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt trunk/LayoutTests/fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html trunk/LayoutTests/fast/js/prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt trunk/LayoutTests/fast/js/prototype-chain-caching-with-impure-get-own-property-slot-traps.html trunk/LayoutTests/fast/js/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js trunk/LayoutTests/fast/js/script-tests/prototype-chain-caching-with-impure-get-own-property-slot-traps.js Diff Modified: trunk/LayoutTests/ChangeLog (137699 => 137700) --- trunk/LayoutTests/ChangeLog 2012-12-14 03:16:43 UTC (rev 137699) +++ trunk/LayoutTests/ChangeLog 2012-12-14 03:24:28 UTC (rev 137700) @@ -1,3 +1,19 @@ +2012-12-13 Filip Pizlo + +Named lookups on HTML documents produce inconsistent results in _javascript_Core bindings +https://bugs.webkit.org/show_bug.cgi?id=104623 + +Reviewed by Geoffrey Garen. + +* fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Added. +* fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Added. +* fast/js/prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Added. +* fast/js/prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Added. +* fast/js/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Added. +(f): +* fast/js/script-tests/prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Added. +(f): + 2012-12-13 Noel Gordon [chromium] Unreviewed gardening. Added: trunk/LayoutTests/fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt (0 => 137700) --- trunk/LayoutTests/fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt (rev 0) +++ trunk/LayoutTests/fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt 2012-12-14 03:24:28 UTC (rev 137700) @@ -0,0 +1,409 @@ +Tests what happens when you make prototype chain accesses with impure GetOwnPropertySlot traps in the way. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS typeof f() is "function" +PASS type
[webkit-changes] [137699] trunk/Source/JavaScriptCore
Title: [137699] trunk/Source/_javascript_Core
Revision 137699
Author fpi...@apple.com
Date 2012-12-13 19:16:43 -0800 (Thu, 13 Dec 2012)
Log Message
Unreviewed, roll out http://trac.webkit.org/changeset/137683.
It broke gmail.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC):
* runtime/Operations.h:
(JSC):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGCapabilities.h
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/runtime/Operations.cpp
trunk/Source/_javascript_Core/runtime/Operations.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (137698 => 137699)
--- trunk/Source/_javascript_Core/ChangeLog 2012-12-14 03:13:27 UTC (rev 137698)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-12-14 03:16:43 UTC (rev 137699)
@@ -1,3 +1,33 @@
+2012-12-13 Filip Pizlo
+
+Unreviewed, roll out http://trac.webkit.org/changeset/137683.
+It broke gmail.
+
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::execute):
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGCSEPhase.cpp:
+(JSC::DFG::CSEPhase::putStructureStoreElimination):
+(JSC::DFG::CSEPhase::performNodeCSE):
+* dfg/DFGCapabilities.h:
+(JSC::DFG::canCompileOpcode):
+* dfg/DFGNodeType.h:
+(DFG):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGPredictionPropagationPhase.cpp:
+(JSC::DFG::PredictionPropagationPhase::propagate):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* runtime/Operations.cpp:
+(JSC::jsTypeStringForValue):
+(JSC):
+* runtime/Operations.h:
+(JSC):
+
2012-13-11 Oliver Hunt
Support op_typeof in the DFG
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (137698 => 137699)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-12-14 03:13:27 UTC (rev 137698)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-12-14 03:16:43 UTC (rev 137699)
@@ -31,7 +31,6 @@
#include "CodeBlock.h"
#include "DFGBasicBlock.h"
#include "GetByIdStatus.h"
-#include "Operations.h"
#include "PutByIdStatus.h"
namespace JSC { namespace DFG {
@@ -708,11 +707,6 @@
case IsString:
constantWasSet = trySetConstant(nodeIndex, jsBoolean(isJSString(child)));
break;
-case IsObject:
-if (child.isNull() || !child.isObject()) {
-constantWasSet = trySetConstant(nodeIndex, jsBoolean(child.isNull()));
-break;
-}
default:
constantWasSet = false;
break;
@@ -722,64 +716,9 @@
break;
}
}
-
forNode(nodeIndex).set(SpecBoolean);
break;
}
-
-case TypeOf: {
-JSGlobalData* globalData = m_codeBlock->globalData();
-JSValue child = forNode(node.child1()).value();
-AbstractValue& abstractChild = forNode(node.child1());
-if (child) {
-JSValue typeString = jsTypeStringForValue(*globalData, m_codeBlock->globalObjectFor(node.codeOrigin), child);
-if (trySetConstant(nodeIndex, typeString)) {
-m_foundConstants = true;
-break;
-}
-} else if (isNumberSpeculation(abstractChild.m_type)) {
-if (trySetConstant(nodeIndex, globalData->smallStrings.numberString(globalData))) {
-forNode(node.child1()).filter(SpecNumber);
-m_foundConstants = true;
-break;
-}
-} else if (isStringSpeculation(abstractChild.m_type)) {
-if (trySetConstant(nod
[webkit-changes] [137697] trunk
Title: [137697] trunk
Revision 137697
Author wangxian...@chromium.org
Date 2012-12-13 18:58:39 -0800 (Thu, 13 Dec 2012)
Log Message
Out-of-view check of fixed position element in frame is incorrect when page is scaled
https://bugs.webkit.org/show_bug.cgi?id=104943
Reviewed by Simon Fraser.
Source/WebCore:
Use frameScaleFactor instead of pageScaleFactor to scale the layer bounds.
Tests: compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html
compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
LayoutTests:
Test cases.
* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt: Added.
* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll-expected.txt: Added.
* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html: Added.
* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html: Added.
* compositing/layer-creation/resources/fixed-position-out-of-view-frame-scroll.html: Added.
* compositing/layer-creation/resources/fixed-position-out-of-view-frame.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Added Paths
trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt
trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll-expected.txt
trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html
trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html
trunk/LayoutTests/compositing/layer-creation/resources/
trunk/LayoutTests/compositing/layer-creation/resources/fixed-position-out-of-view-frame-scroll.html
trunk/LayoutTests/compositing/layer-creation/resources/fixed-position-out-of-view-frame.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137696 => 137697)
--- trunk/LayoutTests/ChangeLog 2012-12-14 02:24:13 UTC (rev 137696)
+++ trunk/LayoutTests/ChangeLog 2012-12-14 02:58:39 UTC (rev 137697)
@@ -1,3 +1,19 @@
+2012-12-13 Xianzhu Wang
+
+Out-of-view check of fixed position element in frame is incorrect when page is scaled
+https://bugs.webkit.org/show_bug.cgi?id=104943
+
+Reviewed by Simon Fraser.
+
+Test cases.
+
+* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt: Added.
+* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll-expected.txt: Added.
+* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html: Added.
+* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html: Added.
+* compositing/layer-creation/resources/fixed-position-out-of-view-frame-scroll.html: Added.
+* compositing/layer-creation/resources/fixed-position-out-of-view-frame.html: Added.
+
2012-12-13 Bear Travis
Positioned replaced elements should resolve vertical margins against their
Added: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt (0 => 137697)
--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt 2012-12-14 02:58:39 UTC (rev 137697)
@@ -0,0 +1,2 @@
+
+PASS
Added: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll-expected.txt (0 => 137697)
--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll-expected.txt 2012-12-14 02:58:39 UTC (rev 137697)
@@ -0,0 +1,2 @@
+
+PASS
Added: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html (0 => 137697)
--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html (rev 0)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html 2012-12-14 02:58:39 UTC (rev 137697)
@@ -0,0 +1,35 @@
+
+
+
+
+ if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+ }
+ if (window.internals) {
+window.internals.settings.setEnableCompositingForFixedPosition(true);
+window.internals.settings.setFixedPositionCreatesStackingContext(true);
+
+addEventListener("load", function() {
+ window.internals.setPageScaleFactor(0.5, 0, 0);
+ setTimeout(function() {
+var layerTreeScaledDown = internals.layerTreeAsText(document.getElementById("iframe").contentDocum
[webkit-changes] [137696] branches/chromium/1312
Title: [137696] branches/chromium/1312
Revision 137696
Author cev...@google.com
Date 2012-12-13 18:24:13 -0800 (Thu, 13 Dec 2012)
Log Message
Merge 136554
BUG=158533
Review URL: https://codereview.chromium.org/11569024
Modified Paths
branches/chromium/1312/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
branches/chromium/1312/LayoutTests/mathml/mfenced-root-layer-expected.txt
branches/chromium/1312/LayoutTests/mathml/mfenced-root-layer.html
Diff
Copied: branches/chromium/1312/LayoutTests/mathml/mfenced-root-layer-expected.txt (from rev 136554, trunk/LayoutTests/mathml/mfenced-root-layer-expected.txt) (0 => 137696)
--- branches/chromium/1312/LayoutTests/mathml/mfenced-root-layer-expected.txt (rev 0)
+++ branches/chromium/1312/LayoutTests/mathml/mfenced-root-layer-expected.txt 2012-12-14 02:24:13 UTC (rev 137696)
@@ -0,0 +1,2 @@
+Bug 100764: Heap-use-after-free in WebCore::RenderLayer::paintList [MathML]
+This test passes if it does not crash.
Copied: branches/chromium/1312/LayoutTests/mathml/mfenced-root-layer.html (from rev 136554, trunk/LayoutTests/mathml/mfenced-root-layer.html) (0 => 137696)
--- branches/chromium/1312/LayoutTests/mathml/mfenced-root-layer.html (rev 0)
+++ branches/chromium/1312/LayoutTests/mathml/mfenced-root-layer.html 2012-12-14 02:24:13 UTC (rev 137696)
@@ -0,0 +1,16 @@
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var mfenced = document.createElementNS("http://www.w3.org/1998/Math/MathML", "mfenced");
+
+var docElt = document.documentElement;
+docElt.parentNode.removeChild(docElt);
+
+document.appendChild(mfenced);
+
+var e = document.createElement("div");
+e.innerHTML = "Bug 100764: Heap-use-after-free in WebCore::RenderLayer::paintList [MathML]
This test passes if it does not crash.";
+mfenced.appendChild(e);
+
Modified: branches/chromium/1312/Source/WebCore/rendering/RenderLayer.cpp (137695 => 137696)
--- branches/chromium/1312/Source/WebCore/rendering/RenderLayer.cpp 2012-12-14 02:13:33 UTC (rev 137695)
+++ branches/chromium/1312/Source/WebCore/rendering/RenderLayer.cpp 2012-12-14 02:24:13 UTC (rev 137696)
@@ -960,8 +960,10 @@
RenderLayer* RenderLayer::stackingContext() const
{
RenderLayer* layer = parent();
-while (layer && !layer->isRootLayer() && !layer->renderer()->isRoot() && layer->renderer()->style()->hasAutoZIndex())
+while (layer && !layer->isStackingContext())
layer = layer->parent();
+
+ASSERT(!layer || layer->isStackingContext());
return layer;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137695] trunk
Title: [137695] trunk
Revision 137695
Author commit-qu...@webkit.org
Date 2012-12-13 18:13:33 -0800 (Thu, 13 Dec 2012)
Log Message
Source/WebCore: Positioned replaced elements should resolve vertical margins against their containing
block's logical width
https://bugs.webkit.org/show_bug.cgi?id=103579
Patch by Bear Travis on 2012-12-13
Reviewed by Emil A Eklund.
According to the CSS box model & writing modes specifications, percentage margin
& padding values, including top & bottom, should be resolved based on the
containing block's logical width (logical with respect to the containing block's
writing mode).
http://www.w3.org/TR/CSS2/box.html#margin-properties
http://dev.w3.org/csswg/css3-writing-modes/#dimension-mapping
Previously, a positioned replaced element resolved margin before/after relative to
its inline direction (containerLogicalHeight), and margin start/end relative to
its block direction (containerLogicalWidth). This patch measures the container's
logical width in its own inline direction (containerRelativeLogicalWidth) to
resolve all margin percentage values.
Test: fast/writing-mode/percentage-margins-absolute-replaced.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Calculate the logical
width of the container, and use it to calculate margins.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced): Ditto.
LayoutTests: Positioned replaced elements should resolve vertical margins against their
containing block's logical width
https://bugs.webkit.org/show_bug.cgi?id=103579
Patch by Bear Travis on 2012-12-13
Reviewed by Emil A Eklund.
Test that different writing mode combinations between a parent and child correctly
compute percentage margins for an absolutely positioned replaced child.
* fast/writing-mode/percentage-margins-absolute-replaced-expected.txt: Added.
* fast/writing-mode/percentage-margins-absolute-replaced.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
Added Paths
trunk/LayoutTests/fast/writing-mode/percentage-margins-absolute-replaced-expected.txt
trunk/LayoutTests/fast/writing-mode/percentage-margins-absolute-replaced.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137694 => 137695)
--- trunk/LayoutTests/ChangeLog 2012-12-14 02:12:05 UTC (rev 137694)
+++ trunk/LayoutTests/ChangeLog 2012-12-14 02:13:33 UTC (rev 137695)
@@ -1,3 +1,17 @@
+2012-12-13 Bear Travis
+
+Positioned replaced elements should resolve vertical margins against their
+containing block's logical width
+https://bugs.webkit.org/show_bug.cgi?id=103579
+
+Reviewed by Emil A Eklund.
+
+Test that different writing mode combinations between a parent and child correctly
+compute percentage margins for an absolutely positioned replaced child.
+
+* fast/writing-mode/percentage-margins-absolute-replaced-expected.txt: Added.
+* fast/writing-mode/percentage-margins-absolute-replaced.html: Added.
+
2012-12-13 Rick Byers
Layout Test fast/events/mouse-cursor-image-set.html is flaky
Added: trunk/LayoutTests/fast/writing-mode/percentage-margins-absolute-replaced-expected.txt (0 => 137695)
--- trunk/LayoutTests/fast/writing-mode/percentage-margins-absolute-replaced-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/writing-mode/percentage-margins-absolute-replaced-expected.txt 2012-12-14 02:13:33 UTC (rev 137695)
@@ -0,0 +1,18 @@
+Percentage margins on absolutely positioned replaced elements are relative to the container's logical width.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS "10px 20px 30px 40px" is "10px 20px 30px 40px"
+PASS "10px 20px 30px 40px" is "10px 20px 30px 40px"
+PASS "10px 20px 30px 40px" is "10px 20px 30px 40px"
+PASS "10px 20px 30px 40px" is "10px 20px 30px 40px"
+PASS "10px 20px 30px 40px" is "10px 20px 30px 40px"
+PASS "10px 20px 30px 40px" is "10px 20px 30px 40px"
+PASS "10px 20px 30px 40px" is "10px 20px 30px 40px"
+PASS "10px 20px 30px 40px" is "10px 20px 30px 40px"
+PASS "10px 20px 30px 40px" is "10px 20px 30px 40px"
+
Added: trunk/LayoutTests/fast/writing-mode/percentage-margins-absolute-replaced.html (0 => 137695)
--- trunk/LayoutTests/fast/writing-mode/percentage-margins-absolute-replaced.html (rev 0)
+++ trunk/LayoutTests/fast/writing-mode/percentage-margins-absolute-replaced.html 2012-12-14 02:13:33 UTC (rev 137695)
@@ -0,0 +1,81 @@
+
+
+
+
+
+description('Percentage margins on absolutely positioned replaced elements are relative to the container\'s logical width.');
+
+window._onload_ = function() {
+var inners = document.querySelectorAll('.inner');
+for (var i = 0; i < inners.length; i++) {
+var inner = inners.item(i);
+var style = getComputedStyle(inner);
+shouldBe('"' + st
[webkit-changes] [137694] branches/chromium/1312
Title: [137694] branches/chromium/1312
Revision 137694
Author cev...@google.com
Date 2012-12-13 18:12:05 -0800 (Thu, 13 Dec 2012)
Log Message
Merge 136541
BUG=163994
Review URL: https://codereview.chromium.org/11564028
Modified Paths
branches/chromium/1312/Source/WebCore/svg/SVGUseElement.cpp
branches/chromium/1312/Source/WebCore/svg/SVGUseElement.h
Added Paths
branches/chromium/1312/LayoutTests/svg/custom/use-href-update-crash-expected.txt
branches/chromium/1312/LayoutTests/svg/custom/use-href-update-crash.svg
Diff
Copied: branches/chromium/1312/LayoutTests/svg/custom/use-href-update-crash-expected.txt (from rev 136541, trunk/LayoutTests/svg/custom/use-href-update-crash-expected.txt) (0 => 137694)
--- branches/chromium/1312/LayoutTests/svg/custom/use-href-update-crash-expected.txt (rev 0)
+++ branches/chromium/1312/LayoutTests/svg/custom/use-href-update-crash-expected.txt 2012-12-14 02:12:05 UTC (rev 137694)
@@ -0,0 +1 @@
+PASS: did not crash.
Copied: branches/chromium/1312/LayoutTests/svg/custom/use-href-update-crash.svg (from rev 136541, trunk/LayoutTests/svg/custom/use-href-update-crash.svg) (0 => 137694)
--- branches/chromium/1312/LayoutTests/svg/custom/use-href-update-crash.svg (rev 0)
+++ branches/chromium/1312/LayoutTests/svg/custom/use-href-update-crash.svg 2012-12-14 02:12:05 UTC (rev 137694)
@@ -0,0 +1,17 @@
+
+
+
+ PASS: did not crash.
+
+
+var use = document.getElementById('use');
+use.setAttribute('xlink:href', 'bar.svg#bar');
+use.parentNode.removeChild(use);
+use = null;
+gc();
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+
Modified: branches/chromium/1312/Source/WebCore/svg/SVGUseElement.cpp (137693 => 137694)
--- branches/chromium/1312/Source/WebCore/svg/SVGUseElement.cpp 2012-12-14 02:02:51 UTC (rev 137693)
+++ branches/chromium/1312/Source/WebCore/svg/SVGUseElement.cpp 2012-12-14 02:12:05 UTC (rev 137694)
@@ -107,8 +107,7 @@
SVGUseElement::~SVGUseElement()
{
-if (m_cachedDocument)
-m_cachedDocument->removeClient(this);
+setCachedDocument(0);
clearResourceReferences();
}
@@ -256,18 +255,14 @@
KURL url = ""
if (url.hasFragmentIdentifier()) {
CachedResourceRequest request(ResourceRequest(url.string()));
-m_cachedDocument = document()->cachedResourceLoader()->requestSVGDocument(request);
-if (m_cachedDocument)
-m_cachedDocument->addClient(this);
+setCachedDocument(document()->cachedResourceLoader()->requestSVGDocument(request));
}
-}
+} else
+setCachedDocument(0);
-if (m_cachedDocument && !isExternalReference) {
-m_cachedDocument->removeClient(this);
-m_cachedDocument = 0;
-}
if (!m_wasInsertedByParser)
buildPendingResource();
+
return;
}
@@ -991,6 +986,19 @@
}
}
+void SVGUseElement::setCachedDocument(CachedResourceHandle cachedDocument)
+{
+if (m_cachedDocument == cachedDocument)
+return;
+
+if (m_cachedDocument)
+m_cachedDocument->removeClient(this);
+
+m_cachedDocument = cachedDocument;
+if (m_cachedDocument)
+m_cachedDocument->addClient(this);
}
+}
+
#endif // ENABLE(SVG)
Modified: branches/chromium/1312/Source/WebCore/svg/SVGUseElement.h (137693 => 137694)
--- branches/chromium/1312/Source/WebCore/svg/SVGUseElement.h 2012-12-14 02:02:51 UTC (rev 137693)
+++ branches/chromium/1312/Source/WebCore/svg/SVGUseElement.h 2012-12-14 02:12:05 UTC (rev 137694)
@@ -114,6 +114,7 @@
bool instanceTreeIsLoading(SVGElementInstance*);
virtual void notifyFinished(CachedResource*);
Document* referencedDocument() const;
+void setCachedDocument(CachedResourceHandle);
// SVGTests
virtual void synchronizeRequiredFeatures() { SVGTests::synchronizeRequiredFeatures(this); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137693] trunk/Tools
Title: [137693] trunk/Tools
Revision 137693
Author jpar...@chromium.org
Date 2012-12-13 18:02:51 -0800 (Thu, 13 Dec 2012)
Log Message
Dashboard cleanup: remove usage of global g_builders.
https://bugs.webkit.org/show_bug.cgi?id=104941
Reviewed by Dirk Pranke.
The dashboards use a lot of global state, which makes hacking on them
complicated. This change removes the use of one such global: g_builders.
In most cases, we can just use currentBuilderGroup().builders instead,
which is now currentBuilders().
Surprisingly, the most changes were required to the unit tests, since
they were even bigger offenders of bad hygiene, relying on global state
set by other tests, randomly clobbering global variables in ways the
real code doesn't, etc.
* TestResultServer/static-dashboards/builders.js:
(BuilderGroup.prototype.setup):
* TestResultServer/static-dashboards/dashboard_base.js:
(.switch.return):
(htmlForTestTypeSwitcher):
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(generatePage):
(getAllTestsTrie):
(processTestRunsForAllBuilders):
(showPopupForBuild):
(generatePageForExpectationsUpdate):
(loadExpectationsLayoutTests):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(resetGlobals):
(stubResultsByBuilder):
(test):
* TestResultServer/static-dashboards/loader.js:
(.):
* TestResultServer/static-dashboards/loader_unittests.js:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/aggregate_results.html
trunk/Tools/TestResultServer/static-dashboards/builders.js
trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js
trunk/Tools/TestResultServer/static-dashboards/loader.js
trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js
trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.html
trunk/Tools/TestResultServer/static-dashboards/treemap.html
Diff
Modified: trunk/Tools/ChangeLog (137692 => 137693)
--- trunk/Tools/ChangeLog 2012-12-14 01:58:05 UTC (rev 137692)
+++ trunk/Tools/ChangeLog 2012-12-14 02:02:51 UTC (rev 137693)
@@ -1,3 +1,39 @@
+2012-12-13 Julie Parent
+
+Dashboard cleanup: remove usage of global g_builders.
+https://bugs.webkit.org/show_bug.cgi?id=104941
+
+Reviewed by Dirk Pranke.
+
+The dashboards use a lot of global state, which makes hacking on them
+complicated. This change removes the use of one such global: g_builders.
+In most cases, we can just use currentBuilderGroup().builders instead,
+which is now currentBuilders().
+Surprisingly, the most changes were required to the unit tests, since
+they were even bigger offenders of bad hygiene, relying on global state
+set by other tests, randomly clobbering global variables in ways the
+real code doesn't, etc.
+
+* TestResultServer/static-dashboards/builders.js:
+(BuilderGroup.prototype.setup):
+* TestResultServer/static-dashboards/dashboard_base.js:
+(.switch.return):
+(htmlForTestTypeSwitcher):
+* TestResultServer/static-dashboards/flakiness_dashboard.js:
+(generatePage):
+(getAllTestsTrie):
+(processTestRunsForAllBuilders):
+(showPopupForBuild):
+(generatePageForExpectationsUpdate):
+(loadExpectationsLayoutTests):
+* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+(resetGlobals):
+(stubResultsByBuilder):
+(test):
+* TestResultServer/static-dashboards/loader.js:
+(.):
+* TestResultServer/static-dashboards/loader_unittests.js:
+
2012-12-13 Eric Seidel
Callers should not have to stringify args before calling Executive run_command/popen
Modified: trunk/Tools/TestResultServer/static-dashboards/aggregate_results.html (137692 => 137693)
--- trunk/Tools/TestResultServer/static-dashboards/aggregate_results.html 2012-12-14 01:58:05 UTC (rev 137692)
+++ trunk/Tools/TestResultServer/static-dashboards/aggregate_results.html 2012-12-14 02:02:51 UTC (rev 137693)
@@ -68,7 +68,7 @@
function generatePage()
{
var html = htmlForTestTypeSwitcher(true) + '';
-for (var builder in g_builders)
+for (var builder in currentBuilders())
html += htmlForBuilder(builder);
document.body.innerHTML = html;
}
Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (137692 => 137693)
--- trunk/Tools/TestResultServer/static-dashboards/builders.js 2012-12-14 01:58:05 UTC (rev 137692)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js 2012-12-14 02:02:51 UTC (rev 137693)
@@ -127,7 +127,6 @@
// FIXME: instead of copying these to globals, it would be better if
// the rest of the code read things from the BuilderGroup instance directly
g_defaultBuilderName = this._defaultBuilder();
[webkit-changes] [137692] trunk/Tools
Title: [137692] trunk/Tools
Revision 137692
Author e...@webkit.org
Date 2012-12-13 17:58:05 -0800 (Thu, 13 Dec 2012)
Log Message
Callers should not have to stringify args before calling Executive run_command/popen
https://bugs.webkit.org/show_bug.cgi?id=104975
Reviewed by Dirk Pranke.
One could argue that we should match the python call syntax here,
but I think it's a more friendly API if we automagically handle
stringification of args in run_command, etc.
This removes map(unicode, args) from several callsites.
When I first tried to land this change, I didn't realize that
Executive._command_for_printing depended on this behavior
having been applied to args in run_command. The fix is to
call _stringify_args in both run_command and popen.
This is slightly redundant, but given how short args have to be
(due to shell limits), I don't think the double-encode check
matters in practice.
This is slightly complicated by the fact that apache_http_server.py
is the one caller in our codebase which uses shell=True.
shell=True is a well-documented trail-of-tears:
http://stackoverflow.com/questions/3172470/actual-meaning-of-shell-true-in-subprocess
but to support this legacy (windows-only) code (which I can't easily test)
I've added an if-hack to avoid stringifying the the popen(shell=True) case.
* Scripts/webkitpy/common/system/executive.py:
(Executive.run_command):
(Executive._stringify_args):
(Executive.popen):
* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_auto_stringify_args):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(attach_to_pid):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/executive.py
trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
Diff
Modified: trunk/Tools/ChangeLog (137691 => 137692)
--- trunk/Tools/ChangeLog 2012-12-14 01:45:53 UTC (rev 137691)
+++ trunk/Tools/ChangeLog 2012-12-14 01:58:05 UTC (rev 137692)
@@ -1,3 +1,39 @@
+2012-12-13 Eric Seidel
+
+Callers should not have to stringify args before calling Executive run_command/popen
+https://bugs.webkit.org/show_bug.cgi?id=104975
+
+Reviewed by Dirk Pranke.
+
+One could argue that we should match the python call syntax here,
+but I think it's a more friendly API if we automagically handle
+stringification of args in run_command, etc.
+This removes map(unicode, args) from several callsites.
+
+When I first tried to land this change, I didn't realize that
+Executive._command_for_printing depended on this behavior
+having been applied to args in run_command. The fix is to
+call _stringify_args in both run_command and popen.
+This is slightly redundant, but given how short args have to be
+(due to shell limits), I don't think the double-encode check
+matters in practice.
+
+This is slightly complicated by the fact that apache_http_server.py
+is the one caller in our codebase which uses shell=True.
+shell=True is a well-documented trail-of-tears:
+http://stackoverflow.com/questions/3172470/actual-meaning-of-shell-true-in-subprocess
+but to support this legacy (windows-only) code (which I can't easily test)
+I've added an if-hack to avoid stringifying the the popen(shell=True) case.
+
+* Scripts/webkitpy/common/system/executive.py:
+(Executive.run_command):
+(Executive._stringify_args):
+(Executive.popen):
+* Scripts/webkitpy/common/system/executive_unittest.py:
+(ExecutiveTest.test_auto_stringify_args):
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(attach_to_pid):
+
2012-12-13 Adrienne Walker
Unreviewed, rolling out r137645, r137646, and r137667.
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (137691 => 137692)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2012-12-14 01:45:53 UTC (rev 137691)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2012-12-14 01:58:05 UTC (rev 137692)
@@ -101,9 +101,6 @@
return sys.platform not in ('win32', 'cygwin')
def _run_command_with_teed_output(self, args, teed_output, **kwargs):
-args = map(unicode, args) # Popen will throw an exception if args are non-strings (like int())
-args = map(self._encode_argument_if_needed, args)
-
child_process = self.popen(args,
stdout=self.PIPE,
stderr=self.STDOUT,
@@ -390,8 +387,7 @@
"""Popen wrapper for convenience and to work around python bugs."""
assert(isinstance(args, list) or isinstance(args, tuple))
start_time = time.time()
-args = map(unicode, args) # Popen will throw an exception if args are non-strings (like int())
-args = map(self._encode_argument
[webkit-changes] [137690] trunk/Source/WebCore
Title: [137690] trunk/Source/WebCore
Revision 137690
Author bda...@apple.com
Date 2012-12-13 17:44:16 -0800 (Thu, 13 Dec 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=102599
ASSERT loading Acid3 test in run-safari --debug (r135050)
Reviewed by Simon Fraser.
New flag IncludeCompositedDescendants will always calculate the layer bounds for
descendants, even when the are composited.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds):
* rendering/RenderLayer.h:
calculateCompositedBounds() should not include this new flag, so instead of
calling that, call calculateLayerBounds() directly with the
IncludeCompositedDescendants flag. This will get us the information we need
upfront and avoid the toggling later on.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (137689 => 137690)
--- trunk/Source/WebCore/ChangeLog 2012-12-14 01:29:03 UTC (rev 137689)
+++ trunk/Source/WebCore/ChangeLog 2012-12-14 01:44:16 UTC (rev 137690)
@@ -1,3 +1,23 @@
+2012-12-13 Beth Dakin
+
+https://bugs.webkit.org/show_bug.cgi?id=102599
+ASSERT loading Acid3 test in run-safari --debug (r135050)
+
+Reviewed by Simon Fraser.
+
+New flag IncludeCompositedDescendants will always calculate the layer bounds for
+descendants, even when the are composited.
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::calculateLayerBounds):
+* rendering/RenderLayer.h:
+
+calculateCompositedBounds() should not include this new flag, so instead of
+calling that, call calculateLayerBounds() directly with the
+IncludeCompositedDescendants flag. This will get us the information we need
+upfront and avoid the toggling later on.
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
+
2012-12-13 Tien-Ren Chen
Don't consider container nodes of other disambiguated nodes
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (137689 => 137690)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-12-14 01:29:03 UTC (rev 137689)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-12-14 01:44:16 UTC (rev 137690)
@@ -4599,7 +4599,7 @@
}
// FIXME: should probably just pass 'flags' down to descendants.
-CalculateLayerBoundsFlags descendantFlags = DefaultCalculateLayerBoundsFlags | (flags & ExcludeHiddenDescendants);
+CalculateLayerBoundsFlags descendantFlags = DefaultCalculateLayerBoundsFlags | (flags & ExcludeHiddenDescendants) | (flags & IncludeCompositedDescendants);
const_cast(this)->updateLayerListsIfNeeded();
@@ -4620,7 +4620,7 @@
size_t listSize = negZOrderList->size();
for (size_t i = 0; i < listSize; ++i) {
RenderLayer* curLayer = negZOrderList->at(i);
-if (!curLayer->isComposited()) {
+if (flags & IncludeCompositedDescendants || !curLayer->isComposited()) {
IntRect childUnionBounds = curLayer->calculateLayerBounds(this, 0, descendantFlags);
unionBounds.unite(childUnionBounds);
}
@@ -4631,7 +4631,7 @@
size_t listSize = posZOrderList->size();
for (size_t i = 0; i < listSize; ++i) {
RenderLayer* curLayer = posZOrderList->at(i);
-if (!curLayer->isComposited()) {
+if (flags & IncludeCompositedDescendants || !curLayer->isComposited()) {
IntRect childUnionBounds = curLayer->calculateLayerBounds(this, 0, descendantFlags);
unionBounds.unite(childUnionBounds);
}
@@ -4642,7 +4642,7 @@
size_t listSize = normalFlowList->size();
for (size_t i = 0; i < listSize; ++i) {
RenderLayer* curLayer = normalFlowList->at(i);
-if (!curLayer->isComposited()) {
+if (flags & IncludeCompositedDescendants || !curLayer->isComposited()) {
IntRect curAbsBounds = curLayer->calculateLayerBounds(this, 0, descendantFlags);
unionBounds.unite(curAbsBounds);
}
Modified: trunk/Source/WebCore/rendering/RenderLayer.h (137689 => 137690)
--- trunk/Source/WebCore/rendering/RenderLayer.h 2012-12-14 01:29:03 UTC (rev 137689)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2012-12-14 01:44:16 UTC (rev 137690)
@@ -579,6 +579,7 @@
IncludeLayerFilterOutsets = 1 << 2,
ExcludeHiddenDescendants = 1 << 3,
DontConstrainForMask = 1 << 4,
+IncludeCompositedDescendants = 1 << 5,
DefaultCalculateLayerBoundsFlags = IncludeSelfTransform | UseLocalClipRectIfPossible | IncludeLayerFilterOutsets
};
[webkit-changes] [137689] trunk/Source/WebKit2
Title: [137689] trunk/Source/WebKit2 Revision 137689 Author a...@apple.com Date 2012-12-13 17:29:03 -0800 (Thu, 13 Dec 2012) Log Message Resource loads sometimes stall https://bugs.webkit.org/show_bug.cgi?id=104976 Reviewed by Anders Carlsson. Quick and dirty partial fix. * Shared/BlockingResponseMap.h: (BlockingResponseMap::didReceiveResponse): Wake up all threads, so that non-sequential responses don't break us. This is still horribly inefficient,but should improve behavior quite a bit. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/BlockingResponseMap.h Diff Modified: trunk/Source/WebKit2/ChangeLog (137688 => 137689) --- trunk/Source/WebKit2/ChangeLog 2012-12-14 01:15:08 UTC (rev 137688) +++ trunk/Source/WebKit2/ChangeLog 2012-12-14 01:29:03 UTC (rev 137689) @@ -1,3 +1,16 @@ +2012-12-13 Alexey Proskuryakov + +Resource loads sometimes stall +https://bugs.webkit.org/show_bug.cgi?id=104976 + +Reviewed by Anders Carlsson. + +Quick and dirty partial fix. + +* Shared/BlockingResponseMap.h: (BlockingResponseMap::didReceiveResponse): +Wake up all threads, so that non-sequential responses don't break us. This is still +horribly inefficient,but should improve behavior quite a bit. + 2012-12-13 Seokju Kwon Fix unused parameter compile warnings Modified: trunk/Source/WebKit2/Shared/BlockingResponseMap.h (137688 => 137689) --- trunk/Source/WebKit2/Shared/BlockingResponseMap.h 2012-12-14 01:15:08 UTC (rev 137688) +++ trunk/Source/WebKit2/Shared/BlockingResponseMap.h 2012-12-14 01:29:03 UTC (rev 137689) @@ -54,7 +54,8 @@ ASSERT(!m_responses.contains(requestID)); m_responses.set(requestID, response); -m_condition.signal(); +// FIXME (NetworkProcess): Waking up all threads is quite inefficient. +m_condition.broadcast(); } private: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137688] trunk/Source
Title: [137688] trunk/Source Revision 137688 Author commit-qu...@webkit.org Date 2012-12-13 17:15:08 -0800 (Thu, 13 Dec 2012) Log Message Fix unused parameter compile warnings https://bugs.webkit.org/show_bug.cgi?id=104907 Patch by Seokju Kwon on 2012-12-13 Reviewed by Kentaro Hara. Use UNUSED_PARAM macro to fix build warning -Wunused-parameter when ENABLE_INSPECTOR is disabled. Source/WebKit/efl: * WebCoreSupport/DumpRenderTreeSupportEfl.cpp: (DumpRenderTreeSupportEfl::evaluateInWebInspector): Source/WebKit2: * UIProcess/API/C/WKInspector.cpp: (WKInspectorGetPage): (WKInspectorIsVisible): (WKInspectorIsFront): (WKInspectorShow): (WKInspectorClose): (WKInspectorShowConsole): (WKInspectorShowResources): (WKInspectorShowMainResourceForFrame): (WKInspectorIsAttached): (WKInspectorAttach): (WKInspectorDetach): (WKInspectorIsDebuggingJavaScript): (WKInspectorToggleJavaScriptDebugging): (WKInspectorIsProfilingJavaScript): (WKInspectorToggleJavaScriptProfiling): (WKInspectorIsProfilingPage): (WKInspectorTogglePageProfiling): * UIProcess/API/C/WKPage.cpp: (WKPageGetInspector): Modified Paths trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/C/WKInspector.cpp trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp Diff Modified: trunk/Source/WebKit/efl/ChangeLog (137687 => 137688) --- trunk/Source/WebKit/efl/ChangeLog 2012-12-14 01:10:28 UTC (rev 137687) +++ trunk/Source/WebKit/efl/ChangeLog 2012-12-14 01:15:08 UTC (rev 137688) @@ -1,3 +1,16 @@ +2012-12-13 Seokju Kwon + +Fix unused parameter compile warnings +https://bugs.webkit.org/show_bug.cgi?id=104907 + +Reviewed by Kentaro Hara. + +Use UNUSED_PARAM macro to fix build warning -Wunused-parameter +when ENABLE_INSPECTOR is disabled. + +* WebCoreSupport/DumpRenderTreeSupportEfl.cpp: +(DumpRenderTreeSupportEfl::evaluateInWebInspector): + 2012-12-13 Jussi Kukkonen [EFL][GTK] Don't call deprecated g_type_init when glib => 2.35 Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (137687 => 137688) --- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-12-14 01:10:28 UTC (rev 137687) +++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-12-14 01:15:08 UTC (rev 137688) @@ -62,6 +62,7 @@ #include #include #include +#include #if ENABLE(GEOLOCATION) #include @@ -525,6 +526,10 @@ if (page->inspectorController()) page->inspectorController()->evaluateForTestInFrontend(callId, script); +#else +UNUSED_PARAM(ewkView); +UNUSED_PARAM(callId); +UNUSED_PARAM(script); #endif } Modified: trunk/Source/WebKit2/ChangeLog (137687 => 137688) --- trunk/Source/WebKit2/ChangeLog 2012-12-14 01:10:28 UTC (rev 137687) +++ trunk/Source/WebKit2/ChangeLog 2012-12-14 01:15:08 UTC (rev 137688) @@ -1,5 +1,36 @@ 2012-12-13 Seokju Kwon +Fix unused parameter compile warnings +https://bugs.webkit.org/show_bug.cgi?id=104907 + +Reviewed by Kentaro Hara. + +Use UNUSED_PARAM macro to fix build warning -Wunused-parameter +when ENABLE_INSPECTOR is disabled. + +* UIProcess/API/C/WKInspector.cpp: +(WKInspectorGetPage): +(WKInspectorIsVisible): +(WKInspectorIsFront): +(WKInspectorShow): +(WKInspectorClose): +(WKInspectorShowConsole): +(WKInspectorShowResources): +(WKInspectorShowMainResourceForFrame): +(WKInspectorIsAttached): +(WKInspectorAttach): +(WKInspectorDetach): +(WKInspectorIsDebuggingJavaScript): +(WKInspectorToggleJavaScriptDebugging): +(WKInspectorIsProfilingJavaScript): +(WKInspectorToggleJavaScriptProfiling): +(WKInspectorIsProfilingPage): +(WKInspectorTogglePageProfiling): +* UIProcess/API/C/WKPage.cpp: +(WKPageGetInspector): + +2012-12-13 Seokju Kwon + [QT][GTK][EFL] Add guard for WebInspectorServer https://bugs.webkit.org/show_bug.cgi?id=104889 Modified: trunk/Source/WebKit2/UIProcess/API/C/WKInspector.cpp (137687 => 137688) --- trunk/Source/WebKit2/UIProcess/API/C/WKInspector.cpp 2012-12-14 01:10:28 UTC (rev 137687) +++ trunk/Source/WebKit2/UIProcess/API/C/WKInspector.cpp 2012-12-14 01:15:08 UTC (rev 137688) @@ -28,6 +28,7 @@ #include "WKAPICast.h" #include "WebInspectorProxy.h" +#include using namespace WebKit; @@ -45,6 +46,7 @@ #if ENABLE(INSPECTOR) return toAPI(toImpl(inspectorRef)->page()); #else +UNUSED_PARAM(inspectorRef); return 0; #endif } @@ -54,6 +56,7 @@ #if ENABLE(INSPECTOR) return toImpl(inspectorRef)->isVisible(); #else +UNUSED_PARAM(inspectorRef); return false; #endif } @@ -63,6 +66,7 @@ #if ENABLE(INSPECTOR) return toImpl(inspectorRef)->isFront(); #else +UNUSED_PARAM(inspect
[webkit-changes] [137687] trunk/Source/WebKit2
Title: [137687] trunk/Source/WebKit2 Revision 137687 Author commit-qu...@webkit.org Date 2012-12-13 17:10:28 -0800 (Thu, 13 Dec 2012) Log Message [QT][GTK][EFL] Add guard for WebInspectorServer https://bugs.webkit.org/show_bug.cgi?id=104889 Patch by Seokju Kwon on 2012-12-13 Reviewed by Kenneth Rohde Christiansen. Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer. * UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp: * UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp: * UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp trunk/Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp trunk/Source/WebKit2/UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (137686 => 137687) --- trunk/Source/WebKit2/ChangeLog 2012-12-14 01:09:58 UTC (rev 137686) +++ trunk/Source/WebKit2/ChangeLog 2012-12-14 01:10:28 UTC (rev 137687) @@ -1,3 +1,16 @@ +2012-12-13 Seokju Kwon + +[QT][GTK][EFL] Add guard for WebInspectorServer +https://bugs.webkit.org/show_bug.cgi?id=104889 + +Reviewed by Kenneth Rohde Christiansen. + +Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer. + +* UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp: +* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp: +* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: + 2012-12-13 Huang Dongsung Coordinated Graphics: Reorder messages to CoordinatedLayerTreeHostProxy Modified: trunk/Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp (137686 => 137687) --- trunk/Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp 2012-12-14 01:09:58 UTC (rev 137686) +++ trunk/Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp 2012-12-14 01:10:28 UTC (rev 137687) @@ -23,6 +23,8 @@ */ #include "config.h" + +#if ENABLE(INSPECTOR_SERVER) #include "WebInspectorServer.h" #include "WebInspectorProxy.h" @@ -103,3 +105,4 @@ } } +#endif Modified: trunk/Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp (137686 => 137687) --- trunk/Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp 2012-12-14 01:09:58 UTC (rev 137686) +++ trunk/Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp 2012-12-14 01:10:28 UTC (rev 137687) @@ -23,6 +23,8 @@ */ #include "config.h" + +#if ENABLE(INSPECTOR_SERVER) #include "WebInspectorServer.h" #include "WebInspectorProxy.h" @@ -94,3 +96,4 @@ } } +#endif Modified: trunk/Source/WebKit2/UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp (137686 => 137687) --- trunk/Source/WebKit2/UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp 2012-12-14 01:09:58 UTC (rev 137686) +++ trunk/Source/WebKit2/UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp 2012-12-14 01:10:28 UTC (rev 137687) @@ -21,6 +21,7 @@ #include "config.h" +#if ENABLE(INSPECTOR_SERVER) #include "WebInspectorServer.h" #include "WebInspectorProxy.h" @@ -104,3 +105,4 @@ } } +#endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137686] trunk/Source
Title: [137686] trunk/Source
Revision 137686
Author commit-qu...@webkit.org
Date 2012-12-13 17:09:58 -0800 (Thu, 13 Dec 2012)
Log Message
Don't consider container nodes of other disambiguated nodes
https://bugs.webkit.org/show_bug.cgi?id=104619
Patch by Tien-Ren Chen on 2012-12-13
Reviewed by Eric Seidel.
Source/WebCore:
It is not uncommon to have a clickable that contains other clickable objects.
This heuristic avoids excessive disambiguation in that case.
New unit test: WebFrameTest.DisambiguationPopupNoContainer
* page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):
Source/WebKit/chromium:
Added a test to track the new disambiguation popup heuristics.
* tests/WebFrameTest.cpp:
* tests/data/disambiguation_popup_no_container.html: Added.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/TouchDisambiguation.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp
Added Paths
trunk/Source/WebKit/chromium/tests/data/disambiguation_popup_no_container.html
Diff
Modified: trunk/Source/WebCore/ChangeLog (137685 => 137686)
--- trunk/Source/WebCore/ChangeLog 2012-12-14 00:42:34 UTC (rev 137685)
+++ trunk/Source/WebCore/ChangeLog 2012-12-14 01:09:58 UTC (rev 137686)
@@ -1,3 +1,18 @@
+2012-12-13 Tien-Ren Chen
+
+Don't consider container nodes of other disambiguated nodes
+https://bugs.webkit.org/show_bug.cgi?id=104619
+
+Reviewed by Eric Seidel.
+
+It is not uncommon to have a clickable that contains other clickable objects.
+This heuristic avoids excessive disambiguation in that case.
+
+New unit test: WebFrameTest.DisambiguationPopupNoContainer
+
+* page/TouchDisambiguation.cpp:
+(WebCore::findGoodTouchTargets):
+
2012-12-13 Adrienne Walker
Unreviewed, rolling out r137645, r137646, and r137667.
Modified: trunk/Source/WebCore/page/TouchDisambiguation.cpp (137685 => 137686)
--- trunk/Source/WebCore/page/TouchDisambiguation.cpp 2012-12-14 00:42:34 UTC (rev 137685)
+++ trunk/Source/WebCore/page/TouchDisambiguation.cpp 2012-12-14 01:09:58 UTC (rev 137686)
@@ -39,6 +39,7 @@
#include "HTMLNames.h"
#include "HitTestResult.h"
#include "NodeTraversal.h"
+#include "RenderBlock.h"
#include
#include
@@ -100,10 +101,29 @@
HitTestResult result = mainFrame->eventHandler()->hitTestResultAtPoint(contentsPoint, false, false, DontHitTestScrollbars, HitTestRequest::Active | HitTestRequest::ReadOnly, IntSize(padding, padding));
const ListHashSet >& hitResults = result.rectBasedTestResult();
+// Blacklist nodes that are container of disambiguated nodes.
+// It is not uncommon to have a clickable that contains other clickable objects.
+// This heuristic avoids excessive disambiguation in that case.
+HashSet blackList;
+for (ListHashSet >::const_iterator it = hitResults.begin(); it != hitResults.end(); ++it) {
+RenderObject* renderer = it->get()->renderer();
+if (!renderer)
+continue;
+for (RenderBlock* container = renderer->containingBlock(); container; container = container->containingBlock()) {
+Node* containerNode = container->node();
+if (!containerNode)
+continue;
+if (!blackList.add(containerNode).isNewEntry)
+break;
+}
+}
+
HashMap touchTargets;
float bestScore = 0;
for (ListHashSet >::const_iterator it = hitResults.begin(); it != hitResults.end(); ++it) {
for (Node* node = it->get(); node; node = node->parentNode()) {
+if (blackList.contains(it->get()))
+continue;
if (node->isDocumentNode() || node->hasTagName(HTMLNames::htmlTag) || node->hasTagName(HTMLNames::bodyTag))
break;
if (node->willRespondToMouseClickEvents()) {
Modified: trunk/Source/WebKit/chromium/ChangeLog (137685 => 137686)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-14 00:42:34 UTC (rev 137685)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-14 01:09:58 UTC (rev 137686)
@@ -1,3 +1,15 @@
+2012-12-13 Tien-Ren Chen
+
+Don't consider container nodes of other disambiguated nodes
+https://bugs.webkit.org/show_bug.cgi?id=104619
+
+Reviewed by Eric Seidel.
+
+Added a test to track the new disambiguation popup heuristics.
+
+* tests/WebFrameTest.cpp:
+* tests/data/disambiguation_popup_no_container.html: Added.
+
2012-12-13 James Robinson
[chromium] Expose a WebLayerTreeView getter on WebWidget to make it easier for the embedder to interface with the compositor
Modified: trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp (137685 => 137686)
--- trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-12-14 00:42:34 UTC (rev 137685)
+++ trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-12-14 01:09:58 UTC (rev 137686)
@@ -1542,7 +1542,7 @@
return event;
[webkit-changes] [137685] trunk/Source/WebKit2
Title: [137685] trunk/Source/WebKit2
Revision 137685
Author commit-qu...@webkit.org
Date 2012-12-13 16:42:34 -0800 (Thu, 13 Dec 2012)
Log Message
Coordinated Graphics: Reorder messages to CoordinatedLayerTreeHostProxy
https://bugs.webkit.org/show_bug.cgi?id=103843
Patch by Huang Dongsung on 2012-12-13
Reviewed by Noam Rosenthal.
Clarify LayerTreeRenderer::setRootLayerID() can be called only once during its
lifecycle. LayerTreeRenderer, CoordinatedLayerTreeHost and CoordinatedLayerTreeHostProxy
have the same lifecycle to WebPage and the root layer is reused even if loading
new page, so it is impossible to call LayerTreeRenderer::setRootLayerID() more
than twice.
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setRootLayerID):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137684 => 137685)
--- trunk/Source/WebKit2/ChangeLog 2012-12-14 00:42:31 UTC (rev 137684)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-14 00:42:34 UTC (rev 137685)
@@ -1,3 +1,19 @@
+2012-12-13 Huang Dongsung
+
+Coordinated Graphics: Reorder messages to CoordinatedLayerTreeHostProxy
+https://bugs.webkit.org/show_bug.cgi?id=103843
+
+Reviewed by Noam Rosenthal.
+
+Clarify LayerTreeRenderer::setRootLayerID() can be called only once during its
+lifecycle. LayerTreeRenderer, CoordinatedLayerTreeHost and CoordinatedLayerTreeHostProxy
+have the same lifecycle to WebPage and the root layer is reused even if loading
+new page, so it is impossible to call LayerTreeRenderer::setRootLayerID() more
+than twice.
+
+* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
+(WebKit::LayerTreeRenderer::setRootLayerID):
+
2012-12-13 Alexey Proskuryakov
DOM cookie access functions should respect private browsing
Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp (137684 => 137685)
--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp 2012-12-14 00:42:31 UTC (rev 137684)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp 2012-12-14 00:42:34 UTC (rev 137685)
@@ -392,16 +392,12 @@
void LayerTreeRenderer::setRootLayerID(CoordinatedLayerID layerID)
{
-if (layerID == m_rootLayerID)
-return;
+ASSERT(layerID != InvalidCoordinatedLayerID);
+ASSERT(m_rootLayerID == InvalidCoordinatedLayerID);
m_rootLayerID = layerID;
-
m_rootLayer->removeAllChildren();
-if (!layerID)
-return;
-
GraphicsLayer* layer = ensureLayer(layerID);
m_rootLayer->addChild(layer);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137684] trunk/LayoutTests
Title: [137684] trunk/LayoutTests
Revision 137684
Author commit-qu...@webkit.org
Date 2012-12-13 16:42:31 -0800 (Thu, 13 Dec 2012)
Log Message
Layout Test fast/events/mouse-cursor-image-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=104945
Patch by Rick Byers on 2012-12-13
Reviewed by Beth Dakin.
Fix typo that prevented one of the images from being reliably pre-loaded.
A deeper fix to avoid these class of issues is tracked by
https://bugs.webkit.org/show_bug.cgi?id=104952
* fast/events/mouse-cursor-image-set.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/mouse-cursor-image-set.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137683 => 137684)
--- trunk/LayoutTests/ChangeLog 2012-12-14 00:32:55 UTC (rev 137683)
+++ trunk/LayoutTests/ChangeLog 2012-12-14 00:42:31 UTC (rev 137684)
@@ -1,3 +1,16 @@
+2012-12-13 Rick Byers
+
+Layout Test fast/events/mouse-cursor-image-set.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=104945
+
+Reviewed by Beth Dakin.
+
+Fix typo that prevented one of the images from being reliably pre-loaded.
+A deeper fix to avoid these class of issues is tracked by
+https://bugs.webkit.org/show_bug.cgi?id=104952
+
+* fast/events/mouse-cursor-image-set.html:
+
2012-12-13 Adrienne Walker
Unreviewed, rolling out r137645, r137646, and r137667.
Modified: trunk/LayoutTests/fast/events/mouse-cursor-image-set.html (137683 => 137684)
--- trunk/LayoutTests/fast/events/mouse-cursor-image-set.html 2012-12-14 00:32:55 UTC (rev 137683)
+++ trunk/LayoutTests/fast/events/mouse-cursor-image-set.html 2012-12-14 00:42:31 UTC (rev 137684)
@@ -113,7 +113,7 @@
{ url: 'resources/greenbox.png' },
{ url: 'resources/greenbox30.png' },
{ url: 'resources/greenbox200.png' },
- { url: 'resources/greenbox-hotspot35-4.cur' },
+ { url: 'resources/greenbox-hotspot5-4.cur' },
{ url: 'resources/greenbox30-hotspot28-3.cur' },
{ url: 'doesntexist.png', error: true } ];
ensureImagesLoaded(imagesToLoad, runTests);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137683] trunk/Source/JavaScriptCore
Title: [137683] trunk/Source/_javascript_Core
Revision 137683
Author oli...@apple.com
Date 2012-12-13 16:32:55 -0800 (Thu, 13 Dec 2012)
Log Message
Support op_typeof in the DFG
https://bugs.webkit.org/show_bug.cgi?id=98898
Reviewed by Filip Pizlo.
Adds a TypeOf node to the DFG to support op_typeof.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
We try to determine the result early here, and substitute in a constant.
Otherwise we leave the node intact, and set the result type to SpecString.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
Parse op_typeof
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
TypeOf nodes can be subjected to pure CSE
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
We can handle typeof.
* dfg/DFGNodeType.h:
(DFG):
Define the node.
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
Add operationTypeOf to support the non-trivial cases.
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Actual codegen
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC):
* runtime/Operations.h:
(JSC):
Some refactoring to allow us to get the type string for an
object without needing a callframe.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGCapabilities.h
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/runtime/Operations.cpp
trunk/Source/_javascript_Core/runtime/Operations.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (137682 => 137683)
--- trunk/Source/_javascript_Core/ChangeLog 2012-12-14 00:30:25 UTC (rev 137682)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-12-14 00:32:55 UTC (rev 137683)
@@ -1,3 +1,46 @@
+2012-13-11 Oliver Hunt
+
+Support op_typeof in the DFG
+https://bugs.webkit.org/show_bug.cgi?id=98898
+
+Reviewed by Filip Pizlo.
+
+Adds a TypeOf node to the DFG to support op_typeof.
+
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::execute):
+ We try to determine the result early here, and substitute in a constant.
+ Otherwise we leave the node intact, and set the result type to SpecString.
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+ Parse op_typeof
+* dfg/DFGCSEPhase.cpp:
+(JSC::DFG::CSEPhase::performNodeCSE):
+ TypeOf nodes can be subjected to pure CSE
+* dfg/DFGCapabilities.h:
+(JSC::DFG::canCompileOpcode):
+ We can handle typeof.
+* dfg/DFGNodeType.h:
+(DFG):
+ Define the node.
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+ Add operationTypeOf to support the non-trivial cases.
+* dfg/DFGPredictionPropagationPhase.cpp:
+(JSC::DFG::PredictionPropagationPhase::propagate):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+ Actual codegen
+* runtime/Operations.cpp:
+(JSC::jsTypeStringForValue):
+(JSC):
+* runtime/Operations.h:
+(JSC):
+ Some refactoring to allow us to get the type string for an
+ object without needing a callframe.
+
2012-12-12 Filip Pizlo
OSR exit compiler should emit code for resetting the execution counter that matches the logic of ExecutionCounter.cpp
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (137682 => 137683)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-12-14 00:30:25 UTC (rev 137682)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-12-14 00:32:55 UTC (rev 137683)
@@ -31,6 +31,7 @@
#include "CodeBlock.h"
#include "DFGBasicBlock.h"
#include "GetByIdStatus.h"
+#include "Operations.h"
#include "PutByIdStatus.h"
namespace JSC { namespace DFG {
@@ -707,6 +708,11 @@
case IsString:
constantWasSet = trySetConstant(nodeIndex, jsBoolean(isJSString(child)));
break;
+case IsObject:
+if (child.isNull() || !child.isObject()) {
+constantWasSet = trySetConstant(nodeIndex, jsBoolean(child.isNull()));
+break;
+}
default:
[webkit-changes] [137681] trunk/Source/WebKit/chromium
Title: [137681] trunk/Source/WebKit/chromium
Revision 137681
Author commit-qu...@webkit.org
Date 2012-12-13 16:22:36 -0800 (Thu, 13 Dec 2012)
Log Message
[chromium] Expose a WebLayerTreeView getter on WebWidget to make it easier for the embedder to interface with the compositor
https://bugs.webkit.org/show_bug.cgi?id=104968
Patch by James Robinson on 2012-12-13
Reviewed by Adrienne Walker.
This is an intermediate step on the way to https://code.google.com/p/chromium/issues/detail?id=156175.
* public/WebWidget.h:
(WebKit):
(WebWidget):
(WebKit::WebWidget::layerTreeView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::webLayerTreeView):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (137680 => 137681)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-14 00:20:23 UTC (rev 137680)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-14 00:22:36 UTC (rev 137681)
@@ -1,3 +1,22 @@
+2012-12-13 James Robinson
+
+[chromium] Expose a WebLayerTreeView getter on WebWidget to make it easier for the embedder to interface with the compositor
+https://bugs.webkit.org/show_bug.cgi?id=104968
+
+Reviewed by Adrienne Walker.
+
+This is an intermediate step on the way to https://code.google.com/p/chromium/issues/detail?id=156175.
+
+* public/WebWidget.h:
+(WebKit):
+(WebWidget):
+(WebKit::WebWidget::layerTreeView):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::webLayerTreeView):
+(WebKit):
+* src/WebViewImpl.h:
+(WebViewImpl):
+
2012-12-13 Antoine Labour
[chromium] Small fixes for WebPluginContainer::setWebLayer
Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (137680 => 137681)
--- trunk/Source/WebKit/chromium/public/WebWidget.h 2012-12-14 00:20:23 UTC (rev 137680)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h 2012-12-14 00:22:36 UTC (rev 137681)
@@ -46,6 +46,7 @@
namespace WebKit {
class WebInputEvent;
+class WebLayerTreeView;
class WebMouseEvent;
class WebString;
struct WebPoint;
@@ -134,6 +135,10 @@
// ready to use.
virtual void setCompositorSurfaceReady() = 0;
+// Returns this widget's WebLayerTreeView if compositing is active, nil
+// otherwise.
+virtual WebLayerTreeView* layerTreeView() { return 0; }
+
// Temporary method for the embedder to notify the WebWidget that the widget
// has taken damage, e.g. due to a window expose. This method will be
// removed when the WebWidget inversion patch lands --- http://crbug.com/112837
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (137680 => 137681)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-12-14 00:20:23 UTC (rev 137680)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-12-14 00:22:36 UTC (rev 137681)
@@ -1724,6 +1724,11 @@
m_layerTreeView->setSurfaceReady();
}
+WebLayerTreeView* WebViewImpl::webLayerTreeView()
+{
+return m_layerTreeView.get();
+}
+
void WebViewImpl::animate(double)
{
#if ENABLE(REQUEST_ANIMATION_FRAME)
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (137680 => 137681)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2012-12-14 00:20:23 UTC (rev 137680)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2012-12-14 00:22:36 UTC (rev 137681)
@@ -142,6 +142,7 @@
virtual void willExitFullScreen();
virtual void didExitFullScreen();
virtual void setCompositorSurfaceReady();
+virtual WebLayerTreeView* webLayerTreeView();
virtual void animate(double);
virtual void layout(); // Also implements WebLayerTreeViewClient::layout()
virtual void enterForceCompositingMode(bool enable) OVERRIDE;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137680] trunk/Source/WebCore
Title: [137680] trunk/Source/WebCore
Revision 137680
Author akl...@apple.com
Date 2012-12-13 16:20:23 -0800 (Thu, 13 Dec 2012)
Log Message
Event dispatch: Avoid heap allocations in ensureEventAncestors() typical case.
Reviewed by Anders Carlsson.
Give the EventTarget and EventContext vectors an inline capacity of 32 (no science here, just a
non-zero number.) As these vectors are created on the stack already, this is merely using a bit
more stack space to avoid malloc()ing all the gosh-darn time.
Looks like ~6% improvement on Dromaeo/jslib-event-prototype.
* dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):
(WebCore::EventDispatcher::ensureEventAncestors):
* dom/EventDispatcher.h:
(EventRelatedTargetAdjuster):
(EventDispatcher):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/EventDispatcher.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (137679 => 137680)
--- trunk/Source/WebCore/ChangeLog 2012-12-14 00:20:07 UTC (rev 137679)
+++ trunk/Source/WebCore/ChangeLog 2012-12-14 00:20:23 UTC (rev 137680)
@@ -1,3 +1,24 @@
+2012-12-13 Andreas Kling
+
+Event dispatch: Avoid heap allocations in ensureEventAncestors() typical case.
+
+
+Reviewed by Anders Carlsson.
+
+Give the EventTarget and EventContext vectors an inline capacity of 32 (no science here, just a
+non-zero number.) As these vectors are created on the stack already, this is merely using a bit
+more stack space to avoid malloc()ing all the gosh-darn time.
+
+Looks like ~6% improvement on Dromaeo/jslib-event-prototype.
+
+* dom/EventDispatcher.cpp:
+(WebCore::EventRelatedTargetAdjuster::adjust):
+(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):
+(WebCore::EventDispatcher::ensureEventAncestors):
+* dom/EventDispatcher.h:
+(EventRelatedTargetAdjuster):
+(EventDispatcher):
+
2012-12-13 James Simonsen
[Resource Timing] Don't report resources with data: urls
Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (137679 => 137680)
--- trunk/Source/WebCore/dom/EventDispatcher.cpp 2012-12-14 00:20:07 UTC (rev 137679)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp 2012-12-14 00:20:23 UTC (rev 137680)
@@ -60,12 +60,12 @@
ASSERT(m_relatedTarget);
}
-void EventRelatedTargetAdjuster::adjust(Vector& ancestors)
+void EventRelatedTargetAdjuster::adjust(Vector& ancestors)
{
// Synthetic mouse events can have a relatedTarget which is identical to the target.
bool targetIsIdenticalToToRelatedTarget = (m_node.get() == m_relatedTarget.get());
-Vector relatedTargetStack;
+Vector relatedTargetStack;
TreeScope* lastTreeScope = 0;
for (AncestorChainWalker walker(m_relatedTarget.get()); walker.get(); walker.parent()) {
Node* node = walker.get();
@@ -86,7 +86,7 @@
lastTreeScope = 0;
EventTarget* adjustedRelatedTarget = 0;
-for (Vector::iterator iter = ancestors.begin(); iter < ancestors.end(); ++iter) {
+for (Vector::iterator iter = ancestors.begin(); iter < ancestors.end(); ++iter) {
TreeScope* scope = iter->node()->treeScope();
if (scope == lastTreeScope) {
// Re-use the previous adjustedRelatedTarget if treeScope does not change. Just for the performance optimization.
@@ -111,7 +111,7 @@
EventTarget* EventRelatedTargetAdjuster::findRelatedTarget(TreeScope* scope)
{
-Vector parentTreeScopes;
+Vector parentTreeScopes;
EventTarget* relatedTarget = 0;
while (scope) {
parentTreeScopes.append(scope);
@@ -122,7 +122,7 @@
}
scope = scope->parentTreeScope();
}
-for (Vector::iterator iter = parentTreeScopes.begin(); iter < parentTreeScopes.end(); ++iter)
+for (Vector::iterator iter = parentTreeScopes.begin(); iter < parentTreeScopes.end(); ++iter)
m_relatedTargetMap.add(*iter, relatedTarget);
return relatedTarget;
}
@@ -188,7 +188,7 @@
m_ancestorsInitialized = true;
bool inDocument = m_node->inDocument();
bool isSVGElement = m_node->isSVGElement();
-Vector targetStack;
+Vector targetStack;
for (AncestorChainWalker walker(m_node.get()); walker.get(); walker.parent()) {
Node* node = walker.get();
if (targetStack.isEmpty())
Modified: trunk/Source/WebCore/dom/EventDispatcher.h (137679 => 137680)
--- trunk/Source/WebCore/dom/EventDispatcher.h 2012-12-14 00:20:07 UTC (rev 137679)
+++ trunk/Source/WebCore/dom/EventDispatcher.h 2012-12-14 00:20:23 UTC (rev 137680)
@@ -26,6 +26,7 @@
#ifndef EventDispatcher_h
#define EventDispatcher_h
+#include "EventContext.h"
#include "SimulatedClickOptions.h"
#include
#include
@@ -34,7 +35,6 @@
namespace WebCore {
class Event;
-class EventContext;
class EventDispatchMediator;
class EventTarget;
class FrameView;
@@ -58
[webkit-changes] [137679] branches/safari-536.28-branch/Source
Title: [137679] branches/safari-536.28-branch/Source Revision 137679 Author lforsch...@apple.com Date 2012-12-13 16:20:07 -0800 (Thu, 13 Dec 2012) Log Message Versioning. Modified Paths branches/safari-536.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-536.28-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-536.28-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-536.28-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-536.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig (137678 => 137679) --- branches/safari-536.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-12-14 00:17:29 UTC (rev 137678) +++ branches/safari-536.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-12-14 00:20:07 UTC (rev 137679) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 28; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-536.28-branch/Source/WebCore/Configurations/Version.xcconfig (137678 => 137679) --- branches/safari-536.28-branch/Source/WebCore/Configurations/Version.xcconfig 2012-12-14 00:17:29 UTC (rev 137678) +++ branches/safari-536.28-branch/Source/WebCore/Configurations/Version.xcconfig 2012-12-14 00:20:07 UTC (rev 137679) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 28; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-536.28-branch/Source/WebKit/mac/Configurations/Version.xcconfig (137678 => 137679) --- branches/safari-536.28-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-12-14 00:17:29 UTC (rev 137678) +++ branches/safari-536.28-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-12-14 00:20:07 UTC (rev 137679) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 28; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-536.28-branch/Source/WebKit2/Configurations/Version.xcconfig (137678 => 137679) --- branches/safari-536.28-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-12-14 00:17:29 UTC (rev 137678) +++ branches/safari-536.28-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-12-14 00:20:07 UTC (rev 137679) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 28; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137678] tags/Safari-536.28.7/
Title: [137678] tags/Safari-536.28.7/ Revision 137678 Author lforsch...@apple.com Date 2012-12-13 16:17:29 -0800 (Thu, 13 Dec 2012) Log Message New Tag. Added Paths tags/Safari-536.28.7/ Diff Property changes: tags/Safari-536.28.7 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137677] trunk
Title: [137677] trunk
Revision 137677
Author simon...@chromium.org
Date 2012-12-13 16:13:21 -0800 (Thu, 13 Dec 2012)
Log Message
[Resource Timing] Don't report resources with data: urls
https://bugs.webkit.org/show_bug.cgi?id=104868
Reviewed by Tony Gentilcore.
Source/WebCore:
Test: http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::loadDone):
LayoutTests:
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url-expected.txt: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
Added Paths
trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url-expected.txt
trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137676 => 137677)
--- trunk/LayoutTests/ChangeLog 2012-12-14 00:06:20 UTC (rev 137676)
+++ trunk/LayoutTests/ChangeLog 2012-12-14 00:13:21 UTC (rev 137677)
@@ -1,3 +1,13 @@
+2012-12-13 James Simonsen
+
+[Resource Timing] Don't report resources with data: urls
+https://bugs.webkit.org/show_bug.cgi?id=104868
+
+Reviewed by Tony Gentilcore.
+
+* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url-expected.txt: Added.
+* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html: Added.
+
2012-12-13 Beth Dakin
Rubber-stamped by Tim Horton.
Added: trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url-expected.txt (0 => 137677)
--- trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url-expected.txt 2012-12-14 00:13:21 UTC (rev 137677)
@@ -0,0 +1,8 @@
+Description
+
+This test validates that resources with data: URIs aren't present in the Resource Timing buffer.
+
+
+
+PASS entries.length == 0
+
Added: trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html (0 => 137677)
--- trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html (rev 0)
+++ trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html 2012-12-14 00:13:21 UTC (rev 137677)
@@ -0,0 +1,31 @@
+
+
+
+
+Resource Timing ignores requests for data: URIs
+
+
+var iframe;
+function setup_iframe() {
+var iframe_content = '
+
+
+Description
+This test validates that resources with data: URIs aren't present in the Resource Timing buffer.
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (137676 => 137677)
--- trunk/Source/WebCore/ChangeLog 2012-12-14 00:06:20 UTC (rev 137676)
+++ trunk/Source/WebCore/ChangeLog 2012-12-14 00:13:21 UTC (rev 137677)
@@ -1,3 +1,15 @@
+2012-12-13 James Simonsen
+
+[Resource Timing] Don't report resources with data: urls
+https://bugs.webkit.org/show_bug.cgi?id=104868
+
+Reviewed by Tony Gentilcore.
+
+Test: http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html
+
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::loadDone):
+
2012-12-13 Ian Vollick
Add a missing nullity check in RenderObject::containingBlock
Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (137676 => 137677)
--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2012-12-14 00:06:20 UTC (rev 137676)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2012-12-14 00:13:21 UTC (rev 137677)
@@ -704,7 +704,7 @@
#if ENABLE(RESOURCE_TIMING)
// FIXME: Add resource timing support for main resources.
-if (resource && resource->type() != CachedResource::MainResource && !resource->errorOccurred() && !resource->wasCanceled()) {
+if (resource && resource->type() != CachedResource::MainResource && !resource->errorOccurred() && !resource->wasCanceled() && resource->response().isHTTP()) {
HashMap::iterator initiatorIt = m_initiatorMap.find(resource);
if (initiatorIt != m_initiatorMap.end()) {
ASSERT(document());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137676] trunk/LayoutTests
Title: [137676] trunk/LayoutTests
Revision 137676
Author bda...@apple.com
Date 2012-12-13 16:06:20 -0800 (Thu, 13 Dec 2012)
Log Message
Rubber-stamped by Tim Horton.
This test needs updates results after http://trac.webkit.org/changeset/137393
* platform/mac/svg/css/shadow-changes-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/css/shadow-changes-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (137675 => 137676)
--- trunk/LayoutTests/ChangeLog 2012-12-14 00:00:34 UTC (rev 137675)
+++ trunk/LayoutTests/ChangeLog 2012-12-14 00:06:20 UTC (rev 137676)
@@ -1,3 +1,11 @@
+2012-12-13 Beth Dakin
+
+Rubber-stamped by Tim Horton.
+
+This test needs updates results after http://trac.webkit.org/changeset/137393
+
+* platform/mac/svg/css/shadow-changes-expected.txt:
+
2012-12-13 Tab Atkins
Switch the gradient drawing code to use bearing angles
Modified: trunk/LayoutTests/platform/mac/svg/css/shadow-changes-expected.txt (137675 => 137676)
--- trunk/LayoutTests/platform/mac/svg/css/shadow-changes-expected.txt 2012-12-14 00:00:34 UTC (rev 137675)
+++ trunk/LayoutTests/platform/mac/svg/css/shadow-changes-expected.txt 2012-12-14 00:06:20 UTC (rev 137676)
@@ -1,8 +1,8 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
- RenderSVGRoot {svg} at (146,16) size 315x288
-RenderSVGContainer {g} at (116,0) size 345x304
+ RenderSVGRoot {svg} at (135,5) size 326x285
+RenderSVGContainer {g} at (105,0) size 356x290
RenderSVGRect {rect} at (135,5) size 215x215 [fill={[type=SOLID] [color=#FF]}] [x=150.00] [y=20.00] [width=200.00] [height=200.00]
RenderSVGEllipse {circle} at (205,75) size 215x215 [fill={[type=SOLID] [color=#FF]}] [cx=320.00] [cy=190.00] [r=100.00]
RenderSVGText {text} at (270,36) size 191x107 contains 1 chunk(s)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137675] branches/chromium/1312
Title: [137675] branches/chromium/1312
Revision 137675
Author cev...@google.com
Date 2012-12-13 16:00:34 -0800 (Thu, 13 Dec 2012)
Log Message
Merge 136845
BUG=162494
Modified Paths
branches/chromium/1312/LayoutTests/platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png
branches/chromium/1312/Source/WebCore/svg/graphics/SVGImageCache.cpp
Added Paths
branches/chromium/1312/LayoutTests/svg/as-image/animated-use-as-image-crash-expected.txt
branches/chromium/1312/LayoutTests/svg/as-image/animated-use-as-image-crash.html
branches/chromium/1312/LayoutTests/svg/as-image/resources/animated-href-on-use.svg
Diff
Modified: branches/chromium/1312/LayoutTests/platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png
(Binary files differ)
Copied: branches/chromium/1312/LayoutTests/svg/as-image/animated-use-as-image-crash-expected.txt (from rev 136845, trunk/LayoutTests/svg/as-image/animated-use-as-image-crash-expected.txt) (0 => 137675)
--- branches/chromium/1312/LayoutTests/svg/as-image/animated-use-as-image-crash-expected.txt (rev 0)
+++ branches/chromium/1312/LayoutTests/svg/as-image/animated-use-as-image-crash-expected.txt 2012-12-14 00:00:34 UTC (rev 137675)
@@ -0,0 +1,3 @@
+Test passes if loaded into Chromium with Asan enabled and does not crash.
+
+
Copied: branches/chromium/1312/LayoutTests/svg/as-image/animated-use-as-image-crash.html (from rev 136845, trunk/LayoutTests/svg/as-image/animated-use-as-image-crash.html) (0 => 137675)
--- branches/chromium/1312/LayoutTests/svg/as-image/animated-use-as-image-crash.html (rev 0)
+++ branches/chromium/1312/LayoutTests/svg/as-image/animated-use-as-image-crash.html 2012-12-14 00:00:34 UTC (rev 137675)
@@ -0,0 +1,14 @@
+
+
+ Test passes if loaded into Chromium with Asan enabled and does not crash.
+
+
+if (window.testRunner) {
+ testRunner.waitUntilDone();
+ testRunner.dumpAsText();
+}
+
+setTimeout(function() { if (window.testRunner) testRunner.notifyDone(); }, 500);
+
+
+
Copied: branches/chromium/1312/LayoutTests/svg/as-image/resources/animated-href-on-use.svg (from rev 136845, trunk/LayoutTests/svg/as-image/resources/animated-href-on-use.svg) (0 => 137675)
--- branches/chromium/1312/LayoutTests/svg/as-image/resources/animated-href-on-use.svg (rev 0)
+++ branches/chromium/1312/LayoutTests/svg/as-image/resources/animated-href-on-use.svg 2012-12-14 00:00:34 UTC (rev 137675)
@@ -0,0 +1,15 @@
+
+
+
+
+
+
+Pass if no crash in Asan builds, message 1
+Pass if no crash in Asan builds, message 2
+
+
+
+
+
+
Modified: branches/chromium/1312/Source/WebCore/svg/graphics/SVGImageCache.cpp (137674 => 137675)
--- branches/chromium/1312/Source/WebCore/svg/graphics/SVGImageCache.cpp 2012-12-13 23:52:35 UTC (rev 137674)
+++ branches/chromium/1312/Source/WebCore/svg/graphics/SVGImageCache.cpp 2012-12-14 00:00:34 UTC (rev 137675)
@@ -90,14 +90,9 @@
for (ImageDataMap::iterator it = m_imageDataMap.begin(); it != end; ++it)
it->value.imageNeedsUpdate = true;
-// If we're in the middle of layout, start redrawing dirty
-// images on a timer; otherwise it's safe to draw immediately.
-FrameView* frameView = m_svgImage->frameView();
-if (frameView && (frameView->needsLayout() || frameView->isInLayout())) {
-if (!m_redrawTimer.isActive())
-m_redrawTimer.startOneShot(0);
-} else
- redraw();
+// Always redraw on a timer because this method may be invoked from destructors of things we are intending to draw.
+if (!m_redrawTimer.isActive())
+m_redrawTimer.startOneShot(0);
}
void SVGImageCache::redraw()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137674] trunk/Source/WebCore
Title: [137674] trunk/Source/WebCore
Revision 137674
Author voll...@chromium.org
Date 2012-12-13 15:52:35 -0800 (Thu, 13 Dec 2012)
Log Message
Add a missing nullity check in RenderObject::containingBlock
https://bugs.webkit.org/show_bug.cgi?id=104961
Reviewed by Adrienne Walker.
Adds a missing nullity check in an assert.
No new tests, no change in functionality.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (137673 => 137674)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 23:49:06 UTC (rev 137673)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 23:52:35 UTC (rev 137674)
@@ -1,3 +1,17 @@
+2012-12-13 Ian Vollick
+
+Add a missing nullity check in RenderObject::containingBlock
+https://bugs.webkit.org/show_bug.cgi?id=104961
+
+Reviewed by Adrienne Walker.
+
+Adds a missing nullity check in an assert.
+
+No new tests, no change in functionality.
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::containingBlock):
+
2012-12-13 Tab Atkins
Switch the gradient drawing code to use bearing angles
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (137673 => 137674)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2012-12-13 23:49:06 UTC (rev 137673)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2012-12-13 23:52:35 UTC (rev 137674)
@@ -768,7 +768,7 @@
#endif
o = o->parent();
}
-ASSERT(!o->isAnonymousBlock());
+ASSERT(!o || !o->isAnonymousBlock());
} else if (!isText() && m_style->position() == AbsolutePosition) {
while (o) {
// For relpositioned inlines, we return the nearest non-anonymous enclosing block. We don't try
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137673] trunk/Tools
Title: [137673] trunk/Tools
Revision 137673
Author dpra...@chromium.org
Date 2012-12-13 15:49:06 -0800 (Thu, 13 Dec 2012)
Log Message
Unreviewed, rolling out r137661.
http://trac.webkit.org/changeset/137661
https://bugs.webkit.org/show_bug.cgi?id=104891
broke unit tests, run-webkit-tests
* Scripts/webkitpy/common/system/executive.py:
(Executive._run_command_with_teed_output):
(Executive.run_command):
(Executive.popen):
* Scripts/webkitpy/common/system/profiler.py:
(ProfilerFactory.create_profiler):
(GooglePProf.profile_after_exit):
(IProfiler.attach_to_pid):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.__init__):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/executive.py
trunk/Tools/Scripts/webkitpy/common/system/profiler.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
Diff
Modified: trunk/Tools/ChangeLog (137672 => 137673)
--- trunk/Tools/ChangeLog 2012-12-13 23:42:03 UTC (rev 137672)
+++ trunk/Tools/ChangeLog 2012-12-13 23:49:06 UTC (rev 137673)
@@ -1,5 +1,26 @@
2012-12-13 Dirk Pranke
+Unreviewed, rolling out r137661.
+http://trac.webkit.org/changeset/137661
+https://bugs.webkit.org/show_bug.cgi?id=104891
+
+broke unit tests, run-webkit-tests
+
+* Scripts/webkitpy/common/system/executive.py:
+(Executive._run_command_with_teed_output):
+(Executive.run_command):
+(Executive.popen):
+* Scripts/webkitpy/common/system/profiler.py:
+(ProfilerFactory.create_profiler):
+(GooglePProf.profile_after_exit):
+(IProfiler.attach_to_pid):
+* Scripts/webkitpy/layout_tests/port/driver.py:
+(Driver.__init__):
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner._parse_args):
+
+2012-12-13 Dirk Pranke
+
nrwt: move rundetails, summarize_results into test_run_results
https://bugs.webkit.org/show_bug.cgi?id=104963
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (137672 => 137673)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2012-12-13 23:42:03 UTC (rev 137672)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2012-12-13 23:49:06 UTC (rev 137673)
@@ -101,6 +101,9 @@
return sys.platform not in ('win32', 'cygwin')
def _run_command_with_teed_output(self, args, teed_output, **kwargs):
+args = map(unicode, args) # Popen will throw an exception if args are non-strings (like int())
+args = map(self._encode_argument_if_needed, args)
+
child_process = self.popen(args,
stdout=self.PIPE,
stderr=self.STDOUT,
@@ -387,6 +390,8 @@
"""Popen wrapper for convenience and to work around python bugs."""
assert(isinstance(args, list) or isinstance(args, tuple))
start_time = time.time()
+args = map(unicode, args) # Popen will throw an exception if args are non-strings (like int())
+args = map(self._encode_argument_if_needed, args)
stdin, string_to_communicate = self._compute_stdin(input)
stderr = self.STDOUT if return_stderr else None
@@ -453,9 +458,7 @@
return argument.encode(self._child_process_encoding())
def popen(self, *args, **kwargs):
-string_args = map(unicode, *args) # Popen will throw an exception if args are non-strings (like int())
-string_args = map(self._encode_argument_if_needed, string_args)
-return subprocess.Popen(string_args, **kwargs)
+return subprocess.Popen(*args, **kwargs)
def run_in_parallel(self, command_lines_and_cwds, processes=None):
"""Runs a list of (cmd_line list, cwd string) tuples in parallel and returns a list of (retcode, stdout, stderr) tuples."""
Modified: trunk/Tools/Scripts/webkitpy/common/system/profiler.py (137672 => 137673)
--- trunk/Tools/Scripts/webkitpy/common/system/profiler.py 2012-12-13 23:42:03 UTC (rev 137672)
+++ trunk/Tools/Scripts/webkitpy/common/system/profiler.py 2012-12-13 23:49:06 UTC (rev 137673)
@@ -34,30 +34,12 @@
class ProfilerFactory(object):
@classmethod
-def create_profiler(cls, host, executable_path, output_dir, profiler_name=None, identifier=None):
-profilers_by_name = cls.available_profilers_by_name(host.platform)
-profiler_class = profilers_by_name.get(profiler_name or cls.default_profiler_name(host.platform))
-if not profiler_class:
-return None
-return profiler_class(host, executable_path, output_dir, identifier)
+def create_profiler(cls, host, executable_path, output_dir, identifier=None):
+if host.platform.is_mac():
+return IProfiler(host, executable_path, output_dir, identifier)
+return GooglePProf(host
[webkit-changes] [137670] branches/chromium/1312/Source/WebCore/editing/ApplyStyleCommand. cpp
Title: [137670] branches/chromium/1312/Source/WebCore/editing/ApplyStyleCommand.cpp
Revision 137670
Author cev...@google.com
Date 2012-12-13 15:37:52 -0800 (Thu, 13 Dec 2012)
Log Message
Merge 136619
BUG=163110
Review URL: https://codereview.chromium.org/11577012
Modified Paths
branches/chromium/1312/Source/WebCore/editing/ApplyStyleCommand.cpp
Diff
Modified: branches/chromium/1312/Source/WebCore/editing/ApplyStyleCommand.cpp (137669 => 137670)
--- branches/chromium/1312/Source/WebCore/editing/ApplyStyleCommand.cpp 2012-12-13 23:34:31 UTC (rev 137669)
+++ branches/chromium/1312/Source/WebCore/editing/ApplyStyleCommand.cpp 2012-12-13 23:37:52 UTC (rev 137670)
@@ -974,24 +974,22 @@
return;
// The outer loop is traversing the tree vertically from highestAncestor to targetNode
-Node* current = highestAncestor;
+RefPtr current = highestAncestor;
// Along the way, styled elements that contain targetNode are removed and accumulated into elementsToPushDown.
// Each child of the removed element, exclusing ancestors of targetNode, is then wrapped by clones of elements in elementsToPushDown.
Vector > elementsToPushDown;
-while (current != targetNode) {
-ASSERT(current);
-ASSERT(current->contains(targetNode));
+while (current && current != targetNode && current->contains(targetNode)) {
NodeVector currentChildren;
-getChildNodes(current, currentChildren);
+getChildNodes(current.get(), currentChildren);
RefPtr styledElement;
-if (current->isStyledElement() && isStyledInlineElementToRemove(static_cast(current))) {
-styledElement = static_cast(current);
+if (current->isStyledElement() && isStyledInlineElementToRemove(static_cast(current.get( {
+styledElement = static_cast(current.get());
elementsToPushDown.append(styledElement);
}
RefPtr styleToPushDown = EditingStyle::create();
if (current->isHTMLElement())
-removeInlineStyleFromElement(style, toHTMLElement(current), RemoveIfNeeded, styleToPushDown.get());
+removeInlineStyleFromElement(style, toHTMLElement(current.get()), RemoveIfNeeded, styleToPushDown.get());
// The inner loop will go through children on each level
// FIXME: we should aggregate inline child elements together so that we don't wrap each child separately.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137669] trunk
Title: [137669] trunk Revision 137669 Author commit-qu...@webkit.org Date 2012-12-13 15:34:31 -0800 (Thu, 13 Dec 2012) Log Message Switch the gradient drawing code to use bearing angles https://bugs.webkit.org/show_bug.cgi?id=104616 Patch by Tab Atkins on 2012-12-13 Reviewed by Dean Jackson. Source/WebCore: Switch the gradient math from polar-coordinate angles to bearing angles. To make this possible without behavior changes, switch the m_deprecatedType boolean to an m_gradientType enum, and fix all usages accordingly. No new tests, as this is a refactoring and should have no behavior changes. Existing tests suffice. * css/CSSGradientValue.cpp: (WebCore::endPointsFromAngle): This is the only mechanical change. The rest are just fixing the plumbing around the boolean->enum change. * css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::sortStopsIfNeeded): (WebCore::CSSGradientValue::addStops): (WebCore::CSSLinearGradientValue::customCssText): (WebCore::CSSLinearGradientValue::createGradient): (WebCore::CSSRadialGradientValue::customCssText): * css/CSSGradientValue.h: (WebCore::CSSGradientValue::gradientType): (WebCore::CSSGradientValue::CSSGradientValue): (WebCore::CSSLinearGradientValue::create): (WebCore::CSSLinearGradientValue::CSSLinearGradientValue): (WebCore::CSSRadialGradientValue::create): (WebCore::CSSRadialGradientValue::CSSRadialGradientValue): * css/CSSParser.cpp: (WebCore::CSSParser::parseDeprecatedGradient): (WebCore::CSSParser::parseDeprecatedLinearGradient): (WebCore::CSSParser::parseDeprecatedRadialGradient): LayoutTests: This change alters a few pixels on the linux baseline. It may or may not trigger similar failures on Windows and Mac - we'll see. * platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSGradientValue.cpp trunk/Source/WebCore/css/CSSGradientValue.h trunk/Source/WebCore/css/CSSParser.cpp Diff Modified: trunk/LayoutTests/ChangeLog (137668 => 137669) --- trunk/LayoutTests/ChangeLog 2012-12-13 23:33:45 UTC (rev 137668) +++ trunk/LayoutTests/ChangeLog 2012-12-13 23:34:31 UTC (rev 137669) @@ -1,3 +1,16 @@ +2012-12-13 Tab Atkins + +Switch the gradient drawing code to use bearing angles +https://bugs.webkit.org/show_bug.cgi?id=104616 + +Reviewed by Dean Jackson. + +This change alters a few pixels on the linux baseline. +It may or may not trigger similar failures on Windows and Mac - we'll see. + +* platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png: +* platform/chromium/TestExpectations: + 2012-12-13 Adam Klein Mark one test as failing and rebaseline another after r137646 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137668 => 137669) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-13 23:33:45 UTC (rev 137668) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-13 23:34:31 UTC (rev 137669) @@ -4190,6 +4190,8 @@ webkit.org/b/104727 transforms/3d/hit-testing/backface-hit-test.html [ Pass ImageOnlyFailure ] webkit.org/b/104727 transforms/3d/hit-testing/backface-no-transform-hit-test.html [ Pass ImageOnlyFailure ] +webkit.org/b/104616 [ Win Mac ] fast/gradients/css3-linear-angle-gradients.html [ ImageOnlyFailure Pass ] + # Fail only on WebKit-only checkout webkit.org/b/104548 [ Linux ] fast/text/hyphenate-character.html [ Failure ] webkit.org/b/104548 [ Linux ] fast/text/hyphenate-first-word.html [ Failure ] Modified: trunk/LayoutTests/platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png (Binary files differ) Modified: trunk/Source/WebCore/ChangeLog (137668 => 137669) --- trunk/Source/WebCore/ChangeLog 2012-12-13 23:33:45 UTC (rev 137668) +++ trunk/Source/WebCore/ChangeLog 2012-12-13 23:34:31 UTC (rev 137669) @@ -1,3 +1,39 @@ +2012-12-13 Tab Atkins + +Switch the gradient drawing code to use bearing angles +https://bugs.webkit.org/show_bug.cgi?id=104616 + +Reviewed by Dean Jackson. + +Switch the gradient math from polar-coordinate angles to bearing angles. +To make this possible without behavior changes, +switch the m_deprecatedType boolean to an m_gradientType enum, +and fix all usages accordingly. + +No new tests, as this is a refactoring and should have no behavior changes. Existing tests suffice. + +* css/CSSGradientValue.cpp: +(WebCore::endPointsFromAngle): +This is the only mechanical change. The rest are just fixing the plumbing around the boolean->enum change. + +* css/CSSGradientValue.cpp: +(WebCore::CSSGradientValue::sortStopsIfNeeded): +
[webkit-changes] [137668] branches/chromium/1312
Title: [137668] branches/chromium/1312
Revision 137668
Author cev...@google.com
Date 2012-12-13 15:33:45 -0800 (Thu, 13 Dec 2012)
Log Message
Merge 136560
BUG=158199
Review URL: https://codereview.chromium.org/11565023
Modified Paths
branches/chromium/1312/Source/WebCore/css/CSSImageSetValue.cpp
branches/chromium/1312/Source/WebCore/rendering/style/StyleCachedImageSet.h
Added Paths
branches/chromium/1312/LayoutTests/fast/css/image-set-value-not-removed-crash-expected.txt
branches/chromium/1312/LayoutTests/fast/css/image-set-value-not-removed-crash.html
Diff
Copied: branches/chromium/1312/LayoutTests/fast/css/image-set-value-not-removed-crash-expected.txt (from rev 136560, trunk/LayoutTests/fast/css/image-set-value-not-removed-crash-expected.txt) (0 => 137668)
--- branches/chromium/1312/LayoutTests/fast/css/image-set-value-not-removed-crash-expected.txt (rev 0)
+++ branches/chromium/1312/LayoutTests/fast/css/image-set-value-not-removed-crash-expected.txt 2012-12-13 23:33:45 UTC (rev 137668)
@@ -0,0 +1,2 @@
+PASS. WebKit didn't crash.
+
Copied: branches/chromium/1312/LayoutTests/fast/css/image-set-value-not-removed-crash.html (from rev 136560, trunk/LayoutTests/fast/css/image-set-value-not-removed-crash.html) (0 => 137668)
--- branches/chromium/1312/LayoutTests/fast/css/image-set-value-not-removed-crash.html (rev 0)
+++ branches/chromium/1312/LayoutTests/fast/css/image-set-value-not-removed-crash.html 2012-12-13 23:33:45 UTC (rev 137668)
@@ -0,0 +1,41 @@
+
+
+A
+
+@-webkit-keyframes anim1 {
+0% {
+opacity: 0.5772; border-image: 26829%;
+}
+100% {
+opacity: 0.3167;
+}
+}
+* {
+-webkit-animation-name: anim1;
+-webkit-animation-duration: 1s;
+}
+.class1 {
+border-image: -webkit-image-set(url(#does-not-exist) 25x, url("does-not-exist.gif") 206x) 2 126 158 166 fill;
+}
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var docElement = document.body;
+docElement.contentEditable = "true";
+
+function crash() {
+test1 = document.createElementNS("http://www.w3.org/1999/xhtml", "td");
+test1.setAttribute("class", "class1");
+docElement.appendChild(test1);
+document.execCommand("SelectAll", false, null)
+document.execCommand("InsertText", false, "PASS. WebKit didn't crash.")
+for (i = 0; i != 49; i++)
+ window.getSelection().modify("move", "forward", "character");
+
+document.execCommand("Italic", false, null);
+}
+document.addEventListener("DOMContentLoaded", crash, false);
+
+
\ No newline at end of file
Modified: branches/chromium/1312/Source/WebCore/css/CSSImageSetValue.cpp (137667 => 137668)
--- branches/chromium/1312/Source/WebCore/css/CSSImageSetValue.cpp 2012-12-13 23:31:55 UTC (rev 137667)
+++ branches/chromium/1312/Source/WebCore/css/CSSImageSetValue.cpp 2012-12-13 23:33:45 UTC (rev 137668)
@@ -51,6 +51,8 @@
CSSImageSetValue::~CSSImageSetValue()
{
+if (m_imageSet && m_imageSet->isCachedImageSet())
+static_cast(m_imageSet.get())->clearImageSetValue();
}
void CSSImageSetValue::fillImageSet()
Modified: branches/chromium/1312/Source/WebCore/rendering/style/StyleCachedImageSet.h (137667 => 137668)
--- branches/chromium/1312/Source/WebCore/rendering/style/StyleCachedImageSet.h 2012-12-13 23:31:55 UTC (rev 137667)
+++ branches/chromium/1312/Source/WebCore/rendering/style/StyleCachedImageSet.h 2012-12-13 23:33:45 UTC (rev 137668)
@@ -58,6 +58,8 @@
CachedImage* cachedImage() const { return m_bestFitImage.get(); }
+void clearImageSetValue() { m_imageSetValue = 0; }
+
virtual bool canRender(const RenderObject*, float multiplier) const;
virtual bool isLoaded() const;
virtual bool errorOccurred() const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137667] trunk/LayoutTests
Title: [137667] trunk/LayoutTests Revision 137667 Author ad...@chromium.org Date 2012-12-13 15:31:55 -0800 (Thu, 13 Dec 2012) Log Message Mark one test as failing and rebaseline another after r137646 Unreviewed chromium gardening. * platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added. * platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added. * platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Added Paths trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/ trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/ trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/ trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/ trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/ trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/ trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (137666 => 137667) --- trunk/LayoutTests/ChangeLog 2012-12-13 23:30:51 UTC (rev 137666) +++ trunk/LayoutTests/ChangeLog 2012-12-13 23:31:55 UTC (rev 137667) @@ -1,5 +1,16 @@ 2012-12-13 Adam Klein +Mark one test as failing and rebaseline another after r137646 + +Unreviewed chromium gardening. + +* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added. +* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added. +* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added. +* platform/chromium/TestExpectations: + +2012-12-13 Adam Klein + Move MutationObserver tests to fast/dom/MutationObserver https://bugs.webkit.org/show_bug.cgi?id=104948 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137666 => 137667) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-13 23:30:51 UTC (rev 137666) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-13 23:31:55 UTC (rev 137667) @@ -1450,6 +1450,9 @@ # Fails on webkit windows as well. crbug.com/24207 fast/events/attempt-scroll-with-no-scrollbars.html [ Failure ] +# Fails when opting into composited scrolling. +webkit.org/b/104965 [ Mac ] platform/chromium/virtual/gpu/compositedscrolling/scrollbars/scrollbar-drag-thumb-with-large-content.html [ Failure ] + # No glyph for U+FFFD (Replacement Character : black diamond with # question mark) in them on Win XP. crbug.com/10315 [ XP ] fast/encoding/invalid-UTF-8.html [ Failure ] Added: trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scroll
[webkit-changes] [137666] trunk/Tools
Title: [137666] trunk/Tools
Revision 137666
Author e...@webkit.org
Date 2012-12-13 15:30:51 -0800 (Thu, 13 Dec 2012)
Log Message
Make --profile output easier to understand for pprof on linux
https://bugs.webkit.org/show_bug.cgi?id=104957
Reviewed by Dirk Pranke.
pprof is kinda mysterious, so we print some information
on how to use it, and how to learn how to read the sample dump.
This is similar to what we've done for perf output for Chromium Android.
* Scripts/webkitpy/common/system/profiler.py:
(GooglePProf._pprof_path):
(GooglePProf.profile_after_exit):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/profiler.py
Diff
Modified: trunk/Tools/ChangeLog (137665 => 137666)
--- trunk/Tools/ChangeLog 2012-12-13 23:28:12 UTC (rev 137665)
+++ trunk/Tools/ChangeLog 2012-12-13 23:30:51 UTC (rev 137666)
@@ -1,3 +1,18 @@
+2012-12-13 Eric Seidel
+
+Make --profile output easier to understand for pprof on linux
+https://bugs.webkit.org/show_bug.cgi?id=104957
+
+Reviewed by Dirk Pranke.
+
+pprof is kinda mysterious, so we print some information
+on how to use it, and how to learn how to read the sample dump.
+This is similar to what we've done for perf output for Chromium Android.
+
+* Scripts/webkitpy/common/system/profiler.py:
+(GooglePProf._pprof_path):
+(GooglePProf.profile_after_exit):
+
2012-12-13 Dirk Pranke
Revert r137407 - it didn't actually work right.
Modified: trunk/Tools/Scripts/webkitpy/common/system/profiler.py (137665 => 137666)
--- trunk/Tools/Scripts/webkitpy/common/system/profiler.py 2012-12-13 23:28:12 UTC (rev 137665)
+++ trunk/Tools/Scripts/webkitpy/common/system/profiler.py 2012-12-13 23:30:51 UTC (rev 137666)
@@ -94,19 +94,25 @@
match = re.search("^Total:[^\n]*\n((?:[^\n]*\n){0,10})", pprof_output, re.MULTILINE)
return match.group(1) if match else None
-def profile_after_exit(self):
+def _pprof_path(self):
# FIXME: We should have code to find the right google-pprof executable, some Googlers have
# google-pprof installed as "pprof" on their machines for them.
-# FIXME: Similarly we should find the right perl!
+return '/usr/bin/google-pprof'
+def profile_after_exit(self):
# google-pprof doesn't check its arguments, so we have to.
if not (self._host.filesystem.exists(self._output_path)):
print "Failed to gather profile, %s does not exist." % self._output_path
return
-pprof_args = ['/usr/bin/perl', '/usr/bin/google-pprof', '--text', self._executable_path, self._output_path]
+pprof_args = [self._pprof_path(), '--text', self._executable_path, self._output_path]
profile_text = self._host.executive.run_command(pprof_args)
+print "First 10 lines of pprof --text:"
print self._first_ten_lines_of_profile(profile_text)
+print "http://google-perftools.googlecode.com/svn/trunk/doc/cpuprofile.html documents output."
+print
+print "To interact with the the full profile, including produce graphs:"
+print ' '.join([self._pprof_path(), self._executable_path, self._output_path])
class Sample(SingleFileOutputProfiler):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137665] branches/chromium/1312
Title: [137665] branches/chromium/1312
Revision 137665
Author cev...@google.com
Date 2012-12-13 15:28:12 -0800 (Thu, 13 Dec 2012)
Log Message
Merge 136558
BUG=158060
Review URL: https://codereview.chromium.org/11573024
Modified Paths
branches/chromium/1312/Source/WebCore/css/CSSCrossfadeValue.cpp
Added Paths
branches/chromium/1312/LayoutTests/fast/images/crossfade-client-not-removed-crash-expected.txt
branches/chromium/1312/LayoutTests/fast/images/crossfade-client-not-removed-crash.html
Diff
Copied: branches/chromium/1312/LayoutTests/fast/images/crossfade-client-not-removed-crash-expected.txt (from rev 136558, trunk/LayoutTests/fast/images/crossfade-client-not-removed-crash-expected.txt) (0 => 137665)
--- branches/chromium/1312/LayoutTests/fast/images/crossfade-client-not-removed-crash-expected.txt (rev 0)
+++ branches/chromium/1312/LayoutTests/fast/images/crossfade-client-not-removed-crash-expected.txt 2012-12-13 23:28:12 UTC (rev 137665)
@@ -0,0 +1,2 @@
+Blocked access to external URL http://-4294967295/
+PASS. WebKit didn't crash.
Copied: branches/chromium/1312/LayoutTests/fast/images/crossfade-client-not-removed-crash.html (from rev 136558, trunk/LayoutTests/fast/images/crossfade-client-not-removed-crash.html) (0 => 137665)
--- branches/chromium/1312/LayoutTests/fast/images/crossfade-client-not-removed-crash.html (rev 0)
+++ branches/chromium/1312/LayoutTests/fast/images/crossfade-client-not-removed-crash.html 2012-12-13 23:28:12 UTC (rev 137665)
@@ -0,0 +1,34 @@
+
+
+
+A
+
+.class1 {
+background-image: -webkit-cross-fade(url(#does-not-exist), url(http://-4294967295), 157%);
+}
+.class2:first-of-type {
+-webkit-animation-direction: alternate;
+}
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var docElement = document.body;
+docElement.contentEditable = "true";
+
+function crash() {
+test1 = document.createElementNS("http://www.w3.org/1999/xhtml", "thead");
+docElement.appendChild(test1);
+test2 = document.createElementNS("http://www.w3.org/1999/xhtml", "intent");
+test2.setAttribute("class", "class2");
+docElement.appendChild(test2);
+test1.setAttribute("class", "class1");
+window.getSelection().selectAllChildren(tCF1);
+document.execCommand("hilitecolor", false, "#FF");
+document.execCommand("InsertText", false, "PASS. WebKit didn't crash.");
+}
+
+document.addEventListener("DOMContentLoaded", crash, false);
+
+
\ No newline at end of file
Modified: branches/chromium/1312/Source/WebCore/css/CSSCrossfadeValue.cpp (137664 => 137665)
--- branches/chromium/1312/Source/WebCore/css/CSSCrossfadeValue.cpp 2012-12-13 23:27:42 UTC (rev 137664)
+++ branches/chromium/1312/Source/WebCore/css/CSSCrossfadeValue.cpp 2012-12-13 23:28:12 UTC (rev 137665)
@@ -128,14 +128,26 @@
void CSSCrossfadeValue::loadSubimages(CachedResourceLoader* cachedResourceLoader)
{
+CachedResourceHandle oldCachedFromImage = m_cachedFromImage;
+CachedResourceHandle oldCachedToImage = m_cachedToImage;
+
m_cachedFromImage = cachedImageForCSSValue(m_fromValue.get(), cachedResourceLoader);
m_cachedToImage = cachedImageForCSSValue(m_toValue.get(), cachedResourceLoader);
-if (m_cachedFromImage)
-m_cachedFromImage->addClient(&m_crossfadeSubimageObserver);
-if (m_cachedToImage)
-m_cachedToImage->addClient(&m_crossfadeSubimageObserver);
+if (m_cachedFromImage != oldCachedFromImage) {
+if (oldCachedFromImage)
+oldCachedFromImage->removeClient(&m_crossfadeSubimageObserver);
+if (m_cachedFromImage)
+m_cachedFromImage->addClient(&m_crossfadeSubimageObserver);
+}
+if (m_cachedToImage != oldCachedToImage) {
+if (oldCachedToImage)
+oldCachedToImage->removeClient(&m_crossfadeSubimageObserver);
+if (m_cachedToImage)
+m_cachedToImage->addClient(&m_crossfadeSubimageObserver);
+}
+
m_crossfadeSubimageObserver.setReady(true);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137664] trunk/Tools
Title: [137664] trunk/Tools
Revision 137664
Author dpra...@chromium.org
Date 2012-12-13 15:27:42 -0800 (Thu, 13 Dec 2012)
Log Message
Revert r137407 - it didn't actually work right.
https://bugs.webkit.org/show_bug.cgi?id=101976
Unreviewed, build fix.
Turns out that rebaselining was completely broken with this change :(
We're passing in a list of test names rather than the list of
failureInfo objects.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (137663 => 137664)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2012-12-13 23:21:54 UTC (rev 137663)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2012-12-13 23:27:42 UTC (rev 137664)
@@ -30,45 +30,26 @@
var kCheckoutUnavailableMessage = 'Failed! Garden-o-matic needs a local server to modify your working copy. Please run "webkit-patch garden-o-matic" start the local server.';
// FIXME: Where should this function go?
-function rebaselineWithStatusUpdates(failureInfoList, resultsByTest)
+function rebaselineWithStatusUpdates(failureInfoList)
{
+// FIXME: If a test is a reftest, webkit-patch rebaseline-test should error out
+// and we should alert (modal dialog?) the user.
var statusView = new ui.StatusArea('Rebaseline');
var id = statusView.newId();
var testNames = base.uniquifyArray(failureInfoList.map(function(failureInfo) { return failureInfo.testName; }));
+var testName = testNames.length == 1 ? testNames[0] : testNames.length + ' tests';
+statusView.addMessage(id, 'Performing rebaseline of ' + testName + '...');
-var failuresToRebaseline = [];
-testNames.forEach(function(testName) {
-if (isAnyReftest(testName, resultsByTest))
-statusView.addMessage(id, testName + ' is a ref test, skipping');
-else {
-failuresToRebaseline.push(testName);
-statusView.addMessage(id, 'Rebaselining ' + testName + '...');
-}
+checkout.rebaseline(failureInfoList, function() {
+statusView.addFinalMessage(id, 'Rebaseline done! Please land with "webkit-patch land-cowhand".');
+}, function(failureInfo) {
+statusView.addMessage(id, failureInfo.testName + ' on ' + ui.displayNameForBuilder(failureInfo.builderName));
+}, function() {
+statusView.addFinalMessage(id, kCheckoutUnavailableMessage);
});
-
-if (failuresToRebaseline.length) {
-checkout.rebaseline(failuresToRebaseline, function() {
-statusView.addFinalMessage(id, 'Rebaseline done! Please land with "webkit-patch land-cowhand".');
-}, function(failureInfo) {
-statusView.addMessage(id, failureInfo.testName + ' on ' + ui.displayNameForBuilder(failureInfo.builderName));
-}, function() {
-statusView.addFinalMessage(id, kCheckoutUnavailableMessage);
-});
-} else
-statusView.addFinalMessage(id, 'No tests left to rebaseline!')
}
-// FIXME: This is duplicated from ui/results.js :(.
-function isAnyReftest(testName, resultsByTest)
-{
-return Object.keys(resultsByTest[testName]).map(function(builder) {
-return resultsByTest[testName][builder];
-}).some(function(resultNode) {
-return resultNode.reftest_type && resultNode.reftest_type.length;
-});
-}
-
// FIXME: Where should this function go?
function updateExpectationsWithStatusUpdates(failureInfoList)
{
@@ -117,7 +98,7 @@
},
onRebaseline: function()
{
-rebaselineWithStatusUpdates(this._failureInfoList(), this._resultsByTest);
+rebaselineWithStatusUpdates(this._failureInfoList());
this._view.nextTest();
},
onUpdateExpectations: function()
@@ -225,14 +206,7 @@
},
onRebaseline: function(failures)
{
-var testNameList = failures.testNameList();
-var failuresByTest = base.filterDictionary(
-this._resultsFilter(this._model.resultsByBuilder),
-function(key) {
-return testNameList.indexOf(key) != -1;
-});
-
-rebaselineWithStatusUpdates(this._toFailureInfoList(failures), failuresByTest);
+rebaselineWithStatusUpdates(this._toFailureInfoList(failures))
[webkit-changes] [137663] trunk
Title: [137663] trunk
Revision 137663
Author pi...@chromium.org
Date 2012-12-13 15:21:54 -0800 (Thu, 13 Dec 2012)
Log Message
[chromium] Small fixes for WebPluginContainer::setWebLayer
https://bugs.webkit.org/show_bug.cgi?id=104953
Reviewed by James Robinson.
Source/WebKit/chromium:
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::~WebPluginContainerImpl): Allow
WebPlugin to clean up dangling pointers.
Tools:
* DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Clean up
dangling pointers, force correct invalidation of the layer.
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (137662 => 137663)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-13 23:19:51 UTC (rev 137662)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-13 23:21:54 UTC (rev 137663)
@@ -1,5 +1,16 @@
2012-12-13 Antoine Labour
+[chromium] Small fixes for WebPluginContainer::setWebLayer
+https://bugs.webkit.org/show_bug.cgi?id=104953
+
+Reviewed by James Robinson.
+
+* src/WebPluginContainerImpl.cpp:
+(WebKit::WebPluginContainerImpl::~WebPluginContainerImpl): Allow
+WebPlugin to clean up dangling pointers.
+
+2012-12-13 Antoine Labour
+
[chromium] Add WebPluginContainer::setWebLayer to supersede setBackingTextureId/setBackingIOSurfaceId
https://bugs.webkit.org/show_bug.cgi?id=104875
Modified: trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (137662 => 137663)
--- trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-12-13 23:19:51 UTC (rev 137662)
+++ trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-12-13 23:21:54 UTC (rev 137663)
@@ -671,17 +671,16 @@
WebPluginContainerImpl::~WebPluginContainerImpl()
{
-#if USE(ACCELERATED_COMPOSITING)
-if (m_webLayer)
-GraphicsLayerChromium::unregisterContentsLayer(m_webLayer);
-#endif
-
if (m_touchEventRequestType != TouchEventRequestTypeNone)
m_element->document()->didRemoveTouchEventHandler(m_element);
for (size_t i = 0; i < m_pluginLoadObservers.size(); ++i)
m_pluginLoadObservers[i]->clearPluginContainer();
m_webPlugin->destroy();
+#if USE(ACCELERATED_COMPOSITING)
+if (m_webLayer)
+GraphicsLayerChromium::unregisterContentsLayer(m_webLayer);
+#endif
}
void WebPluginContainerImpl::handleMouseEvent(MouseEvent* event)
Modified: trunk/Tools/ChangeLog (137662 => 137663)
--- trunk/Tools/ChangeLog 2012-12-13 23:19:51 UTC (rev 137662)
+++ trunk/Tools/ChangeLog 2012-12-13 23:21:54 UTC (rev 137663)
@@ -1,3 +1,13 @@
+2012-12-13 Antoine Labour
+
+[chromium] Small fixes for WebPluginContainer::setWebLayer
+https://bugs.webkit.org/show_bug.cgi?id=104953
+
+Reviewed by James Robinson.
+
+* DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Clean up
+dangling pointers, force correct invalidation of the layer.
+
2012-12-13 Eric Seidel
Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp (137662 => 137663)
--- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp 2012-12-13 23:19:51 UTC (rev 137662)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp 2012-12-13 23:21:54 UTC (rev 137663)
@@ -311,6 +311,8 @@
void WebTestPluginImpl::destroy()
{
+if (m_container)
+m_container->setWebLayer(0);
m_layer.clear();
destroyScene();
@@ -344,7 +346,7 @@
drawScene();
m_context->flush();
-m_container->commitBackingTexture();
+m_layer->layer()->invalidate();
}
WebTestPluginImpl::Primitive WebTestPluginImpl::parsePrimitive(const WebString& string)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137661] trunk/Tools
Title: [137661] trunk/Tools
Revision 137661
Author e...@webkit.org
Date 2012-12-13 15:17:17 -0800 (Thu, 13 Dec 2012)
Log Message
Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
https://bugs.webkit.org/show_bug.cgi?id=104891
Reviewed by Dirk Pranke.
I also implemented a very simple "Sample" Profiler using
Mac OS X's /usr/bin/sample command line tool.
I also moved the map(unicode, args) call into Executive.popen
so that all callers don't have to do it themselves.
The real reason for this abstraction is to make it easy
to support both perf and pprof on linux which seem to
be about equally popular among those I ask in the Chrome team.
* Scripts/webkitpy/common/system/executive.py:
(Executive.popen):
* Scripts/webkitpy/common/system/profiler.py:
(ProfilerFactory.create_profiler):
(ProfilerFactory):
(ProfilerFactory.available_profilers_by_name):
(ProfilerFactory.default_profiler_name):
(Sample):
(Sample.__init__):
(Sample.attach_to_pid):
(Sample.profile_after_exit):
(IProfiler.attach_to_pid):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.__init__):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/executive.py
trunk/Tools/Scripts/webkitpy/common/system/profiler.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
Diff
Modified: trunk/Tools/ChangeLog (137660 => 137661)
--- trunk/Tools/ChangeLog 2012-12-13 23:11:14 UTC (rev 137660)
+++ trunk/Tools/ChangeLog 2012-12-13 23:17:17 UTC (rev 137661)
@@ -1,3 +1,37 @@
+2012-12-13 Eric Seidel
+
+Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
+https://bugs.webkit.org/show_bug.cgi?id=104891
+
+Reviewed by Dirk Pranke.
+
+I also implemented a very simple "Sample" Profiler using
+Mac OS X's /usr/bin/sample command line tool.
+
+I also moved the map(unicode, args) call into Executive.popen
+so that all callers don't have to do it themselves.
+
+The real reason for this abstraction is to make it easy
+to support both perf and pprof on linux which seem to
+be about equally popular among those I ask in the Chrome team.
+
+* Scripts/webkitpy/common/system/executive.py:
+(Executive.popen):
+* Scripts/webkitpy/common/system/profiler.py:
+(ProfilerFactory.create_profiler):
+(ProfilerFactory):
+(ProfilerFactory.available_profilers_by_name):
+(ProfilerFactory.default_profiler_name):
+(Sample):
+(Sample.__init__):
+(Sample.attach_to_pid):
+(Sample.profile_after_exit):
+(IProfiler.attach_to_pid):
+* Scripts/webkitpy/layout_tests/port/driver.py:
+(Driver.__init__):
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner._parse_args):
+
2012-12-13 Dirk Pranke
support -wk2 port names properly in webkitpy.layout_tests.port
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (137660 => 137661)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2012-12-13 23:11:14 UTC (rev 137660)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2012-12-13 23:17:17 UTC (rev 137661)
@@ -101,9 +101,6 @@
return sys.platform not in ('win32', 'cygwin')
def _run_command_with_teed_output(self, args, teed_output, **kwargs):
-args = map(unicode, args) # Popen will throw an exception if args are non-strings (like int())
-args = map(self._encode_argument_if_needed, args)
-
child_process = self.popen(args,
stdout=self.PIPE,
stderr=self.STDOUT,
@@ -390,8 +387,6 @@
"""Popen wrapper for convenience and to work around python bugs."""
assert(isinstance(args, list) or isinstance(args, tuple))
start_time = time.time()
-args = map(unicode, args) # Popen will throw an exception if args are non-strings (like int())
-args = map(self._encode_argument_if_needed, args)
stdin, string_to_communicate = self._compute_stdin(input)
stderr = self.STDOUT if return_stderr else None
@@ -458,7 +453,9 @@
return argument.encode(self._child_process_encoding())
def popen(self, *args, **kwargs):
-return subprocess.Popen(*args, **kwargs)
+string_args = map(unicode, *args) # Popen will throw an exception if args are non-strings (like int())
+string_args = map(self._encode_argument_if_needed, string_args)
+return subprocess.Popen(string_args, **kwargs)
def run_in_parallel(self, command_lines_and_cwds, processes=None):
"""Runs a list of (cmd_line list, cwd string) tuples in parallel and ret
[webkit-changes] [137660] trunk/LayoutTests
Title: [137660] trunk/LayoutTests Revision 137660 Author fmal...@chromium.org Date 2012-12-13 15:11:14 -0800 (Thu, 13 Dec 2012) Log Message [Chromium] Unreviewed rebaselining after Skia roll @6773. * platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png: * platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png: * platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png: * platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png trunk/LayoutTests/platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (137659 => 137660) --- trunk/LayoutTests/ChangeLog 2012-12-13 23:06:25 UTC (rev 137659) +++ trunk/LayoutTests/ChangeLog 2012-12-13 23:11:14 UTC (rev 137660) @@ -1,3 +1,12 @@ +2012-12-13 Florin Malita + +[Chromium] Unreviewed rebaselining after Skia roll @6773. + +* platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png: +* platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png: +* platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png: +* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: + 2012-12-13 Beth Dakin Another attempt at getting these expectations right for the bots. Modified: trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137659] trunk/LayoutTests
Title: [137659] trunk/LayoutTests Revision 137659 Author bda...@apple.com Date 2012-12-13 15:06:25 -0800 (Thu, 13 Dec 2012) Log Message Another attempt at getting these expectations right for the bots. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137658 => 137659) --- trunk/LayoutTests/ChangeLog 2012-12-13 22:58:36 UTC (rev 137658) +++ trunk/LayoutTests/ChangeLog 2012-12-13 23:06:25 UTC (rev 137659) @@ -1,5 +1,11 @@ 2012-12-13 Beth Dakin +Another attempt at getting these expectations right for the bots. + +* platform/mac/TestExpectations: + +2012-12-13 Beth Dakin + Skipping this test for now since it has been failing a lot recently. https://bugs.webkit.org/show_bug.cgi?id=104962 tracks fixing to bug. * platform/mac/TestExpectations: Modified: trunk/LayoutTests/platform/mac/TestExpectations (137658 => 137659) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 22:58:36 UTC (rev 137658) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 23:06:25 UTC (rev 137659) @@ -1244,8 +1244,8 @@ webkit.org/b/104104 fast/overflow/scrollbar-click-retains-focus.html [ Failure ] -webkit.org/b/104942 compositing/background-color/background-color-change-to-text.html [ Failure ] -webkit.org/b/104942 compositing/background-color/background-color-text-change.html [ Failure ] +webkit.org/b/104942 compositing/background-color/background-color-change-to-text.html [ ImageOnlyFailure ] +webkit.org/b/104942 compositing/background-color/background-color-text-change.html [ ImageOnlyFailure ] webkit.org/b/104949 fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137658] trunk/LayoutTests
Title: [137658] trunk/LayoutTests Revision 137658 Author bda...@apple.com Date 2012-12-13 14:58:36 -0800 (Thu, 13 Dec 2012) Log Message Skipping this test for now since it has been failing a lot recently. https://bugs.webkit.org/show_bug.cgi?id=104962 tracks fixing to bug. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137657 => 137658) --- trunk/LayoutTests/ChangeLog 2012-12-13 22:46:26 UTC (rev 137657) +++ trunk/LayoutTests/ChangeLog 2012-12-13 22:58:36 UTC (rev 137658) @@ -1,5 +1,11 @@ 2012-12-13 Beth Dakin +Skipping this test for now since it has been failing a lot recently. +https://bugs.webkit.org/show_bug.cgi?id=104962 tracks fixing to bug. +* platform/mac/TestExpectations: + +2012-12-13 Beth Dakin + Skipping this test for now since it has been failing since it was added. https://bugs.webkit.org/show_bug.cgi?id=104954 tracks fixing to bug. * platform/mac/TestExpectations: Modified: trunk/LayoutTests/platform/mac/TestExpectations (137657 => 137658) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 22:46:26 UTC (rev 137657) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 22:58:36 UTC (rev 137658) @@ -1250,3 +1250,5 @@ webkit.org/b/104949 fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html [ Failure ] webkit.org/b/104954 http/tests/canvas/canvas-slow-font-loading.html [ ImageOnlyFailure ] + +webkit.org/b/104962 platform/mac/fast/loader/file-url-mimetypes-2.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137657] trunk/Source/WebKit2
Title: [137657] trunk/Source/WebKit2
Revision 137657
Author a...@apple.com
Date 2012-12-13 14:46:26 -0800 (Thu, 13 Dec 2012)
Log Message
DOM cookie access functions should respect private browsing
https://bugs.webkit.org/show_bug.cgi?id=104691
Reviewed by Anders Carlsson.
Remove obsolete FIXMEs, and fix one function that I overlooked.
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
(WebKit::NetworkConnectionToWebProcess::getHostnamesWithCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookiesForHostname):
(WebKit::NetworkConnectionToWebProcess::deleteAllCookies):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137656 => 137657)
--- trunk/Source/WebKit2/ChangeLog 2012-12-13 22:40:31 UTC (rev 137656)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-13 22:46:26 UTC (rev 137657)
@@ -1,3 +1,23 @@
+2012-12-13 Alexey Proskuryakov
+
+ DOM cookie access functions should respect private browsing
+https://bugs.webkit.org/show_bug.cgi?id=104691
+
+Reviewed by Anders Carlsson.
+
+Remove obsolete FIXMEs, and fix one function that I overlooked.
+
+* NetworkProcess/NetworkConnectionToWebProcess.cpp:
+(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
+(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
+(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
+(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
+(WebKit::NetworkConnectionToWebProcess::getRawCookies):
+(WebKit::NetworkConnectionToWebProcess::deleteCookie):
+(WebKit::NetworkConnectionToWebProcess::getHostnamesWithCookies):
+(WebKit::NetworkConnectionToWebProcess::deleteCookiesForHostname):
+(WebKit::NetworkConnectionToWebProcess::deleteAllCookies):
+
2012-12-13 Anders Carlsson
DownloadManager shouldn't call the web process directly
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp (137656 => 137657)
--- trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp 2012-12-13 22:40:31 UTC (rev 137656)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp 2012-12-13 22:46:26 UTC (rev 137657)
@@ -167,43 +167,36 @@
void NetworkConnectionToWebProcess::cookiesForDOM(bool privateBrowsingEnabled, const KURL& firstParty, const KURL& url, String& result)
{
-// FIXME (NetworkProcess): Use a correct storage session.
result = WebCore::cookiesForDOM(networkingContext(privateBrowsingEnabled), firstParty, url);
}
void NetworkConnectionToWebProcess::setCookiesFromDOM(bool privateBrowsingEnabled, const KURL& firstParty, const KURL& url, const String& cookieString)
{
-// FIXME (NetworkProcess): Use a correct storage session.
WebCore::setCookiesFromDOM(networkingContext(privateBrowsingEnabled), firstParty, url, cookieString);
}
void NetworkConnectionToWebProcess::cookiesEnabled(bool privateBrowsingEnabled, const KURL& firstParty, const KURL& url, bool& result)
{
-// FIXME (NetworkProcess): Use a correct storage session.
result = WebCore::cookiesEnabled(networkingContext(privateBrowsingEnabled), firstParty, url);
}
void NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue(bool privateBrowsingEnabled, const KURL& firstParty, const KURL& url, String& result)
{
-// FIXME (NetworkProcess): Use a correct storage session.
-result = WebCore::cookieRequestHeaderFieldValue(0, firstParty, url);
+result = WebCore::cookieRequestHeaderFieldValue(networkingContext(privateBrowsingEnabled), firstParty, url);
}
void NetworkConnectionToWebProcess::getRawCookies(bool privateBrowsingEnabled, const KURL& firstParty, const KURL& url, Vector& result)
{
-// FIXME (NetworkProcess): Use a correct storage session.
WebCore::getRawCookies(networkingContext(privateBrowsingEnabled), firstParty, url, result);
}
void NetworkConnectionToWebProcess::deleteCookie(bool privateBrowsingEnabled, const KURL& url, const String& cookieName)
{
-// FIXME (NetworkProcess): Use a correct storage session.
WebCore::deleteCookie(networkingContext(privateBrowsingEnabled), url, cookieName);
}
void NetworkConnectionToWebProcess::getHostnamesWithCookies(bool privateBrowsingEnabled, Vector& hostnames)
{
-// FIXME (NetworkProcess): Use a correct storage session.
HashSet hostnamesSet;
WebCore::getHostname
[webkit-changes] [137656] trunk/LayoutTests
Title: [137656] trunk/LayoutTests Revision 137656 Author bda...@apple.com Date 2012-12-13 14:40:31 -0800 (Thu, 13 Dec 2012) Log Message Skipping this test for now since it has been failing since it was added. https://bugs.webkit.org/show_bug.cgi?id=104954 tracks fixing to bug. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137655 => 137656) --- trunk/LayoutTests/ChangeLog 2012-12-13 22:27:24 UTC (rev 137655) +++ trunk/LayoutTests/ChangeLog 2012-12-13 22:40:31 UTC (rev 137656) @@ -1,3 +1,9 @@ +2012-12-13 Beth Dakin + +Skipping this test for now since it has been failing since it was added. +https://bugs.webkit.org/show_bug.cgi?id=104954 tracks fixing to bug. +* platform/mac/TestExpectations: + 2012-12-13 Roger Fong Unreviewed gardening. Apple Windows port. Modified: trunk/LayoutTests/platform/mac/TestExpectations (137655 => 137656) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 22:27:24 UTC (rev 137655) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 22:40:31 UTC (rev 137656) @@ -1248,3 +1248,5 @@ webkit.org/b/104942 compositing/background-color/background-color-text-change.html [ Failure ] webkit.org/b/104949 fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html [ Failure ] + +webkit.org/b/104954 http/tests/canvas/canvas-slow-font-loading.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137655] trunk/Source/WebKit2
Title: [137655] trunk/Source/WebKit2
Revision 137655
Author ander...@apple.com
Date 2012-12-13 14:27:24 -0800 (Thu, 13 Dec 2012)
Log Message
DownloadManager shouldn't call the web process directly
https://bugs.webkit.org/show_bug.cgi?id=104946
Reviewed by Antti Koivisto.
Introduce the needed DownloadManager::Client member functions and have Download call them instead of calling the web process directly.
* WebProcess/Downloads/Download.cpp:
(WebKit::Download::Download):
(WebKit::Download::~Download):
(WebKit::Download::connection):
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::DownloadManager):
(WebKit::DownloadManager::didCreateDownload):
(WebKit::DownloadManager::didDestroyDownload):
(WebKit::DownloadManager::connection):
* WebProcess/Downloads/DownloadManager.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didCreateDownload):
(WebKit::WebProcess::didDestroyDownload):
* WebProcess/WebProcess.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp
trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp
trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.h
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137654 => 137655)
--- trunk/Source/WebKit2/ChangeLog 2012-12-13 22:25:43 UTC (rev 137654)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-13 22:27:24 UTC (rev 137655)
@@ -1,3 +1,27 @@
+2012-12-13 Anders Carlsson
+
+DownloadManager shouldn't call the web process directly
+https://bugs.webkit.org/show_bug.cgi?id=104946
+
+Reviewed by Antti Koivisto.
+
+Introduce the needed DownloadManager::Client member functions and have Download call them instead of calling the web process directly.
+
+* WebProcess/Downloads/Download.cpp:
+(WebKit::Download::Download):
+(WebKit::Download::~Download):
+(WebKit::Download::connection):
+* WebProcess/Downloads/DownloadManager.cpp:
+(WebKit::DownloadManager::DownloadManager):
+(WebKit::DownloadManager::didCreateDownload):
+(WebKit::DownloadManager::didDestroyDownload):
+(WebKit::DownloadManager::connection):
+* WebProcess/Downloads/DownloadManager.h:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::didCreateDownload):
+(WebKit::WebProcess::didDestroyDownload):
+* WebProcess/WebProcess.h:
+
2012-12-13 Alexey Proskuryakov
Per-Tab WebProcess: DOM cookie access functions should respect private browsing
Modified: trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp (137654 => 137655)
--- trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp 2012-12-13 22:25:43 UTC (rev 137654)
+++ trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp 2012-12-13 22:27:24 UTC (rev 137655)
@@ -34,7 +34,6 @@
#include "DownloadManager.h"
#include "SandboxExtension.h"
#include "WebCoreArgumentCoders.h"
-#include "WebProcess.h"
using namespace WebCore;
@@ -57,19 +56,19 @@
{
ASSERT(m_downloadID);
-WebProcess::shared().disableTermination();
+m_downloadManager.didCreateDownload();
}
Download::~Download()
{
platformInvalidate();
-WebProcess::shared().enableTermination();
+m_downloadManager.didDestroyDownload();
}
CoreIPC::Connection* Download::connection() const
{
-return WebProcess::shared().connection();
+return m_downloadManager.connection();
}
void Download::didStart()
Modified: trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp (137654 => 137655)
--- trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp 2012-12-13 22:25:43 UTC (rev 137654)
+++ trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp 2012-12-13 22:27:24 UTC (rev 137655)
@@ -27,7 +27,6 @@
#include "DownloadManager.h"
#include "Download.h"
-#include "WebProcess.h"
#include
using namespace WebCore;
@@ -37,8 +36,6 @@
DownloadManager::DownloadManager(Client* client)
: m_client(client)
{
-// FIXME: Actually use the client for something.
-(void)m_client;
}
void DownloadManager::startDownload(uint64_t downloadID, const ResourceRequest& request)
@@ -76,6 +73,21 @@
delete download;
}
+void DownloadManager::didCreateDownload()
+{
+m_client->didCreateDownload();
+}
+
+void DownloadManager::didDestroyDownload()
+{
+m_client->didDestroyDownload();
+}
+
+CoreIPC::Connection* DownloadManager::connection()
+{
+return m_client->connection();
+}
+
#if PLATFORM(QT)
void DownloadManager::startTransfer(uint64_t downloadID, const String& destination)
{
Modified: trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.h (137654 => 137655)
--- trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.h 2012-12-13 22:25:43 UTC (rev 137654)
+++ trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.h 2012-12-13 22:27:24 UTC (rev 137655)
@@ -26,17 +26,18 @@
#ifn
[webkit-changes] [137653] trunk
Title: [137653] trunk
Revision 137653
Author pi...@chromium.org
Date 2012-12-13 14:16:28 -0800 (Thu, 13 Dec 2012)
Log Message
[chromium] Add WebPluginContainer::setWebLayer to supersede setBackingTextureId/setBackingIOSurfaceId
https://bugs.webkit.org/show_bug.cgi?id=104875
Reviewed by James Robinson.
* public/WebPluginContainer.h:
(WebKit):
(WebPluginContainer):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setWebLayer):
(WebKit):
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
(WebKit::WebPluginContainerImpl::~WebPluginContainerImpl):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebPluginContainer.h
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (137652 => 137653)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-13 22:07:04 UTC (rev 137652)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-13 22:16:28 UTC (rev 137653)
@@ -1,3 +1,26 @@
+2012-12-13 Antoine Labour
+
+[chromium] Add WebPluginContainer::setWebLayer to supersede setBackingTextureId/setBackingIOSurfaceId
+https://bugs.webkit.org/show_bug.cgi?id=104875
+
+Reviewed by James Robinson.
+
+* public/WebPluginContainer.h:
+(WebKit):
+(WebPluginContainer):
+* src/WebPluginContainerImpl.cpp:
+(WebKit::WebPluginContainerImpl::setWebLayer):
+(WebKit):
+(WebKit::WebPluginContainerImpl::setBackingTextureId):
+(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
+(WebKit::WebPluginContainerImpl::commitBackingTexture):
+(WebKit::WebPluginContainerImpl::setOpaque):
+(WebKit::WebPluginContainerImpl::platformLayer):
+(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
+(WebKit::WebPluginContainerImpl::~WebPluginContainerImpl):
+* src/WebPluginContainerImpl.h:
+(WebPluginContainerImpl):
+
2012-12-13 Yusuf Ozuysal
Check whether a touchDown lands on a registered touch event handler from the compositor
Modified: trunk/Source/WebKit/chromium/public/WebPluginContainer.h (137652 => 137653)
--- trunk/Source/WebKit/chromium/public/WebPluginContainer.h 2012-12-13 22:07:04 UTC (rev 137652)
+++ trunk/Source/WebKit/chromium/public/WebPluginContainer.h 2012-12-13 22:16:28 UTC (rev 137653)
@@ -42,6 +42,7 @@
class WebString;
class WebURL;
class WebURLRequest;
+class WebLayer;
struct WebPoint;
struct WebRect;
@@ -136,6 +137,10 @@
virtual float pageScaleFactor() = 0;
virtual float pageZoomFactor() = 0;
+// Sets the layer representing the plugin for compositing. The
+// WebPluginContainer does *not* take ownership.
+virtual void setWebLayer(WebLayer*) = 0;
+
protected:
~WebPluginContainer() { }
};
Modified: trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (137652 => 137653)
--- trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-12-13 22:07:04 UTC (rev 137652)
+++ trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-12-13 22:16:28 UTC (rev 137653)
@@ -284,6 +284,23 @@
return frame->pageZoomFactor();
}
+void WebPluginContainerImpl::setWebLayer(WebLayer* layer)
+{
+if (m_webLayer == layer)
+return;
+
+// If anyone of the layers is null we need to switch between hardware
+// and software compositing. This is done by triggering a style recalc
+// on the container element.
+if (!m_webLayer || !layer)
+m_element->setNeedsStyleRecalc(WebCore::SyntheticStyleChange);
+if (m_webLayer)
+GraphicsLayerChromium::unregisterContentsLayer(m_webLayer);
+if (layer)
+GraphicsLayerChromium::registerContentsLayer(layer);
+m_webLayer = layer;
+}
+
bool WebPluginContainerImpl::supportsPaginatedPrint() const
{
return m_webPlugin->supportsPaginatedPrint();
@@ -381,19 +398,12 @@
ASSERT(!m_ioSurfaceLayer);
-if (!m_textureLayer) {
+if (!m_textureLayer)
m_textureLayer = adoptPtr(Platform::current()->compositorSupport()->createExternalTextureLayer());
-GraphicsLayerChromium::registerContentsLayer(m_textureLayer->layer());
-}
m_textureLayer->setTextureId(textureId);
-
-// If anyone of the IDs is zero we need to switch between hardware
-// and software compositing. This is done by triggering a style recalc
-// on the container element.
-if (!m_textureId || !textureId)
-m_element->setNeedsStyleRecalc(WebCore::SyntheticStyl
[webkit-changes] [137652] trunk/LayoutTests
Title: [137652] trunk/LayoutTests Revision 137652 Author bda...@apple.com Date 2012-12-13 14:07:04 -0800 (Thu, 13 Dec 2012) Log Message This test has been failing on the Mac bots for a while. https://bugs.webkit.org/show_bug.cgi?id=104949 * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137651 => 137652) --- trunk/LayoutTests/ChangeLog 2012-12-13 22:06:21 UTC (rev 137651) +++ trunk/LayoutTests/ChangeLog 2012-12-13 22:07:04 UTC (rev 137652) @@ -1,5 +1,12 @@ 2012-12-13 Beth Dakin +This test has been failing on the Mac bots for a while. +https://bugs.webkit.org/show_bug.cgi?id=104949 + +* platform/mac/TestExpectations: + +2012-12-13 Beth Dakin + Fixing a copy-paste error. * platform/mac/TestExpectations: Modified: trunk/LayoutTests/platform/mac/TestExpectations (137651 => 137652) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 22:06:21 UTC (rev 137651) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 22:07:04 UTC (rev 137652) @@ -1246,3 +1246,5 @@ webkit.org/b/104942 compositing/background-color/background-color-change-to-text.html [ Failure ] webkit.org/b/104942 compositing/background-color/background-color-text-change.html [ Failure ] + +webkit.org/b/104949 fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137651] branches/safari-536.28-branch/Source
Title: [137651] branches/safari-536.28-branch/Source Revision 137651 Author lforsch...@apple.com Date 2012-12-13 14:06:21 -0800 (Thu, 13 Dec 2012) Log Message Versioning. Modified Paths branches/safari-536.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-536.28-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-536.28-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-536.28-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-536.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig (137650 => 137651) --- branches/safari-536.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-12-13 21:53:06 UTC (rev 137650) +++ branches/safari-536.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-12-13 22:06:21 UTC (rev 137651) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 28; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-536.28-branch/Source/WebCore/Configurations/Version.xcconfig (137650 => 137651) --- branches/safari-536.28-branch/Source/WebCore/Configurations/Version.xcconfig 2012-12-13 21:53:06 UTC (rev 137650) +++ branches/safari-536.28-branch/Source/WebCore/Configurations/Version.xcconfig 2012-12-13 22:06:21 UTC (rev 137651) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 28; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-536.28-branch/Source/WebKit/mac/Configurations/Version.xcconfig (137650 => 137651) --- branches/safari-536.28-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-12-13 21:53:06 UTC (rev 137650) +++ branches/safari-536.28-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-12-13 22:06:21 UTC (rev 137651) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 28; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-536.28-branch/Source/WebKit2/Configurations/Version.xcconfig (137650 => 137651) --- branches/safari-536.28-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-12-13 21:53:06 UTC (rev 137650) +++ branches/safari-536.28-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-12-13 22:06:21 UTC (rev 137651) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 28; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137650] trunk/Tools
Title: [137650] trunk/Tools Revision 137650 Author dpra...@chromium.org Date 2012-12-13 13:53:06 -0800 (Thu, 13 Dec 2012) Log Message support -wk2 port names properly in webkitpy.layout_tests.port https://bugs.webkit.org/show_bug.cgi?id=104761 Reviewed by Eric Seidel. Our support for WK2 port names was inconsistent at best; this patch modifies the code so that -wk2 is supported for all ports that have WK2 implementations and is equivalent to specifying and -2/--webkit-test-runner. In addition, this modifies builders.all_port_names() to include the wk2 variants. * Scripts/webkitpy/common/checkout/baselineoptimizer.py: * Scripts/webkitpy/layout_tests/port/apple.py: (ApplePort.determine_full_port_name): * Scripts/webkitpy/layout_tests/port/base.py: (Port.determine_full_port_name): (Port.__init__): * Scripts/webkitpy/layout_tests/port/builders.py: * Scripts/webkitpy/layout_tests/port/driver_unittest.py: (DriverTest.make_port): * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.default_baseline_search_path): * Scripts/webkitpy/layout_tests/port/win.py: (WinPort.default_baseline_search_path): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (TestRebaselineExpectations.test_rebaseline_expectations): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py trunk/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py Diff Modified: trunk/Tools/ChangeLog (137649 => 137650) --- trunk/Tools/ChangeLog 2012-12-13 21:50:52 UTC (rev 137649) +++ trunk/Tools/ChangeLog 2012-12-13 21:53:06 UTC (rev 137650) @@ -1,3 +1,32 @@ +2012-12-13 Dirk Pranke + +support -wk2 port names properly in webkitpy.layout_tests.port +https://bugs.webkit.org/show_bug.cgi?id=104761 + +Reviewed by Eric Seidel. + +Our support for WK2 port names was inconsistent at best; this patch +modifies the code so that -wk2 is supported for all ports that +have WK2 implementations and is equivalent to specifying +and -2/--webkit-test-runner. In addition, this modifies +builders.all_port_names() to include the wk2 variants. + +* Scripts/webkitpy/common/checkout/baselineoptimizer.py: +* Scripts/webkitpy/layout_tests/port/apple.py: +(ApplePort.determine_full_port_name): +* Scripts/webkitpy/layout_tests/port/base.py: +(Port.determine_full_port_name): +(Port.__init__): +* Scripts/webkitpy/layout_tests/port/builders.py: +* Scripts/webkitpy/layout_tests/port/driver_unittest.py: +(DriverTest.make_port): +* Scripts/webkitpy/layout_tests/port/mac.py: +(MacPort.default_baseline_search_path): +* Scripts/webkitpy/layout_tests/port/win.py: +(WinPort.default_baseline_search_path): +* Scripts/webkitpy/tool/commands/rebaseline_unittest.py: +(TestRebaselineExpectations.test_rebaseline_expectations): + 2012-12-13 Ian Vollick [chromium] Add a virtual test suite for enabling opt-in to composited scrolling Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py (137649 => 137650) --- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py 2012-12-13 21:50:52 UTC (rev 137649) +++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py 2012-12-13 21:53:06 UTC (rev 137650) @@ -60,10 +60,6 @@ 'mac-future': ['LayoutTests/platform/mac-future', 'LayoutTests/platform/mac', 'LayoutTests'], 'win-future': ['LayoutTests/platform/win-future', 'LayoutTests/platform/win', 'LayoutTests'], 'qt-unknown': ['LayoutTests/platform/qt-unknown', 'LayoutTests/platform/qt', 'LayoutTests'], - -# FIXME: Account for the efl-wk2 port which isn't returned in builders.all_port_names(). -# See https://bugs.webkit.org/show_bug.cgi?id=104761. -'efl-wk2': ['LayoutTests/platform/efl-wk2', 'LayoutTests/platform/efl', 'LayoutTests'], } Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py (137649 => 137650) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py 2012-12-13 21:50:52 UTC (rev 137649) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py 2012-12-13 21:53:06 UTC (rev 137650) @@ -55,17 +55,21 @@ @classmethod def determine_full_port_name(cls, host, options, port_name): -# If the port_name matches the (badly named) cls.port_name, that -# means that they passed 'mac' or 'win' and didn't specify a version. -# That convention means that we're supposed to use the version currently -# being run, so this won't work if you're not on mac or win (respectively).
[webkit-changes] [137649] trunk/LayoutTests
Title: [137649] trunk/LayoutTests Revision 137649 Author bda...@apple.com Date 2012-12-13 13:50:52 -0800 (Thu, 13 Dec 2012) Log Message Fixing a copy-paste error. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137648 => 137649) --- trunk/LayoutTests/ChangeLog 2012-12-13 21:49:10 UTC (rev 137648) +++ trunk/LayoutTests/ChangeLog 2012-12-13 21:50:52 UTC (rev 137649) @@ -1,5 +1,11 @@ 2012-12-13 Beth Dakin +Fixing a copy-paste error. + +* platform/mac/TestExpectations: + +2012-12-13 Beth Dakin + Marking these tests as failing since they are failing on the bots. https://bugs.webkit.org/show_bug.cgi?id=104942 tracks fixing the actual bug. Modified: trunk/LayoutTests/platform/mac/TestExpectations (137648 => 137649) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 21:49:10 UTC (rev 137648) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 21:50:52 UTC (rev 137649) @@ -1243,7 +1243,6 @@ webkit.org/b/103663 [ MountainLion Lion SnowLeopard ] media/track/track-in-band.html webkit.org/b/104104 fast/overflow/scrollbar-click-retains-focus.html [ Failure ] -background-color-text-change.html webkit.org/b/104942 compositing/background-color/background-color-change-to-text.html [ Failure ] webkit.org/b/104942 compositing/background-color/background-color-text-change.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137648] trunk/LayoutTests
Title: [137648] trunk/LayoutTests Revision 137648 Author bda...@apple.com Date 2012-12-13 13:49:10 -0800 (Thu, 13 Dec 2012) Log Message Marking these tests as failing since they are failing on the bots. https://bugs.webkit.org/show_bug.cgi?id=104942 tracks fixing the actual bug. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137647 => 137648) --- trunk/LayoutTests/ChangeLog 2012-12-13 21:48:03 UTC (rev 137647) +++ trunk/LayoutTests/ChangeLog 2012-12-13 21:49:10 UTC (rev 137648) @@ -1,3 +1,10 @@ +2012-12-13 Beth Dakin + +Marking these tests as failing since they are failing on the bots. +https://bugs.webkit.org/show_bug.cgi?id=104942 tracks fixing the actual bug. + +* platform/mac/TestExpectations: + 2012-12-13 Ian Vollick Automatically use composited scrolling Modified: trunk/LayoutTests/platform/mac/TestExpectations (137647 => 137648) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 21:48:03 UTC (rev 137647) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-13 21:49:10 UTC (rev 137648) @@ -1243,3 +1243,7 @@ webkit.org/b/103663 [ MountainLion Lion SnowLeopard ] media/track/track-in-band.html webkit.org/b/104104 fast/overflow/scrollbar-click-retains-focus.html [ Failure ] +background-color-text-change.html + +webkit.org/b/104942 compositing/background-color/background-color-change-to-text.html [ Failure ] +webkit.org/b/104942 compositing/background-color/background-color-text-change.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137647] trunk/Source
Title: [137647] trunk/Source
Revision 137647
Author a...@apple.com
Date 2012-12-13 13:48:03 -0800 (Thu, 13 Dec 2012)
Log Message
Per-Tab WebProcess: DOM cookie access functions should respect private browsing
https://bugs.webkit.org/show_bug.cgi?id=104691
Reviewed by Sam Weinig.
Pass private browsing state from local context to remote one.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/NetworkingContext.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebFrameNetworkingContext.cpp
trunk/Source/WebKit/win/WebCoreSupport/WebFrameNetworkingContext.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.messages.in
trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.h
trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm
trunk/Source/WebKit2/WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (137646 => 137647)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 21:37:25 UTC (rev 137646)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 21:48:03 UTC (rev 137647)
@@ -178,6 +178,17 @@
2012-12-13 Alexey Proskuryakov
+ Per-Tab WebProcess: DOM cookie access functions should respect private browsing
+https://bugs.webkit.org/show_bug.cgi?id=104691
+
+Reviewed by Sam Weinig.
+
+* platform/network/NetworkingContext.h: Added a function that returns current
+context type. Ideally, we would track contexts across processes in a generic manner,
+but we only have two now, and don't need such complications.
+
+2012-12-13 Alexey Proskuryakov
+
ResourceLoader::didReceiveAuthenticationChallenge uses a wrong client
https://bugs.webkit.org/show_bug.cgi?id=104935
Modified: trunk/Source/WebCore/platform/network/NetworkingContext.h (137646 => 137647)
--- trunk/Source/WebCore/platform/network/NetworkingContext.h 2012-12-13 21:37:25 UTC (rev 137646)
+++ trunk/Source/WebCore/platform/network/NetworkingContext.h 2012-12-13 21:48:03 UTC (rev 137647)
@@ -80,6 +80,7 @@
#endif
#if PLATFORM(MAC) || USE(CFNETWORK)
+virtual bool inPrivateBrowsingMode() const = 0;
virtual CFURLStorageSessionRef storageSession() const = 0;
#endif
Modified: trunk/Source/WebKit/mac/ChangeLog (137646 => 137647)
--- trunk/Source/WebKit/mac/ChangeLog 2012-12-13 21:37:25 UTC (rev 137646)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-12-13 21:48:03 UTC (rev 137647)
@@ -1,3 +1,16 @@
+2012-12-13 Alexey Proskuryakov
+
+ Per-Tab WebProcess: DOM cookie access functions should respect private browsing
+https://bugs.webkit.org/show_bug.cgi?id=104691
+
+Reviewed by Sam Weinig.
+
+* WebCoreSupport/WebFrameNetworkingContext.h:
+* WebCoreSupport/WebFrameNetworkingContext.mm:
+(WebFrameNetworkingContext::inPrivateBrowsingMode):
+(WebFrameNetworkingContext::storageSession):
+Implemented inPrivateBrowsingMode().
+
2012-12-12 Mark Lam
Encapsulate externally used webdatabase APIs in DatabaseManager.
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h (137646 => 137647)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h 2012-12-13 21:37:25 UTC (rev 137646)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h 2012-12-13 21:48:03 UTC (rev 137647)
@@ -43,6 +43,7 @@
virtual bool needsSiteSpecificQuirks() const OVERRIDE;
virtual bool localFileContentSniffingEnabled() const OVERRIDE;
+virtual bool inPrivateBrowsingMode() const OVERRIDE;
virtual CFURLStorageSessionRef storageSession() const OVERRIDE;
virtual WebCore::SchedulePairHashSet* scheduledRunLoopPairs() const OVERRIDE;
virtual WebCore::ResourceError blockedError(const WebCore::ResourceRequest&) const OVERRIDE;
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm (137646 => 137647)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm 2012-12-13 21:37:25 UTC (rev 137646)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm 2012-12-13 21:48:03 UTC (rev 137647)
@@ -97,10 +97,14 @@
return defaultCFStorageSession;
}
+bool WebFrameNetworkingContext::inPrivateBrowsingMode() const
+{
+return frame() && frame()->settings() && frame()->sett
[webkit-changes] [137645] trunk
Title: [137645] trunk Revision 137645 Author voll...@chromium.org Date 2012-12-13 13:25:00 -0800 (Thu, 13 Dec 2012) Log Message [chromium] Add a virtual test suite for enabling opt-in to composited scrolling https://bugs.webkit.org/show_bug.cgi?id=104911 Reviewed by Adrienne Walker. Tools: Adds two virtual tests suites to run the tests in compositing/overflow/ and scrollbars/ with the flag --enable-accelerated-compositing-for-overflow-scroll * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort.virtual_test_suites): LayoutTests: Updated the test expectations for the virtual test suite to match the usual chromium test expectations. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py Diff Modified: trunk/LayoutTests/ChangeLog (137644 => 137645) --- trunk/LayoutTests/ChangeLog 2012-12-13 21:18:19 UTC (rev 137644) +++ trunk/LayoutTests/ChangeLog 2012-12-13 21:25:00 UTC (rev 137645) @@ -1,3 +1,15 @@ +2012-12-13 Ian Vollick + +[chromium] Add a virtual test suite for enabling opt-in to composited scrolling +https://bugs.webkit.org/show_bug.cgi?id=104911 + +Reviewed by Adrienne Walker. + +Updated the test expectations for the virtual test suite to match the +usual chromium test expectations. + +* platform/chromium/TestExpectations: + 2012-12-13 Beth Dakin This test started failing after http://trac.webkit.org/changeset/137592 which Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137644 => 137645) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-13 21:18:19 UTC (rev 137644) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-13 21:25:00 UTC (rev 137645) @@ -3625,8 +3625,11 @@ webkit.org/b/85856 [ Win Mac Android ] fast/block/float/026.html [ ImageOnlyFailure ] webkit.org/b/85856 [ Win Mac Android ] fast/overflow/unreachable-overflow-rtl-bug.html [ Failure ImageOnlyFailure ] webkit.org/b/85856 [ Linux Win SnowLeopard ] scrollbars/rtl/div-absolute.html [ Failure ] +webkit.org/b/85856 [ Linux Win SnowLeopard ] platform/chromium/virtual/gpu/compositedscrolling/scrollbars/rtl/div-absolute.html [ Failure ] webkit.org/b/85856 [ Lion MountainLion ] scrollbars/rtl/div-absolute.html [ Failure Pass ] +webkit.org/b/85856 [ Lion MountainLion ] platform/chromium/virtual/gpu/compositedscrolling/scrollbars/rtl/div-absolute.html [ Failure Pass ] webkit.org/b/85856 scrollbars/rtl/div-horizontal.html [ Failure ] +webkit.org/b/85856 platform/chromium/virtual/gpu/compositedscrolling/scrollbars/rtl/div-horizontal.html [ Failure ] # Bug 93148 changed this to a testRunner test and it started timing out on Mac. webkit.org/b/93148 [ Mac ] fast/css/nested-layers-with-hover.html [ Timeout ] @@ -3692,20 +3695,26 @@ # ENABLE_ACCELERATED_OVERFLOW_SCROLLING is not currently enabled in Chromium. webkit.org/b/94353 compositing/overflow/scrolling-content-clip-to-viewport.html [ Failure ] webkit.org/b/94353 platform/chromium/virtual/softwarecompositing/overflow/scrolling-content-clip-to-viewport.html [ Failure ] +webkit.org/b/94353 platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-content-clip-to-viewport.html [ Failure ] webkit.org/b/94353 compositing/overflow/scrolling-without-painting.html [ Failure ] webkit.org/b/94353 platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting.html [ Failure ] +webkit.org/b/94353 platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting.html [ Failure ] webkit.org/b/94353 compositing/overflow/updating-scrolling-content.html [ Failure ] webkit.org/b/94353 platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content.html [ Failure ] +webkit.org/b/94353 platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content.html [ Failure ] webkit.org/b/94353 compositing/overflow/textarea-scroll-touch.html [ Failure ] webkit.org/b/94353 platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch.html [ Failure ] +webkit.org/b/94353 platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch.html [ Failure ] # Failing on Linux (Content Shell) only now webkit.org/b/94353 [ Android Linux ] compositing/overflow/nested-scrolling.html [ Failure Pass ] webkit.org/b/94353 [ Android Linux ] platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling.html [ Failure Pass ] webkit.org/b/94353 compositing/overflow/overflow-auto-with-touch.html [ Failure ] webkit.org/b/94353 platform/chromium/virtual/softwarecompositing/overflow/overflow-auto-with-touch.html [ Failure ] +webkit.org/b/94353 platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch.html [ Failure ] webkit.org/b/94353 compositing/overflow/overflow-overlay-
[webkit-changes] [137644] tags/Safari-537.21/Source/WebCore
Title: [137644] tags/Safari-537.21/Source/WebCore
Revision 137644
Author lforsch...@apple.com
Date 2012-12-13 13:18:19 -0800 (Thu, 13 Dec 2012)
Log Message
Merged r137573.
Modified Paths
tags/Safari-537.21/Source/WebCore/ChangeLog
tags/Safari-537.21/Source/WebCore/loader/FrameLoader.cpp
tags/Safari-537.21/Source/WebCore/platform/KURL.cpp
tags/Safari-537.21/Source/WebCore/platform/KURL.h
tags/Safari-537.21/Source/WebCore/plugins/PlugInOriginHash.cpp
Diff
Modified: tags/Safari-537.21/Source/WebCore/ChangeLog (137643 => 137644)
--- tags/Safari-537.21/Source/WebCore/ChangeLog 2012-12-13 21:18:01 UTC (rev 137643)
+++ tags/Safari-537.21/Source/WebCore/ChangeLog 2012-12-13 21:18:19 UTC (rev 137644)
@@ -1,5 +1,31 @@
2012-12-13 Lucas Forschler
+Merge r137573
+
+2012-12-12 Jon Lee
+
+Crash in PlugInOriginHash with empty MIME type (104882)
+https://bugs.webkit.org/show_bug.cgi?id=104882
+
+
+Reviewed by Filip Pizlo.
+
+The crash occurs because the strings might be null. Add a check for it, but also try to infer a MIME type
+in case the markup does not include a type attribute, but we can find it from the extension in the URL.
+
+* platform/KURL.cpp: Add a new function mimeTypeFromURL() which tries to return the implied MIME type
+based on the URL provided. If nothing was found, return a null string.
+(WebCore::mimeTypeFromURL): Factored out from FrameLoader::defaultObjectContentType().
+* platform/KURL.h:
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::defaultObjectContentType): Refactor to use mimeTypeFromURL().
+* plugins/PlugInOriginHash.cpp:
+(WebCore::addCaseFoldedCharacters): Add a check for an empty string.
+(WebCore::PlugInOriginHash::hash): If the service type is empty, try to infer the MIME type.
+
+2012-12-13 Lucas Forschler
+
Merge r137607
2012-12-13 Nate Chapin
Modified: tags/Safari-537.21/Source/WebCore/loader/FrameLoader.cpp (137643 => 137644)
--- tags/Safari-537.21/Source/WebCore/loader/FrameLoader.cpp 2012-12-13 21:18:01 UTC (rev 137643)
+++ tags/Safari-537.21/Source/WebCore/loader/FrameLoader.cpp 2012-12-13 21:18:19 UTC (rev 137644)
@@ -884,16 +884,15 @@
ObjectContentType FrameLoader::defaultObjectContentType(const KURL& url, const String& mimeTypeIn, bool shouldPreferPlugInsForImages)
{
String mimeType = mimeTypeIn;
-String decodedPath = decodeURLEscapeSequences(url.path());
-String extension = decodedPath.substring(decodedPath.reverseFind('.') + 1);
-// We don't use MIMETypeRegistry::getMIMETypeForPath() because it returns "application/octet-stream" upon failure
if (mimeType.isEmpty())
-mimeType = MIMETypeRegistry::getMIMETypeForExtension(extension);
+mimeType = mimeTypeFromURL(url);
#if !PLATFORM(MAC) && !PLATFORM(CHROMIUM) && !PLATFORM(EFL) // Mac has no PluginDatabase, nor does Chromium or EFL
-if (mimeType.isEmpty())
-mimeType = PluginDatabase::installedPlugins()->MIMETypeForExtension(extension);
+if (mimeType.isEmpty()) {
+String decodedPath = decodeURLEscapeSequences(url.path());
+mimeType = PluginDatabase::installedPlugins()->MIMETypeForExtension(decodedPath.substring(decodedPath.reverseFind('.') + 1));
+}
#endif
if (mimeType.isEmpty())
Modified: tags/Safari-537.21/Source/WebCore/platform/KURL.cpp (137643 => 137644)
--- tags/Safari-537.21/Source/WebCore/platform/KURL.cpp 2012-12-13 21:18:01 UTC (rev 137643)
+++ tags/Safari-537.21/Source/WebCore/platform/KURL.cpp 2012-12-13 21:18:19 UTC (rev 137644)
@@ -28,6 +28,7 @@
#include "KURL.h"
#include "DecodeEscapeSequences.h"
+#include "MIMETypeRegistry.h"
#include "PlatformMemoryInstrumentation.h"
#include "TextEncoding.h"
#include
@@ -1918,6 +1919,15 @@
return "";
}
+String mimeTypeFromURL(const KURL& url)
+{
+String decodedPath = decodeURLEscapeSequences(url.path());
+String extension = decodedPath.substring(decodedPath.reverseFind('.') + 1);
+
+// We don't use MIMETypeRegistry::getMIMETypeForPath() because it returns "application/octet-stream" upon failure
+return MIMETypeRegistry::getMIMETypeForExtension(extension);
+}
+
void KURL::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{
MemoryClassInfo info(memoryObjectInfo, this);
Modified: tags/Safari-537.21/Source/WebCore/platform/KURL.h (137643 => 137644)
--- tags/Safari-537.21/Source/WebCore/platform/KURL.h 2012-12-13 21:18:01 UTC (rev 137643)
+++ tags/Safari-537.21/Source/WebCore/platform/KURL.h 2012-12-13 21:18:19 UTC (rev 137644)
@@ -290,6 +290,7 @@
bool isValidProtocol(const String&);
String mimeTypeFromDataURL(const String& url);
+String mimeTypeFromURL(const KURL&);
// Unescapes the given string using URL escaping rules, given an optional
// encoding (defaulting to UTF-8 otherwise). DANGER:
[webkit-changes] [137643] trunk/Tools
Title: [137643] trunk/Tools Revision 137643 Author dpra...@chromium.org Date 2012-12-13 13:18:01 -0800 (Thu, 13 Dec 2012) Log Message delete extraneous self.fail in mastercfg_unittest.py https://bugs.webkit.org/show_bug.cgi?id=104940 Reviewed by Eric Seidel. This was accidentally introduced in r137404. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py (137642 => 137643) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py 2012-12-13 20:56:56 UTC (rev 137642) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py 2012-12-13 21:18:01 UTC (rev 137643) @@ -61,7 +61,6 @@ '1 unique leaks found!', ] run_webkit_tests._parseNewRunWebKitTestsOutput(log_text) -self.fail() self.assertEqual(run_webkit_tests.incorrectLayoutLines, expected_incorrect_lines) def test_nrwt_missing_results(self): Modified: trunk/Tools/ChangeLog (137642 => 137643) --- trunk/Tools/ChangeLog 2012-12-13 20:56:56 UTC (rev 137642) +++ trunk/Tools/ChangeLog 2012-12-13 21:18:01 UTC (rev 137643) @@ -1,5 +1,16 @@ 2012-12-13 Dirk Pranke +delete extraneous self.fail in mastercfg_unittest.py +https://bugs.webkit.org/show_bug.cgi?id=104940 + +Reviewed by Eric Seidel. + +This was accidentally introduced in r137404. + +* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: + +2012-12-13 Dirk Pranke + Fix a mis-named variable after r137621. https://bugs.webkit.org/show_bug.cgi?id=104871 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137642] trunk/Source/WebCore
Title: [137642] trunk/Source/WebCore
Revision 137642
Author rn...@webkit.org
Date 2012-12-13 12:56:56 -0800 (Thu, 13 Dec 2012)
Log Message
REGRESSION(r137406): NodeTraversal changes causing large renderer crash
https://bugs.webkit.org/show_bug.cgi?id=104937
Reviewed by Antti Koivisto.
Add a null pointer check to exit early since ElementTraversal::next assumes a non-null pointer.
No new tests since I don't think this function is ever exposed to any ES5 bindings.
* editing/FrameSelection.cpp:
(WebCore::scanForForm):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (137641 => 137642)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 20:54:57 UTC (rev 137641)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 20:56:56 UTC (rev 137642)
@@ -1,3 +1,17 @@
+2012-12-13 Ryosuke Niwa
+
+REGRESSION(r137406): NodeTraversal changes causing large renderer crash
+https://bugs.webkit.org/show_bug.cgi?id=104937
+
+Reviewed by Antti Koivisto.
+
+Add a null pointer check to exit early since ElementTraversal::next assumes a non-null pointer.
+
+No new tests since I don't think this function is ever exposed to any ES5 bindings.
+
+* editing/FrameSelection.cpp:
+(WebCore::scanForForm):
+
2012-12-13 David Grogan
IndexedDB: Improve error messages
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (137641 => 137642)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2012-12-13 20:54:57 UTC (rev 137641)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2012-12-13 20:56:56 UTC (rev 137642)
@@ -1953,7 +1953,9 @@
// Scans logically forward from "start", including any child frames.
static HTMLFormElement* scanForForm(Node* start)
{
-Element* element = start && start->isElementNode() ? toElement(start) : ElementTraversal::next(start);
+if (!start)
+return 0;
+Element* element = start->isElementNode() ? toElement(start) : ElementTraversal::next(start);
for (; element; element = ElementTraversal::next(element)) {
if (element->hasTagName(formTag))
return static_cast(element);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137640] trunk/Source/WebKit2
Title: [137640] trunk/Source/WebKit2
Revision 137640
Author ander...@apple.com
Date 2012-12-13 12:53:03 -0800 (Thu, 13 Dec 2012)
Log Message
Get rid of DownloadManager::shared
https://bugs.webkit.org/show_bug.cgi?id=104939
Reviewed by Andreas Kling.
Move the DownloadManager singleton to WebProcess and stub out a DownloadManager::Client class.
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::DownloadManager):
* WebProcess/Downloads/DownloadManager.h:
(Client):
(WebKit::DownloadManager::Client::~Client):
(DownloadManager):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::startDownload):
(WebKit::WebFrame::convertHandleToDownload):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::downloadManager):
(WebKit):
(WebKit::WebProcess::shouldTerminate):
(WebKit::WebProcess::downloadRequest):
(WebKit::WebProcess::cancelDownload):
(WebKit::WebProcess::startTransfer):
* WebProcess/WebProcess.h:
(WebProcess):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp
trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.h
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137639 => 137640)
--- trunk/Source/WebKit2/ChangeLog 2012-12-13 20:50:32 UTC (rev 137639)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-13 20:53:03 UTC (rev 137640)
@@ -1,3 +1,31 @@
+2012-12-13 Anders Carlsson
+
+Get rid of DownloadManager::shared
+https://bugs.webkit.org/show_bug.cgi?id=104939
+
+Reviewed by Andreas Kling.
+
+Move the DownloadManager singleton to WebProcess and stub out a DownloadManager::Client class.
+
+* WebProcess/Downloads/DownloadManager.cpp:
+(WebKit::DownloadManager::DownloadManager):
+* WebProcess/Downloads/DownloadManager.h:
+(Client):
+(WebKit::DownloadManager::Client::~Client):
+(DownloadManager):
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::startDownload):
+(WebKit::WebFrame::convertHandleToDownload):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::downloadManager):
+(WebKit):
+(WebKit::WebProcess::shouldTerminate):
+(WebKit::WebProcess::downloadRequest):
+(WebKit::WebProcess::cancelDownload):
+(WebKit::WebProcess::startTransfer):
+* WebProcess/WebProcess.h:
+(WebProcess):
+
2012-12-12 Andy Estes
[WebKit2] Only register NSNotificationCenter observers once per WebContext
Modified: trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp (137639 => 137640)
--- trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp 2012-12-13 20:50:32 UTC (rev 137639)
+++ trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp 2012-12-13 20:53:03 UTC (rev 137640)
@@ -34,16 +34,13 @@
namespace WebKit {
-DownloadManager& DownloadManager::shared()
+DownloadManager::DownloadManager(Client* client)
+: m_client(client)
{
-DEFINE_STATIC_LOCAL(DownloadManager, downloadManager, ());
-return downloadManager;
+// FIXME: Actually use the client for something.
+(void)m_client;
}
-DownloadManager::DownloadManager()
-{
-}
-
void DownloadManager::startDownload(uint64_t downloadID, const ResourceRequest& request)
{
OwnPtr download = Download::create(*this, downloadID, request);
Modified: trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.h (137639 => 137640)
--- trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.h 2012-12-13 20:50:32 UTC (rev 137639)
+++ trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.h 2012-12-13 20:53:03 UTC (rev 137640)
@@ -48,8 +48,13 @@
WTF_MAKE_NONCOPYABLE(DownloadManager);
public:
-static DownloadManager& shared();
+class Client {
+public:
+virtual ~Client() { }
+};
+explicit DownloadManager(Client*);
+
void startDownload(uint64_t downloadID, const WebCore::ResourceRequest&);
void convertHandleToDownload(uint64_t downloadID, WebCore::ResourceHandle*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
@@ -63,8 +68,7 @@
#endif
private:
-DownloadManager();
-
+Client* m_client;
HashMap m_downloads;
};
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp (137639 => 137640)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2012-12-13 20:50:32 UTC (rev 137639)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2012-12-13 20:53:03 UTC (rev 137640)
@@ -236,7 +236,7 @@
{
ASSERT(m_policyDownloadID);
-DownloadManager::shared().startDownload(m_policyDownloadID, request);
+WebProcess::shared().downloadManager().startDownload(m_policyDownloadID, request);
m_policyDownloadID = 0;
}
@@ -245,7 +245,7 @@
{
ASSERT(m_policyDownloadID);
-DownloadManager::shared().convertHandleToDownload(m_
[webkit-changes] [137639] tags/Safari-537.21/Source/WebCore
Title: [137639] tags/Safari-537.21/Source/WebCore
Revision 137639
Author lforsch...@apple.com
Date 2012-12-13 12:50:32 -0800 (Thu, 13 Dec 2012)
Log Message
Merged r137604.
Modified Paths
tags/Safari-537.21/Source/WebCore/ChangeLog
tags/Safari-537.21/Source/WebCore/loader/cache/CachedResource.cpp
tags/Safari-537.21/Source/WebCore/loader/cache/CachedResource.h
tags/Safari-537.21/Source/WebCore/loader/cache/CachedResourceLoader.cpp
Diff
Modified: tags/Safari-537.21/Source/WebCore/ChangeLog (137638 => 137639)
--- tags/Safari-537.21/Source/WebCore/ChangeLog 2012-12-13 20:46:32 UTC (rev 137638)
+++ tags/Safari-537.21/Source/WebCore/ChangeLog 2012-12-13 20:50:32 UTC (rev 137639)
@@ -1,3 +1,29 @@
+2012-12-13 Lucas Forschler
+
+Merge r137604
+
+2012-12-13 Nate Chapin
+
+CachedResources should hang on to stripped fragment identifiers
+https://bugs.webkit.org/show_bug.cgi?id=104721
+
+Reviewed by Maciej Stachowiak.
+
+No new tests, this will be unused until bug
+https://bugs.webkit.org/show_bug.cgi?id=49246 re-lands. Then, it will
+allow http/tests/inspector/resource-parameters.html to continue passing.
+
+* loader/cache/CachedResource.cpp:
+(WebCore::CachedResource::CachedResource):
+(WebCore::CachedResource::load):
+* loader/cache/CachedResource.h:
+(CachedResource):
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::requestResource): We override the request's url with the
+local variable "url" here. The only difference between url and request.url() is that url
+has had any fragment identifier removed. Do this work later (in the CachedResource constructor)
+so that the CachedResource can save the fragment for later.
+
2012-12-12 Shinya Kawanaka
ContainerNodeAlgorithm::notifyInsertedIntoDocument is not used
Modified: tags/Safari-537.21/Source/WebCore/loader/cache/CachedResource.cpp (137638 => 137639)
--- tags/Safari-537.21/Source/WebCore/loader/cache/CachedResource.cpp 2012-12-13 20:46:32 UTC (rev 137638)
+++ tags/Safari-537.21/Source/WebCore/loader/cache/CachedResource.cpp 2012-12-13 20:50:32 UTC (rev 137639)
@@ -188,6 +188,14 @@
#ifndef NDEBUG
cachedResourceLeakCounter.increment();
#endif
+
+if (!m_resourceRequest.url().hasFragmentIdentifier())
+return;
+KURL urlForCache = MemoryCache::removeFragmentIdentifierIfNeeded(m_resourceRequest.url());
+if (urlForCache.hasFragmentIdentifier())
+return;
+m_fragmentIdentifierForRequest = m_resourceRequest.url().fragmentIdentifier();
+m_resourceRequest.setURL(urlForCache);
}
CachedResource::~CachedResource()
@@ -293,10 +301,20 @@
if (type() != MainResource)
addAdditionalRequestHeaders(cachedResourceLoader);
+// FIXME: It's unfortunate that the cache layer and below get to know anything about fragment identifiers.
+// We should look into removing the expectation of that knowledge from the platform network stacks.
+ResourceRequest request(m_resourceRequest);
+if (!m_fragmentIdentifierForRequest.isNull()) {
+KURL url = ""
+url.setFragmentIdentifier(m_fragmentIdentifierForRequest);
+request.setURL(url);
+m_fragmentIdentifierForRequest = String();
+}
+
#if USE(PLATFORM_STRATEGIES)
-m_loader = platformStrategies()->loaderStrategy()->resourceLoadScheduler()->scheduleSubresourceLoad(cachedResourceLoader->frame(), this, m_resourceRequest, m_resourceRequest.priority(), options);
+m_loader = platformStrategies()->loaderStrategy()->resourceLoadScheduler()->scheduleSubresourceLoad(cachedResourceLoader->frame(), this, request, request.priority(), options);
#else
-m_loader = resourceLoadScheduler()->scheduleSubresourceLoad(cachedResourceLoader->frame(), this, m_resourceRequest, m_resourceRequest.priority(), options);
+m_loader = resourceLoadScheduler()->scheduleSubresourceLoad(cachedResourceLoader->frame(), this, request, request.priority(), options);
#endif
if (!m_loader) {
Modified: tags/Safari-537.21/Source/WebCore/loader/cache/CachedResource.h (137638 => 137639)
--- tags/Safari-537.21/Source/WebCore/loader/cache/CachedResource.h 2012-12-13 20:46:32 UTC (rev 137638)
+++ tags/Safari-537.21/Source/WebCore/loader/cache/CachedResource.h 2012-12-13 20:50:32 UTC (rev 137639)
@@ -308,6 +308,8 @@
void addAdditionalRequestHeaders(CachedResourceLoader*);
void failBeforeStarting();
+String m_fragmentIdentifierForRequest;
+
RefPtr m_cachedMetadata;
ResourceError m_error;
Modified: tags/Safari-537.21/Source/WebCore/loader/cache/CachedResourceLoader.cpp (137638 => 137639)
--- tags/Safari-537.21/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2012-12-13 20:46:32 UTC (rev 137638)
+++ tags/Safari-537.21/Source/WebCore/loader/cache/CachedResourceLoad
[webkit-changes] [137638] trunk/LayoutTests
Title: [137638] trunk/LayoutTests Revision 137638 Author bda...@apple.com Date 2012-12-13 12:46:32 -0800 (Thu, 13 Dec 2012) Log Message This test started failing after http://trac.webkit.org/changeset/137592 which rolled out a patch that touched these results. I am going to re-set the results for now so that the test will pass, and make a note in the bug. * platform/mac/accessibility/internal-link-anchors2-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/accessibility/internal-link-anchors2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (137637 => 137638) --- trunk/LayoutTests/ChangeLog 2012-12-13 20:44:22 UTC (rev 137637) +++ trunk/LayoutTests/ChangeLog 2012-12-13 20:46:32 UTC (rev 137638) @@ -1,3 +1,11 @@ +2012-12-13 Beth Dakin + +This test started failing after http://trac.webkit.org/changeset/137592 which +rolled out a patch that touched these results. I am going to re-set the results +for now so that the test will pass, and make a note in the bug. + +* platform/mac/accessibility/internal-link-anchors2-expected.txt: + 2012-12-13 David Grogan IndexedDB: Improve error messages Modified: trunk/LayoutTests/platform/mac/accessibility/internal-link-anchors2-expected.txt (137637 => 137638) --- trunk/LayoutTests/platform/mac/accessibility/internal-link-anchors2-expected.txt 2012-12-13 20:44:22 UTC (rev 137637) +++ trunk/LayoutTests/platform/mac/accessibility/internal-link-anchors2-expected.txt 2012-12-13 20:46:32 UTC (rev 137638) @@ -20,7 +20,7 @@ AXLinkedUIElements: (null) AXSelected: 0 AXBlockQuoteLevel: 0 -AXTopLevelUIElement: +AXTopLevelUIElement: AXARIABusy: 0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137637] trunk/Source/WebKit2
Title: [137637] trunk/Source/WebKit2
Revision 137637
Author aes...@apple.com
Date 2012-12-13 12:44:22 -0800 (Thu, 13 Dec 2012)
Log Message
[WebKit2] Only register NSNotificationCenter observers once per WebContext
https://bugs.webkit.org/show_bug.cgi?id=104879
Reviewed by Alexey Proskuryakov.
WebContext was mistakenly registering NSNotificationCenter observers
every time a new web process was created. In a multi-WebProcess world,
this caused duplicate observers to be needlessly registered. Fix this
by registering observers at WebContext creation time (and fix a related
bug where two of the observers were never unregistered).
* UIProcess/WebContext.h:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitialize): Register observers when initializing the context.
(WebKit::WebContext::platformInitializeWebProcess): Don't register observers here.
(WebKit::WebContext::platformInvalidateContext): Unregister observers when invalidating the context.
(WebKit::WebContext::registerNotificationObservers):
(WebKit::WebContext::unregisterNotificationObservers):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137636 => 137637)
--- trunk/Source/WebKit2/ChangeLog 2012-12-13 20:11:46 UTC (rev 137636)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-13 20:44:22 UTC (rev 137637)
@@ -1,3 +1,24 @@
+2012-12-12 Andy Estes
+
+[WebKit2] Only register NSNotificationCenter observers once per WebContext
+https://bugs.webkit.org/show_bug.cgi?id=104879
+
+Reviewed by Alexey Proskuryakov.
+
+WebContext was mistakenly registering NSNotificationCenter observers
+every time a new web process was created. In a multi-WebProcess world,
+this caused duplicate observers to be needlessly registered. Fix this
+by registering observers at WebContext creation time (and fix a related
+bug where two of the observers were never unregistered).
+
+* UIProcess/WebContext.h:
+* UIProcess/mac/WebContextMac.mm:
+(WebKit::WebContext::platformInitialize): Register observers when initializing the context.
+(WebKit::WebContext::platformInitializeWebProcess): Don't register observers here.
+(WebKit::WebContext::platformInvalidateContext): Unregister observers when invalidating the context.
+(WebKit::WebContext::registerNotificationObservers):
+(WebKit::WebContext::unregisterNotificationObservers):
+
2012-12-13 Anders Carlsson
Download objects should keep track of their associated DownloadManager object
Modified: trunk/Source/WebKit2/UIProcess/WebContext.h (137636 => 137637)
--- trunk/Source/WebKit2/UIProcess/WebContext.h 2012-12-13 20:11:46 UTC (rev 137636)
+++ trunk/Source/WebKit2/UIProcess/WebContext.h 2012-12-13 20:44:22 UTC (rev 137637)
@@ -319,6 +319,8 @@
static void applicationBecameOccluded(uint32_t, void*, uint32_t, void*, uint32_t);
static void initializeProcessSuppressionSupport();
static void registerOcclusionNotificationHandlers();
+void registerNotificationObservers();
+void unregisterNotificationObservers();
#endif
void addPlugInAutoStartOriginHash(const String& pageOrigin, unsigned plugInOriginHash);
Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (137636 => 137637)
--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm 2012-12-13 20:11:46 UTC (rev 137636)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm 2012-12-13 20:44:22 UTC (rev 137637)
@@ -79,6 +79,7 @@
void WebContext::platformInitialize()
{
registerUserDefaultsIfNeeded();
+registerNotificationObservers();
}
String WebContext::applicationCacheDirectory()
@@ -131,30 +132,11 @@
NSArray *schemes = [[WKBrowsingContextController customSchemes] allObjects];
for (size_t i = 0; i < [schemes count]; ++i)
parameters.urlSchemesRegisteredForCustomProtocols.append([schemes objectAtIndex:i]);
-
-// FIXME(Multi-WebProcess): We register observers for every process that is created, which makes no sense.
-
-m_customSchemeRegisteredObserver = [[NSNotificationCenter defaultCenter] addObserverForName:WebKit::SchemeForCustomProtocolRegisteredNotificationName object:nil queue:[NSOperationQueue currentQueue] usingBlock:^(NSNotification *notification) {
-NSString *scheme = [notification object];
-ASSERT([scheme isKindOfClass:[NSString class]]);
-sendToAllProcesses(Messages::WebProcess::RegisterSchemeForCustomProtocol(scheme));
-}];
-
-m_customSchemeUnregisteredObserver = [[NSNotificationCenter defaultCenter] addObserverForName:WebKit::SchemeForCustomProtocolUnregisteredNotificationName object:nil queue:[NSOperationQueue currentQueue] usingBlock:^(NSNotification *notification) {
-NSString *scheme = [notification object];
-ASSERT([scheme isKindOfClass:[NSString class]
[webkit-changes] [137636] trunk/Source/WebKit2
Title: [137636] trunk/Source/WebKit2
Revision 137636
Author ander...@apple.com
Date 2012-12-13 12:11:46 -0800 (Thu, 13 Dec 2012)
Log Message
Download objects should keep track of their associated DownloadManager object
https://bugs.webkit.org/show_bug.cgi?id=104936
Reviewed by Andreas Kling.
This is the first step towards eliminating DownloadManager::shared.
* WebProcess/Downloads/Download.cpp:
(WebKit::Download::create):
(WebKit::Download::Download):
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):
* WebProcess/Downloads/Download.h:
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp
trunk/Source/WebKit2/WebProcess/Downloads/Download.h
trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137635 => 137636)
--- trunk/Source/WebKit2/ChangeLog 2012-12-13 20:10:07 UTC (rev 137635)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-13 20:11:46 UTC (rev 137636)
@@ -1,5 +1,25 @@
2012-12-13 Anders Carlsson
+Download objects should keep track of their associated DownloadManager object
+https://bugs.webkit.org/show_bug.cgi?id=104936
+
+Reviewed by Andreas Kling.
+
+This is the first step towards eliminating DownloadManager::shared.
+
+* WebProcess/Downloads/Download.cpp:
+(WebKit::Download::create):
+(WebKit::Download::Download):
+(WebKit::Download::didFinish):
+(WebKit::Download::didFail):
+(WebKit::Download::didCancel):
+* WebProcess/Downloads/Download.h:
+* WebProcess/Downloads/DownloadManager.cpp:
+(WebKit::DownloadManager::startDownload):
+(WebKit::DownloadManager::convertHandleToDownload):
+
+2012-12-13 Anders Carlsson
+
Remove unused initiatingPage parameter from download objects
https://bugs.webkit.org/show_bug.cgi?id=104933
Modified: trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp (137635 => 137636)
--- trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp 2012-12-13 20:10:07 UTC (rev 137635)
+++ trunk/Source/WebKit2/WebProcess/Downloads/Download.cpp 2012-12-13 20:11:46 UTC (rev 137636)
@@ -40,13 +40,13 @@
namespace WebKit {
-PassOwnPtr Download::create(uint64_t downloadID, const ResourceRequest& request)
+PassOwnPtr Download::create(DownloadManager& downloadManager, uint64_t downloadID, const ResourceRequest& request)
{
-return adoptPtr(new Download(downloadID, request));
+return adoptPtr(new Download(downloadManager, downloadID, request));
}
-Download::Download(uint64_t downloadID, const ResourceRequest& request)
-: m_downloadID(downloadID)
+Download::Download(DownloadManager& downloadManager, uint64_t downloadID, const ResourceRequest& request)
+: m_downloadManager(downloadManager)
, m_request(request)
#if USE(CFNETWORK)
, m_allowOverwrite(false)
@@ -137,7 +137,8 @@
if (m_sandboxExtension)
m_sandboxExtension->invalidate();
-DownloadManager::shared().downloadFinished(this);
+
+m_downloadManager.downloadFinished(this);
}
void Download::didFail(const ResourceError& error, const CoreIPC::DataReference& resumeData)
@@ -146,7 +147,7 @@
if (m_sandboxExtension)
m_sandboxExtension->invalidate();
-DownloadManager::shared().downloadFinished(this);
+m_downloadManager.downloadFinished(this);
}
void Download::didCancel(const CoreIPC::DataReference& resumeData)
@@ -155,7 +156,7 @@
if (m_sandboxExtension)
m_sandboxExtension->invalidate();
-DownloadManager::shared().downloadFinished(this);
+m_downloadManager.downloadFinished(this);
}
} // namespace WebKit
Modified: trunk/Source/WebKit2/WebProcess/Downloads/Download.h (137635 => 137636)
--- trunk/Source/WebKit2/WebProcess/Downloads/Download.h 2012-12-13 20:10:07 UTC (rev 137635)
+++ trunk/Source/WebKit2/WebProcess/Downloads/Download.h 2012-12-13 20:11:46 UTC (rev 137636)
@@ -62,6 +62,7 @@
namespace WebKit {
class DownloadAuthenticationClient;
+class DownloadManager;
class SandboxExtension;
class WebPage;
@@ -72,7 +73,7 @@
class Download : public CoreIPC::MessageSender {
WTF_MAKE_NONCOPYABLE(Download);
public:
-static PassOwnPtr create(uint64_t downloadID, const WebCore::ResourceRequest&);
+static PassOwnPtr create(DownloadManager&, uint64_t downloadID, const WebCore::ResourceRequest&);
~Download();
// Used by MessageSender.
@@ -117,12 +118,13 @@
void cancelAuthenticationChallenge(const WebCore::AuthenticationChallenge&);
private:
-Download(uint64_t downloadID, const WebCore::ResourceRequest&);
+Download(DownloadManager&, uint64_t downloadID, const WebCore::ResourceRequest&);
void platformInvalidate();
String retrieveDestinationWithSuggestedFilena
[webkit-changes] [137635] trunk
Title: [137635] trunk
Revision 137635
Author dgro...@chromium.org
Date 2012-12-13 12:10:07 -0800 (Thu, 13 Dec 2012)
Log Message
IndexedDB: Improve error messages
https://bugs.webkit.org/show_bug.cgi?id=104624
Reviewed by Tony Chang.
Source/WebCore:
Add detail to error messages so that they are more helpful and can be
traced back to a specific line of code.
Updated test: transaction-error.html
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::open):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::perform):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
LayoutTests:
Updated error message and establish that non-ascii characters in index
names don't make it back to the browser properly.
* storage/indexeddb/resources/shared.js:
(unexpectedAbortCallback):
* storage/indexeddb/resources/transaction-error.js:
(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded.trans.onabort):
(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded):
(testErrorFromCommit.trans.oncomplete):
(testErrorFromCommit):
* storage/indexeddb/transaction-error-expected.txt:
* storage/indexeddb/transaction-error.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/resources/shared.js
trunk/LayoutTests/storage/indexeddb/resources/transaction-error.js
trunk/LayoutTests/storage/indexeddb/transaction-error-expected.txt
trunk/LayoutTests/storage/indexeddb/transaction-error.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (137634 => 137635)
--- trunk/LayoutTests/ChangeLog 2012-12-13 20:07:58 UTC (rev 137634)
+++ trunk/LayoutTests/ChangeLog 2012-12-13 20:10:07 UTC (rev 137635)
@@ -1,3 +1,23 @@
+2012-12-13 David Grogan
+
+IndexedDB: Improve error messages
+https://bugs.webkit.org/show_bug.cgi?id=104624
+
+Reviewed by Tony Chang.
+
+Updated error message and establish that non-ascii characters in index
+names don't make it back to the browser properly.
+
+* storage/indexeddb/resources/shared.js:
+(unexpectedAbortCallback):
+* storage/indexeddb/resources/transaction-error.js:
+(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded.trans.onabort):
+(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded):
+(testErrorFromCommit.trans.oncomplete):
+(testErrorFromCommit):
+* storage/indexeddb/transaction-error-expected.txt:
+* storage/indexeddb/transaction-error.html:
+
2012-12-13 David Barton
Heap-use-after-free in WebCore::RenderBlock::finishDelayUpdateScrollInfo
Modified: trunk/LayoutTests/storage/indexeddb/resources/shared.js (137634 => 137635)
--- trunk/LayoutTests/storage/indexeddb/resources/shared.js 2012-12-13 20:07:58 UTC (rev 137634)
+++ trunk/LayoutTests/storage/indexeddb/resources/shared.js 2012-12-13 20:10:07 UTC (rev 137635)
@@ -53,7 +53,7 @@
function unexpectedAbortCallback(e)
{
-testFailed("Abort function called unexpectedly!");
+testFailed("Abort function called unexpectedly! Message: [" + e.target.webkitErrorMessage + "]");
finishJSTest();
}
Modified: trunk/LayoutTests/storage/indexeddb/resources/transaction-error.js (137634 => 137635)
--- trunk/LayoutTests/storage/indexeddb/resources/transaction-error.js 2012-12-13 20:07:58 UTC (rev 137634)
+++ trunk/LayoutTests/storage/indexeddb/resources/transaction-error.js 2012-12-13 20:10:07 UTC (rev 137635)
@@ -105,7 +105,8 @@
request._onupgradeneeded_ = function() {
evalAndLog("trans = request.transaction");
debug("This should fail due to the unique constraint:");
-evalAndLog("trans.objectStore('storeName').createIndex('indexName', 'id', {unique: true})");
+evalAndLog("indexName = 'Also test utf8: \u6F22'");
+evalAndLog("trans.objectStore('storeName').creat
[webkit-changes] [137634] trunk/Tools
Title: [137634] trunk/Tools
Revision 137634
Author dpra...@chromium.org
Date 2012-12-13 12:07:58 -0800 (Thu, 13 Dec 2012)
Log Message
Fix a mis-named variable after r137621.
https://bugs.webkit.org/show_bug.cgi?id=104871
Unreviewed, build fix.
* Scripts/webkitpy/layout_tests/views/buildbot_results.py:
(BuildBotPrinter.print_results):
* Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py
trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (137633 => 137634)
--- trunk/Tools/ChangeLog 2012-12-13 19:51:49 UTC (rev 137633)
+++ trunk/Tools/ChangeLog 2012-12-13 20:07:58 UTC (rev 137634)
@@ -1,5 +1,16 @@
2012-12-13 Dirk Pranke
+Fix a mis-named variable after r137621.
+https://bugs.webkit.org/show_bug.cgi?id=104871
+
+Unreviewed, build fix.
+
+* Scripts/webkitpy/layout_tests/views/buildbot_results.py:
+(BuildBotPrinter.print_results):
+* Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
+
+2012-12-13 Dirk Pranke
+
webkitpy: rename ResultSummary
https://bugs.webkit.org/show_bug.cgi?id=104871
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py (137633 => 137634)
--- trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py 2012-12-13 19:51:49 UTC (rev 137633)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py 2012-12-13 20:07:58 UTC (rev 137634)
@@ -48,7 +48,7 @@
def print_results(self, run_details):
if self.debug_logging:
-self.print_run_results(run_details.run_results)
+self.print_run_results(run_details.initial_results)
self.print_unexpected_results(run_details.summarized_results)
def _print(self, msg):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py (137633 => 137634)
--- trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py 2012-12-13 19:51:49 UTC (rev 137633)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py 2012-12-13 20:07:58 UTC (rev 137634)
@@ -163,3 +163,13 @@
ur = get_unexpected_results(expected=False, passing=True, flaky=False)
printer.print_unexpected_results(ur)
self.assertNotEmpty(out)
+
+printer, out = self.get_printer()
+tests = ['passes/text.html', 'failures/expected/timeout.html', 'failures/expected/crash.html', 'failures/expected/audio.html']
+expectations = ''
+port = MockHost().port_factory.get('test')
+paths, initial_results, exp = self.get_run_results(port, tests, expectations)
+summarized_results = get_unexpected_results(expected=False, passing=True, flaky=False)
+details = manager.RunDetails(summarized_results['num_regressions'], summarized_results, initial_results, None)
+printer.print_results(details)
+self.assertNotEmpty(out)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137633] trunk/Source/WebCore
Title: [137633] trunk/Source/WebCore
Revision 137633
Author commit-qu...@webkit.org
Date 2012-12-13 11:51:49 -0800 (Thu, 13 Dec 2012)
Log Message
[GTK] Safeguard against possible NULL-dereference
https://bugs.webkit.org/show_bug.cgi?id=104931
Patch by Claudio Saavedra on 2012-12-13
Reviewed by Chris Fleizach.
This was spotted by Coverity. See bug 104114.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetIndexInParent): If parent is NULL
bail out early.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (137632 => 137633)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 19:48:26 UTC (rev 137632)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 19:51:49 UTC (rev 137633)
@@ -1,3 +1,16 @@
+2012-12-13 Claudio Saavedra
+
+[GTK] Safeguard against possible NULL-dereference
+https://bugs.webkit.org/show_bug.cgi?id=104931
+
+Reviewed by Chris Fleizach.
+
+This was spotted by Coverity. See bug 104114.
+
+* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+(webkitAccessibleGetIndexInParent): If parent is NULL
+bail out early.
+
2012-12-13 David Barton
Heap-use-after-free in WebCore::RenderBlock::finishDelayUpdateScrollInfo
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (137632 => 137633)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2012-12-13 19:48:26 UTC (rev 137632)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2012-12-13 19:51:49 UTC (rev 137633)
@@ -407,6 +407,9 @@
AccessibilityObject* coreObject = core(object);
AccessibilityObject* parent = coreObject->parentObjectUnignored();
+if (!parent)
+return -1;
+
if (!parent && isRootObject(coreObject)) {
AtkObject* atkParent = atkParentOfRootObject(object);
if (!atkParent)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137632] trunk
Title: [137632] trunk
Revision 137632
Author dbar...@mathscribe.com
Date 2012-12-13 11:48:26 -0800 (Thu, 13 Dec 2012)
Log Message
Heap-use-after-free in WebCore::RenderBlock::finishDelayUpdateScrollInfo
https://bugs.webkit.org/show_bug.cgi?id=103750
Reviewed by Tony Chang.
Source/WebCore:
MathML sometimes creates and destroys renderers for descendants during layout (or even to calculate
preferred logical widths), e.g. for operator stretching. RenderBlock::finishDelayUpdateScrollInfo
must therefore leave gDelayedUpdateScrollInfoSet intact as it iterates over it, so
RenderBlock::willBeDestroyed can call gDelayedUpdateScrollInfoSet->remove(this) effectively if needed.
This also prevents duplicate entries from being added to gDelayedUpdateScrollInfoSet.
Test: mathml/mo-stretch-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::startDelayUpdateScrollInfo):
- Allow gDelayedUpdateScrollInfoSet to be non-null when gDelayUpdateScrollInfo is 0 during
RenderBlock::finishDelayUpdateScrollInfo.
(WebCore::RenderBlock::finishDelayUpdateScrollInfo):
- Remove blocks from gDelayedUpdateScrollInfoSet one at a time, waiting for each block until it is
about to be updated.
LayoutTests:
* mathml/mo-stretch-crash-expected.txt: Added.
* mathml/mo-stretch-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/mathml/mo-stretch-crash-expected.txt
trunk/LayoutTests/mathml/mo-stretch-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137631 => 137632)
--- trunk/LayoutTests/ChangeLog 2012-12-13 19:46:13 UTC (rev 137631)
+++ trunk/LayoutTests/ChangeLog 2012-12-13 19:48:26 UTC (rev 137632)
@@ -1,3 +1,13 @@
+2012-12-13 David Barton
+
+Heap-use-after-free in WebCore::RenderBlock::finishDelayUpdateScrollInfo
+https://bugs.webkit.org/show_bug.cgi?id=103750
+
+Reviewed by Tony Chang.
+
+* mathml/mo-stretch-crash-expected.txt: Added.
+* mathml/mo-stretch-crash.html: Added.
+
2012-12-13 Joanmarie Diggs
[GTK] accessibiltiy/aria-hidden.html is failing
Added: trunk/LayoutTests/mathml/mo-stretch-crash-expected.txt (0 => 137632)
--- trunk/LayoutTests/mathml/mo-stretch-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/mathml/mo-stretch-crash-expected.txt 2012-12-13 19:48:26 UTC (rev 137632)
@@ -0,0 +1,2 @@
+This test passes if it does not crash.
+
Added: trunk/LayoutTests/mathml/mo-stretch-crash.html (0 => 137632)
--- trunk/LayoutTests/mathml/mo-stretch-crash.html (rev 0)
+++ trunk/LayoutTests/mathml/mo-stretch-crash.html 2012-12-13 19:48:26 UTC (rev 137632)
@@ -0,0 +1,30 @@
+
+
+
+
+
+dd, q, mfenced, div {
+width: 7px;
+overflow-y: auto;
+padding-left: 100%;
+}
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+body.contentEditable = "true";
+function crash() {
+mfenced = document.createElementNS("http://www.w3.org/1998/Math/MathML", "mfenced");
+div = document.createElement("div");
+mfenced.appendChild(div);
+dd.appendChild(mfenced);
+body.style.display = "-webkit-flex";
+div.appendChild(quote);
+}
+window.addEventListener("load", crash, false);
+
+
+This test passes if it does not crash.
+
+
Modified: trunk/Source/WebCore/ChangeLog (137631 => 137632)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 19:46:13 UTC (rev 137631)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 19:48:26 UTC (rev 137632)
@@ -1,3 +1,26 @@
+2012-12-13 David Barton
+
+Heap-use-after-free in WebCore::RenderBlock::finishDelayUpdateScrollInfo
+https://bugs.webkit.org/show_bug.cgi?id=103750
+
+Reviewed by Tony Chang.
+
+MathML sometimes creates and destroys renderers for descendants during layout (or even to calculate
+preferred logical widths), e.g. for operator stretching. RenderBlock::finishDelayUpdateScrollInfo
+must therefore leave gDelayedUpdateScrollInfoSet intact as it iterates over it, so
+RenderBlock::willBeDestroyed can call gDelayedUpdateScrollInfoSet->remove(this) effectively if needed.
+This also prevents duplicate entries from being added to gDelayedUpdateScrollInfoSet.
+
+Test: mathml/mo-stretch-crash.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::startDelayUpdateScrollInfo):
+- Allow gDelayedUpdateScrollInfoSet to be non-null when gDelayUpdateScrollInfo is 0 during
+ RenderBlock::finishDelayUpdateScrollInfo.
+(WebCore::RenderBlock::finishDelayUpdateScrollInfo):
+- Remove blocks from gDelayedUpdateScrollInfoSet one at a time, waiting for each block until it is
+ about to be updated.
+
2012-12-13 Alexey Proskuryakov
[webkit-changes] [137631] trunk/Source/WebCore
Title: [137631] trunk/Source/WebCore Revision 137631 Author a...@apple.com Date 2012-12-13 11:46:13 -0800 (Thu, 13 Dec 2012) Log Message ResourceLoader::didReceiveAuthenticationChallenge uses a wrong client https://bugs.webkit.org/show_bug.cgi?id=104935 Reviewed by Anders Carlsson. * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): The handle is null when NetworkProcess is used. In any case, it should be correct to use the client carried within AuthenticationChallenge. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/ResourceLoader.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (137630 => 137631) --- trunk/Source/WebCore/ChangeLog 2012-12-13 19:32:23 UTC (rev 137630) +++ trunk/Source/WebCore/ChangeLog 2012-12-13 19:46:13 UTC (rev 137631) @@ -1,3 +1,15 @@ +2012-12-13 Alexey Proskuryakov + +ResourceLoader::didReceiveAuthenticationChallenge uses a wrong client +https://bugs.webkit.org/show_bug.cgi?id=104935 + + +Reviewed by Anders Carlsson. + +* loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): +The handle is null when NetworkProcess is used. In any case, it should be correct +to use the client carried within AuthenticationChallenge. + 2012-12-13 Stephen White CanvasRenderingContext2D::setFont() is slow. Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (137630 => 137631) --- trunk/Source/WebCore/loader/ResourceLoader.cpp 2012-12-13 19:32:23 UTC (rev 137630) +++ trunk/Source/WebCore/loader/ResourceLoader.cpp 2012-12-13 19:46:13 UTC (rev 137631) @@ -499,8 +499,8 @@ // Only these platforms provide a way to continue without credentials. // If we can't continue with credentials, we need to cancel the load altogether. #if PLATFORM(MAC) || USE(CFNETWORK) || USE(CURL) || PLATFORM(GTK) || PLATFORM(EFL) -handle()->receivedRequestToContinueWithoutCredential(challenge); -ASSERT(!handle()->hasAuthenticationChallenge()); +challenge.authenticationClient()->receivedRequestToContinueWithoutCredential(challenge); +ASSERT(!handle() || !handle()->hasAuthenticationChallenge()); #else didFail(blockedError()); #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137630] trunk
Title: [137630] trunk
Revision 137630
Author senorbla...@chromium.org
Date 2012-12-13 11:32:23 -0800 (Thu, 13 Dec 2012)
Log Message
.: Added manual test for canvas setFont speed.
https://bugs.webkit.org/show_bug.cgi?id=104923
Reviewed by James Robinson.
* ManualTests/canvas-font-speed.html: Added.
Source/WebCore: CanvasRenderingContext2D::setFont() is slow.
https://bugs.webkit.org/show_bug.cgi?id=104923
Reviewed by James Robinson.
This spends most of its time in the CSS parser. As a first step,
early-out if the new value is the same as unparsed string for the current font.
See also http://code.google.com/p/chromium/issues/detail?id=164016.
Covered by existing tests in canvas/ and fast/canvas, and ManualTests/canvas-font-speed.html.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Added Paths
trunk/ManualTests/canvas-font-speed.html
Diff
Modified: trunk/ChangeLog (137629 => 137630)
--- trunk/ChangeLog 2012-12-13 19:26:08 UTC (rev 137629)
+++ trunk/ChangeLog 2012-12-13 19:32:23 UTC (rev 137630)
@@ -1,3 +1,12 @@
+2012-12-13 Stephen White
+
+Added manual test for canvas setFont speed.
+https://bugs.webkit.org/show_bug.cgi?id=104923
+
+Reviewed by James Robinson.
+
+* ManualTests/canvas-font-speed.html: Added.
+
2012-12-13 Jerome Pasion
[Qt] Doc: Fixing Qt WebKit reference documentation.
Added: trunk/ManualTests/canvas-font-speed.html (0 => 137630)
--- trunk/ManualTests/canvas-font-speed.html (rev 0)
+++ trunk/ManualTests/canvas-font-speed.html 2012-12-13 19:32:23 UTC (rev 137630)
@@ -0,0 +1,18 @@
+
+
+
+Canvas 2d Context Font Property Speed
+
+
+
+
+var canvas = document.getElementById('thecanvas');
+var context = canvas.getContext('2d');
+var t0 = Date.now();
+for (var i = 0; i < 1000; i++) {
+ context.font = 'bold 13px Arial';
+}
+alert('Elapsed for 1000 font settings: ' + (Date.now() - t0));
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (137629 => 137630)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 19:26:08 UTC (rev 137629)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 19:32:23 UTC (rev 137630)
@@ -1,3 +1,19 @@
+2012-12-13 Stephen White
+
+CanvasRenderingContext2D::setFont() is slow.
+https://bugs.webkit.org/show_bug.cgi?id=104923
+
+Reviewed by James Robinson.
+
+This spends most of its time in the CSS parser. As a first step,
+early-out if the new value is the same as unparsed string for the current font.
+See also http://code.google.com/p/chromium/issues/detail?id=164016.
+
+Covered by existing tests in canvas/ and fast/canvas, and ManualTests/canvas-font-speed.html.
+
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::setFont):
+
2012-12-13 Parth Patel , Max Feil
Allow plugins to be disabled by shared library filename
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (137629 => 137630)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2012-12-13 19:26:08 UTC (rev 137629)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2012-12-13 19:32:23 UTC (rev 137630)
@@ -2072,6 +2072,9 @@
void CanvasRenderingContext2D::setFont(const String& newFont)
{
+if (newFont == state().m_unparsedFont && state().m_realizedFont)
+return;
+
RefPtr parsedStyle = StylePropertySet::create();
CSSParser::parseValue(parsedStyle.get(), CSSPropertyFont, newFont, true, strictToCSSParserMode(!m_usesCSSCompatibilityParseMode), 0);
if (parsedStyle->isEmpty())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137629] branches/safari-536.28-branch/Source/WebKit2
Title: [137629] branches/safari-536.28-branch/Source/WebKit2
Revision 137629
Author lforsch...@apple.com
Date 2012-12-13 11:26:08 -0800 (Thu, 13 Dec 2012)
Log Message
Rollout r133937.
Modified Paths
branches/safari-536.28-branch/Source/WebKit2/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/Shared/WebPreferencesStore.h
branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h
branches/safari-536.28-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
branches/safari-536.28-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h
Diff
Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (137628 => 137629)
--- branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:23:27 UTC (rev 137628)
+++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:26:08 UTC (rev 137629)
@@ -1,5 +1,9 @@
2012-12-13 Lucas Forschler
+Rollout r133937
+
+2012-12-13 Lucas Forschler
+
Rollout r133942 and 133943
2012-12-13 Lucas Forschler
Modified: branches/safari-536.28-branch/Source/WebKit2/Shared/WebPreferencesStore.h (137628 => 137629)
--- branches/safari-536.28-branch/Source/WebKit2/Shared/WebPreferencesStore.h 2012-12-13 19:23:27 UTC (rev 137628)
+++ branches/safari-536.28-branch/Source/WebKit2/Shared/WebPreferencesStore.h 2012-12-13 19:26:08 UTC (rev 137629)
@@ -112,8 +112,6 @@
macro(ShouldRespectImageOrientation, shouldRespectImageOrientation, Bool, bool, false) \
macro(WantsBalancedSetDefersLoadingBehavior, wantsBalancedSetDefersLoadingBehavior, Bool, bool, false) \
macro(DiagnosticLoggingEnabled, diagnosticLoggingEnabled, Bool, bool, false) \
-macro(AsynchronousPluginInitializationEnabled, asynchronousPluginInitializationEnabled, Bool, bool, false) \
-macro(ArtificialPluginInitializationDelayEnabled, artificialPluginInitializationDelayEnabled, Bool, bool, false) \
macro(CookieEnabled, cookieEnabled, Bool, bool, true) \
\
Modified: branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (137628 => 137629)
--- branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2012-12-13 19:23:27 UTC (rev 137628)
+++ branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2012-12-13 19:26:08 UTC (rev 137629)
@@ -814,23 +814,3 @@
{
return toImpl(preferencesRef)->diagnosticLoggingEnabled();
}
-
-void WKPreferencesSetAsynchronousPluginInitializationEnabled(WKPreferencesRef preferencesRef, bool enabled)
-{
-toImpl(preferencesRef)->setAsynchronousPluginInitializationEnabled(enabled);
-}
-
-bool WKPreferencesGetAsynchronousPluginInitializationEnabled(WKPreferencesRef preferencesRef)
-{
-return toImpl(preferencesRef)->asynchronousPluginInitializationEnabled();
-}
-
-void WKPreferencesSetArtificialPluginInitializationDelayEnabled(WKPreferencesRef preferencesRef, bool enabled)
-{
-toImpl(preferencesRef)->setArtificialPluginInitializationDelayEnabled(enabled);
-}
-
-bool WKPreferencesGetArtificialPluginInitializationDelayEnabled(WKPreferencesRef preferencesRef)
-{
-return toImpl(preferencesRef)->artificialPluginInitializationDelayEnabled();
-}
Modified: branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h (137628 => 137629)
--- branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h 2012-12-13 19:23:27 UTC (rev 137628)
+++ branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h 2012-12-13 19:26:08 UTC (rev 137629)
@@ -183,14 +183,6 @@
WK_EXPORT void WKPreferencesSetDiagnosticLoggingEnabled(WKPreferencesRef preferencesRef, bool enabled);
WK_EXPORT bool WKPreferencesGetDiagnosticLoggingEnabled(WKPreferencesRef preferencesRef);
-// Defaults to false
-WK_EXPORT void WKPreferencesSetAsynchronousPluginInitializationEnabled(WKPreferencesRef preferencesRef, bool enabled);
-WK_EXPORT bool WKPreferencesGetAsynchronousPluginInitializationEnabled(WKPreferencesRef preferencesRef);
-
-// Defaults to false
-WK_EXPORT void WKPreferencesSetArtificialPluginInitializationDelayEnabled(WKPreferencesRef preferencesRef, bool enabled);
-WK_EXPORT bool WKPreferencesGetArtificialPluginInitializationDelayEnabled(WKPreferencesRef preferencesRef);
-
// Defaults to true
WK_EXPORT void WKPreferencesSetCookieEnabled(WKPreferencesRef preferences, bool enabled);
WK_EXPORT bool WKPreferencesGetCookieEnabled(WKPreferencesRef preferences);
Modified: branches/safari-536.28-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (137628 => 137629)
--- branches/safari-536.28-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-12-13 19:23:27 UTC (rev 137628)
+++ branches/safari-536.28-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-12-13 19:26:08 UTC (rev 137629)
@@ -189,8 +189,6 @@
, m_isInRedo(false)
, m_isClosed(false)
, m_tabToLinks(false)
-
[webkit-changes] [137628] branches/safari-536.28-branch
Title: [137628] branches/safari-536.28-branch
Revision 137628
Author lforsch...@apple.com
Date 2012-12-13 11:23:27 -0800 (Thu, 13 Dec 2012)
Log Message
Rollout r133942 and r133943.
Modified Paths
branches/safari-536.28-branch/Source/WebKit2/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/Shared/WebPreferencesStore.h
branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h
branches/safari-536.28-branch/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
branches/safari-536.28-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
branches/safari-536.28-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h
branches/safari-536.28-branch/Tools/ChangeLog
branches/safari-536.28-branch/Tools/WebKitTestRunner/TestController.cpp
Diff
Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (137627 => 137628)
--- branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:23:23 UTC (rev 137627)
+++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:23:27 UTC (rev 137628)
@@ -1,5 +1,9 @@
2012-12-13 Lucas Forschler
+Rollout r133942 and 133943
+
+2012-12-13 Lucas Forschler
+
Rollout r133946
2012-12-13 Lucas Forschler
Modified: branches/safari-536.28-branch/Source/WebKit2/Shared/WebPreferencesStore.h (137627 => 137628)
--- branches/safari-536.28-branch/Source/WebKit2/Shared/WebPreferencesStore.h 2012-12-13 19:23:23 UTC (rev 137627)
+++ branches/safari-536.28-branch/Source/WebKit2/Shared/WebPreferencesStore.h 2012-12-13 19:23:27 UTC (rev 137628)
@@ -113,7 +113,6 @@
macro(WantsBalancedSetDefersLoadingBehavior, wantsBalancedSetDefersLoadingBehavior, Bool, bool, false) \
macro(DiagnosticLoggingEnabled, diagnosticLoggingEnabled, Bool, bool, false) \
macro(AsynchronousPluginInitializationEnabled, asynchronousPluginInitializationEnabled, Bool, bool, false) \
-macro(AsynchronousPluginInitializationEnabledForAllPlugins, asynchronousPluginInitializationEnabledForAllPlugins, Bool, bool, false) \
macro(ArtificialPluginInitializationDelayEnabled, artificialPluginInitializationDelayEnabled, Bool, bool, false) \
macro(CookieEnabled, cookieEnabled, Bool, bool, true) \
\
Modified: branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (137627 => 137628)
--- branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2012-12-13 19:23:23 UTC (rev 137627)
+++ branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2012-12-13 19:23:27 UTC (rev 137628)
@@ -825,16 +825,6 @@
return toImpl(preferencesRef)->asynchronousPluginInitializationEnabled();
}
-void WKPreferencesSetAsynchronousPluginInitializationEnabledForAllPlugins(WKPreferencesRef preferencesRef, bool enabled)
-{
-toImpl(preferencesRef)->setAsynchronousPluginInitializationEnabledForAllPlugins(enabled);
-}
-
-bool WKPreferencesGetAsynchronousPluginInitializationEnabledForAllPlugins(WKPreferencesRef preferencesRef)
-{
-return toImpl(preferencesRef)->asynchronousPluginInitializationEnabledForAllPlugins();
-}
-
void WKPreferencesSetArtificialPluginInitializationDelayEnabled(WKPreferencesRef preferencesRef, bool enabled)
{
toImpl(preferencesRef)->setArtificialPluginInitializationDelayEnabled(enabled);
Modified: branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h (137627 => 137628)
--- branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h 2012-12-13 19:23:23 UTC (rev 137627)
+++ branches/safari-536.28-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h 2012-12-13 19:23:27 UTC (rev 137628)
@@ -188,10 +188,6 @@
WK_EXPORT bool WKPreferencesGetAsynchronousPluginInitializationEnabled(WKPreferencesRef preferencesRef);
// Defaults to false
-WK_EXPORT void WKPreferencesSetAsynchronousPluginInitializationEnabledForAllPlugins(WKPreferencesRef preferencesRef, bool enabled);
-WK_EXPORT bool WKPreferencesGetAsynchronousPluginInitializationEnabledForAllPlugins(WKPreferencesRef preferencesRef);
-
-// Defaults to false
WK_EXPORT void WKPreferencesSetArtificialPluginInitializationDelayEnabled(WKPreferencesRef preferencesRef, bool enabled);
WK_EXPORT bool WKPreferencesGetArtificialPluginInitializationDelayEnabled(WKPreferencesRef preferencesRef);
Modified: branches/safari-536.28-branch/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (137627 => 137628)
--- branches/safari-536.28-branch/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2012-12-13 19:23:23 UTC (rev 137627)
+++ branches/safari-536.28-branch/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2012-12-13 19:23:27 UTC (rev 137628)
@@ -125,30 +125,6 @@
// FIXME: Need an explicit way to set "WebKitTabToLinksPreferenceKey" directly in WebPage.
-if (preference == "WebKit2AsynchronousPluginInitializationEnable
[webkit-changes] [137627] trunk/Source
Title: [137627] trunk/Source
Revision 137627
Author commit-qu...@webkit.org
Date 2012-12-13 11:23:23 -0800 (Thu, 13 Dec 2012)
Log Message
Allow plugins to be disabled by shared library filename
https://bugs.webkit.org/show_bug.cgi?id=101274
Patch by Parth Patel , Max Feil on 2012-12-13
Reviewed by Antonio Gomes.
Source/WebCore:
This fix makes PluginDatabase changes general so that other ports
can use this mechanism if they wish.
Layout test not included with this patch because there
is currently no framework within LayoutTests to allow calls
from an external application via platform API code (such as the
WebView API).
* plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::fileExistsAndIsNotDisabled):
(WebCore):
(WebCore::PluginDatabase::getDeletedPlugins):
(WebCore::PluginDatabase::removeDisabledPluginFile):
(WebCore::PluginDatabase::addDisabledPluginFile):
(WebCore::PluginDatabase::getPluginPathsInDirectories):
* plugins/PluginDatabase.h:
(PluginDatabase):
Source/WebKit/blackberry:
Mechanism allows plugins to be disabled by specifying their shared library filenames.
Once disabled, a plugin's shared library should never be loaded.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
(WebKit):
(BlackBerry::WebKit::WebPage::updateDisabledPluginFiles):
* Api/WebPage.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/PluginDatabase.cpp
trunk/Source/WebCore/plugins/PluginDatabase.h
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage.h
trunk/Source/WebKit/blackberry/ChangeLog
Diff
Modified: trunk/Source/WebCore/ChangeLog (137626 => 137627)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 19:16:29 UTC (rev 137626)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 19:23:23 UTC (rev 137627)
@@ -1,3 +1,28 @@
+2012-12-13 Parth Patel , Max Feil
+
+Allow plugins to be disabled by shared library filename
+https://bugs.webkit.org/show_bug.cgi?id=101274
+
+Reviewed by Antonio Gomes.
+
+This fix makes PluginDatabase changes general so that other ports
+can use this mechanism if they wish.
+
+Layout test not included with this patch because there
+is currently no framework within LayoutTests to allow calls
+from an external application via platform API code (such as the
+WebView API).
+
+* plugins/PluginDatabase.cpp:
+(WebCore::PluginDatabase::fileExistsAndIsNotDisabled):
+(WebCore):
+(WebCore::PluginDatabase::getDeletedPlugins):
+(WebCore::PluginDatabase::removeDisabledPluginFile):
+(WebCore::PluginDatabase::addDisabledPluginFile):
+(WebCore::PluginDatabase::getPluginPathsInDirectories):
+* plugins/PluginDatabase.h:
+(PluginDatabase):
+
2012-12-13 Yongjun Zhang
Document will never be released when an Image is created inside unload event listener
Modified: trunk/Source/WebCore/plugins/PluginDatabase.cpp (137626 => 137627)
--- trunk/Source/WebCore/plugins/PluginDatabase.cpp 2012-12-13 19:16:29 UTC (rev 137626)
+++ trunk/Source/WebCore/plugins/PluginDatabase.cpp 2012-12-13 19:23:23 UTC (rev 137627)
@@ -312,11 +312,20 @@
m_preferredPlugins.set(mimeType.lower(), plugin);
}
+bool PluginDatabase::fileExistsAndIsNotDisabled(const String& filePath) const
+{
+// Skip plugin files that are disabled by filename.
+if (m_disabledPluginFiles.contains(pathGetFileName(filePath)))
+return false;
+
+return fileExists(filePath);
+}
+
void PluginDatabase::getDeletedPlugins(PluginSet& plugins) const
{
PluginSet::const_iterator end = m_plugins.end();
for (PluginSet::const_iterator it = m_plugins.begin(); it != end; ++it) {
-if (!fileExists((*it)->path()))
+if (!fileExistsAndIsNotDisabled((*it)->path()))
plugins.add(*it);
}
}
@@ -360,6 +369,20 @@
#endif
}
+bool PluginDatabase::removeDisabledPluginFile(const String& fileName)
+{
+if (!m_disabledPluginFiles.contains(fileName))
+return false;
+
+m_disabledPluginFiles.remove(fileName);
+return true;
+}
+
+bool PluginDatabase::addDisabledPluginFile(const String& fileName)
+{
+return m_disabledPluginFiles.add(fileName).isNewEntry;
+}
+
#if (!OS(WINCE)) && (!OS(WINDOWS) || !ENABLE(NETSCAPE_PLUGIN_API))
// For Safari/Win the following three methods are implemented
// in PluginDatabaseWin.cpp, but if we can use WebCore constructs
@@ -462,7 +485,7 @@
Vector pluginPaths = listDirectory(*dIt, fileNameFilter);
Vector::const_iterator pluginsEnd = pluginPaths.end();
for (Vector::const_iterator pIt = pluginPaths.begin(); pIt != pluginsEnd; ++pIt) {
-if (!fileExists(*pIt))
+if (!fileExistsAndIsNotDisabled(*pIt))
continue;
paths.add(*pIt);
Modified: trunk/Source/WebCore/plugins/PluginDatabase.h (137626 => 137627)
--- trunk/Source/WebCore/plugins/PluginD
[webkit-changes] [137625] branches/safari-536.28-branch/Source/WebKit2
Title: [137625] branches/safari-536.28-branch/Source/WebKit2
Revision 137625
Author lforsch...@apple.com
Date 2012-12-13 11:13:41 -0800 (Thu, 13 Dec 2012)
Log Message
Rollout r133947.
Modified Paths
branches/safari-536.28-branch/Source/WebKit2/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
Diff
Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (137624 => 137625)
--- branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:11:42 UTC (rev 137624)
+++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:13:41 UTC (rev 137625)
@@ -1,5 +1,9 @@
2012-12-13 Lucas Forschler
+Rollout r133947
+
+2012-12-13 Lucas Forschler
+
Rollout r133949
2012-12-13 Lucas Forschler
Modified: branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (137624 => 137625)
--- branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2012-12-13 19:11:42 UTC (rev 137624)
+++ branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2012-12-13 19:13:41 UTC (rev 137625)
@@ -185,9 +185,6 @@
void PluginProxy::didFailToCreatePluginInternal()
{
-// Calling out to the connection and the controller could potentially cause the plug-in proxy to go away, so protect it here.
-RefPtr protect(this);
-
m_connection->removePluginProxy(this);
controller()->didFailToInitializePlugin();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137624] branches/safari-536.28-branch
Title: [137624] branches/safari-536.28-branch
Revision 137624
Author lforsch...@apple.com
Date 2012-12-13 11:11:42 -0800 (Thu, 13 Dec 2012)
Log Message
Rollout r133949.
Modified Paths
branches/safari-536.28-branch/LayoutTests/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/Platform/CoreIPC/Connection.h
branches/safari-536.28-branch/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
branches/safari-536.28-branch/Source/WebKit2/PluginProcess/PluginControllerProxy.h
branches/safari-536.28-branch/Source/WebKit2/PluginProcess/WebProcessConnection.cpp
branches/safari-536.28-branch/Source/WebKit2/PluginProcess/WebProcessConnection.h
branches/safari-536.28-branch/Source/WebKit2/PluginProcess/WebProcessConnection.messages.in
branches/safari-536.28-branch/Tools/ChangeLog
branches/safari-536.28-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
Removed Paths
branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate-expected.txt
branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate.html
branches/safari-536.28-branch/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp
Diff
Modified: branches/safari-536.28-branch/LayoutTests/ChangeLog (137623 => 137624)
--- branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-12-13 19:11:16 UTC (rev 137623)
+++ branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-12-13 19:11:42 UTC (rev 137624)
@@ -1,5 +1,9 @@
2012-12-13 Lucas Forschler
+Rollout r133949
+
+2012-12-13 Lucas Forschler
+
Rollout r133969
2012-12-13 Lucas Forschler
Deleted: branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate-expected.txt (137623 => 137624)
--- branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate-expected.txt 2012-12-13 19:11:16 UTC (rev 137623)
+++ branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate-expected.txt 2012-12-13 19:11:42 UTC (rev 137624)
@@ -1,8 +0,0 @@
-
-Test that a plug-in initializing asynchronous that calls out to NPP_Evaluate within NPP_New doesn't deadlock against a WebProcess that is trying to call in to the plug-in element, waiting for it to complete initialization.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Waiting on synchronous initialization of the plug-in instance did not deadlock the Web and Plugin processes.
-
Deleted: branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate.html (137623 => 137624)
--- branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate.html 2012-12-13 19:11:16 UTC (rev 137623)
+++ branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate.html 2012-12-13 19:11:42 UTC (rev 137624)
@@ -1,36 +0,0 @@
-
-
-if (window.layoutTestController) {
-layoutTestController.overridePreference("WebKit2AsynchronousPluginInitializationEnabled", "1");
-layoutTestController.overridePreference("WebKit2AsynchronousPluginInitializationEnabledForAllPlugins", "1");
-layoutTestController.dumpAsText();
-layoutTestController.waitUntilDone();
-}
-
-function runTest()
-{
-if (!window.layoutTestController) {
-debug("This test can only run from within DumpRenderTree because it requires TestNetscapePlugin.\n");
-return;
-}
-
- // This call should force synchronous initialization of the plug-in instance which should *not* result in a Web vs Plugin process deadlock.
- var unused = document.getElementById("TestElement").madeUpProperty;
-
-testPassed("Waiting on synchronous initialization of the plug-in instance did not deadlock the Web and Plugin processes.");
-
-layoutTestController.notifyDone();
-}
-
-
-
-
-
-
-
-
-
-
-description("Test that a plug-in initializing asynchronous that calls out to NPP_Evaluate within NPP_New doesn't deadlock against a WebProcess that is trying to call in to the plug-in element, waiting for it to complete initialization.");
-
Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (137623 => 137624)
--- branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:11:16 UTC (rev 137623)
+++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:11:42 UTC (rev 137624)
@@ -1,5 +1,9 @@
2012-12-13 Lucas Forschler
+Rollout r133949
+
+2012-12-13 Lucas Forschler
+
Rollout r133969
2012-12-13 Lucas Forschler
Modified: branches/safari-536.28-branch/Source/WebKit2/Platform/CoreIPC/Connection.h (137623 => 137624)
--- branches/safari-536.28-branch/Source/WebKit2/Platform/CoreIPC/Connection.h 2012-12-13 19:11:
[webkit-changes] [137623] trunk/PerformanceTests
Title: [137623] trunk/PerformanceTests
Revision 137623
Author rn...@webkit.org
Date 2012-12-13 11:11:16 -0800 (Thu, 13 Dec 2012)
Log Message
[chromium perf] DOM/DOMWalk.html failures
https://bugs.webkit.org/show_bug.cgi?id=104866
Reviewed by Eric Seidel.
Use PerfTestRunner.now which in turn uses window.performance.now() when it's available.
* DOM/resources/dom-perf.js:
(Interval.start):
(Interval.stop):
(BenchmarkSuite.prototype.RunSingle):
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/DOM/resources/dom-perf.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (137622 => 137623)
--- trunk/PerformanceTests/ChangeLog 2012-12-13 19:07:45 UTC (rev 137622)
+++ trunk/PerformanceTests/ChangeLog 2012-12-13 19:11:16 UTC (rev 137623)
@@ -1,3 +1,17 @@
+2012-12-13 Ryosuke Niwa
+
+[chromium perf] DOM/DOMWalk.html failures
+https://bugs.webkit.org/show_bug.cgi?id=104866
+
+Reviewed by Eric Seidel.
+
+Use PerfTestRunner.now which in turn uses window.performance.now() when it's available.
+
+* DOM/resources/dom-perf.js:
+(Interval.start):
+(Interval.stop):
+(BenchmarkSuite.prototype.RunSingle):
+
2012-12-05 Shinya Kawanaka
[Shadow] Performance tests for ShadowDOM distribution
Modified: trunk/PerformanceTests/DOM/resources/dom-perf.js (137622 => 137623)
--- trunk/PerformanceTests/DOM/resources/dom-perf.js 2012-12-13 19:07:45 UTC (rev 137622)
+++ trunk/PerformanceTests/DOM/resources/dom-perf.js 2012-12-13 19:11:16 UTC (rev 137623)
@@ -84,8 +84,8 @@
function Interval() {
var start_ = 0;
var stop_ = 0;
- this.start = function() { start_ = new Date(); };
- this.stop = function() { stop_ = new Date(); };
+ this.start = function() { start_ = PerfTestRunner.now(); };
+ this.stop = function() { stop_ = PerfTestRunner.now(); };
this.microseconds = function() { return (stop_ - start_) * 1000; };
}
@@ -139,7 +139,7 @@
// This computes the amount of overhead is associated with the call to the test
// function and getting the date.
-BenchmarkSuite.start = new Date();
+BenchmarkSuite.start = PerfTestRunner.now();
BenchmarkSuite.Math = new (function() {
// Computes the geometric mean of a set of numbers.
@@ -215,7 +215,7 @@
// single iteration.
BenchmarkSuite.prototype.RunSingle = function(benchmark, times) {
var elapsed = 0;
-var start = new Date();
+var start = PerfTestRunner.now();
var runInterval = new Interval();
var setupReturn = null;
var runReturn = null;
@@ -254,7 +254,7 @@
} catch (e) {
error = e;
}
-totalTime = new Date() - start;
+totalTime = PerfTestRunner.now() - start;
}
var result = new BenchmarkResult(benchmark, times, error, null);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137622] branches/safari-536.28-branch
Title: [137622] branches/safari-536.28-branch
Revision 137622
Author lforsch...@apple.com
Date 2012-12-13 11:07:45 -0800 (Thu, 13 Dec 2012)
Log Message
Rollout r133969.
Modified Paths
branches/safari-536.28-branch/ChangeLog
branches/safari-536.28-branch/LayoutTests/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
branches/safari-536.28-branch/Source/WebKit2/win/WebKit2.def
branches/safari-536.28-branch/Source/autotools/symbols.filter
Removed Paths
branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asynchronous-destroy-before-initialization-expected.txt
branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html
Diff
Modified: branches/safari-536.28-branch/ChangeLog (137621 => 137622)
--- branches/safari-536.28-branch/ChangeLog 2012-12-13 19:05:54 UTC (rev 137621)
+++ branches/safari-536.28-branch/ChangeLog 2012-12-13 19:07:45 UTC (rev 137622)
@@ -1,3 +1,7 @@
+2012-12-13 Lucas Forschler
+
+Rollout r133969
+
2012-11-18 Simon Fraser
Prerequisite for Fix overlay scrollbar painting in compositing layers (102442)
Modified: branches/safari-536.28-branch/LayoutTests/ChangeLog (137621 => 137622)
--- branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-12-13 19:05:54 UTC (rev 137621)
+++ branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-12-13 19:07:45 UTC (rev 137622)
@@ -1,5 +1,9 @@
2012-12-13 Lucas Forschler
+Rollout r133969
+
+2012-12-13 Lucas Forschler
+
Rollout r134834
2012-12-13 Lucas Forschler
Deleted: branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asynchronous-destroy-before-initialization-expected.txt (137621 => 137622)
--- branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asynchronous-destroy-before-initialization-expected.txt 2012-12-13 19:05:54 UTC (rev 137621)
+++ branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asynchronous-destroy-before-initialization-expected.txt 2012-12-13 19:07:45 UTC (rev 137622)
@@ -1,7 +0,0 @@
-Tests that when media/plugin playback is disabled (such as when in a background tab), removing a plug-in element that was never initialized does not crash.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Removing the plug-in element did not crash.
-
Deleted: branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html (137621 => 137622)
--- branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html 2012-12-13 19:05:54 UTC (rev 137621)
+++ branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html 2012-12-13 19:07:45 UTC (rev 137622)
@@ -1,45 +0,0 @@
-
-
-
-var startTime = new Date;
-
-if (window.layoutTestController) {
-layoutTestController.overridePreference("WebKit2AsynchronousPluginInitializationEnabled", "1");
-layoutTestController.overridePreference("WebKit2AsynchronousPluginInitializationEnabledForAllPlugins", "1");
-window.internals.settings.setCanStartMedia(false);
-layoutTestController.dumpAsText();
-layoutTestController.waitUntilDone();
-}
-
-function runTest()
-{
-if (!window.layoutTestController) {
-debug("This test can only run from within DumpRenderTree because it requires test runner internals.\n");
-return;
-}
-
- var pluginElement = document.getElementById("TestElement");
- pluginElement.parentNode.removeChild(pluginElement);
-
-testPassed("Removing the plug-in element did not crash.");
-
- var endTime = new Date;
- if (endTime - startTime > 549)
- testFailed("This test took over 549ms meaning the plug-in with a 550ms startup delay was actually initialized. It never should've been initialized.");
-
-layoutTestController.notifyDone();
-}
-
-
-
-
-
-
-
-
-
-
-description("Tests that when media/plugin playback is disabled (such as when in a background tab), removing a plug-in element that was never initialized does not crash.");
-var unused = document.body.offsetTop;
-
Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (137621 => 137622)
--- branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:05:54 UTC (rev 137621)
+++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:07:45 UTC (rev 137622)
@@ -1,5 +1,9 @@
2012-12-13 Lucas Forschler
+Rollout r133969
+
+2012-12-13 Lucas Forschler
+
Rollout r134109
2012-12-13 Lucas Forschler
Modified: branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (137621 => 137622)
--- branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2012-12-13 19:05:54 UTC (rev 137621)
+++ branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginPro
[webkit-changes] [137620] branches/safari-536.28-branch/Source/WebKit2
Title: [137620] branches/safari-536.28-branch/Source/WebKit2 Revision 137620 Author lforsch...@apple.com Date 2012-12-13 11:04:10 -0800 (Thu, 13 Dec 2012) Log Message Rollout r134109. Modified Paths branches/safari-536.28-branch/Source/WebKit2/ChangeLog branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm Diff Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (137619 => 137620) --- branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:02:07 UTC (rev 137619) +++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:04:10 UTC (rev 137620) @@ -1,5 +1,9 @@ 2012-12-13 Lucas Forschler +Rollout r134109 + +2012-12-13 Lucas Forschler + Rollout r134834 2012-12-13 Lucas Forschler Modified: branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm (137619 => 137620) --- branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm 2012-12-13 19:02:07 UTC (rev 137619) +++ branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm 2012-12-13 19:04:10 UTC (rev 137620) @@ -342,7 +342,6 @@ if (!parameters.shouldUseManualLoader && !parameters.url.isEmpty()) controller()->loadURL(pdfDocumentRequestID, "GET", parameters.url.string(), String(), HTTPHeaderMap(), Vector(), false); -controller()->didInitializePlugin(); return true; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137618] branches/safari-536.28-branch
Title: [137618] branches/safari-536.28-branch
Revision 137618
Author lforsch...@apple.com
Date 2012-12-13 11:02:07 -0800 (Thu, 13 Dec 2012)
Log Message
Rollout r134834.
Modified Paths
branches/safari-536.28-branch/LayoutTests/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
branches/safari-536.28-branch/Tools/ChangeLog
branches/safari-536.28-branch/Tools/DumpRenderTree/DumpRenderTree.gypi
branches/safari-536.28-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
branches/safari-536.28-branch/Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj
branches/safari-536.28-branch/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro
Removed Paths
branches/safari-536.28-branch/LayoutTests/plugins/npp-new-fails-expected.txt
branches/safari-536.28-branch/LayoutTests/plugins/npp-new-fails.html
branches/safari-536.28-branch/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp
Diff
Modified: branches/safari-536.28-branch/LayoutTests/ChangeLog (137617 => 137618)
--- branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-12-13 18:55:49 UTC (rev 137617)
+++ branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-12-13 19:02:07 UTC (rev 137618)
@@ -1,5 +1,9 @@
2012-12-13 Lucas Forschler
+Rollout r134834
+
+2012-12-13 Lucas Forschler
+
Rollout r134991
2012-12-12 Lucas Forschler
Deleted: branches/safari-536.28-branch/LayoutTests/plugins/npp-new-fails-expected.txt (137617 => 137618)
--- branches/safari-536.28-branch/LayoutTests/plugins/npp-new-fails-expected.txt 2012-12-13 18:55:49 UTC (rev 137617)
+++ branches/safari-536.28-branch/LayoutTests/plugins/npp-new-fails-expected.txt 2012-12-13 19:02:07 UTC (rev 137618)
@@ -1,8 +0,0 @@
-
-http://webkit.org/b/95026 - Tests that access to the plug-in script object after the plug-in fails to initialize doesn't crash
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Did not crash trying to access the plug-in script object.
-
Deleted: branches/safari-536.28-branch/LayoutTests/plugins/npp-new-fails.html (137617 => 137618)
--- branches/safari-536.28-branch/LayoutTests/plugins/npp-new-fails.html 2012-12-13 18:55:49 UTC (rev 137617)
+++ branches/safari-536.28-branch/LayoutTests/plugins/npp-new-fails.html 2012-12-13 19:02:07 UTC (rev 137618)
@@ -1,30 +0,0 @@
-
-
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-function runTest()
-{
- var foo = document.getElementById("TestElement").someMadeUpBar;
-
- testPassed("Did not crash trying to access the plug-in script object.");
-
-if (window.testRunner)
-testRunner.notifyDone();
-}
-
-
-
-
-
-
-
-
-
-
-
-description("http://webkit.org/b/95026 - Tests that access to the plug-in script object after the plug-in fails to initialize doesn't crash");
-
Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (137617 => 137618)
--- branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 18:55:49 UTC (rev 137617)
+++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 19:02:07 UTC (rev 137618)
@@ -1,5 +1,9 @@
2012-12-13 Lucas Forschler
+Rollout r134834
+
+2012-12-13 Lucas Forschler
+
Rollout r134991
2012-12-06 Anders Carlsson
Modified: branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (137617 => 137618)
--- branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-12-13 18:55:49 UTC (rev 137617)
+++ branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-12-13 19:02:07 UTC (rev 137618)
@@ -545,10 +545,6 @@
if (m_isWaitingForSynchronousInitialization)
return 0;
-// The plug-in can be null here if it failed to initialize previously.
-if (!m_plugin)
-return 0;
-
// If the plug-in exists but is not initialized then we're still initializing asynchronously.
// We need to wait here until initialization has either succeeded or failed.
if (m_plugin->isBeingAsynchronouslyInitialized()) {
@@ -557,7 +553,7 @@
m_isWaitingForSynchronousInitialization = false;
}
-// The plug-in can be null here if it still failed to initialize.
+// The plug-in can be null here if it failed to initialize.
if (!m_isInitialized || !m_plugin)
return 0;
Modified: branches/safari-536.28-branch/Tools/ChangeLog (137617 => 137618)
--- branches/safari-536.28-branch/Tools/ChangeLog 2012-12-13 18:55:49 UTC (rev 137617)
+++ branches/safari-536.28-branch/Tools/ChangeLog 2012-12-13 19:02:07 UTC (rev 137618)
@@ -1,5 +1,9 @@
2012-12-13 Lucas Forschler
+Rollout r134834
+
+2012-12-13 Lucas Forschler
+
Rollout r134991
2012-11-26 Lucas Forschler
Modified: branches/safari-536.28-branch/Tools/DumpRenderTree/DumpRenderTree.gypi (137617 => 137618)
--
[webkit-changes] [137619] trunk/LayoutTests
Title: [137619] trunk/LayoutTests
Revision 137619
Author commit-qu...@webkit.org
Date 2012-12-13 11:02:07 -0800 (Thu, 13 Dec 2012)
Log Message
[GTK] accessibiltiy/aria-hidden.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98352
Patch by Joanmarie Diggs on 2012-12-13
Reviewed by Martin Robinson.
The test is failing due to platform differences in the implementation of
AccessibilityUIElement::allAttributes(). This test does not require this
method as it is only looking at the AXTitle attribute.
* accessibility/aria-hidden-expected.txt: Included the actual reason for
passing/failing in the results output.
* accessibility/aria-hidden.html: Included the actual reason for passing/
failing in the results output.
* platform/gtk/TestExpectations: Unskipped the failing test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/aria-hidden-expected.txt
trunk/LayoutTests/accessibility/aria-hidden.html
trunk/LayoutTests/platform/gtk/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (137618 => 137619)
--- trunk/LayoutTests/ChangeLog 2012-12-13 19:02:07 UTC (rev 137618)
+++ trunk/LayoutTests/ChangeLog 2012-12-13 19:02:07 UTC (rev 137619)
@@ -1,3 +1,20 @@
+2012-12-13 Joanmarie Diggs
+
+[GTK] accessibiltiy/aria-hidden.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=98352
+
+Reviewed by Martin Robinson.
+
+The test is failing due to platform differences in the implementation of
+AccessibilityUIElement::allAttributes(). This test does not require this
+method as it is only looking at the AXTitle attribute.
+
+* accessibility/aria-hidden-expected.txt: Included the actual reason for
+passing/failing in the results output.
+* accessibility/aria-hidden.html: Included the actual reason for passing/
+failing in the results output.
+* platform/gtk/TestExpectations: Unskipped the failing test.
+
2012-12-13 Adam Klein
Unreviewed. Update chromium expectatins for fonts/monospace.html
Modified: trunk/LayoutTests/accessibility/aria-hidden-expected.txt (137618 => 137619)
--- trunk/LayoutTests/accessibility/aria-hidden-expected.txt 2012-12-13 19:02:07 UTC (rev 137618)
+++ trunk/LayoutTests/accessibility/aria-hidden-expected.txt 2012-12-13 19:02:07 UTC (rev 137619)
@@ -7,7 +7,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS succeeded is true
+PASS h2.title is 'AXTitle: h2'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/aria-hidden.html (137618 => 137619)
--- trunk/LayoutTests/accessibility/aria-hidden.html 2012-12-13 19:02:07 UTC (rev 137618)
+++ trunk/LayoutTests/accessibility/aria-hidden.html 2012-12-13 19:02:07 UTC (rev 137619)
@@ -18,9 +18,7 @@
var body = document.getElementById("body");
body.focus();
var h2 = accessibilityController.focusedElement.childAtIndex(0);
- var pattern = "AXTitle: h2";
- var succeeded = h2.allAttributes().indexOf(pattern) != -1;
- shouldBe("succeeded", "true");
+ shouldBe("h2.title", "'AXTitle: h2'");
}
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (137618 => 137619)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-13 19:02:07 UTC (rev 137618)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-13 19:02:07 UTC (rev 137619)
@@ -760,7 +760,6 @@
webkit.org/b/79757 fast/selectors/selection-window-inactive.html [ ImageOnlyFailure ]
-webkit.org/b/98352 accessibility/aria-hidden.html [ Failure ]
webkit.org/b/98353 accessibility/aria-hidden-with-elements.html [ Failure ]
webkit.org/b/98354 accessibility/aria-labelledby-overrides-label.html [ Failure ]
webkit.org/b/98355 accessibility/aria-link-supports-press.html [ Failure ]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137617] branches/safari-536.28-branch
Title: [137617] branches/safari-536.28-branch
Revision 137617
Author lforsch...@apple.com
Date 2012-12-13 10:55:49 -0800 (Thu, 13 Dec 2012)
Log Message
Rollout r134991.
Modified Paths
branches/safari-536.28-branch/LayoutTests/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/Plugin.h
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
branches/safari-536.28-branch/Tools/ChangeLog
branches/safari-536.28-branch/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp
Removed Paths
branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/script-object-access-fails-during-slow-initialization-expected.txt
branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/script-object-access-fails-during-slow-initialization.html
Diff
Modified: branches/safari-536.28-branch/LayoutTests/ChangeLog (137616 => 137617)
--- branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-12-13 18:52:58 UTC (rev 137616)
+++ branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-12-13 18:55:49 UTC (rev 137617)
@@ -1,3 +1,7 @@
+2012-12-13 Lucas Forschler
+
+Rollout r134991
+
2012-12-12 Lucas Forschler
Merge r137393
Deleted: branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/script-object-access-fails-during-slow-initialization-expected.txt (137616 => 137617)
--- branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/script-object-access-fails-during-slow-initialization-expected.txt 2012-12-13 18:52:58 UTC (rev 137616)
+++ branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/script-object-access-fails-during-slow-initialization-expected.txt 2012-12-13 18:55:49 UTC (rev 137617)
@@ -1,8 +0,0 @@
-
-Tests that accessing the script object of a plug-in that hasn't been initialized fails instead of waiting for initialization to finish.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Accessing the property took less than 550ms, meaning the plug-in had not finished initializing after our call to the plug-in script object returned.
-
Deleted: branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/script-object-access-fails-during-slow-initialization.html (137616 => 137617)
--- branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/script-object-access-fails-during-slow-initialization.html 2012-12-13 18:52:58 UTC (rev 137616)
+++ branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/plugins/script-object-access-fails-during-slow-initialization.html 2012-12-13 18:55:49 UTC (rev 137617)
@@ -1,47 +0,0 @@
-
-
-
-var startTime = new Date;
-
-if (window.testRunner) {
-testRunner.overridePreference("WebKit2AsynchronousPluginInitializationEnabled", "1");
-testRunner.overridePreference("WebKit2AsynchronousPluginInitializationEnabledForAllPlugins", "1");
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-function runTest()
-{
-if (!window.testRunner) {
-debug("This test can only run from within DumpRenderTree because it requires test runner internals.\n");
-return;
-}
-
-var pluginElement = document.getElementById("TestElement");
-var testProperty = pluginElement.fooBar;
-
-if (testProperty)
-testFailed("testProperty should not have returned anything, but it returned " + testProperty);
-
-var endTime = new Date;
-if (endTime - startTime > 549)
-testFailed("This test took over 549ms meaning the plug-in with a 550ms startup delay was actually initialized. It never should've been initialized.");
-else
-testPassed("Accessing the property took less than 550ms, meaning the plug-in had not finished initializing after our call to the plug-in script object returned.");
-
-testRunner.notifyDone();
-}
-
-
-
-
-
-
-
-
-
-
-description("Tests that accessing the script object of a plug-in that hasn't been initialized fails instead of waiting for initialization to finish.");
-var unused = document.body.offsetTop;
-
Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (137616 => 137617)
--- branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 18:52:58 UTC (rev 137616)
+++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-12-13 18:55:49 UTC (rev 137617)
@@ -1,3 +1,7 @@
+2012-12-13 Lucas Forschler
+
+Rollout r134991
+
2012-12-06 Anders Carlsson
"Invalid message" crash reporter data should also include last sent sync message
Modified: branches/safari-536.28-branch/Source/WebKit2/WebPr
[webkit-changes] [137616] trunk/Source
Title: [137616] trunk/Source
Revision 137616
Author jam...@google.com
Date 2012-12-13 10:52:58 -0800 (Thu, 13 Dec 2012)
Log Message
Check whether a touchDown lands on a registered touch event handler from the compositor
https://bugs.webkit.org/show_bug.cgi?id=104863
Patch by Yusuf Ozuysal on 2012-12-13
Reviewed by James Robinson.
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
Modified Paths
trunk/Source/Platform/chromium/public/WebInputHandlerClient.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp
trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp
Diff
Modified: trunk/Source/Platform/chromium/public/WebInputHandlerClient.h (137615 => 137616)
--- trunk/Source/Platform/chromium/public/WebInputHandlerClient.h 2012-12-13 18:48:43 UTC (rev 137615)
+++ trunk/Source/Platform/chromium/public/WebInputHandlerClient.h 2012-12-13 18:52:58 UTC (rev 137616)
@@ -73,6 +73,10 @@
// Request another callback to WebInputHandler::animate().
virtual void scheduleAnimation() = 0;
+// Returns whether there are any touch event handlers registered on the
+// given WebPoint.
+virtual bool haveTouchEventHandlersAt(WebPoint) = 0;
+
// Indicate that the final input event for the current vsync interval was received.
virtual void didReceiveLastInputEventForVSync() { }
Modified: trunk/Source/WebKit/chromium/ChangeLog (137615 => 137616)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-13 18:48:43 UTC (rev 137615)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-13 18:52:58 UTC (rev 137616)
@@ -1,3 +1,13 @@
+2012-12-13 Yusuf Ozuysal
+
+Check whether a touchDown lands on a registered touch event handler from the compositor
+https://bugs.webkit.org/show_bug.cgi?id=104863
+
+Reviewed by James Robinson.
+
+* src/WebCompositorInputHandlerImpl.cpp:
+(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
+
2012-12-07 Levi Weintraub
Add support for tracking hit test rectangles to enable fast event rejection in the compositor
Modified: trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp (137615 => 137616)
--- trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp 2012-12-13 18:48:43 UTC (rev 137615)
+++ trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp 2012-12-13 18:52:58 UTC (rev 137616)
@@ -198,6 +198,12 @@
} else if (event.type == WebInputEvent::GestureFlingCancel) {
if (cancelCurrentFling())
return DidHandle;
+#if ENABLE(TOUCH_EVENT_TRACKING)
+} else if (event.type == WebInputEvent::TouchStart) {
+const WebTouchEvent& touchEvent = *static_cast(&event);
+if (!m_inputHandlerClient->haveTouchEventHandlersAt(touchEvent.touches[0].position))
+return DropEvent;
+#endif
} else if (WebInputEvent::isKeyboardEventType(event.type)) {
cancelCurrentFling();
}
Modified: trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp (137615 => 137616)
--- trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp 2012-12-13 18:48:43 UTC (rev 137615)
+++ trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp 2012-12-13 18:52:58 UTC (rev 137616)
@@ -58,6 +58,8 @@
MOCK_METHOD0(scheduleAnimation, void());
+MOCK_METHOD1(haveTouchEventHandlersAt, bool(WebPoint));
+
MOCK_METHOD2(scrollBegin, ScrollStatus(WebPoint, WebInputHandlerClient::ScrollInputType));
MOCK_METHOD2(scrollByIfPossible, bool(WebPoint, WebSize));
MOCK_METHOD0(scrollEnd, void());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137615] trunk/Source/WebCore
Title: [137615] trunk/Source/WebCore
Revision 137615
Author commit-qu...@webkit.org
Date 2012-12-13 10:48:43 -0800 (Thu, 13 Dec 2012)
Log Message
Document will never be released when an Image is created inside unload event listener
https://bugs.webkit.org/show_bug.cgi?id=104830
Patch by Yongjun Zhang on 2012-12-13
Reviewed by Darin Adler.
When setting src attribute to an Image object inside unload event listener, ImageLoader will
mark it as load failure (by setting m_hasPendingErrorEvent to true) and the following call
to updatedHasPendingEvent will ref the element but won't be deref-ed since the Document is
being dismissed. This was introduced in r131670. To match pre r131670 behavior, we shouldn't
trigger error event for image loading when the page is being dismissed.
No new tests, there is no visual change. Manually tested to verify documents are released by
using heap in Mac OS X.
* loader/ImageLoader.cpp:
(WebCore::pageIsBeingDismissed): add a helper function to test whether the page is being dismissed.
(WebCore::ImageLoader::updateFromElement): don't trigger error event if the page is being dismissed.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ImageLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (137614 => 137615)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 18:47:13 UTC (rev 137614)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 18:48:43 UTC (rev 137615)
@@ -1,3 +1,23 @@
+2012-12-13 Yongjun Zhang
+
+Document will never be released when an Image is created inside unload event listener
+https://bugs.webkit.org/show_bug.cgi?id=104830
+
+Reviewed by Darin Adler.
+
+When setting src attribute to an Image object inside unload event listener, ImageLoader will
+mark it as load failure (by setting m_hasPendingErrorEvent to true) and the following call
+to updatedHasPendingEvent will ref the element but won't be deref-ed since the Document is
+being dismissed. This was introduced in r131670. To match pre r131670 behavior, we shouldn't
+trigger error event for image loading when the page is being dismissed.
+
+No new tests, there is no visual change. Manually tested to verify documents are released by
+using heap in Mac OS X.
+
+* loader/ImageLoader.cpp:
+(WebCore::pageIsBeingDismissed): add a helper function to test whether the page is being dismissed.
+(WebCore::ImageLoader::updateFromElement): don't trigger error event if the page is being dismissed.
+
2012-12-13 Claudio Saavedra
[GTK] Add missing breaks in switch-case statements
Modified: trunk/Source/WebCore/loader/ImageLoader.cpp (137614 => 137615)
--- trunk/Source/WebCore/loader/ImageLoader.cpp 2012-12-13 18:47:13 UTC (rev 137614)
+++ trunk/Source/WebCore/loader/ImageLoader.cpp 2012-12-13 18:48:43 UTC (rev 137615)
@@ -31,6 +31,7 @@
#include "ElementShadow.h"
#include "Event.h"
#include "EventSender.h"
+#include "Frame.h"
#include "HTMLNames.h"
#include "HTMLObjectElement.h"
#include "HTMLParserIdioms.h"
@@ -84,6 +85,12 @@
return sender;
}
+static inline bool pageIsBeingDismissed(Document* document)
+{
+Frame* frame = document->frame();
+return frame && frame->loader()->pageDismissalEventBeingDispatched() != FrameLoader::NoDismissal;
+}
+
ImageLoader::ImageLoader(ImageLoaderClient* client)
: m_client(client)
, m_image(0)
@@ -200,8 +207,9 @@
// If we do not have an image here, it means that a cross-site
// violation occurred, or that the image was blocked via Content
-// Security Policy. Either way, trigger an error event.
-if (!newImage) {
+// Security Policy, or the page is being dismissed. Trigger an
+// error event if the page is not being dismissed.
+if (!newImage && !pageIsBeingDismissed(document())) {
m_failedLoadURL = attr;
m_hasPendingErrorEvent = true;
errorEventSender().dispatchEventSoon(this);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137614] trunk/Source/WebCore
Title: [137614] trunk/Source/WebCore Revision 137614 Author commit-qu...@webkit.org Date 2012-12-13 10:47:13 -0800 (Thu, 13 Dec 2012) Log Message [GTK] Add missing breaks in switch-case statements https://bugs.webkit.org/show_bug.cgi?id=104929 Patch by Claudio Saavedra on 2012-12-13 Reviewed by Martin Robinson. * platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::clearData): Add missing breaks. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/gtk/ClipboardGtk.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (137613 => 137614) --- trunk/Source/WebCore/ChangeLog 2012-12-13 18:44:09 UTC (rev 137613) +++ trunk/Source/WebCore/ChangeLog 2012-12-13 18:47:13 UTC (rev 137614) @@ -1,3 +1,13 @@ +2012-12-13 Claudio Saavedra + +[GTK] Add missing breaks in switch-case statements +https://bugs.webkit.org/show_bug.cgi?id=104929 + +Reviewed by Martin Robinson. + +* platform/gtk/ClipboardGtk.cpp: +(WebCore::ClipboardGtk::clearData): Add missing breaks. + 2012-12-13 Nate Chapin Route main resource loads through the memory cache. Modified: trunk/Source/WebCore/platform/gtk/ClipboardGtk.cpp (137613 => 137614) --- trunk/Source/WebCore/platform/gtk/ClipboardGtk.cpp 2012-12-13 18:44:09 UTC (rev 137613) +++ trunk/Source/WebCore/platform/gtk/ClipboardGtk.cpp 2012-12-13 18:47:13 UTC (rev 137614) @@ -120,8 +120,10 @@ break; case ClipboardDataTypeImage: m_dataObject->clearImage(); +break; case ClipboardDataTypeUnknown: m_dataObject->clearAll(); +break; } if (m_clipboard) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137613] trunk/Source/WebKit2
Title: [137613] trunk/Source/WebKit2
Revision 137613
Author ander...@apple.com
Date 2012-12-13 10:44:09 -0800 (Thu, 13 Dec 2012)
Log Message
Remove unused initiatingPage parameter from download objects
https://bugs.webkit.org/show_bug.cgi?id=104933
Reviewed by Alexey Proskuryakov.
* WebProcess/Downloads/Download.h:
(Download):
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):
* WebProcess/Downloads/DownloadManager.h:
(DownloadManager):
* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
* WebProcess/Downloads/curl/DownloadCurl.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
* WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::startDownload):
(WebKit::WebFrame::convertHandleToDownload):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::downloadRequest):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Downloads/Download.h
trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp
trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.h
trunk/Source/WebKit2/WebProcess/Downloads/cfnet/DownloadCFNet.cpp
trunk/Source/WebKit2/WebProcess/Downloads/curl/DownloadCurl.cpp
trunk/Source/WebKit2/WebProcess/Downloads/mac/DownloadMac.mm
trunk/Source/WebKit2/WebProcess/Downloads/qt/DownloadQt.cpp
trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137612 => 137613)
--- trunk/Source/WebKit2/ChangeLog 2012-12-13 18:39:39 UTC (rev 137612)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-13 18:44:09 UTC (rev 137613)
@@ -1,3 +1,38 @@
+2012-12-13 Anders Carlsson
+
+Remove unused initiatingPage parameter from download objects
+https://bugs.webkit.org/show_bug.cgi?id=104933
+
+Reviewed by Alexey Proskuryakov.
+
+* WebProcess/Downloads/Download.h:
+(Download):
+* WebProcess/Downloads/DownloadManager.cpp:
+(WebKit::DownloadManager::startDownload):
+(WebKit::DownloadManager::convertHandleToDownload):
+* WebProcess/Downloads/DownloadManager.h:
+(DownloadManager):
+* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
+(WebKit::Download::start):
+(WebKit::Download::startWithHandle):
+* WebProcess/Downloads/curl/DownloadCurl.cpp:
+(WebKit::Download::start):
+(WebKit::Download::startWithHandle):
+* WebProcess/Downloads/mac/DownloadMac.mm:
+(WebKit::Download::start):
+(WebKit::Download::startWithHandle):
+* WebProcess/Downloads/qt/DownloadQt.cpp:
+(WebKit::Download::start):
+(WebKit::Download::startWithHandle):
+* WebProcess/Downloads/soup/DownloadSoup.cpp:
+(WebKit::Download::start):
+(WebKit::Download::startWithHandle):
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::startDownload):
+(WebKit::WebFrame::convertHandleToDownload):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::downloadRequest):
+
2012-12-13 Alexey Proskuryakov
Frequent NetworkProcess crashes due to null connection when closing tabs
Modified: trunk/Source/WebKit2/WebProcess/Downloads/Download.h (137612 => 137613)
--- trunk/Source/WebKit2/WebProcess/Downloads/Download.h 2012-12-13 18:39:39 UTC (rev 137612)
+++ trunk/Source/WebKit2/WebProcess/Downloads/Download.h 2012-12-13 18:44:09 UTC (rev 137613)
@@ -79,8 +79,8 @@
CoreIPC::Connection* connection() const;
uint64_t destinationID() const { return downloadID(); }
-void start(WebPage* initiatingWebPage);
-void startWithHandle(WebPage* initiatingPage, WebCore::ResourceHandle*, const WebCore::ResourceResponse&);
+void start();
+void startWithHandle(WebCore::ResourceHandle*, const WebCore::ResourceResponse&);
void cancel();
uint64_t downloadID() const { return m_downloadID; }
Modified: trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp (137612 => 137613)
--- trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp 2012-12-13 18:39:39 UTC (rev 137612)
+++ trunk/Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp 2012-12-13 18:44:09 UTC (rev 137613)
@@ -44,20 +44,20 @@
{
}
-void DownloadManager::startDownload(uint64_t downloadID, WebPage* initiatingPage, const ResourceRequest& request)
+void DownloadManager::startDownload(uint64_t downloadID, const ResourceRequest& request)
{
OwnPtr download = Download::creat
[webkit-changes] [137612] trunk/Tools
Title: [137612] trunk/Tools
Revision 137612
Author thiago.san...@intel.com
Date 2012-12-13 10:39:39 -0800 (Thu, 13 Dec 2012)
Log Message
[EFL] The WebKit2 bots are building and executing WebKit1 tests
https://bugs.webkit.org/show_bug.cgi?id=104690
Reviewed by Csaba Osztrogonác.
Pass --no-webkit1 option to the EFL WK2 bots when building. This
will disable WK1 API and thus, the WK1 API tests.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit2Only):
(BuildAndTestFactory):
(BuildAndTestFactory.__init__):
(BuildAndTestWebKit2OnlyFactory):
Now bots using BuildAndTestWebKit2OnlyFactory (for instance only EFL) will
get --no-webkit1 as a parameter on the build-webkit script.
* Scripts/build-webkit:
Added support for -no-webkit1 for the Qt and EFL port.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (137611 => 137612)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-12-13 18:34:53 UTC (rev 137611)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-12-13 18:39:39 UTC (rev 137612)
@@ -328,12 +328,12 @@
"slavenames": ["efl-linux-slave-1"]
},
{
- "name": "EFL Linux 64-bit Release WK2", "type": "BuildAndTestWebKit2", "builddir": "efl-linux-64-release-wk2",
+ "name": "EFL Linux 64-bit Release WK2", "type": "BuildAndTestWebKit2Only", "builddir": "efl-linux-64-release-wk2",
"platform": "efl", "configuration": "release", "architectures": ["x86_64"],
"slavenames": ["efl-linux-slave-2"]
},
{
- "name": "EFL Linux 64-bit Debug WK2", "type": "BuildAndTestWebKit2", "builddir": "efl-linux-64-debug-wk2",
+ "name": "EFL Linux 64-bit Debug WK2", "type": "BuildAndTestWebKit2Only", "builddir": "efl-linux-64-debug-wk2",
"platform": "efl", "configuration": "debug", "architectures": ["x86_64"],
"slavenames": ["efl-linux-slave-4"]
},
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (137611 => 137612)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-12-13 18:34:53 UTC (rev 137611)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-12-13 18:39:39 UTC (rev 137612)
@@ -207,6 +207,10 @@
return shell.Compile.start(self)
+class CompileWebKit2Only(CompileWebKit):
+command = ["perl", "./Tools/Scripts/build-webkit", "--no-webkit1", WithProperties("--%(configuration)s")]
+
+
class ArchiveBuiltProduct(shell.ShellCommand):
command = ["python", "./Tools/BuildSlaveSupport/built-product-archive",
WithProperties("--platform=%(fullPlatform)s"), WithProperties("--%(configuration)s"), "archive"]
@@ -787,13 +791,14 @@
self.addStep(RunQtAPITests)
class BuildAndTestFactory(Factory):
+CompileClass = CompileWebKit
TestClass = RunWebKitTests
ExtractTestResultsClass = ExtractTestResults
def __init__(self, platform, configuration, architectures, triggers=None, SVNMirror=None, **kwargs):
Factory.__init__(self, platform, configuration, architectures, False, SVNMirror, **kwargs)
if platform.startswith("chromium"):
self.addStep(CleanupChromiumCrashLogs)
-self.addStep(CompileWebKit())
+self.addStep(self.CompileClass())
if not platform.startswith("chromium"):
self.addStep(RunJavaScriptCoreTests())
if platform.startswith("chromium"):
@@ -821,7 +826,8 @@
self.addStep(UploadBuiltProduct())
self.addStep(trigger.Trigger(schedulerNames=triggers))
-class BuildAndTestWebKit2Factory(BuildAndTestFactory):
+class BuildAndTestWebKit2OnlyFactory(BuildAndTestFactory):
+CompileClass = CompileWebKit2Only
TestClass = RunWebKit2Tests
class BuildAndTestLeaksFactory(BuildAndTestFactory):
Modified: trunk/Tools/ChangeLog (137611 => 137612)
--- trunk/Tools/ChangeLog 2012-12-13 18:34:53 UTC (rev 137611)
+++ trunk/Tools/ChangeLog 2012-12-13 18:39:39 UTC (rev 137612)
@@ -1,3 +1,24 @@
+2012-12-13 Thiago Marcos P. Santos
+
+[EFL] The WebKit2 bots are building and executing WebKit1 tests
+https://bugs.webkit.org/show_bug.cgi?id=104690
+
+Reviewed by Csaba Osztrogonác.
+
+Pass --no-webkit1 option to the EFL WK2 bots when building. This
+will disable WK1 API and thus, the WK1 API tests.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+
[webkit-changes] [137611] trunk/Tools
Title: [137611] trunk/Tools
Revision 137611
Author e...@webkit.org
Date 2012-12-13 10:34:53 -0800 (Thu, 13 Dec 2012)
Log Message
build-webkit --chromium-android forces Make even when update-webkit used --ninja
https://bugs.webkit.org/show_bug.cgi?id=104839
Reviewed by Tony Chang.
This was recommended by Peter as part of:
https://bugs.webkit.org/show_bug.cgi?id=104434#c4
Fixing this makes build-webkit --chromium-android work for the common (ninja) case.
* Scripts/webkitdirs.pm:
(buildChromium):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (137610 => 137611)
--- trunk/Tools/ChangeLog 2012-12-13 18:32:53 UTC (rev 137610)
+++ trunk/Tools/ChangeLog 2012-12-13 18:34:53 UTC (rev 137611)
@@ -1,3 +1,17 @@
+2012-12-13 Eric Seidel
+
+build-webkit --chromium-android forces Make even when update-webkit used --ninja
+https://bugs.webkit.org/show_bug.cgi?id=104839
+
+Reviewed by Tony Chang.
+
+This was recommended by Peter as part of:
+https://bugs.webkit.org/show_bug.cgi?id=104434#c4
+Fixing this makes build-webkit --chromium-android work for the common (ninja) case.
+
+* Scripts/webkitdirs.pm:
+(buildChromium):
+
2012-12-13 Julie Parent
Loader_unittests should reset state between runs.
Modified: trunk/Tools/Scripts/webkitdirs.pm (137610 => 137611)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-12-13 18:32:53 UTC (rev 137610)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-12-13 18:34:53 UTC (rev 137611)
@@ -2543,7 +2543,7 @@
} elsif (isCygwin() || isWindows()) {
# Windows build - builds the root visual studio solution.
$result = buildChromiumVisualStudioProject("Source/WebKit/chromium/All.sln", $clean);
-} elsif (isChromiumNinja() && !isChromiumAndroid()) {
+} elsif (isChromiumNinja()) {
$result = buildChromiumNinja("all", $clean, @options);
} elsif (isLinux() || isChromiumAndroid() || isChromiumMacMake()) {
# Linux build - build using make.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137610] trunk/Source/WebKit2
Title: [137610] trunk/Source/WebKit2
Revision 137610
Author a...@apple.com
Date 2012-12-13 10:32:53 -0800 (Thu, 13 Dec 2012)
Log Message
Frequent NetworkProcess crashes due to null connection when closing tabs
https://bugs.webkit.org/show_bug.cgi?id=104922
Reviewed by Anders Carlsson.
Don't zero out connection pointers when a connection closes. There doesn't appear
to be any reason to do this.
Tested by hitting breakpoints in all relevant objects destructors to confirm that
this doesn't introduce leaks.
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::didClose):
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::connectionToWebProcessDidClose):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137609 => 137610)
--- trunk/Source/WebKit2/ChangeLog 2012-12-13 18:32:15 UTC (rev 137609)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-13 18:32:53 UTC (rev 137610)
@@ -1,3 +1,22 @@
+2012-12-13 Alexey Proskuryakov
+
+ Frequent NetworkProcess crashes due to null connection when closing tabs
+https://bugs.webkit.org/show_bug.cgi?id=104922
+
+Reviewed by Anders Carlsson.
+
+Don't zero out connection pointers when a connection closes. There doesn't appear
+to be any reason to do this.
+
+Tested by hitting breakpoints in all relevant objects destructors to confirm that
+this doesn't introduce leaks.
+
+* NetworkProcess/NetworkConnectionToWebProcess.cpp:
+(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
+(WebKit::NetworkConnectionToWebProcess::didClose):
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::connectionToWebProcessDidClose):
+
2012-12-13 Thiago Marcos P. Santos
[EFL] Update the way we set the cookies policy
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp (137609 => 137610)
--- trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp 2012-12-13 18:32:15 UTC (rev 137609)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp 2012-12-13 18:32:53 UTC (rev 137610)
@@ -56,7 +56,6 @@
NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess()
{
-ASSERT(!m_connection);
ASSERT(m_observers.isEmpty());
}
@@ -99,20 +98,20 @@
void NetworkConnectionToWebProcess::didClose(CoreIPC::Connection*)
{
-// Protect ourself as we might be otherwise be deleted during this function
+// Protect ourself as we might be otherwise be deleted during this function.
RefPtr protector(this);
NetworkProcess::shared().removeNetworkConnectionToWebProcess(this);
+// FIXME (NetworkProcess): We might consider actively clearing out all requests for this connection.
+// But that might not be necessary as the observer mechanism used above is much more direct.
+
Vector observers;
copyToVector(m_observers, observers);
for (size_t i = 0; i < observers.size(); ++i)
observers[i]->connectionToWebProcessDidClose(this);
-
-// FIXME (NetworkProcess): We might consider actively clearing out all requests for this connection.
-// But that might not be necessary as the observer mechanism used above is much more direct.
-
-m_connection = 0;
+
+// The object may be destroyed now.
}
void NetworkConnectionToWebProcess::didReceiveInvalidMessage(CoreIPC::Connection*, CoreIPC::StringReference, CoreIPC::StringReference)
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp (137609 => 137610)
--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2012-12-13 18:32:15 UTC (rev 137609)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2012-12-13 18:32:53 UTC (rev 137610)
@@ -144,8 +144,6 @@
void NetworkResourceLoader::connectionToWebProcessDidClose(NetworkConnectionToWebProcess* connection)
{
ASSERT_ARG(connection, connection == m_connection.get());
-m_connection->unregisterObserver(this);
-m_connection = 0;
}
void NetworkResourceLoader::didReceiveResponse(ResourceHandle*, const ResourceResponse& response)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137609] trunk/LayoutTests
Title: [137609] trunk/LayoutTests Revision 137609 Author ad...@chromium.org Date 2012-12-13 10:32:15 -0800 (Thu, 13 Dec 2012) Log Message Unreviewed. Update chromium expectatins for fonts/monospace.html * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137608 => 137609) --- trunk/LayoutTests/ChangeLog 2012-12-13 18:30:57 UTC (rev 137608) +++ trunk/LayoutTests/ChangeLog 2012-12-13 18:32:15 UTC (rev 137609) @@ -1,3 +1,9 @@ +2012-12-13 Adam Klein + +Unreviewed. Update chromium expectatins for fonts/monospace.html + +* platform/chromium/TestExpectations: + 2012-12-13 Nate Chapin Route main resource loads through the memory cache. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137608 => 137609) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-13 18:30:57 UTC (rev 137608) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-13 18:32:15 UTC (rev 137609) @@ -4186,7 +4186,7 @@ webkit.org/b/104548 [ Linux ] fast/text/hyphens.html [ Failure ] # Flaky -webkit.org/b/104283 [ XP ] fonts/monospace.html [ Failure Pass ] +webkit.org/b/104283 [ Win Release ] fonts/monospace.html [ Failure Pass ] webkit.org/b/104283 [ Mac Debug ] fonts/monospace.html [ ImageOnlyFailure Pass ] # Flaky on Win ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137608] branches/chromium/1359
Title: [137608] branches/chromium/1359
Revision 137608
Author k...@chromium.org
Date 2012-12-13 10:30:57 -0800 (Thu, 13 Dec 2012)
Log Message
and now revert the manual merge for another build
Modified Paths
branches/chromium/1359/Source/WebCore/dom/Document.cpp
branches/chromium/1359/Source/WebCore/dom/Document.h
branches/chromium/1359/Source/WebCore/dom/Node.cpp
branches/chromium/1359/Source/WebCore/history/CachedFrame.cpp
branches/chromium/1359/Source/WebCore/html/HTMLInputElement.cpp
branches/chromium/1359/Source/WebCore/page/DOMWindow.cpp
branches/chromium/1359/Source/WebCore/page/EventHandler.cpp
branches/chromium/1359/Source/WebCore/page/Frame.cpp
branches/chromium/1359/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
branches/chromium/1359/Source/WebCore/page/scrolling/ScrollingCoordinator.h
branches/chromium/1359/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
branches/chromium/1359/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.h
branches/chromium/1359/Source/WebCore/testing/Internals.cpp
branches/chromium/1359/Source/WebCore/testing/Internals.h
branches/chromium/1359/Source/WebCore/testing/Internals.idl
branches/chromium/1359/Source/WebKit/chromium/features.gypi
branches/chromium/1359/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
Removed Paths
branches/chromium/1359/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt
branches/chromium/1359/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html
Diff
Deleted: branches/chromium/1359/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt (137607 => 137608)
--- branches/chromium/1359/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt 2012-12-13 18:27:51 UTC (rev 137607)
+++ branches/chromium/1359/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt 2012-12-13 18:30:57 UTC (rev 137608)
@@ -1,46 +0,0 @@
-This tests verifies the hit test regions given to the compositor. It can only be run in DumpRenderTree. The outputted rects should cover the hit test regions of all the listed elements.
-
-normalFlow[0]: (8, 72, 784, 10)
-normalFlow[1]: (8, 72, 784, 10)
-normalFlow[2]: (128, 72, 30, 10)
-normalFlow[3]: (8, 72, 784, 10)
-absoluteChildContainer[0]: (8, 162, 784, 10)
-absoluteChildContainer[1]: (8, 162, 784, 10)
-absoluteChildContainer[2]: (8, 162, 784, 10)
-absoluteChildContainer[3]: (118, 300, 140, 10)
-absoluteChildContainer[4]: (118, 300, 140, 10)
-relativeChildContainer[0]: (8, 272, 784, 10)
-relativeChildContainer[1]: (8, 272, 784, 10)
-relativeChildContainer[2]: (8, 272, 784, 10)
-relativeChildContainer[3]: (128, 472, 140, 10)
-overhangingContainer[0]: (8, 362, 784, 10)
-overhangingContainer[1]: (8, 362, 110, 80)
-overhangingContainer[2]: (8, 362, 110, 80)
-transformedChildContainer[0]: (62, 421, 661, 32)
-transformedChildContainer[1]: (62, 421, 661, 32)
-transformedChildContainer[2]: (8, 432, 769, 10)
-continuation[0]: (108, 502, 100, 10)
-
-This tests verifies the hit test regions given to the compositor. It can only be run in DumpRenderTree. The outputted rects should cover the hit test regions of all the listed elements.
-
-normalFlow[0]: (8, 72, 784, 10)
-normalFlow[1]: (8, 72, 784, 10)
-normalFlow[2]: (128, 72, 30, 10)
-normalFlow[3]: (8, 72, 784, 10)
-absoluteChildContainer[0]: (8, 162, 784, 10)
-absoluteChildContainer[1]: (8, 162, 784, 10)
-absoluteChildContainer[2]: (8, 162, 784, 10)
-absoluteChildContainer[3]: (118, 300, 140, 10)
-absoluteChildContainer[4]: (118, 300, 140, 10)
-relativeChildContainer[0]: (8, 272, 784, 10)
-relativeChildContainer[1]: (8, 272, 784, 10)
-relativeChildContainer[2]: (8, 272, 784, 10)
-relativeChildContainer[3]: (128, 472, 140, 10)
-overhangingContainer[0]: (8, 362, 784, 10)
-overhangingContainer[1]: (8, 362, 110, 80)
-overhangingContainer[2]: (8, 362, 110, 80)
-transformedChildContainer[0]: (62, 421, 661, 32)
-transformedChildContainer[1]: (62, 421, 661, 32)
-transformedChildContainer[2]: (8, 432, 769, 10)
-continuation[0]: (108, 502, 100, 10)
-
Deleted: branches/chromium/1359/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html (137607 => 137608)
--- branches/chromium/1359/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html 2012-12-13 18:27:51 UTC (rev 137607)
+++ branches/chromium/1359/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html 2012-12-13 18:30:57 UTC (rev 137608)
@@ -1,200 +0,0 @@
-
-
-
-
-#transformedChild {
- -webkit-transform: rotate3d(0.2, 1, 0, 35grad);
-}
-#absoluteChild {
- position: absolute;
- top: 300px;
-}
-#relativeChild {
- position: relative;
- top: 200px;
-}
-#overhangingContainer {
- height: 10px;
-}
-#overhangingFloatingChild {
- width: 100px;
- float: left;
-}
-#tests {
- font: 10px Ahem;
-}
-
-
-
-This tests verifies the hit test regions given to the comp
[webkit-changes] [137606] trunk/Source/WebCore
Title: [137606] trunk/Source/WebCore
Revision 137606
Author psola...@apple.com
Date 2012-12-13 10:16:58 -0800 (Thu, 13 Dec 2012)
Log Message
Duplicate code in GraphicsContext3D::validateAttributes() and GraphicsContext3D::validateDepthStencil()
https://bugs.webkit.org/show_bug.cgi?id=97275
Reviewed by Dean Jackson.
Remove duplicate code in validateAttributes(). validateAttributes() calls
validateDepthStencil() which has the exact same code.
No new tests because no change in functionality.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::validateAttributes):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (137605 => 137606)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 17:41:29 UTC (rev 137605)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 18:16:58 UTC (rev 137606)
@@ -1,3 +1,18 @@
+2012-12-13 Pratik Solanki
+
+Duplicate code in GraphicsContext3D::validateAttributes() and GraphicsContext3D::validateDepthStencil()
+https://bugs.webkit.org/show_bug.cgi?id=97275
+
+Reviewed by Dean Jackson.
+
+Remove duplicate code in validateAttributes(). validateAttributes() calls
+validateDepthStencil() which has the exact same code.
+
+No new tests because no change in functionality.
+
+* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
+(WebCore::GraphicsContext3D::validateAttributes):
+
2012-12-13 Nate Chapin
CachedResources should hang on to stripped fragment identifiers
Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp (137605 => 137606)
--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp 2012-12-13 17:41:29 UTC (rev 137605)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp 2012-12-13 18:16:58 UTC (rev 137606)
@@ -62,14 +62,7 @@
void GraphicsContext3D::validateAttributes()
{
-Extensions3D* extensions = getExtensions();
validateDepthStencil("GL_EXT_packed_depth_stencil");
-if (m_attrs.antialias) {
-if (!extensions->maySupportMultisampling() || !extensions->supports("GL_ANGLE_framebuffer_multisample") || isGLES2Compliant())
-m_attrs.antialias = false;
-else
-extensions->ensureEnabled("GL_ANGLE_framebuffer_multisample");
-}
}
bool GraphicsContext3D::reshapeFBOs(const IntSize& size)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
