[webkit-changes] [138229] trunk/Source/WebCore
Title: [138229] trunk/Source/WebCore
Revision 138229
Author par...@webkit.org
Date 2012-12-20 00:41:44 -0800 (Thu, 20 Dec 2012)
Log Message
Build fix for WinCE after r137534.
* inspector/InspectorInstrumentation.h:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138228 => 138229)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 06:41:31 UTC (rev 138228)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 08:41:44 UTC (rev 138229)
@@ -1,3 +1,10 @@
+2012-12-20 Patrick Gansterer par...@webkit.org
+
+Build fix for WinCE after r137534.
+
+* inspector/InspectorInstrumentation.h:
+(WebCore):
+
2012-12-19 Yury Semikhatsky yu...@chromium.org
Web Inspector: deny access from injected script to nodes from document with another origin
Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (138228 => 138229)
--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2012-12-20 06:41:31 UTC (rev 138228)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2012-12-20 08:41:44 UTC (rev 138229)
@@ -36,10 +36,14 @@
#include ConsoleTypes.h
#include Element.h
#include Frame.h
+#include HitTestResult.h
#include Page.h
#include ScriptExecutionContext.h
#include ScriptState.h
#include StorageArea.h
+#include WebSocketFrame.h
+#include WebSocketHandshakeRequest.h
+#include WebSocketHandshakeResponse.h
#include wtf/UnusedParam.h
namespace WebCore {
@@ -56,7 +60,6 @@
class DeviceOrientationData;
class GeolocationPosition;
class GraphicsContext;
-class HitTestResult;
class InspectorCSSAgent;
class InspectorTimelineAgent;
class InstrumentingAgents;
@@ -81,12 +84,6 @@
class WorkerContextProxy;
class XMLHttpRequest;
-#if ENABLE(WEB_SOCKETS)
-struct WebSocketFrame;
-class WebSocketHandshakeRequest;
-class WebSocketHandshakeResponse;
-#endif
-
#define FAST_RETURN_IF_NO_FRONTENDS(value) if (!hasFrontends()) return value;
typedef pairInstrumentingAgents*, int InspectorInstrumentationCookie;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138230] trunk/Source/WebKit/mac
Title: [138230] trunk/Source/WebKit/mac Revision 138230 Author loi...@chromium.org Date 2012-12-20 00:49:58 -0800 (Thu, 20 Dec 2012) Log Message Unreviewed build fix for chromium mac after r138206. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (138229 => 138230) --- trunk/Source/WebKit/mac/ChangeLog 2012-12-20 08:41:44 UTC (rev 138229) +++ trunk/Source/WebKit/mac/ChangeLog 2012-12-20 08:49:58 UTC (rev 138230) @@ -1,3 +1,10 @@ +2012-12-20 Ilya Tikhonovsky loi...@chromium.org + +Unreviewed build fix for chromium mac after r138206. + +* WebCoreSupport/WebSystemInterface.mm: +(InitWebCoreSystemInterface): + 2012-12-19 Alexey Proskuryakov a...@apple.com rdar://problem/12890242 [WK2 NetworkProcess] Client doesn't receive SSL certificates Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm (138229 => 138230) --- trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm 2012-12-20 08:41:44 UTC (rev 138229) +++ trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm 2012-12-20 08:49:58 UTC (rev 138230) @@ -58,7 +58,9 @@ INIT(CopyCFLocalizationPreferredName); INIT(CopyCONNECTProxyResponse); INIT(CopyNSURLResponseStatusLine); +#if PLATFORM(MAC) INIT(CopyNSURLResponseCertificateChain); +#endif INIT(CreateCustomCFReadStream); INIT(CreateNSURLConnectionDelegateProxy); INIT(DrawCapsLockIndicator); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138231] trunk/Tools
Title: [138231] trunk/Tools
Revision 138231
Author commit-qu...@webkit.org
Date 2012-12-20 00:54:01 -0800 (Thu, 20 Dec 2012)
Log Message
[GTK] Count failed and timed out tests separately
https://bugs.webkit.org/show_bug.cgi?id=105448
Patch by Alberto Garcia agar...@igalia.com on 2012-12-20
Reviewed by Carlos Garcia Campos.
Display the number of tests that fail, time out and are skipped
separately in the buildbot page.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete):
(RunGtkAPITests.evaluateCommand):
(RunGtkAPITests.getText2):
* Scripts/run-gtk-tests:
(TestRunner.run_tests):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (138230 => 138231)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-12-20 08:49:58 UTC (rev 138230)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-12-20 08:54:01 UTC (rev 138231)
@@ -540,15 +540,34 @@
shell.Test.commandComplete(self, cmd)
logText = cmd.logs['stdio'].getText()
-incorrectLines = []
-for line in logText.splitlines():
-if line.startswith('ERROR') or line.endswith('TIMEOUT'):
-incorrectLines.append(line)
-self.incorrectLines = incorrectLines
+self.incorrectTests = 0
+self.timedOutTests = 0
+self.skippedTests = 0
+self.statusLine = []
+foundItems = re.findall(Tests failed \((\d+)\):, logText)
+if (foundItems):
+self.incorrectTests = int(foundItems[0])
+
+foundItems = re.findall(Tests that timed out \((\d+)\):, logText)
+if (foundItems):
+self.timedOutTests = int(foundItems[0])
+
+foundItems = re.findall(Tests skipped \((\d+)\):, logText)
+if (foundItems):
+self.skippedTests = int(foundItems[0])
+
+self.totalFailedTests = self.incorrectTests + self.timedOutTests
+
+if self.totalFailedTests 0:
+self.statusLine = [
+%d API tests failed, %d timed out, %d skipped %
+(self.incorrectTests, self.timedOutTests, self.skippedTests)
+]
+
def evaluateCommand(self, cmd):
-if self.incorrectLines:
+if self.totalFailedTests 0:
return FAILURE
if cmd.rc != 0:
@@ -560,8 +579,8 @@
return self.getText2(cmd, results)
def getText2(self, cmd, results):
-if results != SUCCESS and self.incorrectLines:
-return [%d API tests failed % len(self.incorrectLines)]
+if results != SUCCESS and self.totalFailedTests 0:
+return self.statusLine
return [self.name]
Modified: trunk/Tools/ChangeLog (138230 => 138231)
--- trunk/Tools/ChangeLog 2012-12-20 08:49:58 UTC (rev 138230)
+++ trunk/Tools/ChangeLog 2012-12-20 08:54:01 UTC (rev 138231)
@@ -1,3 +1,20 @@
+2012-12-20 Alberto Garcia agar...@igalia.com
+
+[GTK] Count failed and timed out tests separately
+https://bugs.webkit.org/show_bug.cgi?id=105448
+
+Reviewed by Carlos Garcia Campos.
+
+Display the number of tests that fail, time out and are skipped
+separately in the buildbot page.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(RunGtkAPITests.commandComplete):
+(RunGtkAPITests.evaluateCommand):
+(RunGtkAPITests.getText2):
+* Scripts/run-gtk-tests:
+(TestRunner.run_tests):
+
2012-12-19 Ryosuke Niwa rn...@webkit.org
PerfTest.parse_output does too much
Modified: trunk/Tools/Scripts/run-gtk-tests (138230 => 138231)
--- trunk/Tools/Scripts/run-gtk-tests 2012-12-20 08:49:58 UTC (rev 138230)
+++ trunk/Tools/Scripts/run-gtk-tests 2012-12-20 08:54:01 UTC (rev 138231)
@@ -335,16 +335,18 @@
if failed_tests:
names = [test.replace(self._programs_path, '', 1) for test in failed_tests]
-sys.stdout.write(Tests failed: %s\n % , .join(names))
+sys.stdout.write(Tests failed (%d): %s\n % (len(names), , .join(names)))
sys.stdout.flush()
if timed_out_tests:
names = [test.replace(self._programs_path, '', 1) for test in timed_out_tests]
-sys.stdout.write(Tests that timed out: %s\n % , .join(names))
+sys.stdout.write(Tests that timed out (%d): %s\n % (len(names), , .join(names)))
sys.stdout.flush()
if self._skipped_tests and self._options.skipped_action == 'skip':
-sys.stdout.write(Tests skipped:\n%s\n % \n.join([str(skipped) for skipped in self._skipped_tests]))
+sys.stdout.write(Tests skipped (%d):\n%s\n %
+ (len(self._skipped_tests),
+ \n.join([str(skipped) for skipped in self._skipped_tests])))
[webkit-changes] [138232] trunk
Title: [138232] trunk Revision 138232 Author dominik.rottsc...@intel.com Date 2012-12-20 01:00:43 -0800 (Thu, 20 Dec 2012) Log Message [WK2] WebAudio WKTR support https://bugs.webkit.org/show_bug.cgi?id=95084 Reviewed by Kenneth Rohde Christiansen. Source/WebCore: Mac build fixes for adding WebAudio WKTR support. No new tests, enables audio testing using WebKitTestRunner. * WebCore.exp.in: toUint8Array symbol exported. * WebCore.xcodeproj/project.pbxproj: JSUint8Array.h and JSArrayBufferView.h headers made available as private headers. Source/WebKit2: Implementing audio data dump support for WebKitTestRunner, by adding the API to the IDL, enabling IPC for transferring the audio data as bytebuffer and dumping it according to run-webkit-tests script's expectations. I am adding a testrunner specific bundle method to extract data from a Uint8Array into a bytebuffer. This API is used by WebKitTestRunner's TestRunner to extract the data into a local variable, then sending it over IPC. * DerivedSources.pri: Fixing Qt build by adding JSUint8Array.h header to list of forwarding headers. * Target.pri: Adding missing WKData.* files. Qt build fix. * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleCreateWKDataFromUint8Array): Added. * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Adding WKBundleCreateWKDataFromUint8Array. * WebProcess/InjectedBundle/InjectedBundle.cpp: Convert Uint8Array to WebData. (WebKit::InjectedBundle::createWebDataFromUint8Array): (WebKit): * WebProcess/InjectedBundle/InjectedBundle.h: (WebKit): (InjectedBundle): Tools: Implementing audio data dump support for WebKitTestRunner, by adding the API to the IDL, enabling IPC for transferring the audio data as bytebuffer and dumping it according to run-webkit-tests script's expectations. This enables audio testing on WebKit2 ports. Based on initial wip-patch from Philippe Normand - thanks. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API. (WTR::TestRunner::setAudioData): (WTR): * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio. (TestRunner): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process. (WTR::InjectedBundle::done): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred. (WTR::InjectedBundle::setAudioResult): (InjectedBundle): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac. * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process. (WTR::TestInvocation::dumpResults): (WTR): (WTR::TestInvocation::dumpAudio): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping. * WebKitTestRunner/TestInvocation.h: (TestInvocation): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/DerivedSources.pri trunk/Source/WebKit2/Target.pri trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h trunk/Tools/WebKitTestRunner/TestInvocation.cpp trunk/Tools/WebKitTestRunner/TestInvocation.h Diff Modified: trunk/Source/WebCore/ChangeLog (138231 => 138232) --- trunk/Source/WebCore/ChangeLog 2012-12-20 08:54:01 UTC (rev 138231) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 09:00:43 UTC (rev 138232) @@ -1,3 +1,17 @@ +2012-12-20 Dominik Röttsches dominik.rottsc...@intel.com + +[WK2] WebAudio WKTR support +https://bugs.webkit.org/show_bug.cgi?id=95084 + +Reviewed by Kenneth Rohde Christiansen. + +Mac build fixes for adding WebAudio WKTR support. + +No new tests, enables audio testing using WebKitTestRunner. + +* WebCore.exp.in: toUint8Array symbol exported. +* WebCore.xcodeproj/project.pbxproj: JSUint8Array.h and JSArrayBufferView.h headers made available as private headers. + 2012-12-20 Patrick Gansterer par...@webkit.org Build fix for WinCE after r137534.
[webkit-changes] [138233] trunk/Source/WebKit/chromium
Title: [138233] trunk/Source/WebKit/chromium
Revision 138233
Author loi...@chromium.org
Date 2012-12-20 01:07:51 -0800 (Thu, 20 Dec 2012)
Log Message
Unreviewed, rolling out r138215.
http://trac.webkit.org/changeset/138215
https://bugs.webkit.org/show_bug.cgi?id=105505
it broke downstream compilation with clang (Requested by
loislo on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-12-20
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::sharedWorkerRepository):
* src/SharedWorkerRepository.cpp:
(WebKit::sharedWorkerRepository):
(WebCore::SharedWorkerRepository::isAvailable):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (138232 => 138233)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 09:00:43 UTC (rev 138232)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 09:07:51 UTC (rev 138233)
@@ -1,3 +1,20 @@
+2012-12-20 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r138215.
+http://trac.webkit.org/changeset/138215
+https://bugs.webkit.org/show_bug.cgi?id=105505
+
+it broke downstream compilation with clang (Requested by
+loislo on #webkit).
+
+* public/platform/WebKitPlatformSupport.h:
+(WebKit):
+(WebKitPlatformSupport):
+(WebKit::WebKitPlatformSupport::sharedWorkerRepository):
+* src/SharedWorkerRepository.cpp:
+(WebKit::sharedWorkerRepository):
+(WebCore::SharedWorkerRepository::isAvailable):
+
2012-12-19 Mark Pilgrim pilg...@chromium.org
[Chromium] Remove idbFactory from PlatformSupport
Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (138232 => 138233)
--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2012-12-20 09:00:43 UTC (rev 138232)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2012-12-20 09:07:51 UTC (rev 138233)
@@ -36,6 +36,7 @@
namespace WebKit {
class WebIDBFactory; // FIXME: Does this belong in platform?
+class WebSharedWorkerRepository; // FIXME: Does this belong in platform?
// FIXME: Eventually all these API will need to move to WebKit::Platform.
class WebKitPlatformSupport : public Platform {
@@ -44,6 +45,11 @@
virtual WebIDBFactory* idbFactory() { return 0; }
+
+// Shared Workers --
+
+virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; }
+
protected:
~WebKitPlatformSupport() { }
};
Modified: trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp (138232 => 138233)
--- trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp 2012-12-20 09:00:43 UTC (rev 138232)
+++ trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp 2012-12-20 09:07:51 UTC (rev 138233)
@@ -69,8 +69,15 @@
static WebSharedWorkerRepository* sharedWorkerRepository()
{
-// Will only be non-zero if the embedder has set the shared worker repository upon initialization. Nothing in WebKit sets this.
-return s_sharedWorkerRepository;
+WebSharedWorkerRepository* repository;
+
+repository = s_sharedWorkerRepository;
+if (!repository) {
+repository = webKitPlatformSupport()-sharedWorkerRepository();
+setSharedWorkerRepository(repository);
+}
+
+return repository;
}
}
@@ -211,6 +218,8 @@
bool SharedWorkerRepository::isAvailable()
{
+// Allow the WebKitPlatformSupport to determine if SharedWorkers
+// are available.
return WebKit::sharedWorkerRepository();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138234] trunk/Source
Title: [138234] trunk/Source
Revision 138234
Author commit-qu...@webkit.org
Date 2012-12-20 01:12:26 -0800 (Thu, 20 Dec 2012)
Log Message
Remove GraphicsLayer::setGraphicsLayerFactory().
https://bugs.webkit.org/show_bug.cgi?id=105503
Patch by Huang Dongsung luxte...@company100.net on 2012-12-20
Reviewed by Kenneth Rohde Christiansen.
We don't need GraphicsLayer::setGraphicsLayerFactory() anymore. After r130302,
we have used a graphics layer factory explicitly.
Source/WebCore:
No new tests. Refactoring only.
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayer::create):
Source/WebKit2:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
* WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h
trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h
trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp
trunk/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138233 => 138234)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 09:07:51 UTC (rev 138233)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 09:12:26 UTC (rev 138234)
@@ -1,3 +1,21 @@
+2012-12-20 Huang Dongsung luxte...@company100.net
+
+Remove GraphicsLayer::setGraphicsLayerFactory().
+https://bugs.webkit.org/show_bug.cgi?id=105503
+
+Reviewed by Kenneth Rohde Christiansen.
+
+We don't need GraphicsLayer::setGraphicsLayerFactory() anymore. After r130302,
+we have used a graphics layer factory explicitly.
+
+No new tests. Refactoring only.
+
+* platform/graphics/GraphicsLayer.cpp:
+* platform/graphics/GraphicsLayer.h:
+(GraphicsLayer):
+* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+(WebCore::GraphicsLayer::create):
+
2012-12-20 Dominik Röttsches dominik.rottsc...@intel.com
[WK2] WebAudio WKTR support
Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp (138233 => 138234)
--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp 2012-12-20 09:07:51 UTC (rev 138233)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp 2012-12-20 09:12:26 UTC (rev 138234)
@@ -410,15 +410,6 @@
}
}
-#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL)
-GraphicsLayer::GraphicsLayerFactoryCallback* GraphicsLayer::s_graphicsLayerFactory = 0;
-
-void GraphicsLayer::setGraphicsLayerFactory(GraphicsLayer::GraphicsLayerFactoryCallback factory)
-{
-s_graphicsLayerFactory = factory;
-}
-#endif
-
#if ENABLE(CSS_FILTERS)
static inline const FilterOperations* filterOperationsAt(const KeyframeValueList valueList, size_t index)
{
Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.h (138233 => 138234)
--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.h 2012-12-20 09:07:51 UTC (rev 138233)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.h 2012-12-20 09:12:26 UTC (rev 138234)
@@ -419,13 +419,6 @@
void resetTrackedRepaints();
void addRepaintRect(const FloatRect);
-#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL)
-// This allows several alternative GraphicsLayer implementations in the same port,
-// e.g. if a different GraphicsLayer implementation is needed in WebKit1 vs. WebKit2.
-typedef PassOwnPtrGraphicsLayer GraphicsLayerFactoryCallback(GraphicsLayerClient*);
-static void setGraphicsLayerFactory(GraphicsLayerFactoryCallback);
-#endif
-
static bool supportsBackgroundColorContent()
{
#if USE(CA) || USE(TEXTURE_MAPPER)
@@ -527,10 +520,6 @@
IntRect m_contentsRect;
int m_repaintCount;
-
-#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL)
-static GraphicsLayer::GraphicsLayerFactoryCallback* s_graphicsLayerFactory;
-#endif
};
Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (138233 => 138234)
--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp 2012-12-20 09:07:51 UTC (rev 138233)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp 2012-12-20 09:12:26 UTC (rev 138234)
@@ -44,8 +44,6 @@
PassOwnPtrGraphicsLayer GraphicsLayer::create(GraphicsLayerClient* client)
{
-if (s_graphicsLayerFactory)
-return (*s_graphicsLayerFactory)(client);
return adoptPtr(new GraphicsLayerTextureMapper(client));
}
[webkit-changes] [138235] trunk/Source/WebCore
Title: [138235] trunk/Source/WebCore
Revision 138235
Author carlo...@webkit.org
Date 2012-12-20 01:18:09 -0800 (Thu, 20 Dec 2012)
Log Message
Make order iterator member stack allocated in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=104366
Reviewed by Tony Chang.
It avoids a heap allocation during layout.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::OrderIterator::OrderIterator):
(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
(WebCore::RenderFlexibleBox::OrderIterator::first):
(WebCore::RenderFlexibleBox::OrderIterator::next):
(WebCore::RenderFlexibleBox::OrderIterator::reset):
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::RenderFlexibleBox::firstLineBoxBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::appendChildFrameRects):
(WebCore::RenderFlexibleBox::repaintChildrenDuringLayoutIfMoved):
(WebCore::RenderFlexibleBox::paintChildren):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::alignFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):
* rendering/RenderFlexibleBox.h:
(OrderIterator):
(WebCore::RenderFlexibleBox::OrderIterator::currentChild):
(RenderFlexibleBox):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138234 => 138235)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 09:12:26 UTC (rev 138234)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 09:18:09 UTC (rev 138235)
@@ -1,3 +1,35 @@
+2012-12-19 Carlos Garcia Campos cgar...@igalia.com
+
+Make order iterator member stack allocated in RenderFlexibleBox
+https://bugs.webkit.org/show_bug.cgi?id=104366
+
+Reviewed by Tony Chang.
+
+It avoids a heap allocation during layout.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::OrderIterator::OrderIterator):
+(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
+(WebCore::RenderFlexibleBox::OrderIterator::first):
+(WebCore::RenderFlexibleBox::OrderIterator::next):
+(WebCore::RenderFlexibleBox::OrderIterator::reset):
+(WebCore::RenderFlexibleBox::RenderFlexibleBox):
+(WebCore::RenderFlexibleBox::firstLineBoxBaseline):
+(WebCore::RenderFlexibleBox::layoutBlock):
+(WebCore::RenderFlexibleBox::appendChildFrameRects):
+(WebCore::RenderFlexibleBox::repaintChildrenDuringLayoutIfMoved):
+(WebCore::RenderFlexibleBox::paintChildren):
+(WebCore::RenderFlexibleBox::layoutFlexItems):
+(WebCore::RenderFlexibleBox::computeNextFlexLine):
+(WebCore::RenderFlexibleBox::alignFlexLines):
+(WebCore::RenderFlexibleBox::alignChildren):
+(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
+(WebCore::RenderFlexibleBox::flipForWrapReverse):
+* rendering/RenderFlexibleBox.h:
+(OrderIterator):
+(WebCore::RenderFlexibleBox::OrderIterator::currentChild):
+(RenderFlexibleBox):
+
2012-12-20 Huang Dongsung luxte...@company100.net
Remove GraphicsLayer::setGraphicsLayerFactory().
Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (138234 => 138235)
--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2012-12-20 09:12:26 UTC (rev 138234)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2012-12-20 09:18:09 UTC (rev 138235)
@@ -49,58 +49,52 @@
static bool isDeletedValue(int value) { return value == std::numeric_limitsint::min() + 1; }
};
-class RenderFlexibleBox::OrderIterator {
-public:
-OrderIterator(RenderFlexibleBox* flexibleBox, const OrderHashSet orderValues)
-: m_flexibleBox(flexibleBox)
-, m_currentChild(0)
-, m_orderValuesIterator(0)
-{
-copyToVector(orderValues, m_orderValues);
-std::sort(m_orderValues.begin(), m_orderValues.end());
-}
+RenderFlexibleBox::OrderIterator::OrderIterator(const RenderFlexibleBox* flexibleBox)
+: m_flexibleBox(flexibleBox)
+, m_currentChild(0)
+, m_orderValuesIterator(0)
+{
+}
-RenderBox* currentChild() { return m_currentChild; }
+void RenderFlexibleBox::OrderIterator::setOrderValues(const OrderHashSet orderValues)
+{
+reset();
+copyToVector(orderValues, m_orderValues);
+std::sort(m_orderValues.begin(), m_orderValues.end());
+}
-RenderBox* first()
-{
-reset();
-return next();
-}
+RenderBox* RenderFlexibleBox::OrderIterator::first()
+{
+reset();
+return next();
+}
-RenderBox* next()
-{
-do {
-if (!m_currentChild) {
+RenderBox* RenderFlexibleBox::OrderIterator::next()
+{
+do {
+if (!m_currentChild) {
+if
[webkit-changes] [138236] trunk/Source
Title: [138236] trunk/Source
Revision 138236
Author pfeld...@chromium.org
Date 2012-12-20 01:39:32 -0800 (Thu, 20 Dec 2012)
Log Message
Web Inspector: introduce Page.captureScreenshot
https://bugs.webkit.org/show_bug.cgi?id=105315
Reviewed by Yury Semikhatsky.
Source/WebCore:
It will be primarily used by the automation clients, but maybe we find a good place
for it in the front-end as well.
* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::captureScreenshot):
(InspectorClient):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::captureScreenshot):
(WebCore):
* inspector/InspectorPageAgent.h:
Source/WebKit/chromium:
Introduces a way for browser to handle protocol commands:
embedder will ask WebKit whether it should override the command
result and will get a hint value. Based on that hint, browser
will prepare the data and ask WebKit again to patch this data in.
* public/WebDevToolsAgent.h:
(WebDevToolsAgent):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::captureScreenshot):
(WebKit):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(BrowserDataHintStringValues):
(WebKit):
(WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::captureScreenshot):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgentImpl::sendMessageToFrontend):
(WebKit::WebDevToolsAgent::shouldPatchWithBrowserData):
(WebKit::WebDevToolsAgent::patchWithBrowserData):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorClient.h
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDevToolsAgent.h
trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp
trunk/Source/WebKit/chromium/src/InspectorClientImpl.h
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138235 => 138236)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 09:18:09 UTC (rev 138235)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 09:39:32 UTC (rev 138236)
@@ -1,3 +1,22 @@
+2012-12-19 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: introduce Page.captureScreenshot
+https://bugs.webkit.org/show_bug.cgi?id=105315
+
+Reviewed by Yury Semikhatsky.
+
+It will be primarily used by the automation clients, but maybe we find a good place
+for it in the front-end as well.
+
+* inspector/Inspector.json:
+* inspector/InspectorClient.h:
+(WebCore::InspectorClient::captureScreenshot):
+(InspectorClient):
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::captureScreenshot):
+(WebCore):
+* inspector/InspectorPageAgent.h:
+
2012-12-19 Carlos Garcia Campos cgar...@igalia.com
Make order iterator member stack allocated in RenderFlexibleBox
Modified: trunk/Source/WebCore/inspector/Inspector.json (138235 => 138236)
--- trunk/Source/WebCore/inspector/Inspector.json 2012-12-20 09:18:09 UTC (rev 138235)
+++ trunk/Source/WebCore/inspector/Inspector.json 2012-12-20 09:39:32 UTC (rev 138236)
@@ -456,6 +456,14 @@
{ name: visible, type: boolean, description: True for showing compositing borders. }
],
hidden: true
+},
+{
+name: captureScreenshot,
+description: Capture page screenshot.,
+returns: [
+{ name: data, type: string, description: Base64-encoded image data (PNG). }
+],
+hidden: true
}
],
events: [
Modified: trunk/Source/WebCore/inspector/InspectorClient.h (138235 => 138236)
--- trunk/Source/WebCore/inspector/InspectorClient.h 2012-12-20 09:18:09 UTC (rev 138235)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2012-12-20 09:39:32 UTC (rev 138236)
@@ -81,6 +81,8 @@
virtual void getAllocatedObjects(HashSetconst void*) { }
virtual void dumpUncountedAllocatedObjects(const HashMapconst void*, size_t) { }
+virtual bool captureScreenshot(String*) { return false; }
+
static bool doDispatchMessageOnFrontendPage(Page* frontendPage, const String message);
};
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (138235 => 138236)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-12-20 09:18:09 UTC (rev 138235)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-12-20 09:39:32 UTC (rev 138236)
@@ -1048,7 +1048,7 @@
GeolocationController* controller = GeolocationController::from(m_page);
GeolocationPosition* position = 0;
if
[webkit-changes] [138237] trunk/Source/WebCore
Title: [138237] trunk/Source/WebCore
Revision 138237
Author commit-qu...@webkit.org
Date 2012-12-20 02:06:56 -0800 (Thu, 20 Dec 2012)
Log Message
Web Inspector: fix |_repaintAll| behaviour of a DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=105429
Patch by Andrey Lushnikov lushni...@chromium.com on 2012-12-20
Reviewed by Pavel Feldman.
Override |_repainAll| method in TextEditorMainPanel and manually
repaint visible chunks.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine): Call |_repaintAll| method because |expand()| does not do any repaints anymore.
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll): Return |false| in case of fast return, and |true| otherwise.
(WebInspector.TextEditorMainPanel.prototype._repaintAll): Added.
(WebInspector.TextEditorMainChunk.prototype.expand): Remove painting operations.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (138236 => 138237)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 09:39:32 UTC (rev 138236)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 10:06:56 UTC (rev 138237)
@@ -1,3 +1,19 @@
+2012-12-20 Andrey Lushnikov lushni...@chromium.com
+
+Web Inspector: fix |_repaintAll| behaviour of a DefaultTextEditor
+https://bugs.webkit.org/show_bug.cgi?id=105429
+
+Reviewed by Pavel Feldman.
+
+Override |_repainAll| method in TextEditorMainPanel and manually
+repaint visible chunks.
+
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine): Call |_repaintAll| method because |expand()| does not do any repaints anymore.
+(WebInspector.TextEditorChunkedPanel.prototype._repaintAll): Return |false| in case of fast return, and |true| otherwise.
+(WebInspector.TextEditorMainPanel.prototype._repaintAll): Added.
+(WebInspector.TextEditorMainChunk.prototype.expand): Remove painting operations.
+
2012-12-19 Pavel Feldman pfeld...@chromium.org
Web Inspector: introduce Page.captureScreenshot
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (138236 => 138237)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-12-20 09:39:32 UTC (rev 138236)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-12-20 10:06:56 UTC (rev 138237)
@@ -813,6 +813,7 @@
lineChunk.expand();
if (suffixChunk)
suffixChunk.expand();
+this._repaintAll();
}
this.endDomUpdates();
@@ -932,7 +933,7 @@
delete this._repaintAllTimer;
if (this._paintCoalescingLevel)
-return;
+return false;
var visibleFrom = this._scrollTop();
var visibleTo = visibleFrom + this._clientHeight();
@@ -941,6 +942,7 @@
var result = this._findVisibleChunks(visibleFrom, visibleTo);
this._expandChunks(result.start, result.end);
}
+return true;
},
_scrollTop: function()
@@ -1361,6 +1363,25 @@
this._isShowing = false;
},
+_repaintAll: function()
+{
+// calling overridden |_repaintAll| method
+if (!WebInspector.TextEditorChunkedPanel.prototype._repaintAll.call(this))
+return false;
+
+var visibleFrom = this._scrollTop();
+var visibleTo = visibleFrom + this._clientHeight();
+
+if (visibleTo) {
+var result = this._findVisibleChunks(visibleFrom, visibleTo);
+for(var i = result.start; i result.end; i++) {
+var chunk = this._textChunks[i];
+this._paintLines(chunk.startLine, chunk.startLine + chunk.linesCount, true);
+}
+}
+return true;
+},
+
_attachMutationObserver: function()
{
if (!this._isShowing)
@@ -2658,10 +2679,8 @@
this._expanded = true;
-if (this.linesCount === 1) {
-this._chunkedPanel._paintLine(this.element);
+if (this.linesCount === 1)
return;
-}
this._chunkedPanel.beginDomUpdates();
@@ -2673,7 +2692,6 @@
this._expandedLineRows.push(lineRow);
}
parentElement.removeChild(this.element);
-this._chunkedPanel._paintLines(this.startLine, this.startLine + this.linesCount);
this._chunkedPanel.endDomUpdates();
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138238] trunk/LayoutTests
Title: [138238] trunk/LayoutTests Revision 138238 Author rn...@webkit.org Date 2012-12-20 02:20:21 -0800 (Thu, 20 Dec 2012) Log Message Update Mac test expectations as suggested by Antoine Quint. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138237 => 138238) --- trunk/LayoutTests/ChangeLog 2012-12-20 10:06:56 UTC (rev 138237) +++ trunk/LayoutTests/ChangeLog 2012-12-20 10:20:21 UTC (rev 138238) @@ -1,3 +1,9 @@ +2012-12-20 Ryosuke Niwa rn...@webkit.org + +Update Mac test expectations as suggested by Antoine Quint. + +* platform/mac/TestExpectations: + 2012-12-19 Yury Semikhatsky yu...@chromium.org Web Inspector: deny access from injected script to nodes from document with another origin Modified: trunk/LayoutTests/platform/mac/TestExpectations (138237 => 138238) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 10:06:56 UTC (rev 138237) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 10:20:21 UTC (rev 138238) @@ -1241,6 +1241,8 @@ # Mountain Lion and prior do not support custom media data loading Bug(jernoble) [ MountainLion Lion SnowLeopard ] media/video-src-blob.html +webkit.org/b/105514 media/track/track-in-band-cues-added-once.html [ Failure ] + # Mountain Lion and prior do not allow access to in-band text tracks webkit.org/b/103663 [ MountainLion Lion SnowLeopard ] media/track/track-in-band.html webkit.org/b/103663 [ MountainLion Lion SnowLeopard ] media/track/track-in-band-cues-added-once.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138239] trunk/Tools
Title: [138239] trunk/Tools Revision 138239 Author joc...@chromium.org Date 2012-12-20 02:39:42 -0800 (Thu, 20 Dec 2012) Log Message [chromium] fix stray printf in TestRunner's WebTestProxy https://bugs.webkit.org/show_bug.cgi?id=105515 Reviewed by Ryosuke Niwa. * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::shouldInsertNode): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp Diff Modified: trunk/Tools/ChangeLog (138238 => 138239) --- trunk/Tools/ChangeLog 2012-12-20 10:20:21 UTC (rev 138238) +++ trunk/Tools/ChangeLog 2012-12-20 10:39:42 UTC (rev 138239) @@ -1,3 +1,13 @@ +2012-12-20 Jochen Eisinger joc...@chromium.org + +[chromium] fix stray printf in TestRunner's WebTestProxy +https://bugs.webkit.org/show_bug.cgi?id=105515 + +Reviewed by Ryosuke Niwa. + +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::shouldInsertNode): + 2012-12-20 Dominik Röttsches dominik.rottsc...@intel.com [WK2] WebAudio WKTR support Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp (138238 => 138239) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp 2012-12-20 10:20:21 UTC (rev 138238) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp 2012-12-20 10:39:42 UTC (rev 138239) @@ -323,7 +323,7 @@ printNodeDescription(m_delegate, node, 0); m_delegate-printMessage( replacingDOMRange:); printRangeDescription(m_delegate, range); -printf( givenAction:%s\n, editingActionDescription(action).c_str()); +m_delegate-printMessage(string( givenAction:) + editingActionDescription(action) + \n); } return true; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138240] trunk/LayoutTests
Title: [138240] trunk/LayoutTests Revision 138240 Author loi...@chromium.org Date 2012-12-20 03:00:13 -0800 (Thu, 20 Dec 2012) Log Message Unreviewed. Adjust TestExpectations for media/track tests. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138239 => 138240) --- trunk/LayoutTests/ChangeLog 2012-12-20 10:39:42 UTC (rev 138239) +++ trunk/LayoutTests/ChangeLog 2012-12-20 11:00:13 UTC (rev 138240) @@ -1,3 +1,9 @@ +2012-12-20 Ilya Tikhonovsky loi...@chromium.org + +Unreviewed. Adjust TestExpectations for media/track tests. + +* platform/chromium/TestExpectations: + 2012-12-20 Ryosuke Niwa rn...@webkit.org Update Mac test expectations as suggested by Antoine Quint. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (138239 => 138240) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-20 10:39:42 UTC (rev 138239) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-20 11:00:13 UTC (rev 138240) @@ -2938,6 +2938,7 @@ webkit.org/b/73865 media/track/text-track-cue-is-reachable.html [ Failure ] webkit.org/b/73865 media/track/text-track-is-reachable.html [ Failure ] +webkit.org/b/73865 media/track [ Crash Pass ] # Opera-submitted tests to W3C for track, a lot of failures still. webkit.org/b/103926 media/track/opera/idl/media-idl-tests.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138241] trunk/LayoutTests
Title: [138241] trunk/LayoutTests
Revision 138241
Author zandober...@gmail.com
Date 2012-12-20 03:05:17 -0800 (Thu, 20 Dec 2012)
Log Message
Unreviewed GTK gardening.
Adding a platform-specific baseline for a Shadow DOM test as required after r138165.
Adding failure expectations for two failures introduced separately in r138112 and r138184.
* platform/gtk/TestExpectations:
* platform/gtk/fast/dom/shadow/shadow-root-js-api-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
Added Paths
trunk/LayoutTests/platform/gtk/fast/dom/shadow/shadow-root-js-api-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (138240 => 138241)
--- trunk/LayoutTests/ChangeLog 2012-12-20 11:00:13 UTC (rev 138240)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 11:05:17 UTC (rev 138241)
@@ -1,3 +1,13 @@
+2012-12-20 Zan Dobersek zandober...@gmail.com
+
+Unreviewed GTK gardening.
+
+Adding a platform-specific baseline for a Shadow DOM test as required after r138165.
+Adding failure expectations for two failures introduced separately in r138112 and r138184.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/dom/shadow/shadow-root-js-api-expected.txt: Added.
+
2012-12-20 Ilya Tikhonovsky loi...@chromium.org
Unreviewed. Adjust TestExpectations for media/track tests.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (138240 => 138241)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-20 11:00:13 UTC (rev 138240)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-20 11:05:17 UTC (rev 138241)
@@ -1389,6 +1389,10 @@
webkit.org/b/87734 svg/dom/viewspec-parser-6.html [ Failure ]
webkit.org/b/87734 svg/dom/viewspec-parser-7.html [ Failure ]
+webkit.org/b/105443 accessibility/aria-controls-with-tabs.html [ Failure ]
+
+webkit.org/b/105522 transitions/transitions-parsing.html [ Failure ]
+
#
# End of Tests failing
#
Added: trunk/LayoutTests/platform/gtk/fast/dom/shadow/shadow-root-js-api-expected.txt (0 => 138241)
--- trunk/LayoutTests/platform/gtk/fast/dom/shadow/shadow-root-js-api-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/dom/shadow/shadow-root-js-api-expected.txt 2012-12-20 11:05:17 UTC (rev 138241)
@@ -0,0 +1,29 @@
+Tests for ShadowRoot JS APIs. Can only run within DRT
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS window.ShadowRoot is undefined.
+PASS window.WebKitShadowRoot is defined.
+PASS new window.WebKitShadowRoot(document.createElement('div')) threw exception TypeError: '[object ShadowRootConstructor]' is not a constructor (evaluating 'new window.WebKitShadowRoot(document.createElement('div'))').
+PASS shadowRoot instanceof window.WebKitShadowRoot is true
+PASS shadowRoot.getElementById('div1') is div1
+PASS shadowRoot.getElementById('foo') is null
+PASS shadowRoot.getElementsByClassName('class2') is [div2]
+PASS shadowRoot.getElementsByClassName('foo') is []
+PASS shadowRoot.getElementsByTagName('div') is [div1, div2]
+PASS shadowRoot.getElementsByTagName('foo') is []
+PASS shadowRoot.getElementsByTagNameNS('*', 'div') is [div1, div2]
+PASS shadowRoot.getElementsByTagNameNS('', 'div') is []
+PASS shadowRoot.getElementsByTagNameNS('*', 'foo') is []
+PASS shadowRoot.querySelector('#div1') is div1
+PASS shadowRoot.querySelector('#foo') is null
+PASS shadowRoot.querySelector('.class2') is div2
+PASS shadowRoot.querySelector('.foo') is null
+PASS shadowRoot.querySelectorAll('div') is [div1, div2]
+PASS shadowRoot.querySelectorAll('foo') is []
+PASS youngerShadowRoot is not shadowRoot
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138242] trunk/Source/WebCore
Title: [138242] trunk/Source/WebCore
Revision 138242
Author ca...@chromium.org
Date 2012-12-20 03:48:25 -0800 (Thu, 20 Dec 2012)
Log Message
Web Inspector: [CPU Profile] Idle time is always 0
https://bugs.webkit.org/show_bug.cgi?id=105509
Patch by Eugene Klyuchnikov eus...@chromium.org on 2012-12-20
Reviewed by Pavel Feldman.
Fix: pass correct profile object to method.
* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.profileCallback):
(WebInspector.CPUProfileView.prototype._injectIdleTimeNode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CPUProfileView.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (138241 => 138242)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 11:05:17 UTC (rev 138241)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 11:48:25 UTC (rev 138242)
@@ -1,3 +1,16 @@
+2012-12-20 Eugene Klyuchnikov eus...@chromium.org
+
+Web Inspector: [CPU Profile] Idle time is always 0
+https://bugs.webkit.org/show_bug.cgi?id=105509
+
+Reviewed by Pavel Feldman.
+
+Fix: pass correct profile object to method.
+
+* inspector/front-end/CPUProfileView.js:
+(WebInspector.CPUProfileView.profileCallback):
+(WebInspector.CPUProfileView.prototype._injectIdleTimeNode):
+
2012-12-20 Andrey Lushnikov lushni...@chromium.com
Web Inspector: fix |_repaintAll| behaviour of a DefaultTextEditor
Modified: trunk/Source/WebCore/inspector/front-end/CPUProfileView.js (138241 => 138242)
--- trunk/Source/WebCore/inspector/front-end/CPUProfileView.js 2012-12-20 11:05:17 UTC (rev 138241)
+++ trunk/Source/WebCore/inspector/front-end/CPUProfileView.js 2012-12-20 11:48:25 UTC (rev 138242)
@@ -96,7 +96,7 @@
this.profile.head = profile.head;
if (profile.idleTime)
-this._injectIdleTimeNode();
+this._injectIdleTimeNode(profile);
this._assignParentsInProfile();
this._changeView();
@@ -540,9 +540,8 @@
}
},
-_injectIdleTimeNode: function()
+_injectIdleTimeNode: function(profile)
{
-var profile = ""
var idleTime = profile.idleTime;
var nodes = profile.head.children;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138243] trunk/LayoutTests
Title: [138243] trunk/LayoutTests Revision 138243 Author o...@webkit.org Date 2012-12-20 04:12:50 -0800 (Thu, 20 Dec 2012) Log Message Unreviewed gardening, skip a crashing test to paint the bots green. * platform/qt/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138242 => 138243) --- trunk/LayoutTests/ChangeLog 2012-12-20 11:48:25 UTC (rev 138242) +++ trunk/LayoutTests/ChangeLog 2012-12-20 12:12:50 UTC (rev 138243) @@ -1,3 +1,9 @@ +2012-12-20 Csaba Osztrogonác o...@webkit.org + +Unreviewed gardening, skip a crashing test to paint the bots green. + +* platform/qt/TestExpectations: + 2012-12-20 Zan Dobersek zandober...@gmail.com Unreviewed GTK gardening. Modified: trunk/LayoutTests/platform/qt/TestExpectations (138242 => 138243) --- trunk/LayoutTests/platform/qt/TestExpectations 2012-12-20 11:48:25 UTC (rev 138242) +++ trunk/LayoutTests/platform/qt/TestExpectations 2012-12-20 12:12:50 UTC (rev 138243) @@ -2456,3 +2456,6 @@ http/tests/xmlhttprequest/post-blob-content-type-sync.html webkit.org/b/104788 css3/flexbox/flex-algorithm.html [ Failure ] + +# [Qt]REGRESSION(r138222): It made fast/forms/number/number-spinbutton-click-in-iframe.html crash +webkit.org/b/105529 fast/forms/number/number-spinbutton-click-in-iframe.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138244] trunk/Source/WebCore
Title: [138244] trunk/Source/WebCore Revision 138244 Author ca...@chromium.org Date 2012-12-20 04:43:56 -0800 (Thu, 20 Dec 2012) Log Message Web Inspector: Timeline: enhance short-records filter. https://bugs.webkit.org/show_bug.cgi?id=101749 Patch by Eugene Klyuchnikov eustas@gmail.com on 2012-12-20 Reviewed by Pavel Feldman. Currently filter could be on (accepting records longer than 15ms) or off (accepting all records). Adding some options between 0ms and 15ms will make this feature much more useful. Additional changes: - removed hardcoded size constant WebInspector.StatusBarComboBox.width * English.lproj/localizedStrings.js: Added new / removed orphan strings. * inspector/front-end/ProfilesPanel.js: Changed offset calculation. * inspector/front-end/TimelineOverviewPane.js: Enhanced filter. * inspector/front-end/TimelinePanel.js: Replaced button with combobox. (WebInspector.TimelineIsLongFilter): Enhanced filter. * inspector/front-end/TimelinePresentationModel.js: Removed Record isLong method. * inspector/front-end/timelinePanel.css: Removed orphan styles. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/inspector/front-end/Panel.js trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js trunk/Source/WebCore/inspector/front-end/StatusBarButton.js trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js trunk/Source/WebCore/inspector/front-end/TimelinePanel.js trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js trunk/Source/WebCore/inspector/front-end/timelinePanel.css Diff Modified: trunk/Source/WebCore/ChangeLog (138243 => 138244) --- trunk/Source/WebCore/ChangeLog 2012-12-20 12:12:50 UTC (rev 138243) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 12:43:56 UTC (rev 138244) @@ -1,3 +1,26 @@ +2012-12-20 Eugene Klyuchnikov eustas@gmail.com + +Web Inspector: Timeline: enhance short-records filter. +https://bugs.webkit.org/show_bug.cgi?id=101749 + +Reviewed by Pavel Feldman. + +Currently filter could be on (accepting records longer than 15ms) or +off (accepting all records). Adding some options between 0ms and 15ms +will make this feature much more useful. + +Additional changes: +- removed hardcoded size constant WebInspector.StatusBarComboBox.width + +* English.lproj/localizedStrings.js: Added new / removed orphan strings. +* inspector/front-end/ProfilesPanel.js: Changed offset calculation. +* inspector/front-end/TimelineOverviewPane.js: Enhanced filter. +* inspector/front-end/TimelinePanel.js: Replaced button with combobox. +(WebInspector.TimelineIsLongFilter): Enhanced filter. +* inspector/front-end/TimelinePresentationModel.js: +Removed Record isLong method. +* inspector/front-end/timelinePanel.css: Removed orphan styles. + 2012-12-20 Eugene Klyuchnikov eus...@chromium.org Web Inspector: [CPU Profile] Idle time is always 0 Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (138243 => 138244) --- trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-12-20 12:12:50 UTC (rev 138243) +++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-12-20 12:43:56 UTC (rev 138244) @@ -220,7 +220,6 @@ localizedStrings[Heavy (Bottom Up)] = Heavy (Bottom Up); localizedStrings[Hex Colors] = Hex Colors; localizedStrings[Hide console.] = Hide console.; -localizedStrings[Hide the records that are shorter than %s] = Hide the Precords that are shorter than %s; localizedStrings[Image] = Image; localizedStrings[Images] = Images; localizedStrings[Increment by %f] = Increment by %f; @@ -381,7 +380,6 @@ localizedStrings[Show inherited] = Show inherited; localizedStrings[Show rulers] = Show rulers; localizedStrings[Show Shadow DOM] = Show Shadow DOM; -localizedStrings[Show the records that are shorter than %s] = Show the records that are shorter than %s; localizedStrings[Show times as percentages.] = Show times as percentages.; localizedStrings[Show total and self times as percentages.] = Show total and self times as percentages.; localizedStrings[Size] = Size; @@ -807,6 +805,9 @@ localizedStrings[Glyph cache resources] = Glyph cache resources; localizedStrings[CSS Regions Support] = CSS Regions Support; localizedStrings[Scroll] = Scroll; +localizedStrings[Show all records] = Show all records; +localizedStrings[\u2265 %dms] = \u2265 %dms; +localizedStrings[Hide records shorter than %dms] = Hide records shorter than %dms; localizedStrings[Detached from the target] = Detached from the target; localizedStrings[Remote debugging has been terminated with reason: ] = Remote debugging has been terminated with reason: ; localizedStrings[Please re-attach to the new target.] = Please re-attach to the new target.; Modified: trunk/Source/WebCore/inspector/front-end/Panel.js (138243 => 138244) ---
[webkit-changes] [138245] trunk/Source/WebCore
Title: [138245] trunk/Source/WebCore Revision 138245 Author yu...@chromium.org Date 2012-12-20 05:01:42 -0800 (Thu, 20 Dec 2012) Log Message Web Inspector: extract native heap graph representation into a separate file https://bugs.webkit.org/show_bug.cgi?id=105524 Reviewed by Alexander Pavlov. Moved native heap graph parser into NativeHeapGraph.js, renamed NativeHeapGraphNode to NativeHeapGraph.Node and NativeHeapGraphEdge to NativeHeapGraph.Edge Removed unused pie chart view. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/InspectorMemoryAgent.cpp: (WebCore::InspectorMemoryAgent::getProcessMemoryDistribution): fixed optional parameter handling * WebCore.gypi: * inspector/InspectorMemoryAgent.cpp: (WebCore::InspectorMemoryAgent::getProcessMemoryDistribution): * inspector/compile-front-end.py: * inspector/front-end/NativeHeapGraph.js: Added. (WebInspector.NativeHeapGraph): (WebInspector.NativeHeapGraph.prototype.rootNodes): (WebInspector.NativeHeapGraph.prototype._calculateNodeEdgeIndexes): (WebInspector.NativeHeapGraph.prototype._addDummyNode): (WebInspector.NativeHeapGraph.Edge): (WebInspector.NativeHeapGraph.Edge.prototype.type): (WebInspector.NativeHeapGraph.Edge.prototype.name): (WebInspector.NativeHeapGraph.Edge.prototype.target): (WebInspector.NativeHeapGraph.Edge.prototype._getStringField): (WebInspector.NativeHeapGraph.Edge.prototype.toString): (WebInspector.NativeHeapGraph.Node): (WebInspector.NativeHeapGraph.Node.prototype.id): (WebInspector.NativeHeapGraph.Node.prototype.type): (WebInspector.NativeHeapGraph.Node.prototype.size): (WebInspector.NativeHeapGraph.Node.prototype.className): (WebInspector.NativeHeapGraph.Node.prototype.name): (WebInspector.NativeHeapGraph.Node.prototype.hasReferencedNodes): (WebInspector.NativeHeapGraph.Node.prototype.referencedNodes): (WebInspector.NativeHeapGraph.Node.prototype.outgoingEdges): (WebInspector.NativeHeapGraph.Node.prototype.targetOfEdge): (WebInspector.NativeHeapGraph.Node.prototype.targetsOfAllEdges): (WebInspector.NativeHeapGraph.Node.prototype._firstEdgePoistion): (WebInspector.NativeHeapGraph.Node.prototype._afterLastEdgePosition): (WebInspector.NativeHeapGraph.Node.prototype._getStringField): (WebInspector.NativeHeapGraph.Node.prototype.toString): * inspector/front-end/NativeMemorySnapshotView.js: * inspector/front-end/ProfilesPanel.js: * inspector/front-end/WebKit.qrc: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp trunk/Source/WebCore/inspector/compile-front-end.py trunk/Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js trunk/Source/WebCore/inspector/front-end/WebKit.qrc Added Paths trunk/Source/WebCore/inspector/front-end/NativeHeapGraph.js Diff Modified: trunk/Source/WebCore/ChangeLog (138244 => 138245) --- trunk/Source/WebCore/ChangeLog 2012-12-20 12:43:56 UTC (rev 138244) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 13:01:42 UTC (rev 138245) @@ -1,3 +1,52 @@ +2012-12-20 Yury Semikhatsky yu...@chromium.org + +Web Inspector: extract native heap graph representation into a separate file +https://bugs.webkit.org/show_bug.cgi?id=105524 + +Reviewed by Alexander Pavlov. + +Moved native heap graph parser into NativeHeapGraph.js, renamed NativeHeapGraphNode to NativeHeapGraph.Node +and NativeHeapGraphEdge to NativeHeapGraph.Edge +Removed unused pie chart view. + +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* inspector/InspectorMemoryAgent.cpp: +(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution): fixed optional parameter handling +* WebCore.gypi: +* inspector/InspectorMemoryAgent.cpp: +(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution): +* inspector/compile-front-end.py: +* inspector/front-end/NativeHeapGraph.js: Added. +(WebInspector.NativeHeapGraph): +(WebInspector.NativeHeapGraph.prototype.rootNodes): +(WebInspector.NativeHeapGraph.prototype._calculateNodeEdgeIndexes): +(WebInspector.NativeHeapGraph.prototype._addDummyNode): +(WebInspector.NativeHeapGraph.Edge): +(WebInspector.NativeHeapGraph.Edge.prototype.type): +(WebInspector.NativeHeapGraph.Edge.prototype.name): +(WebInspector.NativeHeapGraph.Edge.prototype.target): +(WebInspector.NativeHeapGraph.Edge.prototype._getStringField): +(WebInspector.NativeHeapGraph.Edge.prototype.toString): +(WebInspector.NativeHeapGraph.Node): +(WebInspector.NativeHeapGraph.Node.prototype.id): +(WebInspector.NativeHeapGraph.Node.prototype.type): +(WebInspector.NativeHeapGraph.Node.prototype.size): +(WebInspector.NativeHeapGraph.Node.prototype.className): +
[webkit-changes] [138246] trunk/Tools
Title: [138246] trunk/Tools
Revision 138246
Author o...@webkit.org
Date 2012-12-20 05:45:47 -0800 (Thu, 20 Dec 2012)
Log Message
[Qt] EWS bots should call qmake always
https://bugs.webkit.org/show_bug.cgi?id=90049
Reviewed by Simon Hausmann.
* Scripts/webkitdirs.pm:
(buildQMakeProjects):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (138245 => 138246)
--- trunk/Tools/ChangeLog 2012-12-20 13:01:42 UTC (rev 138245)
+++ trunk/Tools/ChangeLog 2012-12-20 13:45:47 UTC (rev 138246)
@@ -1,3 +1,13 @@
+2012-12-20 Csaba Osztrogonác o...@webkit.org
+
+[Qt] EWS bots should call qmake always
+https://bugs.webkit.org/show_bug.cgi?id=90049
+
+Reviewed by Simon Hausmann.
+
+* Scripts/webkitdirs.pm:
+(buildQMakeProjects):
+
2012-12-20 Jochen Eisinger joc...@chromium.org
[chromium] fix stray printf in TestRunner's WebTestProxy
Modified: trunk/Tools/Scripts/webkitdirs.pm (138245 => 138246)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-12-20 13:01:42 UTC (rev 138245)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-12-20 13:45:47 UTC (rev 138246)
@@ -2356,6 +2356,11 @@
my $maybeNeedsCleanBuild = 0;
my $needsIncrementalBuild = 0;
+# Full incremental build (run qmake) needed on buildbots and EWS bots always.
+if (grep(/CONFIG\+=buildbot/,@buildParams)) {
+$needsIncrementalBuild = 1;
+}
+
if ($svnRevision ne $previousSvnRevision) {
print Last built revision was . $previousSvnRevision .
, now at revision $svnRevision. Full incremental build needed.\n;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138247] trunk/Source/WebCore
Title: [138247] trunk/Source/WebCore Revision 138247 Author hausm...@webkit.org Date 2012-12-20 05:48:24 -0800 (Thu, 20 Dec 2012) Log Message [Qt] JS bridge does not transmit QVariants anymore in Qt5 https://bugs.webkit.org/show_bug.cgi?id=104540 Patch by Simon Hausmann simon.hausm...@digia.com, Jedrzej Nowacki jedrzej.nowa...@digia.com on 2012-12-19 Reviewed by Kenneth Rohde Christiansen. A data corruption exists in the QObject bridge when calling slots that take a QVariant. The calling convention for slots is that the void* parameter array must contain pointers to the actually required destination argument type. If a function takes an int for example, the corresponding entry in the void* parameter array must be a pointer to an int that the moc generated code then can safely cast to an int* and dereference. Similarly if the function takes a QVariant it must be a pointer to a QVariant. We implement this calling convention by constructing QVariants of the requested parameter types and passing the value of data() into the void* parameter array. This works fine for all types except if the requested type is a QVariant. In that case data() will _not_ return a pointer that can later be safely casted to a QVariant pointer and dereferenced. Instead we must use the address of our variant to ensure a working cast. Our auto tests cover this case, but they worked by accident because the provided pointer when casted to a QVariant happens to have the correct type id that doesn't produce the warning seen in the test case of the provided example and the unit test just copies the QVariant and thus pointer. * bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtMethodMatchType::typeId): Replace string based meta type id determination of QVariant with a quicker table lookup. (JSC::Bindings::findMethodIndex): Remember the chosen (requested) types and pass the pointer to the QVariant instead of its data() pointer if requested. (JSC::Bindings::QtRuntimeMethod::call): Fixed determination of whether we need to convert a return value or not solely based on the return type _specified_ in the meta method instead of the variant value returned. The latter is not sufficient because a slot can return an invalid variant, which is not the same as returning void. This was triggered by an unit test that accidentally passed due to this memory corruption in the first place. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bridge/qt/qt_runtime.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (138246 => 138247) --- trunk/Source/WebCore/ChangeLog 2012-12-20 13:45:47 UTC (rev 138246) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 13:48:24 UTC (rev 138247) @@ -1,3 +1,49 @@ +2012-12-19 Simon Hausmann simon.hausm...@digia.com, Jedrzej Nowacki jedrzej.nowa...@digia.com + +[Qt] JS bridge does not transmit QVariants anymore in Qt5 +https://bugs.webkit.org/show_bug.cgi?id=104540 + +Reviewed by Kenneth Rohde Christiansen. + +A data corruption exists in the QObject bridge when calling slots that +take a QVariant. + +The calling convention for slots is that the void* parameter array must +contain pointers to the actually required destination argument type. If +a function takes an int for example, the corresponding entry in the +void* parameter array must be a pointer to an int that the moc +generated code then can safely cast to an int* and dereference. +Similarly if the function takes a QVariant it must be a pointer to a +QVariant. + +We implement this calling convention by constructing QVariants of the +requested parameter types and passing the value of data() into the +void* parameter array. This works fine for all types except if the +requested type is a QVariant. In that case data() will _not_ return a +pointer that can later be safely casted to a QVariant pointer and +dereferenced. Instead we must use the address of our variant to ensure +a working cast. + +Our auto tests cover this case, but they worked by accident because the +provided pointer when casted to a QVariant happens to have the correct +type id that doesn't produce the warning seen in the test case of the +provided example and the unit test just copies the QVariant and thus +pointer. + +* bridge/qt/qt_runtime.cpp: +(JSC::Bindings::QtMethodMatchType::typeId): Replace string based meta +type id determination of QVariant with a quicker table lookup. +(JSC::Bindings::findMethodIndex): Remember the chosen (requested) types +and pass the pointer to the QVariant instead of its data() pointer if +requested. +(JSC::Bindings::QtRuntimeMethod::call): Fixed determination of whether +we need to convert a return value or not solely based on the return +type _specified_ in the meta method instead of the
[webkit-changes] [138248] trunk
Title: [138248] trunk Revision 138248 Author dominik.rottsc...@intel.com Date 2012-12-20 06:09:05 -0800 (Thu, 20 Dec 2012) Log Message [EFL] MiniBrowser does not play Infinite Gangnam Style https://bugs.webkit.org/show_bug.cgi?id=103531 Reviewed by Kenneth Rohde Christiansen. .: WebAudio now switched to ON for EFL. * Source/cmake/OptionsEfl.cmake: Source/WebCore: Specifying additional define to avoid deprecation warning. No new tests, compile time change which doesn't affect behavior. * PlatformEfl.cmake: Source/WebKit2: WebAudio preference now defaults to switched on. * UIProcess/API/efl/EwkViewImpl.cpp: (EwkViewImpl::EwkViewImpl): Tools: For EFL we would like this feature to be built by default. * Scripts/webkitperl/FeatureList.pm: LayoutTests: Marked remaining webaudio failures. * platform/efl/TestExpectations: Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp trunk/Source/cmake/OptionsEfl.cmake trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitperl/FeatureList.pm Diff Modified: trunk/ChangeLog (138247 => 138248) --- trunk/ChangeLog 2012-12-20 13:48:24 UTC (rev 138247) +++ trunk/ChangeLog 2012-12-20 14:09:05 UTC (rev 138248) @@ -1,3 +1,14 @@ +2012-12-20 Dominik Röttsches dominik.rottsc...@intel.com + +[EFL] MiniBrowser does not play Infinite Gangnam Style +https://bugs.webkit.org/show_bug.cgi?id=103531 + +Reviewed by Kenneth Rohde Christiansen. + +WebAudio now switched to ON for EFL. + +* Source/cmake/OptionsEfl.cmake: + 2012-12-19 Yael Aharon yael.aha...@intel.com [EFL] Allow the build system to find OpenGL ES Modified: trunk/LayoutTests/ChangeLog (138247 => 138248) --- trunk/LayoutTests/ChangeLog 2012-12-20 13:48:24 UTC (rev 138247) +++ trunk/LayoutTests/ChangeLog 2012-12-20 14:09:05 UTC (rev 138248) @@ -1,3 +1,14 @@ +2012-12-20 Dominik Röttsches dominik.rottsc...@intel.com + +[EFL] MiniBrowser does not play Infinite Gangnam Style +https://bugs.webkit.org/show_bug.cgi?id=103531 + +Reviewed by Kenneth Rohde Christiansen. + +Marked remaining webaudio failures. + +* platform/efl/TestExpectations: + 2012-12-20 Csaba Osztrogonác o...@webkit.org Unreviewed gardening, skip a crashing test to paint the bots green. Modified: trunk/LayoutTests/platform/efl/TestExpectations (138247 => 138248) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-12-20 13:48:24 UTC (rev 138247) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-12-20 14:09:05 UTC (rev 138248) @@ -646,6 +646,13 @@ webkit.org/b/100519 fast/images/paletted-png-with-color-profile.html [ Skip ] # +# CRASHES +# + +webkit.org/b/105299 webaudio/_javascript_audionode.html [ Crash ] +webkit.org/b/105299 webaudio/_javascript_audionode-upmix2-8channel-input.html [ Pass Crash ] + +# # FLAKY TESTS # @@ -762,6 +769,8 @@ webkit.org/b/105280 http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html [ Failure Pass ] webkit.org/b/105280 http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html [ Failure Pass ] +webkit.org/b/105296 webaudio/delaynode-maxdelay.html [ Failure Pass ] + # # FAILING TESTS # @@ -1159,11 +1168,6 @@ webkit.org/b/88080 pointer-lock [ Skip ] webkit.org/b/88080 http/tests/pointer-lock [ Skip ] -# Requires WEB_AUDIO support. -webkit.org/b/91738 webaudio [ Skip ] -webkit.org/b/91738 inspector-protocol/nmi-webaudio.html [ Skip ] -webkit.org/b/91738 inspector-protocol/nmi-webaudio-leak-test.html [ Skip ] - # Requires MEDIA_STREAM support. webkit.org/b/87662 fast/mediastream [ Skip ] @@ -1729,5 +1733,26 @@ webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes.html [ ImageOnlyFailure Crash ] webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes-repaint.html [ ImageOnlyFailure Crash ] -# Failing touch events case -webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ] +# Failing touch events case +webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ] + +# WebAudio remaining issues +webkit.org/b/105289 webaudio/mediastreamaudiosourcenode.html [ Failure ] +webkit.org/b/105289 webaudio/mediastreamaudiodestinationnode.html [
[webkit-changes] [138249] trunk/Tools
Title: [138249] trunk/Tools Revision 138249 Author carlo...@webkit.org Date 2012-12-20 06:47:45 -0800 (Thu, 20 Dec 2012) Log Message Unreviewed. Skip unit test WebKit2.ForceRepaint that times out * Scripts/run-gtk-tests: (TestRunner): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests Diff Modified: trunk/Tools/ChangeLog (138248 => 138249) --- trunk/Tools/ChangeLog 2012-12-20 14:09:05 UTC (rev 138248) +++ trunk/Tools/ChangeLog 2012-12-20 14:47:45 UTC (rev 138249) @@ -1,3 +1,10 @@ +2012-12-20 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Skip unit test WebKit2.ForceRepaint that times out + +* Scripts/run-gtk-tests: +(TestRunner): + 2012-12-20 Dominik Röttsches dominik.rottsc...@intel.com [EFL] MiniBrowser does not play Infinite Gangnam Style Modified: trunk/Tools/Scripts/run-gtk-tests (138248 => 138249) --- trunk/Tools/Scripts/run-gtk-tests 2012-12-20 14:09:05 UTC (rev 138248) +++ trunk/Tools/Scripts/run-gtk-tests 2012-12-20 14:47:45 UTC (rev 138249) @@ -79,6 +79,7 @@ SkippedTest(TestWebKitAPI/TestWebKit2, WebKit2.SpacebarScrolling, Test fails, 84961), SkippedTest(TestWebKitAPI/TestWebKit2, WebKit2.WKConnection, Tests fail and time out out, 84959), SkippedTest(TestWebKitAPI/TestWebKit2, WebKit2.WKPageGetScaleFactorNotZero, Test fails and times out, 88455), +SkippedTest(TestWebKitAPI/TestWebKit2, WebKit2.ForceRepaint, Test times out, 105532), ] def __init__(self, options, tests=[]): ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138251] trunk/LayoutTests
Title: [138251] trunk/LayoutTests Revision 138251 Author dominik.rottsc...@intel.com Date 2012-12-20 07:14:58 -0800 (Thu, 20 Dec 2012) Log Message [EFL] Unreviewed gardening. Marking inspector-protocol/nmi-webaudio* tests as failing, they don't work yet after r138248. * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138250 => 138251) --- trunk/LayoutTests/ChangeLog 2012-12-20 14:54:17 UTC (rev 138250) +++ trunk/LayoutTests/ChangeLog 2012-12-20 15:14:58 UTC (rev 138251) @@ -1,3 +1,12 @@ +2012-12-20 Dominik Röttsches dominik.rottsc...@intel.com + +[EFL] Unreviewed gardening. + +Marking inspector-protocol/nmi-webaudio* tests as failing, +they don't work yet after r138248. + +* platform/efl/TestExpectations: + 2012-12-20 Florin Malita fmal...@chromium.org Incorrect color space conversion for FEImage Modified: trunk/LayoutTests/platform/efl/TestExpectations (138250 => 138251) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-12-20 14:54:17 UTC (rev 138250) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-12-20 15:14:58 UTC (rev 138251) @@ -1799,3 +1799,5 @@ webkit.org/b/105297 webaudio/audiobuffersource-loop-points.html [ Failure ] webkit.org/b/105297 webaudio/audiobuffersource-playbackrate.html [ Failure ] webkit.org/b/105298 webaudio/decode-audio-data-basic.html [ Failure ] +webkit.org/b/105535 inspector-protocol/nmi-webaudio.html [ Failure ] +webkit.org/b/105535 inspector-protocol/nmi-webaudio-leak-test.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138252] trunk
Title: [138252] trunk Revision 138252 Author zandober...@gmail.com Date 2012-12-20 07:26:35 -0800 (Thu, 20 Dec 2012) Log Message [GTK] Remove the --enable-unstable-features configuration option https://bugs.webkit.org/show_bug.cgi?id=105327 Reviewed by Martin Robinson. .: Remove the unnecessary feature_defines_unstable variable. Remove the unstable-features configuration option. * configure.ac: * GNUmakefile.am: Source/WebCore: Remove the ENABLE_UNSTABLE_FEATURES guards in various GNUmakefiles now that the configuration option is removed. No new tests - no new testable functionality. * GNUmakefile.am: Remove the ENABLE_UNSTABLE_FEATURES guards in GNUmakefile.am where they were used to override certain feature define values in case of a release build. * GNUmakefile.features.am.in: Adjust the default value for the feature defines that were previously overriden in release builds. This feature define list will eventually represent feature status in release builds with overriding being done through build-webkit. * bindings/gobject/GNUmakefile.am: Move the DOM bindings targets that were previously guarded by the ENABLE_UNSTABLE_FEATURES guards to the common listing of the video-dependent DOM bindings. Tools: Add a missing feature option for the CSS sticky position feature. * Scripts/webkitperl/FeatureList.pm: Modified Paths trunk/ChangeLog trunk/GNUmakefile.am trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/GNUmakefile.features.am.in trunk/Source/WebCore/bindings/gobject/GNUmakefile.am trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitperl/FeatureList.pm trunk/configure.ac Diff Modified: trunk/ChangeLog (138251 => 138252) --- trunk/ChangeLog 2012-12-20 15:14:58 UTC (rev 138251) +++ trunk/ChangeLog 2012-12-20 15:26:35 UTC (rev 138252) @@ -1,3 +1,16 @@ +2012-12-20 Zan Dobersek zandober...@gmail.com + +[GTK] Remove the --enable-unstable-features configuration option +https://bugs.webkit.org/show_bug.cgi?id=105327 + +Reviewed by Martin Robinson. + +Remove the unnecessary feature_defines_unstable variable. +Remove the unstable-features configuration option. + +* configure.ac: +* GNUmakefile.am: + 2012-12-20 Dominik Röttsches dominik.rottsc...@intel.com [EFL] MiniBrowser does not play Infinite Gangnam Style Modified: trunk/GNUmakefile.am (138251 => 138252) --- trunk/GNUmakefile.am 2012-12-20 15:14:58 UTC (rev 138251) +++ trunk/GNUmakefile.am 2012-12-20 15:26:35 UTC (rev 138252) @@ -62,7 +62,6 @@ ALL_MOFILES := feature_defines_defaults := feature_defines_overrides := -feature_defines_unstable := feature_defines := dom_binding_idls := wtf_sources := Modified: trunk/Source/WebCore/ChangeLog (138251 => 138252) --- trunk/Source/WebCore/ChangeLog 2012-12-20 15:14:58 UTC (rev 138251) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 15:26:35 UTC (rev 138252) @@ -1,3 +1,23 @@ +2012-12-20 Zan Dobersek zandober...@gmail.com + +[GTK] Remove the --enable-unstable-features configuration option +https://bugs.webkit.org/show_bug.cgi?id=105327 + +Reviewed by Martin Robinson. + +Remove the ENABLE_UNSTABLE_FEATURES guards in various GNUmakefiles now that +the configuration option is removed. + +No new tests - no new testable functionality. + +* GNUmakefile.am: Remove the ENABLE_UNSTABLE_FEATURES guards in GNUmakefile.am +where they were used to override certain feature define values in case of a release build. +* GNUmakefile.features.am.in: Adjust the default value for the feature defines that were +previously overriden in release builds. This feature define list will eventually represent +feature status in release builds with overriding being done through build-webkit. +* bindings/gobject/GNUmakefile.am: Move the DOM bindings targets that were previously guarded +by the ENABLE_UNSTABLE_FEATURES guards to the common listing of the video-dependent DOM bindings. + 2012-12-20 Florin Malita fmal...@chromium.org Incorrect color space conversion for FEImage Modified: trunk/Source/WebCore/GNUmakefile.am (138251 => 138252) --- trunk/Source/WebCore/GNUmakefile.am 2012-12-20 15:14:58 UTC (rev 138251) +++ trunk/Source/WebCore/GNUmakefile.am 2012-12-20 15:26:35 UTC (rev 138252) @@ -342,23 +342,7 @@ feature_defines_overrides += ENABLE_SPELLCHECK=0 endif # END ENABLE_SPELLCHECK -# --- -# Unstable features -# If unstable features should not be enabled, their defines should be overriden with a 0 value. -# --- -if !ENABLE_UNSTABLE_FEATURES -feature_defines_unstable += \ - ENABLE_CSP_NEXT=0 \ - ENABLE_CSS3_TEXT=0 \ - ENABLE_CSS_STICKY_POSITION=0 \ - ENABLE_LINK_PREFETCH=0 \ - ENABLE_MICRODATA=0 \ - ENABLE_MUTATION_OBSERVERS=0 \ - ENABLE_STYLE_SCOPED=0 \ - ENABLE_VIDEO_TRACK=0 -endif - # Fill the feature_defines variable with all the defines, making it possible # to override
[webkit-changes] [138253] trunk/Tools
Title: [138253] trunk/Tools
Revision 138253
Author thiago.san...@intel.com
Date 2012-12-20 07:28:26 -0800 (Thu, 20 Dec 2012)
Log Message
[Qt] Move ImageDiff to the Tools directory root
https://bugs.webkit.org/show_bug.cgi?id=105420
Reviewed by Tor Arne Vestbø.
Moved ImageDiff from outside DumpRenderTree because it is also a
dependency when running pixel tests for WebKit2.
* ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
* ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
* Tools.pro:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Tools.pro
Added Paths
trunk/Tools/ImageDiff/ImageDiff.pro
trunk/Tools/ImageDiff/qt/
trunk/Tools/ImageDiff/qt/ImageDiff.cpp
Removed Paths
trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp
trunk/Tools/DumpRenderTree/qt/ImageDiff.pro
Diff
Modified: trunk/Tools/ChangeLog (138252 => 138253)
--- trunk/Tools/ChangeLog 2012-12-20 15:26:35 UTC (rev 138252)
+++ trunk/Tools/ChangeLog 2012-12-20 15:28:26 UTC (rev 138253)
@@ -1,3 +1,17 @@
+2012-12-20 Thiago Marcos P. Santos thiago.san...@intel.com
+
+[Qt] Move ImageDiff to the Tools directory root
+https://bugs.webkit.org/show_bug.cgi?id=105420
+
+Reviewed by Tor Arne Vestbø.
+
+Moved ImageDiff from outside DumpRenderTree because it is also a
+dependency when running pixel tests for WebKit2.
+
+* ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
+* ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
+* Tools.pro:
+
2012-12-20 Zan Dobersek zandober...@gmail.com
[GTK] Remove the --enable-unstable-features configuration option
Deleted: trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp (138252 => 138253)
--- trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp 2012-12-20 15:26:35 UTC (rev 138252)
+++ trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp 2012-12-20 15:28:26 UTC (rev 138253)
@@ -1,153 +0,0 @@
-/*
-Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies)
-
-This library is free software; you can redistribute it and/or
-modify it under the terms of the GNU Library General Public
-License as published by the Free Software Foundation; either
-version 2 of the License, or (at your option) any later version.
-
-This library is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
-Library General Public License for more details.
-
-You should have received a copy of the GNU Library General Public License
-along with this library; see the file COPYING.LIB. If not, write to
-the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
-Boston, MA 02110-1301, USA.
-*/
-
-#include QtCore/qmath.h
-
-#include QApplication
-#include QBuffer
-#include QByteArray
-#include QImage
-#include QStringList
-
-#include stdio.h
-
-int main(int argc, char* argv[])
-{
-QCoreApplication app(argc, argv);
-
-qreal tolerance = 0;
-
-QStringList args = app.arguments();
-for (int i = 0; i argc; ++i)
-if (args[i] == -t || args[i] == --tolerance)
-tolerance = args[i + 1].toDouble();
-
-char buffer[2048];
-QImage actualImage;
-QImage baselineImage;
-
-while (fgets(buffer, sizeof(buffer), stdin)) {
-// remove the CR
-char* newLineCharacter = strchr(buffer, '\n');
-if (newLineCharacter)
-*newLineCharacter = '\0';
-
-if (!strncmp(Content-Length: , buffer, 16)) {
-strtok(buffer, );
-int imageSize = strtol(strtok(0, ), 0, 10);
-
-if (imageSize = 0) {
-fputs(error, image size must be specified.\n, stdout);
-} else {
-unsigned char buffer[2048];
-QBuffer data;
-
-// Read all the incoming chunks
-data.open(QBuffer::WriteOnly);
-while (imageSize 0) {
-size_t bytesToRead = qMin(imageSize, 2048);
-size_t bytesRead = fread(buffer, 1, bytesToRead, stdin);
-data.write(reinterpret_castconst char*(buffer), bytesRead);
-imageSize -= static_castint(bytesRead);
-}
-
-// Convert into QImage
-QImage decodedImage;
-decodedImage.loadFromData(data.data(), PNG);
-decodedImage.convertToFormat(QImage::Format_ARGB32);
-
-// Place it in the right place
-if (actualImage.isNull())
-actualImage = decodedImage;
-else
-baselineImage = decodedImage;
-}
-}
-
-if (!actualImage.isNull() !baselineImage.isNull()) {
-
-if (actualImage.size() != baselineImage.size()) {
-
[webkit-changes] [138254] trunk/Source/WebCore
Title: [138254] trunk/Source/WebCore
Revision 138254
Author commit-qu...@webkit.org
Date 2012-12-20 07:50:14 -0800 (Thu, 20 Dec 2012)
Log Message
INPUT_MULTIPLE_FIELDS_UI: Add minimum/maximum value to DateTimeEditElement::LayoutParameters
https://bugs.webkit.org/show_bug.cgi?id=105510
Patch by Kunihiko Sakamoto ksakam...@chromium.org on 2012-12-20
Reviewed by Kent Tamura.
Add two DateComponents fields, minimum and maximum, to DateTimeEditElement::LayoutParameters, replacing minimumYear and maximumYear.
They will be used to limit selectable values of month, day, etc.
No new tests. No behavior change.
* html/BaseMultipleFieldsDateAndTimeInputType.cpp: Removed fullYear().
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Ditto.
* html/DateInputType.cpp:
(WebCore::DateInputType::setupLayoutParameters): Populates minimum/maximum.
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::setupLayoutParameters): Ditto.
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::setupLayoutParameters): Ditto.
* html/MonthInputType.cpp:
(WebCore::MonthInputType::setupLayoutParameters): Ditto.
* html/WeekInputType.cpp:
(WebCore::WeekInputType::setupLayoutParameters): Ditto.
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitField): Replace the usage of minimumYear/maximumYear with minimum/maximum DateComponents.
* html/shadow/DateTimeEditElement.h:
(LayoutParameters): Removed minimumYear, maximumYear, and undefinedYear(), and added minimum and maximum fields.
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp
trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h
trunk/Source/WebCore/html/DateInputType.cpp
trunk/Source/WebCore/html/DateTimeInputType.cpp
trunk/Source/WebCore/html/DateTimeLocalInputType.cpp
trunk/Source/WebCore/html/MonthInputType.cpp
trunk/Source/WebCore/html/WeekInputType.cpp
trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp
trunk/Source/WebCore/html/shadow/DateTimeEditElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138253 => 138254)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 15:28:26 UTC (rev 138253)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 15:50:14 UTC (rev 138254)
@@ -1,3 +1,34 @@
+2012-12-20 Kunihiko Sakamoto ksakam...@chromium.org
+
+INPUT_MULTIPLE_FIELDS_UI: Add minimum/maximum value to DateTimeEditElement::LayoutParameters
+https://bugs.webkit.org/show_bug.cgi?id=105510
+
+Reviewed by Kent Tamura.
+
+Add two DateComponents fields, minimum and maximum, to DateTimeEditElement::LayoutParameters, replacing minimumYear and maximumYear.
+They will be used to limit selectable values of month, day, etc.
+
+No new tests. No behavior change.
+
+* html/BaseMultipleFieldsDateAndTimeInputType.cpp: Removed fullYear().
+* html/BaseMultipleFieldsDateAndTimeInputType.h:
+(BaseMultipleFieldsDateAndTimeInputType): Ditto.
+* html/DateInputType.cpp:
+(WebCore::DateInputType::setupLayoutParameters): Populates minimum/maximum.
+* html/DateTimeInputType.cpp:
+(WebCore::DateTimeInputType::setupLayoutParameters): Ditto.
+* html/DateTimeLocalInputType.cpp:
+(WebCore::DateTimeLocalInputType::setupLayoutParameters): Ditto.
+* html/MonthInputType.cpp:
+(WebCore::MonthInputType::setupLayoutParameters): Ditto.
+* html/WeekInputType.cpp:
+(WebCore::WeekInputType::setupLayoutParameters): Ditto.
+* html/shadow/DateTimeEditElement.cpp:
+(WebCore::DateTimeEditBuilder::visitField): Replace the usage of minimumYear/maximumYear with minimum/maximum DateComponents.
+* html/shadow/DateTimeEditElement.h:
+(LayoutParameters): Removed minimumYear, maximumYear, and undefinedYear(), and added minimum and maximum fields.
+(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters):
+
2012-12-20 Zan Dobersek zandober...@gmail.com
[GTK] Remove the --enable-unstable-features configuration option
Modified: trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp (138253 => 138254)
--- trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp 2012-12-20 15:28:26 UTC (rev 138253)
+++ trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp 2012-12-20 15:50:14 UTC (rev 138254)
@@ -422,14 +422,6 @@
m_pickerIndicatorElement-removeInlineStyleProperty(CSSPropertyDisplay);
}
-int BaseMultipleFieldsDateAndTimeInputType::fullYear(const String source) const
-{
-DateComponents date;
-if (!parseToDateComponents(source, date))
-return DateTimeEditElement::LayoutParameters::undefinedYear();
-return date.fullYear();
-}
-
bool BaseMultipleFieldsDateAndTimeInputType::shouldHaveSecondField(const DateComponents date) const
{
[webkit-changes] [138255] trunk/LayoutTests
Title: [138255] trunk/LayoutTests
Revision 138255
Author commit-qu...@webkit.org
Date 2012-12-20 08:00:00 -0800 (Thu, 20 Dec 2012)
Log Message
Fix tests depend on current year
https://bugs.webkit.org/show_bug.cgi?id=105525
Patch by Kunihiko Sakamoto ksakam...@chromium.org on 2012-12-20
Reviewed by Kent Tamura.
Current year was embedded in several expectation files unintentionally.
* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
* fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt:
* fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt
trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html
trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt
trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html
trunk/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt
trunk/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138254 => 138255)
--- trunk/LayoutTests/ChangeLog 2012-12-20 15:50:14 UTC (rev 138254)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 16:00:00 UTC (rev 138255)
@@ -1,3 +1,19 @@
+2012-12-20 Kunihiko Sakamoto ksakam...@chromium.org
+
+Fix tests depend on current year
+https://bugs.webkit.org/show_bug.cgi?id=105525
+
+Reviewed by Kent Tamura.
+
+Current year was embedded in several expectation files unintentionally.
+
+* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
+* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
+* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
+* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
+* fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt:
+* fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html:
+
2012-12-20 Dominik Röttsches dominik.rottsc...@intel.com
[EFL] Unreviewed gardening.
Modified: trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt (138254 => 138255)
--- trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt 2012-12-20 15:50:14 UTC (rev 138254)
+++ trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt 2012-12-20 16:00:00 UTC (rev 138255)
@@ -21,9 +21,9 @@
PASS input.value is 2012-10-29
PASS input.value is 2012-08-29
== Up/Down keys on empty value ==
-PASS input.value is 2012-11-01
+PASS input.value is currentYear + -11-01
== Up/Down keys on empty value 2 ==
-PASS input.value is 2012-02-28
+PASS input.value is currentYear + -02-28
== Tab key ==
PASS input.value is 2012-09-05
PASS input.value is 2012-09-07
Modified: trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html (138254 => 138255)
--- trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html 2012-12-20 15:50:14 UTC (rev 138254)
+++ trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html 2012-12-20 16:00:00 UTC (rev 138255)
@@ -94,7 +94,7 @@
keyDown('rightArrow'); // - 11/01/[]
var currentYear = new Date().getFullYear();
keyDown('upArrow'); // - 11/01/[current year]
-shouldBeEqualToString('input.value', currentYear + '-11-01');
+shouldBe('input.value', 'currentYear + -11-01');
beginTest('Up/Down keys on empty value 2');
keyDown('upArrow'); //- [01]/dd/
@@ -107,7 +107,7 @@
keyDown('rightArrow'); // - 02/28/[]
currentYear = new Date().getFullYear();
keyDown('downArrow'); // - 02/28/[current year]
-shouldBeEqualToString('input.value', currentYear + '-02-28');
+shouldBe('input.value', 'currentYear + -02-28');
beginTest('Tab key', '2012-09-30');
keyDown('\t'); // - 09/[30]/2012
Modified: trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt (138254 => 138255)
--- trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt 2012-12-20 15:50:14 UTC (rev 138254)
+++
[webkit-changes] [138256] trunk/Tools
Title: [138256] trunk/Tools Revision 138256 Author carlo...@webkit.org Date 2012-12-20 08:12:31 -0800 (Thu, 20 Dec 2012) Log Message Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate * Scripts/run-gtk-tests: (TestRunner): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests Diff Modified: trunk/Tools/ChangeLog (138255 => 138256) --- trunk/Tools/ChangeLog 2012-12-20 16:00:00 UTC (rev 138255) +++ trunk/Tools/ChangeLog 2012-12-20 16:12:31 UTC (rev 138256) @@ -1,3 +1,10 @@ +2012-12-20 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate + +* Scripts/run-gtk-tests: +(TestRunner): + 2012-12-20 Thiago Marcos P. Santos thiago.san...@intel.com [Qt] Move ImageDiff to the Tools directory root Modified: trunk/Tools/Scripts/run-gtk-tests (138255 => 138256) --- trunk/Tools/Scripts/run-gtk-tests 2012-12-20 16:00:00 UTC (rev 138255) +++ trunk/Tools/Scripts/run-gtk-tests 2012-12-20 16:12:31 UTC (rev 138256) @@ -66,6 +66,7 @@ SkippedTest(unittests/testwebresource, /webkit/webresource/loading, Test fails, 104689), SkippedTest(unittests/testwebresource, /webkit/webresource/sub_resource_loading, Test fails in GTK Linux 64-bit Release bot, 82330), SkippedTest(unittests/testwebview, /webkit/webview/icon-uri, Test times out in GTK Linux 64-bit Release bot, 82328), +SkippedTest(unittests/testatk, /webkit/atk/getTextInParagraphAndBodyModerate, Test fails, 105538), SkippedTest(WebKit2APITests/TestResources, /webkit2/WebKitWebView/resources, Test is flaky in GTK Linux 32-bit Release bot, 82868), SkippedTest(WebKit2APITests/TestWebKitAccessibility, /webkit2/WebKitAccessibility/atspi-basic-hierarchy, Test fails, 100408), SkippedTest(WebKit2APITests/TestWebKitFindController, /webkit2/WebKitFindController/hide, Test always fails in Xvfb, 89810), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138257] trunk/LayoutTests
Title: [138257] trunk/LayoutTests
Revision 138257
Author commit-qu...@webkit.org
Date 2012-12-20 08:22:37 -0800 (Thu, 20 Dec 2012)
Log Message
2 fast/filesystem test cases ask for more space than the size they request when creating the file system
https://bugs.webkit.org/show_bug.cgi?id=105307
Patch by Lianghui Chen liac...@rim.com on 2012-12-20
Reviewed by Yong Li.
The purpose of this patch is to make these 2 test cases conform to the
size limit, so for platform that wants to enforce the size limit they
will not fail due to quota limit.
* fast/filesystem/resources/file-writer-abort-continue.js:
* fast/filesystem/resources/op-get-metadata.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/filesystem/resources/file-writer-abort-continue.js
trunk/LayoutTests/fast/filesystem/resources/op-get-metadata.js
Diff
Modified: trunk/LayoutTests/ChangeLog (138256 => 138257)
--- trunk/LayoutTests/ChangeLog 2012-12-20 16:12:31 UTC (rev 138256)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 16:22:37 UTC (rev 138257)
@@ -1,3 +1,17 @@
+2012-12-20 Lianghui Chen liac...@rim.com
+
+2 fast/filesystem test cases ask for more space than the size they request when creating the file system
+https://bugs.webkit.org/show_bug.cgi?id=105307
+
+Reviewed by Yong Li.
+
+The purpose of this patch is to make these 2 test cases conform to the
+size limit, so for platform that wants to enforce the size limit they
+will not fail due to quota limit.
+
+* fast/filesystem/resources/file-writer-abort-continue.js:
+* fast/filesystem/resources/op-get-metadata.js:
+
2012-12-20 Kunihiko Sakamoto ksakam...@chromium.org
Fix tests depend on current year
Modified: trunk/LayoutTests/fast/filesystem/resources/file-writer-abort-continue.js (138256 => 138257)
--- trunk/LayoutTests/fast/filesystem/resources/file-writer-abort-continue.js 2012-12-20 16:12:31 UTC (rev 138256)
+++ trunk/LayoutTests/fast/filesystem/resources/file-writer-abort-continue.js 2012-12-20 16:22:37 UTC (rev 138257)
@@ -16,6 +16,12 @@
var currentTest = 0;
var blob = getBlob();
+// fileSystemOverhead is an estimate of extra size needed to save a full file
+// system, it need to be large enough to avoid test failure due to file system
+// quota limit.
+var fileSystemOverhead = blobSize * 5 / 1000 + 1024;
+var fileSystemSize = blobSize * 2 + fileSystemOverhead;
+
var methodSet = [
{ // Setup method set that writes, then aborts that write before completion.
action : startWrite,
@@ -174,7 +180,7 @@
}
var jsTestIsAsync = true;
-setupAndRunTest(2*1024*1024, 'file-writer-abort',
+setupAndRunTest(fileSystemSize, 'file-writer-abort',
function (fileEntry, fileWriter) {
fileEntryForCleanup = fileEntry;
writer = fileWriter;
Modified: trunk/LayoutTests/fast/filesystem/resources/op-get-metadata.js (138256 => 138257)
--- trunk/LayoutTests/fast/filesystem/resources/op-get-metadata.js 2012-12-20 16:12:31 UTC (rev 138256)
+++ trunk/LayoutTests/fast/filesystem/resources/op-get-metadata.js 2012-12-20 16:22:37 UTC (rev 138257)
@@ -5,7 +5,7 @@
{fullPath:'/tmp'},
{fullPath:'/file1', size:0},
{fullPath:'/file2', size:10},
-{fullPath:'/file3', size:100},
+{fullPath:'/file3', size:90},
],
tests: [
function(helper) { helper.getMetadata('/'); },
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138258] trunk
Title: [138258] trunk
Revision 138258
Author carlo...@webkit.org
Date 2012-12-20 08:45:57 -0800 (Thu, 20 Dec 2012)
Log Message
[Qt]REGRESSION(r138222): It made fast/forms/number/number-spinbutton-click-in-iframe.html crash
https://bugs.webkit.org/show_bug.cgi?id=105529
Reviewed by Nate Chapin.
Source/WebCore:
Make sure assignIdentifierToInitialRequest() and
dispatchWillSendRequest() are called before all other
notification callbacks for the substitute data.
Fixes a crash in fast/forms/number/number-spinbutton-click-in-iframe.html.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::load): Call
handleSubstituteDataLoadSoon() after assigning the substitute data
identifier.
LayoutTests:
* platform/qt/TestExpectations: Unskip
fast/forms/number/number-spinbutton-click-in-iframe.html.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/MainResourceLoader.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (138257 => 138258)
--- trunk/LayoutTests/ChangeLog 2012-12-20 16:22:37 UTC (rev 138257)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 16:45:57 UTC (rev 138258)
@@ -1,3 +1,13 @@
+2012-12-20 Carlos Garcia Campos cgar...@igalia.com
+
+[Qt]REGRESSION(r138222): It made fast/forms/number/number-spinbutton-click-in-iframe.html crash
+https://bugs.webkit.org/show_bug.cgi?id=105529
+
+Reviewed by Nate Chapin.
+
+* platform/qt/TestExpectations: Unskip
+fast/forms/number/number-spinbutton-click-in-iframe.html.
+
2012-12-20 Lianghui Chen liac...@rim.com
2 fast/filesystem test cases ask for more space than the size they request when creating the file system
Modified: trunk/LayoutTests/platform/qt/TestExpectations (138257 => 138258)
--- trunk/LayoutTests/platform/qt/TestExpectations 2012-12-20 16:22:37 UTC (rev 138257)
+++ trunk/LayoutTests/platform/qt/TestExpectations 2012-12-20 16:45:57 UTC (rev 138258)
@@ -2497,6 +2497,3 @@
http/tests/xmlhttprequest/post-blob-content-type-sync.html
webkit.org/b/104788 css3/flexbox/flex-algorithm.html [ Failure ]
-
-# [Qt]REGRESSION(r138222): It made fast/forms/number/number-spinbutton-click-in-iframe.html crash
-webkit.org/b/105529 fast/forms/number/number-spinbutton-click-in-iframe.html
Modified: trunk/Source/WebCore/ChangeLog (138257 => 138258)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 16:22:37 UTC (rev 138257)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 16:45:57 UTC (rev 138258)
@@ -1,3 +1,21 @@
+2012-12-20 Carlos Garcia Campos cgar...@igalia.com
+
+[Qt]REGRESSION(r138222): It made fast/forms/number/number-spinbutton-click-in-iframe.html crash
+https://bugs.webkit.org/show_bug.cgi?id=105529
+
+Reviewed by Nate Chapin.
+
+Make sure assignIdentifierToInitialRequest() and
+dispatchWillSendRequest() are called before all other
+notification callbacks for the substitute data.
+
+Fixes a crash in fast/forms/number/number-spinbutton-click-in-iframe.html.
+
+* loader/MainResourceLoader.cpp:
+(WebCore::MainResourceLoader::load): Call
+handleSubstituteDataLoadSoon() after assigning the substitute data
+identifier.
+
2012-12-20 Kunihiko Sakamoto ksakam...@chromium.org
INPUT_MULTIPLE_FIELDS_UI: Add minimum/maximum value to DateTimeEditElement::LayoutParameters
Modified: trunk/Source/WebCore/loader/MainResourceLoader.cpp (138257 => 138258)
--- trunk/Source/WebCore/loader/MainResourceLoader.cpp 2012-12-20 16:22:37 UTC (rev 138257)
+++ trunk/Source/WebCore/loader/MainResourceLoader.cpp 2012-12-20 16:45:57 UTC (rev 138258)
@@ -643,10 +643,10 @@
documentLoader()-applicationCacheHost()-maybeLoadMainResource(request, m_substituteData);
if (m_substituteData.isValid()) {
-handleSubstituteDataLoadSoon(request);
m_substituteDataLoadIdentifier = m_documentLoader-frame()-page()-progress()-createUniqueIdentifier();
frameLoader()-notifier()-assignIdentifierToInitialRequest(m_substituteDataLoadIdentifier, documentLoader(), request);
frameLoader()-notifier()-dispatchWillSendRequest(documentLoader(), m_substituteDataLoadIdentifier, request, ResourceResponse());
+handleSubstituteDataLoadSoon(request);
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138259] trunk/Tools
Title: [138259] trunk/Tools
Revision 138259
Author m...@apple.com
Date 2012-12-20 09:26:37 -0800 (Thu, 20 Dec 2012)
Log Message
prepare-ChangeLog adds Additional information of the change such as approach, rationale where it doesn't make sense
https://bugs.webkit.org/show_bug.cgi?id=99268
Reviewed by Alexey Proskuryakov.
* Scripts/prepare-ChangeLog:
(generateNewChangeLogs): Removed the Additional information of the change line.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/prepare-ChangeLog
Diff
Modified: trunk/Tools/ChangeLog (138258 => 138259)
--- trunk/Tools/ChangeLog 2012-12-20 16:45:57 UTC (rev 138258)
+++ trunk/Tools/ChangeLog 2012-12-20 17:26:37 UTC (rev 138259)
@@ -1,3 +1,13 @@
+2012-12-20 Dan Bernstein m...@apple.com
+
+prepare-ChangeLog adds Additional information of the change such as approach, rationale where it doesn't make sense
+https://bugs.webkit.org/show_bug.cgi?id=99268
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/prepare-ChangeLog:
+(generateNewChangeLogs): Removed the Additional information of the change line.
+
2012-12-20 Carlos Garcia Campos cgar...@igalia.com
Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
Modified: trunk/Tools/Scripts/prepare-ChangeLog (138258 => 138259)
--- trunk/Tools/Scripts/prepare-ChangeLog 2012-12-20 16:45:57 UTC (rev 138258)
+++ trunk/Tools/Scripts/prepare-ChangeLog 2012-12-20 17:26:37 UTC (rev 138259)
@@ -499,7 +499,6 @@
print CHANGE_LOG normalizeLineEndings(\n, $endl);
print CHANGE_LOG normalizeLineEndings(Reviewed by $reviewer.\n\n, $endl);
-print CHANGE_LOG normalizeLineEndings(Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).\n\n, $endl);
if ($prefix =~ m/WebCore/ || `pwd` =~ m/WebCore/) {
if (@$addedRegressionTests) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138260] trunk
Title: [138260] trunk Revision 138260 Author dmazz...@google.com Date 2012-12-20 09:29:34 -0800 (Thu, 20 Dec 2012) Log Message AX: support clickPoint in DRT for chromium https://bugs.webkit.org/show_bug.cgi?id=97359 Reviewed by Chris Fleizach. Source/WebCore: When computing the accessible bounding box of an SVG root, be sure to call a method that uses transforms, otherwise an assertion fails. Newly unskipped tests: accessibility/svg-bounds.html and accessibility/svg-remote-element.html * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::boundingBoxRect): Source/WebKit/chromium: Exposes the clickPoint accessibility method in WebAccessibilityObject. * public/WebAccessibilityObject.h: (WebAccessibilityObject): * src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::clickPoint): (WebKit): Tools: Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that several more tests can pass. * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement): (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback): (WebTestRunner): (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback): (WebTestRunner::AccessibilityUIElement::elementAtPointCallback): * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: (AccessibilityUIElement): LayoutTests: Enable four more tests now that clickPointX, clickPointY, and elementAtPoint are implemented for Chromium. Minor fixes to two tests to make them more robust across platfoms and when run in parallel. * accessibility/svg-bounds.html: Updated * accessibility/svg-bounds-expected.txt: Added (made cross-platform * accessibility/svg-remote-element.html: Updated * accessibility/svg-remote-element-expected.txt: Added (made cross-platform) * platform/mac/accessibility/svg-bounds-expected.txt: Deleted * platform/mac/accessibility/svg-remote-element-expected.txt: Deleted * platform/chromium/TestExpectations: Updated Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/svg-bounds.html trunk/LayoutTests/accessibility/svg-remote-element-expected.txt trunk/LayoutTests/accessibility/svg-remote-element.html trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebAccessibilityObject.h trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h Added Paths trunk/LayoutTests/accessibility/svg-bounds-expected.txt Removed Paths trunk/LayoutTests/platform/chromium/accessibility/svg-bounds-expected.txt trunk/LayoutTests/platform/mac/accessibility/svg-bounds-expected.txt trunk/LayoutTests/platform/mac/accessibility/svg-remote-element-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (138259 => 138260) --- trunk/LayoutTests/ChangeLog 2012-12-20 17:26:37 UTC (rev 138259) +++ trunk/LayoutTests/ChangeLog 2012-12-20 17:29:34 UTC (rev 138260) @@ -1,3 +1,24 @@ +2012-12-20 Dominic Mazzoni dmazz...@google.com + +AX: support clickPoint in DRT for chromium +https://bugs.webkit.org/show_bug.cgi?id=97359 + +Reviewed by Chris Fleizach. + +Enable four more tests now that clickPointX, clickPointY, +and elementAtPoint are implemented for Chromium. + +Minor fixes to two tests to make them more robust +across platfoms and when run in parallel. + +* accessibility/svg-bounds.html: Updated +* accessibility/svg-bounds-expected.txt: Added (made cross-platform +* accessibility/svg-remote-element.html: Updated +* accessibility/svg-remote-element-expected.txt: Added (made cross-platform) +* platform/mac/accessibility/svg-bounds-expected.txt: Deleted +* platform/mac/accessibility/svg-remote-element-expected.txt: Deleted +* platform/chromium/TestExpectations: Updated + 2012-12-20 Carlos Garcia Campos cgar...@igalia.com [Qt]REGRESSION(r138222): It made fast/forms/number/number-spinbutton-click-in-iframe.html crash Copied: trunk/LayoutTests/accessibility/svg-bounds-expected.txt (from rev 138259, trunk/LayoutTests/platform/chromium/accessibility/svg-bounds-expected.txt) (0 => 138260) --- trunk/LayoutTests/accessibility/svg-bounds-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/svg-bounds-expected.txt 2012-12-20 17:29:34 UTC (rev 138260) @@ -0,0 +1,44 @@ +Test +This test ensures the accessibility bounds of embedded SVG objects are correct. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +container location: (607, 107) +Face role: AXRole:
[webkit-changes] [138261] trunk/Source/WebCore
Title: [138261] trunk/Source/WebCore
Revision 138261
Author commit-qu...@webkit.org
Date 2012-12-20 09:33:29 -0800 (Thu, 20 Dec 2012)
Log Message
[BlackBerry]Change fullscreen back button size
https://bugs.webkit.org/show_bug.cgi?id=105541
Patch by Tiancheng Jiang tiji...@rim.com on 2012-12-20
Reviewed by Rob Buis.
Internally Reviewed by John Griggs.
Resize fullscreen mode back button size to meet browser back button size.
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::RenderThemeBlackBerry::paintMediaFullscreenButton):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138260 => 138261)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 17:29:34 UTC (rev 138260)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 17:33:29 UTC (rev 138261)
@@ -1,3 +1,17 @@
+2012-12-20 Tiancheng Jiang tiji...@rim.com
+
+[BlackBerry]Change fullscreen back button size
+https://bugs.webkit.org/show_bug.cgi?id=105541
+
+Reviewed by Rob Buis.
+
+Internally Reviewed by John Griggs.
+Resize fullscreen mode back button size to meet browser back button size.
+
+* platform/blackberry/RenderThemeBlackBerry.cpp:
+(WebCore):
+(WebCore::RenderThemeBlackBerry::paintMediaFullscreenButton):
+
2012-12-20 Dominic Mazzoni dmazz...@google.com
AX: support clickPoint in DRT for chromium
Modified: trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp (138260 => 138261)
--- trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp 2012-12-20 17:29:34 UTC (rev 138260)
+++ trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp 2012-12-20 17:33:29 UTC (rev 138261)
@@ -47,6 +47,9 @@
const float marginSize = 4;
const float mediaControlsHeight = 44;
const float mediaBackButtonHeight = 33;
+// Scale exit-fullscreen button size.
+const float mediaFullscreenButtonHeightRatio = 5 / 11.0;
+const float mediaFullscreenButtonWidthRatio = 3 / 11.0;
const float mediaSliderOutlineWidth = 2;
const float mediaSliderTrackRadius = 3;
const float mediaSliderThumbWidth = 25;
@@ -1002,11 +1005,16 @@
static Image* mediaExitFullscreen = Image::loadPlatformResource(back).leakRef();
Image* buttonImage = mediaEnterFullscreen;
+IntRect currentRect(rect);
#if ENABLE(FULLSCREEN_API)
-if (mediaElement-document()-webkitIsFullScreen() mediaElement-document()-webkitCurrentFullScreenElement() == mediaElement)
+if (mediaElement-document()-webkitIsFullScreen() mediaElement-document()-webkitCurrentFullScreenElement() == mediaElement) {
buttonImage = mediaExitFullscreen;
+IntRect fullscreenRect(rect.x() + (1 - mediaFullscreenButtonWidthRatio) * rect.width() / 2, rect.y() + (1 - mediaFullscreenButtonHeightRatio) * rect.height() / 2,
+rect.width() * mediaFullscreenButtonWidthRatio, rect.height() * mediaFullscreenButtonHeightRatio);
+currentRect = fullscreenRect;
+}
#endif
-return paintMediaButton(paintInfo.context, rect, buttonImage);
+return paintMediaButton(paintInfo.context, currentRect, buttonImage);
#else
UNUSED_PARAM(object);
UNUSED_PARAM(paintInfo);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138262] trunk/LayoutTests
Title: [138262] trunk/LayoutTests Revision 138262 Author t...@chromium.org Date 2012-12-20 09:34:24 -0800 (Thu, 20 Dec 2012) Log Message [chromium] Unreviewed gardening. Update pixel results for fast/sub-pixel/transformed-iframe-copy-on-scroll.html on mac. The test uses mock scrollbars but the old results have real scrollbars. * platform/chromium-mac-lion/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png: * platform/chromium-mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png trunk/LayoutTests/platform/chromium-mac-lion/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (138261 => 138262) --- trunk/LayoutTests/ChangeLog 2012-12-20 17:33:29 UTC (rev 138261) +++ trunk/LayoutTests/ChangeLog 2012-12-20 17:34:24 UTC (rev 138262) @@ -1,3 +1,13 @@ +2012-12-20 Tony Chang t...@chromium.org + +[chromium] Unreviewed gardening. + +Update pixel results for fast/sub-pixel/transformed-iframe-copy-on-scroll.html +on mac. The test uses mock scrollbars but the old results have real scrollbars. + +* platform/chromium-mac-lion/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png: +* platform/chromium-mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png: + 2012-12-20 Dominic Mazzoni dmazz...@google.com AX: support clickPoint in DRT for chromium Modified: trunk/LayoutTests/platform/chromium-mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-lion/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138263] trunk/Source/WebCore
Title: [138263] trunk/Source/WebCore
Revision 138263
Author a...@chromium.org
Date 2012-12-20 09:41:37 -0800 (Thu, 20 Dec 2012)
Log Message
CodeGen: Make [Reflect] use fastGetAttribute and fastHasAttribute
https://bugs.webkit.org/show_bug.cgi?id=105540
Reviewed by Andreas Kling.
Currently the codegen generates code that use getAttribute and hasAttribute. We can use
fastGetAttribute and fastHasAttribute when we use a non SVG animated attribute and not
HTML::styleAttr.
This improves Bindings/id-getter by 16% and Dromaeo/dom-attr by 21%.
No new tests. No change in behavior.
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/V8/V8TestObj.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138262 => 138263)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 17:34:24 UTC (rev 138262)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 17:41:37 UTC (rev 138263)
@@ -1,3 +1,26 @@
+2012-12-20 Erik Arvidsson a...@chromium.org
+
+CodeGen: Make [Reflect] use fastGetAttribute and fastHasAttribute
+https://bugs.webkit.org/show_bug.cgi?id=105540
+
+Reviewed by Andreas Kling.
+
+Currently the codegen generates code that use getAttribute and hasAttribute. We can use
+fastGetAttribute and fastHasAttribute when we use a non SVG animated attribute and not
+HTML::styleAttr.
+
+This improves Bindings/id-getter by 16% and Dromaeo/dom-attr by 21%.
+
+No new tests. No change in behavior.
+
+* bindings/scripts/CodeGenerator.pm:
+* bindings/scripts/CodeGeneratorV8.pm:
+* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
+* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+* bindings/scripts/test/JS/JSTestObj.cpp:
+* bindings/scripts/test/ObjC/DOMTestObj.mm:
+* bindings/scripts/test/V8/V8TestObj.cpp:
+
2012-12-20 Tiancheng Jiang tiji...@rim.com
[BlackBerry]Change fullscreen back button size
Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (138262 => 138263)
--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-12-20 17:34:24 UTC (rev 138262)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-12-20 17:41:37 UTC (rev 138263)
@@ -565,6 +565,15 @@
return WebCore::${namespace}::${contentAttributeName}Attr;
}
+sub CanUseFastAttribute
+{
+my ($generator, $attribute) = @_;
+my $attributeType = $attribute-signature-type;
+# HTMLNames::styleAttr cannot be used with fast{Get,Has}Attribute but we do not [Reflect] the
+# style attribute.
+return !$generator-IsSVGAnimatedType($attributeType);
+}
+
sub GetterExpression
{
my ($generator, $implIncludes, $interfaceName, $attribute) = @_;
@@ -579,13 +588,22 @@
if ($attribute-signature-extendedAttributes-{URL}) {
$functionName = getURLAttribute;
} elsif ($attribute-signature-type eq boolean) {
-$functionName = hasAttribute;
+my $namespace = $generator-NamespaceForAttributeName($interfaceName, $contentAttributeName);
+if ($generator-CanUseFastAttribute($attribute)) {
+$functionName = fastHasAttribute;
+} else {
+$functionName = hasAttribute;
+}
} elsif ($attribute-signature-type eq long) {
$functionName = getIntegralAttribute;
} elsif ($attribute-signature-type eq unsigned long) {
$functionName = getUnsignedIntegralAttribute;
} else {
-$functionName = getAttribute;
+if ($generator-CanUseFastAttribute($attribute)) {
+$functionName = fastGetAttribute;
+} else {
+$functionName = getAttribute;
+}
}
return ($functionName, $contentAttributeName);
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (138262 => 138263)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-12-20 17:34:24 UTC (rev 138262)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-12-20 17:41:37 UTC (rev 138263)
@@ -931,11 +931,9 @@
my $url = ""
if ($getterStringUsesImp $reflect !$url $codeGenerator-IsSubType($interface, Node) $codeGenerator-IsStringType($attrType)) {
# Generate super-compact call for regular attribute getter:
-my $contentAttributeName
[webkit-changes] [138264] trunk/Tools
Title: [138264] trunk/Tools Revision 138264 Author e...@webkit.org Date 2012-12-20 09:58:33 -0800 (Thu, 20 Dec 2012) Log Message EWSes do not need to dump build/test logs when things pass https://bugs.webkit.org/show_bug.cgi?id=105402 Reviewed by Dirk Pranke. When we were first writing the commit-queue and EWS system and running them locally, we thought it was important to see the build/test output as it happened. Now these queues have been running for years, and we don't use this feature anymore. So this patch makes us stop tee-ing the output directly to stdout, and instead only print any output from commands when they fail. I also added some logging when we execute each command since we are no longer printing the command output itself. This should make it much easier to see errors with the EWS system itself, now that all the passing-build output is removed. This required updating a zillion unittests, since we have a bunch of integration style testing of the queue-bots. Many of the unittests for the bots were already approximating this behavior by using a logging Executive. I disabled logging in those cases to avoid redundant logging in those tests. * Scripts/webkitpy/common/system/executive.py: (Executive.command_for_printing): (Executive.run_command): * Scripts/webkitpy/common/system/executive_mock.py: (MockExecutive.command_for_printing): (MockExecutive.run_command): * Scripts/webkitpy/common/system/executive_unittest.py: (ExecutiveTest.test_auto_stringify_args): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: (EarlyWarningSytemTest._default_expected_logs): (_test_ews): (_test_ewses): * Scripts/webkitpy/tool/commands/queues.py: (AbstractQueue.run_webkit_patch): * Scripts/webkitpy/tool/commands/queues_unittest.py: (AbstractQueueTest._assert_run_webkit_patch): (CommitQueueTest.test_commit_queue): (test_rollout): (test_rollout_lands): (test_manual_reject_during_processing): (StyleQueueTest.test_style_queue_with_style_exception): (test_style_queue_with_watch_list_exception): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/system/executive.py trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py trunk/Tools/Scripts/webkitpy/tool/commands/queues.py trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py Diff Modified: trunk/Tools/ChangeLog (138263 => 138264) --- trunk/Tools/ChangeLog 2012-12-20 17:41:37 UTC (rev 138263) +++ trunk/Tools/ChangeLog 2012-12-20 17:58:33 UTC (rev 138264) @@ -1,3 +1,50 @@ +2012-12-20 Eric Seidel e...@webkit.org + +EWSes do not need to dump build/test logs when things pass +https://bugs.webkit.org/show_bug.cgi?id=105402 + +Reviewed by Dirk Pranke. + +When we were first writing the commit-queue and EWS system +and running them locally, we thought it was important to see the +build/test output as it happened. Now these queues have been running +for years, and we don't use this feature anymore. So this patch +makes us stop tee-ing the output directly to stdout, and instead +only print any output from commands when they fail. + +I also added some logging when we execute each command +since we are no longer printing the command output itself. +This should make it much easier to see errors with the EWS +system itself, now that all the passing-build output is removed. + +This required updating a zillion unittests, since we have a bunch of +integration style testing of the queue-bots. Many of the unittests for the bots were +already approximating this behavior by using a logging Executive. +I disabled logging in those cases to avoid redundant logging in those tests. + +* Scripts/webkitpy/common/system/executive.py: +(Executive.command_for_printing): +(Executive.run_command): +* Scripts/webkitpy/common/system/executive_mock.py: +(MockExecutive.command_for_printing): +(MockExecutive.run_command): +* Scripts/webkitpy/common/system/executive_unittest.py: +(ExecutiveTest.test_auto_stringify_args): +* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: +(EarlyWarningSytemTest._default_expected_logs): +(_test_ews): +(_test_ewses): +* Scripts/webkitpy/tool/commands/queues.py: +(AbstractQueue.run_webkit_patch): +* Scripts/webkitpy/tool/commands/queues_unittest.py: +(AbstractQueueTest._assert_run_webkit_patch): +(CommitQueueTest.test_commit_queue): +(test_rollout): +(test_rollout_lands): +(test_manual_reject_during_processing): +(StyleQueueTest.test_style_queue_with_style_exception): +(test_style_queue_with_watch_list_exception): + 2012-12-20 Dominic Mazzoni
[webkit-changes] [138265] trunk/Source/WebCore
Title: [138265] trunk/Source/WebCore
Revision 138265
Author commit-qu...@webkit.org
Date 2012-12-20 10:06:46 -0800 (Thu, 20 Dec 2012)
Log Message
[EFL] [WebGL] [Wk2] Contents are not rendered properly.
https://bugs.webkit.org/show_bug.cgi?id=104664
Patch by Viatcheslav Ostapenko sl.ostape...@samsung.com on 2012-12-20
Reviewed by Noam Rosenthal.
WebGL pages that render more than one frame are broken. Only 1st
frame comes to the UI side. All webgl repaint tests fail because
of this.
Specification of EXT_texture_from_pixmap extension here
http://www.opengl.org/registry/specs/EXT/texture_from_pixmap.txt
says, that:
The contents of the texture after the drawable has been bound are defined
as the result of all rendering that has completed before the call to
glXBindTexImageEXT.
It means that in order to get updates for every frame glXBindTexImageEXT has
to be called on every frame update.
Covered by existing fast/canavs/webgl/*repaint tests.
* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::isReceiver):
(WebCore::GraphicsSurface::platformSwapBuffers):
* platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138264 => 138265)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 17:58:33 UTC (rev 138264)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 18:06:46 UTC (rev 138265)
@@ -1,3 +1,30 @@
+2012-12-20 Viatcheslav Ostapenko sl.ostape...@samsung.com
+
+[EFL] [WebGL] [Wk2] Contents are not rendered properly.
+https://bugs.webkit.org/show_bug.cgi?id=104664
+
+Reviewed by Noam Rosenthal.
+
+WebGL pages that render more than one frame are broken. Only 1st
+frame comes to the UI side. All webgl repaint tests fail because
+of this.
+Specification of EXT_texture_from_pixmap extension here
+http://www.opengl.org/registry/specs/EXT/texture_from_pixmap.txt
+says, that:
+The contents of the texture after the drawable has been bound are defined
+as the result of all rendering that has completed before the call to
+glXBindTexImageEXT.
+It means that in order to get updates for every frame glXBindTexImageEXT has
+to be called on every frame update.
+
+Covered by existing fast/canavs/webgl/*repaint tests.
+
+* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
+(WebCore::GraphicsSurfacePrivate::isReceiver):
+(WebCore::GraphicsSurface::platformSwapBuffers):
+* platform/graphics/texmap/TextureMapperBackingStore.cpp:
+(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
+
2012-12-20 Erik Arvidsson a...@chromium.org
CodeGen: Make [Reflect] use fastGetAttribute and fastHasAttribute
Modified: trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp (138264 => 138265)
--- trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp 2012-12-20 17:58:33 UTC (rev 138264)
+++ trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp 2012-12-20 18:06:46 UTC (rev 138265)
@@ -168,18 +168,8 @@
GLXFBConfig* fbConfigs = glXChooseFBConfig(m_display, DefaultScreen(m_display), attributes, numReturned);
// Make sure that we choose a configuration that supports an alpha mask.
-for (int i = 0; i numReturned; ++i) {
-XVisualInfo* visualInfo = glXGetVisualFromFBConfig(m_display, fbConfigs[i]);
-if (!visualInfo)
-continue;
+m_fbConfig = findFBConfigWithAlpha(fbConfigs, numReturned);
-XRenderPictFormat* format = XRenderFindVisualFormat(m_display, visualInfo-visual);
-if (format format-direct.alphaMask 0) {
-m_fbConfig = fbConfigs[i];
-break;
-}
-}
-
XFree(fbConfigs);
// Create a GLX context for OpenGL rendering
@@ -255,8 +245,11 @@
int numberOfConfigs;
GLXFBConfig* configs = glXChooseFBConfig(m_display, XDefaultScreen(m_display), glxSpec, numberOfConfigs);
+// If origin window has alpha then try to find config with alpha.
+GLXFBConfig config = m_hasAlpha ? findFBConfigWithAlpha(configs, numberOfConfigs) : configs[0];
+
m_xPixmap = XCompositeNameWindowPixmap(m_display, winId);
-m_glxPixmap = glXCreatePixmap(m_display, *configs, m_xPixmap, glxAttributes);
+m_glxPixmap = glXCreatePixmap(m_display, config, m_xPixmap, glxAttributes);
uint inverted = 0;
glXQueryDrawable(m_display, m_glxPixmap, GLX_Y_INVERTED_EXT, inverted);
@@ -354,7 +347,26 @@
return m_size;
}
+bool isReceiver() const {
[webkit-changes] [138267] branches/chromium/1364
Title: [138267] branches/chromium/1364
Revision 138267
Author k...@chromium.org
Date 2012-12-20 10:21:28 -0800 (Thu, 20 Dec 2012)
Log Message
Revert 138208
Revert 138189
Merge 138095
Input elements with default touch handlers don't update handler counts when changing documents
https://bugs.webkit.org/show_bug.cgi?id=105334
Reviewed by James Robinson.
Source/WebCore:
When an Input element with default touch event handlers changes documents, it failed to
update the touch event handler sets in both the old and new document. This patch fixes this
case.
Test: fast/events/touch/touch-input-element-change-documents.html
* dom/Document.h:
(WebCore::Document::didRemoveTouchEventTargetNode) This function makes sense when touch
handling is enabled, regardless of whether we're tracking the rects.
* dom/Document.cpp:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement): Switch from didRemoveTouchEventHandler to
didRemoveTouchEventTargetNode, since we don't care about counts in the destructor.
(WebCore::HTMLInputElement::updateType): Fixing incorrect indentation.
(WebCore::HTMLInputElement::didMoveToNewDocument): Adding the node to the new document and
removing it from the old.
LayoutTests:
* fast/events/touch/touch-input-element-change-documents-expected.txt: Added.
* fast/events/touch/touch-input-element-change-documents.html: Added.
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11649024
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11571072
TBR=k...@chromium.org
Review URL: https://codereview.chromium.org/11642045
Modified Paths
branches/chromium/1364/Source/WebCore/dom/Document.cpp
branches/chromium/1364/Source/WebCore/dom/Document.h
branches/chromium/1364/Source/WebCore/html/HTMLInputElement.cpp
Added Paths
branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt
branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html
Diff
Copied: branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt (from rev 138207, branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt) (0 => 138267)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt (rev 0)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt 2012-12-20 18:21:28 UTC (rev 138267)
@@ -0,0 +1,12 @@
+This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 2
+PASS window.internals.touchEventHandlerCount(document) is 3
+PASS window.internals.touchEventHandlerCount(document) is 2
+PASS window.internals.touchEventHandlerCount(document) is 0
+
Property changes: branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt
Added: svn:mergeinfo
Copied: branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html (from rev 138207, branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html) (0 => 138267)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html (rev 0)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html 2012-12-20 18:21:28 UTC (rev 138267)
@@ -0,0 +1,30 @@
+script src=""
+div id='container'/div
+script
+description(This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.);
+
+
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+ // There are two touchable Input elements in Audio's shadow DOM when controls are enabled.
+ var input = document.createElement('audio');
+ input.setAttribute(controls, true);
+ var container = document.getElementById('container');
+
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+ container.appendChild(input);
+ shouldBe('window.internals.touchEventHandlerCount(document)', '2');
+
+ input._ontouchend_ = function() { };
+ shouldBe('window.internals.touchEventHandlerCount(document)', '3');
+
+ input._ontouchend_ = null;
+ shouldBe('window.internals.touchEventHandlerCount(document)', '2');
+
+ document.implementation.createDocument(, , null).adoptNode(input);
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+
+/script
+/body
[webkit-changes] [138268] trunk
Title: [138268] trunk Revision 138268 Author jsb...@chromium.org Date 2012-12-20 10:21:35 -0800 (Thu, 20 Dec 2012) Log Message IndexedDB: Layout test showing delete database getting two blocked events https://bugs.webkit.org/show_bug.cgi?id=92674 Reviewed by Tony Chang. Source/WebCore: Match the steps specified behavior for deleteDatabase() in the spec: versionchange/blocked events fire if necessary, then waits until a condition is satisfied before continuing with the steps to delete the database. The bug was caused by retrying the full call again. Events are also now sent out immediately when a versionchange transaction is running, rather than entering a limbo state - again, the new behavior matches the spec more accurately. Tests: storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html storage/indexeddb/intversion-gated-on-delete.html * Modules/indexeddb/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::processPendingCalls): (WebCore::IDBDatabaseBackendImpl::deleteDatabase): First half of the steps. (WebCore): (WebCore::IDBDatabaseBackendImpl::isDeleteDatabaseBlocked): Pull out condition test. (WebCore::IDBDatabaseBackendImpl::deleteDatabaseFinal): Second half of the of steps. * Modules/indexeddb/IDBDatabaseBackendImpl.h: (IDBDatabaseBackendImpl): LayoutTests: Update/add tests to match the expected behavior where blocked/versionchange events fire even when a versionchange transaction is running. * storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt: Copied from LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt. * storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html: Copied from LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded.html. * storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt: Renamed from LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt. * storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html: Renamed from LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded.html. * storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt: * storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt: * storage/indexeddb/intversion-gated-on-delete-expected.txt: * storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js: Copied from LayoutTests/storage/indexeddb/resources/intversion-delete-in-upgradeneeded.js. * storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js: Renamed from LayoutTests/storage/indexeddb/resources/intversion-delete-in-upgradeneeded.js. * storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js: * storage/indexeddb/resources/factory-deletedatabase.js: * storage/indexeddb/resources/intversion-gated-on-delete.js: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt trunk/LayoutTests/storage/indexeddb/intversion-gated-on-delete-expected.txt trunk/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js trunk/LayoutTests/storage/indexeddb/resources/factory-deletedatabase.js trunk/LayoutTests/storage/indexeddb/resources/intversion-gated-on-delete.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h Added Paths trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html trunk/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js trunk/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js Removed Paths trunk/LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt trunk/LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded.html trunk/LayoutTests/storage/indexeddb/resources/intversion-delete-in-upgradeneeded.js Diff Modified: trunk/LayoutTests/ChangeLog (138267 => 138268) --- trunk/LayoutTests/ChangeLog 2012-12-20 18:21:28 UTC (rev 138267) +++ trunk/LayoutTests/ChangeLog 2012-12-20 18:21:35 UTC (rev 138268) @@ -1,3 +1,26 @@ +2012-12-20 Joshua Bell jsb...@chromium.org + +IndexedDB: Layout test showing delete database getting two blocked events +
[webkit-changes] [138269] branches/chromium/1364
Title: [138269] branches/chromium/1364
Revision 138269
Author k...@chromium.org
Date 2012-12-20 10:22:29 -0800 (Thu, 20 Dec 2012)
Log Message
Revert 138207
Revert 138190
Merge 138181
Correct missing touch event handler de-registration for nested Documents and DOMWindows
https://bugs.webkit.org/show_bug.cgi?id=105384
Reviewed by James Robinson.
Source/WebCore:
Correcting case by which a nested DOMWindow wouldn't clean up its event handler references
on its Document when removeAllEventListeners was called. Also, correctly propagating this
from a nested Document to its owner Document.
Updating fast/events/touch/touch-handler-count.html to catch this bug.
* dom/Document.cpp:
(WebCore::Document::didRemoveEventTargetNode):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):
LayoutTests:
* fast/events/touch/touch-handler-count-expected.txt:
* fast/events/touch/touch-handler-count.html: Adding case of nested DOMWindows with event handlers.
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11635026
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11647025
TBR=k...@chromium.org
Review URL: https://codereview.chromium.org/11638044
Modified Paths
branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt
branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html
branches/chromium/1364/Source/WebCore/dom/Document.cpp
branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp
Diff
Modified: branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt (138268 => 138269)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt 2012-12-20 18:21:35 UTC (rev 138268)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt 2012-12-20 18:22:29 UTC (rev 138269)
@@ -71,4 +71,8 @@
PASS window.internals.touchEventHandlerCount(document) is 2
PASS window.internals.touchEventHandlerCount(document) is 2
PASS window.internals.touchEventHandlerCount(document) is 0
+Test that nested Documents' touch handlers are properly removed from their parent Document.
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 1
+PASS window.internals.touchEventHandlerCount(document) is 0
Modified: branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html (138268 => 138269)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html 2012-12-20 18:21:35 UTC (rev 138268)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html 2012-12-20 18:22:29 UTC (rev 138269)
@@ -204,5 +204,24 @@
shouldBe('window.internals.touchEventHandlerCount(document)', '0');
})();
+debug(Test that nested Documents' touch handlers are properly removed from their parent Document.);
+(function() {
+var iframe = document.createElement('iframe');
+var touchtarget = document.getElementById('touchtarget');
+
+shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+touchtarget.appendChild(iframe);
+
+var nestedDocument = iframe.contentWindow.document;
+nestedDocument.open('text/html', 'replace');
+nestedDocument.write(!DOCTYPE html\nhtmlbody _onload_=\window._ontouchstart_ = function() { };\/body);
+nestedDocument.close();
+
+shouldBe('window.internals.touchEventHandlerCount(document)', '1');
+
+touchtarget.removeChild(iframe);
+shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+})();
/script
/body
Modified: branches/chromium/1364/Source/WebCore/dom/Document.cpp (138268 => 138269)
--- branches/chromium/1364/Source/WebCore/dom/Document.cpp 2012-12-20 18:21:35 UTC (rev 138268)
+++ branches/chromium/1364/Source/WebCore/dom/Document.cpp 2012-12-20 18:22:29 UTC (rev 138269)
@@ -5659,6 +5659,9 @@
{
if (m_touchEventTargets.get())
m_touchEventTargets-removeAll(handler);
+if (handler == this)
+if (Document* parentDocument = this-parentDocument())
+parentDocument-didRemoveEventTargetNode(this);
}
#endif
Modified: branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp (138268 => 138269)
--- branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp 2012-12-20 18:21:35 UTC (rev 138268)
+++ branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp 2012-12-20 18:22:29 UTC (rev 138269)
@@ -1685,6 +1685,10 @@
if (DeviceOrientationController* controller = DeviceOrientationController::from(page()))
controller-removeAllDeviceEventListeners(this);
#endif
+#if ENABLE(TOUCH_EVENTS)
+if (Document* document = this-document())
+document-didRemoveEventTargetNode(document);
+#endif
removeAllUnloadEventListeners(this);
removeAllBeforeUnloadEventListeners(this);
___
[webkit-changes] [138270] trunk
Title: [138270] trunk Revision 138270 Author commit-qu...@webkit.org Date 2012-12-20 10:28:57 -0800 (Thu, 20 Dec 2012) Log Message onload callback for track element attached to video does not fire https://bugs.webkit.org/show_bug.cgi?id=103258 Patch by Antoine Quint grao...@apple.com on 2012-12-20 Reviewed by Eric Carlson. Source/WebCore: We now correctly implement the track processing model per the latest spec at http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#start-the-track-processing-model. For a track to load, three conditions must be met: 1. it must have a non-empty src 2. it must have a mode other than disabled (the default) 3. it must have a parent media element We used to only check if we were able to load upon setting the track's src, whereas a change of any of those conditions should have done this, which this patch now correctly implements. We also correctly implement the load model asynchronously after step 4, per the spec, hence the split of the code previously entirely contained in HTMLTrackElement::scheduleLoad() in another method fired on a timer. Test: media/track/track-element-load-event.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::textTrackModeChanged): * html/HTMLTrackElement.cpp: (WebCore::HTMLTrackElement::HTMLTrackElement): (WebCore::HTMLTrackElement::insertedInto): (WebCore::HTMLTrackElement::parseAttribute): (WebCore::HTMLTrackElement::scheduleLoad): (WebCore): (WebCore::HTMLTrackElement::loadTimerFired): (WebCore::HTMLTrackElement::textTrackModeChanged): * html/HTMLTrackElement.h: * html/track/TextTrack.cpp: (WebCore::TextTrack::removeAllCues): (WebCore): * html/track/TextTrack.h: (TextTrack): LayoutTests: As a result of fixing this bug, a few new failures were uncovered and TestExpectations needed to be updated to take this into account. Additionally, some existing tests were incorrect or outdated and were fixed as well. Finally, a new test was added to thoroughly test the various conditions required for a track element to successfully load. * fast/events/constructors/track-event-constructor.html: Update the test to correctly set a non-disabled mode on the text track such that it may load per the rules enforced with this patch. * http/tests/security/text-track-crossorigin.html: Update the test to correctly set a non-disabled mode on the text track such that it may load per the rules enforced with this patch. * media/track/track-add-track-expected.txt: Update the output to match changes made to test. * media/track/track-add-track.html: Update the test to correctly set a non-disabled mode on the text track such that it may load per the rules enforced with this patch. Also, ensure the .readyState of the text track is correctly assumed to be NONE vs. LOADING as it would have to wait until the next run loop to be changed to anything but NONE. * media/track/track-element-load-event-expected.txt: Added. * media/track/track-element-load-event.html: Added. * media/track/track-load-from-src-readyState.html: Update the test to correctly set a non-disabled mode on the text track such that it may load per the rules enforced with this patch. * platform/chromium/TestExpectations: Skip tests that now fail instead of timing out. * platform/efl/TestExpectations: Skip tests that now fail instead of timing out. * platform/gtk/TestExpectations: Skip tests that now fail instead of timing out. * platform/mac/TestExpectations: Skip tests that now fail instead of timing out. * platform/qt/TestExpectations: Skip tests that now fail instead of timing out. * platform/win/TestExpectations: Skip tests that now fail instead of timing out. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/events/constructors/track-event-constructor.html trunk/LayoutTests/http/tests/security/text-track-crossorigin.html trunk/LayoutTests/media/track/track-add-track-expected.txt trunk/LayoutTests/media/track/track-add-track.html trunk/LayoutTests/media/track/track-load-from-src-readyState.html trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/qt/TestExpectations trunk/LayoutTests/platform/win/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLTrackElement.cpp trunk/Source/WebCore/html/HTMLTrackElement.h trunk/Source/WebCore/html/track/TextTrack.cpp trunk/Source/WebCore/html/track/TextTrack.h Added Paths trunk/LayoutTests/media/track/track-element-load-event-expected.txt trunk/LayoutTests/media/track/track-element-load-event.html Diff Modified: trunk/LayoutTests/ChangeLog (138269 => 138270) --- trunk/LayoutTests/ChangeLog 2012-12-20 18:22:29 UTC (rev 138269) +++ trunk/LayoutTests/ChangeLog 2012-12-20 18:28:57 UTC (rev 138270) @@ -1,3 +1,36 @@ +2012-12-20 Antoine Quint grao...@apple.com
[webkit-changes] [138271] tags/Safari-537.23
Title: [138271] tags/Safari-537.23
Revision 138271
Author lforsch...@apple.com
Date 2012-12-20 10:34:20 -0800 (Thu, 20 Dec 2012)
Log Message
Merged r138226. rdar://problem/12893550
Modified Paths
tags/Safari-537.23/Source/WebKit2/ChangeLog
tags/Safari-537.23/Source/WebKit2/Shared/ChildProcess.cpp
tags/Safari-537.23/Source/WebKit2/Shared/ChildProcess.h
tags/Safari-537.23/Source/WebKit2/Shared/mac/ChildProcessMac.mm
tags/Safari-537.23/WebKitLibraries/ChangeLog
tags/Safari-537.23/WebKitLibraries/WebKitSystemInterface.h
Diff
Modified: tags/Safari-537.23/Source/WebKit2/ChangeLog (138270 => 138271)
--- tags/Safari-537.23/Source/WebKit2/ChangeLog 2012-12-20 18:28:57 UTC (rev 138270)
+++ tags/Safari-537.23/Source/WebKit2/ChangeLog 2012-12-20 18:34:20 UTC (rev 138271)
@@ -1,3 +1,28 @@
+2012-12-20 Lucas Forschler lforsch...@apple.com
+
+Merge r138226
+
+2012-12-19 Kiran Muppala cmupp...@apple.com
+
+Adopt new assertion SPI for process suppression on Mac
+https://bugs.webkit.org/show_bug.cgi?id=105378
+
+Reviewed by Mark Rowe.
+
+Process suppression for WebKit2 child processes is currently enabled or disabled using AutomaticTermination.
+This should be replaced with a new assertion SPI specific to process suppression.
+
+* Shared/ChildProcess.cpp:
+(WebKit::ChildProcess::ChildProcess): Remove unused member variable m_applicationIsOccluded.
+* Shared/ChildProcess.h:
+(WebKit::ChildProcess::applicationIsOccluded): Infer occlusion state from m_processVisibleAssertion.
+* Shared/mac/ChildProcessMac.mm:
+(WebKit::ChildProcess::setApplicationIsOccluded): Use applicationIsOccluded() accessor to check if the
+occlusion state has changed and take or release a process visible assertion accordingly.
+(WebKit::ChildProcess::platformInitialize): Remove call to initializeTimerCoalescingPolicy(), since taking
+a process visible assertion also sets the timer coalescing policy appropriately. Set the occlusion
+state to false on initialization.
+
2012-12-19 Alexey Proskuryakov a...@apple.com
rdar://problem/12890242 [WK2 NetworkProcess] Client doesn't receive SSL certificates
Modified: tags/Safari-537.23/Source/WebKit2/Shared/ChildProcess.cpp (138270 => 138271)
--- tags/Safari-537.23/Source/WebKit2/Shared/ChildProcess.cpp 2012-12-20 18:28:57 UTC (rev 138270)
+++ tags/Safari-537.23/Source/WebKit2/Shared/ChildProcess.cpp 2012-12-20 18:34:20 UTC (rev 138271)
@@ -60,9 +60,6 @@
: m_terminationTimeout(0)
, m_terminationCounter(0)
, m_terminationTimer(RunLoop::main(), this, ChildProcess::terminationTimerFired)
-#if PLATFORM(MAC)
-, m_applicationIsOccluded(false)
-#endif
{
// FIXME: The termination timer should not be scheduled on the main run loop.
// It won't work with the threaded mode, but it's not really useful anyway as is.
Modified: tags/Safari-537.23/Source/WebKit2/Shared/ChildProcess.h (138270 => 138271)
--- tags/Safari-537.23/Source/WebKit2/Shared/ChildProcess.h 2012-12-20 18:28:57 UTC (rev 138270)
+++ tags/Safari-537.23/Source/WebKit2/Shared/ChildProcess.h 2012-12-20 18:34:20 UTC (rev 138271)
@@ -28,6 +28,7 @@
#include Connection.h
#include WebCore/RunLoop.h
+#include wtf/RetainPtr.h
#if PLATFORM(MAC)
OBJC_CLASS NSString;
@@ -62,7 +63,7 @@
};
#if PLATFORM(MAC)
-bool applicationIsOccluded() const { return m_applicationIsOccluded; }
+bool applicationIsOccluded() const { return !m_processVisibleAssertion; }
void setApplicationIsOccluded(bool);
#endif
@@ -80,13 +81,6 @@
virtual bool shouldTerminate() = 0;
virtual void terminate();
-#if PLATFORM(MAC)
-void disableProcessSuppression(NSString *reason);
-void enableProcessSuppression(NSString *reason);
-
-static NSString * const processSuppressionVisibleApplicationReason;
-#endif
-
void platformInitialize();
// The timeout, in seconds, before this process will be terminated if termination
@@ -100,7 +94,7 @@
WebCore::RunLoop::TimerChildProcess m_terminationTimer;
#if PLATFORM(MAC)
-bool m_applicationIsOccluded;
+RetainPtrid m_processVisibleAssertion;
#endif
};
Modified: tags/Safari-537.23/Source/WebKit2/Shared/mac/ChildProcessMac.mm (138270 => 138271)
--- tags/Safari-537.23/Source/WebKit2/Shared/mac/ChildProcessMac.mm 2012-12-20 18:28:57 UTC (rev 138270)
+++ tags/Safari-537.23/Source/WebKit2/Shared/mac/ChildProcessMac.mm 2012-12-20 18:34:20 UTC (rev 138271)
@@ -26,61 +26,30 @@
#import config.h
#import ChildProcess.h
+#import WebKitSystemInterface.h
#import mach/task.h
namespace WebKit {
-NSString * const ChildProcess::processSuppressionVisibleApplicationReason = @Application is Visible;
-
void ChildProcess::setApplicationIsOccluded(bool applicationIsOccluded)
{
-if (m_applicationIsOccluded == applicationIsOccluded)
+if
[webkit-changes] [138272] trunk/LayoutTests
Title: [138272] trunk/LayoutTests Revision 138272 Author dmazz...@google.com Date 2012-12-20 10:35:33 -0800 (Thu, 20 Dec 2012) Log Message Unreviewed. Adjust Mac TestExpectations. https://bugs.webkit.org/show_bug.cgi?id=105372 Removes accessibility/svg-bounds.html from platform/mac/TestExpectations. The problem was caused by bug 97359: committed r138061, reverted r138121, re-landed r138260 without the bug. * platform/mac/TestExpectations: remove accessibility/svg-bounds.html Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138271 => 138272) --- trunk/LayoutTests/ChangeLog 2012-12-20 18:34:20 UTC (rev 138271) +++ trunk/LayoutTests/ChangeLog 2012-12-20 18:35:33 UTC (rev 138272) @@ -1,3 +1,16 @@ +2012-12-20 Dominic Mazzoni dmazz...@google.com + +Unreviewed. Adjust Mac TestExpectations. +https://bugs.webkit.org/show_bug.cgi?id=105372 + +Removes accessibility/svg-bounds.html from +platform/mac/TestExpectations. + +The problem was caused by bug 97359: committed r138061, +reverted r138121, re-landed r138260 without the bug. + +* platform/mac/TestExpectations: remove accessibility/svg-bounds.html + 2012-12-20 Antoine Quint grao...@apple.com onload callback for track element attached to video does not fire Modified: trunk/LayoutTests/platform/mac/TestExpectations (138271 => 138272) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 18:34:20 UTC (rev 138271) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 18:35:33 UTC (rev 138272) @@ -72,9 +72,6 @@ # Skipped until https://bugs.webkit.org/show_bug.cgi?id=33923 is resolved. platform/mac/accessibility/change-notification-on-scroll.html -# Asserts: https://bugs.webkit.org/show_bug.cgi?id=105372 -[ Debug ] accessibility/svg-bounds.html - # See https://bugs.webkit.org/show_bug.cgi?id=34287 http/tests/media/video-cookie.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138273] trunk/Source
Title: [138273] trunk/Source Revision 138273 Author carlo...@webkit.org Date 2012-12-20 10:42:13 -0800 (Thu, 20 Dec 2012) Log Message [GTK] Add API to set a TLS errors policy to WebKit2 GTK+ API https://bugs.webkit.org/show_bug.cgi?id=104482 Reviewed by Martin Robinson. Source/WebCore: * platform/network/soup/ResourceError.h: (WebCore::ResourceError::setTLSErrors): Set the TLS error flags. (WebCore::ResourceError::setCertificate): Set the certificate. * platform/network/soup/ResourceErrorSoup.cpp: (WebCore::ResourceError::tlsError): Set the given TLS errors and certificate to the ResourceError. (WebCore::ResourceError::platformCopy): Copy also the TLS errors and the certificate. (WebCore::ResourceError::platformCompare): Compare also the TLS errors. Source/WebKit2: Add an emum for TLS errors policy with values IGNORE and FAIL and API to WebKitWebContext to set/get the policy. * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): Encode ignoreTLSErrors. (WebKit::WebProcessCreationParameters::decode): Decode ignoreTLSErrors. * Shared/WebProcessCreationParameters.h: (WebProcessCreationParameters): Add ignoreTLSErrors when building with soup network backend. * Shared/soup/PlatformCertificateInfo.cpp: (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Add a constructor that receives a ResourceError. * Shared/soup/PlatformCertificateInfo.h: * Shared/soup/WebCoreArgumentCodersSoup.cpp: (CoreIPCencodePlatformData): Encode the PlatformCertificateInfo as part for the ResourceError. (CoreIPCdecodePlatformData): Decode the PlatformCertificateInfo and set certificate and TLS errors in the ResourceError. * UIProcess/API/gtk/WebKitLoaderClient.cpp: (didFailProvisionalLoadWithErrorForFrame): Call webkitWebViewLoadFailedWithTLSErrors() if the load failed due to TLS errors. * UIProcess/API/gtk/WebKitWebContext.cpp: (_WebKitWebContextPrivate): Add tlsErrorsPolicy member. (createDefaultWebContext): Initiales tlsErrorsPolicy. (webkit_web_context_set_tls_errors_policy): Set the TLS errors policy notify WebContext to ignore TLS errors or not. (webkit_web_context_get_tls_errors_policy): Return the current TLS errors policy. * UIProcess/API/gtk/WebKitWebContext.h: * UIProcess/API/gtk/WebKitWebView.cpp: (webkitWebViewLoadFailedWithTLSErrors): Finish the load with an error if the TLS errors policy is FAIL. * UIProcess/API/gtk/WebKitWebViewPrivate.h: * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols. * UIProcess/API/gtk/tests/TestSSL.cpp: (testTLSErrorsPolicy): (beforeAll): * UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Initialize m_ignoreTLSErrors. * UIProcess/WebContext.h: (WebContext): Add m_ignoreTLSErrors member. (WebKit::WebContext::ignoreTLSErrors): Return m_ignoreTLSErrors. * UIProcess/efl/WebContextEfl.cpp: (WebKit::WebContext::platformInitializeWebProcess): Set ignoreTLSErrors parameter. (WebKit::WebContext::setIgnoreTLSErrors): Send SetIgnoreTLSErrors message to the web process. * UIProcess/gtk/WebContextGtk.cpp: (WebKit::WebContext::platformInitializeWebProcess): Set ignoreTLSErrors parameter. (WebKit::WebContext::setIgnoreTLSErrors): Send SetIgnoreTLSErrors message to the web process. (WebKit): * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: * WebProcess/efl/WebProcessMainEfl.cpp: (WebKit::WebProcessMainEfl): Remove the call to ResourceHandle::setIgnoreSSLErrors(). * WebProcess/gtk/WebProcessMainGtk.cpp: (WebKit::WebProcessMainGtk): Remove the call to ResourceHandle::setIgnoreSSLErrors(). * WebProcess/soup/WebProcessSoup.cpp: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::setIgnoreTLSErrors): Call ResourceHandle::setIgnoreSSLErrors(). (WebKit): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/soup/ResourceError.h trunk/Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h trunk/Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp trunk/Source/WebKit2/Shared/soup/PlatformCertificateInfo.h trunk/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp trunk/Source/WebKit2/UIProcess/WebContext.cpp trunk/Source/WebKit2/UIProcess/WebContext.h trunk/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp trunk/Source/WebKit2/WebProcess/WebProcess.h trunk/Source/WebKit2/WebProcess/WebProcess.messages.in
[webkit-changes] [138274] trunk/LayoutTests
Title: [138274] trunk/LayoutTests
Revision 138274
Author commit-qu...@webkit.org
Date 2012-12-20 10:48:42 -0800 (Thu, 20 Dec 2012)
Log Message
Block level pseudo elements bleed background color to html
https://bugs.webkit.org/show_bug.cgi?id=104855
Patch by Elliott Sprehn espr...@gmail.com on 2012-12-20
Reviewed by Julien Chaffraix.
Before r137336 placing a pseudo element :before or :after that was display
block on the html element would also set the background color of the
root of the document.
This was because RenderObject::isRoot checked if document()-documentElement() == m_node,
which was true for html:before or html:after with the old implementation
of generated content. Instead it should have compared against node() which
would have compensated for the anonymous generated content.
This is fixed by the new generated content implementation that was turned
on in r137336 because m_node is now the PseudoElement, not the generatingNode.
* fast/css-generated-content/html-pseudo-background-color-expected.html: Added.
* fast/css-generated-content/html-pseudo-background-color.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/css-generated-content/html-pseudo-background-color-expected.html
trunk/LayoutTests/fast/css-generated-content/html-pseudo-background-color.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138273 => 138274)
--- trunk/LayoutTests/ChangeLog 2012-12-20 18:42:13 UTC (rev 138273)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 18:48:42 UTC (rev 138274)
@@ -1,3 +1,25 @@
+2012-12-20 Elliott Sprehn espr...@gmail.com
+
+Block level pseudo elements bleed background color to html
+https://bugs.webkit.org/show_bug.cgi?id=104855
+
+Reviewed by Julien Chaffraix.
+
+Before r137336 placing a pseudo element :before or :after that was display
+block on the html element would also set the background color of the
+root of the document.
+
+This was because RenderObject::isRoot checked if document()-documentElement() == m_node,
+which was true for html:before or html:after with the old implementation
+of generated content. Instead it should have compared against node() which
+would have compensated for the anonymous generated content.
+
+This is fixed by the new generated content implementation that was turned
+on in r137336 because m_node is now the PseudoElement, not the generatingNode.
+
+* fast/css-generated-content/html-pseudo-background-color-expected.html: Added.
+* fast/css-generated-content/html-pseudo-background-color.html: Added.
+
2012-12-20 Dominic Mazzoni dmazz...@google.com
Unreviewed. Adjust Mac TestExpectations.
Added: trunk/LayoutTests/fast/css-generated-content/html-pseudo-background-color-expected.html (0 => 138274)
--- trunk/LayoutTests/fast/css-generated-content/html-pseudo-background-color-expected.html (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/html-pseudo-background-color-expected.html 2012-12-20 18:48:42 UTC (rev 138274)
@@ -0,0 +1,9 @@
+!DOCTYPE html
+
+pBug 104855: Block level pseudo elements bleed background color to lt;htmlgt;/p
+
+pNeither frame should be red./p
+
+iframe/iframe
+
+iframe/iframe
Added: trunk/LayoutTests/fast/css-generated-content/html-pseudo-background-color.html (0 => 138274)
--- trunk/LayoutTests/fast/css-generated-content/html-pseudo-background-color.html (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/html-pseudo-background-color.html 2012-12-20 18:48:42 UTC (rev 138274)
@@ -0,0 +1,25 @@
+!DOCTYPE html
+
+pBug 104855: Block level pseudo elements bleed background color to lt;htmlgt;/p
+
+pNeither frame should be red./p
+
+iframe srcdoc='
+style
+html:before {
+content: ;
+display: block;
+background: red;
+}
+/style
+'/iframe
+
+iframe srcdoc='
+style
+html:after {
+content: ;
+display: block;
+background: red;
+}
+/style
+'/iframe
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138276] trunk
Title: [138276] trunk
Revision 138276
Author fpi...@apple.com
Date 2012-12-20 11:14:39 -0800 (Thu, 20 Dec 2012)
Log Message
DFG speculation checks that take JumpList should consolidate OSRExits
https://bugs.webkit.org/show_bug.cgi?id=105401
Reviewed by Oliver Hunt.
Source/_javascript_Core:
Change OSRExitCompilationInfo to always contain a JumpList, and change JumpList
to be more compact. This way, a speculationCheck that takes a JumpList only has
to emit one OSRExit structure, and one OSRExit landing pad.
The downside is that we get less precise information about *where* we exited
from. So, this also includes changes to the profiler to be more relaxed about
what an ExitSite is.
* assembler/AbstractMacroAssembler.h:
(JumpList):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(DFG):
(JSC::DFG::JITCompiler::appendExitInfo):
(JITCompiler):
* dfg/DFGOSRExitCompilationInfo.h:
(OSRExitCompilationInfo):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
* profiler/ProfilerCompilation.cpp:
(JSC::Profiler::Compilation::addOSRExitSite):
* profiler/ProfilerCompilation.h:
(Compilation):
* profiler/ProfilerOSRExitSite.cpp:
(JSC::Profiler::OSRExitSite::toJS):
* profiler/ProfilerOSRExitSite.h:
(JSC::Profiler::OSRExitSite::OSRExitSite):
(JSC::Profiler::OSRExitSite::codeAddress):
(OSRExitSite):
Tools:
Update the profiler to understand that an OSR exit may have multiple
candidate exit sites.
* Scripts/display-profiler-output:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilationInfo.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/profiler/ProfilerCompilation.cpp
trunk/Source/_javascript_Core/profiler/ProfilerCompilation.h
trunk/Source/_javascript_Core/profiler/ProfilerOSRExitSite.cpp
trunk/Source/_javascript_Core/profiler/ProfilerOSRExitSite.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/display-profiler-output
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (138275 => 138276)
--- trunk/Source/_javascript_Core/ChangeLog 2012-12-20 19:00:08 UTC (rev 138275)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-12-20 19:14:39 UTC (rev 138276)
@@ -1,3 +1,44 @@
+2012-12-19 Filip Pizlo fpi...@apple.com
+
+DFG speculation checks that take JumpList should consolidate OSRExits
+https://bugs.webkit.org/show_bug.cgi?id=105401
+
+Reviewed by Oliver Hunt.
+
+Change OSRExitCompilationInfo to always contain a JumpList, and change JumpList
+to be more compact. This way, a speculationCheck that takes a JumpList only has
+to emit one OSRExit structure, and one OSRExit landing pad.
+
+The downside is that we get less precise information about *where* we exited
+from. So, this also includes changes to the profiler to be more relaxed about
+what an ExitSite is.
+
+* assembler/AbstractMacroAssembler.h:
+(JumpList):
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::linkOSRExits):
+(JSC::DFG::JITCompiler::link):
+* dfg/DFGJITCompiler.h:
+(DFG):
+(JSC::DFG::JITCompiler::appendExitInfo):
+(JITCompiler):
+* dfg/DFGOSRExitCompilationInfo.h:
+(OSRExitCompilationInfo):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::speculationCheck):
+(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
+(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
+* profiler/ProfilerCompilation.cpp:
+(JSC::Profiler::Compilation::addOSRExitSite):
+* profiler/ProfilerCompilation.h:
+(Compilation):
+* profiler/ProfilerOSRExitSite.cpp:
+(JSC::Profiler::OSRExitSite::toJS):
+* profiler/ProfilerOSRExitSite.h:
+(JSC::Profiler::OSRExitSite::OSRExitSite):
+(JSC::Profiler::OSRExitSite::codeAddress):
+(OSRExitSite):
+
2012-12-19 Oliver Hunt oli...@apple.com
Fix some incorrect tests in testapi.c
Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (138275 => 138276)
--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2012-12-20 19:00:08 UTC (rev 138275)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2012-12-20 19:14:39 UTC (rev 138276)
@@ -592,7 +592,7 @@
friend class LinkBuffer;
public:
-typedef VectorJump, 16 JumpVector;
+typedef VectorJump, 2 JumpVector;
JumpList() { }
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp (138275 => 138276)
---
[webkit-changes] [138277] trunk/Source/WebCore
Title: [138277] trunk/Source/WebCore
Revision 138277
Author a...@chromium.org
Date 2012-12-20 11:16:00 -0800 (Thu, 20 Dec 2012)
Log Message
REGRESSION(r138263): Don't use fastGetAttribute for HTMLNames::classAttr because it breaks on SVGElement
https://bugs.webkit.org/show_bug.cgi?id=10
Reviewed by Tony Chang.
The code generated generated code that uses fastGetAttribute for the className WebIDL attribute getter.
However, this attribute is animatable in SVG so we cannot use the fast function for it.
No new tests. The assert is no longer hit.
* bindings/scripts/CodeGenerator.pm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
Diff
Modified: trunk/Source/WebCore/ChangeLog (138276 => 138277)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 19:14:39 UTC (rev 138276)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 19:16:00 UTC (rev 138277)
@@ -1,3 +1,17 @@
+2012-12-20 Erik Arvidsson a...@chromium.org
+
+REGRESSION(r138263): Don't use fastGetAttribute for HTMLNames::classAttr because it breaks on SVGElement
+https://bugs.webkit.org/show_bug.cgi?id=10
+
+Reviewed by Tony Chang.
+
+The code generated generated code that uses fastGetAttribute for the className WebIDL attribute getter.
+However, this attribute is animatable in SVG so we cannot use the fast function for it.
+
+No new tests. The assert is no longer hit.
+
+* bindings/scripts/CodeGenerator.pm:
+
2012-12-20 Carlos Garcia Campos cgar...@igalia.com
[GTK] Add API to set a TLS errors policy to WebKit2 GTK+ API
Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (138276 => 138277)
--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-12-20 19:14:39 UTC (rev 138276)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-12-20 19:16:00 UTC (rev 138277)
@@ -567,10 +567,14 @@
sub CanUseFastAttribute
{
-my ($generator, $attribute) = @_;
+my ($generator, $attribute, $contentAttributeName) = @_;
my $attributeType = $attribute-signature-type;
# HTMLNames::styleAttr cannot be used with fast{Get,Has}Attribute but we do not [Reflect] the
# style attribute.
+
+# Unfortunately SVG makes class animatable.
+return 0 if $contentAttributeName eq WebCore::HTMLNames::classAttr;
+
return !$generator-IsSVGAnimatedType($attributeType);
}
@@ -589,7 +593,7 @@
$functionName = getURLAttribute;
} elsif ($attribute-signature-type eq boolean) {
my $namespace = $generator-NamespaceForAttributeName($interfaceName, $contentAttributeName);
-if ($generator-CanUseFastAttribute($attribute)) {
+if ($generator-CanUseFastAttribute($attribute, $contentAttributeName)) {
$functionName = fastHasAttribute;
} else {
$functionName = hasAttribute;
@@ -599,7 +603,7 @@
} elsif ($attribute-signature-type eq unsigned long) {
$functionName = getUnsignedIntegralAttribute;
} else {
-if ($generator-CanUseFastAttribute($attribute)) {
+if ($generator-CanUseFastAttribute($attribute, $contentAttributeName)) {
$functionName = fastGetAttribute;
} else {
$functionName = getAttribute;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138278] trunk
Title: [138278] trunk
Revision 138278
Author simon.fra...@apple.com
Date 2012-12-20 11:30:59 -0800 (Thu, 20 Dec 2012)
Log Message
Lots of sticky tests failing in WK2
https://bugs.webkit.org/show_bug.cgi?id=105464
Source/WebCore:
Reviewed by Brady Eidson.
Fixing this bug altered the timing of InternalSettings::Backup()
and restoreTo(), such that 'canStartMedia' on Page would get saved as false,
and then restored as false, which breaks all media tests.
'canStartMedia' is set to false initially by the WebPage constructor, and is also
set to false when the WKView leaves the window, so treating it like other Settings
that can be saved and restored is unreliable, as seen here. It's easier and simpler
to just always reset it to 'true' between tests.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::reset):
* testing/InternalSettings.h:
(Backup):
Tools:
Reviewed by Beth Dakin.
WebKitTestRunner had a race between snapshotting in the UI process,
and resettting after the test in the web process. InjectedBundle::done()
was a bad place to call page()-resetAfterTest(), because of this race;
it could reset the scroll position before the UI snapshot had been obtained.
Fix by moving the call to page()-resetAfterTest() into didReceiveMessage(),
for the Reset message which will come in before the next test.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::done):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138277 => 138278)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 19:16:00 UTC (rev 138277)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 19:30:59 UTC (rev 138278)
@@ -1,3 +1,27 @@
+2012-12-19 Simon Fraser simon.fra...@apple.com
+
+Lots of sticky tests failing in WK2
+https://bugs.webkit.org/show_bug.cgi?id=105464
+
+Reviewed by Brady Eidson.
+
+Fixing this bug altered the timing of InternalSettings::Backup()
+and restoreTo(), such that 'canStartMedia' on Page would get saved as false,
+and then restored as false, which breaks all media tests.
+
+'canStartMedia' is set to false initially by the WebPage constructor, and is also
+set to false when the WKView leaves the window, so treating it like other Settings
+that can be saved and restored is unreliable, as seen here. It's easier and simpler
+to just always reset it to 'true' between tests.
+
+* testing/InternalSettings.cpp:
+(WebCore::InternalSettings::Backup::Backup):
+(WebCore::InternalSettings::Backup::restoreTo):
+(WebCore::InternalSettings::InternalSettings):
+(WebCore::InternalSettings::reset):
+* testing/InternalSettings.h:
+(Backup):
+
2012-12-20 Erik Arvidsson a...@chromium.org
REGRESSION(r138263): Don't use fastGetAttribute for HTMLNames::classAttr because it breaks on SVGElement
Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (138277 => 138278)
--- trunk/Source/WebCore/testing/InternalSettings.cpp 2012-12-20 19:16:00 UTC (rev 138277)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2012-12-20 19:30:59 UTC (rev 138278)
@@ -61,7 +61,7 @@
namespace WebCore {
-InternalSettings::Backup::Backup(Page* page, Settings* settings)
+InternalSettings::Backup::Backup(Settings* settings)
: m_originalPasswordEchoDurationInSeconds(settings-passwordEchoDurationInSeconds())
, m_originalPasswordEchoEnabled(settings-passwordEchoEnabled())
, m_originalFixedElementsLayoutRelativeToFrame(settings-fixedElementsLayoutRelativeToFrame())
@@ -91,7 +91,6 @@
#if ENABLE(DIALOG_ELEMENT)
, m_originalDialogElementEnabled(RuntimeEnabledFeatures::dialogElementEnabled())
#endif
-, m_canStartMedia(page-canStartMedia())
, m_originalForceCompositingMode(settings-forceCompositingMode())
, m_originalCompositingForFixedPositionEnabled(settings-acceleratedCompositingForFixedPositionEnabled())
, m_originalCompositingForScrollableFramesEnabled(settings-acceleratedCompositingForScrollableFramesEnabled())
@@ -108,7 +107,7 @@
}
-void InternalSettings::Backup::restoreTo(Page* page, Settings* settings)
+void InternalSettings::Backup::restoreTo(Settings* settings)
{
settings-setPasswordEchoDurationInSeconds(m_originalPasswordEchoDurationInSeconds);
settings-setPasswordEchoEnabled(m_originalPasswordEchoEnabled);
@@ -139,7 +138,6 @@
#if ENABLE(DIALOG_ELEMENT)
RuntimeEnabledFeatures::setDialogElementEnabled(m_originalDialogElementEnabled);
#endif
-page-setCanStartMedia(m_canStartMedia);
[webkit-changes] [138279] trunk/Source/WebKit/win
Title: [138279] trunk/Source/WebKit/win Revision 138279 Author ander...@apple.com Date 2012-12-20 11:36:37 -0800 (Thu, 20 Dec 2012) Log Message Copy WebKit2.rc to back to WebKit/win/WebKit.vcproj. Rubber-stamped by Tim Horton. * WebKit.vcproj/WebKit.rc: Added. Modified Paths trunk/Source/WebKit/win/ChangeLog Added Paths trunk/Source/WebKit/win/WebKit.vcproj/WebKit.rc Diff Modified: trunk/Source/WebKit/win/ChangeLog (138278 => 138279) --- trunk/Source/WebKit/win/ChangeLog 2012-12-20 19:30:59 UTC (rev 138278) +++ trunk/Source/WebKit/win/ChangeLog 2012-12-20 19:36:37 UTC (rev 138279) @@ -1,5 +1,13 @@ 2012-12-20 Anders Carlsson ander...@apple.com +Copy WebKit2.rc to back to WebKit/win/WebKit.vcproj. + +Rubber-stamped by Tim Horton. + +* WebKit.vcproj/WebKit.rc: Added. + +2012-12-20 Anders Carlsson ander...@apple.com + Copy files from WebKit2/win (back) to WebKit/win/WebKit.vcproj. Rubber-stamped by Tim Horton. Added: trunk/Source/WebKit/win/WebKit.vcproj/WebKit.rc (0 => 138279) --- trunk/Source/WebKit/win/WebKit.vcproj/WebKit.rc (rev 0) +++ trunk/Source/WebKit/win/WebKit.vcproj/WebKit.rc 2012-12-20 19:36:37 UTC (rev 138279) @@ -0,0 +1,52 @@ +// Microsoft Visual C++ generated resource script. +// +#include autoversion.h +#include resource.h +#include winresrc.h + +#ifdef _WIN32 +LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US +#pragma code_page(1252) +#endif //_WIN32 + +/ +// +// PNG +// + +IDR_RESIZE_CORNERPNG textAreaResizeCorner.png +IDR_MISSING_IMAGEPNG missingImage.png +IDR_NULL_PLUGIN PNG nullplugin.png +IDR_DELETE_BUTTONPNG deleteButton.png +IDR_DELETE_BUTTON_PRESSEDPNG deleteButtonPressed.png +IDR_ZOOM_IN_CURSOR PNG zoomInCursor.png +IDR_ZOOM_OUT_CURSOR PNG zoomOutCursor.png +IDR_VERTICAL_TEXT_CURSOR PNG verticalTextCursor.png +IDR_PAN_SCROLL_ICON PNG panIcon.png +IDR_PAN_SOUTH_CURSOR PNG panSouthCursor.png +IDR_PAN_NORTH_CURSOR PNG panNorthCursor.png +IDR_PAN_EAST_CURSOR PNG panEastCursor.png +IDR_PAN_WEST_CURSOR PNG panWestCursor.png +IDR_PAN_SOUTH_EAST_CURSORPNG panSouthEastCursor.png +IDR_PAN_SOUTH_WEST_CURSORPNG panSouthWestCursor.png +IDR_PAN_NORTH_EAST_CURSORPNG panNorthEastCursor.png +IDR_PAN_NORTH_WEST_CURSORPNG panNorthWestCursor.png +IDR_SEARCH_CANCELPNG searchCancel.png +IDR_SEARCH_CANCEL_PRESSEDPNG searchCancelPressed.png +IDR_SEARCH_MAGNIFIER PNG searchMagnifier.png +IDR_SEARCH_MAGNIFIER_RESULTS PNG searchMagnifierResults.png +IDR_FS_VIDEO_AUDIO_VOLUME_HIGH PNG fsVideoAudioVolumeHigh.png +IDR_FS_VIDEO_AUDIO_VOLUME_LOWPNG fsVideoAudioVolumeLow.png +IDR_FS_VIDEO_EXIT_FULLSCREEN PNG fsVideoExitFullscreen.png +IDR_FS_VIDEO_PAUSE PNG fsVideoPause.png +IDR_FS_VIDEO_PLAYPNG fsVideoPlay.png + +/ +// +// STRINGTABLE +// + +STRINGTABLE +BEGIN +BUILD_NUMBER __BUILD_NUMBER_SHORT__ +END ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138280] trunk/Websites/webkit.org
Title: [138280] trunk/Websites/webkit.org Revision 138280 Author rn...@webkit.org Date 2012-12-20 11:44:30 -0800 (Thu, 20 Dec 2012) Log Message Add a sample change log entry to contributing.html https://bugs.webkit.org/show_bug.cgi?id=105506 Reviewed by Alexey Proskuryakov. Added a sample change log to the page directly people skimming through the page will still see it. Also mention that prepare-ChangeLogs is automatically ran by webkit-patch upload. * coding/contributing.html: Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/coding/contributing.html Diff Modified: trunk/Websites/webkit.org/ChangeLog (138279 => 138280) --- trunk/Websites/webkit.org/ChangeLog 2012-12-20 19:36:37 UTC (rev 138279) +++ trunk/Websites/webkit.org/ChangeLog 2012-12-20 19:44:30 UTC (rev 138280) @@ -1,3 +1,15 @@ +2012-12-20 Ryosuke Niwa rn...@webkit.org + +Add a sample change log entry to contributing.html +https://bugs.webkit.org/show_bug.cgi?id=105506 + +Reviewed by Alexey Proskuryakov. + +Added a sample change log to the page directly people skimming through the page will still +see it. Also mention that prepare-ChangeLogs is automatically ran by webkit-patch upload. + +* coding/contributing.html: + 2012-12-18 Nico Weber tha...@chromium.org Fix broken loop in style guide Modified: trunk/Websites/webkit.org/coding/contributing.html (138279 => 138280) --- trunk/Websites/webkit.org/coding/contributing.html 2012-12-20 19:36:37 UTC (rev 138279) +++ trunk/Websites/webkit.org/coding/contributing.html 2012-12-20 19:44:30 UTC (rev 138280) @@ -129,8 +129,28 @@ h3 id=changelogsChangeLog files/h3 pChangeLogs are simple text files which provide historical documentation for all changes to the WebKit project. All patches require an entry to the ChangeLog. The codewebkit-patch upload/code script will create a basic entry containing a list of all files that have been changed. The first line contains the date, your full name, and your email address. Use this to write up a brief summary of the changes you've made. Don't worry about the Reviewed by NOBODY (OOPS!) line, the person landing your patch will fill this in./p -pThere is one ChangeLog per top-level directory, if you changed code and tests you will need to edit at least two ChangeLogs. The codeprepare-ChangeLog/code script will create a stub entries for you. You should edit these stubs to describe your change, including the full url to the bug (a href="" entry/a, note that you can use code--bug/code flag). (You should set EMAIL_ADDRESS and CHANGE_LOG_NAME in your environment if you will be running this script frequently.)/p +pThere is one ChangeLog per top-level directory, if you changed code and tests you will need to edit at least two ChangeLogs. The codeprepare-ChangeLog/code script (automatically ran by codewebkit-patch/code) will create a stub entries for you. You should edit these stubs to describe your change, including the full url to the bug (a href="" entry/a, note that you can use code--bug/code flag). (You should set EMAIL_ADDRESS and CHANGE_LOG_NAME in your environment if you will be running this script frequently.)/p +pA typical change log entry before being submitted to Bugzilla looks like this:/p +precode2012-10-04 Enrica Casucci lt;enr...@apple.comgt; + +Font::glyphDataAndPageForCharacter doesn't account for text orientation when using systemFallback on a cold cache. +https://bugs.webkit.org/show_bug.cgi?id=98452. + +Reviewed by NOBODY (OOPS!). + +The text orientation was considered only when there is a cache hit. +This change moves the logic to handle text orientation to a separate +inline function that is called also when the glyph is added to the cache. + +Test: fast/text/vertical-rl-rtl-linebreak.html + +* platform/graphics/FontFastPath.cpp: +(WebCore::applyTextOrientationForCharacter): Added. +(WebCore::Font::glyphDataAndPageForCharacter): Modified to use the new function in +both cases of cold and warm cache. +/code/pre + pThe No new tests. (OOPS!) line appears if codewebkit-patch/code did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), remove this line and explain why you didn't write tests. Otherwise all changes require test cases which should be mentioned in the ChangeLog. If you keep this line in your ChangeLog entry, your patch will be rejected by the commit bot./p ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138281] trunk
Title: [138281] trunk
Revision 138281
Author simon...@chromium.org
Date 2012-12-20 12:07:32 -0800 (Thu, 20 Dec 2012)
Log Message
[Resource Timing] 304 responses should show up in the timing buffer
https://bugs.webkit.org/show_bug.cgi?id=105490
Reviewed by Tony Gentilcore.
Source/WebCore:
Test: http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached.html
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::loadDone):
LayoutTests:
* http/tests/w3c/webperf/resources/generate_resource.php:
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached-expected.txt: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/w3c/webperf/resources/generate_resource.php
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
Added Paths
trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached-expected.txt
trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138280 => 138281)
--- trunk/LayoutTests/ChangeLog 2012-12-20 19:44:30 UTC (rev 138280)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 20:07:32 UTC (rev 138281)
@@ -1,3 +1,14 @@
+2012-12-20 James Simonsen simon...@chromium.org
+
+[Resource Timing] 304 responses should show up in the timing buffer
+https://bugs.webkit.org/show_bug.cgi?id=105490
+
+Reviewed by Tony Gentilcore.
+
+* http/tests/w3c/webperf/resources/generate_resource.php:
+* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached-expected.txt: Added.
+* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached.html: Added.
+
2012-12-20 Elliott Sprehn espr...@gmail.com
Block level pseudo elements bleed background color to html
Modified: trunk/LayoutTests/http/tests/w3c/webperf/resources/generate_resource.php (138280 => 138281)
--- trunk/LayoutTests/http/tests/w3c/webperf/resources/generate_resource.php 2012-12-20 19:44:30 UTC (rev 138280)
+++ trunk/LayoutTests/http/tests/w3c/webperf/resources/generate_resource.php 2012-12-20 20:07:32 UTC (rev 138281)
@@ -1,4 +1,9 @@
?php
+ if (isset($_SERVER['HTTP_IF_NONE_MATCH'])) {
+header('HTTP/1.1 304 Not Modified');
+exit;
+ }
+
$type = $_GET[type];
$response_code = 200;
@@ -43,6 +48,7 @@
header(HTTP/1.1 $response_code);
header(Content-type: $content_type);
+ header(Etag: 7);
print($body);
exit;
?
Added: trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached-expected.txt (0 => 138281)
--- trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached-expected.txt 2012-12-20 20:07:32 UTC (rev 138281)
@@ -0,0 +1,9 @@
+Description
+
+This test validates that a 304 Not Modified resource appears in the buffer.
+
+
+
+PASS There should be two entries
+PASS Both entries should have the same name
+
Added: trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached.html (0 => 138281)
--- trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached.html (rev 0)
+++ trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached.html 2012-12-20 20:07:32 UTC (rev 138281)
@@ -0,0 +1,51 @@
+!DOCTYPE html
+html
+head
+meta charset=utf-8 /
+titleResource Timing cached resources/title
+link rel=author title=Google href="" /
+link rel=help href=""
+script src=""
+script src=""
+script src=""
+script
+setup({explicit_done: true});
+var d;
+var iframe;
+var iframeBody;
+var image;
+function setup_iframe() {
+iframe = document.getElementById('frameContext');
+d = iframe.contentWindow.document;
+iframeBody = d.createElement('body');
+
+image = d.createElement('img');
+image.src = '';
+iframeBody.appendChild(image);
+}
+function reload_image() {
+iframeBody.removeChild(image);
+image = d.createElement('img');
+image.src = '';
+image.addEventListener('load', onload_test, false);
+iframeBody.appendChild(image);
+}
+function onload_test() {
+var entries = iframe.contentWindow.performance.webkitGetEntries();
+test_equals(entries.length, 2, There should be two entries);
+if (entries.length = 2) {
+test_equals(entries[0].name, entries[1].name, Both entries should have the same name);
+}
+done();
+}
+window.setup_iframe = setup_iframe;
+window.addEventListener(load, reload_image, false);
+/script
+/head
+body
+h1Description/h1
+pThis test validates that a 304 Not Modified resource appears in the
[webkit-changes] [138282] trunk
Title: [138282] trunk
Revision 138282
Author d...@apple.com
Date 2012-12-20 12:10:53 -0800 (Thu, 20 Dec 2012)
Log Message
Follow WebVTT line breaking rules
https://bugs.webkit.org/show_bug.cgi?id=105496
Reviewed by Eric Carlson.
Source/WebCore:
WebVTT requires that captions never overflow their containers. In other
words, that it is ok to break within words rather than hide content.
Implement this by using CSS's word-break property.
Test: media/track/track-word-breaking.html
* css/mediaControls.css:
(video::-webkit-media-text-track-container): Add word-break.
* css/mediaControlsQuickTime.css: Drive-by cleanup to make sure selection doesn't happen.
(audio::-webkit-media-controls-closed-captions-container, video::-webkit-media-controls-closed-captions-container):
(audio::-webkit-media-controls-closed-captions-track-list, video::-webkit-media-controls-closed-captions-track-list):
LayoutTests:
Test that captions do emergency line breaking. Since we can't
rely on text dimensions, the test simply compares a caption that
will be on one line to a caption with a single huge word, that must
break at least twice. If the bounding rectangle of the second caption
is bigger than the first, we know we broke.
* media/track/captions-webvtt/long-word.vtt: Added.
* media/track/track-word-breaking-expected.txt: Added.
* media/track/track-word-breaking.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mediaControls.css
trunk/Source/WebCore/css/mediaControlsQuickTime.css
Added Paths
trunk/LayoutTests/media/track/captions-webvtt/long-word.vtt
trunk/LayoutTests/media/track/track-word-breaking-expected.txt
trunk/LayoutTests/media/track/track-word-breaking.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138281 => 138282)
--- trunk/LayoutTests/ChangeLog 2012-12-20 20:07:32 UTC (rev 138281)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 20:10:53 UTC (rev 138282)
@@ -1,3 +1,20 @@
+2012-12-19 Dean Jackson d...@apple.com
+
+Follow WebVTT line breaking rules
+https://bugs.webkit.org/show_bug.cgi?id=105496
+
+Reviewed by Eric Carlson.
+
+Test that captions do emergency line breaking. Since we can't
+rely on text dimensions, the test simply compares a caption that
+will be on one line to a caption with a single huge word, that must
+break at least twice. If the bounding rectangle of the second caption
+is bigger than the first, we know we broke.
+
+* media/track/captions-webvtt/long-word.vtt: Added.
+* media/track/track-word-breaking-expected.txt: Added.
+* media/track/track-word-breaking.html: Added.
+
2012-12-20 James Simonsen simon...@chromium.org
[Resource Timing] 304 responses should show up in the timing buffer
Added: trunk/LayoutTests/media/track/captions-webvtt/long-word.vtt (0 => 138282)
--- trunk/LayoutTests/media/track/captions-webvtt/long-word.vtt (rev 0)
+++ trunk/LayoutTests/media/track/captions-webvtt/long-word.vtt 2012-12-20 20:10:53 UTC (rev 138282)
@@ -0,0 +1,9 @@
+WEBVTT
+
+1
+00:00:00.000 -- 00:00:02.000
+first caption
+
+2
+00:00:02.000 -- 00:01:00.000
+mmm
Added: trunk/LayoutTests/media/track/track-word-breaking-expected.txt (0 => 138282)
--- trunk/LayoutTests/media/track/track-word-breaking-expected.txt (rev 0)
+++ trunk/LayoutTests/media/track/track-word-breaking-expected.txt 2012-12-20 20:10:53 UTC (rev 138282)
@@ -0,0 +1,7 @@
+Test that line breaks are forced in captions.
+EVENT(canplaythrough)
+Single line caption height recorded.
+EVENT(seeked)
+Second caption was more than twice as tall as first caption. OK
+END OF TEST
+
Property changes on: trunk/LayoutTests/media/track/track-word-breaking-expected.txt
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Added: trunk/LayoutTests/media/track/track-word-breaking.html (0 => 138282)
--- trunk/LayoutTests/media/track/track-word-breaking.html (rev 0)
+++ trunk/LayoutTests/media/track/track-word-breaking.html 2012-12-20 20:10:53 UTC (rev 138282)
@@ -0,0 +1,41 @@
+html
+head
+script src=""
+script src=""
+script src=""
+script
+
+var singleLineRect;
+
+function testUnbreakableLine()
+{
+var multiLineRect = textTrackDisplayElement(video).firstChild.firstChild.getBoundingClientRect();
+var ratio = multiLineRect.height / singleLineRect.height;
+logResult(ratio 2, Second caption was more than twice as tall as first
[webkit-changes] [138283] trunk/LayoutTests
Title: [138283] trunk/LayoutTests
Revision 138283
Author d...@apple.com
Date 2012-12-20 12:11:11 -0800 (Thu, 20 Dec 2012)
Log Message
Cleanup some captions menu tests
https://bugs.webkit.org/show_bug.cgi?id=105500
Reviewed by Eric Carlson.
Use the helper library where possible. Dynamically add
video.src so that we always get the 'canplaythrough' event.
* media/video-controls-captions-trackmenu-expected.txt:
* media/video-controls-captions-trackmenu-localized.html:
* media/video-controls-captions-trackmenu-sorted.html:
* media/video-controls-captions-trackmenu.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt
trunk/LayoutTests/media/video-controls-captions-trackmenu-localized.html
trunk/LayoutTests/media/video-controls-captions-trackmenu-sorted.html
trunk/LayoutTests/media/video-controls-captions-trackmenu.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138282 => 138283)
--- trunk/LayoutTests/ChangeLog 2012-12-20 20:10:53 UTC (rev 138282)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 20:11:11 UTC (rev 138283)
@@ -1,5 +1,20 @@
2012-12-19 Dean Jackson d...@apple.com
+Cleanup some captions menu tests
+https://bugs.webkit.org/show_bug.cgi?id=105500
+
+Reviewed by Eric Carlson.
+
+Use the helper library where possible. Dynamically add
+video.src so that we always get the 'canplaythrough' event.
+
+* media/video-controls-captions-trackmenu-expected.txt:
+* media/video-controls-captions-trackmenu-localized.html:
+* media/video-controls-captions-trackmenu-sorted.html:
+* media/video-controls-captions-trackmenu.html:
+
+2012-12-19 Dean Jackson d...@apple.com
+
Follow WebVTT line breaking rules
https://bugs.webkit.org/show_bug.cgi?id=105496
Modified: trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt (138282 => 138283)
--- trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt 2012-12-20 20:10:53 UTC (rev 138282)
+++ trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt 2012-12-20 20:11:11 UTC (rev 138283)
@@ -2,15 +2,14 @@
EVENT(canplaythrough)
-*** Add another text track.
-RUN(video.addTextTrack(captions, Commentary, ru))
-
*** Set the user language preference.
RUN(internals.setUserPreferredLanguages(['en']))
-*** Click the CC button.
+*** Add another text track.
+RUN(video.addTextTrack(captions, Commentary, ru))
*** Turning captions on
-Found 5 menu items OK
+There should be 5 items in the menu.
+EXPECTED (5 == '5') OK
EXPECTED (video.textTracks.length == '4') OK
Track 0 should be showing
EXPECTED (video.textTracks[0].mode == 'showing') OK
@@ -24,10 +23,9 @@
*** Remove a track.
RUN(video.removeChild(document.querySelectorAll(track)[0]))
-
-*** Click the CC button.
*** Turning captions off
-Found 4 menu items OK
+There should be 4 items in the menu.
+EXPECTED (4 == '4') OK
EXPECTED (video.textTracks.length == '3') OK
Track 0 should be disabled
EXPECTED (video.textTracks[0].mode == 'disabled') OK
Modified: trunk/LayoutTests/media/video-controls-captions-trackmenu-localized.html (138282 => 138283)
--- trunk/LayoutTests/media/video-controls-captions-trackmenu-localized.html 2012-12-20 20:10:53 UTC (rev 138282)
+++ trunk/LayoutTests/media/video-controls-captions-trackmenu-localized.html 2012-12-20 20:11:11 UTC (rev 138283)
@@ -52,6 +52,7 @@
function start()
{
findMediaElement();
+video.src = "" 'content/test');
waitForEvent('canplaythrough', function () { startTrackMenuTest(testMenuHeaders); });
}
/script
@@ -60,8 +61,6 @@
body _onload_=start()
pTest that captions and subtitles menu items are localized./p
video width=500 height=300 controls
-source src="" type=video/mp4
-source src="" type=video/ogg
track kind=captions src=""
track kind=subtitles src=""
/video
Modified: trunk/LayoutTests/media/video-controls-captions-trackmenu-sorted.html (138282 => 138283)
--- trunk/LayoutTests/media/video-controls-captions-trackmenu-sorted.html 2012-12-20 20:10:53 UTC (rev 138282)
+++ trunk/LayoutTests/media/video-controls-captions-trackmenu-sorted.html 2012-12-20 20:11:11 UTC (rev 138283)
@@ -49,6 +49,7 @@
function start()
{
findMediaElement();
+video.src = "" 'content/test');
waitForEvent('canplaythrough', function () { startTrackMenuTest(testSortedMenu); });
}
/script
@@ -57,8 +58,6 @@
body _onload_=start()
pTest that captions and subtitles are sorted in the menu./p
video width=500 height=300 controls
-source src="" type=video/mp4
-source src="" type=video/ogg
track label=c kind=captions src="" srclang=ja
track label=b kind=captions src=""
[webkit-changes] [138284] trunk/Source/WebCore
Title: [138284] trunk/Source/WebCore
Revision 138284
Author d...@apple.com
Date 2012-12-20 12:20:34 -0800 (Thu, 20 Dec 2012)
Log Message
Track menu in wrong location when fullscreen
https://bugs.webkit.org/show_bug.cgi?id=105234
Reviewed by Eric Carlson.
Add a rule to position the captions menu in the correct location
when the video is fullscreen. Also a drive-by removal of unnecessary
CSS selectors, and changing an encoded PNG into an SVG.
* css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-closed-captions-container): Add a rule to position
the menu when in fullscreen.
* css/mediaControlsQuickTime.css: Remove the unnecessary audio selectors.
(video::-webkit-media-controls-toggle-closed-captions-button):
(video::-webkit-media-controls-closed-captions-container):
(video::-webkit-media-controls-closed-captions-track-list):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/fullscreenQuickTime.css
trunk/Source/WebCore/css/mediaControlsQuickTime.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (138283 => 138284)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 20:11:11 UTC (rev 138283)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 20:20:34 UTC (rev 138284)
@@ -1,5 +1,24 @@
2012-12-19 Dean Jackson d...@apple.com
+Track menu in wrong location when fullscreen
+https://bugs.webkit.org/show_bug.cgi?id=105234
+
+Reviewed by Eric Carlson.
+
+Add a rule to position the captions menu in the correct location
+when the video is fullscreen. Also a drive-by removal of unnecessary
+CSS selectors, and changing an encoded PNG into an SVG.
+
+* css/fullscreenQuickTime.css:
+(video:-webkit-full-screen::-webkit-media-controls-closed-captions-container): Add a rule to position
+the menu when in fullscreen.
+* css/mediaControlsQuickTime.css: Remove the unnecessary audio selectors.
+(video::-webkit-media-controls-toggle-closed-captions-button):
+(video::-webkit-media-controls-closed-captions-container):
+(video::-webkit-media-controls-closed-captions-track-list):
+
+2012-12-19 Dean Jackson d...@apple.com
+
Follow WebVTT line breaking rules
https://bugs.webkit.org/show_bug.cgi?id=105496
Modified: trunk/Source/WebCore/css/fullscreenQuickTime.css (138283 => 138284)
--- trunk/Source/WebCore/css/fullscreenQuickTime.css 2012-12-20 20:11:11 UTC (rev 138283)
+++ trunk/Source/WebCore/css/fullscreenQuickTime.css 2012-12-20 20:20:34 UTC (rev 138284)
@@ -166,3 +166,9 @@
left: 8px;
right: 8px;
}
+
+video:-webkit-full-screen::-webkit-media-controls-closed-captions-container {
+bottom: 64px;
+margin-left: 205px;
+}
+
Modified: trunk/Source/WebCore/css/mediaControlsQuickTime.css (138283 => 138284)
--- trunk/Source/WebCore/css/mediaControlsQuickTime.css 2012-12-20 20:11:11 UTC (rev 138283)
+++ trunk/Source/WebCore/css/mediaControlsQuickTime.css 2012-12-20 20:20:34 UTC (rev 138284)
@@ -229,7 +229,7 @@
border: none !important;
}
-audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button {
+video::-webkit-media-controls-toggle-closed-captions-button {
-webkit-appearance: media-toggle-closed-captions-button;
display: -webkit-box;
width: 16px;
@@ -240,7 +240,7 @@
border: none !important;
}
-audio::-webkit-media-controls-closed-captions-container, video::-webkit-media-controls-closed-captions-container {
+video::-webkit-media-controls-closed-captions-container {
-webkit-appearance: media-closed-captions-container;
position: absolute;
display: block;
@@ -255,7 +255,7 @@
cursor: default;
}
-audio::-webkit-media-controls-closed-captions-track-list, video::-webkit-media-controls-closed-captions-track-list {
+video::-webkit-media-controls-closed-captions-track-list {
-webkit-appearance: media-closed-captions-track-list;
position: absolute;
display: block;
@@ -272,7 +272,6 @@
-webkit-user-select: none;
}
-audio::-webkit-media-controls-closed-captions-track-list h3,
video::-webkit-media-controls-closed-captions-track-list h3 {
margin: 0;
color: #bbb;
@@ -284,16 +283,15 @@
font-size: 9pt;
}
-audio::-webkit-media-controls-closed-captions-track-list ul,
video::-webkit-media-controls-closed-captions-track-list ul {
list-style-type: none;
margin: 0 0 8px 0;
padding: 0;
}
-audio::-webkit-media-controls-closed-captions-track-list li,
video::-webkit-media-controls-closed-captions-track-list li {
color: white;
+background-image: none;
text-shadow: 0 1px 0 black;
margin: 0;
padding-left: 24px;
@@ -310,24 +308,21 @@
-webkit-text-overflow: ellipsis;
}
-audio::-webkit-media-controls-closed-captions-track-list li:hover,
video::-webkit-media-controls-closed-captions-track-list li:hover {
background-image: -webkit-gradient(linear, left top,
[webkit-changes] [138285] trunk/Source
Title: [138285] trunk/Source Revision 138285 Author jap...@chromium.org Date 2012-12-20 12:26:43 -0800 (Thu, 20 Dec 2012) Log Message Rename shouldBufferData to dataBufferingPolicy https://bugs.webkit.org/show_bug.cgi?id=105450 Reviewed by Alexey Proskuryakov. No new tests, simple rename. Source/WebCore: * html/MediaDocument.cpp: (WebCore::MediaDocumentParser::createDocumentStructure): * html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes): * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveData): * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::setDataBufferingPolicy): * loader/MainResourceLoader.h: (MainResourceLoader): * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::setDataBufferingPolicy): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::willStopBufferingData): * loader/ResourceLoader.h: (ResourceLoader): * loader/ResourceLoaderOptions.h: (WebCore::ResourceLoaderOptions::ResourceLoaderOptions): (ResourceLoaderOptions): * loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::data): (WebCore::CachedRawResource::setDataBufferingPolicy): (WebCore::CachedRawResource::canReuse): * loader/cache/CachedRawResource.h: (CachedRawResource): * loader/cache/CachedResource.h: (WebCore::CachedResource::dataBufferingPolicy): * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didReceiveDataArray): * page/EventSource.cpp: (WebCore::EventSource::connect): Source/WebKit/chromium: * src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::loadAsynchronously): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/MediaDocument.cpp trunk/Source/WebCore/html/PluginDocument.cpp trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp trunk/Source/WebCore/loader/MainResourceLoader.cpp trunk/Source/WebCore/loader/MainResourceLoader.h trunk/Source/WebCore/loader/ResourceLoader.cpp trunk/Source/WebCore/loader/ResourceLoader.h trunk/Source/WebCore/loader/ResourceLoaderOptions.h trunk/Source/WebCore/loader/cache/CachedRawResource.cpp trunk/Source/WebCore/loader/cache/CachedRawResource.h trunk/Source/WebCore/loader/cache/CachedResource.h trunk/Source/WebCore/loader/mac/ResourceLoaderMac.mm trunk/Source/WebCore/page/EventSource.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (138284 => 138285) --- trunk/Source/WebCore/ChangeLog 2012-12-20 20:20:34 UTC (rev 138284) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 20:26:43 UTC (rev 138285) @@ -1,3 +1,46 @@ +2012-12-20 Nate Chapin jap...@chromium.org + +Rename shouldBufferData to dataBufferingPolicy +https://bugs.webkit.org/show_bug.cgi?id=105450 + +Reviewed by Alexey Proskuryakov. + +No new tests, simple rename. + +* html/MediaDocument.cpp: +(WebCore::MediaDocumentParser::createDocumentStructure): +* html/PluginDocument.cpp: +(WebCore::PluginDocumentParser::appendBytes): +* inspector/InspectorResourceAgent.cpp: +(WebCore::InspectorResourceAgent::didReceiveData): +* loader/DocumentThreadableLoader.cpp: +(WebCore::DocumentThreadableLoader::loadRequest): +* loader/MainResourceLoader.cpp: +(WebCore::MainResourceLoader::setDataBufferingPolicy): +* loader/MainResourceLoader.h: +(MainResourceLoader): +* loader/ResourceLoader.cpp: +(WebCore::ResourceLoader::setDataBufferingPolicy): +(WebCore::ResourceLoader::addData): +(WebCore::ResourceLoader::willStopBufferingData): +* loader/ResourceLoader.h: +(ResourceLoader): +* loader/ResourceLoaderOptions.h: +(WebCore::ResourceLoaderOptions::ResourceLoaderOptions): +(ResourceLoaderOptions): +* loader/cache/CachedRawResource.cpp: +(WebCore::CachedRawResource::data): +(WebCore::CachedRawResource::setDataBufferingPolicy): +(WebCore::CachedRawResource::canReuse): +* loader/cache/CachedRawResource.h: +(CachedRawResource): +* loader/cache/CachedResource.h: +(WebCore::CachedResource::dataBufferingPolicy): +* loader/mac/ResourceLoaderMac.mm: +(WebCore::ResourceLoader::didReceiveDataArray): +* page/EventSource.cpp: +(WebCore::EventSource::connect): + 2012-12-19 Dean Jackson d...@apple.com Track menu in wrong location when fullscreen Modified: trunk/Source/WebCore/html/MediaDocument.cpp (138284 => 138285) --- trunk/Source/WebCore/html/MediaDocument.cpp 2012-12-20 20:20:34 UTC (rev 138284) +++ trunk/Source/WebCore/html/MediaDocument.cpp 2012-12-20 20:26:43 UTC (rev 138285) @@ -105,7 +105,7 @@ if (!frame) return; -
[webkit-changes] [138286] trunk/LayoutTests
Title: [138286] trunk/LayoutTests Revision 138286 Author rn...@webkit.org Date 2012-12-20 12:29:48 -0800 (Thu, 20 Dec 2012) Log Message Update Mac test expectation per bugs 105566 and 105567. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138285 => 138286) --- trunk/LayoutTests/ChangeLog 2012-12-20 20:26:43 UTC (rev 138285) +++ trunk/LayoutTests/ChangeLog 2012-12-20 20:29:48 UTC (rev 138286) @@ -1,3 +1,9 @@ +2012-12-20 Ryosuke Niwa rn...@webkit.org + +Update Mac test expectation per bugs 105566 and 105567. + +* platform/mac/TestExpectations: + 2012-12-19 Dean Jackson d...@apple.com Cleanup some captions menu tests Modified: trunk/LayoutTests/platform/mac/TestExpectations (138285 => 138286) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 20:26:43 UTC (rev 138285) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 20:29:48 UTC (rev 138286) @@ -1262,3 +1262,6 @@ webkit.org/b/105049 compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html [ Failure ] webkit.org/b/105049 compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html [ Failure ] + +webkit.org/b/105566 media/track/track-webvtt-tc006-cue-identifiers.html [ Crash Pass ] +webkit.org/b/105567 http/tests/security/data-url-inline.css.html [ Crash Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138287] trunk/LayoutTests
Title: [138287] trunk/LayoutTests Revision 138287 Author rn...@webkit.org Date 2012-12-20 12:36:25 -0800 (Thu, 20 Dec 2012) Log Message Add a Mac test expectation per bug 104848. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138286 => 138287) --- trunk/LayoutTests/ChangeLog 2012-12-20 20:29:48 UTC (rev 138286) +++ trunk/LayoutTests/ChangeLog 2012-12-20 20:36:25 UTC (rev 138287) @@ -1,5 +1,11 @@ 2012-12-20 Ryosuke Niwa rn...@webkit.org +Add a Mac test expectation per bug 104848. + +* platform/mac/TestExpectations: + +2012-12-20 Ryosuke Niwa rn...@webkit.org + Update Mac test expectation per bugs 105566 and 105567. * platform/mac/TestExpectations: Modified: trunk/LayoutTests/platform/mac/TestExpectations (138286 => 138287) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 20:29:48 UTC (rev 138286) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 20:36:25 UTC (rev 138287) @@ -1265,3 +1265,6 @@ webkit.org/b/105566 media/track/track-webvtt-tc006-cue-identifiers.html [ Crash Pass ] webkit.org/b/105567 http/tests/security/data-url-inline.css.html [ Crash Pass ] + +webkit.org/b/104848 fast/frames/sandboxed-iframe-attribute-parsing.html [ Failure Pass ] +webkit.org/b/104848 fast/frames/sandboxed-iframe-parsing-space-characters.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138288] trunk/Source/WebCore
Title: [138288] trunk/Source/WebCore
Revision 138288
Author a...@apple.com
Date 2012-12-20 13:04:36 -0800 (Thu, 20 Dec 2012)
Log Message
REGRESSION (r138191): Tests fail in ResourceRequest::setStorageSession
https://bugs.webkit.org/show_bug.cgi?id=105563
Reviewed by Sam Weinig.
* platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willSendRequest):
* platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest):
Don't try to appky a session if client canceled the request by setting it ot a null one.
* platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::setStorageSession):
* platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::setStorageSession):
Update platform request, so that the session does not get lost once it's updated later.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp
trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm
trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (138287 => 138288)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 20:36:25 UTC (rev 138287)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 21:04:36 UTC (rev 138288)
@@ -1,3 +1,18 @@
+2012-12-20 Alexey Proskuryakov a...@apple.com
+
+REGRESSION (r138191): Tests fail in ResourceRequest::setStorageSession
+https://bugs.webkit.org/show_bug.cgi?id=105563
+
+Reviewed by Sam Weinig.
+
+* platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willSendRequest):
+* platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest):
+Don't try to appky a session if client canceled the request by setting it ot a null one.
+
+* platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::setStorageSession):
+* platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::setStorageSession):
+Update platform request, so that the session does not get lost once it's updated later.
+
2012-12-20 Nate Chapin jap...@chromium.org
Rename shouldBufferData to dataBufferingPolicy
Modified: trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp (138287 => 138288)
--- trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp 2012-12-20 20:36:25 UTC (rev 138287)
+++ trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp 2012-12-20 21:04:36 UTC (rev 138288)
@@ -562,7 +562,8 @@
client()-willSendRequest(this, request, redirectResponse);
// Client call may not preserve the session, especially if the request is sent over IPC.
-request.setStorageSession(d-m_storageSession.get());
+if (!request.isNull())
+request.setStorageSession(d-m_storageSession.get());
}
bool ResourceHandle::shouldUseCredentialStorage()
Modified: trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp (138287 => 138288)
--- trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp 2012-12-20 20:36:25 UTC (rev 138287)
+++ trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp 2012-12-20 21:04:36 UTC (rev 138288)
@@ -223,6 +223,8 @@
void ResourceRequest::setStorageSession(CFURLStorageSessionRef storageSession)
{
+updatePlatformRequest();
+
CFMutableURLRequestRef cfRequest = CFURLRequestCreateMutableCopy(0, m_cfRequest.get());
wkSetRequestStorageSession(storageSession, cfRequest);
m_cfRequest.adoptCF(cfRequest);
Modified: trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm (138287 => 138288)
--- trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2012-12-20 20:36:25 UTC (rev 138287)
+++ trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2012-12-20 21:04:36 UTC (rev 138288)
@@ -475,7 +475,8 @@
client()-willSendRequest(this, request, redirectResponse);
// Client call may not preserve the session, especially if the request is sent over IPC.
-request.setStorageSession(d-m_storageSession.get());
+if (!request.isNull())
+request.setStorageSession(d-m_storageSession.get());
}
bool ResourceHandle::shouldUseCredentialStorage()
Modified: trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm (138287 => 138288)
--- trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm 2012-12-20 20:36:25 UTC (rev 138287)
+++ trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm 2012-12-20 21:04:36 UTC (rev 138288)
@@ -187,6 +187,7 @@
void ResourceRequest::setStorageSession(CFURLStorageSessionRef storageSession)
{
+updatePlatformRequest();
m_nsRequest.adoptNS(wkCopyRequestWithStorageSession(storageSession, m_nsRequest.get()));
}
___
[webkit-changes] [138289] trunk/LayoutTests
Title: [138289] trunk/LayoutTests Revision 138289 Author commit-qu...@webkit.org Date 2012-12-20 13:15:48 -0800 (Thu, 20 Dec 2012) Log Message [Chromium] Restore WebM EME canPlayType() expectations. https://bugs.webkit.org/show_bug.cgi?id=105070 Unreviewed TestExpectations revert of r137225. Patch by David Dorwin ddor...@chromium.org on 2012-12-20 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138288 => 138289) --- trunk/LayoutTests/ChangeLog 2012-12-20 21:04:36 UTC (rev 138288) +++ trunk/LayoutTests/ChangeLog 2012-12-20 21:15:48 UTC (rev 138289) @@ -1,3 +1,12 @@ +2012-12-20 David Dorwin ddor...@chromium.org + +[Chromium] Restore WebM EME canPlayType() expectations. +https://bugs.webkit.org/show_bug.cgi?id=105070 + +Unreviewed TestExpectations revert of r137225. + +* platform/chromium/TestExpectations: + 2012-12-20 Ryosuke Niwa rn...@webkit.org Add a Mac test expectation per bug 104848. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (138288 => 138289) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-20 21:04:36 UTC (rev 138288) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-20 21:15:48 UTC (rev 138289) @@ -4268,9 +4268,6 @@ webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html [ Failure Pass ] webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types.html [ Timeout Pass ] -# Broken by Chromium r172175 -crbug.com/165315 media/encrypted-media/encrypted-media-can-play-type-webm.html [ Failure ] - # New test added in r137331 webkit.org/b/104715 [ MountainLion ] fast/block/float/floats-wrap-inside-inline-007.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138290] trunk/Source/WebCore
Title: [138290] trunk/Source/WebCore Revision 138290 Author alecfl...@chromium.org Date 2012-12-20 13:20:23 -0800 (Thu, 20 Dec 2012) Log Message IndexedDB: Cursor and IndexWriter cleanup for refactor https://bugs.webkit.org/show_bug.cgi?id=105449 Reviewed by Tony Chang. This is a cleanup of some code to make the refactor that is coming in https://bugs.webkit.org/show_bug.cgi?id=102741 cleaner. Some CursorType assertions have been removed because the code will be used in more generic circumstances in a future patch. The previously-private IndexWriter has been pulled into IDBObjectStoreBackendImpl and made to just use IDB*Metadata so it can be reused later. No new tests as this does not change the logic of executing code. * Modules/indexeddb/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::perform): * Modules/indexeddb/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create): (WebCore::IDBCursorBackendImpl::value): (IDBCursorBackendImpl): * Modules/indexeddb/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::create): (WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::OpenIndexCursorOperation): (IDBIndexBackendImpl::OpenIndexCursorOperation): (WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::perform): * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::IndexWriter::verifyIndexKeys): (WebCore::IDBObjectStoreBackendImpl::IndexWriter::writeIndexKeys): (WebCore::IDBObjectStoreBackendImpl::IndexWriter::addingKeyAllowed): (WebCore::IDBObjectStoreBackendImpl::makeIndexWriters): * Modules/indexeddb/IDBObjectStoreBackendImpl.h: (IndexWriter): (WebCore::IDBObjectStoreBackendImpl::IndexWriter::IndexWriter): (IDBObjectStoreBackendImpl): * Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::setCursorDetails): (WebCore::IDBRequest::setResultCursor): (WebCore::IDBRequest::onSuccess): * Modules/indexeddb/IDBRequest.h: (IDBRequest): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp trunk/Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h trunk/Source/WebCore/Modules/indexeddb/IDBCursorBackendInterface.h trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp trunk/Source/WebCore/Modules/indexeddb/IDBIndexBackendImpl.cpp trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (138289 => 138290) --- trunk/Source/WebCore/ChangeLog 2012-12-20 21:15:48 UTC (rev 138289) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 21:20:23 UTC (rev 138290) @@ -1,3 +1,50 @@ +2012-12-20 Alec Flett alecfl...@chromium.org + +IndexedDB: Cursor and IndexWriter cleanup for refactor +https://bugs.webkit.org/show_bug.cgi?id=105449 + +Reviewed by Tony Chang. + +This is a cleanup of some code to make the refactor that is coming +in https://bugs.webkit.org/show_bug.cgi?id=102741 cleaner. Some +CursorType assertions have been removed because the code will be +used in more generic circumstances in a future patch. + +The previously-private IndexWriter has been pulled into +IDBObjectStoreBackendImpl and made to just use IDB*Metadata +so it can be reused later. + +No new tests as this does not change the logic of executing code. + +* Modules/indexeddb/IDBCursorBackendImpl.cpp: +(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): +(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::perform): +* Modules/indexeddb/IDBCursorBackendImpl.h: +(WebCore::IDBCursorBackendImpl::create): +(WebCore::IDBCursorBackendImpl::value): +(IDBCursorBackendImpl): +* Modules/indexeddb/IDBIndexBackendImpl.cpp: +(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::create): +(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::OpenIndexCursorOperation): +(IDBIndexBackendImpl::OpenIndexCursorOperation): +(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::perform): +* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: +(WebCore::IDBObjectStoreBackendImpl::IndexWriter::verifyIndexKeys): +(WebCore::IDBObjectStoreBackendImpl::IndexWriter::writeIndexKeys): +(WebCore::IDBObjectStoreBackendImpl::IndexWriter::addingKeyAllowed): +(WebCore::IDBObjectStoreBackendImpl::makeIndexWriters): +* Modules/indexeddb/IDBObjectStoreBackendImpl.h: +(IndexWriter): +(WebCore::IDBObjectStoreBackendImpl::IndexWriter::IndexWriter): +(IDBObjectStoreBackendImpl): +*
[webkit-changes] [138291] trunk/Source/WebCore
Title: [138291] trunk/Source/WebCore
Revision 138291
Author commit-qu...@webkit.org
Date 2012-12-20 13:22:08 -0800 (Thu, 20 Dec 2012)
Log Message
[TexMap] Remove ParentChange in TextureMapperLayer.
https://bugs.webkit.org/show_bug.cgi?id=105494
Patch by Huang Dongsung luxte...@company100.net on 2012-12-20
Reviewed by Noam Rosenthal.
ParentChange is useless, because ChildrenChange is enough. In addition,
GraphicsLayer uses setParent() method internally. This patch copies
GraphicsLayer::setChildren() into TextureMapperLayer::setChildren().
No new tests. Covered by existing tests.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore):
(WebCore::GraphicsLayerTextureMapper::setChildren):
Match the similar style of replaceChild().
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
(WebCore::TextureMapperLayer::setChildren):
Copied from GraphicsLayer::setChildren().
(WebCore):
(WebCore::TextureMapperLayer::addChild):
Copied from GraphicsLayer::addChild().
(WebCore::TextureMapperLayer::removeFromParent):
Copied from GraphicsLayer::removeFromParent().
(WebCore::TextureMapperLayer::removeAllChildren):
Copied from GraphicsLayer::removeAllChildren().
* platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138290 => 138291)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 21:20:23 UTC (rev 138290)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 21:22:08 UTC (rev 138291)
@@ -1,3 +1,36 @@
+2012-12-20 Huang Dongsung luxte...@company100.net
+
+[TexMap] Remove ParentChange in TextureMapperLayer.
+https://bugs.webkit.org/show_bug.cgi?id=105494
+
+Reviewed by Noam Rosenthal.
+
+ParentChange is useless, because ChildrenChange is enough. In addition,
+GraphicsLayer uses setParent() method internally. This patch copies
+GraphicsLayer::setChildren() into TextureMapperLayer::setChildren().
+
+No new tests. Covered by existing tests.
+
+* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+(WebCore):
+(WebCore::GraphicsLayerTextureMapper::setChildren):
+ Match the similar style of replaceChild().
+* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
+(GraphicsLayerTextureMapper):
+* platform/graphics/texmap/TextureMapperLayer.cpp:
+(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
+(WebCore::TextureMapperLayer::setChildren):
+ Copied from GraphicsLayer::setChildren().
+(WebCore):
+(WebCore::TextureMapperLayer::addChild):
+ Copied from GraphicsLayer::addChild().
+(WebCore::TextureMapperLayer::removeFromParent):
+ Copied from GraphicsLayer::removeFromParent().
+(WebCore::TextureMapperLayer::removeAllChildren):
+ Copied from GraphicsLayer::removeAllChildren().
+* platform/graphics/texmap/TextureMapperLayer.h:
+(TextureMapperLayer):
+
2012-12-20 Alec Flett alecfl...@chromium.org
IndexedDB: Cursor and IndexWriter cleanup for refactor
Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (138290 => 138291)
--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp 2012-12-20 21:20:23 UTC (rev 138290)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp 2012-12-20 21:22:08 UTC (rev 138291)
@@ -120,18 +120,13 @@
/* \reimp (GraphicsLayer.h)
*/
-void GraphicsLayerTextureMapper::setParent(GraphicsLayer* layer)
-{
-notifyChange(TextureMapperLayer::ParentChange);
-GraphicsLayer::setParent(layer);
-}
-
-/* \reimp (GraphicsLayer.h)
-*/
bool GraphicsLayerTextureMapper::setChildren(const VectorGraphicsLayer* children)
{
-notifyChange(TextureMapperLayer::ChildrenChange);
-return GraphicsLayer::setChildren(children);
+if (GraphicsLayer::setChildren(children)) {
+notifyChange(TextureMapperLayer::ChildrenChange);
+return true;
+}
+return false;
}
/* \reimp (GraphicsLayer.h)
@@ -179,16 +174,6 @@
/* \reimp (GraphicsLayer.h)
*/
-void GraphicsLayerTextureMapper::removeFromParent()
-{
-if (!parent())
-return;
-notifyChange(TextureMapperLayer::ParentChange);
-GraphicsLayer::removeFromParent();
-}
-
-/* \reimp (GraphicsLayer.h)
-*/
void GraphicsLayerTextureMapper::setMaskLayer(GraphicsLayer* value)
{
if (value == maskLayer())
Modified:
[webkit-changes] [138292] trunk/LayoutTests
Title: [138292] trunk/LayoutTests Revision 138292 Author t...@chromium.org Date 2012-12-20 13:22:29 -0800 (Thu, 20 Dec 2012) Log Message [chromium] Unreviewed gardening. Mark an inspector test as flakey and update form date tests after r138255. * platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: * platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt trunk/LayoutTests/platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (138291 => 138292) --- trunk/LayoutTests/ChangeLog 2012-12-20 21:22:08 UTC (rev 138291) +++ trunk/LayoutTests/ChangeLog 2012-12-20 21:22:29 UTC (rev 138292) @@ -1,3 +1,13 @@ +2012-12-20 Tony Chang t...@chromium.org + +[chromium] Unreviewed gardening. + +Mark an inspector test as flakey and update form date tests after r138255. + +* platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: +* platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: +* platform/chromium/TestExpectations: + 2012-12-20 David Dorwin ddor...@chromium.org [Chromium] Restore WebM EME canPlayType() expectations. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (138291 => 138292) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-20 21:22:08 UTC (rev 138291) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-20 21:22:29 UTC (rev 138292) @@ -3716,6 +3716,7 @@ webkit.org/b/89826 [ Mac Win ] fast/css/word-space-extra.html [ Failure ] webkit.org/b/94002 [ Win7 Debug ] inspector/debugger [ Pass Timeout ] +webkit.org/b/94002 [ Win7 Debug ] inspector/debugger/event-listener-breakpoints.html [ Pass Timeout Failure ] # Flaky webkit.org/b/99389 [ Win ] inspector/debugger/xhr-breakpoints.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt (138291 => 138292) --- trunk/LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt 2012-12-20 21:22:08 UTC (rev 138291) +++ trunk/LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt 2012-12-20 21:22:29 UTC (rev 138292) @@ -21,9 +21,9 @@ PASS input.value is 2012-10-29 PASS input.value is 2012-08-29 == Up/Down keys on empty value == -PASS input.value is 2012-11-01 +PASS input.value is currentYear + -11-01 == Up/Down keys on empty value 2 == -PASS input.value is 2012-02-28 +PASS input.value is currentYear + -02-28 == Tab key == PASS input.value is 2012-09-05 PASS input.value is 2012-09-07 Modified: trunk/LayoutTests/platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt (138291 => 138292) --- trunk/LayoutTests/platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt 2012-12-20 21:22:08 UTC (rev 138291) +++ trunk/LayoutTests/platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt 2012-12-20 21:22:29 UTC (rev 138292) @@ -21,7 +21,7 @@ PASS input.value is 2012-10-29T00:00 PASS input.value is 2012-08-29T00:00 == Up/Down keys on empty value == -PASS input.value is 2012-11-01T01:59 +PASS input.value is currentYear + -11-01T01:59 == Tab key == PASS input.value is 2012-09-05T12:00 PASS document.activeElement.id is after ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138293] trunk/Source/WTF
Title: [138293] trunk/Source/WTF
Revision 138293
Author oli...@apple.com
Date 2012-12-20 13:35:56 -0800 (Thu, 20 Dec 2012)
Log Message
Harden pointers in FastMalloc's singly linked list implementation
https://bugs.webkit.org/show_bug.cgi?id=105571
Reviewed by Gavin Barraclough.
Add simple xor based hardening of the next pointer in the
fast malloc singly linked list implementation. We rely on
ASLR to introduce the address randomness we want for the mask.
Happily this produces a very low cost random value to use.
* wtf/FastMalloc.cpp:
(WTF):
(WTF::SLL_Next):
(WTF::SLL_SetNext):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FastMalloc.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (138292 => 138293)
--- trunk/Source/WTF/ChangeLog 2012-12-20 21:22:29 UTC (rev 138292)
+++ trunk/Source/WTF/ChangeLog 2012-12-20 21:35:56 UTC (rev 138293)
@@ -1,3 +1,20 @@
+2012-12-20 Oliver Hunt oli...@apple.com
+
+Harden pointers in FastMalloc's singly linked list implementation
+https://bugs.webkit.org/show_bug.cgi?id=105571
+
+Reviewed by Gavin Barraclough.
+
+Add simple xor based hardening of the next pointer in the
+fast malloc singly linked list implementation. We rely on
+ASLR to introduce the address randomness we want for the mask.
+Happily this produces a very low cost random value to use.
+
+* wtf/FastMalloc.cpp:
+(WTF):
+(WTF::SLL_Next):
+(WTF::SLL_SetNext):
+
2012-12-19 Oliver Hunt oli...@apple.com
StringImpl isolatedCopy unnecessarily copies text-segment character data
Modified: trunk/Source/WTF/wtf/FastMalloc.cpp (138292 => 138293)
--- trunk/Source/WTF/wtf/FastMalloc.cpp 2012-12-20 21:22:29 UTC (rev 138292)
+++ trunk/Source/WTF/wtf/FastMalloc.cpp 2012-12-20 21:35:56 UTC (rev 138293)
@@ -100,6 +100,11 @@
#define FORCE_SYSTEM_MALLOC 1
#endif
+// Harden the pointers stored in the TCMalloc linked lists
+#if COMPILER(GCC)
+#define ENABLE_TCMALLOC_HARDENING 1
+#endif
+
// Use a background thread to periodically scavenge memory to release back to the system
#if PLATFORM(IOS)
#define USE_BACKGROUND_THREAD_TO_SCAVENGE_MEMORY 0
@@ -496,6 +501,23 @@
#define MESSAGE LOG_ERROR
#define CHECK_CONDITION ASSERT
+#if ENABLE(TCMALLOC_HARDENING)
+/*
+ * To make it harder to exploit use-after free style exploits
+ * we mask the addresses we put into our linked lists with the
+ * address of kLLHardeningMask. Due to ASLR the address of
+ * kLLHardeningMask should be sufficiently randomized to make direct
+ * freelist manipulation much more difficult.
+ */
+static const char kLLHardeningMask = 0;
+#define MASK_PTR(ptr) (reinterpret_casttypeof(ptr)(reinterpret_castuintptr_t(ptr)^reinterpret_castuintptr_t(kLLHardeningMask)))
+#define UNMASK_PTR(ptr) (reinterpret_casttypeof(ptr)(reinterpret_castuintptr_t(ptr)^reinterpret_castuintptr_t(kLLHardeningMask)))
+#else
+#define MASK_PTR(ptr) (ptr)
+#define UNMASK_PTR(ptr) (ptr)
+#endif
+
+
//---
// Configuration
//---
@@ -662,11 +684,11 @@
// storage.
static inline void *SLL_Next(void *t) {
- return *(reinterpret_castvoid**(t));
+ return UNMASK_PTR(*(reinterpret_castvoid**(t)));
}
static inline void SLL_SetNext(void *t, void *n) {
- *(reinterpret_castvoid**(t)) = n;
+ *(reinterpret_castvoid**(t)) = MASK_PTR(n);
}
static inline void SLL_Push(void **list, void *element) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138294] trunk/Tools
Title: [138294] trunk/Tools
Revision 138294
Author tha...@chromium.org
Date 2012-12-20 13:37:41 -0800 (Thu, 20 Dec 2012)
Log Message
chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
https://bugs.webkit.org/show_bug.cgi?id=105498
Reviewed by Dirk Pranke.
Use the newest binary available rather than an than always picking one
build directory over another based on iteration order.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._static_build_path):
Check for timestamps.
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_build_path_timestamps):
Test that out / xcodebuild selection happens based on timestamps
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinPortTest.test_build_path_timestamps):
Test that out / build selection happens based on timestamps
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (138293 => 138294)
--- trunk/Tools/ChangeLog 2012-12-20 21:35:56 UTC (rev 138293)
+++ trunk/Tools/ChangeLog 2012-12-20 21:37:41 UTC (rev 138294)
@@ -1,3 +1,23 @@
+2012-12-20 Nico Weber tha...@chromium.org
+
+chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
+https://bugs.webkit.org/show_bug.cgi?id=105498
+
+Reviewed by Dirk Pranke.
+
+Use the newest binary available rather than an than always picking one
+build directory over another based on iteration order.
+
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumPort._static_build_path):
+Check for timestamps.
+* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
+(ChromiumMacPortTest.test_build_path_timestamps):
+Test that out / xcodebuild selection happens based on timestamps
+* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
+(ChromiumWinPortTest.test_build_path_timestamps):
+Test that out / build selection happens based on timestamps
+
2012-12-19 Simon Fraser simon.fra...@apple.com
Lots of sticky tests failing in WK2
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (138293 => 138294)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-12-20 21:35:56 UTC (rev 138293)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-12-20 21:37:41 UTC (rev 138294)
@@ -84,16 +84,26 @@
if build_directory:
return filesystem.join(build_directory, configuration, *comps)
+hits = []
for directory in cls.DEFAULT_BUILD_DIRECTORIES:
base_dir = filesystem.join(chromium_base, directory, configuration)
-if filesystem.exists(base_dir):
-return filesystem.join(base_dir, *comps)
+path = filesystem.join(base_dir, *comps)
+if filesystem.exists(path):
+hits.append((filesystem.mtime(path), path))
+if hits:
+hits.sort(reverse=True)
+return hits[0][1] # Return the newest file found.
for directory in cls.DEFAULT_BUILD_DIRECTORIES:
base_dir = filesystem.join(webkit_base, directory, configuration)
-if filesystem.exists(base_dir):
-return filesystem.join(base_dir, *comps)
+path = filesystem.join(base_dir, *comps)
+if filesystem.exists(path):
+hits.append((filesystem.mtime(path), path))
+if hits:
+hits.sort(reverse=True)
+return hits[0][1] # Return the newest file found.
+
# We have to default to something, so pick the last one.
return filesystem.join(base_dir, *comps)
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py (138293 => 138294)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py 2012-12-20 21:35:56 UTC (rev 138293)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py 2012-12-20 21:37:41 UTC (rev 138294)
@@ -95,6 +95,18 @@
options = MockOptions(configuration='Release', build_directory=None)
self.assert_build_path(options, ['/mock-checkout/Source/WebKit/chromium/xcodebuild/Release', '/mock-checkout/Source/WebKit/chromium/out/Release'], '/mock-checkout/Source/WebKit/chromium/xcodebuild/Release')
+def test_build_path_timestamps(self):
+options = MockOptions(configuration='Release', build_directory=None)
+port = self.make_port(options=options)
+port.host.filesystem.maybe_make_directory('/mock-checkout/out/Release')
+port.host.filesystem.maybe_make_directory('/mock-checkout/xcodebuild/Release')
+# Check with 'out' being newer.
+
[webkit-changes] [138295] trunk/LayoutTests
Title: [138295] trunk/LayoutTests Revision 138295 Author t...@chromium.org Date 2012-12-20 13:38:30 -0800 (Thu, 20 Dec 2012) Log Message [chromium] Unreviewed gardening. Rebaseline tests mentioned in 105121 and remove tests that are passing on Win bots according to the flakiness dashboard. * platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png: Added. * platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png: Added. * platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png: Added. * platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png: Added. * platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png: Added. * platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png: Added. * platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png: Added. * platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png: Added. * platform/chromium/TestExpectations: * platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Added Paths trunk/LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/ trunk/LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/ trunk/LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt trunk/LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/ trunk/LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png trunk/LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (138294 => 138295) --- trunk/LayoutTests/ChangeLog 2012-12-20 21:37:41 UTC (rev 138294) +++ trunk/LayoutTests/ChangeLog 2012-12-20 21:38:30 UTC (rev 138295) @@ -2,6 +2,23 @@ [chromium] Unreviewed gardening. +Rebaseline tests mentioned in 105121 and remove tests that are passing on Win bots according to the flakiness dashboard. + +* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png: Added. +* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png: Added. +* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png: Added. +* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png: Added. +* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png: Added. +* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png: Added. +* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/nested-scrolling-expected.png: Added. +* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png: Added. +* platform/chromium/TestExpectations: +* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Added. + +2012-12-20 Tony Chang
[webkit-changes] [138296] trunk/Source/WebCore
Title: [138296] trunk/Source/WebCore
Revision 138296
Author a...@chromium.org
Date 2012-12-20 13:40:14 -0800 (Thu, 20 Dec 2012)
Log Message
fastAttributeLookupAllowed: classAttr is only animatable by SVG styled elements
https://bugs.webkit.org/show_bug.cgi?id=105565
Reviewed by Eric Seidel.
When it comes to determining if we can use fastGetAttribute we should not penalize
all classAttr access just because some SVG styled elements does funky things with
className.
This makes classAttr considered animatable only for styled SVG elements.
No new tests. No change in behavior.
* bindings/scripts/CodeGenerator.pm:
* dom/Element.cpp:
* svg/SVGElement.cpp:
* svg/SVGElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/svg/SVGElement.cpp
trunk/Source/WebCore/svg/SVGElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138295 => 138296)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 21:38:30 UTC (rev 138295)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 21:40:14 UTC (rev 138296)
@@ -1,3 +1,23 @@
+2012-12-20 Erik Arvidsson a...@chromium.org
+
+fastAttributeLookupAllowed: classAttr is only animatable by SVG styled elements
+https://bugs.webkit.org/show_bug.cgi?id=105565
+
+Reviewed by Eric Seidel.
+
+When it comes to determining if we can use fastGetAttribute we should not penalize
+all classAttr access just because some SVG styled elements does funky things with
+className.
+
+This makes classAttr considered animatable only for styled SVG elements.
+
+No new tests. No change in behavior.
+
+* bindings/scripts/CodeGenerator.pm:
+* dom/Element.cpp:
+* svg/SVGElement.cpp:
+* svg/SVGElement.h:
+
2012-12-20 Huang Dongsung luxte...@company100.net
[TexMap] Remove ParentChange in TextureMapperLayer.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (138295 => 138296)
--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-12-20 21:38:30 UTC (rev 138295)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-12-20 21:40:14 UTC (rev 138296)
@@ -567,14 +567,11 @@
sub CanUseFastAttribute
{
-my ($generator, $attribute, $contentAttributeName) = @_;
+my ($generator, $attribute) = @_;
my $attributeType = $attribute-signature-type;
# HTMLNames::styleAttr cannot be used with fast{Get,Has}Attribute but we do not [Reflect] the
# style attribute.
-# Unfortunately SVG makes class animatable.
-return 0 if $contentAttributeName eq WebCore::HTMLNames::classAttr;
-
return !$generator-IsSVGAnimatedType($attributeType);
}
@@ -593,7 +590,7 @@
$functionName = getURLAttribute;
} elsif ($attribute-signature-type eq boolean) {
my $namespace = $generator-NamespaceForAttributeName($interfaceName, $contentAttributeName);
-if ($generator-CanUseFastAttribute($attribute, $contentAttributeName)) {
+if ($generator-CanUseFastAttribute($attribute)) {
$functionName = fastHasAttribute;
} else {
$functionName = hasAttribute;
@@ -603,7 +600,7 @@
} elsif ($attribute-signature-type eq unsigned long) {
$functionName = getUnsignedIntegralAttribute;
} else {
-if ($generator-CanUseFastAttribute($attribute, $contentAttributeName)) {
+if ($generator-CanUseFastAttribute($attribute)) {
$functionName = fastGetAttribute;
} else {
$functionName = getAttribute;
Modified: trunk/Source/WebCore/dom/Element.cpp (138295 => 138296)
--- trunk/Source/WebCore/dom/Element.cpp 2012-12-20 21:38:30 UTC (rev 138295)
+++ trunk/Source/WebCore/dom/Element.cpp 2012-12-20 21:40:14 UTC (rev 138296)
@@ -2443,7 +2443,7 @@
#if ENABLE(SVG)
if (isSVGElement())
-return !SVGElement::isAnimatableAttribute(name);
+return !static_castconst SVGElement*(this)-isAnimatableAttribute(name);
#endif
return true;
Modified: trunk/Source/WebCore/svg/SVGElement.cpp (138295 => 138296)
--- trunk/Source/WebCore/svg/SVGElement.cpp 2012-12-20 21:38:30 UTC (rev 138295)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2012-12-20 21:40:14 UTC (rev 138296)
@@ -646,12 +646,11 @@
}
#ifndef NDEBUG
-bool SVGElement::isAnimatableAttribute(const QualifiedName name)
+bool SVGElement::isAnimatableAttribute(const QualifiedName name) const
{
DEFINE_STATIC_LOCAL(HashSetQualifiedName, animatableAttributes, ());
if (animatableAttributes.isEmpty()) {
-animatableAttributes.add(classAttr);
animatableAttributes.add(XLinkNames::hrefAttr);
animatableAttributes.add(SVGNames::amplitudeAttr);
animatableAttributes.add(SVGNames::azimuthAttr);
@@ -746,6 +745,10 @@
animatableAttributes.add(SVGNames::yChannelSelectorAttr);
animatableAttributes.add(SVGNames::zAttr);
}
+
+if
[webkit-changes] [138297] trunk/Source/WebCore
Title: [138297] trunk/Source/WebCore
Revision 138297
Author a...@chromium.org
Date 2012-12-20 13:59:29 -0800 (Thu, 20 Dec 2012)
Log Message
CodeGen: Make [Reflect] use getIdAttribute and getNameAttribute
https://bugs.webkit.org/show_bug.cgi?id=105549
Reviewed by Andreas Kling.
Let the codegen use getIdAttribute and getNameAttribute when we know the attribute
is HTMLNames::idAttr or HTMLNames::nameAttr respectively. The more specialized functions
do not search for the attribute if it knows that the element does not have that attribute
speeding up the case where id or name are not present.
This improves Dromaeo/dom-attr by 5% and Bindings/undefined-id-getter by 2%
No new tests. No change in behavior
* bindings/scripts/CodeGenerator.pm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
Diff
Modified: trunk/Source/WebCore/ChangeLog (138296 => 138297)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 21:40:14 UTC (rev 138296)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 21:59:29 UTC (rev 138297)
@@ -1,5 +1,23 @@
2012-12-20 Erik Arvidsson a...@chromium.org
+CodeGen: Make [Reflect] use getIdAttribute and getNameAttribute
+https://bugs.webkit.org/show_bug.cgi?id=105549
+
+Reviewed by Andreas Kling.
+
+Let the codegen use getIdAttribute and getNameAttribute when we know the attribute
+is HTMLNames::idAttr or HTMLNames::nameAttr respectively. The more specialized functions
+do not search for the attribute if it knows that the element does not have that attribute
+speeding up the case where id or name are not present.
+
+This improves Dromaeo/dom-attr by 5% and Bindings/undefined-id-getter by 2%
+
+No new tests. No change in behavior
+
+* bindings/scripts/CodeGenerator.pm:
+
+2012-12-20 Erik Arvidsson a...@chromium.org
+
fastAttributeLookupAllowed: classAttr is only animatable by SVG styled elements
https://bugs.webkit.org/show_bug.cgi?id=105565
Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (138296 => 138297)
--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-12-20 21:40:14 UTC (rev 138296)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-12-20 21:59:29 UTC (rev 138297)
@@ -600,7 +600,13 @@
} elsif ($attribute-signature-type eq unsigned long) {
$functionName = getUnsignedIntegralAttribute;
} else {
-if ($generator-CanUseFastAttribute($attribute)) {
+if ($contentAttributeName eq WebCore::HTMLNames::idAttr) {
+$functionName = getIdAttribute;
+$contentAttributeName = ;
+} elsif ($contentAttributeName eq WebCore::HTMLNames::nameAttr) {
+$functionName = getNameAttribute;
+$contentAttributeName = ;
+} elsif ($generator-CanUseFastAttribute($attribute)) {
$functionName = fastGetAttribute;
} else {
$functionName = getAttribute;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138298] trunk
Title: [138298] trunk
Revision 138298
Author commit-qu...@webkit.org
Date 2012-12-20 14:12:40 -0800 (Thu, 20 Dec 2012)
Log Message
window.crypto.getRandomValues should return the input ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=104845
Source/WebCore:
The W3C Web Crypto API FPWD, as well as the WHATWG February 2012 draft,
define crypto.getRandomValues() as returning the input ArrayBufferView,
to allow function call chaining. Update the implementation to match
the current spec, rather than the old spec of void/undefined.
Patch by Ryan Sleevi rsle...@chromium.org on 2012-12-20
Reviewed by Kentaro Hara.
Test: security/crypto-random-values-types.html
* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCryptoCustom.cpp: Added.
(WebCore):
(WebCore::JSCrypto::getRandomValues):
Added custom getRandomValues implementation so that the input wrapped
ArrayBufferView can be returned directly to the caller. This is to
preserve the underlying type and indexing accessor for the TypedArray
subclass.
* bindings/v8/custom/V8CryptoCustom.cpp: Added.
(WebCore):
(WebCore::V8Crypto::getRandomValuesCallback):
Added custom getRandomValues implementation so that the input wrapped
ArrayBufferView can be returned directly to the caller. This is to
preserve the underlying type and indexing accessor for the TypedArray
subclass.
* page/Crypto.idl:
LayoutTests:
Patch by Ryan Sleevi rsle...@chromium.org on 2012-12-20
Reviewed by Kentaro Hara.
* fast/js/resources/js-test-pre.js:
(shouldBeType):
Added helper to assert that an _expression_ returns an object of the
correct type.
* security/crypto-random-values-types-expected.txt:
* security/crypto-random-values-types.html:
Test all possible TypedArray integer types and ensure that both the
correct TypedArray type is returned and that it is equal to the input
type; that is, that the input type is modified in place, rather then
copied.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/resources/js-test-pre.js
trunk/LayoutTests/security/crypto-random-values-types-expected.txt
trunk/LayoutTests/security/crypto-random-values-types.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/UseJSC.cmake
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/page/Crypto.idl
Added Paths
trunk/Source/WebCore/bindings/js/JSCryptoCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8CryptoCustom.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (138297 => 138298)
--- trunk/LayoutTests/ChangeLog 2012-12-20 21:59:29 UTC (rev 138297)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 22:12:40 UTC (rev 138298)
@@ -1,3 +1,21 @@
+2012-12-20 Ryan Sleevi rsle...@chromium.org
+
+window.crypto.getRandomValues should return the input ArrayBufferView
+https://bugs.webkit.org/show_bug.cgi?id=104845
+
+Reviewed by Kentaro Hara.
+
+* fast/js/resources/js-test-pre.js:
+(shouldBeType):
+Added helper to assert that an _expression_ returns an object of the
+correct type.
+* security/crypto-random-values-types-expected.txt:
+* security/crypto-random-values-types.html:
+Test all possible TypedArray integer types and ensure that both the
+correct TypedArray type is returned and that it is equal to the input
+type; that is, that the input type is modified in place, rather then
+copied.
+
2012-12-20 Tony Chang t...@chromium.org
[chromium] Unreviewed gardening.
Modified: trunk/LayoutTests/fast/js/resources/js-test-pre.js (138297 => 138298)
--- trunk/LayoutTests/fast/js/resources/js-test-pre.js 2012-12-20 21:59:29 UTC (rev 138297)
+++ trunk/LayoutTests/fast/js/resources/js-test-pre.js 2012-12-20 22:12:40 UTC (rev 138298)
@@ -188,6 +188,23 @@
testFailed(_a + should be + _bv + (of type + typeof _bv + ). Was + _av + (of type + typeof _av + ).);
}
+function shouldBeType(_a, _type) {
+ var exception;
+ var _av;
+ try {
+_av = eval(_a);
+ } catch (e) {
+exception = e;
+ }
+
+ var _typev = eval(_type);
+ if (_av instanceof _typev) {
+testPassed(_a + is an instance of + _type);
+ } else {
+testFailed(_a + is not an instance of + _type);
+ }
+}
+
// Variant of shouldBe()--confirms that result of eval(_to_eval) is within
// numeric _tolerance of numeric _target.
function shouldBeCloseTo(_to_eval, _target, _tolerance, quiet)
Modified: trunk/LayoutTests/security/crypto-random-values-types-expected.txt (138297 => 138298)
--- trunk/LayoutTests/security/crypto-random-values-types-expected.txt 2012-12-20 21:59:29 UTC (rev 138297)
+++ trunk/LayoutTests/security/crypto-random-values-types-expected.txt 2012-12-20 22:12:40 UTC (rev 138298)
@@
[webkit-changes] [138299] trunk/Source/WebCore
Title: [138299] trunk/Source/WebCore
Revision 138299
Author an...@apple.com
Date 2012-12-20 14:13:16 -0800 (Thu, 20 Dec 2012)
Log Message
Font description not synchronized correctly on orientation affecting property changes
https://bugs.webkit.org/show_bug.cgi?id=105533
Reviewed by Enrica Casucci.
In StyleResolver checkForOrientationChange() function checks if the new computed orientation differs from the parent
orientation and updates the style's font description only if it does. This is not correct as equal values do not guarantee
the new font description is actually up to date. We can leave the function with the computed orientation and the font
description still out of sync.
Fix by bailing out fast only if the font description is already in sync.
No layout test yet, verified with a test app.
* css/StyleResolver.cpp:
(WebCore::checkForOrientationChange):
(WebCore::StyleResolver::updateFont):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138298 => 138299)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 22:12:40 UTC (rev 138298)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 22:13:16 UTC (rev 138299)
@@ -1,3 +1,23 @@
+2012-12-20 Antti Koivisto an...@apple.com
+
+Font description not synchronized correctly on orientation affecting property changes
+https://bugs.webkit.org/show_bug.cgi?id=105533
+
+Reviewed by Enrica Casucci.
+
+In StyleResolver checkForOrientationChange() function checks if the new computed orientation differs from the parent
+orientation and updates the style's font description only if it does. This is not correct as equal values do not guarantee
+the new font description is actually up to date. We can leave the function with the computed orientation and the font
+description still out of sync.
+
+Fix by bailing out fast only if the font description is already in sync.
+
+No layout test yet, verified with a test app.
+
+* css/StyleResolver.cpp:
+(WebCore::checkForOrientationChange):
+(WebCore::StyleResolver::updateFont):
+
2012-12-20 Ryan Sleevi rsle...@chromium.org
window.crypto.getRandomValues should return the input ArrayBufferView
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (138298 => 138299)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2012-12-20 22:12:40 UTC (rev 138298)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-12-20 22:13:16 UTC (rev 138299)
@@ -2151,23 +2151,19 @@
return false;
}
-static void checkForOrientationChange(RenderStyle* style, const RenderStyle* parentStyle)
+static void checkForOrientationChange(RenderStyle* style)
{
-FontOrientation childFontOrientation;
-NonCJKGlyphOrientation childGlyphOrientation;
-getFontAndGlyphOrientation(style, childFontOrientation, childGlyphOrientation);
+FontOrientation fontOrientation;
+NonCJKGlyphOrientation glyphOrientation;
+getFontAndGlyphOrientation(style, fontOrientation, glyphOrientation);
-FontOrientation parentFontOrientation;
-NonCJKGlyphOrientation parentGlyphOrientation;
-getFontAndGlyphOrientation(parentStyle, parentFontOrientation, parentGlyphOrientation);
-
-if (childFontOrientation == parentFontOrientation childGlyphOrientation == parentGlyphOrientation)
+const FontDescription fontDescription = style-fontDescription();
+if (fontDescription.orientation() == fontOrientation fontDescription.nonCJKGlyphOrientation() == glyphOrientation)
return;
-const FontDescription childFont = style-fontDescription();
-FontDescription newFontDescription(childFont);
-newFontDescription.setNonCJKGlyphOrientation(childGlyphOrientation);
-newFontDescription.setOrientation(childFontOrientation);
+FontDescription newFontDescription(fontDescription);
+newFontDescription.setNonCJKGlyphOrientation(glyphOrientation);
+newFontDescription.setOrientation(fontOrientation);
style-setFontDescription(newFontDescription);
}
@@ -2179,7 +2175,7 @@
checkForTextSizeAdjust();
checkForGenericFamilyChange(style(), m_parentStyle);
checkForZoomChange(style(), m_parentStyle);
-checkForOrientationChange(style(), m_parentStyle);
+checkForOrientationChange(style());
m_style-font().update(m_fontSelector);
m_fontDirty = false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138300] trunk/Source/JavaScriptCore
Title: [138300] trunk/Source/_javascript_Core Revision 138300 Author fpi...@apple.com Date 2012-12-20 14:17:05 -0800 (Thu, 20 Dec 2012) Log Message DFG shouldn't emit CheckStructure on array accesses if exit profiling tells it not to https://bugs.webkit.org/show_bug.cgi?id=105577 Reviewed by Mark Hahnenberg. I don't know why this wasn't there from the beginning. * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (138299 => 138300) --- trunk/Source/_javascript_Core/ChangeLog 2012-12-20 22:13:16 UTC (rev 138299) +++ trunk/Source/_javascript_Core/ChangeLog 2012-12-20 22:17:05 UTC (rev 138300) @@ -1,3 +1,15 @@ +2012-12-20 Filip Pizlo fpi...@apple.com + +DFG shouldn't emit CheckStructure on array accesses if exit profiling tells it not to +https://bugs.webkit.org/show_bug.cgi?id=105577 + +Reviewed by Mark Hahnenberg. + +I don't know why this wasn't there from the beginning. + +* dfg/DFGByteCodeParser.cpp: +(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks): + 2012-12-19 Filip Pizlo fpi...@apple.com DFG speculation checks that take JumpList should consolidate OSRExits Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (138299 => 138300) --- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2012-12-20 22:13:16 UTC (rev 138299) +++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2012-12-20 22:17:05 UTC (rev 138300) @@ -944,7 +944,9 @@ ArrayMode result = ArrayMode::fromObserved(profile, action, makeSafe); -if (profile-hasDefiniteStructure() result.benefitsFromStructureCheck()) +if (profile-hasDefiniteStructure() + result.benefitsFromStructureCheck() + !m_inlineStackTop-m_exitProfile.hasExitSite(m_currentIndex, BadCache)) addToGraph(CheckStructure, OpInfo(m_graph.addStructureSet(profile-expectedStructure())), base); return result; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138301] trunk/Source/WebKit2
Title: [138301] trunk/Source/WebKit2
Revision 138301
Author beid...@apple.com
Date 2012-12-20 14:20:31 -0800 (Thu, 20 Dec 2012)
Log Message
[GTK] Remove the --enable-unstable-features configuration option
https://bugs.webkit.org/show_bug.cgi?id=105327
Patch by Zan Dobersek zandober...@gmail.com on 2012-12-20
Reviewed by Martin Robinson.
Remove the unnecessary feature_defines_unstable variable.
Remove the unstable-features configuration option.
* configure.ac:
* GNUmakefile.am:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.messages.in
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h
trunk/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (138300 => 138301)
--- trunk/Source/WebKit2/ChangeLog 2012-12-20 22:17:05 UTC (rev 138300)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-20 22:20:31 UTC (rev 138301)
@@ -1,3 +1,28 @@
+2012-12-20 Brady Eidson beid...@apple.com
+
+NetworkProcess has no need for suspend/resumePendingRequests.
+rdar://problem/12866005 and https://bugs.webkit.org/show_bug.cgi?id=105550
+
+Reviewed by Alexey Proskuryakov.
+
+suspend/resumePendingRequests were important in a single-process, WebKit1 API world to help prevent
+client callbacks from occurring during layout/painting.
+
+In a WebKit2 + NetworkProcess world, they aren't important.
+
+Remove the Web-Network process messages:
+* NetworkProcess/NetworkConnectionToWebProcess.cpp:
+* NetworkProcess/NetworkConnectionToWebProcess.h:
+* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
+* NetworkProcess/NetworkResourceLoadScheduler.cpp:
+* NetworkProcess/NetworkResourceLoadScheduler.h:
+
+For now, still keep the per-WebProcess count to help keep servePendingRequest working as WebCore intends:
+* WebProcess/Network/WebResourceLoadScheduler.cpp:
+(WebKit::WebResourceLoadScheduler::servePendingRequests):
+(WebKit::WebResourceLoadScheduler::suspendPendingRequests):
+(WebKit::WebResourceLoadScheduler::resumePendingRequests):
+
2012-12-20 Carlos Garcia Campos cgar...@igalia.com
[GTK] Add API to set a TLS errors policy to WebKit2 GTK+ API
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp (138300 => 138301)
--- trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp 2012-12-20 22:17:05 UTC (rev 138300)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp 2012-12-20 22:20:31 UTC (rev 138301)
@@ -139,16 +139,6 @@
NetworkProcess::shared().networkResourceLoadScheduler().servePendingRequests(static_castResourceLoadPriority(resourceLoadPriority));
}
-void NetworkConnectionToWebProcess::suspendPendingRequests()
-{
-NetworkProcess::shared().networkResourceLoadScheduler().suspendPendingRequests();
-}
-
-void NetworkConnectionToWebProcess::resumePendingRequests()
-{
-NetworkProcess::shared().networkResourceLoadScheduler().resumePendingRequests();
-}
-
void NetworkConnectionToWebProcess::setSerialLoadingEnabled(bool enabled)
{
m_serialLoadingEnabled = enabled;
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h (138300 => 138301)
--- trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h 2012-12-20 22:17:05 UTC (rev 138300)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h 2012-12-20 22:20:31 UTC (rev 138301)
@@ -83,8 +83,6 @@
void removeLoadIdentifier(ResourceLoadIdentifier);
void crossOriginRedirectReceived(ResourceLoadIdentifier, const WebCore::KURL redirectURL);
void servePendingRequests(uint32_t resourceLoadPriority);
-void suspendPendingRequests();
-void resumePendingRequests();
void setSerialLoadingEnabled(bool);
void startDownload(bool privateBrowsingEnabled, uint64_t downloadID, const WebCore::ResourceRequest);
void cookiesForDOM(bool privateBrowsingEnabled, const WebCore::KURL firstParty, const WebCore::KURL, String result);
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.messages.in (138300 => 138301)
--- trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.messages.in 2012-12-20 22:17:05 UTC (rev 138300)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.messages.in 2012-12-20 22:20:31 UTC (rev 138301)
@@ -33,9 +33,6 @@
RemoveLoadIdentifier(uint64_t resourceLoadIdentifier)
ServePendingRequests(uint32_t resourceLoadPriority)
-
-SuspendPendingRequests() - ()
-ResumePendingRequests() - ()
SetSerialLoadingEnabled(bool enabled) - ()
Modified:
[webkit-changes] [138303] trunk
Title: [138303] trunk
Revision 138303
Author rn...@webkit.org
Date 2012-12-20 14:38:43 -0800 (Thu, 20 Dec 2012)
Log Message
REGRESSION(r133820?): SimplifyMarkupTest API test asserts
https://bugs.webkit.org/show_bug.cgi?id=105370
Reviewed by Simon Fraser.
Source/WebCore:
The bug was caused by SimplifyMarkupCommand::doApply calling removeNodePreservingChildren on nodes
that have already been removed. We normally check this condition in pruneSubsequentAncestorsToRemove
but we weren't checking it when there were no ancestor to remove because we early exited in that case.
Fixed the bug by doing the early exit for when the node's parent had already been removed first.
Test: TestWebKitAPI/Tests/mac/SimplifyMarkup.mm
* editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove): Also removed an unused variable
nodeAfterHighestAncestorToRemove.
Tools:
Re-enable the test.
* TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/SimplifyMarkupCommand.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/mac/SimplifyMarkup.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (138302 => 138303)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 22:35:20 UTC (rev 138302)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 22:38:43 UTC (rev 138303)
@@ -1,3 +1,23 @@
+2012-12-20 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION(r133820?): SimplifyMarkupTest API test asserts
+https://bugs.webkit.org/show_bug.cgi?id=105370
+
+Reviewed by Simon Fraser.
+
+The bug was caused by SimplifyMarkupCommand::doApply calling removeNodePreservingChildren on nodes
+that have already been removed. We normally check this condition in pruneSubsequentAncestorsToRemove
+but we weren't checking it when there were no ancestor to remove because we early exited in that case.
+
+Fixed the bug by doing the early exit for when the node's parent had already been removed first.
+
+Test: TestWebKitAPI/Tests/mac/SimplifyMarkup.mm
+
+* editing/SimplifyMarkupCommand.cpp:
+(WebCore::SimplifyMarkupCommand::doApply):
+(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove): Also removed an unused variable
+nodeAfterHighestAncestorToRemove.
+
2012-12-20 Antti Koivisto an...@apple.com
Font description not synchronized correctly on orientation affecting property changes
Modified: trunk/Source/WebCore/editing/SimplifyMarkupCommand.cpp (138302 => 138303)
--- trunk/Source/WebCore/editing/SimplifyMarkupCommand.cpp 2012-12-20 22:35:20 UTC (rev 138302)
+++ trunk/Source/WebCore/editing/SimplifyMarkupCommand.cpp 2012-12-20 22:38:43 UTC (rev 138303)
@@ -105,15 +105,13 @@
ASSERT(nodesToRemove[pastLastNodeToRemove]-firstChild() == nodesToRemove[pastLastNodeToRemove]-lastChild());
}
-if (pastLastNodeToRemove == startNodeIndex + 1)
-return 0;
-
Node* highestAncestorToRemove = nodesToRemove[pastLastNodeToRemove - 1].get();
-
-RefPtrNode nodeAfterHighestAncestorToRemove = highestAncestorToRemove-nextSibling();
RefPtrContainerNode parent = highestAncestorToRemove-parentNode();
if (!parent) // Parent has already been removed.
return -1;
+
+if (pastLastNodeToRemove == startNodeIndex + 1)
+return 0;
removeNode(nodesToRemove[startNodeIndex], AssumeContentIsAlwaysEditable);
insertNodeBefore(nodesToRemove[startNodeIndex], highestAncestorToRemove, AssumeContentIsAlwaysEditable);
Modified: trunk/Tools/ChangeLog (138302 => 138303)
--- trunk/Tools/ChangeLog 2012-12-20 22:35:20 UTC (rev 138302)
+++ trunk/Tools/ChangeLog 2012-12-20 22:38:43 UTC (rev 138303)
@@ -1,3 +1,15 @@
+2012-12-20 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION(r133820?): SimplifyMarkupTest API test asserts
+https://bugs.webkit.org/show_bug.cgi?id=105370
+
+Reviewed by Simon Fraser.
+
+Re-enable the test.
+
+* TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
+(TestWebKitAPI::TEST):
+
2012-12-20 Nico Weber tha...@chromium.org
chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/SimplifyMarkup.mm (138302 => 138303)
--- trunk/Tools/TestWebKitAPI/Tests/mac/SimplifyMarkup.mm 2012-12-20 22:35:20 UTC (rev 138302)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/SimplifyMarkup.mm 2012-12-20 22:38:43 UTC (rev 138303)
@@ -47,7 +47,7 @@
namespace TestWebKitAPI {
-TEST(WebKit1, DISABLED_SimplifyMarkupTest)
+TEST(WebKit1, SimplifyMarkupTest)
{
RetainPtrWebView webView1(AdoptNS, [[WebView alloc] initWithFrame:NSMakeRect(0, 0, 120, 200) frameName:nil groupName:nil]);
RetainPtrWebView webView2(AdoptNS, [[WebView alloc] initWithFrame:NSMakeRect(0, 0, 120, 200) frameName:nil groupName:nil]);
[webkit-changes] [138304] trunk/LayoutTests
Title: [138304] trunk/LayoutTests Revision 138304 Author rn...@webkit.org Date 2012-12-20 14:50:57 -0800 (Thu, 20 Dec 2012) Log Message Add a Mac test expectation per bug 105580. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138303 => 138304) --- trunk/LayoutTests/ChangeLog 2012-12-20 22:38:43 UTC (rev 138303) +++ trunk/LayoutTests/ChangeLog 2012-12-20 22:50:57 UTC (rev 138304) @@ -1,3 +1,9 @@ +2012-12-20 Ryosuke Niwa rn...@webkit.org + +Add a Mac test expectation per bug 105580. + +* platform/mac/TestExpectations: + 2012-12-20 Ryan Sleevi rsle...@chromium.org window.crypto.getRandomValues should return the input ArrayBufferView Modified: trunk/LayoutTests/platform/mac/TestExpectations (138303 => 138304) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 22:38:43 UTC (rev 138303) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 22:50:57 UTC (rev 138304) @@ -1264,6 +1264,8 @@ webkit.org/b/105049 compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html [ Failure ] webkit.org/b/105566 media/track/track-webvtt-tc006-cue-identifiers.html [ Crash Pass ] +webkit.org/b/105580 media/track/track-prefer-captions.html [ Crash Pass ] + webkit.org/b/105567 http/tests/security/data-url-inline.css.html [ Crash Pass ] webkit.org/b/104848 fast/frames/sandboxed-iframe-attribute-parsing.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138305] trunk/Tools
Title: [138305] trunk/Tools
Revision 138305
Author ander...@apple.com
Date 2012-12-20 15:06:46 -0800 (Thu, 20 Dec 2012)
Log Message
Don't include WebKit2 headers when building TestWebKitAPI on windows
https://bugs.webkit.org/show_bug.cgi?id=105582
Reviewed by Tim Horton.
* TestWebKitAPI/config.h:
* TestWebKitAPI/win/main.cpp:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/config.h
trunk/Tools/TestWebKitAPI/win/main.cpp
Diff
Modified: trunk/Tools/ChangeLog (138304 => 138305)
--- trunk/Tools/ChangeLog 2012-12-20 22:50:57 UTC (rev 138304)
+++ trunk/Tools/ChangeLog 2012-12-20 23:06:46 UTC (rev 138305)
@@ -1,3 +1,13 @@
+2012-12-20 Anders Carlsson ander...@apple.com
+
+Don't include WebKit2 headers when building TestWebKitAPI on windows
+https://bugs.webkit.org/show_bug.cgi?id=105582
+
+Reviewed by Tim Horton.
+
+* TestWebKitAPI/config.h:
+* TestWebKitAPI/win/main.cpp:
+
2012-12-20 Ryosuke Niwa rn...@webkit.org
REGRESSION(r133820?): SimplifyMarkupTest API test asserts
Modified: trunk/Tools/TestWebKitAPI/config.h (138304 => 138305)
--- trunk/Tools/TestWebKitAPI/config.h 2012-12-20 22:50:57 UTC (rev 138304)
+++ trunk/Tools/TestWebKitAPI/config.h 2012-12-20 23:06:46 UTC (rev 138305)
@@ -64,7 +64,7 @@
#include stdint.h
-#if !PLATFORM(CHROMIUM) || (PLATFORM(GTK) defined(BUILDING_WEBKIT2__))
+#if (!PLATFORM(CHROMIUM) !PLATFORM(WIN)) || (PLATFORM(GTK) defined(BUILDING_WEBKIT2__))
#include WebKit2/WebKit2_C.h
#endif
Modified: trunk/Tools/TestWebKitAPI/win/main.cpp (138304 => 138305)
--- trunk/Tools/TestWebKitAPI/win/main.cpp 2012-12-20 22:50:57 UTC (rev 138304)
+++ trunk/Tools/TestWebKitAPI/win/main.cpp 2012-12-20 23:06:46 UTC (rev 138305)
@@ -25,6 +25,7 @@
#include config.h
#include TestsController.h
+#include windows.h
int main(int argc, char** argv)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138306] trunk/Source/WebKit2
Title: [138306] trunk/Source/WebKit2
Revision 138306
Author a...@apple.com
Date 2012-12-20 15:10:36 -0800 (Thu, 20 Dec 2012)
Log Message
LocalTerminationDisabler is not needed in WebCookieManager.cpp
https://bugs.webkit.org/show_bug.cgi?id=105581
Reviewed by Anders Carlsson.
All WebCookieManager functions are synchronous, and all LocalTerminationDisabler does
is enable/disable a timer that cannot fire inside the function anyway.
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Cookies/WebCookieManager.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (138305 => 138306)
--- trunk/Source/WebKit2/ChangeLog 2012-12-20 23:06:46 UTC (rev 138305)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-20 23:10:36 UTC (rev 138306)
@@ -1,3 +1,21 @@
+2012-12-20 Alexey Proskuryakov a...@apple.com
+
+LocalTerminationDisabler is not needed in WebCookieManager.cpp
+https://bugs.webkit.org/show_bug.cgi?id=105581
+
+Reviewed by Anders Carlsson.
+
+All WebCookieManager functions are synchronous, and all LocalTerminationDisabler does
+is enable/disable a timer that cannot fire inside the function anyway.
+
+* WebProcess/Cookies/WebCookieManager.cpp:
+(WebKit::WebCookieManager::getHostnamesWithCookies):
+(WebKit::WebCookieManager::deleteCookiesForHostname):
+(WebKit::WebCookieManager::deleteAllCookies):
+(WebKit::WebCookieManager::startObservingCookieChanges):
+(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
+(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
+
2012-12-20 Brady Eidson beid...@apple.com
NetworkProcess has no need for suspend/resumePendingRequests.
Modified: trunk/Source/WebKit2/WebProcess/Cookies/WebCookieManager.cpp (138305 => 138306)
--- trunk/Source/WebKit2/WebProcess/Cookies/WebCookieManager.cpp 2012-12-20 23:06:46 UTC (rev 138305)
+++ trunk/Source/WebKit2/WebProcess/Cookies/WebCookieManager.cpp 2012-12-20 23:10:36 UTC (rev 138306)
@@ -53,8 +53,6 @@
void WebCookieManager::getHostnamesWithCookies(uint64_t callbackID)
{
-WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
-
HashSetString hostnames;
WebCore::getHostnamesWithCookies(0, hostnames);
@@ -67,22 +65,16 @@
void WebCookieManager::deleteCookiesForHostname(const String hostname)
{
-WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
-
WebCore::deleteCookiesForHostname(0, hostname);
}
void WebCookieManager::deleteAllCookies()
{
-WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
-
WebCore::deleteAllCookies(0);
}
void WebCookieManager::startObservingCookieChanges()
{
-WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
-
WebCore::startObservingCookieChanges();
}
@@ -98,13 +90,11 @@
void WebCookieManager::setHTTPCookieAcceptPolicy(HTTPCookieAcceptPolicy policy)
{
-WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
platformSetHTTPCookieAcceptPolicy(policy);
}
void WebCookieManager::getHTTPCookieAcceptPolicy(uint64_t callbackID)
{
-WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
WebProcess::shared().connection()-send(Messages::WebCookieManagerProxy::DidGetHTTPCookieAcceptPolicy(platformGetHTTPCookieAcceptPolicy(), callbackID), 0);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138307] trunk/LayoutTests
Title: [138307] trunk/LayoutTests Revision 138307 Author rn...@webkit.org Date 2012-12-20 15:20:13 -0800 (Thu, 20 Dec 2012) Log Message Add a Mac test expectation per bug 105584. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138306 => 138307) --- trunk/LayoutTests/ChangeLog 2012-12-20 23:10:36 UTC (rev 138306) +++ trunk/LayoutTests/ChangeLog 2012-12-20 23:20:13 UTC (rev 138307) @@ -1,5 +1,11 @@ 2012-12-20 Ryosuke Niwa rn...@webkit.org +Add a Mac test expectation per bug 105584. + +* platform/mac/TestExpectations: + +2012-12-20 Ryosuke Niwa rn...@webkit.org + Add a Mac test expectation per bug 105580. * platform/mac/TestExpectations: Modified: trunk/LayoutTests/platform/mac/TestExpectations (138306 => 138307) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 23:10:36 UTC (rev 138306) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 23:20:13 UTC (rev 138307) @@ -1265,6 +1265,7 @@ webkit.org/b/105566 media/track/track-webvtt-tc006-cue-identifiers.html [ Crash Pass ] webkit.org/b/105580 media/track/track-prefer-captions.html [ Crash Pass ] +webkit.org/b/105584 media/video-controls-captions-trackmenu.html [ Failure Pass ] webkit.org/b/105567 http/tests/security/data-url-inline.css.html [ Crash Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138308] trunk/Source/JavaScriptCore
Title: [138308] trunk/Source/_javascript_Core
Revision 138308
Author msab...@apple.com
Date 2012-12-20 15:20:30 -0800 (Thu, 20 Dec 2012)
Log Message
JIT: Change uninitialized pointer value -1 to constant
https://bugs.webkit.org/show_bug.cgi?id=105576
Rubber stamped by Gavin Barraclough.
Changed the use of -1 as a pointer value in the JITs to be the constant unusedPointer defined in the
new file jit/UnusedPointer.h. Made it's value 0xd1e7beef, which is a bad pointer on most architectures
because it is odd, and to distinguish it from other common values.
* GNUmakefile.list.am:
* _javascript_Core.xcodeproj/project.pbxproj:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
* jit/JITWriteBarrier.h:
(JSC::JITWriteBarrierBase::clearToUnusedPointer):
(JSC::JITWriteBarrierBase::get):
* jit/UnusedPointer.h: Added.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/dfg/DFGRepatch.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp
trunk/Source/_javascript_Core/jit/JITWriteBarrier.h
Added Paths
trunk/Source/_javascript_Core/jit/UnusedPointer.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (138307 => 138308)
--- trunk/Source/_javascript_Core/ChangeLog 2012-12-20 23:20:13 UTC (rev 138307)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-12-20 23:20:30 UTC (rev 138308)
@@ -1,3 +1,37 @@
+2012-12-20 Michael Saboff msab...@apple.com
+
+JIT: Change uninitialized pointer value -1 to constant
+https://bugs.webkit.org/show_bug.cgi?id=105576
+
+Rubber stamped by Gavin Barraclough.
+
+Changed the use of -1 as a pointer value in the JITs to be the constant unusedPointer defined in the
+new file jit/UnusedPointer.h. Made it's value 0xd1e7beef, which is a bad pointer on most architectures
+because it is odd, and to distinguish it from other common values.
+
+* GNUmakefile.list.am:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* dfg/DFGRepatch.cpp:
+(JSC::DFG::dfgResetGetByID):
+(JSC::DFG::dfgResetPutByID):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::cachedGetById):
+(JSC::DFG::SpeculativeJIT::cachedPutById):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::cachedGetById):
+(JSC::DFG::SpeculativeJIT::cachedPutById):
+* jit/JIT.h:
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::resetPatchGetById):
+(JSC::JIT::resetPatchPutById):
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::resetPatchGetById):
+(JSC::JIT::resetPatchPutById):
+* jit/JITWriteBarrier.h:
+(JSC::JITWriteBarrierBase::clearToUnusedPointer):
+(JSC::JITWriteBarrierBase::get):
+* jit/UnusedPointer.h: Added.
+
2012-12-20 Filip Pizlo fpi...@apple.com
DFG shouldn't emit CheckStructure on array accesses if exit profiling tells it not to
Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (138307 => 138308)
--- trunk/Source/_javascript_Core/GNUmakefile.list.am 2012-12-20 23:20:13 UTC (rev 138307)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2012-12-20 23:20:30 UTC (rev 138308)
@@ -438,6 +438,7 @@
Source/_javascript_Core/jit/SpecializedThunkJIT.h \
Source/_javascript_Core/jit/ThunkGenerators.cpp \
Source/_javascript_Core/jit/ThunkGenerators.h \
+ Source/_javascript_Core/jit/UnusedPointer.h \
Source/_javascript_Core/llint/LLIntCommon.h \
Source/_javascript_Core/llint/LLIntCLoop.cpp \
Source/_javascript_Core/llint/LLIntCLoop.h \
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (138307 => 138308)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2012-12-20 23:20:13 UTC (rev 138307)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2012-12-20 23:20:30 UTC (rev 138308)
@@ -1291,6 +1291,7 @@
65621E6B089E859700760F35 /* PropertySlot.cpp */ = {isa = PBXFileReference; fileEncoding = 30; indentWidth = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PropertySlot.cpp; sourceTree = group; tabWidth = 8; };
65621E6C089E859700760F35 /*
[webkit-changes] [138309] trunk/LayoutTests
Title: [138309] trunk/LayoutTests Revision 138309 Author simon.fra...@apple.com Date 2012-12-20 15:37:34 -0800 (Thu, 20 Dec 2012) Log Message Skip tests in WK2 that rely on eventSender.beginDragWithFiles. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138308 => 138309) --- trunk/LayoutTests/ChangeLog 2012-12-20 23:20:30 UTC (rev 138308) +++ trunk/LayoutTests/ChangeLog 2012-12-20 23:37:34 UTC (rev 138309) @@ -1,3 +1,9 @@ +2012-12-20 Simon Fraser simon.fra...@apple.com + +Skip tests in WK2 that rely on eventSender.beginDragWithFiles. + +* platform/mac-wk2/TestExpectations: + 2012-12-20 Ryosuke Niwa rn...@webkit.org Add a Mac test expectation per bug 105584. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (138308 => 138309) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2012-12-20 23:20:30 UTC (rev 138308) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2012-12-20 23:37:34 UTC (rev 138309) @@ -118,6 +118,7 @@ fast/events/mouseup-from-button2.html fast/events/node-event-anchor-lock.html fast/events/ondragenter.html +fast/events/only-valid-drop-targets-receive-file-drop.html fast/events/open-window-from-another-frame.html fast/events/popup-when-select-change.html fast/events/right-click-focus.html @@ -130,6 +131,7 @@ fast/events/wheelevent-direction-inverted-from-device.html fast/forms/drag-into-textarea.html fast/forms/drag-out-of-textarea.html +fast/forms/file/input-file-value.html fast/forms/input-readonly-autoscroll.html fast/forms/input-text-drag-down.html fast/forms/listbox-typeahead-cyrillic.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138310] trunk/LayoutTests
Title: [138310] trunk/LayoutTests
Revision 138310
Author simon.fra...@apple.com
Date 2012-12-20 15:37:41 -0800 (Thu, 20 Dec 2012)
Log Message
Remove an incorrect WK2 result, and two there were identical to the WK1 results.
* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Removed.
* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt
trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (138309 => 138310)
--- trunk/LayoutTests/ChangeLog 2012-12-20 23:37:34 UTC (rev 138309)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 23:37:41 UTC (rev 138310)
@@ -1,5 +1,13 @@
2012-12-20 Simon Fraser simon.fra...@apple.com
+Remove an incorrect WK2 result, and two there were identical to the WK1 results.
+
+* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
+* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Removed.
+* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
+
+2012-12-20 Simon Fraser simon.fra...@apple.com
+
Skip tests in WK2 that rely on eventSender.beginDragWithFiles.
* platform/mac-wk2/TestExpectations:
Deleted: trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt (138309 => 138310)
--- trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt 2012-12-20 23:37:34 UTC (rev 138309)
+++ trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt 2012-12-20 23:37:41 UTC (rev 138310)
@@ -1,47 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x197
- RenderBlock {html} at (0,0) size 800x198
-RenderBody {body} at (5,5) size 790x187
- RenderTable {table} at (142,0) size 505x186
-RenderTableSection (anonymous) at (0,0) size 504x186
- RenderTableRow {tr} at (0,0) size 504x186
-RenderTableCell {td} at (0,0) size 504x186 [r=0 c=0 rs=1 cs=3]
- RenderTable {table} at (7,6) size 492x174
-RenderTableSection (anonymous) at (0,0) size 491x174
- RenderTableRow {tr} at (0,1) size 491x65
-RenderTableCell {td} at (1,1) size 489x66 [r=0 c=0 rs=1 cs=2]
- RenderBlock {h1} at (5,19) size 480x27
-RenderText {#text} at (0,0) size 479x26
- text run at (0,0) width 479: Both sides should have identical size after zooming
- RenderTableRow {tr} at (0,67) size 491x23
-RenderTableCell {td} at (1,67) size 244x23 [r=1 c=0 rs=1 cs=1]
- RenderText {#text} at (95,5) size 54x13
-text run at (95,5) width 54: SVG Image
-RenderTableCell {td} at (246,67) size 244x23 [r=1 c=1 rs=1 cs=1]
- RenderText {#text} at (95,5) size 54x13
-text run at (95,5) width 54: PNG Image
- RenderTableRow {tr} at (0,91) size 491x82
-RenderTableCell {td} at (1,91) size 244x82 [r=2 c=0 rs=1 cs=1]
- RenderEmbeddedObject {object} at (100,5) size 139x70
-layer at (0,0) size 139x69
- RenderView at (0,0) size 139x69
-layer at (0,0) size 139x69
- RenderSVGRoot {svg} at (23,0) size 93x69
-RenderSVGContainer {g} at (28,8) size 73x47
- RenderSVGRect {rect} at (28,8) size 11x17 [stroke={[type=SOLID] [color=#00]}] [x=30.00] [y=46.00] [width=50.00] [height=80.00]
- RenderSVGRect {rect} at (48,8) size 10x17 [fill={[type=SOLID] [color=#FF]}] [x=130.00] [y=46.00] [width=50.00] [height=80.00]
- RenderSVGRect {rect} at (71,8) size 11x17 [stroke={[type=SOLID] [color=#00]}] [x=250.00] [y=46.00] [width=50.00] [height=80.00]
- RenderSVGRect {rect} at (90,8) size 11x17 [fill={[type=SOLID] [color=#FF]}] [x=350.00] [y=46.00] [width=50.00] [height=80.00]
- RenderSVGRect {rect} at (28,37) size 12x18 [stroke={[type=SOLID] [color=#FF] [stroke width=8.00]}] [x=30.00] [y=196.00] [width=50.00] [height=80.00]
-
[webkit-changes] [138311] trunk/Source/WebCore
Title: [138311] trunk/Source/WebCore
Revision 138311
Author commit-qu...@webkit.org
Date 2012-12-20 15:51:39 -0800 (Thu, 20 Dec 2012)
Log Message
Unreviewed, rolling out r138265.
http://trac.webkit.org/changeset/138265
https://bugs.webkit.org/show_bug.cgi?id=105586
Accidentally committed extra code that is not reviewed and
shouldn't go with this commit. (Requested by ostap on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-12-20
* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurface::platformSwapBuffers):
* platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138310 => 138311)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 23:37:41 UTC (rev 138310)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 23:51:39 UTC (rev 138311)
@@ -1,3 +1,21 @@
+2012-12-20 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r138265.
+http://trac.webkit.org/changeset/138265
+https://bugs.webkit.org/show_bug.cgi?id=105586
+
+Accidentally committed extra code that is not reviewed and
+shouldn't go with this commit. (Requested by ostap on
+#webkit).
+
+* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
+(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
+(WebCore::GraphicsSurfacePrivate::createPixmap):
+(GraphicsSurfacePrivate):
+(WebCore::GraphicsSurface::platformSwapBuffers):
+* platform/graphics/texmap/TextureMapperBackingStore.cpp:
+(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
+
2012-12-20 Ryosuke Niwa rn...@webkit.org
REGRESSION(r133820?): SimplifyMarkupTest API test asserts
Modified: trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp (138310 => 138311)
--- trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp 2012-12-20 23:37:41 UTC (rev 138310)
+++ trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp 2012-12-20 23:51:39 UTC (rev 138311)
@@ -168,8 +168,18 @@
GLXFBConfig* fbConfigs = glXChooseFBConfig(m_display, DefaultScreen(m_display), attributes, numReturned);
// Make sure that we choose a configuration that supports an alpha mask.
-m_fbConfig = findFBConfigWithAlpha(fbConfigs, numReturned);
+for (int i = 0; i numReturned; ++i) {
+XVisualInfo* visualInfo = glXGetVisualFromFBConfig(m_display, fbConfigs[i]);
+if (!visualInfo)
+continue;
+XRenderPictFormat* format = XRenderFindVisualFormat(m_display, visualInfo-visual);
+if (format format-direct.alphaMask 0) {
+m_fbConfig = fbConfigs[i];
+break;
+}
+}
+
XFree(fbConfigs);
// Create a GLX context for OpenGL rendering
@@ -245,11 +255,8 @@
int numberOfConfigs;
GLXFBConfig* configs = glXChooseFBConfig(m_display, XDefaultScreen(m_display), glxSpec, numberOfConfigs);
-// If origin window has alpha then try to find config with alpha.
-GLXFBConfig config = m_hasAlpha ? findFBConfigWithAlpha(configs, numberOfConfigs) : configs[0];
-
m_xPixmap = XCompositeNameWindowPixmap(m_display, winId);
-m_glxPixmap = glXCreatePixmap(m_display, config, m_xPixmap, glxAttributes);
+m_glxPixmap = glXCreatePixmap(m_display, *configs, m_xPixmap, glxAttributes);
uint inverted = 0;
glXQueryDrawable(m_display, m_glxPixmap, GLX_Y_INVERTED_EXT, inverted);
@@ -347,26 +354,7 @@
return m_size;
}
-bool isReceiver() const { return m_isReceiver; }
private:
-GLXFBConfig findFBConfigWithAlpha(GLXFBConfig* fbConfigs, int numberOfConfigs)
-{
-for (int i = 0; i numberOfConfigs; ++i) {
-XVisualInfo* visualInfo = glXGetVisualFromFBConfig(m_display, fbConfigs[i]);
-if (!visualInfo)
-continue;
-
-XRenderPictFormat* format = XRenderFindVisualFormat(m_display, visualInfo-visual);
-if (format format-direct.alphaMask 0) {
-return fbConfigs[i];
-break;
-}
-}
-
-// Return 1st config as a fallback.
-return fbConfigs[0];
-}
-
OffScreenRootWindow m_offScreenWindow;
IntSize m_size;
Display* m_display;
@@ -449,14 +437,6 @@
uint32_t GraphicsSurface::platformSwapBuffers()
{
-if (m_private-isReceiver()) {
-glBindTexture(GL_TEXTURE_2D,
[webkit-changes] [138312] trunk
Title: [138312] trunk
Revision 138312
Author e...@chromium.org
Date 2012-12-20 15:54:53 -0800 (Thu, 20 Dec 2012)
Log Message
[flexbox] Fix handling of very large flex grow/shrink values
https://bugs.webkit.org/show_bug.cgi?id=105579
Reviewed by Tony Chang.
Source/WebCore:
Add isfinite to childSize calculation in RenderFlexibleBox::
resolveFlexibleLengths to avoid overflow.
Covered by css3/flexbox/flex-algorithm.html.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
Check if value is finite before adding to childSize.
LayoutTests:
Update expectations for element with very large flex grow value.
* css3/flexbox/flex-algorithm.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/flex-algorithm.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (138311 => 138312)
--- trunk/LayoutTests/ChangeLog 2012-12-20 23:51:39 UTC (rev 138311)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 23:54:53 UTC (rev 138312)
@@ -1,3 +1,14 @@
+2012-12-20 Emil A Eklund e...@chromium.org
+
+[flexbox] Fix handling of very large flex grow/shrink values
+https://bugs.webkit.org/show_bug.cgi?id=105579
+
+Reviewed by Tony Chang.
+
+Update expectations for element with very large flex grow value.
+
+* css3/flexbox/flex-algorithm.html:
+
2012-12-20 Simon Fraser simon.fra...@apple.com
Remove an incorrect WK2 result, and two there were identical to the WK1 results.
Modified: trunk/LayoutTests/css3/flexbox/flex-algorithm.html (138311 => 138312)
--- trunk/LayoutTests/css3/flexbox/flex-algorithm.html 2012-12-20 23:51:39 UTC (rev 138311)
+++ trunk/LayoutTests/css3/flexbox/flex-algorithm.html 2012-12-20 23:54:53 UTC (rev 138312)
@@ -128,7 +128,7 @@
/div
div class=flexbox
- div data-expected-width=0 style=-webkit-flex: 100 0 600px; -moz-flex: 100 0 600px/div
+ div data-expected-width=600 style=-webkit-flex: 100 0 600px; -moz-flex: 100 0 600px/div
div data-expected-width=600 style=-webkit-flex: 0 100 600px; -moz-flex: 0 100 600px/div
div data-expected-width=33554428 style=-webkit-flex: 1 1 100px; -moz-flex: 1 1 100px/div
/div
Modified: trunk/Source/WebCore/ChangeLog (138311 => 138312)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 23:51:39 UTC (rev 138311)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 23:54:53 UTC (rev 138312)
@@ -1,3 +1,19 @@
+2012-12-20 Emil A Eklund e...@chromium.org
+
+[flexbox] Fix handling of very large flex grow/shrink values
+https://bugs.webkit.org/show_bug.cgi?id=105579
+
+Reviewed by Tony Chang.
+
+Add isfinite to childSize calculation in RenderFlexibleBox::
+resolveFlexibleLengths to avoid overflow.
+
+Covered by css3/flexbox/flex-algorithm.html.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
+Check if value is finite before adding to childSize.
+
2012-12-20 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r138265.
Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (138311 => 138312)
--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2012-12-20 23:51:39 UTC (rev 138311)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2012-12-20 23:54:53 UTC (rev 138312)
@@ -968,10 +968,13 @@
else {
LayoutUnit preferredChildSize = preferredMainAxisContentExtentForChild(child);
LayoutUnit childSize = preferredChildSize;
+double extraSpace = 0;
if (availableFreeSpace 0 totalFlexGrow 0 flexSign == PositiveFlexibility isfinite(totalFlexGrow))
-childSize += roundedLayoutUnit(availableFreeSpace * child-style()-flexGrow() / totalFlexGrow);
+extraSpace = availableFreeSpace * child-style()-flexGrow() / totalFlexGrow;
else if (availableFreeSpace 0 totalWeightedFlexShrink 0 flexSign == NegativeFlexibility isfinite(totalWeightedFlexShrink))
-childSize += roundedLayoutUnit(availableFreeSpace * child-style()-flexShrink() * preferredChildSize / totalWeightedFlexShrink);
+extraSpace = availableFreeSpace * child-style()-flexShrink() * preferredChildSize / totalWeightedFlexShrink;
+if (isfinite(extraSpace))
+childSize += roundedLayoutUnit(extraSpace);
LayoutUnit adjustedChildSize = adjustChildSizeForMinAndMax(child, childSize);
childSizes.append(adjustedChildSize);
___
webkit-changes mailing list
[webkit-changes] [138313] trunk
Title: [138313] trunk Revision 138313 Author commit-qu...@webkit.org Date 2012-12-20 15:57:01 -0800 (Thu, 20 Dec 2012) Log Message .: [EFL][WebGL][Wk2] Replace HAVE(GLX) checks with USE(GLX). https://bugs.webkit.org/show_bug.cgi?id=105431 Patch by Kondapally Kalyan kalyan.kondapa...@intel.com on 2012-12-20 Reviewed by Kenneth Rohde Christiansen. This patch changes the check HAVE(GLX) to USE(GLX). This would enable us to choose our preferred GL backend during build time. * Source/cmake/OptionsEfl.cmake: Source/WebCore: [EFL][WebGL][Wk2] Replace HAVE(GLX) checks with USE(GLX) https://bugs.webkit.org/show_bug.cgi?id=105431 Patch by Kondapally Kalyan kalyan.kondapa...@intel.com on 2012-12-20 Reviewed by Kenneth Rohde Christiansen. This patch changes the check HAVE(GLX) to USE(GLX). This would enable us to choose our preferred GL backend during build time. This patch also adds an additional api to query the shared buffer handle. Buffer handle is not same as gl surface and would depend on how the content is backed up. * platform/graphics/opengl/GLDefs.h: (WebCore): * platform/graphics/opengl/GLPlatformContext.cpp: (WebCore::GLPlatformContext::createContext): (WebCore::GLPlatformContext::createOffScreenContext): (WebCore::GLPlatformContext::createCurrentContextWrapper): * platform/graphics/opengl/GLPlatformSurface.cpp: (WebCore::GLPlatformSurface::createOffscreenSurface): (WebCore::GLPlatformSurface::createTransportSurface): (WebCore::GLPlatformSurface::GLPlatformSurface): (WebCore::GLPlatformSurface::handle): (WebCore): (WebCore::GLPlatformSurface::drawable): * platform/graphics/opengl/GLPlatformSurface.h: (GLPlatformSurface): * platform/graphics/surfaces/glx/GLXContext.cpp: * platform/graphics/surfaces/glx/GLXContext.h: * platform/graphics/surfaces/glx/GLXSurface.cpp: (WebCore::GLXTransportSurface::GLXTransportSurface): (WebCore::GLXTransportSurface::destroy): (WebCore::GLXPBuffer::initialize): (WebCore::GLXPBuffer::freeResources): * platform/graphics/surfaces/glx/GLXSurface.h: * platform/graphics/surfaces/glx/GLXWindowResources.h: * platform/graphics/surfaces/glx/X11WindowResources.cpp: (WebCore::X11OffScreenWindow::X11OffScreenWindow): (WebCore::X11OffScreenWindow::setGeometry): (WebCore::X11OffScreenWindow::createOffscreenWindow): (WebCore::X11OffScreenWindow::destroyWindow): * platform/graphics/surfaces/glx/X11WindowResources.h: (WebCore): (DummySharedResources): (WebCore::DummySharedResources::create): (WebCore::DummySharedResources::nativeDisplay): (WebCore::DummySharedResources::pBufferContextConfig): (WebCore::DummySharedResources::surfaceContextConfig): (WebCore::DummySharedResources::DummySharedResources): (WebCore::DummySharedResources::~DummySharedResources): Modified Paths trunk/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/opengl/GLDefs.h trunk/Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp trunk/Source/WebCore/platform/graphics/opengl/GLPlatformSurface.cpp trunk/Source/WebCore/platform/graphics/opengl/GLPlatformSurface.h trunk/Source/WebCore/platform/graphics/surfaces/glx/GLXContext.cpp trunk/Source/WebCore/platform/graphics/surfaces/glx/GLXContext.h trunk/Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.cpp trunk/Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.h trunk/Source/WebCore/platform/graphics/surfaces/glx/GLXWindowResources.h trunk/Source/WebCore/platform/graphics/surfaces/glx/X11WindowResources.cpp trunk/Source/cmake/OptionsEfl.cmake Diff Modified: trunk/ChangeLog (138312 => 138313) --- trunk/ChangeLog 2012-12-20 23:54:53 UTC (rev 138312) +++ trunk/ChangeLog 2012-12-20 23:57:01 UTC (rev 138313) @@ -1,3 +1,15 @@ +2012-12-20 Kondapally Kalyan kalyan.kondapa...@intel.com + +[EFL][WebGL][Wk2] Replace HAVE(GLX) checks with USE(GLX). +https://bugs.webkit.org/show_bug.cgi?id=105431 + +Reviewed by Kenneth Rohde Christiansen. + +This patch changes the check HAVE(GLX) to USE(GLX). +This would enable us to choose our preferred GL backend during build time. + +* Source/cmake/OptionsEfl.cmake: + 2012-12-20 Zan Dobersek zandober...@gmail.com [GTK] Remove the --enable-unstable-features configuration option Modified: trunk/Source/WebCore/ChangeLog (138312 => 138313) --- trunk/Source/WebCore/ChangeLog 2012-12-20 23:54:53 UTC (rev 138312) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 23:57:01 UTC (rev 138313) @@ -1,3 +1,55 @@ +2012-12-20 Kondapally Kalyan kalyan.kondapa...@intel.com + +[EFL][WebGL][Wk2] Replace HAVE(GLX) checks with USE(GLX) +https://bugs.webkit.org/show_bug.cgi?id=105431 + +Reviewed by Kenneth Rohde Christiansen. + +This patch changes the check HAVE(GLX) to USE(GLX). +This would enable us to choose our preferred GL backend during build time. +This patch also adds an additional api to query the shared buffer handle. +Buffer handle is not same as gl surface and would depend
[webkit-changes] [138314] trunk/Tools
Title: [138314] trunk/Tools
Revision 138314
Author dpra...@chromium.org
Date 2012-12-20 16:04:40 -0800 (Thu, 20 Dec 2012)
Log Message
TestExpectation fallback is broken
https://bugs.webkit.org/show_bug.cgi?id=105583
Reviewed by Ryosuke Niwa.
When I added support for the -wk2 in port names, it looks
like I broke the way we computed the list of TestExpectations
files so that the implementation-version directory was left out :(.
Fixed and cleaned up the tests.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.expectations_files):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(TestWebKitPort.__init__):
(PortTestCase.test_skipped_directories_for_symbols):
(test_skipped_directories_for_features):
(test_skipped_directories_for_features_no_matching_tests_in_test_list):
(test_skipped_tests_for_unsupported_features_empty_test_list):
(test_skipped_layout_tests):
(test_expectations_files):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
Diff
Modified: trunk/Tools/ChangeLog (138313 => 138314)
--- trunk/Tools/ChangeLog 2012-12-20 23:57:01 UTC (rev 138313)
+++ trunk/Tools/ChangeLog 2012-12-21 00:04:40 UTC (rev 138314)
@@ -1,3 +1,26 @@
+2012-12-20 Dirk Pranke dpra...@chromium.org
+
+TestExpectation fallback is broken
+https://bugs.webkit.org/show_bug.cgi?id=105583
+
+Reviewed by Ryosuke Niwa.
+
+When I added support for the -wk2 in port names, it looks
+like I broke the way we computed the list of TestExpectations
+files so that the implementation-version directory was left out :(.
+Fixed and cleaned up the tests.
+
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.expectations_files):
+* Scripts/webkitpy/layout_tests/port/port_testcase.py:
+(TestWebKitPort.__init__):
+(PortTestCase.test_skipped_directories_for_symbols):
+(test_skipped_directories_for_features):
+(test_skipped_directories_for_features_no_matching_tests_in_test_list):
+(test_skipped_tests_for_unsupported_features_empty_test_list):
+(test_skipped_layout_tests):
+(test_expectations_files):
+
2012-12-20 Anders Carlsson ander...@apple.com
Don't include WebKit2 headers when building TestWebKitAPI on windows
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (138313 => 138314)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-12-20 23:57:01 UTC (rev 138313)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-12-21 00:04:40 UTC (rev 138314)
@@ -1071,13 +1071,15 @@
# Unlike baseline_search_path, we only want to search [WK2-PORT, PORT-VERSION, PORT] and any directories
# included via --additional-platform-directory, not the full casade.
search_paths = [self.port_name]
-if self.name() != self.port_name:
-search_paths.append(self.name())
+non_wk2_name = self.name().replace('-wk2', '')
+if non_wk2_name != self.port_name:
+search_paths.append(non_wk2_name)
+
if self.get_option('webkit_test_runner'):
# Because nearly all of the skipped tests for WebKit 2 are due to cross-platform
# issues, all wk2 ports share a skipped list under platform/wk2.
-search_paths.extend([self._wk2_port_name(), wk2])
+search_paths.extend([wk2, self._wk2_port_name()])
search_paths.extend(self.get_option(additional_platform_directory, []))
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py (138313 => 138314)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py 2012-12-20 23:57:01 UTC (rev 138313)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py 2012-12-21 00:04:40 UTC (rev 138314)
@@ -50,12 +50,13 @@
class TestWebKitPort(Port):
port_name = testwebkitport
-def __init__(self, symbols_string=None,
+def __init__(self, port_name=None, symbols_string=None,
expectations_file=None, skips_file=None, host=None, config=None,
**kwargs):
+port_name = port_name or TestWebKitPort.port_name
self.symbols_string = symbols_string # Passing disables all staticly-detectable features.
host = host or MockSystemHost()
-super(TestWebKitPort, self).__init__(host, TestWebKitPort.port_name, **kwargs)
+super(TestWebKitPort, self).__init__(host, port_name=port_name, **kwargs)
def all_test_configurations(self):
return [self.test_configuration()]
@@ -462,7 +463,7 @@
inspector/styles/variables, # Requires CSS Variables
])
-result_directories = set(TestWebKitPort(symbols_string, None)._skipped_tests_for_unsupported_features(test_list=['mathml/foo.html']))
+result_directories =
[webkit-changes] [138315] trunk
Title: [138315] trunk
Revision 138315
Author ad...@chromium.org
Date 2012-12-20 16:09:20 -0800 (Thu, 20 Dec 2012)
Log Message
Properly process template end tags when in TemplateContentsMode
https://bugs.webkit.org/show_bug.cgi?id=105556
Reviewed by Eric Seidel.
Source/WebCore:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag): Take care of the FIXME and just call
processTemplateEndTag() instead of incorrectly special-casing the end tag behavior in some cases.
LayoutTests:
* html5lib/resources/template.dat:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/html5lib/resources/template.dat
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (138314 => 138315)
--- trunk/LayoutTests/ChangeLog 2012-12-21 00:04:40 UTC (rev 138314)
+++ trunk/LayoutTests/ChangeLog 2012-12-21 00:09:20 UTC (rev 138315)
@@ -1,3 +1,12 @@
+2012-12-20 Adam Klein ad...@chromium.org
+
+Properly process template end tags when in TemplateContentsMode
+https://bugs.webkit.org/show_bug.cgi?id=105556
+
+Reviewed by Eric Seidel.
+
+* html5lib/resources/template.dat:
+
2012-12-20 Emil A Eklund e...@chromium.org
[flexbox] Fix handling of very large flex grow/shrink values
Modified: trunk/LayoutTests/html5lib/resources/template.dat (138314 => 138315)
--- trunk/LayoutTests/html5lib/resources/template.dat 2012-12-21 00:04:40 UTC (rev 138314)
+++ trunk/LayoutTests/html5lib/resources/template.dat 2012-12-21 00:09:20 UTC (rev 138315)
@@ -859,3 +859,19 @@
| tbody
| tr
| tfoot
+
+#data
+bodytemplatetemplatebtemplate/template/templatetext/template
+#errors
+#document
+| html
+| head
+| body
+| template
+| #document-fragment
+| template
+| #document-fragment
+| b
+| template
+| #document-fragment
+| text
Modified: trunk/Source/WebCore/ChangeLog (138314 => 138315)
--- trunk/Source/WebCore/ChangeLog 2012-12-21 00:04:40 UTC (rev 138314)
+++ trunk/Source/WebCore/ChangeLog 2012-12-21 00:09:20 UTC (rev 138315)
@@ -1,3 +1,14 @@
+2012-12-20 Adam Klein ad...@chromium.org
+
+Properly process template end tags when in TemplateContentsMode
+https://bugs.webkit.org/show_bug.cgi?id=105556
+
+Reviewed by Eric Seidel.
+
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::processEndTag): Take care of the FIXME and just call
+processTemplateEndTag() instead of incorrectly special-casing the end tag behavior in some cases.
+
2012-12-20 Kondapally Kalyan kalyan.kondapa...@intel.com
[EFL][WebGL][Wk2] Replace HAVE(GLX) checks with USE(GLX)
Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (138314 => 138315)
--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2012-12-21 00:04:40 UTC (rev 138314)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2012-12-21 00:09:20 UTC (rev 138315)
@@ -2283,12 +2283,8 @@
break;
case TemplateContentsMode:
#if ENABLE(TEMPLATE_ELEMENT)
-// FIXME: https://www.w3.org/Bugs/Public/show_bug.cgi?id=19966
if (token-name() == templateTag) {
-ASSERT(m_tree.currentStackItem()-hasTagName(templateTag));
-m_tree.openElements()-pop();
-m_templateInsertionModes.removeLast();
-resetInsertionModeAppropriately();
+processTemplateEndTag(token);
return;
}
setInsertionMode(InBodyMode);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138317] trunk
Title: [138317] trunk
Revision 138317
Author espr...@chromium.org
Date 2012-12-20 16:15:22 -0800 (Thu, 20 Dec 2012)
Log Message
RenderBlock hit testing should ignore PseudoElements
https://bugs.webkit.org/show_bug.cgi?id=105545
Reviewed by Eric Seidel.
Source/WebCore:
Use nonPseudoNode() in hit testing code in RenderBlock and RenderBox so
that when clicking on the box generated by a pseudo element we never
generate a Position for the PseudoElement, but instead for the
generating node.
Test: fast/css-generated-content/block-and-box-hit-testing.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForBox):
(WebCore::isEditingBoundary):
(WebCore::positionForPointRespectingEditingBoundaries):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionForPoint):
LayoutTests:
Add test for hit testing on pseudo element generated blocks and boxes.
* fast/css-generated-content/block-and-box-hit-testing-expected.txt: Added.
* fast/css-generated-content/block-and-box-hit-testing.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
Added Paths
trunk/LayoutTests/fast/css-generated-content/block-and-box-hit-testing-expected.txt
trunk/LayoutTests/fast/css-generated-content/block-and-box-hit-testing.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138316 => 138317)
--- trunk/LayoutTests/ChangeLog 2012-12-21 00:13:14 UTC (rev 138316)
+++ trunk/LayoutTests/ChangeLog 2012-12-21 00:15:22 UTC (rev 138317)
@@ -1,3 +1,15 @@
+2012-12-20 Elliott Sprehn espr...@chromium.org
+
+RenderBlock hit testing should ignore PseudoElements
+https://bugs.webkit.org/show_bug.cgi?id=105545
+
+Reviewed by Eric Seidel.
+
+Add test for hit testing on pseudo element generated blocks and boxes.
+
+* fast/css-generated-content/block-and-box-hit-testing-expected.txt: Added.
+* fast/css-generated-content/block-and-box-hit-testing.html: Added.
+
2012-12-20 Stephen Chenney schen...@chromium.org
SVG: altglpyh for a surrogate pair character in a ligature fails
Added: trunk/LayoutTests/fast/css-generated-content/block-and-box-hit-testing-expected.txt (0 => 138317)
--- trunk/LayoutTests/fast/css-generated-content/block-and-box-hit-testing-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/block-and-box-hit-testing-expected.txt 2012-12-21 00:15:22 UTC (rev 138317)
@@ -0,0 +1 @@
+Bug 105545 - RenderBlock and RenderBox hit testing should ignore PseudoElements
Added: trunk/LayoutTests/fast/css-generated-content/block-and-box-hit-testing.html (0 => 138317)
--- trunk/LayoutTests/fast/css-generated-content/block-and-box-hit-testing.html (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/block-and-box-hit-testing.html 2012-12-21 00:15:22 UTC (rev 138317)
@@ -0,0 +1,40 @@
+!DOCTYPE html
+
+style
+html, body {
+margin: 0;
+padding: 0;
+font-size: 14px;
+}
+
+div:before {
+display: block;
+content: Clicking the red border should not crash.;
+border: 5px solid red;
+}
+
+div:after {
+display: table;
+content: Clicking the margin should not crash.;
+margin: 10px;
+background: yellow;
+}
+/style
+
+div/div
+
+pBug 105545 - RenderBlock and RenderBox hit testing should ignore PseudoElements/p
+
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+if (window.eventSender) {
+eventSender.mouseMoveTo(0, 0);
+eventSender.mouseDown();
+eventSender.mouseUp();
+eventSender.mouseMoveTo(0, 40);
+eventSender.mouseDown();
+eventSender.mouseUp();
+}
+/script
Modified: trunk/Source/WebCore/ChangeLog (138316 => 138317)
--- trunk/Source/WebCore/ChangeLog 2012-12-21 00:13:14 UTC (rev 138316)
+++ trunk/Source/WebCore/ChangeLog 2012-12-21 00:15:22 UTC (rev 138317)
@@ -1,3 +1,24 @@
+2012-12-20 Elliott Sprehn espr...@chromium.org
+
+RenderBlock hit testing should ignore PseudoElements
+https://bugs.webkit.org/show_bug.cgi?id=105545
+
+Reviewed by Eric Seidel.
+
+Use nonPseudoNode() in hit testing code in RenderBlock and RenderBox so
+that when clicking on the box generated by a pseudo element we never
+generate a Position for the PseudoElement, but instead for the
+generating node.
+
+Test: fast/css-generated-content/block-and-box-hit-testing.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::positionForBox):
+(WebCore::isEditingBoundary):
+(WebCore::positionForPointRespectingEditingBoundaries):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::positionForPoint):
+
2012-12-20 Stephen Chenney schen...@chromium.org
SVG: altglpyh for a surrogate pair character in a ligature fails
Modified:
[webkit-changes] [138318] trunk/LayoutTests
Title: [138318] trunk/LayoutTests Revision 138318 Author rn...@webkit.org Date 2012-12-20 16:20:14 -0800 (Thu, 20 Dec 2012) Log Message Add a crash test expectation on Mac. ap is looking into the problem as we speak. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138317 => 138318) --- trunk/LayoutTests/ChangeLog 2012-12-21 00:15:22 UTC (rev 138317) +++ trunk/LayoutTests/ChangeLog 2012-12-21 00:20:14 UTC (rev 138318) @@ -1,3 +1,9 @@ +2012-12-20 Ryosuke Niwa rn...@webkit.org + +Add a crash test expectation on Mac. ap is looking into the problem as we speak. + +* platform/mac/TestExpectations: + 2012-12-20 Elliott Sprehn espr...@chromium.org RenderBlock hit testing should ignore PseudoElements Modified: trunk/LayoutTests/platform/mac/TestExpectations (138317 => 138318) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-21 00:15:22 UTC (rev 138317) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-21 00:20:14 UTC (rev 138318) @@ -1271,3 +1271,6 @@ webkit.org/b/104848 fast/frames/sandboxed-iframe-attribute-parsing.html [ Failure Pass ] webkit.org/b/104848 fast/frames/sandboxed-iframe-parsing-space-characters.html [ Failure Pass ] + +# ap is looking into this crash. +bug(rniwa) http/tests/appcache/main-resource-redirect.html [ Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138319] trunk/Source
Title: [138319] trunk/Source
Revision 138319
Author psola...@apple.com
Date 2012-12-20 16:21:04 -0800 (Thu, 20 Dec 2012)
Log Message
Rename HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) to USE(NETWORK_CFDATA_ARRAY_CALLBACK)
https://bugs.webkit.org/show_bug.cgi?id=105578
Reviewed by Alexey Proskuryakov.
Source/WebCore:
* loader/ResourceBuffer.cpp: Remove duplicate append() call that was under the wrong ifdef.
* loader/ResourceBuffer.h:
Source/WebKit2:
* NetworkProcess/NetworkResourceLoader.cpp:
* NetworkProcess/NetworkResourceLoader.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceBuffer.cpp
trunk/Source/WebCore/loader/ResourceBuffer.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138318 => 138319)
--- trunk/Source/WebCore/ChangeLog 2012-12-21 00:20:14 UTC (rev 138318)
+++ trunk/Source/WebCore/ChangeLog 2012-12-21 00:21:04 UTC (rev 138319)
@@ -1,3 +1,13 @@
+2012-12-20 Pratik Solanki psola...@apple.com
+
+Rename HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) to USE(NETWORK_CFDATA_ARRAY_CALLBACK)
+https://bugs.webkit.org/show_bug.cgi?id=105578
+
+Reviewed by Alexey Proskuryakov.
+
+* loader/ResourceBuffer.cpp: Remove duplicate append() call that was under the wrong ifdef.
+* loader/ResourceBuffer.h:
+
2012-12-20 Elliott Sprehn espr...@chromium.org
RenderBlock hit testing should ignore PseudoElements
Modified: trunk/Source/WebCore/loader/ResourceBuffer.cpp (138318 => 138319)
--- trunk/Source/WebCore/loader/ResourceBuffer.cpp 2012-12-21 00:20:14 UTC (rev 138318)
+++ trunk/Source/WebCore/loader/ResourceBuffer.cpp 2012-12-21 00:21:04 UTC (rev 138319)
@@ -126,13 +126,6 @@
}
#endif
-#if HAVE(NETWORK_CFDATA_ARRAY_CALLBACK)
-void ResourceBuffer::append(CFDataRef dataRef)
-{
-m_sharedBuffer-append(dataRef);
-}
-#endif
-
void ResourceBuffer::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{
MemoryClassInfo info(memoryObjectInfo, this);
Modified: trunk/Source/WebCore/loader/ResourceBuffer.h (138318 => 138319)
--- trunk/Source/WebCore/loader/ResourceBuffer.h 2012-12-21 00:20:14 UTC (rev 138318)
+++ trunk/Source/WebCore/loader/ResourceBuffer.h 2012-12-21 00:21:04 UTC (rev 138319)
@@ -77,9 +77,6 @@
#if USE(CF)
CFDataRef createCFData();
#endif
-#if HAVE(NETWORK_CFDATA_ARRAY_CALLBACK)
-void append(CFDataRef);
-#endif
void reportMemoryUsage(MemoryObjectInfo*) const;
Modified: trunk/Source/WebKit2/ChangeLog (138318 => 138319)
--- trunk/Source/WebKit2/ChangeLog 2012-12-21 00:20:14 UTC (rev 138318)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-21 00:21:04 UTC (rev 138319)
@@ -1,3 +1,13 @@
+2012-12-20 Pratik Solanki psola...@apple.com
+
+Rename HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) to USE(NETWORK_CFDATA_ARRAY_CALLBACK)
+https://bugs.webkit.org/show_bug.cgi?id=105578
+
+Reviewed by Alexey Proskuryakov.
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+* NetworkProcess/NetworkResourceLoader.h:
+
2012-12-20 Alexey Proskuryakov a...@apple.com
LocalTerminationDisabler is not needed in WebCookieManager.cpp
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp (138318 => 138319)
--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2012-12-21 00:20:14 UTC (rev 138318)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2012-12-21 00:21:04 UTC (rev 138319)
@@ -324,7 +324,7 @@
}
#endif
-#if HAVE(NETWORK_CFDATA_ARRAY_CALLBACK)
+#if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
bool NetworkResourceLoader::supportsDataArray()
{
notImplemented();
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h (138318 => 138319)
--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h 2012-12-21 00:20:14 UTC (rev 138318)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h 2012-12-21 00:21:04 UTC (rev 138319)
@@ -89,7 +89,7 @@
virtual bool canAuthenticateAgainstProtectionSpace(WebCore::ResourceHandle*, const WebCore::ProtectionSpace) OVERRIDE;
#endif
-#if HAVE(NETWORK_CFDATA_ARRAY_CALLBACK)
+#if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
virtual bool supportsDataArray() OVERRIDE;
virtual void didReceiveDataArray(WebCore::ResourceHandle*, CFArrayRef) OVERRIDE;
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138320] trunk
Title: [138320] trunk
Revision 138320
Author commit-qu...@webkit.org
Date 2012-12-20 16:23:01 -0800 (Thu, 20 Dec 2012)
Log Message
Unreviewed, rolling out r138270.
http://trac.webkit.org/changeset/138270
https://bugs.webkit.org/show_bug.cgi?id=105589
Many media tests are failing/crashing intermittently, often
pointing at WebCore::HTMLTrackElement::didCompleteLoad as
culprit (Requested by dino_ on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-12-20
Source/WebCore:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackModeChanged):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::insertedInto):
(WebCore::HTMLTrackElement::parseAttribute):
(WebCore::HTMLTrackElement::scheduleLoad):
(WebCore::HTMLTrackElement::textTrackModeChanged):
* html/HTMLTrackElement.h:
* html/track/TextTrack.cpp:
* html/track/TextTrack.h:
LayoutTests:
* fast/events/constructors/track-event-constructor.html:
* http/tests/security/text-track-crossorigin.html:
* media/track/track-add-track-expected.txt:
* media/track/track-add-track.html:
* media/track/track-element-load-event-expected.txt: Removed.
* media/track/track-element-load-event.html: Removed.
* media/track/track-load-from-src-readyState.html:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/constructors/track-event-constructor.html
trunk/LayoutTests/http/tests/security/text-track-crossorigin.html
trunk/LayoutTests/media/track/track-add-track-expected.txt
trunk/LayoutTests/media/track/track-add-track.html
trunk/LayoutTests/media/track/track-load-from-src-readyState.html
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLTrackElement.cpp
trunk/Source/WebCore/html/HTMLTrackElement.h
trunk/Source/WebCore/html/track/TextTrack.cpp
trunk/Source/WebCore/html/track/TextTrack.h
Removed Paths
trunk/LayoutTests/media/track/track-element-load-event-expected.txt
trunk/LayoutTests/media/track/track-element-load-event.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138319 => 138320)
--- trunk/LayoutTests/ChangeLog 2012-12-21 00:21:04 UTC (rev 138319)
+++ trunk/LayoutTests/ChangeLog 2012-12-21 00:23:01 UTC (rev 138320)
@@ -1,3 +1,27 @@
+2012-12-20 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r138270.
+http://trac.webkit.org/changeset/138270
+https://bugs.webkit.org/show_bug.cgi?id=105589
+
+Many media tests are failing/crashing intermittently, often
+pointing at WebCore::HTMLTrackElement::didCompleteLoad as
+culprit (Requested by dino_ on #webkit).
+
+* fast/events/constructors/track-event-constructor.html:
+* http/tests/security/text-track-crossorigin.html:
+* media/track/track-add-track-expected.txt:
+* media/track/track-add-track.html:
+* media/track/track-element-load-event-expected.txt: Removed.
+* media/track/track-element-load-event.html: Removed.
+* media/track/track-load-from-src-readyState.html:
+* platform/chromium/TestExpectations:
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/qt/TestExpectations:
+* platform/win/TestExpectations:
+
2012-12-20 Ryosuke Niwa rn...@webkit.org
Add a crash test expectation on Mac. ap is looking into the problem as we speak.
Modified: trunk/LayoutTests/fast/events/constructors/track-event-constructor.html (138319 => 138320)
--- trunk/LayoutTests/fast/events/constructors/track-event-constructor.html 2012-12-21 00:21:04 UTC (rev 138319)
+++ trunk/LayoutTests/fast/events/constructors/track-event-constructor.html 2012-12-21 00:23:01 UTC (rev 138320)
@@ -55,7 +55,6 @@
trackElement = document.createElement('track');
video.appendChild(trackElement);
-trackElement.track.mode = hidden;
trackElement.addEventListener('load', test);
trackElement.src='';
Modified: trunk/LayoutTests/http/tests/security/text-track-crossorigin.html (138319 => 138320)
--- trunk/LayoutTests/http/tests/security/text-track-crossorigin.html 2012-12-21 00:21:04 UTC (rev 138319)
+++ trunk/LayoutTests/http/tests/security/text-track-crossorigin.html 2012-12-21 00:23:01 UTC (rev 138320)
@@ -79,7 +79,6 @@
function start()
{
trackElement =
[webkit-changes] [138321] trunk/Source/JavaScriptCore
Title: [138321] trunk/Source/_javascript_Core
Revision 138321
Author oli...@apple.com
Date 2012-12-20 16:29:17 -0800 (Thu, 20 Dec 2012)
Log Message
Try to convince bots to be happy with testapi.
Modified Paths
trunk/Source/_javascript_Core/API/JSScriptRefPrivate.h
trunk/Source/_javascript_Core/ChangeLog
Diff
Modified: trunk/Source/_javascript_Core/API/JSScriptRefPrivate.h (138320 => 138321)
--- trunk/Source/_javascript_Core/API/JSScriptRefPrivate.h 2012-12-21 00:23:01 UTC (rev 138320)
+++ trunk/Source/_javascript_Core/API/JSScriptRefPrivate.h 2012-12-21 00:29:17 UTC (rev 138321)
@@ -30,13 +30,13 @@
#include _javascript_Core/JSStringRef.h
#include _javascript_Core/JSValueRef.h
+/*! @typedef JSScriptRef A _javascript_ script reference. */
+typedef struct OpaqueJSScript* JSScriptRef;
+
#ifdef __cplusplus
extern C {
#endif
-/*! @typedef JSScriptRef A _javascript_ script reference. */
-typedef struct OpaqueJSScript* JSScriptRef;
-
/*!
@function
@abstract Creates a script reference from an ascii string, without copying or taking ownership of the string
Modified: trunk/Source/_javascript_Core/ChangeLog (138320 => 138321)
--- trunk/Source/_javascript_Core/ChangeLog 2012-12-21 00:23:01 UTC (rev 138320)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-12-21 00:29:17 UTC (rev 138321)
@@ -1,3 +1,9 @@
+2012-12-20 Oliver Hunt oli...@apple.com
+
+Try to convince bots to be happy with testapi.
+
+* API/JSScriptRefPrivate.h:
+
2012-12-20 Michael Saboff msab...@apple.com
JIT: Change uninitialized pointer value -1 to constant
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138322] trunk/LayoutTests
Title: [138322] trunk/LayoutTests
Revision 138322
Author d...@apple.com
Date 2012-12-20 16:44:11 -0800 (Thu, 20 Dec 2012)
Log Message
REGRESSION: media/video-controls-captions-trackmenu.html intermittently fails
https://bugs.webkit.org/show_bug.cgi?id=105584
Unreviewed expected results update. Remove the failure expectation.
* media/video-controls-captions-trackmenu-expected.txt:
* media/video-controls-captions-trackmenu.html:
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt
trunk/LayoutTests/media/video-controls-captions-trackmenu.html
trunk/LayoutTests/platform/mac/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (138321 => 138322)
--- trunk/LayoutTests/ChangeLog 2012-12-21 00:29:17 UTC (rev 138321)
+++ trunk/LayoutTests/ChangeLog 2012-12-21 00:44:11 UTC (rev 138322)
@@ -1,3 +1,14 @@
+2012-12-20 Dean Jackson d...@apple.com
+
+REGRESSION: media/video-controls-captions-trackmenu.html intermittently fails
+https://bugs.webkit.org/show_bug.cgi?id=105584
+
+Unreviewed expected results update. Remove the failure expectation.
+
+* media/video-controls-captions-trackmenu-expected.txt:
+* media/video-controls-captions-trackmenu.html:
+* platform/mac/TestExpectations:
+
2012-12-20 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r138270.
Modified: trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt (138321 => 138322)
--- trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt 2012-12-21 00:29:17 UTC (rev 138321)
+++ trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt 2012-12-21 00:44:11 UTC (rev 138322)
@@ -12,9 +12,9 @@
EXPECTED (5 == '5') OK
EXPECTED (video.textTracks.length == '4') OK
Track 0 should be showing
-EXPECTED (video.textTracks[0].mode == 'showing') OK
+EXPECTED (video.textTracks[0].mode == 'disabled') OK
Track 1 should be disabled
-EXPECTED (video.textTracks[1].mode == 'disabled') OK
+EXPECTED (video.textTracks[1].mode == 'showing') OK
Track 2 should be disabled
EXPECTED (video.textTracks[2].mode == 'disabled') OK
Track 3 should be disabled
Modified: trunk/LayoutTests/media/video-controls-captions-trackmenu.html (138321 => 138322)
--- trunk/LayoutTests/media/video-controls-captions-trackmenu.html 2012-12-21 00:29:17 UTC (rev 138321)
+++ trunk/LayoutTests/media/video-controls-captions-trackmenu.html 2012-12-21 00:44:11 UTC (rev 138322)
@@ -70,9 +70,9 @@
{
testExpected(video.textTracks.length, 4);
consoleWrite(Track 0 should be showing);
-testExpected(video.textTracks[0].mode, showing);
+testExpected(video.textTracks[0].mode, disabled);
consoleWrite(Track 1 should be disabled);
-testExpected(video.textTracks[1].mode, disabled);
+testExpected(video.textTracks[1].mode, showing);
consoleWrite(Track 2 should be disabled);
testExpected(video.textTracks[2].mode, disabled);
consoleWrite(Track 3 should be disabled);
Modified: trunk/LayoutTests/platform/mac/TestExpectations (138321 => 138322)
--- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-21 00:29:17 UTC (rev 138321)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-21 00:44:11 UTC (rev 138322)
@@ -1260,7 +1260,6 @@
webkit.org/b/105566 media/track/track-webvtt-tc006-cue-identifiers.html [ Crash Pass ]
webkit.org/b/105580 media/track/track-prefer-captions.html [ Crash Pass ]
-webkit.org/b/105584 media/video-controls-captions-trackmenu.html [ Failure Pass ]
webkit.org/b/105567 http/tests/security/data-url-inline.css.html [ Crash Pass ]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138323] trunk/LayoutTests
Title: [138323] trunk/LayoutTests Revision 138323 Author e...@chromium.org Date 2012-12-20 16:46:26 -0800 (Thu, 20 Dec 2012) Log Message Unreviewed, remove css3/flexbox/flex-algorithm.html from efl, gtk and qt TestExpectations file. * platform/efl/TestExpectations: * platform/gtk/TestExpectations: * platform/qt/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/qt/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138322 => 138323) --- trunk/LayoutTests/ChangeLog 2012-12-21 00:44:11 UTC (rev 138322) +++ trunk/LayoutTests/ChangeLog 2012-12-21 00:46:26 UTC (rev 138323) @@ -1,3 +1,11 @@ +2012-12-20 Emil A Eklund e...@chromium.org + +Unreviewed, remove css3/flexbox/flex-algorithm.html from efl, gtk and qt TestExpectations file. + +* platform/efl/TestExpectations: +* platform/gtk/TestExpectations: +* platform/qt/TestExpectations: + 2012-12-20 Dean Jackson d...@apple.com REGRESSION: media/video-controls-captions-trackmenu.html intermittently fails Modified: trunk/LayoutTests/platform/efl/TestExpectations (138322 => 138323) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-12-21 00:44:11 UTC (rev 138322) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-12-21 00:46:26 UTC (rev 138323) @@ -1735,8 +1735,6 @@ webkit.org/b/104571 http/tests/security/xssAuditor/script-tag-with-source-null-char.html [ Failure ] webkit.org/b/104571 http/tests/xmlhttprequest/origin-exact-matching.html [ Failure ] -webkit.org/b/104788 css3/flexbox/flex-algorithm.html [ Failure ] - # Fixed positioning reftest failing webkit.org/b/104808 compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/platform/gtk/TestExpectations (138322 => 138323) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-21 00:44:11 UTC (rev 138322) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-21 00:46:26 UTC (rev 138323) @@ -1419,8 +1419,6 @@ webkit.org/b/104686 http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html [ Failure ] -webkit.org/b/104788 css3/flexbox/flex-algorithm.html [ Failure ] - webkit.org/b/87734 svg/dom/SVGViewSpec.html [ Failure ] webkit.org/b/87734 svg/dom/complex-svgView-specification.html [ ImageOnlyFailure ] webkit.org/b/87734 svg/dom/viewspec-parser-1.html [ Failure ] Modified: trunk/LayoutTests/platform/qt/TestExpectations (138322 => 138323) --- trunk/LayoutTests/platform/qt/TestExpectations 2012-12-21 00:44:11 UTC (rev 138322) +++ trunk/LayoutTests/platform/qt/TestExpectations 2012-12-21 00:46:26 UTC (rev 138323) @@ -2495,5 +2495,3 @@ # https://bugs.webkit.org/show_bug.cgi?id=104352 http/tests/xmlhttprequest/post-blob-content-type-async.html http/tests/xmlhttprequest/post-blob-content-type-sync.html - -webkit.org/b/104788 css3/flexbox/flex-algorithm.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138324] trunk/Source/WebKit2
Title: [138324] trunk/Source/WebKit2
Revision 138324
Author commit-qu...@webkit.org
Date 2012-12-20 16:51:18 -0800 (Thu, 20 Dec 2012)
Log Message
[CoordGfx] Remove CoordinatedLayerUpdateInfo class forwarding
https://bugs.webkit.org/show_bug.cgi?id=105588
Patch by Helder Correia helder.corr...@nokia.com on 2012-12-20
Reviewed by Noam Rosenthal.
There is no such class.
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(WebKit):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(WebKit):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (138323 => 138324)
--- trunk/Source/WebKit2/ChangeLog 2012-12-21 00:46:26 UTC (rev 138323)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-21 00:51:18 UTC (rev 138324)
@@ -1,3 +1,17 @@
+2012-12-20 Helder Correia helder.corr...@nokia.com
+
+[CoordGfx] Remove CoordinatedLayerUpdateInfo class forwarding
+https://bugs.webkit.org/show_bug.cgi?id=105588
+
+Reviewed by Noam Rosenthal.
+
+There is no such class.
+
+* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
+(WebKit):
+* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
+(WebKit):
+
2012-12-20 Pratik Solanki psola...@apple.com
Rename HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) to USE(NETWORK_CFDATA_ARRAY_CALLBACK)
Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h (138323 => 138324)
--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h 2012-12-21 00:46:26 UTC (rev 138323)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h 2012-12-21 00:51:18 UTC (rev 138324)
@@ -44,7 +44,6 @@
class CoordinatedLayerInfo;
class LayerTreeRenderer;
-class CoordinatedLayerUpdateInfo;
class CoordinatedLayerTreeHostProxy {
WTF_MAKE_NONCOPYABLE(CoordinatedLayerTreeHostProxy);
Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h (138323 => 138324)
--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h 2012-12-21 00:46:26 UTC (rev 138323)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h 2012-12-21 00:51:18 UTC (rev 138324)
@@ -49,7 +49,6 @@
class CoordinatedBackingStore;
class CoordinatedLayerTreeHostProxy;
class CoordinatedLayerInfo;
-class CoordinatedLayerUpdateInfo;
class LayerTreeRenderer : public ThreadSafeRefCountedLayerTreeRenderer, public WebCore::GraphicsLayerClient {
public:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138325] trunk/LayoutTests
Title: [138325] trunk/LayoutTests
Revision 138325
Author dmazz...@google.com
Date 2012-12-20 16:58:13 -0800 (Thu, 20 Dec 2012)
Log Message
accessibility/svg-remote-element.html is flaky (times out)
https://bugs.webkit.org/show_bug.cgi?id=105587
Reviewed by Chris Fleizach.
Avoid race condition where the test would never run if the
SVG image was already loaded before the load event listener
gets added.
* accessibility/svg-remote-element.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/svg-remote-element.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138324 => 138325)
--- trunk/LayoutTests/ChangeLog 2012-12-21 00:51:18 UTC (rev 138324)
+++ trunk/LayoutTests/ChangeLog 2012-12-21 00:58:13 UTC (rev 138325)
@@ -1,3 +1,16 @@
+2012-12-20 Dominic Mazzoni dmazz...@google.com
+
+accessibility/svg-remote-element.html is flaky (times out)
+https://bugs.webkit.org/show_bug.cgi?id=105587
+
+Reviewed by Chris Fleizach.
+
+Avoid race condition where the test would never run if the
+SVG image was already loaded before the load event listener
+gets added.
+
+* accessibility/svg-remote-element.html:
+
2012-12-20 Emil A Eklund e...@chromium.org
Unreviewed, remove css3/flexbox/flex-algorithm.html from efl, gtk and qt TestExpectations file.
Modified: trunk/LayoutTests/accessibility/svg-remote-element.html (138324 => 138325)
--- trunk/LayoutTests/accessibility/svg-remote-element.html 2012-12-21 00:51:18 UTC (rev 138324)
+++ trunk/LayoutTests/accessibility/svg-remote-element.html 2012-12-21 00:58:13 UTC (rev 138325)
@@ -3,7 +3,7 @@
body
script src=""
-img tabindex=0 id=svg-image src="" alt=interactive SVG
+img tabindex=0 id=svg-image alt=interactive SVG
div id=console/div
script
@@ -21,10 +21,6 @@
return element.clickPointY - element.height/2;
}
-if (window.accessibilityController) {
-document.getElementById(svg-image).addEventListener(load, runAXTest);
-}
-
function runAXTest() {
var container = accessibilityController.accessibleElementById(svg-image);
@@ -64,6 +60,11 @@
finishJSTest();
}
+if (window.accessibilityController) {
+document.getElementById(svg-image).addEventListener(load, runAXTest);
+}
+document.getElementById(svg-image).src = ""
+
/script
script src=""
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138327] trunk/Source/WebCore
Title: [138327] trunk/Source/WebCore
Revision 138327
Author commit-qu...@webkit.org
Date 2012-12-20 17:01:47 -0800 (Thu, 20 Dec 2012)
Log Message
[EFL] [WebGL] [Wk2] Contents are not rendered properly.
https://bugs.webkit.org/show_bug.cgi?id=104664
Patch by Viatcheslav Ostapenko sl.ostape...@samsung.com on 2012-12-20
Reviewed by Noam Rosenthal.
WebGL pages that render more than one frame are broken. Only 1st
frame comes to the UI side. All webgl repaint tests fail because
of this.
Specification of EXT_texture_from_pixmap extension here
http://www.opengl.org/registry/specs/EXT/texture_from_pixmap.txt
says, that:
The contents of the texture after the drawable has been bound are defined
as the result of all rendering that has completed before the call to
glXBindTexImageEXT.
It means that in order to get updates for every frame glXBindTexImageEXT has
to be called on every frame update.
Covered by existing fast/canavs/webgl/*repaint tests.
* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::isReceiver):
(WebCore::GraphicsSurface::platformSwapBuffers):
* platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138326 => 138327)
--- trunk/Source/WebCore/ChangeLog 2012-12-21 00:59:46 UTC (rev 138326)
+++ trunk/Source/WebCore/ChangeLog 2012-12-21 01:01:47 UTC (rev 138327)
@@ -1,3 +1,30 @@
+2012-12-20 Viatcheslav Ostapenko sl.ostape...@samsung.com
+
+[EFL] [WebGL] [Wk2] Contents are not rendered properly.
+https://bugs.webkit.org/show_bug.cgi?id=104664
+
+Reviewed by Noam Rosenthal.
+
+WebGL pages that render more than one frame are broken. Only 1st
+frame comes to the UI side. All webgl repaint tests fail because
+of this.
+Specification of EXT_texture_from_pixmap extension here
+http://www.opengl.org/registry/specs/EXT/texture_from_pixmap.txt
+says, that:
+The contents of the texture after the drawable has been bound are defined
+as the result of all rendering that has completed before the call to
+glXBindTexImageEXT.
+It means that in order to get updates for every frame glXBindTexImageEXT has
+to be called on every frame update.
+
+Covered by existing fast/canavs/webgl/*repaint tests.
+
+* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
+(WebCore::GraphicsSurfacePrivate::isReceiver):
+(WebCore::GraphicsSurface::platformSwapBuffers):
+* platform/graphics/texmap/TextureMapperBackingStore.cpp:
+(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
+
2012-12-20 Ryuan Choi ryuan.c...@samsung.com
[EFL] Build break with latest EFL libraries.
Modified: trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp (138326 => 138327)
--- trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp 2012-12-21 00:59:46 UTC (rev 138326)
+++ trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp 2012-12-21 01:01:47 UTC (rev 138327)
@@ -354,6 +354,7 @@
return m_size;
}
+bool isReceiver() const { return m_isReceiver; }
private:
OffScreenRootWindow m_offScreenWindow;
IntSize m_size;
@@ -437,6 +438,14 @@
uint32_t GraphicsSurface::platformSwapBuffers()
{
+if (m_private-isReceiver()) {
+glBindTexture(GL_TEXTURE_2D, platformGetTextureID());
+// Release previous lock and rebind texture to surface to get frame update.
+pGlXReleaseTexImageEXT(m_private-display(), m_private-glxPixmap(), GLX_FRONT_EXT);
+pGlXBindTexImageEXT(m_private-display(), m_private-glxPixmap(), GLX_FRONT_EXT, 0);
+return 0;
+}
+
m_private-swapBuffers();
return 0;
}
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp (138326 => 138327)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp 2012-12-21 00:59:46 UTC (rev 138326)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp 2012-12-21 01:01:47 UTC (rev 138327)
@@ -39,9 +39,9 @@
m_graphicsSurface = surface;
}
-void TextureMapperSurfaceBackingStore::swapBuffersIfNeeded(uint32_t frontBuffer)
+void TextureMapperSurfaceBackingStore::swapBuffersIfNeeded(uint32_t)
{
-if (m_graphicsSurface m_graphicsSurface-frontBuffer() != frontBuffer)
+if (m_graphicsSurface)
m_graphicsSurface-swapBuffers();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138328] trunk/Source/WebCore
Title: [138328] trunk/Source/WebCore Revision 138328 Author a...@apple.com Date 2012-12-20 17:18:21 -0800 (Thu, 20 Dec 2012) Log Message REGRESSION (r138191): Tests crash in ResourceRequest::setStorageSession https://bugs.webkit.org/show_bug.cgi?id=105563 Reviewed by Brady Eidson. Partially fixes crashing http/tests/appcache/main-resource-redirect.html (but there is an unrelated regression affecting this test). * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willSendRequest): * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): The client can make the object get destoryed, protect it to avoid accessing deleted memory. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (138327 => 138328) --- trunk/Source/WebCore/ChangeLog 2012-12-21 01:01:47 UTC (rev 138327) +++ trunk/Source/WebCore/ChangeLog 2012-12-21 01:18:21 UTC (rev 138328) @@ -1,3 +1,17 @@ +2012-12-20 Alexey Proskuryakov a...@apple.com + +REGRESSION (r138191): Tests crash in ResourceRequest::setStorageSession +https://bugs.webkit.org/show_bug.cgi?id=105563 + +Reviewed by Brady Eidson. + +Partially fixes crashing http/tests/appcache/main-resource-redirect.html +(but there is an unrelated regression affecting this test). + +* platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willSendRequest): +* platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): +The client can make the object get destoryed, protect it to avoid accessing deleted memory. + 2012-12-20 Viatcheslav Ostapenko sl.ostape...@samsung.com [EFL] [WebGL] [Wk2] Contents are not rendered properly. Modified: trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp (138327 => 138328) --- trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp 2012-12-21 01:01:47 UTC (rev 138327) +++ trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp 2012-12-21 01:18:21 UTC (rev 138328) @@ -559,6 +559,7 @@ } } +RefPtrResourceHandle protect(this); client()-willSendRequest(this, request, redirectResponse); // Client call may not preserve the session, especially if the request is sent over IPC. Modified: trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm (138327 => 138328) --- trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2012-12-21 01:01:47 UTC (rev 138327) +++ trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2012-12-21 01:18:21 UTC (rev 138328) @@ -472,6 +472,7 @@ } } +RefPtrResourceHandle protect(this); client()-willSendRequest(this, request, redirectResponse); // Client call may not preserve the session, especially if the request is sent over IPC. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138329] trunk/Source/JavaScriptCore
Title: [138329] trunk/Source/_javascript_Core Revision 138329 Author oli...@apple.com Date 2012-12-20 17:26:39 -0800 (Thu, 20 Dec 2012) Log Message Finally found the problem. Using the wrong JSContextGroup. Modified Paths trunk/Source/_javascript_Core/API/tests/testapi.c trunk/Source/_javascript_Core/ChangeLog Diff Modified: trunk/Source/_javascript_Core/API/tests/testapi.c (138328 => 138329) --- trunk/Source/_javascript_Core/API/tests/testapi.c 2012-12-21 01:18:21 UTC (rev 138328) +++ trunk/Source/_javascript_Core/API/tests/testapi.c 2012-12-21 01:26:39 UTC (rev 138329) @@ -1047,7 +1047,6 @@ // Test garbage collection with a fresh context context = JSGlobalContextCreateInGroup(NULL, NULL); -JSContextGroupRef contextGroup = JSContextGetGroup(context); TestInitializeFinalize = true; testInitializeFinalize(); JSGlobalContextRelease(context); @@ -1063,6 +1062,8 @@ JSClassRef globalObjectClass = JSClassCreate(globalObjectClassDefinition); context = JSGlobalContextCreateInGroup(NULL, globalObjectClass); +JSContextGroupRef contextGroup = JSContextGetGroup(context); + JSGlobalContextRetain(context); JSGlobalContextRelease(context); ASSERT(JSContextGetGlobalContext(context) == context); Modified: trunk/Source/_javascript_Core/ChangeLog (138328 => 138329) --- trunk/Source/_javascript_Core/ChangeLog 2012-12-21 01:18:21 UTC (rev 138328) +++ trunk/Source/_javascript_Core/ChangeLog 2012-12-21 01:26:39 UTC (rev 138329) @@ -1,5 +1,12 @@ 2012-12-20 Oliver Hunt oli...@apple.com +Finally found the problem. Using the wrong JSContextGroup. + +* API/tests/testapi.c: +(main): + +2012-12-20 Oliver Hunt oli...@apple.com + Try to convince bots to be happy with testapi. * API/JSScriptRefPrivate.h: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138330] trunk/LayoutTests
Title: [138330] trunk/LayoutTests Revision 138330 Author rn...@webkit.org Date 2012-12-20 17:39:58 -0800 (Thu, 20 Dec 2012) Log Message Add Mac test expectations for the bug 73865. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138329 => 138330) --- trunk/LayoutTests/ChangeLog 2012-12-21 01:26:39 UTC (rev 138329) +++ trunk/LayoutTests/ChangeLog 2012-12-21 01:39:58 UTC (rev 138330) @@ -1,3 +1,9 @@ +2012-12-20 Ryosuke Niwa rn...@webkit.org + +Add Mac test expectations for the bug 73865. + +* platform/mac/TestExpectations: + 2012-12-20 Dominic Mazzoni dmazz...@google.com accessibility/svg-remote-element.html is flaky (times out) Modified: trunk/LayoutTests/platform/mac/TestExpectations (138329 => 138330) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-21 01:26:39 UTC (rev 138329) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-21 01:39:58 UTC (rev 138330) @@ -1223,7 +1223,6 @@ webkit.org/b/100846 inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html [ Skip ] webkit.org/b/100142 css3/filters/effect-reference-hw.html [ Failure ] -webkit.org/b/100142 css3/filters/effect-reference-ordering-hw.html [ Failure ] webkit.org/b/100142 css3/filters/effect-reference.html [ Failure ] # Mac doesn't have a toggle for CC any more, it's based on a menu of choices. @@ -1261,6 +1260,10 @@ webkit.org/b/105566 media/track/track-webvtt-tc006-cue-identifiers.html [ Crash Pass ] webkit.org/b/105580 media/track/track-prefer-captions.html [ Crash Pass ] +webkit.org/b/73865 media/track/tracklist-is-reachable.html [ Crash Pass ] +webkit.org/b/73865 media/track/text-track-cue-is-reachable.html [ Crash Pass ] +webkit.org/b/73865 media/track/text-track-is-reachable.html [ Crash Pass ] + webkit.org/b/105567 http/tests/security/data-url-inline.css.html [ Crash Pass ] webkit.org/b/104848 fast/frames/sandboxed-iframe-attribute-parsing.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138331] trunk/Source
Title: [138331] trunk/Source
Revision 138331
Author ander...@apple.com
Date 2012-12-20 17:43:29 -0800 (Thu, 20 Dec 2012)
Log Message
Stop building WebKit2 for Windows
https://bugs.webkit.org/show_bug.cgi?id=105585
Reviewed by Brian Weinstein.
Source/WebKit/win:
Stop building WebKit2 on Windows, and change WebKit.vcproj to build WebKit.dll again.
* WebKit.vcproj/WebKit.sln:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitApple.vsprops: Added.
* WebKit.vcproj/WebKitDirectX.vsprops: Added.
* WebKit.vcproj/WebKitLibCommon.vsprops:
* WebKit.vcproj/WebKitLibDebug.vsprops:
* WebKit.vcproj/WebKitLibDebugAll.vsprops:
* WebKit.vcproj/WebKitLibProduction.vsprops:
* WebKit.vcproj/WebKitLibRelease.vsprops:
Source/WebKit2:
Remove an unneeded export.
* win/WebKit2.def.in:
Modified Paths
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebKit.vcproj/WebKit.sln
trunk/Source/WebKit/win/WebKit.vcproj/WebKit.vcproj
trunk/Source/WebKit/win/WebKit.vcproj/WebKitLibCommon.vsprops
trunk/Source/WebKit/win/WebKit.vcproj/WebKitLibDebug.vsprops
trunk/Source/WebKit/win/WebKit.vcproj/WebKitLibDebugAll.vsprops
trunk/Source/WebKit/win/WebKit.vcproj/WebKitLibProduction.vsprops
trunk/Source/WebKit/win/WebKit.vcproj/WebKitLibRelease.vsprops
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def.in
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (138330 => 138331)
--- trunk/Source/WebKit/win/ChangeLog 2012-12-21 01:39:58 UTC (rev 138330)
+++ trunk/Source/WebKit/win/ChangeLog 2012-12-21 01:43:29 UTC (rev 138331)
@@ -1,5 +1,24 @@
2012-12-20 Anders Carlsson ander...@apple.com
+Stop building WebKit2 for Windows
+https://bugs.webkit.org/show_bug.cgi?id=105585
+
+Reviewed by Brian Weinstein.
+
+Stop building WebKit2 on Windows, and change WebKit.vcproj to build WebKit.dll again.
+
+* WebKit.vcproj/WebKit.sln:
+* WebKit.vcproj/WebKit.vcproj:
+* WebKit.vcproj/WebKitApple.vsprops: Added.
+* WebKit.vcproj/WebKitDirectX.vsprops: Added.
+* WebKit.vcproj/WebKitLibCommon.vsprops:
+* WebKit.vcproj/WebKitLibDebug.vsprops:
+* WebKit.vcproj/WebKitLibDebugAll.vsprops:
+* WebKit.vcproj/WebKitLibProduction.vsprops:
+* WebKit.vcproj/WebKitLibRelease.vsprops:
+
+2012-12-20 Anders Carlsson ander...@apple.com
+
Copy WebKit2.rc to back to WebKit/win/WebKit.vcproj.
Rubber-stamped by Tim Horton.
Modified: trunk/Source/WebKit/win/WebKit.vcproj/WebKit.sln (138330 => 138331)
--- trunk/Source/WebKit/win/WebKit.vcproj/WebKit.sln 2012-12-21 01:39:58 UTC (rev 138330)
+++ trunk/Source/WebKit/win/WebKit.vcproj/WebKit.sln 2012-12-21 01:43:29 UTC (rev 138331)
@@ -3,8 +3,8 @@
# Visual Studio 2005
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = _javascript_Core, ..\..\..\_javascript_Core\_javascript_Core.vcproj\_javascript_Core\_javascript_Core.vcproj, {011D10F1-B656-4A1B-A0C3-3842F02122C5}
ProjectSection(ProjectDependencies) = postProject
- {4FF5BA11-59EC-4C24-8F52-F235C2E7D43A} = {4FF5BA11-59EC-4C24-8F52-F235C2E7D43A}
{9221744B-5715-4F56-9590-42F7AB23DD8B} = {9221744B-5715-4F56-9590-42F7AB23DD8B}
+ {4FF5BA11-59EC-4C24-8F52-F235C2E7D43A} = {4FF5BA11-59EC-4C24-8F52-F235C2E7D43A}
EndProjectSection
EndProject
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = WebCore, ..\..\..\WebCore\WebCore.vcproj\WebCore.vcproj, {1C16337B-ACF3-4D03-AA90-851C5B5EADA6}
@@ -43,28 +43,11 @@
EndProject
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = testapi, ..\..\..\_javascript_Core\_javascript_Core.vcproj\testapi\testapi.vcproj, {1AFD081F-1AC7-4A97-8EFA-6DF97761A3A2}
ProjectSection(ProjectDependencies) = postProject
- {AAE88FEF-509E-4D49-870B-7357922C276F} = {AAE88FEF-509E-4D49-870B-7357922C276F}
- EndProjectSection
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = WebKit, ..\..\..\WebKit2\win\WebKit2.vcproj, {2E51ABE8-76CB-485B-A66C-46AEF4DF8ACD}
- ProjectSection(ProjectDependencies) = postProject
- {2EDAD637-CBA8-4E55-97ED-7D2BBC336FDB} = {2EDAD637-CBA8-4E55-97ED-7D2BBC336FDB}
- EndProjectSection
-EndProject
-Project({2150E333-8FDC-42A3-9474-1A3956D46DE8}) = WebKit2 Folder, WebKit2 Folder, {9AB9C96C-9039-4FA9-8F83-BBFC8F8B2182}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = WebKit2Generated, ..\..\..\WebKit2\win\WebKit2Generated.vcproj, {2EDAD637-CBA8-4E55-97ED-7D2BBC336FDB}
- ProjectSection(ProjectDependencies) = postProject
{0662A8A9-82A3-4638-97D8-EC425D8D87C9} = {0662A8A9-82A3-4638-97D8-EC425D8D87C9}
EndProjectSection
EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = WebKit2WebProcess, ..\..\..\WebKit2\win\WebKit2WebProcess.vcproj, {AAE88FEF-509E-4D49-870B-7357922C276F}
- ProjectSection(ProjectDependencies) = postProject
- {2E51ABE8-76CB-485B-A66C-46AEF4DF8ACD} = {2E51ABE8-76CB-485B-A66C-46AEF4DF8ACD}
- EndProjectSection
+Project({2150E333-8FDC-42A3-9474-1A3956D46DE8}) = WebKit Folder, WebKit Folder, {1D359ACC-BE10-45D7-938B-BC7E4B7AA6CA}
[webkit-changes] [138332] trunk
Title: [138332] trunk
Revision 138332
Author commit-qu...@webkit.org
Date 2012-12-20 17:52:05 -0800 (Thu, 20 Dec 2012)
Log Message
Percentage min/max width replaced element may incorrectly rendered
https://bugs.webkit.org/show_bug.cgi?id=105264
Patch by KyungTae Kim ktf@samsung.com on 2012-12-20
Reviewed by Tony Chang.
Source/WebCore:
To make do not include percentage min width in preferred logical width calculation,
because we cannot resolve it for preferred width.
Test: fast/css/percent-min-width-img-src-change.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidth):
Modify includeMaxWidth parameter to shouldComputePreferred.
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
Modify includeMaxWidth parameter to shouldComputePreferred.
If shouldComputePreferred is ComputePreferred,
don't use minLogicalWidth or maxLogicalWidth if they are percent type.
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
Modify includeMaxWidth parameter to shouldComputePreferred.
(WebCore::RenderReplaced::computeMaxPreferredLogicalWidth):
Modify from set includeMaxWidth=false to set shouldComputePreferred=ComputePreferred.
* rendering/RenderReplaced.h:
(RenderReplaced):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
Modify includeMaxWidth parameter to shouldComputePreferred.
* rendering/RenderSVGRoot.h:
(RenderSVGRoot):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::computeReplacedLogicalWidth):
Modify includeMaxWidth parameter to shouldComputePreferred.
* rendering/RenderVideo.h:
(RenderVideo):
LayoutTests:
Add test to check when the source of images with percentage min-width is changed.
* fast/css/percent-min-width-img-src-change-expected.txt: Added.
* fast/css/percent-min-width-img-src-change.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderReplaced.cpp
trunk/Source/WebCore/rendering/RenderReplaced.h
trunk/Source/WebCore/rendering/RenderVideo.cpp
trunk/Source/WebCore/rendering/RenderVideo.h
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h
Added Paths
trunk/LayoutTests/fast/css/percent-min-width-img-src-change-expected.txt
trunk/LayoutTests/fast/css/percent-min-width-img-src-change.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138331 => 138332)
--- trunk/LayoutTests/ChangeLog 2012-12-21 01:43:29 UTC (rev 138331)
+++ trunk/LayoutTests/ChangeLog 2012-12-21 01:52:05 UTC (rev 138332)
@@ -1,3 +1,15 @@
+2012-12-20 KyungTae Kim ktf@samsung.com
+
+Percentage min/max width replaced element may incorrectly rendered
+https://bugs.webkit.org/show_bug.cgi?id=105264
+
+Reviewed by Tony Chang.
+
+Add test to check when the source of images with percentage min-width is changed.
+
+* fast/css/percent-min-width-img-src-change-expected.txt: Added.
+* fast/css/percent-min-width-img-src-change.html: Added.
+
2012-12-20 Ryosuke Niwa rn...@webkit.org
Add Mac test expectations for the bug 73865.
Added: trunk/LayoutTests/fast/css/percent-min-width-img-src-change-expected.txt (0 => 138332)
--- trunk/LayoutTests/fast/css/percent-min-width-img-src-change-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/percent-min-width-img-src-change-expected.txt 2012-12-21 01:52:05 UTC (rev 138332)
@@ -0,0 +1,2 @@
+PASS
+
Added: trunk/LayoutTests/fast/css/percent-min-width-img-src-change.html (0 => 138332)
--- trunk/LayoutTests/fast/css/percent-min-width-img-src-change.html (rev 0)
+++ trunk/LayoutTests/fast/css/percent-min-width-img-src-change.html 2012-12-21 01:52:05 UTC (rev 138332)
@@ -0,0 +1,48 @@
+!DOCTYPE html
+html
+head
+script type=text/_javascript_
+var completed = 0, failures = 0, failuresDetail = ;
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+function printResult() {
+document.getElementById(result).innerText = failures ? FAIL: + failures + cases failed\n + failuresDetail : PASS;
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+function imageCheckForMin(image) {
+if (image.src.match(greenbox-100px.png) != null) {
+image.src = ""
+}
+else {
+++completed;
+if (image.width != 25) {
+++failures;
+failuresDetail += image.id + : + image.width + (expected: + 25 + )\n;
+}
+if (completed == 2)
+ printResult();
+}
+}
+/script
+/head
+
+body
+div id=result/div
+table
+tbody
+tr
+td
+img id=percentMinWidthInTable style=min-width:100%; src="" _onload_=imageCheckForMin(this)
+/td
+/tr
+/tbody
+/table
+div style=position:absolute;top:200px;left:11px
+img
[webkit-changes] [138333] trunk/LayoutTests
Title: [138333] trunk/LayoutTests Revision 138333 Author t...@chromium.org Date 2012-12-20 18:03:36 -0800 (Thu, 20 Dec 2012) Log Message [chromium] Unreviewed, mark a new test as failing on Chromium Mac. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138332 => 138333) --- trunk/LayoutTests/ChangeLog 2012-12-21 01:52:05 UTC (rev 138332) +++ trunk/LayoutTests/ChangeLog 2012-12-21 02:03:36 UTC (rev 138333) @@ -1,3 +1,9 @@ +2012-12-20 Tony Chang t...@chromium.org + +[chromium] Unreviewed, mark a new test as failing on Chromium Mac. + +* platform/chromium/TestExpectations: + 2012-12-20 KyungTae Kim ktf@samsung.com Percentage min/max width replaced element may incorrectly rendered Modified: trunk/LayoutTests/platform/chromium/TestExpectations (138332 => 138333) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-21 01:52:05 UTC (rev 138332) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-21 02:03:36 UTC (rev 138333) @@ -4270,3 +4270,4 @@ webkit.org/b/105471 [ Win ] platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting.html webkit.org/b/105471 [ Win ] platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content.html +webkit.org/b/105595 [ Mac ] svg/text/alt-glyph-for-surrogate-pair.svg [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138335] trunk/LayoutTests
Title: [138335] trunk/LayoutTests Revision 138335 Author rn...@webkit.org Date 2012-12-20 18:18:21 -0800 (Thu, 20 Dec 2012) Log Message Add another Mac test expectations for the bug 73865. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138334 => 138335) --- trunk/LayoutTests/ChangeLog 2012-12-21 02:09:54 UTC (rev 138334) +++ trunk/LayoutTests/ChangeLog 2012-12-21 02:18:21 UTC (rev 138335) @@ -1,3 +1,9 @@ +2012-12-20 Ryosuke Niwa rn...@webkit.org + +Add another Mac test expectations for the bug 73865. + +* platform/mac/TestExpectations: + 2012-12-20 Rik Cabanier caban...@adobe.com Add canvas blending modes using Core Graphics Modified: trunk/LayoutTests/platform/mac/TestExpectations (138334 => 138335) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-21 02:09:54 UTC (rev 138334) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-21 02:18:21 UTC (rev 138335) @@ -1263,6 +1263,7 @@ webkit.org/b/73865 media/track/tracklist-is-reachable.html [ Crash Pass ] webkit.org/b/73865 media/track/text-track-cue-is-reachable.html [ Crash Pass ] webkit.org/b/73865 media/track/text-track-is-reachable.html [ Crash Pass ] +webkit.org/b/73865 media/track/track-webvtt-tc005-header-comment.html [ Crash Pass ] webkit.org/b/105567 http/tests/security/data-url-inline.css.html [ Crash Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
