[webkit-changes] [140905] trunk/Source/WebKit2

2013-01-25 Thread christophe . dumez 
Title: [140905] trunk/Source/WebKit2








Revision 140905
Author christophe.du...@intel.com
Date 2013-01-25 23:59:35 -0800 (Fri, 25 Jan 2013)


Log Message
[EFL][WK2] Use C API inside ewk_database_manager and ewk_storage_manager
https://bugs.webkit.org/show_bug.cgi?id=107920

Reviewed by Benjamin Poulain.

Use C API inside ewk_database_manager and ewk_storage_manager instead
of accessing internal C++ classes directly, to avoid violating API
layering.

* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
* UIProcess/API/efl/ewk_database_manager.cpp:
(EwkDatabaseManager::EwkDatabaseManager):
(EwkDatabaseManager::getDatabaseOrigins):
* UIProcess/API/efl/ewk_database_manager_private.h:
(EwkDatabaseManager::create):
(EwkDatabaseManager):
* UIProcess/API/efl/ewk_storage_manager.cpp:
(EwkStorageManager::EwkStorageManager):
(EwkStorageManager::getStorageOrigins):
* UIProcess/API/efl/ewk_storage_manager_private.h:
(EwkStorageManager::create):
(EwkStorageManager):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_database_manager.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_database_manager_private.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager_private.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (140904 => 140905)

--- trunk/Source/WebKit2/ChangeLog	2013-01-26 06:07:23 UTC (rev 140904)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-26 07:59:35 UTC (rev 140905)
@@ -1,3 +1,29 @@
+2013-01-25  Christophe Dumez  
+
+[EFL][WK2] Use C API inside ewk_database_manager and ewk_storage_manager
+https://bugs.webkit.org/show_bug.cgi?id=107920
+
+Reviewed by Benjamin Poulain.
+
+Use C API inside ewk_database_manager and ewk_storage_manager instead
+of accessing internal C++ classes directly, to avoid violating API
+layering.
+
+* UIProcess/API/efl/ewk_context.cpp:
+(EwkContext::EwkContext):
+* UIProcess/API/efl/ewk_database_manager.cpp:
+(EwkDatabaseManager::EwkDatabaseManager):
+(EwkDatabaseManager::getDatabaseOrigins):
+* UIProcess/API/efl/ewk_database_manager_private.h:
+(EwkDatabaseManager::create):
+(EwkDatabaseManager):
+* UIProcess/API/efl/ewk_storage_manager.cpp:
+(EwkStorageManager::EwkStorageManager):
+(EwkStorageManager::getStorageOrigins):
+* UIProcess/API/efl/ewk_storage_manager_private.h:
+(EwkStorageManager::create):
+(EwkStorageManager):
+
 2013-01-25  Andreas Kling  
 
 [Mac] Defer loading the Web Inspector bundle until it's necessary.


Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp (140904 => 140905)

--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp	2013-01-26 06:07:23 UTC (rev 140904)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp	2013-01-26 07:59:35 UTC (rev 140905)
@@ -26,6 +26,7 @@
 #include "NetworkInfoProvider.h"
 #include "RequestManagerClientEfl.h"
 #include "WKAPICast.h"
+#include "WKContext.h"
 #include "WKContextSoup.h"
 #include "WKNumber.h"
 #include "WKRetainPtr.h"
@@ -65,8 +66,8 @@
 
 EwkContext::EwkContext(PassRefPtr context)
 : m_context(context)
-, m_databaseManager(EwkDatabaseManager::create(m_context))
-, m_storageManager(EwkStorageManager::create(m_context))
+, m_databaseManager(EwkDatabaseManager::create(WKContextGetDatabaseManager(toAPI(m_context.get()
+, m_storageManager(EwkStorageManager::create(WKContextGetKeyValueStorageManager(toAPI(m_context.get()
 #if ENABLE(BATTERY_STATUS)
 , m_batteryProvider(BatteryProvider::create(m_context))
 #endif


Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_database_manager.cpp (140904 => 140905)

--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_database_manager.cpp	2013-01-26 06:07:23 UTC (rev 140904)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_database_manager.cpp	2013-01-26 07:59:35 UTC (rev 140905)
@@ -28,21 +28,21 @@
 
 #include "WKAPICast.h"
 #include "WKArray.h"
-#include "WKDatabaseManager.h"
-#include "WebDatabaseManagerProxy.h"
 #include "ewk_database_manager_private.h"
 #include "ewk_error_private.h"
 #include "ewk_security_origin_private.h"
 
 using namespace WebKit;
 
-EwkDatabaseManager::EwkDatabaseManager(WebDatabaseManagerProxy* databaseManager)
+EwkDatabaseManager::EwkDatabaseManager(WKDatabaseManagerRef databaseManager)
 : m_databaseManager(databaseManager)
-{ }
+{
+ASSERT(databaseManager);
+}
 
 void EwkDatabaseManager::getDatabaseOrigins(WKDatabaseManagerGetDatabaseOriginsFunction callback, void* context) const
 {
-WKDatabaseManagerGetDatabaseOrigins(toAPI(m_databaseManager.get()), context, callback);
+WKDatabaseManagerGetDatabaseOrigins(m_databaseManager.get(), context, callback);
 }
 
 Eina_List* EwkDatabaseManager::createOriginList(WKArrayRef origins) const


Modified: trunk/Source/W

[webkit-changes] [140903] trunk/Source/WebKit2

2013-01-25 Thread akling 
Title: [140903] trunk/Source/WebKit2








Revision 140903
Author akl...@apple.com
Date 2013-01-25 21:42:07 -0800 (Fri, 25 Jan 2013)


Log Message
[Mac] Defer loading the Web Inspector bundle until it's necessary.



Reviewed by Anders Carlsson.

Don't instantiate an NSBundle for the Web Inspector before it's needed.
1.51MB progression on Membuster3.

* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::WebInspector):
* WebProcess/WebPage/WebInspector.h:
(WebInspector):
* WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::WebInspector::setInspectorUsesWebKitUserInterface):
(WebKit::WebInspector::localizedStringsURL):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/WebInspectorMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (140902 => 140903)

--- trunk/Source/WebKit2/ChangeLog	2013-01-26 05:23:36 UTC (rev 140902)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-26 05:42:07 UTC (rev 140903)
@@ -1,3 +1,22 @@
+2013-01-25  Andreas Kling  
+
+[Mac] Defer loading the Web Inspector bundle until it's necessary.
+
+
+
+Reviewed by Anders Carlsson.
+
+Don't instantiate an NSBundle for the Web Inspector before it's needed.
+1.51MB progression on Membuster3.
+
+* WebProcess/WebPage/WebInspector.cpp:
+(WebKit::WebInspector::WebInspector):
+* WebProcess/WebPage/WebInspector.h:
+(WebInspector):
+* WebProcess/WebPage/mac/WebInspectorMac.mm:
+(WebKit::WebInspector::setInspectorUsesWebKitUserInterface):
+(WebKit::WebInspector::localizedStringsURL):
+
 2013-01-25  Gyuyoung Kim  
 
 [EFL][WK2] Fix build break after r140891.


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp (140902 => 140903)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp	2013-01-26 05:23:36 UTC (rev 140902)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp	2013-01-26 05:42:07 UTC (rev 140903)
@@ -51,6 +51,10 @@
 , m_inspectorPage(0)
 , m_frontendClient(0)
 , m_frontendChannel(frontendChannel)
+#if PLATFORM(MAC)
+, m_hasLocalizedStringsURL(false)
+, m_usesWebKitUserInterface(false)
+#endif
 #if ENABLE(INSPECTOR_SERVER)
 , m_remoteFrontendConnected(false)
 #endif


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h (140902 => 140903)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h	2013-01-26 05:23:36 UTC (rev 140902)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h	2013-01-26 05:42:07 UTC (rev 140903)
@@ -124,7 +124,9 @@
 WebInspectorFrontendClient* m_frontendClient;
 WebCore::InspectorFrontendChannel* m_frontendChannel;
 #if PLATFORM(MAC)
-String m_localizedStringsURL;
+mutable String m_localizedStringsURL;
+mutable bool m_hasLocalizedStringsURL;
+bool m_usesWebKitUserInterface;
 #endif
 #if ENABLE(INSPECTOR_SERVER)
 bool m_remoteFrontendConnected;


Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WebInspectorMac.mm (140902 => 140903)

--- trunk/Source/WebKit2/WebProcess/WebPage/mac/WebInspectorMac.mm	2013-01-26 05:23:36 UTC (rev 140902)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WebInspectorMac.mm	2013-01-26 05:42:07 UTC (rev 140903)
@@ -50,16 +50,24 @@
 
 void WebInspector::setInspectorUsesWebKitUserInterface(bool flag)
 {
-NSString *bundleIdentifier = inspectorReallyUsesWebKitUserInterface(flag) ? @"com.apple.WebCore" : @"com.apple.WebInspector";
-NSString *path = [[NSBundle bundleWithIdentifier:bundleIdentifier] pathForResource:@"localizedStrings" ofType:@"js"];
-if ([path length])
-m_localizedStringsURL = [[NSURL fileURLWithPath:path] absoluteString];
-else
-m_localizedStringsURL = String();
+if (m_usesWebKitUserInterface == flag)
+return;
+
+m_usesWebKitUserInterface = flag;
+m_hasLocalizedStringsURL = false;
 }
 
 String WebInspector::localizedStringsURL() const
 {
+if (!m_hasLocalizedStringsURL) {
+NSString *bundleIdentifier = inspectorReallyUsesWebKitUserInterface(m_usesWebKitUserInterface) ? @"com.apple.WebCore" : @"com.apple.WebInspector";
+NSString *path = [[NSBundle bundleWithIdentifier:bundleIdentifier] pathForResource:@"localizedStrings" ofType:@"js"];
+if ([path length])
+m_localizedStringsURL = [[NSURL fileURLWithPath:path] absoluteString];
+else
+m_localizedStringsURL = String();
+m_hasLocalizedStringsURL = true;
+}
 return m_localizedStringsURL;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140901] trunk/Source/WebKit2

2013-01-25 Thread mrowe 
Title: [140901] trunk/Source/WebKit2








Revision 140901
Author mr...@apple.com
Date 2013-01-25 20:06:17 -0800 (Fri, 25 Jan 2013)


Log Message
Don't crash when the WKBundlePageUIClient doesn't implement createPlugInExtraStyleSheet.

Reviewed by Dean Jackson.

* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::plugInExtraStyleSheet): Check that createPlugInExtraStyleSheet
is provided before calling it.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (140900 => 140901)

--- trunk/Source/WebKit2/ChangeLog	2013-01-26 03:50:14 UTC (rev 140900)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-26 04:06:17 UTC (rev 140901)
@@ -1,3 +1,13 @@
+2013-01-25  Mark Rowe  
+
+Don't crash when the WKBundlePageUIClient doesn't implement createPlugInExtraStyleSheet.
+
+Reviewed by Dean Jackson.
+
+* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
+(WebKit::InjectedBundlePageUIClient::plugInExtraStyleSheet): Check that createPlugInExtraStyleSheet
+is provided before calling it.
+
 2013-01-25  Andy Estes  
 
 Wrap content filtering code in an object


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp (140900 => 140901)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp	2013-01-26 03:50:14 UTC (rev 140900)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp	2013-01-26 04:06:17 UTC (rev 140901)
@@ -195,6 +195,9 @@
 
 String InjectedBundlePageUIClient::plugInExtraStyleSheet() const
 {
+if (!m_client.createPlugInExtraStyleSheet)
+return String();
+
 RefPtr styleSheet = adoptRef(toImpl(m_client.createPlugInExtraStyleSheet(m_client.clientInfo)));
 return styleSheet ? styleSheet->string() : String();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140900] trunk/Source

2013-01-25 Thread roger_fong 
Title: [140900] trunk/Source








Revision 140900
Author roger_f...@apple.com
Date 2013-01-25 19:50:14 -0800 (Fri, 25 Jan 2013)


Log Message
Unreviewed. Rename LLInt projects folder and make appropriate changes to solutions.

* _javascript_Core.vcxproj/_javascript_Core.sln:
* _javascript_Core.vcxproj/LLInt: Copied from _javascript_Core.vcxproj/LLInt.vcproj.
* _javascript_Core.vcxproj/LLInt.vcproj: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntAssembly: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.make: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.vcxproj: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.vcxproj.user: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntAssembly/build-LLIntAssembly.sh: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntDesiredOffsets: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.make: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj.user: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj.user: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.props: Removed.
* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorRelease.props: Removed.
* WebKit.vcxproj/WebKit.sln:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.sln
trunk/Source/WTF/WTF.vcxproj/WTFCommon.props
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.vcxproj/WebKit.sln


Added Paths

trunk/Source/_javascript_Core/_javascript_Core.vcxproj/LLInt/


Removed Paths

trunk/Source/_javascript_Core/_javascript_Core.vcxproj/LLInt.vcproj/




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (140899 => 140900)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-26 02:58:46 UTC (rev 140899)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-26 03:50:14 UTC (rev 140900)
@@ -1,3 +1,27 @@
+2013-01-25  Roger Fong  
+
+Unreviewed. Rename LLInt projects folder and make appropriate changes to solutions.
+
+* _javascript_Core.vcxproj/_javascript_Core.sln:
+* _javascript_Core.vcxproj/LLInt: Copied from _javascript_Core.vcxproj/LLInt.vcproj.
+* _javascript_Core.vcxproj/LLInt.vcproj: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntAssembly: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.make: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.vcxproj: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.vcxproj.user: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntAssembly/build-LLIntAssembly.sh: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntDesiredOffsets: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.make: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj.user: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj.user: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.props: Removed.
+* _javascript_Core.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorRelease.props: Removed.
+
 2013-01-24  Roger Fong  
 
 VS2010 _javascript_Core: Clean up property sheets, add a JSC solution, add testRegExp and testAPI projects.


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.sln (140899 => 140900)

--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.sln	2013-01-26 02:58:46 UTC (rev 140899)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.sln

[webkit-changes] [140899] trunk/Source/WebCore

2013-01-25 Thread roger_fong 
Title: [140899] trunk/Source/WebCore








Revision 140899
Author roger_f...@apple.com
Date 2013-01-25 18:58:46 -0800 (Fri, 25 Jan 2013)


Log Message
Unreviewed Windows build fix. All it wanted was one more line.

* css/plugIns.css:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/plugIns.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (140898 => 140899)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 02:13:26 UTC (rev 140898)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 02:58:46 UTC (rev 140899)
@@ -1,3 +1,9 @@
+2013-01-25  Roger Fong  
+
+Unreviewed Windows build fix. All it wanted was one more line.
+
+* css/plugIns.css:
+
 2013-01-25  Joone Hur  
 
 [GTK][AC] Use new Clutter APIs instead of deprecated APIs


Modified: trunk/Source/WebCore/css/plugIns.css (140898 => 140899)

--- trunk/Source/WebCore/css/plugIns.css	2013-01-26 02:13:26 UTC (rev 140898)
+++ trunk/Source/WebCore/css/plugIns.css	2013-01-26 02:58:46 UTC (rev 140899)
@@ -23,4 +23,4 @@
  */
 
 /* plug-ins */
-p{} /*Needed by Windows because it doesn't like empty files*/
\ No newline at end of file
+p{} /*Needed by Windows because it doesn't like empty files*/






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140897] tags/Safari-537.28.1/

2013-01-25 Thread lforschler 
Title: [140897] tags/Safari-537.28.1/








Revision 140897
Author lforsch...@apple.com
Date 2013-01-25 18:11:36 -0800 (Fri, 25 Jan 2013)


Log Message
New Tag.

Added Paths

tags/Safari-537.28.1/




Diff

Property changes: tags/Safari-537.28.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140898] tags/Safari-537.28.1/Source

2013-01-25 Thread lforschler 
Title: [140898] tags/Safari-537.28.1/Source








Revision 140898
Author lforsch...@apple.com
Date 2013-01-25 18:13:26 -0800 (Fri, 25 Jan 2013)


Log Message
Versioning.

Modified Paths

tags/Safari-537.28.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-537.28.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-537.28.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-537.28.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-537.28.1/Source/_javascript_Core/Configurations/Version.xcconfig (140897 => 140898)

--- tags/Safari-537.28.1/Source/_javascript_Core/Configurations/Version.xcconfig	2013-01-26 02:11:36 UTC (rev 140897)
+++ tags/Safari-537.28.1/Source/_javascript_Core/Configurations/Version.xcconfig	2013-01-26 02:13:26 UTC (rev 140898)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 28;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-537.28.1/Source/WebCore/Configurations/Version.xcconfig (140897 => 140898)

--- tags/Safari-537.28.1/Source/WebCore/Configurations/Version.xcconfig	2013-01-26 02:11:36 UTC (rev 140897)
+++ tags/Safari-537.28.1/Source/WebCore/Configurations/Version.xcconfig	2013-01-26 02:13:26 UTC (rev 140898)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 28;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-537.28.1/Source/WebKit/mac/Configurations/Version.xcconfig (140897 => 140898)

--- tags/Safari-537.28.1/Source/WebKit/mac/Configurations/Version.xcconfig	2013-01-26 02:11:36 UTC (rev 140897)
+++ tags/Safari-537.28.1/Source/WebKit/mac/Configurations/Version.xcconfig	2013-01-26 02:13:26 UTC (rev 140898)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 28;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-537.28.1/Source/WebKit2/Configurations/Version.xcconfig (140897 => 140898)

--- tags/Safari-537.28.1/Source/WebKit2/Configurations/Version.xcconfig	2013-01-26 02:11:36 UTC (rev 140897)
+++ tags/Safari-537.28.1/Source/WebKit2/Configurations/Version.xcconfig	2013-01-26 02:13:26 UTC (rev 140898)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 28;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140895] trunk/Source/WebCore

2013-01-25 Thread roger_fong 
Title: [140895] trunk/Source/WebCore








Revision 140895
Author roger_f...@apple.com
Date 2013-01-25 18:03:37 -0800 (Fri, 25 Jan 2013)


Log Message
Unreviewed build fix for Windows.

* css/plugIns.css:
(p):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/plugIns.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (140894 => 140895)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 01:52:12 UTC (rev 140894)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 02:03:37 UTC (rev 140895)
@@ -1,3 +1,10 @@
+2013-01-25  Roger Fong  
+
+Unreviewed build fix for Windows.
+
+* css/plugIns.css:
+(p):
+
 2013-01-25  Julien Chaffraix  
 
 Share code between the different min-content / max-content code paths


Modified: trunk/Source/WebCore/css/plugIns.css (140894 => 140895)

--- trunk/Source/WebCore/css/plugIns.css	2013-01-26 01:52:12 UTC (rev 140894)
+++ trunk/Source/WebCore/css/plugIns.css	2013-01-26 02:03:37 UTC (rev 140895)
@@ -23,4 +23,4 @@
  */
 
 /* plug-ins */
-object{} /*Needed by Windows because it doesn't like empty files*/
\ No newline at end of file
+p{} /*Needed by Windows because it doesn't like empty files*/
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140894] trunk/Source/WebCore

2013-01-25 Thread jchaffraix 
Title: [140894] trunk/Source/WebCore








Revision 140894
Author jchaffr...@webkit.org
Date 2013-01-25 17:52:12 -0800 (Fri, 25 Jan 2013)


Log Message
Share code between the different min-content / max-content code paths
https://bugs.webkit.org/show_bug.cgi?id=107740

Reviewed by Tony Chang.

This change enables sharing between the different content based computations
by using function pointers to specialize the behavior as needed.

Refactoring, covered by existing tests.

* rendering/RenderGrid.cpp:
(WebCore::GridTrack::growUsedBreadth):
(WebCore::GridTrack::usedBreadth):
(WebCore::GridTrack::growMaxBreadth):
Added the previous getters / setters that will be passed to resolveContentBasedTrackSizingFunctionsForItems.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Updated to reuse resolveContentBasedTrackSizingFunctionsForItems instead of duplicating code.
One change is that now, we properly apply the min on all branches, which was an oversight of
the previous patches.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Added this function as the core content-sized resolution function. For now, we pass the
current track by direction & index to be able to filter grid items.

* rendering/RenderGrid.h:
Added resolveContentBasedTrackSizingFunctionsForItems and the function pointers typedef's.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (140893 => 140894)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 01:42:02 UTC (rev 140893)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 01:52:12 UTC (rev 140894)
@@ -1,3 +1,33 @@
+2013-01-25  Julien Chaffraix  
+
+Share code between the different min-content / max-content code paths
+https://bugs.webkit.org/show_bug.cgi?id=107740
+
+Reviewed by Tony Chang.
+
+This change enables sharing between the different content based computations
+by using function pointers to specialize the behavior as needed.
+
+Refactoring, covered by existing tests.
+
+* rendering/RenderGrid.cpp:
+(WebCore::GridTrack::growUsedBreadth):
+(WebCore::GridTrack::usedBreadth):
+(WebCore::GridTrack::growMaxBreadth):
+Added the previous getters / setters that will be passed to resolveContentBasedTrackSizingFunctionsForItems.
+
+(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
+Updated to reuse resolveContentBasedTrackSizingFunctionsForItems instead of duplicating code.
+One change is that now, we properly apply the min on all branches, which was an oversight of
+the previous patches.
+
+(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
+Added this function as the core content-sized resolution function. For now, we pass the
+current track by direction & index to be able to filter grid items.
+
+* rendering/RenderGrid.h:
+Added resolveContentBasedTrackSizingFunctionsForItems and the function pointers typedef's.
+
 2013-01-25  Kentaro Hara  
 
 Remove InjectedScript::wrapSerializedObject()


Modified: trunk/Source/WebCore/rendering/RenderGrid.cpp (140893 => 140894)

--- trunk/Source/WebCore/rendering/RenderGrid.cpp	2013-01-26 01:42:02 UTC (rev 140893)
+++ trunk/Source/WebCore/rendering/RenderGrid.cpp	2013-01-26 01:52:12 UTC (rev 140894)
@@ -43,6 +43,20 @@
 {
 }
 
+void growUsedBreadth(LayoutUnit growth)
+{
+ASSERT(growth >= 0);
+m_usedBreadth += growth;
+}
+LayoutUnit usedBreadth() const { return m_usedBreadth; }
+
+void growMaxBreadth(LayoutUnit growth)
+{
+if (m_maxBreadth == infinity)
+m_maxBreadth = m_usedBreadth + growth;
+else
+m_maxBreadth += growth;
+}
 LayoutUnit maxBreadthIfNotInfinite() const
 {
 return (m_maxBreadth == infinity) ? m_usedBreadth : m_maxBreadth;
@@ -272,67 +286,45 @@
 GridTrack& track = tracks[i];
 const Length& minTrackBreadth = trackStyles[i].minTrackBreadth();
 if (minTrackBreadth.isMinContent() || minTrackBreadth.isMaxContent()) {
-// FIXME: The specification factors this logic into resolveContentBasedTrackSizingFunctionsForItems
-// to reuse code between the branches and also calls distributeSpaceToTracks.
-for (RenderBox* child = firstChildBox(); child; child = child->nextSiblingBox()) {
-size_t cellIndex = resolveGridPosition(direction, child);
-if (cellIndex != i)
-continue;
-
-LayoutUnit additionalBreadthSpace = minContentForChild(child, direction, columnTracks) - track.m_usedBreadth;
-ASSERT(additionalBreadthSpace >= 0);
-track.m_usedBreadth += additionalBreadthSpace;
-availableLogicalSpace -= additionalBreadthSpa

[webkit-changes] [140893] trunk/Source/WebCore

2013-01-25 Thread haraken 
Title: [140893] trunk/Source/WebCore








Revision 140893
Author hara...@chromium.org
Date 2013-01-25 17:42:02 -0800 (Fri, 25 Jan 2013)


Log Message
Remove InjectedScript::wrapSerializedObject()
https://bugs.webkit.org/show_bug.cgi?id=107906

Reviewed by Abhishek Arya.

InjectedScript::wrapSerializedObject() is unused.
(This is one of steps to remove raw pointers of SerializedScriptValue*,
which can be a security concern.)

* inspector/InjectedScript.cpp:
* inspector/InjectedScript.h:
(InjectedScript):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScript.cpp
trunk/Source/WebCore/inspector/InjectedScript.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (140892 => 140893)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 01:38:05 UTC (rev 140892)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 01:42:02 UTC (rev 140893)
@@ -1,5 +1,20 @@
 2013-01-25  Kentaro Hara  
 
+Remove InjectedScript::wrapSerializedObject()
+https://bugs.webkit.org/show_bug.cgi?id=107906
+
+Reviewed by Abhishek Arya.
+
+InjectedScript::wrapSerializedObject() is unused.
+(This is one of steps to remove raw pointers of SerializedScriptValue*,
+which can be a security concern.)
+
+* inspector/InjectedScript.cpp:
+* inspector/InjectedScript.h:
+(InjectedScript):
+
+2013-01-25  Kentaro Hara  
+
 Keep a RefPtr when we call serialize()/deserialize() in code generators
 https://bugs.webkit.org/show_bug.cgi?id=107902
 


Modified: trunk/Source/WebCore/inspector/InjectedScript.cpp (140892 => 140893)

--- trunk/Source/WebCore/inspector/InjectedScript.cpp	2013-01-26 01:38:05 UTC (rev 140892)
+++ trunk/Source/WebCore/inspector/InjectedScript.cpp	2013-01-26 01:42:02 UTC (rev 140893)
@@ -222,12 +222,6 @@
 return wrapObject(nodeAsScriptValue(node), groupName);
 }
 
-PassRefPtr InjectedScript::wrapSerializedObject(SerializedScriptValue* serializedScriptValue, const String& groupName) const
-{
-ScriptValue scriptValue = serializedScriptValue->deserializeForInspector(scriptState());
-return scriptValue.hasNoValue() ? 0 : wrapObject(scriptValue, groupName);
-}
-
 ScriptValue InjectedScript::findObjectById(const String& objectId) const
 {
 ASSERT(!hasNoValue());


Modified: trunk/Source/WebCore/inspector/InjectedScript.h (140892 => 140893)

--- trunk/Source/WebCore/inspector/InjectedScript.h	2013-01-26 01:38:05 UTC (rev 140892)
+++ trunk/Source/WebCore/inspector/InjectedScript.h	2013-01-26 01:42:02 UTC (rev 140893)
@@ -92,7 +92,6 @@
 
 PassRefPtr wrapObject(const ScriptValue&, const String& groupName, bool generatePreview = false) const;
 PassRefPtr wrapNode(Node*, const String& groupName);
-PassRefPtr wrapSerializedObject(SerializedScriptValue*, const String& groupName) const;
 ScriptValue findObjectById(const String& objectId) const;
 
 void inspectNode(Node*);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140892] trunk/Source/WebCore

2013-01-25 Thread haraken 
Title: [140892] trunk/Source/WebCore








Revision 140892
Author hara...@chromium.org
Date 2013-01-25 17:38:05 -0800 (Fri, 25 Jan 2013)


Log Message
Keep a RefPtr when we call serialize()/deserialize() in code generators
https://bugs.webkit.org/show_bug.cgi?id=107902

Reviewed by Abhishek Arya.

If you use a raw SerializedScriptValue* for serialize()/deserialize(),
it can potentially cause a use-after-free. This is because serialize()/
deserialize() can destruct a RefPtr of the SerializedScriptValue*,
depending on data that is serialized/deserialized. So we should keep a
RefPtr when we call serialize()/deserialize().
(See https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)

No tests. This is just a just-in-case fix.

* Modules/intents/Intent.h:
(WebCore::Intent::data):
* Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):
* Modules/intents/IntentRequest.h:
(IntentRequest):
* Modules/intents/IntentResultCallback.h:
(IntentResultCallback):
* bindings/scripts/CodeGeneratorJS.pm:
(GetNativeTypeForCallbacks):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GetNativeTypeForCallbacks):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
* dom/MessagePortChannel.h:
(WebCore::MessagePortChannel::EventData::message):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/intents/Intent.h
trunk/Source/WebCore/Modules/intents/IntentRequest.cpp
trunk/Source/WebCore/Modules/intents/IntentRequest.h
trunk/Source/WebCore/Modules/intents/IntentResultCallback.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp
trunk/Source/WebCore/dom/MessagePortChannel.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (140891 => 140892)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 01:36:40 UTC (rev 140891)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 01:38:05 UTC (rev 140892)
@@ -1,5 +1,41 @@
 2013-01-25  Kentaro Hara  
 
+Keep a RefPtr when we call serialize()/deserialize() in code generators
+https://bugs.webkit.org/show_bug.cgi?id=107902
+
+Reviewed by Abhishek Arya.
+
+If you use a raw SerializedScriptValue* for serialize()/deserialize(),
+it can potentially cause a use-after-free. This is because serialize()/
+deserialize() can destruct a RefPtr of the SerializedScriptValue*,
+depending on data that is serialized/deserialized. So we should keep a
+RefPtr when we call serialize()/deserialize().
+(See https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)
+
+No tests. This is just a just-in-case fix.
+
+* Modules/intents/Intent.h:
+(WebCore::Intent::data):
+* Modules/intents/IntentRequest.cpp:
+(WebCore::IntentRequest::postResult):
+(WebCore::IntentRequest::postFailure):
+* Modules/intents/IntentRequest.h:
+(IntentRequest):
+* Modules/intents/IntentResultCallback.h:
+(IntentResultCallback):
+* bindings/scripts/CodeGeneratorJS.pm:
+(GetNativeTypeForCallbacks):
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateNormalAttrGetter):
+(GetNativeTypeForCallbacks):
+* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
+(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
+(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
+* dom/MessagePortChannel.h:
+(WebCore::MessagePortChannel::EventData::message):
+
+2013-01-25  Kentaro Hara  
+
 Keep a RefPtr when we call serialize()/deserialize() for MessageEvent
 https://bugs.webkit.org/show_bug.cgi?id=107900
 


Modified: trunk/Source/WebCore/Modules/intents/Intent.h (140891 => 140892)

--- trunk/Source/WebCore/Modules/intents/Intent.h	2013-01-26 01:36:40 UTC (rev 140891)
+++ trunk/Source/WebCore/Modules/intents/Intent.h	2013-01-26 01:38:05 UTC (rev 140892)
@@ -36,6 +36,7 @@
 #include "MessagePort.h"
 #include "MessagePortChannel.h"
 #include "ScriptState.h"
+#include "SerializedScriptValue.h"
 #include 
 #include 
 #include 
@@ -45,8 +46,6 @@
 
 namespace WebCore {
 
-class SerializedScriptValue;
-
 typedef int ExceptionCode;
 
 class Intent : public RefCounted {
@@ -58,7 +57,7 @@
 
 const String& action() const { return m_action; }
 const String& type() const { return m_type; }
-SerializedScriptValue* data() const { return m_data.get(); }
+PassRefPtr data() const { return m_data; }
 
 MessagePortChannelArray* messagePorts() const { return m_ports.get(); }
 const KURL& service() const { return m

[webkit-changes] [140891] trunk/Source/WebCore

2013-01-25 Thread haraken 
Title: [140891] trunk/Source/WebCore








Revision 140891
Author hara...@chromium.org
Date 2013-01-25 17:36:40 -0800 (Fri, 25 Jan 2013)


Log Message
Keep a RefPtr when we call serialize()/deserialize() for MessageEvent
https://bugs.webkit.org/show_bug.cgi?id=107900

Reviewed by Abhishek Arya.

If you use a raw SerializedScriptValue* for serialize()/deserialize(),
it can potentially cause a use-after-free. This is because serialize()/
deserialize() can destruct a RefPtr of the SerializedScriptValue*,
depending on data that is serialized/deserialized. So we should keep a
RefPtr when we call serialize()/deserialize().
(See https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)

No tests. This is just a just-in-case fix. I couldn't find any bug
even in an ASAN build.

* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* dom/MessageEvent.h:
(WebCore::MessageEvent::dataAsSerializedScriptValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp
trunk/Source/WebCore/dom/MessageEvent.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (140890 => 140891)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 01:32:36 UTC (rev 140890)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 01:36:40 UTC (rev 140891)
@@ -1,5 +1,29 @@
 2013-01-25  Kentaro Hara  
 
+Keep a RefPtr when we call serialize()/deserialize() for MessageEvent
+https://bugs.webkit.org/show_bug.cgi?id=107900
+
+Reviewed by Abhishek Arya.
+
+If you use a raw SerializedScriptValue* for serialize()/deserialize(),
+it can potentially cause a use-after-free. This is because serialize()/
+deserialize() can destruct a RefPtr of the SerializedScriptValue*,
+depending on data that is serialized/deserialized. So we should keep a
+RefPtr when we call serialize()/deserialize().
+(See https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)
+
+No tests. This is just a just-in-case fix. I couldn't find any bug
+even in an ASAN build.
+
+* bindings/js/JSMessageEventCustom.cpp:
+(WebCore::JSMessageEvent::data):
+* bindings/v8/custom/V8MessageEventCustom.cpp:
+(WebCore::V8MessageEvent::dataAccessorGetter):
+* dom/MessageEvent.h:
+(WebCore::MessageEvent::dataAsSerializedScriptValue):
+
+2013-01-25  Kentaro Hara  
+
 [V8] Keep a RefPtr when we call serialize()/deserialize() (part 1)
 https://bugs.webkit.org/show_bug.cgi?id=107891
 


Modified: trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp (140890 => 140891)

--- trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp	2013-01-26 01:32:36 UTC (rev 140890)
+++ trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp	2013-01-26 01:36:40 UTC (rev 140891)
@@ -62,7 +62,7 @@
 }
 
 case MessageEvent::DataTypeSerializedScriptValue:
-if (SerializedScriptValue* serializedValue = event->dataAsSerializedScriptValue()) {
+if (RefPtr serializedValue = event->dataAsSerializedScriptValue()) {
 MessagePortArray* ports = static_cast(impl())->ports();
 result = serializedValue->deserialize(exec, globalObject(), ports, NonThrowing);
 }


Modified: trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp (140890 => 140891)

--- trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp	2013-01-26 01:32:36 UTC (rev 140890)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp	2013-01-26 01:36:40 UTC (rev 140891)
@@ -58,7 +58,7 @@
 }
 
 case MessageEvent::DataTypeSerializedScriptValue:
-if (SerializedScriptValue* serializedValue = event->dataAsSerializedScriptValue())
+if (RefPtr serializedValue = event->dataAsSerializedScriptValue())
 result = serializedValue->deserialize(info.GetIsolate(), event->ports());
 else
 result = v8Null(info.GetIsolate());


Modified: trunk/Source/WebCore/dom/MessageEvent.h (140890 => 140891)

--- trunk/Source/WebCore/dom/MessageEvent.h	2013-01-26 01:32:36 UTC (rev 140890)
+++ trunk/Source/WebCore/dom/MessageEvent.h	2013-01-26 01:36:40 UTC (rev 140891)
@@ -108,7 +108,7 @@
 };
 DataType dataType() const { return m_dataType; }
 const ScriptValue& dataAsScriptValue() const { ASSERT(m_dataType == DataTypeScriptValue); return m_dataAsScriptValue; }
-SerializedScriptValue* dataAsSerializedScriptValue() const { ASSERT(m_dataType == DataTypeSerializedScriptValue); return m_dataAsSerializedScriptValue.get(); }
+PassRefPtr dataAsSerializedScriptValue() const { ASSERT(m_dataType == DataTypeSerializedScriptValue); return m_dataAsSerializedScriptValue; }
 String dataAsString() const { ASSERT(m_dataType == DataTypeString); return m_dataAsString; }
 Blob* dat

[webkit-changes] [140890] tags/Safari-537.28/Source

2013-01-25 Thread lforschler 
Title: [140890] tags/Safari-537.28/Source








Revision 140890
Author lforsch...@apple.com
Date 2013-01-25 17:32:36 -0800 (Fri, 25 Jan 2013)


Log Message
Versioning.

Modified Paths

tags/Safari-537.28/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-537.28/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-537.28/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-537.28/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-537.28/Source/_javascript_Core/Configurations/Version.xcconfig (140889 => 140890)

--- tags/Safari-537.28/Source/_javascript_Core/Configurations/Version.xcconfig	2013-01-26 01:32:15 UTC (rev 140889)
+++ tags/Safari-537.28/Source/_javascript_Core/Configurations/Version.xcconfig	2013-01-26 01:32:36 UTC (rev 140890)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 27;
+MINOR_VERSION = 28;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: tags/Safari-537.28/Source/WebCore/Configurations/Version.xcconfig (140889 => 140890)

--- tags/Safari-537.28/Source/WebCore/Configurations/Version.xcconfig	2013-01-26 01:32:15 UTC (rev 140889)
+++ tags/Safari-537.28/Source/WebCore/Configurations/Version.xcconfig	2013-01-26 01:32:36 UTC (rev 140890)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 27;
+MINOR_VERSION = 28;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: tags/Safari-537.28/Source/WebKit/mac/Configurations/Version.xcconfig (140889 => 140890)

--- tags/Safari-537.28/Source/WebKit/mac/Configurations/Version.xcconfig	2013-01-26 01:32:15 UTC (rev 140889)
+++ tags/Safari-537.28/Source/WebKit/mac/Configurations/Version.xcconfig	2013-01-26 01:32:36 UTC (rev 140890)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 27;
+MINOR_VERSION = 28;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: tags/Safari-537.28/Source/WebKit2/Configurations/Version.xcconfig (140889 => 140890)

--- tags/Safari-537.28/Source/WebKit2/Configurations/Version.xcconfig	2013-01-26 01:32:15 UTC (rev 140889)
+++ tags/Safari-537.28/Source/WebKit2/Configurations/Version.xcconfig	2013-01-26 01:32:36 UTC (rev 140890)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 27;
+MINOR_VERSION = 28;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140889] trunk/Tools

2013-01-25 Thread jochen 
Title: [140889] trunk/Tools








Revision 140889
Author joc...@chromium.org
Date 2013-01-25 17:32:15 -0800 (Fri, 25 Jan 2013)


Log Message
[chromium] move tracking of the top loading frame to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=107948

Reviewed by Adam Barth.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::WorkQueue::processWorkSoon):
(DRTTestRunner::WorkQueue::processWork):
(DRTTestRunner::completeNotifyDone):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::setTopLoadingFrame):
(WebTestRunner::WebTestRunner::topLoadingFrame):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setTopLoadingFrame):
(WebTestRunner):
(WebTestRunner::TestRunner::topLoadingFrame):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
(WebTestRunner::TestRunner::locationChangeDone):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didFailLoad):
(WebTestRunner::WebTestProxyBase::didFinishLoad):
(WebTestRunner::WebTestProxyBase::locationChangeDone):
(WebTestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::reset):
(WebViewHost::updateURL):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Tools/ChangeLog (140888 => 140889)

--- trunk/Tools/ChangeLog	2013-01-26 01:29:06 UTC (rev 140888)
+++ trunk/Tools/ChangeLog	2013-01-26 01:32:15 UTC (rev 140889)
@@ -1,3 +1,43 @@
+2013-01-25  Jochen Eisinger  
+
+[chromium] move tracking of the top loading frame to TestRunner library
+https://bugs.webkit.org/show_bug.cgi?id=107948
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::WorkQueue::processWorkSoon):
+(DRTTestRunner::WorkQueue::processWork):
+(DRTTestRunner::completeNotifyDone):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+(DRTTestRunner):
+* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
+(WebTestProxyBase):
+* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
+(WebTestRunner::WebTestRunner::setTopLoadingFrame):
+(WebTestRunner::WebTestRunner::topLoadingFrame):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::reset):
+(WebTestRunner::TestRunner::setTopLoadingFrame):
+(WebTestRunner):
+(WebTestRunner::TestRunner::topLoadingFrame):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(TestRunner):
+(WebTestRunner::TestRunner::locationChangeDone):
+* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
+(WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
+(WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
+(WebTestRunner::WebTestProxyBase::didFailLoad):
+(WebTestRunner::WebTestProxyBase::didFinishLoad):
+(WebTestRunner::WebTestProxyBase::locationChangeDone):
+(WebTestRunner):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::reset):
+(WebViewHost::updateURL):
+* DumpRenderTree/chromium/WebViewHost.h:
+(WebViewHost):
+
 2013-01-25  Sheriff Bot  
 
 Unreviewed, rolling out r140774.


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (140888 => 140889)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-26 01:29:06 UTC (rev 140888)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-26 01:32:15 UTC (rev 140889)
@@ -120,7 +120,7 @@
 
 void DRTTestRunner::WorkQueue::processWorkSoon()
 {
-if (m_controller->m_shell->webViewHost()->topLoadingFrame())
+if (m_controller->topLoadingFrame())
 return;
 
 if (!m_queue.isEmpty()) {
@@ -141,7 +141,7 @@
 return;
 }
 
-if (!m_controller->m_waitUntilDone && !shell->webViewHost()->topLoadingFrame())
+if (!m_controller->m_waitUntilDone && !m_contro

[webkit-changes] [140888] tags/Safari-537.28/

2013-01-25 Thread lforschler 
Title: [140888] tags/Safari-537.28/








Revision 140888
Author lforsch...@apple.com
Date 2013-01-25 17:29:06 -0800 (Fri, 25 Jan 2013)


Log Message
New Tag.

Added Paths

tags/Safari-537.28/




Diff

Property changes: tags/Safari-537.28



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140887] trunk/Source/WebCore

2013-01-25 Thread haraken 
Title: [140887] trunk/Source/WebCore








Revision 140887
Author hara...@chromium.org
Date 2013-01-25 17:28:40 -0800 (Fri, 25 Jan 2013)


Log Message
[V8] Keep a RefPtr when we call serialize()/deserialize() (part 1)
https://bugs.webkit.org/show_bug.cgi?id=107891

Reviewed by Abhishek Arya.

If you use a raw SerializedScriptValue* for serialize()/deserialize(),
it can potentially cause a use-after-free. This is because serialize()/
deserialize() can destruct a RefPtr of the SerializedScriptValue*,
depending on data that is serialized/deserialized. So we should keep a
RefPtr when we call serialize()/deserialize().
(See https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)

No tests. This is just a just-in-case fix. I couldn't find any bug
even in an ASAN build.

* bindings/v8/custom/V8CustomEventCustom.cpp:
(WebCore::V8CustomEvent::detailAccessorGetter):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8CustomEventCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (140886 => 140887)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 01:26:08 UTC (rev 140886)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 01:28:40 UTC (rev 140887)
@@ -1,5 +1,25 @@
 2013-01-25  Kentaro Hara  
 
+[V8] Keep a RefPtr when we call serialize()/deserialize() (part 1)
+https://bugs.webkit.org/show_bug.cgi?id=107891
+
+Reviewed by Abhishek Arya.
+
+If you use a raw SerializedScriptValue* for serialize()/deserialize(),
+it can potentially cause a use-after-free. This is because serialize()/
+deserialize() can destruct a RefPtr of the SerializedScriptValue*,
+depending on data that is serialized/deserialized. So we should keep a
+RefPtr when we call serialize()/deserialize().
+(See https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)
+
+No tests. This is just a just-in-case fix. I couldn't find any bug
+even in an ASAN build.
+
+* bindings/v8/custom/V8CustomEventCustom.cpp:
+(WebCore::V8CustomEvent::detailAccessorGetter):
+
+2013-01-25  Kentaro Hara  
+
 Keep a RefPtr when we call serialize()/deserialize() in PopStateEvent
 https://bugs.webkit.org/show_bug.cgi?id=107904
 


Modified: trunk/Source/WebCore/bindings/v8/custom/V8CustomEventCustom.cpp (140886 => 140887)

--- trunk/Source/WebCore/bindings/v8/custom/V8CustomEventCustom.cpp	2013-01-26 01:26:08 UTC (rev 140886)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CustomEventCustom.cpp	2013-01-26 01:28:40 UTC (rev 140887)
@@ -49,7 +49,7 @@
 v8::Handle V8CustomEvent::detailAccessorGetter(v8::Local name, const v8::AccessorInfo& info)
 {
 CustomEvent* imp = V8CustomEvent::toNative(info.Holder());
-SerializedScriptValue* serialized = imp->serializedScriptValue().get();
+RefPtr serialized = imp->serializedScriptValue();
 if (serialized) {
 v8::Handle value = info.Holder()->GetHiddenValue(V8HiddenPropertyName::detail());
 if (value.IsEmpty()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140886] trunk/Source/WebCore

2013-01-25 Thread haraken 
Title: [140886] trunk/Source/WebCore








Revision 140886
Author hara...@chromium.org
Date 2013-01-25 17:26:08 -0800 (Fri, 25 Jan 2013)


Log Message
Keep a RefPtr when we call serialize()/deserialize() in PopStateEvent
https://bugs.webkit.org/show_bug.cgi?id=107904

Reviewed by Abhishek Arya.

If you use a raw SerializedScriptValue* for serialize()/deserialize(),
it can potentially cause a use-after-free. This is because serialize()/
deserialize() can destruct a RefPtr of the SerializedScriptValue*,
depending on data that is serialized/deserialized. So we should keep a
RefPtr when we call serialize()/deserialize().
(See https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)

No tests. This is just a just-in-case fix.

* dom/PopStateEvent.h:
(WebCore::PopStateEvent::serializedState):
* page/History.cpp:
(WebCore::History::isSameAsCurrentState):
* page/History.h:
(History):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/PopStateEvent.h
trunk/Source/WebCore/page/History.cpp
trunk/Source/WebCore/page/History.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (140885 => 140886)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 01:13:15 UTC (rev 140885)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 01:26:08 UTC (rev 140886)
@@ -1,5 +1,28 @@
 2013-01-25  Kentaro Hara  
 
+Keep a RefPtr when we call serialize()/deserialize() in PopStateEvent
+https://bugs.webkit.org/show_bug.cgi?id=107904
+
+Reviewed by Abhishek Arya.
+
+If you use a raw SerializedScriptValue* for serialize()/deserialize(),
+it can potentially cause a use-after-free. This is because serialize()/
+deserialize() can destruct a RefPtr of the SerializedScriptValue*,
+depending on data that is serialized/deserialized. So we should keep a
+RefPtr when we call serialize()/deserialize().
+(See https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)
+
+No tests. This is just a just-in-case fix.
+
+* dom/PopStateEvent.h:
+(WebCore::PopStateEvent::serializedState):
+* page/History.cpp:
+(WebCore::History::isSameAsCurrentState):
+* page/History.h:
+(History):
+
+2013-01-25  Kentaro Hara  
+
 Rename CodeGenerator::IsSubType() to CodeGenerator::InheritsInterface()
 https://bugs.webkit.org/show_bug.cgi?id=107874
 


Modified: trunk/Source/WebCore/dom/PopStateEvent.h (140885 => 140886)

--- trunk/Source/WebCore/dom/PopStateEvent.h	2013-01-26 01:13:15 UTC (rev 140885)
+++ trunk/Source/WebCore/dom/PopStateEvent.h	2013-01-26 01:26:08 UTC (rev 140886)
@@ -48,7 +48,7 @@
 static PassRefPtr create(PassRefPtr, PassRefPtr);
 static PassRefPtr create(const AtomicString&, const PopStateEventInit&);
 
-SerializedScriptValue* serializedState() const { return m_serializedState.get(); }
+PassRefPtr serializedState() const { return m_serializedState; }
 const ScriptValue& state() const { return m_state; }
 History* history() const { return m_history.get(); }
 


Modified: trunk/Source/WebCore/page/History.cpp (140885 => 140886)

--- trunk/Source/WebCore/page/History.cpp	2013-01-26 01:13:15 UTC (rev 140885)
+++ trunk/Source/WebCore/page/History.cpp	2013-01-26 01:26:08 UTC (rev 140886)
@@ -77,7 +77,7 @@
 return m_lastStateObjectRequested != stateInternal();
 }
 
-bool History::isSameAsCurrentState(SerializedScriptValue* state) const
+bool History::isSameAsCurrentState(PassRefPtr state) const
 {
 return state == stateInternal();
 }


Modified: trunk/Source/WebCore/page/History.h (140885 => 140886)

--- trunk/Source/WebCore/page/History.h	2013-01-26 01:13:15 UTC (rev 140885)
+++ trunk/Source/WebCore/page/History.h	2013-01-26 01:26:08 UTC (rev 140886)
@@ -55,7 +55,7 @@
 void go(ScriptExecutionContext*, int distance);
 
 bool stateChanged() const;
-bool isSameAsCurrentState(SerializedScriptValue*) const;
+bool isSameAsCurrentState(PassRefPtr) const;
 
 enum StateObjectType {
 StateObjectPush,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140885] trunk/LayoutTests

2013-01-25 Thread esprehn 
Title: [140885] trunk/LayoutTests








Revision 140885
Author espr...@chromium.org
Date 2013-01-25 17:13:15 -0800 (Fri, 25 Jan 2013)


Log Message
Make unload-reparent-sibling-frame.html wait for completion
https://bugs.webkit.org/show_bug.cgi?id=107987

Reviewed by Ojan Vafai.

While this test runs fine locally and in the cr-linux EWS it
appears to be flaky on many of the other bots because it doesn't
wait for the test to complete. Instead make the waiting in the test
explicit.

* fast/frames/unload-reparent-sibling-frame.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/frames/unload-reparent-sibling-frame.html




Diff

Modified: trunk/LayoutTests/ChangeLog (140884 => 140885)

--- trunk/LayoutTests/ChangeLog	2013-01-26 01:05:54 UTC (rev 140884)
+++ trunk/LayoutTests/ChangeLog	2013-01-26 01:13:15 UTC (rev 140885)
@@ -1,3 +1,17 @@
+2013-01-25  Elliott Sprehn  
+
+Make unload-reparent-sibling-frame.html wait for completion
+https://bugs.webkit.org/show_bug.cgi?id=107987
+
+Reviewed by Ojan Vafai.
+
+While this test runs fine locally and in the cr-linux EWS it
+appears to be flaky on many of the other bots because it doesn't
+wait for the test to complete. Instead make the waiting in the test
+explicit.
+
+* fast/frames/unload-reparent-sibling-frame.html:
+
 2013-01-25  Pan Deng  
 
 [User Timing] Class name of user timing entries should be PerformanceMark/PerformanceMeasure.


Modified: trunk/LayoutTests/fast/frames/unload-reparent-sibling-frame.html (140884 => 140885)

--- trunk/LayoutTests/fast/frames/unload-reparent-sibling-frame.html	2013-01-26 01:05:54 UTC (rev 140884)
+++ trunk/LayoutTests/fast/frames/unload-reparent-sibling-frame.html	2013-01-26 01:13:15 UTC (rev 140885)
@@ -4,48 +4,50 @@
 
 
 
+
+
 
 
 
 
 description('Reparented sibling frames from unload handlers should load.');
 
+var jsTestIsAsync = true;
+var count = 2;
+var container = document.getElementById('container');
+var inside = document.getElementById('inside');
+var frame1 = document.getElementById('frame1');
+var frame2 = document.getElementById('frame2');
+
 if (window.testRunner) {
 testRunner.dumpAsText();
 testRunner.dumpChildFramesAsText();
 }
 
-function onframeload(text)
+function runTest()
 {
-this.contentDocument.body.innerHTML = this.id;
+if (--count) return;
+// Wait until all frame disconnection calls are complete to ensure inDocument
+// frames remain loaded.
+setTimeout(function() {
+shouldNotBe('frame1.contentDocument', 'null');
+shouldNotBe('frame2.contentDocument', 'null');
+finishJSTest();
+}, 0);
 }
 
-function runTest()
-{
-}
-
-var container = document.getElementById('container');
-var inside = document.getElementById('inside');
-
-var frame1 = document.createElement('iframe');
-frame1.id = 'frame1';
-frame1._onload_ = onframeload;
-
-var frame2 = document.createElement('iframe');
-frame2.id = 'frame2';
-frame2._onload_ = onframeload;
-
 _onload_ = function() {
 inside.appendChild(frame1);
 inside.appendChild(frame2);
 
 frame1.contentWindow._onunload_ = function() {
+frame1._onload_ = runTest;
+frame2._onload_ = runTest;
 document.body.appendChild(inside);
 };
 
 container.parentNode.removeChild(container);
-shouldNotBe('frame1.contentDocument', 'null');
-shouldNotBe('frame2.contentDocument', 'null');
-isSuccessfullyParsed();
 };
 
+
+

[webkit-changes] [140884] trunk/Source/WebCore

2013-01-25 Thread haraken 
Title: [140884] trunk/Source/WebCore








Revision 140884
Author hara...@chromium.org
Date 2013-01-25 17:05:54 -0800 (Fri, 25 Jan 2013)


Log Message
Rename CodeGenerator::IsSubType() to CodeGenerator::InheritsInterface()
https://bugs.webkit.org/show_bug.cgi?id=107874

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(InheritsInterface):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallback):
(GenerateImplementationIndexer):
(GenerateToV8Converters):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (140883 => 140884)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 00:57:12 UTC (rev 140883)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 01:05:54 UTC (rev 140884)
@@ -1,5 +1,28 @@
 2013-01-25  Kentaro Hara  
 
+Rename CodeGenerator::IsSubType() to CodeGenerator::InheritsInterface()
+https://bugs.webkit.org/show_bug.cgi?id=107874
+
+Reviewed by Adam Barth.
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGenerator.pm:
+(InheritsInterface):
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+(GenerateImplementation):
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateHeader):
+(GetInternalFields):
+(GenerateNormalAttrGetter):
+(GenerateNormalAttrSetter):
+(GenerateFunctionCallback):
+(GenerateImplementationIndexer):
+(GenerateToV8Converters):
+
+2013-01-25  Kentaro Hara  
+
 [V8] Pass an Isolate to GetRawTemplate()
 https://bugs.webkit.org/show_bug.cgi?id=107927
 


Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (140883 => 140884)

--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm	2013-01-26 00:57:12 UTC (rev 140883)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm	2013-01-26 01:05:54 UTC (rev 140884)
@@ -732,8 +732,7 @@
 return $interfaceName ? $interfaceName : $interface->name;
 }
 
-# FIXME: Rename to InheritsInterface
-sub IsSubType
+sub InheritsInterface
 {
 my $object = shift;
 my $interface = shift;


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (140883 => 140884)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2013-01-26 00:57:12 UTC (rev 140883)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2013-01-26 01:05:54 UTC (rev 140884)
@@ -1040,7 +1040,7 @@
 GetCustomIsReachable($interface) ||
 $interface->extendedAttributes->{"JSCustomFinalize"} ||
 $interface->extendedAttributes->{"ActiveDOMObject"}) {
-if ($interfaceName ne "Node" && $codeGenerator->IsSubType($interface, "Node")) {
+if ($interfaceName ne "Node" && $codeGenerator->InheritsInterface($interface, "Node")) {
 $headerIncludes{"JSNode.h"} = 1;
 push(@headerContent, "class JS${interfaceName}Owner : public JSNodeOwner {\n");
 } else {
@@ -1413,7 +1413,7 @@
 my $hasParent = $hasLegacyParent || $hasRealParent;
 my $parentClassName = GetParentClassName($interface);
 my $visibleInterfaceName = $codeGenerator->GetVisibleInterfaceName($interface);
-my $eventTarget = $interface->extendedAttributes->{"EventTarget"} || ($codeGenerator->IsSubType($interface, "EventTarget") && $interface->name ne "EventTarget");
+my $eventTarget = $interface->extendedAttributes->{"EventTarget"} || ($codeGenerator->InheritsInterface($interface, "EventTarget") && $interface->name ne "EventTarget");
 my $needsMarkChildren = $interface->extendedAttributes->{"JSCustomMarkFunction"} || $interface->extendedAttributes->{"EventTarget"} || $interface->name eq "EventTarget";
 
 # - Add default header template
@@ -2492,7 +2492,7 @@
 push(@implContent, "if (js${interfaceName}->impl()->hasPendingActivity())\n");
 push(@implContent, "return true;\n");
 }
-if ($codeGenerator->IsSubType($interface, "Node")) {
+if ($codeGenerator->InheritsInterface($interface, "Node")) {
 push(@implContent, "if (JSNodeOwner::isReachableFromOpaqueRoots(handle, 0, visitor))\n");
 push(@implContent, "return true;\n");
 }


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (140883 => 140884)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2013-01-26 00:57:12 UTC (rev 140883)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2013-01-26 01:05:54 UTC (rev 140884)
@@ -272,7 +272,7 @@
 $codeGenerator->LinkOverloadedFunctions($interface);
 
 # Ensure the IsDO

[webkit-changes] [140882] trunk

2013-01-25 Thread commit-queue 
Title: [140882] trunk








Revision 140882
Author commit-qu...@webkit.org
Date 2013-01-25 16:54:33 -0800 (Fri, 25 Jan 2013)


Log Message
Source/WebCore: [User Timing]Change class name that presented in _javascript_ for user timing entry.
https://bugs.webkit.org/show_bug.cgi?id=107925.

Patch by Pan Deng  on 2013-01-25
Reviewed by Tony Gentilcore.

In current implementation, class type of user timing entries are PerformanceEntry, according
to W3C spec, they should be PerformanceMark and PerformanceMeasure.

Test: http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html

* bindings/v8/custom/V8PerformanceEntryCustom.cpp:
(WebCore::wrap):
* page/PerformanceEntry.h:
(WebCore::PerformanceEntry::isMark):
(WebCore::PerformanceEntry::isMeasure):
* page/PerformanceMark.h:
(WebCore::PerformanceMark::isMark):
(PerformanceMark):
* page/PerformanceMeasure.h:
(WebCore::PerformanceMeasure::isMeasure):
(PerformanceMeasure):

LayoutTests: [User Timing] Class name of user timing entries should be PerformanceMark/PerformanceMeasure.
https://bugs.webkit.org/show_bug.cgi?id=107925.

Patch by Pan Deng  on 2013-01-25
Reviewed by Tony Gentilcore.

* http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type-expected.txt: Added.
* http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8PerformanceEntryCustom.cpp
trunk/Source/WebCore/page/PerformanceEntry.h
trunk/Source/WebCore/page/PerformanceMark.h
trunk/Source/WebCore/page/PerformanceMeasure.h


Added Paths

trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type-expected.txt
trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html




Diff

Modified: trunk/LayoutTests/ChangeLog (140881 => 140882)

--- trunk/LayoutTests/ChangeLog	2013-01-26 00:47:02 UTC (rev 140881)
+++ trunk/LayoutTests/ChangeLog	2013-01-26 00:54:33 UTC (rev 140882)
@@ -1,3 +1,13 @@
+2013-01-25  Pan Deng  
+
+[User Timing] Class name of user timing entries should be PerformanceMark/PerformanceMeasure.
+https://bugs.webkit.org/show_bug.cgi?id=107925.
+
+Reviewed by Tony Gentilcore.
+
+* http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type-expected.txt: Added.
+* http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html: Added.
+
 2013-01-24  Ojan Vafai  
 
 MathML preferred widths should not depend on layout information


Added: trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type-expected.txt (0 => 140882)

--- trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type-expected.txt	2013-01-26 00:54:33 UTC (rev 140882)
@@ -0,0 +1,8 @@
+Description
+
+This test validates the user timing entry type, PerformanceMark and PerformanceMeasure.
+
+
+PASS Class name of mark entry should be PerformanceMark. 
+PASS Class name of measure entry should be PerformanceMeasure. 
+


Added: trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html (0 => 140882)

--- trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html	(rev 0)
+++ trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html	2013-01-26 00:54:33 UTC (rev 140882)
@@ -0,0 +1,29 @@
+
+
+
+
+user timing entry type
+
+
+
+Description
+This test validates the user timing entry type, PerformanceMark and PerformanceMeasure.
+
+
+
+var context = new PerformanceContext(window.performance);
+context.mark('mark');
+context.measure('measure');
+var mark_entry = context.getEntriesByName('mark')[0];
+var measure_entry = context.getEntriesByName('measure')[0];
+
+test_equals(Object.prototype.toString.call(mark_entry), '[object PerformanceMark]', 'Class name of mark entry should be PerformanceMark.');
+test_equals(Object.prototype.toString.call(measure_entry), '[object PerformanceMeasure]', 'Class name of measure entry should be PerformanceMeasure.');
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (140881 => 140882)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 00:47:02 UTC (rev 140881)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 00:54:33 UTC (rev 140882)
@@ -1,3 +1,27 @@
+2013-01-25  Pan Deng  
+
+[User Timing]Change class name that presented in _javascript_ for user timing entry.
+https://bugs.webkit.org/show_bug.cgi?id=107925.
+
+Reviewed

[webkit-changes] [140879] trunk/Source/WebCore

2013-01-25 Thread rtoy 
Title: [140879] trunk/Source/WebCore








Revision 140879
Author r...@google.com
Date 2013-01-25 16:36:55 -0800 (Fri, 25 Jan 2013)


Log Message
Don't subtract too much from nonSilentFramesToProcess
https://bugs.webkit.org/show_bug.cgi?id=107966

Reviewed by Kenneth Russell.

No new tests.

* Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (140878 => 140879)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 00:24:10 UTC (rev 140878)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 00:36:55 UTC (rev 140879)
@@ -1,3 +1,15 @@
+2013-01-25  Raymond Toy  
+
+Don't subtract too much from nonSilentFramesToProcess
+https://bugs.webkit.org/show_bug.cgi?id=107966
+
+Reviewed by Kenneth Russell.
+
+No new tests.
+
+* Modules/webaudio/AudioScheduledSourceNode.cpp:
+(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
+
 2013-01-25  Roger Fong  
 
 Unreviewed. Windows build fix by Dean.


Modified: trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp (140878 => 140879)

--- trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp	2013-01-26 00:24:10 UTC (rev 140878)
+++ trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp	2013-01-26 00:36:55 UTC (rev 140879)
@@ -117,7 +117,11 @@
 ASSERT(isSafe);
 
 if (isSafe) {
-nonSilentFramesToProcess -= framesToZero;
+if (framesToZero > nonSilentFramesToProcess)
+nonSilentFramesToProcess = 0;
+else
+nonSilentFramesToProcess -= framesToZero;
+
 for (unsigned i = 0; i < outputBus->numberOfChannels(); ++i)
 memset(outputBus->channel(i)->mutableData() + zeroStartFrame, 0, sizeof(float) * framesToZero);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140878] trunk/Source/WebCore

2013-01-25 Thread roger_fong 
Title: [140878] trunk/Source/WebCore








Revision 140878
Author roger_f...@apple.com
Date 2013-01-25 16:24:10 -0800 (Fri, 25 Jan 2013)


Log Message
Unreviewed. Windows build fix by Dean.

* css/plugIns.css:
(object):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/plugIns.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (140877 => 140878)

--- trunk/Source/WebCore/ChangeLog	2013-01-26 00:20:45 UTC (rev 140877)
+++ trunk/Source/WebCore/ChangeLog	2013-01-26 00:24:10 UTC (rev 140878)
@@ -1,3 +1,10 @@
+2013-01-25  Roger Fong  
+
+Unreviewed. Windows build fix by Dean.
+
+* css/plugIns.css:
+(object):
+
 2013-01-25  Dima Gorbik  
 
 Support language WebVTT Nodes


Modified: trunk/Source/WebCore/css/plugIns.css (140877 => 140878)

--- trunk/Source/WebCore/css/plugIns.css	2013-01-26 00:20:45 UTC (rev 140877)
+++ trunk/Source/WebCore/css/plugIns.css	2013-01-26 00:24:10 UTC (rev 140878)
@@ -23,3 +23,4 @@
  */
 
 /* plug-ins */
+object{} /*Needed by Windows because it doesn't like empty files*/
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140877] trunk

2013-01-25 Thread commit-queue 
Title: [140877] trunk








Revision 140877
Author commit-qu...@webkit.org
Date 2013-01-25 16:20:45 -0800 (Fri, 25 Jan 2013)


Log Message
Support language WebVTT Nodes
https://bugs.webkit.org/show_bug.cgi?id=107907

Patch by Dima Gorbik  on 2013-01-25
Reviewed by Eric Carlson.

Source/WebCore:

Language stack and WebVTT language nodes are added as
required by specs.

Test: media/track/track-css-matching-lang.html

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree): WebVTT language nodes should be
spans in DOM and the lang attribute should be set for all nodes if applicable.
* html/track/TextTrackCue.h:
(WebCore::TextTrackCue::langElementTagName):
(TextTrackCue):
(WebCore::TextTrackCue::langAttributeName):
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::createDocumentFragmentFromCueText): clear the language stack in case
we use the same parser object for multiple cues that have incorrect syntax.
(WebCore::isLangToken):
(WebCore):
(WebCore::WebVTTParser::constructTreeFromToken): parse lang WebVTT objects.
* html/track/WebVTTParser.h:
(WebVTTParser):

LayoutTests:

* media/track/captions-webvtt/styling-lang.vtt: Added.
* media/track/track-css-matching-lang-expected.txt: Added.
* media/track/track-css-matching-lang.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/TextTrackCue.cpp
trunk/Source/WebCore/html/track/TextTrackCue.h
trunk/Source/WebCore/html/track/WebVTTParser.cpp
trunk/Source/WebCore/html/track/WebVTTParser.h


Added Paths

trunk/LayoutTests/media/track/captions-webvtt/styling-lang.vtt
trunk/LayoutTests/media/track/track-css-matching-lang-expected.txt
trunk/LayoutTests/media/track/track-css-matching-lang.html




Diff

Modified: trunk/LayoutTests/ChangeLog (140876 => 140877)

--- trunk/LayoutTests/ChangeLog	2013-01-26 00:19:49 UTC (rev 140876)
+++ trunk/LayoutTests/ChangeLog	2013-01-26 00:20:45 UTC (rev 140877)
@@ -1,3 +1,14 @@
+2013-01-25  Dima Gorbik  
+
+Support language WebVTT Nodes
+https://bugs.webkit.org/show_bug.cgi?id=107907
+
+Reviewed by Eric Carlson.
+
+* media/track/captions-webvtt/styling-lang.vtt: Added.
+* media/track/track-css-matching-lang-expected.txt: Added.
+* media/track/track-css-matching-lang.html: Added.
+
 2013-01-25  Emil A Eklund  
 
 Unreviewed chromium svg rebaseline.


Added: trunk/LayoutTests/media/track/captions-webvtt/styling-lang.vtt (0 => 140877)

--- trunk/LayoutTests/media/track/captions-webvtt/styling-lang.vtt	(rev 0)
+++ trunk/LayoutTests/media/track/captions-webvtt/styling-lang.vtt	2013-01-26 00:20:45 UTC (rev 140877)
@@ -0,0 +1,5 @@
+WEBVTT
+
+1
+00:00.000 --> 00:01.000
+English Русский English again


Added: trunk/LayoutTests/media/track/track-css-matching-lang-expected.txt (0 => 140877)

--- trunk/LayoutTests/media/track/track-css-matching-lang-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/track/track-css-matching-lang-expected.txt	2013-01-26 00:20:45 UTC (rev 140877)
@@ -0,0 +1,8 @@
+Test that cues are being matched properly by the lang attribute.
+EVENT(canplaythrough)
+EVENT(seeked)
+EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
+EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
+EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
+END OF TEST
+


Added: trunk/LayoutTests/media/track/track-css-matching-lang.html (0 => 140877)

--- trunk/LayoutTests/media/track/track-css-matching-lang.html	(rev 0)
+++ trunk/LayoutTests/media/track/track-css-matching-lang.html	2013-01-26 00:20:45 UTC (rev 140877)
@@ -0,0 +1,60 @@
+
+
+
+
+
+
+::cue(c[lang="ru"]) { color: red; }
+::cue(c[lang="en"]) { color: green; }
+
+
+