[webkit-changes] [144423] trunk/Source/WebCore

[keishi]

Title: [144423] trunk/Source/WebCore








Revision 144423
Author kei...@webkit.org
Date 2013-02-28 23:48:35 -0800 (Thu, 28 Feb 2013)


Log Message
Add calendar table view for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110970

Reviewed by Kent Tamura.

The calendar table that will be used in the new calendar picker (Bug 109439).

No new tests. Code is not used yet.

* Resources/pagepopups/calendarPicker.js:
(DayCell): Cell which represents one day in the calendar.
(DayCell.recycleOrCreate):
(DayCell.prototype._recycleBin):
(DayCell.prototype.throwAway):
(DayCell.prototype.setHighlighted): Sets the highlighted class on the element.
(DayCell.prototype.setDisabled): Sets the disabled class on the element.
(DayCell.prototype.setIsInCurrentMonth): Sets the current-month class on the element.
(DayCell.prototype.setIsToday): Sets the today class on the element.
(DayCell.prototype.reset): Resets the day cell to be reused.
(WeekNumberCell): Cell used for the week number column.
(WeekNumberCell.prototype._recycleBin):
(WeekNumberCell.recycleOrCreate):
(WeekNumberCell.prototype.reset):
(WeekNumberCell.prototype.throwAway):
(WeekNumberCell.prototype.setHighlighted): Sets the highlighted class on the element.
(WeekNumberCell.prototype.setDisabled): Sets the disabled class on the element.
(CalendarTableHeaderView): Header for the calendar table. Contains the column labels.
(CalendarRowCell): Row containing day cells and maybe a week number cell.
(CalendarRowCell.prototype._recycleBin):
(CalendarRowCell.prototype.reset):
(CalendarRowCell.prototype.throwAway):
(CalendarTableView): A list view showing a grid of days.
(CalendarTableView.prototype.rowAtScrollOffset): Returns the row number currently at the scroll offset.
(CalendarTableView.prototype.scrollOffsetForRow): Returns the current scroll offset for the given row.
(CalendarTableView.prototype.onClick): If the click is on a DayCell or WeekNumberCell, select the appropriate date range.
(CalendarTableView.prototype.onMouseOver): If the click is on a DayCell or WeekNumberCell, highlight the appropriate date range.
(CalendarTableView.prototype.onMouseOut):
(CalendarTableView.prototype.prepareNewCell): Prepares a new row cell by recycling or creating a new one.
(CalendarTableView.prototype.height): Returns the height of the view in pixels.
(CalendarTableView.prototype.setHeight): Sets the height of the view in pixels.
(CalendarTableView.prototype.scrollToMonth): Scrolls to reveal the given month.
(CalendarTableView.prototype.dayAtColumnAndRow): Day at a given column and row. Column number doesn't count week number column.
(CalendarTableView.prototype.columnAndRowForDay): Column and row for the given day.
(CalendarTableView.prototype.updateCells): Update the position and appearance of the cell.s
(CalendarTableView.prototype.prepareNewDayCell): Prepares a new day cell. The cell is registered to this._dayCells.
(CalendarTableView.prototype.prepareNewWeekNumberCell): Prepares a new week number cell. The cell is registered to this._weekNumberCells.
(CalendarTableView.prototype.throwAwayDayCell): The cell is unregistered from this._dayCells.
(CalendarTableView.prototype.throwAwayWeekNumberCell): The cell is unregistered from this._weekNumberCells.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (144422 => 144423)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 07:26:10 UTC (rev 144422)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 07:48:35 UTC (rev 144423)
@@ -1,3 +1,54 @@
+2013-02-28  Keishi Hattori  
+
+Add calendar table view for the new calendar picker
+https://bugs.webkit.org/show_bug.cgi?id=110970
+
+Reviewed by Kent Tamura.
+
+The calendar table that will be used in the new calendar picker (Bug 109439).
+
+No new tests. Code is not used yet.
+
+* Resources/pagepopups/calendarPicker.js:
+(DayCell): Cell which represents one day in the calendar.
+(DayCell.recycleOrCreate):
+(DayCell.prototype._recycleBin):
+(DayCell.prototype.throwAway):
+(DayCell.prototype.setHighlighted): Sets the highlighted class on the element.
+(DayCell.prototype.setDisabled): Sets the disabled class on the element.
+(DayCell.prototype.setIsInCurrentMonth): Sets the current-month class on the element.
+(DayCell.prototype.setIsToday): Sets the today class on the element.
+(DayCell.prototype.reset): Resets the day cell to be reused.
+(WeekNumberCell): Cell used for the week number column.
+(WeekNumberCell.prototype._recycleBin):
+(WeekNumberCell.recycleOrCreate):
+(WeekNumberCell.prototype.reset):
+(WeekNumberCell.prototype.throwAway):
+(WeekNumberCell.prototype.setHighlighted): Sets the highlighted class on the element.
+(WeekNumberCell.prototype.setDisabled): Sets the disabled class on the element.

[webkit-changes] [144421] trunk/Tools

[rniwa]

Title: [144421] trunk/Tools








Revision 144421
Author rn...@webkit.org
Date 2013-02-28 22:34:29 -0800 (Thu, 28 Feb 2013)


Log Message
Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
https://bugs.webkit.org/show_bug.cgi?id=42

Reviewed by Adam Barth.

Merged _run_single_test into _run_tests_set. The code looks much cleaner now.

Also removed _print_status since it's never used anywhere.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.run):
(PerfTestsRunner._run_tests_set):
* Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest.run_test):
(MainTest.test_run_test_set):
(MainTest.test_run_test_set_kills_drt_per_run):
(MainTest.test_run_test_set_for_parser_tests):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py




Diff

Modified: trunk/Tools/ChangeLog (144420 => 144421)

--- trunk/Tools/ChangeLog	2013-03-01 06:28:41 UTC (rev 144420)
+++ trunk/Tools/ChangeLog	2013-03-01 06:34:29 UTC (rev 144421)
@@ -1,3 +1,23 @@
+2013-02-28  Ryosuke Niwa  
+
+Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
+https://bugs.webkit.org/show_bug.cgi?id=42
+
+Reviewed by Adam Barth.
+
+Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
+
+Also removed _print_status since it's never used anywhere.
+
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner.run):
+(PerfTestsRunner._run_tests_set):
+* Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
+(MainTest.run_test):
+(MainTest.test_run_test_set):
+(MainTest.test_run_test_set_kills_drt_per_run):
+(MainTest.test_run_test_set_for_parser_tests):
+
 2013-02-28  Kiran Muppala  
 
 Disable window occlusion detection for WebKitTestRunner Web View on Mac


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (144420 => 144421)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py	2013-03-01 06:28:41 UTC (rev 144420)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py	2013-03-01 06:34:29 UTC (rev 144421)
@@ -186,7 +186,7 @@
 try:
 if needs_http:
 self._start_http_servers()
-unexpected = self._run_tests_set(sorted(list(tests), key=lambda test: test.test_name()), self._port)
+unexpected = self._run_tests_set(sorted(list(tests), key=lambda test: test.test_name()))
 
 finally:
 if needs_http:
@@ -356,40 +356,21 @@
 _log.info("JSON file uploaded to %s." % url)
 return True
 
-def _print_status(self, tests, expected, unexpected):
-if len(tests) == expected + unexpected:
-status = "Ran %d tests" % len(tests)
-else:
-status = "Running %d of %d tests" % (expected + unexpected + 1, len(tests))
-if unexpected:
-status += " (%d didn't run)" % unexpected
-_log.info(status)
-
-def _run_tests_set(self, tests, port):
+def _run_tests_set(self, tests):
 result_count = len(tests)
-expected = 0
-unexpected = 0
-driver = None
+failures = 0
 
-for test in tests:
-_log.info('Running %s (%d of %d)' % (test.test_name(), expected + unexpected + 1, len(tests)))
-if self._run_single_test(test):
-expected = expected + 1
+for i, test in enumerate(tests):
+_log.info('Running %s (%d of %d)' % (test.test_name(), i + 1, len(tests)))
+start_time = time.time()
+new_results = test.run(self._options.time_out_ms)
+if new_results:
+self._results.update(new_results)
 else:
-unexpected = unexpected + 1
+failures += 1
+_log.error('FAILED')
 
+_log.info('Finished: %f s' % (time.time() - start_time))
 _log.info('')
 
-return unexpected
-
-def _run_single_test(self, test):
-start_time = time.time()
-new_results = test.run(self._options.time_out_ms)
-if new_results:
-self._results.update(new_results)
-else:
-_log.error('FAILED')
-
-_log.info("Finished: %f s" % (time.time() - start_time))
-
-return new_results != None
+return failures


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py (144420 => 144421)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py	2013-03-01 06:28:41 UTC (rev 144420)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py	2013-03-01 06:34:29 UTC (rev 144421)
@@ -214,7 +214,8 @@
 
 def run_test(self, test_name):
   

[webkit-changes] [144420] trunk/LayoutTests

[toyoshim]

Title: [144420] trunk/LayoutTests








Revision 144420
Author toyos...@chromium.org
Date 2013-02-28 22:28:41 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed chromium gardening
https://bugs.webkit.org/show_bug.cgi?id=41

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (144419 => 144420)

--- trunk/LayoutTests/ChangeLog	2013-03-01 06:24:16 UTC (rev 144419)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 06:28:41 UTC (rev 144420)
@@ -1,3 +1,10 @@
+2013-02-28  Takashi Toyoshima  
+
+Unreviewed chromium gardening
+https://bugs.webkit.org/show_bug.cgi?id=41
+
+* platform/chromium/TestExpectations:
+
 2013-02-28  Seokju Kwon  
 
 [EFL] Gardening for some inspector tests


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144419 => 144420)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-01 06:24:16 UTC (rev 144419)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-01 06:28:41 UTC (rev 144420)
@@ -1604,6 +1604,8 @@
 webkit.org/b/110377 [ MountainLion ] fast/multicol/newmulticol/float-paginate.html [ ImageOnlyFailure ]
 webkit.org/b/110377 [ MountainLion ] fast/multicol/newmulticol/positioned-with-constrained-height.html [ ImageOnlyFailure ]
 
+webkit.org/b/41 [ Debug ] fast/regions/seamless-iframe-flowed-into-regions.html [ ImageOnlyFailure ]
+
 # -
 # MAC PORT TESTS
 # -






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144419] trunk/Source/WebCore

[commit-queue]

Title: [144419] trunk/Source/WebCore








Revision 144419
Author commit-qu...@webkit.org
Date 2013-02-28 22:24:16 -0800 (Thu, 28 Feb 2013)


Log Message
[V8] Added V8CustomIndexedGetter to IDLs that correspond to existing custom indexedPropertyGetter.
https://bugs.webkit.org/show_bug.cgi?id=110852

Patch by Koji Hara  on 2013-02-28
Reviewed by Kentaro Hara.

Add V8CustomIndexedGetter attribute that indicates the interface have custom implementation of a getter of indexed properties.
(Also added to the wiki)
https://trac.webkit.org/wiki/WebKitIDL#V8CustomIndexedGetter
Add V8CustomIndexedGetter to IDLs that correspond to existing custom indexedPropertyGetter.
We want to clean up CodeGeneratorV8.pm.
The problem is that all implementations of indexed properties and named properties are currently delegated to custom bindings.
We want to auto-generate as much code as possible.
As a starting point, this commit assures a interface has [V8CustomIndexedGetter] ==> there's custom implementation of indexed getter.

No test. Simple refactoring.

* bindings/scripts/IDLAttributes.txt: Add V8CustomIndexedGetter attribute.
* dom/NamedNodeMap.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLAppletElement.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLEmbedElement.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLFormElement.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLObjectElement.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLOptionsCollection.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLSelectElement.idl: Add V8CustomIndexedGetter attribute.
* page/DOMWindow.idl: Add V8CustomIndexedGetter attribute.
* storage/Storage.idl: Add V8CustomIndexedGetter attribute.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
trunk/Source/WebCore/dom/NamedNodeMap.idl
trunk/Source/WebCore/html/HTMLAppletElement.idl
trunk/Source/WebCore/html/HTMLEmbedElement.idl
trunk/Source/WebCore/html/HTMLFormElement.idl
trunk/Source/WebCore/html/HTMLObjectElement.idl
trunk/Source/WebCore/html/HTMLOptionsCollection.idl
trunk/Source/WebCore/html/HTMLSelectElement.idl
trunk/Source/WebCore/page/DOMWindow.idl
trunk/Source/WebCore/storage/Storage.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (144418 => 144419)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 06:23:57 UTC (rev 144418)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 06:24:16 UTC (rev 144419)
@@ -1,3 +1,32 @@
+2013-02-28  Koji Hara  
+
+[V8] Added V8CustomIndexedGetter to IDLs that correspond to existing custom indexedPropertyGetter.
+https://bugs.webkit.org/show_bug.cgi?id=110852
+
+Reviewed by Kentaro Hara.
+
+Add V8CustomIndexedGetter attribute that indicates the interface have custom implementation of a getter of indexed properties.
+(Also added to the wiki)
+https://trac.webkit.org/wiki/WebKitIDL#V8CustomIndexedGetter
+Add V8CustomIndexedGetter to IDLs that correspond to existing custom indexedPropertyGetter.
+We want to clean up CodeGeneratorV8.pm.
+The problem is that all implementations of indexed properties and named properties are currently delegated to custom bindings.
+We want to auto-generate as much code as possible.
+As a starting point, this commit assures a interface has [V8CustomIndexedGetter] ==> there's custom implementation of indexed getter.
+
+No test. Simple refactoring.
+
+* bindings/scripts/IDLAttributes.txt: Add V8CustomIndexedGetter attribute.
+* dom/NamedNodeMap.idl: Add V8CustomIndexedGetter attribute.
+* html/HTMLAppletElement.idl: Add V8CustomIndexedGetter attribute.
+* html/HTMLEmbedElement.idl: Add V8CustomIndexedGetter attribute.
+* html/HTMLFormElement.idl: Add V8CustomIndexedGetter attribute.
+* html/HTMLObjectElement.idl: Add V8CustomIndexedGetter attribute.
+* html/HTMLOptionsCollection.idl: Add V8CustomIndexedGetter attribute.
+* html/HTMLSelectElement.idl: Add V8CustomIndexedGetter attribute.
+* page/DOMWindow.idl: Add V8CustomIndexedGetter attribute.
+* storage/Storage.idl: Add V8CustomIndexedGetter attribute.
+
 2013-02-28  Xingnan Wang  
 
 Heap-use-after-free in WebCore::AudioNodeInput::updateInternalBus


Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (144418 => 144419)

--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt	2013-03-01 06:23:57 UTC (rev 144418)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt	2013-03-01 06:24:16 UTC (rev 144419)
@@ -116,6 +116,7 @@
 V8Custom
 V8CustomConstructor
 V8CustomGetter
+V8CustomIndexedGetter
 V8CustomIsReachable
 V8CustomSetter
 V8CustomToJSObject


Modified: trunk/Source/WebCore/dom/NamedNodeMap.idl (144418 => 144419)

--- trunk/Source/WebCore/dom/NamedNodeMap.idl	2013-03-01 06:23:57 UTC (rev 144418)
+++ trunk/Source/WebCore/dom/NamedNodeMap.idl	2013-03-01 06:24:16 UTC (rev 144419)
@@ -22,6 +22,7 @

[webkit-changes] [144418] branches/chromium/1410/Source/WebCore

[eustas]

Title: [144418] branches/chromium/1410/Source/WebCore








Revision 144418
Author eus...@chromium.org
Date 2013-02-28 22:23:57 -0800 (Thu, 28 Feb 2013)


Log Message
Merge 144161
> Web Inspector: timeline stops working on certain sites
> https://bugs.webkit.org/show_bug.cgi?id=110955
> 
> Reviewed by Alexander Pavlov.
> 
> Analysis: "timerId" value is number,
> so it is not wrapped to node as expected.
> 
> Solution: wrap values of all types except Node.
> 
> * inspector/front-end/TimelinePresentationModel.js:
> Wrap nonstring values to text nodes.
> 

TBR=eus...@chromium.org
Review URL: https://codereview.chromium.org/12389044

Modified Paths

branches/chromium/1410/Source/WebCore/ChangeLog
branches/chromium/1410/Source/WebCore/inspector/front-end/TimelinePresentationModel.js




Diff

Modified: branches/chromium/1410/Source/WebCore/ChangeLog (144417 => 144418)

--- branches/chromium/1410/Source/WebCore/ChangeLog	2013-03-01 06:07:55 UTC (rev 144417)
+++ branches/chromium/1410/Source/WebCore/ChangeLog	2013-03-01 06:23:57 UTC (rev 144418)
@@ -1,3 +1,18 @@
+2013-02-27  Eugene Klyuchnikov  
+
+Web Inspector: timeline stops working on certain sites
+https://bugs.webkit.org/show_bug.cgi?id=110955
+
+Reviewed by Alexander Pavlov.
+
+Analysis: "timerId" value is number,
+so it is not wrapped to node as expected.
+
+Solution: wrap values of all types except Node.
+
+* inspector/front-end/TimelinePresentationModel.js:
+Wrap nonstring values to text nodes.
+
 2013-02-11  Zhenyao Mo  
 
 WEBGL_compressed_texture_s3tc extension can be enabled even when not supported


Modified: branches/chromium/1410/Source/WebCore/inspector/front-end/TimelinePresentationModel.js (144417 => 144418)

--- branches/chromium/1410/Source/WebCore/inspector/front-end/TimelinePresentationModel.js	2013-03-01 06:07:55 UTC (rev 144417)
+++ branches/chromium/1410/Source/WebCore/inspector/front-end/TimelinePresentationModel.js	2013-03-01 06:23:57 UTC (rev 144418)
@@ -1019,8 +1019,8 @@
 break;
 }
 
-if (typeof details === "string")
-return this._createSpanWithText(details);
+if (details && !(details instanceof Node))
+return this._createSpanWithText("" + details);
 
 return details ? details : null;
 },
@@ -1055,11 +1055,15 @@
 },
 
 /**
- * @param {string=} defaultValue
+ * @param {*=} defaultValue
+ * @return {Element|string}
  */
 _linkifyScriptLocation: function(defaultValue)
 {
-return this.scriptName ? this._linkifyLocation(this.scriptName, this.scriptLine, 0) : defaultValue;
+if (this.scriptName)
+return this._linkifyLocation(this.scriptName, this.scriptLine, 0);
+else
+return defaultValue ? "" + defaultValue : null;
 },
 
 calculateAggregatedStats: function(categories)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144416] branches/safari-536.29-branch

[beidson]

Title: [144416] branches/safari-536.29-branch








Revision 144416
Author beid...@apple.com
Date 2013-02-28 21:59:00 -0800 (Thu, 28 Feb 2013)


Log Message
Merge r141486

2013-01-30  Brian Weinstein  

Add a call to the page UI client to determine if a plug-in should load
https://bugs.webkit.org/show_bug.cgi?id=108407


Source/WebKit2: 

Reviewed by Anders Carlsson.

This patch adds a client call to the WKPageUIClient to be called to determine
whether or not a plug-in should load.

* UIProcess/API/C/WKPage.h: Add shouldLoadPlugin.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath): Moved from WebProcessProxy, and added a call to
m_uiClient.shouldInstantiatePlugin.
* UIProcess/WebPageProxy.h:
* UIProcss/WebPageProxy.messages.in: Moved GetPluginPath from WebProcessProxy to WebPageProxy.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginPath): Moved to WebPageProxy.
* UIProcess/WebProcessProxy.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::shouldInstantiatePlugin): Return that we should load the plug-in if
the client function isn't defined, and call the function if it is.
* UIProcess/WebUIClient.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Add an entry for the new
client function.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Send the message to the WebPageProxy, not the WebProcessProxy.
(WebKit::WebPage::canPluginHandleResponse): Made a member function, so it can call sendSync, and
send the message to the WebPageProxy, not the WebProcessProxy.
* WebProcess/WebPage/WebPage.h:

Tools: 

Add entries for the new function in the necessary structs.

Reviewed by Anders Carlsson.

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

Modified Paths

branches/safari-536.29-branch/Source/WebKit2/ChangeLog
branches/safari-536.29-branch/Source/WebKit2/UIProcess/API/C/WKPage.h
branches/safari-536.29-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp
branches/safari-536.29-branch/Source/WebKit2/UIProcess/WebPageProxy.h
branches/safari-536.29-branch/Source/WebKit2/UIProcess/WebPageProxy.messages.in
branches/safari-536.29-branch/Source/WebKit2/UIProcess/WebUIClient.cpp
branches/safari-536.29-branch/Source/WebKit2/UIProcess/WebUIClient.h
branches/safari-536.29-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
branches/safari-536.29-branch/Tools/ChangeLog
branches/safari-536.29-branch/Tools/MiniBrowser/mac/BrowserWindowController.m
branches/safari-536.29-branch/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: branches/safari-536.29-branch/Source/WebKit2/ChangeLog (144415 => 144416)

--- branches/safari-536.29-branch/Source/WebKit2/ChangeLog	2013-03-01 05:46:21 UTC (rev 144415)
+++ branches/safari-536.29-branch/Source/WebKit2/ChangeLog	2013-03-01 05:59:00 UTC (rev 144416)
@@ -1,3 +1,40 @@
+2013-02-28  Brady Eidson  
+
+Merge r141486
+
+2013-01-30  Brian Weinstein  
+
+Add a call to the page UI client to determine if a plug-in should load
+https://bugs.webkit.org/show_bug.cgi?id=108407
+
+
+Reviewed by Anders Carlsson.
+
+This patch adds a client call to the WKPageUIClient to be called to determine
+whether or not a plug-in should load.
+
+* UIProcess/API/C/WKPage.h: Add shouldLoadPlugin.
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::getPluginPath): Moved from WebProcessProxy, and added a call to
+m_uiClient.shouldInstantiatePlugin.
+* UIProcess/WebPageProxy.h:
+* UIProcss/WebPageProxy.messages.in: Moved GetPluginPath from WebProcessProxy to WebPageProxy.
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::getPluginPath): Moved to WebPageProxy.
+* UIProcess/WebProcessProxy.h:
+* UIProcess/WebUIClient.cpp:
+(WebKit::WebUIClient::shouldInstantiatePlugin): Return that we should load the plug-in if
+the client function isn't defined, and call the function if it is.
+* UIProcess/WebUIClient.h:
+* UIProcess/mac/WebInspectorProxyMac.mm:
+(WebKit::WebInspectorProxy::platformCreateInspectorPage): Add an entry for the new
+client function.
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::createPlugin): Send the message to the WebPageProxy, not the WebProcessProxy.
+(WebKit::WebPage::canPluginHandleResponse): Made a member function, so it can call sendSync, and
+send the message to the WebPageProxy, not the WebProcessProxy.
+

[webkit-changes] [144415] trunk/Tools

[commit-queue]

Title: [144415] trunk/Tools








Revision 144415
Author commit-qu...@webkit.org
Date 2013-02-28 21:46:21 -0800 (Thu, 28 Feb 2013)


Log Message
Disable window occlusion detection for WebKitTestRunner Web View on Mac
https://bugs.webkit.org/show_bug.cgi?id=16

Patch by Kiran Muppala  on 2013-02-28
Reviewed by Simon Fraser.

Window occlusion notifications were causing WebKitTestRunner's Web View
to be detected as occluded and causing a few _javascript_ timer layout
tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
by initializing the page visibility to "visible" after creating the view.
But a better solution is to disable window occlusion detection, so that
not only the page but also the view is treated as visible.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions): Remove call to
setVisibilityState, since it is no longer necessary.
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView): Disable window occlusion
detection for the created WKView.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm




Diff

Modified: trunk/Tools/ChangeLog (144414 => 144415)

--- trunk/Tools/ChangeLog	2013-03-01 05:41:23 UTC (rev 144414)
+++ trunk/Tools/ChangeLog	2013-03-01 05:46:21 UTC (rev 144415)
@@ -1,3 +1,24 @@
+2013-02-28  Kiran Muppala  
+
+Disable window occlusion detection for WebKitTestRunner Web View on Mac
+https://bugs.webkit.org/show_bug.cgi?id=16
+
+Reviewed by Simon Fraser.
+
+Window occlusion notifications were causing WebKitTestRunner's Web View
+to be detected as occluded and causing a few _javascript_ timer layout
+tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
+by initializing the page visibility to "visible" after creating the view.
+But a better solution is to disable window occlusion detection, so that
+not only the page but also the view is treated as visible.
+
+* WebKitTestRunner/TestController.cpp:
+(WTR::TestController::createWebViewWithOptions): Remove call to
+setVisibilityState, since it is no longer necessary.
+* WebKitTestRunner/mac/PlatformWebViewMac.mm:
+(WTR::PlatformWebView::PlatformWebView): Disable window occlusion
+detection for the created WKView.
+
 2013-02-28  Li Yin  
 
 [chromium] Events can't be triggered on MediaStreamTrack


Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (144414 => 144415)

--- trunk/Tools/WebKitTestRunner/TestController.cpp	2013-03-01 05:41:23 UTC (rev 144414)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp	2013-03-01 05:46:21 UTC (rev 144415)
@@ -482,10 +482,6 @@
 0, // unableToImplementPolicy
 };
 WKPageSetPagePolicyClient(m_mainWebView->page(), &pagePolicyClient);
-
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
-setVisibilityState(kWKPageVisibilityStateVisible, true);
-#endif
 }
 
 void TestController::ensureViewSupportsOptions(WKDictionaryRef options)


Modified: trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm (144414 => 144415)

--- trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm	2013-03-01 05:41:23 UTC (rev 144414)
+++ trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm	2013-03-01 05:46:21 UTC (rev 144415)
@@ -115,6 +115,7 @@
 
 NSRect rect = NSMakeRect(0, 0, 800, 600);
 m_view = [[TestRunnerWKView alloc] initWithFrame:rect contextRef:contextRef pageGroupRef:pageGroupRef useTiledDrawing:useTiledDrawing];
+[m_view setWindowOcclusionDetectionEnabled:NO];
 
 NSRect windowRect = NSOffsetRect(rect, -1, [(NSScreen *)[[NSScreen screens] objectAtIndex:0] frame].size.height - rect.size.height + 1);
 m_window = [[WebKitTestRunnerWindow alloc] initWithContentRect:windowRect styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:YES];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144414] trunk/LayoutTests

[commit-queue]

Title: [144414] trunk/LayoutTests








Revision 144414
Author commit-qu...@webkit.org
Date 2013-02-28 21:41:23 -0800 (Thu, 28 Feb 2013)


Log Message
[EFL] Gardening for some inspector tests
https://bugs.webkit.org/show_bug.cgi?id=31

Unreviewed gardening.

Patch by Seokju Kwon  on 2013-02-28

* platform/efl-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (144413 => 144414)

--- trunk/LayoutTests/ChangeLog	2013-03-01 05:03:34 UTC (rev 144413)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 05:41:23 UTC (rev 144414)
@@ -1,3 +1,12 @@
+2013-02-28  Seokju Kwon  
+
+[EFL] Gardening for some inspector tests
+https://bugs.webkit.org/show_bug.cgi?id=31
+
+Unreviewed gardening.
+
+* platform/efl-wk1/TestExpectations:
+
 2013-02-28  Sheriff Bot  
 
 Unreviewed, rolling out r144370.


Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (144413 => 144414)

--- trunk/LayoutTests/platform/efl-wk1/TestExpectations	2013-03-01 05:03:34 UTC (rev 144413)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations	2013-03-01 05:41:23 UTC (rev 144414)
@@ -155,6 +155,7 @@
 webkit.org/b/84589 fast/animation/request-animation-frame-during-modal.html [ Failure ]
 webkit.org/b/84589 fast/dom/Window/open-window-min-size.html [ Failure ]
 webkit.org/b/84589 http/tests/security/cross-frame-access-call.html [ Failure ]
+webkit.org/b/84589 inspector/console/console-long-eval-crash.html [ Failure ]
 
 # Needs custom policy delegate enhancement to log DOM node info - EFL port is missing DOM node abstraction
 webkit.org/b/87972 fast/forms/mailto/formenctype-attribute-button-html.html [ Failure ]
@@ -235,8 +236,7 @@
 fast/block/lineboxcontain/font.html
 
 # following tests started failing on EFL after r122952.
-inspector/styles/override-screen-size.html
-inspector/console/console-long-eval-crash.html
+webkit.org/b/82886 inspector/styles/override-screen-size.html
 inspector/timeline/timeline-paint.html
 
 # Incorrect rendering results after r115846






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144413] trunk

[commit-queue]

Title: [144413] trunk








Revision 144413
Author commit-qu...@webkit.org
Date 2013-02-28 21:03:34 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed, rolling out r144370.
http://trac.webkit.org/changeset/144370
https://bugs.webkit.org/show_bug.cgi?id=36

Caused 21 assertion failure at DocumentLoader.cpp(436)
(Requested by toyoshim on #webkit).

Patch by Sheriff Bot  on 2013-02-28

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::checkLoadComplete):

LayoutTests:

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (144412 => 144413)

--- trunk/LayoutTests/ChangeLog	2013-03-01 04:40:10 UTC (rev 144412)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 05:03:34 UTC (rev 144413)
@@ -1,3 +1,14 @@
+2013-02-28  Sheriff Bot  
+
+Unreviewed, rolling out r144370.
+http://trac.webkit.org/changeset/144370
+https://bugs.webkit.org/show_bug.cgi?id=36
+
+Caused 21 assertion failure at DocumentLoader.cpp(436)
+(Requested by toyoshim on #webkit).
+
+* platform/mac/TestExpectations:
+
 2013-02-28  Takashi Toyoshima  
 
 Unreviewed, chromium gardening; update expected image for Snow Leopard


Modified: trunk/LayoutTests/platform/mac/TestExpectations (144412 => 144413)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-03-01 04:40:10 UTC (rev 144412)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-03-01 05:03:34 UTC (rev 144413)
@@ -1439,6 +1439,7 @@
 
 webkit.org/b/110186 inspector-protocol/page/_javascript_DialogEvents.html [ Skip ]
 
+webkit.org/b/110554 http/tests/security/feed-urls-from-remote.html [ Failure ]
 webkit.org/b/110555 fast/canvas/canvas-currentPath.html [ Failure ]
 webkit.org/b/110555 fast/canvas/canvas-path-constructors.html [ Failure ]
 


Modified: trunk/Source/WebCore/ChangeLog (144412 => 144413)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 04:40:10 UTC (rev 144412)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 05:03:34 UTC (rev 144413)
@@ -1,3 +1,18 @@
+2013-02-28  Sheriff Bot  
+
+Unreviewed, rolling out r144370.
+http://trac.webkit.org/changeset/144370
+https://bugs.webkit.org/show_bug.cgi?id=36
+
+Caused 21 assertion failure at DocumentLoader.cpp(436)
+(Requested by toyoshim on #webkit).
+
+* dom/Document.cpp:
+(WebCore::Document::decrementActiveParserCount):
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::isLoading):
+(WebCore::DocumentLoader::checkLoadComplete):
+
 2013-02-28  Li Yin  
 
 [chromium] Events can't be triggered on MediaStreamTrack


Modified: trunk/Source/WebCore/dom/Document.cpp (144412 => 144413)

--- trunk/Source/WebCore/dom/Document.cpp	2013-03-01 04:40:10 UTC (rev 144412)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-03-01 05:03:34 UTC (rev 144413)
@@ -5808,7 +5808,12 @@
 --m_activeParserCount;
 if (!frame())
 return;
+// FIXME: This should always be enabled, but it seems to cause
+// http/tests/security/feed-urls-from-remote.html to timeout on Mac WK1
+// see http://webkit.org/b/110554 and http://webkit.org/b/110401
+#if ENABLE(THREADED_HTML_PARSER)
 loader()->checkLoadComplete();
+#endif
 frame()->loader()->checkLoadComplete();
 }
 


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (144412 => 144413)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2013-03-01 04:40:10 UTC (rev 144412)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2013-03-01 05:03:34 UTC (rev 144413)
@@ -287,8 +287,13 @@
 
 bool DocumentLoader::isLoading() const
 {
+// FIXME: This should always be enabled, but it seems to cause
+// http/tests/security/feed-urls-from-remote.html to timeout on Mac WK1
+// see http://webkit.org/b/110554 and http://webkit.org/b/110401
+#if ENABLE(THREADED_HTML_PARSER)
 if (document() && document()->hasActiveParser())
 return true;
+#endif
 return isLoadingMainResource() || !m_subresourceLoaders.isEmpty() || !m_plugInStreamLoaders.isEmpty();
 }
 
@@ -433,7 +438,11 @@
 {
 if (!m_frame || isLoading())
 return;
+#if !ENABLE(THREADED_HTML_PARSER)
+// This ASSERT triggers with the threaded HTML parser.
+// See https://bugs.webkit.org/show_bug.cgi?id=110937
 ASSERT(this == frameLoader()->activeDocumentLoader());
+#endif
 m_frame->document()->domWindow()->finishedLoading();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144412] trunk/LayoutTests

[toyoshim]

Title: [144412] trunk/LayoutTests








Revision 144412
Author toyos...@chromium.org
Date 2013-02-28 20:40:10 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed, chromium gardening; update expected image for Snow Leopard

* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (144411 => 144412)

--- trunk/LayoutTests/ChangeLog	2013-03-01 04:39:52 UTC (rev 144411)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 04:40:10 UTC (rev 144412)
@@ -1,3 +1,10 @@
+2013-02-28  Takashi Toyoshima  
+
+Unreviewed, chromium gardening; update expected image for Snow Leopard
+
+* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
+* platform/chromium/TestExpectations:
+
 2013-02-28  Stephen Chenney  
 
 [Chromium] Rebaselines for Win decorations-with-text-combine.html


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144411 => 144412)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-01 04:39:52 UTC (rev 144411)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-01 04:40:10 UTC (rev 144412)
@@ -4403,7 +4403,7 @@
 
 # Need rebaseline
 webkit.org/b/110654 [ Mac Win ] css2.1/20110323/replaced-elements-001.htm [ Failure ]
-webkit.org/b/109413 [ SnowLeopard Win Linux ] svg/custom/foreign-object-skew.svg [ Failure ]
+webkit.org/b/109413 [ Linux Win ] svg/custom/foreign-object-skew.svg [ Failure ]
 webkit.org/b/110654 [ Win ] tables/mozilla/bugs/bug92647-2.html [ Failure ]
 # New test
 webkit.org/b/110654 [ Mac Win ] css3/flexbox/button.html [ Failure ]


Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144411] trunk/Source/WebKit2

[commit-queue]

Title: [144411] trunk/Source/WebKit2








Revision 144411
Author commit-qu...@webkit.org
Date 2013-02-28 20:39:52 -0800 (Thu, 28 Feb 2013)


Log Message
[WK2] Refactoring : Fix indentation and braces in WebInspectorClient.h|cpp
https://bugs.webkit.org/show_bug.cgi?id=109925

Patch by Seokju Kwon  on 2013-02-28
Reviewed by Benjamin Poulain.

The contents of an outermost namespace block should not be indented.
And One-line control clauses should not use braces.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::closeInspectorFrontend):
* WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebCore):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (144410 => 144411)

--- trunk/Source/WebKit2/ChangeLog	2013-03-01 04:37:55 UTC (rev 144410)
+++ trunk/Source/WebKit2/ChangeLog	2013-03-01 04:39:52 UTC (rev 144411)
@@ -1,3 +1,18 @@
+2013-02-28  Seokju Kwon  
+
+[WK2] Refactoring : Fix indentation and braces in WebInspectorClient.h|cpp
+https://bugs.webkit.org/show_bug.cgi?id=109925
+
+Reviewed by Benjamin Poulain.
+
+The contents of an outermost namespace block should not be indented.
+And One-line control clauses should not use braces.
+
+* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+(WebKit::WebInspectorClient::closeInspectorFrontend):
+* WebProcess/WebCoreSupport/WebInspectorClient.h:
+(WebCore):
+
 2013-02-28  Kiran Muppala  
 
 Add a pre-bootstrap message for NetworkProcess XPC service


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp (144410 => 144411)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp	2013-03-01 04:37:55 UTC (rev 144410)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp	2013-03-01 04:39:52 UTC (rev 144411)
@@ -52,9 +52,8 @@
 
 void WebInspectorClient::closeInspectorFrontend()
 {
-if (m_page->inspector()) {
+if (m_page->inspector())
 m_page->inspector()->didClose();
-}
 }
 
 void WebInspectorClient::bringFrontendToFront()


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h (144410 => 144411)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h	2013-03-01 04:37:55 UTC (rev 144410)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h	2013-03-01 04:39:52 UTC (rev 144411)
@@ -34,8 +34,8 @@
 #include 
 
 namespace WebCore {
-class GraphicsContext;
-class IntRect;
+class GraphicsContext;
+class IntRect;
 }
 
 namespace WebKit {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144409] trunk/Source/WebKit2

[commit-queue]

Title: [144409] trunk/Source/WebKit2








Revision 144409
Author commit-qu...@webkit.org
Date 2013-02-28 20:18:44 -0800 (Thu, 28 Feb 2013)


Log Message
Add a pre-bootstrap message for NetworkProcess XPC service
https://bugs.webkit.org/show_bug.cgi?id=27

Patch by Kiran Muppala  on 2013-02-28
Reviewed by Sam Weinig.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(WebKit::XPCServiceEventHandler): Hold on to the pre-bootstrap message.
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler): Ditto.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService): Send a pre-bootstrap message for NetworkProcess
XPC service.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm
trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm
trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (144408 => 144409)

--- trunk/Source/WebKit2/ChangeLog	2013-03-01 03:35:07 UTC (rev 144408)
+++ trunk/Source/WebKit2/ChangeLog	2013-03-01 04:18:44 UTC (rev 144409)
@@ -1,3 +1,18 @@
+2013-02-28  Kiran Muppala  
+
+Add a pre-bootstrap message for NetworkProcess XPC service
+https://bugs.webkit.org/show_bug.cgi?id=27
+
+Reviewed by Sam Weinig.
+
+* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
+(WebKit::XPCServiceEventHandler): Hold on to the pre-bootstrap message.
+* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
+(WebKit::XPCServiceEventHandler): Ditto.
+* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+(WebKit::connectToService): Send a pre-bootstrap message for NetworkProcess
+XPC service.
+
 2013-02-28  Conrad Shultz  
 
 Need API to control page underlay color


Modified: trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm (144408 => 144409)

--- trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm	2013-03-01 03:35:07 UTC (rev 144408)
+++ trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm	2013-03-01 04:18:44 UTC (rev 144409)
@@ -124,6 +124,11 @@
 
 initializerFunctionPtr(peer, event);
 }
+
+if (!strcmp(xpc_dictionary_get_string(event, "message-name"), "pre-bootstrap")) {
+// Hold on to the pre-bootstrap message.
+xpc_retain(event);
+}
 }
 });
 


Modified: trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm (144408 => 144409)

--- trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm	2013-03-01 03:35:07 UTC (rev 144408)
+++ trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm	2013-03-01 04:18:44 UTC (rev 144409)
@@ -59,6 +59,11 @@
 
 initializerFunctionPtr(peer, event);
 }
+
+if (!strcmp(xpc_dictionary_get_string(event, "message-name"), "pre-bootstrap")) {
+// Hold on to the pre-bootstrap message.
+xpc_retain(event);
+}
 }
 });
 


Modified: trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm (144408 => 144409)

--- trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm	2013-03-01 03:35:07 UTC (rev 144408)
+++ trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm	2013-03-01 04:18:44 UTC (rev 144409)
@@ -188,6 +188,15 @@
 xpc_connection_set_event_handler(connection, ^(xpc_object_t event) { });
 xpc_connection_resume(connection);
 
+#if ENABLE(NETWORK_PROCESS)
+if (launchOptions.processType == ProcessLauncher::NetworkProcess) {
+xpc_object_t preBootstrapMessage = xpc_dictionary_create(0, 0, 0);
+xpc_dictionary_set_string(preBootstrapMessage, "message-name", "pre-bootstrap");
+xpc_connection_send_message(connection, preBootstrapMessage);
+xpc_release(preBootstrapMessage);
+}
+#endif
+
 // Create the listening port.
 mach_port_t listeningPort;
 mach_port_allocate(mach_task_self(), MACH_PORT_RIGHT_RECEIVE, &listeningPort);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144408] trunk/Source

[commit-queue]

Title: [144408] trunk/Source








Revision 144408
Author commit-qu...@webkit.org
Date 2013-02-28 19:35:07 -0800 (Thu, 28 Feb 2013)


Log Message
WebKit API for enabling DOM logging for certain worlds
https://bugs.webkit.org/show_bug.cgi?id=110779

Source/WebCore:

Patch by Ankur Taly  on 2013-02-28
Reviewed by Adam Barth.

Adds additional static methods to DOMWrapperWorld for managing the
mapping between worldIDs and logger objects (where DOM logging messages
are sent), and also defines a class (V8DOMActivityLogger) for logger
objects.

* WebCore.gypi:
* bindings/v8/DOMWrapperWorld.cpp:
(WebCore):
(WebCore::domActivityLoggers):
(WebCore::DOMWrapperWorld::setDOMActivityLogger):
(WebCore::DOMWrapperWorld::getDOMActivityLogger):
* bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
* bindings/v8/V8DOMActivityLogger.h: Added.
(WebCore):
(V8DOMActivityLogger):
(WebCore::V8DOMActivityLogger::~V8DOMActivityLogger):
(WebCore::V8DOMActivityLogger::log):

Source/WebKit/chromium:

Patch by Ankur Taly  on 2013-02-28
Reviewed by Adam Barth.

This patch adds initial plumbing for enabling logging of DOM
activity by _javascript_ code running withing v8, on a
per-world basis. In particular it adds methods to the chromium
WebKit API for associating a logger object with world ids for which
DOM activity logging is enabled.

* WebKit.gyp:
* public/WebDOMActivityLogger.h: Added.
(v8):
(WebKit):
(WebDOMActivityLogger):
(WebKit::WebDOMActivityLogger::~WebDOMActivityLogger):
(WebKit::WebDOMActivityLogger::log):
* src/WebDOMActivityLogger.cpp: Added.
(WebKit):
(DOMActivityLoggerContainer):
(WebKit::DOMActivityLoggerContainer::DOMActivityLoggerContainer):
(WebKit::DOMActivityLoggerContainer::~DOMActivityLoggerContainer):
(WebKit::DOMActivityLoggerContainer::log):
(WebKit::hasDOMActivityLogger):
(WebKit::setDOMActivityLogger):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.cpp
trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.h
trunk/Source/WebKit/chromium/ChangeLog


Added Paths

trunk/Source/WebCore/bindings/v8/V8DOMActivityLogger.h
trunk/Source/WebKit/chromium/public/WebDOMActivityLogger.h
trunk/Source/WebKit/chromium/src/WebDOMActivityLogger.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144407 => 144408)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 02:12:54 UTC (rev 144407)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 03:35:07 UTC (rev 144408)
@@ -1,3 +1,29 @@
+2013-02-28  Ankur Taly  
+
+WebKit API for enabling DOM logging for certain worlds
+https://bugs.webkit.org/show_bug.cgi?id=110779
+
+Reviewed by Adam Barth.
+
+Adds additional static methods to DOMWrapperWorld for managing the
+mapping between worldIDs and logger objects (where DOM logging messages
+are sent), and also defines a class (V8DOMActivityLogger) for logger
+objects.
+
+* WebCore.gypi:
+* bindings/v8/DOMWrapperWorld.cpp:
+(WebCore):
+(WebCore::domActivityLoggers):
+(WebCore::DOMWrapperWorld::setDOMActivityLogger):
+(WebCore::DOMWrapperWorld::getDOMActivityLogger):
+* bindings/v8/DOMWrapperWorld.h:
+(DOMWrapperWorld):
+* bindings/v8/V8DOMActivityLogger.h: Added.
+(WebCore):
+(V8DOMActivityLogger):
+(WebCore::V8DOMActivityLogger::~V8DOMActivityLogger):
+(WebCore::V8DOMActivityLogger::log):
+
 2013-02-28  Adam Barth  
 
 The threaded HTML parser shouldn't need to invalidate the speculation buffer on every document.write


Modified: trunk/Source/WebCore/WebCore.gypi (144407 => 144408)

--- trunk/Source/WebCore/WebCore.gypi	2013-03-01 02:12:54 UTC (rev 144407)
+++ trunk/Source/WebCore/WebCore.gypi	2013-03-01 03:35:07 UTC (rev 144408)
@@ -1270,6 +1270,7 @@
 'bindings/v8/V8Collection.h',
 'bindings/v8/V8DOMConfiguration.cpp',
 'bindings/v8/V8DOMConfiguration.h',
+'bindings/v8/V8DOMActivityLogger.h',
 'bindings/v8/V8DOMWindowShell.cpp',
 'bindings/v8/V8DOMWindowShell.h',
 'bindings/v8/V8DOMWrapper.cpp',


Modified: trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.cpp (144407 => 144408)

--- trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.cpp	2013-03-01 02:12:54 UTC (rev 144407)
+++ trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.cpp	2013-03-01 03:35:07 UTC (rev 144408)
@@ -33,8 +33,10 @@
 
 #include "DOMDataStore.h"
 #include "V8Binding.h"
+#include "V8DOMActivityLogger.h"
 #include "V8DOMWindow.h"
 #include "V8DOMWrapper.h"
+#include 
 #include 
 #include 
 
@@ -220,4 +222,24 @@
 isolatedWorldContentSecurityPolicies().remove(worldID);
 }
 
+typedef HashMap, WTF::IntHash, WTF::UnsignedWithZeroKeyHashTraits > DOMActivityLoggerMap; 
+static DOMActivityLoggerMap& domActivityLoggers()
+{
+ASSERT(isMainThread());
+DEFINE_STATIC_LOCAL(DOMActivityLoggerMap, map, ());
+return map;
+}
+
+void DOMWrapperWorld::s

[webkit-changes] [144407] trunk/Source/WebCore

[abarth]

Title: [144407] trunk/Source/WebCore








Revision 144407
Author aba...@webkit.org
Date 2013-02-28 18:12:54 -0800 (Thu, 28 Feb 2013)


Log Message
The threaded HTML parser shouldn't need to invalidate the speculation buffer on every document.write
https://bugs.webkit.org/show_bug.cgi?id=30

Reviewed by Eric Seidel.

Previously, the threaded HTML parser always invalidated its speculation
buffer when it received a document.write.  That means we performed
poorly on web sites that contained document.write calls early in the
page.

This patch teaches the HTMLDocumentParser that we don't need to discard
the speculation buffer in the common case of starting and ending in the
DataState.

* html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::checkForSpeculationFailure):
(WebCore::HTMLDocumentParser::didFailSpeculation):
* html/parser/HTMLDocumentParser.h:
(WebCore):
(ParsedChunk):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/BackgroundHTMLParser.cpp
trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp
trunk/Source/WebCore/html/parser/HTMLDocumentParser.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (144406 => 144407)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 02:11:42 UTC (rev 144406)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 02:12:54 UTC (rev 144407)
@@ -1,3 +1,28 @@
+2013-02-28  Adam Barth  
+
+The threaded HTML parser shouldn't need to invalidate the speculation buffer on every document.write
+https://bugs.webkit.org/show_bug.cgi?id=30
+
+Reviewed by Eric Seidel.
+
+Previously, the threaded HTML parser always invalidated its speculation
+buffer when it received a document.write.  That means we performed
+poorly on web sites that contained document.write calls early in the
+page.
+
+This patch teaches the HTMLDocumentParser that we don't need to discard
+the speculation buffer in the common case of starting and ending in the
+DataState.
+
+* html/parser/BackgroundHTMLParser.cpp:
+(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::checkForSpeculationFailure):
+(WebCore::HTMLDocumentParser::didFailSpeculation):
+* html/parser/HTMLDocumentParser.h:
+(WebCore):
+(ParsedChunk):
+
 2013-02-28  Eberhard Graether  
 
 WebInspector: Switch hide element shortcut in ElementsPanel to use a selector


Modified: trunk/Source/WebCore/html/parser/BackgroundHTMLParser.cpp (144406 => 144407)

--- trunk/Source/WebCore/html/parser/BackgroundHTMLParser.cpp	2013-03-01 02:11:42 UTC (rev 144406)
+++ trunk/Source/WebCore/html/parser/BackgroundHTMLParser.cpp	2013-03-01 02:12:54 UTC (rev 144407)
@@ -279,6 +279,7 @@
 OwnPtr chunk = adoptPtr(new HTMLDocumentParser::ParsedChunk);
 chunk->tokens = m_pendingTokens.release();
 chunk->preloads.swap(m_pendingPreloads);
+chunk->tokenizerState = m_tokenizer->state();
 chunk->inputCheckpoint = m_input.createCheckpoint();
 chunk->preloadScannerCheckpoint = m_preloadScanner->createCheckpoint();
 callOnMainThread(bind(&HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser, m_parser, chunk.release()));


Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (144406 => 144407)

--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp	2013-03-01 02:11:42 UTC (rev 144406)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp	2013-03-01 02:12:54 UTC (rev 144407)
@@ -332,16 +332,24 @@
 {
 if (!m_tokenizer)
 return;
-// FIXME: If the tokenizer is in the same state as when we started this function,
-// then we haven't necessarily failed our speculation.
+if (!m_currentChunk)
+return;
+// Currently we're only smart enough to reuse the speculation buffer if the tokenizer
+// both starts and ends in the DataState. That state is simplest because the HTMLToken
+// is always in the Uninitialized state. We should consider whether we can reuse the
+// speculation buffer in other states, but we'd likely need to do something more
+// sophisticated with the HTMLToken.
+if (m_currentChunk->tokenizerState == HTMLTokenizer::DataState && m_tokenizer->state() == HTMLTokenizer::DataState && m_input.current().isEmpty()) {
+ASSERT(m_token->isUninitialized());
+m_tokenizer.clear();
+m_token.clear();
+return;
+}
 didFailSpeculation(m_token.release(), m_tokenizer.release());
 }
 
 void HTMLDocumentParser::didFailSpeculation(PassOwnPtr token, PassOwnPtr tokenizer)
 {
-if (!m_currentChunk)
-return;
-
 m_weakFactory.revokeAll();
 m_speculations.clear();
 


Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.h (144406 => 144407)

--- trunk/Source/WebCore/html/p

[webkit-changes] [144406] trunk/LayoutTests

[schenney]

Title: [144406] trunk/LayoutTests








Revision 144406
Author schen...@chromium.org
Date 2013-02-28 18:11:42 -0800 (Thu, 28 Feb 2013)


Log Message
[Chromium] Rebaselines for Win decorations-with-text-combine.html

Unreviewed expectations update.

* platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.png:
* platform/chromium-win/fast/text/decorations-with-text-combine-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/fast/text/decorations-with-text-combine-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (144405 => 144406)

--- trunk/LayoutTests/ChangeLog	2013-03-01 01:58:44 UTC (rev 144405)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 02:11:42 UTC (rev 144406)
@@ -1,3 +1,12 @@
+2013-02-28  Stephen Chenney  
+
+[Chromium] Rebaselines for Win decorations-with-text-combine.html
+
+Unreviewed expectations update.
+
+* platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.png:
+* platform/chromium-win/fast/text/decorations-with-text-combine-expected.png:
+
 2013-02-28  Eberhard Graether  
 
 WebInspector: Switch hide element shortcut in ElementsPanel to use a selector


Modified: trunk/LayoutTests/platform/chromium-win/fast/text/decorations-with-text-combine-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144405] trunk

[commit-queue]

Title: [144405] trunk








Revision 144405
Author commit-qu...@webkit.org
Date 2013-02-28 17:58:44 -0800 (Thu, 28 Feb 2013)


Log Message
WebInspector: Switch hide element shortcut in ElementsPanel to use a selector
https://bugs.webkit.org/show_bug.cgi?id=110641

Patch by Eberhard Graether  on 2013-02-28
Reviewed by Pavel Feldman.

This change switches the shortcut for adding visibility:hidden to an element's style
to toggling a class name on the element and injecting a style rule into the element's
document instead. This way it is possible to change the visibility of all child
elements as well.

Test: inspector/elements/hide-shortcut.html

Source/WebCore:

* inspector/front-end/CSSStyleModel.js:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._onkeydown):
(WebInspector.ElementsTreeOutline.prototype.resolvedNode.toggleClassAndInjectStyleRule):
(WebInspector.ElementsTreeOutline.prototype.):
(WebInspector.ElementsTreeOutline.prototype._toggleHideShortcut):

LayoutTests:

* inspector/elements/hide-shortcut-expected.txt: Added.
* inspector/elements/hide-shortcut.html: Added.
* inspector/elements/resources/hide-shortcut-iframe.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js


Added Paths

trunk/LayoutTests/inspector/elements/hide-shortcut-expected.txt
trunk/LayoutTests/inspector/elements/hide-shortcut.html
trunk/LayoutTests/inspector/elements/resources/hide-shortcut-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (144404 => 144405)

--- trunk/LayoutTests/ChangeLog	2013-03-01 01:53:51 UTC (rev 144404)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 01:58:44 UTC (rev 144405)
@@ -1,3 +1,21 @@
+2013-02-28  Eberhard Graether  
+
+WebInspector: Switch hide element shortcut in ElementsPanel to use a selector
+https://bugs.webkit.org/show_bug.cgi?id=110641
+
+Reviewed by Pavel Feldman.
+
+This change switches the shortcut for adding visibility:hidden to an element's style
+to toggling a class name on the element and injecting a style rule into the element's
+document instead. This way it is possible to change the visibility of all child
+elements as well.
+
+Test: inspector/elements/hide-shortcut.html
+
+* inspector/elements/hide-shortcut-expected.txt: Added.
+* inspector/elements/hide-shortcut.html: Added.
+* inspector/elements/resources/hide-shortcut-iframe.html: Added.
+
 2013-02-28  Seokju Kwon  
 
 [EFL] Focus problem in inspector/extensions/extensions-panel.html


Added: trunk/LayoutTests/inspector/elements/hide-shortcut-expected.txt (0 => 144405)

--- trunk/LayoutTests/inspector/elements/hide-shortcut-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/elements/hide-shortcut-expected.txt	2013-03-01 01:58:44 UTC (rev 144405)
@@ -0,0 +1,27 @@
+Tests the hide shortcut, which toggles visibility:hidden on the node and it's ancestors. Bug 110641
+
+parent
+child
+
+
+Running: testSetUp
+
+Running: testToggleHideShortcutOn
+=== Added hide shortcut ===
+=== Parent node is hidden ===
+visibility: hidden;
+=== Child node is hidden ===
+visibility: hidden;
+
+Running: testToggleHideShortcutOff
+=== Removed hide shortcut ===
+=== Parent node is visible ===
+visibility: visible;
+=== Child node is visible ===
+visibility: visible;
+
+Running: testToggleHideShortcutOnInFrame
+=== Added hide shortcut in frame ===
+=== Frame node is hidden ===
+visibility: hidden;
+


Added: trunk/LayoutTests/inspector/elements/hide-shortcut.html (0 => 144405)

--- trunk/LayoutTests/inspector/elements/hide-shortcut.html	(rev 0)
+++ trunk/LayoutTests/inspector/elements/hide-shortcut.html	2013-03-01 01:58:44 UTC (rev 144405)
@@ -0,0 +1,128 @@
+
+
+
+
+function test()
+{
+var treeOutline;
+var parentNode;
+var childNode;
+var frameNode;
+
+WebInspector.showPanel("elements");
+InspectorTest.runTestSuite([
+function testSetUp(next)
+{
+treeOutline = WebInspector.panels.elements.treeOutline;
+
+InspectorTest.nodeWithId("parent-node", callback);
+
+function callback(node)
+{
+parentNode = node
+InspectorTest.nodeWithId("child-node", callback2);
+}
+
+function callback2(node)
+{
+childNode = node;
+InspectorTest.nodeWithId("frame-node", callback3);
+}
+
+function callback3(node)
+{
+frameNode = node;
+next();
+}
+},
+
+function testToggleHideShortcutOn(next)
+{
+treeOutline._toggleHideShortcut(parentNode, callback);
+
+function callback()
+{
+InspectorTest.addRe

[webkit-changes] [144403] trunk

[commit-queue]

Title: [144403] trunk








Revision 144403
Author commit-qu...@webkit.org
Date 2013-02-28 17:51:26 -0800 (Thu, 28 Feb 2013)


Log Message
[EFL] Focus problem in inspector/extensions/extensions-panel.html
https://bugs.webkit.org/show_bug.cgi?id=97077

Patch by Seokju Kwon  on 2013-02-28
Reviewed by Laszlo Gombos.

Source/WebKit/efl:

* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorFrontendClientEfl::bringToFront): Set focus on inspectorView.

LayoutTests:

Remove inspector/extensions/extensions-panel.html from TestExpectations.

* platform/efl-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk1/TestExpectations
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (144402 => 144403)

--- trunk/LayoutTests/ChangeLog	2013-03-01 01:50:08 UTC (rev 144402)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 01:51:26 UTC (rev 144403)
@@ -1,3 +1,14 @@
+2013-02-28  Seokju Kwon  
+
+[EFL] Focus problem in inspector/extensions/extensions-panel.html
+https://bugs.webkit.org/show_bug.cgi?id=97077
+
+Reviewed by Laszlo Gombos.
+
+Remove inspector/extensions/extensions-panel.html from TestExpectations.
+
+* platform/efl-wk1/TestExpectations:
+
 2013-02-28  Levi Weintraub  
 
 Stale FrameSelection in removed iframe causes crash


Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (144402 => 144403)

--- trunk/LayoutTests/platform/efl-wk1/TestExpectations	2013-03-01 01:50:08 UTC (rev 144402)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations	2013-03-01 01:51:26 UTC (rev 144403)
@@ -262,9 +262,6 @@
 webkit.org/b/87972 fast/loader/policy-delegate-action-hit-test-zoomed.html [ Failure ]
 webkit.org/b/87972 fast/encoding/mailto-always-utf-8.html [ Failure ]
 
-# Frame does not get focus as expected
-webkit.org/b/97077 inspector/extensions/extensions-panel.html [ Failure ]
-
 # Fails after r133322
 webkit.org/b/98523 fast/images/repaint-subrect-grid.html [ Failure ]
 


Modified: trunk/Source/WebKit/efl/ChangeLog (144402 => 144403)

--- trunk/Source/WebKit/efl/ChangeLog	2013-03-01 01:50:08 UTC (rev 144402)
+++ trunk/Source/WebKit/efl/ChangeLog	2013-03-01 01:51:26 UTC (rev 144403)
@@ -1,3 +1,13 @@
+2013-02-28  Seokju Kwon  
+
+[EFL] Focus problem in inspector/extensions/extensions-panel.html
+https://bugs.webkit.org/show_bug.cgi?id=97077
+
+Reviewed by Laszlo Gombos.
+
+* WebCoreSupport/InspectorClientEfl.cpp:
+(WebCore::InspectorFrontendClientEfl::bringToFront): Set focus on inspectorView.
+
 2013-02-23  Jason Anderssen  
 
 Move setAutofilled from TestRunner to WebCore


Modified: trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp (144402 => 144403)

--- trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp	2013-03-01 01:50:08 UTC (rev 144402)
+++ trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp	2013-03-01 01:51:26 UTC (rev 144403)
@@ -175,7 +175,7 @@
 
 void InspectorFrontendClientEfl::bringToFront()
 {
-notImplemented();
+evas_object_focus_set(m_inspectorView, true);
 }
 
 void InspectorFrontendClientEfl::closeWindow()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144401] trunk/Source/JavaScriptCore

[fpizlo]

Title: [144401] trunk/Source/_javascript_Core








Revision 144401
Author fpi...@apple.com
Date 2013-02-28 17:32:03 -0800 (Thu, 28 Feb 2013)


Log Message
DFG CFA should not do liveness pruning
https://bugs.webkit.org/show_bug.cgi?id=19

Reviewed by Mark Hahnenberg.

It adds complexity and probably buys nothing.  Moreover, I'm transitioning to having
liveness only available at the bitter end of compilation, so this will stop working
after https://bugs.webkit.org/show_bug.cgi?id=109389 anyway.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::mergeStateAtTail):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (144400 => 144401)

--- trunk/Source/_javascript_Core/ChangeLog	2013-03-01 01:24:47 UTC (rev 144400)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-03-01 01:32:03 UTC (rev 144401)
@@ -1,5 +1,20 @@
 2013-02-28  Filip Pizlo  
 
+DFG CFA should not do liveness pruning
+https://bugs.webkit.org/show_bug.cgi?id=19
+
+Reviewed by Mark Hahnenberg.
+
+It adds complexity and probably buys nothing.  Moreover, I'm transitioning to having
+liveness only available at the bitter end of compilation, so this will stop working
+after https://bugs.webkit.org/show_bug.cgi?id=109389 anyway.
+
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::initialize):
+(JSC::DFG::AbstractState::mergeStateAtTail):
+
+2013-02-28  Filip Pizlo  
+
 Don't try to emit profiling if you don't have the DFG JIT.
 
 Rubber stamped by Mark Hahnenberg.


Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (144400 => 144401)

--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp	2013-03-01 01:24:47 UTC (rev 144400)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp	2013-03-01 01:32:03 UTC (rev 144401)
@@ -89,13 +89,6 @@
 for (size_t i = 0; i < root->valuesAtHead.numberOfArguments(); ++i) {
 Node* node = root->variablesAtHead.argument(i);
 ASSERT(node->op() == SetArgument);
-if (!node->shouldGenerate()) {
-// The argument is dead. We don't do any checks for such arguments, and so
-// for the purpose of the analysis, they contain no value.
-root->valuesAtHead.argument(i).clear();
-continue;
-}
-
 if (!node->variableAccessData()->shouldUnboxIfPossible()) {
 root->valuesAtHead.argument(i).makeTop();
 continue;
@@ -1616,20 +1609,6 @@
 dataLogF(" from last access due to captured variable.\n");
 #endif
 } else {
-if (!node->shouldGenerate()) {
-// If the node at tail is a GetLocal that is dead, then skip it to get to the Phi.
-// The Phi may be live.
-if (node->op() != GetLocal)
-return false;
-
-node = node->child1().node();
-ASSERT(node->op() == Phi);
-if (!node->shouldGenerate())
-return false;
-}
-
-ASSERT(node->shouldGenerate());
-
 #if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE)
 dataLogF("  It's live, node @%u.\n", node->index());
 #endif
@@ -1649,6 +1628,18 @@
 break;
 
 case GetLocal:
+// If the GetLocal is dead, then we transfer from head to tail.
+// FIXME: We can get rid of this case after https://bugs.webkit.org/show_bug.cgi?id=109389
+if (!node->shouldGenerate()) {
+// The block transfers the value from head to tail.
+source = inVariable;
+#if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE)
+dataLogF("  Transfering ");
+source.dump(WTF::dataFile());
+dataLogF(" from head to tail (dead GetLocal case).\n");
+#endif
+break;
+}
 // The block refines the value with additional speculations.
 source = forNode(node);
 #if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144400] trunk

[leviw]

Title: [144400] trunk








Revision 144400
Author le...@chromium.org
Date 2013-02-28 17:24:47 -0800 (Thu, 28 Feb 2013)


Log Message
Stale FrameSelection in removed iframe causes crash
https://bugs.webkit.org/show_bug.cgi?id=108696

Reviewed by Ryosuke Niwa.

Source/WebCore:

Catching a specific issue where selectFrameElementInParentIfFullySelected in a nested
iFrame that is removed can leave the outer frame's selection referencing stale nodes.
Instead, in this case, we keep the frame alive long enough to check for this condition
and clear our selection if we hit it.

Test: editing/selection/selection-in-iframe-removed-crash.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):

LayoutTests:

* editing/selection/selection-in-iframe-removed-crash-expected.txt: Added.
* editing/selection/selection-in-iframe-removed-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp


Added Paths

trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash-expected.txt
trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (144399 => 144400)

--- trunk/LayoutTests/ChangeLog	2013-03-01 01:01:31 UTC (rev 144399)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 01:24:47 UTC (rev 144400)
@@ -1,3 +1,13 @@
+2013-02-28  Levi Weintraub  
+
+Stale FrameSelection in removed iframe causes crash
+https://bugs.webkit.org/show_bug.cgi?id=108696
+
+Reviewed by Ryosuke Niwa.
+
+* editing/selection/selection-in-iframe-removed-crash-expected.txt: Added.
+* editing/selection/selection-in-iframe-removed-crash.html: Added.
+
 2013-02-28  Stephen Chenney  
 
 [Chromium] Rebaselines for Mac decorations-with-text-combine.html


Added: trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash-expected.txt (0 => 144400)

--- trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash-expected.txt	2013-03-01 01:24:47 UTC (rev 144400)
@@ -0,0 +1 @@
+Test passes if it does not crash. 


Added: trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash.html (0 => 144400)

--- trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash.html	(rev 0)
+++ trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash.html	2013-03-01 01:24:47 UTC (rev 144400)
@@ -0,0 +1,28 @@
+
+
+Test passes if it does not crash.
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var docElement = document.documentElement;
+function crash() {
+iframe1 = document.createElementNS("http://www.w3.org/1999/xhtml", "iframe");
+iframe1.setAttribute("srcdoc", "ABC");
+docElement.appendChild(iframe1);
+document1 = document.implementation.createDocument("", null);
+iframe1.addEventListener("DOMFocusOut", function () { document1.adoptNode(iframe1); }, false);
+iframe1.focus();
+setTimeout("finish();", 0);
+}
+
+function finish() {
+document.designMode = "on";
+range1 = document.createRange();
+range1.selectNodeContents(iframe1.contentDocument);
+window.getSelection().addRange(range1);
+}
+
+document.addEventListener("DOMContentLoaded", crash, false);
+
+


Modified: trunk/Source/WebCore/ChangeLog (144399 => 144400)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 01:01:31 UTC (rev 144399)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 01:24:47 UTC (rev 144400)
@@ -1,3 +1,20 @@
+2013-02-28  Levi Weintraub  
+
+Stale FrameSelection in removed iframe causes crash
+https://bugs.webkit.org/show_bug.cgi?id=108696
+
+Reviewed by Ryosuke Niwa.
+
+Catching a specific issue where selectFrameElementInParentIfFullySelected in a nested
+iFrame that is removed can leave the outer frame's selection referencing stale nodes.
+Instead, in this case, we keep the frame alive long enough to check for this condition
+and clear our selection if we hit it.
+
+Test: editing/selection/selection-in-iframe-removed-crash.html
+
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::setSelection):
+
 2013-02-28  Conrad Shultz  
 
 Need API to control page underlay color


Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (144399 => 144400)

--- trunk/Source/WebCore/editing/FrameSelection.cpp	2013-03-01 01:01:31 UTC (rev 144399)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp	2013-03-01 01:24:47 UTC (rev 144400)
@@ -280,7 +280,13 @@
 if (s.base().anchorNode()) {
 Document* document = s.base().anchorNode()->document();
 if (document && document->frame() && document->frame() != m_frame && document != m_frame->document()) {
+RefPtr guard = document->frame();
 document->frame()->selection()->setSelection(s,

[webkit-changes] [144399] trunk/Source/WebCore

[roger_fong]

Title: [144399] trunk/Source/WebCore








Revision 144399
Author roger_f...@apple.com
Date 2013-02-28 17:01:31 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed. AppleWin VS2010 build fix.

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters




Diff

Modified: trunk/Source/WebCore/ChangeLog (144398 => 144399)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 00:50:37 UTC (rev 144398)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 01:01:31 UTC (rev 144399)
@@ -68,6 +68,13 @@
 
 2013-02-28  Roger Fong  
 
+Unreviewed. AppleWin VS2010 build fix.
+
+* WebCore.vcxproj/WebCore.vcxproj:
+* WebCore.vcxproj/WebCore.vcxproj.filters:
+
+2013-02-28  Roger Fong  
+
 Unreviewed. AppleWin Build fix.
 
 * WebCore.vcproj/WebCore.vcproj:


Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (144398 => 144399)

--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj	2013-03-01 00:50:37 UTC (rev 144398)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj	2013-03-01 01:01:31 UTC (rev 144399)
@@ -3538,8 +3538,6 @@
 
 
 
-
-
 
 
 
@@ -11127,4 +11125,4 @@
   
   
   
-
+
\ No newline at end of file


Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (144398 => 144399)

--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters	2013-03-01 00:50:37 UTC (rev 144398)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters	2013-03-01 01:01:31 UTC (rev 144399)
@@ -3237,12 +3237,6 @@
 
   platform\network
 
-
-  platform\network
-
-
-  platform\network
-
 
   platform\network
 
@@ -15270,4 +15264,4 @@
   rendering
 
   
-
+
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144398] trunk/Tools

[jamesr]

Title: [144398] trunk/Tools








Revision 144398
Author jam...@google.com
Date 2013-02-28 16:50:37 -0800 (Thu, 28 Feb 2013)


Log Message
[chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
https://bugs.webkit.org/show_bug.cgi?id=111017

Reviewed by Adam Barth.

This decouples DumpRenderTree from WebLayerTreeViewClient.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHostDRTLayerTreeViewClient):
(WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
(WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
(WebViewHostDRTLayerTreeViewClient::Layout):
(WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
(WebViewHost::initializeLayerTreeView):
* DumpRenderTree/chromium/WebViewHost.h:
(webkit_support):
(WebViewHost):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Tools/ChangeLog (144397 => 144398)

--- trunk/Tools/ChangeLog	2013-03-01 00:47:10 UTC (rev 144397)
+++ trunk/Tools/ChangeLog	2013-03-01 00:50:37 UTC (rev 144398)
@@ -1,3 +1,23 @@
+2013-02-27  James Robinson  
+
+[chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
+https://bugs.webkit.org/show_bug.cgi?id=111017
+
+Reviewed by Adam Barth.
+
+This decouples DumpRenderTree from WebLayerTreeViewClient.
+
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHostDRTLayerTreeViewClient):
+(WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
+(WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
+(WebViewHostDRTLayerTreeViewClient::Layout):
+(WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
+(WebViewHost::initializeLayerTreeView):
+* DumpRenderTree/chromium/WebViewHost.h:
+(webkit_support):
+(WebViewHost):
+
 2013-02-28  Ryuan Choi  
 
 Unreviewed, add my secondary email address to the list.


Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h (144397 => 144398)

--- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h	2013-03-01 00:47:10 UTC (rev 144397)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h	2013-03-01 00:50:37 UTC (rev 144398)
@@ -108,6 +108,8 @@
 
 void setLogConsoleOutput(bool enabled);
 
+void scheduleComposite();
+
 #if WEBTESTRUNNER_IMPLEMENTATION
 void display();
 void displayInvalidatedRegion();
@@ -125,7 +127,6 @@
 
 void didInvalidateRect(const WebKit::WebRect&);
 void didScrollRect(int, int, const WebKit::WebRect&);
-void scheduleComposite();
 void scheduleAnimation();
 void setWindowRect(const WebKit::WebRect&);
 void show(WebKit::WebNavigationPolicy);
@@ -251,11 +252,6 @@
 WebTestProxyBase::didScrollRect(dx, dy, clipRect);
 Base::didScrollRect(dx, dy, clipRect);
 }
-virtual void scheduleComposite()
-{
-WebTestProxyBase::scheduleComposite();
-Base::scheduleComposite();
-}
 virtual void scheduleAnimation()
 {
 WebTestProxyBase::scheduleAnimation();


Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp (144397 => 144398)

--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp	2013-03-01 00:47:10 UTC (rev 144397)
+++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp	2013-03-01 00:50:37 UTC (rev 144398)
@@ -262,12 +262,26 @@
 setWindowRect(WebRect(0, 0, newSize.width, newSize.height));
 }
 
+class WebViewHostDRTLayerTreeViewClient : public webkit_support::DRTLayerTreeViewClient {
+public:
+explicit WebViewHostDRTLayerTreeViewClient(WebViewHost* host)
+: m_host(host) { }
+virtual ~WebViewHostDRTLayerTreeViewClient() { }
+
+virtual void Layout() { m_host->webView()->layout(); }
+virtual void ScheduleComposite() { m_host->proxy()->scheduleComposite(); }
+
+private:
+WebViewHost* m_host;
+};
+
 void WebViewHost::initializeLayerTreeView(WebLayerTreeViewClient* client, const WebLayer& rootLayer, const WebLayerTreeView::Settings& settings)
 {
+m_layerTreeViewClient = adoptPtr(new WebViewHostDRTLayerTreeViewClient(this));
 if (m_shell->softwareCompositingEnabled())
-m_layerTreeView = adoptPtr(webkit_support::CreateLayerTreeViewSoftware(client));
+m_layerTreeView = adoptPtr(webkit_support::CreateLayerTreeViewSoftware(m_layerTreeViewClient.get()));
 else
-m_layerTreeView = adoptPtr(webkit_support::CreateLayerTreeView3d(client));
+m_layerTreeView = adoptPtr(webkit_support::CreateLayerTreeView3d(m_layerTreeViewClient.get()));
 
 ASSERT(m_layerTreeView);
 m_layerTreeView->setRootLayer(rootLayer);


Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.h (144397 => 144398)

--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.h	2013-03-01 00:47

[webkit-changes] [144397] trunk/Source

[commit-queue]

Title: [144397] trunk/Source








Revision 144397
Author commit-qu...@webkit.org
Date 2013-02-28 16:47:10 -0800 (Thu, 28 Feb 2013)


Log Message
Need API to control page underlay color
https://bugs.webkit.org/show_bug.cgi?id=110918

Patch by Conrad Shultz  on 2013-02-28
Reviewed by Simon Fraser.

Source/WebCore:

* page/ChromeClient.h:
(ChromeClient):
Declare underlayColor().

* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::setUpOverhangAreasLayerContents):
Have setUpOverhangAreasLayerContents() take a background color parameter.

* platform/mac/ScrollbarThemeMac.h:
(ScrollbarThemeMac):
Ditto.

* platform/mac/ScrollbarThemeMac.mm:
Include ColorMac.h.
(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents):
Use the passed-in background color, if valid, for the overhang area layer.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Get the underlay color from the chrome client and pass it into setUpOverhangAreasLayerContents().

Source/WebKit2:

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
Encode underlayColor.
(WebKit::WebPageCreationParameters::decode):
Decode underlayColor.

* Shared/WebPageCreationParameters.h:
(WebPageCreationParameters):
Add underlayColor member.

* UIProcess/API/mac/WKView.mm:
(-[WKView underlayColor]):
Accessor; retrieves the WebCore::Color from the WebPageProxy and converts it to an NSColor.
(-[WKView setUnderlayColor:]):
Mutator; converts the NSColor to a WebCore::Color and passes it to the WebPageProxy.

* UIProcess/API/mac/WKViewPrivate.h:
Add underlayColor @property.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setUnderlayColor):
Mutator; dispatches SetUnderlayColor to WebPage.
(WebKit::WebPageProxy::creationParameters):
Set the parameters' underlayColor member appropriately.

* UIProcess/WebPageProxy.h:
Declare new member functions and variable.
(WebKit::WebPageProxy::underlayColor):
Accessor.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::underlayColor):
Return the associated WebPage's underlayColor.

* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
Declare underlayColor().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Apply any underlayColor that was supplied as part of the WebPageCreationParameters.

* WebProcess/WebPage/WebPage.h:
Declare new member functions and variable.
(WebKit::WebPage::underlayColor):
Accessor.

* WebProcess/WebPage/WebPage.messages.in:
Add SetUnderlayColor message.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebCore/platform/ScrollbarTheme.h
trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h
trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp
trunk/Source/WebKit2/Shared/WebPageCreationParameters.h
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (144396 => 144397)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 00:46:30 UTC (rev 144396)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 00:47:10 UTC (rev 144397)
@@ -1,3 +1,31 @@
+2013-02-28  Conrad Shultz  
+
+Need API to control page underlay color
+https://bugs.webkit.org/show_bug.cgi?id=110918
+
+Reviewed by Simon Fraser.
+
+* page/ChromeClient.h:
+(ChromeClient):
+Declare underlayColor().
+
+* platform/ScrollbarTheme.h:
+(WebCore::ScrollbarTheme::setUpOverhangAreasLayerContents):
+Have setUpOverhangAreasLayerContents() take a background color parameter.
+
+* platform/mac/ScrollbarThemeMac.h:
+(ScrollbarThemeMac):
+Ditto.
+
+* platform/mac/ScrollbarThemeMac.mm:
+Include ColorMac.h.
+(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents):
+Use the passed-in background color, if valid, for the overhang area layer.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
+Get the underlay color from the chrome client and pass it into setUpOverhangAreasLayerContents().
+
 2013-02-28  Beth Dakin  
 
 RelevantRepaintedObjects heuristic should ensure there is some coverage in the 


Modified: trunk/Source/WebCore/page/ChromeClient.h (144396 => 144397)

--- trunk/Source/WebCore/page/ChromeClient.h	2013-03-01 00:46:30 UTC (rev 14439

[webkit-changes] [144396] trunk/LayoutTests

[schenney]

Title: [144396] trunk/LayoutTests








Revision 144396
Author schen...@chromium.org
Date 2013-02-28 16:46:30 -0800 (Thu, 28 Feb 2013)


Log Message
[Chromium] Rebaselines for Mac decorations-with-text-combine.html

Unreviewed expectations update.

* platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png:
* platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (144395 => 144396)

--- trunk/LayoutTests/ChangeLog	2013-03-01 00:42:18 UTC (rev 144395)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 00:46:30 UTC (rev 144396)
@@ -1,3 +1,12 @@
+2013-02-28  Stephen Chenney  
+
+[Chromium] Rebaselines for Mac decorations-with-text-combine.html
+
+Unreviewed expectations update.
+
+* platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png:
+* platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png:
+
 2013-02-28  Roger Fong  
 
 Unreviewed gardening. Skip storage tests on Windows.


Modified: trunk/LayoutTests/platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144395] trunk/Source/WebCore

[bdakin]

Title: [144395] trunk/Source/WebCore








Revision 144395
Author bda...@apple.com
Date 2013-02-28 16:42:18 -0800 (Thu, 28 Feb 2013)


Log Message
RelevantRepaintedObjects heuristic should ensure there is some coverage in the 
bottom half of the relevant view rect
https://bugs.webkit.org/show_bug.cgi?id=24
-and corresponding-


Reviewed by Simon Fraser.

We need two Regions now -- one for the top and another for the bottom. Make sure 
we have at least half of our desired coverage in both.
* page/Page.cpp:
(WebCore::Page::resetRelevantPaintedObjectCounter):
(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::reportMemoryUsage):
* page/Page.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (144394 => 144395)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 00:30:52 UTC (rev 144394)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 00:42:18 UTC (rev 144395)
@@ -1,3 +1,21 @@
+2013-02-28  Beth Dakin  
+
+RelevantRepaintedObjects heuristic should ensure there is some coverage in the 
+bottom half of the relevant view rect
+https://bugs.webkit.org/show_bug.cgi?id=24
+-and corresponding-
+
+
+Reviewed by Simon Fraser.
+
+We need two Regions now -- one for the top and another for the bottom. Make sure 
+we have at least half of our desired coverage in both.
+* page/Page.cpp:
+(WebCore::Page::resetRelevantPaintedObjectCounter):
+(WebCore::Page::addRelevantRepaintedObject):
+(WebCore::Page::reportMemoryUsage):
+* page/Page.h:
+
 2013-02-28  Chris Fleizach  
 
 WebSpeech: support pitch change


Modified: trunk/Source/WebCore/page/Page.cpp (144394 => 144395)

--- trunk/Source/WebCore/page/Page.cpp	2013-03-01 00:30:52 UTC (rev 144394)
+++ trunk/Source/WebCore/page/Page.cpp	2013-03-01 00:42:18 UTC (rev 144395)
@@ -1283,7 +1283,8 @@
 {
 m_isCountingRelevantRepaintedObjects = false;
 m_relevantUnpaintedRenderObjects.clear();
-m_relevantPaintedRegion = Region();
+m_topRelevantPaintedRegion = Region();
+m_bottomRelevantPaintedRegion = Region();
 m_relevantUnpaintedRegion = Region();
 }
 
@@ -1333,13 +1334,38 @@
 m_relevantUnpaintedRegion.subtract(snappedPaintRect);
 }
 
-m_relevantPaintedRegion.unite(snappedPaintRect);
-
+// Split the relevantRect into a top half and a bottom half. Making sure we have coverage in
+// both halves helps to prevent cases where we have a fully loaded menu bar or masthead with
+// no content beneath that.
+LayoutRect topRelevantRect = relevantRect;
+topRelevantRect.contract(LayoutSize(0, relevantRect.height() / 2));
+LayoutRect bottomRelevantRect = topRelevantRect;
+bottomRelevantRect.setY(relevantRect.height() / 2);
+
+// If the rect straddles both Regions, split it appropriately.
+if (topRelevantRect.intersects(snappedPaintRect) && bottomRelevantRect.intersects(snappedPaintRect)) {
+IntRect topIntersection = snappedPaintRect;
+topIntersection.intersect(pixelSnappedIntRect(topRelevantRect));
+m_topRelevantPaintedRegion.unite(topIntersection);
+
+IntRect bottomIntersection = snappedPaintRect;
+bottomIntersection.intersect(pixelSnappedIntRect(bottomRelevantRect));
+m_bottomRelevantPaintedRegion.unite(bottomIntersection);
+} else if (topRelevantRect.intersects(snappedPaintRect))
+m_topRelevantPaintedRegion.unite(snappedPaintRect);
+else
+m_bottomRelevantPaintedRegion.unite(snappedPaintRect);
+
+float topPaintedArea = m_topRelevantPaintedRegion.totalArea();
+float bottomPaintedArea = m_bottomRelevantPaintedRegion.totalArea();
 float viewArea = relevantRect.width() * relevantRect.height();
-float ratioOfViewThatIsPainted = m_relevantPaintedRegion.totalArea() / viewArea;
+
+float ratioThatIsPaintedOnTop = topPaintedArea / viewArea;
+float ratioThatIsPaintedOnBottom = bottomPaintedArea / viewArea;
 float ratioOfViewThatIsUnpainted = m_relevantUnpaintedRegion.totalArea() / viewArea;
 
-if (ratioOfViewThatIsPainted > gMinimumPaintedAreaRatio && ratioOfViewThatIsUnpainted < gMaximumUnpaintedAreaRatio) {
+if (ratioThatIsPaintedOnTop > (gMinimumPaintedAreaRatio / 2) && ratioThatIsPaintedOnBottom > (gMinimumPaintedAreaRatio / 2)
+&& ratioOfViewThatIsUnpainted < gMaximumUnpaintedAreaRatio) {
 m_isCountingRelevantRepaintedObjects = false;
 resetRelevantPaintedObjectCounter();
 if (Frame* frame = mainFrame())
@@ -1449,7 +1475,8 @@
 info.addMember(m_group, "group");
 info.addMember(m_sessionStorage, "sessionStorage");
 info.addMember(m_relevantUnpaintedRenderObjects, "relevantUnpaintedRenderObjects");
-info.addMember(m_relevantPaintedRegion, "relevantPaintedRegion");
+info.addMember(m_topRelevantPaintedRegion, "relevantPaintedRegion");

[webkit-changes] [144394] trunk/LayoutTests

[roger_fong]

Title: [144394] trunk/LayoutTests








Revision 144394
Author roger_f...@apple.com
Date 2013-02-28 16:30:52 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed gardening. Skip storage tests on Windows.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (144393 => 144394)

--- trunk/LayoutTests/ChangeLog	2013-03-01 00:29:30 UTC (rev 144393)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 00:30:52 UTC (rev 144394)
@@ -1,3 +1,9 @@
+2013-02-28  Roger Fong  
+
+Unreviewed gardening. Skip storage tests on Windows.
+
+* platform/win/TestExpectations:
+
 2013-02-28  Ryosuke Niwa  
 
 Add a flaky failure expectation to http/tests/inspector/resource-tree/resource-request-content-while-loading.html


Modified: trunk/LayoutTests/platform/win/TestExpectations (144393 => 144394)

--- trunk/LayoutTests/platform/win/TestExpectations	2013-03-01 00:29:30 UTC (rev 144393)
+++ trunk/LayoutTests/platform/win/TestExpectations	2013-03-01 00:30:52 UTC (rev 144394)
@@ -2657,3 +2657,7 @@
 
 # Need support for ResourceHandle::didChangePriority and DRT support
 webkit.org/b/111016 http/tests/loading/promote-img-preload-priority.html [ Failure ]
+
+# Disable storage tests
+fast/workers/storage/
+storage/






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144393] trunk/Source/WebKit/chromium

[commit-queue]

Title: [144393] trunk/Source/WebKit/chromium








Revision 144393
Author commit-qu...@webkit.org
Date 2013-02-28 16:29:30 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed.  Rolled Chromium DEPS to r185341.  Requested by
"James Robinson"  via sheriffbot.

Patch by Sheriff Bot  on 2013-02-28

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (144392 => 144393)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-01 00:21:46 UTC (rev 144392)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-01 00:29:30 UTC (rev 144393)
@@ -1,3 +1,10 @@
+2013-02-28  Sheriff Bot  
+
+Unreviewed.  Rolled Chromium DEPS to r185341.  Requested by
+"James Robinson"  via sheriffbot.
+
+* DEPS:
+
 2013-02-28  Varun Jain  
 
 Add new webkit API to invoke a context menu.


Modified: trunk/Source/WebKit/chromium/DEPS (144392 => 144393)

--- trunk/Source/WebKit/chromium/DEPS	2013-03-01 00:21:46 UTC (rev 144392)
+++ trunk/Source/WebKit/chromium/DEPS	2013-03-01 00:29:30 UTC (rev 144393)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '184931'
+  'chromium_rev': '185341'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144392] trunk/Source/WebCore

[cfleizach]

Title: [144392] trunk/Source/WebCore








Revision 144392
Author cfleiz...@apple.com
Date 2013-02-28 16:21:46 -0800 (Thu, 28 Feb 2013)


Log Message
WebSpeech: support pitch change
https://bugs.webkit.org/show_bug.cgi?id=107348

Reviewed by Beth Dakin.

Implement a policy for the Mac synthesizer to convert from the utterance's pitch rate
to something sensible for the platform.

* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper initWithSpeechSynthesizer:WebCore::]):
(-[WebSpeechSynthesisWrapper convertPitchToNSSpeechValue:]):
(-[WebSpeechSynthesisWrapper updateBasePitchForSynthesizer]):
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (144391 => 144392)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 00:19:39 UTC (rev 144391)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 00:21:46 UTC (rev 144392)
@@ -1,3 +1,19 @@
+2013-02-28  Chris Fleizach  
+
+WebSpeech: support pitch change
+https://bugs.webkit.org/show_bug.cgi?id=107348
+
+Reviewed by Beth Dakin.
+
+Implement a policy for the Mac synthesizer to convert from the utterance's pitch rate
+to something sensible for the platform.
+
+* platform/mac/PlatformSpeechSynthesizerMac.mm:
+(-[WebSpeechSynthesisWrapper initWithSpeechSynthesizer:WebCore::]):
+(-[WebSpeechSynthesisWrapper convertPitchToNSSpeechValue:]):
+(-[WebSpeechSynthesisWrapper updateBasePitchForSynthesizer]):
+(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
+
 2013-02-28   Vineet Chaudhary  
 
 Unreviewed. Bindings test results update after r144376.


Modified: trunk/Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm (144391 => 144392)

--- trunk/Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm	2013-03-01 00:19:39 UTC (rev 144391)
+++ trunk/Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm	2013-03-01 00:21:46 UTC (rev 144392)
@@ -40,6 +40,7 @@
 const WebCore::PlatformSpeechSynthesisUtterance* m_utterance;
 
 RetainPtr m_synthesizer;
+float m_basePitch;
 }
 
 - (WebSpeechSynthesisWrapper *)initWithSpeechSynthesizer:(WebCore::PlatformSpeechSynthesizer *)synthesizer;
@@ -55,6 +56,7 @@
 return nil;
 
 m_synthesizerObject = synthesizer;
+[self updateBasePitchForSynthesizer];
 return self;
 }
 
@@ -66,6 +68,19 @@
 return 200.0f * rate;
 }
 
+- (float)convertPitchToNSSpeechValue:(float)pitch
+{
+// This allows the base pitch to range from 0% - 200% of the normal pitch.
+return m_basePitch * pitch;
+}
+
+- (void)updateBasePitchForSynthesizer
+{
+// Reset the base pitch whenever we change voices, since the base pitch is different for each voice.
+[m_synthesizer setObject:nil forProperty:NSSpeechResetProperty error:nil];
+m_basePitch = [[m_synthesizer objectForProperty:NSSpeechPitchBaseProperty error:nil] floatValue];
+}
+
 - (void)speakUtterance:(const WebCore::PlatformSpeechSynthesisUtterance *)utterance
 {
 // When speak is called we should not have an existing speech utterance outstanding.
@@ -108,9 +123,17 @@
 
 // Don't set the voice unless necessary. There's a bug in NSSpeechSynthesizer such that
 // setting the voice for the first time will cause the first speechDone callback to report it was unsuccessful.
-if (![[m_synthesizer voice] isEqualToString:voiceURI])
+BOOL updatePitch = NO;
+if (![[m_synthesizer voice] isEqualToString:voiceURI]) {
 [m_synthesizer setVoice:voiceURI];
+// Reset the base pitch whenever we change voices.
+updatePitch = YES;
+}
 
+if (m_basePitch == 0 || updatePitch)
+[self updateBasePitchForSynthesizer];
+
+[m_synthesizer setObject:[NSNumber numberWithFloat:[self convertPitchToNSSpeechValue:utterance->pitch()]] forProperty:NSSpeechPitchBaseProperty error:nil];
 [m_synthesizer setRate:[self convertRateToWPM:utterance->rate()]];
 [m_synthesizer setVolume:utterance->volume()];
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144390] trunk/Source/WebKit2

[andersca]

Title: [144390] trunk/Source/WebKit2








Revision 144390
Author ander...@apple.com
Date 2013-02-28 16:03:48 -0800 (Thu, 28 Feb 2013)


Log Message
Add the notion of an allowed connection to SessionStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=22

Reviewed by Sam Weinig.

Group together each session storage namespace with an allowed connection.
This will help ensure that rouge web processes will not be able to access session storage
from pages in other processes.

* UIProcess/Storage/StorageManager.cpp:
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::allowedConnection):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::setAllowedConnection):
Add an m_allowedConnection member variable, as well as setters and getters.

(WebKit::StorageManager::createSessionStorageNamespace):
Take an optional allowed connection. (It can be null if the process has not finished launching).

(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
New function to set the allowed connection for a session storage namespace.

(WebKit::StorageManager::createStorageArea):
Add another FIXME.

(WebKit::StorageManager::createSessionStorageNamespaceInternal):
Pass the connection to the SessionStorageNamespace constructor.

(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnectionInternal):
Set the allowed connection.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Pass the connection to createSessionStorageNamespace.

(WebKit::WebPageProxy::connectionWillOpen):
Call setAllowedSessionStorageNamespaceConnection.

(WebKit::WebPageProxy::connectionWillClose):
Call setAllowedSessionStorageNamespaceConnection with a null connection.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
Call connectionWillOpen on all pages.

(WebKit::WebProcessProxy::connectionWillClose):
Call connectionWillClose on all pages.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (144389 => 144390)

--- trunk/Source/WebKit2/ChangeLog	2013-02-28 23:59:11 UTC (rev 144389)
+++ trunk/Source/WebKit2/ChangeLog	2013-03-01 00:03:48 UTC (rev 144390)
@@ -1,3 +1,54 @@
+2013-02-28  Anders Carlsson  
+
+Add the notion of an allowed connection to SessionStorageNamespace
+https://bugs.webkit.org/show_bug.cgi?id=22
+
+Reviewed by Sam Weinig.
+
+Group together each session storage namespace with an allowed connection.
+This will help ensure that rouge web processes will not be able to access session storage
+from pages in other processes.
+
+* UIProcess/Storage/StorageManager.cpp:
+(StorageManager::SessionStorageNamespace):
+(WebKit::StorageManager::SessionStorageNamespace::allowedConnection):
+(WebKit::StorageManager::SessionStorageNamespace::create):
+(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
+(WebKit::StorageManager::SessionStorageNamespace::setAllowedConnection):
+Add an m_allowedConnection member variable, as well as setters and getters.
+
+(WebKit::StorageManager::createSessionStorageNamespace):
+Take an optional allowed connection. (It can be null if the process has not finished launching).
+
+(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
+New function to set the allowed connection for a session storage namespace.
+
+(WebKit::StorageManager::createStorageArea):
+Add another FIXME.
+
+(WebKit::StorageManager::createSessionStorageNamespaceInternal):
+Pass the connection to the SessionStorageNamespace constructor.
+
+(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnectionInternal):
+Set the allowed connection.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::WebPageProxy):
+Pass the connection to createSessionStorageNamespace.
+
+(WebKit::WebPageProxy::connectionWillOpen):
+Call setAllowedSessionStorageNamespaceConnection.
+
+(WebKit::WebPageProxy::connectionWillClose):
+Call setAllowedSessionStorageNamespaceConnection with a null connection.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::connectionWillOpen):
+Call connectionWillOpen on all pages.
+
+(WebKit::WebProcessProxy::connectionWillClose):
+Call connectionWillClose on all pages.
+
 2013-02-28  Kiran Muppala  
 
 Add private API to disable WKView window occlusion detection


Modified: trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp (144389 => 144390)

--- trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp	2013-02-28 23:59:11 UTC (rev 144

[webkit-changes] [144389] trunk/Source/WebKit2

[commit-queue]

Title: [144389] trunk/Source/WebKit2








Revision 144389
Author commit-qu...@webkit.org
Date 2013-02-28 15:59:11 -0800 (Thu, 28 Feb 2013)


Log Message
Add private API to disable WKView window occlusion detection
https://bugs.webkit.org/show_bug.cgi?id=07

Patch by Kiran Muppala  on 2013-02-28
Reviewed by Simon Fraser.

* UIProcess/API/mac/WKView.mm:
(-[WKView _enableWindowOcclusionNotifications]): Check if occlusion
detection is enabled before enabling notifications.
(windowBecameOccluded): Ditto before changing window occlusion state.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
Initialize occlusion detection enabled flag to "YES".
(-[WKView windowOcclusionDetectionEnabled]):
(-[WKView setWindowOcclusionDetectionEnabled:]):
* UIProcess/API/mac/WKViewPrivate.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (144388 => 144389)

--- trunk/Source/WebKit2/ChangeLog	2013-02-28 23:54:17 UTC (rev 144388)
+++ trunk/Source/WebKit2/ChangeLog	2013-02-28 23:59:11 UTC (rev 144389)
@@ -1,3 +1,20 @@
+2013-02-28  Kiran Muppala  
+
+Add private API to disable WKView window occlusion detection
+https://bugs.webkit.org/show_bug.cgi?id=07
+
+Reviewed by Simon Fraser.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView _enableWindowOcclusionNotifications]): Check if occlusion
+detection is enabled before enabling notifications.
+(windowBecameOccluded): Ditto before changing window occlusion state.
+(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
+Initialize occlusion detection enabled flag to "YES".
+(-[WKView windowOcclusionDetectionEnabled]):
+(-[WKView setWindowOcclusionDetectionEnabled:]):
+* UIProcess/API/mac/WKViewPrivate.h:
+
 2013-02-28  Anders Carlsson  
 
 Add the notion of an allowed connection to SessionStorageNamespace


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (144388 => 144389)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2013-02-28 23:54:17 UTC (rev 144388)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2013-02-28 23:59:11 UTC (rev 144389)
@@ -227,6 +227,7 @@
 NSSize _intrinsicContentSize;
 BOOL _expandsToFitContentViaAutoLayout;
 BOOL _isWindowOccluded;
+BOOL _windowOcclusionDetectionEnabled;
 }
 
 @end
@@ -2262,6 +2263,9 @@
 - (void)_enableWindowOcclusionNotifications
 {
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+if (![self windowOcclusionDetectionEnabled])
+return;
+
 NSWindow *window = [self window];
 if (!window)
 return;
@@ -2320,7 +2324,7 @@
 Vector& allViews = [WKView _allViews];
 for (size_t i = 0, size = allViews.size(); i < size; ++i) {
 WKView *view = allViews[i];
-if ([[view window] windowNumber] == windowID)
+if ([[view window] windowNumber] == windowID && [view windowOcclusionDetectionEnabled])
 [view _setIsWindowOccluded:YES];
 }
 }
@@ -3133,6 +3137,7 @@
 _data->_expandsToFitContentViaAutoLayout = NO;
 
 _data->_intrinsicContentSize = NSMakeSize(NSViewNoInstrinsicMetric, NSViewNoInstrinsicMetric);
+_data->_windowOcclusionDetectionEnabled = YES;
 
 [self _registerDraggedTypes];
 
@@ -3321,6 +3326,22 @@
 return _data->_viewInWindowChangesDeferredCount;
 }
 
+- (BOOL)windowOcclusionDetectionEnabled
+{
+return _data->_windowOcclusionDetectionEnabled;
+}
+
+- (void)setWindowOcclusionDetectionEnabled:(BOOL)flag
+{
+if (_data->_windowOcclusionDetectionEnabled == flag)
+return;
+_data->_windowOcclusionDetectionEnabled = flag;
+if (flag)
+[self _enableWindowOcclusionNotifications];
+else
+[self _disableWindowOcclusionNotifications];
+}
+
 @end
 
 @implementation WKResponderChainSink


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h (144388 => 144389)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h	2013-02-28 23:54:17 UTC (rev 144388)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h	2013-02-28 23:59:11 UTC (rev 144389)
@@ -59,4 +59,7 @@
 - (void)endDeferringViewInWindowChanges;
 - (BOOL)isDeferringViewInWindowChanges;
 
+- (BOOL)windowOcclusionDetectionEnabled;
+- (void)setWindowOcclusionDetectionEnabled:(BOOL)flag;
+
 @end






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144388] trunk/Source/WebCore

[rgf748]

Title: [144388] trunk/Source/WebCore








Revision 144388
Author rgf...@motorola.com
Date 2013-02-28 15:54:17 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed. Bindings test results update after r144376.

* bindings/scripts/test/JS/JSTestObj.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144387 => 144388)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 23:52:10 UTC (rev 144387)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 23:54:17 UTC (rev 144388)
@@ -1,3 +1,9 @@
+2013-02-28   Vineet Chaudhary  
+
+Unreviewed. Bindings test results update after r144376.
+
+* bindings/scripts/test/JS/JSTestObj.cpp:
+
 2013-02-28  Roger Fong  
 
 Unreviewed. AppleWin Build fix.


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (144387 => 144388)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2013-02-28 23:52:10 UTC (rev 144387)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2013-02-28 23:54:17 UTC (rev 144388)
@@ -21,6 +21,7 @@
 #include "config.h"
 #include "JSTestObj.h"
 
+#include "CallbackFunction.h"
 #include "DOMStringList.h"
 #include "Dictionary.h"
 #include "Document.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144387] trunk/Tools

[pdr]

Title: [144387] trunk/Tools








Revision 144387
Author p...@google.com
Date 2013-02-28 15:52:10 -0800 (Thu, 28 Feb 2013)


Log Message
Add Philip Rogers as a reviewer.

Unreviewed update of committers.py.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (144386 => 144387)

--- trunk/Tools/ChangeLog	2013-02-28 23:43:02 UTC (rev 144386)
+++ trunk/Tools/ChangeLog	2013-02-28 23:52:10 UTC (rev 144387)
@@ -1,3 +1,11 @@
+2013-02-28  Philip Rogers  
+
+Add Philip Rogers as a reviewer.
+
+Unreviewed update of committers.py.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2013-02-28  Ryosuke Niwa  
 
 Merge more methods on PerfTest


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (144386 => 144387)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-02-28 23:43:02 UTC (rev 144386)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-02-28 23:52:10 UTC (rev 144387)
@@ -399,7 +399,6 @@
 Committer("Peter Beverloo", ["pe...@chromium.org", "pe...@webkit.org", "bever...@google.com"], "beverloo"),
 Committer("Peter Kasting", ["pkast...@google.com", "pkast...@chromium.org"], "pkasting"),
 Committer("Peter Varga", ["pva...@webkit.org", "pva...@inf.u-szeged.hu"], "stampho"),
-Committer("Philip Rogers", ["p...@google.com", "p...@chromium.org"], "pdr"),
 Committer("Pierre d'Herbemont", ["pdherbem...@free.fr", "pdherbem...@apple.com"], "pdherbemont"),
 Committer("Pierre-Olivier Latour", "p...@apple.com", "pol"),
 Committer("Pierre Rossi", "pierre.ro...@gmail.com", "elproxy"),
@@ -577,6 +576,7 @@
 Reviewer("Ojan Vafai", ["o...@chromium.org", "ojan.aut...@gmail.com"], "ojan"),
 Reviewer("Oliver Hunt", "oli...@apple.com", "olliej"),
 Reviewer("Pavel Feldman", ["pfeld...@chromium.org", "pfeld...@google.com"], "pfeldman"),
+Reviewer("Philip Rogers", ["p...@google.com", "p...@chromium.org"], "pdr"),
 Reviewer("Philippe Normand", ["pnorm...@igalia.com", "ph...@webkit.org", "ph...@igalia.com"], ["philn-tp", "pnormand"]),
 Reviewer("Richard Williamson", "r...@apple.com", "rjw"),
 Reviewer("Rob Buis", ["rwlb...@gmail.com", "rwlb...@webkit.org", "rb...@rim.com"], "rwlbuis"),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144386] trunk/Source/WebKit2

[andersca]

Title: [144386] trunk/Source/WebKit2








Revision 144386
Author ander...@apple.com
Date 2013-02-28 15:43:02 -0800 (Thu, 28 Feb 2013)


Log Message
Add the notion of an allowed connection to SessionStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=22

Reviewed by Sam Weinig.

Group together each session storage namespace with an allowed connection.
This will help ensure that rouge web processes will not be able to access session storage
from pages in other processes.

* UIProcess/Storage/StorageManager.cpp:
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::allowedConnection):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::setAllowedConnection):
Add an m_allowedConnection member variable, as well as setters and getters.

(WebKit::StorageManager::createSessionStorageNamespace):
Take an optional allowed connection. (It can be null if the process has not finished launching).

(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
New function to set the allowed connection for a session storage namespace.

(WebKit::StorageManager::createStorageArea):
Add another FIXME.

(WebKit::StorageManager::createSessionStorageNamespaceInternal):
Pass the connection to the SessionStorageNamespace constructor.

(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnectionInternal):
Set the allowed connection.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Pass the connection to createSessionStorageNamespace.

(WebKit::WebPageProxy::connectionWillOpen):
Call setAllowedSessionStorageNamespaceConnection.

(WebKit::WebPageProxy::connectionWillClose):
Call setAllowedSessionStorageNamespaceConnection with a null connection.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
Call connectionWillOpen on all pages.

(WebKit::WebProcessProxy::connectionWillClose):
Call connectionWillClose on all pages.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp
trunk/Source/WebKit2/UIProcess/Storage/StorageManager.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (144385 => 144386)

--- trunk/Source/WebKit2/ChangeLog	2013-02-28 23:38:48 UTC (rev 144385)
+++ trunk/Source/WebKit2/ChangeLog	2013-02-28 23:43:02 UTC (rev 144386)
@@ -1,5 +1,56 @@
 2013-02-28  Anders Carlsson  
 
+Add the notion of an allowed connection to SessionStorageNamespace
+https://bugs.webkit.org/show_bug.cgi?id=22
+
+Reviewed by Sam Weinig.
+
+Group together each session storage namespace with an allowed connection.
+This will help ensure that rouge web processes will not be able to access session storage
+from pages in other processes.
+
+* UIProcess/Storage/StorageManager.cpp:
+(StorageManager::SessionStorageNamespace):
+(WebKit::StorageManager::SessionStorageNamespace::allowedConnection):
+(WebKit::StorageManager::SessionStorageNamespace::create):
+(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
+(WebKit::StorageManager::SessionStorageNamespace::setAllowedConnection):
+Add an m_allowedConnection member variable, as well as setters and getters.
+
+(WebKit::StorageManager::createSessionStorageNamespace):
+Take an optional allowed connection. (It can be null if the process has not finished launching).
+
+(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
+New function to set the allowed connection for a session storage namespace.
+
+(WebKit::StorageManager::createStorageArea):
+Add another FIXME.
+
+(WebKit::StorageManager::createSessionStorageNamespaceInternal):
+Pass the connection to the SessionStorageNamespace constructor.
+
+(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnectionInternal):
+Set the allowed connection.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::WebPageProxy):
+Pass the connection to createSessionStorageNamespace.
+
+(WebKit::WebPageProxy::connectionWillOpen):
+Call setAllowedSessionStorageNamespaceConnection.
+
+(WebKit::WebPageProxy::connectionWillClose):
+Call setAllowedSessionStorageNamespaceConnection with a null connection.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::connectionWillOpen):
+Call connectionWillOpen on all pages.
+
+(WebKit::WebProcessProxy::connectionWillClose):
+Call connectionWillClose on all pages.
+
+2013-02-28  Anders Carlsson  
+
 Implement more StorageAreaProxy member fun

[webkit-changes] [144385] trunk/Source/WebCore

[roger_fong]

Title: [144385] trunk/Source/WebCore








Revision 144385
Author roger_f...@apple.com
Date 2013-02-28 15:38:48 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed. AppleWin Build fix.

* WebCore.vcproj/WebCore.vcproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (144384 => 144385)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 23:37:50 UTC (rev 144384)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 23:38:48 UTC (rev 144385)
@@ -1,3 +1,9 @@
+2013-02-28  Roger Fong  
+
+Unreviewed. AppleWin Build fix.
+
+* WebCore.vcproj/WebCore.vcproj:
+
 2013-02-28  Kentaro Hara  
 
 [V8] Remove the world->isMainWorld() check from minorGCPrologue()


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (144384 => 144385)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2013-02-28 23:37:50 UTC (rev 144384)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2013-02-28 23:38:48 UTC (rev 144385)
@@ -32814,14 +32814,6 @@
 	>
 
 -	RelativePath="..\platform\network\BlobRegistry.cpp"
-	>
-
-
-
- 	RelativePath="..\platform\network\BlobRegistryImpl.h"
 	>
 
@@ -38023,7 +38015,7 @@
 >
 			
 			-RelativePath="..\css\DOMWindowCSS.cpp"
+RelativePath="..\css\CSSValuePool.cpp"
 >
  	Name="Debug|Win32"
@@ -38075,12 +38067,20 @@
 
 			
 			-RelativePath="..\css\DOMWindowCSS.h"
+RelativePath="..\css\CSSValuePool.h"
 >
 			
 			-RelativePath="..\css\CSSValuePool.cpp"
+RelativePath="..\css\CSSVariableValue.h"
 >
+			
+			
+			
+			
  	Name="Debug|Win32"
 	ExcludedFromBuild="true"
@@ -38131,18 +38131,10 @@
 
 			
 			-RelativePath="..\css\CSSValuePool.h"
+RelativePath="..\css\DOMWindowCSS.h"
 >
 			
 			-RelativePath="..\css\CSSVariableValue.h"
->
-			
-			
-			
-			 RelativePath="..\css\FontFeatureValue.cpp"
 >
 			
@@ -76754,31 +76746,31 @@
 RelativePath="..\inspector\TimelineRecordFactory.h"
 >
 			
-
-
-
-
-
-
-
-
-
-
 			+RelativePath="..\inspector\TimelineTraceEventProcessor.cpp"
+>
+
+	
+
+
+	
+
+			
+			
+			
+			 RelativePath="..\inspector\WorkerConsoleAgent.cpp"
 >
 @@ -77206,11 +77198,11 @@
 	>
 
 -	RelativePath="..\inspector\front-end\FileSystemView.js"
+	RelativePath="..\inspector\front-end\FileSystemProjectDelegate.js"
 	>
 
 -	RelativePath="..\inspector\front-end\FileSystemProjectDelegate.js"
+	RelativePath="..\inspector\front-end\FileSystemView.js"
 	>
 
 @@ -77354,11 +77346,11 @@
 	>
 
 -	RelativePath="..\inspector\front-end\UglifyJS\_javascript_Formatter.js"
+	RelativePath="..\inspector\front-end\_javascript_Formatter.js"
 	>
 
 -	RelativePath="..\inspector\front-end\_javascript_Formatter.js"
+	RelativePath="..\inspector\front-end\UglifyJS\_javascript_Formatter.js"
 	>
 
 @@ -77798,6 +77790,10 @@
 	>
 
 +	RelativePath="..\inspector\front-end\SuggestBox.js"
+	>
+
+ 	RelativePath="..\inspector\front-end\SummaryBar.js"
 	>
 
@@ -77838,10 +77834,6 @@
 	>
 
 -	RelativePath="..\inspector\front-end\SuggestBox.js"
-	>
-
- 	RelativePath="..\inspector\front-end\TextPrompt.js"
 	>
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144384] trunk/LayoutTests

[rniwa]

Title: [144384] trunk/LayoutTests








Revision 144384
Author rn...@webkit.org
Date 2013-02-28 15:37:50 -0800 (Thu, 28 Feb 2013)


Log Message
Add a flaky failure expectation to http/tests/inspector/resource-tree/resource-request-content-while-loading.html
on all platforms per bug 23.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (144383 => 144384)

--- trunk/LayoutTests/ChangeLog	2013-02-28 23:33:28 UTC (rev 144383)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 23:37:50 UTC (rev 144384)
@@ -1,3 +1,10 @@
+2013-02-28  Ryosuke Niwa  
+
+Add a flaky failure expectation to http/tests/inspector/resource-tree/resource-request-content-while-loading.html
+on all platforms per bug 23.
+
+* TestExpectations:
+
 2013-02-28  Dirk Pranke  
 
 Unreviewed, rebaselining fast/forms/date-appearance/basic.html for chromium.


Modified: trunk/LayoutTests/TestExpectations (144383 => 144384)

--- trunk/LayoutTests/TestExpectations	2013-02-28 23:33:28 UTC (rev 144383)
+++ trunk/LayoutTests/TestExpectations	2013-02-28 23:37:50 UTC (rev 144384)
@@ -4,3 +4,5 @@
 
 # pending functional patch and per-port verification
 webkit.org/b/109954 css3/line-break [ Skip ]
+
+webkit.org/b/23 http/tests/inspector/resource-tree/resource-request-content-while-loading.html [ Failure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144383] trunk/LayoutTests

[dpranke]

Title: [144383] trunk/LayoutTests








Revision 144383
Author dpra...@chromium.org
Date 2013-02-28 15:33:28 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed, rebaselining fast/forms/date-appearance/basic.html for chromium.

* platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png
trunk/LayoutTests/platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (144382 => 144383)

--- trunk/LayoutTests/ChangeLog	2013-02-28 23:30:41 UTC (rev 144382)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 23:33:28 UTC (rev 144383)
@@ -1,5 +1,16 @@
 2013-02-28  Dirk Pranke  
 
+Unreviewed, rebaselining fast/forms/date-appearance/basic.html for chromium.
+
+* platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
+* platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
+* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
+* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
+* platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
+* platform/chromium/TestExpectations:
+
+2013-02-28  Dirk Pranke  
+
 Unreviewed, rebaselining media/track/track-cue-rendering-vertical.html on chromium
 
 * platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Removed.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144382 => 144383)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 23:30:41 UTC (rev 144382)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 23:33:28 UTC (rev 144383)
@@ -3976,9 +3976,6 @@
 webkit.org/b/98687 fast/css-generated-content/table-row-group-to-inline.html [ Failure ]
 webkit.org/b/104595 fast/css/empty-generated-content.html [ Failure ]
 
-# Needs rebaseline
-webkit.org/b/110974 fast/forms/date/date-appearance-basic.html [ ImageOnlyFailure ]
-
 # These are real failues due to 95121.
 # This is spilling caused by LANCZOS3 scaling algorithm that samples outside the source rect.
 webkit.org/b/95121 [ Win Mac Android ] fast/images/pixel-crack-image-background-webkit-transform-scale.html [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144382] trunk/LayoutTests

[dpranke]

Title: [144382] trunk/LayoutTests








Revision 144382
Author dpra...@chromium.org
Date 2013-02-28 15:30:41 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed, rebaselining media/track/track-cue-rendering-vertical.html on chromium

* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Removed.
* platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.png: Added.
* platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.txt: Added.
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png
trunk/LayoutTests/platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png
trunk/LayoutTests/platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (144381 => 144382)

--- trunk/LayoutTests/ChangeLog	2013-02-28 23:25:38 UTC (rev 144381)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 23:30:41 UTC (rev 144382)
@@ -1,5 +1,18 @@
 2013-02-28  Dirk Pranke  
 
+Unreviewed, rebaselining media/track/track-cue-rendering-vertical.html on chromium
+
+* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Removed.
+* platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.png: Added.
+* platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.txt: Added.
+* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
+* platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
+* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
+* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
+* platform/chromium/TestExpectations:
+
+2013-02-28  Dirk Pranke  
+
 Unreviewed, updating chromium TestExpectations to remove passing tests.
 
 * platform/chromium/TestExpectations:


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144381 => 144382)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 23:25:38 UTC (rev 144381)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 23:30:41 UTC (rev 144382)
@@ -3994,12 +3994,6 @@
 # CSS Device Adaptation is not enabled.
 webkit.org/b/95959 css3/device-adapt [ Skip ]
 
-# Require rebaselining after webkit.org/b/97800
-webkit.org/b/89167 media/track/track-cue-rendering-vertical.html [ Failure ]
-# [Chromium-Android] Subtitles (and video) do not work on Android (Disabled to make linter happy)
-#webkit.org/b/98766 [ Android ] media/track/track-cue-rendering-vertical.html [ Failure ]
-#webkit.org/b/98766 [ Android ] media/track/track-cue-rendering-horizontal.html [ Failure ]
-
 webkit.org/b/23166 ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm [ Pass ImageOnlyFailure ]
 
 webkit.org/b/98699 [ Lion ] fast/writing-mode/vertical-subst-font-vert-no-dflt.html [ Crash ]


Deleted: trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt (144381 => 144382)

--- trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt	2013-02-28 23:25:38 UTC (rev 144381)
+++ trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt	2013-02-28 23:30:41 UTC (rev 144382)
@@ -1,76 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x341
-  RenderBlock {HTML} at (0,0) size 800x341
-RenderBody {BODY} at (8,8) size 784x325
-  RenderBlock (anonymous) at (0,0) size 784x245
-RenderText {#text} at (0,0) size 0x0
-  RenderBlock {DIV} at (0,245) size 784x80
-RenderText {#text} at (0,0) size 349x19
-  text run at (0,0) width 349: "Rendering vertical line-positioned cues with Japanese text."
-RenderBR {BR} at (349,0) size 0x19
-RenderText {#text} at (0,20) size 151x19
-  text run at (0,20) width 151: "EVENT(canplaythrough)"
-RenderBR {BR} at 

[webkit-changes] [144381] trunk/Source/WebCore

[haraken]

Title: [144381] trunk/Source/WebCore








Revision 144381
Author hara...@chromium.org
Date 2013-02-28 15:25:38 -0800 (Thu, 28 Feb 2013)


Log Message
[V8] Remove the world->isMainWorld() check from minorGCPrologue()
https://bugs.webkit.org/show_bug.cgi?id=14

Reviewed by Adam Barth.

A couple of weeks ago, I introduced the following check to minorGCPrologue() in r142419.

  void minorGCPrologue() {
// A minor GC can handle the main world only.
DOMWrapperWorld* world = worldForEnteredContextWithoutContextCheck();
if (world && world->isMainWorld()) {
  MinorGCWrapperVisitor visitor(isolate);
  v8::V8::VisitHandlesForPartialDependence(isolate, &visitor);
  visitor.notifyFinished();
}
  }

- The check makes no sense. A GC should not care about what world we are in.
There is no concept of worlds in GC.

- worldForEnteredContextWithoutContextCheck() returns 0 for the main world.
So if a GC runs in the main world, the minor DOM GC is skipped.

- worldForEnteredContextWithoutContextCheck() caused a Chromium crash
(https://code.google.com/p/chromium/issues/detail?id=177587)

We should remove the check.

No tests. No change in behavior.

* bindings/v8/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::getWorld):
* bindings/v8/V8Binding.h:
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::minorGCPrologue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.h
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/bindings/v8/V8GCController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144380 => 144381)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 23:24:59 UTC (rev 144380)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 23:25:38 UTC (rev 144381)
@@ -1,3 +1,41 @@
+2013-02-28  Kentaro Hara  
+
+[V8] Remove the world->isMainWorld() check from minorGCPrologue()
+https://bugs.webkit.org/show_bug.cgi?id=14
+
+Reviewed by Adam Barth.
+
+A couple of weeks ago, I introduced the following check to minorGCPrologue() in r142419.
+
+  void minorGCPrologue() {
+// A minor GC can handle the main world only.
+DOMWrapperWorld* world = worldForEnteredContextWithoutContextCheck();
+if (world && world->isMainWorld()) {
+  MinorGCWrapperVisitor visitor(isolate);
+  v8::V8::VisitHandlesForPartialDependence(isolate, &visitor);
+  visitor.notifyFinished();
+}
+  }
+
+- The check makes no sense. A GC should not care about what world we are in.
+There is no concept of worlds in GC.
+
+- worldForEnteredContextWithoutContextCheck() returns 0 for the main world.
+So if a GC runs in the main world, the minor DOM GC is skipped.
+
+- worldForEnteredContextWithoutContextCheck() caused a Chromium crash
+(https://code.google.com/p/chromium/issues/detail?id=177587)
+
+We should remove the check.
+
+No tests. No change in behavior.
+
+* bindings/v8/DOMWrapperWorld.h:
+(WebCore::DOMWrapperWorld::getWorld):
+* bindings/v8/V8Binding.h:
+* bindings/v8/V8GCController.cpp:
+(WebCore::V8GCController::minorGCPrologue):
+
 2013-02-28  Bruno de Oliveira Abinader  
 
 Create GraphicsContext3DState to aggregate state objects


Modified: trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.h (144380 => 144381)

--- trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.h	2013-02-28 23:24:59 UTC (rev 144380)
+++ trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.h	2013-02-28 23:25:38 UTC (rev 144381)
@@ -67,10 +67,6 @@
 assertContextHasCorrectPrototype(context);
 return static_cast(context->GetAlignedPointerFromEmbedderData(v8ContextIsolatedWorld));
 }
-static DOMWrapperWorld* getWorldWithoutContextCheck(v8::Handle context)
-{
-return static_cast(context->GetAlignedPointerFromEmbedderData(v8ContextIsolatedWorld));
-}
 
 // Associates an isolated world (see above for description) with a security
 // origin. XMLHttpRequest instances used in that world will be considered


Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (144380 => 144381)

--- trunk/Source/WebCore/bindings/v8/V8Binding.h	2013-02-28 23:24:59 UTC (rev 144380)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h	2013-02-28 23:25:38 UTC (rev 144381)
@@ -458,22 +458,6 @@
 return DOMWrapperWorld::getWorld(context);
 }
 
-// This is a slightly different version of worldForEnteredContext().
-// The difference is just that worldForEnteredContextWithoutContextCheck()
-// does not call assertContextHasCorrectPrototype() (which is enabled on
-// Debug builds only). Because assertContextHasCorrectPrototype() crashes
-// if it is called when a current context is not completely initialized,
-// you have to use worldForEnteredContextWithoutContextCheck() if you need
-// to get a DOMWrapperWorld 

[webkit-changes] [144380] trunk/LayoutTests

[dpranke]

Title: [144380] trunk/LayoutTests








Revision 144380
Author dpra...@chromium.org
Date 2013-02-28 15:24:59 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed, updating chromium TestExpectations to remove passing tests.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (144379 => 144380)

--- trunk/LayoutTests/ChangeLog	2013-02-28 23:23:14 UTC (rev 144379)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 23:24:59 UTC (rev 144380)
@@ -1,3 +1,9 @@
+2013-02-28  Dirk Pranke  
+
+Unreviewed, updating chromium TestExpectations to remove passing tests.
+
+* platform/chromium/TestExpectations:
+
 2013-02-28  Kaustubh Atrawalkar  
 
 Notification.requestPermission callback should be optional


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144379 => 144380)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 23:23:14 UTC (rev 144379)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 23:24:59 UTC (rev 144380)
@@ -157,9 +157,6 @@
 # TEMPORARILY SKIPPED TESTS
 # -
 
-# Underline placement needs to be rounded to match other content.
-webkit.org/b/111005 fast/text/decorations-with-text-combine.html [ ImageOnlyFailure ]
-
 # Context menu behavior differs on Mac. This test needs to be adjusted for Mac.
 webkit.org/b/102987 [ Mac ] fast/events/context-nodrag.html [ Skip ]
 
@@ -615,7 +612,7 @@
 http/tests/security/storage-blocking-strengthened-shared-worker.html [ WontFix ]
 storage/indexeddb/basics-shared-workers.html [ WontFix ]
 
-webkit.org/b/110401 http/tests/security/feed-urls-from-remote.html [ Timeout ]
+webkit.org/b/110401 [ Lion Win7 Debug ] http/tests/security/feed-urls-from-remote.html [ Timeout ]
 
 # test_shell does not support message ports
 webkit.org/b/74459 fast/workers/termination-with-port-messages.html
@@ -1326,7 +1323,7 @@
 webkit.org/b/80517 [ Android Lion SnowLeopard ] svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html [ ImageOnlyFailure ]
 webkit.org/b/80517 [ Android XP ] svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html [ ImageOnlyFailure ]
 webkit.org/b/80517 [ Android Lion SnowLeopard ] svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html [ ImageOnlyFailure ]
-webkit.org/b/80517 [ Android MountainLion XP ] svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html [ ImageOnlyFailure ]
+webkit.org/b/80517 [ Android XP ] svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html [ ImageOnlyFailure ]
 webkit.org/b/80517 [ Android ] svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html [ ImageOnlyFailure ]
 webkit.org/b/80517 [ Android ] svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html [ ImageOnlyFailure ]
 webkit.org/b/80517 [ Debug ] svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html [ ImageOnlyFailure Pass ]
@@ -1412,14 +1409,6 @@
 webkit.org/b/101396 svg/css/clippath-with-shadow.svg
 webkit.org/b/101396 svg/css/arrow-with-shadow.svg
 
-# Need rebaseline after https://bugs.webkit.org/show_bug.cgi?id=109775
-webkit.org/b/109775 [ Lion MountainLion Win7 ] media/controls-after-reload.html [ Failure ]
-webkit.org/b/109775 [ Lion MountainLion Win ] media/controls-strict.html [ Failure ]
-webkit.org/b/109775 [ Lion MountainLion Win ] media/controls-styling-strict.html [ Failure ]
-webkit.org/b/109775 [ MountainLion Win ] media/video-controls-rendering.html [ Failure ]
-webkit.org/b/109775 [ MountainLion XP ] media/video-display-toggle.html [ Failure ]
-webkit.org/b/109775 [ Lion MountainLion Win7 ] media/video-playing-and-pause.html [ Failure ]
-
 # -
 # End SVG TESTS
 # -
@@ -1579,11 +1568,6 @@
 # Missing text -- slow font path unimplemented?
 crbug.com/10344 [ Android Linux ] fast/text/should-use-atsui.html [ ImageOnlyFailure ]
 
-# Failure due to changes of V8's __proto__ property.
-webkit.org/b/110887 fast/dom/Window/window-custom-prototype.html [ Failure ]
-webkit.org/b/110887 fast/js/JSON-parse.html [ Failure ]
-webkit.org/b/110887 fast/js/cyclic-prototypes.html [ Failure ]
-
 # Needs V8 fix. V8 bug: http://code.google.com/p/v8/issues/detail?id=1992
 webkit.org/b/80335 fast/js/mozilla/strict/15.4.4.8.html [ Failure ]
 webkit.org/b/80335 fast/js/mozilla/strict/15.4.4.9.html [ Failure ]
@@ -2876,9 +2860,6 @@
 
 webkit.org/b/96267 fast/regions/autoheight-regions-mark.html [ Pass ]
 
-#something is hosed with seamless iframe repainting
-webkit.org/b/106125 fast/regions/seamless-iframe-flowed-into-regions.html [ ImageOnlyFailure ]
-
 webkit.org/b/74137 [ SnowLeopard ] fast/regions/outline-sides-in-region.html [ Pass Timeout ]
 webkit.org/b/74137 fast/regions/float-p

[webkit-changes] [144379] trunk/Source/JavaScriptCore

[fpizlo]

Title: [144379] trunk/Source/_javascript_Core








Revision 144379
Author fpi...@apple.com
Date 2013-02-28 15:23:14 -0800 (Thu, 28 Feb 2013)


Log Message
Don't try to emit profiling if you don't have the DFG JIT.

Rubber stamped by Mark Hahnenberg.

* jit/JIT.h:
(JSC::JIT::shouldEmitProfiling):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JIT.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (144378 => 144379)

--- trunk/Source/_javascript_Core/ChangeLog	2013-02-28 23:17:36 UTC (rev 144378)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-02-28 23:23:14 UTC (rev 144379)
@@ -1,5 +1,14 @@
 2013-02-28  Filip Pizlo  
 
+Don't try to emit profiling if you don't have the DFG JIT.
+
+Rubber stamped by Mark Hahnenberg.
+
+* jit/JIT.h:
+(JSC::JIT::shouldEmitProfiling):
+
+2013-02-28  Filip Pizlo  
+
 DFG Phantom node should be honest about the fact that it can exit
 https://bugs.webkit.org/show_bug.cgi?id=15
 


Modified: trunk/Source/_javascript_Core/jit/JIT.h (144378 => 144379)

--- trunk/Source/_javascript_Core/jit/JIT.h	2013-02-28 23:17:36 UTC (rev 144378)
+++ trunk/Source/_javascript_Core/jit/JIT.h	2013-02-28 23:23:14 UTC (rev 144379)
@@ -904,7 +904,7 @@
 bool canBeOptimizedOrInlined() { return false; }
 // Enables use of value profiler with tiered compilation turned off,
 // in which case all code gets profiled.
-bool shouldEmitProfiling() { return true; }
+bool shouldEmitProfiling() { return false; }
 #endif
 
 Interpreter* m_interpreter;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144378] trunk/Source/WebCore

[bruno . abinader]

Title: [144378] trunk/Source/WebCore








Revision 144378
Author bruno.abina...@basyskom.com
Date 2013-02-28 15:17:36 -0800 (Thu, 28 Feb 2013)


Log Message
Create GraphicsContext3DState to aggregate state objects
https://bugs.webkit.org/show_bug.cgi?id=110817

Reviewed by Kenneth Russell.

Aggregate context state-related objects on a GraphicsContext3DState
struct, in a similar fashion as GraphicsContext does. This is useful to
avoid duplicated values for platform-specific initialization lists.

No behavior changes, thus covered by existing tests.

* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::GraphicsContext3DState::GraphicsContext3DState):
(GraphicsContext3DState):
(GraphicsContext3D):
Moved m_boundFBO, m_activeTexture and m_boundTexture0 to GraphicsContext3DState.

* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::reshapeFBOs):
* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::readPixels):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteTexture):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::createOffscreenBuffers):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
(WebCore::GraphicsContext3D::GraphicsContext3D):
Removed initialization list values not needed anymore and reassigned
calls to m_boundFBO, m_boundTexture0 and m_activeTexture to m_state
respectives.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h
trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp
trunk/Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp
trunk/Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp
trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp
trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144377 => 144378)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 23:06:44 UTC (rev 144377)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 23:17:36 UTC (rev 144378)
@@ -1,3 +1,62 @@
+2013-02-28  Bruno de Oliveira Abinader  
+
+Create GraphicsContext3DState to aggregate state objects
+https://bugs.webkit.org/show_bug.cgi?id=110817
+
+Reviewed by Kenneth Russell.
+
+Aggregate context state-related objects on a GraphicsContext3DState
+struct, in a similar fashion as GraphicsContext does. This is useful to
+avoid duplicated values for platform-specific initialization lists.
+
+No behavior changes, thus covered by existing tests.
+
+* platform/graphics/GraphicsContext3D.h:
+(WebCore::GraphicsContext3D::GraphicsContext3DState::GraphicsContext3DState):
+(GraphicsContext3DState):
+(GraphicsContext3D):
+Moved m_boundFBO, m_activeTexture and m_boundTexture0 to GraphicsContext3DState.
+
+* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
+(WebCore::GraphicsContext3D::GraphicsContext3D):
+(WebCore::GraphicsContext3D::reshapeFBOs):
+* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
+(WebCore::GraphicsContext3D::GraphicsContext3D):
+* platform/gra

[webkit-changes] [144377] trunk/Source/WebCore

[hyatt]

Title: [144377] trunk/Source/WebCore








Revision 144377
Author hy...@apple.com
Date 2013-02-28 15:06:44 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed build fix. A merge error led to a duplication of a single line.
Just removing the duplicate line.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createLocalTransformState):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144376 => 144377)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 22:57:48 UTC (rev 144376)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 23:06:44 UTC (rev 144377)
@@ -1,3 +1,11 @@
+2013-02-28  David Hyatt  
+
+Unreviewed build fix. A merge error led to a duplication of a single line.
+Just removing the duplicate line.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::createLocalTransformState):
+
 2013-02-28  Kaustubh Atrawalkar  
 
 Notification.requestPermission callback should be optional


Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (144376 => 144377)

--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2013-02-28 22:57:48 UTC (rev 144376)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2013-02-28 23:06:44 UTC (rev 144377)
@@ -4368,8 +4368,6 @@
 }
 offset.moveBy(translationOffset);
 
-offset.moveBy(translationOffset);
-
 RenderObject* containerRenderer = containerLayer ? containerLayer->renderer() : 0;
 if (renderer()->shouldUseTransformFromContainer(containerRenderer)) {
 TransformationMatrix containerTransform;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144375] trunk

[commit-queue]

Title: [144375] trunk








Revision 144375
Author commit-qu...@webkit.org
Date 2013-02-28 14:54:13 -0800 (Thu, 28 Feb 2013)


Log Message
Underline should round to match other content.
https://bugs.webkit.org/show_bug.cgi?id=111005

Patch by Ben Wagner  on 2013-02-28
Reviewed by Stephen White.

Test: fast/text/decorations-with-text-combine.html

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForText):
Round (instead of floor) underlines to match other content.

Modified Paths

trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp




Diff

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144374 => 144375)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 22:51:42 UTC (rev 144374)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 22:54:13 UTC (rev 144375)
@@ -157,6 +157,9 @@
 # TEMPORARILY SKIPPED TESTS
 # -
 
+# Underline placement needs to be rounded to match other content.
+webkit.org/b/111005 fast/text/decorations-with-text-combine.html [ ImageOnlyFailure ]
+
 # Context menu behavior differs on Mac. This test needs to be adjusted for Mac.
 webkit.org/b/102987 [ Mac ] fast/events/context-nodrag.html [ Skip ]
 


Modified: trunk/Source/WebCore/ChangeLog (144374 => 144375)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 22:51:42 UTC (rev 144374)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 22:54:13 UTC (rev 144375)
@@ -1,3 +1,16 @@
+2013-02-28  Ben Wagner  
+
+Underline should round to match other content.
+https://bugs.webkit.org/show_bug.cgi?id=111005
+
+Reviewed by Stephen White.
+
+Test: fast/text/decorations-with-text-combine.html
+
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+(WebCore::GraphicsContext::drawLineForText):
+Round (instead of floor) underlines to match other content.
+
 2013-02-28  Eric Carlson  
 
 Refine Ryosuke's r144367 fix.


Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (144374 => 144375)

--- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	2013-02-28 22:51:42 UTC (rev 144374)
+++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	2013-02-28 22:54:13 UTC (rev 144375)
@@ -750,7 +750,8 @@
 SkRect r;
 r.fLeft = WebCoreFloatToSkScalar(pt.x());
 // Avoid anti-aliasing lines. Currently, these are always horizontal.
-r.fTop = WebCoreFloatToSkScalar(floorf(pt.y()));
+// Round to nearest pixel to match text and other content.
+r.fTop = WebCoreFloatToSkScalar(floorf(pt.y() + 0.5f));
 r.fRight = r.fLeft + WebCoreFloatToSkScalar(width);
 r.fBottom = r.fTop + SkIntToScalar(thickness);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144374] trunk/Source/WebCore

[eric . carlson]

Title: [144374] trunk/Source/WebCore








Revision 144374
Author eric.carl...@apple.com
Date 2013-02-28 14:51:42 -0800 (Thu, 28 Feb 2013)


Log Message
Refine Ryosuke's r144367 fix.

Rubber-stamped by Ryosuke Niwa.

* page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PageGroup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144373 => 144374)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 22:48:33 UTC (rev 144373)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 22:51:42 UTC (rev 144374)
@@ -1,14 +1,11 @@
-2013-02-28  Alexey Proskuryakov  
+2013-02-28  Eric Carlson  
 
-Windows build fix.
+Refine Ryosuke's r144367 fix.
 
-Removing ENABLE(BLOB) checks that I added in bug 00. Many, many more are needed
-to cleanly disable blob code.
+Rubber-stamped by Ryosuke Niwa.
 
-* platform/network/BlobData.h:
-* platform/network/BlobRegistryImpl.cpp:
-* platform/network/BlobRegistryImpl.h:
-* platform/network/BlobStorageData.h:
+* page/PageGroup.cpp:
+(WebCore::PageGroup::captionPreferences):
 
 2013-02-28  Eric Seidel  
 


Modified: trunk/Source/WebCore/page/PageGroup.cpp (144373 => 144374)

--- trunk/Source/WebCore/page/PageGroup.cpp	2013-02-28 22:48:33 UTC (rev 144373)
+++ trunk/Source/WebCore/page/PageGroup.cpp	2013-02-28 22:51:42 UTC (rev 144374)
@@ -39,7 +39,7 @@
 #include "StorageNamespace.h"
 
 #if ENABLE(VIDEO_TRACK)
-#if PLATFORM(MAC) && !PLATFORM(IOS)
+#if (PLATFORM(MAC) && !PLATFORM(IOS)) || HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 #include "CaptionUserPreferencesMac.h"
 #else
 #include "CaptionUserPreferences.h"
@@ -420,7 +420,7 @@
 CaptionUserPreferences* PageGroup::captionPreferences()
 {
 if (!m_captionPreferences)
-#if PLATFORM(MAC) && !PLATFORM(IOS)
+#if (PLATFORM(MAC) && !PLATFORM(IOS)) || HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 m_captionPreferences = CaptionUserPreferencesMac::create(this);
 #else
 m_captionPreferences = CaptionUserPreferences::create(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144373] trunk/Source/JavaScriptCore

[fpizlo]

Title: [144373] trunk/Source/_javascript_Core








Revision 144373
Author fpi...@apple.com
Date 2013-02-28 14:48:33 -0800 (Thu, 28 Feb 2013)


Log Message
DFG Phantom node should be honest about the fact that it can exit
https://bugs.webkit.org/show_bug.cgi?id=15

Reviewed by Mark Hahnenberg.

The chances of this having cause serious issues are low, since most clients of the
NodeDoesNotExit flag run after CFA and CFA updates this properly. But one possible
case of badness is if the ByteCodeParser inserted a Phantom with a type check in
between a LogicalNot and a Branch; then that peephole optimization in Fixup might
go slightly wrong.

* dfg/DFGNodeType.h:
(DFG):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGNodeType.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (144372 => 144373)

--- trunk/Source/_javascript_Core/ChangeLog	2013-02-28 22:46:32 UTC (rev 144372)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-02-28 22:48:33 UTC (rev 144373)
@@ -1,3 +1,19 @@
+2013-02-28  Filip Pizlo  
+
+DFG Phantom node should be honest about the fact that it can exit
+https://bugs.webkit.org/show_bug.cgi?id=15
+
+Reviewed by Mark Hahnenberg.
+
+The chances of this having cause serious issues are low, since most clients of the
+NodeDoesNotExit flag run after CFA and CFA updates this properly. But one possible
+case of badness is if the ByteCodeParser inserted a Phantom with a type check in
+between a LogicalNot and a Branch; then that peephole optimization in Fixup might
+go slightly wrong.
+
+* dfg/DFGNodeType.h:
+(DFG):
+
 2013-02-28  Mark Hahnenberg  
 
 Add casts in DFGGPRInfo.h to suppress warnings


Modified: trunk/Source/_javascript_Core/dfg/DFGNodeType.h (144372 => 144373)

--- trunk/Source/_javascript_Core/dfg/DFGNodeType.h	2013-02-28 22:46:32 UTC (rev 144372)
+++ trunk/Source/_javascript_Core/dfg/DFGNodeType.h	2013-02-28 22:48:33 UTC (rev 144373)
@@ -59,7 +59,7 @@
 /* VariableAccessData, and thus will share predictions. */\
 macro(GetLocal, NodeResultJS) \
 macro(SetLocal, NodeExitsForward) \
-macro(Phantom, NodeMustGenerate | NodeDoesNotExit) \
+macro(Phantom, NodeMustGenerate) \
 macro(Nop, NodeDoesNotExit) \
 macro(Phi, NodeDoesNotExit | NodeRelevantToOSR) \
 macro(Flush, NodeMustGenerate | NodeDoesNotExit) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144372] trunk/Source/WebCore

[ap]

Title: [144372] trunk/Source/WebCore








Revision 144372
Author a...@apple.com
Date 2013-02-28 14:46:32 -0800 (Thu, 28 Feb 2013)


Log Message
Windows build fix.

Removing ENABLE(BLOB) checks that I added in bug 00. Many, many more are needed
to cleanly disable blob code.

* platform/network/BlobData.h:
* platform/network/BlobRegistryImpl.cpp:
* platform/network/BlobRegistryImpl.h:
* platform/network/BlobStorageData.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/BlobData.h
trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp
trunk/Source/WebCore/platform/network/BlobRegistryImpl.h
trunk/Source/WebCore/platform/network/BlobStorageData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (144371 => 144372)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 22:33:59 UTC (rev 144371)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 22:46:32 UTC (rev 144372)
@@ -1,3 +1,15 @@
+2013-02-28  Alexey Proskuryakov  
+
+Windows build fix.
+
+Removing ENABLE(BLOB) checks that I added in bug 00. Many, many more are needed
+to cleanly disable blob code.
+
+* platform/network/BlobData.h:
+* platform/network/BlobRegistryImpl.cpp:
+* platform/network/BlobRegistryImpl.h:
+* platform/network/BlobStorageData.h:
+
 2013-02-28  Eric Seidel  
 
 Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()


Modified: trunk/Source/WebCore/platform/network/BlobData.h (144371 => 144372)

--- trunk/Source/WebCore/platform/network/BlobData.h	2013-02-28 22:33:59 UTC (rev 144371)
+++ trunk/Source/WebCore/platform/network/BlobData.h	2013-02-28 22:46:32 UTC (rev 144372)
@@ -31,8 +31,6 @@
 #ifndef BlobData_h
 #define BlobData_h
 
-#if ENABLE(BLOB)
-
 #include "FileSystem.h"
 #include "KURL.h"
 #include 
@@ -206,6 +204,4 @@
 
 } // namespace WebCore
 
-#endif // ENABLE(BLOB)
-
 #endif // BlobData_h


Modified: trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp (144371 => 144372)

--- trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp	2013-02-28 22:33:59 UTC (rev 144371)
+++ trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp	2013-02-28 22:46:32 UTC (rev 144372)
@@ -32,8 +32,6 @@
 #include "config.h"
 #include "BlobRegistryImpl.h"
 
-#if ENABLE(BLOB)
-
 #include "BlobResourceHandle.h"
 #include "BlobStorageData.h"
 #include "ResourceError.h"
@@ -198,5 +196,3 @@
 }
 
 } // namespace WebCore
-
-#endif // ENABLE(BLOB)


Modified: trunk/Source/WebCore/platform/network/BlobRegistryImpl.h (144371 => 144372)

--- trunk/Source/WebCore/platform/network/BlobRegistryImpl.h	2013-02-28 22:33:59 UTC (rev 144371)
+++ trunk/Source/WebCore/platform/network/BlobRegistryImpl.h	2013-02-28 22:46:32 UTC (rev 144372)
@@ -31,8 +31,6 @@
 #ifndef BlobRegistryImpl_h
 #define BlobRegistryImpl_h
 
-#if ENABLE(BLOB)
-
 #include "BlobRegistry.h"
 #include "BlobStorageData.h"
 #include 
@@ -70,6 +68,4 @@
 
 } // namespace WebCore
 
-#endif // ENABLE(BLOB)
-
 #endif // BlobRegistryImpl_h


Modified: trunk/Source/WebCore/platform/network/BlobStorageData.h (144371 => 144372)

--- trunk/Source/WebCore/platform/network/BlobStorageData.h	2013-02-28 22:33:59 UTC (rev 144371)
+++ trunk/Source/WebCore/platform/network/BlobStorageData.h	2013-02-28 22:46:32 UTC (rev 144372)
@@ -31,8 +31,6 @@
 #ifndef BlobStorageData_h
 #define BlobStorageData_h
 
-#if ENABLE(BLOB)
-
 #include "BlobData.h"
 #include 
 #include 
@@ -64,6 +62,4 @@
 
 } // namespace WebCore
 
-#endif
-
 #endif // BlobStorageData_h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144371] tags/Safari-537.32/Source/WebKit2

[lforschler]

Title: [144371] tags/Safari-537.32/Source/WebKit2








Revision 144371
Author lforsch...@apple.com
Date 2013-02-28 14:33:59 -0800 (Thu, 28 Feb 2013)


Log Message
Merged r144324.  

Modified Paths

tags/Safari-537.32/Source/WebKit2/ChangeLog
tags/Safari-537.32/Source/WebKit2/Configurations/BaseXPCService.xcconfig




Diff

Modified: tags/Safari-537.32/Source/WebKit2/ChangeLog (144370 => 144371)

--- tags/Safari-537.32/Source/WebKit2/ChangeLog	2013-02-28 22:33:32 UTC (rev 144370)
+++ tags/Safari-537.32/Source/WebKit2/ChangeLog	2013-02-28 22:33:59 UTC (rev 144371)
@@ -1,3 +1,16 @@
+2013-02-28  Lucas Forschler  
+
+Merge r144324
+
+2013-02-28  Sam Weinig  
+
+Don't install unused XPCServices on Lion
+
+
+Rubber-stamped by Anders Carlsson
+
+* Configurations/BaseXPCService.xcconfig:
+
 2013-02-27  Csaba Osztrogonác  
 
 [WK2] One more unreviewed buildfix for EFL, GTK and Qt after r144218.


Modified: tags/Safari-537.32/Source/WebKit2/Configurations/BaseXPCService.xcconfig (144370 => 144371)

--- tags/Safari-537.32/Source/WebKit2/Configurations/BaseXPCService.xcconfig	2013-02-28 22:33:32 UTC (rev 144370)
+++ tags/Safari-537.32/Source/WebKit2/Configurations/BaseXPCService.xcconfig	2013-02-28 22:33:59 UTC (rev 144371)
@@ -36,3 +36,8 @@
 
 WRAPPER_EXTENSION = xpc;
 MACH_O_TYPE = mh_execute;
+
+SKIP_INSTALL = $(SKIP_INSTALL_$(TARGET_MAC_OS_X_VERSION_MAJOR));
+SKIP_INSTALL_1070 = YES;
+SKIP_INSTALL_1080 = NO;
+SKIP_INSTALL_1090 = NO;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144370] trunk

[eric]

Title: [144370] trunk








Revision 144370
Author e...@webkit.org
Date 2013-02-28 14:33:32 -0800 (Thu, 28 Feb 2013)


Log Message
Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
https://bugs.webkit.org/show_bug.cgi?id=110937

Reviewed by Adam Barth.

Remove the #ifdef guards added to work around this ASSERT.
This was fixed by https://bugs.webkit.org/show_bug.cgi?id=110951
as now DocumentLoader::checkLoadComplete() will ignore the call
if the DocumentLoader is not the active document loader for the Document.

* dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::checkLoadComplete):

Modified Paths

trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp




Diff

Modified: trunk/LayoutTests/platform/mac/TestExpectations (144369 => 144370)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-02-28 22:08:05 UTC (rev 144369)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-02-28 22:33:32 UTC (rev 144370)
@@ -1439,7 +1439,6 @@
 
 webkit.org/b/110186 inspector-protocol/page/_javascript_DialogEvents.html [ Skip ]
 
-webkit.org/b/110554 http/tests/security/feed-urls-from-remote.html [ Failure ]
 webkit.org/b/110555 fast/canvas/canvas-currentPath.html [ Failure ]
 webkit.org/b/110555 fast/canvas/canvas-path-constructors.html [ Failure ]
 


Modified: trunk/Source/WebCore/ChangeLog (144369 => 144370)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 22:08:05 UTC (rev 144369)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 22:33:32 UTC (rev 144370)
@@ -1,3 +1,21 @@
+2013-02-28  Eric Seidel  
+
+Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
+https://bugs.webkit.org/show_bug.cgi?id=110937
+
+Reviewed by Adam Barth.
+
+Remove the #ifdef guards added to work around this ASSERT.
+This was fixed by https://bugs.webkit.org/show_bug.cgi?id=110951
+as now DocumentLoader::checkLoadComplete() will ignore the call
+if the DocumentLoader is not the active document loader for the Document.
+
+* dom/Document.cpp:
+(WebCore::Document::decrementActiveParserCount):
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::isLoading):
+(WebCore::DocumentLoader::checkLoadComplete):
+
 2013-02-28  Ryosuke Niwa  
 
 Revert an erroneous change in r144336.


Modified: trunk/Source/WebCore/dom/Document.cpp (144369 => 144370)

--- trunk/Source/WebCore/dom/Document.cpp	2013-02-28 22:08:05 UTC (rev 144369)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-02-28 22:33:32 UTC (rev 144370)
@@ -5808,12 +5808,7 @@
 --m_activeParserCount;
 if (!frame())
 return;
-// FIXME: This should always be enabled, but it seems to cause
-// http/tests/security/feed-urls-from-remote.html to timeout on Mac WK1
-// see http://webkit.org/b/110554 and http://webkit.org/b/110401
-#if ENABLE(THREADED_HTML_PARSER)
 loader()->checkLoadComplete();
-#endif
 frame()->loader()->checkLoadComplete();
 }
 


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (144369 => 144370)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2013-02-28 22:08:05 UTC (rev 144369)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2013-02-28 22:33:32 UTC (rev 144370)
@@ -287,13 +287,8 @@
 
 bool DocumentLoader::isLoading() const
 {
-// FIXME: This should always be enabled, but it seems to cause
-// http/tests/security/feed-urls-from-remote.html to timeout on Mac WK1
-// see http://webkit.org/b/110554 and http://webkit.org/b/110401
-#if ENABLE(THREADED_HTML_PARSER)
 if (document() && document()->hasActiveParser())
 return true;
-#endif
 return isLoadingMainResource() || !m_subresourceLoaders.isEmpty() || !m_plugInStreamLoaders.isEmpty();
 }
 
@@ -438,11 +433,7 @@
 {
 if (!m_frame || isLoading())
 return;
-#if !ENABLE(THREADED_HTML_PARSER)
-// This ASSERT triggers with the threaded HTML parser.
-// See https://bugs.webkit.org/show_bug.cgi?id=110937
 ASSERT(this == frameLoader()->activeDocumentLoader());
-#endif
 m_frame->document()->domWindow()->finishedLoading();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144369] trunk/Tools/Scripts/webkitpy/common/config/committers.py

[lforschler]

Title: [144369] trunk/Tools/Scripts/webkitpy/common/config/committers.py








Revision 144369
Author lforsch...@apple.com
Date 2013-02-28 14:08:05 -0800 (Thu, 28 Feb 2013)


Log Message
Rollout r144366.  

Modified Paths

trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (144368 => 144369)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-02-28 22:06:46 UTC (rev 144368)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-02-28 22:08:05 UTC (rev 144369)
@@ -253,7 +253,6 @@
 Committer("Claudio Saavedra", "csaave...@igalia.com", "claudio___"),
 Committer("Collin Jackson", "coll...@webkit.org", "collinjackson"),
 Committer("Cris Neckar", "c...@chromium.org", "cneckar"),
-Committer("Damian Kaleta", "dkal...@apple.com", "kaleta"),
 Committer("Dan Winship", "d...@gnome.org", "danw"),
 Committer("Dana Jansens", "dan...@chromium.org", "danakj"),
 Committer("Daniel Cheng", "dch...@chromium.org", "dcheng"),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144368] trunk/LayoutTests

[schenney]

Title: [144368] trunk/LayoutTests








Revision 144368
Author schen...@chromium.org
Date 2013-02-28 14:06:46 -0800 (Thu, 28 Feb 2013)


Log Message
[Chromium] Move html5linb tests to be Slow rather than Timeout

Unreviewed expectations. Requested by Eric Seidel.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (144367 => 144368)

--- trunk/LayoutTests/ChangeLog	2013-02-28 22:02:09 UTC (rev 144367)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 22:06:46 UTC (rev 144368)
@@ -1,3 +1,11 @@
+2013-02-28  Stephen Chenney  
+
+[Chromium] Move html5linb tests to be Slow rather than Timeout
+
+Unreviewed expectations. Requested by Eric Seidel.
+
+* platform/chromium/TestExpectations:
+
 2013-02-28  Jochen Eisinger  
 
 Meta referrer isn't honored for window.open


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144367 => 144368)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 22:02:09 UTC (rev 144367)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 22:06:46 UTC (rev 144368)
@@ -4446,11 +4446,13 @@
 webkit.org/b/110540 [ Linux ] fast/text/international/thai-line-breaks.html [ ImageOnlyFailure Pass ]
 
 # These tests are timing out since r144032
-webkit.org/b/110876 [ Debug ] html5lib/generated/run-template-data.html [ Timeout ]
-webkit.org/b/110876 [ Debug ] html5lib/generated/run-tests1-data.html [ Timeout ]
-webkit.org/b/110876 [ Debug Win Lion ] html5lib/generated/run-tests10-data.html [ Timeout  ]
-webkit.org/b/110876 html5lib/generated/run-tests16-data.html [ Timeout ]
-webkit.org/b/110876 [ Debug Win Mac ] html5lib/generated/run-tests19-data.html [ Timeout ]
+webkit.org/b/110876 html5lib/generated/run-template-data.html [ Slow ]
+webkit.org/b/110876 html5lib/generated/run-tests1-data.html [ Slow ]
+webkit.org/b/110876 html5lib/generated/run-tests2-data.html [ Slow ]
+webkit.org/b/110876 html5lib/generated/run-tests10-data.html [ Slow  ]
+webkit.org/b/110876 html5lib/generated/run-tests16-data.html [ Slow ]
+webkit.org/b/110876 html5lib/generated/run-tests18-data.html [ Slow ]
+webkit.org/b/110876 html5lib/generated/run-tests19-data.html [ Slow ]
 # These html5lib/ tests are also failing
 webkit.org/b/110876 [ Debug Win ] html5lib/generated/run-tests10-write.html [ Pass Crash ]
 webkit.org/b/110876 [ Debug Win Mac ] html5lib/generated/run-tests16-write.html [ Pass Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144367] trunk/Source/WebCore

[rniwa]

Title: [144367] trunk/Source/WebCore








Revision 144367
Author rn...@webkit.org
Date 2013-02-28 14:02:09 -0800 (Thu, 28 Feb 2013)


Log Message
Revert an erroneous change in r144336.

Rubber-stamped by Eric Carlson.

* page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PageGroup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144366 => 144367)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 22:01:27 UTC (rev 144366)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 22:02:09 UTC (rev 144367)
@@ -1,3 +1,12 @@
+2013-02-28  Ryosuke Niwa  
+
+Revert an erroneous change in r144336.
+
+Rubber-stamped by Eric Carlson.
+
+* page/PageGroup.cpp:
+(WebCore::PageGroup::captionPreferences):
+
 2013-02-28  David Hyatt  
 
 Unreviewed build fix for Windows. Make sure the new bits are unsigned and not bools.


Modified: trunk/Source/WebCore/page/PageGroup.cpp (144366 => 144367)

--- trunk/Source/WebCore/page/PageGroup.cpp	2013-02-28 22:01:27 UTC (rev 144366)
+++ trunk/Source/WebCore/page/PageGroup.cpp	2013-02-28 22:02:09 UTC (rev 144367)
@@ -39,7 +39,7 @@
 #include "StorageNamespace.h"
 
 #if ENABLE(VIDEO_TRACK)
-#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
+#if PLATFORM(MAC) && !PLATFORM(IOS)
 #include "CaptionUserPreferencesMac.h"
 #else
 #include "CaptionUserPreferences.h"
@@ -420,7 +420,7 @@
 CaptionUserPreferences* PageGroup::captionPreferences()
 {
 if (!m_captionPreferences)
-#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
+#if PLATFORM(MAC) && !PLATFORM(IOS)
 m_captionPreferences = CaptionUserPreferencesMac::create(this);
 #else
 m_captionPreferences = CaptionUserPreferences::create(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144366] trunk/Tools/Scripts/webkitpy/common/config/committers.py

[lforschler]

Title: [144366] trunk/Tools/Scripts/webkitpy/common/config/committers.py








Revision 144366
Author lforsch...@apple.com
Date 2013-02-28 14:01:27 -0800 (Thu, 28 Feb 2013)


Log Message
Give Damian Committer privs.

Modified Paths

trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (144365 => 144366)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-02-28 21:57:24 UTC (rev 144365)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-02-28 22:01:27 UTC (rev 144366)
@@ -253,6 +253,7 @@
 Committer("Claudio Saavedra", "csaave...@igalia.com", "claudio___"),
 Committer("Collin Jackson", "coll...@webkit.org", "collinjackson"),
 Committer("Cris Neckar", "c...@chromium.org", "cneckar"),
+Committer("Damian Kaleta", "dkal...@apple.com", "kaleta"),
 Committer("Dan Winship", "d...@gnome.org", "danw"),
 Committer("Dana Jansens", "dan...@chromium.org", "danakj"),
 Committer("Daniel Cheng", "dch...@chromium.org", "dcheng"),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144365] trunk/Source/JavaScriptCore

[mhahnenberg]

Title: [144365] trunk/Source/_javascript_Core








Revision 144365
Author mhahnenb...@apple.com
Date 2013-02-28 13:57:24 -0800 (Thu, 28 Feb 2013)


Log Message
Add casts in DFGGPRInfo.h to suppress warnings
https://bugs.webkit.org/show_bug.cgi?id=04

Reviewed by Filip Pizlo.

With certain flags on, we get compiler warnings on ARM. We should do the proper casts to make these warnings go away.

* dfg/DFGGPRInfo.h:
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGGPRInfo.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (144364 => 144365)

--- trunk/Source/_javascript_Core/ChangeLog	2013-02-28 21:52:56 UTC (rev 144364)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-02-28 21:57:24 UTC (rev 144365)
@@ -1,3 +1,16 @@
+2013-02-28  Mark Hahnenberg  
+
+Add casts in DFGGPRInfo.h to suppress warnings
+https://bugs.webkit.org/show_bug.cgi?id=04
+
+Reviewed by Filip Pizlo.
+
+With certain flags on, we get compiler warnings on ARM. We should do the proper casts to make these warnings go away.
+
+* dfg/DFGGPRInfo.h:
+(JSC::DFG::GPRInfo::toIndex):
+(JSC::DFG::GPRInfo::debugName):
+
 2013-02-28  Filip Pizlo  
 
 It should be easy to determine if a DFG node exits forward or backward when doing type checks


Modified: trunk/Source/_javascript_Core/dfg/DFGGPRInfo.h (144364 => 144365)

--- trunk/Source/_javascript_Core/dfg/DFGGPRInfo.h	2013-02-28 21:52:56 UTC (rev 144364)
+++ trunk/Source/_javascript_Core/dfg/DFGGPRInfo.h	2013-02-28 21:57:24 UTC (rev 144365)
@@ -434,8 +434,8 @@
 
 static unsigned toIndex(GPRReg reg)
 {
-ASSERT(reg != InvalidGPRReg);
-ASSERT(reg < 16);
+ASSERT(static_cast(reg) != InvalidGPRReg);
+ASSERT(static_cast(reg) < 16);
 static const unsigned indexForRegister[16] = { 0, 1, 2, InvalidIndex, 3, InvalidIndex, InvalidIndex, InvalidIndex, 4, 5, 6, 7, InvalidIndex, InvalidIndex, InvalidIndex, InvalidIndex };
 unsigned result = indexForRegister[reg];
 ASSERT(result != InvalidIndex);
@@ -444,8 +444,8 @@
 
 static const char* debugName(GPRReg reg)
 {
-ASSERT(reg != InvalidGPRReg);
-ASSERT(reg < 16);
+ASSERT(static_cast(reg) != InvalidGPRReg);
+ASSERT(static_cast(reg) < 16);
 static const char* nameForRegister[16] = {
 "r0", "r1", "r2", "r3",
 "r4", "r5", "r6", "r7",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144364] trunk/Source/WebCore

[hyatt]

Title: [144364] trunk/Source/WebCore








Revision 144364
Author hy...@apple.com
Date 2013-02-28 13:52:56 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed build fix for Windows. Make sure the new bits are unsigned and not bools.

* rendering/RenderBlock.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (144363 => 144364)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 21:52:22 UTC (rev 144363)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 21:52:56 UTC (rev 144364)
@@ -1,3 +1,9 @@
+2013-02-28  David Hyatt  
+
+Unreviewed build fix for Windows. Make sure the new bits are unsigned and not bools.
+
+* rendering/RenderBlock.h:
+
 2013-02-28  Jochen Eisinger  
 
 Meta referrer isn't honored for window.open


Modified: trunk/Source/WebCore/rendering/RenderBlock.h (144363 => 144364)

--- trunk/Source/WebCore/rendering/RenderBlock.h	2013-02-28 21:52:22 UTC (rev 144363)
+++ trunk/Source/WebCore/rendering/RenderBlock.h	2013-02-28 21:52:56 UTC (rev 144364)
@@ -1245,8 +1245,8 @@
 RenderLineBoxList m_lineBoxes;   // All of the root line boxes created for this block flow.  For example, Helloworld. will have two total lines for the .
 
 mutable signed m_lineHeight : 27;
-bool m_hasMarginBeforeQuirk : 1; // Note these quirk values can't be put in RenderBlockRareData since they are set too frequently.
-bool m_hasMarginAfterQuirk : 1;
+unsigned m_hasMarginBeforeQuirk : 1; // Note these quirk values can't be put in RenderBlockRareData since they are set too frequently.
+unsigned m_hasMarginAfterQuirk : 1;
 unsigned m_beingDestroyed : 1;
 unsigned m_hasMarkupTruncation : 1;
 unsigned m_hasBorderOrPaddingLogicalWidthChanged : 1;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144363] trunk/Tools

[rniwa]

Title: [144363] trunk/Tools








Revision 144363
Author rn...@webkit.org
Date 2013-02-28 13:52:22 -0800 (Thu, 28 Feb 2013)


Log Message
Merge more methods on PerfTest
https://bugs.webkit.org/show_bug.cgi?id=111030

Reviewed by Dirk Pranke.

Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.

This makes the control flow a lot more comprehensible.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest._run_with_driver):
(PerfTest._should_ignore_line):
(PerfTest._filter_output):

* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTest._assert_results_are_correct):
(test_ignored_stderr_lines):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (144362 => 144363)

--- trunk/Tools/ChangeLog	2013-02-28 21:51:25 UTC (rev 144362)
+++ trunk/Tools/ChangeLog	2013-02-28 21:52:22 UTC (rev 144363)
@@ -1,3 +1,24 @@
+2013-02-28  Ryosuke Niwa  
+
+Merge more methods on PerfTest
+https://bugs.webkit.org/show_bug.cgi?id=111030
+
+Reviewed by Dirk Pranke.
+
+Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
+and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
+
+This makes the control flow a lot more comprehensible.
+
+* Scripts/webkitpy/performance_tests/perftest.py:
+(PerfTest._run_with_driver):
+(PerfTest._should_ignore_line):
+(PerfTest._filter_output):
+
+* Scripts/webkitpy/performance_tests/perftest_unittest.py:
+(TestPerfTest._assert_results_are_correct):
+(test_ignored_stderr_lines):
+
 2013-02-28  Robert Hogan  
 
 Update my IRC nick


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py (144362 => 144363)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2013-02-28 21:51:25 UTC (rev 144362)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2013-02-28 21:52:22 UTC (rev 144363)
@@ -151,14 +151,42 @@
 
 return results
 
+_description_regex = re.compile(r'^Description: (?P.*)$', re.IGNORECASE)
+_metrics_regex = re.compile(r'^(?PTime|Malloc|JS Heap):')
+_statistics_keys = ['avg', 'median', 'stdev', 'min', 'max', 'unit', 'values']
+_score_regex = re.compile(r'^(?P' + r'|'.join(_statistics_keys) + r')\s+(?P([0-9\.]+(,\s+)?)+)\s*(?P.*)')
+
 def _run_with_driver(self, driver, time_out_ms):
 output = self.run_single(driver, self.test_path(), time_out_ms)
 self._filter_output(output)
 if self.run_failed(output):
 return None
 
-return self.parse_output(output)
+current_metric = None
+results = []
+for line in re.split('\n', output.text):
+if not line:
+continue
 
+description_match = self._description_regex.match(line)
+metric_match = self._metrics_regex.match(line)
+score = self._score_regex.match(line)
+
+if description_match:
+self._description = description_match.group('description')
+elif metric_match:
+current_metric = metric_match.group('metric').replace(' ', '')
+elif score:
+key = score.group('key')
+if key == 'values' and results != None:
+values = [float(number) for number in score.group('value').split(', ')]
+results.append(PerfTestMetric(current_metric, score.group('unit'), values))
+else:
+results = None
+_log.error('ERROR: ' + line)
+
+return results
+
 def run_single(self, driver, test_path, time_out_ms, should_run_pixel_test=False):
 return driver.run_test(DriverInput(test_path, time_out_ms, image_hash=None, should_run_pixel_test=should_run_pixel_test), stop_when_done=False)
 
@@ -177,7 +205,8 @@
 
 return True
 
-def _should_ignore_line(self, regexps, line):
+@staticmethod
+def _should_ignore_line(regexps, line):
 if not line:
 return True
 for regexp in regexps:
@@ -191,9 +220,6 @@
 re.compile(r'^\[INFO:'),
 ]
 
-def _should_ignore_line_in_stderr(self, line):
-return self._should_ignore_line(self._lines_to_ignore_in_stderr, line)
-
 _lines_to_ignore_in_parser_result = [
 re.compile(r'^Running \d+ times$'),
 re.compile(r'^Ignoring warm-up '),
@@ -210,47 +236,12 @@
 re.compile(r'(?P.+): \[(?P(\d+(.\d+)?,\s+)*\d+(.\d+)?)\]'),
 ]
 
-def _should_ignore_line_in_parser_test_result(self, line):
-return self._should_ignore_line(self._lines_to_ignore_in_pa

[webkit-changes] [144361] trunk/Tools

[robert]

Title: [144361] trunk/Tools








Revision 144361
Author rob...@webkit.org
Date 2013-02-28 13:48:11 -0800 (Thu, 28 Feb 2013)


Log Message
Update my IRC nick

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (144360 => 144361)

--- trunk/Tools/ChangeLog	2013-02-28 21:45:58 UTC (rev 144360)
+++ trunk/Tools/ChangeLog	2013-02-28 21:48:11 UTC (rev 144361)
@@ -1,3 +1,11 @@
+2013-02-28  Robert Hogan  
+
+Update my IRC nick
+
+Unreviewed.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2013-02-28  Andras Becsi  
 
 [Qt] Enable thin archives before parsing the project files


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (144360 => 144361)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-02-28 21:45:58 UTC (rev 144360)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-02-28 21:48:11 UTC (rev 144361)
@@ -413,7 +413,7 @@
 Committer("Ravi Kasibhatla", "ravi.kasibha...@motorola.com", "kphanee"),
 Committer("Raymond Toy", ["r...@google.com", "r...@chromium.org"], "rtoy"),
 Committer("Renata Hodovan", "r...@webkit.org", "reni"),
-Committer("Robert Hogan", ["rob...@webkit.org", "rob...@roberthogan.net", "li...@roberthogan.net"], "mwenge"),
+Committer("Robert Hogan", ["rob...@webkit.org", "rob...@roberthogan.net", "li...@roberthogan.net"], "rhogan"),
 Committer("Robert Kroeger", "rjkro...@chromium.org", "rjkroege"),
 Committer("Roger Fong", "roger_f...@apple.com", "rfong"),
 Committer("Roland Steiner", "rolandstei...@chromium.org"),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144360] trunk

[jochen]

Title: [144360] trunk








Revision 144360
Author joc...@chromium.org
Date 2013-02-28 13:45:58 -0800 (Thu, 28 Feb 2013)


Log Message
Meta referrer isn't honored for window.open
https://bugs.webkit.org/show_bug.cgi?id=111076

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/referrer-policy-window-open.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::urlSelected): loadFrameRequest() will set the correct referrer
(WebCore::createWindow): This code is required for the inspector which doesn't set the referrer
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):

LayoutTests:

* http/tests/security/referrer-policy-window-open-expected.txt: Added.
* http/tests/security/referrer-policy-window-open.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/page/DOMWindow.cpp


Added Paths

trunk/LayoutTests/http/tests/security/referrer-policy-window-open-expected.txt
trunk/LayoutTests/http/tests/security/referrer-policy-window-open.html




Diff

Modified: trunk/LayoutTests/ChangeLog (144359 => 144360)

--- trunk/LayoutTests/ChangeLog	2013-02-28 21:37:47 UTC (rev 144359)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 21:45:58 UTC (rev 144360)
@@ -1,3 +1,13 @@
+2013-02-28  Jochen Eisinger  
+
+Meta referrer isn't honored for window.open
+https://bugs.webkit.org/show_bug.cgi?id=111076
+
+Reviewed by Adam Barth.
+
+* http/tests/security/referrer-policy-window-open-expected.txt: Added.
+* http/tests/security/referrer-policy-window-open.html: Added.
+
 2013-02-28  Kondapally Kalyan  
 
 [EFL][WebGL] Enable compositing/webgl/webgl-reflection.html.


Added: trunk/LayoutTests/http/tests/security/referrer-policy-window-open-expected.txt (0 => 144360)

--- trunk/LayoutTests/http/tests/security/referrer-policy-window-open-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/referrer-policy-window-open-expected.txt	2013-02-28 21:45:58 UTC (rev 144360)
@@ -0,0 +1,5 @@
+This test opens a new window. It passes, if the referrer is the origin only.
+
+HTTP Referer header is http://127.0.0.1:8000/
+Referrer is http://127.0.0.1:8000/
+


Added: trunk/LayoutTests/http/tests/security/referrer-policy-window-open.html (0 => 144360)

--- trunk/LayoutTests/http/tests/security/referrer-policy-window-open.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/referrer-policy-window-open.html	2013-02-28 21:45:58 UTC (rev 144360)
@@ -0,0 +1,34 @@
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+testRunner.setCanOpenWindows();
+}
+
+window.addEventListener("message", receiveMessage, false);
+
+function receiveMessage(evt) {
+if (evt.data == "done") {
+if (window.testRunner)
+testRunner.notifyDone();
+} else {
+document.getElementById("log").innerHTML += evt.data + "
";
+}
+}
+
+
+
+
+This test opens a new window. It passes, if the referrer is the origin
+only.
+
+
+
+
+window.open("resources/referrer-policy-postmessage.php");
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (144359 => 144360)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 21:37:47 UTC (rev 144359)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 21:45:58 UTC (rev 144360)
@@ -1,3 +1,18 @@
+2013-02-28  Jochen Eisinger  
+
+Meta referrer isn't honored for window.open
+https://bugs.webkit.org/show_bug.cgi?id=111076
+
+Reviewed by Adam Barth.
+
+Test: http/tests/security/referrer-policy-window-open.html
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::urlSelected): loadFrameRequest() will set the correct referrer
+(WebCore::createWindow): This code is required for the inspector which doesn't set the referrer
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::createWindow):
+
 2013-02-28  Bruno de Oliveira Abinader  
 
 [texmap] Remove redundant defines on TextureMapperGL


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (144359 => 144360)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2013-02-28 21:37:47 UTC (rev 144359)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2013-02-28 21:45:58 UTC (rev 144360)
@@ -311,8 +311,6 @@
 
 if (shouldSendReferrer == NeverSendReferrer)
 m_suppressOpenerInNewFrame = true;
-if (frameRequest.resourceRequest().httpReferrer().isEmpty())
-frameRequest.resourceRequest().setHTTPReferrer(outgoingReferrer());
 addHTTPOriginIfNeeded(frameRequest.resourceRequest(), outgoingOrigin());
 
 loadFrameRequest(frameRequest, lockHistory, lockBackForwardList, triggeringEvent, 0, shouldSendReferrer);
@@ -3349,7 +3347,9 @@
 
 // FIXME: Setting the referrer should be the caller's responsibility.
 FrameLoadRequest requestWithReferrer = request;
-requestWithReferrer.resourceRequest().setHTTPReferrer(openerFrame->loader(

[webkit-changes] [144359] trunk/Source/WebCore

[bruno . abinader]

Title: [144359] trunk/Source/WebCore








Revision 144359
Author bruno.abina...@basyskom.com
Date 2013-02-28 13:37:47 -0800 (Thu, 28 Feb 2013)


Log Message
[texmap] Remove redundant defines on TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=111090

Reviewed by Antonio Gomes.

driverSupportsSubImage() already uses OpenGL ES defines to return
correct support, thus no need for these additional defines.

No behavior changes, thus covered by existing tests.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144358 => 144359)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 21:35:15 UTC (rev 144358)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 21:37:47 UTC (rev 144359)
@@ -1,3 +1,18 @@
+2013-02-28  Bruno de Oliveira Abinader  
+
+[texmap] Remove redundant defines on TextureMapperGL
+https://bugs.webkit.org/show_bug.cgi?id=111090
+
+Reviewed by Antonio Gomes.
+
+driverSupportsSubImage() already uses OpenGL ES defines to return
+correct support, thus no need for these additional defines.
+
+No behavior changes, thus covered by existing tests.
+
+* platform/graphics/texmap/TextureMapperGL.cpp:
+(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
+
 2013-02-26  Zhenyao Mo  
 
 EXT_draw_buffers needs implementation


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (144358 => 144359)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2013-02-28 21:35:15 UTC (rev 144358)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2013-02-28 21:37:47 UTC (rev 144359)
@@ -639,22 +639,18 @@
 void BitmapTextureGL::updateContentsNoSwizzle(const void* srcData, const IntRect& targetRect, const IntPoint& sourceOffset, int bytesPerLine, unsigned bytesPerPixel, Platform3DObject glFormat)
 {
 m_context3D->bindTexture(GraphicsContext3D::TEXTURE_2D, m_id);
-#if !defined(TEXMAP_OPENGL_ES_2)
 if (driverSupportsSubImage()) { // For ES drivers that don't support sub-images.
 // Use the OpenGL sub-image extension, now that we know it's available.
 m_context3D->pixelStorei(GL_UNPACK_ROW_LENGTH, bytesPerLine / bytesPerPixel);
 m_context3D->pixelStorei(GL_UNPACK_SKIP_ROWS, sourceOffset.y());
 m_context3D->pixelStorei(GL_UNPACK_SKIP_PIXELS, sourceOffset.x());
 }
-#endif
 m_context3D->texSubImage2D(GraphicsContext3D::TEXTURE_2D, 0, targetRect.x(), targetRect.y(), targetRect.width(), targetRect.height(), glFormat, DEFAULT_TEXTURE_PIXEL_TRANSFER_TYPE, srcData);
-#if !defined(TEXMAP_OPENGL_ES_2)
 if (driverSupportsSubImage()) { // For ES drivers that don't support sub-images.
 m_context3D->pixelStorei(GL_UNPACK_ROW_LENGTH, 0);
 m_context3D->pixelStorei(GL_UNPACK_SKIP_ROWS, 0);
 m_context3D->pixelStorei(GL_UNPACK_SKIP_PIXELS, 0);
 }
-#endif
 }
 
 void BitmapTextureGL::updateContents(const void* srcData, const IntRect& targetRect, const IntPoint& sourceOffset, int bytesPerLine, UpdateContentsFlag updateContentsFlag)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144357] trunk/LayoutTests

[commit-queue]

Title: [144357] trunk/LayoutTests








Revision 144357
Author commit-qu...@webkit.org
Date 2013-02-28 13:32:11 -0800 (Thu, 28 Feb 2013)


Log Message
[EFL][WebGL] Enable compositing/webgl/webgl-reflection.html.
https://bugs.webkit.org/show_bug.cgi?id=110688

Patch by Kondapally Kalyan  on 2013-02-28
Reviewed by Laszlo Gombos.

This patch adds platform specific test expectation files for the
test and enables it for efl port.

* platform/efl/TestExpectations:
* platform/efl/compositing/webgl/webgl-reflection-expected.png: Added.
* platform/efl/compositing/webgl/webgl-reflection-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations


Added Paths

trunk/LayoutTests/platform/efl/compositing/webgl/webgl-reflection-expected.png
trunk/LayoutTests/platform/efl/compositing/webgl/webgl-reflection-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (144356 => 144357)

--- trunk/LayoutTests/ChangeLog	2013-02-28 21:31:21 UTC (rev 144356)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 21:32:11 UTC (rev 144357)
@@ -1,3 +1,17 @@
+2013-02-28  Kondapally Kalyan  
+
+[EFL][WebGL] Enable compositing/webgl/webgl-reflection.html.
+https://bugs.webkit.org/show_bug.cgi?id=110688
+
+Reviewed by Laszlo Gombos.
+
+This patch adds platform specific test expectation files for the
+test and enables it for efl port.
+
+* platform/efl/TestExpectations:
+* platform/efl/compositing/webgl/webgl-reflection-expected.png: Added.
+* platform/efl/compositing/webgl/webgl-reflection-expected.txt: Added.
+
 2013-02-28  Kent Tamura  
 
 REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator


Modified: trunk/LayoutTests/platform/efl/TestExpectations (144356 => 144357)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-02-28 21:31:21 UTC (rev 144356)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-02-28 21:32:11 UTC (rev 144357)
@@ -1713,7 +1713,6 @@
 # Rendering failure, also missing expected results:
 webkit.org/b/105093 compositing/webgl/webgl-background-color.html [ Skip ]
 webkit.org/b/105093 compositing/webgl/webgl-nonpremultiplied-blend.html [ Skip ]
-webkit.org/b/105093 compositing/webgl/webgl-reflection.html [ Skip ]
 
 # WebProcess timeouts
 webkit.org/b/102464 [ Debug ] fast/images/webgl-teximage2d.html [ Pass Timeout ]


Added: trunk/LayoutTests/platform/efl/compositing/webgl/webgl-reflection-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/efl/compositing/webgl/webgl-reflection-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/efl/compositing/webgl/webgl-reflection-expected.txt (0 => 144357)

--- trunk/LayoutTests/platform/efl/compositing/webgl/webgl-reflection-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/efl/compositing/webgl/webgl-reflection-expected.txt	2013-02-28 21:32:11 UTC (rev 144357)
@@ -0,0 +1,12 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x306
+  RenderBlock {HTML} at (0,0) size 800x306
+RenderBody {BODY} at (8,16) size 784x282
+  RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 311x17
+  text run at (0,0) width 311: "You should see a green triangle and its reflection."
+  RenderBlock (anonymous) at (0,34) size 784x248
+RenderText {#text} at (0,0) size 0x0
+layer at (28,70) size 244x204
+  RenderHTMLCanvas {CANVAS} at (20,20) size 244x204 [border: (2px solid #00)]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144356] trunk/Source/JavaScriptCore

[fpizlo]

Title: [144356] trunk/Source/_javascript_Core








Revision 144356
Author fpi...@apple.com
Date 2013-02-28 13:31:21 -0800 (Thu, 28 Feb 2013)


Log Message
CodeBlock::valueProfile() has a bogus assertion
https://bugs.webkit.org/show_bug.cgi?id=06


Reviewed by Mark Hahnenberg.

This was just a bad assertion: m_bytecodeOffset == -1 means that the value profile is constructed but not initialized.
ValueProfile constructs itself in a safe way; you can call any method you want on a constructed but not initialized
ValueProfile. CodeBlock first constructs all ValueProfiles (by growing the ValueProfile vector) and then initializes
their m_bytecodeOffset later. This is necessary because the initialization is linking bytecode instructions to their
ValueProfiles, so at that point we don't want the ValueProfile vector to resize, which implies that we want all of
them to already be constructed. A GC can happen during this phase, and the GC may want to walk all ValueProfiles.
This is safe, but one of the ValueProfile getters (CodeBlock::valueProfile()) was asserting that any value profile
you get has had its m_bytecodeOffset initialized. This need not be the case and nothing will go wrong if it isn't.

The solution is to remove the assertion, which I believe was put there to ensure that my m_valueProfiles refactoring
a long time ago was sound: it used to be that a ValueProfile with m_bytecodeOffset == -1 was an argument profile; now
all argument profiles are in m_argumentValueProfiles instead. I think it's safe to say that this refactoring was done
soundly since it was a long time ago. So we should kill the assertion - I don't see an easy way to make the assertion
sound with respect to the GC-during-CodeBlock-construction issue, and I don't believe that the assertion is buying us
anything at this point.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::valueProfile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (144355 => 144356)

--- trunk/Source/_javascript_Core/ChangeLog	2013-02-28 21:30:00 UTC (rev 144355)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-02-28 21:31:21 UTC (rev 144356)
@@ -1,3 +1,30 @@
+2013-02-28  Filip Pizlo  
+
+CodeBlock::valueProfile() has a bogus assertion
+https://bugs.webkit.org/show_bug.cgi?id=06
+
+
+Reviewed by Mark Hahnenberg.
+
+This was just a bad assertion: m_bytecodeOffset == -1 means that the value profile is constructed but not initialized.
+ValueProfile constructs itself in a safe way; you can call any method you want on a constructed but not initialized
+ValueProfile. CodeBlock first constructs all ValueProfiles (by growing the ValueProfile vector) and then initializes
+their m_bytecodeOffset later. This is necessary because the initialization is linking bytecode instructions to their
+ValueProfiles, so at that point we don't want the ValueProfile vector to resize, which implies that we want all of
+them to already be constructed. A GC can happen during this phase, and the GC may want to walk all ValueProfiles.
+This is safe, but one of the ValueProfile getters (CodeBlock::valueProfile()) was asserting that any value profile
+you get has had its m_bytecodeOffset initialized. This need not be the case and nothing will go wrong if it isn't.
+
+The solution is to remove the assertion, which I believe was put there to ensure that my m_valueProfiles refactoring
+a long time ago was sound: it used to be that a ValueProfile with m_bytecodeOffset == -1 was an argument profile; now
+all argument profiles are in m_argumentValueProfiles instead. I think it's safe to say that this refactoring was done
+soundly since it was a long time ago. So we should kill the assertion - I don't see an easy way to make the assertion
+sound with respect to the GC-during-CodeBlock-construction issue, and I don't believe that the assertion is buying us
+anything at this point.
+
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::valueProfile):
+
 2013-02-27  Filip Pizlo  
 
 DFG CFA should leave behind information in Edge that says if the Edge's type check is proven to succeed


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (144355 => 144356)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2013-02-28 21:30:00 UTC (rev 144355)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2013-02-28 21:31:21 UTC (rev 144356)
@@ -605,12 +605,7 @@
 }
 
 unsigned numberOfValueProfiles() { return m_valueProfiles.size(); }
-ValueProfile* valueProfile(int index)
-{
-ValueProfile* result = &m_valueProfiles[index];
-ASSERT(result->m_bytecodeOffset != -1);
-return result;
-}
+ValueProfile* valueProfile(int index) { return &m_v

[webkit-changes] [144355] trunk/Source/WebKit/blackberry

[mifenton]

Title: [144355] trunk/Source/WebKit/blackberry








Revision 144355
Author mifen...@rim.com
Date 2013-02-28 13:30:00 -0800 (Thu, 28 Feb 2013)


Log Message
[BlackBerry] Maintain the directionality of the selection after modifying the selection using key events.
https://bugs.webkit.org/show_bug.cgi?id=111078

Reviewed by Yong Li.

PR 295224.

When using the key navigation to modify the selection, reset the
directionality of the selection to the original to prevent
changing the anchor.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (144354 => 144355)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-02-28 21:08:39 UTC (rev 144354)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-02-28 21:30:00 UTC (rev 144355)
@@ -1,3 +1,21 @@
+2013-02-28  Mike Fenton  
+
+[BlackBerry] Maintain the directionality of the selection after modifying the selection using key events.
+https://bugs.webkit.org/show_bug.cgi?id=111078
+
+Reviewed by Yong Li.
+
+PR 295224.
+
+When using the key navigation to modify the selection, reset the
+directionality of the selection to the original to prevent
+changing the anchor.
+
+Reviewed Internally by Nima Ghanavatian.
+
+* WebKitSupport/SelectionHandler.cpp:
+(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
+
 2013-02-28  Lianghui Chen  
 
 [BlackBerry] Disable auto-filling password in forms when auto-form-filling is not enabled.


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (144354 => 144355)

--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2013-02-28 21:08:39 UTC (rev 144354)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2013-02-28 21:30:00 UTC (rev 144355)
@@ -439,15 +439,17 @@
 return false;
 
 unsigned character = 0;
+bool needToInvertDirection = false;
 if (startIsOutsideOfField) {
 character = extendSelectionToFieldBoundary(true /* isStartHandle */, relativeStart, newSelection);
-if (character) {
+if (character && controller->selection().isBaseFirst()) {
 // Invert the selection so that the cursor point is at the beginning.
 controller->setSelection(VisibleSelection(controller->selection().end(), controller->selection().start(), true /* isDirectional */));
+needToInvertDirection = true;
 }
 } else if (endIsOutsideOfField) {
 character = extendSelectionToFieldBoundary(false /* isStartHandle */, relativeEnd, newSelection);
-if (character) {
+if (character && !controller->selection().isBaseFirst()) {
 // Reset the selection so that the end is the edit point.
 controller->setSelection(VisibleSelection(controller->selection().start(), controller->selection().end(), true /* isDirectional */));
 }
@@ -463,6 +465,9 @@
 if (shouldExtendSelectionInDirection(controller->selection(), character))
 m_webPage->m_inputHandler->handleKeyboardInput(Platform::KeyboardEvent(character, Platform::KeyboardEvent::KeyDown, KEYMOD_SHIFT));
 
+if (needToInvertDirection)
+controller->setSelection(VisibleSelection(controller->selection().extent(), controller->selection().base(), true /* isDirectional */));
+
 // Send the selection changed in case this does not trigger a selection change to
 // ensure the caret position is accurate. This may be a duplicate event.
 selectionPositionChanged(true /* forceUpdateWithoutChange */);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144354] trunk/Source/WebCore

[ap]

Title: [144354] trunk/Source/WebCore








Revision 144354
Author a...@apple.com
Date 2013-02-28 13:08:39 -0800 (Thu, 28 Feb 2013)


Log Message
Create BlobRegistry through a strategy
https://bugs.webkit.org/show_bug.cgi?id=00

Chromium build fix.

* platform/network/BlobRegistry.cpp: Use destructor for chromium too.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/BlobRegistry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144353 => 144354)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 21:04:14 UTC (rev 144353)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 21:08:39 UTC (rev 144354)
@@ -3,6 +3,15 @@
 Create BlobRegistry through a strategy
 https://bugs.webkit.org/show_bug.cgi?id=00
 
+Chromium build fix.
+
+* platform/network/BlobRegistry.cpp: Use destructor for chromium too.
+
+2013-02-28  Alexey Proskuryakov  
+
+Create BlobRegistry through a strategy
+https://bugs.webkit.org/show_bug.cgi?id=00
+
 Reviewed by Sam Weinig.
 
 * CMakeLists.txt:


Modified: trunk/Source/WebCore/platform/network/BlobRegistry.cpp (144353 => 144354)

--- trunk/Source/WebCore/platform/network/BlobRegistry.cpp	2013-02-28 21:04:14 UTC (rev 144353)
+++ trunk/Source/WebCore/platform/network/BlobRegistry.cpp	2013-02-28 21:08:39 UTC (rev 144354)
@@ -33,10 +33,9 @@
 #include "PlatformStrategies.h"
 #include 
 
-#if !PLATFORM(CHROMIUM)
-
 namespace WebCore {
 
+#if !PLATFORM(CHROMIUM)
 BlobRegistry& blobRegistry()
 {
 ASSERT(isMainThread());
@@ -48,6 +47,7 @@
 #endif
 return instance;
 }
+#endif
 
 BlobRegistry::~BlobRegistry()
 {
@@ -56,4 +56,3 @@
 }
 
 #endif
-#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144353] trunk/Source/WebCore

[ap]

Title: [144353] trunk/Source/WebCore








Revision 144353
Author a...@apple.com
Date 2013-02-28 13:04:14 -0800 (Thu, 28 Feb 2013)


Log Message
Create BlobRegistry through a strategy
https://bugs.webkit.org/show_bug.cgi?id=00

Reviewed by Sam Weinig.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
Added BlobRegistry.cpp.

* WebCore.exp.in:
* loader/LoaderStrategy.cpp:
(WebCore::LoaderStrategy::createBlobRegistry):
* loader/LoaderStrategy.h:
Addxed a function to create BlobRegistry, with default implementation being
in-process WebKit1 one.

* platform/network/BlobData.h: Added ENABLE(BLOB).

* platform/network/BlobRegistry.cpp: Added. Moved singleton to a separate file.
* platform/network/BlobRegistry.h: Made destructor non-inline. Cleaned up includes.

* platform/network/BlobRegistryImpl.cpp:
* platform/network/BlobRegistryImpl.h:
Cleaned up includes, made functions that are only called through base class private.
Added ENABLE(BLOB).

* platform/network/BlobStorageData.h: Added ENABLE(BLOB).

* platform/network/FormData.cpp:
(WebCore::appendBlobResolved): Check blob registry type before upcasting. It's a
public function, and we should not depend on high level understanding of process
model to prove that the cast is safe.

* platform/network/ResourceHandle.cpp:
* platform/network/cf/FormDataStreamCFNet.cpp:
* platform/network/mac/ResourceHandleMac.mm:
Cleaned up includes.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/loader/LoaderStrategy.cpp
trunk/Source/WebCore/loader/LoaderStrategy.h
trunk/Source/WebCore/platform/network/BlobData.h
trunk/Source/WebCore/platform/network/BlobRegistry.h
trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp
trunk/Source/WebCore/platform/network/BlobRegistryImpl.h
trunk/Source/WebCore/platform/network/BlobStorageData.h
trunk/Source/WebCore/platform/network/FormData.cpp
trunk/Source/WebCore/platform/network/ResourceHandle.cpp
trunk/Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp
trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm


Added Paths

trunk/Source/WebCore/platform/network/BlobRegistry.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (144352 => 144353)

--- trunk/Source/WebCore/CMakeLists.txt	2013-02-28 20:59:15 UTC (rev 144352)
+++ trunk/Source/WebCore/CMakeLists.txt	2013-02-28 21:04:14 UTC (rev 144353)
@@ -2053,6 +2053,7 @@
 
 platform/network/AuthenticationChallengeBase.cpp
 platform/network/BlobData.cpp
+platform/network/BlobRegistry.cpp
 platform/network/BlobRegistryImpl.cpp
 platform/network/BlobResourceHandle.cpp
 platform/network/Credential.cpp


Modified: trunk/Source/WebCore/ChangeLog (144352 => 144353)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 20:59:15 UTC (rev 144352)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 21:04:14 UTC (rev 144353)
@@ -1,3 +1,49 @@
+2013-02-28  Alexey Proskuryakov  
+
+Create BlobRegistry through a strategy
+https://bugs.webkit.org/show_bug.cgi?id=00
+
+Reviewed by Sam Weinig.
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* Target.pri:
+* WebCore.gypi:
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.vcxproj/WebCore.vcxproj:
+* WebCore.vcxproj/WebCore.vcxproj.filters:
+* WebCore.xcodeproj/project.pbxproj:
+Added BlobRegistry.cpp.
+
+* WebCore.exp.in:
+* loader/LoaderStrategy.cpp:
+(WebCore::LoaderStrategy::createBlobRegistry):
+* loader/LoaderStrategy.h:
+Addxed a function to create BlobRegistry, with default implementation being
+in-process WebKit1 one.
+
+* platform/network/BlobData.h: Added ENABLE(BLOB).
+
+* platform/network/BlobRegistry.cpp: Added. Moved singleton to a separate file.
+* platform/network/BlobRegistry.h: Made destructor non-inline. Cleaned up includes.
+
+* platform/network/BlobRegistryImpl.cpp:
+* platform/network/BlobRegistryImpl.h:
+Cleaned up includes, made functions that are only called through base class private.
+Added ENABLE(BLOB).
+
+* platform/network/BlobStorageData.h: Added E

[webkit-changes] [144352] trunk

[tkent]

Title: [144352] trunk








Revision 144352
Author tk...@chromium.org
Date 2013-02-28 12:59:15 -0800 (Thu, 28 Feb 2013)


Log Message
REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
https://bugs.webkit.org/show_bug.cgi?id=110974

Reviewed by Kentaro Hara.

Source/WebCore:

Input elements with the multiple fields UI require flexible box
layout.
- If display:inline or display:inline-block is specified, we
  replace it with display:inline-flex.
- If display:block is specified, we replace it with
  display:flex.
- If other display value is specified, we use it as is, but it
  won't wrap inside an input element because we have
  display:inline-block for ::-webkit-calendar-pixker-indicaotor.

r144184 was incomplete. It avoided the wrapping issue, but it
didn't make spin buttons and calendar arrows right-aligned.

Tests: Update fast/forms/date/date-apparance-basic.html

* css/html.css:
(input::-webkit-calendar-picker-indicator):
Add display:inline-block in orde to avoid line-wrapping.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::customStyleForRenderer):
Move the code to BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer.
* html/InputType.cpp:
(WebCore::InputType::customStyleForRenderer): Added.
* html/InputType.h:
(InputType): Add customStyleForRenderer, and remove
shouldApplyLocaleDirection.
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer):
Moved the code from HTMLInputElement::customStyleForRenderer, and
add display property updatting code.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Add customStyleForRenderer, and remove shouldApplyLocaleDirection.

LayoutTests:

* fast/forms/date/date-appearance-basic-expected.txt:
* fast/forms/date/date-appearance-basic.html:
* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/date/date-appearance-basic-expected.txt
trunk/LayoutTests/fast/forms/date/date-appearance-basic.html
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css
trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp
trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/InputType.cpp
trunk/Source/WebCore/html/InputType.h




Diff

Modified: trunk/LayoutTests/ChangeLog (144351 => 144352)

--- trunk/LayoutTests/ChangeLog	2013-02-28 20:51:44 UTC (rev 144351)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 20:59:15 UTC (rev 144352)
@@ -1,3 +1,15 @@
+2013-02-28  Kent Tamura  
+
+REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
+https://bugs.webkit.org/show_bug.cgi?id=110974
+
+Reviewed by Kentaro Hara.
+
+* fast/forms/date/date-appearance-basic-expected.txt:
+* fast/forms/date/date-appearance-basic.html:
+* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
+* platform/chromium/TestExpectations:
+
 2013-02-28  Xianzhu Wang  
 
 Focus ring for a child layer is incorrectly offset by ancestor composited layer's position


Modified: trunk/LayoutTests/fast/forms/date/date-appearance-basic-expected.txt (144351 => 144352)

--- trunk/LayoutTests/fast/forms/date/date-appearance-basic-expected.txt	2013-02-28 20:51:44 UTC (rev 144351)
+++ trunk/LayoutTests/fast/forms/date/date-appearance-basic-expected.txt	2013-02-28 20:59:15 UTC (rev 144352)
@@ -10,3 +10,4 @@
 font-size with fixed input width:   
 Fixed input height:   
 -webkit-appearance:none: 
+display: none: inline: inline-block: block:table-cell:   


Modified: trunk/LayoutTests/fast/forms/date/date-appearance-basic.html (144351 => 144352)

--- trunk/LayoutTests/fast/forms/date/date-appearance-basic.html	2013-02-28 20:51:44 UTC (rev 144351)
+++ trunk/LayoutTests/fast/forms/date/date-appearance-basic.html	2013-02-28 20:59:15 UTC (rev 144352)
@@ -22,6 +22,11 @@
 Fixed input height: 
   
 -webkit-appearance:none: 
+display: none:
+inline:
+inline-block:
+block:
+table-cell: 
 
 
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144351 => 144352)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 20:51:44 UTC (rev 144351)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 20:59:15 UTC (rev 144352)
@@ -3993,6 +3993,9 @@
 webkit.org/b/98687 fast/css-generated-content/table-row-group-to-inline.html [ Failure ]
 webkit.org/b/104595 fast/css/empty-generated-content.

[webkit-changes] [144351] trunk/Source

[andersca]

Title: [144351] trunk/Source








Revision 144351
Author ander...@apple.com
Date 2013-02-28 12:51:44 -0800 (Thu, 28 Feb 2013)


Log Message
Implement more StorageAreaProxy member functions
https://bugs.webkit.org/show_bug.cgi?id=03

Reviewed by Sam Weinig.

Source/WebCore:

Export two more StorageMap symbols required by WebKit2.

* WebCore.exp.in:

Source/WebKit2:

* Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::securityOrigin):
* Shared/SecurityOriginData.h:
Add helper to create a WebCore::SecurityOrigin from a SecurityOriginData object.

* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::key):
Fill the storage map and call through to StorageMap::key.

(WebKit::StorageAreaProxy::contains):
Fill the storage map and call through to StorageMap::contains.

(WebKit::StorageAreaProxy::memoryBytesUsedByCache):
Return 0; this matches StorageAreaImpl.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/SecurityOriginData.cpp
trunk/Source/WebKit2/Shared/SecurityOriginData.h
trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp
trunk/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144350 => 144351)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 20:38:23 UTC (rev 144350)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 20:51:44 UTC (rev 144351)
@@ -1,3 +1,14 @@
+2013-02-28  Anders Carlsson  
+
+Implement more StorageAreaProxy member functions
+https://bugs.webkit.org/show_bug.cgi?id=03
+
+Reviewed by Sam Weinig.
+
+Export two more StorageMap symbols required by WebKit2.
+
+* WebCore.exp.in:
+
 2013-02-28  Xianzhu Wang  
 
 Focus ring for a child layer is incorrectly offset by ancestor composited layer's position


Modified: trunk/Source/WebCore/WebCore.exp.in (144350 => 144351)

--- trunk/Source/WebCore/WebCore.exp.in	2013-02-28 20:38:23 UTC (rev 144350)
+++ trunk/Source/WebCore/WebCore.exp.in	2013-02-28 20:51:44 UTC (rev 144351)
@@ -83,6 +83,7 @@
 __ZN7WebCore10ScrollView24windowResizerRectChangedEv
 __ZN7WebCore10ScrollView8addChildEN3WTF10PassRefPtrINS_6WidgetEEE
 __ZN7WebCore10StorageMap11importItemsERKN3WTF7HashMapINS1_6StringES3_NS1_10StringHashENS1_10HashTraitsIS3_EES6_EE
+__ZN7WebCore10StorageMap3keyEj
 __ZN7WebCore10StorageMap6createEj
 __ZN7WebCore10StorageMap7setItemERKN3WTF6StringES4_RS2_Rb
 __ZN7WebCore10deleteFileERKN3WTF6StringE
@@ -1188,6 +1189,7 @@
 __ZNK7WebCore10ScrollView18contentsToRootViewERKNS_8IntPointE
 __ZNK7WebCore10StorageMap6lengthEv
 __ZNK7WebCore10StorageMap7getItemERKN3WTF6StringE
+__ZNK7WebCore10StorageMap8containsERKN3WTF6StringE
 __ZNK7WebCore11FrameLoader10isCompleteEv
 __ZNK7WebCore11FrameLoader14cancelledErrorERKNS_15ResourceRequestE
 __ZNK7WebCore11FrameLoader14frameHasLoadedEv


Modified: trunk/Source/WebKit2/ChangeLog (144350 => 144351)

--- trunk/Source/WebKit2/ChangeLog	2013-02-28 20:38:23 UTC (rev 144350)
+++ trunk/Source/WebKit2/ChangeLog	2013-02-28 20:51:44 UTC (rev 144351)
@@ -1,3 +1,25 @@
+2013-02-28  Anders Carlsson  
+
+Implement more StorageAreaProxy member functions
+https://bugs.webkit.org/show_bug.cgi?id=03
+
+Reviewed by Sam Weinig.
+
+* Shared/SecurityOriginData.cpp:
+(WebKit::SecurityOriginData::securityOrigin):
+* Shared/SecurityOriginData.h:
+Add helper to create a WebCore::SecurityOrigin from a SecurityOriginData object.
+
+* WebProcess/Storage/StorageAreaProxy.cpp:
+(WebKit::StorageAreaProxy::key):
+Fill the storage map and call through to StorageMap::key.
+
+(WebKit::StorageAreaProxy::contains):
+Fill the storage map and call through to StorageMap::contains.
+
+(WebKit::StorageAreaProxy::memoryBytesUsedByCache):
+Return 0; this matches StorageAreaImpl.
+
 2013-02-28  Tim Horton  
 
 PDFPlugin: PDF orientation isn't respected when printing or print-previewing


Modified: trunk/Source/WebKit2/Shared/SecurityOriginData.cpp (144350 => 144351)

--- trunk/Source/WebKit2/Shared/SecurityOriginData.cpp	2013-02-28 20:38:23 UTC (rev 144350)
+++ trunk/Source/WebKit2/Shared/SecurityOriginData.cpp	2013-02-28 20:51:44 UTC (rev 144351)
@@ -46,6 +46,11 @@
 return securityOriginData;
 }
 
+PassRefPtr SecurityOriginData::securityOrigin() const
+{
+return SecurityOrigin::create(protocol, host, port);
+}
+
 void SecurityOriginData::encode(CoreIPC::ArgumentEncoder& encoder) const
 {
 encoder << protocol;


Modified: trunk/Source/WebKit2/Shared/SecurityOriginData.h (144350 => 144351)

--- trunk/Source/WebKit2/Shared/SecurityOriginData.h	2013-02-28 20:38:23 UTC (rev 144350)
+++ trunk/Source/WebKit2/Shared/SecurityOriginData.h	2013-02-28 20:51:44 UTC (rev 144351)
@@ -41,6 +41,7 @@
 
 struct SecurityOriginData {
 static SecurityOriginData fromSecurityOrigin(WebCore::SecurityOrigin*);
+PassRefPtr securi

[webkit-changes] [144349] trunk/LayoutTests

[junov]

Title: [144349] trunk/LayoutTests








Revision 144349
Author ju...@google.com
Date 2013-02-28 12:31:55 -0800 (Thu, 28 Feb 2013)


Log Message
Re-baselining expected pixels for fast/borders/border-radius-percent.html on linux
https://bugs.webkit.org/show_bug.cgi?id=110889

Unreviewed

* TestExpectations:
* platform/chromium-linux/fast/borders/border-radius-percent-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (144348 => 144349)

--- trunk/LayoutTests/ChangeLog	2013-02-28 20:18:00 UTC (rev 144348)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 20:31:55 UTC (rev 144349)
@@ -1,3 +1,13 @@
+2013-02-28  Justin Novosad  
+
+Re-baselining expected pixels for fast/borders/border-radius-percent.html on linux
+https://bugs.webkit.org/show_bug.cgi?id=110889
+
+Unreviewed
+
+* TestExpectations:
+* platform/chromium-linux/fast/borders/border-radius-percent-expected.png:
+
 2013-02-28  Stephen Chenney  
 
 [Chromium] Unreviewed gardening, update expectation


Modified: trunk/LayoutTests/TestExpectations (144348 => 144349)

--- trunk/LayoutTests/TestExpectations	2013-02-28 20:18:00 UTC (rev 144348)
+++ trunk/LayoutTests/TestExpectations	2013-02-28 20:31:55 UTC (rev 144349)
@@ -2,8 +2,5 @@
 #
 # See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
 
-# New test in need of pixel baselines
-webkit.org/b/110889 fast/borders/border-radius-percent.html [ ImageOnlyFailure Pass ]
-
 # pending functional patch and per-port verification
 webkit.org/b/109954 css3/line-break [ Skip ]


Modified: trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144348] tags/Safari-537.31.11/Source/WebCore

[lforschler]

Title: [144348] tags/Safari-537.31.11/Source/WebCore








Revision 144348
Author lforsch...@apple.com
Date 2013-02-28 12:18:00 -0800 (Thu, 28 Feb 2013)


Log Message
Merged r143684.  

Modified Paths

tags/Safari-537.31.11/Source/WebCore/ChangeLog
tags/Safari-537.31.11/Source/WebCore/html/HTMLPlugInImageElement.cpp




Diff

Modified: tags/Safari-537.31.11/Source/WebCore/ChangeLog (144347 => 144348)

--- tags/Safari-537.31.11/Source/WebCore/ChangeLog	2013-02-28 20:15:21 UTC (rev 144347)
+++ tags/Safari-537.31.11/Source/WebCore/ChangeLog	2013-02-28 20:18:00 UTC (rev 144348)
@@ -1,5 +1,18 @@
 2013-02-28  Lucas Forschler  
 
+Merge r143684
+
+2013-02-21  Dean Jackson  
+
+Followup commit for https://bugs.webkit.org/show_bug.cgi?id=110541
+from a comment by Jon Lee.
+
+* html/HTMLPlugInImageElement.cpp:
+(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Logic
+in conditional was unnecessarily complex.
+
+2013-02-28  Lucas Forschler  
+
 Merge r143680
 
 2013-02-21  Dean Jackson  


Modified: tags/Safari-537.31.11/Source/WebCore/html/HTMLPlugInImageElement.cpp (144347 => 144348)

--- tags/Safari-537.31.11/Source/WebCore/html/HTMLPlugInImageElement.cpp	2013-02-28 20:15:21 UTC (rev 144347)
+++ tags/Safari-537.31.11/Source/WebCore/html/HTMLPlugInImageElement.cpp	2013-02-28 20:18:00 UTC (rev 144348)
@@ -427,7 +427,7 @@
 LayoutRect rect = toRenderEmbeddedObject(renderer())->contentBoxRect();
 int width = rect.width();
 int height = rect.height();
-if (!width || !height || (width <= sizingTinyDimensionThreshold || height <= sizingTinyDimensionThreshold)) {
+if (width <= sizingTinyDimensionThreshold || height <= sizingTinyDimensionThreshold) {
 LOG(Plugins, "%p Plug-in is %dx%d, set to play", this, width, height);
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144347] tags/Safari-537.31.11/Source/WebCore

[lforschler]

Title: [144347] tags/Safari-537.31.11/Source/WebCore








Revision 144347
Author lforsch...@apple.com
Date 2013-02-28 12:15:21 -0800 (Thu, 28 Feb 2013)


Log Message
Merged r143680.  

Modified Paths

tags/Safari-537.31.11/Source/WebCore/ChangeLog
tags/Safari-537.31.11/Source/WebCore/html/HTMLPlugInImageElement.cpp
tags/Safari-537.31.11/Source/WebCore/html/HTMLPlugInImageElement.h




Diff

Modified: tags/Safari-537.31.11/Source/WebCore/ChangeLog (144346 => 144347)

--- tags/Safari-537.31.11/Source/WebCore/ChangeLog	2013-02-28 20:13:18 UTC (rev 144346)
+++ tags/Safari-537.31.11/Source/WebCore/ChangeLog	2013-02-28 20:15:21 UTC (rev 144347)
@@ -1,5 +1,35 @@
 2013-02-28  Lucas Forschler  
 
+Merge r143680
+
+2013-02-21  Dean Jackson  
+
+Better sizing model for Snapshotted plugins
+https://bugs.webkit.org/show_bug.cgi?id=110541
+
+Reviewed by Simon Fraser.
+
+Clarify the way we apply sizing rules to snapshotted plug-ins. In
+testing we've found that plug-ins smaller than 40px in either
+dimension should never be frozen. Also, larger plugins should
+be explicitly marked, because often they are the single dominant
+element on the page.
+
+As a drive-by, I removed the flag that indicated whether or not
+the label should show automatically. It wasn't being used. This is
+all determined from the shadow root and its CSS now.
+
+* html/HTMLPlugInImageElement.cpp:
+(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New values for size thresholds.
+(WebCore::HTMLPlugInImageElement::createRenderer): Remove call to setShouldShowSnapshotLabelAutomatically.
+(WebCore::classNameForShadowRoot): Remove logging and clearly assign sizing classes.
+(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): We don't need the page size any more.
+(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Use new constant names.
+* html/HTMLPlugInImageElement.h:
+(HTMLPlugInImageElement): Remove setShouldShowSnapshotLabelAutomatically.
+
+2013-02-28  Lucas Forschler  
+
 Merge r142958
 
 2013-02-14  Ryosuke Niwa  


Modified: tags/Safari-537.31.11/Source/WebCore/html/HTMLPlugInImageElement.cpp (144346 => 144347)

--- tags/Safari-537.31.11/Source/WebCore/html/HTMLPlugInImageElement.cpp	2013-02-28 20:13:18 UTC (rev 144346)
+++ tags/Safari-537.31.11/Source/WebCore/html/HTMLPlugInImageElement.cpp	2013-02-28 20:15:21 UTC (rev 144347)
@@ -53,13 +53,10 @@
 
 using namespace HTMLNames;
 
-static const int autoStartPlugInSizeDimensionThreshold = 1;
-static const int autoShowLabelSizeWidthThreshold = 400;
-static const int autoShowLabelSizeHeightThreshold = 300;
-
 static const int sizingTinyDimensionThreshold = 40;
 static const int sizingSmallWidthThreshold = 250;
-static const int sizingMediumWidthThreshold = 600;
+static const int sizingMediumWidthThreshold = 450;
+static const int sizingMediumHeightThreshold = 300;
 
 // This delay should not exceed the snapshot delay in PluginView.cpp
 static const double simulatedMouseClickTimerDelay = .75;
@@ -73,7 +70,6 @@
 , m_needsWidgetUpdate(!createdByParser)
 , m_shouldPreferPlugInsForImages(preferPlugInsForImagesOption == ShouldPreferPlugInsForImages)
 , m_needsDocumentActivationCallbacks(false)
-, m_shouldShowSnapshotLabelAutomatically(false)
 , m_simulatedMouseClickTimer(this, &HTMLPlugInImageElement::simulatedMouseClickTimerFired, simulatedMouseClickTimerDelay)
 , m_swapRendererTimer(this, &HTMLPlugInImageElement::swapRendererTimerFired)
 {
@@ -157,8 +153,6 @@
 if (displayState() == DisplayingSnapshot) {
 RenderSnapshottedPlugIn* renderSnapshottedPlugIn = new (arena) RenderSnapshottedPlugIn(this);
 renderSnapshottedPlugIn->updateSnapshot(m_snapshotImage);
-if (m_shouldShowSnapshotLabelAutomatically)
-renderSnapshottedPlugIn->setShouldShowLabelAutomatically();
 return renderSnapshottedPlugIn;
 }
 
@@ -300,34 +294,25 @@
 renderer()->repaint();
 }
 
-static AtomicString classNameForShadowRootSize(const IntSize& viewContentsSize, const Node* node)
+static AtomicString classNameForShadowRoot(const Node* node)
 {
 DEFINE_STATIC_LOCAL(const AtomicString, plugInTinySizeClassName, ("tiny", AtomicString::ConstructFromLiteral));
 DEFINE_STATIC_LOCAL(const AtomicString, plugInSmallSizeClassName, ("small", AtomicString::ConstructFromLiteral));
 DEFINE_STATIC_LOCAL(const AtomicString, plugInMediumSizeClassName, ("medium", AtomicString::ConstructFromLiteral));
 DEFINE_STATIC_LOCAL(const AtomicString, plugInLargeSizeClassName, ("large", AtomicString::ConstructFromLiteral));
 
-LayoutRect plugInClipRect = node->renderer()->absoluteClippedOverflowRect();
-LayoutRect viewContentsRect(LayoutPoint::zero(), LayoutSize(viewContentsSize));
-

[webkit-changes] [144346] trunk/Source/WTF

[oliver]

Title: [144346] trunk/Source/WTF








Revision 144346
Author oli...@apple.com
Date 2013-02-28 12:13:18 -0800 (Thu, 28 Feb 2013)


Log Message
Crash in JSC::MarkedBlock::FreeList JSC::MarkedBlock::sweepHelper
https://bugs.webkit.org/show_bug.cgi?id=111059

Reviewed by Ryosuke Niwa.

Sometimes C++'s implicit operator conversion rules suck.
Add explicit operator== and !=.

* wtf/FastMalloc.cpp:
(WTF::HardenedSLL::operator!=):
(WTF::HardenedSLL::operator==):
(HardenedSLL):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FastMalloc.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (144345 => 144346)

--- trunk/Source/WTF/ChangeLog	2013-02-28 20:09:59 UTC (rev 144345)
+++ trunk/Source/WTF/ChangeLog	2013-02-28 20:13:18 UTC (rev 144346)
@@ -1,3 +1,18 @@
+2013-02-28  Oliver Hunt  
+
+Crash in JSC::MarkedBlock::FreeList JSC::MarkedBlock::sweepHelper
+https://bugs.webkit.org/show_bug.cgi?id=111059
+
+Reviewed by Ryosuke Niwa.
+
+Sometimes C++'s implicit operator conversion rules suck.
+Add explicit operator== and !=.
+
+* wtf/FastMalloc.cpp:
+(WTF::HardenedSLL::operator!=):
+(WTF::HardenedSLL::operator==):
+(HardenedSLL):
+
 2013-02-28  Zeno Albisser  
 
 Enable DFG JIT for Qt on Mac


Modified: trunk/Source/WTF/wtf/FastMalloc.cpp (144345 => 144346)

--- trunk/Source/WTF/wtf/FastMalloc.cpp	2013-02-28 20:09:59 UTC (rev 144345)
+++ trunk/Source/WTF/wtf/FastMalloc.cpp	2013-02-28 20:13:18 UTC (rev 144346)
@@ -774,6 +774,9 @@
 typedef void* (HardenedSLL::*UnspecifiedBoolType);
 ALWAYS_INLINE operator UnspecifiedBoolType() const { return m_value ? &HardenedSLL::m_value : 0; }
 
+bool operator!=(const HardenedSLL& other) const { return m_value != other.m_value; }
+bool operator==(const HardenedSLL& other) const { return m_value == other.m_value; }
+
 private:
 void* m_value;
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144345] trunk/LayoutTests

[schenney]

Title: [144345] trunk/LayoutTests








Revision 144345
Author schen...@chromium.org
Date 2013-02-28 12:09:59 -0800 (Thu, 28 Feb 2013)


Log Message
[Chromium] Unreviewed gardening, update expectation

* platform/chromium/TestExpectations: Add Win modifier for compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
and remove modifiers for fast/forms/textarea/textarea-state-restore.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (144344 => 144345)

--- trunk/LayoutTests/ChangeLog	2013-02-28 19:59:23 UTC (rev 144344)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 20:09:59 UTC (rev 144345)
@@ -1,3 +1,10 @@
+2013-02-28  Stephen Chenney  
+
+[Chromium] Unreviewed gardening, update expectation
+
+* platform/chromium/TestExpectations: Add Win modifier for compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
+and remove modifiers for fast/forms/textarea/textarea-state-restore.html
+
 2013-02-28  Adam Barth  
 
 Remove these supressions now that we've reverted http://trac.webkit.org/changeset/144126.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144344 => 144345)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 19:59:23 UTC (rev 144344)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 20:09:59 UTC (rev 144345)
@@ -3650,8 +3650,7 @@
 
 webkit.org/b/90900 [ SnowLeopard Lion ] tables/mozilla_expected_failures/other/empty_cells.html [ Failure Pass ]
 
-webkit.org/b/90980 [ Android Linux Mac Debug ] fast/forms/textarea/textarea-state-restore.html [ Pass Timeout ]
-webkit.org/b/90980 [ Win ] fast/forms/textarea/textarea-state-restore.html [ Pass Timeout ]
+webkit.org/b/90980 fast/forms/textarea/textarea-state-restore.html [ Pass Failure Timeout ]
 
 webkit.org/b/91183 http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html [ Failure Pass ]
 webkit.org/b/91183 http/tests/w3c/webperf/approved/HighResolutionTime/test_cross_frame_start.html [ Failure Pass ]
@@ -4422,7 +4421,7 @@
 # Impl-side scrolling is broken for RTL. Causing impl-side scrollbar artifacts.
 crbug.com/175926 [ Linux ] compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html [ Failure ImageOnlyFailure ]
 crbug.com/175926 [ Linux ] compositing/rtl/rtl-iframe-absolute-overflow.html [ Failure ImageOnlyFailure ]
-crbug.com/175926 [ Linux ] compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ Failure ImageOnlyFailure ]
+crbug.com/175926 [ Linux Win ] compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ Failure ImageOnlyFailure ]
 crbug.com/175926 [ Linux Win ] compositing/rtl/rtl-iframe-fixed-overflow.html [ Failure ImageOnlyFailure ]
 crbug.com/175926 [ Linux ] platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled.html [ Failure ImageOnlyFailure ]
 crbug.com/175926 [ Linux ] platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow.html [ Failure ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144344] trunk/Source/WebCore

[hyatt]

Title: [144344] trunk/Source/WebCore








Revision 144344
Author hy...@apple.com
Date 2013-02-28 11:59:23 -0800 (Thu, 28 Feb 2013)


Log Message
Remove the quirk margin bits from RenderObject and put them back in RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=111089

Reviewed by Dan Bernstein.

This patch removes the marginBeforeQuirk and marginAfterQuirk bits from RenderObject
and puts them into RenderBlock instead. I also did some renaming and clean-up after
moving them, e.g., to hasMarginBeforeQuirk and hasMarginAfterQuirk.

Even though it's pretty irrelevant, I also made the code writing-mode-correct so that
the correct child margin quirk is propagated across differing writing mode
boundaries.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::marginBeforeEstimateForChild):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleAfterSideOfBlock):
(WebCore::RenderBlock::hasMarginBeforeQuirk):
(WebCore):
(WebCore::RenderBlock::hasMarginAfterQuirk):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::setHasMarginBeforeQuirk):
(WebCore::RenderBlock::setHasMarginAfterQuirk):
(RenderBlock):
(WebCore::RenderBlock::hasMarginBeforeQuirk):
(WebCore::RenderBlock::hasMarginAfterQuirk):
(MarginInfo):
(WebCore::RenderBlock::MarginInfo::setHasMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::setHasMarginAfterQuirk):
(WebCore::RenderBlock::MarginInfo::hasMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::hasMarginAfterQuirk):
* rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
* rendering/style/RenderStyle.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/style/RenderStyle.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (144343 => 144344)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 19:55:23 UTC (rev 144343)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 19:59:23 UTC (rev 144344)
@@ -1,3 +1,46 @@
+2013-02-28  David Hyatt  
+
+Remove the quirk margin bits from RenderObject and put them back in RenderBlock.
+https://bugs.webkit.org/show_bug.cgi?id=111089
+
+Reviewed by Dan Bernstein.
+
+This patch removes the marginBeforeQuirk and marginAfterQuirk bits from RenderObject
+and puts them into RenderBlock instead. I also did some renaming and clean-up after
+moving them, e.g., to hasMarginBeforeQuirk and hasMarginAfterQuirk.
+
+Even though it's pretty irrelevant, I also made the code writing-mode-correct so that
+the correct child margin quirk is propagated across differing writing mode
+boundaries.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::MarginInfo::MarginInfo):
+(WebCore::RenderBlock::RenderBlock):
+(WebCore::RenderBlock::layoutBlock):
+(WebCore::RenderBlock::collapseMargins):
+(WebCore::RenderBlock::marginBeforeEstimateForChild):
+(WebCore::RenderBlock::setCollapsedBottomMargin):
+(WebCore::RenderBlock::handleAfterSideOfBlock):
+(WebCore::RenderBlock::hasMarginBeforeQuirk):
+(WebCore):
+(WebCore::RenderBlock::hasMarginAfterQuirk):
+* rendering/RenderBlock.h:
+(WebCore::RenderBlock::setHasMarginBeforeQuirk):
+(WebCore::RenderBlock::setHasMarginAfterQuirk):
+(RenderBlock):
+(WebCore::RenderBlock::hasMarginBeforeQuirk):
+(WebCore::RenderBlock::hasMarginAfterQuirk):
+(MarginInfo):
+(WebCore::RenderBlock::MarginInfo::setHasMarginBeforeQuirk):
+(WebCore::RenderBlock::MarginInfo::setHasMarginAfterQuirk):
+(WebCore::RenderBlock::MarginInfo::hasMarginBeforeQuirk):
+(WebCore::RenderBlock::MarginInfo::hasMarginAfterQuirk):
+* rendering/RenderObject.h:
+(RenderObject):
+(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
+(RenderObjectBitfields):
+* rendering/style/RenderStyle.h:
+
 2013-02-28  Sheriff Bot  
 
 Unreviewed, rolling out r144126 and r144176.


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (144343 => 144344)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2013-02-28 19:55:23 UTC (rev 144343)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2013-02-28 19:59:23 UTC (rev 144344)
@@ -167,8 +167,8 @@
 RenderBlock::MarginInfo::MarginInfo(RenderBlock* block, LayoutUnit beforeBorderPadding, LayoutUnit afterBorderPadding)
 : m_atBeforeSideOfBlock(true)
 , m_atAfterSideOfBlock(false)
-, m_marginBeforeQuirk(false)
-, m_marginAfterQuirk(false)
+, m_hasMarginBeforeQuirk(false)
+, m_hasMarginA

[webkit-changes] [144343] trunk/LayoutTests

[abarth]

Title: [144343] trunk/LayoutTests








Revision 144343
Author aba...@webkit.org
Date 2013-02-28 11:55:23 -0800 (Thu, 28 Feb 2013)


Log Message
Remove these supressions now that we've reverted http://trac.webkit.org/changeset/144126.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (144342 => 144343)

--- trunk/LayoutTests/ChangeLog	2013-02-28 19:48:03 UTC (rev 144342)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 19:55:23 UTC (rev 144343)
@@ -1,3 +1,9 @@
+2013-02-28  Adam Barth  
+
+Remove these supressions now that we've reverted http://trac.webkit.org/changeset/144126.
+
+* platform/chromium/TestExpectations:
+
 2013-02-28  Sheriff Bot  
 
 Unreviewed, rolling out r144126 and r144176.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144342 => 144343)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 19:48:03 UTC (rev 144342)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-28 19:55:23 UTC (rev 144343)
@@ -3214,10 +3214,7 @@
 
 webkit.org/b/81697 fast/notifications/notifications-check-permission.html [ Failure ]
 webkit.org/b/81697 fast/notifications/notifications-without-permission.html [ Failure ]
-# webkit.org/b/81697 fast/notifications/notifications-request-permission.html [ Failure ]
-# Failing since r144126, please uncomment the line above before removing these.
-webkit.org/b/110956 fast/notifications/notifications-request-permission.html [ Pass Crash Failure ]
-webkit.org/b/110956 fast/notifications/notifications-request-permission-optional.html [ Pass Crash ]
+webkit.org/b/81697 fast/notifications/notifications-request-permission.html [ Failure ]
 
 webkit.org/b/81732 fast/js/integer-division-neg2tothe32-by-neg1.html [ Crash Pass ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144342] tags/Safari-537.31.11/Source/WebKit2

[lforschler]

Title: [144342] tags/Safari-537.31.11/Source/WebKit2








Revision 144342
Author lforsch...@apple.com
Date 2013-02-28 11:48:03 -0800 (Thu, 28 Feb 2013)


Log Message
Merged r144217.  

Modified Paths

tags/Safari-537.31.11/Source/WebKit2/ChangeLog
tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist
tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist
tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist
tags/Safari-537.31.11/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
tags/Safari-537.31.11/Source/WebKit2/WebProcess/EntryPoint/mac/LegacyProcess/Info.plist
tags/Safari-537.31.11/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist
tags/Safari-537.31.11/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist




Diff

Modified: tags/Safari-537.31.11/Source/WebKit2/ChangeLog (144341 => 144342)

--- tags/Safari-537.31.11/Source/WebKit2/ChangeLog	2013-02-28 19:46:28 UTC (rev 144341)
+++ tags/Safari-537.31.11/Source/WebKit2/ChangeLog	2013-02-28 19:48:03 UTC (rev 144342)
@@ -1,5 +1,31 @@
 2013-02-28  Lucas Forschler  
 
+Merge r144217
+
+2013-02-27  Sam Weinig  
+
+REGRESSION: Loading flash switches to discrete graphics, 100 MB on membuster
+
+
+Reviewed by Dan Bernstein.
+
+Due the change in CFBundleIdentifier, the WebProcess and PluginProcess were
+unnecessarily muxing (they used to be whitelisted by OpenGL) to the discrete
+GPU.
+
+* PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
+* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
+* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
+* WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
+* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
+* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
+Add NSSupportsAutomaticGraphicsSwitching YES.
+
+* WebKit2.xcodeproj/project.pbxproj:
+Re-add the PluginService.32-64.Info.plist plist to the project file.
+
+2013-02-28  Lucas Forschler  
+
 Merge r143543
 
 2013-02-20  Mark Rowe  


Modified: tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist (144341 => 144342)

--- tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist	2013-02-28 19:46:28 UTC (rev 144341)
+++ tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist	2013-02-28 19:48:03 UTC (rev 144342)
@@ -28,5 +28,7 @@
 	NSApplication
 	WebKitEntryPoint
 	PluginProcessMain
+	NSSupportsAutomaticGraphicsSwitching
+	
 
 


Modified: tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist (144341 => 144342)

--- tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist	2013-02-28 19:46:28 UTC (rev 144341)
+++ tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist	2013-02-28 19:48:03 UTC (rev 144342)
@@ -30,6 +30,8 @@
 	PluginServiceInitializer
 	LSUIElement
 	
+	NSSupportsAutomaticGraphicsSwitching
+	
 	XPCService
 	
 		ServiceType


Modified: tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist (144341 => 144342)

--- tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist	2013-02-28 19:46:28 UTC (rev 144341)
+++ tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist	2013-02-28 19:48:03 UTC (rev 144342)
@@ -30,6 +30,8 @@
 	PluginServiceInitializer
 	LSUIElement
 	
+	NSSupportsAutomaticGraphicsSwitching
+	
 	XPCService
 	
 		ServiceType


Modified: tags/Safari-537.31.11/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (144341 => 144342)

--- tags/Safari-537.31.11/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2013-02-28 19:46:28 UTC (rev 144341)
+++ tags/Safari-537.31.11/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2013-02-28 19:48:03 UTC (rev 144342)
@@ -2248,8 +2248,6 @@
 		BC8283AB16B4BEAD00A278FE /* NetworkService.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = NetworkService.xcconfig; sourceTree = ""; };
 		BC8283B116B4BF7700A278FE /* com.apple.WebKit.Networking.xpc */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = com.apple.WebKit.Networking.xpc; sourceTree = BUILT_PRODUCTS_DIR; };
 		BC8283C516B4BFA800A278FE /* com.apple.WebKit.Networking.Development.xpc */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; include

[webkit-changes] [144341] trunk

[commit-queue]

Title: [144341] trunk








Revision 144341
Author commit-qu...@webkit.org
Date 2013-02-28 11:46:28 -0800 (Thu, 28 Feb 2013)


Log Message
Unreviewed, rolling out r144126 and r144176.
http://trac.webkit.org/changeset/144126
http://trac.webkit.org/changeset/144176
https://bugs.webkit.org/show_bug.cgi?id=111096

Caused fast/notifications/notifications-request-
permission.html to crash (Requested by abarth on #webkit).

Patch by Sheriff Bot  on 2013-02-28

Source/WebCore:

* GNUmakefile.list.am:
* Modules/notifications/Notification.h:
(Notification):
* Modules/notifications/Notification.idl:
* Target.pri:
* UseJSC.cmake:
* UseV8.cmake:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSNotificationCustom.cpp: Added.
(WebCore):
(WebCore::JSNotification::requestPermission):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/v8/custom/V8NotificationCustom.cpp: Added.
(WebCore):
(WebCore::V8Notification::requestPermissionMethodCustom):

LayoutTests:

* fast/notifications/notifications-request-permission-optional-expected.txt: Removed.
* fast/notifications/notifications-request-permission-optional.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Modules/notifications/Notification.h
trunk/Source/WebCore/Modules/notifications/Notification.idl
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/UseJSC.cmake
trunk/Source/WebCore/UseV8.cmake
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp


Added Paths

trunk/Source/WebCore/bindings/js/JSNotificationCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8NotificationCustom.cpp


Removed Paths

trunk/LayoutTests/fast/notifications/notifications-request-permission-optional-expected.txt
trunk/LayoutTests/fast/notifications/notifications-request-permission-optional.html




Diff

Modified: trunk/LayoutTests/ChangeLog (144340 => 144341)

--- trunk/LayoutTests/ChangeLog	2013-02-28 19:45:17 UTC (rev 144340)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 19:46:28 UTC (rev 144341)
@@ -1,3 +1,16 @@
+2013-02-28  Sheriff Bot  
+
+Unreviewed, rolling out r144126 and r144176.
+http://trac.webkit.org/changeset/144126
+http://trac.webkit.org/changeset/144176
+https://bugs.webkit.org/show_bug.cgi?id=111096
+
+Caused fast/notifications/notifications-request-
+permission.html to crash (Requested by abarth on #webkit).
+
+* fast/notifications/notifications-request-permission-optional-expected.txt: Removed.
+* fast/notifications/notifications-request-permission-optional.html: Removed.
+
 2013-02-28  Nate Chapin  
 
 Test for https://bugs.webkit.org/show_bug.cgi?id=110482


Deleted: trunk/LayoutTests/fast/notifications/notifications-request-permission-optional-expected.txt (144340 => 144341)

--- trunk/LayoutTests/fast/notifications/notifications-request-permission-optional-expected.txt	2013-02-28 19:45:17 UTC (rev 144340)
+++ trunk/LayoutTests/fast/notifications/notifications-request-permission-optional-expected.txt	2013-02-28 19:46:28 UTC (rev 144341)
@@ -1,6 +0,0 @@
-PASS window.webkitNotifications is not undefined
-PASS window.webkitNotifications.requestPermission() did not throw exception.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: trunk/LayoutTests/fast/notifications/notifications-request-permission-optional.html (144340 => 144341)

--- trunk/LayoutTests/fast/notifications/notifications-request-permission-optional.html	2013-02-28 19:45:17 UTC (rev 144340)
+++ trunk/LayoutTests/fast/notifications/notifications-request-permission-optional.html	2013-02-28 19:46:28 UTC (rev 144341)
@@ -1,11 +0,0 @@
-
-
-
-
-shouldNotBe('window.webkitNotifications', 'undefined');
-shouldNotThrow('window.webkitNotifications.requestPermission()');
-
-

[webkit-changes] [144340] trunk/Source/JavaScriptCore

[fpizlo]

Title: [144340] trunk/Source/_javascript_Core








Revision 144340
Author fpi...@apple.com
Date 2013-02-28 11:45:17 -0800 (Thu, 28 Feb 2013)


Log Message
DFG CFA should leave behind information in Edge that says if the Edge's type check is proven to succeed
https://bugs.webkit.org/show_bug.cgi?id=110840

Reviewed by Mark Hahnenberg.

This doesn't add any observable functionality to the compiler, yet. But it does give
every phase that runs after CFA the ability to know, in O(1) time, whether an edge
will need to execute a type check.

* dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::filterEdgeByUse):
(JSC::DFG::AbstractState::filterByType):
* dfg/DFGCommon.cpp:
(WTF):
(WTF::printInternal):
* dfg/DFGCommon.h:
(JSC::DFG::isProved):
(DFG):
(JSC::DFG::proofStatusForIsProved):
(WTF):
* dfg/DFGEdge.cpp:
(JSC::DFG::Edge::dump):
* dfg/DFGEdge.h:
(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::setNode):
(JSC::DFG::Edge::useKindUnchecked):
(JSC::DFG::Edge::setUseKind):
(Edge):
(JSC::DFG::Edge::proofStatusUnchecked):
(JSC::DFG::Edge::proofStatus):
(JSC::DFG::Edge::setProofStatus):
(JSC::DFG::Edge::isProved):
(JSC::DFG::Edge::needsCheck):
(JSC::DFG::Edge::shift):
(JSC::DFG::Edge::makeWord):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractState.h
trunk/Source/_javascript_Core/dfg/DFGCommon.cpp
trunk/Source/_javascript_Core/dfg/DFGCommon.h
trunk/Source/_javascript_Core/dfg/DFGEdge.cpp
trunk/Source/_javascript_Core/dfg/DFGEdge.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (144339 => 144340)

--- trunk/Source/_javascript_Core/ChangeLog	2013-02-28 19:43:57 UTC (rev 144339)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-02-28 19:45:17 UTC (rev 144340)
@@ -1,3 +1,41 @@
+2013-02-27  Filip Pizlo  
+
+DFG CFA should leave behind information in Edge that says if the Edge's type check is proven to succeed
+https://bugs.webkit.org/show_bug.cgi?id=110840
+
+Reviewed by Mark Hahnenberg.
+
+This doesn't add any observable functionality to the compiler, yet. But it does give
+every phase that runs after CFA the ability to know, in O(1) time, whether an edge
+will need to execute a type check.
+
+* dfg/DFGAbstractState.h:
+(JSC::DFG::AbstractState::filterEdgeByUse):
+(JSC::DFG::AbstractState::filterByType):
+* dfg/DFGCommon.cpp:
+(WTF):
+(WTF::printInternal):
+* dfg/DFGCommon.h:
+(JSC::DFG::isProved):
+(DFG):
+(JSC::DFG::proofStatusForIsProved):
+(WTF):
+* dfg/DFGEdge.cpp:
+(JSC::DFG::Edge::dump):
+* dfg/DFGEdge.h:
+(JSC::DFG::Edge::Edge):
+(JSC::DFG::Edge::setNode):
+(JSC::DFG::Edge::useKindUnchecked):
+(JSC::DFG::Edge::setUseKind):
+(Edge):
+(JSC::DFG::Edge::proofStatusUnchecked):
+(JSC::DFG::Edge::proofStatus):
+(JSC::DFG::Edge::setProofStatus):
+(JSC::DFG::Edge::isProved):
+(JSC::DFG::Edge::needsCheck):
+(JSC::DFG::Edge::shift):
+(JSC::DFG::Edge::makeWord):
+
 2013-02-28  Simon Hausmann  
 
 [Qt][Mac] Fix massive parallel builds


Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.h (144339 => 144340)

--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.h	2013-02-28 19:43:57 UTC (rev 144339)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.h	2013-02-28 19:45:17 UTC (rev 144340)
@@ -183,7 +183,7 @@
 void executeEdges(Node*);
 void executeEdges(unsigned indexInBlock);
 
-ALWAYS_INLINE void filterEdgeByUse(Node* node, Edge edge)
+ALWAYS_INLINE void filterEdgeByUse(Node* node, Edge& edge)
 {
 #if !ASSERT_DISABLED
 switch (edge.useKind()) {
@@ -197,7 +197,7 @@
 }
 #endif // !ASSERT_DISABLED
 
-filterByType(node, edge.node(), typeFilterFor(edge.useKind()));
+filterByType(node, edge, typeFilterFor(edge.useKind()));
 }
 
 // Abstractly execute the effects of the given node. This changes the abstract
@@ -260,11 +260,15 @@
 return true;
 }
 
-ALWAYS_INLINE void filterByType(Node* node, Node* child, SpeculatedType type)
+ALWAYS_INLINE void filterByType(Node* node, Edge& edge, SpeculatedType type)
 {
-AbstractValue& value = forNode(child);
-if (value.m_type & ~type)
+AbstractValue& value = forNode(edge);
+if (value.m_type & ~type) {
 node->setCanExit(true);
+edge.setProofStatus(NeedsCheck);
+} else
+edge.setProofStatus(IsProved);
+
 value.filter(type);
 }
 


Modified: trunk/Source/_javascript_Core/dfg/DFGCommon.cpp (144339 => 144340)

--- trunk/Source/_javascript_Core/dfg/DFGCommon.cpp	2013-02-28 19:43:57 UTC (rev 144339)
+++ trunk/Source/_javascript_Core/dfg/DFGCommon.cpp	2013-02-28 19:45:17 UTC (rev 144340)
@@ -41,16 +41,18 @@
 
 namespace WTF {
 
-void printInternal(PrintStrea

[webkit-changes] [144339] tags/Safari-537.31.11/Source/WebKit2

[lforschler]

Title: [144339] tags/Safari-537.31.11/Source/WebKit2








Revision 144339
Author lforsch...@apple.com
Date 2013-02-28 11:43:57 -0800 (Thu, 28 Feb 2013)


Log Message
Merged r144217.  

Modified Paths

tags/Safari-537.31.11/Source/WebKit2/ChangeLog
tags/Safari-537.31.11/Source/WebKit2/Configurations/PluginService.32.xcconfig
tags/Safari-537.31.11/Source/WebKit2/Configurations/PluginService.64.xcconfig


Added Paths

tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist


Removed Paths

tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist
tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist




Diff

Modified: tags/Safari-537.31.11/Source/WebKit2/ChangeLog (144338 => 144339)

--- tags/Safari-537.31.11/Source/WebKit2/ChangeLog	2013-02-28 19:40:02 UTC (rev 144338)
+++ tags/Safari-537.31.11/Source/WebKit2/ChangeLog	2013-02-28 19:43:57 UTC (rev 144339)
@@ -1,3 +1,21 @@
+2013-02-28  Lucas Forschler  
+
+Merge r143543
+
+2013-02-20  Mark Rowe  
+
+ Remove duplication between 32- and 64-bit PluginService plists.
+
+Reviewed by Dan Bernstein.
+
+The only difference between the plists was the CFBundleIdentifier. Since the values are the
+same as the product name, we can just use the value of the PRODUCT_NAME configuration setting.
+
+* Configurations/PluginService.32.xcconfig:
+* Configurations/PluginService.64.xcconfig:
+* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Renamed from Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist.
+* PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist: Removed.
+
 2013-02-26  Lucas Forschler  
 
 Merge r144091


Modified: tags/Safari-537.31.11/Source/WebKit2/Configurations/PluginService.32.xcconfig (144338 => 144339)

--- tags/Safari-537.31.11/Source/WebKit2/Configurations/PluginService.32.xcconfig	2013-02-28 19:40:02 UTC (rev 144338)
+++ tags/Safari-537.31.11/Source/WebKit2/Configurations/PluginService.32.xcconfig	2013-02-28 19:43:57 UTC (rev 144339)
@@ -25,7 +25,7 @@
 
 ARCHS = i386;
 PRODUCT_NAME = com.apple.WebKit.Plugin.32;
-INFOPLIST_FILE = PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist;
+INFOPLIST_FILE = PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist;
 
 // Since this service is only used in production builds, in debug and release builds
 // we don't link against WebKit2, to avoid linking errors due to not having a WebKit2


Modified: tags/Safari-537.31.11/Source/WebKit2/Configurations/PluginService.64.xcconfig (144338 => 144339)

--- tags/Safari-537.31.11/Source/WebKit2/Configurations/PluginService.64.xcconfig	2013-02-28 19:40:02 UTC (rev 144338)
+++ tags/Safari-537.31.11/Source/WebKit2/Configurations/PluginService.64.xcconfig	2013-02-28 19:43:57 UTC (rev 144339)
@@ -25,7 +25,7 @@
 
 ARCHS = x86_64;
 PRODUCT_NAME = com.apple.WebKit.Plugin.64;
-INFOPLIST_FILE = PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist;
+INFOPLIST_FILE = PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist;
 
 // Since this service is only used in production builds, in debug and release builds
 // we don't link against WebKit2, to avoid linking errors due to not having a WebKit2


Deleted: tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist (144338 => 144339)

--- tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist	2013-02-28 19:40:02 UTC (rev 144338)
+++ tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist	2013-02-28 19:43:57 UTC (rev 144339)
@@ -1,50 +0,0 @@
-
-
-
-
-	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2013 Apple Inc.
-	CFBundleDevelopmentRegion
-	English
-	CFBundleExecutable
-	${EXECUTABLE_NAME}
-	CFBundleIdentifier
-	com.apple.WebKit.Plugin.32
-	CFBundleInfoDictionaryVersion
-	6.0
-	CFBundleName
-	${PRODUCT_NAME}
-	CFBundlePackageType
-	XPC!
-	CFBundleShortVersionString
-	${SHORT_VERSION_STRING}
-	CFBundleSignature
-	
-	CFBundleVersion
-	${BUNDLE_VERSION}
-	LSFileQuarantineEnabled
-	
-	NSPrincipalClass
-	NSApplication
-	WebKitEntryPoint
-	PluginServiceInitializer
-	LSUIElement
-	
-	XPCService
-	
-		ServiceType
-		Application
-		RunLoopType
-		_NSApplicationMain
-		JoinExistingSession
-		
-		_MultipleInstances
-		
-		EnvironmentVariables
-		
-			DYLD_INSERT_LIBRARIES
-			$(WEBKIT2_FRAMEWORKS_DIR)/WebKit2.framework/PluginProcess.app/Contents/MacOS/PluginProcessShim.dylib
-		
-	
-
-


Copied: tags/Safari-537.31.11/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist (from rev 143543, trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-6

[webkit-changes] [144338] trunk

[japhet]

Title: [144338] trunk








Revision 144338
Author jap...@chromium.org
Date 2013-02-28 11:40:02 -0800 (Thu, 28 Feb 2013)


Log Message
Source/WebCore: Crash in CachedRawResource::responseReceived().
https://bugs.webkit.org/show_bug.cgi?id=110482

Reviewed by Adam Barth.

Test: http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html

* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::responseReceived):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=110482

Reviewed by Adam Barth.

* http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedRawResource.cpp


Added Paths

trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt
trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
trunk/LayoutTests/platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (144337 => 144338)

--- trunk/LayoutTests/ChangeLog	2013-02-28 19:37:22 UTC (rev 144337)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 19:40:02 UTC (rev 144338)
@@ -1,3 +1,13 @@
+2013-02-28  Nate Chapin  
+
+Test for https://bugs.webkit.org/show_bug.cgi?id=110482
+
+Reviewed by Adam Barth.
+
+* http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.
+* http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html: Added.
+* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.
+
 2013-02-28  Chris Fleizach  
 
 WebSpeech: support the boundary event


Added: trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt (0 => 144338)

--- trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt	2013-02-28 19:40:02 UTC (rev 144338)
@@ -0,0 +1,2 @@
+CONSOLE MESSAGE: Refused to display 'http://127.0.0.1:8000/security/XFrameOptions/resources/x-frame-options-deny.cgi' in a frame because it set 'X-Frame-Options' to 'deny'.
+Test that two main resources pointing to the same url that are canceled within didReceiveResponse() don't cause us to crash.  


Added: trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html (0 => 144338)

--- trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html	2013-02-28 19:40:02 UTC (rev 144338)
@@ -0,0 +1,14 @@
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+
+Test that two main resources pointing to the same url that are canceled within didReceiveResponse() don't cause us to crash.
+
+
+


Added: trunk/LayoutTests/platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt (0 => 144338)

--- trunk/LayoutTests/platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt	2013-02-28 19:40:02 UTC (rev 144338)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: Refused to display 'http://127.0.0.1:8000/security/XFrameOptions/resources/x-frame-options-deny.cgi' in a frame because it set 'X-Frame-Options' to 'deny'.
+CONSOLE MESSAGE: Refused to display 'http://127.0.0.1:8000/security/XFrameOptions/resources/x-frame-options-deny.cgi' in a frame because it set 'X-Frame-Options' to 'deny'.
+Test that two main resources pointing to the same url that are canceled within didReceiveResponse() don't cause us to crash.  


Modified: trunk/Source/WebCore/ChangeLog (144337 => 144338)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 19:37:22 UTC (rev 144337)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 19:40:02 UTC (rev 144338)
@@ -1,3 +1,15 @@
+2013-02-28  Nate Chapin  
+
+Crash in CachedRawResource::responseReceived().
+https://bugs.webkit.org/show_bug.cgi?id=110482
+
+Reviewed by Adam Barth.
+
+Test: http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
+
+* loader/cache/CachedRawResource.cpp:
+(WebCore::CachedRawResource::responseReceived):
+
 2013-02-28  Eric Carlson  
 
 [Mac] use HAVE

[webkit-changes] [144337] trunk/Source/WTF

[zeno . albisser]

Title: [144337] trunk/Source/WTF








Revision 144337
Author zeno.albis...@digia.com
Date 2013-02-28 11:37:22 -0800 (Thu, 28 Feb 2013)


Log Message
Enable DFG JIT for Qt on Mac
https://bugs.webkit.org/show_bug.cgi?id=111095

Rubber-stamped by Simon Hausmann

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h




Diff

Modified: trunk/Source/WTF/ChangeLog (144336 => 144337)

--- trunk/Source/WTF/ChangeLog	2013-02-28 19:35:15 UTC (rev 144336)
+++ trunk/Source/WTF/ChangeLog	2013-02-28 19:37:22 UTC (rev 144337)
@@ -1,3 +1,12 @@
+2013-02-28  Zeno Albisser  
+
+Enable DFG JIT for Qt on Mac
+https://bugs.webkit.org/show_bug.cgi?id=111095
+
+Rubber-stamped by Simon Hausmann
+
+* wtf/Platform.h:
+
 2013-02-28  Eric Carlson  
 
 [Mac] use HAVE() macro instead of version check


Modified: trunk/Source/WTF/wtf/Platform.h (144336 => 144337)

--- trunk/Source/WTF/wtf/Platform.h	2013-02-28 19:35:15 UTC (rev 144336)
+++ trunk/Source/WTF/wtf/Platform.h	2013-02-28 19:37:22 UTC (rev 144337)
@@ -801,7 +801,7 @@
 
 #if !defined(ENABLE_DFG_JIT) && ENABLE(JIT) && !COMPILER(MSVC)
 /* Enable the DFG JIT on X86 and X86_64.  Only tested on Mac and GNU/Linux. */
-#if (CPU(X86) || CPU(X86_64)) && (PLATFORM(MAC) || OS(LINUX))
+#if (CPU(X86) || CPU(X86_64)) && (OS(DARWIN) || OS(LINUX))
 #define ENABLE_DFG_JIT 1
 #endif
 /* Enable the DFG JIT on ARMv7.  Only tested on iOS and Qt Linux. */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144336] trunk/Source

[eric . carlson]

Title: [144336] trunk/Source








Revision 144336
Author eric.carl...@apple.com
Date 2013-02-28 11:35:15 -0800 (Thu, 28 Feb 2013)


Log Message
[Mac] use HAVE() macro instead of version check
https://bugs.webkit.org/show_bug.cgi?id=111087

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, covered by existing tests.

* page/CaptionUserPreferencesMac.h: Use HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK).
* page/CaptionUserPreferencesMac.mm: Ditto.
(WebCore::CaptionUserPreferencesMac::CaptionUserPreferencesMac): Ditto.
(WebCore::CaptionUserPreferencesMac::~CaptionUserPreferencesMac): Ditto.

* page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences): Ditto.

Source/WTF:

* wtf/Platform.h: Define HAVE_MEDIA_ACCESSIBILITY_FRAMEWORK.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/CaptionUserPreferencesMac.h
trunk/Source/WebCore/page/CaptionUserPreferencesMac.mm
trunk/Source/WebCore/page/PageGroup.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (144335 => 144336)

--- trunk/Source/WTF/ChangeLog	2013-02-28 19:33:48 UTC (rev 144335)
+++ trunk/Source/WTF/ChangeLog	2013-02-28 19:35:15 UTC (rev 144336)
@@ -1,3 +1,12 @@
+2013-02-28  Eric Carlson  
+
+[Mac] use HAVE() macro instead of version check
+https://bugs.webkit.org/show_bug.cgi?id=111087
+
+Reviewed by Dean Jackson.
+
+* wtf/Platform.h: Define HAVE_MEDIA_ACCESSIBILITY_FRAMEWORK.
+
 2013-02-27  Balazs Kilvady  
 
 Bug in atomicIncrement implementation for MIPS GCC


Modified: trunk/Source/WTF/wtf/Platform.h (144335 => 144336)

--- trunk/Source/WTF/wtf/Platform.h	2013-02-28 19:33:48 UTC (rev 144335)
+++ trunk/Source/WTF/wtf/Platform.h	2013-02-28 19:35:15 UTC (rev 144336)
@@ -1020,6 +1020,10 @@
 #define HAVE_AVFOUNDATION_TEXT_TRACK_SUPPORT 1
 #endif
 
+#if PLATFORM(MAC) && !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+#define HAVE_MEDIA_ACCESSIBILITY_FRAMEWORK 1
+#endif
+
 #if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(EFL) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO)) || PLATFORM(BLACKBERRY)
 #define WTF_USE_REQUEST_ANIMATION_FRAME_TIMER 1
 #endif


Modified: trunk/Source/WebCore/ChangeLog (144335 => 144336)

--- trunk/Source/WebCore/ChangeLog	2013-02-28 19:33:48 UTC (rev 144335)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 19:35:15 UTC (rev 144336)
@@ -1,3 +1,20 @@
+2013-02-28  Eric Carlson  
+
+[Mac] use HAVE() macro instead of version check
+https://bugs.webkit.org/show_bug.cgi?id=111087
+
+Reviewed by Dean Jackson.
+
+No new tests, covered by existing tests.
+
+* page/CaptionUserPreferencesMac.h: Use HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK).
+* page/CaptionUserPreferencesMac.mm: Ditto.
+(WebCore::CaptionUserPreferencesMac::CaptionUserPreferencesMac): Ditto.
+(WebCore::CaptionUserPreferencesMac::~CaptionUserPreferencesMac): Ditto.
+
+* page/PageGroup.cpp:
+(WebCore::PageGroup::captionPreferences): Ditto.
+
 2013-02-28  Chris Fleizach  
 
 WebSpeech: support the boundary event


Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMac.h (144335 => 144336)

--- trunk/Source/WebCore/page/CaptionUserPreferencesMac.h	2013-02-28 19:33:48 UTC (rev 144335)
+++ trunk/Source/WebCore/page/CaptionUserPreferencesMac.h	2013-02-28 19:35:15 UTC (rev 144336)
@@ -40,7 +40,7 @@
 static PassOwnPtr create(PageGroup* group) { return adoptPtr(new CaptionUserPreferencesMac(group)); }
 virtual ~CaptionUserPreferencesMac();
 
-#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 virtual bool userHasCaptionPreferences() const OVERRIDE;
 virtual bool userPrefersCaptions() const OVERRIDE;
 virtual void setUserPrefersCaptions(bool) OVERRIDE;
@@ -60,7 +60,7 @@
 private:
 CaptionUserPreferencesMac(PageGroup*);
 
-#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 String captionsWindowCSS() const;
 String captionsBackgroundCSS() const;
 String captionsTextColorCSS() const;


Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMac.mm (144335 => 144336)

--- trunk/Source/WebCore/page/CaptionUserPreferencesMac.mm	2013-02-28 19:33:48 UTC (rev 144335)
+++ trunk/Source/WebCore/page/CaptionUserPreferencesMac.mm	2013-02-28 19:35:15 UTC (rev 144336)
@@ -45,11 +45,11 @@
 #import 
 #import 
 
-#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 #import "MediaAccessibility/MediaAccessibility.h"
 #endif
 
-#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 
 SOFT_LINK_FRAMEWORK_OPTIONAL(MediaAccessibility)
 
@@ -77,7 +77,7 @@
 
 namespace WebCore {
 
-#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 static void userCaptionPreferencesChangedNotificationCallback(CFNotificationCenterRef, void* observer, CFStringRef, const void *, CFDictionaryRef)
 {
 static_cast

[webkit-changes] [144335] trunk

[cfleizach]

Title: [144335] trunk








Revision 144335
Author cfleiz...@apple.com
Date 2013-02-28 11:33:48 -0800 (Thu, 28 Feb 2013)


Log Message
WebSpeech: support the boundary event
https://bugs.webkit.org/show_bug.cgi?id=107350

Reviewed by Beth Dakin.

Source/WebCore:

Generate boundary events for speech synthesis and have them fire the appropriate events.
This implements for the Mac platform, as well as simulating these events in the mock
synthesizer for testing purposes.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html

* Modules/speech/SpeechSynthesis.cpp:
(WebCore):
(WebCore::SpeechSynthesis::boundaryEventOccurred):
* Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
* platform/PlatformSpeechSynthesizer.h:
(WebCore):
(PlatformSpeechSynthesizerClient):
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speechSynthesizer:willSpeakWord:ofString:]):
* platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::speak):

LayoutTests:

* platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events-expected.txt: Added.
* platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/speech/SpeechSynthesis.cpp
trunk/Source/WebCore/Modules/speech/SpeechSynthesis.h
trunk/Source/WebCore/platform/PlatformSpeechSynthesizer.h
trunk/Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm
trunk/Source/WebCore/platform/mock/PlatformSpeechSynthesizerMock.cpp


Added Paths

trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events-expected.txt
trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html




Diff

Modified: trunk/LayoutTests/ChangeLog (144334 => 144335)

--- trunk/LayoutTests/ChangeLog	2013-02-28 19:23:40 UTC (rev 144334)
+++ trunk/LayoutTests/ChangeLog	2013-02-28 19:33:48 UTC (rev 144335)
@@ -1,3 +1,13 @@
+2013-02-28  Chris Fleizach  
+
+WebSpeech: support the boundary event
+https://bugs.webkit.org/show_bug.cgi?id=107350
+
+Reviewed by Beth Dakin.
+
+* platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events-expected.txt: Added.
+* platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html: Added.
+
 2013-02-28  Adam Barth  
 
 This timeout also happens in Release.


Added: trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events-expected.txt (0 => 144335)

--- trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events-expected.txt	2013-02-28 19:33:48 UTC (rev 144335)
@@ -0,0 +1,12 @@
+This tests that a speech job will generate the correct boundary events.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Speech started
+Boundary event: word, Character index: 0
+Boundary event: sentence, Character index: 14
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html (0 => 144335)

--- trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html	2013-02-28 19:33:48 UTC (rev 144335)
@@ -0,0 +1,42 @@
+
+
+
+
+
+
+

+
+