date:20130314

[webkit-changes] [145879] trunk/Source

2013-03-14 Thread lforschler

Title: [145879] trunk/Source








Revision 145879
Author lforsch...@apple.com
Date 2013-03-14 23:28:21 -0700 (Thu, 14 Mar 2013)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (145878 => 145879)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2013-03-15 06:26:14 UTC (rev 145878)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2013-03-15 06:28:21 UTC (rev 145879)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 33;
+MINOR_VERSION = 35;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (145878 => 145879)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2013-03-15 06:26:14 UTC (rev 145878)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2013-03-15 06:28:21 UTC (rev 145879)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 33;
+MINOR_VERSION = 35;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (145878 => 145879)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2013-03-15 06:26:14 UTC (rev 145878)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2013-03-15 06:28:21 UTC (rev 145879)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 33;
+MINOR_VERSION = 35;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (145878 => 145879)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2013-03-15 06:26:14 UTC (rev 145878)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2013-03-15 06:28:21 UTC (rev 145879)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 33;
+MINOR_VERSION = 35;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145878] tags/Safari-537.34/

2013-03-14 Thread lforschler

Title: [145878] tags/Safari-537.34/








Revision 145878
Author lforsch...@apple.com
Date 2013-03-14 23:26:14 -0700 (Thu, 14 Mar 2013)


Log Message
New Tag.

Added Paths

tags/Safari-537.34/




Diff

Property changes: tags/Safari-537.34



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145877] trunk/Source/WebCore

2013-03-14 Thread dominicc

Title: [145877] trunk/Source/WebCore








Revision 145877
Author domin...@chromium.org
Date 2013-03-14 23:22:48 -0700 (Thu, 14 Mar 2013)


Log Message
Redundant if statement in RenderTextControlSingleLine::layout should be removed
https://bugs.webkit.org/show_bug.cgi?id=112406

Reviewed by Andreas Kling.

Covered by existing tests added in r145239.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (145876 => 145877)

--- trunk/Source/WebCore/ChangeLog	2013-03-15 06:01:08 UTC (rev 145876)
+++ trunk/Source/WebCore/ChangeLog	2013-03-15 06:22:48 UTC (rev 145877)
@@ -1,3 +1,15 @@
+2013-03-14  Dominic Cooney  
+
+Redundant if statement in RenderTextControlSingleLine::layout should be removed
+https://bugs.webkit.org/show_bug.cgi?id=112406
+
+Reviewed by Andreas Kling.
+
+Covered by existing tests added in r145239.
+
+* rendering/RenderTextControlSingleLine.cpp:
+(WebCore::RenderTextControlSingleLine::layout):
+
 2013-03-14  Sheriff Bot  
 
 Unreviewed, rolling out r145864.


Modified: trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp (145876 => 145877)

--- trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp	2013-03-15 06:01:08 UTC (rev 145876)
+++ trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp	2013-03-15 06:22:48 UTC (rev 145877)
@@ -135,8 +135,7 @@
 
 m_desiredInnerTextLogicalHeight = desiredLogicalHeight;
 
-if (innerTextRenderer)
-innerTextRenderer->style()->setLogicalHeight(Length(desiredLogicalHeight, Fixed));
+innerTextRenderer->style()->setLogicalHeight(Length(desiredLogicalHeight, Fixed));
 if (innerBlockRenderer)
 innerBlockRenderer->style()->setLogicalHeight(Length(desiredLogicalHeight, Fixed));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145876] trunk

2013-03-14 Thread commit-queue

Title: [145876] trunk








Revision 145876
Author commit-qu...@webkit.org
Date 2013-03-14 23:01:08 -0700 (Thu, 14 Mar 2013)


Log Message
Unreviewed, rolling out r145864.
http://trac.webkit.org/changeset/145864
https://bugs.webkit.org/show_bug.cgi?id=112408

should fix XMLDocumentParser instead of CSSDefaultStyleSheet
(Requested by tasak on #webkit).

Patch by Sheriff Bot  on 2013-03-14

Source/WebCore:

* css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

LayoutTests:

* fast/css/ensure-default-style-sheets-crash-expected.txt: Removed.
* fast/css/ensure-default-style-sheets-crash.xhtml: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSDefaultStyleSheets.cpp


Removed Paths

trunk/LayoutTests/fast/css/ensure-default-style-sheets-crash-expected.txt
trunk/LayoutTests/fast/css/ensure-default-style-sheets-crash.xhtml




Diff

Modified: trunk/LayoutTests/ChangeLog (145875 => 145876)

--- trunk/LayoutTests/ChangeLog	2013-03-15 05:29:01 UTC (rev 145875)
+++ trunk/LayoutTests/ChangeLog	2013-03-15 06:01:08 UTC (rev 145876)
@@ -1,3 +1,15 @@
+2013-03-14  Sheriff Bot  
+
+Unreviewed, rolling out r145864.
+http://trac.webkit.org/changeset/145864
+https://bugs.webkit.org/show_bug.cgi?id=112408
+
+should fix XMLDocumentParser instead of CSSDefaultStyleSheet
+(Requested by tasak on #webkit).
+
+* fast/css/ensure-default-style-sheets-crash-expected.txt: Removed.
+* fast/css/ensure-default-style-sheets-crash.xhtml: Removed.
+
 2013-03-14  Hayato Ito  
 
 [Shadow Dom]: Non Bubbling events in ShadowDOM dispatch in an incorrect order


Deleted: trunk/LayoutTests/fast/css/ensure-default-style-sheets-crash-expected.txt (145875 => 145876)

--- trunk/LayoutTests/fast/css/ensure-default-style-sheets-crash-expected.txt	2013-03-15 05:29:01 UTC (rev 145875)
+++ trunk/LayoutTests/fast/css/ensure-default-style-sheets-crash-expected.txt	2013-03-15 06:01:08 UTC (rev 145876)
@@ -1,3 +0,0 @@
-[bug 112328] https://bugs.webkit.org/show_bug.cgi?id=112328 This test ensures WebKit does not crash when preparing default style sheets without any pages. If there is no crash, the test passes.
-
-PASS


Deleted: trunk/LayoutTests/fast/css/ensure-default-style-sheets-crash.xhtml (145875 => 145876)

--- trunk/LayoutTests/fast/css/ensure-default-style-sheets-crash.xhtml	2013-03-15 05:29:01 UTC (rev 145875)
+++ trunk/LayoutTests/fast/css/ensure-default-style-sheets-crash.xhtml	2013-03-15 06:01:08 UTC (rev 145876)
@@ -1,17 +0,0 @@
-
-
-
-if (window.testRunner)
-testRunner.dumpAsText();
-
-
-
-  [bug 112328] 
-  
-
-  replaceWholeText sample
-
-  
-  PASS
-
-


Modified: trunk/Source/WebCore/ChangeLog (145875 => 145876)

--- trunk/Source/WebCore/ChangeLog	2013-03-15 05:29:01 UTC (rev 145875)
+++ trunk/Source/WebCore/ChangeLog	2013-03-15 06:01:08 UTC (rev 145876)
@@ -1,3 +1,15 @@
+2013-03-14  Sheriff Bot  
+
+Unreviewed, rolling out r145864.
+http://trac.webkit.org/changeset/145864
+https://bugs.webkit.org/show_bug.cgi?id=112408
+
+should fix XMLDocumentParser instead of CSSDefaultStyleSheet
+(Requested by tasak on #webkit).
+
+* css/CSSDefaultStyleSheets.cpp:
+(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
+
 2013-03-14  Eugene Klyuchnikov  
 
 Web Inspector: [DataGrid] Specify columns with array of descriptors.


Modified: trunk/Source/WebCore/css/CSSDefaultStyleSheets.cpp (145875 => 145876)

--- trunk/Source/WebCore/css/CSSDefaultStyleSheets.cpp	2013-03-15 05:29:01 UTC (rev 145875)
+++ trunk/Source/WebCore/css/CSSDefaultStyleSheets.cpp	2013-03-15 06:01:08 UTC (rev 145876)
@@ -201,10 +201,7 @@
 #endif
 
 if (!plugInsStyleSheet && (element->hasTagName(objectTag) || element->hasTagName(embedTag))) {
-Page* page = element->document()->page();
-String plugInsRules = String(plugInsUserAgentStyleSheet, sizeof(plugInsUserAgentStyleSheet)) + RenderTheme::themeForPage(page)->extraPlugInsStyleSheet();
-if (page)
-plugInsRules = plugInsRules + page->chrome()->client()->plugInExtraStyleSheet();
+String plugInsRules = String(plugInsUserAgentStyleSheet, sizeof(plugInsUserAgentStyleSheet)) + RenderTheme::themeForPage(element->document()->page())->extraPlugInsStyleSheet() + element->document()->page()->chrome()->client()->plugInExtraStyleSheet();
 plugInsStyleSheet = parseUASheet(plugInsRules);
 defaultStyle->addRulesFromSheet(plugInsStyleSheet, screenEval());
 changedDefaultStyle = true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145874] trunk/Source/WebCore

2013-03-14 Thread loislo

Title: [145874] trunk/Source/WebCore








Revision 145874
Author loi...@chromium.org
Date 2013-03-14 22:26:33 -0700 (Thu, 14 Mar 2013)


Log Message
Web Inspector: Flame Chart. Support scrolling by dragging.
https://bugs.webkit.org/show_bug.cgi?id=112346

Reviewed by Yury Semikhatsky.

Drag hander was added. It seems that simple repaint works well.
When the user starts dragging we hide the popover, change offset
and do update for the new canvas image.
Drive by change: Due to new way of scrolling the canvas I changed
the behaiviour of the wheel events. Now wheel scrolls if Shift key pressed
and zooms if not.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._startCanvasDragging):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._endCanvasDragging):
(WebInspector.FlameChart.prototype._onMouseWheel):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/FlameChart.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (145873 => 145874)

--- trunk/Source/WebCore/ChangeLog	2013-03-15 05:14:28 UTC (rev 145873)
+++ trunk/Source/WebCore/ChangeLog	2013-03-15 05:26:33 UTC (rev 145874)
@@ -1,3 +1,24 @@
+2013-03-14  Ilya Tikhonovsky  
+
+Web Inspector: Flame Chart. Support scrolling by dragging.
+https://bugs.webkit.org/show_bug.cgi?id=112346
+
+Reviewed by Yury Semikhatsky.
+
+Drag hander was added. It seems that simple repaint works well.
+When the user starts dragging we hide the popover, change offset
+and do update for the new canvas image.
+Drive by change: Due to new way of scrolling the canvas I changed
+the behaiviour of the wheel events. Now wheel scrolls if Shift key pressed
+and zooms if not.
+
+* inspector/front-end/FlameChart.js:
+(WebInspector.FlameChart):
+(WebInspector.FlameChart.prototype._startCanvasDragging):
+(WebInspector.FlameChart.prototype._canvasDragging):
+(WebInspector.FlameChart.prototype._endCanvasDragging):
+(WebInspector.FlameChart.prototype._onMouseWheel):
+
 2013-03-14  Hayato Ito  
 
 [Shadow Dom]: Non Bubbling events in ShadowDOM dispatch in an incorrect order


Modified: trunk/Source/WebCore/inspector/front-end/FlameChart.js (145873 => 145874)

--- trunk/Source/WebCore/inspector/front-end/FlameChart.js	2013-03-15 05:14:28 UTC (rev 145873)
+++ trunk/Source/WebCore/inspector/front-end/FlameChart.js	2013-03-15 05:26:33 UTC (rev 145874)
@@ -40,6 +40,8 @@
 
 this.element.className = "flame-chart";
 this._canvas = this.element.createChild("canvas");
+WebInspector.installDragHandle(this._canvas, this._startCanvasDragging.bind(this), this._canvasDragging.bind(this), this._endCanvasDragging.bind(this), "col-resize");
+
 this._cpuProfileView = cpuProfileView;
 this._xScaleFactor = 4.0;
 this._xOffset = 0;
@@ -61,6 +63,36 @@
 }
 
 WebInspector.FlameChart.prototype = {
+_startCanvasDragging: function(event)
+{
+if (!this._timelineData)
+return false;
+this._isDragging = true;
+this._dragStartPoint = event.pageX;
+this._dragStartXOffset = this._xOffset;
+this._hidePopover();
+return true;
+},
+
+_canvasDragging: function(event)
+{
+this._xOffset = this._dragStartXOffset + this._dragStartPoint - event.pageX;
+
+if (this._xOffset < 0)
+this._xOffset = 0;
+else {
+var maxXOffset = this._timelineData.totalTime * this._xScaleFactor - this._canvas.width;
+if (this._xOffset > maxXOffset)
+this._xOffset = maxXOffset;
+}
+this._scheduleUpdate();
+},
+
+_endCanvasDragging: function()
+{
+this._isDragging = false;
+},
+
 _nodeCount: function()
 {
 var nodes = this._cpuProfileView.profileHead.children.slice();
@@ -154,14 +186,18 @@
 
 _getPopoverAnchor: function()
 {
-if (this._highlightedNodeIndex === -1)
+if (this._highlightedNodeIndex === -1 || this._isDragging)
 return null;
 return this._anchorElement;
 },
 
 _showPopover: function(anchor, popover)
 {
+if (this._isDragging)
+return;
 var node = this._timelineData.nodes[this._highlightedNodeIndex];
+if (!node)
+return;
 var contentHelper = new WebInspector.PopoverContentHelper(node.functionName);
 contentHelper.appendTextRow(WebInspector.UIString("Total time"), Number.secondsToString(node.totalTime / 1000, true));
 contentHelper.appendTextRow(WebInspector.UIString("Self time"), Number.secondsToString(node.selfTime / 1000, true));
@@ -191,6 +227,8 @@
 
 _onMouseMove: function(e)
 {
+if (this._isDragging)
+return;
 var nodeIndex = this._coordinatesToNodeIndex(e.offsetX, e.offsetY);
 if (nodeIndex === thi

[webkit-changes] [145873] trunk

2013-03-14 Thread hayato

Title: [145873] trunk








Revision 145873
Author hay...@chromium.org
Date 2013-03-14 22:14:28 -0700 (Thu, 14 Mar 2013)


Log Message
[Shadow Dom]: Non Bubbling events in ShadowDOM dispatch in an incorrect order
https://bugs.webkit.org/show_bug.cgi?id=112214

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fix the order of event dispatching for Shadow DOM.

So far, an event whose event phase should be set to AT_TARGET,
e.g. event at shadow hosts, is dispatched in bubbling phase in the
whole event path.  This patch fixed the order of event dispatching
so that an event whose event phase must be set to AT_TARGET phase
is dispatched in capturing phase rather than bubbling phase.

The spec is here:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#event-dispatch

5.5 Event Dispatch says:

- When capturing, which entails processing step 3 of the event
dispatch algorithm, the Event eventPhase attribute must return
AT_TARGET if the relative target is same as the node on which
event listeners are invoked
- When bubbling, which entails
processing step 6 of the event dispatch algorithm, the event
listeners must not be invoked on a node if it is the same as its
relative target

No new tests. Update existing layout tests.

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtBubbling):

LayoutTests:

* fast/dom/shadow/cppevent-in-shadow-expected.txt:
* fast/dom/shadow/cppevent-input-in-shadow-expected.txt:
* fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
* fast/dom/shadow/shadow-boundary-events-expected.txt:
* fast/dom/shadow/shadow-boundary-events.html:
* fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/shadow/cppevent-in-shadow-expected.txt
trunk/LayoutTests/fast/dom/shadow/cppevent-input-in-shadow-expected.txt
trunk/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-boundary-events-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-boundary-events.html
trunk/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventDispatcher.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (145872 => 145873)

--- trunk/LayoutTests/ChangeLog	2013-03-15 04:47:50 UTC (rev 145872)
+++ trunk/LayoutTests/ChangeLog	2013-03-15 05:14:28 UTC (rev 145873)
@@ -1,3 +1,20 @@
+2013-03-14  Hayato Ito  
+
+[Shadow Dom]: Non Bubbling events in ShadowDOM dispatch in an incorrect order
+https://bugs.webkit.org/show_bug.cgi?id=112214
+
+Reviewed by Dimitri Glazkov.
+
+* fast/dom/shadow/cppevent-in-shadow-expected.txt:
+* fast/dom/shadow/cppevent-input-in-shadow-expected.txt:
+* fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
+* fast/dom/shadow/shadow-boundary-events-expected.txt:
+* fast/dom/shadow/shadow-boundary-events.html:
+* fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
+* fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt:
+* fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt:
+* fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:
+
 2013-03-14  Pavel Feldman  
 
 Not reviewed: Chromium TestExpectations cleanup prepared by kbr@


Modified: trunk/LayoutTests/fast/dom/shadow/cppevent-in-shadow-expected.txt (145872 => 145873)

--- trunk/LayoutTests/fast/dom/shadow/cppevent-in-shadow-expected.txt	2013-03-15 04:47:50 UTC (rev 145872)
+++ trunk/LayoutTests/fast/dom/shadow/cppevent-in-shadow-expected.txt	2013-03-15 05:14:28 UTC (rev 145873)
@@ -1,9 +1,9 @@
+host: copy is fired.
 dark: copy is fired.
-host: copy is fired.
+host: cut is fired.
 dark: cut is fired.
-host: cut is fired.
+host: paste is fired.
 dark: paste is fired.
-host: paste is fired.
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/dom/shadow/cppevent-input-in-shadow-expected.txt (145872 => 145873)

--- trunk/LayoutTests/fast/dom/shadow/cppevent-input-in-shadow-expected.txt	2013-03-15 04:47:50 UTC (rev 145872)
+++ trunk/LayoutTests/fast/dom/shadow/cppevent-input-in-shadow-expected.txt	2013-03-15 05:14:28 UTC (rev 14587

[webkit-changes] [145872] trunk/LayoutTests

2013-03-14 Thread pfeldman

Title: [145872] trunk/LayoutTests








Revision 145872
Author pfeld...@chromium.org
Date 2013-03-14 21:47:50 -0700 (Thu, 14 Mar 2013)


Log Message
Not reviewed: Chromium TestExpectations cleanup prepared by kbr@

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (145871 => 145872)

--- trunk/LayoutTests/ChangeLog	2013-03-15 04:25:27 UTC (rev 145871)
+++ trunk/LayoutTests/ChangeLog	2013-03-15 04:47:50 UTC (rev 145872)
@@ -1,3 +1,9 @@
+2013-03-14  Pavel Feldman  
+
+Not reviewed: Chromium TestExpectations cleanup prepared by kbr@
+
+* platform/chromium/TestExpectations:
+
 2013-03-14  Shezan Baig  
 
 Backspace/delete at start of table cell shouldn't step out of cell


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (145871 => 145872)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-15 04:25:27 UTC (rev 145871)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-15 04:47:50 UTC (rev 145872)
@@ -594,8 +594,6 @@
 http/tests/security/storage-blocking-strengthened-shared-worker.html [ WontFix ]
 storage/indexeddb/basics-shared-workers.html [ WontFix ]
 
-webkit.org/b/110401 [ Lion Win7 Debug ] http/tests/security/feed-urls-from-remote.html [ Timeout ]
-
 # test_shell does not support message ports
 webkit.org/b/74459 fast/workers/termination-with-port-messages.html
 webkit.org/b/74459 fast/workers/worker-cloneport.html
@@ -1576,13 +1574,11 @@
 webkit.org/b/110138 compositing/geometry/limit-layer-bounds-fixed.html [ Failure ]
 webkit.org/b/110138 platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed.html [ Failure ]
 
-webkit.org/b/110079 [ Win Debug ] storage/websql/sql-data-types.html [ Crash ]
-
 # Newly introduced Reftest fails on Chrome/Mac
 webkit.org/b/110203 [ MountainLion ] fast/multicol/seamless-flowed-through-columns.html [ ImageOnlyFailure ]
 
 # Test fails for some reason.
-webkit.org/b/110296 [ Linux Lion MountainLion ] fast/multicol/newmulticol/column-rules-fixed-height.html [ ImageOnlyFailure ]
+webkit.org/b/110296 [ Linux MountainLion ] fast/multicol/newmulticol/column-rules-fixed-height.html [ ImageOnlyFailure ]
 webkit.org/b/110377 [ MountainLion ] fast/multicol/newmulticol/layers-in-multicol.html [ ImageOnlyFailure ]
 webkit.org/b/110377 [ MountainLion ] fast/multicol/newmulticol/float-paginate-complex.html [ ImageOnlyFailure ]
 webkit.org/b/110377 [ MountainLion ] fast/multicol/newmulticol/float-paginate.html [ ImageOnlyFailure ]
@@ -2394,9 +2390,6 @@
 crbug.com/60651 fast/canvas/webgl/uniform-location.html [ Failure Timeout ]
 crbug.com/60651 platform/chromium/virtual/gpu/fast/canvas/webgl/uniform-location.html [ Failure Timeout ]
 
-# This will fail in Chromium until the patch is upstreamed to ANGLE
-webkit.org/b/98977 fast/canvas/webgl/array-bounds-clamping.html [ Failure ]
-
 # Flaky since r68438:r68445 or before that.
 webkit.org/b/46693 [ Mac ] fast/repaint/repaint-svg-after-style-change.html [ Failure ]
 
@@ -3348,9 +3341,6 @@
 
 webkit.org/b/ [ Win ] http/tests/xmlhttprequest/redirect-cross-origin-post.html [ Failure Pass ]
 
-crbug.com/121442 [ Linux Debug ] plugins/iframe-shims.html [ Crash ]
-crbug.com/121442 [ Linux Release ] plugins/iframe-shims.html [ Crash Pass ]
-
 webkit.org/b/83219 [ Lion MountainLion ] fonts/cursive.html [ Failure ImageOnlyFailure Pass ]
 webkit.org/b/83324 [ Win Debug ] fast/js/cross-global-object-inline-global-var.html [ Failure Pass ]
 
@@ -3620,9 +3610,6 @@
 webkit.org/b/91183 http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html [ Failure Pass ]
 webkit.org/b/91183 http/tests/w3c/webperf/approved/HighResolutionTime/test_cross_frame_start.html [ Failure Pass ]
 
-# Fails on Mac 10.7
-webkit.org/b/91255 [ Lion ] fast/multicol/table-vertical-align.html [ Failure ]
-
 # Fails since creation in 122663
 webkit.org/b/91372 [ Win ] css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ]
 
@@ -3736,7 +3723,6 @@
 webkit.org/b/94492 [ Win ] css3/filters/custom/filter-repaint-custom-rotated.html [ ImageOnlyFailure ]
 
 webkit.org/b/106044 [ Win7 ] css3/filters/effect-invert.html [ ImageOnlyFailure Pass ]
-webkit.org/b/106044 [ XP ] css3/filters/effect-invert.html [ ImageOnlyFailure ]
 
 webkit.org/b/95581 http/tests/xmlhttprequest/zero-length-response.html [ Pass Timeout ]
 webkit.org/b/95581 http/tests/misc/_javascript_-url-stop-loaders.html [ Pass Timeout ]
@@ -3922,7 +3908,6 @@
 webkit.org/b/96833 svg/carto.net/selectionlist.svg [ ImageOnlyFailure Pass ]
 
 webkit.org/b/96549 [ Android ] platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html [ ImageOnlyFailure ]
-webkit.org/b/96628 [ Lion Debug ] fast/frames/calculate-order.html [ Failure ]
 webkit.org/b/96550 http/tests/media/media-source/seek-to-end-after-duration-change.html [ Pass Timeout ]
 
 crbug.com/63921 platfor

[webkit-changes] [145871] trunk

2013-03-14 Thread commit-queue

Title: [145871] trunk








Revision 145871
Author commit-qu...@webkit.org
Date 2013-03-14 21:25:27 -0700 (Thu, 14 Mar 2013)


Log Message
Backspace/delete at start of table cell shouldn't step out of cell
https://bugs.webkit.org/show_bug.cgi?id=35372

Patch by Shezan Baig  on 2013-03-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

Make Delete and ForwardDelete commands be no-ops if we are at the first
position or last position of a table cell respectively.

Tests: editing/deleting/backspace-at-table-cell-beginning.html
   editing/deleting/forward-delete-at-table-cell-ending.html

* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

LayoutTests:

* editing/deleting/backspace-at-table-cell-beginning-expected.txt: Added.
* editing/deleting/backspace-at-table-cell-beginning.html: Added.
* editing/deleting/forward-delete-at-table-cell-ending-expected.txt: Added.
* editing/deleting/forward-delete-at-table-cell-ending.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TypingCommand.cpp


Added Paths

trunk/LayoutTests/editing/deleting/backspace-at-table-cell-beginning-expected.txt
trunk/LayoutTests/editing/deleting/backspace-at-table-cell-beginning.html
trunk/LayoutTests/editing/deleting/forward-delete-at-table-cell-ending-expected.txt
trunk/LayoutTests/editing/deleting/forward-delete-at-table-cell-ending.html




Diff

Modified: trunk/LayoutTests/ChangeLog (145870 => 145871)

--- trunk/LayoutTests/ChangeLog	2013-03-15 03:37:06 UTC (rev 145870)
+++ trunk/LayoutTests/ChangeLog	2013-03-15 04:25:27 UTC (rev 145871)
@@ -1,3 +1,15 @@
+2013-03-14  Shezan Baig  
+
+Backspace/delete at start of table cell shouldn't step out of cell
+https://bugs.webkit.org/show_bug.cgi?id=35372
+
+Reviewed by Ryosuke Niwa.
+
+* editing/deleting/backspace-at-table-cell-beginning-expected.txt: Added.
+* editing/deleting/backspace-at-table-cell-beginning.html: Added.
+* editing/deleting/forward-delete-at-table-cell-ending-expected.txt: Added.
+* editing/deleting/forward-delete-at-table-cell-ending.html: Added.
+
 2013-03-14  Xidorn Quan  
 
 Clickable area is incorrect for elements with border-radius


Added: trunk/LayoutTests/editing/deleting/backspace-at-table-cell-beginning-expected.txt (0 => 145871)

--- trunk/LayoutTests/editing/deleting/backspace-at-table-cell-beginning-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/deleting/backspace-at-table-cell-beginning-expected.txt	2013-03-15 04:25:27 UTC (rev 145871)
@@ -0,0 +1,39 @@
+This test verifies that backspace at the beginning of a table-cell is a no-op. The first dump verifies that the caret stays before 'abc', and doesn't select the nested table. The second dump verifies that the caret stays before 'def'.
+
+Dump of markup 1:
+| 
+|   
+| 
+|   
+| 
+|   
+| 
+|   
+| "ghi"
+|   
+| "jkl"
+|   
+| id="first"
+| "<#selection-caret>abc"
+|   
+| id="second"
+| "def"
+
+Dump of markup 2:
+| 
+|   
+| 
+|   
+| 
+|   
+| 
+|   
+| "ghi"
+|   
+| "jkl"
+|   
+| id="first"
+| "abc"
+|   
+| id="second"
+| "<#selection-caret>def"


Added: trunk/LayoutTests/editing/deleting/backspace-at-table-cell-beginning.html (0 => 145871)

--- trunk/LayoutTests/editing/deleting/backspace-at-table-cell-beginning.html	(rev 0)
+++ trunk/LayoutTests/editing/deleting/backspace-at-table-cell-beginning.html	2013-03-15 04:25:27 UTC (rev 145871)
@@ -0,0 +1,19 @@
+
+
+
+This test verifies that backspace at the beginning of a table-cell is a no-op. The first dump verifies that the caret stays before 'abc', and doesn't select the nested table. The second dump verifies that the caret stays before 'def'.
+ghijklabcdef
+
+Markup.description(document.getElementById("description").innerText);
+
+window.getSelection().collapse(document.getElementById("first").firstChild, 0);
+document.execCommand("Delete");
+Markup.dump("test");
+
+window.getSelection().collapse(document.getElementById("second").firstChild, 0);
+document.execCommand("Delete");
+Markup.dump("test");
+
+
+


Added: trunk/LayoutTests/editing/deleting/forward-delete-at-table-cell-ending-expected.txt (0 => 145871)

--- trunk/LayoutTests/editing/deleting/forward-delete-at-table-cell-ending-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/deleting/forward-delete-at-table-cell-ending-expected.txt	2013-03-15 04:25:27 UTC (rev 145871)
@@ -0,0 +1,41 @@
+This test verifies that forward delete at the end of a table-cell is a no-op. The first dump verifies that the caret stays after 'abc'. The second dump verifies that the caret

[webkit-changes] [145870] trunk

2013-03-14 Thread commit-queue

Title: [145870] trunk








Revision 145870
Author commit-qu...@webkit.org
Date 2013-03-14 20:37:06 -0700 (Thu, 14 Mar 2013)


Log Message
Clickable area is incorrect for elements with border-radius
https://bugs.webkit.org/show_bug.cgi?id=95373

Patch by Xidorn Quan  on 2013-03-14
Reviewed by Simon Fraser.

Source/WebCore:

As RenderBlock doesn't see rounded rect which comes from border-radius
in nodeAtPoint, the rounded corner seems to have an 'invisible' square
box which catches hits. So we added check on whether hitTestPoint also
intersects the rounded rect when hasBorderRadius is set.

This patch is based on Takashi Sakamoto's work in
https://bugs.webkit.org/show_bug.cgi?id=95373

Test: fast/borders/border-radius-position.html

* platform/graphics/FloatQuad.cpp:
(WebCore):
(WebCore::lineIntersectsCircle):
(WebCore::FloatQuad::intersectsCircle):
(WebCore::FloatQuad::intersectsEllipse):
* platform/graphics/FloatQuad.h:
(FloatQuad):
* platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::intersectsQuad):
(WebCore):
* platform/graphics/RoundedRect.h:
(RoundedRect):
* rendering/HitTestLocation.cpp:
(WebCore::HitTestLocation::intersects):
(WebCore):
* rendering/HitTestLocation.h:
(HitTestLocation):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):

LayoutTests:

This test is based on Takashi Sakamoto's work in
https://bugs.webkit.org/show_bug.cgi?id=95373

* fast/borders/border-radius-position-expected.txt: Added.
* fast/borders/border-radius-position.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FloatQuad.cpp
trunk/Source/WebCore/platform/graphics/FloatQuad.h
trunk/Source/WebCore/platform/graphics/RoundedRect.cpp
trunk/Source/WebCore/platform/graphics/RoundedRect.h
trunk/Source/WebCore/rendering/HitTestLocation.cpp
trunk/Source/WebCore/rendering/HitTestLocation.h
trunk/Source/WebCore/rendering/RenderBlock.cpp


Added Paths

trunk/LayoutTests/fast/borders/border-radius-position-expected.txt
trunk/LayoutTests/fast/borders/border-radius-position.html




Diff

Modified: trunk/LayoutTests/ChangeLog (145869 => 145870)

--- trunk/LayoutTests/ChangeLog	2013-03-15 03:30:26 UTC (rev 145869)
+++ trunk/LayoutTests/ChangeLog	2013-03-15 03:37:06 UTC (rev 145870)
@@ -1,3 +1,16 @@
+2013-03-14  Xidorn Quan  
+
+Clickable area is incorrect for elements with border-radius
+https://bugs.webkit.org/show_bug.cgi?id=95373
+
+Reviewed by Simon Fraser.
+
+This test is based on Takashi Sakamoto's work in
+https://bugs.webkit.org/show_bug.cgi?id=95373
+
+* fast/borders/border-radius-position-expected.txt: Added.
+* fast/borders/border-radius-position.html: Added.
+
 2013-03-14  Andreas Kling  
 
 REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.


Added: trunk/LayoutTests/fast/borders/border-radius-position-expected.txt (0 => 145870)

--- trunk/LayoutTests/fast/borders/border-radius-position-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/borders/border-radius-position-expected.txt	2013-03-15 03:37:06 UTC (rev 145870)
@@ -0,0 +1,17 @@
+Test for bug 95373: https://bugs.webkit.org/show_bug.cgi?id=95373 (border-radius) when border-radius:50% there is still 'invisible' square box
+
+Click outerBox
+Click outerBox
+Click innerBox
+Click outerBox
+Click innerBox
+Click outerBox
+Click outerBox
+Click outerBox
+Click innerBox
+Click innerBox
+Click outerBox
+Click outerBox
+Click innerBox
+Click innerBox
+


Added: trunk/LayoutTests/fast/borders/border-radius-position.html (0 => 145870)

--- trunk/LayoutTests/fast/borders/border-radius-position.html	(rev 0)
+++ trunk/LayoutTests/fast/borders/border-radius-position.html	2013-03-15 03:37:06 UTC (rev 145870)
@@ -0,0 +1,106 @@
+
+
+
+
+div#innerBox {
+width: 200px;
+height: 200px;
+padding: 0px;
+border-top-left-radius: 100px 80px;
+border-top-right-radius: 50px 25px;
+border-bottom-left-radius: 50px 70px;
+border-bottom-right-radius: 70px 30px;
+background-color: green;
+}
+
+div#outerBox {
+width: 200px;
+height: 200px;
+margin: 0px;
+padding: 100px;
+background-color: lightgreen;
+}
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function log(message) {
+var console = document.getElementById('console');
+console.innerHTML += message + "\n";
+}
+
+function runTest() {
+var outerBox = document.getElementById('outerBox');
+outerBox.addEventListener('click', function(event) {
+log("Click outerBox");
+}, false);
+var innerBox = document.getElementById('innerBox');
+innerBox.addEventListener('click', function(event) {
+log("Click innerBox");
+event.stopPropagation();
+}, false);
+if (window.testRunner) {
+var x = innerBox.offsetLeft;
+var y = innerBox.offsetTop;
+// top-left
+eventSender.mouseM

[webkit-changes] [145869] trunk

2013-03-14 Thread akling

Title: [145869] trunk








Revision 145869
Author akl...@apple.com
Date 2013-03-14 20:30:26 -0700 (Thu, 14 Mar 2013)


Log Message
REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.



Reviewed by Anders Carlsson.

Source/WebKit2:

Call getWindowFrame() to see if the UI client wants to override the window frame before sending
a WindowAndViewFramesChanged message to the web process.
This fixes a glitch in WTR and the Web Inspector where incorrect window frames were being used.

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):

Tools:

Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.

* WebKitTestRunner/PlatformWebView.h:
(PlatformWebView):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::didInitializeClients):

LayoutTests:

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/PlatformWebView.h
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp
trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm
trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp
trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (145868 => 145869)

--- trunk/LayoutTests/ChangeLog	2013-03-15 02:41:26 UTC (rev 145868)
+++ trunk/LayoutTests/ChangeLog	2013-03-15 03:30:26 UTC (rev 145869)
@@ -1,3 +1,13 @@
+2013-03-14  Andreas Kling  
+
+REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
+
+
+
+Reviewed by Anders Carlsson.
+
+* platform/mac-wk2/TestExpectations:
+
 2013-03-14  John Bauman  
 
 plugins/plugin-clip-subframe.html is flaky


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (145868 => 145869)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-03-15 02:41:26 UTC (rev 145868)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-03-15 03:30:26 UTC (rev 145869)
@@ -317,8 +317,6 @@
 
 webkit.org/b/109890 [ Debug ] platform/mac-wk2/plugins/destroy-during-async-npp-new.html [ Crash ]
 
-webkit.org/b/111815 http/tests/security/cross-frame-access-put.html [ Failure ]
-
 ### END OF (1) Classified failures with bug reports
 
 


Modified: trunk/Source/WebKit2/ChangeLog (145868 => 145869)

--- trunk/Source/WebKit2/ChangeLog	2013-03-15 02:41:26 UTC (rev 145868)
+++ trunk/Source/WebKit2/ChangeLog	2013-03-15 03:30:26 UTC (rev 145869)
@@ -1,3 +1,18 @@
+2013-03-14  Andreas Kling  
+
+REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
+
+
+
+Reviewed by Anders Carlsson.
+
+Call getWindowFrame() to see if the UI client wants to override the window frame before sending
+a WindowAndViewFramesChanged message to the web process.
+This fixes a glitch in WTR and the Web Inspector where incorrect window frames were being used.
+
+* UIProcess/mac/WebPageProxyMac.mm:
+(WebKit::WebPageProxy::windowAndViewFramesChanged):
+
 2013-03-14  Andy Estes  
 
 [WebKit2] Only preprocess sandbox profiles if we're building for the OS X SDK


Modified: trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm (145868 => 145869)

--- trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm	2013-03-15 02:41:26 UTC (rev 145868)
+++ trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm	2013-03-15 03:30:26 UTC (rev 145869)
@@ -143,7 +143,13 @@
 if (!isValid())
 return;
 
-process()->send(Messages::WebPage::WindowAndViewFramesChanged(windowFrameInScreenCoordinates, viewFrameInWindowCoordinates, accessibilityViewCoordinates), m_pageID);
+// If the UI client overrides getWindowFrame(), we call it here to make sure we send the appropriate window frame.  
+FloatRect adjustedWindowFrameInScreenCoordinates;
+getWindowFrame(adjustedWindowFrameInScreenCoordinates);
+if (adjustedWindowFrameInScreenCoordinates.isEmpty())
+adjustedWindowFrameInScreenCoordinates = windowFrameInScreenCoordinates;
+
+process()->send(Messages::WebPage::WindowAndViewFramesChanged(adjustedWindowFrameInScreenCoordinates, viewFrameInWindowCoordinates, accessibilityViewCoordinates), m_pageID);
 }
 
 void WebPageProxy::viewExposedRectChanged(const FloatRect& exposedRect)


Modified: trunk/Tools/Chan

[webkit-changes] [145868] trunk/LayoutTests

2013-03-14 Thread commit-queue

Title: [145868] trunk/LayoutTests








Revision 145868
Author commit-qu...@webkit.org
Date 2013-03-14 19:41:26 -0700 (Thu, 14 Mar 2013)


Log Message
plugins/plugin-clip-subframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=112324

Patch by John Bauman  on 2013-03-14
Reviewed by Ryosuke Niwa.

Ignore duplicate SetWindow calls with identical arguments. Plugins
will ignore these so they're not a problem, and they can cause
flakiness on mac-wk2.

* platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt:
* platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
* platform/chromium-win/plugins/plugin-clip-subframe-expected.txt:
* platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt:
* platform/mac/plugins/plugin-clip-subframe-expected.txt:
* plugins/plugin-clip-subframe-expected.txt:
* plugins/resources/plugin-clip-subframe-iframe.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt
trunk/LayoutTests/platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt
trunk/LayoutTests/platform/chromium-win/plugins/plugin-clip-subframe-expected.txt
trunk/LayoutTests/platform/mac/plugins/plugin-clip-subframe-expected.txt
trunk/LayoutTests/platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt
trunk/LayoutTests/plugins/plugin-clip-subframe-expected.txt
trunk/LayoutTests/plugins/resources/plugin-clip-subframe-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (145867 => 145868)

--- trunk/LayoutTests/ChangeLog	2013-03-15 02:18:45 UTC (rev 145867)
+++ trunk/LayoutTests/ChangeLog	2013-03-15 02:41:26 UTC (rev 145868)
@@ -1,3 +1,22 @@
+2013-03-14  John Bauman  
+
+plugins/plugin-clip-subframe.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=112324
+
+Reviewed by Ryosuke Niwa.
+
+Ignore duplicate SetWindow calls with identical arguments. Plugins
+will ignore these so they're not a problem, and they can cause
+flakiness on mac-wk2.
+
+* platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt:
+* platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
+* platform/chromium-win/plugins/plugin-clip-subframe-expected.txt:
+* platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt:
+* platform/mac/plugins/plugin-clip-subframe-expected.txt:
+* plugins/plugin-clip-subframe-expected.txt:
+* plugins/resources/plugin-clip-subframe-iframe.html:
+
 2013-03-14  Chris Fleizach  
 
 AX: Crash when removing aria-menu item from DOM


Modified: trunk/LayoutTests/platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt (145867 => 145868)

--- trunk/LayoutTests/platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt	2013-03-15 02:18:45 UTC (rev 145867)
+++ trunk/LayoutTests/platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt	2013-03-15 02:41:26 UTC (rev 145868)
@@ -1,3 +1,3 @@
-CONSOLE MESSAGE: line 3: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {65518, 65318, 65518, 65318}, Type 1
-CONSOLE MESSAGE: line 3: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 1
+CONSOLE MESSAGE: line 5: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {65518, 65318, 65518, 65318}, Type 1
+CONSOLE MESSAGE: line 5: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 1
 


Modified: trunk/LayoutTests/platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt (145867 => 145868)

--- trunk/LayoutTests/platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt	2013-03-15 02:18:45 UTC (rev 145867)
+++ trunk/LayoutTests/platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt	2013-03-15 02:41:26 UTC (rev 145868)
@@ -1,3 +1,3 @@
-CONSOLE MESSAGE: line 3: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {65518, 65318, 65518, 65318}, Type 2
-CONSOLE MESSAGE: line 3: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 2
+CONSOLE MESSAGE: line 5: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {65518, 65318, 65518, 65318}, Type 2
+CONSOLE MESSAGE: line 5: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 2
 


Modified: trunk/LayoutTests/platform/chromium-win/plugins/plugin-clip-subframe-expected.txt (145867 => 145868)

--- trunk/LayoutTests/platform/chromium-win/plugins/plugin-clip-subframe-expected.txt	2013-03-15 02:18:45 UTC (rev 145867)
+++ trunk/LayoutTests/platform/chromium-win/plugins/plugin-clip-subframe-expected.txt	2013-03-15 02:41:26 UTC (rev 145868)
@@ -1,3 +1,3 @@
-CONSOLE MESSAGE: line 3: NPP_SetWindow: non-NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 0, 0}, Type 1
-CONSOLE MESSAGE: line 3: NPP_SetWindow: non-NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 1
+CONSOLE MESSAGE: line 5: NPP_SetWindow: non-NULL window

[webkit-changes] [145867] branches/chromium/1410

2013-03-14 Thread dominicc

Title: [145867] branches/chromium/1410








Revision 145867
Author domin...@chromium.org
Date 2013-03-14 19:18:45 -0700 (Thu, 14 Mar 2013)


Log Message
[Chromium] Unreviewed, merge r145239.

Modified Paths

branches/chromium/1410/Source/WebCore/rendering/RenderTextControlSingleLine.cpp


Added Paths

branches/chromium/1410/LayoutTests/fast/forms/search/search-autoscroll-hidden-decoration-container-crash-expected.txt
branches/chromium/1410/LayoutTests/fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html
branches/chromium/1410/LayoutTests/fast/forms/search/search-hide-decoration-container-crash-expected.txt
branches/chromium/1410/LayoutTests/fast/forms/search/search-hide-decoration-container-crash.html
branches/chromium/1410/LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash-expected.txt
branches/chromium/1410/LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash.html




Diff

Copied: branches/chromium/1410/LayoutTests/fast/forms/search/search-autoscroll-hidden-decoration-container-crash-expected.txt (from rev 145239, trunk/LayoutTests/fast/forms/search/search-autoscroll-hidden-decoration-container-crash-expected.txt) (0 => 145867)

--- branches/chromium/1410/LayoutTests/fast/forms/search/search-autoscroll-hidden-decoration-container-crash-expected.txt	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/forms/search/search-autoscroll-hidden-decoration-container-crash-expected.txt	2013-03-15 02:18:45 UTC (rev 145867)
@@ -0,0 +1,2 @@
+Move the mouse over the input element and click and drag upwards to outside the bounds of the input element. If this does not crash, the test passed.
+ PASS


Copied: branches/chromium/1410/LayoutTests/fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html (from rev 145239, trunk/LayoutTests/fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html) (0 => 145867)

--- branches/chromium/1410/LayoutTests/fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html	2013-03-15 02:18:45 UTC (rev 145867)
@@ -0,0 +1,29 @@
+
+
+Move the mouse over the input element and click and drag upwards to
+outside the bounds of the input element. If this does not crash, the
+test passed.
+
+
+
+input::-webkit-textfield-decoration-container {
+display: none;
+}
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+if (window.eventSender) {
+var input = document.querySelector('input');
+var x = input.offsetLeft + input.offsetWidth / 2;
+var y = input.offsetTop + input.offsetHeight / 2;
+eventSender.mouseMoveTo(x, y);
+eventSender.mouseDown();
+eventSender.leapForward(20);
+eventSender.mouseMoveTo(x, 0);
+eventSender.mouseUp();
+document.write('PASS');
+}
+


Copied: branches/chromium/1410/LayoutTests/fast/forms/search/search-hide-decoration-container-crash-expected.txt (from rev 145239, trunk/LayoutTests/fast/forms/search/search-hide-decoration-container-crash-expected.txt) (0 => 145867)

--- branches/chromium/1410/LayoutTests/fast/forms/search/search-hide-decoration-container-crash-expected.txt	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/forms/search/search-hide-decoration-container-crash-expected.txt	2013-03-15 02:18:45 UTC (rev 145867)
@@ -0,0 +1 @@
+ PASS


Copied: branches/chromium/1410/LayoutTests/fast/forms/search/search-hide-decoration-container-crash.html (from rev 145239, trunk/LayoutTests/fast/forms/search/search-hide-decoration-container-crash.html) (0 => 145867)

--- branches/chromium/1410/LayoutTests/fast/forms/search/search-hide-decoration-container-crash.html	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/forms/search/search-hide-decoration-container-crash.html	2013-03-15 02:18:45 UTC (rev 145867)
@@ -0,0 +1,12 @@
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+input::-webkit-textfield-decoration-container {
+display: none;
+}
+
+
+PASS


Copied: branches/chromium/1410/LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash-expected.txt (from rev 145239, trunk/LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash-expected.txt) (0 => 145867)

--- branches/chromium/1410/LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash-expected.txt	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash-expected.txt	2013-03-15 02:18:45 UTC (rev 145867)
@@ -0,0 +1,2 @@
+Move the mouse over the input element and scroll using the mouse wheel. If this does not crash, the test passed.
+ PASS


Copied: branches/chromium/1410/LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash.html (from rev 145239, trunk/LayoutT

[webkit-changes] [145866] trunk

2013-03-14 Thread cfleizach

Title: [145866] trunk








Revision 145866
Author cfleiz...@apple.com
Date 2013-03-14 19:08:36 -0700 (Thu, 14 Mar 2013)


Log Message
AX: Crash when removing aria-menu item from DOM
https://bugs.webkit.org/show_bug.cgi?id=112396

Reviewed by Tim Horton.

Source/WebCore:

Prevent nil access to items in the ARIA menu flow when deleting
objects from the DOM.

Test: accessibility/menu-item-crash.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::menuButtonForMenu):

LayoutTests:

* accessibility/menu-item-crash-expected.txt: Added.
* accessibility/menu-item-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp


Added Paths

trunk/LayoutTests/accessibility/menu-item-crash-expected.txt
trunk/LayoutTests/accessibility/menu-item-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (145865 => 145866)

--- trunk/LayoutTests/ChangeLog	2013-03-15 02:02:15 UTC (rev 145865)
+++ trunk/LayoutTests/ChangeLog	2013-03-15 02:08:36 UTC (rev 145866)
@@ -1,3 +1,13 @@
+2013-03-14  Chris Fleizach  
+
+AX: Crash when removing aria-menu item from DOM
+https://bugs.webkit.org/show_bug.cgi?id=112396
+
+Reviewed by Tim Horton.
+
+* accessibility/menu-item-crash-expected.txt: Added.
+* accessibility/menu-item-crash.html: Added.
+
 2013-03-14  Hayato Ito  
 
 [Shadow]: left side of ::-webkit-distributed selector not working as expected


Added: trunk/LayoutTests/accessibility/menu-item-crash-expected.txt (0 => 145866)

--- trunk/LayoutTests/accessibility/menu-item-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/menu-item-crash-expected.txt	2013-03-15 02:08:36 UTC (rev 145866)
@@ -0,0 +1,10 @@
+This tests that deleting a ARIA menu and children do not cause a crash.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS - There was no crash when removing the ARIA menu from the DOM.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/menu-item-crash.html (0 => 145866)

--- trunk/LayoutTests/accessibility/menu-item-crash.html	(rev 0)
+++ trunk/LayoutTests/accessibility/menu-item-crash.html	2013-03-15 02:08:36 UTC (rev 145866)
@@ -0,0 +1,35 @@
+
+
+
+
+
+
+
+
+
+ a
+ a
+
+
+