[webkit-changes] [150243] trunk/Source/WebKit2
Title: [150243] trunk/Source/WebKit2
Revision 150243
Author bda...@apple.com
Date 2013-05-16 22:22:49 -0700 (Thu, 16 May 2013)
Log Message
Remove WKBundlePageGetHeaderLayer/Footer SPI
https://bugs.webkit.org/show_bug.cgi?id=116254
Reviewed by Benjamin Poulain.
We should remove the Remove WKBundlePageGetHeaderLayer/Footer SPI. It was only
recently added and have been replaced by WKBundlePageSetHeaderBanner/Footer.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.h: Removed.
* WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.mm: Removed.
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit):
(WebKit::WebPage::updateHeaderAndFooterLayersForDeviceScaleChange):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm
Removed Paths
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (150242 => 150243)
--- trunk/Source/WebKit2/ChangeLog 2013-05-17 04:34:27 UTC (rev 150242)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-17 05:22:49 UTC (rev 150243)
@@ -1,3 +1,22 @@
+2013-05-16 Beth Dakin
+
+Remove WKBundlePageGetHeaderLayer/Footer SPI
+https://bugs.webkit.org/show_bug.cgi?id=116254
+
+Reviewed by Benjamin Poulain.
+
+We should remove the Remove WKBundlePageGetHeaderLayer/Footer SPI. It was only
+recently added and have been replaced by WKBundlePageSetHeaderBanner/Footer.
+
+* WebKit2.xcodeproj/project.pbxproj:
+* WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.h: Removed.
+* WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.mm: Removed.
+* WebProcess/WebPage/WebPage.h:
+(WebPage):
+* WebProcess/WebPage/mac/WebPageMac.mm:
+(WebKit):
+(WebKit::WebPage::updateHeaderAndFooterLayersForDeviceScaleChange):
+
2013-05-14 Sam Weinig
Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (150242 => 150243)
--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2013-05-17 04:34:27 UTC (rev 150242)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2013-05-17 05:22:49 UTC (rev 150243)
@@ -609,8 +609,6 @@
935EEBA4127761D6003322B8 /* InjectedBundleBackForwardListItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 935EEB921277615D003322B8 /* InjectedBundleBackForwardListItem.h */; };
9391F2CA121B679A00EBF7E8 /* WebFrameNetworkingContext.mm in Sources */ = {isa = PBXBuildFile; fileRef = 9391F284121B38F500EBF7E8 /* WebFrameNetworkingContext.mm */; };
9391F2CB121B67AD00EBF7E8 /* WebFrameNetworkingContext.h in Headers */ = {isa = PBXBuildFile; fileRef = 9391F283121B38F500EBF7E8 /* WebFrameNetworkingContext.h */; };
- 9394AE441702B25B00344232 /* WKBundlePagePrivateMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 9394AE421702B25B00344232 /* WKBundlePagePrivateMac.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 9394AE451702B25B00344232 /* WKBundlePagePrivateMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 9394AE431702B25B00344232 /* WKBundlePagePrivateMac.mm */; };
939AE7661316E99C00AE06A6 /* WebCoreArgumentCoders.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 939AE7651316E99C00AE06A6 /* WebCoreArgumentCoders.cpp */; };
93BDEB01171DD7AF00BFEE1B /* WKPageLoadTypesPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 93BDEB00171DD7AF00BFEE1B /* WKPageLoadTypesPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
93FC67BD12D3CCF200A60610 /* DecoderAdapter.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93FC679D12D3CC7400A60610 /* DecoderAdapter.cpp */; };
@@ -2093,8 +2091,6 @@
935EEB981277616D003322B8 /* WKBundleBackForwardListItem.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKBundleBackForwardListItem.h; sourceTree = ""; };
9391F283121B38F500EBF7E8 /* WebFrameNetworkingContext.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebFrameNetworkingContext.h; sourceTree = ""; };
9391F284121B38F500EBF7E8 /* WebFrameNetworkingContext.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebFrameNetworkingContext.mm; sourceTree = ""; };
- 9394AE421702B25B00344232 /* WKBundlePagePrivateMac.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKBundlePagePrivateMac.h; sourceTree = ""; };
- 9394AE431702B25B00344232 /* WKBundlePagePrivateMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.
[webkit-changes] [150241] trunk
Title: [150241] trunk
Revision 150241
Author commit-qu...@webkit.org
Date 2013-05-16 20:39:43 -0700 (Thu, 16 May 2013)
Log Message
[EFL] inspector-protocol/page/_javascript_DialogEvents.html is failing
https://bugs.webkit.org/show_bug.cgi?id=114781
Patch by Seokju Kwon on 2013-05-16
Reviewed by Christophe Dumez.
Source/WebKit/efl:
We need to make a distinction between runBeforeUnloadConfirmPanel and confirm.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::runBeforeUnloadConfirmPanel):
* ewk/ewk_view.cpp: Add ewk_view_run_before_unload_confirm API.
(_ewk_view_smart_run_before_unload_confirm):
(ewk_view_base_smart_set):
(ewk_view_run_before_unload_confirm):
* ewk/ewk_view.h: Add smart class member function for runBeforeUnloadConfirmPanel.
* ewk/ewk_view_private.h:
Tools:
Add run_before_unload_confirm and
Print the log message with "CONFIRM NAVIGATION: " in console.
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onBeforeUnloadConfirm):
(drtViewAdd):
LayoutTests:
Unskip fast/loader/form-submission-after-beforeunload-cancel.html as well.
* platform/efl-wk1/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk1/TestExpectations
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
trunk/Source/WebKit/efl/ewk/ewk_view.h
trunk/Source/WebKit/efl/ewk/ewk_view_private.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (150240 => 150241)
--- trunk/LayoutTests/ChangeLog 2013-05-17 03:28:52 UTC (rev 150240)
+++ trunk/LayoutTests/ChangeLog 2013-05-17 03:39:43 UTC (rev 150241)
@@ -1,3 +1,14 @@
+2013-05-16 Seokju Kwon
+
+[EFL] inspector-protocol/page/_javascript_DialogEvents.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=114781
+
+Reviewed by Christophe Dumez.
+
+Unskip fast/loader/form-submission-after-beforeunload-cancel.html as well.
+
+* platform/efl-wk1/TestExpectations:
+
2013-05-16 Alexis Menard
Regression: Event#stopPropagation() does not halt bubbling for webkitTransitionEnd
Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (150240 => 150241)
--- trunk/LayoutTests/platform/efl-wk1/TestExpectations 2013-05-17 03:28:52 UTC (rev 150240)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations 2013-05-17 03:39:43 UTC (rev 150241)
@@ -216,9 +216,6 @@
webkit.org/b/87972 fast/forms/mailto/formenctype-attribute-button-html.html [ Failure ]
webkit.org/b/87972 fast/forms/mailto/formenctype-attribute-input-html.html [ Failure ]
-# EFL's DRT needs CONFIRM NAVIGATION messages
-webkit.org/b/87246 fast/loader/form-submission-after-beforeunload-cancel.html [ Failure ]
-
# New test introduced in r116694 fails
webkit.org/b/86182 fast/frames/seamless/seamless-inherited-document-style.html [ Failure ]
Modified: trunk/Source/WebKit/efl/ChangeLog (150240 => 150241)
--- trunk/Source/WebKit/efl/ChangeLog 2013-05-17 03:28:52 UTC (rev 150240)
+++ trunk/Source/WebKit/efl/ChangeLog 2013-05-17 03:39:43 UTC (rev 150241)
@@ -1,3 +1,21 @@
+2013-05-16 Seokju Kwon
+
+[EFL] inspector-protocol/page/_javascript_DialogEvents.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=114781
+
+Reviewed by Christophe Dumez.
+
+We need to make a distinction between runBeforeUnloadConfirmPanel and confirm.
+
+* WebCoreSupport/ChromeClientEfl.cpp:
+(WebCore::ChromeClientEfl::runBeforeUnloadConfirmPanel):
+* ewk/ewk_view.cpp: Add ewk_view_run_before_unload_confirm API.
+(_ewk_view_smart_run_before_unload_confirm):
+(ewk_view_base_smart_set):
+(ewk_view_run_before_unload_confirm):
+* ewk/ewk_view.h: Add smart class member function for runBeforeUnloadConfirmPanel.
+* ewk/ewk_view_private.h:
+
2013-05-16 Andreas Kling
Page::chrome() should return a reference.
Modified: trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp (150240 => 150241)
--- trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2013-05-17 03:28:52 UTC (rev 150240)
+++ trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2013-05-17 03:39:43 UTC (rev 150241)
@@ -270,7 +270,7 @@
bool ChromeClientEfl::runBeforeUnloadConfirmPanel(const String& message, Frame* frame)
{
-return runJavaScriptConfirm(frame, message);
+return ewk_view_run_before_unload_confirm(m_view, kit(frame), message.utf8().data());
}
void ChromeClientEfl::addMessageToConsole(MessageSource, MessageLevel, const String& message,
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (150240 => 150241)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2013-05-17 03:28:52 UTC (rev 150240)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2013-05-17 03:39:43 UTC (rev 150241)
@@ -655,6 +655,12 @@
return true;
}
+static Eina_Bool _ewk_view_smart_run_before_unload_confirm(E
[webkit-changes] [150240] trunk/Source/WebCore
Title: [150240] trunk/Source/WebCore Revision 150240 Author commit-qu...@webkit.org Date 2013-05-16 20:28:52 -0700 (Thu, 16 May 2013) Log Message Add stubs for ContextMenu and ContextMenuItem https://bugs.webkit.org/show_bug.cgi?id=116235 Patch by Jesus Sanchez-Palencia on 2013-05-16 Reviewed by Antonio Gomes. No new tests needed, only a refactor. Add ContextMenuNone.cpp and ContextMenuItemNone.cpp so ports using ENABLE(CROSS_PLATFORM_CONTEXT_MENU) don't need to replicate these stubs. * PlatformEfl.cmake: * Target.pri: * platform/ContextMenuNone.cpp: Added. (WebCore): (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::getContextMenuItems): (WebCore::ContextMenu::createPlatformContextMenuFromItems): (WebCore::ContextMenu::platformContextMenu): * platform/ContextMenuItemNone.cpp: Added. (WebCore): (WebCore::ContextMenuItem::platformContextMenuItem): * platform/efl/ContextMenuEfl.cpp: Removed. * platform/efl/ContextMenuItemEfl.cpp: Removed. * platform/qt/ContextMenuQt.cpp: Removed. * platform/qt/ContextMenuItemQt.cpp: Removed. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebCore/Target.pri Added Paths trunk/Source/WebCore/platform/ContextMenuItemNone.cpp trunk/Source/WebCore/platform/ContextMenuNone.cpp Removed Paths trunk/Source/WebCore/platform/efl/ContextMenuEfl.cpp trunk/Source/WebCore/platform/efl/ContextMenuItemEfl.cpp trunk/Source/WebCore/platform/qt/ContextMenuItemQt.cpp trunk/Source/WebCore/platform/qt/ContextMenuQt.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (150239 => 150240) --- trunk/Source/WebCore/ChangeLog 2013-05-17 03:26:58 UTC (rev 150239) +++ trunk/Source/WebCore/ChangeLog 2013-05-17 03:28:52 UTC (rev 150240) @@ -1,3 +1,32 @@ +2013-05-16 Jesus Sanchez-Palencia + +Add stubs for ContextMenu and ContextMenuItem +https://bugs.webkit.org/show_bug.cgi?id=116235 + +Reviewed by Antonio Gomes. + +No new tests needed, only a refactor. + +Add ContextMenuNone.cpp and ContextMenuItemNone.cpp +so ports using ENABLE(CROSS_PLATFORM_CONTEXT_MENU) don't +need to replicate these stubs. + +* PlatformEfl.cmake: +* Target.pri: +* platform/ContextMenuNone.cpp: Added. +(WebCore): +(WebCore::ContextMenu::ContextMenu): +(WebCore::ContextMenu::getContextMenuItems): +(WebCore::ContextMenu::createPlatformContextMenuFromItems): +(WebCore::ContextMenu::platformContextMenu): +* platform/ContextMenuItemNone.cpp: Added. +(WebCore): +(WebCore::ContextMenuItem::platformContextMenuItem): +* platform/efl/ContextMenuEfl.cpp: Removed. +* platform/efl/ContextMenuItemEfl.cpp: Removed. +* platform/qt/ContextMenuQt.cpp: Removed. +* platform/qt/ContextMenuItemQt.cpp: Removed. + 2013-05-16 Alexis Menard Regression: Event#stopPropagation() does not halt bubbling for webkitTransitionEnd Modified: trunk/Source/WebCore/PlatformEfl.cmake (150239 => 150240) --- trunk/Source/WebCore/PlatformEfl.cmake 2013-05-17 03:26:58 UTC (rev 150239) +++ trunk/Source/WebCore/PlatformEfl.cmake 2013-05-17 03:28:52 UTC (rev 150240) @@ -53,8 +53,8 @@ platform/efl/AsyncFileSystemEfl.cpp platform/efl/BatteryProviderEfl.cpp platform/efl/ClipboardEfl.cpp -platform/efl/ContextMenuEfl.cpp -platform/efl/ContextMenuItemEfl.cpp +platform/ContextMenuNone.cpp +platform/ContextMenuItemNone.cpp platform/efl/CursorEfl.cpp platform/efl/DragDataEfl.cpp platform/efl/DragImageEfl.cpp Modified: trunk/Source/WebCore/Target.pri (150239 => 150240) --- trunk/Source/WebCore/Target.pri 2013-05-17 03:26:58 UTC (rev 150239) +++ trunk/Source/WebCore/Target.pri 2013-05-17 03:28:52 UTC (rev 150240) @@ -2919,8 +2919,8 @@ platform/ContextMenu.cpp \ platform/ContextMenuItem.cpp \ platform/qt/ClipboardQt.cpp \ -platform/qt/ContextMenuItemQt.cpp \ -platform/qt/ContextMenuQt.cpp \ +platform/ContextMenuItemNone.cpp \ +platform/ContextMenuNone.cpp \ platform/qt/CursorQt.cpp \ platform/qt/DragDataQt.cpp \ platform/qt/DragImageQt.cpp \ Copied: trunk/Source/WebCore/platform/ContextMenuItemNone.cpp (from rev 150239, trunk/Source/WebCore/platform/qt/ContextMenuItemQt.cpp) (0 => 150240) --- trunk/Source/WebCore/platform/ContextMenuItemNone.cpp (rev 0) +++ trunk/Source/WebCore/platform/ContextMenuItemNone.cpp 2013-05-17 03:28:52 UTC (rev 150240) @@ -0,0 +1,43 @@ +/* + * Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies). + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyrig
[webkit-changes] [150239] trunk
Title: [150239] trunk Revision 150239 Author ale...@webkit.org Date 2013-05-16 20:26:58 -0700 (Thu, 16 May 2013) Log Message Regression: Event#stopPropagation() does not halt bubbling for webkitTransitionEnd https://bugs.webkit.org/show_bug.cgi?id=115656 Reviewed by Darin Adler. Source/WebCore: If we create a prefixed event to dispatch it (in the case we have only prefixed event listeners in client's code) then we need to make sure to keep it in sync with the original unprefixed event after it has been dispatched. While being dispatched the event can be modified by client's code and when propagated back to outer elements, attributes were not updated. This patch changes the old design of creating a separate event for the prefixed case and now change the type of the event (so the name) before dispatching it, keeping the attributes if changed and then rename it back to unprefixed when the dispatching is finished. Tests: transitions/transition-end-event-prefixed-01.html transitions/transition-end-event-prefixed-02.html transitions/transition-end-event-prefixed-03.html * dom/Event.h: (WebCore::Event::setType): * dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners): LayoutTests: Added new tests to cover the bug. * transitions/transition-end-event-prefixed-03-expected.txt: Added. * transitions/transition-end-event-prefixed-03.html: Added. * transitions/transition-end-event-prefixed-02-expected.txt: Added. * transitions/transition-end-event-prefixed-02.html: Added. * transitions/transition-end-event-prefixed-01-expected.txt: Added. * transitions/transition-end-event-prefixed-01.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Event.h trunk/Source/WebCore/dom/EventTarget.cpp Added Paths trunk/LayoutTests/transitions/transition-end-event-prefixed-01-expected.txt trunk/LayoutTests/transitions/transition-end-event-prefixed-01.html trunk/LayoutTests/transitions/transition-end-event-prefixed-02-expected.txt trunk/LayoutTests/transitions/transition-end-event-prefixed-02.html trunk/LayoutTests/transitions/transition-end-event-prefixed-03-expected.txt trunk/LayoutTests/transitions/transition-end-event-prefixed-03.html Diff Modified: trunk/LayoutTests/ChangeLog (150238 => 150239) --- trunk/LayoutTests/ChangeLog 2013-05-17 03:20:24 UTC (rev 150238) +++ trunk/LayoutTests/ChangeLog 2013-05-17 03:26:58 UTC (rev 150239) @@ -1,3 +1,19 @@ +2013-05-16 Alexis Menard + +Regression: Event#stopPropagation() does not halt bubbling for webkitTransitionEnd +https://bugs.webkit.org/show_bug.cgi?id=115656 + +Reviewed by Darin Adler. + +Added new tests to cover the bug. + +* transitions/transition-end-event-prefixed-03-expected.txt: Added. +* transitions/transition-end-event-prefixed-03.html: Added. +* transitions/transition-end-event-prefixed-02-expected.txt: Added. +* transitions/transition-end-event-prefixed-02.html: Added. +* transitions/transition-end-event-prefixed-01-expected.txt: Added. +* transitions/transition-end-event-prefixed-01.html: Added. + 2013-05-16 Ryosuke Niwa Add failing test expectations to http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html per bug 116259. Added: trunk/LayoutTests/transitions/transition-end-event-prefixed-01-expected.txt (0 => 150239) --- trunk/LayoutTests/transitions/transition-end-event-prefixed-01-expected.txt (rev 0) +++ trunk/LayoutTests/transitions/transition-end-event-prefixed-01-expected.txt 2013-05-17 03:26:58 UTC (rev 150239) @@ -0,0 +1,22 @@ +Test to make sure that if prefixed transition events are modified we correctly modify unprefixed events. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS successfullyParsed is true + +TEST COMPLETE +PASS transitionEventContainer.type is transitionEventBox.type +PASS transitionEventContainer.bubbles is transitionEventBox.bubbles +PASS transitionEventContainer.timeStamp is transitionEventBox.timeStamp +PASS transitionEventContainer.cancelable is transitionEventBox.cancelable +PASS transitionEventContainer.srcElement is transitionEventBox.srcElement +PASS transitionEventContainer.returnValue is transitionEventBox.returnValue +PASS transitionEventContainer.cancelBubble is transitionEventBox.cancelBubble +PASS transitionEventContainer.defaultPrevented is transitionEventBox.defaultPrevented +PASS transitionEventContainer.target is transitionEventBox.target +PASS transitionEventContainer.currentTarget is testContainer +PASS transitionEventContainer.pseudoElement is transitionEventBox.pseudoElement +PASS transitionEventContainer.elapsedTime is transitionEventBox.elapsedTime +PASS transitionEventContainer.propertyName is transitionEventBox.propertyName + Added: trunk/LayoutTests/transitions/transition-end-event-prefixed-01.html (0 => 150239) --- trunk/Lay
[webkit-changes] [150238] trunk/Source/WebCore
Title: [150238] trunk/Source/WebCore
Revision 150238
Author mifen...@rim.com
Date 2013-05-16 20:20:24 -0700 (Thu, 16 May 2013)
Log Message
[BlackBerry] Strip invoke URLs when writing to the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=116226
Reviewed by Rob Buis.
PR 333516.
Invoke URLs should not be included in the paste data.
Internally Reviewed by Gen Mak.
* platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::writeSelection):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (150237 => 150238)
--- trunk/Source/WebCore/ChangeLog 2013-05-17 03:18:00 UTC (rev 150237)
+++ trunk/Source/WebCore/ChangeLog 2013-05-17 03:20:24 UTC (rev 150238)
@@ -1,3 +1,19 @@
+2013-05-16 Mike Fenton
+
+[BlackBerry] Strip invoke URLs when writing to the clipboard.
+https://bugs.webkit.org/show_bug.cgi?id=116226
+
+Reviewed by Rob Buis.
+
+PR 333516.
+
+Invoke URLs should not be included in the paste data.
+
+Internally Reviewed by Gen Mak.
+
+* platform/blackberry/PasteboardBlackBerry.cpp:
+(WebCore::Pasteboard::writeSelection):
+
2013-05-16 Eduardo Lima Mitev
Missing UNUSED_PARAM macro for textPosition argument in WebKitAccessibleInterfaceText
Modified: trunk/Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp (150237 => 150238)
--- trunk/Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp 2013-05-17 03:18:00 UTC (rev 150237)
+++ trunk/Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp 2013-05-17 03:20:24 UTC (rev 150238)
@@ -65,6 +65,12 @@
{
WTF::String text = shouldSerializeSelectedTextForClipboard == IncludeImageAltTextForClipboard ? frame->editor()->selectedTextForClipboard() : frame->editor()->selectedText();
WTF::String html = createMarkup(selectedRange, 0, AnnotateForInterchange);
+DEFINE_STATIC_LOCAL(AtomicString, invokeString, ("href=""
+size_t startOfInvoke = html.find(invokeString);
+if (startOfInvoke != notFound) {
+size_t endOfInvoke = html.find("\"", startOfInvoke + invokeString.length()) + 1;
+html.remove(startOfInvoke, endOfInvoke - startOfInvoke);
+}
WTF::String url = ""
BlackBerry::Platform::Clipboard::write(text, html, url);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150237] trunk/Tools
Title: [150237] trunk/Tools
Revision 150237
Author commit-qu...@webkit.org
Date 2013-05-16 20:18:00 -0700 (Thu, 16 May 2013)
Log Message
Fix Analyze ChangeLog's entry processing
https://bugs.webkit.org/show_bug.cgi?id=116219
Patch by Peter Gal on 2013-05-16
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/tool/commands/analyzechangelog.py:
(ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/analyzechangelog.py
Diff
Modified: trunk/Tools/ChangeLog (150236 => 150237)
--- trunk/Tools/ChangeLog 2013-05-17 03:17:23 UTC (rev 150236)
+++ trunk/Tools/ChangeLog 2013-05-17 03:18:00 UTC (rev 150237)
@@ -1,3 +1,13 @@
+2013-05-16 Peter Gal
+
+Fix Analyze ChangeLog's entry processing
+https://bugs.webkit.org/show_bug.cgi?id=116219
+
+Reviewed by Ryosuke Niwa.
+
+* Scripts/webkitpy/tool/commands/analyzechangelog.py:
+(ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
+
2013-05-16 Hyungchan Kim
[Qt] UrlLoader::loadNext is broken in MiniBrowser
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/analyzechangelog.py (150236 => 150237)
--- trunk/Tools/Scripts/webkitpy/tool/commands/analyzechangelog.py 2013-05-17 03:17:23 UTC (rev 150236)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/analyzechangelog.py 2013-05-17 03:18:00 UTC (rev 150237)
@@ -180,6 +180,7 @@
def _analyze_entries(self, entries, changelog_path):
dirname = self._filesystem.dirname(changelog_path)
+i = 0
for i, entry in enumerate(entries):
self._print_status('(%s) entries' % i)
assert(entry.authors())
@@ -201,6 +202,5 @@
self._summary['reviewed' if reviewers_for_entry else 'unreviewed'] += 1
-i += 1
self._print_status('(%s) entries' % i)
return i
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150236] trunk/Source/WebCore
Title: [150236] trunk/Source/WebCore Revision 150236 Author commit-qu...@webkit.org Date 2013-05-16 20:17:23 -0700 (Thu, 16 May 2013) Log Message Missing UNUSED_PARAM macro for textPosition argument in WebKitAccessibleInterfaceText https://bugs.webkit.org/show_bug.cgi?id=116230 Patch by Eduardo Lima Mitev on 2013-05-16 Reviewed by Chris Fleizach. No new functionality, no new tests. * accessibility/atk/WebKitAccessibleInterfaceText.cpp: (webkitAccessibleTextGetTextForOffset): List textPosition argument as unused parameter for all platforms except GTK. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (150235 => 150236) --- trunk/Source/WebCore/ChangeLog 2013-05-17 03:15:55 UTC (rev 150235) +++ trunk/Source/WebCore/ChangeLog 2013-05-17 03:17:23 UTC (rev 150236) @@ -1,3 +1,16 @@ +2013-05-16 Eduardo Lima Mitev + +Missing UNUSED_PARAM macro for textPosition argument in WebKitAccessibleInterfaceText +https://bugs.webkit.org/show_bug.cgi?id=116230 + +Reviewed by Chris Fleizach. + +No new functionality, no new tests. + +* accessibility/atk/WebKitAccessibleInterfaceText.cpp: +(webkitAccessibleTextGetTextForOffset): List textPosition argument as +unused parameter for all platforms except GTK. + 2013-05-16 Jaehun Lim Frame flattening prevents in from having scrollbars Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (150235 => 150236) --- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-05-17 03:15:55 UTC (rev 150235) +++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-05-17 03:17:23 UTC (rev 150236) @@ -603,6 +603,7 @@ UNUSED_PARAM(text); UNUSED_PARAM(offset); UNUSED_PARAM(boundaryType); +UNUSED_PARAM(textPosition); UNUSED_PARAM(startOffset); UNUSED_PARAM(endOffset); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150235] trunk/LayoutTests
Title: [150235] trunk/LayoutTests Revision 150235 Author rn...@webkit.org Date 2013-05-16 20:15:55 -0700 (Thu, 16 May 2013) Log Message Add failing test expectations to http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html per bug 116259. * platform/efl/TestExpectations: * platform/gtk/TestExpectations: * platform/mac-wk2/TestExpectations: * platform/qt/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/LayoutTests/platform/qt/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (150234 => 150235) --- trunk/LayoutTests/ChangeLog 2013-05-17 03:14:09 UTC (rev 150234) +++ trunk/LayoutTests/ChangeLog 2013-05-17 03:15:55 UTC (rev 150235) @@ -1,3 +1,12 @@ +2013-05-16 Ryosuke Niwa + +Add failing test expectations to http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html per bug 116259. + +* platform/efl/TestExpectations: +* platform/gtk/TestExpectations: +* platform/mac-wk2/TestExpectations: +* platform/qt/TestExpectations: + 2013-05-16 Jaehun Lim Frame flattening prevents in from having scrollbars Modified: trunk/LayoutTests/platform/efl/TestExpectations (150234 => 150235) --- trunk/LayoutTests/platform/efl/TestExpectations 2013-05-17 03:14:09 UTC (rev 150234) +++ trunk/LayoutTests/platform/efl/TestExpectations 2013-05-17 03:15:55 UTC (rev 150235) @@ -1884,3 +1884,5 @@ webkit.org/b/115439 fast/text/complex-initial-advance.html [ ImageOnlyFailure ] webkit.org/b/115440 svg/stroke/animated-non-scaling-stroke.html [ ImageOnlyFailure ] + +webkit.org/b/116259 http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html [ Failure ] Modified: trunk/LayoutTests/platform/gtk/TestExpectations (150234 => 150235) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-05-17 03:14:09 UTC (rev 150234) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-05-17 03:15:55 UTC (rev 150235) @@ -1457,6 +1457,8 @@ webkit.org/b/116153 fast/css/text-overflow-ellipsis-full-truncate-rtl.html [ ImageOnlyFailure ] +webkit.org/b/116259 http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html [ Failure ] + # # End of Tests failing # Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (150234 => 150235) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2013-05-17 03:14:09 UTC (rev 150234) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2013-05-17 03:15:55 UTC (rev 150235) @@ -271,6 +271,8 @@ webkit.org/b/114573 fast/repaint/selection-gap-fixed-child.html [ Failure ] webkit.org/b/114573 fast/repaint/selection-gap-flipped-fixed-child.html [ Failure ] +webkit.org/b/116259 http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html [ Failure ] + ### END OF (1) Classified failures with bug reports Modified: trunk/LayoutTests/platform/qt/TestExpectations (150234 => 150235) --- trunk/LayoutTests/platform/qt/TestExpectations 2013-05-17 03:14:09 UTC (rev 150234) +++ trunk/LayoutTests/platform/qt/TestExpectations 2013-05-17 03:15:55 UTC (rev 150235) @@ -2759,3 +2759,5 @@ # Reference test fast/sub-pixel/float-wrap-zoom.html fails webkit.org/b/114800 fast/sub-pixel/float-wrap-zoom.html [ ImageOnlyFailure ] + +webkit.org/b/116259 http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150234] trunk
Title: [150234] trunk
Revision 150234
Author commit-qu...@webkit.org
Date 2013-05-16 20:14:09 -0700 (Thu, 16 May 2013)
Log Message
Source/WebCore: Frame flattening prevents in from having scrollbars
https://bugs.webkit.org/show_bug.cgi?id=115884
Patch by Jaehun Lim on 2013-05-16
Reviewed by Antonio Gomes.
Frame flattening should be applied when the frame owner is frame or iframe. But when
the frame owner is object element, frame flattening prevents it from having scrollbars.
In this situation, we can't scroll the html document in object element.
This patch adds two helper functions to verify flattening conditions.
Test: fast/frames/flattening/scrolling-in-object.html
* page/FrameView.cpp:
(WebCore::frameFlatteningEnabled): Added. Helper to check whether flattening is enabled or not.
(WebCore::supportsFrameFlattening): Added. Helper to check whether the frame owner is or .
(WebCore::FrameView::avoidScrollbarCreation):
(WebCore::FrameView::calculateScrollbarModesForLayout): Use frameFlatteningEnabled().
(WebCore::FrameView::layout): Use frameFlatteningEnabled().
(WebCore::FrameView::isInChildFrameWithFrameFlattening): Use frameFlatteningEnabled().
LayoutTests: Frame flattening prevents in from having scrollbars
https://bugs.webkit.org/show_bug.cgi?id=115884
Patch by Jaehun Lim on 2013-05-16
Reviewed by Antonio Gomes.
Frame flattening should be applied when the frame owner is frame or iframe. But when
the frame owner is object element, frame flattening prevents it from having scrollbars.
In this situation, we can't scroll the html document in object element.
This patch adds two helper functions to verify flattening conditions.
* fast/frames/flattening/scrolling-in-object-expected.html: Added.
* fast/frames/flattening/scrolling-in-object.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
Added Paths
trunk/LayoutTests/fast/frames/flattening/scrolling-in-object-expected.html
trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html
Diff
Modified: trunk/LayoutTests/ChangeLog (150233 => 150234)
--- trunk/LayoutTests/ChangeLog 2013-05-17 02:53:15 UTC (rev 150233)
+++ trunk/LayoutTests/ChangeLog 2013-05-17 03:14:09 UTC (rev 150234)
@@ -1,3 +1,19 @@
+2013-05-16 Jaehun Lim
+
+Frame flattening prevents in from having scrollbars
+https://bugs.webkit.org/show_bug.cgi?id=115884
+
+Reviewed by Antonio Gomes.
+
+Frame flattening should be applied when the frame owner is frame or iframe. But when
+the frame owner is object element, frame flattening prevents it from having scrollbars.
+In this situation, we can't scroll the html document in object element.
+
+This patch adds two helper functions to verify flattening conditions.
+
+* fast/frames/flattening/scrolling-in-object-expected.html: Added.
+* fast/frames/flattening/scrolling-in-object.html: Added.
+
2013-05-16 Lamarque V. Souza
[WebSocket] Update pywebsocket to r760
Added: trunk/LayoutTests/fast/frames/flattening/scrolling-in-object-expected.html (0 => 150234)
--- trunk/LayoutTests/fast/frames/flattening/scrolling-in-object-expected.html (rev 0)
+++ trunk/LayoutTests/fast/frames/flattening/scrolling-in-object-expected.html 2013-05-17 03:14:09 UTC (rev 150234)
@@ -0,0 +1,21 @@
+
+
+
+
+
+function runTest()
+{
+document.getElementById('targetDiv').scrollIntoView('true');
+}
+
+
+
+
+
+
+
+">
+
+
+
\ No newline at end of file
Added: trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html (0 => 150234)
--- trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html (rev 0)
+++ trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html 2013-05-17 03:14:09 UTC (rev 150234)
@@ -0,0 +1,33 @@
+
+
+
+if (window.testRunner && window.internals) {
+testRunner.waitUntilDone();
+internals.settings.setFrameFlatteningEnabled(true);
+}
+
+function runTest()
+{
+if (window.eventSender && window.testRunner) {
+var element = document.getElementById('targetObject');
+var startX = element.offsetLeft + element.offsetWidth / 2;
+var startY = element.offsetTop + element.offsetHeight / 2;
+eventSender.mouseMoveTo(startX, startY);
+eventSender.mouseScrollBy(0, -4);
+testRunner.notifyDone();
+}
+}
+
+
+
+
+
+
[webkit-changes] [150233] trunk/Source/WebKit/blackberry
Title: [150233] trunk/Source/WebKit/blackberry
Revision 150233
Author mifen...@rim.com
Date 2013-05-16 19:53:15 -0700 (Thu, 16 May 2013)
Log Message
[BlackBerry] Optimize caret bounds calculation when leaving an input field.
https://bugs.webkit.org/show_bug.cgi?id=116224
Reviewed by Rob Buis.
PR 340132.
If the caret is no longer active in the field, do not allow it
to go into the single line input logic and calculate the node
bounding box.
Internally Reviewed By Gen Mak
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (150232 => 150233)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-05-17 02:50:22 UTC (rev 150232)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-05-17 02:53:15 UTC (rev 150233)
@@ -1,3 +1,21 @@
+2013-05-16 Mike Fenton
+
+[BlackBerry] Optimize caret bounds calculation when leaving an input field.
+https://bugs.webkit.org/show_bug.cgi?id=116224
+
+Reviewed by Rob Buis.
+
+PR 340132.
+
+If the caret is no longer active in the field, do not allow it
+to go into the single line input logic and calculate the node
+bounding box.
+
+Internally Reviewed By Gen Mak
+
+* WebKitSupport/SelectionHandler.cpp:
+(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
+
2013-05-16 Mary Wu
[BlackBerry] Unable to download blob resource
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (150232 => 150233)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-05-17 02:50:22 UTC (rev 150232)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-05-17 02:53:15 UTC (rev 150233)
@@ -1303,7 +1303,7 @@
"SelectionHandler::caretPositionChanged caret Rect %s",
Platform::IntRect(caretLocation).toString().c_str());
-bool isSingleLineInput = !m_webPage->m_inputHandler->isMultilineInputMode();
+bool isSingleLineInput = m_caretActive && !m_webPage->m_inputHandler->isMultilineInputMode();
WebCore::IntRect nodeBoundingBox = isSingleLineInput ? m_webPage->m_inputHandler->boundingBoxForInputField() : WebCore::IntRect();
if (!nodeBoundingBox.isEmpty()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150232] trunk/Source/WebKit2
Title: [150232] trunk/Source/WebKit2 Revision 150232 Author commit-qu...@webkit.org Date 2013-05-16 19:50:22 -0700 (Thu, 16 May 2013) Log Message [GTK] Fix memory leak in WebKitBackForwardList https://bugs.webkit.org/show_bug.cgi?id=116222 Patch by Manuel Rego Casasnovas on 2013-05-16 Reviewed by Carlos Garcia Campos. Due to the use of leakRef() the ImmutableArray is not being released automatically. Adding a local variable in the methods to make sure that the ImmutableArray is freed. * UIProcess/API/gtk/WebKitBackForwardList.cpp: (webkit_back_forward_list_get_back_list_with_limit): Add local variable RefPtr and pass the ImmutableArray to WebKitBackForwardList::webkitBackForwardListCreateList() using RefPtr::get(). (webkit_back_forward_list_get_forward_list_with_limit): Ditto. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (150231 => 150232) --- trunk/Source/WebKit2/ChangeLog 2013-05-17 02:47:20 UTC (rev 150231) +++ trunk/Source/WebKit2/ChangeLog 2013-05-17 02:50:22 UTC (rev 150232) @@ -1,3 +1,21 @@ +2013-05-16 Manuel Rego Casasnovas + +[GTK] Fix memory leak in WebKitBackForwardList +https://bugs.webkit.org/show_bug.cgi?id=116222 + +Reviewed by Carlos Garcia Campos. + +Due to the use of leakRef() the ImmutableArray is not being released +automatically. Adding a local variable in the methods to make sure that +the ImmutableArray is freed. + +* UIProcess/API/gtk/WebKitBackForwardList.cpp: +(webkit_back_forward_list_get_back_list_with_limit): Add local variable +RefPtr and pass the ImmutableArray to +WebKitBackForwardList::webkitBackForwardListCreateList() using +RefPtr::get(). +(webkit_back_forward_list_get_forward_list_with_limit): Ditto. + 2013-05-16 Commit Queue Unreviewed, rolling out r150034. Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp (150231 => 150232) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp 2013-05-17 02:47:20 UTC (rev 150231) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp 2013-05-17 02:50:22 UTC (rev 150232) @@ -252,7 +252,8 @@ g_return_val_if_fail(WEBKIT_IS_BACK_FORWARD_LIST(backForwardList), 0); WebKitBackForwardListPrivate* priv = backForwardList->priv; -return webkitBackForwardListCreateList(backForwardList, priv->backForwardItems->backListAsImmutableArrayWithLimit(limit).leakRef()); +RefPtr immutableArray = priv->backForwardItems->backListAsImmutableArrayWithLimit(limit); +return webkitBackForwardListCreateList(backForwardList, immutableArray.get()); } /** @@ -282,5 +283,6 @@ g_return_val_if_fail(WEBKIT_IS_BACK_FORWARD_LIST(backForwardList), 0); WebKitBackForwardListPrivate* priv = backForwardList->priv; -return webkitBackForwardListCreateList(backForwardList, priv->backForwardItems->forwardListAsImmutableArrayWithLimit(limit).leakRef()); +RefPtr immutableArray = priv->backForwardItems->forwardListAsImmutableArrayWithLimit(limit); +return webkitBackForwardListCreateList(backForwardList, immutableArray.get()); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150231] trunk/Source/WebCore
Title: [150231] trunk/Source/WebCore
Revision 150231
Author par...@webkit.org
Date 2013-05-16 19:47:20 -0700 (Thu, 16 May 2013)
Log Message
Port functions for pathhandling to Windows CE in FileSystemWin
https://bugs.webkit.org/show_bug.cgi?id=116208
Reviewed by Darin Adler.
This will allow us to remove FileSystemWinCE in a next step.
* platform/win/FileSystemWin.cpp:
(WebCore::pathByAppendingComponent):
(WebCore::pathGetFileName):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/win/FileSystemWin.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (150230 => 150231)
--- trunk/Source/WebCore/ChangeLog 2013-05-17 02:46:25 UTC (rev 150230)
+++ trunk/Source/WebCore/ChangeLog 2013-05-17 02:47:20 UTC (rev 150231)
@@ -1,3 +1,16 @@
+2013-05-16 Patrick Gansterer
+
+Port functions for pathhandling to Windows CE in FileSystemWin
+https://bugs.webkit.org/show_bug.cgi?id=116208
+
+Reviewed by Darin Adler.
+
+This will allow us to remove FileSystemWinCE in a next step.
+
+* platform/win/FileSystemWin.cpp:
+(WebCore::pathByAppendingComponent):
+(WebCore::pathGetFileName):
+
2013-05-16 Tim Horton
PDFPlugins don't load when plugins are disabled, but they should
Modified: trunk/Source/WebCore/platform/win/FileSystemWin.cpp (150230 => 150231)
--- trunk/Source/WebCore/platform/win/FileSystemWin.cpp 2013-05-17 02:46:25 UTC (rev 150230)
+++ trunk/Source/WebCore/platform/win/FileSystemWin.cpp 2013-05-17 02:47:20 UTC (rev 150231)
@@ -137,6 +137,16 @@
{
Vector buffer(MAX_PATH);
+#if OS(WINCE)
+buffer.append(path.characters(), path.length());
+
+UChar lastPathCharacter = path[path.length() - 1];
+if (lastPathCharacter != L'\\' && lastPathCharacter != L'/' && component[0] != L'\\' && component[0] != L'/')
+buffer.append(PlatformFilePathSeparator);
+
+buffer.append(component.characters(), component.length());
+buffer.shrinkToFit();
+#else
if (path.length() + 1 > buffer.size())
return String();
@@ -148,6 +158,7 @@
return String();
buffer.resize(wcslen(buffer.data()));
+#endif
return String::adopt(buffer);
}
@@ -190,7 +201,24 @@
String pathGetFileName(const String& path)
{
+#if OS(WINCE)
+size_t positionSlash = path.reverseFind('/');
+size_t positionBackslash = path.reverseFind('\\');
+
+size_t position;
+if (positionSlash == notFound)
+position = positionBackslash;
+else if (positionBackslash == notFound)
+position = positionSlash;
+else
+position = std::max(positionSlash, positionBackslash);
+
+if (position == notFound)
+return path;
+return path.substring(position + 1);
+#else
return String(::PathFindFileName(String(path).charactersWithNullTermination()));
+#endif
}
String directoryName(const String& path)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150230] trunk/Source
Title: [150230] trunk/Source Revision 150230 Author rn...@webkit.org Date 2013-05-16 19:46:25 -0700 (Thu, 16 May 2013) Log Message Unreviewed, rolling out r150034. http://trac.webkit.org/changeset/150034 https://bugs.webkit.org/show_bug.cgi?id=116257 This work around doesn't work due to another bug NSUndoManager has (Requested by rniwa on #webkit). Patch by Commit Queue on 2013-05-16 Source/WebKit/mac: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::registerUndoOrRedoStep): Source/WebKit2: * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::registerEditCommand): Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (150229 => 150230) --- trunk/Source/WebKit/mac/ChangeLog 2013-05-17 02:44:43 UTC (rev 150229) +++ trunk/Source/WebKit/mac/ChangeLog 2013-05-17 02:46:25 UTC (rev 150230) @@ -1,3 +1,15 @@ +2013-05-16 Commit Queue + +Unreviewed, rolling out r150034. +http://trac.webkit.org/changeset/150034 +https://bugs.webkit.org/show_bug.cgi?id=116257 + +This work around doesn't work due to another bug NSUndoManager +has (Requested by rniwa on #webkit). + +* WebCoreSupport/WebEditorClient.mm: +(WebEditorClient::registerUndoOrRedoStep): + 2013-05-16 Tim Horton PDFPlugins don't load when plugins are disabled, but they should Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm (150229 => 150230) --- trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2013-05-17 02:44:43 UTC (rev 150229) +++ trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2013-05-17 02:46:25 UTC (rev 150230) @@ -544,11 +544,9 @@ NSUndoManager *undoManager = [m_webView undoManager]; NSString *actionName = undoNameForEditAction(step->editingAction()); WebUndoStep *webEntry = [WebUndoStep stepWithUndoStep:step]; -[undoManager beginUndoGrouping]; [undoManager registerUndoWithTarget:m_undoTarget.get() selector:(isRedo ? @selector(redoEditing:) : @selector(undoEditing:)) object:webEntry]; if (actionName) [undoManager setActionName:actionName]; -[undoManager endUndoGrouping]; m_haveUndoRedoOperations = YES; } Modified: trunk/Source/WebKit2/ChangeLog (150229 => 150230) --- trunk/Source/WebKit2/ChangeLog 2013-05-17 02:44:43 UTC (rev 150229) +++ trunk/Source/WebKit2/ChangeLog 2013-05-17 02:46:25 UTC (rev 150230) @@ -1,3 +1,15 @@ +2013-05-16 Commit Queue + +Unreviewed, rolling out r150034. +http://trac.webkit.org/changeset/150034 +https://bugs.webkit.org/show_bug.cgi?id=116257 + +This work around doesn't work due to another bug NSUndoManager +has (Requested by rniwa on #webkit). + +* UIProcess/API/mac/PageClientImpl.mm: +(WebKit::PageClientImpl::registerEditCommand): + 2013-05-16 Tim Horton PDFPlugins don't load when plugins are disabled, but they should Modified: trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm (150229 => 150230) --- trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2013-05-17 02:44:43 UTC (rev 150229) +++ trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2013-05-17 02:46:25 UTC (rev 150230) @@ -286,11 +286,9 @@ String actionName = WebEditCommandProxy::nameForEditAction(command->editAction()); NSUndoManager *undoManager = [m_wkView undoManager]; -[undoManager beginUndoGrouping]; [undoManager registerUndoWithTarget:m_undoTarget.get() selector:((undoOrRedo == WebPageProxy::Undo) ? @selector(undoEditing:) : @selector(redoEditing:)) object:commandObjC.get()]; if (!actionName.isEmpty()) [undoManager setActionName:(NSString *)actionName]; -[undoManager endUndoGrouping]; } void PageClientImpl::clearAllEditCommands() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150229] trunk/Tools
Title: [150229] trunk/Tools
Revision 150229
Author commit-qu...@webkit.org
Date 2013-05-16 19:44:43 -0700 (Thu, 16 May 2013)
Log Message
[Qt] UrlLoader::loadNext is broken in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=116099
Patch by Hyungchan Kim on 2013-05-16
Reviewed by Jocelyn Turcotte.
QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
are not available any more. So, UrlLoader::loadNext was broken
because it failed to connect to those signals.
* MiniBrowser/qt/UrlLoader.cpp:
(UrlLoader::UrlLoader):
(UrlLoader::loadingChanged):
* MiniBrowser/qt/UrlLoader.h:
(UrlLoader):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/UrlLoader.cpp
trunk/Tools/MiniBrowser/qt/UrlLoader.h
Diff
Modified: trunk/Tools/ChangeLog (150228 => 150229)
--- trunk/Tools/ChangeLog 2013-05-17 01:10:05 UTC (rev 150228)
+++ trunk/Tools/ChangeLog 2013-05-17 02:44:43 UTC (rev 150229)
@@ -1,3 +1,20 @@
+2013-05-16 Hyungchan Kim
+
+[Qt] UrlLoader::loadNext is broken in MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=116099
+
+Reviewed by Jocelyn Turcotte.
+
+QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
+are not available any more. So, UrlLoader::loadNext was broken
+because it failed to connect to those signals.
+
+* MiniBrowser/qt/UrlLoader.cpp:
+(UrlLoader::UrlLoader):
+(UrlLoader::loadingChanged):
+* MiniBrowser/qt/UrlLoader.h:
+(UrlLoader):
+
2013-05-16 Lamarque V. Souza
[WebSocket] Update pywebsocket to r760
Modified: trunk/Tools/MiniBrowser/qt/UrlLoader.cpp (150228 => 150229)
--- trunk/Tools/MiniBrowser/qt/UrlLoader.cpp 2013-05-17 01:10:05 UTC (rev 150228)
+++ trunk/Tools/MiniBrowser/qt/UrlLoader.cpp 2013-05-17 02:44:43 UTC (rev 150229)
@@ -28,6 +28,7 @@
#include "UrlLoader.h"
#include "private/qquickwebview_p.h"
+#include "private/qwebloadrequest_p.h"
#include
#include
@@ -42,14 +43,14 @@
m_checkIfFinishedTimer.setSingleShot(true);
connect(&m_checkIfFinishedTimer, SIGNAL(timeout()), this, SLOT(checkIfFinished()));
// loadStarted and loadFinished on QWebPage is emitted for each frame/sub-frame
-connect(m_browserWindow->webView(), SIGNAL(loadStarted()), this, SLOT(frameLoadStarted()));
-connect(m_browserWindow->webView(), SIGNAL(loadSucceeded()), this, SLOT(frameLoadFinished()));
-connect(m_browserWindow->webView(), SIGNAL(loadFailed(QDesktopWebView::ErrorType, int, const QUrl&)), this, SLOT(frameLoadFinished()));
+connect(m_browserWindow->webView(), SIGNAL(loadingChanged(QWebLoadRequest*)), this, SLOT(loadingChanged(QWebLoadRequest*)));
+connect(this, SIGNAL(loadStarted()), this, SLOT(frameLoadStarted()));
+connect(this, SIGNAL(loadFinished()), this, SLOT(frameLoadFinished()));
if (timeoutSeconds) {
m_timeoutTimer.setInterval(timeoutSeconds * 1000);
m_timeoutTimer.setSingleShot(true);
-connect(m_browserWindow->webView(), SIGNAL(loadStarted()), &m_timeoutTimer, SLOT(start()));
+connect(this, SIGNAL(loadStarted()), &m_timeoutTimer, SLOT(start()));
connect(&m_timeoutTimer, SIGNAL(timeout()), this, SLOT(loadNext()));
}
if (extraTimeSeconds) {
@@ -129,3 +130,18 @@
qstr = m_urls[m_index++];
return true;
}
+
+void UrlLoader::loadingChanged(QWebLoadRequest* loadRequest)
+{
+switch (loadRequest->status()) {
+case QQuickWebView::LoadStartedStatus:
+emit loadStarted();
+break;
+case QQuickWebView::LoadStoppedStatus:
+case QQuickWebView::LoadSucceededStatus:
+case QQuickWebView::LoadFailedStatus:
+default:
+emit loadFinished();
+break;
+}
+}
Modified: trunk/Tools/MiniBrowser/qt/UrlLoader.h (150228 => 150229)
--- trunk/Tools/MiniBrowser/qt/UrlLoader.h 2013-05-17 01:10:05 UTC (rev 150228)
+++ trunk/Tools/MiniBrowser/qt/UrlLoader.h 2013-05-17 02:44:43 UTC (rev 150229)
@@ -35,6 +35,8 @@
#include
#include
+class QWebLoadRequest;
+
class UrlLoader : public QObject {
Q_OBJECT
@@ -48,9 +50,12 @@
void checkIfFinished();
void frameLoadStarted();
void frameLoadFinished();
+void loadingChanged(QWebLoadRequest*);
Q_SIGNALS:
void pageLoadFinished();
+void loadStarted();
+void loadFinished();
private:
void loadUrlList(const QString& inputFileName);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150228] trunk/Source/WTF
Title: [150228] trunk/Source/WTF
Revision 150228
Author benja...@webkit.org
Date 2013-05-16 18:10:05 -0700 (Thu, 16 May 2013)
Log Message
Add the symbol WTFInvokeCrashHook back for binary compatibility.
Patch by Benjamin Poulain on 2013-05-16
Reviewed by Ryosuke Niwa.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Assertions.cpp
trunk/Source/WTF/wtf/Assertions.h
Diff
Modified: trunk/Source/WTF/ChangeLog (150227 => 150228)
--- trunk/Source/WTF/ChangeLog 2013-05-17 00:42:03 UTC (rev 150227)
+++ trunk/Source/WTF/ChangeLog 2013-05-17 01:10:05 UTC (rev 150228)
@@ -1,3 +1,12 @@
+2013-05-16 Benjamin Poulain
+
+Add the symbol WTFInvokeCrashHook back for binary compatibility.
+
+Reviewed by Ryosuke Niwa.
+
+* wtf/Assertions.cpp:
+* wtf/Assertions.h:
+
2013-05-16 Seokju Kwon
[CMAKE] Need to set WTF_LIBRARIES in wtf/CMakeLists.txt
Modified: trunk/Source/WTF/wtf/Assertions.cpp (150227 => 150228)
--- trunk/Source/WTF/wtf/Assertions.cpp 2013-05-17 00:42:03 UTC (rev 150227)
+++ trunk/Source/WTF/wtf/Assertions.cpp 2013-05-17 01:10:05 UTC (rev 150228)
@@ -326,6 +326,10 @@
globalHook = function;
}
+void WTFInvokeCrashHook()
+{
+}
+
void WTFCrash()
{
if (globalHook)
Modified: trunk/Source/WTF/wtf/Assertions.h (150227 => 150228)
--- trunk/Source/WTF/wtf/Assertions.h 2013-05-17 00:42:03 UTC (rev 150227)
+++ trunk/Source/WTF/wtf/Assertions.h 2013-05-17 01:10:05 UTC (rev 150228)
@@ -125,6 +125,8 @@
WTF_EXPORT_PRIVATE void WTFSetCrashHook(WTFCrashHookFunction);
WTF_EXPORT_PRIVATE void WTFInstallReportBacktraceOnCrashHook();
+// Exist for binary compatibility with older Safari. Do not use.
+WTF_EXPORT_PRIVATE void WTFInvokeCrashHook();
#ifdef __cplusplus
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150226] trunk/Source/WebKit2
Title: [150226] trunk/Source/WebKit2
Revision 150226
Author commit-qu...@webkit.org
Date 2013-05-16 17:36:49 -0700 (Thu, 16 May 2013)
Log Message
[EFL][WK2] Make Ewk_Context_Menu Ewk_Object
https://bugs.webkit.org/show_bug.cgi?id=116097
Patch by Michał Pakuła vel Rutka on 2013-05-16
Reviewed by Gyuyoung Kim.
Changed Ewk_Context_Menu to be an Ewk_Object so pointer to menu
object can be shared between different modules.
* UIProcess/API/efl/EwkView.cpp:
(EwkView::showContextMenu):
* UIProcess/API/efl/EwkView.h:
(EwkView):
* UIProcess/API/efl/ewk_context_menu.cpp:
(EwkContextMenu::appendItem):
(EwkContextMenu::removeItem):
(ewk_context_menu_new):
(ewk_context_menu_new_with_items):
(ewk_context_menu_item_append):
(ewk_context_menu_item_remove):
(ewk_context_menu_hide):
(ewk_context_menu_items_get):
(ewk_context_menu_item_select):
* UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
(ewk_context_menu_item_new_with_submenu):
* UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem):
* UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu):
(EwkContextMenu::create):
* UIProcess/API/efl/ewk_defines.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp
trunk/Source/WebKit2/UIProcess/API/efl/EwkView.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item_private.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu_private.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_defines.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (150225 => 150226)
--- trunk/Source/WebKit2/ChangeLog 2013-05-17 00:33:55 UTC (rev 150225)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-17 00:36:49 UTC (rev 150226)
@@ -1,3 +1,37 @@
+2013-05-16 Michał Pakuła vel Rutka
+
+[EFL][WK2] Make Ewk_Context_Menu Ewk_Object
+https://bugs.webkit.org/show_bug.cgi?id=116097
+
+Reviewed by Gyuyoung Kim.
+
+Changed Ewk_Context_Menu to be an Ewk_Object so pointer to menu
+object can be shared between different modules.
+
+* UIProcess/API/efl/EwkView.cpp:
+(EwkView::showContextMenu):
+* UIProcess/API/efl/EwkView.h:
+(EwkView):
+* UIProcess/API/efl/ewk_context_menu.cpp:
+(EwkContextMenu::appendItem):
+(EwkContextMenu::removeItem):
+(ewk_context_menu_new):
+(ewk_context_menu_new_with_items):
+(ewk_context_menu_item_append):
+(ewk_context_menu_item_remove):
+(ewk_context_menu_hide):
+(ewk_context_menu_items_get):
+(ewk_context_menu_item_select):
+* UIProcess/API/efl/ewk_context_menu_item.cpp:
+(EwkContextMenuItem::EwkContextMenuItem):
+(ewk_context_menu_item_new_with_submenu):
+* UIProcess/API/efl/ewk_context_menu_item_private.h:
+(EwkContextMenuItem):
+* UIProcess/API/efl/ewk_context_menu_private.h:
+(EwkContextMenu):
+(EwkContextMenu::create):
+* UIProcess/API/efl/ewk_defines.h:
+
2013-05-16 Andreas Kling
Page::chrome() should return a reference.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp (150225 => 150226)
--- trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp 2013-05-17 00:33:55 UTC (rev 150225)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp 2013-05-17 00:36:49 UTC (rev 150226)
@@ -844,7 +844,7 @@
if (m_contextMenu)
hideContextMenu();
-m_contextMenu = Ewk_Context_Menu::create(this, items);
+m_contextMenu = EwkContextMenu::create(this, items);
sd->api->context_menu_show(sd, position.x, position.y, m_contextMenu.get());
}
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkView.h (150225 => 150226)
--- trunk/Source/WebKit2/UIProcess/API/efl/EwkView.h 2013-05-17 00:33:55 UTC (rev 150225)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkView.h 2013-05-17 00:36:49 UTC (rev 150226)
@@ -278,7 +278,7 @@
bool m_touchEventsEnabled;
#endif
WebCore::Timer m_displayTimer;
-OwnPtr m_contextMenu;
+RefPtr m_contextMenu;
OwnPtr m_popupMenu;
OwnPtr m_inputMethodContext;
#if ENABLE(INPUT_TYPE_COLOR)
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp (150225 => 150226)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp 2013-05-17 00:33:55 UTC (rev 150225)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp 2013-05-17 00:36:49 UTC (rev 150226)
@@ -80,12 +80,12 @@
m_viewImpl->hideContextMenu();
}
-void Ewk_Context_Menu::appendItem(EwkContextMenuItem* item)
+void EwkContextMenu::appendItem(EwkContextMenuItem* item)
{
m_contextMenuItems = eina_list_append(m_contextMenuItems, item);
}
-void Ewk_Context_Menu::removeItem(EwkContextMenuItem* item)
+void EwkContextMenu::removeItem(EwkContextMenuItem* item)
{
m_contextMenuItems = eina_list_re
[webkit-changes] [150224] trunk/Source/WebCore
Title: [150224] trunk/Source/WebCore Revision 150224 Author commit-qu...@webkit.org Date 2013-05-16 17:30:52 -0700 (Thu, 16 May 2013) Log Message [BlackBerry] Crash due to an assert running test editing/execCommand/indent-paragraphs.html https://bugs.webkit.org/show_bug.cgi?id=114944 Patch by Carlos Garcia Campos on 2013-05-16 Reviewed by Rob Buis. It crashes in network platform code when trying to save an invalid URL in the disk cache. That test contains references to empty URLs like http://. Those empty URLs, are parsed as http:/ by KURL and considered valid. BlackBerry network platform uses GURL which considers those URLs invalid. We needed to check that the URLs are valid for our platform before starting the network operation. Fixes a crash running test editing/execCommand/indent-paragraphs.html. * platform/network/blackberry/NetworkManager.cpp: (WebCore::NetworkManager::startJob): Check if the request URL is valid from the platform point of view right after creating the platform network request and return early if the URL is invalid with StatusErrorInvalidUrl error. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/blackberry/NetworkManager.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (150223 => 150224) --- trunk/Source/WebCore/ChangeLog 2013-05-17 00:20:36 UTC (rev 150223) +++ trunk/Source/WebCore/ChangeLog 2013-05-17 00:30:52 UTC (rev 150224) @@ -1,3 +1,27 @@ +2013-05-16 Carlos Garcia Campos + +[BlackBerry] Crash due to an assert running test editing/execCommand/indent-paragraphs.html +https://bugs.webkit.org/show_bug.cgi?id=114944 + +Reviewed by Rob Buis. + +It crashes in network platform code when trying to save an +invalid URL in the disk cache. That test contains references to +empty URLs like http://. Those empty URLs, are parsed as http:/ by +KURL and considered valid. BlackBerry network platform uses GURL +which considers those URLs invalid. We needed to check that the +URLs are valid for our platform before starting the network +operation. + +Fixes a crash running test +editing/execCommand/indent-paragraphs.html. + +* platform/network/blackberry/NetworkManager.cpp: +(WebCore::NetworkManager::startJob): Check if the request URL is +valid from the platform point of view right after creating the +platform network request and return early if the URL is invalid +with StatusErrorInvalidUrl error. + 2013-05-16 Patrick Gansterer Remove unused function safeCreateFile() from WebCore Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkManager.cpp (150223 => 150224) --- trunk/Source/WebCore/platform/network/blackberry/NetworkManager.cpp 2013-05-17 00:20:36 UTC (rev 150223) +++ trunk/Source/WebCore/platform/network/blackberry/NetworkManager.cpp 2013-05-17 00:30:52 UTC (rev 150224) @@ -156,6 +156,11 @@ BlackBerry::Platform::NetworkRequest platformRequest; request.initializePlatformRequest(platformRequest, frame->loader() && frame->loader()->client() && static_cast(frame->loader()->client())->cookiesEnabled(), isInitial, rereadCookies); +// GURL and KURL consider valid URLs differently, for example http:// is parsed as +// http:/ by KURL and considered valid, while GURL considers it invalid. +if (!platformRequest.url().is_valid()) +return BlackBerry::Platform::FilterStream::StatusErrorInvalidUrl; + const String& documentUrl = frame->document()->url().string(); if (!documentUrl.isEmpty()) platformRequest.setReferrer(documentUrl); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150223] trunk/Tools
Title: [150223] trunk/Tools
Revision 150223
Author commit-qu...@webkit.org
Date 2013-05-16 17:20:36 -0700 (Thu, 16 May 2013)
Log Message
Fix testing if program exists in PATH
https://bugs.webkit.org/show_bug.cgi?id=116216
Patch by Jonathan Liu on 2013-05-16
Reviewed by Jocelyn Turcotte.
functions.prf incorrectly uses win_cmd_shell to test whether to
add .exe to the executable name when checking if it exists in
the PATH environment variable. This works correctly when
building using Windows Command Prompt but not under MSYS shell.
To resolve this, check the win32 platform scope instead of
win_cmd_shell so that it correctly adds .exe to the executable
name on Windows regardless of the shell used when testing if
it exists in PATH.
* qmake/mkspecs/features/functions.prf:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/functions.prf
Diff
Modified: trunk/Tools/ChangeLog (150222 => 150223)
--- trunk/Tools/ChangeLog 2013-05-17 00:19:34 UTC (rev 150222)
+++ trunk/Tools/ChangeLog 2013-05-17 00:20:36 UTC (rev 150223)
@@ -1,3 +1,22 @@
+2013-05-16 Jonathan Liu
+
+Fix testing if program exists in PATH
+https://bugs.webkit.org/show_bug.cgi?id=116216
+
+Reviewed by Jocelyn Turcotte.
+
+functions.prf incorrectly uses win_cmd_shell to test whether to
+add .exe to the executable name when checking if it exists in
+the PATH environment variable. This works correctly when
+building using Windows Command Prompt but not under MSYS shell.
+
+To resolve this, check the win32 platform scope instead of
+win_cmd_shell so that it correctly adds .exe to the executable
+name on Windows regardless of the shell used when testing if
+it exists in PATH.
+
+* qmake/mkspecs/features/functions.prf:
+
2013-05-16 Ryosuke Niwa
Fix the hard-coded names of EWS bots that run tests.
Modified: trunk/Tools/qmake/mkspecs/features/functions.prf (150222 => 150223)
--- trunk/Tools/qmake/mkspecs/features/functions.prf 2013-05-17 00:19:34 UTC (rev 150222)
+++ trunk/Tools/qmake/mkspecs/features/functions.prf 2013-05-17 00:20:36 UTC (rev 150223)
@@ -204,7 +204,7 @@
}
defineTest(programExistsInPath) {
-win_cmd_shell: program = $${1}.exe
+win32: program = $${1}.exe
else: program = $$1
PATH = "$$(PATH)"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150222] trunk/Source/WebCore
Title: [150222] trunk/Source/WebCore
Revision 150222
Author par...@webkit.org
Date 2013-05-16 17:19:34 -0700 (Thu, 16 May 2013)
Log Message
Remove unused function safeCreateFile() from WebCore
https://bugs.webkit.org/show_bug.cgi?id=116211
Reviewed by Anders Carlsson.
* platform/FileSystem.h:
* platform/win/FileSystemWin.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/FileSystem.h
trunk/Source/WebCore/platform/win/FileSystemWin.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (150221 => 150222)
--- trunk/Source/WebCore/ChangeLog 2013-05-17 00:17:46 UTC (rev 150221)
+++ trunk/Source/WebCore/ChangeLog 2013-05-17 00:19:34 UTC (rev 150222)
@@ -1,3 +1,13 @@
+2013-05-16 Patrick Gansterer
+
+Remove unused function safeCreateFile() from WebCore
+https://bugs.webkit.org/show_bug.cgi?id=116211
+
+Reviewed by Anders Carlsson.
+
+* platform/FileSystem.h:
+* platform/win/FileSystemWin.cpp:
+
2013-05-16 Peter Gal
[curl] MIME type should be in lowercase
Modified: trunk/Source/WebCore/platform/FileSystem.h (150221 => 150222)
--- trunk/Source/WebCore/platform/FileSystem.h 2013-05-17 00:17:46 UTC (rev 150221)
+++ trunk/Source/WebCore/platform/FileSystem.h 2013-05-17 00:19:34 UTC (rev 150222)
@@ -227,10 +227,6 @@
String roamingUserSpecificStorageDirectory();
#endif
-#if PLATFORM(WIN) && USE(CF)
-bool safeCreateFile(const String&, CFDataRef);
-#endif
-
} // namespace WebCore
#endif // FileSystem_h
Modified: trunk/Source/WebCore/platform/win/FileSystemWin.cpp (150221 => 150222)
--- trunk/Source/WebCore/platform/win/FileSystemWin.cpp 2013-05-17 00:17:46 UTC (rev 150221)
+++ trunk/Source/WebCore/platform/win/FileSystemWin.cpp 2013-05-17 00:19:34 UTC (rev 150222)
@@ -367,40 +367,6 @@
return cachedStorageDirectory(CSIDL_APPDATA);
}
-#if USE(CF)
-
-bool safeCreateFile(const String& path, CFDataRef data)
-{
-// Create a temporary file.
-WCHAR tempDirPath[MAX_PATH];
-if (!GetTempPathW(WTF_ARRAY_LENGTH(tempDirPath), tempDirPath))
-return false;
-
-WCHAR tempPath[MAX_PATH];
-if (!GetTempFileNameW(tempDirPath, L"WEBKIT", 0, tempPath))
-return false;
-
-HANDLE tempFileHandle = CreateFileW(tempPath, GENERIC_READ | GENERIC_WRITE, 0, 0, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, 0);
-if (tempFileHandle == INVALID_HANDLE_VALUE)
-return false;
-
-// Write the data to this temp file.
-DWORD written;
-if (!WriteFile(tempFileHandle, CFDataGetBytePtr(data), static_cast(CFDataGetLength(data)), &written, 0))
-return false;
-
-CloseHandle(tempFileHandle);
-
-// Copy the temp file to the destination file.
-String destination = path;
-if (!MoveFileExW(tempPath, destination.charactersWithNullTermination(), MOVEFILE_REPLACE_EXISTING | MOVEFILE_COPY_ALLOWED))
-return false;
-
-return true;
-}
-
-#endif // USE(CF)
-
Vector listDirectory(const String& directory, const String& filter)
{
Vector entries;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150221] trunk/Source/WebCore
Title: [150221] trunk/Source/WebCore
Revision 150221
Author commit-qu...@webkit.org
Date 2013-05-16 17:17:46 -0700 (Thu, 16 May 2013)
Log Message
[curl] MIME type should be in lowercase
https://bugs.webkit.org/show_bug.cgi?id=116218
Patch by Peter Gal on 2013-05-16
Reviewed by Benjamin Poulain.
Existing testcase: http/tests/mime/uppercase-mime-type.html
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::headerCallback): Convert the MIME type to lowercase.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (150220 => 150221)
--- trunk/Source/WebCore/ChangeLog 2013-05-17 00:14:52 UTC (rev 150220)
+++ trunk/Source/WebCore/ChangeLog 2013-05-17 00:17:46 UTC (rev 150221)
@@ -1,3 +1,15 @@
+2013-05-16 Peter Gal
+
+[curl] MIME type should be in lowercase
+https://bugs.webkit.org/show_bug.cgi?id=116218
+
+Reviewed by Benjamin Poulain.
+
+Existing testcase: http/tests/mime/uppercase-mime-type.html
+
+* platform/network/curl/ResourceHandleManager.cpp:
+(WebCore::headerCallback): Convert the MIME type to lowercase.
+
2013-05-16 Seokju Kwon
Web Inspector: Fix optional value of promptText in Inspector.json
Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp (150220 => 150221)
--- trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp 2013-05-17 00:14:52 UTC (rev 150220)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp 2013-05-17 00:17:46 UTC (rev 150221)
@@ -288,7 +288,7 @@
d->m_response.setURL(KURL(ParsedURLString, hdr));
d->m_response.setHTTPStatusCode(httpCode);
-d->m_response.setMimeType(extractMIMETypeFromMediaType(d->m_response.httpHeaderField("Content-Type")));
+d->m_response.setMimeType(extractMIMETypeFromMediaType(d->m_response.httpHeaderField("Content-Type")).lower());
d->m_response.setTextEncodingName(extractCharsetFromMediaType(d->m_response.httpHeaderField("Content-Type")));
d->m_response.setSuggestedFilename(filenameFromHTTPContentDisposition(d->m_response.httpHeaderField("Content-Disposition")));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150220] trunk/Source/JavaScriptCore
Title: [150220] trunk/Source/_javascript_Core
Revision 150220
Author par...@webkit.org
Date 2013-05-16 17:14:52 -0700 (Thu, 16 May 2013)
Log Message
Consolidate lists in _javascript_Core CMake files
https://bugs.webkit.org/show_bug.cgi?id=115992
Reviewed by Gyuyoung Kim.
Move common files into the CMakeLists.txt to avoid duplicating the list of files.
Also rebase the recently added GTK files to match the other CMake ports, since
the submitted patch was based on an older version of the source tree.
* CMakeLists.txt:
* PlatformEfl.cmake:
* PlatformGTK.cmake:
* shell/CMakeLists.txt:
* shell/PlatformEfl.cmake:
* shell/PlatformGTK.cmake:
Modified Paths
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/PlatformEfl.cmake
trunk/Source/_javascript_Core/PlatformGTK.cmake
trunk/Source/_javascript_Core/shell/CMakeLists.txt
trunk/Source/_javascript_Core/shell/PlatformEfl.cmake
trunk/Source/_javascript_Core/shell/PlatformGTK.cmake
Diff
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (150219 => 150220)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2013-05-17 00:14:41 UTC (rev 150219)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2013-05-17 00:14:52 UTC (rev 150220)
@@ -164,6 +164,7 @@
jit/ClosureCallStubRoutine.cpp
jit/ExecutableAllocator.cpp
+jit/ExecutableAllocatorFixedVMPool.cpp
jit/HostCallReturnValue.cpp
jit/GCAwareJITStubRoutine.cpp
jit/JITArithmetic32_64.cpp
Modified: trunk/Source/_javascript_Core/ChangeLog (150219 => 150220)
--- trunk/Source/_javascript_Core/ChangeLog 2013-05-17 00:14:41 UTC (rev 150219)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-05-17 00:14:52 UTC (rev 150220)
@@ -1,3 +1,21 @@
+2013-05-16 Patrick Gansterer
+
+Consolidate lists in _javascript_Core CMake files
+https://bugs.webkit.org/show_bug.cgi?id=115992
+
+Reviewed by Gyuyoung Kim.
+
+Move common files into the CMakeLists.txt to avoid duplicating the list of files.
+Also rebase the recently added GTK files to match the other CMake ports, since
+the submitted patch was based on an older version of the source tree.
+
+* CMakeLists.txt:
+* PlatformEfl.cmake:
+* PlatformGTK.cmake:
+* shell/CMakeLists.txt:
+* shell/PlatformEfl.cmake:
+* shell/PlatformGTK.cmake:
+
2013-05-16 Geoffrey Garen
JSValue shouldn't protect/unprotect its context
Modified: trunk/Source/_javascript_Core/PlatformEfl.cmake (150219 => 150220)
--- trunk/Source/_javascript_Core/PlatformEfl.cmake 2013-05-17 00:14:41 UTC (rev 150219)
+++ trunk/Source/_javascript_Core/PlatformEfl.cmake 2013-05-17 00:14:52 UTC (rev 150220)
@@ -1,8 +1,3 @@
-list(APPEND _javascript_Core_SOURCES
-jit/ExecutableAllocatorFixedVMPool.cpp
-)
-
list(APPEND _javascript_Core_INCLUDE_DIRECTORIES
${_javascript_CORE_DIR}/wtf/gobject
)
-
Modified: trunk/Source/_javascript_Core/PlatformGTK.cmake (150219 => 150220)
--- trunk/Source/_javascript_Core/PlatformGTK.cmake 2013-05-17 00:14:41 UTC (rev 150219)
+++ trunk/Source/_javascript_Core/PlatformGTK.cmake 2013-05-17 00:14:52 UTC (rev 150220)
@@ -1,13 +1,3 @@
-list(APPEND _javascript_Core_SOURCES
-jit/ExecutableAllocatorFixedVMPool.cpp
-)
-
-list(APPEND _javascript_Core_LIBRARIES
-${ICU_I18N_LIBRARIES}
-)
-
list(APPEND _javascript_Core_INCLUDE_DIRECTORIES
${_javascript_CORE_DIR}/wtf/gobject
-${ICU_INCLUDE_DIRS}
)
-
Modified: trunk/Source/_javascript_Core/shell/CMakeLists.txt (150219 => 150220)
--- trunk/Source/_javascript_Core/shell/CMakeLists.txt 2013-05-17 00:14:41 UTC (rev 150219)
+++ trunk/Source/_javascript_Core/shell/CMakeLists.txt 2013-05-17 00:14:52 UTC (rev 150220)
@@ -5,6 +5,7 @@
set(JSC_LIBRARIES
${WTF_LIBRARY_NAME}
${_javascript_Core_LIBRARY_NAME}
+${CMAKE_DL_LIBS}
)
if ("${_javascript_Core_LIBRARY_TYPE}" MATCHES "STATIC")
Modified: trunk/Source/_javascript_Core/shell/PlatformEfl.cmake (150219 => 150220)
--- trunk/Source/_javascript_Core/shell/PlatformEfl.cmake 2013-05-17 00:14:41 UTC (rev 150219)
+++ trunk/Source/_javascript_Core/shell/PlatformEfl.cmake 2013-05-17 00:14:52 UTC (rev 150220)
@@ -1,5 +1,4 @@
list(APPEND JSC_LIBRARIES
${GLIB_LIBRARIES}
${ECORE_LIBRARIES}
-${CMAKE_DL_LIBS}
)
Modified: trunk/Source/_javascript_Core/shell/PlatformGTK.cmake (150219 => 150220)
--- trunk/Source/_javascript_Core/shell/PlatformGTK.cmake 2013-05-17 00:14:41 UTC (rev 150219)
+++ trunk/Source/_javascript_Core/shell/PlatformGTK.cmake 2013-05-17 00:14:52 UTC (rev 150220)
@@ -1,5 +1,3 @@
list(APPEND JSC_LIBRARIES
${GLIB_LIBRARIES}
-${CMAKE_DL_LIBS}
)
-
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150219] trunk/Source/WTF
Title: [150219] trunk/Source/WTF
Revision 150219
Author commit-qu...@webkit.org
Date 2013-05-16 17:14:41 -0700 (Thu, 16 May 2013)
Log Message
[CMAKE] Need to set WTF_LIBRARIES in wtf/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=116209
Patch by Seokju Kwon on 2013-05-16
Reviewed by Gyuyoung Kim.
* wtf/CMakeLists.txt: Replace list with set.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CMakeLists.txt
Diff
Modified: trunk/Source/WTF/ChangeLog (150218 => 150219)
--- trunk/Source/WTF/ChangeLog 2013-05-17 00:12:39 UTC (rev 150218)
+++ trunk/Source/WTF/ChangeLog 2013-05-17 00:14:41 UTC (rev 150219)
@@ -1,3 +1,12 @@
+2013-05-16 Seokju Kwon
+
+[CMAKE] Need to set WTF_LIBRARIES in wtf/CMakeLists.txt
+https://bugs.webkit.org/show_bug.cgi?id=116209
+
+Reviewed by Gyuyoung Kim.
+
+* wtf/CMakeLists.txt: Replace list with set.
+
2013-05-16 Benjamin Poulain
Crash properly on iOS
Modified: trunk/Source/WTF/wtf/CMakeLists.txt (150218 => 150219)
--- trunk/Source/WTF/wtf/CMakeLists.txt 2013-05-17 00:12:39 UTC (rev 150218)
+++ trunk/Source/WTF/wtf/CMakeLists.txt 2013-05-17 00:14:41 UTC (rev 150219)
@@ -214,7 +214,7 @@
"${CMAKE_BINARY_DIR}"
)
-list(APPEND WTF_LIBRARIES
+set(WTF_LIBRARIES
${CMAKE_DL_LIBS}
)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150218] trunk/Source/WebCore
Title: [150218] trunk/Source/WebCore
Revision 150218
Author commit-qu...@webkit.org
Date 2013-05-16 17:12:39 -0700 (Thu, 16 May 2013)
Log Message
Web Inspector: Fix optional value of promptText in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=116203
Patch by Seokju Kwon on 2013-05-16
Reviewed by Joseph Pecoraro.
Merge from https://chromiumcodereview.appspot.com/14672031.
No new tests needed.
* inspector/Inspector.json:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (150217 => 150218)
--- trunk/Source/WebCore/ChangeLog 2013-05-17 00:11:54 UTC (rev 150217)
+++ trunk/Source/WebCore/ChangeLog 2013-05-17 00:12:39 UTC (rev 150218)
@@ -1,3 +1,16 @@
+2013-05-16 Seokju Kwon
+
+Web Inspector: Fix optional value of promptText in Inspector.json
+https://bugs.webkit.org/show_bug.cgi?id=116203
+
+Reviewed by Joseph Pecoraro.
+
+Merge from https://chromiumcodereview.appspot.com/14672031.
+
+No new tests needed.
+
+* inspector/Inspector.json:
+
2013-05-16 Mary Wu
[BlackBerry] Unable to download blob resource
Modified: trunk/Source/WebCore/inspector/Inspector.json (150217 => 150218)
--- trunk/Source/WebCore/inspector/Inspector.json 2013-05-17 00:11:54 UTC (rev 150217)
+++ trunk/Source/WebCore/inspector/Inspector.json 2013-05-17 00:12:39 UTC (rev 150218)
@@ -458,7 +458,7 @@
"description": "Accepts or dismisses a _javascript_ initiated dialog (alert, confirm, prompt, or onbeforeunload).",
"parameters": [
{ "name": "accept", "type": "boolean", "description": "Whether to accept or dismiss the dialog." },
-{ "name": "promptText", "type": "string", "optional": "true", "description": "The text to enter into the dialog prompt before accepting. Used only if this is a prompt dialog." }
+{ "name": "promptText", "type": "string", "optional": true, "description": "The text to enter into the dialog prompt before accepting. Used only if this is a prompt dialog." }
],
"hidden": true
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150217] trunk/Source
Title: [150217] trunk/Source
Revision 150217
Author mary...@torchmobile.com.cn
Date 2013-05-16 17:11:54 -0700 (Thu, 16 May 2013)
Log Message
[BlackBerry] Unable to download blob resource
https://bugs.webkit.org/show_bug.cgi?id=115888
Reviewed by Benjamin Poulain.
Source/WebCore:
Add BlobStream to handle over blob data from BlobResourceHandle to download stream.
RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
* PlatformBlackBerry.cmake:
* platform/network/blackberry/BlobStream.cpp: Added.
(WebCore):
(WebCore::BlobStream::BlobStream):
(WebCore::BlobStream::~BlobStream):
(WebCore::BlobStream::didReceiveData):
(WebCore::BlobStream::didFinishLoading):
(WebCore::BlobStream::didFail):
(WebCore::BlobStream::url):
(WebCore::BlobStream::mimeType):
* platform/network/blackberry/BlobStream.h: Added.
(WebCore):
(BlobStream):
Source/WebKit/blackberry:
For blob resource (blob:http), it's not suitable to go to NetworkStream
which don't handle "blob" protocol at all. since blob data already handled
in BlobResourceHandle, simply get the data out to download stream.
RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformBlackBerry.cmake
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
Added Paths
trunk/Source/WebCore/platform/network/blackberry/BlobStream.cpp
trunk/Source/WebCore/platform/network/blackberry/BlobStream.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (150216 => 150217)
--- trunk/Source/WebCore/ChangeLog 2013-05-17 00:06:10 UTC (rev 150216)
+++ trunk/Source/WebCore/ChangeLog 2013-05-17 00:11:54 UTC (rev 150217)
@@ -1,3 +1,27 @@
+2013-05-16 Mary Wu
+
+[BlackBerry] Unable to download blob resource
+https://bugs.webkit.org/show_bug.cgi?id=115888
+
+Reviewed by Benjamin Poulain.
+
+Add BlobStream to handle over blob data from BlobResourceHandle to download stream.
+RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
+
+* PlatformBlackBerry.cmake:
+* platform/network/blackberry/BlobStream.cpp: Added.
+(WebCore):
+(WebCore::BlobStream::BlobStream):
+(WebCore::BlobStream::~BlobStream):
+(WebCore::BlobStream::didReceiveData):
+(WebCore::BlobStream::didFinishLoading):
+(WebCore::BlobStream::didFail):
+(WebCore::BlobStream::url):
+(WebCore::BlobStream::mimeType):
+* platform/network/blackberry/BlobStream.h: Added.
+(WebCore):
+(BlobStream):
+
2013-05-16 Anders Carlsson
Remove SystemTime header and implementations
Modified: trunk/Source/WebCore/PlatformBlackBerry.cmake (150216 => 150217)
--- trunk/Source/WebCore/PlatformBlackBerry.cmake 2013-05-17 00:06:10 UTC (rev 150216)
+++ trunk/Source/WebCore/PlatformBlackBerry.cmake 2013-05-17 00:11:54 UTC (rev 150217)
@@ -44,6 +44,7 @@
platform/network/NetworkStorageSessionStub.cpp
platform/network/ProxyServer.cpp
platform/network/blackberry/AutofillBackingStore.cpp
+platform/network/blackberry/BlobStream.cpp
platform/network/blackberry/CookieJarBlackBerry.cpp
platform/network/blackberry/DNSBlackBerry.cpp
platform/network/blackberry/DeferredData.cpp
Added: trunk/Source/WebCore/platform/network/blackberry/BlobStream.cpp (0 => 150217)
--- trunk/Source/WebCore/platform/network/blackberry/BlobStream.cpp (rev 0)
+++ trunk/Source/WebCore/platform/network/blackberry/BlobStream.cpp 2013-05-17 00:11:54 UTC (rev 150217)
@@ -0,0 +1,65 @@
+/*
+ * Copyright (C) 2013 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include "config.h"
+#include "BlobStream.h"
+
+#include "ResourceHandle.h"
+
+using BlackBerry::Platform::FilterStream;
+
+namespace WebCore {
+
+BlobStream::BlobStream(const ResourceResponse& response, ResourceHandle* handle)
+: FilterStream()
+, m_response(response)
+{
+registerStreamId();
+handle->setClient(this);
+}
+
+BlobStream::~BlobStream()
+{
+}
+
+voi
[webkit-changes] [150216] trunk/Source/WebCore
Title: [150216] trunk/Source/WebCore Revision 150216 Author ander...@apple.com Date 2013-05-16 17:06:10 -0700 (Thu, 16 May 2013) Log Message Remove SystemTime header and implementations https://bugs.webkit.org/show_bug.cgi?id=116200 Reviewed by Alexey Proskuryakov. SystemTim just had a single function that's not called anymore. Remove it. * GNUmakefile.list.am: * PlatformBlackBerry.cmake: * PlatformEfl.cmake: * PlatformWinCE.cmake: * Target.pri: * WebCore.vcproj/WebCore.vcproj: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * WebCore.xcodeproj/project.pbxproj: * history/PageCache.cpp: * platform/SystemTime.h: Removed. * platform/blackberry/SystemTimeBlackBerry.cpp: Removed. * platform/efl/SystemTimeEfl.cpp: Removed. * platform/graphics/ca/GraphicsLayerCA.cpp: * platform/mac/SystemTimeMac.cpp: Removed. * platform/qt/TemporaryLinkStubsQt.cpp: * platform/win/SystemTimeWin.cpp: Removed. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/PlatformBlackBerry.cmake trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebCore/PlatformWinCE.cmake trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/history/PageCache.cpp trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp trunk/Source/WebCore/platform/qt/TemporaryLinkStubsQt.cpp Removed Paths trunk/Source/WebCore/platform/SystemTime.h trunk/Source/WebCore/platform/blackberry/SystemTimeBlackBerry.cpp trunk/Source/WebCore/platform/efl/SystemTimeEfl.cpp trunk/Source/WebCore/platform/mac/SystemTimeMac.cpp trunk/Source/WebCore/platform/win/SystemTimeWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (150215 => 150216) --- trunk/Source/WebCore/ChangeLog 2013-05-17 00:04:06 UTC (rev 150215) +++ trunk/Source/WebCore/ChangeLog 2013-05-17 00:06:10 UTC (rev 150216) @@ -1,3 +1,30 @@ +2013-05-16 Anders Carlsson + +Remove SystemTime header and implementations +https://bugs.webkit.org/show_bug.cgi?id=116200 + +Reviewed by Alexey Proskuryakov. + +SystemTim just had a single function that's not called anymore. Remove it. + +* GNUmakefile.list.am: +* PlatformBlackBerry.cmake: +* PlatformEfl.cmake: +* PlatformWinCE.cmake: +* Target.pri: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.vcxproj/WebCore.vcxproj: +* WebCore.vcxproj/WebCore.vcxproj.filters: +* WebCore.xcodeproj/project.pbxproj: +* history/PageCache.cpp: +* platform/SystemTime.h: Removed. +* platform/blackberry/SystemTimeBlackBerry.cpp: Removed. +* platform/efl/SystemTimeEfl.cpp: Removed. +* platform/graphics/ca/GraphicsLayerCA.cpp: +* platform/mac/SystemTimeMac.cpp: Removed. +* platform/qt/TemporaryLinkStubsQt.cpp: +* platform/win/SystemTimeWin.cpp: Removed. + 2013-05-16 Glenn Adams [Inspector] Don't filter syntax error caused by asterisk in CSS Property name. Modified: trunk/Source/WebCore/GNUmakefile.list.am (150215 => 150216) --- trunk/Source/WebCore/GNUmakefile.list.am 2013-05-17 00:04:06 UTC (rev 150215) +++ trunk/Source/WebCore/GNUmakefile.list.am 2013-05-17 00:06:10 UTC (rev 150216) @@ -6000,7 +6000,6 @@ Source/WebCore/platform/SSLKeyGenerator.h \ Source/WebCore/platform/SuddenTermination.h \ Source/WebCore/platform/Supplementable.h \ - Source/WebCore/platform/SystemTime.h \ Source/WebCore/platform/text/enchant/TextCheckerEnchant.h \ Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp \ Source/WebCore/platform/text/BidiContext.cpp \ Modified: trunk/Source/WebCore/PlatformBlackBerry.cmake (150215 => 150216) --- trunk/Source/WebCore/PlatformBlackBerry.cmake 2013-05-17 00:04:06 UTC (rev 150215) +++ trunk/Source/WebCore/PlatformBlackBerry.cmake 2013-05-17 00:06:10 UTC (rev 150216) @@ -123,7 +123,6 @@ platform/blackberry/SearchPopupMenuBlackBerry.cpp platform/blackberry/SharedTimerBlackBerry.cpp platform/blackberry/SoundBlackBerry.cpp -platform/blackberry/SystemTimeBlackBerry.cpp platform/blackberry/TemporaryLinkStubs.cpp platform/blackberry/WidgetBlackBerry.cpp platform/graphics/blackberry/FloatPointBlackBerry.cpp Modified: trunk/Source/WebCore/PlatformEfl.cmake (150215 => 150216) --- trunk/Source/WebCore/PlatformEfl.cmake 2013-05-17 00:04:06 UTC (rev 150215) +++ trunk/Source/WebCore/PlatformEfl.cmake 2013-05-17 00:06:10 UTC (rev 150216) @@ -82,7 +82,6 @@ platform/efl/ScrollViewEfl.cpp platform/efl/SharedTimerEfl.cpp platform/efl/SoundEfl.cpp -platform/efl/SystemTimeEfl.cpp platform/efl/TemporaryLinkStubs.cpp platform/efl/WidgetEfl.cpp Modified: trunk/Source/WebCore/PlatformWinCE.cmake (150215 => 150216) --- t
[webkit-changes] [150215] trunk/Source/WebCore
Title: [150215] trunk/Source/WebCore
Revision 150215
Author gl...@skynav.com
Date 2013-05-16 17:04:06 -0700 (Thu, 16 May 2013)
Log Message
[Inspector] Don't filter syntax error caused by asterisk in CSS Property name.
https://bugs.webkit.org/show_bug.cgi?id=116196
Reviewed by Benjamin Poulain.
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
- Remove questionable IE7 related error filtering
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (150214 => 150215)
--- trunk/Source/WebCore/ChangeLog 2013-05-17 00:03:01 UTC (rev 150214)
+++ trunk/Source/WebCore/ChangeLog 2013-05-17 00:04:06 UTC (rev 150215)
@@ -1,3 +1,14 @@
+2013-05-16 Glenn Adams
+
+[Inspector] Don't filter syntax error caused by asterisk in CSS Property name.
+https://bugs.webkit.org/show_bug.cgi?id=116196
+
+Reviewed by Benjamin Poulain.
+
+* inspector/InspectorConsoleAgent.cpp:
+(WebCore::InspectorConsoleAgent::addMessageToConsole):
+- Remove questionable IE7 related error filtering
+
2013-05-16 Andreas Kling
Page::chrome() should return a reference.
Modified: trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp (150214 => 150215)
--- trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp 2013-05-17 00:03:01 UTC (rev 150214)
+++ trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp 2013-05-17 00:04:06 UTC (rev 150215)
@@ -188,10 +188,6 @@
clearMessages(&error);
}
-// Ignore errors like "*property=value". This trick is used for IE7: http://stackoverflow.com/questions/4563651/what-does-an-asterisk-do-in-a-css-property-name
-if (source == CSSMessageSource && message.contains(": *"))
-return;
-
bool canGenerateCallStack = !isWorkerAgent() && m_frontend;
addConsoleMessage(adoptPtr(new ConsoleMessage(canGenerateCallStack, source, type, level, message, scriptId, lineNumber, columnNumber, state, requestIdentifier)));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150213] trunk
Title: [150213] trunk
Revision 150213
Author simon.fra...@apple.com
Date 2013-05-16 16:57:46 -0700 (Thu, 16 May 2013)
Log Message
Source/WebCore: Content disappears when scrolling http://www.childrenscancer.org/zach/
https://bugs.webkit.org/show_bug.cgi?id=116206
Reviewed by Darin Adler.
When a RenderLayerBacking gains or loses a foregroundLayer or backgroundLayer,
we need to repaint the primary layer, since what paints into that primary
layer will change.
On the page in question, we gained/lost a foreground layer when scrolling because
the page popped an element into position:fixed.
Test: compositing/repaint/foreground-layer-change.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateForegroundLayer):
(WebCore::RenderLayerBacking::updateBackgroundLayer):
LayoutTests: Content disappears when scrolling http://www.childrenscancer.org/zach/
https://bugs.webkit.org/show_bug.cgi?id=116206
Reviewed by Darin Adler.
Ref test for foreground layer removal.
* compositing/repaint/foreground-layer-change-expected.html: Added.
* compositing/repaint/foreground-layer-change.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Added Paths
trunk/LayoutTests/compositing/repaint/foreground-layer-change-expected.html
trunk/LayoutTests/compositing/repaint/foreground-layer-change.html
Diff
Modified: trunk/LayoutTests/ChangeLog (150212 => 150213)
--- trunk/LayoutTests/ChangeLog 2013-05-16 23:48:49 UTC (rev 150212)
+++ trunk/LayoutTests/ChangeLog 2013-05-16 23:57:46 UTC (rev 150213)
@@ -1,3 +1,15 @@
+2013-05-16 Simon Fraser
+
+Content disappears when scrolling http://www.childrenscancer.org/zach/
+https://bugs.webkit.org/show_bug.cgi?id=116206
+
+Reviewed by Darin Adler.
+
+Ref test for foreground layer removal.
+
+* compositing/repaint/foreground-layer-change-expected.html: Added.
+* compositing/repaint/foreground-layer-change.html: Added.
+
2013-05-16 Ryosuke Niwa
REGRESSION: canvas/philip/tests/2d.text.draw.fontface.notinpage.html fails
Added: trunk/LayoutTests/compositing/repaint/foreground-layer-change-expected.html (0 => 150213)
--- trunk/LayoutTests/compositing/repaint/foreground-layer-change-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/repaint/foreground-layer-change-expected.html 2013-05-16 23:57:46 UTC (rev 150213)
@@ -0,0 +1,41 @@
+
+
+
+
+
+.container {
+border: 1px solid black;
+}
+.box {
+ width: 200px;
+ height: 200px;
+ background-color: red;
+}
+
+.child {
+background-color: green;
+width: 100%;
+height: 100%;
+}
+
+.composited {
+-webkit-transform: translateZ(0);
+}
+
+#negative {
+position: absolute;
+top: 100px;
+height: 50px;
+width: 50px;
+background-color: orange;
+z-index: 0;
+}
+
+
+
+
+
+
+
+
+
Property changes on: trunk/LayoutTests/compositing/repaint/foreground-layer-change-expected.html
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Added: trunk/LayoutTests/compositing/repaint/foreground-layer-change.html (0 => 150213)
--- trunk/LayoutTests/compositing/repaint/foreground-layer-change.html (rev 0)
+++ trunk/LayoutTests/compositing/repaint/foreground-layer-change.html 2013-05-16 23:57:46 UTC (rev 150213)
@@ -0,0 +1,58 @@
+
+
+
+
+
+.container {
+border: 1px solid black;
+}
+.box {
+ width: 200px;
+ height: 200px;
+ background-color: red;
+}
+
+.child {
+background-color: green;
+width: 100%;
+height: 100%;
+}
+
+.composited {
+-webkit-transform: translateZ(0);
+}
+
+#negative {
+position: absolute;
+top: 100px;
+height: 50px;
+width: 50px;
+background-color: orange;
+z-index: 0;
+}
+
+#negative.behind {
+z-index: -1;
+}
+
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+function doTest()
+{
+window.setTimeout(function() {
+document.getElementById('negative').classList.remove('behind');
+if (window.testRunner)
+testRunner.notifyDone();
+}, 0)
+}
+window.addEventListener('load', doTest, false);
+
+
+
+
+
+
+
+
+
Property changes on: trunk/LayoutTests/compositing/repaint/foreground-layer-cha
[webkit-changes] [150212] trunk/Source/WebKit2
Title: [150212] trunk/Source/WebKit2 Revision 150212 Author timothy_hor...@apple.com Date 2013-05-16 16:48:49 -0700 (Thu, 16 May 2013) Log Message [wk2] didGetImageForFindMatch can return a null image https://bugs.webkit.org/show_bug.cgi?id=116251 Reviewed by Simon Fraser. Don't send didGetImageForFindMatch if we didn't get an image for the find match, which can happen if the selection is not visible. * WebProcess/WebPage/FindController.cpp: (WebKit::FindController::getImageForFindMatch): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (150211 => 150212) --- trunk/Source/WebKit2/ChangeLog 2013-05-16 23:38:13 UTC (rev 150211) +++ trunk/Source/WebKit2/ChangeLog 2013-05-16 23:48:49 UTC (rev 150212) @@ -31,6 +31,20 @@ 2013-05-16 Tim Horton +[wk2] didGetImageForFindMatch can return a null image +https://bugs.webkit.org/show_bug.cgi?id=116251 + + +Reviewed by Simon Fraser. + +Don't send didGetImageForFindMatch if we didn't get an image for +the find match, which can happen if the selection is not visible. + +* WebProcess/WebPage/FindController.cpp: +(WebKit::FindController::getImageForFindMatch): + +2013-05-16 Tim Horton + [wk2] Minimum layout width is lost if the WebProcess crashes https://bugs.webkit.org/show_bug.cgi?id=116202 Modified: trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp (150211 => 150212) --- trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp 2013-05-16 23:38:13 UTC (rev 150211) +++ trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp 2013-05-16 23:48:49 UTC (rev 150212) @@ -251,6 +251,9 @@ frame->selection()->setSelection(oldSelection); +if (handle.isNull()) +return; + m_webPage->send(Messages::WebPageProxy::DidGetImageForFindMatch(handle, matchIndex)); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150211] trunk/Tools
Title: [150211] trunk/Tools
Revision 150211
Author rn...@webkit.org
Date 2013-05-16 16:38:13 -0700 (Thu, 16 May 2013)
Log Message
Fix the hard-coded names of EWS bots that run tests.
* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.did_pass_testing_ews):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/queues.py
Diff
Modified: trunk/Tools/ChangeLog (150210 => 150211)
--- trunk/Tools/ChangeLog 2013-05-16 21:32:31 UTC (rev 150210)
+++ trunk/Tools/ChangeLog 2013-05-16 23:38:13 UTC (rev 150211)
@@ -1,3 +1,10 @@
+2013-05-16 Ryosuke Niwa
+
+Fix the hard-coded names of EWS bots that run tests.
+
+* Scripts/webkitpy/tool/commands/queues.py:
+(CommitQueue.did_pass_testing_ews):
+
2013-05-16 Gustavo Noronha Silva
[GTK] Build Xvfb with jhbuild
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues.py (150210 => 150211)
--- trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2013-05-16 21:32:31 UTC (rev 150210)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2013-05-16 23:38:13 UTC (rev 150211)
@@ -381,8 +381,8 @@
def did_pass_testing_ews(self, patch):
# Only Mac and Mac WK2 run tests
# FIXME: We shouldn't have to hard-code it here.
-status = self._tool.status_server.patch_status("mac", patch.id())
-return status == self._pass_status
+patch_status = self._tool.status_server.patch_status
+return patch_status("mac-ews", patch.id()) == self._pass_status or patch_status("mac-wk2-ews", patch.id()) == self._pass_status
# StepSequenceErrorHandler methods
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150210] trunk/Source/WebCore
Title: [150210] trunk/Source/WebCore Revision 150210 Author aes...@apple.com Date 2013-05-16 14:32:31 -0700 (Thu, 16 May 2013) Log Message Do not indefinitely cache resources from blob URLs. Reviewed by Alexey Proskuryakov. Alexey pointed out after I landed r150169 that blob URLs backed by files should return an error if the file changed after the URL was created. By indefinitely caching them in memory, we don't give the loader a chance to check for modification. Remove "blob" from the list of schemes that should be indefinitely cached. * platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/SchemeRegistry.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (150209 => 150210) --- trunk/Source/WebCore/ChangeLog 2013-05-16 21:23:44 UTC (rev 150209) +++ trunk/Source/WebCore/ChangeLog 2013-05-16 21:32:31 UTC (rev 150210) @@ -1,3 +1,18 @@ +2013-05-16 Andy Estes + +Do not indefinitely cache resources from blob URLs. + +Reviewed by Alexey Proskuryakov. + +Alexey pointed out after I landed r150169 that blob URLs backed by +files should return an error if the file changed after the URL was +created. By indefinitely caching them in memory, we don't give the +loader a chance to check for modification. Remove "blob" from the list +of schemes that should be indefinitely cached. + +* platform/SchemeRegistry.cpp: +(WebCore::SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely): + 2013-05-16 Claudio Saavedra [CSS] CSS Variables are case-sensitive Modified: trunk/Source/WebCore/platform/SchemeRegistry.cpp (150209 => 150210) --- trunk/Source/WebCore/platform/SchemeRegistry.cpp 2013-05-16 21:23:44 UTC (rev 150209) +++ trunk/Source/WebCore/platform/SchemeRegistry.cpp 2013-05-16 21:32:31 UTC (rev 150210) @@ -326,7 +326,7 @@ if (equalIgnoringCase(scheme, "applewebdata")) return true; #endif -return equalIgnoringCase(scheme, "blob") || equalIgnoringCase(scheme, "data"); +return equalIgnoringCase(scheme, "data"); } } // namespace WebCore ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150209] trunk/LayoutTests
Title: [150209] trunk/LayoutTests Revision 150209 Author rn...@webkit.org Date 2013-05-16 14:23:44 -0700 (Thu, 16 May 2013) Log Message REGRESSION: canvas/philip/tests/2d.text.draw.fontface.notinpage.html fails https://bugs.webkit.org/show_bug.cgi?id=116245 Add a passing/failing test expectation. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (150208 => 150209) --- trunk/LayoutTests/ChangeLog 2013-05-16 21:18:30 UTC (rev 150208) +++ trunk/LayoutTests/ChangeLog 2013-05-16 21:23:44 UTC (rev 150209) @@ -1,5 +1,14 @@ 2013-05-16 Ryosuke Niwa +REGRESSION: canvas/philip/tests/2d.text.draw.fontface.notinpage.html fails +https://bugs.webkit.org/show_bug.cgi?id=116245 + +Add a passing/failing test expectation. + +* platform/mac/TestExpectations: + +2013-05-16 Ryosuke Niwa + [Mac] fast/events/mouse-cursor-image-set.html is flaky https://bugs.webkit.org/show_bug.cgi?id=116244 Modified: trunk/LayoutTests/platform/mac/TestExpectations (150208 => 150209) --- trunk/LayoutTests/platform/mac/TestExpectations 2013-05-16 21:18:30 UTC (rev 150208) +++ trunk/LayoutTests/platform/mac/TestExpectations 2013-05-16 21:23:44 UTC (rev 150209) @@ -1546,3 +1546,5 @@ webkit.org/b/116241 inspector/storage-panel-dom-storage-update.html [ Failure ] webkit.org/b/116244 fast/events/mouse-cursor-image-set.html [ Failure Pass ] + +webkit.org/b/116245 canvas/philip/tests/2d.text.draw.fontface.notinpage.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150208] trunk/LayoutTests
Title: [150208] trunk/LayoutTests Revision 150208 Author rn...@webkit.org Date 2013-05-16 14:18:30 -0700 (Thu, 16 May 2013) Log Message [Mac] fast/events/mouse-cursor-image-set.html is flaky https://bugs.webkit.org/show_bug.cgi?id=116244 Add a flaky test expectation on Mac. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (150207 => 150208) --- trunk/LayoutTests/ChangeLog 2013-05-16 21:04:57 UTC (rev 150207) +++ trunk/LayoutTests/ChangeLog 2013-05-16 21:18:30 UTC (rev 150208) @@ -1,3 +1,12 @@ +2013-05-16 Ryosuke Niwa + +[Mac] fast/events/mouse-cursor-image-set.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=116244 + +Add a flaky test expectation on Mac. + +* platform/mac/TestExpectations: + 2013-05-16 Claudio Saavedra [CSS] CSS Variables are case-sensitive Modified: trunk/LayoutTests/platform/mac/TestExpectations (150207 => 150208) --- trunk/LayoutTests/platform/mac/TestExpectations 2013-05-16 21:04:57 UTC (rev 150207) +++ trunk/LayoutTests/platform/mac/TestExpectations 2013-05-16 21:18:30 UTC (rev 150208) @@ -1544,3 +1544,5 @@ webkit.org/b/116240 [ Release ] fast/flexbox/auto-height-with-flex.html [ ImageOnlyFailure ] webkit.org/b/116241 inspector/storage-panel-dom-storage-update.html [ Failure ] + +webkit.org/b/116244 fast/events/mouse-cursor-image-set.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150207] trunk
Title: [150207] trunk
Revision 150207
Author csaave...@igalia.com
Date 2013-05-16 14:04:57 -0700 (Thu, 16 May 2013)
Log Message
[CSS] CSS Variables are case-sensitive
https://bugs.webkit.org/show_bug.cgi?id=116239
Reviewed by Ryosuke Niwa.
Source/WebCore:
The CSS Variables specification states that variables are
case-sensitive, unlike other CSS properties.
Test: fast/css/variables/case-sensitive.html
* css/CSSParser.cpp:
(WebCore::CSSParserString::substring): Replace
the now unnecessary lowerSubstring() with this method.
Also, since the method is only used by the CSS variables
implementation, #ifdef it.
(WebCore::CSSParser::createPrimitiveVariableNameValue):
(WebCore::CSSParser::storeVariableDeclaration):
Do not normalize variable declarations to lowercase.
* css/CSSParserValues.h:
(CSSParserString): Replace the lowerSubstring() declaration
and wrap with #if/#endif.
LayoutTests:
* fast/css/variables/case-sensitive-expected.html: Renamed from
fast/css/variables/case-insensitive-expected.html.
* fast/css/variables/case-sensitive.html: Renamed from
LayoutTests/fast/css/variables/case-insensitive.html.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParserValues.h
Added Paths
trunk/LayoutTests/fast/css/variables/case-sensitive-expected.html
trunk/LayoutTests/fast/css/variables/case-sensitive.html
Removed Paths
trunk/LayoutTests/fast/css/variables/case-insensitive-expected.html
trunk/LayoutTests/fast/css/variables/case-insensitive.html
Diff
Modified: trunk/LayoutTests/ChangeLog (150206 => 150207)
--- trunk/LayoutTests/ChangeLog 2013-05-16 21:02:11 UTC (rev 150206)
+++ trunk/LayoutTests/ChangeLog 2013-05-16 21:04:57 UTC (rev 150207)
@@ -1,3 +1,15 @@
+2013-05-16 Claudio Saavedra
+
+[CSS] CSS Variables are case-sensitive
+https://bugs.webkit.org/show_bug.cgi?id=116239
+
+Reviewed by Ryosuke Niwa.
+
+* fast/css/variables/case-sensitive-expected.html: Renamed from
+fast/css/variables/case-insensitive-expected.html.
+* fast/css/variables/case-sensitive.html: Renamed from
+LayoutTests/fast/css/variables/case-insensitive.html.
+
2013-05-16 Gustavo Noronha Silva
[GTK] Build Xvfb with jhbuild
Deleted: trunk/LayoutTests/fast/css/variables/case-insensitive-expected.html (150206 => 150207)
--- trunk/LayoutTests/fast/css/variables/case-insensitive-expected.html 2013-05-16 21:02:11 UTC (rev 150206)
+++ trunk/LayoutTests/fast/css/variables/case-insensitive-expected.html 2013-05-16 21:04:57 UTC (rev 150207)
@@ -1,9 +0,0 @@
-
-
-
-div {
-background-color: green;
-}
-
-This text should have a green background.
-
Deleted: trunk/LayoutTests/fast/css/variables/case-insensitive.html (150206 => 150207)
--- trunk/LayoutTests/fast/css/variables/case-insensitive.html 2013-05-16 21:02:11 UTC (rev 150206)
+++ trunk/LayoutTests/fast/css/variables/case-insensitive.html 2013-05-16 21:04:57 UTC (rev 150207)
@@ -1,13 +0,0 @@
-
-
-
-internals.settings.setCSSVariablesEnabled(true);
-
-
-div {
- background-color: -webkit-var(NaMe);
- -webkit-var-nAmE: green;
-}
-
-This text should have a green background.
-
Added: trunk/LayoutTests/fast/css/variables/case-sensitive-expected.html (0 => 150207)
--- trunk/LayoutTests/fast/css/variables/case-sensitive-expected.html (rev 0)
+++ trunk/LayoutTests/fast/css/variables/case-sensitive-expected.html 2013-05-16 21:04:57 UTC (rev 150207)
@@ -0,0 +1,4 @@
+
+
+This text should have a transparent background.
+
Copied: trunk/LayoutTests/fast/css/variables/case-sensitive.html (from rev 150206, trunk/LayoutTests/fast/css/variables/case-insensitive.html) (0 => 150207)
--- trunk/LayoutTests/fast/css/variables/case-sensitive.html (rev 0)
+++ trunk/LayoutTests/fast/css/variables/case-sensitive.html 2013-05-16 21:04:57 UTC (rev 150207)
@@ -0,0 +1,13 @@
+
+
+
+internals.settings.setCSSVariablesEnabled(true);
+
+
+div {
+ background-color: -webkit-var(NaMe);
+ -webkit-var-nAmE: green;
+}
+
+This text should have a transparent background.
+
Modified: trunk/Source/WebCore/ChangeLog (150206 => 150207)
--- trunk/Source/WebCore/ChangeLog 2013-05-16 21:02:11 UTC (rev 150206)
+++ trunk/Source/WebCore/ChangeLog 2013-05-16 21:04:57 UTC (rev 150207)
@@ -1,3 +1,27 @@
+2013-05-16 Claudio Saavedra
+
+[CSS] CSS Variables are case-sensitive
+https://bugs.webkit.org/show_bug.cgi?id=116239
+
+Reviewed by Ryosuke Niwa.
+
+The CSS Variables specification states that variables are
+case-sensitive, unlike other CSS properties.
+
+Test: fast/css/variables/case-sensitive.html
+
+* css/CSSParser.cpp:
+(WebCore::CSSParserString::substring): Replace
+the now unnecessary lowerSubstring() with this method.
+Also, since the method is only used by the CSS variables
+implementation, #ifdef it.
+
[webkit-changes] [150206] trunk/Source
Title: [150206] trunk/Source
Revision 150206
Author beid...@apple.com
Date 2013-05-16 14:02:11 -0700 (Thu, 16 May 2013)
Log Message
svg/as-image/img-zoom-svg-stylesheet.html crashes with NetworkProcess enabled.
and https://bugs.webkit.org/show_bug.cgi?id=115917
Reviewed by Sam Weinig.
Source/WebCore:
Give WebKit2 the ability to not mis-cast.
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::isEmptyFrameLoaderClient): Defaults to false, and include a FIXME
to remove it once https://bugs.webkit.org/show_bug.cgi?id=116233 is resolved.
* loader/EmptyClients.h: Make isEmptyFrameLoaderClient() return true, and add a FIXME to remove it.
Source/WebKit2:
* NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::SchedulableLoader): ASSERT that either there’s a frame and page ID, or
that the client cannot be asked for credentials.
* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Only cast the FrameLoaderClient and get WebFrame/WebPage
if that is actually possible. Set the clientCredentialPolicy based on whether or not WebFrame/WebPage are
available since they are needed to ask the UIProcess for credentials. ASSERT that either there’s both
a frame and page ID or that the client won’t be asked for credentials.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebCore/loader/FrameLoaderClient.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/SchedulableLoader.cpp
trunk/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (150205 => 150206)
--- trunk/Source/WebCore/ChangeLog 2013-05-16 20:50:06 UTC (rev 150205)
+++ trunk/Source/WebCore/ChangeLog 2013-05-16 21:02:11 UTC (rev 150206)
@@ -1,3 +1,18 @@
+2013-05-16 Brady Eidson
+
+svg/as-image/img-zoom-svg-stylesheet.html crashes with NetworkProcess enabled.
+ and https://bugs.webkit.org/show_bug.cgi?id=115917
+
+Reviewed by Sam Weinig.
+
+Give WebKit2 the ability to not mis-cast.
+
+* loader/FrameLoaderClient.h:
+(WebCore::FrameLoaderClient::isEmptyFrameLoaderClient): Defaults to false, and include a FIXME
+ to remove it once https://bugs.webkit.org/show_bug.cgi?id=116233 is resolved.
+
+* loader/EmptyClients.h: Make isEmptyFrameLoaderClient() return true, and add a FIXME to remove it.
+
2013-05-14 Martin Robinson
[GTK] Add support for building WebCore to the cmake build
Modified: trunk/Source/WebCore/loader/EmptyClients.h (150205 => 150206)
--- trunk/Source/WebCore/loader/EmptyClients.h 2013-05-16 20:50:06 UTC (rev 150205)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2013-05-16 21:02:11 UTC (rev 150206)
@@ -209,6 +209,8 @@
virtual bool shouldNotifyOnFormChanges() { return false; }
};
+// FIXME (bug 116233): Get rid of EmptyFrameLoaderClient. It is a travesty.
+
class EmptyFrameLoaderClient : public FrameLoaderClient {
WTF_MAKE_NONCOPYABLE(EmptyFrameLoaderClient); WTF_MAKE_FAST_ALLOCATED;
public:
@@ -373,6 +375,8 @@
#endif
virtual PassRefPtr createNetworkingContext() OVERRIDE;
+
+virtual bool isEmptyFrameLoaderClient() OVERRIDE { return true; }
};
class EmptyTextCheckerClient : public TextCheckerClient {
Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (150205 => 150206)
--- trunk/Source/WebCore/loader/FrameLoaderClient.h 2013-05-16 20:50:06 UTC (rev 150205)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h 2013-05-16 21:02:11 UTC (rev 150206)
@@ -348,6 +348,9 @@
virtual void dispatchWillInsertBody() { }
virtual void dispatchDidChangeResourcePriority(unsigned long /*identifier*/, ResourceLoadPriority) { }
+
+// FIXME (bug 116233): We need to get rid of EmptyFrameLoaderClient completely, then this will no longer be needed.
+virtual bool isEmptyFrameLoaderClient() { return false; }
};
} // namespace WebCore
Modified: trunk/Source/WebKit2/ChangeLog (150205 => 150206)
--- trunk/Source/WebKit2/ChangeLog 2013-05-16 20:50:06 UTC (rev 150205)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-16 21:02:11 UTC (rev 150206)
@@ -1,3 +1,20 @@
+2013-05-16 Brady Eidson
+
+svg/as-image/img-zoom-svg-stylesheet.html crashes with NetworkProcess enabled.
+ and https://bugs.webkit.org/show_bug.cgi?id=115917
+
+Reviewed by Sam Weinig.
+
+* NetworkProcess/SchedulableLoader.cpp:
+(WebKit::SchedulableLoader::SchedulableLoader): ASSERT that either there’s a frame and page ID, or
+ that the client cannot be asked for credentials.
+
+* WebProcess/Network/WebResourceLoadScheduler.cpp:
+(WebKit::WebResourceLoadScheduler::scheduleLoad): Only cast the FrameLoaderClient and get WebFrame/WebPage
+ if that is actually possible. Set the clientCredentialPolicy based on whether or not WebFrame/WebPage are
+ available since they
[webkit-changes] [150205] trunk/Source/WebKit/mac
Title: [150205] trunk/Source/WebKit/mac
Revision 150205
Author m...@apple.com
Date 2013-05-16 13:50:06 -0700 (Thu, 16 May 2013)
Log Message
-webView:updateHistoryTitle:forURL: does not pass a frame to the delegate
https://bugs.webkit.org/show_bug.cgi?id=116243
Reviewed by Anders Carlsson.
Added a WebFrame parameter to the delegate method.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::setTitle): Pass the frame to the delegate. Maintain
compatibility with clients that implement the old delegate method that
doesn’t take a frame.
* WebView/WebDelegateImplementationCaching.h:
(WebHistoryDelegateImplementationCache): Added a field to cache the
implementation of the old delegate method.
* WebView/WebHistoryDelegate.h: Changed the signature of the delegate method.
* WebView/WebView.mm:
(-[WebView _cacheHistoryDelegateImplementations]): Cache the implementation
of the new delegate method, but also check for the old one.
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Source/WebKit/mac/WebView/WebDelegateImplementationCaching.h
trunk/Source/WebKit/mac/WebView/WebHistoryDelegate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (150204 => 150205)
--- trunk/Source/WebKit/mac/ChangeLog 2013-05-16 20:23:09 UTC (rev 150204)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-05-16 20:50:06 UTC (rev 150205)
@@ -1,3 +1,24 @@
+2013-05-16 Dan Bernstein
+
+-webView:updateHistoryTitle:forURL: does not pass a frame to the delegate
+https://bugs.webkit.org/show_bug.cgi?id=116243
+
+Reviewed by Anders Carlsson.
+
+Added a WebFrame parameter to the delegate method.
+
+* WebCoreSupport/WebFrameLoaderClient.mm:
+(WebFrameLoaderClient::setTitle): Pass the frame to the delegate. Maintain
+compatibility with clients that implement the old delegate method that
+doesn’t take a frame.
+* WebView/WebDelegateImplementationCaching.h:
+(WebHistoryDelegateImplementationCache): Added a field to cache the
+implementation of the old delegate method.
+* WebView/WebHistoryDelegate.h: Changed the signature of the delegate method.
+* WebView/WebView.mm:
+(-[WebView _cacheHistoryDelegateImplementations]): Cache the implementation
+of the new delegate method, but also check for the old one.
+
2013-05-16 Simon Fraser
Re-land r150168 with some OS version guards.
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (150204 => 150205)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2013-05-16 20:23:09 UTC (rev 150204)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2013-05-16 20:50:06 UTC (rev 150205)
@@ -1173,11 +1173,12 @@
if ([view historyDelegate]) {
WebHistoryDelegateImplementationCache* implementations = WebViewGetHistoryDelegateImplementations(view);
-if (!implementations->setTitleFunc)
-return;
-
// FIXME: use direction of title.
-CallHistoryDelegate(implementations->setTitleFunc, view, @selector(webView:updateHistoryTitle:forURL:), (NSString *)title.string(), (NSString *)url);
+if (implementations->setTitleFunc)
+CallHistoryDelegate(implementations->setTitleFunc, view, @selector(webView:updateHistoryTitle:forURL:inFrame:), (NSString *)title.string(), (NSString *)url, m_webFrame.get());
+else if (implementations->deprecatedSetTitleFunc)
+CallHistoryDelegate(implementations->deprecatedSetTitleFunc, view, @selector(webView:updateHistoryTitle:forURL:), (NSString *)title.string(), (NSString *)url);
+
return;
}
Modified: trunk/Source/WebKit/mac/WebView/WebDelegateImplementationCaching.h (150204 => 150205)
--- trunk/Source/WebKit/mac/WebView/WebDelegateImplementationCaching.h 2013-05-16 20:23:09 UTC (rev 150204)
+++ trunk/Source/WebKit/mac/WebView/WebDelegateImplementationCaching.h 2013-05-16 20:50:06 UTC (rev 150205)
@@ -101,6 +101,7 @@
IMP navigatedFunc;
IMP clientRedirectFunc;
IMP serverRedirectFunc;
+IMP deprecatedSetTitleFunc;
IMP setTitleFunc;
IMP populateVisitedLinksFunc;
};
Modified: trunk/Source/WebKit/mac/WebView/WebHistoryDelegate.h (150204 => 150205)
--- trunk/Source/WebKit/mac/WebView/WebHistoryDelegate.h 2013-05-16 20:23:09 UTC (rev 150204)
+++ trunk/Source/WebKit/mac/WebView/WebHistoryDelegate.h 2013-05-16 20:50:06 UTC (rev 150205)
@@ -37,7 +37,7 @@
- (void)webView:(WebView *)webView didPerformServerRedirectFromURL:(NSString *)sourceURL toURL:(NSString *)destinationURL inFrame:(WebFrame *)webFrame;
-- (void)webView:(WebView *)webView updateHistoryTitle:(NSString *)title forURL:(NSString *)url;
+- (void)webView:(WebView *)webView updateHistoryTitle:(NSString *)title forURL:(NSString *)url inFrame:(WebFrame *)webFrame;
- (void)populat
[webkit-changes] [150194] trunk/Source/WebKit/mac
Title: [150194] trunk/Source/WebKit/mac
Revision 150194
Author simon.fra...@apple.com
Date 2013-05-16 11:40:16 -0700 (Thu, 16 May 2013)
Log Message
Re-land r150168 with some OS version guards.
* WebView/WebFrameView.mm:
(-[WebFrameView drawRect:]):
(-[WebFrameView wantsUpdateLayer]):
(-[WebFrameView updateLayer]):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebFrameView.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (150193 => 150194)
--- trunk/Source/WebKit/mac/ChangeLog 2013-05-16 18:30:55 UTC (rev 150193)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-05-16 18:40:16 UTC (rev 150194)
@@ -1,3 +1,12 @@
+2013-05-16 Simon Fraser
+
+Re-land r150168 with some OS version guards.
+
+* WebView/WebFrameView.mm:
+(-[WebFrameView drawRect:]):
+(-[WebFrameView wantsUpdateLayer]):
+(-[WebFrameView updateLayer]):
+
2013-05-16 Commit Queue
Unreviewed, rolling out r150168.
Modified: trunk/Source/WebKit/mac/WebView/WebFrameView.mm (150193 => 150194)
--- trunk/Source/WebKit/mac/WebView/WebFrameView.mm 2013-05-16 18:30:55 UTC (rev 150193)
+++ trunk/Source/WebKit/mac/WebView/WebFrameView.mm 2013-05-16 18:40:16 UTC (rev 150194)
@@ -79,6 +79,12 @@
- (BOOL)_scrollTo:(const NSPoint *)newOrigin animate:(BOOL)animate; // need the boolean result from this method
@end
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+@interface NSView (Details)
+- (void)setBackgroundColor:(NSColor *)color;
+@end
+#endif
+
enum {
SpaceKey = 0x0020
};
@@ -458,7 +464,7 @@
- (void)drawRect:(NSRect)rect
{
-if ([self documentView] == nil) {
+if (![self documentView]) {
// Need to paint ourselves if there's no documentView to do it instead.
if ([[self _webView] drawsBackground]) {
[[[self _webView] backgroundColor] set];
@@ -474,6 +480,34 @@
}
}
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+- (BOOL)wantsUpdateLayer
+{
+return YES;
+}
+
+- (void)updateLayer
+{
+// Do what -drawRect: does but by setting a backgroundColor on the view. This avoids
+// backing store for this view when the WebView is layer-backed.
+if (![self documentView]) {
+if ([[self _webView] drawsBackground]) {
+[self setBackgroundColor:[[self _webView] backgroundColor]];
+return;
+}
+} else {
+#ifndef NDEBUG
+if ([[self _scrollView] drawsBackground]) {
+[self setBackgroundColor:[NSColor cyanColor]];
+return;
+}
+#endif
+}
+
+[self setBackgroundColor:[NSColor clearColor]];
+}
+#endif
+
- (NSRect)visibleRect
{
// This method can be called beneath -[NSView dealloc] after we have cleared _private.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150203] tags/Safari-537.42/Source/WebKit/mac
Title: [150203] tags/Safari-537.42/Source/WebKit/mac
Revision 150203
Author lforsch...@apple.com
Date 2013-05-16 12:37:12 -0700 (Thu, 16 May 2013)
Log Message
Merged r150194.
Modified Paths
tags/Safari-537.42/Source/WebKit/mac/ChangeLog
tags/Safari-537.42/Source/WebKit/mac/WebView/WebFrameView.mm
Diff
Modified: tags/Safari-537.42/Source/WebKit/mac/ChangeLog (150202 => 150203)
--- tags/Safari-537.42/Source/WebKit/mac/ChangeLog 2013-05-16 19:33:28 UTC (rev 150202)
+++ tags/Safari-537.42/Source/WebKit/mac/ChangeLog 2013-05-16 19:37:12 UTC (rev 150203)
@@ -1,5 +1,18 @@
2013-05-16 Lucas Forschler
+Merge r150194
+
+2013-05-16 Simon Fraser
+
+Re-land r150168 with some OS version guards.
+
+* WebView/WebFrameView.mm:
+(-[WebFrameView drawRect:]):
+(-[WebFrameView wantsUpdateLayer]):
+(-[WebFrameView updateLayer]):
+
+2013-05-16 Lucas Forschler
+
Merge r150180
2013-05-16 Commit Queue
Modified: tags/Safari-537.42/Source/WebKit/mac/WebView/WebFrameView.mm (150202 => 150203)
--- tags/Safari-537.42/Source/WebKit/mac/WebView/WebFrameView.mm 2013-05-16 19:33:28 UTC (rev 150202)
+++ tags/Safari-537.42/Source/WebKit/mac/WebView/WebFrameView.mm 2013-05-16 19:37:12 UTC (rev 150203)
@@ -79,6 +79,12 @@
- (BOOL)_scrollTo:(const NSPoint *)newOrigin animate:(BOOL)animate; // need the boolean result from this method
@end
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+@interface NSView (Details)
+- (void)setBackgroundColor:(NSColor *)color;
+@end
+#endif
+
enum {
SpaceKey = 0x0020
};
@@ -458,7 +464,7 @@
- (void)drawRect:(NSRect)rect
{
-if ([self documentView] == nil) {
+if (![self documentView]) {
// Need to paint ourselves if there's no documentView to do it instead.
if ([[self _webView] drawsBackground]) {
[[[self _webView] backgroundColor] set];
@@ -474,6 +480,34 @@
}
}
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+- (BOOL)wantsUpdateLayer
+{
+return YES;
+}
+
+- (void)updateLayer
+{
+// Do what -drawRect: does but by setting a backgroundColor on the view. This avoids
+// backing store for this view when the WebView is layer-backed.
+if (![self documentView]) {
+if ([[self _webView] drawsBackground]) {
+[self setBackgroundColor:[[self _webView] backgroundColor]];
+return;
+}
+} else {
+#ifndef NDEBUG
+if ([[self _scrollView] drawsBackground]) {
+[self setBackgroundColor:[NSColor cyanColor]];
+return;
+}
+#endif
+}
+
+[self setBackgroundColor:[NSColor clearColor]];
+}
+#endif
+
- (NSRect)visibleRect
{
// This method can be called beneath -[NSView dealloc] after we have cleared _private.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150202] tags/Safari-537.42/Source/WebKit/mac
Title: [150202] tags/Safari-537.42/Source/WebKit/mac
Revision 150202
Author lforsch...@apple.com
Date 2013-05-16 12:33:28 -0700 (Thu, 16 May 2013)
Log Message
Merge r150180.
Modified Paths
tags/Safari-537.42/Source/WebKit/mac/ChangeLog
tags/Safari-537.42/Source/WebKit/mac/WebView/WebFrameView.mm
Diff
Modified: tags/Safari-537.42/Source/WebKit/mac/ChangeLog (150201 => 150202)
--- tags/Safari-537.42/Source/WebKit/mac/ChangeLog 2013-05-16 19:19:25 UTC (rev 150201)
+++ tags/Safari-537.42/Source/WebKit/mac/ChangeLog 2013-05-16 19:33:28 UTC (rev 150202)
@@ -1,3 +1,19 @@
+2013-05-16 Lucas Forschler
+
+Merge r150180
+
+2013-05-16 Commit Queue
+
+Unreviewed, rolling out r150168.
+http://trac.webkit.org/changeset/150168
+https://bugs.webkit.org/show_bug.cgi?id=116214
+
+broke the world on Mountain Lion (Requested by thorton on
+#webkit).
+
+* WebView/WebFrameView.mm:
+(-[WebFrameView drawRect:]):
+
2013-05-15 Simon Fraser
Avoid backing store for the WebFrameView's layer when the WebView is layer-backed
Modified: tags/Safari-537.42/Source/WebKit/mac/WebView/WebFrameView.mm (150201 => 150202)
--- tags/Safari-537.42/Source/WebKit/mac/WebView/WebFrameView.mm 2013-05-16 19:19:25 UTC (rev 150201)
+++ tags/Safari-537.42/Source/WebKit/mac/WebView/WebFrameView.mm 2013-05-16 19:33:28 UTC (rev 150202)
@@ -79,10 +79,6 @@
- (BOOL)_scrollTo:(const NSPoint *)newOrigin animate:(BOOL)animate; // need the boolean result from this method
@end
-@interface NSView (Details)
-- (void)setBackgroundColor:(NSColor *)color;
-@end
-
enum {
SpaceKey = 0x0020
};
@@ -462,7 +458,7 @@
- (void)drawRect:(NSRect)rect
{
-if (![self documentView]) {
+if ([self documentView] == nil) {
// Need to paint ourselves if there's no documentView to do it instead.
if ([[self _webView] drawsBackground]) {
[[[self _webView] backgroundColor] set];
@@ -478,32 +474,6 @@
}
}
-- (BOOL)wantsUpdateLayer
-{
-return YES;
-}
-
-- (void)updateLayer
-{
-// Do what -drawRect: does but by setting a backgroundColor on the view. This avoids
-// backing store for this view when the WebView is layer-backed.
-if (![self documentView]) {
-if ([[self _webView] drawsBackground]) {
-[self setBackgroundColor:[[self _webView] backgroundColor]];
-return;
-}
-} else {
-#ifndef NDEBUG
-if ([[self _scrollView] drawsBackground]) {
-[self setBackgroundColor:[NSColor cyanColor]];
-return;
-}
-#endif
-}
-
-[self setBackgroundColor:[NSColor clearColor]];
-}
-
- (NSRect)visibleRect
{
// This method can be called beneath -[NSView dealloc] after we have cleared _private.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150201] trunk/LayoutTests
Title: [150201] trunk/LayoutTests Revision 150201 Author rn...@webkit.org Date 2013-05-16 12:19:25 -0700 (Thu, 16 May 2013) Log Message Add more Mac test expectations. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (150200 => 150201) --- trunk/LayoutTests/ChangeLog 2013-05-16 19:13:32 UTC (rev 150200) +++ trunk/LayoutTests/ChangeLog 2013-05-16 19:19:25 UTC (rev 150201) @@ -1,5 +1,11 @@ 2013-05-16 Ryosuke Niwa +Add more Mac test expectations. + +* platform/mac/TestExpectations: + +2013-05-16 Ryosuke Niwa + Add a test expectation per bug 116238 and remove lines erroneously added in r150090. * platform/mac/TestExpectations: Modified: trunk/LayoutTests/platform/mac/TestExpectations (150200 => 150201) --- trunk/LayoutTests/platform/mac/TestExpectations 2013-05-16 19:13:32 UTC (rev 150200) +++ trunk/LayoutTests/platform/mac/TestExpectations 2013-05-16 19:19:25 UTC (rev 150201) @@ -1540,3 +1540,7 @@ editing/secure-input/reset-state-on-navigation.html [ Failure ] webkit.org/b/116238 css3/filters/custom/filter-fallback-to-software.html [ ImageOnlyFailure ] + +webkit.org/b/116240 [ Release ] fast/flexbox/auto-height-with-flex.html [ ImageOnlyFailure ] + +webkit.org/b/116241 inspector/storage-panel-dom-storage-update.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150200] trunk/Source/WebKit2
Title: [150200] trunk/Source/WebKit2
Revision 150200
Author timo...@apple.com
Date 2013-05-16 12:13:32 -0700 (Thu, 16 May 2013)
Log Message
Make the Find Banner in Safari work again with the docked Web Inspector.
https://webkit.org/b/116182
rdar://problem/13857423
Reviewed by Benjamin Poulain.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
(WebKit::WebInspectorProxy::platformDetach):
Preserve the top position of the inspected view so banners in Safari still work.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (150199 => 150200)
--- trunk/Source/WebKit2/ChangeLog 2013-05-16 19:11:43 UTC (rev 150199)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-16 19:13:32 UTC (rev 150200)
@@ -1,3 +1,17 @@
+2013-05-16 Timothy Hatcher
+
+Make the Find Banner in Safari work again with the docked Web Inspector.
+
+https://webkit.org/b/116182
+rdar://problem/13857423
+
+Reviewed by Benjamin Poulain.
+
+* UIProcess/mac/WebInspectorProxyMac.mm:
+(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
+(WebKit::WebInspectorProxy::platformDetach):
+Preserve the top position of the inspected view so banners in Safari still work.
+
2013-05-16 Tim Horton
[wk2] Minimum layout width is lost if the WebProcess crashes
Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (150199 => 150200)
--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2013-05-16 19:11:43 UTC (rev 150199)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2013-05-16 19:13:32 UTC (rev 150200)
@@ -625,6 +625,7 @@
NSRect inspectedViewFrame = [inspectedView frame];
NSRect inspectorFrame = NSZeroRect;
NSRect parentBounds = [[inspectedView superview] bounds];
+CGFloat inspectedViewTop = NSMaxY(inspectedViewFrame);
switch (m_attachmentSide) {
case AttachmentSideBottom: {
@@ -634,7 +635,8 @@
CGFloat parentHeight = NSHeight(parentBounds);
CGFloat inspectorHeight = InspectorFrontendClientLocal::constrainedAttachedWindowHeight(currentDimension, parentHeight);
-inspectedViewFrame = NSMakeRect(0, inspectorHeight, NSWidth(parentBounds), parentHeight - inspectorHeight);
+// Preserve the top position of the inspected view so banners in Safari still work.
+inspectedViewFrame = NSMakeRect(0, inspectorHeight, NSWidth(parentBounds), inspectedViewTop - inspectorHeight);
inspectorFrame = NSMakeRect(0, 0, NSWidth(inspectedViewFrame), inspectorHeight);
break;
}
@@ -646,8 +648,10 @@
CGFloat parentWidth = NSWidth(parentBounds);
CGFloat inspectorWidth = InspectorFrontendClientLocal::constrainedAttachedWindowWidth(currentDimension, parentWidth);
-inspectedViewFrame = NSMakeRect(0, 0, parentWidth - inspectorWidth, NSHeight(parentBounds));
-inspectorFrame = NSMakeRect(parentWidth - inspectorWidth, 0, inspectorWidth, NSHeight(inspectedViewFrame));
+// Preserve the top position of the inspected view so banners in Safari still work. But don't use that
+// top position for the inspector view since the banners only stretch as wide as the the inspected view.
+inspectedViewFrame = NSMakeRect(0, 0, parentWidth - inspectorWidth, inspectedViewTop);
+inspectorFrame = NSMakeRect(parentWidth - inspectorWidth, 0, inspectorWidth, NSHeight(parentBounds));
break;
}
}
@@ -714,9 +718,9 @@
[m_inspectorView.get() removeFromSuperview];
// Make sure that we size the inspected view's frame after detaching so that it takes up the space that the
-// attached inspector used to.
+// attached inspector used to. Preserve the top position of the inspected view so banners in Safari still work.
-[inspectedView setFrame:[[inspectedView superview] bounds]];
+inspectedView.frame = NSMakeRect(0, 0, NSWidth(inspectedView.superview.bounds), NSMaxY(inspectedView.frame));
// Return early if we are not visible. This means the inspector was closed while attached
// and we should not create and show the inspector window.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150199] trunk/Source/JavaScriptCore
Title: [150199] trunk/Source/_javascript_Core
Revision 150199
Author gga...@apple.com
Date 2013-05-16 12:11:43 -0700 (Thu, 16 May 2013)
Log Message
JSValue shouldn't protect/unprotect its context
https://bugs.webkit.org/show_bug.cgi?id=116234
Reviewed by Mark Hahnenberg.
Our retain on _context is sufficient.
* API/JSValue.mm:
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
Modified Paths
trunk/Source/_javascript_Core/API/JSValue.mm
trunk/Source/_javascript_Core/ChangeLog
Diff
Modified: trunk/Source/_javascript_Core/API/JSValue.mm (150198 => 150199)
--- trunk/Source/_javascript_Core/API/JSValue.mm 2013-05-16 19:09:57 UTC (rev 150198)
+++ trunk/Source/_javascript_Core/API/JSValue.mm 2013-05-16 19:11:43 UTC (rev 150199)
@@ -971,7 +971,6 @@
_context = [context retain];
m_value = value;
-JSValueProtect([_context JSGlobalContextRef], m_value);
return self;
}
@@ -1089,7 +1088,6 @@
- (void)dealloc
{
-JSValueUnprotect([_context JSGlobalContextRef], m_value);
[_context release];
_context = nil;
[super dealloc];
Modified: trunk/Source/_javascript_Core/ChangeLog (150198 => 150199)
--- trunk/Source/_javascript_Core/ChangeLog 2013-05-16 19:09:57 UTC (rev 150198)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-05-16 19:11:43 UTC (rev 150199)
@@ -1,3 +1,16 @@
+2013-05-16 Geoffrey Garen
+
+JSValue shouldn't protect/unprotect its context
+https://bugs.webkit.org/show_bug.cgi?id=116234
+
+Reviewed by Mark Hahnenberg.
+
+Our retain on _context is sufficient.
+
+* API/JSValue.mm:
+(-[JSValue initWithValue:inContext:]):
+(-[JSValue dealloc]):
+
2013-05-15 Ryosuke Niwa
Another Windows build fix attempt after r150160.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150198] trunk/Tools
Title: [150198] trunk/Tools
Revision 150198
Author k...@webkit.org
Date 2013-05-16 12:09:57 -0700 (Thu, 16 May 2013)
Log Message
[jhbuild] Should remove the sources directory as well when cleaning
https://bugs.webkit.org/show_bug.cgi?id=116229
Patch by Gustavo Noronha Silva on 2013-05-16
Reviewed by Martin Robinson.
* Scripts/update-webkit-libs-jhbuild:
(cleanJhbuild): remove the Source directory as well when cleaning.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/update-webkit-libs-jhbuild
Diff
Modified: trunk/Tools/ChangeLog (150197 => 150198)
--- trunk/Tools/ChangeLog 2013-05-16 19:08:38 UTC (rev 150197)
+++ trunk/Tools/ChangeLog 2013-05-16 19:09:57 UTC (rev 150198)
@@ -1,3 +1,13 @@
+2013-05-16 Gustavo Noronha Silva
+
+[jhbuild] Should remove the sources directory as well when cleaning
+https://bugs.webkit.org/show_bug.cgi?id=116229
+
+Reviewed by Martin Robinson.
+
+* Scripts/update-webkit-libs-jhbuild:
+(cleanJhbuild): remove the Source directory as well when cleaning.
+
2013-05-15 Dominik Röttsches
[EFL] Remove Intel Wk2 Buildbots from Master
Modified: trunk/Tools/Scripts/update-webkit-libs-jhbuild (150197 => 150198)
--- trunk/Tools/Scripts/update-webkit-libs-jhbuild 2013-05-16 19:08:38 UTC (rev 150197)
+++ trunk/Tools/Scripts/update-webkit-libs-jhbuild 2013-05-16 19:09:57 UTC (rev 150198)
@@ -101,8 +101,6 @@
sub cleanJhbuild()
{
-runJhbuild("clean");
-
# If the configuration changed, dependencies may have been removed.
# Since we lack a granular way of uninstalling those we wipe out the
# jhbuild root and start from scratch.
@@ -110,6 +108,10 @@
if (system("rm -rf $jhbuildPath/Root") ne 0) {
die "Cleaning jhbuild root failed!";
}
+
+if (system("rm -rf $jhbuildPath/Source") ne 0) {
+die "Cleaning jhbuild sources failed!";
+}
}
delete $ENV{AR_FLAGS} if exists $ENV{AR_FLAGS};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150197] trunk/Source/WebKit2
Title: [150197] trunk/Source/WebKit2 Revision 150197 Author timothy_hor...@apple.com Date 2013-05-16 12:08:38 -0700 (Thu, 16 May 2013) Log Message [wk2] Minimum layout width is lost if the WebProcess crashes https://bugs.webkit.org/show_bug.cgi?id=116202 Reviewed by Darin Adler. Send the minimum layout width to the WebProcess upon initialization, so that crashed-and-restarted WebProcesses have the correct width. * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): * Shared/WebPageCreationParameters.h: (WebPageCreationParameters): Add minimumLayoutWidth WebPage creation parameter. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): Send the current minimumLayoutWidth to the WebPage when it's created. (WebKit::WebPageProxy::setMinimumLayoutWidth): Store minimumLayoutWidth changes that come in while the WebProcess is not valid, so that the correct width is sent once it is restarted. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Set minimumLayoutWidth to the value provided by our creation parameters. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp trunk/Source/WebKit2/Shared/WebPageCreationParameters.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (150196 => 150197) --- trunk/Source/WebKit2/ChangeLog 2013-05-16 19:03:16 UTC (rev 150196) +++ trunk/Source/WebKit2/ChangeLog 2013-05-16 19:08:38 UTC (rev 150197) @@ -1,3 +1,33 @@ +2013-05-16 Tim Horton + +[wk2] Minimum layout width is lost if the WebProcess crashes +https://bugs.webkit.org/show_bug.cgi?id=116202 + + +Reviewed by Darin Adler. + +Send the minimum layout width to the WebProcess upon initialization, +so that crashed-and-restarted WebProcesses have the correct width. + +* Shared/WebPageCreationParameters.cpp: +(WebKit::WebPageCreationParameters::encode): +(WebKit::WebPageCreationParameters::decode): +* Shared/WebPageCreationParameters.h: +(WebPageCreationParameters): +Add minimumLayoutWidth WebPage creation parameter. + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::creationParameters): +Send the current minimumLayoutWidth to the WebPage when it's created. + +(WebKit::WebPageProxy::setMinimumLayoutWidth): +Store minimumLayoutWidth changes that come in while the WebProcess is +not valid, so that the correct width is sent once it is restarted. + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::WebPage): +Set minimumLayoutWidth to the value provided by our creation parameters. + 2013-05-16 Zoltan Arvai [Win] Unreviewed buildfix after r150161. Modified: trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp (150196 => 150197) --- trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp 2013-05-16 19:03:16 UTC (rev 150196) +++ trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp 2013-05-16 19:08:38 UTC (rev 150197) @@ -60,6 +60,7 @@ encoder << mediaVolume; encoder << mayStartMediaWhenInWindow; encoder << overridePrivateBrowsingEnabled; +encoder << minimumLayoutWidth; #if PLATFORM(MAC) encoder.encodeEnum(layerHostingMode); @@ -123,6 +124,8 @@ return false; if (!decoder.decode(parameters.overridePrivateBrowsingEnabled)) return false; +if (!decoder.decode(parameters.minimumLayoutWidth)) +return false; #if PLATFORM(MAC) if (!decoder.decodeEnum(parameters.layerHostingMode)) Modified: trunk/Source/WebKit2/Shared/WebPageCreationParameters.h (150196 => 150197) --- trunk/Source/WebKit2/Shared/WebPageCreationParameters.h 2013-05-16 19:03:16 UTC (rev 150196) +++ trunk/Source/WebKit2/Shared/WebPageCreationParameters.h 2013-05-16 19:08:38 UTC (rev 150197) @@ -91,6 +91,8 @@ bool overridePrivateBrowsingEnabled; +float minimumLayoutWidth; + #if PLATFORM(MAC) LayerHostingMode layerHostingMode; ColorSpaceData colorSpace; Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (150196 => 150197) --- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2013-05-16 19:03:16 UTC (rev 150196) +++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2013-05-16 19:08:38 UTC (rev 150197) @@ -3943,6 +3943,7 @@ parameters.mediaVolume = m_mediaVolume; parameters.mayStartMediaWhenInWindow = m_mayStartMediaWhenInWindow; parameters.overridePrivateBrowsingEnabled = m_overridePrivateBrowsingEnabled; +parameters.minimumLayoutWidth = m_minimumLayoutWidth; #if PLATFORM(MAC) parameters.layerHostingMode = m_layerHostingMode; @@ -4312,10 +4313,11 @@ if (m_minimumLayoutWidth == minimumLayoutWidth) return; +m_minimumLayoutWidth = minimumLayoutWidth; + if (!is
[webkit-changes] [150196] trunk/Source
Title: [150196] trunk/Source
Revision 150196
Author benja...@webkit.org
Date 2013-05-16 12:03:16 -0700 (Thu, 16 May 2013)
Log Message
Crash properly on iOS
https://bugs.webkit.org/show_bug.cgi?id=115782
Reviewed by Darin Adler.
Improve crash handling.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
Modified Paths
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_CoreExports.def
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreExportGenerator/_javascript_CoreExports.def.in
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Assertions.cpp
trunk/Source/WTF/wtf/Assertions.h
Diff
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_CoreExports.def (150195 => 150196)
--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_CoreExports.def 2013-05-16 19:00:36 UTC (rev 150195)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_CoreExports.def 2013-05-16 19:03:16 UTC (rev 150196)
@@ -555,8 +555,8 @@
?writeBarrier@HandleSet@JSC@@QAEXPAVJSValue@2@ABV32@@Z
?yield@WTF@@YAXXZ
?zeroTime@MediaTime@WTF@@SAABV12@XZ
+WTFCrash
WTFGetBacktrace
-WTFInvokeCrashHook
WTFLog
WTFLogAlways
WTFLogVerbose
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreExportGenerator/_javascript_CoreExports.def.in (150195 => 150196)
--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreExportGenerator/_javascript_CoreExports.def.in 2013-05-16 19:00:36 UTC (rev 150195)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreExportGenerator/_javascript_CoreExports.def.in 2013-05-16 19:03:16 UTC (rev 150196)
@@ -554,8 +554,8 @@
?writeBarrier@HandleSet@JSC@@QAEXPAVJSValue@2@ABV32@@Z
?yield@WTF@@YAXXZ
?zeroTime@MediaTime@WTF@@SAABV12@XZ
+WTFCrash
WTFGetBacktrace
-WTFInvokeCrashHook
WTFLog
WTFLogAlways
WTFLogVerbose
Modified: trunk/Source/WTF/ChangeLog (150195 => 150196)
--- trunk/Source/WTF/ChangeLog 2013-05-16 19:00:36 UTC (rev 150195)
+++ trunk/Source/WTF/ChangeLog 2013-05-16 19:03:16 UTC (rev 150196)
@@ -1,3 +1,15 @@
+2013-05-16 Benjamin Poulain
+
+Crash properly on iOS
+https://bugs.webkit.org/show_bug.cgi?id=115782
+
+Reviewed by Darin Adler.
+
+Improve crash handling.
+
+* wtf/Assertions.cpp:
+* wtf/Assertions.h:
+
2013-05-15 Ryuan Choi
Unreviewed build fix after r150123
Modified: trunk/Source/WTF/wtf/Assertions.cpp (150195 => 150196)
--- trunk/Source/WTF/wtf/Assertions.cpp 2013-05-16 19:00:36 UTC (rev 150195)
+++ trunk/Source/WTF/wtf/Assertions.cpp 2013-05-16 19:03:16 UTC (rev 150196)
@@ -326,10 +326,19 @@
globalHook = function;
}
-void WTFInvokeCrashHook()
+void WTFCrash()
{
if (globalHook)
globalHook();
+
+WTFReportBacktrace();
+*(int *)(uintptr_t)0xbbadbeef = 0;
+// More reliable, but doesn't say BBADBEEF.
+#if COMPILER(CLANG)
+__builtin_trap();
+#else
+((void(*)())0)();
+#endif
}
#if HAVE(SIGNAL_H)
Modified: trunk/Source/WTF/wtf/Assertions.h (150195 => 150196)
--- trunk/Source/WTF/wtf/Assertions.h 2013-05-16 19:00:36 UTC (rev 150195)
+++ trunk/Source/WTF/wtf/Assertions.h 2013-05-16 19:03:16 UTC (rev 150196)
@@ -123,7 +123,6 @@
typedef void (*WTFCrashHookFunction)();
WTF_EXPORT_PRIVATE void WTFSetCrashHook(WTFCrashHookFunction);
-WTF_EXPORT_PRIVATE void WTFInvokeCrashHook();
WTF_EXPORT_PRIVATE void WTFInstallReportBacktraceOnCrashHook();
#ifdef __cplusplus
@@ -138,30 +137,24 @@
Signals are ignored by the crash reporter on OS X so we must do better.
*/
-#ifndef CRASH
#if COMPILER(CLANG)
-#define CRASH() \
-(WTFReportBacktrace(), \
- WTFInvokeCrashHook(), \
- (*(int *)(uintptr_t)0xbbadbeef = 0), \
- __builtin_trap())
-#else
-#define CRASH() \
-(WTFReportBacktrace(), \
- WTFInvokeCrashHook(), \
- (*(int *)(uintptr_t)0xbbadbeef = 0), \
- ((void(*)())0)() /* More reliable, but doesn't say BBADBEEF */ \
-)
-#endif
-#endif
-
-#if COMPILER(CLANG)
#define NO_RETURN_DUE_TO_CRASH NO_RETURN
#else
#define NO_RETURN_DUE_TO_CRASH
#endif
+#ifndef CRASH
+#define CRASH() WTFCrash()
+#endif
+#ifdef __cplusplus
+extern "C" {
+#endif
+WTF_EXPORT_PRIVATE void WTFCrash() NO_RETURN_DUE_TO_CRASH;
+#ifdef __cplusplus
+}
+#endif
+
/* BACKTRACE
Print a backtrace to the same location as ASSERT messages.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150195] trunk/LayoutTests
Title: [150195] trunk/LayoutTests Revision 150195 Author rn...@webkit.org Date 2013-05-16 12:00:36 -0700 (Thu, 16 May 2013) Log Message Add a test expectation per bug 116238 and remove lines erroneously added in r150090. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (150194 => 150195) --- trunk/LayoutTests/ChangeLog 2013-05-16 18:40:16 UTC (rev 150194) +++ trunk/LayoutTests/ChangeLog 2013-05-16 19:00:36 UTC (rev 150195) @@ -1,5 +1,11 @@ 2013-05-16 Ryosuke Niwa +Add a test expectation per bug 116238 and remove lines erroneously added in r150090. + +* platform/mac/TestExpectations: + +2013-05-16 Ryosuke Niwa + Mac rebaseline. The flakiness dashboard tells us that it started at r150101 but reverting the change locally didn't fix the problem as far as Beth and I checked. Modified: trunk/LayoutTests/platform/mac/TestExpectations (150194 => 150195) --- trunk/LayoutTests/platform/mac/TestExpectations 2013-05-16 18:40:16 UTC (rev 150194) +++ trunk/LayoutTests/platform/mac/TestExpectations 2013-05-16 19:00:36 UTC (rev 150195) @@ -1539,30 +1539,4 @@ # Fails with WebKit1 only. editing/secure-input/reset-state-on-navigation.html [ Failure ] -# Needs rebaseline after bug https://bugs.webkit.org/show_bug.cgi?id=52185 -webkit.org/b/52185 fast/table/007.html [ Failure Rebaseline ] -webkit.org/b/52185 fast/table/colspanMinWidth.html [ Failure Rebaseline ] -webkit.org/b/52185 fast/table/colspanMinWidth-vertical.html [ Failure Rebaseline ] -webkit.org/b/52185 fast/table/spanOverlapRepaint.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug13169.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug133756-1.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug133756-2.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug17138.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug17548.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug220536.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug6304.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug73321.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug7714.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug86708.html [ ImageOnlyFailure Rebaseline ] -webkit.org/b/52185 tables/mozilla/bugs/bug8858.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/core/bloomberg.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/core/cell_heights.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla/other/test6.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug1010.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug131020-3.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug23847.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug58402-2.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug65372.html [ Failure Rebaseline ] -webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug6933.html [ Failure Rebaseline ] -webkit.org/b/52185 accessibility/table-cells.html [ Failure Rebaseline ] -webkit.org/b/52185 accessibility/table-attributes.html [ Failure Rebaseline ] +webkit.org/b/116238 css3/filters/custom/filter-fallback-to-software.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150193] trunk/LayoutTests
Title: [150193] trunk/LayoutTests
Revision 150193
Author rn...@webkit.org
Date 2013-05-16 11:30:55 -0700 (Thu, 16 May 2013)
Log Message
Mac rebaseline. The flakiness dashboard tells us that it started at r150101
but reverting the change locally didn't fix the problem as far as Beth and I checked.
* platform/mac/platform/mac/fast/text/thai-combining-mark-positioning-expected.txt: Added.
* platform/mac/platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/mac/platform/mac/fast/text/thai-combining-mark-positioning-expected.txt
trunk/LayoutTests/platform/mac/platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (150192 => 150193)
--- trunk/LayoutTests/ChangeLog 2013-05-16 18:30:19 UTC (rev 150192)
+++ trunk/LayoutTests/ChangeLog 2013-05-16 18:30:55 UTC (rev 150193)
@@ -1,3 +1,11 @@
+2013-05-16 Ryosuke Niwa
+
+Mac rebaseline. The flakiness dashboard tells us that it started at r150101
+but reverting the change locally didn't fix the problem as far as Beth and I checked.
+
+* platform/mac/platform/mac/fast/text/thai-combining-mark-positioning-expected.txt: Added.
+* platform/mac/platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt: Added.
+
2013-05-16 Sergio Villar Senin
Enable the CSSVariables setting in css-variable-definition.html test
Added: trunk/LayoutTests/platform/mac/platform/mac/fast/text/thai-combining-mark-positioning-expected.txt (0 => 150193)
--- trunk/LayoutTests/platform/mac/platform/mac/fast/text/thai-combining-mark-positioning-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/platform/mac/fast/text/thai-combining-mark-positioning-expected.txt 2013-05-16 18:30:55 UTC (rev 150193)
@@ -0,0 +1,8 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 784x101
+RenderText {#text} at (0,0) size 385x101
+ text run at (0,0) width 385: "\x{E43}\x{E2B}\x{E49}\x{E21}\x{E35}\x{E02}\x{E36}\x{E49}\x{E19} \x{E01}\x{E32}\x{E23}\x{E17}\x{E4D}\x{E32}\x{E43}\x{E2B}\x{E49}"
Added: trunk/LayoutTests/platform/mac/platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt (0 => 150193)
--- trunk/LayoutTests/platform/mac/platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt 2013-05-16 18:30:55 UTC (rev 150193)
@@ -0,0 +1,15 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 784x30
+RenderInline {SPAN} at (0,0) size 100x10
+ RenderText {#text} at (0,13) size 100x10
+text run at (0,13) width 100: "Tiny monospace text."
+RenderText {#text} at (100,0) size 6x30
+ text run at (100,0) width 6: " "
+RenderInline {SPAN} at (0,0) size 224x30
+ RenderText {#text} at (105,0) size 224x30
+text run at (105,0) width 224: "This text should not be jagged."
+RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150192] trunk
Title: [150192] trunk Revision 150192 Author mrobin...@webkit.org Date 2013-05-16 11:30:19 -0700 (Thu, 16 May 2013) Log Message [GTK] [CMake] Disable the shadow DOM https://bugs.webkit.org/show_bug.cgi?id=116237 Reviewed by Gustavo Noronha Silva. * Source/cmake/OptionsGTK.cmake: Disable shadow DOM by default. Modified Paths trunk/ChangeLog trunk/Source/cmake/OptionsGTK.cmake Diff Modified: trunk/ChangeLog (150191 => 150192) --- trunk/ChangeLog 2013-05-16 18:22:25 UTC (rev 150191) +++ trunk/ChangeLog 2013-05-16 18:30:19 UTC (rev 150192) @@ -1,3 +1,12 @@ +2013-05-16 Martin Robinson + +[GTK] [CMake] Disable the shadow DOM +https://bugs.webkit.org/show_bug.cgi?id=116237 + +Reviewed by Gustavo Noronha Silva. + +* Source/cmake/OptionsGTK.cmake: Disable shadow DOM by default. + 2013-05-14 Martin Robinson [GTK] Add support for building WebCore to the cmake build Modified: trunk/Source/cmake/OptionsGTK.cmake (150191 => 150192) --- trunk/Source/cmake/OptionsGTK.cmake 2013-05-16 18:22:25 UTC (rev 150191) +++ trunk/Source/cmake/OptionsGTK.cmake 2013-05-16 18:30:19 UTC (rev 150192) @@ -36,7 +36,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOLUTION_MEDIA_QUERY OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REQUEST_ANIMATION_FRAME ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SECCOMP_FILTERS OFF) -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHADOW_DOM ON) +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHADOW_DOM OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHARED_WORKERS ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPELLCHECK ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TEMPLATE_ELEMENT ON) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150191] trunk/Source/WebKit/gtk
Title: [150191] trunk/Source/WebKit/gtk Revision 150191 Author mrobin...@webkit.org Date 2013-05-16 11:22:25 -0700 (Thu, 16 May 2013) Log Message [GTK] Documentation for WEBKIT_DEBUG logging channels is out of date https://bugs.webkit.org/show_bug.cgi?id=114764 Reviewed by Gustavo Noronha Silva. * docs/webkitenvironment.xml: Update documentation to reflect current list of logging channels. Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/docs/webkitenvironment.xml Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (150190 => 150191) --- trunk/Source/WebKit/gtk/ChangeLog 2013-05-16 18:19:38 UTC (rev 150190) +++ trunk/Source/WebKit/gtk/ChangeLog 2013-05-16 18:22:25 UTC (rev 150191) @@ -1,3 +1,13 @@ +2013-05-16 Martin Robinson + +[GTK] Documentation for WEBKIT_DEBUG logging channels is out of date +https://bugs.webkit.org/show_bug.cgi?id=114764 + +Reviewed by Gustavo Noronha Silva. + +* docs/webkitenvironment.xml: Update documentation to reflect current list of +logging channels. + 2013-05-16 Allan Sandfeld Jensen [GTK] TargetFrame and innerNodeFrame confused Modified: trunk/Source/WebKit/gtk/docs/webkitenvironment.xml (150190 => 150191) --- trunk/Source/WebKit/gtk/docs/webkitenvironment.xml 2013-05-16 18:19:38 UTC (rev 150190) +++ trunk/Source/WebKit/gtk/docs/webkitenvironment.xml 2013-05-16 18:22:25 UTC (rev 150191) @@ -31,66 +31,32 @@ - -BackForward - - -Editing - - -Events - - -Frames - - -FTP - - -History - - -IconDatabase - - -Loading - - -Media - - -Network - - -NotYetImplemented - - -PageCache - - -PlatformLeaks - - -Plugin - - -PopupBlocking - - -SpellingAndGrammar - - -SQLDatabase - - -StorageAPI - - -TextConversion - - -Threading - +BackForward +Editing +Events +Frames +FTP +History +IconDatabase +Loading +Media +Network +NotYetImplemented +PageCache +PlatformLeaks +ResourceLoading +Animations +Plugins +PopupBlocking +Progress +SpellingAndGrammar +SQLDatabase +StorageAPI +Threading +FileAPI +WebAudio +Compositing +Gamepad ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150190] branches/dfgFourthTier/Source/JavaScriptCore
Title: [150190] branches/dfgFourthTier/Source/_javascript_Core Revision 150190 Author mhahnenb...@apple.com Date 2013-05-16 11:19:38 -0700 (Thu, 16 May 2013) Log Message observeUseKindOnNode doesn't contain a case for KnownCellUse https://bugs.webkit.org/show_bug.cgi?id=116130 This would just lead to us being overly conservative when deciding whether we should unbox GetLocals with KnownCellUse UseKinds. Reviewed by Filip Pizlo. * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::observeUseKindOnNode): Modified Paths branches/dfgFourthTier/Source/_javascript_Core/ChangeLog branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGFixupPhase.cpp Diff Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (150189 => 150190) --- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-05-16 18:16:56 UTC (rev 150189) +++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-05-16 18:19:38 UTC (rev 150190) @@ -1,5 +1,18 @@ 2013-05-16 Mark Hahnenberg +observeUseKindOnNode doesn't contain a case for KnownCellUse +https://bugs.webkit.org/show_bug.cgi?id=116130 + +This would just lead to us being overly conservative when deciding +whether we should unbox GetLocals with KnownCellUse UseKinds. + +Reviewed by Filip Pizlo. + +* dfg/DFGFixupPhase.cpp: +(JSC::DFG::FixupPhase::observeUseKindOnNode): + +2013-05-16 Mark Hahnenberg + fourthTier: infrequent segfault in DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks() https://bugs.webkit.org/show_bug.cgi?id=116134 Modified: branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (150189 => 150190) --- branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2013-05-16 18:16:56 UTC (rev 150189) +++ branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2013-05-16 18:19:38 UTC (rev 150190) @@ -1243,6 +1243,7 @@ m_profitabilityChanged |= variable->mergeIsProfitableToUnbox(true); break; case CellUse: +case KnownCellUse: case ObjectUse: case StringUse: case KnownStringUse: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150189] trunk
Title: [150189] trunk
Revision 150189
Author mrobin...@webkit.org
Date 2013-05-16 11:16:56 -0700 (Thu, 16 May 2013)
Log Message
[GTK] Add support for building WebCore to the cmake build
https://bugs.webkit.org/show_bug.cgi?id=116128
Reviewed by Gustavo Noronha Silva.
.:
* Source/PlatformGTK.cmake: Added.
* Source/cmake/OptionsGTK.cmake: Added more logic and variables to support WebCore and properly
defined some existing variables.
Source/WebCore:
* PlatformGTK.cmake: Added.
* platform/gtk/GtkVersioning.c: Include "config.h" because we removed
the autotoolsconfig.h include from the header.
* platform/gtk/GtkVersioning.h: Remove autotoolsconfig.h include to support for
non-autotools build systems.
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GtkVersioning.c
trunk/Source/WebCore/platform/gtk/GtkVersioning.h
trunk/Source/cmake/OptionsGTK.cmake
Added Paths
trunk/Source/PlatformGTK.cmake
trunk/Source/WebCore/PlatformGTK.cmake
Diff
Modified: trunk/ChangeLog (150188 => 150189)
--- trunk/ChangeLog 2013-05-16 18:12:24 UTC (rev 150188)
+++ trunk/ChangeLog 2013-05-16 18:16:56 UTC (rev 150189)
@@ -1,3 +1,14 @@
+2013-05-14 Martin Robinson
+
+[GTK] Add support for building WebCore to the cmake build
+https://bugs.webkit.org/show_bug.cgi?id=116128
+
+Reviewed by Gustavo Noronha Silva.
+
+* Source/PlatformGTK.cmake: Added.
+* Source/cmake/OptionsGTK.cmake: Added more logic and variables to support WebCore and properly
+defined some existing variables.
+
2013-05-15 Alexey Proskuryakov
More fixing after WebProcessShim renaming in r149074.
Added: trunk/Source/PlatformGTK.cmake (0 => 150189)
--- trunk/Source/PlatformGTK.cmake (rev 0)
+++ trunk/Source/PlatformGTK.cmake 2013-05-16 18:16:56 UTC (rev 150189)
@@ -0,0 +1,18 @@
+if (ENABLE_INSPECTOR)
+add_custom_target(
+web-inspector-resources ALL
+COMMAND ${CMAKE_COMMAND} -E copy_directory ${WEBCORE_DIR}/inspector/front-end ${DATA_BUILD_DIR}/webinspector
+COMMAND ${CMAKE_COMMAND} -E copy ${WEBCORE_DIR}/English.lproj/localizedStrings.js ${DATA_BUILD_DIR}/webinspector
+COMMAND ${CMAKE_COMMAND} -E copy ${WEBKIT2_DIR}/UIProcess/InspectorServer/front-end/inspectorPageIndex.html ${DATA_BUILD_DIR}/webinspector
+COMMAND ${CMAKE_COMMAND} -E copy ${DERIVED_SOURCES_WEBCORE_DIR}/InspectorBackendCommands.js ${DATA_BUILD_DIR}/webinspector
+DEPENDS ${WebCore_LIBRARY_NAME}
+WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
+)
+install(DIRECTORY "${DATA_BUILD_DIR}/webinspector"
+DESTINATION "${DATA_INSTALL_DIR}/webinspector"
+FILES_MATCHING PATTERN "*.js"
+ PATTERN "*.html"
+ PATTERN "*.css"
+ PATTERN "*.gif"
+ PATTERN "*.png")
+endif ()
Modified: trunk/Source/WebCore/ChangeLog (150188 => 150189)
--- trunk/Source/WebCore/ChangeLog 2013-05-16 18:12:24 UTC (rev 150188)
+++ trunk/Source/WebCore/ChangeLog 2013-05-16 18:16:56 UTC (rev 150189)
@@ -1,3 +1,16 @@
+2013-05-14 Martin Robinson
+
+[GTK] Add support for building WebCore to the cmake build
+https://bugs.webkit.org/show_bug.cgi?id=116128
+
+Reviewed by Gustavo Noronha Silva.
+
+* PlatformGTK.cmake: Added.
+* platform/gtk/GtkVersioning.c: Include "config.h" because we removed
+the autotoolsconfig.h include from the header.
+* platform/gtk/GtkVersioning.h: Remove autotoolsconfig.h include to support for
+non-autotools build systems.
+
2013-05-15 Ryosuke Niwa
DocumentOrderedMap doesn't need to have two HashMaps
Added: trunk/Source/WebCore/PlatformGTK.cmake (0 => 150189)
--- trunk/Source/WebCore/PlatformGTK.cmake (rev 0)
+++ trunk/Source/WebCore/PlatformGTK.cmake 2013-05-16 18:16:56 UTC (rev 150189)
@@ -0,0 +1,348 @@
+list(APPEND WebCore_INCLUDE_DIRECTORIES
+"${WEBCORE_DIR}/accessibility/atk"
+"${WEBCORE_DIR}/editing/atk"
+"${WEBCORE_DIR}/page/gtk"
+"${WEBCORE_DIR}/platform/cairo"
+"${WEBCORE_DIR}/platform/gtk"
+"${WEBCORE_DIR}/platform/graphics/cairo"
+"${WEBCORE_DIR}/platform/graphics/gtk"
+"${WEBCORE_DIR}/platform/graphics/freetype"
+"${WEBCORE_DIR}/platform/graphics/harfbuzz/"
+"${WEBCORE_DIR}/platform/graphics/harfbuzz/ng"
+"${WEBCORE_DIR}/platform/graphics/opengl"
+"${WEBCORE_DIR}/platform/linux"
+"${WEBCORE_DIR}/platform/mediastream/gstreamer"
+"${WEBCORE_DIR}/platform/network/gtk"
+"${WEBCORE_DIR}/platform/network/soup"
+"${WEBCORE_DIR}/platform/text/gtk"
+"${WEBCORE_DIR}/plugins/gtk"
+)
+
+list(APPEND WebCore_SOURCES
+accessibility/atk/AccessibilityObjectAtk.cpp
+accessibility/atk/AXObjectCacheAtk.cpp
+accessibility/atk/WebKitAccessibleHyperlink.cpp
+accessibility/atk/WebKitAccessibleInterfaceAction.cpp
+accessibility/atk/
[webkit-changes] [150188] branches/dfgFourthTier/Source/JavaScriptCore
Title: [150188] branches/dfgFourthTier/Source/_javascript_Core
Revision 150188
Author mhahnenb...@apple.com
Date 2013-05-16 11:12:24 -0700 (Thu, 16 May 2013)
Log Message
fourthTier: infrequent segfault in DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks()
https://bugs.webkit.org/show_bug.cgi?id=116134
CodeBlock and JITCode should be ThreadSafeRefCounted. We're going to
start using them on more threads very soon (with concurrent
compilation). This patch also fixes the specific place where we were
superfluously creating a RefPtr.
Reviewed by Oliver Hunt.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getJITType):
* jit/JITCode.h:
Modified Paths
branches/dfgFourthTier/Source/_javascript_Core/ChangeLog
branches/dfgFourthTier/Source/_javascript_Core/bytecode/CodeBlock.h
branches/dfgFourthTier/Source/_javascript_Core/jit/JITCode.h
Diff
Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (150187 => 150188)
--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-05-16 18:04:13 UTC (rev 150187)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-05-16 18:12:24 UTC (rev 150188)
@@ -1,3 +1,19 @@
+2013-05-16 Mark Hahnenberg
+
+fourthTier: infrequent segfault in DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks()
+https://bugs.webkit.org/show_bug.cgi?id=116134
+
+CodeBlock and JITCode should be ThreadSafeRefCounted. We're going to
+start using them on more threads very soon (with concurrent
+compilation). This patch also fixes the specific place where we were
+superfluously creating a RefPtr.
+
+Reviewed by Oliver Hunt.
+
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::getJITType):
+* jit/JITCode.h:
+
2013-05-16 Mark Lam
Implement a probe mechanism for JIT generated code.
Modified: branches/dfgFourthTier/Source/_javascript_Core/bytecode/CodeBlock.h (150187 => 150188)
--- branches/dfgFourthTier/Source/_javascript_Core/bytecode/CodeBlock.h 2013-05-16 18:04:13 UTC (rev 150187)
+++ branches/dfgFourthTier/Source/_javascript_Core/bytecode/CodeBlock.h 2013-05-16 18:12:24 UTC (rev 150188)
@@ -90,7 +90,7 @@
static ALWAYS_INLINE int missingThisObjectMarker() { return std::numeric_limits::max(); }
-class CodeBlock : public RefCounted, public UnconditionalFinalizer, public WeakReferenceHarvester {
+class CodeBlock : public ThreadSafeRefCounted, public UnconditionalFinalizer, public WeakReferenceHarvester {
WTF_MAKE_FAST_ALLOCATED;
friend class JIT;
friend class LLIntOffsetsExtractor;
@@ -297,7 +297,7 @@
}
PassRefPtr getJITCode() { return m_jitCode; }
MacroAssemblerCodePtr getJITCodeWithArityCheck() { return m_jitCodeWithArityCheck; }
-JITCode::JITType getJITType() const { return JITCode::jitTypeFor(m_jitCode); }
+JITCode::JITType getJITType() const { return JITCode::jitTypeFor(m_jitCode.get()); }
virtual JSObject* compileOptimized(ExecState*, JSScope*, unsigned bytecodeIndex) = 0;
virtual void jettison() = 0;
enum JITCompilationResult { AlreadyCompiled, CouldNotCompile, CompiledSuccessfully };
Modified: branches/dfgFourthTier/Source/_javascript_Core/jit/JITCode.h (150187 => 150188)
--- branches/dfgFourthTier/Source/_javascript_Core/jit/JITCode.h 2013-05-16 18:04:13 UTC (rev 150187)
+++ branches/dfgFourthTier/Source/_javascript_Core/jit/JITCode.h 2013-05-16 18:12:24 UTC (rev 150188)
@@ -50,7 +50,7 @@
class JSStack;
#endif
-class JITCode : public RefCounted {
+class JITCode : public ThreadSafeRefCounted {
public:
typedef MacroAssemblerCodeRef CodeRef;
typedef MacroAssemblerCodePtr CodePtr;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150187] trunk/Source/WebCore
Title: [150187] trunk/Source/WebCore Revision 150187 Author rn...@webkit.org Date 2013-05-16 11:04:13 -0700 (Thu, 16 May 2013) Log Message DocumentOrderedMap doesn't need to have two HashMaps https://bugs.webkit.org/show_bug.cgi?id=116167 Reviewed by Geoffrey Garen. Previously, we had two hash maps: m_map and m_duplicateCounts in DocumentOrderedMap to keep track of the first element and the number of duplicates for a given name. This patch simplifies this structure by having a single hash map that contains both the pointer and the number of duplicates. In addition, this patch fixes a regression introduced in r149652 that window and document name maps were not updated for some elements inside a SVG use element, and makes use of the newly added list of the matching elements in SelectorQuery. * dom/DocumentOrderedMap.cpp: (WebCore::DocumentOrderedMap::clear): Updated to use the new hash map. (WebCore::DocumentOrderedMap::add): Ditto. (WebCore::DocumentOrderedMap::remove): Ditto. (WebCore::DocumentOrderedMap::get): Ditto. (WebCore::DocumentOrderedMap::getAllElementsById): Added. * dom/DocumentOrderedMap.h: (WebCore::DocumentOrderedMap::MapEntry::MapEntry): Added. (WebCore::DocumentOrderedMap::containsSingle): Updated to use new hash map. (WebCore::DocumentOrderedMap::contains): Ditto. (WebCore::DocumentOrderedMap::containsMultiple): Ditto. * dom/Element.cpp: (WebCore::Element::insertedInto): This function didn't add this element to window and document's name maps if the element had already been inserted into a tree scope, and the current call was inserting an ancestor of the tree scope into the document. We were exiting early per scope != treeScope(). Fixed the bug by splitting updateId into two functions updateIdForTreeScope and updateIdForDocument. The former is called when this element is inserted into a new tree scope, and the latter is called when this element is inserted into a HTML document even if it had already been inside some tree scope. (WebCore::Element::removedFrom): This function didn't remove this element from tree scope's id maps if the tree scope wasn't a document. Fixed the bug by simply checking that the removal happens beneath the current tree scope. (WebCore::Element::updateName): (WebCore::Element::updateNameForTreeScope): Renamed from updateName. (WebCore::Element::updateNameForDocument): Extracted from updateName. (WebCore::Element::updateId): (WebCore::Element::updateIdForTreeScope): Renamed from updateId. (WebCore::Element::updateIdForDocument): Extracted from updateId. * dom/Element.h: * dom/SelectorQuery.cpp: (WebCore::SelectorDataList::canUseIdLookup): Refactored to return the id subselector instead of checking if the first subselector happens to be matching an id. (WebCore::SelectorDataList::execute): Use the subselector canUseIdLookup returned. Also make use of newly added getAllElementsById when there are multiple matching elements for a given id. * dom/SelectorQuery.h: * dom/TreeScope.cpp: (WebCore::TreeScope::getAllElementsById): Added. * dom/TreeScope.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/DocumentOrderedMap.cpp trunk/Source/WebCore/dom/DocumentOrderedMap.h trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/dom/SelectorQuery.cpp trunk/Source/WebCore/dom/SelectorQuery.h trunk/Source/WebCore/dom/TreeScope.cpp trunk/Source/WebCore/dom/TreeScope.h Diff Modified: trunk/Source/WebCore/ChangeLog (150186 => 150187) --- trunk/Source/WebCore/ChangeLog 2013-05-16 17:54:38 UTC (rev 150186) +++ trunk/Source/WebCore/ChangeLog 2013-05-16 18:04:13 UTC (rev 150187) @@ -1,3 +1,66 @@ +2013-05-15 Ryosuke Niwa + +DocumentOrderedMap doesn't need to have two HashMaps +https://bugs.webkit.org/show_bug.cgi?id=116167 + +Reviewed by Geoffrey Garen. + +Previously, we had two hash maps: m_map and m_duplicateCounts in DocumentOrderedMap to keep track +of the first element and the number of duplicates for a given name. This patch simplifies this structure +by having a single hash map that contains both the pointer and the number of duplicates. + +In addition, this patch fixes a regression introduced in r149652 that window and document name maps +were not updated for some elements inside a SVG use element, and makes use of the newly added list of +the matching elements in SelectorQuery. + +* dom/DocumentOrderedMap.cpp: +(WebCore::DocumentOrderedMap::clear): Updated to use the new hash map. +(WebCore::DocumentOrderedMap::add): Ditto. +(WebCore::DocumentOrderedMap::remove): Ditto. +(WebCore::DocumentOrderedMap::get): Ditto. +(WebCore::DocumentOrderedMap::getAllElementsById): Added. + +* dom/DocumentOrderedMap.h: + +(WebCore::DocumentOrderedMap::MapEntry::MapEntry): Added. +(WebCore::DocumentOrderedMap::containsSingle): Updated to use new hash map. +
[webkit-changes] [150185] releases/WebKitGTK/webkit-2.0
Title: [150185] releases/WebKitGTK/webkit-2.0 Revision 150185 Author k...@webkit.org Date 2013-05-16 10:23:50 -0700 (Thu, 16 May 2013) Log Message [GTK] WebAudio doesn't build in WebKitGTK+ 2.0.2 https://bugs.webkit.org/show_bug.cgi?id=116154 Patch by Alberto Garcia on 2013-05-16 Reviewed by Gustavo Noronha Silva. Don't override the value of ENABLE_WEB_AUDIO selected in the configure script. * Source/autotools/SetupWebKitFeatures.m4: Modified Paths releases/WebKitGTK/webkit-2.0/ChangeLog releases/WebKitGTK/webkit-2.0/Source/autotools/SetupWebKitFeatures.m4 Diff Modified: releases/WebKitGTK/webkit-2.0/ChangeLog (150184 => 150185) --- releases/WebKitGTK/webkit-2.0/ChangeLog 2013-05-16 17:06:58 UTC (rev 150184) +++ releases/WebKitGTK/webkit-2.0/ChangeLog 2013-05-16 17:23:50 UTC (rev 150185) @@ -1,3 +1,15 @@ +2013-05-16 Alberto Garcia + +[GTK] WebAudio doesn't build in WebKitGTK+ 2.0.2 +https://bugs.webkit.org/show_bug.cgi?id=116154 + +Reviewed by Gustavo Noronha Silva. + +Don't override the value of ENABLE_WEB_AUDIO selected in the +configure script. + +* Source/autotools/SetupWebKitFeatures.m4: + 2013-05-13 Carlos Garcia Campos Unreviewed. Update NEWS and Versions.m4 for 2.0.2 release. Modified: releases/WebKitGTK/webkit-2.0/Source/autotools/SetupWebKitFeatures.m4 (150184 => 150185) --- releases/WebKitGTK/webkit-2.0/Source/autotools/SetupWebKitFeatures.m4 2013-05-16 17:06:58 UTC (rev 150184) +++ releases/WebKitGTK/webkit-2.0/Source/autotools/SetupWebKitFeatures.m4 2013-05-16 17:23:50 UTC (rev 150185) @@ -171,7 +171,6 @@ ENABLE_USER_TIMING=0 \ ENABLE_VIBRATION=0 \ ENABLE_VIDEO_TRACK=0 \ - ENABLE_WEB_AUDIO=0 \ ENABLE_WEB_SOCKETS=1 \ ENABLE_WEB_TIMING=1 \ ENABLE_WORKERS=1 \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150184] trunk/LayoutTests
Title: [150184] trunk/LayoutTests Revision 150184 Author ser...@webkit.org Date 2013-05-16 10:06:58 -0700 (Thu, 16 May 2013) Log Message Enable the CSSVariables setting in css-variable-definition.html test https://bugs.webkit.org/show_bug.cgi?id=116231 Reviewed by Andreas Kling. CSSVariablesEnabled setting must be set to true to allow CSSVariables at runtime. Modified also the indent size to 4 spaces. * css3/css-variable-definition-expected.html: * css3/css-variable-definition.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/css-variable-definition-expected.html trunk/LayoutTests/css3/css-variable-definition.html Diff Modified: trunk/LayoutTests/ChangeLog (150183 => 150184) --- trunk/LayoutTests/ChangeLog 2013-05-16 15:44:09 UTC (rev 150183) +++ trunk/LayoutTests/ChangeLog 2013-05-16 17:06:58 UTC (rev 150184) @@ -1,3 +1,18 @@ +2013-05-16 Sergio Villar Senin + +Enable the CSSVariables setting in css-variable-definition.html test +https://bugs.webkit.org/show_bug.cgi?id=116231 + +Reviewed by Andreas Kling. + +CSSVariablesEnabled setting must be set to true to allow +CSSVariables at runtime. + +Modified also the indent size to 4 spaces. + +* css3/css-variable-definition-expected.html: +* css3/css-variable-definition.html: + 2013-05-15 Andy Estes Resources from non-HTTP schemes should not be cached indefinitely Modified: trunk/LayoutTests/css3/css-variable-definition-expected.html (150183 => 150184) --- trunk/LayoutTests/css3/css-variable-definition-expected.html 2013-05-16 15:44:09 UTC (rev 150183) +++ trunk/LayoutTests/css3/css-variable-definition-expected.html 2013-05-16 17:06:58 UTC (rev 150184) @@ -1,14 +1,17 @@ + +internals.settings.setCSSVariablesEnabled(true); +- :root { - -webkit-var-mycolor: red; - } - div { - color: -webkit-var(mycolor); - }+:root { +-webkit-var-mycolor: red; +} +div { +color: -webkit-var(mycolor); +} - Check that a CSS variable definition accepts spaces before the ':' - This text should be red +Check that a CSS variable definition accepts spaces before the ':' +This text should be red Modified: trunk/LayoutTests/css3/css-variable-definition.html (150183 => 150184) --- trunk/LayoutTests/css3/css-variable-definition.html 2013-05-16 15:44:09 UTC (rev 150183) +++ trunk/LayoutTests/css3/css-variable-definition.html 2013-05-16 17:06:58 UTC (rev 150184) @@ -1,14 +1,17 @@ + +internals.settings.setCSSVariablesEnabled(true); +- :root { - -webkit-var-mycolor : red; - } - div { - color: -webkit-var(mycolor); - }+:root { +-webkit-var-mycolor : red; +} +div { +color: -webkit-var(mycolor); +} - Check that a CSS variable definition accepts spaces before the ':' - This text should be red +Check that a CSS variable definition accepts spaces before the ':' +This text should be red ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150183] trunk/Source/WebCore
Title: [150183] trunk/Source/WebCore
Revision 150183
Author da...@apple.com
Date 2013-05-16 08:44:09 -0700 (Thu, 16 May 2013)
Log Message
[Mac] Make Clipboard::create functions for Mac platform independent by moving Pasteboard creation to Pasteboard functions
https://bugs.webkit.org/show_bug.cgi?id=116179
Reviewed by Andreas Kling.
* dom/Clipboard.cpp:
(WebCore::Clipboard::createForCopyAndPaste): Moved the function here from
ClipboardMac, and have it use Pasteboard functions that are not Mac-specific.
(WebCore::Clipboard::create): Ditto.
(WebCore::Clipboard::createForDragAndDrop): Ditto.
* platform/DragData.h:
(WebCore::DragData::pasteboardName): Made this const.
* platform/Pasteboard.h: Added new create functions, used by the clipboard
create functions above.
* platform/mac/ClipboardMac.mm: Removed the functions that were moved to the
Clipboard.cpp file.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::createForCopyAndPaste): Added.
(WebCore::Pasteboard::createPrivate): Added.
(WebCore::Pasteboard::createForDragAndDrop): Added.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Clipboard.cpp
trunk/Source/WebCore/platform/DragData.h
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/mac/ClipboardMac.mm
trunk/Source/WebCore/platform/mac/PasteboardMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (150182 => 150183)
--- trunk/Source/WebCore/ChangeLog 2013-05-16 15:19:05 UTC (rev 150182)
+++ trunk/Source/WebCore/ChangeLog 2013-05-16 15:44:09 UTC (rev 150183)
@@ -1,3 +1,30 @@
+2013-05-15 Darin Adler
+
+[Mac] Make Clipboard::create functions for Mac platform independent by moving Pasteboard creation to Pasteboard functions
+https://bugs.webkit.org/show_bug.cgi?id=116179
+
+Reviewed by Andreas Kling.
+
+* dom/Clipboard.cpp:
+(WebCore::Clipboard::createForCopyAndPaste): Moved the function here from
+ClipboardMac, and have it use Pasteboard functions that are not Mac-specific.
+(WebCore::Clipboard::create): Ditto.
+(WebCore::Clipboard::createForDragAndDrop): Ditto.
+
+* platform/DragData.h:
+(WebCore::DragData::pasteboardName): Made this const.
+
+* platform/Pasteboard.h: Added new create functions, used by the clipboard
+create functions above.
+
+* platform/mac/ClipboardMac.mm: Removed the functions that were moved to the
+Clipboard.cpp file.
+
+* platform/mac/PasteboardMac.mm:
+(WebCore::Pasteboard::createForCopyAndPaste): Added.
+(WebCore::Pasteboard::createPrivate): Added.
+(WebCore::Pasteboard::createForDragAndDrop): Added.
+
2013-05-15 Anders Carlsson
Fix a thinko.
Modified: trunk/Source/WebCore/dom/Clipboard.cpp (150182 => 150183)
--- trunk/Source/WebCore/dom/Clipboard.cpp 2013-05-16 15:19:05 UTC (rev 150182)
+++ trunk/Source/WebCore/dom/Clipboard.cpp 2013-05-16 15:44:09 UTC (rev 150183)
@@ -28,6 +28,7 @@
#include "CachedImage.h"
#include "CachedImageClient.h"
+#include "DragData.h"
#include "Editor.h"
#include "FileList.h"
#include "Frame.h"
@@ -278,6 +279,11 @@
#if !USE(LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS)
+PassRefPtr Clipboard::createForCopyAndPaste(ClipboardAccessPolicy policy)
+{
+return adoptRef(new Clipboard(policy, CopyAndPaste, policy == ClipboardWritable ? Pasteboard::createPrivate() : Pasteboard::createForCopyAndPaste()));
+}
+
bool Clipboard::hasData()
{
return m_pasteboard->hasData();
@@ -350,6 +356,19 @@
#else
+// FIXME: Should be named createForDragAndDrop.
+// FIXME: Should take const DragData& instead of DragData*.
+// FIXME: Should not take Frame*.
+PassRefPtr Clipboard::create(ClipboardAccessPolicy policy, DragData* dragData, Frame*)
+{
+return adoptRef(new Clipboard(policy, DragAndDrop, Pasteboard::createForDragAndDrop(*dragData), dragData->containsFiles()));
+}
+
+PassRefPtr Clipboard::createForDragAndDrop()
+{
+return adoptRef(new Clipboard(ClipboardWritable, DragAndDrop, Pasteboard::createForDragAndDrop()));
+}
+
void Clipboard::setDragImage(CachedImage* image, const IntPoint& location)
{
if (!canSetDragImage())
Modified: trunk/Source/WebCore/platform/DragData.h (150182 => 150183)
--- trunk/Source/WebCore/platform/DragData.h 2013-05-16 15:19:05 UTC (rev 150182)
+++ trunk/Source/WebCore/platform/DragData.h 2013-05-16 15:44:09 UTC (rev 150183)
@@ -116,7 +116,7 @@
unsigned numberOfFiles() const;
int modifierKeyState() const;
#if PLATFORM(MAC)
-const String& pasteboardName() { return m_pasteboardName; }
+const String& pasteboardName() const { return m_pasteboardName; }
#endif
#if ENABLE(FILE_SYSTEM)
Modified: trunk/Source/WebCore/platform/Pasteboard.h (150182 => 150183)
--- trunk/Source/WebCore/platform/Pasteboard.h 2013-05-16 15:19:05 UTC (rev 150182)
+++ trunk/Source/WebCore/platform/Pasteboard.h 2013-05-16 15:44:09 UTC (rev 150183)
@@ -63,6 +63,7 @@
class Clipboard;
class D
[webkit-changes] [150182] trunk/Source/WebKit/gtk
Title: [150182] trunk/Source/WebKit/gtk
Revision 150182
Author allan.jen...@digia.com
Date 2013-05-16 08:19:05 -0700 (Thu, 16 May 2013)
Log Message
[GTK] TargetFrame and innerNodeFrame confused
https://bugs.webkit.org/show_bug.cgi?id=102907
Reviewed by Martin Robinson.
* webkit/webkithittestresult.cpp:
(WebKit::kit):
Modified Paths
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkithittestresult.cpp
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (150181 => 150182)
--- trunk/Source/WebKit/gtk/ChangeLog 2013-05-16 12:49:23 UTC (rev 150181)
+++ trunk/Source/WebKit/gtk/ChangeLog 2013-05-16 15:19:05 UTC (rev 150182)
@@ -1,3 +1,13 @@
+2013-05-16 Allan Sandfeld Jensen
+
+[GTK] TargetFrame and innerNodeFrame confused
+https://bugs.webkit.org/show_bug.cgi?id=102907
+
+Reviewed by Martin Robinson.
+
+* webkit/webkithittestresult.cpp:
+(WebKit::kit):
+
2013-05-15 Anders Carlsson
Fix build.
Modified: trunk/Source/WebKit/gtk/webkit/webkithittestresult.cpp (150181 => 150182)
--- trunk/Source/WebKit/gtk/webkit/webkithittestresult.cpp 2013-05-16 12:49:23 UTC (rev 150181)
+++ trunk/Source/WebKit/gtk/webkit/webkithittestresult.cpp 2013-05-16 15:19:05 UTC (rev 150182)
@@ -287,7 +287,7 @@
GOwnPtr imageURI(0);
GOwnPtr mediaURI(0);
WebKitDOMNode* node = 0;
-WebCore::Frame* targetFrame;
+WebCore::Frame* innerNodeFrame;
WebCore::IntPoint point;
if (!result.absoluteLinkURL().isEmpty()) {
@@ -314,14 +314,14 @@
if (result.innerNonSharedNode())
node = kit(result.innerNonSharedNode());
-// FIXME: This should probably use innerNodeFrame, as targetFrame is the potentially different frame the link opens in.
-targetFrame = result.targetFrame();
-if (targetFrame && targetFrame->view()) {
+innerNodeFrame = result.innerNodeFrame();
+if (innerNodeFrame && innerNodeFrame->view()) {
// Convert document coords to widget coords.
-point = targetFrame->view()->contentsToWindow(result.roundedPointInInnerNodeFrame());
+point = innerNodeFrame->view()->contentsToWindow(result.roundedPointInInnerNodeFrame());
} else {
-// FIXME: This should probably use roundedPointInMainFrame and translate from the mainframe.
-point = result.roundedPointInInnerNodeFrame();
+// FIXME: Main frame coords is not the same as window coords,
+// but we do not have pointer to mainframe view here.
+point = result.roundedPointInMainFrame();
}
return WEBKIT_HIT_TEST_RESULT(g_object_new(WEBKIT_TYPE_HIT_TEST_RESULT,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150181] trunk/Tools
Title: [150181] trunk/Tools
Revision 150181
Author dominik.rottsc...@intel.com
Date 2013-05-16 05:49:23 -0700 (Thu, 16 May 2013)
Log Message
[EFL] Remove Intel Wk2 Buildbots from Master
https://bugs.webkit.org/show_bug.cgi?id=116149
Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
since Gyuyoung Kim from Samsung plans to take over and maintain it.
Reviewed by Benjamin Poulain.
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (150180 => 150181)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2013-05-16 10:07:01 UTC (rev 150180)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2013-05-16 12:49:23 UTC (rev 150181)
@@ -52,8 +52,6 @@
{ "name": "efl-linux-slave-1", "platform": "efl" },
{ "name": "efl-linux-slave-2", "platform": "efl" },
{ "name": "efl-linux-slave-3", "platform": "efl" },
-{ "name": "efl-linux-slave-4", "platform": "efl" },
-{ "name": "efl-linux-perf-1", "platform": "efl" },
{ "name": "mips-1", "platform": "qt-mipsel"},
@@ -251,19 +249,9 @@
"slavenames": ["efl-linux-slave-2"]
},
{
- "name": "EFL Linux 64-bit Debug WK2", "type": "BuildAndTestWebKit2Only", "builddir": "efl-linux-64-debug-wk2",
- "platform": "efl", "configuration": "debug", "architectures": ["x86_64"],
- "slavenames": ["efl-linux-slave-4"]
-},
-{
"name": "EFL Linux 32-bit Release (Build)", "type": "Build", "builddir": "efl-linux-32-release",
"platform": "efl", "configuration": "release", "architectures": ["i386"],
"slavenames": ["efl-linux-slave-3"]
-},
-{
- "name": "EFL Linux 64-bit Release WK2 (Perf)", "type": "BuildAndPerfTestWebKit2", "builddir": "efl-linux-64-release-wk2-perf",
- "platform": "efl", "configuration": "release", "architectures": ["x86_64"],
- "slavenames": ["efl-linux-perf-1"]
}
],
@@ -273,8 +261,7 @@
"Qt Linux 64-bit Release (WebKit2 Perf)", "Qt Linux ARMv7 Release", "Qt Linux MIPS32R2 LE Release",
"Qt Linux SH4 Release",
"Qt Windows 32-bit Release", "Qt Windows 32-bit Debug", "Qt Mountain Lion Release",
- "EFL Linux 64-bit Release", "EFL Linux 64-bit Release WK2", "EFL Linux 32-bit Release (Build)", "EFL Linux 64-bit Debug WK2",
- "EFL Linux 64-bit Release WK2 (Perf)",
+ "EFL Linux 64-bit Release", "EFL Linux 64-bit Release WK2", "EFL Linux 32-bit Release (Build)",
"WinCairo Release", "WinCE Release (Build)"]
},
{ "type": "PlatformSpecificScheduler", "platform": "mac-lion", "branch": "trunk", "treeStableTimer": 45.0,
Modified: trunk/Tools/ChangeLog (150180 => 150181)
--- trunk/Tools/ChangeLog 2013-05-16 10:07:01 UTC (rev 150180)
+++ trunk/Tools/ChangeLog 2013-05-16 12:49:23 UTC (rev 150181)
@@ -1,3 +1,15 @@
+2013-05-15 Dominik Röttsches
+
+[EFL] Remove Intel Wk2 Buildbots from Master
+https://bugs.webkit.org/show_bug.cgi?id=116149
+
+Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
+since Gyuyoung Kim from Samsung plans to take over and maintain it.
+
+Reviewed by Benjamin Poulain.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
2013-05-15 Brent Fulgham
[Windows] Update various build tools to understand VS2010 environment.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150180] trunk/Source/WebKit/mac
Title: [150180] trunk/Source/WebKit/mac
Revision 150180
Author commit-qu...@webkit.org
Date 2013-05-16 03:07:01 -0700 (Thu, 16 May 2013)
Log Message
Unreviewed, rolling out r150168.
http://trac.webkit.org/changeset/150168
https://bugs.webkit.org/show_bug.cgi?id=116214
broke the world on Mountain Lion (Requested by thorton on
#webkit).
* WebView/WebFrameView.mm:
(-[WebFrameView drawRect:]):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebFrameView.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (150179 => 150180)
--- trunk/Source/WebKit/mac/ChangeLog 2013-05-16 09:47:19 UTC (rev 150179)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-05-16 10:07:01 UTC (rev 150180)
@@ -1,3 +1,15 @@
+2013-05-16 Commit Queue
+
+Unreviewed, rolling out r150168.
+http://trac.webkit.org/changeset/150168
+https://bugs.webkit.org/show_bug.cgi?id=116214
+
+broke the world on Mountain Lion (Requested by thorton on
+#webkit).
+
+* WebView/WebFrameView.mm:
+(-[WebFrameView drawRect:]):
+
2013-05-15 Simon Fraser
Avoid backing store for the WebFrameView's layer when the WebView is layer-backed
Modified: trunk/Source/WebKit/mac/WebView/WebFrameView.mm (150179 => 150180)
--- trunk/Source/WebKit/mac/WebView/WebFrameView.mm 2013-05-16 09:47:19 UTC (rev 150179)
+++ trunk/Source/WebKit/mac/WebView/WebFrameView.mm 2013-05-16 10:07:01 UTC (rev 150180)
@@ -79,10 +79,6 @@
- (BOOL)_scrollTo:(const NSPoint *)newOrigin animate:(BOOL)animate; // need the boolean result from this method
@end
-@interface NSView (Details)
-- (void)setBackgroundColor:(NSColor *)color;
-@end
-
enum {
SpaceKey = 0x0020
};
@@ -462,7 +458,7 @@
- (void)drawRect:(NSRect)rect
{
-if (![self documentView]) {
+if ([self documentView] == nil) {
// Need to paint ourselves if there's no documentView to do it instead.
if ([[self _webView] drawsBackground]) {
[[[self _webView] backgroundColor] set];
@@ -478,32 +474,6 @@
}
}
-- (BOOL)wantsUpdateLayer
-{
-return YES;
-}
-
-- (void)updateLayer
-{
-// Do what -drawRect: does but by setting a backgroundColor on the view. This avoids
-// backing store for this view when the WebView is layer-backed.
-if (![self documentView]) {
-if ([[self _webView] drawsBackground]) {
-[self setBackgroundColor:[[self _webView] backgroundColor]];
-return;
-}
-} else {
-#ifndef NDEBUG
-if ([[self _scrollView] drawsBackground]) {
-[self setBackgroundColor:[NSColor cyanColor]];
-return;
-}
-#endif
-}
-
-[self setBackgroundColor:[NSColor clearColor]];
-}
-
- (NSRect)visibleRect
{
// This method can be called beneath -[NSView dealloc] after we have cleared _private.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150178] trunk/Source/WebKit2
Title: [150178] trunk/Source/WebKit2
Revision 150178
Author abe...@webkit.org
Date 2013-05-16 01:46:12 -0700 (Thu, 16 May 2013)
Log Message
[WK2] PluginInformation.cpp fails to build because of missing ENABLE(NETSCAPE_PLUGIN_API) guard
https://bugs.webkit.org/show_bug.cgi?id=116018
Rubber-stamped by Jocelyn Turcotte.
* Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::getPluginModuleInformation):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (150177 => 150178)
--- trunk/Source/WebKit2/ChangeLog 2013-05-16 05:56:10 UTC (rev 150177)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-16 08:46:12 UTC (rev 150178)
@@ -1,3 +1,13 @@
+2013-05-16 Andras Becsi
+
+[WK2] PluginInformation.cpp fails to build because of missing ENABLE(NETSCAPE_PLUGIN_API) guard
+https://bugs.webkit.org/show_bug.cgi?id=116018
+
+Rubber-stamped by Jocelyn Turcotte.
+
+* Shared/Plugins/Netscape/PluginInformation.cpp:
+(WebKit::getPluginModuleInformation):
+
2013-05-15 Simon Cooper
Enable printing in plugins
Modified: trunk/Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp (150177 => 150178)
--- trunk/Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp 2013-05-16 05:56:10 UTC (rev 150177)
+++ trunk/Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp 2013-05-16 08:46:12 UTC (rev 150178)
@@ -98,11 +98,13 @@
void getPluginModuleInformation(const PluginModuleInfo& plugin, ImmutableDictionary::MapType& map)
{
+#if ENABLE(NETSCAPE_PLUGIN_API)
map.set(pluginInformationPathKey(), WebString::create(plugin.path));
map.set(pluginInformationDisplayNameKey(), WebString::create(plugin.info.name));
map.set(pluginInformationDefaultLoadPolicyKey(), WebUInt64::create(toWKPluginLoadPolicy(PluginInfoStore::policyForPlugin(plugin;
getPlatformPluginModuleInformation(plugin, map);
+#endif
}
PassRefPtr createPluginInformationDictionary(const PluginModuleInfo& plugin)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
