[webkit-changes] [153920] trunk/Source/WebCore
Title: [153920] trunk/Source/WebCore Revision 153920 Author jer.no...@apple.com Date 2013-08-09 20:29:16 -0700 (Fri, 09 Aug 2013) Log Message Crash in com.apple.WebKit.WebContent at com.apple.MediaToolbox. https://bugs.webkit.org/show_bug.cgi?id=119645 Reviewed by Eric Carlson. Work around crash caused by by releasing m_request as soon as keys have been added to it. * Modules/encryptedmedia/CDMPrivateAVFoundation.mm: (WebCore::CDMSessionAVFoundation::update): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm Diff Modified: trunk/Source/WebCore/ChangeLog (153919 => 153920) --- trunk/Source/WebCore/ChangeLog 2013-08-10 01:43:33 UTC (rev 153919) +++ trunk/Source/WebCore/ChangeLog 2013-08-10 03:29:16 UTC (rev 153920) @@ -1,3 +1,16 @@ +2013-08-09 Jer Noble + +Crash in com.apple.WebKit.WebContent at com.apple.MediaToolbox. +https://bugs.webkit.org/show_bug.cgi?id=119645 + +Reviewed by Eric Carlson. + +Work around crash caused by by releasing +m_request as soon as keys have been added to it. + +* Modules/encryptedmedia/CDMPrivateAVFoundation.mm: +(WebCore::CDMSessionAVFoundation::update): + 2013-08-09 Anders Carlsson Artifacts seen sometimes with layer backed WebKit1 plug-in Modified: trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm (153919 => 153920) --- trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm 2013-08-10 01:43:33 UTC (rev 153919) +++ trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm 2013-08-10 03:29:16 UTC (rev 153920) @@ -152,6 +152,7 @@ errorCode = 0; systemCode = 0; nextMessage = nullptr; +m_request = nullptr; return true; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153919] branches/safari-537-branch/Source
Title: [153919] branches/safari-537-branch/Source Revision 153919 Author lforsch...@apple.com Date 2013-08-09 18:43:33 -0700 (Fri, 09 Aug 2013) Log Message Versioning. Modified Paths branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig (153918 => 153919) --- branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2013-08-10 01:41:29 UTC (rev 153918) +++ branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2013-08-10 01:43:33 UTC (rev 153919) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 56; +MINOR_VERSION = 57; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig (153918 => 153919) --- branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig 2013-08-10 01:41:29 UTC (rev 153918) +++ branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig 2013-08-10 01:43:33 UTC (rev 153919) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 56; +MINOR_VERSION = 57; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (153918 => 153919) --- branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2013-08-10 01:41:29 UTC (rev 153918) +++ branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2013-08-10 01:43:33 UTC (rev 153919) @@ -1,5 +1,5 @@ MAJOR_VERSION = 537; -MINOR_VERSION = 56; +MINOR_VERSION = 57; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig (153918 => 153919) --- branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2013-08-10 01:41:29 UTC (rev 153918) +++ branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2013-08-10 01:43:33 UTC (rev 153919) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 56; +MINOR_VERSION = 57; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig (153918 => 153919) --- branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig 2013-08-10 01:41:29 UTC (rev 153918) +++ branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig 2013-08-10 01:43:33 UTC (rev 153919) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 56; +MINOR_VERSION = 57; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153918] tags/Safari-537.56/
Title: [153918] tags/Safari-537.56/ Revision 153918 Author lforsch...@apple.com Date 2013-08-09 18:41:29 -0700 (Fri, 09 Aug 2013) Log Message New Tag. Added Paths tags/Safari-537.56/ Diff Property changes: tags/Safari-537.56 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153917] trunk/Source/WebCore
Title: [153917] trunk/Source/WebCore Revision 153917 Author ander...@apple.com Date 2013-08-09 17:36:10 -0700 (Fri, 09 Aug 2013) Log Message Artifacts seen sometimes with layer backed WebKit1 plug-in https://bugs.webkit.org/show_bug.cgi?id=119647 Reviewed by Beth Dakin. Don't try to paint layer backed views - they will be painted by Core Animation. * platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/mac/WidgetMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (153916 => 153917) --- trunk/Source/WebCore/ChangeLog 2013-08-10 00:07:43 UTC (rev 153916) +++ trunk/Source/WebCore/ChangeLog 2013-08-10 00:36:10 UTC (rev 153917) @@ -1,3 +1,16 @@ +2013-08-09 Anders Carlsson + +Artifacts seen sometimes with layer backed WebKit1 plug-in +https://bugs.webkit.org/show_bug.cgi?id=119647 + + +Reviewed by Beth Dakin. + +Don't try to paint layer backed views - they will be painted by Core Animation. + +* platform/mac/WidgetMac.mm: +(WebCore::Widget::paint): + 2013-08-09 Rob Buis ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff Modified: trunk/Source/WebCore/platform/mac/WidgetMac.mm (153916 => 153917) --- trunk/Source/WebCore/platform/mac/WidgetMac.mm 2013-08-10 00:07:43 UTC (rev 153916) +++ trunk/Source/WebCore/platform/mac/WidgetMac.mm 2013-08-10 00:36:10 UTC (rev 153917) @@ -204,6 +204,12 @@ return; NSView *view = getOuterView(); +// We don't want to paint the view at all if it's layer backed, because then we'll end up +// with multiple copies of the view contents, one in the view's layer itself and one in the +// WebHTMLView's backing store (either a layer or the window backing store). +if (view.layer) +return; + // Take a reference to this Widget, because sending messages to the views can invoke arbitrary // code, which can deref it. RefPtr protectedThis(this); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153916] trunk/LayoutTests
Title: [153916] trunk/LayoutTests Revision 153916 Author a...@apple.com Date 2013-08-09 17:07:43 -0700 (Fri, 09 Aug 2013) Log Message Merge an encoding test from Blink https://bugs.webkit.org/show_bug.cgi?id=116943 Original patch by Adam Barth. * fast/encoding/meta-overrules-auto-expected.txt: Added. * fast/encoding/meta-overrules-auto.html: Added. * fast/encoding/resources/meta-input-encoding.html: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/fast/encoding/meta-overrules-auto-expected.txt trunk/LayoutTests/fast/encoding/meta-overrules-auto.html trunk/LayoutTests/fast/encoding/resources/meta-input-encoding.html Diff Modified: trunk/LayoutTests/ChangeLog (153915 => 153916) --- trunk/LayoutTests/ChangeLog 2013-08-10 00:01:53 UTC (rev 153915) +++ trunk/LayoutTests/ChangeLog 2013-08-10 00:07:43 UTC (rev 153916) @@ -1,5 +1,16 @@ 2013-08-09 Alexey Proskuryakov +Merge an encoding test from Blink +https://bugs.webkit.org/show_bug.cgi?id=116943 + +Original patch by Adam Barth. + +* fast/encoding/meta-overrules-auto-expected.txt: Added. +* fast/encoding/meta-overrules-auto.html: Added. +* fast/encoding/resources/meta-input-encoding.html: Added. + +2013-08-09 Alexey Proskuryakov + Tests that dump delegate calls are flaky because of cached redirects https://bugs.webkit.org/show_bug.cgi?id=119641 Added: trunk/LayoutTests/fast/encoding/meta-overrules-auto-expected.txt (0 => 153916) --- trunk/LayoutTests/fast/encoding/meta-overrules-auto-expected.txt (rev 0) +++ trunk/LayoutTests/fast/encoding/meta-overrules-auto-expected.txt 2013-08-10 00:07:43 UTC (rev 153916) @@ -0,0 +1,7 @@ +This iframe should use UTF-8 because of its meta tag even in spite of this test enabling the encoding detector: + + + +Frame: '-->' + +UTF-8 Property changes on: trunk/LayoutTests/fast/encoding/meta-overrules-auto-expected.txt ___ Added: svn:mime-type Added: svn:eol-style Added: trunk/LayoutTests/fast/encoding/meta-overrules-auto.html (0 => 153916) --- trunk/LayoutTests/fast/encoding/meta-overrules-auto.html (rev 0) +++ trunk/LayoutTests/fast/encoding/meta-overrules-auto.html 2013-08-10 00:07:43 UTC (rev 153916) @@ -0,0 +1,12 @@ + +if (window.testRunner) { +testRunner.dumpAsText(); +testRunner.dumpChildFramesAsText(); +} +if (!window.internals) +alert("This test requires window.internals"); +window.internals.settings.setUsesEncodingDetector(true); + +This iframe should use UTF-8 because of its meta tag even in spite of this test +enabling the encoding detector: +Property changes on: trunk/LayoutTests/fast/encoding/meta-overrules-auto.html ___ Added: svn:mime-type Added: trunk/LayoutTests/fast/encoding/resources/meta-input-encoding.html (0 => 153916) --- trunk/LayoutTests/fast/encoding/resources/meta-input-encoding.html (rev 0) +++ trunk/LayoutTests/fast/encoding/resources/meta-input-encoding.html 2013-08-10 00:07:43 UTC (rev 153916) @@ -0,0 +1,4 @@ + + +document.write(document.inputEncoding); + Property changes on: trunk/LayoutTests/fast/encoding/resources/meta-input-encoding.html ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153914] trunk
Title: [153914] trunk Revision 153914 Author rwlb...@webkit.org Date 2013-08-09 16:30:32 -0700 (Fri, 09 Aug 2013) Log Message ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff https://bugs.webkit.org/show_bug.cgi?id=119623 Reviewed by Dirk Schulze. Source/WebCore: Include all the stroke attributes in the style diff comparison, the visited links ones were missing. Test: svg/animations/animate-stroke-crasher.html * rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff): LayoutTests: Add testcase from bug with small adjustments. * svg/animations/animate-stroke-crasher-expected.txt: Added. * svg/animations/animate-stroke-crasher.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/style/SVGRenderStyle.cpp Added Paths trunk/LayoutTests/svg/animations/animate-stroke-crasher-expected.txt trunk/LayoutTests/svg/animations/animate-stroke-crasher.html Diff Modified: trunk/LayoutTests/ChangeLog (153913 => 153914) --- trunk/LayoutTests/ChangeLog 2013-08-09 23:25:11 UTC (rev 153913) +++ trunk/LayoutTests/ChangeLog 2013-08-09 23:30:32 UTC (rev 153914) @@ -1,3 +1,15 @@ +2013-08-09 Rob Buis + +ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff +https://bugs.webkit.org/show_bug.cgi?id=119623 + +Reviewed by Dirk Schulze. + +Add testcase from bug with small adjustments. + +* svg/animations/animate-stroke-crasher-expected.txt: Added. +* svg/animations/animate-stroke-crasher.html: Added. + 2013-08-09 Alexey Proskuryakov REGRESSION (r142755): window.open creates an invisible window when width and height are 0 Added: trunk/LayoutTests/svg/animations/animate-stroke-crasher-expected.txt (0 => 153914) --- trunk/LayoutTests/svg/animations/animate-stroke-crasher-expected.txt (rev 0) +++ trunk/LayoutTests/svg/animations/animate-stroke-crasher-expected.txt 2013-08-09 23:30:32 UTC (rev 153914) @@ -0,0 +1,2 @@ +PASS + Added: trunk/LayoutTests/svg/animations/animate-stroke-crasher.html (0 => 153914) --- trunk/LayoutTests/svg/animations/animate-stroke-crasher.html (rev 0) +++ trunk/LayoutTests/svg/animations/animate-stroke-crasher.html 2013-08-09 23:30:32 UTC (rev 153914) @@ -0,0 +1,14 @@ + + + + + if (window.testRunner) +testRunner.dumpAsText(); + +PASS + + + + + Modified: trunk/Source/WebCore/ChangeLog (153913 => 153914) --- trunk/Source/WebCore/ChangeLog 2013-08-09 23:25:11 UTC (rev 153913) +++ trunk/Source/WebCore/ChangeLog 2013-08-09 23:30:32 UTC (rev 153914) @@ -1,3 +1,17 @@ +2013-08-09 Rob Buis + +ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff +https://bugs.webkit.org/show_bug.cgi?id=119623 + +Reviewed by Dirk Schulze. + +Include all the stroke attributes in the style diff comparison, the visited links ones were missing. + +Test: svg/animations/animate-stroke-crasher.html + +* rendering/style/SVGRenderStyle.cpp: +(WebCore::SVGRenderStyle::diff): + 2013-08-09 Alexey Proskuryakov REGRESSION (r142755): window.open creates an invisible window when width and height are 0 Modified: trunk/Source/WebCore/rendering/style/SVGRenderStyle.cpp (153913 => 153914) --- trunk/Source/WebCore/rendering/style/SVGRenderStyle.cpp 2013-08-09 23:25:11 UTC (rev 153913) +++ trunk/Source/WebCore/rendering/style/SVGRenderStyle.cpp 2013-08-09 23:30:32 UTC (rev 153914) @@ -183,7 +183,10 @@ || stroke->paintUri != other->stroke->paintUri || stroke->miterLimit != other->stroke->miterLimit || stroke->dashArray != other->stroke->dashArray -|| stroke->dashOffset != other->stroke->dashOffset) +|| stroke->dashOffset != other->stroke->dashOffset +|| stroke->visitedLinkPaintColor != other->stroke->visitedLinkPaintColor +|| stroke->visitedLinkPaintUri != other->stroke->visitedLinkPaintUri +|| stroke->visitedLinkPaintType != other->stroke->visitedLinkPaintType) return StyleDifferenceLayout; // Only the stroke-opacity case remains, where we only need a repaint. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153913] trunk
Title: [153913] trunk Revision 153913 Author a...@apple.com Date 2013-08-09 16:25:11 -0700 (Fri, 09 Aug 2013) Log Message REGRESSION (r142755): window.open creates an invisible window when width and height are 0 https://bugs.webkit.org/show_bug.cgi?id=119633 Reviewed by Darin Adler. Source/WebCore: Test: fast/dom/Window/open-zero-size-as-default.html Relying on each WebKit to refuse setting size to zero was fragile - because this required each one to have the check, and because by the time the client was called, the initially zero size was not necessarily zero. * loader/FrameLoader.cpp: (WebCore::createWindow): When sizes are zero, keep the size the window was created with, because that's the default one by definition. * page/DOMWindow.cpp: (WebCore::DOMWindow::adjustWindowRect): It's too late to check for zero size now, it's been mangled to adjust for the difference between window and viewport size. Source/WebKit/efl: * WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::setWindowRect): Once again, the passed rect cannot be empty. Source/WebKit/gtk: * WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setWindowRect): Once again, the passed rect cannot be empty. LayoutTests: * fast/dom/Window/open-zero-size-as-default-expected.txt: Added. * fast/dom/Window/open-zero-size-as-default.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/page/DOMWindow.cpp trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp Added Paths trunk/LayoutTests/fast/dom/Window/open-zero-size-as-default-expected.txt trunk/LayoutTests/fast/dom/Window/open-zero-size-as-default.html Diff Modified: trunk/LayoutTests/ChangeLog (153912 => 153913) --- trunk/LayoutTests/ChangeLog 2013-08-09 23:09:10 UTC (rev 153912) +++ trunk/LayoutTests/ChangeLog 2013-08-09 23:25:11 UTC (rev 153913) @@ -1,5 +1,15 @@ 2013-08-09 Alexey Proskuryakov +REGRESSION (r142755): window.open creates an invisible window when width and height are 0 +https://bugs.webkit.org/show_bug.cgi?id=119633 + +Reviewed by Darin Adler. + +* fast/dom/Window/open-zero-size-as-default-expected.txt: Added. +* fast/dom/Window/open-zero-size-as-default.html: Added. + +2013-08-09 Alexey Proskuryakov + http/tests/navigation/back-twice-without-commit.html times out https://bugs.webkit.org/show_bug.cgi?id=82980 Added: trunk/LayoutTests/fast/dom/Window/open-zero-size-as-default-expected.txt (0 => 153913) --- trunk/LayoutTests/fast/dom/Window/open-zero-size-as-default-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/Window/open-zero-size-as-default-expected.txt 2013-08-09 23:25:11 UTC (rev 153913) @@ -0,0 +1,3 @@ +Test that passing "height=0,width=0" to window.open() results in default window size. + +PASS Added: trunk/LayoutTests/fast/dom/Window/open-zero-size-as-default.html (0 => 153913) --- trunk/LayoutTests/fast/dom/Window/open-zero-size-as-default.html (rev 0) +++ trunk/LayoutTests/fast/dom/Window/open-zero-size-as-default.html 2013-08-09 23:25:11 UTC (rev 153913) @@ -0,0 +1,32 @@ + + +Test that passing "height=0,width=0" to window.open() results in default window size. + + +if (window.testRunner) { +testRunner.waitUntilDone(); +testRunner.dumpAsText(); +testRunner.setCanOpenWindows(); +} + +var result = document.getElementById("result"); + +window.addEventListener("message", function (e) { +try { +var dimensions = JSON.parse(e.data); +if (dimensions[0] > 100 && dimensions[1] > 100) +result.innerHTML = "PASS"; +else +result.innerHTML = "FAIL: " + e.data; +} catch (ex) { +alert("FAIL: " + ex + " (" + e.data + ")"); +} + +if (window.testRunner) +testRunner.notifyDone(); +}, false); + +window.open("data:text/html,