[webkit-changes] [153982] trunk/LayoutTests

[rniwa]

Title: [153982] trunk/LayoutTests








Revision 153982
Author rn...@webkit.org
Date 2013-08-12 23:38:55 -0700 (Mon, 12 Aug 2013)


Log Message
Fix null dereference in HTMLAnchorElement::sendPings when frame is not attached to a page
https://bugs.webkit.org/show_bug.cgi?id=119716

Reviewed by Darin Adler.

Add a regression test for r153975.

* fast/html/detach-frame-while-clicking-on-anchor-with-ping-expected.txt: Added.
* fast/html/detach-frame-while-clicking-on-anchor-with-ping.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/html/detach-frame-while-clicking-on-anchor-with-ping-expected.txt
trunk/LayoutTests/fast/html/detach-frame-while-clicking-on-anchor-with-ping.html




Diff

Modified: trunk/LayoutTests/ChangeLog (153981 => 153982)

--- trunk/LayoutTests/ChangeLog	2013-08-13 06:26:45 UTC (rev 153981)
+++ trunk/LayoutTests/ChangeLog	2013-08-13 06:38:55 UTC (rev 153982)
@@ -1,3 +1,15 @@
+2013-08-12  Ryosuke Niwa  
+
+Fix null dereference in HTMLAnchorElement::sendPings when frame is not attached to a page
+https://bugs.webkit.org/show_bug.cgi?id=119716
+
+Reviewed by Darin Adler.
+
+Add a regression test for r153975.
+
+* fast/html/detach-frame-while-clicking-on-anchor-with-ping-expected.txt: Added.
+* fast/html/detach-frame-while-clicking-on-anchor-with-ping.html: Added.
+
 2013-08-12  Zan Dobersek  
 
 ASSERTION FAILED: type() == Percent in WebCore::Length::percent


Added: trunk/LayoutTests/fast/html/detach-frame-while-clicking-on-anchor-with-ping-expected.txt (0 => 153982)

--- trunk/LayoutTests/fast/html/detach-frame-while-clicking-on-anchor-with-ping-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/html/detach-frame-while-clicking-on-anchor-with-ping-expected.txt	2013-08-13 06:38:55 UTC (rev 153982)
@@ -0,0 +1,4 @@
+This tests detaching a frame while clicking on an anchor element with ping attribute in the frame.
+WebKit should not crash.
+
+PASS. WebKit did not crash.


Added: trunk/LayoutTests/fast/html/detach-frame-while-clicking-on-anchor-with-ping.html (0 => 153982)

--- trunk/LayoutTests/fast/html/detach-frame-while-clicking-on-anchor-with-ping.html	(rev 0)
+++ trunk/LayoutTests/fast/html/detach-frame-while-clicking-on-anchor-with-ping.html	2013-08-13 06:38:55 UTC (rev 153982)
@@ -0,0 +1,28 @@
+
+
+
+This tests detaching a frame while clicking on an anchor element with ping attribute in the frame.
+WebKit should not crash.
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var iframe = document.createElement('iframe');
+document.body.appendChild(iframe);
+var anchorElement = iframe.contentDocument.createElement('a');
+anchorElement.setAttribute('href', '_javascript_:parent.remove(event);');
+anchorElement.setAttribute('ping', 'https://webkit.org/');
+iframe.contentDocument.body.appendChild(anchorElement);
+
+function remove(event) {
+iframe.parentNode.removeChild(iframe);
+event.preventDefault();
+}
+
+anchorElement.click();
+document.write('PASS. WebKit did not crash.');
+
+
+
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153981] trunk

[zandobersek]

Title: [153981] trunk








Revision 153981
Author zandober...@gmail.com
Date 2013-08-12 23:26:45 -0700 (Mon, 12 Aug 2013)


Log Message
ASSERTION FAILED: type() == Percent in WebCore::Length::percent
https://bugs.webkit.org/show_bug.cgi?id=116715

Reviewed by Darin Adler.

Source/WebCore: 

Allow the Calculated type in the Length::percent method that returns the Length's
float value. This reflects the changes in r110148 that adjusted the Length::isPercent
method to return true for Length objects of either Percent or Calculated type.

Test: fast/css/calculated-length-as-percent-crash.html

* platform/Length.h:
(WebCore::Length::percent): Assert that Length::isPercent is true when Length::percent
is called, ensuring the Length's type is either Percent or Calculated.

LayoutTests: 

Add the test case, as produced by the Fuzzinator, that was causing assertions
in Length::percent due to Length objects of the Calculated type not being treated
as holding a proper percent value in that method, despite Length::isPercent
returning true for Length objects of either Percent or the Calculated type.

* fast/css/calculated-length-as-percent-crash-expected.txt: Added.
* fast/css/calculated-length-as-percent-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Length.h


Added Paths

trunk/LayoutTests/fast/css/calculated-length-as-percent-crash-expected.txt
trunk/LayoutTests/fast/css/calculated-length-as-percent-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (153980 => 153981)

--- trunk/LayoutTests/ChangeLog	2013-08-13 06:26:29 UTC (rev 153980)
+++ trunk/LayoutTests/ChangeLog	2013-08-13 06:26:45 UTC (rev 153981)
@@ -1,3 +1,18 @@
+2013-08-12  Zan Dobersek  
+
+ASSERTION FAILED: type() == Percent in WebCore::Length::percent
+https://bugs.webkit.org/show_bug.cgi?id=116715
+
+Reviewed by Darin Adler.
+
+Add the test case, as produced by the Fuzzinator, that was causing assertions
+in Length::percent due to Length objects of the Calculated type not being treated
+as holding a proper percent value in that method, despite Length::isPercent
+returning true for Length objects of either Percent or the Calculated type.
+
+* fast/css/calculated-length-as-percent-crash-expected.txt: Added.
+* fast/css/calculated-length-as-percent-crash.html: Added.
+
 2013-08-12  Alexey Proskuryakov  
 
 http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac


Added: trunk/LayoutTests/fast/css/calculated-length-as-percent-crash-expected.txt (0 => 153981)

--- trunk/LayoutTests/fast/css/calculated-length-as-percent-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/calculated-length-as-percent-crash-expected.txt	2013-08-13 06:26:45 UTC (rev 153981)
@@ -0,0 +1,3 @@
+Test for bug #116715: ASSERTION FAILED: type() == Percent in WebCore::Length::percent
+This test passes if there's no crash.
+


Added: trunk/LayoutTests/fast/css/calculated-length-as-percent-crash.html (0 => 153981)

--- trunk/LayoutTests/fast/css/calculated-length-as-percent-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/css/calculated-length-as-percent-crash.html	2013-08-13 06:26:45 UTC (rev 153981)
@@ -0,0 +1,19 @@
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+
+
+Test for : ASSERTION FAILED: type() == Percent in WebCore::Length::percent
+This test passes if there's no crash.
+
+
+
+
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (153980 => 153981)

--- trunk/Source/WebCore/ChangeLog	2013-08-13 06:26:29 UTC (rev 153980)
+++ trunk/Source/WebCore/ChangeLog	2013-08-13 06:26:45 UTC (rev 153981)
@@ -1,3 +1,20 @@
+2013-08-12  Zan Dobersek  
+
+ASSERTION FAILED: type() == Percent in WebCore::Length::percent
+https://bugs.webkit.org/show_bug.cgi?id=116715
+
+Reviewed by Darin Adler.
+
+Allow the Calculated type in the Length::percent method that returns the Length's
+float value. This reflects the changes in r110148 that adjusted the Length::isPercent
+method to return true for Length objects of either Percent or Calculated type.
+
+Test: fast/css/calculated-length-as-percent-crash.html
+
+* platform/Length.h:
+(WebCore::Length::percent): Assert that Length::isPercent is true when Length::percent
+is called, ensuring the Length's type is either Percent or Calculated.
+
 2013-06-16  Darin Adler  
 
 Move Clipboard::declareAndWriteDragImage to DragController


Modified: trunk/Source/WebCore/platform/Length.h (153980 => 153981)

--- trunk/Source/WebCore/platform/Length.h	2013-08-13 06:26:29 UTC (rev 153980)
+++ trunk/Source/WebCore/platform/Length.h	2013-08-13 06:26:45 UTC (rev 153981)
@@ -136,7 +136,7 @@
 
 float percent() const
 {
-ASSERT(type() == Percent);
+ASSERT(isPercent());
 return getFloatValue();
 }
 






_

[webkit-changes] [153980] trunk/Tools

[mitz]

Title: [153980] trunk/Tools








Revision 153980
Author m...@apple.com
Date 2013-08-12 23:26:29 -0700 (Mon, 12 Aug 2013)


Log Message
extract-localizable-strings output is not suited for parsing by Xcode
https://bugs.webkit.org/show_bug.cgi?id=119728

Reviewed by Darin Adler.

Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
removed “ERROR” since messages that refer to a line in a file are shown as error by default,
added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
with 0).

* Scripts/extract-localizable-strings:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/extract-localizable-strings




Diff

Modified: trunk/Tools/ChangeLog (153979 => 153980)

--- trunk/Tools/ChangeLog	2013-08-13 06:16:35 UTC (rev 153979)
+++ trunk/Tools/ChangeLog	2013-08-13 06:26:29 UTC (rev 153980)
@@ -1,3 +1,17 @@
+2013-08-12  Dan Bernstein  
+
+extract-localizable-strings output is not suited for parsing by Xcode
+https://bugs.webkit.org/show_bug.cgi?id=119728
+
+Reviewed by Darin Adler.
+
+Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
+removed “ERROR” since messages that refer to a line in a file are shown as error by default,
+added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
+with 0).
+
+* Scripts/extract-localizable-strings:
+
 2013-08-12  Ryuan Choi  
 
 [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT


Modified: trunk/Tools/Scripts/extract-localizable-strings (153979 => 153980)

--- trunk/Tools/Scripts/extract-localizable-strings	2013-08-13 06:16:35 UTC (rev 153979)
+++ trunk/Tools/Scripts/extract-localizable-strings	2013-08-13 06:26:29 UTC (rev 153980)
@@ -95,13 +95,13 @@
 chomp;
 if (/^"([^\\"]|\\.)*"$/ or /^[-_\/\w\s.]+.(h|m|mm|c|cpp)$/ or /^[-_\/\w\s.]+.(h|m|mm|c|cpp):"([^\\"]|\\.)*"$/) {
 if ($exception{$_}) {
-print "$exceptionsFile:$.:exception for $_ appears twice\n";
-print "$exceptionsFile:$exception{$_}:first appearance\n";
+print "$exceptionsFile:$.: warning: exception for $_ appears twice\n";
+print "$exceptionsFile:$exception{$_}: warning: first appearance\n";
 } else {
 $exception{$_} = $.;
 }
 } else {
-print "$exceptionsFile:$.:syntax error\n";
+print "$exceptionsFile:$.: warning: syntax error\n";
 }
 }
 close EXCEPTIONS;
@@ -151,7 +151,7 @@
 
 if ($token eq "\"") {
 if ($expected and $expected ne "a quoted string") {
-print "$file:$.:ERROR:found a quoted string but expected $expected\n";
+print "$file:$.: found a quoted string but expected $expected\n";
 $sawError = 1;
 $expected = "";
 }
@@ -163,7 +163,7 @@
 $string .= $1;
 }
 } else {
-print "$file:$.:ERROR:mismatched quotes\n";
+print "$file:$.: mismatched quotes\n";
 $sawError = 1;
 $_ = "";
 }
@@ -202,7 +202,7 @@
 } elsif ($exception{"$file:\"$string\""}) {
 $usedException{"$file:\"$string\""} = 1;
 } else {
-print "$file:$stringLine:\"$string\" is not marked for localization\n" if $warnAboutUnlocalizedStrings;
+print "$file:$stringLine: warning: \"$string\" is not marked for localization\n" if $warnAboutUnlocalizedStrings;
 $notLocalizedCount++;
 }
 }
@@ -213,7 +213,7 @@
 $previousToken = $token;
 
 if ($token =~ /^NSLocalized/ && $token !~ /NSLocalizedDescriptionKey/ && $token !~ /NSLocalizedStringFromTableInBundle/ && $token !~ /NSLocalizedFileSizeDescription/) {
-print "$file:$.:ERROR:found a use of an NSLocalized macro ($token); not supported\n";
+print "$file:$.: found a use of an NSLocalized macro ($token); not supported\n";
 $nestingLevel = 0 if !defined $nestingLevel;
 $sawError = 1;
 $NSLocalizeCount++;
@@ -226,13 +226,13 @@
 $_ = ""; # Discard the rest of the line
 } elsif ($token eq "'") {
 if (!s-([^\\]|\\.)'--) { #' <-- that single quote makes the Project Builder editor less confused
-print "$file:$.:ERROR:mismatched single quote\n";
+print "$file:$.: mismatched single quote\n";
 $sawError = 1;
 $_ = "";
 }
 } else {
 if ($expected and $expected ne $toke

[webkit-changes] [153979] trunk

[zandobersek]

Title: [153979] trunk








Revision 153979
Author zandober...@gmail.com
Date 2013-08-12 23:16:35 -0700 (Mon, 12 Aug 2013)


Log Message
[Autotools] Adjust the help string for the configure's --enable-optimizations flag
https://bugs.webkit.org/show_bug.cgi?id=119682

Reviewed by Martin Robinson.

* Source/autotools/ReadCommandLineArguments.m4: Remove the 'GCC only' part of the help
string for the --enable-optimizations flag. This is not true and can lead to confusion
since the optimizations can be applied when compiling with Clang as well.

Modified Paths

trunk/ChangeLog
trunk/Source/autotools/ReadCommandLineArguments.m4




Diff

Modified: trunk/ChangeLog (153978 => 153979)

--- trunk/ChangeLog	2013-08-13 05:58:19 UTC (rev 153978)
+++ trunk/ChangeLog	2013-08-13 06:16:35 UTC (rev 153979)
@@ -1,3 +1,14 @@
+2013-08-12  Zan Dobersek  
+
+[Autotools] Adjust the help string for the configure's --enable-optimizations flag
+https://bugs.webkit.org/show_bug.cgi?id=119682
+
+Reviewed by Martin Robinson.
+
+* Source/autotools/ReadCommandLineArguments.m4: Remove the 'GCC only' part of the help
+string for the --enable-optimizations flag. This is not true and can lead to confusion
+since the optimizations can be applied when compiling with Clang as well.
+
 2013-08-11  Carlos Garcia Campos  
 
 Unreviewed. Update NEWS and Versions.m4 for 2.1.4 release.


Modified: trunk/Source/autotools/ReadCommandLineArguments.m4 (153978 => 153979)

--- trunk/Source/autotools/ReadCommandLineArguments.m4	2013-08-13 05:58:19 UTC (rev 153978)
+++ trunk/Source/autotools/ReadCommandLineArguments.m4	2013-08-13 06:16:35 UTC (rev 153979)
@@ -22,7 +22,7 @@
 
 AC_MSG_CHECKING([whether to enable optimized builds])
 AC_ARG_ENABLE(optimizations, 
-AC_HELP_STRING([--enable-optimizations], [turn on optimize builds (GCC only) [default=yes]]),
+AC_HELP_STRING([--enable-optimizations], [turn on build-time optimizations [default=yes]]),
 [enable_optimizations=$enableval],
 [
 if test "$enable_debug" = "yes"; then






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153978] trunk/Source/WebCore

[darin]

Title: [153978] trunk/Source/WebCore








Revision 153978
Author da...@apple.com
Date 2013-08-12 22:58:19 -0700 (Mon, 12 Aug 2013)


Log Message
Move Clipboard::declareAndWriteDragImage to DragController
https://bugs.webkit.org/show_bug.cgi?id=117683

Reviewed by Brent Fulgham.

* dom/Clipboard.h: Removed declareAndWriteDragImage.

* page/DragController.cpp:
(WebCore::selectImageBeforeDragging): Half of the old prepareClipboardForImageDrag
is now refactored into this function.
(WebCore::DragController::startDrag): Where we called prepareClipboardForImageDrag,
instead call selectImageBeforeDragging and declareAndWriteDragImage. This is needed
because declareAndWriteDragImage needs to be a member function, for Mac at least.

* page/DragController.h: Added declareAndWriteDragImage.

* page/efl/DragControllerEfl.cpp:
(WebCore::DragController::declareAndWriteDragImage): Added empty placeholder.
It would be better to delete this file rather than having these placeholders.
I don't think EFL actually has drag support, and it makes work to have to keep
source files up to date that are really unused.

* page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::declareAndWriteDragImage): Added. Calls Pasteboard::writeImage.
* page/mac/DragControllerMac.mm:
(WebCore::DragController::declareAndWriteDragImage): Added. Calls to DragClient, which
does the work.
* page/qt/DragControllerQt.cpp:
(WebCore::DragController::declareAndWriteDragImage): Added. Calls Pasteboard::writeImage.
* page/win/DragControllerWin.cpp:
(WebCore::DragController::declareAndWriteDragImage): Added. Uses Pasteboard functions to
do the work.

* platform/Clipboard.h: Changed the pasteboard function to return a non-const reference.
For now, it's not clear what const will mean for pasteboards, and it's currently not
possible to write to a const pasteboard, which we need to do in the new
DragController::declareAndWriteDragImage functions.

* platform/Pasteboard.h: Added a new writeMarkup function, implemented only for Windows
at this time.

* platform/efl/ClipboardEfl.cpp: Deleted declareAndWriteDragImage.
* platform/gtk/ClipboardGtk.cpp: Ditto.
* platform/ios/ClipboardIOS.h: Ditto.
* platform/ios/ClipboardIOS.mm: Ditto.
* platform/mac/ClipboardMac.mm: Ditto.
* platform/qt/ClipboardQt.cpp: Ditto.
* platform/win/ClipboardWin.cpp: Ditto.

* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writePlainTextToDataObject): Took out a pointless line of code.
(WebCore::Pasteboard::writeMarkup): Added. Currently implemented only for Windows.
This factors out a significant piece of DragController::declareAndWriteDragImage,
and will probably be handy for other platforms later.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Clipboard.h
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/page/DragController.h
trunk/Source/WebCore/page/efl/DragControllerEfl.cpp
trunk/Source/WebCore/page/gtk/DragControllerGtk.cpp
trunk/Source/WebCore/page/mac/DragControllerMac.mm
trunk/Source/WebCore/page/qt/DragControllerQt.cpp
trunk/Source/WebCore/page/win/DragControllerWin.cpp
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/efl/ClipboardEfl.cpp
trunk/Source/WebCore/platform/gtk/ClipboardGtk.cpp
trunk/Source/WebCore/platform/ios/ClipboardIOS.h
trunk/Source/WebCore/platform/ios/ClipboardIOS.mm
trunk/Source/WebCore/platform/mac/ClipboardMac.mm
trunk/Source/WebCore/platform/qt/ClipboardQt.cpp
trunk/Source/WebCore/platform/win/ClipboardWin.cpp
trunk/Source/WebCore/platform/win/PasteboardWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (153977 => 153978)

--- trunk/Source/WebCore/ChangeLog	2013-08-13 05:55:56 UTC (rev 153977)
+++ trunk/Source/WebCore/ChangeLog	2013-08-13 05:58:19 UTC (rev 153978)
@@ -1,3 +1,60 @@
+2013-06-16  Darin Adler  
+
+Move Clipboard::declareAndWriteDragImage to DragController
+https://bugs.webkit.org/show_bug.cgi?id=117683
+
+Reviewed by Brent Fulgham.
+
+* dom/Clipboard.h: Removed declareAndWriteDragImage.
+
+* page/DragController.cpp:
+(WebCore::selectImageBeforeDragging): Half of the old prepareClipboardForImageDrag
+is now refactored into this function.
+(WebCore::DragController::startDrag): Where we called prepareClipboardForImageDrag,
+instead call selectImageBeforeDragging and declareAndWriteDragImage. This is needed
+because declareAndWriteDragImage needs to be a member function, for Mac at least.
+
+* page/DragController.h: Added declareAndWriteDragImage.
+
+* page/efl/DragControllerEfl.cpp:
+(WebCore::DragController::declareAndWriteDragImage): Added empty placeholder.
+It would be better to delete this file rather than having these placeholders.
+I don't think EFL actually has drag support, and it makes work to have to keep
+source files up to date that are really unused.
+
+* page/gtk/DragControllerGtk.cpp:
+(WebCore::DragControlle

[webkit-changes] [153976] trunk/Tools

[mitz]

Title: [153976] trunk/Tools








Revision 153976
Author m...@apple.com
Date 2013-08-12 22:53:05 -0700 (Mon, 12 Aug 2013)


Log Message
extract-localizable-strings doesn't know how to verify an existing strings file
https://bugs.webkit.org/show_bug.cgi?id=119704

Reviewed by Darin Adler.

* Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
exceptions file name to omitting the --exceptions option. Added a --skip option, changing
the way directories to skip are specified from prefixing the directory with a “-” to
specifying it with --skip.
Finally, added a --verify option. When specified, the strings file is not written to, but
instead read in and checked for consistency with the comments, keys and values derived from
the source files and the exceptions file. Missing keys, unused keys, mismatching values and
mismatching comments are reported as errors.
* Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
directories to skip and no exceptions file.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/extract-localizable-strings
trunk/Tools/Scripts/update-webkit-localizable-strings




Diff

Modified: trunk/Tools/ChangeLog (153975 => 153976)

--- trunk/Tools/ChangeLog	2013-08-13 05:48:32 UTC (rev 153975)
+++ trunk/Tools/ChangeLog	2013-08-13 05:53:05 UTC (rev 153976)
@@ -1,3 +1,22 @@
+2013-08-12  Dan Bernstein  
+
+extract-localizable-strings doesn't know how to verify an existing strings file
+https://bugs.webkit.org/show_bug.cgi?id=119704
+
+Reviewed by Darin Adler.
+
+* Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
+exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
+exceptions file name to omitting the --exceptions option. Added a --skip option, changing
+the way directories to skip are specified from prefixing the directory with a “-” to
+specifying it with --skip.
+Finally, added a --verify option. When specified, the strings file is not written to, but
+instead read in and checked for consistency with the comments, keys and values derived from
+the source files and the exceptions file. Missing keys, unused keys, mismatching values and
+mismatching comments are reported as errors.
+* Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
+directories to skip and no exceptions file.
+
 2013-08-12  Alexey Proskuryakov  
 
 http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac


Modified: trunk/Tools/Scripts/extract-localizable-strings (153975 => 153976)

--- trunk/Tools/Scripts/extract-localizable-strings	2013-08-13 05:48:32 UTC (rev 153975)
+++ trunk/Tools/Scripts/extract-localizable-strings	2013-08-13 05:53:05 UTC (rev 153976)
@@ -43,33 +43,40 @@
 # The exceptions file has a list of strings in quotes, filenames, and filename/string pairs separated by :.
 
 use strict;
+use Getopt::Long;
 no warnings 'deprecated';
 
 sub UnescapeHexSequence($);
 
 my %isDebugMacro = ( ASSERT_WITH_MESSAGE => 1, LOG_ERROR => 1, ERROR => 1, NSURL_ERROR => 1, FATAL => 1, LOG => 1, LOG_WARNING => 1, UI_STRING_LOCALIZE_LATER => 1, UI_STRING_LOCALIZE_LATER_KEY => 1, LPCTSTR_UI_STRING_LOCALIZE_LATER => 1, UNLOCALIZED_STRING => 1, UNLOCALIZED_LPCTSTR => 1, dprintf => 1, NSException => 1, NSLog => 1, printf => 1 );
 
-@ARGV >= 2 or die "Usage: extract-localizable-strings   [ directory... ]\nDid you mean to run update-webkit-localizable-strings instead?\n";
+my $verify;
+my $exceptionsFile;
+my @directoriesToSkip = ();
 
-my $exceptionsFile = shift @ARGV;
--f $exceptionsFile or die "Couldn't find exceptions file $exceptionsFile\n" unless $exceptionsFile eq "-";
+my %options = (
+'verify' => \$verify,
+'exceptions=s' => \$exceptionsFile,
+'skip=s' => \@directoriesToSkip,
+);
 
+GetOptions(%options);
+
+@ARGV >= 2 or die "Usage: extract-localizable-strings [--verify] [--exceptions ]  [--skip directory | directory]...\nDid you mean to run update-webkit-localizable-strings instead?\n";
+
+-f $exceptionsFile or die "Couldn't find exceptions file $exceptionsFile\n" unless !defined $exceptionsFile;
+
 my $fileToUpdate = shift @ARGV;
 -f $fileToUpdate or die "Couldn't find file to update $fileToUpdate\n";
 
-my $warnAboutUnlocalizedStrings = $exceptionsFile ne "-";
+my $warnAboutUnlocalizedStrings = defined $exceptionsFile;
 
 my @directories = ();
-my @directoriesToSkip = ();
 if (@ARGV < 1) {
 push(@directories, ".");
 } else {
 for my $dir (@ARGV) {
-if ($dir =~ /^-(.*)$/) {
-push @directoriesToSkip, $1;
-} else {
-push @directories, $dir;
-}
+push @directories, $dir;
 }
 }
 
@@ -83,7 +90,7 @@
 my %exception;
 my %usedException;
 
-if ($exceptionsFile ne "-" && ope

[webkit-changes] [153975] trunk/Source/WebCore

[rniwa]

Title: [153975] trunk/Source/WebCore








Revision 153975
Author rn...@webkit.org
Date 2013-08-12 22:48:32 -0700 (Mon, 12 Aug 2013)


Log Message
Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=119716

Reviewed by Darin Adler.

Merge https://chromium.googlesource.com/chromium/blink/+/d5783da353ab783e9994b8fbecd91880be5192a1

No new tests since the test in the Blink change doesn't reproduce crash on WebKit.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::sendPings):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAnchorElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (153974 => 153975)

--- trunk/Source/WebCore/ChangeLog	2013-08-13 05:47:27 UTC (rev 153974)
+++ trunk/Source/WebCore/ChangeLog	2013-08-13 05:48:32 UTC (rev 153975)
@@ -1,3 +1,17 @@
+2013-08-12  Ryosuke Niwa  
+
+Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist
+https://bugs.webkit.org/show_bug.cgi?id=119716
+
+Reviewed by Darin Adler.
+
+Merge https://chromium.googlesource.com/chromium/blink/+/d5783da353ab783e9994b8fbecd91880be5192a1
+
+No new tests since the test in the Blink change doesn't reproduce crash on WebKit.
+
+* html/HTMLAnchorElement.cpp:
+(WebCore::HTMLAnchorElement::sendPings):
+
 2013-08-12  Seokju Kwon  
 
 Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll()


Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (153974 => 153975)

--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp	2013-08-13 05:47:27 UTC (rev 153974)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp	2013-08-13 05:48:32 UTC (rev 153975)
@@ -512,7 +512,7 @@
 
 void HTMLAnchorElement::sendPings(const KURL& destinationURL)
 {
-if (!hasAttribute(pingAttr) || !document()->settings()->hyperlinkAuditingEnabled())
+if (!hasAttribute(pingAttr) || !document()->settings() || !document()->settings()->hyperlinkAuditingEnabled())
 return;
 
 SpaceSplitString pingURLs(getAttribute(pingAttr), false);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153974] trunk/Source/WebCore

[seokju]

Title: [153974] trunk/Source/WebCore








Revision 153974
Author seo...@webkit.org
Date 2013-08-12 22:47:27 -0700 (Mon, 12 Aug 2013)


Log Message
Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll()
https://bugs.webkit.org/show_bug.cgi?id=119710

Reviewed by Darin Adler.

No behavior change, no new tests needed.

* rendering/RenderObject.cpp: Remove unused parameter warning.
(WebCore::shouldRepaintFixedBackgroundsOnScroll):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (153973 => 153974)

--- trunk/Source/WebCore/ChangeLog	2013-08-13 03:44:57 UTC (rev 153973)
+++ trunk/Source/WebCore/ChangeLog	2013-08-13 05:47:27 UTC (rev 153974)
@@ -1,3 +1,15 @@
+2013-08-12  Seokju Kwon  
+
+Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll()
+https://bugs.webkit.org/show_bug.cgi?id=119710
+
+Reviewed by Darin Adler.
+
+No behavior change, no new tests needed.
+
+* rendering/RenderObject.cpp: Remove unused parameter warning.
+(WebCore::shouldRepaintFixedBackgroundsOnScroll):
+
 2013-08-12  Alexey Proskuryakov  
 
 http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac


Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (153973 => 153974)

--- trunk/Source/WebCore/rendering/RenderObject.cpp	2013-08-13 03:44:57 UTC (rev 153973)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp	2013-08-13 05:47:27 UTC (rev 153974)
@@ -126,7 +126,7 @@
 // ignore the CSS property "background-attachment: fixed".
 static bool shouldRepaintFixedBackgroundsOnScroll(FrameView* frameView)
 {
-#if !ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)
+#if !ENABLE(FAST_MOBILE_SCROLLING) || !PLATFORM(QT)
 UNUSED_PARAM(frameView);
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153973] trunk

[ap]

Title: [153973] trunk








Revision 153973
Author a...@apple.com
Date 2013-08-12 20:44:57 -0700 (Mon, 12 Aug 2013)


Log Message
http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=85522

Reviewed by Andy Estes.

Source/WebCore:

Drive-by FIXMEs and trivial fixes for WebCore issues I noticed while working
on this bug. No behavior change expected.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::findFrameForNavigation):
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledFormSubmission::fire):

Tools:

* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
when already done with a test. We already had this check in all UI delegate functions,
except for -webView:addMessageToConsole:withSource: somehow.

LayoutTests:

* http/tests/security/sandboxed-iframe-form-top-expected.txt: Console logging got
improved while this test was marked as skipped or flaky, updating the results.

* platform/mac/TestExpectations: Removed sandboxed-iframe-form-top.html, this test
no longer leaks output into later ones. The test was erroneously marked as flaky
instead of skipped, but now it's good.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/sandboxed-iframe-form-top-expected.txt
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/NavigationScheduler.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/UIDelegate.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (153972 => 153973)

--- trunk/LayoutTests/ChangeLog	2013-08-13 03:34:26 UTC (rev 153972)
+++ trunk/LayoutTests/ChangeLog	2013-08-13 03:44:57 UTC (rev 153973)
@@ -1,3 +1,17 @@
+2013-08-12  Alexey Proskuryakov  
+
+http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
+https://bugs.webkit.org/show_bug.cgi?id=85522
+
+Reviewed by Andy Estes.
+
+* http/tests/security/sandboxed-iframe-form-top-expected.txt: Console logging got
+improved while this test was marked as skipped or flaky, updating the results.
+
+* platform/mac/TestExpectations: Removed sandboxed-iframe-form-top.html, this test
+no longer leaks output into later ones. The test was erroneously marked as flaky
+instead of skipped, but now it's good.
+
 2013-08-12  Ryuan Choi  
 
 [EFL] Unreviewed gardening.


Modified: trunk/LayoutTests/http/tests/security/sandboxed-iframe-form-top-expected.txt (153972 => 153973)

--- trunk/LayoutTests/http/tests/security/sandboxed-iframe-form-top-expected.txt	2013-08-13 03:34:26 UTC (rev 153972)
+++ trunk/LayoutTests/http/tests/security/sandboxed-iframe-form-top-expected.txt	2013-08-13 03:44:57 UTC (rev 153973)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Unsafe _javascript_ attempt to initiate a navigation change for frame with URL http://127.0.0.1:8000/security/sandboxed-iframe-form-top.html from frame with URL http://127.0.0.1:8000/security/resources/sandboxed-iframe-form-top.html.
+CONSOLE MESSAGE: Unsafe _javascript_ attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/sandboxed-iframe-form-top.html' from frame with URL 'http://127.0.0.1:8000/security/resources/sandboxed-iframe-form-top.html'. The frame attempting navigation of the top-level window is sandboxed, but the 'allow-top-navigation' flag is not set.
 
 This tests passes if the sandboxed frame cannot navigate the top frame.
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (153972 => 153973)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-08-13 03:34:26 UTC (rev 153972)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-08-13 03:44:57 UTC (rev 153973)
@@ -621,8 +621,6 @@
 # Requires ENABLE(MEDIA_CAPTURE)
 fast/forms/file/file-input-capture.html
 
-webkit.org/b/85522 http/tests/security/sandboxed-iframe-form-top.html [ Pass Failure ]
-
 webkit.org/b/85523 fullscreen/full-screen-iframe-legacy.html [ Pass Failure ]
 
 webkit.org/b/85525 media/video-played-reset.html [ Pass Failure ]


Modified: trunk/Source/WebCore/ChangeLog (153972 => 153973)

--- trunk/Source/WebCore/ChangeLog	2013-08-13 03:34:26 UTC (rev 153972)
+++ trunk/Source/WebCore/ChangeLog	2013-08-13 03:44:57 UTC (rev 153973)
@@ -1,3 +1,19 @@
+2013-08-12  Alexey Proskuryakov  
+
+http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
+https://bugs.webkit.org/show_bug.cgi?id=85522
+
+Reviewed by Andy Estes.
+
+Drive-by FIXMEs and trivial fixes for WebCore issues I noticed while working
+on this bug. No behavior change expected.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::submitForm):
+(WebCore::FrameLoader::findFrameForNavigation):
+* loader/NavigationScheduler.cpp:
+(WebCore::ScheduledFormSubmission::fire):
+
 2013-08-13  Ryosuke Niwa  
 

[webkit-changes] [153972] trunk/Source/WebCore

[rniwa]

Title: [153972] trunk/Source/WebCore








Revision 153972
Author rn...@webkit.org
Date 2013-08-12 20:34:26 -0700 (Mon, 12 Aug 2013)


Log Message
Fix variable name |end| -> |size| in EventTarget::fireEventListeners
https://bugs.webkit.org/show_bug.cgi?id=119715

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/f58b017539c48059bb2b88d18ee0ee3d14decb01
and also fix variable names in FiringEventIterator.

* dom/EventTarget.cpp:
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::removeAllEventListeners):
* dom/EventTarget.h:
(WebCore::FiringEventIterator::FiringEventIterator):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventTarget.cpp
trunk/Source/WebCore/dom/EventTarget.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (153971 => 153972)

--- trunk/Source/WebCore/ChangeLog	2013-08-13 01:35:13 UTC (rev 153971)
+++ trunk/Source/WebCore/ChangeLog	2013-08-13 03:34:26 UTC (rev 153972)
@@ -1,3 +1,20 @@
+2013-08-13  Ryosuke Niwa  
+
+Fix variable name |end| -> |size| in EventTarget::fireEventListeners
+https://bugs.webkit.org/show_bug.cgi?id=119715
+
+Reviewed by Benjamin Poulain.
+
+Merge https://chromium.googlesource.com/chromium/blink/+/f58b017539c48059bb2b88d18ee0ee3d14decb01
+and also fix variable names in FiringEventIterator.
+
+* dom/EventTarget.cpp:
+(WebCore::EventTarget::removeEventListener):
+(WebCore::EventTarget::fireEventListeners):
+(WebCore::EventTarget::removeAllEventListeners):
+* dom/EventTarget.h:
+(WebCore::FiringEventIterator::FiringEventIterator):
+
 2013-08-12  Ryosuke Niwa  
 
 Encapsulate access to documentNamedItemMap and windowNamedItemMap


Modified: trunk/Source/WebCore/dom/EventTarget.cpp (153971 => 153972)

--- trunk/Source/WebCore/dom/EventTarget.cpp	2013-08-13 01:35:13 UTC (rev 153971)
+++ trunk/Source/WebCore/dom/EventTarget.cpp	2013-08-13 03:34:26 UTC (rev 153972)
@@ -92,10 +92,10 @@
 if (eventType != firingIterator.eventType)
 continue;
 
-if (indexOfRemovedListener >= firingIterator.end)
+if (indexOfRemovedListener >= firingIterator.size)
 continue;
 
---firingIterator.end;
+--firingIterator.size;
 if (indexOfRemovedListener <= firingIterator.iterator)
 --firingIterator.iterator;
 }
@@ -217,18 +217,17 @@
 {
 RefPtr protect = this;
 
-// Fire all listeners registered for this event. Don't fire listeners removed
-// during event dispatch. Also, don't fire event listeners added during event
-// dispatch. Conveniently, all new event listeners will be added after 'end',
-// so iterating to 'end' naturally excludes new event listeners.
+// Fire all listeners registered for this event. Don't fire listeners removed during event dispatch.
+// Also, don't fire event listeners added during event dispatch. Conveniently, all new event listeners will be added
+// after or at index |size|, so iterating up to (but not including) |size| naturally excludes new event listeners.
 
 bool userEventWasHandled = false;
 size_t i = 0;
-size_t end = entry.size();
+size_t size = entry.size();
 if (!d->firingEventIterators)
 d->firingEventIterators = adoptPtr(new FiringEventIteratorVector);
-d->firingEventIterators->append(FiringEventIterator(event->type(), i, end));
-for ( ; i < end; ++i) {
+d->firingEventIterators->append(FiringEventIterator(event->type(), i, size));
+for (; i < size; ++i) {
 RegisteredEventListener& registeredListener = entry[i];
 if (event->eventPhase() == Event::CAPTURING_PHASE && !registeredListener.useCapture)
 continue;
@@ -286,7 +285,7 @@
 if (d->firingEventIterators) {
 for (size_t i = 0; i < d->firingEventIterators->size(); ++i) {
 d->firingEventIterators->at(i).iterator = 0;
-d->firingEventIterators->at(i).end = 0;
+d->firingEventIterators->at(i).size = 0;
 }
 }
 }


Modified: trunk/Source/WebCore/dom/EventTarget.h (153971 => 153972)

--- trunk/Source/WebCore/dom/EventTarget.h	2013-08-13 01:35:13 UTC (rev 153971)
+++ trunk/Source/WebCore/dom/EventTarget.h	2013-08-13 03:34:26 UTC (rev 153972)
@@ -79,16 +79,16 @@
 typedef int ExceptionCode;
 
 struct FiringEventIterator {
-FiringEventIterator(const AtomicString& eventType, size_t& iterator, size_t& end)
+FiringEventIterator(const AtomicString& eventType, size_t& iterator, size_t& size)
 : eventType(eventType)
 , iterator(iterator)
-, end(end)
+, size(size)
 {
 }
 
 const AtomicString& eventType;
 size_t& iterator;
-size_t& end;
+size_t& size;
 };
 typedef Vector FiringEventIteratorVector;
 






_

[webkit-changes] [153970] trunk/Source/WebCore

[rniwa]

Title: [153970] trunk/Source/WebCore








Revision 153970
Author rn...@webkit.org
Date 2013-08-12 18:12:18 -0700 (Mon, 12 Aug 2013)


Log Message
Encapsulate access to documentNamedItemMap and windowNamedItemMap
https://bugs.webkit.org/show_bug.cgi?id=119701

Reviewed by Darin Adler.

Encapsulate m_documentNamedItem and m_windowNamedItem by adding various methods on HTMLDocument.
This will help us doing more refactorings in the future.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):
* dom/Element.cpp:
(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForDocument):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::addDocumentNamedItem): Added.
(WebCore::HTMLDocument::removeDocumentNamedItem): Added.
(WebCore::HTMLDocument::addWindowNamedItem): Added.
(WebCore::HTMLDocument::removeWindowNamedItem): Added.
* html/HTMLDocument.h:
(WebCore::HTMLDocument::documentNamedItem): Added.
(WebCore::HTMLDocument::hasDocumentNamedItem): Added.
(WebCore::HTMLDocument::documentNamedItemContainsMultipleElements): Added.
(WebCore::HTMLDocument::windowNamedItem): Added.
(WebCore::HTMLDocument::hasWindowNamedItem): Added.
(WebCore::HTMLDocument::windowNamedItemContainsMultipleElements): Added.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateDocNamedItem):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/html/HTMLDocument.cpp
trunk/Source/WebCore/html/HTMLDocument.h
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (153969 => 153970)

--- trunk/Source/WebCore/ChangeLog	2013-08-13 01:10:07 UTC (rev 153969)
+++ trunk/Source/WebCore/ChangeLog	2013-08-13 01:12:18 UTC (rev 153970)
@@ -1,3 +1,41 @@
+2013-08-12  Ryosuke Niwa  
+
+Encapsulate access to documentNamedItemMap and windowNamedItemMap
+https://bugs.webkit.org/show_bug.cgi?id=119701
+
+Reviewed by Darin Adler.
+
+Encapsulate m_documentNamedItem and m_windowNamedItem by adding various methods on HTMLDocument.
+This will help us doing more refactorings in the future.
+
+* bindings/js/JSDOMWindowCustom.cpp:
+(WebCore::namedItemGetter):
+(WebCore::JSDOMWindow::getOwnPropertySlot):
+(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
+(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
+* bindings/js/JSHTMLDocumentCustom.cpp:
+(WebCore::JSHTMLDocument::canGetItemsForName):
+(WebCore::JSHTMLDocument::nameGetter):
+* dom/Element.cpp:
+(WebCore::Element::updateNameForDocument):
+(WebCore::Element::updateIdForDocument):
+* html/HTMLDocument.cpp:
+(WebCore::HTMLDocument::addDocumentNamedItem): Added.
+(WebCore::HTMLDocument::removeDocumentNamedItem): Added.
+(WebCore::HTMLDocument::addWindowNamedItem): Added.
+(WebCore::HTMLDocument::removeWindowNamedItem): Added.
+* html/HTMLDocument.h:
+(WebCore::HTMLDocument::documentNamedItem): Added.
+(WebCore::HTMLDocument::hasDocumentNamedItem): Added.
+(WebCore::HTMLDocument::documentNamedItemContainsMultipleElements): Added.
+(WebCore::HTMLDocument::windowNamedItem): Added.
+(WebCore::HTMLDocument::hasWindowNamedItem): Added.
+(WebCore::HTMLDocument::windowNamedItemContainsMultipleElements): Added.
+* html/HTMLImageElement.cpp:
+(WebCore::HTMLImageElement::parseAttribute):
+* html/HTMLObjectElement.cpp:
+(WebCore::HTMLObjectElement::updateDocNamedItem):
+
 2013-08-12  Patrick Gansterer  
 
 [CMake] Use the correct list of files when compiling ANGLESupport on Windows


Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (153969 => 153970)

--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp	2013-08-13 01:10:07 UTC (rev 153969)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp	2013-08-13 01:12:18 UTC (rev 153970)
@@ -96,18 +96,17 @@
 ASSERT(document->isHTMLDocument());
 
 AtomicStringImpl* atomicPropertyName = findAtomicString(propertyName);
-if (!atomicPropertyName || !toHTMLDocument(document)->windowNamedItemMap().contains(atomicPropertyName))
+if (!atomicPropertyName || !toHTMLDocument(document)->hasWindowNamedItem(atomicPropertyName))
 return jsUndefined();
 
-if (UNLIKELY(!toHTMLDocument(document)->windowNamedItemMap().containsSingle(atomicPropertyName))) {
+if (UNLIKEL

[webkit-changes] [153969] trunk/Source/WebKit2

[mitz]

Title: [153969] trunk/Source/WebKit2








Revision 153969
Author m...@apple.com
Date 2013-08-12 18:10:07 -0700 (Mon, 12 Aug 2013)


Log Message
Fixed an off-by-(sizeof(char*) - 1) bug.

Reviewed by Sam Weinig.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(WebKit::XPCServiceEventHandler): Allocate a sufficiently large buffer.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (153968 => 153969)

--- trunk/Source/WebKit2/ChangeLog	2013-08-13 00:35:45 UTC (rev 153968)
+++ trunk/Source/WebKit2/ChangeLog	2013-08-13 01:10:07 UTC (rev 153969)
@@ -1,3 +1,12 @@
+2013-08-12  Dan Bernstein  
+
+Fixed an off-by-(sizeof(char*) - 1) bug.
+
+Reviewed by Sam Weinig.
+
+* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
+(WebKit::XPCServiceEventHandler): Allocate a sufficiently large buffer.
+
 2013-08-12  Beth Dakin  
 
 Remove didNewFirstVisuallyNonEmptyLayout from WebKit2


Modified: trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm (153968 => 153969)

--- trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm	2013-08-13 00:35:45 UTC (rev 153968)
+++ trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm	2013-08-13 01:10:07 UTC (rev 153969)
@@ -108,7 +108,7 @@
 
 xpc_object_t environmentArray = xpc_dictionary_get_value(event, "environment");
 size_t numberOfEnvironmentVariables = xpc_array_get_count(environmentArray);
-char** environment = static_cast(malloc(numberOfEnvironmentVariables * sizeof(char*) + 1));
+char** environment = static_cast(malloc((numberOfEnvironmentVariables + 1) * sizeof(char*)));
 for (size_t i = 0; i < numberOfEnvironmentVariables; ++i)
 environment[i] = strdup(xpc_array_get_string(environmentArray, i));
 environment[numberOfEnvironmentVariables] = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153968] trunk/Source/WebCore

[paroga]

Title: [153968] trunk/Source/WebCore








Revision 153968
Author par...@webkit.org
Date 2013-08-12 17:35:45 -0700 (Mon, 12 Aug 2013)


Log Message
[CMake] Use the correct list of files when compiling ANGLESupport on Windows
https://bugs.webkit.org/show_bug.cgi?id=119439

Reviewed by Gyuyoung Kim.

* CMakeLists.txt: Use ossource_win.cpp instead of ossource_posix.cpp on Windows platforms.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (153967 => 153968)

--- trunk/Source/WebCore/CMakeLists.txt	2013-08-13 00:28:16 UTC (rev 153967)
+++ trunk/Source/WebCore/CMakeLists.txt	2013-08-13 00:35:45 UTC (rev 153968)
@@ -2887,7 +2887,6 @@
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/intermOut.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/IntermTraverse.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/MapLongVariableNames.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/ossource_posix.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/OutputESSL.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/OutputGLSL.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/OutputGLSLBase.cpp
@@ -2926,6 +2925,16 @@
 ${THIRDPARTY_DIR}/ANGLE/src/third_party/compiler/ArrayBoundsClamper.cpp
 )
 
+if (WIN32)
+list(APPEND ANGLESupport_SOURCES
+${THIRDPARTY_DIR}/ANGLE/src/compiler/ossource_win.cpp
+)
+else ()
+list(APPEND ANGLESupport_SOURCES
+${THIRDPARTY_DIR}/ANGLE/src/compiler/ossource_posix.cpp
+)
+endif ()
+
 list(APPEND WebCore_SOURCES
 platform/graphics/ANGLEWebKitBridge.cpp
 platform/graphics/GraphicsContext3D.cpp


Modified: trunk/Source/WebCore/ChangeLog (153967 => 153968)

--- trunk/Source/WebCore/ChangeLog	2013-08-13 00:28:16 UTC (rev 153967)
+++ trunk/Source/WebCore/ChangeLog	2013-08-13 00:35:45 UTC (rev 153968)
@@ -1,3 +1,12 @@
+2013-08-12  Patrick Gansterer  
+
+[CMake] Use the correct list of files when compiling ANGLESupport on Windows
+https://bugs.webkit.org/show_bug.cgi?id=119439
+
+Reviewed by Gyuyoung Kim.
+
+* CMakeLists.txt: Use ossource_win.cpp instead of ossource_posix.cpp on Windows platforms.
+
 2013-08-12  Arnaud Renevier  
 
 [cairo] memory corruption with putImageData and accelerated canvas.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153967] trunk/Source/JavaScriptCore

[oliver]

Title: [153967] trunk/Source/_javascript_Core








Revision 153967
Author oli...@apple.com
Date 2013-08-12 17:28:16 -0700 (Mon, 12 Aug 2013)


Log Message
Remove CodeBlock's notion of adding identifiers entirely
https://bugs.webkit.org/show_bug.cgi?id=119708

Reviewed by Geoffrey Garen.

Remove addAdditionalIdentifier entirely, including the bogus assertion.
Move the addition of identifiers to DFGPlan::reallyAdd

* bytecode/CodeBlock.h:
* dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::reallyAdd):
* dfg/DFGDesiredIdentifiers.h:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::finalize):
* dfg/DFGPlan.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGDesiredIdentifiers.cpp
trunk/Source/_javascript_Core/dfg/DFGDesiredIdentifiers.h
trunk/Source/_javascript_Core/dfg/DFGPlan.cpp
trunk/Source/_javascript_Core/dfg/DFGPlan.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (153966 => 153967)

--- trunk/Source/_javascript_Core/ChangeLog	2013-08-13 00:20:47 UTC (rev 153966)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-08-13 00:28:16 UTC (rev 153967)
@@ -1,5 +1,24 @@
 2013-08-12  Oliver Hunt  
 
+Remove CodeBlock's notion of adding identifiers entirely
+https://bugs.webkit.org/show_bug.cgi?id=119708
+
+Reviewed by Geoffrey Garen.
+
+Remove addAdditionalIdentifier entirely, including the bogus assertion.
+Move the addition of identifiers to DFGPlan::reallyAdd
+
+* bytecode/CodeBlock.h:
+* dfg/DFGDesiredIdentifiers.cpp:
+(JSC::DFG::DesiredIdentifiers::reallyAdd):
+* dfg/DFGDesiredIdentifiers.h:
+* dfg/DFGPlan.cpp:
+(JSC::DFG::Plan::reallyAdd):
+(JSC::DFG::Plan::finalize):
+* dfg/DFGPlan.h:
+
+2013-08-12  Oliver Hunt  
+
 Build fix
 
 * runtime/JSCell.h:


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (153966 => 153967)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2013-08-13 00:20:47 UTC (rev 153966)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2013-08-13 00:28:16 UTC (rev 153967)
@@ -664,12 +664,6 @@
 return m_jitCode->dfgCommon()->dfgIdentifiers.size();
 }
 
-void addAdditionalIdentifier(const Identifier& i)
-{
-ASSERT(JITCode::isOptimizingJIT(jitType()));
-return m_jitCode->dfgCommon()->dfgIdentifiers.append(i);
-}
-
 const Identifier& identifier(int index) const
 {
 size_t unlinkedIdentifiers = m_unlinkedCode->numberOfIdentifiers();


Modified: trunk/Source/_javascript_Core/dfg/DFGDesiredIdentifiers.cpp (153966 => 153967)

--- trunk/Source/_javascript_Core/dfg/DFGDesiredIdentifiers.cpp	2013-08-13 00:20:47 UTC (rev 153966)
+++ trunk/Source/_javascript_Core/dfg/DFGDesiredIdentifiers.cpp	2013-08-13 00:28:16 UTC (rev 153967)
@@ -62,12 +62,12 @@
 return result;
 }
 
-void DesiredIdentifiers::reallyAdd(VM& vm)
+void DesiredIdentifiers::reallyAdd(VM& vm, CommonData* commonData)
 {
 for (unsigned i = 0; i < m_addedIdentifiers.size(); ++i) {
 StringImpl* rep = m_addedIdentifiers[i];
 ASSERT(rep->hasAtLeastOneRef());
-m_codeBlock->addAdditionalIdentifier(Identifier(&vm, rep));
+commonData->dfgIdentifiers.append(Identifier(&vm, rep));
 }
 }
 


Modified: trunk/Source/_javascript_Core/dfg/DFGDesiredIdentifiers.h (153966 => 153967)

--- trunk/Source/_javascript_Core/dfg/DFGDesiredIdentifiers.h	2013-08-13 00:20:47 UTC (rev 153966)
+++ trunk/Source/_javascript_Core/dfg/DFGDesiredIdentifiers.h	2013-08-13 00:28:16 UTC (rev 153967)
@@ -38,6 +38,8 @@
 
 namespace DFG {
 
+class CommonData;
+
 class DesiredIdentifiers {
 public:
 DesiredIdentifiers(CodeBlock*);
@@ -50,7 +52,7 @@
 
 StringImpl* operator[](unsigned index) const { return at(index); }
 
-void reallyAdd(VM&);
+void reallyAdd(VM&, CommonData*);
 
 private:
 CodeBlock* m_codeBlock;


Modified: trunk/Source/_javascript_Core/dfg/DFGPlan.cpp (153966 => 153967)

--- trunk/Source/_javascript_Core/dfg/DFGPlan.cpp	2013-08-13 00:20:47 UTC (rev 153966)
+++ trunk/Source/_javascript_Core/dfg/DFGPlan.cpp	2013-08-13 00:28:16 UTC (rev 153967)
@@ -271,10 +271,10 @@
 && chains.areStillValid();
 }
 
-void Plan::reallyAdd()
+void Plan::reallyAdd(CommonData* commonData)
 {
 watchpoints.reallyAdd();
-identifiers.reallyAdd(vm);
+identifiers.reallyAdd(vm, commonData);
 }
 
 CompilationResult Plan::finalize(RefPtr& jitCode, MacroAssemblerCodePtr* jitCodeWithArityCheck)
@@ -291,7 +291,7 @@
 if (!result)
 return CompilationFailed;
 
-reallyAdd();
+reallyAdd(jitCode->dfgCommon());
 
 return CompilationSuccessful;
 }


Modified: trunk/Source/_javascript_Core/dfg/DFGPlan.h (153966 => 153967)

--- trunk/Source/_javascript_Core/dfg/DFGPlan.h	2013-08-13 00:20:47 UTC (rev 153966)
+++ trunk/Source/_javascript_Core/dfg/DFGPlan.h	201

[webkit-changes] [153965] trunk/Source/JavaScriptCore

[oliver]

Title: [153965] trunk/Source/_javascript_Core








Revision 153965
Author oli...@apple.com
Date 2013-08-12 16:56:39 -0700 (Mon, 12 Aug 2013)


Log Message
Build fix

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCell.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (153964 => 153965)

--- trunk/Source/_javascript_Core/ChangeLog	2013-08-12 23:42:27 UTC (rev 153964)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-08-12 23:56:39 UTC (rev 153965)
@@ -1,5 +1,11 @@
 2013-08-12  Oliver Hunt  
 
+Build fix
+
+* runtime/JSCell.h:
+
+2013-08-12  Oliver Hunt  
+
 Move additionalIdentifiers into DFGCommonData as only the optimising JITs use them
 https://bugs.webkit.org/show_bug.cgi?id=119705
 


Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (153964 => 153965)

--- trunk/Source/_javascript_Core/runtime/JSCell.h	2013-08-12 23:42:27 UTC (rev 153964)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h	2013-08-12 23:56:39 UTC (rev 153965)
@@ -49,6 +49,9 @@
 IncludeDontEnumProperties
 };
 
+template void* allocateCell(Heap&);
+template void* allocateCell(Heap&, size_t);
+
 class JSCell {
 friend class JSValue;
 friend class MarkedBlock;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153964] trunk/Tools

[ap]

Title: [153964] trunk/Tools








Revision 153964
Author a...@apple.com
Date 2013-08-12 16:42:27 -0700 (Mon, 12 Aug 2013)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=119693
[Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
because of connect-src-websocket-allowed.html

Reviewed by Darin Adler.

Starting a load of about:blank and immediately stopping it cancels outstanding
resource loads, but the page has to transition to committed state to have timers
or WebSockets stopped too.

* DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
ensure that transition to committed state happens before we start the next test.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm




Diff

Modified: trunk/Tools/ChangeLog (153963 => 153964)

--- trunk/Tools/ChangeLog	2013-08-12 23:41:26 UTC (rev 153963)
+++ trunk/Tools/ChangeLog	2013-08-12 23:42:27 UTC (rev 153964)
@@ -1,3 +1,18 @@
+2013-08-12  Alexey Proskuryakov  
+
+https://bugs.webkit.org/show_bug.cgi?id=119693
+[Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
+because of connect-src-websocket-allowed.html
+
+Reviewed by Darin Adler.
+
+Starting a load of about:blank and immediately stopping it cancels outstanding
+resource loads, but the page has to transition to committed state to have timers
+or WebSockets stopped too.
+
+* DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
+ensure that transition to committed state happens before we start the next test.
+
 2013-08-12  Beth Dakin  
 
 The LayoutMilestones didLayout callback should only fire for the main frame


Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (153963 => 153964)

--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2013-08-12 23:41:26 UTC (rev 153963)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2013-08-12 23:42:27 UTC (rev 153964)
@@ -1442,8 +1442,9 @@
 
 resetWebViewToConsistentStateBeforeTesting();
 
-[mainFrame loadHTMLString:@"" baseURL:[NSURL URLWithString:@"about:blank"]];
-[mainFrame stopLoading];
+// Loading an empty request synchronously replaces the document with a blank one, which is necessary
+// to stop timers, WebSockets and other activity that could otherwise spill output into next test's results.
+[mainFrame loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@""]]];
 
 [pool release];
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153963] trunk/Source/JavaScriptCore

[oliver]

Title: [153963] trunk/Source/_javascript_Core








Revision 153963
Author oli...@apple.com
Date 2013-08-12 16:41:26 -0700 (Mon, 12 Aug 2013)


Log Message
Move additionalIdentifiers into DFGCommonData as only the optimising JITs use them
https://bugs.webkit.org/show_bug.cgi?id=119705

Reviewed by Geoffrey Garen.

Relatively trivial refactoring

* bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfAdditionalIdentifiers):
(JSC::CodeBlock::addAdditionalIdentifier):
(JSC::CodeBlock::identifier):
(JSC::CodeBlock::numberOfIdentifiers):
* dfg/DFGCommonData.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGCommonData.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (153962 => 153963)

--- trunk/Source/_javascript_Core/ChangeLog	2013-08-12 22:39:13 UTC (rev 153962)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-08-12 23:41:26 UTC (rev 153963)
@@ -1,5 +1,21 @@
 2013-08-12  Oliver Hunt  
 
+Move additionalIdentifiers into DFGCommonData as only the optimising JITs use them
+https://bugs.webkit.org/show_bug.cgi?id=119705
+
+Reviewed by Geoffrey Garen.
+
+Relatively trivial refactoring
+
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::numberOfAdditionalIdentifiers):
+(JSC::CodeBlock::addAdditionalIdentifier):
+(JSC::CodeBlock::identifier):
+(JSC::CodeBlock::numberOfIdentifiers):
+* dfg/DFGCommonData.h:
+
+2013-08-12  Oliver Hunt  
+
 Stop making unnecessary copy of CodeBlock Identifier Vector
 https://bugs.webkit.org/show_bug.cgi?id=119702
 


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (153962 => 153963)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2013-08-12 22:39:13 UTC (rev 153962)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2013-08-12 23:41:26 UTC (rev 153963)
@@ -654,17 +654,34 @@
 #endif
 
 // Constant Pool
+#if ENABLE(DFG_JIT)
+size_t numberOfIdentifiers() const { return m_unlinkedCode->numberOfIdentifiers() + numberOfDFGIdentifiers(); }
+size_t numberOfDFGIdentifiers() const
+{
+if (!JITCode::isOptimizingJIT(jitType()))
+return 0;
 
-size_t numberOfIdentifiers() const { return m_unlinkedCode->numberOfIdentifiers() + numberOfAdditionalIdentifiers(); }
-size_t numberOfAdditionalIdentifiers() const { return m_additionalIdentifiers.size(); }
-void addAdditionalIdentifier(const Identifier& i) { return m_additionalIdentifiers.append(i); }
+return m_jitCode->dfgCommon()->dfgIdentifiers.size();
+}
+
+void addAdditionalIdentifier(const Identifier& i)
+{
+ASSERT(JITCode::isOptimizingJIT(jitType()));
+return m_jitCode->dfgCommon()->dfgIdentifiers.append(i);
+}
+
 const Identifier& identifier(int index) const
 {
 size_t unlinkedIdentifiers = m_unlinkedCode->numberOfIdentifiers();
 if (static_cast(index) < unlinkedIdentifiers)
 return m_unlinkedCode->identifier(index);
-return m_additionalIdentifiers[index - unlinkedIdentifiers];
+ASSERT(JITCode::isOptimizingJIT(jitType()));
+return m_jitCode->dfgCommon()->dfgIdentifiers[index - unlinkedIdentifiers];
 }
+#else
+size_t numberOfIdentifiers() const { return m_unlinkedCode->numberOfIdentifiers(); }
+const Identifier& identifier(int index) const { return m_unlinkedCode->identifier(index); }
+#endif
 
 size_t numberOfConstantRegisters() const { return m_constantRegisters.size(); }
 unsigned addConstant(JSValue v)


Modified: trunk/Source/_javascript_Core/dfg/DFGCommonData.h (153962 => 153963)

--- trunk/Source/_javascript_Core/dfg/DFGCommonData.h	2013-08-12 22:39:13 UTC (rev 153962)
+++ trunk/Source/_javascript_Core/dfg/DFGCommonData.h	2013-08-12 23:41:26 UTC (rev 153963)
@@ -37,6 +37,7 @@
 namespace JSC {
 
 class CodeBlock;
+class Identifier;
 
 namespace DFG {
 
@@ -73,7 +74,8 @@
 void notifyCompilingStructureTransition(CodeBlock*, Node*);
 
 void shrinkToFit();
-
+
+Vector dfgIdentifiers;
 Vector transitions;
 Vector > weakReferences;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153962] trunk/Source/JavaScriptCore

[oliver]

Title: [153962] trunk/Source/_javascript_Core








Revision 153962
Author oli...@apple.com
Date 2013-08-12 15:39:13 -0700 (Mon, 12 Aug 2013)


Log Message
Stop making unnecessary copy of CodeBlock Identifier Vector
https://bugs.webkit.org/show_bug.cgi?id=119702

Reviewed by Michael Saboff.

Make CodeBlock simply use a separate Vector for additional Identifiers
and use the UnlinkedCodeBlock for the initial set of identifiers.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::dumpStructure):
(JSC::dumpChain):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfIdentifiers):
(JSC::CodeBlock::numberOfAdditionalIdentifiers):
(JSC::CodeBlock::addAdditionalIdentifier):
(JSC::CodeBlock::identifier):
* dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::reallyAdd):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_get_arguments_length):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emitSlow_op_put_by_id):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGDesiredIdentifiers.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (153961 => 153962)

--- trunk/Source/_javascript_Core/ChangeLog	2013-08-12 22:05:07 UTC (rev 153961)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-08-12 22:39:13 UTC (rev 153962)
@@ -1,3 +1,47 @@
+2013-08-12  Oliver Hunt  
+
+Stop making unnecessary copy of CodeBlock Identifier Vector
+https://bugs.webkit.org/show_bug.cgi?id=119702
+
+Reviewed by Michael Saboff.
+
+Make CodeBlock simply use a separate Vector for additional Identifiers
+and use the UnlinkedCodeBlock for the initial set of identifiers.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::printGetByIdOp):
+(JSC::dumpStructure):
+(JSC::dumpChain):
+(JSC::CodeBlock::printGetByIdCacheStatus):
+(JSC::CodeBlock::printPutByIdOp):
+(JSC::CodeBlock::dumpBytecode):
+(JSC::CodeBlock::CodeBlock):
+(JSC::CodeBlock::shrinkToFit):
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::numberOfIdentifiers):
+(JSC::CodeBlock::numberOfAdditionalIdentifiers):
+(JSC::CodeBlock::addAdditionalIdentifier):
+(JSC::CodeBlock::identifier):
+* dfg/DFGDesiredIdentifiers.cpp:
+(JSC::DFG::DesiredIdentifiers::reallyAdd):
+* jit/JIT.h:
+* jit/JITOpcodes.cpp:
+(JSC::JIT::emitSlow_op_get_arguments_length):
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::emit_op_get_by_id):
+(JSC::JIT::compileGetByIdHotPath):
+(JSC::JIT::emitSlow_op_get_by_id):
+(JSC::JIT::compileGetByIdSlowCase):
+(JSC::JIT::emitSlow_op_put_by_id):
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::emit_op_get_by_id):
+(JSC::JIT::compileGetByIdHotPath):
+(JSC::JIT::compileGetByIdSlowCase):
+* jit/JITStubs.cpp:
+(JSC::DEFINE_STUB_FUNCTION):
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::LLINT_SLOW_PATH_DECL):
+
 2013-08-08  Mark Lam  
 
 Restoring use of StackIterator instead of Interpreter::getStacktrace().


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (153961 => 153962)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2013-08-12 22:05:07 UTC (rev 153961)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2013-08-12 22:39:13 UTC (rev 153962)
@@ -283,12 +283,12 @@
 int r0 = (++it)->u.operand;
 int r1 = (++it)->u.operand;
 int id0 = (++it)->u.operand;
-out.printf("[%4d] %s\t %s, %s, %s", location, op, registerName(r0).data(), registerName(r1).data(), idName(id0, m_identifiers[id0]).data());
+out.printf("[%4d] %s\t %s, %s, %s", location, op, registerName(r0).data(), registerName(r1).data(), idName(id0, identifier(id0)).data());
 it += 4; // Increment up to the value profiler.
 }
 
 #if ENABLE(JIT) || ENABLE(LLINT) // unused in some configurations
-static void dumpStructure(PrintStream& out, const char* name, ExecState* exec, Structure

[webkit-changes] [153960] trunk/LayoutTests

[rniwa]

Title: [153960] trunk/LayoutTests








Revision 153960
Author rn...@webkit.org
Date 2013-08-12 14:55:06 -0700 (Mon, 12 Aug 2013)


Log Message
Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK.
https://bugs.webkit.org/show_bug.cgi?id=104104

Add back test expectation for Mac since it's still failing on ML WK1 bots.

* platform/mac/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (153959 => 153960)

--- trunk/LayoutTests/ChangeLog	2013-08-12 21:50:06 UTC (rev 153959)
+++ trunk/LayoutTests/ChangeLog	2013-08-12 21:55:06 UTC (rev 153960)
@@ -1,3 +1,13 @@
+2013-08-12  Ryosuke Niwa  
+
+Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK.
+https://bugs.webkit.org/show_bug.cgi?id=104104
+
+Add back test expectation for Mac since it's still failing on ML WK1 bots.
+
+* platform/mac/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2013-08-12  Christophe Dumez  
 
 Define DOM_KEY_LOCATION_* constants on KeyboardEvent


Modified: trunk/LayoutTests/platform/mac/TestExpectations (153959 => 153960)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-08-12 21:50:06 UTC (rev 153959)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-08-12 21:55:06 UTC (rev 153960)
@@ -1128,6 +1128,9 @@
 # The logic in this test is no longer correct for Apple ports
 webkit.org/b/112492 media/track/track-user-preferences.html [ Skip ]
 
+# Only failing on WK1
+webkit.org/b/104104 fast/overflow/scrollbar-click-retains-focus.html [ Failure ]
+
 webkit.org/b/104954 http/tests/canvas/canvas-slow-font-loading.html [ ImageOnlyFailure ]
 
 webkit.org/b/104962 platform/mac/fast/loader/file-url-mimetypes-2.html [ Failure ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (153959 => 153960)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-08-12 21:50:06 UTC (rev 153959)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-08-12 21:55:06 UTC (rev 153960)
@@ -338,6 +338,9 @@
 webkit.org/b/118925 [ Debug ] fast/repaint/region-painting-in-composited-view.html  [ ImageOnlyFailure ]
 webkit.org/b/118925 [ Debug ] svg/repaint/buffered-rendering-static-image.html  [ ImageOnlyFailure ]
 
+# Only failing on WK1
+webkit.org/b/104104 fast/overflow/scrollbar-click-retains-focus.html [ Pass ]
+
 ### END OF (1) Classified failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153959] trunk/Source

[rniwa]

Title: [153959] trunk/Source








Revision 153959
Author rn...@webkit.org
Date 2013-08-12 14:50:06 -0700 (Mon, 12 Aug 2013)


Log Message
Use const AtomicStringImpl* in DocumentOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=119700

Reviewed by Benjamin Poulain.

Use const AtomicStringImpl* in DocumentOrderedMap. It caught at least one bug that HTMLNameCollection'
subclasses' nodeMatches were taking const AtomicString& instead of AtomicStringImpl*. This was forcing
DocumentOrderedMap::getElementByWindowNamedItem and DocumentOrderedMap::getElementByDocumentNamedItem
to create temporary AtomicStrings.

* dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesId):
(WebCore::keyMatchesName):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLabelForAttribute):
(WebCore::keyMatchesWindowNamedItem):
(WebCore::keyMatchesDocumentNamedItem):
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByName):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):
(WebCore::DocumentOrderedMap::getElementByWindowNamedItem):
(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem):
(WebCore::DocumentOrderedMap::getAllElementsById):
* dom/DocumentOrderedMap.h:
(WebCore::DocumentOrderedMap::containsSingle):
(WebCore::DocumentOrderedMap::contains):
(WebCore::DocumentOrderedMap::containsMultiple):
* html/HTMLNameCollection.cpp:
(WebCore::WindowNameCollection::nodeMatches):
(WebCore::DocumentNameCollection::nodeMatches):
* html/HTMLNameCollection.h:
(WebCore::WindowNameCollection::nodeMatches):
(WebCore::DocumentNameCollection::nodeMatches):

Modified Paths

trunk/Source/WTF/wtf/text/AtomicStringImpl.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DocumentOrderedMap.cpp
trunk/Source/WebCore/dom/DocumentOrderedMap.h
trunk/Source/WebCore/html/HTMLNameCollection.cpp
trunk/Source/WebCore/html/HTMLNameCollection.h




Diff

Modified: trunk/Source/WTF/wtf/text/AtomicStringImpl.h (153958 => 153959)

--- trunk/Source/WTF/wtf/text/AtomicStringImpl.h	2013-08-12 21:37:06 UTC (rev 153958)
+++ trunk/Source/WTF/wtf/text/AtomicStringImpl.h	2013-08-12 21:50:06 UTC (rev 153959)
@@ -41,6 +41,11 @@
 ValueCheck {
 static void checkConsistency(const AtomicStringImpl*) { }
 };
+
+template<> struct
+ValueCheck {
+static void checkConsistency(const AtomicStringImpl*) { }
+};
 #endif
 
 }


Modified: trunk/Source/WebCore/ChangeLog (153958 => 153959)

--- trunk/Source/WebCore/ChangeLog	2013-08-12 21:37:06 UTC (rev 153958)
+++ trunk/Source/WebCore/ChangeLog	2013-08-12 21:50:06 UTC (rev 153959)
@@ -1,3 +1,45 @@
+2013-08-12  Ryosuke Niwa  
+
+Use const AtomicStringImpl* in DocumentOrderedMap
+https://bugs.webkit.org/show_bug.cgi?id=119700
+
+Reviewed by Benjamin Poulain.
+
+Use const AtomicStringImpl* in DocumentOrderedMap. It caught at least one bug that HTMLNameCollection'
+subclasses' nodeMatches were taking const AtomicString& instead of AtomicStringImpl*. This was forcing
+DocumentOrderedMap::getElementByWindowNamedItem and DocumentOrderedMap::getElementByDocumentNamedItem
+to create temporary AtomicStrings.
+
+* dom/DocumentOrderedMap.cpp:
+(WebCore::keyMatchesId):
+(WebCore::keyMatchesName):
+(WebCore::keyMatchesMapName):
+(WebCore::keyMatchesLowercasedMapName):
+(WebCore::keyMatchesLabelForAttribute):
+(WebCore::keyMatchesWindowNamedItem):
+(WebCore::keyMatchesDocumentNamedItem):
+(WebCore::DocumentOrderedMap::add):
+(WebCore::DocumentOrderedMap::remove):
+(WebCore::DocumentOrderedMap::get):
+(WebCore::DocumentOrderedMap::getElementById):
+(WebCore::DocumentOrderedMap::getElementByName):
+(WebCore::DocumentOrderedMap::getElementByMapName):
+(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
+(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):
+(WebCore::DocumentOrderedMap::getElementByWindowNamedItem):
+(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem):
+(WebCore::DocumentOrderedMap::getAllElementsById):
+* dom/DocumentOrderedMap.h:
+(WebCore::DocumentOrderedMap::containsSingle):
+(WebCore::DocumentOrderedMap::contains):
+(WebCore::DocumentOrderedMap::containsMultiple):
+* html/HTMLNameCollection.cpp:
+(WebCore::WindowNameCollection::nodeMatches):
+(WebCore::DocumentNameCollection::nodeMatches):
+* html/HTMLNameCollection.h:
+(WebCore::WindowNameCollection::nodeMatches):
+(WebCore::DocumentNameCollection::nodeMatches):
+
 2013-08-12  Beth Dakin  
 
 The LayoutMilestones didLayout callback should only fire fo

[webkit-changes] [153958] trunk

[bdakin]

Title: [153958] trunk








Revision 153958
Author bda...@apple.com
Date 2013-08-12 14:37:06 -0700 (Mon, 12 Aug 2013)


Log Message
The LayoutMilestones didLayout callback should only fire for the main frame
https://bugs.webkit.org/show_bug.cgi?id=119457

Reviewed by Sam Weinig.

Source/WebCore: 

This patch makes it so that FrameLoader::didLayout(LayoutMilestones) is only ever 
called for the main frame. Technically this will change existing API for 
didFirstVisuallyNonEmptyLayoutInFrame and didFirstLayoutInFrame. Clients used to 
be able to register for those callbacks for any frame they wanted, however, now 
they will only ever get the callback when it applies to the main frame. We think 
that this is acceptable since we don’t know of any clients that ever used those 
APIs for a non-main frame. This change also makes nothing but sense for the 
didLayout(LayoutMilestones) callback, since that is a Page-level concept, so it 
should only fire for the main frame.

Only call didLayout for the main frame.
* dom/Document.cpp:
(WebCore::Document::setVisualUpdatesAllowed):

Assert that this is the main frame.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didLayout):

Only call didLayout for the main frame.
* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):

Tools: 

Now that the didLayout callback only fires for the main frame, we want to make 
sure it will fire even when all of the content is in a subframe.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (153957 => 153958)

--- trunk/Source/WebCore/ChangeLog	2013-08-12 21:02:40 UTC (rev 153957)
+++ trunk/Source/WebCore/ChangeLog	2013-08-12 21:37:06 UTC (rev 153958)
@@ -1,3 +1,32 @@
+2013-08-12  Beth Dakin  
+
+The LayoutMilestones didLayout callback should only fire for the main frame
+https://bugs.webkit.org/show_bug.cgi?id=119457
+
+Reviewed by Sam Weinig.
+
+This patch makes it so that FrameLoader::didLayout(LayoutMilestones) is only ever 
+called for the main frame. Technically this will change existing API for 
+didFirstVisuallyNonEmptyLayoutInFrame and didFirstLayoutInFrame. Clients used to 
+be able to register for those callbacks for any frame they wanted, however, now 
+they will only ever get the callback when it applies to the main frame. We think 
+that this is acceptable since we don’t know of any clients that ever used those 
+APIs for a non-main frame. This change also makes nothing but sense for the 
+didLayout(LayoutMilestones) callback, since that is a Page-level concept, so it 
+should only fire for the main frame.
+
+Only call didLayout for the main frame.
+* dom/Document.cpp:
+(WebCore::Document::setVisualUpdatesAllowed):
+
+Assert that this is the main frame.
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::didLayout):
+
+Only call didLayout for the main frame.
+* page/FrameView.cpp:
+(WebCore::FrameView::performPostLayoutTasks):
+
 2013-08-12  Christophe Dumez  
 
 Define DOM_KEY_LOCATION_* constants on KeyboardEvent


Modified: trunk/Source/WebCore/dom/Document.cpp (153957 => 153958)

--- trunk/Source/WebCore/dom/Document.cpp	2013-08-12 21:02:40 UTC (rev 153957)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-08-12 21:37:06 UTC (rev 153958)
@@ -1264,10 +1264,11 @@
 updateLayout();
 
 if (Page* page = this->page()) {
-if (frame() == page->mainFrame())
+if (frame() == page->mainFrame()) {
 frameView->addPaintPendingMilestones(DidFirstPaintAfterSuppressedIncrementalRendering);
-if (page->requestedLayoutMilestones() & DidFirstLayoutAfterSuppressedIncrementalRendering)
-frame()->loader()->didLayout(DidFirstLayoutAfterSuppressedIncrementalRendering);
+if (page->requestedLayoutMilestones() & DidFirstLayoutAfterSuppressedIncrementalRendering)
+frame()->loader()->didLayout(DidFirstLayoutAfterSuppressedIncrementalRendering);
+}
 }
 
 #if USE(ACCELERATED_COMPOSITING)


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (153957 => 153958)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2013-08-12 21:02:40 UTC (rev 153957)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2013-08-1

[webkit-changes] [153957] branches/safari-537-branch/Source/WebCore

[lforschler]

Title: [153957] branches/safari-537-branch/Source/WebCore








Revision 153957
Author lforsch...@apple.com
Date 2013-08-12 14:02:40 -0700 (Mon, 12 Aug 2013)


Log Message
Merged r153917.  

Modified Paths

branches/safari-537-branch/Source/WebCore/ChangeLog
branches/safari-537-branch/Source/WebCore/platform/mac/WidgetMac.mm




Diff

Modified: branches/safari-537-branch/Source/WebCore/ChangeLog (153956 => 153957)

--- branches/safari-537-branch/Source/WebCore/ChangeLog	2013-08-12 20:54:20 UTC (rev 153956)
+++ branches/safari-537-branch/Source/WebCore/ChangeLog	2013-08-12 21:02:40 UTC (rev 153957)
@@ -1,3 +1,20 @@
+2013-08-12  Lucas Forschler  
+
+Merge r153917
+
+2013-08-09  Anders Carlsson  
+
+Artifacts seen sometimes with layer backed WebKit1 plug-in
+https://bugs.webkit.org/show_bug.cgi?id=119647
+
+
+Reviewed by Beth Dakin.
+
+Don't try to paint layer backed views - they will be painted by Core Animation.
+
+* platform/mac/WidgetMac.mm:
+(WebCore::Widget::paint):
+
 2013-08-09  Lucas Forschler  
 
 Merge r153907


Modified: branches/safari-537-branch/Source/WebCore/platform/mac/WidgetMac.mm (153956 => 153957)

--- branches/safari-537-branch/Source/WebCore/platform/mac/WidgetMac.mm	2013-08-12 20:54:20 UTC (rev 153956)
+++ branches/safari-537-branch/Source/WebCore/platform/mac/WidgetMac.mm	2013-08-12 21:02:40 UTC (rev 153957)
@@ -205,6 +205,12 @@
 return;
 NSView *view = getOuterView();
 
+// We don't want to paint the view at all if it's layer backed, because then we'll end up
+// with multiple copies of the view contents, one in the view's layer itself and one in the
+// WebHTMLView's backing store (either a layer or the window backing store).
+if (view.layer)
+return;
+
 // Take a reference to this Widget, because sending messages to the views can invoke arbitrary
 // code, which can deref it.
 RefPtr protectedThis(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153956] trunk

[bdakin]

Title: [153956] trunk








Revision 153956
Author bda...@apple.com
Date 2013-08-12 13:54:20 -0700 (Mon, 12 Aug 2013)


Log Message
Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=119658

Reviewed by Darin Adler.

Source/WebKit2: 

Removing this function entirely will change some functionality in the Nightlies, 
but we think that is an acceptable difference for the Nightlies. If is does cause 
a problem though, we can roll out this patch and deprecate the function instead.

* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeLoaderClient):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleLoaderClient):

Tools: 

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.h
trunk/Source/WebKit2/UIProcess/WebLoaderClient.cpp
trunk/Source/WebKit2/UIProcess/WebLoaderClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (153955 => 153956)

--- trunk/Source/WebKit2/ChangeLog	2013-08-12 19:47:09 UTC (rev 153955)
+++ trunk/Source/WebKit2/ChangeLog	2013-08-12 20:54:20 UTC (rev 153956)
@@ -1,3 +1,29 @@
+2013-08-12  Beth Dakin  
+
+Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=119658
+
+Reviewed by Darin Adler.
+
+Removing this function entirely will change some functionality in the Nightlies, 
+but we think that is an acceptable difference for the Nightlies. If is does cause 
+a problem though, we can roll out this patch and deprecate the function instead.
+
+* UIProcess/API/C/WKPage.h:
+* UIProcess/WebLoaderClient.cpp:
+* UIProcess/WebLoaderClient.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::initializeLoaderClient):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
+* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
+* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::dispatchDidLayout):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::initializeInjectedBundleLoaderClient):
+
 2013-08-12  Arunprasad Rajkumar  
 
 [Qt] [WebKit2] Remove duplicate RAM Size calculation and reuse WTF::ramSize()


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.h (153955 => 153956)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.h	2013-08-12 19:47:09 UTC (rev 153955)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.h	2013-08-12 20:54:20 UTC (rev 153956)
@@ -79,7 +79,6 @@
 typedef void (*WKPageDidReceiveAuthenticationChallengeInFrameCallback)(WKPageRef page, WKFrameRef frame, WKAuthenticationChallengeRef authenticationChallenge, const void *clientInfo);
 typedef void (*WKPageDidChangeBackForwardListCallback)(WKPageRef page, WKBackForwardListItemRef addedItem, WKArrayRef removedItems, const void *clientInfo);
 typedef bool (*WKPageShouldGoToBackForwardListItemCallback)(WKPageRef page, WKBackForwardListItemRef item, const void *clientInfo);
-typedef void (*WKPageDidNewFirstVisuallyNonEmptyLayoutCallback)(WKPageRef page, WKTypeRef userData, const void *clientInfo);
 typedef void (*WKPageWillGoToBackForwardListItemCallback)(WKPageRef page, WKBackForwardListItemRef item, WKTypeRef userData, const void *clientInfo);
 typedef void (*WKPageDidLayoutCallback)(WKPageRef page, WKLayoutMilestones milestones, WKTypeRef us

[webkit-changes] [153954] trunk/Tools

[seokju]

Title: [153954] trunk/Tools








Revision 153954
Author seo...@webkit.org
Date 2013-08-12 12:41:13 -0700 (Mon, 12 Aug 2013)


Log Message
Remove glu's libtest rule from checker.py
https://bugs.webkit.org/show_bug.cgi?id=119674

Reviewed by Darin Adler.

* Scripts/webkitpy/style/checker.py: It is no longer used after r148032.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checker.py




Diff

Modified: trunk/Tools/ChangeLog (153953 => 153954)

--- trunk/Tools/ChangeLog	2013-08-12 19:24:58 UTC (rev 153953)
+++ trunk/Tools/ChangeLog	2013-08-12 19:41:13 UTC (rev 153954)
@@ -1,3 +1,12 @@
+2013-08-12  Seokju Kwon  
+
+Remove glu's libtest rule from checker.py
+https://bugs.webkit.org/show_bug.cgi?id=119674
+
+Reviewed by Darin Adler.
+
+* Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
+
 2013-08-11  ChangSeok Oh  
 
 Unreviewed. Change my primary mail address.


Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (153953 => 153954)

--- trunk/Tools/Scripts/webkitpy/style/checker.py	2013-08-12 19:24:58 UTC (rev 153953)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py	2013-08-12 19:41:13 UTC (rev 153954)
@@ -260,13 +260,6 @@
   "+pep8/W291",  # Trailing white space
   "+whitespace/carriage_return"]),
 
-([# glu's libtess is third-party code, and doesn't follow WebKit style.
-  "Source/ThirdParty/glu"],
- ["-readability",
-  "-whitespace",
-  "-build/header_guard",
-  "-build/include_order"]),
-
 ([# There is no way to avoid the symbols __jit_debug_register_code
   # and __jit_debug_descriptor when integrating with gdb.
   "Source/_javascript_Core/jit/GDBInterface.cpp"],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153953] trunk/LayoutTests

[ap]

Title: [153953] trunk/LayoutTests








Revision 153953
Author a...@apple.com
Date 2013-08-12 12:24:58 -0700 (Mon, 12 Aug 2013)


Log Message
Multiple CSP tests complain about undefined strings in echo-object-data.pl and echo-script-src.pl
https://bugs.webkit.org/show_bug.cgi?id=119692

Reviewed by Darin Adler.

* http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl:
* http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl:
Check whether optional CGI parameters are provided.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl




Diff

Modified: trunk/LayoutTests/ChangeLog (153952 => 153953)

--- trunk/LayoutTests/ChangeLog	2013-08-12 19:13:34 UTC (rev 153952)
+++ trunk/LayoutTests/ChangeLog	2013-08-12 19:24:58 UTC (rev 153953)
@@ -1,3 +1,14 @@
+2013-08-12  Alexey Proskuryakov  
+
+Multiple CSP tests complain about undefined strings in echo-object-data.pl and echo-script-src.pl
+https://bugs.webkit.org/show_bug.cgi?id=119692
+
+Reviewed by Darin Adler.
+
+* http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl:
+* http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl:
+Check whether optional CGI parameters are provided.
+
 2013-08-12  Dean Jackson  
 
 Shadows don't support viewport units


Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl (153952 => 153953)

--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl	2013-08-12 19:13:34 UTC (rev 153952)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl	2013-08-12 19:24:58 UTC (rev 153953)
@@ -5,19 +5,20 @@
 my $cgi = new CGI;
 
 print "Content-Type: text/html; charset=UTF-8\n";
-if ($cgi->param('experimental') eq 'true') {
-print "X-WebKit-CSP: ".$cgi->param('csp')."\n\n";
+my $experimental = $cgi->param('experimental') || "";
+if ($experimental eq 'true') {
+print "X-WebKit-CSP: " . $cgi->param('csp') . "\n\n";
 } else {
-print "Content-Security-Policy: ".$cgi->param('csp')."\n\n";
+print "Content-Security-Policy: " . $cgi->param('csp') . "\n\n";
 }
 
 print "\n";
 print "\n";
 print "\n";
 print "-print "