[webkit-changes] [154805] trunk/Tools

[ap]

Title: [154805] trunk/Tools








Revision 154805
Author a...@apple.com
Date 2013-08-28 23:11:10 -0700 (Wed, 28 Aug 2013)


Log Message
[WK2][Mac] WebKitTestRunner doesn't force system appearance
https://bugs.webkit.org/show_bug.cgi?id=120437

Reviewed by Darin Adler.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize): Set AppleAquaColorVariant,
AppleHighlightColor and AppleOtherHighlightColor to the same values that DRT uses.
Fixed formatting.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm




Diff

Modified: trunk/Tools/ChangeLog (154804 => 154805)

--- trunk/Tools/ChangeLog	2013-08-29 04:03:05 UTC (rev 154804)
+++ trunk/Tools/ChangeLog	2013-08-29 06:11:10 UTC (rev 154805)
@@ -1,3 +1,15 @@
+2013-08-28  Alexey Proskuryakov  
+
+[WK2][Mac] WebKitTestRunner doesn't force system appearance
+https://bugs.webkit.org/show_bug.cgi?id=120437
+
+Reviewed by Darin Adler.
+
+* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
+(WTR::InjectedBundle::platformInitialize): Set AppleAquaColorVariant,
+AppleHighlightColor and AppleOtherHighlightColor to the same values that DRT uses.
+Fixed formatting.
+
 2013-08-16  Ryosuke Niwa  
 
  [Mac] Add a way to easily test attributed string generation


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm (154804 => 154805)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm	2013-08-29 04:03:05 UTC (rev 154804)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm	2013-08-29 06:11:10 UTC (rev 154805)
@@ -39,17 +39,23 @@
 
 void InjectedBundle::platformInitialize(WKTypeRef)
 {
+static const int NoFontSmoothing = 0;
+static const int BlueTintedAppearance = 1;
+
 NSDictionary *dict = [NSDictionary dictionaryWithObjectsAndKeys:
-[NSNumber numberWithInteger:4],   @"AppleAntiAliasingThreshold",
-[NSNumber numberWithInteger:0],   @"AppleFontSmoothing",
+[NSNumber numberWithInteger:4], @"AppleAntiAliasingThreshold",
+[NSNumber numberWithInteger:NoFontSmoothing], @"AppleFontSmoothing",
+[NSNumber numberWithInteger:BlueTintedAppearance], @"AppleAquaColorVariant",
+@"0.709800 0.835300 1.00", @"AppleHighlightColor",
+@"0.50 0.50 0.50", @"AppleOtherHighlightColor",
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
-[NSNumber numberWithBool:NO], @"NSScrollAnimationEnabled",
+[NSNumber numberWithBool:NO], @"NSScrollAnimationEnabled",
 #else
-[NSNumber numberWithBool:NO], @"AppleScrollAnimationEnabled",
+[NSNumber numberWithBool:NO], @"AppleScrollAnimationEnabled",
 #endif
-[NSNumber numberWithBool:NO], @"NSOverlayScrollersEnabled",
-@"Always",@"AppleShowScrollBars",
-[NSArray arrayWithObject:@"en"],  @"AppleLanguages",
+[NSNumber numberWithBool:NO], @"NSOverlayScrollersEnabled",
+@"Always", @"AppleShowScrollBars",
+[NSArray arrayWithObject:@"en"], @"AppleLanguages",
 [NSDictionary dictionaryWithObjectsAndKeys:@"notational", @"notationl", nil], @"NSTestCorrectionDictionary",
 nil];
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154803] trunk

[rniwa]

Title: [154803] trunk








Revision 154803
Author rn...@webkit.org
Date 2013-08-28 20:04:07 -0700 (Wed, 28 Aug 2013)


Log Message
 [Mac] Add a way to easily test attributed string generation

Reviewed by Darin Adler.

Tools: 

Add textInputController.legacyAttributedString to retrieve the attributed string for copy & paste.

We can't use textInputController.attributedSubstringFromRange as it uses WebHTMLConverter's static
editingAttributedStringFromRange function, which doesn't implement the full converter at the moment.

Also NSMutableAttributedString.ranges and WebNSRange so that _javascript_ can get a list of all
ranges in a given attributed string.

* DumpRenderTree/mac/TextInputController.m:
(-[WebNSRange initWithNSRange:]):
(-[WebNSRange location]):
(-[WebNSRange length]):
(+[WebNSRange isSelectorExcludedFromWebScript:]):
(+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
(+[NSMutableAttributedString webScriptNameForSelector:]):
(-[NSMutableAttributedString ranges]): Added.
(+[TextInputController isSelectorExcludedFromWebScript:]):
(+[TextInputController webScriptNameForSelector:]):
(-[TextInputController legacyAttributedString:]):

LayoutTests: 

Add basic tests for textInputController.legacyAttributedString.

* platform/mac-wk2/TestExpectations:
* platform/mac/editing/attributed-string: Added.
* platform/mac/editing/attributed-string/anchor-element-expected.txt: Added.
* platform/mac/editing/attributed-string/anchor-element.html: Added.
* platform/mac/editing/attributed-string/basic-expected.txt: Added.
* platform/mac/editing/attributed-string/basic.html: Added.
* platform/mac/editing/attributed-string/font-size-expected.txt: Added.
* platform/mac/editing/attributed-string/font-size.html: Added.
* platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt: Added.
* platform/mac/editing/attributed-string/font-style-variant-effect.html: Added.
* platform/mac/editing/attributed-string/font-weight-expected.txt: Added.
* platform/mac/editing/attributed-string/font-weight.html: Added.
* platform/mac/editing/attributed-string/letter-spacing-expected.txt: Added.
* platform/mac/editing/attributed-string/letter-spacing.html: Added.
* platform/mac/editing/attributed-string/resources: Added.
* platform/mac/editing/attributed-string/resources/dump-attributed-string.js: Added.
(.):
* platform/mac/editing/attributed-string/text-decorations-expected.txt: Added.
* platform/mac/editing/attributed-string/text-decorations.html: Added.
* platform/mac/editing/attributed-string/vertical-align-expected.txt: Added.
* platform/mac/editing/attributed-string/vertical-align.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/TextInputController.m


Added Paths

trunk/LayoutTests/platform/mac/editing/attributed-string/
trunk/LayoutTests/platform/mac/editing/attributed-string/anchor-element-expected.txt
trunk/LayoutTests/platform/mac/editing/attributed-string/anchor-element.html
trunk/LayoutTests/platform/mac/editing/attributed-string/basic-expected.txt
trunk/LayoutTests/platform/mac/editing/attributed-string/basic.html
trunk/LayoutTests/platform/mac/editing/attributed-string/font-size-expected.txt
trunk/LayoutTests/platform/mac/editing/attributed-string/font-size.html
trunk/LayoutTests/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt
trunk/LayoutTests/platform/mac/editing/attributed-string/font-style-variant-effect.html
trunk/LayoutTests/platform/mac/editing/attributed-string/font-weight-expected.txt
trunk/LayoutTests/platform/mac/editing/attributed-string/font-weight.html
trunk/LayoutTests/platform/mac/editing/attributed-string/letter-spacing-expected.txt
trunk/LayoutTests/platform/mac/editing/attributed-string/letter-spacing.html
trunk/LayoutTests/platform/mac/editing/attributed-string/resources/
trunk/LayoutTests/platform/mac/editing/attributed-string/resources/dump-attributed-string.js
trunk/LayoutTests/platform/mac/editing/attributed-string/text-decorations-expected.txt
trunk/LayoutTests/platform/mac/editing/attributed-string/text-decorations.html
trunk/LayoutTests/platform/mac/editing/attributed-string/vertical-align-expected.txt
trunk/LayoutTests/platform/mac/editing/attributed-string/vertical-align.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154802 => 154803)

--- trunk/LayoutTests/ChangeLog	2013-08-29 02:33:42 UTC (rev 154802)
+++ trunk/LayoutTests/ChangeLog	2013-08-29 03:04:07 UTC (rev 154803)
@@ -1,3 +1,33 @@
+2013-08-16  Ryosuke Niwa  
+
+ [Mac] Add a way to easily test attributed string generation
+
+Reviewed by Darin Adler.
+
+Add basic tests for textInputController.legacyAttributedString.
+
+* platform/mac-wk2/TestExpectations:
+* platform/mac/editing/attributed-string: Added.
+* platform/mac/editing/attributed-string/anchor-element-expected.txt: Added.
+* platform/mac/editi

[webkit-changes] [154802] trunk/Source/WebCore

[cfleizach]

Title: [154802] trunk/Source/WebCore








Revision 154802
Author cfleiz...@apple.com
Date 2013-08-28 19:33:42 -0700 (Wed, 28 Aug 2013)


Log Message
AX: WebProcess at com.apple.WebCore: WebCore::AXObjectCache::rootObject + 27
https://bugs.webkit.org/show_bug.cgi?id=120434

Reviewed by Darin Adler.

Crash logs indicate that there's a null pointer access in rootObject. That seems like it could only
happen in Document was null.

Unfortunately, there are no reproducible steps and no other information to construct a test case.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rootObject):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154801 => 154802)

--- trunk/Source/WebCore/ChangeLog	2013-08-29 01:35:21 UTC (rev 154801)
+++ trunk/Source/WebCore/ChangeLog	2013-08-29 02:33:42 UTC (rev 154802)
@@ -1,3 +1,18 @@
+2013-08-28  Chris Fleizach  
+
+AX: WebProcess at com.apple.WebCore: WebCore::AXObjectCache::rootObject + 27
+https://bugs.webkit.org/show_bug.cgi?id=120434
+
+Reviewed by Darin Adler.
+
+Crash logs indicate that there's a null pointer access in rootObject. That seems like it could only
+happen in Document was null. 
+
+Unfortunately, there are no reproducible steps and no other information to construct a test case.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::rootObject):
+
 2013-08-28  Ryosuke Niwa  
 
 The code to look for an ancestor form element is duplicated in three different places


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (154801 => 154802)

--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2013-08-29 01:35:21 UTC (rev 154801)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2013-08-29 02:33:42 UTC (rev 154802)
@@ -421,6 +421,9 @@
 {
 if (!gAccessibilityEnabled)
 return 0;
+
+if (!m_document)
+return 0;
 
 return getOrCreate(m_document->view());
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154801] trunk/Source/WebCore

[rniwa]

Title: [154801] trunk/Source/WebCore








Revision 154801
Author rn...@webkit.org
Date 2013-08-28 18:35:21 -0700 (Wed, 28 Aug 2013)


Log Message
The code to look for an ancestor form element is duplicated in three different places
https://bugs.webkit.org/show_bug.cgi?id=120391

Reviewed by Darin Adler.

Unduplicated the code by putting a single implementation in HTMLFormElement.cpp.

* WebCore.order:
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::findAssociatedForm):
(WebCore::FormAssociatedElement::formAttributeChanged):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::virtualForm):
* html/HTMLElement.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::findClosestFormAncestor):
* html/HTMLFormElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.order
trunk/Source/WebCore/html/FormAssociatedElement.cpp
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/html/HTMLElement.h
trunk/Source/WebCore/html/HTMLFormControlElement.cpp
trunk/Source/WebCore/html/HTMLFormElement.cpp
trunk/Source/WebCore/html/HTMLFormElement.h
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154800 => 154801)

--- trunk/Source/WebCore/ChangeLog	2013-08-29 01:13:07 UTC (rev 154800)
+++ trunk/Source/WebCore/ChangeLog	2013-08-29 01:35:21 UTC (rev 154801)
@@ -1,5 +1,33 @@
 2013-08-28  Ryosuke Niwa  
 
+The code to look for an ancestor form element is duplicated in three different places
+https://bugs.webkit.org/show_bug.cgi?id=120391
+
+Reviewed by Darin Adler.
+
+Unduplicated the code by putting a single implementation in HTMLFormElement.cpp.
+
+* WebCore.order:
+* html/FormAssociatedElement.cpp:
+(WebCore::FormAssociatedElement::findAssociatedForm):
+(WebCore::FormAssociatedElement::formAttributeChanged):
+* html/HTMLElement.cpp:
+(WebCore::HTMLElement::virtualForm):
+* html/HTMLElement.h:
+* html/HTMLFormControlElement.cpp:
+(WebCore::HTMLFormControlElement::HTMLFormControlElement):
+* html/HTMLFormElement.cpp:
+(WebCore::HTMLFormElement::findClosestFormAncestor):
+* html/HTMLFormElement.h:
+* html/HTMLImageElement.cpp:
+(WebCore::HTMLImageElement::insertedInto):
+* html/HTMLObjectElement.cpp:
+(WebCore::HTMLObjectElement::HTMLObjectElement):
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
+
+2013-08-28  Ryosuke Niwa  
+
 Stop throwing DOM exceptions in internal 'XMLHttpRequest' response getters
 https://bugs.webkit.org/show_bug.cgi?id=120446
 


Modified: trunk/Source/WebCore/WebCore.order (154800 => 154801)

--- trunk/Source/WebCore/WebCore.order	2013-08-29 01:13:07 UTC (rev 154800)
+++ trunk/Source/WebCore/WebCore.order	2013-08-29 01:35:21 UTC (rev 154801)
@@ -5486,7 +5486,6 @@
 __ZN7WebCore22HTMLFormControlElementC2ERKNS_13QualifiedNameEPNS_8DocumentEPNS_15HTMLFormElementE
 __ZN7WebCore16LabelableElementC2ERKNS_13QualifiedNameEPNS_8DocumentE
 __ZN7WebCore21FormAssociatedElementC2Ev
-__ZNK7WebCore11HTMLElement16findFormAncestorEv
 __ZN7WebCore21FormAssociatedElement7setFormEPNS_15HTMLFormElementE
 __ZN7WebCore9InputType10createTextEPNS_16HTMLInputElementE
 __ZN7WebCore13TextInputType6createEPNS_16HTMLInputElementE


Modified: trunk/Source/WebCore/html/FormAssociatedElement.cpp (154800 => 154801)

--- trunk/Source/WebCore/html/FormAssociatedElement.cpp	2013-08-29 01:13:07 UTC (rev 154800)
+++ trunk/Source/WebCore/html/FormAssociatedElement.cpp	2013-08-29 01:35:21 UTC (rev 154801)
@@ -114,7 +114,7 @@
 }
 
 if (!currentAssociatedForm)
-return element->findFormAncestor();
+return HTMLFormElement::findClosestFormAncestor(*element);
 
 return currentAssociatedForm;
 }
@@ -172,7 +172,7 @@
 if (!element->fastHasAttribute(formAttr)) {
 // The form attribute removed. We need to reset form owner here.
 HTMLFormElement* originalForm = m_form;
-setForm(element->findFormAncestor());
+setForm(HTMLFormElement::findClosestFormAncestor(*element));
 HTMLElement* element = toHTMLElement(this);
 if (m_form && m_form != originalForm && m_form->inDocument())
 element->document()->didAssociateFormControl(element);


Modified: trunk/Source/WebCore/html/HTMLElement.cpp (154800 => 154801)

--- trunk/Source/WebCore/html/HTMLElement.cpp	2013-08-29 01:13:07 UTC (rev 154800)
+++ trunk/Source/WebCore/html/HTMLElemen

[webkit-changes] [154800] trunk/Source/WebCore

[rniwa]

Title: [154800] trunk/Source/WebCore








Revision 154800
Author rn...@webkit.org
Date 2013-08-28 18:13:07 -0700 (Wed, 28 Aug 2013)


Log Message
Stop throwing DOM exceptions in internal 'XMLHttpRequest' response getters
https://bugs.webkit.org/show_bug.cgi?id=120446

Reviewed by Alexey Proskuryakov.

Merge https://chromium.googlesource.com/chromium/blink/+/c8188c21452501b68950a9fcc1f5cbc7b4de4df5

Unlike 'responseText' and 'responseXML', 'responseBlob' and
'responseArrayBuffer' are not exposed to _javascript_ (they don't
appear in the IDL or in the specification). As they are only called from
custom bindings in response to a _javascript_ call to the 'response' getter,
we can safely replace the exception-throwing code in the implementation
with an ASSERT that the request type is correct.

* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::response):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseBlob):
(WebCore::XMLHttpRequest::responseArrayBuffer):
* xml/XMLHttpRequest.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (154799 => 154800)

--- trunk/Source/WebCore/ChangeLog	2013-08-29 01:11:18 UTC (rev 154799)
+++ trunk/Source/WebCore/ChangeLog	2013-08-29 01:13:07 UTC (rev 154800)
@@ -1,3 +1,26 @@
+2013-08-28  Ryosuke Niwa  
+
+Stop throwing DOM exceptions in internal 'XMLHttpRequest' response getters
+https://bugs.webkit.org/show_bug.cgi?id=120446
+
+Reviewed by Alexey Proskuryakov.
+
+Merge https://chromium.googlesource.com/chromium/blink/+/c8188c21452501b68950a9fcc1f5cbc7b4de4df5
+
+Unlike 'responseText' and 'responseXML', 'responseBlob' and
+'responseArrayBuffer' are not exposed to _javascript_ (they don't
+appear in the IDL or in the specification). As they are only called from
+custom bindings in response to a _javascript_ call to the 'response' getter,
+we can safely replace the exception-throwing code in the implementation
+with an ASSERT that the request type is correct.
+
+* bindings/js/JSXMLHttpRequestCustom.cpp:
+(WebCore::JSXMLHttpRequest::response):
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::responseBlob):
+(WebCore::XMLHttpRequest::responseArrayBuffer):
+* xml/XMLHttpRequest.h:
+
 2013-08-28  Chris Curtis  
 
 https://bugs.webkit.org/show_bug.cgi?id=119548


Modified: trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp (154799 => 154800)

--- trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp	2013-08-29 01:11:18 UTC (rev 154799)
+++ trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp	2013-08-29 01:13:07 UTC (rev 154800)
@@ -180,26 +180,10 @@
 }
 
 case XMLHttpRequest::ResponseTypeBlob:
-{
-ExceptionCode ec = 0;
-Blob* blob = impl()->responseBlob(ec);
-if (ec) {
-setDOMException(exec, ec);
-return jsUndefined();
-}
-return toJS(exec, globalObject(), blob);
-}
+return toJS(exec, globalObject(), impl()->responseBlob());
 
 case XMLHttpRequest::ResponseTypeArrayBuffer:
-{
-ExceptionCode ec = 0;
-ArrayBuffer* arrayBuffer = impl()->responseArrayBuffer(ec);
-if (ec) {
-setDOMException(exec, ec);
-return jsUndefined();
-}
-return toJS(exec, globalObject(), arrayBuffer);
-}
+return toJS(exec, globalObject(), impl()->responseArrayBuffer());
 }
 
 return jsUndefined();


Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (154799 => 154800)

--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp	2013-08-29 01:11:18 UTC (rev 154799)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp	2013-08-29 01:13:07 UTC (rev 154800)
@@ -277,12 +277,10 @@
 return m_responseDocument.get();
 }
 
-Blob* XMLHttpRequest::responseBlob(ExceptionCode& ec)
+Blob* XMLHttpRequest::responseBlob()
 {
-if (m_responseTypeCode != ResponseTypeBlob) {
-ec = INVALID_STATE_ERR;
-return 0;
-}
+ASSERT(m_responseTypeCode == ResponseTypeBlob);
+
 // We always return null before DONE.
 if (m_state != DONE)
 return 0;
@@ -313,12 +311,9 @@
 return m_responseBlob.get();
 }
 
-ArrayBuffer* XMLHttpRequest::responseArrayBuffer(ExceptionCode& ec)
+ArrayBuffer* XMLHttpRequest::responseArrayBuffer()
 {
-if (m_responseTypeCode != ResponseTypeArrayBuffer) {
-ec = INVALID_STATE_ERR;
-return 0;
-}
+ASSERT(m_responseTypeCode == ResponseTypeArrayBuffer);
 
 if (m_state != DONE)
 return 0;


Modified: trunk/Source/WebCore/xml/XMLHttpRequest.h (154799 => 154800)

--- trunk/Source/WebCore/xml/XMLHttpRequest.h	2013-08-29 01:11:18 U

[webkit-changes] [154799] trunk/LayoutTests

[rniwa]

Title: [154799] trunk/LayoutTests








Revision 154799
Author rn...@webkit.org
Date 2013-08-28 18:11:18 -0700 (Wed, 28 Aug 2013)


Log Message
Expand classList test to cover exception in toString
https://bugs.webkit.org/show_bug.cgi?id=120444

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/825fefb837133d5545964c17f6aa4b62bfe3df0c

When add and remove is called and there is an exception being thrown
in one of the arguments we need to ensure that we are not calling the
implementation of add and remove.

* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:
(shouldBeEqualToString):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt
trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt
trunk/LayoutTests/fast/dom/HTMLElement/script-tests/class-list.js




Diff

Modified: trunk/LayoutTests/ChangeLog (154798 => 154799)

--- trunk/LayoutTests/ChangeLog	2013-08-29 00:31:24 UTC (rev 154798)
+++ trunk/LayoutTests/ChangeLog	2013-08-29 01:11:18 UTC (rev 154799)
@@ -1,3 +1,21 @@
+2013-08-28  Ryosuke Niwa  
+
+Expand classList test to cover exception in toString
+https://bugs.webkit.org/show_bug.cgi?id=120444
+
+Reviewed by Benjamin Poulain.
+
+Merge https://chromium.googlesource.com/chromium/blink/+/825fefb837133d5545964c17f6aa4b62bfe3df0c
+
+When add and remove is called and there is an exception being thrown
+in one of the arguments we need to ensure that we are not calling the
+implementation of add and remove.
+
+* fast/dom/HTMLElement/class-list-expected.txt:
+* fast/dom/HTMLElement/class-list-quirks-expected.txt:
+* fast/dom/HTMLElement/script-tests/class-list.js:
+(shouldBeEqualToString):
+
 2013-08-28  Chris Curtis  
 
 https://bugs.webkit.org/show_bug.cgi?id=119548


Modified: trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt (154798 => 154799)

--- trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt	2013-08-29 00:31:24 UTC (rev 154798)
+++ trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt	2013-08-29 01:11:18 UTC (rev 154799)
@@ -94,6 +94,8 @@
 PASS element.className is ""
 PASS element.classList.add('a', 'b', 'c d') threw expected DOMException with code 5
 PASS element.className is ""
+PASS element.classList.add("a", {toString: function() { throw new Error("user error"); }}, "b") threw exception Error: user error.
+PASS element.className is ""
 PASS element.classList.add() did not throw exception.
 PASS observer.takeRecords().length is 1
 PASS element.className is "b d  "
@@ -101,6 +103,8 @@
 PASS element.className is "a b c"
 PASS element.classList.remove('a', 'b', '') threw expected DOMException with code 12
 PASS element.className is "a b"
+PASS element.classList.remove("a", {toString: function() { throw new Error("user error"); }}, "b") threw exception Error: user error.
+PASS element.className is "a b"
 PASS element.classList.remove('a', 'b', 'c d') threw expected DOMException with code 5
 PASS element.className is "a b"
 PASS element.classList.remove() did not throw exception.


Modified: trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt (154798 => 154799)

--- trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt	2013-08-29 00:31:24 UTC (rev 154798)
+++ trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt	2013-08-29 01:11:18 UTC (rev 154799)
@@ -94,6 +94,8 @@
 PASS element.className is ""
 PASS element.classList.add('a', 'b', 'c d') threw expected DOMException with code 5
 PASS element.className is ""
+PASS element.classList.add("a", {toString: function() { throw new Error("user error"); }}, "b") threw exception Error: user error.
+PASS element.className is ""
 PASS element.classList.add() did not throw exception.
 PASS observer.takeRecords().length is 1
 PASS element.className is "b d  "
@@ -101,6 +103,8 @@
 PASS element.className is "a b c"
 PASS element.classList.remove('a', 'b', '') threw expected DOMException with code 12
 PASS element.className is "a b"
+PASS element.classList.remove("a", {toString: function() { throw new Error("user error"); }}, "b") threw exception Error: user error.
+PASS element.className is "a b"
 PASS element.classList.remove('a', 'b', 'c d') threw expected DOMException with code 5
 PASS element.className is "a b"
 PASS element.classList.remove() did not throw exception.


Modified: trunk/LayoutTests/fast/dom/HTMLElement/script-tests/class-list.js (154798 => 154799)

--- trunk/LayoutTests/fast/dom/HTMLElement/script-tests/class-list.js	2013-08-29 00:31:24 UTC (rev 154798)
+++ trunk/LayoutTests/fast/dom/HTMLElement/script-tests/class-list.js	2013-08-29 01:11:18 UTC (rev 154799)
@@ -312,6 +312,9 @@
 }, DOMException.INVALID_CHARACTER_ERR);
 shouldBeEqualToString('element.className',

[webkit-changes] [154796] releases/WebKitGTK/webkit-2.2/Source/WebCore

[kov]

Title: [154796] releases/WebKitGTK/webkit-2.2/Source/WebCore








Revision 154796
Author k...@webkit.org
Date 2013-08-28 17:06:30 -0700 (Wed, 28 Aug 2013)


Log Message
Merge 154794 - Unreviewed build fix - copy/paste failure, copied too much.

* bindings/gobject/WebKitDOMCustom.h:

Modified Paths

releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.h




Diff

Modified: releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog (154795 => 154796)

--- releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog	2013-08-28 23:59:25 UTC (rev 154795)
+++ releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog	2013-08-29 00:06:30 UTC (rev 154796)
@@ -1,5 +1,11 @@
 2013-08-28  Gustavo Noronha Silva  
 
+Unreviewed build fix - copy/paste failure, copied too much.
+
+* bindings/gobject/WebKitDOMCustom.h:
+
+2013-08-28  Gustavo Noronha Silva  
+
 [GTK] HTMLElement lost setID and getID - need to add compatibility symbols
 https://bugs.webkit.org/show_bug.cgi?id=120440
 


Modified: releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.h (154795 => 154796)

--- releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2013-08-28 23:59:25 UTC (rev 154795)
+++ releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2013-08-29 00:06:30 UTC (rev 154796)
@@ -114,15 +114,6 @@
 WEBKIT_API void webkit_dom_html_element_set_id(WebKitDOMHTMLElement* self, const gchar* value);
 
 /**
- * webkit_dom_html_element_get_title:
- * @self: A #WebKitDOMHTMLElement
- *
- * Returns:
- *
-**/
-WEBKIT_API gchar* webkit_dom_html_element_get_title(WebKitDOMHTMLElement* self);
-
-/**
  * webkit_dom_webkit_named_flow_get_overflow:
  * @flow: A #WebKitDOMWebKitNamedFlow
  *






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154795] trunk/Source/WebCore

[ap]

Title: [154795] trunk/Source/WebCore








Revision 154795
Author a...@apple.com
Date 2013-08-28 16:59:25 -0700 (Wed, 28 Aug 2013)


Log Message
Remove an unused data member from Page.

Rubber-stamped by Brady Eidson.

* page/Page.cpp:
* page/Page.h:
Removed m_cookieEnabled. This was completely dead code, long obsoleted by PageSettings.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (154794 => 154795)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 23:58:20 UTC (rev 154794)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 23:59:25 UTC (rev 154795)
@@ -1,3 +1,13 @@
+2013-08-28  Alexey Proskuryakov  
+
+Remove an unused data member from Page.
+
+Rubber-stamped by Brady Eidson.
+
+* page/Page.cpp:
+* page/Page.h:
+Removed m_cookieEnabled. This was completely dead code, long obsoleted by PageSettings.
+
 2013-08-28  Gustavo Noronha Silva  
 
 Unreviewed build fix - copy/paste failure, copied too much.


Modified: trunk/Source/WebCore/page/Page.cpp (154794 => 154795)

--- trunk/Source/WebCore/page/Page.cpp	2013-08-28 23:58:20 UTC (rev 154794)
+++ trunk/Source/WebCore/page/Page.cpp	2013-08-28 23:59:25 UTC (rev 154795)
@@ -153,7 +153,6 @@
 , m_defersLoading(false)
 , m_defersLoadingCallCount(0)
 , m_inLowQualityInterpolationMode(false)
-, m_cookieEnabled(true)
 , m_areMemoryCacheClientCallsEnabled(true)
 , m_mediaVolume(1)
 , m_pageScaleFactor(1)


Modified: trunk/Source/WebCore/page/Page.h (154794 => 154795)

--- trunk/Source/WebCore/page/Page.h	2013-08-28 23:58:20 UTC (rev 154794)
+++ trunk/Source/WebCore/page/Page.h	2013-08-28 23:59:25 UTC (rev 154795)
@@ -484,7 +484,6 @@
 unsigned m_defersLoadingCallCount;
 
 bool m_inLowQualityInterpolationMode;
-bool m_cookieEnabled;
 bool m_areMemoryCacheClientCallsEnabled;
 float m_mediaVolume;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154794] trunk/Source/WebCore

[kov]

Title: [154794] trunk/Source/WebCore








Revision 154794
Author k...@webkit.org
Date 2013-08-28 16:58:20 -0700 (Wed, 28 Aug 2013)


Log Message
Unreviewed build fix - copy/paste failure, copied too much.

* bindings/gobject/WebKitDOMCustom.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (154793 => 154794)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 23:54:05 UTC (rev 154793)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 23:58:20 UTC (rev 154794)
@@ -1,3 +1,9 @@
+2013-08-28  Gustavo Noronha Silva  
+
+Unreviewed build fix - copy/paste failure, copied too much.
+
+* bindings/gobject/WebKitDOMCustom.h:
+
 2013-08-28  Dean Jackson  
 
 [WebGL] CoreGraphics can provide greyscale image data


Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h (154793 => 154794)

--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2013-08-28 23:54:05 UTC (rev 154793)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2013-08-28 23:58:20 UTC (rev 154794)
@@ -114,15 +114,6 @@
 WEBKIT_API void webkit_dom_html_element_set_id(WebKitDOMHTMLElement* self, const gchar* value);
 
 /**
- * webkit_dom_html_element_get_title:
- * @self: A #WebKitDOMHTMLElement
- *
- * Returns:
- *
-**/
-WEBKIT_API gchar* webkit_dom_html_element_get_title(WebKitDOMHTMLElement* self);
-
-/**
  * webkit_dom_webkit_named_flow_get_overflow:
  * @flow: A #WebKitDOMWebKitNamedFlow
  *






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154793] trunk

[dino]

Title: [154793] trunk








Revision 154793
Author d...@apple.com
Date 2013-08-28 16:54:05 -0700 (Wed, 28 Aug 2013)


Log Message
[WebGL] CoreGraphics can provide greyscale image data
https://webkit.org/b/120443

Reviewed by Simon Fraser.

Source/WebCore:

CoreGraphics can decode greyscale or greyscale+alpha images
while preserving the format. Our WebGL texture unpacker
was seeing this and assuming it meant the data did not come
from an  element. Since that method already special cased
CoreGraphics, the fix was to simply return true for these
extra types.

I also renamed srcFormatComeFromDOMElementOrImageData
to srcFormatComesFromDOMElementOrImageData.

Test: fast/canvas/webgl/tex-image-with-greyscale-image.html

* platform/graphics/GraphicsContext3D.cpp: Call new name.
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::srcFormatComesFromDOMElementOrImageData):
Add support for R8, AR8, A8, and RA8 data formats.

LayoutTests:

New test that attempts to load and draw an image that only has grey
and alpha channels.

* fast/canvas/webgl/resources/greyscale.png: Added.
* fast/canvas/webgl/tex-image-with-greyscale-image-expected.txt: Added.
* fast/canvas/webgl/tex-image-with-greyscale-image.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h


Added Paths

trunk/LayoutTests/fast/canvas/webgl/resources/greyscale.png
trunk/LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image-expected.txt
trunk/LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154792 => 154793)

--- trunk/LayoutTests/ChangeLog	2013-08-28 23:46:02 UTC (rev 154792)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 23:54:05 UTC (rev 154793)
@@ -1,3 +1,17 @@
+2013-08-28  Dean Jackson  
+
+[WebGL] CoreGraphics can provide greyscale image data
+https://webkit.org/b/120443
+
+Reviewed by Simon Fraser.
+
+New test that attempts to load and draw an image that only has grey
+and alpha channels.
+
+* fast/canvas/webgl/resources/greyscale.png: Added.
+* fast/canvas/webgl/tex-image-with-greyscale-image-expected.txt: Added.
+* fast/canvas/webgl/tex-image-with-greyscale-image.html: Added.
+
 2013-08-28  Simon Fraser  
 
 Fix compositing layers in columns


Added: trunk/LayoutTests/fast/canvas/webgl/resources/greyscale.png

(Binary files differ)

Property changes on: trunk/LayoutTests/fast/canvas/webgl/resources/greyscale.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image-expected.txt (0 => 154793)

--- trunk/LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image-expected.txt	2013-08-28 23:54:05 UTC (rev 154793)
@@ -0,0 +1,10 @@
+Verify we can handle 2 sample per pixel images (e.g. greyscale with alpha)
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS getError was expected value: NO_ERROR : should be no errors
+Testing texImage2D
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image-expected.txt
___


Added: svn:mime-type

Added: svn:keywords

Added: svn:eol-style

Added: trunk/LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image.html (0 => 154793)

--- trunk/LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image.html	(rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image.html	2013-08-28 23:54:05 UTC (rev 154793)
@@ -0,0 +1,52 @@
+
+
+
+
+var wtu = WebGLTestUtils;
+var gl = null;
+var textureLoc = null;
+var successfullyParsed = false;
+
+function init()
+{
+if (window.initNonKhronosFramework)
+window.initNonKhronosFramework(true);
+
+description('Verify we can handle 2 sample per pixel images (e.g. greyscale with alpha)');
+
+gl = wtu.create3DContext("example");
+
+var program = wtu.setupTexturedQuad(gl);
+
+gl.clearColor(0,0,0,1);
+gl.clearDepth(1);
+
+textureLoc = gl.getUniformLocation(program, "tex");
+wtu.loadTexture(gl, "resources/greyscale.png", runTest);
+}
+
+function runTest()
+{
+glErrorShouldBe(gl, gl.NO_ERROR, "should be no errors");
+
+debug('Testing texImage2D');
+gl.clear(gl.COLOR_BUFFER_BIT | gl.DEPTH_BUFFER_BIT);
+// Point the uniform sampler to texture unit 0
+gl.uniform1i(textureLoc, 0);
+// Draw the triangles
+wtu.drawQuad(gl, [0, 0, 0, 255]);
+finishTest();
+}
+
+
+
+
+
+
+
+
+
Property changes on: trunk/LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image.html
_

[webkit-changes] [154790] trunk/Source/WebKit/win

[bfulgham]

Title: [154790] trunk/Source/WebKit/win








Revision 154790
Author bfulg...@apple.com
Date 2013-08-28 16:41:02 -0700 (Wed, 28 Aug 2013)


Log Message
[Windows] LayoutTests on Windows debug fails and exits early
https://bugs.webkit.org/show_bug.cgi?id=120438

Reviewed by Tim Horton.

Visual Studio mishandles char* containing utf8-content. Must manually
escape non-ASCII characters so the byte stream is correct for localized
string lookup.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::cannotShowURLError): Replace unicode apostrophe
character with utf8-byte equivalent.
(WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
(WebFrameLoaderClient::dispatchDidFailToStartPlugin): Ditto.

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (154789 => 154790)

--- trunk/Source/WebKit/win/ChangeLog	2013-08-28 23:37:28 UTC (rev 154789)
+++ trunk/Source/WebKit/win/ChangeLog	2013-08-28 23:41:02 UTC (rev 154790)
@@ -1,5 +1,22 @@
 2013-08-28  Brent Fulgham  
 
+[Windows] LayoutTests on Windows debug fails and exits early
+https://bugs.webkit.org/show_bug.cgi?id=120438
+
+Reviewed by Tim Horton.
+
+Visual Studio mishandles char* containing utf8-content. Must manually
+escape non-ASCII characters so the byte stream is correct for localized
+string lookup.
+
+* WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebFrameLoaderClient::cannotShowURLError): Replace unicode apostrophe
+character with utf8-byte equivalent.
+(WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
+(WebFrameLoaderClient::dispatchDidFailToStartPlugin): Ditto.
+
+2013-08-28  Brent Fulgham  
+
 [Windows] Provide useful error messages for WebKitErrorDomain errors
 https://bugs.webkit.org/show_bug.cgi?id=120428
 


Modified: trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp (154789 => 154790)

--- trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp	2013-08-28 23:37:28 UTC (rev 154789)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp	2013-08-28 23:41:02 UTC (rev 154790)
@@ -880,7 +880,7 @@
 
 ResourceError WebFrameLoaderClient::cannotShowURLError(const ResourceRequest& request)
 {
-return ResourceError(String(WebKitErrorDomain), WebKitErrorCannotShowURL, request.url().string(), WEB_UI_STRING("The URL can\x92t be shown", "WebKitErrorCannotShowURL description"));
+return ResourceError(String(WebKitErrorDomain), WebKitErrorCannotShowURL, request.url().string(), WEB_UI_STRING("The URL can\xE2\x80\x99t be shown", "WebKitErrorCannotShowURL description"));
 }
 
 ResourceError WebFrameLoaderClient::interruptedForPolicyChangeError(const ResourceRequest& request)
@@ -890,7 +890,7 @@
 
 ResourceError WebFrameLoaderClient::cannotShowMIMETypeError(const ResourceResponse& response)
 {
-return ResourceError(String(), WebKitErrorCannotShowMIMEType, response.url().string(), WEB_UI_STRING("Content with specified MIME type can\x92t be shown", "WebKitErrorCannotShowMIMEType description"));
+return ResourceError(String(), WebKitErrorCannotShowMIMEType, response.url().string(), WEB_UI_STRING("Content with specified MIME type can\xE2\x80\x99t be shown", "WebKitErrorCannotShowMIMEType description"));
 }
 
 ResourceError WebFrameLoaderClient::fileDoesNotExistError(const ResourceResponse& response)
@@ -1144,11 +1144,11 @@
 switch (pluginView->status()) {
 case PluginStatusCanNotFindPlugin:
 errorCode = WebKitErrorCannotFindPlugIn;
-description = WEB_UI_STRING("The plug-in can\x92t be found", "WebKitErrorCannotFindPlugin description");
+description = WEB_UI_STRING("The plug-in can\xE2\x80\x99t be found", "WebKitErrorCannotFindPlugin description");
 break;
 case PluginStatusCanNotLoadPlugin:
 errorCode = WebKitErrorCannotLoadPlugIn;
-description = WEB_UI_STRING("The plug-in can\x92t be loaded", "WebKitErrorCannotLoadPlugin description");
+description = WEB_UI_STRING("The plug-in can\xE2\x80\x99t be loaded", "WebKitErrorCannotLoadPlugin description");
 break;
 default:
 ASSERT_NOT_REACHED();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154789] releases/WebKitGTK/webkit-2.2

[kov]

Title: [154789] releases/WebKitGTK/webkit-2.2








Revision 154789
Author k...@webkit.org
Date 2013-08-28 16:37:28 -0700 (Wed, 28 Aug 2013)


Log Message
Merge 154787 - [GTK] Enable maintainer mode configure switch
https://bugs.webkit.org/show_bug.cgi?id=120424

Reviewed by Martin Robinson.

The maintainer mode feature is used by ostree and other automated builders to ensure no autotools
regeneration will happen for a regular tarball build; ostree builders, for instance, are very
conservative with toolchain upgrades, and are still using aclocal 1.12. WebKit's latest tarball
(2.1.90) for some reason tries to regenerate build files, and the build fails because it can't find
the version of aclocal that was used for generating the tarball (1.13).

* configure.ac: enable maintainer mode feature.

Modified Paths

releases/WebKitGTK/webkit-2.2/ChangeLog
releases/WebKitGTK/webkit-2.2/configure.ac




Diff

Modified: releases/WebKitGTK/webkit-2.2/ChangeLog (154788 => 154789)

--- releases/WebKitGTK/webkit-2.2/ChangeLog	2013-08-28 23:36:41 UTC (rev 154788)
+++ releases/WebKitGTK/webkit-2.2/ChangeLog	2013-08-28 23:37:28 UTC (rev 154789)
@@ -1,3 +1,18 @@
+2013-08-28  Gustavo Noronha Silva  
+
+[GTK] Enable maintainer mode configure switch
+https://bugs.webkit.org/show_bug.cgi?id=120424
+
+Reviewed by Martin Robinson.
+
+The maintainer mode feature is used by ostree and other automated builders to ensure no autotools
+regeneration will happen for a regular tarball build; ostree builders, for instance, are very
+conservative with toolchain upgrades, and are still using aclocal 1.12. WebKit's latest tarball
+(2.1.90) for some reason tries to regenerate build files, and the build fails because it can't find
+the version of aclocal that was used for generating the tarball (1.13).
+
+* configure.ac: enable maintainer mode feature.
+
 2013-08-27  Carlos Garcia Campos  
 
 Unreviewed. Update NEWS and Versions.m4 for 2.1.90 release.


Modified: releases/WebKitGTK/webkit-2.2/configure.ac (154788 => 154789)

--- releases/WebKitGTK/webkit-2.2/configure.ac	2013-08-28 23:36:41 UTC (rev 154788)
+++ releases/WebKitGTK/webkit-2.2/configure.ac	2013-08-28 23:37:28 UTC (rev 154789)
@@ -32,6 +32,7 @@
 
 # We would put AM_INIT_AUTOMAKE into SetupAutomake.m4, but seems to cause autoconf errors.
 AM_INIT_AUTOMAKE([foreign subdir-objects dist-xz no-dist-gzip tar-ustar])
+AM_MAINTAINER_MODE([enable])
 m4_include([Source/autotools/SetupAutomake.m4])
 
 ##






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154788] releases/WebKitGTK/webkit-2.2/Source/WebCore

[kov]

Title: [154788] releases/WebKitGTK/webkit-2.2/Source/WebCore








Revision 154788
Author k...@webkit.org
Date 2013-08-28 16:36:41 -0700 (Wed, 28 Aug 2013)


Log Message
Merge 154786 - [GTK] HTMLElement lost setID and getID - need to add compatibility symbols
https://bugs.webkit.org/show_bug.cgi?id=120440

Reviewed by Martin Robinson.

No tests, just adding compatibility symbols.

setID and getID were removed, and the parent class (Element) ones should be used instead.
We need to keep our ABI compatible, though, so add compatibility symbols.

* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_element_get_id):
(webkit_dom_html_element_set_id):
* bindings/gobject/WebKitDOMCustom.h:

Modified Paths

releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp
releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.h




Diff

Modified: releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog (154787 => 154788)

--- releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog	2013-08-28 23:35:34 UTC (rev 154787)
+++ releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog	2013-08-28 23:36:41 UTC (rev 154788)
@@ -1,3 +1,20 @@
+2013-08-28  Gustavo Noronha Silva  
+
+[GTK] HTMLElement lost setID and getID - need to add compatibility symbols
+https://bugs.webkit.org/show_bug.cgi?id=120440
+
+Reviewed by Martin Robinson.
+
+No tests, just adding compatibility symbols.
+
+setID and getID were removed, and the parent class (Element) ones should be used instead.
+We need to keep our ABI compatible, though, so add compatibility symbols.
+
+* bindings/gobject/WebKitDOMCustom.cpp:
+(webkit_dom_html_element_get_id):
+(webkit_dom_html_element_set_id):
+* bindings/gobject/WebKitDOMCustom.h:
+
 2013-08-27  Xabier Rodriguez Calvar  
 
 [GTK] Volume slider shows incorrect track when muted


Modified: releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp (154787 => 154788)

--- releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp	2013-08-28 23:35:34 UTC (rev 154787)
+++ releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp	2013-08-28 23:36:41 UTC (rev 154788)
@@ -64,6 +64,18 @@
 webkit_dom_element_set_class_name(WEBKIT_DOM_ELEMENT(element), value);
 }
 
+gchar* webkit_dom_html_element_get_id(WebKitDOMHTMLElement* element)
+{
+g_warning("The get_id method on WebKitDOMHTMLElement is deprecated. Use the one in WebKitDOMElement instead.");
+return webkit_dom_element_get_id(WEBKIT_DOM_ELEMENT(element));
+}
+
+void webkit_dom_html_element_set_id(WebKitDOMHTMLElement* element, const gchar* value)
+{
+g_warning("The set_id method on WebKitDOMHTMLElement is deprecated. Use the one in WebKitDOMElement instead.");
+webkit_dom_element_set_id(WEBKIT_DOM_ELEMENT(element), value);
+}
+
 gboolean webkit_dom_webkit_named_flow_get_overflow(WebKitDOMWebKitNamedFlow* flow)
 {
 g_warning("The WebKitDOMWebKitNamedFlow::overflow property has been renamed to WebKitDOMWebKitNamedFlow::overset. Please update your code to use the new name.");


Modified: releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.h (154787 => 154788)

--- releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2013-08-28 23:35:34 UTC (rev 154787)
+++ releases/WebKitGTK/webkit-2.2/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2013-08-28 23:36:41 UTC (rev 154788)
@@ -91,6 +91,38 @@
 WEBKIT_API void webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self);
 
 /**
+ * webkit_dom_html_element_get_id:
+ * @self: A #WebKitDOMHTMLElement
+ *
+ * This method is deprecated. Use webkit_dom_element_set_id() instead.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gchar* webkit_dom_html_element_get_id(WebKitDOMHTMLElement* self);
+
+/**
+ * webkit_dom_html_element_set_id:
+ * @self: A #WebKitDOMHTMLElement
+ * @value: A #gchar
+ *
+ * This method is deprecated. Use webkit_dom_element_set_id() instead.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API void webkit_dom_html_element_set_id(WebKitDOMHTMLElement* self, const gchar* value);
+
+/**
+ * webkit_dom_html_element_get_title:
+ * @self: A #WebKitDOMHTMLElement
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gchar* webkit_dom_html_element_get_title(WebKitDOMHTMLElement* self);
+
+/**
  * webkit_dom_webkit_named_flow_get_overflow:
  * @flow: A #WebKitDOMWebKitNamedFlow
  *






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154787] trunk

[kov]

Title: [154787] trunk








Revision 154787
Author k...@webkit.org
Date 2013-08-28 16:35:34 -0700 (Wed, 28 Aug 2013)


Log Message
[GTK] Enable maintainer mode configure switch
https://bugs.webkit.org/show_bug.cgi?id=120424

Reviewed by Martin Robinson.

The maintainer mode feature is used by ostree and other automated builders to ensure no autotools
regeneration will happen for a regular tarball build; ostree builders, for instance, are very
conservative with toolchain upgrades, and are still using aclocal 1.12. WebKit's latest tarball
(2.1.90) for some reason tries to regenerate build files, and the build fails because it can't find
the version of aclocal that was used for generating the tarball (1.13).

* configure.ac: enable maintainer mode feature.

Modified Paths

trunk/ChangeLog
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (154786 => 154787)

--- trunk/ChangeLog	2013-08-28 23:34:43 UTC (rev 154786)
+++ trunk/ChangeLog	2013-08-28 23:35:34 UTC (rev 154787)
@@ -1,3 +1,18 @@
+2013-08-28  Gustavo Noronha Silva  
+
+[GTK] Enable maintainer mode configure switch
+https://bugs.webkit.org/show_bug.cgi?id=120424
+
+Reviewed by Martin Robinson.
+
+The maintainer mode feature is used by ostree and other automated builders to ensure no autotools
+regeneration will happen for a regular tarball build; ostree builders, for instance, are very
+conservative with toolchain upgrades, and are still using aclocal 1.12. WebKit's latest tarball
+(2.1.90) for some reason tries to regenerate build files, and the build fails because it can't find
+the version of aclocal that was used for generating the tarball (1.13).
+
+* configure.ac: enable maintainer mode feature.
+
 2013-08-28  Zan Dobersek  
 
 [GTK] Add support for building JSC with FTL JIT enabled


Modified: trunk/configure.ac (154786 => 154787)

--- trunk/configure.ac	2013-08-28 23:34:43 UTC (rev 154786)
+++ trunk/configure.ac	2013-08-28 23:35:34 UTC (rev 154787)
@@ -32,6 +32,7 @@
 
 # We would put AM_INIT_AUTOMAKE into SetupAutomake.m4, but seems to cause autoconf errors.
 AM_INIT_AUTOMAKE([foreign subdir-objects dist-xz no-dist-gzip tar-ustar])
+AM_MAINTAINER_MODE([enable])
 m4_include([Source/autotools/SetupAutomake.m4])
 
 ##






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154786] trunk/Source/WebCore

[kov]

Title: [154786] trunk/Source/WebCore








Revision 154786
Author k...@webkit.org
Date 2013-08-28 16:34:43 -0700 (Wed, 28 Aug 2013)


Log Message
[GTK] HTMLElement lost setID and getID - need to add compatibility symbols
https://bugs.webkit.org/show_bug.cgi?id=120440

Reviewed by Martin Robinson.

No tests, just adding compatibility symbols.

setID and getID were removed, and the parent class (Element) ones should be used instead.
We need to keep our ABI compatible, though, so add compatibility symbols.

* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_element_get_id):
(webkit_dom_html_element_set_id):
* bindings/gobject/WebKitDOMCustom.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp
trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (154785 => 154786)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 22:52:53 UTC (rev 154785)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 23:34:43 UTC (rev 154786)
@@ -1,3 +1,20 @@
+2013-08-28  Gustavo Noronha Silva  
+
+[GTK] HTMLElement lost setID and getID - need to add compatibility symbols
+https://bugs.webkit.org/show_bug.cgi?id=120440
+
+Reviewed by Martin Robinson.
+
+No tests, just adding compatibility symbols.
+
+setID and getID were removed, and the parent class (Element) ones should be used instead.
+We need to keep our ABI compatible, though, so add compatibility symbols.
+
+* bindings/gobject/WebKitDOMCustom.cpp:
+(webkit_dom_html_element_get_id):
+(webkit_dom_html_element_set_id):
+* bindings/gobject/WebKitDOMCustom.h:
+
 2013-08-28  Simon Fraser  
 
 Fix compositing layers in columns


Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp (154785 => 154786)

--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp	2013-08-28 22:52:53 UTC (rev 154785)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp	2013-08-28 23:34:43 UTC (rev 154786)
@@ -64,6 +64,18 @@
 webkit_dom_element_set_class_name(WEBKIT_DOM_ELEMENT(element), value);
 }
 
+gchar* webkit_dom_html_element_get_id(WebKitDOMHTMLElement* element)
+{
+g_warning("The get_id method on WebKitDOMHTMLElement is deprecated. Use the one in WebKitDOMElement instead.");
+return webkit_dom_element_get_id(WEBKIT_DOM_ELEMENT(element));
+}
+
+void webkit_dom_html_element_set_id(WebKitDOMHTMLElement* element, const gchar* value)
+{
+g_warning("The set_id method on WebKitDOMHTMLElement is deprecated. Use the one in WebKitDOMElement instead.");
+webkit_dom_element_set_id(WEBKIT_DOM_ELEMENT(element), value);
+}
+
 gboolean webkit_dom_webkit_named_flow_get_overflow(WebKitDOMWebKitNamedFlow* flow)
 {
 g_warning("The WebKitDOMWebKitNamedFlow::overflow property has been renamed to WebKitDOMWebKitNamedFlow::overset. Please update your code to use the new name.");


Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h (154785 => 154786)

--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2013-08-28 22:52:53 UTC (rev 154785)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2013-08-28 23:34:43 UTC (rev 154786)
@@ -91,6 +91,38 @@
 WEBKIT_API void webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self);
 
 /**
+ * webkit_dom_html_element_get_id:
+ * @self: A #WebKitDOMHTMLElement
+ *
+ * This method is deprecated. Use webkit_dom_element_set_id() instead.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gchar* webkit_dom_html_element_get_id(WebKitDOMHTMLElement* self);
+
+/**
+ * webkit_dom_html_element_set_id:
+ * @self: A #WebKitDOMHTMLElement
+ * @value: A #gchar
+ *
+ * This method is deprecated. Use webkit_dom_element_set_id() instead.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API void webkit_dom_html_element_set_id(WebKitDOMHTMLElement* self, const gchar* value);
+
+/**
+ * webkit_dom_html_element_get_title:
+ * @self: A #WebKitDOMHTMLElement
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gchar* webkit_dom_html_element_get_title(WebKitDOMHTMLElement* self);
+
+/**
  * webkit_dom_webkit_named_flow_get_overflow:
  * @flow: A #WebKitDOMWebKitNamedFlow
  *






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154784] trunk/Source/WebKit

[bfulgham]

Title: [154784] trunk/Source/WebKit








Revision 154784
Author bfulg...@apple.com
Date 2013-08-28 15:50:20 -0700 (Wed, 28 Aug 2013)


Log Message
[WinCairo] Unreviewed build fix.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add
missing Cairo symbols; don't export CG symbols for Cairo build.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (154783 => 154784)

--- trunk/Source/WebKit/ChangeLog	2013-08-28 22:49:17 UTC (rev 154783)
+++ trunk/Source/WebKit/ChangeLog	2013-08-28 22:50:20 UTC (rev 154784)
@@ -1,3 +1,10 @@
+2013-08-28  Brent Fulgham  
+
+[WinCairo] Unreviewed build fix.
+
+* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add
+missing Cairo symbols; don't export CG symbols for Cairo build.
+
 2013-08-26  Roger Fong  
 
 AppleWin build fix following r154627.


Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in (154783 => 154784)

--- trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in	2013-08-28 22:49:17 UTC (rev 154783)
+++ trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in	2013-08-28 22:50:20 UTC (rev 154784)
@@ -383,14 +383,16 @@
 symbolWithPointer(?getCGImageRef@BitmapImage@WebCore@@UAEPAUCGImage@@XZ, ?getCGImageRef@BitmapImage@WebCore@@UEAAPEAUCGImage@@XZ)
 symbolWithPointer(?getFirstCGImageRefOfSize@BitmapImage@WebCore@@UAEPAUCGImage@@ABVIntSize@2@@Z, ?getFirstCGImageRefOfSize@BitmapImage@WebCore@@UEAAPEAUCGImage@@AEBVIntSize@2@@Z)
 symbolWithPointer(?getCGImageArray@BitmapImage@WebCore@@UAE?AV?$RetainPtr@PBU__CFArray@@@WTF@@XZ, ?getCGImageArray@BitmapImage@WebCore@@UEAA?AV?$RetainPtr@PEBU__CFArray@@@WTF@@XZ)
+symbolWithPointer(?draw@BitmapImage@WebCore@@MAEXPAVGraphicsContext@2@ABVFloatRect@2@1W4ColorSpace@2@W4CompositeOperator@2@W4BlendMode@2@@Z, ?draw@BitmapImage@WebCore@@MEAAXPEAVGraphicsContext@2@AEBVFloatRect@2@1W4ColorSpace@2@W4CompositeOperator@2@W4BlendMode@2@@Z)
 #elif USE(CAIRO)
 symbolWithPointer(?nativeImageForCurrentFrame@BitmapImage@WebCore@@UAE?AV?$PassRefPtr@U_cairo_surface@@@WTF@@XZ, ?nativeImageForCurrentFrame@BitmapImage@WebCore@@UEAA?AV?$PassRefPtr@U_cairo_surface@@@WTF@@XZ)
+symbolWithPointer(?draw@BitmapImage@WebCore@@MAEXPAVGraphicsContext@2@ABVFloatRect@2@1W4ColorSpace@2@W4CompositeOperator@2@W4BlendMode@2@UImageOrientationDescription@2@@Z, ?draw@BitmapImage@WebCore@@MAEXPAVGraphicsContext@2@ABVFloatRect@2@1W4ColorSpace@2@W4CompositeOperator@2@W4BlendMode@2@UImageOrientationDescription@2@@Z)
+symbolWithPointer(?draw@BitmapImage@WebCore@@MAEXPAVGraphicsContext@2@ABVFloatRect@2@1W4ColorSpace@2@W4CompositeOperator@2@W4BlendMode@2@@Z, ?draw@BitmapImage@WebCore@@MAEXPAVGraphicsContext@2@ABVFloatRect@2@1W4ColorSpace@2@W4CompositeOperator@2@W4BlendMode@2@@Z)
 #endif
 symbolWithPointer(?getHBITMAP@BitmapImage@WebCore@@UAE_NPAUHBITMAP__@@@Z, ?getHBITMAP@BitmapImage@WebCore@@UEAA_NPEAUHBITMAP__@@@Z)
 symbolWithPointer(?getHBITMAPOfSize@BitmapImage@WebCore@@UAE_NPAUHBITMAP__@@PAUtagSIZE@@@Z, ?getHBITMAPOfSize@BitmapImage@WebCore@@UEAA_NPEAUHBITMAP__@@PEAUtagSIZE@@@Z)
 symbolWithPointer(?drawPattern@Image@WebCore@@UAEXPAVGraphicsContext@2@ABVFloatRect@2@ABVAffineTransform@2@ABVFloatPoint@2@W4ColorSpace@2@W4CompositeOperator@2@1W4BlendMode@2@@Z, ?drawPattern@Image@WebCore@@UEAAXPEAVGraphicsContext@2@AEBVFloatRect@2@AEBVAffineTransform@2@AEBVFloatPoint@2@W4ColorSpace@2@W4CompositeOperator@2@1W4BlendMode@2@@Z)
 symbolWithPointer(?drawFrameMatchingSourceSize@BitmapImage@WebCore@@MAEXPAVGraphicsContext@2@ABVFloatRect@2@ABVIntSize@2@W4ColorSpace@2@W4CompositeOperator@2@@Z, ?drawFrameMatchingSourceSize@BitmapImage@WebCore@@MEAAXPEAVGraphicsContext@2@AEBVFloatRect@2@AEBVIntSize@2@W4ColorSpace@2@W4CompositeOperator@2@@Z)
-symbolWithPointer(?draw@BitmapImage@WebCore@@MAEXPAVGraphicsContext@2@ABVFloatRect@2@1W4ColorSpace@2@W4CompositeOperator@2@W4BlendMode@2@@Z, ?draw@BitmapImage@WebCore@@MEAAXPEAVGraphicsContext@2@AEBVFloatRect@2@1W4ColorSpace@2@W4CompositeOperator@2@W4BlendMode@2@@Z)
 symbolWithPointer(?mayFillWithSolidColor@BitmapImage@WebCore@@MAE_NXZ, ?mayFillWithSolidColor@BitmapImage@WebCore@@MEAA_NXZ)
 symbolWithPointer(?solidColor@BitmapImage@WebCore@@MBE?AVColor@2@XZ, ?solidColor@BitmapImage@WebCore@@MEBA?AVColor@2@XZ)
 symbolWithPointer(?frameCount@BitmapImage@WebCore@@MAEIXZ, ?frameCount@BitmapImage@WebCore@@MEAA_KXZ)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154783] trunk/Source/WebCore

[bfulgham]

Title: [154783] trunk/Source/WebCore








Revision 154783
Author bfulg...@apple.com
Date 2013-08-28 15:49:17 -0700 (Wed, 28 Aug 2013)


Log Message
[WinCairo] Unreviewed build fix.

* WebCore.vcxproj/WebCore.vcxproj: Don't exclude the full screen
window from the build.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters




Diff

Modified: trunk/Source/WebCore/ChangeLog (154782 => 154783)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 22:44:23 UTC (rev 154782)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 22:49:17 UTC (rev 154783)
@@ -1,3 +1,11 @@
+2013-08-28  Brent Fulgham  
+
+[WinCairo] Unreviewed build fix.
+
+* WebCore.vcxproj/WebCore.vcxproj: Don't exclude the full screen
+window from the build.
+* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
+
 2013-08-28  Benjamin Poulain  
 
 Fix the build after r154780


Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (154782 => 154783)

--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj	2013-08-28 22:44:23 UTC (rev 154782)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj	2013-08-28 22:49:17 UTC (rev 154783)
@@ -1,4 +1,4 @@
-
+
 
   
 
@@ -7762,9 +7762,7 @@
 
 
 
-  true
   true
-  true
   true
 
 
@@ -21412,4 +21410,4 @@
   
 
   
-
+
\ No newline at end of file


Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (154782 => 154783)

--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters	2013-08-28 22:44:23 UTC (rev 154782)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters	2013-08-28 22:49:17 UTC (rev 154783)
@@ -14835,6 +14835,9 @@
 
   rendering\style
 
+
+
+
   
   
 
@@ -15784,4 +15787,4 @@
   plugins\win
 
   
-
+
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154782] trunk/Source/WebCore

[benjamin]

Title: [154782] trunk/Source/WebCore








Revision 154782
Author benja...@webkit.org
Date 2013-08-28 15:44:23 -0700 (Wed, 28 Aug 2013)


Log Message
Fix the build after r154780

* dom/SpaceSplitString.cpp:
(WebCore::SpaceSplitStringData::create):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/SpaceSplitString.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154781 => 154782)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 22:35:14 UTC (rev 154781)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 22:44:23 UTC (rev 154782)
@@ -1,3 +1,10 @@
+2013-08-28  Benjamin Poulain  
+
+Fix the build after r154780
+
+* dom/SpaceSplitString.cpp:
+(WebCore::SpaceSplitStringData::create):
+
 2013-08-27  Benjamin Poulain  
 
 Simplify and clean SpaceSplitString


Modified: trunk/Source/WebCore/dom/SpaceSplitString.cpp (154781 => 154782)

--- trunk/Source/WebCore/dom/SpaceSplitString.cpp	2013-08-28 22:35:14 UTC (rev 154781)
+++ trunk/Source/WebCore/dom/SpaceSplitString.cpp	2013-08-28 22:44:23 UTC (rev 154782)
@@ -219,7 +219,7 @@
 AtomicString* tokenArrayStart = spaceSplitStringData->tokenArrayStart();
 TokenAtomicStringInitializer tokenInitializer(tokenArrayStart);
 tokenizeSpaceSplitString(tokenInitializer, keyString);
-ASSERT(tokenInitializer.nextMemoryBucket() - tokenArrayStart == tokenCount);
+ASSERT(static_cast(tokenInitializer.nextMemoryBucket() - tokenArrayStart) == tokenCount);
 ASSERT(reinterpret_cast(tokenInitializer.nextMemoryBucket()) == reinterpret_cast(spaceSplitStringData) + sizeToAllocate);
 
 return adoptRef(spaceSplitStringData);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154781] trunk

[commit-queue]

Title: [154781] trunk








Revision 154781
Author commit-qu...@webkit.org
Date 2013-08-28 15:35:14 -0700 (Wed, 28 Aug 2013)


Log Message
[GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
https://bugs.webkit.org/show_bug.cgi?id=120419

Patch by Denis Nomiyama  on 2013-08-28
Reviewed by Chris Fleizach.

Tools:

Added a notification for AXFocusedUIElementChanged.

* DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
(axObjectEventListener): Added a notification for AXFocusedUIElementChanged.

LayoutTests:

Updated the expected results according to the fix added to AccessibilityCallbacksAtk.cpp
where a notification was added for AXFocusedUIElementChanged.

* platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (154780 => 154781)

--- trunk/LayoutTests/ChangeLog	2013-08-28 22:29:13 UTC (rev 154780)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 22:35:14 UTC (rev 154781)
@@ -1,3 +1,15 @@
+2013-08-28  Denis Nomiyama  
+
+[GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
+https://bugs.webkit.org/show_bug.cgi?id=120419
+
+Reviewed by Chris Fleizach.
+
+Updated the expected results according to the fix added to AccessibilityCallbacksAtk.cpp
+where a notification was added for AXFocusedUIElementChanged.
+
+* platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt:
+
 2013-08-28  Rob Buis  
 
 Namespace prefix is blindly followed when serializing


Modified: trunk/LayoutTests/platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt (154780 => 154781)

--- trunk/LayoutTests/platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt	2013-08-28 22:29:13 UTC (rev 154780)
+++ trunk/LayoutTests/platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt	2013-08-28 22:35:14 UTC (rev 154781)
@@ -4,4 +4,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+Got notification: AXFocusedUIElementChanged
 
+TEST COMPLETE
+


Modified: trunk/Tools/ChangeLog (154780 => 154781)

--- trunk/Tools/ChangeLog	2013-08-28 22:29:13 UTC (rev 154780)
+++ trunk/Tools/ChangeLog	2013-08-28 22:35:14 UTC (rev 154781)
@@ -1,3 +1,15 @@
+2013-08-28  Denis Nomiyama  
+
+[GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
+https://bugs.webkit.org/show_bug.cgi?id=120419
+
+Reviewed by Chris Fleizach.
+
+Added a notification for AXFocusedUIElementChanged.
+
+* DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
+(axObjectEventListener): Added a notification for AXFocusedUIElementChanged.
+
 2013-08-28  Roger Fong  
 
 Decrease number of workers used in NRWT by the Windows port.


Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp (154780 => 154781)

--- trunk/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp	2013-08-28 22:29:13 UTC (rev 154780)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp	2013-08-28 22:35:14 UTC (rev 154781)
@@ -104,6 +104,7 @@
 } else if (!g_strcmp0(signalQuery.signal_name, "focus-event")) {
 signalName.set(g_strdup("focus-event"));
 signalValue.set(g_strdup_printf("%d", g_value_get_boolean(¶mValues[1])));
+notificationName = "AXFocusedUIElementChanged";
 } else if (!g_strcmp0(signalQuery.signal_name, "children-changed")) {
 signalName.set(g_strdup("children-changed"));
 signalValue.set(g_strdup_printf("%d", g_value_get_uint(¶mValues[1])));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154780] trunk/Source/WebCore

[benjamin]

Title: [154780] trunk/Source/WebCore








Revision 154780
Author benja...@webkit.org
Date 2013-08-28 15:29:13 -0700 (Wed, 28 Aug 2013)


Log Message
Simplify and clean SpaceSplitString
https://bugs.webkit.org/show_bug.cgi?id=120385

Patch by Benjamin Poulain  on 2013-08-27
Reviewed by Ryosuke Niwa.

Clean up of SpaceSplitString following the cleaning of the DOMTokenList hierarchy.
This brings the following:
- Fix the coding style of the header.
- Remove the concepts of empty and null. The list can now be empty or have something.
  There is no null state.
- Put the tokens directly following SpaceSplitStringData instead of using a Vector in between.

* WebCore.exp.in:
* dom/ElementData.h:
(WebCore::ElementData::hasClass):
* dom/SpaceSplitString.cpp:
(WebCore::tokenizeSpaceSplitString):
(WebCore::SpaceSplitStringData::containsAll):
(WebCore::SpaceSplitString::set):
(WebCore::SpaceSplitString::spaceSplitStringContainsValue):
(WebCore::TokenCounterProcessor::TokenCounterProcessor):
(WebCore::TokenCounterProcessor::processToken):
(WebCore::TokenCounterProcessor::tokenCount):
(WebCore::TokenInitializerProcessor::TokenInitializerProcessor):
(WebCore::TokenInitializerProcessor::processToken):
(WebCore::TokenInitializerProcessor::nextMemoryBucket):
(WebCore::SpaceSplitStringData::create):
(WebCore::SpaceSplitStringData::destroy):
* dom/SpaceSplitString.h:
(WebCore::SpaceSplitStringData::contains):
(WebCore::SpaceSplitStringData::size):
(WebCore::SpaceSplitStringData::operator[]):
(WebCore::SpaceSplitStringData::ref):
(WebCore::SpaceSplitStringData::deref):
(WebCore::SpaceSplitStringData::SpaceSplitStringData):
(WebCore::SpaceSplitStringData::~SpaceSplitStringData):
(WebCore::SpaceSplitStringData::tokenArrayStart):
(WebCore::SpaceSplitString::SpaceSplitString):
(WebCore::SpaceSplitString::operator!=):
(WebCore::SpaceSplitString::clear):
(WebCore::SpaceSplitString::contains):
(WebCore::SpaceSplitString::containsAll):
(WebCore::SpaceSplitString::size):
(WebCore::SpaceSplitString::isEmpty):
(WebCore::SpaceSplitString::operator[]):
(WebCore::SpaceSplitString::spaceSplitStringContainsValue):
* html/ClassList.cpp:
(WebCore::ClassList::classNames):
* page/EventHandler.cpp:
(WebCore::findDropZone):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/dom/ElementData.h
trunk/Source/WebCore/dom/SpaceSplitString.cpp
trunk/Source/WebCore/dom/SpaceSplitString.h
trunk/Source/WebCore/html/ClassList.cpp
trunk/Source/WebCore/page/EventHandler.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154779 => 154780)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 22:25:19 UTC (rev 154779)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 22:29:13 UTC (rev 154780)
@@ -1,3 +1,103 @@
+2013-08-27  Benjamin Poulain  
+
+Simplify and clean SpaceSplitString
+https://bugs.webkit.org/show_bug.cgi?id=120385
+
+Reviewed by Ryosuke Niwa.
+
+Clean up of SpaceSplitString following the cleaning of the DOMTokenList hierarchy.
+This brings the following:
+- Fix the coding style of the header.
+- Remove the concepts of empty and null. The list can now be empty or have something.
+  There is no null state.
+- Put the tokens directly following SpaceSplitStringData instead of using a Vector in between.
+
+* WebCore.exp.in:
+* dom/ElementData.h:
+(WebCore::ElementData::hasClass):
+* dom/SpaceSplitString.cpp:
+(WebCore::tokenizeSpaceSplitString):
+(WebCore::SpaceSplitStringData::containsAll):
+(WebCore::SpaceSplitString::set):
+(WebCore::SpaceSplitString::spaceSplitStringContainsValue):
+(WebCore::TokenCounterProcessor::TokenCounterProcessor):
+(WebCore::TokenCounterProcessor::processToken):
+(WebCore::TokenCounterProcessor::tokenCount):
+(WebCore::TokenInitializerProcessor::TokenInitializerProcessor):
+(WebCore::TokenInitializerProcessor::processToken):
+(WebCore::TokenInitializerProcessor::nextMemoryBucket):
+(WebCore::SpaceSplitStringData::create):
+(WebCore::SpaceSplitStringData::destroy):
+* dom/SpaceSplitString.h:
+(WebCore::SpaceSplitStringData::contains):
+(WebCore::SpaceSplitStringData::size):
+(WebCore::SpaceSplitStringData::operator[]):
+(WebCore::SpaceSplitStringData::ref):
+(WebCore::SpaceSplitStringData::deref):
+(WebCore::SpaceSplitStringData::SpaceSplitStringData):
+(WebCore::SpaceSplitStringData::~SpaceSplitStringData):
+(WebCore::SpaceSplitStringData::tokenArrayStart):
+(WebCore::SpaceSplitString::SpaceSplitString):
+(WebCore::SpaceSplitString::operator!=):
+(WebCore::SpaceSplitString::clear):
+(WebCore::SpaceSplitString::contains):
+(WebCore::SpaceSplitString::containsAll):
+(WebCore::SpaceSplitString::size):
+(WebCore::SpaceSplitString::isEmpty):
+(WebCore::S

[webkit-changes] [154779] trunk

[rwlbuis]

Title: [154779] trunk








Revision 154779
Author rwlb...@webkit.org
Date 2013-08-28 15:25:19 -0700 (Wed, 28 Aug 2013)


Log Message
Namespace prefix is blindly followed when serializing
https://bugs.webkit.org/show_bug.cgi?id=19121
Serializer doesn't handling inconsistent prefixes properly
https://bugs.webkit.org/show_bug.cgi?id=117764
Attribute namespaces are serialized as if they were element ones
https://bugs.webkit.org/show_bug.cgi?id=22958

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add code to make sure unique prefixes and namespace declarations are generated.
Unique prefix generation happens when:
- the same prefix is used to map to different namespaces or
- no prefix is given but the attribute is in a namespace.

This is done in order to not violate constraints listed in http://www.w3.org/TR/xml-names11/. In general
the pseudo code listed in http://www.w3.org/TR/DOM-Level-3-Core/namespaces-algorithms.html#normalizeDocumentAlgo
is used, doing the following for attributes:
if the attribute has a namespace then
  if the attribute has no prefix OR prefix is not declared OR conflicts with existing prefix mapping to different NS then
try to find the matching in-scope declaration by looking up the prefix in the namespace -> prefix mapping, if found use that prefix
else if the attribute prefix is not null AND not mapped in-scope, declare the prefix
else generate a unique prefix for the namespace

To keep track of in-scope namespaces a prefix to namespace mapping is used.

Tests: fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html
   fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict.html
   fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix.html
   svg/custom/xlink-prefix-generation-in-attributes.html

* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::MarkupAccumulator):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute):
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::generateUniquePrefix):
(WebCore::MarkupAccumulator::appendAttribute):
* editing/MarkupAccumulator.h:

LayoutTests:

Add tests to make sure unique prefixes and namespace declarations are generated for the
case when the same prefix is used to map to different namespaces. All testcases are based
on the testcases attached to the bugs.

* fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts-expected.txt: Added.
* fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html: Added.
* fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict-expected.txt: Added.
* fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict.html: Added.
* fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix-expected.txt: Added.
* fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix.html: Added.
* svg/custom/xlink-prefix-generation-in-attributes-expected.txt: Added.
* svg/custom/xlink-prefix-generation-in-attributes.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/MarkupAccumulator.cpp
trunk/Source/WebCore/editing/MarkupAccumulator.h


Added Paths

trunk/LayoutTests/fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts-expected.txt
trunk/LayoutTests/fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html
trunk/LayoutTests/fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict-expected.txt
trunk/LayoutTests/fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict.html
trunk/LayoutTests/fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix-expected.txt
trunk/LayoutTests/fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix.html
trunk/LayoutTests/svg/custom/xlink-prefix-generation-in-attributes-expected.txt
trunk/LayoutTests/svg/custom/xlink-prefix-generation-in-attributes.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154778 => 154779)

--- trunk/LayoutTests/ChangeLog	2013-08-28 22:19:25 UTC (rev 154778)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 22:25:19 UTC (rev 154779)
@@ -1,3 +1,27 @@
+2013-08-28  Rob Buis  
+
+Namespace prefix is blindly followed when serializing
+https://bugs.webkit.org/show_bug.cgi?id=19121
+Serializer doesn't handling inconsistent prefixes properly
+https://bugs.webkit.org/show_bug.cgi?id=117764
+Attribute namespaces are serialized as if they were element ones
+https://bugs.webkit.org/show_bug.cgi?id=22958
+
+Reviewed by Ryosuke Niwa.
+
+Add tests to make sure unique prefixes and namespace declarations are generated for the
+case when the same prefix is used to map to different namespaces. All testcases are based
+on the testcases attached to the bugs.
+
+* fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts-expected.txt: Added.
+* fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html: Added.
+* fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict-expected.

[webkit-changes] [154778] trunk

[commit-queue]

Title: [154778] trunk








Revision 154778
Author commit-qu...@webkit.org
Date 2013-08-28 15:19:25 -0700 (Wed, 28 Aug 2013)


Log Message
AX: Cancel button in search field not accessible.


Source/WebCore:

Expose the cancel button that shows in an input element of
type search to accessibility.

Patch by Sam White  on 2013-08-28
Reviewed by Chris Fleizach.

Test: platform/mac/accessibility/search-field-cancel-button.html

* CMakeLists.txt:
* English.lproj/Localizable.strings:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer):
* accessibility/AccessibilityAllInOne.cpp:
* accessibility/AccessibilitySearchFieldButtons.cpp: Added.
(WebCore::AccessibilitySearchFieldCancelButton::create):
(WebCore::AccessibilitySearchFieldCancelButton::AccessibilitySearchFieldCancelButton):
(WebCore::AccessibilitySearchFieldCancelButton::accessibilityDescription):
(WebCore::AccessibilitySearchFieldCancelButton::accessibilityText):
(WebCore::AccessibilitySearchFieldCancelButton::press):
(WebCore::AccessibilitySearchFieldCancelButton::computeAccessibilityIsIgnored):
* accessibility/AccessibilitySearchFieldButtons.h: Added.
* dom/Element.h:
(WebCore::Element::isSearchFieldCancelButtonElement):
* html/shadow/TextControlInnerElements.h:
* platform/LocalizedStrings.cpp:
(WebCore::AXSearchFieldCancelButtonText):
* platform/LocalizedStrings.h:
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXSearchFieldCancelButtonText):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXSearchFieldCancelButtonText):
* platform/qt/LocalizedStringsQt.cpp:
(WebCore::AXSearchFieldCancelButtonText):

LayoutTests:

Make sure the cancel button that shows in an input element of
type search is accessible and actionable.

Patch by Sam White  on 2013-08-28
Reviewed by Chris Fleizach.

* platform/mac/accessibility/search-field-cancel-button-expected.txt: Added.
* platform/mac/accessibility/search-field-cancel-button.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/Localizable.strings
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AccessibilityAllInOne.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/html/shadow/TextControlInnerElements.h
trunk/Source/WebCore/platform/LocalizedStrings.cpp
trunk/Source/WebCore/platform/LocalizedStrings.h
trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp
trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp
trunk/Source/WebCore/platform/qt/LocalizedStringsQt.cpp


Added Paths

trunk/LayoutTests/platform/mac/accessibility/search-field-cancel-button-expected.txt
trunk/LayoutTests/platform/mac/accessibility/search-field-cancel-button.html
trunk/Source/WebCore/accessibility/AccessibilitySearchFieldButtons.cpp
trunk/Source/WebCore/accessibility/AccessibilitySearchFieldButtons.h




Diff

Modified: trunk/LayoutTests/ChangeLog (154777 => 154778)

--- trunk/LayoutTests/ChangeLog	2013-08-28 20:42:02 UTC (rev 154777)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 22:19:25 UTC (rev 154778)
@@ -1,3 +1,16 @@
+2013-08-28  Sam White  
+
+AX: Cancel button in search field not accessible.
+
+
+Make sure the cancel button that shows in an input element of
+type search is accessible and actionable.
+
+Reviewed by Chris Fleizach.
+
+* platform/mac/accessibility/search-field-cancel-button-expected.txt: Added.
+* platform/mac/accessibility/search-field-cancel-button.html: Added.
+
 2013-08-28  Ryosuke Niwa  
 
 REGRESSION(r154586): Past names map should only be used when named item is empty


Added: trunk/LayoutTests/platform/mac/accessibility/search-field-cancel-button-expected.txt (0 => 154778)

--- trunk/LayoutTests/platform/mac/accessibility/search-field-cancel-button-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/search-field-cancel-button-expected.txt	2013-08-28 22:19:25 UTC (rev 154778)
@@ -0,0 +1,15 @@
+
+This tests that the search field cancel button is exposed correctly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS button.description is 'AXDescription: cancel'
+PASS button.role is 'AXRole: AXButton'
+PASS button.roleDescription is 'AXRoleDescription: button'
+PASS document.getElementById('search').value is 'X'
+PASS document.getElementById('search').value is ''
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/platform/mac/accessibility/search-field-cancel-button.html (0 => 154778)

--- trunk/LayoutTests/platform/mac/accessibility/search-field-cancel-button.html	  

[webkit-changes] [154777] trunk/Source/WebInspectorUI

[joepeck]

Title: [154777] trunk/Source/WebInspectorUI








Revision 154777
Author joep...@webkit.org
Date 2013-08-28 13:42:02 -0700 (Wed, 28 Aug 2013)


Log Message
Web Inspector: Give reload icon an :active state and allow CSS to style some SVG images
https://bugs.webkit.org/show_bug.cgi?id=120384

Reviewed by Timothy Hatcher.

The Reload icon is duplicated just to provide different fill colors.
Convert from using  to an  document for this image, and style
it with CSS. This also makes it trivial to add an :active state.

* UserInterface/ImageUtilities.js:
(.invokeCallbackWithDocument):
(.imageLoad):
(.imageError):
(wrappedSVGDocument):
Helpers for downloading and in memory caching SVG images.

* UserInterface/Images/Reload.svg:
* UserInterface/Images/ReloadSelected.svg: Removed.
Updated Reload image better matches the original design (slightly
larger). And the duplicate image can be removed.

* UserInterface/ResourceTreeElement.css:
(.item.resource > .status > .reload-button):
(.item.resource > .status > .reload-button > svg *):
(.item.resource.selected > .status > .reload-button > svg *):
(.item.resource.selected > .status > .reload-button:active > svg *):
Different styles, including a new :active style.

* UserInterface/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.prototype._updateStatusWithMainFrameButtons):
(WebInspector.ResourceTreeElement.prototype._updateStatus):
Handle updating the main frame's state asynchronously since loading the SVG
image document is asynchronous.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/ImageUtilities.js
trunk/Source/WebInspectorUI/UserInterface/Images/Reload.svg
trunk/Source/WebInspectorUI/UserInterface/ResourceTreeElement.css
trunk/Source/WebInspectorUI/UserInterface/ResourceTreeElement.js


Removed Paths

trunk/Source/WebInspectorUI/UserInterface/Images/ReloadSelected.svg




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (154776 => 154777)

--- trunk/Source/WebInspectorUI/ChangeLog	2013-08-28 20:33:57 UTC (rev 154776)
+++ trunk/Source/WebInspectorUI/ChangeLog	2013-08-28 20:42:02 UTC (rev 154777)
@@ -1,3 +1,39 @@
+2013-08-28  Joseph Pecoraro  
+
+Web Inspector: Give reload icon an :active state and allow CSS to style some SVG images
+https://bugs.webkit.org/show_bug.cgi?id=120384
+
+Reviewed by Timothy Hatcher.
+
+The Reload icon is duplicated just to provide different fill colors.
+Convert from using  to an  document for this image, and style
+it with CSS. This also makes it trivial to add an :active state.
+
+* UserInterface/ImageUtilities.js:
+(.invokeCallbackWithDocument):
+(.imageLoad):
+(.imageError):
+(wrappedSVGDocument):
+Helpers for downloading and in memory caching SVG images.
+
+* UserInterface/Images/Reload.svg:
+* UserInterface/Images/ReloadSelected.svg: Removed.
+Updated Reload image better matches the original design (slightly
+larger). And the duplicate image can be removed.
+
+* UserInterface/ResourceTreeElement.css:
+(.item.resource > .status > .reload-button):
+(.item.resource > .status > .reload-button > svg *):
+(.item.resource.selected > .status > .reload-button > svg *):
+(.item.resource.selected > .status > .reload-button:active > svg *):
+Different styles, including a new :active style.
+
+* UserInterface/ResourceTreeElement.js:
+(WebInspector.ResourceTreeElement.prototype._updateStatusWithMainFrameButtons):
+(WebInspector.ResourceTreeElement.prototype._updateStatus):
+Handle updating the main frame's state asynchronously since loading the SVG
+image document is asynchronous.
+
 2013-08-27  Joseph Pecoraro  
 
 Web Inspector: Debugger should have Continue to Here Context Menu


Modified: trunk/Source/WebInspectorUI/UserInterface/ImageUtilities.js (154776 => 154777)

--- trunk/Source/WebInspectorUI/UserInterface/ImageUtilities.js	2013-08-28 20:33:57 UTC (rev 154776)
+++ trunk/Source/WebInspectorUI/UserInterface/ImageUtilities.js	2013-08-28 20:42:02 UTC (rev 154777)
@@ -669,3 +669,62 @@
 context.putImageData(imageData, 0, 0);
 }
 }
+
+
+var svgImageCache = {};
+
+function loadSVGImageDocumentElement(url, callback)
+{
+function invokeCallbackWithDocument(svgText) {
+var parser = new DOMParser;
+var doc = parser.parseFromString(svgText, "image/svg+xml");
+callback(doc.documentElement);
+}
+
+function imageLoad(event) {
+if (xhr.status === 0 || xhr.status === 200) {
+var svgText = xhr.responseText;
+svgImageCache[url] = svgText;
+invokeCallbackWithDocument(svgText);
+} else {
+console.error("Unexpected XHR status (" + xhr.status + ") loading SVG image: " + url);
+callback(null);
+}
+}
+
+function imageError(event) {
+co

[webkit-changes] [154776] trunk/Tools

[roger_fong]

Title: [154776] trunk/Tools








Revision 154776
Author roger_f...@apple.com
Date 2013-08-28 13:33:57 -0700 (Wed, 28 Aug 2013)


Log Message
Decrease number of workers used in NRWT by the Windows port.
https://bugs.webkit.org/show_bug.cgi?id=120435.

Reviewed by Brent Fulgham.

* Scripts/webkitpy/port/win.py:
(WinPort.default_child_processes):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/win.py




Diff

Modified: trunk/Tools/ChangeLog (154775 => 154776)

--- trunk/Tools/ChangeLog	2013-08-28 20:26:22 UTC (rev 154775)
+++ trunk/Tools/ChangeLog	2013-08-28 20:33:57 UTC (rev 154776)
@@ -1,3 +1,13 @@
+2013-08-28  Roger Fong  
+
+Decrease number of workers used in NRWT by the Windows port.
+https://bugs.webkit.org/show_bug.cgi?id=120435.
+
+Reviewed by Brent Fulgham.
+
+* Scripts/webkitpy/port/win.py:
+(WinPort.default_child_processes):
+
 2013-08-28  Allan Sandfeld Jensen  
 
 Http tests fails on Debian with Apache 2.4


Modified: trunk/Tools/Scripts/webkitpy/port/win.py (154775 => 154776)

--- trunk/Tools/Scripts/webkitpy/port/win.py	2013-08-28 20:26:22 UTC (rev 154775)
+++ trunk/Tools/Scripts/webkitpy/port/win.py	2013-08-28 20:33:57 UTC (rev 154776)
@@ -89,6 +89,9 @@
 def operating_system(self):
 return 'win'
 
+def default_child_processes(self):
+return self._executive.cpu_count() / 2
+
 def show_results_html_file(self, results_filename):
 self._run_script('run-safari', [abspath_to_uri(SystemHost().platform, results_filename)])
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154775] trunk/Source/WebCore

[eric . carlson]

Title: [154775] trunk/Source/WebCore








Revision 154775
Author eric.carl...@apple.com
Date 2013-08-28 13:26:22 -0700 (Wed, 28 Aug 2013)


Log Message
MediaPlayerPrivateAVFoundationObjC is painting video frames under the video layer
https://bugs.webkit.org/show_bug.cgi?id=120170

Reviewed by Simon Fraser.

No new tests, it is only possible to test in the debugger.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): Drive by optimization.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): Move logic from paint here.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Do nothing if we already have a video layer,
otherwise call paint().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (154774 => 154775)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 20:06:11 UTC (rev 154774)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 20:26:22 UTC (rev 154775)
@@ -1,3 +1,18 @@
+2013-08-28  Eric Carlson  
+
+MediaPlayerPrivateAVFoundationObjC is painting video frames under the video layer
+https://bugs.webkit.org/show_bug.cgi?id=120170
+
+Reviewed by Simon Fraser.
+
+No new tests, it is only possible to test in the debugger.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): Drive by optimization.
+(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): Move logic from paint here.
+(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Do nothing if we already have a video layer,
+otherwise call paint().
+
 2013-08-28  Antti Koivisto  
 
 Add child and descendant const iterators


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (154774 => 154775)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2013-08-28 20:06:11 UTC (rev 154774)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2013-08-28 20:26:22 UTC (rev 154775)
@@ -390,7 +390,10 @@
 
 bool MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame() const
 {
-return (m_videoFrameHasDrawn || (m_videoLayer && [m_videoLayer.get() isReadyForDisplay]));
+if (currentRenderingMode() == MediaRenderingToLayer)
+return m_videoLayer && [m_videoLayer.get() isReadyForDisplay];
+
+return m_videoFrameHasDrawn;
 }
 
 void MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL(const String& url)
@@ -787,14 +790,6 @@
 if (!metaDataAvailable() || context->paintingDisabled())
 return;
 
-paint(context, rect);
-}
-
-void MediaPlayerPrivateAVFoundationObjC::paint(GraphicsContext* context, const IntRect& rect)
-{
-if (!metaDataAvailable() || context->paintingDisabled())
-return;
-
 setDelayCallbacks(true);
 BEGIN_BLOCK_OBJC_EXCEPTIONS;
 
@@ -810,6 +805,18 @@
 m_videoFrameHasDrawn = true;
 }
 
+void MediaPlayerPrivateAVFoundationObjC::paint(GraphicsContext* context, const IntRect& rect)
+{
+if (!metaDataAvailable() || context->paintingDisabled())
+return;
+
+// We can ignore the request if we are already rendering to a layer.
+if (currentRenderingMode() == MediaRenderingToLayer)
+return;
+
+paintCurrentFrameInContext(context, rect);
+}
+
 #if __MAC_OS_X_VERSION_MIN_REQUIRED < 1080
 void MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator(GraphicsContext* context, const IntRect& rect)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154774] branches/safari-537.60-branch/Source/WebCore

[lforschler]

Title: [154774] branches/safari-537.60-branch/Source/WebCore








Revision 154774
Author lforsch...@apple.com
Date 2013-08-28 13:06:11 -0700 (Wed, 28 Aug 2013)


Log Message
Merged r154694.  

Modified Paths

branches/safari-537.60-branch/Source/WebCore/ChangeLog
branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp




Diff

Modified: branches/safari-537.60-branch/Source/WebCore/ChangeLog (154773 => 154774)

--- branches/safari-537.60-branch/Source/WebCore/ChangeLog	2013-08-28 20:03:52 UTC (rev 154773)
+++ branches/safari-537.60-branch/Source/WebCore/ChangeLog	2013-08-28 20:06:11 UTC (rev 154774)
@@ -1,5 +1,20 @@
 2013-08-28  Lucas Forschler  
 
+Merge r154694
+
+2013-08-27  Brent Fulgham  
+
+[Windows] Correct method call for characteristic update.
+
+Reviewed by Eric Carlson.
+
+* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
+[Windows] Correct method call (should have been "characteristicsChanged", not
+"player()->characteristicChanged()"
+
+2013-08-28  Lucas Forschler  
+
 Merge r154693
 
 2013-08-26  Brent Fulgham  


Modified: branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp (154773 => 154774)

--- branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp	2013-08-28 20:03:52 UTC (rev 154773)
+++ branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp	2013-08-28 20:06:11 UTC (rev 154774)
@@ -917,7 +917,7 @@
 sizeChanged();
 
 if (primaryAudioTrackLanguage != languageOfPrimaryAudioTrack())
-player()->characteristicChanged();
+characteristicsChanged();
 
 setDelayCharacteristicsChangedNotification(false);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154773] branches/safari-537.60-branch/Source/WebCore

[lforschler]

Title: [154773] branches/safari-537.60-branch/Source/WebCore








Revision 154773
Author lforsch...@apple.com
Date 2013-08-28 13:03:52 -0700 (Wed, 28 Aug 2013)


Log Message
Merged r154693.  

Modified Paths

branches/safari-537.60-branch/Source/WebCore/ChangeLog
branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp




Diff

Modified: branches/safari-537.60-branch/Source/WebCore/ChangeLog (154772 => 154773)

--- branches/safari-537.60-branch/Source/WebCore/ChangeLog	2013-08-28 20:01:32 UTC (rev 154772)
+++ branches/safari-537.60-branch/Source/WebCore/ChangeLog	2013-08-28 20:03:52 UTC (rev 154773)
@@ -1,5 +1,19 @@
 2013-08-28  Lucas Forschler  
 
+Merge r154693
+
+2013-08-26  Brent Fulgham  
+
+[Windows] some track language tags are not recognized
+https://bugs.webkit.org/show_bug.cgi?id=120335
+
+Reviewed by Eric Carlson.
+
+* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Revise implementation
+to match logic in platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjc.mm
+
+2013-08-28  Lucas Forschler  
+
 Merge r154527
 
 2013-08-23  Eric Carlson  


Modified: branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp (154772 => 154773)

--- branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp	2013-08-28 20:01:32 UTC (rev 154772)
+++ branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp	2013-08-28 20:03:52 UTC (rev 154773)
@@ -841,6 +841,8 @@
 if (!avAsset(m_avfWrapper))
 return;
 
+setDelayCharacteristicsChangedNotification(true);
+
 bool haveCCTrack = false;
 bool hasCaptions = false;
 
@@ -914,8 +916,10 @@
 
 sizeChanged();
 
-if (!primaryAudioTrackLanguage.isNull() && primaryAudioTrackLanguage != languageOfPrimaryAudioTrack())
+if (primaryAudioTrackLanguage != languageOfPrimaryAudioTrack())
 player()->characteristicChanged();
+
+setDelayCharacteristicsChangedNotification(false);
 }
 
 void MediaPlayerPrivateAVFoundationCF::sizeChanged()
@@ -1095,6 +1099,12 @@
 AVCFAssetTrackRef track = (AVCFAssetTrackRef)CFArrayGetValueAtIndex(tracks.get(), 0);
 RetainPtr language = adoptCF(AVCFAssetTrackCopyExtendedLanguageTag(track));
 
+// If the language code is stored as a QuickTime 5-bit packed code there aren't enough bits for a full
+// RFC 4646 language tag so extendedLanguageTag returns null. In this case languageCode will return the
+// ISO 639-2/T language code so check it.
+if (!language)
+language = adoptCF(AVCFAssetTrackCopyLanguageCode(track));
+
 // Some legacy tracks have "und" as a language, treat that the same as no language at all.
 if (language && CFStringCompare(language.get(), CFSTR("und"), kCFCompareCaseInsensitive) != kCFCompareEqualTo) {
 m_languageOfPrimaryAudioTrack = language.get();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154772] branches/safari-537.60-branch/Source/WebKit

[lforschler]

Title: [154772] branches/safari-537.60-branch/Source/WebKit








Revision 154772
Author lforsch...@apple.com
Date 2013-08-28 13:01:32 -0700 (Wed, 28 Aug 2013)


Log Message
Merged r154642.  

Modified Paths

branches/safari-537.60-branch/Source/WebKit/ChangeLog
branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj
branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters




Diff

Modified: branches/safari-537.60-branch/Source/WebKit/ChangeLog (154771 => 154772)

--- branches/safari-537.60-branch/Source/WebKit/ChangeLog	2013-08-28 20:00:37 UTC (rev 154771)
+++ branches/safari-537.60-branch/Source/WebKit/ChangeLog	2013-08-28 20:01:32 UTC (rev 154772)
@@ -1,5 +1,16 @@
 2013-08-28  Lucas Forschler  
 
+Merge r154642
+
+2013-08-26  Roger Fong  
+
+AppleWin build fix following r154627.
+
+* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
+* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
+
+2013-08-28  Lucas Forschler  
+
 Merge r154627
 
 2013-08-21  Roger Fong  


Modified: branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj (154771 => 154772)

--- branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj	2013-08-28 20:00:37 UTC (rev 154771)
+++ branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj	2013-08-28 20:01:32 UTC (rev 154772)
@@ -145,9 +145,9 @@
 
 
 
-
-
-
+
+
+
   
   
   


Modified: branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters (154771 => 154772)

--- branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters	2013-08-28 20:00:37 UTC (rev 154771)
+++ branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters	2013-08-28 20:01:32 UTC (rev 154772)
@@ -10,8 +10,8 @@
 
 
 
-
-
-
+
+
+
   
 
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154771] branches/safari-537.60-branch/Source/WebKit/win

[lforschler]

Title: [154771] branches/safari-537.60-branch/Source/WebKit/win








Revision 154771
Author lforsch...@apple.com
Date 2013-08-28 13:00:37 -0700 (Wed, 28 Aug 2013)


Log Message
Merged r154634.  

Modified Paths

branches/safari-537.60-branch/Source/WebKit/win/ChangeLog


Added Paths

branches/safari-537.60-branch/Source/WebKit/win/Interfaces/Accessible2/AccessibleEditableText.idl
branches/safari-537.60-branch/Source/WebKit/win/Interfaces/Accessible2/AccessibleText.idl
branches/safari-537.60-branch/Source/WebKit/win/Interfaces/Accessible2/AccessibleText2.idl




Diff

Modified: branches/safari-537.60-branch/Source/WebKit/win/ChangeLog (154770 => 154771)

--- branches/safari-537.60-branch/Source/WebKit/win/ChangeLog	2013-08-28 19:59:40 UTC (rev 154770)
+++ branches/safari-537.60-branch/Source/WebKit/win/ChangeLog	2013-08-28 20:00:37 UTC (rev 154771)
@@ -1,5 +1,17 @@
 2013-08-28  Lucas Forschler  
 
+Merge r154634
+
+2013-08-26  Roger Fong  
+
+Unreviewed. Add missing interface files that were left out in r154627.
+
+* Interfaces/Accessible2/AccessibleEditableText.idl: Added.
+* Interfaces/Accessible2/AccessibleText.idl: Added.
+* Interfaces/Accessible2/AccessibleText2.idl: Added.
+
+2013-08-28  Lucas Forschler  
+
 Merge r154627
 
 2013-08-23  Roger Fong  


Copied: branches/safari-537.60-branch/Source/WebKit/win/Interfaces/Accessible2/AccessibleEditableText.idl (from rev 154634, trunk/Source/WebKit/win/Interfaces/Accessible2/AccessibleEditableText.idl) (0 => 154771)

--- branches/safari-537.60-branch/Source/WebKit/win/Interfaces/Accessible2/AccessibleEditableText.idl	(rev 0)
+++ branches/safari-537.60-branch/Source/WebKit/win/Interfaces/Accessible2/AccessibleEditableText.idl	2013-08-28 20:00:37 UTC (rev 154771)
@@ -0,0 +1,262 @@
+/*
+ *
+ *  File Name (AccessibleEditableText.idl)
+ * 
+ *  IAccessible2 IDL Specification 
+ * 
+ *  Copyright (c) 2007, 2012 Linux Foundation 
+ *  Copyright (c) 2006 IBM Corporation 
+ *  Copyright (c) 2000, 2006 Sun Microsystems, Inc. 
+ *  All rights reserved. 
+ *   
+ *   
+ *  Redistribution and use in source and binary forms, with or without 
+ *  modification, are permitted provided that the following conditions 
+ *  are met: 
+ *   
+ *   1. Redistributions of source code must retain the above copyright 
+ *  notice, this list of conditions and the following disclaimer. 
+ *   
+ *   2. Redistributions in binary form must reproduce the above 
+ *  copyright notice, this list of conditions and the following 
+ *  disclaimer in the documentation and/or other materials 
+ *  provided with the distribution. 
+ *
+ *   3. Neither the name of the Linux Foundation nor the names of its 
+ *  contributors may be used to endorse or promote products 
+ *  derived from this software without specific prior written 
+ *  permission. 
+ *   
+ *  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND 
+ *  CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, 
+ *  INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF 
+ *  MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 
+ *  DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR 
+ *  CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 
+ *  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT 
+ *  NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 
+ *  LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 
+ *  HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 
+ *  CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR 
+ *  OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, 
+ *  EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
+ *   
+ *  This BSD License conforms to the Open Source Initiative "Simplified 
+ *  BSD License" as published at: 
+ *  http://www.opensource.org/licenses/bsd-license.php 
+ *   
+ *  IAccessible2 is a trademark of the Linux Foundation. The IAccessible2 
+ *  mark may be used in accordance with the Linux Foundation Trademark 
+ *  Policy to indicate compliance with the IAccessible2 specification. 
+ * 
+ / 
+
+import "objidl.idl";
+import "oaidl.idl";
+import "oleacc.idl";
+import "IA2CommonTypes.idl";
+
+/** @brief This interface provides clipboard capability to text objects.
+
+ This interface is typically used in conjunction with the IAccessibleText 
+  interface and complements that interface with the additional capability of
+  clipboard operations.  Note that even a read only text object can support
+  the copy capability so this interface is not limited to editable objects.
+
+ The substrings used with this interface are specified as follows:
+  If startOffset is less than endOffset, the substring starts with the 
+  character at startOffset and ends wit

[webkit-changes] [154770] branches/safari-537.60-branch/Source/WebKit

[lforschler]

Title: [154770] branches/safari-537.60-branch/Source/WebKit








Revision 154770
Author lforsch...@apple.com
Date 2013-08-28 12:59:40 -0700 (Wed, 28 Aug 2013)


Log Message
Merged r154627.  

Modified Paths

branches/safari-537.60-branch/Source/WebKit/ChangeLog
branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj
branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters
branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj
branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj.filters
branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj
branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters
branches/safari-537.60-branch/Source/WebKit/win/AccessibleBase.cpp
branches/safari-537.60-branch/Source/WebKit/win/AccessibleBase.h
branches/safari-537.60-branch/Source/WebKit/win/ChangeLog


Added Paths

branches/safari-537.60-branch/Source/WebKit/win/AccessibleTextImpl.cpp
branches/safari-537.60-branch/Source/WebKit/win/AccessibleTextImpl.h




Diff

Modified: branches/safari-537.60-branch/Source/WebKit/ChangeLog (154769 => 154770)

--- branches/safari-537.60-branch/Source/WebKit/ChangeLog	2013-08-28 19:43:51 UTC (rev 154769)
+++ branches/safari-537.60-branch/Source/WebKit/ChangeLog	2013-08-28 19:59:40 UTC (rev 154770)
@@ -1,3 +1,20 @@
+2013-08-28  Lucas Forschler  
+
+Merge r154627
+
+2013-08-21  Roger Fong  
+
+ IAccessibleText and IAccessibleEditableText implementation for AppleWindows port.
+
+Reviewed by Chris Fleizach.
+
+* WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
+* WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters:
+* WebKit.vcxproj/WebKit/WebKit.vcxproj:
+* WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
+* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
+* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
+
 2013-07-12  Lucas Forschler  
 
 Merge r152571


Modified: branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj (154769 => 154770)

--- branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj	2013-08-28 19:43:51 UTC (rev 154769)
+++ branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj	2013-08-28 19:59:40 UTC (rev 154770)
@@ -172,8 +172,11 @@
 
 
 
+
 
 
+
+
 
   true
   true


Modified: branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters (154769 => 154770)

--- branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters	2013-08-28 19:43:51 UTC (rev 154769)
+++ branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters	2013-08-28 19:59:40 UTC (rev 154770)
@@ -277,6 +277,15 @@
 
   IDL
 
+
+  IDL\Accessibility2
+
+
+  IDL\Accessibility2
+
+
+  IDL\Accessibility2
+
   
   
 


Modified: branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj (154769 => 154770)

--- branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj	2013-08-28 19:43:51 UTC (rev 154769)
+++ branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj	2013-08-28 19:59:40 UTC (rev 154770)
@@ -145,6 +145,7 @@
 
 
 
+
 
 
 
@@ -266,6 +267,7 @@
 
 
 
+
 
 
 


Modified: branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj.filters (154769 => 154770)

--- branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj.filters	2013-08-28 19:43:51 UTC (rev 154769)
+++ branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj.filters	2013-08-28 19:59:40 UTC (rev 154770)
@@ -275,6 +275,9 @@
 
   WebCoreSupport
 
+
+  Sources
+
   
   
 
@@ -536,6 +539,9 @@
   Header Files
 
 
+
+  Header Files
+
   
   
 
@@ -628,4 +634,4 @@
   Resources
 
   
-
+
\ No newline at end of file


Modified: branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj (154769 => 154770)

--- branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj	2013-08-28 19:43:51 UTC (rev 154769)
+++ branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj	2013-08-28 19:59:40 UTC (rev 154770)
@@ -145,6 +145,9 @@
 
 
 
+
+
+
   
   
   


Modified: branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters (154769 => 154770)

--- branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters	2013-08-28 19

[webkit-changes] [154767] trunk/Source/WebCore

[commit-queue]

Title: [154767] trunk/Source/WebCore








Revision 154767
Author commit-qu...@webkit.org
Date 2013-08-28 12:41:12 -0700 (Wed, 28 Aug 2013)


Log Message
AX:Null pointer may be dereferenced.
https://bugs.webkit.org/show_bug.cgi?id=120300

Patch by Lukasz Gajowy  on 2013-08-28
Reviewed by Chris Fleizach.

Added a check if newObj is not null and an assert in order to avoid dereferecing null pointer.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154766 => 154767)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 19:24:50 UTC (rev 154766)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 19:41:12 UTC (rev 154767)
@@ -1,3 +1,15 @@
+2013-08-28  Lukasz Gajowy  
+
+AX:Null pointer may be dereferenced.
+https://bugs.webkit.org/show_bug.cgi?id=120300
+
+Reviewed by Chris Fleizach.
+
+Added a check if newObj is not null and an assert in order to avoid dereferecing null pointer.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::getOrCreate):
+
 2013-08-28  Pratik Solanki  
 
 Document::elementSheet() should return a reference


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (154766 => 154767)

--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2013-08-28 19:24:50 UTC (rev 154766)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2013-08-28 19:41:12 UTC (rev 154767)
@@ -330,7 +330,12 @@
 
 // Will crash later if we have two objects for the same widget.
 ASSERT(!get(widget));
-
+
+// Catch the case if an (unsupported) widget type is used. Only FrameView and ScrollBar are supported now.
+ASSERT(newObj);
+if (!newObj)
+return 0;
+
 getAXID(newObj.get());
 
 m_widgetObjectMapping.set(widget, newObj->axObjectID());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154768] branches/safari-537.60-branch

[lforschler]

Title: [154768] branches/safari-537.60-branch








Revision 154768
Author lforsch...@apple.com
Date 2013-08-28 12:41:56 -0700 (Wed, 28 Aug 2013)


Log Message
Merged r154527.  

Modified Paths

branches/safari-537.60-branch/LayoutTests/ChangeLog
branches/safari-537.60-branch/LayoutTests/media/track/text-track-cue-is-reachable.html
branches/safari-537.60-branch/LayoutTests/media/track/text-track-is-reachable.html
branches/safari-537.60-branch/LayoutTests/media/track/track-active-cues.html
branches/safari-537.60-branch/LayoutTests/media/track/track-cue-overlap-snap-to-lines-not-set.html
branches/safari-537.60-branch/LayoutTests/media/track/track-cue-rendering-horizontal.html
branches/safari-537.60-branch/LayoutTests/media/track/track-cue-rendering-vertical.html
branches/safari-537.60-branch/LayoutTests/media/track/track-kind.html
branches/safari-537.60-branch/LayoutTests/media/track/track-large-timestamp.html
branches/safari-537.60-branch/LayoutTests/media/track/track-mode.html
branches/safari-537.60-branch/LayoutTests/media/track/track-text-track-cue-list.html
branches/safari-537.60-branch/LayoutTests/media/track/track-webvtt-tc000-empty.html
branches/safari-537.60-branch/LayoutTests/media/track/track-webvtt-tc002-bom.html
branches/safari-537.60-branch/LayoutTests/media/track/track-webvtt-tc010-no-timings.html
branches/safari-537.60-branch/LayoutTests/media/track/track-webvtt-tc027-empty-cue.html
branches/safari-537.60-branch/LayoutTests/media/track/track-webvtt-tc028-unsupported-markup.html
branches/safari-537.60-branch/LayoutTests/media/track/track-word-breaking.html
branches/safari-537.60-branch/LayoutTests/media/video-test.js
branches/safari-537.60-branch/Source/WebCore/ChangeLog
branches/safari-537.60-branch/Source/WebCore/html/HTMLMediaElement.cpp
branches/safari-537.60-branch/Source/WebCore/html/HTMLMediaElement.h
branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
branches/safari-537.60-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: branches/safari-537.60-branch/LayoutTests/ChangeLog (154767 => 154768)

--- branches/safari-537.60-branch/LayoutTests/ChangeLog	2013-08-28 19:41:12 UTC (rev 154767)
+++ branches/safari-537.60-branch/LayoutTests/ChangeLog	2013-08-28 19:41:56 UTC (rev 154768)
@@ -1,3 +1,35 @@
+2013-08-28  Lucas Forschler  
+
+Merge r154527
+
+2013-08-23  Eric Carlson  
+
+[Mac] some track language tags are not recognized
+https://bugs.webkit.org/show_bug.cgi?id=119643
+
+Reviewed by Jer Noble.
+
+Explicitly set caption mode to "Automatic" so the track 'default' attribute works.
+
+* media/track/text-track-cue-is-reachable.html: 
+* media/track/text-track-is-reachable.html: 
+* media/track/track-active-cues.html:
+* media/track/track-cue-overlap-snap-to-lines-not-set.html:
+* media/track/track-cue-rendering-horizontal.html:
+* media/track/track-cue-rendering-vertical.html:
+* media/track/track-kind.html:
+* media/track/track-large-timestamp.html:
+* media/track/track-mode.html:
+* media/track/track-text-track-cue-list.html:
+* media/track/track-webvtt-tc000-empty.html:
+* media/track/track-webvtt-tc002-bom.html:
+* media/track/track-webvtt-tc010-no-timings.html:
+* media/track/track-webvtt-tc027-empty-cue.html:
+* media/track/track-webvtt-tc028-unsupported-markup.html:
+* media/track/track-word-breaking.html:
+* media/video-test.js:
+(setCaptionDisplayMode):
+
 2013-08-16  Lucas Forschler  
 
 Merge r154147


Modified: branches/safari-537.60-branch/LayoutTests/media/track/text-track-cue-is-reachable.html (154767 => 154768)

--- branches/safari-537.60-branch/LayoutTests/media/track/text-track-cue-is-reachable.html	2013-08-28 19:41:12 UTC (rev 154767)
+++ branches/safari-537.60-branch/LayoutTests/media/track/text-track-cue-is-reachable.html	2013-08-28 19:41:56 UTC (rev 154768)
@@ -37,6 +37,8 @@
 endTest();
 }
 
+setCaptionDisplayMode('Automatic');
+
 
 
 


Modified: branches/safari-537.60-branch/LayoutTests/media/track/text-track-is-reachable.html (154767 => 154768)

--- branches/safari-537.60-branch/LayoutTests/media/track/text-track-is-reachable.html	2013-08-28 19:41:12 UTC (rev 154767)
+++ branches/safari-537.60-branch/LayoutTests/media/track/text-track-is-reachable.html	2013-08-28 19:41:56 UTC (rev 154768)
@@ -38,6 +38,8 @@
 endTest();
 }
 
+setCaptionDisplayMode('Automatic');
+
 
 
 


Modified: branches/safari-537.60-branch/LayoutTests/media/track/track-active-c

[webkit-changes] [154769] trunk/Source/WebCore

[antti]

Title: [154769] trunk/Source/WebCore








Revision 154769
Author an...@apple.com
Date 2013-08-28 12:43:51 -0700 (Wed, 28 Aug 2013)


Log Message
Add child and descendant const iterators
https://bugs.webkit.org/show_bug.cgi?id=120430

Reviewed by Andreas Kling

This patch adds const-correct DOM tree traversal iterators. It also uses them in a few places.

Some const_casts have been applied where constness breaks.

* dom/ChildIterator.h:
(WebCoreChildConstIterator):
(WebCoreoperator):
(WebCore::=):
(WebCoreChildConstIteratorAdapter):
(WebCorebegin):
(WebCoreend):
(WebCore::elementChildren):
(WebCore::childrenOfType):
* dom/DescendantIterator.h:
(WebCoreDescendantConstIterator):
(WebCoreoperator):
(WebCore::=):
(WebCoreDescendantConstIteratorAdapter):
(WebCorebegin):
(WebCoreend):
(WebCore::elementDescendants):
(WebCore::descendantsOfType):
* dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::legend):
* html/HTMLFieldSetElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::finishParsingChildren):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::containsJavaApplet):
* svg/SVGElement.cpp:
(WebCore::SVGElement::title):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
(WebCore::SVGSVGElement::checkIntersection):
(WebCore::SVGSVGElement::checkEnclosure):
(WebCore::SVGSVGElement::getElementById):
* svg/SVGSVGElement.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ChildIterator.h
trunk/Source/WebCore/dom/DescendantIterator.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/html/HTMLFieldSetElement.cpp
trunk/Source/WebCore/html/HTMLFieldSetElement.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp
trunk/Source/WebCore/svg/SVGElement.cpp
trunk/Source/WebCore/svg/SVGSVGElement.cpp
trunk/Source/WebCore/svg/SVGSVGElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (154768 => 154769)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 19:41:56 UTC (rev 154768)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 19:43:51 UTC (rev 154769)
@@ -1,3 +1,50 @@
+2013-08-28  Antti Koivisto  
+
+Add child and descendant const iterators
+https://bugs.webkit.org/show_bug.cgi?id=120430
+
+Reviewed by Andreas Kling
+
+This patch adds const-correct DOM tree traversal iterators. It also uses them in a few places.
+
+Some const_casts have been applied where constness breaks.
+
+* dom/ChildIterator.h:
+(WebCoreChildConstIterator):
+(WebCoreoperator):
+(WebCore::=):
+(WebCoreChildConstIteratorAdapter):
+(WebCorebegin):
+(WebCoreend):
+(WebCore::elementChildren):
+(WebCore::childrenOfType):
+* dom/DescendantIterator.h:
+(WebCoreDescendantConstIterator):
+(WebCoreoperator):
+(WebCore::=):
+(WebCoreDescendantConstIteratorAdapter):
+(WebCorebegin):
+(WebCoreend):
+(WebCore::elementDescendants):
+(WebCore::descendantsOfType):
+* dom/Node.cpp:
+(WebCore::Node::numberOfScopedHTMLStyleChildren):
+* html/HTMLFieldSetElement.cpp:
+(WebCore::HTMLFieldSetElement::legend):
+* html/HTMLFieldSetElement.h:
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::finishParsingChildren):
+* html/HTMLObjectElement.cpp:
+(WebCore::HTMLObjectElement::containsJavaApplet):
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::title):
+* svg/SVGSVGElement.cpp:
+(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
+(WebCore::SVGSVGElement::checkIntersection):
+(WebCore::SVGSVGElement::checkEnclosure):
+(WebCore::SVGSVGElement::getElementById):
+* svg/SVGSVGElement.h:
+
 2013-08-28  Lukasz Gajowy  
 
 AX:Null pointer may be dereferenced.


Modified: trunk/Source/WebCore/dom/ChildIterator.h (154768 => 154769)

--- trunk/Source/WebCore/dom/ChildIterator.h	2013-08-28 19:41:56 UTC (rev 154768)
+++ trunk/Source/WebCore/dom/ChildIterator.h	2013-08-28 19:43:51 UTC (rev 154769)
@@ -53,6 +53,24 @@
 };
 
 template 
+class ChildConstIterator {
+public:
+ChildConstIterator();
+ChildConstIterator(const ElementType* current);
+ChildConstIterator& operator++();
+const ElementType& operator*() const;
+const ElementType* operator->() const;
+bool operator!=(const ChildConstIterator& other) const;
+
+private:
+const ElementType* m_current;
+
+#if !ASSERT_DISABLED
+DescendantIteratorAssertions m_assertions;
+#endif
+};
+
+template 
 class ChildIteratorAdapter {
 public:
 ChildIteratorAdapter(ContainerNode* root);
@@ -63,9 +81,24 @@
 const ContainerNode* m_root;
 };
 
+template 
+class ChildConstIteratorAdapter {

[webkit-changes] [154766] trunk/Source/WebCore

[psolanki]

Title: [154766] trunk/Source/WebCore








Revision 154766
Author psola...@apple.com
Date 2013-08-28 12:24:50 -0700 (Wed, 28 Aug 2013)


Log Message
Document::elementSheet() should return a reference
https://bugs.webkit.org/show_bug.cgi?id=120433

Reviewed by Andreas Kling.

Since elementSheet() always retruns a valid pointer, we can simply return a reference
instead. Also rename m_elemSheet to m_elementSheet.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseInlineStyleDeclaration):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::InlineCSSStyleDeclaration::parentStyleSheet):
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateBaseURL):
(WebCore::Document::elementSheet):
* dom/Document.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleFromString):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/StyledElement.cpp
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154765 => 154766)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 19:00:01 UTC (rev 154765)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 19:24:50 UTC (rev 154766)
@@ -1,3 +1,31 @@
+2013-08-28  Pratik Solanki  
+
+Document::elementSheet() should return a reference
+https://bugs.webkit.org/show_bug.cgi?id=120433
+
+Reviewed by Andreas Kling.
+
+Since elementSheet() always retruns a valid pointer, we can simply return a reference
+instead. Also rename m_elemSheet to m_elementSheet.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseInlineStyleDeclaration):
+* css/PropertySetCSSStyleDeclaration.cpp:
+(WebCore::InlineCSSStyleDeclaration::parentStyleSheet):
+* dom/Document.cpp:
+(WebCore::Document::~Document):
+(WebCore::Document::recalcStyle):
+(WebCore::Document::updateBaseURL):
+(WebCore::Document::elementSheet):
+* dom/Document.h:
+* dom/StyledElement.cpp:
+(WebCore::StyledElement::setInlineStyleFromString):
+(WebCore::StyledElement::setInlineStyleProperty):
+(WebCore::StyledElement::addSubresourceAttributeURLs):
+(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):
+* inspector/InspectorStyleSheet.cpp:
+(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
+
 2013-08-28  Ryosuke Niwa  
 
 REGRESSION(r154586): Past names map should only be used when named item is empty


Modified: trunk/Source/WebCore/css/CSSParser.cpp (154765 => 154766)

--- trunk/Source/WebCore/css/CSSParser.cpp	2013-08-28 19:00:01 UTC (rev 154765)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2013-08-28 19:24:50 UTC (rev 154766)
@@ -1423,9 +1423,9 @@
 
 PassRefPtr CSSParser::parseInlineStyleDeclaration(const String& string, Element* element)
 {
-CSSParserContext context = element->document()->elementSheet()->contents()->parserContext();
+CSSParserContext context = element->document()->elementSheet().contents()->parserContext();
 context.mode = strictToCSSParserMode(element->isHTMLElement() && !element->document()->inQuirksMode());
-return CSSParser(context).parseDeclaration(string, element->document()->elementSheet()->contents());
+return CSSParser(context).parseDeclaration(string, element->document()->elementSheet().contents());
 }
 
 PassRefPtr CSSParser::parseDeclaration(const String& string, StyleSheetContents* contextStyleSheet)


Modified: trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp (154765 => 154766)

--- trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp	2013-08-28 19:00:01 UTC (rev 154765)
+++ trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp	2013-08-28 19:24:50 UTC (rev 154766)
@@ -366,7 +366,7 @@
 
 CSSStyleSheet* InlineCSSStyleDeclaration::parentStyleSheet() const
 {
-return m_parentElement ? m_parentElement->document()->elementSheet() : 0;
+return m_parentElement ? &m_parentElement->document()->elementSheet() : 0;
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/dom/Document.cpp (154765 => 154766)

--- trunk/Source/WebCore/dom/Document.cpp	2013-08-28 19:00:01 UTC (rev 154765)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-08-28 19:24:50 UTC (rev 154766)
@@ -593,8 +593,8 @@
 
 m_styleSheetCollection.clear();
 
-if (m_elemSheet)
-m_elemSheet->clearOwnerNode();
+if (m_elementSheet)
+m_elementSheet->clearOwnerNode();
 
 clearStyleResolver(); // We need to

[webkit-changes] [154765] trunk

[rniwa]

Title: [154765] trunk








Revision 154765
Author rn...@webkit.org
Date 2013-08-28 12:00:01 -0700 (Wed, 28 Aug 2013)


Log Message
REGRESSION(r154586): Past names map should only be used when named item is empty
https://bugs.webkit.org/show_bug.cgi?id=120432

Reviewed by Anders Carlsson.

Source/WebCore: 

Don't add the element from the past names map if we've found elements of the given name.

Test: fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty.html

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getNamedElements):

LayoutTests: 

Add a regression test so that we never regress again.

* fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty-expected.txt: Added.
* fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormElement.cpp


Added Paths

trunk/LayoutTests/fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty-expected.txt
trunk/LayoutTests/fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154764 => 154765)

--- trunk/LayoutTests/ChangeLog	2013-08-28 18:44:20 UTC (rev 154764)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 19:00:01 UTC (rev 154765)
@@ -1,5 +1,17 @@
 2013-08-28  Ryosuke Niwa  
 
+REGRESSION(r154586): Past names map should only be used when named item is empty
+https://bugs.webkit.org/show_bug.cgi?id=120432
+
+Reviewed by Anders Carlsson.
+
+Add a regression test so that we never regress again.
+
+* fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty-expected.txt: Added.
+* fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty.html: Added.
+
+2013-08-28  Ryosuke Niwa  
+
 Fix a typo in the test name.
 
 * fast/forms/past-names-map-should-not-contain-disassociated-elements-expected.txt: Copied from LayoutTests/fast/forms/past-names-map-should-not-contained-disassociated-elements-expected.txt.


Added: trunk/LayoutTests/fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty-expected.txt (0 => 154765)

--- trunk/LayoutTests/fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty-expected.txt	2013-08-28 19:00:01 UTC (rev 154765)
@@ -0,0 +1,8 @@
+PASS form['foo'] is form.childNodes[0]
+PASS form['bar'][0] is form.childNodes[1]
+PASS form['bar'][1] is form.childNodes[2]
+PASS form.childNodes[0].name = 'bar'; form.childNodes[1].name = form.childNodes[2].name = 'foo'; form['foo'].length is 2
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty.html (0 => 154765)

--- trunk/LayoutTests/fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/past-names-map-should-be-used-only-when-named-item-is-empty.html	2013-08-28 19:00:01 UTC (rev 154765)
@@ -0,0 +1,19 @@
+
+
+
+
+
+
+var form = document.querySelector('form');
+shouldBe("form['foo']", "form.childNodes[0]");
+shouldBe("form['bar'][0]", "form.childNodes[1]");
+shouldBe("form['bar'][1]", "form.childNodes[2]");
+shouldBe("form.childNodes[0].name = 'bar'; form.childNodes[1].name = form.childNodes[2].name = 'foo'; form['foo'].length", "2");
+
+var successfullyParsed = true;
+
+
+

[webkit-changes] [154764] trunk/Source/WebKit/win

[bfulgham]

Title: [154764] trunk/Source/WebKit/win








Revision 154764
Author bfulg...@apple.com
Date 2013-08-28 11:44:20 -0700 (Wed, 28 Aug 2013)


Log Message
[Windows] Provide useful error messages for WebKitErrorDomain errors
https://bugs.webkit.org/show_bug.cgi?id=120428

Reviewed by Anders Carlsson.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::cancelledError): Provide text for this error.
(WebFrameLoaderClient::blockedError): Hook up WEB_UI_STRING for this error.
(WebFrameLoaderClient::cannotShowURLError): Ditto
(WebFrameLoaderClient::interruptedForPolicyChangeError): Ditto
(WebFrameLoaderClient::cannotShowMIMETypeError): Ditto
(WebFrameLoaderClient::fileDoesNotExistError): Provide text for this error.
(WebFrameLoaderClient::pluginWillHandleLoadError): Hook up WEB_UI_STRING for this error.
(WebFrameLoaderClient::dispatchDidFailToStartPlugin): Ditto.
(WebFrameLoaderClient::createJavaAppletWidget): Ditto.
(WebFrameLoaderClient::webHistory): Remove blank line above method.

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (154763 => 154764)

--- trunk/Source/WebKit/win/ChangeLog	2013-08-28 18:35:51 UTC (rev 154763)
+++ trunk/Source/WebKit/win/ChangeLog	2013-08-28 18:44:20 UTC (rev 154764)
@@ -1,3 +1,22 @@
+2013-08-28  Brent Fulgham  
+
+[Windows] Provide useful error messages for WebKitErrorDomain errors
+https://bugs.webkit.org/show_bug.cgi?id=120428
+
+Reviewed by Anders Carlsson.
+
+* WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebFrameLoaderClient::cancelledError): Provide text for this error.
+(WebFrameLoaderClient::blockedError): Hook up WEB_UI_STRING for this error.
+(WebFrameLoaderClient::cannotShowURLError): Ditto
+(WebFrameLoaderClient::interruptedForPolicyChangeError): Ditto
+(WebFrameLoaderClient::cannotShowMIMETypeError): Ditto
+(WebFrameLoaderClient::fileDoesNotExistError): Provide text for this error.
+(WebFrameLoaderClient::pluginWillHandleLoadError): Hook up WEB_UI_STRING for this error.
+(WebFrameLoaderClient::dispatchDidFailToStartPlugin): Ditto.
+(WebFrameLoaderClient::createJavaAppletWidget): Ditto.
+(WebFrameLoaderClient::webHistory): Remove blank line above method.
+
 2013-08-27  Brent Fulgham  
 
 [Windows] Loader is not properly determining supported MIME types


Modified: trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp (154763 => 154764)

--- trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp	2013-08-28 18:35:51 UTC (rev 154763)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp	2013-08-28 18:44:20 UTC (rev 154764)
@@ -71,6 +71,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -869,42 +870,37 @@
 {
 // FIXME: Need ChickenCat to include CFNetwork/CFURLError.h to get these values
 // Alternatively, we could create our own error domain/codes.
-return ResourceError(String(WebURLErrorDomain), -999, request.url().string(), String());
+return ResourceError(String(WebURLErrorDomain), -999, request.url().string(), String("Cancelled"));
 }
 
 ResourceError WebFrameLoaderClient::blockedError(const ResourceRequest& request)
 {
-// FIXME: Need to implement the String descriptions for errors in the WebKitErrorDomain and have them localized
-return ResourceError(String(WebKitErrorDomain), WebKitErrorCannotUseRestrictedPort, request.url().string(), String());
+return ResourceError(String(WebKitErrorDomain), WebKitErrorCannotUseRestrictedPort, request.url().string(), WEB_UI_STRING("Not allowed to use restricted network port", "WebKitErrorCannotUseRestrictedPort description"));
 }
 
 ResourceError WebFrameLoaderClient::cannotShowURLError(const ResourceRequest& request)
 {
-// FIXME: Need to implement the String descriptions for errors in the WebKitErrorDomain and have them localized
-return ResourceError(String(WebKitErrorDomain), WebKitErrorCannotShowURL, request.url().string(), String());
+return ResourceError(String(WebKitErrorDomain), WebKitErrorCannotShowURL, request.url().string(), WEB_UI_STRING("The URL can\x92t be shown", "WebKitErrorCannotShowURL description"));
 }
 
 ResourceError WebFrameLoaderClient::interruptedForPolicyChangeError(const ResourceRequest& request)
 {
-// FIXME: Need to implement the String descriptions for errors in the WebKitErrorDomain and have them localized
-return ResourceError(String(WebKitErrorDomain), WebKitErrorFrameLoadInterruptedByPolicyChange, request.url().string(), String());
+return ResourceError(String(WebKitErrorDomain), WebKitErrorFrameLoadInterruptedByPolicyChange, request.url().string(), WEB_UI_STRING("Frame load interrupted", "WebKitErrorFrameLoadInterruptedByPolicyChange description"));
 }
 
-ResourceError WebFrameLoaderClient::cannotShowMIMETypeError(const ResourceRe

[webkit-changes] [154763] trunk/Source/WebKit2

[andersca]

Title: [154763] trunk/Source/WebKit2








Revision 154763
Author ander...@apple.com
Date 2013-08-28 11:35:51 -0700 (Wed, 28 Aug 2013)


Log Message
Allow the Flash plug-in to open its preference pane
https://bugs.webkit.org/show_bug.cgi?id=120431


Reviewed by Andreas Kling.

Forward the -[NSWorkspace openFile:] call to the UI process and allow opening
the Flash preference pane (if Flash asks for it).

* PluginProcess/PluginProcess.h:
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::replacedNSWorkspace_openFile):
(WebKit::initializeCocoaOverrides):
(WebKit::PluginProcess::openFile):
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.messages.in:
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::openURL):
(WebKit::shouldOpenFile):
(WebKit::PluginProcessProxy::openFile):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginProcess.h
trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm
trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h
trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.messages.in
trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (154762 => 154763)

--- trunk/Source/WebKit2/ChangeLog	2013-08-28 18:31:41 UTC (rev 154762)
+++ trunk/Source/WebKit2/ChangeLog	2013-08-28 18:35:51 UTC (rev 154763)
@@ -1,3 +1,26 @@
+2013-08-28  Anders Carlsson  
+
+Allow the Flash plug-in to open its preference pane
+https://bugs.webkit.org/show_bug.cgi?id=120431
+
+
+Reviewed by Andreas Kling.
+
+Forward the -[NSWorkspace openFile:] call to the UI process and allow opening
+the Flash preference pane (if Flash asks for it).
+
+* PluginProcess/PluginProcess.h:
+* PluginProcess/mac/PluginProcessMac.mm:
+(WebKit::replacedNSWorkspace_openFile):
+(WebKit::initializeCocoaOverrides):
+(WebKit::PluginProcess::openFile):
+* UIProcess/Plugins/PluginProcessProxy.h:
+* UIProcess/Plugins/PluginProcessProxy.messages.in:
+* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
+(WebKit::PluginProcessProxy::openURL):
+(WebKit::shouldOpenFile):
+(WebKit::PluginProcessProxy::openFile):
+
 2013-08-28  Tamas Czene  
 
 [wk2] Resolve unused parameters in WebPlatformStrategies.cpp


Modified: trunk/Source/WebKit2/PluginProcess/PluginProcess.h (154762 => 154763)

--- trunk/Source/WebKit2/PluginProcess/PluginProcess.h	2013-08-28 18:31:41 UTC (rev 154762)
+++ trunk/Source/WebKit2/PluginProcess/PluginProcess.h	2013-08-28 18:35:51 UTC (rev 154763)
@@ -60,7 +60,7 @@
 bool launchProcess(const String& launchPath, const Vector& arguments);
 bool launchApplicationAtURL(const String& urlString, const Vector& arguments);
 bool openURL(const String& urlString, int32_t& status, String& launchedURLString);
-
+bool openFile(const String& urlString);
 #endif
 
 private:


Modified: trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm (154762 => 154763)

--- trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm	2013-08-28 18:31:41 UTC (rev 154762)
+++ trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm	2013-08-28 18:35:51 UTC (rev 154763)
@@ -302,6 +302,16 @@
 return NSWorkspace_launchApplicationAtURL_options_configuration_error(self, _cmd, url, options, configuration, error);
 }
 
+static BOOL (*NSWorkspace_openFile)(NSWorkspace *, SEL, NSString *);
+
+static BOOL replacedNSWorkspace_openFile(NSWorkspace *self, SEL _cmd, NSString *fullPath)
+{
+if (PluginProcess::shared().openFile(fullPath))
+return true;
+
+return NSWorkspace_openFile(self, _cmd, fullPath);
+}
+
 static void initializeCocoaOverrides()
 {
 // Override -[NSConcreteTask launch:]
@@ -312,6 +322,10 @@
 Method launchApplicationAtURLOptionsConfigurationErrorMethod = class_getInstanceMethod(objc_getClass("NSWorkspace"), @selector(launchApplicationAtURL:options:configuration:error:));
 NSWorkspace_launchApplicationAtURL_options_configuration_error = reinterpret_cast(method_setImplementation(launchApplicationAtURLOptionsConfigurationErrorMethod, reinterpret_cast(replacedNSWorkspace_launchApplicationAtURL_options_configuration_error)));
 
+// Override -[NSWorkspace openFile:]
+Method openFileMethod = class_getInstanceMethod(objc_getClass("NSWorkspace"), @selector(openFile:));
+NSWorkspace_openFile = reinterpret_cast(method_setImplementation(openFileMethod, reinterpret_cast(replacedNSWorkspace_openFile)));
+
 // Override -[NSApplication runModalForWindow:]
 Method runModalForWindowMethod = class_getInstanceMethod(objc_getClass("NSApplication"), @selector(runModalForWindow:));
 NSApplication_RunModalForWindow = method_setImplementation(runModalForWindowMethod, reinterpret_cast(replacedRunModalForWindow));
@@ -371,6 +385,15 @@
 return result;
 }
 
+bool PluginProcess::openFile(const Stri

[webkit-changes] [154762] trunk/LayoutTests

[rniwa]

Title: [154762] trunk/LayoutTests








Revision 154762
Author rn...@webkit.org
Date 2013-08-28 11:31:41 -0700 (Wed, 28 Aug 2013)


Log Message
Fix a typo in the test name.

* fast/forms/past-names-map-should-not-contain-disassociated-elements-expected.txt: Copied from LayoutTests/fast/forms/past-names-map-should-not-contained-disassociated-elements-expected.txt.
* fast/forms/past-names-map-should-not-contain-disassociated-elements.html: Copied from LayoutTests/fast/forms/past-names-map-should-not-contained-disassociated-elements.html.
* fast/forms/past-names-map-should-not-contained-disassociated-elements-expected.txt: Removed.
* fast/forms/past-names-map-should-not-contained-disassociated-elements.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/forms/past-names-map-should-not-contain-disassociated-elements-expected.txt
trunk/LayoutTests/fast/forms/past-names-map-should-not-contain-disassociated-elements.html


Removed Paths

trunk/LayoutTests/fast/forms/past-names-map-should-not-contained-disassociated-elements-expected.txt
trunk/LayoutTests/fast/forms/past-names-map-should-not-contained-disassociated-elements.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154761 => 154762)

--- trunk/LayoutTests/ChangeLog	2013-08-28 18:28:55 UTC (rev 154761)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 18:31:41 UTC (rev 154762)
@@ -1,3 +1,12 @@
+2013-08-28  Ryosuke Niwa  
+
+Fix a typo in the test name.
+
+* fast/forms/past-names-map-should-not-contain-disassociated-elements-expected.txt: Copied from LayoutTests/fast/forms/past-names-map-should-not-contained-disassociated-elements-expected.txt.
+* fast/forms/past-names-map-should-not-contain-disassociated-elements.html: Copied from LayoutTests/fast/forms/past-names-map-should-not-contained-disassociated-elements.html.
+* fast/forms/past-names-map-should-not-contained-disassociated-elements-expected.txt: Removed.
+* fast/forms/past-names-map-should-not-contained-disassociated-elements.html: Removed.
+
 2013-08-27  Ryosuke Niwa  
 
 Don't keep unassociated elements in the past names map


Copied: trunk/LayoutTests/fast/forms/past-names-map-should-not-contain-disassociated-elements-expected.txt (from rev 154761, trunk/LayoutTests/fast/forms/past-names-map-should-not-contained-disassociated-elements-expected.txt) (0 => 154762)

--- trunk/LayoutTests/fast/forms/past-names-map-should-not-contain-disassociated-elements-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/past-names-map-should-not-contain-disassociated-elements-expected.txt	2013-08-28 18:31:41 UTC (rev 154762)
@@ -0,0 +1,16 @@
+This test ensures elements are removed from the past names map of a form element once they are no longer associated with the form element.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS form1['foo'] is input
+PASS form2.appendChild(form1.firstChild); form1['foo'] is undefined.
+PASS form2['foo'] is input
+PASS form2.removeChild(input);form2['foo'] is undefined.
+PASS form1.appendChild(input); form1['foo'] is input
+PASS input.setAttribute('form', 'form1'); form1.removeChild(input); input.appendChild(form1); form1['foo'] is undefined.
+PASS form1['foo'] is not input
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Copied: trunk/LayoutTests/fast/forms/past-names-map-should-not-contain-disassociated-elements.html (from rev 154761, trunk/LayoutTests/fast/forms/past-names-map-should-not-contained-disassociated-elements.html) (0 => 154762)

--- trunk/LayoutTests/fast/forms/past-names-map-should-not-contain-disassociated-elements.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/past-names-map-should-not-contain-disassociated-elements.html	2013-08-28 18:31:41 UTC (rev 154762)
@@ -0,0 +1,30 @@
+
+
+
+
+
+
+
+description('This test ensures elements are removed from the past names map of a form element once they are no longer associated with the form element.');
+
+var form1 = document.querySelector('#form1');
+var form2 = document.querySelector('#form2');
+var input = document.querySelector('input');
+
+shouldBe("form1['foo']", "input");
+shouldBeUndefined("form2.appendChild(form1.firstChild); form1['foo']");
+
+shouldBe("form2['foo']", "input");
+shouldBeUndefined("form2.removeChild(input);form2['foo']");
+
+shouldBe("form1.appendChild(input); form1['foo']", "input");
+shouldBeUndefined("input.setAttribute('form', 'form1'); form1.removeChild(input); input.appendChild(form1); form1['foo']");
+shouldNotBe("form1['foo']", "input");
+
+var successfullyParsed = true;
+
+
+
+