[webkit-changes] [154968] trunk/Source/WebCore

[darin]

Title: [154968] trunk/Source/WebCore








Revision 154968
Author da...@apple.com
Date 2013-09-02 23:02:11 -0700 (Mon, 02 Sep 2013)


Log Message
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::removeProfile): Fix braces here; a review
comment I forgot to address in my last check-in.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154967 => 154968)

--- trunk/Source/WebCore/ChangeLog	2013-09-03 06:00:45 UTC (rev 154967)
+++ trunk/Source/WebCore/ChangeLog	2013-09-03 06:02:11 UTC (rev 154968)
@@ -1,5 +1,11 @@
 2013-09-02  Darin Adler  da...@apple.com
 
+* inspector/InspectorProfilerAgent.cpp:
+(WebCore::InspectorProfilerAgent::removeProfile): Fix braces here; a review
+comment I forgot to address in my last check-in.
+
+2013-09-02  Darin Adler  da...@apple.com
+
 Cut down on double hashing and code needlessly using hash table iterators
 https://bugs.webkit.org/show_bug.cgi?id=120611
 


Modified: trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp (154967 => 154968)

--- trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp	2013-09-03 06:00:45 UTC (rev 154967)
+++ trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp	2013-09-03 06:02:11 UTC (rev 154968)
@@ -311,11 +311,10 @@
 void InspectorProfilerAgent::removeProfile(ErrorString*, const String type, int rawUid)
 {
 unsigned uid = static_castunsigned(rawUid);
-if (type == CPUProfileType) {
+if (type == CPUProfileType)
 m_profiles.remove(uid);
-} else if (type == HeapProfileType) {
+else if (type == HeapProfileType)
 m_snapshots.remove(uid);
-}
 }
 
 void InspectorProfilerAgent::resetState()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154970] trunk/Source/WebCore

[calvaris]

Title: [154970] trunk/Source/WebCore








Revision 154970
Author calva...@igalia.com
Date 2013-09-03 00:16:02 -0700 (Tue, 03 Sep 2013)


Log Message
[GStreamer] Video player sets system volume to 100%
https://bugs.webkit.org/show_bug.cgi?id=118974

Reviewed by Philippe Normand.

In order to preserve the system volume we need to keep track of
the volume being initialized in the HTMLMediaElement and then just
setting the volume to the sink when initializing the pipeline if
that volume was changed before.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialized
attribute to false.
(WebCore::HTMLMediaElement::setVolume): Set the attribute to true
when volume is changed.
(WebCore::HTMLMediaElement::updateVolume): Set the volume only if
volume was initialized.
(WebCore::HTMLMediaElement::mediaPlayerPlatformVolumeConfigurationRequired):
Platform volume configuration is required only if volume was not
initialized before.
* html/HTMLMediaElement.h: Added attribute and interface method.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerPlatformVolumeConfigurationRequired):
Declared and added default implementation for the interface method.
(WebCore::MediaPlayer::platformVolumeConfigurationRequired):
Asked the client, meaning the HTMLMediaElement if the platform
volume configuration is required.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::mediaPlayerPrivateVolumeChangedCallback): Added log.
(WebCore::MediaPlayerPrivateGStreamerBase::setVolume): Added log.
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
Set the volume only if not platform volume is required and added log.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154969 => 154970)

--- trunk/Source/WebCore/ChangeLog	2013-09-03 06:06:49 UTC (rev 154969)
+++ trunk/Source/WebCore/ChangeLog	2013-09-03 07:16:02 UTC (rev 154970)
@@ -1,3 +1,38 @@
+2013-09-03  Xabier Rodriguez Calvar  calva...@igalia.com
+
+[GStreamer] Video player sets system volume to 100%
+https://bugs.webkit.org/show_bug.cgi?id=118974
+
+Reviewed by Philippe Normand.
+
+In order to preserve the system volume we need to keep track of
+the volume being initialized in the HTMLMediaElement and then just
+setting the volume to the sink when initializing the pipeline if
+that volume was changed before.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::HTMLMediaElement): Initialized
+attribute to false.
+(WebCore::HTMLMediaElement::setVolume): Set the attribute to true
+when volume is changed.
+(WebCore::HTMLMediaElement::updateVolume): Set the volume only if
+volume was initialized.
+(WebCore::HTMLMediaElement::mediaPlayerPlatformVolumeConfigurationRequired):
+Platform volume configuration is required only if volume was not
+initialized before.
+* html/HTMLMediaElement.h: Added attribute and interface method.
+* platform/graphics/MediaPlayer.h:
+(WebCore::MediaPlayerClient::mediaPlayerPlatformVolumeConfigurationRequired):
+Declared and added default implementation for the interface method.
+(WebCore::MediaPlayer::platformVolumeConfigurationRequired):
+Asked the client, meaning the HTMLMediaElement if the platform
+volume configuration is required.
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::mediaPlayerPrivateVolumeChangedCallback): Added log.
+(WebCore::MediaPlayerPrivateGStreamerBase::setVolume): Added log.
+(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
+Set the volume only if not platform volume is required and added log.
+
 2013-09-02  Darin Adler  da...@apple.com
 
 * inspector/InspectorProfilerAgent.cpp:


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (154969 => 154970)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2013-09-03 06:06:49 UTC (rev 154969)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2013-09-03 07:16:02 UTC (rev 154970)
@@ -267,6 +267,7 @@
 , m_readyState(HAVE_NOTHING)
 , m_readyStateMaximum(HAVE_NOTHING)
 , m_volume(1.0f)
+, m_volumeInitialized(false)
 , m_lastSeekTime(0)
 , m_previousProgressTime(numeric_limitsdouble::max())
 , m_clockTimeAtLastUpdateEvent(0)
@@ -2708,6 +2709,7 @@
 
 if (m_volume != vol) {
 m_volume = vol;
+m_volumeInitialized = true;
 updateVolume();
 scheduleEvent(eventNames().volumechangeEvent);
 }
@@ -3978,7 +3980,8 @@
 }
 
 m_player-setMuted(shouldMute);
-

[webkit-changes] [154971] trunk/Source/WebCore

[anilsson]

Title: [154971] trunk/Source/WebCore








Revision 154971
Author anils...@rim.com
Date 2013-09-03 00:29:18 -0700 (Tue, 03 Sep 2013)


Log Message
[BlackBerry] Remove LayerData::LayerProgram
https://bugs.webkit.org/show_bug.cgi?id=120601

Reviewed by Anders Carlsson.

JIRA 490672
All layer contents are RGBA now, so there's no need to support BGRA any
more and the LayerData::LayerProgram enum can be removed. Related dead
code was removed.

No new tests, no change in behavior.

* platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
(WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
* platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::LayerData):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::createProgram):
* platform/graphics/blackberry/LayerRenderer.h:
* platform/graphics/blackberry/LayerWebKitThread.h:
* platform/graphics/blackberry/PluginLayerWebKitThread.cpp:
(WebCore::PluginLayerWebKitThread::setPluginView):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp
trunk/Source/WebCore/platform/graphics/blackberry/LayerData.h
trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp
trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.h
trunk/Source/WebCore/platform/graphics/blackberry/LayerWebKitThread.h
trunk/Source/WebCore/platform/graphics/blackberry/PluginLayerWebKitThread.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154970 => 154971)

--- trunk/Source/WebCore/ChangeLog	2013-09-03 07:16:02 UTC (rev 154970)
+++ trunk/Source/WebCore/ChangeLog	2013-09-03 07:29:18 UTC (rev 154971)
@@ -1,3 +1,29 @@
+2013-09-03  Arvid Nilsson  anils...@rim.com
+
+[BlackBerry] Remove LayerData::LayerProgram
+https://bugs.webkit.org/show_bug.cgi?id=120601
+
+Reviewed by Anders Carlsson.
+
+JIRA 490672
+All layer contents are RGBA now, so there's no need to support BGRA any
+more and the LayerData::LayerProgram enum can be removed. Related dead
+code was removed.
+
+No new tests, no change in behavior.
+
+* platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
+(WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
+* platform/graphics/blackberry/LayerData.h:
+(WebCore::LayerData::LayerData):
+* platform/graphics/blackberry/LayerRenderer.cpp:
+(WebCore::LayerRenderer::compositeLayersRecursive):
+(WebCore::LayerRenderer::createProgram):
+* platform/graphics/blackberry/LayerRenderer.h:
+* platform/graphics/blackberry/LayerWebKitThread.h:
+* platform/graphics/blackberry/PluginLayerWebKitThread.cpp:
+(WebCore::PluginLayerWebKitThread::setPluginView):
+
 2013-09-03  Xabier Rodriguez Calvar  calva...@igalia.com
 
 [GStreamer] Video player sets system volume to 100%


Modified: trunk/Source/WebCore/platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp (154970 => 154971)

--- trunk/Source/WebCore/platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp	2013-09-03 07:16:02 UTC (rev 154970)
+++ trunk/Source/WebCore/platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp	2013-09-03 07:29:18 UTC (rev 154971)
@@ -45,7 +45,6 @@
 , m_textureAccessor(0)
 {
 layerCompositingThread()-setClient(m_client.get());
-setLayerProgram(LayerProgramRGBA);
 }
 
 EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread()


Modified: trunk/Source/WebCore/platform/graphics/blackberry/LayerData.h (154970 => 154971)

--- trunk/Source/WebCore/platform/graphics/blackberry/LayerData.h	2013-09-03 07:16:02 UTC (rev 154970)
+++ trunk/Source/WebCore/platform/graphics/blackberry/LayerData.h	2013-09-03 07:29:18 UTC (rev 154971)
@@ -56,11 +56,6 @@
 public:
 enum LayerType { Layer, TransformLayer, WebGLLayer, CanvasLayer, CustomLayer };
 enum FilterType { Linear, Nearest, Trilinear, Lanczos };
-enum LayerProgram {
-LayerProgramRGBA = 0,
-LayerProgramBGRA,
-NumberOfLayerPrograms
-};
 
 #if ENABLE(CSS_FILTERS)
 enum CSSFilterShaders {
@@ -91,7 +86,6 @@
 , m_opacity(1.0)
 , m_anchorPointZ(0.0)
 , m_borderWidth(0.0)
-, m_layerProgram(LayerProgramBGRA)
 , m_pluginView(0)
 #if ENABLE(VIDEO)
 , m_mediaPlayer(0)
@@ -159,8 +153,6 @@
 
 bool needsTexture() const { return m_layerType == WebGLLayer || m_layerType == CanvasLayer || m_needsTexture; }
 
-LayerProgram layerProgram() const { return m_layerProgram; }
-
 bool isFixedPosition() const { return m_isFixedPosition; }
 bool hasFixedContainer() const { return m_hasFixedContainer; }
 bool hasFixedAncestorInDOMTree() const { return m_hasFixedAncestorInDOMTree; }
@@ -219,8 +211,6 @@
 float m_anchorPointZ;
 float m_borderWidth;
 
-LayerProgram m_layerProgram;
-
 PluginView* m_pluginView;
 #if 

[webkit-changes] [154974] trunk

[allan . jensen]

Title: [154974] trunk








Revision 154974
Author allan.jen...@digia.com
Date 2013-09-03 01:54:26 -0700 (Tue, 03 Sep 2013)


Log Message
[Qt][WK1] PageVisibility tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=120418

Reviewed by Jocelyn Turcotte.

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetPageVisibility):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Implement resetPageVisibility so we can reset visibility without
emiting visibility state change events.

* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::resetPageVisibility):

Modified Paths

trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp




Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (154973 => 154974)

--- trunk/Source/WebKit/qt/ChangeLog	2013-09-03 08:21:16 UTC (rev 154973)
+++ trunk/Source/WebKit/qt/ChangeLog	2013-09-03 08:54:26 UTC (rev 154974)
@@ -1,3 +1,14 @@
+2013-09-03  Allan Sandfeld Jensen  allan.jen...@digia.com
+
+[Qt][WK1] PageVisibility tests are flaky
+https://bugs.webkit.org/show_bug.cgi?id=120418
+
+Reviewed by Jocelyn Turcotte.
+
+* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
+(DumpRenderTreeSupportQt::resetPageVisibility):
+* WebCoreSupport/DumpRenderTreeSupportQt.h:
+
 2013-08-28  Zeno Albisser  z...@webkit.org
 
 [Qt] Option key combinations do not work in Input Elements.


Modified: trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp (154973 => 154974)

--- trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp	2013-09-03 08:21:16 UTC (rev 154973)
+++ trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp	2013-09-03 08:54:26 UTC (rev 154974)
@@ -893,6 +893,16 @@
 WebCore::Font::setDefaultTypesettingFeatures(0);
 }
 
+void DumpRenderTreeSupportQt::resetPageVisibility(QWebPageAdapter* adapter)
+{
+#if ENABLE(PAGE_VISIBILITY_API)
+// Set visibility without emitting an event.
+adapter-page-setVisibilityState(PageVisibilityStateVisible, true);
+#else
+UNUSED_PARAM(adapter);
+#endif
+}
+
 void DumpRenderTreeSupportQt::getJSWindowObject(QWebFrameAdapter* adapter, JSContextRef* context, JSObjectRef* object)
 {
 JSDOMWindow* window = toJSDOMWindow(adapter-frame, mainThreadNormalWorld());


Modified: trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h (154973 => 154974)

--- trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h	2013-09-03 08:21:16 UTC (rev 154973)
+++ trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h	2013-09-03 08:54:26 UTC (rev 154974)
@@ -205,6 +205,7 @@
 static void clearNotificationPermissions();
 
 static void disableDefaultTypesettingFeatures();
+static void resetPageVisibility(QWebPageAdapter*);
 
 static void getJSWindowObject(QWebFrameAdapter*, JSContextRef*, JSObjectRef*);
 };


Modified: trunk/Tools/ChangeLog (154973 => 154974)

--- trunk/Tools/ChangeLog	2013-09-03 08:21:16 UTC (rev 154973)
+++ trunk/Tools/ChangeLog	2013-09-03 08:54:26 UTC (rev 154974)
@@ -1,3 +1,16 @@
+2013-09-03  Allan Sandfeld Jensen  allan.jen...@digia.com
+
+[Qt][WK1] PageVisibility tests are flaky
+https://bugs.webkit.org/show_bug.cgi?id=120418
+
+Reviewed by Jocelyn Turcotte.
+
+Implement resetPageVisibility so we can reset visibility without
+emiting visibility state change events.
+
+* DumpRenderTree/qt/TestRunnerQt.cpp:
+(TestRunner::resetPageVisibility):
+
 2013-09-03  ChangSeok Oh  changseok...@collabora.com
 
 [GTK] libsoup upversion to fix a gstreamer issue, bug115354


Modified: trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp (154973 => 154974)

--- trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp	2013-09-03 08:21:16 UTC (rev 154973)
+++ trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp	2013-09-03 08:54:26 UTC (rev 154974)
@@ -950,7 +950,7 @@
 
 void TestRunner::resetPageVisibility()
 {
-// No need to implement it because the visibility state is correctly initialised when the page is created.
+DumpRenderTreeSupportQt::resetPageVisibility(DumpRenderTree::instance()-pageAdapter());
 }
 
 void TestRunner::setPageVisibility(const char* visibility)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154975] trunk/Source/WebCore

[allan . jensen]

Title: [154975] trunk/Source/WebCore








Revision 154975
Author allan.jen...@digia.com
Date 2013-09-03 03:10:37 -0700 (Tue, 03 Sep 2013)


Log Message
[Qt] Remove dead code for QtXmlPatterns
https://bugs.webkit.org/show_bug.cgi?id=120624

Reviewed by Simon Hausmann.

Remove code supporting XSLT using QtXmlPatterns which has been
dead for some time.

* Target.pri:
* WebCore.pri:
* dom/TransformSourceQt.cpp: Removed.
* xml/XSLStyleSheetQt.cpp: Removed.
* xml/XSLTProcessorQt.cpp: Removed.
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::parseProcessingInstruction):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.pri
trunk/Source/WebCore/xml/parser/XMLDocumentParserQt.cpp


Removed Paths

trunk/Source/WebCore/dom/TransformSourceQt.cpp
trunk/Source/WebCore/xml/XSLStyleSheetQt.cpp
trunk/Source/WebCore/xml/XSLTProcessorQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154974 => 154975)

--- trunk/Source/WebCore/ChangeLog	2013-09-03 08:54:26 UTC (rev 154974)
+++ trunk/Source/WebCore/ChangeLog	2013-09-03 10:10:37 UTC (rev 154975)
@@ -1,3 +1,22 @@
+2013-09-03  Allan Sandfeld Jensen  allan.jen...@digia.com
+
+[Qt] Remove dead code for QtXmlPatterns
+https://bugs.webkit.org/show_bug.cgi?id=120624
+
+Reviewed by Simon Hausmann.
+
+Remove code supporting XSLT using QtXmlPatterns which has been
+dead for some time.
+
+* Target.pri:
+* WebCore.pri:
+* dom/TransformSourceQt.cpp: Removed.
+* xml/XSLStyleSheetQt.cpp: Removed.
+* xml/XSLTProcessorQt.cpp: Removed.
+* xml/parser/XMLDocumentParserQt.cpp:
+(WebCore::XMLDocumentParser::doEnd):
+(WebCore::XMLDocumentParser::parseProcessingInstruction):
+
 2013-09-03  Mihnea Ovidenie  mih...@adobe.com
 
 [CSS Regions] position: fixed is computed relative to the first region, not the viewport


Modified: trunk/Source/WebCore/Target.pri (154974 => 154975)

--- trunk/Source/WebCore/Target.pri	2013-09-03 08:54:26 UTC (rev 154974)
+++ trunk/Source/WebCore/Target.pri	2013-09-03 10:10:37 UTC (rev 154975)
@@ -3572,12 +3572,6 @@
 xml/XSLImportRule.h \
 xml/XSLTUnicodeSort.h
 
-} else {
-SOURCES += \
-dom/TransformSourceQt.cpp \
-xml/XSLStyleSheetQt.cpp \
-xml/XSLTProcessor.cpp \
-xml/XSLTProcessorQt.cpp
 }
 }
 


Modified: trunk/Source/WebCore/WebCore.pri (154974 => 154975)

--- trunk/Source/WebCore/WebCore.pri	2013-09-03 08:54:26 UTC (rev 154974)
+++ trunk/Source/WebCore/WebCore.pri	2013-09-03 10:10:37 UTC (rev 154975)
@@ -110,19 +110,22 @@
 
 INCLUDEPATH += $$WEBCORE_GENERATED_SOURCES_DIR
 
+use?(LIBXML2) {
+mac {
+INCLUDEPATH += /usr/include/libxml2
+LIBS += -lxml2
+} else {
+PKGCONFIG += libxml-2.0
+}
+}
+
 enable?(XSLT) {
-use?(LIBXML2) {
-mac {
-INCLUDEPATH += /usr/include/libxslt /usr/include/libxml2
-LIBS += -lxml2 -lxslt
-} else {
-PKGCONFIG += libxslt libxml-2.0
-}
+mac {
+INCLUDEPATH += /usr/include/libxslt
+LIBS += -lxslt
 } else {
-QT *= xmlpatterns
+PKGCONFIG += libxslt
 }
-} else:!mac:use?(LIBXML2) {
-PKGCONFIG += libxml-2.0
 }
 
 use?(ZLIB) {


Deleted: trunk/Source/WebCore/dom/TransformSourceQt.cpp (154974 => 154975)

--- trunk/Source/WebCore/dom/TransformSourceQt.cpp	2013-09-03 08:54:26 UTC (rev 154974)
+++ trunk/Source/WebCore/dom/TransformSourceQt.cpp	2013-09-03 10:10:37 UTC (rev 154975)
@@ -1,34 +0,0 @@
-/*
- * Copyright (C) 2009 Jakub Wieczorek faw...@gmail.com
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#include config.h
-#include TransformSource.h
-
-namespace WebCore {
-
-TransformSource::TransformSource(const PlatformTransformSource source)
-: m_source(source)
-{
-}
-
-TransformSource::~TransformSource()
-{
-}
-
-}


Deleted: trunk/Source/WebCore/xml/XSLStyleSheetQt.cpp (154974 => 154975)

--- trunk/Source/WebCore/xml/XSLStyleSheetQt.cpp	2013-09-03 08:54:26 UTC (rev 154974)
+++ trunk/Source/WebCore/xml/XSLStyleSheetQt.cpp	2013-09-03 10:10:37 UTC 

[webkit-changes] [154976] trunk

[commit-queue]

Title: [154976] trunk








Revision 154976
Author commit-qu...@webkit.org
Date 2013-09-03 04:29:33 -0700 (Tue, 03 Sep 2013)


Log Message
Source/WebCore: [AX][ATK] Added support for sort and help attributes.
https://bugs.webkit.org/show_bug.cgi?id=120456

Patch by Krzysztof Czech k.cz...@samsung.com on 2013-09-03
Reviewed by Chris Fleizach.

Added support for aria-sort and aria-help attributes.

Test: accessibility/aria-sort.html

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):

Tools: [AX][ATK] Added support for sort and help attributes
https://bugs.webkit.org/show_bug.cgi?id=120456

Patch by Krzysztof Czech k.cz...@samsung.com on 2013-09-03
Reviewed by Chris Fleizach.

Added missing implementation to AccessibilityUIElement::helpText and support for
aria-sort attribute.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(coreAttributeToAtkAttribute):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::coreAttributeToAtkAttribute):
(WTR::AccessibilityUIElement::helpText):

LayoutTests: [AX][ATK] Added support for sort and help attributes
https://bugs.webkit.org/show_bug.cgi?id=120456

Patch by Krzysztof Czech k.cz...@samsung.com on 2013-09-03
Reviewed by Chris Fleizach.

Sharing aria-sort.html specific mac test with efl and gtk.
Changing specific expectations of some accessibility tests.

* accessibility/aria-sort-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-sort-expected.txt.
* accessibility/aria-sort.html: Renamed from LayoutTests/platform/mac/accessibility/aria-sort.html.
* platform/efl-wk2/TestExpectations:
* platform/efl-wk2/accessibility/image-link-expected.txt:
* platform/efl-wk2/accessibility/image-map2-expected.txt:
* platform/efl-wk2/accessibility/table-cell-spans-expected.txt:
* platform/efl-wk2/accessibility/table-cells-expected.txt:
* platform/gtk/accessibility/image-link-expected.txt:
* platform/gtk/accessibility/image-map2-expected.txt:
* platform/gtk/accessibility/table-cell-spans-expected.txt:
* platform/gtk/accessibility/table-cells-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations
trunk/LayoutTests/platform/efl-wk2/accessibility/image-link-expected.txt
trunk/LayoutTests/platform/efl-wk2/accessibility/image-map2-expected.txt
trunk/LayoutTests/platform/efl-wk2/accessibility/table-cell-spans-expected.txt
trunk/LayoutTests/platform/efl-wk2/accessibility/table-cells-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/image-link-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/table-cell-spans-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/table-cells-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp


Added Paths

trunk/LayoutTests/accessibility/aria-sort-expected.txt
trunk/LayoutTests/accessibility/aria-sort.html


Removed Paths

trunk/LayoutTests/platform/mac/accessibility/aria-sort-expected.txt
trunk/LayoutTests/platform/mac/accessibility/aria-sort.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154975 => 154976)

--- trunk/LayoutTests/ChangeLog	2013-09-03 10:10:37 UTC (rev 154975)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 11:29:33 UTC (rev 154976)
@@ -1,3 +1,25 @@
+2013-09-03  Krzysztof Czech  k.cz...@samsung.com
+
+[AX][ATK] Added support for sort and help attributes
+https://bugs.webkit.org/show_bug.cgi?id=120456
+
+Reviewed by Chris Fleizach.
+
+Sharing aria-sort.html specific mac test with efl and gtk.
+Changing specific expectations of some accessibility tests.
+
+* accessibility/aria-sort-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-sort-expected.txt.
+* accessibility/aria-sort.html: Renamed from LayoutTests/platform/mac/accessibility/aria-sort.html.
+* platform/efl-wk2/TestExpectations:
+* platform/efl-wk2/accessibility/image-link-expected.txt:
+* platform/efl-wk2/accessibility/image-map2-expected.txt:
+* platform/efl-wk2/accessibility/table-cell-spans-expected.txt:
+* platform/efl-wk2/accessibility/table-cells-expected.txt:
+* platform/gtk/accessibility/image-link-expected.txt:
+* platform/gtk/accessibility/image-map2-expected.txt:
+* platform/gtk/accessibility/table-cell-spans-expected.txt:
+* platform/gtk/accessibility/table-cells-expected.txt:
+
 2013-09-03  Mihnea Ovidenie  mih...@adobe.com
 
 [CSS Regions] position: fixed is computed relative to the first region, not the viewport


Copied: trunk/LayoutTests/accessibility/aria-sort-expected.txt (from rev 154975, trunk/LayoutTests/platform/mac/accessibility/aria-sort-expected.txt) (0 => 154976)

[webkit-changes] [154977] trunk

[commit-queue]

Title: [154977] trunk








Revision 154977
Author commit-qu...@webkit.org
Date 2013-09-03 06:16:54 -0700 (Tue, 03 Sep 2013)


Log Message
[gstreamer] Disable HTTP request Accept-Encoding: header field on gstreamer source element to avoid receiving the wrong size when retrieving data
https://bugs.webkit.org/show_bug.cgi?id=115354

Patch by Andre Moreira Magalhaes andre.magalh...@collabora.co.uk on 2013-09-03
Reviewed by Philippe Normand.

Source/WebCore:

Also disable Accept-Encoding on ResourceRequest::toSoupMessage accordingly.

* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::toSoupMessage):
Call ResourceRequest::updateSoupMessage from ResourceRequest::toSoupMessage so that the
Accept-Encoding header is also respected.

LayoutTests:

Add test to check that video requests will send no Accept-Encoding header.

* http/tests/media/video-accept-encoding-expected.txt: Added.
* http/tests/media/video-accept-encoding.cgi: Added.
* http/tests/media/video-accept-encoding.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp


Added Paths

trunk/LayoutTests/http/tests/media/video-accept-encoding-expected.txt
trunk/LayoutTests/http/tests/media/video-accept-encoding.cgi
trunk/LayoutTests/http/tests/media/video-accept-encoding.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154976 => 154977)

--- trunk/LayoutTests/ChangeLog	2013-09-03 11:29:33 UTC (rev 154976)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 13:16:54 UTC (rev 154977)
@@ -1,3 +1,16 @@
+2013-09-03  Andre Moreira Magalhaes   andre.magalh...@collabora.co.uk
+
+[gstreamer] Disable HTTP request Accept-Encoding: header field on gstreamer source element to avoid receiving the wrong size when retrieving data
+https://bugs.webkit.org/show_bug.cgi?id=115354
+
+Reviewed by Philippe Normand.
+
+Add test to check that video requests will send no Accept-Encoding header.
+
+* http/tests/media/video-accept-encoding-expected.txt: Added.
+* http/tests/media/video-accept-encoding.cgi: Added.
+* http/tests/media/video-accept-encoding.html: Added.
+
 2013-09-03  Krzysztof Czech  k.cz...@samsung.com
 
 [AX][ATK] Added support for sort and help attributes


Added: trunk/LayoutTests/http/tests/media/video-accept-encoding-expected.txt (0 => 154977)

--- trunk/LayoutTests/http/tests/media/video-accept-encoding-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/media/video-accept-encoding-expected.txt	2013-09-03 13:16:54 UTC (rev 154977)
@@ -0,0 +1,6 @@
+Test that video requests contain no Accept-Encoding header.
+
+EVENT(loadedmetadata)
+loaded metadata of media file OK
+END OF TEST
+


Added: trunk/LayoutTests/http/tests/media/video-accept-encoding.cgi (0 => 154977)

--- trunk/LayoutTests/http/tests/media/video-accept-encoding.cgi	(rev 0)
+++ trunk/LayoutTests/http/tests/media/video-accept-encoding.cgi	2013-09-03 13:16:54 UTC (rev 154977)
@@ -0,0 +1,86 @@
+#!/usr/bin/perl -w
+
+use strict;
+
+use CGI;
+use File::stat;
+
+use constant CHUNK_SIZE_BYTES = 1024;
+
+my $query = new CGI;
+
+my $name = $query-param('name') or die;
+my $filesize = stat($name)-size;
+
+# Get MIME type.
+my $type = $query-param('type') or die;
+
+# Get throttling rate, assuming parameter is in kilobytes per second.
+my $kbPerSec = $query-param('throttle') || 0;
+my $chunkPerSec = $kbPerSec * 1024 / CHUNK_SIZE_BYTES;
+
+CGI-nph(1);
+
+my $contentRange = $ENV{'HTTP_RANGE'};
+
+my $rangeEnd = $filesize - 1;
+my @parsedRange = (0, $rangeEnd);
+
+my $acceptEncoding = $ENV{'HTTP_ACCEPT_ENCODING'};
+
+my $httpStatus;
+
+if ($acceptEncoding) {
+$httpStatus = 406 Not Acceptable;
+
+print Status:  . $httpStatus . \n;
+print Connection: close\n;
+print \n;
+} else {
+my $httpContentRange;
+if ($contentRange) {
+my @values = split('=', $contentRange);
+my $rangeType = $values[0];
+@parsedRange = split(-, $values[1]);
+
+if (!$parsedRange[1]) {
+$parsedRange[1] = $rangeEnd;
+}
+$httpStatus = 206 Partial Content;
+$httpContentRange = bytes  . $parsedRange[0] . - . $parsedRange[1] . / . $filesize;
+} else {
+$httpStatus = 200 OK;
+}
+
+print Status:  . $httpStatus . \n;
+print Connection: close\n;
+print Content-Length:  . $filesize . \n;
+print Content-Type:  . $type . \n;
+print Accept-Ranges: bytes\n;
+if ($httpContentRange) {
+print Content-Range:  . $httpContentRange . \n;
+}
+print \n;
+
+open FILE, $name or die;
+binmode FILE;
+my ($data, $n);
+my $total = $parsedRange[0];
+
+seek(FILE, $parsedRange[0], 0);
+
+while (($n = read FILE, $data, 1024) != 0) {
+print $data;
+
+$total += $n;
+if (($total = $filesize) || ($total  $parsedRange[1])) {
+last;
+}
+
+  

[webkit-changes] [154978] trunk

[paroga]

Title: [154978] trunk








Revision 154978
Author par...@webkit.org
Date 2013-09-03 06:25:14 -0700 (Tue, 03 Sep 2013)


Log Message
[CMake] Fix detection of x86_64 platform with MSVC
https://bugs.webkit.org/show_bug.cgi?id=116662

Reviewed by Gyuyoung Kim.

Use ${MSVC_CXX_ARCHITECTURE_ID} instead of ${CMAKE_SYSTEM_PROCESSOR}, since
the later one just resolves to the host processor on Windows.

* CMakeLists.txt:

Modified Paths

trunk/CMakeLists.txt
trunk/ChangeLog




Diff

Modified: trunk/CMakeLists.txt (154977 => 154978)

--- trunk/CMakeLists.txt	2013-09-03 13:16:54 UTC (rev 154977)
+++ trunk/CMakeLists.txt	2013-09-03 13:25:14 UTC (rev 154978)
@@ -67,17 +67,23 @@
 # -
 # Determine the target processor
 # -
-string(TOLOWER ${CMAKE_SYSTEM_PROCESSOR} LOWERCASE_CMAKE_SYSTEM_PROCESSOR)
+# Use MSVC_CXX_ARCHITECTURE_ID instead of CMAKE_SYSTEM_PROCESSOR when defined,
+# since the later one just resolves to the host processor on Windows.
+if (MSVC_CXX_ARCHITECTURE_ID)
+string(TOLOWER ${MSVC_CXX_ARCHITECTURE_ID} LOWERCASE_CMAKE_SYSTEM_PROCESSOR)
+else ()
+string(TOLOWER ${CMAKE_SYSTEM_PROCESSOR} LOWERCASE_CMAKE_SYSTEM_PROCESSOR)
+endif ()
 if (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES ^arm)
 set(WTF_CPU_ARM 1)
 elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES ^mips)
 set(WTF_CPU_MIPS 1)
-elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES (x86_64|amd64))
+elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES (x64|x86_64|amd64))
 set(WTF_CPU_X86_64 1)
 elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES (i[3-6]86|x86))
 set(WTF_CPU_X86 1)
 else ()
-message(FATAL_ERROR Unknown CPU '${CMAKE_SYSTEM_PROCESSOR}')
+message(FATAL_ERROR Unknown CPU '${LOWERCASE_CMAKE_SYSTEM_PROCESSOR}')
 endif ()
 
 # -


Modified: trunk/ChangeLog (154977 => 154978)

--- trunk/ChangeLog	2013-09-03 13:16:54 UTC (rev 154977)
+++ trunk/ChangeLog	2013-09-03 13:25:14 UTC (rev 154978)
@@ -1,3 +1,15 @@
+2013-09-03  Patrick Gansterer  par...@webkit.org
+
+[CMake] Fix detection of x86_64 platform with MSVC
+https://bugs.webkit.org/show_bug.cgi?id=116662
+
+Reviewed by Gyuyoung Kim.
+
+Use ${MSVC_CXX_ARCHITECTURE_ID} instead of ${CMAKE_SYSTEM_PROCESSOR}, since
+the later one just resolves to the host processor on Windows.
+
+* CMakeLists.txt:
+
 2013-08-29  Sam Weinig  s...@webkit.org
 
 Add ENABLE guards for Promises






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154979] trunk/LayoutTests

[commit-queue]

Title: [154979] trunk/LayoutTests








Revision 154979
Author commit-qu...@webkit.org
Date 2013-09-03 06:25:23 -0700 (Tue, 03 Sep 2013)


Log Message
[EFL] accessibility/aria-describedby-on-input.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112027

Unreviewed EFL gardening.

accessibility/aria-describedby-on-input.html passes after r154976.

Patch by Krzysztof Czech k.cz...@samsung.com on 2013-09-03

* platform/efl-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (154978 => 154979)

--- trunk/LayoutTests/ChangeLog	2013-09-03 13:25:14 UTC (rev 154978)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 13:25:23 UTC (rev 154979)
@@ -1,3 +1,14 @@
+2013-09-03  Krzysztof Czech  k.cz...@samsung.com
+
+[EFL] accessibility/aria-describedby-on-input.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=112027
+
+Unreviewed EFL gardening.
+
+accessibility/aria-describedby-on-input.html passes after r154976.
+
+* platform/efl-wk2/TestExpectations:
+
 2013-09-03  Andre Moreira Magalhaes   andre.magalh...@collabora.co.uk
 
 [gstreamer] Disable HTTP request Accept-Encoding: header field on gstreamer source element to avoid receiving the wrong size when retrieving data


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (154978 => 154979)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-09-03 13:25:14 UTC (rev 154978)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-09-03 13:25:23 UTC (rev 154979)
@@ -216,7 +216,6 @@
 #
 
 # Missing EFL's accessibility functions
-webkit.org/b/112027 accessibility/aria-describedby-on-input.html [ Failure ]
 webkit.org/b/111984 accessibility/aria-hidden-updates-alldescendants.html [ Failure ]
 webkit.org/b/111986 accessibility/aria-invalid.html [ Failure ]
 webkit.org/b/111987 accessibility/aria-link-supports-press.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154981] trunk/Source/WebCore

[zandobersek]

Title: [154981] trunk/Source/WebCore








Revision 154981
Author zandober...@gmail.com
Date 2013-09-03 07:20:59 -0700 (Tue, 03 Sep 2013)


Log Message
REGRESSION(r154967): http appcache tests crashing on WK1
https://bugs.webkit.org/show_bug.cgi?id=120620

Reviewed by Andreas Kling.

* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::cacheDestroyed): Reintroduce pre-r154967 behavior that returned early in
this method if the passed-in ApplicationCache object was not found in the ApplicationCacheGroup's HashSet
of all the caches. This is now done by checking that the HashSetT::remove(T) returns true (meaning the
object was found in the HashSet and removed from it) in addition to that HashSet being subsequently empty
before the method moves on to destroying its ApplicationCacheGroup instance.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154980 => 154981)

--- trunk/Source/WebCore/ChangeLog	2013-09-03 13:36:17 UTC (rev 154980)
+++ trunk/Source/WebCore/ChangeLog	2013-09-03 14:20:59 UTC (rev 154981)
@@ -1,3 +1,17 @@
+2013-09-03  Zan Dobersek  zdober...@igalia.com
+
+REGRESSION(r154967): http appcache tests crashing on WK1
+https://bugs.webkit.org/show_bug.cgi?id=120620
+
+Reviewed by Andreas Kling.
+
+* loader/appcache/ApplicationCacheGroup.cpp:
+(WebCore::ApplicationCacheGroup::cacheDestroyed): Reintroduce pre-r154967 behavior that returned early in
+this method if the passed-in ApplicationCache object was not found in the ApplicationCacheGroup's HashSet
+of all the caches. This is now done by checking that the HashSetT::remove(T) returns true (meaning the
+object was found in the HashSet and removed from it) in addition to that HashSet being subsequently empty
+before the method moves on to destroying its ApplicationCacheGroup instance.
+
 2013-09-03  Andre Moreira Magalhaes   andre.magalh...@collabora.co.uk
 
 [gstreamer] Disable HTTP request Accept-Encoding: header field on gstreamer source element to avoid receiving the wrong size when retrieving data


Modified: trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp (154980 => 154981)

--- trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp	2013-09-03 13:36:17 UTC (rev 154980)
+++ trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp	2013-09-03 14:20:59 UTC (rev 154981)
@@ -387,8 +387,7 @@
 
 void ApplicationCacheGroup::cacheDestroyed(ApplicationCache* cache)
 {
-m_caches.remove(cache);
-if (m_caches.isEmpty()) {
+if (m_caches.remove(cache)  m_caches.isEmpty()) {
 ASSERT(m_associatedDocumentLoaders.isEmpty());
 ASSERT(m_pendingMasterResourceLoaders.isEmpty());
 delete this;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154989] trunk/Source/WebKit2

[commit-queue]

Title: [154989] trunk/Source/WebKit2








Revision 154989
Author commit-qu...@webkit.org
Date 2013-09-03 10:08:13 -0700 (Tue, 03 Sep 2013)


Log Message
[GTK] gdk threads deprecated functions calls should be refactored
https://bugs.webkit.org/show_bug.cgi?id=120070

Patch by Anton Obzhirov a.obzhi...@samsung.com on 2013-09-03
Reviewed by Mario Sanchez Prada.

Removed deprecated functions gdk_threads_leave()/gdk_threads_enter() functions since
there is no more checks for threads lock in GTK 3.6.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewRunAsModal):
* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (154988 => 154989)

--- trunk/Source/WebKit2/ChangeLog	2013-09-03 16:51:19 UTC (rev 154988)
+++ trunk/Source/WebKit2/ChangeLog	2013-09-03 17:08:13 UTC (rev 154989)
@@ -1,3 +1,18 @@
+2013-09-03  Anton Obzhirov  a.obzhi...@samsung.com
+
+[GTK] gdk threads deprecated functions calls should be refactored
+https://bugs.webkit.org/show_bug.cgi?id=120070
+
+Reviewed by Mario Sanchez Prada.
+
+Removed deprecated functions gdk_threads_leave()/gdk_threads_enter() functions since
+there is no more checks for threads lock in GTK 3.6.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewRunAsModal):
+* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
+(WebKit::WebPopupMenuProxyGtk::showPopupMenu):
+
 2013-09-03  Brian Holt  brian.h...@samsung.com
 
 [GTK] [WK2] TestContextMenu default-menu fails


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (154988 => 154989)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2013-09-03 16:51:19 UTC (rev 154988)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2013-09-03 17:08:13 UTC (rev 154989)
@@ -1560,9 +1560,7 @@
 g_signal_emit(webView, signals[RUN_AS_MODAL], 0, NULL);
 
 webView-priv-modalLoop = adoptGRef(g_main_loop_new(0, FALSE));
-gdk_threads_leave();
 g_main_loop_run(webView-priv-modalLoop.get());
-gdk_threads_enter();
 }
 
 void webkitWebViewClosePage(WebKitWebView* webView)


Modified: trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp (154988 => 154989)

--- trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp	2013-09-03 16:51:19 UTC (rev 154988)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp	2013-09-03 17:08:13 UTC (rev 154989)
@@ -97,9 +97,7 @@
 // menu right after calling WebPopupMenuProxy::showPopupMenu().
 m_runLoop = adoptGRef(g_main_loop_new(0, FALSE));
 
-gdk_threads_leave();
 g_main_loop_run(m_runLoop.get());
-gdk_threads_enter();
 
 m_runLoop.clear();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154998] trunk

[graouts]

Title: [154998] trunk








Revision 154998
Author grao...@apple.com
Date 2013-09-03 13:16:29 -0700 (Tue, 03 Sep 2013)


Log Message
Web Inspector: exceptions triggered from console evaluation do not pause the debugger
https://bugs.webkit.org/show_bug.cgi?id=120460

Source/WebCore:

Reviewed by Timothy Hatcher.

* inspector/InjectedScriptSource.js:
Explicitly set a sourceURL such that the frontend may identify injected script when
processing call frames in order to hide such code from the debugger.

Source/WebInspectorUI:

We used to preclude any debugging from errors stemming from code evaluated in the console
as we would always set the doNotPauseOnExceptionsAndMuteConsole parameter to false when
calling _javascript_LogViewController._evaluateInInspectedWindow(). However, it is desirable
to allow debugging code ran from the console.

We now allow debugging in such a scenario and we filter out call frames coming from the
Web Inspector injected script as well as the call frame for the console prompt such that
we only pause in the debugger in case the exception is in code under the console prompt
and not the console code prompt itself.

Additionally, to prevent stepping out to call frames we may have filtered out, we disable
the step out button in cases where there are no further frames in the frontend to go out to.

Reviewed by Timothy Hatcher.

* UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.debuggerDidPause):
Filter out call frames that have a URL coming from Web Inspector injected script by looking
for a URL starting with the __WebInspector prefix. If we determine that there are no call
frames left after filtering, we resume code evaluation such that we only pause in the debugger
when the exception is in code evluated under the console prompt.

* UserInterface/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerActiveCallFrameDidChange):
Monitor any change to the active call frame such that we may tie the state of the
step out button to the availability of a call frame to step out to in the filtered
list set on the DebuggerManager.

* UserInterface/_javascript_LogViewController.js:
(WebInspector._javascript_LogViewController.prototype.consolePromptTextCommitted):
Set the doNotPauseOnExceptionsAndMuteConsole to false when calling _evaluateInInspectedWindow()
in order to allow pausing on exceptions coming from code evalued in the console. Also, explicitly
set a sourceURL for the script to evaluate such that we may identify its origin when filtering
call frames stemming from inspector code.

* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
Filter out any script resource starting with the Web Inspector-specific __WebInspector prefix
so that injected script does not show up.

LayoutTests:

Reviewed by Timothy Hatcher.

* platform/mac/inspector/console/command-line-api-expected.txt:
Take into account the addition of a sourceURL to inspector/InjectedScriptSource.js.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/inspector/console/command-line-api-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/DebuggerManager.js
trunk/Source/WebInspectorUI/UserInterface/DebuggerSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/_javascript_LogViewController.js
trunk/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js




Diff

Modified: trunk/LayoutTests/ChangeLog (154997 => 154998)

--- trunk/LayoutTests/ChangeLog	2013-09-03 19:30:20 UTC (rev 154997)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 20:16:29 UTC (rev 154998)
@@ -1,3 +1,13 @@
+2013-09-03  Antoine Quint  grao...@apple.com
+
+Web Inspector: exceptions triggered from console evaluation do not pause the debugger
+https://bugs.webkit.org/show_bug.cgi?id=120460
+
+Reviewed by Timothy Hatcher.
+
+* platform/mac/inspector/console/command-line-api-expected.txt:
+Take into account the addition of a sourceURL to inspector/InjectedScriptSource.js.
+
 2013-08-28  Sergio Villar Senin  svil...@igalia.com
 
 [CSS Grid Layout] Add parsing for named grid lines


Modified: trunk/LayoutTests/platform/mac/inspector/console/command-line-api-expected.txt (154997 => 154998)

--- trunk/LayoutTests/platform/mac/inspector/console/command-line-api-expected.txt	2013-09-03 19:30:20 UTC (rev 154997)
+++ trunk/LayoutTests/platform/mac/inspector/console/command-line-api-expected.txt	2013-09-03 20:16:29 UTC (rev 154998)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1225: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
+CONSOLE MESSAGE: line 1227: The console function $() has changed from $=getElementById(id) to 

[webkit-changes] [155001] branches/safari-537.60-branch/Source/WebKit/win

[lforschler]

Title: [155001] branches/safari-537.60-branch/Source/WebKit/win








Revision 155001
Author lforsch...@apple.com
Date 2013-09-03 15:08:49 -0700 (Tue, 03 Sep 2013)


Log Message
Merged r154759.  rdar://problem/14879679

Modified Paths

branches/safari-537.60-branch/Source/WebKit/win/ChangeLog
branches/safari-537.60-branch/Source/WebKit/win/WebView.cpp
branches/safari-537.60-branch/Source/WebKit/win/WebView.h




Diff

Modified: branches/safari-537.60-branch/Source/WebKit/win/ChangeLog (155000 => 155001)

--- branches/safari-537.60-branch/Source/WebKit/win/ChangeLog	2013-09-03 21:47:45 UTC (rev 155000)
+++ branches/safari-537.60-branch/Source/WebKit/win/ChangeLog	2013-09-03 22:08:49 UTC (rev 155001)
@@ -1,3 +1,24 @@
+2013-09-03  Lucas Forschler  lforsch...@apple.com
+
+Merge r154759
+
+2013-08-27  Brent Fulgham  bfulg...@apple.com
+
+[Windows] Loader is not properly determining supported MIME types
+https://bugs.webkit.org/show_bug.cgi?id=120383
+
+Reviewed by Eric Carlson.
+
+* WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebFrameLoaderClient::canShowMIMEType): Modify to ask WebView if it can
+display the media type. Use new helper function to avoid converting a String
+to BSTR, only to immediatly be converted from BSTR back to String.
+(WebFrameLoaderClient::canShowMIMETypeAsHTML): Ditto.
+* WebView.cpp:
+(WebView::canShowMIMEType): Move logic to a new (similarly named) helper function.
+(WebView::canShowMIMETypeAsHTML): Ditto.
+* WebView.h: Add declaration for two new helper functions.
+
 2013-08-29  Roger Fong  roger_f...@apple.com
 
 Unreviewed. Windows build fix.


Modified: branches/safari-537.60-branch/Source/WebKit/win/WebView.cpp (155000 => 155001)

--- branches/safari-537.60-branch/Source/WebKit/win/WebView.cpp	2013-09-03 21:47:45 UTC (rev 155000)
+++ branches/safari-537.60-branch/Source/WebKit/win/WebView.cpp	2013-09-03 22:08:49 UTC (rev 155001)
@@ -110,6 +110,7 @@
 #include WebCore/KeyboardEvent.h
 #include WebCore/MIMETypeRegistry.h
 #include WebCore/MemoryCache.h
+#include WebCore/NotImplemented.h
 #include WebCore/Page.h
 #include WebCore/PageCache.h
 #include WebCore/PageGroup.h
@@ -2532,39 +2533,51 @@
 
 // IWebView 
 
-HRESULT STDMETHODCALLTYPE WebView::canShowMIMEType( 
-/* [in] */ BSTR mimeType,
-/* [retval][out] */ BOOL* canShow)
+HRESULT WebView::canShowMIMEType(/* [in] */ BSTR mimeType, /* [retval][out] */ BOOL* canShow)
 {
-String mimeTypeStr = toString(mimeType);
-
 if (!canShow)
 return E_POINTER;
 
+*canShow = canShowMIMEType(toString(mimeType));
+
+return S_OK;
+}
+
+bool WebView::canShowMIMEType(const String mimeType)
+{
 Frame* coreFrame = core(m_mainFrame);
 bool allowPlugins = coreFrame  coreFrame-loader()-subframeLoader()-allowPlugins(NotAboutToInstantiatePlugin);
 
-*canShow = MIMETypeRegistry::isSupportedImageMIMEType(mimeTypeStr)
-|| MIMETypeRegistry::isSupportedNonImageMIMEType(mimeTypeStr);
+bool canShow = MIMETypeRegistry::isSupportedImageMIMEType(mimeType)
+|| MIMETypeRegistry::isSupportedNonImageMIMEType(mimeType)
+|| MIMETypeRegistry::isSupportedMediaMIMEType(mimeType);
 
-if (!*canShow  m_page  m_page-pluginData()) {
-*canShow = (m_page-pluginData()-supportsMimeType(mimeTypeStr, PluginData::AllPlugins)  allowPlugins)
-|| m_page-pluginData()-supportsMimeType(mimeTypeStr, PluginData::OnlyApplicationPlugins);
+if (!canShow  m_page  m_page-pluginData())) {
+canShow = (m_page-pluginData()-supportsMimeType(mimeType, PluginData::AllPlugins)  allowPlugins)
+|| m_page-pluginData()-supportsMimeType(mimeType, PluginData::OnlyApplicationPlugins);
 }
 
-if (!*canShow)
-*canShow = shouldUseEmbeddedView(mimeTypeStr);
+if (!canShow)
+canShow = shouldUseEmbeddedView(mimeType);
 
+return canShow;
+}
+
+HRESULT WebView::canShowMIMETypeAsHTML(/* [in] */ BSTR mimeType, /* [retval][out] */ BOOL* canShow)
+{
+if (!canShow)
+return E_POINTER;
+
+*canShow = canShowMIMETypeAsHTML(toString(mimeType));
+
 return S_OK;
 }
 
-HRESULT STDMETHODCALLTYPE WebView::canShowMIMETypeAsHTML( 
-/* [in] */ BSTR /*mimeType*/,
-/* [retval][out] */ BOOL* canShow)
+bool WebView::canShowMIMETypeAsHTML(const String /*mimeType*/)
 {
 // FIXME
-*canShow = TRUE;
-return S_OK;
+notImplemented();
+return true;
 }
 
 HRESULT STDMETHODCALLTYPE WebView::MIMETypesShownAsHTML( 


Modified: branches/safari-537.60-branch/Source/WebKit/win/WebView.h (155000 => 155001)

--- branches/safari-537.60-branch/Source/WebKit/win/WebView.h	2013-09-03 21:47:45 UTC (rev 155000)
+++ branches/safari-537.60-branch/Source/WebKit/win/WebView.h	2013-09-03 22:08:49 UTC (rev 155001)
@@ -975,6 +975,9 @@
 

[webkit-changes] [155002] trunk

[betravis]

Title: [155002] trunk








Revision 155002
Author betra...@adobe.com
Date 2013-09-03 15:14:51 -0700 (Tue, 03 Sep 2013)


Log Message
[CSS Shapes] Shape's content gets extra left offset when left-border is positive on the content box
https://bugs.webkit.org/show_bug.cgi?id=117573

Reviewed by David Hyatt.

Source/WebCore:

Nested blocks need to take into account their offset from the shape-inside container.
The new code calculates the offset from the shape-inside container, then applies the
offset to the computed segments. The line must be moved down by the offset's height,
and each segment must be moved left by the offset's width.

Test: fast/shapes/shape-inside/shape-inside-offset-block-children.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::relayoutShapeDescendantIfMoved): Relayout a block child if its
new logical left would cause it to rest at a new position within a shape container.
(WebCore::RenderBlock::logicalOffsetFromShapeAncestorContainer): Calculate the logical
offset form a shape inside ancestor container.
(WebCore::RenderBlock::layoutBlockChild): Call relayoutShapeDescendantIfMoved with the
new position offset.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Use layout offset, rather
than just vertical offset.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Ditto.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Ditto.
* rendering/shapes/ShapeInsideInfo.h:
(WebCore::ShapeInsideInfo::computeSegmentsForLine): Shift segments logically left when
there is an inline offset.

LayoutTests:

Test that nested children with padding correctly apply an ancestor's shape-inside
across different writing modes.

* fast/shapes/shape-inside/shape-inside-offset-block-children-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-offset-block-children.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/shapes/ShapeInsideInfo.h


Added Paths

trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-offset-block-children-expected.html
trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-offset-block-children.html




Diff

Modified: trunk/LayoutTests/ChangeLog (155001 => 155002)

--- trunk/LayoutTests/ChangeLog	2013-09-03 22:08:49 UTC (rev 155001)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 22:14:51 UTC (rev 155002)
@@ -1,3 +1,16 @@
+2013-09-03  Bear Travis  betra...@adobe.com
+
+[CSS Shapes] Shape's content gets extra left offset when left-border is positive on the content box
+https://bugs.webkit.org/show_bug.cgi?id=117573
+
+Reviewed by David Hyatt.
+
+Test that nested children with padding correctly apply an ancestor's shape-inside
+across different writing modes.
+
+* fast/shapes/shape-inside/shape-inside-offset-block-children-expected.html: Added.
+* fast/shapes/shape-inside/shape-inside-offset-block-children.html: Added.
+
 2013-09-03  Antoine Quint  grao...@apple.com
 
 Web Inspector: exceptions triggered from console evaluation do not pause the debugger


Added: trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-offset-block-children-expected.html (0 => 155002)

--- trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-offset-block-children-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-offset-block-children-expected.html	2013-09-03 22:14:51 UTC (rev 155002)
@@ -0,0 +1,33 @@
+!DOCTYPE html
+html
+head
+style id='stylesheet'
+.shape-inside {
+font: 50px/1 Ahem, sans-serif;
+color: green;
+float: left;
+}
+/style
+script src=''/script
+script
+ids = [
+'shape-inside',
+'shape-inside-rl',
+'shape-inside-lr',
+'shape-inside-tb-lr-tb',
+'shape-inside-lr-rl-lr'
+];
+ids.forEach(function(id) {
+drawExpectedRectangle(id, 'stylesheet', { width: 300, height: 300 }, { x: 100, y: 100, width: 100, height: 100 }, 'px', null);
+});
+/script
+/head
+body
+pThis test ensures that shape-inside takes into account padding on nested child blocks in different writing modes. You should see several green squares within a blue outline. The test requires the Ahem font./p
+div id='shape-inside' class='shape-inside'/div
+div id='shape-inside-rl' class='shape-inside'/div
+div id='shape-inside-lr' class='shape-inside'/div
+div id='shape-inside-tb-lr-tb' class='shape-inside'/div
+div id='shape-inside-lr-rl-lr' class='shape-inside'/div
+/body
+/html


Added: trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-offset-block-children.html (0 => 155002)

--- trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-offset-block-children.html	(rev 0)

[webkit-changes] [155003] branches/safari-537.60-branch/Source/WebKit/win

[lforschler]

Title: [155003] branches/safari-537.60-branch/Source/WebKit/win








Revision 155003
Author lforsch...@apple.com
Date 2013-09-03 15:20:55 -0700 (Tue, 03 Sep 2013)


Log Message
Merged r154764.  rdar://problem/14879688

Modified Paths

branches/safari-537.60-branch/Source/WebKit/win/ChangeLog
branches/safari-537.60-branch/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp
branches/safari-537.60-branch/Source/WebKit/win/WebFrame.cpp




Diff

Modified: branches/safari-537.60-branch/Source/WebKit/win/ChangeLog (155002 => 155003)

--- branches/safari-537.60-branch/Source/WebKit/win/ChangeLog	2013-09-03 22:14:51 UTC (rev 155002)
+++ branches/safari-537.60-branch/Source/WebKit/win/ChangeLog	2013-09-03 22:20:55 UTC (rev 155003)
@@ -1,5 +1,28 @@
 2013-09-03  Lucas Forschler  lforsch...@apple.com
 
+Merge r154764
+
+2013-08-28  Brent Fulgham  bfulg...@apple.com
+
+[Windows] Provide useful error messages for WebKitErrorDomain errors
+https://bugs.webkit.org/show_bug.cgi?id=120428
+
+Reviewed by Anders Carlsson.
+
+* WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebFrameLoaderClient::cancelledError): Provide text for this error.
+(WebFrameLoaderClient::blockedError): Hook up WEB_UI_STRING for this error.
+(WebFrameLoaderClient::cannotShowURLError): Ditto
+(WebFrameLoaderClient::interruptedForPolicyChangeError): Ditto
+(WebFrameLoaderClient::cannotShowMIMETypeError): Ditto
+(WebFrameLoaderClient::fileDoesNotExistError): Provide text for this error.
+(WebFrameLoaderClient::pluginWillHandleLoadError): Hook up WEB_UI_STRING for this error.
+(WebFrameLoaderClient::dispatchDidFailToStartPlugin): Ditto.
+(WebFrameLoaderClient::createJavaAppletWidget): Ditto.
+(WebFrameLoaderClient::webHistory): Remove blank line above method.
+
+2013-09-03  Lucas Forschler  lforsch...@apple.com
+
 Merge r154759
 
 2013-08-27  Brent Fulgham  bfulg...@apple.com


Modified: branches/safari-537.60-branch/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp (155002 => 155003)

--- branches/safari-537.60-branch/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp	2013-09-03 22:14:51 UTC (rev 155002)
+++ branches/safari-537.60-branch/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp	2013-09-03 22:20:55 UTC (rev 155003)
@@ -63,6 +63,7 @@
 #include WebCore/HTMLParserIdioms.h
 #include WebCore/HTMLPlugInElement.h
 #include WebCore/HistoryItem.h
+#include WebCore/LocalizedStrings.h
 #include WebCore/Page.h
 #include WebCore/PluginPackage.h
 #include WebCore/PluginView.h
@@ -814,12 +815,15 @@
 userInfoBag-setDictionary(userInfo.get());
  
 int errorCode = 0;
+String description;
 switch (pluginView-status()) {
 case PluginStatusCanNotFindPlugin:
 errorCode = WebKitErrorCannotFindPlugIn;
+description = WEB_UI_STRING(The plug-in can’t be found, WebKitErrorCannotFindPlugin description);
 break;
 case PluginStatusCanNotLoadPlugin:
 errorCode = WebKitErrorCannotLoadPlugIn;
+description = WEB_UI_STRING(The plug-in can’t be loaded, WebKitErrorCannotLoadPlugin description);
 break;
 default:
 ASSERT_NOT_REACHED();


Modified: branches/safari-537.60-branch/Source/WebKit/win/WebFrame.cpp (155002 => 155003)

--- branches/safari-537.60-branch/Source/WebKit/win/WebFrame.cpp	2013-09-03 22:14:51 UTC (rev 155002)
+++ branches/safari-537.60-branch/Source/WebKit/win/WebFrame.cpp	2013-09-03 22:20:55 UTC (rev 155003)
@@ -82,6 +82,7 @@
 #include WebCore/HTMLPlugInElement.h
 #include WebCore/JSDOMWindow.h
 #include WebCore/KeyboardEvent.h
+#include WebCore/LocalizedStrings.h
 #include WebCore/MouseRelatedEvent.h
 #include WebCore/NotImplemented.h
 #include WebCore/Page.h
@@ -1650,42 +1651,37 @@
 {
 // FIXME: Need ChickenCat to include CFNetwork/CFURLError.h to get these values
 // Alternatively, we could create our own error domain/codes.
-return ResourceError(String(WebURLErrorDomain), -999, request.url().string(), String());
+return ResourceError(String(WebURLErrorDomain), -999, request.url().string(), String(Cancelled));
 }
 
 ResourceError WebFrame::blockedError(const ResourceRequest request)
 {
-// FIXME: Need to implement the String descriptions for errors in the WebKitErrorDomain and have them localized
-return ResourceError(String(WebKitErrorDomain), WebKitErrorCannotUseRestrictedPort, request.url().string(), String());
+return ResourceError(String(WebKitErrorDomain), WebKitErrorCannotUseRestrictedPort, request.url().string(), WEB_UI_STRING(Not allowed to use restricted network port, WebKitErrorCannotUseRestrictedPort descriptiondescriptiondescription));
 }
 
 ResourceError WebFrame::cannotShowURLError(const ResourceRequest request)
 {
-// FIXME: Need to implement the String descriptions for errors 

[webkit-changes] [154997] trunk/Source

[akling]

Title: [154997] trunk/Source








Revision 154997
Author akl...@apple.com
Date 2013-09-03 12:30:20 -0700 (Tue, 03 Sep 2013)


Log Message
Support VectorRefT.
https://webkit.org/b/120637

Reviewed by Antti Koivisto.

Source/WebCore:

Use VectorRefT internally in Page.

* page/Page.cpp:
(WebCore::networkStateChanged):
(WebCore::Page::refreshPlugins):

Clean up these functions and use VectorRefFrame to store pointers to frames
since we know they are not going to be null.

(WebCore::Page::pluginViews):

Changed this to return a VectorRefPluginView by value instead of passing a
writable vector as an argument. Clean up loops with 'auto'.

(WebCore::Page::storageBlockingStateChanged):
(WebCore::Page::privateBrowsingStateChanged):

Tweaked for pluginViews() returning a Vector now.

(WebCore::Page::setVisibilityState):

Store Documents that need a visibilitychange event in a VectorRefDocument.

Source/WTF:

Add a Ref(const T) constructor to enable VectorRefT. This looks a bit awkward
but is necessary for Vector::append(const T) to find a constructor.

An alternative would be to add something like std::vector::emplace_back, but I can't
think of a good name for that, and it'd be nice if append() would just work.

Also add operator-(). I initially excluded this because I felt it made for
unsafe-looking code. Things quickly got out of hand with .get() everywhere though.

IMO - looks OK as long as it's only used on the first link in a dereference chain,
as that variable and its type will be in context.

* wtf/Ref.h:
(WTF::Ref::Ref):
(WTF::Ref::~Ref):
(WTF::Ref::operator-):
(WTF::Ref::get):
* wtf/VectorTraits.h:

Add simple traits for RefT so it can be moved around freely by Vector.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Ref.h
trunk/Source/WTF/wtf/VectorTraits.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h




Diff

Modified: trunk/Source/WTF/ChangeLog (154996 => 154997)

--- trunk/Source/WTF/ChangeLog	2013-09-03 19:14:41 UTC (rev 154996)
+++ trunk/Source/WTF/ChangeLog	2013-09-03 19:30:20 UTC (rev 154997)
@@ -1,3 +1,31 @@
+2013-09-03  Andreas Kling  akl...@apple.com
+
+Support VectorRefT.
+https://webkit.org/b/120637
+
+Reviewed by Antti Koivisto.
+
+Add a Ref(const T) constructor to enable VectorRefT. This looks a bit awkward
+but is necessary for Vector::append(const T) to find a constructor.
+
+An alternative would be to add something like std::vector::emplace_back, but I can't
+think of a good name for that, and it'd be nice if append() would just work.
+
+Also add operator-(). I initially excluded this because I felt it made for
+unsafe-looking code. Things quickly got out of hand with .get() everywhere though.
+
+IMO - looks OK as long as it's only used on the first link in a dereference chain,
+as that variable and its type will be in context.
+
+* wtf/Ref.h:
+(WTF::Ref::Ref):
+(WTF::Ref::~Ref):
+(WTF::Ref::operator-):
+(WTF::Ref::get):
+* wtf/VectorTraits.h:
+
+Add simple traits for RefT so it can be moved around freely by Vector.
+
 2013-09-03  Mikhail Pozdnyakov  mikhail.pozdnya...@intel.com
 
 Check WTF::VectorFiller template argument type size in compile time


Modified: trunk/Source/WTF/wtf/Ref.h (154996 => 154997)

--- trunk/Source/WTF/wtf/Ref.h	2013-09-03 19:14:41 UTC (rev 154996)
+++ trunk/Source/WTF/wtf/Ref.h	2013-09-03 19:30:20 UTC (rev 154997)
@@ -32,12 +32,18 @@
 
 templatetypename T class Ref {
 public:
-ALWAYS_INLINE Ref(T object) : m_ptr(object) { m_ptr-ref(); }
-ALWAYS_INLINE ~Ref() { m_ptr-deref(); }
+// Ref(const T) looks awkward but makes VectorRefT possible.
+Ref(const T object) : m_ptr(const_castT(object)) { m_ptr-ref(); }
+Ref(T object) : m_ptr(object) { m_ptr-ref(); }
 
-ALWAYS_INLINE const T get() const { return *m_ptr; }
-ALWAYS_INLINE T get() { return *m_ptr; }
+~Ref() { m_ptr-deref(); }
 
+const T* operator-() const { return m_ptr; }
+T* operator-() { return m_ptr; }
+
+const T get() const { return *m_ptr; }
+T get() { return *m_ptr; }
+
 private:
 Ref(const Ref);
 Ref operator=(const RefT);


Modified: trunk/Source/WTF/wtf/VectorTraits.h (154996 => 154997)

--- trunk/Source/WTF/wtf/VectorTraits.h	2013-09-03 19:14:41 UTC (rev 154996)
+++ trunk/Source/WTF/wtf/VectorTraits.h	2013-09-03 19:30:20 UTC (rev 154997)
@@ -23,6 +23,7 @@
 
 #include wtf/OwnArrayPtr.h
 #include wtf/OwnPtr.h
+#include wtf/Ref.h
 #include wtf/RefPtr.h
 #include wtf/TypeTraits.h
 #include utility
@@ -82,6 +83,9 @@
 templatetypename P
 struct VectorTraitsOwnArrayPtrP  : SimpleClassVectorTraits { };
 
+templatetypename P
+struct VectorTraitsRefP  : SimpleClassVectorTraits { };
+
 template
 struct VectorTraitsAtomicString : SimpleClassVectorTraits { };
 


Modified: 

[webkit-changes] [155004] branches/safari-537.60-branch/Source/WebKit/win/WebView.cpp

[lforschler]

Title: [155004] branches/safari-537.60-branch/Source/WebKit/win/WebView.cpp








Revision 155004
Author lforsch...@apple.com
Date 2013-09-03 15:31:26 -0700 (Tue, 03 Sep 2013)


Log Message
Windows build fix after 155001.

Modified Paths

branches/safari-537.60-branch/Source/WebKit/win/WebView.cpp




Diff

Modified: branches/safari-537.60-branch/Source/WebKit/win/WebView.cpp (155003 => 155004)

--- branches/safari-537.60-branch/Source/WebKit/win/WebView.cpp	2013-09-03 22:20:55 UTC (rev 155003)
+++ branches/safari-537.60-branch/Source/WebKit/win/WebView.cpp	2013-09-03 22:31:26 UTC (rev 155004)
@@ -2552,7 +2552,7 @@
 || MIMETypeRegistry::isSupportedNonImageMIMEType(mimeType)
 || MIMETypeRegistry::isSupportedMediaMIMEType(mimeType);
 
-if (!canShow  m_page  m_page-pluginData())) {
+if (!canShow  m_page  m_page-pluginData()) {
 canShow = (m_page-pluginData()-supportsMimeType(mimeType, PluginData::AllPlugins)  allowPlugins)
 || m_page-pluginData()-supportsMimeType(mimeType, PluginData::OnlyApplicationPlugins);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155007] branches/safari-537.60-branch/Source/WebKit/win/WebFrame.cpp

[lforschler]

Title: [155007] branches/safari-537.60-branch/Source/WebKit/win/WebFrame.cpp








Revision 155007
Author lforsch...@apple.com
Date 2013-09-03 16:04:12 -0700 (Tue, 03 Sep 2013)


Log Message
Windows build fix.

Modified Paths

branches/safari-537.60-branch/Source/WebKit/win/WebFrame.cpp




Diff

Modified: branches/safari-537.60-branch/Source/WebKit/win/WebFrame.cpp (155006 => 155007)

--- branches/safari-537.60-branch/Source/WebKit/win/WebFrame.cpp	2013-09-03 22:36:16 UTC (rev 155006)
+++ branches/safari-537.60-branch/Source/WebKit/win/WebFrame.cpp	2013-09-03 23:04:12 UTC (rev 155007)
@@ -1669,12 +1669,12 @@
 return ResourceError(String(WebKitErrorDomain), WebKitErrorFrameLoadInterruptedByPolicyChange, request.url().string(), WEB_UI_STRING(Frame load interrupted, WebKitErrorFrameLoadInterruptedByPolicyChange description));
 }
 
-ResourceError WebFrame::cannotShowMIMETypeError(const ResourceResponse)
+ResourceError WebFrame::cannotShowMIMETypeError(const ResourceResponse response)
 {
 return ResourceError(String(), WebKitErrorCannotShowMIMEType, response.url().string(), WEB_UI_STRING(Content with specified MIME type can’t be shown, WebKitErrorCannotShowMIMEType description));
 }
 
-ResourceError WebFrame::fileDoesNotExistError(const ResourceResponse)
+ResourceError WebFrame::fileDoesNotExistError(const ResourceResponse response)
 {
 return ResourceError(String(WebURLErrorDomain), -1100, response.url().string(), String(File does not exist.));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155008] trunk

[oliver]

Title: [155008] trunk








Revision 155008
Author oli...@apple.com
Date 2013-09-03 16:21:10 -0700 (Tue, 03 Sep 2013)


Log Message
Support structured clone of Map and Set
https://bugs.webkit.org/show_bug.cgi?id=120654

Reviewed by Simon Fraser.

Source/_javascript_Core:

Make xcode copy the required headers, and add appropriate export attributes

* _javascript_Core.xcodeproj/project.pbxproj:
* runtime/JSMap.h:
* runtime/JSSet.h:
* runtime/MapData.h:

Source/WebCore:

Add support for cloning Map and Set.  Fairly self explanatory change.
Needed to add Forwarding headers for the JSMap, JSSet and MapData classes.

* ForwardingHeaders/runtime/JSMap.h: Added.
* ForwardingHeaders/runtime/JSSet.h: Added.
* ForwardingHeaders/runtime/MapData.h: Added.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::isMap):
(WebCore::CloneSerializer::isSet):
(WebCore::CloneSerializer::startSet):
(WebCore::CloneSerializer::startMap):
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::consumeMapDataTerminationIfPossible):
(WebCore::CloneDeserializer::deserialize):

LayoutTests:

Tests!

* fast/dom/Window/script-tests/postmessage-clone.js:
(set new):
(set add.set add):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js
trunk/LayoutTests/fast/dom/Window/window-postmessage-clone-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/runtime/JSMap.h
trunk/Source/_javascript_Core/runtime/JSSet.h
trunk/Source/_javascript_Core/runtime/MapData.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp


Added Paths

trunk/Source/WebCore/ForwardingHeaders/runtime/JSMap.h
trunk/Source/WebCore/ForwardingHeaders/runtime/JSSet.h
trunk/Source/WebCore/ForwardingHeaders/runtime/MapData.h




Diff

Modified: trunk/LayoutTests/ChangeLog (155007 => 155008)

--- trunk/LayoutTests/ChangeLog	2013-09-03 23:04:12 UTC (rev 155007)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 23:21:10 UTC (rev 155008)
@@ -1,3 +1,16 @@
+2013-09-03  Oliver Hunt  oli...@apple.com
+
+Support structured clone of Map and Set
+https://bugs.webkit.org/show_bug.cgi?id=120654
+
+Reviewed by Simon Fraser.
+
+Tests!
+
+* fast/dom/Window/script-tests/postmessage-clone.js:
+(set new):
+(set add.set add):
+
 2013-09-03  Bear Travis  betra...@adobe.com
 
 [CSS Shapes] Shape's content gets extra left offset when left-border is positive on the content box


Modified: trunk/LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js (155007 => 155008)

--- trunk/LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js	2013-09-03 23:04:12 UTC (rev 155007)
+++ trunk/LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js	2013-09-03 23:21:10 UTC (rev 155008)
@@ -43,6 +43,28 @@
 tryPostMessage('window', true);
 tryPostMessage('({get a() { throw x }})', true);
 
+var map = new Map;
+var set = new Set;
+map.expando1 = {};
+map.expando2 = {};
+map.aSet = set;
+map.set(1, 2.5)
+map.set(entry, map.expando1);
+map.set(true, set);
+map.set(map.expando2, map);
+set.add(false)
+set.add(map)
+tryPostMessage(map, false, evalThunk, function (v) {
+newMap = v
+doPassFail(newMap.get(entry) === newMap.expando1, String keyed entry was cloned correctly);
+doPassFail(newMap.get(newMap.expando2) === newMap, Object key entry was cloned correctly);
+shouldBe(newMap.get(true), newMap.aSet)
+shouldBe(newMap.aSet.has(newMap), true)
+newMap.forEach(function (value, key) { 
+console.innerHTML += LOG:  + value +  =  + key + br
+})
+})
+
 if (window.eventSender) {
 var fileInput = document.getElementById(fileInput);
 var fileRect = fileInput.getClientRects()[0];


Modified: trunk/LayoutTests/fast/dom/Window/window-postmessage-clone-expected.txt (155007 => 155008)

--- trunk/LayoutTests/fast/dom/Window/window-postmessage-clone-expected.txt	2013-09-03 23:04:12 UTC (rev 155007)
+++ trunk/LayoutTests/fast/dom/Window/window-postmessage-clone-expected.txt	2013-09-03 23:21:10 UTC (rev 155008)
@@ -37,6 +37,14 @@
 PASS: eventData is === to eventData[0]
 PASS: eventData.graph1 is === to eventData.graph2
 PASS: eventData[0] is === to eventData[1]
+PASS: String keyed entry was cloned correctly
+PASS: Object key entry was cloned correctly
+PASS: newMap.get(true) is [object Set] of type object
+PASS: newMap.aSet.has(newMap) is true of type boolean
+LOG: 2.5 = 1
+LOG: [object Object] = entry
+LOG: [object Set] = true
+LOG: [object Map] = [object Object]
 PASS: eventData is [object ImageData] of type object
 PASS: eventData is [object Uint8ClampedArray] of type object
 PASS: eventData is [object ImageData] of type object


Modified: trunk/Source/_javascript_Core/ChangeLog (155007 => 155008)

--- trunk/Source/_javascript_Core/ChangeLog	2013-09-03 23:04:12 UTC (rev 155007)
+++ 

[webkit-changes] [154991] trunk

[commit-queue]

Title: [154991] trunk








Revision 154991
Author commit-qu...@webkit.org
Date 2013-09-03 11:30:08 -0700 (Tue, 03 Sep 2013)


Log Message
Unreviewed, rolling out r154881.
http://trac.webkit.org/changeset/154881
https://bugs.webkit.org/show_bug.cgi?id=120643

Crashes on macworld.com (Requested by kling on #webkit).

Source/WebCore:

* dom/Element.cpp:
(WebCore::Element::setAttributeInternal):

LayoutTests:

* fast/dom/Element/setAttributeNode-for-existing-attribute-expected.txt: Removed.
* fast/dom/Element/setAttributeNode-for-existing-attribute.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp


Removed Paths

trunk/LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute-expected.txt
trunk/LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154990 => 154991)

--- trunk/LayoutTests/ChangeLog	2013-09-03 17:33:22 UTC (rev 154990)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 18:30:08 UTC (rev 154991)
@@ -1,3 +1,14 @@
+2013-09-03  Commit Queue  commit-qu...@webkit.org
+
+Unreviewed, rolling out r154881.
+http://trac.webkit.org/changeset/154881
+https://bugs.webkit.org/show_bug.cgi?id=120643
+
+Crashes on macworld.com (Requested by kling on #webkit).
+
+* fast/dom/Element/setAttributeNode-for-existing-attribute-expected.txt: Removed.
+* fast/dom/Element/setAttributeNode-for-existing-attribute.html: Removed.
+
 2013-09-03  Mihnea Ovidenie  mih...@adobe.com
 
 [CSSRegions] Pseudo-elements as regions should not be exposed to JS


Deleted: trunk/LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute-expected.txt (154990 => 154991)

--- trunk/LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute-expected.txt	2013-09-03 17:33:22 UTC (rev 154990)
+++ trunk/LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute-expected.txt	2013-09-03 18:30:08 UTC (rev 154991)
@@ -1,3 +0,0 @@
-Testcase for bug 120293: setAttributeNode() does not set the new value to an existing attribute if specified attribute is in a different case.\nThe issue can be manually verified by ascertaining that a green colored block is displayed instead of a red one.
- 
-background-color specified with lowercase style attribute was: red and specified with uppercase style attribute is: green


Deleted: trunk/LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute.html (154990 => 154991)

--- trunk/LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute.html	2013-09-03 17:33:22 UTC (rev 154990)
+++ trunk/LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute.html	2013-09-03 18:30:08 UTC (rev 154991)
@@ -1,26 +0,0 @@
-!DOCTYPE html
-html
-head
-script
-function runTest() {
-if (window.testRunner)
-testRunner.dumpAsText();
-
-var testElement = document.getElementById('test');
-var testElementBgColor = testElement.style.background;
-
-var newAttr = document.createAttribute(STYLE);
-newAttr.value = background-color: green;
-testElement.setAttributeNode(newAttr);
-var testElementBgColorAfterReset = testElement.style.background;
-
-document.getElementById('result').innerHTML = background-color specified with lowercase style attribute was: +testElementBgColor+ and specified with uppercase style attribute is: +testElementBgColorAfterReset;
-}
-/script
-/head
-body _onload_=runTest();
-divTestcase for bug a href="" setAttributeNode() does not set the new value to an existing attribute if specified attribute is in a different case.\nThe issue can be manually verified by ascertaining that a green colored block is displayed instead of a red one./div
-div id=test style=background-color: red;/nbsp;/div
-div id=result/div
-/body
-/html


Modified: trunk/Source/WebCore/ChangeLog (154990 => 154991)

--- trunk/Source/WebCore/ChangeLog	2013-09-03 17:33:22 UTC (rev 154990)
+++ trunk/Source/WebCore/ChangeLog	2013-09-03 18:30:08 UTC (rev 154991)
@@ -1,3 +1,14 @@
+2013-09-03  Commit Queue  commit-qu...@webkit.org
+
+Unreviewed, rolling out r154881.
+http://trac.webkit.org/changeset/154881
+https://bugs.webkit.org/show_bug.cgi?id=120643
+
+Crashes on macworld.com (Requested by kling on #webkit).
+
+* dom/Element.cpp:
+(WebCore::Element::setAttributeInternal):
+
 2013-09-03  Andre Moreira Magalhaes   andre.magalh...@collabora.co.uk
 
 [GStreamer] Don't set state to NULL until element is destroyed


Modified: trunk/Source/WebCore/dom/Element.cpp (154990 => 154991)

--- trunk/Source/WebCore/dom/Element.cpp	2013-09-03 17:33:22 UTC (rev 154990)
+++ trunk/Source/WebCore/dom/Element.cpp	2013-09-03 18:30:08 UTC (rev 154991)
@@ -963,24 +963,21 @@
 return;
 }
 
-bool valueChanged = newValue != attributeAt(index).value();
-const QualifiedName attributeName = 

[webkit-changes] [155005] tags/Safari-537.67/

[lforschler]

Title: [155005] tags/Safari-537.67/








Revision 155005
Author lforsch...@apple.com
Date 2013-09-03 15:34:19 -0700 (Tue, 03 Sep 2013)


Log Message
New Tag.

Added Paths

tags/Safari-537.67/




Diff

Property changes: tags/Safari-537.67



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155006] branches/safari-537-branch/Source

[lforschler]

Title: [155006] branches/safari-537-branch/Source








Revision 155006
Author lforsch...@apple.com
Date 2013-09-03 15:36:16 -0700 (Tue, 03 Sep 2013)


Log Message
Versioning.

Modified Paths

branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig (155005 => 155006)

--- branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2013-09-03 22:34:19 UTC (rev 155005)
+++ branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2013-09-03 22:36:16 UTC (rev 155006)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 67;
+MINOR_VERSION = 68;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig (155005 => 155006)

--- branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig	2013-09-03 22:34:19 UTC (rev 155005)
+++ branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig	2013-09-03 22:36:16 UTC (rev 155006)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 67;
+MINOR_VERSION = 68;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (155005 => 155006)

--- branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2013-09-03 22:34:19 UTC (rev 155005)
+++ branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2013-09-03 22:36:16 UTC (rev 155006)
@@ -1,5 +1,5 @@
 MAJOR_VERSION = 537;
-MINOR_VERSION = 67;
+MINOR_VERSION = 68;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig (155005 => 155006)

--- branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2013-09-03 22:34:19 UTC (rev 155005)
+++ branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2013-09-03 22:36:16 UTC (rev 155006)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 67;
+MINOR_VERSION = 68;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig (155005 => 155006)

--- branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig	2013-09-03 22:34:19 UTC (rev 155005)
+++ branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig	2013-09-03 22:36:16 UTC (rev 155006)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 67;
+MINOR_VERSION = 68;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154992] trunk

[rniwa]

Title: [154992] trunk








Revision 154992
Author rn...@webkit.org
Date 2013-09-03 11:45:51 -0700 (Tue, 03 Sep 2013)


Log Message
Support the json responseType and JSON response entity in XHR
https://bugs.webkit.org/show_bug.cgi?id=73648

Reviewed by Oliver Hunt.

Source/_javascript_Core: 

Based on the patch written by Jarred Nicholls.

Add JSC::JSONParse. This function will be used in XMLHttpRequest.response of type 'json'.

* _javascript_Core.xcodeproj/project.pbxproj:
* runtime/JSONObject.cpp:
(JSC::JSONParse):
* runtime/JSONObject.h:

Source/WebCore: 

Based on the patch written by Jarred Nicholls.

Implement 'json' type for XMLHttpRequest.response. We cache the result on JSC side as a cached attribute
unlike other response types like 'document' and 'blob' for which the parsed response object is cached
in XMLHttpRequest itself. In the long run, we should do the same for other types of response types.

Also refactored the various code to share the code.

Tests: fast/xmlhttprequest/xmlhttprequest-responsetype-json-invalid.html
   fast/xmlhttprequest/xmlhttprequest-responsetype-json-utf16.html
   fast/xmlhttprequest/xmlhttprequest-responsetype-json-valid.html

* ForwardingHeaders/runtime/JSONObject.h: Added.

* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitChildren):
(WebCore::JSXMLHttpRequest::response): Use JSONParse to parse the response text and cache the result.
Call didCacheResponseJSON to set the cache status and clear the original response buffer.

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest): Added m_responseCacheIsValid to invalidate the cache of
a json response.
(WebCore::XMLHttpRequest::responseText):
(WebCore::XMLHttpRequest::didCacheResponseJSON): Added; Updates m_responseCacheIsValid and clears the
response buffer to save memory.
(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::responseType):
(WebCore::XMLHttpRequest::clearResponseBuffers):
(WebCore::XMLHttpRequest::didReceiveData):

* xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::doneWithoutErrors): Extracted from responseXML.
(WebCore::XMLHttpRequest::responseTextIgnoringResponseType): Extracted from responseText.
(WebCore::XMLHttpRequest::responseCacheIsValid): Added.
(WebCore::XMLHttpRequest::shouldDecodeResponse): Extracted from didReceiveData.
Also modified to decode when the response type is ResponseTypeJSON.

* xml/XMLHttpRequest.idl: Added CachedAttribute IDL extention on response property. This cache is
used when the response type is 'json'.

LayoutTests: 

Add regression tests for XMLHttpRequest.response of type 'json'.

Two of these tests (valid  invalid) come from Jarred Nicholls's original patch.

* fast/xmlhttprequest/resources/xmlhttprequest-responsetype-json-utf-16.json: Added.
* fast/xmlhttprequest/resources/xmlhttprequest-responsetype-json.json: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-json-invalid-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-json-invalid.html: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-json-utf16-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-json-utf16.html: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-json-valid-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-json-valid.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/runtime/JSONObject.cpp
trunk/Source/_javascript_Core/runtime/JSONObject.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.h
trunk/Source/WebCore/xml/XMLHttpRequest.idl


Added Paths

trunk/LayoutTests/fast/xmlhttprequest/resources/xmlhttprequest-responsetype-json-utf-16.json
trunk/LayoutTests/fast/xmlhttprequest/resources/xmlhttprequest-responsetype-json.json
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-json-invalid-expected.txt
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-json-invalid.html
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-json-utf16-expected.txt
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-json-utf16.html
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-json-valid-expected.txt
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-json-valid.html
trunk/Source/WebCore/ForwardingHeaders/runtime/JSONObject.h




Diff

Modified: trunk/LayoutTests/ChangeLog (154991 => 154992)

--- trunk/LayoutTests/ChangeLog	2013-09-03 18:30:08 UTC (rev 154991)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 18:45:51 UTC (rev 154992)
@@ -1,3 +1,23 @@
+2013-09-02  Ryosuke Niwa  rn...@webkit.org
+
+Support the json responseType and JSON response entity in XHR
+

[webkit-changes] [154983] trunk/Source/WebKit/qt

[allan . jensen]

Title: [154983] trunk/Source/WebKit/qt








Revision 154983
Author allan.jen...@digia.com
Date 2013-09-03 07:47:01 -0700 (Tue, 03 Sep 2013)


Log Message
[Qt] Tiled-backing store not clipped to frame or visible rect
https://bugs.webkit.org/show_bug.cgi?id=120606

Reviewed by Jocelyn Turcotte.

Clip painting from the tiled-backing store to the frame rect.

* WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::renderFromTiledBackingStore):

Modified Paths

trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp




Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (154982 => 154983)

--- trunk/Source/WebKit/qt/ChangeLog	2013-09-03 14:43:20 UTC (rev 154982)
+++ trunk/Source/WebKit/qt/ChangeLog	2013-09-03 14:47:01 UTC (rev 154983)
@@ -1,5 +1,17 @@
 2013-09-03  Allan Sandfeld Jensen  allan.jen...@digia.com
 
+[Qt] Tiled-backing store not clipped to frame or visible rect
+https://bugs.webkit.org/show_bug.cgi?id=120606
+
+Reviewed by Jocelyn Turcotte.
+
+Clip painting from the tiled-backing store to the frame rect.
+
+* WebCoreSupport/QWebFrameAdapter.cpp:
+(QWebFrameAdapter::renderFromTiledBackingStore):
+
+2013-09-03  Allan Sandfeld Jensen  allan.jen...@digia.com
+
 [Qt][WK1] PageVisibility tests are flaky
 https://bugs.webkit.org/show_bug.cgi?id=120418
 


Modified: trunk/Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp (154982 => 154983)

--- trunk/Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp	2013-09-03 14:43:20 UTC (rev 154982)
+++ trunk/Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp	2013-09-03 14:47:01 UTC (rev 154983)
@@ -641,19 +641,20 @@
 
 int scrollX = view-scrollX();
 int scrollY = view-scrollY();
-context.translate(-scrollX, -scrollY);
+QRect frameRect = view-frameRect();
 
 for (int i = 0; i  vector.size(); ++i) {
 const QRect clipRect = vector.at(i);
 
-painter-save();
+context.save();
+QRect rect = clipRect.intersected(frameRect);
+context.translate(-scrollX, -scrollY);
+rect.translate(scrollX, scrollY);
+context.clip(rect);
 
-QRect rect = clipRect.translated(scrollX, scrollY);
-painter-setClipRect(rect, Qt::IntersectClip);
-
 frame-tiledBackingStore()-paint(context, rect);
 
-painter-restore();
+context.restore();
 }
 
 #if USE(ACCELERATED_COMPOSITING)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154984] trunk/Source/WebCore

[commit-queue]

Title: [154984] trunk/Source/WebCore








Revision 154984
Author commit-qu...@webkit.org
Date 2013-09-03 07:50:53 -0700 (Tue, 03 Sep 2013)


Log Message
[WinCairo] Unneeded code in method GlyphPage::fill().
https://bugs.webkit.org/show_bug.cgi?id=120634

Patch by pe...@outlook.com pe...@outlook.com on 2013-09-03
Reviewed by Andreas Kling.

* platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:
(WebCore::GlyphPage::fill): Remove unneeded call to GetTextMetrics() function.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154983 => 154984)

--- trunk/Source/WebCore/ChangeLog	2013-09-03 14:47:01 UTC (rev 154983)
+++ trunk/Source/WebCore/ChangeLog	2013-09-03 14:50:53 UTC (rev 154984)
@@ -1,3 +1,13 @@
+2013-09-03  pe...@outlook.com  pe...@outlook.com
+
+[WinCairo] Unneeded code in method GlyphPage::fill().
+https://bugs.webkit.org/show_bug.cgi?id=120634
+
+Reviewed by Andreas Kling.
+
+* platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:
+(WebCore::GlyphPage::fill): Remove unneeded call to GetTextMetrics() function.
+
 2013-09-03  Mihnea Ovidenie  mih...@adobe.com
 
 [CSSRegions] Pseudo-elements as regions should not be exposed to JS


Modified: trunk/Source/WebCore/platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp (154983 => 154984)

--- trunk/Source/WebCore/platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp	2013-09-03 14:47:01 UTC (rev 154983)
+++ trunk/Source/WebCore/platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp	2013-09-03 14:50:53 UTC (rev 154984)
@@ -46,9 +46,6 @@
 SaveDC(dc);
 SelectObject(dc, fontData-platformData().hfont());
 
-TEXTMETRIC tm;
-GetTextMetrics(dc, tm);
-
 WORD localGlyphBuffer[GlyphPage::size * 2];
 DWORD result = GetGlyphIndices(dc, buffer, bufferLength, localGlyphBuffer, 0);
 bool success = result != GDI_ERROR  static_castunsigned(result) == bufferLength;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154993] trunk

[dbates]

Title: [154993] trunk








Revision 154993
Author dba...@webkit.org
Date 2013-09-03 11:51:45 -0700 (Tue, 03 Sep 2013)


Log Message
Require layout when -webkit-overflow-scrolling changes
https://bugs.webkit.org/show_bug.cgi?id=120535

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/repaint/overflow-scroll-touch-repaint.html

We want to require a layout when the value of -webkit-overflow-scrolling changes
since -webkit-overflow-scrolling creates a stacking context.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):

LayoutTests:

Add a test to ensure we perform a layout and repaint when the
value of -webkit-overflow-scrolling changes on an element.

At the time of writing, the iOS port enables ACCELERATED_OVERFLOW_SCROLLING.

* fast/repaint/overflow-scroll-touch-repaint-expected.txt: Added.
* fast/repaint/overflow-scroll-touch-repaint.html: Added.
* platform/efl/TestExpectations: Skip test fast/repaint/overflow-scroll-touch-repaint.html
since this platform doesn't enable ACCELERATED_OVERFLOW_SCROLLING.
* platform/gtk/TestExpectations: Ditto.
* platform/mac/TestExpectations: Ditto.
* platform/qt/TestExpectations: Ditto.
* platform/win/TestExpectations: Ditto.
* platform/wincairo/TestExpectations: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/wincairo/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.cpp


Added Paths

trunk/LayoutTests/fast/repaint/overflow-scroll-touch-repaint-expected.txt
trunk/LayoutTests/fast/repaint/overflow-scroll-touch-repaint.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154992 => 154993)

--- trunk/LayoutTests/ChangeLog	2013-09-03 18:45:51 UTC (rev 154992)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 18:51:45 UTC (rev 154993)
@@ -1,3 +1,25 @@
+2013-09-03  Daniel Bates  daba...@apple.com
+
+Require layout when -webkit-overflow-scrolling changes
+https://bugs.webkit.org/show_bug.cgi?id=120535
+
+Reviewed by Darin Adler.
+
+Add a test to ensure we perform a layout and repaint when the
+value of -webkit-overflow-scrolling changes on an element.
+
+At the time of writing, the iOS port enables ACCELERATED_OVERFLOW_SCROLLING.
+
+* fast/repaint/overflow-scroll-touch-repaint-expected.txt: Added.
+* fast/repaint/overflow-scroll-touch-repaint.html: Added.
+* platform/efl/TestExpectations: Skip test fast/repaint/overflow-scroll-touch-repaint.html
+since this platform doesn't enable ACCELERATED_OVERFLOW_SCROLLING.
+* platform/gtk/TestExpectations: Ditto.
+* platform/mac/TestExpectations: Ditto.
+* platform/qt/TestExpectations: Ditto.
+* platform/win/TestExpectations: Ditto.
+* platform/wincairo/TestExpectations: Ditto.
+
 2013-09-02  Ryosuke Niwa  rn...@webkit.org
 
 Support the json responseType and JSON response entity in XHR


Added: trunk/LayoutTests/fast/repaint/overflow-scroll-touch-repaint-expected.txt (0 => 154993)

--- trunk/LayoutTests/fast/repaint/overflow-scroll-touch-repaint-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/repaint/overflow-scroll-touch-repaint-expected.txt	2013-09-03 18:51:45 UTC (rev 154993)
@@ -0,0 +1,9 @@
+This test PASSED if you see repaint output (below).
+
+(repaint rects
+  (rect 0 0 800 600)
+  (rect 8 16 784 20)
+  (rect 8 52 2000 2000)
+  (rect 8 16 2000 2036)
+)
+


Added: trunk/LayoutTests/fast/repaint/overflow-scroll-touch-repaint.html (0 => 154993)

--- trunk/LayoutTests/fast/repaint/overflow-scroll-touch-repaint.html	(rev 0)
+++ trunk/LayoutTests/fast/repaint/overflow-scroll-touch-repaint.html	2013-09-03 18:51:45 UTC (rev 154993)
@@ -0,0 +1,19 @@
+!DOCTYPE html
+html
+head
+script src=""
+script
+function repaintTest()
+{
+document.body.style.webkitOverflowScrolling = touch;
+}
+/script
+/head
+body style=overflow: hidden; -webkit-overflow-scrolling: auto _onload_=runRepaintTest()
+!-- This tests that we require a layout and repaint when the value of -webkit-overflow-scrolling changes. --
+pThis test PASSED if you see repaint output (below)./p
+!-- Note, we expect this test to fail on all ports that have not compiled with ACCELERATED_OVERFLOW_SCROLLING enabled. --
+
+div style=width: 2000px; height: 2000px;/div
+/body
+/html


Modified: trunk/LayoutTests/platform/efl/TestExpectations (154992 => 154993)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-09-03 18:45:51 UTC (rev 154992)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-09-03 18:51:45 UTC (rev 154993)
@@ -327,6 +327,9 @@
 Bug(EFL) fast/canvas/fill-stroke-clip-reset-path.html
 Bug(EFL) 

[webkit-changes] [155009] trunk/LayoutTests

[benjamin]

Title: [155009] trunk/LayoutTests








Revision 155009
Author benja...@webkit.org
Date 2013-09-03 16:56:36 -0700 (Tue, 03 Sep 2013)


Log Message
The test inspector/geolocation-success.html is unreliable
https://bugs.webkit.org/show_bug.cgi?id=120655

Reviewed by Alexey Proskuryakov.

* inspector/geolocation-success.html:
The test was expecting everything would be done in the page context
when InspectorTest.evaluateInPage invoke the callback.

This is not the case, geolocation APIs are asynchronous.
The callbacks printLocation() and printError() may or may not be executed.

To fix this, the execution of each step is changed to depends on the completion
of the geolocation callback.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/geolocation-success.html




Diff

Modified: trunk/LayoutTests/ChangeLog (155008 => 155009)

--- trunk/LayoutTests/ChangeLog	2013-09-03 23:21:10 UTC (rev 155008)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 23:56:36 UTC (rev 155009)
@@ -1,3 +1,20 @@
+2013-09-03  Benjamin Poulain  benja...@webkit.org
+
+The test inspector/geolocation-success.html is unreliable
+https://bugs.webkit.org/show_bug.cgi?id=120655
+
+Reviewed by Alexey Proskuryakov.
+
+* inspector/geolocation-success.html:
+The test was expecting everything would be done in the page context
+when InspectorTest.evaluateInPage invoke the callback.
+
+This is not the case, geolocation APIs are asynchronous.
+The callbacks printLocation() and printError() may or may not be executed.
+
+To fix this, the execution of each step is changed to depends on the completion
+of the geolocation callback.
+
 2013-09-03  Oliver Hunt  oli...@apple.com
 
 Support structured clone of Map and Set


Modified: trunk/LayoutTests/inspector/geolocation-success.html (155008 => 155009)

--- trunk/LayoutTests/inspector/geolocation-success.html	2013-09-03 23:21:10 UTC (rev 155008)
+++ trunk/LayoutTests/inspector/geolocation-success.html	2013-09-03 23:56:36 UTC (rev 155009)
@@ -15,32 +15,35 @@
 } else
 debug('This test can not be run without the LayoutTestController');
 
-function getGeolocation()
+function getGeolocation(webInspectorCallbackString)
 {
 function printLocation(pos)
 {
 console.log('lat: ' + pos.coords.latitude + ', long: ' + pos.coords.longitude);
+finishTest();
 }
 function printError(err)
 {
 console.log('Error: ' + err.code);
+finishTest();
 }
+function finishTest()
+{
+testRunner.evaluateInWebInspector(0, webInspectorCallbackString);
+}
 navigator.geolocation.getCurrentPosition(printLocation, printError, [])
 }
 
 function test()
 {
-function callbackComplete()
+window.testStep2 = function()
 {
-InspectorTest.completeTest();
-}
-function callback()
-{
 PageAgent.clearGeolocationOverride();
-InspectorTest.evaluateInPage(getGeolocation(), callbackComplete);
+InspectorTest.evaluateInPage(getGeolocation('InspectorTest.completeTest()'));
 }
+
 PageAgent.setGeolocationOverride(43.476093, -80.540299, 150);
-InspectorTest.evaluateInPage(getGeolocation(), callback);
+InspectorTest.evaluateInPage(getGeolocation('window.testStep2()'));
 }
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155010] tags/Safari-537.60.1/

[lforschler]

Title: [155010] tags/Safari-537.60.1/








Revision 155010
Author lforsch...@apple.com
Date 2013-09-03 16:57:03 -0700 (Tue, 03 Sep 2013)


Log Message
New Tag.

Added Paths

tags/Safari-537.60.1/




Diff

Property changes: tags/Safari-537.60.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154995] trunk

[ap]

Title: [154995] trunk








Revision 154995
Author a...@apple.com
Date 2013-09-03 12:00:52 -0700 (Tue, 03 Sep 2013)


Log Message
[Mac] Hyphenation respects regional format settings language instead of primary language
https://bugs.webkit.org/show_bug.cgi?id=120641

Reviewed by Dan Bernstein.

Fixes hyphenation tests on my machine with non-English regional format settings.

* platform/text/cf/HyphenationCF.cpp: (createValueForNullKey):
Use primary UI language for hyphenation, not regional settings language.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/cf/HyphenationCF.cpp


Added Paths

trunk/LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (154994 => 154995)

--- trunk/LayoutTests/ChangeLog	2013-09-03 19:00:11 UTC (rev 154994)
+++ trunk/LayoutTests/ChangeLog	2013-09-03 19:00:52 UTC (rev 154995)
@@ -1,3 +1,13 @@
+2013-09-03  Alexey Proskuryakov  a...@apple.com
+
+[Mac] Hyphenation respects regional format settings language instead of primary language
+https://bugs.webkit.org/show_bug.cgi?id=120641
+
+Reviewed by Dan Bernstein.
+
+* platform/mac/fast/text/hyphenate-locale-expected.png: Added, this test only had
+expected pixel results in mac-lion dorectory.
+
 2013-09-03  Daniel Bates  daba...@apple.com
 
 Require layout when -webkit-overflow-scrolling changes


Added: trunk/LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.png
___

Added: svn:mime-type

Modified: trunk/Source/WebCore/ChangeLog (154994 => 154995)

--- trunk/Source/WebCore/ChangeLog	2013-09-03 19:00:11 UTC (rev 154994)
+++ trunk/Source/WebCore/ChangeLog	2013-09-03 19:00:52 UTC (rev 154995)
@@ -1,3 +1,15 @@
+2013-09-03  Alexey Proskuryakov  a...@apple.com
+
+[Mac] Hyphenation respects regional format settings language instead of primary language
+https://bugs.webkit.org/show_bug.cgi?id=120641
+
+Reviewed by Dan Bernstein.
+
+Fixes hyphenation tests on my machine with non-English regional format settings.
+
+* platform/text/cf/HyphenationCF.cpp: (createValueForNullKey):
+Use primary UI language for hyphenation, not regional settings language.
+
 2013-09-03  Danilo Cesar Lemes de Paula  danilo.ce...@collabora.co.uk
 
 [GTK][EFL] include missing localized strings for subtitle auto track


Modified: trunk/Source/WebCore/platform/text/cf/HyphenationCF.cpp (154994 => 154995)

--- trunk/Source/WebCore/platform/text/cf/HyphenationCF.cpp	2013-09-03 19:00:11 UTC (rev 154994)
+++ trunk/Source/WebCore/platform/text/cf/HyphenationCF.cpp	2013-09-03 19:00:52 UTC (rev 154995)
@@ -27,6 +27,7 @@
 #include Hyphenation.h
 
 #include AtomicStringKeyedMRUCache.h
+#include Language.h
 #include TextBreakIteratorInternalICU.h
 #include wtf/ListHashSet.h
 #include wtf/RetainPtr.h
@@ -36,7 +37,9 @@
 template
 RetainPtrCFLocaleRef AtomicStringKeyedMRUCacheRetainPtrCFLocaleRef ::createValueForNullKey()
 {
-RetainPtrCFLocaleRef locale = adoptCF(CFLocaleCopyCurrent());
+// CF hyphenation functions use locale (regional formats) language, which doesn't necessarily match primary UI language,
+// so we can't use default locale here. See rdar://problem/14897664.
+RetainPtrCFLocaleRef locale = adoptCF(CFLocaleCreate(0, defaultLanguage().createCFString().get()));
 
 return CFStringIsHyphenationAvailableForLocale(locale.get()) ? locale : 0;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154994] trunk/Source/WebCore

[commit-queue]

Title: [154994] trunk/Source/WebCore








Revision 154994
Author commit-qu...@webkit.org
Date 2013-09-03 12:00:11 -0700 (Tue, 03 Sep 2013)


Log Message
[GTK][EFL] include missing localized strings for subtitle auto track
https://bugs.webkit.org/show_bug.cgi?id=120629

those methods are necessary to show the Auto track on webkitgtk

Patch by Danilo Cesar Lemes de Paula danilo.ce...@collabora.co.uk on 2013-09-03
Reviewed by Gustavo Noronha Silva.

* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::textTrackAutomaticMenuItemText):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::textTrackAutomaticMenuItemText):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp
trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (154993 => 154994)

--- trunk/Source/WebCore/ChangeLog	2013-09-03 18:51:45 UTC (rev 154993)
+++ trunk/Source/WebCore/ChangeLog	2013-09-03 19:00:11 UTC (rev 154994)
@@ -1,3 +1,17 @@
+2013-09-03  Danilo Cesar Lemes de Paula  danilo.ce...@collabora.co.uk
+
+[GTK][EFL] include missing localized strings for subtitle auto track
+https://bugs.webkit.org/show_bug.cgi?id=120629
+
+those methods are necessary to show the Auto track on webkitgtk
+
+Reviewed by Gustavo Noronha Silva.
+
+* platform/efl/LocalizedStringsEfl.cpp:
+(WebCore::textTrackAutomaticMenuItemText):
+* platform/gtk/LocalizedStringsGtk.cpp:
+(WebCore::textTrackAutomaticMenuItemText):
+
 2013-09-03  Daniel Bates  daba...@apple.com
 
 Require layout when -webkit-overflow-scrolling changes


Modified: trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp (154993 => 154994)

--- trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp	2013-09-03 18:51:45 UTC (rev 154993)
+++ trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp	2013-09-03 19:00:11 UTC (rev 154994)
@@ -640,6 +640,11 @@
 return String::fromUTF8(Off);
 }
 
+String textTrackAutomaticMenuItemText()
+{
+return String::fromUTF8(Auto);
+}
+
 String textTrackNoLabelText()
 {
 return String::fromUTF8(No label);


Modified: trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp (154993 => 154994)

--- trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp	2013-09-03 18:51:45 UTC (rev 154993)
+++ trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp	2013-09-03 19:00:11 UTC (rev 154994)
@@ -803,6 +803,11 @@
 return String::fromUTF8(C_(Off, Menu item label for the track that represents disabling closed captions));
 }
 
+String textTrackAutomaticMenuItemText()
+{
+return String::fromUTF8(C_(Menu item label for the automatically choosen track, Auto));
+}
+
 String textTrackNoLabelText()
 {
 return String::fromUTF8(C_(No label, Menu item label for a closed captions track that has no other name));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155011] branches/safari-537.60-branch/Source

[lforschler]

Title: [155011] branches/safari-537.60-branch/Source








Revision 155011
Author lforsch...@apple.com
Date 2013-09-03 17:04:03 -0700 (Tue, 03 Sep 2013)


Log Message
Versioning.

Modified Paths

branches/safari-537.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-537.60-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-537.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-537.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-537.60-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-537.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig (155010 => 155011)

--- branches/safari-537.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2013-09-03 23:57:03 UTC (rev 155010)
+++ branches/safari-537.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2013-09-04 00:04:03 UTC (rev 155011)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 60;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-537.60-branch/Source/WebCore/Configurations/Version.xcconfig (155010 => 155011)

--- branches/safari-537.60-branch/Source/WebCore/Configurations/Version.xcconfig	2013-09-03 23:57:03 UTC (rev 155010)
+++ branches/safari-537.60-branch/Source/WebCore/Configurations/Version.xcconfig	2013-09-04 00:04:03 UTC (rev 155011)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 60;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-537.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (155010 => 155011)

--- branches/safari-537.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2013-09-03 23:57:03 UTC (rev 155010)
+++ branches/safari-537.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2013-09-04 00:04:03 UTC (rev 155011)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 537;
 MINOR_VERSION = 60;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The system version prefix is based on the current system version.


Modified: branches/safari-537.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig (155010 => 155011)

--- branches/safari-537.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2013-09-03 23:57:03 UTC (rev 155010)
+++ branches/safari-537.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2013-09-04 00:04:03 UTC (rev 155011)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 60;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-537.60-branch/Source/WebKit2/Configurations/Version.xcconfig (155010 => 155011)

--- branches/safari-537.60-branch/Source/WebKit2/Configurations/Version.xcconfig	2013-09-03 23:57:03 UTC (rev 155010)
+++ branches/safari-537.60-branch/Source/WebKit2/Configurations/Version.xcconfig	2013-09-04 00:04:03 UTC (rev 155011)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 60;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155012] trunk/LayoutTests

[benjamin]

Title: [155012] trunk/LayoutTests








Revision 155012
Author benja...@webkit.org
Date 2013-09-03 17:16:44 -0700 (Tue, 03 Sep 2013)


Log Message
Try unskipping compositing/images/positioned-image-content-rect.html

Unreviewed.

* platform/mac/TestExpectations:
The test compositing/images/positioned-image-content-rect.html seems to pass reliably
on the bots and locally.
Try to unskip it.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (155011 => 155012)

--- trunk/LayoutTests/ChangeLog	2013-09-04 00:04:03 UTC (rev 155011)
+++ trunk/LayoutTests/ChangeLog	2013-09-04 00:16:44 UTC (rev 155012)
@@ -1,5 +1,16 @@
 2013-09-03  Benjamin Poulain  benja...@webkit.org
 
+Try unskipping compositing/images/positioned-image-content-rect.html
+
+Unreviewed.
+
+* platform/mac/TestExpectations:
+The test compositing/images/positioned-image-content-rect.html seems to pass reliably
+on the bots and locally.
+Try to unskip it.
+
+2013-09-03  Benjamin Poulain  benja...@webkit.org
+
 The test inspector/geolocation-success.html is unreliable
 https://bugs.webkit.org/show_bug.cgi?id=120655
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (155011 => 155012)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-09-04 00:04:03 UTC (rev 155011)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-09-04 00:16:44 UTC (rev 155012)
@@ -1064,7 +1064,6 @@
 webkit.org/b/98456 compositing/images/truncated-direct-png-image.html [ ImageOnlyFailure ]
 
 # Ref tests suffering from colorspace issues
-compositing/images/positioned-image-content-rect.html [ ImageOnlyFailure ]
 compositing/patterns/direct-pattern-compositing-add-text.html [ Pass ImageOnlyFailure ]
 compositing/patterns/direct-pattern-compositing-contain.html [ Pass ImageOnlyFailure ]
 compositing/patterns/direct-pattern-compositing-cover.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154985] trunk/Source/WebKit/qt

[allan . jensen]

Title: [154985] trunk/Source/WebKit/qt








Revision 154985
Author allan.jen...@digia.com
Date 2013-09-03 08:32:07 -0700 (Tue, 03 Sep 2013)


Log Message
[Qt] Images scaled poorly on composited canvas
https://bugs.webkit.org/show_bug.cgi?id=120632

Reviewed by Jocelyn Turcotte.

Explicitly set a imageInterpolationQuality on the TextureMapper, because
InterpolationDefault may be interpreted differently by nested GraphicsContexts.

* WebCoreSupport/TextureMapperLayerClientQt.cpp:
(TextureMapperLayerClientQt::renderCompositedLayers):

Modified Paths

trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/TextureMapperLayerClientQt.cpp




Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (154984 => 154985)

--- trunk/Source/WebKit/qt/ChangeLog	2013-09-03 14:50:53 UTC (rev 154984)
+++ trunk/Source/WebKit/qt/ChangeLog	2013-09-03 15:32:07 UTC (rev 154985)
@@ -1,5 +1,18 @@
 2013-09-03  Allan Sandfeld Jensen  allan.jen...@digia.com
 
+[Qt] Images scaled poorly on composited canvas
+https://bugs.webkit.org/show_bug.cgi?id=120632
+
+Reviewed by Jocelyn Turcotte.
+
+Explicitly set a imageInterpolationQuality on the TextureMapper, because
+InterpolationDefault may be interpreted differently by nested GraphicsContexts.
+
+* WebCoreSupport/TextureMapperLayerClientQt.cpp:
+(TextureMapperLayerClientQt::renderCompositedLayers):
+
+2013-09-03  Allan Sandfeld Jensen  allan.jen...@digia.com
+
 [Qt] Tiled-backing store not clipped to frame or visible rect
 https://bugs.webkit.org/show_bug.cgi?id=120606
 


Modified: trunk/Source/WebKit/qt/WebCoreSupport/TextureMapperLayerClientQt.cpp (154984 => 154985)

--- trunk/Source/WebKit/qt/WebCoreSupport/TextureMapperLayerClientQt.cpp	2013-09-03 14:50:53 UTC (rev 154984)
+++ trunk/Source/WebKit/qt/WebCoreSupport/TextureMapperLayerClientQt.cpp	2013-09-03 15:32:07 UTC (rev 154985)
@@ -104,7 +104,14 @@
 return;
 
 m_textureMapper-setGraphicsContext(context);
-m_textureMapper-setImageInterpolationQuality(context-imageInterpolationQuality());
+// GraphicsContext::imageInterpolationQuality is always InterpolationDefault here,
+// but 'default' may be interpreted differently due to a different backend QPainter,
+// so we need to set an explicit imageInterpolationQuality.
+if (context-platformContext()-renderHints()  QPainter::SmoothPixmapTransform)
+m_textureMapper-setImageInterpolationQuality(WebCore::InterpolationMedium);
+else
+m_textureMapper-setImageInterpolationQuality(WebCore::InterpolationNone);
+
 m_textureMapper-setTextDrawingMode(context-textDrawingMode());
 QPainter* painter = context-platformContext();
 const QTransform transform = painter-worldTransform();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154999] trunk/Websites/webkit.org

[benjamin]

Title: [154999] trunk/Websites/webkit.org








Revision 154999
Author benja...@webkit.org
Date 2013-09-03 14:36:32 -0700 (Tue, 03 Sep 2013)


Log Message
Fix the recommended testing platform on the website

Rubberstamped by Enrica Casucci.

* quality/testing.html:

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/quality/testing.html




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (154998 => 154999)

--- trunk/Websites/webkit.org/ChangeLog	2013-09-03 20:16:29 UTC (rev 154998)
+++ trunk/Websites/webkit.org/ChangeLog	2013-09-03 21:36:32 UTC (rev 154999)
@@ -1,3 +1,11 @@
+2013-09-03  Benjamin Poulain  benja...@webkit.org
+
+Fix the recommended testing platform on the website
+
+Rubberstamped by Enrica Casucci.
+
+* quality/testing.html:
+
 2013-08-08  Benjamin Poulain  bpoul...@apple.com
 
 Fix webkit.org content overflowing their content box


Modified: trunk/Websites/webkit.org/quality/testing.html (154998 => 154999)

--- trunk/Websites/webkit.org/quality/testing.html	2013-09-03 20:16:29 UTC (rev 154998)
+++ trunk/Websites/webkit.org/quality/testing.html	2013-09-03 21:36:32 UTC (rev 154999)
@@ -14,7 +14,7 @@
 differences are found, then the patch has passed the tests.  If any tests fail, then the patch cannot be committed until the
 discrepancies in the tests are resolved./p
 
-pRegression tests must be run on Leopard, since the expected results checked in were generated on Leopard./p
+pRegression tests must be run on the latest released version of Mac OS X, since that is were the expected results are generated./p
 
 
 h3The _javascript_Core Tests/h3






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155000] trunk/Tools

[ap]

Title: [155000] trunk/Tools








Revision 155000
Author a...@apple.com
Date 2013-09-03 14:47:45 -0700 (Tue, 03 Sep 2013)


Log Message
[Mac] WebKitTestRunner still beeps sometimes
https://bugs.webkit.org/show_bug.cgi?id=120652

Reviewed by Tim Horton.

In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
UI process (notably, AppKit beeps when handling a key equivalent returns NO).

* WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
Use the same SPI that we use in DRT and in WebProcess to disable beeping.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm




Diff

Modified: trunk/Tools/ChangeLog (154999 => 155000)

--- trunk/Tools/ChangeLog	2013-09-03 21:36:32 UTC (rev 154999)
+++ trunk/Tools/ChangeLog	2013-09-03 21:47:45 UTC (rev 155000)
@@ -1,3 +1,16 @@
+2013-09-03  Alexey Proskuryakov  a...@apple.com
+
+[Mac] WebKitTestRunner still beeps sometimes
+https://bugs.webkit.org/show_bug.cgi?id=120652
+
+Reviewed by Tim Horton.
+
+In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
+UI process (notably, AppKit beeps when handling a key equivalent returns NO).
+
+* WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
+Use the same SPI that we use in DRT and in WebProcess to disable beeping.
+
 2013-09-03  Krzysztof Czech  k.cz...@samsung.com
 
 [AX][ATK] Added support for sort and help attributes


Modified: trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm (154999 => 155000)

--- trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm	2013-09-03 21:36:32 UTC (rev 154999)
+++ trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm	2013-09-03 21:47:45 UTC (rev 155000)
@@ -32,6 +32,10 @@
 #import WebKit2/WKStringCF.h
 #import mach-o/dyld.h 
 
+@interface NSSound (Details)
++ (void)_setAlertType:(NSUInteger)alertType;
+@end
+
 namespace WTR {
 
 void TestController::notifyDone()
@@ -42,6 +46,8 @@
 {
 poseAsClass(WebKitTestRunnerPasteboard, NSPasteboard);
 poseAsClass(WebKitTestRunnerEvent, NSEvent);
+
+[NSSound _setAlertType:0];
 }
 
 void TestController::platformDestroy()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155014] trunk

[enrica]

Title: [155014] trunk








Revision 155014
Author enr...@apple.com
Date 2013-09-03 18:13:08 -0700 (Tue, 03 Sep 2013)


Log Message
Can't select Katakana word by double-clicking.
rdar://problem/14654926

Reviewed by Alexey Proskuryakov and Ryosuke Niwa.

Source/WebCore: 

For some languages, like Japanese we need
to use more context for word breaking.

New test: editing/selection/doubleclick-japanese-text.html

* platform/text/TextBoundaries.h:
(WebCore::requiresContextForWordBoundary):

Source/WTF: 

For some languages, like Japanese we need
to use more context for word breaking.
I've renamed the function to better reflect its use
and remove the unused hasLineBreakingPropertyComplexContextOrIdeographic.

* wtf/unicode/icu/UnicodeIcu.h:
(WTF::Unicode::requiresComplexContextForWordBreaking):

LayoutTests: 

Added new test for this scenario.

* editing/selection/doubleclick-japanese-text-expected.txt: Added.
* editing/selection/doubleclick-japanese-text.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/unicode/icu/UnicodeIcu.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/TextBoundaries.h


Added Paths

trunk/LayoutTests/editing/selection/doubleclick-japanese-text-expected.txt
trunk/LayoutTests/editing/selection/doubleclick-japanese-text.html




Diff

Modified: trunk/LayoutTests/ChangeLog (155013 => 155014)

--- trunk/LayoutTests/ChangeLog	2013-09-04 00:26:57 UTC (rev 155013)
+++ trunk/LayoutTests/ChangeLog	2013-09-04 01:13:08 UTC (rev 155014)
@@ -1,3 +1,15 @@
+2013-09-03  Enrica Casucci  enr...@apple.com
+
+Can't select Katakana word by double-clicking.
+rdar://problem/14654926
+
+Reviewed by Alexey Proskuryakov and Ryosuke Niwa.
+
+Added new test for this scenario.
+
+* editing/selection/doubleclick-japanese-text-expected.txt: Added.
+* editing/selection/doubleclick-japanese-text.html: Added.
+
 2013-09-03  Benjamin Poulain  benja...@webkit.org
 
 Try unskipping compositing/images/positioned-image-content-rect.html


Added: trunk/LayoutTests/editing/selection/doubleclick-japanese-text-expected.txt (0 => 155014)

--- trunk/LayoutTests/editing/selection/doubleclick-japanese-text-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/doubleclick-japanese-text-expected.txt	2013-09-04 01:13:08 UTC (rev 155014)
@@ -0,0 +1,10 @@
+This tests that double-clicking on Japanese text.
+
+例えばオーストラリア
+Passed for offset 55
+Passed for offset 70
+Passed for offset 85
+Passed for offset 100
+Passed for offset 115
+Passed for offset 130
+


Added: trunk/LayoutTests/editing/selection/doubleclick-japanese-text.html (0 => 155014)

--- trunk/LayoutTests/editing/selection/doubleclick-japanese-text.html	(rev 0)
+++ trunk/LayoutTests/editing/selection/doubleclick-japanese-text.html	2013-09-04 01:13:08 UTC (rev 155014)
@@ -0,0 +1,88 @@
+?xml version=1.0 encoding=UTF-8?
+!DOCTYPE html
+html xmlns=http://www.w3.org/1999/xhtml
+head
+script
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+function getPositionOfNode(id)
+{
+var n = document.getElementById(id);
+var pos = {x: 0, y: 0};
+
+while (n) {
+pos.x += n.offsetLeft + n.clientLeft;
+pos.y += n.offsetTop + n.clientTop;
+n = n.offsetParent;
+}
+return pos;
+}
+
+function doubleClickNode(id, offset)
+{
+var pos = getPositionOfNode(id);
+eventSender.mouseMoveTo(pos.x + offset, pos.y + 2);
+eventSender.mouseDown();
+eventSender.leapForward(1);
+eventSender.mouseUp();
+eventSender.leapForward(100);
+eventSender.mouseDown();
+eventSender.leapForward(1);
+eventSender.mouseUp();
+}
+
+function doTest(testId, offset, expectedText)
+{
+// Simulate a double click.
+doubleClickNode(testId, offset);
+
+// Get the text of the current selection.
+var sel = window.getSelection();
+var actualText = sel.getRangeAt(0).toString();
+
+if (expectedText == actualText) {
+log(Passed for offset  + offset);
+} else {
+log(Failed for offset  + offset);
+log(  Expected:  + expectedText);
+log(  Actual:  + actualText);
+}
+
+}
+
+function runTests()
+{
+if (window.testRunner) {
+doTest(test1, 55, オーストラリア);
+doTest(test1, 70, オーストラリア);
+doTest(test1, 85, オーストラリア);
+doTest(test1, 100, オーストラリア);
+doTest(test1, 115, オーストラリア);
+doTest(test1, 130, オーストラリア);
+}
+}
+
+function log(msg)
+{
+var l = document.getElementById('log');
+l.appendChild(document.createTextNode(msg));
+l.appendChild(document.createElement('br'));
+}
+
+/script
+/head
+body _onload_=runTests()
+p
+This tests that double-clicking on Japanese text.
+/p
+
+div
+span id=test1例えばオーストラリア/span
+/div
+
+pre id=log
+/pre
+
+/body
+/html


Modified: trunk/Source/WTF/ChangeLog (155013 => 155014)

--- trunk/Source/WTF/ChangeLog	2013-09-04 00:26:57 UTC 

[webkit-changes] [154987] trunk/Source/WebKit2

[commit-queue]

Title: [154987] trunk/Source/WebKit2








Revision 154987
Author commit-qu...@webkit.org
Date 2013-09-03 09:51:03 -0700 (Tue, 03 Sep 2013)


Log Message
[GTK] [WK2] TestContextMenu default-menu fails
https://bugs.webkit.org/show_bug.cgi?id=120459

Patch by Brian Holt brian.h...@samsung.com on 2013-09-03
Reviewed by Gustavo Noronha Silva.

Add context menu items for downloading media elements.

* UIProcess/API/gtk/WebKitContextMenuActions.cpp:
(webkitContextMenuActionGetActionTag):
(webkitContextMenuActionGetForContextMenuItem):
(webkitContextMenuActionGetLabel):
* UIProcess/API/gtk/WebKitContextMenuActions.h:
* UIProcess/API/gtk/tests/TestContextMenu.cpp:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.h
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (154986 => 154987)

--- trunk/Source/WebKit2/ChangeLog	2013-09-03 16:39:29 UTC (rev 154986)
+++ trunk/Source/WebKit2/ChangeLog	2013-09-03 16:51:03 UTC (rev 154987)
@@ -1,3 +1,19 @@
+2013-09-03  Brian Holt  brian.h...@samsung.com
+
+[GTK] [WK2] TestContextMenu default-menu fails
+https://bugs.webkit.org/show_bug.cgi?id=120459
+
+Reviewed by Gustavo Noronha Silva.
+
+Add context menu items for downloading media elements.
+
+* UIProcess/API/gtk/WebKitContextMenuActions.cpp:
+(webkitContextMenuActionGetActionTag):
+(webkitContextMenuActionGetForContextMenuItem):
+(webkitContextMenuActionGetLabel):
+* UIProcess/API/gtk/WebKitContextMenuActions.h:
+* UIProcess/API/gtk/tests/TestContextMenu.cpp:
+
 2013-09-02  Darin Adler  da...@apple.com
 
 Cut down on double hashing and code needlessly using hash table iterators


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.cpp (154986 => 154987)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.cpp	2013-09-03 16:39:29 UTC (rev 154986)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.cpp	2013-09-03 16:51:03 UTC (rev 154987)
@@ -123,6 +123,9 @@
 return ContextMenuItemTagMediaPlayPause;
 case WEBKIT_CONTEXT_MENU_ACTION_MEDIA_MUTE:
 return ContextMenuItemTagMediaMute;
+case WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK:
+case WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_AUDIO_TO_DISK:
+return ContextMenuItemTagDownloadMediaToDisk;
 case WEBKIT_CONTEXT_MENU_ACTION_CUSTOM:
 return ContextMenuItemBaseApplicationTag;
 default:
@@ -214,6 +217,9 @@
 WEBKIT_CONTEXT_MENU_ACTION_MEDIA_PLAY : WEBKIT_CONTEXT_MENU_ACTION_MEDIA_PAUSE;
 case ContextMenuItemTagMediaMute:
 return WEBKIT_CONTEXT_MENU_ACTION_MEDIA_MUTE;
+case ContextMenuItemTagDownloadMediaToDisk:
+return menuItem-title() == contextMenuItemTagDownloadVideoToDisk() ?
+WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK : WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_AUDIO_TO_DISK;
 case ContextMenuItemBaseApplicationTag:
 return WEBKIT_CONTEXT_MENU_ACTION_CUSTOM;
 default:
@@ -306,6 +312,10 @@
 return contextMenuItemTagMediaPause();
 case WEBKIT_CONTEXT_MENU_ACTION_MEDIA_MUTE:
 return contextMenuItemTagMediaMute();
+case WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK:
+return contextMenuItemTagDownloadVideoToDisk();
+case WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_AUDIO_TO_DISK:
+return contextMenuItemTagDownloadAudioToDisk();
 case WEBKIT_CONTEXT_MENU_ACTION_NO_ACTION:
 case WEBKIT_CONTEXT_MENU_ACTION_CUSTOM:
 case WEBKIT_CONTEXT_MENU_ACTION_SPELLING_GUESS:


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.h (154986 => 154987)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.h	2013-09-03 16:39:29 UTC (rev 154986)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.h	2013-09-03 16:51:03 UTC (rev 154987)
@@ -72,6 +72,8 @@
  * @WEBKIT_CONTEXT_MENU_ACTION_MEDIA_PLAY: Play current media element.
  * @WEBKIT_CONTEXT_MENU_ACTION_MEDIA_PAUSE: Pause current media element.
  * @WEBKIT_CONTEXT_MENU_ACTION_MEDIA_MUTE: Mute current media element.
+ * @WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK: Download video to disk.
+ * @WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_AUDIO_TO_DISK: Download audio to disk.
  * @WEBKIT_CONTEXT_MENU_ACTION_CUSTOM: Custom action defined by applications.
  *
  * Enum values used to denote the stock actions for
@@ -121,6 +123,8 @@
 WEBKIT_CONTEXT_MENU_ACTION_MEDIA_PLAY,
 WEBKIT_CONTEXT_MENU_ACTION_MEDIA_PAUSE,
 WEBKIT_CONTEXT_MENU_ACTION_MEDIA_MUTE,
+WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK,
+WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_AUDIO_TO_DISK,
 
 WEBKIT_CONTEXT_MENU_ACTION_CUSTOM = 1
 } WebKitContextMenuAction;


Modified: 

[webkit-changes] [154988] trunk/Source/WebCore

[commit-queue]

Title: [154988] trunk/Source/WebCore








Revision 154988
Author commit-qu...@webkit.org
Date 2013-09-03 09:51:19 -0700 (Tue, 03 Sep 2013)


Log Message
[GStreamer] Don't set state to NULL until element is destroyed
https://bugs.webkit.org/show_bug.cgi?id=117354

Patch by Andre Moreira Magalhaes andre.magalh...@collabora.co.uk on 2013-09-03
Reviewed by Philippe Normand.

Don't set playbin to NULL until it is going to be destroyed or if we stay
for too long on the READY state. Instead only set the state to READY as this
allows much faster state changes to PAUSED/PLAYING again. playbin internally
caches some state that is destroyed when setting it to NULL.
This state is independent of the URI and it is even possible to change the
URI in READY state.

To avoid having resources (e.g. audio devices) open indefinitely,
when setting the state to READY we create a timeout and if the timeout
is reached we reset the pipeline state to NULL to free resources.

Also now all state changes use the changePipelineState method instead of setting
the playbin state directly with gst_element_set_state, so we have a better control
of when we are requesting state changes.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateReadyStateTimeoutCallback):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::commitLoad):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::handlePluginInstallerResult):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (154987 => 154988)

--- trunk/Source/WebCore/ChangeLog	2013-09-03 16:51:03 UTC (rev 154987)
+++ trunk/Source/WebCore/ChangeLog	2013-09-03 16:51:19 UTC (rev 154988)
@@ -1,3 +1,35 @@
+2013-09-03  Andre Moreira Magalhaes   andre.magalh...@collabora.co.uk
+
+[GStreamer] Don't set state to NULL until element is destroyed
+https://bugs.webkit.org/show_bug.cgi?id=117354
+
+Reviewed by Philippe Normand.
+
+Don't set playbin to NULL until it is going to be destroyed or if we stay
+for too long on the READY state. Instead only set the state to READY as this
+allows much faster state changes to PAUSED/PLAYING again. playbin internally
+caches some state that is destroyed when setting it to NULL.
+This state is independent of the URI and it is even possible to change the
+URI in READY state.
+
+To avoid having resources (e.g. audio devices) open indefinitely,
+when setting the state to READY we create a timeout and if the timeout
+is reached we reset the pipeline state to NULL to free resources.
+
+Also now all state changes use the changePipelineState method instead of setting
+the playbin state directly with gst_element_set_state, so we have a better control
+of when we are requesting state changes.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::mediaPlayerPrivateReadyStateTimeoutCallback):
+(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
+(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
+(WebCore::MediaPlayerPrivateGStreamer::commitLoad):
+(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
+(WebCore::MediaPlayerPrivateGStreamer::setRate):
+(WebCore::MediaPlayerPrivateGStreamer::handlePluginInstallerResult):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
+
 2013-09-03  pe...@outlook.com  pe...@outlook.com
 
 [WinCairo] Unneeded code in method GlyphPage::fill().


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (154987 => 154988)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2013-09-03 16:51:03 UTC (rev 154987)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2013-09-03 16:51:19 UTC (rev 154988)
@@ -81,6 +81,9 @@
 static const char* gPlaybinName = playbin2;
 static const gint64 gPercentMax = 100;
 #endif
+// Max interval in seconds to stay in the READY state on manual
+// state change requests.
+static const guint gReadyStateTimerInterval = 60;
 
 GST_DEBUG_CATEGORY_EXTERN(webkit_media_player_debug);
 #define GST_CAT_DEFAULT webkit_media_player_debug
@@ -158,6 +161,14 @@
 }
 #endif
 
+static gboolean mediaPlayerPrivateReadyStateTimeoutCallback(MediaPlayerPrivateGStreamer* player)
+{
+// This is the callback of the timeout source created in ::changePipelineState.

[webkit-changes] [154990] trunk/Source/WTF

[mikhail . pozdnyakov]

Title: [154990] trunk/Source/WTF








Revision 154990
Author mikhail.pozdnya...@intel.com
Date 2013-09-03 10:33:22 -0700 (Tue, 03 Sep 2013)


Log Message
Check WTF::VectorFiller template argument type size in compile time
https://bugs.webkit.org/show_bug.cgi?id=120631

Reviewed by Darin Adler.

The template argument's type size in WTF::VectorFiller 'memset' specialization
should be checked during compilation rather than in runtime.

* wtf/Vector.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Vector.h




Diff

Modified: trunk/Source/WTF/ChangeLog (154989 => 154990)

--- trunk/Source/WTF/ChangeLog	2013-09-03 17:08:13 UTC (rev 154989)
+++ trunk/Source/WTF/ChangeLog	2013-09-03 17:33:22 UTC (rev 154990)
@@ -1,3 +1,15 @@
+2013-09-03  Mikhail Pozdnyakov  mikhail.pozdnya...@intel.com
+
+Check WTF::VectorFiller template argument type size in compile time
+https://bugs.webkit.org/show_bug.cgi?id=120631
+
+Reviewed by Darin Adler.
+
+The template argument's type size in WTF::VectorFiller 'memset' specialization
+should be checked during compilation rather than in runtime.
+
+* wtf/Vector.h:
+
 2013-09-02  Darin Adler  da...@apple.com
 
 Cut down on double hashing and code needlessly using hash table iterators


Modified: trunk/Source/WTF/wtf/Vector.h (154989 => 154990)

--- trunk/Source/WTF/wtf/Vector.h	2013-09-03 17:08:13 UTC (rev 154989)
+++ trunk/Source/WTF/wtf/Vector.h	2013-09-03 17:33:22 UTC (rev 154990)
@@ -174,7 +174,7 @@
 {
 static void uninitializedFill(T* dst, T* dstEnd, const T val) 
 {
-ASSERT(sizeof(T) == sizeof(char));
+COMPILE_ASSERT(sizeof(T) == sizeof(char), Size_of_type_should_be_equal_to_one);
 #if COMPILER(GCC)  defined(_FORTIFY_SOURCE)
 if (!__builtin_constant_p(dstEnd - dst) || (!(dstEnd - dst)))
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155015] trunk/Source/WebCore

[darin]

Title: [155015] trunk/Source/WebCore








Revision 155015
Author da...@apple.com
Date 2013-09-03 19:46:10 -0700 (Tue, 03 Sep 2013)


Log Message
Fix backwards branch in ~Node from r154967
https://bugs.webkit.org/show_bug.cgi?id=120659

Reviewed by Andreas Kling.

* dom/Node.cpp:
(WebCore::Node::~Node): Fix backwards branch. The old code ran the code only
when we did not remove the item from the table. I removed a ! from this _expression_
after review; bad idea.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (155014 => 155015)

--- trunk/Source/WebCore/ChangeLog	2013-09-04 01:13:08 UTC (rev 155014)
+++ trunk/Source/WebCore/ChangeLog	2013-09-04 02:46:10 UTC (rev 155015)
@@ -1,3 +1,15 @@
+2013-09-03  Darin Adler  da...@apple.com
+
+Fix backwards branch in ~Node from r154967
+https://bugs.webkit.org/show_bug.cgi?id=120659
+
+Reviewed by Andreas Kling.
+
+* dom/Node.cpp:
+(WebCore::Node::~Node): Fix backwards branch. The old code ran the code only
+when we did not remove the item from the table. I removed a ! from this _expression_
+after review; bad idea.
+
 2013-09-03  Enrica Casucci  enr...@apple.com
 
 Can't select Katakana word by double-clicking.


Modified: trunk/Source/WebCore/dom/Node.cpp (155014 => 155015)

--- trunk/Source/WebCore/dom/Node.cpp	2013-09-04 01:13:08 UTC (rev 155014)
+++ trunk/Source/WebCore/dom/Node.cpp	2013-09-04 02:46:10 UTC (rev 155015)
@@ -336,7 +336,7 @@
 Node::~Node()
 {
 #ifndef NDEBUG
-if (ignoreSet.remove(this))
+if (!ignoreSet.remove(this))
 nodeCounter.decrement();
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155017] trunk/Source/WebKit2

[darin]

Title: [155017] trunk/Source/WebKit2








Revision 155017
Author da...@apple.com
Date 2013-09-03 21:27:57 -0700 (Tue, 03 Sep 2013)


Log Message
REGRESSION (r154967) window resize is very choppy
https://bugs.webkit.org/show_bug.cgi?id=120653

Reviewed by Andreas Kling.

Andreas Kling spotted the bad change.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::waitForMessage): Roll out this incorrect change.
The code here is not the same as a call to take.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (155016 => 155017)

--- trunk/Source/WebKit2/ChangeLog	2013-09-04 03:34:13 UTC (rev 155016)
+++ trunk/Source/WebKit2/ChangeLog	2013-09-04 04:27:57 UTC (rev 155017)
@@ -1,3 +1,16 @@
+2013-09-03  Darin Adler  da...@apple.com
+
+REGRESSION (r154967) window resize is very choppy
+https://bugs.webkit.org/show_bug.cgi?id=120653
+
+Reviewed by Andreas Kling.
+
+Andreas Kling spotted the bad change.
+
+* Platform/CoreIPC/Connection.cpp:
+(CoreIPC::Connection::waitForMessage): Roll out this incorrect change.
+The code here is not the same as a call to take.
+
 2013-09-03  Anton Obzhirov  a.obzhi...@samsung.com
 
 [GTK] gdk threads deprecated functions calls should be refactored


Modified: trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp (155016 => 155017)

--- trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp	2013-09-04 03:34:13 UTC (rev 155016)
+++ trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp	2013-09-04 04:27:57 UTC (rev 155017)
@@ -417,8 +417,13 @@
 while (true) {
 MutexLocker locker(m_waitForMessageMutex);
 
-if (OwnPtrMessageDecoder decoder = m_waitForMessageMap.take(messageAndDestination))
+HashMapstd::pairstd::pairStringReference, StringReference, uint64_t, OwnPtrMessageDecoder::iterator it = m_waitForMessageMap.find(messageAndDestination);
+if (it-value) {
+OwnPtrMessageDecoder decoder = it-value.release();
+m_waitForMessageMap.remove(it);
+
 return decoder.release();
+}
 
 // Now we wait.
 if (!m_waitForMessageCondition.timedWait(m_waitForMessageMutex, absoluteTime)) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155018] trunk/Source/WebCore

[akling]

Title: [155018] trunk/Source/WebCore








Revision 155018
Author akl...@apple.com
Date 2013-09-03 21:49:23 -0700 (Tue, 03 Sep 2013)


Log Message
ASSERTION FAILED: frame().view() == this closing a page with SVG or video
https://webkit.org/b/120645

Reviewed by Antti Koivisto.

Have RenderSVGResourceContainer check if the document is being destroyed before
triggering any repaints. This replaces the previous check for a null RenderView
which meant basically the same thing.

We could add more and better assertions to catch unnecessary work during tree
teardown, but let's do that separately.

* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markClientForInvalidation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (155017 => 155018)

--- trunk/Source/WebCore/ChangeLog	2013-09-04 04:27:57 UTC (rev 155017)
+++ trunk/Source/WebCore/ChangeLog	2013-09-04 04:49:23 UTC (rev 155018)
@@ -1,3 +1,20 @@
+2013-09-03  Andreas Kling  akl...@apple.com
+
+ASSERTION FAILED: frame().view() == this closing a page with SVG or video
+https://webkit.org/b/120645
+
+Reviewed by Antti Koivisto.
+
+Have RenderSVGResourceContainer check if the document is being destroyed before
+triggering any repaints. This replaces the previous check for a null RenderView
+which meant basically the same thing.
+
+We could add more and better assertions to catch unnecessary work during tree
+teardown, but let's do that separately.
+
+* rendering/svg/RenderSVGResourceContainer.cpp:
+(WebCore::RenderSVGResourceContainer::markClientForInvalidation):
+
 2013-09-03  Gyuyoung Kim  gyuyoung@samsung.com
 
 Fix uninitialized build warning in make_names.pl


Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp (155017 => 155018)

--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp	2013-09-04 04:27:57 UTC (rev 155017)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp	2013-09-04 04:49:23 UTC (rev 155018)
@@ -139,7 +139,8 @@
 client-setNeedsBoundariesUpdate();
 break;
 case RepaintInvalidation:
-client-repaint();
+if (!client-documentBeingDestroyed())
+client-repaint();
 break;
 case ParentOnlyInvalidation:
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155019] trunk/Source/WebCore

[darin]

Title: [155019] trunk/Source/WebCore








Revision 155019
Author da...@apple.com
Date 2013-09-03 21:53:23 -0700 (Tue, 03 Sep 2013)


Log Message
Change type of Document::doctype back to a raw pointer
https://bugs.webkit.org/show_bug.cgi?id=120617

Reviewed by Andreas Kling.

* dom/Document.cpp:
(WebCore::Document::doctype): Return a raw pointer.
(WebCore::Document::childrenChanged): Use the raw pointer.
Also added a FIXME about this code that is probably in the wrong place.
* dom/Document.h: More of the same.

* editing/markup.cpp:
(WebCore::documentTypeString): Get rid of local variable entirely,
since null is already handled right by createMarkup, and also remove
the call to get since doctype is just a raw pointer.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/editing/markup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (155018 => 155019)

--- trunk/Source/WebCore/ChangeLog	2013-09-04 04:49:23 UTC (rev 155018)
+++ trunk/Source/WebCore/ChangeLog	2013-09-04 04:53:23 UTC (rev 155019)
@@ -1,3 +1,21 @@
+2013-09-03  Darin Adler  da...@apple.com
+
+Change type of Document::doctype back to a raw pointer
+https://bugs.webkit.org/show_bug.cgi?id=120617
+
+Reviewed by Andreas Kling.
+
+* dom/Document.cpp:
+(WebCore::Document::doctype): Return a raw pointer.
+(WebCore::Document::childrenChanged): Use the raw pointer.
+Also added a FIXME about this code that is probably in the wrong place.
+* dom/Document.h: More of the same.
+
+* editing/markup.cpp:
+(WebCore::documentTypeString): Get rid of local variable entirely,
+since null is already handled right by createMarkup, and also remove
+the call to get since doctype is just a raw pointer.
+
 2013-09-03  Andreas Kling  akl...@apple.com
 
 ASSERTION FAILED: frame().view() == this closing a page with SVG or video


Modified: trunk/Source/WebCore/dom/Document.cpp (155018 => 155019)

--- trunk/Source/WebCore/dom/Document.cpp	2013-09-04 04:49:23 UTC (rev 155018)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-09-04 04:53:23 UTC (rev 155019)
@@ -756,7 +756,7 @@
 return documentElement()  documentElement()-hasTagName(htmlTag)  documentElement()-hasAttribute(manifestAttr);
 }
 
-PassRefPtrDocumentType Document::doctype() const
+DocumentType* Document::doctype() const
 {
 for (Node* node = firstChild(); node; node = node-nextSibling()) {
 if (node-isDocumentTypeNode())
@@ -772,7 +772,11 @@
 // NOTE: Per DOM, dynamically inserting/removing doctype nodes doesn't affect compatibility mode.
 
 #if ENABLE(LEGACY_VIEWPORT_ADAPTION)
-if (RefPtrDocumentType documentType = doctype()) {
+// FIXME: It's a little strange to add these rules when a DocumentType with this prefix is added,
+// but not remove these rules when a DocumentType with this prefix is removed. It seems this should
+// be handled more the way the compatibility mode is, by fetching the doctype at the appropriate time,
+// rather than by responding when a document type node is inserted.
+if (DocumentType* documentType = doctype()) {
 if (documentType-publicId().startsWith(-//wapforum//dtd xhtml mobile 1., /* caseSensitive */ false))
 processViewport(width=device-width, height=device-height, ViewportArguments::XHTMLMobileProfile);
 }


Modified: trunk/Source/WebCore/dom/Document.h (155018 => 155019)

--- trunk/Source/WebCore/dom/Document.h	2013-09-04 04:49:23 UTC (rev 155018)
+++ trunk/Source/WebCore/dom/Document.h	2013-09-04 04:53:23 UTC (rev 155019)
@@ -327,7 +327,7 @@
 void setReferrerPolicy(ReferrerPolicy referrerPolicy) { m_referrerPolicy = referrerPolicy; }
 ReferrerPolicy referrerPolicy() const { return m_referrerPolicy; }
 
-PassRefPtrDocumentType doctype() const;
+DocumentType* doctype() const;
 
 DOMImplementation* implementation();
 


Modified: trunk/Source/WebCore/editing/markup.cpp (155018 => 155019)

--- trunk/Source/WebCore/editing/markup.cpp	2013-09-04 04:49:23 UTC (rev 155018)
+++ trunk/Source/WebCore/editing/markup.cpp	2013-09-04 04:53:23 UTC (rev 155019)
@@ -926,11 +926,7 @@
 
 String documentTypeString(const Document document)
 {
-RefPtrDocumentType documentType = document.doctype();
-if (!documentType)
-return String();
-
-return createMarkup(documentType.get());
+return createMarkup(document.doctype());
 }
 
 String createFullMarkup(const Node* node)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155020] trunk/Source/WTF

[enrica]

Title: [155020] trunk/Source/WTF








Revision 155020
Author enr...@apple.com
Date 2013-09-03 22:06:08 -0700 (Tue, 03 Sep 2013)


Log Message
Follow up to http://trac.webkit.org/changeset/155014

Reviewed by Alexey Proskuryakov.

In the r155014 I renamed hasLineBreakingPropertyComplexContext
to requiresComplexContextForWordBreaking but forgot to
make the same change in UnicodeWchar.h.

* wtf/unicode/wchar/UnicodeWchar.cpp:
(WTF::Unicode::requiresComplexContextForWordBreaking):
* wtf/unicode/wchar/UnicodeWchar.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/unicode/wchar/UnicodeWchar.cpp
trunk/Source/WTF/wtf/unicode/wchar/UnicodeWchar.h




Diff

Modified: trunk/Source/WTF/ChangeLog (155019 => 155020)

--- trunk/Source/WTF/ChangeLog	2013-09-04 04:53:23 UTC (rev 155019)
+++ trunk/Source/WTF/ChangeLog	2013-09-04 05:06:08 UTC (rev 155020)
@@ -1,5 +1,19 @@
 2013-09-03  Enrica Casucci  enr...@apple.com
 
+Follow up to http://trac.webkit.org/changeset/155014
+
+Reviewed by Alexey Proskuryakov.
+
+In the r155014 I renamed hasLineBreakingPropertyComplexContext
+to requiresComplexContextForWordBreaking but forgot to
+make the same change in UnicodeWchar.h.
+
+* wtf/unicode/wchar/UnicodeWchar.cpp:
+(WTF::Unicode::requiresComplexContextForWordBreaking):
+* wtf/unicode/wchar/UnicodeWchar.h:
+
+2013-09-03  Enrica Casucci  enr...@apple.com
+
 Can't select Katakana word by double-clicking.
 rdar://problem/14654926
 


Modified: trunk/Source/WTF/wtf/unicode/wchar/UnicodeWchar.cpp (155019 => 155020)

--- trunk/Source/WTF/wtf/unicode/wchar/UnicodeWchar.cpp	2013-09-04 04:53:23 UTC (rev 155019)
+++ trunk/Source/WTF/wtf/unicode/wchar/UnicodeWchar.cpp	2013-09-04 05:06:08 UTC (rev 155020)
@@ -50,7 +50,7 @@
 return DecompositionNone; // FIXME: implement!
 }
 
-bool hasLineBreakingPropertyComplexContext(UChar32)
+bool requiresComplexContextForWordBreaking(UChar32)
 {
 return false; // FIXME: implement!
 }


Modified: trunk/Source/WTF/wtf/unicode/wchar/UnicodeWchar.h (155019 => 155020)

--- trunk/Source/WTF/wtf/unicode/wchar/UnicodeWchar.h	2013-09-04 04:53:23 UTC (rev 155019)
+++ trunk/Source/WTF/wtf/unicode/wchar/UnicodeWchar.h	2013-09-04 05:06:08 UTC (rev 155020)
@@ -125,7 +125,7 @@
 WTF_EXPORT_PRIVATE unsigned char combiningClass(UChar32);
 WTF_EXPORT_PRIVATE Direction direction(UChar32);
 WTF_EXPORT_PRIVATE DecompositionType decompositionType(UChar32);
-WTF_EXPORT_PRIVATE bool hasLineBreakingPropertyComplexContext(UChar32);
+WTF_EXPORT_PRIVATE bool requiresComplexContextForWordBreaking(UChar32);
 WTF_EXPORT_PRIVATE UChar32 mirroredChar(UChar32);
 
 inline bool isAlphanumeric(UChar c) { return !!iswalnum(c); }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155021] trunk/Source

[fpizlo]

Title: [155021] trunk/Source








Revision 155021
Author fpi...@apple.com
Date 2013-09-03 22:48:06 -0700 (Tue, 03 Sep 2013)


Log Message
CodeBlock memory cost reporting should be rationalized
https://bugs.webkit.org/show_bug.cgi?id=120615

Source/_javascript_Core: 

Reviewed by Darin Adler.

Report the size of the instruction stream, and then remind the GC that we're
using memory when we trace.

This is a slight slow-down on some JSBench tests because it makes us GC a
bit more frequently. But I think it's well worth it; if we really want those
tests to GC less frequently then we can achieve that through other kinds of
tuning. It's better that the GC knows that CodeBlocks do in fact use memory;
what it does with that information is a somewhat orthogonal question.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):

Source/WTF: 

Reviewed by Darin Adler.

* wtf/RefCountedArray.h:
(WTF::RefCountedArray::refCount):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/RefCountedArray.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (155020 => 155021)

--- trunk/Source/_javascript_Core/ChangeLog	2013-09-04 05:06:08 UTC (rev 155020)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-09-04 05:48:06 UTC (rev 155021)
@@ -1,3 +1,23 @@
+2013-09-03  Filip Pizlo  fpi...@apple.com
+
+CodeBlock memory cost reporting should be rationalized
+https://bugs.webkit.org/show_bug.cgi?id=120615
+
+Reviewed by Darin Adler.
+
+Report the size of the instruction stream, and then remind the GC that we're
+using memory when we trace.
+
+This is a slight slow-down on some JSBench tests because it makes us GC a
+bit more frequently. But I think it's well worth it; if we really want those
+tests to GC less frequently then we can achieve that through other kinds of
+tuning. It's better that the GC knows that CodeBlocks do in fact use memory;
+what it does with that information is a somewhat orthogonal question.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::CodeBlock):
+(JSC::CodeBlock::visitAggregate):
+
 2013-09-03  Mark Lam  mark@apple.com
 
 Converting StackIterator to a callback interface.


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (155020 => 155021)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2013-09-04 05:06:08 UTC (rev 155020)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2013-09-04 05:48:06 UTC (rev 155021)
@@ -1847,7 +1847,7 @@
 if (Options::dumpGeneratedBytecodes())
 dumpBytecode();
 m_heap-m_codeBlocks.add(this);
-m_heap-reportExtraMemoryCost(sizeof(CodeBlock));
+m_heap-reportExtraMemoryCost(sizeof(CodeBlock) + m_instructions.size() * sizeof(Instruction));
 }
 
 CodeBlock::~CodeBlock()
@@ -1931,6 +1931,17 @@
 if (!!m_alternative)
 m_alternative-visitAggregate(visitor);
 
+visitor.reportExtraMemoryUsage(sizeof(CodeBlock));
+if (m_jitCode)
+visitor.reportExtraMemoryUsage(m_jitCode-size());
+if (m_instructions.size()) {
+// Divide by refCount() because m_instructions points to something that is shared
+// by multiple CodeBlocks, and we only want to count it towards the heap size once.
+// Having each CodeBlock report only its proportional share of the size is one way
+// of accomplishing this.
+visitor.reportExtraMemoryUsage(m_instructions.size() * sizeof(Instruction) / m_instructions.refCount());
+}
+
 visitor.append(m_unlinkedCode);
 
 // There are three things that may use unconditional finalizers: lazy bytecode freeing,


Modified: trunk/Source/WTF/ChangeLog (155020 => 155021)

--- trunk/Source/WTF/ChangeLog	2013-09-04 05:06:08 UTC (rev 155020)
+++ trunk/Source/WTF/ChangeLog	2013-09-04 05:48:06 UTC (rev 155021)
@@ -1,3 +1,13 @@
+2013-09-03  Filip Pizlo  fpi...@apple.com
+
+CodeBlock memory cost reporting should be rationalized
+https://bugs.webkit.org/show_bug.cgi?id=120615
+
+Reviewed by Darin Adler.
+
+* wtf/RefCountedArray.h:
+(WTF::RefCountedArray::refCount):
+
 2013-09-03  Enrica Casucci  enr...@apple.com
 
 Follow up to http://trac.webkit.org/changeset/155014


Modified: trunk/Source/WTF/wtf/RefCountedArray.h (155020 => 155021)

--- trunk/Source/WTF/wtf/RefCountedArray.h	2013-09-04 05:06:08 UTC (rev 155020)
+++ trunk/Source/WTF/wtf/RefCountedArray.h	2013-09-04 05:48:06 UTC (rev 155021)
@@ -112,6 +112,13 @@
 fastFree(Header::fromPayload(m_data));
 }
 
+unsigned refCount() const
+{
+if (!m_data)
+return 0;
+return Header::fromPayload(m_data)-refCount;
+}
+
 size_t size() const
 {
 if (!m_data)






___