[webkit-changes] [155094] trunk/Source/WebCore
Title: [155094] trunk/Source/WebCore
Revision 155094
Author akl...@apple.com
Date 2013-09-04 23:20:09 -0700 (Wed, 04 Sep 2013)
Log Message
CachedPage construction should begin with a Page.
https://webkit.org/b/120721
Reviewed by Anders Carlsson.
We can't create a CachedPage from a null Page anyway.
* history/CachedPage.cpp:
(WebCore::CachedPage::create):
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
* history/CachedPage.h:
* history/PageCache.cpp:
(WebCore::PageCache::add):
* history/PageCache.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/CachedPage.cpp
trunk/Source/WebCore/history/CachedPage.h
trunk/Source/WebCore/history/PageCache.cpp
trunk/Source/WebCore/history/PageCache.h
trunk/Source/WebCore/loader/FrameLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155093 => 155094)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 06:05:16 UTC (rev 155093)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 06:20:09 UTC (rev 155094)
@@ -1,3 +1,23 @@
+2013-09-04 Andreas Kling akl...@apple.com
+
+CachedPage construction should begin with a Page.
+https://webkit.org/b/120721
+
+Reviewed by Anders Carlsson.
+
+We can't create a CachedPage from a null Page anyway.
+
+* history/CachedPage.cpp:
+(WebCore::CachedPage::create):
+(WebCore::CachedPage::CachedPage):
+(WebCore::CachedPage::restore):
+* history/CachedPage.h:
+* history/PageCache.cpp:
+(WebCore::PageCache::add):
+* history/PageCache.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::commitProvisionalLoad):
+
2013-09-04 Arpita Bahuguna a@samsung.com
setAttributeNode() does not set the new value to an existing attribute if specified attribute is in a different case.
Modified: trunk/Source/WebCore/history/CachedPage.cpp (155093 => 155094)
--- trunk/Source/WebCore/history/CachedPage.cpp 2013-09-05 06:05:16 UTC (rev 155093)
+++ trunk/Source/WebCore/history/CachedPage.cpp 2013-09-05 06:20:09 UTC (rev 155094)
@@ -45,15 +45,15 @@
DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, cachedPageCounter, (CachedPage));
-PassOwnPtrCachedPage CachedPage::create(Page* page)
+PassOwnPtrCachedPage CachedPage::create(Page page)
{
return adoptPtr(new CachedPage(page));
}
-CachedPage::CachedPage(Page* page)
+CachedPage::CachedPage(Page page)
: m_timeStamp(monotonicallyIncreasingTime())
-, m_expirationTime(m_timeStamp + page-settings().backForwardCacheExpirationInterval())
-, m_cachedMainFrame(CachedFrame::create(page-mainFrame()))
+, m_expirationTime(m_timeStamp + page.settings().backForwardCacheExpirationInterval())
+, m_cachedMainFrame(CachedFrame::create(page.mainFrame()))
, m_needStyleRecalcForVisitedLinks(false)
, m_needsFullStyleRecalc(false)
, m_needsCaptionPreferencesChanged(false)
@@ -74,37 +74,37 @@
ASSERT(!m_cachedMainFrame);
}
-void CachedPage::restore(Page* page)
+void CachedPage::restore(Page page)
{
ASSERT(m_cachedMainFrame);
-ASSERT(page page-frameIsMainFrame(m_cachedMainFrame-view()-frame()));
-ASSERT(!page-subframeCount());
+ASSERT(page.frameIsMainFrame(m_cachedMainFrame-view()-frame()));
+ASSERT(!page.subframeCount());
m_cachedMainFrame-open();
// Restore the focus appearance for the focused element.
// FIXME: Right now we don't support pages w/ frames in the b/f cache. This may need to be tweaked when we add support for that.
-Document* focusedDocument = page-focusController().focusedOrMainFrame().document();
+Document* focusedDocument = page.focusController().focusedOrMainFrame().document();
if (Element* element = focusedDocument-focusedElement())
element-updateFocusAppearance(true);
if (m_needStyleRecalcForVisitedLinks) {
-for (Frame* frame = page-mainFrame(); frame; frame = frame-tree().traverseNext())
+for (Frame* frame = page.mainFrame(); frame; frame = frame-tree().traverseNext())
frame-document()-visitedLinkState().invalidateStyleForAllLinks();
}
#if USE(ACCELERATED_COMPOSITING)
if (m_needsDeviceScaleChanged) {
-page-mainFrame().deviceOrPageScaleFactorChanged();
+page.mainFrame().deviceOrPageScaleFactorChanged();
}
#endif
if (m_needsFullStyleRecalc)
-page-setNeedsRecalcStyleInAllFrames();
+page.setNeedsRecalcStyleInAllFrames();
#if ENABLE(VIDEO_TRACK)
if (m_needsCaptionPreferencesChanged)
-page-captionPreferencesChanged();
+page.captionPreferencesChanged();
#endif
clear();
Modified: trunk/Source/WebCore/history/CachedPage.h (155093 => 155094)
--- trunk/Source/WebCore/history/CachedPage.h 2013-09-05 06:05:16 UTC (rev 155093)
+++ trunk/Source/WebCore/history/CachedPage.h 2013-09-05 06:20:09 UTC (rev 155094)
@@ -36,10 +36,10
[webkit-changes] [155095] trunk/Source/WebCore
Title: [155095] trunk/Source/WebCore
Revision 155095
Author g.czajkow...@samsung.com
Date 2013-09-04 23:29:50 -0700 (Wed, 04 Sep 2013)
Log Message
Remove deprecated markersForNode(Node* node).
https://bugs.webkit.org/show_bug.cgi?id=120679
Reviewed by Ryosuke Niwa.
DocumentMarkerController::markersForNode(Node* node) has been marked as
deprecated in favor of markersFor(Node*, MarkerTypes = AllMarkers()).
No new tests, no behavior change.
* dom/DocumentMarkerController.cpp:
* dom/DocumentMarkerController.h:
Remove never used markersForNode(Node*).
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DocumentMarkerController.cpp
trunk/Source/WebCore/dom/DocumentMarkerController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (155094 => 155095)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 06:20:09 UTC (rev 155094)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 06:29:50 UTC (rev 155095)
@@ -1,3 +1,19 @@
+2013-09-04 Grzegorz Czajkowski g.czajkow...@samsung.com
+
+Remove deprecated markersForNode(Node* node).
+https://bugs.webkit.org/show_bug.cgi?id=120679
+
+Reviewed by Ryosuke Niwa.
+
+DocumentMarkerController::markersForNode(Node* node) has been marked as
+deprecated in favor of markersFor(Node*, MarkerTypes = AllMarkers()).
+
+No new tests, no behavior change.
+
+* dom/DocumentMarkerController.cpp:
+* dom/DocumentMarkerController.h:
+Remove never used markersForNode(Node*).
+
2013-09-04 Andreas Kling akl...@apple.com
CachedPage construction should begin with a Page.
Modified: trunk/Source/WebCore/dom/DocumentMarkerController.cpp (155094 => 155095)
--- trunk/Source/WebCore/dom/DocumentMarkerController.cpp 2013-09-05 06:20:09 UTC (rev 155094)
+++ trunk/Source/WebCore/dom/DocumentMarkerController.cpp 2013-09-05 06:29:50 UTC (rev 155095)
@@ -334,20 +334,6 @@
return result;
}
-// FIXME: Should be removed after all relevant patches are landed
-VectorDocumentMarker DocumentMarkerController::markersForNode(Node* node)
-{
-VectorDocumentMarker result;
-MarkerList* list = m_markers.get(node);
-if (!list)
-return result;
-
-for (size_t i = 0; i list-size(); ++i)
-result.append(list-at(i));
-
-return result;
-}
-
VectorDocumentMarker* DocumentMarkerController::markersInRange(Range* range, DocumentMarker::MarkerTypes markerTypes)
{
if (!possiblyHasMarkers(markerTypes))
Modified: trunk/Source/WebCore/dom/DocumentMarkerController.h (155094 => 155095)
--- trunk/Source/WebCore/dom/DocumentMarkerController.h 2013-09-05 06:20:09 UTC (rev 155094)
+++ trunk/Source/WebCore/dom/DocumentMarkerController.h 2013-09-05 06:29:50 UTC (rev 155095)
@@ -80,7 +80,6 @@
DocumentMarker* markerContainingPoint(const LayoutPoint, DocumentMarker::MarkerType);
VectorDocumentMarker* markersFor(Node*, DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());
VectorDocumentMarker* markersInRange(Range*, DocumentMarker::MarkerTypes);
-VectorDocumentMarker markersForNode(Node*);
VectorIntRect renderedRectsForMarkers(DocumentMarker::MarkerType);
void clearDescriptionOnMarkersIntersectingRange(Range*, DocumentMarker::MarkerTypes);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155098] trunk
Title: [155098] trunk
Revision 155098
Author fpi...@apple.com
Date 2013-09-04 23:34:58 -0700 (Wed, 04 Sep 2013)
Log Message
jsc tests should have timeouts
https://bugs.webkit.org/show_bug.cgi?id=120725
Source/_javascript_Core:
Reviewed by Geoffrey Garen.
Add the timeout logic directly to 'jsc' because that's easier to do than
writing shell/perl code for it.
* jsc.cpp:
(timeoutThreadMain):
(main):
Tools:
Reviewed by Geoffrey Garen.
Set the timeout to 20 seconds per test for now.
* Scripts/run-_javascript_core-tests:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (155097 => 155098)
--- trunk/Source/_javascript_Core/ChangeLog 2013-09-05 06:32:35 UTC (rev 155097)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-09-05 06:34:58 UTC (rev 155098)
@@ -1,5 +1,19 @@
2013-09-04 Filip Pizlo fpi...@apple.com
+jsc tests should have timeouts
+https://bugs.webkit.org/show_bug.cgi?id=120725
+
+Reviewed by Geoffrey Garen.
+
+Add the timeout logic directly to 'jsc' because that's easier to do than
+writing shell/perl code for it.
+
+* jsc.cpp:
+(timeoutThreadMain):
+(main):
+
+2013-09-04 Filip Pizlo fpi...@apple.com
+
fast/js/dfg-* tests should wait for the concurrent JIT
https://bugs.webkit.org/show_bug.cgi?id=120723
Modified: trunk/Source/_javascript_Core/jsc.cpp (155097 => 155098)
--- trunk/Source/_javascript_Core/jsc.cpp 2013-09-05 06:32:35 UTC (rev 155097)
+++ trunk/Source/_javascript_Core/jsc.cpp 2013-09-05 06:34:58 UTC (rev 155098)
@@ -518,6 +518,23 @@
int jscmain(int argc, char** argv);
+static double s_desiredTimeout;
+static double s_timeToWake;
+
+static NO_RETURN_DUE_TO_CRASH void timeoutThreadMain(void*)
+{
+// WTF doesn't provide for a portable sleep(), so we use the ThreadCondition, which
+// is close enough.
+Mutex mutex;
+ThreadCondition condition;
+mutex.lock();
+while (currentTime() s_timeToWake)
+condition.timedWait(mutex, s_timeToWake);
+
+dataLog(Timed out after , s_desiredTimeout, seconds!\n);
+CRASH();
+}
+
int main(int argc, char** argv)
{
#if PLATFORM(IOS)
@@ -566,6 +583,17 @@
WTF::initializeMainThread();
#endif
JSC::initializeThreading();
+
+if (char* timeoutString = getenv(JSC_timeout)) {
+if (sscanf(timeoutString, %lf, s_desiredTimeout) != 1) {
+dataLog(
+WARNING: timeout string is malformed, got , timeoutString,
+ but expected a number. Not using a timeout.\n);
+} else {
+s_timeToWake = currentTime() + s_desiredTimeout;
+createThread(timeoutThreadMain, 0, jsc Timeout Thread);
+}
+}
// We can't use destructors in the following code because it uses Windows
// Structured Exception Handling
Modified: trunk/Tools/ChangeLog (155097 => 155098)
--- trunk/Tools/ChangeLog 2013-09-05 06:32:35 UTC (rev 155097)
+++ trunk/Tools/ChangeLog 2013-09-05 06:34:58 UTC (rev 155098)
@@ -1,5 +1,16 @@
2013-09-04 Filip Pizlo fpi...@apple.com
+jsc tests should have timeouts
+https://bugs.webkit.org/show_bug.cgi?id=120725
+
+Reviewed by Geoffrey Garen.
+
+Set the timeout to 20 seconds per test for now.
+
+* Scripts/run-_javascript_core-tests:
+
+2013-09-04 Filip Pizlo fpi...@apple.com
+
run-_javascript_core-tests should run-fast-jsc as well
https://bugs.webkit.org/show_bug.cgi?id=120722
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (155097 => 155098)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 06:32:35 UTC (rev 155097)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 06:34:58 UTC (rev 155098)
@@ -115,6 +115,7 @@
my $productDir = jscProductDir();
$ENV{DYLD_FRAMEWORK_PATH} = $productDir;
+$ENV{JSC_timeout} = 20; # Set a 20 second timeout on all jsc tests.
setPathForRunningWebKitApp(\%ENV) if isCygwin();
sub testapiPath($)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155099] trunk
Title: [155099] trunk
Revision 155099
Author zherc...@webkit.org
Date 2013-09-04 23:38:55 -0700 (Wed, 04 Sep 2013)
Log Message
https://webkit.org/b/118553 Hash navigation doesn't affect history when the page is retrieved from appcache
Reviewed by Darin Adler.
Source/WebCore:
A new flag called keepInHistory is added to allow keeping
certain pages in the history even if they have substitute data.
Test: http/tests/appcache/history-test.html
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::urlForHistory):
* loader/SubstituteData.h:
(WebCore::SubstituteData::SubstituteData):
(WebCore::SubstituteData::shouldRevealToSessionHistory):
(WebCore::SubstituteData::setShouldRevealToSessionHistory):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::maybeLoadMainResource):
LayoutTests:
* http/tests/appcache/history-test-expected.txt: Added.
* http/tests/appcache/history-test.html: Added.
* http/tests/appcache/resources/history-test.html: Added.
* http/tests/appcache/resources/history-test.manifest: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/SubstituteData.h
trunk/Source/WebCore/loader/appcache/ApplicationCacheHost.cpp
Added Paths
trunk/LayoutTests/http/tests/appcache/history-test-expected.txt
trunk/LayoutTests/http/tests/appcache/history-test.html
trunk/LayoutTests/http/tests/appcache/resources/history-test.html
trunk/LayoutTests/http/tests/appcache/resources/history-test.manifest
Diff
Modified: trunk/LayoutTests/ChangeLog (155098 => 155099)
--- trunk/LayoutTests/ChangeLog 2013-09-05 06:34:58 UTC (rev 155098)
+++ trunk/LayoutTests/ChangeLog 2013-09-05 06:38:55 UTC (rev 155099)
@@ -1,3 +1,14 @@
+2013-09-04 Zoltan Herczeg zherc...@webkit.org
+
+https://webkit.org/b/118553 Hash navigation doesn't affect history when the page is retrieved from appcache
+
+Reviewed by Darin Adler.
+
+* http/tests/appcache/history-test-expected.txt: Added.
+* http/tests/appcache/history-test.html: Added.
+* http/tests/appcache/resources/history-test.html: Added.
+* http/tests/appcache/resources/history-test.manifest: Added.
+
2013-09-04 Mihai Tica mit...@adobe.com
Test background blend modes with animated gif background layers.
Added: trunk/LayoutTests/http/tests/appcache/history-test-expected.txt (0 => 155099)
--- trunk/LayoutTests/http/tests/appcache/history-test-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/appcache/history-test-expected.txt 2013-09-05 06:38:55 UTC (rev 155099)
@@ -0,0 +1,3 @@
+Test whether window.history.back() is supported in application cache.
+
+PASS: Returning to the original page.
Added: trunk/LayoutTests/http/tests/appcache/history-test.html (0 => 155099)
--- trunk/LayoutTests/http/tests/appcache/history-test.html (rev 0)
+++ trunk/LayoutTests/http/tests/appcache/history-test.html 2013-09-05 06:38:55 UTC (rev 155099)
@@ -0,0 +1,11 @@
+html
+body
+script
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+window.location.assign(resources/history-test.html);
+/script
+/body
+/html
Added: trunk/LayoutTests/http/tests/appcache/resources/history-test.html (0 => 155099)
--- trunk/LayoutTests/http/tests/appcache/resources/history-test.html (rev 0)
+++ trunk/LayoutTests/http/tests/appcache/resources/history-test.html 2013-09-05 06:38:55 UTC (rev 155099)
@@ -0,0 +1,23 @@
+html manifest=history-test.manifest
+body
+pTest whether window.history.back() is supported in application cache./p
+
+script
+
+if (document.cookie) {
+document.write(pPASS: Returning to the original page./p);
+if (window.testRunner)
+testRunner.notifyDone();
+} else {
+document.write(pSTART: Redirecting to other page./p);
+document.cookie = 'cookie1=testcookie';
+
+// Give time to the history manager to cache this page.
+setTimeout(function () {
+window.location.assign(/navigation/resources/go-back.html);
+}, 200);
+}
+
+/script
+/body
+/html
Added: trunk/LayoutTests/http/tests/appcache/resources/history-test.manifest (0 => 155099)
--- trunk/LayoutTests/http/tests/appcache/resources/history-test.manifest (rev 0)
+++ trunk/LayoutTests/http/tests/appcache/resources/history-test.manifest 2013-09-05 06:38:55 UTC (rev 155099)
@@ -0,0 +1,5 @@
+CACHE MANIFEST
+history-test.html
+
+NETWORK:
+*
Modified: trunk/Source/WebCore/ChangeLog (155098 => 155099)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 06:34:58 UTC (rev 155098)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 06:38:55 UTC (rev 155099)
@@ -1,3 +1,23 @@
+2013-09-04 Zoltan Herczeg zherc...@webkit.org
+
+https://webkit.org/b/118553 Hash navigation doesn't affect history when the page is retrieved from appcache
+
+Reviewed by Darin Adler.
+
+A new
[webkit-changes] [155100] trunk
Title: [155100] trunk
Revision 155100
Author k...@webkit.org
Date 2013-09-04 23:50:05 -0700 (Wed, 04 Sep 2013)
Log Message
Support interpolation between cross-fade() images
https://bugs.webkit.org/show_bug.cgi?id=119955
Reviewed by Darin Adler.
Source/WebCore:
With this patch, CSS can animate from one -webkit-cross-fade
function to another, when the input images are the same in the
same order.
* css/CSSCrossfadeValue.cpp: Added blend function.
(WebCore::blendFunc):
(WebCore::CSSCrossfadeValue::blend):
(WebCore::CSSCrossfadeValue::equals):
(WebCore::CSSCrossfadeValue::equalInputImages):
* css/CSSCrossfadeValue.h: Added save casting functions.
(WebCore::toCSSCrossfadeValue):
* css/CSSValue.h:
(WebCore::CSSValue::isCrossfadeValue):
* page/animation/CSSPropertyAnimation.cpp: Add another condition to
interpolate between two -webkit-cross-fade functions.
(WebCore::blendFunc):
LayoutTests:
Test interpolation from one cross-fade function to another. Changed pixel test
to a ref test.
* animations/cross-fade-background-image.html:
* animations/cross-fade-background-image-expected.html: Added.
* platform/mac/animations/cross-fade-background-image-expected.png: Removed.
* platform/mac/animations/cross-fade-background-image-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/animations/cross-fade-background-image.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSCrossfadeValue.cpp
trunk/Source/WebCore/css/CSSCrossfadeValue.h
trunk/Source/WebCore/css/CSSValue.h
trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp
Added Paths
trunk/LayoutTests/animations/cross-fade-background-image-expected.html
Removed Paths
trunk/LayoutTests/platform/mac/animations/cross-fade-background-image-expected.png
trunk/LayoutTests/platform/mac/animations/cross-fade-background-image-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (155099 => 155100)
--- trunk/LayoutTests/ChangeLog 2013-09-05 06:38:55 UTC (rev 155099)
+++ trunk/LayoutTests/ChangeLog 2013-09-05 06:50:05 UTC (rev 155100)
@@ -1,3 +1,18 @@
+2013-09-04 Dirk Schulze k...@webkit.org
+
+Support interpolation between cross-fade() images
+https://bugs.webkit.org/show_bug.cgi?id=119955
+
+Reviewed by Darin Adler.
+
+Test interpolation from one cross-fade function to another. Changed pixel test
+to a ref test.
+
+* animations/cross-fade-background-image.html:
+* animations/cross-fade-background-image-expected.html: Added.
+* platform/mac/animations/cross-fade-background-image-expected.png: Removed.
+* platform/mac/animations/cross-fade-background-image-expected.txt: Removed.
+
2013-09-04 Zoltan Herczeg zherc...@webkit.org
https://webkit.org/b/118553 Hash navigation doesn't affect history when the page is retrieved from appcache
Added: trunk/LayoutTests/animations/cross-fade-background-image-expected.html (0 => 155100)
--- trunk/LayoutTests/animations/cross-fade-background-image-expected.html (rev 0)
+++ trunk/LayoutTests/animations/cross-fade-background-image-expected.html 2013-09-05 06:50:05 UTC (rev 155100)
@@ -0,0 +1,25 @@
+html
+head
+ style
+#rect {
+position: absolute;
+top: 200px;
+left: 100px;
+width: 200px;
+height: 300px;
+background-color: #049196;
+}
+ /style
+/head
+body
+div id=rect/div
+div id=result
+PASS - backgroundImage property for box element at 2.5s saw something close to: -webkit-cross-fade(url(blue-100.png), url(green-100.png), 50%)br
+PASS - backgroundImage property for box and boxStatic elements at 2.5s are close enough to each otherbr
+PASS - backgroundImage property for boxShorthand and boxStatic elements at 2.5s are close enough to each otherbr
+PASS - backgroundImage property for boxAnim1 element at 2.5s saw something close to: -webkit-cross-fade(url(resources/blue-100.png), url(resources/green-100.png), 0.5)br
+PASS - backgroundImage property for boxAnim2 element at 2.5s saw something close to: -webkit-cross-fade(url(resources/green-100.png), url(resources/blue-100.png), 50%)br
+PASS - backgroundImage property for boxAnim3 element at 2.5s saw something close to: -webkit-cross-fade(url(resources/blue-100.png), url(resources/green-100.png), 50%)br
+/div
+/body
+/html
\ No newline at end of file
Modified: trunk/LayoutTests/animations/cross-fade-background-image.html (155099 => 155100)
--- trunk/LayoutTests/animations/cross-fade-background-image.html 2013-09-05 06:38:55 UTC (rev 155099)
+++ trunk/LayoutTests/animations/cross-fade-background-image.html 2013-09-05 06:50:05 UTC (rev 155100)
@@ -4,7 +4,7 @@
#box {
position: absolute;
left: 100px;
-top: 100px;
+top: 200px;
height: 100px;
width: 100px;
background-color: red;
@@ -13,7 +13,7 @@
#boxShorthand {
position: absolute;
left: 100px;
-top: 200px;
+top: 300px;
[webkit-changes] [155101] trunk/Tools
Title: [155101] trunk/Tools
Revision 155101
Author fpi...@apple.com
Date 2013-09-05 00:18:58 -0700 (Thu, 05 Sep 2013)
Log Message
Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
* Scripts/run-_javascript_core-tests:
(readAllLines):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
Diff
Modified: trunk/Tools/ChangeLog (155100 => 155101)
--- trunk/Tools/ChangeLog 2013-09-05 06:50:05 UTC (rev 155100)
+++ trunk/Tools/ChangeLog 2013-09-05 07:18:58 UTC (rev 155101)
@@ -1,3 +1,10 @@
+2013-09-05 Filip Pizlo fpi...@apple.com
+
+Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
+
+* Scripts/run-_javascript_core-tests:
+(readAllLines):
+
2013-09-04 Filip Pizlo fpi...@apple.com
jsc tests should have timeouts
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (155100 => 155101)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 06:50:05 UTC (rev 155100)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 07:18:58 UTC (rev 155101)
@@ -31,7 +31,6 @@
# as well as other tests: testapi on Mac and LayoutTests/fast/js.
use strict;
-use File::Slurp;
use FindBin;
use Getopt::Long qw(:config pass_through);
use List::Util qw(min max);
@@ -216,6 +215,20 @@
}
}
+sub readAllLines
+{
+my ($filename) = @_;
+my @array = ();
+eval {
+open FILE, $filename or die;
+while (FILE) {
+push @array, $_;
+}
+close FILE;
+};
+return @array;
+}
+
sub printThingsFound
{
my ($number, $label, $pluralLabel, $verb) = @_;
@@ -228,8 +241,8 @@
print $verb.\n;
}
-my @fastJSFailList = eval { read_file($fastJSResultsDir . /failed) };
-my @fastJSCrashList = eval { read_file($fastJSResultsDir . /crashed) };
+my @fastJSFailList = readAllLines($fastJSResultsDir . /failed);
+my @fastJSCrashList = readAllLines($fastJSResultsDir . /crashed);
my $numJSFailures = @fastJSFailList;
my $numJSCrashes = @fastJSCrashList;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155102] trunk/Source/WebCore
Title: [155102] trunk/Source/WebCore
Revision 155102
Author be...@igalia.com
Date 2013-09-05 00:22:01 -0700 (Thu, 05 Sep 2013)
Log Message
[GTK] MediaControlsGtk: fix warning in constructor due to incorrect order of attributes
https://bugs.webkit.org/show_bug.cgi?id=120703
Reviewed by Carlos Garcia Campos.
Fix member initialization so it matches their declaration [-Wreorder].
* html/shadow/MediaControlsGtk.cpp:
(WebCore::MediaControlsGtk::MediaControlsGtk):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155101 => 155102)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 07:18:58 UTC (rev 155101)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 07:22:01 UTC (rev 155102)
@@ -1,3 +1,15 @@
+2013-09-05 Alberto Garcia be...@igalia.com
+
+[GTK] MediaControlsGtk: fix warning in constructor due to incorrect order of attributes
+https://bugs.webkit.org/show_bug.cgi?id=120703
+
+Reviewed by Carlos Garcia Campos.
+
+Fix member initialization so it matches their declaration [-Wreorder].
+
+* html/shadow/MediaControlsGtk.cpp:
+(WebCore::MediaControlsGtk::MediaControlsGtk):
+
2013-09-04 Dirk Schulze k...@webkit.org
Support interpolation between cross-fade() images
Modified: trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp (155101 => 155102)
--- trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp 2013-09-05 07:18:58 UTC (rev 155101)
+++ trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp 2013-09-05 07:22:01 UTC (rev 155102)
@@ -64,9 +64,9 @@
: MediaControls(document)
, m_durationDisplay(0)
, m_enclosure(0)
-, m_eventListener(0)
, m_closedCaptionsTrackList(0)
, m_closedCaptionsContainer(0)
+, m_eventListener(0)
{
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155103] trunk/Tools
Title: [155103] trunk/Tools
Revision 155103
Author fpi...@apple.com
Date 2013-09-05 00:23:58 -0700 (Thu, 05 Sep 2013)
Log Message
Unreviewed, don't run fast/js tests in run-_javascript_core-tests on platforms that
can't support it because if non-bourne shells. This fixes part #2 of the Linux
bot breakage.
* Scripts/run-_javascript_core-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
Diff
Modified: trunk/Tools/ChangeLog (155102 => 155103)
--- trunk/Tools/ChangeLog 2013-09-05 07:22:01 UTC (rev 155102)
+++ trunk/Tools/ChangeLog 2013-09-05 07:23:58 UTC (rev 155103)
@@ -1,5 +1,13 @@
2013-09-05 Filip Pizlo fpi...@apple.com
+Unreviewed, don't run fast/js tests in run-_javascript_core-tests on platforms that
+can't support it because if non-bourne shells. This fixes part #2 of the Linux
+bot breakage.
+
+* Scripts/run-_javascript_core-tests:
+
+2013-09-05 Filip Pizlo fpi...@apple.com
+
Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
* Scripts/run-_javascript_core-tests:
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (155102 => 155103)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 07:22:01 UTC (rev 155102)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 07:23:58 UTC (rev 155103)
@@ -189,13 +189,16 @@
}
close ACTUAL;
-# Run the fast/js tests.
chdirWebKit();
my $fastJSResultsDir = $productDir . /fast-jsc-results;
-my @fastJSDriverCmd = (/bin/sh, Tools/Scripts/run-fast-jsc, -j, jscPath($productDir), -r, $fastJSResultsDir, -t, LayoutTests);
-print Running: . join( , @fastJSDriverCmd) . \n;
-$result = system(@fastJSDriverCmd);
-exit exitStatus($result) if $result;
+my $runFastJS = isAppleMacWebKit();
+if ($runFastJS) {
+# Run the fast/js tests.
+my @fastJSDriverCmd = (/bin/sh, Tools/Scripts/run-fast-jsc, -j, jscPath($productDir), -r, $fastJSResultsDir, -t, LayoutTests);
+print Running: . join( , @fastJSDriverCmd) . \n;
+$result = system(@fastJSDriverCmd);
+exit exitStatus($result) if $result;
+}
my $numNewMozillaFailures = keys %newMozillaFailures;
if ($numNewMozillaFailures) {
@@ -262,11 +265,13 @@
print \n;
-print Results for fast/js tests:\n;
-printThingsFound($numJSFailures, failure, failures, found);
-printThingsFound($numJSCrashes, crash, crashes, found);
-print OK.\n if $numJSFailures == 0 $numJSCrashes == 0;
-
-print \n;
-
+if ($runFastJS) {
+print Results for fast/js tests:\n;
+printThingsFound($numJSFailures, failure, failures, found);
+printThingsFound($numJSCrashes, crash, crashes, found);
+print OK.\n if $numJSFailures == 0 $numJSCrashes == 0;
+
+print \n;
+}
+
exit(1) if $numNewMozillaFailures || $numJSFailures || $numJSCrashes;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155104] trunk/Source/WebCore
Title: [155104] trunk/Source/WebCore
Revision 155104
Author commit-qu...@webkit.org
Date 2013-09-05 00:33:38 -0700 (Thu, 05 Sep 2013)
Log Message
[Qt][WK1] REGRESSION(r154988): compositing/video/video-with-invalid-source.html
https://bugs.webkit.org/show_bug.cgi?id=120683
Patch by Andre Moreira Magalhaes andre.magalh...@collabora.co.uk on 2013-09-05
Reviewed by Philippe Normand.
Do not set pipeline state to NULL on MediaPlayerPrivateGStreamer::loadingFailed()
otherwise the bus is flushed and we never get a GST_MESSAGE_ERROR when failing to
load uris.
Also restore previous behaviour (before r154988) of not invoking loadingFailed() for
all failed manual state change attempts.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
Do not call loadingFailed() if state change fails as all manual state changes are
now done with changePipelineState().
(WebCore::MediaPlayerPrivateGStreamer::play):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
Restore previous behaviour (before changeset r154988) when calling changePipelineState().
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
Do nothing if changing to READY on EOS (same behaviour as setting to NULL as it was before
changeset r154988).
(WebCore::MediaPlayerPrivateGStreamer::loadingFailed):
Do not set pipeline state to NULL so we properly get GST_MESSAGE_ERROR on loading failures.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155103 => 155104)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 07:23:58 UTC (rev 155103)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 07:33:38 UTC (rev 155104)
@@ -1,3 +1,31 @@
+2013-09-05 Andre Moreira Magalhaes andre.magalh...@collabora.co.uk
+
+[Qt][WK1] REGRESSION(r154988): compositing/video/video-with-invalid-source.html
+https://bugs.webkit.org/show_bug.cgi?id=120683
+
+Reviewed by Philippe Normand.
+
+Do not set pipeline state to NULL on MediaPlayerPrivateGStreamer::loadingFailed()
+otherwise the bus is flushed and we never get a GST_MESSAGE_ERROR when failing to
+load uris.
+Also restore previous behaviour (before r154988) of not invoking loadingFailed() for
+all failed manual state change attempts.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
+Do not call loadingFailed() if state change fails as all manual state changes are
+now done with changePipelineState().
+(WebCore::MediaPlayerPrivateGStreamer::play):
+(WebCore::MediaPlayerPrivateGStreamer::pause):
+(WebCore::MediaPlayerPrivateGStreamer::seek):
+(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
+Restore previous behaviour (before changeset r154988) when calling changePipelineState().
+(WebCore::MediaPlayerPrivateGStreamer::updateStates):
+Do nothing if changing to READY on EOS (same behaviour as setting to NULL as it was before
+changeset r154988).
+(WebCore::MediaPlayerPrivateGStreamer::loadingFailed):
+Do not set pipeline state to NULL so we properly get GST_MESSAGE_ERROR on loading failures.
+
2013-09-05 Alberto Garcia be...@igalia.com
[GTK] MediaControlsGtk: fix warning in constructor due to incorrect order of attributes
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (155103 => 155104)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2013-09-05 07:23:58 UTC (rev 155103)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2013-09-05 07:33:38 UTC (rev 155104)
@@ -441,7 +441,6 @@
GstStateChangeReturn setStateResult = gst_element_set_state(m_playBin.get(), newState);
GstState pausedOrPlaying = newState == GST_STATE_PLAYING ? GST_STATE_PAUSED : GST_STATE_PLAYING;
if (currentState != pausedOrPlaying setStateResult == GST_STATE_CHANGE_FAILURE) {
-loadingFailed(MediaPlayer::Empty);
return false;
}
@@ -476,6 +475,8 @@
m_preload = MediaPlayer::Auto;
setDownloadBuffering();
LOG_MEDIA_MESSAGE(Play);
+} else {
+loadingFailed(MediaPlayer::Empty);
}
}
@@ -488,6 +489,8 @@
if (changePipelineState(GST_STATE_PAUSED))
INFO_MEDIA_MESSAGE(Pause);
+else
+loadingFailed(MediaPlayer::Empty);
}
float MediaPlayerPrivateGStreamer::duration() const
@@ -586,7 +589,8 @@
if (m_isEndReached) {
LOG_MEDIA_MESSAGE([Seek] reset pipeline);
m_resetPipeline = true;
-changePipelineState(GST_STATE_PAUSED);
+if
[webkit-changes] [155105] trunk
Title: [155105] trunk
Revision 155105
Author k...@webkit.org
Date 2013-09-05 00:38:46 -0700 (Thu, 05 Sep 2013)
Log Message
NULL ptr in WebCore::RefCountedPropertyWrapperWebCore::ClipPathOperation::blend
https://bugs.webkit.org/show_bug.cgi?id=105408
Reviewed by Dean Jackson.
Source/WebCore:
Adding an early return if from or to clip-path values are 'none'. According to the
specification we shall just interpolate between two basic shapes.
http://dev.w3.org/csswg/css-shapes/#basic-shape-interpolation
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
LayoutTests:
Test that animation from none to a basic shape on -webkit-clip-path doesn't crash.
* css3/masking/clip-path-animation-expected.txt:
* css3/masking/clip-path-animation.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/masking/clip-path-animation-expected.txt
trunk/LayoutTests/css3/masking/clip-path-animation.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (155104 => 155105)
--- trunk/LayoutTests/ChangeLog 2013-09-05 07:33:38 UTC (rev 155104)
+++ trunk/LayoutTests/ChangeLog 2013-09-05 07:38:46 UTC (rev 155105)
@@ -1,3 +1,15 @@
+2013-09-05 Dirk Schulze k...@webkit.org
+
+NULL ptr in WebCore::RefCountedPropertyWrapperWebCore::ClipPathOperation::blend
+https://bugs.webkit.org/show_bug.cgi?id=105408
+
+Reviewed by Dean Jackson.
+
+Test that animation from none to a basic shape on -webkit-clip-path doesn't crash.
+
+* css3/masking/clip-path-animation-expected.txt:
+* css3/masking/clip-path-animation.html:
+
2013-09-04 Dirk Schulze k...@webkit.org
Support interpolation between cross-fade() images
Modified: trunk/LayoutTests/css3/masking/clip-path-animation-expected.txt (155104 => 155105)
--- trunk/LayoutTests/css3/masking/clip-path-animation-expected.txt 2013-09-05 07:33:38 UTC (rev 155104)
+++ trunk/LayoutTests/css3/masking/clip-path-animation-expected.txt 2013-09-05 07:38:46 UTC (rev 155105)
@@ -1,6 +1,7 @@
-
+
PASS - webkitClipPath property for rectangle-box element at 1s saw something close to: rectangle(10%, 10%, 80%, 80%, 0px, 0px)
PASS - webkitClipPath property for circle-box element at 1s saw something close to: circle(35%, 35%, 35%)
PASS - webkitClipPath property for ellipse-box element at 1s saw something close to: ellipse(35%, 35%, 35%, 30%)
PASS - webkitClipPath property for polygon-box element at 1s saw something close to: polygon(nonzero, 10% 10%, 90% 10%, 90% 90%, 10% 90%)
+PASS - webkitClipPath property for none-box element at 1s saw something close to: polygon(nonzero, 20% 20%, 80% 20%, 80% 80%, 20% 80%)
Modified: trunk/LayoutTests/css3/masking/clip-path-animation.html (155104 => 155105)
--- trunk/LayoutTests/css3/masking/clip-path-animation.html 2013-09-05 07:33:38 UTC (rev 155104)
+++ trunk/LayoutTests/css3/masking/clip-path-animation.html 2013-09-05 07:38:46 UTC (rev 155105)
@@ -27,6 +27,9 @@
-webkit-animation: polygon-anim 2s linear
}
+#none-box {
+ -webkit-animation: none-anim 2s linear
+}
@-webkit-keyframes rectangle-anim {
from { -webkit-clip-path: rectangle(0%, 0%, 100%, 100%); }
@@ -48,6 +51,12 @@
to { -webkit-clip-path: polygon(nonzero, 20% 20%, 80% 20%, 80% 80%, 20% 80%); }
}
+@-webkit-keyframes none-anim {
+/* We do not support animations from or to 'none' as specified. */
+from { -webkit-clip-path: none; }
+to { -webkit-clip-path: polygon(nonzero, 20% 20%, 80% 20%, 80% 80%, 20% 80%); }
+}
+
/style
script src=""
script type=text/_javascript_
@@ -57,6 +66,7 @@
[circle-anim, 1, circle-box, webkitClipPath, circle(35%, 35%, 35%), 0.05],
[ellipse-anim, 1, ellipse-box, webkitClipPath, ellipse(35%, 35%, 35%, 30%), 0.05],
[polygon-anim, 1, polygon-box, webkitClipPath, polygon(nonzero, 10% 10%, 90% 10%, 90% 90%, 10% 90%), 0.05],
+ [none-anim, 1, none-box, webkitClipPath, polygon(nonzero, 20% 20%, 80% 20%, 80% 80%, 20% 80%), 0],
];
runAnimationTest(expectedValues);
@@ -68,6 +78,7 @@
div class=box id=circle-box/div
div class=box id=ellipse-box/div
div class=box id=polygon-box/div
+div class=box id=none-box/div
div id=result
/div
Modified: trunk/Source/WebCore/ChangeLog (155104 => 155105)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 07:33:38 UTC (rev 155104)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 07:38:46 UTC (rev 155105)
@@ -1,3 +1,18 @@
+2013-09-05 Dirk Schulze k...@webkit.org
+
+NULL ptr in WebCore::RefCountedPropertyWrapperWebCore::ClipPathOperation::blend
+https://bugs.webkit.org/show_bug.cgi?id=105408
+
+Reviewed by Dean Jackson.
+
+Adding an early return if from or to clip-path values are 'none'. According to the
+specification we shall just interpolate between two basic shapes.
+
+
[webkit-changes] [155108] trunk/Source/WebCore
Title: [155108] trunk/Source/WebCore Revision 155108 Author o...@webkit.org Date 2013-09-05 02:51:25 -0700 (Thu, 05 Sep 2013) Log Message Fix SynchronousLoaderClient class for !USE(CFNETWORK) platforms https://bugs.webkit.org/show_bug.cgi?id=120532 Reviewed by Darin Adler. * CMakeLists.txt: * PlatformEfl.cmake: * PlatformGTK.cmake: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * platform/network/SynchronousLoaderClient.cpp: * platform/network/cf/SynchronousLoaderClientCFNet.cpp: Added. (WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge): (WebCore::SynchronousLoaderClient::platformBadResponseError): * platform/network/soup/SynchronousLoaderClientSoup.cpp: Added. (WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge): (WebCore::SynchronousLoaderClient::platformBadResponseError): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebCore/PlatformGTK.cmake trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters trunk/Source/WebCore/platform/network/SynchronousLoaderClient.cpp Added Paths trunk/Source/WebCore/platform/network/cf/SynchronousLoaderClientCFNet.cpp trunk/Source/WebCore/platform/network/soup/SynchronousLoaderClientSoup.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (155107 => 155108) --- trunk/Source/WebCore/CMakeLists.txt 2013-09-05 09:01:02 UTC (rev 155107) +++ trunk/Source/WebCore/CMakeLists.txt 2013-09-05 09:51:25 UTC (rev 155108) @@ -2047,6 +2047,7 @@ platform/network/ResourceRequestBase.cpp platform/network/ResourceResponseBase.cpp platform/network/SocketStreamHandleBase.cpp +platform/network/SynchronousLoaderClient.cpp platform/sql/SQLValue.cpp platform/sql/SQLiteAuthorizer.cpp Modified: trunk/Source/WebCore/ChangeLog (155107 => 155108) --- trunk/Source/WebCore/ChangeLog 2013-09-05 09:01:02 UTC (rev 155107) +++ trunk/Source/WebCore/ChangeLog 2013-09-05 09:51:25 UTC (rev 155108) @@ -1,3 +1,23 @@ +2013-09-05 Csaba Osztrogonác o...@webkit.org + +Fix SynchronousLoaderClient class for !USE(CFNETWORK) platforms +https://bugs.webkit.org/show_bug.cgi?id=120532 + +Reviewed by Darin Adler. + +* CMakeLists.txt: +* PlatformEfl.cmake: +* PlatformGTK.cmake: +* WebCore.vcxproj/WebCore.vcxproj: +* WebCore.vcxproj/WebCore.vcxproj.filters: +* platform/network/SynchronousLoaderClient.cpp: +* platform/network/cf/SynchronousLoaderClientCFNet.cpp: Added. +(WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge): +(WebCore::SynchronousLoaderClient::platformBadResponseError): +* platform/network/soup/SynchronousLoaderClientSoup.cpp: Added. +(WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge): +(WebCore::SynchronousLoaderClient::platformBadResponseError): + 2013-09-05 Jinwoo Song jinwoo7.s...@samsung.com Fix unused parameter warning in WebKitAccessibleInterfaceText.cpp Modified: trunk/Source/WebCore/PlatformEfl.cmake (155107 => 155108) --- trunk/Source/WebCore/PlatformEfl.cmake 2013-09-05 09:01:02 UTC (rev 155107) +++ trunk/Source/WebCore/PlatformEfl.cmake 2013-09-05 09:51:25 UTC (rev 155108) @@ -161,6 +161,7 @@ platform/network/soup/ResourceResponseSoup.cpp platform/network/soup/SocketStreamHandleSoup.cpp platform/network/soup/SoupURIUtils.cpp +platform/network/soup/SynchronousLoaderClientSoup.cpp platform/posix/FileSystemPOSIX.cpp platform/posix/SharedBufferPOSIX.cpp Modified: trunk/Source/WebCore/PlatformGTK.cmake (155107 => 155108) --- trunk/Source/WebCore/PlatformGTK.cmake 2013-09-05 09:01:02 UTC (rev 155107) +++ trunk/Source/WebCore/PlatformGTK.cmake 2013-09-05 09:51:25 UTC (rev 155108) @@ -202,6 +202,7 @@ platform/network/soup/ResourceResponseSoup.cpp platform/network/soup/SocketStreamHandleSoup.cpp platform/network/soup/SoupURIUtils.cpp +platform/network/soup/SynchronousLoaderClientSoup.cpp platform/PlatformStrategies.cpp Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (155107 => 155108) --- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2013-09-05 09:01:02 UTC (rev 155107) +++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2013-09-05 09:51:25 UTC (rev 155108) @@ -8247,6 +8247,12 @@ ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Release_WinCairo|Win32'true/ExcludedFromBuild ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Release_WinCairo|x64'true/ExcludedFromBuild /ClCompile +ClCompile Include=..\platform\network\cf\SynchronousLoaderClientCFNet.cpp + ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Debug_WinCairo|Win32'true/ExcludedFromBuild + ExcludedFromBuild
[webkit-changes] [155111] trunk/LayoutTests
Title: [155111] trunk/LayoutTests Revision 155111 Author commit-qu...@webkit.org Date 2013-09-05 06:22:00 -0700 (Thu, 05 Sep 2013) Log Message [GTK] media/track/in-band/ layout tests introduced in r154908 are failing https://bugs.webkit.org/show_bug.cgi?id=120665 Patch by Brendan Long b.l...@cablelabs.com on 2013-09-05 Reviewed by Philippe Normand. * platform/efl/TestExpectations: Skip new media/track/in-band tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (155110 => 155111) --- trunk/LayoutTests/ChangeLog 2013-09-05 12:34:35 UTC (rev 155110) +++ trunk/LayoutTests/ChangeLog 2013-09-05 13:22:00 UTC (rev 155111) @@ -1,3 +1,12 @@ +2013-09-05 Brendan Long b.l...@cablelabs.com + +[GTK] media/track/in-band/ layout tests introduced in r154908 are failing +https://bugs.webkit.org/show_bug.cgi?id=120665 + +Reviewed by Philippe Normand. + +* platform/efl/TestExpectations: Skip new media/track/in-band tests. + 2013-09-05 Zoltan Arvai zar...@inf.u-szeged.hu [Qt] Unreviewed gardening. Modified: trunk/LayoutTests/platform/efl/TestExpectations (155110 => 155111) --- trunk/LayoutTests/platform/efl/TestExpectations 2013-09-05 12:34:35 UTC (rev 155110) +++ trunk/LayoutTests/platform/efl/TestExpectations 2013-09-05 13:22:00 UTC (rev 155111) @@ -1538,13 +1538,14 @@ # Fails until we enable the Resource Timing API. webkit.org/b/61138 http/tests/w3c/webperf/submission/Google/resource-timing [ Skip ] -# No support for exposing in-band text tracks +# In-band tracks only work on GStreamer = 1.1.2 Bug(EFL) media/track/track-in-band.html [ Skip ] Bug(EFL) media/track/track-in-band-cues-added-once.html [ Skip ] Bug(EFL) media/track/track-in-band-style.html [ Skip ] Bug(EFL) media/track/track-in-band-legacy-api.html [ Skip ] Bug(EFL) media/track/track-forced-subtitles-in-band.html [ Skip ] Bug(EFL) media/track/track-in-band-mode.html [ Skip ] +Bug(EFL) media/track/in-band [ Skip ] # Rendering failure, also missing expected results: webkit.org/b/105093 compositing/webgl/webgl-nonpremultiplied-blend.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155112] trunk/Source/WebCore
Title: [155112] trunk/Source/WebCore
Revision 155112
Author commit-qu...@webkit.org
Date 2013-09-05 06:25:50 -0700 (Thu, 05 Sep 2013)
Log Message
Precision updates in WebAudio.
https://bugs.webkit.org/show_bug.cgi?id=119739
Patch by Praveen R Jadhav pravee...@samsung.com on 2013-09-05
Reviewed by Philippe Normand.
WebAudio Specification suggests to use 'double' datatypes
for minDecibels, maxDecibels and smoothingTimeConstant in
AnalyserNode.idl and currentTime in AudioContext.idl.
Current WebKit implementation has declared these attributes
as 'float' type.
Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioContext-section
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AnalyserNode
No new tests, covered by existing tests.
* Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::setMinDecibels):
(WebCore::AnalyserNode::setMaxDecibels):
(WebCore::AnalyserNode::setSmoothingTimeConstant):
* Modules/webaudio/AnalyserNode.h:
(WebCore::AnalyserNode::minDecibels):
(WebCore::AnalyserNode::maxDecibels):
(WebCore::AnalyserNode::smoothingTimeConstant):
* Modules/webaudio/AnalyserNode.idl:
* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/RealtimeAnalyser.h:
(WebCore::RealtimeAnalyser::setMinDecibels):
(WebCore::RealtimeAnalyser::minDecibels):
(WebCore::RealtimeAnalyser::setMaxDecibels):
(WebCore::RealtimeAnalyser::maxDecibels):
(WebCore::RealtimeAnalyser::setSmoothingTimeConstant):
(WebCore::RealtimeAnalyser::smoothingTimeConstant):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp
trunk/Source/WebCore/Modules/webaudio/AnalyserNode.h
trunk/Source/WebCore/Modules/webaudio/AnalyserNode.idl
trunk/Source/WebCore/Modules/webaudio/AudioContext.idl
trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (155111 => 155112)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 13:22:00 UTC (rev 155111)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 13:25:50 UTC (rev 155112)
@@ -1,3 +1,39 @@
+2013-09-05 Praveen R Jadhav pravee...@samsung.com
+
+Precision updates in WebAudio.
+https://bugs.webkit.org/show_bug.cgi?id=119739
+
+Reviewed by Philippe Normand.
+
+WebAudio Specification suggests to use 'double' datatypes
+for minDecibels, maxDecibels and smoothingTimeConstant in
+AnalyserNode.idl and currentTime in AudioContext.idl.
+Current WebKit implementation has declared these attributes
+as 'float' type.
+
+Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioContext-section
+ https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AnalyserNode
+
+No new tests, covered by existing tests.
+
+* Modules/webaudio/AnalyserNode.cpp:
+(WebCore::AnalyserNode::setMinDecibels):
+(WebCore::AnalyserNode::setMaxDecibels):
+(WebCore::AnalyserNode::setSmoothingTimeConstant):
+* Modules/webaudio/AnalyserNode.h:
+(WebCore::AnalyserNode::minDecibels):
+(WebCore::AnalyserNode::maxDecibels):
+(WebCore::AnalyserNode::smoothingTimeConstant):
+* Modules/webaudio/AnalyserNode.idl:
+* Modules/webaudio/AudioContext.idl:
+* Modules/webaudio/RealtimeAnalyser.h:
+(WebCore::RealtimeAnalyser::setMinDecibels):
+(WebCore::RealtimeAnalyser::minDecibels):
+(WebCore::RealtimeAnalyser::setMaxDecibels):
+(WebCore::RealtimeAnalyser::maxDecibels):
+(WebCore::RealtimeAnalyser::setSmoothingTimeConstant):
+(WebCore::RealtimeAnalyser::smoothingTimeConstant):
+
2013-09-05 Mihnea Ovidenie mih...@adobe.com
Replace node() calls with generatingNode() for RenderRegion code
Modified: trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp (155111 => 155112)
--- trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp 2013-09-05 13:22:00 UTC (rev 155111)
+++ trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp 2013-09-05 13:25:50 UTC (rev 155112)
@@ -78,7 +78,7 @@
ec = INDEX_SIZE_ERR;
}
-void AnalyserNode::setMinDecibels(float k, ExceptionCode ec)
+void AnalyserNode::setMinDecibels(double k, ExceptionCode ec)
{
if (k maxDecibels()) {
ec = INDEX_SIZE_ERR;
@@ -88,7 +88,7 @@
m_analyser.setMinDecibels(k);
}
-void AnalyserNode::setMaxDecibels(float k, ExceptionCode ec)
+void AnalyserNode::setMaxDecibels(double k, ExceptionCode ec)
{
if (k minDecibels()) {
ec = INDEX_SIZE_ERR;
@@ -98,7 +98,7 @@
m_analyser.setMaxDecibels(k);
}
-void AnalyserNode::setSmoothingTimeConstant(float k, ExceptionCode ec)
+void AnalyserNode::setSmoothingTimeConstant(double k, ExceptionCode ec)
{
if (k 0 || k 1) {
ec = INDEX_SIZE_ERR;
Modified: trunk/Source/WebCore/Modules/webaudio/AnalyserNode.h (155111 => 155112)
--- trunk/Source/WebCore/Modules/webaudio/AnalyserNode.h
[webkit-changes] [155115] trunk/Source/WTF
Title: [155115] trunk/Source/WTF
Revision 155115
Author mikhail.pozdnya...@intel.com
Date 2013-09-05 07:31:30 -0700 (Thu, 05 Sep 2013)
Log Message
Remove String(RefPtrStringImpl) constructor
https://bugs.webkit.org/show_bug.cgi?id=120767
Reviewed by Anders Carlsson.
The String(RefPtrStringImpl) constructor should be removed for the following reasons:
- It almost does not have clients, so it is unneeded.
- RefPtr should never be passed by value
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::shrinkToFit):
* wtf/text/WTFString.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringBuilder.cpp
trunk/Source/WTF/wtf/text/WTFString.h
Diff
Modified: trunk/Source/WTF/ChangeLog (155114 => 155115)
--- trunk/Source/WTF/ChangeLog 2013-09-05 14:23:14 UTC (rev 155114)
+++ trunk/Source/WTF/ChangeLog 2013-09-05 14:31:30 UTC (rev 155115)
@@ -1,3 +1,18 @@
+2013-09-05 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com
+
+Remove String(RefPtrStringImpl) constructor
+https://bugs.webkit.org/show_bug.cgi?id=120767
+
+Reviewed by Anders Carlsson.
+
+The String(RefPtrStringImpl) constructor should be removed for the following reasons:
+- It almost does not have clients, so it is unneeded.
+- RefPtr should never be passed by value
+
+* wtf/text/StringBuilder.cpp:
+(WTF::StringBuilder::shrinkToFit):
+* wtf/text/WTFString.h:
+
2013-09-05 Jaehun Lim ljaehun@samsung.com
Unreviewed. Fix build after r155083
Modified: trunk/Source/WTF/wtf/text/StringBuilder.cpp (155114 => 155115)
--- trunk/Source/WTF/wtf/text/StringBuilder.cpp 2013-09-05 14:23:14 UTC (rev 155114)
+++ trunk/Source/WTF/wtf/text/StringBuilder.cpp 2013-09-05 14:31:30 UTC (rev 155115)
@@ -341,8 +341,7 @@
reallocateBufferLChar(m_length);
else
reallocateBufferUChar(m_length);
-m_string = m_buffer;
-m_buffer = 0;
+m_string = m_buffer.release();
}
}
Modified: trunk/Source/WTF/wtf/text/WTFString.h (155114 => 155115)
--- trunk/Source/WTF/wtf/text/WTFString.h 2013-09-05 14:23:14 UTC (rev 155114)
+++ trunk/Source/WTF/wtf/text/WTFString.h 2013-09-05 14:31:30 UTC (rev 155115)
@@ -128,7 +128,6 @@
// Construct a string referencing an existing StringImpl.
String(StringImpl* impl) : m_impl(impl) { }
String(PassRefPtrStringImpl impl) : m_impl(impl) { }
-String(RefPtrStringImpl impl) : m_impl(impl) { }
// Construct a string from a constant string literal.
WTF_EXPORT_STRING_API String(ASCIILiteral characters);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155116] trunk/Source/WebCore
Title: [155116] trunk/Source/WebCore
Revision 155116
Author an...@apple.com
Date 2013-09-05 07:45:58 -0700 (Thu, 05 Sep 2013)
Log Message
Call createTextRenderersForSiblingsAfterAttachIfNeeded only for the attach root
https://bugs.webkit.org/show_bug.cgi?id=120770
Reviewed by Andreas Kling.
There is no need to call this during recursive attach as siblings are going to be attached normally anyway.
Move call sites to attach roots only.
* style/StyleResolveTree.cpp:
(WebCore::Style::createTextRenderersForSiblingsAfterAttachIfNeeded):
Factor to take reference and do the inital tests itself.
(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::updateTextRendererAfterContentChange):
(WebCore::Style::attachChildren):
Also tightened the condition where previously attached children may be encountered.
(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveLocal):
(WebCore::Style::updateTextStyle):
(WebCore::Style::reattachRenderTree):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleResolveTree.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155115 => 155116)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 14:31:30 UTC (rev 155115)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 14:45:58 UTC (rev 155116)
@@ -1,3 +1,29 @@
+2013-09-05 Antti Koivisto an...@apple.com
+
+Call createTextRenderersForSiblingsAfterAttachIfNeeded only for the attach root
+https://bugs.webkit.org/show_bug.cgi?id=120770
+
+Reviewed by Andreas Kling.
+
+There is no need to call this during recursive attach as siblings are going to be attached normally anyway.
+Move call sites to attach roots only.
+
+* style/StyleResolveTree.cpp:
+(WebCore::Style::createTextRenderersForSiblingsAfterAttachIfNeeded):
+
+Factor to take reference and do the inital tests itself.
+
+(WebCore::Style::createTextRendererIfNeeded):
+(WebCore::Style::updateTextRendererAfterContentChange):
+(WebCore::Style::attachChildren):
+
+Also tightened the condition where previously attached children may be encountered.
+
+(WebCore::Style::attachRenderTree):
+(WebCore::Style::resolveLocal):
+(WebCore::Style::updateTextStyle):
+(WebCore::Style::reattachRenderTree):
+
2013-09-05 Enrique Ocaña González eoca...@igalia.com
[GTK] Assertion fails when the mouse pointer is styled with a custom cursor
Modified: trunk/Source/WebCore/style/StyleResolveTree.cpp (155115 => 155116)
--- trunk/Source/WebCore/style/StyleResolveTree.cpp 2013-09-05 14:31:30 UTC (rev 155115)
+++ trunk/Source/WebCore/style/StyleResolveTree.cpp 2013-09-05 14:45:58 UTC (rev 155116)
@@ -280,22 +280,19 @@
return 0;
}
-static void createTextRenderersForSiblingsAfterAttachIfNeeded(Node* sibling)
+static void createTextRenderersForSiblingsAfterAttachIfNeeded(Node node)
{
-ASSERT(sibling-previousSibling());
-ASSERT(sibling-previousSibling()-renderer());
-ASSERT(!sibling-renderer());
-ASSERT(sibling-attached());
+if (!node.renderer())
+return;
// If this node got a renderer it may be the previousRenderer() of sibling text nodes and thus affect the
// result of Text::textRendererIsNeeded() for those nodes.
-for (; sibling; sibling = sibling-nextSibling()) {
+for (Node* sibling = node.nextSibling(); sibling; sibling = sibling-nextSibling()) {
if (sibling-renderer())
break;
if (!sibling-attached())
break; // Assume this means none of the following siblings are attached.
if (!sibling-isTextNode())
continue;
-ASSERT(!sibling-renderer());
attachTextRenderer(*toText(sibling));
// If we again decided not to create a renderer for next, we can bail out the loop,
// because it won't affect the result of Text::textRendererIsNeeded() for the rest
@@ -385,10 +382,6 @@
// Parent takes care of the animations, no need to call setAnimatableStyle.
newRenderer-setStyle(style.release());
parentRenderer-addChild(newRenderer, nextRenderer);
-
-Node* sibling = textNode.nextSibling();
-if (sibling !sibling-renderer() sibling-attached())
-createTextRenderersForSiblingsAfterAttachIfNeeded(sibling);
}
void attachTextRenderer(Text textNode)
@@ -414,6 +407,7 @@
RenderText* textRenderer = toRenderText(textNode.renderer());
if (!textRenderer) {
attachTextRenderer(textNode);
+createTextRenderersForSiblingsAfterAttachIfNeeded(textNode);
return;
}
RenderObject* parentRenderer = NodeRenderingTraversal::parent(textNode)-renderer();
@@ -425,23 +419,10 @@
textRenderer-setTextWithOffset(textNode.dataImpl(), offsetOfReplacedData, lengthOfReplacedData);
}
-#ifndef NDEBUG
-static bool childAttachedAllowedWhenAttachingChildren(ContainerNode node)
-{
-if
[webkit-changes] [155121] trunk/Source
Title: [155121] trunk/Source
Revision 155121
Author ander...@apple.com
Date 2013-09-05 08:20:51 -0700 (Thu, 05 Sep 2013)
Log Message
Vector::releaseBuffer should return an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=120718
Reviewed by Andreas Kling.
Source/WebCore:
Change FormStreamFields::currentData to an OwnPtr.
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::closeCurrentStream):
(WebCore::advanceCurrentStream):
(WebCore::formCreate):
Source/WTF:
Change Vector::releaseBuffer() to return an OwnPtr. I intentionally chose
to use an OwnPtr over a PassOwnPtr since we're trying to move away from PassOwnPtr objects.
Fix fallout from this change by adopting OwnPtr/PassOwnPtr in StringBuffer and the two StringImpl
constructors that adopt the passed in pointer.
* wtf/Vector.h:
* wtf/text/StringBuffer.h:
* wtf/text/StringImpl.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Vector.h
trunk/Source/WTF/wtf/text/StringBuffer.h
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (155120 => 155121)
--- trunk/Source/WTF/ChangeLog 2013-09-05 15:17:33 UTC (rev 155120)
+++ trunk/Source/WTF/ChangeLog 2013-09-05 15:20:51 UTC (rev 155121)
@@ -1,3 +1,20 @@
+2013-09-04 Anders Carlsson ander...@apple.com
+
+Vector::releaseBuffer should return an OwnPtr
+https://bugs.webkit.org/show_bug.cgi?id=120718
+
+Reviewed by Andreas Kling.
+
+Change Vector::releaseBuffer() to return an OwnPtr. I intentionally chose
+to use an OwnPtr over a PassOwnPtr since we're trying to move away from PassOwnPtr objects.
+
+Fix fallout from this change by adopting OwnPtr/PassOwnPtr in StringBuffer and the two StringImpl
+constructors that adopt the passed in pointer.
+
+* wtf/Vector.h:
+* wtf/text/StringBuffer.h:
+* wtf/text/StringImpl.h:
+
2013-09-05 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com
Remove String(RefPtrStringImpl) constructor
Modified: trunk/Source/WTF/wtf/Vector.h (155120 => 155121)
--- trunk/Source/WTF/wtf/Vector.h 2013-09-05 15:17:33 UTC (rev 155120)
+++ trunk/Source/WTF/wtf/Vector.h 2013-09-05 15:20:51 UTC (rev 155121)
@@ -26,6 +26,7 @@
#include wtf/FastAllocBase.h
#include wtf/Noncopyable.h
#include wtf/NotFound.h
+#include wtf/OwnPtr.h
#include wtf/StdLibExtras.h
#include wtf/ValueCheck.h
#include wtf/VectorTraits.h
@@ -307,12 +308,12 @@
const T* buffer() const { return m_buffer; }
size_t capacity() const { return m_capacity; }
-T* releaseBuffer()
+OwnPtrT releaseBuffer()
{
T* buffer = m_buffer;
m_buffer = 0;
m_capacity = 0;
-return buffer;
+return adoptPtr(buffer);
}
protected:
@@ -487,10 +488,10 @@
using Base::buffer;
using Base::capacity;
-T* releaseBuffer()
+OwnPtrT releaseBuffer()
{
if (buffer() == inlineBuffer())
-return 0;
+return nullptr;
return Base::releaseBuffer();
}
@@ -541,6 +542,13 @@
TypeOperations::initialize(begin(), end());
}
+Vector(size_t size, const T val)
+: Base(size, size)
+{
+if (begin())
+TypeOperations::uninitializedFill(begin(), end(), val);
+}
+
~Vector()
{
if (m_size)
@@ -653,19 +661,12 @@
shrink(size() - 1);
}
-Vector(size_t size, const T val)
-: Base(size, size)
-{
-if (begin())
-TypeOperations::uninitializedFill(begin(), end(), val);
-}
-
void fill(const T, size_t);
void fill(const T val) { fill(val, size()); }
templatetypename Iterator void appendRange(Iterator start, Iterator end);
-T* releaseBuffer();
+OwnPtrT releaseBuffer();
void swap(VectorT, inlineCapacity, OverflowHandler other)
{
@@ -1152,19 +1153,19 @@
}
templatetypename T, size_t inlineCapacity, typename OverflowHandler
-inline T* VectorT, inlineCapacity, OverflowHandler::releaseBuffer()
+inline OwnPtrT VectorT, inlineCapacity, OverflowHandler::releaseBuffer()
{
-T* buffer = Base::releaseBuffer();
+OwnPtrT buffer = Base::releaseBuffer();
if (inlineCapacity !buffer m_size) {
// If the vector had some data, but no buffer to release,
// that means it was using the inline buffer. In that case,
// we create a brand new buffer so the caller always gets one.
size_t bytes = m_size * sizeof(T);
-buffer = static_castT*(fastMalloc(bytes));
-memcpy(buffer, data(), bytes);
+buffer = adoptPtr(static_castT*(fastMalloc(bytes)));
+memcpy(buffer.get(), data(), bytes);
}
m_size = 0;
-return buffer;
+return buffer.release();
}
templatetypename T, size_t inlineCapacity, typename OverflowHandler
Modified: trunk/Source/WTF/wtf/text/StringBuffer.h
[webkit-changes] [155123] trunk/Source/JavaScriptCore
Title: [155123] trunk/Source/_javascript_Core Revision 155123 Author bfulg...@apple.com Date 2013-09-05 09:28:15 -0700 (Thu, 05 Sep 2013) Log Message [Windows] Unreviewed build fix for DebugSuffix target. * _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: Don't build 64-bit assembly in 32-bit build. Also correct 'filters' file so that files appear in categories that match their on-disk locations. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters Diff Modified: trunk/Source/_javascript_Core/ChangeLog (155122 => 155123) --- trunk/Source/_javascript_Core/ChangeLog 2013-09-05 15:54:07 UTC (rev 155122) +++ trunk/Source/_javascript_Core/ChangeLog 2013-09-05 16:28:15 UTC (rev 155123) @@ -1,3 +1,10 @@ +2013-09-05 Brent Fulgham bfulg...@apple.com + +[Windows] Unreviewed build fix for DebugSuffix target. + +* _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: Don't build 64-bit assembly in 32-bit build. +Also correct 'filters' file so that files appear in categories that match their on-disk locations. + 2013-09-04 Filip Pizlo fpi...@apple.com jsc tests should have timeouts Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters (155122 => 155123) --- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters 2013-09-05 15:54:07 UTC (rev 155122) +++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters 2013-09-05 16:28:15 UTC (rev 155123) @@ -858,13 +858,28 @@ ClCompile Include=..\runtime\JSPromise.cpp Filterruntime/Filter /ClCompile -ClCompile Include=..\bytecode\DeferredCompilationCallback.cpp / -ClCompile Include=..\dfg\DFGCompilationKey.cpp / -ClCompile Include=..\dfg\DFGCompilationMode.cpp / -ClCompile Include=..\dfg\DFGDriver.cpp / -ClCompile Include=..\heap\CodeBlockSet.cpp / -ClCompile Include=..\jit\JITToDFGDeferredCompilationCallback.cpp / -ClCompile Include=..\llint\LLIntEntrypoint.cpp / +ClCompile Include=..\heap\CodeBlockSet.cpp + Filterheap/Filter +/ClCompile +ClCompile Include=..\bytecode\DeferredCompilationCallback.cpp + Filterbytecode/Filter +/ClCompile +ClCompile Include=..\dfg\DFGCompilationKey.cpp + Filterdfg/Filter +/ClCompile +ClCompile Include=..\dfg\DFGDriver.cpp + Filterdfg/Filter +/ClCompile +ClCompile Include=..\dfg\DFGCompilationMode.cpp + Filterdfg/Filter +/ClCompile +ClCompile Include=..\jit\JITToDFGDeferredCompilationCallback.cpp + Filterjit/Filter +/ClCompile +ClCompile Include=..\llint\LLIntEntrypoint.cpp + Filterllint/Filter +/ClCompile + /ItemGroup ItemGroup ClInclude Include=..\API\APICallbackFunction.h @@ -2224,19 +2239,45 @@ ClInclude Include=$(ConfigurationBuildDir)\obj$(PlatformArchitecture)\$(ProjectName)\DerivedSources\NamePrototype.lut.h FilterDerived Sources/Filter /ClInclude -ClInclude Include=..\bytecode\DeferredCompilationCallback.h / -ClInclude Include=..\dfg\DFGCompilationKey.h / -ClInclude Include=..\dfg\DFGCompilationMode.h / -ClInclude Include=..\heap\CodeBlockSet.h / -ClInclude Include=..\jit\JITToDFGDeferredCompilationCallback.h / -ClInclude Include=..\llint\LLIntEntrypoint.h / -ClInclude Include=..\runtime\JSMap.h / -ClInclude Include=..\runtime\JSSet.h / -ClInclude Include=..\runtime\MapConstructor.h / -ClInclude Include=..\runtime\MapData.h / -ClInclude Include=..\runtime\MapPrototype.h / -ClInclude Include=..\runtime\SetConstructor.h / -ClInclude Include=..\runtime\SetPrototype.h / +ClInclude Include=..\heap\CodeBlockSet.h + Filterheap/Filter +/ClInclude +ClInclude Include=..\bytecode\DeferredCompilationCallback.h + Filterbytecode/Filter +/ClInclude +ClInclude Include=..\dfg\DFGCompilationKey.h + Filterdfg/Filter +/ClInclude +ClInclude Include=..\dfg\DFGCompilationMode.h + Filterdfg/Filter +/ClInclude +ClInclude Include=..\jit\JITToDFGDeferredCompilationCallback.h + Filterjit/Filter +/ClInclude +ClInclude Include=..\runtime\JSMap.h + Filterruntime/Filter +/ClInclude +ClInclude Include=..\runtime\JSSet.h + Filterruntime/Filter +/ClInclude +ClInclude Include=..\llint\LLIntEntrypoint.h + Filterllint/Filter +/ClInclude +ClInclude Include=..\runtime\MapConstructor.h + Filterruntime/Filter +/ClInclude +ClInclude Include=..\runtime\MapData.h + Filterruntime/Filter +/ClInclude +ClInclude Include=..\runtime\SetPrototype.h + Filterruntime/Filter +/ClInclude +ClInclude Include=..\runtime\MapPrototype.h + Filterruntime/Filter +/ClInclude +ClInclude Include=..\runtime\SetConstructor.h + Filterruntime/Filter +/ClInclude
[webkit-changes] [155127] trunk/Source/WebCore
Title: [155127] trunk/Source/WebCore Revision 155127 Author roger_f...@apple.com Date 2013-09-05 10:21:16 -0700 (Thu, 05 Sep 2013) Log Message Link to libdispatch_debug.lib when using DebugSuffix configuration. https://bugs.webkit.org/show_bug.cgi?id=120712. rdar://problem/14883216. Reviewed by Brent Fulgham. * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (155126 => 155127) --- trunk/Source/WebCore/ChangeLog 2013-09-05 17:11:55 UTC (rev 155126) +++ trunk/Source/WebCore/ChangeLog 2013-09-05 17:21:16 UTC (rev 155127) @@ -418,6 +418,16 @@ 2013-09-04 Roger Fong roger_f...@apple.com +Link to libdispatch_debug.lib when using DebugSuffix configuration. +https://bugs.webkit.org/show_bug.cgi?id=120712. +rdar://problem/14883216. + +Reviewed by Brent Fulgham. + +* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: + +2013-09-04 Roger Fong roger_f...@apple.com + Unreviewed. Windows build fix and WebCore project cleanup. * WebCore.vcxproj/WebCore.vcxproj.filters: Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp (155126 => 155127) --- trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp 2013-09-05 17:11:55 UTC (rev 155126) +++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp 2013-09-05 17:21:16 UTC (rev 155127) @@ -66,7 +66,11 @@ #include CoreMediaSoftLinking.h // We don't bother softlinking against libdispatch since it's already been loaded by AAS. +#ifdef DEBUG_ALL +#pragma comment(lib, libdispatch_debug.lib) +#else #pragma comment(lib, libdispatch.lib) +#endif using namespace std; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155128] trunk/LayoutTests
Title: [155128] trunk/LayoutTests Revision 155128 Author commit-qu...@webkit.org Date 2013-09-05 10:28:28 -0700 (Thu, 05 Sep 2013) Log Message [GTK] improving tests expectations related to trackmenu https://bugs.webkit.org/show_bug.cgi?id=120699 Adding tests expectations to the current GTK's trackmenu implementation. Also adding a in-band-track test expectation as failure since we don't support in-band tracks yet. Patch by Danilo Cesar Lemes de Paula danilo.ce...@collabora.co.uk on 2013-09-05 Reviewed by Gustavo Noronha Silva. * platform/gtk/TestExpectations: * platform/gtk/media/video-controls-captions-trackmenu-expected.txt: Added. * platform/gtk/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added. * platform/gtk/media/video-controls-captions-trackmenu-localized-expected.txt: Added. * platform/gtk/media/video-controls-captions-trackmenu-sorted-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Added Paths trunk/LayoutTests/platform/gtk/media/video-controls-captions-trackmenu-expected.txt trunk/LayoutTests/platform/gtk/media/video-controls-captions-trackmenu-hide-on-click-expected.txt trunk/LayoutTests/platform/gtk/media/video-controls-captions-trackmenu-localized-expected.txt trunk/LayoutTests/platform/gtk/media/video-controls-captions-trackmenu-sorted-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (155127 => 155128) --- trunk/LayoutTests/ChangeLog 2013-09-05 17:21:16 UTC (rev 155127) +++ trunk/LayoutTests/ChangeLog 2013-09-05 17:28:28 UTC (rev 155128) @@ -1,3 +1,22 @@ +2013-09-05 Danilo Cesar Lemes de Paula danilo.ce...@collabora.co.uk + +[GTK] improving tests expectations related to trackmenu +https://bugs.webkit.org/show_bug.cgi?id=120699 + +Adding tests expectations to the current GTK's trackmenu +implementation. + +Also adding a in-band-track test expectation as failure since we don't +support in-band tracks yet. + +Reviewed by Gustavo Noronha Silva. + +* platform/gtk/TestExpectations: +* platform/gtk/media/video-controls-captions-trackmenu-expected.txt: Added. +* platform/gtk/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added. +* platform/gtk/media/video-controls-captions-trackmenu-localized-expected.txt: Added. +* platform/gtk/media/video-controls-captions-trackmenu-sorted-expected.txt: Added. + 2013-09-05 Filip Pizlo fpi...@apple.com fast/js/dfg-* tests should wait for the concurrent JIT Modified: trunk/LayoutTests/platform/gtk/TestExpectations (155127 => 155128) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-05 17:21:16 UTC (rev 155127) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-05 17:28:28 UTC (rev 155128) @@ -382,6 +382,7 @@ # No support for exposing in-band text tracks webkit.org/b/103771 media/track/track-forced-subtitles-in-band.html [ Timeout Failure ] +webkit.org/b/103771 media/track/track-in-band-duplicate-tracks-when-source-changes.html [ Failure ] webkit.org/b/103771 media/track/track-in-band.html [ Failure ] webkit.org/b/103771 media/track/track-in-band-cues-added-once.html [ Timeout ] webkit.org/b/103771 media/track/track-in-band-style.html [ Timeout ] Added: trunk/LayoutTests/platform/gtk/media/video-controls-captions-trackmenu-expected.txt (0 => 155128) --- trunk/LayoutTests/platform/gtk/media/video-controls-captions-trackmenu-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/media/video-controls-captions-trackmenu-expected.txt 2013-09-05 17:28:28 UTC (rev 155128) @@ -0,0 +1,39 @@ +Test that we are able to trigger the list of captions, and select from the list. + +EVENT(canplaythrough) + +*** Set the user language preference. +RUN(internals.setUserPreferredLanguages(['en'])) + +*** Add another text track. +RUN(video.addTextTrack(captions, Commentary, ru)) + +*** Turning captions on +There should be 6 items in the menu. +EXPECTED (trackListItems.length == '6') OK +EXPECTED (video.textTracks.length == '4') OK +Track 0 should be showing +EXPECTED (video.textTracks[0].mode == 'showing') OK +Track 1 should be disabled +EXPECTED (video.textTracks[1].mode == 'disabled') OK +Track 2 should be disabled +EXPECTED (video.textTracks[2].mode == 'disabled') OK +Track 3 should be disabled +EXPECTED (video.textTracks[3].mode == 'disabled') OK +EXPECTED (textTrackDisplayElement(video, 'display').innerText == 'Lorem') OK + +*** Remove a track. +RUN(video.removeChild(document.querySelectorAll(track)[0])) +*** Turning captions off +There should be 5 items in the menu. +EXPECTED (trackListItems.length == '5') OK +EXPECTED (video.textTracks.length == '3') OK +Track 0 should be disabled +EXPECTED (video.textTracks[0].mode == 'disabled') OK +Track 1 should be disabled +EXPECTED (video.textTracks[1].mode == 'disabled') OK +Track 2 should be disabled +EXPECTED (video.textTracks[2].mode
[webkit-changes] [155136] trunk/Source/WebCore
Title: [155136] trunk/Source/WebCore
Revision 155136
Author joep...@webkit.org
Date 2013-09-05 11:29:30 -0700 (Thu, 05 Sep 2013)
Log Message
Fix build warning about unused variable.
Unreviewed build fix.
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::evaluateBreakpointAction):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155135 => 155136)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 18:23:02 UTC (rev 155135)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 18:29:30 UTC (rev 155136)
@@ -1,3 +1,12 @@
+2013-09-05 Joseph Pecoraro pecor...@apple.com
+
+Fix build warning about unused variable.
+
+Unreviewed build fix.
+
+* bindings/js/ScriptDebugServer.cpp:
+(WebCore::ScriptDebugServer::evaluateBreakpointAction):
+
2013-09-05 Anders Carlsson ander...@apple.com
Enable C++11 wherever we build C++ files that include wtf/Platform.h
Modified: trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp (155135 => 155136)
--- trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp 2013-09-05 18:23:02 UTC (rev 155135)
+++ trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp 2013-09-05 18:29:30 UTC (rev 155136)
@@ -194,7 +194,7 @@
}
case ScriptBreakpointActionTypeEvaluate: {
JSValue exception;
-JSValue result = m_currentCallFrame-evaluate(breakpointAction.data, exception);
+m_currentCallFrame-evaluate(breakpointAction.data, exception);
if (exception)
reportException(m_currentCallFrame-exec(), exception);
break;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155129] branches/safari-537-branch
Title: [155129] branches/safari-537-branch
Revision 155129
Author lforsch...@apple.com
Date 2013-09-05 10:35:59 -0700 (Thu, 05 Sep 2013)
Log Message
Merged r154037. rdar://problem/14705502
Modified Paths
branches/safari-537-branch/LayoutTests/ChangeLog
branches/safari-537-branch/Source/WebCore/ChangeLog
branches/safari-537-branch/Source/WebCore/dom/SelectorQuery.cpp
Added Paths
branches/safari-537-branch/LayoutTests/fast/selectors/querySelector-id-with-multiple-elements-with-same-id-expected.txt
branches/safari-537-branch/LayoutTests/fast/selectors/querySelector-id-with-multiple-elements-with-same-id.html
Diff
Modified: branches/safari-537-branch/LayoutTests/ChangeLog (155128 => 155129)
--- branches/safari-537-branch/LayoutTests/ChangeLog 2013-09-05 17:28:28 UTC (rev 155128)
+++ branches/safari-537-branch/LayoutTests/ChangeLog 2013-09-05 17:35:59 UTC (rev 155129)
@@ -1,3 +1,17 @@
+2013-09-05 Lucas Forschler lforsch...@apple.com
+
+Merge r154037
+
+2013-08-13 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION(r150187): Safari fails to render allrecipe.com comment popups
+https://bugs.webkit.org/show_bug.cgi?id=119780
+
+Reviewed by Benjamin Poulain.
+
+* fast/selectors/querySelector-id-with-multiple-elements-with-same-id-expected.txt: Added.
+* fast/selectors/querySelector-id-with-multiple-elements-with-same-id.html: Added.
+
2013-09-04 Lucas Forschler lforsch...@apple.com
Merge r155014
Copied: branches/safari-537-branch/LayoutTests/fast/selectors/querySelector-id-with-multiple-elements-with-same-id-expected.txt (from rev 154037, trunk/LayoutTests/fast/selectors/querySelector-id-with-multiple-elements-with-same-id-expected.txt) (0 => 155129)
--- branches/safari-537-branch/LayoutTests/fast/selectors/querySelector-id-with-multiple-elements-with-same-id-expected.txt (rev 0)
+++ branches/safari-537-branch/LayoutTests/fast/selectors/querySelector-id-with-multiple-elements-with-same-id-expected.txt 2013-09-05 17:35:59 UTC (rev 155129)
@@ -0,0 +1,11 @@
+This test makes sure WebKit element.querySelector(#foo) returns a descendent node of the element even when there are multiple elements with the id foo.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS container.querySelectorAll(#foo).length is 1
+PASS container.querySelectorAll(#foo)[0] is container.firstChild
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: branches/safari-537-branch/LayoutTests/fast/selectors/querySelector-id-with-multiple-elements-with-same-id.html (from rev 154037, trunk/LayoutTests/fast/selectors/querySelector-id-with-multiple-elements-with-same-id.html) (0 => 155129)
--- branches/safari-537-branch/LayoutTests/fast/selectors/querySelector-id-with-multiple-elements-with-same-id.html (rev 0)
+++ branches/safari-537-branch/LayoutTests/fast/selectors/querySelector-id-with-multiple-elements-with-same-id.html 2013-09-05 17:35:59 UTC (rev 155129)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+body
+span id=foo/span
+div id=containerspan id=foo/span/div
+/body
+script src=""
+script
+description('This test makes sure WebKit element.querySelector(#foo) returns a descendent node of the element even when there are multiple elements with the id foo.');
+
+var container = document.getElementById('container');
+shouldBe('container.querySelectorAll(#foo).length', '1');
+shouldBe('container.querySelectorAll(#foo)[0]', 'container.firstChild');
+
+/script
+script src=""
+/html
Modified: branches/safari-537-branch/Source/WebCore/ChangeLog (155128 => 155129)
--- branches/safari-537-branch/Source/WebCore/ChangeLog 2013-09-05 17:28:28 UTC (rev 155128)
+++ branches/safari-537-branch/Source/WebCore/ChangeLog 2013-09-05 17:35:59 UTC (rev 155129)
@@ -1,3 +1,26 @@
+2013-09-05 Lucas Forschler lforsch...@apple.com
+
+Merge r154037
+
+2013-08-13 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION(r150187): Safari fails to render allrecipe.com comment popups
+https://bugs.webkit.org/show_bug.cgi?id=119780
+
+Reviewed by Benjamin Poulain.
+
+The bug was caused by SelectorDataList::executeFastPathForIdSelector not verifying that
+elements found by getAllElementsById are descendents of rootNode when there are multiple
+elements of the same id. This resulted in querySelector and querySelectorAll of an element
+returning nodes outside of the element.
+
+Fixed the bug by checking this condition when we have multiple elements of the same id.
+
+Test: fast/selectors/querySelector-id-with-multiple-elements-with-same-id.html
+
+* dom/SelectorQuery.cpp:
+(WebCore::SelectorDataList::executeFastPathForIdSelector):
+
2013-09-04 Dean Jackson d...@apple.com
rdar://problem/14910916 Disable CSS_SHAPES on safari-537-branch
Modified:
[webkit-changes] [155138] trunk/Source/WebCore
Title: [155138] trunk/Source/WebCore
Revision 155138
Author timothy_hor...@apple.com
Date 2013-09-05 12:25:21 -0700 (Thu, 05 Sep 2013)
Log Message
iOS build broke with change to make Mac use PDFKit for PDFDocumentImage
https://bugs.webkit.org/show_bug.cgi?id=120771
Reviewed by Anders Carlsson.
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::createPDFDocument):
Use the (removed in r155069) PLATFORM(MAC) way of making a CGDataProvider from a SharedBuffer
everywhere; this is what iOS was expecting to use (where I accidentally changed behavior),
and it should also work for Windows, the only other USE(CG) platform.
Since we only createPDFDocument() after all data has been received, I'm not
restoring the comment about the SharedBuffer being secretly written to behind its back.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155137 => 155138)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 18:58:07 UTC (rev 155137)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 19:25:21 UTC (rev 155138)
@@ -1,3 +1,19 @@
+2013-09-05 Tim Horton timothy_hor...@apple.com
+
+iOS build broke with change to make Mac use PDFKit for PDFDocumentImage
+https://bugs.webkit.org/show_bug.cgi?id=120771
+
+Reviewed by Anders Carlsson.
+
+* platform/graphics/cg/PDFDocumentImage.cpp:
+(WebCore::PDFDocumentImage::createPDFDocument):
+Use the (removed in r155069) PLATFORM(MAC) way of making a CGDataProvider from a SharedBuffer
+everywhere; this is what iOS was expecting to use (where I accidentally changed behavior),
+and it should also work for Windows, the only other USE(CG) platform.
+
+Since we only createPDFDocument() after all data has been received, I'm not
+restoring the comment about the SharedBuffer being secretly written to behind its back.
+
2013-09-04 Dean Jackson d...@apple.com
Rename supportsContext to probablySupportsContext
Modified: trunk/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp (155137 => 155138)
--- trunk/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp 2013-09-05 18:58:07 UTC (rev 155137)
+++ trunk/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp 2013-09-05 19:25:21 UTC (rev 155138)
@@ -145,13 +145,8 @@
#if !USE(PDFKIT_FOR_PDFDOCUMENTIMAGE)
void PDFDocumentImage::createPDFDocument()
{
-// Create a CGDataProvider to wrap the SharedBuffer.
-// We use the GetBytesAtPosition callback rather than the GetBytePointer one because SharedBuffer
-// does not provide a way to lock down the byte pointer and guarantee that it won't move, which
-// is a requirement for using the GetBytePointer callback.
-
-CGDataProviderDirectCallbacks providerCallbacks = { 0, 0, 0, sharedBufferGetBytesAtPosition, 0 };
-RetainPtrCGDataProviderRef dataProvider = adoptCF(CGDataProviderCreateDirect(this-data(), this-data()-size(), providerCallbacks));
+RetainPtrCFDataRef data = ""
+RetainPtrCGDataProviderRef dataProvider = adoptCF(CGDataProviderCreateWithCFData(data.get()));
m_document = CGPDFDocumentCreateWithProvider(dataProvider.get());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155140] trunk/Tools
Title: [155140] trunk/Tools
Revision 155140
Author simon.fra...@apple.com
Date 2013-09-05 12:38:48 -0700 (Thu, 05 Sep 2013)
Log Message
Expected result images are sometimes blank in WKTR
https://bugs.webkit.org/show_bug.cgi?id=120715
Reviewed by Tim Horton.
In WebKitTestRunner, snapshots obtained via windowSnapshotImage() were
sometimes blank if a previous test triggered compositing mode, and the
current test or reference did not require compositing. This happened
because the UI process didn't wait for the web process to complete
its compositing mode switch before snapshotting. Fix by calling
WKPageForceRepaint() before we take the snapshot; this is async,
so we have to spin the runloop for a while.
Remove the Qt/EFL code that does the same thing.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::forceRepaintDoneCallback):
(WTR::TestInvocation::dumpResults):
* WebKitTestRunner/TestInvocation.h:
* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestInvocation.cpp
trunk/Tools/WebKitTestRunner/TestInvocation.h
trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp
trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp
Diff
Modified: trunk/Tools/ChangeLog (155139 => 155140)
--- trunk/Tools/ChangeLog 2013-09-05 19:32:35 UTC (rev 155139)
+++ trunk/Tools/ChangeLog 2013-09-05 19:38:48 UTC (rev 155140)
@@ -1,3 +1,29 @@
+2013-09-05 Simon Fraser simon.fra...@apple.com
+
+Expected result images are sometimes blank in WKTR
+https://bugs.webkit.org/show_bug.cgi?id=120715
+
+Reviewed by Tim Horton.
+
+In WebKitTestRunner, snapshots obtained via windowSnapshotImage() were
+sometimes blank if a previous test triggered compositing mode, and the
+current test or reference did not require compositing. This happened
+because the UI process didn't wait for the web process to complete
+its compositing mode switch before snapshotting. Fix by calling
+WKPageForceRepaint() before we take the snapshot; this is async,
+so we have to spin the runloop for a while.
+
+Remove the Qt/EFL code that does the same thing.
+
+* WebKitTestRunner/TestInvocation.cpp:
+(WTR::TestInvocation::forceRepaintDoneCallback):
+(WTR::TestInvocation::dumpResults):
+* WebKitTestRunner/TestInvocation.h:
+* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
+(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
+* WebKitTestRunner/qt/TestInvocationQt.cpp:
+(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
+
2013-09-05 Csaba Osztrogonác o...@webkit.org
Make build.webkit.org report the number of failing run-fast-jsc tests
Modified: trunk/Tools/WebKitTestRunner/TestInvocation.cpp (155139 => 155140)
--- trunk/Tools/WebKitTestRunner/TestInvocation.cpp 2013-09-05 19:32:35 UTC (rev 155139)
+++ trunk/Tools/WebKitTestRunner/TestInvocation.cpp 2013-09-05 19:38:48 UTC (rev 155140)
@@ -310,6 +310,12 @@
fflush(stderr);
}
+void TestInvocation::forceRepaintDoneCallback(WKErrorRef, void* context)
+{
+TestInvocation* testInvocation = static_castTestInvocation*(context);
+testInvocation-m_gotRepaint = true;
+}
+
void TestInvocation::dumpResults()
{
if (m_textOutput.length() || !m_audioResult)
@@ -317,8 +323,17 @@
else
dumpAudio(m_audioResult.get());
-if (m_dumpPixels m_pixelResult)
+if (m_dumpPixels m_pixelResult) {
+m_gotRepaint = false;
+WKPageForceRepaint(TestController::shared().mainWebView()-page(), this, TestInvocation::forceRepaintDoneCallback);
+TestController::shared().runUntil(m_gotRepaint, TestController::ShortTimeout);
+if (!m_gotRepaint) {
+m_errorMessage = Timed out waiting for pre-pixel dump repaint\n;
+m_webProcessIsUnresponsive = true;
+return;
+}
dumpPixelsAndCompareWithExpected(m_pixelResult.get(), m_repaintRects.get());
+}
fputs(#EOF\n, stdout);
fflush(stdout);
Modified: trunk/Tools/WebKitTestRunner/TestInvocation.h (155139 => 155140)
--- trunk/Tools/WebKitTestRunner/TestInvocation.h 2013-09-05 19:32:35 UTC (rev 155139)
+++ trunk/Tools/WebKitTestRunner/TestInvocation.h 2013-09-05 19:38:48 UTC (rev 155140)
@@ -58,10 +58,8 @@
void dumpAudio(WKDataRef);
bool compareActualHashToExpectedAndDumpResults(const char[33]);
-#if PLATFORM(QT) || PLATFORM(EFL)
static void forceRepaintDoneCallback(WKErrorRef, void* context);
-#endif
-
+
WKRetainPtrWKURLRef m_url;
std::string m_pathOrURL;
Modified: trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp (155139 => 155140)
--- trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp
[webkit-changes] [155149] trunk/Source/JavaScriptCore
Title: [155149] trunk/Source/_javascript_Core Revision 155149 Author fpi...@apple.com Date 2013-09-05 14:19:09 -0700 (Thu, 05 Sep 2013) Log Message REGRESSION(149636, merged in 153145): ToThis conversion doesn't work in the DFG https://bugs.webkit.org/show_bug.cgi?id=120781 Reviewed by Mark Hahnenberg. - Use some method table hacks to detect if the CheckStructure optimization is valid for to_this. - Introduce a FinalObjectUse and use it for ToThis-Identity conversion. This looks like it might be perf-neutral on the major benchmarks, but it introduces some horrible performance cliffs. For example if you add methods to the Array prototype, you'll get horrible performance cliffs. As in virtual calls to C++ every time you call a JS function even if it's inlined. LongSpider/3d-cube appears to hit this. * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFGexecuteEffects): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): * dfg/DFGSafeToExecute.h: (JSC::DFG::SafeToExecuteEdge::operator()): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::speculateFinalObject): (JSC::DFG::SpeculativeJIT::speculate): * dfg/DFGSpeculativeJIT.h: * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGUseKind.cpp: (WTF::printInternal): * dfg/DFGUseKind.h: (JSC::DFG::typeFilterFor): (JSC::DFG::isCell): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp trunk/Source/_javascript_Core/dfg/DFGUseKind.cpp trunk/Source/_javascript_Core/dfg/DFGUseKind.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (155148 => 155149) --- trunk/Source/_javascript_Core/ChangeLog 2013-09-05 21:17:35 UTC (rev 155148) +++ trunk/Source/_javascript_Core/ChangeLog 2013-09-05 21:19:09 UTC (rev 155149) @@ -1,3 +1,43 @@ +2013-09-05 Filip Pizlo fpi...@apple.com + +REGRESSION(149636, merged in 153145): ToThis conversion doesn't work in the DFG +https://bugs.webkit.org/show_bug.cgi?id=120781 + +Reviewed by Mark Hahnenberg. + +- Use some method table hacks to detect if the CheckStructure optimization is + valid for to_this. + +- Introduce a FinalObjectUse and use it for ToThis-Identity conversion. + +This looks like it might be perf-neutral on the major benchmarks, but it +introduces some horrible performance cliffs. For example if you add methods to +the Array prototype, you'll get horrible performance cliffs. As in virtual calls +to C++ every time you call a JS function even if it's inlined. +LongSpider/3d-cube appears to hit this. + +* dfg/DFGAbstractInterpreterInlines.h: +(JSC::DFGexecuteEffects): +* dfg/DFGByteCodeParser.cpp: +(JSC::DFG::ByteCodeParser::parseBlock): +* dfg/DFGFixupPhase.cpp: +(JSC::DFG::FixupPhase::fixupNode): +* dfg/DFGSafeToExecute.h: +(JSC::DFG::SafeToExecuteEdge::operator()): +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::speculateFinalObject): +(JSC::DFG::SpeculativeJIT::speculate): +* dfg/DFGSpeculativeJIT.h: +* dfg/DFGSpeculativeJIT32_64.cpp: +(JSC::DFG::SpeculativeJIT::compile): +* dfg/DFGSpeculativeJIT64.cpp: +(JSC::DFG::SpeculativeJIT::compile): +* dfg/DFGUseKind.cpp: +(WTF::printInternal): +* dfg/DFGUseKind.h: +(JSC::DFG::typeFilterFor): +(JSC::DFG::isCell): + 2013-09-05 Anders Carlsson ander...@apple.com GCAssertions.h should use STL type traits and static_assert Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (155148 => 155149) --- trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2013-09-05 21:17:35 UTC (rev 155148) +++ trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2013-09-05 21:19:09 UTC (rev 155149) @@ -1086,7 +1086,7 @@ AbstractValue destination = forNode(node); destination = source; -destination.merge(SpecObjectOther); +destination.merge(SpecObject); break; } Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (155148 => 155149) --- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2013-09-05 21:17:35 UTC (rev 155148) +++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2013-09-05
[webkit-changes] [155150] trunk/Source/WebCore
Title: [155150] trunk/Source/WebCore
Revision 155150
Author akl...@apple.com
Date 2013-09-05 14:25:32 -0700 (Thu, 05 Sep 2013)
Log Message
Cached Page and Frame don't need to be ref-counted.
https://webkit.org/b/120710
Reviewed by Anders Carlsson.
- CachedPage is owned by HistoryItem.
- CachedFrame is owned by CachedPage.
Remove the ref counting from these objects to make the code less confusing.
Added a new method:
- PassOwnPtrCachedPage PageCache::take(HistoryItem*)
..which is what it looks like - a combined get() and remove() that transfers
ownership of the CachedPage to the caller.
This is used by commitProvisionalLoad() and invalidateCurrentItemCachedPage()
to accomplish in one swoop what they used to do in awkwardly spaced steps.
* history/CachedFrame.h:
(WebCore::CachedFrame::create):
* history/CachedPage.cpp:
(WebCore::CachedPage::create):
* history/CachedPage.h:
* history/HistoryItem.h:
* history/PageCache.cpp:
(WebCore::PageCache::take):
* history/PageCache.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::transitionToCommitted):
* loader/FrameLoader.h:
* loader/HistoryController.cpp:
(WebCore::HistoryController::invalidateCurrentItemCachedPage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/CachedFrame.h
trunk/Source/WebCore/history/CachedPage.cpp
trunk/Source/WebCore/history/CachedPage.h
trunk/Source/WebCore/history/HistoryItem.h
trunk/Source/WebCore/history/PageCache.cpp
trunk/Source/WebCore/history/PageCache.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.h
trunk/Source/WebCore/loader/HistoryController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155149 => 155150)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 21:19:09 UTC (rev 155149)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 21:25:32 UTC (rev 155150)
@@ -1,3 +1,41 @@
+2013-09-05 Andreas Kling akl...@apple.com
+
+Cached Page and Frame don't need to be ref-counted.
+https://webkit.org/b/120710
+
+Reviewed by Anders Carlsson.
+
+- CachedPage is owned by HistoryItem.
+- CachedFrame is owned by CachedPage.
+
+Remove the ref counting from these objects to make the code less confusing.
+
+Added a new method:
+
+- PassOwnPtrCachedPage PageCache::take(HistoryItem*)
+
+..which is what it looks like - a combined get() and remove() that transfers
+ownership of the CachedPage to the caller.
+
+This is used by commitProvisionalLoad() and invalidateCurrentItemCachedPage()
+to accomplish in one swoop what they used to do in awkwardly spaced steps.
+
+* history/CachedFrame.h:
+(WebCore::CachedFrame::create):
+* history/CachedPage.cpp:
+(WebCore::CachedPage::create):
+* history/CachedPage.h:
+* history/HistoryItem.h:
+* history/PageCache.cpp:
+(WebCore::PageCache::take):
+* history/PageCache.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::commitProvisionalLoad):
+(WebCore::FrameLoader::transitionToCommitted):
+* loader/FrameLoader.h:
+* loader/HistoryController.cpp:
+(WebCore::HistoryController::invalidateCurrentItemCachedPage):
+
2013-09-05 David Kilzer ddkil...@apple.com
BUILD FIX (r155108): Add SynchronousLoaderClientCFNet.cpp to Xcode project
Modified: trunk/Source/WebCore/history/CachedFrame.h (155149 => 155150)
--- trunk/Source/WebCore/history/CachedFrame.h 2013-09-05 21:19:09 UTC (rev 155149)
+++ trunk/Source/WebCore/history/CachedFrame.h 2013-09-05 21:25:32 UTC (rev 155150)
@@ -30,7 +30,6 @@
#include KURL.h
#include ScriptCachedFrameData.h
#include wtf/PassOwnPtr.h
-#include wtf/RefCounted.h
#include wtf/RefPtr.h
namespace WebCore {
@@ -67,12 +66,12 @@
bool m_isComposited;
#endif
-VectorRefPtrCachedFrame m_childFrames;
+VectorOwnPtrCachedFrame m_childFrames;
};
-class CachedFrame : public RefCountedCachedFrame, private CachedFrameBase {
+class CachedFrame : private CachedFrameBase {
public:
-static PassRefPtrCachedFrame create(Frame frame) { return adoptRef(new CachedFrame(frame)); }
+static PassOwnPtrCachedFrame create(Frame frame) { return adoptPtr(new CachedFrame(frame)); }
void open();
void clear();
Modified: trunk/Source/WebCore/history/CachedPage.cpp (155149 => 155150)
--- trunk/Source/WebCore/history/CachedPage.cpp 2013-09-05 21:19:09 UTC (rev 155149)
+++ trunk/Source/WebCore/history/CachedPage.cpp 2013-09-05 21:25:32 UTC (rev 155150)
@@ -45,9 +45,9 @@
DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, cachedPageCounter, (CachedPage));
-PassRefPtrCachedPage CachedPage::create(Page page)
+PassOwnPtrCachedPage CachedPage::create(Page page)
{
-return adoptRef(new CachedPage(page));
+return adoptPtr(new CachedPage(page));
}
CachedPage::CachedPage(Page page)
Modified:
[webkit-changes] [155151] trunk/Tools
Title: [155151] trunk/Tools
Revision 155151
Author ander...@apple.com
Date 2013-09-05 14:34:17 -0700 (Thu, 05 Sep 2013)
Log Message
Move all Vector tests into Vector.cpp
https://bugs.webkit.org/show_bug.cgi?id=120797
Reviewed by Andreas Kling.
* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/GNUmakefile.am:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/VectorBasic.cpp: Removed.
* TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Removed.
* TestWebKitAPI/Tests/WTF/WTF.pro:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/CMakeLists.txt
trunk/Tools/TestWebKitAPI/GNUmakefile.am
trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj
trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/WTF.pro
Removed Paths
trunk/Tools/TestWebKitAPI/Tests/WTF/VectorBasic.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/VectorReverse.cpp
Diff
Modified: trunk/Tools/ChangeLog (155150 => 155151)
--- trunk/Tools/ChangeLog 2013-09-05 21:25:32 UTC (rev 155150)
+++ trunk/Tools/ChangeLog 2013-09-05 21:34:17 UTC (rev 155151)
@@ -1,3 +1,21 @@
+2013-09-05 Anders Carlsson ander...@apple.com
+
+Move all Vector tests into Vector.cpp
+https://bugs.webkit.org/show_bug.cgi?id=120797
+
+Reviewed by Andreas Kling.
+
+* TestWebKitAPI/CMakeLists.txt:
+* TestWebKitAPI/GNUmakefile.am:
+* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
+* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WTF/Vector.cpp:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WTF/VectorBasic.cpp: Removed.
+* TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Removed.
+* TestWebKitAPI/Tests/WTF/WTF.pro:
+
2013-09-05 Simon Fraser simon.fra...@apple.com
Expected result images are sometimes blank in WKTR
Modified: trunk/Tools/TestWebKitAPI/CMakeLists.txt (155150 => 155151)
--- trunk/Tools/TestWebKitAPI/CMakeLists.txt 2013-09-05 21:25:32 UTC (rev 155150)
+++ trunk/Tools/TestWebKitAPI/CMakeLists.txt 2013-09-05 21:34:17 UTC (rev 155151)
@@ -111,7 +111,6 @@
${TESTWEBKITAPI_DIR}/Tests/WTF/StringOperators.cpp
${TESTWEBKITAPI_DIR}/Tests/WTF/TemporaryChange.cpp
${TESTWEBKITAPI_DIR}/Tests/WTF/Vector.cpp
-${TESTWEBKITAPI_DIR}/Tests/WTF/VectorBasic.cpp
${TESTWEBKITAPI_DIR}/Tests/WTF/VectorReverse.cpp
${TESTWEBKITAPI_DIR}/Tests/WTF/WTFString.cpp
)
Modified: trunk/Tools/TestWebKitAPI/GNUmakefile.am (155150 => 155151)
--- trunk/Tools/TestWebKitAPI/GNUmakefile.am 2013-09-05 21:25:32 UTC (rev 155150)
+++ trunk/Tools/TestWebKitAPI/GNUmakefile.am 2013-09-05 21:34:17 UTC (rev 155151)
@@ -73,8 +73,6 @@
Tools/TestWebKitAPI/Tests/WTF/StringOperators.cpp \
Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp \
Tools/TestWebKitAPI/Tests/WTF/Vector.cpp \
- Tools/TestWebKitAPI/Tests/WTF/VectorBasic.cpp \
- Tools/TestWebKitAPI/Tests/WTF/VectorReverse.cpp \
Tools/TestWebKitAPI/WTFStringUtilities.h
Programs_TestWebKitAPI_TestJavaScriptCore_CPPFLAGS = \
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj (155150 => 155151)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj 2013-09-05 21:25:32 UTC (rev 155150)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj 2013-09-05 21:34:17 UTC (rev 155151)
@@ -299,8 +299,6 @@
ClCompile Include=..\Tests\WTF\StringHasher.cpp /
ClCompile Include=..\Tests\WTF\StringOperators.cpp /
ClCompile Include=..\Tests\WTF\Vector.cpp /
-ClCompile Include=..\Tests\WTF\VectorBasic.cpp /
-ClCompile Include=..\Tests\WTF\VectorReverse.cpp /
ClCompile Include=..\win\HostWindow.cpp /
ClCompile Include=..\win\main.cpp /
/ItemGroup
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters (155150 => 155151)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters 2013-09-05 21:25:32 UTC (rev 155150)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters 2013-09-05 21:34:17 UTC (rev 155151)
@@ -78,12 +78,6 @@
ClCompile Include=..\Tests\WTF\Vector.cpp
FilterTests\WTF/Filter
/ClCompile
-ClCompile Include=..\Tests\WTF\VectorBasic.cpp
- FilterTests\WTF/Filter
-/ClCompile
-ClCompile Include=..\Tests\WTF\VectorReverse.cpp
- FilterTests\WTF/Filter
-/ClCompile
ClCompile Include=..\Tests\WTF\cf\RetainPtr.cpp
FilterTests\WTF\cf/Filter
/ClCompile
Modified:
[webkit-changes] [155135] trunk/Source
Title: [155135] trunk/Source Revision 155135 Author ander...@apple.com Date 2013-09-05 11:23:02 -0700 (Thu, 05 Sep 2013) Log Message Enable C++11 wherever we build C++ files that include wtf/Platform.h https://bugs.webkit.org/show_bug.cgi?id=120782 Reviewed by Andreas Kling. Source/ThirdParty: Set CLANG_CXX_LANGUAGE_STANDARD to gnu++0x. * gtest/xcode/Config/General.xcconfig: Source/WebCore: Pass -std=gnu++11 when preprocessing wtf/Platform.h. * DerivedSources.make: Modified Paths trunk/Source/ThirdParty/ChangeLog trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make Diff Modified: trunk/Source/ThirdParty/ChangeLog (155134 => 155135) --- trunk/Source/ThirdParty/ChangeLog 2013-09-05 18:01:00 UTC (rev 155134) +++ trunk/Source/ThirdParty/ChangeLog 2013-09-05 18:23:02 UTC (rev 155135) @@ -1,3 +1,14 @@ +2013-09-05 Anders Carlsson ander...@apple.com + +Enable C++11 wherever we build C++ files that include wtf/Platform.h +https://bugs.webkit.org/show_bug.cgi?id=120782 + +Reviewed by Andreas Kling. + +Set CLANG_CXX_LANGUAGE_STANDARD to gnu++0x. + +* gtest/xcode/Config/General.xcconfig: + 2013-08-20 Alex Christensen achristen...@apple.com Use PlatformArchitecture to distinguish between 32-bit and 64-bit builds on Windows. Modified: trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig (155134 => 155135) --- trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig 2013-09-05 18:01:00 UTC (rev 155134) +++ trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig 2013-09-05 18:23:02 UTC (rev 155135) @@ -29,6 +29,9 @@ // Force C99 dialect GCC_C_LANGUAGE_STANDARD = c99 +// Force C++11 +CLANG_CXX_LANGUAGE_STANDARD = gnu++0x; + // not sure why apple defaults this on, but it's pretty risky ALWAYS_SEARCH_USER_PATHS = NO Modified: trunk/Source/WebCore/ChangeLog (155134 => 155135) --- trunk/Source/WebCore/ChangeLog 2013-09-05 18:01:00 UTC (rev 155134) +++ trunk/Source/WebCore/ChangeLog 2013-09-05 18:23:02 UTC (rev 155135) @@ -1,3 +1,14 @@ +2013-09-05 Anders Carlsson ander...@apple.com + +Enable C++11 wherever we build C++ files that include wtf/Platform.h +https://bugs.webkit.org/show_bug.cgi?id=120782 + +Reviewed by Andreas Kling. + +Pass -std=gnu++11 when preprocessing wtf/Platform.h. + +* DerivedSources.make: + 2013-09-05 Joseph Pecoraro pecor...@apple.com Web Inspector: Breakpoint Actions Modified: trunk/Source/WebCore/DerivedSources.make (155134 => 155135) --- trunk/Source/WebCore/DerivedSources.make 2013-09-05 18:01:00 UTC (rev 155134) +++ trunk/Source/WebCore/DerivedSources.make 2013-09-05 18:23:02 UTC (rev 155135) @@ -713,7 +713,7 @@ SDK_FLAGS=-isysroot $(SDKROOT) endif -ifeq ($(shell $(CC) -x c++ -E -P -dM $(SDK_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include wtf/Platform.h /dev/null | grep ENABLE_ORIENTATION_EVENTS | cut -d' ' -f3), 1) +ifeq ($(shell $(CC) -std=gnu++11 -x c++ -E -P -dM $(SDK_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include wtf/Platform.h /dev/null | grep ENABLE_ORIENTATION_EVENTS | cut -d' ' -f3), 1) ENABLE_ORIENTATION_EVENTS = 1 endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155160] trunk/Tools
Title: [155160] trunk/Tools
Revision 155160
Author seo...@webkit.org
Date 2013-09-05 16:30:32 -0700 (Thu, 05 Sep 2013)
Log Message
Unreviewed build fix. VectorReverse.cpp was removed after r155151.
* TestWebKitAPI/CMakeLists.txt:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/CMakeLists.txt
Diff
Modified: trunk/Tools/ChangeLog (155159 => 155160)
--- trunk/Tools/ChangeLog 2013-09-05 23:27:41 UTC (rev 155159)
+++ trunk/Tools/ChangeLog 2013-09-05 23:30:32 UTC (rev 155160)
@@ -1,3 +1,9 @@
+2013-09-05 Seokju Kwon seo...@webkit.org
+
+Unreviewed build fix. VectorReverse.cpp was removed after r155151.
+
+* TestWebKitAPI/CMakeLists.txt:
+
2013-09-05 Anders Carlsson ander...@apple.com
Make Vector::uncheckedAppend work with move-only types
Modified: trunk/Tools/TestWebKitAPI/CMakeLists.txt (155159 => 155160)
--- trunk/Tools/TestWebKitAPI/CMakeLists.txt 2013-09-05 23:27:41 UTC (rev 155159)
+++ trunk/Tools/TestWebKitAPI/CMakeLists.txt 2013-09-05 23:30:32 UTC (rev 155160)
@@ -111,7 +111,6 @@
${TESTWEBKITAPI_DIR}/Tests/WTF/StringOperators.cpp
${TESTWEBKITAPI_DIR}/Tests/WTF/TemporaryChange.cpp
${TESTWEBKITAPI_DIR}/Tests/WTF/Vector.cpp
-${TESTWEBKITAPI_DIR}/Tests/WTF/VectorReverse.cpp
${TESTWEBKITAPI_DIR}/Tests/WTF/WTFString.cpp
)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155145] trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
Title: [155145] trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
Revision 155145
Author hy...@apple.com
Date 2013-09-05 13:54:49 -0700 (Thu, 05 Sep 2013)
Log Message
Fix build bustage.
Modified Paths
trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
Diff
Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp (155144 => 155145)
--- trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp 2013-09-05 20:17:48 UTC (rev 155144)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp 2013-09-05 20:54:49 UTC (rev 155145)
@@ -33,6 +33,7 @@
#include FontCache.h
#include FontSelector.h
#include MathMLNames.h
+#include RenderBlockFlow.h
#include RenderText.h
namespace WebCore {
@@ -307,7 +308,7 @@
addChild(container);
RenderBlock* parent = container;
if (charRelative) {
-RenderBlock* charBlock = new (renderArena()) RenderBlock(node());
+RenderBlockFlow* charBlock = new (renderArena()) RenderBlockFlow(node());
RefPtrRenderStyle charStyle = RenderStyle::create();
charStyle-inheritFrom(container-style());
charStyle-setDisplay(INLINE_BLOCK);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155137] trunk
Title: [155137] trunk
Revision 155137
Author d...@apple.com
Date 2013-09-05 11:58:07 -0700 (Thu, 05 Sep 2013)
Log Message
Rename supportsContext to probablySupportsContext
https://bugs.webkit.org/show_bug.cgi?id=120716
rdar://problem/14914499
Reviewed by Antoine Quint.
As decided in: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2013-September/040680.html
Source/WebCore:
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::probablySupportsContext):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::probablySupportsContext):
* html/HTMLCanvasElement.h:
* html/HTMLCanvasElement.idl:
LayoutTests:
* fast/canvas/webgl/canvas-supports-context-expected.txt:
* fast/canvas/webgl/canvas-supports-context.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt
trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp
trunk/Source/WebCore/html/HTMLCanvasElement.cpp
trunk/Source/WebCore/html/HTMLCanvasElement.h
trunk/Source/WebCore/html/HTMLCanvasElement.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (155136 => 155137)
--- trunk/LayoutTests/ChangeLog 2013-09-05 18:29:30 UTC (rev 155136)
+++ trunk/LayoutTests/ChangeLog 2013-09-05 18:58:07 UTC (rev 155137)
@@ -1,3 +1,16 @@
+2013-09-04 Dean Jackson d...@apple.com
+
+Rename supportsContext to probablySupportsContext
+https://bugs.webkit.org/show_bug.cgi?id=120716
+rdar://problem/14914499
+
+Reviewed by Antoine Quint.
+
+As decided in: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2013-September/040680.html
+
+* fast/canvas/webgl/canvas-supports-context-expected.txt:
+* fast/canvas/webgl/canvas-supports-context.html:
+
2013-09-05 Joseph Pecoraro pecor...@apple.com
Web Inspector: Breakpoint Actions
Modified: trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt (155136 => 155137)
--- trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt 2013-09-05 18:29:30 UTC (rev 155136)
+++ trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt 2013-09-05 18:58:07 UTC (rev 155137)
@@ -1,118 +1,118 @@
-This test ensures WebGL implementations interact correctly with the canvas tag's supportContext function, that getContext and supportsContext are implemented consistently with one another, and that malformed parameters to supportsContext are handled correctly.
+This test ensures WebGL implementations interact correctly with the canvas tag's probablySupportsContext function, that getContext and probablySupportsContext are implemented consistently with one another, and that malformed parameters to probablySupportsContext are handled correctly.
On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-Canvas.supportsContext('2d')
+Canvas.probablySupportsContext('2d')
-PASS supportsContext('2d') is consistent with getContext('2d')
-PASS supportsContext('2d') returns true
+PASS probablySupportsContext('2d') is consistent with getContext('2d')
+PASS probablySupportsContext('2d') returns true
PASS getContext('2d') returns true (context exists)
-Testing getContext and supportsContext('2d') after a context is created
-PASS supportsContext('2d') returns true
-PASS supportsContext('webkit-3d') returns false
+Testing getContext and probablySupportsContext('2d') after a context is created
+PASS probablySupportsContext('2d') returns true
+PASS probablySupportsContext('webkit-3d') returns false
PASS webkit-3d context does not exist
WebGL disabled
-Canvas.supportsContext('webkit-3d')
+Canvas.probablySupportsContext('webkit-3d')
-PASS supportsContext('webkit-3d') is consistent with getContext('webkit-3d')
-FAIL supportsContext('webkit-3d') returns false
+PASS probablySupportsContext('webkit-3d') is consistent with getContext('webkit-3d')
+FAIL probablySupportsContext('webkit-3d') returns false
FAIL getContext('webkit-3d') returns false (context does not exist)
-Canvas.supportsContext('experimental-webgl')
+Canvas.probablySupportsContext('experimental-webgl')
-PASS supportsContext('experimental-webgl') is consistent with getContext('experimental-webgl')
-FAIL supportsContext('experimental-webgl') returns false
+PASS probablySupportsContext('experimental-webgl') is consistent with getContext('experimental-webgl')
+FAIL probablySupportsContext('experimental-webgl') returns false
FAIL getContext('experimental-webgl') returns false (context does not exist)
-Canvas.supportsContext('moz-webgl')
+Canvas.probablySupportsContext('moz-webgl')
-PASS supportsContext('moz-webgl') is consistent with getContext('moz-webgl')
-FAIL supportsContext('moz-webgl') returns false
+PASS probablySupportsContext('moz-webgl') is consistent with getContext('moz-webgl')
+FAIL probablySupportsContext('moz-webgl') returns false
[webkit-changes] [155117] trunk/Tools
Title: [155117] trunk/Tools
Revision 155117
Author fpi...@apple.com
Date 2013-09-05 08:01:12 -0700 (Thu, 05 Sep 2013)
Log Message
Unreviewed, green the Mac bots by boosting the timeout on JSC tests. One of the
Mozilla tests appears to run for a longer time.
I think we want to continue to allow a few tests here and there to be
longer-running, rather than excluding them. I seem to recall that those tests
catch good bugs.
* Scripts/run-_javascript_core-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
Diff
Modified: trunk/Tools/ChangeLog (155116 => 155117)
--- trunk/Tools/ChangeLog 2013-09-05 14:45:58 UTC (rev 155116)
+++ trunk/Tools/ChangeLog 2013-09-05 15:01:12 UTC (rev 155117)
@@ -1,5 +1,16 @@
2013-09-05 Filip Pizlo fpi...@apple.com
+Unreviewed, green the Mac bots by boosting the timeout on JSC tests. One of the
+Mozilla tests appears to run for a longer time.
+
+I think we want to continue to allow a few tests here and there to be
+longer-running, rather than excluding them. I seem to recall that those tests
+catch good bugs.
+
+* Scripts/run-_javascript_core-tests:
+
+2013-09-05 Filip Pizlo fpi...@apple.com
+
Unreviewed, don't run fast/js tests in run-_javascript_core-tests on platforms that
can't support it because if non-bourne shells. This fixes part #2 of the Linux
bot breakage.
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (155116 => 155117)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 14:45:58 UTC (rev 155116)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 15:01:12 UTC (rev 155117)
@@ -114,7 +114,7 @@
my $productDir = jscProductDir();
$ENV{DYLD_FRAMEWORK_PATH} = $productDir;
-$ENV{JSC_timeout} = 20; # Set a 20 second timeout on all jsc tests.
+$ENV{JSC_timeout} = 60; # Set a 60 second timeout on all jsc tests.
setPathForRunningWebKitApp(\%ENV) if isCygwin();
sub testapiPath($)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155146] trunk/Source/WTF
Title: [155146] trunk/Source/WTF Revision 155146 Author ander...@apple.com Date 2013-09-05 14:01:30 -0700 (Thu, 05 Sep 2013) Log Message Clean up wtf/Compiler.h https://bugs.webkit.org/show_bug.cgi?id=120790 Reviewed by Andreas Kling. - Get rid of the CLANG_PRAGMA define, it's not used anywhere. - Remove a workaround for a bug in the version of clang that came with Xcode 4.2. - Replace WTF_COMPILER_SUPPORTS_CXX_FINAL_CONTROL with a compiler quirk for versions of clang that have a buggy final implementation and fix a bug in the macro where final would be disabled for versions of clang where __clang_minor__ is less than 2, regardless of the major version. - Fail if someone tries to compile the WebKit stack with a compiler that doesn't support rvalue references or static_assert. * wtf/Compiler.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Compiler.h Diff Modified: trunk/Source/WTF/ChangeLog (155145 => 155146) --- trunk/Source/WTF/ChangeLog 2013-09-05 20:54:49 UTC (rev 155145) +++ trunk/Source/WTF/ChangeLog 2013-09-05 21:01:30 UTC (rev 155146) @@ -1,5 +1,22 @@ 2013-09-05 Anders Carlsson ander...@apple.com +Clean up wtf/Compiler.h +https://bugs.webkit.org/show_bug.cgi?id=120790 + +Reviewed by Andreas Kling. + +- Get rid of the CLANG_PRAGMA define, it's not used anywhere. +- Remove a workaround for a bug in the version of clang that came with Xcode 4.2. +- Replace WTF_COMPILER_SUPPORTS_CXX_FINAL_CONTROL with a compiler quirk for versions of clang + that have a buggy final implementation and fix a bug in the macro where final would be disabled + for versions of clang where __clang_minor__ is less than 2, regardless of the major version. +- Fail if someone tries to compile the WebKit stack with a compiler that doesn't support rvalue + references or static_assert. + +* wtf/Compiler.h: + +2013-09-05 Anders Carlsson ander...@apple.com + Change StringBuffer back to not use an OwnPtr in an attempt to fix ports. * wtf/text/StringBuffer.h: Modified: trunk/Source/WTF/wtf/Compiler.h (155145 => 155146) --- trunk/Source/WTF/wtf/Compiler.h 2013-09-05 20:54:49 UTC (rev 155145) +++ trunk/Source/WTF/wtf/Compiler.h 2013-09-05 21:01:30 UTC (rev 155146) @@ -41,16 +41,9 @@ #if defined(__clang__) #define WTF_COMPILER_CLANG 1 -#define CLANG_PRAGMA(PRAGMA) _Pragma(PRAGMA) - /* Specific compiler features */ #define WTF_COMPILER_SUPPORTS_CXX_VARIADIC_TEMPLATES __has_feature(cxx_variadic_templates) - -/* There is a bug in clang that comes with Xcode 4.2 where AtomicStrings can't be implicitly converted to Strings - in the presence of move constructors and/or move assignment operators. This bug has been fixed in Xcode 4.3 clang, so we - check for both cxx_rvalue_references as well as the unrelated cxx_nonstatic_member_init feature which we know was added in 4.3 */ -#define WTF_COMPILER_SUPPORTS_CXX_RVALUE_REFERENCES __has_feature(cxx_rvalue_references) __has_feature(cxx_nonstatic_member_init) - +#define WTF_COMPILER_SUPPORTS_CXX_RVALUE_REFERENCES __has_feature(cxx_rvalue_references) #define WTF_COMPILER_SUPPORTS_CXX_DELETED_FUNCTIONS __has_feature(cxx_deleted_functions) #define WTF_COMPILER_SUPPORTS_CXX_NULLPTR __has_feature(cxx_nullptr) #define WTF_COMPILER_SUPPORTS_CXX_EXPLICIT_CONVERSIONS __has_feature(cxx_explicit_conversions) @@ -58,23 +51,14 @@ #define WTF_COMPILER_SUPPORTS_C_STATIC_ASSERT __has_feature(c_static_assert) #define WTF_COMPILER_SUPPORTS_CXX_STATIC_ASSERT __has_feature(cxx_static_assert) #define WTF_COMPILER_SUPPORTS_CXX_OVERRIDE_CONTROL __has_feature(cxx_override_control) - -#ifdef __APPLE__ -/* Enable final only on clang 4.2 and later to avoid bugs like http://webkit.org/b/119165 */ -#define APPLE_CLANG_VERSION_AT_LEAST(major, minor) (defined(__clang_major__) __clang_major__ = major __clang_minor__ = minor) -#define WTF_COMPILER_SUPPORTS_CXX_FINAL_CONTROL WTF_COMPILER_SUPPORTS_CXX_OVERRIDE_CONTROL APPLE_CLANG_VERSION_AT_LEAST(4, 2) -#else -/* We don't know which versions of clang has the bug mentioned above since __clang_major__ and __clang_minor__ are vendor dependent */ -#define WTF_COMPILER_SUPPORTS_CXX_FINAL_CONTROL WTF_COMPILER_SUPPORTS_CXX_OVERRIDE_CONTROL -#endif - -#define WTF_COMPILER_SUPPORTS_HAS_TRIVIAL_DESTRUCTOR __has_feature(has_trivial_destructor) #define WTF_COMPILER_SUPPORTS_CXX_STRONG_ENUMS __has_feature(cxx_strong_enums) #define WTF_COMPILER_SUPPORTS_CXX_REFERENCE_QUALIFIED_FUNCTIONS __has_feature(cxx_reference_qualified_functions) + +/* Disable final on versions of Apple clang earlier than 4.2 to avoid bugs like http://webkit.org/b/119165 */ +#if defined(__APPLE__) (__clang_major__ 4 || (__clang_major__ == 4 __clang_minor__ 2)) +#define WTF_COMPILER_QUIRK_FINAL_IS_BUGGY #endif -#ifndef CLANG_PRAGMA -#define CLANG_PRAGMA(PRAGMA) #endif /* COMPILER(MSVC) - Microsoft Visual C++ */ @@ -92,7 +76,6
[webkit-changes] [155147] trunk/Source/WebCore
Title: [155147] trunk/Source/WebCore
Revision 155147
Author ddkil...@apple.com
Date 2013-09-05 14:07:41 -0700 (Thu, 05 Sep 2013)
Log Message
BUILD FIX (r155108): Add SynchronousLoaderClientCFNet.cpp to Xcode project
* WebCore.xcodeproj/project.pbxproj: The iOS port defines
USE(CFNETWORK), so it needs to compile
SynchronousLoaderClientCFNet.cpp to build successfully.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (155146 => 155147)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 21:01:30 UTC (rev 155146)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 21:07:41 UTC (rev 155147)
@@ -1,3 +1,11 @@
+2013-09-05 David Kilzer ddkil...@apple.com
+
+BUILD FIX (r155108): Add SynchronousLoaderClientCFNet.cpp to Xcode project
+
+* WebCore.xcodeproj/project.pbxproj: The iOS port defines
+USE(CFNETWORK), so it needs to compile
+SynchronousLoaderClientCFNet.cpp to build successfully.
+
2013-09-05 Anders Carlsson ander...@apple.com
GCAssertions.h should use STL type traits and static_assert
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (155146 => 155147)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2013-09-05 21:01:30 UTC (rev 155146)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2013-09-05 21:07:41 UTC (rev 155147)
@@ -1314,6 +1314,7 @@
441B055C0CD77A2D007C1F18 /* DOMHTMLEmbedElementPrivate.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 4429AAFB0CB84E88007647C5 /* DOMHTMLEmbedElementPrivate.h */; };
441B055E0CD77A48007C1F18 /* DOMHTMLIFrameElementPrivate.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 4429AAFD0CB84EA5007647C5 /* DOMHTMLIFrameElementPrivate.h */; };
441B05600CD77A65007C1F18 /* DOMHTMLObjectElementPrivate.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 4429AAFF0CB84EC3007647C5 /* DOMHTMLObjectElementPrivate.h */; };
+ 442ABCD617D9262F00D30715 /* SynchronousLoaderClientCFNet.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 442ABCD517D9262F00D30715 /* SynchronousLoaderClientCFNet.cpp */; };
44311CD612E4E22D000A8D19 /* DOMDocumentFragmentPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 44311CD412E4E22D000A8D19 /* DOMDocumentFragmentPrivate.h */; };
44311CD712E4E22D000A8D19 /* DOMDocumentPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 44311CD512E4E22D000A8D19 /* DOMDocumentPrivate.h */; };
44311CD812E4E24B000A8D19 /* DOMDocumentPrivate.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 44311CD512E4E22D000A8D19 /* DOMDocumentPrivate.h */; };
@@ -7814,6 +7815,7 @@
4429AAFD0CB84EA5007647C5 /* DOMHTMLIFrameElementPrivate.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = DOMHTMLIFrameElementPrivate.h; sourceTree = group; };
4429AAFF0CB84EC3007647C5 /* DOMHTMLObjectElementPrivate.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = DOMHTMLObjectElementPrivate.h; sourceTree = group; };
4429AB070CB84F81007647C5 /* DOMTextEventInternal.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = DOMTextEventInternal.h; sourceTree = group; };
+ 442ABCD517D9262F00D30715 /* SynchronousLoaderClientCFNet.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SynchronousLoaderClientCFNet.cpp; sourceTree = group; };
44311CD412E4E22D000A8D19 /* DOMDocumentFragmentPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMDocumentFragmentPrivate.h; sourceTree = group; };
44311CD512E4E22D000A8D19 /* DOMDocumentPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMDocumentPrivate.h; sourceTree = group; };
447958021643B47B001E0A7F /* ParsedContentType.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ParsedContentType.cpp; sourceTree = group; };
@@ -19031,6 +19033,7 @@
51ABAE1A103C18FF008C5260 /* SocketStreamError.h */,
51ABAE1C103C1913008C5260 /* SocketStreamHandle.h */,
51ABAE1D103C1913008C5260 /* SocketStreamHandleCFNet.cpp */,
+442ABCD517D9262F00D30715 /* SynchronousLoaderClientCFNet.cpp */,
);
path = cf;
sourceTree = group;
@@ -27310,6 +27313,7 @@
B2E4EC970D00C22B00432643 /* SVGZoomEvent.cpp in Sources */,
E180811216FCF42F00B80D07 /* SynchronousLoaderClient.cpp in Sources */,
E180811616FCF9CB00B80D07 /* SynchronousLoaderClient.mm in Sources */,
+442ABCD617D9262F00D30715 /* SynchronousLoaderClientCFNet.cpp in Sources */,
5DA97ECE168E787B000E3676 /* SystemVersionMac.mm in Sources */,
BCE3BEC20D222B1D007E06E4 /* TagNodeList.cpp in Sources */,
F55B3DD51251F12D003EF269 /* TelephoneInputType.cpp in Sources */,
[webkit-changes] [155164] trunk/Source
Title: [155164] trunk/Source
Revision 155164
Author akl...@apple.com
Date 2013-09-05 17:35:00 -0700 (Thu, 05 Sep 2013)
Log Message
ScrollView::children() should return a reference.
https://webkit.org/b/120795
Reviewed by Anders Carlsson.
Source/WebCore:
This function was already just returning the address of a member variable.
Modernized some loops that were using it.
* bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::setJavaScriptPaused):
* page/FrameView.cpp:
(WebCore::FrameView::hasCustomScrollbars):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
* page/Page.cpp:
(WebCore::Page::pluginViews):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
* platform/ScrollView.h:
(WebCore::ScrollView::children):
* plugins/IFrameShimSupport.cpp:
(WebCore::getPluginOcclusions):
Source/WebKit/mac:
* WebView/WebView.mm:
(-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/PageScriptDebugServer.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/plugins/IFrameShimSupport.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (155163 => 155164)
--- trunk/Source/WebCore/ChangeLog 2013-09-06 00:23:22 UTC (rev 155163)
+++ trunk/Source/WebCore/ChangeLog 2013-09-06 00:35:00 UTC (rev 155164)
@@ -1,3 +1,27 @@
+2013-09-05 Andreas Kling akl...@apple.com
+
+ScrollView::children() should return a reference.
+https://webkit.org/b/120795
+
+Reviewed by Anders Carlsson.
+
+This function was already just returning the address of a member variable.
+Modernized some loops that were using it.
+
+* bindings/js/PageScriptDebugServer.cpp:
+(WebCore::PageScriptDebugServer::setJavaScriptPaused):
+* page/FrameView.cpp:
+(WebCore::FrameView::hasCustomScrollbars):
+(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
+* page/Page.cpp:
+(WebCore::Page::pluginViews):
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
+* platform/ScrollView.h:
+(WebCore::ScrollView::children):
+* plugins/IFrameShimSupport.cpp:
+(WebCore::getPluginOcclusions):
+
2013-09-05 Beth Dakin bda...@apple.com
Reverting revisions 155139, 155141, 155142, and 155145 since they appear to have
Modified: trunk/Source/WebCore/bindings/js/PageScriptDebugServer.cpp (155163 => 155164)
--- trunk/Source/WebCore/bindings/js/PageScriptDebugServer.cpp 2013-09-06 00:23:22 UTC (rev 155163)
+++ trunk/Source/WebCore/bindings/js/PageScriptDebugServer.cpp 2013-09-06 00:35:00 UTC (rev 155164)
@@ -219,11 +219,7 @@
if (!view)
return;
-const HashSetRefPtrWidget * children = view-children();
-ASSERT(children);
-
-HashSetRefPtrWidget ::const_iterator end = children-end();
-for (HashSetRefPtrWidget ::const_iterator it = children-begin(); it != end; ++it) {
+for (auto it = view-children().begin(), end = view-children().end(); it != end; ++it) {
Widget* widget = (*it).get();
if (!widget-isPluginView())
continue;
Modified: trunk/Source/WebCore/page/FrameView.cpp (155163 => 155164)
--- trunk/Source/WebCore/page/FrameView.cpp 2013-09-06 00:23:22 UTC (rev 155163)
+++ trunk/Source/WebCore/page/FrameView.cpp 2013-09-06 00:35:00 UTC (rev 155164)
@@ -1065,19 +1065,6 @@
return onlyDuringLayout layoutPending() ? 0 : m_layoutRoot;
}
-static inline void collectFrameViewChildren(FrameView* frameView, VectorRefPtrFrameView frameViews)
-{
-const HashSetRefPtrWidget * viewChildren = frameView-children();
-ASSERT(viewChildren);
-
-const HashSetRefPtrWidget ::iterator end = viewChildren-end();
-for (HashSetRefPtrWidget ::iterator current = viewChildren-begin(); current != end; ++current) {
-Widget* widget = (*current).get();
-if (widget-isFrameView())
-frameViews.append(toFrameView(widget));
-}
-}
-
inline void FrameView::forceLayoutParentViewIfNeeded()
{
#if ENABLE(SVG)
@@ -3378,10 +3365,8 @@
bool FrameView::hasCustomScrollbars() const
{
-const HashSetRefPtrWidget * viewChildren = children();
-HashSetRefPtrWidget ::const_iterator end = viewChildren-end();
-for (HashSetRefPtrWidget ::const_iterator current = viewChildren-begin(); current != end; ++current) {
-Widget* widget = current-get();
+for (auto it = children().begin(), end = children().end(); it != end; ++it) {
+Widget* widget = it-get();
if (widget-isFrameView()) {
if (toFrameView(widget)-hasCustomScrollbars())
[webkit-changes] [155141] trunk/Source/WebCore
Title: [155141] trunk/Source/WebCore
Revision 155141
Author hy...@apple.com
Date 2013-09-05 12:47:40 -0700 (Thu, 05 Sep 2013)
Log Message
Make RenderBlock have a protected constructor..
https://bugs.webkit.org/show_bug.cgi?id=120787
Reviewed by Beth Dakin.
Make sure nobody can create a RenderBlock directly. Make sure RenderBlockFlows
get made when a display:block/inline-block/compact/run-in is seen.
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createRenderer):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createRenderer):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::createAnonymous):
* rendering/RenderBlock.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLDetailsElement.cpp
trunk/Source/WebCore/html/HTMLSummaryElement.cpp
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderObject.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155140 => 155141)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 19:38:48 UTC (rev 155140)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 19:47:40 UTC (rev 155141)
@@ -1,5 +1,25 @@
2013-09-05 David Hyatt hy...@apple.com
+Make RenderBlock have a protected constructor..
+https://bugs.webkit.org/show_bug.cgi?id=120787
+
+Reviewed by Beth Dakin.
+
+Make sure nobody can create a RenderBlock directly. Make sure RenderBlockFlows
+get made when a display:block/inline-block/compact/run-in is seen.
+
+* html/HTMLDetailsElement.cpp:
+(WebCore::HTMLDetailsElement::createRenderer):
+* html/HTMLSummaryElement.cpp:
+(WebCore::HTMLSummaryElement::createRenderer):
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::createAnonymous):
+* rendering/RenderBlock.h:
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::createObject):
+
+2013-09-05 David Hyatt hy...@apple.com
+
Add new RenderBlockFlow class
https://bugs.webkit.org/show_bug.cgi?id=120777
Modified: trunk/Source/WebCore/html/HTMLDetailsElement.cpp (155140 => 155141)
--- trunk/Source/WebCore/html/HTMLDetailsElement.cpp 2013-09-05 19:38:48 UTC (rev 155140)
+++ trunk/Source/WebCore/html/HTMLDetailsElement.cpp 2013-09-05 19:47:40 UTC (rev 155141)
@@ -27,7 +27,7 @@
#include HTMLSummaryElement.h
#include LocalizedStrings.h
#include MouseEvent.h
-#include RenderBlock.h
+#include RenderBlockFlow.h
#include ShadowRoot.h
#include Text.h
@@ -113,7 +113,7 @@
RenderObject* HTMLDetailsElement::createRenderer(RenderArena* arena, RenderStyle*)
{
-return new (arena) RenderBlock(this);
+return new (arena) RenderBlockFlow(this);
}
void HTMLDetailsElement::didAddUserAgentShadowRoot(ShadowRoot* root)
Modified: trunk/Source/WebCore/html/HTMLSummaryElement.cpp (155140 => 155141)
--- trunk/Source/WebCore/html/HTMLSummaryElement.cpp 2013-09-05 19:38:48 UTC (rev 155140)
+++ trunk/Source/WebCore/html/HTMLSummaryElement.cpp 2013-09-05 19:47:40 UTC (rev 155141)
@@ -30,7 +30,7 @@
#include MouseEvent.h
#include NodeRenderingTraversal.h
#include PlatformMouseEvent.h
-#include RenderBlock.h
+#include RenderBlockFlow.h
#include ShadowRoot.h
namespace WebCore {
@@ -68,7 +68,7 @@
RenderObject* HTMLSummaryElement::createRenderer(RenderArena* arena, RenderStyle*)
{
-return new (arena) RenderBlock(this);
+return new (arena) RenderBlockFlow(this);
}
bool HTMLSummaryElement::childShouldCreateRenderer(const Node* child) const
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (155140 => 155141)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2013-09-05 19:38:48 UTC (rev 155140)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2013-09-05 19:47:40 UTC (rev 155141)
@@ -237,7 +237,7 @@
RenderBlock* RenderBlock::createAnonymous(Document* document)
{
-RenderBlock* renderer = new (document-renderArena()) RenderBlock(0);
+RenderBlock* renderer = new (document-renderArena()) RenderBlockFlow(0);
renderer-setDocumentForAnonymous(document);
return renderer;
}
Modified: trunk/Source/WebCore/rendering/RenderBlock.h (155140 => 155141)
--- trunk/Source/WebCore/rendering/RenderBlock.h 2013-09-05 19:38:48 UTC (rev 155140)
+++ trunk/Source/WebCore/rendering/RenderBlock.h 2013-09-05 19:47:40 UTC (rev 155141)
@@ -89,9 +89,11 @@
template class friend struct ValueToString;
#endif
+protected:
explicit RenderBlock(ContainerNode*);
virtual ~RenderBlock();
+public:
static RenderBlock* createAnonymous(Document*);
RenderObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()-firstChild(); }
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (155140 => 155141)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2013-09-05 19:38:48 UTC (rev 155140)
+++
[webkit-changes] [155152] trunk
Title: [155152] trunk
Revision 155152
Author ander...@apple.com
Date 2013-09-05 14:52:25 -0700 (Thu, 05 Sep 2013)
Log Message
Make Vector::uncheckedAppend work with move-only types
https://bugs.webkit.org/show_bug.cgi?id=120799
Reviewed by Andreas Kling.
Source/WTF:
* wtf/Vector.h:
(WTFuncheckedAppend):
Use std::forward to invoke the move constructor when possible.
Tools:
* TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::MoveOnly):
Add a move-only class.
(TestWebKitAPI::TEST):
Add a test for VectorMoveOnly::uncheckedAppend.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Vector.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (155151 => 155152)
--- trunk/Source/WTF/ChangeLog 2013-09-05 21:34:17 UTC (rev 155151)
+++ trunk/Source/WTF/ChangeLog 2013-09-05 21:52:25 UTC (rev 155152)
@@ -1,5 +1,16 @@
2013-09-05 Anders Carlsson ander...@apple.com
+Make Vector::uncheckedAppend work with move-only types
+https://bugs.webkit.org/show_bug.cgi?id=120799
+
+Reviewed by Andreas Kling.
+
+* wtf/Vector.h:
+(WTFuncheckedAppend):
+Use std::forward to invoke the move constructor when possible.
+
+2013-09-05 Anders Carlsson ander...@apple.com
+
Add COMPILER_SUPPORTS(CXX_AUTO_TYPE) and #error if it's 0
https://bugs.webkit.org/show_bug.cgi?id=120794
Modified: trunk/Source/WTF/wtf/Vector.h (155151 => 155152)
--- trunk/Source/WTF/wtf/Vector.h 2013-09-05 21:34:17 UTC (rev 155151)
+++ trunk/Source/WTF/wtf/Vector.h 2013-09-05 21:52:25 UTC (rev 155152)
@@ -643,7 +643,7 @@
templatetypename U void append(const U*, size_t);
templatetypename U void append(const U);
-templatetypename U void uncheckedAppend(const U val);
+templatetypename U void uncheckedAppend(U val);
templatetypename U, size_t otherCapacity void appendVector(const VectorU, otherCapacity);
templatetypename U bool tryAppend(const U*, size_t);
@@ -1068,11 +1068,11 @@
// vector's capacity is large enough for the append to succeed.
templatetypename T, size_t inlineCapacity, typename OverflowHandler templatetypename U
-inline void VectorT, inlineCapacity, OverflowHandler::uncheckedAppend(const U val)
+inline void VectorT, inlineCapacity, OverflowHandler::uncheckedAppend(U val)
{
ASSERT(size() capacity());
-const U* ptr = val;
-new (NotNull, end()) T(*ptr);
+typename std::remove_referenceU::type* ptr = val;
+new (NotNull, end()) T(std::forwardU(*ptr));
++m_size;
}
Modified: trunk/Tools/ChangeLog (155151 => 155152)
--- trunk/Tools/ChangeLog 2013-09-05 21:34:17 UTC (rev 155151)
+++ trunk/Tools/ChangeLog 2013-09-05 21:52:25 UTC (rev 155152)
@@ -1,5 +1,19 @@
2013-09-05 Anders Carlsson ander...@apple.com
+Make Vector::uncheckedAppend work with move-only types
+https://bugs.webkit.org/show_bug.cgi?id=120799
+
+Reviewed by Andreas Kling.
+
+* TestWebKitAPI/Tests/WTF/Vector.cpp:
+(TestWebKitAPI::MoveOnly):
+Add a move-only class.
+
+(TestWebKitAPI::TEST):
+Add a test for VectorMoveOnly::uncheckedAppend.
+
+2013-09-05 Anders Carlsson ander...@apple.com
+
Move all Vector tests into Vector.cpp
https://bugs.webkit.org/show_bug.cgi?id=120797
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp (155151 => 155152)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp 2013-09-05 21:34:17 UTC (rev 155151)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp 2013-09-05 21:52:25 UTC (rev 155152)
@@ -108,4 +108,51 @@
EXPECT_TRUE(end == it);
}
+class MoveOnly {
+public:
+MoveOnly(unsigned value)
+: m_value(value)
+{
+}
+
+unsigned value() const
+{
+return m_value;
+}
+
+MoveOnly(MoveOnly other)
+: m_value(other.m_value)
+{
+other.m_value = 0;
+}
+
+MoveOnly operator=(MoveOnly other)
+{
+if (this == other)
+return *this;
+
+m_value = other.m_value;
+other.m_value = 0;
+return *this;
+}
+
+private:
+unsigned m_value;
+};
+
+TEST(WTF_Vector, MoveOnly_UncheckedAppend)
+{
+VectorMoveOnly vector;
+
+vector.reserveInitialCapacity(100);
+for (size_t i = 0; i 100; ++i) {
+MoveOnly moveOnly(i);
+vector.uncheckedAppend(std::move(moveOnly));
+EXPECT_EQ(moveOnly.value(), 0U);
+}
+
+for (size_t i = 0; i 100; ++i)
+EXPECT_EQ(vector[i].value(), i);
+}
+
} // namespace TestWebKitAPI
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155165] trunk/Source/WebInspectorUI
Title: [155165] trunk/Source/WebInspectorUI
Revision 155165
Author commit-qu...@webkit.org
Date 2013-09-05 17:55:42 -0700 (Thu, 05 Sep 2013)
Log Message
Web Inspector: Edit Breakpoint popover sometimes appears misplaced in top left
https://bugs.webkit.org/show_bug.cgi?id=120804
Patch by Joseph Pecoraro pecor...@apple.com on 2013-09-05
Reviewed by Timothy Hatcher.
Grab the bounding rect immediately, instead of grabbing it from the element
after the user has selected the Edit Breakpoint context menu item. When
the popover was misplaced it was when using an element had been removed or
replaced in the DOM, and caused a bogus bounding client rect.
* UserInterface/Breakpoint.js:
(WebInspector.Breakpoint.prototype.editBreakpoint):
(WebInspector.Breakpoint.prototype._showEditBreakpointPopover):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (155164 => 155165)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-09-06 00:35:00 UTC (rev 155164)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-09-06 00:55:42 UTC (rev 155165)
@@ -1,5 +1,21 @@
2013-09-05 Joseph Pecoraro pecor...@apple.com
+Web Inspector: Edit Breakpoint popover sometimes appears misplaced in top left
+https://bugs.webkit.org/show_bug.cgi?id=120804
+
+Reviewed by Timothy Hatcher.
+
+Grab the bounding rect immediately, instead of grabbing it from the element
+after the user has selected the Edit Breakpoint context menu item. When
+the popover was misplaced it was when using an element had been removed or
+replaced in the DOM, and caused a bogus bounding client rect.
+
+* UserInterface/Breakpoint.js:
+(WebInspector.Breakpoint.prototype.editBreakpoint):
+(WebInspector.Breakpoint.prototype._showEditBreakpointPopover):
+
+2013-09-05 Joseph Pecoraro pecor...@apple.com
+
Web Inspector: Remove harmless assert, triggered hitting breakpoint in auto prettyprinted code on reload
https://bugs.webkit.org/show_bug.cgi?id=120332
Modified: trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js (155164 => 155165)
--- trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js 2013-09-06 00:35:00 UTC (rev 155164)
+++ trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js 2013-09-06 00:55:42 UTC (rev 155165)
@@ -199,9 +199,13 @@
appendContextMenuItems: function(contextMenu, breakpointDisplayElement)
{
+console.assert(document.body.contains(breakpointDisplayElement), breakpoint popover display element must be in the DOM);
+
+var boundingClientRect = breakpointDisplayElement.getBoundingClientRect();
+
function editBreakpoint()
{
-this._showEditBreakpointPopover(breakpointDisplayElement);
+this._showEditBreakpointPopover(boundingClientRect);
}
function removeBreakpoint()
@@ -474,10 +478,11 @@
delete this._popover;
},
-_showEditBreakpointPopover: function(element)
+_showEditBreakpointPopover: function(boundingClientRect)
{
const padding = 2;
-var bounds = WebInspector.Rect.rectFromClientRect(element.getBoundingClientRect());
+var bounds = WebInspector.Rect.rectFromClientRect(boundingClientRect);
+
bounds.origin.x -= 1; // Move the anchor left one pixel so it looks more centered.
bounds.origin.x -= padding;
bounds.origin.y -= padding;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155142] trunk/Source/WebCore
Title: [155142] trunk/Source/WebCore
Revision 155142
Author hy...@apple.com
Date 2013-09-05 12:57:08 -0700 (Thu, 05 Sep 2013)
Log Message
Make RenderListItem inherit from RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=120789
Reviewed by Beth Dakin.
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::RenderListItem):
(WebCore::RenderListItem::willBeDestroyed):
(WebCore::RenderListItem::willBeRemovedFromTree):
(WebCore::RenderListItem::layout):
(WebCore::RenderListItem::addOverflowFromChildren):
(WebCore::RenderListItem::computePreferredLogicalWidths):
(WebCore::RenderListItem::paint):
* rendering/RenderListItem.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListItem.cpp
trunk/Source/WebCore/rendering/RenderListItem.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (155141 => 155142)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 19:47:40 UTC (rev 155141)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 19:57:08 UTC (rev 155142)
@@ -1,5 +1,22 @@
2013-09-05 David Hyatt hy...@apple.com
+Make RenderListItem inherit from RenderBlockFlow.
+https://bugs.webkit.org/show_bug.cgi?id=120789
+
+Reviewed by Beth Dakin.
+
+* rendering/RenderListItem.cpp:
+(WebCore::RenderListItem::RenderListItem):
+(WebCore::RenderListItem::willBeDestroyed):
+(WebCore::RenderListItem::willBeRemovedFromTree):
+(WebCore::RenderListItem::layout):
+(WebCore::RenderListItem::addOverflowFromChildren):
+(WebCore::RenderListItem::computePreferredLogicalWidths):
+(WebCore::RenderListItem::paint):
+* rendering/RenderListItem.h:
+
+2013-09-05 David Hyatt hy...@apple.com
+
Make RenderBlock have a protected constructor..
https://bugs.webkit.org/show_bug.cgi?id=120787
Modified: trunk/Source/WebCore/rendering/RenderListItem.cpp (155141 => 155142)
--- trunk/Source/WebCore/rendering/RenderListItem.cpp 2013-09-05 19:47:40 UTC (rev 155141)
+++ trunk/Source/WebCore/rendering/RenderListItem.cpp 2013-09-05 19:57:08 UTC (rev 155142)
@@ -42,7 +42,7 @@
using namespace HTMLNames;
RenderListItem::RenderListItem(Element* element)
-: RenderBlock(element)
+: RenderBlockFlow(element)
, m_marker(0)
, m_hasExplicitValue(false)
, m_isValueUpToDate(false)
@@ -76,7 +76,7 @@
m_marker-destroy();
m_marker = 0;
}
-RenderBlock::willBeDestroyed();
+RenderBlockFlow::willBeDestroyed();
}
void RenderListItem::insertedIntoTree()
@@ -88,7 +88,7 @@
void RenderListItem::willBeRemovedFromTree()
{
-RenderBlock::willBeRemovedFromTree();
+RenderBlockFlow::willBeRemovedFromTree();
updateListMarkerNumbers();
}
@@ -306,12 +306,12 @@
ASSERT(needsLayout());
insertOrMoveMarkerRendererIfNeeded();
-RenderBlock::layout();
+RenderBlockFlow::layout();
}
void RenderListItem::addOverflowFromChildren()
{
-RenderBlock::addOverflowFromChildren();
+RenderBlockFlow::addOverflowFromChildren();
positionListMarker();
}
@@ -325,7 +325,7 @@
SetLayoutNeededForbiddenScope layoutForbiddenScope(this, false);
#endif
insertOrMoveMarkerRendererIfNeeded();
-RenderBlock::computePreferredLogicalWidths();
+RenderBlockFlow::computePreferredLogicalWidths();
}
void RenderListItem::positionListMarker()
@@ -428,7 +428,7 @@
if (!logicalHeight() hasOverflowClip())
return;
-RenderBlock::paint(paintInfo, paintOffset);
+RenderBlockFlow::paint(paintInfo, paintOffset);
}
const String RenderListItem::markerText() const
Modified: trunk/Source/WebCore/rendering/RenderListItem.h (155141 => 155142)
--- trunk/Source/WebCore/rendering/RenderListItem.h 2013-09-05 19:47:40 UTC (rev 155141)
+++ trunk/Source/WebCore/rendering/RenderListItem.h 2013-09-05 19:57:08 UTC (rev 155142)
@@ -23,14 +23,14 @@
#ifndef RenderListItem_h
#define RenderListItem_h
-#include RenderBlock.h
+#include RenderBlockFlow.h
namespace WebCore {
class HTMLOListElement;
class RenderListMarker;
-class RenderListItem FINAL : public RenderBlock {
+class RenderListItem FINAL : public RenderBlockFlow {
public:
explicit RenderListItem(Element*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155153] trunk/Source/WebKit2
Title: [155153] trunk/Source/WebKit2
Revision 155153
Author a...@apple.com
Date 2013-09-05 15:06:31 -0700 (Thu, 05 Sep 2013)
Log Message
WKFullScreenWindowController extends lifetime of WKView, deleting it at a wrong time
https://bugs.webkit.org/show_bug.cgi?id=120792
rdar://problem/14884666
Reviewed by Jer Noble.
* UIProcess/API/mac/WKView.mm: (-[WKView fullScreenWindowController]):
Use a newly minted initializer for the controller.
* UIProcess/mac/WKFullScreenWindowController.h: Removed unused web view accessors.
Changed the class to take web view at initialization time.
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:webView:]): Initialize the controller
inone step.
(-[WKFullScreenWindowController dealloc]): WebView is now a raw pointer, no need
to zero it.
(-[WKFullScreenWindowController close]): Make sure to not leave a dangling WKView
pointer (this method is indirectly but inevitably called when WKView is deallocated).
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.h
trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (155152 => 155153)
--- trunk/Source/WebKit2/ChangeLog 2013-09-05 21:52:25 UTC (rev 155152)
+++ trunk/Source/WebKit2/ChangeLog 2013-09-05 22:06:31 UTC (rev 155153)
@@ -1,3 +1,25 @@
+2013-09-05 Alexey Proskuryakov a...@apple.com
+
+WKFullScreenWindowController extends lifetime of WKView, deleting it at a wrong time
+https://bugs.webkit.org/show_bug.cgi?id=120792
+rdar://problem/14884666
+
+Reviewed by Jer Noble.
+
+* UIProcess/API/mac/WKView.mm: (-[WKView fullScreenWindowController]):
+Use a newly minted initializer for the controller.
+
+* UIProcess/mac/WKFullScreenWindowController.h: Removed unused web view accessors.
+Changed the class to take web view at initialization time.
+
+* UIProcess/mac/WKFullScreenWindowController.mm:
+(-[WKFullScreenWindowController initWithWindow:webView:]): Initialize the controller
+inone step.
+(-[WKFullScreenWindowController dealloc]): WebView is now a raw pointer, no need
+to zero it.
+(-[WKFullScreenWindowController close]): Make sure to not leave a dangling WKView
+pointer (this method is indirectly but inevitably called when WKView is deallocated).
+
2013-09-05 Anders Carlsson ander...@apple.com
Replace uses of CLANG_PRAGMA with #pragma
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (155152 => 155153)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2013-09-05 21:52:25 UTC (rev 155152)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2013-09-05 22:06:31 UTC (rev 155153)
@@ -2937,10 +2937,9 @@
- (WKFullScreenWindowController*)fullScreenWindowController
{
-if (!_data-_fullScreenWindowController) {
-_data-_fullScreenWindowController = adoptNS([[WKFullScreenWindowController alloc] initWithWindow:[self createFullScreenWindow]]);
-[_data-_fullScreenWindowController.get() setWebView:self];
-}
+if (!_data-_fullScreenWindowController)
+_data-_fullScreenWindowController = adoptNS([[WKFullScreenWindowController alloc] initWithWindow:[self createFullScreenWindow] webView:self]);
+
return _data-_fullScreenWindowController.get();
}
Modified: trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.h (155152 => 155153)
--- trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.h 2013-09-05 21:52:25 UTC (rev 155152)
+++ trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.h 2013-09-05 22:06:31 UTC (rev 155153)
@@ -46,7 +46,7 @@
@interface WKFullScreenWindowController : NSWindowControllerNSWindowDelegate {
@private
-WKView *_webView;
+WKView *_webView; // Cannot be retained, see rdar://problem/14884666.
RetainPtrWebCoreFullScreenPlaceholderView _webViewPlaceholder;
RetainPtrWebWindowScaleAnimation _scaleAnimation;
RetainPtrWebWindowFadeAnimation _fadeAnimation;
@@ -60,8 +60,7 @@
double _savedScale;
}
-- (WKView*)webView;
-- (void)setWebView:(WKView*)webView;
+- (id)initWithWindow:(NSWindow *)window webView:(WKView *)webView;
- (WebCoreFullScreenPlaceholderView*)webViewPlaceholder;
Modified: trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (155152 => 155153)
--- trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm 2013-09-05 21:52:25 UTC (rev 155152)
+++ trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm 2013-09-05 22:06:31 UTC (rev 155153)
@@ -89,7 +89,7 @@
#pragma mark -
#pragma mark Initialization
-- (id)initWithWindow:(NSWindow *)window
+- (id)initWithWindow:(NSWindow *)window
[webkit-changes] [155166] trunk/Source/JavaScriptCore
Title: [155166] trunk/Source/_javascript_Core
Revision 155166
Author mr...@apple.com
Date 2013-09-05 18:08:48 -0700 (Thu, 05 Sep 2013)
Log Message
Roll out r155149 since it broke the build.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/dfg/DFGUseKind.cpp
trunk/Source/_javascript_Core/dfg/DFGUseKind.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (155165 => 155166)
--- trunk/Source/_javascript_Core/ChangeLog 2013-09-06 00:55:42 UTC (rev 155165)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-09-06 01:08:48 UTC (rev 155166)
@@ -23,46 +23,6 @@
(JSC::CodeBlock::printLocationAndOp):
(JSC::CodeBlock::printLocationOpAndRegisterOperand):
-2013-09-05 Filip Pizlo fpi...@apple.com
-
-REGRESSION(149636, merged in 153145): ToThis conversion doesn't work in the DFG
-https://bugs.webkit.org/show_bug.cgi?id=120781
-
-Reviewed by Mark Hahnenberg.
-
-- Use some method table hacks to detect if the CheckStructure optimization is
- valid for to_this.
-
-- Introduce a FinalObjectUse and use it for ToThis-Identity conversion.
-
-This looks like it might be perf-neutral on the major benchmarks, but it
-introduces some horrible performance cliffs. For example if you add methods to
-the Array prototype, you'll get horrible performance cliffs. As in virtual calls
-to C++ every time you call a JS function even if it's inlined.
-LongSpider/3d-cube appears to hit this.
-
-* dfg/DFGAbstractInterpreterInlines.h:
-(JSC::DFGexecuteEffects):
-* dfg/DFGByteCodeParser.cpp:
-(JSC::DFG::ByteCodeParser::parseBlock):
-* dfg/DFGFixupPhase.cpp:
-(JSC::DFG::FixupPhase::fixupNode):
-* dfg/DFGSafeToExecute.h:
-(JSC::DFG::SafeToExecuteEdge::operator()):
-* dfg/DFGSpeculativeJIT.cpp:
-(JSC::DFG::SpeculativeJIT::speculateFinalObject):
-(JSC::DFG::SpeculativeJIT::speculate):
-* dfg/DFGSpeculativeJIT.h:
-* dfg/DFGSpeculativeJIT32_64.cpp:
-(JSC::DFG::SpeculativeJIT::compile):
-* dfg/DFGSpeculativeJIT64.cpp:
-(JSC::DFG::SpeculativeJIT::compile):
-* dfg/DFGUseKind.cpp:
-(WTF::printInternal):
-* dfg/DFGUseKind.h:
-(JSC::DFG::typeFilterFor):
-(JSC::DFG::isCell):
-
2013-09-05 Anders Carlsson ander...@apple.com
GCAssertions.h should use STL type traits and static_assert
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (155165 => 155166)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2013-09-06 00:55:42 UTC (rev 155165)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2013-09-06 01:08:48 UTC (rev 155166)
@@ -1086,7 +1086,7 @@
AbstractValue destination = forNode(node);
destination = source;
-destination.merge(SpecObject);
+destination.merge(SpecObjectOther);
break;
}
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (155165 => 155166)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2013-09-06 00:55:42 UTC (rev 155165)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2013-09-06 01:08:48 UTC (rev 155166)
@@ -1902,8 +1902,7 @@
if (profile-m_singletonValueIsTop
|| !profile-m_singletonValue
|| !profile-m_singletonValue.isCell()
-|| profile-m_singletonValue.asCell()-classInfo() != Structure::info()
-|| static_castStructure*(profile-m_singletonValue.asCell())-classInfo()-methodTable.toThis != JSObject::info()-methodTable.toThis)
+|| profile-m_singletonValue.asCell()-classInfo() != Structure::info())
setThis(addToGraph(ToThis, op1));
else {
addToGraph(
Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (155165 => 155166)
--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2013-09-06 00:55:42 UTC (rev 155165)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2013-09-06 01:08:48 UTC (rev 155166)
@@ -706,7 +706,7 @@
}
if (isFinalObjectSpeculation(node-child1()-prediction())) {
-setUseKindAndUnboxIfProfitableFinalObjectUse(node-child1());
+setUseKindAndUnboxIfProfitableObjectUse(node-child1());
[webkit-changes] [155154] trunk/Source/WebInspectorUI
Title: [155154] trunk/Source/WebInspectorUI
Revision 155154
Author commit-qu...@webkit.org
Date 2013-09-05 15:11:29 -0700 (Thu, 05 Sep 2013)
Log Message
Web Inspector: Remove harmless assert, triggered hitting breakpoint in auto prettyprinted code on reload
https://bugs.webkit.org/show_bug.cgi?id=120332
Patch by Joseph Pecoraro pecor...@apple.com on 2013-09-05
Reviewed by Timothy Hatcher.
* UserInterface/TextEditor.js:
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/TextEditor.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (155153 => 155154)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-09-05 22:06:31 UTC (rev 155153)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-09-05 22:11:29 UTC (rev 155154)
@@ -1,5 +1,14 @@
2013-09-05 Joseph Pecoraro pecor...@apple.com
+Web Inspector: Remove harmless assert, triggered hitting breakpoint in auto prettyprinted code on reload
+https://bugs.webkit.org/show_bug.cgi?id=120332
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/TextEditor.js:
+
+2013-09-05 Joseph Pecoraro pecor...@apple.com
+
Web Inspector: Breakpoint Actions
https://bugs.webkit.org/show_bug.cgi?id=120576
Modified: trunk/Source/WebInspectorUI/UserInterface/TextEditor.js (155153 => 155154)
--- trunk/Source/WebInspectorUI/UserInterface/TextEditor.js 2013-09-05 22:06:31 UTC (rev 155153)
+++ trunk/Source/WebInspectorUI/UserInterface/TextEditor.js 2013-09-05 22:11:29 UTC (rev 155154)
@@ -1180,7 +1180,6 @@
}
if (!isNaN(this._executionLineNumber)) {
-console.assert(this._executionLineHandle);
console.assert(!isNaN(this._executionColumnNumber));
newExecutionLocation = this._formatterSourceMap.originalToFormatted(this._executionLineNumber, this._executionColumnNumber);
}
@@ -1204,7 +1203,6 @@
}
if (!isNaN(this._executionLineNumber)) {
-console.assert(this._executionLineHandle);
console.assert(!isNaN(this._executionColumnNumber));
newExecutionLocation = this._formatterSourceMap.formattedToOriginal(this._executionLineNumber, this._executionColumnNumber);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155161] trunk/Source/WebCore
Title: [155161] trunk/Source/WebCore Revision 155161 Author a...@apple.com Date 2013-09-05 17:16:28 -0700 (Thu, 05 Sep 2013) Log Message Flaky Test: platform/mac/editing/deleting/deletionUI-single-instance.html https://bugs.webkit.org/show_bug.cgi?id=114181 Reviewed by Ryosuke Niwa. Editor survives navigations, and so did DeleteButtonController. But the state it holds is document specific (like nodes in the old document). * editing/Editor.cpp: (WebCore::Editor::clear): Replace DeleteButtonController. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/Editor.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (155160 => 155161) --- trunk/Source/WebCore/ChangeLog 2013-09-05 23:30:32 UTC (rev 155160) +++ trunk/Source/WebCore/ChangeLog 2013-09-06 00:16:28 UTC (rev 155161) @@ -1,3 +1,15 @@ +2013-09-05 Alexey Proskuryakov a...@apple.com + +Flaky Test: platform/mac/editing/deleting/deletionUI-single-instance.html +https://bugs.webkit.org/show_bug.cgi?id=114181 + +Reviewed by Ryosuke Niwa. + +Editor survives navigations, and so did DeleteButtonController. But the state it holds +is document specific (like nodes in the old document). + +* editing/Editor.cpp: (WebCore::Editor::clear): Replace DeleteButtonController. + 2013-09-05 Gyuyoung Kim gyuyoung@samsung.com Generate toFooElement() functions from tagname data. Modified: trunk/Source/WebCore/editing/Editor.cpp (155160 => 155161) --- trunk/Source/WebCore/editing/Editor.cpp 2013-09-05 23:30:32 UTC (rev 155160) +++ trunk/Source/WebCore/editing/Editor.cpp 2013-09-06 00:16:28 UTC (rev 155161) @@ -921,6 +921,10 @@ m_customCompositionUnderlines.clear(); m_shouldStyleWithCSS = false; m_defaultParagraphSeparator = EditorParagraphSeparatorIsDiv; + +#if ENABLE(DELETION_UI) +m_deleteButtonController = adoptPtr(new DeleteButtonController(m_frame)); +#endif } bool Editor::insertText(const String text, Event* triggeringEvent) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155144] trunk/Source/WebKit2
Title: [155144] trunk/Source/WebKit2
Revision 155144
Author ander...@apple.com
Date 2013-09-05 13:17:48 -0700 (Thu, 05 Sep 2013)
Log Message
Replace uses of CLANG_PRAGMA with #pragma
Rubber-stamped by Andreas Kling.
This file is only compiled by clang anyway.
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::load):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (155143 => 155144)
--- trunk/Source/WebKit2/ChangeLog 2013-09-05 20:12:23 UTC (rev 155143)
+++ trunk/Source/WebKit2/ChangeLog 2013-09-05 20:17:48 UTC (rev 155144)
@@ -1,5 +1,16 @@
2013-09-05 Anders Carlsson ander...@apple.com
+Replace uses of CLANG_PRAGMA with #pragma
+
+Rubber-stamped by Andreas Kling.
+
+This file is only compiled by clang anyway.
+
+* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
+(WebKit::InjectedBundle::load):
+
+2013-09-05 Anders Carlsson ander...@apple.com
+
GCAssertions.h should use STL type traits and static_assert
https://bugs.webkit.org/show_bug.cgi?id=120785
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm (155143 => 155144)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm 2013-09-05 20:12:23 UTC (rev 155143)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm 2013-09-05 20:17:48 UTC (rev 155144)
@@ -113,10 +113,10 @@
objCInitializationUserData = static_castObjCObjectGraph*(initializationUserData)-rootObject();
[instance webProcessPlugIn:[WKWebProcessPlugInController _shared] initializeWithObject:objCInitializationUserData.get()];
} else if ([instance respondsToSelector:@selector(webProcessPlugInInitialize:)]) {
-CLANG_PRAGMA(clang diagnostic push)
-CLANG_PRAGMA(clang diagnostic ignored \-Wdeprecated-declarations\)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored -Wdeprecated-declarations
[instance webProcessPlugInInitialize:[WKWebProcessPlugInController _shared]];
-CLANG_PRAGMA(clang diagnostic pop)
+#pragma clang diagnostic pop
}
return true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155167] trunk/Source/WebCore
Title: [155167] trunk/Source/WebCore
Revision 155167
Author akl...@apple.com
Date 2013-09-05 18:24:45 -0700 (Thu, 05 Sep 2013)
Log Message
ContainerNode: Apply RefT to some popular DOM functions.
https://webkit.org/b/120800
Reviewed by Antti Koivisto.
Use Ref to avoid a bunch of null checks in some popular DOM functions.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
'refChild' is never null here, so store it in a Ref.
(WebCore::ContainerNode::replaceChild):
'removedChild' is never null here, so store it in a Ref.
(WebCore::ContainerNode::removeChild):
'child' is never null here, so store it in a Ref.
Also return true at the end of the function since we can't
null-check 'child' anymore (not that it would ever be false!)
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
Use RefDocument in both of these methods.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155166 => 155167)
--- trunk/Source/WebCore/ChangeLog 2013-09-06 01:08:48 UTC (rev 155166)
+++ trunk/Source/WebCore/ChangeLog 2013-09-06 01:24:45 UTC (rev 155167)
@@ -1,5 +1,34 @@
2013-09-05 Andreas Kling akl...@apple.com
+ContainerNode: Apply RefT to some popular DOM functions.
+https://webkit.org/b/120800
+
+Reviewed by Antti Koivisto.
+
+Use Ref to avoid a bunch of null checks in some popular DOM functions.
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::insertBefore):
+
+'refChild' is never null here, so store it in a Ref.
+
+(WebCore::ContainerNode::replaceChild):
+
+'removedChild' is never null here, so store it in a Ref.
+
+(WebCore::ContainerNode::removeChild):
+
+'child' is never null here, so store it in a Ref.
+Also return true at the end of the function since we can't
+null-check 'child' anymore (not that it would ever be false!)
+
+(WebCore::dispatchChildInsertionEvents):
+(WebCore::dispatchChildRemovalEvents):
+
+Use RefDocument in both of these methods.
+
+2013-09-05 Andreas Kling akl...@apple.com
+
ScrollView::children() should return a reference.
https://webkit.org/b/120795
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (155166 => 155167)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2013-09-06 01:08:48 UTC (rev 155166)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2013-09-06 01:24:45 UTC (rev 155167)
@@ -284,7 +284,7 @@
if (refChild-previousSibling() == newChild || refChild == newChild) // nothing to do
return true;
-RefPtrNode next = refChild;
+RefNode next(*refChild);
NodeVector targets;
collectChildrenAndRemoveFromOldParent(newChild.get(), targets, ec);
@@ -314,7 +314,7 @@
treeScope()-adoptIfNeeded(child);
-insertBeforeCommon(next.get(), child);
+insertBeforeCommon(next.get(), child);
updateTreeAfterInsertion(child, attachBehavior);
}
@@ -431,7 +431,7 @@
RefPtrNode next = oldChild-nextSibling();
// Remove the node we're replacing
-RefPtrNode removedChild = oldChild;
+RefNode removedChild(*oldChild);
removeChild(oldChild, ec);
if (ec)
return false;
@@ -543,12 +543,12 @@
return false;
}
-RefPtrNode child = oldChild;
+RefNode child(*oldChild);
-document().removeFocusedNodeOfSubtree(child.get());
+document().removeFocusedNodeOfSubtree(child.get());
#if ENABLE(FULLSCREEN_API)
-document().removeFullScreenElementOfSubtree(child.get());
+document().removeFullScreenElementOfSubtree(child.get());
#endif
// Events fired when blurring currently focused node might have moved this
@@ -558,7 +558,7 @@
return false;
}
-willRemoveChild(child.get());
+willRemoveChild(child.get());
// Mutation events might have moved this child into a different parent.
if (child-parentNode() != this) {
@@ -571,15 +571,15 @@
Node* prev = child-previousSibling();
Node* next = child-nextSibling();
-removeBetween(prev, next, child.get());
+removeBetween(prev, next, child.get());
-notifyChildRemoved(child.get(), prev, next, ChildChangeSourceAPI);
+notifyChildRemoved(child.get(), prev, next, ChildChangeSourceAPI);
-ChildNodeRemovalNotifier(this).notify(child.get());
+ChildNodeRemovalNotifier(this).notify(child.get());
}
dispatchSubtreeModifiedEvent();
-return child;
+return true;
}
void ContainerNode::removeBetween(Node* previousChild, Node* nextChild, Node* oldChild)
@@ -1026,7 +1026,7 @@
ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden());
RefPtrNode c = child;
-RefPtrDocument document = child-document();
+RefDocument document(child-document());
if
[webkit-changes] [155168] trunk/Source/WebCore
Title: [155168] trunk/Source/WebCore
Revision 155168
Author akl...@apple.com
Date 2013-09-05 18:34:05 -0700 (Thu, 05 Sep 2013)
Log Message
FrameLoader: Convert three little loops to using VectorRefFrame.
https://webkit.org/b/120798
Reviewed by Antti Koivisto.
Also apply a bit of inline capacity + reserveInitialCapacity + uncheckedAppend
in FrameLoader::detachChildren() since we know the final size from the start.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachChildren):
(WebCore::FrameLoader::checkLoadComplete):
(WebCore::FrameLoader::shouldClose):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155167 => 155168)
--- trunk/Source/WebCore/ChangeLog 2013-09-06 01:24:45 UTC (rev 155167)
+++ trunk/Source/WebCore/ChangeLog 2013-09-06 01:34:05 UTC (rev 155168)
@@ -1,5 +1,20 @@
2013-09-05 Andreas Kling akl...@apple.com
+FrameLoader: Convert three little loops to using VectorRefFrame.
+https://webkit.org/b/120798
+
+Reviewed by Antti Koivisto.
+
+Also apply a bit of inline capacity + reserveInitialCapacity + uncheckedAppend
+in FrameLoader::detachChildren() since we know the final size from the start.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::detachChildren):
+(WebCore::FrameLoader::checkLoadComplete):
+(WebCore::FrameLoader::shouldClose):
+
+2013-09-05 Andreas Kling akl...@apple.com
+
ContainerNode: Apply RefT to some popular DOM functions.
https://webkit.org/b/120800
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (155167 => 155168)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2013-09-06 01:24:45 UTC (rev 155167)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2013-09-06 01:34:05 UTC (rev 155168)
@@ -2318,14 +2318,12 @@
void FrameLoader::detachChildren()
{
-typedef VectorRefPtrFrame FrameVector;
-FrameVector childrenToDetach;
-childrenToDetach.reserveCapacity(m_frame.tree().childCount());
+VectorRefFrame, 16 childrenToDetach;
+childrenToDetach.reserveInitialCapacity(m_frame.tree().childCount());
for (Frame* child = m_frame.tree().lastChild(); child; child = child-tree().previousSibling())
-childrenToDetach.append(child);
-FrameVector::iterator end = childrenToDetach.end();
-for (FrameVector::iterator it = childrenToDetach.begin(); it != end; ++it)
-(*it)-loader().detachFromParent();
+childrenToDetach.uncheckedAppend(*child);
+for (unsigned i = 0; i childrenToDetach.size(); ++i)
+childrenToDetach[i]-loader().detachFromParent();
}
void FrameLoader::closeAndRemoveChild(Frame* child)
@@ -2348,16 +2346,18 @@
m_shouldCallCheckLoadComplete = false;
+if (!m_frame.page())
+return;
+
// FIXME: Always traversing the entire frame tree is a bit inefficient, but
// is currently needed in order to null out the previous history item for all frames.
-if (Page* page = m_frame.page()) {
-VectorRefPtrFrame, 10 frames;
-for (RefPtrFrame frame = page-mainFrame(); frame; frame = frame-tree().traverseNext())
-frames.append(frame);
-// To process children before their parents, iterate the vector backwards.
-for (size_t i = frames.size(); i; --i)
-frames[i - 1]-loader().checkLoadCompleteForThisFrame();
-}
+VectorRefFrame, 16 frames;
+for (Frame* frame = m_frame.page()-mainFrame(); frame; frame = frame-tree().traverseNext())
+frames.append(*frame);
+
+// To process children before their parents, iterate the vector backwards.
+for (unsigned i = frames.size(); i; --i)
+frames[i - 1]-loader().checkLoadCompleteForThisFrame();
}
int FrameLoader::numPendingOrLoadingRequests(bool recurse) const
@@ -2722,10 +2722,10 @@
return true;
// Store all references to each subframe in advance since beforeunload's event handler may modify frame
-VectorRefPtrFrame targetFrames;
-targetFrames.append(m_frame);
+VectorRefFrame, 16 targetFrames;
+targetFrames.append(m_frame);
for (Frame* child = m_frame.tree().firstChild(); child; child = child-tree().traverseNext(m_frame))
-targetFrames.append(child);
+targetFrames.append(*child);
bool shouldClose = false;
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155124] trunk/Tools
Title: [155124] trunk/Tools
Revision 155124
Author o...@webkit.org
Date 2013-09-05 09:42:00 -0700 (Thu, 05 Sep 2013)
Log Message
Make build.webkit.org report the number of failing run-fast-jsc tests
https://bugs.webkit.org/show_bug.cgi?id=120766
Reviewed by Filip Pizlo.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunJavaScriptCoreTests.commandComplete):
(RunJavaScriptCoreTests.getText2):
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(RunJavaScriptCoreTestsTest): Added.
(RunJavaScriptCoreTestsTest.assertResults):
(RunJavaScriptCoreTestsTest.test_no_regressions_old_output):
(RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
(RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output):
(RunJavaScriptCoreTestsTest.test_fast_js_failure_new_output):
(RunJavaScriptCoreTestsTest.test_fast_js_crash_new_output):
(RunJavaScriptCoreTestsTest.test_mozilla_and_fast_js_failure_new_output):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (155123 => 155124)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2013-09-05 16:28:15 UTC (rev 155123)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2013-09-05 16:42:00 UTC (rev 155124)
@@ -257,14 +257,34 @@
def commandComplete(self, cmd):
shell.Test.commandComplete(self, cmd)
-
logText = cmd.logs['stdio'].getText()
-statusLines = [line for line in logText.splitlines() if line.find('regression') = 0 and line.find(' found.') = 0]
-if statusLines and statusLines[0].split()[0] != '0':
-self.regressionLine = statusLines[0]
-else:
-self.regressionLine = None
+expressions = [
+('failing Mozilla test', re.compile(r'(\d+) regression')),
+('failing fast/js test', re.compile(r'(\d+) failure')),
+('crashing fast/js test', re.compile(r'(\d+) crash')),
+]
+resultLines = {}
+
+for line in logText.splitlines():
+for name, _expression_ in expressions:
+match = _expression_.search(line)
+if match:
+resultLines[name] = int(match.group(1))
+break
+
+self.regressionLine = []
+for name in resultLines:
+failures = resultLines[name]
+if not failures:
+continue
+
+if failures == 1:
+pluralSuffix = ''
+else:
+pluralSuffix = 's'
+self.regressionLine.append(%d %s%s % (failures, name, pluralSuffix))
+
if 'actual.html (source)' in cmd.logs:
self.addHTMLLog('actual.html', cmd.logs['actual.html (source)'].getText())
@@ -281,12 +301,10 @@
return self.getText2(cmd, results)
def getText2(self, cmd, results):
-if results != SUCCESS and self.regressionLine:
-return [self.name, self.regressionLine]
+result = [self.name]
+result.extend(self.regressionLine)
+return result
-return [self.name]
-
-
class RunWebKitTests(shell.Test):
name = layout-test
description = [layout-tests running]
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py (155123 => 155124)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py 2013-09-05 16:28:15 UTC (rev 155123)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py 2013-09-05 16:42:00 UTC (rev 155124)
@@ -101,6 +101,68 @@
self.logs = {'stdio': StubStdio(stdio)}
+class RunJavaScriptCoreTestsTest(unittest.TestCase):
+def assertResults(self, expected_result, expected_text, rc, stdio):
+cmd = StubRemoteCommand(rc, stdio)
+step = RunJavaScriptCoreTests()
+step.commandComplete(cmd)
+actual_results = step.evaluateCommand(cmd)
+actual_text = step.getText2(cmd, actual_results)
+
+self.assertEqual(expected_result, actual_results)
+self.assertEqual(actual_text, expected_text)
+
+def test_no_regressions_old_output(self):
+self.assertResults(SUCCESS, [jscore-test], 0, Results for Mozilla tests:
+0 regressions found.
+0 tests fixed.
+OK.)
+
+def test_mozilla_failure_old_output(self):
+self.assertResults(FAILURE, [jscore-test, '1 failing Mozilla test '], 1, Results for Mozilla tests:
+1 regression found.
+0 tests fixed.)
+
+def test_mozilla_failure_new_output(self):
+self.assertResults(FAILURE, [jscore-test, '1 failing Mozilla test '], 1, Results for Mozilla tests:
+1 regression found.
+0 tests fixed.
+
+Results for fast/js tests:
+0 failures found.
+0 crashes found.
+OK.)
+
+def
[webkit-changes] [155125] trunk/Source/WebKit2
Title: [155125] trunk/Source/WebKit2
Revision 155125
Author be...@igalia.com
Date 2013-09-05 10:10:13 -0700 (Thu, 05 Sep 2013)
Log Message
[WK2] [GTK] Remove the test to disable AC under Wayland from WebKitWebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=120762
Reviewed by Gustavo Noronha Silva.
The code to disable AC under Wayland is not run if we're using
WebKitTestRunner, so it would be better to move it to
WebKitWebViewBase.
However it's not really necessary to do that, instead it's much
simpler to disable accelerated compositing in all cases unless we
know we can support it.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseUpdatePreferences):
* UIProcess/API/gtk/WebKitWebViewGroup.cpp:
(webkitWebViewGroupAttachSettingsToPageGroup):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGroup.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (155124 => 155125)
--- trunk/Source/WebKit2/ChangeLog 2013-09-05 16:42:00 UTC (rev 155124)
+++ trunk/Source/WebKit2/ChangeLog 2013-09-05 17:10:13 UTC (rev 155125)
@@ -1,3 +1,23 @@
+2013-09-05 Alberto Garcia be...@igalia.com
+
+[WK2] [GTK] Remove the test to disable AC under Wayland from WebKitWebViewGroup
+https://bugs.webkit.org/show_bug.cgi?id=120762
+
+Reviewed by Gustavo Noronha Silva.
+
+The code to disable AC under Wayland is not run if we're using
+WebKitTestRunner, so it would be better to move it to
+WebKitWebViewBase.
+
+However it's not really necessary to do that, instead it's much
+simpler to disable accelerated compositing in all cases unless we
+know we can support it.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseUpdatePreferences):
+* UIProcess/API/gtk/WebKitWebViewGroup.cpp:
+(webkitWebViewGroupAttachSettingsToPageGroup):
+
2013-09-04 Alberto Garcia be...@igalia.com
[WK2][GTK] ASSERTION in WebKit::LayerTreeHostGtk::invalidate
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (155124 => 155125)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2013-09-05 16:42:00 UTC (rev 155124)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2013-09-05 17:10:13 UTC (rev 155125)
@@ -896,12 +896,14 @@
void webkitWebViewBaseUpdatePreferences(WebKitWebViewBase* webkitWebViewBase)
{
-#if USE(TEXTURE_MAPPER_GL)
WebKitWebViewBasePrivate* priv = webkitWebViewBase-priv;
-if (!priv-redirectedWindow)
-priv-pageProxy-pageGroup()-preferences()-setAcceleratedCompositingEnabled(false);
+#if USE(TEXTURE_MAPPER_GL)
+if (priv-redirectedWindow)
+return;
#endif
+
+priv-pageProxy-pageGroup()-preferences()-setAcceleratedCompositingEnabled(false);
}
void webkitWebViewBaseCreateWebPage(WebKitWebViewBase* webkitWebViewBase, WebContext* context, WebPageGroup* pageGroup)
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGroup.cpp (155124 => 155125)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGroup.cpp 2013-09-05 16:42:00 UTC (rev 155124)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGroup.cpp 2013-09-05 17:10:13 UTC (rev 155125)
@@ -28,10 +28,6 @@
#include wtf/gobject/GRefPtr.h
#include wtf/text/CString.h
-#ifdef GDK_WINDOWING_WAYLAND
-#include gdk/gdkwayland.h
-#endif
-
using namespace WebKit;
/**
@@ -130,12 +126,6 @@
static void webkitWebViewGroupAttachSettingsToPageGroup(WebKitWebViewGroup* group)
{
group-priv-pageGroup-setPreferences(webkitSettingsGetPreferences(group-priv-settings.get()));
-
-#ifdef GDK_WINDOWING_WAYLAND
-GdkDisplay* display = gdk_display_manager_get_default_display(gdk_display_manager_get());
-if (GDK_IS_WAYLAND_DISPLAY(display))
-group-priv-pageGroup-preferences()-setAcceleratedCompositingEnabled(false);
-#endif
}
WebKitWebViewGroup* webkitWebViewGroupCreate(WebPageGroup* pageGroup)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155156] tags/Safari-537.69/
Title: [155156] tags/Safari-537.69/ Revision 155156 Author lforsch...@apple.com Date 2013-09-05 16:11:16 -0700 (Thu, 05 Sep 2013) Log Message New Tag. Added Paths tags/Safari-537.69/ Diff Property changes: tags/Safari-537.69 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155126] trunk/Source/WTF
Title: [155126] trunk/Source/WTF
Revision 155126
Author ander...@apple.com
Date 2013-09-05 10:11:55 -0700 (Thu, 05 Sep 2013)
Log Message
Change StringBuffer back to not use an OwnPtr in an attempt to fix ports.
* wtf/text/StringBuffer.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringBuffer.h
Diff
Modified: trunk/Source/WTF/ChangeLog (155125 => 155126)
--- trunk/Source/WTF/ChangeLog 2013-09-05 17:10:13 UTC (rev 155125)
+++ trunk/Source/WTF/ChangeLog 2013-09-05 17:11:55 UTC (rev 155126)
@@ -1,3 +1,9 @@
+2013-09-05 Anders Carlsson ander...@apple.com
+
+Change StringBuffer back to not use an OwnPtr in an attempt to fix ports.
+
+* wtf/text/StringBuffer.h:
+
2013-09-04 Anders Carlsson ander...@apple.com
Vector::releaseBuffer should return an OwnPtr
Modified: trunk/Source/WTF/wtf/text/StringBuffer.h (155125 => 155126)
--- trunk/Source/WTF/wtf/text/StringBuffer.h 2013-09-05 17:10:13 UTC (rev 155125)
+++ trunk/Source/WTF/wtf/text/StringBuffer.h 2013-09-05 17:11:55 UTC (rev 155126)
@@ -44,11 +44,12 @@
{
if (m_length std::numeric_limitsunsigned::max() / sizeof(CharType))
CRASH();
-m_data = adoptPtr(static_castCharType*(fastMalloc(m_length * sizeof(CharType;
+m_data = static_castCharType*(fastMalloc(m_length * sizeof(CharType)));
}
~StringBuffer()
{
+fastFree(m_data);
}
void shrink(unsigned newLength)
@@ -62,29 +63,26 @@
if (newLength m_length) {
if (newLength std::numeric_limitsunsigned::max() / sizeof(UChar))
CRASH();
-m_data = adoptPtr(static_castUChar*(fastRealloc(m_data.release().leakPtr(), newLength * sizeof(UChar;
+m_data = static_castUChar*(fastRealloc(m_data, newLength * sizeof(UChar)));
}
m_length = newLength;
}
unsigned length() const { return m_length; }
-CharType* characters() { return m_data.get(); }
+CharType* characters() { return m_data; }
-CharType operator[](unsigned i)
-{
-ASSERT_WITH_SECURITY_IMPLICATION(i m_length);
-return m_data.get()[i];
-}
+CharType operator[](unsigned i) { ASSERT_WITH_SECURITY_IMPLICATION(i m_length); return m_data[i]; }
PassOwnPtrCharType release()
{
-OwnPtrCharType data = ""
-return data.release();
+CharType* data = ""
+m_data = 0;
+return adoptPtr(data);
}
private:
unsigned m_length;
-OwnPtrCharType m_data;
+CharType* m_data;
};
} // namespace WTF
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155157] branches/safari-537-branch/Source
Title: [155157] branches/safari-537-branch/Source Revision 155157 Author lforsch...@apple.com Date 2013-09-05 16:13:13 -0700 (Thu, 05 Sep 2013) Log Message Versioning. Modified Paths branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig (155156 => 155157) --- branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2013-09-05 23:11:16 UTC (rev 155156) +++ branches/safari-537-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2013-09-05 23:13:13 UTC (rev 155157) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 69; +MINOR_VERSION = 70; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig (155156 => 155157) --- branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig 2013-09-05 23:11:16 UTC (rev 155156) +++ branches/safari-537-branch/Source/WebCore/Configurations/Version.xcconfig 2013-09-05 23:13:13 UTC (rev 155157) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 69; +MINOR_VERSION = 70; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (155156 => 155157) --- branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2013-09-05 23:11:16 UTC (rev 155156) +++ branches/safari-537-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2013-09-05 23:13:13 UTC (rev 155157) @@ -1,5 +1,5 @@ MAJOR_VERSION = 537; -MINOR_VERSION = 69; +MINOR_VERSION = 70; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig (155156 => 155157) --- branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2013-09-05 23:11:16 UTC (rev 155156) +++ branches/safari-537-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2013-09-05 23:13:13 UTC (rev 155157) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 69; +MINOR_VERSION = 70; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig (155156 => 155157) --- branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig 2013-09-05 23:11:16 UTC (rev 155156) +++ branches/safari-537-branch/Source/WebKit2/Configurations/Version.xcconfig 2013-09-05 23:13:13 UTC (rev 155157) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 69; +MINOR_VERSION = 70; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155158] trunk/Source/WTF
Title: [155158] trunk/Source/WTF Revision 155158 Author ander...@apple.com Date 2013-09-05 16:13:42 -0700 (Thu, 05 Sep 2013) Log Message Fix build with older versions of clang from Xcode. * wtf/Compiler.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Compiler.h Diff Modified: trunk/Source/WTF/ChangeLog (155157 => 155158) --- trunk/Source/WTF/ChangeLog 2013-09-05 23:13:13 UTC (rev 155157) +++ trunk/Source/WTF/ChangeLog 2013-09-05 23:13:42 UTC (rev 155158) @@ -1,5 +1,11 @@ 2013-09-05 Anders Carlsson ander...@apple.com +Fix build with older versions of clang from Xcode. + +* wtf/Compiler.h: + +2013-09-05 Anders Carlsson ander...@apple.com + Make Vector::uncheckedAppend work with move-only types https://bugs.webkit.org/show_bug.cgi?id=120799 Modified: trunk/Source/WTF/wtf/Compiler.h (155157 => 155158) --- trunk/Source/WTF/wtf/Compiler.h 2013-09-05 23:13:13 UTC (rev 155157) +++ trunk/Source/WTF/wtf/Compiler.h 2013-09-05 23:13:42 UTC (rev 155158) @@ -57,7 +57,7 @@ /* Disable final on versions of Apple clang earlier than 4.2 to avoid bugs like http://webkit.org/b/119165 */ #if defined(__APPLE__) (__clang_major__ 4 || (__clang_major__ == 4 __clang_minor__ 2)) -#define WTF_COMPILER_QUIRK_FINAL_IS_BUGGY +#define WTF_COMPILER_QUIRK_FINAL_IS_BUGGY 1 #endif #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155148] trunk/Source/WTF
Title: [155148] trunk/Source/WTF Revision 155148 Author ander...@apple.com Date 2013-09-05 14:17:35 -0700 (Thu, 05 Sep 2013) Log Message Add COMPILER_SUPPORTS(CXX_AUTO_TYPE) and #error if it's 0 https://bugs.webkit.org/show_bug.cgi?id=120794 Reviewed by Andreas Kling. People have already begun using C++11 auto in WebCore, so let's make it a prerequisite. * wtf/Compiler.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Compiler.h Diff Modified: trunk/Source/WTF/ChangeLog (155147 => 155148) --- trunk/Source/WTF/ChangeLog 2013-09-05 21:07:41 UTC (rev 155147) +++ trunk/Source/WTF/ChangeLog 2013-09-05 21:17:35 UTC (rev 155148) @@ -1,5 +1,16 @@ 2013-09-05 Anders Carlsson ander...@apple.com +Add COMPILER_SUPPORTS(CXX_AUTO_TYPE) and #error if it's 0 +https://bugs.webkit.org/show_bug.cgi?id=120794 + +Reviewed by Andreas Kling. + +People have already begun using C++11 auto in WebCore, so let's make it a prerequisite. + +* wtf/Compiler.h: + +2013-09-05 Anders Carlsson ander...@apple.com + Clean up wtf/Compiler.h https://bugs.webkit.org/show_bug.cgi?id=120790 Modified: trunk/Source/WTF/wtf/Compiler.h (155147 => 155148) --- trunk/Source/WTF/wtf/Compiler.h 2013-09-05 21:07:41 UTC (rev 155147) +++ trunk/Source/WTF/wtf/Compiler.h 2013-09-05 21:17:35 UTC (rev 155148) @@ -53,6 +53,7 @@ #define WTF_COMPILER_SUPPORTS_CXX_OVERRIDE_CONTROL __has_feature(cxx_override_control) #define WTF_COMPILER_SUPPORTS_CXX_STRONG_ENUMS __has_feature(cxx_strong_enums) #define WTF_COMPILER_SUPPORTS_CXX_REFERENCE_QUALIFIED_FUNCTIONS __has_feature(cxx_reference_qualified_functions) +#define WTF_COMPILER_SUPPORTS_CXX_AUTO_TYPE __has_feature(cxx_auto_type) /* Disable final on versions of Apple clang earlier than 4.2 to avoid bugs like http://webkit.org/b/119165 */ #if defined(__APPLE__) (__clang_major__ 4 || (__clang_major__ == 4 __clang_minor__ 2)) @@ -83,6 +84,7 @@ #if _MSC_VER = 1600 #define WTF_COMPILER_SUPPORTS_CXX_RVALUE_REFERENCES 1 #define WTF_COMPILER_SUPPORTS_CXX_STATIC_ASSERT 1 +#define WTF_COMPILER_SUPPORTS_CXX_AUTO_TYPE 1 #endif #endif /* defined(_MSC_VER) */ @@ -130,6 +132,7 @@ #define WTF_COMPILER_SUPPORTS_CXX_RVALUE_REFERENCES 1 #define WTF_COMPILER_SUPPORTS_CXX_STATIC_ASSERT 1 #define WTF_COMPILER_SUPPORTS_CXX_VARIADIC_TEMPLATES 1 +#define WTF_COMPILER_SUPPORTS_CXX_AUTO_TYPE 1 #endif #if GCC_VERSION_AT_LEAST(4, 4, 0) #define WTF_COMPILER_SUPPORTS_CXX_DELETED_FUNCTIONS 1 @@ -184,7 +187,10 @@ #if !COMPILER_SUPPORTS(CXX_STATIC_ASSERT) #error Please use a compiler that supports C++11 static_assert. #endif +#if !COMPILER_SUPPORTS(CXX_AUTO_TYPE) +#error Please use a compiler that supports C++11 auto. #endif +#endif /* ALWAYS_INLINE */ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155130] trunk/Source/WebCore
Title: [155130] trunk/Source/WebCore Revision 155130 Author bfulg...@apple.com Date 2013-09-05 10:54:11 -0700 (Thu, 05 Sep 2013) Log Message [Windows] Unreviewed build/link improvement after r155127 to be consistent about using debug-build support libraries. Now that rdar://problem/9898937 is resolved, we should be linking to debug AVFoundationCF as well. * page/CaptionUserPreferencesMediaAF.cpp: Link to AVFoundationCF_debug when building with the DEBUG_ALL target. * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Ditto. * platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (155129 => 155130) --- trunk/Source/WebCore/ChangeLog 2013-09-05 17:35:59 UTC (rev 155129) +++ trunk/Source/WebCore/ChangeLog 2013-09-05 17:54:11 UTC (rev 155130) @@ -1,3 +1,16 @@ +2013-09-05 Brent Fulgham bfulg...@apple.com + +[Windows] Unreviewed build/link improvement after r155127 to be +consistent about using debug-build support libraries. + +Now that rdar://problem/9898937 is resolved, we should be linking +to debug AVFoundationCF as well. + +* page/CaptionUserPreferencesMediaAF.cpp: Link to AVFoundationCF_debug +when building with the DEBUG_ALL target. +* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Ditto. +* platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Ditto. + 2013-09-04 Anders Carlsson ander...@apple.com Vector::releaseBuffer should return an OwnPtr Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp (155129 => 155130) --- trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2013-09-05 17:35:59 UTC (rev 155129) +++ trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2013-09-05 17:54:11 UTC (rev 155130) @@ -65,7 +65,13 @@ #define SOFT_LINK_AVF_POINTER(Lib, Name, Type) SOFT_LINK_POINTER_OPTIONAL(Lib, Name, Type) #define SOFT_LINK_AVF_FRAMEWORK_IMPORT(Lib, Fun, ReturnType, Arguments, Signature) SOFT_LINK(Lib, Fun, ReturnType, Arguments, Signature) #else + +#ifdef DEBUG_ALL +#define SOFT_LINK_AVF_FRAMEWORK(Lib) SOFT_LINK_DEBUG_LIBRARY(Lib) +#else #define SOFT_LINK_AVF_FRAMEWORK(Lib) SOFT_LINK_LIBRARY(Lib) +#endif + #define SOFT_LINK_AVF(Lib, Name, Type) SOFT_LINK_DLL_IMPORT(Lib, Name, Type) #define SOFT_LINK_AVF_POINTER(Lib, Name, Type) SOFT_LINK_VARIABLE_DLL_IMPORT_OPTIONAL(Lib, Name, Type) #define SOFT_LINK_AVF_FRAMEWORK_IMPORT(Lib, Fun, ReturnType, Arguments, Signature) SOFT_LINK_DLL_IMPORT(Lib, Fun, ReturnType, __cdecl, Arguments, Signature) Modified: trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp (155129 => 155130) --- trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp 2013-09-05 17:35:59 UTC (rev 155129) +++ trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp 2013-09-05 17:54:11 UTC (rev 155130) @@ -42,7 +42,12 @@ #define SOFT_LINK_AVF_FRAMEWORK(Lib) SOFT_LINK_FRAMEWORK_OPTIONAL(Lib) #define SOFT_LINK_AVF_POINTER(Lib, Name, Type) SOFT_LINK_POINTER_OPTIONAL(Lib, Name, Type) #else +#ifdef DEBUG_ALL +#define SOFT_LINK_AVF_FRAMEWORK(Lib) SOFT_LINK_DEBUG_LIBRARY(Lib) +#else #define SOFT_LINK_AVF_FRAMEWORK(Lib) SOFT_LINK_LIBRARY(Lib) +#endif + #define SOFT_LINK_AVF_POINTER(Lib, Name, Type) SOFT_LINK_VARIABLE_DLL_IMPORT_OPTIONAL(Lib, Name, Type) #endif Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h (155129 => 155130) --- trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h 2013-09-05 17:35:59 UTC (rev 155129) +++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h 2013-09-05 17:54:11 UTC (rev 155130) @@ -28,8 +28,7 @@ // Soft-link against AVFoundationCF functions and variables required by MediaPlayerPrivateAVFoundationCF.cpp. #ifdef DEBUG_ALL -// FIXME: rdar://problem/9898937 AVFoundationCF doesn't currently deliver a debug library. -SOFT_LINK_LIBRARY(AVFoundationCF) +SOFT_LINK_DEBUG_LIBRARY(AVFoundationCF) #else SOFT_LINK_LIBRARY(AVFoundationCF) #endif Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp (155129 => 155130) --- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp 2013-09-05 17:35:59 UTC (rev 155129) +++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp 2013-09-05 17:54:11 UTC (rev 155130) @@ -1009,7 +1009,11 @@ bool
[webkit-changes] [155131] trunk
Title: [155131] trunk
Revision 155131
Author simon.fra...@apple.com
Date 2013-09-05 10:56:58 -0700 (Thu, 05 Sep 2013)
Log Message
Source/WebCore: Fix repaint issue on paints into ancestor filtered layers
https://bugs.webkit.org/show_bug.cgi?id=120780
Reviewed by Tim Horton.
When a repaint happened on a layer with a filter, and which paints into
its compositing ancestor, we'd repaint the wrong layer (and assert).
Fix by ensuring that RenderLayer::enclosingFilterLayer() takes paintsIntoCompositedAncestor()
into account, by adding a function that we share between three callers who
check isComposited() !paintsIntoCompositedAncestor(). I didn't use a function
on RenderLayer, because I wanted it to be inline but to not #include RenderLayerBacking
in RenderLayer.h.
Test: compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html
* dom/Node.cpp: Drive-by removal of #include RenderLayer.h
* rendering/RenderLayer.cpp:
(WebCore::compositedWithOwnBackingStore):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint):
(WebCore::RenderLayer::enclosingFilterRepaintLayer):
(WebCore::RenderLayer::clippingRootForPainting):
LayoutTests: Fix repaint issue on paints into ancestor filtered layers
https://bugs.webkit.org/show_bug.cgi?id=120780
rdar://problem/14884148
Reviewed by Tim Horton.
Ref test for opacity change on a filtered layer which paints into its compositing ancestor.
* compositing/filters/opacity-change-on-filtered-paints-into-ancestor-expected.html: Added.
* compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
trunk/LayoutTests/compositing/filters/opacity-change-on-filtered-paints-into-ancestor-expected.html
trunk/LayoutTests/compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html
Diff
Modified: trunk/LayoutTests/ChangeLog (155130 => 155131)
--- trunk/LayoutTests/ChangeLog 2013-09-05 17:54:11 UTC (rev 155130)
+++ trunk/LayoutTests/ChangeLog 2013-09-05 17:56:58 UTC (rev 155131)
@@ -1,3 +1,16 @@
+2013-09-05 Simon Fraser simon.fra...@apple.com
+
+Fix repaint issue on paints into ancestor filtered layers
+https://bugs.webkit.org/show_bug.cgi?id=120780
+rdar://problem/14884148
+
+Reviewed by Tim Horton.
+
+Ref test for opacity change on a filtered layer which paints into its compositing ancestor.
+
+* compositing/filters/opacity-change-on-filtered-paints-into-ancestor-expected.html: Added.
+* compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html: Added.
+
2013-09-05 Danilo Cesar Lemes de Paula danilo.ce...@collabora.co.uk
[GTK] improving tests expectations related to trackmenu
Added: trunk/LayoutTests/compositing/filters/opacity-change-on-filtered-paints-into-ancestor-expected.html (0 => 155131)
--- trunk/LayoutTests/compositing/filters/opacity-change-on-filtered-paints-into-ancestor-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/filters/opacity-change-on-filtered-paints-into-ancestor-expected.html 2013-09-05 17:56:58 UTC (rev 155131)
@@ -0,0 +1,37 @@
+!DOCTYPE html
+
+html
+head
+style
+.container {
+overflow: hidden;
+position: absolute;
+z-index: 1;
+border: 1px solid black;
+}
+
+.composited {
+ -webkit-transform: translateZ(0);
+}
+
+.box {
+ width: 100px;
+ height: 100px;
+ margin: 10px;
+ background-color: blue;
+}
+
+.filtered {
+-webkit-filter: blur(2px);
+opacity: 0.8;
+}
+/style
+/head
+body
+
+div class=container
+div class=filtered box/div
+div class=composited box/div
+/div
+/body
+/html
Added: trunk/LayoutTests/compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html (0 => 155131)
--- trunk/LayoutTests/compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html (rev 0)
+++ trunk/LayoutTests/compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html 2013-09-05 17:56:58 UTC (rev 155131)
@@ -0,0 +1,54 @@
+!DOCTYPE html
+
+html
+head
+style
+.container {
+overflow: hidden;
+position: absolute;
+z-index: 1;
+border: 1px solid black;
+}
+
+.composited {
+ -webkit-transform: translateZ(0);
+}
+
+.box {
+ width: 100px;
+ height: 100px;
+ margin: 10px;
+ background-color: blue;
+}
+
+.filtered {
+-webkit-filter: blur(2px);
+opacity: 0.2;
+}
+
+.filtered.changed {
+opacity: 0.8;
+}
+
[webkit-changes] [155132] trunk
Title: [155132] trunk
Revision 155132
Author joep...@webkit.org
Date 2013-09-05 11:00:53 -0700 (Thu, 05 Sep 2013)
Log Message
Web Inspector: Breakpoint Actions
https://bugs.webkit.org/show_bug.cgi?id=120576
Reviewed by Timothy Hatcher.
Source/WebCore:
Tests: inspector-protocol/debugger/setBreakpoint-actions.html
inspector-protocol/debugger/setBreakpoint-options-exception.html
* inspector/ScriptBreakpoint.h:
(WebCore::ScriptBreakpointAction::ScriptBreakpointAction):
(WebCore::ScriptBreakpoint::ScriptBreakpoint):
Struct for a breakpoint action. Type and string of data.
* bindings/js/ScriptDebugServer.h:
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::evaluateBreakpointAction):
(WebCore::ScriptDebugServer::evaluateBreakpointActions):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::pauseIfNeeded):
When a breakpoint is triggered evaluate each of its breakpoint
actions in order. If there are exceptions, log them.
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::buildObjectForBreakpointCookie):
(WebCore::InspectorDebuggerAgent::didParseSource):
Save and restore breakpoint actions where needed.
(WebCore::breakpointActionTypeForString):
(WebCore::breakpointActionsFromProtocol):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
Parse optional breakpoint actions from the protocol into
ScriptBreakpointAction objects.
LayoutTests:
* inspector-protocol/debugger/resources/breakpoint.js:
* inspector-protocol/debugger/setBreakpoint-actions-expected.txt: Added.
* inspector-protocol/debugger/setBreakpoint-actions.html: Added.
* inspector-protocol/debugger/setBreakpoint-options-exception-expected.txt: Added.
* inspector-protocol/debugger/setBreakpoint-options-exception.html: Added.
* inspector-protocol/resources/console-helper.js: Added.
(ConsoleHelper.simplifiedConsoleMessage):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector-protocol/debugger/resources/breakpoint.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp
trunk/Source/WebCore/bindings/js/ScriptDebugServer.h
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
trunk/Source/WebCore/inspector/ScriptBreakpoint.h
Added Paths
trunk/LayoutTests/inspector-protocol/debugger/setBreakpoint-actions-expected.txt
trunk/LayoutTests/inspector-protocol/debugger/setBreakpoint-actions.html
trunk/LayoutTests/inspector-protocol/debugger/setBreakpoint-options-exception-expected.txt
trunk/LayoutTests/inspector-protocol/debugger/setBreakpoint-options-exception.html
trunk/LayoutTests/inspector-protocol/resources/
trunk/LayoutTests/inspector-protocol/resources/console-helper.js
Diff
Modified: trunk/LayoutTests/ChangeLog (155131 => 155132)
--- trunk/LayoutTests/ChangeLog 2013-09-05 17:56:58 UTC (rev 155131)
+++ trunk/LayoutTests/ChangeLog 2013-09-05 18:00:53 UTC (rev 155132)
@@ -1,3 +1,18 @@
+2013-09-05 Joseph Pecoraro pecor...@apple.com
+
+Web Inspector: Breakpoint Actions
+https://bugs.webkit.org/show_bug.cgi?id=120576
+
+Reviewed by Timothy Hatcher.
+
+* inspector-protocol/debugger/resources/breakpoint.js:
+* inspector-protocol/debugger/setBreakpoint-actions-expected.txt: Added.
+* inspector-protocol/debugger/setBreakpoint-actions.html: Added.
+* inspector-protocol/debugger/setBreakpoint-options-exception-expected.txt: Added.
+* inspector-protocol/debugger/setBreakpoint-options-exception.html: Added.
+* inspector-protocol/resources/console-helper.js: Added.
+(ConsoleHelper.simplifiedConsoleMessage):
+
2013-09-05 Simon Fraser simon.fra...@apple.com
Fix repaint issue on paints into ancestor filtered layers
Modified: trunk/LayoutTests/inspector-protocol/debugger/resources/breakpoint.js (155131 => 155132)
--- trunk/LayoutTests/inspector-protocol/debugger/resources/breakpoint.js 2013-09-05 17:56:58 UTC (rev 155131)
+++ trunk/LayoutTests/inspector-protocol/debugger/resources/breakpoint.js 2013-09-05 18:00:53 UTC (rev 155132)
@@ -12,3 +12,8 @@
{
log(inside breakpointAutomaticallyContinue);
}
+
+function breakpointActions(a, b)
+{
+log(inside breakpointActions a:( + a + ) b:( + b + ));
+}
Added: trunk/LayoutTests/inspector-protocol/debugger/setBreakpoint-actions-expected.txt (0 => 155132)
--- trunk/LayoutTests/inspector-protocol/debugger/setBreakpoint-actions-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector-protocol/debugger/setBreakpoint-actions-expected.txt 2013-09-05 18:00:53 UTC (rev 155132)
@@ -0,0 +1,24 @@
+CONSOLE MESSAGE: log-action-before
+CONSOLE MESSAGE: line 1: eval-action
+CONSOLE MESSAGE: log-action-after
+CONSOLE MESSAGE: log-action-before
+CONSOLE MESSAGE: line 1: eval-action
+CONSOLE MESSAGE: log-action-after
[webkit-changes] [155134] trunk/Source/WebInspectorUI
Title: [155134] trunk/Source/WebInspectorUI Revision 155134 Author joep...@webkit.org Date 2013-09-05 11:01:00 -0700 (Thu, 05 Sep 2013) Log Message Web Inspector: Breakpoint Actions https://bugs.webkit.org/show_bug.cgi?id=120576 Reviewed by Timothy Hatcher. Give the CodeMirror editor for _javascript_ Breakpoint Actions JS Runtime completions (like window, document, etc.). The logic was inside of _javascript_LogViewController but was already entirely independent. Factor it out into its own class and plug it into CodeMirrorCompletionController as a CompletionsProvider. Because the class hooks into a global event to reset some state, make it a singleton, so new instances are not leaked. * UserInterface/Main.html: * UserInterface/Main.js: (WebInspector.loaded): * UserInterface/RuntimeManager.js: Added. (WebInspector.RuntimeManager): (WebInspector.RuntimeManager.prototype.evalCallback): (WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow): Move eval in window to new RuntimeManager. A slightly cleaner place to this since it is used both by the console and JS completions provider. * UserInterface/CodeMirrorCompletionController.js: (WebInspector.CodeMirrorCompletionController): (WebInspector.CodeMirrorCompletionController.prototype.setExtendedCompletionProvider): (WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition): Allow a completions provider plugin to completions controller. If one is available, this supercedes the delegate extend completions path. * UserInterface/BreakpointActionView.js: * UserInterface/ConsolePrompt.js: (WebInspector.ConsolePrompt): Use the new JS completions provider to get runtime JS completions. NOTE: ConsolePrompt still needs the delegate path for SQL completions. * UserInterface/_javascript_LogViewController.js: (WebInspector._javascript_LogViewController): (WebInspector._javascript_LogViewController.prototype.consolePromptTextCommitted): * UserInterface/_javascript_RuntimeCompletionProvider.js: Added. (WebInspector._javascript_RuntimeCompletionProvider): (get WebInspector._javascript_RuntimeCompletionProvider.prototype.): (get WebInspector._javascript_RuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded): Move the JS completions code to a new class. No changes needed. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/BreakpointActionView.js trunk/Source/WebInspectorUI/UserInterface/CodeMirrorCompletionController.js trunk/Source/WebInspectorUI/UserInterface/ConsolePrompt.js trunk/Source/WebInspectorUI/UserInterface/_javascript_LogViewController.js trunk/Source/WebInspectorUI/UserInterface/Main.html trunk/Source/WebInspectorUI/UserInterface/Main.js Added Paths trunk/Source/WebInspectorUI/UserInterface/_javascript_RuntimeCompletionProvider.js trunk/Source/WebInspectorUI/UserInterface/RuntimeManager.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (155133 => 155134) --- trunk/Source/WebInspectorUI/ChangeLog 2013-09-05 18:00:56 UTC (rev 155133) +++ trunk/Source/WebInspectorUI/ChangeLog 2013-09-05 18:01:00 UTC (rev 155134) @@ -5,6 +5,55 @@ Reviewed by Timothy Hatcher. +Give the CodeMirror editor for _javascript_ Breakpoint Actions JS Runtime +completions (like window, document, etc.). + +The logic was inside of _javascript_LogViewController but was already +entirely independent. Factor it out into its own class and plug it into +CodeMirrorCompletionController as a CompletionsProvider. + +Because the class hooks into a global event to reset some state, make +it a singleton, so new instances are not leaked. + +* UserInterface/Main.html: +* UserInterface/Main.js: +(WebInspector.loaded): +* UserInterface/RuntimeManager.js: Added. +(WebInspector.RuntimeManager): +(WebInspector.RuntimeManager.prototype.evalCallback): +(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow): +Move eval in window to new RuntimeManager. A slightly cleaner place to this +since it is used both by the console and JS completions provider. + +* UserInterface/CodeMirrorCompletionController.js: +(WebInspector.CodeMirrorCompletionController): +(WebInspector.CodeMirrorCompletionController.prototype.setExtendedCompletionProvider): +(WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition): +Allow a completions provider plugin to completions controller. If one +is available, this supercedes the delegate extend completions path. + +* UserInterface/BreakpointActionView.js: +* UserInterface/ConsolePrompt.js: +(WebInspector.ConsolePrompt): +Use the new JS completions provider to get runtime JS completions. +NOTE: ConsolePrompt still needs the delegate path for SQL completions. + +*
[webkit-changes] [155113] trunk/Source/WebCore
Title: [155113] trunk/Source/WebCore
Revision 155113
Author commit-qu...@webkit.org
Date 2013-09-05 07:15:46 -0700 (Thu, 05 Sep 2013)
Log Message
[GTK] Assertion fails when the mouse pointer is styled with a custom cursor
https://bugs.webkit.org/show_bug.cgi?id=118905
Patch by Enrique Ocaña González eoca...@igalia.com on 2013-09-05
Reviewed by Philippe Normand.
Checked that the custom cursor image and its pixbuf is valid and create a null
cursor otherwise.
* platform/gtk/CursorGtk.cpp:
(WebCore::createCustomCursor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/CursorGtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155112 => 155113)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 13:25:50 UTC (rev 155112)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 14:15:46 UTC (rev 155113)
@@ -1,3 +1,16 @@
+2013-09-05 Enrique Ocaña González eoca...@igalia.com
+
+[GTK] Assertion fails when the mouse pointer is styled with a custom cursor
+https://bugs.webkit.org/show_bug.cgi?id=118905
+
+Reviewed by Philippe Normand.
+
+Checked that the custom cursor image and its pixbuf is valid and create a null
+cursor otherwise.
+
+* platform/gtk/CursorGtk.cpp:
+(WebCore::createCustomCursor):
+
2013-09-05 Praveen R Jadhav pravee...@samsung.com
Precision updates in WebAudio.
Modified: trunk/Source/WebCore/platform/gtk/CursorGtk.cpp (155112 => 155113)
--- trunk/Source/WebCore/platform/gtk/CursorGtk.cpp 2013-09-05 13:25:50 UTC (rev 155112)
+++ trunk/Source/WebCore/platform/gtk/CursorGtk.cpp 2013-09-05 14:15:46 UTC (rev 155113)
@@ -60,8 +60,12 @@
static GRefPtrGdkCursor createCustomCursor(Image* image, const IntPoint hotSpot)
{
+GRefPtrGdkPixbuf pixbuf = adoptGRef(image-getGdkPixbuf());
+
+if (!image-nativeImageForCurrentFrame() || !pixbuf)
+return 0;
+
IntPoint effectiveHotSpot = determineHotSpot(image, hotSpot);
-GRefPtrGdkPixbuf pixbuf = adoptGRef(image-getGdkPixbuf());
return adoptGRef(gdk_cursor_new_from_pixbuf(gdk_display_get_default(), pixbuf.get(), effectiveHotSpot.x(), effectiveHotSpot.y()));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155169] trunk/Source/WebInspectorUI
Title: [155169] trunk/Source/WebInspectorUI
Revision 155169
Author commit-qu...@webkit.org
Date 2013-09-05 20:33:57 -0700 (Thu, 05 Sep 2013)
Log Message
Web Inspector: Breakpoint Action JS Editor has line wrapping issues with long no-space lines
https://bugs.webkit.org/show_bug.cgi?id=120822
Patch by Joseph Pecoraro pecor...@apple.com on 2013-09-05
Reviewed by Timothy Hatcher.
* UserInterface/BreakpointActionView.css:
(.breakpoint-action-eval-editor .CodeMirror):
(.breakpoint-action-eval-editor .CodeMirror-scroll):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/BreakpointActionView.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (155168 => 155169)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-09-06 01:34:05 UTC (rev 155168)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-09-06 03:33:57 UTC (rev 155169)
@@ -1,5 +1,16 @@
2013-09-05 Joseph Pecoraro pecor...@apple.com
+Web Inspector: Breakpoint Action JS Editor has line wrapping issues with long no-space lines
+https://bugs.webkit.org/show_bug.cgi?id=120822
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/BreakpointActionView.css:
+(.breakpoint-action-eval-editor .CodeMirror):
+(.breakpoint-action-eval-editor .CodeMirror-scroll):
+
+2013-09-05 Joseph Pecoraro pecor...@apple.com
+
Web Inspector: Edit Breakpoint popover sometimes appears misplaced in top left
https://bugs.webkit.org/show_bug.cgi?id=120804
Modified: trunk/Source/WebInspectorUI/UserInterface/BreakpointActionView.css (155168 => 155169)
--- trunk/Source/WebInspectorUI/UserInterface/BreakpointActionView.css 2013-09-06 01:34:05 UTC (rev 155168)
+++ trunk/Source/WebInspectorUI/UserInterface/BreakpointActionView.css 2013-09-06 03:33:57 UTC (rev 155169)
@@ -75,11 +75,11 @@
}
.breakpoint-action-eval-editor .CodeMirror {
-width: 100%;
+width: 336px; /* NOTE: Fixed value, manually tuned to .edit-breakpoint-popover-content.wide width */
height: auto;
}
.breakpoint-action-eval-editor .CodeMirror-scroll {
-width: 100%;
+width: 336px; /* NOTE: Fixed value, manually tuned to .edit-breakpoint-popover-content.wide width */
overflow: hidden;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155171] trunk/Source/WTF
Title: [155171] trunk/Source/WTF
Revision 155171
Author m...@apple.com
Date 2013-09-05 20:50:08 -0700 (Thu, 05 Sep 2013)
Log Message
INSTALL_PATH_PREFIX is used even when not installing
https://bugs.webkit.org/show_bug.cgi?id=120810
Reviewed by Andy Estes.
* Configurations/CopyWTFHeaders.xcconfig: Removed INSTALL_PATH_PREFIX from
the definition of PRIVATE_HEADERS_FOLDER_PATH. Also removed the leading
slash, because the Xcode definition of this build setting is relative.
* WTF.xcodeproj/project.pbxproj: Prepend INSTALL_PATH_PREFIX here when installing.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Configurations/CopyWTFHeaders.xcconfig
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WTF/ChangeLog (155170 => 155171)
--- trunk/Source/WTF/ChangeLog 2013-09-06 03:43:14 UTC (rev 155170)
+++ trunk/Source/WTF/ChangeLog 2013-09-06 03:50:08 UTC (rev 155171)
@@ -1,3 +1,15 @@
+2013-09-05 Dan Bernstein m...@apple.com
+
+INSTALL_PATH_PREFIX is used even when not installing
+https://bugs.webkit.org/show_bug.cgi?id=120810
+
+Reviewed by Andy Estes.
+
+* Configurations/CopyWTFHeaders.xcconfig: Removed INSTALL_PATH_PREFIX from
+the definition of PRIVATE_HEADERS_FOLDER_PATH. Also removed the leading
+slash, because the Xcode definition of this build setting is relative.
+* WTF.xcodeproj/project.pbxproj: Prepend INSTALL_PATH_PREFIX here when installing.
+
2013-09-05 Anders Carlsson ander...@apple.com
Fix build with older versions of clang from Xcode.
Modified: trunk/Source/WTF/Configurations/CopyWTFHeaders.xcconfig (155170 => 155171)
--- trunk/Source/WTF/Configurations/CopyWTFHeaders.xcconfig 2013-09-06 03:43:14 UTC (rev 155170)
+++ trunk/Source/WTF/Configurations/CopyWTFHeaders.xcconfig 2013-09-06 03:50:08 UTC (rev 155171)
@@ -21,5 +21,5 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-PRIVATE_HEADERS_FOLDER_PATH = $(INSTALL_PATH_PREFIX)/usr/local/include/wtf;
+PRIVATE_HEADERS_FOLDER_PATH = usr/local/include/wtf;
INSTALLHDRS_SCRIPT_PHASE = YES;
Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (155170 => 155171)
--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2013-09-06 03:43:14 UTC (rev 155170)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2013-09-06 03:50:08 UTC (rev 155171)
@@ -1171,7 +1171,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = if [[ \${DEPLOYMENT_LOCATION}\ == \NO\ ]]; then\nPRIVATE_HEADERS_PATH=\${TARGET_BUILD_DIR%%/}${PRIVATE_HEADERS_FOLDER_PATH}\\nelse\nPRIVATE_HEADERS_PATH=\${DSTROOT%%/}${PRIVATE_HEADERS_FOLDER_PATH}\\nfi;\n\nmkdir -p \${PRIVATE_HEADERS_PATH}\\nrsync -av --no-owner --no-group --prune-empty-dirs --exclude \.svn\ --exclude \usr\ --exclude \DerivedSources\ --include \*/\ --include \*.h\ --exclude \*\ \${SRCROOT}/wtf/\ \${PRIVATE_HEADERS_PATH}\\n\n;
+ shellScript = if [[ \${DEPLOYMENT_LOCATION}\ == \NO\ ]]; then\nPRIVATE_HEADERS_PATH=\${TARGET_BUILD_DIR%/}/${PRIVATE_HEADERS_FOLDER_PATH}\\nelse\nPRIVATE_HEADERS_PATH=\${DSTROOT}${INSTALL_PATH_PREFIX%/}/${PRIVATE_HEADERS_FOLDER_PATH}\\nfi;\n\nmkdir -p \${PRIVATE_HEADERS_PATH}\\nrsync -av --no-owner --no-group --prune-empty-dirs --exclude \.svn\ --exclude \usr\ --exclude \DerivedSources\ --include \*/\ --include \*.h\ --exclude \*\ \${SRCROOT}/wtf/\ \${PRIVATE_HEADERS_PATH}\\n;
};
/* End PBXShellScriptBuildPhase section */
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155172] trunk/Source/ThirdParty/ANGLE
Title: [155172] trunk/Source/ThirdParty/ANGLE Revision 155172 Author m...@apple.com Date 2013-09-05 20:50:53 -0700 (Thu, 05 Sep 2013) Log Message INSTALL_PATH_PREFIX is used even when not installing https://bugs.webkit.org/show_bug.cgi?id=120818 Reviewed by Darin Adler. * Configurations/ANGLE.xcconfig: Changed the definition of PRIVATE_HEADERS_FOLDER_PATH to include INSTALL_PATH_PREFIX only when installing. Modified Paths trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig Diff Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (155171 => 155172) --- trunk/Source/ThirdParty/ANGLE/ChangeLog 2013-09-06 03:50:08 UTC (rev 155171) +++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2013-09-06 03:50:53 UTC (rev 155172) @@ -1,3 +1,13 @@ +2013-09-05 Dan Bernstein m...@apple.com + +INSTALL_PATH_PREFIX is used even when not installing +https://bugs.webkit.org/show_bug.cgi?id=120818 + +Reviewed by Darin Adler. + +* Configurations/ANGLE.xcconfig: Changed the definition of PRIVATE_HEADERS_FOLDER_PATH +to include INSTALL_PATH_PREFIX only when installing. + 2013-08-17 David Kilzer ddkil...@apple.com ANGLE fails to build with trunk clang: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register] Modified: trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig (155171 => 155172) --- trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig 2013-09-06 03:50:08 UTC (rev 155171) +++ trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig 2013-09-06 03:50:53 UTC (rev 155172) @@ -2,4 +2,6 @@ HEADER_SEARCH_PATHS = include src; INSTALL_PATH_ACTUAL = /usr/local/lib; -PUBLIC_HEADERS_FOLDER_PATH = $(INSTALL_PATH_PREFIX)/usr/local/include/ANGLE; +PUBLIC_HEADERS_FOLDER_PATH = $(PUBLIC_HEADERS_FOLDER_PATH_$(DEPLOYMENT_LOCATION)); +PUBLIC_HEADERS_FOLDER_PATH_NO = /usr/local/include/ANGLE; +PUBLIC_HEADERS_FOLDER_PATH_YES = $(INSTALL_PATH_PREFIX)/usr/local/include/ANGLE; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155118] trunk/Tools
Title: [155118] trunk/Tools
Revision 155118
Author o...@webkit.org
Date 2013-09-05 08:11:58 -0700 (Thu, 05 Sep 2013)
Log Message
Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
https://bugs.webkit.org/show_bug.cgi?id=120759
Reviewed by Filip Pizlo.
* Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy.
* Scripts/run-_javascript_core-tests: Enable run-fast-jsc tests everywhere, except Windows.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-fast-jsc
trunk/Tools/Scripts/run-_javascript_core-tests
Diff
Modified: trunk/Tools/ChangeLog (155117 => 155118)
--- trunk/Tools/ChangeLog 2013-09-05 15:01:12 UTC (rev 155117)
+++ trunk/Tools/ChangeLog 2013-09-05 15:11:58 UTC (rev 155118)
@@ -1,3 +1,13 @@
+2013-09-05 Csaba Osztrogonác o...@webkit.org
+
+Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
+https://bugs.webkit.org/show_bug.cgi?id=120759
+
+Reviewed by Filip Pizlo.
+
+* Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy.
+* Scripts/run-_javascript_core-tests: Enable run-fast-jsc tests everywhere, except Windows.
+
2013-09-05 Filip Pizlo fpi...@apple.com
Unreviewed, green the Mac bots by boosting the timeout on JSC tests. One of the
Modified: trunk/Tools/Scripts/run-fast-jsc (155117 => 155118)
--- trunk/Tools/Scripts/run-fast-jsc 2013-09-05 15:01:12 UTC (rev 155117)
+++ trunk/Tools/Scripts/run-fast-jsc 2013-09-05 15:11:58 UTC (rev 155118)
@@ -32,7 +32,7 @@
cmdName=`basename $0`
-function usage()
+usage()
{
echo usage: $cmdName [[--jsc | -j] path-to-jsc] [[--results-dir | -r] results-path]
echo [[--test-root | -t] test-root-path] [[--test-list | -l] test-list-file]
@@ -108,8 +108,12 @@
if [ -f $expectedOut -a -f $jsTest ]
then
-echo Testing $test ... \c
-let numTestsRun=$numTestsRun+1
+if [ `uname` = 'Darwin' ]; then
+echo Testing $test ... \c
+else
+echo -n Testing $test ...
+fi
+numTestsRun=$(($numTestsRun+1))
$jscCmd $preScript $jsTest $postScript 2$actualErr $actualOut
JSC_RES=$?
@@ -138,14 +142,14 @@
if [ $testPassed -eq 1 ]
then
echo $test $passList
-let numPassed=$numPassed+1
+numPassed=$(($numPassed+1))
else
echo $test $failList
-let numFailed=$numFailed+1
+numFailed=$(($numFailed+1))
if [ $testCrashed -eq 1 ]
then
echo $test $crashList
-let numCrashed=$numCrashed+1
+numCrashed=$(($numCrashed+1))
fi
fi
fi
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (155117 => 155118)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 15:01:12 UTC (rev 155117)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 15:11:58 UTC (rev 155118)
@@ -191,7 +191,11 @@
chdirWebKit();
my $fastJSResultsDir = $productDir . /fast-jsc-results;
-my $runFastJS = isAppleMacWebKit();
+
+# FIXME: run-fast-jsc tests doesn't work properly on Windows
+# https://bugs.webkit.org/show_bug.cgi?id=120765
+my $runFastJS = !isAppleWinWebKit();
+
if ($runFastJS) {
# Run the fast/js tests.
my @fastJSDriverCmd = (/bin/sh, Tools/Scripts/run-fast-jsc, -j, jscPath($productDir), -r, $fastJSResultsDir, -t, LayoutTests);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155119] trunk/Source/WebCore
Title: [155119] trunk/Source/WebCore
Revision 155119
Author ander...@apple.com
Date 2013-09-05 08:15:59 -0700 (Thu, 05 Sep 2013)
Log Message
Animations in an AnimationList are never null
https://bugs.webkit.org/show_bug.cgi?id=120720
Reviewed by Andreas Kling.
Change AnimationList::operator[] to return an Animation and fix up related code to also take references.
* css/CSSComputedStyleDeclaration.cpp:
* css/DeprecatedStyleBuilder.cpp:
* page/animation/CompositeAnimation.cpp:
* page/animation/KeyframeAnimation.cpp:
* platform/animation/Animation.h:
* platform/animation/AnimationList.cpp:
* platform/animation/AnimationList.h:
* rendering/RenderLayerBacking.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp
trunk/Source/WebCore/page/animation/CompositeAnimation.cpp
trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp
trunk/Source/WebCore/platform/animation/Animation.h
trunk/Source/WebCore/platform/animation/AnimationList.cpp
trunk/Source/WebCore/platform/animation/AnimationList.h
trunk/Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155118 => 155119)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 15:11:58 UTC (rev 155118)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 15:15:59 UTC (rev 155119)
@@ -1,3 +1,21 @@
+2013-09-04 Anders Carlsson ander...@apple.com
+
+Animations in an AnimationList are never null
+https://bugs.webkit.org/show_bug.cgi?id=120720
+
+Reviewed by Andreas Kling.
+
+Change AnimationList::operator[] to return an Animation and fix up related code to also take references.
+
+* css/CSSComputedStyleDeclaration.cpp:
+* css/DeprecatedStyleBuilder.cpp:
+* page/animation/CompositeAnimation.cpp:
+* page/animation/KeyframeAnimation.cpp:
+* platform/animation/Animation.h:
+* platform/animation/AnimationList.cpp:
+* platform/animation/AnimationList.h:
+* rendering/RenderLayerBacking.cpp:
+
2013-09-05 Antti Koivisto an...@apple.com
Call createTextRenderersForSiblingsAfterAttachIfNeeded only for the attach root
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (155118 => 155119)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2013-09-05 15:11:58 UTC (rev 155118)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2013-09-05 15:15:59 UTC (rev 155119)
@@ -1165,17 +1165,18 @@
return list.release();
}
-static PassRefPtrCSSValue createTransitionPropertyValue(const Animation* animation)
+static PassRefPtrCSSValue createTransitionPropertyValue(const Animation animation)
{
RefPtrCSSValue propertyValue;
-if (animation-animationMode() == Animation::AnimateNone)
+if (animation.animationMode() == Animation::AnimateNone)
propertyValue = cssValuePool().createIdentifierValue(CSSValueNone);
-else if (animation-animationMode() == Animation::AnimateAll)
+else if (animation.animationMode() == Animation::AnimateAll)
propertyValue = cssValuePool().createIdentifierValue(CSSValueAll);
else
-propertyValue = cssValuePool().createValue(getPropertyNameString(animation-property()), CSSPrimitiveValue::CSS_STRING);
+propertyValue = cssValuePool().createValue(getPropertyNameString(animation.property()), CSSPrimitiveValue::CSS_STRING);
return propertyValue.release();
}
+
static PassRefPtrCSSValue getTransitionPropertyValue(const AnimationList* animList)
{
RefPtrCSSValueList list = CSSValueList::createCommaSeparated();
@@ -1192,7 +1193,7 @@
RefPtrCSSValueList list = CSSValueList::createCommaSeparated();
if (animList) {
for (size_t i = 0; i animList-size(); ++i)
-list-append(cssValuePool().createValue(animList-animation(i)-delay(), CSSPrimitiveValue::CSS_S));
+list-append(cssValuePool().createValue(animList-animation(i).delay(), CSSPrimitiveValue::CSS_S));
} else {
// Note that initialAnimationDelay() is used for both transitions and animations
list-append(cssValuePool().createValue(Animation::initialAnimationDelay(), CSSPrimitiveValue::CSS_S));
@@ -1205,7 +1206,7 @@
RefPtrCSSValueList list = CSSValueList::createCommaSeparated();
if (animList) {
for (size_t i = 0; i animList-size(); ++i)
-list-append(cssValuePool().createValue(animList-animation(i)-duration(), CSSPrimitiveValue::CSS_S));
+list-append(cssValuePool().createValue(animList-animation(i).duration(), CSSPrimitiveValue::CSS_S));
} else {
// Note that initialAnimationDuration() is used for both transitions and animations
list-append(cssValuePool().createValue(Animation::initialAnimationDuration(), CSSPrimitiveValue::CSS_S));
[webkit-changes] [155120] trunk/Source/WebCore
Title: [155120] trunk/Source/WebCore
Revision 155120
Author akl...@apple.com
Date 2013-09-05 08:17:33 -0700 (Thu, 05 Sep 2013)
Log Message
Reverting Cached Page and Frame don't need to be ref-counted.
https://webkit.org/b/120758
This didn't work so well on Qt bots. Will have to take bigger steps
here instead of iterating.
* history/CachedFrame.h:
(WebCore::CachedFrame::create):
* history/CachedPage.cpp:
(WebCore::CachedPage::create):
* history/CachedPage.h:
* history/HistoryItem.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::transitionToCommitted):
* loader/FrameLoader.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/CachedFrame.h
trunk/Source/WebCore/history/CachedPage.cpp
trunk/Source/WebCore/history/CachedPage.h
trunk/Source/WebCore/history/HistoryItem.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (155119 => 155120)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 15:15:59 UTC (rev 155119)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 15:17:33 UTC (rev 155120)
@@ -1,3 +1,22 @@
+2013-09-05 Andreas Kling akl...@apple.com
+
+Reverting Cached Page and Frame don't need to be ref-counted.
+https://webkit.org/b/120758
+
+This didn't work so well on Qt bots. Will have to take bigger steps
+here instead of iterating.
+
+* history/CachedFrame.h:
+(WebCore::CachedFrame::create):
+* history/CachedPage.cpp:
+(WebCore::CachedPage::create):
+* history/CachedPage.h:
+* history/HistoryItem.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::commitProvisionalLoad):
+(WebCore::FrameLoader::transitionToCommitted):
+* loader/FrameLoader.h:
+
2013-09-04 Anders Carlsson ander...@apple.com
Animations in an AnimationList are never null
Modified: trunk/Source/WebCore/history/CachedFrame.h (155119 => 155120)
--- trunk/Source/WebCore/history/CachedFrame.h 2013-09-05 15:15:59 UTC (rev 155119)
+++ trunk/Source/WebCore/history/CachedFrame.h 2013-09-05 15:17:33 UTC (rev 155120)
@@ -30,6 +30,7 @@
#include KURL.h
#include ScriptCachedFrameData.h
#include wtf/PassOwnPtr.h
+#include wtf/RefCounted.h
#include wtf/RefPtr.h
namespace WebCore {
@@ -66,12 +67,12 @@
bool m_isComposited;
#endif
-VectorOwnPtrCachedFrame m_childFrames;
+VectorRefPtrCachedFrame m_childFrames;
};
-class CachedFrame : private CachedFrameBase {
+class CachedFrame : public RefCountedCachedFrame, private CachedFrameBase {
public:
-static PassOwnPtrCachedFrame create(Frame frame) { return adoptPtr(new CachedFrame(frame)); }
+static PassRefPtrCachedFrame create(Frame frame) { return adoptRef(new CachedFrame(frame)); }
void open();
void clear();
Modified: trunk/Source/WebCore/history/CachedPage.cpp (155119 => 155120)
--- trunk/Source/WebCore/history/CachedPage.cpp 2013-09-05 15:15:59 UTC (rev 155119)
+++ trunk/Source/WebCore/history/CachedPage.cpp 2013-09-05 15:17:33 UTC (rev 155120)
@@ -45,9 +45,9 @@
DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, cachedPageCounter, (CachedPage));
-PassOwnPtrCachedPage CachedPage::create(Page page)
+PassRefPtrCachedPage CachedPage::create(Page page)
{
-return adoptPtr(new CachedPage(page));
+return adoptRef(new CachedPage(page));
}
CachedPage::CachedPage(Page page)
Modified: trunk/Source/WebCore/history/CachedPage.h (155119 => 155120)
--- trunk/Source/WebCore/history/CachedPage.h 2013-09-05 15:15:59 UTC (rev 155119)
+++ trunk/Source/WebCore/history/CachedPage.h 2013-09-05 15:17:33 UTC (rev 155120)
@@ -27,6 +27,7 @@
#define CachedPage_h
#include CachedFrame.h
+#include wtf/RefCounted.h
namespace WebCore {
@@ -34,9 +35,9 @@
class DocumentLoader;
class Page;
-class CachedPage {
+class CachedPage : public RefCountedCachedPage {
public:
-static PassOwnPtrCachedPage create(Page);
+static PassRefPtrCachedPage create(Page);
~CachedPage();
void restore(Page);
@@ -66,7 +67,7 @@
double m_timeStamp;
double m_expirationTime;
-OwnPtrCachedFrame m_cachedMainFrame;
+RefPtrCachedFrame m_cachedMainFrame;
bool m_needStyleRecalcForVisitedLinks;
bool m_needsFullStyleRecalc;
bool m_needsCaptionPreferencesChanged;
Modified: trunk/Source/WebCore/history/HistoryItem.h (155119 => 155120)
--- trunk/Source/WebCore/history/HistoryItem.h 2013-09-05 15:15:59 UTC (rev 155119)
+++ trunk/Source/WebCore/history/HistoryItem.h 2013-09-05 15:17:33 UTC (rev 155120)
@@ -286,7 +286,7 @@
// PageCache controls these fields.
HistoryItem* m_next;
HistoryItem* m_prev;
-OwnPtrCachedPage m_cachedPage;
+RefPtrCachedPage m_cachedPage;
#if PLATFORM(MAC)
RetainPtrid m_viewState;
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (155119 => 155120)
---
[webkit-changes] [155174] trunk/Source
Title: [155174] trunk/Source
Revision 155174
Author akl...@apple.com
Date 2013-09-05 21:49:52 -0700 (Thu, 05 Sep 2013)
Log Message
FrameView: Constructor should take Frame.
https://webkit.org/b/120824
Reviewed by Anders Carlsson.
* WebCore.exp.in:
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::overlayPage):
* page/Frame.cpp:
(WebCore::Frame::createView):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::create):
* page/FrameView.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/inspector/InspectorOverlay.cpp
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/svg/graphics/SVGImage.cpp
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (155173 => 155174)
--- trunk/Source/WebCore/ChangeLog 2013-09-06 03:57:14 UTC (rev 155173)
+++ trunk/Source/WebCore/ChangeLog 2013-09-06 04:49:52 UTC (rev 155174)
@@ -1,3 +1,22 @@
+2013-09-05 Andreas Kling akl...@apple.com
+
+FrameView: Constructor should take Frame.
+https://webkit.org/b/120824
+
+Reviewed by Anders Carlsson.
+
+* WebCore.exp.in:
+* inspector/InspectorOverlay.cpp:
+(WebCore::InspectorOverlay::overlayPage):
+* page/Frame.cpp:
+(WebCore::Frame::createView):
+* page/FrameView.cpp:
+(WebCore::FrameView::FrameView):
+(WebCore::FrameView::create):
+* page/FrameView.h:
+* svg/graphics/SVGImage.cpp:
+(WebCore::SVGImage::dataChanged):
+
2013-09-05 Jinwoo Song jinwoo7.s...@samsung.com
Fix build warnings by unused parameter
Modified: trunk/Source/WebCore/WebCore.exp.in (155173 => 155174)
--- trunk/Source/WebCore/WebCore.exp.in 2013-09-06 03:57:14 UTC (rev 155173)
+++ trunk/Source/WebCore/WebCore.exp.in 2013-09-06 04:49:52 UTC (rev 155174)
@@ -1144,6 +1144,7 @@
__ZN7WebCore9FrameTree11appendChildEN3WTF10PassRefPtrINS_5FrameEEE
__ZN7WebCore9FrameTree7setNameERKN3WTF12AtomicStringE
__ZN7WebCore9FrameTree9clearNameEv
+__ZN7WebCore9FrameView6createERNS_5FrameE
__ZN7WebCore9FrameView11forceLayoutEb
__ZN7WebCore9FrameView12setMediaTypeERKN3WTF6StringE
__ZN7WebCore9FrameView13setNodeToDrawEPNS_4NodeE
@@ -1179,8 +1180,6 @@
__ZN7WebCore9FrameView37updateLayoutAndStyleIfNeededRecursiveEv
__ZN7WebCore9FrameView38scrollPositionChangedViaPlatformWidgetEv
__ZN7WebCore9FrameView39flushCompositingStateIncludingSubframesEv
-__ZN7WebCore9FrameView6createEPNS_5FrameE
-__ZN7WebCore9FrameView6createEPNS_5FrameERKNS_7IntSizeE
__ZN7WebCore9HTMLNames10listingTagE
__ZN7WebCore9HTMLNames11textareaTagE
__ZN7WebCore9HTMLNames12selectedAttrE
Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (155173 => 155174)
--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2013-09-06 03:57:14 UTC (rev 155173)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2013-09-06 04:49:52 UTC (rev 155174)
@@ -451,7 +451,7 @@
overlaySettings.setPluginsEnabled(false);
Frame frame = m_overlayPage-mainFrame();
-frame.setView(FrameView::create(frame));
+frame.setView(FrameView::create(frame));
frame.init();
FrameLoader loader = frame.loader();
frame.view()-setCanHaveScrollbars(false);
Modified: trunk/Source/WebCore/page/Frame.cpp (155173 => 155174)
--- trunk/Source/WebCore/page/Frame.cpp 2013-09-06 03:57:14 UTC (rev 155173)
+++ trunk/Source/WebCore/page/Frame.cpp 2013-09-06 04:49:52 UTC (rev 155174)
@@ -725,12 +725,12 @@
RefPtrFrameView frameView;
if (isMainFrame) {
-frameView = FrameView::create(this, viewportSize);
+frameView = FrameView::create(*this, viewportSize);
frameView-setFixedLayoutSize(fixedLayoutSize);
frameView-setFixedVisibleContentRect(fixedVisibleContentRect);
frameView-setUseFixedLayout(useFixedLayout);
} else
-frameView = FrameView::create(this);
+frameView = FrameView::create(*this);
frameView-setScrollbarModes(horizontalScrollbarMode, verticalScrollbarMode, horizontalLock, verticalLock);
Modified: trunk/Source/WebCore/page/FrameView.cpp (155173 => 155174)
--- trunk/Source/WebCore/page/FrameView.cpp 2013-09-06 03:57:14 UTC (rev 155173)
+++ trunk/Source/WebCore/page/FrameView.cpp 2013-09-06 04:49:52 UTC (rev 155174)
@@ -170,8 +170,8 @@
return Pagination::BottomToTopPaginated;
}
-FrameView::FrameView(Frame* frame)
-: m_frame(frame)
+FrameView::FrameView(Frame frame)
+: m_frame(frame)
, m_canHaveScrollbars(true)
, m_layoutTimer(this, FrameView::layoutTimerFired)
, m_layoutRoot(0)
@@ -214,14 +214,14 @@
}
}
-PassRefPtrFrameView FrameView::create(Frame* frame)
+PassRefPtrFrameView FrameView::create(Frame frame)
{
RefPtrFrameView view = adoptRef(new
[webkit-changes] [155175] trunk
Title: [155175] trunk
Revision 155175
Author commit-qu...@webkit.org
Date 2013-09-05 22:47:21 -0700 (Thu, 05 Sep 2013)
Log Message
[Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in the build when they are disabled
https://bugs.webkit.org/show_bug.cgi?id=117206
Patch by Brendan Long b.l...@cablelabs.com on 2013-09-05
Reviewed by Philippe Normand.
.:
* Source/widgetsapi.pri: Don't include DefaultFullScreenVideoHandler when it's disabled.
Source/WebCore:
No new tests because this just fixes a build warning.
* Target.pri: Don't include PlatformVideoWindow* files in the build when they are disabled.
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/widgetsapi.pri
Diff
Modified: trunk/ChangeLog (155174 => 155175)
--- trunk/ChangeLog 2013-09-06 04:49:52 UTC (rev 155174)
+++ trunk/ChangeLog 2013-09-06 05:47:21 UTC (rev 155175)
@@ -1,3 +1,12 @@
+2013-09-05 Brendan Long b.l...@cablelabs.com
+
+[Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in the build when they are disabled
+https://bugs.webkit.org/show_bug.cgi?id=117206
+
+Reviewed by Philippe Normand.
+
+* Source/widgetsapi.pri: Don't include DefaultFullScreenVideoHandler when it's disabled.
+
2013-09-05 Ryuan Choi ryuan.c...@samsung.com
[CMAKE] Add c++0x into CXX_FLAGS as a default
Modified: trunk/Source/WebCore/ChangeLog (155174 => 155175)
--- trunk/Source/WebCore/ChangeLog 2013-09-06 04:49:52 UTC (rev 155174)
+++ trunk/Source/WebCore/ChangeLog 2013-09-06 05:47:21 UTC (rev 155175)
@@ -1,3 +1,14 @@
+2013-09-05 Brendan Long b.l...@cablelabs.com
+
+[Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in the build when they are disabled
+https://bugs.webkit.org/show_bug.cgi?id=117206
+
+Reviewed by Philippe Normand.
+
+No new tests because this just fixes a build warning.
+
+* Target.pri: Don't include PlatformVideoWindow* files in the build when they are disabled.
+
2013-09-05 Andreas Kling akl...@apple.com
FrameView: Constructor should take Frame.
Modified: trunk/Source/WebCore/Target.pri (155174 => 155175)
--- trunk/Source/WebCore/Target.pri 2013-09-06 04:49:52 UTC (rev 155174)
+++ trunk/Source/WebCore/Target.pri 2013-09-06 05:47:21 UTC (rev 155175)
@@ -3326,8 +3326,6 @@
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h \
platform/graphics/gstreamer/VideoSinkGStreamer.h \
platform/graphics/gstreamer/WebKitWebSourceGStreamer.h \
-platform/graphics/gstreamer/PlatformVideoWindow.h \
-platform/graphics/gstreamer/PlatformVideoWindowPrivate.h \
platform/graphics/gstreamer/ImageGStreamer.h
SOURCES += \
platform/graphics/gstreamer/GStreamerGWorld.cpp \
@@ -3335,7 +,6 @@
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp \
platform/graphics/gstreamer/VideoSinkGStreamer.cpp \
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp \
-platform/graphics/gstreamer/PlatformVideoWindowQt.cpp \
platform/graphics/gstreamer/ImageGStreamerQt.cpp
enable?(VIDEO_TRACK) {
HEADERS += \
@@ -3347,6 +3344,13 @@
platform/graphics/gstreamer/TextCombinerGStreamer.cpp \
platform/graphics/gstreamer/TextSinkGStreamer.cpp
}
+use?(NATIVE_FULLSCREEN_VIDEO) {
+HEADERS += \
+platform/graphics/gstreamer/PlatformVideoWindow.h \
+platform/graphics/gstreamer/PlatformVideoWindowPrivate.h
+SOURCES += \
+platform/graphics/gstreamer/PlatformVideoWindowQt.cpp
+}
} else:use?(QT_MULTIMEDIA) {
HEADERS += \
Modified: trunk/Source/widgetsapi.pri (155174 => 155175)
--- trunk/Source/widgetsapi.pri 2013-09-06 04:49:52 UTC (rev 155174)
+++ trunk/Source/widgetsapi.pri 2013-09-06 05:47:21 UTC (rev 155175)
@@ -110,7 +110,6 @@
$$PWD/WebKit/qt/WidgetSupport/QtFallbackWebPopup.cpp \
$$PWD/WebKit/qt/WidgetSupport/QtWebComboBox.cpp \
$$PWD/WebKit/qt/WidgetSupport/QWebUndoCommand.cpp \
-$$PWD/WebKit/qt/WidgetSupport/DefaultFullScreenVideoHandler.cpp \
$$PWD/WebKit/qt/WidgetSupport/InitWebKitQt.cpp \
$$PWD/WebKit/qt/WidgetSupport/InspectorClientWebPage.cpp \
$$PWD/WebKit/qt/WidgetSupport/PageClientQt.cpp \
@@ -130,7 +129,6 @@
$$PWD/WebKit/qt/Api/qwebkitplatformplugin.h \
$$PWD/WebKit/qt/WidgetSupport/InitWebKitQt.h \
$$PWD/WebKit/qt/WidgetSupport/InspectorClientWebPage.h \
-$$PWD/WebKit/qt/WidgetSupport/DefaultFullScreenVideoHandler.h \
$$PWD/WebKit/qt/WidgetSupport/QtFallbackWebPopup.h \
$$PWD/WebKit/qt/WidgetSupport/QtWebComboBox.h \
$$PWD/WebKit/qt/WidgetSupport/QWebUndoCommand.h \
@@ -155,3 +153,7 @@
}
}
+use?(QT_MULTIMEDIA) {
+SOURCES +=
[webkit-changes] [155176] trunk/Source/WebCore
Title: [155176] trunk/Source/WebCore
Revision 155176
Author commit-qu...@webkit.org
Date 2013-09-05 22:48:40 -0700 (Thu, 05 Sep 2013)
Log Message
DRY out srcset related deviceScaleFactor calculations
https://bugs.webkit.org/show_bug.cgi?id=120791
Identical deviceScaleFactor calculations were performed in 3 different locations.
I've added that calculation as a method of Document.
Previous calculations are replaced by calls to this method.
Patch by Yoav Weiss y...@yoav.ws on 2013-09-05
Reviewed by Andreas Kling.
No new tests since this is a refactoring change. No functionality have changed.
* dom/Document.cpp:
(WebCore::Document::deviceScaleFactor):
* dom/Document.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155175 => 155176)
--- trunk/Source/WebCore/ChangeLog 2013-09-06 05:47:21 UTC (rev 155175)
+++ trunk/Source/WebCore/ChangeLog 2013-09-06 05:48:40 UTC (rev 155176)
@@ -1,3 +1,25 @@
+2013-09-05 Yoav Weiss y...@yoav.ws
+
+DRY out srcset related deviceScaleFactor calculations
+https://bugs.webkit.org/show_bug.cgi?id=120791
+
+Identical deviceScaleFactor calculations were performed in 3 different locations.
+I've added that calculation as a method of Document.
+Previous calculations are replaced by calls to this method.
+
+Reviewed by Andreas Kling.
+
+No new tests since this is a refactoring change. No functionality have changed.
+
+* dom/Document.cpp:
+(WebCore::Document::deviceScaleFactor):
+* dom/Document.h:
+* html/HTMLImageElement.cpp:
+(WebCore::HTMLImageElement::parseAttribute):
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::pumpTokenizer):
+(WebCore::HTMLDocumentParser::insert):
+
2013-09-05 Brendan Long b.l...@cablelabs.com
[Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in the build when they are disabled
Modified: trunk/Source/WebCore/dom/Document.cpp (155175 => 155176)
--- trunk/Source/WebCore/dom/Document.cpp 2013-09-06 05:47:21 UTC (rev 155175)
+++ trunk/Source/WebCore/dom/Document.cpp 2013-09-06 05:48:40 UTC (rev 155176)
@@ -5958,6 +5958,13 @@
}
#endif
+float Document::deviceScaleFactor() const
+{
+float deviceScaleFactor = 1.0;
+if (Page* documentPage = page())
+deviceScaleFactor = documentPage-deviceScaleFactor();
+return deviceScaleFactor;
+}
void Document::didAssociateFormControl(Element* element)
{
if (!frame() || !frame()-page() || !frame()-page()-chrome().client().shouldNotifyOnFormChanges())
Modified: trunk/Source/WebCore/dom/Document.h (155175 => 155176)
--- trunk/Source/WebCore/dom/Document.h 2013-09-06 05:47:21 UTC (rev 155175)
+++ trunk/Source/WebCore/dom/Document.h 2013-09-06 05:48:40 UTC (rev 155176)
@@ -496,6 +496,8 @@
Page* page() const; // can be NULL
Settings* settings() const; // can be NULL
+float deviceScaleFactor() const;
+
PassRefPtrRange createRange();
PassRefPtrNodeIterator createNodeIterator(Node* root, unsigned whatToShow,
Modified: trunk/Source/WebCore/html/HTMLImageElement.cpp (155175 => 155176)
--- trunk/Source/WebCore/html/HTMLImageElement.cpp 2013-09-06 05:47:21 UTC (rev 155175)
+++ trunk/Source/WebCore/html/HTMLImageElement.cpp 2013-09-06 05:48:40 UTC (rev 155176)
@@ -123,10 +123,7 @@
if (renderer() renderer()-isImage())
toRenderImage(renderer())-updateAltText();
} else if (name == srcAttr || name == srcsetAttr) {
-float deviceScaleFactor = 1.0;
-if (Page* page = document().page())
-deviceScaleFactor = page-deviceScaleFactor();
-m_bestFitImageURL = bestFitSourceForImageAttributes(deviceScaleFactor, fastGetAttribute(srcAttr), fastGetAttribute(srcsetAttr));
+m_bestFitImageURL = bestFitSourceForImageAttributes(document().deviceScaleFactor(), fastGetAttribute(srcAttr), fastGetAttribute(srcsetAttr));
m_imageLoader.updateFromElementIgnoringPreviousError();
} else if (name == usemapAttr)
setIsLink(!value.isNull() !shouldProhibitLinks(this));
Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (155175 => 155176)
--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2013-09-06 05:47:21 UTC (rev 155175)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2013-09-06 05:48:40 UTC (rev 155176)
@@ -566,10 +566,7 @@
if (isWaitingForScripts()) {
ASSERT(m_tokenizer-state() == HTMLTokenizer::DataState);
if (!m_preloadScanner) {
-float
[webkit-changes] [155177] trunk/Source/JavaScriptCore
Title: [155177] trunk/Source/_javascript_Core
Revision 155177
Author oli...@apple.com
Date 2013-09-05 22:50:33 -0700 (Thu, 05 Sep 2013)
Log Message
Make it simpler to introduce new data types to the global object
https://bugs.webkit.org/show_bug.cgi?id=120801
Reviewed by Gavin Barraclough.
Add an iterator macro that lists all the simple ES types (e.g. type
consists of instance, constructor, and prototype classes). So that
we don't need to have every new type litter JSGlobalObject.{cpp,h} with
members, accessors, and manual GC visiting.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.cpp
trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (155176 => 155177)
--- trunk/Source/_javascript_Core/ChangeLog 2013-09-06 05:48:40 UTC (rev 155176)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-09-06 05:50:33 UTC (rev 155177)
@@ -1,3 +1,19 @@
+2013-09-05 Oliver Hunt oli...@apple.com
+
+Make it simpler to introduce new data types to the global object
+https://bugs.webkit.org/show_bug.cgi?id=120801
+
+Reviewed by Gavin Barraclough.
+
+Add an iterator macro that lists all the simple ES types (e.g. type
+consists of instance, constructor, and prototype classes). So that
+we don't need to have every new type litter JSGlobalObject.{cpp,h} with
+members, accessors, and manual GC visiting.
+
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::visitChildren):
+* runtime/JSGlobalObject.h:
+
2013-09-05 Michael Saboff msab...@apple.com
Cleanup formatting of byte code debug output
Modified: trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.cpp (155176 => 155177)
--- trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.cpp 2013-09-06 05:48:40 UTC (rev 155176)
+++ trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.cpp 2013-09-06 05:50:33 UTC (rev 155177)
@@ -53,10 +53,9 @@
putDirectWithoutTransition(vm, vm.propertyNames-length, jsNumber(1), DontEnum | DontDelete | ReadOnly);
}
-JSArrayBufferConstructor* JSArrayBufferConstructor::create(
-JSGlobalObject* globalObject, Structure* structure, JSArrayBufferPrototype* prototype)
+JSArrayBufferConstructor* JSArrayBufferConstructor::create(CallFrame* callFrame, JSGlobalObject* globalObject, Structure* structure, JSArrayBufferPrototype* prototype)
{
-VM vm = globalObject-vm();
+VM vm = callFrame-vm();
JSArrayBufferConstructor* result =
new (NotNull, allocateCellJSArrayBufferConstructor(vm.heap))
JSArrayBufferConstructor(globalObject, structure);
Modified: trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.h (155176 => 155177)
--- trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.h 2013-09-06 05:48:40 UTC (rev 155176)
+++ trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.h 2013-09-06 05:50:33 UTC (rev 155177)
@@ -41,7 +41,7 @@
void finishCreation(VM, JSArrayBufferPrototype*);
public:
-static JSArrayBufferConstructor* create(JSGlobalObject*, Structure*, JSArrayBufferPrototype*);
+static JSArrayBufferConstructor* create(CallFrame*, JSGlobalObject*, Structure*, JSArrayBufferPrototype*);
DECLARE_INFO;
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp (155176 => 155177)
--- trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp 2013-09-06 05:48:40 UTC (rev 155176)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp 2013-09-06 05:50:33 UTC (rev 155177)
@@ -241,7 +241,6 @@
m_objectPrototype-putDirectAccessor(exec, exec-propertyNames().underscoreProto, protoAccessor, Accessor | DontEnum);
m_functionPrototype-structure()-setPrototypeWithoutTransition(exec-vm(), m_objectPrototype.get());
-m_arrayBufferPrototype.set(exec-vm(), this, JSArrayBufferPrototype::create(exec, this, JSArrayBufferPrototype::createStructure(exec-vm(), this, m_objectPrototype.get(;
m_typedArrays[toIndex(TypeInt8)].prototype.set(exec-vm(), this, JSInt8ArrayPrototype::create(exec, this, JSInt8ArrayPrototype::createStructure(exec-vm(), this, m_objectPrototype.get(;
m_typedArrays[toIndex(TypeInt16)].prototype.set(exec-vm(), this, JSInt16ArrayPrototype::create(exec, this, JSInt16ArrayPrototype::createStructure(exec-vm(), this, m_objectPrototype.get(;
m_typedArrays[toIndex(TypeInt32)].prototype.set(exec-vm(), this, JSInt32ArrayPrototype::create(exec, this, JSInt32ArrayPrototype::createStructure(exec-vm(), this, m_objectPrototype.get(;
@@ -253,7 +252,6 @@
m_typedArrays[toIndex(TypeFloat64)].prototype.set(exec-vm(), this,
[webkit-changes] [155178] trunk
Title: [155178] trunk
Revision 155178
Author k...@webkit.org
Date 2013-09-05 23:00:49 -0700 (Thu, 05 Sep 2013)
Log Message
Support SVG filters on -webkit-filter() function
https://bugs.webkit.org/show_bug.cgi?id=120806
Reviewed by Darin Adler.
Source/WebCore:
Add support for SVG Filters on CSS -webkit-filter() image function.
Test: fast/filter-image/filter-image-svg.html
* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image): Pass renderer to filter builder.
LayoutTests:
Test that the -webkit-filter() function can reference a SVG Filter
from the document.
* fast/filter-image/filter-image-svg-expected.html: Added.
* fast/filter-image/filter-image-svg.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFilterImageValue.cpp
Added Paths
trunk/LayoutTests/fast/filter-image/filter-image-svg-expected.html
trunk/LayoutTests/fast/filter-image/filter-image-svg.html
Diff
Modified: trunk/LayoutTests/ChangeLog (155177 => 155178)
--- trunk/LayoutTests/ChangeLog 2013-09-06 05:50:33 UTC (rev 155177)
+++ trunk/LayoutTests/ChangeLog 2013-09-06 06:00:49 UTC (rev 155178)
@@ -1,3 +1,16 @@
+2013-09-05 Dirk Schulze k...@webkit.org
+
+Support SVG filters on -webkit-filter() function
+https://bugs.webkit.org/show_bug.cgi?id=120806
+
+Reviewed by Darin Adler.
+
+Test that the -webkit-filter() function can reference a SVG Filter
+from the document.
+
+* fast/filter-image/filter-image-svg-expected.html: Added.
+* fast/filter-image/filter-image-svg.html: Added.
+
2013-09-05 Jinwoo Song jinwoo7.s...@samsung.com
[EFL] Unreviewed gardening.
Added: trunk/LayoutTests/fast/filter-image/filter-image-svg-expected.html (0 => 155178)
--- trunk/LayoutTests/fast/filter-image/filter-image-svg-expected.html (rev 0)
+++ trunk/LayoutTests/fast/filter-image/filter-image-svg-expected.html 2013-09-06 06:00:49 UTC (rev 155178)
@@ -0,0 +1,20 @@
+!DOCTYPE html
+html lang=en
+head
+ meta charset=utf-8
+ title/title
+ script
+
+ /script
+ style
+div {
+ background-color: black;
+ width: 100px;
+ height: 100px;
+}
+ /style
+/head
+body
+div/div
+/body
+/html
\ No newline at end of file
Added: trunk/LayoutTests/fast/filter-image/filter-image-svg.html (0 => 155178)
--- trunk/LayoutTests/fast/filter-image/filter-image-svg.html (rev 0)
+++ trunk/LayoutTests/fast/filter-image/filter-image-svg.html 2013-09-06 06:00:49 UTC (rev 155178)
@@ -0,0 +1,29 @@
+!DOCTYPE html
+html lang=en
+head
+ meta charset=utf-8
+ title/title
+ script
+
+ /script
+ style
+div {
+ background-image: -webkit-filter(url(image.svg), url(#filter));
+ width: 100px;
+ height: 100px;
+}
+ /style
+/head
+body
+div/div
+svg height=0
+ filter id=filter
+feComponentTransfer
+ feFuncR type=linear slope=0/
+ feFuncG type=linear slope=0/
+ feFuncB type=linear slope=0/
+/feComponentTransfer
+ /filter
+/svg
+/body
+/html
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (155177 => 155178)
--- trunk/Source/WebCore/ChangeLog 2013-09-06 05:50:33 UTC (rev 155177)
+++ trunk/Source/WebCore/ChangeLog 2013-09-06 06:00:49 UTC (rev 155178)
@@ -1,3 +1,17 @@
+2013-09-05 Dirk Schulze k...@webkit.org
+
+Support SVG filters on -webkit-filter() function
+https://bugs.webkit.org/show_bug.cgi?id=120806
+
+Reviewed by Darin Adler.
+
+Add support for SVG Filters on CSS -webkit-filter() image function.
+
+Test: fast/filter-image/filter-image-svg.html
+
+* css/CSSFilterImageValue.cpp:
+(WebCore::CSSFilterImageValue::image): Pass renderer to filter builder.
+
2013-09-05 Yoav Weiss y...@yoav.ws
DRY out srcset related deviceScaleFactor calculations
Modified: trunk/Source/WebCore/css/CSSFilterImageValue.cpp (155177 => 155178)
--- trunk/Source/WebCore/css/CSSFilterImageValue.cpp 2013-09-06 05:50:33 UTC (rev 155177)
+++ trunk/Source/WebCore/css/CSSFilterImageValue.cpp 2013-09-06 06:00:49 UTC (rev 155178)
@@ -122,8 +122,7 @@
filterRenderer-setSourceImage(texture.release());
filterRenderer-setSourceImageRect(FloatRect(FloatPoint(), size));
filterRenderer-setFilterRegion(FloatRect(FloatPoint(), size));
-// FIXME: SVG Filter don't work at the moment.
-if (!filterRenderer-build(0, m_filterOperations, FilterFunction))
+if (!filterRenderer-build(renderer, m_filterOperations, FilterFunction))
return Image::nullImage();
filterRenderer-apply();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
