[webkit-changes] [160302] trunk
Title: [160302] trunk Revision 160302 Author commit-qu...@webkit.org Date 2013-12-09 01:37:23 -0800 (Mon, 09 Dec 2013) Log Message [WK2][Gtk] Add support for ENABLE_NETWORK_PROCESS to the build system https://bugs.webkit.org/show_bug.cgi?id=118231 Patch by Brian Holt on 2013-12-09 Reviewed by Martin Robinson. Original patch by Kwang Yul Seo . .: Disabled ENABLE_NETWORK_PROCESS by default. * Source/autotools/SetupAutomake.m4: * Source/autotools/SetupWebKitFeatures.m4: Source/WebKit2: Add source files to the build system and build NetworkProcess executable. * GNUmakefile.am: * GNUmakefile.list.am: * NetworkProcess/unix/NetworkProcessMainUnix.cpp: * UIProcess/gtk/WebContextGtk.cpp: (WebKit::WebContext::platformInitializeWebProcess): Modified Paths trunk/ChangeLog trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am trunk/Source/WebKit2/GNUmakefile.list.am trunk/Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp trunk/Source/autotools/SetupAutomake.m4 trunk/Source/autotools/SetupWebKitFeatures.m4 Diff Modified: trunk/ChangeLog (160301 => 160302) --- trunk/ChangeLog 2013-12-09 07:46:56 UTC (rev 160301) +++ trunk/ChangeLog 2013-12-09 09:37:23 UTC (rev 160302) @@ -1,3 +1,17 @@ +2013-12-09 Brian Holt + +[WK2][Gtk] Add support for ENABLE_NETWORK_PROCESS to the build system +https://bugs.webkit.org/show_bug.cgi?id=118231 + +Reviewed by Martin Robinson. + +Original patch by Kwang Yul Seo . + +Disabled ENABLE_NETWORK_PROCESS by default. + +* Source/autotools/SetupAutomake.m4: +* Source/autotools/SetupWebKitFeatures.m4: + 2013-12-06 Alberto Garcia [GTK] Enable web audio by default Modified: trunk/Source/WebKit2/ChangeLog (160301 => 160302) --- trunk/Source/WebKit2/ChangeLog 2013-12-09 07:46:56 UTC (rev 160301) +++ trunk/Source/WebKit2/ChangeLog 2013-12-09 09:37:23 UTC (rev 160302) @@ -1,3 +1,20 @@ +2013-12-09 Brian Holt + +[WK2][Gtk] Add support for ENABLE_NETWORK_PROCESS to the build system +https://bugs.webkit.org/show_bug.cgi?id=118231 + +Reviewed by Martin Robinson. + +Original patch by Kwang Yul Seo . + +Add source files to the build system and build NetworkProcess executable. + +* GNUmakefile.am: +* GNUmakefile.list.am: +* NetworkProcess/unix/NetworkProcessMainUnix.cpp: +* UIProcess/gtk/WebContextGtk.cpp: +(WebKit::WebContext::platformInitializeWebProcess): + 2013-12-08 Ryuan Choi [EFL][WK2] Move FullScreenManager logic to WebViewEfl Modified: trunk/Source/WebKit2/GNUmakefile.am (160301 => 160302) --- trunk/Source/WebKit2/GNUmakefile.am 2013-12-09 07:46:56 UTC (rev 160301) +++ trunk/Source/WebKit2/GNUmakefile.am 2013-12-09 09:37:23 UTC (rev 160302) @@ -97,6 +97,7 @@ -I$(srcdir)/Source/WebKit2 \ -I$(srcdir)/Source/WebKit2/gtk \ -I$(srcdir)/Source/WebKit2/NetworkProcess \ + -I$(srcdir)/Source/WebKit2/NetworkProcess/FileAPI \ -I$(srcdir)/Source/WebKit2/Platform \ -I$(srcdir)/Source/WebKit2/Platform/CoreIPC \ -I$(srcdir)/Source/WebKit2/Platform/CoreIPC/gtk \ @@ -112,10 +113,12 @@ -I$(srcdir)/Source/WebKit2/Shared/CoreIPCSupport \ -I$(srcdir)/Source/WebKit2/Shared/Downloads \ -I$(srcdir)/Source/WebKit2/Shared/Downloads/soup \ + -I$(srcdir)/Source/WebKit2/Shared/FileAPI \ -I$(srcdir)/Source/WebKit2/Shared/Databases \ -I$(srcdir)/Source/WebKit2/Shared/Databases/IndexedDB \ -I$(srcdir)/Source/WebKit2/Shared/gtk \ -I$(srcdir)/Source/WebKit2/Shared/Network \ + -I$(srcdir)/Source/WebKit2/Shared/Network/CustomProtocols \ -I$(srcdir)/Source/WebKit2/Shared/Plugins \ -I$(srcdir)/Source/WebKit2/Shared/Plugins/Netscape \ -I$(srcdir)/Source/WebKit2/Shared/Plugins/Netscape/x11 \ @@ -145,6 +148,7 @@ -I$(srcdir)/Source/WebKit2/WebProcess/Cookies \ -I$(srcdir)/Source/WebKit2/WebProcess/Databases \ -I$(srcdir)/Source/WebKit2/WebProcess/Databases/IndexedDB \ + -I$(srcdir)/Source/WebKit2/WebProcess/FileAPI \ -I$(srcdir)/Source/WebKit2/WebProcess/FullScreen \ -I$(srcdir)/Source/WebKit2/WebProcess/Geolocation \ -I$(srcdir)/Source/WebKit2/WebProcess/gtk \ @@ -158,6 +162,7 @@ -I$(srcdir)/Source/WebKit2/WebProcess/KeyValueStorage \ -I$(srcdir)/Source/WebKit2/WebProcess/Launching \ -I$(srcdir)/Source/WebKit2/WebProcess/MediaCache \ + -I$(srcdir)/Source/WebKit2/WebProcess/Network \ -I$(srcdir)/Source/WebKit2/WebProcess/NetworkInfo \ -I$(srcdir)/Source/WebKit2/WebProcess/Notifications \ -I$(srcdir)/Source/WebKit2/WebProcess/OriginData \ @@ -366,6 +371,7 @@ $(GENSOURCES_WEBKIT2)/webkit2gtk/include/webkit2 vpath %.messages.in = \ + $(WebKit2)/NetworkProcess \ $(WebKit2)/PluginProcess \ $(WebKit2)/Shared \ $(WebKit2)/Shared/Authentication \ @@ -374,6 +380,7 @@ $(WebKit2)/UIProcess/ApplicationCache \ $(WebKit2)/UIProcess/Downloads \ $(WebKit2)/UIProcess/Geolocation \ + $(WebKit2)/UIProcess/Network
[webkit-changes] [160303] trunk/Source/WebKit2
Title: [160303] trunk/Source/WebKit2 Revision 160303 Author zandober...@gmail.com Date 2013-12-09 01:54:09 -0800 (Mon, 09 Dec 2013) Log Message [GTK][WK2] Move WebFullScreenManagerProxyGtk logic to PageClientImpl https://bugs.webkit.org/show_bug.cgi?id=125440 Reviewed by Martin Robinson. Make PageClientImpl a WebFullScreenManagerProxyClient. This brings the GTK port in line with changes in r160296 and fixes the WK2 build for that port. * GNUmakefile.list.am: * UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::fullScreenManagerProxyClient): (WebKit::PageClientImpl::closeFullScreenManager): (WebKit::PageClientImpl::isFullScreen): (WebKit::PageClientImpl::enterFullScreen): (WebKit::PageClientImpl::exitFullScreen): (WebKit::PageClientImpl::beganEnterFullScreen): (WebKit::PageClientImpl::beganExitFullScreen): * UIProcess/API/gtk/PageClientImpl.h: * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseCreateWebPage): * UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.list.am trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp Removed Paths trunk/Source/WebKit2/UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (160302 => 160303) --- trunk/Source/WebKit2/ChangeLog 2013-12-09 09:37:23 UTC (rev 160302) +++ trunk/Source/WebKit2/ChangeLog 2013-12-09 09:54:09 UTC (rev 160303) @@ -1,3 +1,27 @@ +2013-12-09 Zan Dobersek + +[GTK][WK2] Move WebFullScreenManagerProxyGtk logic to PageClientImpl +https://bugs.webkit.org/show_bug.cgi?id=125440 + +Reviewed by Martin Robinson. + +Make PageClientImpl a WebFullScreenManagerProxyClient. This brings the GTK port in line +with changes in r160296 and fixes the WK2 build for that port. + +* GNUmakefile.list.am: +* UIProcess/API/gtk/PageClientImpl.cpp: +(WebKit::PageClientImpl::fullScreenManagerProxyClient): +(WebKit::PageClientImpl::closeFullScreenManager): +(WebKit::PageClientImpl::isFullScreen): +(WebKit::PageClientImpl::enterFullScreen): +(WebKit::PageClientImpl::exitFullScreen): +(WebKit::PageClientImpl::beganEnterFullScreen): +(WebKit::PageClientImpl::beganExitFullScreen): +* UIProcess/API/gtk/PageClientImpl.h: +* UIProcess/API/gtk/WebKitWebViewBase.cpp: +(webkitWebViewBaseCreateWebPage): +* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp: + 2013-12-09 Brian Holt [WK2][Gtk] Add support for ENABLE_NETWORK_PROCESS to the build system Modified: trunk/Source/WebKit2/GNUmakefile.list.am (160302 => 160303) --- trunk/Source/WebKit2/GNUmakefile.list.am 2013-12-09 09:37:23 UTC (rev 160302) +++ trunk/Source/WebKit2/GNUmakefile.list.am 2013-12-09 09:54:09 UTC (rev 160303) @@ -894,7 +894,6 @@ Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h \ Source/WebKit2/UIProcess/gtk/WebFullScreenClientGtk.cpp \ Source/WebKit2/UIProcess/gtk/WebFullScreenClientGtk.h \ - Source/WebKit2/UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp \ Source/WebKit2/UIProcess/gtk/WebInspectorClientGtk.cpp \ Source/WebKit2/UIProcess/gtk/WebInspectorClientGtk.h \ Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp \ Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp (160302 => 160303) --- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2013-12-09 09:37:23 UTC (rev 160302) +++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2013-12-09 09:54:09 UTC (rev 160303) @@ -289,4 +289,49 @@ notImplemented(); } +#if ENABLE(FULLSCREEN_API) +WebFullScreenManagerProxyClient& PageClientImpl::fullScreenManagerProxyClient() +{ +return *this; +} + +void PageClientImpl::closeFullScreenManager() +{ +notImplemented(); +} + +bool PageClientImpl::isFullScreen() +{ +notImplemented(); +return false; +} + +void PageClientImpl::enterFullScreen() +{ +if (!m_viewWidget) +return; + +webkitWebViewBaseEnterFullScreen(WEBKIT_WEB_VIEW_BASE(m_viewWidget)); +} + +void PageClientImpl::exitFullScreen() +{ +if (!m_viewWidget) +return; + +webkitWebViewBaseExitFullScreen(WEBKIT_WEB_VIEW_BASE(m_viewWidget)); +} + +void PageClientImpl::beganEnterFullScreen(const IntRect& initialFrame, const IntRect& finalFrame) +{ +notImplemented(); +} + +void PageClientImpl::beganExitFullScreen(const IntRect& initialFrame, const IntRect& finalFrame) +{ +notImplemented(); +} + +#endif // ENABLE(FULLSCREEN_API) + } // namespace WebKit Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h (160302 => 160303) --- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2013-12-09 09:37:23 UTC (rev 160302) +++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2013-12-09 09:54:09 UTC (rev 160303) @@ -31,6 +31,
[webkit-changes] [160304] trunk/Source/WebKit2
Title: [160304] trunk/Source/WebKit2 Revision 160304 Author g...@gnome.org Date 2013-12-09 01:55:49 -0800 (Mon, 09 Dec 2013) Log Message [GTK] run-webkit-tests may DOS the system, specially in debug builds https://bugs.webkit.org/show_bug.cgi?id=125436 Reviewed by Martin Robinson. * GNUmakefile.am: use -no-fast-install for WebKitWebProcess and WebKitPluginProcess so they do not need to be relinked the first time they are executed in-tree. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am Diff Modified: trunk/Source/WebKit2/ChangeLog (160303 => 160304) --- trunk/Source/WebKit2/ChangeLog 2013-12-09 09:54:09 UTC (rev 160303) +++ trunk/Source/WebKit2/ChangeLog 2013-12-09 09:55:49 UTC (rev 160304) @@ -1,3 +1,13 @@ +2013-12-09 Gustavo Noronha Silva + +[GTK] run-webkit-tests may DOS the system, specially in debug builds +https://bugs.webkit.org/show_bug.cgi?id=125436 + +Reviewed by Martin Robinson. + +* GNUmakefile.am: use -no-fast-install for WebKitWebProcess and WebKitPluginProcess so +they do not need to be relinked the first time they are executed in-tree. + 2013-12-09 Zan Dobersek [GTK][WK2] Move WebFullScreenManagerProxyGtk logic to PageClientImpl Modified: trunk/Source/WebKit2/GNUmakefile.am (160303 => 160304) --- trunk/Source/WebKit2/GNUmakefile.am 2013-12-09 09:54:09 UTC (rev 160303) +++ trunk/Source/WebKit2/GNUmakefile.am 2013-12-09 09:55:49 UTC (rev 160304) @@ -539,6 +539,9 @@ $(GTK_UNIX_PRINTING_LIBS) \ $(LIBSOUP_LIBS) +Programs_WebKitWebProcess_LDFLAGS = \ + -no-fast-install + libWebCoreGtk2_la_SOURCES = \ $(webcoregtk_sources) @@ -756,6 +759,9 @@ $(WINMM_LIBS) \ $(ZLIB_LIBS) +Programs_WebKitPluginProcess_LDFLAGS = \ + -no-fast-install + Programs_WebKitPluginProcess_CXXFLAGS = \ -fvisibility-inlines-hidden \ $(global_cxxflags) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [160305] trunk/LayoutTests
Title: [160305] trunk/LayoutTests Revision 160305 Author g...@gnome.org Date 2013-12-09 03:45:44 -0800 (Mon, 09 Dec 2013) Log Message accessibility/press-targets-center-point.html should not depend on font layout https://bugs.webkit.org/show_bug.cgi?id=125387 Reviewed by Chris Fleizach. * accessibility/press-targets-center-point.html: use explicit sizes for heights (and width for vertical writing mode), so that font layout does not alter the results. * platform/gtk/TestExpectations: remove failure expectation for accessibility/press-targets-center-point.html Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/press-targets-center-point.html trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (160304 => 160305) --- trunk/LayoutTests/ChangeLog 2013-12-09 09:55:49 UTC (rev 160304) +++ trunk/LayoutTests/ChangeLog 2013-12-09 11:45:44 UTC (rev 160305) @@ -1,3 +1,14 @@ +2013-12-09 Gustavo Noronha Silva + +accessibility/press-targets-center-point.html should not depend on font layout +https://bugs.webkit.org/show_bug.cgi?id=125387 + +Reviewed by Chris Fleizach. + +* accessibility/press-targets-center-point.html: use explicit sizes for heights (and width +for vertical writing mode), so that font layout does not alter the results. +* platform/gtk/TestExpectations: remove failure expectation for accessibility/press-targets-center-point.html + 2013-12-08 Ryosuke Niwa getComputedStyle border-radius shorthand omits vertical radius information Modified: trunk/LayoutTests/accessibility/press-targets-center-point.html (160304 => 160305) --- trunk/LayoutTests/accessibility/press-targets-center-point.html 2013-12-09 09:55:49 UTC (rev 160304) +++ trunk/LayoutTests/accessibility/press-targets-center-point.html 2013-12-09 11:45:44 UTC (rev 160305) @@ -16,16 +16,16 @@ -target +target Actual: waitingExpected: waiting -translate transform target +translate transform target Actual: waitingExpected: waiting -vertical left-to-right writing mode target +vertical left-to-right writing mode target Actual: waitingExpected: waiting -right-to-left direction target +right-to-left direction target Actual: waitingExpected: waiting Modified: trunk/LayoutTests/platform/gtk/TestExpectations (160304 => 160305) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-12-09 09:55:49 UTC (rev 160304) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-12-09 11:45:44 UTC (rev 160305) @@ -1519,8 +1519,6 @@ webkit.org/b/125406 fast/regions/relative-in-absolute-borders-overflow.html [ ImageOnlyFailure ] -webkit.org/b/125409 accessibility/press-targets-center-point.html [ Failure ] - # # End of Tests failing # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [160306] trunk/Source/WebCore
Title: [160306] trunk/Source/WebCore Revision 160306 Author carlo...@webkit.org Date 2013-12-09 03:49:27 -0800 (Mon, 09 Dec 2013) Log Message Unreviewed. Fix the GTK+ build with NetworkProcess enabled. * GNUmakefile.list.am: Add missing file to compilation. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am Diff Modified: trunk/Source/WebCore/ChangeLog (160305 => 160306) --- trunk/Source/WebCore/ChangeLog 2013-12-09 11:45:44 UTC (rev 160305) +++ trunk/Source/WebCore/ChangeLog 2013-12-09 11:49:27 UTC (rev 160306) @@ -1,3 +1,9 @@ +2013-12-09 Carlos Garcia Campos + +Unreviewed. Fix the GTK+ build with NetworkProcess enabled. + +* GNUmakefile.list.am: Add missing file to compilation. + 2013-12-08 Ryosuke Niwa getComputedStyle border-radius shorthand omits vertical radius information Modified: trunk/Source/WebCore/GNUmakefile.list.am (160305 => 160306) --- trunk/Source/WebCore/GNUmakefile.list.am 2013-12-09 11:45:44 UTC (rev 160305) +++ trunk/Source/WebCore/GNUmakefile.list.am 2013-12-09 11:49:27 UTC (rev 160306) @@ -5478,6 +5478,7 @@ Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp \ Source/WebCore/platform/network/soup/ResourceResponse.h \ Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp \ + Source/WebCore/platform/network/soup/SynchronousLoaderClientSoup.cpp \ Source/WebCore/platform/ScrollableArea.cpp \ Source/WebCore/platform/ScrollableArea.h \ Source/WebCore/platform/ScrollbarThemeClient.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [160307] trunk/Source/WebKit2
Title: [160307] trunk/Source/WebKit2 Revision 160307 Author k...@webkit.org Date 2013-12-09 04:06:40 -0800 (Mon, 09 Dec 2013) Log Message [WK2][Soup] Support cache model in NetworkProcess https://bugs.webkit.org/show_bug.cgi?id=118343 Reviewed by Carlos Garcia Campos. Original patch by Kwang Yul Seo and Csaba Osztrogonác . Copied cache model code from WebProcess. NetworkProcess is configured not to use the WebCore memory cache. * NetworkProcess/soup/NetworkProcessSoup.cpp: (WebKit::getCacheDiskFreeSize): (WebKit::getMemorySize): (WebKit::NetworkProcess::platformInitializeNetworkProcess): Initialize soup cache. (WebKit::NetworkProcess::platformSetCacheModel): Copied code from WebProcess::platformSetCacheModel but removed WebCore memory cache initialization because NetworkProcess does not use the WebCore memory cache. (WebKit::NetworkProcess::clearCacheForAllOrigins): Copied code from WebProcess::clearCacheForAllOrigins. * NetworkProcess/unix/NetworkProcessMainUnix.cpp: Copied initialization code from WebProcessMainGtk.cpp. (WebKit::NetworkProcessMain): * WebProcess/soup/WebProcessSoup.cpp: (WebKit::WebProcess::platformSetCacheModel): Don't set the disk cache if NetworkProcess is used. (WebKit::WebProcess::platformClearResourceCaches): Don't clear the non-existing disk cache. (if NetworkProcess is used) (WebKit::WebProcess::platformInitializeWebProcess): Don't initialize the disk cache if NetworkProcess is used. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp trunk/Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp trunk/Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (160306 => 160307) --- trunk/Source/WebKit2/ChangeLog 2013-12-09 11:49:27 UTC (rev 160306) +++ trunk/Source/WebKit2/ChangeLog 2013-12-09 12:06:40 UTC (rev 160307) @@ -1,3 +1,37 @@ +2013-12-09 Kwang Yul Seo + +[WK2][Soup] Support cache model in NetworkProcess +https://bugs.webkit.org/show_bug.cgi?id=118343 + +Reviewed by Carlos Garcia Campos. + +Original patch by Kwang Yul Seo and Csaba Osztrogonác . + +Copied cache model code from WebProcess. +NetworkProcess is configured not to use the WebCore memory cache. + +* NetworkProcess/soup/NetworkProcessSoup.cpp: +(WebKit::getCacheDiskFreeSize): +(WebKit::getMemorySize): +(WebKit::NetworkProcess::platformInitializeNetworkProcess): +Initialize soup cache. +(WebKit::NetworkProcess::platformSetCacheModel): +Copied code from WebProcess::platformSetCacheModel but removed +WebCore memory cache initialization because NetworkProcess does not use +the WebCore memory cache. +(WebKit::NetworkProcess::clearCacheForAllOrigins): +Copied code from WebProcess::clearCacheForAllOrigins. +* NetworkProcess/unix/NetworkProcessMainUnix.cpp: +Copied initialization code from WebProcessMainGtk.cpp. +(WebKit::NetworkProcessMain): +* WebProcess/soup/WebProcessSoup.cpp: +(WebKit::WebProcess::platformSetCacheModel): +Don't set the disk cache if NetworkProcess is used. +(WebKit::WebProcess::platformClearResourceCaches): +Don't clear the non-existing disk cache. (if NetworkProcess is used) +(WebKit::WebProcess::platformInitializeWebProcess): +Don't initialize the disk cache if NetworkProcess is used. + 2013-12-09 Gustavo Noronha Silva [GTK] run-webkit-tests may DOS the system, specially in debug builds Modified: trunk/Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp (160306 => 160307) --- trunk/Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp 2013-12-09 11:49:27 UTC (rev 160306) +++ trunk/Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp 2013-12-09 12:06:40 UTC (rev 160307) @@ -29,21 +29,81 @@ #include "NetworkProcess.h" #include "NetworkProcessCreationParameters.h" +#include "ResourceCachesToClear.h" +#include #include +#include +#include +#include +#include using namespace WebCore; namespace WebKit { -void NetworkProcess::platformInitializeNetworkProcess(const NetworkProcessCreationParameters&) +static uint64_t getCacheDiskFreeSize(SoupCache* cache) { +ASSERT(cache); + +GOwnPtr cacheDir; +g_object_get(G_OBJECT(cache), "cache-dir", &cacheDir.outPtr(), NULL); +if (!cacheDir) +return 0; + +return WebCore::getVolumeFreeSizeForPath(cacheDir.get()); } -void NetworkProcess::platformSetCacheModel(CacheModel) +static uint64_t getMemorySize() { -notImplemented(); +static uint64_t kDefaultMemorySize = 512; +#if !OS(WINDOWS) +long pageSize = sysconf(_SC_PAGESIZE); +if (pageSize == -1) +return kDefaultMemorySize; + +long physPages = sysconf(_SC_PHYS_PAGES); +if (physPages == -1) +return kDefaultMemorySize; + +return ((pageSize / 1024) * physPages)
[webkit-changes] [160309] trunk
Title: [160309] trunk Revision 160309 Author commit-qu...@webkit.org Date 2013-12-09 04:42:54 -0800 (Mon, 09 Dec 2013) Log Message Source/WebCore: DataCloneError exception is not thrown when postMessage's second parameter is the source port or the target port. https://bugs.webkit.org/show_bug.cgi?id=124708 Patch by Michal Poteralski on 2013-12-09 Reviewed by Alexey Proskuryakov. According to specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/web-messaging.html#dom-window-postmessage If the method was invoked with a second argument transfer then if any of the objects in the transfer are either the source port or the target port (if any), then a DataCloneError exception should be thrown. Currently an InvalidStateError exception is thrown what is an incorrect behaviour. The proposed solution is change to the correct the exception value. Tests: fast/dom/Window/postMessage-clone-port-error.html * dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): Improve exception value LayoutTests: DataCloneError exception is not thrown when postMessage's second parameter is the source port or the target port. https://bugs.webkit.org/show_bug.cgi?id=124708 Patch by Michal Poteralski on 2013-12-09 Reviewed by Alexey Proskuryakov. Added layout test to check correctness of value thrown by postMessage: * fast/dom/Window/postMessage-clone-port-error-expected.txt: Added. * fast/dom/Window/postMessage-clone-port-error.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/events/message-port-clone-expected.txt trunk/LayoutTests/fast/events/message-port-multi-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/MessagePort.cpp Added Paths trunk/LayoutTests/fast/dom/Window/postMessage-clone-port-error-expected.txt trunk/LayoutTests/fast/dom/Window/postMessage-clone-port-error.html Diff Modified: trunk/LayoutTests/ChangeLog (160308 => 160309) --- trunk/LayoutTests/ChangeLog 2013-12-09 12:28:44 UTC (rev 160308) +++ trunk/LayoutTests/ChangeLog 2013-12-09 12:42:54 UTC (rev 160309) @@ -1,3 +1,17 @@ +2013-12-09 Michal Poteralski + +DataCloneError exception is not thrown when postMessage's second parameter +is the source port or the target port. + +https://bugs.webkit.org/show_bug.cgi?id=124708 + +Reviewed by Alexey Proskuryakov. + +Added layout test to check correctness of value thrown by postMessage: + +* fast/dom/Window/postMessage-clone-port-error-expected.txt: Added. +* fast/dom/Window/postMessage-clone-port-error.html: Added. + 2013-12-09 Gustavo Noronha Silva accessibility/press-targets-center-point.html should not depend on font layout Added: trunk/LayoutTests/fast/dom/Window/postMessage-clone-port-error-expected.txt (0 => 160309) --- trunk/LayoutTests/fast/dom/Window/postMessage-clone-port-error-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/Window/postMessage-clone-port-error-expected.txt 2013-12-09 12:42:54 UTC (rev 160309) @@ -0,0 +1,5 @@ +PASS successfullyParsed is true + +TEST COMPLETE +PASS exName is "DataCloneError" + Added: trunk/LayoutTests/fast/dom/Window/postMessage-clone-port-error.html (0 => 160309) --- trunk/LayoutTests/fast/dom/Window/postMessage-clone-port-error.html (rev 0) +++ trunk/LayoutTests/fast/dom/Window/postMessage-clone-port-error.html 2013-12-09 12:42:54 UTC (rev 160309) @@ -0,0 +1,21 @@ + + +var exName; +function test() { +if (window.testRunner) +testRunner.dumpAsText(); + +var channel = new MessageChannel(); +channel.port1.start(); + +try { +channel.port1.postMessage("ports", [channel.port1]); +} catch(ex) { +exName = ex.name +shouldBeEqualToString("exName", "DataCloneError"); +} +} + +
[webkit-changes] [160310] trunk/Source
Title: [160310] trunk/Source Revision 160310 Author mrobin...@webkit.org Date 2013-12-09 06:10:18 -0800 (Mon, 09 Dec 2013) Log Message [WK2][Soup] Use didReceiveBuffer instead of didReceiveData https://bugs.webkit.org/show_bug.cgi?id=118598 Reviewed by Gustavo Noronha Silva. Original patch by Kwang Yul Seo and Csaba Osztrogonác . Switch from using didReceiveData to didReceiveBuffer for the Soup backend and let SharedBuffer wrap a SoupBuffer. This is necessary because the NetworkProcess only supports getting data via SharedBuffer. Source/WebCore: * GNUmakefile.list.am: Add the new SharedBufferSoup.cpp file to the list. * PlatformEfl.cmake: * PlatformGTK.cmake: * PlatformNix.cmake: * platform/SharedBuffer.cpp: We no longer used the no-op version of the platformFoo methods. * platform/SharedBuffer.h: Ditto. * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Use didReceiveBuffer instead of didReceiveData. * platform/network/ResourceHandleInternal.h: Have only a m_soupBuffer member instead of three to manage the buffer. * platform/network/soup/GOwnPtrSoup.cpp: Add support for SoupBuffer. * platform/network/soup/GOwnPtrSoup.h: Ditto. * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didReceiveData): ASSERT_NOT_REACHED here, since it should never be called now. (WebCore::WebCoreSynchronousLoader::didReceiveBuffer): Handle this call properly. (WebCore::ResourceHandle::ensureReadBuffer): Now we package up our buffer into a SoupBuffer. (WebCore::redirectSkipCallback): Use the new m_soupBuffer member. (WebCore::cleanupSoupRequestOperation): Ditto. (WebCore::nextMultipartResponsePartCallback): Ditto. (WebCore::sendRequestCallback): Ditto. (WebCore::readCallback): * platform/soup/SharedBufferSoup.cpp: Added. Source/WebKit/gtk: * webkit/webkitdownload.cpp: (DownloadClient::didReceiveData): Replace with ASSERT_NOT_REACHED. (DownloadClient::didReceiveBuffer): Use this to process incoming data. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebCore/PlatformGTK.cmake trunk/Source/WebCore/PlatformNix.cmake trunk/Source/WebCore/platform/SharedBuffer.cpp trunk/Source/WebCore/platform/SharedBuffer.h trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp trunk/Source/WebCore/platform/network/ResourceHandleInternal.h trunk/Source/WebCore/platform/network/soup/GOwnPtrSoup.cpp trunk/Source/WebCore/platform/network/soup/GOwnPtrSoup.h trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp Added Paths trunk/Source/WebCore/platform/soup/ trunk/Source/WebCore/platform/soup/SharedBufferSoup.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (160309 => 160310) --- trunk/Source/WebCore/ChangeLog 2013-12-09 12:42:54 UTC (rev 160309) +++ trunk/Source/WebCore/ChangeLog 2013-12-09 14:10:18 UTC (rev 160310) @@ -1,3 +1,38 @@ +2013-12-08 Martin Robinson + +[WK2][Soup] Use didReceiveBuffer instead of didReceiveData +https://bugs.webkit.org/show_bug.cgi?id=118598 + +Reviewed by Gustavo Noronha Silva. + +Original patch by Kwang Yul Seo and Csaba Osztrogonác . + +Switch from using didReceiveData to didReceiveBuffer for the Soup backend and +let SharedBuffer wrap a SoupBuffer. This is necessary because the NetworkProcess +only supports getting data via SharedBuffer. + +* GNUmakefile.list.am: Add the new SharedBufferSoup.cpp file to the list. +* PlatformEfl.cmake: +* PlatformGTK.cmake: +* PlatformNix.cmake: +* platform/SharedBuffer.cpp: We no longer used the no-op version of the platformFoo methods. +* platform/SharedBuffer.h: Ditto. +* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Use didReceiveBuffer instead of didReceiveData. +* platform/network/ResourceHandleInternal.h: Have only a m_soupBuffer member instead of three to manage the buffer. +* platform/network/soup/GOwnPtrSoup.cpp: Add support for SoupBuffer. +* platform/network/soup/GOwnPtrSoup.h: Ditto. +* platform/network/soup/ResourceHandleSoup.cpp: +(WebCore::WebCoreSynchronousLoader::didReceiveData): ASSERT_NOT_REACHED here, since it should never be +called now. +(WebCore::WebCoreSynchronousLoader::didReceiveBuffer): Handle this call properly. +(WebCore::ResourceHandle::ensureReadBuffer): Now we package up our buffer into a SoupBuffer. +(WebCore::redirectSkipCallback): Use the new m_soupBuffer member. +(WebCore::cleanupSoupRequestOperation): Ditto. +(WebCore::nextMultipartResponsePartCallback): Ditto. +(WebCore::sendRequestCallback): Ditto. +(WebCore::readCallback): +* platform/soup/SharedBufferSoup.cpp: Added. + 2013-12-09 Michal Poteralski DataCloneError exc
[webkit-changes] [160311] trunk
Title: [160311] trunk Revision 160311 Author cfleiz...@apple.com Date 2013-12-09 06:17:27 -0800 (Mon, 09 Dec 2013) Log Message AX: WebKit ignores @alt on IMG elements with role="text" https://bugs.webkit.org/show_bug.cgi?id=125363 Reviewed by Mario Sanchez Prada. Source/WebCore: If an element has a different role, the alt attribute should still be used in the name calculation if present. Test: accessibility/alt-tag-on-image-with-nonimage-role.html * accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::usesAltTagForTextComputation): (WebCore::AccessibilityNodeObject::alternativeText): (WebCore::AccessibilityNodeObject::accessibilityDescription): (WebCore::AccessibilityNodeObject::text): * accessibility/AccessibilityNodeObject.h: LayoutTests: * accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Added. * accessibility/alt-tag-on-image-with-nonimage-role.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp trunk/Source/WebCore/accessibility/AccessibilityNodeObject.h Added Paths trunk/LayoutTests/accessibility/alt-tag-on-image-with-nonimage-role-expected.txt trunk/LayoutTests/accessibility/alt-tag-on-image-with-nonimage-role.html Diff Modified: trunk/LayoutTests/ChangeLog (160310 => 160311) --- trunk/LayoutTests/ChangeLog 2013-12-09 14:10:18 UTC (rev 160310) +++ trunk/LayoutTests/ChangeLog 2013-12-09 14:17:27 UTC (rev 160311) @@ -1,3 +1,13 @@ +2013-12-09 Chris Fleizach + +AX: WebKit ignores @alt on IMG elements with role="text" +https://bugs.webkit.org/show_bug.cgi?id=125363 + +Reviewed by Mario Sanchez Prada. + +* accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Added. +* accessibility/alt-tag-on-image-with-nonimage-role.html: Added. + 2013-12-09 Michal Poteralski DataCloneError exception is not thrown when postMessage's second parameter Added: trunk/LayoutTests/accessibility/alt-tag-on-image-with-nonimage-role-expected.txt (0 => 160311) --- trunk/LayoutTests/accessibility/alt-tag-on-image-with-nonimage-role-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/alt-tag-on-image-with-nonimage-role-expected.txt 2013-12-09 14:17:27 UTC (rev 160311) @@ -0,0 +1,13 @@ + +This tests that setting a role on an img still allows the alt attribute to be used for the description.. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS text.stringValue is 'AXValue: TEST1' +PASS group.description is 'AXDescription: TEST2' +PASS button.description is 'AXDescription: TEST3' +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/accessibility/alt-tag-on-image-with-nonimage-role.html (0 => 160311) --- trunk/LayoutTests/accessibility/alt-tag-on-image-with-nonimage-role.html (rev 0) +++ trunk/LayoutTests/accessibility/alt-tag-on-image-with-nonimage-role.html 2013-12-09 14:17:27 UTC (rev 160311) @@ -0,0 +1,37 @@ + + + + + + ++ +
+ +
+ + + + +