[webkit-changes] [161804] trunk/Source/WebKit2
Title: [161804] trunk/Source/WebKit2
Revision 161804
Author commit-qu...@webkit.org
Date 2014-01-11 23:31:52 -0800 (Sat, 11 Jan 2014)
Log Message
Support bool argument for encoding/decoding invocations.
https://bugs.webkit.org/show_bug.cgi?id=126823
Patch by Yongjun Zhang on 2014-01-11
Reviewed by Sam Weinig.
For remote invocation method argument, current we support int, double and ObjC
object, this patch add support for bool type too.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocation):
(decodeInvocationArguments):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (161803 => 161804)
--- trunk/Source/WebKit2/ChangeLog 2014-01-12 07:15:34 UTC (rev 161803)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-12 07:31:52 UTC (rev 161804)
@@ -1,3 +1,17 @@
+2014-01-11 Yongjun Zhang
+
+Support bool argument for encoding/decoding invocations.
+https://bugs.webkit.org/show_bug.cgi?id=126823
+
+Reviewed by Sam Weinig.
+
+For remote invocation method argument, current we support int, double and ObjC
+object, this patch add support for bool type too.
+
+* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
+(encodeInvocation):
+(decodeInvocationArguments):
+
2014-01-11 Alexey Proskuryakov
[Mac] [Windows] Stop scheduling network requests in WebCore
Modified: trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm (161803 => 161804)
--- trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm 2014-01-12 07:15:34 UTC (rev 161803)
+++ trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm 2014-01-12 07:31:52 UTC (rev 161804)
@@ -146,6 +146,15 @@
break;
}
+// bool
+case 'B': {
+BOOL value;
+[invocation getArgument:&value atIndex:i];;
+
+encodeToObjectStream(encoder, @(value));
+break;
+}
+
// Objective-C object
case '@': {
id value;
@@ -385,6 +394,13 @@
break;
}
+// bool
+case 'B': {
+bool value = [decodeObjectFromObjectStream(decoder, [NSSet setWithObject:[NSNumber class]]) boolValue];
+[invocation setArgument:&value atIndex:i];
+break;
+}
+
// Objective-C object
case '@': {
NSSet *allowedClasses = allowedArgumentClasses[i - 2].get();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161802] trunk/Source/WTF
Title: [161802] trunk/Source/WTF
Revision 161802
Author zandober...@gmail.com
Date 2014-01-11 23:15:28 -0800 (Sat, 11 Jan 2014)
Log Message
Unreviewed build fix for ports using GCC after r161770.
* wtf/IteratorAdaptors.h:
(WTF::FilterIterator::operator*): Replicating r161797, the const qualifier for
FilterIterator::operator*() is removed since it clashes with some iterator types
that are also const, causing compilation failures with GCC.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/IteratorAdaptors.h
Diff
Modified: trunk/Source/WTF/ChangeLog (161801 => 161802)
--- trunk/Source/WTF/ChangeLog 2014-01-12 06:30:10 UTC (rev 161801)
+++ trunk/Source/WTF/ChangeLog 2014-01-12 07:15:28 UTC (rev 161802)
@@ -1,3 +1,12 @@
+2014-01-11 Zan Dobersek
+
+Unreviewed build fix for ports using GCC after r161770.
+
+* wtf/IteratorAdaptors.h:
+(WTF::FilterIterator::operator*): Replicating r161797, the const qualifier for
+FilterIterator::operator*() is removed since it clashes with some iterator types
+that are also const, causing compilation failures with GCC.
+
2014-01-11 Anders Carlsson
Use std::call_once instead of AtomicallyInitializedStatic when creating a HTTP header set
Modified: trunk/Source/WTF/wtf/IteratorAdaptors.h (161801 => 161802)
--- trunk/Source/WTF/wtf/IteratorAdaptors.h 2014-01-12 06:30:10 UTC (rev 161801)
+++ trunk/Source/WTF/wtf/IteratorAdaptors.h 2014-01-12 07:15:28 UTC (rev 161802)
@@ -50,7 +50,7 @@
return *this;
}
-const decltype(*std::declval()) operator*() const
+decltype(*std::declval()) operator*() const
{
ASSERT(m_iter != m_end);
ASSERT(m_pred(*m_iter));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161803] trunk/WebKitLibraries
Title: [161803] trunk/WebKitLibraries Revision 161803 Author a...@apple.com Date 2014-01-11 23:15:34 -0800 (Sat, 11 Jan 2014) Log Message [Mac] [Windows] Stop scheduling network requests in WebCore https://bugs.webkit.org/show_bug.cgi?id=126789 Update Windows WKSI. * win/include/WebKitSystemInterface/WebKitSystemInterface.h: * win/lib32/WebKitSystemInterface.lib: Modified Paths trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/win/include/WebKitSystemInterface/WebKitSystemInterface.h trunk/WebKitLibraries/win/lib32/WebKitSystemInterface.lib Diff Modified: trunk/WebKitLibraries/ChangeLog (161802 => 161803) --- trunk/WebKitLibraries/ChangeLog 2014-01-12 07:15:28 UTC (rev 161802) +++ trunk/WebKitLibraries/ChangeLog 2014-01-12 07:15:34 UTC (rev 161803) @@ -4,6 +4,17 @@ https://bugs.webkit.org/show_bug.cgi?id=126789 +Update Windows WKSI. + +* win/include/WebKitSystemInterface/WebKitSystemInterface.h: +* win/lib32/WebKitSystemInterface.lib: + +2014-01-11 Alexey Proskuryakov + +[Mac] [Windows] Stop scheduling network requests in WebCore +https://bugs.webkit.org/show_bug.cgi?id=126789 + + Update WKSI. * WebKitSystemInterface.h: Modified: trunk/WebKitLibraries/win/include/WebKitSystemInterface/WebKitSystemInterface.h (161802 => 161803) --- trunk/WebKitLibraries/win/include/WebKitSystemInterface/WebKitSystemInterface.h 2014-01-12 07:15:28 UTC (rev 161802) +++ trunk/WebKitLibraries/win/include/WebKitSystemInterface/WebKitSystemInterface.h 2014-01-12 07:15:34 UTC (rev 161803) @@ -113,9 +113,10 @@ void wkCFURLCacheDeleteHostNamesInPersistentStore(CFArrayRef hostNames); unsigned wkInitializeMaximumHTTPConnectionCountPerHost(unsigned preferredConnectionCount); -int wkGetHTTPPipeliningPriority(CFURLRequestRef); -void wkSetHTTPPipeliningMaximumPriority(int maximumPriority); -void wkSetHTTPPipeliningPriority(CFURLRequestRef, int priority); +int wkGetHTTPRequestPriority(CFURLRequestRef); +void wkSetHTTPRequestMaximumPriority(int maximumPriority); +void wkSetHTTPRequestPriority(CFURLRequestRef, int priority); +void wkHTTPRequestEnablePipelining(CFURLRequestRef); void wkSetCONNECTProxyForStream(CFReadStreamRef, CFStringRef proxyHost, CFNumberRef proxyPort); void wkSetCONNECTProxyAuthorizationForStream(CFReadStreamRef, CFStringRef proxyAuthorizationString); Modified: trunk/WebKitLibraries/win/lib32/WebKitSystemInterface.lib (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161801] trunk/Source
Title: [161801] trunk/Source
Revision 161801
Author ander...@apple.com
Date 2014-01-11 22:30:10 -0800 (Sat, 11 Jan 2014)
Log Message
Use std::call_once instead of AtomicallyInitializedStatic when creating a HTTP header set
https://bugs.webkit.org/show_bug.cgi?id=126837
Reviewed by Sam Weinig.
Source/WebCore:
Use std::call_once when constructing the HTTPHeaderSet.
* loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlResponseHeaderWhitelist):
Source/WTF:
* wtf/HashSet.h:
(WTF::HashSet::HashSet):
Add a HashSet constructor that takes an initializer list.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashSet.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (161800 => 161801)
--- trunk/Source/WTF/ChangeLog 2014-01-12 05:59:44 UTC (rev 161800)
+++ trunk/Source/WTF/ChangeLog 2014-01-12 06:30:10 UTC (rev 161801)
@@ -1,3 +1,14 @@
+2014-01-11 Anders Carlsson
+
+Use std::call_once instead of AtomicallyInitializedStatic when creating a HTTP header set
+https://bugs.webkit.org/show_bug.cgi?id=126837
+
+Reviewed by Sam Weinig.
+
+* wtf/HashSet.h:
+(WTF::HashSet::HashSet):
+Add a HashSet constructor that takes an initializer list.
+
2014-01-11 Sam Weinig
Fix the EFL build.
Modified: trunk/Source/WTF/wtf/HashSet.h (161800 => 161801)
--- trunk/Source/WTF/wtf/HashSet.h 2014-01-12 05:59:44 UTC (rev 161800)
+++ trunk/Source/WTF/wtf/HashSet.h 2014-01-12 06:30:10 UTC (rev 161801)
@@ -21,6 +21,7 @@
#ifndef WTF_HashSet_h
#define WTF_HashSet_h
+#include
#include
#include
@@ -49,6 +50,16 @@
typedef HashTableConstIteratorAdapter const_iterator;
typedef typename HashTableType::AddResult AddResult;
+HashSet()
+{
+}
+
+HashSet(std::initializer_list initializerList)
+{
+for (const auto& value : initializerList)
+add(value);
+}
+
void swap(HashSet&);
int size() const;
Modified: trunk/Source/WebCore/ChangeLog (161800 => 161801)
--- trunk/Source/WebCore/ChangeLog 2014-01-12 05:59:44 UTC (rev 161800)
+++ trunk/Source/WebCore/ChangeLog 2014-01-12 06:30:10 UTC (rev 161801)
@@ -1,3 +1,15 @@
+2014-01-11 Anders Carlsson
+
+Use std::call_once instead of AtomicallyInitializedStatic when creating a HTTP header set
+https://bugs.webkit.org/show_bug.cgi?id=126837
+
+Reviewed by Sam Weinig.
+
+Use std::call_once when constructing the HTTPHeaderSet.
+
+* loader/CrossOriginAccessControl.cpp:
+(WebCore::isOnAccessControlResponseHeaderWhitelist):
+
2014-01-11 David Kilzer
[iOS] Do not link to ApplicationServices.framework for iOS
Modified: trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp (161800 => 161801)
--- trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp 2014-01-12 05:59:44 UTC (rev 161800)
+++ trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp 2014-01-12 06:30:10 UTC (rev 161801)
@@ -31,7 +31,7 @@
#include "ResourceRequest.h"
#include "ResourceResponse.h"
#include "SecurityOrigin.h"
-#include
+#include
#include
#include
@@ -76,24 +76,22 @@
return true;
}
-static PassOwnPtr createAllowedCrossOriginResponseHeadersSet()
-{
-OwnPtr headerSet = adoptPtr(new HashSet);
-
-headerSet->add("cache-control");
-headerSet->add("content-language");
-headerSet->add("content-type");
-headerSet->add("expires");
-headerSet->add("last-modified");
-headerSet->add("pragma");
-
-return headerSet.release();
-}
-
bool isOnAccessControlResponseHeaderWhitelist(const String& name)
{
-AtomicallyInitializedStatic(HTTPHeaderSet*, allowedCrossOriginResponseHeaders = createAllowedCrossOriginResponseHeadersSet().leakPtr());
+static std::once_flag onceFlag;
+static HTTPHeaderSet* allowedCrossOriginResponseHeaders;
+std::call_once(onceFlag, []{
+allowedCrossOriginResponseHeaders = std::make_unique>({
+"cache-control",
+"content-language",
+"content-type",
+"expires",
+"last-modified",
+"pragma"
+}).release();
+});
+
return allowedCrossOriginResponseHeaders->contains(name);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161800] trunk/Source/WebCore
Title: [161800] trunk/Source/WebCore
Revision 161800
Author ddkil...@apple.com
Date 2014-01-11 21:59:44 -0800 (Sat, 11 Jan 2014)
Log Message
[iOS] Do not link to ApplicationServices.framework for iOS
Reviewed by Dan Bernstein.
* Configurations/WebCore.xcconfig:
(OTHER_LDFLAGS_macosx): Add -framework ApplicationServices.
* WebCore.xcodeproj/project.pbxproj: Remove reference to
ApplicationServices.framework.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (161799 => 161800)
--- trunk/Source/WebCore/ChangeLog 2014-01-12 05:27:21 UTC (rev 161799)
+++ trunk/Source/WebCore/ChangeLog 2014-01-12 05:59:44 UTC (rev 161800)
@@ -1,5 +1,17 @@
2014-01-11 David Kilzer
+[iOS] Do not link to ApplicationServices.framework for iOS
+
+
+Reviewed by Dan Bernstein.
+
+* Configurations/WebCore.xcconfig:
+(OTHER_LDFLAGS_macosx): Add -framework ApplicationServices.
+* WebCore.xcodeproj/project.pbxproj: Remove reference to
+ApplicationServices.framework.
+
+2014-01-11 David Kilzer
+
[iOS] Build fix for StyleResolver.cpp
* rendering/style/RenderStyle.h:
Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (161799 => 161800)
--- trunk/Source/WebCore/Configurations/WebCore.xcconfig 2014-01-12 05:27:21 UTC (rev 161799)
+++ trunk/Source/WebCore/Configurations/WebCore.xcconfig 2014-01-12 05:59:44 UTC (rev 161800)
@@ -73,7 +73,7 @@
OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_$(PLATFORM_NAME));
OTHER_LDFLAGS_iphoneos = $(OTHER_LDFLAGS_iphonesimulator) -framework IOSurface;
OTHER_LDFLAGS_iphonesimulator = $(OTHER_LDFLAGS_BASE) -framework Accelerate -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework GraphicsServices -framework ImageIO -framework OpenGLES -framework QuartzCore -lMobileGestalt;
-OTHER_LDFLAGS_macosx = $(OTHER_LDFLAGS_BASE) -sub_library libobjc -umbrella WebKit -allowable_client WebKit2 -framework IOSurface;
+OTHER_LDFLAGS_macosx = $(OTHER_LDFLAGS_BASE) -sub_library libobjc -umbrella WebKit -allowable_client WebKit2 -framework ApplicationServices -framework IOSurface;
NORMAL_WEBCORE_FRAMEWORKS_DIR = $(NORMAL_WEBCORE_FRAMEWORKS_DIR_$(PLATFORM_NAME));
NORMAL_WEBCORE_FRAMEWORKS_DIR_iphoneos = $(PRODUCTION_FRAMEWORKS_DIR);
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (161799 => 161800)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-01-12 05:27:21 UTC (rev 161799)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-01-12 05:59:44 UTC (rev 161800)
@@ -3231,7 +3231,6 @@
93F19B0408245E59001E9ABC /* XSLTProcessor.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC06F24B06D18A7E004A6FA3 /* XSLTProcessor.cpp */; };
93F19B0508245E59001E9ABC /* XSLTProcessorLibxslt.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC06F24D06D18A7E004A6FA3 /* XSLTProcessorLibxslt.cpp */; };
93F19B0708245E59001E9ABC /* WebCoreView.m in Sources */ = {isa = PBXBuildFile; fileRef = BE8560510701F91100239769 /* WebCoreView.m */; };
- 93F19B1308245E59001E9ABC /* ApplicationServices.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = F5C2869302846DCD018635CA /* ApplicationServices.framework */; };
93F19B1408245E59001E9ABC /* Carbon.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = F5C2869402846DCD018635CA /* Carbon.framework */; };
93F19B1508245E59001E9ABC /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = F5C2869502846DCD018635CA /* Cocoa.framework */; };
93F19B1608245E59001E9ABC /* _javascript_Core.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = F8216299029F4FB501000131 /* _javascript_Core.framework */; };
@@ -13517,7 +13516,6 @@
F5C041E00FFCA96D00839D4A /* DOMHTMLDataListElementInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMHTMLDataListElementInternal.h; sourceTree = ""; };
F5C041E10FFCA96D00839D4A /* JSHTMLDataListElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLDataListElement.cpp; sourceTree = ""; };
F5C041E20FFCA96D00839D4A /* JSHTMLDataListElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSHTMLDataListElement.h; sourceTree = ""; };
- F5C2869302846DCD018635CA /* ApplicationServices.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = ApplicationServices.framework; path = /System/Library/Frameworks/ApplicationServices.framework; sourceTree = ""; };
F5C2869402846DCD018635CA /* Carbon.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Carbon.framework; path = /System/Library/Frameworks/Carbon.framework; sourceTree = ""; };
F5C2869502846DCD01863
[webkit-changes] [161799] trunk/Source/WebCore
Title: [161799] trunk/Source/WebCore
Revision 161799
Author ddkil...@apple.com
Date 2014-01-11 21:27:21 -0800 (Sat, 11 Jan 2014)
Log Message
[iOS] Build fix for StyleResolver.cpp
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setCompositionFillColor): Added.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (161798 => 161799)
--- trunk/Source/WebCore/ChangeLog 2014-01-12 04:56:31 UTC (rev 161798)
+++ trunk/Source/WebCore/ChangeLog 2014-01-12 05:27:21 UTC (rev 161799)
@@ -1,5 +1,12 @@
2014-01-11 David Kilzer
+[iOS] Build fix for StyleResolver.cpp
+
+* rendering/style/RenderStyle.h:
+(WebCore::RenderStyle::setCompositionFillColor): Added.
+
+2014-01-11 David Kilzer
+
[iOS] Fix build of RenderLayerCompositor::registerAllViewportConstrainedLayers()
* rendering/RenderLayerCompositor.cpp:
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (161798 => 161799)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2014-01-12 04:56:31 UTC (rev 161798)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2014-01-12 05:27:21 UTC (rev 161799)
@@ -1455,6 +1455,7 @@
#endif
#if PLATFORM(IOS)
void setTouchCalloutEnabled(bool v) { SET_VAR(rareInheritedData, touchCalloutEnabled, v); }
+void setCompositionFillColor(const Color &c) { SET_VAR(rareInheritedData, compositionFillColor, c); }
#endif
#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
void setUseTouchOverflowScrolling(bool v) { SET_VAR(rareInheritedData, useTouchOverflowScrolling, v); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161798] trunk/Source/WebCore
Title: [161798] trunk/Source/WebCore
Revision 161798
Author ddkil...@apple.com
Date 2014-01-11 20:56:31 -0800 (Sat, 11 Jan 2014)
Log Message
[iOS] Fix build of RenderLayerCompositor::registerAllViewportConstrainedLayers()
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
Fix use of std::make_unique<>() and add an adoptPtr() call.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (161797 => 161798)
--- trunk/Source/WebCore/ChangeLog 2014-01-12 04:33:34 UTC (rev 161797)
+++ trunk/Source/WebCore/ChangeLog 2014-01-12 04:56:31 UTC (rev 161798)
@@ -1,3 +1,11 @@
+2014-01-11 David Kilzer
+
+[iOS] Fix build of RenderLayerCompositor::registerAllViewportConstrainedLayers()
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
+Fix use of std::make_unique<>() and add an adoptPtr() call.
+
2014-01-11 Alexey Proskuryakov
[Mac] [Windows] Stop scheduling network requests in WebCore
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (161797 => 161798)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2014-01-12 04:33:34 UTC (rev 161797)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2014-01-12 04:56:31 UTC (rev 161798)
@@ -3500,16 +3500,16 @@
std::unique_ptr constraints;
if (layer.renderer().isStickyPositioned()) {
-constraints = std::make_unique(new StickyPositionViewportConstraints(computeStickyViewportConstraints(layer)));
+constraints = std::make_unique(computeStickyViewportConstraints(layer));
const RenderLayer* enclosingTouchScrollableLayer = nullptr;
if (isStickyInAcceleratedScrollingLayerOrViewport(layer, &enclosingTouchScrollableLayer) && enclosingTouchScrollableLayer) {
ASSERT(enclosingTouchScrollableLayer->isComposited());
stickyContainerMap.add(layer.backing()->graphicsLayer()->platformLayer(), enclosingTouchScrollableLayer->backing()->scrollingLayer()->platformLayer());
}
} else
-constraints = std::make_unique(new FixedPositionViewportConstraints(computeFixedViewportConstraints(layer)));
+constraints = std::make_unique(computeFixedViewportConstraints(layer));
-layerMap.add(layer.backing()->graphicsLayer()->platformLayer(), constraints.release());
+layerMap.add(layer.backing()->graphicsLayer()->platformLayer(), adoptPtr(constraints.release()));
}
if (ChromeClient* client = this->chromeClient())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161797] trunk/Source/WTF
Title: [161797] trunk/Source/WTF
Revision 161797
Author wei...@apple.com
Date 2014-01-11 20:33:34 -0800 (Sat, 11 Jan 2014)
Log Message
Fix the EFL build.
* wtf/IteratorAdaptors.h:
(WTF::TransformIterator::operator*):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/IteratorAdaptors.h
Diff
Modified: trunk/Source/WTF/ChangeLog (161796 => 161797)
--- trunk/Source/WTF/ChangeLog 2014-01-12 04:20:13 UTC (rev 161796)
+++ trunk/Source/WTF/ChangeLog 2014-01-12 04:33:34 UTC (rev 161797)
@@ -1,5 +1,12 @@
2014-01-11 Sam Weinig
+Fix the EFL build.
+
+* wtf/IteratorAdaptors.h:
+(WTF::TransformIterator::operator*):
+
+2014-01-11 Sam Weinig
+
Add support for null StringViews
https://bugs.webkit.org/show_bug.cgi?id=126827
Modified: trunk/Source/WTF/wtf/IteratorAdaptors.h (161796 => 161797)
--- trunk/Source/WTF/wtf/IteratorAdaptors.h 2014-01-12 04:20:13 UTC (rev 161796)
+++ trunk/Source/WTF/wtf/IteratorAdaptors.h 2014-01-12 04:33:34 UTC (rev 161797)
@@ -87,7 +87,7 @@
return *this;
}
-const decltype(std::declval()(*std::declval())) operator*() const
+decltype(std::declval()(*std::declval())) operator*() const
{
return m_transform(*m_iter);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161795] trunk/Source/WebCore
Title: [161795] trunk/Source/WebCore
Revision 161795
Author ddkil...@apple.com
Date 2014-01-11 20:13:43 -0800 (Sat, 11 Jan 2014)
Log Message
[iOS] Fix build failure in WebCore::findEndWordBoundary()
Filed Bug 126830 for the proper fix:
* editing/VisibleUnits.cpp:
(WebCore::endWordBoundary): Switch back to using
WebCore::findWordBoundary() on iOS.
* platform/text/mac/TextBoundaries.mm:
(WebCore::findEndWordBoundary): Add FIXME for iOS implementation
that doesn't use NSAttributedString.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/VisibleUnits.cpp
trunk/Source/WebCore/platform/text/mac/TextBoundaries.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (161794 => 161795)
--- trunk/Source/WebCore/ChangeLog 2014-01-12 03:53:39 UTC (rev 161794)
+++ trunk/Source/WebCore/ChangeLog 2014-01-12 04:13:43 UTC (rev 161795)
@@ -1,3 +1,18 @@
+2014-01-11 David Kilzer
+
+[iOS] Fix build failure in WebCore::findEndWordBoundary()
+
+Filed Bug 126830 for the proper fix:
+
+
+* editing/VisibleUnits.cpp:
+(WebCore::endWordBoundary): Switch back to using
+WebCore::findWordBoundary() on iOS.
+
+* platform/text/mac/TextBoundaries.mm:
+(WebCore::findEndWordBoundary): Add FIXME for iOS implementation
+that doesn't use NSAttributedString.
+
2014-01-11 Andy Estes
[iOS] Move text autosizing code from RenderBlock to RenderBlockFlow
Modified: trunk/Source/WebCore/editing/VisibleUnits.cpp (161794 => 161795)
--- trunk/Source/WebCore/editing/VisibleUnits.cpp 2014-01-12 03:53:39 UTC (rev 161794)
+++ trunk/Source/WebCore/editing/VisibleUnits.cpp 2014-01-12 04:13:43 UTC (rev 161795)
@@ -658,8 +658,14 @@
return length;
}
needMoreContext = false;
+#if PLATFORM(IOS)
+// FIXME: Bug 126830: [iOS] Implement WebCore::findEndWordBoundary()
+int start, end;
+findWordBoundary(characters, length, offset, &start, &end);
+#else
int end;
findEndWordBoundary(characters, length, offset, &end);
+#endif
return end;
}
Modified: trunk/Source/WebCore/platform/text/mac/TextBoundaries.mm (161794 => 161795)
--- trunk/Source/WebCore/platform/text/mac/TextBoundaries.mm 2014-01-12 03:53:39 UTC (rev 161794)
+++ trunk/Source/WebCore/platform/text/mac/TextBoundaries.mm 2014-01-12 04:13:43 UTC (rev 161795)
@@ -247,6 +247,7 @@
void findEndWordBoundary(const UChar* chars, int len, int position, int* end)
{
+#if !PLATFORM(IOS)
NSString* string = [[NSString alloc] initWithCharactersNoCopy:const_cast(chars)
length:len freeWhenDone:NO];
NSAttributedString* attr = [[NSAttributedString alloc] initWithString:string];
@@ -254,6 +255,13 @@
[attr release];
[string release];
*end = range.location + range.length;
+#else
+// FIXME: Bug 126830: [iOS] Implement WebCore::findEndWordBoundary()
+UNUSED_PARAM(chars);
+UNUSED_PARAM(len);
+UNUSED_PARAM(position);
+UNUSED_PARAM(end);
+#endif
}
int findNextWordFromIndex(const UChar* chars, int len, int position, bool forward)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161794] trunk/LayoutTests
Title: [161794] trunk/LayoutTests Revision 161794 Author bfulg...@apple.com Date 2014-01-11 19:53:39 -0800 (Sat, 11 Jan 2014) Log Message [WebGL] Correct uniform input validation for texture sampler uniforms https://bugs.webkit.org/show_bug.cgi?id=126775 Reviewed by Anders Carlsson. * fast/canvas/webgl/uniform-samplers-test-expected.txt: Added. * fast/canvas/webgl/uniform-samplers-test.html: Corrected resource includes when moving from khronos suite to our fast suite. * resources/js-test-pre.js: (expectTrue): Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/canvas/webgl/uniform-samplers-test.html trunk/LayoutTests/resources/js-test-pre.js Added Paths trunk/LayoutTests/fast/canvas/webgl/uniform-samplers-test-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (161793 => 161794) --- trunk/LayoutTests/ChangeLog 2014-01-12 03:23:25 UTC (rev 161793) +++ trunk/LayoutTests/ChangeLog 2014-01-12 03:53:39 UTC (rev 161794) @@ -1,3 +1,16 @@ +2014-01-11 Brent Fulgham + +[WebGL] Correct uniform input validation for texture sampler uniforms +https://bugs.webkit.org/show_bug.cgi?id=126775 + +Reviewed by Anders Carlsson. + +* fast/canvas/webgl/uniform-samplers-test-expected.txt: Added. +* fast/canvas/webgl/uniform-samplers-test.html: Corrected resource +includes when moving from khronos suite to our fast suite. +* resources/js-test-pre.js: +(expectTrue): Added. + 2014-01-11 Dean Jackson [JSC] Revise typed array implementations to match ECMAScript and WebGL Specification Added: trunk/LayoutTests/fast/canvas/webgl/uniform-samplers-test-expected.txt (0 => 161794) --- trunk/LayoutTests/fast/canvas/webgl/uniform-samplers-test-expected.txt (rev 0) +++ trunk/LayoutTests/fast/canvas/webgl/uniform-samplers-test-expected.txt 2014-01-12 03:53:39 UTC (rev 161794) @@ -0,0 +1,17 @@ +Tests that only Uniform1i and Uniform1iv can be used to setsampler uniforms. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + +PASS getError was expected value: NO_ERROR : uniform1i can set a sampler uniform +PASS getError was expected value: NO_ERROR : uniform1iv can set a sampler uniform +PASS getError was expected value: NO_ERROR : uniform1iv can set a sampler uniform +PASS getError was expected value: INVALID_OPERATION : uniform1f returns INVALID_OPERATION if attempting to set a sampler uniform +PASS getError was expected value: INVALID_OPERATION : uniform1fv returns INVALID_OPERATION if attempting to set a sampler uniform +PASS uniform1i works for any valid texture unit +PASS uniform1iv works for any valid texture unit +PASS uniform1i generates INVALID_VALUE for invalid texture units +PASS uniform1iv generates INVALID_VALUE for invalid texture units +PASS successfullyParsed is true + +TEST COMPLETE + Modified: trunk/LayoutTests/fast/canvas/webgl/uniform-samplers-test.html (161793 => 161794) --- trunk/LayoutTests/fast/canvas/webgl/uniform-samplers-test.html 2014-01-12 03:23:25 UTC (rev 161793) +++ trunk/LayoutTests/fast/canvas/webgl/uniform-samplers-test.html 2014-01-12 03:53:39 UTC (rev 161794) @@ -1,39 +1,10 @@ - - - WebGL sampler uniforms conformance test. - -+