[webkit-changes] [163523] trunk/Source
Title: [163523] trunk/Source Revision 163523 Author bshaf...@apple.com Date 2014-02-06 00:03:55 -0800 (Thu, 06 Feb 2014) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (163522 => 163523) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2014-02-06 08:00:58 UTC (rev 163522) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2014-02-06 08:03:55 UTC (rev 163523) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 17; +MINOR_VERSION = 18; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (163522 => 163523) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2014-02-06 08:00:58 UTC (rev 163522) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2014-02-06 08:03:55 UTC (rev 163523) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 17; +MINOR_VERSION = 18; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (163522 => 163523) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-02-06 08:00:58 UTC (rev 163522) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-02-06 08:03:55 UTC (rev 163523) @@ -1,5 +1,5 @@ MAJOR_VERSION = 538; -MINOR_VERSION = 17; +MINOR_VERSION = 18; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (163522 => 163523) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2014-02-06 08:00:58 UTC (rev 163522) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2014-02-06 08:03:55 UTC (rev 163523) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 17; +MINOR_VERSION = 18; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (163522 => 163523) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2014-02-06 08:00:58 UTC (rev 163522) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2014-02-06 08:03:55 UTC (rev 163523) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 17; +MINOR_VERSION = 18; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163522] tags/Safari-538.17/
Title: [163522] tags/Safari-538.17/ Revision 163522 Author bshaf...@apple.com Date 2014-02-06 00:00:58 -0800 (Thu, 06 Feb 2014) Log Message New tag. Added Paths tags/Safari-538.17/ Diff Property changes: tags/Safari-538.17 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163521] trunk/Source/WebKit2
Title: [163521] trunk/Source/WebKit2 Revision 163521 Author zandober...@gmail.com Date 2014-02-05 23:59:07 -0800 (Wed, 05 Feb 2014) Log Message Unreviewed GTK build fix after r163480. * GNUmakefile.list.am: Removing the WebUIClient build targets. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.list.am Diff Modified: trunk/Source/WebKit2/ChangeLog (163520 => 163521) --- trunk/Source/WebKit2/ChangeLog 2014-02-06 07:58:22 UTC (rev 163520) +++ trunk/Source/WebKit2/ChangeLog 2014-02-06 07:59:07 UTC (rev 163521) @@ -1,3 +1,9 @@ +2014-02-05 Zan Dobersek + +Unreviewed GTK build fix after r163480. + +* GNUmakefile.list.am: Removing the WebUIClient build targets. + 2014-02-05 Simon Fraser Transfer the non-fast-scrollable region to the UI process for iOS Modified: trunk/Source/WebKit2/GNUmakefile.list.am (163520 => 163521) --- trunk/Source/WebKit2/GNUmakefile.list.am 2014-02-06 07:58:22 UTC (rev 163520) +++ trunk/Source/WebKit2/GNUmakefile.list.am 2014-02-06 07:59:07 UTC (rev 163521) @@ -982,8 +982,6 @@ Source/WebKit2/UIProcess/WebTextChecker.h \ Source/WebKit2/UIProcess/WebTextCheckerClient.cpp \ Source/WebKit2/UIProcess/WebTextCheckerClient.h \ - Source/WebKit2/UIProcess/WebUIClient.cpp \ - Source/WebKit2/UIProcess/WebUIClient.h \ Source/WebKit2/UIProcess/InspectorServer/HTTPRequest.cpp \ Source/WebKit2/UIProcess/InspectorServer/HTTPRequest.h \ Source/WebKit2/UIProcess/InspectorServer/WebInspectorServer.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163520] trunk/Tools
Title: [163520] trunk/Tools
Revision 163520
Author abu...@adobe.com
Date 2014-02-05 23:58:22 -0800 (Wed, 05 Feb 2014)
Log Message
Adding myself as a reviewer.
Unreviewed.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (163519 => 163520)
--- trunk/Tools/ChangeLog 2014-02-06 07:49:15 UTC (rev 163519)
+++ trunk/Tools/ChangeLog 2014-02-06 07:58:22 UTC (rev 163520)
@@ -1,3 +1,11 @@
+2014-02-06 Andrei Bucur
+
+Adding myself as a reviewer.
+
+Unreviewed.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2014-02-05 Zan Dobersek
Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (163519 => 163520)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-02-06 07:49:15 UTC (rev 163519)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-02-06 07:58:22 UTC (rev 163520)
@@ -3320,6 +3320,15 @@
"kling"
]
},
+ "Andrei Bucur" : {
+ "emails" : [
+"abu...@adobe.com"
+ ],
+ "expertise" : "CSS Regions, CSS Fragmentation, Layout and rendering",
+ "nicks" : [
+"abucur"
+ ]
+ },
"Andy Estes" : {
"emails" : [
"aes...@apple.com"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163519] trunk
Title: [163519] trunk
Revision 163519
Author zandober...@gmail.com
Date 2014-02-05 23:49:15 -0800 (Wed, 05 Feb 2014)
Log Message
Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro
https://bugs.webkit.org/show_bug.cgi?id=128267
Reviewed by Andreas Kling.
Source/WTF:
Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro that was manually defined for compilers
that support the C++11 initializer lists. The feature is well supported in Clang, MSVC and also GCC. It
was actually already used unguarded in HashSet.
* wtf/Compiler.h:
* wtf/HashMap.h:
(WTF::HashMap::HashMap):
* wtf/Vector.h:
(WTF::Vector::Vector):
Tools:
Remove the COMPILER_SUPPORTS(CXX_GENERALIZED_INITIALIZERS) as the underlying macro is also
being removed since the feature is supported by all the compilers the project approves.
* TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Compiler.h
trunk/Source/WTF/wtf/HashMap.h
trunk/Source/WTF/wtf/Vector.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (163518 => 163519)
--- trunk/Source/WTF/ChangeLog 2014-02-06 07:24:27 UTC (rev 163518)
+++ trunk/Source/WTF/ChangeLog 2014-02-06 07:49:15 UTC (rev 163519)
@@ -1,3 +1,20 @@
+2014-02-05 Zan Dobersek
+
+Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro
+https://bugs.webkit.org/show_bug.cgi?id=128267
+
+Reviewed by Andreas Kling.
+
+Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro that was manually defined for compilers
+that support the C++11 initializer lists. The feature is well supported in Clang, MSVC and also GCC. It
+was actually already used unguarded in HashSet.
+
+* wtf/Compiler.h:
+* wtf/HashMap.h:
+(WTF::HashMap::HashMap):
+* wtf/Vector.h:
+(WTF::Vector::Vector):
+
2014-02-05 Andreas Kling
Remove ENABLE(DIRECTORY_UPLOAD).
Modified: trunk/Source/WTF/wtf/Compiler.h (163518 => 163519)
--- trunk/Source/WTF/wtf/Compiler.h 2014-02-06 07:24:27 UTC (rev 163518)
+++ trunk/Source/WTF/wtf/Compiler.h 2014-02-06 07:49:15 UTC (rev 163519)
@@ -44,7 +44,6 @@
#define WTF_COMPILER_SUPPORTS_BLOCKS __has_feature(blocks)
#define WTF_COMPILER_SUPPORTS_C_STATIC_ASSERT __has_feature(c_static_assert)
#define WTF_COMPILER_SUPPORTS_CXX_CONSTEXPR __has_feature(cxx_constexpr)
-#define WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS __has_feature(cxx_generalized_initializers)
#define WTF_COMPILER_SUPPORTS_CXX_REFERENCE_QUALIFIED_FUNCTIONS __has_feature(cxx_reference_qualified_functions)
#define WTF_COMPILER_SUPPORTS_CXX_USER_LITERALS __has_feature(cxx_user_literals)
#define WTF_COMPILER_SUPPORTS_FALLTHROUGH_WARNINGS __has_feature(cxx_attributes) && __has_warning("-Wimplicit-fallthrough")
@@ -106,7 +105,6 @@
#if defined(_MSC_VER)
#define WTF_COMPILER_MSVC 1
-#define WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS 1
#endif
#if defined(_MSC_VER) && _MSC_VER < 1800
Modified: trunk/Source/WTF/wtf/HashMap.h (163518 => 163519)
--- trunk/Source/WTF/wtf/HashMap.h 2014-02-06 07:24:27 UTC (rev 163518)
+++ trunk/Source/WTF/wtf/HashMap.h 2014-02-06 07:49:15 UTC (rev 163519)
@@ -21,6 +21,7 @@
#ifndef WTF_HashMap_h
#define WTF_HashMap_h
+#include
#include
#include
@@ -72,13 +73,11 @@
{
}
-#if COMPILER_SUPPORTS(CXX_GENERALIZED_INITIALIZERS)
HashMap(std::initializer_list initializerList)
{
for (const auto& keyValuePair : initializerList)
add(keyValuePair.key, keyValuePair.value);
}
-#endif
void swap(HashMap&);
Modified: trunk/Source/WTF/wtf/Vector.h (163518 => 163519)
--- trunk/Source/WTF/wtf/Vector.h 2014-02-06 07:24:27 UTC (rev 163518)
+++ trunk/Source/WTF/wtf/Vector.h 2014-02-06 07:49:15 UTC (rev 163519)
@@ -21,6 +21,7 @@
#ifndef WTF_Vector_h
#define WTF_Vector_h
+#include
#include
#include
#include
@@ -548,14 +549,12 @@
TypeOperations::uninitializedFill(begin(), end(), val);
}
-#if COMPILER_SUPPORTS(CXX_GENERALIZED_INITIALIZERS)
Vector(std::initializer_list initializerList)
{
reserveInitialCapacity(initializerList.size());
for (const auto& element : initializerList)
uncheckedAppend(element);
}
-#endif
~Vector()
{
Modified: trunk/Tools/ChangeLog (163518 => 163519)
--- trunk/Tools/ChangeLog 2014-02-06 07:24:27 UTC (rev 163518)
+++ trunk/Tools/ChangeLog 2014-02-06 07:49:15 UTC (rev 163519)
@@ -1,3 +1,18 @@
+2014-02-05 Zan Dobersek
+
+Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro
+https://bugs.webkit.org/show_bug.cgi?id=128267
+
+Reviewed by Andreas Kling.
+
+Remove the COMPILER_SUPPORTS(CXX_GENERALIZED_INITIALIZER
[webkit-changes] [163517] trunk/Source/JavaScriptCore
Title: [163517] trunk/Source/_javascript_Core
Revision 163517
Author fpi...@apple.com
Date 2014-02-05 23:11:48 -0800 (Wed, 05 Feb 2014)
Log Message
Make FTL OSR entry something we only try after we've already compiled the function with the FTL and it still got stuck in a loop after that without ever returning like a sensible function oughta have
https://bugs.webkit.org/show_bug.cgi?id=128234
Reviewed by Geoffrey Garen.
Use DFG::JITCode::osrEntryRetry as a counter to decide when to invoke OSR entry. That
comes into play only after we've done a replacement compile.
This appears to still give us a speed-up on the kinds of things that OSR entry is good
for, while also eliminating pointless OSR entry compilations on other things.
* dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::JITCode):
* dfg/DFGJITCode.h:
* dfg/DFGOperations.cpp:
* dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):
* runtime/Options.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCode.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCode.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp
trunk/Source/_javascript_Core/runtime/Options.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163516 => 163517)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-06 06:55:20 UTC (rev 163516)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-06 07:11:48 UTC (rev 163517)
@@ -1,5 +1,26 @@
2014-02-04 Filip Pizlo
+Make FTL OSR entry something we only try after we've already compiled the function with the FTL and it still got stuck in a loop after that without ever returning like a sensible function oughta have
+https://bugs.webkit.org/show_bug.cgi?id=128234
+
+Reviewed by Geoffrey Garen.
+
+Use DFG::JITCode::osrEntryRetry as a counter to decide when to invoke OSR entry. That
+comes into play only after we've done a replacement compile.
+
+This appears to still give us a speed-up on the kinds of things that OSR entry is good
+for, while also eliminating pointless OSR entry compilations on other things.
+
+* dfg/DFGJITCode.cpp:
+(JSC::DFG::JITCode::JITCode):
+* dfg/DFGJITCode.h:
+* dfg/DFGOperations.cpp:
+* dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
+(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):
+* runtime/Options.h:
+
+2014-02-04 Filip Pizlo
+
Don't speculate on ToThis if we already know that arg0 has a questionable record with structure checks
https://bugs.webkit.org/show_bug.cgi?id=128229
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCode.cpp (163516 => 163517)
--- trunk/Source/_javascript_Core/dfg/DFGJITCode.cpp 2014-02-06 06:55:20 UTC (rev 163516)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCode.cpp 2014-02-06 07:11:48 UTC (rev 163517)
@@ -34,6 +34,10 @@
JITCode::JITCode()
: DirectJITCode(DFGJIT)
+#if ENABLE(FTL_JIT)
+, osrEntryRetry(0)
+, abandonOSREntry(false)
+#endif // ENABLE(FTL_JIT)
{
}
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCode.h (163516 => 163517)
--- trunk/Source/_javascript_Core/dfg/DFGJITCode.h 2014-02-06 06:55:20 UTC (rev 163516)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCode.h 2014-02-06 07:11:48 UTC (rev 163517)
@@ -125,6 +125,8 @@
#if ENABLE(FTL_JIT)
ExecutionCounter tierUpCounter;
RefPtr osrEntryBlock;
+unsigned osrEntryRetry;
+bool abandonOSREntry;
#endif // ENABLE(FTL_JIT)
};
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (163516 => 163517)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2014-02-06 06:55:20 UTC (rev 163516)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2014-02-06 07:11:48 UTC (rev 163517)
@@ -1113,21 +1113,8 @@
}
#if ENABLE(FTL_JIT)
-void JIT_OPERATION triggerTierUpNow(ExecState* exec)
+static void triggerFTLReplacementCompile(VM* vm, CodeBlock* codeBlock, JITCode* jitCode)
{
-VM* vm = &exec->vm();
-NativeCallFrameTracer tracer(vm, exec);
-DeferGC deferGC(vm->heap);
-CodeBlock* codeBlock = exec->codeBlock();
-
-JITCode* jitCode = codeBlock->jitCode()->dfg();
-
-if (Options::verboseOSR()) {
-dataLog(
-*codeBlock, ": Entered triggerTierUpNow with executeCounter = ",
-jitCode->tierUpCounter, "\n");
-}
-
if (codeBlock->baselineVersion()->m_didFailFTLCompilation) {
if (Options::verboseOSR())
dataLog("Deferring FTL-optimization of ", *codeBlock, " indefinitely because there was an FTL failure.\n");
@@ -1175,6 +1162,24 @@
Operands(), ToFTLDeferredCompilationCallback::create(codeBlock));
}
+void JIT_OPERATION triggerTierUpNow(ExecState* exec)
+{
+VM* vm =
[webkit-changes] [163516] trunk/Source
Title: [163516] trunk/Source Revision 163516 Author simon.fra...@apple.com Date 2014-02-05 22:55:20 -0800 (Wed, 05 Feb 2014) Log Message Transfer the non-fast-scrollable region to the UI process for iOS https://bugs.webkit.org/show_bug.cgi?id=128293 Reviewed by Benjamin Poulain. Source/WebCore: Two main changes to support sending the non-fast scrollable region to the UI process for iOS: 1. Add ScrollingCoordinator::frameViewNonFastScrollableRegionChanged(), which is called when we've updated the touch event region (this can happen independenly of layout). When called we just scheduled a scrolling tree commit with the new region. 2. Avoid thinking that we have a new root node with every remote scrolling transaction. This was a side-effect of reconstructing the scrolling state tree in the UI process, and caused us to try to grab a nonFastScrollableRegion from a node which never had one set. * WebCore.exp.in: * page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged): * page/scrolling/AsyncScrollingCoordinator.h: * page/scrolling/ScrollingCoordinator.cpp: (WebCore::ScrollingCoordinator::computeNonFastScrollableRegion): * page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::frameViewNonFastScrollableRegionChanged): * page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::setHasNewRootStateNode): * page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::commitNewTreeState): (WebCore::ScrollingTree::isPointInNonFastScrollableRegion): * page/scrolling/ScrollingTree.h: Source/WebKit2: Two main changes to support sending the non-fast scrollable region to the UI process for iOS: 1. Add ScrollingCoordinator::frameViewNonFastScrollableRegionChanged(), which is called when we've updated the touch event region (this can happen independenly of layout). When called we just scheduled a scrolling tree commit with the new region. 2. Avoid thinking that we have a new root node with every remote scrolling transaction. This was a side-effect of reconstructing the scrolling state tree in the UI process, and caused us to try to grab a nonFastScrollableRegion from a node which never had one set. Now that we have the non-fast scrollable region in the UI process, we can use it to avoid sending sync messages to the web process. * Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp: (ArgumentCoder::encode): Encode hasNewRootNode. (ArgumentCoder::decode): Decode hasNewRootNode and set it on the state tree. (WebKit::RemoteScrollingCoordinatorTransaction::encode): Encode the nonFastScrollableRegion now that we can encode Regions. (WebKit::RemoteScrollingCoordinatorTransaction::decode): Decode the nonFastScrollableRegion now that we can decode Regions. * UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::isPointInNonFastScrollableRegion): * UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleTouchEvent): If we're not in the non-fast scrollable region, don't both sending touch events to the web process. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h trunk/Source/WebCore/page/scrolling/ScrollingStateTree.h trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp trunk/Source/WebCore/page/scrolling/ScrollingTree.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm trunk/Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp trunk/Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h Diff Modified: trunk/Source/WebCore/ChangeLog (163515 => 163516) --- trunk/Source/WebCore/ChangeLog 2014-02-06 06:45:41 UTC (rev 163515) +++ trunk/Source/WebCore/ChangeLog 2014-02-06 06:55:20 UTC (rev 163516) @@ -1,3 +1,38 @@ +2014-02-05 Simon Fraser + +Transfer the non-fast-scrollable region to the UI process for iOS +https://bugs.webkit.org/show_bug.cgi?id=128293 + +Reviewed by Benjamin Poulain. + +Two main changes to support sending the non-fast scrollable region +to the UI process for iOS: + +1. Add ScrollingCoordinator::frameViewNonFastScrollableRegionChanged(), +which is called when we've updated the touch event region (this can happen +indep
[webkit-changes] [163514] trunk/Source/WebKit2
Title: [163514] trunk/Source/WebKit2
Revision 163514
Author benja...@webkit.org
Date 2014-02-05 22:19:16 -0800 (Wed, 05 Feb 2014)
Log Message
[WK2] Add the minimumLayoutSizeOverride SPI to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=128295
Patch by Benjamin Poulain on 2014-02-05
Reviewed by Anders Carlsson.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView minimumLayoutSizeOverride]):
(-[WKWebView setMinimumLayoutSizeOverride:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h: Added.
* WebKit2.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163513 => 163514)
--- trunk/Source/WebKit2/ChangeLog 2014-02-06 05:26:57 UTC (rev 163513)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-06 06:19:16 UTC (rev 163514)
@@ -1,3 +1,16 @@
+2014-02-05 Benjamin Poulain
+
+[WK2] Add the minimumLayoutSizeOverride SPI to WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=128295
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView minimumLayoutSizeOverride]):
+(-[WKWebView setMinimumLayoutSizeOverride:]):
+* UIProcess/API/Cocoa/WKWebViewPrivate.h: Added.
+* WebKit2.xcodeproj/project.pbxproj:
+
2014-02-05 Simon Fraser
Support encoding and decoding of Regions
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (163513 => 163514)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-02-06 05:26:57 UTC (rev 163513)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-02-06 06:19:16 UTC (rev 163514)
@@ -363,6 +363,22 @@
[_scrollView setContentOffset:contentOffset];
}
+#pragma mark Private API
+
+- (CGSize)_minimumLayoutSizeOverride
+{
+ASSERT(_hasStaticMinimumLayoutSize);
+return [_viewportHandler availableViewSize];
+}
+
+- (void)_setMinimumLayoutSizeOverride:(CGSize)minimumLayoutSizeOverride
+{
+_hasStaticMinimumLayoutSize = YES;
+[_viewportHandler update:^{
+[_viewportHandler setAvailableViewSize:minimumLayoutSizeOverride];
+}];
+}
+
#endif
#pragma mark OS X-specific methods
Added: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h (0 => 163514)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h (rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h 2014-02-06 06:19:16 UTC (rev 163514)
@@ -0,0 +1,38 @@
+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import
+
+#if WK_API_ENABLED
+
+@interface WKWebView (WKPrivate)
+
+#if TARGET_OS_IPHONE
+@property (nonatomic, setter=_setMinimumLayoutSizeOverride) CGSize _minimumLayoutSizeOverride;
+#endif
+
+@end
+
+#endif
Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (163513 => 163514)
--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2014-02-06 05:26:57 UTC (rev 163513)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2014-02-06 06:19:16 UTC (rev 163514)
@@ -400,6 +400,7 @@
1FB00AC9185F76460019142E /* WKWebProcessPlugInPageGroupInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 1FB00AC6185F76460019142E /* WKWebProcessPlugInPageGroupInternal.h */; };
1QQ417CB12C00CCA002BE67B /* TextCheckerCompletion.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CC417C912C00CCA002BE67B /* TextCheckerCompletion.h */; };
1ZZ417EF12C00D87002BE67B /* TextCheckerCompletion.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1BB417C912C0
[webkit-changes] [163513] trunk/Source/JavaScriptCore
Title: [163513] trunk/Source/_javascript_Core
Revision 163513
Author fpi...@apple.com
Date 2014-02-05 21:26:57 -0800 (Wed, 05 Feb 2014)
Log Message
Don't speculate on ToThis if we already know that arg0 has a questionable record with structure checks
https://bugs.webkit.org/show_bug.cgi?id=128229
Reviewed by Geoffrey Garen.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163512 => 163513)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-06 05:14:19 UTC (rev 163512)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-06 05:26:57 UTC (rev 163513)
@@ -1,3 +1,13 @@
+2014-02-04 Filip Pizlo
+
+Don't speculate on ToThis if we already know that arg0 has a questionable record with structure checks
+https://bugs.webkit.org/show_bug.cgi?id=128229
+
+Reviewed by Geoffrey Garen.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+
2014-02-05 Mark Hahnenberg
Handling of opaque roots is wrong in EdenCollections
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (163512 => 163513)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2014-02-06 05:14:19 UTC (rev 163512)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2014-02-06 05:26:57 UTC (rev 163513)
@@ -1970,7 +1970,8 @@
|| cachedStructure->classInfo()->methodTable.toThis != JSObject::info()->methodTable.toThis
|| m_inlineStackTop->m_profiledBlock->couldTakeSlowCase(m_currentIndex)
|| m_inlineStackTop->m_exitProfile.hasExitSite(m_currentIndex, BadCache)
-|| m_inlineStackTop->m_exitProfile.hasExitSite(m_currentIndex, BadCacheWatchpoint)) {
+|| m_inlineStackTop->m_exitProfile.hasExitSite(m_currentIndex, BadCacheWatchpoint)
+|| (op1->op() == GetLocal && op1->variableAccessData()->structureCheckHoistingFailed())) {
setThis(addToGraph(ToThis, op1));
} else {
addToGraph(
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163512] trunk/Source/WebCore
Title: [163512] trunk/Source/WebCore
Revision 163512
Author benja...@webkit.org
Date 2014-02-05 21:14:19 -0800 (Wed, 05 Feb 2014)
Log Message
SelectorCodeGenerator::generateElementHasTagName should match the local name before the namespace
https://bugs.webkit.org/show_bug.cgi?id=128167
Reviewed by Sam Weinig.
The local name is a stricter filter than the namespace, it should always run first.
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasTagName):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/cssjit/SelectorCompiler.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (163511 => 163512)
--- trunk/Source/WebCore/ChangeLog 2014-02-06 05:11:39 UTC (rev 163511)
+++ trunk/Source/WebCore/ChangeLog 2014-02-06 05:14:19 UTC (rev 163512)
@@ -1,5 +1,17 @@
2014-02-05 Benjamin Poulain
+SelectorCodeGenerator::generateElementHasTagName should match the local name before the namespace
+https://bugs.webkit.org/show_bug.cgi?id=128167
+
+Reviewed by Sam Weinig.
+
+The local name is a stricter filter than the namespace, it should always run first.
+
+* cssjit/SelectorCompiler.cpp:
+(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasTagName):
+
+2014-02-05 Benjamin Poulain
+
Add HTMLNames::classAttr as a regular name in SVGElement::isAnimatableAttribute
https://bugs.webkit.org/show_bug.cgi?id=128166
Modified: trunk/Source/WebCore/cssjit/SelectorCompiler.cpp (163511 => 163512)
--- trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2014-02-06 05:11:39 UTC (rev 163511)
+++ trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2014-02-06 05:14:19 UTC (rev 163512)
@@ -813,6 +813,14 @@
LocalRegister qualifiedNameImpl(m_registerAllocator);
m_assembler.loadPtr(Assembler::Address(elementAddressRegister, Element::tagQNameMemoryOffset() + QualifiedName::implMemoryOffset()), qualifiedNameImpl);
+const AtomicString& selectorLocalName = nameToMatch.localName();
+if (selectorLocalName != starAtom) {
+// Generate localName == element->localName().
+LocalRegister constantRegister(m_registerAllocator);
+m_assembler.move(Assembler::TrustedImmPtr(selectorLocalName.impl()), constantRegister);
+failureCases.append(m_assembler.branchPtr(Assembler::NotEqual, Assembler::Address(qualifiedNameImpl, QualifiedName::QualifiedNameImpl::localNameMemoryOffset()), constantRegister));
+}
+
const AtomicString& selectorNamespaceURI = nameToMatch.namespaceURI();
if (selectorNamespaceURI != starAtom) {
// Generate namespaceURI == element->namespaceURI().
@@ -820,14 +828,6 @@
m_assembler.move(Assembler::TrustedImmPtr(selectorNamespaceURI.impl()), constantRegister);
failureCases.append(m_assembler.branchPtr(Assembler::NotEqual, Assembler::Address(qualifiedNameImpl, QualifiedName::QualifiedNameImpl::namespaceMemoryOffset()), constantRegister));
}
-
-const AtomicString& selectorLocalName = nameToMatch.localName();
-if (selectorLocalName != starAtom) {
-// Generate localName == element->localName().
-LocalRegister constantRegister(m_registerAllocator);
-m_assembler.move(Assembler::TrustedImmPtr(selectorLocalName.impl()), constantRegister);
-failureCases.append(m_assembler.branchPtr(Assembler::NotEqual, Assembler::Address(qualifiedNameImpl, QualifiedName::QualifiedNameImpl::localNameMemoryOffset()), constantRegister));
-}
}
void SelectorCodeGenerator::generateElementHasId(Assembler::JumpList& failureCases, const LocalRegister& elementDataAddress, const AtomicString& idToMatch)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163511] trunk/Source/WebCore/ChangeLog
Title: [163511] trunk/Source/WebCore/ChangeLog Revision 163511 Author benja...@webkit.org Date 2014-02-05 21:11:39 -0800 (Wed, 05 Feb 2014) Log Message Add HTMLNames::classAttr as a regular name in SVGElement::isAnimatableAttribute https://bugs.webkit.org/show_bug.cgi?id=128166 Reviewed by Sam Weinig. For historical reasons, classAttr was treated separately. There is no reasons for that anymore. * svg/SVGElement.cpp: (WebCore::SVGElement::isAnimatableAttribute): Modified Paths trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/ChangeLog (163510 => 163511) --- trunk/Source/WebCore/ChangeLog 2014-02-06 05:10:24 UTC (rev 163510) +++ trunk/Source/WebCore/ChangeLog 2014-02-06 05:11:39 UTC (rev 163511) @@ -1,6 +1,6 @@ 2014-02-05 Benjamin Poulain -Add HTMLNames::classAttr has a regular name in SVGElement::isAnimatableAttribute +Add HTMLNames::classAttr as a regular name in SVGElement::isAnimatableAttribute https://bugs.webkit.org/show_bug.cgi?id=128166 Reviewed by Sam Weinig. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163510] trunk/Source/WebCore
Title: [163510] trunk/Source/WebCore
Revision 163510
Author benja...@webkit.org
Date 2014-02-05 21:10:24 -0800 (Wed, 05 Feb 2014)
Log Message
Add HTMLNames::classAttr has a regular name in SVGElement::isAnimatableAttribute
https://bugs.webkit.org/show_bug.cgi?id=128166
Reviewed by Sam Weinig.
For historical reasons, classAttr was treated separately. There is no reasons for that anymore.
* svg/SVGElement.cpp:
(WebCore::SVGElement::isAnimatableAttribute):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (163509 => 163510)
--- trunk/Source/WebCore/ChangeLog 2014-02-06 04:31:46 UTC (rev 163509)
+++ trunk/Source/WebCore/ChangeLog 2014-02-06 05:10:24 UTC (rev 163510)
@@ -1,3 +1,15 @@
+2014-02-05 Benjamin Poulain
+
+Add HTMLNames::classAttr has a regular name in SVGElement::isAnimatableAttribute
+https://bugs.webkit.org/show_bug.cgi?id=128166
+
+Reviewed by Sam Weinig.
+
+For historical reasons, classAttr was treated separately. There is no reasons for that anymore.
+
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::isAnimatableAttribute):
+
2014-02-05 Simon Fraser
Support encoding and decoding of Regions
Modified: trunk/Source/WebCore/svg/SVGElement.cpp (163509 => 163510)
--- trunk/Source/WebCore/svg/SVGElement.cpp 2014-02-06 04:31:46 UTC (rev 163509)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2014-02-06 05:10:24 UTC (rev 163510)
@@ -809,10 +809,11 @@
#ifndef NDEBUG
bool SVGElement::isAnimatableAttribute(const QualifiedName& name) const
{
-DEFINE_STATIC_LOCAL(HashSet, animatableAttributes, ());
+static NeverDestroyed> neverDestroyedAnimatableAttributes;
+HashSet& animatableAttributes = neverDestroyedAnimatableAttributes;
if (animatableAttributes.isEmpty()) {
-animatableAttributes.add(XLinkNames::hrefAttr);
+animatableAttributes.add(HTMLNames::classAttr);
animatableAttributes.add(SVGNames::amplitudeAttr);
animatableAttributes.add(SVGNames::azimuthAttr);
animatableAttributes.add(SVGNames::baseFrequencyAttr);
@@ -905,11 +906,9 @@
animatableAttributes.add(SVGNames::yAttr);
animatableAttributes.add(SVGNames::yChannelSelectorAttr);
animatableAttributes.add(SVGNames::zAttr);
+animatableAttributes.add(XLinkNames::hrefAttr);
}
-if (name == classAttr)
-return true;
-
return animatableAttributes.contains(name);
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163509] trunk/Source
Title: [163509] trunk/Source
Revision 163509
Author simon.fra...@apple.com
Date 2014-02-05 20:31:46 -0800 (Wed, 05 Feb 2014)
Log Message
Support encoding and decoding of Regions
https://bugs.webkit.org/show_bug.cgi?id=128284
Source/WebCore:
Reviewed by Anders Carlsson.
Region changes to make it encodable:
Make Region::Span public and give it a default constructor.
Allow getting and setting of Shape internals, and a way to update
the Region bounds after changing the shape. Also add a way to test
for valid spans and segments.
* platform/graphics/Region.cpp:
(WebCore::Region::Shape::isValid):
(WebCore::Region::updateBoundsFromShape):
* platform/graphics/Region.h:
(WebCore::Region::isValid):
(WebCore::Region::Span::Span):
(WebCore::Region::shapeSegments):
(WebCore::Region::shapeSpans):
(WebCore::Region::setShapeSegments):
(WebCore::Region::setShapeSpans):
(WebCore::Region::Shape::segments):
(WebCore::Region::Shape::spans):
(WebCore::Region::Shape::setSegments):
(WebCore::Region::Shape::setSpans):
Source/WebKit2:
Reviewed by Anders Carlsson.
Support encoding and decoding of Region, and its internal
struct Region::Span.
ArgumentCoders had to be taught about how to encode
Vectors with inline capacity.
* Platform/IPC/ArgumentCoders.h:
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* Shared/WebCoreArgumentCoders.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Region.cpp
trunk/Source/WebCore/platform/graphics/Region.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/IPC/ArgumentCoders.h
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (163508 => 163509)
--- trunk/Source/WebCore/ChangeLog 2014-02-06 04:10:47 UTC (rev 163508)
+++ trunk/Source/WebCore/ChangeLog 2014-02-06 04:31:46 UTC (rev 163509)
@@ -1,3 +1,32 @@
+2014-02-05 Simon Fraser
+
+Support encoding and decoding of Regions
+https://bugs.webkit.org/show_bug.cgi?id=128284
+
+Reviewed by Anders Carlsson.
+
+Region changes to make it encodable:
+
+Make Region::Span public and give it a default constructor.
+Allow getting and setting of Shape internals, and a way to update
+the Region bounds after changing the shape. Also add a way to test
+for valid spans and segments.
+
+* platform/graphics/Region.cpp:
+(WebCore::Region::Shape::isValid):
+(WebCore::Region::updateBoundsFromShape):
+* platform/graphics/Region.h:
+(WebCore::Region::isValid):
+(WebCore::Region::Span::Span):
+(WebCore::Region::shapeSegments):
+(WebCore::Region::shapeSpans):
+(WebCore::Region::setShapeSegments):
+(WebCore::Region::setShapeSpans):
+(WebCore::Region::Shape::segments):
+(WebCore::Region::Shape::spans):
+(WebCore::Region::Shape::setSegments):
+(WebCore::Region::Shape::setSpans):
+
2014-02-05 Andreas Kling
Rebaseline the bindings tests after Oliver's hackery.
Modified: trunk/Source/WebCore/platform/graphics/Region.cpp (163508 => 163509)
--- trunk/Source/WebCore/platform/graphics/Region.cpp 2014-02-06 04:10:47 UTC (rev 163508)
+++ trunk/Source/WebCore/platform/graphics/Region.cpp 2014-02-06 04:31:46 UTC (rev 163509)
@@ -319,10 +319,10 @@
#ifndef NDEBUG
void Region::Shape::dump() const
{
-for (Shape::SpanIterator span = spans_begin(), end = spans_end(); span != end; ++span) {
+for (auto span = spans_begin(), end = spans_end(); span != end; ++span) {
printf("%6d: (", span->y);
-for (Shape::SegmentIterator segment = segments_begin(span), end = segments_end(span); segment != end; ++segment)
+for (auto segment = segments_begin(span), end = segments_end(span); segment != end; ++segment)
printf("%d ", *segment);
printf(")\n");
}
@@ -331,6 +331,27 @@
}
#endif
+bool Region::Shape::isValid() const
+{
+for (auto span = spans_begin(), end = spans_end(); span != end && span + 1 != end; ++span) {
+int y = span->y;
+int height = (span + 1)->y - y;
+
+if (height < 0)
+return false;
+
+for (auto segment = segments_begin(span), end = segments_end(span); segment != end && segment + 1 != end; segment += 2) {
+int x = *segment;
+int width = *(segment + 1) - x;
+
+if (width < 0)
+return false;
+}
+}
+
+return true;
+}
+
IntRect Region::Shape::bounds() const
{
if (isEmpty())
@@ -550,6 +571,11 @@
}
#endif
+void Region::updateBoundsFromShape()
+{
+m_bounds = m_shape.bounds();
+}
+
void Region::intersect(const Region& region)
{
if (m_bounds.isEmpty())
Modified: trunk/Source/WebCore/platform/graphics/Regio
[webkit-changes] [163507] trunk/Source/JavaScriptCore
Title: [163507] trunk/Source/_javascript_Core
Revision 163507
Author mhahnenb...@apple.com
Date 2014-02-05 19:38:19 -0800 (Wed, 05 Feb 2014)
Log Message
Handling of opaque roots is wrong in EdenCollections
https://bugs.webkit.org/show_bug.cgi?id=128210
Reviewed by Oliver Hunt.
The set of opaque roots is always cleared during each collection. We should instead persist
the set of opaque roots across EdenCollections and only clear it at the beginning of FullCollections.
Also added a couple of custom objects to the jsc shell that allow us to test this.
* heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::reset):
(JSC::GCThreadSharedData::didStartMarking):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/Heap.h:
(JSC::Heap::setShouldDoFullCollection):
* heap/SlotVisitor.cpp:
(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
* heap/SlotVisitor.h:
* jsc.cpp:
(WTF::Element::Element):
(WTF::Element::root):
(WTF::Element::setRoot):
(WTF::Element::create):
(WTF::Element::createStructure):
(WTF::ElementHandleOwner::isReachableFromOpaqueRoots):
(WTF::Root::Root):
(WTF::Root::element):
(WTF::Root::setElement):
(WTF::Root::create):
(WTF::Root::createStructure):
(WTF::Root::visitChildren):
(WTF::Element::handleOwner):
(WTF::Element::finishCreation):
(GlobalObject::finishCreation):
(functionCreateRoot):
(functionCreateElement):
(functionGetElement):
(functionSetElementRoot):
(functionGCAndSweep):
(functionFullGC):
(functionEdenGC):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/GCThreadSharedData.cpp
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/heap/SlotVisitor.cpp
trunk/Source/_javascript_Core/heap/SlotVisitor.h
trunk/Source/_javascript_Core/jsc.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163506 => 163507)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-06 03:07:17 UTC (rev 163506)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-06 03:38:19 UTC (rev 163507)
@@ -1,3 +1,50 @@
+2014-02-05 Mark Hahnenberg
+
+Handling of opaque roots is wrong in EdenCollections
+https://bugs.webkit.org/show_bug.cgi?id=128210
+
+Reviewed by Oliver Hunt.
+
+The set of opaque roots is always cleared during each collection. We should instead persist
+the set of opaque roots across EdenCollections and only clear it at the beginning of FullCollections.
+
+Also added a couple of custom objects to the jsc shell that allow us to test this.
+
+* heap/GCThreadSharedData.cpp:
+(JSC::GCThreadSharedData::reset):
+(JSC::GCThreadSharedData::didStartMarking):
+* heap/Heap.cpp:
+(JSC::Heap::markRoots):
+* heap/Heap.h:
+(JSC::Heap::setShouldDoFullCollection):
+* heap/SlotVisitor.cpp:
+(JSC::SlotVisitor::didStartMarking):
+(JSC::SlotVisitor::reset):
+* heap/SlotVisitor.h:
+* jsc.cpp:
+(WTF::Element::Element):
+(WTF::Element::root):
+(WTF::Element::setRoot):
+(WTF::Element::create):
+(WTF::Element::createStructure):
+(WTF::ElementHandleOwner::isReachableFromOpaqueRoots):
+(WTF::Root::Root):
+(WTF::Root::element):
+(WTF::Root::setElement):
+(WTF::Root::create):
+(WTF::Root::createStructure):
+(WTF::Root::visitChildren):
+(WTF::Element::handleOwner):
+(WTF::Element::finishCreation):
+(GlobalObject::finishCreation):
+(functionCreateRoot):
+(functionCreateElement):
+(functionGetElement):
+(functionSetElementRoot):
+(functionGCAndSweep):
+(functionFullGC):
+(functionEdenGC):
+
2014-02-05 Anders Carlsson
Remove unused functions.
Modified: trunk/Source/_javascript_Core/heap/GCThreadSharedData.cpp (163506 => 163507)
--- trunk/Source/_javascript_Core/heap/GCThreadSharedData.cpp 2014-02-06 03:07:17 UTC (rev 163506)
+++ trunk/Source/_javascript_Core/heap/GCThreadSharedData.cpp 2014-02-06 03:38:19 UTC (rev 163507)
@@ -118,16 +118,11 @@
}
#endif
}
-
+
void GCThreadSharedData::reset()
{
ASSERT(m_sharedMarkStack.isEmpty());
-#if ENABLE(PARALLEL_GC)
-m_opaqueRoots.clear();
-#else
-ASSERT(m_opaqueRoots.isEmpty());
-#endif
m_weakReferenceHarvesters.removeAll();
if (m_shouldHashCons) {
@@ -158,6 +153,13 @@
void GCThreadSharedData::didStartMarking()
{
+if (m_vm->heap.operationInProgress() == FullCollection) {
+#if ENABLE(PARALLEL_GC)
+m_opaqueRoots.clear();
+#else
+ASSERT(m_opaqueRoots.isEmpty());
+#endif
+}
std::lock_guard lock(m_markingMutex);
m_parallelMarkersShouldExit = false;
startNextPhase(Mark);
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (163506 => 163507)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2014-02-06 03:07:17 UTC (rev 163506)
+++ trunk/Source/_javascript_Cor
[webkit-changes] [163506] trunk/Source/WebKit2
Title: [163506] trunk/Source/WebKit2
Revision 163506
Author ander...@apple.com
Date 2014-02-05 19:07:17 -0800 (Wed, 05 Feb 2014)
Log Message
Add -[WKNavigationAction request]
https://bugs.webkit.org/show_bug.cgi?id=128288
Reviewed by Andreas Kling.
* UIProcess/API/Cocoa/WKNavigationAction.h:
* UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction request]):
(-[WKNavigationAction setRequest:]):
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h
trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163505 => 163506)
--- trunk/Source/WebKit2/ChangeLog 2014-02-06 02:30:04 UTC (rev 163505)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-06 03:07:17 UTC (rev 163506)
@@ -1,3 +1,18 @@
+2014-02-05 Anders Carlsson
+
+Add -[WKNavigationAction request]
+https://bugs.webkit.org/show_bug.cgi?id=128288
+
+Reviewed by Andreas Kling.
+
+* UIProcess/API/Cocoa/WKNavigationAction.h:
+* UIProcess/API/Cocoa/WKNavigationAction.mm:
+(-[WKNavigationAction request]):
+(-[WKNavigationAction setRequest:]):
+* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
+
2014-02-05 Sam Weinig
[WebKit2, FTL] Add user default to enable the FTL
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.h (163505 => 163506)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.h 2014-02-06 02:30:04 UTC (rev 163505)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.h 2014-02-06 03:07:17 UTC (rev 163506)
@@ -45,6 +45,7 @@
@property (nonatomic, readonly) WKFrameInfo *sourceFrame;
@property (nonatomic, readonly) WKNavigationType navigationType;
+@property (nonatomic, readonly) NSURLRequest *request;
@end
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm (163505 => 163506)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm 2014-02-06 02:30:04 UTC (rev 163505)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm 2014-02-06 03:07:17 UTC (rev 163506)
@@ -32,6 +32,7 @@
@implementation WKNavigationAction {
RetainPtr _sourceFrame;
+RetainPtr _request;
}
- (WKFrameInfo *)sourceFrame
@@ -44,6 +45,16 @@
_sourceFrame = sourceFrame;
}
+- (NSURLRequest *)request
+{
+return _request.get();
+}
+
+- (void)setRequest:(NSURLRequest *)request
+{
+_request = adoptNS([request copy]);
+}
+
@end
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h (163505 => 163506)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h 2014-02-06 02:30:04 UTC (rev 163505)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h 2014-02-06 03:07:17 UTC (rev 163506)
@@ -32,6 +32,7 @@
@property (nonatomic, readwrite, strong) WKFrameInfo *sourceFrame;
@property (nonatomic, readwrite) WKNavigationType navigationType;
+@property (nonatomic, readwrite, copy) NSURLRequest *request;
@end
Modified: trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm (163505 => 163506)
--- trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm 2014-02-06 02:30:04 UTC (rev 163505)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm 2014-02-06 03:07:17 UTC (rev 163506)
@@ -136,7 +136,7 @@
return frameInfo;
}
-void NavigationState::PolicyClient::decidePolicyForNavigationAction(WebPageProxy*, WebFrameProxy* destinationFrame, const NavigationActionData& navigationActionData, WebFrameProxy* sourceFrame, const WebCore::ResourceRequest& originalRequest, const WebCore::ResourceRequest&, RefPtr listener, API::Object* userData)
+void NavigationState::PolicyClient::decidePolicyForNavigationAction(WebPageProxy*, WebFrameProxy* destinationFrame, const NavigationActionData& navigationActionData, WebFrameProxy* sourceFrame, const WebCore::ResourceRequest& originalRequest, const WebCore::ResourceRequest& request, RefPtr listener, API::Object* userData)
{
if (!m_navigationState.m_navigationDelegateMethods.webViewDecidePolicyForNavigationActionDecisionHandler) {
// FIXME: Figure out what the "default delegate behavior" should be here.
@@ -158,6 +158,7 @@
}
[navigationAction setNavigationType:toWKNavigationType(navigationActionData.navigationType)];
+[navigationAction setRequest:request.nsURLRequest(WebCore::DoNotUpdateHTTPBody)];
[navigationDelegate webView:m_navigationState.m_webView decidePolicyForNavigationAction:navigationAct
[webkit-changes] [163504] trunk/Source/WebKit2
Title: [163504] trunk/Source/WebKit2 Revision 163504 Author wei...@apple.com Date 2014-02-05 18:26:17 -0800 (Wed, 05 Feb 2014) Log Message [WebKit2, FTL] Add user default to enable the FTL https://bugs.webkit.org/show_bug.cgi?id=128281 Reviewed by Geoffrey Garen. * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: * UIProcess/mac/WebContextMac.mm: (WebKit::registerUserDefaultsIfNeeded): (WebKit::WebContext::platformInitializeWebProcess): * WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): Pipe through the default. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm trunk/Source/WebKit2/WebProcess/mac/WebProcessMac.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (163503 => 163504) --- trunk/Source/WebKit2/ChangeLog 2014-02-06 02:23:35 UTC (rev 163503) +++ trunk/Source/WebKit2/ChangeLog 2014-02-06 02:26:17 UTC (rev 163504) @@ -1,3 +1,22 @@ +2014-02-05 Sam Weinig + +[WebKit2, FTL] Add user default to enable the FTL +https://bugs.webkit.org/show_bug.cgi?id=128281 + +Reviewed by Geoffrey Garen. + +* Shared/WebProcessCreationParameters.cpp: +(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): +(WebKit::WebProcessCreationParameters::encode): +(WebKit::WebProcessCreationParameters::decode): +* Shared/WebProcessCreationParameters.h: +* UIProcess/mac/WebContextMac.mm: +(WebKit::registerUserDefaultsIfNeeded): +(WebKit::WebContext::platformInitializeWebProcess): +* WebProcess/mac/WebProcessMac.mm: +(WebKit::WebProcess::platformInitializeWebProcess): +Pipe through the default. + 2014-02-05 Anders Carlsson Add sourceFrame to WKNavigationAction Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp (163503 => 163504) --- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2014-02-06 02:23:35 UTC (rev 163503) +++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2014-02-06 02:26:17 UTC (rev 163504) @@ -40,6 +40,7 @@ , nsURLCacheDiskCapacity(0) , shouldForceScreenFontSubstitution(false) , shouldEnableKerningAndLigaturesByDefault(false) +, shouldEnableFTL(false) #endif #if ENABLE(NETWORK_PROCESS) , usesNetworkProcess(false) @@ -108,6 +109,7 @@ encoder << uiProcessBundleResourcePathExtensionHandle; encoder << shouldForceScreenFontSubstitution; encoder << shouldEnableKerningAndLigaturesByDefault; +encoder << shouldEnableFTL; #endif #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) @@ -231,6 +233,8 @@ return false; if (!decoder.decode(parameters.shouldEnableKerningAndLigaturesByDefault)) return false; +if (!decoder.decode(parameters.shouldEnableFTL)) +return false; #endif #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h (163503 => 163504) --- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h 2014-02-06 02:23:35 UTC (rev 163503) +++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h 2014-02-06 02:26:17 UTC (rev 163504) @@ -131,6 +131,7 @@ bool shouldForceScreenFontSubstitution; bool shouldEnableKerningAndLigaturesByDefault; +bool shouldEnableFTL; #endif // PLATFORM(MAC) #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (163503 => 163504) --- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm 2014-02-06 02:23:35 UTC (rev 163503) +++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm 2014-02-06 02:26:17 UTC (rev 163504) @@ -67,6 +67,7 @@ NSString *WebKitLocalCacheDefaultsKey = @"WebKitLocalCache"; NSString *WebStorageDirectoryDefaultsKey = @"WebKitLocalStorageDatabasePathPreferenceKey"; NSString *WebKitKerningAndLigaturesEnabledByDefaultDefaultsKey = @"WebKitKerningAndLigaturesEnabledByDefault"; +NSString *WebKitFTLEnabledDefaultsKey = @"WebKitFTLEnabledDefaultsKey"; #if !PLATFORM(IOS) static NSString *WebKitApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification = @"NSApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification"; @@ -96,6 +97,7 @@ #if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 [registrationDictionary setObject:[NSNumber numberWithBool:YES] forKey:WebKitKerningAndLigaturesEnabledByDefaultDefaultsKey]; +[registrationDictionary setObject:[NSNumber numberWithBool:NO] forKey:WebKitFTLEnabledDefaultsKey]; #endif [[NSUserDefaults standardUserDefaults] registerDefaults:registratio
[webkit-changes] [163503] trunk/Source/WebCore
Title: [163503] trunk/Source/WebCore
Revision 163503
Author ander...@apple.com
Date 2014-02-05 18:23:35 -0800 (Wed, 05 Feb 2014)
Log Message
Fix a warning.
* platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::ContentFilter):
Remove an unnecessary comparison.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ContentFilterMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (163502 => 163503)
--- trunk/Source/WebCore/ChangeLog 2014-02-06 02:11:51 UTC (rev 163502)
+++ trunk/Source/WebCore/ChangeLog 2014-02-06 02:23:35 UTC (rev 163503)
@@ -1,3 +1,11 @@
+2014-02-05 Anders Carlsson
+
+Fix a warning.
+
+* platform/mac/ContentFilterMac.mm:
+(WebCore::ContentFilter::ContentFilter):
+Remove an unnecessary comparison.
+
2014-02-05 Csaba Osztrogonác
Fix the !ENABLE(PAGE_VISIBILITY_API) build
Modified: trunk/Source/WebCore/platform/mac/ContentFilterMac.mm (163502 => 163503)
--- trunk/Source/WebCore/platform/mac/ContentFilterMac.mm 2014-02-06 02:11:51 UTC (rev 163502)
+++ trunk/Source/WebCore/platform/mac/ContentFilterMac.mm 2014-02-06 02:23:35 UTC (rev 163503)
@@ -104,7 +104,7 @@
m_neFilterSourceQueue = dispatch_queue_create("com.apple.WebCore.NEFilterSourceQueue", DISPATCH_QUEUE_SERIAL);
long long expectedContentSize = [response.nsURLResponse() expectedContentLength];
-if (expectedContentSize < 0 || expectedContentSize > NSUIntegerMax)
+if (expectedContentSize < 0)
m_originalData = adoptNS([[NSMutableData alloc] init]);
else
m_originalData = adoptNS([[NSMutableData alloc] initWithCapacity:(NSUInteger)expectedContentSize]);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163502] trunk/Source/JavaScriptCore
Title: [163502] trunk/Source/_javascript_Core
Revision 163502
Author ander...@apple.com
Date 2014-02-05 18:11:51 -0800 (Wed, 05 Feb 2014)
Log Message
Remove unused functions.
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertySlot):
* runtime/RegExpObject.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp
trunk/Source/_javascript_Core/runtime/RegExpObject.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163501 => 163502)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-06 01:49:06 UTC (rev 163501)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-06 02:11:51 UTC (rev 163502)
@@ -1,3 +1,11 @@
+2014-02-05 Anders Carlsson
+
+Remove unused functions.
+
+* runtime/RegExpConstructor.cpp:
+(JSC::RegExpConstructor::getOwnPropertySlot):
+* runtime/RegExpObject.cpp:
+
2014-02-05 Oliver Hunt
Change custom getter signature to make the base reference an object pointer
Modified: trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp (163501 => 163502)
--- trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp 2014-02-06 01:49:06 UTC (rev 163501)
+++ trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp 2014-02-06 02:11:51 UTC (rev 163502)
@@ -157,11 +157,6 @@
{
return getStaticValueSlot(exec, ExecState::regExpConstructorTable(exec->vm()), jsCast(object), propertyName, slot);
}
-
-static inline RegExpConstructor* asRegExpConstructor(EncodedJSValue value)
-{
-return jsCast(JSValue::decode(value));
-}
EncodedJSValue regExpConstructorDollar1(ExecState* exec, JSObject* slotBase, EncodedJSValue, PropertyName)
{
Modified: trunk/Source/_javascript_Core/runtime/RegExpObject.cpp (163501 => 163502)
--- trunk/Source/_javascript_Core/runtime/RegExpObject.cpp 2014-02-06 01:49:06 UTC (rev 163501)
+++ trunk/Source/_javascript_Core/runtime/RegExpObject.cpp 2014-02-06 02:11:51 UTC (rev 163502)
@@ -155,11 +155,6 @@
return Base::defineOwnProperty(object, exec, propertyName, descriptor, shouldThrow);
}
-static inline RegExpObject* asRegExpObject(EncodedJSValue value)
-{
-return jsCast(JSValue::decode(value));
-}
-
EncodedJSValue regExpObjectGlobal(ExecState*, JSObject* slotBase, EncodedJSValue, PropertyName)
{
return JSValue::encode(jsBoolean(asRegExpObject(slotBase)->regExp()->global()));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163501] trunk
Title: [163501] trunk Revision 163501 Author ander...@apple.com Date 2014-02-05 17:49:06 -0800 (Wed, 05 Feb 2014) Log Message Add sourceFrame to WKNavigationAction https://bugs.webkit.org/show_bug.cgi?id=128280 Reviewed by Dan Bernstein. * UIProcess/API/Cocoa/WKFrameInfo.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h. * UIProcess/API/Cocoa/WKFrameInfo.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h. (-[WKFrameInfo request]): (-[WKFrameInfo setRequest:]): * UIProcess/API/Cocoa/WKFrameInfoInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h. * UIProcess/API/Cocoa/WKNavigationAction.h: * UIProcess/API/Cocoa/WKNavigationAction.mm: (-[WKNavigationAction sourceFrame]): (-[WKNavigationAction setSourceFrame:]): * UIProcess/API/Cocoa/WKNavigationActionInternal.h: * UIProcess/Cocoa/NavigationState.mm: (WebKit::frameInfoFromWebFrameProxy): (WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction): * WebKit2.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m Added Paths trunk/Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm trunk/Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h Diff Modified: trunk/Source/WebKit2/ChangeLog (163500 => 163501) --- trunk/Source/WebKit2/ChangeLog 2014-02-06 01:19:43 UTC (rev 163500) +++ trunk/Source/WebKit2/ChangeLog 2014-02-06 01:49:06 UTC (rev 163501) @@ -1,3 +1,25 @@ +2014-02-05 Anders Carlsson + +Add sourceFrame to WKNavigationAction +https://bugs.webkit.org/show_bug.cgi?id=128280 + +Reviewed by Dan Bernstein. + +* UIProcess/API/Cocoa/WKFrameInfo.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h. +* UIProcess/API/Cocoa/WKFrameInfo.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h. +(-[WKFrameInfo request]): +(-[WKFrameInfo setRequest:]): +* UIProcess/API/Cocoa/WKFrameInfoInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h. +* UIProcess/API/Cocoa/WKNavigationAction.h: +* UIProcess/API/Cocoa/WKNavigationAction.mm: +(-[WKNavigationAction sourceFrame]): +(-[WKNavigationAction setSourceFrame:]): +* UIProcess/API/Cocoa/WKNavigationActionInternal.h: +* UIProcess/Cocoa/NavigationState.mm: +(WebKit::frameInfoFromWebFrameProxy): +(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction): +* WebKit2.xcodeproj/project.pbxproj: + 2014-02-05 Enrica Casucci WK2: Tap highlight is positioned incorrectly in iframes. Copied: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h (from rev 163499, trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h) (0 => 163501) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h (rev 0) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h 2014-02-06 01:49:06 UTC (rev 163501) @@ -0,0 +1,39 @@ +/* + * Copyright (C) 2014 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF + * THE POSSIBILITY OF SUCH DAMAGE. + */ + +#import +#import + +#if WK_API_ENABLED + +WK_API_CLASS +@interface WKFrameI
[webkit-changes] [163500] branches/safari-537.75-branch/Source
Title: [163500] branches/safari-537.75-branch/Source Revision 163500 Author bfulg...@apple.com Date 2014-02-05 17:19:43 -0800 (Wed, 05 Feb 2014) Log Message Source/WebCore: Merge r154146, r155828, r156145 2013-08-15 Brent Fulgham [Windows] Consolidate WebKit Bundle Handling https://bugs.webkit.org/show_bug.cgi?id=119869 Reviewed by Tim Horton. * WebCore.vcxproj/WebCore.vcxproj: Add new WebCoreBundleWin files. * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto. * platform/network/curl/ResourceHandleManager.cpp: (WebCore::certificatePath): Use correct bundle handling logic. * platform/win/LocalizedStringsWin.cpp: Move bundle implementation to new WebCoreBundleWin.cpp file. * platform/win/WebCoreBundleWin.cpp: Added. (WebCore::createWebKitBundle): (WebCore::webKitBundle): * platform/win/WebCoreBundleWin.h: Added. Source/WebKit/win: Merge r154146 2013-08-15 Brent Fulgham [Windows] Consolidate WebKit Bundle handling https://bugs.webkit.org/show_bug.cgi?id=119869 Reviewed by Tim Horton. * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend): Switch to new WebCore::webkitBundle() method. (WebInspectorFrontendClient::localizedStringsURL): Ditto. Source/WTF: Merge in build correction to prevent needless "rebuild all" builds. * WTF.vcxproj/WTFGenerated.make: Avoid re-copying identical files, which forces a complete rebuild. Modified Paths branches/safari-537.75-branch/Source/WTF/ChangeLog branches/safari-537.75-branch/Source/WTF/WTF.vcxproj/WTFGenerated.make branches/safari-537.75-branch/Source/WebCore/ChangeLog branches/safari-537.75-branch/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj branches/safari-537.75-branch/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters branches/safari-537.75-branch/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp branches/safari-537.75-branch/Source/WebCore/platform/win/LocalizedStringsWin.cpp branches/safari-537.75-branch/Source/WebKit/win/ChangeLog branches/safari-537.75-branch/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp Diff Modified: branches/safari-537.75-branch/Source/WTF/ChangeLog (163499 => 163500) --- branches/safari-537.75-branch/Source/WTF/ChangeLog 2014-02-06 01:18:23 UTC (rev 163499) +++ branches/safari-537.75-branch/Source/WTF/ChangeLog 2014-02-06 01:19:43 UTC (rev 163500) @@ -1,3 +1,10 @@ +2014-02-05 Brent Fulgham + +Merge in build correction to prevent needless "rebuild all" builds. + +* WTF.vcxproj/WTFGenerated.make: Avoid re-copying identical files, which +forces a complete rebuild. + 2014-01-27 Brent Fulgham Merge r162723. Modified: branches/safari-537.75-branch/Source/WTF/WTF.vcxproj/WTFGenerated.make (163499 => 163500) --- branches/safari-537.75-branch/Source/WTF/WTF.vcxproj/WTFGenerated.make 2014-02-06 01:18:23 UTC (rev 163499) +++ branches/safari-537.75-branch/Source/WTF/WTF.vcxproj/WTFGenerated.make 2014-02-06 01:19:43 UTC (rev 163500) @@ -17,6 +17,9 @@ WTFHeaderDetection.h: WTFGenerated.make -mkdir "%ConfigurationBuildDir%\include\private\wtf <+IF EXIST "%ConfigurationBuildDir%\include\private\wtf\$@" GOTO DONE echo /* No Legible Output Support Found */ > "%ConfigurationBuildDir%\include\private\wtf\$@" IF EXIST "$(WEBKIT_LIBRARIES)/include/AVFoundationCF/AVCFPlayerItemLegibleOutput.h" (echo #define __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ 1090 > "%ConfigurationBuildDir%\include\private\wtf\$@") +:DONE << + Modified: branches/safari-537.75-branch/Source/WebCore/ChangeLog (163499 => 163500) --- branches/safari-537.75-branch/Source/WebCore/ChangeLog 2014-02-06 01:18:23 UTC (rev 163499) +++ branches/safari-537.75-branch/Source/WebCore/ChangeLog 2014-02-06 01:19:43 UTC (rev 163500) @@ -1,3 +1,25 @@ +2014-02-05 Brent Fulgham + +Merge r154146, r155828, r156145 + +2013-08-15 Brent Fulgham + +[Windows] Consolidate WebKit Bundle Handling +https://bugs.webkit.org/show_bug.cgi?id=119869 + +Reviewed by Tim Horton. + +* WebCore.vcxproj/WebCore.vcxproj: Add new WebCoreBundleWin files. +* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto. +* platform/network/curl/ResourceHandleManager.cpp: +(WebCore::certificatePath): Use correct bundle handling logic. +* platform/win/LocalizedStringsWin.cpp: Move bundle implementation to +new WebCoreBundleWin.cpp file. +* platform/win/WebCoreBundleWin.cpp: Added. +(WebCore::createWebKitBundle): +(WebCore::webKitBundle): +* platform/win/WebCoreBundleWin.h: Added. + 2014-02-04 Brent Fulgham Build fix after last branch merge. Modified: branches/safari-537.75-branch/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (163499 => 163500) --- branches/safari-537.75-branch/So
[webkit-changes] [163499] trunk/Source/WebKit2
Title: [163499] trunk/Source/WebKit2
Revision 163499
Author enr...@apple.com
Date 2014-02-05 17:18:23 -0800 (Wed, 05 Feb 2014)
Log Message
WK2: Tap highlight is positioned incorrectly in iframes.
https://bugs.webkit.org/show_bug.cgi?id=128277
Reviewed by Benjamin Poulain.
We need to convert the quad to root view coordinates
before returning it to the UIProcess for drawing the highlight.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::tapHighlightAtPosition):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163498 => 163499)
--- trunk/Source/WebKit2/ChangeLog 2014-02-06 01:14:42 UTC (rev 163498)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-06 01:18:23 UTC (rev 163499)
@@ -1,3 +1,17 @@
+2014-02-05 Enrica Casucci
+
+WK2: Tap highlight is positioned incorrectly in iframes.
+https://bugs.webkit.org/show_bug.cgi?id=128277
+
+
+Reviewed by Benjamin Poulain.
+
+We need to convert the quad to root view coordinates
+before returning it to the UIProcess for drawing the highlight.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::tapHighlightAtPosition):
+
2014-02-05 Ryuan Choi
Unreviewed build fix attempt on EFL build after r163480
Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (163498 => 163499)
--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-02-06 01:14:42 UTC (rev 163498)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-02-06 01:18:23 UTC (rev 163499)
@@ -318,6 +318,16 @@
if (renderer) {
renderer->absoluteQuads(quads);
Color highlightColor = node->computedStyle()->tapHighlightColor();
+if (!node->document().frame()->isMainFrame()) {
+FrameView* view = node->document().frame()->view();
+for (size_t i = 0; i < quads.size(); ++i) {
+FloatQuad& currentQuad = quads[i];
+currentQuad.setP1(view->contentsToRootView(roundedIntPoint(currentQuad.p1(;
+currentQuad.setP2(view->contentsToRootView(roundedIntPoint(currentQuad.p2(;
+currentQuad.setP3(view->contentsToRootView(roundedIntPoint(currentQuad.p3(;
+currentQuad.setP4(view->contentsToRootView(roundedIntPoint(currentQuad.p4(;
+}
+}
RoundedRect::Radii borderRadii;
if (renderer->isBox()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163498] trunk/Source/WebCore
Title: [163498] trunk/Source/WebCore
Revision 163498
Author o...@webkit.org
Date 2014-02-05 17:14:42 -0800 (Wed, 05 Feb 2014)
Log Message
Fix the !ENABLE(PAGE_VISIBILITY_API) build
https://bugs.webkit.org/show_bug.cgi?id=127907
Reviewed by Brent Fulgham.
* page/Page.cpp:
(WebCore::Page::setIsVisible):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (163497 => 163498)
--- trunk/Source/WebCore/ChangeLog 2014-02-06 01:08:23 UTC (rev 163497)
+++ trunk/Source/WebCore/ChangeLog 2014-02-06 01:14:42 UTC (rev 163498)
@@ -1,3 +1,13 @@
+2014-02-05 Csaba Osztrogonác
+
+Fix the !ENABLE(PAGE_VISIBILITY_API) build
+https://bugs.webkit.org/show_bug.cgi?id=127907
+
+Reviewed by Brent Fulgham.
+
+* page/Page.cpp:
+(WebCore::Page::setIsVisible):
+
2014-02-05 Oliver Hunt
Change custom getter signature to make the base reference an object pointer
Modified: trunk/Source/WebCore/page/Page.cpp (163497 => 163498)
--- trunk/Source/WebCore/page/Page.cpp 2014-02-06 01:08:23 UTC (rev 163497)
+++ trunk/Source/WebCore/page/Page.cpp 2014-02-06 01:14:42 UTC (rev 163498)
@@ -1171,8 +1171,10 @@
unthrottleTimers();
+#if ENABLE(PAGE_VISIBILITY_API)
if (m_settings->hiddenPageCSSAnimationSuspensionEnabled())
mainFrame().animation().resumeAnimations();
+#endif
resumeAnimatingImages();
}
@@ -1194,8 +1196,10 @@
if (m_pageThrottler->shouldThrottleTimers())
throttleTimers();
+#if ENABLE(PAGE_VISIBILITY_API)
if (m_settings->hiddenPageCSSAnimationSuspensionEnabled())
mainFrame().animation().suspendAnimations();
+#endif
for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {
if (FrameView* frameView = frame->view())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163495] tags/Safari-538.16.2
Title: [163495] tags/Safari-538.16.2
Revision 163495
Author lforsch...@apple.com
Date 2014-02-05 16:57:54 -0800 (Wed, 05 Feb 2014)
Log Message
Merged r163474.
Modified Paths
tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog
tags/Safari-538.16.2/Source/_javascript_Core/Configurations/Base.xcconfig
tags/Safari-538.16.2/Source/_javascript_Core/Configurations/LLVMForJSC.xcconfig
tags/Safari-538.16.2/Tools/ChangeLog
tags/Safari-538.16.2/Tools/Scripts/copy-webkitlibraries-to-product-directory
Diff
Modified: tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog (163494 => 163495)
--- tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:54:30 UTC (rev 163494)
+++ tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:57:54 UTC (rev 163495)
@@ -1,5 +1,19 @@
2014-02-05 Lucas Forschler
+Merge r163474
+
+2014-02-05 Filip Pizlo
+
+JSC on Mac should pull LLVM from prefix=/usr/local/LLVMForJavaScriptCore and not /usr/local
+https://bugs.webkit.org/show_bug.cgi?id=128269
+
+Reviewed by Mark Hahnenberg.
+
+* Configurations/Base.xcconfig:
+* Configurations/LLVMForJSC.xcconfig:
+
+2014-02-05 Lucas Forschler
+
Merge r163473
2014-02-05 Mark Hahnenberg
Modified: tags/Safari-538.16.2/Source/_javascript_Core/Configurations/Base.xcconfig (163494 => 163495)
--- tags/Safari-538.16.2/Source/_javascript_Core/Configurations/Base.xcconfig 2014-02-06 00:54:30 UTC (rev 163494)
+++ tags/Safari-538.16.2/Source/_javascript_Core/Configurations/Base.xcconfig 2014-02-06 00:57:54 UTC (rev 163495)
@@ -78,7 +78,7 @@
LINKER_DISPLAYS_MANGLED_NAMES = YES;
PREBINDING = NO;
WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough;
-HEADER_SEARCH_PATHS = . icu "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
+HEADER_SEARCH_PATHS = . icu "${BUILT_PRODUCTS_DIR}/usr/local/LLVMForJavaScriptCore/include" /usr/local/LLVMForJavaScriptCore/include "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
TARGET_MAC_OS_X_VERSION_MAJOR = $(MAC_OS_X_VERSION_MAJOR);
Modified: tags/Safari-538.16.2/Source/_javascript_Core/Configurations/LLVMForJSC.xcconfig (163494 => 163495)
--- tags/Safari-538.16.2/Source/_javascript_Core/Configurations/LLVMForJSC.xcconfig 2014-02-06 00:54:30 UTC (rev 163494)
+++ tags/Safari-538.16.2/Source/_javascript_Core/Configurations/LLVMForJSC.xcconfig 2014-02-06 00:57:54 UTC (rev 163495)
@@ -29,7 +29,7 @@
OTHER_LDFLAGS_LLVM = $(OTHER_LDFLAGS_LLVM_$(ENABLE_FTL_JIT));
OTHER_LDFLAGS_LLVM_ = ;
-OTHER_LDFLAGS_LLVM_ENABLE_FTL_JIT = -lpthread -lm -lLLVMTableGen -lLLVMDebugInfo -lLLVMOption -lLLVMX86Disassembler -lLLVMX86AsmParser -lLLVMX86CodeGen -lLLVMSelectionDAG -lLLVMAsmPrinter -lLLVMX86Desc -lLLVMX86Info -lLLVMX86AsmPrinter -lLLVMX86Utils -lLLVMIRReader -lLLVMAsmParser -lLLVMMCDisassembler -lLLVMMCParser -lLLVMInstrumentation -lLLVMBitReader -lLLVMInterpreter -lLLVMipo -lLLVMVectorize -lLLVMLinker -lLLVMBitWriter -lLLVMMCJIT -lLLVMJIT -lLLVMCodeGen -lLLVMObjCARCOpts -lLLVMScalarOpts -lLLVMInstCombine -lLLVMTransformUtils -lLLVMipa -lLLVMAnalysis -lLLVMRuntimeDyld -lLLVMExecutionEngine -lLLVMTarget -lLLVMMC -lLLVMObject -lLLVMCore -lLLVMSupport;
+OTHER_LDFLAGS_LLVM_ENABLE_FTL_JIT = -lpthread -lm -L/usr/local/LLVMForJavaScriptCore/lib -lLLVMTableGen -lLLVMDebugInfo -lLLVMOption -lLLVMX86Disassembler -lLLVMX86AsmParser -lLLVMX86CodeGen -lLLVMSelectionDAG -lLLVMAsmPrinter -lLLVMX86Desc -lLLVMX86Info -lLLVMX86AsmPrinter -lLLVMX86Utils -lLLVMIRReader -lLLVMAsmParser -lLLVMMCDisassembler -lLLVMMCParser -lLLVMInstrumentation -lLLVMBitReader -lLLVMInterpreter -lLLVMipo -lLLVMVectorize -lLLVMLinker -lLLVMBitWriter -lLLVMMCJIT -lLLVMJIT -lLLVMCodeGen -lLLVMObjCARCOpts -lLLVMScalarOpts -lLLVMInstCombine -lLLVMTransformUtils -lLLVMipa -lLLVMAnalysis -lLLVMRuntimeDyld -lLLVMExecutionEngine -lLLVMTarget -lLLVMMC -lLLVMObject -lLLVMCore -lLLVMSupport;
OTHER_LDFLAGS_BASE = -lobjc -Wl,-Y,3 $(OTHER_LDFLAGS_HIDE_SYMBOLS);
OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_$(PLATFORM_NAME));
Modified: tags/Safari-538.16.2/Tools/ChangeLog (163494 => 163495)
--- tags/Safari-538.16.2/Tools/ChangeLog 2014-02-06 00:54:30 UTC (rev 163494)
+++ tags/Safari-538.16.2/Tools/ChangeLog 2014-02-06 00:57:54 UTC (rev 163495)
@@ -1,5 +1,18 @@
2014-02-05 Lucas Forschler
+Merge r163474
+
+2014-02-05 Filip Pizlo
+
+JSC on Mac should pull LLVM from prefix=/usr/local/LLVMForJavaScriptCore and not /usr/local
+https://bugs.webkit.org/show_bug.cgi?id=128269
+
+Reviewed by Mark Hahnenberg.
+
+* Scripts/copy-webkitlibraries-to-product-directory:
+
+2014-02-05 Lucas Forschler
+
[webkit-changes] [163494] tags/Safari-538.16.2/Source/JavaScriptCore
Title: [163494] tags/Safari-538.16.2/Source/_javascript_Core
Revision 163494
Author lforsch...@apple.com
Date 2014-02-05 16:54:30 -0800 (Wed, 05 Feb 2014)
Log Message
Merged r163473.
Modified Paths
tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog
tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp
Diff
Modified: tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog (163493 => 163494)
--- tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:52:04 UTC (rev 163493)
+++ tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:54:30 UTC (rev 163494)
@@ -1,5 +1,15 @@
2014-02-05 Lucas Forschler
+Merge r163473
+
+2014-02-05 Mark Hahnenberg
+
+Fix 32-bit builds after r163471
+
+* dfg/DFGOSRExitCompilerCommon.cpp:
+
+2014-02-05 Lucas Forschler
+
Merge r163471
2014-02-05 Mark Hahnenberg
Modified: tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp (163493 => 163494)
--- tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp 2014-02-06 00:52:04 UTC (rev 163493)
+++ tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp 2014-02-06 00:54:30 UTC (rev 163494)
@@ -160,6 +160,7 @@
jit.store32(AssemblyHelpers::TrustedImm32(locationBits), AssemblyHelpers::tagFor((VirtualRegister)(JSStack::ArgumentCount)));
}
+#if ENABLE(GGC)
static void osrWriteBarrier(CCallHelpers& jit, GPRReg owner, GPRReg scratch1, GPRReg scratch2)
{
AssemblyHelpers::Jump definitelyNotMarked = jit.genericWriteBarrier(owner, scratch1, scratch2);
@@ -179,6 +180,7 @@
definitelyNotMarked.link(&jit);
}
+#endif // ENABLE(GGC)
void adjustAndJumpToTarget(CCallHelpers& jit, const OSRExitBase& exit)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163493] tags/Safari-538.16.2/Source/JavaScriptCore
Title: [163493] tags/Safari-538.16.2/Source/_javascript_Core
Revision 163493
Author lforsch...@apple.com
Date 2014-02-05 16:52:04 -0800 (Wed, 05 Feb 2014)
Log Message
Merged r163471.
Modified Paths
tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog
tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp
tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp
tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp
tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
tags/Safari-538.16.2/Source/_javascript_Core/jit/AssemblyHelpers.h
Diff
Modified: tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog (163492 => 163493)
--- tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:49:42 UTC (rev 163492)
+++ tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:52:04 UTC (rev 163493)
@@ -1,5 +1,31 @@
2014-02-05 Lucas Forschler
+Merge r163471
+
+2014-02-05 Mark Hahnenberg
+
+Can no longer run OctaneV2 in browser, crashes in speculationFromCell
+https://bugs.webkit.org/show_bug.cgi?id=128266
+
+Reviewed by Filip Pizlo.
+
+Move the OSR exit write barriers into OSRExitCompilerCommon. Also reorganize some
+of the code to be in more appropriate places.
+
+* dfg/DFGOSRExitCompiler32_64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* dfg/DFGOSRExitCompiler64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* dfg/DFGOSRExitCompilerCommon.cpp:
+(JSC::DFG::osrWriteBarrier):
+(JSC::DFG::adjustAndJumpToTarget):
+* dfg/DFGSpeculativeJIT.cpp:
+* dfg/DFGSpeculativeJIT.h:
+* jit/AssemblyHelpers.h:
+(JSC::AssemblyHelpers::genericWriteBarrier):
+
+2014-02-05 Lucas Forschler
+
Merge r163420
2014-02-04 Mark Hahnenberg
Modified: tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp (163492 => 163493)
--- tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp 2014-02-06 00:49:42 UTC (rev 163492)
+++ tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp 2014-02-06 00:52:04 UTC (rev 163493)
@@ -456,17 +456,6 @@
}
}
-#if ENABLE(GGC)
-// 11) Write barrier the owner executable because we're jumping into a different block.
-for (CodeOrigin codeOrigin = exit.m_codeOrigin; ; codeOrigin = codeOrigin.inlineCallFrame->caller) {
-CodeBlock* baselineCodeBlock = m_jit.baselineCodeBlockFor(codeOrigin);
-m_jit.move(AssemblyHelpers::TrustedImmPtr(baselineCodeBlock->ownerExecutable()), GPRInfo::nonArgGPR0);
-SpeculativeJIT::osrWriteBarrier(m_jit, GPRInfo::nonArgGPR0, GPRInfo::nonArgGPR1, GPRInfo::nonArgGPR2);
-if (!codeOrigin.inlineCallFrame)
-break;
-}
-#endif
-
// 12) And finish.
adjustAndJumpToTarget(m_jit, exit);
}
Modified: tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp (163492 => 163493)
--- tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp 2014-02-06 00:49:42 UTC (rev 163492)
+++ tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp 2014-02-06 00:52:04 UTC (rev 163493)
@@ -412,17 +412,6 @@
}
}
-#if ENABLE(GGC)
-// 11) Write barrier the owner executable because we're jumping into a different block.
-for (CodeOrigin codeOrigin = exit.m_codeOrigin; ; codeOrigin = codeOrigin.inlineCallFrame->caller) {
-CodeBlock* baselineCodeBlock = m_jit.baselineCodeBlockFor(codeOrigin);
-m_jit.move(AssemblyHelpers::TrustedImmPtr(baselineCodeBlock->ownerExecutable()), GPRInfo::nonArgGPR0);
-SpeculativeJIT::osrWriteBarrier(m_jit, GPRInfo::nonArgGPR0, GPRInfo::nonArgGPR1, GPRInfo::nonArgGPR2);
-if (!codeOrigin.inlineCallFrame)
-break;
-}
-#endif
-
// 12) And finish.
adjustAndJumpToTarget(m_jit, exit);
}
Modified: tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp (163492 => 163493)
--- tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp 2014-02-06 00:49:42 UTC (rev 163492)
+++ tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp 2014-02-06 00:52:04 UTC (rev 163493)
@@ -160,8 +160,39 @@
jit.store32(AssemblyHelpers::TrustedImm32(locationBits), AssemblyHelpers::tagFor((VirtualRegister)(JSStack::ArgumentCount)));
}
+static void osrWriteBarrier(CCallHelpers& jit, GPRReg owner, GPRReg scratch1, GPRReg scratch2)
+{
+AssemblyHelpers::Jump definitelyNotMarked = jit.genericWriteBarrier(owner, scratch1, scratch2);
+
+// We need these extra slots because setupArgumentsWithExecState will use poke on x86.
+#if CPU(X86)
+jit.subPtr(MacroAssem
[webkit-changes] [163492] tags/Safari-538.16.2/Tools
Title: [163492] tags/Safari-538.16.2/Tools
Revision 163492
Author lforsch...@apple.com
Date 2014-02-05 16:49:42 -0800 (Wed, 05 Feb 2014)
Log Message
Merged r163423.
Modified Paths
tags/Safari-538.16.2/Tools/ChangeLog
tags/Safari-538.16.2/Tools/Scripts/copy-webkitlibraries-to-product-directory
Diff
Modified: tags/Safari-538.16.2/Tools/ChangeLog (163491 => 163492)
--- tags/Safari-538.16.2/Tools/ChangeLog 2014-02-06 00:48:20 UTC (rev 163491)
+++ tags/Safari-538.16.2/Tools/ChangeLog 2014-02-06 00:49:42 UTC (rev 163492)
@@ -1,5 +1,15 @@
2014-02-05 Lucas Forschler
+Merge r163423
+
+2014-02-04 Filip Pizlo
+
+Fix build when the script is called from Xcode.
+
+* Scripts/copy-webkitlibraries-to-product-directory:
+
+2014-02-05 Lucas Forschler
+
Merge r163418
2014-02-04 Filip Pizlo
Modified: tags/Safari-538.16.2/Tools/Scripts/copy-webkitlibraries-to-product-directory (163491 => 163492)
--- tags/Safari-538.16.2/Tools/Scripts/copy-webkitlibraries-to-product-directory 2014-02-06 00:48:20 UTC (rev 163491)
+++ tags/Safari-538.16.2/Tools/Scripts/copy-webkitlibraries-to-product-directory 2014-02-06 00:49:42 UTC (rev 163492)
@@ -182,7 +182,7 @@
print("Building LLVM.\n");
chdir $ownLLVMDirectory;
-(system("make -j `sysctl -n hw.activecpu`") == 0) or die;
+(system("(unset PROJECT_NAME ; make -j `sysctl -n hw.activecpu`)") == 0) or die;
chdirWebKit();
my $ownLLVMBuildMode = "";
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163491] tags/Safari-538.16.2/Source/JavaScriptCore
Title: [163491] tags/Safari-538.16.2/Source/_javascript_Core
Revision 163491
Author lforsch...@apple.com
Date 2014-02-05 16:48:20 -0800 (Wed, 05 Feb 2014)
Log Message
Merged r163420.
Modified Paths
tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog
tags/Safari-538.16.2/Source/_javascript_Core/bytecode/CodeBlock.cpp
Diff
Modified: tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog (163490 => 163491)
--- tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:46:36 UTC (rev 163490)
+++ tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:48:20 UTC (rev 163491)
@@ -1,5 +1,16 @@
2014-02-05 Lucas Forschler
+Merge r163420
+
+2014-02-04 Mark Hahnenberg
+
+Fix !ENABLE(JIT) builds after r163418
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::reoptimizationRetryCounter): Return 0 if there's no way for us to reoptimize.
+
+2014-02-05 Lucas Forschler
+
Merge r163418
2014-02-04 Filip Pizlo
Modified: tags/Safari-538.16.2/Source/_javascript_Core/bytecode/CodeBlock.cpp (163490 => 163491)
--- tags/Safari-538.16.2/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-02-06 00:46:36 UTC (rev 163490)
+++ tags/Safari-538.16.2/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-02-06 00:48:20 UTC (rev 163491)
@@ -2916,13 +2916,17 @@
#endif
}
-#if ENABLE(JIT)
unsigned CodeBlock::reoptimizationRetryCounter() const
{
+#if ENABLE(JIT)
ASSERT(m_reoptimizationRetryCounter <= Options::reoptimizationRetryCounterMax());
return m_reoptimizationRetryCounter;
+#else
+return 0;
+#endif // ENABLE(JIT)
}
+#if ENABLE(JIT)
void CodeBlock::countReoptimization()
{
m_reoptimizationRetryCounter++;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163489] tags/Safari-538.16.2/Tools
Title: [163489] tags/Safari-538.16.2/Tools
Revision 163489
Author lforsch...@apple.com
Date 2014-02-05 16:43:40 -0800 (Wed, 05 Feb 2014)
Log Message
Merged r163411.
Modified Paths
tags/Safari-538.16.2/Tools/ChangeLog
tags/Safari-538.16.2/Tools/Scripts/export-llvm-build
Diff
Modified: tags/Safari-538.16.2/Tools/ChangeLog (163488 => 163489)
--- tags/Safari-538.16.2/Tools/ChangeLog 2014-02-06 00:42:58 UTC (rev 163488)
+++ tags/Safari-538.16.2/Tools/ChangeLog 2014-02-06 00:43:40 UTC (rev 163489)
@@ -1,3 +1,18 @@
+2014-02-05 Lucas Forschler
+
+Merge r163411
+
+2014-02-04 Filip Pizlo
+
+export-llvm-build should work with git checkouts
+https://bugs.webkit.org/show_bug.cgi?id=128217
+
+Reviewed by Mark Hahnenberg.
+
+If svn export fails, just do ditto.
+
+* Scripts/export-llvm-build:
+
2014-02-03 Krzysztof Czech
[ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
Modified: tags/Safari-538.16.2/Tools/Scripts/export-llvm-build (163488 => 163489)
--- tags/Safari-538.16.2/Tools/Scripts/export-llvm-build 2014-02-06 00:42:58 UTC (rev 163488)
+++ tags/Safari-538.16.2/Tools/Scripts/export-llvm-build 2014-02-06 00:43:40 UTC (rev 163489)
@@ -32,7 +32,7 @@
cmd = cmd.map{|value| value.to_s}
commandArray = cmd.map{|value| Shellwords.shellescape(value)}.join(' ')
$stderr.puts ">> #{commandArray}"
-riase unless system(*cmd)
+raise unless system(*cmd)
end
$libraryPackage = Pathname.new("LLVMLibraries.tar.bz2")
@@ -110,7 +110,11 @@
| directory |
directory = Pathname.new(directory).realpath
Dir.chdir($llvmPath) {
-mysys("svn", "export", "include", (directory + "include").to_s)
+begin
+mysys("svn", "export", "include", directory + "include")
+rescue
+mysys("ditto", "include", directory + "include")
+end
}
["include/llvm/Config"].each {
| genDirName |
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163490] tags/Safari-538.16.2
Title: [163490] tags/Safari-538.16.2 Revision 163490 Author lforsch...@apple.com Date 2014-02-05 16:46:36 -0800 (Wed, 05 Feb 2014) Log Message Merged r163418. Modified Paths tags/Safari-538.16.2/LayoutTests/ChangeLog tags/Safari-538.16.2/LayoutTests/js/script-tests/dfg-convert-this-dom-window.js tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog tags/Safari-538.16.2/Source/_javascript_Core/bytecode/CodeBlock.h tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGArrayMode.cpp tags/Safari-538.16.2/Source/_javascript_Core/dfg/DFGArrayMode.h tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp tags/Safari-538.16.2/Source/_javascript_Core/jit/JITPropertyAccess.cpp tags/Safari-538.16.2/Source/_javascript_Core/jsc.cpp tags/Safari-538.16.2/Source/_javascript_Core/runtime/TestRunnerUtils.cpp tags/Safari-538.16.2/Source/_javascript_Core/runtime/TestRunnerUtils.h tags/Safari-538.16.2/Tools/ChangeLog tags/Safari-538.16.2/Tools/Scripts/run-jsc-stress-tests Added Paths tags/Safari-538.16.2/Source/_javascript_Core/tests/stress/float32-repeat-out-of-bounds.js tags/Safari-538.16.2/Source/_javascript_Core/tests/stress/int8-repeat-out-of-bounds.js tags/Safari-538.16.2/Source/_javascript_Core/tests/stress/string-out-of-bounds-negative-proto-value.js Removed Paths tags/Safari-538.16.2/LayoutTests/js/dfg-string-out-of-bounds-negative-proto-value-expected.txt tags/Safari-538.16.2/LayoutTests/js/dfg-string-out-of-bounds-negative-proto-value.html tags/Safari-538.16.2/LayoutTests/js/script-tests/dfg-string-out-of-bounds-negative-proto-value.js Diff Modified: tags/Safari-538.16.2/LayoutTests/ChangeLog (163489 => 163490) --- tags/Safari-538.16.2/LayoutTests/ChangeLog 2014-02-06 00:43:40 UTC (rev 163489) +++ tags/Safari-538.16.2/LayoutTests/ChangeLog 2014-02-06 00:46:36 UTC (rev 163490) @@ -1,3 +1,24 @@ +2014-02-05 Lucas Forschler + +Merge r163418 + +2014-02-04 Filip Pizlo + +DFG PutByVal on typed arrays should detect OutOfBounds sooner +https://bugs.webkit.org/show_bug.cgi?id=128162 + +Reviewed by Mark Hahnenberg. + +dfg-string-out-of-blahblah was moved to JSC/tests/stress. + +dfg-convert-this-dom-window was using dfgShouldBe() incorrectly and this got revealed +by my TestRunnerUtils refactoring. + +* js/dfg-string-out-of-bounds-negative-proto-value-expected.txt: Removed. +* js/dfg-string-out-of-bounds-negative-proto-value.html: Removed. +* js/script-tests/dfg-convert-this-dom-window.js: +* js/script-tests/dfg-string-out-of-bounds-negative-proto-value.js: Removed. + 2014-02-04 Lucas Forschler Rollout r163280. Deleted: tags/Safari-538.16.2/LayoutTests/js/dfg-string-out-of-bounds-negative-proto-value-expected.txt (163489 => 163490) --- tags/Safari-538.16.2/LayoutTests/js/dfg-string-out-of-bounds-negative-proto-value-expected.txt 2014-02-06 00:43:40 UTC (rev 163489) +++ tags/Safari-538.16.2/LayoutTests/js/dfg-string-out-of-bounds-negative-proto-value-expected.txt 2014-02-06 00:46:36 UTC (rev 163490) @@ -1,9 +0,0 @@ -Tests what happens when you do a negative out-of-bounds access on a string while the prototype has a negative indexed property. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -Passed some tests silently. - -TEST COMPLETE - Deleted: tags/Safari-538.16.2/LayoutTests/js/dfg-string-out-of-bounds-negative-proto-value.html (163489 => 163490) --- tags/Safari-538.16.2/LayoutTests/js/dfg-string-out-of-bounds-negative-proto-value.html 2014-02-06 00:43:40 UTC (rev 163489) +++ tags/Safari-538.16.2/LayoutTests/js/dfg-string-out-of-bounds-negative-proto-value.html 2014-02-06 00:46:36 UTC (rev 163490) @@ -1,10 +0,0 @@ - - - -
[webkit-changes] [163488] tags/Safari-538.16.2/Source/JavaScriptCore
Title: [163488] tags/Safari-538.16.2/Source/_javascript_Core Revision 163488 Author lforsch...@apple.com Date 2014-02-05 16:42:58 -0800 (Wed, 05 Feb 2014) Log Message Merged r163366. Modified Paths tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog tags/Safari-538.16.2/Source/_javascript_Core/runtime/Options.h Diff Modified: tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog (163487 => 163488) --- tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:28:30 UTC (rev 163487) +++ tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:42:58 UTC (rev 163488) @@ -1,5 +1,18 @@ 2014-02-05 Lucas Forschler +Merge r163366 + +2014-02-03 Filip Pizlo + +Lift the FTL tier-up threshold from 25000 to 10 +https://bugs.webkit.org/show_bug.cgi?id=128158 + +Rubber stamped by Michael Saboff. + +* runtime/Options.h: + +2014-02-05 Lucas Forschler + Merge r163324 2014-02-03 Matthew Mirman Modified: tags/Safari-538.16.2/Source/_javascript_Core/runtime/Options.h (163487 => 163488) --- tags/Safari-538.16.2/Source/_javascript_Core/runtime/Options.h 2014-02-06 00:28:30 UTC (rev 163487) +++ tags/Safari-538.16.2/Source/_javascript_Core/runtime/Options.h 2014-02-06 00:42:58 UTC (rev 163488) @@ -192,7 +192,7 @@ v(int32, executionCounterIncrementForLoop, 1) \ v(int32, executionCounterIncrementForEntry, 15) \ \ -v(int32, thresholdForFTLOptimizeAfterWarmUp, 25000) \ +v(int32, thresholdForFTLOptimizeAfterWarmUp, 10) \ v(int32, thresholdForFTLOptimizeSoon, 1000) \ v(int32, ftlTierUpCounterIncrementForLoop, 1) \ v(int32, ftlTierUpCounterIncrementForReturn, 15) \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163487] tags/Safari-538.16.2/Source/JavaScriptCore
Title: [163487] tags/Safari-538.16.2/Source/_javascript_Core
Revision 163487
Author lforsch...@apple.com
Date 2014-02-05 16:28:30 -0800 (Wed, 05 Feb 2014)
Log Message
Merged r163324.
Modified Paths
tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog
tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h
tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLCapabilities.cpp
tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
Added Paths
tags/Safari-538.16.2/Source/_javascript_Core/tests/stress/ftl-gettypedarrayoffset-simple.js
tags/Safari-538.16.2/Source/_javascript_Core/tests/stress/ftl-gettypedarrayoffset-wasteful.js
Diff
Modified: tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog (163486 => 163487)
--- tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:20:42 UTC (rev 163486)
+++ tags/Safari-538.16.2/Source/_javascript_Core/ChangeLog 2014-02-06 00:28:30 UTC (rev 163487)
@@ -1,3 +1,25 @@
+2014-02-05 Lucas Forschler
+
+Merge r163324
+
+2014-02-03 Matthew Mirman
+
+Added GetTypedArrayByteOffset to FTL
+https://bugs.webkit.org/show_bug.cgi?id=127589
+
+Reviewed by Filip Pizlo.
+
+* ftl/FTLAbstractHeapRepository.h:
+* ftl/FTLCapabilities.cpp:
+(JSC::FTL::canCompile):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileNode):
+(JSC::FTL::LowerDFGToLLVM::compileGetTypedArrayByteOffset):
+* tests/stress/ftl-gettypedarrayoffset-simple.js: Added.
+(foo):
+* tests/stress/ftl-gettypedarrayoffset-wasteful.js: Added.
+(foo):
+
2014-02-03 Dan Bernstein
Correctly address Darin’s review comment on the last change.
Modified: tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h (163486 => 163487)
--- tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h 2014-02-06 00:20:42 UTC (rev 163486)
+++ tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h 2014-02-06 00:28:30 UTC (rev 163487)
@@ -42,6 +42,8 @@
macro(WriteBarrierBuffer_bufferContents)
#define FOR_EACH_ABSTRACT_FIELD(macro) \
+macro(ArrayBuffer_data, ArrayBuffer::offsetOfData()) \
+macro(Butterfly_arrayBuffer, Butterfly::offsetOfArrayBuffer()) \
macro(Butterfly_publicLength, Butterfly::offsetOfPublicLength()) \
macro(Butterfly_vectorLength, Butterfly::offsetOfVectorLength()) \
macro(CallFrame_callerFrame, CallFrame::callerFrameOffset()) \
Modified: tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLCapabilities.cpp (163486 => 163487)
--- tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLCapabilities.cpp 2014-02-06 00:20:42 UTC (rev 163486)
+++ tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLCapabilities.cpp 2014-02-06 00:28:30 UTC (rev 163487)
@@ -109,6 +109,7 @@
case AllocatePropertyStorage:
case FunctionReentryWatchpoint:
case TypedArrayWatchpoint:
+case GetTypedArrayByteOffset:
case VariableWatchpoint:
case NotifyWrite:
case StoreBarrier:
Modified: tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (163486 => 163487)
--- tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-02-06 00:20:42 UTC (rev 163486)
+++ tags/Safari-538.16.2/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-02-06 00:28:30 UTC (rev 163487)
@@ -434,6 +434,9 @@
case NewArrayWithSize:
compileNewArrayWithSize();
break;
+case GetTypedArrayByteOffset:
+compileGetTypedArrayByteOffset();
+break;
case AllocatePropertyStorage:
compileAllocatePropertyStorage();
break;
@@ -1725,6 +1728,41 @@
BadIndexingType, jsValueValue(cell), 0,
m_out.bitNot(isArrayType(cell, m_node->arrayMode(;
}
+
+void compileGetTypedArrayByteOffset()
+{
+LValue basePtr = lowCell(m_node->child1());
+
+LBasicBlock simpleCase = FTL_NEW_BLOCK(m_out, ("wasteless typed array"));
+LBasicBlock wastefulCase = FTL_NEW_BLOCK(m_out, ("wasteful typed array"));
+LBasicBlock continuation = FTL_NEW_BLOCK(m_out, ("continuation branch"));
+
+LValue baseAddress = m_out.addPtr(basePtr, JSArrayBufferView::offsetOfMode());
+m_out.branch(m_out.notEqual(baseAddress , m_out.constIntPtr(WastefulTypedArray)), simpleCase, wastefulCase);
+
+// begin simple case
+LBasicBlock lastNext = m_out.appendTo(simpleCase, wastefulCase);
+
+ValueFromBlock simpleOut = m_out.anchor(m_out.constIntPtr(0));
+
+m_out.jump(continuation);
+
+// begin wasteful case
+m_out.appendTo(wastefulCase, continuation);
+
+LValue vectorPtr = m_out.loadPtr(basePtr, m_heaps.JSArrayBufferView_vector);
+LValue butterflyPtr = m_out.loadPtr(basePtr,
[webkit-changes] [163486] trunk/Source/WebCore
Title: [163486] trunk/Source/WebCore
Revision 163486
Author aes...@apple.com
Date 2014-02-05 16:20:42 -0800 (Wed, 05 Feb 2014)
Log Message
Buffer incoming data in ContentFilter when using NEFilterSource
https://bugs.webkit.org/show_bug.cgi?id=127979
Reviewed by Sam Weinig.
WebFilterEvaluator buffers incoming data and returns it to us as
replacement data if the load is allowed. NEFilterSource doesn't do
this, so we need to do our own buffering.
* platform/ContentFilter.h: Forward-declared NSMutableData and added
m_originalData.
* platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::ContentFilter): Constructed m_originalData
with an initial capacity (if we know the expected content size).
(WebCore::ContentFilter::addData): Buffered incoming data if we are
using NEFilterSource.
(WebCore::ContentFilter::finishedAddingData):
(WebCore::ContentFilter::getReplacementData): Returned m_originalData
if the load wasn't blocked.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ContentFilter.h
trunk/Source/WebCore/platform/mac/ContentFilterMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (163485 => 163486)
--- trunk/Source/WebCore/ChangeLog 2014-02-06 00:13:04 UTC (rev 163485)
+++ trunk/Source/WebCore/ChangeLog 2014-02-06 00:20:42 UTC (rev 163486)
@@ -1,3 +1,25 @@
+2014-02-04 Andy Estes
+
+Buffer incoming data in ContentFilter when using NEFilterSource
+https://bugs.webkit.org/show_bug.cgi?id=127979
+
+Reviewed by Sam Weinig.
+
+WebFilterEvaluator buffers incoming data and returns it to us as
+replacement data if the load is allowed. NEFilterSource doesn't do
+this, so we need to do our own buffering.
+
+* platform/ContentFilter.h: Forward-declared NSMutableData and added
+m_originalData.
+* platform/mac/ContentFilterMac.mm:
+(WebCore::ContentFilter::ContentFilter): Constructed m_originalData
+with an initial capacity (if we know the expected content size).
+(WebCore::ContentFilter::addData): Buffered incoming data if we are
+using NEFilterSource.
+(WebCore::ContentFilter::finishedAddingData):
+(WebCore::ContentFilter::getReplacementData): Returned m_originalData
+if the load wasn't blocked.
+
2014-02-05 Andreas Kling
Remove ENABLE(DIRECTORY_UPLOAD).
Modified: trunk/Source/WebCore/platform/ContentFilter.h (163485 => 163486)
--- trunk/Source/WebCore/platform/ContentFilter.h 2014-02-06 00:13:04 UTC (rev 163485)
+++ trunk/Source/WebCore/platform/ContentFilter.h 2014-02-06 00:20:42 UTC (rev 163486)
@@ -37,6 +37,7 @@
#endif
#if PLATFORM(MAC)
+OBJC_CLASS NSMutableData;
OBJC_CLASS WebFilterEvaluator;
#endif
@@ -82,7 +83,7 @@
std::atomic m_neFilterSourceStatus;
RetainPtr m_neFilterSource;
dispatch_queue_t m_neFilterSourceQueue;
-dispatch_semaphore_t m_neFilterSourceSemaphore;
+RetainPtr m_originalData;
#endif
};
Modified: trunk/Source/WebCore/platform/mac/ContentFilterMac.mm (163485 => 163486)
--- trunk/Source/WebCore/platform/mac/ContentFilterMac.mm 2014-02-06 00:13:04 UTC (rev 163485)
+++ trunk/Source/WebCore/platform/mac/ContentFilterMac.mm 2014-02-06 00:20:42 UTC (rev 163486)
@@ -102,6 +102,12 @@
if ([getNEFilterSourceClass() filterRequired]) {
m_neFilterSource = adoptNS([[getNEFilterSourceClass() alloc] initWithURL:[response.nsURLResponse() URL] direction:NEFilterSourceDirectionInbound socketIdentifier:0]);
m_neFilterSourceQueue = dispatch_queue_create("com.apple.WebCore.NEFilterSourceQueue", DISPATCH_QUEUE_SERIAL);
+
+long long expectedContentSize = [response.nsURLResponse() expectedContentLength];
+if (expectedContentSize < 0 || expectedContentSize > NSUIntegerMax)
+m_originalData = adoptNS([[NSMutableData alloc] init]);
+else
+m_originalData = adoptNS([[NSMutableData alloc] initWithCapacity:(NSUInteger)expectedContentSize]);
}
#endif
}
@@ -136,11 +142,25 @@
if (!m_neFilterSource)
return;
+// FIXME: NEFilterSource doesn't buffer data like WebFilterEvaluator does,
+// so we need to do it ourselves so getReplacementData() can return the
+// original bytes back to the loader. We should find a way to remove this
+// additional copy.
+[m_originalData appendBytes:data length:length];
+
ref();
-[m_neFilterSource addData:[NSData dataWithBytesNoCopy:(void*)data length:length freeWhenDone:NO] withCompletionQueue:m_neFilterSourceQueue completionHandler:^(NEFilterSourceStatus status, NSData *) {
- m_neFilterSourceStatus = status;
- deref();
+dispatch_semaphore_t neFilterSourceSemaphore = dispatch_semaphore_create(0);
+[m_neFilterSource addData:[NSData dataWithBytes:(void*)data length:length] withCompletionQueue:m_neFilterSourceQueue completionHandler:^(NEFilterSourceStatus status, NSData *) {
+m_neFilterSourceStatus = status;
+d
[webkit-changes] [163485] tags/Safari-538.16.2/Source
Title: [163485] tags/Safari-538.16.2/Source Revision 163485 Author lforsch...@apple.com Date 2014-02-05 16:13:04 -0800 (Wed, 05 Feb 2014) Log Message Versioning. Modified Paths tags/Safari-538.16.2/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-538.16.2/Source/WebCore/Configurations/Version.xcconfig tags/Safari-538.16.2/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-538.16.2/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-538.16.2/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-538.16.2/Source/_javascript_Core/Configurations/Version.xcconfig (163484 => 163485) --- tags/Safari-538.16.2/Source/_javascript_Core/Configurations/Version.xcconfig 2014-02-06 00:10:33 UTC (rev 163484) +++ tags/Safari-538.16.2/Source/_javascript_Core/Configurations/Version.xcconfig 2014-02-06 00:13:04 UTC (rev 163485) @@ -23,7 +23,7 @@ MAJOR_VERSION = 538; MINOR_VERSION = 16; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-538.16.2/Source/WebCore/Configurations/Version.xcconfig (163484 => 163485) --- tags/Safari-538.16.2/Source/WebCore/Configurations/Version.xcconfig 2014-02-06 00:10:33 UTC (rev 163484) +++ tags/Safari-538.16.2/Source/WebCore/Configurations/Version.xcconfig 2014-02-06 00:13:04 UTC (rev 163485) @@ -23,7 +23,7 @@ MAJOR_VERSION = 538; MINOR_VERSION = 16; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-538.16.2/Source/WebInspectorUI/Configurations/Version.xcconfig (163484 => 163485) --- tags/Safari-538.16.2/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-02-06 00:10:33 UTC (rev 163484) +++ tags/Safari-538.16.2/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-02-06 00:13:04 UTC (rev 163485) @@ -1,6 +1,6 @@ MAJOR_VERSION = 538; MINOR_VERSION = 16; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The system version prefix is based on the current system version. Modified: tags/Safari-538.16.2/Source/WebKit/mac/Configurations/Version.xcconfig (163484 => 163485) --- tags/Safari-538.16.2/Source/WebKit/mac/Configurations/Version.xcconfig 2014-02-06 00:10:33 UTC (rev 163484) +++ tags/Safari-538.16.2/Source/WebKit/mac/Configurations/Version.xcconfig 2014-02-06 00:13:04 UTC (rev 163485) @@ -23,7 +23,7 @@ MAJOR_VERSION = 538; MINOR_VERSION = 16; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-538.16.2/Source/WebKit2/Configurations/Version.xcconfig (163484 => 163485) --- tags/Safari-538.16.2/Source/WebKit2/Configurations/Version.xcconfig 2014-02-06 00:10:33 UTC (rev 163484) +++ tags/Safari-538.16.2/Source/WebKit2/Configurations/Version.xcconfig 2014-02-06 00:13:04 UTC (rev 163485) @@ -23,7 +23,7 @@ MAJOR_VERSION = 538; MINOR_VERSION = 16; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163484] tags/Safari-538.16.2/
Title: [163484] tags/Safari-538.16.2/ Revision 163484 Author lforsch...@apple.com Date 2014-02-05 16:10:33 -0800 (Wed, 05 Feb 2014) Log Message New Tag. Added Paths tags/Safari-538.16.2/ Diff Property changes: tags/Safari-538.16.2 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163482] trunk
Title: [163482] trunk
Revision 163482
Author beid...@apple.com
Date 2014-02-05 15:59:52 -0800 (Wed, 05 Feb 2014)
Log Message
IDB: storage/indexeddb/mozilla/autoincrement-indexes.html fails
https://bugs.webkit.org/show_bug.cgi?id=128257
Reviewed by Sam Weinig.
Source/WebCore:
Tests: storage/indexeddb/mozilla/autoincrement-indexes.html
Add some IDBKeyData utility methods for WK2 to use:
* Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::setArrayValue):
(WebCore::IDBKeyData::setStringValue):
(WebCore::IDBKeyData::setDateValue):
(WebCore::IDBKeyData::setNumberValue):
* Modules/indexeddb/IDBKeyData.h:
* WebCore.exp.in:
Source/WebKit2:
* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::putRecordInBackingStore): Write the correct key to the index if it was auto generated.
(WebKit::UniqueIDBDatabase::getRecordFromBackingStore): If this is an auto increment object store with
a non-empty key path, save the key path to the get result.
* DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata): The IndexRecord schema shouldn’t
have key uniqueness.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putRecord): Take IDBKeyData instead of IDBKey.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getIndexRecord): Fill in the primary key from the fetch.
* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
LayoutTests:
* platform/mac-wk2/TestExpectations: Enable the test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.h
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp
trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h
trunk/Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp
trunk/Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h
Diff
Modified: trunk/LayoutTests/ChangeLog (163481 => 163482)
--- trunk/LayoutTests/ChangeLog 2014-02-05 23:47:28 UTC (rev 163481)
+++ trunk/LayoutTests/ChangeLog 2014-02-05 23:59:52 UTC (rev 163482)
@@ -1,3 +1,12 @@
+2014-02-05 Brady Eidson
+
+IDB: storage/indexeddb/mozilla/autoincrement-indexes.html fails
+https://bugs.webkit.org/show_bug.cgi?id=128257
+
+Reviewed by Sam Weinig.
+
+* platform/mac-wk2/TestExpectations: Enable the test.
+
2014-02-05 Brian Burg
Web Inspector: add probe manager and model objects to the frontend
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (163481 => 163482)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-02-05 23:47:28 UTC (rev 163481)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-02-05 23:59:52 UTC (rev 163482)
@@ -470,7 +470,9 @@
# All IndexedDB tests are skipped in WK1.
# Reenable individual tests here that are known to pass, with the eventual goal of re-enabling the entire directory.
storage/indexeddb/mozilla/add-twice-failure.html [ Pass ]
+storage/indexeddb/mozilla/autoincrement-indexes.html [ Pass ]
+
### END OF (5) Features that are not supported in WebKit1, so skipped in mac/TestExpectations then re-enabled here
Modified: trunk/Source/WebCore/ChangeLog (163481 => 163482)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 23:47:28 UTC (rev 163481)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 23:59:52 UTC (rev 163482)
@@ -1,3 +1,22 @@
+2014-02-05 Brady Eidson
+
+IDB: storage/indexeddb/mozilla/autoincrement-indexes.html fails
+https://bugs.webkit.org/show_bug.cgi?id=128257
+
+Reviewed by Sam Weinig.
+
+Tests: storage/indexeddb/mozilla/autoincrement-indexes.html
+
+Add some IDBKeyData utility methods for WK2 to use:
+* Modules/indexeddb/IDBKeyData.cpp:
+(WebCore::IDBKeyData::setArrayValue):
+(WebCore::IDBKeyData::setStringValue):
+(WebCore::IDBKeyData::setDateValue):
+(WebCore::IDBKeyData::setNumberValue):
+* Modules/indexeddb/IDBKeyData.h:
+
+* WebCore.exp.in:
+
2014-02-05 Andreas Kling
Turn on ENABLE(8BIT_TEXTRUN) for everyone.
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp (163481 => 163482)
--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp 2014-02-05 23:47:28 UTC (rev 163481)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp 2014-02-05 23:59:52 UTC (rev 163482)
@@ -281,6 +281,38 @@
}
#endif
+void IDBKeyData::setArrayValue(const Vector& value)
+{
+*this = IDBKeyData();
+arrayValue = value;
+type = IDBKey::ArrayType;
+isNull = false;
}
+void IDBKeyDat
[webkit-changes] [163481] trunk
Title: [163481] trunk
Revision 163481
Author fpi...@apple.com
Date 2014-02-05 15:47:28 -0800 (Wed, 05 Feb 2014)
Log Message
Rename useExperimentalFTL to useFTLJIT.
Rubber stamped by Mark Hahnenberg.
Source/_javascript_Core:
* dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
* runtime/Options.h:
Tools:
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGTierUpCheckInjectionPhase.cpp
trunk/Source/_javascript_Core/runtime/Options.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163480 => 163481)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-05 23:40:26 UTC (rev 163480)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-05 23:47:28 UTC (rev 163481)
@@ -1,3 +1,13 @@
+2014-02-05 Filip Pizlo
+
+Rename useExperimentalFTL to useFTLJIT.
+
+Rubber stamped by Mark Hahnenberg.
+
+* dfg/DFGTierUpCheckInjectionPhase.cpp:
+(JSC::DFG::TierUpCheckInjectionPhase::run):
+* runtime/Options.h:
+
2014-02-05 Brian Burg
Web Inspector: add probe manager and model objects to the frontend
Modified: trunk/Source/_javascript_Core/dfg/DFGTierUpCheckInjectionPhase.cpp (163480 => 163481)
--- trunk/Source/_javascript_Core/dfg/DFGTierUpCheckInjectionPhase.cpp 2014-02-05 23:40:26 UTC (rev 163480)
+++ trunk/Source/_javascript_Core/dfg/DFGTierUpCheckInjectionPhase.cpp 2014-02-05 23:47:28 UTC (rev 163481)
@@ -47,7 +47,7 @@
{
RELEASE_ASSERT(m_graph.m_plan.mode == DFGMode);
-if (!Options::useExperimentalFTL())
+if (!Options::useFTLJIT())
return false;
if (m_graph.m_profiledBlock->m_didFailFTLCompilation)
Modified: trunk/Source/_javascript_Core/runtime/Options.h (163480 => 163481)
--- trunk/Source/_javascript_Core/runtime/Options.h 2014-02-05 23:40:26 UTC (rev 163480)
+++ trunk/Source/_javascript_Core/runtime/Options.h 2014-02-05 23:47:28 UTC (rev 163481)
@@ -136,7 +136,7 @@
v(bool, enableOSREntryToDFG, true) \
v(bool, enableOSREntryToFTL, true) \
\
-v(bool, useExperimentalFTL, false) \
+v(bool, useFTLJIT, false) \
v(bool, enableExperimentalFTLCoverage, false) \
v(bool, useFTLTBAA, true) \
v(bool, enableLLVMFastISel, false) \
Modified: trunk/Tools/ChangeLog (163480 => 163481)
--- trunk/Tools/ChangeLog 2014-02-05 23:40:26 UTC (rev 163480)
+++ trunk/Tools/ChangeLog 2014-02-05 23:47:28 UTC (rev 163481)
@@ -1,5 +1,13 @@
2014-02-05 Filip Pizlo
+Rename useExperimentalFTL to useFTLJIT.
+
+Rubber stamped by Mark Hahnenberg.
+
+* Scripts/run-jsc-stress-tests:
+
+2014-02-05 Filip Pizlo
+
JSC on Mac should pull LLVM from prefix=/usr/local/LLVMForJavaScriptCore and not /usr/local
https://bugs.webkit.org/show_bug.cgi?id=128269
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (163480 => 163481)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2014-02-05 23:40:26 UTC (rev 163480)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2014-02-05 23:47:28 UTC (rev 163481)
@@ -180,7 +180,7 @@
EAGER_OPTIONS = ["--thresholdForJITAfterWarmUp=10", "--thresholdForJITSoon=10", "--thresholdForOptimizeAfterWarmUp=20", "--thresholdForOptimizeAfterLongWarmUp=20", "--thresholdForOptimizeSoon=20", "--thresholdForFTLOptimizeAfterWarmUp=20", "--thresholdForFTLOptimizeSoon=20"]
-FTL_OPTIONS = ["--useExperimentalFTL=true", "--enableExperimentalFTLCoverage=true"]
+FTL_OPTIONS = ["--useFTLJIT=true", "--enableExperimentalFTLCoverage=true"]
$runlist = []
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163479] branches/safari-537.74-branch/LayoutTests
Title: [163479] branches/safari-537.74-branch/LayoutTests
Revision 163479
Author za...@apple.com
Date 2014-02-05 15:38:29 -0800 (Wed, 05 Feb 2014)
Log Message
Update expected result for media/video-controls-captions-trackmenu-sorted.html
* platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
Modified Paths
branches/safari-537.74-branch/LayoutTests/ChangeLog
branches/safari-537.74-branch/LayoutTests/platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt
Diff
Modified: branches/safari-537.74-branch/LayoutTests/ChangeLog (163478 => 163479)
--- branches/safari-537.74-branch/LayoutTests/ChangeLog 2014-02-05 23:30:10 UTC (rev 163478)
+++ branches/safari-537.74-branch/LayoutTests/ChangeLog 2014-02-05 23:38:29 UTC (rev 163479)
@@ -1,3 +1,9 @@
+2014-02-05 Zalan Bujtas
+
+Update expected result for media/video-controls-captions-trackmenu-sorted.html
+
+* platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
+
2014-02-04 Zalan Bujtas
Fix src path for js-test-*.js
Modified: branches/safari-537.74-branch/LayoutTests/platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt (163478 => 163479)
--- branches/safari-537.74-branch/LayoutTests/platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt 2014-02-05 23:30:10 UTC (rev 163478)
+++ branches/safari-537.74-branch/LayoutTests/platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt 2014-02-05 23:38:29 UTC (rev 163479)
@@ -25,11 +25,11 @@
RUN(internals.settings.setShouldDisplayTrackKind('Subtitles', true))
EXPECTED (trackMenuItems[0].textContent == 'Off') OK
EXPECTED (trackMenuItems[1].textContent == 'Auto (Recommended)') OK
-EXPECTED (trackMenuItems[2].textContent == 'z (Japanese)'), OBSERVED 'w (Japanese)' FAIL
-EXPECTED (trackMenuItems[3].textContent == 'v (English)'), OBSERVED 'z (Japanese)' FAIL
-EXPECTED (trackMenuItems[4].textContent == 'x (English-Australia)'), OBSERVED 'u (English)' FAIL
+EXPECTED (trackMenuItems[2].textContent == 'z (Japanese)') OK
+EXPECTED (trackMenuItems[3].textContent == 'v (English)') OK
+EXPECTED (trackMenuItems[4].textContent == 'x (English-Australia)') OK
EXPECTED (video.textTracks.length == '6') OK
-EXPECTED (trackMenuItems.length == '5'), OBSERVED '8' FAIL
+EXPECTED (trackMenuItems.length == '5') OK
END OF TEST
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163478] trunk/Source
Title: [163478] trunk/Source
Revision 163478
Author akl...@apple.com
Date 2014-02-05 15:30:10 -0800 (Wed, 05 Feb 2014)
Log Message
Turn on ENABLE(8BIT_TEXTRUN) for everyone.
Reviewed by Anders Carlsson.
* platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::subRun):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun):
* rendering/RenderBlock.h:
Modified Paths
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/TextRun.h
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
Diff
Modified: trunk/Source/WTF/wtf/FeatureDefines.h (163477 => 163478)
--- trunk/Source/WTF/wtf/FeatureDefines.h 2014-02-05 22:21:40 UTC (rev 163477)
+++ trunk/Source/WTF/wtf/FeatureDefines.h 2014-02-05 23:30:10 UTC (rev 163478)
@@ -60,10 +60,6 @@
#define ENABLE_ASYNC_SCROLLING 1
#endif
-#if !defined(ENABLE_8BIT_TEXTRUN)
-#define ENABLE_8BIT_TEXTRUN 1
-#endif
-
#if !defined(ENABLE_CONTEXT_MENUS)
#define ENABLE_CONTEXT_MENUS 0
#endif
@@ -169,10 +165,6 @@
/* - Apple MAC port (not IOS) - */
#if PLATFORM(MAC) && !PLATFORM(IOS)
-#if !defined(ENABLE_8BIT_TEXTRUN)
-#define ENABLE_8BIT_TEXTRUN 1
-#endif
-
#if !defined(ENABLE_CSS_IMAGE_SET)
#define ENABLE_CSS_IMAGE_SET 1
#endif
@@ -312,10 +304,6 @@
#define ENABLE_SUBPIXEL_LAYOUT 1
#endif
-#if !defined(ENABLE_8BIT_TEXTRUN)
-#define ENABLE_8BIT_TEXTRUN 1
-#endif
-
#endif /* PLATFORM(EFL) */
/* - Gtk port (Unix, Windows, Mac) - */
@@ -331,10 +319,6 @@
#define ENABLE_SUBPIXEL_LAYOUT 1
#endif
-#if !defined(ENABLE_8BIT_TEXTRUN)
-#define ENABLE_8BIT_TEXTRUN 1
-#endif
-
#endif /* PLATFORM(GTK) */
/* ENABLE macro defaults for WebCore */
@@ -344,10 +328,6 @@
#define ENABLE_3D_RENDERING 0
#endif
-#if !defined(ENABLE_8BIT_TEXTRUN)
-#define ENABLE_8BIT_TEXTRUN 0
-#endif
-
#if !defined(ENABLE_ACCELERATED_2D_CANVAS)
#define ENABLE_ACCELERATED_2D_CANVAS 0
#endif
Modified: trunk/Source/WebCore/ChangeLog (163477 => 163478)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 22:21:40 UTC (rev 163477)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 23:30:10 UTC (rev 163478)
@@ -1,3 +1,17 @@
+2014-02-05 Andreas Kling
+
+Turn on ENABLE(8BIT_TEXTRUN) for everyone.
+
+
+Reviewed by Anders Carlsson.
+
+* platform/graphics/TextRun.h:
+(WebCore::TextRun::TextRun):
+(WebCore::TextRun::subRun):
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::constructTextRun):
+* rendering/RenderBlock.h:
+
2014-02-05 Enrica Casucci
WK2: Caret, selections and autocorrection bubbles are incorrectly positioned when inside an iframe.
Modified: trunk/Source/WebCore/platform/graphics/TextRun.h (163477 => 163478)
--- trunk/Source/WebCore/platform/graphics/TextRun.h 2014-02-05 22:21:40 UTC (rev 163477)
+++ trunk/Source/WebCore/platform/graphics/TextRun.h 2014-02-05 23:30:10 UTC (rev 163478)
@@ -59,7 +59,6 @@
typedef unsigned RoundingHacks;
-#if ENABLE(8BIT_TEXTRUN)
TextRun(const LChar* c, unsigned len, float xpos = 0, float expansion = 0, ExpansionBehavior expansionBehavior = AllowTrailingExpansion | ForbidLeadingExpansion, TextDirection direction = LTR, bool directionalOverride = false, bool characterScanForCodePath = true, RoundingHacks roundingHacks = RunRounding | WordRounding)
: m_charactersLength(len)
, m_len(len)
@@ -79,7 +78,6 @@
{
m_data.characters8 = c;
}
-#endif
TextRun(const UChar* c, unsigned len, float xpos = 0, float expansion = 0, ExpansionBehavior expansionBehavior = AllowTrailingExpansion | ForbidLeadingExpansion, TextDirection direction = LTR, bool directionalOverride = false, bool characterScanForCodePath = true, RoundingHacks roundingHacks = RunRounding | WordRounding)
: m_charactersLength(len)
@@ -117,7 +115,6 @@
, m_disableSpacing(false)
, m_tabSize(0)
{
-#if ENABLE(8BIT_TEXTRUN)
if (m_charactersLength && s.is8Bit()) {
m_data.characters8 = s.characters8();
m_is8Bit = true;
@@ -125,10 +122,6 @@
m_data.characters16 = s.deprecatedCharacters();
m_is8Bit = false;
}
-#else
-m_data.characters16 = s.deprecatedCharacters();
-m_is8Bit = false;
-#endif
}
TextRun subRun(unsigned startOffset, unsigned length) const
@@ -137,14 +130,10 @@
TextRun result = *this;
-#if ENABLE(8BIT_TEXTRUN)
if (is8Bit()) {
result.setText(data8(startOffset), length);
return result;
}
-#else
-ASSERT(!is8Bit());
-#endif
result.setText(data16(startOffset), length);
return result;
}
@@ -166,9 +155,7 @@
return String(m_data.characters16, m_len);
}
-#if ENABLE(8BIT_TEXTRUN)
void setText(const LChar* c, unsigned len) { m_data.characters8 = c; m_len = len; m_is8Bi
[webkit-changes] [163476] trunk/Source
Title: [163476] trunk/Source
Revision 163476
Author enr...@apple.com
Date 2014-02-05 13:54:49 -0800 (Wed, 05 Feb 2014)
Log Message
WK2: Caret, selections and autocorrection bubbles are incorrectly positioned when inside an iframe.
https://bugs.webkit.org/show_bug.cgi?id=128264
Reviewed by Simon Fraser.
Source/WebCore:
Adding new exported function.
* WebCore.exp.in:
Source/WebKit2:
Everywhere we return rectangles to the UIProcess, we need to convert them
to root view coordinates. Also, we should allow hit testing to go into child
frames.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::updateSelectionWithTouches):
(WebKit::WebPage::convertSelectionRectsToRootView):
(WebKit::WebPage::requestAutocorrectionData):
(WebKit::WebPage::getPositionInformation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (163475 => 163476)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 21:50:55 UTC (rev 163475)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 21:54:49 UTC (rev 163476)
@@ -1,3 +1,15 @@
+2014-02-05 Enrica Casucci
+
+WK2: Caret, selections and autocorrection bubbles are incorrectly positioned when inside an iframe.
+https://bugs.webkit.org/show_bug.cgi?id=128264
+
+
+Reviewed by Simon Fraser.
+
+Adding new exported function.
+
+* WebCore.exp.in:
+
2014-02-05 Antti Koivisto
ElementRuleCollector should not use StyleResolver::State
Modified: trunk/Source/WebCore/WebCore.exp.in (163475 => 163476)
--- trunk/Source/WebCore/WebCore.exp.in 2014-02-05 21:50:55 UTC (rev 163475)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-02-05 21:54:49 UTC (rev 163476)
@@ -1434,6 +1434,7 @@
__ZNK7WebCore10ScrollView16windowToContentsERKNS_8IntPointE
__ZNK7WebCore10ScrollView18contentsToRootViewERKNS_7IntRectE
__ZNK7WebCore10ScrollView18contentsToRootViewERKNS_8IntPointE
+__ZNK7WebCore10ScrollView18rootViewToContentsERKNS_8IntPointE
__ZNK7WebCore10ScrollView23rootViewToTotalContentsERKNS_8IntPointE
__ZNK7WebCore10ScrollView30scrollOffsetRelativeToDocumentEv
__ZNK7WebCore10StorageMap6lengthEv
Modified: trunk/Source/WebKit2/ChangeLog (163475 => 163476)
--- trunk/Source/WebKit2/ChangeLog 2014-02-05 21:50:55 UTC (rev 163475)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-05 21:54:49 UTC (rev 163476)
@@ -1,3 +1,25 @@
+2014-02-05 Enrica Casucci
+
+WK2: Caret, selections and autocorrection bubbles are incorrectly positioned when inside an iframe.
+https://bugs.webkit.org/show_bug.cgi?id=128264
+
+
+Reviewed by Simon Fraser.
+
+Everywhere we return rectangles to the UIProcess, we need to convert them
+to root view coordinates. Also, we should allow hit testing to go into child
+frames.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::editorState):
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::selectWithGesture):
+(WebKit::WebPage::updateSelectionWithTouches):
+(WebKit::WebPage::convertSelectionRectsToRootView):
+(WebKit::WebPage::requestAutocorrectionData):
+(WebKit::WebPage::getPositionInformation):
+
2014-02-05 Dan Bernstein
[Cocoa] WKRemoteObjectInterface fails with doubles, NSNull, and empty NSStrings
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (163475 => 163476)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-02-05 21:50:55 UTC (rev 163475)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-02-05 21:54:49 UTC (rev 163476)
@@ -666,16 +666,18 @@
result.lastMarkedRect = result.firstMarkedRect;
result.markedText = plainText(compositionRange.get());
}
+FrameView* view = frame.view();
if (selection.isCaret()) {
-result.caretRectAtStart = frame.selection().absoluteCaretBounds();
+result.caretRectAtStart = view->contentsToRootView(frame.selection().absoluteCaretBounds());
result.caretRectAtEnd = result.caretRectAtStart;
if (m_shouldReturnWordAtSelection)
result.wordAtSelection = plainText(wordRangeFromPosition(selection.start()).get());
} else if (selection.isRange()) {
-result.caretRectAtStart = VisiblePosition(selection.start()).absoluteCaretBounds();
-result.caretRectAtEnd = VisiblePosition(selection.end()).absoluteCaretBounds();
+result.caretRectAtStart = view->contentsToRootView(VisiblePosition(selection.start()).absoluteCaretBounds());
+result.caretRectAtEnd = view->contentsToRootView(
[webkit-changes] [163475] trunk
Title: [163475] trunk
Revision 163475
Author an...@apple.com
Date 2014-02-05 13:50:55 -0800 (Wed, 05 Feb 2014)
Log Message
ElementRuleCollector should not use StyleResolver::State
https://bugs.webkit.org/show_bug.cgi?id=128247
Source/WebCore:
Reviewed by Andreas Kling.
Make ElementRuleCollector more reusable.
* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUARules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::ElementRuleCollector::matchAllRules):
* css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::ElementRuleCollector):
Pass the objects that are actually needed rather than the entire State.
LayoutTests:
Reviewed by Andreas Kling.
* platform/mac/fast/parser/xhtml-alternate-entities-expected.png:
* platform/mac/fast/parser/xhtml-alternate-entities-expected.txt: This is a progression.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.png
trunk/LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/ElementRuleCollector.cpp
trunk/Source/WebCore/css/ElementRuleCollector.h
trunk/Source/WebCore/css/StyleResolver.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (163474 => 163475)
--- trunk/LayoutTests/ChangeLog 2014-02-05 21:44:26 UTC (rev 163474)
+++ trunk/LayoutTests/ChangeLog 2014-02-05 21:50:55 UTC (rev 163475)
@@ -1,3 +1,13 @@
+2014-02-05 Antti Koivisto
+
+ElementRuleCollector should not use StyleResolver::State
+https://bugs.webkit.org/show_bug.cgi?id=128247
+
+Reviewed by Andreas Kling.
+
+* platform/mac/fast/parser/xhtml-alternate-entities-expected.png:
+* platform/mac/fast/parser/xhtml-alternate-entities-expected.txt: This is a progression.
+
2014-02-05 Yuki Sekiguchi
Ruby base oddly justify its text when the text is ideograph and it contains on Mac.
Modified: trunk/LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.txt (163474 => 163475)
--- trunk/LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.txt 2014-02-05 21:44:26 UTC (rev 163474)
+++ trunk/LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.txt 2014-02-05 21:50:55 UTC (rev 163475)
@@ -18,7 +18,7 @@
RenderText {#text} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
- RenderInline {p} at (0,0) size 489x18
+ RenderInline {p} at (0,0) size 489x18 [color=#FF]
RenderInline {font} at (0,0) size 489x18
RenderText {#text} at (0,0) size 489x18
text run at (0,0) width 263: "This should be the only line on this page. "
Modified: trunk/Source/WebCore/ChangeLog (163474 => 163475)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 21:44:26 UTC (rev 163474)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 21:50:55 UTC (rev 163475)
@@ -1,3 +1,25 @@
+2014-02-05 Antti Koivisto
+
+ElementRuleCollector should not use StyleResolver::State
+https://bugs.webkit.org/show_bug.cgi?id=128247
+
+Reviewed by Andreas Kling.
+
+Make ElementRuleCollector more reusable.
+
+* css/ElementRuleCollector.cpp:
+(WebCore::ElementRuleCollector::collectMatchingRules):
+(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
+(WebCore::ElementRuleCollector::matchAuthorRules):
+(WebCore::ElementRuleCollector::matchUARules):
+(WebCore::ElementRuleCollector::ruleMatches):
+(WebCore::ElementRuleCollector::collectMatchingRulesForList):
+(WebCore::ElementRuleCollector::matchAllRules):
+* css/ElementRuleCollector.h:
+(WebCore::ElementRuleCollector::ElementRuleCollector):
+
+Pass the objects that are actually needed rather than the entire State.
+
2014-02-05 Brent Fulgham
[Mac] Correct copy/paste error in scrolling code.
Modified: trunk/Source/WebCore/css/ElementRuleCollector.cpp (163474 => 163475)
--- trunk/Source/WebCore/css/ElementRuleCollector.cpp 2014-02-05 21:44:26 UTC (rev 163474)
+++ trunk/Source/WebCore/css/ElementRuleCollector.cpp 2014-02-05 21:50:55 UTC (rev 163475)
@@ -2,7 +2,7 @@
* Copyright (C) 1999 Lars Knoll (kn...@kde.org)
* (C) 2004-2005 Allan Sandfeld Jensen (k...@carewolf.com)
* Copyright (C) 2006, 2007 Nicholas Shanks (web...@nickshanks.com)
- * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2
[webkit-changes] [163474] trunk
Title: [163474] trunk
Revision 163474
Author fpi...@apple.com
Date 2014-02-05 13:44:26 -0800 (Wed, 05 Feb 2014)
Log Message
JSC on Mac should pull LLVM from prefix=/usr/local/LLVMForJavaScriptCore and not /usr/local
https://bugs.webkit.org/show_bug.cgi?id=128269
Reviewed by Mark Hahnenberg.
Source/_javascript_Core:
* Configurations/Base.xcconfig:
* Configurations/LLVMForJSC.xcconfig:
Tools:
* Scripts/copy-webkitlibraries-to-product-directory:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/Base.xcconfig
trunk/Source/_javascript_Core/Configurations/LLVMForJSC.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163473 => 163474)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-05 21:42:33 UTC (rev 163473)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-05 21:44:26 UTC (rev 163474)
@@ -1,3 +1,13 @@
+2014-02-05 Filip Pizlo
+
+JSC on Mac should pull LLVM from prefix=/usr/local/LLVMForJavaScriptCore and not /usr/local
+https://bugs.webkit.org/show_bug.cgi?id=128269
+
+Reviewed by Mark Hahnenberg.
+
+* Configurations/Base.xcconfig:
+* Configurations/LLVMForJSC.xcconfig:
+
2014-02-05 Mark Hahnenberg
Fix 32-bit builds after r163471
Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (163473 => 163474)
--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2014-02-05 21:42:33 UTC (rev 163473)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2014-02-05 21:44:26 UTC (rev 163474)
@@ -78,7 +78,7 @@
LINKER_DISPLAYS_MANGLED_NAMES = YES;
PREBINDING = NO;
WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough;
-HEADER_SEARCH_PATHS = . icu "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
+HEADER_SEARCH_PATHS = . icu "${BUILT_PRODUCTS_DIR}/usr/local/LLVMForJavaScriptCore/include" /usr/local/LLVMForJavaScriptCore/include "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
TARGET_MAC_OS_X_VERSION_MAJOR = $(MAC_OS_X_VERSION_MAJOR);
Modified: trunk/Source/_javascript_Core/Configurations/LLVMForJSC.xcconfig (163473 => 163474)
--- trunk/Source/_javascript_Core/Configurations/LLVMForJSC.xcconfig 2014-02-05 21:42:33 UTC (rev 163473)
+++ trunk/Source/_javascript_Core/Configurations/LLVMForJSC.xcconfig 2014-02-05 21:44:26 UTC (rev 163474)
@@ -29,7 +29,7 @@
OTHER_LDFLAGS_LLVM = $(OTHER_LDFLAGS_LLVM_$(ENABLE_FTL_JIT));
OTHER_LDFLAGS_LLVM_ = ;
-OTHER_LDFLAGS_LLVM_ENABLE_FTL_JIT = -lpthread -lm -lLLVMTableGen -lLLVMDebugInfo -lLLVMOption -lLLVMX86Disassembler -lLLVMX86AsmParser -lLLVMX86CodeGen -lLLVMSelectionDAG -lLLVMAsmPrinter -lLLVMX86Desc -lLLVMX86Info -lLLVMX86AsmPrinter -lLLVMX86Utils -lLLVMIRReader -lLLVMAsmParser -lLLVMMCDisassembler -lLLVMMCParser -lLLVMInstrumentation -lLLVMBitReader -lLLVMInterpreter -lLLVMipo -lLLVMVectorize -lLLVMLinker -lLLVMBitWriter -lLLVMMCJIT -lLLVMJIT -lLLVMCodeGen -lLLVMObjCARCOpts -lLLVMScalarOpts -lLLVMInstCombine -lLLVMTransformUtils -lLLVMipa -lLLVMAnalysis -lLLVMRuntimeDyld -lLLVMExecutionEngine -lLLVMTarget -lLLVMMC -lLLVMObject -lLLVMCore -lLLVMSupport;
+OTHER_LDFLAGS_LLVM_ENABLE_FTL_JIT = -lpthread -lm -L/usr/local/LLVMForJavaScriptCore/lib -lLLVMTableGen -lLLVMDebugInfo -lLLVMOption -lLLVMX86Disassembler -lLLVMX86AsmParser -lLLVMX86CodeGen -lLLVMSelectionDAG -lLLVMAsmPrinter -lLLVMX86Desc -lLLVMX86Info -lLLVMX86AsmPrinter -lLLVMX86Utils -lLLVMIRReader -lLLVMAsmParser -lLLVMMCDisassembler -lLLVMMCParser -lLLVMInstrumentation -lLLVMBitReader -lLLVMInterpreter -lLLVMipo -lLLVMVectorize -lLLVMLinker -lLLVMBitWriter -lLLVMMCJIT -lLLVMJIT -lLLVMCodeGen -lLLVMObjCARCOpts -lLLVMScalarOpts -lLLVMInstCombine -lLLVMTransformUtils -lLLVMipa -lLLVMAnalysis -lLLVMRuntimeDyld -lLLVMExecutionEngine -lLLVMTarget -lLLVMMC -lLLVMObject -lLLVMCore -lLLVMSupport;
OTHER_LDFLAGS_BASE = -lobjc -Wl,-Y,3 $(OTHER_LDFLAGS_HIDE_SYMBOLS);
OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_$(PLATFORM_NAME));
Modified: trunk/Tools/ChangeLog (163473 => 163474)
--- trunk/Tools/ChangeLog 2014-02-05 21:42:33 UTC (rev 163473)
+++ trunk/Tools/ChangeLog 2014-02-05 21:44:26 UTC (rev 163474)
@@ -1,3 +1,12 @@
+2014-02-05 Filip Pizlo
+
+JSC on Mac should pull LLVM from prefix=/usr/local/LLVMForJavaScriptCore and not /usr/local
+https://bugs.webkit.org/show_bug.cgi?id=128269
+
+Reviewed by Mark Hahnenberg.
+
+* Scripts/copy-webkitlibraries-to-product-directory:
+
2014-02-05 Manuel Rego Casasnovas
Create CSS Grid Layout watchlist
Modified: trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory (163473 => 163474)
[webkit-changes] [163473] trunk/Source/JavaScriptCore
Title: [163473] trunk/Source/_javascript_Core
Revision 163473
Author mhahnenb...@apple.com
Date 2014-02-05 13:42:33 -0800 (Wed, 05 Feb 2014)
Log Message
Fix 32-bit builds after r163471
* dfg/DFGOSRExitCompilerCommon.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163472 => 163473)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-05 21:29:47 UTC (rev 163472)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-05 21:42:33 UTC (rev 163473)
@@ -1,5 +1,11 @@
2014-02-05 Mark Hahnenberg
+Fix 32-bit builds after r163471
+
+* dfg/DFGOSRExitCompilerCommon.cpp:
+
+2014-02-05 Mark Hahnenberg
+
Can no longer run OctaneV2 in browser, crashes in speculationFromCell
https://bugs.webkit.org/show_bug.cgi?id=128266
Modified: trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp (163472 => 163473)
--- trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp 2014-02-05 21:29:47 UTC (rev 163472)
+++ trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp 2014-02-05 21:42:33 UTC (rev 163473)
@@ -160,6 +160,7 @@
jit.store32(AssemblyHelpers::TrustedImm32(locationBits), AssemblyHelpers::tagFor((VirtualRegister)(JSStack::ArgumentCount)));
}
+#if ENABLE(GGC)
static void osrWriteBarrier(CCallHelpers& jit, GPRReg owner, GPRReg scratch1, GPRReg scratch2)
{
AssemblyHelpers::Jump definitelyNotMarked = jit.genericWriteBarrier(owner, scratch1, scratch2);
@@ -179,6 +180,7 @@
definitelyNotMarked.link(&jit);
}
+#endif // ENABLE(GGC)
void adjustAndJumpToTarget(CCallHelpers& jit, const OSRExitBase& exit)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163472] trunk/Source/WebCore
Title: [163472] trunk/Source/WebCore
Revision 163472
Author bfulg...@apple.com
Date 2014-02-05 13:29:47 -0800 (Wed, 05 Feb 2014)
Log Message
[Mac] Correct copy/paste error in scrolling code.
https://bugs.webkit.org/show_bug.cgi?id=128258
Reviewed by Anders Carlsson.
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::pinnedInDirection): Use
'setWidth' when dealing with width metrics.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (163471 => 163472)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 21:27:13 UTC (rev 163471)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 21:29:47 UTC (rev 163472)
@@ -1,3 +1,14 @@
+2014-02-05 Brent Fulgham
+
+[Mac] Correct copy/paste error in scrolling code.
+https://bugs.webkit.org/show_bug.cgi?id=128258
+
+Reviewed by Anders Carlsson.
+
+* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
+(WebCore::ScrollingTreeScrollingNodeMac::pinnedInDirection): Use
+'setWidth' when dealing with width metrics.
+
2014-02-05 Yuki Sekiguchi
Ruby base oddly justify its text when the text is ideograph and it contains on Mac.
Modified: trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm (163471 => 163472)
--- trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm 2014-02-05 21:27:13 UTC (rev 163471)
+++ trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm 2014-02-05 21:29:47 UTC (rev 163472)
@@ -207,10 +207,10 @@
} else if (delta.width()) {
if (delta.width() < 0) {
// We are trying to scroll left. Make sure we are not pinned to the left
-limitDelta.setHeight(scrollPosition().x() - minimumScrollPosition().x());
+limitDelta.setWidth(scrollPosition().x() - minimumScrollPosition().x());
} else {
// We are trying to scroll right. Make sure we are not pinned to the right
-limitDelta.setHeight(maximumScrollPosition().x() - scrollPosition().x());
+limitDelta.setWidth(maximumScrollPosition().x() - scrollPosition().x());
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163471] trunk/Source/JavaScriptCore
Title: [163471] trunk/Source/_javascript_Core
Revision 163471
Author mhahnenb...@apple.com
Date 2014-02-05 13:27:13 -0800 (Wed, 05 Feb 2014)
Log Message
Can no longer run OctaneV2 in browser, crashes in speculationFromCell
https://bugs.webkit.org/show_bug.cgi?id=128266
Reviewed by Filip Pizlo.
Move the OSR exit write barriers into OSRExitCompilerCommon. Also reorganize some
of the code to be in more appropriate places.
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget):
* dfg/DFGSpeculativeJIT.cpp:
* dfg/DFGSpeculativeJIT.h:
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::genericWriteBarrier):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/jit/AssemblyHelpers.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163470 => 163471)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-05 21:21:49 UTC (rev 163470)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-05 21:27:13 UTC (rev 163471)
@@ -1,5 +1,27 @@
2014-02-05 Mark Hahnenberg
+Can no longer run OctaneV2 in browser, crashes in speculationFromCell
+https://bugs.webkit.org/show_bug.cgi?id=128266
+
+Reviewed by Filip Pizlo.
+
+Move the OSR exit write barriers into OSRExitCompilerCommon. Also reorganize some
+of the code to be in more appropriate places.
+
+* dfg/DFGOSRExitCompiler32_64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* dfg/DFGOSRExitCompiler64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* dfg/DFGOSRExitCompilerCommon.cpp:
+(JSC::DFG::osrWriteBarrier):
+(JSC::DFG::adjustAndJumpToTarget):
+* dfg/DFGSpeculativeJIT.cpp:
+* dfg/DFGSpeculativeJIT.h:
+* jit/AssemblyHelpers.h:
+(JSC::AssemblyHelpers::genericWriteBarrier):
+
+2014-02-05 Mark Hahnenberg
+
Malloc called beneath MachineThreads::gatherFromOtherThread(), while forbidden
https://bugs.webkit.org/show_bug.cgi?id=128202
Modified: trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp (163470 => 163471)
--- trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp 2014-02-05 21:21:49 UTC (rev 163470)
+++ trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp 2014-02-05 21:27:13 UTC (rev 163471)
@@ -456,17 +456,6 @@
}
}
-#if ENABLE(GGC)
-// 11) Write barrier the owner executable because we're jumping into a different block.
-for (CodeOrigin codeOrigin = exit.m_codeOrigin; ; codeOrigin = codeOrigin.inlineCallFrame->caller) {
-CodeBlock* baselineCodeBlock = m_jit.baselineCodeBlockFor(codeOrigin);
-m_jit.move(AssemblyHelpers::TrustedImmPtr(baselineCodeBlock->ownerExecutable()), GPRInfo::nonArgGPR0);
-SpeculativeJIT::osrWriteBarrier(m_jit, GPRInfo::nonArgGPR0, GPRInfo::nonArgGPR1, GPRInfo::nonArgGPR2);
-if (!codeOrigin.inlineCallFrame)
-break;
-}
-#endif
-
// 12) And finish.
adjustAndJumpToTarget(m_jit, exit);
}
Modified: trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp (163470 => 163471)
--- trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp 2014-02-05 21:21:49 UTC (rev 163470)
+++ trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp 2014-02-05 21:27:13 UTC (rev 163471)
@@ -412,17 +412,6 @@
}
}
-#if ENABLE(GGC)
-// 11) Write barrier the owner executable because we're jumping into a different block.
-for (CodeOrigin codeOrigin = exit.m_codeOrigin; ; codeOrigin = codeOrigin.inlineCallFrame->caller) {
-CodeBlock* baselineCodeBlock = m_jit.baselineCodeBlockFor(codeOrigin);
-m_jit.move(AssemblyHelpers::TrustedImmPtr(baselineCodeBlock->ownerExecutable()), GPRInfo::nonArgGPR0);
-SpeculativeJIT::osrWriteBarrier(m_jit, GPRInfo::nonArgGPR0, GPRInfo::nonArgGPR1, GPRInfo::nonArgGPR2);
-if (!codeOrigin.inlineCallFrame)
-break;
-}
-#endif
-
// 12) And finish.
adjustAndJumpToTarget(m_jit, exit);
}
Modified: trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp (163470 => 163471)
--- trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp 2014-02-05 21:21:49 UTC (rev 163470)
+++ trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp 2014-02-05 21:27:13 UTC (rev 163471)
@@ -160,8 +160,39 @@
jit.store32(AssemblyHelpers::TrustedImm32(locationBits), AssemblyHelpers::tagFor((VirtualRegister)(JSStack::ArgumentCount)));
}
+static void osrWriteBarrier(CCallHelper
[webkit-changes] [163470] trunk/Source/WebKit2
Title: [163470] trunk/Source/WebKit2
Revision 163470
Author m...@apple.com
Date 2014-02-05 13:21:49 -0800 (Wed, 05 Feb 2014)
Log Message
[Cocoa] WKRemoteObjectInterface fails with doubles, NSNull, and empty NSStrings
https://bugs.webkit.org/show_bug.cgi?id=128268
Reviewed by Anders Carlsson.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]): When returning nullptr, also
set the length out parameter to 0.
* Shared/API/Cocoa/WKRemoteObjectInterface.mm:
(propertyListClasses): Added NSNull.
* Shared/UserData.cpp:
(WebKit::UserData::encode): Encode the Double type.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm
trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterface.mm
trunk/Source/WebKit2/Shared/UserData.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163469 => 163470)
--- trunk/Source/WebKit2/ChangeLog 2014-02-05 21:15:42 UTC (rev 163469)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-05 21:21:49 UTC (rev 163470)
@@ -1,3 +1,20 @@
+2014-02-05 Dan Bernstein
+
+[Cocoa] WKRemoteObjectInterface fails with doubles, NSNull, and empty NSStrings
+https://bugs.webkit.org/show_bug.cgi?id=128268
+
+Reviewed by Anders Carlsson.
+
+* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
+(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]): When returning nullptr, also
+set the length out parameter to 0.
+
+* Shared/API/Cocoa/WKRemoteObjectInterface.mm:
+(propertyListClasses): Added NSNull.
+
+* Shared/UserData.cpp:
+(WebKit::UserData::encode): Encode the Double type.
+
2014-02-05 Jer Noble
[WK2] [iOS] No video on embedded YouTube
Modified: trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm (163469 => 163470)
--- trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm 2014-02-05 21:15:42 UTC (rev 163469)
+++ trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm 2014-02-05 21:21:49 UTC (rev 163470)
@@ -554,8 +554,10 @@
- (const uint8_t *)decodeBytesForKey:(NSString *)key returnedLength:(NSUInteger *)length
{
auto* data = ""
-if (!data || !data->size())
+if (!data || !data->size()) {
+*length = 0;
return nullptr;
+}
*length = data->size();
return data->bytes();
Modified: trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterface.mm (163469 => 163470)
--- trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterface.mm 2014-02-05 21:15:42 UTC (rev 163469)
+++ trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterface.mm 2014-02-05 21:21:49 UTC (rev 163470)
@@ -55,7 +55,7 @@
static NSSet *propertyListClasses()
{
// FIXME: Add more property list classes if needed.
-static NSSet *propertyListClasses = [[NSSet alloc] initWithObjects:[NSArray class], [NSDictionary class], [NSNumber class], [NSString class], nil];
+static NSSet *propertyListClasses = [[NSSet alloc] initWithObjects:[NSArray class], [NSDictionary class], [NSNull class], [NSNumber class], [NSString class], nil];
return propertyListClasses;
}
Modified: trunk/Source/WebKit2/Shared/UserData.cpp (163469 => 163470)
--- trunk/Source/WebKit2/Shared/UserData.cpp 2014-02-05 21:15:42 UTC (rev 163469)
+++ trunk/Source/WebKit2/Shared/UserData.cpp 2014-02-05 21:21:49 UTC (rev 163470)
@@ -138,6 +138,10 @@
break;
}
+case API::Object::Type::Double:
+static_cast(object).encode(encoder);
+break;
+
case API::Object::Type::Error:
static_cast(object).encode(encoder);
break;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163469] trunk
Title: [163469] trunk
Revision 163469
Author commit-qu...@webkit.org
Date 2014-02-05 13:15:42 -0800 (Wed, 05 Feb 2014)
Log Message
Ruby base oddly justify its text when the text is ideograph and it contains on Mac.
https://bugs.webkit.org/show_bug.cgi?id=106417
Patch by Yuki Sekiguchi on 2014-02-05
Reviewed by David Hyatt.
Source/WebCore:
Ruby base always justify even if a line have hard break.
Even if next leaf child is line break, InlineTextBox allow trailing expansion.
This make expanded, and there is odd space at the end of the line.
Test: fast/text/ruby-justification-br.html
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::expansionBehavior):
- If next leaf child is line break, we should forbid trailing expansion.
LayoutTests:
Test that don't change justification behavior in ruby base.
* fast/text/ruby-justification-br-expected.html: Added.
* fast/text/ruby-justification-br.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineTextBox.h
Added Paths
trunk/LayoutTests/fast/text/ruby-justification-br-expected.html
trunk/LayoutTests/fast/text/ruby-justification-br.html
Diff
Modified: trunk/LayoutTests/ChangeLog (163468 => 163469)
--- trunk/LayoutTests/ChangeLog 2014-02-05 21:04:16 UTC (rev 163468)
+++ trunk/LayoutTests/ChangeLog 2014-02-05 21:15:42 UTC (rev 163469)
@@ -1,3 +1,15 @@
+2014-02-05 Yuki Sekiguchi
+
+Ruby base oddly justify its text when the text is ideograph and it contains on Mac.
+https://bugs.webkit.org/show_bug.cgi?id=106417
+
+Reviewed by David Hyatt.
+
+Test that don't change justification behavior in ruby base.
+
+* fast/text/ruby-justification-br-expected.html: Added.
+* fast/text/ruby-justification-br.html: Added.
+
2014-02-05 Yoav Weiss
Fix srcset change test flakiness
Added: trunk/LayoutTests/fast/text/ruby-justification-br-expected.html (0 => 163469)
--- trunk/LayoutTests/fast/text/ruby-justification-br-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/ruby-justification-br-expected.html 2014-02-05 21:15:42 UTC (rev 163469)
@@ -0,0 +1,7 @@
+
+
+
+
+ああaaa
+
+
Added: trunk/LayoutTests/fast/text/ruby-justification-br.html (0 => 163469)
--- trunk/LayoutTests/fast/text/ruby-justification-br.html (rev 0)
+++ trunk/LayoutTests/fast/text/ruby-justification-br.html 2014-02-05 21:15:42 UTC (rev 163469)
@@ -0,0 +1,7 @@
+
+
+
+
+ああaaa
+
+
Modified: trunk/Source/WebCore/ChangeLog (163468 => 163469)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 21:04:16 UTC (rev 163468)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 21:15:42 UTC (rev 163469)
@@ -1,3 +1,20 @@
+2014-02-05 Yuki Sekiguchi
+
+Ruby base oddly justify its text when the text is ideograph and it contains on Mac.
+https://bugs.webkit.org/show_bug.cgi?id=106417
+
+Reviewed by David Hyatt.
+
+Ruby base always justify even if a line have hard break.
+Even if next leaf child is line break, InlineTextBox allow trailing expansion.
+This make expanded, and there is odd space at the end of the line.
+
+Test: fast/text/ruby-justification-br.html
+
+* rendering/InlineTextBox.h:
+(WebCore::InlineTextBox::expansionBehavior):
+ - If next leaf child is line break, we should forbid trailing expansion.
+
2014-02-05 Andreas Kling
FrameLoader::stateMachine() should return a reference.
Modified: trunk/Source/WebCore/rendering/InlineTextBox.h (163468 => 163469)
--- trunk/Source/WebCore/rendering/InlineTextBox.h 2014-02-05 21:04:16 UTC (rev 163468)
+++ trunk/Source/WebCore/rendering/InlineTextBox.h 2014-02-05 21:15:42 UTC (rev 163469)
@@ -179,7 +179,7 @@
TextRun::ExpansionBehavior expansionBehavior() const
{
return (canHaveLeadingExpansion() ? TextRun::AllowLeadingExpansion : TextRun::ForbidLeadingExpansion)
-| (expansion() && nextLeafChild() ? TextRun::AllowTrailingExpansion : TextRun::ForbidTrailingExpansion);
+| (expansion() && nextLeafChild() && !nextLeafChild()->isLineBreak() ? TextRun::AllowTrailingExpansion : TextRun::ForbidTrailingExpansion);
}
void behavesLikeText() const = delete;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163468] trunk/Tools
Title: [163468] trunk/Tools
Revision 163468
Author r...@igalia.com
Date 2014-02-05 13:04:16 -0800 (Wed, 05 Feb 2014)
Log Message
Create CSS Grid Layout watchlist
https://bugs.webkit.org/show_bug.cgi?id=128241
Reviewed by Andreas Kling.
Add Sergio Villar, Javier Fernandez and myself to it.
Add Javier Fernandez as contributor.
* Scripts/webkitpy/common/config/contributors.json:
* Scripts/webkitpy/common/config/watchlist:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
trunk/Tools/Scripts/webkitpy/common/config/watchlist
Diff
Modified: trunk/Tools/ChangeLog (163467 => 163468)
--- trunk/Tools/ChangeLog 2014-02-05 20:57:07 UTC (rev 163467)
+++ trunk/Tools/ChangeLog 2014-02-05 21:04:16 UTC (rev 163468)
@@ -1,3 +1,17 @@
+2014-02-05 Manuel Rego Casasnovas
+
+Create CSS Grid Layout watchlist
+https://bugs.webkit.org/show_bug.cgi?id=128241
+
+Reviewed by Andreas Kling.
+
+Add Sergio Villar, Javier Fernandez and myself to it.
+
+Add Javier Fernandez as contributor.
+
+* Scripts/webkitpy/common/config/contributors.json:
+* Scripts/webkitpy/common/config/watchlist:
+
2014-02-05 Alexey Proskuryakov
Copying failing test paths from build.webkit.org/dashboard popovers also copies non-selectable links
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (163467 => 163468)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-02-05 20:57:07 UTC (rev 163467)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-02-05 21:04:16 UTC (rev 163468)
@@ -2898,6 +2898,14 @@
"jcraig"
]
},
+ "Javier Fernandez" : {
+ "emails" : [
+"jfernan...@igalia.com"
+ ],
+ "nicks" : [
+"lajava"
+ ]
+ },
"Jeff Timanus" : {
"emails" : [
"t...@chromium.org",
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (163467 => 163468)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2014-02-05 20:57:07 UTC (rev 163467)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2014-02-05 21:04:16 UTC (rev 163468)
@@ -282,6 +282,14 @@
"ANGLE": {
"filename": r"Source/ThirdParty/ANGLE",
},
+"CSSGridLayout": {
+"filename": r"Source/WebCore/rendering/.*Grid.*"
+r"|Source/WebCore/css/.*Grid.*"
+r"|LayoutTests/fast/css-grid-layout/"
+r"|LayoutTests/ietestcenter/css3/grid/"
+r"|LayoutTests/platform/.*/fast/css-grid-layout/"
+r"|LayoutTests/platform/.*/ietestcenter/css3/grid/",
+},
},
"CC_RULES": {
# Note: All email addresses listed must be registered with bugzilla.
@@ -299,6 +307,7 @@
"ContentSecurityPolicyFiles|ContentSecurityPolicyUsage" : [ "mk...@chromium.org" ],
"CoreAnimation" : [ "simon.fra...@apple.com" ],
"CSS": [ "ale...@webkit.org", "macpher...@chromium.org", "esprehn+aut...@chromium.org", "gl...@skynav.com", "gyuyoung@webkit.org" ],
+"CSSGridLayout": [ "svil...@igalia.com", "jfernan...@igalia.com", "r...@igalia.com" ],
"cURLNetwork": [ "galpe...@inf.u-szeged.hu" ],
"DOM": [ "esprehn+aut...@chromium.org", "kangil@samsung.com" ],
"DOMAttributes": [ "cmarc...@webkit.org", ],
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163467] trunk/LayoutTests
Title: [163467] trunk/LayoutTests
Revision 163467
Author commit-qu...@webkit.org
Date 2014-02-05 12:57:07 -0800 (Wed, 05 Feb 2014)
Log Message
Fix srcset change test flakiness
https://bugs.webkit.org/show_bug.cgi?id=128265
Patch by Yoav Weiss on 2014-02-05
Reviewed by Alexey Proskuryakov.
* fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt:
* fast/hidpi/image-srcset-change-dynamically-from-js-2x.html:
* platform/gtk-wk2/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt
trunk/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html
Removed Paths
trunk/LayoutTests/platform/gtk-wk2/fast/hidpi/
Diff
Modified: trunk/LayoutTests/ChangeLog (163466 => 163467)
--- trunk/LayoutTests/ChangeLog 2014-02-05 20:42:37 UTC (rev 163466)
+++ trunk/LayoutTests/ChangeLog 2014-02-05 20:57:07 UTC (rev 163467)
@@ -1,3 +1,14 @@
+2014-02-05 Yoav Weiss
+
+Fix srcset change test flakiness
+https://bugs.webkit.org/show_bug.cgi?id=128265
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt:
+* fast/hidpi/image-srcset-change-dynamically-from-js-2x.html:
+* platform/gtk-wk2/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt: Removed.
+
2014-02-04 Myles C. Maxfield
Move characterAt index checks from InlineIterator to RenderText
Modified: trunk/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt (163466 => 163467)
--- trunk/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt 2014-02-05 20:42:37 UTC (rev 163466)
+++ trunk/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt 2014-02-05 20:57:07 UTC (rev 163467)
@@ -1,7 +1,3 @@
-blue-100-px-square.png has MIME type image/png
-image-srcset-change-dynamically-from-js-2x.html has MIME type text/html
-srcset-helper.js has MIME type text/_javascript_
-js-test-pre.js has MIME type text/_javascript_
green-400-px-square.png has MIME type image/png
PASS document.getElementById("foo").clientWidth==200 is true
This test passes if this img tag below is a green square when the scale factor is 2. It ensures that attributes can be changed dynamically from _javascript_, and that only the correct resource is loaded.
Modified: trunk/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html (163466 => 163467)
--- trunk/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html 2014-02-05 20:42:37 UTC (rev 163466)
+++ trunk/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html 2014-02-05 20:57:07 UTC (rev 163467)
@@ -5,7 +5,6 @@
[webkit-changes] [163466] trunk/Source
Title: [163466] trunk/Source
Revision 163466
Author akl...@apple.com
Date 2014-02-05 12:42:37 -0800 (Wed, 05 Feb 2014)
Log Message
FrameLoader::stateMachine() should return a reference.
There is always a FrameLoaderStateMatchine, so return it by
reference since it can never be null.
Reviewed by Anders Carlsson.
* history/PageCache.cpp:
(WebCore::logCanCachePageDecision):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::maybeLoadEmpty):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::createDocument):
(WebCore::DocumentWriter::begin):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForHistoryNavigation):
* loader/FrameLoader.h:
(WebCore::FrameLoader::stateMachine):
* loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
(WebCore::HistoryController::saveDocumentState):
* loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::scheduleLocationChange):
(WebCore::NavigationScheduler::scheduleFormSubmission):
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::incrementProgress):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::storeResourceTimingInitiatorInformation):
* page/Frame.cpp:
(WebCore::Frame::injectUserScripts):
* page/FrameView.cpp:
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/PageCache.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/DocumentWriter.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.h
trunk/Source/WebCore/loader/HistoryController.cpp
trunk/Source/WebCore/loader/NavigationScheduler.cpp
trunk/Source/WebCore/loader/ProgressTracker.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Source/WebKit/mac/WebView/WebFrame.mm
trunk/Source/WebKit/win/WebFrame.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (163465 => 163466)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 20:04:59 UTC (rev 163465)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 20:42:37 UTC (rev 163466)
@@ -1,3 +1,41 @@
+2014-02-05 Andreas Kling
+
+FrameLoader::stateMachine() should return a reference.
+
+
+There is always a FrameLoaderStateMatchine, so return it by
+reference since it can never be null.
+
+Reviewed by Anders Carlsson.
+
+* history/PageCache.cpp:
+(WebCore::logCanCachePageDecision):
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::finishedLoading):
+(WebCore::DocumentLoader::commitData):
+(WebCore::DocumentLoader::maybeLoadEmpty):
+* loader/DocumentWriter.cpp:
+(WebCore::DocumentWriter::createDocument):
+(WebCore::DocumentWriter::begin):
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::prepareForHistoryNavigation):
+* loader/FrameLoader.h:
+(WebCore::FrameLoader::stateMachine):
+* loader/HistoryController.cpp:
+(WebCore::HistoryController::restoreScrollPositionAndViewState):
+(WebCore::HistoryController::saveDocumentState):
+* loader/NavigationScheduler.cpp:
+(WebCore::NavigationScheduler::scheduleLocationChange):
+(WebCore::NavigationScheduler::scheduleFormSubmission):
+* loader/ProgressTracker.cpp:
+(WebCore::ProgressTracker::incrementProgress):
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::storeResourceTimingInitiatorInformation):
+* page/Frame.cpp:
+(WebCore::Frame::injectUserScripts):
+* page/FrameView.cpp:
+(WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
+
2014-02-04 Myles C. Maxfield
Move characterAt index checks from InlineIterator to RenderText
Modified: trunk/Source/WebCore/history/PageCache.cpp (163465 => 163466)
--- trunk/Source/WebCore/history/PageCache.cpp 2014-02-05 20:04:59 UTC (rev 163465)
+++ trunk/Source/WebCore/history/PageCache.cpp 2014-02-05 20:42:37 UTC (rev 163466)
@@ -217,7 +217,7 @@
static void logCanCachePageDecision(Page* page)
{
// Only bother logging for main frames that have actually loaded and have content.
-if (page->mainFrame().loader().stateMachine()->creatingInitialEmptyDocument())
+if (page->mainFrame().loader().stateMachine().creatingInitialEmptyDocument())
return;
URL currentURL = page->mainFrame().loader().documentLoader() ? page->mainFrame().loader().documentLoader()->url() : URL();
if (currentURL.isEmpty())
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (163465 => 163466)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2014-02-05 20:04:59 UTC (rev 163465)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2014-02-
[webkit-changes] [163465] trunk
Title: [163465] trunk
Revision 163465
Author mmaxfi...@apple.com
Date 2014-02-05 12:04:59 -0800 (Wed, 05 Feb 2014)
Log Message
Move characterAt index checks from InlineIterator to RenderText
https://bugs.webkit.org/show_bug.cgi?id=128224
Source/WebCore:
Reviewed by Simon Fraser.
Move characterAt index checks from InlineIterator to RenderText
so that all RenderText calls are covered. Few safe instances are
now covered with uncheckedCharacterAt.
Merged from Blink:
http://src.chromium.org/viewvc/blink?view=revision&revision=150830
Test: fast/text/character-at-crash.html
* rendering/InlineIterator.h:
(WebCore::InlineIterator::characterAt):
* rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
* rendering/RenderText.h:
(WebCore::RenderText::operator[]):
(WebCore::RenderText::uncheckedCharacterAt):
(WebCore::RenderText::characterAt):
LayoutTests:
Move characterAt index checks from InlineIterator to RenderText
so that all RenderText calls are covered. Few safe instances are
now covered with uncheckedCharacterAt.
Merged from Blink:
http://src.chromium.org/viewvc/blink?view=revision&revision=150830
Reviewed by Simon Fraser.
* fast/text/character-at-crash-expected.txt: Added.
* fast/text/character-at-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineIterator.h
trunk/Source/WebCore/rendering/RenderText.cpp
trunk/Source/WebCore/rendering/RenderText.h
Added Paths
trunk/LayoutTests/fast/text/character-at-crash-expected.txt
trunk/LayoutTests/fast/text/character-at-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (163464 => 163465)
--- trunk/LayoutTests/ChangeLog 2014-02-05 20:04:40 UTC (rev 163464)
+++ trunk/LayoutTests/ChangeLog 2014-02-05 20:04:59 UTC (rev 163465)
@@ -1,3 +1,20 @@
+2014-02-04 Myles C. Maxfield
+
+Move characterAt index checks from InlineIterator to RenderText
+https://bugs.webkit.org/show_bug.cgi?id=128224
+
+Move characterAt index checks from InlineIterator to RenderText
+so that all RenderText calls are covered. Few safe instances are
+now covered with uncheckedCharacterAt.
+
+Merged from Blink:
+http://src.chromium.org/viewvc/blink?view=revision&revision=150830
+
+Reviewed by Simon Fraser.
+
+* fast/text/character-at-crash-expected.txt: Added.
+* fast/text/character-at-crash.html: Added.
+
2014-02-05 Michał Pakuła vel Rutka
Unreviewed EFL gardening
Added: trunk/LayoutTests/fast/text/character-at-crash-expected.txt (0 => 163465)
--- trunk/LayoutTests/fast/text/character-at-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/text/character-at-crash-expected.txt 2014-02-05 20:04:59 UTC (rev 163465)
@@ -0,0 +1 @@
+Pass. Test didn't crash.
Added: trunk/LayoutTests/fast/text/character-at-crash.html (0 => 163465)
--- trunk/LayoutTests/fast/text/character-at-crash.html (rev 0)
+++ trunk/LayoutTests/fast/text/character-at-crash.html 2014-02-05 20:04:59 UTC (rev 163465)
@@ -0,0 +1,22 @@
+
+
+
+div {
+ -webkit-writing-mode: vertical-lr;
+ -webkit-text-combine: horizontal;
+ height: 7px;
+ white-space: pre-wrap;
+}
+
+
+foo
+
+
+
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+document.documentElement.offsetTop;
+document.documentElement.innerHTML = "Pass. Test didn't crash.";
+
+
Modified: trunk/Source/WebCore/ChangeLog (163464 => 163465)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 20:04:40 UTC (rev 163464)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 20:04:59 UTC (rev 163465)
@@ -1,3 +1,28 @@
+2014-02-04 Myles C. Maxfield
+
+Move characterAt index checks from InlineIterator to RenderText
+https://bugs.webkit.org/show_bug.cgi?id=128224
+
+Reviewed by Simon Fraser.
+
+Move characterAt index checks from InlineIterator to RenderText
+so that all RenderText calls are covered. Few safe instances are
+now covered with uncheckedCharacterAt.
+
+Merged from Blink:
+http://src.chromium.org/viewvc/blink?view=revision&revision=150830
+
+Test: fast/text/character-at-crash.html
+
+* rendering/InlineIterator.h:
+(WebCore::InlineIterator::characterAt):
+* rendering/RenderText.cpp:
+(WebCore::RenderText::computePreferredLogicalWidths):
+* rendering/RenderText.h:
+(WebCore::RenderText::operator[]):
+(WebCore::RenderText::uncheckedCharacterAt):
+(WebCore::RenderText::characterAt):
+
2014-02-05 Andreas Kling
Remove leftover seamless iframe logic from containerForRepaint().
Modified: trunk/Source/WebCore/rendering/InlineIterator.h (163464 => 163465)
--- trunk/Source/WebCore/rendering/InlineIterator.h 2014-02-05 20:04:40 UTC (rev 163464)
+++ trunk/Source/WebCore/rendering/InlineIterator.h 2014-02-05 20:04:59 UTC (rev 163465)
@@ -375,11 +375,7 @@
if (!m_render
[webkit-changes] [163464] trunk/Tools
Title: [163464] trunk/Tools
Revision 163464
Author a...@apple.com
Date 2014-02-05 12:04:40 -0800 (Wed, 05 Feb 2014)
Log Message
Copying failing test paths from build.webkit.org/dashboard popovers also copies non-selectable links
https://bugs.webkit.org/show_bug.cgi?id=128236
Reviewed by Timothy Hatcher.
Work around bug 80159 - copying should always respect user-select:none, but it doesn't yet.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
When copying, temporarily make non-selectable parts invisible, and put text of
the selection onto pasteboard. Since we immediately make everything visible again,
there is even no blinking.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (163463 => 163464)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2014-02-05 20:03:55 UTC (rev 163463)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2014-02-05 20:04:40 UTC (rev 163464)
@@ -214,6 +214,31 @@
content.appendChild(rowElement);
}
+// Work around bug 80159: -webkit-user-select:none not respected when copying content.
+// We set clipboard data manually, temporarily making non-selectable content hidden
+// to easily get accurate selection text.
+content._oncopy_ = function(event) {
+var iterator = document.createNodeIterator(
+event.currentTarget,
+NodeFilter.SHOW_ELEMENT,
+{
+acceptNode: function(element) {
+if (window.getComputedStyle(element).webkitUserSelect !== "none")
+return NodeFilter.FILTER_ACCEPT;
+return NodeFilter.FILTER_SKIP;
+}
+}
+);
+
+while ((node = iterator.nextNode()))
+node.style.visibility = "visible";
+
+event.currentTarget.style.visibility = "hidden";
+event.clipboardData.setData('text', window.getSelection());
+event.currentTarget.style.visibility = "";
+return false;
+}
+
return content;
},
Modified: trunk/Tools/ChangeLog (163463 => 163464)
--- trunk/Tools/ChangeLog 2014-02-05 20:03:55 UTC (rev 163463)
+++ trunk/Tools/ChangeLog 2014-02-05 20:04:40 UTC (rev 163464)
@@ -1,3 +1,17 @@
+2014-02-05 Alexey Proskuryakov
+
+Copying failing test paths from build.webkit.org/dashboard popovers also copies non-selectable links
+https://bugs.webkit.org/show_bug.cgi?id=128236
+
+Reviewed by Timothy Hatcher.
+
+Work around bug 80159 - copying should always respect user-select:none, but it doesn't yet.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+When copying, temporarily make non-selectable parts invisible, and put text of
+the selection onto pasteboard. Since we immediately make everything visible again,
+there is even no blinking.
+
2014-02-05 Nick Diego Yamane
Unreviewed. Add myself to contributors.json
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163463] trunk/Tools
Title: [163463] trunk/Tools
Revision 163463
Author nick.yam...@openbossa.org
Date 2014-02-05 12:03:55 -0800 (Wed, 05 Feb 2014)
Log Message
Unreviewed. Add myself to contributors.json
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (163462 => 163463)
--- trunk/Tools/ChangeLog 2014-02-05 19:39:51 UTC (rev 163462)
+++ trunk/Tools/ChangeLog 2014-02-05 20:03:55 UTC (rev 163463)
@@ -1,3 +1,9 @@
+2014-02-05 Nick Diego Yamane
+
+Unreviewed. Add myself to contributors.json
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2014-02-05 Sergio Correia
Unreviewed. Add myself to contributor and watch lists
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (163462 => 163463)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-02-05 19:39:51 UTC (rev 163462)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-02-05 20:03:55 UTC (rev 163463)
@@ -1851,6 +1851,15 @@
"xc0ffee"
]
},
+ "Nick Diego Yamane" : {
+ "emails" : [
+"nick.yam...@openbossa.org",
+"nick.di...@gmail.com"
+ ],
+ "nicks" : [
+"diegoyam"
+ ]
+ },
"Nima Ghanavatian" : {
"emails" : [
"nghanavat...@blackberry.com",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163462] trunk/LayoutTests
Title: [163462] trunk/LayoutTests Revision 163462 Author m.pak...@samsung.com Date 2014-02-05 11:39:51 -0800 (Wed, 05 Feb 2014) Log Message Unreviewed EFL gardening Add test expectations for tests crashing after r162947 and for http tests. * platform/efl-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (163461 => 163462) --- trunk/LayoutTests/ChangeLog 2014-02-05 19:26:55 UTC (rev 163461) +++ trunk/LayoutTests/ChangeLog 2014-02-05 19:39:51 UTC (rev 163462) @@ -1,3 +1,11 @@ +2014-02-05 Michał Pakuła vel Rutka + +Unreviewed EFL gardening + +Add test expectations for tests crashing after r162947 and for http tests. + +* platform/efl-wk2/TestExpectations: + 2014-02-05 Hans Muller [CSS Shapes] Dynamically created element with image valued shape-outside doesn't update automatically Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (163461 => 163462) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-02-05 19:26:55 UTC (rev 163461) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-02-05 19:39:51 UTC (rev 163462) @@ -70,8 +70,10 @@ webkit.org/b/116587 http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html [ Skip ] webkit.org/b/116587 http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html [ Skip ] webkit.org/b/116587 http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html [ Skip ] +webkit.org/b/116587 http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/broken-utf8.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html [ Skip ] +webkit.org/b/116587 http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/compressed-control-frame.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/cross-origin.html [ Skip ] @@ -82,6 +84,7 @@ webkit.org/b/116587 http/tests/websocket/tests/hybi/handshake-error.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/nocache.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/no-subprotocol.html [ Skip ] +webkit.org/b/116587 http/tests/websocket/tests/hybi/null-character.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/reserved-bits.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/simple.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/sub-protocol.html [ Skip ] @@ -93,6 +96,25 @@ webkit.org/b/116587 http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/zero-length-text.html [ Skip ] +# Started to crash after r162947 +webkit.org/b/128259 compositing/iframes/remove-iframe-crash.html [ Crash ] +webkit.org/b/128259 fast/dom/Window/web-timing-minimal-performance-now.html [ Crash ] +webkit.org/b/128259 fast/events/pagehide-xhr-open.html [ Crash ] fast/events/pageshow-pagehide-on-back-cached.html [ Crash ] +webkit.org/b/128259 fast/events/tab-crash-with-image-map.html [ Crash ] fast/forms/autocomplete.html [ Crash ] +webkit.org/b/128259 fast/history/go-back-to-iframe-with-plugin.html [ Crash ] +webkit.org/b/128259 fast/history/history-back-while-pdf-in-pagecache.html [ Crash ] +webkit.org/b/128259 fast/history/visited-generated-content-test.html [ Crash ] +webkit.org/b/128259 fast/images/animated-gif-with-offsets.html [ Crash ] +webkit.org/b/128259 fast/loader/invalid-charset-on-script-crashes-loader.html [ Crash ] +webkit.org/b/128259 fast/loader/show-only-one-beforeunload-dialog.html [ Crash ] +webkit.org/b/128259 fast/loader/url-data-replace-backslash.html [ Crash ] +webkit.org/b/128259 fast/overflow/image-selection-highlight.html [ Crash ] +webkit.org/b/128259 fast/viewport/viewport-129.html [ Crash ] +webkit.org/b/128259 http/tests/navigation/history-back-across-form-submission-to-fragment.html [ Crash ] +webkit.org/b/128259 http/tests/navigation/https-in-page-cache.html [ Crash ] +webkit.org/b/128259 loader/image-loader-adoptNode-assert.html [ Crash ] +webkit.org/b/128259 media/sources-fallback-codecs.html [ Crash ] + # # FLAKY TESTS # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163461] releases/WebKitGTK/webkit-2.4/Source/WTF
Title: [163461] releases/WebKitGTK/webkit-2.4/Source/WTF
Revision 163461
Author carlo...@webkit.org
Date 2014-02-05 11:26:55 -0800 (Wed, 05 Feb 2014)
Log Message
Merge r163460 - HashMap can't be used with std::unique_ptr as value when it has a custom deleter
https://bugs.webkit.org/show_bug.cgi?id=128250
Patch by Carlos Garcia Campos on 2014-02-05
Reviewed by Darin Adler.
The problem is that the HashMap is using a unique_ptr with the
default deleter, so that when trying to move the unique_ptr the
deleters don't match.
* wtf/HashTraits.h: Add the deleter also in the template
definitation of the parent class for the HashTraits>
Modified Paths
releases/WebKitGTK/webkit-2.4/Source/WTF/ChangeLog
releases/WebKitGTK/webkit-2.4/Source/WTF/wtf/HashTraits.h
Diff
Modified: releases/WebKitGTK/webkit-2.4/Source/WTF/ChangeLog (163460 => 163461)
--- releases/WebKitGTK/webkit-2.4/Source/WTF/ChangeLog 2014-02-05 19:13:57 UTC (rev 163460)
+++ releases/WebKitGTK/webkit-2.4/Source/WTF/ChangeLog 2014-02-05 19:26:55 UTC (rev 163461)
@@ -1,3 +1,17 @@
+2014-02-05 Carlos Garcia Campos
+
+HashMap can't be used with std::unique_ptr as value when it has a custom deleter
+https://bugs.webkit.org/show_bug.cgi?id=128250
+
+Reviewed by Darin Adler.
+
+The problem is that the HashMap is using a unique_ptr with the
+default deleter, so that when trying to move the unique_ptr the
+deleters don't match.
+
+* wtf/HashTraits.h: Add the deleter also in the template
+definitation of the parent class for the HashTraits>
+
2014-01-29 Csaba Osztrogonác
Remove ENABLE(_javascript__DEBUGGER) guards
Modified: releases/WebKitGTK/webkit-2.4/Source/WTF/wtf/HashTraits.h (163460 => 163461)
--- releases/WebKitGTK/webkit-2.4/Source/WTF/wtf/HashTraits.h 2014-02-05 19:13:57 UTC (rev 163460)
+++ releases/WebKitGTK/webkit-2.4/Source/WTF/wtf/HashTraits.h 2014-02-05 19:26:55 UTC (rev 163461)
@@ -101,7 +101,7 @@
static bool isDeletedValue(const T& value) { return value.isHashTableDeletedValue(); }
};
-template struct HashTraits> : SimpleClassHashTraits> {
+template struct HashTraits> : SimpleClassHashTraits> {
typedef std::nullptr_t EmptyValueType;
static EmptyValueType emptyValue() { return nullptr; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163460] trunk/Source/WTF
Title: [163460] trunk/Source/WTF
Revision 163460
Author commit-qu...@webkit.org
Date 2014-02-05 11:13:57 -0800 (Wed, 05 Feb 2014)
Log Message
HashMap can't be used with std::unique_ptr as value when it has a custom deleter
https://bugs.webkit.org/show_bug.cgi?id=128250
Patch by Carlos Garcia Campos on 2014-02-05
Reviewed by Darin Adler.
The problem is that the HashMap is using a unique_ptr with the
default deleter, so that when trying to move the unique_ptr the
deleters don't match.
* wtf/HashTraits.h: Add the deleter also in the template
definitation of the parent class for the HashTraits>
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashTraits.h
Diff
Modified: trunk/Source/WTF/ChangeLog (163459 => 163460)
--- trunk/Source/WTF/ChangeLog 2014-02-05 18:51:22 UTC (rev 163459)
+++ trunk/Source/WTF/ChangeLog 2014-02-05 19:13:57 UTC (rev 163460)
@@ -1,3 +1,17 @@
+2014-02-05 Carlos Garcia Campos
+
+HashMap can't be used with std::unique_ptr as value when it has a custom deleter
+https://bugs.webkit.org/show_bug.cgi?id=128250
+
+Reviewed by Darin Adler.
+
+The problem is that the HashMap is using a unique_ptr with the
+default deleter, so that when trying to move the unique_ptr the
+deleters don't match.
+
+* wtf/HashTraits.h: Add the deleter also in the template
+definitation of the parent class for the HashTraits>
+
2014-02-05 Csaba Osztrogonác
Remove ENABLE(SVG) guards
Modified: trunk/Source/WTF/wtf/HashTraits.h (163459 => 163460)
--- trunk/Source/WTF/wtf/HashTraits.h 2014-02-05 18:51:22 UTC (rev 163459)
+++ trunk/Source/WTF/wtf/HashTraits.h 2014-02-05 19:13:57 UTC (rev 163460)
@@ -101,7 +101,7 @@
static bool isDeletedValue(const T& value) { return value.isHashTableDeletedValue(); }
};
-template struct HashTraits> : SimpleClassHashTraits> {
+template struct HashTraits> : SimpleClassHashTraits> {
typedef std::nullptr_t EmptyValueType;
static EmptyValueType emptyValue() { return nullptr; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163459] trunk/Source/WebCore
Title: [163459] trunk/Source/WebCore Revision 163459 Author akl...@apple.com Date 2014-02-05 10:51:22 -0800 (Wed, 05 Feb 2014) Log Message Remove leftover seamless iframe logic from containerForRepaint(). The parent-flow-thread-in-different-document case is no longer relevant after was removed. Reviewed by David Hyatt. * rendering/RenderObject.cpp: (WebCore::RenderObject::containerForRepaint): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderObject.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (163458 => 163459) --- trunk/Source/WebCore/ChangeLog 2014-02-05 18:39:36 UTC (rev 163458) +++ trunk/Source/WebCore/ChangeLog 2014-02-05 18:51:22 UTC (rev 163459) @@ -1,3 +1,16 @@ +2014-02-05 Andreas Kling + +Remove leftover seamless iframe logic from containerForRepaint(). + + +The parent-flow-thread-in-different-document case is no longer +relevant after was removed. + +Reviewed by David Hyatt. + +* rendering/RenderObject.cpp: +(WebCore::RenderObject::containerForRepaint): + 2014-02-05 Hans Muller [CSS Shapes] Dynamically created element with image valued shape-outside doesn't update automatically Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (163458 => 163459) --- trunk/Source/WebCore/rendering/RenderObject.cpp 2014-02-05 18:39:36 UTC (rev 163458) +++ trunk/Source/WebCore/rendering/RenderObject.cpp 2014-02-05 18:51:22 UTC (rev 163459) @@ -1225,10 +1225,6 @@ // then the repaint container is not the flow thread. if (hasFixedPosInNamedFlowContainingBlock(this)) return repaintContainer; -// The ancestor document will do the reparenting when the repaint propagates further up. -// We're just a seamless child document, and we don't need to do the hacking. -if (parentRenderFlowThread && &parentRenderFlowThread->document() != &document()) -return repaintContainer; // If we have already found a repaint container then we will repaint into that container only if it is part of the same // flow thread. Otherwise we will need to catch the repaint call and send it to the flow thread. RenderFlowThread* repaintContainerFlowThread = repaintContainer ? repaintContainer->flowThreadContainingBlock() : 0; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163457] trunk/Source/WebCore
Title: [163457] trunk/Source/WebCore Revision 163457 Author akl...@apple.com Date 2014-02-05 10:25:26 -0800 (Wed, 05 Feb 2014) Log Message CTTE: ImageLoader is always owned by an Element. - Codify this by making the constructor take Element& or better. - Make element() return Element&. - Marked HTMLImageLoader and SVGImageLoader final. - Made the ImageLoader constructor protected. Reviewed by Sam Weinig. * html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseAttribute): * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::HTMLImageElement): * html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::HTMLImageLoader): (WebCore::HTMLImageLoader::dispatchLoadEvent): (WebCore::HTMLImageLoader::sourceURI): (WebCore::HTMLImageLoader::notifyFinished): * html/HTMLImageLoader.h: * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::imageLoader): * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseAttribute): * html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::startLoadingImage): * html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::didAttachRenderers): (WebCore::HTMLVideoElement::parseAttribute): * loader/ImageLoader.cpp: (WebCore::ImageLoader::ImageLoader): (WebCore::ImageLoader::~ImageLoader): (WebCore::ImageLoader::updateFromElement): (WebCore::ImageLoader::notifyFinished): (WebCore::ImageLoader::renderImageResource): (WebCore::ImageLoader::updatedHasPendingEvent): (WebCore::ImageLoader::timerFired): (WebCore::ImageLoader::dispatchPendingBeforeLoadEvent): (WebCore::ImageLoader::dispatchPendingLoadEvent): (WebCore::ImageLoader::dispatchPendingErrorEvent): * loader/ImageLoader.h: (WebCore::ImageLoader::element): * svg/SVGImageElement.cpp: (WebCore::SVGImageElement::SVGImageElement): * svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::SVGImageLoader): (WebCore::SVGImageLoader::~SVGImageLoader): (WebCore::SVGImageLoader::dispatchLoadEvent): (WebCore::SVGImageLoader::sourceURI): * svg/SVGImageLoader.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLEmbedElement.cpp trunk/Source/WebCore/html/HTMLImageElement.cpp trunk/Source/WebCore/html/HTMLImageLoader.cpp trunk/Source/WebCore/html/HTMLImageLoader.h trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLObjectElement.cpp trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp trunk/Source/WebCore/html/HTMLVideoElement.cpp trunk/Source/WebCore/loader/ImageLoader.cpp trunk/Source/WebCore/loader/ImageLoader.h trunk/Source/WebCore/svg/SVGImageElement.cpp trunk/Source/WebCore/svg/SVGImageLoader.cpp trunk/Source/WebCore/svg/SVGImageLoader.h Diff Modified: trunk/Source/WebCore/ChangeLog (163456 => 163457) --- trunk/Source/WebCore/ChangeLog 2014-02-05 18:11:33 UTC (rev 163456) +++ trunk/Source/WebCore/ChangeLog 2014-02-05 18:25:26 UTC (rev 163457) @@ -1,3 +1,56 @@ +2014-02-05 Andreas Kling + +CTTE: ImageLoader is always owned by an Element. + + +- Codify this by making the constructor take Element& or better. +- Make element() return Element&. +- Marked HTMLImageLoader and SVGImageLoader final. +- Made the ImageLoader constructor protected. + +Reviewed by Sam Weinig. + +* html/HTMLEmbedElement.cpp: +(WebCore::HTMLEmbedElement::parseAttribute): +* html/HTMLImageElement.cpp: +(WebCore::HTMLImageElement::HTMLImageElement): +* html/HTMLImageLoader.cpp: +(WebCore::HTMLImageLoader::HTMLImageLoader): +(WebCore::HTMLImageLoader::dispatchLoadEvent): +(WebCore::HTMLImageLoader::sourceURI): +(WebCore::HTMLImageLoader::notifyFinished): +* html/HTMLImageLoader.h: +* html/HTMLInputElement.cpp: +(WebCore::HTMLInputElement::imageLoader): +* html/HTMLObjectElement.cpp: +(WebCore::HTMLObjectElement::parseAttribute): +* html/HTMLPlugInImageElement.cpp: +(WebCore::HTMLPlugInImageElement::startLoadingImage): +* html/HTMLVideoElement.cpp: +(WebCore::HTMLVideoElement::didAttachRenderers): +(WebCore::HTMLVideoElement::parseAttribute): +* loader/ImageLoader.cpp: +(WebCore::ImageLoader::ImageLoader): +(WebCore::ImageLoader::~ImageLoader): +(WebCore::ImageLoader::updateFromElement): +(WebCore::ImageLoader::notifyFinished): +(WebCore::ImageLoader::renderImageResource): +(WebCore::ImageLoader::updatedHasPendingEvent): +(WebCore::ImageLoader::timerFired): +(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent): +(WebCore::ImageLoader::dispatchPendingLoadEvent): +(WebCore::ImageLoader::dispatchPendingErrorEvent): +* loader/ImageLoader.h: +(WebCore::ImageLoader::element): +* svg/SVGImageElement.cpp: +(WebCore::SVGImageElement::SVGImageElement): +* svg/SVGImageLoader.cpp: +(WebCore::SVGImageLoader::SVGImageLoader): +(WebCore::SVGImageLoader::~SVGImag
[webkit-changes] [163452] trunk/Source/WebCore
Title: [163452] trunk/Source/WebCore
Revision 163452
Author zol...@webkit.org
Date 2014-02-05 09:36:03 -0800 (Wed, 05 Feb 2014)
Log Message
[CSS Shapes] Simplify CSSBasicShapeInset::cssText
https://bugs.webkit.org/show_bug.cgi?id=127841
Reviewed by David Hyatt.
I introduced the updateCornerRadiusWidthAndHeight helper function, which makes the code of cssText method clearer.
No new tests, no behavior change.
* css/CSSBasicShapes.cpp:
(WebCore::updateCornerRadiusWidthAndHeight): Add helper function.
(WebCore::CSSBasicShapeInset::cssText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSBasicShapes.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (163451 => 163452)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 17:34:59 UTC (rev 163451)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 17:36:03 UTC (rev 163452)
@@ -1,5 +1,20 @@
2014-02-05 Zoltan Horvath
+[CSS Shapes] Simplify CSSBasicShapeInset::cssText
+https://bugs.webkit.org/show_bug.cgi?id=127841
+
+Reviewed by David Hyatt.
+
+I introduced the updateCornerRadiusWidthAndHeight helper function, which makes the code of cssText method clearer.
+
+No new tests, no behavior change.
+
+* css/CSSBasicShapes.cpp:
+(WebCore::updateCornerRadiusWidthAndHeight): Add helper function.
+(WebCore::CSSBasicShapeInset::cssText):
+
+2014-02-05 Zoltan Horvath
+
[CSS Shapes] Simplify BasicShapeInset::path
https://bugs.webkit.org/show_bug.cgi?id=127920
Modified: trunk/Source/WebCore/css/CSSBasicShapes.cpp (163451 => 163452)
--- trunk/Source/WebCore/css/CSSBasicShapes.cpp 2014-02-05 17:34:59 UTC (rev 163451)
+++ trunk/Source/WebCore/css/CSSBasicShapes.cpp 2014-02-05 17:36:03 UTC (rev 163452)
@@ -460,47 +460,33 @@
return result.toString();
}
+static inline void updateCornerRadiusWidthAndHeight(CSSPrimitiveValue* corner, String& width, String& height)
+{
+if (!corner)
+return;
+
+Pair* radius = corner->getPairValue();
+width = radius->first() ? radius->first()->cssText() : String("0");
+if (radius->second())
+height = radius->second()->cssText();
+}
+
String CSSBasicShapeInset::cssText() const
{
String topLeftRadiusWidth;
String topLeftRadiusHeight;
-if (topLeftRadius()) {
-Pair* topLeftRadius = m_topLeftRadius->getPairValue();
-topLeftRadiusWidth = topLeftRadius->first() ? topLeftRadius->first()->cssText() : String("0");
-if (topLeftRadius->second())
-topLeftRadiusHeight = topLeftRadius->second()->cssText();
-}
-
String topRightRadiusWidth;
String topRightRadiusHeight;
-if (topRightRadius()) {
-Pair* topRightRadius = m_topRightRadius->getPairValue();
-if (topRightRadius->first())
-topRightRadiusWidth = topRightRadius->first()->cssText();
-if (topRightRadius->second())
-topRightRadiusHeight = topRightRadius->second()->cssText();
-}
-
String bottomRightRadiusWidth;
String bottomRightRadiusHeight;
-if (bottomRightRadius()) {
-Pair* bottomRightRadius = m_bottomRightRadius->getPairValue();
-if (bottomRightRadius->first())
-bottomRightRadiusWidth = bottomRightRadius->first()->cssText();
-if (bottomRightRadius->second())
-bottomRightRadiusHeight = bottomRightRadius->second()->cssText();
-}
-
String bottomLeftRadiusWidth;
String bottomLeftRadiusHeight;
-if (bottomLeftRadius()) {
-Pair* bottomLeftRadius = m_bottomLeftRadius->getPairValue();
-if (bottomLeftRadius->first())
-bottomLeftRadiusWidth = bottomLeftRadius->first()->cssText();
-if (bottomLeftRadius->second())
-bottomLeftRadiusHeight = bottomLeftRadius->second()->cssText();
-}
+updateCornerRadiusWidthAndHeight(topLeftRadius(), topLeftRadiusWidth, topLeftRadiusHeight);
+updateCornerRadiusWidthAndHeight(topRightRadius(), topRightRadiusWidth, topRightRadiusHeight);
+updateCornerRadiusWidthAndHeight(bottomRightRadius(), bottomRightRadiusWidth, bottomRightRadiusHeight);
+updateCornerRadiusWidthAndHeight(bottomLeftRadius(), bottomLeftRadiusWidth, bottomLeftRadiusHeight);
+
return buildInsetString(m_top ? m_top->cssText() : String(),
m_right ? m_right->cssText() : String(),
m_bottom ? m_bottom->cssText() : String(),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163456] trunk/Source/WebKit2
Title: [163456] trunk/Source/WebKit2 Revision 163456 Author jer.no...@apple.com Date 2014-02-05 10:11:33 -0800 (Wed, 05 Feb 2014) Log Message [WK2] [iOS] No video on embedded YouTube https://bugs.webkit.org/show_bug.cgi?id=128237 Reviewed by Sam Weinig. We were using the wrong #if directive; PLUGIN_PROXY_FOR_VIDEO is an ENABLE not a USE. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (163455 => 163456) --- trunk/Source/WebKit2/ChangeLog 2014-02-05 18:05:52 UTC (rev 163455) +++ trunk/Source/WebKit2/ChangeLog 2014-02-05 18:11:33 UTC (rev 163456) @@ -1,3 +1,15 @@ +2014-02-05 Jer Noble + +[WK2] [iOS] No video on embedded YouTube +https://bugs.webkit.org/show_bug.cgi?id=128237 + +Reviewed by Sam Weinig. + +We were using the wrong #if directive; PLUGIN_PROXY_FOR_VIDEO is an ENABLE not a USE. + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::updatePreferences): + 2014-02-05 Dan Bernstein [Cocoa] Expose more WKWebProcessPlugInFrame properties Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (163455 => 163456) --- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-02-05 18:05:52 UTC (rev 163455) +++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-02-05 18:11:33 UTC (rev 163456) @@ -2529,8 +2529,8 @@ settings.setQTKitEnabled(store.getBoolValueForKey(WebPreferencesKey::isQTKitEnabledKey())); #endif -#if USE(PLUGIN_PROXY_FOR_VIDEO) -settings->setVideoPluginProxyEnabled(false); +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO) +settings.setVideoPluginProxyEnabled(false); #endif #if ENABLE(WEB_AUDIO) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163455] trunk/LayoutTests
Title: [163455] trunk/LayoutTests Revision 163455 Author commit-qu...@webkit.org Date 2014-02-05 10:05:52 -0800 (Wed, 05 Feb 2014) Log Message [EFL] Add expectations for two flaky media layout tests https://bugs.webkit.org/show_bug.cgi?id=128253 Unreviewed EFL layout tests gardening. Patch by Andrzej Badowski on 2014-02-05 * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (163454 => 163455) --- trunk/LayoutTests/ChangeLog 2014-02-05 17:59:49 UTC (rev 163454) +++ trunk/LayoutTests/ChangeLog 2014-02-05 18:05:52 UTC (rev 163455) @@ -1,3 +1,12 @@ +2014-02-05 Andrzej Badowski + +[EFL] Add expectations for two flaky media layout tests +https://bugs.webkit.org/show_bug.cgi?id=128253 + +Unreviewed EFL layout tests gardening. + +* platform/efl/TestExpectations: + 2014-02-05 Alexey Proskuryakov Layout Tests compositing/columns/composited-rl-paginated-repaint.html and Modified: trunk/LayoutTests/platform/efl/TestExpectations (163454 => 163455) --- trunk/LayoutTests/platform/efl/TestExpectations 2014-02-05 17:59:49 UTC (rev 163454) +++ trunk/LayoutTests/platform/efl/TestExpectations 2014-02-05 18:05:52 UTC (rev 163455) @@ -586,6 +586,8 @@ webkit.org/b/116704 media/video-zoom.html [ Pass Failure ] webkit.org/b/122039 media/track/track-cue-overlap-snap-to-lines-not-set.html [ Pass Failure ] webkit.org/b/128179 media/video-timeupdate-reverse-play.html [ Pass Failure ] +webkit.org/b/128251 media/video-preload.html [ Pass Failure ] +webkit.org/b/128252 media/track/track-kind.html [ Pass Failure ] # Opera-submitted tests to W3C for , a lot of failures still. webkit.org/b/103926 media/track/opera/idl/media-idl-tests.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163454] trunk/LayoutTests
Title: [163454] trunk/LayoutTests Revision 163454 Author a...@apple.com Date 2014-02-05 09:59:49 -0800 (Wed, 05 Feb 2014) Log Message Layout Tests compositing/columns/composited-rl-paginated-repaint.html and compositing/columns/composited-lr-paginated-repaint.html are flaky https://bugs.webkit.org/show_bug.cgi?id=128255 * platform/mac-wk2/TestExpectations: Marked them as such. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (163453 => 163454) --- trunk/LayoutTests/ChangeLog 2014-02-05 17:53:10 UTC (rev 163453) +++ trunk/LayoutTests/ChangeLog 2014-02-05 17:59:49 UTC (rev 163454) @@ -1,3 +1,11 @@ +2014-02-05 Alexey Proskuryakov + +Layout Tests compositing/columns/composited-rl-paginated-repaint.html and +compositing/columns/composited-lr-paginated-repaint.html are flaky +https://bugs.webkit.org/show_bug.cgi?id=128255 + +* platform/mac-wk2/TestExpectations: Marked them as such. + 2014-02-05 Sergio Correia SVG preserveAspectRatio=none is not honored. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (163453 => 163454) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-02-05 17:53:10 UTC (rev 163453) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-02-05 17:59:49 UTC (rev 163454) @@ -432,6 +432,9 @@ webkit.org/b/127316 svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html [ Pass Timeout ] +webkit.org/b/128255 compositing/columns/composited-lr-paginated-repaint.html [ Pass Failure ] +webkit.org/b/128255 compositing/columns/composited-rl-paginated-repaint.html [ Pass Failure ] + ### END OF (3) Unclassified failures ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163451] trunk/Source/WebCore
Title: [163451] trunk/Source/WebCore
Revision 163451
Author zol...@webkit.org
Date 2014-02-05 09:34:59 -0800 (Wed, 05 Feb 2014)
Log Message
[CSS Shapes] Simplify BasicShapeInset::path
https://bugs.webkit.org/show_bug.cgi?id=127920
Reviewed by David Hyatt.
I introduced a new static helper function called floatSizeForLengthSize
in order to simplify BasicShapeInset::path method.
No new tests, no behavior change.
* rendering/style/BasicShapes.cpp:
(WebCore::floatSizeForLengthSize): New helper function.
(WebCore::BasicShapeInset::path):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/BasicShapes.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (163450 => 163451)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 17:31:47 UTC (rev 163450)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 17:34:59 UTC (rev 163451)
@@ -1,3 +1,19 @@
+2014-02-05 Zoltan Horvath
+
+[CSS Shapes] Simplify BasicShapeInset::path
+https://bugs.webkit.org/show_bug.cgi?id=127920
+
+Reviewed by David Hyatt.
+
+I introduced a new static helper function called floatSizeForLengthSize
+in order to simplify BasicShapeInset::path method.
+
+No new tests, no behavior change.
+
+* rendering/style/BasicShapes.cpp:
+(WebCore::floatSizeForLengthSize): New helper function.
+(WebCore::BasicShapeInset::path):
+
2014-02-05 Wojciech Bielawski
XMLHttpRequest performs too many copies for ArrayBuffer results
Modified: trunk/Source/WebCore/rendering/style/BasicShapes.cpp (163450 => 163451)
--- trunk/Source/WebCore/rendering/style/BasicShapes.cpp 2014-02-05 17:31:47 UTC (rev 163450)
+++ trunk/Source/WebCore/rendering/style/BasicShapes.cpp 2014-02-05 17:34:59 UTC (rev 163451)
@@ -344,6 +344,12 @@
return result.release();
}
+static FloatSize floatSizeForLengthSize(const LengthSize& lengthSize, const FloatRect& boundingBox)
+{
+return FloatSize(floatValueForLength(lengthSize.width(), boundingBox.width()),
+floatValueForLength(lengthSize.height(), boundingBox.height()));
+}
+
void BasicShapeInset::path(Path& path, const FloatRect& boundingBox)
{
ASSERT(path.isEmpty());
@@ -356,22 +362,10 @@
std::max(boundingBox.width() - left - floatValueForLength(m_right, boundingBox.width()), 0),
std::max(boundingBox.height() - top - floatValueForLength(m_bottom, boundingBox.height()), 0)
),
-FloatSize(
-floatValueForLength(m_topLeftRadius.width(), boundingBox.width()),
-floatValueForLength(m_topLeftRadius.height(), boundingBox.height())
-),
-FloatSize(
-floatValueForLength(m_topRightRadius.width(), boundingBox.width()),
-floatValueForLength(m_topRightRadius.height(), boundingBox.height())
-),
-FloatSize(
-floatValueForLength(m_bottomLeftRadius.width(), boundingBox.width()),
-floatValueForLength(m_bottomLeftRadius.height(), boundingBox.height())
-),
-FloatSize(
-floatValueForLength(m_bottomRightRadius.width(), boundingBox.width()),
-floatValueForLength(m_bottomRightRadius.height(), boundingBox.height())
-)
+floatSizeForLengthSize(m_topLeftRadius, boundingBox),
+floatSizeForLengthSize(m_topRightRadius, boundingBox),
+floatSizeForLengthSize(m_bottomLeftRadius, boundingBox),
+floatSizeForLengthSize(m_bottomRightRadius, boundingBox)
);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163450] trunk/Source/JavaScriptCore
Title: [163450] trunk/Source/_javascript_Core
Revision 163450
Author mhahnenb...@apple.com
Date 2014-02-05 09:31:47 -0800 (Wed, 05 Feb 2014)
Log Message
Malloc called beneath MachineThreads::gatherFromOtherThread(), while forbidden
https://bugs.webkit.org/show_bug.cgi?id=128202
Reviewed by Geoffrey Garen.
This patch uses the new GCSegmentedArray to replace the Vector that was used
to record the set of currently executing CodeBlocks during the conservative
stack scan. This is primarily to avoid the possibility of the Vector resizing
while FastMalloc is forbidden.
* heap/BlockAllocator.h:
* heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::CodeBlockSet):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
* heap/CodeBlockSet.h:
* heap/GCSegmentedArray.h:
(JSC::GCSegmentedArray::begin):
(JSC::GCSegmentedArray::end):
(JSC::GCSegmentedArrayIterator::GCSegmentedArrayIterator):
(JSC::GCSegmentedArrayIterator::get):
(JSC::GCSegmentedArrayIterator::operator*):
(JSC::GCSegmentedArrayIterator::operator->):
(JSC::GCSegmentedArrayIterator::operator==):
(JSC::GCSegmentedArrayIterator::operator!=):
(JSC::GCSegmentedArrayIterator::operator++):
* heap/Heap.cpp:
(JSC::Heap::Heap):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/BlockAllocator.h
trunk/Source/_javascript_Core/heap/CodeBlockSet.cpp
trunk/Source/_javascript_Core/heap/CodeBlockSet.h
trunk/Source/_javascript_Core/heap/GCSegmentedArray.h
trunk/Source/_javascript_Core/heap/Heap.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163449 => 163450)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-05 17:13:57 UTC (rev 163449)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-05 17:31:47 UTC (rev 163450)
@@ -1,3 +1,33 @@
+2014-02-05 Mark Hahnenberg
+
+Malloc called beneath MachineThreads::gatherFromOtherThread(), while forbidden
+https://bugs.webkit.org/show_bug.cgi?id=128202
+
+Reviewed by Geoffrey Garen.
+
+This patch uses the new GCSegmentedArray to replace the Vector that was used
+to record the set of currently executing CodeBlocks during the conservative
+stack scan. This is primarily to avoid the possibility of the Vector resizing
+while FastMalloc is forbidden.
+
+* heap/BlockAllocator.h:
+* heap/CodeBlockSet.cpp:
+(JSC::CodeBlockSet::CodeBlockSet):
+(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
+* heap/CodeBlockSet.h:
+* heap/GCSegmentedArray.h:
+(JSC::GCSegmentedArray::begin):
+(JSC::GCSegmentedArray::end):
+(JSC::GCSegmentedArrayIterator::GCSegmentedArrayIterator):
+(JSC::GCSegmentedArrayIterator::get):
+(JSC::GCSegmentedArrayIterator::operator*):
+(JSC::GCSegmentedArrayIterator::operator->):
+(JSC::GCSegmentedArrayIterator::operator==):
+(JSC::GCSegmentedArrayIterator::operator!=):
+(JSC::GCSegmentedArrayIterator::operator++):
+* heap/Heap.cpp:
+(JSC::Heap::Heap):
+
2014-02-05 Wojciech Bielawski
XMLHttpRequest performs too many copies for ArrayBuffer results
Modified: trunk/Source/_javascript_Core/heap/BlockAllocator.h (163449 => 163450)
--- trunk/Source/_javascript_Core/heap/BlockAllocator.h 2014-02-05 17:13:57 UTC (rev 163449)
+++ trunk/Source/_javascript_Core/heap/BlockAllocator.h 2014-02-05 17:31:47 UTC (rev 163450)
@@ -39,6 +39,7 @@
namespace JSC {
class BlockAllocator;
+class CodeBlock;
class CopiedBlock;
class CopyWorkListSegment;
template class GCArraySegment;
@@ -233,6 +234,7 @@
REGION_SET_FOR(CopiedBlock, m_copiedRegionSet);
REGION_SET_FOR(WeakBlock, m_fourKBBlockRegionSet);
REGION_SET_FOR(GCArraySegment, m_fourKBBlockRegionSet);
+REGION_SET_FOR(GCArraySegment, m_fourKBBlockRegionSet);
REGION_SET_FOR(CopyWorkListSegment, m_workListRegionSet);
REGION_SET_FOR(HandleBlock, m_fourKBBlockRegionSet);
Modified: trunk/Source/_javascript_Core/heap/CodeBlockSet.cpp (163449 => 163450)
--- trunk/Source/_javascript_Core/heap/CodeBlockSet.cpp 2014-02-05 17:13:57 UTC (rev 163449)
+++ trunk/Source/_javascript_Core/heap/CodeBlockSet.cpp 2014-02-05 17:31:47 UTC (rev 163450)
@@ -33,7 +33,10 @@
static const bool verbose = false;
-CodeBlockSet::CodeBlockSet() { }
+CodeBlockSet::CodeBlockSet(BlockAllocator& blockAllocator)
+: m_currentlyExecuting(blockAllocator)
+{
+}
CodeBlockSet::~CodeBlockSet()
{
@@ -109,8 +112,8 @@
void CodeBlockSet::rememberCurrentlyExecutingCodeBlocks(Heap* heap)
{
#if ENABLE(GGC)
-for (size_t i = 0; i < m_currentlyExecuting.size(); ++i)
-heap->addToRememberedSet(m_currentlyExecuting[i]->ownerExecutable());
+for (CodeBlock* codeBlock : m_currentlyExecuting)
+heap->addToRememberedSet(codeBlock->ownerExecutable());
m_currentlyExecuting.clear();
#else
UNUSED_PARAM(heap);
Modified: trunk/Source/_javascript_Core/heap/CodeBlockSet.h (163449 => 163450)
--- trunk/Source/_javascript
[webkit-changes] [163449] trunk/Source/WebKit2
Title: [163449] trunk/Source/WebKit2
Revision 163449
Author m...@apple.com
Date 2014-02-05 09:13:57 -0800 (Wed, 05 Feb 2014)
Log Message
[Cocoa] Expose more WKWebProcessPlugInFrame properties
https://bugs.webkit.org/show_bug.cgi?id=128240
Reviewed by Anders Carlsson.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Declared new properties.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame URL]): Added.
(-[WKWebProcessPlugInFrame childFrames]): Added.
(-[WKWebProcessPlugInFrame containsAnyFormElements]): Added.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163448 => 163449)
--- trunk/Source/WebKit2/ChangeLog 2014-02-05 17:13:07 UTC (rev 163448)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-05 17:13:57 UTC (rev 163449)
@@ -1,5 +1,18 @@
2014-02-05 Dan Bernstein
+[Cocoa] Expose more WKWebProcessPlugInFrame properties
+https://bugs.webkit.org/show_bug.cgi?id=128240
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Declared new properties.
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
+(-[WKWebProcessPlugInFrame URL]): Added.
+(-[WKWebProcessPlugInFrame childFrames]): Added.
+(-[WKWebProcessPlugInFrame containsAnyFormElements]): Added.
+
+2014-02-05 Dan Bernstein
+
[Cocoa] Notify WKWebProcessPlugInLoadDelegate when a frame is removed from the frame hierarchy
https://bugs.webkit.org/show_bug.cgi?id=128239
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h (163448 => 163449)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h 2014-02-05 17:13:07 UTC (rev 163448)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h 2014-02-05 17:13:57 UTC (rev 163449)
@@ -38,6 +38,10 @@
WK_API_CLASS
@interface WKWebProcessPlugInFrame : NSObject
+@property (nonatomic, readonly) NSURL *URL;
+@property (nonatomic, readonly) NSArray *childFrames;
+@property (nonatomic, readonly) BOOL containsAnyFormElements;
+
- (JSContext *)jsContextForWorld:(WKWebProcessPlugInScriptWorld *)world;
- (WKWebProcessPlugInHitTestResult *)hitTest:(CGPoint)point;
- (JSValue *)jsNodeForNodeHandle:(WKWebProcessPlugInNodeHandle *)nodeHandle inWorld:(WKWebProcessPlugInScriptWorld *)world;
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm (163448 => 163449)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm 2014-02-05 17:13:07 UTC (rev 163448)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm 2014-02-05 17:13:57 UTC (rev 163449)
@@ -28,6 +28,8 @@
#if WK_API_ENABLED
+#import "WKNSArray.h"
+#import "WKNSURLExtras.h"
#import "WKWebProcessPlugInHitTestResultInternal.h"
#import "WKWebProcessPlugInNodeHandleInternal.h"
#import "WKWebProcessPlugInScriptWorldInternal.h"
@@ -63,6 +65,21 @@
return [JSValue valueWithJSValueRef:valueRef inContext:[self jsContextForWorld:world]];
}
+- (NSURL *)URL
+{
+return [NSURL _web_URLWithWTFString:_frame->url()];
+}
+
+- (NSArray *)childFrames
+{
+return [wrapper(*_frame->childFrames().leakRef()) autorelease];
+}
+
+- (BOOL)containsAnyFormElements
+{
+return !!_frame->containsAnyFormElements();
+}
+
#pragma mark WKObject protocol implementation
- (API::Object&)_apiObject
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163448] trunk/Source/WebKit2
Title: [163448] trunk/Source/WebKit2
Revision 163448
Author m...@apple.com
Date 2014-02-05 09:13:07 -0800 (Wed, 05 Feb 2014)
Log Message
[Cocoa] Notify WKWebProcessPlugInLoadDelegate when a frame is removed from the frame hierarchy
https://bugs.webkit.org/show_bug.cgi?id=128239
Reviewed by Anders Carlsson.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Declared new
delegate method.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didRemoveFrameFromHierarchy): Implemented this page loader client callback by calling the
load delegate.
(setUpPageLoaderClient): Set the above callback in the client structure.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163447 => 163448)
--- trunk/Source/WebKit2/ChangeLog 2014-02-05 16:13:07 UTC (rev 163447)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-05 17:13:07 UTC (rev 163448)
@@ -1,3 +1,17 @@
+2014-02-05 Dan Bernstein
+
+[Cocoa] Notify WKWebProcessPlugInLoadDelegate when a frame is removed from the frame hierarchy
+https://bugs.webkit.org/show_bug.cgi?id=128239
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Declared new
+delegate method.
+* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
+(didRemoveFrameFromHierarchy): Implemented this page loader client callback by calling the
+load delegate.
+(setUpPageLoaderClient): Set the above callback in the client structure.
+
2014-02-05 Csaba Osztrogonác
Remove ENABLE(SVG) guards
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h (163447 => 163448)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h 2014-02-05 16:13:07 UTC (rev 163447)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h 2014-02-05 17:13:07 UTC (rev 163448)
@@ -41,6 +41,7 @@
- (void)webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController*)controller didFinishLoadForFrame:(WKWebProcessPlugInFrame *)frame;
- (void)webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController*)controller didSameDocumentNavigationForFrame:(WKWebProcessPlugInFrame *)frame;
- (void)webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController*)controller globalObjectIsAvailableForFrame:(WKWebProcessPlugInFrame *)frame inScriptWorld:(WKWebProcessPlugInScriptWorld *)scriptWorld;
+- (void)webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController *)controller didRemoveFrameFromHierarchy:(WKWebProcessPlugInFrame *)frame;
// Layout
- (void)webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController*)controller didLayoutForFrame:(WKWebProcessPlugInFrame *)frame;
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm (163447 => 163448)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm 2014-02-05 16:13:07 UTC (rev 163447)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm 2014-02-05 17:13:07 UTC (rev 163448)
@@ -88,6 +88,15 @@
[loadDelegate webProcessPlugInBrowserContextController:pluginContextController globalObjectIsAvailableForFrame:wrapper(*toImpl(frame)) inScriptWorld:wrapper(*toImpl(scriptWorld))];
}
+static void didRemoveFrameFromHierarchy(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userData, const void* clientInfo)
+{
+WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
+auto loadDelegate = pluginContextController->_loadDelegate.get();
+
+if ([loadDelegate respondsToSelector:@selector(webProcessPlugInBrowserContextController:didRemoveFrameFromHierarchy:)])
+[loadDelegate webProcessPlugInBrowserContextController:pluginContextController didRemoveFrameFromHierarchy:wrapper(*toImpl(frame))];
+}
+
static void didCommitLoadForFrame(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userData, const void *clientInfo)
{
WKWebProcessPlugInBrowserContextController *pluginContextController = (WKWebProcessPlugInBrowserContextController *)clientInfo;
@@ -156,6 +165,7 @@
client.didSameDocumentNavigationForFrame = didSameDocumentNavigationForFrame;
client.didFinishLoadForFrame = didFinishLoadForFrame;
client.globalObjectIsAvailableForFrame = globalObjectIsAvailableForFrame;
+client.didRemoveFrameFromHierarchy = didRemoveFrameFromHiera
[webkit-changes] [163447] trunk/LayoutTests
Title: [163447] trunk/LayoutTests Revision 163447 Author za...@apple.com Date 2014-02-05 08:13:07 -0800 (Wed, 05 Feb 2014) Log Message fast/hidpi/image-srcset-relative-svg-canvas.html needs ImageOnlyFailure tag. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (163446 => 163447) --- trunk/LayoutTests/ChangeLog 2014-02-05 15:25:28 UTC (rev 163446) +++ trunk/LayoutTests/ChangeLog 2014-02-05 16:13:07 UTC (rev 163447) @@ -1,3 +1,9 @@ +2014-02-05 Zalan Bujtas + +fast/hidpi/image-srcset-relative-svg-canvas.html needs ImageOnlyFailure tag. + +* TestExpectations: + 2014-02-05 Grzegorz Czajkowski Verify spellcheck attribute asynchronously Modified: trunk/LayoutTests/TestExpectations (163446 => 163447) --- trunk/LayoutTests/TestExpectations 2014-02-05 15:25:28 UTC (rev 163446) +++ trunk/LayoutTests/TestExpectations 2014-02-05 16:13:07 UTC (rev 163447) @@ -61,7 +61,7 @@ webkit.org/b/124342 fast/hidpi/image-srcset-svg-canvas.html [ ImageOnlyFailure ] webkit.org/b/124342 fast/hidpi/image-srcset-svg-canvas-2x.html [ ImageOnlyFailure ] webkit.org/b/124349 fast/hidpi/image-srcset-relative-svg-canvas-2x.html [ ImageOnlyFailure ] -webkit.org/b/124349 fast/hidpi/image-srcset-relative-svg-canvas.html [ Failure ] +webkit.org/b/124349 fast/hidpi/image-srcset-relative-svg-canvas.html [ ImageOnlyFailure ] webaudio/_javascript_audionode-downmix8-2channel-input.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163445] releases/WebKitGTK/webkit-2.3.5/
Title: [163445] releases/WebKitGTK/webkit-2.3.5/ Revision 163445 Author carlo...@webkit.org Date 2014-02-05 05:59:38 -0800 (Wed, 05 Feb 2014) Log Message Tagging the WebKitGTK+ 2.3.5 release Added Paths releases/WebKitGTK/webkit-2.3.5/ Diff Property changes: releases/WebKitGTK/webkit-2.3.5 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163444] trunk/Source
Title: [163444] trunk/Source
Revision 163444
Author commit-qu...@webkit.org
Date 2014-02-05 04:58:41 -0800 (Wed, 05 Feb 2014)
Log Message
XMLHttpRequest performs too many copies for ArrayBuffer results
https://bugs.webkit.org/show_bug.cgi?id=117458
Patch by Wojciech Bielawski on 2014-02-05
Reviewed by Alexey Proskuryakov.
Based on blink change: https://chromium.googlesource.com/chromium/blink/+/bed266aa5a43f7c080c87e527bd35e2b80ecc7b7
Add SharedBuffer::createArrayBuffer() and use it to create XMLHttpRequest's response in ArrayBuffer
This cuts
- two memsets (in ArrayBuffer::create and SharedBuffer::m_buffer::resize)
- one copy (SharedBuffer::m_buffer to ArrayBufferContents::m_data)
- one allocation (SharedBuffer::m_buffer)
Source/_javascript_Core:
* runtime/ArrayBuffer.h:
Source/WebCore:
No new tests. WebKit desn't provide test mechanism similar to blink's one.
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::createArrayBuffer):
* platform/SharedBuffer.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseArrayBuffer):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayBuffer.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/SharedBuffer.cpp
trunk/Source/WebCore/platform/SharedBuffer.h
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163443 => 163444)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-05 12:57:39 UTC (rev 163443)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-05 12:58:41 UTC (rev 163444)
@@ -1,3 +1,20 @@
+2014-02-05 Wojciech Bielawski
+
+XMLHttpRequest performs too many copies for ArrayBuffer results
+https://bugs.webkit.org/show_bug.cgi?id=117458
+
+Reviewed by Alexey Proskuryakov.
+
+Based on blink change: https://chromium.googlesource.com/chromium/blink/+/bed266aa5a43f7c080c87e527bd35e2b80ecc7b7
+
+Add SharedBuffer::createArrayBuffer() and use it to create XMLHttpRequest's response in ArrayBuffer
+This cuts
+- two memsets (in ArrayBuffer::create and SharedBuffer::m_buffer::resize)
+- one copy (SharedBuffer::m_buffer to ArrayBufferContents::m_data)
+- one allocation (SharedBuffer::m_buffer)
+
+* runtime/ArrayBuffer.h:
+
2014-02-05 Csaba Osztrogonác
Remove ENABLE(SVG) guards
Modified: trunk/Source/_javascript_Core/runtime/ArrayBuffer.h (163443 => 163444)
--- trunk/Source/_javascript_Core/runtime/ArrayBuffer.h 2014-02-05 12:57:39 UTC (rev 163443)
+++ trunk/Source/_javascript_Core/runtime/ArrayBuffer.h 2014-02-05 12:58:41 UTC (rev 163444)
@@ -96,7 +96,7 @@
static inline PassRefPtr create(ArrayBufferContents&);
static inline PassRefPtr createAdopted(const void* data, unsigned byteLength);
-// Only for use by Uint8ClampedArray::createUninitialized.
+// Only for use by Uint8ClampedArray::createUninitialized and SharedBuffer::createArrayBuffer.
static inline PassRefPtr createUninitialized(unsigned numElements, unsigned elementByteSize);
inline void* data();
Modified: trunk/Source/WebCore/ChangeLog (163443 => 163444)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 12:57:39 UTC (rev 163443)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 12:58:41 UTC (rev 163444)
@@ -1,3 +1,26 @@
+2014-02-05 Wojciech Bielawski
+
+XMLHttpRequest performs too many copies for ArrayBuffer results
+https://bugs.webkit.org/show_bug.cgi?id=117458
+
+Reviewed by Alexey Proskuryakov.
+
+Based on blink change: https://chromium.googlesource.com/chromium/blink/+/bed266aa5a43f7c080c87e527bd35e2b80ecc7b7
+
+Add SharedBuffer::createArrayBuffer() and use it to create XMLHttpRequest's response in ArrayBuffer
+This cuts
+- two memsets (in ArrayBuffer::create and SharedBuffer::m_buffer::resize)
+- one copy (SharedBuffer::m_buffer to ArrayBufferContents::m_data)
+- one allocation (SharedBuffer::m_buffer)
+
+No new tests. WebKit desn't provide test mechanism similar to blink's one.
+
+* platform/SharedBuffer.cpp:
+(WebCore::SharedBuffer::createArrayBuffer):
+* platform/SharedBuffer.h:
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::responseArrayBuffer):
+
2014-02-05 Csaba Osztrogonác
Remove ENABLE(SVG) guards
Modified: trunk/Source/WebCore/platform/SharedBuffer.cpp (163443 => 163444)
--- trunk/Source/WebCore/platform/SharedBuffer.cpp 2014-02-05 12:57:39 UTC (rev 163443)
+++ trunk/Source/WebCore/platform/SharedBuffer.cpp 2014-02-05 12:58:41 UTC (rev 163444)
@@ -274,6 +274,26 @@
return this->buffer().data();
}
+PassRefPtr SharedBuffer::createArrayBuffer() const
+{
+RefPtr arrayBuffer = ArrayBuffer::createUninitialized(static_cast(size()), sizeof(char));
+
+const char* segment = 0;
+unsigned position = 0;
+while (unsigned segmentSize = getSomeData(seg
[webkit-changes] [163443] trunk/Tools
Title: [163443] trunk/Tools Revision 163443 Author be...@igalia.com Date 2014-02-05 04:57:39 -0800 (Wed, 05 Feb 2014) Log Message Unreviewed. Add myself to some watchlists. * Scripts/webkitpy/common/config/watchlist: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/watchlist Diff Modified: trunk/Tools/ChangeLog (163442 => 163443) --- trunk/Tools/ChangeLog 2014-02-05 12:31:14 UTC (rev 163442) +++ trunk/Tools/ChangeLog 2014-02-05 12:57:39 UTC (rev 163443) @@ -1,3 +1,9 @@ +2014-02-05 Alberto Garcia + +Unreviewed. Add myself to some watchlists. + +* Scripts/webkitpy/common/config/watchlist: + 2014-02-05 Gabor Rapcsanyi Fix WaitForSVNServer build step after r163372. Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (163442 => 163443) --- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2014-02-05 12:31:14 UTC (rev 163442) +++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2014-02-05 12:57:39 UTC (rev 163443) @@ -313,8 +313,8 @@ "GraphicsLayer": [ "simon.fra...@apple.com", "kondapallykal...@gmail.com" ], "GStreamerGraphics": [ "ale...@webkit.org", "pnorm...@igalia.com", "g...@gnome.org", "mrobin...@webkit.org", "cgar...@igalia.com" ], "GStreamerAudio": [ "pnorm...@igalia.com", "dch...@gmail.com" ], -"GtkBuildSystem": [ "zandober...@gmail.com" ], -"GtkWebKit2PublicAPI": [ "cgar...@igalia.com", "g...@gnome.org", "mrobin...@webkit.org" ], +"GtkBuildSystem": [ "zandober...@gmail.com", "be...@igalia.com" ], +"GtkWebKit2PublicAPI": [ "cgar...@igalia.com", "g...@gnome.org", "mrobin...@webkit.org", "be...@igalia.com" ], "Harfbuzz": [ "dominik.rottsc...@intel.com" ], "HTML": [ "esprehn+aut...@chromium.org", "gyuyoung@webkit.org" ], "IndexedDB": [ "alecfl...@chromium.org", "jsb...@chromium.org" ], @@ -333,7 +333,7 @@ "SVNScripts": [ "dba...@webkit.org" ], "ScrollingCoordinator": [ "ander...@apple.com", "jam...@chromium.org", "toniki...@webkit.org", "cmarc...@webkit.org", "l...@webkit.org" ], "Selectors": [ "allan.jen...@digia.com" ], -"SoupNetwork": [ "g...@gnome.org", "mrobin...@webkit.org", "d...@gnome.org", "dch...@gmail.com", "cgar...@igalia.com" ], +"SoupNetwork": [ "g...@gnome.org", "mrobin...@webkit.org", "d...@gnome.org", "dch...@gmail.com", "cgar...@igalia.com", "be...@igalia.com" ], "TextureMapper" : [ "n...@webkit.org", "cmarc...@webkit.org", "l...@webkit.org", "kondapallykal...@gmail.com" ], "TouchAdjustment" : [ "allan.jen...@digia.com" ], "WTF": [ "benja...@webkit.org", "cmarc...@webkit.org" ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163442] releases/WebKitGTK/webkit-2.4
Title: [163442] releases/WebKitGTK/webkit-2.4 Revision 163442 Author carlo...@webkit.org Date 2014-02-05 04:31:14 -0800 (Wed, 05 Feb 2014) Log Message Unreviewed. Update NEWS and Versions.m4 for 2.3.5 release. .: * Source/autotools/Versions.m4: Bump version numbers. Source/WebKit/gtk: * NEWS: Added release notes for 2.3.5. Modified Paths releases/WebKitGTK/webkit-2.4/ChangeLog releases/WebKitGTK/webkit-2.4/Source/WebKit/gtk/ChangeLog releases/WebKitGTK/webkit-2.4/Source/WebKit/gtk/NEWS releases/WebKitGTK/webkit-2.4/Source/autotools/Versions.m4 Diff Modified: releases/WebKitGTK/webkit-2.4/ChangeLog (163441 => 163442) --- releases/WebKitGTK/webkit-2.4/ChangeLog 2014-02-05 12:31:06 UTC (rev 163441) +++ releases/WebKitGTK/webkit-2.4/ChangeLog 2014-02-05 12:31:14 UTC (rev 163442) @@ -1,3 +1,9 @@ +2014-02-05 Carlos Garcia Campos + +Unreviewed. Update NEWS and Versions.m4 for 2.3.5 release. + +* Source/autotools/Versions.m4: Bump version numbers. + 2014-01-29 Csaba Osztrogonác Remove ENABLE(_javascript__DEBUGGER) leftovers Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit/gtk/ChangeLog (163441 => 163442) --- releases/WebKitGTK/webkit-2.4/Source/WebKit/gtk/ChangeLog 2014-02-05 12:31:06 UTC (rev 163441) +++ releases/WebKitGTK/webkit-2.4/Source/WebKit/gtk/ChangeLog 2014-02-05 12:31:14 UTC (rev 163442) @@ -1,3 +1,9 @@ +2014-02-05 Carlos Garcia Campos + +Unreviewed. Update NEWS and Versions.m4 for 2.3.5 release. + +* NEWS: Added release notes for 2.3.5. + 2014-01-29 Csaba Osztrogonác Remove ENABLE(_javascript__DEBUGGER) guards Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit/gtk/NEWS (163441 => 163442) --- releases/WebKitGTK/webkit-2.4/Source/WebKit/gtk/NEWS 2014-02-05 12:31:06 UTC (rev 163441) +++ releases/WebKitGTK/webkit-2.4/Source/WebKit/gtk/NEWS 2014-02-05 12:31:14 UTC (rev 163442) @@ -1,4 +1,24 @@ = +WebKitGTK+ 2.3.5 += + +What's new in WebKitGTK+ 2.3.5? + + - Add API to allow setting a multiple web process model. + - Add API to pass initialization user data from the UI process to +the web extensions. + - Implement languages support with network process. + - Implement custom URI schemes with network process. + - Disable MemoryCache when the DOCUMENT_VIEWER cache model is set. + - Expose aria-describedby with ATK_RELATION_DESCRIBED_BY. + - Fix a bug that prevented from entering fullscreen again in HTML5 +videos after fullscreen was left with ESC. + - Set playback rate when pipeline is not ready in GStreamer media backend. + - Fix a lockup when playing Icecast radio in GStreamer media backend. + - Fix a web process crash when a download is cancelled. + - Fix several crashes when printing via _javascript_. + += WebKitGTK+ 2.3.4 = Modified: releases/WebKitGTK/webkit-2.4/Source/autotools/Versions.m4 (163441 => 163442) --- releases/WebKitGTK/webkit-2.4/Source/autotools/Versions.m4 2014-02-05 12:31:06 UTC (rev 163441) +++ releases/WebKitGTK/webkit-2.4/Source/autotools/Versions.m4 2014-02-05 12:31:14 UTC (rev 163442) @@ -1,19 +1,19 @@ m4_define([webkit_major_version], [2]) m4_define([webkit_minor_version], [3]) -m4_define([webkit_micro_version], [4]) +m4_define([webkit_micro_version], [5]) # This is the version we'll be using as part of our User-Agent string, # e.g., AppleWebKit/$(webkit_user_agent_version) ... # # Sourced from Source/WebCore/Configurations/Version.xcconfig m4_define([webkit_user_agent_major_version], [538]) -m4_define([webkit_user_agent_minor_version], [12]) +m4_define([webkit_user_agent_minor_version], [15]) # Libtool library version, not to confuse with API version. # See http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html -m4_define([libwebkitgtk_version], [22:1:22]) -m4_define([libjavascriptcoregtk_version], [16:3:16]) -m4_define([libwebkit2gtk_version], [33:0:8]) +m4_define([libwebkitgtk_version], [22:2:22]) +m4_define([libjavascriptcoregtk_version], [16:4:16]) +m4_define([libwebkit2gtk_version], [34:0:9]) m4_define([gtk2_required_version], [2.24.10]) m4_define([gtk3_required_version], [3.6.0]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163441] trunk/Tools
Title: [163441] trunk/Tools Revision 163441 Author rga...@webkit.org Date 2014-02-05 04:31:06 -0800 (Wed, 05 Feb 2014) Log Message Fix WaitForSVNServer build step after r163372. Rubber-stamped by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (WaitForSVNServer.evaluateCommand): add missing return SUCCESS Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (163440 => 163441) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-02-05 11:42:35 UTC (rev 163440) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-02-05 12:31:06 UTC (rev 163441) @@ -137,6 +137,7 @@ def evaluateCommand(self, cmd): if cmd.rc != 0: return WARNINGS +return SUCCESS class InstallWin32Dependencies(shell.Compile): description = ["installing dependencies"] Modified: trunk/Tools/ChangeLog (163440 => 163441) --- trunk/Tools/ChangeLog 2014-02-05 11:42:35 UTC (rev 163440) +++ trunk/Tools/ChangeLog 2014-02-05 12:31:06 UTC (rev 163441) @@ -1,3 +1,12 @@ +2014-02-05 Gabor Rapcsanyi + +Fix WaitForSVNServer build step after r163372. + +Rubber-stamped by Csaba Osztrogonác. + +* BuildSlaveSupport/build.webkit.org-config/master.cfg: +(WaitForSVNServer.evaluateCommand): add missing return SUCCESS + 2014-02-05 Csaba Osztrogonác Remove ENABLE(SVG) guards ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163439] trunk/Source/WebCore
Title: [163439] trunk/Source/WebCore
Revision 163439
Author zandober...@gmail.com
Date 2014-02-05 03:19:54 -0800 (Wed, 05 Feb 2014)
Log Message
Manage CalcExpressionNode and derived classes through std::unique_ptr instead of OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=128118
Reviewed by Darin Adler.
Replace uses of OwnPtr for CalcExpressionNode and derived classes with std::unique_ptr.
* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
* css/CSSCalculationValue.h:
* platform/CalculationValue.cpp:
(WebCore::CalculationValue::create):
* platform/CalculationValue.h:
(WebCore::CalculationValue::CalculationValue):
(WebCore::CalcExpressionBinaryOperation::CalcExpressionBinaryOperation):
* platform/Length.cpp:
(WebCore::Length::blendMixedTypes):
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeCenterCoordinate::updateComputedLength):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSCalculationValue.cpp
trunk/Source/WebCore/css/CSSCalculationValue.h
trunk/Source/WebCore/platform/CalculationValue.cpp
trunk/Source/WebCore/platform/CalculationValue.h
trunk/Source/WebCore/platform/Length.cpp
trunk/Source/WebCore/rendering/style/BasicShapes.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (163438 => 163439)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 11:11:46 UTC (rev 163438)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 11:19:54 UTC (rev 163439)
@@ -1,5 +1,28 @@
2014-02-05 Zan Dobersek
+Manage CalcExpressionNode and derived classes through std::unique_ptr instead of OwnPtr
+https://bugs.webkit.org/show_bug.cgi?id=128118
+
+Reviewed by Darin Adler.
+
+Replace uses of OwnPtr for CalcExpressionNode and derived classes with std::unique_ptr.
+
+* css/CSSCalculationValue.cpp:
+(WebCore::CSSCalcPrimitiveValue::toCalcValue):
+(WebCore::CSSCalcBinaryOperation::toCalcValue):
+* css/CSSCalculationValue.h:
+* platform/CalculationValue.cpp:
+(WebCore::CalculationValue::create):
+* platform/CalculationValue.h:
+(WebCore::CalculationValue::CalculationValue):
+(WebCore::CalcExpressionBinaryOperation::CalcExpressionBinaryOperation):
+* platform/Length.cpp:
+(WebCore::Length::blendMixedTypes):
+* rendering/style/BasicShapes.cpp:
+(WebCore::BasicShapeCenterCoordinate::updateComputedLength):
+
+2014-02-05 Zan Dobersek
+
Remove CLASS_IF_GCC workarounds
https://bugs.webkit.org/show_bug.cgi?id=128207
Modified: trunk/Source/WebCore/css/CSSCalculationValue.cpp (163438 => 163439)
--- trunk/Source/WebCore/css/CSSCalculationValue.cpp 2014-02-05 11:11:46 UTC (rev 163438)
+++ trunk/Source/WebCore/css/CSSCalculationValue.cpp 2014-02-05 11:19:54 UTC (rev 163439)
@@ -37,8 +37,6 @@
#include "StyleResolver.h"
#include
-#include
-#include
#include
static const int maxExpressionDepth = 100;
@@ -207,19 +205,18 @@
return m_value->cssText();
}
-virtual PassOwnPtr toCalcValue(const RenderStyle* style, const RenderStyle* rootStyle, double zoom) const
+virtual std::unique_ptr toCalcValue(const RenderStyle* style, const RenderStyle* rootStyle, double zoom) const
{
switch (m_category) {
case CalcNumber:
-return adoptPtr(new CalcExpressionNumber(m_value->getFloatValue()));
+return std::make_unique(m_value->getFloatValue());
case CalcLength:
-return adoptPtr(new CalcExpressionNumber(m_value->computeLength(style, rootStyle, zoom)));
+return std::make_unique(m_value->computeLength(style, rootStyle, zoom));
case CalcPercent:
case CalcPercentLength: {
CSSPrimitiveValue* primitiveValue = m_value.get();
-return adoptPtr(new CalcExpressionLength(primitiveValue
-? primitiveValue->convertToLength(style, rootStyle, zoom)
-: Length(Undefined)));
+return std::make_unique(primitiveValue
+? primitiveValue->convertToLength(style, rootStyle, zoom) : Length(Undefined));
}
// Only types that could be part of a Length _expression_ can be converted
// to a CalcExpressionNode. CalcPercentNumber makes no sense as a Length.
@@ -399,15 +396,15 @@
return !doubleValue();
}
-virtual PassOwnPtr toCalcValue(const RenderStyle* style, const RenderStyle* rootStyle, double zoom) const
+virtual std::unique_ptr toCalcValue(const RenderStyle* style, const RenderStyle* rootStyle, double zoom) const
{
-OwnPtr left(m_leftSide->toCalcValue(style, rootStyle, zoom));
+std::unique_ptr left(m_leftSide->toCalcValue(style, rootStyle, zoom));
if (!left)
return nullptr;
-OwnPtr right(m_rightSide->toCalcValue(style, rootStyle, zoom));
+std::unique_ptr right(m_rightSide->toCalcValue(style, rootS
[webkit-changes] [163438] releases/WebKitGTK/webkit-2.4
Title: [163438] releases/WebKitGTK/webkit-2.4
Revision 163438
Author carlo...@webkit.org
Date 2014-02-05 03:11:46 -0800 (Wed, 05 Feb 2014)
Log Message
Merge r163329 - REGRESSION (r163018): Can’t scroll in lists
https://bugs.webkit.org/show_bug.cgi?id=128090
Source/WebCore:
The regression was caused by the fact that a new method scrollWithWheelEventLocation() was added
to RenderBox to replace the generic scroll() method for the particular case of scrolling using
the mouse wheel. This turned out to be a mistake because in the case of some elements, like select lists,
the scroll method was overriden and now the incorrect method was being called.
The solution was to remove the new method and just add two default parameters to the generic
scroll method.
Patch by Radu Stavila on 2014-02-03
Reviewed by Simon Fraser.
Test: fast/scrolling/scroll-select-list.html
* page/EventHandler.cpp:
(WebCore::scrollNode):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::scroll):
* rendering/RenderBox.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::scroll):
* rendering/RenderEmbeddedObject.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scroll):
* rendering/RenderListBox.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::scroll):
* rendering/RenderTextControlSingleLine.h:
LayoutTests:
New test validates scrolling using the mouse wheel inside a select list.
This test is for the moment added as a ImageOnlyFailure expectation
because the current implementation of eventSender cannot simulate mouse wheel events.
Patch by Radu Stavila on 2014-02-03
Reviewed by Simon Fraser.
* TestExpectations:
* fast/scrolling/scroll-select-list-expected.html: Added.
* fast/scrolling/scroll-select-list.html: Added.
Modified Paths
releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.4/LayoutTests/TestExpectations
releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.4/Source/WebCore/page/EventHandler.cpp
releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderBox.cpp
releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderBox.h
releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderEmbeddedObject.cpp
releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderEmbeddedObject.h
releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderListBox.cpp
releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderListBox.h
releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderTextControlSingleLine.h
Added Paths
releases/WebKitGTK/webkit-2.4/LayoutTests/fast/scrolling/scroll-select-list-expected.html
releases/WebKitGTK/webkit-2.4/LayoutTests/fast/scrolling/scroll-select-list.html
Diff
Modified: releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog (163437 => 163438)
--- releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-02-05 11:01:29 UTC (rev 163437)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-02-05 11:11:46 UTC (rev 163438)
@@ -1,3 +1,18 @@
+2014-02-03 Radu Stavila
+
+REGRESSION (r163018): Can’t scroll in lists
+https://bugs.webkit.org/show_bug.cgi?id=128090
+
+New test validates scrolling using the mouse wheel inside a select list.
+This test is for the moment added as a ImageOnlyFailure expectation
+because the current implementation of eventSender cannot simulate mouse wheel events.
+
+Reviewed by Simon Fraser.
+
+* TestExpectations:
+* fast/scrolling/scroll-select-list-expected.html: Added.
+* fast/scrolling/scroll-select-list.html: Added.
+
2014-01-29 Alexey Proskuryakov
Add a WebCrypto test to verify that BigInteger allows for leading zeroes
Modified: releases/WebKitGTK/webkit-2.4/LayoutTests/TestExpectations (163437 => 163438)
--- releases/WebKitGTK/webkit-2.4/LayoutTests/TestExpectations 2014-02-05 11:01:29 UTC (rev 163437)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/TestExpectations 2014-02-05 11:11:46 UTC (rev 163438)
@@ -2,6 +2,9 @@
#
# See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
+# Incomplete implementation of eventSender causes this test to fail
+webkit.org/b/42194 fast/scrolling/scroll-select-list.html [ ImageOnlyFailure ]
+
# pending functional patch and per-port verification
webkit.org/b/109954 css3/line-break [ Skip ]
Added: releases/WebKitGTK/webkit-2.4/LayoutTests/fast/scrolling/scroll-select-list-expected.html (0 => 163438)
--- releases/WebKitGTK/webkit-2.4/LayoutTests/fast/scrolling/scroll-select-list-expected.html (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/fast/scrolling/scroll-select-list-expected.html 2014-02-05 11:11:46 UTC (rev 163438)
@@ -0,0 +1,27 @@
+
+
+
+
+
+
+ _onload_ = function() {
+ var selectList = document.getElementById("list");
+ selectList.
[webkit-changes] [163437] trunk/Source/WebInspectorUI
Title: [163437] trunk/Source/WebInspectorUI
Revision 163437
Author zandober...@gmail.com
Date 2014-02-05 03:01:29 -0800 (Wed, 05 Feb 2014)
Log Message
[GTK] Avoid no-op regenerations of GResourceBundle.xml, GResourceBundle.c
https://bugs.webkit.org/show_bug.cgi?id=128192
Reviewed by Carlos Garcia Campos.
When doing incremental builds, GResourceBundle.xml and GResourceBundle.c can be
generated when the dependencies are newer than the products, but the generation
doesn't necessarily produce a new or different product. This results in constant
regenerations for these two build targets. Touch the products at the end of
generation to avoid this looping.
* GNUmakefile.am:
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/GNUmakefile.am
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (163436 => 163437)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-02-05 10:33:16 UTC (rev 163436)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-02-05 11:01:29 UTC (rev 163437)
@@ -1,3 +1,18 @@
+2014-02-05 Zan Dobersek
+
+[GTK] Avoid no-op regenerations of GResourceBundle.xml, GResourceBundle.c
+https://bugs.webkit.org/show_bug.cgi?id=128192
+
+Reviewed by Carlos Garcia Campos.
+
+When doing incremental builds, GResourceBundle.xml and GResourceBundle.c can be
+generated when the dependencies are newer than the products, but the generation
+doesn't necessarily produce a new or different product. This results in constant
+regenerations for these two build targets. Touch the products at the end of
+generation to avoid this looping.
+
+* GNUmakefile.am:
+
2014-01-30 Timothy Hatcher
Show profile data in the discrete Scripts timeline view.
Modified: trunk/Source/WebInspectorUI/GNUmakefile.am (163436 => 163437)
--- trunk/Source/WebInspectorUI/GNUmakefile.am 2014-02-05 10:33:16 UTC (rev 163436)
+++ trunk/Source/WebInspectorUI/GNUmakefile.am 2014-02-05 11:01:29 UTC (rev 163437)
@@ -10,11 +10,13 @@
$(AM_V_GEN)
$(AM_V_at)mkdir -p ${GENSOURCES_WEBINSPECTOR_UI}
$(AM_V_at)$(srcdir)/Tools/gtk/generate-inspector-gresource-manifest.py $@
+ $(AM_V_at)touch $@
${GENSOURCES_WEBINSPECTOR_UI}/GResourceBundle.c: DerivedSources/WebInspectorUI/GResourceBundle.xml
$(AM_V_GEN)
$(AM_V_at)glib-compile-resources --generate --sourcedir=$(WebInspectorUI) \
--target=${GENSOURCES_WEBINSPECTOR_UI}/GResourceBundle.c ${GENSOURCES_WEBINSPECTOR_UI}/GResourceBundle.xml
+ $(AM_V_at)touch $@
BUILT_SOURCES += \
DerivedSources/WebInspectorUI/GResourceBundle.xml
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163436] trunk/Source
Title: [163436] trunk/Source
Revision 163436
Author zandober...@gmail.com
Date 2014-02-05 02:33:16 -0800 (Wed, 05 Feb 2014)
Log Message
Remove CLASS_IF_GCC workarounds
https://bugs.webkit.org/show_bug.cgi?id=128207
Reviewed by Anders Carlsson.
Remove the CLASS_IF_GCC macro that was defined to 'class' when using the GCC compiler.
The macro was then used in class friendship declarations for templated classes to avoid
corner-case compiler failures on both GCC pre-4.7 and MSVC pre-2013. The problematic
versions of both compilers are no longer supported, so this macro is good to go.
Source/_javascript_Core:
* heap/HeapBlock.h:
* heap/Region.h:
Source/WebCore:
* bindings/generic/RuntimeEnabledFeatures.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/HeapBlock.h
trunk/Source/_javascript_Core/heap/Region.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163435 => 163436)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-05 10:25:10 UTC (rev 163435)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-05 10:33:16 UTC (rev 163436)
@@ -1,3 +1,18 @@
+2014-02-05 Zan Dobersek
+
+Remove CLASS_IF_GCC workarounds
+https://bugs.webkit.org/show_bug.cgi?id=128207
+
+Reviewed by Anders Carlsson.
+
+Remove the CLASS_IF_GCC macro that was defined to 'class' when using the GCC compiler.
+The macro was then used in class friendship declarations for templated classes to avoid
+corner-case compiler failures on both GCC pre-4.7 and MSVC pre-2013. The problematic
+versions of both compilers are no longer supported, so this macro is good to go.
+
+* heap/HeapBlock.h:
+* heap/Region.h:
+
2014-02-04 Mark Lam
The stack limit computation does not work for Windows.
Modified: trunk/Source/_javascript_Core/heap/HeapBlock.h (163435 => 163436)
--- trunk/Source/_javascript_Core/heap/HeapBlock.h 2014-02-05 10:25:10 UTC (rev 163435)
+++ trunk/Source/_javascript_Core/heap/HeapBlock.h 2014-02-05 10:33:16 UTC (rev 163436)
@@ -35,15 +35,9 @@
class Region;
-#if COMPILER(GCC)
-#define CLASS_IF_GCC class
-#else
-#define CLASS_IF_GCC
-#endif
-
template
class HeapBlock : public DoublyLinkedListNode {
-friend CLASS_IF_GCC DoublyLinkedListNode;
+friend class WTF::DoublyLinkedListNode;
public:
static HeapBlock* destroy(HeapBlock* block) WARN_UNUSED_RETURN
{
Modified: trunk/Source/_javascript_Core/heap/Region.h (163435 => 163436)
--- trunk/Source/_javascript_Core/heap/Region.h 2014-02-05 10:25:10 UTC (rev 163435)
+++ trunk/Source/_javascript_Core/heap/Region.h 2014-02-05 10:33:16 UTC (rev 163436)
@@ -57,7 +57,7 @@
}
class Region : public DoublyLinkedListNode {
-friend CLASS_IF_GCC DoublyLinkedListNode;
+friend class WTF::DoublyLinkedListNode;
friend class BlockAllocator;
public:
~Region();
Modified: trunk/Source/WebCore/ChangeLog (163435 => 163436)
--- trunk/Source/WebCore/ChangeLog 2014-02-05 10:25:10 UTC (rev 163435)
+++ trunk/Source/WebCore/ChangeLog 2014-02-05 10:33:16 UTC (rev 163436)
@@ -1,3 +1,17 @@
+2014-02-05 Zan Dobersek
+
+Remove CLASS_IF_GCC workarounds
+https://bugs.webkit.org/show_bug.cgi?id=128207
+
+Reviewed by Anders Carlsson.
+
+Remove the CLASS_IF_GCC macro that was defined to 'class' when using the GCC compiler.
+The macro was then used in class friendship declarations for templated classes to avoid
+corner-case compiler failures on both GCC pre-4.7 and MSVC pre-2013. The problematic
+versions of both compilers are no longer supported, so this macro is good to go.
+
+* bindings/generic/RuntimeEnabledFeatures.h:
+
2014-02-05 Ryuan Choi
MediaPlayerPrivateGStreamerBase should have virtual destructor
Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (163435 => 163436)
--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2014-02-05 10:25:10 UTC (rev 163435)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2014-02-05 10:33:16 UTC (rev 163436)
@@ -308,14 +308,7 @@
bool m_isFontLoadEventsEnabled;
#endif
-#ifndef CLASS_IF_GCC
-#if COMPILER(GCC)
-#define CLASS_IF_GCC class
-#else
-#define CLASS_IF_GCC
-#endif
-#endif
-friend CLASS_IF_GCC NeverDestroyed;
+friend class WTF::NeverDestroyed;
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163434] releases/WebKitGTK/webkit-2.4/Source
Title: [163434] releases/WebKitGTK/webkit-2.4/Source Revision 163434 Author carlo...@webkit.org Date 2014-02-05 02:19:23 -0800 (Wed, 05 Feb 2014) Log Message Unreviewed. Fix make distcheck. Source/WebCore: * GNUmakefile.list.am: Source/WebKit2: * GNUmakefile.list.am: * Shared/InteractionInformationAtPosition.h: Modified Paths releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-2.4/Source/WebCore/GNUmakefile.list.am releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog releases/WebKitGTK/webkit-2.4/Source/WebKit2/GNUmakefile.list.am releases/WebKitGTK/webkit-2.4/Source/WebKit2/Shared/InteractionInformationAtPosition.h Diff Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog (163433 => 163434) --- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-02-05 09:46:25 UTC (rev 163433) +++ releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-02-05 10:19:23 UTC (rev 163434) @@ -1,3 +1,9 @@ +2014-02-05 Carlos Garcia Campos + +Unreviewed. Fix make distcheck. + +* GNUmakefile.list.am: + 2014-02-04 Zan Dobersek Partially revert r162947 so that Document::topDocument() again Walk over the chain of Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/GNUmakefile.list.am (163433 => 163434) --- releases/WebKitGTK/webkit-2.4/Source/WebCore/GNUmakefile.list.am 2014-02-05 09:46:25 UTC (rev 163433) +++ releases/WebKitGTK/webkit-2.4/Source/WebCore/GNUmakefile.list.am 2014-02-05 10:19:23 UTC (rev 163434) @@ -1835,6 +1835,7 @@ Source/WebCore/Modules/indexeddb/IDBHistograms.h \ Source/WebCore/Modules/indexeddb/IDBIndex.cpp \ Source/WebCore/Modules/indexeddb/IDBIndex.h \ + Source/WebCore/Modules/indexeddb/IDBIndexMetadata.h \ Source/WebCore/Modules/indexeddb/IDBKey.cpp \ Source/WebCore/Modules/indexeddb/IDBKey.h \ Source/WebCore/Modules/indexeddb/IDBKeyData.cpp \ @@ -1849,6 +1850,7 @@ Source/WebCore/Modules/indexeddb/leveldb/IDBLevelDBCoding.h \ Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp \ Source/WebCore/Modules/indexeddb/IDBObjectStore.h \ + Source/WebCore/Modules/indexeddb/IDBObjectStoreMetadata.h \ Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp \ Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.h \ Source/WebCore/Modules/indexeddb/IDBOperation.h \ @@ -5866,6 +5868,7 @@ Source/WebCore/platform/leveldb/LevelDBWriteBatch.cpp \ Source/WebCore/platform/network/soup/GOwnPtrSoup.cpp \ Source/WebCore/platform/network/soup/GOwnPtrSoup.h \ + Source/WebCore/platform/network/soup/GUniquePtrSoup.h \ Source/WebCore/platform/network/soup/ProxyServerSoup.cpp \ Source/WebCore/platform/network/soup/ResourceError.h \ Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp \ @@ -6184,7 +6187,7 @@ Source/WebCore/platform/gtk/FileSystemGtk.cpp \ Source/WebCore/platform/gtk/GRefPtrGtk.cpp \ Source/WebCore/platform/gtk/GRefPtrGtk.h \ - Source/WebCore/platform/gtk/GUniquePtr.h \ + Source/WebCore/platform/gtk/GUniquePtrGtk.h \ Source/WebCore/platform/gtk/GtkClickCounter.cpp \ Source/WebCore/platform/gtk/GtkClickCounter.h \ Source/WebCore/platform/gtk/GtkInputMethodFilter.cpp \ @@ -6337,7 +6340,6 @@ if USE_ACCELERATED_COMPOSITING if USE_TEXTURE_MAPPER_GL webcore_sources += \ - Source/WebCore/platform/graphics/filters/texmap/TextureMapperPlatformCompiledProgram.h \ Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp \ Source/WebCore/platform/graphics/texmap/TextureMapperGL.h \ Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp \ Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog (163433 => 163434) --- releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog 2014-02-05 09:46:25 UTC (rev 163433) +++ releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog 2014-02-05 10:19:23 UTC (rev 163434) @@ -1,3 +1,10 @@ +2014-02-05 Carlos Garcia Campos + +Unreviewed. Fix make distcheck. + +* GNUmakefile.list.am: +* Shared/InteractionInformationAtPosition.h: + 2014-01-29 Csaba Osztrogonác Remove ENABLE(_javascript__DEBUGGER) leftovers Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit2/GNUmakefile.list.am (163433 => 163434) --- releases/WebKitGTK/webkit-2.4/Source/WebKit2/GNUmakefile.list.am 2014-02-05 09:46:25 UTC (rev 163433) +++ releases/WebKitGTK/webkit-2.4/Source/WebKit2/GNUmakefile.list.am 2014-02-05 10:19:23 UTC (rev 163434) @@ -392,6 +392,7 @@ Source/WebKit2/Shared/ImageOptions.h \ Source/WebKit2/Shared/ImmutableDictionary.cpp \ Source/WebKit2/Shared/ImmutableDictionary.h \ + Source/WebKit2/Shared/InteractionInformationAtPosition.h \ Source/WebKit2/Shared/LayerTreeContext.h \ Source/WebKit2/Shared/MutableDictionary.cpp \ Source/WebKit2/Shared/MutableDictionary.h \ @@ -510,6 +511,8 @@ Source/WebKit2/Shared/WebTouchEvent.cpp \ Source/WebKit2/Shared/WebUserContentURLPattern.h \ Source/WebKit2/Shared/WebWheelEvent.cpp \ + Source/WebKit2/UIProcess/API/APILoaderClient.h \
[webkit-changes] [163433] trunk/Source
Title: [163433] trunk/Source
Revision 163433
Author zandober...@gmail.com
Date 2014-02-05 01:46:25 -0800 (Wed, 05 Feb 2014)
Log Message
[GTK] Replace DEFINE_STATIC_LOCAL with NeverDestroyed in GTK WK1 and WK2 code
https://bugs.webkit.org/show_bug.cgi?id=128195
Reviewed by Martin Robinson.
Use static NeverDestroyed variables instead of the DEFINE_STATIC_LOCAL macro.
Source/WebKit/gtk:
* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::initialize):
* WebCoreSupport/PlatformStrategiesGtk.h:
* webkit/webkitwebsettings.cpp:
(isGoogleDomain):
Source/WebKit2:
* UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
(historyItemsMap):
* UIProcess/API/gtk/WebKitWebContext.cpp:
(downloadsMap):
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::pluginWindowMap):
* WebProcess/gtk/WebGtkExtensionManager.cpp:
(WebKit::WebGtkExtensionManager::shared):
* WebProcess/gtk/WebGtkExtensionManager.h:
Modified Paths
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h
trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebPageProxyGtk.cpp
trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp
trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.h
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (163432 => 163433)
--- trunk/Source/WebKit/gtk/ChangeLog 2014-02-05 09:02:43 UTC (rev 163432)
+++ trunk/Source/WebKit/gtk/ChangeLog 2014-02-05 09:46:25 UTC (rev 163433)
@@ -1,3 +1,18 @@
+2014-02-05 Zan Dobersek
+
+[GTK] Replace DEFINE_STATIC_LOCAL with NeverDestroyed in GTK WK1 and WK2 code
+https://bugs.webkit.org/show_bug.cgi?id=128195
+
+Reviewed by Martin Robinson.
+
+Use static NeverDestroyed variables instead of the DEFINE_STATIC_LOCAL macro.
+
+* WebCoreSupport/PlatformStrategiesGtk.cpp:
+(PlatformStrategiesGtk::initialize):
+* WebCoreSupport/PlatformStrategiesGtk.h:
+* webkit/webkitwebsettings.cpp:
+(isGoogleDomain):
+
2014-02-04 Andreas Kling
Remove support.
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp (163432 => 163433)
--- trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp 2014-02-05 09:02:43 UTC (rev 163432)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp 2014-02-05 09:46:25 UTC (rev 163433)
@@ -30,8 +30,8 @@
void PlatformStrategiesGtk::initialize()
{
-DEFINE_STATIC_LOCAL(PlatformStrategiesGtk, platformStrategies, ());
-setPlatformStrategies(&platformStrategies);
+static NeverDestroyed platformStrategies;
+setPlatformStrategies(&platformStrategies.get());
}
PlatformStrategiesGtk::PlatformStrategiesGtk()
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h (163432 => 163433)
--- trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h 2014-02-05 09:02:43 UTC (rev 163432)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h 2014-02-05 09:46:25 UTC (rev 163433)
@@ -28,6 +28,7 @@
#include "SharedWorkerStrategy.h"
#include "StorageStrategy.h"
#include "VisitedLinkStrategy.h"
+#include
class PlatformStrategiesGtk : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::DatabaseStrategy, private WebCore::LoaderStrategy, private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::StorageStrategy, private WebCore::VisitedLinkStrategy {
public:
@@ -64,6 +65,8 @@
// WebCore::VisitedLinkStrategy
virtual bool isLinkVisited(WebCore::Page*, WebCore::LinkHash, const WebCore::URL& baseURL, const WTF::AtomicString& attributeURL);
virtual void addVisitedLink(WebCore::Page*, WebCore::LinkHash);
+
+friend class NeverDestroyed;
};
#endif // PlatformStrategiesGtk_h
Modified: trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp (163432 => 163433)
--- trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp 2014-02-05 09:02:43 UTC (rev 163432)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp 2014-02-05 09:46:25 UTC (rev 163433)
@@ -35,10 +35,11 @@
#include "webkitglobalsprivate.h"
#include "webkitversion.h"
#include "webkitwebsettingsprivate.h"
+#include
+#include
#include
#include
#include
-#include
/**
* SECTION:webkitwebsettings
@@ -1586,23 +1587,23 @@
static bool isGoogleDomain(String host)
{
-DEFINE_STATIC_LOCAL(HashSet, googleDomains, ());
-DEFINE_STATIC_LOCAL(Vector, otherGoogleDomains, ());
+static NeverDestroyed> googleDomains;
+static NeverDestroyed> otherGoogleDomains;
-if (googleDomains.isEmpty())
-initializeDomainsList(googleDomains);
+if (googleDomains.get().isEmpty())
+initializeDomainsList(googleDomains.get());
[webkit-changes] [163432] trunk/LayoutTests
Title: [163432] trunk/LayoutTests
Revision 163432
Author g.czajkow...@samsung.com
Date 2014-02-05 01:02:43 -0800 (Wed, 05 Feb 2014)
Log Message
Verify spellcheck attribute asynchronously
https://bugs.webkit.org/show_bug.cgi?id=128174
Reviewed by Sam Weinig.
Refactoring spelling tests that verify spellcheck attribute to use
asynchronous text checking.
* editing/spelling/spelling-attribute-at-child-expected.txt:
* editing/spelling/script-tests/spelling-attribute-at-child.js:
Do not use getElementById if more than one element has the same
id ('child'). Although we defined a bunch of elements with id
'child', however only first one was retrieved and tested.
Additionally, dump current markup so that user is able to see
which element is being tested.
* editing/spelling/spelling-attribute-change-expected.txt:
* editing/spelling/script-tests/spelling-attribute-change.js:
* editing/spelling/spellcheck-attribute-expected.txt:
* editing/spelling/spellcheck-attribute.html:
Dump markup to increase readability of test expectation.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/spelling/script-tests/spelling-attribute-at-child.js
trunk/LayoutTests/editing/spelling/script-tests/spelling-attribute-change.js
trunk/LayoutTests/editing/spelling/spellcheck-attribute-expected.txt
trunk/LayoutTests/editing/spelling/spellcheck-attribute.html
trunk/LayoutTests/editing/spelling/spelling-attribute-at-child-expected.txt
trunk/LayoutTests/editing/spelling/spelling-attribute-change-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (163431 => 163432)
--- trunk/LayoutTests/ChangeLog 2014-02-05 07:11:57 UTC (rev 163431)
+++ trunk/LayoutTests/ChangeLog 2014-02-05 09:02:43 UTC (rev 163432)
@@ -1,3 +1,28 @@
+2014-02-05 Grzegorz Czajkowski
+
+Verify spellcheck attribute asynchronously
+https://bugs.webkit.org/show_bug.cgi?id=128174
+
+Reviewed by Sam Weinig.
+
+Refactoring spelling tests that verify spellcheck attribute to use
+asynchronous text checking.
+
+* editing/spelling/spelling-attribute-at-child-expected.txt:
+* editing/spelling/script-tests/spelling-attribute-at-child.js:
+Do not use getElementById if more than one element has the same
+id ('child'). Although we defined a bunch of elements with id
+'child', however only first one was retrieved and tested.
+Additionally, dump current markup so that user is able to see
+which element is being tested.
+
+* editing/spelling/spelling-attribute-change-expected.txt:
+* editing/spelling/script-tests/spelling-attribute-change.js:
+
+* editing/spelling/spellcheck-attribute-expected.txt:
+* editing/spelling/spellcheck-attribute.html:
+Dump markup to increase readability of test expectation.
+
2014-02-04 Ryosuke Niwa
Undelete the "build" directories erroneously removed in r163427.
Modified: trunk/LayoutTests/editing/spelling/script-tests/spelling-attribute-at-child.js (163431 => 163432)
--- trunk/LayoutTests/editing/spelling/script-tests/spelling-attribute-at-child.js 2014-02-05 07:11:57 UTC (rev 163431)
+++ trunk/LayoutTests/editing/spelling/script-tests/spelling-attribute-at-child.js 2014-02-05 09:02:43 UTC (rev 163432)
@@ -1,29 +1,50 @@
description('Tests if the spellchecker behavior change after the spellcheck attribute changed by the script.');
+jsTestIsAsync = true;
+
+if (window.internals) {
+internals.settings.setUnifiedTextCheckerEnabled(true);
+internals.settings.setAsynchronousSpellCheckingEnabled(true);
+}
+
var root = document.createElement("div");
document.body.appendChild(root);
-function childHasSpellingMarker(markup)
+function verifyChildSpellingMarker(markup, expectation)
{
root.innerHTML = markup;
-var text = document.getElementById("child").firstChild;
-document.getSelection().setPosition(text, 1);
+var childText = root.firstChild.childNodes[1].firstChild;
+document.getSelection().setPosition(childText, 1); // [^]
document.execCommand("InsertText", false, 'z');
document.execCommand("InsertText", false, 'z');
document.execCommand("InsertText", false, ' ');
-var marked = internals.hasSpellingMarker(1, 2);
-root.innerHTML = "";
-return marked;
+debug(escapeHTML(root.innerHTML));
+shouldBecomeEqual('internals.hasSpellingMarker(1, 2)', expectation ? "true" : "false", function() {
+root.innerHTML = "";
+debug("");
+done();
+});
}
-shouldBeFalse("childHasSpellingMarker(\"Foo [] Baz\")");
-shouldBeTrue("childHasSpellingMarker(\"Foo [] Baz\")");
-shouldBeTrue("childHasSpellingMarker(\"Foo [] Baz\")");
-shouldBeFalse("childHasSpellingMarker(\"Foo [] Baz\")");
-shouldBeFalse("childHasSpellingMarker(\"Foo [] Baz\")");
-shouldBeTrue("childHasSpellingMarker(\"Foo [] Baz\")");
-shouldBeFalse("childHasSpellingMarker(\"Foo [] Baz\")");
-shouldBeTrue("childHasSpellingMarker(\"Foo [] Baz
