date:20140220

[webkit-changes] [164476] trunk/LayoutTests

2014-02-20 Thread rniwa

Title: [164476] trunk/LayoutTests








Revision 164476
Author rn...@webkit.org
Date 2014-02-20 22:45:34 -0800 (Thu, 20 Feb 2014)


Log Message
Update test expectations after r164449.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (164475 => 164476)

--- trunk/LayoutTests/ChangeLog	2014-02-21 06:40:05 UTC (rev 164475)
+++ trunk/LayoutTests/ChangeLog	2014-02-21 06:45:34 UTC (rev 164476)
@@ -1,3 +1,9 @@
+2014-02-20  Ryosuke Niwa  
+
+Update test expectations after r164449.
+
+* TestExpectations:
+
 2014-02-19  Ryosuke Niwa  
 
 m_ancestorDisabledState should never be unknown


Modified: trunk/LayoutTests/TestExpectations (164475 => 164476)

--- trunk/LayoutTests/TestExpectations	2014-02-21 06:40:05 UTC (rev 164475)
+++ trunk/LayoutTests/TestExpectations	2014-02-21 06:45:34 UTC (rev 164476)
@@ -105,4 +105,4 @@
 
 #subpixel failure on non-retina displays.
 webkit.org/b/129050 fast/sub-pixel/compositing-layers-on-subpixel-position.html [ Failure ]
-webkit.org/b/129113 fast/multicol/newmulticol/clipping.html [ Failure ]
+webkit.org/b/129113 fast/multicol/newmulticol/clipping.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164475] trunk

2014-02-20 Thread rniwa

Title: [164475] trunk

Revision 164475
Author rn...@webkit.org
Date 2014-02-20 22:40:05 -0800 (Thu, 20 Feb 2014)

Log Message
m_ancestorDisabledState should never be unknown
https://bugs.webkit.org/show_bug.cgi?id=129084

Reviewed by Benjamin Poulain.

Source/WebCore:

In order to resolve the bug 129035, a text form control elements needs to synchronously change
its inner text element's editability by setting or unsetting contenteditable content attribute.
Before this patch, we could not do this because editability of a text form control dependent on
its disabled-ness which was only computed lazily via updateAncestorDisabledState().

This patch makes HTMLFieldSetElement and HTMLFormControlElement update this state synchronously.
To avoid O(k) DOM traversal, where k is the depth of the tree, in insertedInto and removedFrom of
HTMLFormControlElement on most pages, a new document-level flag, m_disabledFieldsetElementsCount,
has been added to indicate whether the document contains any disabled fieldset or not.

Also renamed the misleadingly named disabledAttributeChanged to disabledStateChanged, and added
new function of the same name (disabledAttributeChanged) to be used by HTMLFieldSetElement
for keeping the document-level flag up-to-date upon disabled attribute changes.

Tests: fast/forms/fieldset/fieldset-disabled-2.html

* dom/Document.cpp:
(WebCore::Document::Document): Initializes newly added m_disabledFieldsetElementsCount.
(WebCore::Document::~Document): Assert that we've done house keeping right.
* dom/Document.h:
(WebCore::Document::hasDisabledFieldsetElement): Added.
(WebCore::Document::addDisabledFieldsetElement): Added.
(WebCore::Document::removeDisabledFieldsetElement): Added.

* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::~HTMLFieldSetElement): Removes itself from the owner document.

(WebCore::updateFromControlElementsAncestorDisabledStateUnder): Added. Updates startNode and
its descendants' ancestor disabled flag. We don't update controls under another disabled
fieldset element since disabled-ness of those controls aren't affected by startNode.

(WebCore::HTMLFieldSetElement::disabledAttributeChanged): Call addDisabledFieldsetElement and
removeDisabledFieldsetElement to update the owner document's flag.

(WebCore::HTMLFieldSetElement::disabledStateChanged): Renamed from disabledAttributeChanged.
Enable form control elements under the first legend element and disable or enable other
descendent form controls in accordance with the presence of disabled content attribute.

(WebCore::HTMLFieldSetElement::childrenChanged): Update disabled-ness of form controls under
child legend elements because controls aren't disabled in the first legend element, and adding
or removing child elements may have changed the first legend element.

(WebCore::HTMLFieldSetElement::didMoveToNewDocument): Update the flag on the owner document.
* html/HTMLFieldSetElement.h:

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::computeIsDisabledByFieldsetAncestor): Returns boolean instead of
updating m_ancestorDisabledState internally. Also renamed from updateAncestorDisabledState.

(WebCore::HTMLFormControlElement::setAncestorDisabled): Replaced ancestorDisabledStateWasChanged.
This function updates m_disabledByAncestorFieldset and calls disabledAttributeChanged as needed.

(WebCore::HTMLFormControlElement::disabledAttributeChanged): Added. Calls disabledStateChanged.
(WebCore::HTMLFormControlElement::disabledStateChanged): Renamed from disabledAttributeChanged.

(WebCore::HTMLFormControlElement::insertedInto): Update m_disabledByAncestorFieldset if there is
a possibility (i.e. the document contains any disabled fieldset element) that this form control
is inserted under a disabled fieldset element.

(WebCore::HTMLFormControlElement::removedFrom): If this form control element is not disabled by
a fieldset ancestor, then there is nothing to do. If it is, then check to see if the element is
still disabled now that we've lost some ancestors.

(WebCore::HTMLFormControlElement::isDisabledFormControl): No longer updates m_ancestorDisabledState
lazily since m_disabledByAncestorFieldset is never ambiguous now.

* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::disabledByAncestorFieldset): Added.

LayoutTests:

Added more test cases.

* fast/forms/fieldset/fieldset-disabled-2-expected.txt:
* fast/forms/fieldset/fieldset-disabled-2.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/fieldset/fieldset-disabled-2-expected.txt
trunk/LayoutTests/fast/forms/fieldset/fieldset-disabled-2.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/html/HTMLFieldSetElement.cpp
trunk/Source/WebCore/html/HTMLFieldSetElement.h
trunk/Source/WebCore/html/HTMLFormControlElement.cpp
trunk/Source/WebCore/html/HTMLFormControlElement.h

[webkit-changes] [164474] trunk/Source

2014-02-20 Thread zalan

Title: [164474] trunk/Source








Revision 164474
Author za...@apple.com
Date 2014-02-20 22:32:11 -0800 (Thu, 20 Feb 2014)


Log Message
Remove redundant deviceScaleFactor() functions and make callers use Document::deviceScaleFactor() when accessible.
https://bugs.webkit.org/show_bug.cgi?id=129137

Reviewed by Simon Fraser.

No change in behavior.

Source/WebCore:

* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
* page/Page.cpp:
* page/Page.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::drawPlatformResizerImage):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintProgressBar):
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem):

Source/WebKit2:

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::getFindIndicatorBitmapAndRect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/DeleteButtonController.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderImage.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderThemeMac.mm
trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164473 => 164474)

--- trunk/Source/WebCore/ChangeLog	2014-02-21 06:13:39 UTC (rev 164473)
+++ trunk/Source/WebCore/ChangeLog	2014-02-21 06:32:11 UTC (rev 164474)
@@ -1,3 +1,36 @@
+2014-02-20  Zalan Bujtas  
+
+Remove redundant deviceScaleFactor() functions and make callers use Document::deviceScaleFactor() when accessible.
+https://bugs.webkit.org/show_bug.cgi?id=129137
+
+Reviewed by Simon Fraser.
+
+No change in behavior.
+
+* editing/DeleteButtonController.cpp:
+(WebCore::DeleteButtonController::createDeletionUI):
+* page/Page.cpp:
+* page/Page.h:
+* platform/graphics/GraphicsContext.cpp:
+(WebCore::GraphicsContext::GraphicsContext):
+* platform/graphics/GraphicsContext.h:
+* platform/graphics/cg/GraphicsContextCG.cpp:
+(WebCore::GraphicsContext::platformInit):
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::paintFillLayerExtended):
+(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::imageSizeForError):
+(WebCore::RenderImage::paintReplaced):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::drawPlatformResizerImage):
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::drawLineForBoxSide):
+* rendering/RenderThemeMac.mm:
+(WebCore::RenderThemeMac::paintProgressBar):
+* rendering/svg/SVGRenderingContext.cpp:
+(WebCore::SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem):
+
 2014-02-20  David Kilzer  
 
 Stop generating Objective-C bindings for the SVG DOM


Modified: trunk/Source/WebCore/editing/DeleteButtonController.cpp (164473 => 164474)

--- trunk/Source/WebCore/editing/DeleteButtonController.cpp	2014-02-21 06:13:39 UTC (rev 164473)
+++ trunk/Source/WebCore/editing/DeleteButtonController.cpp	2014-02-21 06:32:11 UTC (rev 164474)
@@ -245,9 +245,8 @@
 button->setInlineStyleProperty(CSSPropertyHeight, buttonHeight, CSSPrimitiveValue::CSS_PX);
 button->setInlineStyleProperty(CSSPropertyVisibility, CSSValueVisible);
 
-float deviceScaleFactor = WebCore::deviceScaleFactor(&m_frame);
 RefPtr buttonImage;
-if (deviceScaleFactor >= 2)
+if (m_target->document().deviceScaleFactor() >= 2)
 buttonImage = Image::loadPlatformResource("deleteButton@2x");
 else
 buttonImage = Image::loadPlatformResource("deleteButton");


Modified: trunk/Source/WebCore/page/Page.cpp (164473 => 164474)

--- trunk/Source/WebCore/page/Page.cpp	2014-02-21 06:13:39 UTC (rev 164473)
+++ trunk/Source/WebCor

[webkit-changes] [164473] trunk/Source/WebCore

2014-02-20 Thread ddkilzer

Title: [164473] trunk/Source/WebCore








Revision 164473
Author ddkil...@apple.com
Date 2014-02-20 22:13:39 -0800 (Thu, 20 Feb 2014)


Log Message
Stop generating Objective-C bindings for the SVG DOM


Reviewed by Timothy Hatcher.

Bug 114076 stopped compiling the Objective-C bindings for the
SVG DOM, but we continued to generate the header and source
files after that landed in r147822.  This patch also stops
generating the unused header and source files.

* DerivedSources.make:
- Split BINDING_IDLS into NON_SVG_BINDING_IDLS and
  SVG_BINDING_IDLS so that they may operated on separately.
- Define BINDING_IDLS again as the full list of IDL files.
- Rename DOM_CLASSES to JS_DOM_CLASSES so that _javascript_
  bindings are still generated for all IDL files.
- Add OBJC_DOM_CLASSES so that Objective-C bindings are only
  generated for non-SVG IDL files.

* bindings/scripts/CodeGeneratorObjC.pm:
(GetBaseClass):
(GetPropertyAttributes):
(AddIncludesForType):
(GenerateHeader):
(GenerateImplementation):
- Remove support for SVG classes.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (164472 => 164473)

--- trunk/Source/WebCore/ChangeLog	2014-02-21 06:07:37 UTC (rev 164472)
+++ trunk/Source/WebCore/ChangeLog	2014-02-21 06:13:39 UTC (rev 164473)
@@ -1,3 +1,32 @@
+2014-02-20  David Kilzer  
+
+Stop generating Objective-C bindings for the SVG DOM
+
+
+Reviewed by Timothy Hatcher.
+
+Bug 114076 stopped compiling the Objective-C bindings for the
+SVG DOM, but we continued to generate the header and source
+files after that landed in r147822.  This patch also stops
+generating the unused header and source files.
+
+* DerivedSources.make:
+- Split BINDING_IDLS into NON_SVG_BINDING_IDLS and
+  SVG_BINDING_IDLS so that they may operated on separately.
+- Define BINDING_IDLS again as the full list of IDL files.
+- Rename DOM_CLASSES to JS_DOM_CLASSES so that _javascript_
+  bindings are still generated for all IDL files.
+- Add OBJC_DOM_CLASSES so that Objective-C bindings are only
+  generated for non-SVG IDL files.
+
+* bindings/scripts/CodeGeneratorObjC.pm:
+(GetBaseClass):
+(GetPropertyAttributes):
+(AddIncludesForType):
+(GenerateHeader):
+(GenerateImplementation):
+- Remove support for SVG classes.
+
 2014-02-20  Simon Fraser  
 
 RenderBox::updateShapeOutsideInfoAfterStyleChange shows up on profiles


Modified: trunk/Source/WebCore/DerivedSources.make (164472 => 164473)

--- trunk/Source/WebCore/DerivedSources.make	2014-02-21 06:07:37 UTC (rev 164472)
+++ trunk/Source/WebCore/DerivedSources.make	2014-02-21 06:13:39 UTC (rev 164473)
@@ -67,7 +67,7 @@
 $(WebCore)/websockets \
 #
 
-BINDING_IDLS = \
+NON_SVG_BINDING_IDLS = \
 $(WebCore)/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl \
 $(WebCore)/Modules/encryptedmedia/MediaKeyMessageEvent.idl \
 $(WebCore)/Modules/encryptedmedia/MediaKeyNeededEvent.idl \
@@ -485,6 +485,34 @@
 $(WebCore)/plugins/DOMPluginArray.idl \
 $(WebCore)/storage/Storage.idl \
 $(WebCore)/storage/StorageEvent.idl \
+$(WebCore)/testing/Internals.idl \
+$(WebCore)/testing/InternalSettings.idl \
+$(WebCore)/testing/MallocStatistics.idl \
+$(WebCore)/testing/MemoryInfo.idl \
+$(WebCore)/testing/TypeConversions.idl \
+$(WebCore)/workers/AbstractWorker.idl \
+$(WebCore)/workers/DedicatedWorkerGlobalScope.idl \
+$(WebCore)/workers/SharedWorker.idl \
+$(WebCore)/workers/SharedWorkerGlobalScope.idl \
+$(WebCore)/workers/Worker.idl \
+$(WebCore)/workers/WorkerGlobalScope.idl \
+$(WebCore)/workers/WorkerLocation.idl \
+$(WebCore)/xml/DOMParser.idl \
+$(WebCore)/xml/XMLHttpRequest.idl \
+$(WebCore)/xml/XMLHttpRequestException.idl \
+$(WebCore)/xml/XMLHttpRequestProgressEvent.idl \
+$(WebCore)/xml/XMLHttpRequestUpload.idl \
+$(WebCore)/xml/XMLSerializer.idl \
+$(WebCore)/xml/XPathEvaluator.idl \
+$(WebCore)/xml/XPathException.idl \
+$(WebCore)/xml/XPathExpression.idl \
+$(WebCore)/xml/XPathNSResolver.idl \
+$(WebCore)/xml/XPathResult.idl \
+$(WebCore)/xml/XSLTProcessor.idl \
+InternalSettingsGenerated.idl
+#
+
+SVG_BINDING_IDLS = \
 $(WebCore)/svg/SVGAElement.idl \
 $(WebCore)/svg/SVGAltGlyphDefElement.idl \
 $(WebCore)/svg/SVGAltGlyphElement.idl \
@@ -633,32 +661,7 @@
 $(WebCore)/svg/SVGViewElement.idl \
 $(WebCore)/svg/SVGViewSpec.idl \
 $(WebCore)/svg/SVGZoomAndPan.idl \
-$(WebCore)/svg/SVGZoomEvent.idl \
-$(WebCore)/testing/Internals.idl \
-$(WebCore)/testing/InternalSettings.idl \
-$(WebCore)/testing/MallocStatistics.idl \
-$(WebCore)/testing/MemoryInfo.idl \
-$(WebCore)/testing/TypeConversi

[webkit-changes] [164472] trunk/Source/JavaScriptCore

2014-02-20 Thread mark . lam

Title: [164472] trunk/Source/_javascript_Core








Revision 164472
Author mark@apple.com
Date 2014-02-20 22:07:37 -0800 (Thu, 20 Feb 2014)


Log Message
virtualForWithFunction() should not throw an exception with a partially initialized frame.


Reviewed by Michael Saboff.

Currently, when JITOperations.cpp's virtualForWithFunction() fails to
prepare the callee function for execution, it proceeds to throw the
exception using the callee frame which is only partially initialized
thus far. Instead, it should be throwing the exception using the caller
frame because:
1. the error happened "in" the caller while preparing the callee for
   execution i.e. the caller frame is the top fully initialized frame
   on the stack.
2. the callee frame is not fully initialized yet, and the unwind
   mechanism cannot depend on the data in it.

* jit/JITOperations.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITOperations.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164471 => 164472)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-21 06:02:11 UTC (rev 164471)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-21 06:07:37 UTC (rev 164472)
@@ -1,5 +1,25 @@
 2014-02-20  Mark Lam  
 
+virtualForWithFunction() should not throw an exception with a partially initialized frame.
+
+
+Reviewed by Michael Saboff.
+
+Currently, when JITOperations.cpp's virtualForWithFunction() fails to
+prepare the callee function for execution, it proceeds to throw the
+exception using the callee frame which is only partially initialized
+thus far. Instead, it should be throwing the exception using the caller
+frame because:
+1. the error happened "in" the caller while preparing the callee for
+   execution i.e. the caller frame is the top fully initialized frame
+   on the stack.
+2. the callee frame is not fully initialized yet, and the unwind
+   mechanism cannot depend on the data in it.
+
+* jit/JITOperations.cpp:
+
+2014-02-20  Mark Lam  
+
 DefaultGCActivityCallback::doWork() should reschedule if GC is deferred.
 
 


Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (164471 => 164472)

--- trunk/Source/_javascript_Core/jit/JITOperations.cpp	2014-02-21 06:02:11 UTC (rev 164471)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp	2014-02-21 06:07:37 UTC (rev 164472)
@@ -758,7 +758,7 @@
 JSObject* error = functionExecutable->prepareForExecution(execCallee, function, &scope, kind);
 execCallee->setScope(scope);
 if (error) {
-exec->vm().throwException(execCallee, error);
+exec->vm().throwException(exec, error);
 return reinterpret_cast(vm->getCTIStub(throwExceptionFromCallSlowPathGenerator).code().executableAddress());
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164471] trunk/Source/WebCore

2014-02-20 Thread simon . fraser

Title: [164471] trunk/Source/WebCore








Revision 164471
Author simon.fra...@apple.com
Date 2014-02-20 22:02:11 -0800 (Thu, 20 Feb 2014)


Log Message
RenderBox::updateShapeOutsideInfoAfterStyleChange shows up on profiles
https://bugs.webkit.org/show_bug.cgi?id=129075

Reviewed by Dean Jackson.

updateShapeOutsideInfoAfterStyleChange() showed up on profiles in content
with no shapes. Avoid calling this if no style has shapeOutside().

* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164470 => 164471)

--- trunk/Source/WebCore/ChangeLog	2014-02-21 05:27:23 UTC (rev 164470)
+++ trunk/Source/WebCore/ChangeLog	2014-02-21 06:02:11 UTC (rev 164471)
@@ -1,3 +1,16 @@
+2014-02-20  Simon Fraser  
+
+RenderBox::updateShapeOutsideInfoAfterStyleChange shows up on profiles
+https://bugs.webkit.org/show_bug.cgi?id=129075
+
+Reviewed by Dean Jackson.
+
+updateShapeOutsideInfoAfterStyleChange() showed up on profiles in content
+with no shapes. Avoid calling this if no style has shapeOutside().
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::styleDidChange):
+
 2014-02-20  ChangSeok Oh  
 
 Remove unused chromium stuff in Extensions3D


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (164470 => 164471)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2014-02-21 05:27:23 UTC (rev 164470)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2014-02-21 06:02:11 UTC (rev 164471)
@@ -381,7 +381,8 @@
 }
 
 #if ENABLE(CSS_SHAPES)
-updateShapeOutsideInfoAfterStyleChange(style(), oldStyle);
+if ((oldStyle && oldStyle->shapeOutside()) || style().shapeOutside())
+updateShapeOutsideInfoAfterStyleChange(style(), oldStyle);
 #endif
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164470] trunk/Source/WebKit2

2014-02-20 Thread benjamin

Title: [164470] trunk/Source/WebKit2








Revision 164470
Author benja...@webkit.org
Date 2014-02-20 21:27:23 -0800 (Thu, 20 Feb 2014)


Log Message
Add a missing piece of r164469

Patch by Benjamin Poulain  on 2014-02-20

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView scrollViewWillBeginDragging:]):
I forgot to duplicate the change from WKViewIOS in r164469.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164469 => 164470)

--- trunk/Source/WebKit2/ChangeLog	2014-02-21 05:22:51 UTC (rev 164469)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-21 05:27:23 UTC (rev 164470)
@@ -1,5 +1,13 @@
 2014-02-20  Benjamin Poulain  
 
+Add a missing piece of r164469
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView scrollViewWillBeginDragging:]):
+I forgot to duplicate the change from WKViewIOS in r164469.
+
+2014-02-20  Benjamin Poulain  
+
 WKInteractionView always blocks the main thread when sending touch events
 https://bugs.webkit.org/show_bug.cgi?id=129059
 


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (164469 => 164470)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-21 05:22:51 UTC (rev 164469)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-21 05:27:23 UTC (rev 164470)
@@ -353,6 +353,8 @@
 
 - (void)scrollViewWillBeginDragging:(UIScrollView *)scrollView
 {
+if (scrollView.panGestureRecognizer.state == UIGestureRecognizerStateBegan)
+[_contentView willStartUserTriggeredScroll];
 [_contentView willStartZoomOrScroll];
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164469] trunk/Source/WebKit2

2014-02-20 Thread benjamin

Title: [164469] trunk/Source/WebKit2








Revision 164469
Author benja...@webkit.org
Date 2014-02-20 21:22:51 -0800 (Thu, 20 Feb 2014)


Log Message
WKInteractionView always blocks the main thread when sending touch events
https://bugs.webkit.org/show_bug.cgi?id=129059

Patch by Benjamin Poulain  on 2014-02-20
Reviewed by Enrica Casucci.

Add the asynchronous dispatching to WebKit2.

* Shared/NativeWebTouchEvent.h:
(WebKit::NativeWebTouchEvent::uniqueId):
* Shared/ios/NativeWebTouchEventIOS.mm:
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
* UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::doneWithTouchEvent):
* UIProcess/API/ios/WKContentView.h:
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView willStartUserTriggeredScroll]):
(-[WKContentView willStartUserTriggeredZoom]):
(-[WKContentView _webTouchEvent:WebKit::preventsNativeGestures:]):
* UIProcess/API/ios/WKContentViewInternal.h:
* UIProcess/API/ios/WKInteractionView.h:
* UIProcess/API/ios/WKInteractionView.mm:
(-[WKInteractionView _webTouchEventsRecognized:]):
(-[WKInteractionView _webTouchEvent:WebKit::preventsNativeGestures:]):
(-[WKInteractionView _willStartUserTriggeredScrollingOrZooming]):
* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView scrollViewWillBeginDragging:]):
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h
trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm
trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm
trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.h
trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm
trunk/Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h
trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.h
trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm
trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164468 => 164469)

--- trunk/Source/WebKit2/ChangeLog	2014-02-21 04:59:09 UTC (rev 164468)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-21 05:22:51 UTC (rev 164469)
@@ -1,5 +1,35 @@
 2014-02-20  Benjamin Poulain  
 
+WKInteractionView always blocks the main thread when sending touch events
+https://bugs.webkit.org/show_bug.cgi?id=129059
+
+Reviewed by Enrica Casucci.
+
+Add the asynchronous dispatching to WebKit2.
+
+* Shared/NativeWebTouchEvent.h:
+(WebKit::NativeWebTouchEvent::uniqueId):
+* Shared/ios/NativeWebTouchEventIOS.mm:
+(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
+* UIProcess/API/ios/PageClientImplIOS.mm:
+(WebKit::PageClientImpl::doneWithTouchEvent):
+* UIProcess/API/ios/WKContentView.h:
+* UIProcess/API/ios/WKContentView.mm:
+(-[WKContentView willStartUserTriggeredScroll]):
+(-[WKContentView willStartUserTriggeredZoom]):
+(-[WKContentView _webTouchEvent:WebKit::preventsNativeGestures:]):
+* UIProcess/API/ios/WKContentViewInternal.h:
+* UIProcess/API/ios/WKInteractionView.h:
+* UIProcess/API/ios/WKInteractionView.mm:
+(-[WKInteractionView _webTouchEventsRecognized:]):
+(-[WKInteractionView _webTouchEvent:WebKit::preventsNativeGestures:]):
+(-[WKInteractionView _willStartUserTriggeredScrollingOrZooming]):
+* UIProcess/API/ios/WKViewIOS.mm:
+(-[WKView scrollViewWillBeginDragging:]):
+* WebKit2.xcodeproj/project.pbxproj:
+
+2014-02-20  Benjamin Poulain  
+
 Start fixing the view states driven by the WKScrollView
 https://bugs.webkit.org/show_bug.cgi?id=129140
 


Modified: trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h (164468 => 164469)

--- trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h	2014-02-21 04:59:09 UTC (rev 164468)
+++ trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h	2014-02-21 05:22:51 UTC (rev 164469)
@@ -46,7 +46,7 @@
 public:
 #if PLATFORM(IOS)
 explicit NativeWebTouchEvent(UIWebTouchEventsGestureRecognizer *);
-const UIWebTouchEventsGestureRecognizer* nativeEvent() const { return m_nativeEvent.get(); }
+unsigned uniqueId() const { return m_uniqueID; }
 #elif PLATFORM(GTK)
 NativeWebTouchEvent(const NativeWebTouchEvent&);
 NativeWebTouchEvent(GdkEvent*, WebCore::GtkTouchContextHelper&);
@@ -59,7 +59,7 @@
 
 private:
 #if PLATFORM(IOS)
-RetainPtr m_nativeEvent;
+unsigned m_uniqueID;
 #elif PLATFORM(GTK)
 GUniquePtr m_nativeEvent;
 const WebCore::GtkTouchContextHelper& m_touchContext;


Modified: trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm (164468 => 164469)

--- trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm	2014-02-21 04:59:09 UTC (rev 164468)
+++ trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm	2014-02-21 05:22:51 UTC (rev 164469)
@@ -35,6 +35,8 @@
 
 namespace WebKit {
 
+static unsigned uniqueTouchEventIdIndex = 0;
+
 static inline WebEvent::Type webEventT

[webkit-changes] [164468] trunk/Source/WebCore

2014-02-20 Thread changseok . oh

Title: [164468] trunk/Source/WebCore








Revision 164468
Author changseok...@collabora.com
Date 2014-02-20 20:59:09 -0800 (Thu, 20 Feb 2014)


Log Message
Remove unused chromium stuff in Extensions3D
https://bugs.webkit.org/show_bug.cgi?id=129086

Reviewed by Anders Carlsson.

Remove GL_CHROMIUM_copy_texture and GL_CHROMIUM_flipy interfaces since they are used nowhere.

No new tests since no functionality changed.

* platform/graphics/Extensions3D.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
* platform/graphics/opengl/Extensions3DOpenGL.h:
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
* platform/graphics/opengl/Extensions3DOpenGLES.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Extensions3D.h
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (164467 => 164468)

--- trunk/Source/WebCore/ChangeLog	2014-02-21 04:55:44 UTC (rev 164467)
+++ trunk/Source/WebCore/ChangeLog	2014-02-21 04:59:09 UTC (rev 164468)
@@ -1,3 +1,20 @@
+2014-02-20  ChangSeok Oh  
+
+Remove unused chromium stuff in Extensions3D
+https://bugs.webkit.org/show_bug.cgi?id=129086
+
+Reviewed by Anders Carlsson.
+
+Remove GL_CHROMIUM_copy_texture and GL_CHROMIUM_flipy interfaces since they are used nowhere.
+
+No new tests since no functionality changed.
+
+* platform/graphics/Extensions3D.h:
+* platform/graphics/opengl/Extensions3DOpenGL.cpp:
+* platform/graphics/opengl/Extensions3DOpenGL.h:
+* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
+* platform/graphics/opengl/Extensions3DOpenGLES.h:
+
 2014-02-20  Joseph Pecoraro  
 
 [iOS] Assert / crash trying to draw empty checked input


Modified: trunk/Source/WebCore/platform/graphics/Extensions3D.h (164467 => 164468)

--- trunk/Source/WebCore/platform/graphics/Extensions3D.h	2014-02-21 04:55:44 UTC (rev 164467)
+++ trunk/Source/WebCore/platform/graphics/Extensions3D.h	2014-02-21 04:59:09 UTC (rev 164468)
@@ -71,8 +71,6 @@
 //   GL_IMG_texture_compression_pvrtc
 //   EXT_texture_filter_anisotropic
 //   GL_EXT_debug_marker
-//   GL_CHROMIUM_copy_texture
-//   GL_CHROMIUM_flipy
 //   GL_ARB_draw_buffers / GL_EXT_draw_buffers
 //   GL_ANGLE_instanced_arrays
 
@@ -155,13 +153,6 @@
 TEXTURE_MAX_ANISOTROPY_EXT = 0x84FE,
 MAX_TEXTURE_MAX_ANISOTROPY_EXT = 0x84FF,
 
-// GL_CHROMIUM_flipy
-UNPACK_FLIP_Y_CHROMIUM = 0x9240,
-
-// GL_CHROMIUM_copy_texture
-UNPACK_PREMULTIPLY_ALPHA_CHROMIUM = 0x9241,
-UNPACK_UNPREMULTIPLY_ALPHA_CHROMIUM = 0x9242,
-
 // GL_ARB_draw_buffers / GL_EXT_draw_buffers
 MAX_DRAW_BUFFERS_EXT = 0x8824,
 DRAW_BUFFER0_EXT = 0x8825,
@@ -223,9 +214,6 @@
 // GL_ANGLE_translated_shader_source
 virtual String getTranslatedShaderSourceANGLE(Platform3DObject) = 0;
 
-// GL_CHROMIUM_copy_texture
-virtual void copyTextureCHROMIUM(GC3Denum, Platform3DObject, Platform3DObject, GC3Dint, GC3Denum) = 0;
-
 // EXT Robustness - uses getGraphicsResetStatusARB
 virtual void readnPixelsEXT(int x, int y, GC3Dsizei width, GC3Dsizei height, GC3Denum format, GC3Denum type, GC3Dsizei bufSize, void *data) = 0;
 virtual void getnUniformfvEXT(GC3Duint program, int location, GC3Dsizei bufSize, float *params) = 0;


Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp (164467 => 164468)

--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2014-02-21 04:55:44 UTC (rev 164467)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2014-02-21 04:59:09 UTC (rev 164468)
@@ -141,12 +141,6 @@
 #endif
 }
 
-void Extensions3DOpenGL::copyTextureCHROMIUM(GC3Denum, Platform3DObject, Platform3DObject, GC3Dint, GC3Denum)
-{
-// FIXME: implement this function and add GL_CHROMIUM_copy_texture in supports().
-return;
-}
-
 void Extensions3DOpenGL::insertEventMarkerEXT(const String&)
 {
 // FIXME: implement this function and add GL_EXT_debug_marker in supports().


Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h (164467 => 164468)

--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h	2014-02-21 04:55:44 UTC (rev 164467)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h	2014-02-21 04:59:09 UTC (rev 164468)
@@ -47,7 +47,6 @@
 virtual void deleteVertexArrayOES(Platform3DObject);
 virtual GC3Dboolean isVertexArrayOES(Platform3DObject);
 virtual void bindVertexArrayOES(Platform3DObject);
-virtual void copyTextureCHROMIUM(GC3Denum, Platform3DObject, Platform3DObject, GC3Dint, GC3Denum);
 virtual void insertEventMarkerEXT(co

[webkit-changes] [164467] trunk

2014-02-20 Thread commit-queue

Title: [164467] trunk








Revision 164467
Author commit-qu...@webkit.org
Date 2014-02-20 20:55:44 -0800 (Thu, 20 Feb 2014)


Log Message
[iOS] Assert / crash trying to draw empty checked input
https://bugs.webkit.org/show_bug.cgi?id=129138

Patch by Joseph Pecoraro  on 2014-02-20
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/forms/checkbox-empty-size.html

* rendering/RenderThemeIOS.mm:
(WebCore::shortened):
Avoid a divide by 0, but checking for the condition upfront.

LayoutTests:

* fast/forms/checkbox-empty-size-expected.txt: Added.
* fast/forms/checkbox-empty-size.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeIOS.mm


Added Paths

trunk/LayoutTests/fast/forms/checkbox-empty-size-expected.txt
trunk/LayoutTests/fast/forms/checkbox-empty-size.html




Diff

Modified: trunk/LayoutTests/ChangeLog (164466 => 164467)

--- trunk/LayoutTests/ChangeLog	2014-02-21 04:53:48 UTC (rev 164466)
+++ trunk/LayoutTests/ChangeLog	2014-02-21 04:55:44 UTC (rev 164467)
@@ -1,3 +1,13 @@
+2014-02-20  Joseph Pecoraro  
+
+[iOS] Assert / crash trying to draw empty checked input
+https://bugs.webkit.org/show_bug.cgi?id=129138
+
+Reviewed by Simon Fraser.
+
+* fast/forms/checkbox-empty-size-expected.txt: Added.
+* fast/forms/checkbox-empty-size.html: Added.
+
 2014-02-20  Geoffrey Garen  
 
 Math.imul gives wrong results


Added: trunk/LayoutTests/fast/forms/checkbox-empty-size-expected.txt (0 => 164467)

--- trunk/LayoutTests/fast/forms/checkbox-empty-size-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/checkbox-empty-size-expected.txt	2014-02-21 04:55:44 UTC (rev 164467)
@@ -0,0 +1 @@
+   Test passes if it does not crash.


Added: trunk/LayoutTests/fast/forms/checkbox-empty-size.html (0 => 164467)

--- trunk/LayoutTests/fast/forms/checkbox-empty-size.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/checkbox-empty-size.html	2014-02-21 04:55:44 UTC (rev 164467)
@@ -0,0 +1,14 @@
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+
+
+
+
+Test passes if it does not crash.
+
+


Modified: trunk/Source/WebCore/ChangeLog (164466 => 164467)

--- trunk/Source/WebCore/ChangeLog	2014-02-21 04:53:48 UTC (rev 164466)
+++ trunk/Source/WebCore/ChangeLog	2014-02-21 04:55:44 UTC (rev 164467)
@@ -1,3 +1,16 @@
+2014-02-20  Joseph Pecoraro  
+
+[iOS] Assert / crash trying to draw empty checked input
+https://bugs.webkit.org/show_bug.cgi?id=129138
+
+Reviewed by Simon Fraser.
+
+Test: fast/forms/checkbox-empty-size.html
+
+* rendering/RenderThemeIOS.mm:
+(WebCore::shortened):
+Avoid a divide by 0, but checking for the condition upfront.
+
 2014-02-20  Benjamin Poulain  
 
 Start fixing the view states driven by the WKScrollView


Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (164466 => 164467)

--- trunk/Source/WebCore/rendering/RenderThemeIOS.mm	2014-02-21 04:53:48 UTC (rev 164466)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm	2014-02-21 04:55:44 UTC (rev 164467)
@@ -338,7 +338,7 @@
 {
 float x = end.x - start.x;
 float y = end.y - start.y;
-float ratio = width / sqrtf(x * x + y * y);
+float ratio = (!x && !y) ? 0 : width / sqrtf(x * x + y * y);
 return CGPointMake(start.x + x * ratio, start.y + y * ratio);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164466] trunk/Source

2014-02-20 Thread benjamin

Title: [164466] trunk/Source








Revision 164466
Author benja...@webkit.org
Date 2014-02-20 20:53:48 -0800 (Thu, 20 Feb 2014)


Log Message
Start fixing the view states driven by the WKScrollView
https://bugs.webkit.org/show_bug.cgi?id=129140

Patch by Benjamin Poulain  on 2014-02-20
Reviewed by Tim Horton and Simon Fraser.

Source/WebCore: 

* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::scaledExposedRect):
That comment was more confusing than helping. FrameView-relative coordinates should not need
scaling.

Source/WebKit2: 

WKScrollView creates a "window" over WKContentView with an area that is exposed,
an area that is unobcured and with a certain scale.

Instead of having 3 loosely related paths for updating WKContentView
when the content "window" change, everything is consolidated behind the
single API -[WKContentView didUpdateVisibleRect:unobscuredRect:scale:].

This patch only fixes the content updates from the UI process side to keep things simple.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didFinishScrolling]):
(-[WKWebView scrollViewDidEndDragging:willDecelerate:]):
(-[WKWebView scrollViewDidEndDecelerating:]):
(-[WKWebView scrollViewDidScrollToTop:]):
(-[WKWebView scrollViewDidScroll:]):
(-[WKWebView scrollViewDidEndZooming:withView:atScale:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _updateContentWindow]):
(-[WKWebView _setObscuredInsets:]):
* UIProcess/API/ios/WKContentView.h:
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:]):
(-[WKContentView _updateFixedPositionRect]):
(-[WKContentView didFinishScrolling]):
(-[WKContentView didZoomToScale:]):
* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView contentView:didCommitLayerTree:]):
(-[WKView _didFinishScrolling]):
(-[WKView scrollViewDidEndDragging:willDecelerate:]):
(-[WKView scrollViewDidEndDecelerating:]):
(-[WKView scrollViewDidScrollToTop:]):
(-[WKView scrollViewDidScroll:]):
(-[WKView scrollViewDidEndZooming:withView:atScale:]):
Scrolling is modified to take into account the view position and the obcured content.
Instead of driving the scrolling position from the UIScrollView delegate callbacks,
we use changes in unobscured rect to find changes in "content visible scroll position".

WebPageProxy::didFinishScrolling() is removed. All the scrollOffset updates now go through
the ScrollingCoordinator.

(-[WKView _frameOrBoundsChanged]):
(-[WKView _updateContentWindow]):
(-[WKView _setObscuredInsets:]):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::unobscuredContentRect):
(WebKit::WebPageProxy::setUnobscuredContentRect):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/mac/TileController.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.h
trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm
trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (164465 => 164466)

--- trunk/Source/WebCore/ChangeLog	2014-02-21 04:04:23 UTC (rev 164465)
+++ trunk/Source/WebCore/ChangeLog	2014-02-21 04:53:48 UTC (rev 164466)
@@ -1,3 +1,15 @@
+2014-02-20  Benjamin Poulain  
+
+Start fixing the view states driven by the WKScrollView
+https://bugs.webkit.org/show_bug.cgi?id=129140
+
+Reviewed by Tim Horton and Simon Fraser.
+
+* platform/graphics/ca/mac/TileController.mm:
+(WebCore::TileController::scaledExposedRect):
+That comment was more confusing than helping. FrameView-relative coordinates should not need
+scaling.
+
 2014-02-20  Gyuyoung Kim  
 
 Start to use std::unique_ptr for DragImageLoader


Modified: trunk/Source/WebCore/platform/graphics/ca/mac/TileController.mm (164465 => 164466)

--- trunk/Source/WebCore/platform/graphics/ca/mac/TileController.mm	2014-02-21 04:04:23 UTC (rev 164465)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/TileController.mm	2014-02-21 04:53:48 UTC (rev 164466)
@@ -319,7 +319,6 @@
 
 FloatRect TileController::scaledExposedRect() const
 {
-// Since the exposedRect is in FrameView-relative coordinates, we need to scale into document space.
 FloatRect scaledExposedRect = m_exposedRect;
 scaledExposedRect.scale(1 / m_scale);
 return scaledExposedRect;


Modified: trunk/Source/WebKit2/ChangeLog (164465 => 164466)

--- trunk/Source/WebKit2/ChangeLog	2014-02-21 04:04:23 UTC (rev 164465)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-21 04:53:48 UTC (rev 164466)
@@ -1,3 +1,60 @@
+2014-02-20  Benjamin Poulain  
+
+Start fixing the view states driven by

[webkit-changes] [164464] trunk/Source/WebKit2

2014-02-20 Thread timothy_horton

Title: [164464] trunk/Source/WebKit2








Revision 164464
Author timothy_hor...@apple.com
Date 2014-02-20 19:10:22 -0800 (Thu, 20 Feb 2014)


Log Message
Fix a build warning by moving some WKWebView methods from the private category to WKWebView itself.

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView setAllowsBackForwardNavigationGestures:]):
(-[WKWebView allowsBackForwardNavigationGestures]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164463 => 164464)

--- trunk/Source/WebKit2/ChangeLog	2014-02-21 02:53:14 UTC (rev 164463)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-21 03:10:22 UTC (rev 164464)
@@ -1,3 +1,13 @@
+2014-02-20  Tim Horton  
+
+Fix a build warning by moving some WKWebView methods from the private category to WKWebView itself.
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView setAllowsBackForwardNavigationGestures:]):
+(-[WKWebView allowsBackForwardNavigationGestures]):
+
 2014-02-20  Enrica Casucci  
 
 ASSERT on touches callbacks after r164409 on iOS.


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (164463 => 164464)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-21 02:53:14 UTC (rev 164463)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-21 03:10:22 UTC (rev 164464)
@@ -88,6 +88,7 @@
 CGFloat _lastAdjustmentForScroller;
 
 std::unique_ptr _gestureController;
+BOOL _allowsBackForwardNavigationGestures;
 #endif
 #if PLATFORM(MAC)
 RetainPtr _wkView;
@@ -446,7 +447,29 @@
 [self _keyboardChangedWithInfo:notification.userInfo adjustScrollView:YES];
 }
 
+- (void)setAllowsBackForwardNavigationGestures:(BOOL)allowsBackForwardNavigationGestures
+{
+if (_allowsBackForwardNavigationGestures == allowsBackForwardNavigationGestures)
+return;
 
+_allowsBackForwardNavigationGestures = allowsBackForwardNavigationGestures;
+
+if (allowsBackForwardNavigationGestures) {
+if (!_gestureController) {
+_gestureController = std::make_unique(*_page);
+_gestureController->installSwipeHandler(self, [self scrollView]);
+}
+} else
+_gestureController = nullptr;
+
+_page->setShouldRecordNavigationSnapshots(allowsBackForwardNavigationGestures);
+}
+
+- (BOOL)allowsBackForwardNavigationGestures
+{
+return _allowsBackForwardNavigationGestures;
+}
+
 #endif
 
 #pragma mark OS X-specific methods
@@ -682,29 +705,6 @@
 _isChangingObscuredInsetsInteractively = NO;
 }
 
-- (void)setAllowsBackForwardNavigationGestures:(BOOL)allowsBackForwardNavigationGestures
-{
-if (_allowsBackForwardNavigationGestures == allowsBackForwardNavigationGestures)
-return;
-
-_allowsBackForwardNavigationGestures = allowsBackForwardNavigationGestures;
-
-if (allowsBackForwardNavigationGestures) {
-if (!_gestureController) {
-_gestureController = std::make_unique(*_page);
-_gestureController->installSwipeHandler(self, [self scrollView]);
-}
-} else
-_gestureController = nullptr;
-
-_page->setShouldRecordNavigationSnapshots(allowsBackForwardNavigationGestures);
-}
-
-- (BOOL)allowsBackForwardNavigationGestures
-{
-return _allowsBackForwardNavigationGestures;
-}
-
 #endif
 
 @end






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164463] trunk/Source/JavaScriptCore

2014-02-20 Thread mark . lam

Title: [164463] trunk/Source/_javascript_Core








Revision 164463
Author mark@apple.com
Date 2014-02-20 18:53:14 -0800 (Thu, 20 Feb 2014)


Log Message
DefaultGCActivityCallback::doWork() should reschedule if GC is deferred.


Reviewed by Mark Hahnenberg.

Currently, DefaultGCActivityCallback::doWork() does not check if the GC
needs to be deferred before commencing. As a result, the GC may crash
and/or corrupt data because the VM is not in the consistent state needed
for the GC to run. With this fix, doWork() now checks if the GC is
supposed to be deferred and re-schedules if needed. It only commences
with GC'ing when it's safe to do so.

* runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::doWork):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/GCActivityCallback.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164462 => 164463)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-21 02:13:49 UTC (rev 164462)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-21 02:53:14 UTC (rev 164463)
@@ -1,3 +1,20 @@
+2014-02-20  Mark Lam  
+
+DefaultGCActivityCallback::doWork() should reschedule if GC is deferred.
+
+
+Reviewed by Mark Hahnenberg.
+
+Currently, DefaultGCActivityCallback::doWork() does not check if the GC
+needs to be deferred before commencing. As a result, the GC may crash
+and/or corrupt data because the VM is not in the consistent state needed
+for the GC to run. With this fix, doWork() now checks if the GC is
+supposed to be deferred and re-schedules if needed. It only commences
+with GC'ing when it's safe to do so.
+
+* runtime/GCActivityCallback.cpp:
+(JSC::DefaultGCActivityCallback::doWork):
+
 2014-02-20  Geoffrey Garen  
 
 Math.imul gives wrong results


Modified: trunk/Source/_javascript_Core/runtime/GCActivityCallback.cpp (164462 => 164463)

--- trunk/Source/_javascript_Core/runtime/GCActivityCallback.cpp	2014-02-21 02:13:49 UTC (rev 164462)
+++ trunk/Source/_javascript_Core/runtime/GCActivityCallback.cpp	2014-02-21 02:53:14 UTC (rev 164463)
@@ -87,6 +87,11 @@
 return;
 
 APIEntryShim shim(m_vm);
+if (heap->isDeferred()) {
+scheduleTimer(0);
+return;
+}
+
 #if !PLATFORM(IOS)
 double startTime = WTF::monotonicallyIncreasingTime();
 if (heap->isPagedOut(startTime + pagingTimeOut)) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164462] trunk/Source/WebKit2

2014-02-20 Thread enrica

Title: [164462] trunk/Source/WebKit2








Revision 164462
Author enr...@apple.com
Date 2014-02-20 18:13:49 -0800 (Thu, 20 Feb 2014)


Log Message
ASSERT on touches callbacks after r164409 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=129135

Reviewed by Alexey Proskuryakov.

The change used incorrecly true and false in TouchesCallbacks and
ImageCallback. It also reintroduced isMainThread() which doesn't work
for iOS.

* UIProcess/GenericCallback.h:
(WebKit::CallbackBase::generateCallbackID):
(WebKit::ImageCallback::performCallbackWithReturnValue):
(WebKit::ImageCallback::invalidate):
* UIProcess/WebPageProxy.h:
(WebKit::TouchesCallback::performCallbackWithReturnValue):
(WebKit::TouchesCallback::invalidate):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/GenericCallback.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164461 => 164462)

--- trunk/Source/WebKit2/ChangeLog	2014-02-21 02:01:28 UTC (rev 164461)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-21 02:13:49 UTC (rev 164462)
@@ -1,3 +1,22 @@
+2014-02-20  Enrica Casucci  
+
+ASSERT on touches callbacks after r164409 on iOS.
+https://bugs.webkit.org/show_bug.cgi?id=129135
+
+Reviewed by Alexey Proskuryakov.
+
+The change used incorrecly true and false in TouchesCallbacks and
+ImageCallback. It also reintroduced isMainThread() which doesn't work
+for iOS.
+
+* UIProcess/GenericCallback.h:
+(WebKit::CallbackBase::generateCallbackID):
+(WebKit::ImageCallback::performCallbackWithReturnValue):
+(WebKit::ImageCallback::invalidate):
+* UIProcess/WebPageProxy.h:
+(WebKit::TouchesCallback::performCallbackWithReturnValue):
+(WebKit::TouchesCallback::invalidate):
+
 2014-02-20  Anders Carlsson  
 
 We need something like WKPageUIClient in the Obj-C API


Modified: trunk/Source/WebKit2/UIProcess/GenericCallback.h (164461 => 164462)

--- trunk/Source/WebKit2/UIProcess/GenericCallback.h	2014-02-21 02:01:28 UTC (rev 164461)
+++ trunk/Source/WebKit2/UIProcess/GenericCallback.h	2014-02-21 02:13:49 UTC (rev 164462)
@@ -31,9 +31,9 @@
 #include "WKAPICast.h"
 #include 
 #include 
-#include 
 #include 
 #include 
+#include 
 
 namespace WebKit {
 
@@ -54,7 +54,7 @@
 private:
 static uint64_t generateCallbackID()
 {
-ASSERT(isMainThread());
+ASSERT(RunLoop::isMain());
 static uint64_t uniqueCallbackID = 1;
 return uniqueCallbackID++;
 }
@@ -235,7 +235,7 @@
 {
 ASSERT(m_callback);
 
-m_callback(true, returnValue1);
+m_callback(false, returnValue1);
 
 m_callback = 0;
 }
@@ -246,7 +246,7 @@
 
 RefPtr error = API::Error::create();
 ShareableBitmap::Handle handle;
-m_callback(false, handle);
+m_callback(true, handle);
 
 m_callback = 0;
 }


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (164461 => 164462)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2014-02-21 02:01:28 UTC (rev 164461)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2014-02-21 02:13:49 UTC (rev 164462)
@@ -289,7 +289,7 @@
 {
 ASSERT(m_callback);
 
-m_callback(true, returnValue1, returnValue2);
+m_callback(false, returnValue1, returnValue2);
 
 m_callback = 0;
 }
@@ -299,7 +299,7 @@
 ASSERT(m_callback);
 
 RefPtr error = API::Error::create();
-m_callback(false, WebCore::IntPoint(), 0);
+m_callback(true, WebCore::IntPoint(), 0);
 
 m_callback = 0;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164461] trunk

2014-02-20 Thread ggaren

Title: [164461] trunk








Revision 164461
Author gga...@apple.com
Date 2014-02-20 18:01:28 -0800 (Thu, 20 Feb 2014)


Log Message
Math.imul gives wrong results
https://bugs.webkit.org/show_bug.cgi?id=126345

Reviewed by Mark Hahnenberg.

Source/_javascript_Core: 

Don't truncate non-int doubles to 0 -- that's just not how ToInt32 works.
Instead, take a slow path that will do the right thing.

* jit/ThunkGenerators.cpp:
(JSC::imulThunkGenerator):

LayoutTests: 

Test this edge case of a double just outside the int range.

* js/dom/imul-expected.txt:
* js/dom/script-tests/imul.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/imul-expected.txt
trunk/LayoutTests/js/dom/script-tests/imul.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (164460 => 164461)

--- trunk/LayoutTests/ChangeLog	2014-02-21 01:50:03 UTC (rev 164460)
+++ trunk/LayoutTests/ChangeLog	2014-02-21 02:01:28 UTC (rev 164461)
@@ -1,3 +1,15 @@
+2014-02-20  Geoffrey Garen  
+
+Math.imul gives wrong results
+https://bugs.webkit.org/show_bug.cgi?id=126345
+
+Reviewed by Mark Hahnenberg.
+
+Test this edge case of a double just outside the int range.
+
+* js/dom/imul-expected.txt:
+* js/dom/script-tests/imul.js:
+
 2014-02-20  Brady Eidson  
 
 Add very basic image control rendering


Modified: trunk/LayoutTests/js/dom/imul-expected.txt (164460 => 164461)

--- trunk/LayoutTests/js/dom/imul-expected.txt	2014-02-21 01:50:03 UTC (rev 164460)
+++ trunk/LayoutTests/js/dom/imul-expected.txt	2014-02-21 02:01:28 UTC (rev 164461)
@@ -21,6 +21,7 @@
 PASS Math.imul(Infinity, -Infinity) is 0
 PASS Math.imul(-Infinity, Infinity) is 0
 PASS Math.imul(-Infinity, -Infinity) is 0
+PASS Math.imul(0x, 5) is -5
 PASS testIMul(2,2,1) is 4
 PASS testIMul(2.5,2,1) is 4
 PASS testIMul(2,2.5,1) is 4


Modified: trunk/LayoutTests/js/dom/script-tests/imul.js (164460 => 164461)

--- trunk/LayoutTests/js/dom/script-tests/imul.js	2014-02-21 01:50:03 UTC (rev 164460)
+++ trunk/LayoutTests/js/dom/script-tests/imul.js	2014-02-21 02:01:28 UTC (rev 164461)
@@ -20,6 +20,7 @@
 shouldBe("Math.imul(Infinity, -Infinity)", "0");
 shouldBe("Math.imul(-Infinity, Infinity)", "0");
 shouldBe("Math.imul(-Infinity, -Infinity)", "0");
+shouldBe("Math.imul(0x, 5)", "-5");
 
 function testIMul(left, right, count)
 {


Modified: trunk/Source/_javascript_Core/ChangeLog (164460 => 164461)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-21 01:50:03 UTC (rev 164460)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-21 02:01:28 UTC (rev 164461)
@@ -1,3 +1,16 @@
+2014-02-20  Geoffrey Garen  
+
+Math.imul gives wrong results
+https://bugs.webkit.org/show_bug.cgi?id=126345
+
+Reviewed by Mark Hahnenberg.
+
+Don't truncate non-int doubles to 0 -- that's just not how ToInt32 works.
+Instead, take a slow path that will do the right thing.
+
+* jit/ThunkGenerators.cpp:
+(JSC::imulThunkGenerator):
+
 2014-02-20  Filip Pizlo  
 
 DFG should do its own static estimates of execution frequency before it starts creating OSR entrypoints


Modified: trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp (164460 => 164461)

--- trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp	2014-02-21 01:50:03 UTC (rev 164460)
+++ trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp	2014-02-21 02:01:28 UTC (rev 164461)
@@ -924,8 +924,7 @@
 nonIntArg0Jump.link(&jit);
 jit.loadDoubleArgument(0, SpecializedThunkJIT::fpRegT0, SpecializedThunkJIT::regT0);
 jit.branchTruncateDoubleToInt32(SpecializedThunkJIT::fpRegT0, SpecializedThunkJIT::regT0, SpecializedThunkJIT::BranchIfTruncateSuccessful).linkTo(doneLoadingArg0, &jit);
-jit.xor32(SpecializedThunkJIT::regT0, SpecializedThunkJIT::regT0);
-jit.jump(doneLoadingArg0);
+jit.appendFailure(jit.jump());
 } else
 jit.appendFailure(nonIntArg0Jump);
 
@@ -933,8 +932,7 @@
 nonIntArg1Jump.link(&jit);
 jit.loadDoubleArgument(1, SpecializedThunkJIT::fpRegT0, SpecializedThunkJIT::regT1);
 jit.branchTruncateDoubleToInt32(SpecializedThunkJIT::fpRegT0, SpecializedThunkJIT::regT1, SpecializedThunkJIT::BranchIfTruncateSuccessful).linkTo(doneLoadingArg1, &jit);
-jit.xor32(SpecializedThunkJIT::regT1, SpecializedThunkJIT::regT1);
-jit.jump(doneLoadingArg1);
+jit.appendFailure(jit.jump());
 } else
 jit.appendFailure(nonIntArg1Jump);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164460] trunk/Source/WebKit2

2014-02-20 Thread andersca

Title: [164460] trunk/Source/WebKit2








Revision 164460
Author ander...@apple.com
Date 2014-02-20 17:50:03 -0800 (Thu, 20 Feb 2014)


Log Message
We need something like WKPageUIClient in the Obj-C API
https://bugs.webkit.org/show_bug.cgi?id=129123


Reviewed by Sam Weinig.

* UIProcess/API/APIUIClient.h:
* UIProcess/API/Cocoa/WKUIDelegate.h: Added.
* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView UIDelegate]):
(-[WKWebView setUIDelegate:]):
* UIProcess/Cocoa/UIClient.h: Added.
* UIProcess/Cocoa/UIClient.mm: Added.
(WebKit::UIClient::UIClient):
(WebKit::UIClient::~UIClient):
(WebKit::UIClient::delegate):
(WebKit::UIClient::setDelegate):
(WebKit::UIClient::runJavaScriptAlert):
(WebKit::UIClient::runJavaScriptConfirm):
(WebKit::UIClient::runJavaScriptPrompt):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::uiClient):
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APIUIClient.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h
trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.h
trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164459 => 164460)

--- trunk/Source/WebKit2/ChangeLog	2014-02-21 01:20:48 UTC (rev 164459)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-21 01:50:03 UTC (rev 164460)
@@ -1,3 +1,31 @@
+2014-02-20  Anders Carlsson  
+
+We need something like WKPageUIClient in the Obj-C API
+https://bugs.webkit.org/show_bug.cgi?id=129123
+
+
+Reviewed by Sam Weinig.
+
+* UIProcess/API/APIUIClient.h:
+* UIProcess/API/Cocoa/WKUIDelegate.h: Added.
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView initWithFrame:configuration:]):
+(-[WKWebView UIDelegate]):
+(-[WKWebView setUIDelegate:]):
+* UIProcess/Cocoa/UIClient.h: Added.
+* UIProcess/Cocoa/UIClient.mm: Added.
+(WebKit::UIClient::UIClient):
+(WebKit::UIClient::~UIClient):
+(WebKit::UIClient::delegate):
+(WebKit::UIClient::setDelegate):
+(WebKit::UIClient::runJavaScriptAlert):
+(WebKit::UIClient::runJavaScriptConfirm):
+(WebKit::UIClient::runJavaScriptPrompt):
+* UIProcess/WebPageProxy.h:
+(WebKit::WebPageProxy::uiClient):
+* WebKit2.xcodeproj/project.pbxproj:
+
 2014-02-20  Brady Eidson  
 
 Add very basic image control rendering


Modified: trunk/Source/WebKit2/UIProcess/API/APIUIClient.h (164459 => 164460)

--- trunk/Source/WebKit2/UIProcess/API/APIUIClient.h	2014-02-21 01:20:48 UTC (rev 164459)
+++ trunk/Source/WebKit2/UIProcess/API/APIUIClient.h	2014-02-21 01:50:03 UTC (rev 164460)
@@ -29,6 +29,7 @@
 #include "WKPage.h"
 #include "WebEvent.h"
 #include "WebHitTestResult.h"
+#include "WebPageProxy.h"
 #include 
 #include 
 #include 


Added: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h (0 => 164460)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h	2014-02-21 01:50:03 UTC (rev 164460)
@@ -0,0 +1,45 @@
+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import 
+#import 
+
+#if WK_API_ENABLED
+
+@class WKFrameInfo;
+
+@protocol WKUIDelegate 
+
+@optional
+
+- (void)webView:(WKWebView *)web

[webkit-changes] [164459] trunk/Source/JavaScriptCore

2014-02-20 Thread fpizlo

Title: [164459] trunk/Source/_javascript_Core








Revision 164459
Author fpi...@apple.com
Date 2014-02-20 17:20:48 -0800 (Thu, 20 Feb 2014)


Log Message
DFG should do its own static estimates of execution frequency before it starts creating OSR entrypoints
https://bugs.webkit.org/show_bug.cgi?id=129129

Reviewed by Geoffrey Garen.

We estimate execution counts based on loop depth, and then use those to estimate branch
weights. These weights then get carried all the way down to LLVM prof branch_weights
meta-data.

This is better than letting LLVM do its own static estimates, since by the time we
generate LLVM IR, we may have messed up the CFG due to OSR entrypoint creation. Of
course, it would be even better if we just slurped in some kind of execution counts
from profiling, but we don't do that, yet.

* CMakeLists.txt:
* GNUmakefile.list.am:
* _javascript_Core.vcxproj/_javascript_Core.vcxproj:
* _javascript_Core.xcodeproj/project.pbxproj:
* dfg/DFGBasicBlock.cpp:
(JSC::DFG::BasicBlock::BasicBlock):
* dfg/DFGBasicBlock.h:
* dfg/DFGBlockInsertionSet.cpp:
(JSC::DFG::BlockInsertionSet::insert):
(JSC::DFG::BlockInsertionSet::insertBefore):
* dfg/DFGBlockInsertionSet.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGCriticalEdgeBreakingPhase.cpp:
(JSC::DFG::CriticalEdgeBreakingPhase::breakCriticalEdge):
* dfg/DFGLoopPreHeaderCreationPhase.cpp:
(JSC::DFG::createPreHeader):
* dfg/DFGNaturalLoops.h:
(JSC::DFG::NaturalLoops::loopDepth):
* dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* dfg/DFGStaticExecutionCountEstimationPhase.cpp: Added.
(JSC::DFG::StaticExecutionCountEstimationPhase::StaticExecutionCountEstimationPhase):
(JSC::DFG::StaticExecutionCountEstimationPhase::run):
(JSC::DFG::StaticExecutionCountEstimationPhase::applyCounts):
(JSC::DFG::performStaticExecutionCountEstimation):
* dfg/DFGStaticExecutionCountEstimationPhase.h: Added.

Modified Paths

trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/dfg/DFGBasicBlock.cpp
trunk/Source/_javascript_Core/dfg/DFGBasicBlock.h
trunk/Source/_javascript_Core/dfg/DFGBlockInsertionSet.cpp
trunk/Source/_javascript_Core/dfg/DFGBlockInsertionSet.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGCriticalEdgeBreakingPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGLoopPreHeaderCreationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGNaturalLoops.h
trunk/Source/_javascript_Core/dfg/DFGOSREntrypointCreationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGPlan.cpp


Added Paths

trunk/Source/_javascript_Core/dfg/DFGStaticExecutionCountEstimationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGStaticExecutionCountEstimationPhase.h




Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (164458 => 164459)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2014-02-21 01:14:35 UTC (rev 164458)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2014-02-21 01:20:48 UTC (rev 164459)
@@ -184,6 +184,7 @@
 dfg/DFGSpeculativeJIT32_64.cpp
 dfg/DFGSpeculativeJIT64.cpp
 dfg/DFGStackLayoutPhase.cpp
+dfg/DFGStaticExecutionCountEstimationPhase.cpp
 dfg/DFGStoreBarrierElisionPhase.cpp
 dfg/DFGStrengthReductionPhase.cpp
 dfg/DFGThreadData.cpp


Modified: trunk/Source/_javascript_Core/ChangeLog (164458 => 164459)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-21 01:14:35 UTC (rev 164458)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-21 01:20:48 UTC (rev 164459)
@@ -1,5 +1,52 @@
 2014-02-20  Filip Pizlo  
 
+DFG should do its own static estimates of execution frequency before it starts creating OSR entrypoints
+https://bugs.webkit.org/show_bug.cgi?id=129129
+
+Reviewed by Geoffrey Garen.
+
+We estimate execution counts based on loop depth, and then use those to estimate branch
+weights. These weights then get carried all the way down to LLVM prof branch_weights
+meta-data.
+
+This is better than letting LLVM do its own static estimates, since by the time we
+generate LLVM IR, we may have messed up the CFG due to OSR entrypoint creation. Of
+course, it would be even better if we just slurped in some kind of execution counts
+from profiling, but we don't do that, yet.
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* _javascript_Core.vcxproj/_javascript_Core.vcxproj:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* dfg/DFGBasicBlock.cpp:
+(JSC::DFG::BasicBlock::BasicBlock):
+* dfg/DFGBasicBlock.h:
+* dfg/DF

[webkit-changes] [164458] trunk/Source/WebCore

2014-02-20 Thread beidson

Title: [164458] trunk/Source/WebCore








Revision 164458
Author beid...@apple.com
Date 2014-02-20 17:14:35 -0800 (Thu, 20 Feb 2014)


Log Message
Move the image controls setting to Settings.in
https://bugs.webkit.org/show_bug.cgi?id=129126

Reviewed by Tim Horton.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* page/Settings.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/page/Settings.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (164457 => 164458)

--- trunk/Source/WebCore/ChangeLog	2014-02-21 00:39:35 UTC (rev 164457)
+++ trunk/Source/WebCore/ChangeLog	2014-02-21 01:14:35 UTC (rev 164458)
@@ -1,5 +1,17 @@
 2014-02-20  Brady Eidson  
 
+Move the image controls setting to Settings.in
+https://bugs.webkit.org/show_bug.cgi?id=129126
+
+Reviewed by Tim Horton.
+
+* page/Settings.cpp:
+(WebCore::Settings::Settings):
+* page/Settings.h:
+* page/Settings.in:
+
+2014-02-20  Brady Eidson  
+
 Add very basic image control rendering
 https://bugs.webkit.org/show_bug.cgi?id=129080
 


Modified: trunk/Source/WebCore/page/Settings.cpp (164457 => 164458)

--- trunk/Source/WebCore/page/Settings.cpp	2014-02-21 00:39:35 UTC (rev 164457)
+++ trunk/Source/WebCore/page/Settings.cpp	2014-02-21 01:14:35 UTC (rev 164458)
@@ -186,9 +186,6 @@
 #endif
 , m_scrollingPerformanceLoggingEnabled(false)
 , m_aggressiveTileRetentionEnabled(false)
-#if ENABLE(IMAGE_CONTROLS)
-, m_imageControlsEnabled(false)
-#endif
 , m_timeWithoutMouseMovementBeforeHidingControls(3)
 , m_setImageLoadingSettingsTimer(this, &Settings::imageLoadingSettingsTimerFired)
 #if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
@@ -638,13 +635,6 @@
 m_aggressiveTileRetentionEnabled = enabled;
 }
 
-#if ENABLE(IMAGE_CONTROLS)
-void Settings::setImageControlsEnabled(bool enabled)
-{
-m_imageControlsEnabled = enabled;
-}
-#endif
-
 void Settings::setMockScrollbarsEnabled(bool flag)
 {
 gMockScrollbarsEnabled = flag;


Modified: trunk/Source/WebCore/page/Settings.h (164457 => 164458)

--- trunk/Source/WebCore/page/Settings.h	2014-02-21 00:39:35 UTC (rev 164457)
+++ trunk/Source/WebCore/page/Settings.h	2014-02-21 01:14:35 UTC (rev 164458)
@@ -237,11 +237,6 @@
 void setAggressiveTileRetentionEnabled(bool);
 bool aggressiveTileRetentionEnabled() { return m_aggressiveTileRetentionEnabled; }
 
-#if ENABLE(IMAGE_CONTROLS)
-void setImageControlsEnabled(bool);
-bool imageControlsEnabled() { return m_imageControlsEnabled; }
-#endif
-
 static void setShouldRespectPriorityInCSSAttributeSetters(bool);
 static bool shouldRespectPriorityInCSSAttributeSetters();
 
@@ -320,9 +315,6 @@
 #endif
 bool m_scrollingPerformanceLoggingEnabled : 1;
 bool m_aggressiveTileRetentionEnabled : 1;
-#if ENABLE(IMAGE_CONTROLS)
-bool m_imageControlsEnabled : 1;
-#endif
 
 double m_timeWithoutMouseMovementBeforeHidingControls;
 


Modified: trunk/Source/WebCore/page/Settings.in (164457 => 164458)

--- trunk/Source/WebCore/page/Settings.in	2014-02-21 00:39:35 UTC (rev 164457)
+++ trunk/Source/WebCore/page/Settings.in	2014-02-21 01:14:35 UTC (rev 164458)
@@ -214,6 +214,7 @@
 shouldTransformsAffectOverflow initial=true
 shouldDispatchJavaScriptWindowOnErrorEvents initial=false
 alwaysUseAcceleratedOverflowScroll initial=false
+imageControlsEnabled initial=false, conditional=IMAGE_CONTROLS
 
 # FIXME: This is unneeded and should be removed.
 alwaysUseBaselineOfPrimaryFont initial=false






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164456] trunk/Source/JavaScriptCore

2014-02-20 Thread fpizlo

Title: [164456] trunk/Source/_javascript_Core








Revision 164456
Author fpi...@apple.com
Date 2014-02-20 16:00:12 -0800 (Thu, 20 Feb 2014)


Log Message
FTL may not see a compact_unwind section if there weren't any stackmaps
https://bugs.webkit.org/show_bug.cgi?id=129125

Reviewed by Geoffrey Garen.

It's OK to not have an unwind section, so long as the function also doesn't have any
OSR exits.

* ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
(JSC::FTL::compile):
* ftl/FTLUnwindInfo.cpp:
(JSC::FTL::UnwindInfo::parse):
* ftl/FTLUnwindInfo.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLCompile.cpp
trunk/Source/_javascript_Core/ftl/FTLUnwindInfo.cpp
trunk/Source/_javascript_Core/ftl/FTLUnwindInfo.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164455 => 164456)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-20 23:46:18 UTC (rev 164455)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-21 00:00:12 UTC (rev 164456)
@@ -1 +1,18 @@
+2014-02-20  Filip Pizlo  
+
+FTL may not see a compact_unwind section if there weren't any stackmaps
+https://bugs.webkit.org/show_bug.cgi?id=129125
+
+Reviewed by Geoffrey Garen.
+
+It's OK to not have an unwind section, so long as the function also doesn't have any
+OSR exits.
+
+* ftl/FTLCompile.cpp:
+(JSC::FTL::fixFunctionBasedOnStackMaps):
+(JSC::FTL::compile):
+* ftl/FTLUnwindInfo.cpp:
+(JSC::FTL::UnwindInfo::parse):
+* ftl/FTLUnwindInfo.h:
+
 == Rolled over to ChangeLog-2014-02-20 ==


Modified: trunk/Source/_javascript_Core/ftl/FTLCompile.cpp (164455 => 164456)

--- trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2014-02-20 23:46:18 UTC (rev 164455)
+++ trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2014-02-21 00:00:12 UTC (rev 164456)
@@ -164,7 +164,7 @@
 
 static void fixFunctionBasedOnStackMaps(
 State& state, CodeBlock* codeBlock, JITCode* jitCode, GeneratedFunction generatedFunction,
-StackMaps::RecordMap& recordMap)
+StackMaps::RecordMap& recordMap, bool didSeeUnwindInfo)
 {
 Graph& graph = state.graph;
 VM& vm = graph.m_vm;
@@ -236,10 +236,13 @@
 ExitThunkGenerator exitThunkGenerator(state);
 exitThunkGenerator.emitThunks();
 if (exitThunkGenerator.didThings()) {
+RELEASE_ASSERT(state.finalizer->osrExit.size());
+RELEASE_ASSERT(didSeeUnwindInfo);
+
 OwnPtr linkBuffer = adoptPtr(new LinkBuffer(
 vm, &exitThunkGenerator, codeBlock, JITCompilationMustSucceed));
 
-ASSERT(state.finalizer->osrExit.size() == state.jitCode->osrExit.size());
+RELEASE_ASSERT(state.finalizer->osrExit.size() == state.jitCode->osrExit.size());
 
 for (unsigned i = 0; i < state.jitCode->osrExit.size(); ++i) {
 OSRExitCompilationInfo& info = state.finalizer->osrExit[i];
@@ -573,10 +576,15 @@
 }
 }
 
-state.jitCode->unwindInfo.parse(
+bool didSeeUnwindInfo = state.jitCode->unwindInfo.parse(
 state.compactUnwind, state.compactUnwindSize, state.generatedFunction);
-if (shouldShowDisassembly())
-dataLog("Unwind info for ", CodeBlockWithJITType(state.graph.m_codeBlock, JITCode::FTLJIT), ":\n", state.jitCode->unwindInfo, "\n");
+if (shouldShowDisassembly()) {
+dataLog("Unwind info for ", CodeBlockWithJITType(state.graph.m_codeBlock, JITCode::FTLJIT), ":\n");
+if (didSeeUnwindInfo)
+dataLog("", state.jitCode->unwindInfo, "\n");
+else
+dataLog("\n");
+}
 
 if (state.stackmapsSection && state.stackmapsSection->size()) {
 if (shouldShowDisassembly()) {
@@ -599,7 +607,7 @@
 StackMaps::RecordMap recordMap = state.jitCode->stackmaps.computeRecordMap();
 fixFunctionBasedOnStackMaps(
 state, state.graph.m_codeBlock, state.jitCode.get(), state.generatedFunction,
-recordMap);
+recordMap, didSeeUnwindInfo);
 
 if (shouldShowDisassembly()) {
 for (unsigned i = 0; i < state.jitCode->handles().size(); ++i) {


Modified: trunk/Source/_javascript_Core/ftl/FTLUnwindInfo.cpp (164455 => 164456)

--- trunk/Source/_javascript_Core/ftl/FTLUnwindInfo.cpp	2014-02-20 23:46:18 UTC (rev 164455)
+++ trunk/Source/_javascript_Core/ftl/FTLUnwindInfo.cpp	2014-02-21 00:00:12 UTC (rev 164456)
@@ -48,11 +48,14 @@
 
 } // anonymous namespace
 
-void UnwindInfo::parse(void* section, size_t size, GeneratedFunction generatedFunction)
+bool UnwindInfo::parse(void* section, size_t size, GeneratedFunction generatedFunction)
 {
 m_registers.clear();
 
-RELEASE_ASSERT(section);
+RELEASE_ASSERT(!!section == !!size);
+if (!section)
+return false;
+
 RELEASE_ASSERT(size >= sizeof(CompactUnwind));
 
 CompactUnwind* data = ""
@@ -156,6 +159,7 @@
 #endif
 
 std::sort(m_registers.

[webkit-changes] [164455] trunk/Source/WebKit2

2014-02-20 Thread timothy_horton

Title: [164455] trunk/Source/WebKit2








Revision 164455
Author timothy_hor...@apple.com
Date 2014-02-20 15:46:18 -0800 (Thu, 20 Feb 2014)


Log Message
Add magnification and swiping properties to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=129117

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKViewPrivate.h:
Move allowsBackForwardNavigationGestures out of a Mac-only block.

* UIProcess/API/Cocoa/WKWebView.h:
Add allowsBackForwardNavigationGestures to WKWebView for both platforms.
Add magnification properties to WKWebView for Mac.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView contentView:didCommitLayerTree:WebKit::]):
(-[WKWebView setAllowsBackForwardNavigationGestures:]):
(-[WKWebView allowsBackForwardNavigationGestures]):
(-[WKWebView setAllowsMagnification:]):
(-[WKWebView allowsMagnification]):
(-[WKWebView setMagnification:]):
(-[WKWebView magnification]):
(-[WKWebView setMagnification:centeredAtPoint:]):
For iOS, copy implementations from WKViewIOS.
For Mac, forward to the inner WKView.

* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView setAllowsBackForwardNavigationGestures:]):
Fix the logic to tear down the ViewGestureController.

* UIProcess/API/mac/WKView.mm:
(-[WKView setMagnification:centeredAtPoint:]):
(-[WKView setMagnification:]):
(-[WKView magnification]):
Use CG types for API.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164454 => 164455)

--- trunk/Source/WebKit2/ChangeLog	2014-02-20 23:34:21 UTC (rev 164454)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-20 23:46:18 UTC (rev 164455)
@@ -1 +1,37 @@
+2014-02-20  Tim Horton  
+
+Add magnification and swiping properties to WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=129117
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/Cocoa/WKViewPrivate.h:
+Move allowsBackForwardNavigationGestures out of a Mac-only block.
+
+* UIProcess/API/Cocoa/WKWebView.h:
+Add allowsBackForwardNavigationGestures to WKWebView for both platforms.
+Add magnification properties to WKWebView for Mac.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView contentView:didCommitLayerTree:WebKit::]):
+(-[WKWebView setAllowsBackForwardNavigationGestures:]):
+(-[WKWebView allowsBackForwardNavigationGestures]):
+(-[WKWebView setAllowsMagnification:]):
+(-[WKWebView allowsMagnification]):
+(-[WKWebView setMagnification:]):
+(-[WKWebView magnification]):
+(-[WKWebView setMagnification:centeredAtPoint:]):
+For iOS, copy implementations from WKViewIOS.
+For Mac, forward to the inner WKView.
+
+* UIProcess/API/ios/WKViewIOS.mm:
+(-[WKView setAllowsBackForwardNavigationGestures:]):
+Fix the logic to tear down the ViewGestureController.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView setMagnification:centeredAtPoint:]):
+(-[WKView setMagnification:]):
+(-[WKView magnification]):
+Use CG types for API.
+
 == Rolled over to ChangeLog-2014-02-20 ==


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h (164454 => 164455)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h	2014-02-20 23:34:21 UTC (rev 164454)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h	2014-02-20 23:46:18 UTC (rev 164455)
@@ -117,8 +117,15 @@
 - (void)goBack;
 - (void)goForward;
 
+@property (nonatomic) BOOL allowsBackForwardNavigationGestures;
+
 #if TARGET_OS_IPHONE
 @property (nonatomic, readonly) UIScrollView *scrollView;
+#else
+@property (nonatomic) BOOL allowsMagnification;
+@property (nonatomic) CGFloat magnification;
+
+- (void)setMagnification:(CGFloat)magnification centeredAtPoint:(CGPoint)point;
 #endif
 
 @end


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (164454 => 164455)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-20 23:34:21 UTC (rev 164454)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-20 23:46:18 UTC (rev 164455)
@@ -32,6 +32,7 @@
 #import "RemoteLayerTreeTransaction.h"
 #import "RemoteObjectRegistry.h"
 #import "RemoteObjectRegistryMessages.h"
+#import "ViewGestureController.h"
 #import "WKBackForwardListInternal.h"
 #import "WKBackForwardListItemInternal.h"
 #import "WKBrowsingContextHandleInternal.h"
@@ -83,6 +84,8 @@
 UIEdgeInsets _obscuredInsets;
 bool _isChangingObscuredInsetsInteractively;
 CGFloat _lastAdjustmentForScroller;
+
+std::unique_ptr _gestureController;
 #endif
 #if PLATFORM(MAC)
 RetainPtr _wkView;
@@ -307,6 +310,9 @@
 if (![_scrollView isZooming] && ![_scrollView isZoomBouncing])
 [_scrollView setZoomScale:layerTreeTransaction.pageScaleFactor()];
 
+if (_gestureController)
+_gestureController->setRenderTreeSize(layerTr

[webkit-changes] [164451] trunk

2014-02-20 Thread dino

Title: [164451] trunk








Revision 164451
Author d...@apple.com
Date 2014-02-20 15:11:52 -0800 (Thu, 20 Feb 2014)


Log Message
Add an unresolved WebGLPolicy and an API to resolve it
https://bugs.webkit.org/show_bug.cgi?id=129109

Reviewed by Anders Carlsson.

Source/WebCore:

Add a third WebGLLoadPolicy which is "pending" allowing the page
to go ahead with creating the WebGLRenderingContext and resolve the policy
at a later time. Add a new API resolveWebGLLoadPolicy to do the resolution.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext): WebGLBlock -> WebGLBlockCreation
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::webGLPolicyForURL): WebGLAllow -> WebGLAllowCreation.
(WebCore::FrameLoaderClient::resolveWebGLPolicyForURL): New method.
* loader/FrameLoaderTypes.h: Add WebGLPendingCreation.

Source/WebKit2:

Add a third WebGLLoadPolicy which is "pending" allowing the page
to go ahead with creating the WebGLRenderingContext and resolve the policy
at a later time. Add a new API resolveWebGLLoadPolicy to do the resolution.

* UIProcess/API/APILoaderClient.h:
(API::LoaderClient::webGLLoadPolicy): New return value.
(API::LoaderClient::resolveWebGLLoadPolicy): New method definition.
* UIProcess/API/C/WKAPICast.h:
(WebKit::toWebGLLoadPolicy): Change names of return types.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient): New stubs.
* UIProcess/API/C/WKPageLoaderClient.h: New policy type kWKWebGLLoadPolicyPending.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resolveWebGLPolicyForURL): New method.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: New message.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::webGLPolicyForURL):
(WebKit::WebFrameLoaderClient::resolveWebGLPolicyForURL):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):
* WebProcess/WebPage/WebPage.h:

Tools:

Add a new entry for resolveWebGLLoadPolicy.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCanvasElement.cpp
trunk/Source/WebCore/loader/FrameLoaderClient.h
trunk/Source/WebCore/loader/FrameLoaderTypes.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APILoaderClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPageLoaderClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164450 => 164451)

--- trunk/Source/WebCore/ChangeLog	2014-02-20 23:04:31 UTC (rev 164450)
+++ trunk/Source/WebCore/ChangeLog	2014-02-20 23:11:52 UTC (rev 164451)
@@ -1,3 +1,21 @@
+2014-02-20  Dean Jackson  
+
+Add an unresolved WebGLPolicy and an API to resolve it
+https://bugs.webkit.org/show_bug.cgi?id=129109
+
+Reviewed by Anders Carlsson.
+
+Add a third WebGLLoadPolicy which is "pending" allowing the page
+to go ahead with creating the WebGLRenderingContext and resolve the policy
+at a later time. Add a new API resolveWebGLLoadPolicy to do the resolution.
+
+* html/HTMLCanvasElement.cpp:
+(WebCore::HTMLCanvasElement::getContext): WebGLBlock -> WebGLBlockCreation
+* loader/FrameLoaderClient.h:
+(WebCore::FrameLoaderClient::webGLPolicyForURL): WebGLAllow -> WebGLAllowCreation.
+(WebCore::FrameLoaderClient::resolveWebGLPolicyForURL): New method.
+* loader/FrameLoaderTypes.h: Add WebGLPendingCreation.
+
 2014-02-20  Zalan Bujtas  
 
 Subpixel rendering: Enable compositing RenderLayer painting on device pixel position.


Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (164450 => 164451)

--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp	2014-02-20 23:04:31 UTC (rev 164450)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp	2014-02-20 23:11:52 UTC (rev 164451)
@@ -226,7 +226,7 @@
 if (page && !topDocument.url().isLocalFile()) {
 WebGLLoadPolicy policy = page->mainFrame().loader().client().webGLPolicyForURL(topDocument.url());
 
-if (policy == WebGLBlock)
+if (policy == WebGLBlockCreation)
 return nullptr;
 }
 m_context = WebGLRenderingContext::create(this, static_cast(attrs));


Modified: trunk/Source/WebCore/loader/FrameLo

[webkit-changes] [164453] trunk/Source/WebKit2

2014-02-20 Thread bdakin

Title: [164453] trunk/Source/WebKit2








Revision 164453
Author bda...@apple.com
Date 2014-02-20 15:12:19 -0800 (Thu, 20 Feb 2014)


Log Message
WKPage's setBackgroundExtendsBeyondPage API should be exposed through WKView and 
WKWebView
https://bugs.webkit.org/show_bug.cgi?id=129120

Reviewed by Anders Carlsson.

While we’re in this code, fix up the pageExtendedBackgroundColor to match.
* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _pageExtendedBackgroundColor]):
(-[WKWebView _setBackgroundExtendsBeyondPage:]):
(-[WKWebView _backgroundExtendsBeyondPage]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _pageExtendedBackgroundColor]):
(-[WKView _setBackgroundExtendsBeyondPage:]):
(-[WKView _backgroundExtendsBeyondPage]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164452 => 164453)

--- trunk/Source/WebKit2/ChangeLog	2014-02-20 23:12:18 UTC (rev 164452)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-20 23:12:19 UTC (rev 164453)
@@ -1,3 +1,23 @@
+2014-02-20  Beth Dakin  
+
+WKPage's setBackgroundExtendsBeyondPage API should be exposed through WKView and 
+WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=129120
+
+Reviewed by Anders Carlsson.
+
+While we’re in this code, fix up the pageExtendedBackgroundColor to match.
+* UIProcess/API/Cocoa/WKViewPrivate.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _pageExtendedBackgroundColor]):
+(-[WKWebView _setBackgroundExtendsBeyondPage:]):
+(-[WKWebView _backgroundExtendsBeyondPage]):
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+* UIProcess/API/ios/WKViewIOS.mm:
+(-[WKView _pageExtendedBackgroundColor]):
+(-[WKView _setBackgroundExtendsBeyondPage:]):
+(-[WKView _backgroundExtendsBeyondPage]):
+
 2014-02-20  Dean Jackson  
 
 Add an unresolved WebGLPolicy and an API to resolve it


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h (164452 => 164453)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h	2014-02-20 23:12:18 UTC (rev 164452)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h	2014-02-20 23:12:19 UTC (rev 164453)
@@ -47,7 +47,8 @@
 // Define the inset of the scrollview unusable by the web page.
 @property (nonatomic, setter=_setObscuredInsets:) UIEdgeInsets _obscuredInsets;
 
-- (UIColor *)pageExtendedBackgroundColor;
+@property (nonatomic, setter=_setBackgroundExtendsBeyondPage:) BOOL _backgroundExtendsBeyondPage;
+@property (readonly) UIColor *_pageExtendedBackgroundColor;
 
 - (void)_beginInteractiveObscuredInsetsChange;
 - (void)_endInteractiveObscuredInsetsChange;


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (164452 => 164453)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-20 23:12:18 UTC (rev 164452)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-20 23:12:19 UTC (rev 164453)
@@ -596,7 +596,7 @@
 _obscuredInsets = obscuredInsets;
 }
 
-- (UIColor *)pageExtendedBackgroundColor
+- (UIColor *)_pageExtendedBackgroundColor
 {
 WebCore::Color color = _page->pageExtendedBackgroundColor();
 if (!color.isValid())
@@ -605,6 +605,16 @@
 return [UIColor colorWithRed:(color.red() / 255.0) green:(color.green() / 255.0) blue:(color.blue() / 255.0) alpha:(color.alpha() / 255.0)];
 }
 
+- (void)_setBackgroundExtendsBeyondPage:(BOOL)backgroundExtends
+{
+_page->setBackgroundExtendsBeyondPage(backgroundExtends);
+}
+
+- (BOOL)_backgroundExtendsBeyondPage
+{
+return _page->backgroundExtendsBeyondPage();
+}
+
 - (void)_beginInteractiveObscuredInsetsChange
 {
 ASSERT(!_isChangingObscuredInsetsInteractively);


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h (164452 => 164453)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h	2014-02-20 23:12:18 UTC (rev 164452)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h	2014-02-20 23:12:19 UTC (rev 164453)
@@ -69,7 +69,8 @@
 // Define the inset of the scrollview unusable by the web page.
 @property (nonatomic, setter=_setObscuredInsets:) UIEdgeInsets _obscuredInsets;
 
-- (UIColor *)pageExtendedBackgroundColor;
+@property (nonatomic, setter=_setBackgroundExtendsBeyondPage:) BOOL _backgroundExtendsBeyondPage;
+@property (readonly) UIColor *_pageExtendedBackgroundColor;
 
 - (void)_beginInteractiveObscuredInsetsChange;
 - (void)_endInteractiveObscuredInsetsChange;


Modified: trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm (164452 => 164453)

--- trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm	2014-02-20 23:12:18 UTC (rev 164452)
+++ trunk/Source/WebKit2/UIProcess/API/io

[webkit-changes] [164449] trunk

2014-02-20 Thread zalan

Title: [164449] trunk








Revision 164449
Author za...@apple.com
Date 2014-02-20 15:04:20 -0800 (Thu, 20 Feb 2014)


Log Message
Subpixel rendering: Enable compositing RenderLayer painting on device pixel position.
https://bugs.webkit.org/show_bug.cgi?id=128509

Reviewed by Simon Fraser.

GraphicsLayer is now positioned on device pixel boundary. This enables us to put
compositing layers on a subpixel position and animate them with device pixel
precision.

Source/WebCore:

Tests: fast/sub-pixel/compositing-layers-on-subpixel-position.html
   fast/sub-pixel/simple-clipping.html

* platform/LayoutUnit.h:
(WebCore::ceilToDevicePixel):
* platform/graphics/LayoutPoint.h:
(WebCore::flooredForPainting):
(WebCore::ceiledForPainting):
* platform/graphics/LayoutRect.cpp:
(WebCore::enclosingRectForPainting):
* platform/graphics/LayoutRect.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
* rendering/RenderLayerBacking.cpp:
(WebCore::clipBox):
(WebCore::pixelFractionForLayerPainting):
(WebCore::calculateDevicePixelOffsetFromRenderer):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintIntoLayer):
* rendering/RenderLayerBacking.h:

LayoutTests:

* TestExpectations:
* fast/sub-pixel/compositing-layers-on-subpixel-position-expected.html: Added.
* fast/sub-pixel/compositing-layers-on-subpixel-position.html: Added.
* fast/sub-pixel/simple-clipping-expected.html: Added.
* fast/sub-pixel/simple-clipping.html: Added.
* platform/mac/compositing/layer-creation/overlap-animation-container-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/mac/compositing/layer-creation/overlap-animation-container-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/LayoutUnit.h
trunk/Source/WebCore/platform/graphics/LayoutPoint.h
trunk/Source/WebCore/platform/graphics/LayoutRect.cpp
trunk/Source/WebCore/platform/graphics/LayoutRect.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h


Added Paths

trunk/LayoutTests/fast/sub-pixel/compositing-layers-on-subpixel-position-expected.html
trunk/LayoutTests/fast/sub-pixel/compositing-layers-on-subpixel-position.html
trunk/LayoutTests/fast/sub-pixel/simple-clipping-expected.html
trunk/LayoutTests/fast/sub-pixel/simple-clipping.html




Diff

Modified: trunk/LayoutTests/ChangeLog (164448 => 164449)

--- trunk/LayoutTests/ChangeLog	2014-02-20 22:55:11 UTC (rev 164448)
+++ trunk/LayoutTests/ChangeLog	2014-02-20 23:04:20 UTC (rev 164449)
@@ -1,3 +1,21 @@
+2014-02-20  Zalan Bujtas  
+
+Subpixel rendering: Enable compositing RenderLayer painting on device pixel position.
+https://bugs.webkit.org/show_bug.cgi?id=128509
+
+Reviewed by Simon Fraser.
+
+GraphicsLayer is now positioned on device pixel boundary. This enables us to put
+compositing layers on a subpixel position and animate them with device pixel
+precision.
+
+* TestExpectations:
+* fast/sub-pixel/compositing-layers-on-subpixel-position-expected.html: Added.
+* fast/sub-pixel/compositing-layers-on-subpixel-position.html: Added.
+* fast/sub-pixel/simple-clipping-expected.html: Added.
+* fast/sub-pixel/simple-clipping.html: Added.
+* platform/mac/compositing/layer-creation/overlap-animation-container-expected.txt:
+
 2014-02-20  Mark Hahnenberg  
 
 Unskip fast/workers/use-machine-stack.html


Modified: trunk/LayoutTests/TestExpectations (164448 => 164449)

--- trunk/LayoutTests/TestExpectations	2014-02-20 22:55:11 UTC (rev 164448)
+++ trunk/LayoutTests/TestExpectations	2014-02-20 23:04:20 UTC (rev 164449)
@@ -102,3 +102,7 @@
 webkit.org/b/83618 fast/dom/inline-event-attributes-release.html [ Failure ]
 
 webkit.org/b/129057 media/controls-styling-strict.html [ Pass Failure ]
+
+#subpixel failure on non-retina displays.
+webkit.org/b/129050 fast/sub-pixel/compositing-layers-on-subpixel-position.html [ Failure ]
+webkit.org/b/129113 fast/multicol/newmulticol/clipping.html [ Failure ]


Added: trunk/LayoutTests/fast/sub-pixel/compositing-layers-on-subpixel-position-expected.html (0 => 164449)

--- trunk/LayoutTests/fast/sub-pixel/compositing-layers-on-subpixel-position-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/compositing-layers-on-subpixel-position-expected.html	2014-02-20 23:04:20 UTC (rev 164449)
@@ -0,0 +1,50 @@
+
+
+
+This tests that we properly position render layers when composition is introduced.
+
+  div {
+background-color: black;
+position: absolute;
+  }
+  .parent {
+background-color: red;
+  }
+
+
+
+
+
+  var childPos = -2;
+  function createGrid(topPos, leftPos) {
+var container = document.getElementById("container");
+localTopPos = topPos;
+localLeftPos = leftPos;
+for (var i = 0; i < 10; ++i, localTopPos = l

[webkit-changes] [164450] trunk/Source/WebKit2

2014-02-20 Thread andersca

Title: [164450] trunk/Source/WebKit2








Revision 164450
Author ander...@apple.com
Date 2014-02-20 15:04:31 -0800 (Thu, 20 Feb 2014)


Log Message
Make it possible to reply asynchronously to _javascript_ panels and alerts
https://bugs.webkit.org/show_bug.cgi?id=129116

Reviewed by Dan Bernstein.

* Scripts/webkit2/LegacyMessageReceiver-expected.cpp:
(Messages::WebPage::GetPluginProcessConnection::DelayedReply::send):
(Messages::WebPage::TestMultipleAttributes::DelayedReply::send):
* Scripts/webkit2/MessageReceiver-expected.cpp:
(Messages::WebPage::GetPluginProcessConnection::DelayedReply::send):
(Messages::WebPage::TestMultipleAttributes::DelayedReply::send):
* Scripts/webkit2/messages.py:
(generate_message_handler):
* UIProcess/API/APIUIClient.h:
(API::UIClient::runJavaScriptAlert):
(API::UIClient::runJavaScriptConfirm):
(API::UIClient::runJavaScriptPrompt):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp
trunk/Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp
trunk/Source/WebKit2/Scripts/webkit2/messages.py
trunk/Source/WebKit2/UIProcess/API/APIUIClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164449 => 164450)

--- trunk/Source/WebKit2/ChangeLog	2014-02-20 23:04:20 UTC (rev 164449)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-20 23:04:31 UTC (rev 164450)
@@ -1,3 +1,31 @@
+2014-02-20  Anders Carlsson  
+
+Make it possible to reply asynchronously to _javascript_ panels and alerts
+https://bugs.webkit.org/show_bug.cgi?id=129116
+
+Reviewed by Dan Bernstein.
+
+* Scripts/webkit2/LegacyMessageReceiver-expected.cpp:
+(Messages::WebPage::GetPluginProcessConnection::DelayedReply::send):
+(Messages::WebPage::TestMultipleAttributes::DelayedReply::send):
+* Scripts/webkit2/MessageReceiver-expected.cpp:
+(Messages::WebPage::GetPluginProcessConnection::DelayedReply::send):
+(Messages::WebPage::TestMultipleAttributes::DelayedReply::send):
+* Scripts/webkit2/messages.py:
+(generate_message_handler):
+* UIProcess/API/APIUIClient.h:
+(API::UIClient::runJavaScriptAlert):
+(API::UIClient::runJavaScriptConfirm):
+(API::UIClient::runJavaScriptPrompt):
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPageUIClient):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::runJavaScriptAlert):
+(WebKit::WebPageProxy::runJavaScriptConfirm):
+(WebKit::WebPageProxy::runJavaScriptPrompt):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+
 2014-02-20  Enrique Ocaña González  
 
 WebKitGTK+ should stop using COMPILE_ASSERT_MATCHING_ENUM macros


Modified: trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp (164449 => 164450)

--- trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp	2014-02-20 23:04:20 UTC (rev 164449)
+++ trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp	2014-02-20 23:04:31 UTC (rev 164450)
@@ -74,9 +74,9 @@
 {
 ASSERT(m_encoder);
 *m_encoder << connectionHandle;
-bool result = m_connection->sendSyncReply(std::move(m_encoder));
+bool _result = m_connection->sendSyncReply(std::move(m_encoder));
 m_connection = nullptr;
-return result;
+return _result;
 }
 
 TestMultipleAttributes::DelayedReply::DelayedReply(PassRefPtr connection, std::unique_ptr encoder)
@@ -93,9 +93,9 @@
 bool TestMultipleAttributes::DelayedReply::send()
 {
 ASSERT(m_encoder);
-bool result = m_connection->sendSyncReply(std::move(m_encoder));
+bool _result = m_connection->sendSyncReply(std::move(m_encoder));
 m_connection = nullptr;
-return result;
+return _result;
 }
 
 } // namespace WebPage


Modified: trunk/Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp (164449 => 164450)

--- trunk/Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp	2014-02-20 23:04:20 UTC (rev 164449)
+++ trunk/Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp	2014-02-20 23:04:31 UTC (rev 164450)
@@ -74,9 +74,9 @@
 {
 ASSERT(m_encoder);
 *m_encoder << connectionHandle;
-bool result = m_connection->sendSyncReply(std::move(m_encoder));
+bool _result = m_connection->sendSyncReply(std::move(m_encoder));
 m_connection = nullptr;
-return result;
+return _result;
 }
 
 TestMultipleAttributes::DelayedReply::DelayedReply(PassRefPtr connection, std::

[webkit-changes] [164448] trunk/Source/JavaScriptCore

2014-02-20 Thread mhahnenberg

Title: [164448] trunk/Source/_javascript_Core








Revision 164448
Author mhahnenb...@apple.com
Date 2014-02-20 14:55:11 -0800 (Thu, 20 Feb 2014)


Log Message
CopiedBlock::pin can call into fastFree while forbidden
https://bugs.webkit.org/show_bug.cgi?id=128654

Reviewed by Oliver Hunt.

A FullCollection that skips copying doesn't clear the CopyWorkList of the all the surviving
CopiedBlocks because we currently only call didSurviveGC() at the beginning of FullCollections.

EdenCollections always do copying, therefore they always clear all CopyWorkLists.

The fix is to call didSurviveGC() for all surviving CopiedBlocks at the end of FullCollections
as well at the beginning.

* heap/CopiedBlock.h:
(JSC::CopiedBlock::didSurviveGC):
* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::doneCopying):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/CopiedBlock.h
trunk/Source/_javascript_Core/heap/CopiedSpace.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164447 => 164448)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-20 22:53:21 UTC (rev 164447)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-20 22:55:11 UTC (rev 164448)
@@ -1,5 +1,25 @@
 2014-02-20  Mark Hahnenberg  
 
+CopiedBlock::pin can call into fastFree while forbidden
+https://bugs.webkit.org/show_bug.cgi?id=128654
+
+Reviewed by Oliver Hunt.
+
+A FullCollection that skips copying doesn't clear the CopyWorkList of the all the surviving 
+CopiedBlocks because we currently only call didSurviveGC() at the beginning of FullCollections.
+
+EdenCollections always do copying, therefore they always clear all CopyWorkLists.
+
+The fix is to call didSurviveGC() for all surviving CopiedBlocks at the end of FullCollections 
+as well at the beginning.
+
+* heap/CopiedBlock.h:
+(JSC::CopiedBlock::didSurviveGC):
+* heap/CopiedSpace.cpp:
+(JSC::CopiedSpace::doneCopying):
+
+2014-02-20  Mark Hahnenberg  
+
 Add a JSC option to disable EdenCollections
 https://bugs.webkit.org/show_bug.cgi?id=128849
 


Modified: trunk/Source/_javascript_Core/heap/CopiedBlock.h (164447 => 164448)

--- trunk/Source/_javascript_Core/heap/CopiedBlock.h	2014-02-20 22:53:21 UTC (rev 164447)
+++ trunk/Source/_javascript_Core/heap/CopiedBlock.h	2014-02-20 22:55:11 UTC (rev 164448)
@@ -147,6 +147,7 @@
 inline void CopiedBlock::didSurviveGC()
 {
 checkConsistency();
+ASSERT(isOld());
 m_liveBytes = 0;
 #ifndef NDEBUG
 m_liveObjects = 0;


Modified: trunk/Source/_javascript_Core/heap/CopiedSpace.cpp (164447 => 164448)

--- trunk/Source/_javascript_Core/heap/CopiedSpace.cpp	2014-02-20 22:53:21 UTC (rev 164447)
+++ trunk/Source/_javascript_Core/heap/CopiedSpace.cpp	2014-02-20 22:55:11 UTC (rev 164448)
@@ -253,6 +253,7 @@
 // We don't add the block to the blockSet because it was never removed.
 ASSERT(m_blockSet.contains(block));
 blockFilter->add(reinterpret_cast(block));
+block->didSurviveGC();
 toSpace->push(block);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164447] trunk/Source/JavaScriptCore

2014-02-20 Thread mhahnenberg

Title: [164447] trunk/Source/_javascript_Core








Revision 164447
Author mhahnenb...@apple.com
Date 2014-02-20 14:53:21 -0800 (Thu, 20 Feb 2014)


Log Message
Add a JSC option to disable EdenCollections
https://bugs.webkit.org/show_bug.cgi?id=128849

Reviewed by Mark Lam.

This will help quickly identify whether or not GenGC is responsible for a
particular crash by prematurely collecting a live object.

* heap/Heap.cpp:
(JSC::Heap::collect):
(JSC::Heap::shouldDoFullCollection):
* heap/Heap.h:
* runtime/Options.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/runtime/Options.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164446 => 164447)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-20 22:09:12 UTC (rev 164446)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-20 22:53:21 UTC (rev 164447)
@@ -1,3 +1,19 @@
+2014-02-20  Mark Hahnenberg  
+
+Add a JSC option to disable EdenCollections
+https://bugs.webkit.org/show_bug.cgi?id=128849
+
+Reviewed by Mark Lam.
+
+This will help quickly identify whether or not GenGC is responsible for a 
+particular crash by prematurely collecting a live object.
+
+* heap/Heap.cpp:
+(JSC::Heap::collect):
+(JSC::Heap::shouldDoFullCollection):
+* heap/Heap.h:
+* runtime/Options.h:
+
 2014-02-20  Michael Saboff  
 
 REGRESSION (r164417): ASSERTION FAILED: isBranch() in X86 32 bit build


Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (164446 => 164447)

--- trunk/Source/_javascript_Core/heap/Heap.cpp	2014-02-20 22:09:12 UTC (rev 164446)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp	2014-02-20 22:53:21 UTC (rev 164447)
@@ -832,24 +832,16 @@
 }
 #endif
 
-bool isFullCollection = m_shouldDoFullCollection;
-if (isFullCollection) {
+if (shouldDoFullCollection()) {
 m_operationInProgress = FullCollection;
 m_slotVisitor.clearMarkStack();
 m_shouldDoFullCollection = false;
 if (Options::logGC())
 dataLog("FullCollection, ");
 } else {
-#if ENABLE(GGC)
 m_operationInProgress = EdenCollection;
 if (Options::logGC())
 dataLog("EdenCollection, ");
-#else
-m_operationInProgress = FullCollection;
-m_slotVisitor.clearMarkStack();
-if (Options::logGC())
-dataLog("FullCollection, ");
-#endif
 }
 if (m_operationInProgress == FullCollection)
 m_extraMemoryUsage = 0;
@@ -1136,4 +1128,13 @@
 #endif
 }
 
+bool Heap::shouldDoFullCollection() const
+{
+#if ENABLE(GGC)
+return Options::alwaysDoFullCollection() || m_shouldDoFullCollection;
+#else
+return true;
+#endif
+}
+
 } // namespace JSC


Modified: trunk/Source/_javascript_Core/heap/Heap.h (164446 => 164447)

--- trunk/Source/_javascript_Core/heap/Heap.h	2014-02-20 22:09:12 UTC (rev 164446)
+++ trunk/Source/_javascript_Core/heap/Heap.h	2014-02-20 22:53:21 UTC (rev 164447)
@@ -255,6 +255,7 @@
 void zombifyDeadObjects();
 void markDeadObjects();
 
+bool shouldDoFullCollection() const;
 size_t sizeAfterCollect();
 
 JSStack& stack();


Modified: trunk/Source/_javascript_Core/runtime/Options.h (164446 => 164447)

--- trunk/Source/_javascript_Core/runtime/Options.h	2014-02-20 22:09:12 UTC (rev 164446)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2014-02-20 22:53:21 UTC (rev 164447)
@@ -135,6 +135,7 @@
 v(bool, alwaysComputeHash, false) \
 v(bool, testTheFTL, false) \
 v(bool, verboseSanitizeStack, false) \
+v(bool, alwaysDoFullCollection, false) \
 \
 v(bool, enableOSREntryToDFG, true) \
 v(bool, enableOSREntryToFTL, true) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164445] trunk/Source/JavaScriptCore

2014-02-20 Thread msaboff

Title: [164445] trunk/Source/_javascript_Core








Revision 164445
Author msab...@apple.com
Date 2014-02-20 14:07:13 -0800 (Thu, 20 Feb 2014)


Log Message
REGRESSION (r164417): ASSERTION FAILED: isBranch() in X86 32 bit build
https://bugs.webkit.org/show_bug.cgi?id=129118

Reviewed by Filip Pizlo.

Changed 32 bit version of SpeculativeJIT::compile handling of Jump nodes to match
what is in the 64 bit build.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (16 => 164445)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-20 21:29:37 UTC (rev 16)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-20 22:07:13 UTC (rev 164445)
@@ -1,3 +1,16 @@
+2014-02-20  Michael Saboff  
+
+REGRESSION (r164417): ASSERTION FAILED: isBranch() in X86 32 bit build
+https://bugs.webkit.org/show_bug.cgi?id=129118
+
+Reviewed by Filip Pizlo.
+
+Changed 32 bit version of SpeculativeJIT::compile handling of Jump nodes to match
+what is in the 64 bit build.
+
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
 2014-02-20  Zan Dobersek  
 
 [Automake] Collect the _javascript_ files required for JSC builtins through a wildcard


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (16 => 164445)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2014-02-20 21:29:37 UTC (rev 16)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2014-02-20 22:07:13 UTC (rev 164445)
@@ -3009,7 +3009,7 @@
 }
 
 case DFG::Jump: {
-jump(node->branchData()->taken.block);
+jump(node->targetBlock());
 noResult(node);
 break;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164444] trunk/Source/JavaScriptCore

2014-02-20 Thread zandobersek

Title: [16] trunk/Source/_javascript_Core








Revision 16
Author zandober...@gmail.com
Date 2014-02-20 13:29:37 -0800 (Thu, 20 Feb 2014)


Log Message
[Automake] Collect the _javascript_ files required for JSC builtins through a wildcard
https://bugs.webkit.org/show_bug.cgi?id=129115

Reviewed by Oliver Hunt.

* GNUmakefile.list.am: Simplify adding new _javascript_Core builtins by using a wildcard
to gather all the _javascript_ files instead of listing each file explicitly.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164443 => 16)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-20 20:57:20 UTC (rev 164443)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-20 21:29:37 UTC (rev 16)
@@ -1,3 +1,13 @@
+2014-02-20  Zan Dobersek  
+
+[Automake] Collect the _javascript_ files required for JSC builtins through a wildcard
+https://bugs.webkit.org/show_bug.cgi?id=129115
+
+Reviewed by Oliver Hunt.
+
+* GNUmakefile.list.am: Simplify adding new _javascript_Core builtins by using a wildcard
+to gather all the _javascript_ files instead of listing each file explicitly.
+
 2014-02-20  Mark Hahnenberg  
 
 Replace uses of deprecated POSIX index() with strchr() in ObjcRuntimeExtras.h


Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (164443 => 16)

--- trunk/Source/_javascript_Core/GNUmakefile.list.am	2014-02-20 20:57:20 UTC (rev 164443)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am	2014-02-20 21:29:37 UTC (rev 16)
@@ -38,8 +38,7 @@
 	DerivedSources/_javascript_Core/LLIntAssembly.h
 
 _javascript_core_builtins_js_nosources += \
-	Source/_javascript_Core/builtins/Array.prototype.js \
-	Source/_javascript_Core/builtins/Promise.prototype.js
+	$(wildcard $(srcdir)/Source/_javascript_Core/builtins/*.js)
 
 _javascript_core_sources += \
 	Source/_javascript_Core/API/APICallbackFunction.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164443] trunk/Source/JavaScriptCore

2014-02-20 Thread mhahnenberg

Title: [164443] trunk/Source/_javascript_Core








Revision 164443
Author mhahnenb...@apple.com
Date 2014-02-20 12:57:20 -0800 (Thu, 20 Feb 2014)


Log Message
Replace uses of deprecated POSIX index() with strchr() in ObjcRuntimeExtras.h
https://bugs.webkit.org/show_bug.cgi?id=128610

Reviewed by Anders Carlsson.

index() is deprecated in favor of strchr() so we should use the latter.

* API/JSWrapperMap.mm:
(selectorToPropertyName):
* API/ObjcRuntimeExtras.h:
(parseObjCType):

Modified Paths

trunk/Source/_javascript_Core/API/JSWrapperMap.mm
trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/JSWrapperMap.mm (164442 => 164443)

--- trunk/Source/_javascript_Core/API/JSWrapperMap.mm	2014-02-20 20:37:03 UTC (rev 164442)
+++ trunk/Source/_javascript_Core/API/JSWrapperMap.mm	2014-02-20 20:57:20 UTC (rev 164443)
@@ -59,7 +59,7 @@
 static NSString *selectorToPropertyName(const char* start)
 {
 // Use 'index' to check for colons, if there are none, this is easy!
-const char* firstColon = index(start, ':');
+const char* firstColon = strchr(start, ':');
 if (!firstColon)
 return [NSString stringWithUTF8String:start];
 


Modified: trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h (164442 => 164443)

--- trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h	2014-02-20 20:37:03 UTC (rev 164442)
+++ trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h	2014-02-20 20:57:20 UTC (rev 164443)
@@ -193,8 +193,8 @@
 
 if (*position == '"') {
 const char* begin = position + 1;
-const char* protocolPosition = index(begin, '<');
-const char* endOfType = index(begin, '"');
+const char* protocolPosition = strchr(begin, '<');
+const char* endOfType = strchr(begin, '"');
 position = endOfType + 1;
 
 // There's no protocol involved in this type, so just handle the class name.


Modified: trunk/Source/_javascript_Core/ChangeLog (164442 => 164443)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-20 20:37:03 UTC (rev 164442)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-20 20:57:20 UTC (rev 164443)
@@ -1,3 +1,17 @@
+2014-02-20  Mark Hahnenberg  
+
+Replace uses of deprecated POSIX index() with strchr() in ObjcRuntimeExtras.h
+https://bugs.webkit.org/show_bug.cgi?id=128610
+
+Reviewed by Anders Carlsson.
+
+index() is deprecated in favor of strchr() so we should use the latter.
+
+* API/JSWrapperMap.mm:
+(selectorToPropertyName):
+* API/ObjcRuntimeExtras.h:
+(parseObjCType):
+
 2014-02-19  Filip Pizlo  
 
 FTL should not emit stack overflow checks in leaf functions






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164442] trunk/Source/JavaScriptCore

2014-02-20 Thread fpizlo

Title: [164442] trunk/Source/_javascript_Core








Revision 164442
Author fpi...@apple.com
Date 2014-02-20 12:37:03 -0800 (Thu, 20 Feb 2014)


Log Message
FTL should not emit stack overflow checks in leaf functions
https://bugs.webkit.org/show_bug.cgi?id=129085

Reviewed by Michael Saboff.

Miniscule (0.5%) speed-up on V8v7.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::didOverflowStack):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164441 => 164442)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-20 20:01:19 UTC (rev 164441)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-20 20:37:03 UTC (rev 164442)
@@ -1,3 +1,16 @@
+2014-02-19  Filip Pizlo  
+
+FTL should not emit stack overflow checks in leaf functions
+https://bugs.webkit.org/show_bug.cgi?id=129085
+
+Reviewed by Michael Saboff.
+
+Miniscule (0.5%) speed-up on V8v7.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::lower):
+(JSC::FTL::LowerDFGToLLVM::didOverflowStack):
+
 2014-02-20  Mark Hahnenberg  
 
 Dynamically generated JSExport protocols added to a class results in a crash


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (164441 => 164442)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-02-20 20:01:19 UTC (rev 164441)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-02-20 20:37:03 UTC (rev 164442)
@@ -136,9 +136,9 @@
 m_tagMask = m_out.constInt64(TagMask);
 
 m_out.storePtr(m_out.constIntPtr(codeBlock()), addressFor(JSStack::CodeBlock));
+
 m_out.branch(
-m_out.below(m_callFrame, m_out.loadPtr(m_out.absolute(vm().addressOfFTLStackLimit(,
-rarely(stackOverflow), usually(lowBlock(m_graph.block(0;
+didOverflowStack(), rarely(stackOverflow), usually(lowBlock(m_graph.block(0;
 
 m_out.appendTo(stackOverflow, m_handleExceptions);
 vmCall(m_out.operation(operationThrowStackOverflowError), m_callFrame, m_out.constIntPtr(codeBlock()), NoExceptions);
@@ -3704,6 +3704,42 @@
 m_out.store64(m_out.add(m_out.load64(counter), m_out.constInt64(1)), counter);
 }
 
+LValue didOverflowStack()
+{
+// This does a very simple leaf function analysis. The invariant of FTL call
+// frames is that the caller had already done enough of a stack check to
+// prove that this call frame has enough stack to run, and also enough stack
+// to make runtime calls. So, we only need to stack check when making calls
+// to other JS functions. If we don't find such calls then we don't need to
+// do any stack checks.
+
+for (BlockIndex blockIndex = 0; blockIndex < m_graph.numBlocks(); ++blockIndex) {
+BasicBlock* block = m_graph.block(blockIndex);
+if (!block)
+continue;
+
+for (unsigned nodeIndex = block->size(); nodeIndex--;) {
+Node* node = block->at(nodeIndex);
+
+switch (node->op()) {
+case GetById:
+case PutById:
+case Call:
+case Construct:
+return m_out.below(
+m_callFrame,
+m_out.loadPtr(
+m_out.absolute(vm().addressOfFTLStackLimit(;
+
+default:
+break;
+}
+}
+}
+
+return m_out.booleanFalse;
+}
+
 LValue getById(LValue base)
 {
 StringImpl* uid = m_graph.identifiers()[m_node->identifierNumber()];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164441] trunk/Source/WebCore

2014-02-20 Thread bjonesbe

Title: [164441] trunk/Source/WebCore








Revision 164441
Author bjone...@adobe.com
Date 2014-02-20 12:01:19 -0800 (Thu, 20 Feb 2014)


Log Message
Rename border/padding/margin width/height to horizontal/vertical extent on RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=129043

Reviewed by David Hyatt.

Using horizontal extent instead of width and vertical extent instead
of height makes it more obvious that these are measurements of both
border/margin/padding sides, not just one.

As David Hyatt put it: "I dislike using terms like 'width' since it
could be confused with the actual border-width CSS name, i.e., a
person new to this code would think the method was returning the pixel
width of a single border."

No new tests, no behavior change.

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::updateWidget):
* inspector/InspectorOverlay.cpp:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::positionForPoint):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::horizontalBorderExtent):
(WebCore::RenderBoxModelObject::verticalBorderExtent):
(WebCore::RenderBoxModelObject::verticalBorderAndPaddingExtent):
(WebCore::RenderBoxModelObject::horizontalBorderAndPaddingExtent):
(WebCore::RenderBoxModelObject::verticalMarginExtent):
(WebCore::RenderBoxModelObject::horizontalMarginExtent):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::computePreferredLogicalWidths):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::localCaretRect):
(WebCore::RenderInline::generateCulledLineBoxRects):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computePreferredLogicalWidths):
(WebCore::RenderListBox::computeLogicalHeight):
* rendering/RenderMenuList.cpp:
(RenderMenuList::computePreferredLogicalWidths):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::trackPieceRectWithMargins):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computePreferredLogicalWidths):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
* rendering/line/LineLayoutState.h:
(WebCore::FloatWithRect::FloatWithRect):
* rendering/shapes/ShapeInfo.cpp:
(WebCore::ShapeInfo::setReferenceBoxLogicalSize):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::updateCachedBoundaries):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAppletElement.cpp
trunk/Source/WebCore/inspector/InspectorOverlay.cpp
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.h
trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFieldset.cpp
trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderMenuList.cpp
trunk/Source/WebCore/rendering/RenderScrollbar.cpp
trunk/Source/WebCore/rendering/RenderSlider.cpp
trunk/Source/WebCore/rendering/RenderTextControl.cpp
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
trunk/Source/WebCore/rendering/line/LineLayoutState.h
trunk/Source/WebCore/rendering/shapes/ShapeInfo.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164440 => 164441)

--- trunk/Source/WebCore/ChangeLog	2014-02-20 19:40:28 UTC (rev 164440)
+++ trunk/Source/WebCore/ChangeLog	2014-02-20 20:01:19 UTC (rev 164441)
@@ -1,5 +1,75 @@
 2014-02-20  Bem Jones-Bey  
 
+Rename border/padding/margin width/height to horizontal/vertical extent on RenderBoxModelObject
+https://bugs.webkit.org/show_bug.cgi?id=129043
+
+Reviewed by David Hyatt.
+
+Using horizontal extent instead of width and vertical extent instead
+of height makes it more obvious that these are measurements of both
+border/margin/padding sides, not just one.
+
+As David Hyatt put it: "I dislike using terms like 'width' since it
+could be confused with the actu

[webkit-changes] [164439] trunk/Source/JavaScriptCore

2014-02-20 Thread mhahnenberg

Title: [164439] trunk/Source/_javascript_Core








Revision 164439
Author mhahnenb...@apple.com
Date 2014-02-20 11:40:04 -0800 (Thu, 20 Feb 2014)


Log Message
Dynamically generated JSExport protocols added to a class results in a crash
https://bugs.webkit.org/show_bug.cgi?id=129108

Reviewed by Oliver Hunt.

We're not getting any information from the runtime about the types of the methods on
these protocols because they didn't exist at compile time. We should handle this gracefully.

* API/ObjCCallbackFunction.mm:
(objCCallbackFunctionForInvocation):
* API/tests/JSExportTests.mm:
(+[JSExportTests exportDynamicallyGeneratedProtocolTest]):
(runJSExportTests):

Modified Paths

trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm
trunk/Source/_javascript_Core/API/tests/JSExportTests.mm
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm (164438 => 164439)

--- trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm	2014-02-20 19:31:02 UTC (rev 164438)
+++ trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm	2014-02-20 19:40:04 UTC (rev 164439)
@@ -632,6 +632,9 @@
 
 static JSObjectRef objCCallbackFunctionForInvocation(JSContext *context, NSInvocation *invocation, CallbackType type, Class instanceClass, const char* signatureWithObjcClasses)
 {
+if (!signatureWithObjcClasses)
+return nil;
+
 const char* position = signatureWithObjcClasses;
 
 OwnPtr result = adoptPtr(parseObjCType(position));


Modified: trunk/Source/_javascript_Core/API/tests/JSExportTests.mm (164438 => 164439)

--- trunk/Source/_javascript_Core/API/tests/JSExportTests.mm	2014-02-20 19:31:02 UTC (rev 164438)
+++ trunk/Source/_javascript_Core/API/tests/JSExportTests.mm	2014-02-20 19:40:04 UTC (rev 164439)
@@ -25,6 +25,9 @@
 
 #import "JSExportTests.h"
 
+#import 
+#import 
+
 #if JSC_OBJC_API_ENABLED
 
 extern "C" void checkResult(NSString *description, bool passed);
@@ -32,6 +35,7 @@
 @interface JSExportTests : NSObject
 + (void) exportInstanceMethodWithIdProtocolTest;
 + (void) exportInstanceMethodWithClassProtocolTest;
++ (void) exportDynamicallyGeneratedProtocolTest;
 @end
 
 @protocol TruthTeller
@@ -100,6 +104,25 @@
 [context evaluateScript:@"makeTestObject().methodWithClassProtocol(opaqueObject);"];
 checkResult(@"Successfully exported instance method", !context.exception);
 }
+
++ (void) exportDynamicallyGeneratedProtocolTest
+{
+JSContext *context = [[JSContext alloc] init];
+Protocol *dynProtocol = objc_allocateProtocol("NSStringJSExport");
+Protocol *jsExportProtocol = @protocol(JSExport);
+protocol_addProtocol(dynProtocol, jsExportProtocol);
+Method method = class_getInstanceMethod([NSString class], @selector(boolValue));
+protocol_addMethodDescription(dynProtocol, @selector(boolValue), method_getTypeEncoding(method), YES, YES);
+NSLog(@"type encoding = %s", method_getTypeEncoding(method));
+protocol_addMethodDescription(dynProtocol, @selector(boolValue), "B@:", YES, YES);
+objc_registerProtocol(dynProtocol);
+class_addProtocol([NSString class], dynProtocol);
+
+context[@"NSString"] = [NSString class];
+context[@"myString"] = @"YES";
+JSValue *value = [context evaluateScript:@"myString.boolValue()"];
+checkResult(@"Dynamically generated JSExport-ed protocols are ignored", [value isUndefined] && !!context.exception);
+}
 @end
 
 void runJSExportTests()
@@ -107,6 +130,7 @@
 @autoreleasepool {
 [JSExportTests exportInstanceMethodWithIdProtocolTest];
 [JSExportTests exportInstanceMethodWithClassProtocolTest];
+[JSExportTests exportDynamicallyGeneratedProtocolTest];
 }
 }
 


Modified: trunk/Source/_javascript_Core/ChangeLog (164438 => 164439)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-20 19:31:02 UTC (rev 164438)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-20 19:40:04 UTC (rev 164439)
@@ -1,3 +1,19 @@
+2014-02-20  Mark Hahnenberg  
+
+Dynamically generated JSExport protocols added to a class results in a crash
+https://bugs.webkit.org/show_bug.cgi?id=129108
+
+Reviewed by Oliver Hunt.
+
+We're not getting any information from the runtime about the types of the methods on 
+these protocols because they didn't exist at compile time. We should handle this gracefully.
+
+* API/ObjCCallbackFunction.mm:
+(objCCallbackFunctionForInvocation):
+* API/tests/JSExportTests.mm:
+(+[JSExportTests exportDynamicallyGeneratedProtocolTest]):
+(runJSExportTests):
+
 2014-02-20  Gabor Rapcsanyi  
 
 ASSERTION FAILED: isUInt16() on ARMv7 after r113253.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164440] trunk/Source/WebCore

2014-02-20 Thread bjonesbe

Title: [164440] trunk/Source/WebCore








Revision 164440
Author bjone...@adobe.com
Date 2014-02-20 11:40:28 -0800 (Thu, 20 Feb 2014)


Log Message
Rename RenderBlockFlow::clearFloats and RenderBlockFlow::newLine to be more accurate
https://bugs.webkit.org/show_bug.cgi?id=128991

Reviewed by David Hyatt.

Rename clearFloats to rebuildFloatingObjectSetFromIntrudingFloats
since it does just that.

Rename newLine to clearFloats because it actually does what the CSS
spec calls clearing floats. This also matches clearFloatsIfNeeded.

This also removes a FIXME comment that points to a bug that has
already been fixed.

This patch is based on a Blink patch by leviw:
https://src.chromium.org/viewvc/blink?revision=158598&view=revision

No new tests, no behavior change.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::clearFloats):
* rendering/RenderBlockFlow.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
* rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::handleFloat):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
trunk/Source/WebCore/rendering/RenderBlockFlow.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/line/BreakingContextInlineHeaders.h
trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164439 => 164440)

--- trunk/Source/WebCore/ChangeLog	2014-02-20 19:40:04 UTC (rev 164439)
+++ trunk/Source/WebCore/ChangeLog	2014-02-20 19:40:28 UTC (rev 164440)
@@ -1,3 +1,37 @@
+2014-02-20  Bem Jones-Bey  
+
+Rename RenderBlockFlow::clearFloats and RenderBlockFlow::newLine to be more accurate
+https://bugs.webkit.org/show_bug.cgi?id=128991
+
+Reviewed by David Hyatt.
+
+Rename clearFloats to rebuildFloatingObjectSetFromIntrudingFloats
+since it does just that.
+
+Rename newLine to clearFloats because it actually does what the CSS
+spec calls clearing floats. This also matches clearFloatsIfNeeded.
+
+This also removes a FIXME comment that points to a bug that has
+already been fixed.
+
+This patch is based on a Blink patch by leviw:
+https://src.chromium.org/viewvc/blink?revision=158598&view=revision
+
+No new tests, no behavior change.
+
+* rendering/RenderBlockFlow.cpp:
+(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
+(WebCore::RenderBlockFlow::layoutBlock):
+(WebCore::RenderBlockFlow::clearFloats):
+* rendering/RenderBlockFlow.h:
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::RenderBlockFlow::layoutRunsAndFloats):
+(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
+* rendering/line/BreakingContextInlineHeaders.h:
+(WebCore::BreakingContext::handleFloat):
+* rendering/svg/RenderSVGText.cpp:
+(WebCore::RenderSVGText::layout):
+
 2014-02-19  Pratik Solanki  
 
 ASSERT in FrameLoader::shouldInterruptLoadForXFrameOptions


Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (164439 => 164440)

--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2014-02-20 19:40:04 UTC (rev 164439)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2014-02-20 19:40:28 UTC (rev 164440)
@@ -203,7 +203,7 @@
 RenderBox::willBeDestroyed();
 }
 
-void RenderBlockFlow::clearFloats()
+void RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats()
 {
 if (m_floatingObjects)
 m_floatingObjects->setHorizontalWritingMode(isHorizontalWritingMode());
@@ -351,7 +351,7 @@
 if (updateLogicalWidthAndColumnWidth())
 relayoutChildren = true;
 
-clearFloats();
+rebuildFloatingObjectSetFromIntrudingFloats();
 
 LayoutUnit previousHeight = logicalHeight();
 // FIXME: should this start out as borderAndPaddingLogicalHeight() + scrollbarLogicalHeight(),
@@ -2355,7 +2355,7 @@
 return true;
 }
 
-void RenderBlockFlow::newLine(EClear clear)
+void RenderBlockFlow::clearFloats(EClear clear)
 {
 positionNewFloats();
 // set y position


Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.h (164439 => 164440)

--- trunk/Source/WebCore/rendering/RenderBlockFlow.h	2014-02-20 19:40:04 UTC (rev 164439)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.h	2014-02-20 19:40:28 UTC (rev 164440)
@@ -67,7 +67,7 @@
 // repopulates the list with any floats that intrude from previous siblings or parents. Floats that were added by
 // descendants are gone when this call completes and will get added back later on after the children have gotten
 // a relayout.
-void clearFloats();
+void rebuildFloati

[webkit-changes] [164437] trunk/LayoutTests

2014-02-20 Thread mhahnenberg

Title: [164437] trunk/LayoutTests








Revision 164437
Author mhahnenb...@apple.com
Date 2014-02-20 11:19:12 -0800 (Thu, 20 Feb 2014)


Log Message
Unskip fast/workers/use-machine-stack.html

Unreviewed test gardening. This was fixed as part of http://trac.webkit.org/changeset/164371, 
so we're unskipping it.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (164436 => 164437)

--- trunk/LayoutTests/ChangeLog	2014-02-20 18:48:51 UTC (rev 164436)
+++ trunk/LayoutTests/ChangeLog	2014-02-20 19:19:12 UTC (rev 164437)
@@ -1,3 +1,12 @@
+2014-02-20  Mark Hahnenberg  
+
+Unskip fast/workers/use-machine-stack.html
+
+Unreviewed test gardening. This was fixed as part of http://trac.webkit.org/changeset/164371, 
+so we're unskipping it.
+
+* TestExpectations:
+
 2014-02-20  Michał Pakuła vel Rutka  
 
 Unreviewed EFL gardening


Modified: trunk/LayoutTests/TestExpectations (164436 => 164437)

--- trunk/LayoutTests/TestExpectations	2014-02-20 18:48:51 UTC (rev 164436)
+++ trunk/LayoutTests/TestExpectations	2014-02-20 19:19:12 UTC (rev 164437)
@@ -99,8 +99,6 @@
 
 webkit.org/b/127697 fast/writing-mode/ruby-text-logical-left.html [ Skip ]
 
-webkit.org/b/128745 [ Debug ] fast/workers/use-machine-stack.html [ Pass Crash ]
-
 webkit.org/b/83618 fast/dom/inline-event-attributes-release.html [ Failure ]
 
 webkit.org/b/129057 media/controls-styling-strict.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164435] trunk/Source/WebCore

2014-02-20 Thread psolanki

Title: [164435] trunk/Source/WebCore








Revision 164435
Author psola...@apple.com
Date 2014-02-20 10:23:24 -0800 (Thu, 20 Feb 2014)


Log Message
ASSERT in FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=129081


Reviewed by Alexey Proskuryakov.

Do not assert if the server sends us a malformed X-Frame-Options header.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164434 => 164435)

--- trunk/Source/WebCore/ChangeLog	2014-02-20 18:15:42 UTC (rev 164434)
+++ trunk/Source/WebCore/ChangeLog	2014-02-20 18:23:24 UTC (rev 164435)
@@ -1,3 +1,16 @@
+2014-02-19  Pratik Solanki  
+
+ASSERT in FrameLoader::shouldInterruptLoadForXFrameOptions
+https://bugs.webkit.org/show_bug.cgi?id=129081
+
+
+Reviewed by Alexey Proskuryakov.
+
+Do not assert if the server sends us a malformed X-Frame-Options header.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
+
 2014-02-20  Krzysztof Czech  
 
 AX: Use auto to reduce some code in loops


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (164434 => 164435)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2014-02-20 18:15:42 UTC (rev 164434)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2014-02-20 18:23:24 UTC (rev 164435)
@@ -3068,10 +3068,11 @@
 case XFrameOptionsInvalid:
 m_frame.document()->addConsoleMessage(MessageSource::JS, MessageLevel::Error, "Invalid 'X-Frame-Options' header encountered when loading '" + url.stringCenterEllipsizedToLength() + "': '" + content + "' is not a recognized directive. The header will be ignored.", requestIdentifier);
 return false;
-default:
-ASSERT_NOT_REACHED();
+case XFrameOptionsNone:
 return false;
 }
+ASSERT_NOT_REACHED();
+return false;
 }
 
 void FrameLoader::loadProvisionalItemFromCachedPage()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164434] trunk/Source/WebKit/mac

2014-02-20 Thread ddkilzer

Title: [164434] trunk/Source/WebKit/mac








Revision 164434
Author ddkil...@apple.com
Date 2014-02-20 10:15:42 -0800 (Thu, 20 Feb 2014)


Log Message
[ASan] WebKit1 sources are not compiled using ASAN macros


Reviewed by Brent Fulgham.

* Configurations/WebKit.xcconfig: Use $inherited for
OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS so that ASAN_OTHER_CFLAGS
and ASAN_OTHER_CPLUSPLUSFLAGS are inherited from
DebugRelease.xcconfig.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/WebKit.xcconfig




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (164433 => 164434)

--- trunk/Source/WebKit/mac/ChangeLog	2014-02-20 17:38:15 UTC (rev 164433)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-02-20 18:15:42 UTC (rev 164434)
@@ -1,3 +1,15 @@
+2014-02-20  David Kilzer  
+
+[ASan] WebKit1 sources are not compiled using ASAN macros
+
+
+Reviewed by Brent Fulgham.
+
+* Configurations/WebKit.xcconfig: Use $inherited for
+OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS so that ASAN_OTHER_CFLAGS
+and ASAN_OTHER_CPLUSPLUSFLAGS are inherited from
+DebugRelease.xcconfig.
+
 2014-02-19  Brady Eidson  
 
 Add FeatureDefines for image controls


Modified: trunk/Source/WebKit/mac/Configurations/WebKit.xcconfig (164433 => 164434)

--- trunk/Source/WebKit/mac/Configurations/WebKit.xcconfig	2014-02-20 17:38:15 UTC (rev 164433)
+++ trunk/Source/WebKit/mac/Configurations/WebKit.xcconfig	2014-02-20 18:15:42 UTC (rev 164434)
@@ -53,9 +53,9 @@
 STAGED_FRAMEWORKS_SEARCH_PATH = $(STAGED_FRAMEWORKS_SEARCH_PATH_$(USE_STAGING_INSTALL_PATH));
 STAGED_FRAMEWORKS_SEARCH_PATH_YES = $(NEXT_ROOT)$(SYSTEM_LIBRARY_DIR)/StagedFrameworks/Safari;
 
-OTHER_CFLAGS = $(OTHER_CFLAGS_$(PLATFORM_NAME));
-OTHER_CFLAGS_macosx = $(OTHER_CFLAGS) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
-OTHER_CPLUSPLUSFLAGS = $(OTHER_CFLAGS);
+OTHER_CFLAGS = $(inherited) $(OTHER_CFLAGS_$(PLATFORM_NAME));
+OTHER_CFLAGS_macosx = -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+OTHER_CPLUSPLUSFLAGS = $(inherited) $(OTHER_CFLAGS_$(PLATFORM_NAME));
 
 GCC_PREFIX_HEADER = mac/WebKitPrefix.h;
 GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) $(FEATURE_DEFINES) FRAMEWORK_NAME=WebKit WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST $(GCC_PREPROCESSOR_DEFINITIONS);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164433] trunk/Source/JavaScriptCore

2014-02-20 Thread rgabor

Title: [164433] trunk/Source/_javascript_Core








Revision 164433
Author rga...@webkit.org
Date 2014-02-20 09:38:15 -0800 (Thu, 20 Feb 2014)


Log Message
ASSERTION FAILED: isUInt16() on ARMv7 after r113253.
https://bugs.webkit.org/show_bug.cgi?id=129101

Reviewed by Michael Saboff.

If the immediate value type is encoded then we shouldn't reach this assert.
Check the immediate type to avoid assertion in alignemnt check.

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::add):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164432 => 164433)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-20 17:27:16 UTC (rev 164432)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-20 17:38:15 UTC (rev 164433)
@@ -1,3 +1,16 @@
+2014-02-20  Gabor Rapcsanyi  
+
+ASSERTION FAILED: isUInt16() on ARMv7 after r113253.
+https://bugs.webkit.org/show_bug.cgi?id=129101
+
+Reviewed by Michael Saboff.
+
+If the immediate value type is encoded then we shouldn't reach this assert.
+Check the immediate type to avoid assertion in alignemnt check.
+
+* assembler/ARMv7Assembler.h:
+(JSC::ARMv7Assembler::add):
+
 2014-02-20  Csaba Osztrogonác  
 
 Get rid of redundant Platform.h includes


Modified: trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h (164432 => 164433)

--- trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h	2014-02-20 17:27:16 UTC (rev 164432)
+++ trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h	2014-02-20 17:38:15 UTC (rev 164433)
@@ -857,7 +857,7 @@
 ASSERT(rn != ARMRegisters::pc);
 ASSERT(imm.isValid());
 
-if (rn == ARMRegisters::sp) {
+if (rn == ARMRegisters::sp && imm.isUInt16()) {
 ASSERT(!(imm.getUInt16() & 3));
 if (!(rd & 8) && imm.isUInt10()) {
 m_formatter.oneWordOp5Reg3Imm8(OP_ADD_SP_imm_T1, rd, static_cast(imm.getUInt10() >> 2));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164432] trunk/Source/WebInspectorUI

2014-02-20 Thread graouts

Title: [164432] trunk/Source/WebInspectorUI








Revision 164432
Author grao...@webkit.org
Date 2014-02-20 09:27:16 -0800 (Thu, 20 Feb 2014)


Log Message
Web Inspector: Popover should animate its frame to display its refreshed content
https://bugs.webkit.org/show_bug.cgi?id=129088

Reviewed by Timothy Hatcher.

When calling .update(), we now check whether we can animate the change of frame provided the
new computed frame to best fit the current content still matches the edge the popover uses
to attach to the target frame. If we find that we can do so, we animate the background frame
of the popover while ensuring the anchor point remains stable during the animation such that
only the popover's frame seems to animate.

* UserInterface/Geometry.js:
(WebInspector.Rect.prototype.round):
Returns a new Rect with rounded values, using a floor for the position and a ceil for the size.

* UserInterface/Main.html:
Link to the new UnitBezier.js source file.

* UserInterface/Popover.js:
(WebInspector.Popover):
Make ._anchorPoint an ivar such that we don't need to pass a reference to the anchorPoint into
the various calls leading to an update of the popover's background drawing.

(WebInspector.Popover.prototype.set frame):
We no longer round the values of the frame here, instead calling the new .round() method on Rect
in places where we compute a new frame.

(WebInspector.Popover.prototype.set content):
(WebInspector.Popover.prototype.update):
Update the calls to ._update() to set the new shouldAnimate flag to true in situations where the
popover is already visible.

(WebInspector.Popover.prototype._update):
In the situation where there is a preference to animate the frame, as set by the new shouldAnimate
parameter, check that we can indeed animate by ensuring that the edge the popover uses to attach to
the target frame remains the same upon computing the new best metrics for the new content size. If
we can indeed animate, call _animateFrame(), otherwise set the new frame, anchor point and frame
drawing discretely like we used to.

(WebInspector.Popover.prototype._setAnchorPoint):
New method to ensure we floor the position of the anchor point to ensure, when animating, that the
anchor point remains stationary.

(WebInspector.Popover.prototype._animateFrame):
Using the new UnitBezier class, animate the popover frame from its previous value to its newly computed
value while ensuring the anchor point remains, at all times, the same absolute position such that it
remains stationary during the animation. The spline used to animate the frame is the same that a CSS
transition set with an "ease" timing-function (default value) would use.

(WebInspector.Popover.prototype._drawBackground):
(WebInspector.Popover.prototype._drawFrame):
Adopt new ._edge and ._anchorPoint ivars.

* UserInterface/UnitBezier.js: Added.
New class used to perform animations using a timing function specified with a cubic Bézier curve. The code
is directly adapted from the Source/WebCore/platform/graphics/UnitBezier.h file.

(WebInspector.UnitBezier):
(WebInspector.UnitBezier.prototype.solve):
(WebInspector.UnitBezier.prototype._sampleCurveX):
(WebInspector.UnitBezier.prototype._sampleCurveY):
(WebInspector.UnitBezier.prototype._sampleCurveDerivativeX):
(WebInspector.UnitBezier.prototype._solveCurveX):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Geometry.js
trunk/Source/WebInspectorUI/UserInterface/Main.html
trunk/Source/WebInspectorUI/UserInterface/Popover.js


Added Paths

trunk/Source/WebInspectorUI/UserInterface/UnitBezier.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (164431 => 164432)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-02-20 17:19:18 UTC (rev 164431)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-02-20 17:27:16 UTC (rev 164432)
@@ -1,5 +1,71 @@
 2014-02-20  Antoine Quint  
 
+Web Inspector: Popover should animate its frame to display its refreshed content
+https://bugs.webkit.org/show_bug.cgi?id=129088
+
+Reviewed by Timothy Hatcher.
+
+When calling .update(), we now check whether we can animate the change of frame provided the
+new computed frame to best fit the current content still matches the edge the popover uses
+to attach to the target frame. If we find that we can do so, we animate the background frame
+of the popover while ensuring the anchor point remains stable during the animation such that
+only the popover's frame seems to animate.
+
+* UserInterface/Geometry.js:
+(WebInspector.Rect.prototype.round):
+Returns a new Rect with rounded values, using a floor for the position and a ceil for the size.
+
+* UserInterface/Main.html:
+Link to the new UnitBezier.js source file.
+
+* UserInterface/Popover.js:
+(WebInspector.Popover):
+Make ._anchorPoint an ivar such that we don't need to pass a reference to the anchorPoint into
+t

[webkit-changes] [164431] trunk/Source/WebInspectorUI

2014-02-20 Thread graouts

Title: [164431] trunk/Source/WebInspectorUI








Revision 164431
Author grao...@webkit.org
Date 2014-02-20 09:19:18 -0800 (Thu, 20 Feb 2014)


Log Message
Web Inspector: content using a CSS transition within a popover causes the popover to disappear
https://bugs.webkit.org/show_bug.cgi?id=129089

Reviewed by Timothy Hatcher.

Simply check that the element being transitioned is indeed the popover's container before assuming
that the "transitonend" received was for a fade-out transition.

* UserInterface/Popover.js:
(WebInspector.Popover.prototype.handleEvent):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Popover.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (164430 => 164431)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-02-20 17:01:52 UTC (rev 164430)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-02-20 17:19:18 UTC (rev 164431)
@@ -1,5 +1,18 @@
 2014-02-20  Antoine Quint  
 
+Web Inspector: content using a CSS transition within a popover causes the popover to disappear
+https://bugs.webkit.org/show_bug.cgi?id=129089
+
+Reviewed by Timothy Hatcher.
+
+Simply check that the element being transitioned is indeed the popover's container before assuming
+that the "transitonend" received was for a fade-out transition.
+
+* UserInterface/Popover.js:
+(WebInspector.Popover.prototype.handleEvent):
+
+2014-02-20  Antoine Quint  
+
 Web Inspector: clicking on a color swatch in the Computed styles tab shouldn't show the color editing popover
 https://bugs.webkit.org/show_bug.cgi?id=129093
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Popover.js (164430 => 164431)

--- trunk/Source/WebInspectorUI/UserInterface/Popover.js	2014-02-20 17:01:52 UTC (rev 164430)
+++ trunk/Source/WebInspectorUI/UserInterface/Popover.js	2014-02-20 17:19:18 UTC (rev 164431)
@@ -154,12 +154,14 @@
 this.dismiss();
 break;
 case "transitionend":
-document.body.removeChild(this._element);
-this._element.classList.remove(WebInspector.Popover.FadeOutClassName);
-this._container.textContent = "";
-if (this.delegate && typeof this.delegate.didDismissPopover === "function")
-this.delegate.didDismissPopover(this);
-break;
+if (event.target === this._element) {
+document.body.removeChild(this._element);
+this._element.classList.remove(WebInspector.Popover.FadeOutClassName);
+this._container.textContent = "";
+if (this.delegate && typeof this.delegate.didDismissPopover === "function")
+this.delegate.didDismissPopover(this);
+break;
+}
 }
 },
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164430] trunk/Source/WTF

2014-02-20 Thread ossy

Title: [164430] trunk/Source/WTF








Revision 164430
Author o...@webkit.org
Date 2014-02-20 09:01:52 -0800 (Thu, 20 Feb 2014)


Log Message
Add StackStats sources to cmake and autotools build files
https://bugs.webkit.org/show_bug.cgi?id=129103

Reviewed by Anders Carlsson.

* GNUmakefile.list.am:
* wtf/CMakeLists.txt:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/GNUmakefile.list.am
trunk/Source/WTF/wtf/CMakeLists.txt




Diff

Modified: trunk/Source/WTF/ChangeLog (164429 => 164430)

--- trunk/Source/WTF/ChangeLog	2014-02-20 16:43:35 UTC (rev 164429)
+++ trunk/Source/WTF/ChangeLog	2014-02-20 17:01:52 UTC (rev 164430)
@@ -1,5 +1,15 @@
 2014-02-20  Csaba Osztrogonác  
 
+Add StackStats sources to cmake and autotools build files
+https://bugs.webkit.org/show_bug.cgi?id=129103
+
+Reviewed by Anders Carlsson.
+
+* GNUmakefile.list.am:
+* wtf/CMakeLists.txt:
+
+2014-02-20  Csaba Osztrogonác  
+
 Get rid of redundant Platform.h includes
 https://bugs.webkit.org/show_bug.cgi?id=128817
 


Modified: trunk/Source/WTF/GNUmakefile.list.am (164429 => 164430)

--- trunk/Source/WTF/GNUmakefile.list.am	2014-02-20 16:43:35 UTC (rev 164429)
+++ trunk/Source/WTF/GNUmakefile.list.am	2014-02-20 17:01:52 UTC (rev 164430)
@@ -154,6 +154,7 @@
 Source/WTF/wtf/Spectrum.h \
 Source/WTF/wtf/StackBounds.cpp \
 Source/WTF/wtf/StackBounds.h \
+Source/WTF/wtf/StackStats.cpp \
 Source/WTF/wtf/StackStats.h \
 Source/WTF/wtf/StaticConstructors.h \
 Source/WTF/wtf/StdLibExtras.h \


Modified: trunk/Source/WTF/wtf/CMakeLists.txt (164429 => 164430)

--- trunk/Source/WTF/wtf/CMakeLists.txt	2014-02-20 16:43:35 UTC (rev 164429)
+++ trunk/Source/WTF/wtf/CMakeLists.txt	2014-02-20 17:01:52 UTC (rev 164430)
@@ -93,6 +93,7 @@
 SaturatedArithmetic.h
 SegmentedVector.h
 StackBounds.h
+StackStats.h
 StaticConstructors.h
 StdLibExtras.h
 StringExtras.h
@@ -181,6 +182,7 @@
 RunLoop.cpp
 SHA1.cpp
 SixCharacterHash.cpp
+StackStats.cpp
 StackBounds.cpp
 StringPrintStream.cpp
 TCSystemAlloc.cpp






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164429] trunk/Source/WebInspectorUI

2014-02-20 Thread graouts

Title: [164429] trunk/Source/WebInspectorUI








Revision 164429
Author grao...@webkit.org
Date 2014-02-20 08:43:35 -0800 (Thu, 20 Feb 2014)


Log Message
Web Inspector: clicking on a color swatch in the Computed styles tab shouldn't show the color editing popover
https://bugs.webkit.org/show_bug.cgi?id=129093

Reviewed by Timothy Hatcher.

If the current editor is read-only, only allow cycling between color types since it wouldn't make sense to edit
such colors.

* UserInterface/CSSStyleDeclarationTextEditor.js:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (164428 => 164429)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-02-20 15:23:48 UTC (rev 164428)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-02-20 16:43:35 UTC (rev 164429)
@@ -1,3 +1,15 @@
+2014-02-20  Antoine Quint  
+
+Web Inspector: clicking on a color swatch in the Computed styles tab shouldn't show the color editing popover
+https://bugs.webkit.org/show_bug.cgi?id=129093
+
+Reviewed by Timothy Hatcher.
+
+If the current editor is read-only, only allow cycling between color types since it wouldn't make sense to edit
+such colors.
+
+* UserInterface/CSSStyleDeclarationTextEditor.js:
+
 2014-02-19  Joseph Pecoraro  
 
 Web Inspector: Remove unused InspectorBackend member variable


Modified: trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js (164428 => 164429)

--- trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js	2014-02-20 15:23:48 UTC (rev 164428)
+++ trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js	2014-02-20 16:43:35 UTC (rev 164429)
@@ -679,7 +679,7 @@
 this._codeMirror.operation(update.bind(this));
 }
 
-if (event.shiftKey) {
+if (event.shiftKey || this._codeMirror.getOption("readOnly")) {
 var nextFormat = color.nextFormat();
 console.assert(nextFormat);
 if (!nextFormat)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164427] trunk/LayoutTests

2014-02-20 Thread m . pakula

Title: [164427] trunk/LayoutTests








Revision 164427
Author m.pak...@samsung.com
Date 2014-02-20 06:31:42 -0800 (Thu, 20 Feb 2014)


Log Message
Unreviewed EFL gardening

Add tests expectations for failing tests and remove ones for
passing tests after r163645, r163614, r164145.

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl-wk1/TestExpectations
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (164426 => 164427)

--- trunk/LayoutTests/ChangeLog	2014-02-20 13:52:24 UTC (rev 164426)
+++ trunk/LayoutTests/ChangeLog	2014-02-20 14:31:42 UTC (rev 164427)
@@ -1,3 +1,14 @@
+2014-02-20  Michał Pakuła vel Rutka  
+
+Unreviewed EFL gardening
+
+Add tests expectations for failing tests and remove ones for
+passing tests after r163645, r163614, r164145.
+
+* platform/efl-wk1/TestExpectations:
+* platform/efl-wk2/TestExpectations:
+* platform/efl/TestExpectations:
+
 2014-02-20  Artur Moryc  
 
 AX: Children Nodes for Canvas objects are not equal to Render Objects.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (164426 => 164427)

--- trunk/LayoutTests/platform/efl/TestExpectations	2014-02-20 13:52:24 UTC (rev 164426)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2014-02-20 14:31:42 UTC (rev 164427)
@@ -695,6 +695,10 @@
 webkit.org/b/128905 media/video-fast-seek.html [ Crash Pass ]
 webkit.org/b/128905 media/video-extreme-playbackrate-crash.html [ Crash Pass ]
 
+webkit.org/b/125517 compositing/regions/floated-region-with-transformed-child.html [ ImageOnlyFailure Pass ]
+
+webkit.org/b/128736 inspector-protocol/debugger/setBreakpoint-dfg.html [ Failure Pass ]
+
 #
 # PASSING TESTS WITH INCORRECT EXPECTATIONS
 #
@@ -818,12 +822,15 @@
 webkit.org/b/84338 editing/pasteboard/copy-in-password-field.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-null-characters.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-paste-bidi.html [ Failure ]
+webkit.org/b/84338 editing/pasteboard/copy-paste-converts-fixed.html [ Failure ]
+webkit.org/b/84338 editing/pasteboard/copy-paste-converts-sticky.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-paste-converts-sticky-and-fixed.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-paste-doesnt-convert-sticky-and-fixed-during-partial-copy.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-paste-first-line-in-textarea.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-paste-float.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-paste-pre-line-content.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-paste-ruby-text-with-block.html [ Failure ]
+webkit.org/b/84338 editing/pasteboard/copy-paste-wraps-position-absolute.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-resolves-urls.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-text-with-backgroundcolor.html [ Failure ]
 webkit.org/b/84338 editing/pasteboard/copy-text-with-wrapped-tag.html [ Failure ]
@@ -1493,8 +1500,6 @@
 
 webkit.org/b/110316 svg/as-background-image/tiled-background-image.html [ ImageOnlyFailure ]
 
-webkit.org/b/110338 fast/events/touch/emulate-touch-events.html [ Failure ]
-
 webkit.org/b/110446 svg/as-background-image/svg-transformed-background.html [ ImageOnlyFailure ]
 
 # New test
@@ -1741,12 +1746,8 @@
 
 webkit.org/b/124971 compositing/repaint/repaint-on-layer-grouping-change.html [ Failure ]
 
-webkit.org/b/124971 fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html [ ImageOnlyFailure ]
-
 webkit.org/b/125348 accessibility/document-attributes.html [ Failure ]
 
-webkit.org/b/125352 fast/css/text-input-with-webkit-border-radius.html [ Failure ]
-
 webkit.org/b/125355 fast/events/updateLayoutForHitTest.html [ Failure ]
 
 webkit.org/b/125458 fast/repaint/line-flow-with-floats-9.html [ Failure ]
@@ -1759,7 +1760,6 @@
 webkit.org/b/125496 animations/cross-fade-webkit-mask-image.html [ Failure ]
 
 # Added in r157725, failing due differences in media player controls rendering
-webkit.org/b/125517 compositing/regions/floated-region-with-transformed-child.html [ ImageOnlyFailure ]
 webkit.org/b/125517 compositing/regions/propagate-region-box-shadow-border-padding-for-video.html [ ImageOnlyFailure ]
 webkit.org/b/125517 compositing/regions/transform-transparent-positioned-video-inside-region.html [ ImageOnlyFailure ]
 
@@ -1772,7 +1772,6 @@
 webkit.org/b/125517 compositing/regions/z-index-update.html [ ImageOnlyFailure ]
 webkit.org/b/125517 compositing/regions/z-index.html [ ImageOnlyFailure ]
 
-webkit.org/b/125573 compo

[webkit-changes] [164426] trunk/Source/WebCore

2014-02-20 Thread commit-queue

Title: [164426] trunk/Source/WebCore








Revision 164426
Author commit-qu...@webkit.org
Date 2014-02-20 05:52:24 -0800 (Thu, 20 Feb 2014)


Log Message
Unreviewed, rolling out r164422.
http://trac.webkit.org/changeset/164422
https://bugs.webkit.org/show_bug.cgi?id=129102

Causes assertions in
ScriptExecutionContext::canSuspendActiveDOMObjects()
(Requested by zdobersek on #webkit).

* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
* dom/KeyboardEvent.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::reportException):
(WebCore::ScriptExecutionContext::publicURLManager):
* dom/ScriptExecutionContext.h:
* dom/ScriptRunner.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/KeyboardEvent.cpp
trunk/Source/WebCore/dom/KeyboardEvent.h
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/dom/ScriptRunner.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (164425 => 164426)

--- trunk/Source/WebCore/ChangeLog	2014-02-20 12:29:53 UTC (rev 164425)
+++ trunk/Source/WebCore/ChangeLog	2014-02-20 13:52:24 UTC (rev 164426)
@@ -1,3 +1,22 @@
+2014-02-20  Commit Queue  
+
+Unreviewed, rolling out r164422.
+http://trac.webkit.org/changeset/164422
+https://bugs.webkit.org/show_bug.cgi?id=129102
+
+Causes assertions in
+ScriptExecutionContext::canSuspendActiveDOMObjects()
+(Requested by zdobersek on #webkit).
+
+* dom/KeyboardEvent.cpp:
+(WebCore::KeyboardEvent::KeyboardEvent):
+* dom/KeyboardEvent.h:
+* dom/ScriptExecutionContext.cpp:
+(WebCore::ScriptExecutionContext::reportException):
+(WebCore::ScriptExecutionContext::publicURLManager):
+* dom/ScriptExecutionContext.h:
+* dom/ScriptRunner.h:
+
 2014-02-20  Zan Dobersek  
 
 Move to using std::unique_ptr for VisitedLinkState, CheckedRadioButtons


Modified: trunk/Source/WebCore/dom/KeyboardEvent.cpp (164425 => 164426)

--- trunk/Source/WebCore/dom/KeyboardEvent.cpp	2014-02-20 12:29:53 UTC (rev 164425)
+++ trunk/Source/WebCore/dom/KeyboardEvent.cpp	2014-02-20 13:52:24 UTC (rev 164426)
@@ -108,7 +108,7 @@
 KeyboardEvent::KeyboardEvent(const PlatformKeyboardEvent& key, AbstractView* view)
 : UIEventWithKeyState(eventTypeForKeyboardEventType(key.type()),
   true, true, key.timestamp(), view, 0, key.ctrlKey(), key.altKey(), key.shiftKey(), key.metaKey())
-, m_keyEvent(std::make_unique(key))
+, m_keyEvent(adoptPtr(new PlatformKeyboardEvent(key)))
 , m_keyIdentifier(key.keyIdentifier())
 , m_location(keyLocationCode(key))
 , m_altGraphKey(false)


Modified: trunk/Source/WebCore/dom/KeyboardEvent.h (164425 => 164426)

--- trunk/Source/WebCore/dom/KeyboardEvent.h	2014-02-20 12:29:53 UTC (rev 164425)
+++ trunk/Source/WebCore/dom/KeyboardEvent.h	2014-02-20 13:52:24 UTC (rev 164426)
@@ -25,7 +25,6 @@
 #define KeyboardEvent_h
 
 #include "UIEventWithKeyState.h"
-#include 
 #include 
 
 namespace WebCore {
@@ -114,7 +113,7 @@
 KeyboardEvent(const PlatformKeyboardEvent&, AbstractView*);
 KeyboardEvent(const AtomicString&, const KeyboardEventInit&);
 
-std::unique_ptr m_keyEvent;
+OwnPtr m_keyEvent;
 String m_keyIdentifier;
 unsigned m_location;
 bool m_altGraphKey : 1;


Modified: trunk/Source/WebCore/dom/ScriptExecutionContext.cpp (164425 => 164426)

--- trunk/Source/WebCore/dom/ScriptExecutionContext.cpp	2014-02-20 12:29:53 UTC (rev 164425)
+++ trunk/Source/WebCore/dom/ScriptExecutionContext.cpp	2014-02-20 13:52:24 UTC (rev 164426)
@@ -299,8 +299,8 @@
 {
 if (m_inDispatchErrorEvent) {
 if (!m_pendingExceptions)
-m_pendingExceptions = std::make_unique>>();
-m_pendingExceptions->append(std::make_unique(errorMessage, lineNumber, columnNumber, sourceURL, callStack));
+m_pendingExceptions = adoptPtr(new Vector>());
+m_pendingExceptions->append(adoptPtr(new PendingException(errorMessage, lineNumber, columnNumber, sourceURL, callStack)));
 return;
 }
 
@@ -311,9 +311,11 @@
 if (!m_pendingExceptions)
 return;
 
-for (auto& exception : *m_pendingExceptions)
-logExceptionToConsole(exception->m_errorMessage, exception->m_sourceURL, exception->m_lineNumber, exception->m_columnNumber, exception->m_callStack);
-m_pendingExceptions.reset();
+for (size_t i = 0; i < m_pendingExceptions->size(); i++) {
+PendingException* e = m_pendingExceptions->at(i).get();
+logExceptionToConsole(e->m_errorMessage, e->m_sourceURL, e->m_lineNumber, e->m_columnNumber, e->m_callStack);
+}
+m_pendingExceptions.clear();
 }
 
 void ScriptExecutionContext::addConsoleMessage(MessageSource source, MessageLevel level, const String& message, const String& sourceURL, unsigned lineNumber, unsigned columnNumber, JSC::ExecState* state, unsigned long requestIdentifier)
@@ -361,7 +363,7 @@
 Pu

[webkit-changes] [164425] trunk/Source/WebCore

2014-02-20 Thread zandobersek

Title: [164425] trunk/Source/WebCore








Revision 164425
Author zandober...@gmail.com
Date 2014-02-20 04:29:53 -0800 (Thu, 20 Feb 2014)


Log Message
Move to using std::unique_ptr for VisitedLinkState, CheckedRadioButtons
https://bugs.webkit.org/show_bug.cgi?id=128967

Reviewed by Andreas Kling.

Replace uses of OwnPtr and PassOwnPtr in the VisitedLinkState and
CheckedRadioButtons classes with std::unique_ptr.

* dom/CheckedRadioButtons.cpp:
(WebCore::RadioButtonGroup::RadioButtonGroup):
(WebCore::RadioButtonGroup::remove):
(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):
* dom/CheckedRadioButtons.h:
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
* dom/VisitedLinkState.cpp:
* dom/VisitedLinkState.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/CheckedRadioButtons.cpp
trunk/Source/WebCore/dom/CheckedRadioButtons.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/VisitedLinkState.cpp
trunk/Source/WebCore/dom/VisitedLinkState.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (164424 => 164425)

--- trunk/Source/WebCore/ChangeLog	2014-02-20 11:33:09 UTC (rev 164424)
+++ trunk/Source/WebCore/ChangeLog	2014-02-20 12:29:53 UTC (rev 164425)
@@ -1,3 +1,25 @@
+2014-02-20  Zan Dobersek  
+
+Move to using std::unique_ptr for VisitedLinkState, CheckedRadioButtons
+https://bugs.webkit.org/show_bug.cgi?id=128967
+
+Reviewed by Andreas Kling.
+
+Replace uses of OwnPtr and PassOwnPtr in the VisitedLinkState and
+CheckedRadioButtons classes with std::unique_ptr.
+
+* dom/CheckedRadioButtons.cpp:
+(WebCore::RadioButtonGroup::RadioButtonGroup):
+(WebCore::RadioButtonGroup::remove):
+(WebCore::CheckedRadioButtons::addButton):
+(WebCore::CheckedRadioButtons::removeButton):
+* dom/CheckedRadioButtons.h:
+* dom/Document.cpp:
+(WebCore::Document::Document):
+* dom/Document.h:
+* dom/VisitedLinkState.cpp:
+* dom/VisitedLinkState.h:
+
 2014-02-20  Artur Moryc  
 
 AX: Children Nodes for Canvas objects are not equal to Render Objects.


Modified: trunk/Source/WebCore/dom/CheckedRadioButtons.cpp (164424 => 164425)

--- trunk/Source/WebCore/dom/CheckedRadioButtons.cpp	2014-02-20 11:33:09 UTC (rev 164424)
+++ trunk/Source/WebCore/dom/CheckedRadioButtons.cpp	2014-02-20 12:29:53 UTC (rev 164425)
@@ -29,7 +29,7 @@
 class RadioButtonGroup {
 WTF_MAKE_FAST_ALLOCATED;
 public:
-static PassOwnPtr create();
+RadioButtonGroup();
 bool isEmpty() const { return m_members.isEmpty(); }
 bool isRequired() const { return m_requiredCount; }
 HTMLInputElement* checkedButton() const { return m_checkedButton; }
@@ -40,7 +40,6 @@
 bool contains(HTMLInputElement*) const;
 
 private:
-RadioButtonGroup();
 void setNeedsValidityCheckForAllButtons();
 bool isValid() const;
 void setCheckedButton(HTMLInputElement*);
@@ -51,16 +50,11 @@
 };
 
 RadioButtonGroup::RadioButtonGroup()
-: m_checkedButton(0)
+: m_checkedButton(nullptr)
 , m_requiredCount(0)
 {
 }
 
-PassOwnPtr RadioButtonGroup::create()
-{
-return adoptPtr(new RadioButtonGroup);
-}
-
 inline bool RadioButtonGroup::isValid() const
 {
 return !isRequired() || m_checkedButton;
@@ -140,7 +134,7 @@
 --m_requiredCount;
 }
 if (m_checkedButton == button)
-m_checkedButton = 0;
+m_checkedButton = nullptr;
 
 if (m_members.isEmpty()) {
 ASSERT(!m_requiredCount);
@@ -190,11 +184,11 @@
 return;
 
 if (!m_nameToGroupMap)
-m_nameToGroupMap = adoptPtr(new NameToGroupMap);
+m_nameToGroupMap = std::make_unique();
 
-OwnPtr& group = m_nameToGroupMap->add(element->name().impl(), PassOwnPtr()).iterator->value;
+auto& group = m_nameToGroupMap->add(element->name().impl(), nullptr).iterator->value;
 if (!group)
-group = RadioButtonGroup::create();
+group = std::make_unique();
 group->add(element);
 }
 
@@ -263,7 +257,7 @@
 // of m_nameToGroupMap from AtomicStringImpl* to RefPtr.
 m_nameToGroupMap->remove(it);
 if (m_nameToGroupMap->isEmpty())
-m_nameToGroupMap.clear();
+m_nameToGroupMap = nullptr;
 }
 }
 


Modified: trunk/Source/WebCore/dom/CheckedRadioButtons.h (164424 => 164425)

--- trunk/Source/WebCore/dom/CheckedRadioButtons.h	2014-02-20 11:33:09 UTC (rev 164424)
+++ trunk/Source/WebCore/dom/CheckedRadioButtons.h	2014-02-20 12:29:53 UTC (rev 164425)
@@ -21,9 +21,9 @@
 #ifndef CheckedRadioButtons_h
 #define CheckedRadioButtons_h
 
+#include 
 #include 
 #include 
-#include 
 
 namespace WebCore {
 
@@ -44,8 +44,8 @@
 bool isInRequiredGroup(HTMLInputElement*) const;
 
 private:
-typedef HashMap> NameToGroupMap;
-OwnPtr m_nameToGroupMap;
+typedef HashMap> NameToGroupMap;
+std::unique_ptr m_nameToGroupMap;
 };

[webkit-changes] [164423] trunk

2014-02-20 Thread commit-queue

Title: [164423] trunk








Revision 164423
Author commit-qu...@webkit.org
Date 2014-02-20 02:24:14 -0800 (Thu, 20 Feb 2014)


Log Message
AX: Children Nodes for Canvas objects are not equal to Render Objects.
https://bugs.webkit.org/show_bug.cgi?id=123568

Patch by Artur Moryc  on 2014-02-20
Reviewed by Chris Fleizach.

Source/WebCore:

There is a difference in children nodes taken into account for RenderObject
and for NodeObject types. There is a problem with text nodes that are
focusable for EFL/GTK and therefore are not filtered out in the test like it
happens for the MAC port. Text nodes are eliminated in the
AccessibilityRenderObject::computeAccessibilityIsIgnored() method. The same
approach has been applied to the NodeObject to eliminate text nodes.

Covered by existing tests.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):

LayoutTests:

The canvas-accessibilitynodeobject.html test is not failing anymore.

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk1/TestExpectations
trunk/LayoutTests/platform/efl-wk2/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (164422 => 164423)

--- trunk/LayoutTests/ChangeLog	2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/LayoutTests/ChangeLog	2014-02-20 10:24:14 UTC (rev 164423)
@@ -1,3 +1,16 @@
+2014-02-20  Artur Moryc  
+
+AX: Children Nodes for Canvas objects are not equal to Render Objects.
+https://bugs.webkit.org/show_bug.cgi?id=123568
+
+Reviewed by Chris Fleizach.
+
+The canvas-accessibilitynodeobject.html test is not failing anymore.
+
+* platform/efl-wk1/TestExpectations:
+* platform/efl-wk2/TestExpectations:
+* platform/gtk/TestExpectations:
+
 2014-02-20  Frédéric Wang  
 
 Implement the MathML Operator Dictionary.


Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (164422 => 164423)

--- trunk/LayoutTests/platform/efl-wk1/TestExpectations	2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations	2014-02-20 10:24:14 UTC (rev 164423)
@@ -106,7 +106,6 @@
 webkit.org/b/111988 accessibility/aria-readonly.html [ Failure ]
 webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ]
 webkit.org/b/111992 accessibility/aria-used-on-image-maps.html [ Failure ]
-webkit.org/b/111994 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
 webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ]
 webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]
 webkit.org/b/122109 accessibility/file-upload-button-stringvalue.html [ Failure ]


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (164422 => 164423)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2014-02-20 10:24:14 UTC (rev 164423)
@@ -264,7 +264,6 @@
 webkit.org/b/111984 accessibility/aria-hidden-updates-alldescendants.html [ Failure ]
 webkit.org/b/111988 accessibility/aria-readonly.html [ Failure ]
 webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ]
-webkit.org/b/111994 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
 webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ]
 webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]
 webkit.org/b/112002 accessibility/inline-continuations.html [ Failure ]


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (164422 => 164423)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2014-02-20 10:24:14 UTC (rev 164423)
@@ -1249,8 +1249,6 @@
 # This failure appears to be GTK-specific
 webkit.org/b/91319 css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ]
 
-webkit.org/b/92100 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
-
 webkit.org/b/93976 fast/css-generated-content/quotes-lang.html [ ImageOnlyFailure ]
 
 # This has always failed on Gtk/Efl - exposed by bug 89826


Modified: trunk/Source/WebCore/ChangeLog (164422 => 164423)

--- trunk/Source/WebCore/ChangeLog	2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/Source/WebCore/ChangeLog	2014-02-20 10:24:14 UTC (rev 164423)
@@ -1,3 +1,22 @@
+2014-02-20  Artur Moryc  
+
+AX: Children Nodes for Canvas objects are not equal to Render Objects.
+https://bugs.webkit.org/show_bug.cgi?id=123568
+
+Reviewed by Chris Fleizach.
+
+There is a difference in children nodes taken into account for RenderObject
+and for NodeObject types. There is a problem with text nod

[webkit-changes] [164422] trunk/Source/WebCore

2014-02-20 Thread zandobersek

Title: [164422] trunk/Source/WebCore








Revision 164422
Author zandober...@gmail.com
Date 2014-02-20 01:57:03 -0800 (Thu, 20 Feb 2014)


Log Message
Move to using std::unique_ptr for KeyboardEvent, ScriptExecutionContext::PendingException
https://bugs.webkit.org/show_bug.cgi?id=129061

Reviewed by Andreas Kling.

Replace uses of OwnPtr and PassOwnPtr for KeyboardEvent and ScriptExecutionContext::PendingException
classes with std::unique_ptr. ScriptExecutionContext::Task objects are still handled through OwnPtr,
but this will be addressed later.

* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
* dom/KeyboardEvent.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::reportException):
(WebCore::ScriptExecutionContext::publicURLManager):
* dom/ScriptExecutionContext.h:
* dom/ScriptRunner.h: Remove an unnecessary PassOwnPtr header inclusion.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/KeyboardEvent.cpp
trunk/Source/WebCore/dom/KeyboardEvent.h
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/dom/ScriptRunner.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (164421 => 164422)

--- trunk/Source/WebCore/ChangeLog	2014-02-20 09:49:53 UTC (rev 164421)
+++ trunk/Source/WebCore/ChangeLog	2014-02-20 09:57:03 UTC (rev 164422)
@@ -1,5 +1,25 @@
 2014-02-20  Zan Dobersek  
 
+Move to using std::unique_ptr for KeyboardEvent, ScriptExecutionContext::PendingException
+https://bugs.webkit.org/show_bug.cgi?id=129061
+
+Reviewed by Andreas Kling.
+
+Replace uses of OwnPtr and PassOwnPtr for KeyboardEvent and ScriptExecutionContext::PendingException
+classes with std::unique_ptr. ScriptExecutionContext::Task objects are still handled through OwnPtr,
+but this will be addressed later.
+
+* dom/KeyboardEvent.cpp:
+(WebCore::KeyboardEvent::KeyboardEvent):
+* dom/KeyboardEvent.h:
+* dom/ScriptExecutionContext.cpp:
+(WebCore::ScriptExecutionContext::reportException):
+(WebCore::ScriptExecutionContext::publicURLManager):
+* dom/ScriptExecutionContext.h:
+* dom/ScriptRunner.h: Remove an unnecessary PassOwnPtr header inclusion.
+
+2014-02-20  Zan Dobersek  
+
 Move to using std::unique_ptr for EventListenerMap, EventTarget
 https://bugs.webkit.org/show_bug.cgi?id=129062
 


Modified: trunk/Source/WebCore/dom/KeyboardEvent.cpp (164421 => 164422)

--- trunk/Source/WebCore/dom/KeyboardEvent.cpp	2014-02-20 09:49:53 UTC (rev 164421)
+++ trunk/Source/WebCore/dom/KeyboardEvent.cpp	2014-02-20 09:57:03 UTC (rev 164422)
@@ -108,7 +108,7 @@
 KeyboardEvent::KeyboardEvent(const PlatformKeyboardEvent& key, AbstractView* view)
 : UIEventWithKeyState(eventTypeForKeyboardEventType(key.type()),
   true, true, key.timestamp(), view, 0, key.ctrlKey(), key.altKey(), key.shiftKey(), key.metaKey())
-, m_keyEvent(adoptPtr(new PlatformKeyboardEvent(key)))
+, m_keyEvent(std::make_unique(key))
 , m_keyIdentifier(key.keyIdentifier())
 , m_location(keyLocationCode(key))
 , m_altGraphKey(false)


Modified: trunk/Source/WebCore/dom/KeyboardEvent.h (164421 => 164422)

--- trunk/Source/WebCore/dom/KeyboardEvent.h	2014-02-20 09:49:53 UTC (rev 164421)
+++ trunk/Source/WebCore/dom/KeyboardEvent.h	2014-02-20 09:57:03 UTC (rev 164422)
@@ -25,6 +25,7 @@
 #define KeyboardEvent_h
 
 #include "UIEventWithKeyState.h"
+#include 
 #include 
 
 namespace WebCore {
@@ -113,7 +114,7 @@
 KeyboardEvent(const PlatformKeyboardEvent&, AbstractView*);
 KeyboardEvent(const AtomicString&, const KeyboardEventInit&);
 
-OwnPtr m_keyEvent;
+std::unique_ptr m_keyEvent;
 String m_keyIdentifier;
 unsigned m_location;
 bool m_altGraphKey : 1;


Modified: trunk/Source/WebCore/dom/ScriptExecutionContext.cpp (164421 => 164422)

--- trunk/Source/WebCore/dom/ScriptExecutionContext.cpp	2014-02-20 09:49:53 UTC (rev 164421)
+++ trunk/Source/WebCore/dom/ScriptExecutionContext.cpp	2014-02-20 09:57:03 UTC (rev 164422)
@@ -299,8 +299,8 @@
 {
 if (m_inDispatchErrorEvent) {
 if (!m_pendingExceptions)
-m_pendingExceptions = adoptPtr(new Vector>());
-m_pendingExceptions->append(adoptPtr(new PendingException(errorMessage, lineNumber, columnNumber, sourceURL, callStack)));
+m_pendingExceptions = std::make_unique>>();
+m_pendingExceptions->append(std::make_unique(errorMessage, lineNumber, columnNumber, sourceURL, callStack));
 return;
 }
 
@@ -311,11 +311,9 @@
 if (!m_pendingExceptions)
 return;
 
-for (size_t i = 0; i < m_pendingExceptions->size(); i++) {
-PendingException* e = m_pendingExceptions->at(i).get();
-logExceptionToConsole(e->m_errorMessage, e->m_sourceURL, e->m_lineNumber, e->m_columnNumber, e->m_callStack);
-}
-m_pendingExceptions.clear();
+for (auto& ex

[webkit-changes] [164421] trunk/Source/WebCore

2014-02-20 Thread zandobersek

Title: [164421] trunk/Source/WebCore








Revision 164421
Author zandober...@gmail.com
Date 2014-02-20 01:49:53 -0800 (Thu, 20 Feb 2014)


Log Message
Move to using std::unique_ptr for EventListenerMap, EventTarget
https://bugs.webkit.org/show_bug.cgi?id=129062

Reviewed by Andreas Kling.

Replace uses of OwnPtr and PassOwnPtr in the EventListenerMap and
EventTarget classes with std::unique_ptr.

* dom/EventListenerMap.cpp:
(WebCore::EventListenerMap::add):
* dom/EventListenerMap.h:
* dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
* dom/EventTarget.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventListenerMap.cpp
trunk/Source/WebCore/dom/EventListenerMap.h
trunk/Source/WebCore/dom/EventTarget.cpp
trunk/Source/WebCore/dom/EventTarget.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (164420 => 164421)

--- trunk/Source/WebCore/ChangeLog	2014-02-20 09:46:47 UTC (rev 164420)
+++ trunk/Source/WebCore/ChangeLog	2014-02-20 09:49:53 UTC (rev 164421)
@@ -1,5 +1,22 @@
 2014-02-20  Zan Dobersek  
 
+Move to using std::unique_ptr for EventListenerMap, EventTarget
+https://bugs.webkit.org/show_bug.cgi?id=129062
+
+Reviewed by Andreas Kling.
+
+Replace uses of OwnPtr and PassOwnPtr in the EventListenerMap and
+EventTarget classes with std::unique_ptr.
+
+* dom/EventListenerMap.cpp:
+(WebCore::EventListenerMap::add):
+* dom/EventListenerMap.h:
+* dom/EventTarget.cpp:
+(WebCore::EventTarget::fireEventListeners):
+* dom/EventTarget.h:
+
+2014-02-20  Zan Dobersek  
+
 Move to using std::unique_ptr for Document and related classes
 https://bugs.webkit.org/show_bug.cgi?id=129063
 


Modified: trunk/Source/WebCore/dom/EventListenerMap.cpp (164420 => 164421)

--- trunk/Source/WebCore/dom/EventListenerMap.cpp	2014-02-20 09:46:47 UTC (rev 164420)
+++ trunk/Source/WebCore/dom/EventListenerMap.cpp	2014-02-20 09:49:53 UTC (rev 164421)
@@ -130,7 +130,7 @@
 return addListenerToVector(m_entries[i].second.get(), listener, useCapture);
 }
 
-m_entries.append(std::make_pair(eventType, adoptPtr(new EventListenerVector)));
+m_entries.append(std::make_pair(eventType, std::make_unique()));
 return addListenerToVector(m_entries.last().second.get(), listener, useCapture);
 }
 


Modified: trunk/Source/WebCore/dom/EventListenerMap.h (164420 => 164421)

--- trunk/Source/WebCore/dom/EventListenerMap.h	2014-02-20 09:46:47 UTC (rev 164420)
+++ trunk/Source/WebCore/dom/EventListenerMap.h	2014-02-20 09:49:53 UTC (rev 164421)
@@ -34,8 +34,8 @@
 #define EventListenerMap_h
 
 #include "RegisteredEventListener.h"
+#include 
 #include 
-#include 
 #include 
 
 namespace WebCore {
@@ -66,7 +66,7 @@
 
 void assertNoActiveIterators();
 
-Vector>, 2> m_entries;
+Vector>, 2> m_entries;
 
 #ifndef NDEBUG
 int m_activeIteratorCount;


Modified: trunk/Source/WebCore/dom/EventTarget.cpp (164420 => 164421)

--- trunk/Source/WebCore/dom/EventTarget.cpp	2014-02-20 09:46:47 UTC (rev 164420)
+++ trunk/Source/WebCore/dom/EventTarget.cpp	2014-02-20 09:49:53 UTC (rev 164421)
@@ -255,7 +255,7 @@
 size_t i = 0;
 size_t size = entry.size();
 if (!d->firingEventIterators)
-d->firingEventIterators = adoptPtr(new FiringEventIteratorVector);
+d->firingEventIterators = std::make_unique();
 d->firingEventIterators->append(FiringEventIterator(event->type(), i, size));
 
 ScriptExecutionContext* context = scriptExecutionContext();


Modified: trunk/Source/WebCore/dom/EventTarget.h (164420 => 164421)

--- trunk/Source/WebCore/dom/EventTarget.h	2014-02-20 09:46:47 UTC (rev 164420)
+++ trunk/Source/WebCore/dom/EventTarget.h	2014-02-20 09:49:53 UTC (rev 164421)
@@ -35,6 +35,7 @@
 #include "EventListenerMap.h"
 #include "EventNames.h"
 #include "EventTargetInterfaces.h"
+#include 
 #include 
 #include 
 #include 
@@ -97,7 +98,7 @@
 ~EventTargetData();
 
 EventListenerMap eventListenerMap;
-OwnPtr firingEventIterators;
+std::unique_ptr firingEventIterators;
 };
 
 enum EventTargetInterface {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164420] trunk/Source/WebCore

2014-02-20 Thread zandobersek

Title: [164420] trunk/Source/WebCore








Revision 164420
Author zandober...@gmail.com
Date 2014-02-20 01:46:47 -0800 (Thu, 20 Feb 2014)


Log Message
Move to using std::unique_ptr for Document and related classes
https://bugs.webkit.org/show_bug.cgi?id=129063

Reviewed by Anders Carlsson.

Replace uses of OwnPtr and PassOwnPtr in the Document and related classes with std::unique_ptr.

* dom/DOMImplementation.h:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::removedLastRef):
(WebCore::Document::selectorQueryCache):
(WebCore::Document::implementation):
(WebCore::Document::formController):
(WebCore::Document::createStyleResolver):
(WebCore::Document::clearStyleResolver):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::setParsing):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::setTransformSource):
(WebCore::Document::accessSVGExtensions):
(WebCore::Document::sharedObjectPoolClearTimerFired):
(WebCore::Document::didAddTouchEventHandler):
* dom/Document.h:
* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::DocumentEventQueue):
* dom/DocumentEventQueue.h:
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
* dom/DocumentMarkerController.h:
* dom/DocumentSharedObjectPool.cpp:
* dom/DocumentSharedObjectPool.h:
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::activeStyleSheetsContains):
* dom/DocumentStyleSheetCollection.h:
* dom/DocumentType.h:
* html/FormController.h:
* rendering/TextAutosizer.h:
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMImplementation.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/DocumentEventQueue.cpp
trunk/Source/WebCore/dom/DocumentEventQueue.h
trunk/Source/WebCore/dom/DocumentMarkerController.cpp
trunk/Source/WebCore/dom/DocumentMarkerController.h
trunk/Source/WebCore/dom/DocumentSharedObjectPool.cpp
trunk/Source/WebCore/dom/DocumentSharedObjectPool.h
trunk/Source/WebCore/dom/DocumentStyleSheetCollection.cpp
trunk/Source/WebCore/dom/DocumentStyleSheetCollection.h
trunk/Source/WebCore/dom/DocumentType.h
trunk/Source/WebCore/html/FormController.h
trunk/Source/WebCore/rendering/TextAutosizer.h
trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164419 => 164420)

--- trunk/Source/WebCore/ChangeLog	2014-02-20 09:10:50 UTC (rev 164419)
+++ trunk/Source/WebCore/ChangeLog	2014-02-20 09:46:47 UTC (rev 164420)
@@ -1,3 +1,48 @@
+2014-02-20  Zan Dobersek  
+
+Move to using std::unique_ptr for Document and related classes
+https://bugs.webkit.org/show_bug.cgi?id=129063
+
+Reviewed by Anders Carlsson.
+
+Replace uses of OwnPtr and PassOwnPtr in the Document and related classes with std::unique_ptr.
+
+* dom/DOMImplementation.h:
+* dom/Document.cpp:
+(WebCore::Document::Document):
+(WebCore::Document::removedLastRef):
+(WebCore::Document::selectorQueryCache):
+(WebCore::Document::implementation):
+(WebCore::Document::formController):
+(WebCore::Document::createStyleResolver):
+(WebCore::Document::clearStyleResolver):
+(WebCore::Document::clearAXObjectCache):
+(WebCore::Document::axObjectCache):
+(WebCore::Document::setParsing):
+(WebCore::Document::styleResolverChanged):
+(WebCore::Document::setTransformSource):
+(WebCore::Document::accessSVGExtensions):
+(WebCore::Document::sharedObjectPoolClearTimerFired):
+(WebCore::Document::didAddTouchEventHandler):
+* dom/Document.h:
+* dom/DocumentEventQueue.cpp:
+(WebCore::DocumentEventQueue::DocumentEventQueue):
+* dom/DocumentEventQueue.h:
+* dom/DocumentMarkerController.cpp:
+(WebCore::DocumentMarkerController::addMarker):
+* dom/DocumentMarkerController.h:
+* dom/DocumentSharedObjectPool.cpp:
+* dom/DocumentSharedObjectPool.h:
+* dom/DocumentStyleSheetCollection.cpp:
+(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
+(WebCore::DocumentStyleSheetCollection::activeStyleSheetsContains):
+* dom/DocumentStyleSheetCollection.h:
+* dom/DocumentType.h:
+* html/FormController.h:
+* rendering/TextAutosizer.h:
+* xml/parser/XMLDocumentParserLibxml2.cpp:
+(WebCore::XMLDocumentParser::doEnd):
+
 2014-02-20  Mihnea Ovidenie  
 
 [CSSRegions] Add helper method for region clipping flow content


Modified: trunk/Source/WebCore/dom/DOMImplementation.h (164419 => 164420)

--- trunk/Source/WebCore/dom/DOMImplementation.h	2014-02-20 09:10:50 UTC (rev 164419)
+++ trunk/Source/WebCore/dom/DOMImplemen

48 matches

Mail list logo