[webkit-changes] [166045] trunk/Source/JavaScriptCore
Title: [166045] trunk/Source/_javascript_Core
Revision 166045
Author fpi...@apple.com
Date 2014-03-20 23:51:18 -0700 (Thu, 20 Mar 2014)
Log Message
FTL should correctly compile GetByVal on Uint32Array that claims to return non-int32 values
https://bugs.webkit.org/show_bug.cgi?id=130562
Reviewed by Geoffrey Garen.
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
* tests/stress/uint32array-unsigned-load.js: Added.
(foo):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
Added Paths
trunk/Source/_javascript_Core/tests/stress/uint32array-unsigned-load.js
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (166044 => 166045)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-21 06:44:44 UTC (rev 166044)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-21 06:51:18 UTC (rev 166045)
@@ -1,3 +1,16 @@
+2014-03-20 Filip Pizlo
+
+FTL should correctly compile GetByVal on Uint32Array that claims to return non-int32 values
+https://bugs.webkit.org/show_bug.cgi?id=130562
+
+
+Reviewed by Geoffrey Garen.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
+* tests/stress/uint32array-unsigned-load.js: Added.
+(foo):
+
2014-03-20 Brian Burg
Web Inspector: add frontend controller and models for replay sessions
Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (166044 => 166045)
--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-03-21 06:44:44 UTC (rev 166044)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-03-21 06:51:18 UTC (rev 166045)
@@ -2042,6 +2042,11 @@
return;
}
+if (m_node->shouldSpeculateMachineInt()) {
+setStrictInt52(m_out.zeroExt(result, m_out.int64));
+return;
+}
+
setDouble(m_out.unsignedToFP(result, m_out.doubleType));
return;
}
Added: trunk/Source/_javascript_Core/tests/stress/uint32array-unsigned-load.js (0 => 166045)
--- trunk/Source/_javascript_Core/tests/stress/uint32array-unsigned-load.js (rev 0)
+++ trunk/Source/_javascript_Core/tests/stress/uint32array-unsigned-load.js 2014-03-21 06:51:18 UTC (rev 166045)
@@ -0,0 +1,15 @@
+function foo(a) {
+return a[0] + 1;
+}
+
+noInline(foo);
+
+var a = new Uint32Array(1);
+a[0] = -1;
+
+for (var i = 0; i < 1; ++i) {
+var result = foo(a);
+if (result != 4294967296)
+throw "Error: bad result: " + result;
+}
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166044] trunk/Source/WebCore
Title: [166044] trunk/Source/WebCore
Revision 166044
Author da...@apple.com
Date 2014-03-20 23:44:44 -0700 (Thu, 20 Mar 2014)
Log Message
Remove a couple of unused functions from CSSOMUtils
https://bugs.webkit.org/show_bug.cgi?id=130558
Reviewed by Andreas Kling.
* css/CSSOMUtils.cpp: Remove String overloads. Callers all use the StringBuilder
ones, which is good since that is a more efficient idiom.
* css/CSSOMUtils.h: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSOMUtils.cpp
trunk/Source/WebCore/css/CSSOMUtils.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (166043 => 166044)
--- trunk/Source/WebCore/ChangeLog 2014-03-21 06:44:06 UTC (rev 166043)
+++ trunk/Source/WebCore/ChangeLog 2014-03-21 06:44:44 UTC (rev 166044)
@@ -1,3 +1,14 @@
+2014-03-20 Darin Adler
+
+Remove a couple of unused functions from CSSOMUtils
+https://bugs.webkit.org/show_bug.cgi?id=130558
+
+Reviewed by Andreas Kling.
+
+* css/CSSOMUtils.cpp: Remove String overloads. Callers all use the StringBuilder
+ones, which is good since that is a more efficient idiom.
+* css/CSSOMUtils.h: Ditto.
+
2014-03-20 Pratik Solanki
Unreviewed. iOS build fix after r166017, r166032.
Modified: trunk/Source/WebCore/css/CSSOMUtils.cpp (166043 => 166044)
--- trunk/Source/WebCore/css/CSSOMUtils.cpp 2014-03-21 06:44:06 UTC (rev 166043)
+++ trunk/Source/WebCore/css/CSSOMUtils.cpp 2014-03-21 06:44:44 UTC (rev 166044)
@@ -49,13 +49,6 @@
appendTo.append(' ');
}
-void serializeIdentifier(const String& identifier, String& appendTo)
-{
-StringBuilder addend;
-serializeIdentifier(identifier, addend);
-appendTo.append(addend.toString());
-}
-
void serializeIdentifier(const String& identifier, StringBuilder& appendTo)
{
bool isFirst = true;
@@ -85,13 +78,6 @@
}
}
-void serializeString(const String& string, String& appendTo)
-{
-StringBuilder addend;
-serializeString(string, addend);
-appendTo.append(addend.toString());
-}
-
void serializeString(const String& string, StringBuilder& appendTo)
{
appendTo.append('\"');
Modified: trunk/Source/WebCore/css/CSSOMUtils.h (166043 => 166044)
--- trunk/Source/WebCore/css/CSSOMUtils.h 2014-03-21 06:44:06 UTC (rev 166043)
+++ trunk/Source/WebCore/css/CSSOMUtils.h 2014-03-21 06:44:44 UTC (rev 166044)
@@ -40,12 +40,10 @@
namespace WebCore {
// Common serializing methods. See: http://dev.w3.org/csswg/cssom/#common-serializing-idioms
-void serializeCharacter(UChar32, StringBuilder& appendTo);
-void serializeCharacterAsCodePoint(UChar32, StringBuilder& appendTo);
-void serializeIdentifier(const String& identifier, String& appendTo);
-void serializeIdentifier(const String& identifier, StringBuilder& appendTo);
-void serializeString(const String&, String& appendTo);
-void serializeString(const String&, StringBuilder& appendTo);
+void serializeCharacter(UChar32, StringBuilder&);
+void serializeCharacterAsCodePoint(UChar32, StringBuilder&);
+void serializeIdentifier(const String& identifier, StringBuilder&);
+void serializeString(const String&, StringBuilder&);
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166043] trunk/Source/WTF
Title: [166043] trunk/Source/WTF Revision 166043 Author da...@apple.com Date 2014-03-20 23:44:06 -0700 (Thu, 20 Mar 2014) Log Message Fix a header guard mistake (harmless but clearly wrong) https://bugs.webkit.org/show_bug.cgi?id=130559 Reviewed by Andreas Kling. * wtf/text/StringConcatenate.h: Correct the macro name in the header guard. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/text/StringConcatenate.h Diff Modified: trunk/Source/WTF/ChangeLog (166042 => 166043) --- trunk/Source/WTF/ChangeLog 2014-03-21 06:30:10 UTC (rev 166042) +++ trunk/Source/WTF/ChangeLog 2014-03-21 06:44:06 UTC (rev 166043) @@ -1,3 +1,12 @@ +2014-03-20 Darin Adler + +Fix a header guard mistake (harmless but clearly wrong) +https://bugs.webkit.org/show_bug.cgi?id=130559 + +Reviewed by Andreas Kling. + +* wtf/text/StringConcatenate.h: Correct the macro name in the header guard. + 2014-03-20 Hyowon Kim Move to using std::unique_ptr for EFL objects. Modified: trunk/Source/WTF/wtf/text/StringConcatenate.h (166042 => 166043) --- trunk/Source/WTF/wtf/text/StringConcatenate.h 2014-03-21 06:30:10 UTC (rev 166042) +++ trunk/Source/WTF/wtf/text/StringConcatenate.h 2014-03-21 06:44:06 UTC (rev 166043) @@ -28,7 +28,7 @@ #include -#ifndef WTFString_h +#ifndef AtomicString_h #include #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166042] trunk/Source/WebCore
Title: [166042] trunk/Source/WebCore Revision 166042 Author psola...@apple.com Date 2014-03-20 23:30:10 -0700 (Thu, 20 Mar 2014) Log Message Unreviewed. iOS build fix after r166017, r166032. * platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRectInternal): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ScrollView.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (166041 => 166042) --- trunk/Source/WebCore/ChangeLog 2014-03-21 05:26:21 UTC (rev 166041) +++ trunk/Source/WebCore/ChangeLog 2014-03-21 06:30:10 UTC (rev 166042) @@ -1,3 +1,10 @@ +2014-03-20 Pratik Solanki + +Unreviewed. iOS build fix after r166017, r166032. + +* platform/ScrollView.cpp: +(WebCore::ScrollView::visibleContentRectInternal): + 2014-03-20 Hyowon Kim Move to using std::unique_ptr for EFL objects. Modified: trunk/Source/WebCore/platform/ScrollView.cpp (166041 => 166042) --- trunk/Source/WebCore/platform/ScrollView.cpp 2014-03-21 05:26:21 UTC (rev 166041) +++ trunk/Source/WebCore/platform/ScrollView.cpp 2014-03-21 06:30:10 UTC (rev 166042) @@ -307,7 +307,11 @@ return m_fixedVisibleContentRect; #endif +#if PLATFORM(IOS) +return unobscuredContentRect(); +#else return unobscuredContentRect(scrollbarInclusion); +#endif } #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166041] trunk/Source/WebInspectorUI
Title: [166041] trunk/Source/WebInspectorUI Revision 166041 Author bb...@apple.com Date 2014-03-20 22:26:21 -0700 (Thu, 20 Mar 2014) Log Message Web Inspector: add temporary buttons to capture/play/pause replay recordings https://bugs.webkit.org/show_bug.cgi?id=129692 Reviewed by Timothy Hatcher. If the Replay agent is available, replace the existing ad-hoc navigation bar in the Timelines sidebar panel with a record and pause/play button. This UI is temporary. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Controllers/ReplayManager.js: Turn two segment state assertions into FIXMEs because the assertions are too strong until the public API uses async chains. (WebInspector.ReplayManager.prototype.replayToMarkIndex): (WebInspector.ReplayManager.prototype.replayToCompletion): * UserInterface/Images/Circle.svg: Added. * UserInterface/Views/ActivateButtonNavigationItem.js: (WebInspector.ActivateButtonNavigationItem.prototype.generateStyleText): * UserInterface/Views/ButtonNavigationItem.css: Adjust styles so the default style has opacity:1 and the glyph color is darker. (.navigation-bar .item.button.suppress-emboss > .glyph): (.navigation-bar .item.button.suppress-emboss.disabled > .glyph): * UserInterface/Views/ButtonNavigationItem.js: (WebInspector.ButtonNavigationItem.prototype.generateStyleText): Explicitly generate the width and height properties so that separate button instances do not influence the size of each other. * UserInterface/Views/TimelineSidebarPanel.js: (WebInspector.TimelineSidebarPanel.prototype._recordGlyphClicked): (WebInspector.TimelineSidebarPanel.prototype._replayCaptureButtonClicked): (WebInspector.TimelineSidebarPanel.prototype._replayPauseResumeButtonClicked): (WebInspector.TimelineSidebarPanel.prototype._captureStarted): (WebInspector.TimelineSidebarPanel.prototype._captureStopped): (WebInspector.TimelineSidebarPanel.prototype._playbackStarted): (WebInspector.TimelineSidebarPanel.prototype._playbackPaused): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js trunk/Source/WebInspectorUI/UserInterface/Views/ActivateButtonNavigationItem.js trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.js trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js Added Paths trunk/Source/WebInspectorUI/UserInterface/Images/Circle.svg Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (166040 => 166041) --- trunk/Source/WebInspectorUI/ChangeLog 2014-03-21 04:45:14 UTC (rev 166040) +++ trunk/Source/WebInspectorUI/ChangeLog 2014-03-21 05:26:21 UTC (rev 166041) @@ -1,5 +1,42 @@ 2014-03-20 Brian Burg +Web Inspector: add temporary buttons to capture/play/pause replay recordings +https://bugs.webkit.org/show_bug.cgi?id=129692 + +Reviewed by Timothy Hatcher. + +If the Replay agent is available, replace the existing ad-hoc navigation bar +in the Timelines sidebar panel with a record and pause/play button. This UI +is temporary. + +* Localizations/en.lproj/localizedStrings.js: +* UserInterface/Controllers/ReplayManager.js: Turn two segment state assertions into +FIXMEs because the assertions are too strong until the public API uses async chains. +(WebInspector.ReplayManager.prototype.replayToMarkIndex): +(WebInspector.ReplayManager.prototype.replayToCompletion): +* UserInterface/Images/Circle.svg: Added. +* UserInterface/Views/ActivateButtonNavigationItem.js: +(WebInspector.ActivateButtonNavigationItem.prototype.generateStyleText): +* UserInterface/Views/ButtonNavigationItem.css: Adjust styles so the default style +has opacity:1 and the glyph color is darker. +(.navigation-bar .item.button.suppress-emboss > .glyph): +(.navigation-bar .item.button.suppress-emboss.disabled > .glyph): +* UserInterface/Views/ButtonNavigationItem.js: +(WebInspector.ButtonNavigationItem.prototype.generateStyleText): Explicitly +generate the width and height properties so that separate button instances do +not influence the size of each other. + +* UserInterface/Views/TimelineSidebarPanel.js: +(WebInspector.TimelineSidebarPanel.prototype._recordGlyphClicked): +(WebInspector.TimelineSidebarPanel.prototype._replayCaptureButtonClicked): +(WebInspector.TimelineSidebarPanel.prototype._replayPauseResumeButtonClicked): +(WebInspector.TimelineSidebarPanel.prototype._captureStarted): +(WebInspector.TimelineSidebarPanel.prototype._captureStopped): +(WebInspector.TimelineSidebarPanel.prototype._playbackStarted): +(WebInspector.TimelineSidebarPanel.prototype._playbackPaused): + +2014-03-20 Brian Burg + Web I
[webkit-changes] [166038] trunk/PerformanceTests
Title: [166038] trunk/PerformanceTests Revision 166038 Author zol...@webkit.org Date 2014-03-20 21:05:05 -0700 (Thu, 20 Mar 2014) Log Message Add option for hiding Confidence Interval Delta on the performance tests results page https://bugs.webkit.org/show_bug.cgi?id=130483 Reviewed by Ryosuke Niwa. I've found it useful to hide the confidence interval delta from the results table sometimes, for example on copying data, or for a clearer look. This patch introduces a new button for it on the local results page. * resources/results-template.html: Modified Paths trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/resources/results-template.html Diff Modified: trunk/PerformanceTests/ChangeLog (166037 => 166038) --- trunk/PerformanceTests/ChangeLog 2014-03-21 03:47:26 UTC (rev 166037) +++ trunk/PerformanceTests/ChangeLog 2014-03-21 04:05:05 UTC (rev 166038) @@ -1,3 +1,16 @@ +2014-03-20 Zoltan Horvath + +Add option for hiding Confidence Interval Delta on the performance tests results page +https://bugs.webkit.org/show_bug.cgi?id=130483 + +Reviewed by Ryosuke Niwa. + +I've found it useful to hide the confidence interval delta from the results table +sometimes, for example on copying data, or for a clearer look. This patch introduces +a new button for it on the local results page. + +* resources/results-template.html: + 2014-03-20 Laszlo Vidacs Optimize RenderTable::colToEffCol() for tables without colspans Modified: trunk/PerformanceTests/resources/results-template.html (166037 => 166038) --- trunk/PerformanceTests/resources/results-template.html 2014-03-21 03:47:26 UTC (rev 166037) +++ trunk/PerformanceTests/resources/results-template.html 2014-03-21 04:05:05 UTC (rev 166038) @@ -132,6 +132,7 @@ Result TimeMemory Reference +CIΔ ShowHide
[webkit-changes] [166037] trunk
Title: [166037] trunk
Revision 166037
Author thiago.lace...@openbossa.org
Date 2014-03-20 20:47:26 -0700 (Thu, 20 Mar 2014)
Log Message
[EFL][GTK] Get CMake to find Freetype2 properly
https://bugs.webkit.org/show_bug.cgi?id=130150
Reviewed by Martin Robinson.
Newer versions of CMake are not able to find Freetype2 correctly.
FindFreetype2.cmake checks for the version number in freetype.h header, since it seems that bug exists in
freetype2 repo, because a completely different version number is found in freetype2.pc.
.:
* Source/cmake/FindFreetype2.cmake: Added.
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:
Source/WebCore:
* PlatformEfl.cmake:
* PlatformGTK.cmake:
Source/WebKit:
* PlatformEfl.cmake:
Source/WebKit2:
* PlatformEfl.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformEfl.cmake
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/cmake/OptionsEfl.cmake
trunk/Source/cmake/OptionsGTK.cmake
Added Paths
trunk/Source/cmake/FindFreetype2.cmake
Diff
Modified: trunk/ChangeLog (166036 => 166037)
--- trunk/ChangeLog 2014-03-21 03:13:46 UTC (rev 166036)
+++ trunk/ChangeLog 2014-03-21 03:47:26 UTC (rev 166037)
@@ -1,3 +1,18 @@
+2014-03-20 Thiago de Barros Lacerda
+
+[EFL][GTK] Get CMake to find Freetype2 properly
+https://bugs.webkit.org/show_bug.cgi?id=130150
+
+Reviewed by Martin Robinson.
+
+Newer versions of CMake are not able to find Freetype2 correctly.
+FindFreetype2.cmake checks for the version number in freetype.h header, since it seems that bug exists in
+freetype2 repo, because a completely different version number is found in freetype2.pc.
+
+* Source/cmake/FindFreetype2.cmake: Added.
+* Source/cmake/OptionsEfl.cmake:
+* Source/cmake/OptionsGTK.cmake:
+
2014-03-20 Brian Burg
Web Replay: capture and replay mouse events
Modified: trunk/Source/WebCore/ChangeLog (166036 => 166037)
--- trunk/Source/WebCore/ChangeLog 2014-03-21 03:13:46 UTC (rev 166036)
+++ trunk/Source/WebCore/ChangeLog 2014-03-21 03:47:26 UTC (rev 166037)
@@ -1,3 +1,17 @@
+2014-03-20 Thiago de Barros Lacerda
+
+[EFL][GTK] Get CMake to find Freetype2 properly
+https://bugs.webkit.org/show_bug.cgi?id=130150
+
+Reviewed by Martin Robinson.
+
+Newer versions of CMake are not able to find Freetype2 correctly.
+FindFreetype2.cmake checks for the version number in freetype.h header, since it seems that bug exists in
+freetype2 repo, because a completely different version number is found in freetype2.pc.
+
+* PlatformEfl.cmake:
+* PlatformGTK.cmake:
+
2014-03-20 Martin Robinson
[GTK] Suppress errors about using gdk_threads_enter gdk_threads_leave
Modified: trunk/Source/WebCore/PlatformEfl.cmake (166036 => 166037)
--- trunk/Source/WebCore/PlatformEfl.cmake 2014-03-21 03:13:46 UTC (rev 166036)
+++ trunk/Source/WebCore/PlatformEfl.cmake 2014-03-21 03:47:26 UTC (rev 166037)
@@ -221,7 +221,7 @@
${E_DBUS_EUKIT_LIBRARIES}
${E_DBUS_LIBRARIES}
${FONTCONFIG_LIBRARIES}
-${FREETYPE_LIBRARIES}
+${FREETYPE2_LIBRARIES}
${GLIB_GIO_LIBRARIES}
${GLIB_GOBJECT_LIBRARIES}
${GLIB_LIBRARIES}
@@ -248,7 +248,7 @@
${EEZE_INCLUDE_DIRS}
${EINA_INCLUDE_DIRS}
${EVAS_INCLUDE_DIRS}
-${FREETYPE_INCLUDE_DIRS}
+${FREETYPE2_INCLUDE_DIRS}
${LIBXML2_INCLUDE_DIR}
${LIBXSLT_INCLUDE_DIR}
${SQLITE_INCLUDE_DIR}
Modified: trunk/Source/WebCore/PlatformGTK.cmake (166036 => 166037)
--- trunk/Source/WebCore/PlatformGTK.cmake 2014-03-21 03:13:46 UTC (rev 166036)
+++ trunk/Source/WebCore/PlatformGTK.cmake 2014-03-21 03:47:26 UTC (rev 166037)
@@ -293,7 +293,7 @@
${CAIRO_LIBRARIES}
${ENCHANT_LIBRARIES}
${FONTCONFIG_LIBRARIES}
-${FREETYPE_LIBRARIES}
+${FREETYPE2_LIBRARIES}
${GEOCLUE_LIBRARIES}
${GLIB_GIO_LIBRARIES}
${GLIB_GMODULE_LIBRARIES}
@@ -322,7 +322,7 @@
${ATK_INCLUDE_DIRS}
${CAIRO_INCLUDE_DIRS}
${ENCHANT_INCLUDE_DIRS}
-${FREETYPE_INCLUDE_DIRS}
+${FREETYPE2_INCLUDE_DIRS}
${GEOCLUE_INCLUDE_DIRS}
${GIO_UNIX_INCLUDE_DIRS}
${GLIB_INCLUDE_DIRS}
Modified: trunk/Source/WebKit/ChangeLog (166036 => 166037)
--- trunk/Source/WebKit/ChangeLog 2014-03-21 03:13:46 UTC (rev 166036)
+++ trunk/Source/WebKit/ChangeLog 2014-03-21 03:47:26 UTC (rev 166037)
@@ -1,3 +1,16 @@
+2014-03-20 Thiago de Barros Lacerda
+
+[EFL][GTK] Get CMake to find Freetype2 properly
+https://bugs.webkit.org/show_bug.cgi?id=130150
+
+Reviewed by Martin Robinson.
+
+Newer versions of CMake are not able to find Freetype2 correctly.
+FindFreetype2.cmake checks for the version number in freetype.h header, since it seems that bug exists
[webkit-changes] [166035] trunk/Source
Title: [166035] trunk/Source Revision 166035 Author mrobin...@webkit.org Date 2014-03-20 20:00:59 -0700 (Thu, 20 Mar 2014) Log Message [GTK] Suppress errors about using gdk_threads_enter gdk_threads_leave https://bugs.webkit.org/show_bug.cgi?id=130517 Reviewed by Sergio Villar Senin. Source/WebCore: * plugins/gtk/gtk2xtbin.c: Use GCC suppression to suppress errors about deprecations. Source/WebKit2: * UIProcess/API/gtk/WebKitWebView.cpp: Use GCC suppression to suppress errors about deprecations. * UIProcess/gtk/WebPopupMenuProxyGtk.cpp: Ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/plugins/gtk/gtk2xtbin.c trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (166034 => 166035) --- trunk/Source/WebCore/ChangeLog 2014-03-21 01:41:21 UTC (rev 166034) +++ trunk/Source/WebCore/ChangeLog 2014-03-21 03:00:59 UTC (rev 166035) @@ -1,3 +1,12 @@ +2014-03-20 Martin Robinson + +[GTK] Suppress errors about using gdk_threads_enter gdk_threads_leave +https://bugs.webkit.org/show_bug.cgi?id=130517 + +Reviewed by Sergio Villar Senin. + +* plugins/gtk/gtk2xtbin.c: Use GCC suppression to suppress errors about deprecations. + 2014-03-20 Simon Fraser Cleanup in aisle r166017. Modified: trunk/Source/WebCore/plugins/gtk/gtk2xtbin.c (166034 => 166035) --- trunk/Source/WebCore/plugins/gtk/gtk2xtbin.c 2014-03-21 01:41:21 UTC (rev 166034) +++ trunk/Source/WebCore/plugins/gtk/gtk2xtbin.c 2014-03-21 03:00:59 UTC (rev 166035) @@ -65,6 +65,9 @@ #include #include +// This is to suppress warnings about gdk_threads_leave and gdk_threads_enter. +#pragma GCC diagnostic ignored "-Wdeprecated-declarations" + /* uncomment this if you want debugging information about widget creation and destruction */ #undef DEBUG_XTBIN Modified: trunk/Source/WebKit2/ChangeLog (166034 => 166035) --- trunk/Source/WebKit2/ChangeLog 2014-03-21 01:41:21 UTC (rev 166034) +++ trunk/Source/WebKit2/ChangeLog 2014-03-21 03:00:59 UTC (rev 166035) @@ -1,3 +1,13 @@ +2014-03-20 Martin Robinson + +[GTK] Suppress errors about using gdk_threads_enter gdk_threads_leave +https://bugs.webkit.org/show_bug.cgi?id=130517 + +Reviewed by Sergio Villar Senin. + +* UIProcess/API/gtk/WebKitWebView.cpp: Use GCC suppression to suppress errors about deprecations. +* UIProcess/gtk/WebPopupMenuProxyGtk.cpp: Ditto. + 2014-03-20 Ryuan Choi [EFL][WK2] tests of test_ewk2_cookie_manager are flaky Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (166034 => 166035) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-03-21 01:41:21 UTC (rev 166034) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-03-21 03:00:59 UTC (rev 166035) @@ -1646,9 +1646,14 @@ g_signal_emit(webView, signals[RUN_AS_MODAL], 0, NULL); webView->priv->modalLoop = adoptGRef(g_main_loop_new(0, FALSE)); + +// This is to suppress warnings about gdk_threads_leave and gdk_threads_enter. +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wdeprecated-declarations" gdk_threads_leave(); g_main_loop_run(webView->priv->modalLoop.get()); gdk_threads_enter(); +#pragma GCC diagnostic pop } void webkitWebViewClosePage(WebKitWebView* webView) Modified: trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp (166034 => 166035) --- trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp 2014-03-21 01:41:21 UTC (rev 166034) +++ trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp 2014-03-21 03:00:59 UTC (rev 166035) @@ -97,9 +97,13 @@ // menu right after calling WebPopupMenuProxy::showPopupMenu(). m_runLoop = adoptGRef(g_main_loop_new(0, FALSE)); +// This is to suppress warnings about gdk_threads_leave and gdk_threads_enter. +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wdeprecated-declarations" gdk_threads_leave(); g_main_loop_run(m_runLoop.get()); gdk_threads_enter(); +#pragma GCC diagnostic pop m_runLoop.clear(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166032] trunk/Source/WebCore
Title: [166032] trunk/Source/WebCore
Revision 166032
Author simon.fra...@apple.com
Date 2014-03-20 18:16:40 -0700 (Thu, 20 Mar 2014)
Log Message
Cleanup in aisle r166017.
visibleContentRectInternal() was dropping the scrollbar
inclusiveness on the floor, and we need to reset the top inset
between tests.
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRectInternal):
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/testing/Internals.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166031 => 166032)
--- trunk/Source/WebCore/ChangeLog 2014-03-21 00:57:31 UTC (rev 166031)
+++ trunk/Source/WebCore/ChangeLog 2014-03-21 01:16:40 UTC (rev 166032)
@@ -1,3 +1,16 @@
+2014-03-20 Simon Fraser
+
+Cleanup in aisle r166017.
+
+visibleContentRectInternal() was dropping the scrollbar
+inclusiveness on the floor, and we need to reset the top inset
+between tests.
+
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::visibleContentRectInternal):
+* testing/Internals.cpp:
+(WebCore::Internals::resetToConsistentState):
+
2014-03-20 Enrica Casucci
Build fix.
Modified: trunk/Source/WebCore/platform/ScrollView.cpp (166031 => 166032)
--- trunk/Source/WebCore/platform/ScrollView.cpp 2014-03-21 00:57:31 UTC (rev 166031)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2014-03-21 01:16:40 UTC (rev 166032)
@@ -307,7 +307,7 @@
return m_fixedVisibleContentRect;
#endif
-return unobscuredContentRect();
+return unobscuredContentRect(scrollbarInclusion);
}
#endif
Modified: trunk/Source/WebCore/testing/Internals.cpp (166031 => 166032)
--- trunk/Source/WebCore/testing/Internals.cpp 2014-03-21 00:57:31 UTC (rev 166031)
+++ trunk/Source/WebCore/testing/Internals.cpp 2014-03-21 01:16:40 UTC (rev 166032)
@@ -272,6 +272,7 @@
if (mainFrameView) {
mainFrameView->setHeaderHeight(0);
mainFrameView->setFooterHeight(0);
+page->setTopContentInset(0);
}
TextRun::setAllowsRoundingHacks(false);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166031] trunk/Source/WebKit2
Title: [166031] trunk/Source/WebKit2
Revision 166031
Author commit-qu...@webkit.org
Date 2014-03-20 17:57:31 -0700 (Thu, 20 Mar 2014)
Log Message
Unreviewed, rolling out r165985.
https://bugs.webkit.org/show_bug.cgi?id=130551
broke page loading on all cocoa platforms (Requested by
thorton on #webkit).
Reverted changeset:
"[WebKit2] Implement
NetworkingContext::sourceApplicationAuditData() for WebKit2"
https://bugs.webkit.org/show_bug.cgi?id=130528
http://trac.webkit.org/changeset/165985
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm
trunk/Source/WebKit2/Platform/IPC/Connection.h
trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166030 => 166031)
--- trunk/Source/WebKit2/ChangeLog 2014-03-21 00:32:37 UTC (rev 166030)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-21 00:57:31 UTC (rev 166031)
@@ -1,3 +1,18 @@
+2014-03-20 Commit Queue
+
+Unreviewed, rolling out r165985.
+https://bugs.webkit.org/show_bug.cgi?id=130551
+
+broke page loading on all cocoa platforms (Requested by
+thorton on #webkit).
+
+Reverted changeset:
+
+"[WebKit2] Implement
+NetworkingContext::sourceApplicationAuditData() for WebKit2"
+https://bugs.webkit.org/show_bug.cgi?id=130528
+http://trac.webkit.org/changeset/165985
+
2014-03-20 Alexey Proskuryakov
Fix a long-standing typo that's now breaking USE(ASYNC_NSTEXTINPUTCLIENT) build.
Modified: trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm (166030 => 166031)
--- trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm 2014-03-21 00:32:37 UTC (rev 166030)
+++ trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm 2014-03-21 00:57:31 UTC (rev 166031)
@@ -26,7 +26,6 @@
#import "config.h"
#import "RemoteNetworkingContext.h"
-#import "NetworkProcess.h"
#import "SessionTracker.h"
#import "WebErrors.h"
#import
@@ -70,11 +69,7 @@
RetainPtr RemoteNetworkingContext::sourceApplicationAuditData() const
{
-audit_token_t auditToken;
-if (!NetworkProcess::shared().parentProcessConnection()->getAuditToken(auditToken))
-return nullptr;
-
-return adoptCF(CFDataCreate(0, (const UInt8*)&auditToken, sizeof(auditToken)));
+return nil;
}
ResourceError RemoteNetworkingContext::blockedError(const ResourceRequest& request) const
Modified: trunk/Source/WebKit2/Platform/IPC/Connection.h (166030 => 166031)
--- trunk/Source/WebKit2/Platform/IPC/Connection.h 2014-03-21 00:32:37 UTC (rev 166030)
+++ trunk/Source/WebKit2/Platform/IPC/Connection.h 2014-03-21 00:57:31 UTC (rev 166031)
@@ -114,7 +114,7 @@
};
static bool identifierIsNull(Identifier identifier) { return identifier.port == MACH_PORT_NULL; }
xpc_connection_t xpcConnection() { return m_xpcConnection; }
-bool getAuditToken(audit_token_t&);
+
#elif USE(UNIX_DOMAIN_SOCKETS)
typedef int Identifier;
static bool identifierIsNull(Identifier identifier) { return !identifier; }
Modified: trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp (166030 => 166031)
--- trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp 2014-03-21 00:32:37 UTC (rev 166030)
+++ trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp 2014-03-21 00:57:31 UTC (rev 166031)
@@ -35,12 +35,6 @@
#include
#include
-#if __has_include()
-#include
-#else
-extern "C" void xpc_connection_get_audit_token(xpc_connection_t, audit_token_t*);
-#endif
-
namespace IPC {
static const size_t inlineMessageMaxSize = 4096;
@@ -517,13 +511,4 @@
return Identifier(m_isServer ? m_receivePort : m_sendPort, m_xpcConnection);
}
-bool Connection::getAuditToken(audit_token_t& auditToken)
-{
-if (!m_xpcConnection)
-return false;
-
-xpc_connection_get_audit_token(m_xpcConnection, &auditToken);
-return true;
-}
-
} // namespace IPC
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm (166030 => 166031)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm 2014-03-21 00:32:37 UTC (rev 166030)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm 2014-03-21 00:57:31 UTC (rev 166031)
@@ -24,11 +24,10 @@
*/
#include "config.h"
-#include "WebFrameNetworkingContext.h"
#include "SessionTracker.h"
#include "WebCookieManager.h"
-#include "WebProcess.h"
+#include "WebFrameNetworkingContext.h"
#include "WebPage.h"
#include
#include
@@ -91,11 +90,7 @@
RetainPtr WebFrameNetworkingContext::sourceApplicationAuditData() const
{
-audit_token_t auditToken;
-if (!WebProcess::shared().parentProcessConnection()->getAuditToken(auditToken))
-return nullptr;
-
-return adoptCF(CFDataCreate(0, (const UInt8*)&auditToken, sizeof(auditToken)))
[webkit-changes] [166030] trunk/Source/JavaScriptCore
Title: [166030] trunk/Source/_javascript_Core
Revision 166030
Author fpi...@apple.com
Date 2014-03-20 17:32:37 -0700 (Thu, 20 Mar 2014)
Log Message
FTL ValueToInt32 mishandles the constant case, and by the way, there is a constant case that the FTL sees
https://bugs.webkit.org/show_bug.cgi?id=130546
Reviewed by Mark Hahnenberg.
Make AI do a better job of folding this.
Also made the FTL backend be more tolerant of data representations. In this case it
didn't know that "constant" was a valid representation. There is a finite set of
possible representations, but broadly, we don't write code that presumes anything
about the representation of an input; that's what methods like lowJSValue() are for.
ValueToInt32 was previously not relying on those methods at all because it had some
hacks. Now, those hacks are just a fast-path optimization but ultimately we fall down
to lowJSValue().
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileValueToInt32):
(JSC::FTL::LowerDFGToLLVM::numberOrNotCellToInt32):
* tests/stress/value-to-int32-undefined-constant.js: Added.
(foo):
* tests/stress/value-to-int32-undefined.js: Added.
(foo):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
Added Paths
trunk/Source/_javascript_Core/tests/stress/value-to-int32-undefined-constant.js
trunk/Source/_javascript_Core/tests/stress/value-to-int32-undefined.js
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (166029 => 166030)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-21 00:21:30 UTC (rev 166029)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-21 00:32:37 UTC (rev 166030)
@@ -1,3 +1,31 @@
+2014-03-20 Filip Pizlo
+
+FTL ValueToInt32 mishandles the constant case, and by the way, there is a constant case that the FTL sees
+https://bugs.webkit.org/show_bug.cgi?id=130546
+
+
+Reviewed by Mark Hahnenberg.
+
+Make AI do a better job of folding this.
+
+Also made the FTL backend be more tolerant of data representations. In this case it
+didn't know that "constant" was a valid representation. There is a finite set of
+possible representations, but broadly, we don't write code that presumes anything
+about the representation of an input; that's what methods like lowJSValue() are for.
+ValueToInt32 was previously not relying on those methods at all because it had some
+hacks. Now, those hacks are just a fast-path optimization but ultimately we fall down
+to lowJSValue().
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileValueToInt32):
+(JSC::FTL::LowerDFGToLLVM::numberOrNotCellToInt32):
+* tests/stress/value-to-int32-undefined-constant.js: Added.
+(foo):
+* tests/stress/value-to-int32-undefined.js: Added.
+(foo):
+
2014-03-20 Mark Hahnenberg
Add some assertions back
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (166029 => 166030)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2014-03-21 00:21:30 UTC (rev 166029)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2014-03-21 00:32:37 UTC (rev 166030)
@@ -297,6 +297,10 @@
setConstant(node, JSValue(child.asBoolean()));
break;
}
+if (child.isUndefinedOrNull()) {
+setConstant(node, jsNumber(0));
+break;
+}
}
forNode(node).setType(SpecInt32);
Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (166029 => 166030)
--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-03-21 00:21:30 UTC (rev 166029)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-03-21 00:32:37 UTC (rev 166030)
@@ -651,59 +651,7 @@
value = m_jsValueValues.get(m_node->child1().node());
if (isValid(value)) {
-LBasicBlock intCase = FTL_NEW_BLOCK(m_out, ("ValueToInt32 int case"));
-LBasicBlock notIntCase = FTL_NEW_BLOCK(m_out, ("ValueToInt32 not int case"));
-LBasicBlock doubleCase = 0;
-LBasicBlock notNumberCase = 0;
-if (m_node->child1().useKind() == NotCellUse) {
-doubleCase = FTL_NEW_BLOCK(m_out, ("ValueToInt32 double case"));
-notNumberCase = FTL_NEW_BLOCK(m_out, ("ValueToInt32 not number case"));
-}
-LBasicBlock continuation = FTL_NEW_BLOCK(m_out, ("ValueToInt32 continuation"));
-
-Vector res
[webkit-changes] [166029] trunk/Source/WebKit2
Title: [166029] trunk/Source/WebKit2 Revision 166029 Author a...@apple.com Date 2014-03-20 17:21:30 -0700 (Thu, 20 Mar 2014) Log Message Fix a long-standing typo that's now breaking USE(ASYNC_NSTEXTINPUTCLIENT) build. Rubber-stamped by Tim Horton. * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::cancelComposition): Use a correct type for reply (it's really the same type, but ConfirmComposition is behind an ifdef, and not available). Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (166028 => 166029) --- trunk/Source/WebKit2/ChangeLog 2014-03-21 00:10:50 UTC (rev 166028) +++ trunk/Source/WebKit2/ChangeLog 2014-03-21 00:21:30 UTC (rev 166029) @@ -1,3 +1,13 @@ +2014-03-20 Alexey Proskuryakov + +Fix a long-standing typo that's now breaking USE(ASYNC_NSTEXTINPUTCLIENT) build. + +Rubber-stamped by Tim Horton. + +* UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::cancelComposition): +Use a correct type for reply (it's really the same type, but ConfirmComposition +is behind an ifdef, and not available). + 2014-03-20 Enrica Casucci [iOS WebKit2] typing and deleting text lags behind the caret movement on google.com. Modified: trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm (166028 => 166029) --- trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm 2014-03-21 00:10:50 UTC (rev 166028) +++ trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm 2014-03-21 00:21:30 UTC (rev 166029) @@ -280,7 +280,7 @@ if (!isValid()) return; -process().sendSync(Messages::WebPage::CancelComposition(), Messages::WebPage::ConfirmComposition::Reply(m_editorState), m_pageID); +process().sendSync(Messages::WebPage::CancelComposition(), Messages::WebPage::CancelComposition::Reply(m_editorState), m_pageID); } void WebPageProxy::insertDictatedTextAsync(const String& text, const EditingRange& replacementRange, const Vector& dictationAlternativesWithRange) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166028] trunk/Source/JavaScriptCore
Title: [166028] trunk/Source/_javascript_Core
Revision 166028
Author mhahnenb...@apple.com
Date 2014-03-20 17:10:50 -0700 (Thu, 20 Mar 2014)
Log Message
Add some assertions back
https://bugs.webkit.org/show_bug.cgi?id=130531
Reviewed by Geoffrey Garen.
We removed a useful set of assertions for verifying that MarkedBlocks were
in the state that we expected them to be in after clearing marks in the Heap.
We should add these back to catch bugs earlier.
* heap/MarkedBlock.h:
* heap/MarkedSpace.cpp:
(JSC::VerifyMarkedOrRetired::operator()):
(JSC::MarkedSpace::clearMarks):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MarkedBlock.h
trunk/Source/_javascript_Core/heap/MarkedSpace.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (166027 => 166028)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-21 00:07:34 UTC (rev 166027)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-21 00:10:50 UTC (rev 166028)
@@ -1,3 +1,19 @@
+2014-03-20 Mark Hahnenberg
+
+Add some assertions back
+https://bugs.webkit.org/show_bug.cgi?id=130531
+
+Reviewed by Geoffrey Garen.
+
+We removed a useful set of assertions for verifying that MarkedBlocks were
+in the state that we expected them to be in after clearing marks in the Heap.
+We should add these back to catch bugs earlier.
+
+* heap/MarkedBlock.h:
+* heap/MarkedSpace.cpp:
+(JSC::VerifyMarkedOrRetired::operator()):
+(JSC::MarkedSpace::clearMarks):
+
2014-03-20 Filip Pizlo
Implement stackmap header version check and support new stackmap formats
Modified: trunk/Source/_javascript_Core/heap/MarkedBlock.h (166027 => 166028)
--- trunk/Source/_javascript_Core/heap/MarkedBlock.h 2014-03-21 00:07:34 UTC (rev 166027)
+++ trunk/Source/_javascript_Core/heap/MarkedBlock.h 2014-03-21 00:10:50 UTC (rev 166028)
@@ -71,7 +71,7 @@
class MarkedBlock : public HeapBlock {
friend class LLIntOffsetsExtractor;
-
+friend struct VerifyMarkedOrRetired;
public:
static const size_t atomSize = 16; // bytes
static const size_t atomShiftAmount = 4; // log_2(atomSize) FIXME: Change atomSize to 16.
Modified: trunk/Source/_javascript_Core/heap/MarkedSpace.cpp (166027 => 166028)
--- trunk/Source/_javascript_Core/heap/MarkedSpace.cpp 2014-03-21 00:07:34 UTC (rev 166027)
+++ trunk/Source/_javascript_Core/heap/MarkedSpace.cpp 2014-03-21 00:10:50 UTC (rev 166028)
@@ -317,6 +317,21 @@
#endif
}
+#ifndef NDEBUG
+struct VerifyMarkedOrRetired : MarkedBlock::VoidFunctor {
+void operator()(MarkedBlock* block)
+{
+switch (block->m_state) {
+case MarkedBlock::Marked:
+case MarkedBlock::Retired:
+return;
+default:
+RELEASE_ASSERT_NOT_REACHED();
+}
+}
+};
+#endif
+
void MarkedSpace::clearMarks()
{
if (m_heap->operationInProgress() == EdenCollection) {
@@ -324,6 +339,11 @@
m_blocksWithNewObjects[i]->clearMarks();
} else
forEachBlock();
+
+#ifndef NDEBUG
+VerifyMarkedOrRetired verifyFunctor;
+forEachBlock(verifyFunctor);
+#endif
}
void MarkedSpace::willStartIterating()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166027] trunk/Source/WebKit2
Title: [166027] trunk/Source/WebKit2
Revision 166027
Author enr...@apple.com
Date 2014-03-20 17:07:34 -0700 (Thu, 20 Mar 2014)
Log Message
[iOS WebKit2] typing and deleting text lags behind the caret movement on google.com.
https://bugs.webkit.org/show_bug.cgi?id=130544
Reviewed by Tim Horton.
On iOS the selection is drawn in the UIProcess. If the WebProcess is
processing multiple requests within the same runloop, the caret could be
updated in the UIProcess before the WebProcess has had a chance to paint.
This change synchronizes the selection drawing with the tile update.
* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _didCommitLayerTree:WebKit::]):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _selectionChanged]):
(-[WKContentView _updateChangedSelection]):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeSelection):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166026 => 166027)
--- trunk/Source/WebKit2/ChangeLog 2014-03-21 00:04:44 UTC (rev 166026)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-21 00:07:34 UTC (rev 166027)
@@ -1,3 +1,26 @@
+2014-03-20 Enrica Casucci
+
+[iOS WebKit2] typing and deleting text lags behind the caret movement on google.com.
+https://bugs.webkit.org/show_bug.cgi?id=130544
+
+
+Reviewed by Tim Horton.
+
+On iOS the selection is drawn in the UIProcess. If the WebProcess is
+processing multiple requests within the same runloop, the caret could be
+updated in the UIProcess before the WebProcess has had a chance to paint.
+This change synchronizes the selection drawing with the tile update.
+
+* UIProcess/WebPageProxy.h:
+* UIProcess/ios/WKContentView.mm:
+(-[WKContentView _didCommitLayerTree:WebKit::]):
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _selectionChanged]):
+(-[WKContentView _updateChangedSelection]):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::didChangeSelection):
+
2014-03-20 Alexey Proskuryakov
Generalize WebInspector check in maybeInitializeSandboxExtensionHandle().
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm (166026 => 166027)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm 2014-03-21 00:04:44 UTC (rev 166026)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm 2014-03-21 00:07:34 UTC (rev 166027)
@@ -294,6 +294,7 @@
[_rootContentView setFrame:CGRectMake(0, 0, contentsSize.width, contentsSize.height)];
[_webView _didCommitLayerTree:layerTreeTransaction];
+[self _updateChangedSelection];
}
- (void)_setAcceleratedCompositingRootView:(UIView *)rootView
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (166026 => 166027)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h 2014-03-21 00:04:44 UTC (rev 166026)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h 2014-03-21 00:07:34 UTC (rev 166027)
@@ -110,6 +110,7 @@
BOOL _showingTextStyleOptions;
BOOL _hasValidPositionInformation;
BOOL _isTapHighlightIDValid;
+BOOL _selectionNeedsUpdate;
}
@end
@@ -129,6 +130,7 @@
- (void)_startAssistingNode:(const WebKit::AssistedNodeInformation&)information;
- (void)_stopAssistingNode;
- (void)_selectionChanged;
+- (void)_updateChangedSelection;
- (BOOL)_interpretKeyEvent:(WebIOSEvent *)theEvent isCharEvent:(BOOL)isCharEvent;
- (void)_positionInformationDidChange:(const WebKit::InteractionInformationAtPosition&)info;
- (void)_attemptClickAtLocation:(CGPoint)location;
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (166026 => 166027)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-03-21 00:04:44 UTC (rev 166026)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-03-21 00:07:34 UTC (rev 166027)
@@ -1918,6 +1918,14 @@
- (void)_selectionChanged
{
+_selectionNeedsUpdate = YES;
+}
+
+- (void)_updateChangedSelection
+{
+if (!_selectionNeedsUpdate)
+return;
+
// FIXME: We need to figure out what to do if the selection is changed by _javascript_.
if (_textSelectionAssistant) {
_markedText = (_page->editorState().hasComposition) ? _page->editorState().markedText : String();
@@ -1925,6 +1933,7 @@
[_textSelectionAssistant selectionChanged];
} else
[_webSelectionAssistant selectionChanged];
+_selectionNeedsUpdate = NO;
}
#pragma mark - Implementation of UIWebTouchEventsGestureRecognizerDelegate.
Modifie
[webkit-changes] [166026] trunk/Source/WebKit2
Title: [166026] trunk/Source/WebKit2
Revision 166026
Author a...@apple.com
Date 2014-03-20 17:04:44 -0700 (Thu, 20 Mar 2014)
Log Message
Generalize WebInspector check in maybeInitializeSandboxExtensionHandle().
https://bugs.webkit.org/show_bug.cgi?id=130079
Reviewed by Anders Carlsson.
* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
Perform an early return for all paths that don't need a sandbox extension due to
access being assumed, not only for WebInspector pages.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::hasAssumedReadAccessToURL):
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
* UIProcess/WebProcessProxy.h:
Factored out m_localPathsWithAssumedReadAccess iteration to a public function.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166025 => 166026)
--- trunk/Source/WebKit2/ChangeLog 2014-03-21 00:03:58 UTC (rev 166025)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-21 00:04:44 UTC (rev 166026)
@@ -1,3 +1,21 @@
+2014-03-20 Alexey Proskuryakov
+
+Generalize WebInspector check in maybeInitializeSandboxExtensionHandle().
+https://bugs.webkit.org/show_bug.cgi?id=130079
+
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
+Perform an early return for all paths that don't need a sandbox extension due to
+access being assumed, not only for WebInspector pages.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::hasAssumedReadAccessToURL):
+(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
+* UIProcess/WebProcessProxy.h:
+Factored out m_localPathsWithAssumedReadAccess iteration to a public function.
+
2014-03-20 Csaba Osztrogonác
Unreviewed buildfix after r165983 for non Cocoa platforms.
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (166025 => 166026)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-03-21 00:03:58 UTC (rev 166025)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-03-21 00:04:44 UTC (rev 166026)
@@ -627,10 +627,12 @@
if (!url.isLocalFile())
return false;
+if (m_process->hasAssumedReadAccessToURL(url))
+return false;
+
#if ENABLE(INSPECTOR)
-// Don't give the inspector full access to the file system.
-if (WebInspectorProxy::isInspectorPage(*this))
-return false;
+// Inspector resources are in a directory with assumed access.
+ASSERT_WITH_SECURITY_IMPLICATION(!WebInspectorProxy::isInspectorPage(*this));
#endif
SandboxExtension::createHandle("/", SandboxExtension::ReadOnly, sandboxExtensionHandle);
Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (166025 => 166026)
--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2014-03-21 00:03:58 UTC (rev 166025)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2014-03-21 00:04:44 UTC (rev 166026)
@@ -240,6 +240,21 @@
m_localPathsWithAssumedReadAccess.add(baseURL.fileSystemPath());
}
+bool WebProcessProxy::hasAssumedReadAccessToURL(const URL& url) const
+{
+if (!url.isLocalFile())
+return false;
+
+String path = url.fileSystemPath();
+for (const String& assumedAccessPath : m_localPathsWithAssumedReadAccess) {
+// There are no ".." components, because URL removes those.
+if (path.startsWith(assumedAccessPath))
+return true;
+}
+
+return false;
+}
+
bool WebProcessProxy::checkURLReceivedFromWebProcess(const String& urlString)
{
return checkURLReceivedFromWebProcess(URL(URL(), urlString));
@@ -258,15 +273,12 @@
return true;
// If we loaded a string with a file base URL before, loading resources from that subdirectory is fine.
-// There are no ".." components, because all URLs received from WebProcess are parsed with URL, which removes those.
-String path = url.fileSystemPath();
-for (HashSet::const_iterator iter = m_localPathsWithAssumedReadAccess.begin(); iter != m_localPathsWithAssumedReadAccess.end(); ++iter) {
-if (path.startsWith(*iter))
-return true;
-}
+if (hasAssumedReadAccessToURL(url))
+return true;
// Items in back/forward list have been already checked.
// One case where we don't have sandbox extensions for file URLs in b/f list is if the list has been reinstated after a crash or a browser restart.
+String path = url.fileSystemPath();
for (WebBackForwardListItemMap::iterator iter = m_backForwardListItemMap.begin(), end = m_backForwardListItemMap.end(); iter != end; ++iter) {
if (URL(URL(), iter->value->url()).fileSystemPath() == path)
return true;
Modified: trunk/Source/WebK
[webkit-changes] [166025] trunk/Source/WebKit2
Title: [166025] trunk/Source/WebKit2 Revision 166025 Author o...@webkit.org Date 2014-03-20 17:03:58 -0700 (Thu, 20 Mar 2014) Log Message Unreviewed buildfix after r165983 for non Cocoa platforms. * UIProcess/API/C/WKAPICast.h: * UIProcess/API/C/WKPreferences.cpp: * UIProcess/efl/WebInspectorProxyEfl.cpp: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (166024 => 166025) --- trunk/Source/WebKit2/ChangeLog 2014-03-21 00:03:41 UTC (rev 166024) +++ trunk/Source/WebKit2/ChangeLog 2014-03-21 00:03:58 UTC (rev 166025) @@ -1,3 +1,11 @@ +2014-03-20 Csaba Osztrogonác + +Unreviewed buildfix after r165983 for non Cocoa platforms. + +* UIProcess/API/C/WKAPICast.h: +* UIProcess/API/C/WKPreferences.cpp: +* UIProcess/efl/WebInspectorProxyEfl.cpp: + 2014-03-20 Beth Dakin Implement contentInset for Mac WebKit2 Modified: trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h (166024 => 166025) --- trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h 2014-03-21 00:03:41 UTC (rev 166024) +++ trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h 2014-03-21 00:03:58 UTC (rev 166025) @@ -39,8 +39,8 @@ #include "WKCookieManager.h" #include "WKCredentialTypes.h" #include "WKPage.h" -#include "WKPreferencesPrivate.h" #include "WKPreferencesRef.h" +#include "WKPreferencesRefPrivate.h" #include "WKProtectionSpaceTypes.h" #include "WKResourceCacheManager.h" #include "WKSharedAPICast.h" Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (166024 => 166025) --- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2014-03-21 00:03:41 UTC (rev 166024) +++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2014-03-21 00:03:58 UTC (rev 166025) @@ -24,9 +24,9 @@ */ #include "config.h" -#include "WKPreferencesPrivate.h" + #include "WKPreferencesRef.h" - +#include "WKPreferencesRefPrivate.h" #include "WKAPICast.h" #include "WebContext.h" #include "WebPreferences.h" Modified: trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp (166024 => 166025) --- trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp 2014-03-21 00:03:41 UTC (rev 166024) +++ trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp 2014-03-21 00:03:58 UTC (rev 166025) @@ -39,7 +39,6 @@ #include #include #include -#include #include #include #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166024] trunk/Source/WebCore
Title: [166024] trunk/Source/WebCore Revision 166024 Author enr...@apple.com Date 2014-03-20 17:03:41 -0700 (Thu, 20 Mar 2014) Log Message Build fix. Removing unused variable. * page/FrameView.cpp: (WebCore::FrameView::didPaintContents): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FrameView.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (166023 => 166024) --- trunk/Source/WebCore/ChangeLog 2014-03-20 23:55:09 UTC (rev 166023) +++ trunk/Source/WebCore/ChangeLog 2014-03-21 00:03:41 UTC (rev 166024) @@ -1,3 +1,12 @@ +2014-03-20 Enrica Casucci + +Build fix. + +Removing unused variable. + +* page/FrameView.cpp: +(WebCore::FrameView::didPaintContents): + 2014-03-20 Brent Fulgham Rename TextTrackRegion/TextTrackRegionList to VTTRegion/VTTRegionList Modified: trunk/Source/WebCore/page/FrameView.cpp (166023 => 166024) --- trunk/Source/WebCore/page/FrameView.cpp 2014-03-20 23:55:09 UTC (rev 166023) +++ trunk/Source/WebCore/page/FrameView.cpp 2014-03-21 00:03:41 UTC (rev 166024) @@ -3534,10 +3534,9 @@ memoryCache()->pruneLiveResources(true); #endif -Document* document = frame().document(); // Regions may have changed as a result of the visibility/z-index of element changing. #if ENABLE(DASHBOARD_SUPPORT) -if (document->annotatedRegionsDirty()) +if (frame().document()->annotatedRegionsDirty()) updateAnnotatedRegions(); #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166023] trunk/Source/WebKit
Title: [166023] trunk/Source/WebKit Revision 166023 Author bda...@apple.com Date 2014-03-20 16:55:09 -0700 (Thu, 20 Mar 2014) Log Message Speculative build fix. * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in Diff Modified: trunk/Source/WebKit/ChangeLog (166022 => 166023) --- trunk/Source/WebKit/ChangeLog 2014-03-20 23:47:16 UTC (rev 166022) +++ trunk/Source/WebKit/ChangeLog 2014-03-20 23:55:09 UTC (rev 166023) @@ -1,3 +1,9 @@ +2014-03-20 Beth Dakin + +Speculative build fix. + +* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: + 2014-03-20 Alex Christensen Build fixes for Win64. Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in (166022 => 166023) --- trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in 2014-03-20 23:47:16 UTC (rev 166022) +++ trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in 2014-03-20 23:55:09 UTC (rev 166023) @@ -277,6 +277,7 @@ symbolWithPointer(?setCanStartMedia@Page@WebCore@@QAEX_N@Z, ?setCanStartMedia@Page@WebCore@@QEAAX_N@Z) symbolWithPointer(?setCursiveFontFamily@Settings@WebCore@@QAEXABVAtomicString@WTF@@W4UScriptCode@@@Z, ?setCursiveFontFamily@Settings@WebCore@@QEAAXAEBVAtomicString@WTF@@W4UScriptCode@@@Z) symbolWithPointer(?setDeviceScaleFactor@Page@WebCore@@QAEXM@Z, ?setDeviceScaleFactor@Page@WebCore@@QEAAXM@Z) +symbolWithPointer(?setTopContentInset@Page@WebCore@@QAEXM@Z, ?setTopContentInset@Page@WebCore@@QEAAXM@Z) symbolWithPointer(?setDOMException@WebCore@@YAXPAVExecState@JSC@@H@Z, ?setDOMException@WebCore@@YAXPEAVExecState@JSC@@H@Z) symbolWithPointer(?setFantasyFontFamily@Settings@WebCore@@QAEXABVAtomicString@WTF@@W4UScriptCode@@@Z, ?setFantasyFontFamily@Settings@WebCore@@QEAAXAEBVAtomicString@WTF@@W4UScriptCode@@@Z) symbolWithPointer(?setFixedFontFamily@Settings@WebCore@@QAEXABVAtomicString@WTF@@W4UScriptCode@@@Z, ?setFixedFontFamily@Settings@WebCore@@QEAAXAEBVAtomicString@WTF@@W4UScriptCode@@@Z) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166021] trunk/Source/WebCore
Title: [166021] trunk/Source/WebCore
Revision 166021
Author simon.fra...@apple.com
Date 2014-03-20 16:43:33 -0700 (Thu, 20 Mar 2014)
Log Message
Fix the iOS build.
* page/FrameView.cpp:
(WebCore::FrameView::willPaintContents):
(WebCore::FrameView::didPaintContents):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166020 => 166021)
--- trunk/Source/WebCore/ChangeLog 2014-03-20 23:39:00 UTC (rev 166020)
+++ trunk/Source/WebCore/ChangeLog 2014-03-20 23:43:33 UTC (rev 166021)
@@ -1,3 +1,11 @@
+2014-03-20 Simon Fraser
+
+Fix the iOS build.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::willPaintContents):
+(WebCore::FrameView::didPaintContents):
+
2014-03-20 Hans Muller
[CSS Shapes] clamp RasterShape shapeMargin to reference box size
Modified: trunk/Source/WebCore/page/FrameView.cpp (166020 => 166021)
--- trunk/Source/WebCore/page/FrameView.cpp 2014-03-20 23:39:00 UTC (rev 166020)
+++ trunk/Source/WebCore/page/FrameView.cpp 2014-03-20 23:43:33 UTC (rev 166021)
@@ -3481,7 +3481,7 @@
#if PLATFORM(IOS)
// FIXME: Remove PLATFORM(IOS)-guard once we upstream the iOS changes to MemoryPressureHandler.h.
-if (isTopLevelPainter && memoryPressureHandler().hasReceivedMemoryPressure()) {
+if (paintingState.isTopLevelPainter && memoryPressureHandler().hasReceivedMemoryPressure()) {
LOG(MemoryPressure, "Under memory pressure: %s", __PRETTY_FUNCTION__);
// To avoid unnecessary image decoding, we don't prune recently-decoded live resources here since
@@ -3530,7 +3530,7 @@
// Painting can lead to decoding of large amounts of bitmaps
// If we are low on memory, wipe them out after the paint.
// FIXME: Remove PLATFORM(IOS)-guard once we upstream the iOS changes to MemoryPressureHandler.h.
-if (isTopLevelPainter && memoryPressureHandler().hasReceivedMemoryPressure())
+if (paintingState.isTopLevelPainter && memoryPressureHandler().hasReceivedMemoryPressure())
memoryCache()->pruneLiveResources(true);
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166020] trunk/Source/WebKit/mac
Title: [166020] trunk/Source/WebKit/mac Revision 166020 Author ander...@apple.com Date 2014-03-20 16:39:00 -0700 (Thu, 20 Mar 2014) Log Message Fix build. * MigrateHeaders.make: Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/MigrateHeaders.make Diff Modified: trunk/Source/WebKit/mac/ChangeLog (166019 => 166020) --- trunk/Source/WebKit/mac/ChangeLog 2014-03-20 23:31:55 UTC (rev 166019) +++ trunk/Source/WebKit/mac/ChangeLog 2014-03-20 23:39:00 UTC (rev 166020) @@ -1,3 +1,9 @@ +2014-03-20 Anders Carlsson + +Fix build. + +* MigrateHeaders.make: + 2014-03-20 Pratik Solanki [iOS] Get code to compile on older iOS versions Modified: trunk/Source/WebKit/mac/MigrateHeaders.make (166019 => 166020) --- trunk/Source/WebKit/mac/MigrateHeaders.make 2014-03-20 23:31:55 UTC (rev 166019) +++ trunk/Source/WebKit/mac/MigrateHeaders.make 2014-03-20 23:39:00 UTC (rev 166020) @@ -282,6 +282,7 @@ WKWebViewPrivate.h \ _WKActivatedElementInfo.h \ _WKElementAction.h \ +_WKProcessPoolConfiguration.h \ _WKThumbnailView.h \ # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166018] trunk/Source/WebCore
Title: [166018] trunk/Source/WebCore
Revision 166018
Author bda...@apple.com
Date 2014-03-20 16:30:56 -0700 (Thu, 20 Mar 2014)
Log Message
Build fix.
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166017 => 166018)
--- trunk/Source/WebCore/ChangeLog 2014-03-20 23:19:04 UTC (rev 166017)
+++ trunk/Source/WebCore/ChangeLog 2014-03-20 23:30:56 UTC (rev 166018)
@@ -1,5 +1,12 @@
2014-03-20 Beth Dakin
+Build fix.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::paintContents):
+
+2014-03-20 Beth Dakin
+
Implement contentInset for Mac WebKit2
https://bugs.webkit.org/show_bug.cgi?id=130273
Modified: trunk/Source/WebCore/page/FrameView.cpp (166017 => 166018)
--- trunk/Source/WebCore/page/FrameView.cpp 2014-03-20 23:19:04 UTC (rev 166017)
+++ trunk/Source/WebCore/page/FrameView.cpp 2014-03-20 23:30:56 UTC (rev 166018)
@@ -3553,11 +3553,9 @@
void FrameView::paintContents(GraphicsContext* context, const IntRect& dirtyRect)
{
-Document* document = frame().document();
-
#ifndef NDEBUG
bool fillWithRed;
-if (document->printing())
+if (frame().document()->printing())
fillWithRed = false; // Printing, don't fill with red (can't remember why).
else if (frame().ownerElement())
fillWithRed = false; // Subframe, don't fill with red.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166015] trunk/Source/WebCore
Title: [166015] trunk/Source/WebCore
Revision 166015
Author simon.fra...@apple.com
Date 2014-03-20 16:14:31 -0700 (Thu, 20 Mar 2014)
Log Message
FrameView::paintContents() is not called for composited content
https://bugs.webkit.org/show_bug.cgi?id=130541
Reviewed by Beth Dakin.
FrameView::paintContents() is not called for frames that have
composited contents, yet it contains code that is expected
to run for all Frames.
Fix by factoring into will/didPaintContents(), and calling
the will/did functions from RenderLayerBacking::paintIntoLayer().
Also add a SetLayoutNeededForbiddenScope check for composited-layer
painting.
* page/FrameView.cpp:
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::willPaintContents):
(WebCore::FrameView::didPaintContents):
(WebCore::FrameView::paintContents):
* page/FrameView.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166014 => 166015)
--- trunk/Source/WebCore/ChangeLog 2014-03-20 23:09:45 UTC (rev 166014)
+++ trunk/Source/WebCore/ChangeLog 2014-03-20 23:14:31 UTC (rev 166015)
@@ -1,3 +1,29 @@
+2014-03-20 Simon Fraser
+
+FrameView::paintContents() is not called for composited content
+https://bugs.webkit.org/show_bug.cgi?id=130541
+
+Reviewed by Beth Dakin.
+
+FrameView::paintContents() is not called for frames that have
+composited contents, yet it contains code that is expected
+to run for all Frames.
+
+Fix by factoring into will/didPaintContents(), and calling
+the will/did functions from RenderLayerBacking::paintIntoLayer().
+
+Also add a SetLayoutNeededForbiddenScope check for composited-layer
+painting.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::updateControlTints):
+(WebCore::FrameView::willPaintContents):
+(WebCore::FrameView::didPaintContents):
+(WebCore::FrameView::paintContents):
+* page/FrameView.h:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::paintIntoLayer):
+
2014-03-20 Tim Horton
Fix the Mountain Lion build.
Modified: trunk/Source/WebCore/page/FrameView.cpp (166014 => 166015)
--- trunk/Source/WebCore/page/FrameView.cpp 2014-03-20 23:09:45 UTC (rev 166014)
+++ trunk/Source/WebCore/page/FrameView.cpp 2014-03-20 23:14:31 UTC (rev 166015)
@@ -3461,43 +3461,15 @@
adjustTiledBackingCoverage();
}
-void FrameView::paintContents(GraphicsContext* p, const IntRect& rect)
+void FrameView::willPaintContents(GraphicsContext* context, const IntRect& dirtyRect, PaintingState& paintingState)
{
Document* document = frame().document();
-#ifndef NDEBUG
-bool fillWithRed;
-if (document->printing())
-fillWithRed = false; // Printing, don't fill with red (can't remember why).
-else if (frame().ownerElement())
-fillWithRed = false; // Subframe, don't fill with red.
-else if (isTransparent())
-fillWithRed = false; // Transparent, don't fill with red.
-else if (m_paintBehavior & PaintBehaviorSelectionOnly)
-fillWithRed = false; // Selections are transparent, don't fill with red.
-else if (m_nodeToDraw)
-fillWithRed = false; // Element images are transparent, don't fill with red.
-else
-fillWithRed = true;
-
-if (fillWithRed)
-p->fillRect(rect, Color(0xFF, 0, 0), ColorSpaceDeviceRGB);
-#endif
+if (!context->paintingDisabled())
+InspectorInstrumentation::willPaint(renderView());
-RenderView* renderView = this->renderView();
-if (!renderView) {
-LOG_ERROR("called FrameView::paint with nil renderer");
-return;
-}
+paintingState.isTopLevelPainter = !sCurrentPaintTimeStamp;
-ASSERT(!needsLayout());
-if (needsLayout())
-return;
-
-if (!p->paintingDisabled())
-InspectorInstrumentation::willPaint(renderView);
-
-bool isTopLevelPainter = !sCurrentPaintTimeStamp;
#if PLATFORM(IOS)
// FIXME: Remove PLATFORM(IOS)-guard once we upstream the iOS changes to MemoryPressureHandler.h.
if (isTopLevelPainter && memoryPressureHandler().hasReceivedMemoryPressure()) {
@@ -3508,15 +3480,13 @@
memoryCache()->prune();
}
#endif
-if (isTopLevelPainter)
+if (paintingState.isTopLevelPainter)
sCurrentPaintTimeStamp = monotonicallyIncreasingTime();
-FontCachePurgePreventer fontCachePurgePreventer;
-
-if (!p->paintingDisabled() && !document->printing())
+if (!context->paintingDisabled() && !document->printing())
flushCompositingStateForThisFrame(&frame());
-PaintBehavior oldPaintBehavior = m_paintBehavior;
+paintingState.paintBehavior = m_paintBehavior;
[webkit-changes] [166014] branches/safari-537.75-branch
Title: [166014] branches/safari-537.75-branch
Revision 166014
Author matthew_han...@apple.com
Date 2014-03-20 16:09:45 -0700 (Thu, 20 Mar 2014)
Log Message
Merge r165821.
Modified Paths
branches/safari-537.75-branch/LayoutTests/ChangeLog
branches/safari-537.75-branch/Source/WebCore/ChangeLog
branches/safari-537.75-branch/Source/WebCore/css/CSSStyleRule.cpp
branches/safari-537.75-branch/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
branches/safari-537.75-branch/Source/WebCore/css/PropertySetCSSStyleDeclaration.h
Added Paths
branches/safari-537.75-branch/LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation-expected.txt
branches/safari-537.75-branch/LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation.html
branches/safari-537.75-branch/LayoutTests/fast/css/getMatchedCSSRules-crash-expected.txt
branches/safari-537.75-branch/LayoutTests/fast/css/getMatchedCSSRules-crash.html
Diff
Modified: branches/safari-537.75-branch/LayoutTests/ChangeLog (166013 => 166014)
--- branches/safari-537.75-branch/LayoutTests/ChangeLog 2014-03-20 23:08:30 UTC (rev 166013)
+++ branches/safari-537.75-branch/LayoutTests/ChangeLog 2014-03-20 23:09:45 UTC (rev 166014)
@@ -1,5 +1,21 @@
2014-03-20 Matthew Hanson
+Merge r165821.
+
+2014-03-18 Antti Koivisto
+
+Mutating rules returned by getMatchedCSSRules can result in crash
+https://bugs.webkit.org/show_bug.cgi?id=130209
+
+Reviewed by Andreas Kling.
+
+* fast/css/getMatchedCSSProperties-rule-mutation-expected.txt: Added.
+* fast/css/getMatchedCSSProperties-rule-mutation.html: Added.
+* fast/css/getMatchedCSSRules-crash-expected.txt: Added.
+* fast/css/getMatchedCSSRules-crash.html: Added.
+
+2014-03-20 Matthew Hanson
+
Merge r165921.
2014-03-19 Antti Koivisto
Copied: branches/safari-537.75-branch/LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation-expected.txt (from rev 165821, trunk/LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation-expected.txt) (0 => 166014)
--- branches/safari-537.75-branch/LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation-expected.txt (rev 0)
+++ branches/safari-537.75-branch/LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation-expected.txt 2014-03-20 23:09:45 UTC (rev 166014)
@@ -0,0 +1,20 @@
+Test that CSSStyleRules returned by getMatchedCSSRules can't be mutated
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS rules.length is 2
+PASS rules[0].selectorText is originalText
+PASS rules[1].selectorText is originalText
+PASS rules[0].style.cssText is originalText
+PASS rules[1].style.cssText is originalText
+PASS rules[0].style.color is originalText
+PASS rules[1].style.color is originalText
+PASS rules[0].style.getPropertyValue('color') is originalText
+PASS rules[1].style.getPropertyValue('color') is originalText
+PASS rules[0].style.color is originalText
+PASS rules[1].style.color is originalText
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: branches/safari-537.75-branch/LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation.html (from rev 165821, trunk/LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation.html) (0 => 166014)
--- branches/safari-537.75-branch/LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation.html (rev 0)
+++ branches/safari-537.75-branch/LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation.html 2014-03-20 23:09:45 UTC (rev 166014)
@@ -0,0 +1,67 @@
+
+
+
+
+#test { color: blue; }
+@media all {
+#test { color: blue; }
+}
+
+
+
+
+
+