[webkit-changes] [167344] trunk

[carlosgc]

Title: [167344] trunk








Revision 167344
Author carlo...@webkit.org
Date 2014-04-16 03:19:59 -0700 (Wed, 16 Apr 2014)


Log Message
REGRESSION(r166779): [GTK] Printing doesn't work since r166779
https://bugs.webkit.org/show_bug.cgi?id=131725

Reviewed by Philippe Normand.

* Source/cmake/OptionsGTK.cmake: Check GTK_UNIX_PRINT_FOUND
instead of GTK_UNIX_PRINTING_FOUND and set the macro
HAVE_GTK_UNIX_PRINTING to 1 when found.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (167343 => 167344)

--- trunk/ChangeLog	2014-04-16 05:16:36 UTC (rev 167343)
+++ trunk/ChangeLog	2014-04-16 10:19:59 UTC (rev 167344)
@@ -1,3 +1,14 @@
+2014-04-16  Carlos Garcia Campos  cgar...@igalia.com
+
+REGRESSION(r166779): [GTK] Printing doesn't work since r166779
+https://bugs.webkit.org/show_bug.cgi?id=131725
+
+Reviewed by Philippe Normand.
+
+* Source/cmake/OptionsGTK.cmake: Check GTK_UNIX_PRINT_FOUND
+instead of GTK_UNIX_PRINTING_FOUND and set the macro
+HAVE_GTK_UNIX_PRINTING to 1 when found.
+
 2014-04-11  Brian J. Burg  b...@cs.washington.edu
 
 Web Replay: memoize nondeterministic attributes of the Navigator interface


Modified: trunk/Source/cmake/OptionsGTK.cmake (167343 => 167344)

--- trunk/Source/cmake/OptionsGTK.cmake	2014-04-16 05:16:36 UTC (rev 167343)
+++ trunk/Source/cmake/OptionsGTK.cmake	2014-04-16 10:19:59 UTC (rev 167344)
@@ -210,8 +210,8 @@
 endif ()
 
 find_package(GTKUnixPrint)
-if (GTK_UNIX_PRINTING_FOUND)
-set(HAVE_GTK_UNIX_PRINTING)
+if (GTK_UNIX_PRINT_FOUND)
+set(HAVE_GTK_UNIX_PRINTING 1)
 endif ()
 
 if (ENABLE_CREDENTIAL_STORAGE)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167346] trunk/Source/WebKit/efl

[commit-queue]

Title: [167346] trunk/Source/WebKit/efl








Revision 167346
Author commit-qu...@webkit.org
Date 2014-04-16 05:25:39 -0700 (Wed, 16 Apr 2014)


Log Message
[EFL] Cleanup the build from unused parameters in WebKit-efl.
https://bugs.webkit.org/show_bug.cgi?id=131677.

Patch by Jeongeun Kim je_julie@samsung.com on 2014-04-16
Reviewed by Gyuyoung Kim.

Changed ASSERT to ASSERT_UNUSED if it's just used for ASSERT.

* ewk/ewk_view.cpp:
(ewk_view_scroll):

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (167345 => 167346)

--- trunk/Source/WebKit/efl/ChangeLog	2014-04-16 11:26:55 UTC (rev 167345)
+++ trunk/Source/WebKit/efl/ChangeLog	2014-04-16 12:25:39 UTC (rev 167346)
@@ -1,3 +1,15 @@
+2014-04-16  Jeongeun Kim  je_julie@samsung.com
+
+[EFL] Cleanup the build from unused parameters in WebKit-efl.
+https://bugs.webkit.org/show_bug.cgi?id=131677.
+
+Reviewed by Gyuyoung Kim.
+
+Changed ASSERT to ASSERT_UNUSED if it's just used for ASSERT.
+
+* ewk/ewk_view.cpp:
+(ewk_view_scroll):
+
 2014-04-15  Hyowon Kim  hw1008@samsung.com
 
 [EFL] Fix problems with the pixel dump.


Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (167345 => 167346)

--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2014-04-16 11:26:55 UTC (rev 167345)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2014-04-16 12:25:39 UTC (rev 167346)
@@ -3520,8 +3520,8 @@
 
 void ewk_view_scroll(Evas_Object* ewkView, const WebCore::IntSize delta, const WebCore::IntRect rectToScroll, const WebCore::IntRect)
 {
-ASSERT(!rectToScroll.isEmpty());
-ASSERT(delta.width() || delta.height());
+ASSERT_UNUSED(rectToScroll, !rectToScroll.isEmpty());
+ASSERT_UNUSED(delta, delta.width() || delta.height());
 
 EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData);
 EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167347] trunk/Source/JavaScriptCore

[rgabor]

Title: [167347] trunk/Source/_javascript_Core








Revision 167347
Author rga...@webkit.org
Date 2014-04-16 07:24:51 -0700 (Wed, 16 Apr 2014)


Log Message
Unreviewed, ARM64 buildfix after r167336.

* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::branchAdd32): Add missing function.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167346 => 167347)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-16 12:25:39 UTC (rev 167346)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-16 14:24:51 UTC (rev 167347)
@@ -1,3 +1,10 @@
+2014-04-16  Gabor Rapcsanyi  rga...@webkit.org
+
+Unreviewed, ARM64 buildfix after r167336.
+
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::branchAdd32): Add missing function.
+
 2014-04-15  Filip Pizlo  fpi...@apple.com
 
 Unreviewed, add the obvious thing that marks MakeRope as exiting since it can exit.


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h (167346 => 167347)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h	2014-04-16 12:25:39 UTC (rev 167346)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h	2014-04-16 14:24:51 UTC (rev 167347)
@@ -1830,6 +1830,12 @@
 return branchAdd32(cond, op1, dataTempRegister, dest);
 }
 
+Jump branchAdd32(ResultCondition cond, Address src, RegisterID dest)
+{
+load32(src, getCachedDataTempRegisterIDAndInvalidate());
+return branchAdd32(cond, dest, dataTempRegister, dest);
+}
+
 Jump branchAdd32(ResultCondition cond, RegisterID src, RegisterID dest)
 {
 return branchAdd32(cond, dest, src, dest);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167348] trunk

[darin]

Title: [167348] trunk








Revision 167348
Author da...@apple.com
Date 2014-04-16 09:51:17 -0700 (Wed, 16 Apr 2014)


Log Message
Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
https://bugs.webkit.org/show_bug.cgi?id=131735

Reviewed by Alexey Proskuryakov.

Source/WTF:
* wtf/Vector.h:
(WTF::Vector::takeLast): Added a missing std::move. All the other take functions have it.

Tools:
* TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
is on the right. This can be confusing since our _javascript_ test framework does it the opposite
way, but gtest works better this way.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Vector.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (167347 => 167348)

--- trunk/Source/WTF/ChangeLog	2014-04-16 14:24:51 UTC (rev 167347)
+++ trunk/Source/WTF/ChangeLog	2014-04-16 16:51:17 UTC (rev 167348)
@@ -1,3 +1,13 @@
+2014-04-16  Darin Adler  da...@apple.com
+
+Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
+https://bugs.webkit.org/show_bug.cgi?id=131735
+
+Reviewed by Alexey Proskuryakov.
+
+* wtf/Vector.h:
+(WTF::Vector::takeLast): Added a missing std::move. All the other take functions have it.
+
 2014-04-14  Mark Lam  mark@apple.com
 
 monotonicallyIncreasingTime() should only initialize its static timebaseInfo once.


Modified: trunk/Source/WTF/wtf/Vector.h (167347 => 167348)

--- trunk/Source/WTF/wtf/Vector.h	2014-04-16 14:24:51 UTC (rev 167347)
+++ trunk/Source/WTF/wtf/Vector.h	2014-04-16 16:51:17 UTC (rev 167348)
@@ -661,7 +661,7 @@
 
 T takeLast()
 {
-T result = last();
+T result = std::move(last());
 removeLast();
 return result;
 }


Modified: trunk/Tools/ChangeLog (167347 => 167348)

--- trunk/Tools/ChangeLog	2014-04-16 14:24:51 UTC (rev 167347)
+++ trunk/Tools/ChangeLog	2014-04-16 16:51:17 UTC (rev 167348)
@@ -1,3 +1,15 @@
+2014-04-16  Darin Adler  da...@apple.com
+
+Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
+https://bugs.webkit.org/show_bug.cgi?id=131735
+
+Reviewed by Alexey Proskuryakov.
+
+* TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
+Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
+is on the right. This can be confusing since our _javascript_ test framework does it the opposite
+way, but gtest works better this way.
+
 2014-04-15  Hyowon Kim  hw1008@samsung.com
 
 [EFL] Fix problems with the pixel dump.


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp (167347 => 167348)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp	2014-04-16 14:24:51 UTC (rev 167347)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp	2014-04-16 16:51:17 UTC (rev 167348)
@@ -34,8 +34,8 @@
 {
 Vectorint intVector;
 EXPECT_TRUE(intVector.isEmpty());
-EXPECT_EQ(0ul, intVector.size());
-EXPECT_EQ(0ul, intVector.capacity());
+EXPECT_EQ(0U, intVector.size());
+EXPECT_EQ(0U, intVector.capacity());
 }
 
 TEST(WTF_Vector, Iterator)
@@ -150,11 +150,11 @@
 for (size_t i = 0; i  100; ++i) {
 MoveOnly moveOnly(i);
 vector.uncheckedAppend(std::move(moveOnly));
-EXPECT_EQ(moveOnly.value(), 0U);
+EXPECT_EQ(0U, moveOnly.value());
 }
 
 for (size_t i = 0; i  100; ++i)
-EXPECT_EQ(vector[i].value(), i);
+EXPECT_EQ(i, vector[i].value());
 }
 
 TEST(WTF_Vector, MoveOnly_Append)
@@ -164,11 +164,11 @@
 for (size_t i = 0; i  100; ++i) {
 MoveOnly moveOnly(i);
 vector.append(std::move(moveOnly));
-EXPECT_EQ(moveOnly.value(), 0U);
+EXPECT_EQ(0U, moveOnly.value());
 }
 
 for (size_t i = 0; i  100; ++i)
-EXPECT_EQ(vector[i].value(), i);
+EXPECT_EQ(i, vector[i].value());
 
 for (size_t i = 0; i  16; ++i) {
 VectorMoveOnly vector;
@@ -179,11 +179,11 @@
 vector.append(j);
 vector.append(std::move(vector[0]));
 
-EXPECT_EQ(vector[0].value(), 0U);
+EXPECT_EQ(0U, vector[0].value());
 
 for (size_t j = 0; j  i; ++j)
-EXPECT_EQ(vector[j + 1].value(), j);
-EXPECT_EQ(vector.last().value(), i);
+EXPECT_EQ(j, vector[j + 1].value());
+EXPECT_EQ(i, vector.last().value());
 }
 }
 
@@ -207,7 +207,7 @@
 EXPECT_EQ(0U, moveOnly.value());
 }
 
-EXPECT_EQ(vector.size(), 200U);
+EXPECT_EQ(200U, vector.size());
 for (size_t i = 0; i  200; ++i) {
 if (i % 2)
 EXPECT_EQ(99 - i / 2, vector[i].value());
@@ -216,94 +216,111 @@
 }
 }
 

[webkit-changes] [167349] trunk

[jer . noble]

Title: [167349] trunk








Revision 167349
Author jer.no...@apple.com
Date 2014-04-16 09:52:31 -0700 (Wed, 16 Apr 2014)


Log Message
[MSE] Seeks into buffered ranges will never complete.
https://bugs.webkit.org/show_bug.cgi?id=131717

Reviewed by Eric Carlson.

Source/WebCore:
Test: media/media-source/media-source-seek-complete.html

Run the SourceBuffer Monitoring step after initiating a seek.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime):

LayoutTests:
* media/media-source/media-source-seek-complete-expected.txt: Added.
* media/media-source/media-source-seek-complete.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp


Added Paths

trunk/LayoutTests/media/media-source/media-source-seek-complete-expected.txt
trunk/LayoutTests/media/media-source/media-source-seek-complete.html




Diff

Modified: trunk/LayoutTests/ChangeLog (167348 => 167349)

--- trunk/LayoutTests/ChangeLog	2014-04-16 16:51:17 UTC (rev 167348)
+++ trunk/LayoutTests/ChangeLog	2014-04-16 16:52:31 UTC (rev 167349)
@@ -1,3 +1,13 @@
+2014-04-16  Jer Noble  jer.no...@apple.com
+
+[MSE] Seeks into buffered ranges will never complete.
+https://bugs.webkit.org/show_bug.cgi?id=131717
+
+Reviewed by Eric Carlson.
+
+* media/media-source/media-source-seek-complete-expected.txt: Added.
+* media/media-source/media-source-seek-complete.html: Added.
+
 2014-04-16  Gyuyoung Kim  gyuyoung@samsung.com
 
 Unreviewed EFL gardening. Some test modules come to crash since buildbot uses


Added: trunk/LayoutTests/media/media-source/media-source-seek-complete-expected.txt (0 => 167349)

--- trunk/LayoutTests/media/media-source/media-source-seek-complete-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-seek-complete-expected.txt	2014-04-16 16:52:31 UTC (rev 167349)
@@ -0,0 +1,14 @@
+
+EXPECTED (source.readyState == 'closed') OK
+EVENT(sourceopen)
+RUN(sourceBuffer = source.addSourceBuffer(video/mock; codecs=mock))
+RUN(sourceBuffer.appendBuffer(initSegment))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(samples))
+EVENT(updateend)
+RUN(source.duration = 11)
+RUN(source.endOfStream())
+RUN(video.currentTime = 10)
+EVENT(seeked)
+END OF TEST
+


Added: trunk/LayoutTests/media/media-source/media-source-seek-complete.html (0 => 167349)

--- trunk/LayoutTests/media/media-source/media-source-seek-complete.html	(rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-seek-complete.html	2014-04-16 16:52:31 UTC (rev 167349)
@@ -0,0 +1,59 @@
+!DOCTYPE html
+html
+head
+titlemock-media-source/title
+script src=""
+script src=""
+script
+var source;
+var sourceBuffer;
+var initSegment;
+var samples;
+
+if (window.internals)
+internals.initializeMockMediaSource();
+
+function runTest()
+{
+findMediaElement();
+
+source = new MediaSource();
+testExpected('source.readyState', 'closed');
+
+waitForEventOn(source, 'sourceopen', sourceOpen);
+var videoSource = document.createElement('source');
+videoSource.type = 'video/mock; codecs=mock';
+videoSource.src = ""
+video.appendChild(videoSource);
+}
+
+function sourceOpen()
+{
+run('sourceBuffer = source.addSourceBuffer(video/mock; codecs=mock)');
+waitForEventOn(sourceBuffer, 'updateend', loadSamples, false, true);
+initSegment = makeAInit(8, [makeATrack(1, 'mock', TRACK_KIND.VIDEO)]);
+run('sourceBuffer.appendBuffer(initSegment)');
+}
+
+function loadSamples()
+{
+samples = concatenateSamples([
+makeASample(10, 10, 1, 1, SAMPLE_FLAG.SYNC),
+]);
+waitForEventOn(sourceBuffer, 'updateend', seek, false, true);
+run('sourceBuffer.appendBuffer(samples)');
+}
+
+function seek()
+{
+waitForEventAndEnd('seeked', endTest);
+run('source.duration = 11');
+run('source.endOfStream()');
+run('video.currentTime = 10');
+}
+/script
+/head
+body _onload_=runTest()
+video/video
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (167348 => 167349)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 16:51:17 UTC (rev 167348)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 16:52:31 UTC (rev 167349)
@@ -1,3 +1,17 @@
+2014-04-16  Jer Noble  jer.no...@apple.com
+
+[MSE] Seeks into buffered ranges will never complete.
+https://bugs.webkit.org/show_bug.cgi?id=131717
+
+Reviewed by Eric Carlson.
+
+Test: media/media-source/media-source-seek-complete.html
+
+Run the SourceBuffer Monitoring step after initiating a seek.
+
+* Modules/mediasource/SourceBuffer.cpp:
+(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime):
+
 2014-04-15  Hyowon Kim  

[webkit-changes] [167350] trunk/Tools

[timothy_horton]

Title: [167350] trunk/Tools








Revision 167350
Author timothy_hor...@apple.com
Date 2014-04-16 10:17:11 -0700 (Wed, 16 Apr 2014)


Log Message
check-webkit-style doesn't check code style in .mm or .m files
https://bugs.webkit.org/show_bug.cgi?id=131708

Reviewed by Darin Adler.

* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
(CheckerDispatcherDispatchTest.test_cpp_paths):
(CheckerDispatcherDispatchTest.test_text_paths):
Check .mm and .m files as C++.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
Add an override for our ordinary missing spaces around = for @synthesize,
which should look like @synthesize propertyName=_varName;

Add an override for missing space before { for blocks' ^{.

Don't follow the extra space before [ rule for Objective-C, because
it breaks this rule in a multitude of ways because of method calls.

(check_braces):
Don't complain about { not being on the end of the previous line if
the previous line starts with - ( or + (, which would indicate a
Objective-C method definition.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checker.py
trunk/Tools/Scripts/webkitpy/style/checker_unittest.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py




Diff

Modified: trunk/Tools/ChangeLog (167349 => 167350)

--- trunk/Tools/ChangeLog	2014-04-16 16:52:31 UTC (rev 167349)
+++ trunk/Tools/ChangeLog	2014-04-16 17:17:11 UTC (rev 167350)
@@ -1,3 +1,31 @@
+2014-04-16  Tim Horton  timothy_hor...@apple.com
+
+check-webkit-style doesn't check code style in .mm or .m files
+https://bugs.webkit.org/show_bug.cgi?id=131708
+
+Reviewed by Darin Adler.
+
+* Scripts/webkitpy/style/checker.py:
+* Scripts/webkitpy/style/checker_unittest.py:
+(CheckerDispatcherDispatchTest.test_cpp_paths):
+(CheckerDispatcherDispatchTest.test_text_paths):
+Check .mm and .m files as C++.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(check_spacing):
+Add an override for our ordinary missing spaces around = for @synthesize,
+which should look like @synthesize propertyName=_varName;
+
+Add an override for missing space before { for blocks' ^{.
+
+Don't follow the extra space before [ rule for Objective-C, because
+it breaks this rule in a multitude of ways because of method calls.
+
+(check_braces):
+Don't complain about { not being on the end of the previous line if
+the previous line starts with - ( or + (, which would indicate a
+Objective-C method definition.
+
 2014-04-16  Darin Adler  da...@apple.com
 
 Make Vector::takeLast work with move-only types (and optimize for types where move is faster)


Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (167349 => 167350)

--- trunk/Tools/Scripts/webkitpy/style/checker.py	2014-04-16 16:52:31 UTC (rev 167349)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py	2014-04-16 17:17:11 UTC (rev 167350)
@@ -257,6 +257,8 @@
 'c',
 'cpp',
 'h',
+'mm',
+'m',
 ]
 
 _JS_FILE_EXTENSION = 'js'
@@ -277,7 +279,6 @@
 'html',
 'idl',
 'in',
-'mm',
 'php',
 'pl',
 'pm',


Modified: trunk/Tools/Scripts/webkitpy/style/checker_unittest.py (167349 => 167350)

--- trunk/Tools/Scripts/webkitpy/style/checker_unittest.py	2014-04-16 16:52:31 UTC (rev 167349)
+++ trunk/Tools/Scripts/webkitpy/style/checker_unittest.py	2014-04-16 17:17:11 UTC (rev 167350)
@@ -442,6 +442,8 @@
 foo.c,
 foo.cpp,
 foo.h,
+foo.mm,
+foo.m,
 ]
 
 for path in paths:
@@ -537,7 +539,6 @@
foo.html,
foo.idl,
foo.in,
-   foo.mm,
foo.php,
foo.pl,
foo.pm,


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (167349 => 167350)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2014-04-16 16:52:31 UTC (rev 167349)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2014-04-16 17:17:11 UTC (rev 167350)
@@ -1848,13 +1848,21 @@
 error(line_number, 'whitespace/property', 4,
   'Should not have spaces around = in property attributes.')
 
+# Objective-C @synthesize lines.
+is_objective_c_synthesize = search(r'^@synthesize', line)
+if is_objective_c_synthesize:
+# prop=_varName not prop = _varName
+if search(r'(\s+=|=\s+)', line):
+error(line_number, 'whitespace/property', 4,
+  'Should not have spaces around = in property synthesis.')
+
 # Don't try to do spacing checks for operator methods
 line = sub(r'operator(==|!=|||=|=|||\+=|-=|\*=|/=|%=|=|\|=|^=|=|=|/)\(', 'operator\(', line)
 # Don't try to do spacing checks for #include, #import, or #if statements at
 # minimum because it messes up checks for spacing around /
 if match(r'\s*#\s*(?:include|import|if)', line):
 return
-

[webkit-changes] [167351] trunk

[commit-queue]

Title: [167351] trunk








Revision 167351
Author commit-qu...@webkit.org
Date 2014-04-16 10:19:23 -0700 (Wed, 16 Apr 2014)


Log Message
ASSERTION FAILED: x2 = x1 in WebCore::RenderObject::drawLineForBoxSide
https://bugs.webkit.org/show_bug.cgi?id=127835

Source/WebCore:
In some cases when a negative margin and a positive padding are applied
together to the right and/or left side of the box, the logical width of
the borders can be set to a negative value, making the assertion fire.
The fix checks if the width or height of the box is negative, and if so,
it will not display the borders and shadows of the box.

Patch by Martin Hodovan mhodo...@inf.u-szeged.hu on 2014-04-16
Reviewed by Darin Adler.

Test: fast/css/padding-margin-negative-border.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):

LayoutTests:
Added test demonstrates four cases:
Test #1: Negative upper margin + positive upper padding
Test #2: Negative right margin + positive right padding (used to fail)
Test #3: Negative bottom margin + positive bottom padding
Test #4: Negative left margin + positive left padding (used to fail)

Patch by Martin Hodovan mhodo...@inf.u-szeged.hu on 2014-04-16
Reviewed by Darin Adler.

* fast/css/padding-margin-negative-border-expected.html: Added.
* fast/css/padding-margin-negative-border.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp


Added Paths

trunk/LayoutTests/fast/css/padding-margin-negative-border-expected.html
trunk/LayoutTests/fast/css/padding-margin-negative-border.html




Diff

Modified: trunk/LayoutTests/ChangeLog (167350 => 167351)

--- trunk/LayoutTests/ChangeLog	2014-04-16 17:17:11 UTC (rev 167350)
+++ trunk/LayoutTests/ChangeLog	2014-04-16 17:19:23 UTC (rev 167351)
@@ -1,3 +1,19 @@
+2014-04-16  Martin Hodovan  mhodo...@inf.u-szeged.hu
+
+ASSERTION FAILED: x2 = x1 in WebCore::RenderObject::drawLineForBoxSide
+https://bugs.webkit.org/show_bug.cgi?id=127835
+
+Added test demonstrates four cases:
+Test #1: Negative upper margin + positive upper padding
+Test #2: Negative right margin + positive right padding (used to fail)
+Test #3: Negative bottom margin + positive bottom padding
+Test #4: Negative left margin + positive left padding (used to fail)
+
+Reviewed by Darin Adler.
+
+* fast/css/padding-margin-negative-border-expected.html: Added.
+* fast/css/padding-margin-negative-border.html: Added.
+
 2014-04-16  Jer Noble  jer.no...@apple.com
 
 [MSE] Seeks into buffered ranges will never complete.


Added: trunk/LayoutTests/fast/css/padding-margin-negative-border-expected.html (0 => 167351)

--- trunk/LayoutTests/fast/css/padding-margin-negative-border-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css/padding-margin-negative-border-expected.html	2014-04-16 17:19:23 UTC (rev 167351)
@@ -0,0 +1,69 @@
+!DOCTYPE html
+html
+  body
+table style=width:700px
+  tr
+tdtop/td
+td style=width:400px
+  b style=border:solid;
+i style=
+background-color:green;
+margin: -30px 0px 0px 0px;
+padding: 1px 0px 0px 0px;
+Here is some text.
+/i
+  /b
+/td
+  /tr
+/table
+
+table style=width:700px
+  tr
+tdright/td
+td style=width:400px
+  b style=border:solid;
+border-color:white
+i style=
+background-color:green;
+margin: 0px -208px 0px 0px;
+padding: 0px 1px 0px 0px;
+Here is some text.
+/i
+  /b
+/td
+  /tr
+/table
+
+table style=width:700px
+  tr
+tdbottom/td
+td style=width:400px
+  b style=border:solid;
+i style=
+background-color:green;
+margin: 0px 0px -30px 0px;
+padding: 0px 0px 1px 0px;
+Here is some text.
+/i
+  /b
+/td
+  /tr
+/table
+
+table style=width:700px
+tdleft/td
+td style=width:400px
+  b style=border:solid;
+border-color:white
+i style=
+background-color:green;
+margin: 0px 0px 0px -208px;
+padding: 0px 0px 0px 31px;
+Here is some text.
+/i
+  /b
+/td
+  /tr
+/table
+  /body
+/html


Added: trunk/LayoutTests/fast/css/padding-margin-negative-border.html (0 => 167351)

--- trunk/LayoutTests/fast/css/padding-margin-negative-border.html	(rev 0)
+++ trunk/LayoutTests/fast/css/padding-margin-negative-border.html	2014-04-16 17:19:23 UTC (rev 167351)
@@ -0,0 +1,67 @@
+!DOCTYPE html
+html
+  body
+table style=width:700px
+  

[webkit-changes] [167352] trunk/Source/WebCore

[commit-queue]

Title: [167352] trunk/Source/WebCore








Revision 167352
Author commit-qu...@webkit.org
Date 2014-04-16 10:24:10 -0700 (Wed, 16 Apr 2014)


Log Message
[WinCairo][cURL] Build fix for WinCairo build with USE(CURL).
https://bugs.webkit.org/show_bug.cgi?id=131614

Patch by Daewoong Jang daewoong.j...@navercorp.com on 2014-04-16
Reviewed by Brent Fulgham.

Build fix, no new tests needed.

* platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::loadResponseHeaders):
* platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::loadIndex):
* platform/network/soup/ResourceError.h:
* platform/network/soup/SocketStreamHandle.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlCacheEntry.cpp
trunk/Source/WebCore/platform/network/curl/CurlCacheManager.cpp
trunk/Source/WebCore/platform/network/soup/ResourceError.h
trunk/Source/WebCore/platform/network/soup/SocketStreamHandle.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (167351 => 167352)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 17:19:23 UTC (rev 167351)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 17:24:10 UTC (rev 167352)
@@ -1,3 +1,19 @@
+2014-04-16  Daewoong Jang  daewoong.j...@navercorp.com
+
+[WinCairo][cURL] Build fix for WinCairo build with USE(CURL).
+https://bugs.webkit.org/show_bug.cgi?id=131614
+
+Reviewed by Brent Fulgham.
+
+Build fix, no new tests needed.
+
+* platform/network/curl/CurlCacheEntry.cpp:
+(WebCore::CurlCacheEntry::loadResponseHeaders):
+* platform/network/curl/CurlCacheManager.cpp:
+(WebCore::CurlCacheManager::loadIndex):
+* platform/network/soup/ResourceError.h:
+* platform/network/soup/SocketStreamHandle.h:
+
 2014-04-16  Martin Hodovan  mhodo...@inf.u-szeged.hu
 
 ASSERTION FAILED: x2 = x1 in WebCore::RenderObject::drawLineForBoxSide


Modified: trunk/Source/WebCore/platform/network/curl/CurlCacheEntry.cpp (167351 => 167352)

--- trunk/Source/WebCore/platform/network/curl/CurlCacheEntry.cpp	2014-04-16 17:19:23 UTC (rev 167351)
+++ trunk/Source/WebCore/platform/network/curl/CurlCacheEntry.cpp	2014-04-16 17:24:10 UTC (rev 167352)
@@ -146,7 +146,7 @@
 if (!loadFileToBuffer(m_headerFilename, buffer))
 return false;
 
-String headerContent = String(buffer.data());
+String headerContent = String(buffer.data(), buffer.size());
 VectorString headerFields;
 headerContent.split(\n, headerFields);
 


Modified: trunk/Source/WebCore/platform/network/curl/CurlCacheManager.cpp (167351 => 167352)

--- trunk/Source/WebCore/platform/network/curl/CurlCacheManager.cpp	2014-04-16 17:19:23 UTC (rev 167351)
+++ trunk/Source/WebCore/platform/network/curl/CurlCacheManager.cpp	2014-04-16 17:24:10 UTC (rev 167352)
@@ -127,7 +127,7 @@
 closeFile(indexFile);
 
 // Create strings from buffer
-String headerContent = String(buffer.data());
+String headerContent = String(buffer.data(), buffer.size());
 VectorString indexURLs;
 headerContent.split(\n, indexURLs);
 buffer.clear();


Modified: trunk/Source/WebCore/platform/network/soup/ResourceError.h (167351 => 167352)

--- trunk/Source/WebCore/platform/network/soup/ResourceError.h	2014-04-16 17:19:23 UTC (rev 167351)
+++ trunk/Source/WebCore/platform/network/soup/ResourceError.h	2014-04-16 17:24:10 UTC (rev 167352)
@@ -27,6 +27,9 @@
 #define ResourceError_h
 
 #include ResourceErrorBase.h
+
+#if USE(SOUP)
+
 #include wtf/gobject/GRefPtr.h
 
 typedef struct _GTlsCertificate GTlsCertificate;
@@ -71,4 +74,6 @@
 
 }
 
+#endif
+
 #endif // ResourceError_h_


Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamHandle.h (167351 => 167352)

--- trunk/Source/WebCore/platform/network/soup/SocketStreamHandle.h	2014-04-16 17:19:23 UTC (rev 167351)
+++ trunk/Source/WebCore/platform/network/soup/SocketStreamHandle.h	2014-04-16 17:24:10 UTC (rev 167352)
@@ -34,6 +34,9 @@
 #define SocketStreamHandle_h
 
 #include SocketStreamHandleBase.h
+
+#if USE(SOUP)
+
 #include wtf/PassRefPtr.h
 #include wtf/RefCounted.h
 #include wtf/gobject/GRefPtr.h
@@ -81,4 +84,6 @@
 
 }  // namespace WebCore
 
+#endif
+
 #endif  // SocketStreamHandle_h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167353] trunk

[hyatt]

Title: [167353] trunk








Revision 167353
Author hy...@apple.com
Date 2014-04-16 10:36:56 -0700 (Wed, 16 Apr 2014)


Log Message
Make sure to skip the RenderMultiColumnFlowThread when resolving percentage heights inside columns against
containing blocks. The flow thread's auto height should not interfere if a fixed height is specified on
an ancestor.

https://bugs.webkit.org/show_bug.cgi?id=131741

Reviewed by Simon Fraser.


Source/WebCore: 
Added fast/multicol/percent-height.html.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
Add an isInFlowRenderFlowThread check so that we skip those blocks and don't consider them at all
when resolving percentage heights.

LayoutTests: 
* fast/multicol/percent-height-expected.html: Added.
* fast/multicol/percent-height.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/LayoutTests/fast/multicol/percent-height-expected.html
trunk/LayoutTests/fast/multicol/percent-height.html




Diff

Modified: trunk/LayoutTests/ChangeLog (167352 => 167353)

--- trunk/LayoutTests/ChangeLog	2014-04-16 17:24:10 UTC (rev 167352)
+++ trunk/LayoutTests/ChangeLog	2014-04-16 17:36:56 UTC (rev 167353)
@@ -1,3 +1,16 @@
+2014-04-16  David Hyatt  hy...@apple.com
+
+Make sure to skip the RenderMultiColumnFlowThread when resolving percentage heights inside columns against
+containing blocks. The flow thread's auto height should not interfere if a fixed height is specified on
+an ancestor.
+
+https://bugs.webkit.org/show_bug.cgi?id=131741
+
+Reviewed by Simon Fraser.
+
+* fast/multicol/percent-height-expected.html: Added.
+* fast/multicol/percent-height.html: Added.
+
 2014-04-16  Martin Hodovan  mhodo...@inf.u-szeged.hu
 
 ASSERTION FAILED: x2 = x1 in WebCore::RenderObject::drawLineForBoxSide


Added: trunk/LayoutTests/fast/multicol/percent-height-expected.html (0 => 167353)

--- trunk/LayoutTests/fast/multicol/percent-height-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/percent-height-expected.html	2014-04-16 17:36:56 UTC (rev 167353)
@@ -0,0 +1,10 @@
+!DOCTYPE html
+html
+  head
+titleResolving percent height inside multicol/title
+/head
+  body
+pThere should be a blue square below./p
+div style=width:99px; height:99px; background:blue;/div
+/body
+  /html


Added: trunk/LayoutTests/fast/multicol/percent-height.html (0 => 167353)

--- trunk/LayoutTests/fast/multicol/percent-height.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/percent-height.html	2014-04-16 17:36:56 UTC (rev 167353)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+html
+  head
+titleResolving percent height inside multicol/title
+script
+  if (window.internals)
+  internals.settings.setRegionBasedColumnsEnabled(true);
+  /script
+/head
+  body
+pThere should be a blue square below./p
+div style=-webkit-columns:3; columns:3; -webkit-column-gap:0; column-gap:0; width:99px; height:99px;
+  div style=height:300%; background:blue;/div
+  /div
+/body
+  /html


Modified: trunk/Source/WebCore/ChangeLog (167352 => 167353)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 17:24:10 UTC (rev 167352)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 17:36:56 UTC (rev 167353)
@@ -1,3 +1,20 @@
+2014-04-16  David Hyatt  hy...@apple.com
+
+Make sure to skip the RenderMultiColumnFlowThread when resolving percentage heights inside columns against
+containing blocks. The flow thread's auto height should not interfere if a fixed height is specified on
+an ancestor.
+
+https://bugs.webkit.org/show_bug.cgi?id=131741
+
+Reviewed by Simon Fraser.
+
+Added fast/multicol/percent-height.html.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
+Add an isInFlowRenderFlowThread check so that we skip those blocks and don't consider them at all
+when resolving percentage heights.
+
 2014-04-16  Daewoong Jang  daewoong.j...@navercorp.com
 
 [WinCairo][cURL] Build fix for WinCairo build with USE(CURL).


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (167352 => 167353)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2014-04-16 17:24:10 UTC (rev 167352)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2014-04-16 17:36:56 UTC (rev 167353)
@@ -2713,6 +2713,11 @@
 
 bool RenderBox::skipContainingBlockForPercentHeightCalculation(const RenderBox* containingBlock) const
 {
+// Flow threads for multicol or paged overflow should be skipped. They are invisible to the DOM,
+// and percent heights of children should be resolved against the multicol or paged 

[webkit-changes] [167354] trunk/Source/JavaScriptCore

[fpizlo]

Title: [167354] trunk/Source/_javascript_Core








Revision 167354
Author fpi...@apple.com
Date 2014-04-16 10:48:22 -0700 (Wed, 16 Apr 2014)


Log Message
Unreviewed, ARMv7 build fix after r167336.

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchAdd32):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167353 => 167354)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-16 17:36:56 UTC (rev 167353)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-16 17:48:22 UTC (rev 167354)
@@ -1,3 +1,10 @@
+2014-04-16  Filip Pizlo  fpi...@apple.com
+
+Unreviewed, ARMv7 build fix after r167336.
+
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::branchAdd32):
+
 2014-04-16  Gabor Rapcsanyi  rga...@webkit.org
 
 Unreviewed, ARM64 buildfix after r167336.


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (167353 => 167354)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h	2014-04-16 17:36:56 UTC (rev 167353)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h	2014-04-16 17:48:22 UTC (rev 167354)
@@ -1513,6 +1513,12 @@
 return branchAdd32(cond, dest, src, dest);
 }
 
+Jump branchAdd32(ResultCondition cond, Address src, RegisterID dest)
+{
+load32(src, dataTempRegister);
+return branchAdd32(cond, dest, dataTempRegister, dest);
+}
+
 Jump branchAdd32(ResultCondition cond, TrustedImm32 imm, RegisterID dest)
 {
 return branchAdd32(cond, dest, imm, dest);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167356] trunk/Source/WebCore

[simon . fraser]

Title: [167356] trunk/Source/WebCore








Revision 167356
Author simon.fra...@apple.com
Date 2014-04-16 10:50:57 -0700 (Wed, 16 Apr 2014)


Log Message
Convert the boolean param of Image::startAnimation() to an enum
https://bugs.webkit.org/show_bug.cgi?id=131742

Reviewed by Tim Horton.

Use an enum to make the code more readable.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
* platform/graphics/Image.h:
(WebCore::Image::startAnimation):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::startAnimation):
* svg/graphics/SVGImage.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.h
trunk/Source/WebCore/platform/graphics/Image.cpp
trunk/Source/WebCore/platform/graphics/Image.h
trunk/Source/WebCore/svg/graphics/SVGImage.cpp
trunk/Source/WebCore/svg/graphics/SVGImage.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (167355 => 167356)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 17:48:56 UTC (rev 167355)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 17:50:57 UTC (rev 167356)
@@ -1,3 +1,23 @@
+2014-04-16  Simon Fraser  simon.fra...@apple.com
+
+Convert the boolean param of Image::startAnimation() to an enum
+https://bugs.webkit.org/show_bug.cgi?id=131742
+
+Reviewed by Tim Horton.
+
+Use an enum to make the code more readable.
+
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::startAnimation):
+* platform/graphics/BitmapImage.h:
+* platform/graphics/Image.cpp:
+(WebCore::Image::drawTiled):
+* platform/graphics/Image.h:
+(WebCore::Image::startAnimation):
+* svg/graphics/SVGImage.cpp:
+(WebCore::SVGImage::startAnimation):
+* svg/graphics/SVGImage.h:
+
 2014-04-16  David Hyatt  hy...@apple.com
 
 Make sure to skip the RenderMultiColumnFlowThread when resolving percentage heights inside columns against


Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (167355 => 167356)

--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2014-04-16 17:48:56 UTC (rev 167355)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2014-04-16 17:50:57 UTC (rev 167356)
@@ -539,7 +539,7 @@
 return (repetitionCount(false) != cAnimationNone  !m_animationFinished  imageObserver());
 }
 
-void BitmapImage::startAnimation(bool catchUpIfNecessary)
+void BitmapImage::startAnimation(CatchUpAnimation catchUpIfNecessary)
 {
 if (m_frameTimer || !shouldAnimate() || frameCount() = 1)
 return;
@@ -593,7 +593,7 @@
 if (nextFrame == 0  m_repetitionsComplete == 0  m_desiredFrameStartTime  time)
 m_desiredFrameStartTime = time;
 
-if (!catchUpIfNecessary || time  m_desiredFrameStartTime) {
+if (catchUpIfNecessary == DoNotCatchUp || time  m_desiredFrameStartTime) {
 // Haven't yet reached time for next frame to start; delay until then.
 m_frameTimer = std::make_uniqueTimerBitmapImage(this, BitmapImage::advanceAnimation);
 m_frameTimer-startOneShot(std::max(m_desiredFrameStartTime - time, 0.));
@@ -636,7 +636,7 @@
 // situation the best we can do is to simply change frames as fast
 // as possible, so force startAnimation() to set a zero-delay timer
 // and bail out if we're not caught up.
-startAnimation(false);
+startAnimation(DoNotCatchUp);
 }
 }
 }


Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.h (167355 => 167356)

--- trunk/Source/WebCore/platform/graphics/BitmapImage.h	2014-04-16 17:48:56 UTC (rev 167355)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.h	2014-04-16 17:50:57 UTC (rev 167356)
@@ -272,7 +272,7 @@
 // Animation.
 int repetitionCount(bool imageKnownToBeComplete);  // |imageKnownToBeComplete| should be set if the caller knows the entire image has been decoded.
 bool shouldAnimate();
-virtual void startAnimation(bool catchUpIfNecessary = true) override;
+virtual void startAnimation(CatchUpAnimation = CatchUp) override;
 void advanceAnimation(TimerBitmapImage);
 
 // Function that does the real work of advancing the animation.  When


Modified: trunk/Source/WebCore/platform/graphics/Image.cpp (167355 => 167356)

--- trunk/Source/WebCore/platform/graphics/Image.cpp	2014-04-16 17:48:56 UTC (rev 167355)
+++ trunk/Source/WebCore/platform/graphics/Image.cpp	2014-04-16 17:50:57 UTC (rev 167356)
@@ -185,7 +185,7 @@
 drawPattern(ctxt, tileRect, patternTransform, oneTileRect.location(), styleColorSpace, op, destRect, blendMode);
 
 #if PLATFORM(IOS)
-startAnimation(false);
+startAnimation(DoNotCatchUp);
 #else
 startAnimation();
 #endif
@@ -223,7 +223,7 @@
 drawPattern(ctxt, srcRect, patternTransform, patternPhase, styleColorSpace, op, dstRect);
 
 #if 

[webkit-changes] [167357] trunk/Source/WebKit2

[timothy_horton]

Title: [167357] trunk/Source/WebKit2








Revision 167357
Author timothy_hor...@apple.com
Date 2014-04-16 10:54:50 -0700 (Wed, 16 Apr 2014)


Log Message
Fix some style checker complaints in PDFPlugin
https://bugs.webkit.org/show_bug.cgi?id=131706

Reviewed by Darin Adler.

* WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:forParameter:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeNames]):
(WebKit::PDFPlugin::attemptToUnlockPDF):
(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors):
(WebKit::PDFPlugin::isEditingCommandEnabled):
(WebKit::PDFPlugin::nextMatchForString):
(WebKit::PDFPlugin::handleWheelEvent):
(WebKit::PDFPlugin::liveData):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167356 => 167357)

--- trunk/Source/WebKit2/ChangeLog	2014-04-16 17:50:57 UTC (rev 167356)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-16 17:54:50 UTC (rev 167357)
@@ -1,3 +1,21 @@
+2014-04-16  Tim Horton  timothy_hor...@apple.com
+
+Fix some style checker complaints in PDFPlugin
+https://bugs.webkit.org/show_bug.cgi?id=131706
+
+Reviewed by Darin Adler.
+
+* WebProcess/Plugins/PDF/PDFPlugin.mm:
+(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]):
+(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:forParameter:]):
+(-[WKPDFPluginAccessibilityObject accessibilityAttributeNames]):
+(WebKit::PDFPlugin::attemptToUnlockPDF):
+(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors):
+(WebKit::PDFPlugin::isEditingCommandEnabled):
+(WebKit::PDFPlugin::nextMatchForString):
+(WebKit::PDFPlugin::handleWheelEvent):
+(WebKit::PDFPlugin::liveData):
+
 2014-04-15  Dan Bernstein  m...@apple.com
 
 [Cocoa] Add a form delegate method corresponding to willSubmitForm


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm (167356 => 167357)

--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm	2014-04-16 17:50:57 UTC (rev 167356)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm	2014-04-16 17:54:50 UTC (rev 167357)
@@ -112,16 +112,15 @@
 // will jump to the next or previous page, to match PDFKit behavior.
 static const int defaultScrollMagnitudeThresholdForPageFlip = 20;
 
-@interface WKPDFPluginAccessibilityObject : NSObject
-{
+@interface WKPDFPluginAccessibilityObject : NSObject {
 PDFLayerController *_pdfLayerController;
 NSObject *_parent;
 WebKit::PDFPlugin* _pdfPlugin;
 }
 
-@property(assign) PDFLayerController *pdfLayerController;
-@property(assign) NSObject *parent;
-@property(assign) WebKit::PDFPlugin* pdfPlugin;
+@property (assign) PDFLayerController *pdfLayerController;
+@property (assign) NSObject *parent;
+@property (assign) WebKit::PDFPlugin* pdfPlugin;
 
 - (id)initWithPDFPlugin:(WebKit::PDFPlugin *)plugin;
 
@@ -129,9 +128,9 @@
 
 @implementation WKPDFPluginAccessibilityObject
 
-@synthesize pdfLayerController = _pdfLayerController;
-@synthesize parent = _parent;
-@synthesize pdfPlugin = _pdfPlugin;
+@synthesize pdfLayerController=_pdfLayerController;
+@synthesize parent=_parent;
+@synthesize pdfPlugin=_pdfPlugin;
 
 - (id)initWithPDFPlugin:(WebKit::PDFPlugin *)plugin
 {
@@ -152,31 +151,31 @@
 {
 if ([attribute isEqualToString:NSAccessibilityParentAttribute])
 return _parent;
-else if ([attribute isEqualToString:NSAccessibilityValueAttribute])
+if ([attribute isEqualToString:NSAccessibilityValueAttribute])
 return [_pdfLayerController accessibilityValueAttribute];
-else if ([attribute isEqualToString:NSAccessibilitySelectedTextAttribute])
+if ([attribute isEqualToString:NSAccessibilitySelectedTextAttribute])
 return [_pdfLayerController accessibilitySelectedTextAttribute];
-else if ([attribute isEqualToString:NSAccessibilitySelectedTextRangeAttribute])
+if ([attribute isEqualToString:NSAccessibilitySelectedTextRangeAttribute])
 return [_pdfLayerController accessibilitySelectedTextRangeAttribute];
-else if ([attribute isEqualToString:NSAccessibilityNumberOfCharactersAttribute])
+if ([attribute isEqualToString:NSAccessibilityNumberOfCharactersAttribute])
 return [_pdfLayerController accessibilityNumberOfCharactersAttribute];
-else if ([attribute isEqualToString:NSAccessibilityVisibleCharacterRangeAttribute])
+if ([attribute isEqualToString:NSAccessibilityVisibleCharacterRangeAttribute])
 return [_pdfLayerController accessibilityVisibleCharacterRangeAttribute];
-else if ([attribute isEqualToString:NSAccessibilityTopLevelUIElementAttribute])
+if ([attribute isEqualToString:NSAccessibilityTopLevelUIElementAttribute])
 return [_parent accessibilityAttributeValue:NSAccessibilityTopLevelUIElementAttribute];
-else 

[webkit-changes] [167358] trunk/Source/WebKit2

[timothy_horton]

Title: [167358] trunk/Source/WebKit2








Revision 167358
Author timothy_hor...@apple.com
Date 2014-04-16 10:58:52 -0700 (Wed, 16 Apr 2014)


Log Message
Accidentally included some style-checker-testing changes in the last commit.

* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::attemptToUnlockPDF):
(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167357 => 167358)

--- trunk/Source/WebKit2/ChangeLog	2014-04-16 17:54:50 UTC (rev 167357)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-16 17:58:52 UTC (rev 167358)
@@ -1,5 +1,13 @@
 2014-04-16  Tim Horton  timothy_hor...@apple.com
 
+Accidentally included some style-checker-testing changes in the last commit.
+
+* WebProcess/Plugins/PDF/PDFPlugin.mm:
+(WebKit::PDFPlugin::attemptToUnlockPDF):
+(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors):
+
+2014-04-16  Tim Horton  timothy_hor...@apple.com
+
 Fix some style checker complaints in PDFPlugin
 https://bugs.webkit.org/show_bug.cgi?id=131706
 


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm (167357 => 167358)

--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm	2014-04-16 17:54:50 UTC (rev 167357)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm	2014-04-16 17:58:52 UTC (rev 167358)
@@ -1005,7 +1005,7 @@
 
 void PDFPlugin::attemptToUnlockPDF(const String password)
 {
-[m_pdfLayerController.get() attemptToUnlockWithPassword:password];
+[m_pdfLayerController attemptToUnlockWithPassword:password];
 
 if (![pdfDocument() isLocked]) {
 m_passwordField = nullptr;
@@ -1021,7 +1021,7 @@
 if (!handlesPageScaleFactor())
 newScaleFactor *= webFrame()-page()-pageScaleFactor();
 
-[m_pdfLayerController.get() setDeviceScaleFactor:newScaleFactor];
+[m_pdfLayerController setDeviceScaleFactor:newScaleFactor];
 }
 
 void PDFPlugin::contentsScaleFactorChanged(float)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167359] trunk/Tools

[commit-queue]

Title: [167359] trunk/Tools








Revision 167359
Author commit-qu...@webkit.org
Date 2014-04-16 10:58:52 -0700 (Wed, 16 Apr 2014)


Log Message
[GTK] Unreviewed GTK gardening.

Update list of skipped unit tests:

  Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility

  Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
  and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors

Patch by Carlos Alberto Lopez Perez clo...@igalia.com on 2014-04-16

* Scripts/run-gtk-tests:
(TestRunner):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests




Diff

Modified: trunk/Tools/ChangeLog (167358 => 167359)

--- trunk/Tools/ChangeLog	2014-04-16 17:58:52 UTC (rev 167358)
+++ trunk/Tools/ChangeLog	2014-04-16 17:58:52 UTC (rev 167359)
@@ -1,3 +1,17 @@
+2014-04-16  Carlos Alberto Lopez Perez  clo...@igalia.com
+
+[GTK] Unreviewed GTK gardening.
+
+Update list of skipped unit tests:
+
+  Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
+
+  Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
+  and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
+
+* Scripts/run-gtk-tests:
+(TestRunner):
+
 2014-04-16  Tim Horton  timothy_hor...@apple.com
 
 check-webkit-style doesn't check code style in .mm or .m files


Modified: trunk/Tools/Scripts/run-gtk-tests (167358 => 167359)

--- trunk/Tools/Scripts/run-gtk-tests	2014-04-16 17:58:52 UTC (rev 167358)
+++ trunk/Tools/Scripts/run-gtk-tests	2014-04-16 17:58:52 UTC (rev 167359)
@@ -64,6 +64,7 @@
 SkippedTest(WebKit2Gtk/TestUIClient, /webkit2/WebKitWebView/mouse-target, Test times out after r150890, 117689),
 SkippedTest(WebKit2Gtk/TestContextMenu, SkippedTest.ENTIRE_SUITE, Test times out after r150890, 117689),
 SkippedTest(WebKit2Gtk/TestWebKitWebView, /webkit2/WebKitWebView/snapshot, Test fails, 120404),
+SkippedTest(WebKit2Gtk/TestWebKitWebView, /webkit2/WebKitWebView/page-visibility, Test fails or times out, 131731),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.MouseMoveAfterCrash, Test is flaky, 85066),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.NewFirstVisuallyNonEmptyLayoutForImages, Test is flaky, 85066),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.NewFirstVisuallyNonEmptyLayoutFrames, Test fails, 85037),
@@ -75,8 +76,6 @@
 SkippedTest(WebKit2/TestWebKit2, WebKit2.ReloadPageAfterCrash, Test flakily times out, 110129),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.DidAssociateFormControls, Test times out, 120302),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.InjectedBundleFrameHitTest, Test times out, 120303),
-SkippedTest(WebKit2/TestWebKit2, WebKit2.ResizeReversePaginatedWebView, Test fails, 120305),
-SkippedTest(WebKit2/TestWebKit2, WebKit2.ScrollPinningBehaviors, Test fails, 120306),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.TerminateTwice, Test causes crash on the next test, 121970),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.GeolocationTransitionToHighAccuracy, Test causes crash on the next test, 125068),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.GeolocationTransitionToLowAccuracy, Test causes crash on the next test, 125068),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167362] trunk/LayoutTests/platform/mac-wk2/TestExpectations

[abucur]

Title: [167362] trunk/LayoutTests/platform/mac-wk2/TestExpectations








Revision 167362
Author abu...@adobe.com
Date 2014-04-16 11:05:44 -0700 (Wed, 16 Apr 2014)


Log Message
[mac][wk2] REGRESSION (Tiled Drawing): fast/layers/no-clipping-overflow-hidden-added-after-transform.html fails with tiled drawing
https://bugs.webkit.org/show_bug.cgi?id=122238

Unreviewed. The test passes now.

Modified Paths

trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (167361 => 167362)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2014-04-16 18:04:43 UTC (rev 167361)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2014-04-16 18:05:44 UTC (rev 167362)
@@ -327,7 +327,6 @@
 webkit.org/b/122235 css3/background/background-repeat-space-padding.html [ ImageOnlyFailure ]
 
 webkit.org/b/122237 [ Debug ] fast/table/crash-section-logical-height-changed-needsCellRecalc.html [ Crash ]
-webkit.org/b/122238 fast/layers/no-clipping-overflow-hidden-added-after-transform.html [ ImageOnlyFailure ]
 
 webkit.org/b/122456 css3/images/cross-fade-svg-with-opacity.html [ ImageOnlyFailure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167363] trunk/Source/WebKit

[simon . fraser]

Title: [167363] trunk/Source/WebKit








Revision 167363
Author simon.fra...@apple.com
Date 2014-04-16 11:06:13 -0700 (Wed, 16 Apr 2014)


Log Message
Make Windows fail with a link error so I know what the new symbol is.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (167362 => 167363)

--- trunk/Source/WebKit/ChangeLog	2014-04-16 18:05:44 UTC (rev 167362)
+++ trunk/Source/WebKit/ChangeLog	2014-04-16 18:06:13 UTC (rev 167363)
@@ -1,3 +1,9 @@
+2014-04-16  Simon Fraser  simon.fra...@apple.com
+
+Make Windows fail with a link error so I know what the new symbol is.
+
+* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
+
 2014-04-10  Michael Saboff  msab...@apple.com
 
 LLInt interpreter code should be generated as part of one function


Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in (167362 => 167363)

--- trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in	2014-04-16 18:05:44 UTC (rev 167362)
+++ trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in	2014-04-16 18:06:13 UTC (rev 167363)
@@ -373,7 +373,6 @@
 symbolWithPointer(?dataChanged@BitmapImage@WebCore@@UAE_N_N@Z, ?dataChanged@BitmapImage@WebCore@@UEAA_N_N@Z)
 symbolWithPointer(?filenameExtension@BitmapImage@WebCore@@UBE?AVString@WTF@@XZ, ?filenameExtension@BitmapImage@WebCore@@UEBA?AVString@WTF@@XZ)
 symbolWithPointer(?destroyDecodedData@BitmapImage@WebCore@@MAEX_N@Z, ?destroyDecodedData@BitmapImage@WebCore@@MEAAX_N@Z)
-symbolWithPointer(?startAnimation@BitmapImage@WebCore@@MAEX_N@Z, ?startAnimation@BitmapImage@WebCore@@MEAAX_N@Z)
 symbolWithPointer(?stopAnimation@BitmapImage@WebCore@@UAEXXZ, ?stopAnimation@BitmapImage@WebCore@@UEAAXXZ)
 symbolWithPointer(?resetAnimation@BitmapImage@WebCore@@UAEXXZ, ?resetAnimation@BitmapImage@WebCore@@UEAAXXZ)
 #if USE(CG)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167364] trunk/Source/JavaScriptCore

[mhahnenberg]

Title: [167364] trunk/Source/_javascript_Core








Revision 167364
Author mhahnenb...@apple.com
Date 2014-04-16 11:09:56 -0700 (Wed, 16 Apr 2014)


Log Message
[WebKit] Cleanup the build from uninitialized variable in _javascript_Core
https://bugs.webkit.org/show_bug.cgi?id=131728

Reviewed by Darin Adler.

* runtime/JSObject.cpp:
(JSC::JSObject::genericConvertDoubleToContiguous): Add a RELEASE_ASSERT on the
path we expect to never take. Also shut up confused compilers about uninitialized things.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167363 => 167364)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-16 18:06:13 UTC (rev 167363)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-16 18:09:56 UTC (rev 167364)
@@ -1,3 +1,14 @@
+2014-04-16  Mark Hahnenberg  mhahnenb...@apple.com
+
+[WebKit] Cleanup the build from uninitialized variable in _javascript_Core
+https://bugs.webkit.org/show_bug.cgi?id=131728
+
+Reviewed by Darin Adler.
+
+* runtime/JSObject.cpp:
+(JSC::JSObject::genericConvertDoubleToContiguous): Add a RELEASE_ASSERT on the 
+path we expect to never take. Also shut up confused compilers about uninitialized things.
+
 2014-04-16  Filip Pizlo  fpi...@apple.com
 
 Unreviewed, ARMv7 build fix after r167336.


Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (167363 => 167364)

--- trunk/Source/_javascript_Core/runtime/JSObject.cpp	2014-04-16 18:06:13 UTC (rev 167363)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp	2014-04-16 18:09:56 UTC (rev 167364)
@@ -829,6 +829,10 @@
 case RageConvertDoubleToValue:
 v = jsNumber(value);
 break;
+default:
+v = JSValue();
+RELEASE_ASSERT_NOT_REACHED();
+break;
 }
 ASSERT(v.isNumber());
 currentAsValue-setWithoutWriteBarrier(v);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167365] trunk

[bfulgham]

Title: [167365] trunk








Revision 167365
Author bfulg...@apple.com
Date 2014-04-16 11:15:04 -0700 (Wed, 16 Apr 2014)


Log Message
[Win] Eliminate use of deleteAllValues in Windows Files
https://bugs.webkit.org/show_bug.cgi?id=131631

Reviewed by Darin Adler.


Source/WebCore: 
Update to use std::unique_ptr for object lifetime. Get rid of
deleteAllValues now that it is no loner needed. Use ranged for
loops where possible.

* platform/win/WCDataObject.cpp:
(WebCore::WCEnumFormatEtc::WCEnumFormatEtc):
(WebCore::WCDataObject::~WCDataObject):
(WebCore::WCDataObject::GetData):
(WebCore::WCDataObject::QueryGetData):
(WebCore::WCDataObject::SetData):
(WebCore::WCDataObject::clearData):
* platform/win/WCDataObject.h:

Tools: 
Switch to std::unique_ptr for memory lifetime. Get rid of
deleteAllValues now that it is no longer needed. Use ranged
for loops where possible.

* DumpRenderTree/win/DRTDataObject.cpp:
(WCEnumFormatEtc::WCEnumFormatEtc):
(DRTDataObject::~DRTDataObject):
(DRTDataObject::GetData):
(DRTDataObject::QueryGetData):
(DRTDataObject::SetData):
(DRTDataObject::clearData):
* DumpRenderTree/win/DRTDataObject.h:
* DumpRenderTree/win/UIDelegate.cpp:
(DRTUndoObject::DRTUndoObject):
(DRTUndoObject::~DRTUndoObject):
(DRTUndoStack::~DRTUndoStack):
(DRTUndoStack::clear):
(DRTUndoStack::pop):
(DRTUndoManager::DRTUndoManager):
(DRTUndoManager::redo):
(DRTUndoManager::undo):
(UIDelegate::UIDelegate):
(UIDelegate::resetUndoManager):
* DumpRenderTree/win/UIDelegate.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/win/WCDataObject.cpp
trunk/Source/WebCore/platform/win/WCDataObject.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/win/DRTDataObject.cpp
trunk/Tools/DumpRenderTree/win/DRTDataObject.h
trunk/Tools/DumpRenderTree/win/UIDelegate.cpp
trunk/Tools/DumpRenderTree/win/UIDelegate.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (167364 => 167365)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 18:09:56 UTC (rev 167364)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 18:15:04 UTC (rev 167365)
@@ -1,3 +1,23 @@
+2014-04-15  Brent Fulgham  bfulg...@apple.com
+
+[Win] Eliminate use of deleteAllValues in Windows Files
+https://bugs.webkit.org/show_bug.cgi?id=131631
+
+Reviewed by Darin Adler.
+
+Update to use std::unique_ptr for object lifetime. Get rid of
+deleteAllValues now that it is no loner needed. Use ranged for
+loops where possible.
+
+* platform/win/WCDataObject.cpp:
+(WebCore::WCEnumFormatEtc::WCEnumFormatEtc):
+(WebCore::WCDataObject::~WCDataObject):
+(WebCore::WCDataObject::GetData):
+(WebCore::WCDataObject::QueryGetData):
+(WebCore::WCDataObject::SetData):
+(WebCore::WCDataObject::clearData):
+* platform/win/WCDataObject.h:
+
 2014-04-16  Chris Fleizach  cfleiz...@apple.com
 
 AX: Accessing a table cell with an invalid column header crashes


Modified: trunk/Source/WebCore/platform/win/WCDataObject.cpp (167364 => 167365)

--- trunk/Source/WebCore/platform/win/WCDataObject.cpp	2014-04-16 18:09:56 UTC (rev 167364)
+++ trunk/Source/WebCore/platform/win/WCDataObject.cpp	2014-04-16 18:15:04 UTC (rev 167365)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2007 Apple Inc.  All rights reserved.
+ * Copyright (C) 2007, 2014 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -36,7 +36,7 @@
 {
 public:
 WCEnumFormatEtc(const VectorFORMATETC formats);
-WCEnumFormatEtc(const VectorFORMATETC* formats);
+WCEnumFormatEtc(const Vectorstd::unique_ptrFORMATETC formats);
 
 //IUnknown members
 STDMETHOD(QueryInterface)(REFIID, void**);
@@ -55,8 +55,6 @@
 size_t m_current;
 };
 
-
-
 WCEnumFormatEtc::WCEnumFormatEtc(const VectorFORMATETC formats)
 : m_ref(1)
 , m_current(0)
@@ -65,12 +63,12 @@
 m_formats.append(formats[i]);
 }
 
-WCEnumFormatEtc::WCEnumFormatEtc(const VectorFORMATETC* formats)
-: m_ref(1)
-, m_current(0)
+WCEnumFormatEtc::WCEnumFormatEtc(const Vectorstd::unique_ptrFORMATETC formats)
+: m_ref(1)
+, m_current(0)
 {
-for(size_t i = 0; i  formats.size(); ++i)
-m_formats.append(*formats[i]);
+for (auto format : formats)
+m_formats.append(*format);
 }
 
 STDMETHODIMP  WCEnumFormatEtc::QueryInterface(REFIID riid, void** ppvObject)
@@ -178,15 +176,6 @@
 {
 }
 
-WCDataObject::~WCDataObject()
-{
-for(size_t i = 0; i  m_medium.size(); ++i) {
-ReleaseStgMedium(m_medium[i]);
-delete m_medium[i];
-}
-WTF::deprecatedDeleteAllValues(m_formats);
-}
-
 STDMETHODIMP WCDataObject::QueryInterface(REFIID riid,void** ppvObject)
 {
 *ppvObject = 0;
@@ -220,12 +209,12 @@
 return E_POINTER;
 pmedium-hGlobal = 0;
 
-for(size_t i=0; i  m_formats.size(); ++i) {
+for (size_t i = 0; i  m_formats.size(); ++i) {
 if(/*pformatetcIn-tymed  

[webkit-changes] [167366] trunk/LayoutTests

[bjonesbe]

Title: [167366] trunk/LayoutTests








Revision 167366
Author bjone...@adobe.com
Date 2014-04-16 11:16:54 -0700 (Wed, 16 Apr 2014)


Log Message
Remove references to Leopard and Snow Leopard from Windows TestExpectations

Filed new bugs to track each of these tests, so someone with a windows
build can try and see if the tests still fail.

Unreviewed.

* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/wincairo/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (167365 => 167366)

--- trunk/LayoutTests/ChangeLog	2014-04-16 18:15:04 UTC (rev 167365)
+++ trunk/LayoutTests/ChangeLog	2014-04-16 18:16:54 UTC (rev 167366)
@@ -1,3 +1,15 @@
+2014-04-16  Bem Jones-Bey  bjone...@adobe.com
+
+Remove references to Leopard and Snow Leopard from Windows TestExpectations
+
+Filed new bugs to track each of these tests, so someone with a windows
+build can try and see if the tests still fail.
+
+Unreviewed.
+
+* platform/win/TestExpectations:
+* platform/wincairo/TestExpectations:
+
 2014-04-16  David Hyatt  hy...@apple.com
 
 Make sure to skip the RenderMultiColumnFlowThread when resolving percentage heights inside columns against


Modified: trunk/LayoutTests/platform/win/TestExpectations (167365 => 167366)

--- trunk/LayoutTests/platform/win/TestExpectations	2014-04-16 18:15:04 UTC (rev 167365)
+++ trunk/LayoutTests/platform/win/TestExpectations	2014-04-16 18:16:54 UTC (rev 167366)
@@ -226,7 +226,7 @@
 svg/W3C-SVG-1.1/fonts-elem-04-b.svg
 svg/W3C-SVG-1.1/fonts-elem-07-b.svg
 
-# https://bugs.webkit.org/show_bug.cgi?id=35012 (SVG entity parsing broken on SnowLeopard/Windows)
+# https://bugs.webkit.org/show_bug.cgi?id=131744 (Is SVG Entity parsing still broken on Windows?)
 svg/W3C-SVG-1.1/coords-viewattr-01-b.svg
 svg/zoom/page/zoom-coords-viewattr-01-b.svg
 svg/zoom/text/zoom-coords-viewattr-01-b.svg
@@ -278,10 +278,10 @@
 # This test is dependant on DRT being able to open windows.
 fast/dom/Window/new-window-opener.html
 
-# rdar://problem/5228278 Leopard SVG regression test failures due to different path dimensions
+# https://bugs.webkit.org/show_bug.cgi?id=131745 (Is this still broken on Windows?)
 svg/W3C-SVG-1.1/metadata-example-01-b.svg
 
-# rdar://problem/5539818 REGRESSION (Leopard): http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html failing
+# https://bugs.webkit.org/show_bug.cgi?id=131746 (Is this still broken on Windows?)
 http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html
 
 # rdar://5667007 2 SVG text tests failing (due to bad rounding?)
@@ -339,7 +339,7 @@
 fast/encoding/frame-default-enc.html
 http/tests/misc/frame-default-enc-same-domain.html
 
-# rdar://problem/5539822 REGRESSION (Leopard): svg/custom/stroke-width-click.svg test failing
+# https://bugs.webkit.org/show_bug.cgi?id=131748 (Is this still broken on Windows?)
 svg/custom/stroke-width-click.svg
 
 # Assertion failure in FrameLoader::loadWithDocumentLoader https://bugs.webkit.org/show_bug.cgi?id=23921


Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (167365 => 167366)

--- trunk/LayoutTests/platform/wincairo/TestExpectations	2014-04-16 18:15:04 UTC (rev 167365)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations	2014-04-16 18:16:54 UTC (rev 167366)
@@ -748,7 +748,7 @@
 svg/W3C-SVG-1.1/fonts-elem-04-b.svg
 svg/W3C-SVG-1.1/fonts-elem-07-b.svg
 
-# https://bugs.webkit.org/show_bug.cgi?id=35012 (SVG entity parsing broken on SnowLeopard/Windows)
+# https://bugs.webkit.org/show_bug.cgi?id=131744 (Is SVG Entity parsing still broken on Windows?)
 svg/W3C-SVG-1.1/coords-viewattr-01-b.svg
 svg/zoom/page/zoom-coords-viewattr-01-b.svg
 svg/zoom/text/zoom-coords-viewattr-01-b.svg
@@ -798,10 +798,10 @@
 # This test is dependant on DRT being able to open windows.
 fast/dom/Window/new-window-opener.html
 
-# rdar://problem/5228278 Leopard SVG regression test failures due to different path dimensions
+# https://bugs.webkit.org/show_bug.cgi?id=131745 (Is this still broken on Windows?)
 svg/W3C-SVG-1.1/metadata-example-01-b.svg
 
-# rdar://problem/5539818 REGRESSION (Leopard): http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html failing
+# https://bugs.webkit.org/show_bug.cgi?id=131746 (Is this still broken on Windows?)
 http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html
 
 # rdar://5667007 2 SVG text tests failing (due to bad rounding?)
@@ -862,7 +862,7 @@
 #rdar://problem/5829328 REGRESSION: fast/frames/viewsource-empty-attribute-value.html fails on Windows intermittently
 fast/frames/viewsource-empty-attribute-value.html
 
-# rdar://problem/5539822 REGRESSION (Leopard): svg/custom/stroke-width-click.svg test failing
+# https://bugs.webkit.org/show_bug.cgi?id=131748 (Is this still broken on Windows?)
 svg/custom/stroke-width-click.svg
 

[webkit-changes] [167361] trunk

[cfleizach]

Title: [167361] trunk








Revision 167361
Author cfleiz...@apple.com
Date 2014-04-16 11:04:43 -0700 (Wed, 16 Apr 2014)


Log Message
AX: Accessing a table cell with an invalid column header crashes
https://bugs.webkit.org/show_bug.cgi?id=131719

Reviewed by Darin Adler.

If no tableCell is available as a column/row header, then do not continue processing.

Test: accessibility/table-missing-column-header-crash.html

* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::columnHeaders):
(WebCore::AccessibilityTableCell::rowHeaders):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp


Added Paths

trunk/LayoutTests/accessibility/table-missing-column-header-crash-expected.txt
trunk/LayoutTests/accessibility/table-missing-column-header-crash.html




Diff

Added: trunk/LayoutTests/accessibility/table-missing-column-header-crash-expected.txt (0 => 167361)

--- trunk/LayoutTests/accessibility/table-missing-column-header-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/table-missing-column-header-crash-expected.txt	2014-04-16 18:04:43 UTC (rev 167361)
@@ -0,0 +1,11 @@
+Home	Help	Login
+	Tip us on news
+This tests that accessing invalid column headers does not crash.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/table-missing-column-header-crash.html (0 => 167361)

--- trunk/LayoutTests/accessibility/table-missing-column-header-crash.html	(rev 0)
+++ trunk/LayoutTests/accessibility/table-missing-column-header-crash.html	2014-04-16 18:04:43 UTC (rev 167361)
@@ -0,0 +1,37 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body id=body
+
+table id=table border=1 cellspacing=1
+tbodytrtdtable border=1 width=100%tbody
+trtda href="" accesskey=1Home/a/td
+tda href=""
+tda href=""
+/td/trtrtd colspan=4
+input type=text/tdtd colspan=2a href="" us on news/a/td
+/tr/tbody/table
+
+
+p id=description/p
+div id=console/div
+
+script
+
+description(This tests that accessing invalid column headers does not crash.);
+
+if (window.accessibilityController) {
+var table = accessibilityController.accessibleElementById(table);
+
+var cell = table.childAtIndex(1).childAtIndex(1);
+// This should not crash.
+cell.attributesOfColumnHeaders();
+}
+
+/script
+
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (167360 => 167361)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 18:00:24 UTC (rev 167360)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 18:04:43 UTC (rev 167361)
@@ -1,3 +1,18 @@
+2014-04-16  Chris Fleizach  cfleiz...@apple.com
+
+AX: Accessing a table cell with an invalid column header crashes
+https://bugs.webkit.org/show_bug.cgi?id=131719
+
+Reviewed by Darin Adler.
+
+If no tableCell is available as a column/row header, then do not continue processing.
+
+Test: accessibility/table-missing-column-header-crash.html
+
+* accessibility/AccessibilityTableCell.cpp:
+(WebCore::AccessibilityTableCell::columnHeaders):
+(WebCore::AccessibilityTableCell::rowHeaders):
+
 2014-04-16  Brendan Long  b.l...@cablelabs.com
 
 [GTK] Fix unused parameter warnings


Modified: trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp (167360 => 167361)

--- trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp	2014-04-16 18:00:24 UTC (rev 167360)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp	2014-04-16 18:04:43 UTC (rev 167361)
@@ -177,7 +177,7 @@
 
 for (unsigned row = 0; row  rowRange.first; row++) {
 AccessibilityTableCell* tableCell = parent-cellForColumnAndRow(colRange.first, row);
-if (tableCell == this || headers.contains(tableCell))
+if (!tableCell || tableCell == this || headers.contains(tableCell))
 continue;
 
 std::pairunsigned, unsigned childRowRange;
@@ -205,7 +205,7 @@
 
 for (unsigned column = 0; column  colRange.first; column++) {
 AccessibilityTableCell* tableCell = parent-cellForColumnAndRow(column, rowRange.first);
-if (tableCell == this || headers.contains(tableCell))
+if (!tableCell || tableCell == this || headers.contains(tableCell))
 continue;
 
 const AtomicString scope = tableCell-getAttribute(scopeAttr);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167367] trunk/LayoutTests

[zoltan]

Title: [167367] trunk/LayoutTests








Revision 167367
Author zol...@webkit.org
Date 2014-04-16 11:32:18 -0700 (Wed, 16 Apr 2014)


Log Message
Remove fast/parser/parser-yield-timing.html from skipped list
https://bugs.webkit.org/show_bug.cgi?id=131749

Reviewed by Darin Adler.

The test was originally skipped in Bug 89812 due to flakiness on Chromium
debug bots. I run the tests with huge iterations and I don't see
flakiness on Mavericks release/debug. Let's remove from skipped for now.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (167366 => 167367)

--- trunk/LayoutTests/ChangeLog	2014-04-16 18:16:54 UTC (rev 167366)
+++ trunk/LayoutTests/ChangeLog	2014-04-16 18:32:18 UTC (rev 167367)
@@ -1,3 +1,16 @@
+2014-04-16  Zoltan Horvath  zol...@webkit.org
+
+Remove fast/parser/parser-yield-timing.html from skipped list
+https://bugs.webkit.org/show_bug.cgi?id=131749
+
+Reviewed by Darin Adler.
+
+The test was originally skipped in Bug 89812 due to flakiness on Chromium
+debug bots. I run the tests with huge iterations and I don't see
+flakiness on Mavericks release/debug. Let's remove from skipped for now.
+
+* platform/mac/TestExpectations:
+
 2014-04-16  Bem Jones-Bey  bjone...@adobe.com
 
 Remove references to Leopard and Snow Leopard from Windows TestExpectations


Modified: trunk/LayoutTests/platform/mac/TestExpectations (167366 => 167367)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-04-16 18:16:54 UTC (rev 167366)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-04-16 18:32:18 UTC (rev 167367)
@@ -2,8 +2,6 @@
 #
 # See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
 
-webkit.org/b/89812 fast/parser/parser-yield-timing.html [ Pass Failure ]
-
 # rdar://problem/5647952 fast/events/mouseout-on-window.html needs mac DRT to issue mouse out events
 fast/events/mouseout-on-window.html [ Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167368] trunk

[ap]

Title: [167368] trunk








Revision 167368
Author a...@apple.com
Date 2014-04-16 11:49:39 -0700 (Wed, 16 Apr 2014)


Log Message
DataTransfer should cache its FileList
https://bugs.webkit.org/show_bug.cgi?id=131694

Reviewed by Darin Adler.

Source/WebCore:
Test: fast/events/data-transfer-files-attribute-identity.html

* bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readTerminal):
Switched to a new FileList constructor, CloneDeserializer doesn't really need to modify
the FileList with append().

* dom/DataTransfer.h:
* dom/DataTransfer.cpp:
(WebCore::DataTransfer::types): Added a FIXME.
(WebCore::DataTransfer::files): Changed to reuse a cached FileList. It's currently
easy, because we don't support DataTransferItemList. Once we do, making any changes
through it will also require updating the FileList in a way that doesn't replace
File objects for unchanged files.

* fileapi/FileList.h:
(WebCore::FileList::create):
(WebCore::FileList::isEmpty):
(WebCore::FileList::FileList):
(WebCore::FileList::append):
(WebCore::FileList::clear):
Made non-const functions private, because neither DataTransfer nor FileInputType
expect the list to be modified without their knowledge. Added a new Vector based
constructor so that a FileList could be created without the use of append().

* html/FileInputType.cpp: (WebCore::FileInputType::createFileList): Simplified
the code a little bit. FileInputType still needs to modify the list for clear(),
but doesn't need to add to it dynamically - unlike with DataTransfer, it's expected
to create a new FileList when it's modified.

LayoutTests:
* fast/events/data-transfer-files-attribute-identity-expected.txt: Added.
* fast/events/data-transfer-files-attribute-identity.html: Added.

* platform/wk2/TestExpectations: Skipped the test, because WKTR doesn't support
file dragging yet.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/dom/DataTransfer.cpp
trunk/Source/WebCore/dom/DataTransfer.h
trunk/Source/WebCore/fileapi/FileList.h
trunk/Source/WebCore/html/FileInputType.cpp


Added Paths

trunk/LayoutTests/fast/events/data-transfer-files-attribute-identity-expected.txt
trunk/LayoutTests/fast/events/data-transfer-files-attribute-identity.html




Diff

Modified: trunk/LayoutTests/ChangeLog (167367 => 167368)

--- trunk/LayoutTests/ChangeLog	2014-04-16 18:32:18 UTC (rev 167367)
+++ trunk/LayoutTests/ChangeLog	2014-04-16 18:49:39 UTC (rev 167368)
@@ -1,3 +1,16 @@
+2014-04-16  Alexey Proskuryakov  a...@apple.com
+
+DataTransfer should cache its FileList
+https://bugs.webkit.org/show_bug.cgi?id=131694
+
+Reviewed by Darin Adler.
+
+* fast/events/data-transfer-files-attribute-identity-expected.txt: Added.
+* fast/events/data-transfer-files-attribute-identity.html: Added.
+
+* platform/wk2/TestExpectations: Skipped the test, because WKTR doesn't support
+file dragging yet.
+
 2014-04-16  Zoltan Horvath  zol...@webkit.org
 
 Remove fast/parser/parser-yield-timing.html from skipped list


Added: trunk/LayoutTests/fast/events/data-transfer-files-attribute-identity-expected.txt (0 => 167368)

--- trunk/LayoutTests/fast/events/data-transfer-files-attribute-identity-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/data-transfer-files-attribute-identity-expected.txt	2014-04-16 18:49:39 UTC (rev 167368)
@@ -0,0 +1,12 @@
+
+Test that the same object is returned for dataTransfer.files each time, as well as for File objects in the FileList.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS event.dataTransfer.files is event.dataTransfer.files
+PASS event.dataTransfer.files.item(0) is event.dataTransfer.files.item(0)
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/events/data-transfer-files-attribute-identity.html (0 => 167368)

--- trunk/LayoutTests/fast/events/data-transfer-files-attribute-identity.html	(rev 0)
+++ trunk/LayoutTests/fast/events/data-transfer-files-attribute-identity.html	2014-04-16 18:49:39 UTC (rev 167368)
@@ -0,0 +1,34 @@
+!DOCTYPE html
+html
+head
+meta charset=utf-8
+script src=""
+/head
+body
+input type=file _ondrop_=dropped(event)/input
+div id=console/div
+script
+
+description(Test that the same object is returned for dataTransfer.files each time, as well as for File objects in the FileList.);
+
+function runTest()
+{
+var inputElement = document.getElementsByTagName('input')[0];
+eventSender.beginDragWithFiles(['test.txt']);
+eventSender.mouseMoveTo(inputElement.offsetLeft + inputElement.offsetWidth / 2,
+inputElement.offsetTop + inputElement.offsetHeight / 2);
+eventSender.mouseUp();
+}
+
+function dropped(event)
+{
+shouldBe(event.dataTransfer.files, 

[webkit-changes] [167370] trunk/Tools

[agomez]

Title: [167370] trunk/Tools








Revision 167370
Author ago...@igalia.com
Date 2014-04-16 11:51:56 -0700 (Wed, 16 Apr 2014)


Log Message
[Win] Pass default parameters to cygwin setup wizard
https://bugs.webkit.org/show_bug.cgi?id=131361

Reviewed by Brent Fulgham.

Added some parameters to the cygwin setup wizard so the user
doesn't really have to do any interaction.

* CygwinDownloader/cygwin-downloader.py:
* CygwinDownloader/cygwin-downloader.zip:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/CygwinDownloader/cygwin-downloader.py
trunk/Tools/CygwinDownloader/cygwin-downloader.zip


Property Changed

trunk/Tools/CygwinDownloader/cygwin-downloader.zip




Diff

Modified: trunk/Tools/ChangeLog (167369 => 167370)

--- trunk/Tools/ChangeLog	2014-04-16 18:51:49 UTC (rev 167369)
+++ trunk/Tools/ChangeLog	2014-04-16 18:51:56 UTC (rev 167370)
@@ -1,3 +1,16 @@
+2014-04-16  Andres Gomez  ago...@igalia.com
+
+[Win] Pass default parameters to cygwin setup wizard
+https://bugs.webkit.org/show_bug.cgi?id=131361
+
+Reviewed by Brent Fulgham.
+
+Added some parameters to the cygwin setup wizard so the user
+doesn't really have to do any interaction.
+
+* CygwinDownloader/cygwin-downloader.py:
+* CygwinDownloader/cygwin-downloader.zip:
+
 2014-04-15  Brent Fulgham  bfulg...@apple.com
 
 [Win] Eliminate use of deleteAllValues in Windows Files


Modified: trunk/Tools/CygwinDownloader/cygwin-downloader.py (167369 => 167370)

--- trunk/Tools/CygwinDownloader/cygwin-downloader.py	2014-04-16 18:51:49 UTC (rev 167369)
+++ trunk/Tools/CygwinDownloader/cygwin-downloader.py	2014-04-16 18:51:56 UTC (rev 167370)
@@ -149,11 +149,9 @@
 
 print 
 Finished downloading Cygwin. In %d seconds,
-I will run setup.exe. Select the Install
-from Local Directory option and browse to
-%s
-when asked for the Local Package Directory.
- % (seconds_to_sleep, os.getcwd())
+I will run setup.exe. All the suitable options have
+been already selected for you.
+ % (seconds_to_sleep)
 
 
 while seconds_to_sleep  0:
@@ -164,4 +162,4 @@
 print
 
 if not dry_run:
-os.execl(setup.exe)
+os.execv(setup.exe, list((-L, -l, os.getcwd(), -P, ,.join(required_packages


Modified: trunk/Tools/CygwinDownloader/cygwin-downloader.zip

(Binary files differ)

Property changes on: trunk/Tools/CygwinDownloader/cygwin-downloader.zip
___

Added: svn:executable




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167374] trunk/LayoutTests

[ddkilzer]

Title: [167374] trunk/LayoutTests








Revision 167374
Author ddkil...@apple.com
Date 2014-04-16 12:01:00 -0700 (Wed, 16 Apr 2014)


Log Message
Remove test results that match platform/mac results

Found using this shell script:

$ for F in `find LayoutTests/platform/ios-sim -name \*-expected.txt`; do \
T=`echo $F | sed -e 's#platform/ios-sim/##'`; \
M=`echo $F | sed -e 's#platform/ios-sim/#platform/mac/#'`; \
ML=`echo $F | sed -e 's#platform/ios-sim/#platform/mac-mountainlion/#'`; \
if [ -f $M -a ! -f $ML -a -z `diff -u $F $M 2 /dev/null` ]; then echo $F; fi; \
done

* platform/ios-sim/fast/block/positioning/016-expected.txt: Removed.
* platform/ios-sim/fast/block/positioning/025-expected.txt: Removed.
* platform/ios-sim/fast/dom/icon-url-property-expected.txt: Removed.
* platform/ios-sim/fast/hidpi/focus-rings-expected.txt: Removed.
* platform/ios-sim/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Removed.
* platform/ios-sim/fast/preloader/document-write-2-expected.txt: Removed.
* platform/ios-sim/fast/preloader/script-expected.txt: Removed.
* platform/ios-sim/fast/writing-mode/broken-ideograph-small-caps-expected.txt: Removed.
* platform/ios-sim/fast/xsl/sort-locale-expected.txt: Removed.
* platform/ios-sim/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Removed.
* platform/ios-sim/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Removed.
* platform/ios-sim/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Removed.
* platform/ios-sim/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/ios-sim/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/ios-sim/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/ios-sim/fast/dom/icon-url-property-expected.txt
trunk/LayoutTests/platform/ios-sim/fast/hidpi/focus-rings-expected.txt
trunk/LayoutTests/platform/ios-sim/fast/multicol/shrink-to-column-height-for-pagination-expected.txt
trunk/LayoutTests/platform/ios-sim/fast/preloader/document-write-2-expected.txt
trunk/LayoutTests/platform/ios-sim/fast/preloader/script-expected.txt
trunk/LayoutTests/platform/ios-sim/fast/writing-mode/broken-ideograph-small-caps-expected.txt
trunk/LayoutTests/platform/ios-sim/fast/xsl/sort-locale-expected.txt
trunk/LayoutTests/platform/ios-sim/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/ios-sim/sputnik/
trunk/LayoutTests/platform/ios-sim/webarchive/loading/mainresource-null-mimetype-crash-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (167373 => 167374)

--- trunk/LayoutTests/ChangeLog	2014-04-16 19:00:55 UTC (rev 167373)
+++ trunk/LayoutTests/ChangeLog	2014-04-16 19:01:00 UTC (rev 167374)
@@ -1,5 +1,32 @@
 2014-04-16  David Kilzer  ddkil...@apple.com
 
+Remove test results that match platform/mac results
+
+Found using this shell script:
+
+$ for F in `find LayoutTests/platform/ios-sim -name \*-expected.txt`; do \
+T=`echo $F | sed -e 's#platform/ios-sim/##'`; \
+M=`echo $F | sed -e 's#platform/ios-sim/#platform/mac/#'`; \
+ML=`echo $F | sed -e 's#platform/ios-sim/#platform/mac-mountainlion/#'`; \
+if [ -f $M -a ! -f $ML -a -z `diff -u $F $M 2 /dev/null` ]; then echo $F; fi; \
+done
+
+* platform/ios-sim/fast/block/positioning/016-expected.txt: Removed.
+* platform/ios-sim/fast/block/positioning/025-expected.txt: Removed.
+* platform/ios-sim/fast/dom/icon-url-property-expected.txt: Removed.
+* platform/ios-sim/fast/hidpi/focus-rings-expected.txt: Removed.
+* platform/ios-sim/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Removed.
+* platform/ios-sim/fast/preloader/document-write-2-expected.txt: Removed.
+* platform/ios-sim/fast/preloader/script-expected.txt: Removed.
+* platform/ios-sim/fast/writing-mode/broken-ideograph-small-caps-expected.txt: Removed.
+* platform/ios-sim/fast/xsl/sort-locale-expected.txt: Removed.
+* platform/ios-sim/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Removed.
+* platform/ios-sim/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Removed.
+* platform/ios-sim/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Removed.
+* platform/ios-sim/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Removed.
+
+2014-04-16  David Kilzer  ddkil...@apple.com
+
 Remove test results that match top-level results
 
 Found using this shell script:


Deleted: trunk/LayoutTests/platform/ios-sim/fast/block/positioning/016-expected.txt (167373 => 167374)

--- trunk/LayoutTests/platform/ios-sim/fast/block/positioning/016-expected.txt	2014-04-16 19:00:55 UTC (rev 167373)
+++ 

[webkit-changes] [167375] trunk/Source/WebCore

[simon . fraser]

Title: [167375] trunk/Source/WebCore








Revision 167375
Author simon.fra...@apple.com
Date 2014-04-16 12:12:57 -0700 (Wed, 16 Apr 2014)


Log Message
Fix the iOS build.

* platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::draw):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (167374 => 167375)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 19:01:00 UTC (rev 167374)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 19:12:57 UTC (rev 167375)
@@ -1,3 +1,10 @@
+2014-04-16  Simon Fraser  simon.fra...@apple.com
+
+Fix the iOS build.
+
+* platform/graphics/cg/BitmapImageCG.cpp:
+(WebCore::BitmapImage::draw):
+
 2014-04-16  Alexey Proskuryakov  a...@apple.com
 
 DataTransfer should cache its FileList


Modified: trunk/Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp (167374 => 167375)

--- trunk/Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp	2014-04-16 19:01:00 UTC (rev 167374)
+++ trunk/Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp	2014-04-16 19:12:57 UTC (rev 167375)
@@ -204,7 +204,7 @@
 
 image = frameAtIndex(m_currentFrame);
 #else
-startAnimation(false);
+startAnimation(DoNotCatchUp);
 
 CGRect transformedDestinationRect = CGRectApplyAffineTransform(destRect, CGContextGetCTM(ctxt-platformContext()));
 RetainPtrCGImageRef imagePossiblyCopied;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167376] trunk/Source/WebCore

[zoltan]

Title: [167376] trunk/Source/WebCore








Revision 167376
Author zol...@webkit.org
Date 2014-04-16 12:37:34 -0700 (Wed, 16 Apr 2014)


Log Message
Cleanup header includes in ShapeOutsideInfo.h
https://bugs.webkit.org/show_bug.cgi?id=131750

Reviewed by Antti Koivisto.

Make the build faster by removing unnecessary header includes.

No new tests, no behavior change.

* rendering/shapes/ShapeOutsideInfo.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (167375 => 167376)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 19:12:57 UTC (rev 167375)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 19:37:34 UTC (rev 167376)
@@ -1,3 +1,16 @@
+2014-04-16  Zoltan Horvath  zol...@webkit.org
+
+Cleanup header includes in ShapeOutsideInfo.h
+https://bugs.webkit.org/show_bug.cgi?id=131750
+
+Reviewed by Antti Koivisto.
+
+Make the build faster by removing unnecessary header includes.
+
+No new tests, no behavior change.
+
+* rendering/shapes/ShapeOutsideInfo.h:
+
 2014-04-16  Simon Fraser  simon.fra...@apple.com
 
 Fix the iOS build.


Modified: trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.h (167375 => 167376)

--- trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.h	2014-04-16 19:12:57 UTC (rev 167375)
+++ trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.h	2014-04-16 19:37:34 UTC (rev 167376)
@@ -32,13 +32,8 @@
 
 #if ENABLE(CSS_SHAPES)
 
-#include FloatRect.h
 #include LayoutSize.h
-#include LayoutUnit.h
-#include RenderStyle.h
 #include Shape.h
-#include ShapeValue.h
-#include memory
 
 namespace WebCore {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167377] trunk/Source/WebCore

[commit-queue]

Title: [167377] trunk/Source/WebCore








Revision 167377
Author commit-qu...@webkit.org
Date 2014-04-16 12:54:03 -0700 (Wed, 16 Apr 2014)


Log Message
[curl] Add WEB_TIMING support
https://bugs.webkit.org/show_bug.cgi?id=127555

Patch by Robert Sipka si...@inf.u-szeged.hu on 2014-04-16
Reviewed by Brent Fulgham.

Access timing information related to navigation.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::milisecondsSinceRequest):
(WebCore::calculateWebTimingInformations):
(WebCore::sockoptfunction):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::dispatchSynchronousJob):
(WebCore::ResourceHandleManager::initializeHandle):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (167376 => 167377)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 19:37:34 UTC (rev 167376)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 19:54:03 UTC (rev 167377)
@@ -1,3 +1,21 @@
+2014-04-16  Robert Sipka  si...@inf.u-szeged.hu
+
+[curl] Add WEB_TIMING support
+https://bugs.webkit.org/show_bug.cgi?id=127555
+
+Reviewed by Brent Fulgham.
+
+Access timing information related to navigation.
+
+* platform/network/curl/ResourceHandleManager.cpp:
+(WebCore::milisecondsSinceRequest):
+(WebCore::calculateWebTimingInformations):
+(WebCore::sockoptfunction):
+(WebCore::headerCallback):
+(WebCore::ResourceHandleManager::downloadTimerCallback):
+(WebCore::ResourceHandleManager::dispatchSynchronousJob):
+(WebCore::ResourceHandleManager::initializeHandle):
+
 2014-04-16  Zoltan Horvath  zol...@webkit.org
 
 Cleanup header includes in ShapeOutsideInfo.h


Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp (167376 => 167377)

--- trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp	2014-04-16 19:37:34 UTC (rev 167376)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp	2014-04-16 19:54:03 UTC (rev 167377)
@@ -61,6 +61,9 @@
 
 #include errno.h
 #include stdio.h
+#if ENABLE(WEB_TIMING)
+#include wtf/CurrentTime.h
+#endif
 #if USE(CF)
 #include wtf/RetainPtr.h
 #endif
@@ -147,6 +150,53 @@
 }
 }
 
+#if ENABLE(WEB_TIMING)
+static int milisecondsSinceRequest(double requestTime)
+{
+return static_castint((monotonicallyIncreasingTime() - requestTime) * 1000.0);
+}
+
+static void calculateWebTimingInformations(ResourceHandleInternal* d)
+{
+double startTransfertTime;
+double preTransferTime;
+double dnslookupTime;
+double connectTime;
+double appConnectTime;
+
+curl_easy_getinfo(d-m_handle, CURLINFO_NAMELOOKUP_TIME, dnslookupTime);
+curl_easy_getinfo(d-m_handle, CURLINFO_CONNECT_TIME, connectTime);
+curl_easy_getinfo(d-m_handle, CURLINFO_APPCONNECT_TIME, appConnectTime);
+curl_easy_getinfo(d-m_handle, CURLINFO_STARTTRANSFER_TIME, startTransfertTime);
+curl_easy_getinfo(d-m_handle, CURLINFO_PRETRANSFER_TIME, preTransferTime);
+
+d-m_response.resourceLoadTiming()-dnsStart = 0;
+d-m_response.resourceLoadTiming()-dnsEnd = static_castint(dnslookupTime * 1000);
+
+d-m_response.resourceLoadTiming()-connectStart = static_castint(dnslookupTime * 1000);
+d-m_response.resourceLoadTiming()-connectEnd = static_castint(connectTime * 1000);
+
+d-m_response.resourceLoadTiming()-sendStart = static_castint(connectTime *1000);
+d-m_response.resourceLoadTiming()-sendEnd =static_castint(preTransferTime * 1000);
+
+if (appConnectTime) {
+d-m_response.resourceLoadTiming()-sslStart = static_castint(connectTime * 1000);
+d-m_response.resourceLoadTiming()-sslEnd = static_castint(appConnectTime *1000);
+}
+}
+
+static int sockoptfunction(void* data, curl_socket_t /*curlfd*/, curlsocktype /*purpose*/)
+{
+ResourceHandle* job = static_castResourceHandle*(data);
+ResourceHandleInternal* d = job-getInternal();
+
+if (d-m_response.resourceLoadTiming())
+d-m_response.resourceLoadTiming()-requestTime = monotonicallyIncreasingTime();
+
+return 0;
+}
+#endif
+
 // libcurl does not implement its own thread synchronization primitives.
 // these two functions provide mutexes for cookies, and for the global DNS
 // cache.
@@ -449,6 +499,11 @@
 d-m_multipartHandle = MultipartHandle::create(job, boundary);
 }
 
+#if ENABLE(WEB_TIMING)
+if (d-m_response.resourceLoadTiming()  d-m_response.resourceLoadTiming()-requestTime)
+d-m_response.resourceLoadTiming()-receiveHeadersEnd = milisecondsSinceRequest(d-m_response.resourceLoadTiming()-requestTime);
+#endif
+
 // HTTP redirection
 if (isHttpRedirect(httpCode)) {
 String location = d-m_response.httpHeaderField(location);
@@ -476,10 +531,9 @@
 }
 }
 
-if (client) {
-  

[webkit-changes] [167378] trunk/Source/WTF

[barraclough]

Title: [167378] trunk/Source/WTF








Revision 167378
Author barraclo...@apple.com
Date 2014-04-16 12:57:02 -0700 (Wed, 16 Apr 2014)


Log Message
Update to pthread QoS SPI
https://bugs.webkit.org/show_bug.cgi?id=131753

Rubber stamped by Benjamin Poulain

* wtf/ThreadingPthreads.cpp:
(WTF::setCurrentThreadQOSUtility):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ThreadingPthreads.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (167377 => 167378)

--- trunk/Source/WTF/ChangeLog	2014-04-16 19:54:03 UTC (rev 167377)
+++ trunk/Source/WTF/ChangeLog	2014-04-16 19:57:02 UTC (rev 167378)
@@ -1,3 +1,13 @@
+2014-04-16  Gavin Barraclough  barraclo...@apple.com
+
+Update to pthread QoS SPI
+https://bugs.webkit.org/show_bug.cgi?id=131753
+
+Rubber stamped by Benjamin Poulain
+
+* wtf/ThreadingPthreads.cpp:
+(WTF::setCurrentThreadQOSUtility):
+
 2014-04-14  Geoffrey Garen  gga...@apple.com
 
 WTF should have an optional mbmalloc target so we can benchmark FastMalloc


Modified: trunk/Source/WTF/wtf/ThreadingPthreads.cpp (167377 => 167378)

--- trunk/Source/WTF/wtf/ThreadingPthreads.cpp	2014-04-16 19:54:03 UTC (rev 167377)
+++ trunk/Source/WTF/wtf/ThreadingPthreads.cpp	2014-04-16 19:57:02 UTC (rev 167378)
@@ -237,7 +237,7 @@
 void setCurrentThreadQOSUtility()
 {
 #if OS(MAC_OS_X)  __MAC_OS_X_VERSION_MIN_REQUIRED = 101000
-pthread_set_qos_class_np(pthread_self(), QOS_CLASS_UTILITY, 0);
+pthread_set_qos_class_self_np(QOS_CLASS_UTILITY, 0);
 #endif
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167379] trunk/Source/WebKit2

[ap]

Title: [167379] trunk/Source/WebKit2








Revision 167379
Author a...@apple.com
Date 2014-04-16 13:02:48 -0700 (Wed, 16 Apr 2014)


Log Message
Updating tests after bug 131721, [GTK] Fix unused parameter warnings.

* Scripts/webkit2/LegacyMessageReceiver-expected.cpp:
(WebKit::WebPage::didReceiveWebPageMessage):
(WebKit::WebPage::didReceiveSyncWebPageMessage):
* Scripts/webkit2/MessageReceiver-expected.cpp:
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp
trunk/Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167378 => 167379)

--- trunk/Source/WebKit2/ChangeLog	2014-04-16 19:57:02 UTC (rev 167378)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-16 20:02:48 UTC (rev 167379)
@@ -1,3 +1,14 @@
+2014-04-16  Alexey Proskuryakov  a...@apple.com
+
+Updating tests after bug 131721, [GTK] Fix unused parameter warnings.
+
+* Scripts/webkit2/LegacyMessageReceiver-expected.cpp:
+(WebKit::WebPage::didReceiveWebPageMessage):
+(WebKit::WebPage::didReceiveSyncWebPageMessage):
+* Scripts/webkit2/MessageReceiver-expected.cpp:
+(WebKit::WebPage::didReceiveMessage):
+(WebKit::WebPage::didReceiveSyncMessage):
+
 2014-04-16  Brendan Long  b.l...@cablelabs.com
 
 [GTK] Fix unused parameter warnings


Modified: trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp (167378 => 167379)

--- trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp	2014-04-16 19:57:02 UTC (rev 167378)
+++ trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp	2014-04-16 20:02:48 UTC (rev 167379)
@@ -184,6 +184,7 @@
 return;
 }
 #endif
+UNUSED_PARAM(decoder);
 ASSERT_NOT_REACHED();
 }
 
@@ -215,6 +216,8 @@
 return;
 }
 #endif
+UNUSED_PARAM(decoder);
+UNUSED_PARAM(replyEncoder);
 ASSERT_NOT_REACHED();
 }
 


Modified: trunk/Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp (167378 => 167379)

--- trunk/Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp	2014-04-16 19:57:02 UTC (rev 167378)
+++ trunk/Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp	2014-04-16 20:02:48 UTC (rev 167379)
@@ -185,6 +185,7 @@
 }
 #endif
 UNUSED_PARAM(connection);
+UNUSED_PARAM(decoder);
 ASSERT_NOT_REACHED();
 }
 
@@ -217,6 +218,8 @@
 }
 #endif
 UNUSED_PARAM(connection);
+UNUSED_PARAM(decoder);
+UNUSED_PARAM(replyEncoder);
 ASSERT_NOT_REACHED();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167380] trunk

[oliver]

Title: [167380] trunk








Revision 167380
Author oli...@apple.com
Date 2014-04-16 13:10:41 -0700 (Wed, 16 Apr 2014)


Log Message
Simple ES6 feature:Array.prototype.fill
https://bugs.webkit.org/show_bug.cgi?id=131703

Reviewed by David Hyatt.

Source/_javascript_Core:
Add support for Array.prototype.fill

* builtins/Array.prototype.js:
(fill):
* runtime/ArrayPrototype.cpp:

LayoutTests:
Add tests.

* js/Object-getOwnPropertyNames-expected.txt:
* js/array-fill-expected.txt: Added.
* js/array-fill.html: Added.
* js/script-tests/Object-getOwnPropertyNames.js:
* js/script-tests/array-fill.js: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt
trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/Array.prototype.js
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp


Added Paths

trunk/LayoutTests/js/array-fill-expected.txt
trunk/LayoutTests/js/array-fill.html
trunk/LayoutTests/js/script-tests/array-fill.js




Diff

Modified: trunk/LayoutTests/ChangeLog (167379 => 167380)

--- trunk/LayoutTests/ChangeLog	2014-04-16 20:02:48 UTC (rev 167379)
+++ trunk/LayoutTests/ChangeLog	2014-04-16 20:10:41 UTC (rev 167380)
@@ -1,3 +1,18 @@
+2014-04-16  Oliver Hunt  oli...@apple.com
+
+Simple ES6 feature:Array.prototype.fill
+https://bugs.webkit.org/show_bug.cgi?id=131703
+
+Reviewed by David Hyatt.
+
+Add tests.
+
+* js/Object-getOwnPropertyNames-expected.txt:
+* js/array-fill-expected.txt: Added.
+* js/array-fill.html: Added.
+* js/script-tests/Object-getOwnPropertyNames.js:
+* js/script-tests/array-fill.js: Added.
+
 2014-04-16  David Kilzer  ddkil...@apple.com
 
 Remove test results that match platform/mac results


Modified: trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt (167379 => 167380)

--- trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt	2014-04-16 20:02:48 UTC (rev 167379)
+++ trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt	2014-04-16 20:10:41 UTC (rev 167380)
@@ -45,7 +45,7 @@
 PASS getSortedOwnPropertyNames(Function) is ['length', 'name', 'prototype']
 PASS getSortedOwnPropertyNames(Function.prototype) is ['apply', 'bind', 'call', 'constructor', 'length', 'name', 'toString']
 PASS getSortedOwnPropertyNames(Array) is ['isArray', 'length', 'name', 'prototype']
-PASS getSortedOwnPropertyNames(Array.prototype) is ['concat', 'constructor', 'entries', 'every', 'filter', 'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift']
+PASS getSortedOwnPropertyNames(Array.prototype) is ['concat', 'constructor', 'entries', 'every', 'fill', 'filter', 'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift']
 PASS getSortedOwnPropertyNames(String) is ['fromCharCode', 'length', 'name', 'prototype']
 PASS getSortedOwnPropertyNames(String.prototype) is ['anchor', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'concat', 'constructor', 'fixed', 'fontcolor', 'fontsize', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'replace', 'search', 'slice', 'small', 'split', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimLeft', 'trimRight', 'valueOf']
 PASS getSortedOwnPropertyNames(Boolean) is ['length', 'name', 'prototype']


Added: trunk/LayoutTests/js/array-fill-expected.txt (0 => 167380)

--- trunk/LayoutTests/js/array-fill-expected.txt	(rev 0)
+++ trunk/LayoutTests/js/array-fill-expected.txt	2014-04-16 20:10:41 UTC (rev 167380)
@@ -0,0 +1,20 @@
+This test checks the behavior of the Array.prototype.fill()
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS [0, 0, 0, 0, 0].fill() is [undefined, undefined, undefined, undefined, undefined]
+PASS [0, 0, 0, 0, 0].fill(3) is [3, 3, 3, 3, 3]
+PASS [0, 0, 0, 0, 0].fill(3, 1) is [0, 3, 3, 3, 3]
+PASS [0, 0, 0, 0, 0].fill(3, 1, 3) is [0, 3, 3, 0, 0]
+PASS [0, 0, 0, 0, 0].fill(3, 1, 1000) is [0, 3, 3, 3, 3]
+PASS [0, 0, 0, 0, 0].fill(3, -2, 1000) is [0, 0, 0, 3, 3]
+PASS [0, 0, 0, 0, 0].fill(3, -2, 4) is [0, 0, 0, 3, 0]
+PASS [0, 0, 0, 0, 0].fill(3, -2, -1) is [0, 0, 0, 3, 0]
+PASS [0, 0, 0, 0, 0].fill(3, -2, -3) is [0, 0, 0, 0, 0]
+PASS [0, 0, 0, 0, 0].fill(3, undefined, 4) is [3, 3, 3, 3, 0]
+PASS [ ,  ,  ,  , 0].fill(3, 1, 3) is [, 3, 3, , 0]
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/js/array-fill.html (0 => 167380)

--- trunk/LayoutTests/js/array-fill.html	(rev 0)
+++ 

[webkit-changes] [167382] trunk/Source/JavaScriptCore

[commit-queue]

Title: [167382] trunk/Source/_javascript_Core








Revision 167382
Author commit-qu...@webkit.org
Date 2014-04-16 13:54:43 -0700 (Wed, 16 Apr 2014)


Log Message
Fix JSC Debug Regressions on Windows
https://bugs.webkit.org/show_bug.cgi?id=131182

Patch by pe...@outlook.com pe...@outlook.com on 2014-04-16
Reviewed by Brent Fulgham.

The cast static_castint64_t(number) in JSValue::isMachineInt() can generate a floating point error,
and set the st floating point register tags, if the value of the number parameter is infinite.
If the st floating point register tags are not cleared, this can cause strange floating point behavior later on.
This can be avoided by checking for infinity first.

* runtime/JSCJSValueInlines.h:
(JSC::JSValue::isMachineInt): Avoid floating point error by checking for infinity first.
* runtime/Options.cpp:
(JSC::recomputeDependentOptions): Re-enable jit for Windows.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h
trunk/Source/_javascript_Core/runtime/Options.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167381 => 167382)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-16 20:43:12 UTC (rev 167381)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-16 20:54:43 UTC (rev 167382)
@@ -1,3 +1,20 @@
+2014-04-16  pe...@outlook.com  pe...@outlook.com
+
+Fix JSC Debug Regressions on Windows
+https://bugs.webkit.org/show_bug.cgi?id=131182
+
+Reviewed by Brent Fulgham.
+
+The cast static_castint64_t(number) in JSValue::isMachineInt() can generate a floating point error,
+and set the st floating point register tags, if the value of the number parameter is infinite.
+If the st floating point register tags are not cleared, this can cause strange floating point behavior later on.
+This can be avoided by checking for infinity first.
+
+* runtime/JSCJSValueInlines.h:
+(JSC::JSValue::isMachineInt): Avoid floating point error by checking for infinity first.
+* runtime/Options.cpp:
+(JSC::recomputeDependentOptions): Re-enable jit for Windows.
+
 2014-04-16  Oliver Hunt  oli...@apple.com
 
 Simple ES6 feature:Array.prototype.fill


Modified: trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h (167381 => 167382)

--- trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h	2014-04-16 20:43:12 UTC (rev 167381)
+++ trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h	2014-04-16 20:54:43 UTC (rev 167382)
@@ -504,6 +504,11 @@
 double number = asDouble();
 if (number != number)
 return false;
+#if OS(WINDOWS)
+// Need to check for infinity on Windows to avoid floating point error on following cast, see bug 131182.
+if (std::isinf(number))
+return false;
+#endif
 int64_t asInt64 = static_castint64_t(number);
 if (asInt64 != number)
 return false;


Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (167381 => 167382)

--- trunk/Source/_javascript_Core/runtime/Options.cpp	2014-04-16 20:43:12 UTC (rev 167381)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp	2014-04-16 20:54:43 UTC (rev 167382)
@@ -226,11 +226,6 @@
 #if !ENABLE(FTL_JIT)
 Options::useFTLJIT() = false;
 #endif
-#if OS(WINDOWS)
-// Temporarily disable the JIT on Windows until we have a fix for
-// https://webkit.org/b/131182.
-Options::useJIT() = false;
-#endif
 
 if (Options::showDisassembly()
 || Options::showDFGDisassembly()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167384] trunk/Source/WebCore

[bjonesbe]

Title: [167384] trunk/Source/WebCore








Revision 167384
Author bjone...@adobe.com
Date 2014-04-16 14:14:22 -0700 (Wed, 16 Apr 2014)


Log Message
Fix CodeGenerator.pm to only write files if the generated content has changed
https://bugs.webkit.org/show_bug.cgi?id=131756

Reviewed by Sam Weinig.

To improve build speed, don't touch generated files unless the newly
generated content is actually different.

* bindings/scripts/CodeGenerator.pm:
(UpdateFile):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (167383 => 167384)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 21:07:49 UTC (rev 167383)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 21:14:22 UTC (rev 167384)
@@ -1,3 +1,16 @@
+2014-04-16  Bem Jones-Bey  bjone...@adobe.com
+
+Fix CodeGenerator.pm to only write files if the generated content has changed
+https://bugs.webkit.org/show_bug.cgi?id=131756
+
+Reviewed by Sam Weinig.
+
+To improve build speed, don't touch generated files unless the newly
+generated content is actually different.
+
+* bindings/scripts/CodeGenerator.pm:
+(UpdateFile):
+
 2014-04-16  Andreas Kling  akl...@apple.com
 
 Add a way to cache never-changing IDL attributes in the wrapper.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (167383 => 167384)

--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm	2014-04-16 21:07:49 UTC (rev 167383)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm	2014-04-16 21:14:22 UTC (rev 167384)
@@ -166,9 +166,16 @@
 my $fileName = shift;
 my $contents = shift;
 
-open FH,  $fileName or die Couldn't open $fileName: $!\n;
-print FH $contents;
-close FH;
+if (-e $fileName) {
+open my $fh, , $fileName or die Couldn't open $fileName: $!\n;
+my $oldcontents = join '', $fh;
+close $fh or die Couldn't close $fileName: $!\n;
+return if $contents eq $oldcontents;
+}
+
+open my $fh, , $fileName or die Couldn't open $fileName: $!\n;
+print $fh $contents;
+close $fh or die Couldn't close $fileName: $!\n
 }
 
 sub ForAllParents






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167386] trunk/Source/WebKit2

[barraclough]

Title: [167386] trunk/Source/WebKit2








Revision 167386
Author barraclo...@apple.com
Date 2014-04-16 14:34:35 -0700 (Wed, 16 Apr 2014)


Log Message
REGRESSION: PCE.js is 20x slower in WebKit2 because timers are throttled
https://bugs.webkit.org/show_bug.cgi?id=131189

Unreviewed rollout of r166754

This change is no longer necessary.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167385 => 167386)

--- trunk/Source/WebKit2/ChangeLog	2014-04-16 21:24:02 UTC (rev 167385)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-16 21:34:35 UTC (rev 167386)
@@ -1,3 +1,15 @@
+2014-04-16  Gavin Barraclough  baraclo...@apple.com
+
+REGRESSION: PCE.js is 20x slower in WebKit2 because timers are throttled
+https://bugs.webkit.org/show_bug.cgi?id=131189
+
+Unreviewed rollout of r166754
+
+This change is no longer necessary.
+
+* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+(WebKit::connectToService):
+
 2014-04-16  Alexey Proskuryakov  a...@apple.com
 
 Updating tests after bug 131721, [GTK] Fix unused parameter warnings.


Modified: trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm (167385 => 167386)

--- trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm	2014-04-16 21:24:02 UTC (rev 167385)
+++ trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm	2014-04-16 21:34:35 UTC (rev 167386)
@@ -180,16 +180,9 @@
 xpc_connection_set_event_handler(connection, ^(xpc_object_t event) { });
 xpc_connection_resume(connection);
 
-#if ENABLE(NETWORK_PROCESS) || OS(IOS)
-#if OS(IOS)
-// Leak a boost onto any WebKit2 process.
-bool shouldBoost = true;
-#else
+#if ENABLE(NETWORK_PROCESS)
 // Leak a boost onto the NetworkProcess.
-bool shouldBoost = launchOptions.processType == ProcessLauncher::NetworkProcess;
-#endif
-
-if (shouldBoost) {
+if (launchOptions.processType == ProcessLauncher::NetworkProcess) {
 xpc_object_t preBootstrapMessage = xpc_dictionary_create(0, 0, 0);
 xpc_dictionary_set_string(preBootstrapMessage, message-name, pre-bootstrap);
 xpc_connection_send_message(connection, preBootstrapMessage);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167388] trunk/Source/WebKit2

[timothy_horton]

Title: [167388] trunk/Source/WebKit2








Revision 167388
Author timothy_hor...@apple.com
Date 2014-04-16 14:53:51 -0700 (Wed, 16 Apr 2014)


Log Message
Minor include sanity in WebPage.h
https://bugs.webkit.org/show_bug.cgi?id=131752

Reviewed by Simon Fraser.

* WebProcess/WebPage/WebPage.h:
Remove a bunch of unnecessary includes.
Un-indent some stuff.

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebPage/FindController.cpp:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/mac/WebPageMac.mm:
Add back more specific includes, into implementation files.

* WebProcess/WebPage/WebUndoStep.cpp:
(WebKit::WebUndoStep::~WebUndoStep):
* WebProcess/WebPage/WebUndoStep.h:
Add an out-of-line destructor.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/LayerTreeContext.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebUndoStep.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebUndoStep.h
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167387 => 167388)

--- trunk/Source/WebKit2/ChangeLog	2014-04-16 21:50:57 UTC (rev 167387)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-16 21:53:51 UTC (rev 167388)
@@ -1,3 +1,26 @@
+2014-04-16  Tim Horton  timothy_hor...@apple.com
+
+Minor include sanity in WebPage.h
+https://bugs.webkit.org/show_bug.cgi?id=131752
+
+Reviewed by Simon Fraser.
+
+* WebProcess/WebPage/WebPage.h:
+Remove a bunch of unnecessary includes.
+Un-indent some stuff.
+
+* WebProcess/WebCoreSupport/WebEditorClient.cpp:
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+* WebProcess/WebPage/FindController.cpp:
+* WebProcess/WebPage/WebPage.cpp:
+* WebProcess/WebPage/mac/WebPageMac.mm:
+Add back more specific includes, into implementation files.
+
+* WebProcess/WebPage/WebUndoStep.cpp:
+(WebKit::WebUndoStep::~WebUndoStep):
+* WebProcess/WebPage/WebUndoStep.h:
+Add an out-of-line destructor.
+
 2014-04-16  Gavin Barraclough  baraclo...@apple.com
 
 REGRESSION: PCE.js is 20x slower in WebKit2 because timers are throttled


Modified: trunk/Source/WebKit2/Shared/LayerTreeContext.h (167387 => 167388)

--- trunk/Source/WebKit2/Shared/LayerTreeContext.h	2014-04-16 21:50:57 UTC (rev 167387)
+++ trunk/Source/WebKit2/Shared/LayerTreeContext.h	2014-04-16 21:53:51 UTC (rev 167388)
@@ -29,8 +29,8 @@
 #include stdint.h
 
 namespace IPC {
-class ArgumentDecoder;
-class ArgumentEncoder;
+class ArgumentDecoder;
+class ArgumentEncoder;
 }
 
 namespace WebKit {


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp (167387 => 167388)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp	2014-04-16 21:50:57 UTC (rev 167387)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp	2014-04-16 21:53:51 UTC (rev 167388)
@@ -34,6 +34,7 @@
 #include WebPageProxy.h
 #include WebPageProxyMessages.h
 #include WebProcess.h
+#include WebUndoStep.h
 #include WebCore/ArchiveResource.h
 #include WebCore/DocumentFragment.h
 #include WebCore/FocusController.h


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (167387 => 167388)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2014-04-16 21:50:57 UTC (rev 167387)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2014-04-16 21:53:51 UTC (rev 167388)
@@ -28,6 +28,7 @@
 
 #include AuthenticationManager.h
 #include DataReference.h
+#include DrawingArea.h
 #include InjectedBundle.h
 #include InjectedBundleBackForwardListItem.h
 #include InjectedBundleDOMWindowExtension.h


Modified: trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp (167387 => 167388)

--- trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2014-04-16 21:50:57 UTC (rev 167387)
+++ trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2014-04-16 21:53:51 UTC (rev 167388)
@@ -26,6 +26,7 @@
 #include config.h
 #include FindController.h
 
+#include DrawingArea.h
 #include PluginView.h
 #include ShareableBitmap.h
 #include WKPage.h


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (167387 => 167388)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2014-04-16 21:50:57 UTC (rev 167387)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2014-04-16 21:53:51 UTC (rev 167388)
@@ -90,6 +90,7 @@
 #include WebProcess.h
 #include WebProcessProxyMessages.h
 #include WebProgressTrackerClient.h
+#include 

[webkit-changes] [167389] trunk/Tools

[commit-queue]

Title: [167389] trunk/Tools








Revision 167389
Author commit-qu...@webkit.org
Date 2014-04-16 14:58:23 -0700 (Wed, 16 Apr 2014)


Log Message
[Win] run-_javascript_core-tests fails to run.
https://bugs.webkit.org/show_bug.cgi?id=131761

Patch by pe...@outlook.com pe...@outlook.com on 2014-04-16
Reviewed by Brent Fulgham.

* Scripts/build-jsc: For now, don't try to build bmalloc on Windows.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-jsc




Diff

Modified: trunk/Tools/ChangeLog (167388 => 167389)

--- trunk/Tools/ChangeLog	2014-04-16 21:53:51 UTC (rev 167388)
+++ trunk/Tools/ChangeLog	2014-04-16 21:58:23 UTC (rev 167389)
@@ -1,3 +1,12 @@
+2014-04-16  pe...@outlook.com  pe...@outlook.com
+
+[Win] run-_javascript_core-tests fails to run.
+https://bugs.webkit.org/show_bug.cgi?id=131761
+
+Reviewed by Brent Fulgham.
+
+* Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
+
 2014-04-16  Andres Gomez  ago...@igalia.com
 
 [Win] Pass default parameters to cygwin setup wizard


Modified: trunk/Tools/Scripts/build-jsc (167388 => 167389)

--- trunk/Tools/Scripts/build-jsc	2014-04-16 21:53:51 UTC (rev 167388)
+++ trunk/Tools/Scripts/build-jsc	2014-04-16 21:58:23 UTC (rev 167389)
@@ -127,7 +127,9 @@
 chdirWebKit();
 }
 
-buildMyProject(Source/bmalloc, bmalloc);
+if (!isAppleWinWebKit()  !isWinCairo()) {
+buildMyProject(Source/bmalloc, bmalloc);
+}
 buildMyProject(Source/WTF, WTF);
 buildMyProject(Source/_javascript_Core, _javascript_Core);
 if (isAppleMacWebKit()  $cli) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167390] trunk/Source/WebKit2

[simon . fraser]

Title: [167390] trunk/Source/WebKit2








Revision 167390
Author simon.fra...@apple.com
Date 2014-04-16 15:04:17 -0700 (Wed, 16 Apr 2014)


Log Message
Failing to decode a layer tree commit message resulted in silent and mysterious failure
https://bugs.webkit.org/show_bug.cgi?id=131766
rdar://problem/16520894

Reviewed by Sam Weinig.

If the message decode failed, we should have already marked the message as invalid.
Failing to do so indicates in a decode code coding error.

* Platform/IPC/HandleMessage.h:
(IPC::handleMessage):
(IPC::handleMessageVariadic):
(IPC::handleMessageDelayed):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/IPC/HandleMessage.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167389 => 167390)

--- trunk/Source/WebKit2/ChangeLog	2014-04-16 21:58:23 UTC (rev 167389)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-16 22:04:17 UTC (rev 167390)
@@ -1,3 +1,19 @@
+2014-04-16  Simon Fraser  simon.fra...@apple.com
+
+Failing to decode a layer tree commit message resulted in silent and mysterious failure
+https://bugs.webkit.org/show_bug.cgi?id=131766
+rdar://problem/16520894
+
+Reviewed by Sam Weinig.
+
+If the message decode failed, we should have already marked the message as invalid.
+Failing to do so indicates in a decode code coding error.
+
+* Platform/IPC/HandleMessage.h:
+(IPC::handleMessage):
+(IPC::handleMessageVariadic):
+(IPC::handleMessageDelayed):
+
 2014-04-16  Tim Horton  timothy_hor...@apple.com
 
 Minor include sanity in WebPage.h


Modified: trunk/Source/WebKit2/Platform/IPC/HandleMessage.h (167389 => 167390)

--- trunk/Source/WebKit2/Platform/IPC/HandleMessage.h	2014-04-16 21:58:23 UTC (rev 167389)
+++ trunk/Source/WebKit2/Platform/IPC/HandleMessage.h	2014-04-16 22:04:17 UTC (rev 167390)
@@ -112,8 +112,11 @@
 void handleMessage(MessageDecoder decoder, C* object, MF function)
 {
 typename T::DecodeType arguments;
-if (!decoder.decode(arguments))
+if (!decoder.decode(arguments)) {
+ASSERT(decoder.isInvalid());
 return;
+}
+
 callMemberFunction(std::move(arguments), object, function);
 }
 
@@ -121,8 +124,10 @@
 void handleMessage(MessageDecoder decoder, MessageEncoder replyEncoder, C* object, MF function)
 {
 typename T::DecodeType arguments;
-if (!decoder.decode(arguments))
+if (!decoder.decode(arguments)) {
+ASSERT(decoder.isInvalid());
 return;
+}
 
 typename T::Reply::ValueType replyArguments;
 callMemberFunction(std::move(arguments), replyArguments, object, function);
@@ -133,8 +138,10 @@
 void handleMessage(Connection* connection, MessageDecoder decoder, MessageEncoder replyEncoder, C* object, MF function)
 {
 typename T::DecodeType arguments;
-if (!decoder.decode(arguments))
+if (!decoder.decode(arguments)) {
+ASSERT(decoder.isInvalid());
 return;
+}
 
 typename T::Reply::ValueType replyArguments;
 callMemberFunction(connection, std::move(arguments), replyArguments, object, function);
@@ -145,8 +152,10 @@
 void handleMessage(Connection* connection, MessageDecoder decoder, C* object, MF function)
 {
 typename T::DecodeType arguments;
-if (!decoder.decode(arguments))
+if (!decoder.decode(arguments)) {
+ASSERT(decoder.isInvalid());
 return;
+}
 callMemberFunction(connection, std::move(arguments), object, function);
 }
 
@@ -154,8 +163,10 @@
 void handleMessageVariadic(MessageDecoder decoder, C* object, MF function)
 {
 typename T::DecodeType arguments;
-if (!decoder.decode(arguments))
+if (!decoder.decode(arguments)) {
+ASSERT(decoder.isInvalid());
 return;
+}
 callMemberFunction(std::move(arguments), decoder, object, function);
 }
 
@@ -163,8 +174,10 @@
 void handleMessageVariadic(MessageDecoder decoder, MessageEncoder replyEncoder, C* object, MF function)
 {
 typename T::DecodeType arguments;
-if (!decoder.decode(arguments))
+if (!decoder.decode(arguments)) {
+ASSERT(decoder.isInvalid());
 return;
+}
 
 typename T::Reply::ValueType replyArguments;
 callMemberFunction(std::move(arguments), decoder, replyArguments, object, function);
@@ -175,8 +188,10 @@
 void handleMessageDelayed(Connection* connection, MessageDecoder decoder, std::unique_ptrMessageEncoder replyEncoder, C* object, MF function)
 {
 typename T::DecodeType arguments;
-if (!decoder.decode(arguments))
+if (!decoder.decode(arguments)) {
+ASSERT(decoder.isInvalid());
 return;
+}
 
 RefPtrtypename T::DelayedReply delayedReply = adoptRef(new typename T::DelayedReply(connection, std::move(replyEncoder)));
 callMemberFunction(std::move(arguments), delayedReply.release(), object, function);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [167391] trunk/Source/WebCore

[akling]

Title: [167391] trunk/Source/WebCore








Revision 167391
Author akl...@apple.com
Date 2014-04-16 15:21:43 -0700 (Wed, 16 Apr 2014)


Log Message
Revert direct caching of tagName and nodeName from r167383.

Ryosuke tells me this is not entirely safe, will need to rethink.

* dom/Element.idl:
* dom/Node.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebCore/dom/Node.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (167390 => 167391)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 22:04:17 UTC (rev 167390)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 22:21:43 UTC (rev 167391)
@@ -1,3 +1,12 @@
+2014-04-16  Andreas Kling  akl...@apple.com
+
+Revert direct caching of tagName and nodeName from r167383.
+
+Ryosuke tells me this is not entirely safe, will need to rethink.
+
+* dom/Element.idl:
+* dom/Node.idl:
+
 2014-04-16  Peter Molnar  pmolnar.u-sze...@partner.samsung.com
 
 Improve security mitigation added in webkit r94001.


Modified: trunk/Source/WebCore/dom/Element.idl (167390 => 167391)

--- trunk/Source/WebCore/dom/Element.idl	2014-04-16 22:04:17 UTC (rev 167390)
+++ trunk/Source/WebCore/dom/Element.idl	2014-04-16 22:21:43 UTC (rev 167391)
@@ -25,7 +25,7 @@
 
 // DOM Level 1 Core
 
-[TreatReturnedNullStringAs=Null, ReturnsCacheableValue] readonly attribute DOMString tagName;
+[TreatReturnedNullStringAs=Null] readonly attribute DOMString tagName;
 
 [TreatReturnedNullStringAs=Null] DOMString getAttribute([Default=Undefined] optional DOMString name);
 [ObjCLegacyUnnamedParameters, RaisesException] void setAttribute([Default=Undefined] optional DOMString name,


Modified: trunk/Source/WebCore/dom/Node.idl (167390 => 167391)

--- trunk/Source/WebCore/dom/Node.idl	2014-04-16 22:04:17 UTC (rev 167390)
+++ trunk/Source/WebCore/dom/Node.idl	2014-04-16 22:21:43 UTC (rev 167391)
@@ -46,7 +46,7 @@
 const unsigned short  DOCUMENT_FRAGMENT_NODE = 11;
 const unsigned short  NOTATION_NODE  = 12;
 
-[TreatReturnedNullStringAs=Null, ReturnsCacheableValue] readonly attribute DOMStringnodeName;
+[TreatReturnedNullStringAs=Null] readonly attribute DOMStringnodeName;
 
 // FIXME: the spec says this can also raise on retrieval.
 [TreatReturnedNullStringAs=Null, TreatNullAs=NullString, SetterRaisesException] attribute DOMString nodeValue;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167392] trunk/Source/JavaScriptCore

[fpizlo]

Title: [167392] trunk/Source/_javascript_Core








Revision 167392
Author fpi...@apple.com
Date 2014-04-16 15:39:05 -0700 (Wed, 16 Apr 2014)


Log Message
Enable system library calls in FTL for ARM64
https://bugs.webkit.org/show_bug.cgi?id=130154

Patch by Juergen Ributzka juer...@apple.com on 2014-04-16
Reviewed by Geoffrey Garen and Filip Pizlo.

* ftl/FTLIntrinsicRepository.h:
* ftl/FTLOutput.h:
(JSC::FTL::Output::doubleRem):
(JSC::FTL::Output::doubleSin):
(JSC::FTL::Output::doubleCos):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h
trunk/Source/_javascript_Core/ftl/FTLOutput.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167391 => 167392)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-16 22:21:43 UTC (rev 167391)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-16 22:39:05 UTC (rev 167392)
@@ -1,3 +1,16 @@
+2014-04-16  Juergen Ributzka  juer...@apple.com
+
+Enable system library calls in FTL for ARM64
+https://bugs.webkit.org/show_bug.cgi?id=130154
+
+Reviewed by Geoffrey Garen and Filip Pizlo.
+
+* ftl/FTLIntrinsicRepository.h:
+* ftl/FTLOutput.h:
+(JSC::FTL::Output::doubleRem):
+(JSC::FTL::Output::doubleSin):
+(JSC::FTL::Output::doubleCos):
+
 2014-04-16  pe...@outlook.com  pe...@outlook.com
 
 Fix JSC Debug Regressions on Windows


Modified: trunk/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h (167391 => 167392)

--- trunk/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h	2014-04-16 22:21:43 UTC (rev 167391)
+++ trunk/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h	2014-04-16 22:39:05 UTC (rev 167392)
@@ -59,7 +59,6 @@
 macro(C_JITOperation_EJssJssJss, functionType(intPtr, intPtr, intPtr, intPtr, intPtr)) \
 macro(C_JITOperation_ESt, functionType(intPtr, intPtr, intPtr)) \
 macro(D_JITOperation_D, functionType(doubleType, doubleType)) \
-macro(D_JITOperation_DD, functionType(doubleType, doubleType, doubleType)) \
 macro(I_JITOperation_EJss, functionType(intPtr, intPtr, intPtr)) \
 macro(J_JITOperation_E, functionType(int64, intPtr)) \
 macro(J_JITOperation_EA, functionType(int64, intPtr, intPtr)) \


Modified: trunk/Source/_javascript_Core/ftl/FTLOutput.h (167391 => 167392)

--- trunk/Source/_javascript_Core/ftl/FTLOutput.h	2014-04-16 22:21:43 UTC (rev 167391)
+++ trunk/Source/_javascript_Core/ftl/FTLOutput.h	2014-04-16 22:39:05 UTC (rev 167392)
@@ -126,13 +126,7 @@
 LValue doubleSub(LValue left, LValue right) { return buildFSub(m_builder, left, right); }
 LValue doubleMul(LValue left, LValue right) { return buildFMul(m_builder, left, right); }
 LValue doubleDiv(LValue left, LValue right) { return buildFDiv(m_builder, left, right); }
-LValue doubleRem(LValue left, LValue right)
-{
-// FIXME: LLVM may soften float operations by expanding them to libcalls.
-// We cannot allow that on all platforms yet.
-// rdar://16196412 MachO large code model support.
-return isX86() ? buildFRem(m_builder, left, right) : call(operation(fmod), left, right);
-}
+LValue doubleRem(LValue left, LValue right) { return buildFRem(m_builder, left, right); }
 LValue doubleNeg(LValue value) { return buildFNeg(m_builder, value); }
 
 LValue bitAnd(LValue left, LValue right) { return buildAnd(m_builder, left, right); }
@@ -176,12 +170,11 @@
 
 LValue doubleSin(LValue value)
 {
-return call(isX86() ? doubleSinIntrinsic() : operation(sin), value);
-
+return call(doubleSinIntrinsic(), value);
 }
 LValue doubleCos(LValue value)
 {
-return call(isX86() ? doubleCosIntrinsic() : operation(cos), value);
+return call(doubleCosIntrinsic(), value);
 }
 
 LValue doubleSqrt(LValue value)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167393] trunk/Source/WebKit2

[timothy_horton]

Title: [167393] trunk/Source/WebKit2








Revision 167393
Author timothy_hor...@apple.com
Date 2014-04-16 15:39:47 -0700 (Wed, 16 Apr 2014)


Log Message
Don't build LayerTreeHost on Mac (and clean it up)
https://bugs.webkit.org/show_bug.cgi?id=131769

Reviewed by Simon Fraser.

* WebKit2.xcodeproj/project.pbxproj:
Don't include it in the project.

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::updatePreferences):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setLayerHostingMode): Deleted.
(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Deleted.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/ios/WebPageIOS.mm:
Get rid of LayerTreeHost::supportsAcceleratedCompositing, which always returns true everywhere.
Remove some LayerTreeHost.h includes.
Remove LayerTreeHost::setLayerHostingMode, which is PLATFORM(COCOA) and not needed.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
trunk/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167392 => 167393)

--- trunk/Source/WebKit2/ChangeLog	2014-04-16 22:39:05 UTC (rev 167392)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-16 22:39:47 UTC (rev 167393)
@@ -1,3 +1,29 @@
+2014-04-16  Tim Horton  timothy_hor...@apple.com
+
+Don't build LayerTreeHost on Mac (and clean it up)
+https://bugs.webkit.org/show_bug.cgi?id=131769
+
+Reviewed by Simon Fraser.
+
+* WebKit2.xcodeproj/project.pbxproj:
+Don't include it in the project.
+
+* WebProcess/InjectedBundle/InjectedBundle.cpp:
+(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
+(WebKit::CoordinatedDrawingArea::updatePreferences):
+* WebProcess/WebPage/DrawingAreaImpl.cpp:
+(WebKit::DrawingAreaImpl::updatePreferences):
+* WebProcess/WebPage/LayerTreeHost.h:
+(WebKit::LayerTreeHost::setLayerHostingMode): Deleted.
+(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Deleted.
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::updatePreferences):
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+Get rid of LayerTreeHost::supportsAcceleratedCompositing, which always returns true everywhere.
+Remove some LayerTreeHost.h includes.
+Remove LayerTreeHost::setLayerHostingMode, which is PLATFORM(COCOA) and not needed.
+
 2014-04-16  Simon Fraser  simon.fra...@apple.com
 
 Failing to decode a layer tree commit message resulted in silent and mysterious failure


Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (167392 => 167393)

--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2014-04-16 22:39:05 UTC (rev 167392)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2014-04-16 22:39:47 UTC (rev 167393)
@@ -129,8 +129,6 @@
 		1A15841A189044F50017616C /* WKProcessPool.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A158418189044F50017616C /* WKProcessPool.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		1A17977F137EE82C00F97D45 /* PluginCreationParameters.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A17977D137EE82C00F97D45 /* PluginCreationParameters.cpp */; };
 		1A179780137EE82C00F97D45 /* PluginCreationParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A17977E137EE82C00F97D45 /* PluginCreationParameters.h */; };
-		1A186EEA12EF7618008E5F37 /* LayerTreeHost.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A186EE812EF7618008E5F37 /* LayerTreeHost.h */; };
-		1A186EEB12EF7618008E5F37 /* LayerTreeHost.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A186EE912EF7618008E5F37 /* LayerTreeHost.cpp */; };
 		1A1B0EB518A424950038481A /* WKNavigationResponse.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A1B0EB318A424950038481A /* WKNavigationResponse.mm */; };
 		1A1B0EB618A424950038481A /* WKNavigationResponse.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A1B0EB418A424950038481A /* WKNavigationResponse.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		1A1B0EB818A424CD0038481A /* WKNavigationResponseInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A1B0EB718A424CD0038481A /* WKNavigationResponseInternal.h */; };
@@ -1898,8 +1896,6 @@
 		1A17635516B1D5D000D88FD6 /* StorageNamespaceImpl.h 

[webkit-changes] [167395] trunk/Source/WebCore

[zoltan]

Title: [167395] trunk/Source/WebCore








Revision 167395
Author zol...@webkit.org
Date 2014-04-16 15:54:23 -0700 (Wed, 16 Apr 2014)


Log Message
Vanish unnecessary includes from Shapes.{h|cpp}
https://bugs.webkit.org/show_bug.cgi?id=131762

Reviewed by Andreas Kling.

No new tests, no behavior change.

* rendering/shapes/BoxShape.h:
* rendering/shapes/Shape.cpp:
* rendering/shapes/Shape.h:
* rendering/shapes/ShapeOutsideInfo.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/shapes/BoxShape.h
trunk/Source/WebCore/rendering/shapes/Shape.cpp
trunk/Source/WebCore/rendering/shapes/Shape.h
trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (167394 => 167395)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 22:44:00 UTC (rev 167394)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 22:54:23 UTC (rev 167395)
@@ -1,3 +1,17 @@
+2014-04-16  Zoltan Horvath  zol...@webkit.org
+
+Vanish unnecessary includes from Shapes.{h|cpp}
+https://bugs.webkit.org/show_bug.cgi?id=131762
+
+Reviewed by Andreas Kling.
+
+No new tests, no behavior change.
+
+* rendering/shapes/BoxShape.h:
+* rendering/shapes/Shape.cpp:
+* rendering/shapes/Shape.h:
+* rendering/shapes/ShapeOutsideInfo.h:
+
 2014-04-16  Andreas Kling  akl...@apple.com
 
 Revert direct caching of tagName and nodeName from r167383.


Modified: trunk/Source/WebCore/rendering/shapes/BoxShape.h (167394 => 167395)

--- trunk/Source/WebCore/rendering/shapes/BoxShape.h	2014-04-16 22:44:00 UTC (rev 167394)
+++ trunk/Source/WebCore/rendering/shapes/BoxShape.h	2014-04-16 22:54:23 UTC (rev 167395)
@@ -31,10 +31,13 @@
 #define BoxShape_h
 
 #include FloatRoundedRect.h
+#include RenderStyleConstants.h
 #include Shape.h
 
 namespace WebCore {
 
+class RenderBox;
+
 RoundedRect computeRoundedRectForBoxShape(CSSBoxType, const RenderBox);
 
 class BoxShape : public Shape {


Modified: trunk/Source/WebCore/rendering/shapes/Shape.cpp (167394 => 167395)

--- trunk/Source/WebCore/rendering/shapes/Shape.cpp	2014-04-16 22:44:00 UTC (rev 167394)
+++ trunk/Source/WebCore/rendering/shapes/Shape.cpp	2014-04-16 22:54:23 UTC (rev 167395)
@@ -32,15 +32,12 @@
 
 #include BasicShapeFunctions.h
 #include BoxShape.h
-#include CachedImage.h
-#include FloatSize.h
 #include ImageBuffer.h
 #include LengthFunctions.h
 #include PolygonShape.h
 #include RasterShape.h
 #include RectangleShape.h
 #include WindRule.h
-#include wtf/MathExtras.h
 
 namespace WebCore {
 


Modified: trunk/Source/WebCore/rendering/shapes/Shape.h (167394 => 167395)

--- trunk/Source/WebCore/rendering/shapes/Shape.h	2014-04-16 22:44:00 UTC (rev 167394)
+++ trunk/Source/WebCore/rendering/shapes/Shape.h	2014-04-16 22:54:23 UTC (rev 167395)
@@ -30,14 +30,9 @@
 #ifndef Shape_h
 #define Shape_h
 
-#include BasicShapes.h
 #include LayoutRect.h
 #include Path.h
-#include RoundedRect.h
-#include StyleImage.h
 #include WritingMode.h
-#include memory
-#include wtf/Vector.h
 
 namespace WebCore {
 
@@ -52,6 +47,10 @@
 float logicalRight;
 };
 
+class BasicShape;
+class Image;
+class RoundedRect;
+
 typedef VectorLineSegment SegmentList;
 
 


Modified: trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.h (167394 => 167395)

--- trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.h	2014-04-16 22:44:00 UTC (rev 167394)
+++ trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.h	2014-04-16 22:54:23 UTC (rev 167395)
@@ -34,6 +34,7 @@
 
 #include LayoutSize.h
 #include Shape.h
+#include wtf/HashMap.h
 
 namespace WebCore {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167396] trunk/Source/JavaScriptCore

[mark . lam]

Title: [167396] trunk/Source/_javascript_Core








Revision 167396
Author mark@apple.com
Date 2014-04-16 16:07:49 -0700 (Wed, 16 Apr 2014)


Log Message
Crash in CodeBlock::setOptimizationThresholdBasedOnCompilationResult() when the debugger activates.
https://webkit.org/b/131747

Reviewed by Filip Pizlo.

When the debugger is about to activate (e.g. enter stepping mode), it first
waits for all DFG compilations to complete.  However, when the DFG completes,
if compilation is successful, it will install a new DFG codeBlock.  The
CodeBlock installation process is required to register codeBlocks with the
debugger.  Debugger::registerCodeBlock() will eventually call
CodeBlock::setSteppingMode() which may jettison the DFG codeBlock that we're
trying to install.  Thereafter, chaos ensues.

This jettison'ing only happens because the debugger currently set its
m_steppingMode flag before waiting for compilation to complete.  The fix is
simply to set that flag only after compilation is complete.

* debugger/Debugger.cpp:
(JSC::Debugger::setSteppingMode):
(JSC::Debugger::registerCodeBlock):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/debugger/Debugger.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167395 => 167396)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-16 22:54:23 UTC (rev 167395)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-16 23:07:49 UTC (rev 167396)
@@ -1,3 +1,26 @@
+2014-04-16  Mark Lam  mark@apple.com
+
+Crash in CodeBlock::setOptimizationThresholdBasedOnCompilationResult() when the debugger activates.
+https://webkit.org/b/131747
+
+Reviewed by Filip Pizlo.
+
+When the debugger is about to activate (e.g. enter stepping mode), it first
+waits for all DFG compilations to complete.  However, when the DFG completes,
+if compilation is successful, it will install a new DFG codeBlock.  The
+CodeBlock installation process is required to register codeBlocks with the
+debugger.  Debugger::registerCodeBlock() will eventually call
+CodeBlock::setSteppingMode() which may jettison the DFG codeBlock that we're
+trying to install.  Thereafter, chaos ensues.
+
+This jettison'ing only happens because the debugger currently set its
+m_steppingMode flag before waiting for compilation to complete.  The fix is
+simply to set that flag only after compilation is complete.
+
+* debugger/Debugger.cpp:
+(JSC::Debugger::setSteppingMode):
+(JSC::Debugger::registerCodeBlock):
+
 2014-04-16  Filip Pizlo  fpi...@apple.com
 
 Discern between NaNs that would be safe to tag and NaNs that need some purification before tagging


Modified: trunk/Source/_javascript_Core/debugger/Debugger.cpp (167395 => 167396)

--- trunk/Source/_javascript_Core/debugger/Debugger.cpp	2014-04-16 22:54:23 UTC (rev 167395)
+++ trunk/Source/_javascript_Core/debugger/Debugger.cpp	2014-04-16 23:07:49 UTC (rev 167396)
@@ -232,18 +232,22 @@
 
 void Debugger::setSteppingMode(SteppingMode mode)
 {
-if (mode == m_steppingMode)
+if (mode == m_steppingMode || !m_vm)
 return;
+
+m_vm-waitForCompilationsToComplete();
+
 m_steppingMode = mode;
-
-if (!m_vm)
-return;
 SetSteppingModeFunctor functor(this, mode);
-forEachCodeBlock(functor);
+m_vm-heap.forEachCodeBlock(functor);
 }
 
 void Debugger::registerCodeBlock(CodeBlock* codeBlock)
 {
+// FIXME: We should never have to jettison a code block (due to pending breakpoints
+// or stepping mode) that is being registered. operationOptimize() should have
+// prevented the optimizing of such code blocks in the first place. Find a way to
+// express this with greater clarity in the code. See https://webkit.org/b131771.
 applyBreakpoints(codeBlock);
 if (isStepping())
 codeBlock-setSteppingMode(CodeBlock::SteppingModeEnabled);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167397] trunk/Source/JavaScriptCore

[fpizlo]

Title: [167397] trunk/Source/_javascript_Core








Revision 167397
Author fpi...@apple.com
Date 2014-04-16 16:30:02 -0700 (Wed, 16 Apr 2014)


Log Message
Allocate the data section on the heap again for FTL on ARM64
https://bugs.webkit.org/show_bug.cgi?id=130156

Patch by Juergen Ributzka juer...@apple.com on 2014-04-16
Reviewed by Geoffrey Garen and Filip Pizlo.

* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
* ftl/FTLDataSection.cpp:
(JSC::FTL::DataSection::DataSection):
(JSC::FTL::DataSection::~DataSection):
* ftl/FTLDataSection.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLCompile.cpp
trunk/Source/_javascript_Core/ftl/FTLDataSection.cpp
trunk/Source/_javascript_Core/ftl/FTLDataSection.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167396 => 167397)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-16 23:07:49 UTC (rev 167396)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-16 23:30:02 UTC (rev 167397)
@@ -1,3 +1,17 @@
+2014-04-16  Juergen Ributzka  juer...@apple.com
+
+Allocate the data section on the heap again for FTL on ARM64
+https://bugs.webkit.org/show_bug.cgi?id=130156
+
+Reviewed by Geoffrey Garen and Filip Pizlo.
+
+* ftl/FTLCompile.cpp:
+(JSC::FTL::mmAllocateDataSection):
+* ftl/FTLDataSection.cpp:
+(JSC::FTL::DataSection::DataSection):
+(JSC::FTL::DataSection::~DataSection):
+* ftl/FTLDataSection.h:
+
 2014-04-16  Mark Lam  mark@apple.com
 
 Crash in CodeBlock::setOptimizationThresholdBasedOnCompilationResult() when the debugger activates.


Modified: trunk/Source/_javascript_Core/ftl/FTLCompile.cpp (167396 => 167397)

--- trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2014-04-16 23:07:49 UTC (rev 167396)
+++ trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2014-04-16 23:30:02 UTC (rev 167397)
@@ -79,11 +79,14 @@
 UNUSED_PARAM(sectionID);
 UNUSED_PARAM(isReadOnly);
 
+// Allocate the GOT in the code section to make it reachable for all code.
+if (!strcmp(sectionName, __got))
+return mmAllocateCodeSection(opaqueState, size, alignment, sectionID, sectionName);
+
 State state = *static_castState*(opaqueState);
-
-RefPtrDataSection section = adoptRef(new DataSection(
-state.graph.m_vm, state.graph.m_codeBlock, size, alignment));
-
+
+RefPtrDataSection section = adoptRef(new DataSection(size, alignment));
+
 if (!strcmp(sectionName, __llvm_stackmaps))
 state.stackmapsSection = section;
 else {
@@ -94,7 +97,7 @@
 state.compactUnwindSize = size;
 }
 }
-
+
 return bitwise_castuint8_t*(section-base());
 }
 


Modified: trunk/Source/_javascript_Core/ftl/FTLDataSection.cpp (167396 => 167397)

--- trunk/Source/_javascript_Core/ftl/FTLDataSection.cpp	2014-04-16 23:07:49 UTC (rev 167396)
+++ trunk/Source/_javascript_Core/ftl/FTLDataSection.cpp	2014-04-16 23:30:02 UTC (rev 167397)
@@ -34,30 +34,9 @@
 
 namespace JSC { namespace FTL {
 
-#if CPU(ARM64)
-// FIXME: We should undo this once we fix relocation issues.
-// https://bugs.webkit.org/show_bug.cgi?id=129756
-static const bool useExecutableMemory = true;
-#else
-static const bool useExecutableMemory = false;
-#endif
-
-DataSection::DataSection(VM vm, CodeBlock* codeBlock, size_t size, unsigned alignment)
+DataSection::DataSection(size_t size, unsigned alignment)
 : m_size(size)
 {
-if (useExecutableMemory) {
-RELEASE_ASSERT(alignment  jitAllocationGranule);
-
-RefPtrExecutableMemoryHandle result =
-vm.executableAllocator.allocate(
-vm, size, codeBlock, JITCompilationMustSucceed);
-m_base = result-start();
-m_size = result-sizeInBytes();
-
-m_allocationBase = result.release().leakRef();
-return;
-}
-
 RELEASE_ASSERT(WTF::bitCount(alignment) == 1);
 
 const unsigned nativeAlignment = 8;
@@ -76,10 +55,7 @@
 
 DataSection::~DataSection()
 {
-if (useExecutableMemory)
-static_castExecutableMemoryHandle*(m_allocationBase)-deref();
-else
-fastFree(m_allocationBase);
+fastFree(m_allocationBase);
 }
 
 } } // namespace JSC::FTL


Modified: trunk/Source/_javascript_Core/ftl/FTLDataSection.h (167396 => 167397)

--- trunk/Source/_javascript_Core/ftl/FTLDataSection.h	2014-04-16 23:07:49 UTC (rev 167396)
+++ trunk/Source/_javascript_Core/ftl/FTLDataSection.h	2014-04-16 23:30:02 UTC (rev 167397)
@@ -36,7 +36,7 @@
 
 class DataSection : public RefCountedDataSection {
 public:
-DataSection(VM, CodeBlock*, size_t, unsigned alignment);
+DataSection(size_t, unsigned alignment);
 ~DataSection();
 
 void* base() { return m_base; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167398] trunk/Source/WebKit2

[timothy_horton]

Title: [167398] trunk/Source/WebKit2








Revision 167398
Author timothy_hor...@apple.com
Date 2014-04-16 16:40:53 -0700 (Wed, 16 Apr 2014)


Log Message
Deduplicate LayerTreeContext
https://bugs.webkit.org/show_bug.cgi?id=131773

Reviewed by Simon Fraser.

There are three identical implementations, one for each platform, for no reason.

* CMakeLists.txt:
* PlatformEfl.cmake:
* PlatformGTK.cmake:
* Shared/LayerTreeContext.cpp: Renamed from Source/WebKit2/Shared/mac/LayerTreeContextMac.mm.
(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):
* Shared/LayerTreeContext.h:
(WebKit::operator!=): Deleted.
* Shared/efl/LayerTreeContextEfl.cpp: Removed.
* Shared/gtk/LayerTreeContextGtk.cpp: Removed.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):

Modified Paths

trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/Shared/LayerTreeContext.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp
trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp


Added Paths

trunk/Source/WebKit2/Shared/LayerTreeContext.cpp


Removed Paths

trunk/Source/WebKit2/Shared/efl/LayerTreeContextEfl.cpp
trunk/Source/WebKit2/Shared/gtk/LayerTreeContextGtk.cpp
trunk/Source/WebKit2/Shared/mac/LayerTreeContextMac.mm




Diff

Modified: trunk/Source/WebKit2/CMakeLists.txt (167397 => 167398)

--- trunk/Source/WebKit2/CMakeLists.txt	2014-04-16 23:30:02 UTC (rev 167397)
+++ trunk/Source/WebKit2/CMakeLists.txt	2014-04-16 23:40:53 UTC (rev 167398)
@@ -195,6 +195,7 @@
 Shared/EditorState.cpp
 Shared/FontInfo.cpp
 Shared/ImmutableDictionary.cpp
+Shared/LayerTreeContext.cpp
 Shared/MutableDictionary.cpp
 Shared/NavigationActionData.cpp
 Shared/OriginAndDatabases.cpp


Modified: trunk/Source/WebKit2/ChangeLog (167397 => 167398)

--- trunk/Source/WebKit2/ChangeLog	2014-04-16 23:30:02 UTC (rev 167397)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-16 23:40:53 UTC (rev 167398)
@@ -1,5 +1,34 @@
 2014-04-16  Tim Horton  timothy_hor...@apple.com
 
+Deduplicate LayerTreeContext
+https://bugs.webkit.org/show_bug.cgi?id=131773
+
+Reviewed by Simon Fraser.
+
+There are three identical implementations, one for each platform, for no reason.
+
+* CMakeLists.txt:
+* PlatformEfl.cmake:
+* PlatformGTK.cmake:
+* Shared/LayerTreeContext.cpp: Renamed from Source/WebKit2/Shared/mac/LayerTreeContextMac.mm.
+(WebKit::LayerTreeContext::LayerTreeContext):
+(WebKit::LayerTreeContext::~LayerTreeContext):
+(WebKit::LayerTreeContext::encode):
+(WebKit::LayerTreeContext::decode):
+(WebKit::LayerTreeContext::isEmpty):
+(WebKit::operator==):
+* Shared/LayerTreeContext.h:
+(WebKit::operator!=): Deleted.
+* Shared/efl/LayerTreeContextEfl.cpp: Removed.
+* Shared/gtk/LayerTreeContextGtk.cpp: Removed.
+* WebKit2.xcodeproj/project.pbxproj:
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
+* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
+(WebKit::LayerTreeHostGtk::initialize):
+
+2014-04-16  Tim Horton  timothy_hor...@apple.com
+
 Don't build LayerTreeHost on Mac (and clean it up)
 https://bugs.webkit.org/show_bug.cgi?id=131769
 


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (167397 => 167398)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2014-04-16 23:30:02 UTC (rev 167397)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2014-04-16 23:40:53 UTC (rev 167398)
@@ -34,7 +34,6 @@
 
 Shared/cairo/ShareableBitmapCairo.cpp
 
-Shared/efl/LayerTreeContextEfl.cpp
 Shared/efl/NativeWebKeyboardEventEfl.cpp
 Shared/efl/NativeWebTouchEventEfl.cpp
 Shared/efl/NativeWebWheelEventEfl.cpp


Modified: trunk/Source/WebKit2/PlatformGTK.cmake (167397 => 167398)

--- trunk/Source/WebKit2/PlatformGTK.cmake	2014-04-16 23:30:02 UTC (rev 167397)
+++ trunk/Source/WebKit2/PlatformGTK.cmake	2014-04-16 23:40:53 UTC (rev 167398)
@@ -54,7 +54,6 @@
 Shared/cairo/ShareableBitmapCairo.cpp
 
 Shared/gtk/ArgumentCodersGtk.cpp
-Shared/gtk/LayerTreeContextGtk.cpp
 Shared/gtk/NativeWebKeyboardEventGtk.cpp
 Shared/gtk/NativeWebMouseEventGtk.cpp
 Shared/gtk/NativeWebTouchEventGtk.cpp


Added: trunk/Source/WebKit2/Shared/LayerTreeContext.cpp (0 => 167398)

--- 

[webkit-changes] [167399] trunk/Source/WebKit2

[zandobersek]

Title: [167399] trunk/Source/WebKit2








Revision 167399
Author zandober...@gmail.com
Date 2014-04-16 16:46:59 -0700 (Wed, 16 Apr 2014)


Log Message
Make IPC::Arguments a variadic template
https://bugs.webkit.org/show_bug.cgi?id=131684

Reviewed by Darin Adler.

Make IPC::Arguments a variadic template that uses the template parameter pack to further
define the std::tuple ValueType and is used to define the std::tuple container of the
values passed into the container.

* Platform/IPC/Arguments.h:
(IPC::Arguments::Arguments):
(IPC::Arguments::encode):
(IPC::Arguments::decode):
(IPC::Arguments0::encode): Deleted.
(IPC::Arguments0::decode): Deleted.
(IPC::Arguments1::Arguments1): Deleted.
(IPC::Arguments1::encode): Deleted.
(IPC::Arguments1::decode): Deleted.
(IPC::Arguments2::Arguments2): Deleted.
(IPC::Arguments2::encode): Deleted.
(IPC::Arguments2::decode): Deleted.
(IPC::Arguments3::Arguments3): Deleted.
(IPC::Arguments3::encode): Deleted.
(IPC::Arguments3::decode): Deleted.
(IPC::Arguments4::Arguments4): Deleted.
(IPC::Arguments4::encode): Deleted.
(IPC::Arguments4::decode): Deleted.
(IPC::Arguments5::Arguments5): Deleted.
(IPC::Arguments5::encode): Deleted.
(IPC::Arguments5::decode): Deleted.
(IPC::Arguments6::Arguments6): Deleted.
(IPC::Arguments6::encode): Deleted.
(IPC::Arguments6::decode): Deleted.
(IPC::Arguments7::Arguments7): Deleted.
(IPC::Arguments7::encode): Deleted.
(IPC::Arguments7::decode): Deleted.
(IPC::Arguments8::Arguments8): Deleted.
(IPC::Arguments8::encode): Deleted.
(IPC::Arguments8::decode): Deleted.
(IPC::Arguments10::Arguments10): Deleted.
(IPC::Arguments10::encode): Deleted.
(IPC::Arguments10::decode): Deleted.
* Scripts/webkit2/LegacyMessages-expected.h:
* Scripts/webkit2/Messages-expected.h:
* Scripts/webkit2/messages.py: Clean up the code a bit.
(reply_parameter_type):
(arguments_type):
(reply_type):
(decode_type):
(arguments_type_old): Deleted.
(base_class): Deleted.
(delayed_reply_type): Deleted.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/IPC/Arguments.h
trunk/Source/WebKit2/Scripts/webkit2/LegacyMessages-expected.h
trunk/Source/WebKit2/Scripts/webkit2/Messages-expected.h
trunk/Source/WebKit2/Scripts/webkit2/messages.py




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167398 => 167399)

--- trunk/Source/WebKit2/ChangeLog	2014-04-16 23:40:53 UTC (rev 167398)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-16 23:46:59 UTC (rev 167399)
@@ -1,3 +1,58 @@
+2014-04-16  Zan Dobersek  zdober...@igalia.com
+
+Make IPC::Arguments a variadic template
+https://bugs.webkit.org/show_bug.cgi?id=131684
+
+Reviewed by Darin Adler.
+
+Make IPC::Arguments a variadic template that uses the template parameter pack to further
+define the std::tuple ValueType and is used to define the std::tuple container of the
+values passed into the container.
+
+* Platform/IPC/Arguments.h:
+(IPC::Arguments::Arguments):
+(IPC::Arguments::encode):
+(IPC::Arguments::decode):
+(IPC::Arguments0::encode): Deleted.
+(IPC::Arguments0::decode): Deleted.
+(IPC::Arguments1::Arguments1): Deleted.
+(IPC::Arguments1::encode): Deleted.
+(IPC::Arguments1::decode): Deleted.
+(IPC::Arguments2::Arguments2): Deleted.
+(IPC::Arguments2::encode): Deleted.
+(IPC::Arguments2::decode): Deleted.
+(IPC::Arguments3::Arguments3): Deleted.
+(IPC::Arguments3::encode): Deleted.
+(IPC::Arguments3::decode): Deleted.
+(IPC::Arguments4::Arguments4): Deleted.
+(IPC::Arguments4::encode): Deleted.
+(IPC::Arguments4::decode): Deleted.
+(IPC::Arguments5::Arguments5): Deleted.
+(IPC::Arguments5::encode): Deleted.
+(IPC::Arguments5::decode): Deleted.
+(IPC::Arguments6::Arguments6): Deleted.
+(IPC::Arguments6::encode): Deleted.
+(IPC::Arguments6::decode): Deleted.
+(IPC::Arguments7::Arguments7): Deleted.
+(IPC::Arguments7::encode): Deleted.
+(IPC::Arguments7::decode): Deleted.
+(IPC::Arguments8::Arguments8): Deleted.
+(IPC::Arguments8::encode): Deleted.
+(IPC::Arguments8::decode): Deleted.
+(IPC::Arguments10::Arguments10): Deleted.
+(IPC::Arguments10::encode): Deleted.
+(IPC::Arguments10::decode): Deleted.
+* Scripts/webkit2/LegacyMessages-expected.h:
+* Scripts/webkit2/Messages-expected.h:
+* Scripts/webkit2/messages.py: Clean up the code a bit.
+(reply_parameter_type):
+(arguments_type):
+(reply_type):
+(decode_type):
+(arguments_type_old): Deleted.
+(base_class): Deleted.
+(delayed_reply_type): Deleted.
+
 2014-04-16  Tim Horton  timothy_hor...@apple.com
 
 Deduplicate LayerTreeContext


Modified: trunk/Source/WebKit2/Platform/IPC/Arguments.h (167398 => 167399)

--- trunk/Source/WebKit2/Platform/IPC/Arguments.h	

[webkit-changes] [167400] trunk/Source/WTF

[simon . fraser]

Title: [167400] trunk/Source/WTF








Revision 167400
Author simon.fra...@apple.com
Date 2014-04-16 16:50:25 -0700 (Wed, 16 Apr 2014)


Log Message
Don't include CryptographicallyRandomNumber.h in StringImpl.h
https://bugs.webkit.org/show_bug.cgi?id=131772

Reviewed by Sam Weinig.

* wtf/text/StringImpl.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.h




Diff

Modified: trunk/Source/WTF/ChangeLog (167399 => 167400)

--- trunk/Source/WTF/ChangeLog	2014-04-16 23:46:59 UTC (rev 167399)
+++ trunk/Source/WTF/ChangeLog	2014-04-16 23:50:25 UTC (rev 167400)
@@ -1,3 +1,12 @@
+2014-04-16  Simon Fraser  simon.fra...@apple.com
+
+Don't include CryptographicallyRandomNumber.h in StringImpl.h
+https://bugs.webkit.org/show_bug.cgi?id=131772
+
+Reviewed by Sam Weinig.
+
+* wtf/text/StringImpl.h:
+
 2014-04-16  Gavin Barraclough  barraclo...@apple.com
 
 Update to pthread QoS SPI


Modified: trunk/Source/WTF/wtf/text/StringImpl.h (167399 => 167400)

--- trunk/Source/WTF/wtf/text/StringImpl.h	2014-04-16 23:46:59 UTC (rev 167399)
+++ trunk/Source/WTF/wtf/text/StringImpl.h	2014-04-16 23:50:25 UTC (rev 167400)
@@ -28,7 +28,6 @@
 #include unicode/ustring.h
 #include wtf/ASCIICType.h
 #include wtf/CompilationThread.h
-#include wtf/CryptographicallyRandomNumber.h
 #include wtf/Forward.h
 #include wtf/MathExtras.h
 #include wtf/StdLibExtras.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167401] trunk

[roger_fong]

Title: [167401] trunk








Revision 167401
Author roger_f...@apple.com
Date 2014-04-16 16:53:59 -0700 (Wed, 16 Apr 2014)


Log Message
Add a way for layout tests to determine whether or not a plugin is snapshotted.
https://bugs.webkit.org/show_bug.cgi?id=131650.
rdar://problem/16615528

Reviewed by Dean Jackson.

* testing/Internals.cpp:
(WebCore::Internals::isPluginSnapshotted):
* testing/Internals.h:
* testing/Internals.idl:

Adjust simple.html accordingly, more snapshotting test changes to come.
* platform/mac-wk2/plugins/snapshotting/simple-expected.txt:
* plugins/snapshotting/simple.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/plugins/snapshotting/simple-expected.txt
trunk/LayoutTests/plugins/snapshotting/simple.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (167400 => 167401)

--- trunk/LayoutTests/ChangeLog	2014-04-16 23:50:25 UTC (rev 167400)
+++ trunk/LayoutTests/ChangeLog	2014-04-16 23:53:59 UTC (rev 167401)
@@ -1,3 +1,15 @@
+2014-04-16  Roger Fong  roger_f...@apple.com
+
+Add a way for layout tests to determine whether or not a plugin is snapshotted.
+https://bugs.webkit.org/show_bug.cgi?id=131650.
+rdar://problem/16615528
+
+Reviewed by Dean Jackson.
+
+Adjust simple.html accordingly, more snapshotting test changes to come.
+* platform/mac-wk2/plugins/snapshotting/simple-expected.txt:
+* plugins/snapshotting/simple.html: 
+
 2014-04-16  Oliver Hunt  oli...@apple.com
 
 Simple ES6 feature:Array.prototype.fill


Modified: trunk/LayoutTests/platform/mac-wk2/plugins/snapshotting/simple-expected.txt (167400 => 167401)

--- trunk/LayoutTests/platform/mac-wk2/plugins/snapshotting/simple-expected.txt	2014-04-16 23:50:25 UTC (rev 167400)
+++ trunk/LayoutTests/platform/mac-wk2/plugins/snapshotting/simple-expected.txt	2014-04-16 23:53:59 UTC (rev 167401)
@@ -1,23 +1,5 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
-  RenderBlock {P} at (0,0) size 784x18
-RenderText {#text} at (0,0) size 306x18
-  text run at (0,0) width 306: This test forces a plugin to snapshot immediately
-  RenderBlock (anonymous) at (0,34) size 784x150
-RenderSnapshottedPlugIn {EMBED} at (0,0) size 300x150
-RenderText {#text} at (0,0) size 0x0
-layer at (8,42) size 300x150
-  RenderBlock (relative positioned) {DIV} at (0,0) size 300x150
-layer at (8,42) size 300x150
-  RenderBlock (positioned) {DIV} at (0,0) size 300x150
-layer at (24,58) size 203x44
-  RenderBlock (positioned) {DIV} at (16,16) size 203x44 [bgcolor=#FF]
-RenderBlock {DIV} at (32,4) size 139x18
-  RenderText {#text} at (0,0) size 139x18
-text run at (0,0) width 139: Snapshotted Plug-In
-RenderBlock {DIV} at (32,22) size 139x18 [color=#44]
-  RenderText {#text} at (22,0) size 95x18
-text run at (22,0) width 95: Click to restart
+This test forces a plugin to snapshot immediately
+
+FAIL
+
+


Modified: trunk/LayoutTests/plugins/snapshotting/simple.html (167400 => 167401)

--- trunk/LayoutTests/plugins/snapshotting/simple.html	2014-04-16 23:50:25 UTC (rev 167400)
+++ trunk/LayoutTests/plugins/snapshotting/simple.html	2014-04-16 23:53:59 UTC (rev 167401)
@@ -1,12 +1,18 @@
 pThis test forces a plugin to snapshot immediately/p
+p id=passStatusPASS/p
 script
 if (window.testRunner) {
 window.internals.settings.setPlugInSnapshottingEnabled(true);
 window.internals.settings.setMaximumPlugInSnapshotAttempts(0);
 testRunner.waitUntilDone();
+testRunner.dumpAsText();
 setTimeout(function () {
+var plugin = document.getElementById(plugin);
+var passStatus = document.getElementById(passStatus);
+if (!window.internals.isPluginSnapshotted(plugin))
+passStatus.innerHTML = FAIL;
 testRunner.notifyDone();
 }, 500);
 }
 /script
-embed src=""
+embed id=plugin src=""


Modified: trunk/Source/WebCore/ChangeLog (167400 => 167401)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 23:50:25 UTC (rev 167400)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 23:53:59 UTC (rev 167401)
@@ -1,3 +1,16 @@
+2014-04-16  Roger Fong  roger_f...@apple.com
+
+Add a way for layout tests to determine whether or not a plugin is snapshotted.
+https://bugs.webkit.org/show_bug.cgi?id=131650.
+rdar://problem/16615528
+
+Reviewed by Dean Jackson.
+
+* testing/Internals.cpp:
+(WebCore::Internals::isPluginSnapshotted):
+* testing/Internals.h:
+* testing/Internals.idl:
+
 2014-04-16  Zoltan Horvath  zol...@webkit.org
 
 Vanish unnecessary includes from Shapes.{h|cpp}
@@ -15461,7 +15474,6 @@
 * 

[webkit-changes] [167402] trunk

[dino]

Title: [167402] trunk








Revision 167402
Author d...@apple.com
Date 2014-04-16 16:55:36 -0700 (Wed, 16 Apr 2014)


Log Message
MediaDocument on iOS should be full page
https://bugs.webkit.org/show_bug.cgi?id=131774

Reviewed by Jer Noble.

Source/WebCore:
A MediaDocument on iOS has two problems. It can't rely
on intrinsic size, since it doesn't load the content until
a user gesture. Secondly, on a small screen you want the
media to fill the page.

Add width/height 100% for iOS documents.

Test: platform/iphone-simulator/media/media-document-controls-size.html

* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:
* platform/iphone-simulator/media/media-document-controls-size-expected.txt: Added.
* platform/iphone-simulator/media/media-document-controls-size.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/MediaDocument.cpp


Added Paths

trunk/LayoutTests/platform/iphone-simulator/
trunk/LayoutTests/platform/iphone-simulator/media/
trunk/LayoutTests/platform/iphone-simulator/media/media-document-controls-size-expected.txt
trunk/LayoutTests/platform/iphone-simulator/media/media-document-controls-size.html




Diff

Modified: trunk/LayoutTests/ChangeLog (167401 => 167402)

--- trunk/LayoutTests/ChangeLog	2014-04-16 23:53:59 UTC (rev 167401)
+++ trunk/LayoutTests/ChangeLog	2014-04-16 23:55:36 UTC (rev 167402)
@@ -1,3 +1,13 @@
+2014-04-16  Dean Jackson  d...@apple.com
+
+MediaDocument on iOS should be full page
+https://bugs.webkit.org/show_bug.cgi?id=131774
+
+Reviewed by Jer Noble.
+
+* platform/iphone-simulator/media/media-document-controls-size-expected.txt: Added.
+* platform/iphone-simulator/media/media-document-controls-size.html: Added.
+
 2014-04-16  Roger Fong  roger_f...@apple.com
 
 Add a way for layout tests to determine whether or not a plugin is snapshotted.


Added: trunk/LayoutTests/platform/iphone-simulator/media/media-document-controls-size-expected.txt (0 => 167402)

--- trunk/LayoutTests/platform/iphone-simulator/media/media-document-controls-size-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/iphone-simulator/media/media-document-controls-size-expected.txt	2014-04-16 23:55:36 UTC (rev 167402)
@@ -0,0 +1,8 @@
+CONSOLE MESSAGE: line 145: Localized string Start Playback not found.
+CONSOLE MESSAGE: line 145: Localized string Choose Wireless Display not found.
+Test that media documents have accurately sized media.
+
+
+EXPECTED (width == '200px') OK
+EXPECTED (height == '180px') OK
+
Property changes on: trunk/LayoutTests/platform/iphone-simulator/media/media-document-controls-size-expected.txt
___


Added: svn:mime-type

Added: svn:keywords

Added: svn:eol-style

Added: trunk/LayoutTests/platform/iphone-simulator/media/media-document-controls-size.html (0 => 167402)

--- trunk/LayoutTests/platform/iphone-simulator/media/media-document-controls-size.html	(rev 0)
+++ trunk/LayoutTests/platform/iphone-simulator/media/media-document-controls-size.html	2014-04-16 23:55:36 UTC (rev 167402)
@@ -0,0 +1,22 @@
+pTest that media documents have accurately sized media.p
+script src="" type=text/_javascript_/script
+script src="" type=text/_javascript_/script
+
+iframe style=width: 200px; height: 180px; border: 0px; id=container /iframe
+
+script type=text/_javascript_
+var iframe = document.getElementById(container);
+var width, height;
+
+function runTest(event) {
+var video = iframe.contentDocument.querySelector(video);
+width = window.getComputedStyle(video).width;
+height = window.getComputedStyle(video).height;
+testExpected(width, 200px);
+testExpected(height, 180px);
+testRunner.notifyDone();
+};
+
+iframe._onload_ = runTest;
+iframe.src = "" + findMediaFile(video, content/test);
+/script
Property changes on: trunk/LayoutTests/platform/iphone-simulator/media/media-document-controls-size.html
___


Added: svn:mime-type

Added: svn:keywords

Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (167401 => 167402)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 23:53:59 UTC (rev 167401)
+++ trunk/Source/WebCore/ChangeLog	2014-04-16 23:55:36 UTC (rev 167402)
@@ -1,3 +1,22 @@
+2014-04-16  Dean Jackson  d...@apple.com
+
+MediaDocument on iOS should be full page
+https://bugs.webkit.org/show_bug.cgi?id=131774
+
+Reviewed by Jer Noble.
+
+A MediaDocument on iOS has two problems. It can't rely
+on intrinsic size, since it doesn't load the content until
+a user gesture. Secondly, on a small screen you want the
+media to fill the page.
+
+Add width/height 100% for iOS documents.
+
+Test: platform/iphone-simulator/media/media-document-controls-size.html
+
+* 

[webkit-changes] [167403] trunk/Source/WebKit/mac

[timothy_horton]

Title: [167403] trunk/Source/WebKit/mac








Revision 167403
Author timothy_hor...@apple.com
Date 2014-04-16 16:59:13 -0700 (Wed, 16 Apr 2014)


Log Message
Images dragged from WebKit1 on 2x displays are too big
https://bugs.webkit.org/show_bug.cgi?id=131775
rdar://problem/15933525

Reviewed by Simon Fraser.

* WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
Scale the drag image's logical size down by the device scale factor
in WebKit1 just like we do in WebKit2.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebDragClient.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (167402 => 167403)

--- trunk/Source/WebKit/mac/ChangeLog	2014-04-16 23:55:36 UTC (rev 167402)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-04-16 23:59:13 UTC (rev 167403)
@@ -1,3 +1,16 @@
+2014-04-16  Tim Horton  timothy_hor...@apple.com
+
+Images dragged from WebKit1 on 2x displays are too big
+https://bugs.webkit.org/show_bug.cgi?id=131775
+rdar://problem/15933525
+
+Reviewed by Simon Fraser.
+
+* WebCoreSupport/WebDragClient.mm:
+(WebDragClient::startDrag):
+Scale the drag image's logical size down by the device scale factor
+in WebKit1 just like we do in WebKit2.
+
 2014-04-13  Andy Estes  aes...@apple.com
 
 [QuickLook] Move file system-related code into WebKit


Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebDragClient.mm (167402 => 167403)

--- trunk/Source/WebKit/mac/WebCoreSupport/WebDragClient.mm	2014-04-16 23:55:36 UTC (rev 167402)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebDragClient.mm	2014-04-16 23:59:13 UTC (rev 167403)
@@ -105,6 +105,10 @@
 NSImage *dragNSImage = dragImage.get();
 WebHTMLView *sourceHTMLView = htmlView.get();
 
+IntSize size([dragNSImage size]);
+size.scale(1 / frame.page()-deviceScaleFactor());
+[dragNSImage setSize:size];
+
 id delegate = [m_webView UIDelegate];
 SEL selector = @selector(webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:);
 if ([delegate respondsToSelector:selector]) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167404] trunk/Source/WebCore

[hyatt]

Title: [167404] trunk/Source/WebCore








Revision 167404
Author hy...@apple.com
Date 2014-04-16 17:27:34 -0700 (Wed, 16 Apr 2014)


Log Message
[New Multicolumn] Selection gets confused when the mouse is in the column gaps.
https://bugs.webkit.org/show_bug.cgi?id=131739

Reviewed by Enrica Casucci.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGaps):
Make sure not to paint selection gaps. This matches the old multi-column behavior. Even though
selection gaps *nearly* work with the new multi-column code, I am disabling them so that we
can turn them on without visual regressions.

(WebCore::isChildHitTestCandidate):
Don't allow in-flow RenderFlowThreads to be descended into from positionForPoint. We always want
to look only at the spanners and at the sets.

* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::nodeAtPoint):
* rendering/RenderMultiColumnFlowThread.h:
Override nodeAtPoint to disallow the RenderMultiColumnFlowThread from being considered for hit
testing when no DOM node is found. It's better to just let RenderBlock's positionForPoint run
to drill back down into the appropriate column set.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::positionForPoint):
Implement positionForPoint for RenderMultiColumnSets. This is a straight-up port of the
old multi-column code's adjustPointToColumnContents function.

* rendering/RenderMultiColumnSet.h:
Add override of positionForPoint.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp
trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.h
trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp
trunk/Source/WebCore/rendering/RenderMultiColumnSet.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (167403 => 167404)

--- trunk/Source/WebCore/ChangeLog	2014-04-16 23:59:13 UTC (rev 167403)
+++ trunk/Source/WebCore/ChangeLog	2014-04-17 00:27:34 UTC (rev 167404)
@@ -1,3 +1,35 @@
+2014-04-16  David Hyatt  hy...@apple.com
+
+[New Multicolumn] Selection gets confused when the mouse is in the column gaps.
+https://bugs.webkit.org/show_bug.cgi?id=131739
+
+Reviewed by Enrica Casucci.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::selectionGaps):
+Make sure not to paint selection gaps. This matches the old multi-column behavior. Even though
+selection gaps *nearly* work with the new multi-column code, I am disabling them so that we
+can turn them on without visual regressions.
+
+(WebCore::isChildHitTestCandidate):
+Don't allow in-flow RenderFlowThreads to be descended into from positionForPoint. We always want
+to look only at the spanners and at the sets.
+
+* rendering/RenderMultiColumnFlowThread.cpp:
+(WebCore::RenderMultiColumnFlowThread::nodeAtPoint):
+* rendering/RenderMultiColumnFlowThread.h:
+Override nodeAtPoint to disallow the RenderMultiColumnFlowThread from being considered for hit
+testing when no DOM node is found. It's better to just let RenderBlock's positionForPoint run
+to drill back down into the appropriate column set.
+
+* rendering/RenderMultiColumnSet.cpp:
+(WebCore::RenderMultiColumnSet::positionForPoint):
+Implement positionForPoint for RenderMultiColumnSets. This is a straight-up port of the
+old multi-column code's adjustPointToColumnContents function.
+
+* rendering/RenderMultiColumnSet.h:
+Add override of positionForPoint.
+
 2014-04-16  Dean Jackson  d...@apple.com
 
 MediaDocument on iOS should be full page


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (167403 => 167404)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2014-04-16 23:59:13 UTC (rev 167403)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2014-04-17 00:27:34 UTC (rev 167404)
@@ -2406,7 +2406,7 @@
 if (!isRenderBlockFlow()) // FIXME: Make multi-column selection gap filling work someday.
 return result;
 
-if (hasColumns() || hasTransform() || style().columnSpan()) {
+if (hasColumns() || hasTransform() || style().columnSpan() || isInFlowRenderFlowThread()) {
 // FIXME: We should learn how to gap fill multiple columns and transforms eventually.
 lastLogicalTop = blockDirectionOffset(rootBlock, offsetFromRootBlock) + logicalHeight();
 lastLogicalLeft = logicalLeftSelectionOffset(rootBlock, logicalHeight(), cache);
@@ -3178,7 +3178,7 @@
 
 static inline bool isChildHitTestCandidate(const RenderBox box)
 {
-return box.height()  box.style().visibility() == VISIBLE  !box.isFloatingOrOutOfFlowPositioned();
+return box.height()  box.style().visibility() == VISIBLE  !box.isFloatingOrOutOfFlowPositioned()  !box.isInFlowRenderFlowThread();
 }
 
 // Valid candidates in a FlowThread must be rendered by the region.

[webkit-changes] [167405] trunk/Source/JavaScriptCore

[bfulgham]

Title: [167405] trunk/Source/_javascript_Core








Revision 167405
Author bfulg...@apple.com
Date 2014-04-16 17:40:36 -0700 (Wed, 16 Apr 2014)


Log Message
[Win] Unreviewed Windows gardening. Restrict our new 'isinf' check
to 32-bit builds, and revise the comment to explain what we are
doing.

* runtime/JSCJSValueInlines.h:
(JSC::JSValue::isMachineInt): Provide motivation for the new
'isinf' check for our 32-bit code path.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167404 => 167405)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-17 00:27:34 UTC (rev 167404)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-17 00:40:36 UTC (rev 167405)
@@ -1,3 +1,13 @@
+2014-04-16  Brent Fulgham  bfulg...@apple.com
+
+[Win] Unreviewed Windows gardening. Restrict our new 'isinf' check
+to 32-bit builds, and revise the comment to explain what we are
+doing.
+
+* runtime/JSCJSValueInlines.h:
+(JSC::JSValue::isMachineInt): Provide motivation for the new
+'isinf' check for our 32-bit code path.
+
 2014-04-16  Juergen Ributzka  juer...@apple.com
 
 Allocate the data section on the heap again for FTL on ARM64


Modified: trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h (167404 => 167405)

--- trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h	2014-04-17 00:27:34 UTC (rev 167404)
+++ trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h	2014-04-17 00:40:36 UTC (rev 167405)
@@ -506,8 +506,12 @@
 double number = asDouble();
 if (number != number)
 return false;
-#if OS(WINDOWS)
-// Need to check for infinity on Windows to avoid floating point error on following cast, see bug 131182.
+#if OS(WINDOWS)  CPU(X86)
+// The VS Compiler for 32-bit builds generates a floating point error when attempting to cast
+// from an infinity to a 64-bit integer. We leave this routine with the floating point error
+// left in a register, causing undefined behavior in later floating point operations.
+//
+// To avoid this issue, we check for infinity here, and return false in that case.
 if (std::isinf(number))
 return false;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167406] trunk

[burg]

Title: [167406] trunk








Revision 167406
Author b...@cs.washington.edu
Date 2014-04-16 17:56:35 -0700 (Wed, 16 Apr 2014)


Log Message
Web Replay: memoize fallback time values for document.lastModified
https://bugs.webkit.org/show_bug.cgi?id=131318

Reviewed by Joseph Pecoraro.

Source/WebCore:
If a document's Last-Modified header can't be found or used, then
document.lastModified is derived from the current system time or
from filesystem data, which is obviously nondeterministic.

It's better to handle this inside Document::lastModified rather than using
MemoizedDOMResult, because only the fallback case is nondeterministic.

Test: http/tests/inspector/replay/document-last-modified-fallback-value.html

The test is skipped for now, as it will be very flaky without the
functionality introduced by bugs 130728 and 129391.

* dom/Document.cpp:
(WebCore::Document::lastModified): Save or reuse memoized fallback value.
* replay/WebInputs.json: Add input DocumentLastModifiedDate.

LayoutTests:
Mark the new test as skipped until dependent functionality is landed.

* http/tests/inspector/replay/document-last-modified-fallback-value.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/replay/WebInputs.json


Added Paths

trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value-expected.txt
trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html




Diff

Modified: trunk/LayoutTests/ChangeLog (167405 => 167406)

--- trunk/LayoutTests/ChangeLog	2014-04-17 00:40:36 UTC (rev 167405)
+++ trunk/LayoutTests/ChangeLog	2014-04-17 00:56:35 UTC (rev 167406)
@@ -1,3 +1,14 @@
+2014-04-16  Brian J. Burg  b...@cs.washington.edu
+
+Web Replay: memoize fallback time values for document.lastModified
+https://bugs.webkit.org/show_bug.cgi?id=131318
+
+Reviewed by Joseph Pecoraro.
+
+Mark the new test as skipped until dependent functionality is landed.
+
+* http/tests/inspector/replay/document-last-modified-fallback-value.html: Added.
+
 2014-04-16  Dean Jackson  d...@apple.com
 
 MediaDocument on iOS should be full page


Modified: trunk/LayoutTests/TestExpectations (167405 => 167406)

--- trunk/LayoutTests/TestExpectations	2014-04-17 00:40:36 UTC (rev 167405)
+++ trunk/LayoutTests/TestExpectations	2014-04-17 00:56:35 UTC (rev 167406)
@@ -99,3 +99,6 @@
 # Fails or asserts on most runs.
 webkit.org/b/131679 inspector/dom/content-flow-list.html [ Skip ]
 webkit.org/b/131679 inspector/dom/content-flow-content-removal.html [ Skip ]
+
+# Doesn't work yet, relies on network replay functionality (webkit.org/b/130728, webkit.org/b/129391)
+webkit.org/b/131318 http/tests/inspector/replay/document-last-modified-fallback-value.html [ Skip ]


Added: trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value-expected.txt (0 => 167406)

--- trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value-expected.txt	2014-04-17 00:56:35 UTC (rev 167406)
@@ -0,0 +1,13 @@
+Tests that we can capture and replay nondeterminism in fallback values for document.lastModified
+
+Waiting for test page to finish its initial load...
+Test page initial load done.
+Waiting for capturing to start...
+Capturing has started.
+Waiting to capture initial navigation...
+Initial navigation captured. Dumping state
+Capture stopped, now starting replay to completion...
+Playback has started.
+Waiting to replay initial navigation...
+Initial navigation replayed. Dumping state...
+PASS: Nondeterministic state should not differ during capture and replay.


Added: trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html (0 => 167406)

--- trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html	2014-04-17 00:56:35 UTC (rev 167406)
@@ -0,0 +1,33 @@
+html
+head
+script type=text/_javascript_ src=""
+script type=text/_javascript_ src=""
+script
+
+function appendFrameWithLastModifiedDate(text) {
+document.write('iframe src="" + escape(text) + '/iframe');
+}
+
+appendFrameWithLastModifiedDate('');
+
+function dumpNondeterministicState()
+{
+return Date.parse(frames[0].document.body.textContent);
+}
+
+function test()
+{
+function statesAreEqual(a, b)
+{
+return a === b;
+}
+
+InspectorTest.Replay.runSingleSegmentRefTest(statesAreEqual);
+}
+
+/script
+/head
+body _onload_=runTest()
+pTests that we can capture and replay nondeterminism in fallback values for document.lastModified/p
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (167405 => 

[webkit-changes] [167407] trunk

[achicu]

Title: [167407] trunk








Revision 167407
Author ach...@adobe.com
Date 2014-04-16 18:00:26 -0700 (Wed, 16 Apr 2014)


Log Message
Improve performance of the RenderLayerCompositor::OverlapMap
https://bugs.webkit.org/show_bug.cgi?id=115063

Reviewed by Simon Fraser.

PerformanceTests:
Testing the performance of computing the overlap of 5000 layers.

* Layout/layers_overlap_2d.html: Added. Using non-composited layers, to check
that the performance on the non-composited path is not changing with this patch.
* Layout/layers_overlap_3d.html: Added. Records the time to do the layout of 5000
non-overlapping 3D layers.

Source/WebCore:
No new tests, no new functionality or behavior.

Do not use the OverlapMap in RenderLayerCompositor::computeCompositingRequirements if the layer already
has a 3D transform. This way we can avoid a potential expensive lookups when we know for sure the layer
is already supposed to be composited.

Also, added a bounding box of the overlap map, so that it can catch cases when the new layer is not overlapping
any of the previous layers. This is pretty common when having composited layers laid out in a vertical/horizontal list.

* rendering/RenderLayerCompositor.cpp:
(OverlapMapContainer):
(WebCore::OverlapMapContainer::add):
(WebCore::OverlapMapContainer::overlapsLayers):
(WebCore::OverlapMapContainer::unite):
(WebCore):
(WebCore::RenderLayerCompositor::OverlapMap::add):
(WebCore::RenderLayerCompositor::OverlapMap::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::pushCompositingContainer):
(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):
(RenderLayerCompositor::OverlapMap):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp


Added Paths

trunk/PerformanceTests/Layout/layers_overlap_2d.html
trunk/PerformanceTests/Layout/layers_overlap_3d.html




Diff

Modified: trunk/PerformanceTests/ChangeLog (167406 => 167407)

--- trunk/PerformanceTests/ChangeLog	2014-04-17 00:56:35 UTC (rev 167406)
+++ trunk/PerformanceTests/ChangeLog	2014-04-17 01:00:26 UTC (rev 167407)
@@ -1,3 +1,17 @@
+2014-04-16  Alexandru Chiculita  ach...@adobe.com
+
+Improve performance of the RenderLayerCompositor::OverlapMap
+https://bugs.webkit.org/show_bug.cgi?id=115063
+
+Reviewed by Simon Fraser.
+
+Testing the performance of computing the overlap of 5000 layers.
+
+* Layout/layers_overlap_2d.html: Added. Using non-composited layers, to check
+that the performance on the non-composited path is not changing with this patch.
+* Layout/layers_overlap_3d.html: Added. Records the time to do the layout of 5000
+non-overlapping 3D layers.
+
 2014-04-15  Zoltan Horvath  zol...@webkit.org
 
 [CSS Shapes] Linking stylesheet instead of inline style definition has ruined ShapesRegions test


Added: trunk/PerformanceTests/Layout/layers_overlap_2d.html (0 => 167407)

--- trunk/PerformanceTests/Layout/layers_overlap_2d.html	(rev 0)
+++ trunk/PerformanceTests/Layout/layers_overlap_2d.html	2014-04-17 01:00:26 UTC (rev 167407)
@@ -0,0 +1,54 @@
+!DOCTYPE html
+html
+head
+titlePerformance tester for non-overlaping 2D layers/title
+style
+.container {
+position: relative;
+width: 20px;
+height: 20px;
+border: 1px solid #AAA;
+margin: 0 auto 5px;
+}
+
+.box {
+width: 100%;
+height: 100%;
+position: absolute;
+background: red;
+}
+
+.composited {
+-webkit-transform: translateZ(1px);
+}
+/style
+script src=""
+/head
+body
+pre id=log/pre
+script
+function createTestFunction(count) {
+return function() {
+var container = document.createElement(div);
+for(i = 0; i  count; ++i) {
+var outer = document.createElement('div');
+outer.className = 'container';
+var inner = document.createElement('div');
+inner.className = 'box';
+if (i == 0) {
+// Use at least one 3D layer to trigger the overlap map checking.
+inner.className +=  composited;
+}
+outer.appendChild(inner);
+container.appendChild(outer);
+}
+document.body.appendChild(container);
+// Force a layout update.
+document.body.clientHeight;
+container.remove();
+}
+}
+

[webkit-changes] [167408] trunk/Source/WebKit2

[benjamin]

Title: [167408] trunk/Source/WebKit2








Revision 167408
Author benja...@webkit.org
Date 2014-04-16 18:23:44 -0700 (Wed, 16 Apr 2014)


Log Message
[iOS][WK2] Do not update the visible content rects when setting the same obscured insets multiple times
https://bugs.webkit.org/show_bug.cgi?id=131633

Patch by Benjamin Poulain bpoul...@apple.com on 2014-04-16
Reviewed by Darin Adler.

We should avoid computing the visible content rects when not needed.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setObscuredInsets:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167407 => 167408)

--- trunk/Source/WebKit2/ChangeLog	2014-04-17 01:00:26 UTC (rev 167407)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-17 01:23:44 UTC (rev 167408)
@@ -1,3 +1,15 @@
+2014-04-16  Benjamin Poulain  bpoul...@apple.com
+
+[iOS][WK2] Do not update the visible content rects when setting the same obscured insets multiple times
+https://bugs.webkit.org/show_bug.cgi?id=131633
+
+Reviewed by Darin Adler.
+
+We should avoid computing the visible content rects when not needed.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _setObscuredInsets:]):
+
 2014-04-16  Zan Dobersek  zdober...@igalia.com
 
 Make IPC::Arguments a variadic template


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (167407 => 167408)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-04-17 01:00:26 UTC (rev 167407)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-04-17 01:23:44 UTC (rev 167408)
@@ -1271,6 +1271,10 @@
 ASSERT(obscuredInsets.left = 0);
 ASSERT(obscuredInsets.bottom = 0);
 ASSERT(obscuredInsets.right = 0);
+
+if (UIEdgeInsetsEqualToEdgeInsets(_obscuredInsets, obscuredInsets))
+return;
+
 _obscuredInsets = obscuredInsets;
 [self _updateVisibleContentRects];
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167409] trunk/Source/WebKit2

[benjamin]

Title: [167409] trunk/Source/WebKit2








Revision 167409
Author benja...@webkit.org
Date 2014-04-16 18:26:07 -0700 (Wed, 16 Apr 2014)


Log Message
[iOS][WK2] Improve the approximation of the scroll position of the dynamic viewport size updates
https://bugs.webkit.org/show_bug.cgi?id=131720

Patch by Benjamin Poulain bpoul...@apple.com on 2014-04-16
Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollToContentOffset:]):
The scrolling tree was forcing scroll at the wrong scale during the transition. 

(-[WKWebView _setMinimumLayoutSizeOverride:]):
This was left out by accident. The WebProcess was getting the new layout size twice, making
WebPage::dynamicViewportSizeUpdate() very confused when the content size changes.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
Add scrolling adjustment for the dynamic relayout case:
-Sticky top and bottom like the UIProcess.
-Keep the same relative position of the unobscured rect's center.

Also fix a bug in the horizontal and vertical adjustments: the code was using the exposed rect
instead of the unobscured rect, which made the adjustments off by the size of the obscured insets.

The type is changed from double to float since ARMv7 has a grudge against double.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167408 => 167409)

--- trunk/Source/WebKit2/ChangeLog	2014-04-17 01:23:44 UTC (rev 167408)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-17 01:26:07 UTC (rev 167409)
@@ -1,5 +1,31 @@
 2014-04-16  Benjamin Poulain  bpoul...@apple.com
 
+[iOS][WK2] Improve the approximation of the scroll position of the dynamic viewport size updates
+https://bugs.webkit.org/show_bug.cgi?id=131720
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _scrollToContentOffset:]):
+The scrolling tree was forcing scroll at the wrong scale during the transition. 
+
+(-[WKWebView _setMinimumLayoutSizeOverride:]):
+This was left out by accident. The WebProcess was getting the new layout size twice, making
+WebPage::dynamicViewportSizeUpdate() very confused when the content size changes.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::dynamicViewportSizeUpdate):
+Add scrolling adjustment for the dynamic relayout case:
+-Sticky top and bottom like the UIProcess.
+-Keep the same relative position of the unobscured rect's center.
+
+Also fix a bug in the horizontal and vertical adjustments: the code was using the exposed rect
+instead of the unobscured rect, which made the adjustments off by the size of the obscured insets.
+
+The type is changed from double to float since ARMv7 has a grudge against double.
+
+2014-04-16  Benjamin Poulain  bpoul...@apple.com
+
 [iOS][WK2] Do not update the visible content rects when setting the same obscured insets multiple times
 https://bugs.webkit.org/show_bug.cgi?id=131633
 


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (167408 => 167409)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-04-17 01:23:44 UTC (rev 167408)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-04-17 01:26:07 UTC (rev 167409)
@@ -549,10 +549,14 @@
 
 - (void)_scrollToContentOffset:(WebCore::FloatPoint)contentOffset
 {
+if (_isAnimatingResize)
+return;
+
 WebCore::FloatPoint scaledOffset = contentOffset;
 CGFloat zoomScale = contentZoomScale(self);
 scaledOffset.scale(zoomScale, zoomScale);
 
+// FIXME: the offset is relative to the unobscured rect top, not the content insets!
 UIEdgeInsets inset = [_scrollView contentInset];
 scaledOffset += WebCore::FloatSize(-inset.left, -inset.top);
 
@@ -1257,7 +1261,8 @@
 {
 _hasStaticMinimumLayoutSize = YES;
 _minimumLayoutSizeOverride = minimumLayoutSizeOverride;
-setViewportConfigurationMinimumLayoutSize(*_page, minimumLayoutSizeOverride);
+if (!_isAnimatingResize)
+setViewportConfigurationMinimumLayoutSize(*_page, minimumLayoutSizeOverride);
 }
 
 - (UIEdgeInsets)_obscuredInsets


Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (167408 => 167409)

--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2014-04-17 01:23:44 UTC (rev 167408)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2014-04-17 01:26:07 UTC (rev 167409)
@@ -1803,19 +1803,43 @@
 newUnobscuredContentRect.setWidth(std::min(static_castfloat(newContentSize.width()), newExposedContentRect.width()));
 newUnobscuredContentRect.setHeight(std::min(static_castfloat(newContentSize.height()), newExposedContentRect.height()));
 
-double horizontalAdjustment = 0;
+if (oldContentSize != 

[webkit-changes] [167412] trunk/Source/WebKit2

[benjamin]

Title: [167412] trunk/Source/WebKit2








Revision 167412
Author benja...@webkit.org
Date 2014-04-16 20:28:02 -0700 (Wed, 16 Apr 2014)


Log Message
[iOS][WK2] Fix the DidCommitLoad initial scrolling position
https://bugs.webkit.org/show_bug.cgi?id=131780

Patch by Benjamin Poulain bpoul...@apple.com on 2014-04-16
Reviewed by Jon Honeycutt.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):
That code is older than _obscuredInsets and used the contentInsets as a workaround.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (167411 => 167412)

--- trunk/Source/WebKit2/ChangeLog	2014-04-17 03:26:53 UTC (rev 167411)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-17 03:28:02 UTC (rev 167412)
@@ -1,5 +1,16 @@
 2014-04-16  Benjamin Poulain  bpoul...@apple.com
 
+[iOS][WK2] Fix the DidCommitLoad initial scrolling position
+https://bugs.webkit.org/show_bug.cgi?id=131780
+
+Reviewed by Jon Honeycutt.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _didCommitLayerTree:]):
+That code is older than _obscuredInsets and used the contentInsets as a workaround.
+
+2014-04-16  Benjamin Poulain  bpoul...@apple.com
+
 [iOS][WK2] Fix annoying scrolling bugs
 https://bugs.webkit.org/show_bug.cgi?id=131722
 


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (167411 => 167412)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-04-17 03:26:53 UTC (rev 167411)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-04-17 03:28:02 UTC (rev 167412)
@@ -473,8 +473,7 @@
 _gestureController-setRenderTreeSize(layerTreeTransaction.renderTreeSize());
 
 if (_isWaitingForNewLayerTreeAfterDidCommitLoad) {
-UIEdgeInsets inset = [_scrollView contentInset];
-[_scrollView setContentOffset:CGPointMake(-inset.left, -inset.top)];
+[_scrollView setContentOffset:CGPointMake(-_obscuredInsets.left, -_obscuredInsets.top)];
 _isWaitingForNewLayerTreeAfterDidCommitLoad = NO;
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167413] tags/Safari-538.30/

[lforschler]

Title: [167413] tags/Safari-538.30/








Revision 167413
Author lforsch...@apple.com
Date 2014-04-16 20:44:39 -0700 (Wed, 16 Apr 2014)


Log Message
New Tag.

Added Paths

tags/Safari-538.30/




Diff

Property changes: tags/Safari-538.30



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167414] trunk/Source

[lforschler]

Title: [167414] trunk/Source








Revision 167414
Author lforsch...@apple.com
Date 2014-04-16 20:48:02 -0700 (Wed, 16 Apr 2014)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (167413 => 167414)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2014-04-17 03:44:39 UTC (rev 167413)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2014-04-17 03:48:02 UTC (rev 167414)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 538;
-MINOR_VERSION = 30;
+MINOR_VERSION = 31;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (167413 => 167414)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2014-04-17 03:44:39 UTC (rev 167413)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2014-04-17 03:48:02 UTC (rev 167414)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 538;
-MINOR_VERSION = 30;
+MINOR_VERSION = 31;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (167413 => 167414)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-04-17 03:44:39 UTC (rev 167413)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-04-17 03:48:02 UTC (rev 167414)
@@ -1,5 +1,5 @@
 MAJOR_VERSION = 538;
-MINOR_VERSION = 30;
+MINOR_VERSION = 31;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (167413 => 167414)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2014-04-17 03:44:39 UTC (rev 167413)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2014-04-17 03:48:02 UTC (rev 167414)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 538;
-MINOR_VERSION = 30;
+MINOR_VERSION = 31;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (167413 => 167414)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2014-04-17 03:44:39 UTC (rev 167413)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2014-04-17 03:48:02 UTC (rev 167414)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 538;
-MINOR_VERSION = 30;
+MINOR_VERSION = 31;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167415] trunk/Source/WebCore

[benjamin]

Title: [167415] trunk/Source/WebCore








Revision 167415
Author benja...@webkit.org
Date 2014-04-16 20:54:11 -0700 (Wed, 16 Apr 2014)


Log Message
Fix the build after r167412

Patch by Benjamin Poulain bpoul...@apple.com on 2014-04-16

* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (167414 => 167415)

--- trunk/Source/WebCore/ChangeLog	2014-04-17 03:48:02 UTC (rev 167414)
+++ trunk/Source/WebCore/ChangeLog	2014-04-17 03:54:11 UTC (rev 167415)
@@ -1,5 +1,12 @@
 2014-04-16  Benjamin Poulain  bpoul...@apple.com
 
+Fix the build after r167412
+
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::updateScrollbars):
+
+2014-04-16  Benjamin Poulain  bpoul...@apple.com
+
 [iOS][WK2] Fix annoying scrolling bugs
 https://bugs.webkit.org/show_bug.cgi?id=131722
 


Modified: trunk/Source/WebCore/platform/ScrollView.cpp (167414 => 167415)

--- trunk/Source/WebCore/platform/ScrollView.cpp	2014-04-17 03:48:02 UTC (rev 167414)
+++ trunk/Source/WebCore/platform/ScrollView.cpp	2014-04-17 03:54:11 UTC (rev 167415)
@@ -731,7 +731,6 @@
 m_verticalScrollbar-offsetDidChange();
 
 m_inUpdateScrollbars = false;
-#endif
 }
 
 const int panIconSizeLength = 16;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167417] trunk/Source/JavaScriptCore

[fpizlo]

Title: [167417] trunk/Source/_javascript_Core








Revision 167417
Author fpi...@apple.com
Date 2014-04-16 22:02:28 -0700 (Wed, 16 Apr 2014)


Log Message
Extra error reporting for invalid value conversions
https://bugs.webkit.org/show_bug.cgi?id=131786

Rubber stamped by Ryosuke Niwa.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::injectTypeConversionsForEdge):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167416 => 167417)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-17 04:57:29 UTC (rev 167416)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-17 05:02:28 UTC (rev 167417)
@@ -1,5 +1,15 @@
 2014-04-16  Filip Pizlo  fpi...@apple.com
 
+Extra error reporting for invalid value conversions
+https://bugs.webkit.org/show_bug.cgi?id=131786
+
+Rubber stamped by Ryosuke Niwa.
+
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::injectTypeConversionsForEdge):
+
+2014-04-16  Filip Pizlo  fpi...@apple.com
+
 Sink NaN sanitization to uses and remove it when it's unnecessary
 https://bugs.webkit.org/show_bug.cgi?id=131419
 


Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (167416 => 167417)

--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp	2014-04-17 04:57:29 UTC (rev 167416)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp	2014-04-17 05:02:28 UTC (rev 167417)
@@ -1898,6 +1898,8 @@
 Node* result;
 if (edge-hasDoubleResult()) {
 // This will never happen.
+dataLog(Found an Int52RepUse to a double result: , node,  - , edge, \n);
+m_graph.dump();
 RELEASE_ASSERT_NOT_REACHED();
 } else if (edge-shouldSpeculateInt32ForArithmetic()) {
 result = m_insertionSet.insertNode(
@@ -1905,7 +1907,11 @@
 Edge(edge.node(), Int32Use));
 } else {
 // This is only here for dealing with constants.
-RELEASE_ASSERT(edge-op() == JSConstant);
+if (edge-op() != JSConstant) {
+dataLog(Found an Int52RepUse on something that is neither Int32 nor a constant: , node,  - , edge, \n);
+m_graph.dump();
+RELEASE_ASSERT_NOT_REACHED();
+}
 result = m_insertionSet.insertNode(
 m_indexInBlock, SpecMachineInt, Int52Constant, node-origin,
 OpInfo(edge-constantNumber()));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167416] trunk/Source/JavaScriptCore

[fpizlo]

Title: [167416] trunk/Source/_javascript_Core








Revision 167416
Author fpi...@apple.com
Date 2014-04-16 21:57:29 -0700 (Wed, 16 Apr 2014)


Log Message
Sink NaN sanitization to uses and remove it when it's unnecessary
https://bugs.webkit.org/show_bug.cgi?id=131419

Reviewed by Oliver Hunt.

This moves NaN purification to stores that could see an impure NaN.

5% speed-up on AsmBench, 50% speed-up on AsmBench/n-body. It is a regression on FloatMM
though, because of the other bug that causes that benchmark to box doubles in a loop.

* bytecode/SpeculatedType.h:
(JSC::isInt32SpeculationForArithmetic):
(JSC::isMachineIntSpeculationForArithmetic):
(JSC::isDoubleSpeculation):
(JSC::isDoubleSpeculationForArithmetic):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreterAbstractStateType::executeEffects):
* dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::fixTypeForRepresentation):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::injectTypeConversionsForEdge):
* dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueRep):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
* dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileValueRep):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
* runtime/PureNaN.h:
* tests/stress/float32-array-nan-inlined.js: Added.
(foo):
(test):
* tests/stress/float32-array-nan.js: Added.
(foo):
(test):
* tests/stress/float64-array-nan-inlined.js: Added.
(foo):
(isBigEndian):
(test):
* tests/stress/float64-array-nan.js: Added.
(foo):
(isBigEndian):
(test):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/SpeculatedType.h
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGAbstractValue.cpp
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGInPlaceAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGUseKind.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
trunk/Source/_javascript_Core/runtime/PureNaN.h


Added Paths

trunk/Source/_javascript_Core/tests/stress/float32-array-nan-inlined.js
trunk/Source/_javascript_Core/tests/stress/float32-array-nan.js
trunk/Source/_javascript_Core/tests/stress/float64-array-nan-inlined.js
trunk/Source/_javascript_Core/tests/stress/float64-array-nan.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167415 => 167416)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-17 03:54:11 UTC (rev 167415)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-17 04:57:29 UTC (rev 167416)
@@ -1,3 +1,55 @@
+2014-04-16  Filip Pizlo  fpi...@apple.com
+
+Sink NaN sanitization to uses and remove it when it's unnecessary
+https://bugs.webkit.org/show_bug.cgi?id=131419
+
+Reviewed by Oliver Hunt.
+
+This moves NaN purification to stores that could see an impure NaN.
+
+5% speed-up on AsmBench, 50% speed-up on AsmBench/n-body. It is a regression on FloatMM
+though, because of the other bug that causes that benchmark to box doubles in a loop.
+
+* bytecode/SpeculatedType.h:
+(JSC::isInt32SpeculationForArithmetic):
+(JSC::isMachineIntSpeculationForArithmetic):
+(JSC::isDoubleSpeculation):
+(JSC::isDoubleSpeculationForArithmetic):
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreterAbstractStateType::executeEffects):
+* dfg/DFGAbstractValue.cpp:
+(JSC::DFG::AbstractValue::fixTypeForRepresentation):
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::fixupNode):
+(JSC::DFG::FixupPhase::injectTypeConversionsForEdge):
+* dfg/DFGInPlaceAbstractState.cpp:
+(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
+* dfg/DFGPredictionPropagationPhase.cpp:
+(JSC::DFG::PredictionPropagationPhase::propagate):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileValueRep):
+(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
+* dfg/DFGUseKind.h:
+(JSC::DFG::typeFilterFor):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileValueRep):
+(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
+* runtime/PureNaN.h:
+* tests/stress/float32-array-nan-inlined.js: Added.
+(foo):
+(test):
+* tests/stress/float32-array-nan.js: Added.
+(foo):
+(test):
+* tests/stress/float64-array-nan-inlined.js: Added.
+(foo):
+(isBigEndian):
+

[webkit-changes] [167418] trunk/Source/JavaScriptCore

[ap]

Title: [167418] trunk/Source/_javascript_Core








Revision 167418
Author a...@apple.com
Date 2014-04-16 22:31:33 -0700 (Wed, 16 Apr 2014)


Log Message
Build fix after http://trac.webkit.org/changeset/167416 (Sink NaN sanitization)

* dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::speculate):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167417 => 167418)

--- trunk/Source/_javascript_Core/ChangeLog	2014-04-17 05:02:28 UTC (rev 167417)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-17 05:31:33 UTC (rev 167418)
@@ -1,3 +1,9 @@
+2014-04-16  Alexey Proskuryakov  a...@apple.com
+
+Build fix after http://trac.webkit.org/changeset/167416 (Sink NaN sanitization)
+
+* dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::speculate):
+
 2014-04-16  Filip Pizlo  fpi...@apple.com
 
 Extra error reporting for invalid value conversions


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (167417 => 167418)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2014-04-17 05:02:28 UTC (rev 167417)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2014-04-17 05:31:33 UTC (rev 167418)
@@ -4855,7 +4855,7 @@
 ASSERT(!needsTypeCheck(edge, SpecInt32));
 break;
 case DoubleRepUse:
-ASSERT(!needsTypeCheck(edge, SpecDouble));
+ASSERT(!needsTypeCheck(edge, SpecFullDouble));
 break;
 case Int52RepUse:
 ASSERT(!needsTypeCheck(edge, SpecMachineInt));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167419] tags/Safari-538.30/

[lforschler]

Title: [167419] tags/Safari-538.30/








Revision 167419
Author lforsch...@apple.com
Date 2014-04-16 22:58:55 -0700 (Wed, 16 Apr 2014)


Log Message
Remove Tag.

Removed Paths

tags/Safari-538.30/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes