[webkit-changes] [177822] trunk/Tools
Title: [177822] trunk/Tools Revision 177822 Author k.cz...@samsung.com Date 2014-12-30 04:29:16 -0800 (Tue, 30 Dec 2014) Log Message [EFL] Bump version of ATK used by jhbuild to 2.15.2 https://bugs.webkit.org/show_bug.cgi?id=139816 Reviewed by Gyuyoung Kim. Bump version of ATK used by jhbuild to 2.15.2 * efl/jhbuild.modules: Modified Paths trunk/Tools/ChangeLog trunk/Tools/efl/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (177821 => 177822) --- trunk/Tools/ChangeLog 2014-12-30 04:39:59 UTC (rev 177821) +++ trunk/Tools/ChangeLog 2014-12-30 12:29:16 UTC (rev 177822) @@ -1,3 +1,14 @@ +2014-12-30 Krzysztof Czech k.cz...@samsung.com + +[EFL] Bump version of ATK used by jhbuild to 2.15.2 +https://bugs.webkit.org/show_bug.cgi?id=139816 + +Reviewed by Gyuyoung Kim. + +Bump version of ATK used by jhbuild to 2.15.2 + +* efl/jhbuild.modules: + 2014-12-29 Fabien Vallée fval...@connected-labs.com [jhBuild] cairo build error (-flto) Modified: trunk/Tools/efl/jhbuild.modules (177821 => 177822) --- trunk/Tools/efl/jhbuild.modules 2014-12-30 04:39:59 UTC (rev 177821) +++ trunk/Tools/efl/jhbuild.modules 2014-12-30 12:29:16 UTC (rev 177822) @@ -287,9 +287,9 @@ autotools id=atk autogen-sh=configure autogenargs=--disable-introspection -branch module=pub/GNOME/sources/atk/2.11/atk-2.11.92.tar.xz version=2.11.92 +branch module=pub/GNOME/sources/atk/2.15/atk-2.15.2.tar.xz version=2.15.2 repo=ftp.gnome.org -hash=sha256:71e9880f1b704dfd98806643b8dc66a5df4fcef155cf5944184d8e8f66dac689/ +hash=sha256:179d15424b8aa3a5726903f0da458de68e0585dfd9d451c6dcfcdb6b7b509cbe/ dependencies dep package=glib/ /dependencies ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [177823] trunk/Source/WebKit2
Title: [177823] trunk/Source/WebKit2 Revision 177823 Author ander...@apple.com Date 2014-12-30 09:41:13 -0800 (Tue, 30 Dec 2014) Log Message Transient local storage namespaces need to ref their storage areas https://bugs.webkit.org/show_bug.cgi?id=140006 rdar://problem/19225389 Reviewed by Sam Weinig. We need to keep transient storage areas around even if they have no active connections, so use a RefPtr instead of a raw pointer. This matches what we do for session storage namespaces. * UIProcess/Storage/StorageManager.cpp: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (177822 => 177823) --- trunk/Source/WebKit2/ChangeLog 2014-12-30 12:29:16 UTC (rev 177822) +++ trunk/Source/WebKit2/ChangeLog 2014-12-30 17:41:13 UTC (rev 177823) @@ -1,3 +1,16 @@ +2014-12-30 Anders Carlsson ander...@apple.com + +Transient local storage namespaces need to ref their storage areas +https://bugs.webkit.org/show_bug.cgi?id=140006 +rdar://problem/19225389 + +Reviewed by Sam Weinig. + +We need to keep transient storage areas around even if they have no active connections, +so use a RefPtr instead of a raw pointer. This matches what we do for session storage namespaces. + +* UIProcess/Storage/StorageManager.cpp: + 2014-12-29 Anders Carlsson ander...@apple.com Remove unneeded StorageNamespace functions Modified: trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp (177822 => 177823) --- trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp 2014-12-30 12:29:16 UTC (rev 177822) +++ trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp 2014-12-30 17:41:13 UTC (rev 177823) @@ -150,8 +150,7 @@ const unsigned m_quotaInBytes = 5 * 1024 * 1024; -// We don't hold an explicit reference to the StorageAreas; they are kept alive by the m_storageAreasByConnection map in StorageManager. -HashMapRefPtrSecurityOrigin, StorageArea* m_storageAreaMap; +HashMapRefPtrSecurityOrigin, RefPtrStorageArea m_storageAreaMap; }; RefStorageManager::StorageArea StorageManager::StorageArea::create(LocalStorageNamespace* localStorageNamespace, RefPtrSecurityOrigin securityOrigin, unsigned quotaInBytes) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [177824] trunk
Title: [177824] trunk
Revision 177824
Author rga...@webkit.org
Date 2014-12-30 10:40:20 -0800 (Tue, 30 Dec 2014)
Log Message
Too large plugins are crashing.
https://bugs.webkit.org/show_bug.cgi?id=139856
Reviewed by Darin Adler.
Source/WebKit2:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::updateBackingStore): Return false if backingStore cannot be allocated.
LayoutTests:
Add layout test to cover this crash.
* plugins/large-plugin-crash-expected.txt: Added.
* plugins/large-plugin-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
Added Paths
trunk/LayoutTests/plugins/large-plugin-crash-expected.txt
trunk/LayoutTests/plugins/large-plugin-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (177823 => 177824)
--- trunk/LayoutTests/ChangeLog 2014-12-30 17:41:13 UTC (rev 177823)
+++ trunk/LayoutTests/ChangeLog 2014-12-30 18:40:20 UTC (rev 177824)
@@ -1,3 +1,15 @@
+2014-12-30 Gabor Rapcsanyi rga...@webkit.org
+
+Too large plugins are crashing.
+https://bugs.webkit.org/show_bug.cgi?id=139856
+
+Reviewed by Darin Adler.
+
+Add layout test to cover this crash.
+
+* plugins/large-plugin-crash-expected.txt: Added.
+* plugins/large-plugin-crash.html: Added.
+
2014-12-29 Sebastian Dröge sebast...@centricular.com
Enable MediaSource tests for the GTK port
Added: trunk/LayoutTests/plugins/large-plugin-crash-expected.txt (0 => 177824)
--- trunk/LayoutTests/plugins/large-plugin-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/plugins/large-plugin-crash-expected.txt 2014-12-30 18:40:20 UTC (rev 177824)
@@ -0,0 +1,5 @@
+Bug 139856: Large plugin crash.
+
+This test PASSES if it does not CRASH.
+
+
Added: trunk/LayoutTests/plugins/large-plugin-crash.html (0 => 177824)
--- trunk/LayoutTests/plugins/large-plugin-crash.html (rev 0)
+++ trunk/LayoutTests/plugins/large-plugin-crash.html 2014-12-30 18:40:20 UTC (rev 177824)
@@ -0,0 +1,15 @@
+html
+body
+pBug a href="" Large plugin crash./p
+pThis test PASSES if it does not CRASH./p
+
+embed id=plugin width=9 type=application/x-webkit-test-netscape/embed
+
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+document.getElementById('plugin').style.webkitTransform = 'scale(1)';
+/script
+
+/body
+/html
Modified: trunk/Source/WebKit2/ChangeLog (177823 => 177824)
--- trunk/Source/WebKit2/ChangeLog 2014-12-30 17:41:13 UTC (rev 177823)
+++ trunk/Source/WebKit2/ChangeLog 2014-12-30 18:40:20 UTC (rev 177824)
@@ -1,3 +1,13 @@
+2014-12-30 Gabor Rapcsanyi rga...@webkit.org
+
+Too large plugins are crashing.
+https://bugs.webkit.org/show_bug.cgi?id=139856
+
+Reviewed by Darin Adler.
+
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::updateBackingStore): Return false if backingStore cannot be allocated.
+
2014-12-30 Anders Carlsson ander...@apple.com
Transient local storage namespaces need to ref their storage areas
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (177823 => 177824)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2014-12-30 17:41:13 UTC (rev 177823)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2014-12-30 18:40:20 UTC (rev 177824)
@@ -596,6 +596,8 @@
if (!m_backingStore) {
m_backingStore = ShareableBitmap::create(backingStoreSize, ShareableBitmap::SupportsAlpha);
+if (!m_backingStore)
+return false;
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [177825] trunk/Source/WebKit/mac
Title: [177825] trunk/Source/WebKit/mac
Revision 177825
Author m...@apple.com
Date 2014-12-30 12:43:00 -0800 (Tue, 30 Dec 2014)
Log Message
[Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
https://bugs.webkit.org/show_bug.cgi?id=140003
Reviewed by Darin Adler.
* Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
that takes their string parameter as a value parameter and has an attribute telling
the compiler that if the value parameter is a format string then the function returns a
modified version of it. The result is that if UI_STRING is used as a format string parameter
to some function or method, the compiler will check the format specifiers in the string
against the other parameters.
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (177824 => 177825)
--- trunk/Source/WebKit/mac/ChangeLog 2014-12-30 18:40:20 UTC (rev 177824)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-12-30 20:43:00 UTC (rev 177825)
@@ -1,3 +1,17 @@
+2014-12-30 Dan Bernstein m...@apple.com
+
+[Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
+https://bugs.webkit.org/show_bug.cgi?id=140003
+
+Reviewed by Darin Adler.
+
+* Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
+that takes their string parameter as a value parameter and has an attribute telling
+the compiler that if the value parameter is a format string then the function returns a
+modified version of it. The result is that if UI_STRING is used as a format string parameter
+to some function or method, the compiler will check the format specifiers in the string
+against the other parameters.
+
2014-12-29 Dan Bernstein m...@apple.com
Fixed the iOS build.
Modified: trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h (177824 => 177825)
--- trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h 2014-12-30 18:40:20 UTC (rev 177824)
+++ trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h 2014-12-30 20:43:00 UTC (rev 177825)
@@ -28,11 +28,15 @@
#if __OBJC__
@class NSBundle;
-#elif __cplusplus
+typedef NSString *WebLocalizedStringType;
+#else
+#if __cplusplus
class NSBundle;
#else
typedef struct NSBundle NSBundle;
#endif
+typedef CFStringRef WebLocalizedStringType;
+#endif
typedef struct {
const char *identifier;
@@ -43,11 +47,7 @@
extern C {
#endif
-#if __OBJC__
-NSString *WebLocalizedString(WebLocalizableStringsBundle *bundle, const char *key);
-#else
-CFStringRef WebLocalizedString(WebLocalizableStringsBundle *bundle, const char *key);
-#endif
+WebLocalizedStringType WebLocalizedString(WebLocalizableStringsBundle* bundle, const char* key);
#if TARGET_OS_IPHONE
void LoadWebLocalizedStrings(void); // The first WebLocalizedString call can take over 20ms unless this function is called beforehand.
@@ -57,18 +57,23 @@
}
#endif
+static inline __attribute__((format_arg(3))) WebLocalizedStringType WebLocalizedStringWithValue(WebLocalizableStringsBundle* bundle, const char* key, const char* value)
+{
+return WebLocalizedString(bundle, key);
+}
+
#ifdef FRAMEWORK_NAME
#define LOCALIZABLE_STRINGS_BUNDLE(F) LOCALIZABLE_STRINGS_BUNDLE_HELPER(F)
#define LOCALIZABLE_STRINGS_BUNDLE_HELPER(F) F ## LocalizableStringsBundle
extern WebLocalizableStringsBundle LOCALIZABLE_STRINGS_BUNDLE(FRAMEWORK_NAME);
-#define UI_STRING(string, comment) WebLocalizedString(LOCALIZABLE_STRINGS_BUNDLE(FRAMEWORK_NAME), string)
-#define UI_STRING_KEY(string, key, comment) WebLocalizedString(LOCALIZABLE_STRINGS_BUNDLE(FRAMEWORK_NAME), key)
+#define UI_STRING(string, comment) WebLocalizedStringWithValue(LOCALIZABLE_STRINGS_BUNDLE(FRAMEWORK_NAME), string, string)
+#define UI_STRING_KEY(string, key, comment) WebLocalizedStringWithValue(LOCALIZABLE_STRINGS_BUNDLE(FRAMEWORK_NAME), key, string)
#else
-#define UI_STRING(string, comment) WebLocalizedString(0, string)
-#define UI_STRING_KEY(string, key, comment) WebLocalizedString(0, key)
+#define UI_STRING(string, comment) WebLocalizedStringWithValue(0, string, string)
+#define UI_STRING_KEY(string, key, comment) WebLocalizedStringWithValue(0, key, string)
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [177826] trunk
Title: [177826] trunk Revision 177826 Author rga...@webkit.org Date 2014-12-30 14:09:58 -0800 (Tue, 30 Dec 2014) Log Message Source/WebKit2: Too large plugins are crashing. https://bugs.webkit.org/show_bug.cgi?id=139868 Reviewed by Darin Adler. * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::updateBackingStore): Return false if backingStore cannot be allocated. LayoutTests: Fix bug number typo in the previous commit. * plugins/large-plugin-crash-expected.txt: * plugins/large-plugin-crash.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/plugins/large-plugin-crash-expected.txt trunk/LayoutTests/plugins/large-plugin-crash.html trunk/Source/WebKit2/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (177825 => 177826) --- trunk/LayoutTests/ChangeLog 2014-12-30 20:43:00 UTC (rev 177825) +++ trunk/LayoutTests/ChangeLog 2014-12-30 22:09:58 UTC (rev 177826) @@ -1,7 +1,14 @@ 2014-12-30 Gabor Rapcsanyi rga...@webkit.org +Fix bug number typo in the previous commit. + +* plugins/large-plugin-crash-expected.txt: +* plugins/large-plugin-crash.html: + +2014-12-30 Gabor Rapcsanyi rga...@webkit.org + Too large plugins are crashing. -https://bugs.webkit.org/show_bug.cgi?id=139856 +https://bugs.webkit.org/show_bug.cgi?id=139868 Reviewed by Darin Adler. Modified: trunk/LayoutTests/plugins/large-plugin-crash-expected.txt (177825 => 177826) --- trunk/LayoutTests/plugins/large-plugin-crash-expected.txt 2014-12-30 20:43:00 UTC (rev 177825) +++ trunk/LayoutTests/plugins/large-plugin-crash-expected.txt 2014-12-30 22:09:58 UTC (rev 177826) @@ -1,4 +1,4 @@ -Bug 139856: Large plugin crash. +Bug 139868: Large plugin crash. This test PASSES if it does not CRASH. Modified: trunk/LayoutTests/plugins/large-plugin-crash.html (177825 => 177826) --- trunk/LayoutTests/plugins/large-plugin-crash.html 2014-12-30 20:43:00 UTC (rev 177825) +++ trunk/LayoutTests/plugins/large-plugin-crash.html 2014-12-30 22:09:58 UTC (rev 177826) @@ -1,6 +1,6 @@ html body -pBug a href="" Large plugin crash./p +pBug a href="" Large plugin crash./p pThis test PASSES if it does not CRASH./p embed id=plugin width=9 type=application/x-webkit-test-netscape/embed Modified: trunk/Source/WebKit2/ChangeLog (177825 => 177826) --- trunk/Source/WebKit2/ChangeLog 2014-12-30 20:43:00 UTC (rev 177825) +++ trunk/Source/WebKit2/ChangeLog 2014-12-30 22:09:58 UTC (rev 177826) @@ -1,7 +1,7 @@ 2014-12-30 Gabor Rapcsanyi rga...@webkit.org Too large plugins are crashing. -https://bugs.webkit.org/show_bug.cgi?id=139856 +https://bugs.webkit.org/show_bug.cgi?id=139868 Reviewed by Darin Adler. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [177827] trunk/Source/WebCore
Title: [177827] trunk/Source/WebCore
Revision 177827
Author cdu...@apple.com
Date 2014-12-30 14:25:32 -0800 (Tue, 30 Dec 2014)
Log Message
Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=140007
Reviewed by Darin Adler.
Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
by using custom code.
* css/CSSPropertyNames.in:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue): Deleted.
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue): Deleted.
(WebCore::ApplyPropertyFontVariantLigatures::applyValue): Deleted.
(WebCore::ApplyPropertyFontVariantLigatures::createHandler): Deleted.
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInitialWebkitFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyInheritWebkitFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyValueWebkitFontVariantLigatures):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPropertyNames.in
trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp
trunk/Source/WebCore/css/StyleBuilderCustom.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (177826 => 177827)
--- trunk/Source/WebCore/ChangeLog 2014-12-30 22:09:58 UTC (rev 177826)
+++ trunk/Source/WebCore/ChangeLog 2014-12-30 22:25:32 UTC (rev 177827)
@@ -1,3 +1,25 @@
+2014-12-30 Chris Dumez cdu...@apple.com
+
+Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
+https://bugs.webkit.org/show_bug.cgi?id=140007
+
+Reviewed by Darin Adler.
+
+Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
+by using custom code.
+
+* css/CSSPropertyNames.in:
+* css/DeprecatedStyleBuilder.cpp:
+(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
+(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue): Deleted.
+(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue): Deleted.
+(WebCore::ApplyPropertyFontVariantLigatures::applyValue): Deleted.
+(WebCore::ApplyPropertyFontVariantLigatures::createHandler): Deleted.
+* css/StyleBuilderCustom.h:
+(WebCore::StyleBuilderCustom::applyInitialWebkitFontVariantLigatures):
+(WebCore::StyleBuilderCustom::applyInheritWebkitFontVariantLigatures):
+(WebCore::StyleBuilderCustom::applyValueWebkitFontVariantLigatures):
+
2014-12-29 Chris Dumez cdu...@apple.com
Move animation / transition CSS properties to the new StyleBuilder
Modified: trunk/Source/WebCore/css/CSSPropertyNames.in (177826 => 177827)
--- trunk/Source/WebCore/css/CSSPropertyNames.in 2014-12-30 22:09:58 UTC (rev 177826)
+++ trunk/Source/WebCore/css/CSSPropertyNames.in 2014-12-30 22:25:32 UTC (rev 177827)
@@ -93,7 +93,7 @@
-webkit-font-feature-settings [Inherited, LegacyStyleBuilder]
-webkit-font-kerning [Inherited, LegacyStyleBuilder]
-webkit-font-smoothing [Inherited, LegacyStyleBuilder]
--webkit-font-variant-ligatures [Inherited, LegacyStyleBuilder]
+-webkit-font-variant-ligatures [Inherited, Custom=All]
-webkit-locale [Inherited, Custom=Value]
-webkit-text-orientation [Inherited, Custom=Value]
-epub-text-orientation = -webkit-text-orientation
Modified: trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp (177826 => 177827)
--- trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp 2014-12-30 22:09:58 UTC (rev 177826)
+++ trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp 2014-12-30 22:25:32 UTC (rev 177827)
@@ -313,86 +313,6 @@
static PropertyHandler createHandler() { return PropertyHandler(applyInheritValue, applyInitialValue, applyValue); }
};
-class ApplyPropertyFontVariantLigatures {
-public:
-static void applyInheritValue(CSSPropertyID, StyleResolver* styleResolver)
-{
-const FontDescription parentFontDescription = styleResolver-parentFontDescription();
-FontDescription fontDescription = styleResolver-fontDescription();
-
-fontDescription.setCommonLigaturesState(parentFontDescription.commonLigaturesState());
-fontDescription.setDiscretionaryLigaturesState(parentFontDescription.discretionaryLigaturesState());
-fontDescription.setHistoricalLigaturesState(parentFontDescription.historicalLigaturesState());
-
-styleResolver-setFontDescription(fontDescription);
-}
-
-static void applyInitialValue(CSSPropertyID, StyleResolver* styleResolver)
-{
-FontDescription fontDescription = styleResolver-fontDescription();
-
-fontDescription.setCommonLigaturesState(FontDescription::NormalLigaturesState);
-fontDescription.setDiscretionaryLigaturesState(FontDescription::NormalLigaturesState);
-fontDescription.setHistoricalLigaturesState(FontDescription::NormalLigaturesState);
-
-styleResolver-setFontDescription(fontDescription);
-}
-
-
[webkit-changes] [177828] trunk/Source/WebCore
Title: [177828] trunk/Source/WebCore Revision 177828 Author cdu...@apple.com Date 2014-12-30 16:53:04 -0800 (Tue, 30 Dec 2014) Log Message Move font-related CSS properties to the new StyleBuilder https://bugs.webkit.org/show_bug.cgi?id=140008 Reviewed by Darin Adler. Move font-related CSS properties to the new StyleBuilder by teaching makeprop.pl how to generate them. * css/CSSPropertyNames.in: * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): (WebCore::ApplyPropertyFont::applyInheritValue): Deleted. (WebCore::ApplyPropertyFont::applyInitialValue): Deleted. (WebCore::ApplyPropertyFont::applyValue): Deleted. (WebCore::ApplyPropertyFont::createHandler): Deleted. * css/makeprop.pl: (generateInitialValueSetter): (generateInheritValueSetter): (generateValueSetter): * platform/graphics/FontDescription.h: (WebCore::FontDescription::initialItalic): (WebCore::FontDescription::initialSmallCaps): (WebCore::FontDescription::initialKerning): (WebCore::FontDescription::initialFontSmoothing): (WebCore::FontDescription::initialTextRenderingMode): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp trunk/Source/WebCore/css/makeprop.pl trunk/Source/WebCore/platform/graphics/FontDescription.h Diff Modified: trunk/Source/WebCore/ChangeLog (177827 => 177828) --- trunk/Source/WebCore/ChangeLog 2014-12-30 22:25:32 UTC (rev 177827) +++ trunk/Source/WebCore/ChangeLog 2014-12-31 00:53:04 UTC (rev 177828) @@ -1,5 +1,33 @@ 2014-12-30 Chris Dumez cdu...@apple.com +Move font-related CSS properties to the new StyleBuilder +https://bugs.webkit.org/show_bug.cgi?id=140008 + +Reviewed by Darin Adler. + +Move font-related CSS properties to the new StyleBuilder +by teaching makeprop.pl how to generate them. + +* css/CSSPropertyNames.in: +* css/DeprecatedStyleBuilder.cpp: +(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): +(WebCore::ApplyPropertyFont::applyInheritValue): Deleted. +(WebCore::ApplyPropertyFont::applyInitialValue): Deleted. +(WebCore::ApplyPropertyFont::applyValue): Deleted. +(WebCore::ApplyPropertyFont::createHandler): Deleted. +* css/makeprop.pl: +(generateInitialValueSetter): +(generateInheritValueSetter): +(generateValueSetter): +* platform/graphics/FontDescription.h: +(WebCore::FontDescription::initialItalic): +(WebCore::FontDescription::initialSmallCaps): +(WebCore::FontDescription::initialKerning): +(WebCore::FontDescription::initialFontSmoothing): +(WebCore::FontDescription::initialTextRenderingMode): + +2014-12-30 Chris Dumez cdu...@apple.com + Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder https://bugs.webkit.org/show_bug.cgi?id=140007 Modified: trunk/Source/WebCore/css/CSSPropertyNames.in (177827 => 177828) --- trunk/Source/WebCore/css/CSSPropertyNames.in 2014-12-30 22:25:32 UTC (rev 177827) +++ trunk/Source/WebCore/css/CSSPropertyNames.in 2014-12-31 00:53:04 UTC (rev 177828) @@ -76,6 +76,10 @@ // * AnimationProperty: // Indicates that this CSS property is an animation / transition property. // It must have corresponding methods on the Animation class. +// +// * FontProperty: +// Indicates that this CSS property is font-related. It must have corresponding +// methods on the FontDescription class. // high-priority property names have to be listed first, to simplify the check @@ -86,13 +90,13 @@ font [Inherited, LegacyStyleBuilder] font-family [Inherited, Custom=All] font-size [Inherited, LegacyStyleBuilder] -font-style [Inherited, LegacyStyleBuilder] -font-variant [Inherited, LegacyStyleBuilder] +font-style [Inherited, FontProperty, TypeName=FontItalic, NameForMethods=Italic] +font-variant [Inherited, FontProperty, TypeName=FontSmallCaps, NameForMethods=SmallCaps] font-weight [Inherited, Custom=All] -text-rendering [Inherited, LegacyStyleBuilder] +text-rendering [Inherited, FontProperty, TypeName=TextRenderingMode, NameForMethods=TextRenderingMode] -webkit-font-feature-settings [Inherited, LegacyStyleBuilder] --webkit-font-kerning [Inherited, LegacyStyleBuilder] --webkit-font-smoothing [Inherited, LegacyStyleBuilder] +-webkit-font-kerning [Inherited, FontProperty, TypeName=FontDescription::Kerning, NameForMethods=Kerning] +-webkit-font-smoothing [Inherited, FontProperty, TypeName=FontSmoothingMode] -webkit-font-variant-ligatures [Inherited, Custom=All] -webkit-locale [Inherited, Custom=Value] -webkit-text-orientation [Inherited, Custom=Value] Modified: trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp (177827 => 177828) --- trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp 2014-12-30 22:25:32 UTC (rev 177827) +++ trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp 2014-12-31 00:53:04 UTC (rev 177828) @@
