[webkit-changes] [179337] trunk/Tools

[ossy]

Title: [179337] trunk/Tools








Revision 179337
Author o...@webkit.org
Date 2015-01-28 23:44:28 -0800 (Wed, 28 Jan 2015)


Log Message
URTBF after r179326, added uuid-dev package as new dependency.

* efl/install-dependencies:
* gtk/install-dependencies:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/efl/install-dependencies
trunk/Tools/gtk/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (179336 => 179337)

--- trunk/Tools/ChangeLog	2015-01-29 07:00:37 UTC (rev 179336)
+++ trunk/Tools/ChangeLog	2015-01-29 07:44:28 UTC (rev 179337)
@@ -1,3 +1,10 @@
+2015-01-28  Csaba Osztrogonác  
+
+URTBF after r179326, added uuid-dev package as new dependency.
+
+* efl/install-dependencies:
+* gtk/install-dependencies:
+
 2015-01-28  Timothy Horton  
 
 Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace


Modified: trunk/Tools/efl/install-dependencies (179336 => 179337)

--- trunk/Tools/efl/install-dependencies	2015-01-29 07:00:37 UTC (rev 179336)
+++ trunk/Tools/efl/install-dependencies	2015-01-29 07:44:28 UTC (rev 179337)
@@ -99,6 +99,7 @@
 ragel \
 ruby \
 subversion \
+uuid-dev \
 x11proto-print-dev
 
 # These are dependencies necessary for building WebKitEFL and not available on ARM64.


Modified: trunk/Tools/gtk/install-dependencies (179336 => 179337)

--- trunk/Tools/gtk/install-dependencies	2015-01-29 07:00:37 UTC (rev 179336)
+++ trunk/Tools/gtk/install-dependencies	2015-01-29 07:44:28 UTC (rev 179337)
@@ -95,6 +95,7 @@
 libxt-dev \
 libxtst-dev \
 ruby \
+uuid-dev \
 xfonts-utils
 
 # These are dependencies necessary for running tests.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179336] trunk/LayoutTests

[commit-queue]

Title: [179336] trunk/LayoutTests








Revision 179336
Author commit-qu...@webkit.org
Date 2015-01-28 23:00:37 -0800 (Wed, 28 Jan 2015)


Log Message
security/mixedContent/redirect-https-to-http-iframe-in-main-frame test is the same as security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
https://bugs.webkit.org/show_bug.cgi?id=140876

Patch by Michael Catanzaro  on 2015-01-28
Reviewed by Darin Adler.

Fix the test so it's not identical to the redirect-http-to-https-iframe-in-main-frame
test, and update the expected results.

* http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
* http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt
trunk/LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html




Diff

Modified: trunk/LayoutTests/ChangeLog (179335 => 179336)

--- trunk/LayoutTests/ChangeLog	2015-01-29 05:23:28 UTC (rev 179335)
+++ trunk/LayoutTests/ChangeLog	2015-01-29 07:00:37 UTC (rev 179336)
@@ -1,3 +1,16 @@
+2015-01-28  Michael Catanzaro  
+
+security/mixedContent/redirect-https-to-http-iframe-in-main-frame test is the same as security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
+https://bugs.webkit.org/show_bug.cgi?id=140876
+
+Reviewed by Darin Adler.
+
+Fix the test so it's not identical to the redirect-http-to-https-iframe-in-main-frame
+test, and update the expected results.
+
+* http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
+* http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html:
+
 2015-01-28  Benjamin Poulain  
 
 Start fixing the handling of Element's attributes when they contain non-ASCII characters


Modified: trunk/LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt (179335 => 179336)

--- trunk/LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt	2015-01-29 05:23:28 UTC (rev 179335)
+++ trunk/LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt	2015-01-29 07:00:37 UTC (rev 179336)
@@ -4,10 +4,10 @@
 main frame - didFinishLoadForFrame
 main frame - didCommitLoadForFrame
 frame "-->" - didStartProvisionalLoadForFrame
-CONSOLE MESSAGE: The page at about:blank displayed insecure content from http://127.0.0.1:8080/resources/redirect.php?url=""
+main frame - didFinishDocumentLoadForFrame
+CONSOLE MESSAGE: The page at about:blank displayed insecure content from http://127.0.0.1:8080/security/mixedContent/resources/boring.html.
 
 didDisplayInsecureContent
-main frame - didFinishDocumentLoadForFrame
 frame "-->" - didReceiveServerRedirectForProvisionalLoadForFrame
 frame "-->" - didCommitLoadForFrame
 frame "-->" - didFinishDocumentLoadForFrame


Modified: trunk/LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html (179335 => 179336)

--- trunk/LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html	2015-01-29 05:23:28 UTC (rev 179335)
+++ trunk/LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html	2015-01-29 07:00:37 UTC (rev 179336)
@@ -20,7 +20,7 @@
 in the window is HTTPS but is displaying content that can be controlled by an
 active network attacker.
 
-window.open("https://127.0.0.1:8443/security/mixedContent/resources/frame-with-redirect-http-to-https-frame.html");
+window.open("https://127.0.0.1:8443/security/mixedContent/resources/frame-with-redirect-https-to-http-frame.html");
 
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179335] trunk

[commit-queue]

Title: [179335] trunk








Revision 179335
Author commit-qu...@webkit.org
Date 2015-01-28 21:23:28 -0800 (Wed, 28 Jan 2015)


Log Message
Poor performance on IE's Chalkboard benchmark.
https://bugs.webkit.org/show_bug.cgi?id=140753.

Patch by Said Abou-Hallawa  on 2015-01-28
Reviewed by Zalan Bujtas.

PerformanceTests:

* SVG/UnderTheSeeBenchmark.html: Added
* SVG/WorldcupBenchmark.html: Added.
* SVG/resources/RenderAnimator.css: Added.
* SVG/resources/RenderAnimator.js: Added.
These are benchmarks for the SVG rendering. Mainly we want to measure how fast
the SVG rendering will be when only a small part of it is drawn.

Source/WebCore:

Test: PerformanceTests/SVG/UnderTheSeeBenchmark.html
  PerformanceTests/SVG/WorldcupBenchmark.html

The SVG rendering code was not skipping the SVG elements which are outside the
clipping rectangle. We were drawing all the SVG elements even if some of them
are completely outside the clipping rectangle. The fix is to pass the correct
dirty rectangle to the ScrollView which then gets propagated to the SVG renderers.

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
SVGImage::draw() needs to pass the intersection of 'srcRect' and context->clipBounds(),
to ScrollView::paint(). This will ensure RenderSVGShape::paint() gets the correct
clipping rectangle. If there is no intersection between the boundingBox of the
RenderSVGShape and the clipping rectangle, the RenderSVGShape will not be drawn.

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/graphics/SVGImage.cpp


Added Paths

trunk/PerformanceTests/SVG/UnderTheSeeBenchmark.html
trunk/PerformanceTests/SVG/WorldcupBenchmark.html
trunk/PerformanceTests/SVG/resources/RenderAnimator.css
trunk/PerformanceTests/SVG/resources/RenderAnimator.js




Diff

Modified: trunk/PerformanceTests/ChangeLog (179334 => 179335)

--- trunk/PerformanceTests/ChangeLog	2015-01-29 04:45:39 UTC (rev 179334)
+++ trunk/PerformanceTests/ChangeLog	2015-01-29 05:23:28 UTC (rev 179335)
@@ -1,3 +1,17 @@
+2015-01-28  Said Abou-Hallawa  
+
+Poor performance on IE's Chalkboard benchmark.
+https://bugs.webkit.org/show_bug.cgi?id=140753.
+
+Reviewed by Zalan Bujtas.
+
+* SVG/UnderTheSeeBenchmark.html: Added
+* SVG/WorldcupBenchmark.html: Added.
+* SVG/resources/RenderAnimator.css: Added.
+* SVG/resources/RenderAnimator.js: Added.
+These are benchmarks for the SVG rendering. Mainly we want to measure how fast
+the SVG rendering will be when only a small part of it is drawn.
+
 2015-01-21  Geoffrey Garen  
 
 bmalloc: support aligned allocation


Added: trunk/PerformanceTests/SVG/UnderTheSeeBenchmark.html (0 => 179335)

--- trunk/PerformanceTests/SVG/UnderTheSeeBenchmark.html	(rev 0)
+++ trunk/PerformanceTests/SVG/UnderTheSeeBenchmark.html	2015-01-29 05:23:28 UTC (rev 179335)
@@ -0,0 +1,11 @@
+
+
+  
+
+  
+
+  
+


Added: trunk/PerformanceTests/SVG/WorldcupBenchmark.html (0 => 179335)

--- trunk/PerformanceTests/SVG/WorldcupBenchmark.html	(rev 0)
+++ trunk/PerformanceTests/SVG/WorldcupBenchmark.html	2015-01-29 05:23:28 UTC (rev 179335)
@@ -0,0 +1,11 @@
+
+
+  
+
+  
+
+  
+


Added: trunk/PerformanceTests/SVG/resources/RenderAnimator.css (0 => 179335)

--- trunk/PerformanceTests/SVG/resources/RenderAnimator.css	(rev 0)
+++ trunk/PerformanceTests/SVG/resources/RenderAnimator.css	2015-01-29 05:23:28 UTC (rev 179335)
@@ -0,0 +1,15 @@
+.Benchmark {
+position: fixed;
+visibility: hidden;
+transition: opacity 1.2s;
+}
+
+.Timer {
+position: absolute;
+right: 0px;
+bottom: 0px;
+margin: 0px 40px 14px 0px;
+font-family: Garamond;
+font-size: 18pt;
+transition: opacity 1.2s;
+}


Added: trunk/PerformanceTests/SVG/resources/RenderAnimator.js (0 => 179335)

--- trunk/PerformanceTests/SVG/resources/RenderAnimator.js	(rev 0)
+++ trunk/PerformanceTests/SVG/resources/RenderAnimator.js	2015-01-29 05:23:28 UTC (rev 179335)
@@ -0,0 +1,233 @@
+//
+// To use this script, the HTML has to have only one element and this element's className
+// should be equal to "Benchmark".
+//
+// This script forces rendering the HTML element many times by changing its position and its
+// size. The size can be very big to test the case of displaying only a small portion of the
+// element and measure how fast the display will be in this case.
+//
+
+function Point(x, y) {
+this.x = x;
+this.y = y;
+}
+
+Point.prototype = {
+scale : function(other) {
+return new Point(this.x * other.x, this.y * other.y);
+},
+add : function(other) {
+return new Point(this.x + other.x, this.y + other.y);
+},
+subtract : function(other) {
+return new Point(this.x - other.x, this.y - other.y);
+},
+isAlmostEqual : function(other, threshold) {
+return Mat

[webkit-changes] [179334] branches/safari-600.5-branch

[matthew_hanson]

Title: [179334] branches/safari-600.5-branch








Revision 179334
Author matthew_han...@apple.com
Date 2015-01-28 20:45:39 -0800 (Wed, 28 Jan 2015)


Log Message
Merge r179027. rdar://problem/19585744

Modified Paths

branches/safari-600.5-branch/LayoutTests/ChangeLog
branches/safari-600.5-branch/Source/WebCore/ChangeLog
branches/safari-600.5-branch/Source/WebCore/rendering/RenderView.cpp


Added Paths

branches/safari-600.5-branch/LayoutTests/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt
branches/safari-600.5-branch/LayoutTests/fast/multicol/pagination/LeftToRight-tb-hittest.html
branches/safari-600.5-branch/LayoutTests/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt
branches/safari-600.5-branch/LayoutTests/fast/multicol/pagination/RightToLeft-rl-hittest.html




Diff

Modified: branches/safari-600.5-branch/LayoutTests/ChangeLog (179333 => 179334)

--- branches/safari-600.5-branch/LayoutTests/ChangeLog	2015-01-29 04:45:34 UTC (rev 179333)
+++ branches/safari-600.5-branch/LayoutTests/ChangeLog	2015-01-29 04:45:39 UTC (rev 179334)
@@ -1,5 +1,22 @@
 2015-01-28  Matthew Hanson  
 
+Merge r179027. rdar://problem/19585744
+
+2015-01-23  Enrica Casucci  
+
+Hit test returns incorrect results when performed in paginated content over the page gaps.
+https://bugs.webkit.org/show_bug.cgi?id=140837
+rdar://problem/17494390
+
+Reviewed by Dave Hyatt.
+
+* fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
+* fast/multicol/pagination/LeftToRight-tb-hittest.html: Added.
+* fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
+* fast/multicol/pagination/RightToLeft-rl-hittest.html: Added.
+
+2015-01-28  Matthew Hanson  
+
 Merge r178953. rdar://problem/19617631
 
 2015-01-22  Joseph Pecoraro  


Added: branches/safari-600.5-branch/LayoutTests/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt (0 => 179334)

--- branches/safari-600.5-branch/LayoutTests/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt	(rev 0)
+++ branches/safari-600.5-branch/LayoutTests/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt	2015-01-29 04:45:39 UTC (rev 179334)
@@ -0,0 +1,132 @@
+layer at (0,0) size 2460x585
+  RenderView at (0,0) size 800x585
+RenderMultiColumnSet at (0,0) size 800x585
+layer at (0,0) size 385x3122 backgroundClip at (0,0) size 2460x585 clip at (0,0) size 2460x585 outlineClip at (0,0) size 2460x585
+  RenderMultiColumnFlowThread at (0,0) size 385x3122
+layer at (0,0) size 385x3122 backgroundClip at (0,0) size 2460x585 clip at (0,0) size 2460x585 outlineClip at (0,0) size 2460x585
+  RenderBlock {HTML} at (0,0) size 385x3122 [border: (1px solid #008000)]
+RenderBody {BODY} at (4,4) size 377x3114 [border: (1px solid #00)]
+  RenderBlock {P} at (1,25) size 375x364
+RenderText {#text} at (0,0) size 373x364
+  text run at (0,0) width 291: "1 Lorem ipsum dolor sit amet,"
+  text run at (0,28) width 332: "consectetur adipisicing elit, sed do"
+  text run at (0,56) width 373: "eiusmod tempor incididunt ut labore et"
+  text run at (0,84) width 315: "dolore magna aliqua. Ut enim ad"
+  text run at (0,112) width 270: "minim veniam, quis nostrud"
+  text run at (0,140) width 334: "exercitation ullamco laboris nisi ut"
+  text run at (0,168) width 333: "aliquip ex ea commodo consequat."
+  text run at (0,196) width 358: "Duis aute irure dolor in reprehenderit"
+  text run at (0,224) width 372: "in voluptate velit esse cillum dolore eu"
+  text run at (0,252) width 340: "fugiat nulla pariatur. Excepteur sint"
+  text run at (0,280) width 357: "occaecat cupidatat non proident, sunt"
+  text run at (0,308) width 332: "in culpa qui officia deserunt mollit"
+  text run at (0,336) width 198: "anim id est laborum."
+  RenderBlock {P} at (1,413) size 375x364
+RenderText {#text} at (0,0) size 373x364
+  text run at (0,0) width 291: "2 Lorem ipsum dolor sit amet,"
+  text run at (0,28) width 332: "consectetur adipisicing elit, sed do"
+  text run at (0,56) width 373: "eiusmod tempor incididunt ut labore et"
+  text run at (0,84) width 315: "dolore magna aliqua. Ut enim ad"
+  text run at (0,112) width 270: "minim veniam, quis nostrud"
+  text run at (0,140) width 334: "exercitation ullamco laboris nisi ut"
+  text run at (0,168) width 333: "aliquip ex ea commodo consequat."
+  text run at (0,196) width 358: "Duis aute irure dolor in reprehenderit"
+  text run at (0,224) width 372: "in voluptate velit esse cillum dolore eu"
+  text run at (0,252) width 340: "fugiat nulla pariatur. Excepteur sint"
+  text run at (0,280) width 357: "occaecat cupidatat non proident, sunt"
+  text run a

[webkit-changes] [179333] branches/safari-600.5-branch/LayoutTests

[matthew_hanson]

Title: [179333] branches/safari-600.5-branch/LayoutTests








Revision 179333
Author matthew_han...@apple.com
Date 2015-01-28 20:45:34 -0800 (Wed, 28 Jan 2015)


Log Message
Merge r178953. rdar://problem/19617631

Modified Paths

branches/safari-600.5-branch/LayoutTests/ChangeLog
branches/safari-600.5-branch/LayoutTests/TestExpectations




Diff

Modified: branches/safari-600.5-branch/LayoutTests/ChangeLog (179332 => 179333)

--- branches/safari-600.5-branch/LayoutTests/ChangeLog	2015-01-29 04:30:01 UTC (rev 179332)
+++ branches/safari-600.5-branch/LayoutTests/ChangeLog	2015-01-29 04:45:34 UTC (rev 179333)
@@ -1,5 +1,15 @@
 2015-01-28  Matthew Hanson  
 
+Merge r178953. rdar://problem/19617631
+
+2015-01-22  Joseph Pecoraro  
+
+Unreviewed, skip flakey inspector test.
+
+* TestExpectations:
+
+2015-01-28  Matthew Hanson  
+
 Merge r178795. rdar://problem/19617631
 
 2015-01-20  Joseph Pecoraro  


Modified: branches/safari-600.5-branch/LayoutTests/TestExpectations (179332 => 179333)

--- branches/safari-600.5-branch/LayoutTests/TestExpectations	2015-01-29 04:30:01 UTC (rev 179332)
+++ branches/safari-600.5-branch/LayoutTests/TestExpectations	2015-01-29 04:45:34 UTC (rev 179333)
@@ -98,6 +98,7 @@
 # Disabled the expectations because these tests are also skipped above.
 # webkit.org/b/129817 inspector/dom/content-flow-list.html [ Pass Failure ]
 # webkit.org/b/129817 inspector/dom/content-flow-content-removal.html [ Pass Failure ]
+inspector/model/remote-object-get-properties.html [ Skip ]
 
 # Collecting region's children in a named flow not supported yet
 webkit.org/b/74144 fast/regions/flow-body-in-html.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179331] branches/safari-600.5-branch

[matthew_hanson]

Title: [179331] branches/safari-600.5-branch








Revision 179331
Author matthew_han...@apple.com
Date 2015-01-28 20:29:59 -0800 (Wed, 28 Jan 2015)


Log Message
Merge r178768. rdar://problem/19617631

Modified Paths

branches/safari-600.5-branch/LayoutTests/ChangeLog
branches/safari-600.5-branch/Source/_javascript_Core/ChangeLog
branches/safari-600.5-branch/Source/_javascript_Core/inspector/InjectedScript.cpp
branches/safari-600.5-branch/Source/_javascript_Core/inspector/InjectedScript.h
branches/safari-600.5-branch/Source/_javascript_Core/inspector/InjectedScriptSource.js
branches/safari-600.5-branch/Source/_javascript_Core/inspector/agents/InspectorRuntimeAgent.cpp
branches/safari-600.5-branch/Source/_javascript_Core/inspector/agents/InspectorRuntimeAgent.h
branches/safari-600.5-branch/Source/_javascript_Core/inspector/protocol/Runtime.json
branches/safari-600.5-branch/Source/WebInspectorUI/ChangeLog
branches/safari-600.5-branch/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js
branches/safari-600.5-branch/Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js


Added Paths

branches/safari-600.5-branch/LayoutTests/inspector/model/
branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties-expected.txt
branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties.html




Diff

Modified: branches/safari-600.5-branch/LayoutTests/ChangeLog (179330 => 179331)

--- branches/safari-600.5-branch/LayoutTests/ChangeLog	2015-01-29 04:29:56 UTC (rev 179330)
+++ branches/safari-600.5-branch/LayoutTests/ChangeLog	2015-01-29 04:29:59 UTC (rev 179331)
@@ -1,3 +1,17 @@
+2015-01-28  Matthew Hanson  
+
+Merge r178768. rdar://problem/19617631
+
+2015-01-20  Joseph Pecoraro  
+
+Web Inspector: Expanding event objects in console shows undefined for most values, it should have real values
+https://bugs.webkit.org/show_bug.cgi?id=137306
+
+Reviewed by Timothy Hatcher.
+
+* inspector/model/remote-object-get-properties-expected.txt: Added.
+* inspector/model/remote-object-get-properties.html: Added.
+
 2015-01-28  Matthew  
 
 Merge r178363. rdar://problem/19617795


Added: branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (0 => 179331)

--- branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties-expected.txt	(rev 0)
+++ branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties-expected.txt	2015-01-29 04:29:59 UTC (rev 179331)
@@ -0,0 +1,186 @@
+
+-
+_expression_: window.simpleObject
+objectId: {"injectedScriptId":1,"id":1}
+type: object
+description: Object
+
+OWN PROPERTIES:
+a
+b
+__proto__
+
+OWN AND GETTER PROPERTIES:
+a
+b
+__proto__
+
+ALL PROPERTIES:
+a
+b
+toString
+toLocaleString
+valueOf
+hasOwnProperty
+propertyIsEnumerable
+isPrototypeOf
+__defineGetter__
+__defineSetter__
+__lookupGetter__
+__lookupSetter__
+constructor
+__proto__
+-
+
+-
+_expression_: window.loadEvent
+objectId: {"injectedScriptId":1,"id":16}
+type: object
+description: Event
+
+OWN PROPERTIES:
+clipboardData
+__proto__
+
+OWN AND GETTER PROPERTIES:
+clipboardData
+type
+target
+currentTarget
+eventPhase
+bubbles
+cancelable
+timeStamp
+defaultPrevented
+srcElement
+returnValue
+cancelBubble
+__proto__
+
+ALL PROPERTIES:
+clipboardData
+constructor
+type
+target
+currentTarget
+eventPhase
+bubbles
+cancelable
+timeStamp
+defaultPrevented
+srcElement
+returnValue
+cancelBubble
+NONE
+CAPTURING_PHASE
+AT_TARGET
+BUBBLING_PHASE
+MOUSEDOWN
+MOUSEUP
+MOUSEOVER
+MOUSEOUT
+MOUSEMOVE
+MOUSEDRAG
+CLICK
+DBLCLICK
+KEYDOWN
+KEYUP
+KEYPRESS
+DRAGDROP
+FOCUS
+BLUR
+SELECT
+CHANGE
+stopPropagation
+preventDefault
+initEvent
+stopImmediatePropagation
+toString
+toLocaleString
+valueOf
+hasOwnProperty
+propertyIsEnumerable
+isPrototypeOf
+__defineGetter__
+__defineSetter__
+__lookupGetter__
+__lookupSetter__
+__proto__
+-
+
+-
+_expression_: window.complexObject
+objectId: {"injectedScriptId":1,"id":41}
+type: object
+description: SuperFoo
+
+OWN PROPERTIES:
+_bar
+_foo
+__proto__
+
+OWN AND GETTER PROPERTIES:
+_bar
+_foo
+getterProperty
+foo
+bar
+__proto__
+
+ALL PROPERTIES:
+_bar
+_foo
+constructor
+get getterProperty
+set getterProperty

[webkit-changes] [179332] branches/safari-600.5-branch/LayoutTests

[matthew_hanson]

Title: [179332] branches/safari-600.5-branch/LayoutTests








Revision 179332
Author matthew_han...@apple.com
Date 2015-01-28 20:30:01 -0800 (Wed, 28 Jan 2015)


Log Message
Merge r178795. rdar://problem/19617631

Modified Paths

branches/safari-600.5-branch/LayoutTests/ChangeLog
branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties-expected.txt
branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties.html




Diff

Modified: branches/safari-600.5-branch/LayoutTests/ChangeLog (179331 => 179332)

--- branches/safari-600.5-branch/LayoutTests/ChangeLog	2015-01-29 04:29:59 UTC (rev 179331)
+++ branches/safari-600.5-branch/LayoutTests/ChangeLog	2015-01-29 04:30:01 UTC (rev 179332)
@@ -1,5 +1,16 @@
 2015-01-28  Matthew Hanson  
 
+Merge r178795. rdar://problem/19617631
+
+2015-01-20  Joseph Pecoraro  
+
+Unreviewed gardening. Remove variable objectId from output.
+
+* inspector/model/remote-object-get-properties-expected.txt:
+* inspector/model/remote-object-get-properties.html:
+
+2015-01-28  Matthew Hanson  
+
 Merge r178768. rdar://problem/19617631
 
 2015-01-20  Joseph Pecoraro  


Modified: branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (179331 => 179332)

--- branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties-expected.txt	2015-01-29 04:29:59 UTC (rev 179331)
+++ branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties-expected.txt	2015-01-29 04:30:01 UTC (rev 179332)
@@ -1,7 +1,6 @@
 
 -
 _expression_: window.simpleObject
-objectId: {"injectedScriptId":1,"id":1}
 type: object
 description: Object
 
@@ -34,7 +33,6 @@
 
 -
 _expression_: window.loadEvent
-objectId: {"injectedScriptId":1,"id":16}
 type: object
 description: Event
 
@@ -110,7 +108,6 @@
 
 -
 _expression_: window.complexObject
-objectId: {"injectedScriptId":1,"id":41}
 type: object
 description: SuperFoo
 
@@ -155,7 +152,6 @@
 
 -
 _expression_: window.badGetterObject
-objectId: {"injectedScriptId":1,"id":60}
 type: object
 description: ClassWithBadGetter
 


Modified: branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties.html (179331 => 179332)

--- branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties.html	2015-01-29 04:29:59 UTC (rev 179331)
+++ branches/safari-600.5-branch/LayoutTests/inspector/model/remote-object-get-properties.html	2015-01-29 04:30:01 UTC (rev 179332)
@@ -71,7 +71,6 @@
 
 WebInspector.runtimeManager.evaluateInInspectedWindow(step._expression_, "test", false, true, false, function(remoteObject, wasThrown) {
 InspectorTest.assert(remoteObject instanceof WebInspector.RemoteObject);
-InspectorTest.log("objectId: " + remoteObject.objectId);
 InspectorTest.log("type: " + remoteObject.type);
 if (remoteObject.subtype)
 InspectorTest.log("subtype: " + remoteObject.subtype);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179330] branches/safari-600.5-branch/Source/WebCore

[matthew_hanson]

Title: [179330] branches/safari-600.5-branch/Source/WebCore








Revision 179330
Author matthew_han...@apple.com
Date 2015-01-28 20:29:56 -0800 (Wed, 28 Jan 2015)


Log Message
Merge r178571. rdar://problem/19585723

Modified Paths

branches/safari-600.5-branch/Source/WebCore/ChangeLog
branches/safari-600.5-branch/Source/WebCore/html/HTMLElement.cpp




Diff

Modified: branches/safari-600.5-branch/Source/WebCore/ChangeLog (179329 => 179330)

--- branches/safari-600.5-branch/Source/WebCore/ChangeLog	2015-01-29 04:29:54 UTC (rev 179329)
+++ branches/safari-600.5-branch/Source/WebCore/ChangeLog	2015-01-29 04:29:56 UTC (rev 179330)
@@ -1,3 +1,26 @@
+2015-01-28  Matthew Hanson  
+
+Merge r178571. rdar://problem/19585723
+
+2015-01-15  Ryosuke Niwa  
+
+Removing an HTML element spends a lot of time in adjustDirectionalityIfNeededAfterChildrenChanged
+https://bugs.webkit.org/show_bug.cgi?id=140523
+
+
+Reviewed by Chris Dumez.
+
+The bug was caused by adjustDirectionalityIfNeededAfterChildrenChanged always traversing children to
+unset selfOrAncestorHasDirAutoAttribute flag while removing a child element.
+
+Fixed the bug by removing this code. This code was no-op prior to being refactored in r154957 since
+we only entered a for loop with the invariant "counter < childCountDelta" when "childCountDelta < 0".
+
+See http://trac.webkit.org/changeset/154957/trunk/Source/WebCore/html/HTMLElement.cpp.
+
+* html/HTMLElement.cpp:
+(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
+
 2015-01-28  Matthew  
 
 Merge r178363. rdar://problem/19617795


Modified: branches/safari-600.5-branch/Source/WebCore/html/HTMLElement.cpp (179329 => 179330)

--- branches/safari-600.5-branch/Source/WebCore/html/HTMLElement.cpp	2015-01-29 04:29:54 UTC (rev 179329)
+++ branches/safari-600.5-branch/Source/WebCore/html/HTMLElement.cpp	2015-01-29 04:29:56 UTC (rev 179330)
@@ -953,16 +953,7 @@
 void HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged(Element* beforeChange, ChildChangeType changeType)
 {
 // FIXME: This function looks suspicious.
-if (document().renderView() && (changeType == ElementRemoved || changeType == TextRemoved)) {
-Node* node = beforeChange ? beforeChange->nextSibling() : nullptr;
-for (; node; node = node->nextSibling()) {
-if (elementAffectsDirectionality(*node))
-continue;
 
-setHasDirAutoFlagRecursively(node, false);
-}
-}
-
 if (!selfOrAncestorHasDirAutoAttribute())
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179329] branches/safari-600.5-branch/Source/JavaScriptCore

[matthew_hanson]

Title: [179329] branches/safari-600.5-branch/Source/_javascript_Core








Revision 179329
Author matthew_han...@apple.com
Date 2015-01-28 20:29:54 -0800 (Wed, 28 Jan 2015)


Log Message
Merge r178365. rdar://problem/19617809

Modified Paths

branches/safari-600.5-branch/Source/_javascript_Core/ChangeLog
branches/safari-600.5-branch/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp




Diff

Modified: branches/safari-600.5-branch/Source/_javascript_Core/ChangeLog (179328 => 179329)

--- branches/safari-600.5-branch/Source/_javascript_Core/ChangeLog	2015-01-29 03:05:12 UTC (rev 179328)
+++ branches/safari-600.5-branch/Source/_javascript_Core/ChangeLog	2015-01-29 04:29:54 UTC (rev 179329)
@@ -1,5 +1,45 @@
 2015-01-28  Matthew  
 
+Merge r178365. rdar://problem/19617809
+
+2015-01-13  Geoffrey Garen  
+
+Out of bounds access in BytecodeGenerator::emitGetById under DotAccessorNode::emitBytecode
+https://bugs.webkit.org/show_bug.cgi?id=140397
+
+Reviewed by Geoffrey Garen.
+
+Patch by Alexey Proskuryakov.
+
+Reviewed, performance tested, and ChangeLogged by Geoffrey Garen.
+
+No performance change.
+
+No test, since this is a small past-the-end read, which is very
+difficult to turn into a reproducible failing test -- and existing tests
+crash reliably using ASan.
+
+* bytecompiler/NodesCodegen.cpp:
+(JSC::BracketAccessorNode::emitBytecode):
+(JSC::DotAccessorNode::emitBytecode):
+(JSC::FunctionCallBracketNode::emitBytecode):
+(JSC::PostfixNode::emitResolve):
+(JSC::DeleteBracketNode::emitBytecode):
+(JSC::DeleteDotNode::emitBytecode):
+(JSC::PrefixNode::emitResolve):
+(JSC::UnaryOpNode::emitBytecode):
+(JSC::BitwiseNotNode::emitBytecode):
+(JSC::BinaryOpNode::emitBytecode):
+(JSC::EqualNode::emitBytecode):
+(JSC::StrictEqualNode::emitBytecode):
+(JSC::ThrowableBinaryOpNode::emitBytecode):
+(JSC::AssignDotNode::emitBytecode):
+(JSC::AssignBracketNode::emitBytecode): Use RefPtr in more places. Any
+register used across a call to a function that might allocate a new
+temporary register must be held in a RefPtr.
+
+2015-01-28  Matthew  
+
 Merge r178311. rdar://problem/19617780
 
 2015-01-12  Geoffrey Garen  


Modified: branches/safari-600.5-branch/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (179328 => 179329)

--- branches/safari-600.5-branch/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp	2015-01-29 03:05:12 UTC (rev 179328)
+++ branches/safari-600.5-branch/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp	2015-01-29 04:29:54 UTC (rev 179329)
@@ -366,9 +366,9 @@
 if (m_base->isResolveNode() 
 && generator.willResolveToArguments(static_cast(m_base)->identifier())
 && !generator.symbolTable().slowArguments()) {
-RegisterID* property = generator.emitNode(m_subscript);
+RefPtr property = generator.emitNode(m_subscript);
 generator.emitExpressionInfo(divot(), divotStart(), divotEnd());
-return generator.emitGetArgumentByVal(generator.finalDestination(dst), generator.uncheckedRegisterForArguments(), property);
+return generator.emitGetArgumentByVal(generator.finalDestination(dst), generator.uncheckedRegisterForArguments(), property.get());
 }
 
 RefPtr base = generator.emitNodeForLeftHandSide(m_base, m_subscriptHasAssignments, m_subscript->isPure(generator));
@@ -392,9 +392,9 @@
 }
 
 nonArgumentsPath:
-RegisterID* base = generator.emitNode(m_base);
+RefPtr base = generator.emitNode(m_base);
 generator.emitExpressionInfo(divot(), divotStart(), divotEnd());
-return generator.emitGetById(generator.finalDestination(dst), base, m_ident);
+return generator.emitGetById(generator.finalDestination(dst), base.get(), m_ident);
 }
 
 // -- ArgumentListNode -
@@ -508,9 +508,9 @@
 RegisterID* FunctionCallBracketNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
 {
 RefPtr base = generator.emitNode(m_base);
-RegisterID* property = generator.emitNode(m_subscript);
+RefPtr property = generator.emitNode(m_subscript);
 generator.emitExpressionInfo(subexpressionDivot(), subexpressionStart(), subexpressionEnd());
-RefPtr function = generator.emitGetByVal(generator.tempDestination(dst), base.get(), property);
+RefPtr function = generator.emitGetByVal(generator.tempDestination(dst), base.get(), property.get());
 RefPtr returnValue = generator.finalDestination(dst, function.get());
 CallArguments callArguments(generator, m_args);
 generator.emitMove(callArguments.thisRegister(), base.get());
@@ -736,21 +736,21 @@
 const Identifier& ident = resolve->identifier();
 
 if (

[webkit-changes] [179325] trunk/Source/WTF

[commit-queue]

Title: [179325] trunk/Source/WTF








Revision 179325
Author commit-qu...@webkit.org
Date 2015-01-28 18:32:19 -0800 (Wed, 28 Jan 2015)


Log Message
Windows return -1 when calling vsnprintf with arguments that exceed target buffer size
https://bugs.webkit.org/show_bug.cgi?id=140917

Patch by Namhoon Kim  on 2015-01-28
Reviewed by Brent Fulgham.

Fix return value of vsnprintf when windows API return -1 to denote
requested buffer exceeded. Replace return value by calling vscprintf.

* wtf/StringExtras.h:
(snprintf): Fix return value by calling vscprintf when buffer exceeded.
(wtf_vsnprintf): Ditto.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/StringExtras.h




Diff

Modified: trunk/Source/WTF/ChangeLog (179324 => 179325)

--- trunk/Source/WTF/ChangeLog	2015-01-29 02:15:47 UTC (rev 179324)
+++ trunk/Source/WTF/ChangeLog	2015-01-29 02:32:19 UTC (rev 179325)
@@ -1,3 +1,17 @@
+2015-01-28  Namhoon Kim  
+
+Windows return -1 when calling vsnprintf with arguments that exceed target buffer size
+https://bugs.webkit.org/show_bug.cgi?id=140917
+
+Reviewed by Brent Fulgham.
+
+Fix return value of vsnprintf when windows API return -1 to denote
+requested buffer exceeded. Replace return value by calling vscprintf.
+
+* wtf/StringExtras.h:
+(snprintf): Fix return value by calling vscprintf when buffer exceeded.
+(wtf_vsnprintf): Ditto.
+
 2015-01-28  Geoffrey Garen  
 
 Removed fastMallocForbid / fastMallocAllow


Modified: trunk/Source/WTF/wtf/StringExtras.h (179324 => 179325)

--- trunk/Source/WTF/wtf/StringExtras.h	2015-01-29 02:15:47 UTC (rev 179324)
+++ trunk/Source/WTF/wtf/StringExtras.h	2015-01-29 02:32:19 UTC (rev 179325)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2015 Electronic Arts, Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -37,12 +38,16 @@
 #if COMPILER(MSVC)
 // FIXME: why a COMPILER check instead of OS? also, these should be HAVE checks
 
+#include 
+
 inline int snprintf(char* buffer, size_t count, const char* format, ...) 
 {
 int result;
 va_list args;
 va_start(args, format);
 result = _vsnprintf(buffer, count, format, args);
+if (result < 0 && errno != EINVAL)
+result = _vscprintf(format, args);
 va_end(args);
 
 // In the case where the string entirely filled the buffer, _vsnprintf will not
@@ -56,6 +61,8 @@
 inline double wtf_vsnprintf(char* buffer, size_t count, const char* format, va_list args)
 {
 int result = _vsnprintf(buffer, count, format, args);
+if (result < 0 && errno != EINVAL)
+result = _vscprintf(format, args);
 
 // In the case where the string entirely filled the buffer, _vsnprintf will not
 // null-terminate it, but vsnprintf must.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179327] trunk/Source/WebKit2

[antti]

Title: [179327] trunk/Source/WebKit2








Revision 179327
Author an...@apple.com
Date 2015-01-28 18:52:30 -0800 (Wed, 28 Jan 2015)


Log Message
http/tests/xmlhttprequest/workers/methods.html sometimes times out with disk cache enabled
https://bugs.webkit.org/show_bug.cgi?id=140976

Reviewed by Chris Dumez.

The previous fix sometimes invoked the completion handler twice. Explicitly track if we
have called it or not.

* NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::dispatchRetrieveOperation):

Also move the error case to the done branch. According to the documentation 'done' is always set on error.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (179326 => 179327)

--- trunk/Source/WebKit2/ChangeLog	2015-01-29 02:32:24 UTC (rev 179326)
+++ trunk/Source/WebKit2/ChangeLog	2015-01-29 02:52:30 UTC (rev 179327)
@@ -1,3 +1,18 @@
+2015-01-28  Antti Koivisto  
+
+http/tests/xmlhttprequest/workers/methods.html sometimes times out with disk cache enabled
+https://bugs.webkit.org/show_bug.cgi?id=140976
+
+Reviewed by Chris Dumez.
+
+The previous fix sometimes invoked the completion handler twice. Explicitly track if we
+have called it or not.
+
+* NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
+(WebKit::NetworkCacheStorage::dispatchRetrieveOperation):
+
+Also move the error case to the done branch. According to the documentation 'done' is always set on error.
+
 2015-01-28  Timothy Horton  
 
 Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace


Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm (179326 => 179327)

--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm	2015-01-29 02:32:24 UTC (rev 179326)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm	2015-01-29 02:52:30 UTC (rev 179327)
@@ -362,25 +362,25 @@
 int fd;
 auto channel = createIOChannelForKey(retrieve.key, IOChannelType::Read, cachePathCapture.string(), fd);
 
-dispatch_io_read(channel.get(), 0, std::numeric_limits::max(), dispatch_get_main_queue(), [this, fd, retrieve](bool done, dispatch_data_t fileData, int error) {
+bool didCallCompletionHandler = false;
+dispatch_io_read(channel.get(), 0, std::numeric_limits::max(), dispatch_get_main_queue(), [this, fd, retrieve, didCallCompletionHandler](bool done, dispatch_data_t fileData, int error) mutable {
 if (done) {
 ASSERT(m_activeRetrieveOperationCount);
 --m_activeRetrieveOperationCount;
 dispatchPendingRetrieveOperations();
 }
-if (error) {
-retrieve.completionHandler(nullptr);
-removeEntry(retrieve.key);
-return;
-}
 if (done) {
-// File exists but is empty. Invoke the completion handler as it hasn't been done yet.
-if (fileData == dispatch_data_empty)
+if (!didCallCompletionHandler)
 retrieve.completionHandler(nullptr);
+if (error)
+removeEntry(retrieve.key);
 return;
 }
+ASSERT(!didCallCompletionHandler); // We are requesting maximum sized chunk so we should never get called more than once with data.
+
 auto entry = decodeEntry(fileData, fd, retrieve.key);
 bool success = retrieve.completionHandler(WTF::move(entry));
+didCallCompletionHandler = true;
 if (!success)
 removeEntry(retrieve.key);
 });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179328] trunk/Source/WebKit2

[timothy_horton]

Title: [179328] trunk/Source/WebKit2








Revision 179328
Author timothy_hor...@apple.com
Date 2015-01-28 19:05:12 -0800 (Wed, 28 Jan 2015)


Log Message
Add API::{FrameInfo, NavigationAction, NavigationResponse} types
https://bugs.webkit.org/show_bug.cgi?id=140982

Reviewed by Sam Weinig.

Make C++ API objects for WK{FrameInfo, NavigationAction, NavigationResponse}
to wrap around, as a step towards moving Modern API logic down into WebPageProxy.

* Shared/API/APIObject.h:
* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
* UIProcess/API/APIFrameInfo.cpp: Added.
* UIProcess/API/APIFrameInfo.h: Added.
* UIProcess/API/APINavigationAction.h: Added.
* UIProcess/API/APINavigationResponse.h: Added.
Add API::FrameInfo, API::NavigationAction, and API::NavigationResponse.

* UIProcess/API/Cocoa/WKFrameInfo.mm:
* UIProcess/API/Cocoa/WKFrameInfoInternal.h:
Make WKFrameInfo a WKObject, wrapping a API::FrameInfo.

* UIProcess/API/Cocoa/WKNavigationAction.mm:
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
Make WKNavigationAction a WKObject, wrapping a API::NavigationAction.

* UIProcess/API/Cocoa/WKNavigationResponse.mm:
* UIProcess/API/Cocoa/WKNavigationResponseInternal.h:
Make WKNavigationResponse a WKObject, wrapping a API::NavigationResponse.

* UIProcess/API/Cocoa/WKUserContentController.mm:
Adopt API::FrameInfo.

* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
Adopt API::FrameInfo, and reorganize the code slightly.
Adopt API::NavigationAction.

(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):
Adopt API::FrameInfo.
Adopt API::NavigationResponse.

(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
Adopt API::FrameInfo.

* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
(WebKit::UIDelegate::UIClient::runJavaScriptAlert):
(WebKit::UIDelegate::UIClient::runJavaScriptConfirm):
(WebKit::UIDelegate::UIClient::runJavaScriptPrompt):
Adopt API::FrameInfo.

* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/APIObject.h
trunk/Source/WebKit2/Shared/Cocoa/APIObject.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationResponse.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationResponseInternal.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm
trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/UIProcess/API/APIFrameInfo.cpp
trunk/Source/WebKit2/UIProcess/API/APIFrameInfo.h
trunk/Source/WebKit2/UIProcess/API/APINavigationAction.h
trunk/Source/WebKit2/UIProcess/API/APINavigationResponse.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (179327 => 179328)

--- trunk/Source/WebKit2/ChangeLog	2015-01-29 02:52:30 UTC (rev 179327)
+++ trunk/Source/WebKit2/ChangeLog	2015-01-29 03:05:12 UTC (rev 179328)
@@ -1,3 +1,58 @@
+2015-01-28  Tim Horton  
+
+Add API::{FrameInfo, NavigationAction, NavigationResponse} types
+https://bugs.webkit.org/show_bug.cgi?id=140982
+
+Reviewed by Sam Weinig.
+
+Make C++ API objects for WK{FrameInfo, NavigationAction, NavigationResponse}
+to wrap around, as a step towards moving Modern API logic down into WebPageProxy.
+
+* Shared/API/APIObject.h:
+* Shared/Cocoa/APIObject.mm:
+(API::Object::newObject):
+* UIProcess/API/APIFrameInfo.cpp: Added.
+* UIProcess/API/APIFrameInfo.h: Added.
+* UIProcess/API/APINavigationAction.h: Added.
+* UIProcess/API/APINavigationResponse.h: Added.
+Add API::FrameInfo, API::NavigationAction, and API::NavigationResponse.
+
+* UIProcess/API/Cocoa/WKFrameInfo.mm:
+* UIProcess/API/Cocoa/WKFrameInfoInternal.h:
+Make WKFrameInfo a WKObject, wrapping a API::FrameInfo.
+
+* UIProcess/API/Cocoa/WKNavigationAction.mm:
+* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
+Make WKNavigationAction a WKObject, wrapping a API::NavigationAction.
+
+* UIProcess/API/Cocoa/WKNavigationResponse.mm:
+* UIProcess/API/Cocoa/WKNavigationResponseInternal.h:
+Make WKNavigationResponse a WKObject, wrapping a API::NavigationResponse.
+
+* UIProcess/API/Cocoa/WKUserContentController.mm:
+Adopt API::FrameInfo.
+
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
+Adopt API::FrameInfo, and reorganize the code slightly.
+Adopt API::NavigationAction.
+
+(WebKit::NavigationState::PolicyCli

[webkit-changes] [179326] trunk

[timothy_horton]

Title: [179326] trunk








Revision 179326
Author timothy_hor...@apple.com
Date 2015-01-28 18:32:24 -0800 (Wed, 28 Jan 2015)


Log Message
Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
https://bugs.webkit.org/show_bug.cgi?id=140673

Reviewed by Sam Weinig.

* Platform/IPC/ArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* Platform/IPC/ArgumentCoders.h:
Add a uuid_t (simple) argument coder.
Fix a mis-named header-guard #ifdef.

* Platform/IPC/Connection.cpp:
(IPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(IPC::Connection::dispatchSyncMessage):
Sync message replies inherit the message UUID from the incoming sync message.

(IPC::Connection::sendMessage):
(IPC::Connection::waitForMessage):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
Record outgoing messages. Because sendSyncMessage calls sendMessage,
we have to explicitly avoid recording the message twice.

(IPC::Connection::dispatchMessage):
Record the incoming message.

(IPC::Connection::remoteProcessID):
Add remoteProcessID(), which tries to determine the pid of the remote process.

* Platform/IPC/Connection.h:
(IPC::Connection::xpcConnection):
This can be const.

(IPC::Connection::isValid):
Make this public.

* Platform/IPC/MessageDecoder.cpp:
(IPC::MessageDecoder::MessageDecoder):
* Platform/IPC/MessageDecoder.h:
(IPC::MessageDecoder::setMessageProcessingToken):
(IPC::MessageDecoder::UUID):
Decode and store the message UUID.
Store a MessageProcessingToken for the lifetime of the MessageDecoder;
this ensures that all time spent processing the incoming message will be
counted against that message.

* Platform/IPC/MessageEncoder.cpp:
(IPC::MessageEncoder::MessageEncoder):
By default, create a new UUID for the message. Alternatively, allow clients
to pass the message UUID in (used for sync message replies).
Store the messageReceiverName and messageName.

(IPC::MessageEncoder::encodeHeader):
Factor encodeHeader() out of the constructors so most of their code can be shared.

(IPC::MessageEncoder::isSyncMessage):
(IPC::MessageEncoder::shouldDispatchMessageWhenWaitingForSyncReply):
Add getters for these flags.

* Platform/IPC/MessageEncoder.h:
(IPC::MessageEncoder::messageReceiverName):
(IPC::MessageEncoder::messageName):
(IPC::MessageEncoder::destinationID):
(IPC::MessageEncoder::UUID):

* Platform/IPC/MessageRecorder.h: Added.
* Platform/IPC/MessageRecorder.cpp: Added.
(MessageRecorder::MessageRecorder):
Add a class that interfaces with a custom DTrace provider to log incoming and outgoing messages.

(MessageRecorder::shared):
(MessageRecorder::isEnabled):
Determine if either of the message probes are enabled. If not, we'll avoid most of the
work associated with MessageRecorder.

(MessageRecorder::recordOutgoingMessage):
(MessageRecorder::recordIncomingMessage):
Build a WebKitMessageRecord and MessageProcessingToken from the Message(De|En)coder.
Once the MessageProcessingToken is deallocated, the probe will be invoked with the WebKitMessageRecord.

(MessageRecorder::MessageProcessingToken::MessageProcessingToken):
(MessageRecorder::MessageProcessingToken::~MessageProcessingToken):
Keep track of when the token is created and destroyed; these are considered the beginning
and ending "processing" times of the message (and as such the token should be kept alive for
exactly as long as the message is being processed).

* Platform/IPC/MessageRecorderProbes.d: Added.
Add a DTrace provider source file with two probes, message_sent and message_received.
The struct must match the struct in MessageRecorder.h.

* Platform/IPC/ProcessType.h: Added.
Add an enum of process types.

* WebKit2.xcodeproj/project.pbxproj:

* DatabaseProcess/DatabaseProcess.h:
* DatabaseProcess/DatabaseToWebProcessConnection.h:
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkProcess.h:
* WebProcess/Databases/WebToDatabaseProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Plugins/PluginProcessConnection.h:
* WebProcess/WebPage/WebInspector.h:
* WebProcess/WebPage/WebInspectorUI.h:
* WebProcess/WebProcess.h:
* UIProcess/Databases/DatabaseProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/WebProcessProxy.h:
* PluginProcess/PluginProcess.h:
* PluginProcess/WebProcessConnection.h:
Annotate Connection::Clients with process types.

* Scripts/dtrace/trace-webkit2-messages.d: Added.
Add a DTrace script that outputs a small blob of JSON per message.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.h
trunk/Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.h
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit2/Platform/IPC/ArgumentCoders.cpp
trunk/Source/WebKit2/Platform/IPC/ArgumentCoders.h
trunk/Source/WebKit2/Platform/I

[webkit-changes] [179324] trunk/Source/WebCore

[bfulgham]

Title: [179324] trunk/Source/WebCore








Revision 179324
Author bfulg...@apple.com
Date 2015-01-28 18:15:47 -0800 (Wed, 28 Jan 2015)


Log Message
Scroll snap points do not work in the vertical direction
https://bugs.webkit.org/show_bug.cgi?id=141001


Reviewed by Beth Dakin.

New scroll snap tests are being prepared separately. A manual test case is attached to the issue.

* page/EventHandler.cpp:
(WebCore::handleWheelEventInAppropriateEnclosingBoxForSingleAxis): We want to consider momentum end phase
when dealing with Scroll Snap Points.
* platform/mac/AxisScrollSnapAnimator.mm:
(WebCore::AxisScrollSnapAnimator::handleWheelEvent): We do NOT want to bail out early here. In fact, it's strange
that this code was like this at all, since it meant a large number of cases were not being used. We also want to
trigger the scroll snap animation (when applicable) upon an inertia scroll end.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::gestureShouldBeginSnap): Added.
(WebCore::ScrollAnimatorMac::allowsVerticalStretching): If we have automatic elasticity, and we have active scroll
snap points, we want to let the scroll snap animator deal with the gesture.
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.mm
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (179323 => 179324)

--- trunk/Source/WebCore/ChangeLog	2015-01-29 02:05:10 UTC (rev 179323)
+++ trunk/Source/WebCore/ChangeLog	2015-01-29 02:15:47 UTC (rev 179324)
@@ -1,3 +1,26 @@
+2015-01-28  Brent Fulgham  
+
+Scroll snap points do not work in the vertical direction
+https://bugs.webkit.org/show_bug.cgi?id=141001
+
+
+Reviewed by Beth Dakin.
+
+New scroll snap tests are being prepared separately. A manual test case is attached to the issue.
+
+* page/EventHandler.cpp:
+(WebCore::handleWheelEventInAppropriateEnclosingBoxForSingleAxis): We want to consider momentum end phase
+when dealing with Scroll Snap Points.
+* platform/mac/AxisScrollSnapAnimator.mm:
+(WebCore::AxisScrollSnapAnimator::handleWheelEvent): We do NOT want to bail out early here. In fact, it's strange
+that this code was like this at all, since it meant a large number of cases were not being used. We also want to
+trigger the scroll snap animation (when applicable) upon an inertia scroll end.
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::gestureShouldBeginSnap): Added.
+(WebCore::ScrollAnimatorMac::allowsVerticalStretching): If we have automatic elasticity, and we have active scroll
+snap points, we want to let the scroll snap animator deal with the gesture.
+(WebCore::ScrollAnimatorMac::allowsHorizontalStretching): Ditto.
+
 2015-01-28  Benjamin Poulain  
 
 Start fixing the handling of Element's attributes when they contain non-ASCII characters


Modified: trunk/Source/WebCore/page/EventHandler.cpp (179323 => 179324)

--- trunk/Source/WebCore/page/EventHandler.cpp	2015-01-29 02:05:10 UTC (rev 179323)
+++ trunk/Source/WebCore/page/EventHandler.cpp	2015-01-29 02:15:47 UTC (rev 179324)
@@ -302,7 +302,10 @@
 bool shouldHandleEvent = (axis == ScrollEventAxis::Vertical && wheelEvent->deltaY()) || (axis == ScrollEventAxis::Horizontal && wheelEvent->deltaX());
 #if PLATFORM(MAC)
 shouldHandleEvent |= wheelEvent->phase() == PlatformWheelEventPhaseEnded;
+#if ENABLE(CSS_SCROLL_SNAP)
+shouldHandleEvent |= wheelEvent->momentumPhase() == PlatformWheelEventPhaseEnded;
 #endif
+#endif
 if (!startNode->renderer() || !shouldHandleEvent)
 return false;
 


Modified: trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.mm (179323 => 179324)

--- trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.mm	2015-01-29 02:05:10 UTC (rev 179323)
+++ trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.mm	2015-01-29 02:15:47 UTC (rev 179324)
@@ -102,8 +102,6 @@
 {
 float wheelDelta = m_axis == ScrollEventAxis::Horizontal ? -event.deltaX() : -event.deltaY();
 WheelEventStatus wheelStatus = toWheelEventStatus(event.phase(), event.momentumPhase());
-if ((wheelStatus == WheelEventStatus::UserScrolling || wheelStatus == WheelEventStatus::InertialScrolling || wheelStatus == WheelEventStatus::InertialScrollBegin) && !wheelDelta)
-return;
 
 switch (wheelStatus) {
 case WheelEventStatus::UserScrollBegin:
@@ -134,6 +132,7 @@
 break;
 
 case WheelEventStatus::InertialScrollEnd:
+beginScrollSnapAnimation(ScrollSnapState::Snapping);
 clearInitialWheelDeltaWindow();
 m_shouldOverrideWheelEvent = false;
 break;


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (179323 => 179324)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2015-01-29 0

[webkit-changes] [179323] trunk

[benjamin]

Title: [179323] trunk








Revision 179323
Author benja...@webkit.org
Date 2015-01-28 18:05:10 -0800 (Wed, 28 Jan 2015)


Log Message
Start fixing the handling of Element's attributes when they contain non-ASCII characters
https://bugs.webkit.org/show_bug.cgi?id=141016

Patch by Benjamin Poulain  on 2015-01-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

Attribute handling does not work properly when the attribute name contains non-ASCII character.

The HTML parser tokenize those names as ASCII lowercase. Some of the code is CSS and Element use
unicode lowercase for the names. This breaks all the APIs as soon as a name contains a character
that is non-ASCII and uppercase since some APIs change it, other don't.

This patch is a first step toward fixing this mess, it only address the simple cases.
The HTML spec says the names should be compared ASCII case-insensitive, to I spread that behavior
to places that were using unicode.

Tests: fast/css/attribute-ascii-case-insensitive-html.html
   fast/css/attribute-ascii-case-insensitive-xhtml-expected.xhtml
   fast/css/attribute-ascii-case-insensitive-xhtml.xhtml
   fast/css/attribute-ascii-case-insensitive-xml-in-html.html
   fast/dom/Element/attribute-ascii-case-insensitive-1.html
   fast/dom/Element/attribute-ascii-case-insensitive-2.html
   fast/selectors/attribute-ascii-case-insensitive-style-update.html
   fast/selectors/element-matches-attribute-ascii-case-insensitive-html.html
   fast/selectors/querySelector-attribute-ascii-case-insensitive-html.html

* css/CSSSelector.cpp:
(WebCore::CSSSelector::setAttribute):
* dom/Element.cpp:
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::hasAttribute):
* dom/ElementData.cpp:
(WebCore::ElementData::findAttributeIndexByNameSlowCase):
* dom/ElementData.h:
(WebCore::ElementData::findAttributeIndexByName):

LayoutTests:

Start some basic testing.

Some tests are failing due to the more complicated case being handled incorrectly, this will
be fixed in follow ups.

* fast/css/attribute-ascii-case-insensitive-html-expected.html: Added.
* fast/css/attribute-ascii-case-insensitive-html.html: Added.
* fast/css/attribute-ascii-case-insensitive-xhtml-expected.xhtml: Added.
* fast/css/attribute-ascii-case-insensitive-xhtml.xhtml: Added.
* fast/css/attribute-ascii-case-insensitive-xml-in-html-expected.html: Added.
* fast/css/attribute-ascii-case-insensitive-xml-in-html.html: Added.
* fast/dom/Element/attribute-ascii-case-insensitive-1-expected.txt: Added.
* fast/dom/Element/attribute-ascii-case-insensitive-1.html: Added.
* fast/dom/Element/attribute-ascii-case-insensitive-2-expected.txt: Added.
* fast/dom/Element/attribute-ascii-case-insensitive-2.html: Added.
* fast/selectors/attribute-ascii-case-insensitive-style-update-expected.txt: Added.
* fast/selectors/attribute-ascii-case-insensitive-style-update.html: Added.
* fast/selectors/element-matches-attribute-ascii-case-insensitive-html-expected.txt: Added.
* fast/selectors/element-matches-attribute-ascii-case-insensitive-html.html: Added.
* fast/selectors/querySelector-attribute-ascii-case-insensitive-html-expected.txt: Added.
* fast/selectors/querySelector-attribute-ascii-case-insensitive-html.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSSelector.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/ElementData.cpp
trunk/Source/WebCore/dom/ElementData.h


Added Paths

trunk/LayoutTests/fast/css/attribute-ascii-case-insensitive-html-expected.html
trunk/LayoutTests/fast/css/attribute-ascii-case-insensitive-html.html
trunk/LayoutTests/fast/css/attribute-ascii-case-insensitive-xhtml-expected.xhtml
trunk/LayoutTests/fast/css/attribute-ascii-case-insensitive-xhtml.xhtml
trunk/LayoutTests/fast/css/attribute-ascii-case-insensitive-xml-in-html-expected.html
trunk/LayoutTests/fast/css/attribute-ascii-case-insensitive-xml-in-html.html
trunk/LayoutTests/fast/dom/Element/attribute-ascii-case-insensitive-1-expected.txt
trunk/LayoutTests/fast/dom/Element/attribute-ascii-case-insensitive-1.html
trunk/LayoutTests/fast/dom/Element/attribute-ascii-case-insensitive-2-expected.txt
trunk/LayoutTests/fast/dom/Element/attribute-ascii-case-insensitive-2.html
trunk/LayoutTests/fast/selectors/attribute-ascii-case-insensitive-style-update-expected.txt
trunk/LayoutTests/fast/selectors/attribute-ascii-case-insensitive-style-update.html
trunk/LayoutTests/fast/selectors/element-matches-attribute-ascii-case-insensitive-html-expected.txt
trunk/LayoutTests/fast/selectors/element-matches-attribute-ascii-case-insensitive-html.html
trunk/LayoutTests/fast/selectors/querySelector-attribute-ascii-case-insensitive-html-expected.txt
trunk/LayoutTests/fast/selectors/querySelector-attribute-ascii-case-insensitive-html.html




Diff

Modified: trunk/LayoutTests/ChangeLog (179322 => 179323)

--- trunk/LayoutTests/ChangeLog	2015

[webkit-changes] [179322] trunk/Source/WebInspectorUI

[joepeck]

Title: [179322] trunk/Source/WebInspectorUI








Revision 179322
Author joep...@webkit.org
Date 2015-01-28 18:01:17 -0800 (Wed, 28 Jan 2015)


Log Message
Web Inspector: Change Main Frame Status Buttons when debugging Augmented JSContext
https://bugs.webkit.org/show_bug.cgi?id=141006

Reviewed by Timothy Hatcher.

* Localizations/en.lproj/localizedStrings.js:
New "Restart" string.

* UserInterface/Base/Main.js:
(WebInspector.canArchiveMainFrame):
* UserInterface/Views/FrameTreeElement.js:
(WebInspector.FrameTreeElement.prototype.updateStatusForMainFrame):
(WebInspector.FrameTreeElement.prototype._updateDownloadButton):
Update the tooltip when in a non-Web debuggable, and only show
the Download button when in a Web debuggable.

* UserInterface/Views/TreeElementStatusButton.js:
(WebInspector.TreeElementStatusButton.prototype.set hidden):
Oops! The implementation was backwards. Simplify with classList.toggle.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/FrameTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/TreeElementStatusButton.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (179321 => 179322)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-01-29 01:49:21 UTC (rev 179321)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-01-29 02:01:17 UTC (rev 179322)
@@ -1,3 +1,25 @@
+2015-01-28  Joseph Pecoraro  
+
+Web Inspector: Change Main Frame Status Buttons when debugging Augmented JSContext
+https://bugs.webkit.org/show_bug.cgi?id=141006
+
+Reviewed by Timothy Hatcher.
+
+* Localizations/en.lproj/localizedStrings.js:
+New "Restart" string.
+
+* UserInterface/Base/Main.js:
+(WebInspector.canArchiveMainFrame):
+* UserInterface/Views/FrameTreeElement.js:
+(WebInspector.FrameTreeElement.prototype.updateStatusForMainFrame):
+(WebInspector.FrameTreeElement.prototype._updateDownloadButton):
+Update the tooltip when in a non-Web debuggable, and only show
+the Download button when in a Web debuggable.
+
+* UserInterface/Views/TreeElementStatusButton.js:
+(WebInspector.TreeElementStatusButton.prototype.set hidden):
+Oops! The implementation was backwards. Simplify with classList.toggle.
+
 2015-01-28  Brian J. Burg  
 
 Web Inspector: remove CSS.setPropertyText, CSS.toggleProperty and related dead code


Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (179321 => 179322)

--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2015-01-29 01:49:21 UTC (rev 179321)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2015-01-29 02:01:17 UTC (rev 179322)
@@ -370,6 +370,7 @@
 localizedStrings["Resources"] = "Resources";
 localizedStrings["Response"] = "Response";
 localizedStrings["Response Headers"] = "Response Headers";
+localizedStrings["Restart (%s)"] = "Restart (%s)";
 localizedStrings["Return type for anonymous function"] = "Return type for anonymous function";
 localizedStrings["Return type for function: %s"] = "Return type for function: %s";
 localizedStrings["Reveal in DOM Tree"] = "Reveal in DOM Tree";


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (179321 => 179322)

--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-01-29 01:49:21 UTC (rev 179321)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-01-29 02:01:17 UTC (rev 179322)
@@ -1886,7 +1886,7 @@
 
 WebInspector.canArchiveMainFrame = function()
 {
-if (!PageAgent.archive)
+if (!PageAgent.archive || this.debuggableType !== WebInspector.DebuggableType.Web)
 return false;
 
 return WebInspector.Resource.typeFromMIMEType(WebInspector.frameResourceManager.mainFrame.mainResource.mimeType) === WebInspector.Resource.Type.Document;


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FrameTreeElement.js (179321 => 179322)

--- trunk/Source/WebInspectorUI/UserInterface/Views/FrameTreeElement.js	2015-01-29 01:49:21 UTC (rev 179321)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FrameTreeElement.js	2015-01-29 02:01:17 UTC (rev 179322)
@@ -202,7 +202,12 @@
 if (!this._loadingMainFrameButtons) {
 this._loadingMainFrameButtons = true;
 
-var tooltip = WebInspector.UIString("Reload page (%s)\nReload ignoring cache (%s)").format(WebInspector._reloadPageKeyboardShortcut.displayName, WebInspector._reloadPageIgnoringCacheKeyboardShortcut.displayName);
+var tooltip;
+if (WebInspector.debuggableType === WebInspector.DebuggableType._javascript_)
+tooltip = WebInspector.UIString("Restart (%s)").format(WebInspector._reloadPageKeyboardShortcut.displayName);
+else
+tooltip = WebInspector.UIString("Reload page 

[webkit-changes] [179321] trunk/Source/WebKit2

[commit-queue]

Title: [179321] trunk/Source/WebKit2








Revision 179321
Author commit-qu...@webkit.org
Date 2015-01-28 17:49:21 -0800 (Wed, 28 Jan 2015)


Log Message
Web Inspector: Crash closing inspected page with frequent activity
https://bugs.webkit.org/show_bug.cgi?id=140973

Patch by Joseph Pecoraro  on 2015-01-28
Reviewed by Timothy Hatcher.

* WebProcess/WebPage/WebInspector.h:
(WebKit::WebInspector::disconnectFromPage):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
Be sure to close the WebInspector connection through the page
when the page is closing so that the WebKit::WebInspector is
relinquishes itself as the InspectorFrontendChannel.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (179320 => 179321)

--- trunk/Source/WebKit2/ChangeLog	2015-01-29 01:09:50 UTC (rev 179320)
+++ trunk/Source/WebKit2/ChangeLog	2015-01-29 01:49:21 UTC (rev 179321)
@@ -1,3 +1,18 @@
+2015-01-28  Joseph Pecoraro  
+
+Web Inspector: Crash closing inspected page with frequent activity
+https://bugs.webkit.org/show_bug.cgi?id=140973
+
+Reviewed by Timothy Hatcher.
+
+* WebProcess/WebPage/WebInspector.h:
+(WebKit::WebInspector::disconnectFromPage):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::close):
+Be sure to close the WebInspector connection through the page
+when the page is closing so that the WebKit::WebInspector is
+relinquishes itself as the InspectorFrontendChannel.
+
 2015-01-28  Timothy Horton  
 
 Avoid manually handling quickLookWithEvent: if the immediate action gesture recognizer will do Lookup for us


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h (179320 => 179321)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h	2015-01-29 01:09:50 UTC (rev 179320)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h	2015-01-29 01:49:21 UTC (rev 179321)
@@ -83,6 +83,8 @@
 void remoteFrontendDisconnected();
 #endif
 
+void disconnectFromPage() { close(); }
+
 private:
 friend class WebInspectorClient;
 


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (179320 => 179321)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2015-01-29 01:09:50 UTC (rev 179320)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2015-01-29 01:49:21 UTC (rev 179321)
@@ -977,7 +977,11 @@
 if (pageGroup()->isVisibleToInjectedBundle() && WebProcess::shared().injectedBundle())
 WebProcess::shared().injectedBundle()->willDestroyPage(this);
 
-m_inspector = 0;
+if (m_inspector) {
+m_inspector->disconnectFromPage();
+m_inspector = nullptr;
+}
+
 #if ENABLE(FULLSCREEN_API)
 m_fullScreenManager = 0;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179320] trunk/Source/WebKit2

[timothy_horton]

Title: [179320] trunk/Source/WebKit2








Revision 179320
Author timothy_hor...@apple.com
Date 2015-01-28 17:09:50 -0800 (Wed, 28 Jan 2015)


Log Message
Avoid manually handling quickLookWithEvent: if the immediate action gesture recognizer will do Lookup for us
https://bugs.webkit.org/show_bug.cgi?id=141018


Reviewed by Beth Dakin.

* UIProcess/API/mac/WKView.mm:
(-[WKView quickLookWithEvent:]):
If we have an immediate action gesture recognizer, just call super and
avoid WebKit's special quickLookWithEvent: implementation.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (179319 => 179320)

--- trunk/Source/WebKit2/ChangeLog	2015-01-29 00:58:13 UTC (rev 179319)
+++ trunk/Source/WebKit2/ChangeLog	2015-01-29 01:09:50 UTC (rev 179320)
@@ -1,3 +1,16 @@
+2015-01-28  Timothy Horton  
+
+Avoid manually handling quickLookWithEvent: if the immediate action gesture recognizer will do Lookup for us
+https://bugs.webkit.org/show_bug.cgi?id=141018
+
+
+Reviewed by Beth Dakin.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView quickLookWithEvent:]):
+If we have an immediate action gesture recognizer, just call super and
+avoid WebKit's special quickLookWithEvent: implementation.
+
 2015-01-28  Sungmann Cho  
 
 Remove remaining PLATFORM(WIN) code blocks from WebKit2.


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (179319 => 179320)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2015-01-29 00:58:13 UTC (rev 179319)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2015-01-29 01:09:50 UTC (rev 179320)
@@ -2855,6 +2855,13 @@
 if (_data->_ignoresNonWheelEvents)
 return;
 
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 10100
+if (_data->_immediateActionGestureRecognizer) {
+[super quickLookWithEvent:event];
+return;
+}
+#endif
+
 NSPoint locationInViewCoordinates = [self convertPoint:[event locationInWindow] fromView:nil];
 _data->_page->performDictionaryLookupAtLocation(FloatPoint(locationInViewCoordinates.x, locationInViewCoordinates.y));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179319] trunk

[ggaren]

Title: [179319] trunk








Revision 179319
Author gga...@apple.com
Date 2015-01-28 16:58:13 -0800 (Wed, 28 Jan 2015)


Log Message
Removed fastMallocForbid / fastMallocAllow
https://bugs.webkit.org/show_bug.cgi?id=141012

Reviewed by Mark Hahnenberg.

Source/_javascript_Core:

Copy non-current thread stacks before scanning them instead of scanning
them in-place.

This operation is uncommon (i.e., never in the web content process),
and even in a stress test with 4 threads it only copies about 27kB,
so I think the performance cost is OK.

Scanning in-place requires a complex dance where we constrain our GC
data structures not to use malloc, free, or any other interesting functions
that might acquire locks. We've gotten this wrong many times in the past,
and I just got it wrong again yesterday. Since this code path is rarely
tested, I want it to just make sense, and not depend on or constrain the
details of the rest of the GC heap's design.

* heap/MachineStackMarker.cpp:
(JSC::otherThreadStack): Factored out a helper function for dealing with
unaligned and/or backwards pointers.

(JSC::MachineThreads::tryCopyOtherThreadStack): This is now the only
constrained function, and it only calls memcpy and low-level thread APIs.

(JSC::MachineThreads::tryCopyOtherThreadStacks): The design here is that
you do one pass over all the threads to compute their combined size,
and then a second pass to do all the copying. In theory, the threads may
grow in between passes, in which case you'll continue until the threads
stop growing. In practice, you never continue.

(JSC::growBuffer): Helper function for growing.

(JSC::MachineThreads::gatherConservativeRoots):
(JSC::MachineThreads::gatherFromOtherThread): Deleted.
* heap/MachineStackMarker.h: Updated for interface changes.

Source/WTF:

Removed the forbid / allow API because it is no longer used.

* wtf/FastMalloc.cpp:
(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::tryFastRealloc):
(WTF::fastRealloc):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
(WTF::isForbidden): Deleted.
(WTF::fastMallocForbid): Deleted.
(WTF::fastMallocAllow): Deleted.
(WTF::initializeIsForbiddenKey): Deleted.
* wtf/FastMalloc.h:

Tools:

Fixed a test bug I noticed while testing.

* DumpRenderTree/_javascript_Threading.cpp:
(stopJavaScriptThreads): Lock the _javascript_Threads lock before
accessing _javascript_Threads -- otherwise, you'll ASSERT.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp
trunk/Source/_javascript_Core/heap/MachineStackMarker.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FastMalloc.cpp
trunk/Source/WTF/wtf/FastMalloc.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/_javascript_Threading.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (179318 => 179319)

--- trunk/Source/_javascript_Core/ChangeLog	2015-01-29 00:50:53 UTC (rev 179318)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-01-29 00:58:13 UTC (rev 179319)
@@ -1,3 +1,43 @@
+2015-01-28  Geoffrey Garen  
+
+Removed fastMallocForbid / fastMallocAllow
+https://bugs.webkit.org/show_bug.cgi?id=141012
+
+Reviewed by Mark Hahnenberg.
+
+Copy non-current thread stacks before scanning them instead of scanning
+them in-place.
+
+This operation is uncommon (i.e., never in the web content process),
+and even in a stress test with 4 threads it only copies about 27kB,
+so I think the performance cost is OK.
+
+Scanning in-place requires a complex dance where we constrain our GC
+data structures not to use malloc, free, or any other interesting functions
+that might acquire locks. We've gotten this wrong many times in the past,
+and I just got it wrong again yesterday. Since this code path is rarely
+tested, I want it to just make sense, and not depend on or constrain the
+details of the rest of the GC heap's design.
+
+* heap/MachineStackMarker.cpp:
+(JSC::otherThreadStack): Factored out a helper function for dealing with
+unaligned and/or backwards pointers.
+
+(JSC::MachineThreads::tryCopyOtherThreadStack): This is now the only
+constrained function, and it only calls memcpy and low-level thread APIs.
+
+(JSC::MachineThreads::tryCopyOtherThreadStacks): The design here is that
+you do one pass over all the threads to compute their combined size,
+and then a second pass to do all the copying. In theory, the threads may
+grow in between passes, in which case you'll continue until the threads
+stop growing. In practice, you never continue.
+
+(JSC::growBuffer): Helper function for growing.
+
+(JSC::MachineThreads::gatherConservativeRoots):
+(JSC::MachineThreads::gatherFromOtherThread): Deleted.
+* heap/MachineStackMarker.h: Updated for interface changes.
+
 2015-01-28 

[webkit-changes] [179318] branches/safari-600.5-branch/Source

[bshafiei]

Title: [179318] branches/safari-600.5-branch/Source








Revision 179318
Author bshaf...@apple.com
Date 2015-01-28 16:50:53 -0800 (Wed, 28 Jan 2015)


Log Message
Merged r179230.  rdar://problem/19621509

Modified Paths

branches/safari-600.5-branch/Source/WebKit/mac/ChangeLog
branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebImmediateActionController.h
branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebImmediateActionController.mm
branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebView.mm
branches/safari-600.5-branch/Source/WebKit2/ChangeLog
branches/safari-600.5-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm




Diff

Modified: branches/safari-600.5-branch/Source/WebKit/mac/ChangeLog (179317 => 179318)

--- branches/safari-600.5-branch/Source/WebKit/mac/ChangeLog	2015-01-29 00:43:32 UTC (rev 179317)
+++ branches/safari-600.5-branch/Source/WebKit/mac/ChangeLog	2015-01-29 00:50:53 UTC (rev 179318)
@@ -1,3 +1,25 @@
+2015-01-28  Babak Shafiei  
+
+Merge r179230.
+
+2015-01-27  Beth Dakin  
+
+Immediate action gesture recognizer still doesn't work well with IB
+https://bugs.webkit.org/show_bug.cgi?id=140967
+-and corresponding-
+rdar://problem/19621509
+
+Reviewed by Tim Horton.
+
+We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
+initWithFrame it too early and IB might mess with it.
+* WebView/WebImmediateActionController.h:
+* WebView/WebImmediateActionController.mm:
+(-[WebImmediateActionController immediateActionRecognizer]):
+* WebView/WebView.mm:
+(-[WebView _commonInitializationWithFrameName:groupName:]):
+(-[WebView viewDidMoveToWindow]):
+
 2015-01-28  Matthew  
 
 Merge r179014. rdar://problem/19573674


Modified: branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebImmediateActionController.h (179317 => 179318)

--- branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebImmediateActionController.h	2015-01-29 00:43:32 UTC (rev 179317)
+++ branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebImmediateActionController.h	2015-01-29 00:50:53 UTC (rev 179318)
@@ -53,6 +53,8 @@
 - (void)webView:(WebView *)webView willHandleMouseDown:(NSEvent *)event;
 - (void)webView:(WebView *)webView didHandleScrollWheel:(NSEvent *)event;
 
+- (NSImmediateActionGestureRecognizer *)immediateActionRecognizer;
+
 @end
 
 #endif // PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000


Modified: branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebImmediateActionController.mm (179317 => 179318)

--- branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebImmediateActionController.mm	2015-01-29 00:43:32 UTC (rev 179317)
+++ branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebImmediateActionController.mm	2015-01-29 00:50:53 UTC (rev 179318)
@@ -104,6 +104,11 @@
 [self _clearImmediateActionState];
 }
 
+- (NSImmediateActionGestureRecognizer *)immediateActionRecognizer
+{
+return _immediateActionRecognizer.get();
+}
+
 - (void)_cancelImmediateAction
 {
 // Reset the recognizer by turning it off and on again.


Modified: branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebView.mm (179317 => 179318)

--- branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebView.mm	2015-01-29 00:43:32 UTC (rev 179317)
+++ branches/safari-600.5-branch/Source/WebKit/mac/WebView/WebView.mm	2015-01-29 00:50:53 UTC (rev 179318)
@@ -902,7 +902,6 @@
 RetainPtr recognizer = adoptNS([(NSImmediateActionGestureRecognizer *)[gestureClass alloc] initWithTarget:nil action:NULL]);
 _private->immediateActionController = [[WebImmediateActionController alloc] initWithWebView:self recognizer:recognizer.get()];
 [recognizer setDelegate:_private->immediateActionController];
-[self addGestureRecognizer:recognizer.get()];
 }
 #endif
 
@@ -5304,6 +5303,17 @@
 _private->page->setDeviceScaleFactor([self _deviceScaleFactor]);
 #endif
 
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
+if (_private->immediateActionController) {
+NSImmediateActionGestureRecognizer *recognizer = [_private->immediateActionController immediateActionRecognizer];
+if ([self window]) {
+if (![[self gestureRecognizers] containsObject:recognizer])
+[self addGestureRecognizer:recognizer];
+} else
+[self removeGestureRecognizer:recognizer];
+}
+#endif
+
 [self _updateActiveState];
 [self _updateVisibilityState];
 }


Modified: branches/safari-600.5-branch/Source/WebKit2/ChangeLog (179317 => 179318)

--- branches/safari-600.5-branch/Source/WebKit2/ChangeLog	2015-01-29 00:43:32 UTC (rev 179317)
+++ branches/safari-600.5-branch/Source/WebKit2/ChangeLog	2015-01-29 00:50:53 UTC (rev 179318)
@@ -1,3 +1,22 @@
+2015-01-28  Babak Shafiei  
+
+Merge r179230.
+
+2015-01-27  Beth Daki

[webkit-changes] [179317] branches/safari-600.4-branch/Source

[bshafiei]

Title: [179317] branches/safari-600.4-branch/Source








Revision 179317
Author bshaf...@apple.com
Date 2015-01-28 16:43:32 -0800 (Wed, 28 Jan 2015)


Log Message
Versioning.

Modified Paths

branches/safari-600.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-600.4-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-600.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-600.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-600.4-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-600.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig (179316 => 179317)

--- branches/safari-600.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-01-29 00:40:53 UTC (rev 179316)
+++ branches/safari-600.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-01-29 00:43:32 UTC (rev 179317)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 600;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.4-branch/Source/WebCore/Configurations/Version.xcconfig (179316 => 179317)

--- branches/safari-600.4-branch/Source/WebCore/Configurations/Version.xcconfig	2015-01-29 00:40:53 UTC (rev 179316)
+++ branches/safari-600.4-branch/Source/WebCore/Configurations/Version.xcconfig	2015-01-29 00:43:32 UTC (rev 179317)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 600;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (179316 => 179317)

--- branches/safari-600.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-01-29 00:40:53 UTC (rev 179316)
+++ branches/safari-600.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-01-29 00:43:32 UTC (rev 179317)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig (179316 => 179317)

--- branches/safari-600.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-01-29 00:40:53 UTC (rev 179316)
+++ branches/safari-600.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-01-29 00:43:32 UTC (rev 179317)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 600;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.4-branch/Source/WebKit2/Configurations/Version.xcconfig (179316 => 179317)

--- branches/safari-600.4-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-01-29 00:40:53 UTC (rev 179316)
+++ branches/safari-600.4-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-01-29 00:43:32 UTC (rev 179317)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 600;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179316] trunk/Source/WebKit2

[commit-queue]

Title: [179316] trunk/Source/WebKit2








Revision 179316
Author commit-qu...@webkit.org
Date 2015-01-28 16:40:53 -0800 (Wed, 28 Jan 2015)


Log Message
Remove remaining PLATFORM(WIN) code blocks from WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=140972

Patch by Sungmann Cho  on 2015-01-28
Reviewed by Darin Adler.

* WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (179315 => 179316)

--- trunk/Source/WebKit2/ChangeLog	2015-01-29 00:39:05 UTC (rev 179315)
+++ trunk/Source/WebKit2/ChangeLog	2015-01-29 00:40:53 UTC (rev 179316)
@@ -1,3 +1,13 @@
+2015-01-28  Sungmann Cho  
+
+Remove remaining PLATFORM(WIN) code blocks from WebKit2.
+https://bugs.webkit.org/show_bug.cgi?id=140972
+
+Reviewed by Darin Adler.
+
+* WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
+(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
+
 2015-01-28  Beth Dakin  
 
 Remove Mountain Lion code from WebKit and WebKit2


Modified: trunk/Source/WebKit2/WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp (179315 => 179316)

--- trunk/Source/WebKit2/WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp	2015-01-29 00:39:05 UTC (rev 179315)
+++ trunk/Source/WebKit2/WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp	2015-01-29 00:40:53 UTC (rev 179316)
@@ -32,8 +32,6 @@
 
 #if PLATFORM(MAC)
 #include 
-#elif PLATFORM(WIN)
-#include 
 #endif
 
 using namespace WebCore;
@@ -44,8 +42,6 @@
 {
 #if PLATFORM(MAC)
 CFHTTPCookieStorageRef defaultCookieStorage = WKGetDefaultHTTPCookieStorage();
-#elif PLATFORM(WIN)
-CFHTTPCookieStorageRef defaultCookieStorage = wkGetDefaultHTTPCookieStorage();
 #endif
 
 CFHTTPCookieStorageSetCookieAcceptPolicy(defaultCookieStorage, policy);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179315] trunk/LayoutTests

[bfulgham]

Title: [179315] trunk/LayoutTests








Revision 179315
Author bfulg...@apple.com
Date 2015-01-28 16:39:05 -0800 (Wed, 28 Jan 2015)


Log Message
[Win] Actually delete the file!

* platform/win/fast/events/ondrop-text-htmlt-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/win/fast/events/ondrop-text-htmlt-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (179314 => 179315)

--- trunk/LayoutTests/ChangeLog	2015-01-29 00:38:34 UTC (rev 179314)
+++ trunk/LayoutTests/ChangeLog	2015-01-29 00:39:05 UTC (rev 179315)
@@ -1,5 +1,11 @@
 2015-01-28  Brent Fulgham  
 
+[Win] Actually delete the file!
+
+* platform/win/fast/events/ondrop-text-htmlt-expected.txt: Removed.
+
+2015-01-28  Brent Fulgham  
+
 [Win] Unreviewed gardening. Get rid of misspelled expected file.
 
 Get rid of the 'ondrop-text-htmlt-expected.txt' file, and commit a new baseline


Deleted: trunk/LayoutTests/platform/win/fast/events/ondrop-text-htmlt-expected.txt (179314 => 179315)

--- trunk/LayoutTests/platform/win/fast/events/ondrop-text-htmlt-expected.txt	2015-01-29 00:38:34 UTC (rev 179314)
+++ trunk/LayoutTests/platform/win/fast/events/ondrop-text-htmlt-expected.txt	2015-01-29 00:39:05 UTC (rev 179315)
@@ -1,5 +0,0 @@
-CONSOLE MESSAGE: line 21: text/plain: This test verifies that we can get text/html from the drag object during an ondrop event. 
-CONSOLE MESSAGE: line 23: text/html: This test verifies that we can get text/html from the drag object during an ondrop event. 
-This test verifies that we can get text/html from the drag object during an ondrop event. This test requires DRT.
-PASS
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179314] tags/Safari-600.4.4/

[bshafiei]

Title: [179314] tags/Safari-600.4.4/








Revision 179314
Author bshaf...@apple.com
Date 2015-01-28 16:38:34 -0800 (Wed, 28 Jan 2015)


Log Message
New tag.

Added Paths

tags/Safari-600.4.4/




Diff

Property changes: tags/Safari-600.4.4



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179313] trunk/LayoutTests

[bfulgham]

Title: [179313] trunk/LayoutTests








Revision 179313
Author bfulg...@apple.com
Date 2015-01-28 16:37:04 -0800 (Wed, 28 Jan 2015)


Log Message
[Win] Unreviewed gardening. Get rid of misspelled expected file.

Get rid of the 'ondrop-text-htmlt-expected.txt' file, and commit a new baseline
from the test system.

* platform/win/fast/events/ondrop-text-htmlt-expected.txt: Removed.
* platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (179312 => 179313)

--- trunk/LayoutTests/ChangeLog	2015-01-29 00:30:07 UTC (rev 179312)
+++ trunk/LayoutTests/ChangeLog	2015-01-29 00:37:04 UTC (rev 179313)
@@ -1,3 +1,13 @@
+2015-01-28  Brent Fulgham  
+
+[Win] Unreviewed gardening. Get rid of misspelled expected file.
+
+Get rid of the 'ondrop-text-htmlt-expected.txt' file, and commit a new baseline
+from the test system.
+
+* platform/win/fast/events/ondrop-text-htmlt-expected.txt: Removed.
+* platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
+
 2015-01-28  Chris Dumez  
 
 Regression(r177494): Bad cast to WebKitCSSResourceValue in StyleBuilderConverter::convertMaskImageOperations()


Modified: trunk/LayoutTests/platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt (179312 => 179313)

--- trunk/LayoutTests/platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt	2015-01-29 00:30:07 UTC (rev 179312)
+++ trunk/LayoutTests/platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt	2015-01-29 00:37:04 UTC (rev 179313)
@@ -1,8 +1,8 @@
-layer at (0,0) size 785x730
+layer at (0,0) size 785x726
   RenderView at (0,0) size 785x600
-layer at (0,0) size 785x730
-  RenderBlock {HTML} at (0,0) size 785x730
-RenderBody {BODY} at (8,8) size 769x714
+layer at (0,0) size 785x726
+  RenderBlock {HTML} at (0,0) size 785x726
+RenderBody {BODY} at (8,8) size 769x710
   RenderBlock {DIV} at (0,0) size 769x18
 RenderInline {SPAN} at (0,0) size 325x18
   RenderText {#text} at (0,0) size 309x18
@@ -260,17 +260,17 @@
 RenderInline {SPAN} at (0,0) size 4x18
   RenderText {#text} at (368,0) size 4x18
 text run at (368,0) width 4: "\\"
-  RenderBlock {DIV} at (0,386) size 769x20
-RenderInline {SPAN} at (0,0) size 341x20
-  RenderText {#text} at (0,0) size 325x20
-text run at (0,0) width 325: "Using font \"caption\". expected: yen sign, actual: \x{A5}"
-  RenderInline {SPAN} at (0,0) size 8x20
-RenderText {#text} at (325,0) size 8x20
-  text run at (325,0) width 8: "\x{A5}"
-  RenderInline {SPAN} at (0,0) size 8x20
-RenderText {#text} at (333,0) size 8x20
-  text run at (333,0) width 8: "\x{A5}"
-  RenderBlock {DIV} at (0,406) size 769x18
+  RenderBlock {DIV} at (0,386) size 769x18
+RenderInline {SPAN} at (0,0) size 274x16
+  RenderText {#text} at (0,1) size 262x16
+text run at (0,1) width 262: "Using font \"caption\". expected: yen sign, actual: \x{A5}"
+  RenderInline {SPAN} at (0,0) size 6x16
+RenderText {#text} at (262,1) size 6x16
+  text run at (262,1) width 6: "\x{A5}"
+  RenderInline {SPAN} at (0,0) size 6x16
+RenderText {#text} at (268,1) size 6x16
+  text run at (268,1) width 6: "\x{A5}"
+  RenderBlock {DIV} at (0,404) size 769x18
 RenderInline {SPAN} at (0,0) size 257x16
   RenderText {#text} at (0,1) size 245x16
 text run at (0,1) width 245: "Using font \"icon\". expected: yen sign, actual: \x{A5}"
@@ -280,7 +280,7 @@
   RenderInline {SPAN} at (0,0) size 6x16
 RenderText {#text} at (251,1) size 6x16
   text run at (251,1) width 6: "\x{A5}"
-  RenderBlock {DIV} at (0,424) size 769x18
+  RenderBlock {DIV} at (0,422) size 769x18
 RenderInline {SPAN} at (0,0) size 264x16
   RenderText {#text} at (0,1) size 252x16
 text run at (0,1) width 252: "Using font \"menu\". expected: yen sign, actual: \x{A5}"
@@ -290,7 +290,7 @@
   RenderInline {SPAN} at (0,0) size 6x16
 RenderText {#text} at (258,1) size 6x16
   text run at (258,1) width 6: "\x{A5}"
-  RenderBlock {DIV} at (0,442) size 769x18
+  RenderBlock {DIV} at (0,440) size 769x18
 RenderInline {SPAN} at (0,0) size 304x16
   RenderText {#text} at (0,1) size 292x16
 text run at (0,1) width 292: "Using font \"message-box\". expected: yen sign, actual: \x{A5}"
@@ -300,17 +300,17 @@
   RenderInline {SPAN} at (0,0) size 6x16
 RenderText {#text} at (298,1) size 6x16
   text run at (298,1) width 6: "\x{A5}"
-  RenderBlock {DIV} at (0,460) size 769x20
-RenderInline {SPAN} at (0,0) size 382x20
-

[webkit-changes] [179312] trunk/Tools

[dburkart]

Title: [179312] trunk/Tools








Revision 179312
Author dburk...@apple.com
Date 2015-01-28 16:30:07 -0800 (Wed, 28 Jan 2015)


Log Message
asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
https://bugs.webkit.org/show_bug.cgi?id=141015

Reviewed by Alexey Proskuryakov.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/asan/asan.xcconfig




Diff

Modified: trunk/Tools/ChangeLog (179311 => 179312)

--- trunk/Tools/ChangeLog	2015-01-28 23:56:34 UTC (rev 179311)
+++ trunk/Tools/ChangeLog	2015-01-29 00:30:07 UTC (rev 179312)
@@ -1,3 +1,12 @@
+2015-01-28  Dana Burkart  
+
+asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
+https://bugs.webkit.org/show_bug.cgi?id=141015
+
+Reviewed by Alexey Proskuryakov.
+
+* asan/asan.xcconfig:
+
 2015-01-28  Sam Weinig  
 
 Fix the build.


Modified: trunk/Tools/asan/asan.xcconfig (179311 => 179312)

--- trunk/Tools/asan/asan.xcconfig	2015-01-28 23:56:34 UTC (rev 179311)
+++ trunk/Tools/asan/asan.xcconfig	2015-01-29 00:30:07 UTC (rev 179312)
@@ -10,8 +10,9 @@
 GCC_OPTIMIZATION_LEVEL_Production = 1;
 GCC_OPTIMIZATION_LEVEL_Release = 1;
 
-ASAN_OTHER_CFLAGS = -fsanitize=address -fsanitize-blacklist=$(ASAN_IGNORE) -fno-omit-frame-pointer -g;
+CLANG_ADDRESS_SANITIZER=YES
+
+ASAN_OTHER_CFLAGS = -fsanitize-blacklist=$(ASAN_IGNORE) -fno-omit-frame-pointer -g;
 ASAN_OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CFLAGS);
-ASAN_OTHER_LDFLAGS = -fsanitize=address;
 
 GCC_ENABLE_OBJC_GC = NO;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179311] trunk/Tools

[weinig]

Title: [179311] trunk/Tools








Revision 179311
Author wei...@apple.com
Date 2015-01-28 15:56:34 -0800 (Wed, 28 Jan 2015)


Log Message
Fix the build.

* Scripts/copy-webkitlibraries-to-product-directory:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory




Diff

Modified: trunk/Tools/ChangeLog (179310 => 179311)

--- trunk/Tools/ChangeLog	2015-01-28 23:46:59 UTC (rev 179310)
+++ trunk/Tools/ChangeLog	2015-01-28 23:56:34 UTC (rev 179311)
@@ -1,3 +1,9 @@
+2015-01-28  Sam Weinig  
+
+Fix the build.
+
+* Scripts/copy-webkitlibraries-to-product-directory:
+
 2015-01-28  Lucas Forschler  
 
 Increase the FileUpload block size in an attempt to improve network performance.


Modified: trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory (179310 => 179311)

--- trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2015-01-28 23:46:59 UTC (rev 179310)
+++ trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2015-01-28 23:56:34 UTC (rev 179311)
@@ -150,7 +150,6 @@
 ));
 } else {
 push(@librariesToCopy, (
-"libWebKitSystemInterfaceMountainLion.a",
 "libWebKitSystemInterfaceMavericks.a",
 "libWebKitSystemInterfaceYosemite.a"
 ));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179310] trunk/WebKitLibraries

[weinig]

Title: [179310] trunk/WebKitLibraries








Revision 179310
Author wei...@apple.com
Date 2015-01-28 15:46:59 -0800 (Wed, 28 Jan 2015)


Log Message
Remove libWebKitSystemInterfaceMountainLion.a

Reviewed by Mark Rowe.

* libWebKitSystemInterfaceMountainLion.a: Removed.

Modified Paths

trunk/WebKitLibraries/ChangeLog


Removed Paths

trunk/WebKitLibraries/libWebKitSystemInterfaceMountainLion.a




Diff

Modified: trunk/WebKitLibraries/ChangeLog (179309 => 179310)

--- trunk/WebKitLibraries/ChangeLog	2015-01-28 23:36:46 UTC (rev 179309)
+++ trunk/WebKitLibraries/ChangeLog	2015-01-28 23:46:59 UTC (rev 179310)
@@ -1,3 +1,11 @@
+2015-01-28  Sam Weinig  
+
+Remove libWebKitSystemInterfaceMountainLion.a
+
+Reviewed by Mark Rowe.
+
+* libWebKitSystemInterfaceMountainLion.a: Removed.
+
 2015-01-28  pe...@outlook.com  
 
 [WinCairo] Enable CSS_SELECTORS_LEVEL4.


Deleted: trunk/WebKitLibraries/libWebKitSystemInterfaceMountainLion.a

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [179309] trunk/Source/WebCore

[zalan]

Title: [179309] trunk/Source/WebCore








Revision 179309
Author za...@apple.com
Date 2015-01-28 15:36:46 -0800 (Wed, 28 Jan 2015)


Log Message
Simple line layout: Drop uncommitted/committed terms from LineState.
https://bugs.webkit.org/show_bug.cgi?id=141005

Reviewed by Antti Koivisto.

Fragments form segments and segments turn into runs on the lines.
We add fragments only when they fit so they should not be in 'uncommitted' state at all.

No change in functionality.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::LineState::createRun):
(WebCore::SimpleLineLayout::LineState::addFragment):
(WebCore::SimpleLineLayout::LineState::addWhitespace):
(WebCore::SimpleLineLayout::LineState::hasWhitespaceOnly):
(WebCore::SimpleLineLayout::LineState::width):
(WebCore::SimpleLineLayout::LineState::firstCharacterFits):
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::firstFragment):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
(WebCore::SimpleLineLayout::createTextRuns): Unnecessary assert.
(WebCore::SimpleLineLayout::LineState::commitAndCreateRun): Deleted.
(WebCore::SimpleLineLayout::LineState::addUncommitted): Deleted.
(WebCore::SimpleLineLayout::LineState::addUncommittedWhitespace): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/SimpleLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (179308 => 179309)

--- trunk/Source/WebCore/ChangeLog	2015-01-28 23:20:36 UTC (rev 179308)
+++ trunk/Source/WebCore/ChangeLog	2015-01-28 23:36:46 UTC (rev 179309)
@@ -1,3 +1,32 @@
+2015-01-28  Zalan Bujtas  
+
+Simple line layout: Drop uncommitted/committed terms from LineState.
+https://bugs.webkit.org/show_bug.cgi?id=141005
+
+Reviewed by Antti Koivisto.
+
+Fragments form segments and segments turn into runs on the lines.
+We add fragments only when they fit so they should not be in 'uncommitted' state at all.
+
+No change in functionality.
+
+* rendering/SimpleLineLayout.cpp:
+(WebCore::SimpleLineLayout::LineState::createRun):
+(WebCore::SimpleLineLayout::LineState::addFragment):
+(WebCore::SimpleLineLayout::LineState::addWhitespace):
+(WebCore::SimpleLineLayout::LineState::hasWhitespaceOnly):
+(WebCore::SimpleLineLayout::LineState::width):
+(WebCore::SimpleLineLayout::LineState::firstCharacterFits):
+(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
+(WebCore::SimpleLineLayout::removeTrailingWhitespace):
+(WebCore::SimpleLineLayout::firstFragment):
+(WebCore::SimpleLineLayout::createLineRuns):
+(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
+(WebCore::SimpleLineLayout::createTextRuns): Unnecessary assert.
+(WebCore::SimpleLineLayout::LineState::commitAndCreateRun): Deleted.
+(WebCore::SimpleLineLayout::LineState::addUncommitted): Deleted.
+(WebCore::SimpleLineLayout::LineState::addUncommittedWhitespace): Deleted.
+
 2015-01-28  Chris Dumez  
 
 Regression(r177494): Bad cast to WebKitCSSResourceValue in StyleBuilderConverter::convertMaskImageOperations()


Modified: trunk/Source/WebCore/rendering/SimpleLineLayout.cpp (179308 => 179309)

--- trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2015-01-28 23:20:36 UTC (rev 179308)
+++ trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2015-01-28 23:36:46 UTC (rev 179309)
@@ -228,52 +228,52 @@
 }
 
 struct LineState {
-void commitAndCreateRun(Layout::RunVector& lineRuns)
+void createRun(Layout::RunVector& lineRuns)
 {
-if (uncommittedStart == uncommittedEnd)
+if (segmentStart == segmentEnd)
 return;
 
-lineRuns.append(Run(uncommittedStart, uncommittedEnd, committedWidth, committedWidth + uncommittedWidth, false));
+lineRuns.append(Run(segmentStart, segmentEnd, runsWidth, runsWidth + segmentWidth, false));
 // Move uncommitted to committed.
-committedWidth += uncommittedWidth;
-committedTrailingWhitespaceWidth = uncomittedTrailingWhitespaceWidth;
-committedTrailingWhitespaceLength = uncomittedTrailingWhitespaceLength;
+runsWidth += segmentWidth;
+lastRunTrailingWhitespaceWidth = segmentTrailingWhitespaceWidth;
+lastRunTrailingWhitespaceLength = segmentTrailingWhitespaceLength;
 if (!m_firstCharacterFits)
-m_firstCharacterFits = uncommittedStart + 1 > uncommittedEnd || committedWidth <= availableWidth;
+m_firstCharacterFits = segmentStart + 1 > segmentEnd || runsWidth <= availableWidth;
 
-uncommittedStart = uncommittedEnd;
-uncommittedWidth = 0;
-uncomittedTrailingWhitespaceWidth = 0;
-uncomittedTrailingWhitespaceLength = 0;
-m_newUncommittedSegment = true;
+   

[webkit-changes] [179308] trunk

[cdumez]

Title: [179308] trunk








Revision 179308
Author cdu...@apple.com
Date 2015-01-28 15:20:36 -0800 (Wed, 28 Jan 2015)


Log Message
Regression(r177494): Bad cast to WebKitCSSResourceValue in StyleBuilderConverter::convertMaskImageOperations()
https://bugs.webkit.org/show_bug.cgi?id=140991


Reviewed by Antti Koivisto.

Source/WebCore:

convertMaskImageOperations() was assuming that the CSSValueList's values
were always WebKitCSSResourceValue values. However, they can be
CSSInitialValues as well so we should check before casting.

Test: css3/masking/mask-image-initial-value-crash.html

* css/StyleBuilderConverter.h:
(WebCore::maskImageValueFromIterator):
(WebCore::StyleBuilderConverter::convertMaskImageOperations):

LayoutTests:

Add layout test to cover the case where a CSSValue is incorrectly casted to
a WebKitCSSResourceValue in StyleBuilderConverter::convertMaskImageOperations(),
thus hitting an assertion in downcast<>() on debug builds.

* css3/masking/mask-image-initial-value-crash-expected.txt: Added.
* css3/masking/mask-image-initial-value-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleBuilderConverter.h


Added Paths

trunk/LayoutTests/css3/masking/mask-image-initial-value-crash-expected.txt
trunk/LayoutTests/css3/masking/mask-image-initial-value-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (179307 => 179308)

--- trunk/LayoutTests/ChangeLog	2015-01-28 22:52:22 UTC (rev 179307)
+++ trunk/LayoutTests/ChangeLog	2015-01-28 23:20:36 UTC (rev 179308)
@@ -1,3 +1,18 @@
+2015-01-28  Chris Dumez  
+
+Regression(r177494): Bad cast to WebKitCSSResourceValue in StyleBuilderConverter::convertMaskImageOperations()
+https://bugs.webkit.org/show_bug.cgi?id=140991
+
+
+Reviewed by Antti Koivisto.
+
+Add layout test to cover the case where a CSSValue is incorrectly casted to
+a WebKitCSSResourceValue in StyleBuilderConverter::convertMaskImageOperations(),
+thus hitting an assertion in downcast<>() on debug builds.
+
+* css3/masking/mask-image-initial-value-crash-expected.txt: Added.
+* css3/masking/mask-image-initial-value-crash.html: Added.
+
 2015-01-28  Brent Fulgham  
 
 [Win] More gardening to get the bot green.


Added: trunk/LayoutTests/css3/masking/mask-image-initial-value-crash-expected.txt (0 => 179308)

--- trunk/LayoutTests/css3/masking/mask-image-initial-value-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/masking/mask-image-initial-value-crash-expected.txt	2015-01-28 23:20:36 UTC (rev 179308)
@@ -0,0 +1,3 @@
+This test passes if it doesn't crash.
+
+


Added: trunk/LayoutTests/css3/masking/mask-image-initial-value-crash.html (0 => 179308)

--- trunk/LayoutTests/css3/masking/mask-image-initial-value-crash.html	(rev 0)
+++ trunk/LayoutTests/css3/masking/mask-image-initial-value-crash.html	2015-01-28 23:20:36 UTC (rev 179308)
@@ -0,0 +1,14 @@
+
+
+
+This test passes if it doesn't crash.
+
+
+if (window.testRunner)
+  testRunner.dumpAsText();
+
+testDiv.style.cssText += "-webkit-mask-position: 0px 0px, 1px 1px";
+testDiv.style.cssText += "-webkit-mask-position: 1px 1px;";
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (179307 => 179308)

--- trunk/Source/WebCore/ChangeLog	2015-01-28 22:52:22 UTC (rev 179307)
+++ trunk/Source/WebCore/ChangeLog	2015-01-28 23:20:36 UTC (rev 179308)
@@ -1,5 +1,23 @@
 2015-01-28  Chris Dumez  
 
+Regression(r177494): Bad cast to WebKitCSSResourceValue in StyleBuilderConverter::convertMaskImageOperations()
+https://bugs.webkit.org/show_bug.cgi?id=140991
+
+
+Reviewed by Antti Koivisto.
+
+convertMaskImageOperations() was assuming that the CSSValueList's values
+were always WebKitCSSResourceValue values. However, they can be
+CSSInitialValues as well so we should check before casting.
+
+Test: css3/masking/mask-image-initial-value-crash.html
+
+* css/StyleBuilderConverter.h:
+(WebCore::maskImageValueFromIterator):
+(WebCore::StyleBuilderConverter::convertMaskImageOperations):
+
+2015-01-28  Chris Dumez  
+
 Remove dead code from MemoryCache
 https://bugs.webkit.org/show_bug.cgi?id=140964
 


Modified: trunk/Source/WebCore/css/StyleBuilderConverter.h (179307 => 179308)

--- trunk/Source/WebCore/css/StyleBuilderConverter.h	2015-01-28 22:52:22 UTC (rev 179307)
+++ trunk/Source/WebCore/css/StyleBuilderConverter.h	2015-01-28 23:20:36 UTC (rev 179308)
@@ -1031,6 +1031,14 @@
 return Nullopt;
 }
 
+static inline WebKitCSSResourceValue* maskImageValueFromIterator(CSSValueList& maskImagesList, CSSValueList::iterator it)
+{
+// May also be a CSSInitialValue.
+if (it == maskImagesList.end() || !is(it->get()))
+return nullptr;
+return &downcast(it->get());
+}
+
 inline Vector> StyleBuilderConverter::convertMaskImageOperations(StyleResolver&

[webkit-changes] [179304] branches/safari-600.5-branch

[matthew_hanson]

Title: [179304] branches/safari-600.5-branch








Revision 179304
Author matthew_han...@apple.com
Date 2015-01-28 14:52:15 -0800 (Wed, 28 Jan 2015)


Log Message
Merge r177927. rdar://problem/19585726

Modified Paths

branches/safari-600.5-branch/LayoutTests/ChangeLog
branches/safari-600.5-branch/LayoutTests/platform/mac-wk1/TestExpectations
branches/safari-600.5-branch/Source/WebCore/ChangeLog
branches/safari-600.5-branch/Source/WebCore/page/FrameView.cpp


Added Paths

branches/safari-600.5-branch/LayoutTests/fast/images/animated-gif-window-resizing-expected.txt
branches/safari-600.5-branch/LayoutTests/fast/images/animated-gif-window-resizing.html
branches/safari-600.5-branch/LayoutTests/fast/images/animated-gif-zooming-expected.txt
branches/safari-600.5-branch/LayoutTests/fast/images/animated-gif-zooming.html
branches/safari-600.5-branch/LayoutTests/fast/images/resources/animated-gif-window-resize.html




Diff

Modified: branches/safari-600.5-branch/LayoutTests/ChangeLog (179303 => 179304)

--- branches/safari-600.5-branch/LayoutTests/ChangeLog	2015-01-28 22:52:10 UTC (rev 179303)
+++ branches/safari-600.5-branch/LayoutTests/ChangeLog	2015-01-28 22:52:15 UTC (rev 179304)
@@ -1,5 +1,30 @@
 2015-01-28  Matthew  
 
+Merge r177927. rdar://problem/19585726
+
+2015-01-05  Chris Dumez  
+
+Regression(r163928): Animated images are not resumed on window resizing
+https://bugs.webkit.org/show_bug.cgi?id=139714
+
+
+Reviewed by Darin Adler.
+
+Add a layout test to make sure animated images are correctly paused /
+resumed when resizing the window.
+
+Also add another test to make sure animated images are correctly paused
+/ resumed when zooming in and out.
+
+* fast/images/animated-gif-window-resizing-expected.txt: Added.
+* fast/images/animated-gif-window-resizing.html: Added.
+* fast/images/animated-gif-zooming-expected.txt: Added.
+* fast/images/animated-gif-zooming.html: Added.
+* fast/images/resources/animated-gif-window-resize.html: Added.
+* platform/mac-wk1/TestExpectations:
+
+2015-01-28  Matthew  
+
 Merge r177165. rdar://problem/19617570
 
 2014-12-10  Dean Jackson  


Added: branches/safari-600.5-branch/LayoutTests/fast/images/animated-gif-window-resizing-expected.txt (0 => 179304)

--- branches/safari-600.5-branch/LayoutTests/fast/images/animated-gif-window-resizing-expected.txt	(rev 0)
+++ branches/safari-600.5-branch/LayoutTests/fast/images/animated-gif-window-resizing-expected.txt	2015-01-28 22:52:15 UTC (rev 179304)
@@ -0,0 +1,13 @@
+Test that animated images are properly stopped / resumed on window resizing.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+The animated GIF should initially be outside the viewport.
+PASS isImagePaused() became true
+Resize window so that the image is now inside the viewport.
+PASS isImagePaused() became false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: branches/safari-600.5-branch/LayoutTests/fast/images/animated-gif-window-resizing.html (0 => 179304)

--- branches/safari-600.5-branch/LayoutTests/fast/images/animated-gif-window-resizing.html	(rev 0)
+++ branches/safari-600.5-branch/LayoutTests/fast/images/animated-gif-window-resizing.html	2015-01-28 22:52:15 UTC (rev 179304)
@@ -0,0 +1,43 @@
+
+
+
+
+
+