[webkit-changes] [184704] branches/safari-601.1.32.2-branch/Source
Title: [184704] branches/safari-601.1.32.2-branch/Source
Revision 184704
Author matthew_han...@apple.com
Date 2015-05-20 23:39:27 -0700 (Wed, 20 May 2015)
Log Message
Merge r184681. rdar://problem/20924495
Modified Paths
branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog
branches/safari-601.1.32.2-branch/Source/WebCore/page/ViewportConfiguration.cpp
branches/safari-601.1.32.2-branch/Source/WebCore/page/ViewportConfiguration.h
branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.32.2-branch/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog (184703 => 184704)
--- branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog 2015-05-21 05:55:21 UTC (rev 184703)
+++ branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog 2015-05-21 06:39:27 UTC (rev 184704)
@@ -1,3 +1,23 @@
+2015-05-20 Matthew Hanson matthew_han...@apple.com
+
+Merge r184681. rdar://problem/20924495
+
+2015-05-20 Enrica Casucci enr...@apple.com
+
+[iOS] Using CSS viewport units causes incorrect layout.
+https://bugs.webkit.org/show_bug.cgi?id=145225
+rdar://problem/20924495
+
+Reviewed by Benjamin Poulain.
+
+* page/ViewportConfiguration.cpp:
+(WebCore::ViewportConfiguration::initialScaleFromSize):
+(WebCore::ViewportConfiguration::initialScale):
+(WebCore::ViewportConfiguration::initialScaleIgnoringContentSize):
+* page/ViewportConfiguration.h:
+(WebCore::ViewportConfiguration::initialScaleFromSize):
+(WebCore::ViewportConfiguration::initialScaleIgnoringContentSize):
+
2015-05-20 Babak Shafiei bshaf...@apple.com
Merge r184611.
Modified: branches/safari-601.1.32.2-branch/Source/WebCore/page/ViewportConfiguration.cpp (184703 => 184704)
--- branches/safari-601.1.32.2-branch/Source/WebCore/page/ViewportConfiguration.cpp 2015-05-21 05:55:21 UTC (rev 184703)
+++ branches/safari-601.1.32.2-branch/Source/WebCore/page/ViewportConfiguration.cpp 2015-05-21 06:39:27 UTC (rev 184704)
@@ -130,30 +130,38 @@
return shouldIgnoreHorizontalScalingConstraints() || shouldIgnoreVerticalScalingConstraints();
}
-double ViewportConfiguration::initialScale() const
+double ViewportConfiguration::initialScaleFromSize(double width, double height, bool shouldIgnoreScalingConstraints) const
{
ASSERT(!constraintsAreAllRelative(m_configuration));
// If the document has specified its own initial scale, use it regardless.
// This is guaranteed to be sanity checked already, so no need for MIN/MAX.
-if (m_configuration.initialScaleIsSet !shouldIgnoreScalingConstraints())
+if (m_configuration.initialScaleIsSet !shouldIgnoreScalingConstraints)
return m_configuration.initialScale;
// If not, it is up to us to determine the initial scale.
// We want a scale small enough to fit the document width-wise.
const FloatSize minimumLayoutSize = m_minimumLayoutSize;
-double width = m_contentSize.width() 0 ? m_contentSize.width() : layoutWidth();
double initialScale = 0;
if (width 0 !shouldIgnoreVerticalScalingConstraints())
initialScale = minimumLayoutSize.width() / width;
// Prevent the initial scale from shrinking to a height smaller than our view's minimum height.
-double height = m_contentSize.height() 0 ? m_contentSize.height() : layoutHeight();
if (height 0 height * initialScale minimumLayoutSize.height() !shouldIgnoreHorizontalScalingConstraints())
initialScale = minimumLayoutSize.height() / height;
-return std::min(std::max(initialScale, shouldIgnoreScalingConstraints() ? m_defaultConfiguration.minimumScale : m_configuration.minimumScale), m_configuration.maximumScale);
+return std::min(std::max(initialScale, shouldIgnoreScalingConstraints ? m_defaultConfiguration.minimumScale : m_configuration.minimumScale), m_configuration.maximumScale);
}
+double ViewportConfiguration::initialScale() const
+{
+return initialScaleFromSize(m_contentSize.width() 0 ? m_contentSize.width() : layoutWidth(), m_contentSize.height() 0 ? m_contentSize.height() : layoutHeight(), shouldIgnoreScalingConstraints());
+}
+
+double ViewportConfiguration::initialScaleIgnoringContentSize() const
+{
+return initialScaleFromSize(layoutWidth(), layoutHeight(), false);
+}
+
double ViewportConfiguration::minimumScale() const
{
// If we scale to fit, then this is our minimum scale as well.
Modified: branches/safari-601.1.32.2-branch/Source/WebCore/page/ViewportConfiguration.h (184703 => 184704)
--- branches/safari-601.1.32.2-branch/Source/WebCore/page/ViewportConfiguration.h 2015-05-21 05:55:21 UTC (rev 184703)
+++ branches/safari-601.1.32.2-branch/Source/WebCore/page/ViewportConfiguration.h 2015-05-21 06:39:27 UTC (rev 184704)
@@ -82,6 +82,7 @@
WEBCORE_EXPORT IntSize
[webkit-changes] [184706] branches/safari-601.1.32.2-branch/Source/JavaScriptCore
Title: [184706] branches/safari-601.1.32.2-branch/Source/_javascript_Core
Revision 184706
Author matthew_han...@apple.com
Date 2015-05-20 23:39:35 -0700 (Wed, 20 May 2015)
Log Message
Merge r184652. rdar://problem/21002666
Modified Paths
branches/safari-601.1.32.2-branch/Source/_javascript_Core/ChangeLog
branches/safari-601.1.32.2-branch/Source/_javascript_Core/heap/Heap.cpp
branches/safari-601.1.32.2-branch/Source/_javascript_Core/heap/IncrementalSweeper.cpp
branches/safari-601.1.32.2-branch/Source/_javascript_Core/heap/IncrementalSweeper.h
Diff
Modified: branches/safari-601.1.32.2-branch/Source/_javascript_Core/ChangeLog (184705 => 184706)
--- branches/safari-601.1.32.2-branch/Source/_javascript_Core/ChangeLog 2015-05-21 06:39:32 UTC (rev 184705)
+++ branches/safari-601.1.32.2-branch/Source/_javascript_Core/ChangeLog 2015-05-21 06:39:35 UTC (rev 184706)
@@ -1,3 +1,42 @@
+2015-05-20 Matthew Hanson matthew_han...@apple.com
+
+Merge r184652. rdar://problem/21002666
+
+2015-05-20 Andreas Kling akl...@apple.com
+
+Eden collections should extend the IncrementalSweeper work list, not replace it.
+https://webkit.org/b/145213
+rdar://problem/21002666
+
+Reviewed by Geoffrey Garen.
+
+After an eden collection, the garbage collector was adding all MarkedBlocks containing
+new objects to the IncrementalSweeper's work list, to make sure they didn't have to
+wait until the next full collection before getting swept.
+
+Or at least, that's what it thought it was doing. It turns out that IncrementalSweeper's
+internal work list is really just a reference to Heap::m_blockSnapshot. I didn't realize
+this when writing the post-eden sweep code, and instead made eden collections cancel
+all pending sweeps and *replace* them with the list of blocks with new objects.
+
+This made it so that rapidly occurring eden collections could prevent large numbers of
+heap blocks from ever getting swept. This would manifest as accumulation of MarkedBlocks
+when a system under heavy load was also allocating short lived objects at a high rate.
+Things would eventually get cleaned up when there was a lull and a full collection was
+allowed to run its heap sweep to completion.
+
+Fix this by moving all management of the block snapshot to Heap. snapshotMarkedSpace()
+now handles eden collections by merging the list of blocks with new objects into the
+existing block snapshot.
+
+* heap/Heap.cpp:
+(JSC::Heap::snapshotMarkedSpace):
+(JSC::Heap::notifyIncrementalSweeper):
+* heap/IncrementalSweeper.cpp:
+(JSC::IncrementalSweeper::startSweeping):
+(JSC::IncrementalSweeper::addBlocksAndContinueSweeping): Deleted.
+* heap/IncrementalSweeper.h:
+
2015-05-18 Matthew Hanson matthew_han...@apple.com
Merge r184510. rdar://problem/21004989
Modified: branches/safari-601.1.32.2-branch/Source/_javascript_Core/heap/Heap.cpp (184705 => 184706)
--- branches/safari-601.1.32.2-branch/Source/_javascript_Core/heap/Heap.cpp 2015-05-21 06:39:32 UTC (rev 184705)
+++ branches/safari-601.1.32.2-branch/Source/_javascript_Core/heap/Heap.cpp 2015-05-21 06:39:35 UTC (rev 184706)
@@ -1207,9 +1207,12 @@
{
GCPHASE(SnapshotMarkedSpace);
-if (m_operationInProgress == EdenCollection)
-m_blockSnapshot = m_objectSpace.blocksWithNewObjects();
-else {
+if (m_operationInProgress == EdenCollection) {
+m_blockSnapshot.appendVector(m_objectSpace.blocksWithNewObjects());
+// Sort and deduplicate the block snapshot since we might be appending to an unfinished work list.
+std::sort(m_blockSnapshot.begin(), m_blockSnapshot.end());
+m_blockSnapshot.shrink(std::unique(m_blockSnapshot.begin(), m_blockSnapshot.end()) - m_blockSnapshot.begin());
+} else {
m_blockSnapshot.resizeToFit(m_objectSpace.blocks().set().size());
MarkedBlockSnapshotFunctor functor(m_blockSnapshot);
m_objectSpace.forEachBlock(functor);
@@ -1225,13 +1228,13 @@
void Heap::notifyIncrementalSweeper()
{
GCPHASE(NotifyIncrementalSweeper);
-if (m_operationInProgress == EdenCollection)
-m_sweeper-addBlocksAndContinueSweeping(WTF::move(m_blockSnapshot));
-else {
+
+if (m_operationInProgress == FullCollection) {
if (!m_logicallyEmptyWeakBlocks.isEmpty())
m_indexOfNextLogicallyEmptyWeakBlockToSweep = 0;
-m_sweeper-startSweeping(WTF::move(m_blockSnapshot));
}
+
+m_sweeper-startSweeping();
}
void Heap::rememberCurrentlyExecutingCodeBlocks()
Modified: branches/safari-601.1.32.2-branch/Source/_javascript_Core/heap/IncrementalSweeper.cpp (184705 => 184706)
---
[webkit-changes] [184705] branches/safari-601.1.32.2-branch/Source/WebKit2
Title: [184705] branches/safari-601.1.32.2-branch/Source/WebKit2
Revision 184705
Author matthew_han...@apple.com
Date 2015-05-20 23:39:32 -0700 (Wed, 20 May 2015)
Log Message
Merge r184679. rdar://problem/20990162
Modified Paths
branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm
Diff
Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog (184704 => 184705)
--- branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog 2015-05-21 06:39:27 UTC (rev 184704)
+++ branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog 2015-05-21 06:39:32 UTC (rev 184705)
@@ -1,5 +1,22 @@
2015-05-20 Matthew Hanson matthew_han...@apple.com
+Merge r184679. rdar://problem/20990162
+
+2015-05-20 Tim Horton timothy_hor...@apple.com
+
+Allow overriding the waitForDidUpdateViewState timeout
+https://bugs.webkit.org/show_bug.cgi?id=145230
+rdar://problem/20990162
+
+Reviewed by Darin Adler.
+
+* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
+(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateViewState):
+Use the value from NSUserDefaults, if it exists.
+We'll only check once, so changing the default requires a restart of the UI process.
+
+2015-05-20 Matthew Hanson matthew_han...@apple.com
+
Merge r184681. rdar://problem/20924495
2015-05-20 Enrica Casucci enr...@apple.com
Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm (184704 => 184705)
--- branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm 2015-05-21 06:39:27 UTC (rev 184704)
+++ branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm 2015-05-21 06:39:32 UTC (rev 184705)
@@ -393,11 +393,16 @@
void RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateViewState()
{
+static std::chrono::milliseconds viewStateUpdateTimeout = [] {
+if (id value = [[NSUserDefaults standardUserDefaults] objectForKey:@WebKitOverrideViewStateUpdateTimeout])
+return std::chrono::duration_caststd::chrono::milliseconds(std::chrono::durationdouble([value doubleValue]));
+
#if PLATFORM(IOS)
-auto viewStateUpdateTimeout = std::chrono::milliseconds(500);
+return std::chrono::milliseconds(500);
#else
-auto viewStateUpdateTimeout = std::chrono::milliseconds(250);
+return std::chrono::milliseconds(250);
#endif
+}();
m_webPageProxy.process().connection()-waitForAndDispatchImmediatelyMessages::RemoteLayerTreeDrawingAreaProxy::CommitLayerTree(m_webPageProxy.pageID(), viewStateUpdateTimeout, InterruptWaitingIfSyncMessageArrives);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184707] branches/safari-601.1.32.2-branch/Source/WebCore
Title: [184707] branches/safari-601.1.32.2-branch/Source/WebCore
Revision 184707
Author matthew_han...@apple.com
Date 2015-05-20 23:39:40 -0700 (Wed, 20 May 2015)
Log Message
Merge r184654. rdar://problem/21044514
Modified Paths
branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog
branches/safari-601.1.32.2-branch/Source/WebCore/dom/ViewportArguments.cpp
branches/safari-601.1.32.2-branch/Source/WebCore/dom/ViewportArguments.h
branches/safari-601.1.32.2-branch/Source/WebCore/page/ViewportConfiguration.cpp
branches/safari-601.1.32.2-branch/Source/WebCore/page/ViewportConfiguration.h
Diff
Modified: branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog (184706 => 184707)
--- branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog 2015-05-21 06:39:35 UTC (rev 184706)
+++ branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog 2015-05-21 06:39:40 UTC (rev 184707)
@@ -1,5 +1,46 @@
2015-05-20 Matthew Hanson matthew_han...@apple.com
+Merge r184654. rdar://problem/21044514
+
+2015-05-20 Tim Horton timothy_hor...@apple.com
+
+Add a mechanism to opt-out of the automatic scaling applied to not-really-responsive sites
+https://bugs.webkit.org/show_bug.cgi?id=144760
+
+Reviewed by Darin Adler.
+
+Add a new viewport property, shrink-to-fit, which can be used to disable
+the automatic scaling introduced in r181400. This provides sites with a
+way to tell WebKit that they're really sure they want to be laid out at
+window-width/height, even if they fail to fit within that size.
+
+* dom/ViewportArguments.cpp:
+(WebCore::ViewportArguments::resolve):
+(WebCore::findBooleanValue):
+(WebCore::setViewportFeature):
+* dom/ViewportArguments.h:
+(WebCore::ViewportArguments::ViewportArguments):
+(WebCore::ViewportArguments::operator==):
+* page/ViewportConfiguration.cpp:
+(WebCore::ViewportConfiguration::shouldIgnoreHorizontalScalingConstraints):
+(WebCore::ViewportConfiguration::shouldIgnoreVerticalScalingConstraints):
+(WebCore::ViewportConfiguration::webpageParameters):
+(WebCore::ViewportConfiguration::textDocumentParameters):
+(WebCore::ViewportConfiguration::imageDocumentParameters):
+(WebCore::ViewportConfiguration::testingParameters):
+(WebCore::booleanViewportArgumentIsSet):
+(WebCore::ViewportConfiguration::updateConfiguration):
+(WebCore::ViewportConfigurationTextStream::operator):
+(WebCore::viewportArgumentUserZoomIsSet): Deleted.
+* page/ViewportConfiguration.h:
+(WebCore::ViewportConfiguration::Parameters::Parameters):
+Plumb the shrink-to-fit viewport property through.
+If shrink-to-fit is set to yes, or not set, we behave as usual; if it is
+set to no, we will bail from shouldIgnore[Horizontal|Vertical]ScalingConstraints,
+effectively disabling the automatic scaling introduced in r181400.
+
+2015-05-20 Matthew Hanson matthew_han...@apple.com
+
Merge r184681. rdar://problem/20924495
2015-05-20 Enrica Casucci enr...@apple.com
Modified: branches/safari-601.1.32.2-branch/Source/WebCore/dom/ViewportArguments.cpp (184706 => 184707)
--- branches/safari-601.1.32.2-branch/Source/WebCore/dom/ViewportArguments.cpp 2015-05-21 06:39:35 UTC (rev 184706)
+++ branches/safari-601.1.32.2-branch/Source/WebCore/dom/ViewportArguments.cpp 2015-05-21 06:39:40 UTC (rev 184707)
@@ -86,7 +86,6 @@
float resultZoom = zoom;
float resultMinZoom = minZoom;
float resultMaxZoom = maxZoom;
-float resultUserZoom = userZoom;
switch (int(resultWidth)) {
case ViewportArguments::ValueDeviceWidth:
@@ -244,8 +243,9 @@
// if (resultZoom == ViewportArguments::ValueAuto)
//result.initialScale = ViewportArguments::ValueAuto;
-result.userScalable = resultUserZoom;
+result.userScalable = userZoom;
result.orientation = orientation;
+result.shrinkToFit = shrinkToFit;
return result;
}
@@ -354,7 +354,7 @@
return value;
}
-static float findUserScalableValue(const String keyString, const String valueString, Document* document)
+static float findBooleanValue(const String keyString, const String valueString, Document* document)
{
// yes and no are used as keywords.
// Numbers = 1, numbers = -1, device-width and device-height are mapped to yes.
@@ -392,12 +392,14 @@
else if (keyString == maximum-scale)
arguments-maxZoom = findScaleValue(keyString, valueString, document);
else if (keyString == user-scalable)
-arguments-userZoom = findUserScalableValue(keyString, valueString, document);
+arguments-userZoom = findBooleanValue(keyString, valueString, document);
#if PLATFORM(IOS)
else if (keyString ==
[webkit-changes] [184708] trunk/Source/WebKit2
Title: [184708] trunk/Source/WebKit2
Revision 184708
Author o...@webkit.org
Date 2015-05-21 00:26:50 -0700 (Thu, 21 May 2015)
Log Message
Fix mismatched-tags warnings related to CoordinatedGraphics
https://bugs.webkit.org/show_bug.cgi?id=145130
Reviewed by Darin Adler.
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
* WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (184707 => 184708)
--- trunk/Source/WebKit2/ChangeLog 2015-05-21 06:39:40 UTC (rev 184707)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-21 07:26:50 UTC (rev 184708)
@@ -1,3 +1,14 @@
+2015-05-21 Csaba Osztrogonác o...@webkit.org
+
+Fix mismatched-tags warnings related to CoordinatedGraphics
+https://bugs.webkit.org/show_bug.cgi?id=145130
+
+Reviewed by Darin Adler.
+
+* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
+* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
+* WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
+
2015-05-20 Gyuyoung Kim gyuyoung@webkit.org
Unreviewed GTK build fix since r184686.
Modified: trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h (184707 => 184708)
--- trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h 2015-05-21 06:39:40 UTC (rev 184707)
+++ trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h 2015-05-21 07:26:50 UTC (rev 184708)
@@ -39,7 +39,7 @@
#include wtf/Threading.h
namespace WebCore {
-class CoordinatedGraphicsState;
+struct CoordinatedGraphicsState;
}
namespace WebKit {
Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in (184707 => 184708)
--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in 2015-05-21 06:39:40 UTC (rev 184707)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in 2015-05-21 07:26:50 UTC (rev 184708)
@@ -21,6 +21,6 @@
#if USE(COORDINATED_GRAPHICS)
messages - CoordinatedLayerTreeHostProxy {
-CommitCoordinatedGraphicsState(WebCore::CoordinatedGraphicsState state)
+CommitCoordinatedGraphicsState(struct WebCore::CoordinatedGraphicsState state)
}
#endif
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h (184707 => 184708)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h 2015-05-21 06:39:40 UTC (rev 184707)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h 2015-05-21 07:26:50 UTC (rev 184708)
@@ -46,7 +46,7 @@
namespace WebCore {
class CoordinatedGraphicsLayerState;
-class CoordinatedGraphicsState;
+struct CoordinatedGraphicsState;
class CoordinatedSurface;
class GraphicsContext;
class GraphicsLayer;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184709] trunk/Source/WebCore
Title: [184709] trunk/Source/WebCore Revision 184709 Author gyuyoung@webkit.org Date 2015-05-21 00:26:55 -0700 (Thu, 21 May 2015) Log Message Purge PassRefPtr in WebCore/Modules https://bugs.webkit.org/show_bug.cgi?id=145112 Reviewed by Darin Adler. As a step to remove PassRefPtr, this patch replaces PassRefPtr with Ref or RefPtr depends on null of return value. No new tests, no behavior changes. * Modules/encryptedmedia/MediaKeySession.cpp: (WebCore::MediaKeySession::create): * Modules/encryptedmedia/MediaKeySession.h: * Modules/encryptedmedia/MediaKeys.cpp: (WebCore::MediaKeys::create): (WebCore::MediaKeys::createSession): * Modules/encryptedmedia/MediaKeys.h: * Modules/gamepad/Gamepad.h: * Modules/gamepad/NavigatorGamepad.cpp: (WebCore::NavigatorGamepad::gamepadFromPlatformGamepad): * Modules/gamepad/deprecated/Gamepad.h: * Modules/geolocation/GeolocationError.h: (WebCore::GeolocationError::create): * Modules/geolocation/GeolocationPosition.h: (WebCore::GeolocationPosition::create): * Modules/geolocation/Geoposition.h: (WebCore::Geoposition::create): * Modules/geolocation/PositionError.h: (WebCore::PositionError::create): * Modules/geolocation/PositionOptions.h: (WebCore::PositionOptions::create): * Modules/mediacontrols/MediaControlsHost.cpp: (WebCore::MediaControlsHost::create): * Modules/mediacontrols/MediaControlsHost.h: * Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::create): * Modules/mediasource/MediaSource.h: * Modules/mediastream/RTCDataChannel.cpp: (WebCore::RTCDataChannel::create): * Modules/mediastream/RTCDataChannel.h: * Modules/mediastream/RTCIceCandidate.cpp: (WebCore::RTCIceCandidate::create): * Modules/mediastream/RTCIceCandidate.h: * Modules/webaudio/OfflineAudioContext.cpp: (WebCore::OfflineAudioContext::create): * Modules/webaudio/OfflineAudioContext.h: * Modules/webaudio/OfflineAudioDestinationNode.h: (WebCore::OfflineAudioDestinationNode::create): * Modules/webaudio/OscillatorNode.cpp: (WebCore::OscillatorNode::create): * Modules/webaudio/OscillatorNode.h: * Modules/webdatabase/Database.cpp: (WebCore::Database::runTransaction): * Modules/webdatabase/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originLockFor): * Modules/webdatabase/DatabaseTracker.h: * Modules/webdatabase/SQLError.h: (WebCore::SQLError::create): * Modules/webdatabase/SQLResultSet.h: (WebCore::SQLResultSet::create): * Modules/webdatabase/SQLResultSetRowList.h: (WebCore::SQLResultSetRowList::create): * Modules/webdatabase/SQLStatementBackend.cpp: (WebCore::SQLStatementBackend::create): * Modules/webdatabase/SQLStatementBackend.h: * Modules/webdatabase/SQLTransactionBackend.cpp: (WebCore::SQLTransactionBackend::create): * Modules/webdatabase/SQLTransactionBackend.h: * Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::create): * Modules/websockets/ThreadableWebSocketChannelClientWrapper.h: * Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::create): * Modules/websockets/WebSocket.h: * Modules/websockets/WebSocketChannel.h: (WebCore::WebSocketChannel::create): * Modules/websockets/WorkerThreadableWebSocketChannel.h: (WebCore::WorkerThreadableWebSocketChannel::create): (WebCore::WorkerThreadableWebSocketChannel::Bridge::create): * editing/InsertListCommand.h: (WebCore::InsertListCommand::create): * workers/Worker.cpp: (WebCore::Worker::create): * workers/Worker.h: * xml/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): (WebCore::XPathExpression::evaluate): * xml/XPathExpression.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.h trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.h trunk/Source/WebCore/Modules/gamepad/Gamepad.h trunk/Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp trunk/Source/WebCore/Modules/gamepad/deprecated/Gamepad.h trunk/Source/WebCore/Modules/geolocation/GeolocationError.h trunk/Source/WebCore/Modules/geolocation/GeolocationPosition.h trunk/Source/WebCore/Modules/geolocation/Geoposition.h trunk/Source/WebCore/Modules/geolocation/PositionError.h trunk/Source/WebCore/Modules/geolocation/PositionOptions.h trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp trunk/Source/WebCore/Modules/mediasource/MediaSource.h trunk/Source/WebCore/Modules/mediastream/RTCDataChannel.cpp trunk/Source/WebCore/Modules/mediastream/RTCDataChannel.h trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.h trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.h trunk/Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.h
[webkit-changes] [184710] trunk/Source/WebKit2
Title: [184710] trunk/Source/WebKit2 Revision 184710 Author o...@webkit.org Date 2015-05-21 02:27:07 -0700 (Thu, 21 May 2015) Log Message [EFL] Fix mismatched-tags warnings in UIProcess/API/efl https://bugs.webkit.org/show_bug.cgi?id=145129 Reviewed by Gyuyoung Kim. * UIProcess/API/efl/EwkViewCallbacks.h: * UIProcess/API/efl/ewk_application_cache_manager.h: * UIProcess/API/efl/ewk_auth_request.h: * UIProcess/API/efl/ewk_back_forward_list.h: * UIProcess/API/efl/ewk_back_forward_list_item.h: * UIProcess/API/efl/ewk_color_picker.h: * UIProcess/API/efl/ewk_context.h: * UIProcess/API/efl/ewk_context_menu_item.h: * UIProcess/API/efl/ewk_cookie_manager.h: * UIProcess/API/efl/ewk_database_manager.h: * UIProcess/API/efl/ewk_download_job.h: * UIProcess/API/efl/ewk_error.h: * UIProcess/API/efl/ewk_favicon_database.h: * UIProcess/API/efl/ewk_file_chooser_request.h: * UIProcess/API/efl/ewk_form_submission_request.h: * UIProcess/API/efl/ewk_navigation_data.h: * UIProcess/API/efl/ewk_navigation_policy_decision.h: * UIProcess/API/efl/ewk_object.h: * UIProcess/API/efl/ewk_page_group.h: * UIProcess/API/efl/ewk_popup_menu.h: * UIProcess/API/efl/ewk_popup_menu_item.h: * UIProcess/API/efl/ewk_security_origin.h: * UIProcess/API/efl/ewk_settings.h: * UIProcess/API/efl/ewk_storage_manager.h: * UIProcess/API/efl/ewk_url_request.h: * UIProcess/API/efl/ewk_url_response.h: * UIProcess/API/efl/ewk_url_scheme_request.h: * UIProcess/API/efl/ewk_view.h: * UIProcess/API/efl/ewk_window_features.h: * WebProcess/InjectedBundle/API/efl/ewk_extension.h: * WebProcess/InjectedBundle/API/efl/ewk_page.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/efl/EwkViewCallbacks.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_auth_request.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list_item.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_color_picker.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_database_manager.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_error.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_file_chooser_request.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_form_submission_request.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_navigation_data.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_object.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_page_group.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_security_origin.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_url_request.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_url_response.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_window_features.h trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_extension.h trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h Diff Modified: trunk/Source/WebKit2/ChangeLog (184709 => 184710) --- trunk/Source/WebKit2/ChangeLog 2015-05-21 07:26:55 UTC (rev 184709) +++ trunk/Source/WebKit2/ChangeLog 2015-05-21 09:27:07 UTC (rev 184710) @@ -1,5 +1,44 @@ 2015-05-21 Csaba Osztrogonác o...@webkit.org +[EFL] Fix mismatched-tags warnings in UIProcess/API/efl +https://bugs.webkit.org/show_bug.cgi?id=145129 + +Reviewed by Gyuyoung Kim. + +* UIProcess/API/efl/EwkViewCallbacks.h: +* UIProcess/API/efl/ewk_application_cache_manager.h: +* UIProcess/API/efl/ewk_auth_request.h: +* UIProcess/API/efl/ewk_back_forward_list.h: +* UIProcess/API/efl/ewk_back_forward_list_item.h: +* UIProcess/API/efl/ewk_color_picker.h: +* UIProcess/API/efl/ewk_context.h: +* UIProcess/API/efl/ewk_context_menu_item.h: +* UIProcess/API/efl/ewk_cookie_manager.h: +* UIProcess/API/efl/ewk_database_manager.h: +* UIProcess/API/efl/ewk_download_job.h: +* UIProcess/API/efl/ewk_error.h: +* UIProcess/API/efl/ewk_favicon_database.h: +* UIProcess/API/efl/ewk_file_chooser_request.h: +* UIProcess/API/efl/ewk_form_submission_request.h: +* UIProcess/API/efl/ewk_navigation_data.h: +* UIProcess/API/efl/ewk_navigation_policy_decision.h: +* UIProcess/API/efl/ewk_object.h: +* UIProcess/API/efl/ewk_page_group.h: +*
[webkit-changes] [184725] trunk/Source/WebCore
Title: [184725] trunk/Source/WebCore
Revision 184725
Author mattba...@apple.com
Date 2015-05-21 11:32:58 -0700 (Thu, 21 May 2015)
Log Message
Unreviewed build fix.
* svg/SVGAnimateElementBase.cpp:
(WebCore::propertyTypesAreConsistent): should be type.properties, not type.properties().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGAnimateElementBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (184724 => 184725)
--- trunk/Source/WebCore/ChangeLog 2015-05-21 18:24:59 UTC (rev 184724)
+++ trunk/Source/WebCore/ChangeLog 2015-05-21 18:32:58 UTC (rev 184725)
@@ -1,3 +1,10 @@
+2015-05-21 Matt Baker mattba...@apple.com
+
+Unreviewed build fix.
+
+* svg/SVGAnimateElementBase.cpp:
+(WebCore::propertyTypesAreConsistent): should be type.properties, not type.properties().
+
2015-05-21 Xabier Rodriguez Calvar calva...@igalia.com and Youenn Fablet youenn.fab...@crf.canon.fr
[Streams API] Remove ReadableStreamReader closed promise internal slot
Modified: trunk/Source/WebCore/svg/SVGAnimateElementBase.cpp (184724 => 184725)
--- trunk/Source/WebCore/svg/SVGAnimateElementBase.cpp 2015-05-21 18:24:59 UTC (rev 184724)
+++ trunk/Source/WebCore/svg/SVGAnimateElementBase.cpp 2015-05-21 18:32:58 UTC (rev 184725)
@@ -172,7 +172,7 @@
static inline bool propertyTypesAreConsistent(AnimatedPropertyType expectedPropertyType, const SVGElementAnimatedPropertyList animatedTypes)
{
for (auto type : animatedTypes) {
-for (auto property : type.properties()) {
+for (auto property : type.properties) {
if (expectedPropertyType != property-animatedPropertyType()) {
// This is the only allowed inconsistency. SVGAnimatedAngleAnimator handles both SVGAnimatedAngle SVGAnimatedEnumeration for markers orient attribute.
if (expectedPropertyType == AnimatedAngle property-animatedPropertyType() == AnimatedEnumeration)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184726] trunk/Source/WebKit2
Title: [184726] trunk/Source/WebKit2
Revision 184726
Author bweinst...@apple.com
Date 2015-05-21 11:54:13 -0700 (Thu, 21 May 2015)
Log Message
Add a _WKWebKitContentExtensionStore initializer that takes a path.
https://bugs.webkit.org/show_bug.cgi?id=145269 and work towards rdar://problem/21031414
Reviewed by Anders Carlsson.
* UIProcess/API/APIUserContentExtensionStore.cpp:
(API::UserContentExtensionStore::storeWithPath):
* UIProcess/API/APIUserContentExtensionStore.h:
* UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
* UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:
(+[_WKUserContentExtensionStore storeWithURL:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.cpp
trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStore.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (184725 => 184726)
--- trunk/Source/WebKit2/ChangeLog 2015-05-21 18:32:58 UTC (rev 184725)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-21 18:54:13 UTC (rev 184726)
@@ -1,3 +1,17 @@
+2015-05-21 Brian Weinstein bweinst...@apple.com
+
+Add a _WKWebKitContentExtensionStore initializer that takes a path.
+https://bugs.webkit.org/show_bug.cgi?id=145269 and work towards rdar://problem/21031414
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/APIUserContentExtensionStore.cpp:
+(API::UserContentExtensionStore::storeWithPath):
+* UIProcess/API/APIUserContentExtensionStore.h:
+* UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
+* UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:
+(+[_WKUserContentExtensionStore storeWithURL:]):
+
2015-05-21 Alexey Proskuryakov a...@apple.com
Build fix. Silence some deprecation warnings.
Modified: trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.cpp (184725 => 184726)
--- trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.cpp 2015-05-21 18:32:58 UTC (rev 184725)
+++ trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.cpp 2015-05-21 18:54:13 UTC (rev 184726)
@@ -52,6 +52,11 @@
return *defaultStore;
}
+RefUserContentExtensionStore UserContentExtensionStore::storeWithPath(const WTF::String storePath)
+{
+return adoptRef(*new UserContentExtensionStore(storePath));
+}
+
UserContentExtensionStore::UserContentExtensionStore()
: UserContentExtensionStore(defaultStorePath())
{
Modified: trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.h (184725 => 184726)
--- trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.h 2015-05-21 18:32:58 UTC (rev 184725)
+++ trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.h 2015-05-21 18:54:13 UTC (rev 184726)
@@ -54,6 +54,7 @@
const static uint32_t CurrentContentExtensionFileVersion = 3;
static UserContentExtensionStore defaultStore();
+static RefUserContentExtensionStore storeWithPath(const WTF::String storePath);
explicit UserContentExtensionStore();
explicit UserContentExtensionStore(const WTF::String storePath);
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStore.h (184725 => 184726)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStore.h 2015-05-21 18:32:58 UTC (rev 184725)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStore.h 2015-05-21 18:54:13 UTC (rev 184726)
@@ -33,6 +33,7 @@
@interface _WKUserContentExtensionStore : NSObject
+ (instancetype)defaultStore;
++ (instancetype)storeWithURL:(NSURL *)url;
- (void)compileContentExtensionForIdentifier:(NSString *)identifier encodedContentExtension:(NSString *) NS_RELEASES_ARGUMENT encodedContentExtension completionHandler:(void (^)(_WKUserContentFilter *, NSError *))completionHandler;
- (void)lookupContentExtensionForIdentifier:(NSString *)identifier completionHandler:(void (^)(_WKUserContentFilter *, NSError *))completionHandler;
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm (184725 => 184726)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm 2015-05-21 18:32:58 UTC (rev 184725)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm 2015-05-21 18:54:13 UTC (rev 184726)
@@ -46,6 +46,12 @@
return WebKit::wrapper(API::UserContentExtensionStore::defaultStore());
}
++ (instancetype)storeWithURL:(NSURL *)url
+{
+RefAPI::UserContentExtensionStore store = API::UserContentExtensionStore::storeWithPath(url.absoluteURL.fileSystemRepresentation);
+return WebKit::wrapper(store.leakRef());
+}
+
- (void)compileContentExtensionForIdentifier:(NSString *)identifier encodedContentExtension:(NSString *)encodedContentExtension completionHandler:(void (^)(_WKUserContentFilter *, NSError *))completionHandler
{
auto
[webkit-changes] [184722] trunk/Source/WebCore
Title: [184722] trunk/Source/WebCore
Revision 184722
Author roger_f...@apple.com
Date 2015-05-21 10:52:38 -0700 (Thu, 21 May 2015)
Log Message
Media Controls stop updating after hovering for a few seconds.
https://bugs.webkit.org/show_bug.cgi?id=144770.
rdar://problem/19823121
Reviewed by Jer Noble.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createBase):
We should never hide controls immediately as a result of mousing out of the controls.
It should only happen when the mouse leaves the video entirely.
(Controller.prototype.updateTimelineMetricsIfNeeded):
Don’t update if controls are hidden, timeline dimensions will be 0.
(Controller.prototype.handlePanelTransitionEnd):
Instead of adjusting visibility via adding and removing classes,
remove controls entirely from the tree.
(Controller.prototype.showControls):
Add controls back into the tree when showing controls.
(Controller.prototype.updateForShowingControls):
Helper method for showControls.
(Controller.prototype.controlsAreHidden):
Controls also hidden if removed from tree.
Remove forceUpdate logic, no longer necessary.
(Controller.prototype.handleDurationChange):
(Controller.prototype.updateProgress):
(Controller.prototype.updateTime):
Override methods to use add and remove panelContainer for iOS.
* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handlePanelTransitionEnd):
(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.controlsAreHidden):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (184721 => 184722)
--- trunk/Source/WebCore/ChangeLog 2015-05-21 17:45:48 UTC (rev 184721)
+++ trunk/Source/WebCore/ChangeLog 2015-05-21 17:52:38 UTC (rev 184722)
@@ -1,3 +1,38 @@
+2015-05-21 Roger Fong roger_f...@apple.com
+
+Media Controls stop updating after hovering for a few seconds.
+https://bugs.webkit.org/show_bug.cgi?id=144770.
+rdar://problem/19823121
+
+Reviewed by Jer Noble.
+
+* Modules/mediacontrols/mediaControlsApple.js:
+(Controller.prototype.createBase):
+We should never hide controls immediately as a result of mousing out of the controls.
+It should only happen when the mouse leaves the video entirely.
+(Controller.prototype.updateTimelineMetricsIfNeeded):
+Don’t update if controls are hidden, timeline dimensions will be 0.
+(Controller.prototype.handlePanelTransitionEnd):
+Instead of adjusting visibility via adding and removing classes,
+remove controls entirely from the tree.
+(Controller.prototype.showControls):
+Add controls back into the tree when showing controls.
+(Controller.prototype.updateForShowingControls):
+Helper method for showControls.
+(Controller.prototype.controlsAreHidden):
+Controls also hidden if removed from tree.
+
+Remove forceUpdate logic, no longer necessary.
+(Controller.prototype.handleDurationChange):
+(Controller.prototype.updateProgress):
+(Controller.prototype.updateTime):
+
+Override methods to use add and remove panelContainer for iOS.
+* Modules/mediacontrols/mediaControlsiOS.js:
+(ControllerIOS.prototype.handlePanelTransitionEnd):
+(ControllerIOS.prototype.showControls):
+(ControllerIOS.prototype.controlsAreHidden):
+
2015-05-21 Chris Dumez cdu...@apple.com
Regression(r179293): We no longer call destroyDecodedData() on CachedResources on memory pressure
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (184721 => 184722)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-05-21 17:45:48 UTC (rev 184721)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-05-21 17:52:38 UTC (rev 184722)
@@ -268,7 +268,7 @@
var base = this.base = document.createElement('div');
base.setAttribute('pseudo', '-webkit-media-controls');
this.listenFor(base, 'mousemove', this.handleWrapperMouseMove);
-this.listenFor(base, 'mouseout', this.handleWrapperMouseOut);
+this.listenFor(this.video, 'mouseout', this.handleWrapperMouseOut);
if (this.host.textTrackContainer)
base.appendChild(this.host.textTrackContainer);
},
@@ -291,9 +291,14 @@
this.timelineMetricsNeedsUpdate = true;
},
+scheduleUpdateLayoutForDisplayedWidth: function()
+{
+setTimeout(this.updateLayoutForDisplayedWidth.bind(this), 0);
+},
+
updateTimelineMetricsIfNeeded: function()
{
-if (this.timelineMetricsNeedsUpdate) {
+if (this.timelineMetricsNeedsUpdate !this.controlsAreHidden()) {
this.timelineLeft = this.controls.timeline.offsetLeft;
this.timelineWidth =
[webkit-changes] [184724] branches/safari-601.1.32.2-branch/Source/WebKit2
Title: [184724] branches/safari-601.1.32.2-branch/Source/WebKit2
Revision 184724
Author bshaf...@apple.com
Date 2015-05-21 11:24:59 -0700 (Thu, 21 May 2015)
Log Message
Merged r184716.
Modified Paths
branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm
branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFormInputControl.mm
branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.h
branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.mm
branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm
Diff
Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog (184723 => 184724)
--- branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog 2015-05-21 18:08:34 UTC (rev 184723)
+++ branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog 2015-05-21 18:24:59 UTC (rev 184724)
@@ -1,3 +1,20 @@
+2015-05-21 Babak Shafiei bshaf...@apple.com
+
+Merge r184716.
+
+2015-05-21 Alexey Proskuryakov a...@apple.com
+
+Build fix. Silence some deprecation warnings.
+
+* UIProcess/ios/forms/WKFileUploadPanel.mm:
+(-[WKFileUploadPanel _presentPopoverWithContentViewController:animated:]):
+* UIProcess/ios/forms/WKFormInputControl.mm:
+(-[WKDateTimePopover initWithView:datePickerMode:]):
+* UIProcess/ios/forms/WKFormPopover.h:
+* UIProcess/ios/forms/WKFormPopover.mm:
+* UIProcess/ios/forms/WKFormSelectPopover.mm:
+(-[WKSelectPopover initWithView:hasGroups:]):
+
2015-05-20 Matthew Hanson matthew_han...@apple.com
Merge r184679. rdar://problem/20990162
Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm (184723 => 184724)
--- branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm 2015-05-21 18:08:34 UTC (rev 184723)
+++ branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm 2015-05-21 18:24:59 UTC (rev 184724)
@@ -290,7 +290,10 @@
BOOL _usingCamera;
RetainPtrUIImagePickerController _imagePicker;
RetainPtrUIViewController _presentationViewController; // iPhone always. iPad for Fullscreen Camera.
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored -Wdeprecated-declarations
RetainPtrUIPopoverController _presentationPopover; // iPad for action sheet and Photo Library.
+#pragma clang diagnostic pop
RetainPtrUIDocumentMenuViewController _documentMenuController;
RetainPtrUIAlertController _actionSheetController;
}
@@ -565,7 +568,10 @@
{
[self _dismissDisplayAnimated:animated];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored -Wdeprecated-declarations
_presentationPopover = adoptNS([[UIPopoverController alloc] initWithContentViewController:contentViewController]);
+#pragma clang diagnostic pop
[_presentationPopover setDelegate:self];
[_presentationPopover presentPopoverFromRect:CGRectIntegral(CGRectMake(_interactionPoint.x, _interactionPoint.y, 1, 1)) inView:_view permittedArrowDirections:UIPopoverArrowDirectionAny animated:animated];
}
Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFormInputControl.mm (184723 => 184724)
--- branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFormInputControl.mm 2015-05-21 18:08:34 UTC (rev 184723)
+++ branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFormInputControl.mm 2015-05-21 18:24:59 UTC (rev 184724)
@@ -341,7 +341,10 @@
#pragma clang diagnostic pop
[navigationItem setRightBarButtonItem:clearButton];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored -Wdeprecated-declarations
RetainPtrUIPopoverController controller = adoptNS([[UIPopoverController alloc] initWithContentViewController:navigationController.get()]);
+#pragma clang diagnostic pop
[self setPopoverController:controller.get()];
return self;
Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.h (184723 => 184724)
--- branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.h 2015-05-21 18:08:34 UTC (rev 184723)
+++ branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.h 2015-05-21 18:24:59 UTC (rev 184724)
@@ -38,7 +38,10 @@
- (UIPopoverArrowDirection)popoverArrowDirections;
@property(nonatomic, assign) CGPoint presentationPoint;
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored -Wdeprecated-declarations
@property(nonatomic, retain) UIPopoverController *popoverController;
+#pragma clang diagnostic pop
@property(nonatomic, assign) id WKRotatingPopoverDelegate dismissionDelegate;
@end
Modified:
[webkit-changes] [184721] trunk/LayoutTests
Title: [184721] trunk/LayoutTests Revision 184721 Author cfleiz...@apple.com Date 2015-05-21 10:45:48 -0700 (Thu, 21 May 2015) Log Message AX: improve list heuristics (presentational use versus actual lists) https://bugs.webkit.org/show_bug.cgi?id=134187 Unreviewed layout test fixage. Skip the list-detection2.html test on GTK until it can be investigated. https://bugs.webkit.org/show_bug.cgi?id=145273 Fix a failing test on GTK that needed an update after the last set of changes. Skip the test on windows until a time someone can decide if we even expose or need lists in Windows AX API. https://bugs.webkit.org/show_bug.cgi?id=145271 * platform/gtk/TestExpectations: * platform/gtk/accessibility/list-detection-expected.txt: * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/accessibility/list-detection-expected.txt trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (184720 => 184721) --- trunk/LayoutTests/ChangeLog 2015-05-21 17:45:21 UTC (rev 184720) +++ trunk/LayoutTests/ChangeLog 2015-05-21 17:45:48 UTC (rev 184721) @@ -1,3 +1,20 @@ +2015-05-21 Chris Fleizach cfleiz...@apple.com + +AX: improve list heuristics (presentational use versus actual lists) +https://bugs.webkit.org/show_bug.cgi?id=134187 + +Unreviewed layout test fixage. + +Skip the list-detection2.html test on GTK until it can be investigated. +https://bugs.webkit.org/show_bug.cgi?id=145273 +Fix a failing test on GTK that needed an update after the last set of changes. +Skip the test on windows until a time someone can decide if we even expose or need lists in Windows AX API. +https://bugs.webkit.org/show_bug.cgi?id=145271 + +* platform/gtk/TestExpectations: +* platform/gtk/accessibility/list-detection-expected.txt: +* platform/win/TestExpectations: + 2015-05-21 Said Abou-Hallawa sabouhall...@apple.com SVG as image uses very tiny default font-size Modified: trunk/LayoutTests/platform/gtk/TestExpectations (184720 => 184721) --- trunk/LayoutTests/platform/gtk/TestExpectations 2015-05-21 17:45:21 UTC (rev 184720) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-05-21 17:45:48 UTC (rev 184721) @@ -491,6 +491,7 @@ Bug(GTK) css3/filters/backdrop [ Skip ] webkit.org/b/141072 accessibility/frame-disconnect-textmarker-cache-crash.html [ Failure ] +webkit.org/b/145273 accessibility/list-detection2.html [ Failure ] webkit.org/b/141423 css3/calc/line-height.html [ Failure ] webkit.org/b/141423 editing/pasteboard/simplfiying-markup-should-not-strip-content.html [ Failure ] Modified: trunk/LayoutTests/platform/gtk/accessibility/list-detection-expected.txt (184720 => 184721) --- trunk/LayoutTests/platform/gtk/accessibility/list-detection-expected.txt 2015-05-21 17:45:21 UTC (rev 184720) +++ trunk/LayoutTests/platform/gtk/accessibility/list-detection-expected.txt 2015-05-21 17:45:48 UTC (rev 184721) @@ -35,8 +35,8 @@ PASS axElement.role == 'AXRole: AXList' is true -Unordered list with more than 1 item and no style is a list. -PASS axElement.role == 'AXRole: AXList' is true +Unordered list with more than 1 item and no style is not a list. +PASS axElement.role == 'AXRole: AXList' is false Unordered list with 1 item and no style is not list. Modified: trunk/LayoutTests/platform/win/TestExpectations (184720 => 184721) --- trunk/LayoutTests/platform/win/TestExpectations 2015-05-21 17:45:21 UTC (rev 184720) +++ trunk/LayoutTests/platform/win/TestExpectations 2015-05-21 17:45:48 UTC (rev 184721) @@ -1330,8 +1330,10 @@ webkit.org/b/140798 [ Debug ] accessibility/legend-children-are-visible.html [ Skip ] # Debug assertion webkit.org/b/140798 [ Release ] accessibility/link-inside-button-accessible-text.html [ Failure ] webkit.org/b/140798 [ Debug ] accessibility/link-inside-button-accessible-text.html [ Skip ] # Debug assertion -webkit.org/b/140798 [ Release ] accessibility/list-detection.html [ Failure ] -webkit.org/b/140798 [ Debug ] accessibility/list-detection.html [ Skip ] # Debug assertion +webkit.org/b/145271 [ Release ] accessibility/list-detection.html [ Failure ] +webkit.org/b/145271 [ Debug ] accessibility/list-detection.html [ Skip ] # Debug assertion +webkit.org/b/145271 [ Release ] accessibility/list-detection2.html [ Failure ] +webkit.org/b/145271 [ Debug ] accessibility/list-detection2.html [ Failure ] webkit.org/b/140798 [ Release ] accessibility/listitem-title.html [ Failure ] webkit.org/b/140798 [ Debug ] accessibility/listitem-title.html [ Skip ] # Debug assertion webkit.org/b/140798 [ Release ] accessibility/math-multiscript-attributes.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184720] trunk/Source/WebCore
Title: [184720] trunk/Source/WebCore
Revision 184720
Author cdu...@apple.com
Date 2015-05-21 10:45:21 -0700 (Thu, 21 May 2015)
Log Message
Regression(r179293): We no longer call destroyDecodedData() on CachedResources on memory pressure
https://bugs.webkit.org/show_bug.cgi?id=145270
rdar://problem/20734901
Reviewed by Andreas Kling.
We no longer call destroyDecodedData() on CachedResources on memory
pressure after r179293. In r179293, we started calling
MemoryCache::evictResources() on memory pressure instead of
MemoryCache::pruneToPercentage(0). However, unlike
MemoryCache::pruneToPercentage(), it appears
MemoryCache::evictResources() removes the CachedResources from the
memory cache without calling destroyDecodedData() on them.
This caused a regression on Membuster.
This patch now calls MemoryCache::pruneLiveResourcesToSize(0) on
critical memory pressure, instead of evictResources(). We don't need to
call pruneDeadResourcesToSize(0) here because the non-critical memory
pressure handler already takes care of this.
During local testing, this change seemed to decrease the overall memory
usage of WebProcesses by ~10MB on Membuster (tested on Yosemite).
* platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseNoncriticalMemory):
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/MemoryPressureHandler.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (184719 => 184720)
--- trunk/Source/WebCore/ChangeLog 2015-05-21 17:36:32 UTC (rev 184719)
+++ trunk/Source/WebCore/ChangeLog 2015-05-21 17:45:21 UTC (rev 184720)
@@ -1,3 +1,32 @@
+2015-05-21 Chris Dumez cdu...@apple.com
+
+Regression(r179293): We no longer call destroyDecodedData() on CachedResources on memory pressure
+https://bugs.webkit.org/show_bug.cgi?id=145270
+rdar://problem/20734901
+
+Reviewed by Andreas Kling.
+
+We no longer call destroyDecodedData() on CachedResources on memory
+pressure after r179293. In r179293, we started calling
+MemoryCache::evictResources() on memory pressure instead of
+MemoryCache::pruneToPercentage(0). However, unlike
+MemoryCache::pruneToPercentage(), it appears
+MemoryCache::evictResources() removes the CachedResources from the
+memory cache without calling destroyDecodedData() on them.
+This caused a regression on Membuster.
+
+This patch now calls MemoryCache::pruneLiveResourcesToSize(0) on
+critical memory pressure, instead of evictResources(). We don't need to
+call pruneDeadResourcesToSize(0) here because the non-critical memory
+pressure handler already takes care of this.
+
+During local testing, this change seemed to decrease the overall memory
+usage of WebProcesses by ~10MB on Membuster (tested on Yosemite).
+
+* platform/MemoryPressureHandler.cpp:
+(WebCore::MemoryPressureHandler::releaseNoncriticalMemory):
+(WebCore::MemoryPressureHandler::releaseCriticalMemory):
+
2015-05-21 Said Abou-Hallawa sabouhall...@apple.com
SVG as image uses very tiny default font-size
Modified: trunk/Source/WebCore/platform/MemoryPressureHandler.cpp (184719 => 184720)
--- trunk/Source/WebCore/platform/MemoryPressureHandler.cpp 2015-05-21 17:36:32 UTC (rev 184719)
+++ trunk/Source/WebCore/platform/MemoryPressureHandler.cpp 2015-05-21 17:45:21 UTC (rev 184720)
@@ -95,7 +95,7 @@
}
{
-ReliefLogger log(Evict MemoryCache dead resources);
+ReliefLogger log(Prune MemoryCache dead resources);
MemoryCache::singleton().pruneDeadResourcesToSize(0);
}
}
@@ -110,8 +110,8 @@
}
{
-ReliefLogger log(Evict all MemoryCache resources);
-MemoryCache::singleton().evictResources();
+ReliefLogger log(Prune MemoryCache live resources);
+MemoryCache::singleton().pruneLiveResourcesToSize(0);
}
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184712] trunk/Tools
Title: [184712] trunk/Tools Revision 184712 Author o...@webkit.org Date 2015-05-21 05:28:22 -0700 (Thu, 21 May 2015) Log Message [EFL] Bump libsoup version to 2.50.0 https://bugs.webkit.org/show_bug.cgi?id=145127 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: * efl/patches/soup-clang-warning-fix1.patch: Removed. * efl/patches/soup-clang-warning-fix2.patch: Removed. Modified Paths trunk/Tools/ChangeLog trunk/Tools/efl/jhbuild.modules Removed Paths trunk/Tools/efl/patches/soup-clang-warning-fix1.patch trunk/Tools/efl/patches/soup-clang-warning-fix2.patch Diff Modified: trunk/Tools/ChangeLog (184711 => 184712) --- trunk/Tools/ChangeLog 2015-05-21 10:51:59 UTC (rev 184711) +++ trunk/Tools/ChangeLog 2015-05-21 12:28:22 UTC (rev 184712) @@ -1,3 +1,14 @@ +2015-05-21 Csaba Osztrogonác o...@webkit.org + +[EFL] Bump libsoup version to 2.50.0 +https://bugs.webkit.org/show_bug.cgi?id=145127 + +Reviewed by Gyuyoung Kim. + +* efl/jhbuild.modules: +* efl/patches/soup-clang-warning-fix1.patch: Removed. +* efl/patches/soup-clang-warning-fix2.patch: Removed. + 2015-05-20 Zan Dobersek zdober...@igalia.com [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/ Modified: trunk/Tools/efl/jhbuild.modules (184711 => 184712) --- trunk/Tools/efl/jhbuild.modules 2015-05-21 10:51:59 UTC (rev 184711) +++ trunk/Tools/efl/jhbuild.modules 2015-05-21 12:28:22 UTC (rev 184712) @@ -142,11 +142,9 @@ dep package=glib-networking/ dep package=libxml2/ /dependencies -branch module=/pub/gnome/sources/libsoup/2.42/libsoup-2.42.0.tar.xz version=2.42.0 +branch module=/pub/gnome/sources/libsoup/2.50/libsoup-2.50.0.tar.xz version=2.50.0 repo=ftp.gnome.org -hash=sha256:9e0e7eb5d3f7401ccf521fbc289fc1fa0923b7c7833729e2ed7696f7b848893e - patch file=soup-clang-warning-fix1.patch strip=1/ - patch file=soup-clang-warning-fix2.patch strip=1/ +hash=sha256:1e01365ac4af3817187ea847f9d3588c27eee01fc519a5a7cb212bb78b0f667b /branch /autotools Deleted: trunk/Tools/efl/patches/soup-clang-warning-fix1.patch (184711 => 184712) --- trunk/Tools/efl/patches/soup-clang-warning-fix1.patch 2015-05-21 10:51:59 UTC (rev 184711) +++ trunk/Tools/efl/patches/soup-clang-warning-fix1.patch 2015-05-21 12:28:22 UTC (rev 184712) @@ -1,41 +0,0 @@ -commit 3c96f1977a556b76bc768edeb78497a2e92dd898 -Author: Dan Winship d...@gnome.org -Date: Thu Oct 17 17:56:29 2013 -0400 - -soup-logger: fix -Wformat-nonliteral warnings in clang - -diff --git a/configure.ac b/configure.ac -index f498b96..3759bab 100644 a/configure.ac -+++ b/configure.ac -@@ -340,6 +340,7 @@ if test $GCC = yes -a $set_more_warnings != no; then - -Wall -Wstrict-prototypes -Werror=missing-prototypes \ - -Werror=implicit-function-declaration \ - -Werror=pointer-arith -Werror=init-self -Werror=format=2 \ -+ -Wno-format-zero-length \ - -Werror=missing-include-dirs -Werror=aggregate-return \ - -Werror=declaration-after-statement - fi -diff --git a/libsoup/soup-logger.c b/libsoup/soup-logger.c -index a441f21..34a5576 100644 a/libsoup/soup-logger.c -+++ b/libsoup/soup-logger.c -@@ -374,6 +374,9 @@ soup_logger_detach (SoupLogger *logger, -soup_session_remove_feature (session, SOUP_SESSION_FEATURE (logger)); - } - -+static void soup_logger_print (SoupLogger *logger, SoupLoggerLogLevel level, -+ char direction, const char *format, ...) G_GNUC_PRINTF (4, 5); -+ - static void - soup_logger_print (SoupLogger *logger, SoupLoggerLogLevel level, - char direction, const char *format, ...) -@@ -428,7 +425,7 @@ - *p = '*'; - } - soup_logger_print (logger, SOUP_LOGGER_LOG_HEADERS, '', -- Authorization: Basic [%.*s], len, decoded); -+ Authorization: Basic [%.*s], (int)len, decoded); - g_free (decoded); - } - Deleted: trunk/Tools/efl/patches/soup-clang-warning-fix2.patch (184711 => 184712) --- trunk/Tools/efl/patches/soup-clang-warning-fix2.patch 2015-05-21 10:51:59 UTC (rev 184711) +++ trunk/Tools/efl/patches/soup-clang-warning-fix2.patch 2015-05-21 12:28:22 UTC (rev 184712) @@ -1,65 +0,0 @@ -commit c2c2ecbf7d021bb5445a205ec8c66286afaf1008 -Author: Ryan Lortie de...@desrt.ca -Date: Sun Dec 8 15:41:56 2013 -0500 - -fix up non-literal format string issues - -Fix up a couple of errors picked up by -Werror=format-nonliteral on -clang. - -https://bugzilla.gnome.org/show_bug.cgi?id=720082 - -diff --git a/libsoup/soup-xmlrpc.c b/libsoup/soup-xmlrpc.c -index 8d711d3..e289010 100644 a/libsoup/soup-xmlrpc.c -+++ b/libsoup/soup-xmlrpc.c -@@ -290,6 +290,11 @@ soup_xmlrpc_build_method_response (GValue *value) - } - - static char * -+soup_xmlrpc_build_faultv (int fault_code, -+ const char *fault_format, -+ va_list args) G_GNUC_PRINTF (2, 0); -+ -+static char * -
[webkit-changes] [184713] trunk/Source/JavaScriptCore
Title: [184713] trunk/Source/_javascript_Core
Revision 184713
Author o...@webkit.org
Date 2015-05-21 05:29:43 -0700 (Thu, 21 May 2015)
Log Message
Fix the !ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) build after r184337
https://bugs.webkit.org/show_bug.cgi?id=145248
Reviewed by Yusuke Suzuki.
* bytecompiler/BytecodeGenerator.cpp:
* bytecompiler/BytecodeGenerator.h:
* parser/Parser.cpp:
(JSC::ParserLexerType::parseMemberExpression):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/parser/Parser.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (184712 => 184713)
--- trunk/Source/_javascript_Core/ChangeLog 2015-05-21 12:28:22 UTC (rev 184712)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-05-21 12:29:43 UTC (rev 184713)
@@ -1,3 +1,15 @@
+2015-05-21 Csaba Osztrogonác o...@webkit.org
+
+Fix the !ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) build after r184337
+https://bugs.webkit.org/show_bug.cgi?id=145248
+
+Reviewed by Yusuke Suzuki.
+
+* bytecompiler/BytecodeGenerator.cpp:
+* bytecompiler/BytecodeGenerator.h:
+* parser/Parser.cpp:
+(JSC::ParserLexerType::parseMemberExpression):
+
2015-05-20 Joseph Pecoraro pecor...@apple.com
Web Inspector: array previews should have a much smaller cap on values
Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp (184712 => 184713)
--- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2015-05-21 12:28:22 UTC (rev 184712)
+++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2015-05-21 12:29:43 UTC (rev 184713)
@@ -2808,6 +2808,7 @@
emitLabel(loopDone.get());
}
+#if ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX)
RegisterID* BytecodeGenerator::emitGetTemplateObject(RegisterID* dst, TaggedTemplateNode* taggedTemplate)
{
TemplateRegistryKey::StringVector rawStrings;
@@ -2834,6 +2835,7 @@
emitLoad(arguments.thisRegister(), JSValue(addTemplateRegistryKeyConstant(TemplateRegistryKey(rawStrings, cookedStrings;
return emitCall(dst, getTemplateObject.get(), NoExpectedFunction, arguments, taggedTemplate-divot(), taggedTemplate-divotStart(), taggedTemplate-divotEnd());
}
+#endif
RegisterID* BytecodeGenerator::emitGetEnumerableLength(RegisterID* dst, RegisterID* base)
{
Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h (184712 => 184713)
--- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h 2015-05-21 12:28:22 UTC (rev 184712)
+++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h 2015-05-21 12:29:43 UTC (rev 184713)
@@ -503,8 +503,11 @@
RegisterID* valueRegister, RegisterID* getterRegister, RegisterID* setterRegister, unsigned options, const JSTextPosition);
void emitEnumeration(ThrowableExpressionData* enumerationNode, ExpressionNode* subjectNode, const std::functionvoid(BytecodeGenerator, RegisterID*) callBack);
+
+#if ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX)
RegisterID* emitGetTemplateObject(RegisterID* dst, TaggedTemplateNode*);
-
+#endif
+
RegisterID* emitReturn(RegisterID* src);
RegisterID* emitEnd(RegisterID* src) { return emitUnaryNoDstOp(op_end, src); }
Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (184712 => 184713)
--- trunk/Source/_javascript_Core/parser/Parser.cpp 2015-05-21 12:28:22 UTC (rev 184712)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp 2015-05-21 12:29:43 UTC (rev 184713)
@@ -2611,6 +2611,7 @@
next();
break;
}
+#if ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX)
case TEMPLATE: {
semanticFailIfTrue(baseIsSuper, Cannot use super as tag for tagged templates);
JSTextPosition expressionEnd = lastTokenEndPosition();
@@ -2621,6 +2622,7 @@
m_nonLHSCount = nonLHSCount;
break;
}
+#endif
default:
goto endMemberExpression;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184732] branches/safari-601.1.32-branch/Source/WebCore
Title: [184732] branches/safari-601.1.32-branch/Source/WebCore
Revision 184732
Author bshaf...@apple.com
Date 2015-05-21 13:26:45 -0700 (Thu, 21 May 2015)
Log Message
Merged r184728. rdar://problem/21051039
Modified Paths
branches/safari-601.1.32-branch/Source/WebCore/ChangeLog
branches/safari-601.1.32-branch/Source/WebCore/platform/ScrollAnimator.cpp
branches/safari-601.1.32-branch/Source/WebCore/platform/ScrollAnimator.h
branches/safari-601.1.32-branch/Source/WebCore/platform/cocoa/ScrollController.h
branches/safari-601.1.32-branch/Source/WebCore/platform/cocoa/ScrollController.mm
branches/safari-601.1.32-branch/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: branches/safari-601.1.32-branch/Source/WebCore/ChangeLog (184731 => 184732)
--- branches/safari-601.1.32-branch/Source/WebCore/ChangeLog 2015-05-21 19:53:48 UTC (rev 184731)
+++ branches/safari-601.1.32-branch/Source/WebCore/ChangeLog 2015-05-21 20:26:45 UTC (rev 184732)
@@ -1,3 +1,39 @@
+2015-05-21 Babak Shafiei bshaf...@apple.com
+
+Merge r184728.
+
+2015-05-21 Brent Fulgham bfulg...@apple.com
+
+Scroll-snap points needs to be updated during programmatic scrolls
+https://bugs.webkit.org/show_bug.cgi?id=145216
+rdar://problem/21051039
+
+Reviewed by Dean Jackson.
+
+Whenever we adjust the current scroll position, make sure we also update the current
+active scroll snap offset index (if applicable).
+
+* platform/ScrollAnimator.cpp:
+(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Call the new 'updateActiveScrollSnapIndexForOffset'
+method after moving to a new position.
+(WebCore::ScrollAnimator::setCurrentPosition): Ditto.
+(WebCore::ScrollAnimator::updateActiveScrollSnapIndexForOffset): New method. Asks the scroll controller to
+identify the closest scroll snap offset index. If it finds something relevant, update the ScrollableArea state
+to track these new values.
+* platform/ScrollAnimator.h:
+* platform/cocoa/ScrollController.h:
+(WebCore::ScrollController::activeScrollSnapIndexDidChange):
+(WebCore::ScrollController::setScrollSnapIndexDidChange):
+* platform/cocoa/ScrollController.mm:
+(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset): Added. Find the closest relevant scroll snap offset
+index for the given scroll offset, and update the internal scroll snap state to reflect it.
+(WebCore::ScrollController::setActiveScrollSnapIndicesForOffset): Given the x and y offset for a scroll,
+set the relevant scroll snap offset indices.
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::immediateScrollTo): Call the new 'updateActiveScrollSnapIndexForOffset' method
+after moving to a new position.
+(WebCore::ScrollAnimatorMac::immediateScrollBy): Ditto.
+
2015-05-20 Babak Shafiei bshaf...@apple.com
Merge r184596.
Modified: branches/safari-601.1.32-branch/Source/WebCore/platform/ScrollAnimator.cpp (184731 => 184732)
--- branches/safari-601.1.32-branch/Source/WebCore/platform/ScrollAnimator.cpp 2015-05-21 19:53:48 UTC (rev 184731)
+++ branches/safari-601.1.32-branch/Source/WebCore/platform/ScrollAnimator.cpp 2015-05-21 20:26:45 UTC (rev 184732)
@@ -80,6 +80,7 @@
m_currentPosX = offset.x();
m_currentPosY = offset.y();
notifyPositionChanged(delta);
+updateActiveScrollSnapIndexForOffset();
}
#if ENABLE(CSS_SCROLL_SNAP) PLATFORM(MAC)
@@ -168,6 +169,7 @@
{
m_currentPosX = position.x();
m_currentPosY = position.y();
+updateActiveScrollSnapIndexForOffset();
}
FloatPoint ScrollAnimator::currentPosition() const
@@ -175,6 +177,17 @@
return FloatPoint(m_currentPosX, m_currentPosY);
}
+void ScrollAnimator::updateActiveScrollSnapIndexForOffset()
+{
+#if ENABLE(CSS_SCROLL_SNAP) PLATFORM(MAC)
+m_scrollController.setActiveScrollSnapIndicesForOffset(m_currentPosX, m_currentPosY);
+if (m_scrollController.activeScrollSnapIndexDidChange()) {
+m_scrollableArea.setCurrentHorizontalSnapPointIndex(m_scrollController.activeScrollSnapIndexForAxis(ScrollEventAxis::Horizontal));
+m_scrollableArea.setCurrentVerticalSnapPointIndex(m_scrollController.activeScrollSnapIndexForAxis(ScrollEventAxis::Vertical));
+}
+#endif
+}
+
void ScrollAnimator::notifyPositionChanged(const FloatSize delta)
{
UNUSED_PARAM(delta);
Modified: branches/safari-601.1.32-branch/Source/WebCore/platform/ScrollAnimator.h (184731 => 184732)
--- branches/safari-601.1.32-branch/Source/WebCore/platform/ScrollAnimator.h 2015-05-21 19:53:48 UTC (rev 184731)
+++ branches/safari-601.1.32-branch/Source/WebCore/platform/ScrollAnimator.h 2015-05-21 20:26:45 UTC (rev 184732)
@@ -137,6 +137,7 @@
protected:
[webkit-changes] [184733] branches/safari-601.1.32.2-branch/Source/WebCore
Title: [184733] branches/safari-601.1.32.2-branch/Source/WebCore
Revision 184733
Author bshaf...@apple.com
Date 2015-05-21 13:27:43 -0700 (Thu, 21 May 2015)
Log Message
Merged r184728. rdar://problem/21051039
Modified Paths
branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog
branches/safari-601.1.32.2-branch/Source/WebCore/platform/ScrollAnimator.cpp
branches/safari-601.1.32.2-branch/Source/WebCore/platform/ScrollAnimator.h
branches/safari-601.1.32.2-branch/Source/WebCore/platform/cocoa/ScrollController.h
branches/safari-601.1.32.2-branch/Source/WebCore/platform/cocoa/ScrollController.mm
branches/safari-601.1.32.2-branch/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog (184732 => 184733)
--- branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog 2015-05-21 20:26:45 UTC (rev 184732)
+++ branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog 2015-05-21 20:27:43 UTC (rev 184733)
@@ -1,3 +1,39 @@
+2015-05-21 Babak Shafiei bshaf...@apple.com
+
+Merge r184728.
+
+2015-05-21 Brent Fulgham bfulg...@apple.com
+
+Scroll-snap points needs to be updated during programmatic scrolls
+https://bugs.webkit.org/show_bug.cgi?id=145216
+rdar://problem/21051039
+
+Reviewed by Dean Jackson.
+
+Whenever we adjust the current scroll position, make sure we also update the current
+active scroll snap offset index (if applicable).
+
+* platform/ScrollAnimator.cpp:
+(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Call the new 'updateActiveScrollSnapIndexForOffset'
+method after moving to a new position.
+(WebCore::ScrollAnimator::setCurrentPosition): Ditto.
+(WebCore::ScrollAnimator::updateActiveScrollSnapIndexForOffset): New method. Asks the scroll controller to
+identify the closest scroll snap offset index. If it finds something relevant, update the ScrollableArea state
+to track these new values.
+* platform/ScrollAnimator.h:
+* platform/cocoa/ScrollController.h:
+(WebCore::ScrollController::activeScrollSnapIndexDidChange):
+(WebCore::ScrollController::setScrollSnapIndexDidChange):
+* platform/cocoa/ScrollController.mm:
+(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset): Added. Find the closest relevant scroll snap offset
+index for the given scroll offset, and update the internal scroll snap state to reflect it.
+(WebCore::ScrollController::setActiveScrollSnapIndicesForOffset): Given the x and y offset for a scroll,
+set the relevant scroll snap offset indices.
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::immediateScrollTo): Call the new 'updateActiveScrollSnapIndexForOffset' method
+after moving to a new position.
+(WebCore::ScrollAnimatorMac::immediateScrollBy): Ditto.
+
2015-05-20 Babak Shafiei bshaf...@apple.com
Merge r184308.
Modified: branches/safari-601.1.32.2-branch/Source/WebCore/platform/ScrollAnimator.cpp (184732 => 184733)
--- branches/safari-601.1.32.2-branch/Source/WebCore/platform/ScrollAnimator.cpp 2015-05-21 20:26:45 UTC (rev 184732)
+++ branches/safari-601.1.32.2-branch/Source/WebCore/platform/ScrollAnimator.cpp 2015-05-21 20:27:43 UTC (rev 184733)
@@ -80,6 +80,7 @@
m_currentPosX = offset.x();
m_currentPosY = offset.y();
notifyPositionChanged(delta);
+updateActiveScrollSnapIndexForOffset();
}
#if ENABLE(CSS_SCROLL_SNAP) PLATFORM(MAC)
@@ -168,6 +169,7 @@
{
m_currentPosX = position.x();
m_currentPosY = position.y();
+updateActiveScrollSnapIndexForOffset();
}
FloatPoint ScrollAnimator::currentPosition() const
@@ -175,6 +177,17 @@
return FloatPoint(m_currentPosX, m_currentPosY);
}
+void ScrollAnimator::updateActiveScrollSnapIndexForOffset()
+{
+#if ENABLE(CSS_SCROLL_SNAP) PLATFORM(MAC)
+m_scrollController.setActiveScrollSnapIndicesForOffset(m_currentPosX, m_currentPosY);
+if (m_scrollController.activeScrollSnapIndexDidChange()) {
+m_scrollableArea.setCurrentHorizontalSnapPointIndex(m_scrollController.activeScrollSnapIndexForAxis(ScrollEventAxis::Horizontal));
+m_scrollableArea.setCurrentVerticalSnapPointIndex(m_scrollController.activeScrollSnapIndexForAxis(ScrollEventAxis::Vertical));
+}
+#endif
+}
+
void ScrollAnimator::notifyPositionChanged(const FloatSize delta)
{
UNUSED_PARAM(delta);
Modified: branches/safari-601.1.32.2-branch/Source/WebCore/platform/ScrollAnimator.h (184732 => 184733)
--- branches/safari-601.1.32.2-branch/Source/WebCore/platform/ScrollAnimator.h 2015-05-21 20:26:45 UTC (rev 184732)
+++ branches/safari-601.1.32.2-branch/Source/WebCore/platform/ScrollAnimator.h 2015-05-21 20:27:43 UTC (rev 184733)
@@ -137,6
[webkit-changes] [184711] trunk/Source/WebKit2
Title: [184711] trunk/Source/WebKit2
Revision 184711
Author o...@webkit.org
Date 2015-05-21 03:51:59 -0700 (Thu, 21 May 2015)
Log Message
[EFL] Remove an unused private field from EwkPopupMenuItem class
https://bugs.webkit.org/show_bug.cgi?id=145249
Reviewed by Gyuyoung Kim.
* UIProcess/API/efl/ewk_popup_menu.cpp:
(EwkPopupMenu::EwkPopupMenu):
* UIProcess/API/efl/ewk_popup_menu_private.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_private.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (184710 => 184711)
--- trunk/Source/WebKit2/ChangeLog 2015-05-21 09:27:07 UTC (rev 184710)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-21 10:51:59 UTC (rev 184711)
@@ -1,5 +1,16 @@
2015-05-21 Csaba Osztrogonác o...@webkit.org
+[EFL] Remove an unused private field from EwkPopupMenuItem class
+https://bugs.webkit.org/show_bug.cgi?id=145249
+
+Reviewed by Gyuyoung Kim.
+
+* UIProcess/API/efl/ewk_popup_menu.cpp:
+(EwkPopupMenu::EwkPopupMenu):
+* UIProcess/API/efl/ewk_popup_menu_private.h:
+
+2015-05-21 Csaba Osztrogonác o...@webkit.org
+
[EFL] Fix mismatched-tags warnings in UIProcess/API/efl
https://bugs.webkit.org/show_bug.cgi?id=145129
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu.cpp (184710 => 184711)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu.cpp 2015-05-21 09:27:07 UTC (rev 184710)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu.cpp 2015-05-21 10:51:59 UTC (rev 184711)
@@ -34,9 +34,8 @@
#include ewk_popup_menu_item_private.h
#include ewk_popup_menu_private.h
-EwkPopupMenu::EwkPopupMenu(EwkView* view, WKPopupMenuListenerRef popupMenuListener, WKArrayRef items, unsigned selectedIndex)
-: m_view(view)
-, m_popupMenuListener(popupMenuListener)
+EwkPopupMenu::EwkPopupMenu(EwkView*, WKPopupMenuListenerRef popupMenuListener, WKArrayRef items, unsigned selectedIndex)
+: m_popupMenuListener(popupMenuListener)
, m_popupMenuItems(0)
, m_selectedIndex(selectedIndex)
{
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_private.h (184710 => 184711)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_private.h 2015-05-21 09:27:07 UTC (rev 184710)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_private.h 2015-05-21 10:51:59 UTC (rev 184711)
@@ -45,7 +45,6 @@
unsigned selectedIndex() const;
private:
-EwkView* m_view;
WKRetainPtrWKPopupMenuListenerRef m_popupMenuListener;
Eina_List* m_popupMenuItems;
unsigned m_selectedIndex;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184714] branches/safari-601.1.32.2-branch
Title: [184714] branches/safari-601.1.32.2-branch
Revision 184714
Author bshaf...@apple.com
Date 2015-05-21 08:24:21 -0700 (Thu, 21 May 2015)
Log Message
Merged r184308. rdar://problem/20895753
Modified Paths
branches/safari-601.1.32.2-branch/LayoutTests/ChangeLog
branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog
branches/safari-601.1.32.2-branch/Source/WebCore/editing/EditingStyle.cpp
branches/safari-601.1.32.2-branch/Source/WebCore/editing/EditingStyle.h
branches/safari-601.1.32.2-branch/Source/WebCore/editing/Editor.cpp
Added Paths
branches/safari-601.1.32.2-branch/LayoutTests/editing/style/underline-by-user-expected.txt
branches/safari-601.1.32.2-branch/LayoutTests/editing/style/underline-by-user.html
Diff
Modified: branches/safari-601.1.32.2-branch/LayoutTests/ChangeLog (184713 => 184714)
--- branches/safari-601.1.32.2-branch/LayoutTests/ChangeLog 2015-05-21 12:29:43 UTC (rev 184713)
+++ branches/safari-601.1.32.2-branch/LayoutTests/ChangeLog 2015-05-21 15:24:21 UTC (rev 184714)
@@ -1,3 +1,21 @@
+2015-05-20 Babak Shafiei bshaf...@apple.com
+
+Merge r184308.
+
+2015-05-13 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION(r183770): Crash inside WebEditorClient::shouldApplyStyle when applying underline
+https://bugs.webkit.org/show_bug.cgi?id=144949
+
+Reviewed by Darin Adler.
+
+Added a test that emulates underlining of text by the user. Unlike document.execCommand,
+testRunner.execCommand simulates a user initiated editing command and therefore invokes
+shouldApplyStyle.
+
+* editing/style/underline-by-user-expected.txt: Added.
+* editing/style/underline-by-user.html: Added.
+
2015-05-18 Matthew Hanson matthew_han...@apple.com
Merge r184510. rdar://problem/21004989
Copied: branches/safari-601.1.32.2-branch/LayoutTests/editing/style/underline-by-user-expected.txt (from rev 184308, trunk/LayoutTests/editing/style/underline-by-user-expected.txt) (0 => 184714)
--- branches/safari-601.1.32.2-branch/LayoutTests/editing/style/underline-by-user-expected.txt (rev 0)
+++ branches/safari-601.1.32.2-branch/LayoutTests/editing/style/underline-by-user-expected.txt 2015-05-21 15:24:21 UTC (rev 184714)
@@ -0,0 +1,3 @@
+This tests user initialized underlining of text. To manually test, underline hello below. WebKit should not crash.
+
+hello
Copied: branches/safari-601.1.32.2-branch/LayoutTests/editing/style/underline-by-user.html (from rev 184308, trunk/LayoutTests/editing/style/underline-by-user.html) (0 => 184714)
--- branches/safari-601.1.32.2-branch/LayoutTests/editing/style/underline-by-user.html (rev 0)
+++ branches/safari-601.1.32.2-branch/LayoutTests/editing/style/underline-by-user.html 2015-05-21 15:24:21 UTC (rev 184714)
@@ -0,0 +1,15 @@
+!DOCTYPE html
+html
+body
+pThis tests user initialized underlining of text. To manually test, underline hello below. WebKit should not crash./p
+div id=editor contenteditablehello/div
+script
+document.getElementById('editor').focus();
+document.execCommand('selectAll', false, null);
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.execCommand('underline', false, null);
+}
+/script
+/body
+/html
Modified: branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog (184713 => 184714)
--- branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog 2015-05-21 12:29:43 UTC (rev 184713)
+++ branches/safari-601.1.32.2-branch/Source/WebCore/ChangeLog 2015-05-21 15:24:21 UTC (rev 184714)
@@ -1,3 +1,34 @@
+2015-05-20 Babak Shafiei bshaf...@apple.com
+
+Merge r184308.
+
+2015-05-13 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION(r183770): Crash inside WebEditorClient::shouldApplyStyle when applying underline
+https://bugs.webkit.org/show_bug.cgi?id=144949
+rdar://problem/20895753
+
+Reviewed by Darin Adler.
+
+The crash was caused by the variant of applyStyleToSelection that takes EditingStyle passing
+a null pointer to shouldApplyStyle when we're only applying text decoration changes so that
+m_mutableStyle in the editing style is null. This didn't reproduce in execCommand since we
+wouldn't call shouldApplyStyle in that case. It didn't reproduce in my manual testing because
+font panel also sets text shadow, which ends up filling up m_mutableStyle.
+
+Fixed the bug by creating a mutable style properties when one is not provided by EditingStyle.
+Also fixed the FIXME in the function by converting text decoration changes to a corresponding
+text decoration value. The values passed to shouldApplyStyle now matches the old behavior prior
+to r183770.
+
+Test: editing/style/underline-by-user.html
+
+* editing/EditingStyle.cpp:
+
[webkit-changes] [184734] trunk/Source/WebCore
Title: [184734] trunk/Source/WebCore Revision 184734 Author jacob_niel...@apple.com Date 2015-05-21 15:45:13 -0700 (Thu, 21 May 2015) Log Message r184718 and r184725 caused four tests to begin crashing Unreviewed rollback. Tests that started crashing: svg/carto.net/textbox.svg svg/custom/tref-clone-crash.html svg/custom/use-animation-in-fill.html svg/custom/use-multiple-on-nested-disallowed-font.html * svg/SVGAnimateElementBase.cpp: (WebCore::propertyTypesAreConsistent): * svg/SVGAnimatedPath.cpp: (WebCore::SVGAnimatedPathAnimator::startAnimValAnimation): * svg/SVGAnimatedTypeAnimator.h: (WebCore::SVGAnimatedTypeAnimator::executeAction): * svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseAttribute): * svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): (WebCore::SVGCursorElement::isSupportedAttribute): * svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::pauseAnimations): (WebCore::SVGDocumentExtensions::unpauseAnimations): (WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): (WebCore::SVGDocumentExtensions::isElementWithPendingResources): (WebCore::SVGDocumentExtensions::removeElementFromPendingResources): (WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement): (WebCore::SVGDocumentExtensions::rebuildElements): * svg/SVGElement.cpp: (WebCore::populateAttributeNameToCSSPropertyIDMap): (WebCore::populateAttributeNameToAnimatedPropertyTypeMap): (WebCore::attributeNameToAnimatedPropertyTypeMap): (WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap): (WebCore::cssPropertyWithSVGDOMNameToAnimatedPropertyTypeMap): (WebCore::hasLoadListener): * svg/SVGFontData.cpp: (WebCore::SVGFontData::applySVGGlyphSelection): * svg/SVGFontElement.cpp: (WebCore::SVGFontElement::registerLigaturesInGlyphCache): (WebCore::SVGKerningMap::insert): (WebCore::stringMatchesUnicodeRange): * svg/SVGPathByteStream.h: (WebCore::SVGPathByteStream::begin): (WebCore::SVGPathByteStream::end): (WebCore::SVGPathByteStream::append): (WebCore::SVGPathByteStream::clear): (WebCore::SVGPathByteStream::isEmpty): * svg/SVGPathUtilities.cpp: (WebCore::appendSVGPathByteStreamFromSVGPathSeg): * svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::setElapsed): (WebCore::SMILTimeContainer::updateAnimations): * svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::parseBeginOrEnd): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::disconnectConditions): (WebCore::SVGSMILElement::notifyDependentsIntervalChanged): (WebCore::SVGSMILElement::createInstanceTimesFromSyncbase): * svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::clearResultsRecursive): * svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::addBuiltinEffects): * svg/properties/SVGAnimatedProperty.cpp: (WebCore::SVGAnimatedProperty::~SVGAnimatedProperty): * svg/properties/SVGListProperty.h: (WebCore::SVGListProperty::detachListWrappersAndResize): * svg/properties/SVGPathSegListPropertyTearOff.cpp: (WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/SVGAnimateElementBase.cpp trunk/Source/WebCore/svg/SVGAnimatedPath.cpp trunk/Source/WebCore/svg/SVGAnimatedTypeAnimator.h trunk/Source/WebCore/svg/SVGAnimationElement.cpp trunk/Source/WebCore/svg/SVGCursorElement.cpp trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp trunk/Source/WebCore/svg/SVGElement.cpp trunk/Source/WebCore/svg/SVGFontData.cpp trunk/Source/WebCore/svg/SVGFontElement.cpp trunk/Source/WebCore/svg/SVGPathByteStream.h trunk/Source/WebCore/svg/SVGPathUtilities.cpp trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h trunk/Source/WebCore/svg/properties/SVGAnimatedProperty.cpp trunk/Source/WebCore/svg/properties/SVGListProperty.h trunk/Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (184733 => 184734) --- trunk/Source/WebCore/ChangeLog 2015-05-21 20:27:43 UTC (rev 184733) +++ trunk/Source/WebCore/ChangeLog 2015-05-21 22:45:13 UTC (rev 184734) @@ -1,3 +1,73 @@ +2015-05-21 Jake Nielsen jacob_niel...@apple.com + +r184718 and r184725 caused four tests to begin crashing + +Unreviewed rollback. + +Tests that started crashing: + +svg/carto.net/textbox.svg svg/custom/tref-clone-crash.html svg/custom/use-animation-in-fill.html svg/custom/use-multiple-on-nested-disallowed-font.html + +* svg/SVGAnimateElementBase.cpp: +(WebCore::propertyTypesAreConsistent): +* svg/SVGAnimatedPath.cpp: +(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation): +* svg/SVGAnimatedTypeAnimator.h: +(WebCore::SVGAnimatedTypeAnimator::executeAction): +*
[webkit-changes] [184736] trunk/Source/WebInspectorUI
Title: [184736] trunk/Source/WebInspectorUI Revision 184736 Author joep...@webkit.org Date 2015-05-21 16:33:42 -0700 (Thu, 21 May 2015) Log Message Web Inspector: Improve the UI of the type profiler popover https://bugs.webkit.org/show_bug.cgi?id=140737 Reviewed by Timothy Hatcher. Display TypeDescriptions in a Tree similiar to ObjectTrees. Currently the only information we have in a TypeDescription is the property names, and not their types, so all we can display in the tree are names. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Controllers/TypeTokenAnnotator.js: (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken): * UserInterface/Main.html: * UserInterface/Models/ScriptSyntaxTree.js: (WebInspector.ScriptSyntaxTree.prototype.updateTypes): * UserInterface/Models/StructureDescription.js: Added. (WebInspector.StructureDescription): (WebInspector.StructureDescription.fromPayload): (WebInspector.StructureDescription.prototype.get fields): (WebInspector.StructureDescription.prototype.get optionalFields): (WebInspector.StructureDescription.prototype.get constructorName): (WebInspector.StructureDescription.prototype.get prototypeStructure): (WebInspector.StructureDescription.prototype.get imprecise): * UserInterface/Models/TypeDescription.js: Added. (WebInspector.TypeDescription): (WebInspector.TypeDescription.fromPayload): (WebInspector.TypeDescription.prototype.get leastCommonAncestor): (WebInspector.TypeDescription.prototype.get typeSet): (WebInspector.TypeDescription.prototype.get structures): (WebInspector.TypeDescription.prototype.get valid): (WebInspector.TypeDescription.prototype.get truncated): * UserInterface/Models/TypeSet.js: (WebInspector.TypeSet): (WebInspector.TypeSet.prototype.get primitiveTypeNames): * UserInterface/Views/ObjectTreeView.js: (WebInspector.ObjectTreeView.prototype._updateChildren): * UserInterface/Views/Section.css: Removed. * UserInterface/Views/Section.js: Removed. * UserInterface/Views/SourceCodeTextEditor.css: (.popover .expandable): * UserInterface/Views/SourceCodeTextEditor.js: (WebInspector.SourceCodeTextEditor): (WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes): (WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent): (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler): (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation): (WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject): * UserInterface/Views/TypePropertiesSection.js: Removed. * UserInterface/Views/TypeTokenView.js: (WebInspector.TypeTokenView): (WebInspector.TypeTokenView.titleForPopover): (WebInspector.TypeTokenView.prototype.update): (WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers): (WebInspector.TypeTokenView.prototype._shouldShowPopover): (WebInspector.TypeTokenView.prototype._displayTypeName): * UserInterface/Views/TypeTreeElement.css: Added. (.type-tree-element): (.type-tree-element .titles): (.type-tree-element .disclosure-button): (.type-tree-element.parent .disclosure-button): (.type-tree-element.parent.expanded .disclosure-button): (.type-tree-element .icon): (.type-tree-element.prototype): (.type-tree-element.prototype:focus): (.type-tree-element.prototype + ol): * UserInterface/Views/TypeTreeElement.js: Added. (WebInspector.TypeTreeElement): (WebInspector.TypeTreeElement.prototype.get name): (WebInspector.TypeTreeElement.prototype.get isPrototype): (WebInspector.TypeTreeElement.prototype.onpopulate): (WebInspector.TypeTreeElement.prototype.onexpand): * UserInterface/Views/TypeTreeView.css: Renamed from Source/WebInspectorUI/UserInterface/Views/PropertiesSection.js. (.type-tree): (.type-tree-outline): (.type-tree-outline li): (.type-tree-outline ol): (.type-tree-outline ol.expanded): (.type-tree-outline li .empty-message): * UserInterface/Views/TypeTreeView.js: Added. (WebInspector.TypeTreeView): (WebInspector.TypeTreeView.prototype.get typeDescription): (WebInspector.TypeTreeView.prototype.get element): (WebInspector.TypeTreeView.prototype.get treeOutline): (WebInspector.TypeTreeView.prototype._populate): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Controllers/TypeTokenAnnotator.js trunk/Source/WebInspectorUI/UserInterface/Main.html trunk/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js trunk/Source/WebInspectorUI/UserInterface/Models/TypeSet.js trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js trunk/Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js Added Paths trunk/Source/WebInspectorUI/UserInterface/Models/StructureDescription.js
[webkit-changes] [184735] tags/Safari-600.7.9/
Title: [184735] tags/Safari-600.7.9/ Revision 184735 Author bshaf...@apple.com Date 2015-05-21 16:30:15 -0700 (Thu, 21 May 2015) Log Message New tag. Added Paths tags/Safari-600.7.9/ Diff Property changes: tags/Safari-600.7.9 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184740] trunk/Source
Title: [184740] trunk/Source
Revision 184740
Author dba...@webkit.org
Date 2015-05-21 17:34:12 -0700 (Thu, 21 May 2015)
Log Message
Rollout http://trac.webkit.org/changeset/183909
(https://bugs.webkit.org/show_bug.cgi?id=144657)
Revert http://trac.webkit.org/changeset/183909 since pausing the database
thread prevents in-progress transactions from completing. We need to think
about this change some more.
Source/WebCore:
* Modules/webdatabase/AbstractDatabaseServer.h:
* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::setPauseAllDatabases): Deleted.
* Modules/webdatabase/DatabaseManager.h:
* Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::setPauseAllDatabases): Deleted.
* Modules/webdatabase/DatabaseServer.h:
Source/WebKit2:
* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _applicationDidEnterBackground:]): Deleted.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationDidEnterBackground): Deleted.
* WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::setPauseAllDatabases): Deleted.
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationWillEnterForeground): Deleted.
(WebKit::WebPage::applicationDidEnterBackground): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h
trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp
trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h
trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.cpp
trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm
trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebDatabaseManager.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebDatabaseManager.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (184739 => 184740)
--- trunk/Source/WebCore/ChangeLog 2015-05-22 00:31:07 UTC (rev 184739)
+++ trunk/Source/WebCore/ChangeLog 2015-05-22 00:34:12 UTC (rev 184740)
@@ -1,3 +1,20 @@
+2015-05-21 Daniel Bates daba...@apple.com
+
+Rollout http://trac.webkit.org/changeset/183909
+(https://bugs.webkit.org/show_bug.cgi?id=144657)
+
+Revert http://trac.webkit.org/changeset/183909 since pausing the database
+thread prevents in-progress transactions from completing. We need to think
+about this change some more.
+
+* Modules/webdatabase/AbstractDatabaseServer.h:
+* Modules/webdatabase/DatabaseManager.cpp:
+(WebCore::DatabaseManager::setPauseAllDatabases): Deleted.
+* Modules/webdatabase/DatabaseManager.h:
+* Modules/webdatabase/DatabaseServer.cpp:
+(WebCore::DatabaseServer::setPauseAllDatabases): Deleted.
+* Modules/webdatabase/DatabaseServer.h:
+
2015-05-21 Jake Nielsen jacob_niel...@apple.com
r184718 and r184725 caused four tests to begin crashing
Modified: trunk/Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h (184739 => 184740)
--- trunk/Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h 2015-05-22 00:31:07 UTC (rev 184739)
+++ trunk/Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h 2015-05-22 00:34:12 UTC (rev 184740)
@@ -73,8 +73,6 @@
virtual bool deleteOrigin(SecurityOrigin*) = 0;
virtual bool deleteDatabase(SecurityOrigin*, const String name) = 0;
-virtual void setPauseAllDatabases(bool) = 0;
-
virtual void interruptAllDatabasesForContext(const DatabaseContext*) = 0;
protected:
Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp (184739 => 184740)
--- trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp 2015-05-22 00:31:07 UTC (rev 184739)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp 2015-05-22 00:34:12 UTC (rev 184740)
@@ -397,11 +397,6 @@
return m_server-deleteDatabase(origin, name);
}
-void DatabaseManager::setPauseAllDatabases(bool pauseAllDatabases)
-{
-m_server-setPauseAllDatabases(pauseAllDatabases);
-}
-
void DatabaseManager::closeAllDatabases()
{
m_server-closeAllDatabases();
Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h (184739 => 184740)
--- trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h 2015-05-22 00:31:07 UTC (rev 184739)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h 2015-05-22 00:34:12 UTC (rev 184740)
@@ -106,8 +106,6 @@
WEBCORE_EXPORT bool deleteOrigin(SecurityOrigin*);
WEBCORE_EXPORT bool deleteDatabase(SecurityOrigin*, const String name);
[webkit-changes] [184743] tags/Safari-601.1.32.2.80/Source
Title: [184743] tags/Safari-601.1.32.2.80/Source Revision 184743 Author bshaf...@apple.com Date 2015-05-21 17:41:52 -0700 (Thu, 21 May 2015) Log Message Versioning. Modified Paths tags/Safari-601.1.32.2.80/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-601.1.32.2.80/Source/WebCore/Configurations/Version.xcconfig tags/Safari-601.1.32.2.80/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-601.1.32.2.80/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-601.1.32.2.80/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-601.1.32.2.80/Source/_javascript_Core/Configurations/Version.xcconfig (184742 => 184743) --- tags/Safari-601.1.32.2.80/Source/_javascript_Core/Configurations/Version.xcconfig 2015-05-22 00:39:57 UTC (rev 184742) +++ tags/Safari-601.1.32.2.80/Source/_javascript_Core/Configurations/Version.xcconfig 2015-05-22 00:41:52 UTC (rev 184743) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 32; MICRO_VERSION = 2; -NANO_VERSION = 5; +NANO_VERSION = 80; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-601.1.32.2.80/Source/WebCore/Configurations/Version.xcconfig (184742 => 184743) --- tags/Safari-601.1.32.2.80/Source/WebCore/Configurations/Version.xcconfig 2015-05-22 00:39:57 UTC (rev 184742) +++ tags/Safari-601.1.32.2.80/Source/WebCore/Configurations/Version.xcconfig 2015-05-22 00:41:52 UTC (rev 184743) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 32; MICRO_VERSION = 2; -NANO_VERSION = 5; +NANO_VERSION = 80; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-601.1.32.2.80/Source/WebInspectorUI/Configurations/Version.xcconfig (184742 => 184743) --- tags/Safari-601.1.32.2.80/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-05-22 00:39:57 UTC (rev 184742) +++ tags/Safari-601.1.32.2.80/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-05-22 00:41:52 UTC (rev 184743) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 32; MICRO_VERSION = 2; -NANO_VERSION = 5; +NANO_VERSION = 80; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: tags/Safari-601.1.32.2.80/Source/WebKit/mac/Configurations/Version.xcconfig (184742 => 184743) --- tags/Safari-601.1.32.2.80/Source/WebKit/mac/Configurations/Version.xcconfig 2015-05-22 00:39:57 UTC (rev 184742) +++ tags/Safari-601.1.32.2.80/Source/WebKit/mac/Configurations/Version.xcconfig 2015-05-22 00:41:52 UTC (rev 184743) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 32; MICRO_VERSION = 2; -NANO_VERSION = 5; +NANO_VERSION = 80; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-601.1.32.2.80/Source/WebKit2/Configurations/Version.xcconfig (184742 => 184743) --- tags/Safari-601.1.32.2.80/Source/WebKit2/Configurations/Version.xcconfig 2015-05-22 00:39:57 UTC (rev 184742) +++ tags/Safari-601.1.32.2.80/Source/WebKit2/Configurations/Version.xcconfig 2015-05-22 00:41:52 UTC (rev 184743) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 32; MICRO_VERSION = 2; -NANO_VERSION = 5; +NANO_VERSION = 80; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184745] trunk
Title: [184745] trunk
Revision 184745
Author dba...@webkit.org
Date 2015-05-21 18:15:54 -0700 (Thu, 21 May 2015)
Log Message
Update Autofill button icon
https://bugs.webkit.org/show_bug.cgi?id=145191
rdar://problem/20178942
Reviewed by Jessie Berlin.
Source/WebCore:
* css/html.css:
(input::-webkit-auto-fill-button):
(input::-webkit-auto-fill-button:active):
(input::-webkit-auto-fill-button:hover):
LayoutTests:
Update expected results.
* fast/forms/input-auto-fill-button-expected.txt:
* platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/input-auto-fill-button-expected.txt
trunk/LayoutTests/platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css
Diff
Modified: trunk/LayoutTests/ChangeLog (184744 => 184745)
--- trunk/LayoutTests/ChangeLog 2015-05-22 00:43:33 UTC (rev 184744)
+++ trunk/LayoutTests/ChangeLog 2015-05-22 01:15:54 UTC (rev 184745)
@@ -1,3 +1,16 @@
+2015-05-21 Daniel Bates daba...@apple.com
+
+Update Autofill button icon
+https://bugs.webkit.org/show_bug.cgi?id=145191
+rdar://problem/20178942
+
+Reviewed by Jessie Berlin.
+
+Update expected results.
+
+* fast/forms/input-auto-fill-button-expected.txt:
+* platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt:
+
2015-05-21 Chris Fleizach cfleiz...@apple.com
AX: improve list heuristics (presentational use versus actual lists)
Modified: trunk/LayoutTests/fast/forms/input-auto-fill-button-expected.txt (184744 => 184745)
--- trunk/LayoutTests/fast/forms/input-auto-fill-button-expected.txt 2015-05-22 00:43:33 UTC (rev 184744)
+++ trunk/LayoutTests/fast/forms/input-auto-fill-button-expected.txt 2015-05-22 01:15:54 UTC (rev 184745)
@@ -9,33 +9,33 @@
RenderBlock {DIV} at (0,34) size 784x23
RenderTextControl {INPUT} at (2,2) size 137x19 [bgcolor=#FF] [border: (2px inset #00)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
-RenderBlock {DIV} at (0,0) size 115x13
+RenderBlock {DIV} at (0,0) size 111x13
RenderText {#text} at (140,2) size 5x18
text run at (140,2) width 5:
RenderTextControl {INPUT} at (146,2) size 137x19 [bgcolor=#FF] [border: (2px inset #00)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
-RenderBlock {DIV} at (0,0) size 115x13
+RenderBlock {DIV} at (0,0) size 111x13
RenderText {#text} at (284,2) size 5x18
text run at (284,2) width 5:
RenderTextControl {INPUT} at (290,2) size 138x19 [bgcolor=#FF] [border: (2px inset #00)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
-RenderBlock {DIV} at (0,0) size 115x13
+RenderBlock {DIV} at (0,0) size 111x13
RenderTextControl {INPUT} at (431,2) size 137x19 [bgcolor=#FF] [border: (2px inset #00)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
-RenderBlock {DIV} at (0,0) size 115x13
-layer at (13,47) size 114x13
- RenderBlock {DIV} at (0,0) size 115x13
-layer at (157,47) size 114x13
- RenderBlock {DIV} at (0,0) size 115x13
-layer at (302,47) size 114x13
- RenderBlock {DIV} at (0,0) size 115x13
-layer at (442,47) size 114x13
- RenderBlock {DIV} at (0,0) size 115x13
-layer at (127,47) size 16x13
- RenderImage {DIV} at (114,0) size 17x13
-layer at (272,47) size 16x13
- RenderImage {DIV} at (114,0) size 17x13
-layer at (416,47) size 16x13
- RenderImage {DIV} at (114,0) size 17x13
-layer at (556,47) size 16x13
- RenderImage {DIV} at (114,0) size 17x13
+RenderBlock {DIV} at (0,0) size 111x13
+layer at (13,47) size 110x13
+ RenderBlock {DIV} at (0,0) size 111x13
+layer at (157,47) size 110x13
+ RenderBlock {DIV} at (0,0) size 111x13
+layer at (302,47) size 110x13
+ RenderBlock {DIV} at (0,0) size 111x13
+layer at (442,47) size 110x13
+ RenderBlock {DIV} at (0,0) size 111x13
+layer at (126,48) size 15x12
+ RenderBlock {DIV} at (113,0) size 16x13 [bgcolor=#00]
+layer at (271,48) size 15x12
+ RenderBlock {DIV} at (113,0) size 16x13 [bgcolor=#00]
+layer at (415,48) size 15x12
+ RenderBlock {DIV} at (113,0) size 16x13 [bgcolor=#00]
+layer at (555,48) size 15x12
+ RenderBlock {DIV} at (113,0) size 16x13 [bgcolor=#00]
Modified: trunk/LayoutTests/platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt (184744 => 184745)
--- trunk/LayoutTests/platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt 2015-05-22 00:43:33 UTC (rev 184744)
+++ trunk/LayoutTests/platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt 2015-05-22 01:15:54 UTC (rev 184745)
@@ -9,33 +9,33 @@
RenderBlock {DIV} at (0,34) size 784x23
RenderTextControl {INPUT} at (2,2) size 146x19 [bgcolor=#FF] [border: (2px inset #00)]
[webkit-changes] [184746] tags/Safari-601.1.32.5/
Title: [184746] tags/Safari-601.1.32.5/ Revision 184746 Author bshaf...@apple.com Date 2015-05-21 18:22:19 -0700 (Thu, 21 May 2015) Log Message New tag. Added Paths tags/Safari-601.1.32.5/ Diff Property changes: tags/Safari-601.1.32.5 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184737] tags/Safari-601.1.32.2.5/
Title: [184737] tags/Safari-601.1.32.2.5/ Revision 184737 Author bshaf...@apple.com Date 2015-05-21 17:12:44 -0700 (Thu, 21 May 2015) Log Message New tag. Added Paths tags/Safari-601.1.32.2.5/ Diff Property changes: tags/Safari-601.1.32.2.5 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184739] trunk/Source/WebKit2
Title: [184739] trunk/Source/WebKit2
Revision 184739
Author enr...@apple.com
Date 2015-05-21 17:31:07 -0700 (Thu, 21 May 2015)
Log Message
[iOS] Crash when taking a snapshot of a large PDF.
https://bugs.webkit.org/show_bug.cgi?id=145286
rdar://problem/20892362
Reviewed by Tim Horton.
The code for the PDF case was incorrectly computing the snapshot rect.
On top of that drawViewHierarchyInRect was ignoring the rect and
always creating an image using the view bounds causing the crash.
We are now always using the IOSurface if we are parented or
an image context when we are not.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (184738 => 184739)
--- trunk/Source/WebKit2/ChangeLog 2015-05-22 00:29:48 UTC (rev 184738)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-22 00:31:07 UTC (rev 184739)
@@ -1,3 +1,20 @@
+2015-05-21 Enrica Casucci enr...@apple.com
+
+[iOS] Crash when taking a snapshot of a large PDF.
+https://bugs.webkit.org/show_bug.cgi?id=145286
+rdar://problem/20892362
+
+Reviewed by Tim Horton.
+
+The code for the PDF case was incorrectly computing the snapshot rect.
+On top of that drawViewHierarchyInRect was ignoring the rect and
+always creating an image using the view bounds causing the crash.
+We are now always using the IOSurface if we are parented or
+an image context when we are not.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
+
2015-05-21 Anders Carlsson ander...@apple.com
Symlink the WebKit dylib instead of just the framework directory
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (184738 => 184739)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-05-22 00:29:48 UTC (rev 184738)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-05-22 00:31:07 UTC (rev 184739)
@@ -2718,6 +2718,20 @@
CGFloat imageHeight = imageScale * snapshotRectInContentCoordinates.size.height;
CGSize imageSize = CGSizeMake(imageWidth, imageHeight);
+#if USE(IOSURFACE)
+// If we are parented and thus won't incur a significant penalty from paging in tiles, snapshot the view hierarchy directly.
+if (self.window) {
+auto surface = WebCore::IOSurface::create(WebCore::expandedIntSize(WebCore::FloatSize(imageSize)), WebCore::ColorSpaceDeviceRGB);
+CGFloat imageScaleInViewCoordinates = imageWidth / rectInViewCoordinates.size.width;
+CATransform3D transform = CATransform3DMakeScale(imageScaleInViewCoordinates, imageScaleInViewCoordinates, 1);
+transform = CATransform3DTranslate(transform, -rectInViewCoordinates.origin.x, -rectInViewCoordinates.origin.y, 0);
+CARenderServerRenderLayerWithTransform(MACH_PORT_NULL, self.layer.context.contextId, reinterpret_castuint64_t(self.layer), surface-surface(), 0, 0, transform);
+completionHandler(surface-createImage().get());
+
+return;
+}
+#endif
+
if (_customContentView) {
UIGraphicsBeginImageContextWithOptions(imageSize, YES, 1);
@@ -2725,41 +2739,18 @@
[customContentView.backgroundColor set];
UIRectFill(CGRectMake(0, 0, imageWidth, imageHeight));
-CGRect destinationRect = customContentView.bounds;
-destinationRect.origin.x = -snapshotRectInContentCoordinates.origin.x * imageScale;
-destinationRect.origin.y = -snapshotRectInContentCoordinates.origin.y * imageScale;
-destinationRect.size.width *= imageScale;
-destinationRect.size.height *= imageScale;
+CGContextRef context = UIGraphicsGetCurrentContext();
+CGContextTranslateCTM(context, -snapshotRectInContentCoordinates.origin.x * imageScale, -snapshotRectInContentCoordinates.origin.y * imageScale);
+CGContextScaleCTM(context, imageScale, imageScale);
+[customContentView.layer renderInContext:context];
-if ([_customContentView window])
-[customContentView drawViewHierarchyInRect:destinationRect afterScreenUpdates:NO];
-else {
-CGContextRef context = UIGraphicsGetCurrentContext();
-CGContextTranslateCTM(context, destinationRect.origin.x, destinationRect.origin.y);
-CGContextScaleCTM(context, imageScale, imageScale);
-[customContentView.layer renderInContext:context];
-}
-
completionHandler([UIGraphicsGetImageFromCurrentImageContext() CGImage]);
UIGraphicsEndImageContext();
return;
}
-#if USE(IOSURFACE)
-// If we are parented and thus won't incur a significant penalty from paging in tiles, snapshot the view hierarchy directly.
-if (self.window) {
-auto surface =
[webkit-changes] [184744] tags/Safari-601.1.32.2.80/Source/WebKit2
Title: [184744] tags/Safari-601.1.32.2.80/Source/WebKit2
Revision 184744
Author bshaf...@apple.com
Date 2015-05-21 17:43:33 -0700 (Thu, 21 May 2015)
Log Message
Merged r184738. rdar://problem/20830673
Modified Paths
tags/Safari-601.1.32.2.80/Source/WebKit2/ChangeLog
tags/Safari-601.1.32.2.80/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Diff
Modified: tags/Safari-601.1.32.2.80/Source/WebKit2/ChangeLog (184743 => 184744)
--- tags/Safari-601.1.32.2.80/Source/WebKit2/ChangeLog 2015-05-22 00:41:52 UTC (rev 184743)
+++ tags/Safari-601.1.32.2.80/Source/WebKit2/ChangeLog 2015-05-22 00:43:33 UTC (rev 184744)
@@ -1,5 +1,19 @@
2015-05-21 Babak Shafiei bshaf...@apple.com
+Merge r184738.
+
+2015-05-21 Anders Carlsson ander...@apple.com
+
+Symlink the WebKit dylib instead of just the framework directory
+https://bugs.webkit.org/show_bug.cgi?id=145287
+rdar://problem/20830673
+
+Reviewed by Dan Bernstein.
+
+* WebKit2.xcodeproj/project.pbxproj:
+
+2015-05-21 Babak Shafiei bshaf...@apple.com
+
Merge r184514.
2015-05-18 Brady Eidson beid...@apple.com
Modified: tags/Safari-601.1.32.2.80/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (184743 => 184744)
--- tags/Safari-601.1.32.2.80/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2015-05-22 00:41:52 UTC (rev 184743)
+++ tags/Safari-601.1.32.2.80/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2015-05-22 00:43:33 UTC (rev 184744)
@@ -9042,7 +9042,7 @@
};
1A07D2F61919AB1B00ECDA16 /* Add Symlink in /System/Library/PrivateFrameworks */ = {
isa = PBXShellScriptBuildPhase;
- buildActionMask = 2147483647;
+ buildActionMask = 8;
files = (
);
inputPaths = (
@@ -9050,9 +9050,9 @@
name = Add Symlink in /System/Library/PrivateFrameworks;
outputPaths = (
);
- runOnlyForDeploymentPostprocessing = 0;
+ runOnlyForDeploymentPostprocessing = 1;
shellPath = /bin/sh;
- shellScript = if [[ ${PLATFORM_NAME} != \iphoneos\ ]]; then\nexit 0;\nfi\n\nif [[ ! -d \${INSTALL_DIR}/../PrivateFrameworks\ ]]; then\nmkdir -p \${INSTALL_DIR}/../PrivateFrameworks\\nfi\n\nif [[ -d \${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework\ ! -L \${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework\ ]]; then\necho \ERROR: Cannot create symlink. ${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework already exists and is a directory.\\nexit 1\nfi\n\n# If the symlink already exists, remove it and create the new one in its place.\nln -s -h -f ../Frameworks/WebKit.framework ${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework;
+ shellScript = if [[ ${PLATFORM_NAME} != \iphoneos\ ]]; then\nexit 0;\nfi\n\nif [[ ! -d \${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework\ ]]; then\nmkdir -p \${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework\\nfi\n\n# If the symlink already exists, remove it and create the new one in its place.\nln -s -h -f ../Frameworks/WebKit.framework/WebKit ${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework/WebKit;
};
1A1D2115191D96380001619F /* Postprocess Framework Headers */ = {
isa = PBXShellScriptBuildPhase;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184747] trunk/Source/JavaScriptCore
Title: [184747] trunk/Source/_javascript_Core Revision 184747 Author saambara...@gmail.com Date 2015-05-21 19:39:25 -0700 (Thu, 21 May 2015) Log Message Object allocation sinking phase should explicitly create bottom values for CreateActivation sink candidates and CreateActivation should have SymbolTable as a child node https://bugs.webkit.org/show_bug.cgi?id=145192 Reviewed by Filip Pizlo. When we sink CreateActivation and generate MaterializeCreateActivation in the object allocation sinking phase, we now explictly add PutHints for all variables on the activation setting those variables to their default value (undefined for Function activations and soon to be JS Empty Value for block scope activations). This allows us to remove code that fills FTL fast activation allocations with Undefined. This patch also adds the constant SymbolTable as an OpInfo of CreateActivation and MaterializeCreateActivation nodes. This is in preparation for ES6 block scoping which will introduce a new op code that gets lowered to CreateActivation. * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): * dfg/DFGClobberize.h: (JSC::DFG::clobberize): * dfg/DFGNode.h: (JSC::DFG::Node::hasCellOperand): (JSC::DFG::Node::cellOperand): * dfg/DFGObjectAllocationSinkingPhase.cpp: (JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations): (JSC::DFG::ObjectAllocationSinkingPhase::handleNode): (JSC::DFG::ObjectAllocationSinkingPhase::createMaterialize): (JSC::DFG::ObjectAllocationSinkingPhase::populateMaterialize): * dfg/DFGPromotedHeapLocation.cpp: (WTF::printInternal): * dfg/DFGPromotedHeapLocation.h: * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileCreateActivation): * ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::compileCreateActivation): (JSC::FTL::LowerDFGToLLVM::compileMaterializeCreateActivation): * ftl/FTLOperations.cpp: (JSC::FTL::operationMaterializeObjectInOSR): * tests/stress/activation-sink-default-value.js: Added. (bar): * tests/stress/activation-sink-osrexit-default-value.js: Added. (foo.set result): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGClobberize.h trunk/Source/_javascript_Core/dfg/DFGNode.h trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp trunk/Source/_javascript_Core/dfg/DFGPromotedHeapLocation.cpp trunk/Source/_javascript_Core/dfg/DFGPromotedHeapLocation.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp trunk/Source/_javascript_Core/ftl/FTLOperations.cpp Added Paths trunk/Source/_javascript_Core/tests/stress/activation-sink-default-value.js trunk/Source/_javascript_Core/tests/stress/activation-sink-osrexit-default-value.js Diff Modified: trunk/Source/_javascript_Core/ChangeLog (184746 => 184747) --- trunk/Source/_javascript_Core/ChangeLog 2015-05-22 01:22:19 UTC (rev 184746) +++ trunk/Source/_javascript_Core/ChangeLog 2015-05-22 02:39:25 UTC (rev 184747) @@ -1,3 +1,47 @@ +2015-05-21 Saam Barati saambara...@gmail.com + +Object allocation sinking phase should explicitly create bottom values for CreateActivation sink candidates and CreateActivation should have SymbolTable as a child node +https://bugs.webkit.org/show_bug.cgi?id=145192 + +Reviewed by Filip Pizlo. + +When we sink CreateActivation and generate MaterializeCreateActivation +in the object allocation sinking phase, we now explictly add PutHints for +all variables on the activation setting those variables to their default value +(undefined for Function activations and soon to be JS Empty Value for block scope activations). +This allows us to remove code that fills FTL fast activation allocations with Undefined. + +This patch also adds the constant SymbolTable as an OpInfo of CreateActivation and MaterializeCreateActivation +nodes. This is in preparation for ES6 block scoping which will introduce a new +op code that gets lowered to CreateActivation. + +* dfg/DFGByteCodeParser.cpp: +(JSC::DFG::ByteCodeParser::parseBlock): +* dfg/DFGClobberize.h: +(JSC::DFG::clobberize): +* dfg/DFGNode.h: +(JSC::DFG::Node::hasCellOperand): +(JSC::DFG::Node::cellOperand): +* dfg/DFGObjectAllocationSinkingPhase.cpp: +(JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations): +(JSC::DFG::ObjectAllocationSinkingPhase::handleNode): +(JSC::DFG::ObjectAllocationSinkingPhase::createMaterialize): +(JSC::DFG::ObjectAllocationSinkingPhase::populateMaterialize): +* dfg/DFGPromotedHeapLocation.cpp: +(WTF::printInternal): +* dfg/DFGPromotedHeapLocation.h: +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::compileCreateActivation): +*
[webkit-changes] [184738] trunk/Source/WebKit2
Title: [184738] trunk/Source/WebKit2
Revision 184738
Author ander...@apple.com
Date 2015-05-21 17:29:48 -0700 (Thu, 21 May 2015)
Log Message
Symlink the WebKit dylib instead of just the framework directory
https://bugs.webkit.org/show_bug.cgi?id=145287
rdar://problem/20830673
Reviewed by Dan Bernstein.
* WebKit2.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebKit2/ChangeLog (184737 => 184738)
--- trunk/Source/WebKit2/ChangeLog 2015-05-22 00:12:44 UTC (rev 184737)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-22 00:29:48 UTC (rev 184738)
@@ -1,5 +1,15 @@
2015-05-21 Anders Carlsson ander...@apple.com
+Symlink the WebKit dylib instead of just the framework directory
+https://bugs.webkit.org/show_bug.cgi?id=145287
+rdar://problem/20830673
+
+Reviewed by Dan Bernstein.
+
+* WebKit2.xcodeproj/project.pbxproj:
+
+2015-05-21 Anders Carlsson ander...@apple.com
+
WKWebsiteDataStore doesn't track and remove iOS Safari's offline application cache entries
https://bugs.webkit.org/show_bug.cgi?id=145279
rdar://problem/20657912
Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (184737 => 184738)
--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2015-05-22 00:12:44 UTC (rev 184737)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2015-05-22 00:29:48 UTC (rev 184738)
@@ -9049,7 +9049,7 @@
};
1A07D2F61919AB1B00ECDA16 /* Add Symlink in /System/Library/PrivateFrameworks */ = {
isa = PBXShellScriptBuildPhase;
- buildActionMask = 2147483647;
+ buildActionMask = 8;
files = (
);
inputPaths = (
@@ -9057,9 +9057,9 @@
name = Add Symlink in /System/Library/PrivateFrameworks;
outputPaths = (
);
- runOnlyForDeploymentPostprocessing = 0;
+ runOnlyForDeploymentPostprocessing = 1;
shellPath = /bin/sh;
- shellScript = if [[ ${PLATFORM_NAME} != \iphoneos\ ]]; then\nexit 0;\nfi\n\nif [[ ! -d \${INSTALL_DIR}/../PrivateFrameworks\ ]]; then\nmkdir -p \${INSTALL_DIR}/../PrivateFrameworks\\nfi\n\nif [[ -d \${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework\ ! -L \${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework\ ]]; then\necho \ERROR: Cannot create symlink. ${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework already exists and is a directory.\\nexit 1\nfi\n\n# If the symlink already exists, remove it and create the new one in its place.\nln -s -h -f ../Frameworks/WebKit.framework ${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework;
+ shellScript = if [[ ${PLATFORM_NAME} != \iphoneos\ ]]; then\nexit 0;\nfi\n\nif [[ ! -d \${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework\ ]]; then\nmkdir -p \${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework\\nfi\n\n# If the symlink already exists, remove it and create the new one in its place.\nln -s -h -f ../Frameworks/WebKit.framework/WebKit ${INSTALL_DIR}/../PrivateFrameworks/WebKit.framework/WebKit;
};
1A1D2115191D96380001619F /* Postprocess Framework Headers */ = {
isa = PBXShellScriptBuildPhase;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184741] trunk/Source
Title: [184741] trunk/Source Revision 184741 Author beid...@apple.com Date 2015-05-21 17:35:53 -0700 (Thu, 21 May 2015) Log Message Add an initiated by user gesture flag to ResourceRequest. https://bugs.webkit.org/show_bug.cgi?id=145281 Reviewed by Alex Christensen. Source/WebCore: Allow WebKit to tell WebCore what the new property key is: * platform/ios/WebCoreSystemInterfaceIOS.mm: * platform/mac/WebCoreSystemInterface.h: * platform/mac/WebCoreSystemInterface.mm: Add the flag to ResourceRequest, and make sure it encodes/decodes: * platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::initiatedByUserGesture): (WebCore::ResourceRequestBase::setInitiatedByUserGesture): (WebCore::ResourceRequestBase::encodeWithoutPlatformData): (WebCore::ResourceRequestBase::decodeWithoutPlatformData): Set/get the property on native CFURLRequestRefs: * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): Set/get the property on native NSURLRequests: * platform/network/cocoa/ResourceRequestCocoa.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): Source/WebKit/mac: * WebCoreSupport/WebSystemInterface.mm: (WKResourceRequestIsUserInitiatedKey): (InitWebCoreSystemInterface): Source/WebKit2: Expose a new category on NSURLRequest to allow SPI clients to easily set/get the flag: * Shared/API/Cocoa/_WKNSURLRequestExtras.h: Added. * Shared/API/Cocoa/_WKNSURLRequestExtras.mm: Added. (-[NSURLRequest _web_isUserInitiated]): (-[NSMutableURLRequest _web_setIsUserInitiated:]): * WebKit2.xcodeproj/project.pbxproj: Expose the new property key to WebCore: * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (WKResourceRequestIsUserInitiatedKey): (InitWebCoreSystemInterface): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm trunk/Source/WebCore/platform/network/ResourceRequestBase.h trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp trunk/Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm Added Paths trunk/Source/WebKit2/Shared/API/Cocoa/_WKNSURLRequestExtras.h trunk/Source/WebKit2/Shared/API/Cocoa/_WKNSURLRequestExtras.mm Diff Modified: trunk/Source/WebCore/ChangeLog (184740 => 184741) --- trunk/Source/WebCore/ChangeLog 2015-05-22 00:34:12 UTC (rev 184740) +++ trunk/Source/WebCore/ChangeLog 2015-05-22 00:35:53 UTC (rev 184741) @@ -1,3 +1,32 @@ +2015-05-21 Brady Eidson beid...@apple.com + +Add an initiated by user gesture flag to ResourceRequest. +https://bugs.webkit.org/show_bug.cgi?id=145281 + +Reviewed by Alex Christensen. + +Allow WebKit to tell WebCore what the new property key is: +* platform/ios/WebCoreSystemInterfaceIOS.mm: +* platform/mac/WebCoreSystemInterface.h: +* platform/mac/WebCoreSystemInterface.mm: + +Add the flag to ResourceRequest, and make sure it encodes/decodes: +* platform/network/ResourceRequestBase.h: +(WebCore::ResourceRequestBase::initiatedByUserGesture): +(WebCore::ResourceRequestBase::setInitiatedByUserGesture): +(WebCore::ResourceRequestBase::encodeWithoutPlatformData): +(WebCore::ResourceRequestBase::decodeWithoutPlatformData): + +Set/get the property on native CFURLRequestRefs: +* platform/network/cf/ResourceRequestCFNet.cpp: +(WebCore::ResourceRequest::doUpdatePlatformRequest): +(WebCore::ResourceRequest::doUpdateResourceRequest): + +Set/get the property on native NSURLRequests: +* platform/network/cocoa/ResourceRequestCocoa.mm: +(WebCore::ResourceRequest::doUpdateResourceRequest): +(WebCore::ResourceRequest::doUpdatePlatformRequest): + 2015-05-21 Daniel Bates daba...@apple.com Rollout http://trac.webkit.org/changeset/183909 Modified: trunk/Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm (184740 => 184741) --- trunk/Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm 2015-05-22 00:34:12 UTC (rev 184740) +++ trunk/Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm 2015-05-22 00:35:53 UTC (rev 184741) @@ -124,3 +124,5 @@ WEBCORE_EXPORT bool (*wkQueryDecoderAvailability)(void); +WEBCORE_EXPORT CFStringRef (*wkResourceRequestIsUserInitiatedKey)(void); + Modified: trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h (184740 => 184741) --- trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h 2015-05-22 00:34:12 UTC (rev 184740) +++
[webkit-changes] [184742] tags/Safari-601.1.32.2.80/
Title: [184742] tags/Safari-601.1.32.2.80/ Revision 184742 Author bshaf...@apple.com Date 2015-05-21 17:39:57 -0700 (Thu, 21 May 2015) Log Message New tag. Added Paths tags/Safari-601.1.32.2.80/ Diff Property changes: tags/Safari-601.1.32.2.80 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184748] trunk/Source/WebInspectorUI
Title: [184748] trunk/Source/WebInspectorUI
Revision 184748
Author nvasil...@apple.com
Date 2015-05-21 19:54:44 -0700 (Thu, 21 May 2015)
Log Message
Web Inspector: Dashboard debugger information can be clipped
https://bugs.webkit.org/show_bug.cgi?id=144209
Reviewed by Timothy Hatcher.
* UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard-container):
Make dashboard flexible by using vw (viewport width units).
* UserInterface/Views/DefaultDashboardView.css:
(.toolbar .dashboard.default):
Center default dashboard icons in the middle, don't spread them along the dashboard.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css
trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (184747 => 184748)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-05-22 02:39:25 UTC (rev 184747)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-05-22 02:54:44 UTC (rev 184748)
@@ -1,3 +1,18 @@
+2015-05-21 Nikita Vasilyev nvasil...@apple.com
+
+Web Inspector: Dashboard debugger information can be clipped
+https://bugs.webkit.org/show_bug.cgi?id=144209
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/DashboardContainerView.css:
+(.toolbar .dashboard-container):
+Make dashboard flexible by using vw (viewport width units).
+
+* UserInterface/Views/DefaultDashboardView.css:
+(.toolbar .dashboard.default):
+Center default dashboard icons in the middle, don't spread them along the dashboard.
+
2015-05-21 Joseph Pecoraro pecor...@apple.com
Web Inspector: Improve the UI of the type profiler popover
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css (184747 => 184748)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css 2015-05-22 02:39:25 UTC (rev 184747)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css 2015-05-22 02:54:44 UTC (rev 184748)
@@ -26,7 +26,7 @@
.toolbar .dashboard-container {
position: relative;
-width: 225px;
+width: 36vw;
border-radius: 4px;
background-color: rgb(252, 252, 252);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css (184747 => 184748)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css 2015-05-22 02:39:25 UTC (rev 184747)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css 2015-05-22 02:54:44 UTC (rev 184748)
@@ -34,7 +34,7 @@
.toolbar .dashboard.default {
display: flex;
flex-flow: row nowrap;
-justify-content: space-between;
+justify-content: center;
}
.toolbar .dashboard.default .item {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184749] trunk
Title: [184749] trunk
Revision 184749
Author an...@apple.com
Date 2015-05-21 20:59:16 -0700 (Thu, 21 May 2015)
Log Message
MaskImageOperation code does not manage CachedImageClients correctly
https://bugs.webkit.org/show_bug.cgi?id=145276
Source/WebCore:
rdar://problem/20959822
Reviewed by Andreas Kling.
Test: css3/masking/mask-image-client-crash.html
* platform/graphics/MaskImageOperation.cpp:
(WebCore::MaskImageOperation::isMaskLoaded):
(WebCore::MaskImageOperation::setImage):
If image changes transfer the clients to the new image.
(WebCore::MaskImageOperation::setRenderLayerImageClient):
Always use setImage.
(WebCore::MaskImageOperation::notifyFinished):
* platform/graphics/MaskImageOperation.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayer.h:
* rendering/RenderLayerMaskImageInfo.cpp:
(WebCore::RenderLayer::MaskImageInfo::~MaskImageInfo):
(WebCore::RenderLayer::MaskImageInfo::updateMaskImageClients):
Store the MaskImageOperations where we added clients.
(WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients):
Make sure we remove the clients from the same MaskImageOperations we added them to.
* rendering/RenderLayerMaskImageInfo.h:
LayoutTests:
Reviewed by Andreas Kling.
* css3/masking/mask-image-client-crash-expected.txt: Added.
* css3/masking/mask-image-client-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/MaskImageOperation.cpp
trunk/Source/WebCore/platform/graphics/MaskImageOperation.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderLayerMaskImageInfo.cpp
trunk/Source/WebCore/rendering/RenderLayerMaskImageInfo.h
Added Paths
trunk/LayoutTests/css3/masking/mask-image-client-crash-expected.txt
trunk/LayoutTests/css3/masking/mask-image-client-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (184748 => 184749)
--- trunk/LayoutTests/ChangeLog 2015-05-22 02:54:44 UTC (rev 184748)
+++ trunk/LayoutTests/ChangeLog 2015-05-22 03:59:16 UTC (rev 184749)
@@ -1,3 +1,13 @@
+2015-05-21 Antti Koivisto an...@apple.com
+
+MaskImageOperation code does not manage CachedImageClients correctly
+https://bugs.webkit.org/show_bug.cgi?id=145276
+
+Reviewed by Andreas Kling.
+
+* css3/masking/mask-image-client-crash-expected.txt: Added.
+* css3/masking/mask-image-client-crash.html: Added.
+
2015-05-21 Daniel Bates daba...@apple.com
Update Autofill button icon
Added: trunk/LayoutTests/css3/masking/mask-image-client-crash-expected.txt (0 => 184749)
--- trunk/LayoutTests/css3/masking/mask-image-client-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/masking/mask-image-client-crash-expected.txt 2015-05-22 03:59:16 UTC (rev 184749)
@@ -0,0 +1,2 @@
+This test passes if it doesn't crash or assert.
+
Added: trunk/LayoutTests/css3/masking/mask-image-client-crash.html (0 => 184749)
--- trunk/LayoutTests/css3/masking/mask-image-client-crash.html (rev 0)
+++ trunk/LayoutTests/css3/masking/mask-image-client-crash.html 2015-05-22 03:59:16 UTC (rev 184749)
@@ -0,0 +1,24 @@
+!DOCTYPE HTML
+html id=webtest0
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+head id=webtest1
+link id=webtest2 rel=stylesheet href=""
+/head
+body
+This test passes if it doesn't crash or assert.
+a id=webtest4 href=""
+br id=webtest12 clear=all/
+/body
+
+script
+document.getElementById(webtest4).setAttribute(style,page-break-before:always;-webkit-mask-image:url(data:image/gif;base64,R0lGODdhAQACAPABAAD/AP///ywAAQACAAACAkQKADs=););
+try {
+document.getElementById(webtest12).appendChild(document.createElement(applet)).setAttributeNodeNS(document.getElementById(webtest10));
+} catch(e) {
+}
+document.getElementById(webtest4).setAttribute(style,text-rendering:auto;);
+/script
+/html
Modified: trunk/Source/WebCore/ChangeLog (184748 => 184749)
--- trunk/Source/WebCore/ChangeLog 2015-05-22 02:54:44 UTC (rev 184748)
+++ trunk/Source/WebCore/ChangeLog 2015-05-22 03:59:16 UTC (rev 184749)
@@ -1,3 +1,40 @@
+2015-05-21 Antti Koivisto an...@apple.com
+
+MaskImageOperation code does not manage CachedImageClients correctly
+https://bugs.webkit.org/show_bug.cgi?id=145276
+rdar://problem/20959822
+
+Reviewed by Andreas Kling.
+
+Test: css3/masking/mask-image-client-crash.html
+
+* platform/graphics/MaskImageOperation.cpp:
+(WebCore::MaskImageOperation::isMaskLoaded):
+(WebCore::MaskImageOperation::setImage):
+
+If image changes transfer the clients to the new image.
+
+(WebCore::MaskImageOperation::setRenderLayerImageClient):
+
+Always use setImage.
+
+(WebCore::MaskImageOperation::notifyFinished):
+* platform/graphics/MaskImageOperation.h:
+*
[webkit-changes] [184750] trunk/Source/WebInspectorUI
Title: [184750] trunk/Source/WebInspectorUI
Revision 184750
Author commit-qu...@webkit.org
Date 2015-05-21 21:35:11 -0700 (Thu, 21 May 2015)
Log Message
Web Inspector: Give Toolbar buttons an active style
https://bugs.webkit.org/show_bug.cgi?id=145292
Patch by Joseph Pecoraro pecor...@apple.com on 2015-05-21
Reviewed by Timothy Hatcher.
* UserInterface/Views/ButtonToolbarItem.css:
(.toolbar .item.button:active):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (184749 => 184750)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-05-22 03:59:16 UTC (rev 184749)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-05-22 04:35:11 UTC (rev 184750)
@@ -1,3 +1,13 @@
+2015-05-21 Joseph Pecoraro pecor...@apple.com
+
+Web Inspector: Give Toolbar buttons an active style
+https://bugs.webkit.org/show_bug.cgi?id=145292
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/ButtonToolbarItem.css:
+(.toolbar .item.button:active):
+
2015-05-21 Nikita Vasilyev nvasil...@apple.com
Web Inspector: Dashboard debugger information can be clipped
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css (184749 => 184750)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css 2015-05-22 03:59:16 UTC (rev 184749)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css 2015-05-22 04:35:11 UTC (rev 184750)
@@ -40,6 +40,11 @@
padding: 0 10px;
}
+.toolbar .item.button:active {
+border-top-color: rgb(241, 241, 241);
+background-color: rgb(228, 228, 228);
+}
+
body.window-inactive .toolbar .item.button {
border: 1px solid rgb(220, 220, 220);
background-color: rgb(246, 246, 246);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184752] branches/safari-601.1.32-branch/Source
Title: [184752] branches/safari-601.1.32-branch/Source Revision 184752 Author bshaf...@apple.com Date 2015-05-21 22:46:13 -0700 (Thu, 21 May 2015) Log Message Versioning. Modified Paths branches/safari-601.1.32-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-601.1.32-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-601.1.32-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-601.1.32-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-601.1.32-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-601.1.32-branch/Source/_javascript_Core/Configurations/Version.xcconfig (184751 => 184752) --- branches/safari-601.1.32-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-05-22 05:46:02 UTC (rev 184751) +++ branches/safari-601.1.32-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-05-22 05:46:13 UTC (rev 184752) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 32; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.32-branch/Source/WebCore/Configurations/Version.xcconfig (184751 => 184752) --- branches/safari-601.1.32-branch/Source/WebCore/Configurations/Version.xcconfig 2015-05-22 05:46:02 UTC (rev 184751) +++ branches/safari-601.1.32-branch/Source/WebCore/Configurations/Version.xcconfig 2015-05-22 05:46:13 UTC (rev 184752) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 32; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.32-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (184751 => 184752) --- branches/safari-601.1.32-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-05-22 05:46:02 UTC (rev 184751) +++ branches/safari-601.1.32-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-05-22 05:46:13 UTC (rev 184752) @@ -1,7 +1,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 32; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.32-branch/Source/WebKit/mac/Configurations/Version.xcconfig (184751 => 184752) --- branches/safari-601.1.32-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-05-22 05:46:02 UTC (rev 184751) +++ branches/safari-601.1.32-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-05-22 05:46:13 UTC (rev 184752) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 32; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.32-branch/Source/WebKit2/Configurations/Version.xcconfig (184751 => 184752) --- branches/safari-601.1.32-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-05-22 05:46:02 UTC (rev 184751) +++ branches/safari-601.1.32-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-05-22 05:46:13 UTC (rev 184752) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 32; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184753] branches/safari-600.7-branch/Source
Title: [184753] branches/safari-600.7-branch/Source Revision 184753 Author bshaf...@apple.com Date 2015-05-21 22:46:22 -0700 (Thu, 21 May 2015) Log Message Versioning. Modified Paths branches/safari-600.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-600.7-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-600.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-600.7-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-600.7-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-600.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig (184752 => 184753) --- branches/safari-600.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-05-22 05:46:13 UTC (rev 184752) +++ branches/safari-600.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-05-22 05:46:22 UTC (rev 184753) @@ -23,7 +23,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 7; -TINY_VERSION = 9; +TINY_VERSION = 10; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-600.7-branch/Source/WebCore/Configurations/Version.xcconfig (184752 => 184753) --- branches/safari-600.7-branch/Source/WebCore/Configurations/Version.xcconfig 2015-05-22 05:46:13 UTC (rev 184752) +++ branches/safari-600.7-branch/Source/WebCore/Configurations/Version.xcconfig 2015-05-22 05:46:22 UTC (rev 184753) @@ -23,7 +23,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 7; -TINY_VERSION = 9; +TINY_VERSION = 10; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-600.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (184752 => 184753) --- branches/safari-600.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-05-22 05:46:13 UTC (rev 184752) +++ branches/safari-600.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-05-22 05:46:22 UTC (rev 184753) @@ -1,6 +1,6 @@ MAJOR_VERSION = 600; MINOR_VERSION = 7; -TINY_VERSION = 9; +TINY_VERSION = 10; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-600.7-branch/Source/WebKit/mac/Configurations/Version.xcconfig (184752 => 184753) --- branches/safari-600.7-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-05-22 05:46:13 UTC (rev 184752) +++ branches/safari-600.7-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-05-22 05:46:22 UTC (rev 184753) @@ -23,7 +23,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 7; -TINY_VERSION = 9; +TINY_VERSION = 10; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-600.7-branch/Source/WebKit2/Configurations/Version.xcconfig (184752 => 184753) --- branches/safari-600.7-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-05-22 05:46:13 UTC (rev 184752) +++ branches/safari-600.7-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-05-22 05:46:22 UTC (rev 184753) @@ -23,7 +23,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 7; -TINY_VERSION = 9; +TINY_VERSION = 10; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184751] branches/safari-601.1.32.2-branch/Source
Title: [184751] branches/safari-601.1.32.2-branch/Source Revision 184751 Author bshaf...@apple.com Date 2015-05-21 22:46:02 -0700 (Thu, 21 May 2015) Log Message Versioning. Modified Paths branches/safari-601.1.32.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-601.1.32.2-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-601.1.32.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-601.1.32.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-601.1.32.2-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-601.1.32.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (184750 => 184751) --- branches/safari-601.1.32.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-05-22 04:35:11 UTC (rev 184750) +++ branches/safari-601.1.32.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-05-22 05:46:02 UTC (rev 184751) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 32; MICRO_VERSION = 2; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-601.1.32.2-branch/Source/WebCore/Configurations/Version.xcconfig (184750 => 184751) --- branches/safari-601.1.32.2-branch/Source/WebCore/Configurations/Version.xcconfig 2015-05-22 04:35:11 UTC (rev 184750) +++ branches/safari-601.1.32.2-branch/Source/WebCore/Configurations/Version.xcconfig 2015-05-22 05:46:02 UTC (rev 184751) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 32; MICRO_VERSION = 2; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-601.1.32.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (184750 => 184751) --- branches/safari-601.1.32.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-05-22 04:35:11 UTC (rev 184750) +++ branches/safari-601.1.32.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-05-22 05:46:02 UTC (rev 184751) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 32; MICRO_VERSION = 2; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-601.1.32.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig (184750 => 184751) --- branches/safari-601.1.32.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-05-22 04:35:11 UTC (rev 184750) +++ branches/safari-601.1.32.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-05-22 05:46:02 UTC (rev 184751) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 32; MICRO_VERSION = 2; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/Configurations/Version.xcconfig (184750 => 184751) --- branches/safari-601.1.32.2-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-05-22 04:35:11 UTC (rev 184750) +++ branches/safari-601.1.32.2-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-05-22 05:46:02 UTC (rev 184751) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 32; MICRO_VERSION = 2; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184727] trunk/Source/WebKit2
Title: [184727] trunk/Source/WebKit2
Revision 184727
Author ander...@apple.com
Date 2015-05-21 12:12:17 -0700 (Thu, 21 May 2015)
Log Message
WKWebsiteDataStore doesn't track and remove iOS Safari's offline application cache entries
https://bugs.webkit.org/show_bug.cgi?id=145279
rdar://problem/20657912
Reviewed by Dan Bernstein.
Special-case iOS Safari and WebApp when computing the default application cache directory.
* UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:
(API::applicationCacheDirectory):
(API::WebsiteDataStore::defaultDataStoreConfiguration):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (184726 => 184727)
--- trunk/Source/WebKit2/ChangeLog 2015-05-21 18:54:13 UTC (rev 184726)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-21 19:12:17 UTC (rev 184727)
@@ -1,3 +1,17 @@
+2015-05-21 Anders Carlsson ander...@apple.com
+
+WKWebsiteDataStore doesn't track and remove iOS Safari's offline application cache entries
+https://bugs.webkit.org/show_bug.cgi?id=145279
+rdar://problem/20657912
+
+Reviewed by Dan Bernstein.
+
+Special-case iOS Safari and WebApp when computing the default application cache directory.
+
+* UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:
+(API::applicationCacheDirectory):
+(API::WebsiteDataStore::defaultDataStoreConfiguration):
+
2015-05-21 Brian Weinstein bweinst...@apple.com
Add a _WKWebKitContentExtensionStore initializer that takes a path.
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm (184726 => 184727)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm 2015-05-21 18:54:13 UTC (rev 184726)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm 2015-05-21 19:12:17 UTC (rev 184727)
@@ -26,8 +26,13 @@
#include config.h
#include APIWebsiteDataStore.h
+#include SandboxExtension.h
#include SandboxUtilities.h
+#if PLATFORM(IOS)
+#import WebCore/RuntimeApplicationChecksIOS.h
+#endif
+
namespace API {
String WebsiteDataStore::cacheDirectoryFileSystemRepresentation(const String directoryName)
@@ -86,12 +91,29 @@
return url.absoluteURL.path.fileSystemRepresentation;
}
+static String applicationCacheDirectory()
+{
+#if PLATFORM(IOS)
+// This quirk used to make these apps share application cache storage, but doesn't accomplish that any more.
+// Preserving it avoids the need to migrate data when upgrading.
+// FIXME: Ideally we should just have Safari and WebApp create a data store with
+// this application cache path, but that's not supported as of right now.
+if (WebCore::applicationIsMobileSafari() || WebCore::applicationIsWebApp()) {
+NSString *cachePath = [NSHomeDirectory() stringByAppendingPathComponent:@Library/Caches/com.apple.WebAppCache];
+
+return WebKit::stringByResolvingSymlinksInPath(cachePath.stringByStandardizingPath);
+}
+#endif
+
+return WebsiteDataStore::cacheDirectoryFileSystemRepresentation(OfflineWebApplicationCache);
+}
+
WebKit::WebsiteDataStore::Configuration WebsiteDataStore::defaultDataStoreConfiguration()
{
WebKit::WebsiteDataStore::Configuration configuration;
configuration.networkCacheDirectory = cacheDirectoryFileSystemRepresentation(NetworkCache);
-configuration.applicationCacheDirectory = cacheDirectoryFileSystemRepresentation(OfflineWebApplicationCache);
+configuration.applicationCacheDirectory = applicationCacheDirectory();
configuration.webSQLDatabaseDirectory = websiteDataDirectoryFileSystemRepresentation(WebSQL);
configuration.localStorageDirectory = websiteDataDirectoryFileSystemRepresentation(LocalStorage);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184728] trunk/Source/WebCore
Title: [184728] trunk/Source/WebCore
Revision 184728
Author bfulg...@apple.com
Date 2015-05-21 12:37:50 -0700 (Thu, 21 May 2015)
Log Message
Scroll-snap points needs to be updated during programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=145216
rdar://problem/21051039
Reviewed by Dean Jackson.
Whenever we adjust the current scroll position, make sure we also update the current
active scroll snap offset index (if applicable).
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Call the new 'updateActiveScrollSnapIndexForOffset'
method after moving to a new position.
(WebCore::ScrollAnimator::setCurrentPosition): Ditto.
(WebCore::ScrollAnimator::updateActiveScrollSnapIndexForOffset): New method. Asks the scroll controller to
identify the closest scroll snap offset index. If it finds something relevant, update the ScrollableArea state
to track these new values.
* platform/ScrollAnimator.h:
* platform/cocoa/ScrollController.h:
(WebCore::ScrollController::activeScrollSnapIndexDidChange):
(WebCore::ScrollController::setScrollSnapIndexDidChange):
* platform/cocoa/ScrollController.mm:
(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset): Added. Find the closest relevant scroll snap offset
index for the given scroll offset, and update the internal scroll snap state to reflect it.
(WebCore::ScrollController::setActiveScrollSnapIndicesForOffset): Given the x and y offset for a scroll,
set the relevant scroll snap offset indices.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollTo): Call the new 'updateActiveScrollSnapIndexForOffset' method
after moving to a new position.
(WebCore::ScrollAnimatorMac::immediateScrollBy): Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollAnimator.cpp
trunk/Source/WebCore/platform/ScrollAnimator.h
trunk/Source/WebCore/platform/cocoa/ScrollController.h
trunk/Source/WebCore/platform/cocoa/ScrollController.mm
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (184727 => 184728)
--- trunk/Source/WebCore/ChangeLog 2015-05-21 19:12:17 UTC (rev 184727)
+++ trunk/Source/WebCore/ChangeLog 2015-05-21 19:37:50 UTC (rev 184728)
@@ -1,3 +1,35 @@
+2015-05-21 Brent Fulgham bfulg...@apple.com
+
+Scroll-snap points needs to be updated during programmatic scrolls
+https://bugs.webkit.org/show_bug.cgi?id=145216
+rdar://problem/21051039
+
+Reviewed by Dean Jackson.
+
+Whenever we adjust the current scroll position, make sure we also update the current
+active scroll snap offset index (if applicable).
+
+* platform/ScrollAnimator.cpp:
+(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Call the new 'updateActiveScrollSnapIndexForOffset'
+method after moving to a new position.
+(WebCore::ScrollAnimator::setCurrentPosition): Ditto.
+(WebCore::ScrollAnimator::updateActiveScrollSnapIndexForOffset): New method. Asks the scroll controller to
+identify the closest scroll snap offset index. If it finds something relevant, update the ScrollableArea state
+to track these new values.
+* platform/ScrollAnimator.h:
+* platform/cocoa/ScrollController.h:
+(WebCore::ScrollController::activeScrollSnapIndexDidChange):
+(WebCore::ScrollController::setScrollSnapIndexDidChange):
+* platform/cocoa/ScrollController.mm:
+(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset): Added. Find the closest relevant scroll snap offset
+index for the given scroll offset, and update the internal scroll snap state to reflect it.
+(WebCore::ScrollController::setActiveScrollSnapIndicesForOffset): Given the x and y offset for a scroll,
+set the relevant scroll snap offset indices.
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::immediateScrollTo): Call the new 'updateActiveScrollSnapIndexForOffset' method
+after moving to a new position.
+(WebCore::ScrollAnimatorMac::immediateScrollBy): Ditto.
+
2015-05-21 Matt Baker mattba...@apple.com
Unreviewed build fix.
Modified: trunk/Source/WebCore/platform/ScrollAnimator.cpp (184727 => 184728)
--- trunk/Source/WebCore/platform/ScrollAnimator.cpp 2015-05-21 19:12:17 UTC (rev 184727)
+++ trunk/Source/WebCore/platform/ScrollAnimator.cpp 2015-05-21 19:37:50 UTC (rev 184728)
@@ -80,6 +80,7 @@
m_currentPosX = offset.x();
m_currentPosY = offset.y();
notifyPositionChanged(delta);
+updateActiveScrollSnapIndexForOffset();
}
#if ENABLE(CSS_SCROLL_SNAP) PLATFORM(MAC)
@@ -168,6 +169,7 @@
{
m_currentPosX = position.x();
m_currentPosY = position.y();
+updateActiveScrollSnapIndexForOffset();
}
FloatPoint ScrollAnimator::currentPosition() const
@@ -175,6 +177,17 @@
return FloatPoint(m_currentPosX,
[webkit-changes] [184731] branches/safari-601.1.32.2-branch/Source/WebKit2
Title: [184731] branches/safari-601.1.32.2-branch/Source/WebKit2 Revision 184731 Author bshaf...@apple.com Date 2015-05-21 12:53:48 -0700 (Thu, 21 May 2015) Log Message Merged r184514. rdar://problem/20368630 Modified Paths branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcessProxy.cpp Diff Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog (184730 => 184731) --- branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog 2015-05-21 19:52:44 UTC (rev 184730) +++ branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog 2015-05-21 19:53:48 UTC (rev 184731) @@ -1,5 +1,20 @@ 2015-05-21 Babak Shafiei bshaf...@apple.com +Merge r184514. + +2015-05-18 Brady Eidson beid...@apple.com + +Followup to: Networking process on iOS can be suspended and never exit +https://bugs.webkit.org/show_bug.cgi?id=144971. + +Unreviewed. Fixing API tests that revealed the unintentional change in behavior. + +* Shared/ChildProcessProxy.cpp: +(WebKit::ChildProcessProxy::shutDownProcess): The on WebProcessProxy code path that this + was adopted from had an m_connection null check, and that null check needs to remain. + +2015-05-21 Babak Shafiei bshaf...@apple.com + Merge r184503. 2015-05-18 Brady Eidson beid...@apple.com Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcessProxy.cpp (184730 => 184731) --- branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcessProxy.cpp 2015-05-21 19:52:44 UTC (rev 184730) +++ branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcessProxy.cpp 2015-05-21 19:53:48 UTC (rev 184731) @@ -170,6 +170,9 @@ return; } +if (!m_connection) +return; + processWillShutDown(*m_connection); if (canSendMessage()) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [184730] branches/safari-601.1.32.2-branch/Source/WebKit2
Title: [184730] branches/safari-601.1.32.2-branch/Source/WebKit2 Revision 184730 Author bshaf...@apple.com Date 2015-05-21 12:52:44 -0700 (Thu, 21 May 2015) Log Message Merged r184503. rdar://problem/20368630 Modified Paths branches/safari-601.1.32.2-branch/Source/WebKit2/CMakeLists.txt branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog branches/safari-601.1.32.2-branch/Source/WebKit2/DerivedSources.make branches/safari-601.1.32.2-branch/Source/WebKit2/NetworkProcess/NetworkProcess.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcess.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcess.h branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcessProxy.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcessProxy.h branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/WebProcessPool.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/WebProcessProxy.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj branches/safari-601.1.32.2-branch/Source/WebKit2/WebProcess/WebProcess.cpp Added Paths branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcess.messages.in Diff Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/CMakeLists.txt (184729 => 184730) --- branches/safari-601.1.32.2-branch/Source/WebKit2/CMakeLists.txt 2015-05-21 19:51:39 UTC (rev 184729) +++ branches/safari-601.1.32.2-branch/Source/WebKit2/CMakeLists.txt 2015-05-21 19:52:44 UTC (rev 184730) @@ -641,6 +641,7 @@ PluginProcess/PluginProcess.messages.in PluginProcess/WebProcessConnection.messages.in +Shared/ChildProcess.messages.in Shared/WebConnection.messages.in Shared/Authentication/AuthenticationManager.messages.in Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog (184729 => 184730) --- branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog 2015-05-21 19:51:39 UTC (rev 184729) +++ branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog 2015-05-21 19:52:44 UTC (rev 184730) @@ -1,5 +1,58 @@ 2015-05-21 Babak Shafiei bshaf...@apple.com +Merge r184503. + +2015-05-18 Brady Eidson beid...@apple.com + +Networking process on iOS can be suspended and never exit. +rdar://problem/20368630 and https://bugs.webkit.org/show_bug.cgi?id=144971 + +Reviewed by Darin Adler. + +There's a few issues here. + +1 - When the NetworkProcessProxy goes away, it takes its process assertion with it. This causes +the Network process to suspend indefinitely, unable to ever respond to IPC::Connection callbacks. +We already solved this with WebProcess with a watchdog timer keeping both the process assertion +and xpc_connection alive while the process shuts down. This patch expands that to the network +process, and it will be easy to expand that to database and plugin processes doing forward. + +2 - All of our child processes either decide to self-terminate or listen for their connection to +close at which point they terminate. This leads to various races. We should +move to a model where the UI process explicitly tells them to shutdown, and this patch starts us +down that path. + +* CMakeLists.txt: +* DerivedSources.make: +* WebKit2.xcodeproj/project.pbxproj: + +* NetworkProcess/NetworkProcess.cpp: +(WebKit::NetworkProcess::didReceiveMessage): Send ChildProcess messages to ChildProcess. + +* Shared/ChildProcess.cpp: +(WebKit::ChildProcess::shutDown): For now, just terminate the process. In the future have the + process do cleanup work before it is terminated. +* Shared/ChildProcess.h: +* Shared/ChildProcess.messages.in: Added. + +* Shared/ChildProcessProxy.cpp: +(WebKit::ChildProcessProxy::shutDownProcess): Set a watchdog and - if possible - explicitly message + the process to ShutDown. +(WebKit::ChildProcessProxy::abortProcessLaunchIfNeeded): Deleted. +* Shared/ChildProcessProxy.h: + +* UIProcess/WebProcessPool.cpp: +(WebKit::WebProcessPool::~WebProcessPool): Explicitly tell the network process to shut down. + +* UIProcess/WebProcessProxy.cpp: +(WebKit::WebProcessProxy::removeWebPage): Move abortProcessLaunchIfNeeded() and the watchdog timer + code to ChildProcessProxy::shutDownProcess. + +* WebProcess/WebProcess.cpp: +(WebKit::WebProcess::didReceiveMessage): Send ChildProcess messages to ChildProcess::didReceiveMessage. + +2015-05-21 Babak Shafiei bshaf...@apple.com + Merge r184370. 2015-05-14 Brady Eidson beid...@apple.com Modified:
[webkit-changes] [184729] branches/safari-601.1.32.2-branch/Source/WebKit2
Title: [184729] branches/safari-601.1.32.2-branch/Source/WebKit2 Revision 184729 Author bshaf...@apple.com Date 2015-05-21 12:51:39 -0700 (Thu, 21 May 2015) Log Message Merged r184370. rdar://problem/20368630 Modified Paths branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcessProxy.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcessProxy.h branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/WebFrameProxy.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/WebFrameProxy.h branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/WebPageProxy.h branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/WebProcessLifetimeTracker.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/WebProcessLifetimeTracker.h branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/WebProcessProxy.cpp branches/safari-601.1.32.2-branch/Source/WebKit2/UIProcess/WebProcessProxy.h Diff Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog (184728 => 184729) --- branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog 2015-05-21 19:37:50 UTC (rev 184728) +++ branches/safari-601.1.32.2-branch/Source/WebKit2/ChangeLog 2015-05-21 19:51:39 UTC (rev 184729) @@ -1,5 +1,66 @@ 2015-05-21 Babak Shafiei bshaf...@apple.com +Merge r184370. + +2015-05-14 Brady Eidson beid...@apple.com + +Rename connectionDidClose and related methods to be more clear. +https://bugs.webkit.org/show_bug.cgi?id=145030 + +Reviewed by Darin Adler. + +These methods were easy to confuse with Connection::Client::didClose(), yet they +were about something much more explicit: A child process being shut down by the UI Process. + +Let's call them as such. + +* Shared/ChildProcessProxy.cpp: +(WebKit::ChildProcessProxy::shutDownProcess): +(WebKit::ChildProcessProxy::clearConnection): Deleted. +(WebKit::ChildProcessProxy::connectionDidClose): Deleted. +* Shared/ChildProcessProxy.h: + +* UIProcess/Databases/DatabaseProcessProxy.cpp: +(WebKit::DatabaseProcessProxy::processWillShutDown): +* UIProcess/Databases/DatabaseProcessProxy.h: + +* UIProcess/Network/NetworkProcessProxy.cpp: +(WebKit::NetworkProcessProxy::processWillShutDown): +* UIProcess/Network/NetworkProcessProxy.h: + +* UIProcess/Plugins/PluginProcessProxy.cpp: +(WebKit::PluginProcessProxy::processWillShutDown): +* UIProcess/Plugins/PluginProcessProxy.h: + +* UIProcess/WebFrameProxy.cpp: +(WebKit::WebFrameProxy::webProcessWillShutDown): +(WebKit::WebFrameProxy::disconnect): Deleted. +* UIProcess/WebFrameProxy.h: + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::webProcessWillShutDown): +(WebKit::WebPageProxy::connectionDidClose): Deleted. +* UIProcess/WebPageProxy.h: + +* UIProcess/WebProcessLifetimeTracker.cpp: +(WebKit::WebProcessLifetimeTracker::webProcessWillShutDown): +(WebKit::WebProcessLifetimeTracker::connectionDidClose): Deleted. +* UIProcess/WebProcessLifetimeTracker.h: + +* UIProcess/WebProcessProxy.cpp: +(WebKit::WebProcessProxy::processWillShutDown): +(WebKit::WebProcessProxy::shutDown): +(WebKit::WebProcessProxy::removeWebPage): +(WebKit::WebProcessProxy::didClose): +(WebKit::WebProcessProxy::disconnectFramesFromPage): +(WebKit::WebProcessProxy::shouldTerminate): +(WebKit::WebProcessProxy::requestTermination): +(WebKit::WebProcessProxy::connectionDidClose): Deleted. +(WebKit::WebProcessProxy::disconnect): Deleted. +* UIProcess/WebProcessProxy.h: + +2015-05-21 Babak Shafiei bshaf...@apple.com + Merge r184716. 2015-05-21 Alexey Proskuryakov a...@apple.com Modified: branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcessProxy.cpp (184728 => 184729) --- branches/safari-601.1.32.2-branch/Source/WebKit2/Shared/ChildProcessProxy.cpp 2015-05-21 19:37:50 UTC (rev 184728) +++
[webkit-changes] [184716] trunk/Source/WebKit2
Title: [184716] trunk/Source/WebKit2
Revision 184716
Author a...@apple.com
Date 2015-05-21 10:10:48 -0700 (Thu, 21 May 2015)
Log Message
Build fix. Silence some deprecation warnings.
* UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel _presentPopoverWithContentViewController:animated:]):
* UIProcess/ios/forms/WKFormInputControl.mm:
(-[WKDateTimePopover initWithView:datePickerMode:]):
* UIProcess/ios/forms/WKFormPopover.h:
* UIProcess/ios/forms/WKFormPopover.mm:
* UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectPopover initWithView:hasGroups:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm
trunk/Source/WebKit2/UIProcess/ios/forms/WKFormInputControl.mm
trunk/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.h
trunk/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.mm
trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (184715 => 184716)
--- trunk/Source/WebKit2/ChangeLog 2015-05-21 15:49:21 UTC (rev 184715)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-21 17:10:48 UTC (rev 184716)
@@ -1,3 +1,16 @@
+2015-05-21 Alexey Proskuryakov a...@apple.com
+
+Build fix. Silence some deprecation warnings.
+
+* UIProcess/ios/forms/WKFileUploadPanel.mm:
+(-[WKFileUploadPanel _presentPopoverWithContentViewController:animated:]):
+* UIProcess/ios/forms/WKFormInputControl.mm:
+(-[WKDateTimePopover initWithView:datePickerMode:]):
+* UIProcess/ios/forms/WKFormPopover.h:
+* UIProcess/ios/forms/WKFormPopover.mm:
+* UIProcess/ios/forms/WKFormSelectPopover.mm:
+(-[WKSelectPopover initWithView:hasGroups:]):
+
2015-05-21 Csaba Osztrogonác o...@webkit.org
[EFL] Remove an unused private field from EwkPopupMenuItem class
Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm (184715 => 184716)
--- trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm 2015-05-21 15:49:21 UTC (rev 184715)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm 2015-05-21 17:10:48 UTC (rev 184716)
@@ -290,7 +290,10 @@
BOOL _usingCamera;
RetainPtrUIImagePickerController _imagePicker;
RetainPtrUIViewController _presentationViewController; // iPhone always. iPad for Fullscreen Camera.
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored -Wdeprecated-declarations
RetainPtrUIPopoverController _presentationPopover; // iPad for action sheet and Photo Library.
+#pragma clang diagnostic pop
RetainPtrUIDocumentMenuViewController _documentMenuController;
RetainPtrUIAlertController _actionSheetController;
}
@@ -565,7 +568,10 @@
{
[self _dismissDisplayAnimated:animated];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored -Wdeprecated-declarations
_presentationPopover = adoptNS([[UIPopoverController alloc] initWithContentViewController:contentViewController]);
+#pragma clang diagnostic pop
[_presentationPopover setDelegate:self];
[_presentationPopover presentPopoverFromRect:CGRectIntegral(CGRectMake(_interactionPoint.x, _interactionPoint.y, 1, 1)) inView:_view permittedArrowDirections:UIPopoverArrowDirectionAny animated:animated];
}
Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKFormInputControl.mm (184715 => 184716)
--- trunk/Source/WebKit2/UIProcess/ios/forms/WKFormInputControl.mm 2015-05-21 15:49:21 UTC (rev 184715)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKFormInputControl.mm 2015-05-21 17:10:48 UTC (rev 184716)
@@ -341,7 +341,10 @@
#pragma clang diagnostic pop
[navigationItem setRightBarButtonItem:clearButton];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored -Wdeprecated-declarations
RetainPtrUIPopoverController controller = adoptNS([[UIPopoverController alloc] initWithContentViewController:navigationController.get()]);
+#pragma clang diagnostic pop
[self setPopoverController:controller.get()];
return self;
Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.h (184715 => 184716)
--- trunk/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.h 2015-05-21 15:49:21 UTC (rev 184715)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.h 2015-05-21 17:10:48 UTC (rev 184716)
@@ -38,7 +38,10 @@
- (UIPopoverArrowDirection)popoverArrowDirections;
@property(nonatomic, assign) CGPoint presentationPoint;
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored -Wdeprecated-declarations
@property(nonatomic, retain) UIPopoverController *popoverController;
+#pragma clang diagnostic pop
@property(nonatomic, assign) id WKRotatingPopoverDelegate dismissionDelegate;
@end
Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.mm (184715 => 184716)
--- trunk/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.mm 2015-05-21 15:49:21 UTC (rev 184715)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKFormPopover.mm 2015-05-21 17:10:48
[webkit-changes] [184718] trunk/Source/WebCore
Title: [184718] trunk/Source/WebCore Revision 184718 Author commit-qu...@webkit.org Date 2015-05-21 10:34:09 -0700 (Thu, 21 May 2015) Log Message Use modern for-loops in WebCore/svg. https://bugs.webkit.org/show_bug.cgi?id=145209 Patch by Hunseop Jeong hs85.je...@samsung.com on 2015-05-21 Reviewed by Darin Adler. No new tests, no new tests. * svg/SVGAnimateElementBase.cpp: (WebCore::propertyTypesAreConsistent): * svg/SVGAnimatedPath.cpp: (WebCore::SVGAnimatedPathAnimator::startAnimValAnimation): * svg/SVGAnimatedTypeAnimator.h: (WebCore::SVGAnimatedTypeAnimator::executeAction): * svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseAttribute): * svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): * svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::pauseAnimations): (WebCore::SVGDocumentExtensions::unpauseAnimations): (WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): (WebCore::SVGDocumentExtensions::isElementWithPendingResources): (WebCore::SVGDocumentExtensions::removeElementFromPendingResources): (WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement): * svg/SVGElement.cpp: (WebCore::populateAttributeNameToCSSPropertyIDMap): (WebCore::populateAttributeNameToAnimatedPropertyTypeMap): (WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap): (WebCore::hasLoadListener): * svg/SVGFontData.cpp: (WebCore::SVGFontData::applySVGGlyphSelection): * svg/SVGFontElement.cpp: (WebCore::SVGFontElement::registerLigaturesInGlyphCache): (WebCore::SVGKerningMap::insert): (WebCore::stringMatchesUnicodeRange): * svg/SVGPathByteStream.h: (WebCore::SVGPathByteStream::append): * svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::setElapsed): (WebCore::SMILTimeContainer::updateAnimations): * svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::parseBeginOrEnd): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::disconnectConditions): (WebCore::SVGSMILElement::notifyDependentsIntervalChanged): (WebCore::SVGSMILElement::createInstanceTimesFromSyncbase): * svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::clearResultsRecursive): * svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::addBuiltinEffects): * svg/properties/SVGAnimatedProperty.cpp: (WebCore::SVGAnimatedProperty::~SVGAnimatedProperty): * svg/properties/SVGListProperty.h: (WebCore::SVGListProperty::detachListWrappersAndResize): * svg/properties/SVGPathSegListPropertyTearOff.cpp: (WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/SVGAnimateElementBase.cpp trunk/Source/WebCore/svg/SVGAnimatedPath.cpp trunk/Source/WebCore/svg/SVGAnimatedTypeAnimator.h trunk/Source/WebCore/svg/SVGAnimationElement.cpp trunk/Source/WebCore/svg/SVGCursorElement.cpp trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp trunk/Source/WebCore/svg/SVGElement.cpp trunk/Source/WebCore/svg/SVGFontData.cpp trunk/Source/WebCore/svg/SVGFontElement.cpp trunk/Source/WebCore/svg/SVGPathByteStream.h trunk/Source/WebCore/svg/SVGPathUtilities.cpp trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h trunk/Source/WebCore/svg/properties/SVGAnimatedProperty.cpp trunk/Source/WebCore/svg/properties/SVGListProperty.h trunk/Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (184717 => 184718) --- trunk/Source/WebCore/ChangeLog 2015-05-21 17:27:47 UTC (rev 184717) +++ trunk/Source/WebCore/ChangeLog 2015-05-21 17:34:09 UTC (rev 184718) @@ -1,3 +1,62 @@ +2015-05-21 Hunseop Jeong hs85.je...@samsung.com + +Use modern for-loops in WebCore/svg. +https://bugs.webkit.org/show_bug.cgi?id=145209 + +Reviewed by Darin Adler. + +No new tests, no new tests. + +* svg/SVGAnimateElementBase.cpp: +(WebCore::propertyTypesAreConsistent): +* svg/SVGAnimatedPath.cpp: +(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation): +* svg/SVGAnimatedTypeAnimator.h: +(WebCore::SVGAnimatedTypeAnimator::executeAction): +* svg/SVGAnimationElement.cpp: +(WebCore::SVGAnimationElement::parseAttribute): +* svg/SVGCursorElement.cpp: +(WebCore::SVGCursorElement::~SVGCursorElement): +* svg/SVGDocumentExtensions.cpp: +(WebCore::SVGDocumentExtensions::pauseAnimations): +(WebCore::SVGDocumentExtensions::unpauseAnimations): +(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): +(WebCore::SVGDocumentExtensions::isElementWithPendingResources): +(WebCore::SVGDocumentExtensions::removeElementFromPendingResources): +
[webkit-changes] [184719] trunk
Title: [184719] trunk Revision 184719 Author commit-qu...@webkit.org Date 2015-05-21 10:36:32 -0700 (Thu, 21 May 2015) Log Message SVG as image uses very tiny default font-size https://bugs.webkit.org/show_bug.cgi?id=68090 Patch by Said Abou-Hallawa sabouhall...@apple.com on 2015-05-21 Reviewed by Darin Adler. Source/WebCore: When loading a document, WebKit creates a Page object and then changes its setting from the browser's preferences. This is true for interactive resources also, such as a stand-alone SVG or an SVG embedded in an object tag for example. For non-interactive resources, like an SVG embedded in an img tag for example, this function is called after loading the resource is finished. This function creates an artificial page and fabricates a scoped settings for it. This turns out to be problematic for cases like the default font size because its initial value is zero. We cannot go from WebCore to WebKit to ask for the global settings. But we can inherit the global settings from the the master page. This is not the best solution because of two reasons. (1) Once the resource is cached and the styles for the text elements are calculated, nothing can change the values of styles except removing the resource itself from the cache if the browser's preferences change. Also there is no mechanism to notify this artificial page if the browser's preferences change. (2) An image like a non-interactive SVG, should be displayed the same way regardless of the browser's preferences. A user may be able to change the default font size for other text. But this should not affect images even if they are vector images like SVG. An easy and more agreeable solution is to hard-code the default font size for this case and do not depend on the global settings at all. Test: svg/text/text-default-font-size.html * page/Settings.in: Set the initial value of the setting defaultFontSize to be 16. LayoutTests: * svg/text/text-default-font-size-expected.html: Added. * svg/text/text-default-font-size.html: Added. Ensure the default font size for non-interactive SVG images is not zero. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/Settings.in Added Paths trunk/LayoutTests/svg/text/text-default-font-size-expected.html trunk/LayoutTests/svg/text/text-default-font-size.html Diff Modified: trunk/LayoutTests/ChangeLog (184718 => 184719) --- trunk/LayoutTests/ChangeLog 2015-05-21 17:34:09 UTC (rev 184718) +++ trunk/LayoutTests/ChangeLog 2015-05-21 17:36:32 UTC (rev 184719) @@ -1,3 +1,14 @@ +2015-05-21 Said Abou-Hallawa sabouhall...@apple.com + +SVG as image uses very tiny default font-size +https://bugs.webkit.org/show_bug.cgi?id=68090 + +Reviewed by Darin Adler. + +* svg/text/text-default-font-size-expected.html: Added. +* svg/text/text-default-font-size.html: Added. +Ensure the default font size for non-interactive SVG images is not zero. + 2015-05-21 Youenn Fablet youenn.fab...@crf.canon.fr streams/reference-implementation/readable-stream.html should now pass Added: trunk/LayoutTests/svg/text/text-default-font-size-expected.html (0 => 184719) --- trunk/LayoutTests/svg/text/text-default-font-size-expected.html (rev 0) +++ trunk/LayoutTests/svg/text/text-default-font-size-expected.html 2015-05-21 17:36:32 UTC (rev 184719) @@ -0,0 +1,26 @@ +!DOCTYPE HTML +html +body + img src="" + svg xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink' +g + rect width='100%' height='100%' fill='Lime'/ + text x='10' y='25' font-size='16px'svg-text/text +/g +g transform='translate(40,40)' + rect width='100%' height='100%' fill='yellow'/ + text x='10' y='25' font-size='16px'svg-svg-text/text +/g +g transform='translate(80,80)' + rect width='100%' height='100%' fill='orange'/ + text x='10' y='25' font-size='16px'svg-image-text/text +/g +g transform='translate(120,120)' + rect width='100%' height='100%' fill='red'/ + text x='10' y='25' font-size='16px'svg-image-svg-text/text +/g + /svg +/body +/html + + Added: trunk/LayoutTests/svg/text/text-default-font-size.html (0 => 184719) --- trunk/LayoutTests/svg/text/text-default-font-size.html (rev 0) +++ trunk/LayoutTests/svg/text/text-default-font-size.html 2015-05-21 17:36:32 UTC (rev 184719) @@ -0,0 +1,40 @@ +!DOCTYPE HTML +html +body + img src="" + svg xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink' +rect width='100%' height='100%' fill='Lime'/ +text x='10' y='25'svg-text/text +svg xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink' x='40' y='40' + rect width='100%' height='100%' fill='yellow'/ + text x='10' y='25'svg-svg-text/text +/svg +image x='80' y='80' width='100%' height='100%' + xlink:href='' +/image + /svg +
