[webkit-changes] [186222] trunk/LayoutTests
Title: [186222] trunk/LayoutTests Revision 186222 Author achristen...@apple.com Date 2015-07-02 00:27:27 -0700 (Thu, 02 Jul 2015) Log Message Skip new web timing test on platforms without web timing. * platform/ios-sim-deprecated/Skipped: * platform/mac/TestExpectations: * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-sim-deprecated/Skipped trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (186221 => 186222) --- trunk/LayoutTests/ChangeLog 2015-07-02 07:08:20 UTC (rev 186221) +++ trunk/LayoutTests/ChangeLog 2015-07-02 07:27:27 UTC (rev 186222) @@ -1,3 +1,11 @@ +2015-07-02 Alex Christensen achristen...@webkit.org + +Skip new web timing test on platforms without web timing. + +* platform/ios-sim-deprecated/Skipped: +* platform/mac/TestExpectations: +* platform/win/TestExpectations: + 2015-07-01 Alex Christensen achristen...@webkit.org Fix test from r186208 and r186216. Modified: trunk/LayoutTests/platform/ios-sim-deprecated/Skipped (186221 => 186222) --- trunk/LayoutTests/platform/ios-sim-deprecated/Skipped 2015-07-02 07:08:20 UTC (rev 186221) +++ trunk/LayoutTests/platform/ios-sim-deprecated/Skipped 2015-07-02 07:27:27 UTC (rev 186222) @@ -650,6 +650,7 @@ fast/dom/webtiming-navigate-within-document.html http/tests/misc/webtiming-origins.html http/tests/misc/webtiming-one-redirect.php +http/tests/misc/webtiming-resolution.html http/tests/misc/webtiming-slow-load.php http/tests/misc/webtiming-ssl.php http/tests/misc/webtiming-two-redirects.php Modified: trunk/LayoutTests/platform/mac/TestExpectations (186221 => 186222) --- trunk/LayoutTests/platform/mac/TestExpectations 2015-07-02 07:08:20 UTC (rev 186221) +++ trunk/LayoutTests/platform/mac/TestExpectations 2015-07-02 07:27:27 UTC (rev 186222) @@ -848,6 +848,7 @@ [ Mavericks ] http/tests/misc/webtiming-cross-origin-redirect.php [ WontFix ] [ Mavericks ] http/tests/misc/webtiming-no-origin.html [ WontFix ] [ Mavericks ] http/tests/misc/webtiming-one-redirect.php [ WontFix ] +[ Mavericks ] http/tests/misc/webtiming-resolution.html [ WontFix ] [ Mavericks ] http/tests/misc/webtiming-slow-load.php [ WontFix ] [ Mavericks ] http/tests/misc/webtiming-ssl.php [ WontFix ] [ Mavericks ] http/tests/misc/webtiming-two-redirects.php [ WontFix ] Modified: trunk/LayoutTests/platform/win/TestExpectations (186221 => 186222) --- trunk/LayoutTests/platform/win/TestExpectations 2015-07-02 07:08:20 UTC (rev 186221) +++ trunk/LayoutTests/platform/win/TestExpectations 2015-07-02 07:27:27 UTC (rev 186222) @@ -345,6 +345,7 @@ webkit.org/b/42435 http/tests/misc/webtiming-cross-origin-redirect.php [ Skip ] webkit.org/b/42435 http/tests/misc/webtiming-no-origin.html [ Skip ] webkit.org/b/42435 http/tests/misc/webtiming-one-redirect.php [ Skip ] +webkit.org/b/42435 http/tests/misc/webtiming-resolution.html [ Skip ] webkit.org/b/42435 http/tests/misc/webtiming-slow-load.php [ Skip ] webkit.org/b/42435 http/tests/misc/webtiming-ssl.php [ Skip ] webkit.org/b/42435 http/tests/misc/webtiming-two-redirects.php [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186221] trunk/Source/WebKit2
Title: [186221] trunk/Source/WebKit2
Revision 186221
Author carlo...@webkit.org
Date 2015-07-02 00:08:20 -0700 (Thu, 02 Jul 2015)
Log Message
[GTK] Accelerated Compositing stops working after a web process crash
https://bugs.webkit.org/show_bug.cgi?id=146508
Reviewed by Martin Robinson.
The problem is that we don't send the window ID again to the new
web process.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::didRelaunchProcess): Call
webkitWebViewBaseDidRelaunchWebProcess().
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDidRelaunchWebProcess): Set the window ID to
the new drawing area.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186220 => 186221)
--- trunk/Source/WebKit2/ChangeLog 2015-07-02 06:59:50 UTC (rev 186220)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 07:08:20 UTC (rev 186221)
@@ -1,3 +1,21 @@
+2015-07-02 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] Accelerated Compositing stops working after a web process crash
+https://bugs.webkit.org/show_bug.cgi?id=146508
+
+Reviewed by Martin Robinson.
+
+The problem is that we don't send the window ID again to the new
+web process.
+
+* UIProcess/API/gtk/PageClientImpl.cpp:
+(WebKit::PageClientImpl::didRelaunchProcess): Call
+webkitWebViewBaseDidRelaunchWebProcess().
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseDidRelaunchWebProcess): Set the window ID to
+the new drawing area.
+* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
+
2015-07-01 Joseph Pecoraro pecor...@apple.com
Web Inspector: [Mac] InspectorFrontendHost.beep() doesn't play a sound, sandbox warnings
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp (186220 => 186221)
--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2015-07-02 06:59:50 UTC (rev 186220)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2015-07-02 07:08:20 UTC (rev 186221)
@@ -118,7 +118,7 @@
void PageClientImpl::didRelaunchProcess()
{
-notImplemented();
+webkitWebViewBaseDidRelaunchWebProcess(WEBKIT_WEB_VIEW_BASE(m_viewWidget));
}
void PageClientImpl::toolTipChanged(const String, const String newToolTip)
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (186220 => 186221)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2015-07-02 06:59:50 UTC (rev 186220)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2015-07-02 07:08:20 UTC (rev 186221)
@@ -1387,3 +1387,19 @@
UNUSED_PARAM(webkitWebViewBase);
#endif
}
+
+void webkitWebViewBaseDidRelaunchWebProcess(WebKitWebViewBase* webkitWebViewBase)
+{
+WebKitWebViewBasePrivate* priv = webkitWebViewBase-priv;
+DrawingAreaProxyImpl* drawingArea = static_castDrawingAreaProxyImpl*(priv-pageProxy-drawingArea());
+ASSERT(drawingArea);
+#if USE(REDIRECTED_XCOMPOSITE_WINDOW)
+if (!priv-redirectedWindow)
+return;
+drawingArea-setNativeSurfaceHandleForCompositing(priv-redirectedWindow-windowID());
+#else
+if (!gtk_widget_get_realized(GTK_WIDGET(webkitWebViewBase)))
+return;
+drawingArea-setNativeSurfaceHandleForCompositing(GDK_WINDOW_XID(gtk_widget_get_window(GTK_WIDGET(webkitWebViewBase;
+#endif
+}
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h (186220 => 186221)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h 2015-07-02 06:59:50 UTC (rev 186220)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h 2015-07-02 07:08:20 UTC (rev 186221)
@@ -71,6 +71,7 @@
void webkitWebViewBaseResetClickCounter(WebKitWebViewBase*);
void webkitWebViewBaseEnterAcceleratedCompositingMode(WebKitWebViewBase*);
void webkitWebViewBaseExitAcceleratedCompositingMode(WebKitWebViewBase*);
+void webkitWebViewBaseDidRelaunchWebProcess(WebKitWebViewBase*);
#if ENABLE(DRAG_SUPPORT)
WebKit::DragAndDropHandler webkitWebViewBaseDragAndDropHandler(WebKitWebViewBase*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186219] trunk/LayoutTests
Title: [186219] trunk/LayoutTests Revision 186219 Author achristen...@apple.com Date 2015-07-01 23:41:31 -0700 (Wed, 01 Jul 2015) Log Message Fix test from r186208 and r186216. * http/tests/misc/webtiming-resolution-expected.txt: * http/tests/misc/webtiming-resolution.html: Properly and explicitly test if the time delta is close to a multiple of the expected resolution. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/misc/webtiming-resolution-expected.txt trunk/LayoutTests/http/tests/misc/webtiming-resolution.html Diff Modified: trunk/LayoutTests/ChangeLog (186218 => 186219) --- trunk/LayoutTests/ChangeLog 2015-07-02 04:46:43 UTC (rev 186218) +++ trunk/LayoutTests/ChangeLog 2015-07-02 06:41:31 UTC (rev 186219) @@ -1,3 +1,11 @@ +2015-07-01 Alex Christensen achristen...@webkit.org + +Fix test from r186208 and r186216. + +* http/tests/misc/webtiming-resolution-expected.txt: +* http/tests/misc/webtiming-resolution.html: +Properly and explicitly test if the time delta is close to a multiple of the expected resolution. + 2015-07-01 Chris Dumez cdu...@apple.com Reduce resolution of performance.now Modified: trunk/LayoutTests/http/tests/misc/webtiming-resolution-expected.txt (186218 => 186219) --- trunk/LayoutTests/http/tests/misc/webtiming-resolution-expected.txt 2015-07-02 04:46:43 UTC (rev 186218) +++ trunk/LayoutTests/http/tests/misc/webtiming-resolution-expected.txt 2015-07-02 06:41:31 UTC (rev 186219) @@ -3,5 +3,5 @@ On success, you will see a series of PASS messages, followed by TEST COMPLETE. -PASS Math.abs(1 - (t1 - t0) / 0.005) 1e-10 is true +PASS shouldBeNearZeroOrOne 1e-10 || Math.abs(shouldBeNearZeroOrOne - 1) 1e-10 is true Modified: trunk/LayoutTests/http/tests/misc/webtiming-resolution.html (186218 => 186219) --- trunk/LayoutTests/http/tests/misc/webtiming-resolution.html 2015-07-02 04:46:43 UTC (rev 186218) +++ trunk/LayoutTests/http/tests/misc/webtiming-resolution.html 2015-07-02 06:41:31 UTC (rev 186219) @@ -14,7 +14,10 @@ t1 = performance.now(); } -shouldBe(Math.abs(1 - (t1 - t0) / 0.005) 1e-10, true); +var expectedResolutionMilliseconds = 0.005; +var integerMultipleOfResolution = (t1 - t0) / expectedResolutionMilliseconds; +var shouldBeNearZeroOrOne = integerMultipleOfResolution % 1; +shouldBe(shouldBeNearZeroOrOne 1e-10 || Math.abs(shouldBeNearZeroOrOne - 1) 1e-10, true); /script /body ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186223] trunk/Source/WebKit
Title: [186223] trunk/Source/WebKit Revision 186223 Author timothy_hor...@apple.com Date 2015-07-02 00:36:19 -0700 (Thu, 02 Jul 2015) Log Message iOS WebKitLegacy should match WebKit2's viewport behavior https://bugs.webkit.org/show_bug.cgi?id=146540 rdar://problem/20574017 Reviewed by Dan Bernstein. A number of changes have been made to WebKit2's viewport behavior to make it possible to scale responsive sites that misbehave (lay out in a non-responsive way). * History/WebHistoryItem.mm: * History/WebHistoryItemPrivate.h: Add the plumbing required to implement these new behaviors in WebKit1. * WebKit.iOS.exp: Modified Paths trunk/Source/WebKit/ios/ChangeLog trunk/Source/WebKit/ios/WebKit.iOS.exp trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/History/WebHistoryItem.mm trunk/Source/WebKit/mac/History/WebHistoryItemPrivate.h Diff Modified: trunk/Source/WebKit/ios/ChangeLog (186222 => 186223) --- trunk/Source/WebKit/ios/ChangeLog 2015-07-02 07:27:27 UTC (rev 186222) +++ trunk/Source/WebKit/ios/ChangeLog 2015-07-02 07:36:19 UTC (rev 186223) @@ -1,3 +1,13 @@ +2015-07-02 Timothy Horton timothy_hor...@apple.com + +iOS WebKitLegacy should match WebKit2's viewport behavior +https://bugs.webkit.org/show_bug.cgi?id=146540 +rdar://problem/20574017 + +Reviewed by Dan Bernstein. + +* WebKit.iOS.exp: + 2015-06-25 Joseph Pecoraro pecor...@apple.com Unreviewed, attempt to fix the iOS build after r185968. Modified: trunk/Source/WebKit/ios/WebKit.iOS.exp (186222 => 186223) --- trunk/Source/WebKit/ios/WebKit.iOS.exp 2015-07-02 07:27:27 UTC (rev 186222) +++ trunk/Source/WebKit/ios/WebKit.iOS.exp 2015-07-02 07:36:19 UTC (rev 186223) @@ -21,6 +21,7 @@ _WebViewportMaximumScaleKey _WebViewportMinimumScaleKey _WebViewportUserScalableKey +_WebViewportShrinkToFitKey _WebViewportWidthKey # So that we can use the MemoryMeasure class in MobileSafari Modified: trunk/Source/WebKit/mac/ChangeLog (186222 => 186223) --- trunk/Source/WebKit/mac/ChangeLog 2015-07-02 07:27:27 UTC (rev 186222) +++ trunk/Source/WebKit/mac/ChangeLog 2015-07-02 07:36:19 UTC (rev 186223) @@ -1,3 +1,19 @@ +2015-07-02 Timothy Horton timothy_hor...@apple.com + +iOS WebKitLegacy should match WebKit2's viewport behavior +https://bugs.webkit.org/show_bug.cgi?id=146540 +rdar://problem/20574017 + +Reviewed by Dan Bernstein. + +A number of changes have been made to WebKit2's viewport behavior +to make it possible to scale responsive sites that misbehave (lay out +in a non-responsive way). + +* History/WebHistoryItem.mm: +* History/WebHistoryItemPrivate.h: +Add the plumbing required to implement these new behaviors in WebKit1. + 2015-07-01 Dean Jackson d...@apple.com Disable the experimental WebGL2 implementation Modified: trunk/Source/WebKit/mac/History/WebHistoryItem.mm (186222 => 186223) --- trunk/Source/WebKit/mac/History/WebHistoryItem.mm 2015-07-02 07:27:27 UTC (rev 186222) +++ trunk/Source/WebKit/mac/History/WebHistoryItem.mm 2015-07-02 07:36:19 UTC (rev 186223) @@ -62,6 +62,7 @@ NSString *WebViewportMinimumScaleKey = @minimum-scale; NSString *WebViewportMaximumScaleKey = @maximum-scale; NSString *WebViewportUserScalableKey = @user-scalable; +NSString *WebViewportShrinkToFitKey = @shrink-to-fit; NSString *WebViewportWidthKey= @width; NSString *WebViewportHeightKey = @height; @@ -613,6 +614,7 @@ [argumentsDictionary setObject:[NSNumber numberWithFloat:viewportArguments.width] forKey:WebViewportWidthKey]; [argumentsDictionary setObject:[NSNumber numberWithFloat:viewportArguments.height] forKey:WebViewportHeightKey]; [argumentsDictionary setObject:[NSNumber numberWithFloat:viewportArguments.userZoom] forKey:WebViewportUserScalableKey]; +[argumentsDictionary setObject:[NSNumber numberWithFloat:viewportArguments.shrinkToFit] forKey:WebViewportShrinkToFitKey]; return argumentsDictionary; } @@ -625,6 +627,7 @@ viewportArguments.width = [[arguments objectForKey:WebViewportWidthKey] floatValue]; viewportArguments.height = [[arguments objectForKey:WebViewportHeightKey] floatValue]; viewportArguments.userZoom = [[arguments objectForKey:WebViewportUserScalableKey] floatValue]; +viewportArguments.shrinkToFit = [[arguments objectForKey:WebViewportShrinkToFitKey] floatValue]; core(_private)-setViewportArguments(viewportArguments); } Modified: trunk/Source/WebKit/mac/History/WebHistoryItemPrivate.h (186222 => 186223) --- trunk/Source/WebKit/mac/History/WebHistoryItemPrivate.h 2015-07-02 07:27:27 UTC (rev 186222) +++ trunk/Source/WebKit/mac/History/WebHistoryItemPrivate.h 2015-07-02 07:36:19 UTC (rev 186223) @@ -33,6 +33,7 @@ extern NSString *WebViewportMinimumScaleKey; extern NSString *WebViewportMaximumScaleKey; extern NSString *WebViewportUserScalableKey; +extern NSString *WebViewportShrinkToFitKey;
[webkit-changes] [186220] trunk/Source
Title: [186220] trunk/Source Revision 186220 Author achristen...@apple.com Date 2015-07-01 23:59:50 -0700 (Wed, 01 Jul 2015) Log Message Source/ThirdParty/ANGLE: Re-enable WebGL on WinCairo https://bugs.webkit.org/show_bug.cgi?id=146537 Reviewed by Csaba Osztrogonác. * ANGLE.vcxproj/DirectX32.props: * ANGLE.vcxproj/DirectX64.props: * ANGLE.vcxproj/libGLESv2Common.props: Update DirectX directories to use the Windows SDK instead of the June 2010 DirectX SDK. Source/WebKit: Re-enable WebGL on WinCairo. https://bugs.webkit.org/show_bug.cgi?id=146537 Reviewed by Csaba Osztrogonác. * WebKit.vcxproj/WebKit.sln: Build the ANGLE projects on WinCairo again. Source/WTF: Re-enable WebGL on WinCairo https://bugs.webkit.org/show_bug.cgi?id=146537 Reviewed by Csaba Osztrogonác. * wtf/FeatureDefines.h: Enable WebGL on WinCairo again. Modified Paths trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/DirectX32.props trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/DirectX64.props trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/libGLESv2Common.props trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/FeatureDefines.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebKit.vcxproj/WebKit.sln Diff Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/DirectX32.props (186219 => 186220) --- trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/DirectX32.props 2015-07-02 06:41:31 UTC (rev 186219) +++ trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/DirectX32.props 2015-07-02 06:59:50 UTC (rev 186220) @@ -5,7 +5,7 @@ PropertyGroup / ItemDefinitionGroup Link - AdditionalLibraryDirectories$(DXSDK_DIR)Lib\x86\;%(AdditionalLibraryDirectories)/AdditionalLibraryDirectories + AdditionalLibraryDirectories$(WindowsSDK_LibraryPath_x86);%(AdditionalLibraryDirectories)/AdditionalLibraryDirectories /Link /ItemDefinitionGroup ItemGroup / Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/DirectX64.props (186219 => 186220) --- trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/DirectX64.props 2015-07-02 06:41:31 UTC (rev 186219) +++ trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/DirectX64.props 2015-07-02 06:59:50 UTC (rev 186220) @@ -5,7 +5,7 @@ PropertyGroup / ItemDefinitionGroup Link - AdditionalLibraryDirectories$(DXSDK_DIR)Lib\x64\;%(AdditionalLibraryDirectories)/AdditionalLibraryDirectories + AdditionalLibraryDirectories$(WindowsSDK_LibraryPath_x64);%(AdditionalLibraryDirectories)/AdditionalLibraryDirectories /Link /ItemDefinitionGroup ItemGroup / Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/libGLESv2Common.props (186219 => 186220) --- trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/libGLESv2Common.props 2015-07-02 06:41:31 UTC (rev 186219) +++ trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/libGLESv2Common.props 2015-07-02 06:59:50 UTC (rev 186220) @@ -4,13 +4,13 @@ PropertyGroup Label=UserMacros / ItemDefinitionGroup ClCompile - AdditionalIncludeDirectories..\src;..\src\libGLESv2;..\include;..\include\KHR;$(DXSDK_DIR)\Include/AdditionalIncludeDirectories + AdditionalIncludeDirectories..\src;..\src\libGLESv2;..\include;..\include\KHR;$(WindowsSDK_IncludePath)/AdditionalIncludeDirectories PreprocessorDefinitionsLIBGLESV2_IMPLEMENTATION;ANGLE_DEFAULT_D3D11=1;ANGLE_ENABLE_D3D9;ANGLE_ENABLE_D3D11;NOMINMAX;ANGLE_WEBKIT_WIN;ANGLE_SKIP_DXGI_1_2_CHECK=1;%(PreprocessorDefinitions)/PreprocessorDefinitions /ClCompile Link ModuleDefinitionFile../src/libGLESv2/libGLESv2.def/ModuleDefinitionFile AdditionalDependenciesd3d9.lib;dxguid.lib;translator_common$(DebugSuffix).lib;translator_hlsl$(DebugSuffix).lib;translator_glsl$(DebugSuffix).lib;preprocessor$(DebugSuffix).lib;%(AdditionalDependencies)/AdditionalDependencies - AdditionalLibraryDirectories$(DXSDK_DIR)\Lib\$(PlatformTarget);$(CONFIGURATIONBUILDDIR)\lib$(PlatformArchitecture)/AdditionalLibraryDirectories + AdditionalLibraryDirectories$(CONFIGURATIONBUILDDIR)\lib$(PlatformArchitecture)/AdditionalLibraryDirectories GenerateDebugInformationtrue/GenerateDebugInformation /Link ResourceCompile Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (186219 => 186220) --- trunk/Source/ThirdParty/ANGLE/ChangeLog 2015-07-02 06:41:31 UTC (rev 186219) +++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2015-07-02 06:59:50 UTC (rev 186220) @@ -1,5 +1,17 @@ 2015-07-01 Alex Christensen achristen...@webkit.org +Re-enable WebGL on WinCairo +https://bugs.webkit.org/show_bug.cgi?id=146537 + +Reviewed by Csaba Osztrogonác. + +* ANGLE.vcxproj/DirectX32.props: +* ANGLE.vcxproj/DirectX64.props: +* ANGLE.vcxproj/libGLESv2Common.props: +Update DirectX directories to use the Windows SDK instead of the June 2010 DirectX SDK. + +2015-07-01 Alex Christensen achristen...@webkit.org + Fix ANGLE Windows build after r186169. https://bugs.webkit.org/show_bug.cgi?id=146532 Modified:
[webkit-changes] [186225] trunk
Title: [186225] trunk
Revision 186225
Author carlo...@webkit.org
Date 2015-07-02 06:00:35 -0700 (Thu, 02 Jul 2015)
Log Message
[GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
https://bugs.webkit.org/show_bug.cgi?id=146234
Reviewed by Sergio Villar Senin.
Source/WebKit2:
This is because we don't provide any quota, and 0 is used by
default, so there's never enough quota and openDatabase fails. We
should expose this in the API, but for now, we could use a default
quota of 5MB like WTR does.
* UIProcess/API/gtk/WebKitUIClient.cpp: Override
exceededDatabaseQuota and return always the default quota.
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::exceededDatabaseQuota): Return the quota based on the
expected usage and current database usabe like mac does.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Add
custom UI client to implement exceededDatabaseQuota.
Tools:
Enable the WebSQL directory test that was disabled because of this bug.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
(testWebContextConfiguration):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186224 => 186225)
--- trunk/Source/WebKit2/ChangeLog 2015-07-02 12:13:58 UTC (rev 186224)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 13:00:35 UTC (rev 186225)
@@ -1,3 +1,23 @@
+2015-07-02 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
+https://bugs.webkit.org/show_bug.cgi?id=146234
+
+Reviewed by Sergio Villar Senin.
+
+This is because we don't provide any quota, and 0 is used by
+default, so there's never enough quota and openDatabase fails. We
+should expose this in the API, but for now, we could use a default
+quota of 5MB like WTR does.
+
+* UIProcess/API/gtk/WebKitUIClient.cpp: Override
+exceededDatabaseQuota and return always the default quota.
+* UIProcess/gtk/WebInspectorProxyGtk.cpp:
+(WebKit::exceededDatabaseQuota): Return the quota based on the
+expected usage and current database usabe like mac does.
+(WebKit::WebInspectorProxy::platformCreateInspectorPage): Add
+custom UI client to implement exceededDatabaseQuota.
+
2015-07-02 Commit Queue commit-qu...@webkit.org
Unreviewed, rolling out r185704.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp (186224 => 186225)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp 2015-07-02 12:13:58 UTC (rev 186224)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp 2015-07-02 13:00:35 UTC (rev 186225)
@@ -146,6 +146,13 @@
return WebCore::FloatRect(geometry);
}
+virtual void exceededDatabaseQuota(WebPageProxy*, WebFrameProxy*, API::SecurityOrigin*, const String, const String, unsigned long long /*currentQuota*/, unsigned long long /*currentOriginUsage*/, unsigned long long /*currentDatabaseUsage*/, unsigned long long /*expectedUsage*/, std::functionvoid (unsigned long long) completionHandler) override
+{
+static const unsigned long long defaultQuota = 5 * 1024 * 1204; // 5 MB
+// FIXME: Provide API for this.
+completionHandler(defaultQuota);
+}
+
virtual bool runOpenPanel(WebPageProxy*, WebFrameProxy*, WebOpenPanelParameters* parameters, WebOpenPanelResultListenerProxy* listener) override
{
GRefPtrWebKitFileChooserRequest request = adoptGRef(webkitFileChooserRequestCreate(parameters, listener));
Modified: trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp (186224 => 186225)
--- trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp 2015-07-02 12:13:58 UTC (rev 186224)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp 2015-07-02 13:00:35 UTC (rev 186225)
@@ -52,6 +52,11 @@
inspectorProxy-close();
}
+static unsigned long long exceededDatabaseQuota(WKPageRef, WKFrameRef, WKSecurityOriginRef, WKStringRef, WKStringRef, unsigned long long, unsigned long long, unsigned long long currentDatabaseUsage, unsigned long long expectedUsage, const void*)
+{
+return std::maxunsigned long long(expectedUsage, currentDatabaseUsage * 1.25);
+}
+
void WebInspectorProxy::initializeInspectorClientGtk(const WKInspectorClientGtkBase* inspectorClient)
{
m_client.initialize(inspectorClient);
@@ -75,7 +80,61 @@
m_inspectorView = GTK_WIDGET(webkitWebViewBaseCreate(inspectorProcessPool(), preferences.get(), pageGroup.get(), nullptr, nullptr));
g_object_add_weak_pointer(G_OBJECT(m_inspectorView), reinterpret_castvoid**(m_inspectorView));
-return webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(m_inspectorView));
+
[webkit-changes] [186224] trunk/Source/WebKit2
Title: [186224] trunk/Source/WebKit2
Revision 186224
Author commit-qu...@webkit.org
Date 2015-07-02 05:13:58 -0700 (Thu, 02 Jul 2015)
Log Message
Unreviewed, rolling out r185704.
https://bugs.webkit.org/show_bug.cgi?id=146544
Didn't fix the problem (Requested by anttik on #webkit).
Reverted changeset:
~4% Membuster regression after WebKit r185452
https://bugs.webkit.org/show_bug.cgi?id=146112
http://trac.webkit.org/changeset/185704
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.h
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186223 => 186224)
--- trunk/Source/WebKit2/ChangeLog 2015-07-02 07:36:19 UTC (rev 186223)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 12:13:58 UTC (rev 186224)
@@ -1,3 +1,16 @@
+2015-07-02 Commit Queue commit-qu...@webkit.org
+
+Unreviewed, rolling out r185704.
+https://bugs.webkit.org/show_bug.cgi?id=146544
+
+Didn't fix the problem (Requested by anttik on #webkit).
+
+Reverted changeset:
+
+~4% Membuster regression after WebKit r185452
+https://bugs.webkit.org/show_bug.cgi?id=146112
+http://trac.webkit.org/changeset/185704
+
2015-07-02 Carlos Garcia Campos cgar...@igalia.com
[GTK] Accelerated Compositing stops working after a web process crash
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (186223 => 186224)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2015-07-02 07:36:19 UTC (rev 186223)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2015-07-02 12:13:58 UTC (rev 186224)
@@ -176,10 +176,6 @@
void NetworkProcess::lowMemoryHandler(Critical critical)
{
platformLowMemoryHandler(critical);
-#if ENABLE(NETWORK_CACHE)
-if (NetworkCache::singleton().isEnabled())
-NetworkCache::singleton().handleMemoryPressureNotification(critical);
-#endif
WTF::releaseFastMallocFreeMemory();
}
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp (186223 => 186224)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp 2015-07-02 07:36:19 UTC (rev 186223)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp 2015-07-02 12:13:58 UTC (rev 186224)
@@ -563,16 +563,6 @@
clear(std::chrono::system_clock::time_point::min(), nullptr);
}
-void Cache::handleMemoryPressureNotification(WebCore::Critical critical)
-{
-if (critical != WebCore::Critical::Yes)
-return;
-// There can be substantial amount of memory in the write queue and we don't know how long it will take to write it out.
-// We may also be about to suspend the process.
-if (m_storage)
-m_storage-clearWriteQueue();
-}
-
String Cache::recordsPath() const
{
return m_storage ? m_storage-recordsPath() : String();
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.h (186223 => 186224)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.h 2015-07-02 07:36:19 UTC (rev 186223)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.h 2015-07-02 12:13:58 UTC (rev 186224)
@@ -31,7 +31,6 @@
#include NetworkCacheEntry.h
#include NetworkCacheStorage.h
#include ShareableResource.h
-#include WebCore/MemoryPressureHandler.h
#include WebCore/ResourceResponse.h
#include wtf/text/WTFString.h
@@ -104,8 +103,6 @@
void clear();
void clear(std::chrono::system_clock::time_point modifiedSince, std::functionvoid () completionHandler);
-void handleMemoryPressureNotification(WebCore::Critical);
-
void dumpContentsToFile();
String recordsPath() const;
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp (186223 => 186224)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2015-07-02 07:36:19 UTC (rev 186223)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2015-07-02 12:13:58 UTC (rev 186224)
@@ -908,13 +908,6 @@
});
}
-void Storage::clearWriteQueue()
-{
-LOG(NetworkCacheStorage, (NetworkProcess) clearing write queue);
-
-m_pendingWriteOperations.clear();
-}
-
void Storage::deleteOldVersions()
{
backgroundIOQueue().dispatch([this] {
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h (186223 => 186224)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h 2015-07-02 07:36:19 UTC (rev 186223)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h 2015-07-02 12:13:58 UTC (rev 186224)
@@ -80,8 +80,6 @@
// Null record signals end.
void traverse(TraverseFlags, TraverseHandler);
-void clearWriteQueue();
-
void setCapacity(size_t);
size_t capacity() const { return m_capacity; }
size_t approximateSize() const;
[webkit-changes] [186233] trunk/Source/WebKit2
Title: [186233] trunk/Source/WebKit2
Revision 186233
Author achristen...@apple.com
Date 2015-07-02 13:39:19 -0700 (Thu, 02 Jul 2015)
Log Message
Fix EWS build after r186182.
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::userMediaPermissionRequestManager):
Don't export a function defined in a header, or it will generate a weak external symbol.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186232 => 186233)
--- trunk/Source/WebKit2/ChangeLog 2015-07-02 20:19:36 UTC (rev 186232)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 20:39:19 UTC (rev 186233)
@@ -1,3 +1,11 @@
+2015-07-02 Alex Christensen achristen...@webkit.org
+
+Fix EWS build after r186182.
+
+* WebProcess/WebPage/WebPage.h:
+(WebKit::WebPage::userMediaPermissionRequestManager):
+Don't export a function defined in a header, or it will generate a weak external symbol.
+
2015-07-02 Brady Eidson beid...@apple.com
Add preference to disable all http-equiv.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (186232 => 186233)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2015-07-02 20:19:36 UTC (rev 186232)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2015-07-02 20:39:19 UTC (rev 186233)
@@ -465,7 +465,7 @@
#endif
#if ENABLE(MEDIA_STREAM)
-WK_EXPORT UserMediaPermissionRequestManager userMediaPermissionRequestManager() { return m_userMediaPermissionRequestManager; }
+UserMediaPermissionRequestManager userMediaPermissionRequestManager() { return m_userMediaPermissionRequestManager; }
#endif
#if PLATFORM(IOS)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186234] trunk/Source/WebKit2
Title: [186234] trunk/Source/WebKit2
Revision 186234
Author beid...@apple.com
Date 2015-07-02 13:47:57 -0700 (Thu, 02 Jul 2015)
Log Message
Remove change I accidentally committed in r186232
* UIProcess/WebsiteData/WebsiteDataStore.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186233 => 186234)
--- trunk/Source/WebKit2/ChangeLog 2015-07-02 20:39:19 UTC (rev 186233)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 20:47:57 UTC (rev 186234)
@@ -1,3 +1,9 @@
+2015-07-02 Brady Eidson beid...@apple.com
+
+Remove change I accidentally committed in r186232
+
+* UIProcess/WebsiteData/WebsiteDataStore.h:
+
2015-07-02 Alex Christensen achristen...@webkit.org
Fix EWS build after r186182.
Modified: trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h (186233 => 186234)
--- trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h 2015-07-02 20:39:19 UTC (rev 186233)
+++ trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h 2015-07-02 20:47:57 UTC (rev 186234)
@@ -74,7 +74,7 @@
static void cloneSessionData(WebPageProxy sourcePage, WebPageProxy newPage);
void fetchData(WebsiteDataTypes, std::functionvoid (VectorWebsiteDataRecord) completionHandler);
-//void removeData(WebsiteDataTypes, std::chrono::system_clock::time_point modifiedSince, std::functionvoid () completionHandler);
+void removeData(WebsiteDataTypes, std::chrono::system_clock::time_point modifiedSince, std::functionvoid () completionHandler);
void removeData(WebsiteDataTypes, const VectorWebsiteDataRecord, std::functionvoid () completionHandler);
StorageManager* storageManager() { return m_storageManager.get(); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186240] trunk/Source/WebKit/mac
Title: [186240] trunk/Source/WebKit/mac Revision 186240 Author timothy_hor...@apple.com Date 2015-07-02 15:44:04 -0700 (Thu, 02 Jul 2015) Log Message Fix the build. Rubber-stamped by Brady Eidson. * WebView/WebView.mm: (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Http, not HTTP, for settings generator reasons. Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebView.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (186239 => 186240) --- trunk/Source/WebKit/mac/ChangeLog 2015-07-02 22:32:27 UTC (rev 186239) +++ trunk/Source/WebKit/mac/ChangeLog 2015-07-02 22:44:04 UTC (rev 186240) @@ -1,3 +1,13 @@ +2015-07-02 Timothy Horton timothy_hor...@apple.com + +Fix the build. + +Rubber-stamped by Brady Eidson. + +* WebView/WebView.mm: +(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): +Http, not HTTP, for settings generator reasons. + 2015-07-02 Brady Eidson beid...@apple.com Add preference to disable all http-equiv. Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (186239 => 186240) --- trunk/Source/WebKit/mac/WebView/WebView.mm 2015-07-02 22:32:27 UTC (rev 186239) +++ trunk/Source/WebKit/mac/WebView/WebView.mm 2015-07-02 22:44:04 UTC (rev 186240) @@ -1233,7 +1233,7 @@ _private-page-settings().setMinimumFontSize([_private-preferences minimumFontSize]); // This is a workaround for rdar://problem/21309911. -_private-page-settings().setHTTPEquivEnabled([_private-preferences httpEquivEnabled]); +_private-page-settings().setHttpEquivEnabled([_private-preferences httpEquivEnabled]); _private-page-setGroupName(groupName); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186241] trunk/Source/WebKit2
Title: [186241] trunk/Source/WebKit2 Revision 186241 Author bfulg...@apple.com Date 2015-07-02 15:57:03 -0700 (Thu, 02 Jul 2015) Log Message Correct *another* typo in r186238. * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Fix parameter name scrolView - scrollView. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h Diff Modified: trunk/Source/WebKit2/ChangeLog (186240 => 186241) --- trunk/Source/WebKit2/ChangeLog 2015-07-02 22:44:04 UTC (rev 186240) +++ trunk/Source/WebKit2/ChangeLog 2015-07-02 22:57:03 UTC (rev 186241) @@ -1,5 +1,11 @@ 2015-07-02 Brent Fulgham bfulg...@apple.com +Correct *another* typo in r186238. + +* UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Fix parameter name scrolView - scrollView. + +2015-07-02 Brent Fulgham bfulg...@apple.com + Correct typo in r186238. * UIProcess/API/Cocoa/WKWebView.mm: Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h (186240 => 186241) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h 2015-07-02 22:44:04 UTC (rev 186240) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h 2015-07-02 22:57:03 UTC (rev 186241) @@ -62,7 +62,7 @@ - (void)_webView:(WKWebView *)webView willPreviewImageWithURL:(NSURL *)imageURL WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); - (void)_webView:(WKWebView *)webView commitPreviewedImageWithURL:(NSURL *)imageURL WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); - (void)_webView:(WKWebView *)webView didDismissPreviewViewController:(UIViewController *)previewedViewController; -- (UIEdgeInsets)_webView:(WKWebView *)webView finalObscuredInsetsForScrollView:(UIScrollView *)scrolView withVelocity:(CGPoint)velocity targetContentOffset:(inout CGPoint *)targetContentOffset; +- (UIEdgeInsets)_webView:(WKWebView *)webView finalObscuredInsetsForScrollView:(UIScrollView *)scrollView withVelocity:(CGPoint)velocity targetContentOffset:(inout CGPoint *)targetContentOffset; #endif @end ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186243] trunk/Source/WebKit2
Title: [186243] trunk/Source/WebKit2
Revision 186243
Author mark@apple.com
Date 2015-07-02 16:32:00 -0700 (Thu, 02 Jul 2015)
Log Message
Gardening: fix broken 32-bit build..
https://bugs.webkit.org/show_bug.cgi?id=146416
Not reviewed.
* UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:
(API::SerializedScriptValue::deserialize):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186242 => 186243)
--- trunk/Source/WebKit2/ChangeLog 2015-07-02 23:31:52 UTC (rev 186242)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 23:32:00 UTC (rev 186243)
@@ -1,3 +1,13 @@
+2015-07-02 Mark Lam mark@apple.com
+
+Gardening: fix broken 32-bit build..
+https://bugs.webkit.org/show_bug.cgi?id=146416
+
+Not reviewed.
+
+* UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:
+(API::SerializedScriptValue::deserialize):
+
2015-07-02 Brent Fulgham bfulg...@apple.com
Correct *another* typo in r186238.
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm (186242 => 186243)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm 2015-07-02 23:31:52 UTC (rev 186242)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm 2015-07-02 23:32:00 UTC (rev 186243)
@@ -31,6 +31,8 @@
#import wtf/NeverDestroyed.h
#import wtf/RunLoop.h
+#if WK_API_ENABLED
+
namespace API {
class SharedJSContext {
@@ -74,3 +76,5 @@
}
} // API
+
+#endif // WK_API_ENABLED
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186242] trunk/Source/bmalloc
Title: [186242] trunk/Source/bmalloc Revision 186242 Author gga...@apple.com Date 2015-07-02 16:31:52 -0700 (Thu, 02 Jul 2015) Log Message bmalloc: Shrink the super chunk size https://bugs.webkit.org/show_bug.cgi?id=146519 Reviewed by Andreas Kling. We have lots of reports of crashing due to failed VM allocation on iOS. (This VM limit on iOS is usually 1GB-2GB, and has been as low as 256MB.) Shrink the super chunk size in case fragmentation is the reason for VM allocation failure. This has the downside that = 2MB allocations will now be super slow, but they are also super rare (as in never on most websites), so this is probably an OK tradeoff. * bmalloc/Sizes.h: Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/SegregatedFreeList.h trunk/Source/bmalloc/bmalloc/Sizes.h Diff Modified: trunk/Source/bmalloc/ChangeLog (186241 => 186242) --- trunk/Source/bmalloc/ChangeLog 2015-07-02 22:57:03 UTC (rev 186241) +++ trunk/Source/bmalloc/ChangeLog 2015-07-02 23:31:52 UTC (rev 186242) @@ -1,3 +1,22 @@ +2015-07-02 Geoffrey Garen gga...@apple.com + +bmalloc: Shrink the super chunk size +https://bugs.webkit.org/show_bug.cgi?id=146519 + +Reviewed by Andreas Kling. + +We have lots of reports of crashing due to failed VM allocation on iOS. +(This VM limit on iOS is usually 1GB-2GB, and has been as low as 256MB.) + +Shrink the super chunk size in case fragmentation is the reason for +VM allocation failure. + +This has the downside that = 2MB allocations will now be super slow, +but they are also super rare (as in never on most websites), so this +is probably an OK tradeoff. + +* bmalloc/Sizes.h: + 2015-07-01 Geoffrey Garen gga...@apple.com bmalloc: realloc of an XLarge range can unmap adjacent VM ranges Modified: trunk/Source/bmalloc/bmalloc/SegregatedFreeList.h (186241 => 186242) --- trunk/Source/bmalloc/bmalloc/SegregatedFreeList.h 2015-07-02 22:57:03 UTC (rev 186241) +++ trunk/Source/bmalloc/bmalloc/SegregatedFreeList.h 2015-07-02 23:31:52 UTC (rev 186242) @@ -60,7 +60,7 @@ FreeList select(size_t); Owner m_owner; -std::arrayFreeList, 19 m_freeLists; +std::arrayFreeList, 17 m_freeLists; }; } // namespace bmalloc Modified: trunk/Source/bmalloc/bmalloc/Sizes.h (186241 => 186242) --- trunk/Source/bmalloc/bmalloc/Sizes.h 2015-07-02 22:57:03 UTC (rev 186241) +++ trunk/Source/bmalloc/bmalloc/Sizes.h 2015-07-02 23:31:52 UTC (rev 186242) @@ -53,7 +53,7 @@ #endif static const size_t vmPageMask = ~(vmPageSize - 1); -static const size_t superChunkSize = 32 * MB; +static const size_t superChunkSize = 8 * MB; static const size_t smallMax = 256; static const size_t smallLineSize = 256; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186249] trunk/Source/WebCore
Title: [186249] trunk/Source/WebCore
Revision 186249
Author d...@apple.com
Date 2015-07-02 18:27:25 -0700 (Thu, 02 Jul 2015)
Log Message
Tapping a video in Safari causes the video to flash gray for a quick moment
https://bugs.webkit.org/show_bug.cgi?id=146570
rdar://problem/21325181
Reviewed by Brent Fulgham.
On iOS, video elements should not show the tap highlight.
* css/html.css:
(video):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (186248 => 186249)
--- trunk/Source/WebCore/ChangeLog 2015-07-03 00:53:10 UTC (rev 186248)
+++ trunk/Source/WebCore/ChangeLog 2015-07-03 01:27:25 UTC (rev 186249)
@@ -1,5 +1,18 @@
2015-07-02 Dean Jackson d...@apple.com
+Tapping a video in Safari causes the video to flash gray for a quick moment
+https://bugs.webkit.org/show_bug.cgi?id=146570
+rdar://problem/21325181
+
+Reviewed by Brent Fulgham.
+
+On iOS, video elements should not show the tap highlight.
+
+* css/html.css:
+(video):
+
+2015-07-02 Dean Jackson d...@apple.com
+
WebKit should use 80% white background for PiP indicator
https://bugs.webkit.org/show_bug.cgi?id=146444
rdar://problem/21555726
Modified: trunk/Source/WebCore/css/html.css (186248 => 186249)
--- trunk/Source/WebCore/css/html.css 2015-07-03 00:53:10 UTC (rev 186248)
+++ trunk/Source/WebCore/css/html.css 2015-07-03 01:27:25 UTC (rev 186249)
@@ -106,6 +106,9 @@
video {
object-fit: contain;
+#if defined(WTF_PLATFORM_IOS) WTF_PLATFORM_IOS
+-webkit-tap-highlight-color: transparent;
+#endif
}
/* heading elements */
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186251] trunk/Source/WebCore
Title: [186251] trunk/Source/WebCore
Revision 186251
Author bfulg...@apple.com
Date 2015-07-02 18:44:40 -0700 (Thu, 02 Jul 2015)
Log Message
Ensure media playback is stopped during page close
https://bugs.webkit.org/show_bug.cgi?id=146554
rdar://problem/18033944
Reviewed by Zalan Bujtas.
Add new method to Page class to stop all media playback. It just uses the process
MediaSessionManager singleton to inform all hosted in a particular document to stop.
* Modules/webaudio/AudioContext.h:
(WebCore::WebAudio::hostingDocument): Added.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::hostingDocument): Added.
* dom/Document.cpp:
(WebCore::Document::commonTeardown): Call the new PlatformMediaSessionManager::stopAllMediaPlaybackForDocument
method on document cleanup.
* platform/audio/PlatformMediaSession.h:
Made PlatformMediaSessionManager a friend so it can access the protected 'client' accessor.
Updated PlatformMediaSessionClient to require clients to have a hostingDocument member.
* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::stopAllMediaPlaybackForDocument): Added. Only pauses
playback on elements that match the provided document.
* platform/audio/PlatformMediaSessionManager.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioContext.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/audio/PlatformMediaSession.h
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (186250 => 186251)
--- trunk/Source/WebCore/ChangeLog 2015-07-03 01:43:21 UTC (rev 186250)
+++ trunk/Source/WebCore/ChangeLog 2015-07-03 01:44:40 UTC (rev 186251)
@@ -1,3 +1,29 @@
+2015-07-02 Brent Fulgham bfulg...@apple.com
+
+Ensure media playback is stopped during page close
+https://bugs.webkit.org/show_bug.cgi?id=146554
+rdar://problem/18033944
+
+Reviewed by Zalan Bujtas.
+
+Add new method to Page class to stop all media playback. It just uses the process
+MediaSessionManager singleton to inform all hosted in a particular document to stop.
+
+* Modules/webaudio/AudioContext.h:
+(WebCore::WebAudio::hostingDocument): Added.
+* html/HTMLMediaElement.h:
+(WebCore::HTMLMediaElement::hostingDocument): Added.
+* dom/Document.cpp:
+(WebCore::Document::commonTeardown): Call the new PlatformMediaSessionManager::stopAllMediaPlaybackForDocument
+method on document cleanup.
+* platform/audio/PlatformMediaSession.h:
+Made PlatformMediaSessionManager a friend so it can access the protected 'client' accessor.
+Updated PlatformMediaSessionClient to require clients to have a hostingDocument member.
+* platform/audio/PlatformMediaSessionManager.cpp:
+(WebCore::PlatformMediaSessionManager::stopAllMediaPlaybackForDocument): Added. Only pauses
+playback on elements that match the provided document.
+* platform/audio/PlatformMediaSessionManager.h:
+
2015-07-02 Dean Jackson d...@apple.com
Tapping a video in Safari causes the video to flash gray for a quick moment
Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.h (186250 => 186251)
--- trunk/Source/WebCore/Modules/webaudio/AudioContext.h 2015-07-03 01:43:21 UTC (rev 186250)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.h 2015-07-03 01:44:40 UTC (rev 186251)
@@ -90,6 +90,8 @@
Document* document() const; // ASSERTs if document no longer exists.
+Document* hostingDocument() const override final { return document(); }
+
AudioDestinationNode* destination() { return m_destinationNode.get(); }
size_t currentSampleFrame() const { return m_destinationNode-currentSampleFrame(); }
double currentTime() const { return m_destinationNode-currentTime(); }
Modified: trunk/Source/WebCore/dom/Document.cpp (186250 => 186251)
--- trunk/Source/WebCore/dom/Document.cpp 2015-07-03 01:43:21 UTC (rev 186250)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-07-03 01:44:40 UTC (rev 186251)
@@ -112,6 +112,7 @@
#include PageGroup.h
#include PageTransitionEvent.h
#include PlatformLocale.h
+#include PlatformMediaSessionManager.h
#include PlatformStrategies.h
#include PlugInsResources.h
#include PluginDocument.h
@@ -700,6 +701,8 @@
if (svgExtensions())
accessSVGExtensions().pauseAnimations();
+PlatformMediaSessionManager::sharedManager().stopAllMediaPlaybackForDocument(*this);
+
#if ENABLE(REQUEST_ANIMATION_FRAME)
clearScriptedAnimationController();
#endif
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (186250 => 186251)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2015-07-03 01:43:21 UTC (rev 186250)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2015-07-03 01:44:40 UTC (rev
[webkit-changes] [186254] trunk/Source/WebCore
Title: [186254] trunk/Source/WebCore
Revision 186254
Author cdu...@apple.com
Date 2015-07-02 19:40:00 -0700 (Thu, 02 Jul 2015)
Log Message
Unreviewed, rolling out r186251.
https://bugs.webkit.org/show_bug.cgi?id=146573
caused crashes in webaudio tests (Requested by cdumez on
#webkit).
Reverted changeset:
Ensure media playback is stopped during page close
https://bugs.webkit.org/show_bug.cgi?id=146554
http://trac.webkit.org/changeset/186251
Patch by Commit Queue commit-qu...@webkit.org on 2015-07-02
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioContext.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/audio/PlatformMediaSession.h
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (186253 => 186254)
--- trunk/Source/WebCore/ChangeLog 2015-07-03 02:35:08 UTC (rev 186253)
+++ trunk/Source/WebCore/ChangeLog 2015-07-03 02:40:00 UTC (rev 186254)
@@ -1,3 +1,17 @@
+2015-07-02 Commit Queue commit-qu...@webkit.org
+
+Unreviewed, rolling out r186251.
+https://bugs.webkit.org/show_bug.cgi?id=146573
+
+caused crashes in webaudio tests (Requested by cdumez on
+#webkit).
+
+Reverted changeset:
+
+Ensure media playback is stopped during page close
+https://bugs.webkit.org/show_bug.cgi?id=146554
+http://trac.webkit.org/changeset/186251
+
2015-07-02 Brent Fulgham bfulg...@apple.com
Ensure media playback is stopped during page close
Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.h (186253 => 186254)
--- trunk/Source/WebCore/Modules/webaudio/AudioContext.h 2015-07-03 02:35:08 UTC (rev 186253)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.h 2015-07-03 02:40:00 UTC (rev 186254)
@@ -90,8 +90,6 @@
Document* document() const; // ASSERTs if document no longer exists.
-Document* hostingDocument() const override final { return document(); }
-
AudioDestinationNode* destination() { return m_destinationNode.get(); }
size_t currentSampleFrame() const { return m_destinationNode-currentSampleFrame(); }
double currentTime() const { return m_destinationNode-currentTime(); }
Modified: trunk/Source/WebCore/dom/Document.cpp (186253 => 186254)
--- trunk/Source/WebCore/dom/Document.cpp 2015-07-03 02:35:08 UTC (rev 186253)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-07-03 02:40:00 UTC (rev 186254)
@@ -112,7 +112,6 @@
#include PageGroup.h
#include PageTransitionEvent.h
#include PlatformLocale.h
-#include PlatformMediaSessionManager.h
#include PlatformStrategies.h
#include PlugInsResources.h
#include PluginDocument.h
@@ -701,8 +700,6 @@
if (svgExtensions())
accessSVGExtensions().pauseAnimations();
-PlatformMediaSessionManager::sharedManager().stopAllMediaPlaybackForDocument(*this);
-
#if ENABLE(REQUEST_ANIMATION_FRAME)
clearScriptedAnimationController();
#endif
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (186253 => 186254)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2015-07-03 02:35:08 UTC (rev 186253)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2015-07-03 02:40:00 UTC (rev 186254)
@@ -147,9 +147,7 @@
MediaPlayerEnums::MovieLoadType movieLoadType() const;
bool inActiveDocument() const { return m_inActiveDocument; }
-
-Document* hostingDocument() const override final { return document(); }
-
+
// DOM API
// error state
PassRefPtrMediaError error() const;
Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSession.h (186253 => 186254)
--- trunk/Source/WebCore/platform/audio/PlatformMediaSession.h 2015-07-03 02:35:08 UTC (rev 186253)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSession.h 2015-07-03 02:40:00 UTC (rev 186254)
@@ -37,7 +37,6 @@
namespace WebCore {
-class Document;
class MediaPlaybackTarget;
class PlatformMediaSessionClient;
@@ -146,8 +145,6 @@
State m_stateToRestore;
int m_interruptionCount { 0 };
bool m_notifyingClient;
-
-friend class PlatformMediaSessionManager;
};
class PlatformMediaSessionClient {
@@ -180,8 +177,6 @@
virtual bool isPlayingToWirelessPlaybackTarget() const { return false; }
virtual void setShouldPlayToPlaybackTarget(bool) { }
-virtual Document* hostingDocument() const = 0;
-
protected:
virtual ~PlatformMediaSessionClient() { }
};
Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp (186253 => 186254)
--- trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp 2015-07-03 02:35:08 UTC (rev 186253)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp 2015-07-03 02:40:00 UTC (rev 186254)
@@ -29,7 +29,6 @@
#if ENABLE(VIDEO)
#include AudioSession.h
-#include Document.h
#include Logging.h
#include
[webkit-changes] [186245] trunk/Source/WebKit/ios
Title: [186245] trunk/Source/WebKit/ios Revision 186245 Author timothy_hor...@apple.com Date 2015-07-02 16:40:59 -0700 (Thu, 02 Jul 2015) Log Message iOS WebKitLegacy should match WebKit2's viewport behavior https://bugs.webkit.org/show_bug.cgi?id=146564 rdar://problem/20574017 Reviewed by Brent Fulgham. * WebCoreSupport/WebChromeClientIOS.mm: (dictionaryForViewportArguments): Modified Paths trunk/Source/WebKit/ios/ChangeLog trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm Diff Modified: trunk/Source/WebKit/ios/ChangeLog (186244 => 186245) --- trunk/Source/WebKit/ios/ChangeLog 2015-07-02 23:34:18 UTC (rev 186244) +++ trunk/Source/WebKit/ios/ChangeLog 2015-07-02 23:40:59 UTC (rev 186245) @@ -1,6 +1,17 @@ 2015-07-02 Timothy Horton timothy_hor...@apple.com iOS WebKitLegacy should match WebKit2's viewport behavior +https://bugs.webkit.org/show_bug.cgi?id=146564 +rdar://problem/20574017 + +Reviewed by Brent Fulgham. + +* WebCoreSupport/WebChromeClientIOS.mm: +(dictionaryForViewportArguments): + +2015-07-02 Timothy Horton timothy_hor...@apple.com + +iOS WebKitLegacy should match WebKit2's viewport behavior https://bugs.webkit.org/show_bug.cgi?id=146540 rdar://problem/20574017 Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm (186244 => 186245) --- trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm 2015-07-02 23:34:18 UTC (rev 186244) +++ trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm 2015-07-02 23:40:59 UTC (rev 186245) @@ -167,6 +167,7 @@ @minimum-scale:@(arguments.minZoom), @maximum-scale:@(arguments.maxZoom), @user-scalable:@(arguments.userZoom), + @shrink-to-fit:@(arguments.shrinkToFit), @width:@(arguments.width), @height:@(arguments.height) }; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186247] trunk/Source/WebKit2
Title: [186247] trunk/Source/WebKit2
Revision 186247
Author ander...@apple.com
Date 2015-07-02 17:08:18 -0700 (Thu, 02 Jul 2015)
Log Message
Provide API to clear the HSTS cache
https://bugs.webkit.org/show_bug.cgi?id=146565
rdar://problem/20023805
Reviewed by Tim Horton.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteData):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::clearHSTSCache):
* Shared/WebsiteData/WebsiteDataTypes.h:
* UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:
(dataTypesToString):
* UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:
(WebKit::toWebsiteDataTypes):
(WebKit::toWKWebsiteDataTypes):
* UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::computeNetworkProcessAccessTypeForDataRemoval):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm
trunk/Source/WebKit2/Shared/WebsiteData/WebsiteDataTypes.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecord.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186246 => 186247)
--- trunk/Source/WebKit2/ChangeLog 2015-07-02 23:53:10 UTC (rev 186246)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-03 00:08:18 UTC (rev 186247)
@@ -1,3 +1,26 @@
+2015-07-02 Anders Carlsson ander...@apple.com
+
+Provide API to clear the HSTS cache
+https://bugs.webkit.org/show_bug.cgi?id=146565
+rdar://problem/20023805
+
+Reviewed by Tim Horton.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::deleteWebsiteData):
+* NetworkProcess/NetworkProcess.h:
+* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+(WebKit::NetworkProcess::clearHSTSCache):
+* Shared/WebsiteData/WebsiteDataTypes.h:
+* UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:
+(dataTypesToString):
+* UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:
+(WebKit::toWebsiteDataTypes):
+(WebKit::toWKWebsiteDataTypes):
+* UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::computeNetworkProcessAccessTypeForDataRemoval):
+
2015-07-02 Mark Lam mark@apple.com
Gardening: fix broken 32-bit build..
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (186246 => 186247)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2015-07-02 23:53:10 UTC (rev 186246)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2015-07-03 00:08:18 UTC (rev 186247)
@@ -348,6 +348,11 @@
void NetworkProcess::deleteWebsiteData(SessionID sessionID, uint64_t websiteDataTypes, std::chrono::system_clock::time_point modifiedSince, uint64_t callbackID)
{
+if (websiteDataTypes WebsiteDataTypeHSTSCache) {
+if (auto* networkStorageSession = SessionTracker::session(sessionID))
+clearHSTSCache(*networkStorageSession, modifiedSince);
+}
+
if (websiteDataTypes WebsiteDataTypeCookies) {
if (auto* networkStorageSession = SessionTracker::session(sessionID))
deleteAllCookiesModifiedSince(*networkStorageSession, modifiedSince);
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h (186246 => 186247)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2015-07-02 23:53:10 UTC (rev 186246)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2015-07-03 00:08:18 UTC (rev 186247)
@@ -45,6 +45,7 @@
namespace WebCore {
class CertificateInfo;
+class NetworkStorageSession;
class SecurityOrigin;
}
@@ -95,6 +96,9 @@
static void clearCFURLCacheForOrigins(const VectorSecurityOriginData);
#endif
+#if PLATFORM(COCOA)
+void clearHSTSCache(WebCore::NetworkStorageSession, std::chrono::system_clock::time_point modifiedSince);
+#endif
private:
NetworkProcess();
Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm (186246 => 186247)
--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2015-07-02 23:53:10 UTC (rev 186246)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2015-07-03 00:08:18 UTC (rev 186247)
@@ -34,6 +34,7 @@
#import SandboxExtension.h
#import SecurityOriginData.h
#import WebCore/CFNetworkSPI.h
+#import WebCore/NetworkStorageSession.h
#import WebCore/PublicSuffix.h
#import WebCore/ResourceRequestCFNet.h
#import WebCore/SecurityOrigin.h
@@ -212,6 +213,14 @@
}
}
+void NetworkProcess::clearHSTSCache(WebCore::NetworkStorageSession session, std::chrono::system_clock::time_point modifiedSince)
+{
+NSTimeInterval
[webkit-changes] [186252] trunk/Source/JavaScriptCore
Title: [186252] trunk/Source/_javascript_Core Revision 186252 Author fpi...@apple.com Date 2015-07-02 18:48:01 -0700 (Thu, 02 Jul 2015) Log Message DFG and FTL should have an OSR exit fuzzer https://bugs.webkit.org/show_bug.cgi?id=146562 Reviewed by Benjamin Poulain. Adds a basic OSR exit fuzzer to JSC. This isn't hooked into any test harnesses yet, but I spot-checked it on v8-earley-boyer.js and so far found no bugs. I'd like to figure out how to harness this after I land it. Since it's turned off by default, it should have no effect on behavior. * CMakeLists.txt: * _javascript_Core.vcxproj/_javascript_Core.vcxproj: * _javascript_Core.xcodeproj/project.pbxproj: * dfg/DFGOSRExitFuzz.cpp: Added. (JSC::numberOfOSRExitFuzzChecks): * dfg/DFGOSRExitFuzz.h: Added. * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::emitGetArgumentStart): (JSC::DFG::SpeculativeJIT::emitOSRExitFuzzCheck): (JSC::DFG::SpeculativeJIT::speculationCheck): * dfg/DFGSpeculativeJIT.h: * ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit): * jsc.cpp: (jscmain): * runtime/Options.h: * runtime/TestRunnerUtils.h: Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp trunk/Source/_javascript_Core/jsc.cpp trunk/Source/_javascript_Core/runtime/Options.h trunk/Source/_javascript_Core/runtime/TestRunnerUtils.h Added Paths trunk/Source/_javascript_Core/dfg/DFGOSRExitFuzz.cpp trunk/Source/_javascript_Core/dfg/DFGOSRExitFuzz.h Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (186251 => 186252) --- trunk/Source/_javascript_Core/CMakeLists.txt 2015-07-03 01:44:40 UTC (rev 186251) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2015-07-03 01:48:01 UTC (rev 186252) @@ -208,6 +208,7 @@ dfg/DFGOSRExitCompiler32_64.cpp dfg/DFGOSRExitCompiler64.cpp dfg/DFGOSRExitCompilerCommon.cpp +dfg/DFGOSRExitFuzz.cpp dfg/DFGOSRExitJumpPlaceholder.cpp dfg/DFGOSRExitPreparation.cpp dfg/DFGObjectAllocationSinkingPhase.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (186251 => 186252) --- trunk/Source/_javascript_Core/ChangeLog 2015-07-03 01:44:40 UTC (rev 186251) +++ trunk/Source/_javascript_Core/ChangeLog 2015-07-03 01:48:01 UTC (rev 186252) @@ -1,3 +1,34 @@ +2015-07-02 Filip Pizlo fpi...@apple.com + +DFG and FTL should have an OSR exit fuzzer +https://bugs.webkit.org/show_bug.cgi?id=146562 + +Reviewed by Benjamin Poulain. + +Adds a basic OSR exit fuzzer to JSC. This isn't hooked into any test harnesses yet, but I +spot-checked it on v8-earley-boyer.js and so far found no bugs. I'd like to figure out how +to harness this after I land it. + +Since it's turned off by default, it should have no effect on behavior. + +* CMakeLists.txt: +* _javascript_Core.vcxproj/_javascript_Core.vcxproj: +* _javascript_Core.xcodeproj/project.pbxproj: +* dfg/DFGOSRExitFuzz.cpp: Added. +(JSC::numberOfOSRExitFuzzChecks): +* dfg/DFGOSRExitFuzz.h: Added. +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::emitGetArgumentStart): +(JSC::DFG::SpeculativeJIT::emitOSRExitFuzzCheck): +(JSC::DFG::SpeculativeJIT::speculationCheck): +* dfg/DFGSpeculativeJIT.h: +* ftl/FTLLowerDFGToLLVM.cpp: +(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit): +* jsc.cpp: +(jscmain): +* runtime/Options.h: +* runtime/TestRunnerUtils.h: + 2015-07-02 Saam barati saambara...@gmail.com Rename Deconstruction to Destructuring throughout JSC Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj (186251 => 186252) --- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj 2015-07-03 01:44:40 UTC (rev 186251) +++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj 2015-07-03 01:48:01 UTC (rev 186252) @@ -447,6 +447,7 @@ ClCompile Include=..\dfg\DFGOSRExitCompiler32_64.cpp / ClCompile Include=..\dfg\DFGOSRExitCompiler64.cpp / ClCompile Include=..\dfg\DFGOSRExitCompilerCommon.cpp / +ClCompile Include=..\dfg\DFGOSRExitFuzz.cpp / ClCompile Include=..\dfg\DFGOSRExitJumpPlaceholder.cpp / ClCompile Include=..\dfg\DFGOSRExitPreparation.cpp / ClCompile Include=..\dfg\DFGObjectAllocationSinkingPhase.cpp / @@ -1147,6 +1148,7 @@ ClInclude Include=..\dfg\DFGOSRExitCompilationInfo.h / ClInclude Include=..\dfg\DFGOSRExitCompiler.h / ClInclude Include=..\dfg\DFGOSRExitCompilerCommon.h / +ClInclude
[webkit-changes] [186255] trunk
Title: [186255] trunk Revision 186255 Author commit-qu...@webkit.org Date 2015-07-02 20:08:44 -0700 (Thu, 02 Jul 2015) Log Message [EFL] test_ewk2_application_cache_manager has been failed since r185527 https://bugs.webkit.org/show_bug.cgi?id=146016 Patch by Przemek Piorkowski piorkowskiprzemys...@gmail.com on 2015-07-02 Reviewed by Gyuyoung Kim. In order to handle properly WebApplicationCacheManagerProxy implementation which use .: WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL. Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well. * Source/cmake/OptionsEfl.cmake: set ENABLE_PUBLIC_SUFFIX_LIST to ON for EFL. Source/WebCore: WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL. Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well. * PlatformEfl.cmake: PublicSuffixSoup.cpp added to source files. Source/WebKit2: WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL. Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well. * UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp: (TEST_F): enable ewk_application_cache_manager as it is passing now. Modified Paths trunk/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp trunk/Source/cmake/OptionsEfl.cmake Diff Modified: trunk/ChangeLog (186254 => 186255) --- trunk/ChangeLog 2015-07-03 02:40:00 UTC (rev 186254) +++ trunk/ChangeLog 2015-07-03 03:08:44 UTC (rev 186255) @@ -1,3 +1,16 @@ +2015-07-02 Przemek Piorkowski piorkowskiprzemys...@gmail.com + +[EFL] test_ewk2_application_cache_manager has been failed since r185527 +https://bugs.webkit.org/show_bug.cgi?id=146016 + +Reviewed by Gyuyoung Kim. + +In order to handle properly WebApplicationCacheManagerProxy implementation which use +WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL. +Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well. + +* Source/cmake/OptionsEfl.cmake: set ENABLE_PUBLIC_SUFFIX_LIST to ON for EFL. + 2015-06-30 Andy VanWagoner thetalecraf...@gmail.com Implement ECMAScript Internationalization API Modified: trunk/Source/WebCore/ChangeLog (186254 => 186255) --- trunk/Source/WebCore/ChangeLog 2015-07-03 02:40:00 UTC (rev 186254) +++ trunk/Source/WebCore/ChangeLog 2015-07-03 03:08:44 UTC (rev 186255) @@ -1,3 +1,16 @@ +2015-07-02 Przemek Piorkowski piorkowskiprzemys...@gmail.com + +[EFL] test_ewk2_application_cache_manager has been failed since r185527 +https://bugs.webkit.org/show_bug.cgi?id=146016 + +Reviewed by Gyuyoung Kim. + +In order to handle properly WebApplicationCacheManagerProxy implementation which use +WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL. +Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well. + +* PlatformEfl.cmake: PublicSuffixSoup.cpp added to source files. + 2015-07-02 Commit Queue commit-qu...@webkit.org Unreviewed, rolling out r186251. Modified: trunk/Source/WebCore/PlatformEfl.cmake (186254 => 186255) --- trunk/Source/WebCore/PlatformEfl.cmake 2015-07-03 02:40:00 UTC (rev 186254) +++ trunk/Source/WebCore/PlatformEfl.cmake 2015-07-03 03:08:44 UTC (rev 186255) @@ -248,6 +248,7 @@ platform/posix/FileSystemPOSIX.cpp platform/posix/SharedBufferPOSIX.cpp +platform/soup/PublicSuffixSoup.cpp platform/soup/SharedBufferSoup.cpp platform/soup/URLSoup.cpp Modified: trunk/Source/WebKit2/ChangeLog (186254 => 186255) --- trunk/Source/WebKit2/ChangeLog 2015-07-03 02:40:00 UTC (rev 186254) +++ trunk/Source/WebKit2/ChangeLog 2015-07-03 03:08:44 UTC (rev 186255) @@ -1,3 +1,17 @@ +2015-07-02 Przemek Piorkowski piorkowskiprzemys...@gmail.com + +[EFL] test_ewk2_application_cache_manager has been failed since r185527 +https://bugs.webkit.org/show_bug.cgi?id=146016 + +Reviewed by Gyuyoung Kim. + +In order to handle properly WebApplicationCacheManagerProxy implementation which use +WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL. +Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well. + +* UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp: +(TEST_F): enable ewk_application_cache_manager as it is passing now. + 2015-07-02 Commit Queue commit-qu...@webkit.org Unreviewed, rolling out r186247 and r186250. Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp (186254 => 186255) --- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp 2015-07-03 02:40:00
[webkit-changes] [186256] trunk
Title: [186256] trunk Revision 186256 Author commit-qu...@webkit.org Date 2015-07-02 20:34:36 -0700 (Thu, 02 Jul 2015) Log Message AX: Selection change as a result of focusing an element should include that information in the intent https://bugs.webkit.org/show_bug.cgi?id=146533 Patch by Doug Russell d_russ...@apple.com on 2015-07-02 Reviewed by Chris Fleizach. Added focusChange flag to AXTextStateChangeIntent. Added intent support to selection logic called by Element::updateFocusAppearance(). Added NSAccessibilityTextSelectionChangedFocus to mac notifications. Source/WebCore: Test: platform/mac/accessibility/selection-notification-focus-change.html * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::postTextStateChangeNotification): * accessibility/AXTextStateChangeIntent.h: * accessibility/AccessibilityRenderObject.cpp: (WebCore::setTextSelectionIntent): (WebCore::AccessibilityRenderObject::setFocused): * accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::postTextStateChangePlatformNotification): * dom/Element.cpp: (WebCore::Element::updateFocusAppearance): * dom/Element.h: (WebCore::Element::defaultFocusTextStateChangeIntent): * editing/FrameSelection.cpp: (WebCore::FrameSelection::moveWithoutValidationTo): (WebCore::FrameSelection::setSelectionByMouseIfDifferent): (WebCore::FrameSelection::selectAll): * editing/FrameSelection.h: * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance): * html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::select): (WebCore::HTMLTextFormControlElement::setSelectionRange): (WebCore::HTMLTextFormControlElement::restoreCachedSelection): * html/HTMLTextFormControlElement.h: * page/EventHandler.cpp: (WebCore::setInitialKeyboardSelection): * page/FocusController.cpp: (WebCore::FocusController::advanceFocusInDocumentOrder): LayoutTests: * platform/mac/accessibility/selection-notification-focus-change-expected.txt: Added. * platform/mac/accessibility/selection-notification-focus-change.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AXTextStateChangeIntent.h trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/editing/FrameSelection.cpp trunk/Source/WebCore/editing/FrameSelection.h trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLTextAreaElement.cpp trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp trunk/Source/WebCore/html/HTMLTextFormControlElement.h trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/FocusController.cpp Added Paths trunk/LayoutTests/platform/mac/accessibility/selection-notification-focus-change-expected.txt trunk/LayoutTests/platform/mac/accessibility/selection-notification-focus-change.html Diff Modified: trunk/LayoutTests/ChangeLog (186255 => 186256) --- trunk/LayoutTests/ChangeLog 2015-07-03 03:08:44 UTC (rev 186255) +++ trunk/LayoutTests/ChangeLog 2015-07-03 03:34:36 UTC (rev 186256) @@ -1,3 +1,18 @@ +2015-07-02 Doug Russell d_russ...@apple.com + +AX: Selection change as a result of focusing an element should include that +information in the intent +https://bugs.webkit.org/show_bug.cgi?id=146533 + +Reviewed by Chris Fleizach. + +Added focusChange flag to AXTextStateChangeIntent. +Added intent support to selection logic called by Element::updateFocusAppearance(). +Added NSAccessibilityTextSelectionChangedFocus to mac notifications. + +* platform/mac/accessibility/selection-notification-focus-change-expected.txt: Added. +* platform/mac/accessibility/selection-notification-focus-change.html: Added. + 2015-07-02 Saam barati saambara...@gmail.com Rename Deconstruction to Destructuring throughout JSC Added: trunk/LayoutTests/platform/mac/accessibility/selection-notification-focus-change-expected.txt (0 => 186256) --- trunk/LayoutTests/platform/mac/accessibility/selection-notification-focus-change-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac/accessibility/selection-notification-focus-change-expected.txt 2015-07-03 03:34:36 UTC (rev 186256) @@ -0,0 +1,18 @@ + + 1 + 2 +This tests that selection changes as a result of advancing focus include AXTextSelectionChangedFocus flag. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS addedNotification is true +PASS axTextFocusChangeOne is true +PASS axTextFocusChangeTwo is true +PASS accessibilityController.accessibleElementById(1).isFocusable is true +PASS successfullyParsed is true + +TEST COMPLETE +PASS axTextFocusChangeThree is true +PASS
[webkit-changes] [186244] trunk/Source/WebCore
Title: [186244] trunk/Source/WebCore
Revision 186244
Author d...@apple.com
Date 2015-07-02 16:34:18 -0700 (Thu, 02 Jul 2015)
Log Message
WebKit should use 80% white background for PiP indicator
https://bugs.webkit.org/show_bug.cgi?id=146444
rdar://problem/21555726
Reviewed by Brent Fulgham.
The designers wanted 80% white, not 80% black (r186104).
I've also reverted the AirPlay background back to black.
* Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-wireless-playback-status):
(audio::-webkit-media-controls-wireless-playback-status.small):
(audio::-webkit-media-controls-wireless-playback-status.picture-in-picture):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (186243 => 186244)
--- trunk/Source/WebCore/ChangeLog 2015-07-02 23:32:00 UTC (rev 186243)
+++ trunk/Source/WebCore/ChangeLog 2015-07-02 23:34:18 UTC (rev 186244)
@@ -1,3 +1,19 @@
+2015-07-02 Dean Jackson d...@apple.com
+
+WebKit should use 80% white background for PiP indicator
+https://bugs.webkit.org/show_bug.cgi?id=146444
+rdar://problem/21555726
+
+Reviewed by Brent Fulgham.
+
+The designers wanted 80% white, not 80% black (r186104).
+I've also reverted the AirPlay background back to black.
+
+* Modules/mediacontrols/mediaControlsiOS.css:
+(audio::-webkit-media-controls-wireless-playback-status):
+(audio::-webkit-media-controls-wireless-playback-status.small):
+(audio::-webkit-media-controls-wireless-playback-status.picture-in-picture):
+
2015-07-02 Eric Carlson eric.carl...@apple.com
[Mac] Clear current AirPlay source before setting another
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (186243 => 186244)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2015-07-02 23:32:00 UTC (rev 186243)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2015-07-02 23:34:18 UTC (rev 186244)
@@ -579,8 +579,8 @@
top: 0px;
width: 100%;
height: 100%;
-background-image: url('data:image/svg+xml;utf8,svg xmlns=http://www.w3.org/2000/svg viewBox=0 0 131 90g fill=none stroke=white stroke-width=4rect x=2 y=2 width=127 height=76/line x1=30 y1=88 x2=101 y2=88//g/svg');
-background-color: #333;
+background-image: url('data:image/svg+xml;utf8,svg xmlns=http://www.w3.org/2000/svg viewBox=0 0 131 90g fill=none stroke=rgb(146,146,146) stroke-width=4rect x=2 y=2 width=127 height=76/line x1=30 y1=88 x2=101 y2=88//g/svg');
+background-color: black;
background-repeat: no-repeat;
background-position: 50% calc(.5 * (100% - 25px) - 21pt);
background-size: 131px auto;
@@ -632,7 +632,7 @@
video::-webkit-media-controls-wireless-playback-status.small,
audio::-webkit-media-controls-wireless-playback-status.small {
-background-image: url('data:image/svg+xml;utf8,svg xmlns=http://www.w3.org/2000/svg viewBox=0 0 62 43g fill=none stroke=white stroke-width=2rect x=1 y=1 width=60 height=36/line x1=14 y1=42 x2=48 y2=42//g/svg');
+background-image: url('data:image/svg+xml;utf8,svg xmlns=http://www.w3.org/2000/svg viewBox=0 0 62 43g fill=none stroke=rgb(146,146,146) stroke-width=2rect x=1 y=1 width=60 height=36/line x1=14 y1=42 x2=48 y2=42//g/svg');
background-position: 50% calc(.5 * (100% - 25px) - 5pt);
background-size: 62px auto;
}
@@ -650,9 +650,10 @@
video::-webkit-media-controls-wireless-playback-status.picture-in-picture,
audio::-webkit-media-controls-wireless-playback-status.picture-in-picture
{
+background-color: #ccc;
background-size: 304px auto;
background-position: 50% calc(.5 * (100% - 25px));
-background-image: url('data:image/svg+xml;utf8,svg xmlns=http://www.w3.org/2000/svg viewBox=0 0 304 150g fill=none stroke=white stroke-width=3path d=m 172,106 -81,0 c -3.5,0 -6,-2.5 -6,-6 l 0,-89 c 0,-3.5 2.5,-6 6,-6 l 122,0 c 3.5,0 6,2.5 6,6 l 0,57 /path d=m 233,119 -53,0 c -3,0 -3,-0 -3,-3 l 0,-40 c 0,-3 0,-3 3,-3 l 53,0 c 3,0 3,0 3,3 l 0,40 c 0,3 0,3 -3,3 z //g/svg');
+background-image: url('data:image/svg+xml;utf8,svg xmlns=http://www.w3.org/2000/svg viewBox=0 0 304 150g fill=none stroke=#8e8e93 stroke-width=3path d=m 172,106 -81,0 c -3.5,0 -6,-2.5 -6,-6 l 0,-89 c 0,-3.5 2.5,-6 6,-6 l 122,0 c 3.5,0 6,2.5 6,6 l 0,57 /path d=m 233,119 -53,0 c -3,0 -3,-0 -3,-3 l 0,-40 c 0,-3 0,-3 3,-3 l 53,0 c 3,0 3,0 3,3 l 0,40 c 0,3 0,3 -3,3 z //g/svg');
}
video::-webkit-media-controls-wireless-playback-text-top.picture-in-picture,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186246] trunk
Title: [186246] trunk Revision 186246 Author saambara...@gmail.com Date 2015-07-02 16:53:10 -0700 (Thu, 02 Jul 2015) Log Message Rename Deconstruction to Destructuring throughout JSC https://bugs.webkit.org/show_bug.cgi?id=146100 Reviewed by Mark Lam. Source/_javascript_Core: It is good to use the same naming conventions as the ES6 spec because it is the de facto way of speaking about these language features. This also has the benefit of improving JSC's hackability because it improves code readability for newcomers to JSC or newcomers to this part of the code base. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::initializeNextParameter): (JSC::BytecodeGenerator::visibleNameForParameter): * bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::registerFor): * bytecompiler/NodesCodegen.cpp: (JSC::ForInNode::tryGetBoundLocal): (JSC::ForInNode::emitLoopHeader): (JSC::ForOfNode::emitBytecode): (JSC::ClassExprNode::emitBytecode): (JSC::DestructuringAssignmentNode::emitBytecode): (JSC::DestructuringPatternNode::~DestructuringPatternNode): (JSC::ArrayPatternNode::collectBoundIdentifiers): (JSC::DeconstructingAssignmentNode::emitBytecode): Deleted. (JSC::DeconstructionPatternNode::~DeconstructionPatternNode): Deleted. * parser/ASTBuilder.h: (JSC::ASTBuilder::createElementList): (JSC::ASTBuilder::createFormalParameterList): (JSC::ASTBuilder::createClause): (JSC::ASTBuilder::createClauseList): (JSC::ASTBuilder::createForInLoop): (JSC::ASTBuilder::createForOfLoop): (JSC::ASTBuilder::isBindingNode): (JSC::ASTBuilder::isResolve): (JSC::ASTBuilder::createDestructuringAssignment): (JSC::ASTBuilder::createArrayPattern): (JSC::ASTBuilder::appendArrayPatternSkipEntry): (JSC::ASTBuilder::appendArrayPatternEntry): (JSC::ASTBuilder::appendArrayPatternRestEntry): (JSC::ASTBuilder::createObjectPattern): (JSC::ASTBuilder::appendObjectPatternEntry): (JSC::ASTBuilder::createDeconstructingAssignment): Deleted. * parser/NodeConstructors.h: (JSC::TryNode::TryNode): (JSC::ParameterNode::ParameterNode): (JSC::ForOfNode::ForOfNode): (JSC::DestructuringPatternNode::DestructuringPatternNode): (JSC::ArrayPatternNode::ArrayPatternNode): (JSC::ArrayPatternNode::create): (JSC::ObjectPatternNode::ObjectPatternNode): (JSC::BindingNode::create): (JSC::BindingNode::BindingNode): (JSC::DestructuringAssignmentNode::DestructuringAssignmentNode): (JSC::DeconstructionPatternNode::DeconstructionPatternNode): Deleted. (JSC::DeconstructingAssignmentNode::DeconstructingAssignmentNode): Deleted. * parser/Nodes.cpp: (JSC::FunctionParameters::create): * parser/Nodes.h: (JSC::ExpressionNode::isResolveNode): (JSC::ExpressionNode::isBracketAccessorNode): (JSC::ExpressionNode::isDotAccessorNode): (JSC::ExpressionNode::isDestructuringNode): (JSC::ExpressionNode::isFuncExprNode): (JSC::ExpressionNode::isCommaNode): (JSC::ExpressionNode::isSimpleArray): (JSC::ParameterNode::pattern): (JSC::ParameterNode::nextParam): (JSC::FunctionParameters::size): (JSC::FunctionParameters::at): (JSC::FunctionParameters::patterns): (JSC::DestructuringPatternNode::isBindingNode): (JSC::DestructuringPatternNode::emitDirectBinding): (JSC::ArrayPatternNode::appendIndex): (JSC::ObjectPatternNode::appendEntry): (JSC::BindingNode::boundProperty): (JSC::DestructuringAssignmentNode::bindings): (JSC::ExpressionNode::isDeconstructionNode): Deleted. (JSC::DeconstructionPatternNode::isBindingNode): Deleted. (JSC::DeconstructionPatternNode::emitDirectBinding): Deleted. (JSC::DeconstructingAssignmentNode::bindings): Deleted. * parser/Parser.cpp: (JSC::ParserLexerType::parseVarDeclaration): (JSC::ParserLexerType::parseWhileStatement): (JSC::ParserLexerType::parseVarDeclarationList): (JSC::ParserLexerType::createBindingPattern): (JSC::ParserLexerType::tryParseDestructuringPatternExpression): (JSC::ParserLexerType::parseDestructuringPattern): (JSC::ParserLexerType::parseDefaultValueForDestructuringPattern): (JSC::ParserLexerType::parseForStatement): (JSC::ParserLexerType::parseFormalParameters): (JSC::ParserLexerType::parseFunctionParameters): (JSC::ParserLexerType::parseAssignmentExpression): (JSC::ParserLexerType::tryParseDeconstructionPatternExpression): Deleted. (JSC::ParserLexerType::parseDeconstructionPattern): Deleted. (JSC::ParserLexerType::parseDefaultValueForDeconstructionPattern): Deleted. * parser/Parser.h: (JSC::isEvalNode): * parser/SyntaxChecker.h: (JSC::SyntaxChecker::createPropertyList): (JSC::SyntaxChecker::createElementList): (JSC::SyntaxChecker::createFormalParameterList): (JSC::SyntaxChecker::createClause): (JSC::SyntaxChecker::createClauseList): (JSC::SyntaxChecker::operatorStackPop): * tests/stress/reserved-word-with-escape.js: * tests/stress/rest-elements.js: LayoutTests: * js/deconstructing-parameters-should-be-locals-expected.txt: Removed. * js/deconstructing-parameters-should-be-locals.html: Removed. * js/destructuring-assignment-expected.txt: *
[webkit-changes] [186253] trunk/Source/WebKit2
Title: [186253] trunk/Source/WebKit2
Revision 186253
Author cdu...@apple.com
Date 2015-07-02 19:35:08 -0700 (Thu, 02 Jul 2015)
Log Message
Unreviewed, rolling out r186247 and r186250.
https://bugs.webkit.org/show_bug.cgi?id=146572
Broke the build on Mavericks bots (Requested by cdumez on
#webkit).
Reverted changesets:
Provide API to clear the HSTS cache
https://bugs.webkit.org/show_bug.cgi?id=146565
http://trac.webkit.org/changeset/186247
Unreviewed build fix for non-COCOA ports after r186247.
http://trac.webkit.org/changeset/186250
Patch by Commit Queue commit-qu...@webkit.org on 2015-07-02
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm
trunk/Source/WebKit2/Shared/WebsiteData/WebsiteDataTypes.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecord.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186252 => 186253)
--- trunk/Source/WebKit2/ChangeLog 2015-07-03 01:48:01 UTC (rev 186252)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-03 02:35:08 UTC (rev 186253)
@@ -1,3 +1,20 @@
+2015-07-02 Commit Queue commit-qu...@webkit.org
+
+Unreviewed, rolling out r186247 and r186250.
+https://bugs.webkit.org/show_bug.cgi?id=146572
+
+Broke the build on Mavericks bots (Requested by cdumez on
+#webkit).
+
+Reverted changesets:
+
+Provide API to clear the HSTS cache
+https://bugs.webkit.org/show_bug.cgi?id=146565
+http://trac.webkit.org/changeset/186247
+
+Unreviewed build fix for non-COCOA ports after r186247.
+http://trac.webkit.org/changeset/186250
+
2015-07-02 Jinwoo Song jinwoo7.s...@samsung.com
Unreviewed build fix for non-COCOA ports after r186247.
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (186252 => 186253)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2015-07-03 01:48:01 UTC (rev 186252)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2015-07-03 02:35:08 UTC (rev 186253)
@@ -348,13 +348,6 @@
void NetworkProcess::deleteWebsiteData(SessionID sessionID, uint64_t websiteDataTypes, std::chrono::system_clock::time_point modifiedSince, uint64_t callbackID)
{
-#if PLATFORM(COCOA)
-if (websiteDataTypes WebsiteDataTypeHSTSCache) {
-if (auto* networkStorageSession = SessionTracker::session(sessionID))
-clearHSTSCache(*networkStorageSession, modifiedSince);
-}
-#endif
-
if (websiteDataTypes WebsiteDataTypeCookies) {
if (auto* networkStorageSession = SessionTracker::session(sessionID))
deleteAllCookiesModifiedSince(*networkStorageSession, modifiedSince);
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h (186252 => 186253)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2015-07-03 01:48:01 UTC (rev 186252)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2015-07-03 02:35:08 UTC (rev 186253)
@@ -45,7 +45,6 @@
namespace WebCore {
class CertificateInfo;
-class NetworkStorageSession;
class SecurityOrigin;
}
@@ -96,9 +95,6 @@
static void clearCFURLCacheForOrigins(const VectorSecurityOriginData);
#endif
-#if PLATFORM(COCOA)
-void clearHSTSCache(WebCore::NetworkStorageSession, std::chrono::system_clock::time_point modifiedSince);
-#endif
private:
NetworkProcess();
Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm (186252 => 186253)
--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2015-07-03 01:48:01 UTC (rev 186252)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2015-07-03 02:35:08 UTC (rev 186253)
@@ -34,7 +34,6 @@
#import SandboxExtension.h
#import SecurityOriginData.h
#import WebCore/CFNetworkSPI.h
-#import WebCore/NetworkStorageSession.h
#import WebCore/PublicSuffix.h
#import WebCore/ResourceRequestCFNet.h
#import WebCore/SecurityOrigin.h
@@ -213,14 +212,6 @@
}
}
-void NetworkProcess::clearHSTSCache(WebCore::NetworkStorageSession session, std::chrono::system_clock::time_point modifiedSince)
-{
-NSTimeInterval timeInterval = std::chrono::duration_caststd::chrono::durationdouble(modifiedSince.time_since_epoch()).count();
-NSDate *date = [NSDate dateWithTimeIntervalSince1970:timeInterval];
-
-_CFNetworkResetHSTSHostsSinceDate(session.platformSession(), (__bridge CFDateRef)date);
-}
-
static void clearNSURLCache(dispatch_group_t group, std::chrono::system_clock::time_point modifiedSince, const std::functionvoid () completionHandler)
{
dispatch_group_async(group, dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), [modifiedSince, completionHandler] {
Modified:
[webkit-changes] [186227] trunk/Source/WebInspectorUI
Title: [186227] trunk/Source/WebInspectorUI
Revision 186227
Author drou...@apple.com
Date 2015-07-02 10:31:57 -0700 (Thu, 02 Jul 2015)
Log Message
Web Inspector: Show suggest popover on Tab press even if it wasn't showing before
https://bugs.webkit.org/show_bug.cgi?id=146496
Reviewed by Timothy Hatcher.
* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey): Pressing tab will try to autocomplete before trying
to add an ending colon/semicolon or highlight the next section of text.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (186226 => 186227)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-07-02 16:04:01 UTC (rev 186226)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-02 17:31:57 UTC (rev 186227)
@@ -1,3 +1,14 @@
+2015-07-02 Devin Rousso drou...@apple.com
+
+Web Inspector: Show suggest popover on Tab press even if it wasn't showing before
+https://bugs.webkit.org/show_bug.cgi?id=146496
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey): Pressing tab will try to autocomplete before trying
+to add an ending colon/semicolon or highlight the next section of text.
+
2015-07-01 Joseph Pecoraro pecor...@apple.com
Web Inspector: Aggregate profile call information on the backend to drastically reduce profile sizes
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js (186226 => 186227)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2015-07-02 16:04:01 UTC (rev 186226)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2015-07-02 17:31:57 UTC (rev 186227)
@@ -556,30 +556,30 @@
var hasEndingSemicolon = trimmedLine.endsWith(;);
if (cursor.ch = line.trimRight().length - hasEndingSemicolon) {
-if (!line.includes(:)) {
-codeMirror.setCursor(cursor.line, line.length);
-codeMirror.replaceRange(: , cursor);
-return;
-}
+this._completionController.completeAtCurrentPositionIfNeeded().then(function(result) {
+if (result !== WebInspector.CodeMirrorCompletionController.UpdatePromise.NoCompletionsFound)
+return;
-var replacement = ;
+var replacement = ;
-if (!hasEndingSemicolon)
-replacement += ;;
+if (!hasEndingSemicolon)
+replacement += ;;
-if (lastLine)
-replacement += \n;
+if (lastLine)
+replacement += \n;
-if (replacement.length)
-codeMirror.replaceRange(replacement, {line: cursor.line, ch: trimmedLine.length});
+if (replacement.length)
+codeMirror.replaceRange(replacement, {line: cursor.line, ch: trimmedLine.length});
-if (!nextLine) {
-codeMirror.setCursor(cursor.line + 1, 0);
-return;
-}
+if (!nextLine) {
+codeMirror.setCursor(cursor.line + 1, 0);
+return;
+}
-var colon = nextLine.indexOf(:);
-codeMirror.setSelection({line: cursor.line + 1, ch: 0}, {line: cursor.line + 1, ch: colon 0 ? trimmedNextLine.length : colon});
+var colon = nextLine.indexOf(:);
+codeMirror.setSelection({line: cursor.line + 1, ch: 0}, {line: cursor.line + 1, ch: colon 0 ? trimmedNextLine.length : colon});
+}.bind(this));
+
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186226] trunk/Source
Title: [186226] trunk/Source
Revision 186226
Author m...@apple.com
Date 2015-07-02 09:04:01 -0700 (Thu, 02 Jul 2015)
Log Message
rdar://problem/21429613 [iOS] Stop making symlinks from PrivateFrameworks to Frameworks
https://bugs.webkit.org/show_bug.cgi?id=146542
Reviewed by Sam Weinig.
Source/_javascript_Core:
* _javascript_Core.xcodeproj/project.pbxproj: Removed the build phase that makes the symlink.
Source/WebKit2:
* WebKit2.xcodeproj/project.pbxproj: Removed the build phase that makes the directory of
symlinks.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (186225 => 186226)
--- trunk/Source/_javascript_Core/ChangeLog 2015-07-02 13:00:35 UTC (rev 186225)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-07-02 16:04:01 UTC (rev 186226)
@@ -1,3 +1,12 @@
+2015-07-02 Dan Bernstein m...@apple.com
+
+rdar://problem/21429613 [iOS] Stop making symlinks from PrivateFrameworks to Frameworks
+https://bugs.webkit.org/show_bug.cgi?id=146542
+
+Reviewed by Sam Weinig.
+
+* _javascript_Core.xcodeproj/project.pbxproj: Removed the build phase that makes the symlink.
+
2015-07-01 Joseph Pecoraro pecor...@apple.com
Web Inspector: Aggregate profile call information on the backend to drastically reduce profile sizes
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (186225 => 186226)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2015-07-02 13:00:35 UTC (rev 186225)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2015-07-02 16:04:01 UTC (rev 186226)
@@ -6658,7 +6658,6 @@
5D29D8BE0E9860B400C3D2D0 /* Check For Weak VTables and Externals */,
3713F014142905240036387F /* Check For Inappropriate Objective-C Class Names */,
A55DEAA416703DF7003DB841 /* Check For Inappropriate Macros in External Headers */,
-1A02D9A81B34A882000D1522 /* Add Symlink in /System/Library/PrivateFrameworks */,
);
buildRules = (
);
@@ -6773,20 +6772,6 @@
shellPath = /bin/sh;
shellScript = set -e\n\nif [[ $ENABLE_FTL_JIT != \ENABLE_FTL_JIT\ ]]\nthen\nexit 0\nfi\n\nif [[ ${CONFIGURATION:=Debug} != \Production\ ]]\nthen\n# Copy the llvmForJSC library into the framework.\nditto \${BUILT_PRODUCTS_DIR}/libllvmForJSC.dylib\ \${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH}/Libraries/libllvmForJSC.dylib\\nfi\n\nif [[ $PLATFORM_NAME != \macosx\ ]]\nthen\nexit 0\nfi\n\nif [ ! -e \${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}/Libraries\ ]\nthen\nln -fs \Versions/Current/Libraries\ \${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}/Libraries\\nfi;
};
- 1A02D9A81B34A882000D1522 /* Add Symlink in /System/Library/PrivateFrameworks */ = {
- isa = PBXShellScriptBuildPhase;
- buildActionMask = 8;
- files = (
- );
- inputPaths = (
- );
- name = Add Symlink in /System/Library/PrivateFrameworks;
- outputPaths = (
- );
- runOnlyForDeploymentPostprocessing = 1;
- shellPath = /bin/sh;
- shellScript = if [[ ${PLATFORM_NAME} != \iphoneos\ ]]; then\nexit 0\nfi\n\nif [[ ! -d \${INSTALL_ROOT}/${SYSTEM_LIBRARY_DIR}/PrivateFrameworks\ ]]; then\nmkdir -p \${INSTALL_ROOT}/${SYSTEM_LIBRARY_DIR}/PrivateFrameworks\\nfi\n\nln -s -h -f ../Frameworks/_javascript_Core.framework \${INSTALL_ROOT}/${SYSTEM_LIBRARY_DIR}/PrivateFrameworks/_javascript_Core.framework\;
- };
3713F014142905240036387F /* Check For Inappropriate Objective-C Class Names */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
Modified: trunk/Source/WebKit2/ChangeLog (186225 => 186226)
--- trunk/Source/WebKit2/ChangeLog 2015-07-02 13:00:35 UTC (rev 186225)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 16:04:01 UTC (rev 186226)
@@ -1,3 +1,13 @@
+2015-07-02 Dan Bernstein m...@apple.com
+
+rdar://problem/21429613 [iOS] Stop making symlinks from PrivateFrameworks to Frameworks
+https://bugs.webkit.org/show_bug.cgi?id=146542
+
+Reviewed by Sam Weinig.
+
+* WebKit2.xcodeproj/project.pbxproj: Removed the build phase that makes the directory of
+symlinks.
+
2015-07-02 Carlos Garcia Campos cgar...@igalia.com
[GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (186225 => 186226)
--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2015-07-02 13:00:35 UTC (rev 186225)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2015-07-02 16:04:01 UTC (rev 186226)
@@ -14,7 +14,6 @@
1A50DB70110A3D67000D3FE5 /* Copy Files */,
BCFFCA8A160D6DEA003DF315 /* Add current version symlinks */,
BCFFCA8B160D6E7B003DF315 /* Copy XPC services for engineering builds */,
-1A1A18301B17919B00B06F12
[webkit-changes] [186229] trunk/Source/WebKit2
Title: [186229] trunk/Source/WebKit2
Revision 186229
Author mark@apple.com
Date 2015-07-02 11:38:22 -0700 (Thu, 02 Jul 2015)
Log Message
WKWebView evaluateJavaScript:completionHandler: should reuse its JSContext instance.
https://bugs.webkit.org/show_bug.cgi?id=146416
Reviewed by Anders Carlsson.
The core issue here is that we need to be able to deserialized an
API::SerializedScriptValue instance into an ObjC object graph. We'll solve this
by introducing a API::SerializedScriptValue::deserialize() functions that does
the job. The deserialize() function will will use a SharedJSContext to provide
the needed JSContext for doing this work.
Also updated ScriptMessageHandlerDelegate::didPostMessage() to use this new
deserialize() function.
* Shared/API/APISerializedScriptValue.h:
(API::SerializedScriptValue::deserialize):
(API::SerializedScriptValue::internalRepresentation):
- Changed to return a WebCore::SerializedScriptValue*. This makes it friendlier
to use in the 2 places that need it.
* UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm: Added.
(API::SharedJSContext::SharedJSContext):
(API::SharedJSContext::ensureContext):
(API::SharedJSContext::releaseContext):
(API::SerializedScriptValue::deserialize):
* UIProcess/API/Cocoa/WKUserContentController.mm:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView evaluateJavaScript:completionHandler:]):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewRunJavaScriptCallback):
- Removed a now unnecessary cast.
* WebKit2.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/APISerializedScriptValue.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit2/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186228 => 186229)
--- trunk/Source/WebKit2/ChangeLog 2015-07-02 18:33:23 UTC (rev 186228)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 18:38:22 UTC (rev 186229)
@@ -1,3 +1,38 @@
+2015-07-02 Mark Lam mark@apple.com
+
+WKWebView evaluateJavaScript:completionHandler: should reuse its JSContext instance.
+https://bugs.webkit.org/show_bug.cgi?id=146416
+
+Reviewed by Anders Carlsson.
+
+The core issue here is that we need to be able to deserialized an
+API::SerializedScriptValue instance into an ObjC object graph. We'll solve this
+by introducing a API::SerializedScriptValue::deserialize() functions that does
+the job. The deserialize() function will will use a SharedJSContext to provide
+the needed JSContext for doing this work.
+
+Also updated ScriptMessageHandlerDelegate::didPostMessage() to use this new
+deserialize() function.
+
+* Shared/API/APISerializedScriptValue.h:
+(API::SerializedScriptValue::deserialize):
+(API::SerializedScriptValue::internalRepresentation):
+- Changed to return a WebCore::SerializedScriptValue*. This makes it friendlier
+ to use in the 2 places that need it.
+
+* UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm: Added.
+(API::SharedJSContext::SharedJSContext):
+(API::SharedJSContext::ensureContext):
+(API::SharedJSContext::releaseContext):
+(API::SerializedScriptValue::deserialize):
+* UIProcess/API/Cocoa/WKUserContentController.mm:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView evaluateJavaScript:completionHandler:]):
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewRunJavaScriptCallback):
+- Removed a now unnecessary cast.
+* WebKit2.xcodeproj/project.pbxproj:
+
2015-07-02 Dan Bernstein m...@apple.com
rdar://problem/21429613 [iOS] Stop making symlinks from PrivateFrameworks to Frameworks
Modified: trunk/Source/WebKit2/Shared/API/APISerializedScriptValue.h (186228 => 186229)
--- trunk/Source/WebKit2/Shared/API/APISerializedScriptValue.h 2015-07-02 18:33:23 UTC (rev 186228)
+++ trunk/Source/WebKit2/Shared/API/APISerializedScriptValue.h 2015-07-02 18:38:22 UTC (rev 186229)
@@ -58,10 +58,14 @@
{
return m_serializedScriptValue-deserialize(context, exception);
}
+
+#if PLATFORM(COCOA) defined(__OBJC__)
+static id deserialize(WebCore::SerializedScriptValue, JSValueRef* exception);
+#endif
IPC::DataReference dataReference() const { return m_serializedScriptValue-data(); }
-void* internalRepresentation() { return m_serializedScriptValue.get(); }
+WebCore::SerializedScriptValue* internalRepresentation() { return m_serializedScriptValue.get(); }
private:
explicit SerializedScriptValue(PassRefPtrWebCore::SerializedScriptValue serializedScriptValue)
Added:
[webkit-changes] [186230] trunk/Source/JavaScriptCore
Title: [186230] trunk/Source/_javascript_Core
Revision 186230
Author mark@apple.com
Date 2015-07-02 11:44:30 -0700 (Thu, 02 Jul 2015)
Log Message
Build fix for Win EWS bot.
https://bugs.webkit.org/show_bug.cgi?id=146551
Not reviewed.
* tools/JSDollarVMPrototype.cpp:
(JSC::functionCrash):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/tools/JSDollarVMPrototype.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (186229 => 186230)
--- trunk/Source/_javascript_Core/ChangeLog 2015-07-02 18:38:22 UTC (rev 186229)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-07-02 18:44:30 UTC (rev 186230)
@@ -1,3 +1,13 @@
+2015-07-02 Mark Lam mark@apple.com
+
+Build fix for Win EWS bot.
+https://bugs.webkit.org/show_bug.cgi?id=146551
+
+Not reviewed.
+
+* tools/JSDollarVMPrototype.cpp:
+(JSC::functionCrash):
+
2015-07-02 Dan Bernstein m...@apple.com
rdar://problem/21429613 [iOS] Stop making symlinks from PrivateFrameworks to Frameworks
Modified: trunk/Source/_javascript_Core/tools/JSDollarVMPrototype.cpp (186229 => 186230)
--- trunk/Source/_javascript_Core/tools/JSDollarVMPrototype.cpp 2015-07-02 18:38:22 UTC (rev 186229)
+++ trunk/Source/_javascript_Core/tools/JSDollarVMPrototype.cpp 2015-07-02 18:44:30 UTC (rev 186230)
@@ -57,9 +57,10 @@
putDirect(vm, identifier, JSFunction::create(vm, globalObject, arguments, identifier.string(), function));
}
-static NO_RETURN EncodedJSValue JSC_HOST_CALL functionCrash(ExecState*)
+static EncodedJSValue JSC_HOST_CALL functionCrash(ExecState*)
{
CRASH();
+return JSValue::encode(jsUndefined());
}
static EncodedJSValue JSC_HOST_CALL functionDFGTrue(ExecState*)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186231] trunk/Source/WebCore
Title: [186231] trunk/Source/WebCore
Revision 186231
Author youenn.fab...@crf.canon.fr
Date 2015-07-02 12:27:24 -0700 (Thu, 02 Jul 2015)
Log Message
[Streams API] Remove ReadableStreamController.enqueue() custom binding
https://bugs.webkit.org/show_bug.cgi?id=146455
Reviewed by Darin Adler.
Made enqueue not custom. Updated error to use Default=Undefined in IDL.
No change in behavior.
* Modules/streams/ReadableStreamController.h:
(WebCore::ReadableStreamController::error): Removed unneeded variation of error.
(WebCore::ReadableStreamController::enqueue): Calling ReadableJSStream enqueue method.
* Modules/streams/ReadableStreamController.idl: Updated error with Default=Undefined and made enqueue not custom.
* bindings/js/JSDOMBinding.cpp:
(WebCore::createDOMException): Adding support for RangeError exceptions.
* bindings/js/JSReadableStreamControllerCustom.cpp:
(WebCore::constructJSReadableStreamController): Deleted.
* bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::error): Updated to pass error value as parameter.
(WebCore::ReadableJSStream::enqueue): Added exception throwing through ExceptionCode.
(WebCore::ReadableJSStream::retrieveChunkSize): Ditto.
* bindings/js/ReadableJSStream.h:
* dom/ExceptionCode.h: Adding RangeError.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/streams/ReadableStreamController.h
trunk/Source/WebCore/Modules/streams/ReadableStreamController.idl
trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp
trunk/Source/WebCore/bindings/js/JSReadableStreamControllerCustom.cpp
trunk/Source/WebCore/bindings/js/ReadableJSStream.cpp
trunk/Source/WebCore/bindings/js/ReadableJSStream.h
trunk/Source/WebCore/dom/ExceptionCode.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (186230 => 186231)
--- trunk/Source/WebCore/ChangeLog 2015-07-02 18:44:30 UTC (rev 186230)
+++ trunk/Source/WebCore/ChangeLog 2015-07-02 19:27:24 UTC (rev 186231)
@@ -1,3 +1,29 @@
+2015-07-02 Youenn Fablet youenn.fab...@crf.canon.fr
+
+[Streams API] Remove ReadableStreamController.enqueue() custom binding
+https://bugs.webkit.org/show_bug.cgi?id=146455
+
+Reviewed by Darin Adler.
+
+Made enqueue not custom. Updated error to use Default=Undefined in IDL.
+
+No change in behavior.
+
+* Modules/streams/ReadableStreamController.h:
+(WebCore::ReadableStreamController::error): Removed unneeded variation of error.
+(WebCore::ReadableStreamController::enqueue): Calling ReadableJSStream enqueue method.
+* Modules/streams/ReadableStreamController.idl: Updated error with Default=Undefined and made enqueue not custom.
+* bindings/js/JSDOMBinding.cpp:
+(WebCore::createDOMException): Adding support for RangeError exceptions.
+* bindings/js/JSReadableStreamControllerCustom.cpp:
+(WebCore::constructJSReadableStreamController): Deleted.
+* bindings/js/ReadableJSStream.cpp:
+(WebCore::ReadableJSStream::error): Updated to pass error value as parameter.
+(WebCore::ReadableJSStream::enqueue): Added exception throwing through ExceptionCode.
+(WebCore::ReadableJSStream::retrieveChunkSize): Ditto.
+* bindings/js/ReadableJSStream.h:
+* dom/ExceptionCode.h: Adding RangeError.
+
2015-07-02 Brady Eidson beid...@apple.com
[Content Extensions] Block synchronous XMLHTTPRequest.
Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamController.h (186230 => 186231)
--- trunk/Source/WebCore/Modules/streams/ReadableStreamController.h 2015-07-02 18:44:30 UTC (rev 186230)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamController.h 2015-07-02 19:27:24 UTC (rev 186231)
@@ -48,9 +48,10 @@
ReadableJSStream stream() { return m_stream; }
-void error(JSC::ExecState* state, ExceptionCode ec) { m_stream.error(*state, ec); }
-void error(JSC::ExecState* state, JSC::JSValue, ExceptionCode ec) { m_stream.error(*state, ec); }
+void error(JSC::ExecState* state, JSC::JSValue value, ExceptionCode ec) { m_stream.error(*state, value, ec); }
+void enqueue(JSC::ExecState* state, JSC::JSValue value) { m_stream.enqueue(*state, value); }
+
void ref() { m_stream.ref(); }
void deref() { m_stream.deref(); }
Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamController.idl (186230 => 186231)
--- trunk/Source/WebCore/Modules/streams/ReadableStreamController.idl 2015-07-02 18:44:30 UTC (rev 186230)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamController.idl 2015-07-02 19:27:24 UTC (rev 186231)
@@ -33,9 +33,9 @@
ImplementationLacksVTable,
NoInterfaceObject
] interface ReadableStreamController {
-[Custom, RaisesException] boolean enqueue(any chunk);
+[CallWith=ScriptState] void enqueue([Default=Undefined] optional any chunk);
[RaisesException] void close();
-[CallWith=ScriptState, RaisesException] void error(optional any error);
+[CallWith=ScriptState,
[webkit-changes] [186228] trunk
Title: [186228] trunk
Revision 186228
Author beid...@apple.com
Date 2015-07-02 11:33:23 -0700 (Thu, 02 Jul 2015)
Log Message
[Content Extensions] Block synchronous XMLHTTPRequest.
rdar://problem/21573006 and https://bugs.webkit.org/show_bug.cgi?id=146271
Reviewed by Alex Christensen.
Source/WebCore:
Test: http/tests/contentextensions/sync-xhr-blocked.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously): If content blocked, set up an error, clear
the response, and clear the response data.
LayoutTests:
* http/tests/contentextensions/sync-xhr-blocked-expected.txt: Added.
* http/tests/contentextensions/sync-xhr-blocked.html: Added.
* http/tests/contentextensions/sync-xhr-blocked.html.json: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
Added Paths
trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked-expected.txt
trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked.html
trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked.html.json
Diff
Modified: trunk/LayoutTests/ChangeLog (186227 => 186228)
--- trunk/LayoutTests/ChangeLog 2015-07-02 17:31:57 UTC (rev 186227)
+++ trunk/LayoutTests/ChangeLog 2015-07-02 18:33:23 UTC (rev 186228)
@@ -1,3 +1,14 @@
+2015-07-02 Brady Eidson beid...@apple.com
+
+[Content Extensions] Block synchronous XMLHTTPRequest.
+rdar://problem/21573006 and https://bugs.webkit.org/show_bug.cgi?id=146271
+
+Reviewed by Alex Christensen.
+
+* http/tests/contentextensions/sync-xhr-blocked-expected.txt: Added.
+* http/tests/contentextensions/sync-xhr-blocked.html: Added.
+* http/tests/contentextensions/sync-xhr-blocked.html.json: Added.
+
2015-07-02 Alex Christensen achristen...@webkit.org
Skip new web timing test on platforms without web timing.
Added: trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked-expected.txt (0 => 186228)
--- trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked-expected.txt 2015-07-02 18:33:23 UTC (rev 186228)
@@ -0,0 +1,6 @@
+CONSOLE MESSAGE: line 21: Content blocker prevented frame displaying http://127.0.0.1:8000/contentextensions/sync-xhr-blocked.html from loading a resource from http://127.0.0.1:8000/contentextensions/resources/url-blocking-test.js
+CONSOLE MESSAGE: line 21: XMLHttpRequest cannot load http://127.0.0.1:8000/contentextensions/resources/url-blocking-test.js.
+Synchronous status: 0, readyState:1, responseText:
+Synchronous status: 0, readyState:4, responseText:
+Synchronous error: Error: NETWORK_ERR: XMLHttpRequest Exception 101
+
Added: trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked.html (0 => 186228)
--- trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked.html (rev 0)
+++ trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked.html 2015-07-02 18:33:23 UTC (rev 186228)
@@ -0,0 +1,32 @@
+head
+script
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function log(text) {
+document.body.appendChild(document.createTextNode(text));
+document.body.appendChild(document.createElement(br));
+}
+
+function runTest() {
+var xhr = new XMLHttpRequest();
+xhr._onreadystatechange_ = function() {
+log(Synchronous status: + xhr.status + , readyState: + xhr.readyState + , responseText: + xhr.responseText);
+}
+
+xhr.open(GET, resources/url-blocking-test.js, false);
+try {
+xhr.send();
+} catch (error) {
+log(Synchronous error: + error);
+}
+
+if (window.testRunner)
+testRunner.notifyDone();
+}
+/script
+/head
+body _onload_=runTest()
+/body
Added: trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked.html.json (0 => 186228)
--- trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked.html.json (rev 0)
+++ trunk/LayoutTests/http/tests/contentextensions/sync-xhr-blocked.html.json 2015-07-02 18:33:23 UTC (rev 186228)
@@ -0,0 +1,10 @@
+[
+{
+action: {
+type: block
+},
+trigger: {
+url-filter: url-blocking-test
+}
+}
+]
Modified: trunk/Source/WebCore/ChangeLog (186227 => 186228)
--- trunk/Source/WebCore/ChangeLog 2015-07-02 17:31:57 UTC (rev 186227)
+++ trunk/Source/WebCore/ChangeLog 2015-07-02 18:33:23 UTC (rev 186228)
@@ -1,3 +1,16 @@
+2015-07-02 Brady Eidson beid...@apple.com
+
+[Content Extensions] Block synchronous XMLHTTPRequest.
+rdar://problem/21573006 and https://bugs.webkit.org/show_bug.cgi?id=146271
+
+Reviewed by Alex Christensen.
+
+Test: http/tests/contentextensions/sync-xhr-blocked.html
+
+* loader/FrameLoader.cpp:
+
[webkit-changes] [186232] trunk
Title: [186232] trunk
Revision 186232
Author beid...@apple.com
Date 2015-07-02 13:19:36 -0700 (Thu, 02 Jul 2015)
Log Message
Add preference to disable all http-equiv.
rdar://problem/9091261 and https://bugs.webkit.org/show_bug.cgi?id=146553
Reviewed by Sam Weinig.
Source/WebCore:
No new tests (Covered by existing test)
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* page/Settings.in:
Source/WebKit/mac:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setMetaRefreshEnabled:]): Still expose this SPI, but have it affect
the httpEquivEnabled setting.
(-[WebPreferences metaRefreshEnabled]): Ditto.
(-[WebPreferences setHTTPEquivEnabled:]):
(-[WebPreferences httpEquivEnabled]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _preferencesChanged:]):
Source/WebKit2:
* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMetaRefreshEnabled): Still expose this SPI, but have it affect
the httpEquivEnabled setting.
(WKPreferencesGetMetaRefreshEnabled): Ditto
(WKPreferencesSetHTTPEquivEnabled):
(WKPreferencesGetHTTPEquivEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
LayoutTests:
* loader/meta-refresh-disabled.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/loader/meta-refresh-disabled.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/Settings.in
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (186231 => 186232)
--- trunk/LayoutTests/ChangeLog 2015-07-02 19:27:24 UTC (rev 186231)
+++ trunk/LayoutTests/ChangeLog 2015-07-02 20:19:36 UTC (rev 186232)
@@ -1,5 +1,14 @@
2015-07-02 Brady Eidson beid...@apple.com
+Add preference to disable all http-equiv.
+rdar://problem/9091261 and https://bugs.webkit.org/show_bug.cgi?id=146553
+
+Reviewed by Sam Weinig.
+
+* loader/meta-refresh-disabled.html:
+
+2015-07-02 Brady Eidson beid...@apple.com
+
[Content Extensions] Block synchronous XMLHTTPRequest.
rdar://problem/21573006 and https://bugs.webkit.org/show_bug.cgi?id=146271
Modified: trunk/LayoutTests/loader/meta-refresh-disabled.html (186231 => 186232)
--- trunk/LayoutTests/loader/meta-refresh-disabled.html 2015-07-02 19:27:24 UTC (rev 186231)
+++ trunk/LayoutTests/loader/meta-refresh-disabled.html 2015-07-02 20:19:36 UTC (rev 186232)
@@ -1,7 +1,7 @@
head
script
if (window.testRunner) {
-testRunner.overridePreference(WebKitMetaRefreshEnabled, 0);
+testRunner.overridePreference(WebKitHTTPEquivEnabled, 0);
testRunner.dumpAsText();
testRunner.waitUntilDone();
}
Modified: trunk/Source/WebCore/ChangeLog (186231 => 186232)
--- trunk/Source/WebCore/ChangeLog 2015-07-02 19:27:24 UTC (rev 186231)
+++ trunk/Source/WebCore/ChangeLog 2015-07-02 20:19:36 UTC (rev 186232)
@@ -1,3 +1,16 @@
+2015-07-02 Brady Eidson beid...@apple.com
+
+Add preference to disable all http-equiv.
+rdar://problem/9091261 and https://bugs.webkit.org/show_bug.cgi?id=146553
+
+Reviewed by Sam Weinig.
+
+No new tests (Covered by existing test)
+
+* dom/Document.cpp:
+(WebCore::Document::processHttpEquiv):
+* page/Settings.in:
+
2015-07-02 Youenn Fablet youenn.fab...@crf.canon.fr
[Streams API] Remove ReadableStreamController.enqueue() custom binding
Modified: trunk/Source/WebCore/dom/Document.cpp (186231 => 186232)
--- trunk/Source/WebCore/dom/Document.cpp 2015-07-02 19:27:24 UTC (rev 186231)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-07-02 20:19:36 UTC (rev 186232)
@@ -3023,6 +3023,9 @@
{
ASSERT(!equiv.isNull() !content.isNull());
+if (page() !page()-settings().httpEquivEnabled())
+return;
+
Frame* frame = this-frame();
HTTPHeaderName headerName;
@@ -3043,9 +3046,6 @@
break;
case HTTPHeaderName::Refresh: {
-if (page() !page()-settings().metaRefreshEnabled())
-break;
-
double delay;
String urlString;
if
[webkit-changes] [186235] trunk/Source/WebKit2
Title: [186235] trunk/Source/WebKit2 Revision 186235 Author ander...@apple.com Date 2015-07-02 14:39:37 -0700 (Thu, 02 Jul 2015) Log Message Instead of requiring ToT UIKIt, check that UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP is defined to 1 https://bugs.webkit.org/show_bug.cgi?id=146558 Reviewed by Beth Dakin. * Shared/ios/NativeWebTouchEventIOS.mm: (WebKit::NativeWebTouchEvent::NativeWebTouchEvent): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (186234 => 186235) --- trunk/Source/WebKit2/ChangeLog 2015-07-02 20:47:57 UTC (rev 186234) +++ trunk/Source/WebKit2/ChangeLog 2015-07-02 21:39:37 UTC (rev 186235) @@ -1,3 +1,13 @@ +2015-07-02 Anders Carlsson ander...@apple.com + +Instead of requiring ToT UIKIt, check that UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP is defined to 1 +https://bugs.webkit.org/show_bug.cgi?id=146558 + +Reviewed by Beth Dakin. + +* Shared/ios/NativeWebTouchEventIOS.mm: +(WebKit::NativeWebTouchEvent::NativeWebTouchEvent): + 2015-07-02 Brady Eidson beid...@apple.com Remove change I accidentally committed in r186232 Modified: trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm (186234 => 186235) --- trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm 2015-07-02 20:47:57 UTC (rev 186234) +++ trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm 2015-07-02 21:39:37 UTC (rev 186235) @@ -102,7 +102,7 @@ event-timestamp, extractWebTouchPoint(event), positionForCGPoint(event-locationInDocumentCoordinates), -#if __IPHONE_OS_VERSION_MIN_REQUIRED = 9 +#if __IPHONE_OS_VERSION_MIN_REQUIRED = 9 defined UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP event-isPotentialTap, #else true, ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186236] trunk/Source
Title: [186236] trunk/Source
Revision 186236
Author bda...@apple.com
Date 2015-07-02 15:10:40 -0700 (Thu, 02 Jul 2015)
Log Message
Allow the UIDelegate to customize an image preview
https://bugs.webkit.org/show_bug.cgi?id=146557
-and corresponding-
rdar://problem/21657424
Reviewed by Tim Horton.
Source/WebCore:
Add WEBCORE_EXPORT to use this in WK2.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::url):
Source/WebKit2:
Add imageURL to InteractionInformationAtPosition.
* Shared/InteractionInformationAtPosition.cpp:
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
* Shared/InteractionInformationAtPosition.h:
Two new delegate methods.
* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
Call the delegate methods at the appropriate time.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView previewViewControllerForPosition:inSourceView:]):
(-[WKContentView commitPreviewViewController:]):
Include the imageURL in InteractionInformationAtPosition.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/InteractionInformationAtPosition.cpp
trunk/Source/WebKit2/Shared/InteractionInformationAtPosition.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (186235 => 186236)
--- trunk/Source/WebCore/ChangeLog 2015-07-02 21:39:37 UTC (rev 186235)
+++ trunk/Source/WebCore/ChangeLog 2015-07-02 22:10:40 UTC (rev 186236)
@@ -1,3 +1,16 @@
+2015-07-02 Beth Dakin bda...@apple.com
+
+Allow the UIDelegate to customize an image preview
+https://bugs.webkit.org/show_bug.cgi?id=146557
+-and corresponding-
+rdar://problem/21657424
+
+Reviewed by Tim Horton.
+
+Add WEBCORE_EXPORT to use this in WK2.
+* loader/cache/CachedResource.h:
+(WebCore::CachedResource::url):
+
2015-07-02 Brady Eidson beid...@apple.com
Add preference to disable all http-equiv.
Modified: trunk/Source/WebCore/loader/cache/CachedResource.h (186235 => 186236)
--- trunk/Source/WebCore/loader/cache/CachedResource.h 2015-07-02 21:39:37 UTC (rev 186235)
+++ trunk/Source/WebCore/loader/cache/CachedResource.h 2015-07-02 22:10:40 UTC (rev 186236)
@@ -109,7 +109,7 @@
virtual bool shouldIgnoreHTTPStatusCodeErrors() const { return false; }
ResourceRequest resourceRequest() { return m_resourceRequest; }
-const URL url() const { return m_resourceRequest.url();}
+WEBCORE_EXPORT const URL url() const { return m_resourceRequest.url();}
#if ENABLE(CACHE_PARTITIONING)
const String cachePartition() const { return m_resourceRequest.cachePartition(); }
#endif
Modified: trunk/Source/WebKit2/ChangeLog (186235 => 186236)
--- trunk/Source/WebKit2/ChangeLog 2015-07-02 21:39:37 UTC (rev 186235)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-02 22:10:40 UTC (rev 186236)
@@ -1,3 +1,30 @@
+2015-07-02 Beth Dakin bda...@apple.com
+
+Allow the UIDelegate to customize an image preview
+https://bugs.webkit.org/show_bug.cgi?id=146557
+-and corresponding-
+rdar://problem/21657424
+
+Reviewed by Tim Horton.
+
+Add imageURL to InteractionInformationAtPosition.
+* Shared/InteractionInformationAtPosition.cpp:
+(WebKit::InteractionInformationAtPosition::encode):
+(WebKit::InteractionInformationAtPosition::decode):
+* Shared/InteractionInformationAtPosition.h:
+
+Two new delegate methods.
+* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
+
+Call the delegate methods at the appropriate time.
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView previewViewControllerForPosition:inSourceView:]):
+(-[WKContentView commitPreviewViewController:]):
+
+Include the imageURL in InteractionInformationAtPosition.
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::getPositionInformation):
+
2015-07-02 Anders Carlsson ander...@apple.com
Instead of requiring ToT UIKIt, check that UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP is defined to 1
Modified: trunk/Source/WebKit2/Shared/InteractionInformationAtPosition.cpp (186235 => 186236)
--- trunk/Source/WebKit2/Shared/InteractionInformationAtPosition.cpp 2015-07-02 21:39:37 UTC (rev 186235)
+++ trunk/Source/WebKit2/Shared/InteractionInformationAtPosition.cpp 2015-07-02 22:10:40 UTC (rev 186236)
@@ -41,6 +41,7 @@
encoder touchCalloutEnabled;
encoder clickableElementName;
encoder url;
+encoder imageURL;
encoder title;
encoder bounds;
@@ -73,6 +74,9 @@
if (!decoder.decode(result.url))
return false;
[webkit-changes] [186237] trunk/Source/WebKit2
Title: [186237] trunk/Source/WebKit2 Revision 186237 Author bfulg...@apple.com Date 2015-07-02 15:17:42 -0700 (Thu, 02 Jul 2015) Log Message Provide delegate SPI for clients to notify WebKit about content inset changes https://bugs.webkit.org/show_bug.cgi?id=146482 rdar://problem/21602741 Reviewed by Darin Adler. Provide a new SPI for WebKit client applications to use to inform WebKit of planned adjustments to the edge insets of the view. * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Add new optional delegate method. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]): If the new delegate method exists, use the specified content insets, rather than the current state of the view. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (186236 => 186237) --- trunk/Source/WebKit2/ChangeLog 2015-07-02 22:10:40 UTC (rev 186236) +++ trunk/Source/WebKit2/ChangeLog 2015-07-02 22:17:42 UTC (rev 186237) @@ -1,3 +1,19 @@ +2015-07-02 Brent Fulgham bfulg...@apple.com + +Provide delegate SPI for clients to notify WebKit about content inset changes +https://bugs.webkit.org/show_bug.cgi?id=146482 +rdar://problem/21602741 + +Reviewed by Darin Adler. + +Provide a new SPI for WebKit client applications to use to inform WebKit of planned +adjustments to the edge insets of the view. + +* UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Add new optional delegate method. +* UIProcess/API/Cocoa/WKWebView.mm: +(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]): If the new delegate +method exists, use the specified content insets, rather than the current state of the view. + 2015-07-02 Beth Dakin bda...@apple.com Allow the UIDelegate to customize an image preview Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h (186236 => 186237) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h 2015-07-02 22:10:40 UTC (rev 186236) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h 2015-07-02 22:17:42 UTC (rev 186237) @@ -30,11 +30,14 @@ #import WebKit/WKSecurityOrigin.h #import WebKit/_WKActivatedElementInfo.h +@class UIScrollView; @class UIViewController; @class _WKFrameHandle; @protocol WKUIDelegatePrivate WKUIDelegate +struct UIEdgeInsets; + @optional // FIXME: This should be handled by the WKWebsiteDataStore delegate. @@ -59,6 +62,7 @@ - (void)_webView:(WKWebView *)webView willPreviewImageWithURL:(NSURL *)imageURL WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); - (void)_webView:(WKWebView *)webView commitPreviewedImageWithURL:(NSURL *)imageURL WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); - (void)_webView:(WKWebView *)webView didDismissPreviewViewController:(UIViewController *)previewedViewController; +- (UIEdgeInsets)_webView:(WKWebView *)webView finalObscuredInsetsForScrollView:(UIScrollView *)scrolView withVelocity:(CGPoint)velocity targetContentOffset:(inout CGPoint *)targetContentOffset; #endif @end Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (186236 => 186237) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-07-02 22:10:40 UTC (rev 186236) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-07-02 22:17:42 UTC (rev 186237) @@ -1461,7 +1461,16 @@ CGSize maxScrollOffsets = CGSizeMake(scrollView.contentSize.width - scrollView.bounds.size.width, scrollView.contentSize.height - scrollView.bounds.size.height); CGRect fullViewRect = self.bounds; -CGRect unobscuredRect = UIEdgeInsetsInsetRect(fullViewRect, [self _computedContentInset]); + +UIEdgeInsets contentInset; + +idWKUIDelegatePrivate uiDelegatePrivate = static_castid WKUIDelegatePrivate([self UIDelegate]); +if ([uiDelegatePrivate respondsToSelector:@selector(_webView:finalObscuredInsetsForScrollView:withVelocity:targetContentOffset:)]) +contentInset = [uiDelegatePrivate _webView:self finalObscuredInsetsForScrollView:scrollView withVelocity:velocity targetContentOffset:targetContentOffset]; +else +UIEdgeInsets contentInset = [self _computedContentInset]; + +CGRect unobscuredRect = UIEdgeInsetsInsetRect(fullViewRect, contentInset); coordinator-adjustTargetContentOffsetForSnapping(maxScrollOffsets, velocity, unobscuredRect.origin.y, targetContentOffset); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186238] trunk/Source/WebCore
Title: [186238] trunk/Source/WebCore
Revision 186238
Author eric.carl...@apple.com
Date 2015-07-02 15:31:21 -0700 (Thu, 02 Jul 2015)
Log Message
[Mac] Clear current AirPlay source before setting another
https://bugs.webkit.org/show_bug.cgi?id=145959
Reviewed by Brent Fulgham.
* Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::WebMediaSessionManager::clientStateDidChange): Don't make a client begin playing
to the target just because it has paused.
(WebCore::WebMediaSessionManager::configurePlaybackTargetClients): Always select a client that
requrested the picker, and never consider paused clients when choosing a client to begin
playing to the targer. Call setShouldPlayToPlaybackTarget(true) after all of the other
clients have been told to stop playing to the target.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (186237 => 186238)
--- trunk/Source/WebCore/ChangeLog 2015-07-02 22:17:42 UTC (rev 186237)
+++ trunk/Source/WebCore/ChangeLog 2015-07-02 22:31:21 UTC (rev 186238)
@@ -1,3 +1,18 @@
+2015-07-02 Eric Carlson eric.carl...@apple.com
+
+[Mac] Clear current AirPlay source before setting another
+https://bugs.webkit.org/show_bug.cgi?id=145959
+
+Reviewed by Brent Fulgham.
+
+* Modules/mediasession/WebMediaSessionManager.cpp:
+(WebCore::WebMediaSessionManager::clientStateDidChange): Don't make a client begin playing
+ to the target just because it has paused.
+(WebCore::WebMediaSessionManager::configurePlaybackTargetClients): Always select a client that
+ requrested the picker, and never consider paused clients when choosing a client to begin
+ playing to the targer. Call setShouldPlayToPlaybackTarget(true) after all of the other
+ clients have been told to stop playing to the target.
+
2015-07-02 Beth Dakin bda...@apple.com
Allow the UIDelegate to customize an image preview
Modified: trunk/Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp (186237 => 186238)
--- trunk/Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp 2015-07-02 22:17:42 UTC (rev 186237)
+++ trunk/Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp 2015-07-02 22:31:21 UTC (rev 186238)
@@ -171,15 +171,18 @@
if (!flagsAreSet(oldFlags, MediaProducer::RequiresPlaybackTargetMonitoring) flagsAreSet(newFlags, MediaProducer::RequiresPlaybackTargetMonitoring))
scheduleDelayedTask(TargetMonitoringConfigurationTask);
-if (!flagsAreSet(newFlags, MediaProducer::ExternalDeviceAutoPlayCandidate))
+if (!m_playbackTarget || !m_playbackTarget-hasActiveRoute())
return;
-if (!m_playbackTarget || !m_playbackTarget-hasActiveRoute())
+if (!flagsAreSet(newFlags, MediaProducer::ExternalDeviceAutoPlayCandidate) || !flagsAreSet(newFlags, MediaProducer::IsPlayingVideo))
return;
// Do not interrupt another element already playing to a device.
bool anotherClientHasActiveTarget = false;
for (auto state : m_clientState) {
+if (state == changedClientState)
+continue;
+
if (flagsAreSet(state-flags, MediaProducer::IsPlayingToExternalDevice)) {
if (flagsAreSet(state-flags, MediaProducer::IsPlayingVideo))
return;
@@ -243,14 +246,11 @@
for (size_t i = 0; i m_clientState.size(); ++i) {
auto state = m_clientState[i];
-if (indexOfClientThatRequestedPicker == notFound state-requestedPicker)
+if (state-requestedPicker)
indexOfClientThatRequestedPicker = i;
if (indexOfClientWillPlayToTarget == notFound flagsAreSet(state-flags, MediaProducer::IsPlayingToExternalDevice))
indexOfClientWillPlayToTarget = i;
-
-if (indexOfAutoPlayCandidate == notFound flagsAreSet(state-flags, MediaProducer::ExternalDeviceAutoPlayCandidate) !flagsAreSet(state-flags, MediaProducer::IsPlayingVideo))
-indexOfAutoPlayCandidate = i;
}
if (indexOfClientThatRequestedPicker != notFound)
@@ -264,14 +264,18 @@
if (m_playbackTarget)
state-client.setPlaybackTarget(state-contextId, *m_playbackTarget.copyRef());
-if (i != indexOfClientWillPlayToTarget)
+if (i != indexOfClientWillPlayToTarget || !haveActiveRoute)
state-client.setShouldPlayToPlaybackTarget(state-contextId, false);
-else if (!flagsAreSet(state-flags, MediaProducer::IsPlayingToExternalDevice))
-state-client.setShouldPlayToPlaybackTarget(state-contextId, haveActiveRoute);
state-configurationRequired = false;
state-requestedPicker = false;
}
+
+if (haveActiveRoute indexOfClientWillPlayToTarget != notFound) {
+auto state = m_clientState[indexOfClientWillPlayToTarget];
+if (!flagsAreSet(state-flags,
[webkit-changes] [186239] trunk/Source/WebKit2
Title: [186239] trunk/Source/WebKit2 Revision 186239 Author bfulg...@apple.com Date 2015-07-02 15:32:27 -0700 (Thu, 02 Jul 2015) Log Message Correct typo in r186238. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (186238 => 186239) --- trunk/Source/WebKit2/ChangeLog 2015-07-02 22:31:21 UTC (rev 186238) +++ trunk/Source/WebKit2/ChangeLog 2015-07-02 22:32:27 UTC (rev 186239) @@ -1,5 +1,12 @@ 2015-07-02 Brent Fulgham bfulg...@apple.com +Correct typo in r186238. + +* UIProcess/API/Cocoa/WKWebView.mm: +(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]): + +2015-07-02 Brent Fulgham bfulg...@apple.com + Provide delegate SPI for clients to notify WebKit about content inset changes https://bugs.webkit.org/show_bug.cgi?id=146482 rdar://problem/21602741 Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (186238 => 186239) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-07-02 22:31:21 UTC (rev 186238) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-07-02 22:32:27 UTC (rev 186239) @@ -1468,7 +1468,7 @@ if ([uiDelegatePrivate respondsToSelector:@selector(_webView:finalObscuredInsetsForScrollView:withVelocity:targetContentOffset:)]) contentInset = [uiDelegatePrivate _webView:self finalObscuredInsetsForScrollView:scrollView withVelocity:velocity targetContentOffset:targetContentOffset]; else -UIEdgeInsets contentInset = [self _computedContentInset]; +contentInset = [self _computedContentInset]; CGRect unobscuredRect = UIEdgeInsetsInsetRect(fullViewRect, contentInset); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
