[webkit-changes] [190614] trunk/Source/WebCore

2015-10-06 Thread achristensen 
Title: [190614] trunk/Source/WebCore








Revision 190614
Author achristen...@apple.com
Date 2015-10-06 07:23:09 -0700 (Tue, 06 Oct 2015)


Log Message
Fix Windows build after r190611.

* PlatformWin.cmake:
Forward headers from contentextensions.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformWin.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (190613 => 190614)

--- trunk/Source/WebCore/ChangeLog	2015-10-06 13:31:14 UTC (rev 190613)
+++ trunk/Source/WebCore/ChangeLog	2015-10-06 14:23:09 UTC (rev 190614)
@@ -1,3 +1,10 @@
+2015-10-06  Alex Christensen  
+
+Fix Windows build after r190611.
+
+* PlatformWin.cmake:
+Forward headers from contentextensions.
+
 2015-10-06  Hunseop Jeong  
 
 Use modern for-loops in WebCore/html.


Modified: trunk/Source/WebCore/PlatformWin.cmake (190613 => 190614)

--- trunk/Source/WebCore/PlatformWin.cmake	2015-10-06 13:31:14 UTC (rev 190613)
+++ trunk/Source/WebCore/PlatformWin.cmake	2015-10-06 14:23:09 UTC (rev 190614)
@@ -160,6 +160,7 @@
 accessibility
 bindings
 bridge
+contentextensions
 css
 dom
 editing






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190659] trunk/LayoutTests

2015-10-06 Thread jhoneycutt 
Title: [190659] trunk/LayoutTests








Revision 190659
Author jhoneyc...@apple.com
Date 2015-10-06 20:35:26 -0700 (Tue, 06 Oct 2015)


Log Message
Unreviewed iOS test gardening after r190629.

* platform/ios-simulator/TestExpectations:
* platform/ios-simulator-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190658 => 190659)

--- trunk/LayoutTests/ChangeLog	2015-10-07 02:51:29 UTC (rev 190658)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 03:35:26 UTC (rev 190659)
@@ -1,3 +1,10 @@
+2015-10-06  Jon Honeycutt  
+
+Unreviewed iOS test gardening after r190629.
+
+* platform/ios-simulator/TestExpectations:
+* platform/ios-simulator-wk1/TestExpectations:
+
 2015-10-06  Zalan Bujtas  
 
 Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (190658 => 190659)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2015-10-07 02:51:29 UTC (rev 190658)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2015-10-07 03:35:26 UTC (rev 190659)
@@ -2798,45 +2798,60 @@
 streams/reference-implementation/readable-stream-cancel.html [ Failure Pass ]
 compositing/visible-rect/coverage-scrolling.html [ Failure Pass ]
 
-# Imported Blink tests. (Oct 1, 2015)
-imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure ]
-imported/blink/compositing/draws-content/canvas-simple-background.html [ ImageOnlyFailure ]
-imported/blink/compositing/draws-content/webgl-simple-background.html [ ImageOnlyFailure ]
+# Imported Blink tests.
+imported/blink/animations/background-shorthand-crash.html [ Pass Timeout ]
+imported/blink/animations/base-render-style-font-selector-version-assert.html [ Pass Timeout ]
+imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure Pass ]
+imported/blink/compositing/draws-content/canvas-simple-background.html [ ImageOnlyFailure Pass ]
+imported/blink/compositing/draws-content/webgl-simple-background.html [ ImageOnlyFailure Pass ]
+imported/blink/compositing/layer-creation/iframe-clip-removed.html [ Pass Timeout ]
 imported/blink/compositing/overflow/body-switch-composited-scrolling.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/css-grid-layout/grid-item-margins-and-writing-modes.html [ ImageOnlyFailure ]
-imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes.html [ ImageOnlyFailure ]
+imported/blink/compositing/reorder-z-with-style.html [ Timeout ]
+imported/blink/compositing/squashing/invalidate-on-grouped-mapping-reorder.html [ Pass Timeout ]
+imported/blink/css3/calc/transition-asan-crash.html [ Pass Timeout ]
+imported/blink/editing/execCommand/4128080-2.html [ Failure Pass ]
+imported/blink/fast/canvas/bug382588.html [ Pass Timeout ]
+imported/blink/fast/css-grid-layout/grid-item-margins-and-writing-modes.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes.html [ ImageOnlyFailure Pass ]
 imported/blink/fast/css/border-current-color.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/css/text-overflow-ellipsis-button.html [ ImageOnlyFailure ]
-imported/blink/fast/css/transformed-overflow-hidden-clips-fixed.html [ ImageOnlyFailure ]
-imported/blink/fast/forms/select/listbox-line-height.html [ ImageOnlyFailure ]
-imported/blink/fast/forms/select/select-text-transform.html [ ImageOnlyFailure ]
+imported/blink/fast/css/crash-corner-present.html [ Skip ]
+imported/blink/fast/css/text-overflow-ellipsis-button.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/css/transformed-overflow-hidden-clips-fixed.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/events/popup-forwarded-gesture.html [ Skip ]
+imported/blink/fast/forms/select/listbox-line-height.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/forms/select/select-text-transform.html [ ImageOnlyFailure Pass ]
 imported/blink/fast/images/image-hover-display-alt.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/multicol/client-rects-rtl.html [ ImageOnlyFailure ]
-imported/blink/fast/multicol/composited-layer-single-fragment.html [ ImageOnlyFailure ]
-imported/blink/fast/multicol/composited-relpos-2nd-column.html [ ImageOnlyFailure ]
-imported/blink/fast/multicol/dynamic/remove-spanner-in-content.html [ ImageOnlyFailure ]
+imported/blink/fast/images/image-hover-display-alt.html [ Pass Timeout ]
+imported/blink/fast/inline/reparent-inline-box.html [ Pass Timeout ]
+imported/blink/fast/multicol/client-rects-rtl.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/multicol/composited-layer-single-fragment.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/multicol/composited-relpos-2nd-column.html [ ImageOnlyFailure Pass ]

[webkit-changes] [190660] trunk

2015-10-06 Thread mcatanzaro 
Title: [190660] trunk








Revision 190660
Author mcatanz...@igalia.com
Date 2015-10-06 21:08:25 -0700 (Tue, 06 Oct 2015)


Log Message
[GTK] Add autocleanups
https://bugs.webkit.org/show_bug.cgi?id=149588

Reviewed by Darin Adler.

Source/WebCore:

* PlatformGTK.cmake:
* bindings/scripts/gobject-generate-headers.pl:

Source/WebKit2:

* PlatformGTK.cmake:
* UIProcess/API/gtk/WebKitAutocleanups.h: Added.
* UIProcess/API/gtk/webkit2.h:
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h: Added.
* WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

Tools:

* TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
(AutocleanupsTest::create):
(AutocleanupsTest::testWebProcessAutocleanups):
(registerTests):
* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
* TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
(testUIProcessAutocleanups):
(testWebProcessAutocleanups):
(beforeAll):
(afterAll):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/bindings/scripts/gobject-generate-headers.pl
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/UIProcess/API/gtk/webkit2.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt


Added Paths

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitAutocleanups.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190659 => 190660)

--- trunk/Source/WebCore/ChangeLog	2015-10-07 03:35:26 UTC (rev 190659)
+++ trunk/Source/WebCore/ChangeLog	2015-10-07 04:08:25 UTC (rev 190660)
@@ -1,3 +1,13 @@
+2015-10-06  Michael Catanzaro  
+
+[GTK] Add autocleanups
+https://bugs.webkit.org/show_bug.cgi?id=149588
+
+Reviewed by Darin Adler.
+
+* PlatformGTK.cmake:
+* bindings/scripts/gobject-generate-headers.pl:
+
 2015-10-06  Zalan Bujtas  
 
 Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/


Modified: trunk/Source/WebCore/PlatformGTK.cmake (190659 => 190660)

--- trunk/Source/WebCore/PlatformGTK.cmake	2015-10-07 03:35:26 UTC (rev 190659)
+++ trunk/Source/WebCore/PlatformGTK.cmake	2015-10-07 04:08:25 UTC (rev 190660)
@@ -559,6 +559,8 @@
 bindings/gobject/WebKitDOMObject.cpp
 bindings/gobject/WebKitDOMPrivate.cpp
 bindings/gobject/WebKitDOMXPathNSResolver.cpp
+${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
+${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
 ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines.h
 ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines-unstable.h
 ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdom.h
@@ -774,6 +776,7 @@
 
 set(GObjectDOMBindingsStable_CLASS_LIST ${GObjectDOMBindings_STATIC_CLASS_LIST})
 set(GObjectDOMBindingsStable_INSTALLED_HEADERS
+ ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
  ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines.h
  ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdom.h
  ${WEBCORE_DIR}/bindings/gobject/WebKitDOMCustom.h
@@ -785,6 +788,7 @@
 )
 
 set(GObjectDOMBindingsUnstable_INSTALLED_HEADERS
+ ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
  ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines-unstable.h
  ${WEBCORE_DIR}/bindings/gobject/WebKitDOMCustomUnstable.h
 )
@@ -826,6 +830,18 @@
 COMMAND echo ${GObjectDOMBindingsStable_CLASS_LIST} | ${PERL_EXECUTABLE} ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl gdom > ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdom.h
 )
 
+add_custom_command(
+OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
+DEPENDS ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl
+COMMAND echo ${GObjectDOMBindingsStable_CLASS_LIST} | ${PERL_EXECUTABLE} ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl autocleanups > ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
+)
+
+add_custom_command(
+OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
+DEPENDS ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl
+COMMAND echo ${GObjectDOMBindingsUnstable_CLASS_LIST} | ${PERL_EXECUTABLE} ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl autocleanups > ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
+)
+
 # Some of the static headers are included by generated public headers with include .
 # We need those headers in the derived sources to be in webkitdom directory.

[webkit-changes] [190633] trunk

2015-10-06 Thread jfernandez 
Title: [190633] trunk








Revision 190633
Author jfernan...@igalia.com
Date 2015-10-06 12:23:52 -0700 (Tue, 06 Oct 2015)


Log Message
[CSS Grid Layout] Don't need to reset auto-margins during grid items layout
https://bugs.webkit.org/show_bug.cgi?id=149764

Reviewed by Darin Adler.

Source/WebCore:

This patch implements a refactoring of the auto-margin alignment code for grid
items so it uses start/end and before/after margin logic terms.

I addition, it avoids resetting the auto-margin values, which requires an extra
layout, before applying the alignment logic.

No new tests because there is no behavior change.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeMarginLogicalHeightForChild): Computing margins if child needs layout.
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching):
(WebCore::RenderGrid::updateAutoMarginsInRowAxisIfNeeded): Using start/end logical margins.
(WebCore::RenderGrid::updateAutoMarginsInColumnAxisIfNeeded): Using before/after logical margins.
(WebCore::RenderGrid::columnAxisOffsetForChild): Just added comment.
(WebCore::RenderGrid::rowAxisOffsetForChild): Just added comment.

LayoutTests:

Removed a duplicated layout tests.

* fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change-expected.txt: Removed.
* fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp


Removed Paths

trunk/LayoutTests/fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change.html




Diff

Modified: trunk/LayoutTests/ChangeLog (190632 => 190633)

--- trunk/LayoutTests/ChangeLog	2015-10-06 19:13:46 UTC (rev 190632)
+++ trunk/LayoutTests/ChangeLog	2015-10-06 19:23:52 UTC (rev 190633)
@@ -1,3 +1,15 @@
+2015-10-06  Javier Fernandez  
+
+[CSS Grid Layout] Don't need to reset auto-margins during grid items layout
+https://bugs.webkit.org/show_bug.cgi?id=149764
+
+Reviewed by Darin Adler.
+
+Removed a duplicated layout tests.
+
+* fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change-expected.txt: Removed.
+* fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change.html: Removed.
+
 2015-10-02  Jon Honeycutt  
 
 Import some Blink layout tests.


Deleted: trunk/LayoutTests/fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change-expected.txt (190632 => 190633)

--- trunk/LayoutTests/fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change-expected.txt	2015-10-06 19:13:46 UTC (rev 190632)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change-expected.txt	2015-10-06 19:23:52 UTC (rev 190633)
@@ -1,4 +0,0 @@
-The grids below had initially 'stretched' items, but we have changed 'height' and 'margin' to values which don't allow stretch. This test verifies that the layout algorithm properly detects such changes and clear the override height accordingly.
-
-PASS
-PASS


Deleted: trunk/LayoutTests/fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change.html (190632 => 190633)

--- trunk/LayoutTests/fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change.html	2015-10-06 19:13:46 UTC (rev 190632)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change.html	2015-10-06 19:23:52 UTC (rev 190633)
@@ -1,37 +0,0 @@
-
-
-
-.grid {
--webkit-grid-template: 200px 200px / 200px 200px;
-width: -webkit-fit-content;
-position: relative;
-}
-#fromFixedHeight { height: 100px; }
-#fromMarginAuto { margin: auto; }
-
-
The grids below had initially 'stretched' items, but we have changed 'height' and 'margin' to values which don't allow stretch. This test verifies that the layout algorithm properly detects such changes and clear the override height accordingly.

-

-

-

-

-

-

-

-

-

-

-

-

-

[webkit-changes] [190630] trunk/Tools

2015-10-06 Thread keith_miller 
Title: [190630] trunk/Tools








Revision 190630
Author keith_mil...@apple.com
Date 2015-10-06 11:45:04 -0700 (Tue, 06 Oct 2015)


Log Message
Fix run-_javascript_core-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
https://bugs.webkit.org/show_bug.cgi?id=149815

Reviewed by Filip Pizlo.

Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
so should just use one test runner.

* Scripts/run-_javascript_core-tests:
(runJSCStressTests):
(runMozillaTests): Deleted.
(defaultJsDriverArgsForMozillaTests): Deleted.
* Scripts/run-jsc-stress-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/Tools/ChangeLog (190629 => 190630)

--- trunk/Tools/ChangeLog	2015-10-06 18:39:21 UTC (rev 190629)
+++ trunk/Tools/ChangeLog	2015-10-06 18:45:04 UTC (rev 190630)
@@ -1,3 +1,22 @@
+2015-10-06  Keith Miller  
+
+Fix run-_javascript_core-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
+https://bugs.webkit.org/show_bug.cgi?id=149815
+
+Reviewed by Filip Pizlo.
+
+Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
+Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
+running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
+Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
+so should just use one test runner.
+
+* Scripts/run-_javascript_core-tests:
+(runJSCStressTests):
+(runMozillaTests): Deleted.
+(defaultJsDriverArgsForMozillaTests): Deleted.
+* Scripts/run-jsc-stress-tests:
+
 2015-10-06  Mark Salisbury  
 
 [GTK] Make update-webkitgtk-libs work behind firewall


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (190629 => 190630)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2015-10-06 18:39:21 UTC (rev 190629)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2015-10-06 18:45:04 UTC (rev 190630)
@@ -57,6 +57,8 @@
 
 my $runJSCStress = 1;
 my $runJITStressTests = 1;
+my $runQuickMode = 0;
+my $envVars = "";
 
 my $enableFTL = isAppleMacWebKit();
 my $createTarball = 0;
@@ -68,6 +70,7 @@
 my $testapiDefault = $runTestAPI ? "will run" : "will not run";
 my $jscStressDefault = $runJSCStress ? "will run" : " will not run";
 my $jitStressTestsDefault = $runJITStressTests ? "will run" : " will not run";
+my $quickModeDefault = $runQuickMode ? "some" : "all";
 my $filter;
 my $usage = <

[webkit-changes] [190631] trunk/Source/WebKit2

2015-10-06 Thread andersca 
Title: [190631] trunk/Source/WebKit2








Revision 190631
Author ander...@apple.com
Date 2015-10-06 12:11:24 -0700 (Tue, 06 Oct 2015)


Log Message
WKPage needs to expose a KVO-compliant object, similar to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=149851
rdar://problem/22382022

Reviewed by Dan Bernstein.

Move the PageLoadStateObserver object from WKBrowsingContextController out into a separate file and make it
work with any Objective-C object. Use it in WKObservablePageState and add a WKPageCreateObservableState function.

* UIProcess/API/C/mac/WKPagePrivateMac.h:
* UIProcess/API/C/mac/WKPagePrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp.
(-[WKObservablePageState initWithPage:]):
(-[WKObservablePageState dealloc]):
(-[WKObservablePageState isLoading]):
(-[WKObservablePageState title]):
(-[WKObservablePageState URL]):
(-[WKObservablePageState hasOnlySecureContent]):
(-[WKObservablePageState estimatedProgress]):
(WKPageCreateObservableState):
(WKPageGetProcessIdentifier):
(WKPageIsURLKnownHSTSHost):
* UIProcess/API/Cocoa/PageLoadStateObserver.h: Added.
(WebKit::PageLoadStateObserver::PageLoadStateObserver):
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(PageLoadStateObserver::PageLoadStateObserver): Deleted.
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/PageLoadStateObserver.h


Removed Paths

trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (190630 => 190631)

--- trunk/Source/WebKit2/ChangeLog	2015-10-06 18:45:04 UTC (rev 190630)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-06 19:11:24 UTC (rev 190631)
@@ -1,3 +1,32 @@
+2015-10-06  Anders Carlsson  
+
+WKPage needs to expose a KVO-compliant object, similar to WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=149851
+rdar://problem/22382022
+
+Reviewed by Dan Bernstein.
+
+Move the PageLoadStateObserver object from WKBrowsingContextController out into a separate file and make it
+work with any Objective-C object. Use it in WKObservablePageState and add a WKPageCreateObservableState function.
+
+* UIProcess/API/C/mac/WKPagePrivateMac.h:
+* UIProcess/API/C/mac/WKPagePrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp.
+(-[WKObservablePageState initWithPage:]):
+(-[WKObservablePageState dealloc]):
+(-[WKObservablePageState isLoading]):
+(-[WKObservablePageState title]):
+(-[WKObservablePageState URL]):
+(-[WKObservablePageState hasOnlySecureContent]):
+(-[WKObservablePageState estimatedProgress]):
+(WKPageCreateObservableState):
+(WKPageGetProcessIdentifier):
+(WKPageIsURLKnownHSTSHost):
+* UIProcess/API/Cocoa/PageLoadStateObserver.h: Added.
+(WebKit::PageLoadStateObserver::PageLoadStateObserver):
+* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
+(PageLoadStateObserver::PageLoadStateObserver): Deleted.
+* WebKit2.xcodeproj/project.pbxproj:
+
 2015-10-06  Daniel Bates  
 
 Enable XSLT when building WebKit for iOS using the public iOS SDK


Deleted: trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp (190630 => 190631)

--- trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp	2015-10-06 18:45:04 UTC (rev 190630)
+++ trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp	2015-10-06 19:11:24 UTC (rev 190631)
@@ -1,48 +0,0 @@
-/*
- * Copyright (C) 2011 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- *

[webkit-changes] [190632] trunk/Source/WebInspectorUI

2015-10-06 Thread commit-queue 
Title: [190632] trunk/Source/WebInspectorUI








Revision 190632
Author commit-qu...@webkit.org
Date 2015-10-06 12:13:46 -0700 (Tue, 06 Oct 2015)


Log Message
Web Inspector: Simplify TimelineRecordBar a bit
https://bugs.webkit.org/show_bug.cgi?id=149733

Patch by Joseph Pecoraro  on 2015-10-06
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.prototype.set records):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (190631 => 190632)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-10-06 19:11:24 UTC (rev 190631)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-10-06 19:13:46 UTC (rev 190632)
@@ -1,3 +1,13 @@
+2015-10-06  Joseph Pecoraro  
+
+Web Inspector: Simplify TimelineRecordBar a bit
+https://bugs.webkit.org/show_bug.cgi?id=149733
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TimelineRecordBar.js:
+(WebInspector.TimelineRecordBar.prototype.set records):
+
 2015-10-05  Nikita Vasilyev  
 
 Web Inspector: Error displayed as an object when passed as a second argument to console.log


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js (190631 => 190632)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js	2015-10-06 19:11:24 UTC (rev 190631)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js	2015-10-06 19:13:46 UTC (rev 190632)
@@ -194,8 +194,7 @@
 
 records = records || [];
 
-if (!(records instanceof Array))
-records = [records];
+console.assert(records instanceof Array, "records should be an array");
 
 this._records = records;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190628] trunk/Source/WebCore

2015-10-06 Thread timothy_horton 
Title: [190628] trunk/Source/WebCore








Revision 190628
Author timothy_hor...@apple.com
Date 2015-10-06 11:20:29 -0700 (Tue, 06 Oct 2015)


Log Message
Tile map shows a green rect when threaded scrolling is disabled
https://bugs.webkit.org/show_bug.cgi?id=149716

Reviewed by Darin Adler.

Green is supposed to indicate that we're using the fast path; if threaded
scrolling is disabled, we're definitely not doing that.

* platform/graphics/TiledBacking.h:
* platform/graphics/ca/TileController.cpp:
(WebCore::TileController::TileController):
* platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::update):
Default to the "we have no ScrollingCoordinator" purple indication;
if a ScrollingCoordinator comes along it will setScrollingModeIndication
and change it from this default.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/TiledBacking.h
trunk/Source/WebCore/platform/graphics/ca/TileController.cpp
trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190627 => 190628)

--- trunk/Source/WebCore/ChangeLog	2015-10-06 18:06:34 UTC (rev 190627)
+++ trunk/Source/WebCore/ChangeLog	2015-10-06 18:20:29 UTC (rev 190628)
@@ -1,3 +1,22 @@
+2015-10-06  Tim Horton  
+
+Tile map shows a green rect when threaded scrolling is disabled
+https://bugs.webkit.org/show_bug.cgi?id=149716
+
+Reviewed by Darin Adler.
+
+Green is supposed to indicate that we're using the fast path; if threaded
+scrolling is disabled, we're definitely not doing that.
+
+* platform/graphics/TiledBacking.h:
+* platform/graphics/ca/TileController.cpp:
+(WebCore::TileController::TileController):
+* platform/graphics/ca/TileCoverageMap.cpp:
+(WebCore::TileCoverageMap::update):
+Default to the "we have no ScrollingCoordinator" purple indication;
+if a ScrollingCoordinator comes along it will setScrollingModeIndication
+and change it from this default.
+
 2015-10-06  Zalan Bujtas  
 
 Remove redundant isComposited() function and replace


Modified: trunk/Source/WebCore/platform/graphics/TiledBacking.h (190627 => 190628)

--- trunk/Source/WebCore/platform/graphics/TiledBacking.h	2015-10-06 18:06:34 UTC (rev 190627)
+++ trunk/Source/WebCore/platform/graphics/TiledBacking.h	2015-10-06 18:20:29 UTC (rev 190628)
@@ -35,6 +35,7 @@
 class PlatformCALayer;
 
 enum ScrollingModeIndication {
+SynchronousScrollingBecauseOfLackOfScrollingCoordinatorIndication,
 SynchronousScrollingBecauseOfStyleIndication,
 SynchronousScrollingBecauseOfEventHandlersIndication,
 AsyncScrollingIndication


Modified: trunk/Source/WebCore/platform/graphics/ca/TileController.cpp (190627 => 190628)

--- trunk/Source/WebCore/platform/graphics/ca/TileController.cpp	2015-10-06 18:06:34 UTC (rev 190627)
+++ trunk/Source/WebCore/platform/graphics/ca/TileController.cpp	2015-10-06 18:20:29 UTC (rev 190628)
@@ -70,7 +70,7 @@
 , m_tilesAreOpaque(false)
 , m_hasTilesWithTemporaryScaleFactor(false)
 , m_tileDebugBorderWidth(0)
-, m_indicatorMode(AsyncScrollingIndication)
+, m_indicatorMode(SynchronousScrollingBecauseOfLackOfScrollingCoordinatorIndication)
 , m_topContentInset(0)
 {
 }


Modified: trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp (190627 => 190628)

--- trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp	2015-10-06 18:06:34 UTC (rev 190627)
+++ trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp	2015-10-06 18:20:29 UTC (rev 190628)
@@ -101,6 +101,9 @@
 
 Color visibleRectIndicatorColor;
 switch (m_controller.indicatorMode()) {
+case SynchronousScrollingBecauseOfLackOfScrollingCoordinatorIndication:
+visibleRectIndicatorColor = Color(200, 80, 255);
+break;
 case SynchronousScrollingBecauseOfStyleIndication:
 visibleRectIndicatorColor = Color(255, 0, 0);
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190607] trunk/Source/JavaScriptCore

2015-10-06 Thread commit-queue 
Title: [190607] trunk/Source/_javascript_Core








Revision 190607
Author commit-qu...@webkit.org
Date 2015-10-05 23:15:11 -0700 (Mon, 05 Oct 2015)


Log Message
Unreviewed, rolling out r190599.
https://bugs.webkit.org/show_bug.cgi?id=149836

Made perf tests randomly crash (Requested by ap on #webkit).

Reverted changeset:

"GC shouldn't cancel every FTL compilation"
https://bugs.webkit.org/show_bug.cgi?id=149821
http://trac.webkit.org/changeset/190599

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGPlan.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190606 => 190607)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-06 05:51:34 UTC (rev 190606)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-06 06:15:11 UTC (rev 190607)
@@ -1,5 +1,18 @@
 2015-10-05  Commit Queue  
 
+Unreviewed, rolling out r190599.
+https://bugs.webkit.org/show_bug.cgi?id=149836
+
+Made perf tests randomly crash (Requested by ap on #webkit).
+
+Reverted changeset:
+
+"GC shouldn't cancel every FTL compilation"
+https://bugs.webkit.org/show_bug.cgi?id=149821
+http://trac.webkit.org/changeset/190599
+
+2015-10-05  Commit Queue  
+
 Unreviewed, rolling out r190589.
 https://bugs.webkit.org/show_bug.cgi?id=149833
 


Modified: trunk/Source/_javascript_Core/dfg/DFGPlan.cpp (190606 => 190607)

--- trunk/Source/_javascript_Core/dfg/DFGPlan.cpp	2015-10-06 05:51:34 UTC (rev 190606)
+++ trunk/Source/_javascript_Core/dfg/DFGPlan.cpp	2015-10-06 06:15:11 UTC (rev 190607)
@@ -644,26 +644,12 @@
 {
 if (stage == Cancelled)
 return false;
-
-// NOTE: From here on, this method can return anything and still be sound. It's sound to return
-// false because then we'll just cancel the compilation. It's always sound to do that. It's sound
-// to return true because then we'll just keep alive everything that the compilation needs to
-// have live. The only thing you have to worry about is performance. The goal of returning false
-// is to try to minimize the likelihood that we expend effort compiling something that will be
-// DOA - that is, the code being compiled is only reachable from the compilation worklist itself
-// or the code being compiled is going to have weak references to things that are otherwise dead.
-// If you return false too often, then you'll regress performance because you might be killing a
-// compilation that wouldn't have been DOA, and so you're losing opportunities to run faster
-// code. If you return true too often, then you'll regress performance because you might expend
-// too much effort compiling something that will be DOA.
-
 if (!Heap::isMarked(codeBlock->ownerExecutable()))
 return false;
-
-// FIXME: We could detect if the alternate CodeBlock or the profiled DFG CodeBlock have
-// experienced troubles and may be jettisoned.
-// https://bugs.webkit.org/show_bug.cgi?id=149823
-
+if (!codeBlock->alternative()->isKnownToBeLiveDuringGC())
+return false;
+if (!!profiledDFGCodeBlock && !profiledDFGCodeBlock->isKnownToBeLiveDuringGC())
+return false;
 return true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190609] trunk/LayoutTests

2015-10-06 Thread commit-queue 
Title: [190609] trunk/LayoutTests








Revision 190609
Author commit-qu...@webkit.org
Date 2015-10-05 23:54:48 -0700 (Mon, 05 Oct 2015)


Log Message
Unreviewed EFL Gardening
https://bugs.webkit.org/show_bug.cgi?id=149830

Remove "--lint-test-files warnings".

Patch by Byung Jun Kim  on 2015-10-05

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190608 => 190609)

--- trunk/LayoutTests/ChangeLog	2015-10-06 06:20:58 UTC (rev 190608)
+++ trunk/LayoutTests/ChangeLog	2015-10-06 06:54:48 UTC (rev 190609)
@@ -1,3 +1,12 @@
+2015-10-05  Byung Jun Kim  
+
+Unreviewed EFL Gardening
+https://bugs.webkit.org/show_bug.cgi?id=149830
+
+Remove "--lint-test-files warnings".
+
+* platform/efl/TestExpectations:
+
 2015-10-05  Youenn Fablet  
 
 Migrate streams API to JS Builtins


Modified: trunk/LayoutTests/platform/efl/TestExpectations (190608 => 190609)

--- trunk/LayoutTests/platform/efl/TestExpectations	2015-10-06 06:20:58 UTC (rev 190608)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2015-10-06 06:54:48 UTC (rev 190609)
@@ -80,9 +80,6 @@
 css3/font-feature-settings-preinstalled-fonts.html [ Skip ]
 css3/font-feature-settings-rendering-2.html [ Skip ]
 
-# No support system font punctuation in EFL yet. This test was added by r188377.
-fast/text/system-font-punctuation.html [ Skip ]
-
 # 
 # Tests which also fail in other platforms
 # 
@@ -778,7 +775,6 @@
 webkit.org/b/77631 fast/multicol/span/span-as-immediate-child-property-removal.html [ Failure Pass ]
 webkit.org/b/77631 fast/multicol/span/span-as-immediate-columns-child-removal.html [ Failure Pass ]
 
-webkit.org/b/93213 fast/text/international/text-spliced-font.html [ Failure Pass ]
 webkit.org/b/93214 http/tests/loading/307-after-303-after-post.html [ Crash Pass Timeout ]
 webkit.org/b/93212 http/tests/incremental/slow-utf8-text.pl [ Pass Timeout ]
 
@@ -1927,7 +1923,7 @@
 
 webkit.org/b/124663 media/track/track-legacyapi-with-automatic-mode.html [ Skip ]
 
-webkit.org/b/124890 platform/efl/accessibility/media-emits-object-replacement.html [ Failure ]
+webkit.org/b/124890 accessibility/media-emits-object-replacement.html [ Failure ]
 
 webkit.org/b/125506 accessibility/alt-tag-on-image-with-nonimage-role.html [ Failure ]
 
@@ -2525,13 +2521,6 @@
 webkit.org/b/148470 imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements.html [ Failure ]
 webkit.org/b/148470 imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements.xhtml [ Failure ]
 webkit.org/b/148470 imported/w3c/web-platform-tests/html/dom/interfaces.html [ Failure ]
-webkit.org/b/148470 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-control.html [ Failure ]
-webkit.org/b/148470 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-br.html [ Failure ]
-webkit.org/b/148470 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-source.html [ Failure ]
-webkit.org/b/148470 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-text.html [ Failure ]
-webkit.org/b/148470 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-after.html [ Failure ]
-webkit.org/b/148470 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source.html [ Failure ]
-webkit.org/b/148470 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-text.html [ Failure ]
 webkit.org/b/148470 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html [ Failure ]
 webkit.org/b/148470 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplaythrough.html [ Failure ]
 webkit.org/b/148470 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190644] trunk/LayoutTests

2015-10-06 Thread simon . fraser 
Title: [190644] trunk/LayoutTests








Revision 190644
Author simon.fra...@apple.com
Date 2015-10-06 13:57:22 -0700 (Tue, 06 Oct 2015)


Log Message
Mark compositing/geometry/limit-layer-bounds-opacity-transition.html as failing
on iOS WK2.

* platform/ios-simulator-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190643 => 190644)

--- trunk/LayoutTests/ChangeLog	2015-10-06 20:45:07 UTC (rev 190643)
+++ trunk/LayoutTests/ChangeLog	2015-10-06 20:57:22 UTC (rev 190644)
@@ -1,3 +1,10 @@
+2015-10-06  Simon Fraser  
+
+Mark compositing/geometry/limit-layer-bounds-opacity-transition.html as failing
+on iOS WK2.
+
+* platform/ios-simulator-wk2/TestExpectations:
+
 2015-10-06  Ryan Haddad  
 
 Take 2 on marking compositing/video/video-poster.html as flaky due to crashes.


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (190643 => 190644)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2015-10-06 20:45:07 UTC (rev 190643)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2015-10-06 20:57:22 UTC (rev 190644)
@@ -78,6 +78,7 @@
 compositing/fixed-positioned-pseudo-content-no-compositing.html [ Failure ]
 compositing/reflections/nested-reflection-on-overflow.html [ Failure ]
 compositing/repaint/invalidations-on-composited-layers.html [ Failure ]
+compositing/geometry/limit-layer-bounds-opacity-transition.html [ Failure ]
 
 # Compositing test that time out:
 compositing/animation/animation-compositing.html
@@ -187,7 +188,7 @@
 # MathML tests that fail:
 mathml/presentation/mo-stretch.html [ Failure ]
 
-# SVG tests that time out:
+# SVG tests that time out (these require EventSender)
 svg/animations/animVal-basics.html
 svg/animations/animate-calcMode-spline-by.html
 svg/animations/animate-calcMode-spline-from-by.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190637] trunk/Source/WebCore

2015-10-06 Thread youenn . fablet 
Title: [190637] trunk/Source/WebCore








Revision 190637
Author youenn.fab...@crf.canon.fr
Date 2015-10-06 13:14:08 -0700 (Tue, 06 Oct 2015)


Log Message
Binding generator XXConstructor::finishCreation should take references as parameters
https://bugs.webkit.org/show_bug.cgi?id=149838

Reviewed by Darin Adler.

Updated the binding generator so that XXConstructor::finishCreation
takes a JSDOMGlobalObject& in lieu of a JSDOMGlobalObject*.

Covered by rebased binding tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::create):
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallbackConstructor::create):
(WebCore::JSTestCallbackConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::create):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::create):
(WebCore::JSTestEventTargetConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableConstructor::create):
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::create):
(WebCore::JSTestNodeConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicConstructor::create):
(WebCore::JSTestNondeterministicConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsConstructor::create):
(WebCore::JSTestOverrideBuiltinsConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::finishCreation):
* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeConstructor::create):
(WebCore::JSattributeConstructor::finishCreation):
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyConstructor::create):
(WebCore::JSreadonlyConstructor::finishCreation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp

[webkit-changes] [190634] trunk

2015-10-06 Thread commit-queue 
Title: [190634] trunk








Revision 190634
Author commit-qu...@webkit.org
Date 2015-10-06 12:48:24 -0700 (Tue, 06 Oct 2015)


Log Message
Fix crash in ApplyStyleCommand::applyRelativeFontStyleChange()
https://bugs.webkit.org/show_bug.cgi?id=149300


Patch by Jiewen Tan  on 2015-10-06
Reviewed by Chris Dumez.

Source/WebCore:

This is a merge of Blink r167845 and r194944:
https://codereview.chromium.org/177093016
https://codereview.chromium.org/1124863003

Test: editing/style/apply-style-crash2.html
  editing/style/apply-style-crash3.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
The issue was that we would traverse the DOM tree past the beyondEnd
under some circumstances and thus NodeTraversal::next() would return
null unexpectedly. This CL adds a check to make sure startNode != beyondEnd
before traversing to avoid the problem.

Besides that, this CL hardens changing font style over unknown elements.
When adjusting the start node position of where to apply a font style
command, check that we haven't stepped off the end.

This CL also adds a few more assertions to catch similar issues
more easily in the future.

LayoutTests:

* editing/style/apply-style-crash2-expected.txt: Added.
* editing/style/apply-style-crash2.html: Added.
* editing/style/apply-style-crash3-expected.txt: Added.
* editing/style/apply-style-crash3.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ApplyStyleCommand.cpp


Added Paths

trunk/LayoutTests/editing/style/apply-style-crash2-expected.txt
trunk/LayoutTests/editing/style/apply-style-crash2.html
trunk/LayoutTests/editing/style/apply-style-crash3-expected.txt
trunk/LayoutTests/editing/style/apply-style-crash3.html




Diff

Modified: trunk/LayoutTests/ChangeLog (190633 => 190634)

--- trunk/LayoutTests/ChangeLog	2015-10-06 19:23:52 UTC (rev 190633)
+++ trunk/LayoutTests/ChangeLog	2015-10-06 19:48:24 UTC (rev 190634)
@@ -1,3 +1,16 @@
+2015-10-06  Jiewen Tan  
+
+Fix crash in ApplyStyleCommand::applyRelativeFontStyleChange()
+https://bugs.webkit.org/show_bug.cgi?id=149300
+
+
+Reviewed by Chris Dumez.
+
+* editing/style/apply-style-crash2-expected.txt: Added.
+* editing/style/apply-style-crash2.html: Added.
+* editing/style/apply-style-crash3-expected.txt: Added.
+* editing/style/apply-style-crash3.html: Added.
+
 2015-10-06  Javier Fernandez  
 
 [CSS Grid Layout] Don't need to reset auto-margins during grid items layout


Added: trunk/LayoutTests/editing/style/apply-style-crash2-expected.txt (0 => 190634)

--- trunk/LayoutTests/editing/style/apply-style-crash2-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/style/apply-style-crash2-expected.txt	2015-10-06 19:48:24 UTC (rev 190634)
@@ -0,0 +1,2 @@
+This test passes if it does not crash.
+PASS


Added: trunk/LayoutTests/editing/style/apply-style-crash2.html (0 => 190634)

--- trunk/LayoutTests/editing/style/apply-style-crash2.html	(rev 0)
+++ trunk/LayoutTests/editing/style/apply-style-crash2.html	2015-10-06 19:48:24 UTC (rev 190634)
@@ -0,0 +1,25 @@
+
+
+
+This test passes if it does not crash.
+
+if (window.testRunner)
+  testRunner.dumpAsText();
+
+el1 = document.createElement('li');
+document.body.appendChild(el1);
+el2 = document.createElement('thead');
+el1.appendChild(el2);
+el2.parentNode.insertBefore(document.createElement('video'), el2);
+el2.parentNode.insertBefore(document.createElement('input'), el2);
+document.designMode = 'on';
+window.getSelection().setBaseAndExtent(el1, 2, el2, 4);
+document.designMode = 'off';
+window.getSelection().modify('extend', 'backward', 'character');
+el1.innerHTML = "PASS";
+document.designMode = 'on';
+document.execCommand('FontSizeDelta', false, '-1px');
+document.designMode = 'off';
+
+
+


Added: trunk/LayoutTests/editing/style/apply-style-crash3-expected.txt (0 => 190634)

--- trunk/LayoutTests/editing/style/apply-style-crash3-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/style/apply-style-crash3-expected.txt	2015-10-06 19:48:24 UTC (rev 190634)
@@ -0,0 +1,9 @@
+Verify that changing the style over an unknown element does not crash.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/editing/style/apply-style-crash3.html (0 => 190634)

--- trunk/LayoutTests/editing/style/apply-style-crash3.html	(rev 0)
+++ trunk/LayoutTests/editing/style/apply-style-crash3.html	2015-10-06 19:48:24 UTC (rev 190634)
@@ -0,0 +1,30 @@
+
+
+
+
+
+
+