[webkit-changes] [198774] trunk/Source/WebInspectorUI

[commit-queue]

Title: [198774] trunk/Source/WebInspectorUI








Revision 198774
Author commit-qu...@webkit.org
Date 2016-03-28 20:28:10 -0700 (Mon, 28 Mar 2016)


Log Message
Web Inspector: Ensure maximum accuracy while profiling
https://bugs.webkit.org/show_bug.cgi?id=155809


Patch by Joseph Pecoraro  on 2016-03-28
Reviewed by Timothy Hatcher.

* Localizations/en.lproj/localizedStrings.js:
New strings.

* UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager):
When starting the inspector, if it was previously closed while
breakpoints were temporarily disabled, restore the correct
breakpoints enabled state.

(WebInspector.DebuggerManager.prototype.set breakpointsEnabled):
Warn if we ever try to enable breakpoints during timeline recordings.

(WebInspector.DebuggerManager.prototype.get breakpointsDisabledTemporarily):
(WebInspector.DebuggerManager.prototype.startDisablingBreakpointsTemporarily):
(WebInspector.DebuggerManager.prototype.stopDisablingBreakpointsTemporarily):
Method to start/stop temporarily disabling breakpoints.

(WebInspector.DebuggerManager.prototype._breakpointDisabledStateDidChange):
(WebInspector.DebuggerManager.prototype._setBreakpoint):
When temporarily disabling breakpoints avoid the convenience behavior of
enabling all breakpoints when enabling or setting a single breakpoint.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.startCapturing):
Emit a will start capturing event to do work before enabling instruments.

* UserInterface/Views/DebuggerSidebarPanel.css:
(.sidebar > .panel.navigation.debugger .timeline-recording-warning):
(.sidebar > .panel.navigation.debugger .timeline-recording-warning > a):
Styles for a warning section in the Debugger Sidebar when the Debugger
is temporarily disabled due to a Timeline recording.

* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype._timelineRecordingWillStart):
(WebInspector.DebuggerSidebarPanel.prototype._timelineRecordingStopped):
Modify the Debugger state and UI before and after a Timeline recording.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (198773 => 198774)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-03-29 02:03:22 UTC (rev 198773)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-03-29 03:28:10 UTC (rev 198774)
@@ -1,3 +1,48 @@
+2016-03-28  Joseph Pecoraro  
+
+Web Inspector: Ensure maximum accuracy while profiling
+https://bugs.webkit.org/show_bug.cgi?id=155809
+
+
+Reviewed by Timothy Hatcher.
+
+* Localizations/en.lproj/localizedStrings.js:
+New strings.
+
+* UserInterface/Controllers/DebuggerManager.js:
+(WebInspector.DebuggerManager):
+When starting the inspector, if it was previously closed while
+breakpoints were temporarily disabled, restore the correct
+breakpoints enabled state.
+
+(WebInspector.DebuggerManager.prototype.set breakpointsEnabled):
+Warn if we ever try to enable breakpoints during timeline recordings.
+
+(WebInspector.DebuggerManager.prototype.get breakpointsDisabledTemporarily):
+(WebInspector.DebuggerManager.prototype.startDisablingBreakpointsTemporarily):
+(WebInspector.DebuggerManager.prototype.stopDisablingBreakpointsTemporarily):
+Method to start/stop temporarily disabling breakpoints.
+
+(WebInspector.DebuggerManager.prototype._breakpointDisabledStateDidChange):
+(WebInspector.DebuggerManager.prototype._setBreakpoint):
+When temporarily disabling breakpoints avoid the convenience behavior of
+enabling all breakpoints when enabling or setting a single breakpoint.
+
+* UserInterface/Controllers/TimelineManager.js:
+(WebInspector.TimelineManager.prototype.startCapturing):
+Emit a will start capturing event to do work before enabling instruments.
+
+* UserInterface/Views/DebuggerSidebarPanel.css:
+(.sidebar > .panel.navigation.debugger .timeline-recording-warning):
+(.sidebar > .panel.navigation.debugger .timeline-recording-warning > a):
+Styles for a warning section in the Debugger Sidebar when the Debugger
+is temporarily disabled due to a Timeline recording.
+
+* UserInterface/Views/DebuggerSidebarPanel.js:
+(WebInspector.DebuggerSidebarPanel.prototype._timelineRecordingWillStart):
+(WebInspector.DebuggerSidebarPanel.prototype._timelineRecordingStopped):
+Modify the Debugger state and UI 

[webkit-changes] [198773] trunk

[achristensen]

Title: [198773] trunk








Revision 198773
Author achristen...@apple.com
Date 2016-03-28 19:03:22 -0700 (Mon, 28 Mar 2016)


Log Message
Fix Mac Ninja build after r198766.

.:

* Source/cmake/WebKitMacros.cmake:
WebCore_DERIVED_SOURCES are intentionally in a separate library to reduce linker line length.
This is now only specific to WebKit2_DERIVED_SOURCES, so I'm moving it there.

Source/WebKit2:

* CMakeLists.txt:

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/cmake/WebKitMacros.cmake




Diff

Modified: trunk/ChangeLog (198772 => 198773)

--- trunk/ChangeLog	2016-03-29 01:27:51 UTC (rev 198772)
+++ trunk/ChangeLog	2016-03-29 02:03:22 UTC (rev 198773)
@@ -1,5 +1,13 @@
 2016-03-28  Alex Christensen  
 
+Fix Mac Ninja build after r198766.
+
+* Source/cmake/WebKitMacros.cmake:
+WebCore_DERIVED_SOURCES are intentionally in a separate library to reduce linker line length.
+This is now only specific to WebKit2_DERIVED_SOURCES, so I'm moving it there.
+
+2016-03-28  Alex Christensen  
+
 Fix Windows build after r198766.
 
 * Source/cmake/WebKitMacros.cmake:


Modified: trunk/Source/WebKit2/CMakeLists.txt (198772 => 198773)

--- trunk/Source/WebKit2/CMakeLists.txt	2016-03-29 01:27:51 UTC (rev 198772)
+++ trunk/Source/WebKit2/CMakeLists.txt	2016-03-29 02:03:22 UTC (rev 198773)
@@ -826,6 +826,8 @@
 ${DERIVED_SOURCES_WEBKIT2_DIR}/WebAutomationSessionProxyScriptSource.h
 )
 
+list(APPEND WebKit2_SOURCES ${WebKit2_DERIVED_SOURCES})
+
 WEBKIT_FRAMEWORK(WebKit2)
 add_dependencies(WebKit2 WebCore ${WEBKIT2_EXTRA_DEPENDENCIES})
 add_webkit2_prefix_header(WebKit2)


Modified: trunk/Source/WebKit2/ChangeLog (198772 => 198773)

--- trunk/Source/WebKit2/ChangeLog	2016-03-29 01:27:51 UTC (rev 198772)
+++ trunk/Source/WebKit2/ChangeLog	2016-03-29 02:03:22 UTC (rev 198773)
@@ -1,3 +1,9 @@
+2016-03-28  Alex Christensen  
+
+Fix Mac Ninja build after r198766.
+
+* CMakeLists.txt:
+
 2016-03-28  Brady Eidson  
 
 Modern IDB: Remove abstract base classes for all IDB DOM classes.


Modified: trunk/Source/cmake/WebKitMacros.cmake (198772 => 198773)

--- trunk/Source/cmake/WebKitMacros.cmake	2016-03-29 01:27:51 UTC (rev 198772)
+++ trunk/Source/cmake/WebKitMacros.cmake	2016-03-29 02:03:22 UTC (rev 198773)
@@ -249,7 +249,6 @@
 add_library(${_target} ${${_target}_LIBRARY_TYPE}
 ${${_target}_HEADERS}
 ${${_target}_SOURCES}
-${${_target}_DERIVED_SOURCES}
 )
 target_link_libraries(${_target} ${${_target}_LIBRARIES})
 set_target_properties(${_target} PROPERTIES COMPILE_DEFINITIONS "BUILDING_${_target}")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198772] trunk

[achristensen]

Title: [198772] trunk








Revision 198772
Author achristen...@apple.com
Date 2016-03-28 18:27:51 -0700 (Mon, 28 Mar 2016)


Log Message
Fix Windows build after r198766.

* Source/cmake/WebKitMacros.cmake:
Use the filename from the cpp so that WebCorePrefix.cpp and WebCoreDerivedSourcesPrefix.cpp 
generate unique .pch files, even though they both include WebCorePrefix.h

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/WebKitMacros.cmake




Diff

Modified: trunk/ChangeLog (198771 => 198772)

--- trunk/ChangeLog	2016-03-29 01:06:56 UTC (rev 198771)
+++ trunk/ChangeLog	2016-03-29 01:27:51 UTC (rev 198772)
@@ -1,5 +1,13 @@
 2016-03-28  Alex Christensen  
 
+Fix Windows build after r198766.
+
+* Source/cmake/WebKitMacros.cmake:
+Use the filename from the cpp so that WebCorePrefix.cpp and WebCoreDerivedSourcesPrefix.cpp 
+generate unique .pch files, even though they both include WebCorePrefix.h
+
+2016-03-28  Alex Christensen  
+
 Fix Ninja build on Mac
 https://bugs.webkit.org/show_bug.cgi?id=151399
 


Modified: trunk/Source/cmake/WebKitMacros.cmake (198771 => 198772)

--- trunk/Source/cmake/WebKitMacros.cmake	2016-03-29 01:06:56 UTC (rev 198771)
+++ trunk/Source/cmake/WebKitMacros.cmake	2016-03-29 01:27:51 UTC (rev 198772)
@@ -25,7 +25,7 @@
 
 macro(ADD_PRECOMPILED_HEADER _header _cpp _source)
 if (MSVC)
-get_filename_component(PrecompiledBasename ${_header} NAME_WE)
+get_filename_component(PrecompiledBasename ${_cpp} NAME_WE)
 file(MAKE_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/${_source}")
 set(PrecompiledBinary "${CMAKE_CURRENT_BINARY_DIR}/${_source}/${PrecompiledBasename}.pch")
 set(_sources ${${_source}})






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198771] trunk

[zalan]

Title: [198771] trunk








Revision 198771
Author za...@apple.com
Date 2016-03-28 18:06:56 -0700 (Mon, 28 Mar 2016)


Log Message
Pixel turds when bordered div is resized on SMF forum software.
https://bugs.webkit.org/show_bug.cgi?id=155957


Reviewed by Simon Fraser.

Use unmodified, non-snapped bounding box rect when computing dirty rects.

Source/WebCore:

Test: fast/repaint/hidpi-box-with-subpixel-height-inflates.html

* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.h:
* rendering/RenderElement.cpp:
(WebCore::RenderElement::getTrailingCorner):
* rendering/RenderInline.h:
* rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::borderBoundingBox): Deleted.
* rendering/RenderLineBreak.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::setBestTruncatedAt):

LayoutTests:

* fast/repaint/hidpi-box-with-subpixel-height-inflates-expected.txt: Added.
* fast/repaint/hidpi-box-with-subpixel-height-inflates.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderBoxModelObject.h
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderInline.h
trunk/Source/WebCore/rendering/RenderLineBreak.cpp
trunk/Source/WebCore/rendering/RenderLineBreak.h
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebKit2/Shared/WebRenderObject.cpp


Added Paths

trunk/LayoutTests/fast/repaint/hidpi-box-with-subpixel-height-inflates-expected.txt
trunk/LayoutTests/fast/repaint/hidpi-box-with-subpixel-height-inflates.html




Diff

Modified: trunk/LayoutTests/ChangeLog (198770 => 198771)

--- trunk/LayoutTests/ChangeLog	2016-03-29 00:59:07 UTC (rev 198770)
+++ trunk/LayoutTests/ChangeLog	2016-03-29 01:06:56 UTC (rev 198771)
@@ -1,3 +1,16 @@
+2016-03-28  Zalan Bujtas  
+
+Pixel turds when bordered div is resized on SMF forum software.
+https://bugs.webkit.org/show_bug.cgi?id=155957
+
+
+Reviewed by Simon Fraser.
+
+Use unmodified, non-snapped bounding box rect when computing dirty rects.
+
+* fast/repaint/hidpi-box-with-subpixel-height-inflates-expected.txt: Added.
+* fast/repaint/hidpi-box-with-subpixel-height-inflates.html: Added.
+
 2016-03-28  Chris Fleizach  
 
 AX: Crash when AX trying to create element for an old auto fill element


Added: trunk/LayoutTests/fast/repaint/hidpi-box-with-subpixel-height-inflates-expected.txt (0 => 198771)

--- trunk/LayoutTests/fast/repaint/hidpi-box-with-subpixel-height-inflates-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/repaint/hidpi-box-with-subpixel-height-inflates-expected.txt	2016-03-29 01:06:56 UTC (rev 198771)
@@ -0,0 +1,12 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+(repaint rects
+(rect 0 49.50 22 152.50)
+(rect 0 48.50 22 1)
+(rect 0 49.50 800 152.50)
+(rect 0 49.50 800 152.50)
+(rect 1 1 1 47.50)
+(rect 1 1 1 200)
+)
+


Added: trunk/LayoutTests/fast/repaint/hidpi-box-with-subpixel-height-inflates.html (0 => 198771)

--- trunk/LayoutTests/fast/repaint/hidpi-box-with-subpixel-height-inflates.html	(rev 0)
+++ trunk/LayoutTests/fast/repaint/hidpi-box-with-subpixel-height-inflates.html	2016-03-29 01:06:56 UTC (rev 198771)
@@ -0,0 +1,45 @@
+
+
+jsTestIsAsync = true;
+
+
+
+
+
+

+