[webkit-changes] [199976] trunk/Source/WebCore

2016-04-24 Thread cdumez 
Title: [199976] trunk/Source/WebCore








Revision 199976
Author cdu...@apple.com
Date 2016-04-24 22:59:04 -0700 (Sun, 24 Apr 2016)


Log Message
[Web IDL] Specify default values for boolean parameters
https://bugs.webkit.org/show_bug.cgi?id=156964

Reviewed by Darin Adler.

Specify default values for boolean parameters in our IDL files and
let the bindings generator use WTF::Optional<> for the ones without
a default value.

* CMakeLists.txt:
* Modules/indexeddb/IDBKeyRange.cpp:
* Modules/indexeddb/IDBKeyRange.h:
* Modules/indexeddb/IDBKeyRange.idl:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:

* bindings/js/JSDOMTokenListCustom.cpp: Removed.
We no longer need these custom bindings as the bindings generator
will now provide the implementation with an Optional, given
that the parameter has no default value.

* bindings/scripts/CodeGeneratorJS.pm:
(CanUseWTFOptionalForParameterType): Deleted.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_with_optional_boolean):
(webkit_dom_test_obj_method_with_optional_boolean_is_false):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalBoolean):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalBooleanIsFalse):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj methodWithOptionalBoolean:]):
(-[DOMTestObj methodWithOptionalBooleanIsFalse:]):
* bindings/scripts/test/TestObj.idl:
* dom/Document.h:
* dom/Document.idl:
* dom/Element.idl:
* dom/EventTarget.idl:
* html/DOMTokenList.idl:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.h
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.idl
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebCore/dom/EventTarget.idl
trunk/Source/WebCore/html/DOMTokenList.idl


Removed Paths

trunk/Source/WebCore/bindings/js/JSDOMTokenListCustom.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (199975 => 199976)

--- trunk/Source/WebCore/CMakeLists.txt	2016-04-25 05:56:09 UTC (rev 199975)
+++ trunk/Source/WebCore/CMakeLists.txt	2016-04-25 05:59:04 UTC (rev 199976)
@@ -1123,7 +1123,6 @@
 bindings/js/JSDOMPromise.cpp
 bindings/js/JSDOMStringListCustom.cpp
 bindings/js/JSDOMStringMapCustom.cpp
-bindings/js/JSDOMTokenListCustom.cpp
 bindings/js/JSDOMWindowBase.cpp
 bindings/js/JSDOMWindowCustom.cpp
 bindings/js/JSDOMWindowShell.cpp


Modified: trunk/Source/WebCore/ChangeLog (199975 => 199976)

--- trunk/Source/WebCore/ChangeLog	2016-04-25 05:56:09 UTC (rev 199975)
+++ trunk/Source/WebCore/ChangeLog	2016-04-25 05:59:04 UTC (rev 199976)
@@ -1,5 +1,48 @@
 2016-04-24  Chris Dumez  
 
+[Web IDL] Specify default values for boolean parameters
+https://bugs.webkit.org/show_bug.cgi?id=156964
+
+Reviewed by Darin Adler.
+
+Specify default values for boolean parameters in our IDL files and
+let the bindings generator use WTF::Optional<> for the ones without
+a default value.
+
+* CMakeLists.txt:
+* Modules/indexeddb/IDBKeyRange.cpp:
+* Modules/indexeddb/IDBKeyRange.h:
+* Modules/indexeddb/IDBKeyRange.idl:
+* WebCore.xcodeproj/project.pbxproj:
+* bindings/js/JSBindingsAllInOne.cpp:
+
+* bindings/js/JSDOMTokenListCustom.cpp: Removed.
+We no longer need these custom bindings as the bindings generator
+will now provide the implementation with an Optional, given
+that the parameter has no default value.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(CanUseWTFOptionalForParameterType): Deleted.
+* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+(webkit_dom_test_obj_method_with_optional_boolean):
+(webkit_dom_test_obj_method_with_optional_boolean_is_false):
+* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalBoolean):
+(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalBooleanIsFalse):
+* bindings/scripts/test/ObjC/DOMTestObj.h:
+*

[webkit-changes] [199975] trunk/LayoutTests

2016-04-24 Thread gyuyoung . kim 
Title: [199975] trunk/LayoutTests








Revision 199975
Author gyuyoung@webkit.org
Date 2016-04-24 22:56:09 -0700 (Sun, 24 Apr 2016)


Log Message
[EFL] Some media tests have been failed after bumping gstreamer ver.

Unreviewed EFL gardening. Mark failing tests to timeout or failure.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (199974 => 199975)

--- trunk/LayoutTests/ChangeLog	2016-04-25 03:09:18 UTC (rev 199974)
+++ trunk/LayoutTests/ChangeLog	2016-04-25 05:56:09 UTC (rev 199975)
@@ -1,3 +1,11 @@
+2016-04-24  Gyuyoung Kim  
+
+[EFL] Some media tests have been failed after bumping gstreamer ver.
+
+Unreviewed EFL gardening. Mark failing tests to timeout or failure.
+
+* platform/efl/TestExpectations:
+
 2016-04-24  Chris Dumez  
 
 Autogenerated IDBFactory.open() does the wrong thing if you pass an explicit 'undefined' as the second argument


Modified: trunk/LayoutTests/platform/efl/TestExpectations (199974 => 199975)

--- trunk/LayoutTests/platform/efl/TestExpectations	2016-04-25 03:09:18 UTC (rev 199974)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2016-04-25 05:56:09 UTC (rev 199975)
@@ -2628,3 +2628,60 @@
 webkit.org/b/156024 svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml [ Failure ]
 webkit.org/b/156024 svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml [ Failure ]
 webkit.org/b/156024 svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml [ Failure ]
+
+# Media tests have been failing since we bumped gstreamer ver.
+webkit.org/b/156969 media/media-source/media-source-canplaythrough.html [ Timeout ]
+webkit.org/b/156969 media/media-source/media-source-end-of-stream-buffered.html [ Timeout ]
+webkit.org/b/156969 media/media-source/media-source-end-of-stream-readyState.html [ Timeout ]
+webkit.org/b/156969 media/media-source/media-source-end-of-stream.html [ Timeout ]
+webkit.org/b/156969 media/media-source/media-source-fudge-factor.html [ Timeout ]
+webkit.org/b/156969 media/media-source/media-source-loadedmetada-with-two-sourcebuffers.html [ Timeout ]
+webkit.org/b/156969 media/media-source/media-source-multiple-initialization-segments.html [ Timeout ]
+webkit.org/b/156969 media/media-source/media-source-play.html [ Timeout ]
+webkit.org/b/156969 media/media-source/media-source-remove.html [ Timeout ]
+webkit.org/b/156969 media/track/track-automatic-subtitles.html [ Timeout ]
+webkit.org/b/156969 media/track/track-cues-pause-on-exit.html [ Timeout ]
+webkit.org/b/156969 media/video-controls-toggling.html [ Timeout ]
+webkit.org/b/156969 media/accessiblity-describes-video.html [ Failure ]
+webkit.org/b/156969 media/controls-right-click-on-timebar.html [ Failure ]
+webkit.org/b/156969 media/controls-strict.html [ Failure ]
+webkit.org/b/156969 media/controls-without-preload.html [ Failure ]
+webkit.org/b/156969 media/media-controls-drag-timeline-set-controls-property.html [ Failure ]
+webkit.org/b/156969 media/media-controls-invalid-url.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-append-media-segment-without-init.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-append-nonsync-sample-after-abort.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-duration-after-append.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-monitor-source-buffers.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-overlapping-append.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-overlapping-decodetime.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-sequence-timestamps.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-timeoffset.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-track-enabled.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-tracks.html [ Failure ]
+webkit.org/b/156969 media/media-source/media-source-video-playback-quality.html [ Failure ]
+webkit.org/b/156969 media/nodesFromRect-shadowContent.html [ Failure ]
+webkit.org/b/156969 media/track/track-cue-rendering-snap-to-lines-not-set.html [ Failure ]
+webkit.org/b/156969 media/track/track-cue-rendering-vertical.html [ Failure ]
+webkit.org/b/156969 media/track/track-cue-rendering.html [ Failure ]
+webkit.org/b/156969 media/track/track-delete-during-setup.html [ Failure ]
+webkit.org/b/156969 media/track/track-insert-after-load-crash.html [ Failure ]
+webkit.org/b/156969 media/track/track-long-word-container-sizing.html [ Failure ]
+webkit.org/b/156969 media/track/track-manual-mode.html [ Failure ]
+webkit.org/b/156969 media/track/track-mode-not-changed-by-new-track.html [ Failure ]
+webkit.org/b/156969 media/track/track-mode-triggers-loading.html [ Failure ]
+webkit.org/b/156969

[webkit-changes] [199974] trunk/Source/WebInspectorUI

2016-04-24 Thread mattbaker 
Title: [199974] trunk/Source/WebInspectorUI








Revision 199974
Author mattba...@apple.com
Date 2016-04-24 20:09:18 -0700 (Sun, 24 Apr 2016)


Log Message
Web Inspector: Can't sort by name/source code location columns in Timeline data grids
https://bugs.webkit.org/show_bug.cgi?id=156965


Reviewed by Timothy Hatcher.

Add support for sorting SourceCodeLocation objects to TimelineDataGrid,
and include a grid delegate so that views can extend sorting logic for
other document fragment columns.

* UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView):
(WebInspector.NetworkTimelineView.prototype.dataGridSortComparator):
Sort "name" column by display name first, then resource URL.

* UserInterface/Views/ScriptDetailsTimelineView.js:
(WebInspector.ScriptDetailsTimelineView):
(WebInspector.ScriptDetailsTimelineView.prototype.dataGridSortComparator):
Sort "name" column by display name first, then subtitle.

* UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.get subtitle):
Make subtitle accessible externally for sorting.
(WebInspector.ScriptTimelineDataGridNode.prototype._createNameCellDocumentFragment):
(WebInspector.ScriptTimelineDataGridNode):

* UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid):
(WebInspector.TimelineDataGrid.prototype.get sortDelegate):
(WebInspector.TimelineDataGrid.prototype.set sortDelegate):
Fire a SortChanged event if the delegate changed and the grid is sorted.
(WebInspector.TimelineDataGrid.prototype._sort):
If a sort delegate exists, and it returns a numeric value, skip the
default compare.

(WebInspector.TimelineDataGrid.prototype._sortComparator):
Add support for sorting SourceCodeLocation columns.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineDataGridNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (199973 => 199974)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-04-25 01:40:20 UTC (rev 199973)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-04-25 03:09:18 UTC (rev 199974)
@@ -1,5 +1,45 @@
 2016-04-24  Matt Baker  
 
+Web Inspector: Can't sort by name/source code location columns in Timeline data grids
+https://bugs.webkit.org/show_bug.cgi?id=156965
+
+
+Reviewed by Timothy Hatcher.
+
+Add support for sorting SourceCodeLocation objects to TimelineDataGrid,
+and include a grid delegate so that views can extend sorting logic for
+other document fragment columns.
+
+* UserInterface/Views/NetworkTimelineView.js:
+(WebInspector.NetworkTimelineView):
+(WebInspector.NetworkTimelineView.prototype.dataGridSortComparator):
+Sort "name" column by display name first, then resource URL.
+
+* UserInterface/Views/ScriptDetailsTimelineView.js:
+(WebInspector.ScriptDetailsTimelineView):
+(WebInspector.ScriptDetailsTimelineView.prototype.dataGridSortComparator):
+Sort "name" column by display name first, then subtitle.
+
+* UserInterface/Views/ScriptTimelineDataGridNode.js:
+(WebInspector.ScriptTimelineDataGridNode.prototype.get subtitle):
+Make subtitle accessible externally for sorting.
+(WebInspector.ScriptTimelineDataGridNode.prototype._createNameCellDocumentFragment):
+(WebInspector.ScriptTimelineDataGridNode):
+
+* UserInterface/Views/TimelineDataGrid.js:
+(WebInspector.TimelineDataGrid):
+(WebInspector.TimelineDataGrid.prototype.get sortDelegate):
+(WebInspector.TimelineDataGrid.prototype.set sortDelegate):
+Fire a SortChanged event if the delegate changed and the grid is sorted.
+(WebInspector.TimelineDataGrid.prototype._sort):
+If a sort delegate exists, and it returns a numeric value, skip the
+default compare.
+
+(WebInspector.TimelineDataGrid.prototype._sortComparator):
+Add support for sorting SourceCodeLocation columns.
+
+2016-04-24  Matt Baker  
+
 Web Inspector: Error when selecting a bar in the Frames timeline
 https://bugs.webkit.org/show_bug.cgi?id=156960
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js (199973 => 199974)

--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js	2016-04-25 01:40:20 UTC (rev 199973)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js	2016-04-25 03:09:18 UTC (rev 199974)
@@ -90,6 +90,7 @@
 this._dataGrid = new WebInspector.TimelineDataGrid(columns);
 this._dataGrid.addEventListener(WebInspector.TimelineDataGrid.Event.FiltersDidChange,

[webkit-changes] [199973] trunk/LayoutTests/imported/w3c

2016-04-24 Thread cdumez 
Title: [199973] trunk/LayoutTests/imported/w3c








Revision 199973
Author cdu...@apple.com
Date 2016-04-24 18:40:20 -0700 (Sun, 24 Apr 2016)


Log Message
Unreviewed, revert part of r199970 that shouldn't have been committed.

* web-platform-tests/IndexedDB/idbfactory_open9.htm:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbfactory_open9.htm




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (199972 => 199973)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-04-25 01:03:22 UTC (rev 199972)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-04-25 01:40:20 UTC (rev 199973)
@@ -1,5 +1,11 @@
 2016-04-24  Chris Dumez  
 
+Unreviewed, revert part of r199970 that shouldn't have been committed.
+
+* web-platform-tests/IndexedDB/idbfactory_open9.htm:
+
+2016-04-24  Chris Dumez  
+
 Autogenerated IDBFactory.open() does the wrong thing if you pass an explicit 'undefined' as the second argument
 https://bugs.webkit.org/show_bug.cgi?id=156939
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbfactory_open9.htm (199972 => 199973)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbfactory_open9.htm	2016-04-25 01:03:22 UTC (rev 199972)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbfactory_open9.htm	2016-04-25 01:40:20 UTC (rev 199973)
@@ -1,7 +1,7 @@
 
 IDBFactory.open() - errors in version argument

[webkit-changes] [199972] trunk/Source/WebInspectorUI

2016-04-24 Thread mattbaker 
Title: [199972] trunk/Source/WebInspectorUI








Revision 199972
Author mattba...@apple.com
Date 2016-04-24 18:03:22 -0700 (Sun, 24 Apr 2016)


Log Message
Web Inspector: Error when selecting a bar in the Frames timeline
https://bugs.webkit.org/show_bug.cgi?id=156960


Reviewed by Timothy Hatcher.

Fixes timeline grid node selection when record selected in the overview.
Adds general purpose `findNode` method to DataGrid.

* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.findNode):
Basic find function for locating a grid node in linear time.

* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._recordSelected):
Remove tree outline references, call generic select method.

* UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.selectRecord):
If a data grid was set, deselect current selection and select the node
associated with the timeline record.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (199971 => 199972)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-04-25 00:59:48 UTC (rev 199971)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-04-25 01:03:22 UTC (rev 199972)
@@ -1,5 +1,29 @@
 2016-04-24  Matt Baker  
 
+Web Inspector: Error when selecting a bar in the Frames timeline
+https://bugs.webkit.org/show_bug.cgi?id=156960
+
+
+Reviewed by Timothy Hatcher.
+
+Fixes timeline grid node selection when record selected in the overview.
+Adds general purpose `findNode` method to DataGrid.
+
+* UserInterface/Views/DataGrid.js:
+(WebInspector.DataGrid.prototype.findNode):
+Basic find function for locating a grid node in linear time.
+
+* UserInterface/Views/TimelineRecordingContentView.js:
+(WebInspector.TimelineRecordingContentView.prototype._recordSelected):
+Remove tree outline references, call generic select method.
+
+* UserInterface/Views/TimelineView.js:
+(WebInspector.TimelineView.prototype.selectRecord):
+If a data grid was set, deselect current selection and select the node
+associated with the timeline record.
+
+2016-04-24  Matt Baker  
+
 Web Inspector: Events in _javascript_ & Events timeline have no profile children
 https://bugs.webkit.org/show_bug.cgi?id=156627
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (199971 => 199972)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js	2016-04-25 00:59:48 UTC (rev 199971)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js	2016-04-25 01:03:22 UTC (rev 199972)
@@ -1042,6 +1042,23 @@
 this.children = [];
 }
 
+findNode(comparator, skipHidden, stayWithin, dontPopulate)
+{
+console.assert(typeof comparator === "function");
+
+let currentNode = this._rows[0];
+while (currentNode && !currentNode.root) {
+if (!currentNode.isPlaceholderNode && !(skipHidden && currentNode.hidden)) {
+if (comparator(currentNode))
+return currentNode;
+}
+
+currentNode = currentNode.traverseNextNode(skipHidden, stayWithin, dontPopulate);
+}
+
+return null;
+}
+
 sortNodes(comparator)
 {
 if (this._sortNodesRequestId)


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (199971 => 199972)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2016-04-25 00:59:48 UTC (rev 199971)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2016-04-25 01:03:22 UTC (rev 199972)
@@ -715,28 +715,12 @@
 
 _recordSelected(event)
 {
-var timelineView = this._timelineViewMap.get(event.data.timeline);
+let timelineView = this._timelineViewMap.get(event.data.timeline);
 console.assert(timelineView === this.currentTimelineView, timelineView);
 if (timelineView !== this.currentTimelineView)
 return;
 
-var selectedTreeElement = this.currentTimelineView.navigationSidebarTreeOutline.selectedTreeElement;
-if (!event.data.record) {
-if (selectedTreeElement)
-selectedTreeElement.deselect();
-return;
-}
-
-var treeElement = this.currentTimelineView.navigationSidebarTreeOutline.findTreeElement(event.data.record);
-console.assert(treeElement, "Timeline view has no tree element for record selected in timeline overview.", timelineView, event.data.record);
-if (!treeElement || treeElement.selected)
-return;
-
-

[webkit-changes] [199971] trunk/Source/WebInspectorUI

2016-04-24 Thread mattbaker 
Title: [199971] trunk/Source/WebInspectorUI








Revision 199971
Author mattba...@apple.com
Date 2016-04-24 17:59:48 -0700 (Sun, 24 Apr 2016)


Log Message
Web Inspector: Events in _javascript_ & Events timeline have no profile children
https://bugs.webkit.org/show_bug.cgi?id=156627


Reviewed by Timothy Hatcher.

ProfileNodeDataGridNode should handle `populate` events when expanded.
This was previously done by ProfileNodeTreeElement, which is no longer
used in the Timelines tab.

* UserInterface/Views/ProfileDataGridNode.js:
(WebInspector.ProfileDataGridNode.prototype._updateChildrenForModifiers):
(WebInspector.ProfileDataGridNode.prototype._populate):
(WebInspector.ProfileDataGridNode):
DataGridNode sets `shouldRefreshChildren` to false after populating
child nodes. No need to track with a separate flag.

* UserInterface/Views/ProfileNodeDataGridNode.js:
(WebInspector.ProfileNodeDataGridNode):
(WebInspector.ProfileNodeDataGridNode.prototype._populate):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ProfileDataGridNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/ProfileNodeDataGridNode.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (199970 => 199971)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-04-25 00:27:30 UTC (rev 199970)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-04-25 00:59:48 UTC (rev 199971)
@@ -1,3 +1,26 @@
+2016-04-24  Matt Baker  
+
+Web Inspector: Events in _javascript_ & Events timeline have no profile children
+https://bugs.webkit.org/show_bug.cgi?id=156627
+
+
+Reviewed by Timothy Hatcher.
+
+ProfileNodeDataGridNode should handle `populate` events when expanded.
+This was previously done by ProfileNodeTreeElement, which is no longer
+used in the Timelines tab.
+
+* UserInterface/Views/ProfileDataGridNode.js:
+(WebInspector.ProfileDataGridNode.prototype._updateChildrenForModifiers):
+(WebInspector.ProfileDataGridNode.prototype._populate):
+(WebInspector.ProfileDataGridNode):
+DataGridNode sets `shouldRefreshChildren` to false after populating
+child nodes. No need to track with a separate flag.
+
+* UserInterface/Views/ProfileNodeDataGridNode.js:
+(WebInspector.ProfileNodeDataGridNode):
+(WebInspector.ProfileNodeDataGridNode.prototype._populate):
+
 2016-04-22  Matt Baker  
 
 Web Inspector: HeapAllocationsTimeline grid should use built-in grid column icons


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProfileDataGridNode.js (199970 => 199971)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ProfileDataGridNode.js	2016-04-25 00:27:30 UTC (rev 199970)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProfileDataGridNode.js	2016-04-25 00:59:48 UTC (rev 199971)
@@ -32,7 +32,6 @@
 this._node = cctNode;
 this._tree = tree;
 
-this._populated = false;
 this._childrenToChargeToSelf = new Set;
 this._extraSelfTimeFromChargedChildren = 0;
 
@@ -136,7 +135,7 @@
 let isBottomUp = this._tree.callingContextTree.type === WebInspector.CallingContextTree.Type.BottomUp;
 if (!this._tree.hasModifiers() || isBottomUp) {
 // Add back child data grid nodes that were previously charged to us.
-if (this._populated && this._childrenToChargeToSelf.size) {
+if (!this.shouldRefreshChildren && this._childrenToChargeToSelf.size) {
 for (let child of this._childrenToChargeToSelf) {
 console.assert(child.hasStackTraceInTimeRange(this._tree.startTime, this._tree.endTime));
 this.appendChild(new WebInspector.ProfileDataGridNode(child, this._tree));
@@ -173,7 +172,7 @@
 this.hasChildren = hasNonChargedChild;
 
 // Remove child data grid nodes that have been charged to us.
-if (this._populated && this._childrenToChargeToSelf.size) {
+if (!this.shouldRefreshChildren && this._childrenToChargeToSelf.size) {
 for (let childDataGridNode of this.children) {
 if (this._childrenToChargeToSelf.has(childDataGridNode.node))
 this.removeChild(childDataGridNode);
@@ -238,7 +237,8 @@
 
 _populate()
 {
-this._populated = true;
+if (!this.shouldRefreshChildren)
+return;
 
 this._node.forEachChild((child) => {
 if (!this._childrenToChargeToSelf.has(child)) {


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProfileNodeDataGridNode.js (199970 => 199971)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ProfileNodeDataGridNode.js	2016-04-25 00:27:30 UTC (rev 199970)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProfileNodeDataGridNode.js	2016-04-25 00:59:48 UTC (rev 199971)
@@ -37,6 +37,8 @@
 this._rangeEndTime = typeof rangeEndTime === "number" ?

[webkit-changes] [199970] trunk

2016-04-24 Thread cdumez 
Title: [199970] trunk








Revision 199970
Author cdu...@apple.com
Date 2016-04-24 17:27:30 -0700 (Sun, 24 Apr 2016)


Log Message
Autogenerated IDBFactory.open() does the wrong thing if you pass an explicit 'undefined' as the second argument
https://bugs.webkit.org/show_bug.cgi?id=156939

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync tests from upstream b1818929.

* IndexedDB-private-browsing/idbfactory_open9-expected.txt:
* IndexedDB-private-browsing/idbfactory_open9.html:
* web-platform-tests/IndexedDB/idbfactory_open9-expected.txt:
* web-platform-tests/IndexedDB/idbfactory_open9.htm:

Source/WebCore:

As per WebIDL, if undefined is passed by JS for an optional parameter then
we should use its default value if it has one, or use the special value
"missing":
http://heycam.github.io/webidl/#es-overloads (step 10.4)

Our bindings generator was already mapping undefined to the parameter's
default value when present. However, it was missing the notion of
"missing" value when there no default value. This patch adds supports
for its by passing Optional<>(Nullopt) to the implementation in such
case. This means that the implementation will need to use WTF::Optional<>
type for parameters that do not have a default value. Thankfully though,
in most cases, we will be able to specify a default value in the IDL
so cases where we will need to use WTF::Optional<> will actually be
rare.

To avoid having to do too much refactoring in this patch, the support
for WTF::Optional is currently blacklisted for most IDL types. I will
gradually stop blacklisting each type in follow-up patches, as I either:
- Add default parameter values in our IDL (preferred)
- Use WTF::Optional<> in our implementation (when we cannot specify a
  default value).

This patch fixes a bug with IDBFactory.open()'s second parameter (version)
for which undefined should not throw and indicate that the version
should not be changed. We now use WTF::Optional in the implementation to
distinguish this case and not throw.

No new tests, existing tests were updated / rebaselined.

* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::openInternal): Deleted.
* Modules/indexeddb/IDBFactory.h:
* bindings/scripts/CodeGeneratorJS.pm:
(ShouldUseWTFOptionalForParameterType):
(GenerateParametersCheck):
* fileapi/Blob.idl:
* inspector/InspectorIndexedDBAgent.cpp:

LayoutTests:

Update / rebaseline existing test now that passing undefined as second parameter to
IDBFactory.open() no longer throws.

* storage/indexeddb/intversion-bad-parameters-expected.txt:
* storage/indexeddb/intversion-bad-parameters-private-expected.txt:
* storage/indexeddb/resources/intversion-bad-parameters.js:
(deleteSuccess):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/IndexedDB-private-browsing/idbfactory_open9-expected.txt
trunk/LayoutTests/imported/w3c/IndexedDB-private-browsing/idbfactory_open9.html
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbfactory_open9-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbfactory_open9.htm
trunk/LayoutTests/storage/indexeddb/intversion-bad-parameters-expected.txt
trunk/LayoutTests/storage/indexeddb/intversion-bad-parameters-private-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/intversion-bad-parameters.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBFactory.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/TestTypedefs.idl
trunk/Source/WebCore/fileapi/Blob.idl
trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (199969 => 199970)

--- trunk/LayoutTests/ChangeLog	2016-04-24 17:23:41 UTC (rev 199969)
+++ trunk/LayoutTests/ChangeLog	2016-04-25 00:27:30 UTC (rev 199970)
@@ -1,3 +1,18 @@
+2016-04-24  Chris Dumez  
+
+Autogenerated IDBFactory.open() does the wrong thing if you pass an explicit 'undefined' as the second argument
+https://bugs.webkit.org/show_bug.cgi?id=156939
+
+Reviewed by Darin Adler.
+
+Update / rebaseline existing test now that passing undefined as second parameter to
+IDBFactory.open() no longer throws.
+
+* storage/indexeddb/intversion-bad-parameters-expected.txt:
+* storage/indexeddb/intversion-bad-parameters-private-expected.txt:
+*

[webkit-changes] [199967] trunk

2016-04-24 Thread fpizlo 
Title: [199967] trunk








Revision 199967
Author fpi...@apple.com
Date 2016-04-24 10:05:51 -0700 (Sun, 24 Apr 2016)


Log Message
[INTL] Implement String.prototype.localeCompare in ECMA-402
https://bugs.webkit.org/show_bug.cgi?id=147607

Patch by Filip Pizlo  and Andy VanWagoner  on 2016-04-24
Reviewed by Darin Adler.
Source/_javascript_Core:


Part of this change is just rolling 194394 back in.

The other part is making that not a regression on CDjs. Other than the fact that it uses
bound functions, the problem with this new localeCompare implementation is that it uses
the arguments object. It uses it in a way that *seems* like ArgumentsEliminationPhase
ought to handle, but to my surprise it didn't:

- If we have a ForceExit GetByVal on the arguments object, we would previously assume that
  it escaped. That's false since we just exit at ForceExit. On the other hand we probably
  should be pruning unreachable paths before we get here, but that's a separate issue. I
  don't want to play with phase order right now.

- If we have a OutOfBounds GetByVal on the arguments object, then the best that would
  previously happen is that we'd compile it into an in-bounds arguments access. That's quite
  bad, as Andy's localeCompare illustrates: it uses out-of-bounds access on the arguments
  object to detect if an argument was passed. This change introduces an OutOfBounds version
  of GetMyArgumentByVal for this purpose.

This change required registering sane chain watchpoints. In the process, I noticed that the
old way of doing it had a race condition: we might register watchpoints for the structure
that had become insane. This change introduces a double-checking idiom that I believe works
because once the structure becomes insane it can't go back to sane and watchpoints
registration already involves executing the hardest possible fences.

* builtins/StringPrototype.js:
(repeat):
(localeCompare):
(search):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGArgumentsEliminationPhase.cpp:
* dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
* dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGValidate.cpp:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
* ftl/FTLTypedPointer.h:
(JSC::FTL::TypedPointer::TypedPointer):
(JSC::FTL::TypedPointer::operator bool):
(JSC::FTL::TypedPointer::heap):
(JSC::FTL::TypedPointer::operator!): Deleted.
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):

LayoutTests:


* js/dom/script-tests/string-prototype-properties.js:
* js/dom/string-prototype-properties-expected.txt:
* js/regress/locale-compare.html: Added.
* js/regress/locale-compare-expected.txt: Added.
* js/regress/scripts-tests/locale-compare.js: Added.
* js/script-tests/string-localeCompare.js:
* js/string-localeCompare-expected.txt:
* js/string-localeCompare.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/script-tests/string-prototype-properties.js
trunk/LayoutTests/js/dom/string-prototype-properties-expected.txt
trunk/LayoutTests/js/script-tests/string-localeCompare.js
trunk/LayoutTests/js/string-localeCompare-expected.txt
trunk/LayoutTests/js/string-localeCompare.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/StringPrototype.js
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGDoesGC.cpp
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGPreciseLocalClobberize.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp

[webkit-changes] [199966] tags/Safari-602.1.29.1/Source

2016-04-24 Thread bshafiei 
Title: [199966] tags/Safari-602.1.29.1/Source








Revision 199966
Author bshaf...@apple.com
Date 2016-04-24 09:20:10 -0700 (Sun, 24 Apr 2016)


Log Message
Versioning.

Modified Paths

tags/Safari-602.1.29.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-602.1.29.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-602.1.29.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-602.1.29.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-602.1.29.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-602.1.29.1/Source/_javascript_Core/Configurations/Version.xcconfig (199965 => 199966)

--- tags/Safari-602.1.29.1/Source/_javascript_Core/Configurations/Version.xcconfig	2016-04-24 16:18:19 UTC (rev 199965)
+++ tags/Safari-602.1.29.1/Source/_javascript_Core/Configurations/Version.xcconfig	2016-04-24 16:20:10 UTC (rev 199966)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
 TINY_VERSION = 29;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-602.1.29.1/Source/WebCore/Configurations/Version.xcconfig (199965 => 199966)

--- tags/Safari-602.1.29.1/Source/WebCore/Configurations/Version.xcconfig	2016-04-24 16:18:19 UTC (rev 199965)
+++ tags/Safari-602.1.29.1/Source/WebCore/Configurations/Version.xcconfig	2016-04-24 16:20:10 UTC (rev 199966)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
 TINY_VERSION = 29;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-602.1.29.1/Source/WebInspectorUI/Configurations/Version.xcconfig (199965 => 199966)

--- tags/Safari-602.1.29.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-04-24 16:18:19 UTC (rev 199965)
+++ tags/Safari-602.1.29.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-04-24 16:20:10 UTC (rev 199966)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
 TINY_VERSION = 29;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-602.1.29.1/Source/WebKit/mac/Configurations/Version.xcconfig (199965 => 199966)

--- tags/Safari-602.1.29.1/Source/WebKit/mac/Configurations/Version.xcconfig	2016-04-24 16:18:19 UTC (rev 199965)
+++ tags/Safari-602.1.29.1/Source/WebKit/mac/Configurations/Version.xcconfig	2016-04-24 16:20:10 UTC (rev 199966)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
 TINY_VERSION = 29;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-602.1.29.1/Source/WebKit2/Configurations/Version.xcconfig (199965 => 199966)

--- tags/Safari-602.1.29.1/Source/WebKit2/Configurations/Version.xcconfig	2016-04-24 16:18:19 UTC (rev 199965)
+++ tags/Safari-602.1.29.1/Source/WebKit2/Configurations/Version.xcconfig	2016-04-24 16:20:10 UTC (rev 199966)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
 TINY_VERSION = 29;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199965] tags/Safari-602.1.29.1/

2016-04-24 Thread bshafiei 
Title: [199965] tags/Safari-602.1.29.1/








Revision 199965
Author bshaf...@apple.com
Date 2016-04-24 09:18:19 -0700 (Sun, 24 Apr 2016)


Log Message
New tag.

Added Paths

tags/Safari-602.1.29.1/




Diff

Property changes: tags/Safari-602.1.29.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199963] trunk/Source/WebCore

2016-04-24 Thread youenn . fablet 
Title: [199963] trunk/Source/WebCore








Revision 199963
Author youenn.fab...@crf.canon.fr
Date 2016-04-24 05:45:44 -0700 (Sun, 24 Apr 2016)


Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from MediaControlsHost
https://bugs.webkit.org/show_bug.cgi?id=156903

Reviewed by Chris Dumez.

No change of behavior.

* Modules/mediacontrols/MediaControlsHost.idl: Marking some parameters as nullable.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (199962 => 199963)

--- trunk/Source/WebCore/ChangeLog	2016-04-24 12:45:06 UTC (rev 199962)
+++ trunk/Source/WebCore/ChangeLog	2016-04-24 12:45:44 UTC (rev 199963)
@@ -1,5 +1,16 @@
 2016-04-24  Youenn Fablet  
 
+Drop [UsePointersEvenForNonNullableObjectArguments] from MediaControlsHost
+https://bugs.webkit.org/show_bug.cgi?id=156903
+
+Reviewed by Chris Dumez.
+
+No change of behavior.
+
+* Modules/mediacontrols/MediaControlsHost.idl: Marking some parameters as nullable.
+
+2016-04-24  Youenn Fablet  
+
 Drop [UsePointersEvenForNonNullableObjectArguments] from WebGLRenderingContext
 https://bugs.webkit.org/show_bug.cgi?id=156909
 


Modified: trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl (199962 => 199963)

--- trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl	2016-04-24 12:45:06 UTC (rev 199962)
+++ trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl	2016-04-24 12:45:44 UTC (rev 199963)
@@ -30,19 +30,18 @@
 };
 
 [
-NoInterfaceObject,
 Conditional=MEDIA_CONTROLS_SCRIPT,
-UsePointersEvenForNonNullableObjectArguments,
 ImplementationLacksVTable,
+NoInterfaceObject,
 ] interface MediaControlsHost {
-TextTrack[] sortedTrackListForMenu(TextTrackList trackList);
-AudioTrack[] sortedTrackListForMenu(AudioTrackList trackList);
-DOMString displayNameForTrack(TextTrack track);
-DOMString displayNameForTrack(AudioTrack track);
+TextTrack[] sortedTrackListForMenu(TextTrackList? trackList);
+AudioTrack[] sortedTrackListForMenu(AudioTrackList? trackList);
+DOMString displayNameForTrack(TextTrack? track);
+DOMString displayNameForTrack(AudioTrack? track);
 readonly attribute TextTrack captionMenuOffItem;
 readonly attribute TextTrack captionMenuAutomaticItem;
 readonly attribute DOMString captionDisplayMode;
-void setSelectedTextTrack(TextTrack track);
+void setSelectedTextTrack(TextTrack? track);
 readonly attribute HTMLElement textTrackContainer;
 readonly attribute boolean allowsInlineMediaPlayback;
 readonly attribute boolean supportsFullscreen;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199962] trunk/Source/WebCore

2016-04-24 Thread youenn . fablet 
Title: [199962] trunk/Source/WebCore








Revision 199962
Author youenn.fab...@crf.canon.fr
Date 2016-04-24 05:45:06 -0700 (Sun, 24 Apr 2016)


Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=156909

Reviewed by Chris Dumez.

No change of behavior.

Marking a lot of method parameters as nullable.

* html/canvas/WebGLRenderingContextBase.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (199961 => 199962)

--- trunk/Source/WebCore/ChangeLog	2016-04-24 12:37:43 UTC (rev 199961)
+++ trunk/Source/WebCore/ChangeLog	2016-04-24 12:45:06 UTC (rev 199962)
@@ -1,5 +1,18 @@
 2016-04-24  Youenn Fablet  
 
+Drop [UsePointersEvenForNonNullableObjectArguments] from WebGLRenderingContext
+https://bugs.webkit.org/show_bug.cgi?id=156909
+
+Reviewed by Chris Dumez.
+
+No change of behavior.
+
+Marking a lot of method parameters as nullable.
+
+* html/canvas/WebGLRenderingContextBase.idl:
+
+2016-04-24  Youenn Fablet  
+
 Drop [UsePointersEvenForNonNullableObjectArguments] from WebSocket
 https://bugs.webkit.org/show_bug.cgi?id=156897
 


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl (199961 => 199962)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl	2016-04-24 12:37:43 UTC (rev 199961)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl	2016-04-24 12:45:06 UTC (rev 199962)
@@ -39,11 +39,10 @@
 typedef unrestricted float GLclampf;
 
 [
-NoInterfaceObject,
 Conditional=WEBGL,
-JSCustomMarkFunction,
-UsePointersEvenForNonNullableObjectArguments,
 DoNotCheckConstants,
+JSCustomMarkFunction,
+NoInterfaceObject,
 ] interface WebGLRenderingContextBase : CanvasRenderingContext {
 
 /* ClearBufferMask */
@@ -469,12 +468,12 @@
 readonly attribute GLsizei drawingBufferHeight;
 
 [StrictTypeChecking, RaisesException] void activeTexture(GLenum texture);
-[StrictTypeChecking, RaisesException] void attachShader(WebGLProgram program, WebGLShader shader);
-[StrictTypeChecking, RaisesException] void bindAttribLocation(WebGLProgram program, GLuint index, DOMString name);
-[StrictTypeChecking, RaisesException] void bindBuffer(GLenum target, WebGLBuffer buffer);
-[StrictTypeChecking, RaisesException] void bindFramebuffer(GLenum target, WebGLFramebuffer framebuffer);
-[StrictTypeChecking, RaisesException] void bindRenderbuffer(GLenum target, WebGLRenderbuffer renderbuffer);
-[StrictTypeChecking, RaisesException] void bindTexture(GLenum target, WebGLTexture texture);
+[StrictTypeChecking, RaisesException] void attachShader(WebGLProgram? program, WebGLShader? shader);
+[StrictTypeChecking, RaisesException] void bindAttribLocation(WebGLProgram? program, GLuint index, DOMString name);
+[StrictTypeChecking, RaisesException] void bindBuffer(GLenum target, WebGLBuffer? buffer);
+[StrictTypeChecking, RaisesException] void bindFramebuffer(GLenum target, WebGLFramebuffer? framebuffer);
+[StrictTypeChecking, RaisesException] void bindRenderbuffer(GLenum target, WebGLRenderbuffer? renderbuffer);
+[StrictTypeChecking, RaisesException] void bindTexture(GLenum target, WebGLTexture? texture);
 [StrictTypeChecking] void blendColor(GLclampf red, GLclampf green, GLclampf blue, GLclampf alpha);
 [StrictTypeChecking] void blendEquation(GLenum mode);
 [StrictTypeChecking] void blendEquationSeparate(GLenum modeRGB, GLenum modeAlpha);
@@ -492,7 +491,7 @@
 [StrictTypeChecking] void clearDepth(GLclampf depth);
 [StrictTypeChecking] void clearStencil(GLint s);
 [StrictTypeChecking] void colorMask(GLboolean red, GLboolean green, GLboolean blue, GLboolean alpha);
-[StrictTypeChecking, RaisesException] void compileShader(WebGLShader shader);
+[StrictTypeChecking, RaisesException] void compileShader(WebGLShader? shader);
 
 [StrictTypeChecking] void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat,
GLsizei width, GLsizei height, GLint border, ArrayBufferView data);
@@ -511,17 +510,17 @@
 
 [StrictTypeChecking] void cullFace(GLenum mode);
 
-[StrictTypeChecking] void deleteBuffer(WebGLBuffer buffer);
-[StrictTypeChecking] void deleteFramebuffer(WebGLFramebuffer framebuffer);
-[StrictTypeChecking] void deleteProgram(WebGLProgram program);
-[StrictTypeChecking] void deleteRenderbuffer(WebGLRenderbuffer renderbuffer);
-[StrictTypeChecking] void deleteShader(WebGLShader shader);
-

[webkit-changes] [199961] trunk/Source/WebCore

2016-04-24 Thread youenn . fablet 
Title: [199961] trunk/Source/WebCore








Revision 199961
Author youenn.fab...@crf.canon.fr
Date 2016-04-24 05:37:43 -0700 (Sun, 24 Apr 2016)


Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from WebSocket
https://bugs.webkit.org/show_bug.cgi?id=156897

Reviewed by Chris Dumez.

No change of behavior.

Updating WebSocket::send methods to take references, except for ArrayBufferView, which is not yet supported by the binding generator.

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
* Modules/websockets/WebSocket.h:
* Modules/websockets/WebSocket.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/websockets/WebSocket.cpp
trunk/Source/WebCore/Modules/websockets/WebSocket.h
trunk/Source/WebCore/Modules/websockets/WebSocket.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (199960 => 199961)

--- trunk/Source/WebCore/ChangeLog	2016-04-24 02:49:49 UTC (rev 199960)
+++ trunk/Source/WebCore/ChangeLog	2016-04-24 12:37:43 UTC (rev 199961)
@@ -1,3 +1,19 @@
+2016-04-24  Youenn Fablet  
+
+Drop [UsePointersEvenForNonNullableObjectArguments] from WebSocket
+https://bugs.webkit.org/show_bug.cgi?id=156897
+
+Reviewed by Chris Dumez.
+
+No change of behavior.
+
+Updating WebSocket::send methods to take references, except for ArrayBufferView, which is not yet supported by the binding generator.
+
+* Modules/websockets/WebSocket.cpp:
+(WebCore::WebSocket::send):
+* Modules/websockets/WebSocket.h:
+* Modules/websockets/WebSocket.idl:
+
 2016-04-23  Andy Estes  
 
 Fix issues found by the clang static analyzer


Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.cpp (199960 => 199961)

--- trunk/Source/WebCore/Modules/websockets/WebSocket.cpp	2016-04-24 02:49:49 UTC (rev 199960)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.cpp	2016-04-24 12:37:43 UTC (rev 199961)
@@ -322,22 +322,21 @@
 }
 }
 
-void WebSocket::send(ArrayBuffer* binaryData, ExceptionCode& ec)
+void WebSocket::send(ArrayBuffer& binaryData, ExceptionCode& ec)
 {
-LOG(Network, "WebSocket %p send() Sending ArrayBuffer %p", this, binaryData);
-ASSERT(binaryData);
+LOG(Network, "WebSocket %p send() Sending ArrayBuffer %p", this, );
 if (m_state == CONNECTING) {
 ec = INVALID_STATE_ERR;
 return;
 }
 if (m_state == CLOSING || m_state == CLOSED) {
-unsigned payloadSize = binaryData->byteLength();
+unsigned payloadSize = binaryData.byteLength();
 m_bufferedAmountAfterClose = saturateAdd(m_bufferedAmountAfterClose, payloadSize);
 m_bufferedAmountAfterClose = saturateAdd(m_bufferedAmountAfterClose, getFramingOverhead(payloadSize));
 return;
 }
 ASSERT(m_channel);
-m_channel->send(*binaryData, 0, binaryData->byteLength());
+m_channel->send(binaryData, 0, binaryData.byteLength());
 }
 
 void WebSocket::send(ArrayBufferView* arrayBufferView, ExceptionCode& ec)
@@ -359,21 +358,21 @@
 m_channel->send(*arrayBuffer, arrayBufferView->byteOffset(), arrayBufferView->byteLength());
 }
 
-void WebSocket::send(Blob* binaryData, ExceptionCode& ec)
+void WebSocket::send(Blob& binaryData, ExceptionCode& ec)
 {
-LOG(Network, "WebSocket %p send() Sending Blob '%s'", this, binaryData->url().stringCenterEllipsizedToLength().utf8().data());
+LOG(Network, "WebSocket %p send() Sending Blob '%s'", this, binaryData.url().stringCenterEllipsizedToLength().utf8().data());
 if (m_state == CONNECTING) {
 ec = INVALID_STATE_ERR;
 return;
 }
 if (m_state == CLOSING || m_state == CLOSED) {
-unsigned long payloadSize = static_cast(binaryData->size());
+unsigned long payloadSize = static_cast(binaryData.size());
 m_bufferedAmountAfterClose = saturateAdd(m_bufferedAmountAfterClose, payloadSize);
 m_bufferedAmountAfterClose = saturateAdd(m_bufferedAmountAfterClose, getFramingOverhead(payloadSize));
 return;
 }
 ASSERT(m_channel);
-m_channel->send(*binaryData);
+m_channel->send(binaryData);
 }
 
 void WebSocket::close(int code, const String& reason, ExceptionCode& ec)


Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.h (199960 => 199961)

--- trunk/Source/WebCore/Modules/websockets/WebSocket.h	2016-04-24 02:49:49 UTC (rev 199960)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.h	2016-04-24 12:37:43 UTC (rev 199961)
@@ -72,9 +72,9 @@
 void connect(const String& url, const Vector& protocols, ExceptionCode&);
 
 void send(const String& message, ExceptionCode&);
-void send(JSC::ArrayBuffer*, ExceptionCode&);
+void send(JSC::ArrayBuffer&, ExceptionCode&);
 void send(JSC::ArrayBufferView*, ExceptionCode&);
-void send(Blob*, ExceptionCode&);
+void send(Blob&, ExceptionCode&);
 
 void close(int code, const String& reason, ExceptionCode&);
 void