[webkit-changes] [205005] tags/Safari-601.7.7.1/

[bshafiei]

Title: [205005] tags/Safari-601.7.7.1/








Revision 205005
Author bshaf...@apple.com
Date 2016-08-26 00:32:43 -0700 (Fri, 26 Aug 2016)


Log Message
New tag.

Added Paths

tags/Safari-601.7.7.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205006] tags/Safari-601.7.7.1/Source

[bshafiei]

Title: [205006] tags/Safari-601.7.7.1/Source








Revision 205006
Author bshaf...@apple.com
Date 2016-08-26 00:34:55 -0700 (Fri, 26 Aug 2016)


Log Message
Versioning.

Modified Paths

tags/Safari-601.7.7.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-601.7.7.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-601.7.7.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-601.7.7.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-601.7.7.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-601.7.7.1/Source/_javascript_Core/Configurations/Version.xcconfig (205005 => 205006)

--- tags/Safari-601.7.7.1/Source/_javascript_Core/Configurations/Version.xcconfig	2016-08-26 07:32:43 UTC (rev 205005)
+++ tags/Safari-601.7.7.1/Source/_javascript_Core/Configurations/Version.xcconfig	2016-08-26 07:34:55 UTC (rev 205006)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 7;
 TINY_VERSION = 7;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-601.7.7.1/Source/WebCore/Configurations/Version.xcconfig (205005 => 205006)

--- tags/Safari-601.7.7.1/Source/WebCore/Configurations/Version.xcconfig	2016-08-26 07:32:43 UTC (rev 205005)
+++ tags/Safari-601.7.7.1/Source/WebCore/Configurations/Version.xcconfig	2016-08-26 07:34:55 UTC (rev 205006)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 7;
 TINY_VERSION = 7;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-601.7.7.1/Source/WebInspectorUI/Configurations/Version.xcconfig (205005 => 205006)

--- tags/Safari-601.7.7.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-08-26 07:32:43 UTC (rev 205005)
+++ tags/Safari-601.7.7.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-08-26 07:34:55 UTC (rev 205006)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 7;
 TINY_VERSION = 7;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-601.7.7.1/Source/WebKit/mac/Configurations/Version.xcconfig (205005 => 205006)

--- tags/Safari-601.7.7.1/Source/WebKit/mac/Configurations/Version.xcconfig	2016-08-26 07:32:43 UTC (rev 205005)
+++ tags/Safari-601.7.7.1/Source/WebKit/mac/Configurations/Version.xcconfig	2016-08-26 07:34:55 UTC (rev 205006)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 7;
 TINY_VERSION = 7;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-601.7.7.1/Source/WebKit2/Configurations/Version.xcconfig (205005 => 205006)

--- tags/Safari-601.7.7.1/Source/WebKit2/Configurations/Version.xcconfig	2016-08-26 07:32:43 UTC (rev 205005)
+++ tags/Safari-601.7.7.1/Source/WebKit2/Configurations/Version.xcconfig	2016-08-26 07:34:55 UTC (rev 205006)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 7;
 TINY_VERSION = 7;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205007] trunk/Tools

[gyuyoung . kim]

Title: [205007] trunk/Tools








Revision 205007
Author gyuyoung@webkit.org
Date 2016-08-26 00:36:01 -0700 (Fri, 26 Aug 2016)


Log Message
[EFL] Change homepage url to www.ewebkit.org on MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=161184

Reviewed by Carlos Garcia Campos.

* MiniBrowser/efl/main.c: Set www.ewebkit.org.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/efl/main.c




Diff

Modified: trunk/Tools/ChangeLog (205006 => 205007)

--- trunk/Tools/ChangeLog	2016-08-26 07:34:55 UTC (rev 205006)
+++ trunk/Tools/ChangeLog	2016-08-26 07:36:01 UTC (rev 205007)
@@ -1,3 +1,12 @@
+2016-08-26  Gyuyoung Kim  
+
+[EFL] Change homepage url to www.ewebkit.org on MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=161184
+
+Reviewed by Carlos Garcia Campos.
+
+* MiniBrowser/efl/main.c: Set www.ewebkit.org.
+
 2016-08-25  Aakash Jain  
 
 ews queues should update status server when they start processing patch


Modified: trunk/Tools/MiniBrowser/efl/main.c (205006 => 205007)

--- trunk/Tools/MiniBrowser/efl/main.c	2016-08-26 07:34:55 UTC (rev 205006)
+++ trunk/Tools/MiniBrowser/efl/main.c	2016-08-26 07:36:01 UTC (rev 205007)
@@ -28,7 +28,7 @@
 
 extern int efreet_cache_update;
 
-static const char DEFAULT_URL[] = "http://www.google.com/";
+static const char DEFAULT_URL[] = "http://www.ewebkit.org/";
 static const char APP_NAME[] = "EFL MiniBrowser";
 static const int TOOL_BAR_ICON_SIZE = 24;
 static const int TOOL_BAR_BUTTON_SIZE = 32;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205008] trunk

[nael . ouedraogo]

Title: [205008] trunk








Revision 205008
Author nael.ouedra...@crf.canon.fr
Date 2016-08-26 01:04:02 -0700 (Fri, 26 Aug 2016)


Log Message
Make custom constructors consistent with generated bindings code
https://bugs.webkit.org/show_bug.cgi?id=159550

Reviewed by Youenn Fablet.

Add assertion to check DOMConstructorObject* passed in ExecState is not null.
Rename throwConstructorDocumentUnavailableError to throwConstructorScriptExecutionContextUnavailableError since
ScriptExecutionContext is not necessarily a Document.
Modify error message in case of argument error to be consistent with generated binding code: replace calls to
throwVMError with calls to throwConstructorScriptExecutionContextUnavailableError and throwArgumentTypeError.

No new test required. Modify tests and tests expectations to align with new error messages.

Source/WebCore:

* bindings/js/JSAudioContextCustom.cpp:
(WebCore::constructJSAudioContext):
* bindings/js/JSBlobCustom.cpp:
(WebCore::constructJSBlob):
* bindings/js/JSDOMBinding.cpp:
(WebCore::throwConstructorScriptExecutionContextUnavailableError):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMConstructor.h:
(WebCore::JSBuiltinConstructor::callConstructor):
* bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::constructJSDOMFormData):
* bindings/js/JSDataCueCustom.cpp:
(WebCore::constructJSDataCue):
* bindings/js/JSFileCustom.cpp:
(WebCore::constructJSFile):
* bindings/js/JSHTMLElementCustom.cpp:
(WebCore::constructJSHTMLElement):
* bindings/js/JSMediaSessionCustom.cpp:
(WebCore::constructJSMediaSession):
* bindings/js/JSMutationObserverCustom.cpp:
(WebCore::constructJSMutationObserver):
* bindings/js/JSReadableStreamPrivateConstructors.cpp:
(WebCore::constructJSReadableStreamDefaultReader):
* bindings/js/JSWorkerCustom.cpp:
(WebCore::constructJSWorker):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
(NativeToJSValue):
(GenerateHashTableValueArray):
(GenerateConstructorDefinition):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::construct):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::construct):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::construct):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::construct):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):
* bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
(WebCore::constructJSTestOverloadedConstructorsWithSequence1):
(WebCore::constructJSTestOverloadedConstructorsWithSequence2):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):

LayoutTests:

* fast/dom/MutationObserver/mutation-observer-constructor-expected.txt:
* fast/files/file-constructor-expected.txt:
* fast/files/file-constructor.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-constructor-expected.txt
trunk/LayoutTests/fast/files/file-constructor-expected.txt
trunk/LayoutTests/fast/files/file-constructor.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSAudioContextCustom.cpp
trunk/Source/WebCore/bindings/js/JSBlobCustom.cpp
trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/bindings/js/JSDOMConstructor.h
trunk/Source/WebCore/bindings/js/JSDOMFormDataCustom.cpp
trunk/Source/WebCore/bindings/js/JSDataCueCustom.cpp
trunk/Source/WebCore/bindings/js/JSFileCustom.cpp
trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp
trunk/Source/WebCore/bindings/js/JSMediaSessionCustom.cpp
trunk/Source/WebCore/bindings/js/JSMutationObserverCustom.cpp
trunk/Source/WebCore/bindings/js/JSReadableStreamPrivateConstructors.cpp
trunk/Source/WebCore/bindings/js/JSWorkerCustom.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (205007 => 205008)

--- trunk/LayoutTests/ChangeLog	2016-08-26 07:36:01 UTC (rev 205

[webkit-changes] [205009] trunk/Source/WebKit2

[gyuyoung . kim]

Title: [205009] trunk/Source/WebKit2








Revision 205009
Author gyuyoung@webkit.org
Date 2016-08-26 01:46:02 -0700 (Fri, 26 Aug 2016)


Log Message
Unreviewed EFL build fix since r204996.

Patch by Gyuyoung Kim  on 2016-08-26

* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::setThemePath):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::cancelComposition):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (205008 => 205009)

--- trunk/Source/WebKit2/ChangeLog	2016-08-26 08:04:02 UTC (rev 205008)
+++ trunk/Source/WebKit2/ChangeLog	2016-08-26 08:46:02 UTC (rev 205009)
@@ -1,3 +1,14 @@
+2016-08-26  Gyuyoung Kim  
+
+Unreviewed EFL build fix since r204996.
+
+* UIProcess/efl/WebPageProxyEfl.cpp:
+(WebKit::WebPageProxy::editorStateChanged):
+(WebKit::WebPageProxy::setThemePath):
+(WebKit::WebPageProxy::confirmComposition):
+(WebKit::WebPageProxy::setComposition):
+(WebKit::WebPageProxy::cancelComposition):
+
 2016-08-25  Carlos Garcia Campos  
 
 Unreviewed. Fix GTK+ build after r204986 and r204996.


Modified: trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp (205008 => 205009)

--- trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp	2016-08-26 08:04:02 UTC (rev 205008)
+++ trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp	2016-08-26 08:46:02 UTC (rev 205009)
@@ -69,7 +69,7 @@
 void WebPageProxy::editorStateChanged(const EditorState& editorState)
 {
 m_editorState = editorState;
-
+
 if (editorState.shouldIgnoreCompositionSelectionChange)
 return;
 m_pageClient.updateTextInputState();
@@ -80,7 +80,7 @@
 if (!isValid())
 return;
 
-process().send(Messages::WebPage::SetThemePath(themePath), m_pageID, 0);
+process().send(Messages::WebPage::SetThemePath(themePath), m_pageID);
 }
 
 void WebPageProxy::createPluginContainer(uint64_t&)
@@ -108,7 +108,7 @@
 if (!isValid())
 return;
 
-process().send(Messages::WebPage::ConfirmComposition(compositionString), m_pageID, 0);
+process().send(Messages::WebPage::ConfirmComposition(compositionString), m_pageID);
 }
 
 void WebPageProxy::setComposition(const String& compositionString, Vector& underlines, int cursorPosition)
@@ -116,7 +116,7 @@
 if (!isValid())
 return;
 
-process().send(Messages::WebPage::SetComposition(compositionString, underlines, cursorPosition), m_pageID, 0);
+process().send(Messages::WebPage::SetComposition(compositionString, underlines, cursorPosition), m_pageID);
 }
 
 void WebPageProxy::cancelComposition()
@@ -124,7 +124,7 @@
 if (!isValid())
 return;
 
-process().send(Messages::WebPage::CancelComposition(), m_pageID, 0);
+process().send(Messages::WebPage::CancelComposition(), m_pageID);
 }
 
 #if HAVE(ACCESSIBILITY) && defined(HAVE_ECORE_X)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205010] trunk/Tools

[aakash_jain]

Title: [205010] trunk/Tools








Revision 205010
Author aakash_j...@apple.com
Date 2016-08-26 03:54:51 -0700 (Fri, 26 Aug 2016)


Log Message
EWS should indicate which bot processed the patch
https://bugs.webkit.org/show_bug.cgi?id=161222

Reviewed by Daniel Bates.

* QueueStatusServer/handlers/statusbubble.py:
(StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
Also added "Started processing patch" message to progress_statuses.
I might consider displaying bot id in other statuses as well later on.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/handlers/statusbubble.py




Diff

Modified: trunk/Tools/ChangeLog (205009 => 205010)

--- trunk/Tools/ChangeLog	2016-08-26 08:46:02 UTC (rev 205009)
+++ trunk/Tools/ChangeLog	2016-08-26 10:54:51 UTC (rev 205010)
@@ -1,3 +1,16 @@
+2016-08-26  Aakash Jain  
+
+EWS should indicate which bot processed the patch
+https://bugs.webkit.org/show_bug.cgi?id=161222
+
+Reviewed by Daniel Bates.
+
+* QueueStatusServer/handlers/statusbubble.py:
+(StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
+after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
+Also added "Started processing patch" message to progress_statuses.
+I might consider displaying bot id in other statuses as well later on.
+
 2016-08-26  Gyuyoung Kim  
 
 [EFL] Change homepage url to www.ewebkit.org on MiniBrowser


Modified: trunk/Tools/QueueStatusServer/handlers/statusbubble.py (205009 => 205010)

--- trunk/Tools/QueueStatusServer/handlers/statusbubble.py	2016-08-26 08:46:02 UTC (rev 205009)
+++ trunk/Tools/QueueStatusServer/handlers/statusbubble.py	2016-08-26 10:54:51 UTC (rev 205010)
@@ -40,6 +40,7 @@
 from sets import Set
 
 progress_statuses = Set([
+"Started processing patch",
 "Cleaned working directory",
 "Updated working directory",
 "Applied patch",
@@ -131,7 +132,7 @@
 statuses))
 if not latest_resultative_status:
 bubble["state"] = "started"
-bubble["details_message"] = ("Started processing.\n\nRecent messages:\n\n"
+bubble["details_message"] = (statuses[0].bot_id + ", recent messages:\n\n"
 + "\n".join([status.message for status in statuses]) + "\n\n" + self._iso_time(statuses[0].date))
 elif statuses[0].message == "Pass":
 bubble["state"] = "pass"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205011] trunk/Source/WebCore

[pvollan]

Title: [205011] trunk/Source/WebCore








Revision 205011
Author pvol...@apple.com
Date 2016-08-26 06:29:31 -0700 (Fri, 26 Aug 2016)


Log Message
[Win] Warning fixes.
https://bugs.webkit.org/show_bug.cgi?id=161077

Reviewed by Brent Fulgham.

* css/CSSGrammar.y.includes:
* css/RuleFeature.cpp:
(WebCore::makeAttributeSelectorKey):
* editing/TextIterator.cpp:
(WebCore::SearchBuffer::SearchBuffer):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::textToFragment):
* html/MediaElementSession.h:
* platform/URL.cpp:
* platform/graphics/ca/GraphicsLayerCA.cpp:
* platform/network/HTTPParsers.cpp:
(WebCore::parseHTTPHeader):
* rendering/InlineIterator.h:
(WebCore::InlineIterator::clear):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::FlexBoxIterator::reset):
* rendering/RenderText.cpp:
(WebCore::RenderText::secureText):
* rendering/mathml/RenderMathMLToken.cpp:
(WebCore::mathVariant):
* style/InlineTextBoxStyle.cpp:
(WebCore::visualOverflowForDecorations):
* xml/XPathGrammar.y:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.includes
trunk/Source/WebCore/css/RuleFeature.cpp
trunk/Source/WebCore/editing/TextIterator.cpp
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/html/MediaElementSession.h
trunk/Source/WebCore/platform/URL.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/network/HTTPParsers.cpp
trunk/Source/WebCore/rendering/InlineIterator.h
trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderText.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.cpp
trunk/Source/WebCore/style/InlineTextBoxStyle.cpp
trunk/Source/WebCore/xml/XPathGrammar.y




Diff

Modified: trunk/Source/WebCore/ChangeLog (205010 => 205011)

--- trunk/Source/WebCore/ChangeLog	2016-08-26 10:54:51 UTC (rev 205010)
+++ trunk/Source/WebCore/ChangeLog	2016-08-26 13:29:31 UTC (rev 205011)
@@ -1,3 +1,34 @@
+2016-08-26  Per Arne Vollan  
+
+[Win] Warning fixes.
+https://bugs.webkit.org/show_bug.cgi?id=161077
+
+Reviewed by Brent Fulgham.
+
+* css/CSSGrammar.y.includes:
+* css/RuleFeature.cpp:
+(WebCore::makeAttributeSelectorKey):
+* editing/TextIterator.cpp:
+(WebCore::SearchBuffer::SearchBuffer):
+* html/HTMLElement.cpp:
+(WebCore::HTMLElement::textToFragment):
+* html/MediaElementSession.h:
+* platform/URL.cpp:
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+* platform/network/HTTPParsers.cpp:
+(WebCore::parseHTTPHeader):
+* rendering/InlineIterator.h:
+(WebCore::InlineIterator::clear):
+* rendering/RenderDeprecatedFlexibleBox.cpp:
+(WebCore::FlexBoxIterator::reset):
+* rendering/RenderText.cpp:
+(WebCore::RenderText::secureText):
+* rendering/mathml/RenderMathMLToken.cpp:
+(WebCore::mathVariant):
+* style/InlineTextBoxStyle.cpp:
+(WebCore::visualOverflowForDecorations):
+* xml/XPathGrammar.y:
+
 2016-08-26  Nael Ouedraogo  
 
 Make custom constructors consistent with generated bindings code


Modified: trunk/Source/WebCore/css/CSSGrammar.y.includes (205010 => 205011)

--- trunk/Source/WebCore/css/CSSGrammar.y.includes	2016-08-26 10:54:51 UTC (rev 205010)
+++ trunk/Source/WebCore/css/CSSGrammar.y.includes	2016-08-26 13:29:31 UTC (rev 205011)
@@ -45,6 +45,11 @@
 using namespace WebCore;
 using namespace HTMLNames;
 
+#if COMPILER(MSVC)
+// See https://msdn.microsoft.com/en-us/library/1wea5zwe.aspx
+#pragma warning(disable: 4701)
+#endif
+
 #define YYMALLOC fastMalloc
 #define YYFREE fastFree
 


Modified: trunk/Source/WebCore/css/RuleFeature.cpp (205010 => 205011)

--- trunk/Source/WebCore/css/RuleFeature.cpp	2016-08-26 10:54:51 UTC (rev 205010)
+++ trunk/Source/WebCore/css/RuleFeature.cpp	2016-08-26 13:29:31 UTC (rev 205011)
@@ -87,7 +87,7 @@
 static RuleFeatureSet::AttributeRules::SelectorKey makeAttributeSelectorKey(const CSSSelector& selector)
 {
 bool caseInsensitive = selector.attributeValueMatchingIsCaseInsensitive();
-unsigned matchAndCase = static_cast(selector.match()) << 1 | caseInsensitive;
+unsigned matchAndCase = static_cast(selector.match()) << 1 | (caseInsensitive ? 1 : 0);
 return std::make_pair(selector.attributeCanonicalLocalName().impl(), std::make_pair(selector.value().impl(), matchAndCase));
 }
 


Modified: trunk/Source/WebCore/editing/TextIterator.cpp (205010 => 205011)

--- trunk/Source/WebCore/editing/TextIterator.cpp	2016-08-26 10:54:51 UTC (rev 205010)
+++ trunk/Source/WebCore/editing/TextIterator.cpp	2016-08-26 13:29:31 UTC (rev 205011)
@@ -2004,7 +2004,7 @@
 
 if ((m_options & AtWordStarts) && targetLength) {
 UChar32 targetFirstCharacter;
-U16_GET(m_target, 0, 0, targetLength, targetFirstCharacter);
+U16_GET(m_target, 0, 0u, targetLength, targetFirstCharacter);
 // Characters in the separator cate

[webkit-changes] [205012] trunk

[ossy]

Title: [205012] trunk








Revision 205012
Author o...@webkit.org
Date 2016-08-26 07:04:42 -0700 (Fri, 26 Aug 2016)


Log Message
[EFL][GTK] REGRESSION(204877): Fix the clean build
https://bugs.webkit.org/show_bug.cgi?id=161240

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

* Scripts/generate-forwarding-headers.pl: Added back multiple include-path support. (removed by r183389)

Tools:

* WebKitTestRunner/PlatformEfl.cmake:
* WebKitTestRunner/PlatformGTK.cmake:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/PlatformEfl.cmake
trunk/Tools/WebKitTestRunner/PlatformGTK.cmake




Diff

Modified: trunk/Source/WebKit2/ChangeLog (205011 => 205012)

--- trunk/Source/WebKit2/ChangeLog	2016-08-26 13:29:31 UTC (rev 205011)
+++ trunk/Source/WebKit2/ChangeLog	2016-08-26 14:04:42 UTC (rev 205012)
@@ -1,3 +1,12 @@
+2016-08-26  Csaba Osztrogonác  
+
+[EFL][GTK] REGRESSION(204877): Fix the clean build
+https://bugs.webkit.org/show_bug.cgi?id=161240
+
+Reviewed by Carlos Garcia Campos.
+
+* Scripts/generate-forwarding-headers.pl: Added back multiple include-path support. (removed by r183389)
+
 2016-08-26  Gyuyoung Kim  
 
 Unreviewed EFL build fix since r204996.


Modified: trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl (205011 => 205012)

--- trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl	2016-08-26 13:29:31 UTC (rev 205011)
+++ trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl	2016-08-26 14:04:42 UTC (rev 205012)
@@ -44,12 +44,12 @@
 my %neededHeaders;
 my $verbose = 0; # enable it for debugging purpose
 
-my $incFromRoot;
+my @incFromRoot;
 my $outputDirectory;
 my @platform;
 
 my %options = (
-'include-path=s' => \$incFromRoot,
+'include-path=s' => \@incFromRoot,
 'output=s' => \$outputDirectory,
 'platform=s' => \@platform
 );
@@ -66,7 +66,7 @@
 @frameworkHeaders = ();
 %neededHeaders = ();
 
-find(\&collectNeededHeaders, abs_path($incFromRoot) );
+foreach (@incFromRoot) { find(\&collectNeededHeaders, abs_path($_) ); };
 find(\&collectFrameworkHeaderPaths, File::Spec->catfile($srcRoot, $frameworkDirectoryName));
 createForwardingHeadersForFramework();
 }


Modified: trunk/Tools/ChangeLog (205011 => 205012)

--- trunk/Tools/ChangeLog	2016-08-26 13:29:31 UTC (rev 205011)
+++ trunk/Tools/ChangeLog	2016-08-26 14:04:42 UTC (rev 205012)
@@ -1,3 +1,13 @@
+2016-08-26  Csaba Osztrogonác  
+
+[EFL][GTK] REGRESSION(204877): Fix the clean build
+https://bugs.webkit.org/show_bug.cgi?id=161240
+
+Reviewed by Carlos Garcia Campos.
+
+* WebKitTestRunner/PlatformEfl.cmake:
+* WebKitTestRunner/PlatformGTK.cmake:
+
 2016-08-26  Aakash Jain  
 
 EWS should indicate which bot processed the patch


Modified: trunk/Tools/WebKitTestRunner/PlatformEfl.cmake (205011 => 205012)

--- trunk/Tools/WebKitTestRunner/PlatformEfl.cmake	2016-08-26 13:29:31 UTC (rev 205011)
+++ trunk/Tools/WebKitTestRunner/PlatformEfl.cmake	2016-08-26 14:04:42 UTC (rev 205012)
@@ -1,5 +1,5 @@
 add_custom_target(forwarding-headersEflForWebKitTestRunner
-COMMAND ${PERL_EXECUTABLE} ${WEBKIT2_DIR}/Scripts/generate-forwarding-headers.pl --include-path ${WEBKIT_TESTRUNNER_DIR} --output ${DERIVED_SOURCES_WEBKIT2_DIR}/include --platform efl --platform soup
+COMMAND ${PERL_EXECUTABLE} ${WEBKIT2_DIR}/Scripts/generate-forwarding-headers.pl --include-path ${WEBKIT_TESTRUNNER_DIR} --include-path ${WEBKIT_TESTRUNNER_SHARED_DIR} --output ${DERIVED_SOURCES_WEBKIT2_DIR}/include --platform efl --platform soup
 )
 set(ForwardingHeadersForWebKitTestRunner_NAME forwarding-headersEflForWebKitTestRunner)
 


Modified: trunk/Tools/WebKitTestRunner/PlatformGTK.cmake (205011 => 205012)

--- trunk/Tools/WebKitTestRunner/PlatformGTK.cmake	2016-08-26 13:29:31 UTC (rev 205011)
+++ trunk/Tools/WebKitTestRunner/PlatformGTK.cmake	2016-08-26 14:04:42 UTC (rev 205012)
@@ -1,5 +1,5 @@
 add_custom_target(WebKitTestRunner-forwarding-headers
-COMMAND ${PERL_EXECUTABLE} ${WEBKIT2_DIR}/Scripts/generate-forwarding-headers.pl --include-path ${WEBKIT_TESTRUNNER_DIR} --output ${FORWARDING_HEADERS_DIR} --platform gtk --platform soup
+COMMAND ${PERL_EXECUTABLE} ${WEBKIT2_DIR}/Scripts/generate-forwarding-headers.pl --include-path ${WEBKIT_TESTRUNNER_DIR} --include-path ${WEBKIT_TESTRUNNER_SHARED_DIR} --output ${FORWARDING_HEADERS_DIR} --platform gtk --platform soup
 )
 
 set(ForwardingHeadersForWebKitTestRunner_NAME WebKitTestRunner-forwarding-headers)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205013] trunk/LayoutTests

[ap]

Title: [205013] trunk/LayoutTests








Revision 205013
Author a...@apple.com
Date 2016-08-26 09:04:23 -0700 (Fri, 26 Aug 2016)


Log Message
Reinstate flakiness expectations for viewport tests, as they are still flaky.
https://bugs.webkit.org/show_bug.cgi?id=153110

* platform/ios-simulator-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (205012 => 205013)

--- trunk/LayoutTests/ChangeLog	2016-08-26 14:04:42 UTC (rev 205012)
+++ trunk/LayoutTests/ChangeLog	2016-08-26 16:04:23 UTC (rev 205013)
@@ -1,3 +1,10 @@
+2016-08-26  Alexey Proskuryakov  
+
+Reinstate flakiness expectations for viewport tests, as they are still flaky.
+https://bugs.webkit.org/show_bug.cgi?id=153110
+
+* platform/ios-simulator-wk2/TestExpectations:
+
 2016-08-26  Nael Ouedraogo  
 
 Make custom constructors consistent with generated bindings code


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (205012 => 205013)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2016-08-26 14:04:42 UTC (rev 205012)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2016-08-26 16:04:23 UTC (rev 205013)
@@ -1767,6 +1767,10 @@
 # Forcing always allow user scalable is not supported on certain OS version.
 webkit.org/b/155056 fast/viewport/ios/force-always-user-scalable.html [ Skip ]
 
+webkit.org/b/153110 fast/viewport/ios/width-is-device-width-overflowing.html [ Pass Failure ]
+webkit.org/b/153110 fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden.html [ Pass Failure ]
+webkit.org/b/153110 fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall.html [ Pass Failure ]
+
 webkit.org/b/155501 animations/3d/transform-origin-vs-functions.html [ Pass Failure ]
 
 webkit.org/b/155495 compositing/visible-rect/animated-from-none.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205014] trunk/Tools

[clopez]

Title: [205014] trunk/Tools








Revision 205014
Author clo...@igalia.com
Date 2016-08-26 09:32:32 -0700 (Fri, 26 Aug 2016)


Log Message
[GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
https://bugs.webkit.org/show_bug.cgi?id=160736

Reviewed by Carlos Garcia Campos.

This plugs run-gtk-tests into the webkitpy testing infrastructure.
As a benefit of this, run-gtk-tests now can be executed over any of
the existing supported gtk test display servers (xvfb, weston-over-xvfb,
or native xorg). A new command line switch --wayland is added for
run-gtk-tests.

* Scripts/run-gtk-tests:
(TestRunner.__init__): Remove the --display command line switch, its not longer useful.
Add a --wayland command line switch.
(TestRunner._start_accessibility_daemons):
(TestRunner):
(TestRunner.__init__):
(TestRunner._run_xvfb): Deleted.
(TestRunner._create_driver):
(TestRunner._setup_testing_environment): Delete the environment variable definitions that
are now done by driver._setup_environ_for_test().
(TestRunner._tear_down_testing_environment):
* Scripts/webkitpy/port/driver.py:
(Driver.__init__): Define self._server_name in the constructor of the base class.
It is used by several functions, so it makes sense to store once the value here.
(Driver._setup_environ_for_test): Factorize setting the environment for a given test.
(Driver._start): Get the environment from self._setup_environ_for_test()
* Scripts/webkitpy/port/driver_unittest.py:
(DriverTest):
(DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
* Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
(GtkPort.__init__):
(GtkPort._driver_class):
* Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
(WestonDriver._setup_environ_for_test):
(WestonDriver._start):
* Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
(XorgDriver._setup_environ_for_test):
(XorgDriver._start):
* Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
(XvfbDriver._setup_environ_for_test):
(XvfbDriver._start):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests
trunk/Tools/Scripts/webkitpy/port/driver.py
trunk/Tools/Scripts/webkitpy/port/driver_unittest.py
trunk/Tools/Scripts/webkitpy/port/gtk.py
trunk/Tools/Scripts/webkitpy/port/westondriver.py
trunk/Tools/Scripts/webkitpy/port/xorgdriver.py
trunk/Tools/Scripts/webkitpy/port/xvfbdriver.py




Diff

Modified: trunk/Tools/ChangeLog (205013 => 205014)

--- trunk/Tools/ChangeLog	2016-08-26 16:04:23 UTC (rev 205013)
+++ trunk/Tools/ChangeLog	2016-08-26 16:32:32 UTC (rev 205014)
@@ -1,3 +1,48 @@
+2016-08-26  Carlos Alberto Lopez Perez  
+
+[GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
+https://bugs.webkit.org/show_bug.cgi?id=160736
+
+Reviewed by Carlos Garcia Campos.
+
+This plugs run-gtk-tests into the webkitpy testing infrastructure.
+As a benefit of this, run-gtk-tests now can be executed over any of
+the existing supported gtk test display servers (xvfb, weston-over-xvfb,
+or native xorg). A new command line switch --wayland is added for
+run-gtk-tests.
+
+* Scripts/run-gtk-tests:
+(TestRunner.__init__): Remove the --display command line switch, its not longer useful.
+Add a --wayland command line switch.
+(TestRunner._start_accessibility_daemons):
+(TestRunner):
+(TestRunner.__init__):
+(TestRunner._run_xvfb): Deleted.
+(TestRunner._create_driver):
+(TestRunner._setup_testing_environment): Delete the environment variable definitions that
+are now done by driver._setup_environ_for_test().
+(TestRunner._tear_down_testing_environment):
+* Scripts/webkitpy/port/driver.py:
+(Driver.__init__): Define self._server_name in the constructor of the base class.
+It is used by several functions, so it makes sense to store once the value here.
+(Driver._setup_environ_for_test): Factorize setting the environment for a given test.
+(Driver._start): Get the environment from self._setup_environ_for_test()
+* Scripts/webkitpy/port/driver_unittest.py:
+(DriverTest):
+(DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
+* Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
+(GtkPort.__init__):
+(GtkPort._driver_class):
+* Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
+(WestonDriver._setup_environ_for_test):
+(WestonDriver._start):
+* Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
+(XorgDriver._setup_environ_for_test):
+(XorgDriver._start):
+* Scripts/

[webkit-changes] [205015] trunk/Source/WebCore

[ossy]

Title: [205015] trunk/Source/WebCore








Revision 205015
Author o...@webkit.org
Date 2016-08-26 09:33:03 -0700 (Fri, 26 Aug 2016)


Log Message
Typo fix after r56209
https://bugs.webkit.org/show_bug.cgi?id=161246

Reviewed by Gyuyoung Kim.

* page/FrameView.cpp:
(WebCore::FrameView::adjustMediaTypeForPrinting):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (205014 => 205015)

--- trunk/Source/WebCore/ChangeLog	2016-08-26 16:32:32 UTC (rev 205014)
+++ trunk/Source/WebCore/ChangeLog	2016-08-26 16:33:03 UTC (rev 205015)
@@ -1,3 +1,13 @@
+2016-08-26  Csaba Osztrogonác  
+
+Typo fix after r56209
+https://bugs.webkit.org/show_bug.cgi?id=161246
+
+Reviewed by Gyuyoung Kim.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::adjustMediaTypeForPrinting):
+
 2016-08-26  Per Arne Vollan  
 
 [Win] Warning fixes.


Modified: trunk/Source/WebCore/page/FrameView.cpp (205014 => 205015)

--- trunk/Source/WebCore/page/FrameView.cpp	2016-08-26 16:32:32 UTC (rev 205014)
+++ trunk/Source/WebCore/page/FrameView.cpp	2016-08-26 16:33:03 UTC (rev 205015)
@@ -1605,7 +1605,7 @@
 if (printing) {
 if (m_mediaTypeWhenNotPrinting.isNull())
 m_mediaTypeWhenNotPrinting = mediaType();
-setMediaType("print");
+setMediaType("print");
 } else {
 if (!m_mediaTypeWhenNotPrinting.isNull())
 setMediaType(m_mediaTypeWhenNotPrinting);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205016] trunk/Tools

[pvollan]

Title: [205016] trunk/Tools








Revision 205016
Author pvol...@apple.com
Date 2016-08-26 09:35:26 -0700 (Fri, 26 Aug 2016)


Log Message
[Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=161236

Reviewed by Brent Fulgham.

The & operator in the Test struct has no body.

* TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp




Diff

Modified: trunk/Tools/ChangeLog (205015 => 205016)

--- trunk/Tools/ChangeLog	2016-08-26 16:33:03 UTC (rev 205015)
+++ trunk/Tools/ChangeLog	2016-08-26 16:35:26 UTC (rev 205016)
@@ -1,3 +1,15 @@
+2016-08-26  Per Arne Vollan  
+
+[Win] Warning fix.
+https://bugs.webkit.org/show_bug.cgi?id=161236
+
+Reviewed by Brent Fulgham.
+
+The & operator in the Test struct has no body.
+
+* TestWebKitAPI/Tests/WTF/Vector.cpp:
+(TestWebKitAPI::TEST):
+
 2016-08-26  Carlos Alberto Lopez Perez  
 
 [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp (205015 => 205016)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp	2016-08-26 16:33:03 UTC (rev 205015)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp	2016-08-26 16:35:26 UTC (rev 205016)
@@ -67,7 +67,7 @@
 {
 struct Test {
 private:
-Test* operator&();
+Test* operator&() = delete;
 };
 
 Vector vector;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205017] trunk/Tools

[clopez]

Title: [205017] trunk/Tools








Revision 205017
Author clo...@igalia.com
Date 2016-08-26 09:36:29 -0700 (Fri, 26 Aug 2016)


Log Message
[GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
https://bugs.webkit.org/show_bug.cgi?id=161149

Reviewed by Carlos Garcia Campos.

Add a new function for waiting for the accesibility bus. It sets
the test environment variables before starting the GLib mainloop.
And restores the previous environment after it has finished.
It also adds a timeout (5 seconds) to abort in case it has not
been able to detect the accesibility bus before the timeout expires.

* Scripts/run-gtk-tests:
(TestRunner):
(TestRunner._wait_for_accessibility_bus):
(TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
(TestRunner._start_accessibility_daemons):
(TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests




Diff

Modified: trunk/Tools/ChangeLog (205016 => 205017)

--- trunk/Tools/ChangeLog	2016-08-26 16:35:26 UTC (rev 205016)
+++ trunk/Tools/ChangeLog	2016-08-26 16:36:29 UTC (rev 205017)
@@ -1,3 +1,23 @@
+2016-08-26  Carlos Alberto Lopez Perez  
+
+[GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
+https://bugs.webkit.org/show_bug.cgi?id=161149
+
+Reviewed by Carlos Garcia Campos.
+
+Add a new function for waiting for the accesibility bus. It sets
+the test environment variables before starting the GLib mainloop.
+And restores the previous environment after it has finished.
+It also adds a timeout (5 seconds) to abort in case it has not
+been able to detect the accesibility bus before the timeout expires.
+
+* Scripts/run-gtk-tests:
+(TestRunner):
+(TestRunner._wait_for_accessibility_bus):
+(TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
+(TestRunner._start_accessibility_daemons):
+(TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
+
 2016-08-26  Per Arne Vollan  
 
 [Win] Warning fix.


Modified: trunk/Tools/Scripts/run-gtk-tests (205016 => 205017)

--- trunk/Tools/Scripts/run-gtk-tests	2016-08-26 16:35:26 UTC (rev 205016)
+++ trunk/Tools/Scripts/run-gtk-tests	2016-08-26 16:36:29 UTC (rev 205017)
@@ -153,6 +153,28 @@
 
 return None
 
+def _wait_for_accessibility_bus(self):
+def timeout_accessibility_bus():
+self._accessibility_bus_found = False
+sys.stderr.write("Timeout waiting for the accesibility bus.\n")
+sys.stderr.flush()
+loop.quit()
+# Backup current environment, and temporally set the test one.
+oldenv = dict(os.environ)
+os.environ.clear()
+os.environ.update(self._test_env)
+# We spin a main loop until the bus name appears on DBus.
+self._accessibility_bus_found = True
+loop = GLib.MainLoop()
+Gio.bus_watch_name(Gio.BusType.SESSION, 'org.a11y.Bus', Gio.BusNameWatcherFlags.NONE,
+   lambda *args: loop.quit(), None)
+GLib.timeout_add_seconds(5, timeout_accessibility_bus)
+loop.run()
+# Restore previous environment.
+os.environ.clear()
+os.environ.update(oldenv)
+return self._accessibility_bus_found
+
 def _start_accessibility_daemons(self):
 spi_bus_launcher_path = self._lookup_atspi2_binary('at-spi-bus-launcher')
 spi_registryd_path = self._lookup_atspi2_binary('at-spi2-registryd')
@@ -166,12 +188,11 @@
 sys.stderr.flush()
 return False
 
-# We need to wait until the SPI bus is launched before trying to start the SPI
-# registry, so we spin a main loop until the bus name appears on DBus.
-loop = GLib.MainLoop()
-Gio.bus_watch_name(Gio.BusType.SESSION, 'org.a11y.Bus', Gio.BusNameWatcherFlags.NONE,
-   lambda *args: loop.quit(), None)
-loop.run()
+# We need to wait until the SPI bus is launched before trying to start the SPI registry.
+if not self._wait_for_accessibility_bus():
+sys.stderr.write("Failed checking the accessibility bus within D-Bus\n")
+sys.stderr.flush()
+return False
 
 try:
 self._spi_registryd = subprocess.Popen([spi_registryd_path], env=self._test_env)
@@ -330,7 +351,7 @@
 
 def _get_tests_from_google_test_suite(self, test_program):
 try:
-output = subprocess.check_output([test_program, '--gtest_list_tests'])
+output = subprocess.check_output([test_program, '--gtest_list_tests'], env=self._test_env)
 except subprocess.CalledProcessError:
 sys.stderr.write("ERROR: could not list available tests for binary %s.\n" % (test_program))
  

[webkit-changes] [205018] trunk

[commit-queue]

Title: [205018] trunk








Revision 205018
Author commit-qu...@webkit.org
Date 2016-08-26 09:41:48 -0700 (Fri, 26 Aug 2016)


Log Message
The annotation-xml element does not need to be behave as an mrow
https://bugs.webkit.org/show_bug.cgi?id=161230

Patch by Frederic Wang  on 2016-08-26
Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

In r204779, MathMLAnnotationElement was made a MathMLRowElement just because the
annotation-xml element is generating a RenderMathMLRow. This later point is actually not
needed since annotation-xml is just a wrapper for foreign elements and so does not need to
handle special MathML features like operator spacing or stretching. We can thus move back
MathMLAnnotationElement to a generic MathMLPresentationElement and instead make the
annotation-xml element generate a generic RenderMathMLBlock renderer.

No new tests, semantics annotations already covered by existing tests.

* mathml/MathMLAnnotationElement.cpp: Replace RenderMathMLRow.h with RenderMathMLBlock.h
(WebCore::MathMLAnnotationElement::MathMLAnnotationElement): Inherit from
MathMLPresentationElement instead of MathMLRowElement.
(WebCore::MathMLAnnotationElement::createElementRenderer): Make annotation-xml create a
RenderMathMLBlock instead of a RenderMathMLRow.
(WebCore::MathMLAnnotationElement::attributeChanged): Inherit from MathMLPresentationElement
instead of MathMLRowElement.
* mathml/MathMLAnnotationElement.h: Ditto.

LayoutTests:

* platform/efl/accessibility/math-foreign-content-expected.txt: Remove the AXGroup from the
test expectation, which that was used for annotation-xml.
* platform/gtk/accessibility/math-foreign-content-expected.txt: Ditto.
* platform/mac/accessibility/math-foreign-content-expected.txt: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/accessibility/math-foreign-content-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/math-foreign-content-expected.txt
trunk/LayoutTests/platform/mac/accessibility/math-foreign-content-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/mathml/MathMLAnnotationElement.cpp
trunk/Source/WebCore/mathml/MathMLAnnotationElement.h




Diff

Modified: trunk/LayoutTests/ChangeLog (205017 => 205018)

--- trunk/LayoutTests/ChangeLog	2016-08-26 16:36:29 UTC (rev 205017)
+++ trunk/LayoutTests/ChangeLog	2016-08-26 16:41:48 UTC (rev 205018)
@@ -1,3 +1,15 @@
+2016-08-26  Frederic Wang  
+
+The annotation-xml element does not need to be behave as an mrow
+https://bugs.webkit.org/show_bug.cgi?id=161230
+
+Reviewed by Manuel Rego Casasnovas.
+
+* platform/efl/accessibility/math-foreign-content-expected.txt: Remove the AXGroup from the
+test expectation, which that was used for annotation-xml.
+* platform/gtk/accessibility/math-foreign-content-expected.txt: Ditto.
+* platform/mac/accessibility/math-foreign-content-expected.txt: Ditto.
+
 2016-08-26  Alexey Proskuryakov  
 
 Reinstate flakiness expectations for viewport tests, as they are still flaky.


Modified: trunk/LayoutTests/platform/efl/accessibility/math-foreign-content-expected.txt (205017 => 205018)

--- trunk/LayoutTests/platform/efl/accessibility/math-foreign-content-expected.txt	2016-08-26 16:36:29 UTC (rev 205017)
+++ trunk/LayoutTests/platform/efl/accessibility/math-foreign-content-expected.txt	2016-08-26 16:41:48 UTC (rev 205018)
@@ -5,8 +5,7 @@
 
 AXRole: AXMath 
 AXRole: AXGroup 
-AXRole: AXGroup 
-AXRole: AXSection AXValue: SVG
+AXRole: AXSection AXValue: SVG
 AXRole: AXStatic AXValue: HTML
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/platform/gtk/accessibility/math-foreign-content-expected.txt (205017 => 205018)

--- trunk/LayoutTests/platform/gtk/accessibility/math-foreign-content-expected.txt	2016-08-26 16:36:29 UTC (rev 205017)
+++ trunk/LayoutTests/platform/gtk/accessibility/math-foreign-content-expected.txt	2016-08-26 16:41:48 UTC (rev 205018)
@@ -5,8 +5,7 @@
 
 AXRole: AXMath 
 AXRole: AXGroup 
-AXRole: AXGroup 
-AXRole: AXSection AXValue: SVG
+AXRole: AXSection AXValue: SVG
 AXRole: AXStatic AXValue: HTML
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/platform/mac/accessibility/math-foreign-content-expected.txt (205017 => 205018)

--- trunk/LayoutTests/platform/mac/accessibility/math-foreign-content-expected.txt	2016-08-26 16:36:29 UTC (rev 205017)
+++ trunk/LayoutTests/platform/mac/accessibility/math-foreign-content-expected.txt	2016-08-26 16:41:48 UTC (rev 205018)
@@ -5,9 +5,8 @@
 
 AXRole: AXGroup AXSubrole: AXDocumentMath AXValue: 
 AXRole: AXGroup AXSubrole: AXMathRow AXValue: 
-AXRole: AXGroup AXSubrole: AXMathRow AXValue: 
-AXRole: AXGroup AXSubrole:  AXValue: 
-AXRole: AXStaticText AXSubrole:  AXValue: SVG
+AXRole: AXGroup AXSubrole:  AXValue: 
+AXRole: AXStaticText AXSubrole:  AXValue: SVG
 AXRole

[webkit-changes] [205019] tags/Safari-602.1.50.0.7/

[bshafiei]

Title: [205019] tags/Safari-602.1.50.0.7/








Revision 205019
Author bshaf...@apple.com
Date 2016-08-26 09:50:03 -0700 (Fri, 26 Aug 2016)


Log Message
New tag.

Added Paths

tags/Safari-602.1.50.0.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205020] trunk/Source/JavaScriptCore

[pvollan]

Title: [205020] trunk/Source/_javascript_Core








Revision 205020
Author pvol...@apple.com
Date 2016-08-26 09:50:15 -0700 (Fri, 26 Aug 2016)


Log Message
[Win] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=161235

Reviewed by Brent Fulgham.

YarrPattern::errorMessage has inconsistent dll linkage.

* yarr/YarrPattern.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrPattern.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (205019 => 205020)

--- trunk/Source/_javascript_Core/ChangeLog	2016-08-26 16:50:03 UTC (rev 205019)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-08-26 16:50:15 UTC (rev 205020)
@@ -1,3 +1,14 @@
+2016-08-26  Per Arne Vollan  
+
+[Win] Compile fix.
+https://bugs.webkit.org/show_bug.cgi?id=161235
+
+Reviewed by Brent Fulgham.
+
+YarrPattern::errorMessage has inconsistent dll linkage.
+
+* yarr/YarrPattern.h:
+
 2016-08-25  Alex Christensen  
 
 CMake build fix.


Modified: trunk/Source/_javascript_Core/yarr/YarrPattern.h (205019 => 205020)

--- trunk/Source/_javascript_Core/yarr/YarrPattern.h	2016-08-26 16:50:03 UTC (rev 205019)
+++ trunk/Source/_javascript_Core/yarr/YarrPattern.h	2016-08-26 16:50:15 UTC (rev 205020)
@@ -324,7 +324,7 @@
 NumberOfErrorCodes
 };
 
-WTF_EXPORT_PRIVATE static const char* errorMessage(ErrorCode);
+JS_EXPORT_PRIVATE static const char* errorMessage(ErrorCode);
 
 void reset()
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205021] trunk

[ossy]

Title: [205021] trunk








Revision 205021
Author o...@webkit.org
Date 2016-08-26 09:54:14 -0700 (Fri, 26 Aug 2016)


Log Message
Fix the ENABLE(WEBASSEMBLY) build on Linux
https://bugs.webkit.org/show_bug.cgi?id=161197

Reviewed by Mark Lam.

Source/_javascript_Core:

* CMakeLists.txt:
* b3/B3Common.cpp:
(JSC::B3::shouldDumpIR):
* shell/CMakeLists.txt:
* wasm/JSWASMModule.h:
* wasm/WASMB3IRGenerator.cpp:
(JSC::WASM::toB3Op):
* wasm/WASMB3IRGenerator.h:
* wasm/WASMFormat.h:
* wasm/WASMFunctionParser.h:
* wasm/WASMModuleParser.cpp:
(JSC::WASM::WASMModuleParser::parseFunctionTypes):
* wasm/WASMModuleParser.h:
* wasm/WASMParser.h:
* wasm/WASMPlan.cpp:
* wasm/WASMPlan.h:
* wasm/WASMSections.cpp:

Source/WTF:

* wtf/Platform.h:

Tools:

* Scripts/build-jsc:

Modified Paths

trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3Common.cpp
trunk/Source/_javascript_Core/shell/CMakeLists.txt
trunk/Source/_javascript_Core/wasm/JSWASMModule.h
trunk/Source/_javascript_Core/wasm/WASMB3IRGenerator.cpp
trunk/Source/_javascript_Core/wasm/WASMB3IRGenerator.h
trunk/Source/_javascript_Core/wasm/WASMFormat.h
trunk/Source/_javascript_Core/wasm/WASMFunctionParser.h
trunk/Source/_javascript_Core/wasm/WASMModuleParser.cpp
trunk/Source/_javascript_Core/wasm/WASMModuleParser.h
trunk/Source/_javascript_Core/wasm/WASMParser.h
trunk/Source/_javascript_Core/wasm/WASMPlan.cpp
trunk/Source/_javascript_Core/wasm/WASMPlan.h
trunk/Source/_javascript_Core/wasm/WASMSections.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-jsc




Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (205020 => 205021)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2016-08-26 16:50:15 UTC (rev 205020)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2016-08-26 16:54:14 UTC (rev 205021)
@@ -841,6 +841,10 @@
 tools/JSDollarVMPrototype.cpp
 
 wasm/JSWASMModule.cpp
+wasm/WASMB3IRGenerator.cpp
+wasm/WASMModuleParser.cpp
+wasm/WASMPlan.cpp
+wasm/WASMSections.cpp
 
 yarr/RegularExpression.cpp
 yarr/YarrCanonicalizeUCS2.cpp


Modified: trunk/Source/_javascript_Core/ChangeLog (205020 => 205021)

--- trunk/Source/_javascript_Core/ChangeLog	2016-08-26 16:50:15 UTC (rev 205020)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-08-26 16:54:14 UTC (rev 205021)
@@ -1,3 +1,28 @@
+2016-08-26  Csaba Osztrogonác  
+
+Fix the ENABLE(WEBASSEMBLY) build on Linux
+https://bugs.webkit.org/show_bug.cgi?id=161197
+
+Reviewed by Mark Lam.
+
+* CMakeLists.txt:
+* b3/B3Common.cpp:
+(JSC::B3::shouldDumpIR):
+* shell/CMakeLists.txt:
+* wasm/JSWASMModule.h:
+* wasm/WASMB3IRGenerator.cpp:
+(JSC::WASM::toB3Op):
+* wasm/WASMB3IRGenerator.h:
+* wasm/WASMFormat.h:
+* wasm/WASMFunctionParser.h:
+* wasm/WASMModuleParser.cpp:
+(JSC::WASM::WASMModuleParser::parseFunctionTypes):
+* wasm/WASMModuleParser.h:
+* wasm/WASMParser.h:
+* wasm/WASMPlan.cpp:
+* wasm/WASMPlan.h:
+* wasm/WASMSections.cpp:
+
 2016-08-26  Per Arne Vollan  
 
 [Win] Compile fix.


Modified: trunk/Source/_javascript_Core/b3/B3Common.cpp (205020 => 205021)

--- trunk/Source/_javascript_Core/b3/B3Common.cpp	2016-08-26 16:50:15 UTC (rev 205020)
+++ trunk/Source/_javascript_Core/b3/B3Common.cpp	2016-08-26 16:54:14 UTC (rev 205021)
@@ -36,7 +36,11 @@
 
 bool shouldDumpIR(B3ComplitationMode mode)
 {
+#if ENABLE(FTL_JIT)
 return FTL::verboseCompilationEnabled() || FTL::shouldDumpDisassembly() || shouldDumpIRAtEachPhase(mode);
+#else
+return shouldDumpIRAtEachPhase(mode);
+#endif
 }
 
 bool shouldDumpIRAtEachPhase(B3ComplitationMode mode)


Modified: trunk/Source/_javascript_Core/shell/CMakeLists.txt (205020 => 205021)

--- trunk/Source/_javascript_Core/shell/CMakeLists.txt	2016-08-26 16:50:15 UTC (rev 205020)
+++ trunk/Source/_javascript_Core/shell/CMakeLists.txt	2016-08-26 16:54:14 UTC (rev 205021)
@@ -49,6 +49,10 @@
 ../b3/air/testair.cpp
 )
 
+set(TESTWASM_SOURCES
+../testWASM.cpp
+)
+
 add_executable(testb3 ${TESTB3_SOURCES})
 target_link_libraries(testb3 ${JSC_LIBRARIES})
 
@@ -55,4 +59,7 @@
 add_executable(testair ${TESTAIR_SOURCES})
 target_link_libraries(testair ${JSC_LIBRARIES})
 
+add_executable(testWASM ${TESTWASM_SOURCES})
+target_link_libraries(testWASM ${JSC_LIBRARIES})
+
 endif ()


Modified: trunk/Source/_javascript_Core/wasm/JSWASMModule.h (205020 => 205021)

--- trunk/Source/_javascript_Core/wasm/JSWASMModule.h	2016-08-26 16:50:15 UTC (rev 205020)
+++ trunk/Source/_javascript_Core/wasm/JSWASMModule.h	2016-08-26 16:54:14 UTC (rev 205021)
@@ -23,8 +23,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef JSWASMModule_h
-#define JSWASMModule_h
+#pragma once
 
 #if ENABLE(WEBASSEMBLY)
 
@@ -114

[webkit-changes] [205022] trunk/Source/bmalloc

[barraclough]

Title: [205022] trunk/Source/bmalloc








Revision 205022
Author barraclo...@apple.com
Date 2016-08-26 10:02:37 -0700 (Fri, 26 Aug 2016)


Log Message
bmalloc: speed up the lock slow path
https://bugs.webkit.org/show_bug.cgi?id=161058

Unreviewed rollout - this caused regressions .

* bmalloc.xcodeproj/project.pbxproj:
* bmalloc/ScopeExit.h: Removed.
* bmalloc/StaticMutex.cpp:
(bmalloc::StaticMutex::lockSlowCase):
* bmalloc/StaticMutex.h:
(bmalloc::StaticMutex::init):
* bmalloc/ThreadSwitch.h: Removed.

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/StaticMutex.cpp
trunk/Source/bmalloc/bmalloc/StaticMutex.h
trunk/Source/bmalloc/bmalloc.xcodeproj/project.pbxproj


Removed Paths

trunk/Source/bmalloc/bmalloc/ScopeExit.h
trunk/Source/bmalloc/bmalloc/ThreadSwitch.h




Diff

Modified: trunk/Source/bmalloc/ChangeLog (205021 => 205022)

--- trunk/Source/bmalloc/ChangeLog	2016-08-26 16:54:14 UTC (rev 205021)
+++ trunk/Source/bmalloc/ChangeLog	2016-08-26 17:02:37 UTC (rev 205022)
@@ -1,3 +1,18 @@
+2016-08-26  Gavin Barraclough  
+
+bmalloc: speed up the lock slow path
+https://bugs.webkit.org/show_bug.cgi?id=161058
+
+Unreviewed rollout - this caused regressions .
+
+* bmalloc.xcodeproj/project.pbxproj:
+* bmalloc/ScopeExit.h: Removed.
+* bmalloc/StaticMutex.cpp:
+(bmalloc::StaticMutex::lockSlowCase):
+* bmalloc/StaticMutex.h:
+(bmalloc::StaticMutex::init):
+* bmalloc/ThreadSwitch.h: Removed.
+
 2016-08-24  Andreas Kling  
 
 Add bmalloc::api::isEnabled().


Deleted: trunk/Source/bmalloc/bmalloc/ScopeExit.h (205021 => 205022)

--- trunk/Source/bmalloc/bmalloc/ScopeExit.h	2016-08-26 16:54:14 UTC (rev 205021)
+++ trunk/Source/bmalloc/bmalloc/ScopeExit.h	2016-08-26 17:02:37 UTC (rev 205022)
@@ -1,54 +0,0 @@
-/*
- * Copyright (C) 2016 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
- */
-
-#include 
-#include 
-
-namespace bmalloc {
-
-template
-class ScopeExit {
-public:
-explicit ScopeExit(ExitFunction&& exitFunction)
-: m_exitFunction(exitFunction)
-{
-}
-
-~ScopeExit()
-{
-m_exitFunction();
-}
-
-private:
-ExitFunction m_exitFunction;
-};
-
-template
-ScopeExit makeScopeExit(ExitFunction&& exitFunction)
-{
-return ScopeExit(std::forward(exitFunction));
-}
-
-} // namespace bmalloc


Modified: trunk/Source/bmalloc/bmalloc/StaticMutex.cpp (205021 => 205022)

--- trunk/Source/bmalloc/bmalloc/StaticMutex.cpp	2016-08-26 16:54:14 UTC (rev 205021)
+++ trunk/Source/bmalloc/bmalloc/StaticMutex.cpp	2016-08-26 17:02:37 UTC (rev 205022)
@@ -23,31 +23,15 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */
 
-#include "ScopeExit.h"
 #include "StaticMutex.h"
-#include "ThreadSwitch.h"
+#include 
 
 namespace bmalloc {
 
 void StaticMutex::lockSlowCase()
 {
-// The longest critical section in bmalloc is much shorter than the
-// time it takes to make a system call to yield to the OS scheduler.
-// So, we try again a lot before we yield.
-static const size_t aLot = 256;
-
-if (!m_isSpinning.test_and_set()) {
-auto clear = makeScopeExit([&] { m_isSpinning.clear(); });
-
-for (size_t i = 0; i < aLot; ++i) {
-if (try_lock())
-return;
-}
-}
-
-// Avoid spinning pathologically.
 while (!try_lock())
-threadSwitch();
+std::this_thread::yield();
 }
 
 } // namespace bmalloc


Modified: trunk/Source/bmalloc/bmalloc/StaticMutex.h (205021 => 205022)

--- trunk/Source/bmalloc/bmalloc/StaticMutex.h	2016-08-26 16:54:14 UTC (rev 205021)
+++ trunk/Source/bmalloc/bmalloc/StaticMutex.h	2016-08-26 

[webkit-changes] [205023] trunk

[keith_miller]

Title: [205023] trunk








Revision 205023
Author keith_mil...@apple.com
Date 2016-08-26 10:05:21 -0700 (Fri, 26 Aug 2016)


Log Message
toString called on proxies returns incorrect tag
https://bugs.webkit.org/show_bug.cgi?id=16

Reviewed by Benjamin Poulain.

This patch adds a new Method table function toStringName. This function
is used by Object.prototype.toString to create the string tag that it
inserts. Right now it only changes the stringification of proxy objects.
In future patches I plan to make it work for other classes of objects as
well.

* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::toStringName):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::toStringName):
* runtime/JSObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
* runtime/ProxyObject.cpp:
(JSC::ProxyObject::toStringName):
* runtime/ProxyObject.h:

Modified Paths

trunk/JSTests/test262.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ClassInfo.h
trunk/Source/_javascript_Core/runtime/JSCell.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/ObjectPrototype.cpp
trunk/Source/_javascript_Core/runtime/ProxyObject.cpp
trunk/Source/_javascript_Core/runtime/ProxyObject.h




Diff

Modified: trunk/JSTests/test262.yaml (205022 => 205023)

--- trunk/JSTests/test262.yaml	2016-08-26 17:02:37 UTC (rev 205022)
+++ trunk/JSTests/test262.yaml	2016-08-26 17:05:21 UTC (rev 205023)
@@ -19480,9 +19480,9 @@
 - path: test262/test/built-ins/JSON/stringify/value-proxy-revoked.js
   cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
 - path: test262/test/built-ins/JSON/stringify/value-proxy.js
-  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
+  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
 - path: test262/test/built-ins/JSON/stringify/value-proxy.js
-  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
+  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
 - path: test262/test/built-ins/Map/Symbol.species/length.js
   cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js", "../../../../harness/propertyHelper.js"], []
 - path: test262/test/built-ins/Map/Symbol.species/length.js
@@ -22974,9 +22974,9 @@
 - path: test262/test/built-ins/Object/create/15.2.3.5-4-139.js
   cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
 - path: test262/test/built-ins/Object/create/15.2.3.5-4-14.js
-  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
+  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
 - path: test262/test/built-ins/Object/create/15.2.3.5-4-14.js
-  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
+  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
 - path: test262/test/built-ins/Object/create/15.2.3.5-4-140.js
   cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
 - path: test262/test/built-ins/Object/create/15.2.3.5-4-140.js
@@ -23746,9 +23746,9 @@
 - path: test262/test/built-ins/Object/create/15.2.3.5-4-36.js
   cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
 - path: test262/test/built-ins/Object/create/15.2.3.5-4-37.js
-  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
+  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
 - path: test262/test/built-ins/Object/create/15.2.3.5-4-37.js
-  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
+  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
 - path: test262/test/built-ins/Object/create/15.2.3.5-4-38.js
   cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
 - path: test262/test/built-ins/Object/create/15.2.3.5-4-38.js
@@ -34330,9 +34330,9 @@
 - path: test262/test/built-ins/Object/prototype/toString/proxy-revoked.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
 - path: test262/test/built-ins/Object/prototype/toString/proxy.js
-  cmd: runTest262

[webkit-changes] [205024] trunk

[eric . carlson]

Title: [205024] trunk








Revision 205024
Author eric.carl...@apple.com
Date 2016-08-26 10:13:35 -0700 (Fri, 26 Aug 2016)


Log Message
[MediaStream] Add support for OverConstrainedErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=161199


Reviewed by Jer Noble.

Source/WebCore:

Test: fast/events/constructors/overconstrained-error-event-constructor.html

* CMakeLists.txt:
* DerivedSources.make:
* Modules/mediastream/OverconstrainedErrorEvent.h: Added.
(WebCore::OverconstrainedErrorEvent::~OverconstrainedErrorEvent):
(WebCore::OverconstrainedErrorEvent::create):
(WebCore::OverconstrainedErrorEvent::createForBindings):
(WebCore::OverconstrainedErrorEvent::error):
(WebCore::OverconstrainedErrorEvent::eventInterface):
(WebCore::OverconstrainedErrorEvent::OverconstrainedErrorEvent):
* Modules/mediastream/OverconstrainedErrorEvent.idl: Added.

* WebCore.xcodeproj/project.pbxproj: Add new files.

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Add OverconstrainedErrorEvent converter.
* bindings/js/JSDictionary.h:

* dom/EventNames.in: Add OverconstrainedErrorEvent.

LayoutTests:

* fast/events/constructors/overconstrained-error-event-constructor-expected.txt: Added.
* fast/events/constructors/overconstrained-error-event-constructor.html: Added.
* js/dom/global-constructors-attributes-expected.txt: Updated.
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSDictionary.cpp
trunk/Source/WebCore/bindings/js/JSDictionary.h
trunk/Source/WebCore/dom/EventNames.in


Added Paths

trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor-expected.txt
trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor.html
trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h
trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (205023 => 205024)

--- trunk/LayoutTests/ChangeLog	2016-08-26 17:05:21 UTC (rev 205023)
+++ trunk/LayoutTests/ChangeLog	2016-08-26 17:13:35 UTC (rev 205024)
@@ -1,3 +1,19 @@
+2016-08-26  Eric Carlson  
+
+[MediaStream] Add support for OverConstrainedErrorEvent
+https://bugs.webkit.org/show_bug.cgi?id=161199
+
+
+Reviewed by Jer Noble.
+
+* fast/events/constructors/overconstrained-error-event-constructor-expected.txt: Added.
+* fast/events/constructors/overconstrained-error-event-constructor.html: Added.
+* js/dom/global-constructors-attributes-expected.txt: Updated.
+* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
+
 2016-08-26  Frederic Wang  
 
 The annotation-xml element does not need to be behave as an mrow


Added: trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor-expected.txt (0 => 205024)

--- trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor-expected.txt	2016-08-26 17:13:35 UTC (rev 205024)
@@ -0,0 +1,26 @@
+This tests the constructor for the OverconstrainedErrorEvent DOM class.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS new OverconstrainedErrorEvent('eventType').bubbles is false
+PASS new OverconstrainedErrorEvent('eventType').cancelable is false
+PASS new OverconstrainedErrorEvent('eventType').error is null
+PASS new OverconstrainedErrorEvent('eventType', { bubbles: false }).bubbles is false
+PASS new OverconstrainedErrorEvent('eventType', { bubbles: true }).bubbles is true
+PASS new OverconstrainedErrorEvent('eventType', { cancelable: false }).cancelable is false
+PASS new OverconstrainedErrorEvent('eventType', { cancelable: true }).cancelable is true
+PASS new OverconstrainedErrorEvent('eventType', { er

[webkit-changes] [205025] trunk/Source/WebCore

[pvollan]

Title: [205025] trunk/Source/WebCore








Revision 205025
Author pvol...@apple.com
Date 2016-08-26 10:36:15 -0700 (Fri, 26 Aug 2016)


Log Message
[Win] Warning fixes.
https://bugs.webkit.org/show_bug.cgi?id=161241

Reviewed by Brent Fulgham.

MSVC warns about potential use of uninitialized variables.

* accessibility/AXObjectCache.cpp:
* css/parser/CSSParserValues.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/css/parser/CSSParserValues.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (205024 => 205025)

--- trunk/Source/WebCore/ChangeLog	2016-08-26 17:13:35 UTC (rev 205024)
+++ trunk/Source/WebCore/ChangeLog	2016-08-26 17:36:15 UTC (rev 205025)
@@ -1,3 +1,15 @@
+2016-08-26  Per Arne Vollan  
+
+[Win] Warning fixes.
+https://bugs.webkit.org/show_bug.cgi?id=161241
+
+Reviewed by Brent Fulgham.
+
+MSVC warns about potential use of uninitialized variables.
+
+* accessibility/AXObjectCache.cpp:
+* css/parser/CSSParserValues.cpp:
+
 2016-08-26  Eric Carlson  
 
 [MediaStream] Add support for OverConstrainedErrorEvent


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (205024 => 205025)

--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2016-08-26 17:13:35 UTC (rev 205024)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2016-08-26 17:36:15 UTC (rev 205025)
@@ -100,6 +100,11 @@
 #include "MediaControlElements.h"
 #endif
 
+#if COMPILER(MSVC)
+// See https://msdn.microsoft.com/en-us/library/1wea5zwe.aspx
+#pragma warning(disable: 4701)
+#endif
+
 namespace WebCore {
 
 using namespace HTMLNames;


Modified: trunk/Source/WebCore/css/parser/CSSParserValues.cpp (205024 => 205025)

--- trunk/Source/WebCore/css/parser/CSSParserValues.cpp	2016-08-26 17:13:35 UTC (rev 205024)
+++ trunk/Source/WebCore/css/parser/CSSParserValues.cpp	2016-08-26 17:36:15 UTC (rev 205025)
@@ -29,6 +29,11 @@
 #include "CSSVariableValue.h"
 #include "SelectorPseudoTypeMap.h"
 
+#if COMPILER(MSVC)
+// See https://msdn.microsoft.com/en-us/library/1wea5zwe.aspx
+#pragma warning(disable: 4701)
+#endif
+
 namespace WebCore {
 
 using namespace WTF;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205027] trunk

[utatane . tea]

Title: [205027] trunk








Revision 205027
Author utatane@gmail.com
Date 2016-08-26 10:37:31 -0700 (Fri, 26 Aug 2016)


Log Message
[ES6] newPromiseCapabilities should check the given argument is constructor
https://bugs.webkit.org/show_bug.cgi?id=161226

Reviewed by Mark Lam.

JSTests:

The arrow function should not be a constructor. So the error should be raised.

* stress/new-promise-capabilities-requires-constructor.js: Added.
(shouldThrow):

Source/_javascript_Core:

Use @isConstructor.

* builtins/PromiseOperations.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/PromiseOperations.js


Added Paths

trunk/JSTests/stress/new-promise-capabilities-requires-constructor.js




Diff

Modified: trunk/JSTests/ChangeLog (205026 => 205027)

--- trunk/JSTests/ChangeLog	2016-08-26 17:36:59 UTC (rev 205026)
+++ trunk/JSTests/ChangeLog	2016-08-26 17:37:31 UTC (rev 205027)
@@ -1,3 +1,15 @@
+2016-08-26  Yusuke Suzuki  
+
+[ES6] newPromiseCapabilities should check the given argument is constructor
+https://bugs.webkit.org/show_bug.cgi?id=161226
+
+Reviewed by Mark Lam.
+
+The arrow function should not be a constructor. So the error should be raised.
+
+* stress/new-promise-capabilities-requires-constructor.js: Added.
+(shouldThrow):
+
 2016-08-25  Benjamin Poulain  
 
 [JSC] Clean up the abstract interpreter for cos/sin/sqrt/fround/log


Added: trunk/JSTests/stress/new-promise-capabilities-requires-constructor.js (0 => 205027)

--- trunk/JSTests/stress/new-promise-capabilities-requires-constructor.js	(rev 0)
+++ trunk/JSTests/stress/new-promise-capabilities-requires-constructor.js	2016-08-26 17:37:31 UTC (rev 205027)
@@ -0,0 +1,18 @@
+function shouldThrow(func, errorMessage) {
+var errorThrown = false;
+var error = null;
+try {
+func();
+} catch (e) {
+errorThrown = true;
+error = e;
+}
+if (!errorThrown)
+throw new Error('not thrown');
+if (String(error) !== errorMessage)
+throw new Error(`bad error: ${String(error)}`);
+}
+
+shouldThrow(() => {
+Promise.race.call(() => { }, []);
+}, `TypeError: promise capability requires a constructor function`);


Modified: trunk/Source/_javascript_Core/ChangeLog (205026 => 205027)

--- trunk/Source/_javascript_Core/ChangeLog	2016-08-26 17:36:59 UTC (rev 205026)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-08-26 17:37:31 UTC (rev 205027)
@@ -1,3 +1,14 @@
+2016-08-26  Yusuke Suzuki  
+
+[ES6] newPromiseCapabilities should check the given argument is constructor
+https://bugs.webkit.org/show_bug.cgi?id=161226
+
+Reviewed by Mark Lam.
+
+Use @isConstructor.
+
+* builtins/PromiseOperations.js:
+
 2016-08-25  Keith Miller  
 
 toString called on proxies returns incorrect tag


Modified: trunk/Source/_javascript_Core/builtins/PromiseOperations.js (205026 => 205027)

--- trunk/Source/_javascript_Core/builtins/PromiseOperations.js	2016-08-26 17:36:59 UTC (rev 205026)
+++ trunk/Source/_javascript_Core/builtins/PromiseOperations.js	2016-08-26 17:37:31 UTC (rev 205027)
@@ -50,8 +50,7 @@
 {
 "use strict";
 
-// FIXME: Check isConstructor(constructor).
-if (typeof constructor !== "function")
+if (!@isConstructor(constructor))
 throw new @TypeError("promise capability requires a constructor function");
 
 var promiseCapability = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205028] trunk/Source/WebCore

[ossy]

Title: [205028] trunk/Source/WebCore








Revision 205028
Author o...@webkit.org
Date 2016-08-26 10:58:46 -0700 (Fri, 26 Aug 2016)


Log Message
Fix the !ENABLE(WEB_TIMING) build
https://bugs.webkit.org/show_bug.cgi?id=161250

Reviewed by Alex Christensen.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
* loader/cache/CachedResourceLoader.h:
(WebCore::CachedResourceLoader::resourceTimingInformation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (205027 => 205028)

--- trunk/Source/WebCore/ChangeLog	2016-08-26 17:37:31 UTC (rev 205027)
+++ trunk/Source/WebCore/ChangeLog	2016-08-26 17:58:46 UTC (rev 205028)
@@ -1,3 +1,15 @@
+2016-08-26  Csaba Osztrogonác  
+
+Fix the !ENABLE(WEB_TIMING) build
+https://bugs.webkit.org/show_bug.cgi?id=161250
+
+Reviewed by Alex Christensen.
+
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::didFinishLoading):
+* loader/cache/CachedResourceLoader.h:
+(WebCore::CachedResourceLoader::resourceTimingInformation):
+
 2016-08-26  Chris Dumez  
 
 Trying to access cross-origin Location properties should throw a SecurityError


Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (205027 => 205028)

--- trunk/Source/WebCore/loader/SubresourceLoader.cpp	2016-08-26 17:37:31 UTC (rev 205027)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp	2016-08-26 17:58:46 UTC (rev 205028)
@@ -463,8 +463,10 @@
 finishTime = monotonicallyIncreasingTime();
 m_loadTiming.setResponseEnd(finishTime);
 
+#if ENABLE(WEB_TIMING)
 if (m_documentLoader->cachedResourceLoader().document() && RuntimeEnabledFeatures::sharedFeatures().resourceTimingEnabled())
 m_documentLoader->cachedResourceLoader().resourceTimingInformation().addResourceTiming(m_resource, *m_documentLoader->cachedResourceLoader().document(), m_resource->loader()->loadTiming());
+#endif
 
 m_state = Finishing;
 m_resource->setLoadFinishTime(finishTime);


Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.h (205027 => 205028)

--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.h	2016-08-26 17:37:31 UTC (rev 205027)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.h	2016-08-26 17:58:46 UTC (rev 205028)
@@ -140,7 +140,9 @@
 
 void documentDidFinishLoadEvent();
 
+#if ENABLE(WEB_TIMING)
 ResourceTimingInformation& resourceTimingInformation() { return m_resourceTimingInfo; }
+#endif
 
 private:
 explicit CachedResourceLoader(DocumentLoader*);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205029] trunk/Source/WebCore

[ossy]

Title: [205029] trunk/Source/WebCore








Revision 205029
Author o...@webkit.org
Date 2016-08-26 11:00:28 -0700 (Fri, 26 Aug 2016)


Log Message
Fix the !ENABLE(WEB_SOCKETS) build
https://bugs.webkit.org/show_bug.cgi?id=161251

Reviewed by Alex Christensen.

* page/SocketProvider.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/SocketProvider.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (205028 => 205029)

--- trunk/Source/WebCore/ChangeLog	2016-08-26 17:58:46 UTC (rev 205028)
+++ trunk/Source/WebCore/ChangeLog	2016-08-26 18:00:28 UTC (rev 205029)
@@ -1,5 +1,14 @@
 2016-08-26  Csaba Osztrogonác  
 
+Fix the !ENABLE(WEB_SOCKETS) build
+https://bugs.webkit.org/show_bug.cgi?id=161251
+
+Reviewed by Alex Christensen.
+
+* page/SocketProvider.h:
+
+2016-08-26  Csaba Osztrogonác  
+
 Fix the !ENABLE(WEB_TIMING) build
 https://bugs.webkit.org/show_bug.cgi?id=161250
 


Modified: trunk/Source/WebCore/page/SocketProvider.h (205028 => 205029)

--- trunk/Source/WebCore/page/SocketProvider.h	2016-08-26 17:58:46 UTC (rev 205028)
+++ trunk/Source/WebCore/page/SocketProvider.h	2016-08-26 18:00:28 UTC (rev 205029)
@@ -37,8 +37,8 @@
 
 class WEBCORE_EXPORT SocketProvider : public ThreadSafeRefCounted {
 public:
+static Ref create() { return adoptRef(*new SocketProvider); }
 #if ENABLE(WEB_SOCKETS)
-static Ref create() { return adoptRef(*new SocketProvider); }
 virtual Ref createSocketStreamHandle(const URL&, SocketStreamHandleClient&, SessionID);
 #endif
 virtual ~SocketProvider() { };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205030] trunk

[cdumez]

Title: [205030] trunk








Revision 205030
Author cdu...@apple.com
Date 2016-08-26 11:09:01 -0700 (Fri, 26 Aug 2016)


Log Message
HTMLAreaElement's coords attributes parsing does not comply with the HTML specification
https://bugs.webkit.org/show_bug.cgi?id=161216

Reviewed by Andreas Kling.

LayoutTests/imported/w3c:

Rebaseline W3C test now that all checks are passing. Chrome is also passing all the checks.

* web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt:

Source/WebCore:

HTMLAreaElement's coords attributes parsing does not comply with the HTML specification:
- https://html.spec.whatwg.org/#attr-area-coords

This patch aligns our parsing of this attribute with the specification and Chrome.

No new tests, rebaselined existing test.

* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::HTMLAreaElement):
(WebCore::HTMLAreaElement::parseAttribute):
(WebCore::HTMLAreaElement::getRegion):
* html/HTMLAreaElement.h:
* html/parser/HTMLParserIdioms.cpp:
(WebCore::isHTMLSpaceOrDelimiter):
(WebCore::isNumberStart):
(WebCore::parseHTMLListOfOfFloatingPointNumberValuesInternal):
(WebCore::parseHTMLListOfOfFloatingPointNumberValues):
(WebCore::parseHTMLNonNegativeInteger): Deleted.
* html/parser/HTMLParserIdioms.h:

LayoutTests:

Unskip web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html
as it is now passing and not longer crashing in debug builds.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAreaElement.cpp
trunk/Source/WebCore/html/HTMLAreaElement.h
trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp
trunk/Source/WebCore/html/parser/HTMLParserIdioms.h




Diff

Modified: trunk/LayoutTests/ChangeLog (205029 => 205030)

--- trunk/LayoutTests/ChangeLog	2016-08-26 18:00:28 UTC (rev 205029)
+++ trunk/LayoutTests/ChangeLog	2016-08-26 18:09:01 UTC (rev 205030)
@@ -1,5 +1,17 @@
 2016-08-26  Chris Dumez  
 
+HTMLAreaElement's coords attributes parsing does not comply with the HTML specification
+https://bugs.webkit.org/show_bug.cgi?id=161216
+
+Reviewed by Andreas Kling.
+
+Unskip web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html
+as it is now passing and not longer crashing in debug builds.
+
+* TestExpectations:
+
+2016-08-26  Chris Dumez  
+
 Trying to access cross-origin Location properties should throw a SecurityError
 https://bugs.webkit.org/show_bug.cgi?id=161248
 


Modified: trunk/LayoutTests/TestExpectations (205029 => 205030)

--- trunk/LayoutTests/TestExpectations	2016-08-26 18:00:28 UTC (rev 205029)
+++ trunk/LayoutTests/TestExpectations	2016-08-26 18:09:01 UTC (rev 205030)
@@ -475,8 +475,6 @@
 # WPT tests that fail after doing full test repository reimport and need further investigation
 imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-document.htm [ Pass Failure Timeout ]
 imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace.html [ Pass Failure ]
-webkit.org/b/155516 [ Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html [ Skip ]
-webkit.org/b/155516 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html [ Failure ]
 
 # W3C XMLHttpRequest tests
 imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-aborted.html [ Slow ]


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (205029 => 205030)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-08-26 18:00:28 UTC (rev 205029)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-08-26 18:09:01 UTC (rev 205030)
@@ -1,3 +1,14 @@
+2016-08-26  Chris Dumez  
+
+HTMLAreaElement's coords attributes parsing does not comply with the HTML specification
+https://bugs.webkit.org/show_bug.cgi?id=161216
+
+Reviewed by Andreas Kling.
+
+Rebaseline W3C test now that all checks are passing. Chrome is also passing all the checks.
+
+* web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt:
+
 2016-08-25  Johan K. Jensen  
 
 Update the Resource Timing implementation


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt (205029 => 205030)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt	2016-08-26 18:00:28 UTC (rev 205029)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt	2016-08-26 18:09:01 UTC (rev 205030)
@@ -7,9 +7,29 @@
 PASS FORM FEED: "2\f2

[webkit-changes] [205031] trunk/Source/WebCore

[bfulgham]

Title: [205031] trunk/Source/WebCore








Revision 205031
Author bfulg...@apple.com
Date 2016-08-26 11:12:56 -0700 (Fri, 26 Aug 2016)


Log Message
Crash when getting font bounding rect
https://bugs.webkit.org/show_bug.cgi?id=161202


Reviewed by Myles C. Maxfield.

We should never store GlyphData objects for later use, because they contain raw pointers to Font elements
contained in caches, and those font caches get periodically purged.

Instead, we should hold onto the ‘key’ representing the GlyphData, and simply ask the system for the
GlyphData the next time it is needed.

Tested by existing MathML tests under ASAN and GuardMalloc.

* rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::RenderMathMLToken): Clean up constructors.
(WebCore::RenderMathMLToken::computePreferredLogicalWidths): Use keys to get correct GlyphData when needed.
(WebCore::RenderMathMLToken::updateMathVariantGlyph): Ditto.
(WebCore::RenderMathMLToken::firstLineBaseline): Ditto.
(WebCore::RenderMathMLToken::layoutBlock): Ditto.
(WebCore::RenderMathMLToken::paint): Ditto.
(WebCore::RenderMathMLToken::paintChildren): Ditto.
* rendering/mathml/RenderMathMLToken.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (205030 => 205031)

--- trunk/Source/WebCore/ChangeLog	2016-08-26 18:09:01 UTC (rev 205030)
+++ trunk/Source/WebCore/ChangeLog	2016-08-26 18:12:56 UTC (rev 205031)
@@ -1,3 +1,29 @@
+2016-08-25  Brent Fulgham  
+
+Crash when getting font bounding rect
+https://bugs.webkit.org/show_bug.cgi?id=161202
+
+
+Reviewed by Myles C. Maxfield.
+
+We should never store GlyphData objects for later use, because they contain raw pointers to Font elements
+contained in caches, and those font caches get periodically purged.
+
+Instead, we should hold onto the ‘key’ representing the GlyphData, and simply ask the system for the
+GlyphData the next time it is needed.
+
+Tested by existing MathML tests under ASAN and GuardMalloc.
+
+* rendering/mathml/RenderMathMLToken.cpp:
+(WebCore::RenderMathMLToken::RenderMathMLToken): Clean up constructors.
+(WebCore::RenderMathMLToken::computePreferredLogicalWidths): Use keys to get correct GlyphData when needed.
+(WebCore::RenderMathMLToken::updateMathVariantGlyph): Ditto.
+(WebCore::RenderMathMLToken::firstLineBaseline): Ditto.
+(WebCore::RenderMathMLToken::layoutBlock): Ditto.
+(WebCore::RenderMathMLToken::paint): Ditto.
+(WebCore::RenderMathMLToken::paintChildren): Ditto.
+* rendering/mathml/RenderMathMLToken.h:
+
 2016-08-26  Chris Dumez  
 
 HTMLAreaElement's coords attributes parsing does not comply with the HTML specification


Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.cpp (205030 => 205031)

--- trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.cpp	2016-08-26 18:09:01 UTC (rev 205030)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.cpp	2016-08-26 18:12:56 UTC (rev 205031)
@@ -1,6 +1,7 @@
 /*
  * Copyright (C) 2014 Frédéric Wang (fred.w...@free.fr). All rights reserved.
  * Copyright (C) 2016 Igalia S.L.
+ * Copyright (C) 2016 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -42,15 +43,11 @@
 
 RenderMathMLToken::RenderMathMLToken(Element& element, RenderStyle&& style)
 : RenderMathMLBlock(element, WTFMove(style))
-, m_mathVariantGlyph()
-, m_mathVariantGlyphDirty(false)
 {
 }
 
 RenderMathMLToken::RenderMathMLToken(Document& document, RenderStyle&& style)
 : RenderMathMLBlock(document, WTFMove(style))
-, m_mathVariantGlyph()
-, m_mathVariantGlyphDirty(false)
 {
 }
 
@@ -503,10 +500,13 @@
 if (m_mathVariantGlyphDirty)
 updateMathVariantGlyph();
 
-if (m_mathVariantGlyph.font) {
-m_maxPreferredLogicalWidth = m_minPreferredLogicalWidth = m_mathVariantGlyph.font->widthForGlyph(m_mathVariantGlyph.glyph);
-setPreferredLogicalWidthsDirty(false);
-return;
+if (m_mathVariantCodePoint) {
+auto mathVariantGlyph = style().fontCascade().glyphDataForCharacter(m_mathVariantCodePoint.value(), m_mathVariantIsMirrored);
+if (mathVariantGlyph.font) {
+m_maxPreferredLogicalWidth = m_minPreferredLogicalWidth = mathVariantGlyph.font->widthForGlyph(mathVariantGlyph.glyph);
+setPreferredLogicalWidthsDirty(false);
+return;
+}
 }
 
 RenderMathMLBlock::computePreferredLogicalWidths();
@@ -516,7 +516,7 @@
 {
 ASSERT(m_mathVariantGlyphDirty);
 
-m_mathVariantGlyph = GlyphData();
+m_mathVariantCodePoint = Nullopt;
 m_mathVariantGlyphDirty = false;
 
 // Early return if the 

[webkit-changes] [205032] trunk

[ggaren]

Title: [205032] trunk








Revision 205032
Author gga...@apple.com
Date 2016-08-26 13:18:00 -0700 (Fri, 26 Aug 2016)


Log Message
Renamed XLarge* => Large*
https://bugs.webkit.org/show_bug.cgi?id=161261

Reviewed by Andreas Kling.

XLarge is not a thing anymore: We just have Small and Large.

* bmalloc.xcodeproj/project.pbxproj:
* bmalloc/Heap.cpp:
(bmalloc::Heap::splitAndAllocate):
(bmalloc::Heap::tryAllocateLarge):
(bmalloc::Heap::shrinkLarge):
(bmalloc::Heap::deallocateLarge):
* bmalloc/Heap.h:
* bmalloc/LargeMap.cpp: Copied from Source/bmalloc/bmalloc/XLargeMap.cpp.
(bmalloc::LargeMap::remove):
(bmalloc::LargeMap::add):
(bmalloc::XLargeMap::remove): Deleted.
(bmalloc::XLargeMap::add): Deleted.
* bmalloc/LargeMap.h: Copied from Source/bmalloc/bmalloc/XLargeMap.h.
(bmalloc::LargeMap::ranges):
(bmalloc::XLargeMap::ranges): Deleted.
* bmalloc/LargeRange.h: Copied from Source/bmalloc/bmalloc/XLargeRange.h.
(bmalloc::LargeRange::LargeRange):
(bmalloc::LargeRange::operator<):
(bmalloc::canMerge):
(bmalloc::merge):
(bmalloc::LargeRange::split):
(bmalloc::XLargeRange::XLargeRange): Deleted.
(bmalloc::XLargeRange::operator<): Deleted.
(bmalloc::XLargeRange::split): Deleted.
* bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::tryAllocateLargeChunk):
* bmalloc/VMHeap.h:
* bmalloc/XLargeMap.cpp: Removed.
* bmalloc/XLargeMap.h: Removed.
* bmalloc/XLargeRange.h: Removed.

Modified Paths

trunk/PerformanceTests/MallocBench/MallocBench.xcodeproj/project.pbxproj
trunk/PerformanceTests/MallocBench/run-malloc-benchmarks
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Heap.cpp
trunk/Source/bmalloc/bmalloc/Heap.h
trunk/Source/bmalloc/bmalloc/VMHeap.cpp
trunk/Source/bmalloc/bmalloc/VMHeap.h
trunk/Source/bmalloc/bmalloc.xcodeproj/project.pbxproj


Added Paths

trunk/Source/bmalloc/bmalloc/LargeMap.cpp
trunk/Source/bmalloc/bmalloc/LargeMap.h
trunk/Source/bmalloc/bmalloc/LargeRange.h


Removed Paths

trunk/Source/bmalloc/bmalloc/XLargeMap.cpp
trunk/Source/bmalloc/bmalloc/XLargeMap.h
trunk/Source/bmalloc/bmalloc/XLargeRange.h




Diff

Modified: trunk/PerformanceTests/MallocBench/MallocBench.xcodeproj/project.pbxproj (205031 => 205032)

--- trunk/PerformanceTests/MallocBench/MallocBench.xcodeproj/project.pbxproj	2016-08-26 18:12:56 UTC (rev 205031)
+++ trunk/PerformanceTests/MallocBench/MallocBench.xcodeproj/project.pbxproj	2016-08-26 20:18:00 UTC (rev 205032)
@@ -433,6 +433,7 @@
 GCC_PRECOMPILE_PREFIX_HEADER = NO;
 PRECOMPS_INCLUDE_HEADERS_FROM_BUILT_PRODUCTS_DIR = NO;
 PRODUCT_NAME = "$(TARGET_NAME)";
+SDKROOT = iphoneos.internal;
 			};
 			name = Debug;
 		};
@@ -448,6 +449,7 @@
 );
 PRECOMPS_INCLUDE_HEADERS_FROM_BUILT_PRODUCTS_DIR = NO;
 PRODUCT_NAME = "$(TARGET_NAME)";
+SDKROOT = iphoneos.internal;
 			};
 			name = Release;
 		};


Modified: trunk/PerformanceTests/MallocBench/run-malloc-benchmarks (205031 => 205032)

--- trunk/PerformanceTests/MallocBench/run-malloc-benchmarks	2016-08-26 18:12:56 UTC (rev 205031)
+++ trunk/PerformanceTests/MallocBench/run-malloc-benchmarks	2016-08-26 20:18:00 UTC (rev 205032)
@@ -7,24 +7,6 @@
 $productDir = `perl -e 'use lib \"#{$binDir}/../../Tools/Scripts\"; use webkitdirs; print productDir()'`
 
 $benchmarks_all = [
-# Single-threaded benchmarks.
-"churn",
-"list_allocate",
-"tree_allocate",
-"tree_churn",
-"fragment",
-"fragment_iterate",
-"medium",
-"big",
-
-# Benchmarks based on browser recordings.
-"facebook",
-"reddit",
-"flickr",
-"theverge",
-"nimlang",
-
-# Multi-threaded benchmark variants.
 "message_one",
 "message_many",
 "churn --parallel",
@@ -31,27 +13,10 @@
 "list_allocate --parallel",
 "tree_allocate --parallel",
 "tree_churn --parallel",
-# "facebook --parallel",
-# "reddit --parallel",
-# "flickr --parallel",
-# "theverge --parallel",
-# "nimlang --use-thread-id",
-"fragment --parallel",
-"fragment_iterate --parallel",
-
-# These tests often crash TCMalloc: .
-"medium --parallel",
-"big --parallel",
-
-# Enable these tests to test memory footprint. The way they run is not
-# really compatible with throughput testing.
-# "reddit_memory_warning --runs 0",
-# "flickr_memory_warning --runs 0",
-# "theverge_memory_warning --runs 0",
-
-# Enable this test to test shrinking back down from a large heap while a process remains active.
-# The way it runs is not really compatible with throughput testing.
-# "balloon"
+"facebook --parallel",
+"reddit --parallel",
+"flickr --parallel",
+"theverge --parallel",
 ]
 
 $benchmarks_memory = [


Modified: trunk/Source/bmalloc/ChangeLog (205031 => 205032)

--- trunk/Source/bmalloc/ChangeLog	2016-08-26 18:12:56 UTC (rev 205031)
+++ trunk/Source/bmalloc/ChangeLog	2016-08-26 20:18:00 UTC (rev 205032)
@@ -1,3 +1,43 @@
+2016-08-26  Geoffrey Garen  
+
+Renamed XLarge* => Large*
+https://bugs.webkit.org/show_bug.cgi?id=

[webkit-changes] [205033] trunk/Source/JavaScriptCore

[joepeck]

Title: [205033] trunk/Source/_javascript_Core








Revision 205033
Author joep...@webkit.org
Date 2016-08-26 13:22:21 -0700 (Fri, 26 Aug 2016)


Log Message
Web Inspector: HeapProfiler/ScriptProfiler do not destruct safely when JSContext is destroyed
https://bugs.webkit.org/show_bug.cgi?id=161027


Reviewed by Mark Lam.

For JSContext inspection, when a frontend connects keep the target alive.
This means ref'ing the JSGlobalObject / VM when the first frontend
connects and deref'ing when the last frontend disconnects.

* inspector/JSGlobalObjectInspectorController.h:
* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::globalObjectDestroyed):
(Inspector::JSGlobalObjectInspectorController::disconnectAllFrontends): Deleted.
Now that frontends keep the global object alive, when the global object
is destroyed that must mean that no frontends exist. Remove the now
stale code path.

(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
Ref the target when the first frontend connects, deref when the last disconnects.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp
trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (205032 => 205033)

--- trunk/Source/_javascript_Core/ChangeLog	2016-08-26 20:18:00 UTC (rev 205032)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-08-26 20:22:21 UTC (rev 205033)
@@ -1,3 +1,27 @@
+2016-08-26  Joseph Pecoraro  
+
+Web Inspector: HeapProfiler/ScriptProfiler do not destruct safely when JSContext is destroyed
+https://bugs.webkit.org/show_bug.cgi?id=161027
+
+
+Reviewed by Mark Lam.
+
+For JSContext inspection, when a frontend connects keep the target alive.
+This means ref'ing the JSGlobalObject / VM when the first frontend
+connects and deref'ing when the last frontend disconnects.
+
+* inspector/JSGlobalObjectInspectorController.h:
+* inspector/JSGlobalObjectInspectorController.cpp:
+(Inspector::JSGlobalObjectInspectorController::globalObjectDestroyed):
+(Inspector::JSGlobalObjectInspectorController::disconnectAllFrontends): Deleted.
+Now that frontends keep the global object alive, when the global object
+is destroyed that must mean that no frontends exist. Remove the now
+stale code path.
+
+(Inspector::JSGlobalObjectInspectorController::connectFrontend):
+(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
+Ref the target when the first frontend connects, deref when the last disconnects.
+
 2016-08-26  Yusuke Suzuki  
 
 [ES6] newPromiseCapabilities should check the given argument is constructor


Modified: trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp (205032 => 205033)

--- trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp	2016-08-26 20:18:00 UTC (rev 205032)
+++ trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp	2016-08-26 20:22:21 UTC (rev 205033)
@@ -115,7 +115,7 @@
 
 void JSGlobalObjectInspectorController::globalObjectDestroyed()
 {
-disconnectAllFrontends();
+ASSERT(!m_frontendRouter->hasFrontends());
 
 m_injectedScriptManager->disconnect();
 }
@@ -132,6 +132,10 @@
 if (!connectedFirstFrontend)
 return;
 
+// Keep the JSGlobalObject and VM alive while we are debugging it.
+m_strongVM = &m_globalObject.vm();
+m_strongGlobalObject.set(m_globalObject.vm(), &m_globalObject);
+
 // FIXME: change this to notify agents which frontend has connected (by id).
 m_agents.didCreateFrontendAndBackend(nullptr, nullptr);
 
@@ -162,21 +166,10 @@
 if (m_augmentingClient)
 m_augmentingClient->inspectorDisconnected();
 #endif
-}
 
-void JSGlobalObjectInspectorController::disconnectAllFrontends()
-{
-// FIXME: change this to notify agents which frontend has disconnected (by id).
-m_agents.willDestroyFrontendAndBackend(DisconnectReason::InspectedTargetDestroyed);
-
-m_frontendRouter->disconnectAllFrontends();
-
-m_isAutomaticInspection = false;
-
-#if ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
-if (m_augmentingClient)
-m_augmentingClient->inspectorDisconnected();
-#endif
+// Remove our JSGlobalObject and VM references, we are done debugging it.
+m_strongGlobalObject.clear();
+m_strongVM = nullptr;
 }
 
 void JSGlobalObjectInspectorController::dispatchMessageFromFrontend(const String& message)
@@ -315,4 +308,3 @@
 #endif
 
 } // namespace Inspector
-


Modified: trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.h (205032 => 205033)

--- trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.h	2016-08-26 20:18:00 UTC (rev 205032

[webkit-changes] [205034] trunk/Source/JavaScriptCore

[joepeck]

Title: [205034] trunk/Source/_javascript_Core








Revision 205034
Author joep...@webkit.org
Date 2016-08-26 13:22:24 -0700 (Fri, 26 Aug 2016)


Log Message
Web Inspector: ScriptProfilerAgent and HeapAgent should do less work when frontend disconnects
https://bugs.webkit.org/show_bug.cgi?id=161213


Reviewed by Brian Burg.

* inspector/agents/InspectorHeapAgent.cpp:
(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
Don't take a final snapshot when disconnecting.

* inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorScriptProfilerAgent::stopSamplingWhenDisconnecting):
* inspector/agents/InspectorScriptProfilerAgent.h:
* runtime/SamplingProfiler.h:
Don't process samples when disconnecting.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/agents/InspectorHeapAgent.cpp
trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.cpp
trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.h
trunk/Source/_javascript_Core/runtime/SamplingProfiler.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (205033 => 205034)

--- trunk/Source/_javascript_Core/ChangeLog	2016-08-26 20:22:21 UTC (rev 205033)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-08-26 20:22:24 UTC (rev 205034)
@@ -1,5 +1,24 @@
 2016-08-26  Joseph Pecoraro  
 
+Web Inspector: ScriptProfilerAgent and HeapAgent should do less work when frontend disconnects
+https://bugs.webkit.org/show_bug.cgi?id=161213
+
+
+Reviewed by Brian Burg.
+
+* inspector/agents/InspectorHeapAgent.cpp:
+(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
+Don't take a final snapshot when disconnecting.
+
+* inspector/agents/InspectorScriptProfilerAgent.cpp:
+(Inspector::InspectorScriptProfilerAgent::willDestroyFrontendAndBackend):
+(Inspector::InspectorScriptProfilerAgent::stopSamplingWhenDisconnecting):
+* inspector/agents/InspectorScriptProfilerAgent.h:
+* runtime/SamplingProfiler.h:
+Don't process samples when disconnecting.
+
+2016-08-26  Joseph Pecoraro  
+
 Web Inspector: HeapProfiler/ScriptProfiler do not destruct safely when JSContext is destroyed
 https://bugs.webkit.org/show_bug.cgi?id=161027
 


Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorHeapAgent.cpp (205033 => 205034)

--- trunk/Source/_javascript_Core/inspector/agents/InspectorHeapAgent.cpp	2016-08-26 20:22:21 UTC (rev 205033)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorHeapAgent.cpp	2016-08-26 20:22:24 UTC (rev 205034)
@@ -127,8 +127,10 @@
 
 void InspectorHeapAgent::willDestroyFrontendAndBackend(DisconnectReason)
 {
+// Stop tracking without taking a snapshot.
+m_tracking = false;
+
 ErrorString ignored;
-stopTracking(ignored);
 disable(ignored);
 }
 


Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.cpp (205033 => 205034)

--- trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.cpp	2016-08-26 20:22:21 UTC (rev 205033)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.cpp	2016-08-26 20:22:24 UTC (rev 205034)
@@ -53,8 +53,15 @@
 
 void InspectorScriptProfilerAgent::willDestroyFrontendAndBackend(DisconnectReason)
 {
-ErrorString ignored;
-stopTracking(ignored);
+// Stop tracking without sending results.
+if (m_tracking) {
+m_tracking = false;
+m_activeEvaluateScript = false;
+m_environment.scriptDebugServer().setProfilingClient(nullptr);
+
+// Stop sampling without processing the samples.
+stopSamplingWhenDisconnecting();
+}
 }
 
 void InspectorScriptProfilerAgent::startTracking(ErrorString&, const bool* includeSamples)
@@ -216,6 +223,23 @@
 #endif // ENABLE(SAMPLING_PROFILER)
 }
 
+void InspectorScriptProfilerAgent::stopSamplingWhenDisconnecting()
+{
+#if ENABLE(SAMPLING_PROFILER)
+if (!m_enabledSamplingProfiler)
+return;
+
+JSLockHolder lock(m_environment.scriptDebugServer().vm());
+SamplingProfiler* samplingProfiler = m_environment.scriptDebugServer().vm().samplingProfiler();
+RELEASE_ASSERT(samplingProfiler);
+LockHolder locker(samplingProfiler->getLock());
+samplingProfiler->pause(locker);
+samplingProfiler->clearData(locker);
+
+m_enabledSamplingProfiler = false;
+#endif
+}
+
 void InspectorScriptProfilerAgent::programmaticCaptureStarted()
 {
 m_frontendDispatcher->programmaticCaptureStarted();


Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.h (205033 => 205034)

--- trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.h	2016-08-26 20:22:21 UTC (rev 205033)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.h	2016-08-26 20:22:2

[webkit-changes] [205035] trunk

[commit-queue]

Title: [205035] trunk








Revision 205035
Author commit-qu...@webkit.org
Date 2016-08-26 13:29:17 -0700 (Fri, 26 Aug 2016)


Log Message
Web Inspector: Some CSS selectors in the UI aren't escaped
https://bugs.webkit.org/show_bug.cgi?id=151378

Patch by Devin Rousso  on 2016-08-26
Reviewed by Joseph Pecoraro.

Source/_javascript_Core:

Change ElementData from sending a className string to using an array of
classes, allowing for proper escaping of each class value.

* inspector/protocol/OverlayTypes.json:

Source/WebCore:

No new tests, but logic and results of existing tests updated:
* inspector/dom/content-node-region-info.html:
* inspector/dom/content-node-region-info-expected.txt:
* inspector/dom/highlightNode-expected.txt:
* inspector/dom/highlightSelector.html:
* inspector/dom/highlightSelector-expected.txt:

* inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementData):

* inspector/InspectorOverlayPage.css:
(.pseudo-type):
(.tag-name): Deleted.

* inspector/InspectorOverlayPage.js:
(_createElementTitle):

Source/WebInspectorUI:

* UserInterface/Base/DOMUtilities.js:
(WebInspector.displayNameForNode): Deleted.
(WebInspector.linkifyNodeReference):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

* UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode.prototype.get escapedIdSelector):
(WebInspector.DOMNode.prototype.get escapedClassSelector):
(WebInspector.DOMNode.prototype.get displayName):
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
Rework escaping of ids and class names into separate public functions using CSS.escape.

* UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype.refresh):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

* UserInterface/Views/DOMTreeDataGridNode.js:
(WebInspector.DOMTreeDataGridNode.prototype._createNameCellDocumentFragment):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

* UserInterface/Views/DOMTreeElementPathComponent.js:
(WebInspector.DOMTreeElementPathComponent):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

* UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype.set layer):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

* UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection.prototype.update):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

LayoutTests:

* inspector/dom/content-node-region-info.html:
* inspector/dom/content-node-region-info-expected.txt:
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

* inspector/dom/highlightNode-expected.txt:
* inspector/dom/highlightSelector.html:
* inspector/dom/highlightSelector-expected.txt:
Changed result to replace className with new classes array.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/dom/content-node-region-info.html
trunk/LayoutTests/inspector/dom/highlightNode-expected.txt
trunk/LayoutTests/inspector/dom/highlightSelector-expected.txt
trunk/LayoutTests/inspector/dom/highlightSelector.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/protocol/OverlayTypes.json
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorOverlay.cpp
trunk/Source/WebCore/inspector/InspectorOverlayPage.css
trunk/Source/WebCore/inspector/InspectorOverlayPage.js
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js
trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElementPathComponent.js
trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js




Diff

Modified: trunk/LayoutTests/ChangeLog (205034 => 205035)

--- trunk/LayoutTests/ChangeLog	2016-08-26 20:22:24 UTC (rev 205034)
+++ trunk/LayoutTests/ChangeLog	2016-08-26 20:29:17 UTC (rev 205035)
@@ -1,3 +1,19 @@
+2016-08-26  Devin Rousso  
+
+Web Inspector: Some CSS selectors in the UI aren't escaped
+https://bugs.webkit.org/show_bug.cgi?id=151378
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/dom/content-node-region-info.html:
+* inspector/dom/content-node-region-info-expected.txt:
+Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.
+
+* inspector/dom/highlightNode-expected.txt:
+* inspector/dom/highlightSelector.html:
+* inspector/dom/highlightSelector-expected.txt:
+Changed result to replace className with new classes array.
+
 2016-08-26  Chris Dumez  
 
 HTMLAreaElement's coords attribut

[webkit-changes] [205036] trunk

[mitz]

Title: [205036] trunk








Revision 205036
Author m...@apple.com
Date 2016-08-26 13:33:34 -0700 (Fri, 26 Aug 2016)


Log Message
[Cocoa] Infinite recursion calling -charValue on a WKNSNumber
https://bugs.webkit.org/show_bug.cgi?id=161258

Reviewed by Anders Carlsson.

Source/WebKit2:

* Shared/Cocoa/WKNSNumber.mm:
(-[WKNSNumber charValue]): Override this…
(-[WKNSNumber boolValue]): …not this.

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/Cocoa/WKNSNumber.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (205035 => 205036)

--- trunk/Source/WebKit2/ChangeLog	2016-08-26 20:29:17 UTC (rev 205035)
+++ trunk/Source/WebKit2/ChangeLog	2016-08-26 20:33:34 UTC (rev 205036)
@@ -1,3 +1,14 @@
+2016-08-26  Dan Bernstein  
+
+[Cocoa] Infinite recursion calling -charValue on a WKNSNumber
+https://bugs.webkit.org/show_bug.cgi?id=161258
+
+Reviewed by Anders Carlsson.
+
+* Shared/Cocoa/WKNSNumber.mm:
+(-[WKNSNumber charValue]): Override this…
+(-[WKNSNumber boolValue]): …not this.
+
 2016-08-26  Csaba Osztrogonác  
 
 [EFL][GTK] REGRESSION(204877): Fix the clean build


Modified: trunk/Source/WebKit2/Shared/Cocoa/WKNSNumber.mm (205035 => 205036)

--- trunk/Source/WebKit2/Shared/Cocoa/WKNSNumber.mm	2016-08-26 20:29:17 UTC (rev 205035)
+++ trunk/Source/WebKit2/Shared/Cocoa/WKNSNumber.mm	2016-08-26 20:33:34 UTC (rev 205036)
@@ -106,12 +106,12 @@
 
 // MARK: NSNumber primitive methods
 
-- (BOOL)boolValue
+- (char)charValue
 {
 if (_type == API::Object::Type::Boolean)
 return _number._boolean->value();
 
-return super.boolValue;
+return super.charValue;
 }
 
 - (double)doubleValue


Modified: trunk/Tools/ChangeLog (205035 => 205036)

--- trunk/Tools/ChangeLog	2016-08-26 20:29:17 UTC (rev 205035)
+++ trunk/Tools/ChangeLog	2016-08-26 20:33:34 UTC (rev 205036)
@@ -1,3 +1,13 @@
+2016-08-26  Dan Bernstein  
+
+[Cocoa] Infinite recursion calling -charValue on a WKNSNumber
+https://bugs.webkit.org/show_bug.cgi?id=161258
+
+Reviewed by Anders Carlsson.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
+(TestWebKitAPI::TEST):
+
 2016-08-26  Csaba Osztrogonác  
 
 Fix the ENABLE(WEBASSEMBLY) build on Linux


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm (205035 => 205036)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm	2016-08-26 20:29:17 UTC (rev 205035)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm	2016-08-26 20:33:34 UTC (rev 205036)
@@ -45,6 +45,7 @@
 NSNumber *doubleNumber = (NSNumber *)doubleRef.get();
 
 EXPECT_EQ(YES, booleanNumber.boolValue);
+EXPECT_EQ(YES, booleanNumber.charValue);
 EXPECT_EQ(39UL, uint64Number.unsignedLongLongValue);
 EXPECT_EQ(39, uint64Number.intValue);
 EXPECT_EQ(-16.2, doubleNumber.doubleValue);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205037] trunk

[cdumez]

Title: [205037] trunk








Revision 205037
Author cdu...@apple.com
Date 2016-08-26 13:35:21 -0700 (Fri, 26 Aug 2016)


Log Message
Calling crossOriginWindow.toString() should not be allowed
https://bugs.webkit.org/show_bug.cgi?id=161225

Reviewed by Andreas Kling.

Source/WebCore:

Calling crossOriginWindow.toString() should not be allowed:
- https://html.spec.whatwg.org/#crossoriginproperties-(-o-)

In WebKit, we were printing a security error in the console but
returning "[object Window]" anyway.

In Firefox and Chrome, it throws an exception.

No new tests, updated existing test.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):

LayoutTests:

Update existing tests to reflect the behavior change.

* http/tests/security/cross-frame-access-custom-expected.txt:
* http/tests/security/cross-frame-access-custom.html:
* http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt:
* http/tests/security/cross-frame-access-object-setPrototypeOf.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/cross-frame-access-custom-expected.txt
trunk/LayoutTests/http/tests/security/cross-frame-access-custom.html
trunk/LayoutTests/http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt
trunk/LayoutTests/http/tests/security/cross-frame-access-object-setPrototypeOf.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (205036 => 205037)

--- trunk/LayoutTests/ChangeLog	2016-08-26 20:33:34 UTC (rev 205036)
+++ trunk/LayoutTests/ChangeLog	2016-08-26 20:35:21 UTC (rev 205037)
@@ -1,3 +1,17 @@
+2016-08-26  Chris Dumez  
+
+Calling crossOriginWindow.toString() should not be allowed
+https://bugs.webkit.org/show_bug.cgi?id=161225
+
+Reviewed by Andreas Kling.
+
+Update existing tests to reflect the behavior change.
+
+* http/tests/security/cross-frame-access-custom-expected.txt:
+* http/tests/security/cross-frame-access-custom.html:
+* http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt:
+* http/tests/security/cross-frame-access-object-setPrototypeOf.html:
+
 2016-08-26  Devin Rousso  
 
 Web Inspector: Some CSS selectors in the UI aren't escaped


Modified: trunk/LayoutTests/http/tests/security/cross-frame-access-custom-expected.txt (205036 => 205037)

--- trunk/LayoutTests/http/tests/security/cross-frame-access-custom-expected.txt	2016-08-26 20:33:34 UTC (rev 205036)
+++ trunk/LayoutTests/http/tests/security/cross-frame-access-custom-expected.txt	2016-08-26 20:35:21 UTC (rev 205037)
@@ -15,9 +15,13 @@
 CONSOLE MESSAGE: line 55: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
 CONSOLE MESSAGE: line 83: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
 CONSOLE MESSAGE: line 84: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
+CONSOLE MESSAGE: line 55: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
 CONSOLE MESSAGE: line 83: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
+CONSOLE MESSAGE: line 84: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
 CONSOLE MESSAGE: line 111: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
 CONSOLE MESSAGE: line 111: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
+CONSOLE MESSAGE: line 111: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
+CONSOLE MESSAGE: line 114: TypeError: No default value
 
 
 - tests for getting/setting interesting properties -
@@ -33,7 +37,7 @@
 PASS: canSet('targetWindow.windowPrototypeCustomProperty') should be 'false' and is.
 PASS: canGet('targetWindow.objectPrototypeCustomProperty') should be 'false' and is.
 PASS: canSet('targetWindow.objectPrototypeCustomProperty') should be 'false' and is.
-PASS: canGet('targetWindow.toString') should be 'true' and is.
+PASS: canGet('targetWindow.toString') should be 'false' and is.
 PASS: canSet('targetWindow.toString') should be 'false' and is.
-PASS: toString('targetWindow', '') should be '[object Win

[webkit-changes] [205038] trunk/LayoutTests

[jiewen_tan]

Title: [205038] trunk/LayoutTests








Revision 205038
Author jiewen_...@apple.com
Date 2016-08-26 13:54:19 -0700 (Fri, 26 Aug 2016)


Log Message
Unreviewed, rebase iOS simulator WK1 http tests

* platform/ios-simulator-wk1/TestExpectations:
* platform/ios-simulator-wk1/animations/trigger-container-scroll-simple-expected.txt: Added.
* platform/ios-simulator-wk1/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
* platform/ios-simulator-wk1/http/tests/dom/window-open-about-blank-and-access-document-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/dom/window-open-about-uppercase-blank-and-access-document-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/security/cross-origin-modal-dialog-base-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/security/insecure-geolocation-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-form-in-main-frame-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-xhr-sync-in-main-frame-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-block-insecure-content-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-expected.txt: Added.
* platform/ios-simulator-wk1/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt: Added.
* platform/ios-simulator-wk2/TestExpectations:
* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk1/css2.1/t040302-c61-ex-len-00-b-a-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations


Added Paths

trunk/LayoutTests/platform/ios-simulator-wk1/animations/
trunk/LayoutTests/platform/ios-simulator-wk1/animations/trigger-container-scroll-simple-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/dom/
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/dom/window-open-about-blank-and-access-document-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/dom/window-open-about-uppercase-blank-and-access-document-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/contentSecurityPolicy/
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/cross-origin-modal-dialog-base-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/insecure-geolocation-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/mixedContent/
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-form-in-main-frame-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-xhr-sync-in-main-frame-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-block-insecure-content-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (205037 => 205038)

--- trunk/LayoutTests/ChangeLog	2016-08-26 20:35:21 UTC (rev 205037)
+++ trunk/LayoutTests/ChangeLog	2016-08-26 20:54:19 UTC (rev 205038)
@@ -1,3 +1,25 @@
+2016-08-26  Jiewen Tan  
+
+Unreviewed, rebase iOS simulator WK1 http tests
+
+* platform/ios-simulator-wk1/TestExpectations:
+* platform/ios-simulator-wk1/animations/trigger-container-scroll-simple-expected.txt: Added.
+* platform/ios-simulator-wk1/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
+* platform/ios-simulator-wk1/http/tests/dom/window-open-about

[webkit-changes] [205039] trunk/LayoutTests

[joepeck]

Title: [205039] trunk/LayoutTests








Revision 205039
Author joep...@webkit.org
Date 2016-08-26 13:59:01 -0700 (Fri, 26 Aug 2016)


Log Message
Web Inspector: Modernize inspector/indexeddb tests
https://bugs.webkit.org/show_bug.cgi?id=161113

Reviewed by Brian Burg.

* inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt:
* inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
* inspector/indexeddb/requestDatabaseNames-expected.txt:
* inspector/indexeddb/requestDatabaseNames.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt
trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace.html
trunk/LayoutTests/inspector/indexeddb/requestDatabaseNames-expected.txt
trunk/LayoutTests/inspector/indexeddb/requestDatabaseNames.html




Diff

Modified: trunk/LayoutTests/ChangeLog (205038 => 205039)

--- trunk/LayoutTests/ChangeLog	2016-08-26 20:54:19 UTC (rev 205038)
+++ trunk/LayoutTests/ChangeLog	2016-08-26 20:59:01 UTC (rev 205039)
@@ -1,3 +1,15 @@
+2016-08-25  Joseph Pecoraro  
+
+Web Inspector: Modernize inspector/indexeddb tests
+https://bugs.webkit.org/show_bug.cgi?id=161113
+
+Reviewed by Brian Burg.
+
+* inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt:
+* inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
+* inspector/indexeddb/requestDatabaseNames-expected.txt:
+* inspector/indexeddb/requestDatabaseNames.html:
+
 2016-08-26  Jiewen Tan  
 
 Unreviewed, rebase iOS simulator WK1 http tests


Modified: trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt (205038 => 205039)

--- trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt	2016-08-26 20:54:19 UTC (rev 205038)
+++ trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt	2016-08-26 20:59:01 UTC (rev 205039)
@@ -1,10 +1,15 @@
-CONSOLE MESSAGE: line 11: Created Database 'Database With Space'
+CONSOLE MESSAGE: line 9: Created Database 'Database With Space'
 
-PASS: No IndexedDB databases should exist initially
-[]
-Created Database 'Database With Space'
-PASS: A single IndexedDB database should exist
+== Running test suite: IndexedDB.requestDatabaseNames.spaces
+-- Running test case: ClearDatabases
+-- Running test case: EnsureNoDatabases
+PASS: No IndexedDB databases should exist initially.
+
+-- Running test case: CreateDatabaseWithSpacesInName
+PASS: A single IndexedDB database should exist.
 ["Database With Space"]
-PASS: No IndexedDB databases should exist at the end because we just deleted them
+
+-- Running test case: DeleteDatabaseWithSpacesInName
+PASS: No IndexedDB databases should exist because we just deleted them.
 []
 


Modified: trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace.html (205038 => 205039)

--- trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace.html	2016-08-26 20:54:19 UTC (rev 205038)
+++ trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace.html	2016-08-26 20:59:01 UTC (rev 205039)
@@ -3,83 +3,76 @@