date:20161007

[webkit-changes] [206903] trunk/Source/WebCore

2016-10-07 Thread commit-queue

Title: [206903] trunk/Source/WebCore








Revision 206903
Author commit-qu...@webkit.org
Date 2016-10-07 00:02:02 -0700 (Fri, 07 Oct 2016)


Log Message
Refactor CachedResourceClient::notifyFinished
https://bugs.webkit.org/show_bug.cgi?id=162060

Patch by Youenn Fablet  on 2016-10-07
Reviewed by Darin Adler.

No change of behavior.

Making CachedResourceClient and CachedRawResourceClient callbacks take CachedResource references and not pointers.
In most cases, the CachedResource parameter is only used for assertions.
Removing that parameter might be contemplated in the future.
The only real case is in RenderImage.

Removed the CachedResource parameter from ContentFilter methods as code was calling these methods with null values.

* dom/LoadableClassicScript.cpp:
(WebCore::LoadableClassicScript::notifyFinished):
* dom/LoadableClassicScript.h:
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::notifyFinished):
* html/HTMLImageLoader.h:
* loader/ContentFilter.cpp:
(WebCore::ContentFilter::continueAfterResponseReceived):
(WebCore::ContentFilter::continueAfterDataReceived):
(WebCore::ContentFilter::continueAfterNotifyFinished):
(WebCore::ContentFilter::deliverResourceData):
* loader/ContentFilter.h:
* loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::notifyFinished):
* loader/CrossOriginPreflightChecker.h:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::notifyFinished):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::dataReceived):
* loader/DocumentLoader.h:
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived):
(WebCore::DocumentThreadableLoader::dataSent):
(WebCore::DocumentThreadableLoader::responseReceived):
(WebCore::DocumentThreadableLoader::dataReceived):
(WebCore::DocumentThreadableLoader::notifyFinished):
* loader/DocumentThreadableLoader.h:
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
* loader/ImageLoader.h:
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::triggerEvents):
(WebCore::LinkLoader::notifyFinished):
* loader/LinkLoader.h:
* loader/LinkPreloadResourceClients.cpp:
(WebCore::LinkPreloadResourceClient::triggerEvents):
* loader/LinkPreloadResourceClients.h:
* loader/MediaResourceLoader.cpp:
(WebCore::MediaResource::responseReceived):
(WebCore::MediaResource::shouldCacheResponse):
(WebCore::MediaResource::redirectReceived):
(WebCore::MediaResource::dataSent):
(WebCore::MediaResource::dataReceived):
(WebCore::MediaResource::notifyFinished):
(WebCore::MediaResource::getOrCreateReadBuffer):
* loader/MediaResourceLoader.h:
* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::processNewCueData):
(WebCore::TextTrackLoader::deprecatedDidReceiveCachedResource):
(WebCore::TextTrackLoader::notifyFinished):
* loader/TextTrackLoader.h:
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::notifyClientsDataWasReceived):
(WebCore::CachedRawResource::didAddClient):
(WebCore::CachedRawResource::redirectReceived):
(WebCore::CachedRawResource::responseReceived):
(WebCore::CachedRawResource::shouldCacheResponse):
(WebCore::CachedRawResource::didSendData):
* loader/cache/CachedRawResourceClient.h:
(WebCore::CachedRawResourceClient::dataSent):
(WebCore::CachedRawResourceClient::responseReceived):
(WebCore::CachedRawResourceClient::shouldCacheResponse):
(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::getOrCreateReadBuffer):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::checkNotify):
(WebCore::CachedResource::didAddClient):
* loader/cache/CachedResourceClient.h:
(WebCore::CachedResourceClient::notifyFinished):
(WebCore::CachedResourceClient::deprecatedDidReceiveCachedResource):
* loader/cache/CachedTextTrack.cpp:
(WebCore::CachedTextTrack::updateData):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::notifyFinished):
* loader/icon/IconLoader.h:
* loader/soup/CachedRawResourceSoup.cpp:
* platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::responseReceived):
(WebCore::WebCoreAVCFResourceLoader::dataReceived):
(WebCore::WebCoreAVCFResourceLoader::notifyFinished):
(WebCore::WebCoreAVCFResourceLoader::fulfillRequestWithResource):
* platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.h:
* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::responseReceived):
(WebCore::WebCoreAVFResourceLoader::dataReceived):
(WebCore::WebCoreAVFResourceLoader::notifyFinished):
(WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::notifyFinished):
* rendering/RenderImage.h:
* rendering/RenderLayerFilterInfo.cpp:

[webkit-changes] [206904] trunk

2016-10-07 Thread commit-queue

Title: [206904] trunk








Revision 206904
Author commit-qu...@webkit.org
Date 2016-10-07 00:56:29 -0700 (Fri, 07 Oct 2016)


Log Message
Use 'use lib $FindBin::Bin' to append Perl module include path
https://bugs.webkit.org/show_bug.cgi?id=162256

Patch by Fujii Hironori  on 2016-10-07
Reviewed by Carlos Garcia Campos.

.:

* Source/cmake/WebKitMacros.cmake: Removed '-I' options from
invocation of Perl.

Source/WebCore:

Some Perl  scripts are needed to  be executed with '-I'  switch to
explicitly append Perl module include path.  Use 'use lib' as well
as other Perl scripts do.

* CMakeLists.txt: Removed '-I' options from invocation of Perl.
* DerivedSources.make: Ditto.
* bindings/scripts/generate-bindings.pl: Use 'use lib'.
* bindings/scripts/preprocess-idls.pl: Ditto.
* css/make-css-file-arrays.pl: Ditto.
* css/makegrammar.pl: Ditto.
* css/makeprop.pl: Ditto.
* css/makevalues.pl: Ditto.
* dom/make_dom_exceptions.pl: Ditto.
* dom/make_event_factory.pl: Ditto.
* dom/make_names.pl: Ditto.
* page/make_settings.pl: Ditto.

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/bindings/scripts/generate-bindings.pl
trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl
trunk/Source/WebCore/css/make-css-file-arrays.pl
trunk/Source/WebCore/css/makegrammar.pl
trunk/Source/WebCore/css/makeprop.pl
trunk/Source/WebCore/css/makevalues.pl
trunk/Source/WebCore/dom/make_dom_exceptions.pl
trunk/Source/WebCore/dom/make_event_factory.pl
trunk/Source/WebCore/dom/make_names.pl
trunk/Source/WebCore/page/make_settings.pl
trunk/Source/cmake/WebKitMacros.cmake




Diff

Modified: trunk/ChangeLog (206903 => 206904)

--- trunk/ChangeLog	2016-10-07 07:02:02 UTC (rev 206903)
+++ trunk/ChangeLog	2016-10-07 07:56:29 UTC (rev 206904)
@@ -1,3 +1,13 @@
+2016-10-07  Fujii Hironori  
+
+Use 'use lib $FindBin::Bin' to append Perl module include path
+https://bugs.webkit.org/show_bug.cgi?id=162256
+
+Reviewed by Carlos Garcia Campos.
+
+* Source/cmake/WebKitMacros.cmake: Removed '-I' options from
+invocation of Perl.
+
 2016-10-06  Brent Fulgham  
 
 [Win][Direct2D] Add Direct2D CMake rules


Modified: trunk/Source/WebCore/CMakeLists.txt (206903 => 206904)

--- trunk/Source/WebCore/CMakeLists.txt	2016-10-07 07:02:02 UTC (rev 206903)
+++ trunk/Source/WebCore/CMakeLists.txt	2016-10-07 07:56:29 UTC (rev 206904)
@@ -3534,7 +3534,7 @@
 DEPENDS ${WebCore_CSS_PROPERTY_NAMES}
 WORKING_DIRECTORY ${DERIVED_SOURCES_WEBCORE_DIR}
 COMMAND ${PERL_EXECUTABLE} -ne "print" ${WebCore_CSS_PROPERTY_NAMES} > ${DERIVED_SOURCES_WEBCORE_DIR}/CSSPropertyNames.in
-COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/css/makeprop.pl --defines "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}" --preprocessor "${CODE_GENERATOR_PREPROCESSOR}" --gperf-executable "${GPERF_EXECUTABLE}"
+COMMAND ${PERL_EXECUTABLE} ${WEBCORE_DIR}/css/makeprop.pl --defines "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}" --preprocessor "${CODE_GENERATOR_PREPROCESSOR}" --gperf-executable "${GPERF_EXECUTABLE}"
 VERBATIM)
 list(APPEND WebCore_DERIVED_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/CSSPropertyNames.cpp)
 list(APPEND WebCore_DERIVED_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/StyleBuilder.cpp)
@@ -3549,7 +3549,7 @@
 DEPENDS ${WebCore_CSS_VALUE_KEYWORDS}
 WORKING_DIRECTORY ${DERIVED_SOURCES_WEBCORE_DIR}
 COMMAND ${PERL_EXECUTABLE} -ne "print" ${WebCore_CSS_VALUE_KEYWORDS} > ${DERIVED_SOURCES_WEBCORE_DIR}/CSSValueKeywords.in
-COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/css/makevalues.pl --defines "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}" --preprocessor "${CODE_GENERATOR_PREPROCESSOR}"
+COMMAND ${PERL_EXECUTABLE} ${WEBCORE_DIR}/css/makevalues.pl --defines "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}" --preprocessor "${CODE_GENERATOR_PREPROCESSOR}"
 VERBATIM)
 list(APPEND WebCore_DERIVED_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/CSSValueKeywords.cpp)
 ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES(${WEBCORE_DIR}/css/CSSParser.cpp CSSValueKeywords.h)
@@ -3577,7 +3577,7 @@
 OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/UserAgentStyleSheetsData.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/UserAgentStyleSheets.h
 MAIN_DEPENDENCY ${WEBCORE_DIR}/css/make-css-file-arrays.pl
 DEPENDS ${WebCore_USER_AGENT_STYLE_SHEETS} ${WEBCORE_DIR}/bindings/scripts/preprocessor.pm
-COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/css/make-css-file-arrays.pl --defines "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}" --preprocessor "${CODE_GENERATOR_PREPROCESSOR}" ${DERIVED_SOURCES_WEBCORE_DIR}/UserAgentStyleSheets.h ${DERIVED_SOURCES_WEBCORE_DIR}/UserAgentStyleSheetsData.cpp ${WebCore_USER_AGENT_STYLE_SHEETS}
+COMMAND ${PERL_EXECUTABLE} ${WEBCORE_DIR}/css/make-css-file-arrays.pl --defines "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}" --preprocessor "${CODE_GENERATOR_PREPROCESS

[webkit-changes] [206905] trunk/Tools

2016-10-07 Thread philn

Title: [206905] trunk/Tools








Revision 206905
Author ph...@webkit.org
Date 2016-10-07 01:20:20 -0700 (Fri, 07 Oct 2016)


Log Message
[GTK] Docs build failure
https://bugs.webkit.org/show_bug.cgi?id=163102

Reviewed by Carlos Garcia Campos.

* gtk/jhbuild.modules: Bump to gtk-doc 1.25 to fix build errors on Debian Testing.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (206904 => 206905)

--- trunk/Tools/ChangeLog	2016-10-07 07:56:29 UTC (rev 206904)
+++ trunk/Tools/ChangeLog	2016-10-07 08:20:20 UTC (rev 206905)
@@ -1,3 +1,12 @@
+2016-10-07  Philippe Normand  
+
+[GTK] Docs build failure
+https://bugs.webkit.org/show_bug.cgi?id=163102
+
+Reviewed by Carlos Garcia Campos.
+
+* gtk/jhbuild.modules: Bump to gtk-doc 1.25 to fix build errors on Debian Testing.
+
 2016-10-06  Joseph Pecoraro  
 
 check-webkit-style: Enable the legal/copyright rule for cpp/h files


Modified: trunk/Tools/gtk/jhbuild.modules (206904 => 206905)

--- trunk/Tools/gtk/jhbuild.modules	2016-10-07 07:56:29 UTC (rev 206904)
+++ trunk/Tools/gtk/jhbuild.modules	2016-10-07 08:20:20 UTC (rev 206905)
@@ -461,9 +461,9 @@
 
   
 
-+ repo="ftp.gnome.org"
-hash="sha256:3e6ecf134dbf92a74c24d79848fea3a48e59ab95408a38c6405905d95a293011"/>
+hash="sha256:1ea46ed400e6501f975acaafea31479cea8f32f911dca4dff036f59e6464fd42"/>
   
 
   






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206906] trunk/Source/WebKit2

2016-10-07 Thread mcatanzaro

Title: [206906] trunk/Source/WebKit2








Revision 206906
Author mcatanz...@igalia.com
Date 2016-10-07 02:28:27 -0700 (Fri, 07 Oct 2016)


Log Message
[GTK] Expose WebKitDOMHTMLInputElement APIs for form autofill
https://bugs.webkit.org/show_bug.cgi?id=163082

Reviewed by Darin Adler.

* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp:
(webkit_dom_html_input_element_get_auto_filled): Added.
(webkit_dom_html_input_element_set_auto_filled): Added.
(webkit_dom_html_input_element_set_editing_value): Added.
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h:
* WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt




Diff

Modified: trunk/Source/WebKit2/ChangeLog (206905 => 206906)

--- trunk/Source/WebKit2/ChangeLog	2016-10-07 08:20:20 UTC (rev 206905)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-07 09:28:27 UTC (rev 206906)
@@ -1,3 +1,17 @@
+2016-10-06  Michael Catanzaro  
+
+[GTK] Expose WebKitDOMHTMLInputElement APIs for form autofill
+https://bugs.webkit.org/show_bug.cgi?id=163082
+
+Reviewed by Darin Adler.
+
+* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp:
+(webkit_dom_html_input_element_get_auto_filled): Added.
+(webkit_dom_html_input_element_set_auto_filled): Added.
+(webkit_dom_html_input_element_set_editing_value): Added.
+* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h:
+* WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt:
+
 2016-10-06  John Wilander  
 
 Update Resource Load Statistics


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp (206905 => 206906)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp	2016-10-07 08:20:20 UTC (rev 206905)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp	2016-10-07 09:28:27 UTC (rev 206906)
@@ -989,3 +989,25 @@
 
 return WebKit::core(input)->lastChangeWasUserEdit();
 }
+
+gboolean webkit_dom_html_input_element_get_auto_filled(WebKitDOMHTMLInputElement* self)
+{
+  g_return_val_if_fail(WEBKIT_DOM_IS_HTML_INPUT_ELEMENT(self), FALSE);
+
+  return WebKit::core(self)->isAutoFilled();
+}
+
+void webkit_dom_html_input_element_set_auto_filled(WebKitDOMHTMLInputElement* self, gboolean value)
+{
+  g_return_if_fail(WEBKIT_DOM_IS_HTML_INPUT_ELEMENT(self));
+
+  WebKit::core(self)->setAutoFilled(value);
+}
+
+void webkit_dom_html_input_element_set_editing_value(WebKitDOMHTMLInputElement* self, const gchar* value)
+{
+  g_return_if_fail(WEBKIT_DOM_IS_HTML_INPUT_ELEMENT(self));
+  g_return_if_fail(value);
+
+  WebKit::core(self)->setEditingValue(WTF::String::fromUTF8(value));
+}


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h (206905 => 206906)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h	2016-10-07 08:20:20 UTC (rev 206905)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h	2016-10-07 09:28:27 UTC (rev 206906)
@@ -487,6 +487,37 @@
  */
 WEBKIT_API gboolean webkit_dom_html_input_element_is_edited(WebKitDOMHTMLInputElement* input);
 
+/**
+ * webkit_dom_html_input_element_get_auto_filled:
+ * @self: A #WebKitDOMHTMLInputElement
+ *
+ * Returns: A #gboolean
+ *
+ * Since: 2.16
+ */
+WEBKIT_API gboolean
+webkit_dom_html_input_element_get_auto_filled(WebKitDOMHTMLInputElement* self);
+
+/**
+ * webkit_dom_html_input_element_set_auto_filled:
+ * @self: A #WebKitDOMHTMLInputElement
+ * @value: A #gboolean
+ *
+ * Since: 2.16
+ */
+WEBKIT_API void
+webkit_dom_html_input_element_set_auto_filled(WebKitDOMHTMLInputElement* self, gboolean value);
+
+/**
+ * webkit_dom_html_input_element_set_editing_value:
+ * @self: A #WebKitDOMHTMLInputElement
+ * @value: A #gchar
+ *
+ * Since: 2.16
+ */
+WEBKIT_API void
+webkit_dom_html_input_element_set_editing_value(WebKitDOMHTMLInputElement* self, const gchar* value);
+
 G_END_DECLS
 
 #endif /* WebKitDOMHTMLInputElement_h */


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt (206905 => 206906)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt	2016-10-07 08:20:20 UTC (rev 206905)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt	2016-10-07 09:28:27 UTC (rev 206906)
@@ -2063,6 +2063,9 @@
 webkit_dom_html_input_element_set_capture_type
 webkit_dom_html_input_element_get_capture
 webkit_dom_html_input_element_is_edit

[webkit-changes] [206907] trunk/Source/WebCore

2016-10-07 Thread yoon

Title: [206907] trunk/Source/WebCore








Revision 206907
Author y...@igalia.com
Date 2016-10-07 04:45:22 -0700 (Fri, 07 Oct 2016)


Log Message
[GTK] Remove unneeded creation of TextureMapperPlatformLayerProxy
https://bugs.webkit.org/show_bug.cgi?id=163101

Reviewed by Žan Doberšek.

Covered by existing tests.

* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData): Modified not to create
TextureMapperPlatformLayerProxy if it is not created for the
accelerated 2d canvas.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206906 => 206907)

--- trunk/Source/WebCore/ChangeLog	2016-10-07 09:28:27 UTC (rev 206906)
+++ trunk/Source/WebCore/ChangeLog	2016-10-07 11:45:22 UTC (rev 206907)
@@ -1,3 +1,17 @@
+2016-10-07  Gwang Yoon Hwang  
+
+[GTK] Remove unneeded creation of TextureMapperPlatformLayerProxy
+https://bugs.webkit.org/show_bug.cgi?id=163101
+
+Reviewed by Žan Doberšek.
+
+Covered by existing tests.
+
+* platform/graphics/cairo/ImageBufferCairo.cpp:
+(WebCore::ImageBufferData::ImageBufferData): Modified not to create
+TextureMapperPlatformLayerProxy if it is not created for the
+accelerated 2d canvas.
+
 2016-10-07  Fujii Hironori  
 
 Use 'use lib $FindBin::Bin' to append Perl module include path


Modified: trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp (206906 => 206907)

--- trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp	2016-10-07 09:28:27 UTC (rev 206906)
+++ trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp	2016-10-07 11:45:22 UTC (rev 206907)
@@ -74,12 +74,15 @@
 , m_renderingMode(renderingMode)
 #if ENABLE(ACCELERATED_2D_CANVAS)
 #if USE(COORDINATED_GRAPHICS_THREADED)
-, m_platformLayerProxy(adoptRef(new TextureMapperPlatformLayerProxy))
 , m_compositorTexture(0)
 #endif
 , m_texture(0)
 #endif
 {
+#if ENABLE(ACCELERATED_2D_CANVAS) && USE(COORDINATED_GRAPHICS_THREADED)
+if (m_renderingMode == RenderingMode::Accelerated)
+m_platformLayerProxy = adoptRef(new TextureMapperPlatformLayerProxy);
+#endif
 }
 
 ImageBufferData::~ImageBufferData()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206909] trunk/Source/WebKit2

2016-10-07 Thread commit-queue

Title: [206909] trunk/Source/WebKit2








Revision 206909
Author commit-qu...@webkit.org
Date 2016-10-07 05:04:21 -0700 (Fri, 07 Oct 2016)


Log Message
[GTK] UIProcess crashes when using Japanese IM
https://bugs.webkit.org/show_bug.cgi?id=163011

We have to reference the current GdkEventKey before we try process it
as later when the lambda body is reached the event could be already
freed.

Patch by Tomas Popela  on 2016-10-07
Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseKeyPressEvent):
(webkitWebViewBaseKeyReleaseEvent):
* UIProcess/gtk/InputMethodFilter.h:
Use non-copyable Function so we can use WTFMove to pass the event to
lambda.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit2/UIProcess/gtk/InputMethodFilter.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (206908 => 206909)

--- trunk/Source/WebKit2/ChangeLog	2016-10-07 11:57:30 UTC (rev 206908)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-07 12:04:21 UTC (rev 206909)
@@ -1,3 +1,21 @@
+2016-10-07  Tomas Popela  
+
+[GTK] UIProcess crashes when using Japanese IM
+https://bugs.webkit.org/show_bug.cgi?id=163011
+
+We have to reference the current GdkEventKey before we try process it
+as later when the lambda body is reached the event could be already
+freed.
+
+Reviewed by Carlos Garcia Campos.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseKeyPressEvent):
+(webkitWebViewBaseKeyReleaseEvent):
+* UIProcess/gtk/InputMethodFilter.h:
+Use non-copyable Function so we can use WTFMove to pass the event to
+lambda.
+
 2016-10-06  Michael Catanzaro  
 
 [GTK] Expose WebKitDOMHTMLInputElement APIs for form autofill


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (206908 => 206909)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2016-10-07 11:57:30 UTC (rev 206908)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2016-10-07 12:04:21 UTC (rev 206909)
@@ -674,17 +674,17 @@
 return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->focus_out_event(widget, event);
 }
 
-static gboolean webkitWebViewBaseKeyPressEvent(GtkWidget* widget, GdkEventKey* event)
+static gboolean webkitWebViewBaseKeyPressEvent(GtkWidget* widget, GdkEventKey* keyEvent)
 {
 WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(widget);
 WebKitWebViewBasePrivate* priv = webViewBase->priv;
 
 if (priv->authenticationDialog)
-return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_press_event(widget, event);
+return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_press_event(widget, keyEvent);
 
 #if ENABLE(FULLSCREEN_API)
 if (priv->fullScreenModeActive) {
-switch (event->keyval) {
+switch (keyEvent->keyval) {
 case GDK_KEY_Escape:
 case GDK_KEY_f:
 case GDK_KEY_F:
@@ -702,18 +702,20 @@
 // using gtk_main_do_event().
 if (priv->shouldForwardNextKeyEvent) {
 priv->shouldForwardNextKeyEvent = FALSE;
-return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_press_event(widget, event);
+return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_press_event(widget, keyEvent);
 }
 
-priv->inputMethodFilter.filterKeyEvent(event, [priv, event](const WebCore::CompositionResults& compositionResults, InputMethodFilter::EventFakedForComposition faked) {
-priv->pageProxy->handleKeyboardEvent(NativeWebKeyboardEvent(reinterpret_cast(event), compositionResults, faked,
-!compositionResults.compositionUpdated() ? priv->keyBindingTranslator.commandsForKeyEvent(event) : Vector()));
+// We need to copy the event as otherwise it could be destroyed before we reach the lambda body.
+GUniquePtr event(gdk_event_copy(reinterpret_cast(keyEvent)));
+priv->inputMethodFilter.filterKeyEvent(&event->key, [priv, event = WTFMove(event)](const WebCore::CompositionResults& compositionResults, InputMethodFilter::EventFakedForComposition faked) {
+priv->pageProxy->handleKeyboardEvent(NativeWebKeyboardEvent(event.get(), compositionResults, faked,
+!compositionResults.compositionUpdated() ? priv->keyBindingTranslator.commandsForKeyEvent(&event->key) : Vector()));
 });
 
 return TRUE;
 }
 
-static gboolean webkitWebViewBaseKeyReleaseEvent(GtkWidget* widget, GdkEventKey* event)
+static gboolean webkitWebViewBaseKeyReleaseEvent(GtkWidget* widget, GdkEventKey* keyEvent)
 {
 WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(widget);
 WebKitWebViewBasePrivate* priv = webViewBase->priv;
@@ -720,11 +722,13 @@
 
 if (priv->shouldForwardNextKeyEvent) {
 priv->shouldForwardNextKeyEvent = FALSE;
-return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_release_event(widget, event);
+retur

[webkit-changes] [206911] trunk/Tools

2016-10-07 Thread jbedard

Title: [206911] trunk/Tools








Revision 206911
Author jbed...@apple.com
Date 2016-10-07 08:00:57 -0700 (Fri, 07 Oct 2016)


Log Message
Style Checking Error when Objective C Blocks passed as Argument
https://bugs.webkit.org/show_bug.cgi?id=162463

Reviewed by Darin Adler.

* Scripts/webkitpy/style/checkers/cpp.py:
(regex_for_lambdas_and_blocks): Consider case where block is passed as a function argument.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_objective_c_block_as_argument): Test case where block is passed as a function argument.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (206910 => 206911)

--- trunk/Tools/ChangeLog	2016-10-07 12:50:21 UTC (rev 206910)
+++ trunk/Tools/ChangeLog	2016-10-07 15:00:57 UTC (rev 206911)
@@ -1,3 +1,15 @@
+2016-10-07  Jonathan Bedard  
+
+Style Checking Error when Objective C Blocks passed as Argument
+https://bugs.webkit.org/show_bug.cgi?id=162463
+
+Reviewed by Darin Adler.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(regex_for_lambdas_and_blocks): Consider case where block is passed as a function argument.
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+(CppStyleTest.test_objective_c_block_as_argument): Test case where block is passed as a function argument. 
+
 2016-10-07  Philippe Normand  
 
 [GTK] Docs build failure


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (206910 => 206911)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2016-10-07 12:50:21 UTC (rev 206910)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2016-10-07 15:00:57 UTC (rev 206911)
@@ -1244,7 +1244,7 @@
 
 def regex_for_lambdas_and_blocks(line, line_number, file_state, error):
 cpp_result = search(r'\s\[.*?\]\s', line)
-objc_result = search(r'(\s\^\s?\(.*?\)\s|\^\s?\{)', line)
+objc_result = search(r'(\s\^\s?\(.*?\)\s|\^\s?\{|:\^\s?\(.*?\)\s\{)', line)
 if cpp_result:
 group = cpp_result.group()
 targ_error = None


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (206910 => 206911)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2016-10-07 12:50:21 UTC (rev 206910)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2016-10-07 15:00:57 UTC (rev 206911)
@@ -1905,6 +1905,11 @@
 self.assert_lint('^{', 'No space between ^ and block definition.  [whitespace/brackets] [4]', 'foo.m')
 self.assert_lint('^ (arg1, arg2) {', 'Extra space between ^ and block arguments.  [whitespace/brackets] [4]', 'foo.m')
 
+def test_objective_c_block_as_argument(self):
+self.assert_lint('withLambda:^(var, var_ref) {', '', 'foo.mm')
+self.assert_lint('withLambda:^ {', '', 'foo.m')
+self.assert_lint('withLambda:^{', 'No space between ^ and block definition.  [whitespace/brackets] [4]', 'foo.m')
+
 def test_spacing_around_else(self):
 self.assert_lint('}else {', 'Missing space before else'
  '  [whitespace/braces] [5]')






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206912] trunk/Source/WebCore

2016-10-07 Thread commit-queue

Title: [206912] trunk/Source/WebCore








Revision 206912
Author commit-qu...@webkit.org
Date 2016-10-07 08:10:46 -0700 (Fri, 07 Oct 2016)


Log Message
[Readable Streams API] Implement generic reader functions
https://bugs.webkit.org/show_bug.cgi?id=163003

Patch by Romain Bellessort  on 2016-10-07
Reviewed by Darin Adler.

Implements reader generic functions defined by spec in order to prepare BYOBReader integration.
Generic functions factorize some code that is used by both DefaultReader and BYOBReader.

No change in behaviour.

* Modules/streams/ReadableStreamDefaultReader.js:
(cancel): Rely on readableStreamReaderGenericCancel.
(releaseLock): Rely on readableStreamReaderGenericRelease.
* Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamDefaultReader): Rely on readableStreamReaderGenericInitialize.
(readableStreamReaderGenericInitialize): Added.
(readableStreamReaderGenericCancel): Added.
(readableStreamReaderGenericRelease): Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js
trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (206911 => 206912)

--- trunk/Source/WebCore/ChangeLog	2016-10-07 15:00:57 UTC (rev 206911)
+++ trunk/Source/WebCore/ChangeLog	2016-10-07 15:10:46 UTC (rev 206912)
@@ -1,3 +1,24 @@
+2016-10-07  Romain Bellessort  
+
+[Readable Streams API] Implement generic reader functions
+https://bugs.webkit.org/show_bug.cgi?id=163003
+
+Reviewed by Darin Adler.
+
+Implements reader generic functions defined by spec in order to prepare BYOBReader integration.
+Generic functions factorize some code that is used by both DefaultReader and BYOBReader.
+
+No change in behaviour.
+
+* Modules/streams/ReadableStreamDefaultReader.js:
+(cancel): Rely on readableStreamReaderGenericCancel.
+(releaseLock): Rely on readableStreamReaderGenericRelease.
+* Modules/streams/ReadableStreamInternals.js:
+(privateInitializeReadableStreamDefaultReader): Rely on readableStreamReaderGenericInitialize.
+(readableStreamReaderGenericInitialize): Added.
+(readableStreamReaderGenericCancel): Added.
+(readableStreamReaderGenericRelease): Added.
+
 2016-10-07  Adam Bergkvist  
 
 WebRTC: Misc gardening: Use typedefs consistently and remove unused code


Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js (206911 => 206912)

--- trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js	2016-10-07 15:00:57 UTC (rev 206911)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js	2016-10-07 15:10:46 UTC (rev 206912)
@@ -35,7 +35,7 @@
 if (!this.@ownerReadableStream)
 return @Promise.@reject(new @TypeError("cancel() called on a reader owned by no readable stream"));
 
-return @readableStreamCancel(this.@ownerReadableStream, reason);
+return @readableStreamReaderGenericCancel(this, reason);
 }
 
 function read()
@@ -57,20 +57,13 @@
 if (!@isReadableStreamDefaultReader(this))
 throw @makeThisTypeError("ReadableStreamDefaultReader", "releaseLock");
 
-const stream = this.@ownerReadableStream;
-if (!stream)
- return;
+if (!this.@ownerReadableStream)
+return;
 
 if (this.@readRequests.length)
 @throwTypeError("There are still pending read requests, cannot release the lock");
 
-if (stream.@state === @streamReadable)
-this.@closedPromiseCapability.@reject.@call(@undefined, new @TypeError("releasing lock of reader whose stream is still in readable state"));
-else
-this.@closedPromiseCapability = { @promise: @Promise.@reject(new @TypeError("reader released lock")) };
-
-stream.@reader = @undefined;
-this.@ownerReadableStream = null;
+@readableStreamReaderGenericRelease(this);
 }
 
 function closed()


Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js (206911 => 206912)

--- trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js	2016-10-07 15:00:57 UTC (rev 206911)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js	2016-10-07 15:10:46 UTC (rev 206912)
@@ -36,23 +36,28 @@
 if (@isReadableStreamLocked(stream))
@throwTypeError("ReadableStream is locked");
 
+@readableStreamReaderGenericInitialize(this, stream);
 this.@readRequests = [];
-this.@ownerReadableStream = stream;
-stream.@reader = this;
-if (stream.@state === @streamReadable) {
-this.@closedPromiseCapability = @newPromiseCapability(@Promise);
-return this;
-}
-if (stream.@state === @streamClosed) {
-this.@closedPromiseCapability = { @promise: @Promise.@resolve() };
-return this;
-}
-@assert(stream.@state === @streamErrored);
-this.@closedPromiseCapability = { @promise: @Promise.@reject(stream.@storedError) };

[webkit-changes] [206913] trunk/Source/WebKit2

2016-10-07 Thread carlosgc

Title: [206913] trunk/Source/WebKit2








Revision 206913
Author carlo...@webkit.org
Date 2016-10-07 09:32:42 -0700 (Fri, 07 Oct 2016)


Log Message
Network Session: Allow NetworkDataTask decide what to do when override is allowed for a download
https://bugs.webkit.org/show_bug.cgi?id=163010

Reviewed by Alex Christensen.

Current code always deletes the file before starting a download when allow override is True. In soup backend we
use glib API that takes care of it and tries to ensure that the original file is not deleted if the new file
creation fails for whatever reason.

* NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::continueDecidePendingDownloadDestination): Pass allowOverride to setPendingDownloadLocation().
* NetworkProcess/NetworkDataTask.h:
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::setPendingDownloadLocation): Delete the destination file if exists and allowOverride
is True.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/Downloads/DownloadManager.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.h
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (206912 => 206913)

--- trunk/Source/WebKit2/ChangeLog	2016-10-07 15:10:46 UTC (rev 206912)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-07 16:32:42 UTC (rev 206913)
@@ -1,3 +1,21 @@
+2016-10-07  Carlos Garcia Campos  
+
+Network Session: Allow NetworkDataTask decide what to do when override is allowed for a download
+https://bugs.webkit.org/show_bug.cgi?id=163010
+
+Reviewed by Alex Christensen.
+
+Current code always deletes the file before starting a download when allow override is True. In soup backend we
+use glib API that takes care of it and tries to ensure that the original file is not deleted if the new file
+creation fails for whatever reason.
+
+* NetworkProcess/Downloads/DownloadManager.cpp:
+(WebKit::DownloadManager::continueDecidePendingDownloadDestination): Pass allowOverride to setPendingDownloadLocation().
+* NetworkProcess/NetworkDataTask.h:
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::NetworkDataTask::setPendingDownloadLocation): Delete the destination file if exists and allowOverride
+is True.
+
 2016-10-07  Tomas Popela  
 
 [GTK] UIProcess crashes when using Japanese IM


Modified: trunk/Source/WebKit2/NetworkProcess/Downloads/DownloadManager.cpp (206912 => 206913)

--- trunk/Source/WebKit2/NetworkProcess/Downloads/DownloadManager.cpp	2016-10-07 15:10:46 UTC (rev 206912)
+++ trunk/Source/WebKit2/NetworkProcess/Downloads/DownloadManager.cpp	2016-10-07 16:32:42 UTC (rev 206913)
@@ -128,11 +128,7 @@
 if (!networkDataTask || !completionHandler)
 return;
 
-networkDataTask->setPendingDownloadLocation(destination, sandboxExtensionHandle);
-
-if (allowOverwrite && fileExists(destination))
-deleteFile(destination);
-
+networkDataTask->setPendingDownloadLocation(destination, sandboxExtensionHandle, allowOverwrite);
 completionHandler(PolicyDownload);
 
 ASSERT(!m_downloadsAfterDestinationDecided.contains(downloadID));


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.h (206912 => 206913)

--- trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.h	2016-10-07 15:10:46 UTC (rev 206912)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.h	2016-10-07 16:32:42 UTC (rev 206913)
@@ -121,7 +121,7 @@
 ASSERT(!m_pendingDownload);
 m_pendingDownload = &pendingDownload;
 }
-void setPendingDownloadLocation(const String& filename, const SandboxExtension::Handle&);
+void setPendingDownloadLocation(const String& filename, const SandboxExtension::Handle&, bool allowOverwrite);
 const String& pendingDownloadLocation() { return m_pendingDownloadLocation; }
 
 const WebCore::ResourceRequest& firstRequest() const { return m_firstRequest; }


Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (206912 => 206913)

--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2016-10-07 15:10:46 UTC (rev 206912)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2016-10-07 16:32:42 UTC (rev 206913)
@@ -36,6 +36,7 @@
 #import "WebCoreArgumentCoders.h"
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -268,7 +269,7 @@
 ASSERT_NOT_REACHED();
 }
 
-void NetworkDataTask::setPendingDownloadLocation(const WTF::String& filename, const SandboxExtension::Handle& sandboxExtensionHandle)
+void NetworkDataTask::setPendingDownloadLocation(const WTF::String& filename, const SandboxExtension::Handle& sandboxExtensionHandle, bool allowOverwrite)
 {
 ASSERT(!m_sandboxExtension);
 m_sandboxExtension = SandboxExtension::create(sandboxExtensionHandle);
@@ -277,6 +278,9 @@
 
 m_pendingDownloadLocation =

[webkit-changes] [206914] trunk/LayoutTests

2016-10-07 Thread ryanhaddad

Title: [206914] trunk/LayoutTests








Revision 206914
Author ryanhad...@apple.com
Date 2016-10-07 09:35:37 -0700 (Fri, 07 Oct 2016)


Log Message
Marking contentextensions tests as flaky on mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=162942

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (206913 => 206914)

--- trunk/LayoutTests/ChangeLog	2016-10-07 16:32:42 UTC (rev 206913)
+++ trunk/LayoutTests/ChangeLog	2016-10-07 16:35:37 UTC (rev 206914)
@@ -1,3 +1,12 @@
+2016-10-07  Ryan Haddad  
+
+Marking contentextensions tests as flaky on mac-wk2.
+https://bugs.webkit.org/show_bug.cgi?id=162942
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2016-10-07  Adam Bergkvist  
 
 WebRTC: Test gardening


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (206913 => 206914)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2016-10-07 16:32:42 UTC (rev 206913)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2016-10-07 16:35:37 UTC (rev 206914)
@@ -436,8 +436,8 @@
 
 
 # Content Extensions tests must be enabled explicitly on mac-wk2.
-http/tests/contentextensions [ Pass ]
-http/tests/websocket/tests/hybi/contentextensions [ Pass ]
+http/tests/contentextensions [ Pass Failure ]
+http/tests/websocket/tests/hybi/contentextensions [ Pass Failure ]
 webkit.org/b/146400 http/tests/contentextensions/character-set-basic-support.html [ Pass Failure ]
 
 # WebKit1-only failure.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206915] trunk/Source/WebKit2

2016-10-07 Thread commit-queue

Title: [206915] trunk/Source/WebKit2








Revision 206915
Author commit-qu...@webkit.org
Date 2016-10-07 09:39:21 -0700 (Fri, 07 Oct 2016)


Log Message
Unreviewed, rolling out r206909.
https://bugs.webkit.org/show_bug.cgi?id=163116

Caused most of  GTK layout tests to crash (Requested by KaL on
#webkit).

Reverted changeset:

"[GTK] UIProcess crashes when using Japanese IM"
https://bugs.webkit.org/show_bug.cgi?id=163011
http://trac.webkit.org/changeset/206909

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit2/UIProcess/gtk/InputMethodFilter.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (206914 => 206915)

--- trunk/Source/WebKit2/ChangeLog	2016-10-07 16:35:37 UTC (rev 206914)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-07 16:39:21 UTC (rev 206915)
@@ -1,3 +1,17 @@
+2016-10-07  Commit Queue  
+
+Unreviewed, rolling out r206909.
+https://bugs.webkit.org/show_bug.cgi?id=163116
+
+Caused most of  GTK layout tests to crash (Requested by KaL on
+#webkit).
+
+Reverted changeset:
+
+"[GTK] UIProcess crashes when using Japanese IM"
+https://bugs.webkit.org/show_bug.cgi?id=163011
+http://trac.webkit.org/changeset/206909
+
 2016-10-07  Carlos Garcia Campos  
 
 Network Session: Allow NetworkDataTask decide what to do when override is allowed for a download


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (206914 => 206915)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2016-10-07 16:35:37 UTC (rev 206914)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2016-10-07 16:39:21 UTC (rev 206915)
@@ -674,17 +674,17 @@
 return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->focus_out_event(widget, event);
 }
 
-static gboolean webkitWebViewBaseKeyPressEvent(GtkWidget* widget, GdkEventKey* keyEvent)
+static gboolean webkitWebViewBaseKeyPressEvent(GtkWidget* widget, GdkEventKey* event)
 {
 WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(widget);
 WebKitWebViewBasePrivate* priv = webViewBase->priv;
 
 if (priv->authenticationDialog)
-return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_press_event(widget, keyEvent);
+return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_press_event(widget, event);
 
 #if ENABLE(FULLSCREEN_API)
 if (priv->fullScreenModeActive) {
-switch (keyEvent->keyval) {
+switch (event->keyval) {
 case GDK_KEY_Escape:
 case GDK_KEY_f:
 case GDK_KEY_F:
@@ -702,20 +702,18 @@
 // using gtk_main_do_event().
 if (priv->shouldForwardNextKeyEvent) {
 priv->shouldForwardNextKeyEvent = FALSE;
-return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_press_event(widget, keyEvent);
+return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_press_event(widget, event);
 }
 
-// We need to copy the event as otherwise it could be destroyed before we reach the lambda body.
-GUniquePtr event(gdk_event_copy(reinterpret_cast(keyEvent)));
-priv->inputMethodFilter.filterKeyEvent(&event->key, [priv, event = WTFMove(event)](const WebCore::CompositionResults& compositionResults, InputMethodFilter::EventFakedForComposition faked) {
-priv->pageProxy->handleKeyboardEvent(NativeWebKeyboardEvent(event.get(), compositionResults, faked,
-!compositionResults.compositionUpdated() ? priv->keyBindingTranslator.commandsForKeyEvent(&event->key) : Vector()));
+priv->inputMethodFilter.filterKeyEvent(event, [priv, event](const WebCore::CompositionResults& compositionResults, InputMethodFilter::EventFakedForComposition faked) {
+priv->pageProxy->handleKeyboardEvent(NativeWebKeyboardEvent(reinterpret_cast(event), compositionResults, faked,
+!compositionResults.compositionUpdated() ? priv->keyBindingTranslator.commandsForKeyEvent(event) : Vector()));
 });
 
 return TRUE;
 }
 
-static gboolean webkitWebViewBaseKeyReleaseEvent(GtkWidget* widget, GdkEventKey* keyEvent)
+static gboolean webkitWebViewBaseKeyReleaseEvent(GtkWidget* widget, GdkEventKey* event)
 {
 WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(widget);
 WebKitWebViewBasePrivate* priv = webViewBase->priv;
@@ -722,13 +720,11 @@
 
 if (priv->shouldForwardNextKeyEvent) {
 priv->shouldForwardNextKeyEvent = FALSE;
-return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_release_event(widget, keyEvent);
+return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_release_event(widget, event);
 }
 
-// We need to copy the event as otherwise it could be destroyed before we reach the lambda body.
-GUniquePtr event(gdk_event_copy(reinterpret_cast(keyEvent)));
-priv->inputMethodFilter.filterKeyEvent(&event->key, [priv, event = WTFMove(event)](const WebCore::CompositionResults& compositionResults, Inpu

[webkit-changes] [206916] trunk

2016-10-07 Thread zalan

Title: [206916] trunk








Revision 206916
Author za...@apple.com
Date 2016-10-07 09:41:48 -0700 (Fri, 07 Oct 2016)


Log Message
https://vuldb.com/?cvssv3.2012 takes long time to load.
https://bugs.webkit.org/show_bug.cgi?id=162994


Reviewed by Darin Adler.

Source/WebCore:

Stop visiting cousins when we hit the style sharing search threshold.

In addition to mistakenly ignoring the threshold at SharingResolver::findSibling(), we
continued on searching for cousin elements.

Test: fast/selectors/slow-style-sharing-with-long-cousin-list.html

* style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::resolve):
(WebCore::Style::SharingResolver::findSibling):
(WebCore::Style::SharingResolver::locateCousinList):

LayoutTests:

It takes ~100 seconds to run this test case without the fix (300ms with the fix).
Surely it will timeout if it gets regressed.

* fast/selectors/slow-style-sharing-with-long-cousin-list-expected.txt: Added.
* fast/selectors/slow-style-sharing-with-long-cousin-list.html: Added.
* platform/mac/TestExpectations: Skip perf test in debug.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleSharingResolver.cpp


Added Paths

trunk/LayoutTests/fast/selectors/slow-style-sharing-with-long-cousin-list-expected.txt
trunk/LayoutTests/fast/selectors/slow-style-sharing-with-long-cousin-list.html




Diff

Modified: trunk/LayoutTests/ChangeLog (206915 => 206916)

--- trunk/LayoutTests/ChangeLog	2016-10-07 16:39:21 UTC (rev 206915)
+++ trunk/LayoutTests/ChangeLog	2016-10-07 16:41:48 UTC (rev 206916)
@@ -1,3 +1,18 @@
+2016-10-07  Zalan Bujtas  
+
+https://vuldb.com/?cvssv3.2012 takes long time to load.
+https://bugs.webkit.org/show_bug.cgi?id=162994
+
+
+Reviewed by Darin Adler.
+
+It takes ~100 seconds to run this test case without the fix (300ms with the fix).
+Surely it will timeout if it gets regressed. 
+
+* fast/selectors/slow-style-sharing-with-long-cousin-list-expected.txt: Added.
+* fast/selectors/slow-style-sharing-with-long-cousin-list.html: Added.
+* platform/mac/TestExpectations: Skip perf test in debug.
+
 2016-10-07  Ryan Haddad  
 
 Marking contentextensions tests as flaky on mac-wk2.


Added: trunk/LayoutTests/fast/selectors/slow-style-sharing-with-long-cousin-list-expected.txt (0 => 206916)

--- trunk/LayoutTests/fast/selectors/slow-style-sharing-with-long-cousin-list-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/selectors/slow-style-sharing-with-long-cousin-list-expected.txt	2016-10-07 16:41:48 UTC (rev 206916)
@@ -0,0 +1 @@
+PASSED.


Added: trunk/LayoutTests/fast/selectors/slow-style-sharing-with-long-cousin-list.html (0 => 206916)

--- trunk/LayoutTests/fast/selectors/slow-style-sharing-with-long-cousin-list.html	(rev 0)
+++ trunk/LayoutTests/fast/selectors/slow-style-sharing-with-long-cousin-list.html	2016-10-07 16:41:48 UTC (rev 206916)
@@ -0,0 +1,28 @@
+
+
+
+This test will timeout if we regress style sharing with long cousin list.
+
+td:nth-child(2) {  
+  color: transparent;
+}
+
+
+
+
+
+
+if (window.testRunner)
+  testRunner.dumpAsText();
+var table = document.createElement("table");
+for (var i = 0; i < 3; ++i) {
+  var row = document.createElement("tr");
+  row.appendChild(document.createElement("td"));
+  row.appendChild(document.createElement("td"));
+  table.appendChild(row);
+}
+document.body.appendChild(table);
+document.body.offsetHeight;
+document.body.innerText = "PASSED.";
+
+
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac/TestExpectations (206915 => 206916)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-10-07 16:39:21 UTC (rev 206915)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-10-07 16:41:48 UTC (rev 206916)
@@ -1467,3 +1467,5 @@
 # rdar://problem/28586837
 fast/text/variations/order.html [ Crash ]
 animations/font-variation-settings-order.html [ Crash ]
+
+[ Debug ] fast/selectors/slow-style-sharing-with-long-cousin-list.html [ Skip ]


Modified: trunk/Source/WebCore/ChangeLog (206915 => 206916)

--- trunk/Source/WebCore/ChangeLog	2016-10-07 16:39:21 UTC (rev 206915)
+++ trunk/Source/WebCore/ChangeLog	2016-10-07 16:41:48 UTC (rev 206916)
@@ -1,3 +1,23 @@
+2016-10-07  Zalan Bujtas  
+
+https://vuldb.com/?cvssv3.2012 takes long time to load.
+https://bugs.webkit.org/show_bug.cgi?id=162994
+
+
+Reviewed by Darin Adler.
+
+Stop visiting cousins when we hit the style sharing search threshold.
+
+In addition to mistakenly ignoring the threshold at SharingResolver::findSibling(), we
+continued on searching for cousin elements. 
+
+Test: fast/selectors/slow-style-sharing-with-long-cousin-list.html
+
+* style/StyleSharingResolver.cpp:
+(WebCore::Style::SharingResolver::resolve):
+(WebCore::S

[webkit-changes] [206918] trunk/Tools

2016-10-07 Thread commit-queue

Title: [206918] trunk/Tools








Revision 206918
Author commit-qu...@webkit.org
Date 2016-10-07 10:04:27 -0700 (Fri, 07 Oct 2016)


Log Message
Replace bug URL placeholders independently of the short desc one
https://bugs.webkit.org/show_bug.cgi?id=161684

Patch by Emanuele Aina  on 2016-10-07
Reviewed by Darin Adler.

Instead of adding the bug URL when replacing the short description
placeholder and then ignoring the bug URL placeholder, use the former
to set the short description and the latter for the bug URL.
This means that developers can fully prepare the changelog with short
and long description before submission leaving the bug placeholder in
place, and the changelog machinery will make sure to replace the
latter with the URL of the newly created bug while submitting.

Note that this also means that the short description placeholder alone
no longer causes the bug URL to be added.

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.set_short_description_and_bug_url):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_set_short_description_and_bug_url):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py
trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (206917 => 206918)

--- trunk/Tools/ChangeLog	2016-10-07 16:55:11 UTC (rev 206917)
+++ trunk/Tools/ChangeLog	2016-10-07 17:04:27 UTC (rev 206918)
@@ -1,3 +1,26 @@
+2016-10-07  Emanuele Aina  
+
+Replace bug URL placeholders independently of the short desc one
+https://bugs.webkit.org/show_bug.cgi?id=161684
+
+Reviewed by Darin Adler.
+
+Instead of adding the bug URL when replacing the short description
+placeholder and then ignoring the bug URL placeholder, use the former
+to set the short description and the latter for the bug URL.
+This means that developers can fully prepare the changelog with short
+and long description before submission leaving the bug placeholder in
+place, and the changelog machinery will make sure to replace the
+latter with the URL of the newly created bug while submitting.
+
+Note that this also means that the short description placeholder alone
+no longer causes the bug URL to be added.
+
+* Scripts/webkitpy/common/checkout/changelog.py:
+(ChangeLog.set_short_description_and_bug_url):
+* Scripts/webkitpy/common/checkout/changelog_unittest.py:
+(test_set_short_description_and_bug_url):
+
 2016-10-07  Jonathan Bedard  
 
 Style Checking Error when Objective C Blocks passed as Argument


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py (206917 => 206918)

--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py	2016-10-07 16:55:11 UTC (rev 206917)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py	2016-10-07 17:04:27 UTC (rev 206918)
@@ -430,14 +430,17 @@
 self._filesystem.write_text_file(self.path, newdata)
 
 def set_short_description_and_bug_url(self, short_description, bug_url):
-message = "%s\n%s%s" % (short_description, self._changelog_indent, bug_url)
-bug_boilerplate = "%sNeed the bug URL (OOPS!).\n" % self._changelog_indent
 result = StringIO()
 with self._filesystem.open_text_file_for_reading(self.path) as file:
+short_description_placeholder = "Need a short description (OOPS!)."
+bug_url_placeholder = "Need the bug URL (OOPS!)."
 for line in file:
-line = line.replace("Need a short description (OOPS!).", message)
-if line != bug_boilerplate:
-result.write(line)
+stripped = line.strip()
+if stripped == short_description_placeholder:
+line = self._changelog_indent + short_description + "\n"
+if stripped == bug_url_placeholder:
+line = self._changelog_indent + bug_url + "\n"
+result.write(line)
 self._filesystem.write_text_file(self.path, result.getvalue())
 
 def delete_entries(self, num_entries):


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py (206917 => 206918)

--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py	2016-10-07 16:55:11 UTC (rev 206917)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py	2016-10-07 17:04:27 UTC (rev 206918)
@@ -642,8 +642,7 @@
 bug_url = "http://example.com/b/2344"
 ChangeLog(self._changelog_path, fs).set_short_description_and_bug_url(short_description, bug_url)
 actual_contents = fs.read_text_file(self._changelog_path)
-expected_message = "%s\n%s" % (short_description, bug_url)
-expected_contents = changelog_contents.replace("Need a short description (OOPS!).", expected_message)
+expected_contents = changelog_contents.rep

[webkit-changes] [206919] trunk/LayoutTests

2016-10-07 Thread ryanhaddad

Title: [206919] trunk/LayoutTests








Revision 206919
Author ryanhad...@apple.com
Date 2016-10-07 10:15:13 -0700 (Fri, 07 Oct 2016)


Log Message
Marking imported/blink/storage/indexeddb/blob-valid-after-deletion.html as flaky on mac.
https://bugs.webkit.org/show_bug.cgi?id=163122

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (206918 => 206919)

--- trunk/LayoutTests/ChangeLog	2016-10-07 17:04:27 UTC (rev 206918)
+++ trunk/LayoutTests/ChangeLog	2016-10-07 17:15:13 UTC (rev 206919)
@@ -1,3 +1,12 @@
+2016-10-07  Ryan Haddad  
+
+Marking imported/blink/storage/indexeddb/blob-valid-after-deletion.html as flaky on mac.
+https://bugs.webkit.org/show_bug.cgi?id=163122
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2016-10-07  Zalan Bujtas  
 
 https://vuldb.com/?cvssv3.2012 takes long time to load.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (206918 => 206919)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-10-07 17:04:27 UTC (rev 206918)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-10-07 17:15:13 UTC (rev 206919)
@@ -1410,7 +1410,7 @@
 
 webkit.org/b/158500 storage/indexeddb/database-close-private.html [ Pass Failure ]
 
-webkit.org/b/158640 imported/blink/storage/indexeddb/blob-valid-after-deletion.html [ Pass Failure ]
+webkit.org/b/163122 imported/blink/storage/indexeddb/blob-valid-after-deletion.html [ Pass Timeout ]
 
 webkit.org/b/128312 media/video-load-preload-metadata.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206920] trunk/Source/WebCore

2016-10-07 Thread ryanhaddad

Title: [206920] trunk/Source/WebCore








Revision 206920
Author ryanhad...@apple.com
Date 2016-10-07 10:26:54 -0700 (Fri, 07 Oct 2016)


Log Message
Fix the Windows build after r206917.

Unreviewed build fix.

* dom/DOMAllInOne.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMAllInOne.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206919 => 206920)

--- trunk/Source/WebCore/ChangeLog	2016-10-07 17:15:13 UTC (rev 206919)
+++ trunk/Source/WebCore/ChangeLog	2016-10-07 17:26:54 UTC (rev 206920)
@@ -1,3 +1,11 @@
+2016-10-07  Ryan Haddad  
+
+Fix the Windows build after r206917.
+
+Unreviewed build fix.
+
+* dom/DOMAllInOne.cpp:
+
 2016-10-07  Antti Koivisto  
 
 Rename AuthorStyleSheets to Style::Scope


Modified: trunk/Source/WebCore/dom/DOMAllInOne.cpp (206919 => 206920)

--- trunk/Source/WebCore/dom/DOMAllInOne.cpp	2016-10-07 17:15:13 UTC (rev 206919)
+++ trunk/Source/WebCore/dom/DOMAllInOne.cpp	2016-10-07 17:26:54 UTC (rev 206920)
@@ -29,7 +29,7 @@
 #include "ActiveDOMObject.cpp"
 #include "AnimationEvent.cpp"
 #include "Attr.cpp"
-#include "AuthorStyleSheets.cpp"
+#include "StyleScope.cpp"
 #include "BeforeTextInsertedEvent.cpp"
 #include "BeforeUnloadEvent.cpp"
 #include "CDATASection.cpp"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206921] trunk

2016-10-07 Thread n_wang

Title: [206921] trunk








Revision 206921
Author n_w...@apple.com
Date 2016-10-07 10:44:51 -0700 (Fri, 07 Oct 2016)


Log Message
AX: AXRoleDescription for details and summary elements
https://bugs.webkit.org/show_bug.cgi?id=163094

Reviewed by Chris Fleizach.

Source/WebCore:

details and summary elements should have AXRoleDescription that is consistent with other
elements that have custom AXSubRole.

Test: accessibility/mac/details-summary-role-description.html

* English.lproj/Localizable.strings:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):
* platform/LocalizedStrings.cpp:
(WebCore::AXDetailsText):
(WebCore::AXSummaryText):
* platform/LocalizedStrings.h:
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXDetailsText):
(WebCore::AXSummaryText):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXDetailsText):
(WebCore::AXSummaryText):

LayoutTests:

* accessibility/mac/details-summary-role-description-expected.txt: Added.
* accessibility/mac/details-summary-role-description.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/Localizable.strings
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
trunk/Source/WebCore/platform/LocalizedStrings.cpp
trunk/Source/WebCore/platform/LocalizedStrings.h
trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp
trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp


Added Paths

trunk/LayoutTests/accessibility/mac/details-summary-role-description-expected.txt
trunk/LayoutTests/accessibility/mac/details-summary-role-description.html




Diff

Modified: trunk/LayoutTests/ChangeLog (206920 => 206921)

--- trunk/LayoutTests/ChangeLog	2016-10-07 17:26:54 UTC (rev 206920)
+++ trunk/LayoutTests/ChangeLog	2016-10-07 17:44:51 UTC (rev 206921)
@@ -1,3 +1,13 @@
+2016-10-07  Nan Wang  
+
+AX: AXRoleDescription for details and summary elements
+https://bugs.webkit.org/show_bug.cgi?id=163094
+
+Reviewed by Chris Fleizach.
+
+* accessibility/mac/details-summary-role-description-expected.txt: Added.
+* accessibility/mac/details-summary-role-description.html: Added.
+
 2016-10-07  Ryan Haddad  
 
 Marking imported/blink/storage/indexeddb/blob-valid-after-deletion.html as flaky on mac.


Added: trunk/LayoutTests/accessibility/mac/details-summary-role-description-expected.txt (0 => 206921)

--- trunk/LayoutTests/accessibility/mac/details-summary-role-description-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/details-summary-role-description-expected.txt	2016-10-07 17:44:51 UTC (rev 206921)
@@ -0,0 +1,18 @@
+Summary
+some detail
+
+This tests that summary and detail elements have correct role description.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS summary.role is 'AXRole: AXGroup'
+PASS details.role is 'AXRole: AXGroup'
+PASS summary.subrole is 'AXSubrole: AXSummary'
+PASS details.subrole is 'AXSubrole: AXDetails'
+PASS summary.roleDescription is 'AXRoleDescription: summary'
+PASS details.roleDescription is 'AXRoleDescription: details'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/mac/details-summary-role-description.html (0 => 206921)

--- trunk/LayoutTests/accessibility/mac/details-summary-role-description.html	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/details-summary-role-description.html	2016-10-07 17:44:51 UTC (rev 206921)
@@ -0,0 +1,34 @@
+
+
+
+
+
+
+Summary
some detail
+
+
+
+
+