[webkit-changes] [207658] trunk

[carlosgc]

Title: [207658] trunk








Revision 207658
Author carlo...@webkit.org
Date 2016-10-20 22:30:53 -0700 (Thu, 20 Oct 2016)


Log Message
[GTK] Configures but fails to link with ENABLE_OPENGL=OFF
https://bugs.webkit.org/show_bug.cgi?id=163449

Reviewed by Michael Catanzaro.

.:

Remove wrong dependency of Wayland on OpenGL introduced in r190615, it should be possible to build for Wayland
without GL.

* Source/cmake/OptionsGTK.cmake:

Source/WebCore:

Only define sharingGLContext in PlatformDisplay if EGL or GLX are enabled.

* platform/graphics/PlatformDisplay.cpp:
* platform/graphics/PlatformDisplay.h:
* platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::initialize):
* platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::~PlatformDisplayX11):

Source/WebKit2:

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize): Check TEXTURE_MAPPER_GL instead of TEXTURE_MAPPER and also ensure the current
display is X11.
(webkitWebViewBaseUnrealize): Ditto.
(webkitWebViewBaseDidRelaunchWebProcess): Check TEXTURE_MAPPER_GL instead of TEXTURE_MAPPER.
(webkitWebViewBasePageClosed): Ditto.
* UIProcess/AcceleratedDrawingAreaProxy.cpp:
(WebKit::AcceleratedDrawingAreaProxy::didUpdateBackingStoreState): Ditto.
(WebKit::AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState): Check EGL is enabled before
trying to use the WaylandCompositor.
* UIProcess/AcceleratedDrawingAreaProxy.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess): Ditto.
* UIProcess/gtk/AcceleratedBackingStore.cpp:
(WebKit::AcceleratedBackingStore::create): Ditto.
* UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
* UIProcess/gtk/WaylandCompositor.cpp:
* UIProcess/gtk/WaylandCompositor.h:
* WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::enterAcceleratedCompositingMode): Check TEXTURE_MAPPER_GL instead of TEXTURE_MAPPER.
* WebProcess/WebPage/AcceleratedDrawingArea.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/LayerTreeHost.h:

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp
trunk/Source/WebCore/platform/graphics/PlatformDisplay.h
trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp
trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit2/UIProcess/AcceleratedDrawingAreaProxy.cpp
trunk/Source/WebKit2/UIProcess/AcceleratedDrawingAreaProxy.h
trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStore.cpp
trunk/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp
trunk/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp
trunk/Source/WebKit2/UIProcess/gtk/WaylandCompositor.h
trunk/Source/WebKit2/WebProcess/WebPage/AcceleratedDrawingArea.cpp
trunk/Source/WebKit2/WebProcess/WebPage/AcceleratedDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (207657 => 207658)

--- trunk/ChangeLog	2016-10-21 05:07:43 UTC (rev 207657)
+++ trunk/ChangeLog	2016-10-21 05:30:53 UTC (rev 207658)
@@ -1,3 +1,15 @@
+2016-10-20  Carlos Garcia Campos  
+
+[GTK] Configures but fails to link with ENABLE_OPENGL=OFF
+https://bugs.webkit.org/show_bug.cgi?id=163449
+
+Reviewed by Michael Catanzaro.
+
+Remove wrong dependency of Wayland on OpenGL introduced in r190615, it should be possible to build for Wayland
+without GL.
+
+* Source/cmake/OptionsGTK.cmake:
+
 2016-10-20  Fujii Hironori  
 
 [CMake] CMake does not support the dep files for implicit dependency


Modified: trunk/Source/WebCore/ChangeLog (207657 => 207658)

--- trunk/Source/WebCore/ChangeLog	2016-10-21 05:07:43 UTC (rev 207657)
+++ trunk/Source/WebCore/ChangeLog	2016-10-21 05:30:53 UTC (rev 207658)
@@ -1,3 +1,19 @@
+2016-10-20  Carlos Garcia Campos  
+
+[GTK] Configures but fails to link with ENABLE_OPENGL=OFF
+https://bugs.webkit.org/show_bug.cgi?id=163449
+
+Reviewed by Michael Catanzaro.
+
+Only define sharingGLContext in PlatformDisplay if EGL or GLX are enabled.
+
+* platform/graphics/PlatformDisplay.cpp:
+* platform/graphics/PlatformDisplay.h:
+* platform/graphics/wayland/PlatformDisplayWayland.cpp:
+(WebCore::PlatformDisplayWayland::initialize):
+* platform/graphics/x11/PlatformDisplayX11.cpp:
+(WebCore::PlatformDisplayX11::~PlatformDisplayX11):
+
 2016-10-20  Filip Pizlo  
 
 The tracking of the coarse-grain Heap 

[webkit-changes] [207657] tags/Safari-602.3.3.0.1/Source/WebCore

[bshafiei]

Title: [207657] tags/Safari-602.3.3.0.1/Source/WebCore








Revision 207657
Author bshaf...@apple.com
Date 2016-10-20 22:07:43 -0700 (Thu, 20 Oct 2016)


Log Message
Merge r207654. rdar://problem/28883727

Modified Paths

tags/Safari-602.3.3.0.1/Source/WebCore/ChangeLog
tags/Safari-602.3.3.0.1/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp




Diff

Modified: tags/Safari-602.3.3.0.1/Source/WebCore/ChangeLog (207656 => 207657)

--- tags/Safari-602.3.3.0.1/Source/WebCore/ChangeLog	2016-10-21 05:05:44 UTC (rev 207656)
+++ tags/Safari-602.3.3.0.1/Source/WebCore/ChangeLog	2016-10-21 05:07:43 UTC (rev 207657)
@@ -1,3 +1,14 @@
+2016-10-20  Babak Shafiei  
+
+Merge r207654. rdar://problem/28883727
+
+2016-10-20  Babak Shafiei  
+
+Build fix. rdar://problem/28883727
+
+* platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
+(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
+
 2016-10-20  Daniel Bates  
 
 Merge r206809. rdar://problem/28718761


Modified: tags/Safari-602.3.3.0.1/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp (207656 => 207657)

--- tags/Safari-602.3.3.0.1/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp	2016-10-21 05:05:44 UTC (rev 207656)
+++ tags/Safari-602.3.3.0.1/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp	2016-10-21 05:07:43 UTC (rev 207657)
@@ -135,7 +135,7 @@
 }
 #endif // !PLATFORM(COCOA)
 
-void SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse(CFURLConnectionRef, CFURLResponseRef cfResponse)
+void SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse(CFURLConnectionRef connection, CFURLResponseRef cfResponse)
 {
 LOG(Network, "CFNet - SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse(handle=%p) (%s)", m_handle, m_handle->firstRequest().url().string().utf8().data());
 
@@ -180,10 +180,12 @@
 #if PLATFORM(COCOA) && ENABLE(WEB_TIMING)
 ResourceHandle::getConnectionTimingData(connection, resourceResponse.resourceLoadTiming());
 #else
+UNUSED_PARAM(connection);
+#endif
+
 #if USE(QUICK_LOOK)
 resourceResponse.setIsQuickLook(isQuickLookPreview);
 #endif
-#endif
 
 m_handle->client()->didReceiveResponse(m_handle, WTFMove(resourceResponse));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207656] tags/Safari-602.3.3.0.1/Source

[bshafiei]

Title: [207656] tags/Safari-602.3.3.0.1/Source








Revision 207656
Author bshaf...@apple.com
Date 2016-10-20 22:05:44 -0700 (Thu, 20 Oct 2016)


Log Message
Versioning.

Modified Paths

tags/Safari-602.3.3.0.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-602.3.3.0.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-602.3.3.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-602.3.3.0.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-602.3.3.0.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-602.3.3.0.1/Source/_javascript_Core/Configurations/Version.xcconfig (207655 => 207656)

--- tags/Safari-602.3.3.0.1/Source/_javascript_Core/Configurations/Version.xcconfig	2016-10-21 05:03:29 UTC (rev 207655)
+++ tags/Safari-602.3.3.0.1/Source/_javascript_Core/Configurations/Version.xcconfig	2016-10-21 05:05:44 UTC (rev 207656)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 3;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-602.3.3.0.1/Source/WebCore/Configurations/Version.xcconfig (207655 => 207656)

--- tags/Safari-602.3.3.0.1/Source/WebCore/Configurations/Version.xcconfig	2016-10-21 05:03:29 UTC (rev 207655)
+++ tags/Safari-602.3.3.0.1/Source/WebCore/Configurations/Version.xcconfig	2016-10-21 05:05:44 UTC (rev 207656)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 3;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-602.3.3.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig (207655 => 207656)

--- tags/Safari-602.3.3.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-10-21 05:03:29 UTC (rev 207655)
+++ tags/Safari-602.3.3.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-10-21 05:05:44 UTC (rev 207656)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 3;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-602.3.3.0.1/Source/WebKit/mac/Configurations/Version.xcconfig (207655 => 207656)

--- tags/Safari-602.3.3.0.1/Source/WebKit/mac/Configurations/Version.xcconfig	2016-10-21 05:03:29 UTC (rev 207655)
+++ tags/Safari-602.3.3.0.1/Source/WebKit/mac/Configurations/Version.xcconfig	2016-10-21 05:05:44 UTC (rev 207656)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 3;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-602.3.3.0.1/Source/WebKit2/Configurations/Version.xcconfig (207655 => 207656)

--- tags/Safari-602.3.3.0.1/Source/WebKit2/Configurations/Version.xcconfig	2016-10-21 05:03:29 UTC (rev 207655)
+++ tags/Safari-602.3.3.0.1/Source/WebKit2/Configurations/Version.xcconfig	2016-10-21 05:05:44 UTC (rev 207656)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 3;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207655] tags/Safari-602.3.3.0.1/

[bshafiei]

Title: [207655] tags/Safari-602.3.3.0.1/








Revision 207655
Author bshaf...@apple.com
Date 2016-10-20 22:03:29 -0700 (Thu, 20 Oct 2016)


Log Message
New tag.

Added Paths

tags/Safari-602.3.3.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207654] branches/safari-602-branch/Source/WebCore

[bshafiei]

Title: [207654] branches/safari-602-branch/Source/WebCore








Revision 207654
Author bshaf...@apple.com
Date 2016-10-20 22:01:03 -0700 (Thu, 20 Oct 2016)


Log Message
Build fix. rdar://problem/28883727

Modified Paths

branches/safari-602-branch/Source/WebCore/ChangeLog
branches/safari-602-branch/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp




Diff

Modified: branches/safari-602-branch/Source/WebCore/ChangeLog (207653 => 207654)

--- branches/safari-602-branch/Source/WebCore/ChangeLog	2016-10-21 02:17:35 UTC (rev 207653)
+++ branches/safari-602-branch/Source/WebCore/ChangeLog	2016-10-21 05:01:03 UTC (rev 207654)
@@ -1,3 +1,10 @@
+2016-10-20  Babak Shafiei  
+
+Build fix. rdar://problem/28883727
+
+* platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
+(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
+
 2016-10-20  Daniel Bates  
 
 Merge r206809. rdar://problem/28718761


Modified: branches/safari-602-branch/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp (207653 => 207654)

--- branches/safari-602-branch/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp	2016-10-21 02:17:35 UTC (rev 207653)
+++ branches/safari-602-branch/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp	2016-10-21 05:01:03 UTC (rev 207654)
@@ -135,7 +135,7 @@
 }
 #endif // !PLATFORM(COCOA)
 
-void SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse(CFURLConnectionRef, CFURLResponseRef cfResponse)
+void SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse(CFURLConnectionRef connection, CFURLResponseRef cfResponse)
 {
 LOG(Network, "CFNet - SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse(handle=%p) (%s)", m_handle, m_handle->firstRequest().url().string().utf8().data());
 
@@ -180,10 +180,12 @@
 #if PLATFORM(COCOA) && ENABLE(WEB_TIMING)
 ResourceHandle::getConnectionTimingData(connection, resourceResponse.resourceLoadTiming());
 #else
+UNUSED_PARAM(connection);
+#endif
+
 #if USE(QUICK_LOOK)
 resourceResponse.setIsQuickLook(isQuickLookPreview);
 #endif
-#endif
 
 m_handle->client()->didReceiveResponse(m_handle, WTFMove(resourceResponse));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207652] trunk

[utatane . tea]

Title: [207652] trunk








Revision 207652
Author utatane@gmail.com
Date 2016-10-20 18:33:14 -0700 (Thu, 20 Oct 2016)


Log Message
[JSC] Drop isEnvironmentRecord type info flag and use JSType information instead
https://bugs.webkit.org/show_bug.cgi?id=163761

Reviewed by Keith Miller.

JSTests:

* modules/string-prototype-module-scope.js: Added.
(shouldBe):
(catch):
(refer):
* stress/string-prototype-scopes-global-lexical-environment-strict.js: Added.
(shouldBe):
(catch):
* stress/string-prototype-scopes-global-lexical-environment.js: Added.
(shouldBe):
(catch):
* stress/string-prototype-scopes-strict.js: Added.
(shouldBe):
(catch):
(try.refer):
(refer):
* stress/string-prototype-scopes.js: Added.
(shouldBe):
(catch):
(try.refer):
(refer):
(object.toString):
(with):

Source/_javascript_Core:

When we call a function in the following form,

var charAt = String.prototype.charAt;
charAt();  // |this| becomes the global object.

we should see |this| as undefined/null. In StringPrototype.cpp,
we use IsEnvironmentRecord type info flag to check whther the
given |this| is an environment record.
However, type info flag is precious thing and only StringPrototype.cpp
uses IsEnvironmentRecord. In addition to that, JSType should
already knows whether the given object is an environment record.
So IsEnvironmentRecord type info flag should be dropped.

This patch adds a new JSType, StrictEvalActivation. And we add a new
method JSObject::isEnvironmentRecord(). This method uses JSType to
return the result. And we drop IsEnvironmentRecord type info flag.
This patch makes a room for putting one bit flag to the out of line
type info flag. Previously, it is already exhausted.

* llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
* llint/LowLevelInterpreter.asm:
* runtime/JSObject.h:
(JSC::JSObject::isStrictEvalActivation):
(JSC::JSObject::isEnvironmentRecord):
* runtime/JSSymbolTableObject.h:
* runtime/JSType.h:
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::newImpurePropertyFiresWatchpoints):
(JSC::TypeInfo::isEnvironmentRecord): Deleted.
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::createStructure):
* runtime/StringPrototype.cpp:
(JSC::checkObjectCoercible):

LayoutTests:

* js/dom/script-tests/string-prototype-scopes-in-workers.js: Added.
(catch):
* js/dom/script-tests/string-prototype-scopes.js: Added.
(catch):
* js/dom/string-prototype-scopes-expected.txt: Added.
* js/dom/string-prototype-scopes-in-workers-expected.txt: Added.
* js/dom/string-prototype-scopes-in-workers.html: Added.
* js/dom/string-prototype-scopes.html: Added.

Modified Paths

trunk/JSTests/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LLIntData.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/JSSymbolTableObject.h
trunk/Source/_javascript_Core/runtime/JSType.h
trunk/Source/_javascript_Core/runtime/JSTypeInfo.h
trunk/Source/_javascript_Core/runtime/StrictEvalActivation.h
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp


Added Paths

trunk/JSTests/modules/string-prototype-module-scope.js
trunk/JSTests/stress/string-prototype-scopes-global-lexical-environment-strict.js
trunk/JSTests/stress/string-prototype-scopes-global-lexical-environment.js
trunk/JSTests/stress/string-prototype-scopes-strict.js
trunk/JSTests/stress/string-prototype-scopes.js
trunk/LayoutTests/js/dom/script-tests/string-prototype-scopes-in-workers.js
trunk/LayoutTests/js/dom/script-tests/string-prototype-scopes.js
trunk/LayoutTests/js/dom/string-prototype-scopes-expected.txt
trunk/LayoutTests/js/dom/string-prototype-scopes-in-workers-expected.txt
trunk/LayoutTests/js/dom/string-prototype-scopes-in-workers.html
trunk/LayoutTests/js/dom/string-prototype-scopes.html




Diff

Modified: trunk/JSTests/ChangeLog (207651 => 207652)

--- trunk/JSTests/ChangeLog	2016-10-21 01:27:02 UTC (rev 207651)
+++ trunk/JSTests/ChangeLog	2016-10-21 01:33:14 UTC (rev 207652)
@@ -1,3 +1,33 @@
+2016-10-20  Yusuke Suzuki  
+
+[JSC] Drop isEnvironmentRecord type info flag and use JSType information instead
+https://bugs.webkit.org/show_bug.cgi?id=163761
+
+Reviewed by Keith Miller.
+
+* modules/string-prototype-module-scope.js: Added.
+(shouldBe):
+(catch):
+(refer):
+* stress/string-prototype-scopes-global-lexical-environment-strict.js: Added.
+(shouldBe):
+(catch):
+* stress/string-prototype-scopes-global-lexical-environment.js: Added.
+(shouldBe):
+(catch):
+* stress/string-prototype-scopes-strict.js: Added.
+(shouldBe):
+(catch):
+(try.refer):
+(refer):
+* stress/string-prototype-scopes.js: Added.
+(shouldBe):
+(catch):
+(try.refer):
+(refer):
+(object.toString):
+(with):
+
 

[webkit-changes] [207651] trunk/Source/WebCore

[cdumez]

Title: [207651] trunk/Source/WebCore








Revision 207651
Author cdu...@apple.com
Date 2016-10-20 18:27:02 -0700 (Thu, 20 Oct 2016)


Log Message
[Bindings] Start using signature->idlType instead of signature->type in the overload resolution code
https://bugs.webkit.org/show_bug.cgi?id=163767

Reviewed by Darin Adler.

Start using signature->idlType instead of signature->type in the overload resolution code
to prepare for union type support.

* bindings/scripts/CodeGeneratorJS.pm:
(ComputeEffectiveOverloadSet):
(AreTypesDistinguishableForOverloadResolution):
(GetDistinguishingArgumentIndex):
(GetOverloadThatMatches):
(GenerateOverloadedFunctionOrConstructor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (207650 => 207651)

--- trunk/Source/WebCore/ChangeLog	2016-10-21 01:19:24 UTC (rev 207650)
+++ trunk/Source/WebCore/ChangeLog	2016-10-21 01:27:02 UTC (rev 207651)
@@ -1,3 +1,20 @@
+2016-10-20  Chris Dumez  
+
+[Bindings] Start using signature->idlType instead of signature->type in the overload resolution code
+https://bugs.webkit.org/show_bug.cgi?id=163767
+
+Reviewed by Darin Adler.
+
+Start using signature->idlType instead of signature->type in the overload resolution code
+to prepare for union type support.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(ComputeEffectiveOverloadSet):
+(AreTypesDistinguishableForOverloadResolution):
+(GetDistinguishingArgumentIndex):
+(GetOverloadThatMatches):
+(GenerateOverloadedFunctionOrConstructor):
+
 2016-10-20  Myles C. Maxfield  
 
 Implement WebGL2 bufferData() and bufferSubData() methods


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (207650 => 207651)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-10-21 01:19:24 UTC (rev 207650)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-10-21 01:27:02 UTC (rev 207651)
@@ -1914,7 +1914,7 @@
 my @o;
 my $isVariadic = 0;
 foreach my $parameter (@{$overload->parameters}) {
-push(@t, $parameter->isNullable ? $parameter->type . "?" : $parameter->type);
+push(@t, $parameter->idlType);
 if ($parameter->isOptional) {
 push(@o, "optional");
 } elsif ($parameter->isVariadic) {
@@ -1950,7 +1950,7 @@
 # http://heycam.github.io/webidl/#dfn-distinguishable
 sub AreTypesDistinguishableForOverloadResolution
 {
-my ($typeA, $typeB) = @_;
+my ($idlTypeA, $idlTypeB) = @_;
 
 my $isDictionary = sub {
 my $type = shift;
@@ -1960,22 +1960,26 @@
 my $type = shift;
 return $codeGenerator->IsFunctionOnlyCallbackInterface($type) || &$isDictionary($type);
 };
+
+# FIXME: Add support for union types.
+# idlTypeA and idlTypeB  are distinguishable if:
+# - One type is a union type or nullable union type, the other is neither a union type nor a nullable
+#   union type, and each member type of the first is distinguishable with the second.
+# - Both types are either a union type or nullable union type, and each member type of the one is
+#   distinguishable with each member type of the other.
 
 # FIXME: The WebIDL mandates this but this currently does not work because some of our IDL is wrong.
-# return 0 if IsNullableType($typeA) && IsNullableType($typeB);
+# return 0 if $idlTypeA->isNullable && $idlTypeB->isNullable;
 
-$typeA = StripNullable($typeA);
-$typeB = StripNullable($typeB);
-
-return 0 if $typeA eq $typeB;
-return 0 if $typeA eq "object" or $typeB eq "object";
-return 0 if $codeGenerator->IsNumericType($typeA) && $codeGenerator->IsNumericType($typeB);
-return 0 if $codeGenerator->IsStringOrEnumType($typeA) && $codeGenerator->IsStringOrEnumType($typeB);
-return 0 if &$isDictionary($typeA) && &$isDictionary($typeB);
-return 0 if $codeGenerator->IsCallbackInterface($typeA) && $codeGenerator->IsCallbackInterface($typeB);
-return 0 if &$isCallbackFunctionOrDictionary($typeA) && &$isCallbackFunctionOrDictionary($typeB);
-return 0 if $codeGenerator->IsSequenceOrFrozenArrayType($typeA) && $codeGenerator->IsSequenceOrFrozenArrayType($typeB);
-# FIXME: return 0 if typeA and typeB are both exception types.
+return 0 if $idlTypeA->name eq $idlTypeB->name;
+return 0 if $idlTypeA->name eq "object" or $idlTypeB->name eq "object";
+return 0 if $codeGenerator->IsNumericType($idlTypeA->name) && $codeGenerator->IsNumericType($idlTypeB->name);
+return 0 if $codeGenerator->IsStringOrEnumType($idlTypeA->name) && $codeGenerator->IsStringOrEnumType($idlTypeB->name);
+return 0 if &$isDictionary($idlTypeA->name) && &$isDictionary($idlTypeB->name);
+return 0 if $codeGenerator->IsCallbackInterface($idlTypeA->name) && 

[webkit-changes] [207650] trunk

[jfbastien]

Title: [207650] trunk








Revision 207650
Author jfbast...@apple.com
Date 2016-10-20 18:19:24 -0700 (Thu, 20 Oct 2016)


Log Message
WebAssembly API: implement exception constructors properly

 - Rename WebAssemblyObject to JSWebAssembly for consistency.
 - WebAssembly object now has its own prototype: add WebAssemblyPrototype, and
   use it to register JSWebAssembly's function properties through auto-generated
   .lut.h, instead of manually.
 - The error constructors used to throw (e.g. `new WebAssembly.CompileError()`).
 - Register WebAssembly's constructors from the global object, and hold a
   reference to their structure and prototype so that invoking the constructor
   can use the structure directly from the global object.
 - Add a prototype base field to global object creation. Previous ones all had
   Object's prototype as their base, but WebAssembly's error constructors have
   Error as their base.
 - Test for the error object's correctness.
 - Add missing #if ENABLE(WEBASSEMBLY)

WebAssembly API: implement exception constructors properly
https://bugs.webkit.org/show_bug.cgi?id=163699

Reviewed by Keith Miller.

JSTests:

* wasm/js-api/test_basic_api.js:
(const.c.in.constructorProperties): more tests

Source/_javascript_Core:

* CMakeLists.txt: rename WebAssemblyObject -> JSWebAssembly; add a .lut.h file
* DerivedSources.make: new .lut.h file
* _javascript_Core.xcodeproj/project.pbxproj: ditto
* runtime/JSGlobalObject.cpp: new prototypeBase macro
(JSC::JSGlobalObject::init): register WebAssembly constructors here
(JSC::JSGlobalObject::visitChildren): use the macro to visit
* runtime/JSGlobalObject.h: declare the WebAssembly constructor macro
* wasm/JSWebAssembly.cpp: Copied from Source/_javascript_Core/wasm/WebAssemblyObject.h.
(JSC::JSWebAssembly::create):
(JSC::JSWebAssembly::createStructure):
(JSC::JSWebAssembly::finishCreation):
(JSC::JSWebAssembly::JSWebAssembly):
* wasm/JSWebAssembly.h: Renamed from Source/_javascript_Core/wasm/WebAssemblyObject.h.
* wasm/WebAssemblyObject.cpp: Removed.
* wasm/js/JSWebAssemblyCompileError.cpp:
* wasm/js/JSWebAssemblyCompileError.h:
(JSC::JSWebAssemblyCompileError::create): string convenience
* wasm/js/JSWebAssemblyInstance.cpp:
* wasm/js/JSWebAssemblyInstance.h:
* wasm/js/JSWebAssemblyMemory.cpp:
* wasm/js/JSWebAssemblyMemory.h:
* wasm/js/JSWebAssemblyModule.cpp:
* wasm/js/JSWebAssemblyModule.h:
* wasm/js/JSWebAssemblyRuntimeError.cpp:
* wasm/js/JSWebAssemblyRuntimeError.h:
(JSC::JSWebAssemblyRuntimeError::create): string convenience
* wasm/js/JSWebAssemblyTable.cpp:
* wasm/js/JSWebAssemblyTable.h:
* wasm/js/WebAssemblyCompileErrorConstructor.cpp:
(JSC::constructJSWebAssemblyCompileError):don't throw, create the object
(JSC::WebAssemblyCompileErrorConstructor::finishCreation):no need for the structure, it's on the global object
* wasm/js/WebAssemblyCompileErrorConstructor.h:
* wasm/js/WebAssemblyCompileErrorPrototype.cpp:
* wasm/js/WebAssemblyCompileErrorPrototype.h:
* wasm/js/WebAssemblyInstanceConstructor.cpp:
* wasm/js/WebAssemblyInstanceConstructor.h:
* wasm/js/WebAssemblyInstancePrototype.cpp:
* wasm/js/WebAssemblyInstancePrototype.h:
* wasm/js/WebAssemblyMemoryConstructor.cpp:
* wasm/js/WebAssemblyMemoryConstructor.h:
* wasm/js/WebAssemblyMemoryPrototype.cpp:
* wasm/js/WebAssemblyMemoryPrototype.h:
* wasm/js/WebAssemblyModuleConstructor.cpp:
* wasm/js/WebAssemblyModuleConstructor.h:
* wasm/js/WebAssemblyModulePrototype.cpp:
* wasm/js/WebAssemblyModulePrototype.h:
* wasm/js/WebAssemblyPrototype.cpp: Copied from Source/_javascript_Core/wasm/js/WebAssemblyCompileErrorPrototype.cpp.
(JSC::webAssemblyFunctionValidate):
(JSC::webAssemblyFunctionCompile):
(JSC::WebAssemblyPrototype::create):
(JSC::WebAssemblyPrototype::createStructure):
(JSC::WebAssemblyPrototype::finishCreation):
(JSC::WebAssemblyPrototype::WebAssemblyPrototype):
* wasm/js/WebAssemblyPrototype.h: Copied from Source/_javascript_Core/wasm/js/WebAssemblyMemoryPrototype.h.
* wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:
(JSC::constructJSWebAssemblyRuntimeError):don't throw, create the object
(JSC::WebAssemblyRuntimeErrorConstructor::finishCreation):no need for the structure, it's on the global object
* wasm/js/WebAssemblyRuntimeErrorConstructor.h:
* wasm/js/WebAssemblyRuntimeErrorPrototype.cpp:
* wasm/js/WebAssemblyRuntimeErrorPrototype.h:
* wasm/js/WebAssemblyTableConstructor.cpp:
* wasm/js/WebAssemblyTableConstructor.h:
* wasm/js/WebAssemblyTablePrototype.cpp:
* wasm/js/WebAssemblyTablePrototype.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/js-api/test_basic_api.js
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/DerivedSources.make
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyCompileError.cpp

[webkit-changes] [207649] trunk

[mmaxfield]

Title: [207649] trunk








Revision 207649
Author mmaxfi...@apple.com
Date 2016-10-20 18:17:31 -0700 (Thu, 20 Oct 2016)


Log Message
Implement WebGL2 bufferData() and bufferSubData() methods
https://bugs.webkit.org/show_bug.cgi?id=163759

Reviewed by Dean Jackson.

Source/WebCore:

These new overloads simply clip the input array buffer.

Test: fast/canvas/webgl/bufferData-offset-length.html

* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::bufferData):
(WebCore::WebGL2RenderingContext::bufferSubData):
* html/canvas/WebGL2RenderingContext.h:
* html/canvas/WebGL2RenderingContext.idl:

LayoutTests:

* fast/canvas/webgl/bufferData-offset-length-expected.txt: Added.
* fast/canvas/webgl/bufferData-offset-length.html: Added.
* fast/canvas/webgl/resources/webgl-test.js:
(create3DContext):
(initWebGL):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/webgl/resources/webgl-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h
trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.idl


Added Paths

trunk/LayoutTests/fast/canvas/webgl/bufferData-offset-length-expected.txt
trunk/LayoutTests/fast/canvas/webgl/bufferData-offset-length.html




Diff

Modified: trunk/LayoutTests/ChangeLog (207648 => 207649)

--- trunk/LayoutTests/ChangeLog	2016-10-21 01:15:54 UTC (rev 207648)
+++ trunk/LayoutTests/ChangeLog	2016-10-21 01:17:31 UTC (rev 207649)
@@ -1,3 +1,16 @@
+2016-10-20  Myles C. Maxfield  
+
+Implement WebGL2 bufferData() and bufferSubData() methods
+https://bugs.webkit.org/show_bug.cgi?id=163759
+
+Reviewed by Dean Jackson.
+
+* fast/canvas/webgl/bufferData-offset-length-expected.txt: Added.
+* fast/canvas/webgl/bufferData-offset-length.html: Added.
+* fast/canvas/webgl/resources/webgl-test.js:
+(create3DContext):
+(initWebGL):
+
 2016-10-20  Nan Wang  
 
 AX: VoiceOver is not detecting ARIA treeview if it contains role="presentation"


Added: trunk/LayoutTests/fast/canvas/webgl/bufferData-offset-length-expected.txt (0 => 207649)

--- trunk/LayoutTests/fast/canvas/webgl/bufferData-offset-length-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/bufferData-offset-length-expected.txt	2016-10-21 01:17:31 UTC (rev 207649)
@@ -0,0 +1,19 @@
+ Checks the last two arguments to bufferData() are respected.
+
+PASS gl.getError() is gl.NO_ERROR
+PASS gl.getError() is gl.NO_ERROR
+PASS Left half of canvas should be filled
+PASS Right half of canvas should be empty
+PASS gl.getError() is gl.NO_ERROR
+PASS Left half of canvas should be empty
+PASS Right half of canvas should be filled
+PASS gl.getError() is gl.NO_ERROR
+PASS Left half of canvas should be empty
+PASS Right half of canvas should be filled
+PASS gl.getError() is gl.NO_ERROR
+PASS Left half of canvas should be filled
+PASS Right half of canvas should be empty
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/canvas/webgl/bufferData-offset-length.html (0 => 207649)

--- trunk/LayoutTests/fast/canvas/webgl/bufferData-offset-length.html	(rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/bufferData-offset-length.html	2016-10-21 01:17:31 UTC (rev 207649)
@@ -0,0 +1,102 @@
+
+
+
+
+
+
+
+

+

+