[webkit-changes] [207806] trunk
Title: [207806] trunk
Revision 207806
Author cdu...@apple.com
Date 2016-10-24 22:16:00 -0700 (Mon, 24 Oct 2016)
Log Message
IDBDatabase.createObjectStore() should take a IDBObjectStoreParameters dictionary in parameter
https://bugs.webkit.org/show_bug.cgi?id=163916
Reviewed by Darin Adler.
Source/WebCore:
IDBDatabase.createObjectStore() should take a IDBObjectStoreParameters dictionary in parameter:
- https://www.w3.org/TR/IndexedDB/#idl-def-IDBDatabase
- https://www.w3.org/TR/IndexedDB/#idl-def-IDBObjectStoreParameters
Align our IDL with the specification.
No new tests, no expected Web-exposed behavior change.
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
* Modules/indexeddb/IDBDatabase.h:
* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBKeyPath::IDBKeyPath):
* Modules/indexeddb/IDBKeyPath.h:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/IDBBindingUtilities.cpp:
(WebCore::idbKeyPathFromValue): Deleted.
* bindings/js/IDBBindingUtilities.h:
* bindings/js/JSIDBDatabaseCustom.cpp: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
(GenerateConstructorDefinition):
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::create):
* dom/MessageEvent.h:
* testing/TypeConversions.h:
(WebCore::TypeConversions::setTypeConversionsDictionary):
LayoutTests:
Rebaseline existing tests now that the exception messages differ slightly.
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/create-object-store-options-private-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/create-object-store-options-expected.txt
trunk/LayoutTests/storage/indexeddb/create-object-store-options-private-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.h
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl
trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp
trunk/Source/WebCore/bindings/js/IDBBindingUtilities.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/dom/MessageEvent.cpp
trunk/Source/WebCore/dom/MessageEvent.h
trunk/Source/WebCore/testing/TypeConversions.h
Removed Paths
trunk/Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (207805 => 207806)
--- trunk/LayoutTests/ChangeLog 2016-10-25 04:40:23 UTC (rev 207805)
+++ trunk/LayoutTests/ChangeLog 2016-10-25 05:16:00 UTC (rev 207806)
@@ -1,3 +1,15 @@
+2016-10-24 Chris Dumez
+
+IDBDatabase.createObjectStore() should take a IDBObjectStoreParameters dictionary in parameter
+https://bugs.webkit.org/show_bug.cgi?id=163916
+
+Reviewed by Darin Adler.
+
+Rebaseline existing tests now that the exception messages differ slightly.
+
+* storage/indexeddb/create-object-store-options-expected.txt:
+* storage/indexeddb/create-object-store-options-private-expected.txt:
+
2016-10-24 Alex Christensen
URLParser should match old URL::parse with %2E in path
Modified: trunk/LayoutTests/storage/indexeddb/create-object-store-options-expected.txt (207805 => 207806)
--- trunk/LayoutTests/storage/indexeddb/create-object-store-options-expected.txt 2016-10-25 04:40:23 UTC (rev 207805)
+++ trunk/LayoutTests/storage/indexeddb/create-object-store-options-expected.txt 2016-10-25 05:16:00 UTC (rev 207806)
@@ -15,10 +15,10 @@
trans.objectStore('a').put({'a': 0})
Expecting TypeError exception from db.createObjectStore('d', 'bar');
PASS Exception was thrown.
-PASS db.createObjectStore('d', 'bar'); threw TypeError: Not an object.
+PASS db.createObjectStore('d', 'bar'); threw TypeError: Type error
Expecting TypeError exception from db.createObjectStore('e', false);
PASS Exception was thrown.
-PASS db.createObjectStore('e', false); threw TypeError: Not an object.
+PASS db.createObjectStore('e', false); threw TypeError: Type error
trans.objectStore('b').put({'a': 0}, 0)
trans.objectStore('a').get(0)
PASS event.target.result.a is {a: 0}
Modified: trunk/LayoutTests/storage/indexeddb/create-object-store-options-private-expected.txt (207805 => 207806)
--- trunk/LayoutTests/storage/indexeddb/create-object-store-options-private-expected.txt 2016-10-25 04:40:23 UTC (rev 207805)
+++ trunk/LayoutTests/storage/indexeddb/create-object-store-options-private-expected.txt 2016-10-25 05:16:00 UTC (rev 207806)
@@ -15,10 +15,10 @@
trans.objectStore('a').put({'a': 0})
Expecting TypeError exception from db.createObjectStore('d', 'bar');
PA
[webkit-changes] [207805] trunk
Title: [207805] trunk
Revision 207805
Author achristen...@apple.com
Date 2016-10-24 21:40:23 -0700 (Mon, 24 Oct 2016)
Log Message
URLParser should match old URL::parse with %2E in path
https://bugs.webkit.org/show_bug.cgi?id=163929
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:
Source/WebCore:
Covered by updated API tests, which show that URLParser now matches URL::parse in these cases.
Also covered by newly failing web platform tests, which were failing before URLParser was enabled.
If https://github.com/whatwg/url/issues/87 is resolved we can change behavior to match.
* platform/URLParser.cpp:
(WebCore::URLParser::isSingleDotPathSegment):
(WebCore::URLParser::isDoubleDotPathSegment):
(WebCore::URLParser::consumeSingleDotPathSegment):
(WebCore::URLParser::consumeDoubleDotPathSegment):
(WebCore::URLParser::parse):
(WebCore::URLParser::isPercentEncodedDot): Deleted.
Tools:
* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
LayoutTests:
* fast/url/path-expected.txt:
* fast/url/standard-url-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/path-expected.txt
trunk/LayoutTests/fast/url/standard-url-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (207804 => 207805)
--- trunk/LayoutTests/ChangeLog 2016-10-25 04:19:09 UTC (rev 207804)
+++ trunk/LayoutTests/ChangeLog 2016-10-25 04:40:23 UTC (rev 207805)
@@ -1,3 +1,13 @@
+2016-10-24 Alex Christensen
+
+URLParser should match old URL::parse with %2E in path
+https://bugs.webkit.org/show_bug.cgi?id=163929
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/url/path-expected.txt:
+* fast/url/standard-url-expected.txt:
+
2016-10-24 Zalan Bujtas
Do not update selection rect on dirty lineboxes.
Modified: trunk/LayoutTests/fast/url/path-expected.txt (207804 => 207805)
--- trunk/LayoutTests/fast/url/path-expected.txt 2016-10-25 04:19:09 UTC (rev 207804)
+++ trunk/LayoutTests/fast/url/path-expected.txt 2016-10-25 04:40:23 UTC (rev 207805)
@@ -14,9 +14,9 @@
PASS canonicalize('http://example.com/foo/bar/../ton/../../a') is 'http://example.com/a'
PASS canonicalize('http://example.com/foo/../../..') is 'http://example.com/'
PASS canonicalize('http://example.com/foo/../../../ton') is 'http://example.com/ton'
-PASS canonicalize('http://example.com/foo/%2e') is 'http://example.com/foo/'
-PASS canonicalize('http://example.com/foo/%2e%2') is 'http://example.com/foo/.%2'
-PASS canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') is 'http://example.com/..bar'
+FAIL canonicalize('http://example.com/foo/%2e') should be http://example.com/foo/. Was http://example.com/foo/%2e.
+FAIL canonicalize('http://example.com/foo/%2e%2') should be http://example.com/foo/.%2. Was http://example.com/foo/%2e%2.
+FAIL canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') should be http://example.com/..bar. Was http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar.
PASS canonicalize('http://example.com../..') is 'http://example.com//'
PASS canonicalize('http://example.com/foo/bar//../..') is 'http://example.com/foo/'
PASS canonicalize('http://example.com/foo/bar//..') is 'http://example.com/foo/bar/'
Modified: trunk/LayoutTests/fast/url/standard-url-expected.txt (207804 => 207805)
--- trunk/LayoutTests/fast/url/standard-url-expected.txt 2016-10-25 04:19:09 UTC (rev 207804)
+++ trunk/LayoutTests/fast/url/standard-url-expected.txt 2016-10-25 04:40:23 UTC (rev 207805)
@@ -9,7 +9,7 @@
PASS canonicalize('http://www.google.com') is 'http://www.google.com/'
PASS canonicalize('http:user:@google.com:99?foo') is 'http://u...@google.com:99/?foo'
PASS canonicalize('http://192.0x00A80001') is 'http://192.168.0.1/'
-PASS canonicalize('http://www/foo%2Ehtml') is 'http://www/foo.html'
+FAIL canonicalize('http://www/foo%2Ehtml') should be http://www/foo.html. Was http://www/foo%2Ehtml.
PASS canonicalize('http://user:pass@/') is 'http://user:pass@/'
PASS canonicalize('http://%25DOMAIN:foo...@foodomain.com/') is 'http://%25DOMAIN:foo...@foodomain.com/'
PASS canonicalize('http:www.google.com\\foo') is 'http://www.google.com/foo'
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (207804 => 207805)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-25 04:19:09 UTC (rev 207804)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-25 04:40:23
[webkit-changes] [207804] trunk
Title: [207804] trunk
Revision 207804
Author za...@apple.com
Date 2016-10-24 21:19:09 -0700 (Mon, 24 Oct 2016)
Log Message
Do not update selection rect on dirty lineboxes.
https://bugs.webkit.org/show_bug.cgi?id=163862
Reviewed by Simon Fraser.
Source/WebCore:
In certain cases RenderBlock::updateFirstLetter() triggers
unwanted render tree mutation while the caller assumes intact renderers.
This patch ensures that no renderers gets destroyed while computing the preferred widths
when we are outside of layout context.
Test: fast/css-generated-content/dynamic-first-letter-selection-clear-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderBlock.h:
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::insertOrMoveMarkerRendererIfNeeded):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::updateFirstLetter):
* rendering/RenderRubyRun.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::updateFirstLetter):
* rendering/RenderTable.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::updateFirstLetter):
* rendering/svg/RenderSVGText.h:
LayoutTests:
* fast/css-generated-content/dynamic-first-letter-selection-clear-crash-expected.txt: Added.
* fast/css-generated-content/dynamic-first-letter-selection-clear-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderListItem.cpp
trunk/Source/WebCore/rendering/RenderRubyRun.cpp
trunk/Source/WebCore/rendering/RenderRubyRun.h
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/RenderTable.h
trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGText.h
Added Paths
trunk/LayoutTests/fast/css-generated-content/dynamic-first-letter-selection-clear-crash-expected.txt
trunk/LayoutTests/fast/css-generated-content/dynamic-first-letter-selection-clear-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (207803 => 207804)
--- trunk/LayoutTests/ChangeLog 2016-10-25 03:46:32 UTC (rev 207803)
+++ trunk/LayoutTests/ChangeLog 2016-10-25 04:19:09 UTC (rev 207804)
@@ -1,3 +1,14 @@
+2016-10-24 Zalan Bujtas
+
+Do not update selection rect on dirty lineboxes.
+https://bugs.webkit.org/show_bug.cgi?id=163862
+
+
+Reviewed by Simon Fraser.
+
+* fast/css-generated-content/dynamic-first-letter-selection-clear-crash-expected.txt: Added.
+* fast/css-generated-content/dynamic-first-letter-selection-clear-crash.html: Added.
+
2016-10-24 Ryan Haddad
Unreviewed, rolling out r207795.
Added: trunk/LayoutTests/fast/css-generated-content/dynamic-first-letter-selection-clear-crash-expected.txt (0 => 207804)
--- trunk/LayoutTests/fast/css-generated-content/dynamic-first-letter-selection-clear-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/dynamic-first-letter-selection-clear-crash-expected.txt 2016-10-25 04:19:09 UTC (rev 207804)
@@ -0,0 +1,2 @@
+Pass if
+no crash.
Added: trunk/LayoutTests/fast/css-generated-content/dynamic-first-letter-selection-clear-crash.html (0 => 207804)
--- trunk/LayoutTests/fast/css-generated-content/dynamic-first-letter-selection-clear-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/dynamic-first-letter-selection-clear-crash.html 2016-10-25 04:19:09 UTC (rev 207804)
@@ -0,0 +1,32 @@
+
+
+
+This tests that we can clear selection properly on dynamic content with first letter.
+
+.floatClass::first-letter {
+ float: right;
+}
+
+#innerBody {
+ column-count: 2;
+}
+
+
+
+
+Pass ifno crash.
+
+ if (window.testRunner)
+testRunner.dumpAsText();
+ innerBody.style.webkitWritingMode = "vertical-rl";
+ innerBody.className = "floatClass";
+
+ document.getSelection().setBaseAndExtent(span, 0, innerBody, innerBody.childNodes.length);
+ window.getSelection().modify("extend", "left", "documentboundary");
+ innerBody.scrollIntoViewIfNeeded(true);
+ li.style.cssText = "float: right; height: 40px; width: 40px;";
+ document.body.offsetHeight;
+ li.style.cssText = "";
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (207803 => 207804)
--- trunk/Source/WebCore/ChangeLog 2016-10-25 03:46:32 UTC (rev 207803)
+++ trunk/Source/WebCore/ChangeLog 2016-10-25 04:19:09 UTC (rev 207804)
@@ -1,3 +1,34 @@
+2016-10-24 Zalan Bujtas
+
+Do not update selection rect on dirty lineboxes.
+https://bugs.webkit.org/show_bug.cgi?id=163862
+
+
+Reviewed by Simon Fraser.
+
+In certain cases RenderBlock::updateFirstLetter() triggers
+unwanted render tree mutation while the caller assumes intact renderers.
+This patch ensures that no renderers gets destroyed while computing the preferred widths
+when we a
[webkit-changes] [207803] trunk
Title: [207803] trunk
Revision 207803
Author ryanhad...@apple.com
Date 2016-10-24 20:46:32 -0700 (Mon, 24 Oct 2016)
Log Message
Unreviewed, rolling out r207795.
Introduced API test failures on iOS and macOS.
Reverted changeset:
"URLParser should match old URL::parse with %2E in path"
https://bugs.webkit.org/show_bug.cgi?id=163929
http://trac.webkit.org/changeset/207795
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/path-expected.txt
trunk/LayoutTests/fast/url/standard-url-expected.txt
trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (207802 => 207803)
--- trunk/LayoutTests/ChangeLog 2016-10-25 03:23:14 UTC (rev 207802)
+++ trunk/LayoutTests/ChangeLog 2016-10-25 03:46:32 UTC (rev 207803)
@@ -1,3 +1,15 @@
+2016-10-24 Ryan Haddad
+
+Unreviewed, rolling out r207795.
+
+Introduced API test failures on iOS and macOS.
+
+Reverted changeset:
+
+"URLParser should match old URL::parse with %2E in path"
+https://bugs.webkit.org/show_bug.cgi?id=163929
+http://trac.webkit.org/changeset/207795
+
2016-10-24 Yusuke Suzuki
Arrow functions with concise bodies cannot return regular expressions
Modified: trunk/LayoutTests/fast/url/path-expected.txt (207802 => 207803)
--- trunk/LayoutTests/fast/url/path-expected.txt 2016-10-25 03:23:14 UTC (rev 207802)
+++ trunk/LayoutTests/fast/url/path-expected.txt 2016-10-25 03:46:32 UTC (rev 207803)
@@ -14,9 +14,9 @@
PASS canonicalize('http://example.com/foo/bar/../ton/../../a') is 'http://example.com/a'
PASS canonicalize('http://example.com/foo/../../..') is 'http://example.com/'
PASS canonicalize('http://example.com/foo/../../../ton') is 'http://example.com/ton'
-FAIL canonicalize('http://example.com/foo/%2e') should be http://example.com/foo/. Was http://example.com/foo/%2e.
-FAIL canonicalize('http://example.com/foo/%2e%2') should be http://example.com/foo/.%2. Was http://example.com/foo/%2e%2.
-FAIL canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') should be http://example.com/..bar. Was http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar.
+PASS canonicalize('http://example.com/foo/%2e') is 'http://example.com/foo/'
+PASS canonicalize('http://example.com/foo/%2e%2') is 'http://example.com/foo/.%2'
+PASS canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') is 'http://example.com/..bar'
PASS canonicalize('http://example.com../..') is 'http://example.com//'
PASS canonicalize('http://example.com/foo/bar//../..') is 'http://example.com/foo/'
PASS canonicalize('http://example.com/foo/bar//..') is 'http://example.com/foo/bar/'
Modified: trunk/LayoutTests/fast/url/standard-url-expected.txt (207802 => 207803)
--- trunk/LayoutTests/fast/url/standard-url-expected.txt 2016-10-25 03:23:14 UTC (rev 207802)
+++ trunk/LayoutTests/fast/url/standard-url-expected.txt 2016-10-25 03:46:32 UTC (rev 207803)
@@ -9,7 +9,7 @@
PASS canonicalize('http://www.google.com') is 'http://www.google.com/'
PASS canonicalize('http:user:@google.com:99?foo') is 'http://u...@google.com:99/?foo'
PASS canonicalize('http://192.0x00A80001') is 'http://192.168.0.1/'
-FAIL canonicalize('http://www/foo%2Ehtml') should be http://www/foo.html. Was http://www/foo%2Ehtml.
+PASS canonicalize('http://www/foo%2Ehtml') is 'http://www/foo.html'
PASS canonicalize('http://user:pass@/') is 'http://user:pass@/'
PASS canonicalize('http://%25DOMAIN:foo...@foodomain.com/') is 'http://%25DOMAIN:foo...@foodomain.com/'
PASS canonicalize('http:www.google.com\\foo') is 'http://www.google.com/foo'
Modified: trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt (207802 => 207803)
--- trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt 2016-10-25 03:23:14 UTC (rev 207802)
+++ trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt 2016-10-25 03:46:32 UTC (rev 207803)
@@ -123,9 +123,9 @@
PASS Testing Request url 'http://example.com/foo/bar/../ton/../../a' with base 'about:blank'
PASS Testing Request url 'http://example.com/foo/../../..' with base 'about:blank'
PASS Testing Request url 'http://example.com/foo/../../../ton' with base 'about:blank'
-FAIL Testing Request url 'http://example.com/foo/%2e' with base 'about:blank' assert_equals: expected "http://example.com/foo/" but got "http://example.com/foo/%2e"
-FAIL Testing Request url 'http://example.com/foo/%2e%2' with base 'about:blank' assert_equals: expected "http://example.com/foo/.%2" but got "http://example.com/foo/%2e%2"
-FAIL
[webkit-changes] [207801] branches/safari-602-branch/Source
Title: [207801] branches/safari-602-branch/Source
Revision 207801
Author matthew_han...@apple.com
Date 2016-10-24 20:23:10 -0700 (Mon, 24 Oct 2016)
Log Message
Merge r204472. rdar://problem/28544885
Modified Paths
branches/safari-602-branch/Source/WTF/ChangeLog
branches/safari-602-branch/Source/WTF/wtf/Assertions.h
branches/safari-602-branch/Source/WebCore/ChangeLog
branches/safari-602-branch/Source/WebCore/loader/FrameLoader.cpp
branches/safari-602-branch/Source/WebCore/platform/MemoryPressureHandler.cpp
branches/safari-602-branch/Source/WebCore/platform/MemoryPressureHandler.h
branches/safari-602-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.mm
branches/safari-602-branch/Source/WebKit2/ChangeLog
branches/safari-602-branch/Source/WebKit2/NetworkProcess/Downloads/Download.cpp
branches/safari-602-branch/Source/WebKit2/NetworkProcess/NetworkProcess.cpp
branches/safari-602-branch/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
branches/safari-602-branch/Source/WebKit2/Platform/IPC/Connection.cpp
branches/safari-602-branch/Source/WebKit2/Shared/ChildProcess.cpp
branches/safari-602-branch/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm
branches/safari-602-branch/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp
branches/safari-602-branch/Source/WebKit2/UIProcess/ProcessThrottler.cpp
branches/safari-602-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp
branches/safari-602-branch/Source/WebKit2/UIProcess/WebProcessProxy.cpp
branches/safari-602-branch/Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm
branches/safari-602-branch/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp
branches/safari-602-branch/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp
branches/safari-602-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
branches/safari-602-branch/Source/WebKit2/WebProcess/WebProcess.cpp
Diff
Modified: branches/safari-602-branch/Source/WTF/ChangeLog (207800 => 207801)
--- branches/safari-602-branch/Source/WTF/ChangeLog 2016-10-25 03:23:02 UTC (rev 207800)
+++ branches/safari-602-branch/Source/WTF/ChangeLog 2016-10-25 03:23:10 UTC (rev 207801)
@@ -1,3 +1,20 @@
+2016-10-24 Matthew Hanson
+
+Merge r204472. rdar://problem/28544885
+
+2016-08-15 Keith Rollin
+
+Rename LOG_ALWAYS
+https://bugs.webkit.org/show_bug.cgi?id=160768
+
+Rename LOG_ALWAYS and friends, given that the first parameter to it is
+a boolean _expression_ that determines whether or not logging should be
+performed.
+
+Reviewed by Chris Dumez.
+
+* wtf/Assertions.h:
+
2016-10-19 Matthew Hanson
Merge r205859. rdar://problem/28635084
Modified: branches/safari-602-branch/Source/WTF/wtf/Assertions.h (207800 => 207801)
--- branches/safari-602-branch/Source/WTF/wtf/Assertions.h 2016-10-25 03:23:02 UTC (rev 207800)
+++ branches/safari-602-branch/Source/WTF/wtf/Assertions.h 2016-10-25 03:23:10 UTC (rev 207801)
@@ -84,8 +84,8 @@
#define LOG_DISABLED ASSERTIONS_DISABLED_DEFAULT
#endif
-#ifndef LOG_ALWAYS_DISABLED
-#define LOG_ALWAYS_DISABLED !(USE(OS_LOG))
+#ifndef RELEASE_LOG_DISABLED
+#define RELEASE_LOG_DISABLED !(USE(OS_LOG))
#endif
#if COMPILER(GCC_OR_CLANG)
@@ -380,17 +380,19 @@
#define LOG_VERBOSE(channel, ...) WTFLogVerbose(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, &JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
#endif
-/* LOG_ALWAYS */
+/* RELEASE_LOG */
#define WTF_LOGGING_PREFIX "#WK: "
-#if LOG_ALWAYS_DISABLED
-#define LOG_ALWAYS(isAllowed, format, ...) ((void)0)
-#define LOG_ALWAYS_ERROR(isAllowed, format, ...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, format, ##__VA_ARGS__)
+#if RELEASE_LOG_DISABLED
+#define RELEASE_LOG(format, ...) ((void)0)
+#define RELEASE_LOG_ERROR(format, ...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, format, ##__VA_ARGS__)
#else
#define WTF_LOG_DEFAULT OS_LOG_DEFAULT
-#define LOG_ALWAYS(isAllowed, format, ...) do { if (isAllowed) os_log(WTF_LOG_DEFAULT, WTF_LOGGING_PREFIX format, ##__VA_ARGS__); } while (0)
-#define LOG_ALWAYS_ERROR(isAllowed, format, ...) do { if (isAllowed) os_log_error(WTF_LOG_DEFAULT, WTF_LOGGING_PREFIX format, ##__VA_ARGS__); } while (0)
+#define RELEASE_LOG(format, ...) os_log(WTF_LOG_DEFAULT, WTF_LOGGING_PREFIX format, ##__VA_ARGS__)
+#define RELEASE_LOG_ERROR(format, ...) os_log_error(WTF_LOG_DEFAULT, WTF_LOGGING_PREFIX format, ##__VA_ARGS__)
#endif
+#define RELEASE_LOG_IF(isAllowed, format, ...) do { if (isAllowed) RELEASE_LOG(format, ##__VA_ARGS__); } while (0)
+#define RELEASE_LOG_ERROR_IF(isAllowed, format, ...) do { if (isAllowed) RELEASE_LOG_ERROR(format, ##__VA_ARGS__); } while (0)
/* RELEASE_ASSERT */
Modified: branches/safari-602-branch/Source/WebCore/ChangeLog (207800 => 207801)
--- branches/safari-602-branch/Source/WebCore/ChangeLog 2016-10-25 03:23:02 UTC (rev 207800)
+++ branches/safari-602-branch/Source/We
[webkit-changes] [207800] branches/safari-602-branch/Source
Title: [207800] branches/safari-602-branch/Source Revision 207800 Author matthew_han...@apple.com Date 2016-10-24 20:23:02 -0700 (Mon, 24 Oct 2016) Log Message Versioning. Modified Paths branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig (207799 => 207800) --- branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2016-10-25 02:55:22 UTC (rev 207799) +++ branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2016-10-25 03:23:02 UTC (rev 207800) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 3; -TINY_VERSION = 4; +TINY_VERSION = 5; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig (207799 => 207800) --- branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig 2016-10-25 02:55:22 UTC (rev 207799) +++ branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig 2016-10-25 03:23:02 UTC (rev 207800) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 3; -TINY_VERSION = 4; +TINY_VERSION = 5; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (207799 => 207800) --- branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2016-10-25 02:55:22 UTC (rev 207799) +++ branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2016-10-25 03:23:02 UTC (rev 207800) @@ -1,6 +1,6 @@ MAJOR_VERSION = 602; MINOR_VERSION = 3; -TINY_VERSION = 4; +TINY_VERSION = 5; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig (207799 => 207800) --- branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2016-10-25 02:55:22 UTC (rev 207799) +++ branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2016-10-25 03:23:02 UTC (rev 207800) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 3; -TINY_VERSION = 4; +TINY_VERSION = 5; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig (207799 => 207800) --- branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig 2016-10-25 02:55:22 UTC (rev 207799) +++ branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig 2016-10-25 03:23:02 UTC (rev 207800) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 3; -TINY_VERSION = 4; +TINY_VERSION = 5; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207802] branches/safari-602-branch/Source/WebKit2
Title: [207802] branches/safari-602-branch/Source/WebKit2
Revision 207802
Author matthew_han...@apple.com
Date 2016-10-24 20:23:14 -0700 (Mon, 24 Oct 2016)
Log Message
Merge r206762. rdar://problem/28544885
Modified Paths
branches/safari-602-branch/Source/WebKit2/ChangeLog
branches/safari-602-branch/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
branches/safari-602-branch/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp
branches/safari-602-branch/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp
branches/safari-602-branch/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp
Diff
Modified: branches/safari-602-branch/Source/WebKit2/ChangeLog (207801 => 207802)
--- branches/safari-602-branch/Source/WebKit2/ChangeLog 2016-10-25 03:23:10 UTC (rev 207801)
+++ branches/safari-602-branch/Source/WebKit2/ChangeLog 2016-10-25 03:23:14 UTC (rev 207802)
@@ -1,5 +1,33 @@
2016-10-24 Matthew Hanson
+Merge r206762. rdar://problem/28544885
+
+2016-10-03 Keith Rollin
+
+More logging to diagnose "WebKit encountered an internal error" messages
+https://bugs.webkit.org/show_bug.cgi?id=162754
+
+Reviewed by Antti Koivisto.
+
+Add more logging around calls to internalError, as well as some
+low-level logging around SharedMemory, and mach_vm_map in particular.
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::startNetworkLoad):
+* Platform/Logging.h:
+* Platform/mac/SharedMemoryMac.cpp:
+(WebKit::SharedMemory::allocate):
+(WebKit::makeMemoryEntry):
+(WebKit::SharedMemory::map):
+(WebKit::SharedMemory::~SharedMemory):
+* WebProcess/Network/WebLoaderStrategy.cpp:
+(WebKit::WebLoaderStrategy::networkProcessCrashed):
+(WebKit::WebLoaderStrategy::loadResourceSynchronously):
+* WebProcess/Network/WebResourceLoader.cpp:
+(WebKit::WebResourceLoader::didReceiveResource):
+
+2016-10-24 Matthew Hanson
+
Merge r204472. rdar://problem/28544885
2016-08-15 Keith Rollin
Modified: branches/safari-602-branch/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp (207801 => 207802)
--- branches/safari-602-branch/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2016-10-25 03:23:10 UTC (rev 207801)
+++ branches/safari-602-branch/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2016-10-25 03:23:14 UTC (rev 207802)
@@ -216,6 +216,7 @@
auto* networkSession = SessionTracker::networkSession(parameters.sessionID);
if (!networkSession) {
WTFLogAlways("Attempted to create a NetworkLoad with a session (id=%" PRIu64 ") that does not exist.", parameters.sessionID.sessionID());
+RELEASE_LOG_ERROR_IF_ALLOWED("startNetworkLoad: Attempted to create a NetworkLoad with a session that does not exist (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ", sessionID=%" PRIu64 ")", m_parameters.webPageID, m_parameters.webFrameID, m_parameters.identifier, parameters.sessionID.sessionID());
didFailLoading(internalError(request.url()));
return;
}
Modified: branches/safari-602-branch/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp (207801 => 207802)
--- branches/safari-602-branch/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp 2016-10-25 03:23:10 UTC (rev 207801)
+++ branches/safari-602-branch/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp 2016-10-25 03:23:14 UTC (rev 207802)
@@ -29,6 +29,7 @@
#include "ArgumentDecoder.h"
#include "ArgumentEncoder.h"
#include "Arguments.h"
+#include "Logging.h"
#include "MachPort.h"
#include
#include
@@ -106,7 +107,11 @@
mach_vm_address_t address;
kern_return_t kr = mach_vm_allocate(mach_task_self(), &address, round_page(size), VM_FLAGS_ANYWHERE);
if (kr != KERN_SUCCESS) {
+#if RELEASE_LOG_DISABLED
LOG_ERROR("Failed to allocate mach_vm_allocate shared memory (%zu bytes). %s (%x)", size, mach_error_string(kr), kr);
+#else
+RELEASE_LOG_ERROR("%p - SharedMemory::allocate: Failed to allocate mach_vm_allocate shared memory (%zu bytes). %{public}s (%x)", nullptr, size, mach_error_string(kr), kr);
+#endif
return nullptr;
}
@@ -139,7 +144,11 @@
mach_port_t port;
kern_return_t kr = mach_make_memory_entry_64(mach_task_self(), &memoryObjectSize, offset, machProtection(protection) | VM_PROT_IS_MASK | MAP_MEM_VM_SHARE, &port, parentEntry);
if (kr != KERN_SUCCESS) {
+#if RELEASE_LOG_DISABLED
LOG_ERROR("Failed to create a mach port for shared memory. %s (%x)", mach_error_string(kr), kr);
+#else
+RELEASE_LOG_ERROR("%p - SharedMemory::makeMemoryEntry: Failed to create a mach port for shared memory. %{public}s (%x)", nullptr, mach_error_string(kr), kr);
+#endif
return { };
}
@@ -175,8 +184,15 @@
vm_prot_t vmProtection = machProtection(protection);
[webkit-changes] [207799] trunk/Source/WebCore
Title: [207799] trunk/Source/WebCore
Revision 207799
Author utatane@gmail.com
Date 2016-10-24 19:55:22 -0700 (Mon, 24 Oct 2016)
Log Message
Unreviewed, attempt to fix Windows build after r207787
https://bugs.webkit.org/show_bug.cgi?id=163657
Make the constructor public in DOMJIT::AbstractHeapRepository to make Windows bot green.
It's a bit unfortunate that we need to introduce a workaround here.
* domjit/DOMJITAbstractHeapRepository.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (207798 => 207799)
--- trunk/Source/WebCore/ChangeLog 2016-10-25 02:35:59 UTC (rev 207798)
+++ trunk/Source/WebCore/ChangeLog 2016-10-25 02:55:22 UTC (rev 207799)
@@ -1,3 +1,13 @@
+2016-10-24 Yusuke Suzuki
+
+Unreviewed, attempt to fix Windows build after r207787
+https://bugs.webkit.org/show_bug.cgi?id=163657
+
+Make the constructor public in DOMJIT::AbstractHeapRepository to make Windows bot green.
+It's a bit unfortunate that we need to introduce a workaround here.
+
+* domjit/DOMJITAbstractHeapRepository.h:
+
2016-10-24 Chris Dumez
event.(dataTransfer|clipboardData).getData('text/html') (onpaste, ondrop)
Modified: trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.h (207798 => 207799)
--- trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.h 2016-10-25 02:35:59 UTC (rev 207798)
+++ trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.h 2016-10-25 02:55:22 UTC (rev 207799)
@@ -45,7 +45,7 @@
class AbstractHeapRepository {
-WTF_MAKE_NONCOPYABLE(AbstractHeapRepository);
+WTF_MAKE_NONCOPYABLE(AbstractHeapRepository);
public:
static const AbstractHeapRepository& shared();
@@ -55,8 +55,6 @@
DOMJIT_ABSTRACT_HEAP_LIST(DOMJIT_DEFINE_MEMBER)
#undef DOMJIT_DEFINE_MEMBER
-private:
-friend class NeverDestroyed;
AbstractHeapRepository();
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207798] trunk
Title: [207798] trunk Revision 207798 Author utatane@gmail.com Date 2016-10-24 19:35:59 -0700 (Mon, 24 Oct 2016) Log Message Arrow functions with concise bodies cannot return regular expressions https://bugs.webkit.org/show_bug.cgi?id=163162 Reviewed by Filip Pizlo. JSTests: * ChakraCore/test/Operators/instanceof.baseline-jsc: * ChakraCore/test/Regex/nul_character.baseline-jsc: * ChakraCore/test/es5/Lex_u3.baseline-jsc: * stress/parse-regexp-as-token.js: Added. (shouldBe): Source/_javascript_Core: When we encounter the RegExp in the parser, we first scan it as / or /=. And if / or /= is parsed under the primary _expression_ context, we rescan it as RegExp. However, we did not update the token record information. So the token record still says "I'm / or /=". When we parse the string "() => /hello/", the last token becomes "/", which is the first character of the RegExp, instead of "/hello/". Since the arrow function parsing utilizes the end offset of the last token, we accidentally recognize the range of the above arrow function as "() => /". In this patch, we update the token when rescanning under the RegExp context. This logic is similar to parsing Tail Template Literal token. We also refine the error message for regular _expression_ literals. And since the REGEXP token is now introduced, the other error messages using that token are improved too. Currently, unterminated error messages can be seen in Parser.cpp. However, these messages cannot be shown to users if the lexer has m_error. So these code is meaningless. I'll move these tokenizing errors to the lexer in the subsequent patch[1]. [1]: https://bugs.webkit.org/show_bug.cgi?id=163928 * parser/Lexer.cpp: (JSC::Lexer::fillTokenInfo): (JSC::Lexer::lex): (JSC::Lexer::scanRegExp): (JSC::Lexer::scanTrailingTemplateString): (JSC::Lexer::skipRegExp): Deleted. * parser/Lexer.h: (JSC::Lexer::getToken): * parser/Parser.cpp: (JSC::Parser::parseAssignmentExpression): * parser/Parser.h: (JSC::Parser::getToken): * parser/ParserTokens.h: LayoutTests: * fast/regex/dom/non-pattern-characters-expected.txt: * js/arrowfunction-syntax-errors-expected.txt: * js/regexp-compile-crash-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T4-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T3-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T3-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.2_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T3-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T3-expected.txt: Modified Paths trunk/JSTests/ChakraCore/test/Operators/instanceof.baseline-jsc trunk/JSTests/ChakraCore/test/Regex/nul_character.baseline-jsc trunk/JSTests/ChakraCore/test/es5/Lex_u3.baseline-jsc trunk/JSTests/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/regex/dom/non-pattern-characters-expected.txt trunk/LayoutTests/js/arrowfunction-syntax-errors-expected.txt trunk/LayoutTests/js/regexp-compile-crash-expected.txt trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T1-expected.txt trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T4-expected.txt trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T2-expected.txt trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T1-expected.txt trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T3-expected.txt trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T1-expected.txt trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T3-expected.txt trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A
[webkit-changes] [207797] trunk
Title: [207797] trunk
Revision 207797
Author cdu...@apple.com
Date 2016-10-24 18:48:42 -0700 (Mon, 24 Oct 2016)
Log Message
event.(dataTransfer|clipboardData).getData('text/html') (onpaste, ondrop)
https://bugs.webkit.org/show_bug.cgi?id=19893
Reviewed by Ryosuke Niwa.
Source/WebCore:
We now write selection as HTML as well to the pasteboard so that
event.(dataTransfer|clipboardData).getData('text/html') now works.
I have verified manually that it is still possible to copy text from
Safari and paste it to Excel 2011 Mac after this change. The text is
now pasted as HTML instead of text, which is fine because Excel can
display HTML.
No new tests, unskipped existing tests.
* editing/Editor.h:
* editing/mac/EditorMac.mm:
(WebCore::Editor::selectionInHTMLFormat):
(WebCore::Editor::writeSelectionToPasteboard):
* platform/Pasteboard.h:
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::write):
LayoutTests:
Unskip corresponding tests on Mac.
* editing/pasteboard/onpaste-text-html-expected.txt:
* fast/events/ondrop-text-html-expected.txt:
* platform/mac/TestExpectations:
* platform/wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt
trunk/LayoutTests/fast/events/ondrop-text-html-expected.txt
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/editing/mac/EditorMac.mm
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/mac/PasteboardMac.mm
Diff
Modified: trunk/LayoutTests/ChangeLog (207796 => 207797)
--- trunk/LayoutTests/ChangeLog 2016-10-25 01:38:19 UTC (rev 207796)
+++ trunk/LayoutTests/ChangeLog 2016-10-25 01:48:42 UTC (rev 207797)
@@ -1,3 +1,18 @@
+2016-10-24 Chris Dumez
+
+event.(dataTransfer|clipboardData).getData('text/html') (onpaste, ondrop)
+https://bugs.webkit.org/show_bug.cgi?id=19893
+
+
+Reviewed by Ryosuke Niwa.
+
+Unskip corresponding tests on Mac.
+
+* editing/pasteboard/onpaste-text-html-expected.txt:
+* fast/events/ondrop-text-html-expected.txt:
+* platform/mac/TestExpectations:
+* platform/wk2/TestExpectations:
+
2016-10-24 Alex Christensen
URLParser should match old URL::parse with %2E in path
Modified: trunk/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt (207796 => 207797)
--- trunk/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt 2016-10-25 01:38:19 UTC (rev 207796)
+++ trunk/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt 2016-10-25 01:48:42 UTC (rev 207797)
@@ -1,5 +1,5 @@
CONSOLE MESSAGE: line 21: text/plain: This test verifies that we can get text/html from the clipboard during an onpaste event.
-CONSOLE MESSAGE: line 23: text/html: This test verifies that we can get text/html from the clipboard during an onpaste event.
+CONSOLE MESSAGE: line 23: text/html: This test verifies that we can get text/html from the clipboard during an onpaste event.
This test verifies that we can get text/html from the clipboard during an onpaste event. This test requires DRT.
Paste content in this div.This test verifies that we can get text/html from the clipboard during an onpaste event.
PASS
Modified: trunk/LayoutTests/fast/events/ondrop-text-html-expected.txt (207796 => 207797)
--- trunk/LayoutTests/fast/events/ondrop-text-html-expected.txt 2016-10-25 01:38:19 UTC (rev 207796)
+++ trunk/LayoutTests/fast/events/ondrop-text-html-expected.txt 2016-10-25 01:48:42 UTC (rev 207797)
@@ -1,4 +1,4 @@
CONSOLE MESSAGE: line 21: text/plain: This test verifies that we can get text/html from the drag object during an ondrop event.
-CONSOLE MESSAGE: line 23: text/html: This test verifies that we can get text/html from the drag object during an ondrop event.
+CONSOLE MESSAGE: line 23: text/html: This test verifies that we can get text/html from the drag object during an ondrop event.
This test verifies that we can get text/html from the drag object during an ondrop event. This test requires DRT.
PASS
Modified: trunk/LayoutTests/platform/mac/TestExpectations (207796 => 207797)
--- trunk/LayoutTests/platform/mac/TestExpectations 2016-10-25 01:38:19 UTC (rev 207796)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-10-25 01:48:42 UTC (rev 207797)
@@ -96,11 +96,6 @@
# Need to add functionality to DumpRenderTree to handle scrollbar policy changes
fast/overflow/scrollbar-restored-and-then-locked.html
-# Mac port doesn't put text/html on the pasteboard for app compatibility: https://bugs.webkit.org/show_bug.cgi?id=19893
-editing/pasteboard/onpaste-text-html-types.html
-editing/pasteboard/onpaste-text-html.html
-fast/events/ondrop-text-html.html
-
# EventSendingController does not send events on areas outside the WebView.
scrollbars/scrollbar-click-does-not-blur-content.html
Modified: trunk/LayoutTe
[webkit-changes] [207796] tags/Safari-602.3.4/
Title: [207796] tags/Safari-602.3.4/ Revision 207796 Author matthew_han...@apple.com Date 2016-10-24 18:38:19 -0700 (Mon, 24 Oct 2016) Log Message New tag. Added Paths tags/Safari-602.3.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207795] trunk
Title: [207795] trunk
Revision 207795
Author achristen...@apple.com
Date 2016-10-24 18:31:42 -0700 (Mon, 24 Oct 2016)
Log Message
URLParser should match old URL::parse with %2E in path
https://bugs.webkit.org/show_bug.cgi?id=163929
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:
Source/WebCore:
Covered by updated API tests, which show that URLParser now matches URL::parse in these cases.
Also covered by newly failing web platform tests, which were failing before URLParser was enabled.
If https://github.com/whatwg/url/issues/87 is resolved we can change behavior to match.
* platform/URLParser.cpp:
(WebCore::URLParser::isSingleDotPathSegment):
(WebCore::URLParser::isDoubleDotPathSegment):
(WebCore::URLParser::consumeSingleDotPathSegment):
(WebCore::URLParser::consumeDoubleDotPathSegment):
(WebCore::URLParser::parse):
(WebCore::URLParser::isPercentEncodedDot): Deleted.
Tools:
* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
LayoutTests:
* fast/url/path-expected.txt:
* fast/url/standard-url-expected.txt:
* fetch/fetch-url-serialization-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/path-expected.txt
trunk/LayoutTests/fast/url/standard-url-expected.txt
trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (207794 => 207795)
--- trunk/LayoutTests/ChangeLog 2016-10-25 00:45:03 UTC (rev 207794)
+++ trunk/LayoutTests/ChangeLog 2016-10-25 01:31:42 UTC (rev 207795)
@@ -1,3 +1,14 @@
+2016-10-24 Alex Christensen
+
+URLParser should match old URL::parse with %2E in path
+https://bugs.webkit.org/show_bug.cgi?id=163929
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/url/path-expected.txt:
+* fast/url/standard-url-expected.txt:
+* fetch/fetch-url-serialization-expected.txt:
+
2016-10-24 Brady Eidson
IndexedDB 2.0: Support new IDBKeyRange interfaces.
Modified: trunk/LayoutTests/fast/url/path-expected.txt (207794 => 207795)
--- trunk/LayoutTests/fast/url/path-expected.txt 2016-10-25 00:45:03 UTC (rev 207794)
+++ trunk/LayoutTests/fast/url/path-expected.txt 2016-10-25 01:31:42 UTC (rev 207795)
@@ -14,9 +14,9 @@
PASS canonicalize('http://example.com/foo/bar/../ton/../../a') is 'http://example.com/a'
PASS canonicalize('http://example.com/foo/../../..') is 'http://example.com/'
PASS canonicalize('http://example.com/foo/../../../ton') is 'http://example.com/ton'
-PASS canonicalize('http://example.com/foo/%2e') is 'http://example.com/foo/'
-PASS canonicalize('http://example.com/foo/%2e%2') is 'http://example.com/foo/.%2'
-PASS canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') is 'http://example.com/..bar'
+FAIL canonicalize('http://example.com/foo/%2e') should be http://example.com/foo/. Was http://example.com/foo/%2e.
+FAIL canonicalize('http://example.com/foo/%2e%2') should be http://example.com/foo/.%2. Was http://example.com/foo/%2e%2.
+FAIL canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') should be http://example.com/..bar. Was http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar.
PASS canonicalize('http://example.com../..') is 'http://example.com//'
PASS canonicalize('http://example.com/foo/bar//../..') is 'http://example.com/foo/'
PASS canonicalize('http://example.com/foo/bar//..') is 'http://example.com/foo/bar/'
Modified: trunk/LayoutTests/fast/url/standard-url-expected.txt (207794 => 207795)
--- trunk/LayoutTests/fast/url/standard-url-expected.txt 2016-10-25 00:45:03 UTC (rev 207794)
+++ trunk/LayoutTests/fast/url/standard-url-expected.txt 2016-10-25 01:31:42 UTC (rev 207795)
@@ -9,7 +9,7 @@
PASS canonicalize('http://www.google.com') is 'http://www.google.com/'
PASS canonicalize('http:user:@google.com:99?foo') is 'http://u...@google.com:99/?foo'
PASS canonicalize('http://192.0x00A80001') is 'http://192.168.0.1/'
-PASS canonicalize('http://www/foo%2Ehtml') is 'http://www/foo.html'
+FAIL canonicalize('http://www/foo%2Ehtml') should be http://www/foo.html. Was http://www/foo%2Ehtml.
PASS canonicalize('http://user:pass@/') is 'http://user:pass@/'
PASS canonicalize('http://%25DOMAIN:foo...@foodomain.com/') is 'http://%25DOMAIN:foo...@foodomain.com/'
PASS canonicalize('http:www.google.com\\foo') is 'http://www.google.com/foo'
Modified: trunk/LayoutTests/fetch/fetch-url-serializa
[webkit-changes] [207794] trunk/Source
Title: [207794] trunk/Source
Revision 207794
Author pvol...@apple.com
Date 2016-10-24 17:45:03 -0700 (Mon, 24 Oct 2016)
Log Message
[Win] CMake build type is not set.
https://bugs.webkit.org/show_bug.cgi?id=163917
Reviewed by Alex Christensen.
The CMAKE_BUILD_TYPE variable should be set to Debug or Release.
Source/_javascript_Core:
* _javascript_Core.vcxproj/_javascript_Core.proj:
Source/WebCore:
* WebCore.vcxproj/WebCore.proj:
Source/WebKit:
* WebKit.vcxproj/WebKit.proj:
Source/WTF:
* WTF.vcxproj/WTF.proj:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.vcxproj/WTF.proj
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcxproj/WebCore.proj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (207793 => 207794)
--- trunk/Source/_javascript_Core/ChangeLog 2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-10-25 00:45:03 UTC (rev 207794)
@@ -1,3 +1,14 @@
+2016-10-24 Per Arne Vollan
+
+[Win] CMake build type is not set.
+https://bugs.webkit.org/show_bug.cgi?id=163917
+
+Reviewed by Alex Christensen.
+
+The CMAKE_BUILD_TYPE variable should be set to Debug or Release.
+
+* _javascript_Core.vcxproj/_javascript_Core.proj:
+
2016-10-24 Chris Dumez
Reduce special handling for typed arrays in JSDOMConvert.h
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj (207793 => 207794)
--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj 2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj 2016-10-25 00:45:03 UTC (rev 207794)
@@ -28,7 +28,7 @@
Program Files\Common Files\Apple\Apple Application Support
$(OBJROOT)\$(CONFIG)
$(DSTROOT)
- cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DJAVASCRIPTCORE_DIR=$(SRCROOT.Replace('\','/'))
+ cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DCMAKE_BUILD_TYPE=$(CONFIGURATION) -DJAVASCRIPTCORE_DIR=$(SRCROOT.Replace('\','/'))
Modified: trunk/Source/WTF/ChangeLog (207793 => 207794)
--- trunk/Source/WTF/ChangeLog 2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/WTF/ChangeLog 2016-10-25 00:45:03 UTC (rev 207794)
@@ -1,3 +1,14 @@
+2016-10-24 Per Arne Vollan
+
+[Win] CMake build type is not set.
+https://bugs.webkit.org/show_bug.cgi?id=163917
+
+Reviewed by Alex Christensen.
+
+The CMAKE_BUILD_TYPE variable should be set to Debug or Release.
+
+* WTF.vcxproj/WTF.proj:
+
2016-10-23 Yusuke Suzuki
[DOMJIT] Add a way for DOMJIT::Patchpoint to express effects
Modified: trunk/Source/WTF/WTF.vcxproj/WTF.proj (207793 => 207794)
--- trunk/Source/WTF/WTF.vcxproj/WTF.proj 2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.proj 2016-10-25 00:45:03 UTC (rev 207794)
@@ -28,7 +28,7 @@
Program Files\Common Files\Apple\Apple Application Support
$(OBJROOT)\$(CONFIG)
$(DSTROOT)
- cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DWTF_DIR=$(SRCROOT.Replace('\','/'))
+ cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DCMAKE_BUILD_TYPE=$(CONFIGURATION) -DWTF_DIR=$(SRCROOT.Replace('\','/'))
Modified: trunk/Source/WebCore/ChangeLog (207793 => 207794)
--- trunk/Source/WebCore/ChangeLog 2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/WebCore/ChangeLog 2016-10-25 00:45:03 UTC (rev 207794)
@@ -1,3 +1,14 @@
+2016-10-24 Per Arne Vollan
+
+[Win] CMake build type is not set.
+https://bugs.webkit.org/show_bug.cgi?id=163917
+
+Reviewed by Alex Christensen.
+
+The CMAKE_BUILD_TYPE variable should be set to Debug or Release.
+
+* WebCore.vcxproj/WebCore.proj:
+
2016-10-24 Yusuke Suzuki
Unreviewed, attempt to fix Windows build after r207787
Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.proj (207793 => 207794)
--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.p
[webkit-changes] [207793] trunk/Source/WebCore
Title: [207793] trunk/Source/WebCore
Revision 207793
Author utatane@gmail.com
Date 2016-10-24 17:31:05 -0700 (Mon, 24 Oct 2016)
Log Message
Unreviewed, attempt to fix Windows build after r207787
https://bugs.webkit.org/show_bug.cgi?id=163657
According to the similar code in WebKit, I guess that
Visual C++ requires friend class declaration is done
in the private section to access private members.
And I also changed ::instance to ::shared to align to
the existing WebCore code.
* domjit/DOMJITAbstractHeapRepository.cpp:
(WebCore::DOMJIT::AbstractHeapRepository::shared):
(WebCore::DOMJIT::AbstractHeapRepository::instance): Deleted.
* domjit/DOMJITAbstractHeapRepository.h:
* domjit/JSNodeDOMJIT.cpp:
(WebCore::NodeFirstChildDOMJIT::callDOM):
(WebCore::NodeLastChildDOMJIT::callDOM):
(WebCore::NodeNextSiblingDOMJIT::callDOM):
(WebCore::NodePreviousSiblingDOMJIT::callDOM):
(WebCore::NodeParentNodeDOMJIT::callDOM):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.cpp
trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.h
trunk/Source/WebCore/domjit/JSNodeDOMJIT.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (207792 => 207793)
--- trunk/Source/WebCore/ChangeLog 2016-10-25 00:22:08 UTC (rev 207792)
+++ trunk/Source/WebCore/ChangeLog 2016-10-25 00:31:05 UTC (rev 207793)
@@ -1,3 +1,26 @@
+2016-10-24 Yusuke Suzuki
+
+Unreviewed, attempt to fix Windows build after r207787
+https://bugs.webkit.org/show_bug.cgi?id=163657
+
+According to the similar code in WebKit, I guess that
+Visual C++ requires friend class declaration is done
+in the private section to access private members.
+
+And I also changed ::instance to ::shared to align to
+the existing WebCore code.
+
+* domjit/DOMJITAbstractHeapRepository.cpp:
+(WebCore::DOMJIT::AbstractHeapRepository::shared):
+(WebCore::DOMJIT::AbstractHeapRepository::instance): Deleted.
+* domjit/DOMJITAbstractHeapRepository.h:
+* domjit/JSNodeDOMJIT.cpp:
+(WebCore::NodeFirstChildDOMJIT::callDOM):
+(WebCore::NodeLastChildDOMJIT::callDOM):
+(WebCore::NodeNextSiblingDOMJIT::callDOM):
+(WebCore::NodePreviousSiblingDOMJIT::callDOM):
+(WebCore::NodeParentNodeDOMJIT::callDOM):
+
2016-10-24 Simon Fraser
Fix the lifetime of strings used in LOG_WITH_STREAM
Modified: trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.cpp (207792 => 207793)
--- trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.cpp 2016-10-25 00:22:08 UTC (rev 207792)
+++ trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.cpp 2016-10-25 00:31:05 UTC (rev 207793)
@@ -59,7 +59,7 @@
}
}
-const AbstractHeapRepository& AbstractHeapRepository::instance()
+const AbstractHeapRepository& AbstractHeapRepository::shared()
{
static NeverDestroyed repository;
return repository.get();
Modified: trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.h (207792 => 207793)
--- trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.h 2016-10-25 00:22:08 UTC (rev 207792)
+++ trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.h 2016-10-25 00:31:05 UTC (rev 207793)
@@ -47,8 +47,7 @@
class AbstractHeapRepository {
WTF_MAKE_NONCOPYABLE(AbstractHeapRepository);
public:
-friend class NeverDestroyed;
-static const AbstractHeapRepository& instance();
+static const AbstractHeapRepository& shared();
JSC::DOMJIT::HeapRange DOM;
@@ -57,6 +56,7 @@
#undef DOMJIT_DEFINE_MEMBER
private:
+friend class NeverDestroyed;
AbstractHeapRepository();
};
Modified: trunk/Source/WebCore/domjit/JSNodeDOMJIT.cpp (207792 => 207793)
--- trunk/Source/WebCore/domjit/JSNodeDOMJIT.cpp 2016-10-25 00:22:08 UTC (rev 207792)
+++ trunk/Source/WebCore/domjit/JSNodeDOMJIT.cpp 2016-10-25 00:31:05 UTC (rev 207793)
@@ -104,7 +104,7 @@
Ref NodeFirstChildDOMJIT::callDOM()
{
-const auto& heap = DOMJIT::AbstractHeapRepository::instance();
+const auto& heap = DOMJIT::AbstractHeapRepository::shared();
auto patchpoint = createCallDOMForOffsetAccess(CAST_OFFSET(Node*, ContainerNode*) + ContainerNode::firstChildMemoryOffset(), IsContainerGuardRequirement::Required);
patchpoint->effect = JSC::DOMJIT::Effect::forDef(heap.Node_firstChild);
return patchpoint;
@@ -118,7 +118,7 @@
Ref NodeLastChildDOMJIT::callDOM()
{
-const auto& heap = DOMJIT::AbstractHeapRepository::instance();
+const auto& heap = DOMJIT::AbstractHeapRepository::shared();
auto patchpoint = createCallDOMForOffsetAccess(CAST_OFFSET(Node*, ContainerNode*) + ContainerNode::lastChildMemoryOffset(), IsContainerGuardRequirement::Required);
patchpoint->effect = JSC::DOMJIT::Effect::forDef(heap.Node_lastChild);
return patchpoint;
@@ -132,7 +132,7 @@
Ref NodeNextSiblingDOMJIT::callDOM()
{
-const auto& heap = DOMJIT::AbstractHeapRepository::instance();
+const a
[webkit-changes] [207792] trunk/Source/WebCore
Title: [207792] trunk/Source/WebCore
Revision 207792
Author simon.fra...@apple.com
Date 2016-10-24 17:22:08 -0700 (Mon, 24 Oct 2016)
Log Message
Fix the lifetime of strings used in LOG_WITH_STREAM
https://bugs.webkit.org/show_bug.cgi?id=163923
Reviewed by Brent Fulgham.
Make sure the const char* passed to WTFLog() outlives the call.
Removed logFunctionResult which wasn't used anywhere else, and encourages this bad
pattern.
* platform/LogMacros.h:
* platform/Logging.cpp:
(WebCore::logFunctionResult): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/LogMacros.h
trunk/Source/WebCore/platform/Logging.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (207791 => 207792)
--- trunk/Source/WebCore/ChangeLog 2016-10-25 00:16:29 UTC (rev 207791)
+++ trunk/Source/WebCore/ChangeLog 2016-10-25 00:22:08 UTC (rev 207792)
@@ -1,3 +1,19 @@
+2016-10-24 Simon Fraser
+
+Fix the lifetime of strings used in LOG_WITH_STREAM
+https://bugs.webkit.org/show_bug.cgi?id=163923
+
+Reviewed by Brent Fulgham.
+
+Make sure the const char* passed to WTFLog() outlives the call.
+
+Removed logFunctionResult which wasn't used anywhere else, and encourages this bad
+pattern.
+
+* platform/LogMacros.h:
+* platform/Logging.cpp:
+(WebCore::logFunctionResult): Deleted.
+
2016-10-24 Chris Dumez
Reduce special handling for typed arrays in JSDOMConvert.h
Modified: trunk/Source/WebCore/platform/LogMacros.h (207791 => 207792)
--- trunk/Source/WebCore/platform/LogMacros.h 2016-10-25 00:16:29 UTC (rev 207791)
+++ trunk/Source/WebCore/platform/LogMacros.h 2016-10-25 00:22:08 UTC (rev 207792)
@@ -29,22 +29,14 @@
#if LOG_DISABLED
-#define LOG_RESULT(channel, function) ((void)0)
#define LOG_WITH_STREAM(channel, commands) ((void)0)
#else
-namespace WebCore {
-WEBCORE_EXPORT void logFunctionResult(WTFLogChannel*, std::function);
-}
-
-#define LOG_RESULT(channel, function) WebCore::logFunctionResult(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), function)
-
-#define LOG_WITH_STREAM(channel, commands) WebCore::logFunctionResult(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), \
-[&]() { \
+#define LOG_WITH_STREAM(channel, commands) do { \
WebCore::TextStream stream(WebCore::TextStream::LineMode::SingleLine); \
commands; \
-return stream.release().utf8().data(); \
-});
+WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), "%s", stream.release().utf8().data()); \
+} while (0);
#endif // !LOG_DISABLED
Modified: trunk/Source/WebCore/platform/Logging.cpp (207791 => 207792)
--- trunk/Source/WebCore/platform/Logging.cpp 2016-10-25 00:16:29 UTC (rev 207791)
+++ trunk/Source/WebCore/platform/Logging.cpp 2016-10-25 00:22:08 UTC (rev 207792)
@@ -95,12 +95,4 @@
#endif // !LOG_DISABLED || !RELEASE_LOG_DISABLED
-#if !LOG_DISABLED
-void logFunctionResult(WTFLogChannel* channel, std::function function)
-{
-WTFLog(channel, "%s", function());
-}
-
-#endif // !LOG_DISABLED
-
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207791] trunk/Source
Title: [207791] trunk/Source
Revision 207791
Author cdu...@apple.com
Date 2016-10-24 17:16:29 -0700 (Mon, 24 Oct 2016)
Log Message
Reduce special handling for typed arrays in JSDOMConvert.h
https://bugs.webkit.org/show_bug.cgi?id=163907
Reviewed by Sam Weinig.
Reduce special handling for typed arrays in JSDOMConvert.h by adding a toWrapped() static
function on JSGenericTypedArrayView, similarly to other wrapper types.
Source/_javascript_Core:
* runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::typedImpl):
(JSC::JSGenericTypedArrayView::toWrapped):
Source/WebCore:
No new tests, no web-exposed behavior change.
* bindings/js/JSDOMConvert.h:
(WebCore::Converter>>::convert): Deleted.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayView.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMConvert.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (207790 => 207791)
--- trunk/Source/_javascript_Core/ChangeLog 2016-10-25 00:11:38 UTC (rev 207790)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-10-25 00:16:29 UTC (rev 207791)
@@ -1,3 +1,17 @@
+2016-10-24 Chris Dumez
+
+Reduce special handling for typed arrays in JSDOMConvert.h
+https://bugs.webkit.org/show_bug.cgi?id=163907
+
+Reviewed by Sam Weinig.
+
+Reduce special handling for typed arrays in JSDOMConvert.h by adding a toWrapped() static
+function on JSGenericTypedArrayView, similarly to other wrapper types.
+
+* runtime/JSGenericTypedArrayView.h:
+(JSC::JSGenericTypedArrayView::typedImpl):
+(JSC::JSGenericTypedArrayView::toWrapped):
+
2016-10-24 Yusuke Suzuki
[DOMJIT][DFG] CallDOM never writes Stack
Modified: trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayView.h (207790 => 207791)
--- trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayView.h 2016-10-25 00:11:38 UTC (rev 207790)
+++ trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayView.h 2016-10-25 00:16:29 UTC (rev 207791)
@@ -225,10 +225,12 @@
// then it will have thrown an exception.
bool set(ExecState*, unsigned offset, JSObject*, unsigned objectOffset, unsigned length, CopyType type = CopyType::Unobservable);
-PassRefPtr typedImpl()
+RefPtr typedImpl()
{
return Adaptor::ViewType::create(buffer(), byteOffset(), length());
}
+
+static RefPtr toWrapped(JSValue);
static Structure* createStructure(VM& vm, JSGlobalObject* globalObject, JSValue prototype)
{
@@ -367,4 +369,10 @@
return wrapper->typedImpl();
}
+template
+RefPtr JSGenericTypedArrayView::toWrapped(JSValue value)
+{
+return JSC::toNativeTypedView(value);
+}
+
} // namespace JSC
Modified: trunk/Source/WebCore/ChangeLog (207790 => 207791)
--- trunk/Source/WebCore/ChangeLog 2016-10-25 00:11:38 UTC (rev 207790)
+++ trunk/Source/WebCore/ChangeLog 2016-10-25 00:16:29 UTC (rev 207791)
@@ -1,3 +1,18 @@
+2016-10-24 Chris Dumez
+
+Reduce special handling for typed arrays in JSDOMConvert.h
+https://bugs.webkit.org/show_bug.cgi?id=163907
+
+Reviewed by Sam Weinig.
+
+Reduce special handling for typed arrays in JSDOMConvert.h by adding a toWrapped() static
+function on JSGenericTypedArrayView, similarly to other wrapper types.
+
+No new tests, no web-exposed behavior change.
+
+* bindings/js/JSDOMConvert.h:
+(WebCore::Converter>>::convert): Deleted.
+
2016-10-24 Ryan Haddad
Unreviewed, rolling out r207783.
Modified: trunk/Source/WebCore/bindings/js/JSDOMConvert.h (207790 => 207791)
--- trunk/Source/WebCore/bindings/js/JSDOMConvert.h 2016-10-25 00:11:38 UTC (rev 207790)
+++ trunk/Source/WebCore/bindings/js/JSDOMConvert.h 2016-10-25 00:16:29 UTC (rev 207791)
@@ -235,6 +235,12 @@
using ToWrappedReturnType = RefPtr;
};
+// Typed arrays support.
+template struct JSDOMWrapperConverterTraits> {
+using WrapperClass = JSC::JSGenericTypedArrayView;
+using ToWrappedReturnType = RefPtr>;
+};
+
// MARK: -
// MARK: Interface type
@@ -264,27 +270,6 @@
}
};
-// Typed arrays support.
-
-template struct IDLInterface> : IDLType>> {
-using RawType = JSC::GenericTypedArrayView;
-using NullableType = RefPtr>;
-};
-
-template struct Converter>> : DefaultConverter>> {
-using ReturnType = RefPtr>;
-
-static ReturnType convert(JSC::ExecState& state, JSC::JSValue value)
-{
-JSC::VM& vm = state.vm();
-auto scope = DECLARE_THROW_SCOPE(vm);
-ReturnType object = JSC::toNativeTypedView(value);
-if (!object)
-throwTypeError(&state, scope);
-return object;
-}
-};
-
// MARK: -
// MARK: Any type
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207790] trunk/Source/WebCore
Title: [207790] trunk/Source/WebCore
Revision 207790
Author ryanhad...@apple.com
Date 2016-10-24 17:11:38 -0700 (Mon, 24 Oct 2016)
Log Message
Unreviewed, rolling out r207783.
This change appears to have caused fast/selectors/invalid-
functional-pseudo-class.html to crash on iOS and macOS
Reverted changeset:
"[CSS Parser] Fix :lang argument parsing"
https://bugs.webkit.org/show_bug.cgi?id=163913
http://trac.webkit.org/changeset/207783
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in
trunk/Source/WebCore/css/parser/CSSParserValues.cpp
trunk/Source/WebCore/css/parser/CSSParserValues.h
trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (207789 => 207790)
--- trunk/Source/WebCore/ChangeLog 2016-10-25 00:07:15 UTC (rev 207789)
+++ trunk/Source/WebCore/ChangeLog 2016-10-25 00:11:38 UTC (rev 207790)
@@ -1,3 +1,16 @@
+2016-10-24 Ryan Haddad
+
+Unreviewed, rolling out r207783.
+
+This change appears to have caused fast/selectors/invalid-
+functional-pseudo-class.html to crash on iOS and macOS
+
+Reverted changeset:
+
+"[CSS Parser] Fix :lang argument parsing"
+https://bugs.webkit.org/show_bug.cgi?id=163913
+http://trac.webkit.org/changeset/207783
+
2016-10-24 Brady Eidson
IndexedDB 2.0: Support new IDBKeyRange interfaces.
Modified: trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in (207789 => 207790)
--- trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in 2016-10-25 00:07:15 UTC (rev 207789)
+++ trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in 2016-10-25 00:11:38 UTC (rev 207790)
@@ -1,5 +1,4 @@
-khtml-drag
--webkit-any
-webkit-any(
-webkit-any-link, PseudoClassAnyLinkDeprecated, PseudoElementUnknown
-webkit-autofill
@@ -14,7 +13,6 @@
decrement
default
#if ENABLE(CSS_SELECTORS_LEVEL4)
-dir
dir(
#endif
disabled
@@ -35,23 +33,16 @@
increment
indeterminate
invalid
-lang
lang(
last-child
last-of-type
link
-matches
matches(
no-button
-not
not(
-nth-child
nth-child(
-nth-last-child
nth-last-child(
-nth-last-of-type
nth-last-of-type(
-nth-of-type
nth-of-type(
only-child
only-of-type
@@ -62,7 +53,6 @@
read-write
required
#if ENABLE(CSS_SELECTORS_LEVEL4)
-role
role(
#endif
root
Modified: trunk/Source/WebCore/css/parser/CSSParserValues.cpp (207789 => 207790)
--- trunk/Source/WebCore/css/parser/CSSParserValues.cpp 2016-10-25 00:07:15 UTC (rev 207789)
+++ trunk/Source/WebCore/css/parser/CSSParserValues.cpp 2016-10-25 00:11:38 UTC (rev 207790)
@@ -410,13 +410,7 @@
argumentList->append(languageArgument);
m_selector->setLangArgumentList(WTFMove(argumentList));
}
-
-void CSSParserSelector::setLangArgumentList(std::unique_ptr> argumentList)
-{
-ASSERT_WITH_MESSAGE(!argumentList->isEmpty(), "No CSS Selector takes an empty argument list.");
-m_selector->setLangArgumentList(WTFMove(argumentList));
-}
-
+
void CSSParserSelector::setSelectorList(std::unique_ptr selectorList)
{
m_selector->setSelectorList(WTFMove(selectorList));
Modified: trunk/Source/WebCore/css/parser/CSSParserValues.h (207789 => 207790)
--- trunk/Source/WebCore/css/parser/CSSParserValues.h 2016-10-25 00:07:15 UTC (rev 207789)
+++ trunk/Source/WebCore/css/parser/CSSParserValues.h 2016-10-25 00:11:38 UTC (rev 207790)
@@ -235,7 +235,6 @@
void adoptSelectorVector(Vector>& selectorVector);
void setLangArgumentList(const Vector& stringVector);
-void setLangArgumentList(std::unique_ptr>);
void setSelectorList(std::unique_ptr);
void setPseudoClassValue(const CSSParserString& pseudoClassString);
Modified: trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp (207789 => 207790)
--- trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp 2016-10-25 00:07:15 UTC (rev 207789)
+++ trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp 2016-10-25 00:11:38 UTC (rev 207790)
@@ -100,23 +100,6 @@
return list;
}
-static void consumeLangArgumentList(std::unique_ptr>& argumentList, CSSParserTokenRange& range)
-{
-const CSSParserToken& ident = range.consumeIncludingWhitespace();
-if (ident.type() != IdentToken)
-return;
-argumentList->append(ident.value().toAtomicString());
-while (!range.atEnd() && range.peek().type() == CommaToken) {
-range.consumeIncludingWhitespace();
-const CSSParserToken& ident = range.consumeIncludingWhitespace();
-if (ident.type() != IdentToken) {
-argumentList->clear();
-return;
-}
-argumentList->append(ident.value().toAtomicString());
-}
-}
-
namespace {
enum CompoundSelectorFlags {
@@ -486,84 +469,79 @@
if (token.type() != FunctionToken)
return nullptr;
-if (selector->match() == CSSSelector::PseudoClass) {
-switch (selector->pseudoClassType()) {
-
[webkit-changes] [207789] trunk/Source/JavaScriptCore
Title: [207789] trunk/Source/_javascript_Core
Revision 207789
Author utatane@gmail.com
Date 2016-10-24 17:07:15 -0700 (Mon, 24 Oct 2016)
Log Message
[DOMJIT][DFG] CallDOM never writes Stack
https://bugs.webkit.org/show_bug.cgi?id=163926
Reviewed by Filip Pizlo and Saam Barati.
There is no way to write(Stack) in CallDOM.
This worst case (the most clobbering case) scenario
should be aligned to the one of Call, read(World) and write(Heap).
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (207788 => 207789)
--- trunk/Source/_javascript_Core/ChangeLog 2016-10-25 00:05:24 UTC (rev 207788)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-10-25 00:07:15 UTC (rev 207789)
@@ -1,3 +1,17 @@
+2016-10-24 Yusuke Suzuki
+
+[DOMJIT][DFG] CallDOM never writes Stack
+https://bugs.webkit.org/show_bug.cgi?id=163926
+
+Reviewed by Filip Pizlo and Saam Barati.
+
+There is no way to write(Stack) in CallDOM.
+This worst case (the most clobbering case) scenario
+should be aligned to the one of Call, read(World) and write(Heap).
+
+* dfg/DFGClobberize.h:
+(JSC::DFG::clobberize):
+
2016-10-23 Yusuke Suzuki
[DOMJIT] Add a way for DOMJIT::Patchpoint to express effects
Modified: trunk/Source/_javascript_Core/dfg/DFGClobberize.h (207788 => 207789)
--- trunk/Source/_javascript_Core/dfg/DFGClobberize.h 2016-10-25 00:05:24 UTC (rev 207788)
+++ trunk/Source/_javascript_Core/dfg/DFGClobberize.h 2016-10-25 00:07:15 UTC (rev 207789)
@@ -919,7 +919,7 @@
}
if (effect.writes) {
if (effect.writes == DOMJIT::HeapRange::top())
-write(World);
+write(Heap);
else
write(AbstractHeap(DOMState, effect.writes.rawRepresentation()));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207788] trunk
Title: [207788] trunk
Revision 207788
Author beid...@apple.com
Date 2016-10-24 17:05:24 -0700 (Mon, 24 Oct 2016)
Log Message
IndexedDB 2.0: Support new IDBKeyRange interfaces.
and https://bugs.webkit.org/show_bug.cgi?id=163910
Reviewed by Andy Estes.
Source/WebCore:
No new tests (Covered by additions to existing test)
The "new IDBKeyRanges interfaces" really just means adding the instance method IDBKeyRange.contains.
* Modules/indexeddb/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::contains):
* Modules/indexeddb/IDBKeyRange.h:
* Modules/indexeddb/IDBKeyRange.idl:
LayoutTests:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/keyrange-private-expected.txt:
* storage/indexeddb/resources/keyrange.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt
trunk/LayoutTests/storage/indexeddb/keyrange-private-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/keyrange.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.h
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (207787 => 207788)
--- trunk/LayoutTests/ChangeLog 2016-10-24 23:34:32 UTC (rev 207787)
+++ trunk/LayoutTests/ChangeLog 2016-10-25 00:05:24 UTC (rev 207788)
@@ -1,3 +1,14 @@
+2016-10-24 Brady Eidson
+
+IndexedDB 2.0: Support new IDBKeyRange interfaces.
+ and https://bugs.webkit.org/show_bug.cgi?id=163910
+
+Reviewed by Andy Estes.
+
+* storage/indexeddb/keyrange-expected.txt:
+* storage/indexeddb/keyrange-private-expected.txt:
+* storage/indexeddb/resources/keyrange.js:
+
2016-10-23 Yusuke Suzuki
[DOMJIT] Add a way for DOMJIT::Patchpoint to express effects
Modified: trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt (207787 => 207788)
--- trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt 2016-10-24 23:34:32 UTC (rev 207787)
+++ trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt 2016-10-25 00:05:24 UTC (rev 207788)
@@ -9,6 +9,7 @@
PASS 'upper' in IDBKeyRange is false
PASS 'lowerOpen' in IDBKeyRange is false
PASS 'upperOpen' in IDBKeyRange is false
+PASS 'contains' in IDBKeyRange is false
PASS 'only' in IDBKeyRange is true
PASS 'lowerBound' in IDBKeyRange is true
PASS 'upperBound' in IDBKeyRange is true
@@ -19,6 +20,7 @@
PASS 'upper' in instance is true
PASS 'lowerOpen' in instance is true
PASS 'upperOpen' in instance is true
+PASS 'contains' in instance is true
PASS 'only' in instance is false
PASS 'lowerBound' in instance is false
PASS 'upperBound' in instance is false
@@ -29,186 +31,281 @@
PASS keyRange.upper is 1
PASS keyRange.lowerOpen is false
PASS keyRange.upperOpen is false
+PASS keyRange.contains(1.1) is false
+PASS keyRange.contains(0.9) is false
+PASS keyRange.contains(1) is true
IDBKeyRange.only(3.14)
PASS keyRange.lower is 3.14
PASS keyRange.upper is 3.14
PASS keyRange.lowerOpen is false
PASS keyRange.upperOpen is false
+PASS keyRange.contains(3.24) is false
+PASS keyRange.contains(3.04) is false
+PASS keyRange.contains(3.14) is true
IDBKeyRange.only('a')
PASS keyRange.lower is 'a'
PASS keyRange.upper is 'a'
PASS keyRange.lowerOpen is false
PASS keyRange.upperOpen is false
+PASS keyRange.contains('aa') is false
+PASS keyRange.contains('') is false
+PASS keyRange.contains('a') is true
IDBKeyRange.lowerBound(10,true)
PASS keyRange.lower is 10
PASS keyRange.lowerOpen is true
PASS keyRange.upper is undefined.
PASS keyRange.upperOpen is true
+PASS keyRange.contains(10) is false
+PASS keyRange.contains(10.1) is true
+PASS keyRange.contains(9.9) is false
IDBKeyRange.lowerBound(11,false)
PASS keyRange.lower is 11
PASS keyRange.lowerOpen is false
PASS keyRange.upper is undefined.
PASS keyRange.upperOpen is true
+PASS keyRange.contains(11) is true
+PASS keyRange.contains(11.1) is true
+PASS keyRange.contains(10.9) is false
IDBKeyRange.lowerBound(12,undefined)
PASS keyRange.lower is 12
PASS keyRange.lowerOpen is false
PASS keyRange.upper is undefined.
PASS keyRange.upperOpen is true
+PASS keyRange.contains(12) is true
+PASS keyRange.contains(12.1) is true
+PASS keyRange.contains(11.9) is false
IDBKeyRange.lowerBound(10.1,true)
PASS keyRange.lower is 10.1
PASS keyRange.lowerOpen is true
PASS keyRange.upper is undefined.
PASS keyRange.upperOpen is true
+PASS keyRange.contains(10.1) is false
+PASS keyRange.contains(10.2) is true
+PASS keyRange.contains(10) is false
IDBKeyRange.lowerBound(11.2,false)
PASS keyRange.lower is 11.2
PASS keyRange.lowerOpen is false
PASS keyRange.upper is undefined.
PASS keyRange.upperOpen is true
+PASS keyRange.contains(11.2) is true
+PASS keyRange.contains(11.299) is true
+PASS keyRange.contains(11.1) is false
IDBKeyRange.lowerBound(12.3,undefined)
PASS keyRange.lower is 12.3
PASS keyRange.lowerOpen is false
PASS keyRange.upper is undefined.
PASS
[webkit-changes] [207787] trunk
Title: [207787] trunk Revision 207787 Author utatane@gmail.com Date 2016-10-24 16:34:32 -0700 (Mon, 24 Oct 2016) Log Message [DOMJIT] Add a way for DOMJIT::Patchpoint to express effects https://bugs.webkit.org/show_bug.cgi?id=163657 Reviewed by Saam Barati. Source/_javascript_Core: This patch introduces DOMJIT::Effect. It describes the side effects of the DOMJIT::CallDOMPatchpoint. DOMJIT::CallDOMPatchpoint can use this feature to teach the compilers about the effects. And the compilers will perform CSE based on the reported effects. As the same to B3's HeapRange, the effects are represented as a pair of integers. [begin, end) pair will represents the range of the abstract heap. We encode the abstract heap hierarchy into these pairs. Like, Root: [0, 32) Child1: [0, 20) Child2: [20, 32) Child11: [0, 4) Child12: [4, 20) This simplifies the representation of the abstract heap. And WebCore just tells pairs of integers and it does not tell any detailed hierarchy. So, DFG and FTL can optimize DOM operations without deep knowledge of the DOM abstract heap hierarchy. For example, WebCore will tell that firstChild will read Node_firstChild abstract heap. But this information is encoded to the pair and DFG does not know the details. But still DFG can understand the abstract heap hierarchy and can query whether the given abstract heap overlaps with some abstract heap. The heap range told by the WebCore is represented as DOMJIT::HeapRange. DFG will handle this under the DOMState abstract heap. DOMJIT::HeapRange is stored in DFG::AbstractHeap's Payload. We maintain the hierarchy by DOMJIT::HeapRange in the DOMState abstract heap. We add a necessary handling in DFG's AbstractHeap and ClobberSet. And we also introduce DOMStateLoc for HeapLocation. It is combined with DOMState AbstractHeap with DOMJIT::HeapRange. For example, we can represent Node.firstChild as `read(DOMState:Node_firstChild)` and `def(HeapLocation(node, DOMState:Node_firstChild))` thingy. This allows us to perform CSE onto DOM getters that will read some of DOM heap! For simplicity, we convert CallDOM from NodeVarArgs to the normal one. CallDOM is now just used for DOMJIT getter. So its children is at most 2. It may have either 1 or 2 children. If the global object is required by CallDOMPatchpoint, it has 2 children. And we changed the order of the children to further simplify the code. Before this change, the order is 1: globalObject 2: base. After this patch, the order becomes 1: base, and 2: globalObject. And the child2 may not exists if the global object is not required. We changed all the existing DOMJIT patchpoint to this form. * CMakeLists.txt: * _javascript_Core.xcodeproj/project.pbxproj: * bytecode/PolymorphicAccess.cpp: (JSC::AccessCase::emitDOMJITGetter): * dfg/DFGAbstractHeap.cpp: (JSC::DFG::AbstractHeap::dump): * dfg/DFGAbstractHeap.h: (JSC::DFG::AbstractHeap::isStrictSubtypeOf): (JSC::DFG::AbstractHeap::overlaps): * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter::executeEffects): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::blessCallDOM): (JSC::DFG::ByteCodeParser::handleDOMJITGetter): * dfg/DFGClobberSet.cpp: (JSC::DFG::ClobberSet::overlaps): * dfg/DFGClobberSet.h: * dfg/DFGClobberize.h: (JSC::DFG::clobberize): * dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): * dfg/DFGGraph.h: * dfg/DFGHeapLocation.cpp: (WTF::printInternal): * dfg/DFGHeapLocation.h: * dfg/DFGNode.h: (JSC::DFG::Node::hasCallDOMData): (JSC::DFG::Node::callDOMData): (JSC::DFG::Node::hasCallDOMPatchpoint): Deleted. (JSC::DFG::Node::callDOMPatchpoint): Deleted. * dfg/DFGNodeType.h: * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileCallDOM): * domjit/DOMJITAbstractHeap.cpp: Copied from Source/_javascript_Core/domjit/DOMJITCallDOMPatchpoint.h. (JSC::DOMJIT::AbstractHeap::compute): (JSC::DOMJIT::AbstractHeap::dump): (JSC::DOMJIT::AbstractHeap::shallowDump): (JSC::DOMJIT::AbstractHeap::deepDump): * domjit/DOMJITAbstractHeap.h: Copied from Source/_javascript_Core/domjit/DOMJITCallDOMPatchpoint.h. (JSC::DOMJIT::AbstractHeap::AbstractHeap): (JSC::DOMJIT::AbstractHeap::setParent): (JSC::DOMJIT::AbstractHeap::isRoot): (JSC::DOMJIT::AbstractHeap::isComputed): (JSC::DOMJIT::AbstractHeap::range): * domjit/DOMJITCallDOMPatchpoint.h: * domjit/DOMJITEffect.h: Copied from Source/_javascript_Core/domjit/DOMJITCallDOMPatchpoint.h. (JSC::DOMJIT::Effect::forReadWrite): (JSC::DOMJIT::Effect::forPure): (JSC::DOMJIT::Effect::forDef): (JSC::DOMJIT::Effect::mustGenerate): * domjit/DOMJITHeapRange.cpp: Copied from Source/_javascript_Core/domjit/DOMJITCallDOMPatchpoint.h. (JSC::DOMJIT::HeapRange::dump): * domjit/DOMJITHeapRange.h: Added. (JSC::DOMJIT::HeapRange::HeapRange): (JSC::DOMJIT::HeapRange::fromRaw): (JSC::DOMJIT::HeapRange::begin): (JSC::DOMJIT::HeapRange::end): (JSC::DOMJIT::HeapRange::rawRepresentation): (JSC::DOMJIT::HeapRange::operator bool): (
[webkit-changes] [207786] trunk/LayoutTests
Title: [207786] trunk/LayoutTests Revision 207786 Author mmaxfi...@apple.com Date 2016-10-24 16:12:15 -0700 (Mon, 24 Oct 2016) Log Message Font variations test gardening Unreviewed. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (207785 => 207786) --- trunk/LayoutTests/ChangeLog 2016-10-24 22:51:59 UTC (rev 207785) +++ trunk/LayoutTests/ChangeLog 2016-10-24 23:12:15 UTC (rev 207786) @@ -1,3 +1,11 @@ +2016-10-24 Myles C. Maxfield + +Font variations test gardening + +Unreviewed. + +* platform/mac/TestExpectations: + 2016-10-24 Devin Rousso Web Inspector: Scope chain shouldn't show empty Closure sections Modified: trunk/LayoutTests/platform/mac/TestExpectations (207785 => 207786) --- trunk/LayoutTests/platform/mac/TestExpectations 2016-10-24 22:51:59 UTC (rev 207785) +++ trunk/LayoutTests/platform/mac/TestExpectations 2016-10-24 23:12:15 UTC (rev 207786) @@ -1469,7 +1469,7 @@ # rdar://problem/28586837 fast/text/variations/order.html [ Crash ] -animations/font-variations/font-variation-settings-order.html [ Crash ] +animations/font-variations/font-variation-settings-order.html [ Pass Failure ImageOnlyFailure Crash ] # Variation fonts are not implemented earlier than Sierra. [ ElCapitan Yosemite ] fast/text/variations [ Pass Failure ImageOnlyFailure ] [ ElCapitan Yosemite ] animations/font-variations [ Pass Failure ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207785] trunk/Source/JavaScriptCore
Title: [207785] trunk/Source/_javascript_Core
Revision 207785
Author achristen...@apple.com
Date 2016-10-24 15:51:59 -0700 (Mon, 24 Oct 2016)
Log Message
JSONParse should not crash with null Strings
https://bugs.webkit.org/show_bug.cgi?id=163918
Reviewed by Michael Saboff.
When JSONParse is called with a null String, it calls String::is8bit, which dereferences a null pointer.
This is happening with new work in the Fetch API, but callers of JSONParse should not have to check
if the String is null.
* API/tests/JSONParseTest.cpp: Added.
(testJSONParse):
* API/tests/JSONParseTest.h: Added.
* API/tests/testapi.c:
(main):
Test parsing null Strings. They should have the same result as parsing empty Strings.
* _javascript_Core.xcodeproj/project.pbxproj:
* runtime/JSONObject.cpp:
(JSC::JSONParse):
Check for null Strings.
* shell/PlatformWin.cmake:
Modified Paths
trunk/Source/_javascript_Core/API/tests/testapi.c
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/runtime/JSONObject.cpp
trunk/Source/_javascript_Core/shell/PlatformWin.cmake
Added Paths
trunk/Source/_javascript_Core/API/tests/JSONParseTest.cpp
trunk/Source/_javascript_Core/API/tests/JSONParseTest.h
Diff
Added: trunk/Source/_javascript_Core/API/tests/JSONParseTest.cpp (0 => 207785)
--- trunk/Source/_javascript_Core/API/tests/JSONParseTest.cpp (rev 0)
+++ trunk/Source/_javascript_Core/API/tests/JSONParseTest.cpp 2016-10-24 22:51:59 UTC (rev 207785)
@@ -0,0 +1,69 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "JSONParseTest.h"
+
+#include "JSCInlines.h"
+#include "JSGlobalObject.h"
+#include "JSONObject.h"
+#include "VM.h"
+#include
+
+using namespace JSC;
+
+int testJSONParse()
+{
+bool failed = false;
+
+RefPtr vm = VM::create();
+
+JSLockHolder locker(vm.get());
+JSGlobalObject* globalObject = JSGlobalObject::create(*vm, JSGlobalObject::createStructure(*vm, jsNull()));
+
+ExecState* exec = globalObject->globalExec();
+JSValue v0 = JSONParse(exec, "");
+JSValue v1 = JSONParse(exec, "#$%^");
+JSValue v2 = JSONParse(exec, String());
+UChar emptyUCharArray[1] = { '\0' };
+JSValue v3 = JSONParse(exec, String(emptyUCharArray, 0));
+JSValue v4;
+JSValue v5 = JSONParse(exec, "123");
+
+failed = failed || (v0 != v1);
+failed = failed || (v1 != v2);
+failed = failed || (v2 != v3);
+failed = failed || (v3 != v4);
+failed = failed || (v4 == v5);
+
+vm = nullptr;
+
+if (failed)
+printf("FAIL: JSONParse String test.\n");
+else
+printf("PASS: JSONParse String test.\n");
+
+return failed;
+}
Added: trunk/Source/_javascript_Core/API/tests/JSONParseTest.h (0 => 207785)
--- trunk/Source/_javascript_Core/API/tests/JSONParseTest.h (rev 0)
+++ trunk/Source/_javascript_Core/API/tests/JSONParseTest.h 2016-10-24 22:51:59 UTC (rev 207785)
@@ -0,0 +1,36 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC.
[webkit-changes] [207784] trunk
Title: [207784] trunk
Revision 207784
Author commit-qu...@webkit.org
Date 2016-10-24 15:09:29 -0700 (Mon, 24 Oct 2016)
Log Message
Web Inspector: Scope chain shouldn't show empty Closure sections
https://bugs.webkit.org/show_bug.cgi?id=152348
Patch by Devin Rousso on 2016-10-24
Reviewed by Joseph Pecoraro.
Source/_javascript_Core:
* inspector/InjectedScriptSource.js:
(isEmptyObject):
(InjectedScript.CallFrameProxy._createScopeJson):
If the scope object has no properties, set empty to true.
* inspector/protocol/Debugger.json:
Added empty property to Scope type.
Source/WebInspectorUI:
* UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
* UserInterface/Models/ScopeChainNode.js:
(WebInspector.ScopeChainNode):
(WebInspector.ScopeChainNode.prototype.get empty):
Added support for new empty property.
* UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
Only create and display a DetailsSection if the scope is not empty (via empty).
LayoutTests:
* inspector/model/scope-chain-node-expected.txt:
* inspector/model/scope-chain-node.html:
Added "empty" indicators to scopes without any property descriptors.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/model/scope-chain-node-expected.txt
trunk/LayoutTests/inspector/model/scope-chain-node.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js
trunk/Source/_javascript_Core/inspector/protocol/Debugger.json
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js
trunk/Source/WebInspectorUI/UserInterface/Models/ScopeChainNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (207783 => 207784)
--- trunk/LayoutTests/ChangeLog 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/LayoutTests/ChangeLog 2016-10-24 22:09:29 UTC (rev 207784)
@@ -1,5 +1,16 @@
2016-10-24 Devin Rousso
+Web Inspector: Scope chain shouldn't show empty Closure sections
+https://bugs.webkit.org/show_bug.cgi?id=152348
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/model/scope-chain-node-expected.txt:
+* inspector/model/scope-chain-node.html:
+Added "empty" indicators to scopes without any property descriptors.
+
+2016-10-24 Devin Rousso
+
Web Inspector: Improve Quick Open sorting algorithm
https://bugs.webkit.org/show_bug.cgi?id=163705
Modified: trunk/LayoutTests/inspector/model/scope-chain-node-expected.txt (207783 => 207784)
--- trunk/LayoutTests/inspector/model/scope-chain-node-expected.txt 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/LayoutTests/inspector/model/scope-chain-node-expected.txt 2016-10-24 22:09:29 UTC (rev 207784)
@@ -55,9 +55,11 @@
-- Running test case: WebInspector.ScopeChainNode.FunctionNameInFunctionExpression
SCOPE CHAIN:
Closure
+ (empty)
FunctionName
- functionName: function functionName() {
Closure
+ (empty)
GlobalLexicalEnvironment
- lexicalGlobalVariable: 2
Global
@@ -65,9 +67,11 @@
-- Running test case: WebInspector.ScopeChainNode.FunctionNameInClassMethod
SCOPE CHAIN:
Closure
+ (empty)
Block
- MyClass: class MyClass
Closure
+ (empty)
GlobalLexicalEnvironment
- lexicalGlobalVariable: 2
Global
@@ -101,6 +105,7 @@
Closure
- a: 1
Closure
+ (empty)
GlobalLexicalEnvironment
- lexicalGlobalVariable: 2
Global
@@ -107,11 +112,13 @@
PASS: Pause #17 - Contains a Block scope.
SCOPE CHAIN:
Closure
+ (empty)
Block
- MyClass: class MyClass
Closure
- a: 1
Closure
+ (empty)
GlobalLexicalEnvironment
- lexicalGlobalVariable: 2
Global
@@ -118,11 +125,13 @@
PASS: Pause #18 - Contains a Block scope.
SCOPE CHAIN:
Closure
+ (empty)
Block
- MyClassWithStaticMethod: class MyClassWithStaticMethod
Closure
- a: 1
Closure
+ (empty)
GlobalLexicalEnvironment
- lexicalGlobalVariable: 2
Global
Modified: trunk/LayoutTests/inspector/model/scope-chain-node.html (207783 => 207784)
--- trunk/LayoutTests/inspector/model/scope-chain-node.html 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/LayoutTests/inspector/model/scope-chain-node.html 2016-10-24 22:09:29 UTC (rev 207784)
@@ -45,10 +45,17 @@
InspectorTest.log("SCOPE CHAIN:");
for (let {scope, propertyDescriptors} of results) {
InspectorTest.log(`${scopeTypeToString(scope.type)}`);
-if (scope.type !== WebInspector.ScopeChainNode.Type.Global) {
-for (let descriptor of propertyDescriptors)
-InspectorTest.log(` - ${descriptor.name}: ${first
[webkit-changes] [207783] trunk/Source/WebCore
Title: [207783] trunk/Source/WebCore
Revision 207783
Author hy...@apple.com
Date 2016-10-24 14:51:44 -0700 (Mon, 24 Oct 2016)
Log Message
[CSS Parser] Fix :lang argument parsing
https://bugs.webkit.org/show_bug.cgi?id=163913
Reviewed by Zalan Bujtas.
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
Modify the map to support versions of the function pseudos
without the left paren included.
* css/parser/CSSParserValues.cpp:
(WebCore::CSSParserSelector::setLangArgumentList):
* css/parser/CSSParserValues.h:
Add a helper to just directly pass an AtomicString Vector through.
* css/parser/CSSSelectorParser.cpp:
(WebCore::consumeLangArgumentList):
(WebCore::CSSSelectorParser::consumePseudo):
Add a new consumeLangArgumentList to collect the languages into
an AtomicString Vector.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in
trunk/Source/WebCore/css/parser/CSSParserValues.cpp
trunk/Source/WebCore/css/parser/CSSParserValues.h
trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (207782 => 207783)
--- trunk/Source/WebCore/ChangeLog 2016-10-24 21:48:13 UTC (rev 207782)
+++ trunk/Source/WebCore/ChangeLog 2016-10-24 21:51:44 UTC (rev 207783)
@@ -1,3 +1,25 @@
+2016-10-24 Dave Hyatt
+
+[CSS Parser] Fix :lang argument parsing
+https://bugs.webkit.org/show_bug.cgi?id=163913
+
+Reviewed by Zalan Bujtas.
+
+* css/SelectorPseudoClassAndCompatibilityElementMap.in:
+Modify the map to support versions of the function pseudos
+without the left paren included.
+
+* css/parser/CSSParserValues.cpp:
+(WebCore::CSSParserSelector::setLangArgumentList):
+* css/parser/CSSParserValues.h:
+Add a helper to just directly pass an AtomicString Vector through.
+
+* css/parser/CSSSelectorParser.cpp:
+(WebCore::consumeLangArgumentList):
+(WebCore::CSSSelectorParser::consumePseudo):
+Add a new consumeLangArgumentList to collect the languages into
+an AtomicString Vector.
+
2016-10-24 Alex Christensen
Fix AppleWin build after r207720.
Modified: trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in (207782 => 207783)
--- trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in 2016-10-24 21:48:13 UTC (rev 207782)
+++ trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in 2016-10-24 21:51:44 UTC (rev 207783)
@@ -1,4 +1,5 @@
-khtml-drag
+-webkit-any
-webkit-any(
-webkit-any-link, PseudoClassAnyLinkDeprecated, PseudoElementUnknown
-webkit-autofill
@@ -13,6 +14,7 @@
decrement
default
#if ENABLE(CSS_SELECTORS_LEVEL4)
+dir
dir(
#endif
disabled
@@ -33,16 +35,23 @@
increment
indeterminate
invalid
+lang
lang(
last-child
last-of-type
link
+matches
matches(
no-button
+not
not(
+nth-child
nth-child(
+nth-last-child
nth-last-child(
+nth-last-of-type
nth-last-of-type(
+nth-of-type
nth-of-type(
only-child
only-of-type
@@ -53,6 +62,7 @@
read-write
required
#if ENABLE(CSS_SELECTORS_LEVEL4)
+role
role(
#endif
root
Modified: trunk/Source/WebCore/css/parser/CSSParserValues.cpp (207782 => 207783)
--- trunk/Source/WebCore/css/parser/CSSParserValues.cpp 2016-10-24 21:48:13 UTC (rev 207782)
+++ trunk/Source/WebCore/css/parser/CSSParserValues.cpp 2016-10-24 21:51:44 UTC (rev 207783)
@@ -410,7 +410,13 @@
argumentList->append(languageArgument);
m_selector->setLangArgumentList(WTFMove(argumentList));
}
-
+
+void CSSParserSelector::setLangArgumentList(std::unique_ptr> argumentList)
+{
+ASSERT_WITH_MESSAGE(!argumentList->isEmpty(), "No CSS Selector takes an empty argument list.");
+m_selector->setLangArgumentList(WTFMove(argumentList));
+}
+
void CSSParserSelector::setSelectorList(std::unique_ptr selectorList)
{
m_selector->setSelectorList(WTFMove(selectorList));
Modified: trunk/Source/WebCore/css/parser/CSSParserValues.h (207782 => 207783)
--- trunk/Source/WebCore/css/parser/CSSParserValues.h 2016-10-24 21:48:13 UTC (rev 207782)
+++ trunk/Source/WebCore/css/parser/CSSParserValues.h 2016-10-24 21:51:44 UTC (rev 207783)
@@ -235,6 +235,7 @@
void adoptSelectorVector(Vector>& selectorVector);
void setLangArgumentList(const Vector& stringVector);
+void setLangArgumentList(std::unique_ptr>);
void setSelectorList(std::unique_ptr);
void setPseudoClassValue(const CSSParserString& pseudoClassString);
Modified: trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp (207782 => 207783)
--- trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp 2016-10-24 21:48:13 UTC (rev 207782)
+++ trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp 2016-10-24 21:51:44 UTC (rev 207783)
@@ -100,6 +100,23 @@
return list;
}
+static void consumeLangArgumentList(std::unique_ptr>& argumentList, CSSParserTokenRange& range)
+{
+const CSSParserToken& ident = range
[webkit-changes] [207782] trunk
Title: [207782] trunk
Revision 207782
Author commit-qu...@webkit.org
Date 2016-10-24 14:48:13 -0700 (Mon, 24 Oct 2016)
Log Message
Web Inspector: Improve Quick Open sorting algorithm
https://bugs.webkit.org/show_bug.cgi?id=163705
Patch by Devin Rousso on 2016-10-24
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
* UserInterface/Models/ResourceQueryResult.js:
(WebInspector.ResourceQueryResult.prototype._calculateRank.getMultiplier):
(WebInspector.ResourceQueryResult.prototype._calculateRank):
Added logic to multiply the ranking increment/decrement based on whether the current match
is part of a sequence, whether that sequence began with a special character, and the length
of the current sequence.
LayoutTests:
* inspector/unit-tests/resource-query-controller-expected.txt:
* inspector/unit-tests/resource-query-controller.html:
Changed the ExecuteQueryGeneralRankings and ExecuteQueryPositionRankings tests to reflect
the new ranking logic. Added ExecuteQueryConsecutiveRankings to test more realistic
scenarios and ensure better ranking.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/unit-tests/resource-query-controller-expected.txt
trunk/LayoutTests/inspector/unit-tests/resource-query-controller.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/ResourceQueryResult.js
Diff
Modified: trunk/LayoutTests/ChangeLog (207781 => 207782)
--- trunk/LayoutTests/ChangeLog 2016-10-24 21:44:34 UTC (rev 207781)
+++ trunk/LayoutTests/ChangeLog 2016-10-24 21:48:13 UTC (rev 207782)
@@ -1,3 +1,16 @@
+2016-10-24 Devin Rousso
+
+Web Inspector: Improve Quick Open sorting algorithm
+https://bugs.webkit.org/show_bug.cgi?id=163705
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/unit-tests/resource-query-controller-expected.txt:
+* inspector/unit-tests/resource-query-controller.html:
+Changed the ExecuteQueryGeneralRankings and ExecuteQueryPositionRankings tests to reflect
+the new ranking logic. Added ExecuteQueryConsecutiveRankings to test more realistic
+scenarios and ensure better ranking.
+
2016-10-24 Ryan Haddad
Rebaseline tests for ios-simulator after r207757.
Modified: trunk/LayoutTests/inspector/unit-tests/resource-query-controller-expected.txt (207781 => 207782)
--- trunk/LayoutTests/inspector/unit-tests/resource-query-controller-expected.txt 2016-10-24 21:44:34 UTC (rev 207781)
+++ trunk/LayoutTests/inspector/unit-tests/resource-query-controller-expected.txt 2016-10-24 21:48:13 UTC (rev 207782)
@@ -208,6 +208,9 @@
-- Running test case: ExecuteQueryPositionRankings
PASS: Results should be ranked by descending relevancy.
+-- Running test case: ExecuteQueryConsecutiveRankings
+PASS: Results should be ranked by descending relevancy.
+
-- Running test case: GetMatchingTextRanges
PASS: Result TextRanges should match the expected ranges.
PASS: Result TextRanges should match the expected ranges.
Modified: trunk/LayoutTests/inspector/unit-tests/resource-query-controller.html (207781 => 207782)
--- trunk/LayoutTests/inspector/unit-tests/resource-query-controller.html 2016-10-24 21:44:34 UTC (rev 207781)
+++ trunk/LayoutTests/inspector/unit-tests/resource-query-controller.html 2016-10-24 21:48:13 UTC (rev 207782)
@@ -10,7 +10,7 @@
suite.addTestCase({
name: "FindSpecialCharacterIndices",
description: "Should correctly find special filename characters.",
-test: function() {
+test() {
let matcher = new WebInspector.ResourceQueryController;
let tests = [
{
@@ -69,7 +69,7 @@
suite.addTestCase({
name: "ExecuteQueryAgainstNoResources",
description: "Should return no results if no resources were added to the controller.",
-test: function() {
+test() {
let matcher = new WebInspector.ResourceQueryController;
let results = matcher.executeQuery("abcde");
InspectorTest.expectThat(!results.length, "Should return no results.")
@@ -79,7 +79,7 @@
suite.addTestCase({
name: "ExecuteWhitespaceQueryOrEmptyQuery",
description: "Empty queries and queries containing only whitespace should return no results.",
-test: function() {
+test() {
const whitespaceCharacters = " \t\r\n";
let matcher = new WebInspector.ResourceQueryController;
matcher.addResource(new WebInspector.Resource("abcde"));
@@ -97,7 +97,7 @@
suite.addTestCase({
name: "ExecuteQueryContainingWhitespace",
description: "Whitespace within a query should be ignored.",
-test: function() {
+test() {
let matcher = new WebInspector.ResourceQueryController;
matcher.addResource(new WebInspector.Resource("abcde"));
@@ -111,7 +111,7 @@
suite.addTestCase({
name: "ExecuteQueryMatchNone",
description: "Sho
[webkit-changes] [207781] trunk
Title: [207781] trunk
Revision 207781
Author keith_mil...@apple.com
Date 2016-10-24 14:44:34 -0700 (Mon, 24 Oct 2016)
Log Message
Wasm should support floating point operations.
https://bugs.webkit.org/show_bug.cgi?id=163770
Reviewed by Michael Saboff.
JSTests:
Add appropriate b3op names for floating point wasm bytecodes, where they exist.
Also, fix some WASM => Wasm in WasmOps.h generator script that I missed
the first time I made the change.
* wasm/generate-wasmops-header.js:
(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.template.typename.Int.inline.bool.isValidOpType): Deleted.
(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.enum.BinaryOpType): Deleted.
(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.enum.UnaryOpType): Deleted.
(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.enum.LoadOpType): Deleted.
(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.enum.StoreOpType): Deleted.
(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.undef.CREATE_ENUM_VALUE.inline.bool.isControlOp): Deleted.
* wasm/wasm.json:
Source/_javascript_Core:
Since we now have a Double => Float Trunc in B3, we can now support calls in Wasm
that take floating point arguments. This patch also enables most of the Wasm
floating point operations, as the associated B3 opcode has been linked via wasm.json.
If there is no direct mapping to a B3 opcode the Wasm is not yet implemented. This
patch also fixes a bug in calls where the arguments would be reversed.
* testWasm.cpp:
(cast):
(invoke):
(boxf):
(boxd):
(runWasmTests):
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::createJSWrapper):
* wasm/WasmCallingConvention.h:
(JSC::Wasm::CallingConvention::loadArguments):
(JSC::Wasm::CallingConvention::setupCall):
* wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser::parseExpression):
(JSC::Wasm::FunctionParser::parseUnreachableExpression):
* wasm/WasmOps.h:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/wasm/generate-wasmops-header.js
trunk/JSTests/wasm/wasm.json
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/testWasm.cpp
trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
trunk/Source/_javascript_Core/wasm/WasmCallingConvention.h
trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h
trunk/Source/_javascript_Core/wasm/WasmOps.h
Diff
Modified: trunk/JSTests/ChangeLog (207780 => 207781)
--- trunk/JSTests/ChangeLog 2016-10-24 21:34:09 UTC (rev 207780)
+++ trunk/JSTests/ChangeLog 2016-10-24 21:44:34 UTC (rev 207781)
@@ -1,3 +1,23 @@
+2016-10-24 Keith Miller
+
+Wasm should support floating point operations.
+https://bugs.webkit.org/show_bug.cgi?id=163770
+
+Reviewed by Michael Saboff.
+
+Add appropriate b3op names for floating point wasm bytecodes, where they exist.
+Also, fix some WASM => Wasm in WasmOps.h generator script that I missed
+the first time I made the change.
+
+* wasm/generate-wasmops-header.js:
+(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.template.typename.Int.inline.bool.isValidOpType): Deleted.
+(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.enum.BinaryOpType): Deleted.
+(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.enum.UnaryOpType): Deleted.
+(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.enum.LoadOpType): Deleted.
+(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.enum.StoreOpType): Deleted.
+(const.template.pragma.once.ENABLE.WEBASSEMBLY.include.cstdint.namespace.JSC.namespace.WASM.undef.CREATE_ENUM_VALUE.inline.bool.isControlOp): Deleted.
+* wasm/wasm.json:
+
2016-10-21 Saam Barati
SpeculativeJIT::compileTryGetById needs to pass in NeedsToSpill along both the cell speculation and untyped speculation path
Modified: trunk/JSTests/wasm/generate-wasmops-header.js (207780 => 207781)
--- trunk/JSTests/wasm/generate-wasmops-header.js 2016-10-24 21:34:09 UTC (rev 207780)
+++ trunk/JSTests/wasm/generate-wasmops-header.js 2016-10-24 21:44:34 UTC (rev 207781)
@@ -1,4 +1,4 @@
-// Use the JSON description of WebAssembly to generate the _javascript_Core's WASMOps.h.
+// Use the JSON description of WebAssembly to generate the _javascript_Core's WasmOps.h.
const jsonFile = 'wasm.json';
const wasm = JSON.parse(read(jsonFile));
@@ -90,7 +90,7 @@
#include
-namespace JSC { namespace WASM {
+namespace JSC { namespace Wasm {
${defines}
@@ -147,7 +147,7 @@
return false;
}
-} } // namespace JSC::WASM
+} } // namespace JSC::Wasm
#endif // ENABLE(WEBASSEMBLY)
`;
Mo
[webkit-changes] [207780] trunk/Source/WebCore
Title: [207780] trunk/Source/WebCore Revision 207780 Author achristen...@apple.com Date 2016-10-24 14:34:09 -0700 (Mon, 24 Oct 2016) Log Message Fix AppleWin build after r207720. * html/canvas/OESVertexArrayObject.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (207779 => 207780) --- trunk/Source/WebCore/ChangeLog 2016-10-24 21:17:14 UTC (rev 207779) +++ trunk/Source/WebCore/ChangeLog 2016-10-24 21:34:09 UTC (rev 207780) @@ -2,6 +2,12 @@ Fix AppleWin build after r207720. +* html/canvas/OESVertexArrayObject.cpp: + +2016-10-24 Alex Christensen + +Fix AppleWin build after r207720. + * bindings/js/JSWebGLRenderingContextBaseCustom.cpp: 2016-10-24 Alex Christensen Modified: trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp (207779 => 207780) --- trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp 2016-10-24 21:17:14 UTC (rev 207779) +++ trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp 2016-10-24 21:34:09 UTC (rev 207780) @@ -24,10 +24,11 @@ */ #include "config.h" -#include "OESVertexArrayObject.h" #if ENABLE(WEBGL) +#include "OESVertexArrayObject.h" + #include "Extensions3D.h" #include "WebGLRenderingContext.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207779] trunk/Source/WebCore
Title: [207779] trunk/Source/WebCore Revision 207779 Author achristen...@apple.com Date 2016-10-24 14:17:14 -0700 (Mon, 24 Oct 2016) Log Message Fix AppleWin build after r207720. * bindings/js/JSWebGLRenderingContextBaseCustom.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (207778 => 207779) --- trunk/Source/WebCore/ChangeLog 2016-10-24 21:16:17 UTC (rev 207778) +++ trunk/Source/WebCore/ChangeLog 2016-10-24 21:17:14 UTC (rev 207779) @@ -1,5 +1,11 @@ 2016-10-24 Alex Christensen +Fix AppleWin build after r207720. + +* bindings/js/JSWebGLRenderingContextBaseCustom.cpp: + +2016-10-24 Alex Christensen + Fix Windows build after r207767 and r207769 * css/CSSAllInOne.cpp: Modified: trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp (207778 => 207779) --- trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp 2016-10-24 21:16:17 UTC (rev 207778) +++ trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp 2016-10-24 21:17:14 UTC (rev 207779) @@ -24,10 +24,11 @@ */ #include "config.h" -#include "JSWebGLRenderingContextBase.h" #if ENABLE(WEBGL) +#include "JSWebGLRenderingContextBase.h" + #include "ANGLEInstancedArrays.h" #include "EXTBlendMinMax.h" #include "EXTFragDepth.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207778] trunk/LayoutTests
Title: [207778] trunk/LayoutTests
Revision 207778
Author ryanhad...@apple.com
Date 2016-10-24 14:16:17 -0700 (Mon, 24 Oct 2016)
Log Message
Rebaseline tests for ios-simulator after r207757.
https://bugs.webkit.org/show_bug.cgi?id=163904
Unreviewed test gardening.
* platform/ios-simulator/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
* platform/ios-simulator/svg/batik/text/verticalText-expected.txt:
* platform/ios-simulator/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/ios-simulator/svg/text/text-align-06-b-expected.txt:
* platform/ios-simulator/svg/text/text-vkern-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/svg/W3C-SVG-1.1/text-align-06-b-expected.txt
trunk/LayoutTests/platform/ios-simulator/svg/batik/text/verticalText-expected.txt
trunk/LayoutTests/platform/ios-simulator/svg/batik/text/verticalTextOnPath-expected.txt
trunk/LayoutTests/platform/ios-simulator/svg/text/text-align-06-b-expected.txt
trunk/LayoutTests/platform/ios-simulator/svg/text/text-vkern-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (20 => 207778)
--- trunk/LayoutTests/ChangeLog 2016-10-24 21:01:53 UTC (rev 20)
+++ trunk/LayoutTests/ChangeLog 2016-10-24 21:16:17 UTC (rev 207778)
@@ -1,3 +1,16 @@
+2016-10-24 Ryan Haddad
+
+Rebaseline tests for ios-simulator after r207757.
+https://bugs.webkit.org/show_bug.cgi?id=163904
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
+* platform/ios-simulator/svg/batik/text/verticalText-expected.txt:
+* platform/ios-simulator/svg/batik/text/verticalTextOnPath-expected.txt:
+* platform/ios-simulator/svg/text/text-align-06-b-expected.txt:
+* platform/ios-simulator/svg/text/text-vkern-expected.txt:
+
2016-10-24 Alex Christensen
Rebase tests after r207767
Modified: trunk/LayoutTests/platform/ios-simulator/svg/W3C-SVG-1.1/text-align-06-b-expected.txt (20 => 207778)
--- trunk/LayoutTests/platform/ios-simulator/svg/W3C-SVG-1.1/text-align-06-b-expected.txt 2016-10-24 21:01:53 UTC (rev 20)
+++ trunk/LayoutTests/platform/ios-simulator/svg/W3C-SVG-1.1/text-align-06-b-expected.txt 2016-10-24 21:16:17 UTC (rev 207778)
@@ -12,7 +12,7 @@
RenderSVGInlineText {#text} at (0,0) size 17x68
chunk 1 (vertical) text run 1 at (-10.50,0.00) startOffset 0 endOffset 1 height 34.00: "t"
chunk 1 (vertical) text run 2 at (-10.50,34.00) startOffset 1 endOffset 2 height 34.00: "e"
-RenderSVGTSpan {tspan} at (0,0) size 17x34
+RenderSVGTSpan {tspan} at (0,0) size 34x17
RenderSVGInlineText {#text} at (7,68) size 17x34
chunk 1 (vertical) text run 1 at (-3.50,68.00) startOffset 0 endOffset 1 height 34.00: "7"
RenderSVGInlineText {#text} at (0,102) size 15x68
@@ -22,7 +22,7 @@
RenderSVGInlineText {#text} at (25,0) size 17x68
chunk 1 (vertical) text run 1 at (69.50,0.00) startOffset 0 endOffset 1 height 34.00: "t"
chunk 1 (vertical) text run 2 at (69.50,34.00) startOffset 1 endOffset 2 height 34.00: "e"
-RenderSVGTSpan {tspan} at (0,0) size 27x136
+RenderSVGTSpan {tspan} at (0,0) size 136x27
RenderSVGInlineText {#text} at (0,68) size 27x136
chunk 1 (vertical) text run 1 at (48.50,68.00) startOffset 0 endOffset 1 height 34.00: "-"
chunk 1 (vertical) text run 2 at (48.50,102.00) startOffset 1 endOffset 2 height 34.00: "7"
@@ -35,12 +35,12 @@
RenderSVGInlineText {#text} at (17,0) size 17x68
chunk 1 (vertical) text run 1 at (169.50,0.00) startOffset 0 endOffset 1 height 34.00: "t"
chunk 1 (vertical) text run 2 at (169.50,34.00) startOffset 1 endOffset 2 height 34.00: "e"
-RenderSVGTSpan {tspan} at (0,0) size 17x102
+RenderSVGTSpan {tspan} at (0,0) size 102x17
RenderSVGInlineText {#text} at (0,68) size 17x102
chunk 1 (vertical) text run 1 at (152.00,68.00) startOffset 0 endOffset 1 height 34.00: "s"
chunk 1 (vertical) text run 2 at (152.00,102.00) startOffset 1 endOffset 2 height 34.00: "u"
chunk 1 (vertical) text run 3 at (152.00,136.00) startOffset 2 endOffset 3 height 34.00: "b"
-RenderSVGTSpan {tspan} at (0,0) size 16x34
+RenderSVGTSpan {tspan} at (0,0) size 35x15
RenderSVGInlineText {#text} at (18,170) size 15x34
chunk 1 (vertical) text run 1 at (169.50,170.00) startOffset 0 endOffset 1 height 34.00: "x"
RenderSVGInlineText {#text} at (21,204) size 9x34
@@ -49,7 +49,7 @@
RenderSVGInlineText {#text} at (0,0) size 17x68
chunk 1 (vertical) text run 1 at (249.50,0.00) startOffset 0 endOffset 1 height 34.00: "t"
chunk 1 (vertical) text r
[webkit-changes] [207777] trunk/LayoutTests
Title: [20] trunk/LayoutTests
Revision 20
Author achristen...@apple.com
Date 2016-10-24 14:01:53 -0700 (Mon, 24 Oct 2016)
Log Message
Rebase tests after r207767
https://bugs.webkit.org/show_bug.cgi?id=163891
* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:
No more CSSCharsetRule.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (207776 => 20)
--- trunk/LayoutTests/ChangeLog 2016-10-24 20:53:28 UTC (rev 207776)
+++ trunk/LayoutTests/ChangeLog 2016-10-24 21:01:53 UTC (rev 20)
@@ -1,3 +1,17 @@
+2016-10-24 Alex Christensen
+
+Rebase tests after r207767
+https://bugs.webkit.org/show_bug.cgi?id=163891
+
+* js/dom/global-constructors-attributes-expected.txt:
+* platform/efl/js/dom/global-constructors-attributes-expected.txt:
+* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac/js/dom/global-constructors-attributes-expected.txt:
+* platform/win/js/dom/global-constructors-attributes-expected.txt:
+No more CSSCharsetRule.
+
2016-10-24 Ryan Haddad
Rebaseline inspector/dom/getAccessibilityPropertiesForNode.html
Modified: trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt (207776 => 20)
--- trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt 2016-10-24 20:53:28 UTC (rev 207776)
+++ trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt 2016-10-24 21:01:53 UTC (rev 20)
@@ -113,11 +113,6 @@
PASS Object.getOwnPropertyDescriptor(global, 'CSS').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'CSS').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'CSS').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').value is CSSCharsetRule
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').value is CSSFontFaceRule
PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt (207776 => 20)
--- trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt 2016-10-24 20:53:28 UTC (rev 207776)
+++ trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt 2016-10-24 21:01:53 UTC (rev 20)
@@ -108,11 +108,6 @@
PASS Object.getOwnPropertyDescriptor(global, 'CSS').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'CSS').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'CSS').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').value is CSSCharsetRule
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').value is CSSFontFaceRule
PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').hasOwnProperty('set') is fal
[webkit-changes] [207776] trunk/Source/WebCore
Title: [207776] trunk/Source/WebCore Revision 207776 Author achristen...@apple.com Date 2016-10-24 13:53:28 -0700 (Mon, 24 Oct 2016) Log Message Fix Windows build after r207767 and r207769 * css/CSSAllInOne.cpp: * platform/network/curl/ResourceHandleManager.cpp: (WebCore::getProtectionSpace): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSAllInOne.cpp trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (207775 => 207776) --- trunk/Source/WebCore/ChangeLog 2016-10-24 20:47:04 UTC (rev 207775) +++ trunk/Source/WebCore/ChangeLog 2016-10-24 20:53:28 UTC (rev 207776) @@ -1,3 +1,11 @@ +2016-10-24 Alex Christensen + +Fix Windows build after r207767 and r207769 + +* css/CSSAllInOne.cpp: +* platform/network/curl/ResourceHandleManager.cpp: +(WebCore::getProtectionSpace): + 2016-10-24 Per Arne Vollan [Win] AVCF based media engine does not block cross-site/cross-domain loads. Modified: trunk/Source/WebCore/css/CSSAllInOne.cpp (207775 => 207776) --- trunk/Source/WebCore/css/CSSAllInOne.cpp 2016-10-24 20:47:04 UTC (rev 207775) +++ trunk/Source/WebCore/css/CSSAllInOne.cpp 2016-10-24 20:53:28 UTC (rev 207776) @@ -32,7 +32,6 @@ #include "CSSBorderImageSliceValue.cpp" #include "CSSCalculationValue.cpp" #include "CSSCanvasValue.cpp" -#include "CSSCharsetRule.cpp" #include "CSSComputedStyleDeclaration.cpp" #include "CSSContentDistributionValue.cpp" #include "CSSCrossfadeValue.cpp" Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp (207775 => 207776) --- trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp 2016-10-24 20:47:04 UTC (rev 207775) +++ trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp 2016-10-24 20:53:28 UTC (rev 207776) @@ -423,7 +423,7 @@ return false; String host = url.host(); -String protocol = url.protocol(); +StringView protocol = url.protocol(); String realm; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207775] trunk/Source/WebCore
Title: [207775] trunk/Source/WebCore
Revision 207775
Author pvol...@apple.com
Date 2016-10-24 13:47:04 -0700 (Mon, 24 Oct 2016)
Log Message
[Win] AVCF based media engine does not block cross-site/cross-domain loads.
https://bugs.webkit.org/show_bug.cgi?id=163783
Reviewed by Brent Fulgham.
Prevent cross-site/cross-domain loads by setting appropriate AVCF options.
No new tests; covered by media/video-canvas-source.html. Media tests are
currently skipped on Windows.
* platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h:
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::resolvedURL):
(WebCore::MediaPlayerPrivateAVFoundationCF::hasSingleSecurityOrigin):
(WebCore::AVFWrapper::createAssetForURL):
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h
trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (207774 => 207775)
--- trunk/Source/WebCore/ChangeLog 2016-10-24 20:42:48 UTC (rev 207774)
+++ trunk/Source/WebCore/ChangeLog 2016-10-24 20:47:04 UTC (rev 207775)
@@ -1,3 +1,22 @@
+2016-10-24 Per Arne Vollan
+
+[Win] AVCF based media engine does not block cross-site/cross-domain loads.
+https://bugs.webkit.org/show_bug.cgi?id=163783
+
+Reviewed by Brent Fulgham.
+
+Prevent cross-site/cross-domain loads by setting appropriate AVCF options.
+
+No new tests; covered by media/video-canvas-source.html. Media tests are
+currently skipped on Windows.
+
+* platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h:
+* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::MediaPlayerPrivateAVFoundationCF::resolvedURL):
+(WebCore::MediaPlayerPrivateAVFoundationCF::hasSingleSecurityOrigin):
+(WebCore::AVFWrapper::createAssetForURL):
+* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
+
2016-10-24 Anders Carlsson
Fix build with newer versions of clang
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h (207774 => 207775)
--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h 2016-10-24 20:42:48 UTC (rev 207774)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h 2016-10-24 20:47:04 UTC (rev 207775)
@@ -225,6 +225,9 @@
SOFT_LINK_DLL_IMPORT(AVFoundationCF, AVCFURLAssetCreateWithURLAndOptions, AVCFURLAssetRef, __cdecl, (CFAllocatorRef allocator, CFURLRef URL, CFDictionaryRef options, dispatch_queue_t notificationQueue), (allocator, URL, options, notificationQueue))
#define AVCFURLAssetCreateWithURLAndOptions softLink_AVCFURLAssetCreateWithURLAndOptions
+SOFT_LINK_DLL_IMPORT(AVFoundationCF, AVCFAssetCopyResolvedURL, CFURLRef, __cdecl, (AVCFAssetRef asset), (asset));
+#define AVCFAssetCopyResolvedURL softLink_AVCFAssetCopyResolvedURL
+
SOFT_LINK_DLL_IMPORT_OPTIONAL(AVFoundationCF, AVCFPlayerSetDirect3DDevice, void, __cdecl, (AVCFPlayerRef player, IDirect3DDevice9* d3dDevice))
#define AVCFPlayerSetDirect3DDevice softLink_AVCFPlayerSetDirect3DDevice
@@ -397,6 +400,9 @@
SOFT_LINK_VARIABLE_DLL_IMPORT(AVFoundationCF, AVCFURLAssetInheritURIQueryComponentFromReferencingURIKey, const CFStringRef);
#define AVCFURLAssetInheritURIQueryComponentFromReferencingURIKey getAVCFURLAssetInheritURIQueryComponentFromReferencingURIKey()
+SOFT_LINK_VARIABLE_DLL_IMPORT(AVFoundationCF, AVCFURLAssetReferenceRestrictionsKey, const CFStringRef);
+#define AVCFURLAssetReferenceRestrictionsKey getAVCFURLAssetReferenceRestrictionsKey()
+
SOFT_LINK_VARIABLE_DLL_IMPORT(AVFoundationCF, AVCFMediaCharacteristicEasyToRead, const CFStringRef);
#define AVCFMediaCharacteristicEasyToRead getAVCFMediaCharacteristicEasyToRead()
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp (207774 => 207775)
--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp 2016-10-24 20:42:48 UTC (rev 207774)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp 2016-10-24 20:47:04 UTC (rev 207775)
@@ -83,6 +83,11 @@
#pragma comment(lib, "libdispatch.lib")
#endif
+enum {
+AVAssetReferenceRestrictionForbidRemoteReferenceToLocal = (1UL << 0),
+AVAssetReferenceRestrictionForbidLocalReferenceToRemote = (1UL << 1)
+};
+
using namespace std;
namespace WebCore {
@@ -1333,6 +1338,26 @@
m_avfWrapper->setVideoLayerNeedsCommit();
}
+URL MediaPlayerPrivateAVFoundationCF::resolvedURL() const
+{
+if (!m_avfWrapper || !m_avfWrapper->avAsset())
[webkit-changes] [207774] trunk/Source/WebCore
Title: [207774] trunk/Source/WebCore
Revision 207774
Author ander...@apple.com
Date 2016-10-24 13:42:48 -0700 (Mon, 24 Oct 2016)
Log Message
Fix build with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=163908
rdar://problem/28852016
Reviewed by Tim Horton.
Use the macros that names the soft-linked functions in such a way that they won't conflict with actual functions.
* platform/ios/PlatformScreenIOS.mm:
(WebCore::screenIsMonochrome):
(WebCore::screenHasInvertedColors):
(WebCore::screenSize):
(WebCore::availableScreenSize):
(WebCore::screenScaleFactor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/PlatformScreenIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (207773 => 207774)
--- trunk/Source/WebCore/ChangeLog 2016-10-24 20:25:02 UTC (rev 207773)
+++ trunk/Source/WebCore/ChangeLog 2016-10-24 20:42:48 UTC (rev 207774)
@@ -1,3 +1,20 @@
+2016-10-24 Anders Carlsson
+
+Fix build with newer versions of clang
+https://bugs.webkit.org/show_bug.cgi?id=163908
+rdar://problem/28852016
+
+Reviewed by Tim Horton.
+
+Use the macros that names the soft-linked functions in such a way that they won't conflict with actual functions.
+
+* platform/ios/PlatformScreenIOS.mm:
+(WebCore::screenIsMonochrome):
+(WebCore::screenHasInvertedColors):
+(WebCore::screenSize):
+(WebCore::availableScreenSize):
+(WebCore::screenScaleFactor):
+
2016-10-24 Joseph Pecoraro
Remove unnecessary unused variable stubs
Modified: trunk/Source/WebCore/platform/ios/PlatformScreenIOS.mm (207773 => 207774)
--- trunk/Source/WebCore/platform/ios/PlatformScreenIOS.mm 2016-10-24 20:25:02 UTC (rev 207773)
+++ trunk/Source/WebCore/platform/ios/PlatformScreenIOS.mm 2016-10-24 20:42:48 UTC (rev 207774)
@@ -39,11 +39,11 @@
#import "WebCoreSystemInterface.h"
#import "Widget.h"
-SOFT_LINK_FRAMEWORK(UIKit)
-SOFT_LINK_CLASS(UIKit, UIApplication)
-SOFT_LINK_CLASS(UIKit, UIScreen)
-SOFT_LINK(UIKit, UIAccessibilityIsGrayscaleEnabled, BOOL, (void), ())
-SOFT_LINK(UIKit, UIAccessibilityIsInvertColorsEnabled, BOOL, (void), ())
+SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, UIKit)
+SOFT_LINK_CLASS_FOR_SOURCE(WebCore, UIKit, UIApplication)
+SOFT_LINK_CLASS_FOR_SOURCE(WebCore, UIKit, UIScreen)
+SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, UIKit, UIAccessibilityIsGrayscaleEnabled, BOOL, (void), ())
+SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, UIKit, UIAccessibilityIsInvertColorsEnabled, BOOL, (void), ())
namespace WebCore {
@@ -61,12 +61,12 @@
bool screenIsMonochrome(Widget*)
{
-return UIAccessibilityIsGrayscaleEnabled();
+return softLinkUIKitUIAccessibilityIsGrayscaleEnabled();
}
bool screenHasInvertedColors()
{
-return UIAccessibilityIsInvertColorsEnabled();
+return softLinkUIKitUIAccessibilityIsInvertColorsEnabled();
}
bool screenSupportsExtendedColor(Widget*)
@@ -131,28 +131,28 @@
FloatSize screenSize()
{
-if (deviceHasIPadCapability() && [[getUIApplicationClass() sharedApplication] _isClassic])
+if (deviceHasIPadCapability() && [[get_UIKit_UIApplicationClass() sharedApplication] _isClassic])
return { 320, 480 };
-return FloatSize([[getUIScreenClass() mainScreen] _referenceBounds].size);
+return FloatSize([[get_UIKit_UIScreenClass() mainScreen] _referenceBounds].size);
}
FloatSize availableScreenSize()
{
-if (deviceHasIPadCapability() && [[getUIApplicationClass() sharedApplication] _isClassic])
+if (deviceHasIPadCapability() && [[get_UIKit_UIApplicationClass() sharedApplication] _isClassic])
return { 320, 480 };
-return FloatSize([getUIScreenClass() mainScreen].bounds.size);
+return FloatSize([get_UIKit_UIScreenClass() mainScreen].bounds.size);
}
float screenScaleFactor(UIScreen *screen)
{
if (!screen)
-screen = [getUIScreenClass() mainScreen];
+screen = [get_UIKit_UIScreenClass() mainScreen];
CGFloat scale = screen.scale;
// We can remove this clamping once is fixed.
const CGFloat maximumClassicScreenScaleFactor = 2;
-if ([[getUIApplicationClass() sharedApplication] _isClassic])
+if ([[get_UIKit_UIApplicationClass() sharedApplication] _isClassic])
return std::min(scale, maximumClassicScreenScaleFactor);
return scale;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207773] trunk/Source/WebCore
Title: [207773] trunk/Source/WebCore
Revision 207773
Author commit-qu...@webkit.org
Date 2016-10-24 13:25:02 -0700 (Mon, 24 Oct 2016)
Log Message
Remove unnecessary unused variable stubs
https://bugs.webkit.org/show_bug.cgi?id=163688
Patch by Joseph Pecoraro on 2016-10-24
Reviewed by Simon Fraser.
* Modules/applepay/cocoa/PaymentCocoa.mm:
(WebCore::toDictionary):
* Modules/applepay/cocoa/PaymentContactCocoa.mm:
(WebCore::toDictionary):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/cocoa/PaymentCocoa.mm
trunk/Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (207772 => 207773)
--- trunk/Source/WebCore/ChangeLog 2016-10-24 20:19:23 UTC (rev 207772)
+++ trunk/Source/WebCore/ChangeLog 2016-10-24 20:25:02 UTC (rev 207773)
@@ -1,3 +1,15 @@
+2016-10-24 Joseph Pecoraro
+
+Remove unnecessary unused variable stubs
+https://bugs.webkit.org/show_bug.cgi?id=163688
+
+Reviewed by Simon Fraser.
+
+* Modules/applepay/cocoa/PaymentCocoa.mm:
+(WebCore::toDictionary):
+* Modules/applepay/cocoa/PaymentContactCocoa.mm:
+(WebCore::toDictionary):
+
2016-10-24 Alex Christensen
Try to fix Windows build after r207767
Modified: trunk/Source/WebCore/Modules/applepay/cocoa/PaymentCocoa.mm (207772 => 207773)
--- trunk/Source/WebCore/Modules/applepay/cocoa/PaymentCocoa.mm 2016-10-24 20:19:23 UTC (rev 207772)
+++ trunk/Source/WebCore/Modules/applepay/cocoa/PaymentCocoa.mm 2016-10-24 20:25:02 UTC (rev 207773)
@@ -53,7 +53,6 @@
static RetainPtr toDictionary(PKPayment *payment)
{
ASSERT(payment);
-(void)payment;
auto result = adoptNS([[NSMutableDictionary alloc] init]);
Modified: trunk/Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm (207772 => 207773)
--- trunk/Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm 2016-10-24 20:19:23 UTC (rev 207772)
+++ trunk/Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm 2016-10-24 20:25:02 UTC (rev 207773)
@@ -126,7 +126,6 @@
RetainPtr toDictionary(PKContact *contact)
{
ASSERT(contact);
-(void)contact;
auto result = adoptNS([[NSMutableDictionary alloc] init]);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207772] trunk/Source/WebCore
Title: [207772] trunk/Source/WebCore Revision 207772 Author achristen...@apple.com Date 2016-10-24 13:19:23 -0700 (Mon, 24 Oct 2016) Log Message Try to fix Windows build after r207767 https://bugs.webkit.org/show_bug.cgi?id=163891 * DerivedSources.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (207771 => 207772) --- trunk/Source/WebCore/ChangeLog 2016-10-24 18:53:09 UTC (rev 207771) +++ trunk/Source/WebCore/ChangeLog 2016-10-24 20:19:23 UTC (rev 207772) @@ -1,3 +1,10 @@ +2016-10-24 Alex Christensen + +Try to fix Windows build after r207767 +https://bugs.webkit.org/show_bug.cgi?id=163891 + +* DerivedSources.cpp: + 2016-10-24 Zan Dobersek [CodeGenerator] Only allow a single interface or standalone dictionary per WebIDL file Modified: trunk/Source/WebCore/DerivedSources.cpp (207771 => 207772) --- trunk/Source/WebCore/DerivedSources.cpp 2016-10-24 18:53:09 UTC (rev 207771) +++ trunk/Source/WebCore/DerivedSources.cpp 2016-10-24 20:19:23 UTC (rev 207772) @@ -116,7 +116,6 @@ #include "JSCoordinates.cpp" #include "JSCounter.cpp" #include "JSCrypto.cpp" -#include "JSCSSCharsetRule.cpp" #if ENABLE(FONT_LOAD_EVENTS) #include "JSCSSFontFaceLoadEvent.cpp" #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207771] trunk/LayoutTests
Title: [207771] trunk/LayoutTests Revision 207771 Author ryanhad...@apple.com Date 2016-10-24 11:53:09 -0700 (Mon, 24 Oct 2016) Log Message Rebaseline inspector/dom/getAccessibilityPropertiesForNode.html https://bugs.webkit.org/show_bug.cgi?id=163901 Unreviewed test gardening. * inspector/dom/getAccessibilityPropertiesForNode-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (207770 => 207771) --- trunk/LayoutTests/ChangeLog 2016-10-24 18:29:36 UTC (rev 207770) +++ trunk/LayoutTests/ChangeLog 2016-10-24 18:53:09 UTC (rev 207771) @@ -1,3 +1,12 @@ +2016-10-24 Ryan Haddad + +Rebaseline inspector/dom/getAccessibilityPropertiesForNode.html +https://bugs.webkit.org/show_bug.cgi?id=163901 + +Unreviewed test gardening. + +* inspector/dom/getAccessibilityPropertiesForNode-expected.txt: + 2016-10-24 Dave Hyatt Remove CSSCharsetRule from the CSS OM Modified: trunk/LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt (207770 => 207771) --- trunk/LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt 2016-10-24 18:29:36 UTC (rev 207770) +++ trunk/LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt 2016-10-24 18:53:09 UTC (rev 207771) @@ -23,7 +23,7 @@ role: treeitem childNodeIds.length: 1 parentNodeId: exists -hierarchyLevel: 2 +hierarchyLevel: 1 Tree Item Level 2 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207770] trunk/Source/WebCore
Title: [207770] trunk/Source/WebCore Revision 207770 Author zandober...@gmail.com Date 2016-10-24 11:29:36 -0700 (Mon, 24 Oct 2016) Log Message [CodeGenerator] Only allow a single interface or standalone dictionary per WebIDL file https://bugs.webkit.org/show_bug.cgi?id=163889 Reviewed by Chris Dumez. Assert that there's only one interface or standalone dictionary per WebIDL input file, and exit from the generator otherwise. This avoids potential linking issues where multiple enumeration and dictionary bindings code can be generated if the source WebIDL for them is specified in a file that contains multiple interfaces or standalone dictionaries. Additionally, the generator now also exits if it fails to generate code for any interface of standalone dictionary. This should avoid processing WebIDL files that are empty in substance. TestException.idl and TestInterface.idl files have their second interfaces removed. In place of those a new testing IDL file is added, TestInterfaceLeadingUnderscore.idl. Like the two removed interfaces, it tests that the leading underscode in the identifier is removed by the generator. * bindings/scripts/CodeGenerator.pm: (ProcessDocument): * bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp: Added. (WebCore::JSTestInterfaceLeadingUnderscorePrototype::create): (WebCore::JSTestInterfaceLeadingUnderscorePrototype::createStructure): (WebCore::JSTestInterfaceLeadingUnderscorePrototype::JSTestInterfaceLeadingUnderscorePrototype): (WebCore::JSTestInterfaceLeadingUnderscoreConstructor::prototypeForStructure): (WebCore::JSTestInterfaceLeadingUnderscoreConstructor::initializeProperties): (WebCore::JSTestInterfaceLeadingUnderscorePrototype::finishCreation): (WebCore::JSTestInterfaceLeadingUnderscore::JSTestInterfaceLeadingUnderscore): (WebCore::JSTestInterfaceLeadingUnderscore::createPrototype): (WebCore::JSTestInterfaceLeadingUnderscore::prototype): (WebCore::JSTestInterfaceLeadingUnderscore::destroy): (WebCore::BindingCaller::castForAttribute): (WebCore::jsTestInterfaceLeadingUnderscoreReadonly): (WebCore::jsTestInterfaceLeadingUnderscoreReadonlyGetter): (WebCore::jsTestInterfaceLeadingUnderscoreConstructor): (WebCore::setJSTestInterfaceLeadingUnderscoreConstructor): (WebCore::JSTestInterfaceLeadingUnderscore::getConstructor): (WebCore::JSTestInterfaceLeadingUnderscoreOwner::isReachableFromOpaqueRoots): (WebCore::JSTestInterfaceLeadingUnderscoreOwner::finalize): (WebCore::toJSNewlyCreated): (WebCore::toJS): (WebCore::JSTestInterfaceLeadingUnderscore::toWrapped): * bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.h: Renamed from Source/WebCore/bindings/scripts/test/JS/JSreadonly.h. (WebCore::JSTestInterfaceLeadingUnderscore::create): (WebCore::JSTestInterfaceLeadingUnderscore::createStructure): (WebCore::JSTestInterfaceLeadingUnderscore::finishCreation): (WebCore::wrapperOwner): (WebCore::wrapperKey): (WebCore::toJS): (WebCore::toJSNewlyCreated): * bindings/scripts/test/JS/JSattribute.cpp: Removed. * bindings/scripts/test/JS/JSattribute.h: Removed. * bindings/scripts/test/JS/JSreadonly.cpp: Removed. * bindings/scripts/test/TestException.idl: * bindings/scripts/test/TestInterface.idl: * bindings/scripts/test/TestInterfaceLeadingUnderscore.idl: Copied from Source/WebCore/bindings/scripts/test/TestException.idl. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm trunk/Source/WebCore/bindings/scripts/test/TestException.idl trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl Added Paths trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.h trunk/Source/WebCore/bindings/scripts/test/TestInterfaceLeadingUnderscore.idl Removed Paths trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.h trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.h Diff Modified: trunk/Source/WebCore/ChangeLog (207769 => 207770) --- trunk/Source/WebCore/ChangeLog 2016-10-24 18:25:40 UTC (rev 207769) +++ trunk/Source/WebCore/ChangeLog 2016-10-24 18:29:36 UTC (rev 207770) @@ -1,3 +1,68 @@ +2016-10-24 Zan Dobersek + +[CodeGenerator] Only allow a single interface or standalone dictionary per WebIDL file +https://bugs.webkit.org/show_bug.cgi?id=163889 + +Reviewed by Chris Dumez. + +Assert that there's only one interface or standalone dictionary +per WebIDL input file, and exit from the generator otherwise. + +This avoids potential linking issues where multiple enumeration +and dictionary bindings code can be generated if the source +WebIDL for them is specified in a file that contains multiple +interfaces or standalone dictionaries. + +Additionally, the generator now also exits if it fails to +
[webkit-changes] [207769] trunk
Title: [207769] trunk Revision 207769 Author achristen...@apple.com Date 2016-10-24 11:25:40 -0700 (Mon, 24 Oct 2016) Log Message URL::port should return Optional https://bugs.webkit.org/show_bug.cgi?id=163806 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/url/a-element-expected.txt: * web-platform-tests/url/a-element-xhtml-expected.txt: * web-platform-tests/url/url-constructor-expected.txt: Source/WebCore: A URL without a port is different than a URL with port 0. This matches the spec, Chrome, and Firefox. Covered by newly-passing web platform tests. * Modules/indexeddb/IDBDatabaseIdentifier.h: (WebCore::IDBDatabaseIdentifier::IDBDatabaseIdentifier): (WebCore::IDBDatabaseIdentifier::isHashTableDeletedValue): (WebCore::IDBDatabaseIdentifier::hash): (WebCore::IDBDatabaseIdentifier::isValid): (WebCore::IDBDatabaseIdentifier::isEmpty): * Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::connect): * Modules/websockets/WebSocketHandshake.cpp: (WebCore::hostName): * contentextensions/ContentExtensionsBackend.cpp: (WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad): (WebCore::ContentExtensions::applyBlockedStatusToRequest): * html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::userDidClickSnapshot): (WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): * html/URLUtils.h: (WebCore::URLUtils::protocol): (WebCore::URLUtils::host): (WebCore::URLUtils::port): * loader/CrossOriginAccessControl.cpp: (WebCore::isValidCrossOriginRedirectionURL): * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::responseReceived): (WebCore::isRemoteWebArchive): (WebCore::DocumentLoader::maybeLoadEmpty): * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse): * loader/cache/CachedResource.cpp: (WebCore::shouldCacheSchemeIndefinitely): (WebCore::CachedResource::freshnessLifetime): * page/Location.cpp: (WebCore::Location::protocol): (WebCore::Location::host): (WebCore::Location::port): * page/Page.cpp: (WebCore::Page::userStyleSheetLocationChanged): * page/SecurityOrigin.cpp: (WebCore::shouldTreatAsUniqueOrigin): (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::isSecure): (WebCore::SecurityOrigin::canDisplay): (WebCore::SecurityOrigin::toRawString): (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::databaseIdentifier): * page/SecurityOrigin.h: (WebCore::SecurityOrigin::port): * page/SecurityOriginData.cpp: (WebCore::SecurityOriginData::debugString): * page/SecurityOriginData.h: (): Deleted. * page/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash): * page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::allowChildFrameFromSource): (WebCore::ContentSecurityPolicy::allowResourceFromSource): (WebCore::ContentSecurityPolicy::allowConnectToSource): (WebCore::ContentSecurityPolicy::allowBaseURI): (WebCore::stripURLForUseInReport): (WebCore::ContentSecurityPolicy::upgradeInsecureRequestIfNeeded): * page/csp/ContentSecurityPolicySource.cpp: (WebCore::ContentSecurityPolicySource::ContentSecurityPolicySource): (WebCore::ContentSecurityPolicySource::portMatches): * page/csp/ContentSecurityPolicySource.h: * page/csp/ContentSecurityPolicySourceList.cpp: (WebCore::ContentSecurityPolicySourceList::parse): (WebCore::ContentSecurityPolicySourceList::parseSource): (WebCore::ContentSecurityPolicySourceList::parsePort): * page/csp/ContentSecurityPolicySourceList.h: * platform/SchemeRegistry.h: * platform/URL.cpp: (WebCore::URL::protocol): (WebCore::URL::port): (WebCore::URL::serialize): (WebCore::portAllowed): (WebCore::defaultPortsMap): Deleted. (WebCore::defaultPortForProtocol): Deleted. (WebCore::isDefaultPortForProtocol): Deleted. * platform/URL.h: (WebCore::URL::hasPort): Deleted. * platform/URLParser.cpp: (WebCore::defaultPortForProtocol): (WebCore::isDefaultPortForProtocol): (WebCore::URLParser::parsePort): (WebCore::isDefaultPort): Deleted. * platform/network/CredentialStorage.cpp: (WebCore::originStringFromURL): * platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): (WebCore::ResourceHandle::loadResourceSynchronously): * platform/network/cf/SocketStreamHandleImplCFNet.cpp: (WebCore::SocketStreamHandleImpl::platformClose): (WebCore::SocketStreamHandleImpl::port): * workers/WorkerLocation.cpp: (WebCore::WorkerLocation::protocol): (WebCore::WorkerLocation::host): (WebCore::WorkerLocation::port): Source/WebKit/mac: * WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin port]): Source/WebKit2: * NetworkProcess/mac/NetworkProcessMac.mm: (WebKit::overrideSystemProxies): * Shared/API/APISecurityOrigin.h: (API::SecurityOrigin::create): * Shared/API/APIURL.h: (API::URL::protocol): * Shared/API/c/WKSecurityOriginRef.cpp: (WKSecurityOriginGetPort): * UIProcess/API/Cocoa/WKSecurityOr
[webkit-changes] [207768] trunk/Source/WebCore
Title: [207768] trunk/Source/WebCore
Revision 207768
Author zandober...@gmail.com
Date 2016-10-24 11:24:12 -0700 (Mon, 24 Oct 2016)
Log Message
[CodeGeneratorJS] Support enums for standalone dictionaries
https://bugs.webkit.org/show_bug.cgi?id=163885
Reviewed by Youenn Fablet.
Add support for enumerations in WebIDL files that specify
standalone dictionaries. Implementation of this is pretty
straight-forward and mirrors interface and callback generators
by calling GenerateEnumerations{Header,Implementation}Content()
functions in GenerateDictionary{Header,Implementation}().
In GenerateEnumerationsImplementationContent(), the
NeverDestroyed.h header is added to the implementation includes
since that class is used to hold an array of possible enum
values.
A test enum is added to the TestStandaloneDictionary.idl file
and the baselines are updated to reflect the new capability.
* bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionary):
(GenerateEnumerationsImplementationContent):
(GenerateDictionaryHeader):
(GenerateDictionaryImplementation):
* bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
(WebCore::convertEnumerationToJS):
(WebCore::parseEnumeration):
(WebCore::convertEnumeration):
(WebCore::expectedEnumerationValues):
(WebCore::convertDictionary):
* bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
* bindings/scripts/test/TestStandaloneDictionary.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h
trunk/Source/WebCore/bindings/scripts/test/TestStandaloneDictionary.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (207767 => 207768)
--- trunk/Source/WebCore/ChangeLog 2016-10-24 18:18:09 UTC (rev 207767)
+++ trunk/Source/WebCore/ChangeLog 2016-10-24 18:24:12 UTC (rev 207768)
@@ -1,3 +1,40 @@
+2016-10-24 Zan Dobersek
+
+[CodeGeneratorJS] Support enums for standalone dictionaries
+https://bugs.webkit.org/show_bug.cgi?id=163885
+
+Reviewed by Youenn Fablet.
+
+Add support for enumerations in WebIDL files that specify
+standalone dictionaries. Implementation of this is pretty
+straight-forward and mirrors interface and callback generators
+by calling GenerateEnumerations{Header,Implementation}Content()
+functions in GenerateDictionary{Header,Implementation}().
+
+In GenerateEnumerationsImplementationContent(), the
+NeverDestroyed.h header is added to the implementation includes
+since that class is used to hold an array of possible enum
+values.
+
+A test enum is added to the TestStandaloneDictionary.idl file
+and the baselines are updated to reflect the new capability.
+
+* bindings/scripts/CodeGenerator.pm:
+(ProcessDocument):
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateDictionary):
+(GenerateEnumerationsImplementationContent):
+(GenerateDictionaryHeader):
+(GenerateDictionaryImplementation):
+* bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
+(WebCore::convertEnumerationToJS):
+(WebCore::parseEnumeration):
+(WebCore::convertEnumeration):
+(WebCore::expectedEnumerationValues):
+(WebCore::convertDictionary):
+* bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
+* bindings/scripts/test/TestStandaloneDictionary.idl:
+
2016-10-24 Dave Hyatt
Remove CSSCharsetRule from the CSS OM
Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (207767 => 207768)
--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2016-10-24 18:18:09 UTC (rev 207767)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2016-10-24 18:24:12 UTC (rev 207768)
@@ -216,7 +216,7 @@
# It is possible to have dictionaries in an IDL file without any interface.
unless (@$interfaces) {
foreach my $dictionary (@{$useDocument->dictionaries}) {
-$codeGenerator->GenerateDictionary($dictionary);
+$codeGenerator->GenerateDictionary($dictionary, $useDocument->enumerations);
$codeGenerator->WriteData($dictionary, $useOutputDir, $useOutputHeadersDir);
}
}
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (207767 => 207768)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-10-24 18:18:09 UTC (rev 207767)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-10-24 18:24:12 UTC (rev 207768)
@@ -134,11 +134,11 @@
sub GenerateDictionary
{
-my ($object, $dictionary) = @_;
+my ($object, $dictionary, $enumerations) = @_;
my $className = GetDictionaryClassName($dictionary->name);
-$object->Genera
[webkit-changes] [207767] trunk
Title: [207767] trunk
Revision 207767
Author hy...@apple.com
Date 2016-10-24 11:18:09 -0700 (Mon, 24 Oct 2016)
Log Message
Remove CSSCharsetRule from the CSS OM
https://bugs.webkit.org/show_bug.cgi?id=163891
Reviewed by Darin Adler.
Source/WebCore:
Remove CSSCharsetRule from the CSS OM. All other browser engines have made this
change. This eliminates the weird overloading of isCharsetRule to match both
CSSCharsetRule and StyleRuleCharset (only used by the new parser).
Fix the destroy() method in StyleRuleBase to clean up StyleRuleCharsets created
by the new parser properly.
* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJSNewlyCreated):
* css/CSSCharsetRule.cpp: Removed.
* css/CSSCharsetRule.h: Removed.
* css/CSSCharsetRule.idl: Removed.
* css/CSSPropertySourceData.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::rules):
* css/CSSStyleSheet.h:
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::destroy):
* inspector/InspectorStyleSheet.cpp:
(WebCore::asCSSRuleList):
Source/WebKit/mac:
* DOM/DOMCSSCharsetRule.mm:
(-[DOMCSSCharsetRule encoding]):
LayoutTests:
* fast/dom/Window/resources/window-properties.js:
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:
* fast/encoding/css-charset-default.xhtml:
* fast/encoding/css-charset-dom-expected.txt: Removed.
* fast/encoding/css-charset-dom.html: Removed.
* platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/resources/window-properties.js
trunk/LayoutTests/fast/dom/dom-constructors-expected.txt
trunk/LayoutTests/fast/dom/dom-constructors.html
trunk/LayoutTests/fast/encoding/css-charset-default.xhtml
trunk/LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js
trunk/LayoutTests/http/tests/css/shared-stylesheet-mutation-expected.txt
trunk/LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt
trunk/LayoutTests/platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSCSSRuleCustom.cpp
trunk/Source/WebCore/css/CSSPropertySourceData.h
trunk/Source/WebCore/css/CSSStyleSheet.cpp
trunk/Source/WebCore/css/CSSStyleSheet.h
trunk/Source/WebCore/css/StyleRule.cpp
trunk/Source/WebCore/css/StyleRule.h
trunk/Source/WebCore/css/StyleSheetContents.cpp
trunk/Source/WebCore/css/StyleSheetContents.h
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/DOM/DOMCSSCharsetRule.mm
Removed Paths
trunk/LayoutTests/fast/encoding/css-charset-dom-expected.txt
trunk/LayoutTests/fast/encoding/css-charset-dom.html
trunk/Source/WebCore/css/CSSCharsetRule.cpp
trunk/Source/WebCore/css/CSSCharsetRule.h
trunk/Source/WebCore/css/CSSCharsetRule.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (207766 => 207767)
--- trunk/LayoutTests/ChangeLog 2016-10-24 18:12:01 UTC (rev 207766)
+++ trunk/LayoutTests/ChangeLog 2016-10-24 18:18:09 UTC (rev 207767)
@@ -1,3 +1,18 @@
+2016-10-24 Dave Hyatt
+
+Remove CSSCharsetRule from the CSS OM
+https://bugs.webkit.org/show_bug.cgi?id=163891
+
+Reviewed by Darin Adler.
+
+* fast/dom/Window/resources/window-properties.js:
+* fast/dom/dom-constructors-expected.txt:
+* fast/dom/dom-constructors.html:
+* fast/encoding/css-charset-default.xhtml:
+* fast/encoding/css-charset-dom-expected.txt: Removed.
+* fast/encoding/css-charset-dom.html: Removed.
+* platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
+
2016-10-24 Eric Carlson
[MediaStream] Separate media capture and audio playback muting
Modified: trunk/LayoutTests/fast/dom/Window/resources/window-properties.js (207766 => 207767)
--- trunk/LayoutTests/fast/dom/Window/resources/window-properties.js 2016-10-24 18:12:01 UTC (rev 207766)
+++ trunk/LayoutTests/fast/dom/Window/resources/window-properties.js 2016-10-24 18:18:09 UTC (rev 207767)
@@ -33,7 +33,6 @@
["Attr", "object"],
["CDATASection", "object"],
-["CSSCharsetRule", "object"],
["CSSFontFaceRule", "object"],
["CSSImportRule", "object"],
["CSSMediaRule", "object"],
Modified: trunk/LayoutTests/fast/dom/dom-constructors-expected.txt (207766 => 207767)
--- trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2016-10-24 18:12:01 UTC (rev 207766)
+++ trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2016-10-24 18:18:09 UTC (rev 207767)
@@ -69,7 +69,6 @@
PASS TryAllocate('HTMLElement') is 'exception'
PASS TryAllocate('CanvasRenderingContext2D') is 'exception'
PASS TryAllocate('Counter') is 'exception'
-PASS TryAllocate('CSSCharsetRule') is 'exception'
PASS TryAllocat
[webkit-changes] [207766] trunk/Source/WebCore
Title: [207766] trunk/Source/WebCore
Revision 207766
Author commit-qu...@webkit.org
Date 2016-10-24 11:12:01 -0700 (Mon, 24 Oct 2016)
Log Message
[CodeGeneratorJS] Standalone dictionaries have misplaced build guards
https://bugs.webkit.org/show_bug.cgi?id=163881
Patch by Zan Dobersek on 2016-10-24
Reviewed by Chris Dumez.
Build guards that are generated from the Conditional attribute
on WebIDL dictionary declarations properly guard the relevant
convertDictionary() functions for WebIDL files that also specify
interfaces. But for standalone dictionaries these build guards
should guard the complete header and implementation files, much
like this is done for files that originate from interfaces or
callbacks.
Before this patch, guarding a standalone dictionary resulted in
malformed output because GenerateHeaderContentHeader() and
GenerateImplementationContentHeader() functions both generated
the #if macro that would guard the whole file, but
GenerateDictionary{Header,Implementation}() didn't generate the
closing #endif.
CodeGeneratorJS.pm now passes the conditional string, if any,
to GenerateDictionary{Header,Implementation}Content() functions
in case of a non-standalone dictionary. Otherwise, the
conditional string, if any, is used to guard the complete
header and implementation files.
Generator tests are updated to cover various build guard
combinations on dictionaries in TestObj.idl, and the standalone
dictionary WebIDL file now has a Conditional attribute to check
that the build guards cover complete generated header and
implementation files.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryHeaderContent):
(GenerateDictionariesHeaderContent):
(GenerateDictionaryImplementationContent):
(GenerateDictionariesImplementationContent):
(GenerateDictionaryHeader):
(GenerateDictionaryImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::convertDictionary):
(WebCore::convertDictionary):
(WebCore::convertDictionary):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
* bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestStandaloneDictionary.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/TestStandaloneDictionary.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (207765 => 207766)
--- trunk/Source/WebCore/ChangeLog 2016-10-24 17:53:40 UTC (rev 207765)
+++ trunk/Source/WebCore/ChangeLog 2016-10-24 18:12:01 UTC (rev 207766)
@@ -1,3 +1,54 @@
+2016-10-24 Zan Dobersek
+
+[CodeGeneratorJS] Standalone dictionaries have misplaced build guards
+https://bugs.webkit.org/show_bug.cgi?id=163881
+
+Reviewed by Chris Dumez.
+
+Build guards that are generated from the Conditional attribute
+on WebIDL dictionary declarations properly guard the relevant
+convertDictionary() functions for WebIDL files that also specify
+interfaces. But for standalone dictionaries these build guards
+should guard the complete header and implementation files, much
+like this is done for files that originate from interfaces or
+callbacks.
+
+Before this patch, guarding a standalone dictionary resulted in
+malformed output because GenerateHeaderContentHeader() and
+GenerateImplementationContentHeader() functions both generated
+the #if macro that would guard the whole file, but
+GenerateDictionary{Header,Implementation}() didn't generate the
+closing #endif.
+
+CodeGeneratorJS.pm now passes the conditional string, if any,
+to GenerateDictionary{Header,Implementation}Content() functions
+in case of a non-standalone dictionary. Otherwise, the
+conditional string, if any, is used to guard the complete
+header and implementation files.
+
+Generator tests are updated to cover various build guard
+combinations on dictionaries in TestObj.idl, and the standalone
+dictionary WebIDL file now has a Conditional attribute to check
+that the build guards cover complete generated header and
+implementation files.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateDictionaryHeaderContent):
+(GenerateDictionariesHeaderContent):
+(GenerateDictionaryImplementationContent):
+(GenerateDictionariesImplementationContent):
+(GenerateDictionaryHeader):
+(GenerateDictionaryImplementation):
+* bindings/scripts/test/JS/JSTestObj.cpp:
[webkit-changes] [207765] trunk/Source/JavaScriptCore
Title: [207765] trunk/Source/_javascript_Core
Revision 207765
Author mark@apple.com
Date 2016-10-24 10:53:40 -0700 (Mon, 24 Oct 2016)
Log Message
Dumping of op_negate bytecode is broken.
https://bugs.webkit.org/show_bug.cgi?id=163896
Reviewed by Darin Adler.
It thinks the bytecode consists of only 3 machine words, when it consists of 4.
This is now fixed.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (207764 => 207765)
--- trunk/Source/_javascript_Core/ChangeLog 2016-10-24 17:53:12 UTC (rev 207764)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-10-24 17:53:40 UTC (rev 207765)
@@ -1,3 +1,16 @@
+2016-10-24 Mark Lam
+
+Dumping of op_negate bytecode is broken.
+https://bugs.webkit.org/show_bug.cgi?id=163896
+
+Reviewed by Darin Adler.
+
+It thinks the bytecode consists of only 3 machine words, when it consists of 4.
+This is now fixed.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::dumpBytecode):
+
2016-10-24 Youenn Fablet
Activate WEB_RTC compilation flags for Mac bots
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (207764 => 207765)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2016-10-24 17:53:12 UTC (rev 207764)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2016-10-24 17:53:40 UTC (rev 207765)
@@ -999,6 +999,7 @@
}
case op_negate: {
printUnaryOp(out, exec, location, it, "negate");
+++it; // op_negate has an extra operand for the ArithProfile.
break;
}
case op_add: {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207764] trunk
Title: [207764] trunk Revision 207764 Author eric.carl...@apple.com Date 2016-10-24 10:53:12 -0700 (Mon, 24 Oct 2016) Log Message [MediaStream] Separate media capture and audio playback muting https://bugs.webkit.org/show_bug.cgi?id=163855 Reviewed by Darin Adler. Source/WebCore: Test: fast/mediastream/MediaStream-page-muted.html Change page.muted from a bool to a bitfield so audio and media capture muted are independent. Fix a couple of bugs in the mock media capture device uncovered by new test case. * Modules/mediastream/MediaStream.cpp: (WebCore::MediaStream::pageMutedStateDidChange): page.isMuted -> page.mutedState. * Modules/webaudio/AudioContext.cpp: (WebCore::AudioContext::pageMutedStateDidChange): Ditto. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updateVolume): Ditto. (WebCore::HTMLMediaElement::effectiveMuted): Ditto. * page/MediaProducer.h: Add MutedState enum. * page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setMuted): Take MutedStateFlags instead of bool. m_muted -> m_mutedState. * page/Page.h: * platform/mock/MockRealtimeMediaSource.cpp: (WebCore::MockRealtimeMediaSource::startProducingData): Call setMuted. (WebCore::MockRealtimeMediaSource::stopProducingData): Ditto. * platform/mock/MockRealtimeMediaSource.h: * platform/mock/MockRealtimeVideoSource.cpp: (WebCore::MockRealtimeVideoSource::stopProducingData): Call correct base class method. * testing/Internals.cpp: (WebCore::Internals::setPageMuted): Change parameter from a bool to a string. * testing/Internals.h: * testing/Internals.idl: Source/WebKit2: * Shared/WebPageCreationParameters.h: Change 'muted' from bool to MutedStateFlags. * UIProcess/API/C/WKPage.cpp: Change parameter from bool to WKMediaMutedState. (WKPageSetMuted): * UIProcess/API/C/WKPagePrivate.h: Define WKMediaMutedState. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::setMuted): m_muted -> m_mutedState. (WebKit::WebPageProxy::creationParameters): Ditto. * UIProcess/WebPageProxy.h: * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::isMuted): page.isMuted -> page.mutedState. * WebProcess/WebPage/WebPage.messages.in: Change SetMuted parameter. LayoutTests: * fast/mediastream/MediaStream-page-muted-expected.txt: Added. * fast/mediastream/MediaStream-page-muted.html: Added. * media/video-muted-after-setting-page-muted-state.html: Updated. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/video-muted-after-setting-page-muted-state.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/page/MediaProducer.h trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp trunk/Source/WebCore/platform/mock/MockRealtimeMediaSource.cpp trunk/Source/WebCore/platform/mock/MockRealtimeMediaSource.h trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPageCreationParameters.h trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in Added Paths trunk/LayoutTests/fast/mediastream/MediaStream-page-muted-expected.txt trunk/LayoutTests/fast/mediastream/MediaStream-page-muted.html Diff Modified: trunk/LayoutTests/ChangeLog (207763 => 207764) --- trunk/LayoutTests/ChangeLog 2016-10-24 16:48:54 UTC (rev 207763) +++ trunk/LayoutTests/ChangeLog 2016-10-24 17:53:12 UTC (rev 207764) @@ -1,3 +1,15 @@ +2016-10-24 Eric Carlson + +[MediaStream] Separate media capture and audio playback muting +https://bugs.webkit.org/show_bug.cgi?id=163855 + + +Reviewed by Darin Adler. + +* fast/mediastream/MediaStream-page-muted-expected.txt: Added. +* fast/mediastream/MediaStream-page-muted.html: Added. +* media/video-muted-after-setting-page-muted-state.html: Updated. + 2016-10-24 Youenn Fablet Activate WEB_RTC compilation flags for Mac bots Added: trunk/LayoutTests/fast/mediastream/MediaStream-page-muted-expected.txt (0 => 207764) --- trunk/LayoutTests/fast/mediastream/MediaStream-page-muted-expected.txt (rev 0) +++ trunk/LayoutTests/fast/mediastream/MediaStream-page-muted-expected.txt 2016-10-24 17:53:12 UTC (rev 207764) @@ -0,0 +1,29 @@ +Test enabling/disabling mock media capture devices + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + + +*** Mock capture devices should
[webkit-changes] [207763] trunk/Source/WebCore
Title: [207763] trunk/Source/WebCore Revision 207763 Author da...@apple.com Date 2016-10-24 09:48:54 -0700 (Mon, 24 Oct 2016) Log Message Try to fix Windows build. * bindings/js/JSWebGL2RenderingContextCustom.cpp: Rearranged includes so they are inside the conditional as they should be. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (207762 => 207763) --- trunk/Source/WebCore/ChangeLog 2016-10-24 16:25:02 UTC (rev 207762) +++ trunk/Source/WebCore/ChangeLog 2016-10-24 16:48:54 UTC (rev 207763) @@ -1,3 +1,10 @@ +2016-10-24 Darin Adler + +Try to fix Windows build. + +* bindings/js/JSWebGL2RenderingContextCustom.cpp: Rearranged includes +so they are inside the conditional as they should be. + 2016-10-24 Youenn Fablet Activate WEB_RTC compilation flags for Mac bots Modified: trunk/Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp (207762 => 207763) --- trunk/Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp 2016-10-24 16:25:02 UTC (rev 207762) +++ trunk/Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp 2016-10-24 16:48:54 UTC (rev 207763) @@ -24,14 +24,13 @@ */ #include "config.h" -#include "JSWebGL2RenderingContext.h" #if ENABLE(WEBGL) && ENABLE(WEBGL2) +#include "JSWebGL2RenderingContext.h" +#include "NotImplemented.h" #include #include -#include "NotImplemented.h" -#include "WebGL2RenderingContext.h" using namespace JSC; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207762] trunk
Title: [207762] trunk
Revision 207762
Author commit-qu...@webkit.org
Date 2016-10-24 09:25:02 -0700 (Mon, 24 Oct 2016)
Log Message
Activate WEB_RTC compilation flags for Mac bots
https://bugs.webkit.org/show_bug.cgi?id=163886
Patch by Youenn Fablet on 2016-10-24
Reviewed by Eric Carlson.
Source/_javascript_Core:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Covered by existing tests.
Fixing compilation errors due to missing WEBCORE_EXPORT, missing method and missing override keywords.
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* Modules/mediastream/MediaEndpointPeerConnection.h:
* Modules/mediastream/RTCPeerConnection.h:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/SDPProcessor.cpp:
(WebCore::SDPProcessor::generate):
(WebCore::SDPProcessor::parse):
* WebCore.xcodeproj/project.pbxproj:
* platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:
(WebCore::MockRealtimeVideoSource::createMuted):
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
Tools:
* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
LayoutTests:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
Diff
Modified: trunk/LayoutTests/ChangeLog (207761 => 207762)
--- trunk/LayoutTests/ChangeLog 2016-10-24 16:24:09 UTC (rev 207761)
+++ trunk/LayoutTests/ChangeLog 2016-10-24 16:25:02 UTC (rev 207762)
@@ -1,3 +1,14 @@
+2016-10-24 Youenn Fablet
+
+Activate WEB_RTC compilation flags for Mac bots
+https://bugs.webkit.org/show_bug.cgi?id=163886
+
+Reviewed by Eric Carlson.
+
+* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac/js/dom/global-constructors-attributes-expected.txt:
+
2016-10-24 Brady Eidson
IndexedDB 2.0: Support IDBIndex name assignment.
Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (207761 => 207762)
--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2016-10-24 16:24:09 UTC (rev 207761)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2016-10-24 16:25:02 UTC (rev 207762)
@@ -1018,6 +1018,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').value is MediaStreamEvent
+PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamTrack').value is MediaStreamTrack
PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamTrack').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamTrack').hasOwnProperty('set') is false
@@ -1213,6 +1218,41 @@
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').enumerable is false
PASS Object.getOwnPr
[webkit-changes] [207761] trunk
Title: [207761] trunk Revision 207761 Author beid...@apple.com Date 2016-10-24 09:24:09 -0700 (Mon, 24 Oct 2016) Log Message IndexedDB 2.0: Support IDBIndex name assignment. and https://bugs.webkit.org/show_bug.cgi?id=163805 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/IndexedDB/idbindex-rename-errors-expected.txt: * web-platform-tests/IndexedDB/idbindex-rename-expected.txt: Source/WebCore: Tests: storage/indexeddb/modern/index-rename-1-private.html storage/indexeddb/modern/index-rename-1.html Touches a *lot* of code sites, but none of them are particularly interesting. They are all just getting the new name spread out to all of the various objects that need it. * Modules/indexeddb/IDBDatabase.cpp: (WebCore::IDBDatabase::renameIndex): * Modules/indexeddb/IDBDatabase.h: * Modules/indexeddb/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex): (WebCore::IDBIndex::setName): (WebCore::IDBIndex::rollbackInfoForVersionChangeAbort): * Modules/indexeddb/IDBIndex.h: * Modules/indexeddb/IDBIndex.idl: * Modules/indexeddb/IDBObjectStore.cpp: (WebCore::IDBObjectStore::rollbackForVersionChangeAbort): (WebCore::IDBObjectStore::renameReferencedIndex): (WebCore::IDBObjectStore::rollbackInfoForVersionChangeAbort): Deleted. * Modules/indexeddb/IDBObjectStore.h: * Modules/indexeddb/IDBTransaction.cpp: (WebCore::IDBTransaction::internalAbort): (WebCore::IDBTransaction::renameIndex): (WebCore::IDBTransaction::renameIndexOnServer): (WebCore::IDBTransaction::didRenameIndexOnServer): * Modules/indexeddb/IDBTransaction.h: * Modules/indexeddb/client/IDBConnectionProxy.cpp: (WebCore::IDBClient::IDBConnectionProxy::renameIndex): * Modules/indexeddb/client/IDBConnectionProxy.h: * Modules/indexeddb/client/IDBConnectionToServer.cpp: (WebCore::IDBClient::IDBConnectionToServer::renameIndex): (WebCore::IDBClient::IDBConnectionToServer::didRenameIndex): * Modules/indexeddb/client/IDBConnectionToServer.h: * Modules/indexeddb/client/IDBConnectionToServerDelegate.h: * Modules/indexeddb/client/TransactionOperation.h: (WebCore::IDBClient::createTransactionOperation): * Modules/indexeddb/server/IDBBackingStore.h: * Modules/indexeddb/server/IDBConnectionToClient.cpp: (WebCore::IDBServer::IDBConnectionToClient::didRenameIndex): * Modules/indexeddb/server/IDBConnectionToClient.h: * Modules/indexeddb/server/IDBConnectionToClientDelegate.h: * Modules/indexeddb/server/IDBServer.cpp: (WebCore::IDBServer::IDBServer::renameIndex): * Modules/indexeddb/server/IDBServer.h: * Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp: (WebCore::IDBServer::MemoryBackingStoreTransaction::indexRenamed): (WebCore::IDBServer::MemoryBackingStoreTransaction::abort): * Modules/indexeddb/server/MemoryBackingStoreTransaction.h: * Modules/indexeddb/server/MemoryIDBBackingStore.cpp: (WebCore::IDBServer::MemoryIDBBackingStore::renameIndex): * Modules/indexeddb/server/MemoryIDBBackingStore.h: * Modules/indexeddb/server/MemoryIndex.h: (WebCore::IDBServer::MemoryIndex::rename): * Modules/indexeddb/server/MemoryObjectStore.cpp: (WebCore::IDBServer::MemoryObjectStore::renameIndex): * Modules/indexeddb/server/MemoryObjectStore.h: * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: (WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex): * Modules/indexeddb/server/SQLiteIDBBackingStore.h: * Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::renameIndex): (WebCore::IDBServer::UniqueIDBDatabase::performRenameIndex): (WebCore::IDBServer::UniqueIDBDatabase::didPerformRenameIndex): * Modules/indexeddb/server/UniqueIDBDatabase.h: * Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp: (WebCore::IDBServer::UniqueIDBDatabaseConnection::didRenameIndex): * Modules/indexeddb/server/UniqueIDBDatabaseConnection.h: * Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp: (WebCore::IDBServer::UniqueIDBDatabaseTransaction::renameIndex): * Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h: * Modules/indexeddb/shared/IDBIndexInfo.h: (WebCore::IDBIndexInfo::rename): * Modules/indexeddb/shared/IDBObjectStoreInfo.cpp: (WebCore::IDBObjectStoreInfo::infoForExistingIndex): * Modules/indexeddb/shared/IDBObjectStoreInfo.h: * Modules/indexeddb/shared/IDBResultData.cpp: (WebCore::IDBResultData::renameIndexSuccess): * Modules/indexeddb/shared/IDBResultData.h: * Modules/indexeddb/shared/InProcessIDBServer.cpp: (WebCore::InProcessIDBServer::didRenameIndex): (WebCore::InProcessIDBServer::renameIndex): * Modules/indexeddb/shared/InProcessIDBServer.h: Source/WebKit2: * DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp: (WebKit::WebIDBConnectionToClient::didRenameIndex): (WebKit::WebIDBConnectionToClient::renameIndex): * DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h: * DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in: * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp: (WebKit::WebIDBConnectionToServer::renameIndex): (WebKit::WebIDBConnectionToServer::di
[webkit-changes] [207760] trunk/Tools
Title: [207760] trunk/Tools
Revision 207760
Author wenson_hs...@apple.com
Date 2016-10-24 08:53:22 -0700 (Mon, 24 Oct 2016)
Log Message
Unreviewed, add myself as a WebKit reviewer
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (207759 => 207760)
--- trunk/Tools/ChangeLog 2016-10-24 15:07:27 UTC (rev 207759)
+++ trunk/Tools/ChangeLog 2016-10-24 15:53:22 UTC (rev 207760)
@@ -1,3 +1,9 @@
+2016-10-24 Wenson Hsieh
+
+Unreviewed, add myself as a WebKit reviewer
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2016-10-22 Dan Bernstein
Improve MiniBrowser window titles for URLs without paths and with no title
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (207759 => 207760)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2016-10-24 15:07:27 UTC (rev 207759)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2016-10-24 15:53:22 UTC (rev 207760)
@@ -5493,7 +5493,7 @@
"nicks" : [
"whsieh"
],
- "status" : "committer"
+ "status" : "reviewer"
},
"William Siegrist" : {
"emails" : [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207759] trunk/Source/WebCore
Title: [207759] trunk/Source/WebCore
Revision 207759
Author hy...@apple.com
Date 2016-10-24 08:07:27 -0700 (Mon, 24 Oct 2016)
Log Message
[CSS Parser] Fix -webkit-box-reflect parsing
https://bugs.webkit.org/show_bug.cgi?id=163890
Reviewed by Zalan Bujtas.
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeReflect):
Do a WTFMove on the mask instead of a .releaseNonNull(), since mask can be a nullptr.
Exactly matches the old parser.
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeValue):
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeNumber):
(WebCore::CSSPropertyParserHelpers::consumeInteger):
(WebCore::CSSPropertyParserHelpers::consumeNumber):
(WebCore::CSSPropertyParserHelpers::consumeLength):
(WebCore::CSSPropertyParserHelpers::consumePercent):
(WebCore::CSSPropertyParserHelpers::consumeAngle):
(WebCore::CSSPropertyParserHelpers::consumeTime):
(WebCore::CSSPropertyParserHelpers::consumeUrl):
(WebCore::CSSPropertyParserHelpers::consumeColor):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradientPoint):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradientColorStop):
(WebCore::CSSPropertyParserHelpers::consumeCrossFade):
(WebCore::CSSPropertyParserHelpers::consumeImageSet):
Clean up all instances of CSSPrimitiveValue::create to use the CSSValuePool.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (207758 => 207759)
--- trunk/Source/WebCore/ChangeLog 2016-10-24 14:58:05 UTC (rev 207758)
+++ trunk/Source/WebCore/ChangeLog 2016-10-24 15:07:27 UTC (rev 207759)
@@ -1,3 +1,32 @@
+2016-10-24 Dave Hyatt
+
+[CSS Parser] Fix -webkit-box-reflect parsing
+https://bugs.webkit.org/show_bug.cgi?id=163890
+
+Reviewed by Zalan Bujtas.
+
+* css/parser/CSSPropertyParser.cpp:
+(WebCore::consumeReflect):
+Do a WTFMove on the mask instead of a .releaseNonNull(), since mask can be a nullptr.
+Exactly matches the old parser.
+
+* css/parser/CSSPropertyParserHelpers.cpp:
+(WebCore::CSSPropertyParserHelpers::CalcParser::consumeValue):
+(WebCore::CSSPropertyParserHelpers::CalcParser::consumeNumber):
+(WebCore::CSSPropertyParserHelpers::consumeInteger):
+(WebCore::CSSPropertyParserHelpers::consumeNumber):
+(WebCore::CSSPropertyParserHelpers::consumeLength):
+(WebCore::CSSPropertyParserHelpers::consumePercent):
+(WebCore::CSSPropertyParserHelpers::consumeAngle):
+(WebCore::CSSPropertyParserHelpers::consumeTime):
+(WebCore::CSSPropertyParserHelpers::consumeUrl):
+(WebCore::CSSPropertyParserHelpers::consumeColor):
+(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradientPoint):
+(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradientColorStop):
+(WebCore::CSSPropertyParserHelpers::consumeCrossFade):
+(WebCore::CSSPropertyParserHelpers::consumeImageSet):
+Clean up all instances of CSSPrimitiveValue::create to use the CSSValuePool.
+
2016-10-21 Antoine Quint
[Modern Media Controls] Concatenate JS and CSS files into a single JS and CSS resources
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (207758 => 207759)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2016-10-24 14:58:05 UTC (rev 207758)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2016-10-24 15:07:27 UTC (rev 207759)
@@ -2445,7 +2445,7 @@
RefPtr offset;
if (range.atEnd())
-offset = CSSPrimitiveValue::create(0, CSSPrimitiveValue::UnitTypes::CSS_PX);
+offset = CSSValuePool::singleton().createValue(0, CSSPrimitiveValue::UnitTypes::CSS_PX);
else {
offset = consumeLengthOrPercent(range, context.mode, ValueRangeAll, UnitlessQuirk::Forbid);
if (!offset)
@@ -2458,7 +2458,7 @@
if (!mask)
return nullptr;
}
-return CSSReflectValue::create(direction.releaseNonNull(), offset.releaseNonNull(), mask.releaseNonNull());
+return CSSReflectValue::create(direction.releaseNonNull(), offset.releaseNonNull(), WTFMove(mask));
}
#if ENABLE(CSS_IMAGE_ORIENTATION)
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (207758 => 207759)
--- trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp 2016-10-24 14:58:05 UTC (rev 207758)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp 2016-10-24 15:07:27 UTC (rev 207759)
@@ -90,7 +90,7 @@
if (!m_calcValue)
return nullptr;
m_sourceRange = m_range;
-return CSSPrimitiveValue::create(m_calcValue.release());
+return CSSValuePool::singleton().createValue(m_calcValue.release());
}
RefPtr consumeNumber()
{
@@ -98,7 +98,7 @@
return nullptr;
m_sourceRange = m_ra
[webkit-changes] [207758] trunk/Source/WebCore
Title: [207758] trunk/Source/WebCore
Revision 207758
Author grao...@webkit.org
Date 2016-10-24 07:58:05 -0700 (Mon, 24 Oct 2016)
Log Message
[Modern Media Controls] Concatenate JS and CSS files into a single JS and CSS resources
https://bugs.webkit.org/show_bug.cgi?id=163785
Reviewed by Darin Adler.
Concatenate CSS and JS resources for modern media controls into single JS and CSS files
during build and load these single resources alone at runtime.
* Modules/modern-media-controls/js-files: Added.
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::mediaControlsStyleSheet):
(WebCore::RenderThemeMac::mediaControlsScript):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/RenderThemeMac.mm
Added Paths
trunk/Source/WebCore/Modules/modern-media-controls/js-files
Diff
Modified: trunk/Source/WebCore/ChangeLog (207757 => 207758)
--- trunk/Source/WebCore/ChangeLog 2016-10-24 14:39:40 UTC (rev 207757)
+++ trunk/Source/WebCore/ChangeLog 2016-10-24 14:58:05 UTC (rev 207758)
@@ -1,3 +1,20 @@
+2016-10-21 Antoine Quint
+
+[Modern Media Controls] Concatenate JS and CSS files into a single JS and CSS resources
+https://bugs.webkit.org/show_bug.cgi?id=163785
+
+
+Reviewed by Darin Adler.
+
+Concatenate CSS and JS resources for modern media controls into single JS and CSS files
+during build and load these single resources alone at runtime.
+
+* Modules/modern-media-controls/js-files: Added.
+* WebCore.xcodeproj/project.pbxproj:
+* rendering/RenderThemeMac.mm:
+(WebCore::RenderThemeMac::mediaControlsStyleSheet):
+(WebCore::RenderThemeMac::mediaControlsScript):
+
2016-10-24 Dave Hyatt
[CSS Parser] Unprefix -webkit-writing-mode
Added: trunk/Source/WebCore/Modules/modern-media-controls/js-files (0 => 207758)
--- trunk/Source/WebCore/Modules/modern-media-controls/js-files (rev 0)
+++ trunk/Source/WebCore/Modules/modern-media-controls/js-files 2016-10-24 14:58:05 UTC (rev 207758)
@@ -0,0 +1,34 @@
+controls/scheduler.js
+controls/layout-node.js
+controls/layout-item.js
+controls/icon-service.js
+controls/time-control.js
+controls/time-label.js
+controls/slider.js
+controls/volume-slider.js
+controls/scrubber.js
+controls/button.js
+controls/start-button.js
+controls/icon-button.js
+controls/play-pause-button.js
+controls/skip-back-button.js
+controls/mute-button.js
+controls/airplay-button.js
+controls/pip-button.js
+controls/tracks-button.js
+controls/fullscreen-button.js
+controls/aspect-ratio-button.js
+controls/rewind-button.js
+controls/forward-button.js
+controls/media-controls.js
+controls/macos-media-controls.js
+controls/macos-inline-media-controls.js
+controls/buttons-container.js
+controls/placard.js
+controls/airplay-placard.js
+controls/pip-placard.js
+media/media-controller-support.js
+media/start-support.js
+media/mute-support.js
+media/media-controller.js
+main.js
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (207757 => 207758)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-10-24 14:39:40 UTC (rev 207757)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-10-24 14:58:05 UTC (rev 207758)
@@ -28000,7 +28000,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "rsync -aq --exclude \".svn\" --exclude \".DS_Store\" --exclude \"tests\" \"$SRCROOT/Modules/modern-media-controls\" \"$BUILT_PRODUCTS_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH\"";
+ shellScript = "rsync -aq --exclude \".svn\" --exclude \".DS_Store\" \"$SRCROOT/Modules/modern-media-controls/images\" \"$BUILT_PRODUCTS_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH/modern-media-controls\"\ncd \"$SRCROOT/Modules/modern-media-controls\"\ncat controls/*.css > \"$BUILT_PRODUCTS_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH/modern-media-controls/modern-media-controls.css\"\ncat `cat js-files` > \"$BUILT_PRODUCTS_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH/modern-media-controls/modern-media-controls.js\"";
};
DD041FBD09D9DDBE0010AF2A /* Generate Derived Sources */ = {
isa = PBXShellScriptBuildPhase;
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (207757 => 207758)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2016-10-24 14:39:40 UTC (rev 207757)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2016-10-24 14:58:05 UTC (rev 207758)
@@ -236,11 +236,9 @@
#if ENABLE(MEDIA_CONTROLS_SCRIPT)
if (m_mediaControlsStyleSheet.isEmpty()) {
StringBuilder styleSheetBuilder;
-if (RuntimeEnabledFeatures::sharedFeatures().modernMediaControlsEnabled()) {
-NSArray *paths = @[@"airplay-button", @"button", @"buttons-container", @"icon-button", @"macos-inline-media-controls", @"media-controls", @"placard", @"scrubber", @"slider", @"start-button", @"time-label", @"volume-sl
[webkit-changes] [207757] trunk
Title: [207757] trunk Revision 207757 Author hy...@apple.com Date 2016-10-24 07:39:40 -0700 (Mon, 24 Oct 2016) Log Message [CSS Parser] Unprefix -webkit-writing-mode https://bugs.webkit.org/show_bug.cgi?id=163870 Reviewed by Zalan Bujtas. Source/WebCore: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Change -webkit-writing mode to writing-mode. * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator WritingMode): (WebCore::CSSPrimitiveValue::operator SVGWritingMode): Deleted. Eliminate the SVGWritingMode converters. Add support for the unique SVG-specific values to the WritingMode converters. * css/CSSPropertyNames.in: Alias -webkit-writing-mode to writing-mode. Move writing-mode up to be high priority like -webkit-writing mode was. Alias -epub-writing-mode to writing-mode instead of to -webkit-writing-mode. * css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::svgPropertyValue): Remove writing-mode from SVG computed style, since the base CSSComputedStyleDeclaration handles it. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueWritingMode): (WebCore::StyleBuilderCustom::applyValueWebkitWritingMode): Deleted. Renamed applyValueWebkitWritingMode to applyValueWritingMode. Removed the SVG code, since the underlying converter for WritingMode now handles those values. * css/StyleResolver.cpp: (WebCore::extractDirectionAndWritingMode): Rename -webkit-writing-mode to writing-mode. * css/parser/CSSParser.cpp: (WebCore::isValidKeywordPropertyAndValue): Eliminate -webkit-writing-mode and make sure writing-mode handles both the SVG values and the normal values. * css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): (WebCore::CSSParserFastPaths::isKeywordPropertyID): Same deal here. * html/track/TextTrackCueGeneric.cpp: (WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): * html/track/VTTCue.cpp: (WebCore::VTTCueBox::applyCSSProperties): Cue stuff was setting -webkit-writing-mode, so make it set writing-mode instead now. * rendering/RenderLineBreak.cpp: (WebCore::RenderLineBreak::collectSelectionRects): * rendering/RenderText.cpp: (WebCore::RenderText::collectSelectionRects): Switch the SVG-specific code here over to accessing the RenderStyle writing-mode and not the SVG-specific one. * rendering/style/RenderStyle.h: (WebCore::RenderStyle::isVerticalWritingMode): Add a helper function for asking if something is vertical writing mode. * rendering/style/SVGRenderStyle.cpp: * rendering/style/SVGRenderStyle.h: * rendering/style/SVGRenderStyleDefs.h: (WebCore::SVGRenderStyle::diff): Remove the SVG writing mode code. * rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): Make sure to force SVG font descriptions to be horizontal, since SVG controls its own glyph orientation. * rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGInlineTextBox): * rendering/svg/SVGTextChunk.cpp: (WebCore::SVGTextChunk::SVGTextChunk): * rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::layoutInlineTextBox): * rendering/svg/SVGTextQuery.cpp: (WebCore::SVGTextQuery::executeQuery): Changed to access the RenderStyle writing mode instead of the SVG-specific one. LayoutTests: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: * platform/mac/svg/text/text-align-06-b-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.txt trunk/LayoutTests/platform/mac/svg/text/text-align-06-b-expected.txt trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/StyleBuilderCustom.h trunk/Source/WebCore/css/StyleResolver.cpp trunk/Source/WebCore/css/parser/CSSParser.cpp trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp trunk/Source/WebCore/html/track/VTTCue.cpp trunk/Source/WebCore/rendering/RenderLineBreak.cpp trunk/Source/WebCore/rendering/RenderText.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/SVGRenderStyle.cpp trunk/Source/WebCore/rendering/style/SVGRenderStyle.h trunk/Source/WebCore/rendering/style/SVGRenderStyleDefs.h trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp trunk/Source/WebCore/rendering/svg/SVGRend
[webkit-changes] [207756] trunk/LayoutTests
Title: [207756] trunk/LayoutTests Revision 207756 Author commit-qu...@webkit.org Date 2016-10-24 04:50:29 -0700 (Mon, 24 Oct 2016) Log Message svg/as-image/svg-image-with-data-uri-use-data-uri.svg is flaky after r207754 https://bugs.webkit.org/show_bug.cgi?id=163887 Unreviewed. Patch by Youenn Fablet on 2016-10-24 * TestExpectations: Marking svg/as-image/svg-image-with-data-uri-use-data-uri.svg as crashing. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (207755 => 207756) --- trunk/LayoutTests/ChangeLog 2016-10-24 09:50:47 UTC (rev 207755) +++ trunk/LayoutTests/ChangeLog 2016-10-24 11:50:29 UTC (rev 207756) @@ -1,3 +1,12 @@ +2016-10-24 Youenn Fablet + +svg/as-image/svg-image-with-data-uri-use-data-uri.svg is flaky after r207754 +https://bugs.webkit.org/show_bug.cgi?id=163887 + +Unreviewed. + +* TestExpectations: Marking svg/as-image/svg-image-with-data-uri-use-data-uri.svg as crashing. + 2016-10-23 Antti Koivisto Avoid unnecessary full style resolution in getComputedStyle for non-inherited properties Modified: trunk/LayoutTests/TestExpectations (207755 => 207756) --- trunk/LayoutTests/TestExpectations 2016-10-24 09:50:47 UTC (rev 207755) +++ trunk/LayoutTests/TestExpectations 2016-10-24 11:50:29 UTC (rev 207756) @@ -993,3 +993,5 @@ imported/blink/http/tests/security/shape-image-cors-port.html [ ImageOnlyFailure ] webkit.org/b/163636 media/modern-media-controls/media-controller/media-controller-resize.html [ Pass Timeout ] + +webkit.org/b/163887 svg/as-image/svg-image-with-data-uri-use-data-uri.svg [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [207755] trunk
Title: [207755] trunk Revision 207755 Author an...@apple.com Date 2016-10-24 02:50:47 -0700 (Mon, 24 Oct 2016) Log Message Avoid unnecessary full style resolution in getComputedStyle for non-inherited properties https://bugs.webkit.org/show_bug.cgi?id=163875 Reviewed by Andreas Kling. Source/WebCore: Test: fast/css/getComputedStyle/getComputedStyle-style-resolution.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::hasValidStyleForProperty): For non-inherited properties we don't need to update style even if some ancestor style is invalid as long as explicit 'inherit' is not being used. We still need to update if we find out that the whole subtree we are in is invalid. (WebCore::updateStyleIfNeededForProperty): Pass the property. (WebCore::ComputedStyleExtractor::customPropertyValue): (WebCore::ComputedStyleExtractor::propertyValue): (WebCore::CSSComputedStyleDeclaration::length): (WebCore::elementOrItsAncestorNeedsStyleRecalc): Deleted. (WebCore::updateStyleIfNeededForElement): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::colorFromPrimitiveValue): Mark style as using explicit inheritance if 'currentcolor' value is used. LayoutTests: * fast/css/getComputedStyle/getComputedStyle-style-resolution-expected.txt: Added. * fast/css/getComputedStyle/getComputedStyle-style-resolution.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/StyleResolver.cpp Added Paths trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution.html Diff Modified: trunk/LayoutTests/ChangeLog (207754 => 207755) --- trunk/LayoutTests/ChangeLog 2016-10-24 08:04:20 UTC (rev 207754) +++ trunk/LayoutTests/ChangeLog 2016-10-24 09:50:47 UTC (rev 207755) @@ -1,3 +1,13 @@ +2016-10-23 Antti Koivisto + +Avoid unnecessary full style resolution in getComputedStyle for non-inherited properties +https://bugs.webkit.org/show_bug.cgi?id=163875 + +Reviewed by Andreas Kling. + +* fast/css/getComputedStyle/getComputedStyle-style-resolution-expected.txt: Added. +* fast/css/getComputedStyle/getComputedStyle-style-resolution.html: Added. + 2016-10-24 Youenn Fablet ASSERTION FAILED: canvas()->securityOrigin()->toString() == cachedImage.origin()->toString() Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution-expected.txt (0 => 207755) --- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution-expected.txt (rev 0) +++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution-expected.txt 2016-10-24 09:50:47 UTC (rev 207755) @@ -0,0 +1,7 @@ +Text + +PASS No style resolution when style is valid. +PASS No style resolution when parent style is invalid and querying non-inherited property. +PASS This still works with 'inherit' +PASS Explicit 'inherit' chain triggers style resolution + Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution.html (0 => 207755) --- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution.html (rev 0) +++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution.html 2016-10-24 09:50:47 UTC (rev 207755) @@ -0,0 +1,45 @@ + ++ + +Text +