[webkit-changes] [210916] trunk/Tools
Title: [210916] trunk/Tools
Revision 210916
Author timo...@apple.com
Date 2017-01-19 00:04:55 -0800 (Thu, 19 Jan 2017)
Log Message
Remove my old email address from contributors.json and watchlist.
Patch by Timothy Hatcher on 2017-01-19
* Scripts/validate-committer-lists:
(CommitterListFromGit): Change the mapping to the correct email.
* Scripts/webkitpy/common/config/contributors.json:
* Scripts/webkitpy/common/config/watchlist:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/validate-committer-lists
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
trunk/Tools/Scripts/webkitpy/common/config/watchlist
Diff
Modified: trunk/Tools/ChangeLog (210915 => 210916)
--- trunk/Tools/ChangeLog 2017-01-19 07:45:30 UTC (rev 210915)
+++ trunk/Tools/ChangeLog 2017-01-19 08:04:55 UTC (rev 210916)
@@ -1,3 +1,12 @@
+2017-01-19 Timothy Hatcher
+
+Remove my old email address from contributors.json and watchlist.
+
+* Scripts/validate-committer-lists:
+(CommitterListFromGit): Change the mapping to the correct email.
+* Scripts/webkitpy/common/config/contributors.json:
+* Scripts/webkitpy/common/config/watchlist:
+
2017-01-18 Ryan Haddad
Unreviewed, rolling out r210848.
Modified: trunk/Tools/Scripts/validate-committer-lists (210915 => 210916)
--- trunk/Tools/Scripts/validate-committer-lists 2017-01-19 07:45:30 UTC (rev 210915)
+++ trunk/Tools/Scripts/validate-committer-lists 2017-01-19 08:04:55 UTC (rev 210916)
@@ -148,7 +148,7 @@
'rjw' : 'r...@apple.com',
'seangies' : 'seang...@apple.com', # Sean Gies?, only 5 commits: r16600, r16592, r16511, r16489, r16484
'sheridan' : 'sheri...@apple.com', # Shelly Sheridan
-'thatcher' : 'timo...@apple.com',
+'thatcher' : 'timo...@hatcher.name',
'tomernic' : 't...@apple.com',
'trey' : 't...@usa.net',
'tristan' : 'tris...@apple.com',
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (210915 => 210916)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2017-01-19 07:45:30 UTC (rev 210915)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2017-01-19 08:04:55 UTC (rev 210916)
@@ -5261,8 +5261,8 @@
"Tim Hatcher"
],
"emails" : [
- "timo...@apple.com",
- "timo...@hatcher.name"
+ "timo...@hatcher.name",
+ "thatc...@tesla.com"
],
"expertise" : "WebKit API (Mac), WebKit Web Site, Developer Tools (Web Inspector, _javascript_ Debugger)",
"nicks" : [
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (210915 => 210916)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2017-01-19 07:45:30 UTC (rev 210915)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2017-01-19 08:04:55 UTC (rev 210916)
@@ -10,9 +10,6 @@
#
{
"DEFINITIONS": {
-"AppleMacPublicApi": {
-"filename": r"Source/WebCore/bindings/objc/PublicDOMInterfaces.h"
-},
"Forms": {
"filename": r"Source/WebCore/html/HTML(DataList|FieldSet|Input|Keygen|Label|Legend|OptGroup|Option|Output|Select|TextArea)Element\."
r"|Source/WebCore/html/.*Form[A-Z].*\."
@@ -353,7 +350,6 @@
"Accessibility": [ "cfleiz...@apple.com", "dmazz...@google.com", "apinhe...@igalia.com", "jdi...@igalia.com", "aboxh...@chromium.org", "ma...@webkit.org", "samuel_wh...@apple.com", "jcr...@apple.com" ],
"Animation" : [ "simon.fra...@apple.com", "d...@apple.com", "dstockw...@chromium.org" ],
"MotionMark" : [ "sabouhall...@apple.com" ],
-"AppleMacPublicApi": [ "timo...@apple.com" ],
"BindingsScripts": [ "cdu...@apple.com" ],
"CMake": [ "rak...@webkit.org", "gyuyoung@webkit.org", "ryuan.c...@gmail.com", "sergio.corr...@openbossa.org", "mcatanz...@igalia.com" ],
"CoordinatedGraphics" : [ "n...@webkit.org", "z...@webkit.org", "cmarc...@webkit.org", "l...@webkit.org", "ryuan.c...@gmail.com", "sergio.corr...@openbossa.org", "gyuyoung@webkit.org" ],
@@ -405,7 +401,7 @@
"WTF": [ "benja...@webkit.org", "cmarc...@webkit.org", "cdu...@apple.com", "dba...@webkit.org" ],
"WebGL": [ "d...@apple.com", "kondapallykal...@gmail.com", "grao...@webkit.org" ],
"WebIDL": [ "esprehn+aut...@chromium.org", "cdu...@apple.com", "kondapallykal...@gmail.com" ],
-"WebInspectorAPI": [ "timo...@apple.com", "joep...@webkit.org" ],
+"WebInspectorAPI": [ "joep...@webkit.org" ],
"WebInspectorGenerator": [ "bb...@apple.com", "joep...@webkit.org" ],
"WebInspectorUIImages": [ "ago...@igalia.com" ],
"WebReplayGenerator": [ "bb...@apple.com" ],
@@ -417,10 +413,6 @@
"webkitpy": [ "gl...@skynav.com" ],
},
"MESSAGE_RULES": {
-"AppleMacPublicApi": [ "Please wait for approval from timo...@apple.com (or another member "
- "of the Apple S
[webkit-changes] [210917] trunk/Tools
Title: [210917] trunk/Tools Revision 210917 Author timo...@apple.com Date 2017-01-19 00:08:38 -0800 (Thu, 19 Jan 2017) Log Message Add back my old email address so old commits will still match it. Patch by Timothy Hatcher on 2017-01-19 * Scripts/webkitpy/common/config/contributors.json: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/contributors.json Diff Modified: trunk/Tools/ChangeLog (210916 => 210917) --- trunk/Tools/ChangeLog 2017-01-19 08:04:55 UTC (rev 210916) +++ trunk/Tools/ChangeLog 2017-01-19 08:08:38 UTC (rev 210917) @@ -1,5 +1,11 @@ 2017-01-19 Timothy Hatcher +Add back my old email address so old commits will still match it. + +* Scripts/webkitpy/common/config/contributors.json: + +2017-01-19 Timothy Hatcher + Remove my old email address from contributors.json and watchlist. * Scripts/validate-committer-lists: Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (210916 => 210917) --- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2017-01-19 08:04:55 UTC (rev 210916) +++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2017-01-19 08:08:38 UTC (rev 210917) @@ -5262,7 +5262,8 @@ ], "emails" : [ "timo...@hatcher.name", - "thatc...@tesla.com" + "thatc...@tesla.com", + "timo...@apple.com" ], "expertise" : "WebKit API (Mac), WebKit Web Site, Developer Tools (Web Inspector, _javascript_ Debugger)", "nicks" : [ @@ -5821,4 +5822,4 @@ ], "status" : "reviewer" } -} \ No newline at end of file +} ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210918] trunk
Title: [210918] trunk
Revision 210918
Author achristen...@apple.com
Date 2017-01-19 00:21:37 -0800 (Thu, 19 Jan 2017)
Log Message
[WebIDL] Records should preserve _javascript_ object order
https://bugs.webkit.org/show_bug.cgi?id=167189
Patch by Sam Weinig on 2017-01-18
Reviewed by Alex Christensen.
Source/WebCore:
Instead of modeling IDL records as HashMaps, use a Vector
of KeyValuePairs, to all preserving the iteration order.
* Modules/webdatabase/SQLResultSetRowList.cpp:
(WebCore::SQLResultSetRowList::item):
* Modules/webdatabase/SQLResultSetRowList.h:
Return a Vector rather than a HashMap.
* bindings/IDLTypes.h:
Change underlying type to be a Vector>.
* bindings/js/JSDOMConvert.h:
Update conversion for new implementation type. For conversion
to JSValue, allow any type that can has an iterator of keyValuePairs.
* testing/TypeConversions.h:
(WebCore::TypeConversions::testLongRecord):
(WebCore::TypeConversions::setTestLongRecord):
(WebCore::TypeConversions::testNodeRecord):
(WebCore::TypeConversions::setTestNodeRecord):
(WebCore::TypeConversions::testSequenceRecord):
(WebCore::TypeConversions::setTestSequenceRecord):
* testing/TypeConversions.idl:
Update test IDL to use functions, since the spec mandates that
records can't be used with attributes.
LayoutTests:
* js/dom/webidl-type-mapping-expected.txt:
* js/dom/webidl-type-mapping.html:
Update test to reflect changes to TypeConversions.idl
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/webidl-type-mapping-expected.txt
trunk/LayoutTests/js/dom/webidl-type-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/SQLResultSetRowList.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLResultSetRowList.h
trunk/Source/WebCore/bindings/IDLTypes.h
trunk/Source/WebCore/bindings/js/JSDOMConvert.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/testing/TypeConversions.h
trunk/Source/WebCore/testing/TypeConversions.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (210917 => 210918)
--- trunk/LayoutTests/ChangeLog 2017-01-19 08:08:38 UTC (rev 210917)
+++ trunk/LayoutTests/ChangeLog 2017-01-19 08:21:37 UTC (rev 210918)
@@ -1,3 +1,14 @@
+2017-01-18 Sam Weinig
+
+[WebIDL] Records should preserve _javascript_ object order
+https://bugs.webkit.org/show_bug.cgi?id=167189
+
+Reviewed by Alex Christensen.
+
+* js/dom/webidl-type-mapping-expected.txt:
+* js/dom/webidl-type-mapping.html:
+Update test to reflect changes to TypeConversions.idl
+
2017-01-18 Yoav Weiss
Add Link header support for preload.
Modified: trunk/LayoutTests/js/dom/webidl-type-mapping-expected.txt (210917 => 210918)
--- trunk/LayoutTests/js/dom/webidl-type-mapping-expected.txt 2017-01-19 08:08:38 UTC (rev 210917)
+++ trunk/LayoutTests/js/dom/webidl-type-mapping-expected.txt 2017-01-19 08:21:37 UTC (rev 210918)
@@ -1127,69 +1127,69 @@
PASS converter.typeConversionsDictionaryUnionType is 'dictionary'
Testing record conversion
-converter.testLongRecord = { key: 1, key2: 2 }
-PASS converter.testLongRecord is an instance of Object
-PASS converter.testLongRecord.hasOwnProperty('key') is true
-PASS 'key' in converter.testLongRecord is true
-PASS converter.testLongRecord['key'] is 1
-PASS converter.testLongRecord.hasOwnProperty('key2') is true
-PASS 'key2' in converter.testLongRecord is true
-PASS converter.testLongRecord['key2'] is 2
-converter.testLongRecord = undefined
-PASS converter.testLongRecord is an instance of Object
-converter.testLongRecord = null
-PASS converter.testLongRecord is an instance of Object
-PASS converter.testLongRecord = 1 threw exception TypeError: Type error.
-PASS converter.testLongRecord = { key: { valueOf:function() { throw new Error(); } } } threw exception Error.
-var o = { otherKey: 2 }; Object.defineProperty(o, 'key', { enumerable: false, value: 1 }); converter.testLongRecord = o;
-PASS converter.testLongRecord.hasOwnProperty('key') is false
-PASS converter.testLongRecord.hasOwnProperty('otherKey') is true
-PASS converter.testLongRecord['otherKey'] is 2
-var o = { otherKey: 2 }; Object.defineProperty(o, 'key', { get: function() { return 1; }, enumerable: true }); converter.testLongRecord = o;
-PASS converter.testLongRecord.hasOwnProperty('key') is true
-PASS converter.testLongRecord['key'] is 1
-PASS converter.testLongRecord.hasOwnProperty('otherKey') is true
-PASS converter.testLongRecord['otherKey'] is 2
-PASS var o = { otherKey: 2 }; Object.defineProperty(o, 'key', { get: function() { throw new Error();; }, enumerable: true }); converter.testLongRecord = o; threw exception Error.
-converter.testNodeRecord = { key: document, key2: document.documentElement }
-PASS converter.testNodeRecord.hasOwnProperty('key') is true
-PASS 'key' in converter.testNodeRecord is true
-PASS converter.testNodeRecord['key'] is document
-PASS converter.testNodeRecord.hasOwnProperty('key2') is true
-PASS 'key2' in converter.testNode
[webkit-changes] [210919] trunk/Source/JavaScriptCore
Title: [210919] trunk/Source/_javascript_Core
Revision 210919
Author utatane@gmail.com
Date 2017-01-19 00:40:05 -0800 (Thu, 19 Jan 2017)
Log Message
[B3] B3 strength reduction could encounter Value without owner in PureCSE
https://bugs.webkit.org/show_bug.cgi?id=167161
Reviewed by Filip Pizlo.
PureCSE relies on the fact that all the stored Values have owner member.
This assumption is broken when you execute specializeSelect in B3ReduceStrength phase.
It clears owner of Values which are in between Select and Check to clone them to then/else
blocks. If these cleared Values are already stored in PureCSE map, this map poses a Value
with nullptr owner in PureCSE.
This patch changes PureCSE to ignore stored Values tha have nullptr owner. This even means
that a client of PureCSE could deliberately null the owner if they wanted to signal the
Value should be ignored.
While PureCSE ignores chance for optimization if Value's owner is nullptr, in the current
strength reduction algorithm, this does not hurt optimization because CSE will be eventually
applied since the strength reduction phase want to reach fixed point. But even without
this iterations, our result itself is valid since PureCSE is allowed to be conservative.
* b3/B3PureCSE.cpp:
(JSC::B3::PureCSE::findMatch):
(JSC::B3::PureCSE::process):
* b3/testb3.cpp:
(JSC::B3::testCheckSelectAndCSE):
(JSC::B3::run):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3PureCSE.cpp
trunk/Source/_javascript_Core/b3/testb3.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (210918 => 210919)
--- trunk/Source/_javascript_Core/ChangeLog 2017-01-19 08:21:37 UTC (rev 210918)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-01-19 08:40:05 UTC (rev 210919)
@@ -1,3 +1,32 @@
+2017-01-18 Yusuke Suzuki
+
+[B3] B3 strength reduction could encounter Value without owner in PureCSE
+https://bugs.webkit.org/show_bug.cgi?id=167161
+
+Reviewed by Filip Pizlo.
+
+PureCSE relies on the fact that all the stored Values have owner member.
+This assumption is broken when you execute specializeSelect in B3ReduceStrength phase.
+It clears owner of Values which are in between Select and Check to clone them to then/else
+blocks. If these cleared Values are already stored in PureCSE map, this map poses a Value
+with nullptr owner in PureCSE.
+
+This patch changes PureCSE to ignore stored Values tha have nullptr owner. This even means
+that a client of PureCSE could deliberately null the owner if they wanted to signal the
+Value should be ignored.
+
+While PureCSE ignores chance for optimization if Value's owner is nullptr, in the current
+strength reduction algorithm, this does not hurt optimization because CSE will be eventually
+applied since the strength reduction phase want to reach fixed point. But even without
+this iterations, our result itself is valid since PureCSE is allowed to be conservative.
+
+* b3/B3PureCSE.cpp:
+(JSC::B3::PureCSE::findMatch):
+(JSC::B3::PureCSE::process):
+* b3/testb3.cpp:
+(JSC::B3::testCheckSelectAndCSE):
+(JSC::B3::run):
+
2017-01-18 Filip Pizlo
JSSegmentedVariableObject and its subclasses should have a sane destruction story
Modified: trunk/Source/_javascript_Core/b3/B3PureCSE.cpp (210918 => 210919)
--- trunk/Source/_javascript_Core/b3/B3PureCSE.cpp 2017-01-19 08:21:37 UTC (rev 210918)
+++ trunk/Source/_javascript_Core/b3/B3PureCSE.cpp 2017-01-19 08:40:05 UTC (rev 210919)
@@ -56,6 +56,8 @@
return nullptr;
for (Value* match : iter->value) {
+if (!match->owner)
+continue;
if (dominators.dominates(match->owner, block))
return match;
}
@@ -75,6 +77,8 @@
Matches& matches = m_map.add(key, Matches()).iterator->value;
for (Value* match : matches) {
+if (!match->owner)
+continue;
if (dominators.dominates(match->owner, value->owner)) {
value->replaceWithIdentity(match);
return true;
Modified: trunk/Source/_javascript_Core/b3/testb3.cpp (210918 => 210919)
--- trunk/Source/_javascript_Core/b3/testb3.cpp 2017-01-19 08:21:37 UTC (rev 210918)
+++ trunk/Source/_javascript_Core/b3/testb3.cpp 2017-01-19 08:40:05 UTC (rev 210919)
@@ -11831,6 +11831,50 @@
CHECK(invoke(*code, true, false) == 667);
}
+void testCheckSelectAndCSE()
+{
+Procedure proc;
+BasicBlock* root = proc.addBlock();
+
+auto* selectValue = root->appendNew(
+proc, Select, Origin(),
+root->appendNew(
+proc, BitAnd, Origin(),
+root->appendNew(
+proc, Trunc, Origin(),
+root->appendNew(
+proc, Origin(), GPRInfo::argumentGPR0)),
+root->appendNew(proc, Origin(), 0xff)),
+root->appendNew(proc, Origin(), -42)
[webkit-changes] [210920] trunk/Source/WebKit2
Title: [210920] trunk/Source/WebKit2
Revision 210920
Author carlo...@webkit.org
Date 2017-01-19 00:59:42 -0800 (Thu, 19 Jan 2017)
Log Message
[GTK] Do not update the backing store state unnecessarily when page visibility changes
https://bugs.webkit.org/show_bug.cgi?id=167195
Reviewed by Sergio Villar Senin.
I've noticed that we are receiving UpdateBackingStoreState messages in the web process even when size and scale
factor didn't change. That's quite unfortunate because we do a lot of work unnecessarily and we tell the
threaded compositor that the size changed. This is not only a problem because it's not true, but also because
changing the size is a sync operation in the threaded compositor, so we block the compositing thread for
nothing. This is happening because the WebPageProxy notifies the drawing area that the backing store is
discardable when the page is not visible, and that always produces a new backing store state. In accelerating
compositing mode we don't even have a backing store to discard, so we should check we have something to discard
and also make sure we only generate a new backing store state if we really discarded the backing store.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
(WebKit::DrawingAreaProxyImpl::discardBackingStore):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (210919 => 210920)
--- trunk/Source/WebKit2/ChangeLog 2017-01-19 08:40:05 UTC (rev 210919)
+++ trunk/Source/WebKit2/ChangeLog 2017-01-19 08:59:42 UTC (rev 210920)
@@ -1,3 +1,23 @@
+2017-01-19 Carlos Garcia Campos
+
+[GTK] Do not update the backing store state unnecessarily when page visibility changes
+https://bugs.webkit.org/show_bug.cgi?id=167195
+
+Reviewed by Sergio Villar Senin.
+
+I've noticed that we are receiving UpdateBackingStoreState messages in the web process even when size and scale
+factor didn't change. That's quite unfortunate because we do a lot of work unnecessarily and we tell the
+threaded compositor that the size changed. This is not only a problem because it's not true, but also because
+changing the size is a sync operation in the threaded compositor, so we block the compositing thread for
+nothing. This is happening because the WebPageProxy notifies the drawing area that the backing store is
+discardable when the page is not visible, and that always produces a new backing store state. In accelerating
+compositing mode we don't even have a backing store to discard, so we should check we have something to discard
+and also make sure we only generate a new backing store state if we really discarded the backing store.
+
+* UIProcess/DrawingAreaProxyImpl.cpp:
+(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
+(WebKit::DrawingAreaProxyImpl::discardBackingStore):
+
2017-01-18 Said Abou-Hallawa
[iOS][WK2] Remove the WebView private configuration contentUpdateFrequency
Modified: trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp (210919 => 210920)
--- trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp 2017-01-19 08:40:05 UTC (rev 210919)
+++ trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp 2017-01-19 08:59:42 UTC (rev 210920)
@@ -175,7 +175,7 @@
void DrawingAreaProxyImpl::discardBackingStoreSoon()
{
-if (!m_isBackingStoreDiscardable || m_discardBackingStoreTimer.isActive())
+if (!m_backingStore || !m_isBackingStoreDiscardable || m_discardBackingStoreTimer.isActive())
return;
// We'll wait this many seconds after the last paint before throwing away our backing store to save memory.
@@ -187,6 +187,8 @@
void DrawingAreaProxyImpl::discardBackingStore()
{
+if (!m_backingStore)
+return;
m_backingStore = nullptr;
backingStoreStateDidChange(DoNotRespondImmediately);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210921] trunk
Title: [210921] trunk Revision 210921 Author carlo...@webkit.org Date 2017-01-19 01:03:25 -0800 (Thu, 19 Jan 2017) Log Message [GTK] Provide API to set proxy settings https://bugs.webkit.org/show_bug.cgi?id=128674 Reviewed by Michael Catanzaro. Source/WebCore: Add SoupNetworkProxySettings struct to store proxy settings. * platform/network/soup/SoupNetworkProxySettings.h: Added. (WebCore::SoupNetworkProxySettings::SoupNetworkProxySettings): (WebCore::SoupNetworkProxySettings::operator=): (WebCore::SoupNetworkProxySettings::isEmpty): * platform/network/soup/SoupNetworkSession.cpp: (WebCore::SoupNetworkSession::SoupNetworkSession): Setup the proxy if user provided proxy settings. (WebCore::SoupNetworkSession::setupProxy): Set the proxy-resolver property of the SoupSession according to the global SoupNetworkProxySettings. (WebCore::SoupNetworkSession::setProxySettingsFromEnvironment): Update the global SoupNetworkProxySettings with values from environment. (WebCore::SoupNetworkSession::setProxySettings): Set the global SoupNetworkProxySettings. * platform/network/soup/SoupNetworkSession.h: Source/WebKit2: Add new method webkit_web_context_set_network_proxy_settings() that allows to set proxy settings in a WebKitWebContext. It receives an enum WebKitNetworkProxyMode with modes Default, NoProxy and Custom, and an optional WebKitNetworkProxySettings that is used when mode is Custom. WebKitNetworkProxySettings is a simple boxed type that user can create to set proxy settins with a similar API to GSimpleProxyResolver. * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: Add SetNetworkProxySettings message. * NetworkProcess/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode): Encode proxy settings. (WebKit::NetworkProcessCreationParameters::decode): Decode proxy settings. * NetworkProcess/NetworkProcessCreationParameters.h: * NetworkProcess/efl/NetworkProcessMainEfl.cpp: Use SoupNetworkSession::setProxySettingsFromEnvironment(). * NetworkProcess/soup/NetworkProcessSoup.cpp: (WebKit::NetworkProcess::platformInitializeNetworkProcess): Set proxy settings if provided by the user. (WebKit::NetworkProcess::setNetworkProxySettings): Set global proxy settings and setup the proxy for all existing contexts. * PlatformGTK.cmake: Add new files to compilation. * Shared/WebCoreArgumentCoders.h: * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): Encode proxy settings. (WebKit::WebProcessCreationParameters::decode): Decode proxy settings. * Shared/WebProcessCreationParameters.h: * Shared/soup/WebCoreArgumentCodersSoup.cpp: (IPC::ArgumentCoder::encode): Add encoder implementation for SoupNetworkProxySettings. (IPC::ArgumentCoder::decode): add decoder implementation for SoupNetworkProxySettings. * UIProcess/API/gtk/WebKitNetworkProxySettings.cpp: Added. (_WebKitNetworkProxySettings::_WebKitNetworkProxySettings): (webkitNetworkProxySettingsGetNetworkProxySettings): (webkit_network_proxy_settings_new): Create a new WebKitNetworkProxySettings with optional default proxy uri and ignore hosts list. (webkit_network_proxy_settings_copy): (webkit_network_proxy_settings_free): (webkit_network_proxy_settings_add_proxy): Add a proxy uri for a given uri scheme. * UIProcess/API/gtk/WebKitNetworkProxySettings.h: Added. * UIProcess/API/gtk/WebKitNetworkProxySettingsPrivate.h: Added. * UIProcess/API/gtk/WebKitWebContext.cpp: (webkit_web_context_set_network_proxy_settings): Set proxy settings. * UIProcess/API/gtk/WebKitWebContext.h: * UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols to the documentation. * UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for WebKitNetworkProxySettings. * UIProcess/API/gtk/webkit2.h: Include WebKitNetworkProxySettings.h. * UIProcess/WebProcessPool.h: Add m_networkProxySettings and a setter for soup. * UIProcess/efl/WebProcessPoolEfl.cpp: (WebKit::WebProcessPool::platformInitializeWebProcess): Set m_networkProxySettings to parameters. * UIProcess/gtk/WebProcessPoolGtk.cpp: (WebKit::WebProcessPool::platformInitializeWebProcess): Ditto. * UIProcess/soup/WebProcessPoolSoup.cpp: (WebKit::WebProcessPool::platformInitializeNetworkProcess): Ditto. (WebKit::WebProcessPool::setNetworkProxySettings): Update m_networkProxySettings and notify all processes. * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: Add SetNetworkProxySettings message. * WebProcess/efl/WebProcessMainEfl.cpp: Use SoupNetworkSession::setProxySettingsFromEnvironment(). * WebProcess/soup/WebProcessSoup.cpp: (WebKit::WebProcess::platformSetCacheModel): Remove comment that is no longer true. (WebKit::WebProcess::platformInitializeWebProcess): Set proxy settings if provided by the user. (WebKit::WebProcess::setNetworkProxySettings): Set global proxy settings and setup the proxy for all existing contexts. Tools: Add tests for new proxy settings API. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebCont
[webkit-changes] [210922] trunk/Tools
Title: [210922] trunk/Tools
Revision 210922
Author carlo...@webkit.org
Date 2017-01-19 03:50:31 -0800 (Thu, 19 Jan 2017)
Log Message
Unreviewed. Fix GTK+ unit tests failing since r210531.
Avoid using paths to files that don't actually exist.
* TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
(testWebKitConsoleMessageNetworkError):
* TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
(testContextMenuDefaultMenu):
* TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
* TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
* TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg
Diff
Modified: trunk/Tools/ChangeLog (210921 => 210922)
--- trunk/Tools/ChangeLog 2017-01-19 09:03:25 UTC (rev 210921)
+++ trunk/Tools/ChangeLog 2017-01-19 11:50:31 UTC (rev 210922)
@@ -1,5 +1,19 @@
2017-01-19 Carlos Garcia Campos
+Unreviewed. Fix GTK+ unit tests failing since r210531.
+
+Avoid using paths to files that don't actually exist.
+
+* TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
+(testWebKitConsoleMessageNetworkError):
+* TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
+(testContextMenuDefaultMenu):
+* TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
+* TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
+* TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
+
+2017-01-19 Carlos Garcia Campos
+
[GTK] Provide API to set proxy settings
https://bugs.webkit.org/show_bug.cgi?id=128674
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp (210921 => 210922)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp 2017-01-19 09:03:25 UTC (rev 210921)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp 2017-01-19 11:50:31 UTC (rev 210922)
@@ -127,8 +127,8 @@
static void testWebKitConsoleMessageNetworkError(ConsoleMessageTest* test, gconstpointer)
{
ConsoleMessageTest::ConsoleMessage referenceMessage = { ConsoleMessageTest::MessageSource::Network, ConsoleMessageTest::MessageLevel::Error,
-"Failed to load resource: Error opening file: No such file or directory", 0, "file:///foo/not-found.css" };
-test->loadHtml("", "file:///foo/bar");
+"Failed to load resource: The resource at '/org/webkit/webkit2gtk/tests/not-found.css' does not exist", 0, "resource:///org/webkit/webkit2gtk/tests/not-found.css" };
+test->loadHtml("", "resource:///org/webkit/webkit2gtk/tests/");
test->waitUntilConsoleMessageReceived();
g_assert(test->m_consoleMessage == referenceMessage);
}
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp (210921 => 210922)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp 2017-01-19 09:03:25 UTC (rev 210921)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp 2017-01-19 11:50:31 UTC (rev 210922)
@@ -369,6 +369,7 @@
{
test->showInWindowAndWaitUntilMapped();
+GUniquePtr baseDir(g_strdup_printf("file://%s/", Test::getResourcesDir().data()));
const char* linksHTML =
""
" "
@@ -381,14 +382,14 @@
" "
""
" WebKitGTK+ Website"
-" "
-" "
+" "
+" "
" "
-" "
+" "
" "
" Lorem ipsum."
"";
-test->loadHtml(linksHTML, "file:///");
+test->loadHtml(linksHTML, baseDir.get());
test->waitUntilLoadFinished();
// Context menu for selection.
Added: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg (0 => 210922)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg (rev 0)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg 2017-01-19 11:50:31 UTC (rev 210922)
@@ -0,0 +1,261 @@
+\xFF\xFD\xA0\xC0xh\x87\x87x}\xB7\xDAH@\xAB\xBAj#Îhc\x9A\x8B(\x9E\xAA)\xA2\xCAh\xAA\xCAl\xA2êº\xAC\xAB\xBA\xAB\xA9\xB6\xB7\xF7\xF7\xF7\xFB\xFD\xFE\xFD\xFB\xF7\xEFß¿~\xFD\xF7\xDF~\xFD\xFB\xEF\xBE\xFB\xEF\xBF~\xFD\xF7\xDF{\xDE\xF7\xBD\xEF{\xFF\xFC\xFE\xEB\xDE\xF7\xBD\xEBbض5\xFD\xF6+\xFF~\xBF|\xFD\xF3\xF7`Gy\xF7 @\x88\xFC\xBF\xD0 \xC3}\xF7 \xF7\xBD\xF0{\xDF\x8A\xFC\xF3\x9A\xF7\xB5\xEFzØ\xAD\x8Dm\x9B\x92\xBC:\xEC\xE12z3t/\xE3 I7H\x921\xA3\x93\xCB 3<Ï$\xEE\xED\xCE\xE1+\x86ç¥\&\xA7\xB5\xCF\xC9"@Ï´\xFB\x8B\xDD8\xCBM\xABa\xF0\xCDyj\xAA\xF8]\xC9|\x8A^5\xEB\x86ìµ\xBDk_3\x9B\xE7#\xADÖ¨\xABdN\xD4N\xF8\x9E\x8F\x91]\xBB\xCA@@\xFF\xFD\xA2\xC0VXwxw\xF6\xD6$@\xAB\xA7*\xA9\xA8\x
[webkit-changes] [210923] trunk/Source
Title: [210923] trunk/Source Revision 210923 Author akl...@apple.com Date 2017-01-19 07:56:13 -0800 (Thu, 19 Jan 2017) Log Message ScriptExecutionContext::topOrigin() should return a reference. Reviewed by Sam Weinig. Source/WebCore: There is always a topOrigin() SecurityOrigin, so make it return a reference and remove some unnecessary null-checks exposed by this change. * Modules/applepay/ApplePaySession.cpp: (WebCore::canCallApplePaySessionAPIs): * Modules/encryptedmedia/CDM.cpp: (WebCore::CDM::getSupportedConfiguration): (WebCore::CDM::getConsentStatus): * Modules/indexeddb/IDBFactory.cpp: (WebCore::IDBFactory::openInternal): (WebCore::IDBFactory::deleteDatabase): * Modules/mediastream/MediaDevicesEnumerationRequest.cpp: (WebCore::MediaDevicesEnumerationRequest::topLevelDocumentOrigin): * Modules/mediastream/UserMediaRequest.cpp: (WebCore::UserMediaRequest::topLevelDocumentOrigin): (WebCore::canCallGetUserMedia): * dom/Document.h: * dom/ScriptExecutionContext.h: * html/DOMURL.cpp: (WebCore::DOMURL::revokeObjectURL): * inspector/InspectorIndexedDBAgent.cpp: (WebCore::InspectorIndexedDBAgent::requestDatabaseNames): * inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::cachedResource): * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL): (WebCore::ApplicationCacheGroup::update): * loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): * loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::setDomainForCachePartition): * page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessSessionStorage): (WebCore::SecurityOrigin::canAccessPluginStorage): (WebCore::SecurityOrigin::canAccessApplicationCache): * storage/StorageNamespaceProvider.cpp: (WebCore::StorageNamespaceProvider::localStorageArea): * testing/Internals.cpp: (WebCore::Internals::isLoadingFromMemoryCache): * workers/DedicatedWorkerGlobalScope.cpp: (WebCore::DedicatedWorkerGlobalScope::create): (WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope): * workers/DedicatedWorkerGlobalScope.h: * workers/DedicatedWorkerThread.cpp: (WebCore::DedicatedWorkerThread::DedicatedWorkerThread): (WebCore::DedicatedWorkerThread::createWorkerGlobalScope): * workers/DedicatedWorkerThread.h: * workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::WorkerGlobalScope): * workers/WorkerGlobalScope.h: * workers/WorkerThread.cpp: (WebCore::WorkerThreadStartupData::WorkerThreadStartupData): (WebCore::WorkerThread::WorkerThread): * workers/WorkerThread.h: Source/WebKit/mac: * Misc/WebCache.mm: (+[WebCache addImageToCache:forURL:forFrame:]): (+[WebCache removeImageFromCacheForURL:forFrame:]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp trunk/Source/WebCore/Modules/mediastream/MediaDevicesEnumerationRequest.cpp trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/ScriptExecutionContext.h trunk/Source/WebCore/html/DOMURL.cpp trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp trunk/Source/WebCore/inspector/InspectorPageAgent.cpp trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp trunk/Source/WebCore/page/SecurityOrigin.h trunk/Source/WebCore/storage/StorageNamespaceProvider.cpp trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.h trunk/Source/WebCore/workers/DedicatedWorkerThread.cpp trunk/Source/WebCore/workers/DedicatedWorkerThread.h trunk/Source/WebCore/workers/WorkerGlobalScope.cpp trunk/Source/WebCore/workers/WorkerGlobalScope.h trunk/Source/WebCore/workers/WorkerThread.cpp trunk/Source/WebCore/workers/WorkerThread.h trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Misc/WebCache.mm Diff Modified: trunk/Source/WebCore/ChangeLog (210922 => 210923) --- trunk/Source/WebCore/ChangeLog 2017-01-19 11:50:31 UTC (rev 210922) +++ trunk/Source/WebCore/ChangeLog 2017-01-19 15:56:13 UTC (rev 210923) @@ -1,3 +1,67 @@ +2017-01-19 Andreas Kling + +ScriptExecutionContext::topOrigin() should return a reference. + + +Reviewed by Sam Weinig. + +There is always a topOrigin() SecurityOrigin, so make it return a reference +and remove some unnecessary null-checks exposed by this change. + +* Modules/applepay/ApplePaySession.cpp: +(WebCore::canCallApplePaySessionAPIs): +* Modules/encryptedmedia/CDM.cpp: +(WebCore::CDM::getSupportedConfiguration): +(WebCore::CD
[webkit-changes] [210924] tags/Safari-604.1.4/
Title: [210924] tags/Safari-604.1.4/ Revision 210924 Author jmarc...@apple.com Date 2017-01-19 08:56:57 -0800 (Thu, 19 Jan 2017) Log Message New tag. Added Paths tags/Safari-604.1.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210926] trunk/Source/WebCore
Title: [210926] trunk/Source/WebCore Revision 210926 Author ryanhad...@apple.com Date 2017-01-19 09:28:24 -0800 (Thu, 19 Jan 2017) Log Message Rebaseline bindings tests after r210918. Unreviewed test gardening. * bindings/scripts/test/JS/JSTestObj.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (210925 => 210926) --- trunk/Source/WebCore/ChangeLog 2017-01-19 17:10:31 UTC (rev 210925) +++ trunk/Source/WebCore/ChangeLog 2017-01-19 17:28:24 UTC (rev 210926) @@ -1,3 +1,11 @@ +2017-01-19 Ryan Haddad + +Rebaseline bindings tests after r210918. + +Unreviewed test gardening. + +* bindings/scripts/test/JS/JSTestObj.cpp: + 2017-01-19 Andreas Kling ScriptExecutionContext::topOrigin() should return a reference. Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (210925 => 210926) --- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2017-01-19 17:10:31 UTC (rev 210925) +++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2017-01-19 17:28:24 UTC (rev 210926) @@ -63,8 +63,8 @@ #include #include #include -#include #include +#include #if ENABLE(Condition1) #include "JSTestObjectA.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210927] trunk/Source/WebKit2
Title: [210927] trunk/Source/WebKit2
Revision 210927
Author bb...@apple.com
Date 2017-01-19 09:52:36 -0800 (Thu, 19 Jan 2017)
Log Message
Web Inspector: move Mac-specific automation commands to a separate implementation file
https://bugs.webkit.org/show_bug.cgi?id=163297
Reviewed by Timothy Hatcher.
Not all Automation commands are available on all platforms. Start splitting out
command declarations and implementations based on the target platform.
* DerivedSources.make:
Set an appropriate --platform so the correct backend interface is generated.
* UIProcess/Automation/Automation.json:
Guard commands that should not be available on iOS:
- resizeWindowOfBrowsingContext
- moveWindowOfBrowsingContext
- inspectBrowsingContext
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::platformSimulateKeySequence): Deleted.
- Move shared convenience macros to header file.
- Move out Cocoa-only or Mac-only command implementations.
* UIProcess/Automation/WebAutomationSession.h:
Rearrange some declarations and switch from USE(APPKIT) to PLATFORM(MAC).
* UIProcess/Automation/WebAutomationSessionMacros.h: Added.
* UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm: Added.
(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):
Moved from WebAutomationSessionCocoa.mm. Add iOS-specific header includes.
* UIProcess/Automation/mac/WebAutomationSessionMac.mm: Renamed from Source/WebKit2/UIProcess/Cocoa/WebAutomationSessionCocoa.mm.
(WebKit::WebAutomationSession::resizeWindowOfBrowsingContext):
(WebKit::WebAutomationSession::moveWindowOfBrowsingContext):
(WebKit::WebAutomationSession::inspectBrowsingContext):
Move macOS platform command implementations to here. If other desktop ports want
to use these commands, we can move them somewhere else later.
(WebKit::WebAutomationSession::sendSynthesizedEventsToPage):
(WebKit::WebAutomationSession::markEventAsSynthesizedForAutomation):
(WebKit::WebAutomationSession::wasEventSynthesizedForAutomation):
Move out AppKit-specific event simulation code to here.
(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
(WebKit::WebAutomationSession::platformSimulateKeyStroke):
(WebKit::WebAutomationSession::platformSimulateKeySequence):
Move out Mac platformFoo implementations to here.
* WebKit2.xcodeproj/project.pbxproj:
- Added UIProcess/Automation/{mac,cocoa} groups.
- Add new platform-specific implementation files.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DerivedSources.make
trunk/Source/WebKit2/UIProcess/Automation/Automation.json
trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp
trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSessionMacros.h
trunk/Source/WebKit2/UIProcess/Automation/cocoa/
trunk/Source/WebKit2/UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm
trunk/Source/WebKit2/UIProcess/Automation/mac/
trunk/Source/WebKit2/UIProcess/Automation/mac/WebAutomationSessionMac.mm
Removed Paths
trunk/Source/WebKit2/UIProcess/Cocoa/WebAutomationSessionCocoa.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (210926 => 210927)
--- trunk/Source/WebKit2/ChangeLog 2017-01-19 17:28:24 UTC (rev 210926)
+++ trunk/Source/WebKit2/ChangeLog 2017-01-19 17:52:36 UTC (rev 210927)
@@ -1,3 +1,58 @@
+2017-01-19 Brian Burg
+
+Web Inspector: move Mac-specific automation commands to a separate implementation file
+https://bugs.webkit.org/show_bug.cgi?id=163297
+
+
+Reviewed by Timothy Hatcher.
+
+Not all Automation commands are available on all platforms. Start splitting out
+command declarations and implementations based on the target platform.
+
+* DerivedSources.make:
+Set an appropriate --platform so the correct backend interface is generated.
+
+* UIProcess/Automation/Automation.json:
+Guard commands that should not be available on iOS:
+- resizeWindowOfBrowsingContext
+- moveWindowOfBrowsingContext
+- inspectBrowsingContext
+
+* UIProcess/Automation/WebAutomationSession.cpp:
+(WebKit::WebAutomationSession::platformSimulateKeySequence): Deleted.
+- Move shared convenience macros to header file.
+- Move out Cocoa-only or Mac-only command implementations.
+
+* UIProcess/Automation/WebAutomationSession.h:
+Rearrange some declarations and switch from USE(APPKIT) to PLATFORM(MAC).
+
+* UIProcess/Automation/WebAutomationSessionMacros.h: Added.
+
+* UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm: Added.
+(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):
+Moved from WebAutomationSessionCocoa.mm. Add iOS-specific header includes.
+
+* UIProcess/Automation/mac/WebAutomationSessionMac.mm: Renamed from Source/WebKi
[webkit-changes] [210929] trunk/Source/WebKit2
Title: [210929] trunk/Source/WebKit2 Revision 210929 Author ander...@apple.com Date 2017-01-19 10:20:30 -0800 (Thu, 19 Jan 2017) Log Message Install WebKit.apinotes with the public headers of WebKit framework https://bugs.webkit.org/show_bug.cgi?id=167182 rdar://problem/29008989 Reviewed by Sam Weinig. * Shared/API/Cocoa/WebKit.apinotes: Added. * WebKit2.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit2/Shared/API/Cocoa/WebKit.apinotes Diff Modified: trunk/Source/WebKit2/ChangeLog (210928 => 210929) --- trunk/Source/WebKit2/ChangeLog 2017-01-19 17:59:12 UTC (rev 210928) +++ trunk/Source/WebKit2/ChangeLog 2017-01-19 18:20:30 UTC (rev 210929) @@ -1,3 +1,14 @@ +2017-01-18 Anders Carlsson + +Install WebKit.apinotes with the public headers of WebKit framework +https://bugs.webkit.org/show_bug.cgi?id=167182 +rdar://problem/29008989 + +Reviewed by Sam Weinig. + +* Shared/API/Cocoa/WebKit.apinotes: Added. +* WebKit2.xcodeproj/project.pbxproj: + 2017-01-19 Brian Burg Web Inspector: move Mac-specific automation commands to a separate implementation file Added: trunk/Source/WebKit2/Shared/API/Cocoa/WebKit.apinotes (0 => 210929) --- trunk/Source/WebKit2/Shared/API/Cocoa/WebKit.apinotes (rev 0) +++ trunk/Source/WebKit2/Shared/API/Cocoa/WebKit.apinotes 2017-01-19 18:20:30 UTC (rev 210929) @@ -0,0 +1,202 @@ +--- +Name: WebKit +Classes: +- Name: WebFrame + Properties: + - Name: dataSource +Nullability: O +- Name: WebView + Methods: + - Selector: 'alignCenter:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'alignJustified:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'alignLeft:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'alignRight:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'changeAttributes:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'changeColor:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'changeDocumentBackgroundColor:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'changeFont:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'checkSpelling:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'copy:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'copyFont:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'cut:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'delete:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'goBack:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'goForward:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'makeTextLarger:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'makeTextSmaller:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'makeTextStandardSize:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'moveToBeginningOfSentence:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'moveToBeginningOfSentenceAndModifySelection:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'moveToEndOfSentence:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'moveToEndOfSentenceAndModifySelection:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'overWrite:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'paste:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'pasteAsPlainText:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'pasteAsRichText:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'pasteFont:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'performFindPanelAction:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'reload:' +MethodKind: Instance +Nullability: +- O +NullabilityOfRet: S + - Selector: 'reloadFromOrigin:' +MethodKind: Instance +Nullability: +- O +Nulla
[webkit-changes] [210930] trunk/Source/WebInspectorUI
Title: [210930] trunk/Source/WebInspectorUI
Revision 210930
Author commit-qu...@webkit.org
Date 2017-01-19 10:31:08 -0800 (Thu, 19 Jan 2017)
Log Message
Web Inspector: Network Tab's "Clear Network Items" button should have keyboard shortcuts
https://bugs.webkit.org/show_bug.cgi?id=166943
Patch by Devin Rousso on 2017-01-19
Reviewed by Timothy Hatcher.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
(WebInspector._clear):
Move clear keyboard shortcut to main object and call _handleClearShortcut on the visible
content view if able.
* UserInterface/Controllers/_javascript_LogViewController.js:
(WebInspector._javascript_LogViewController):
(WebInspector._javascript_LogViewController.prototype.requestClearMessages):
(WebInspector._javascript_LogViewController.prototype._handleClearShortcut): Deleted.
* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype.handleClearShortcut):
Move logic for requesting to clear messages from the LogManager to a better named function.
* UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView):
(WebInspector.NetworkGridContentView.prototype.handleClearShortcut):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_LogViewController.js
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (210929 => 210930)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-01-19 18:20:30 UTC (rev 210929)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-01-19 18:31:08 UTC (rev 210930)
@@ -1,5 +1,33 @@
2017-01-19 Devin Rousso
+Web Inspector: Network Tab's "Clear Network Items" button should have keyboard shortcuts
+https://bugs.webkit.org/show_bug.cgi?id=166943
+
+Reviewed by Timothy Hatcher.
+
+* Localizations/en.lproj/localizedStrings.js:
+
+* UserInterface/Base/Main.js:
+(WebInspector.contentLoaded):
+(WebInspector._clear):
+Move clear keyboard shortcut to main object and call _handleClearShortcut on the visible
+content view if able.
+
+* UserInterface/Controllers/_javascript_LogViewController.js:
+(WebInspector._javascript_LogViewController):
+(WebInspector._javascript_LogViewController.prototype.requestClearMessages):
+(WebInspector._javascript_LogViewController.prototype._handleClearShortcut): Deleted.
+* UserInterface/Views/LogContentView.js:
+(WebInspector.LogContentView):
+(WebInspector.LogContentView.prototype.handleClearShortcut):
+Move logic for requesting to clear messages from the LogManager to a better named function.
+
+* UserInterface/Views/NetworkGridContentView.js:
+(WebInspector.NetworkGridContentView):
+(WebInspector.NetworkGridContentView.prototype.handleClearShortcut):
+
+2017-01-19 Devin Rousso
+
Web Inspector: Dashboard's log/error/warning help tag says "click to show the Console" even when clicking does nothing
https://bugs.webkit.org/show_bug.cgi?id=167102
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (210929 => 210930)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-01-19 18:20:30 UTC (rev 210929)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-01-19 18:31:08 UTC (rev 210930)
@@ -145,7 +145,7 @@
localizedStrings["Classes"] = "Classes";
localizedStrings["Clear"] = "Clear";
localizedStrings["Clear Log"] = "Clear Log";
-localizedStrings["Clear Network Items"] = "Clear Network Items";
+localizedStrings["Clear Network Items (%s)"] = "Clear Network Items (%s)";
localizedStrings["Clear Timeline"] = "Clear Timeline";
localizedStrings["Clear focus"] = "Clear focus";
localizedStrings["Clear log (%s or %s)"] = "Clear log (%s or %s)";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (210929 => 210930)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-01-19 18:20:30 UTC (rev 210929)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-01-19 18:31:08 UTC (rev 210930)
@@ -276,6 +276,8 @@
this.splitContentBrowser = new WebInspector.ContentBrowser(document.getElementById("split-content-browser"), this, disableBackForward, disableFindBanner);
this.splitContentBrowser.navigationBar.element.addEventListener("mousedown", this._consoleResizerMouseDown.bind(this));
+this.clearKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, "K", this._clear.bind(this));
+
this.quickConsole = new WebInspector.Quick
[webkit-changes] [210928] trunk/Source/WebInspectorUI
Title: [210928] trunk/Source/WebInspectorUI Revision 210928 Author commit-qu...@webkit.org Date 2017-01-19 09:59:12 -0800 (Thu, 19 Jan 2017) Log Message Web Inspector: Dashboard's log/error/warning help tag says "click to show the Console" even when clicking does nothing https://bugs.webkit.org/show_bug.cgi?id=167102 Patch by Devin Rousso on 2017-01-19 Reviewed by Brian Burg. * UserInterface/Base/Main.js: (WebInspector.showConsoleTab): Don't revert to the All scopes if the requested scope is already selected. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Views/DefaultDashboardView.js: (WebInspector.DefaultDashboardView): (WebInspector.DefaultDashboardView.prototype._appendElementForNamedItem): (WebInspector.DefaultDashboardView.prototype._setItemEnabled): Only apply a title to the element when it is enabled. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Base/Main.js trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (210927 => 210928) --- trunk/Source/WebInspectorUI/ChangeLog 2017-01-19 17:52:36 UTC (rev 210927) +++ trunk/Source/WebInspectorUI/ChangeLog 2017-01-19 17:59:12 UTC (rev 210928) @@ -1,3 +1,21 @@ +2017-01-19 Devin Rousso + +Web Inspector: Dashboard's log/error/warning help tag says "click to show the Console" even when clicking does nothing +https://bugs.webkit.org/show_bug.cgi?id=167102 + +Reviewed by Brian Burg. + +* UserInterface/Base/Main.js: +(WebInspector.showConsoleTab): +Don't revert to the All scopes if the requested scope is already selected. + +* Localizations/en.lproj/localizedStrings.js: +* UserInterface/Views/DefaultDashboardView.js: +(WebInspector.DefaultDashboardView): +(WebInspector.DefaultDashboardView.prototype._appendElementForNamedItem): +(WebInspector.DefaultDashboardView.prototype._setItemEnabled): +Only apply a title to the element when it is enabled. + 2017-01-18 Devin Rousso Web Inspector: split console should be allowed for Network and Timeline tabs when Inspector is not docked Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (210927 => 210928) --- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-01-19 17:52:36 UTC (rev 210927) +++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-01-19 17:59:12 UTC (rev 210928) @@ -195,10 +195,7 @@ localizedStrings["Console Evaluation %d"] = "Console Evaluation %d"; localizedStrings["Console Profile Recorded"] = "Console Profile Recorded"; localizedStrings["Console cleared at %s"] = "Console cleared at %s"; -localizedStrings["Console errors, click to show the Console tab"] = "Console errors, click to show the Console tab"; -localizedStrings["Console logs, click to show the Console tab"] = "Console logs, click to show the Console tab"; localizedStrings["Console opened at %s"] = "Console opened at %s"; -localizedStrings["Console warnings, click to show the Console tab"] = "Console warnings, click to show the Console tab"; localizedStrings["Console:"] = "Console:"; localizedStrings["Container Regions"] = "Container Regions"; localizedStrings["Content"] = "Content"; @@ -699,10 +696,16 @@ localizedStrings["Show all resources"] = "Show all resources"; localizedStrings["Show compositing borders"] = "Show compositing borders"; localizedStrings["Show console tab"] = "Show console tab"; +localizedStrings["Show errors logged to the Console"] = "Show errors logged to the Console"; +localizedStrings["Show messages logged to the Console"] = "Show messages logged to the Console"; +localizedStrings["Show network information"] = "Show network information"; +localizedStrings["Show page load timing"] = "Show page load timing"; +localizedStrings["Show page resources"] = "Show page resources"; localizedStrings["Show shadow DOM nodes"] = "Show shadow DOM nodes"; localizedStrings["Show the details sidebar (%s)"] = "Show the details sidebar (%s)"; localizedStrings["Show the navigation sidebar (%s)"] = "Show the navigation sidebar (%s)"; localizedStrings["Show type information"] = "Show type information"; +localizedStrings["Show warnings logged to the Console"] = "Show warnings logged to the Console"; localizedStrings["Shrink"] = "Shrink"; localizedStrings["Size"] = "Size"; localizedStrings["Size of the current object plus the size of all objects it keeps alive."] = "Size of the current object plus the size of all objects it keeps alive."; @@ -776,7 +779,6 @@ localizedStrings["This object is referenced by internal objects"] = "This object is referenced by internal objects"; localizedStrings["This property needs a value.\nClick to open autocomplete."] = "This property needs a value.\nClick to open autocomplete."; lo
[webkit-changes] [210932] trunk
Title: [210932] trunk Revision 210932 Author mmaxfi...@apple.com Date 2017-01-19 11:24:12 -0800 (Thu, 19 Jan 2017) Log Message [Cocoa] Variation fonts are erroneously disabled on iOS https://bugs.webkit.org/show_bug.cgi?id=167172 Reviewed by Simon Fraser. OpenSource builders don't seem to understand sdk=embedded*. Source/_javascript_Core: * Configurations/FeatureDefines.xcconfig: Source/WebCore: * Configurations/FeatureDefines.xcconfig: Source/WebKit/mac: * Configurations/FeatureDefines.xcconfig: Source/WebKit2: * Configurations/FeatureDefines.xcconfig: Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (210931 => 210932) --- trunk/Source/_javascript_Core/ChangeLog 2017-01-19 19:16:22 UTC (rev 210931) +++ trunk/Source/_javascript_Core/ChangeLog 2017-01-19 19:24:12 UTC (rev 210932) @@ -1,3 +1,14 @@ +2017-01-19 Myles C. Maxfield + +[Cocoa] Variation fonts are erroneously disabled on iOS +https://bugs.webkit.org/show_bug.cgi?id=167172 + +Reviewed by Simon Fraser. + +OpenSource builders don't seem to understand sdk=embedded*. + +* Configurations/FeatureDefines.xcconfig: + 2017-01-19 Skachkov Oleksandr "this" missing after await in async arrow function Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (210931 => 210932) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-01-19 19:16:22 UTC (rev 210931) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-01-19 19:24:12 UTC (rev 210932) @@ -39,7 +39,7 @@ ENABLE_ACCELERATED_2D_CANVAS = ; ENABLE_ACCELERATED_OVERFLOW_SCROLLING[sdk=iphone*] = ENABLE_ACCELERATED_OVERFLOW_SCROLLING; -ENABLE_APPLE_PAY[sdk=embedded*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME)); +ENABLE_APPLE_PAY[sdk=iphone*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME)); ENABLE_APPLE_PAY_iphoneos = ENABLE_APPLE_PAY; ENABLE_APPLE_PAY_iphonesimulator = ENABLE_APPLE_PAY; ENABLE_APPLE_PAY[sdk=iphoneos9*] = ; @@ -205,7 +205,7 @@ ENABLE_FTL_JIT[sdk=macosx*] = ENABLE_FTL_JIT; ENABLE_FTL_JIT[sdk=iphoneos*] = ENABLE_FTL_JIT; -ENABLE_VARIATION_FONTS[sdk=embedded*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME)); +ENABLE_VARIATION_FONTS[sdk=iphone*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME)); ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS; ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS; ENABLE_VARIATION_FONTS[sdk=iphoneos9*] = ; Modified: trunk/Source/WebCore/ChangeLog (210931 => 210932) --- trunk/Source/WebCore/ChangeLog 2017-01-19 19:16:22 UTC (rev 210931) +++ trunk/Source/WebCore/ChangeLog 2017-01-19 19:24:12 UTC (rev 210932) @@ -1,3 +1,14 @@ +2017-01-19 Myles C. Maxfield + +[Cocoa] Variation fonts are erroneously disabled on iOS +https://bugs.webkit.org/show_bug.cgi?id=167172 + +Reviewed by Simon Fraser. + +OpenSource builders don't seem to understand sdk=embedded*. + +* Configurations/FeatureDefines.xcconfig: + 2017-01-19 Ryan Haddad Rebaseline bindings tests after r210918. Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (210931 => 210932) --- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2017-01-19 19:16:22 UTC (rev 210931) +++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2017-01-19 19:24:12 UTC (rev 210932) @@ -39,7 +39,7 @@ ENABLE_ACCELERATED_2D_CANVAS = ; ENABLE_ACCELERATED_OVERFLOW_SCROLLING[sdk=iphone*] = ENABLE_ACCELERATED_OVERFLOW_SCROLLING; -ENABLE_APPLE_PAY[sdk=embedded*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME)); +ENABLE_APPLE_PAY[sdk=iphone*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME)); ENABLE_APPLE_PAY_iphoneos = ENABLE_APPLE_PAY; ENABLE_APPLE_PAY_iphonesimulator = ENABLE_APPLE_PAY; ENABLE_APPLE_PAY[sdk=iphoneos9*] = ; @@ -205,7 +205,7 @@ ENABLE_FTL_JIT[sdk=macosx*] = ENABLE_FTL_JIT; ENABLE_FTL_JIT[sdk=iphoneos*] = ENABLE_FTL_JIT; -ENABLE_VARIATION_FONTS[sdk=embedded*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME)); +ENABLE_VARIATION_FONTS[sdk=iphone*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME)); ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS; ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS; ENABLE_VARIATION_FONTS[sdk=iphoneos9*] = ; Modified: trunk/Source/WebKit/mac/ChangeLog (210931 => 210932) --- trunk/Source/WebKit/mac/ChangeLog 2017-01-19 19:16:22 UTC (rev 210931) +++ trunk/Source/WebKit/mac/ChangeLog 20
[webkit-changes] [210933] trunk/Source/WebKit2
Title: [210933] trunk/Source/WebKit2
Revision 210933
Author m...@apple.com
Date 2017-01-19 11:25:56 -0800 (Thu, 19 Jan 2017)
Log Message
Build fix.
Rubber-stamped by Anders Carlsson.
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toPKPaymentAuthorizationStatus): Suppressed deprecation warnings.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (210932 => 210933)
--- trunk/Source/WebKit2/ChangeLog 2017-01-19 19:24:12 UTC (rev 210932)
+++ trunk/Source/WebKit2/ChangeLog 2017-01-19 19:25:56 UTC (rev 210933)
@@ -1,3 +1,12 @@
+2017-01-19 Dan Bernstein
+
+Build fix.
+
+Rubber-stamped by Anders Carlsson.
+
+* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
+(WebKit::toPKPaymentAuthorizationStatus): Suppressed deprecation warnings.
+
2017-01-19 Myles C. Maxfield
[Cocoa] Variation fonts are erroneously disabled on iOS
Modified: trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm (210932 => 210933)
--- trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2017-01-19 19:24:12 UTC (rev 210932)
+++ trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2017-01-19 19:25:56 UTC (rev 210933)
@@ -435,6 +435,8 @@
static PKPaymentAuthorizationStatus toPKPaymentAuthorizationStatus(WebCore::PaymentAuthorizationStatus status)
{
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
switch (status) {
case WebCore::PaymentAuthorizationStatus::Success:
return PKPaymentAuthorizationStatusSuccess;
@@ -453,6 +455,7 @@
case WebCore::PaymentAuthorizationStatus::PINLockout:
return PKPaymentAuthorizationStatusPINLockout;
}
+#pragma clang diagnostic pop
}
void WebPaymentCoordinatorProxy::platformCompletePaymentSession(WebCore::PaymentAuthorizationStatus status)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210934] trunk/Websites/webkit.org
Title: [210934] trunk/Websites/webkit.org Revision 210934 Author timo...@hatcher.name Date 2017-01-19 12:21:14 -0800 (Thu, 19 Jan 2017) Log Message Add Tesla to the domain associations on the team page https://bugs.webkit.org/show_bug.cgi?id=167202 Reviewed by Brian Burg. * wp-content/themes/webkit/team.php: Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/wp-content/themes/webkit/team.php Diff Modified: trunk/Websites/webkit.org/ChangeLog (210933 => 210934) --- trunk/Websites/webkit.org/ChangeLog 2017-01-19 19:25:56 UTC (rev 210933) +++ trunk/Websites/webkit.org/ChangeLog 2017-01-19 20:21:14 UTC (rev 210934) @@ -1,3 +1,12 @@ +2017-01-19 Timothy Hatcher + +Add Tesla to the domain associations on the team page +https://bugs.webkit.org/show_bug.cgi?id=167202 + +Reviewed by Brian Burg. + +* wp-content/themes/webkit/team.php: + 2016-12-22 Keith Miller Add BitOr for floating points to B3 Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/team.php (210933 => 210934) --- trunk/Websites/webkit.org/wp-content/themes/webkit/team.php 2017-01-19 19:25:56 UTC (rev 210933) +++ trunk/Websites/webkit.org/wp-content/themes/webkit/team.php 2017-01-19 20:21:14 UTC (rev 210934) @@ -114,6 +114,7 @@ 'samsung.com': 'Samsung Electronics', 'sencha.com': 'Sencha', 'sisa.samsung.com': 'Samsung Electronics', +'tesla.com': 'Tesla', 'torchmobile.com.cn': 'Torch Mobile (Beijing) Co. Ltd.', 'digia.com': 'Digia', 'partner.samsung.com': 'Samsung Electronics', @@ -244,4 +245,4 @@ - \ No newline at end of file + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210935] trunk/Source/JavaScriptCore
Title: [210935] trunk/Source/_javascript_Core Revision 210935 Author fpi...@apple.com Date 2017-01-19 12:53:42 -0800 (Thu, 19 Jan 2017) Log Message The mutator needs to fire a barrier after memmoving stuff around in an object that the GC scans https://bugs.webkit.org/show_bug.cgi?id=167208 Reviewed by Saam Barati. It used to be that if you moved a value from one place to another in the same object then there is no need for a barrier because the generational GC would have no need to know that some old object still continues to refer to the same other old object. But the concurrent GC might scan that object as the mutator moves pointers around in it. If the ordering is right, this could mean that the collector never sees some of those pointers. This can be fixed by adding a barrier. This fixes the most obvious cases I found. There may be more and I'll continue to audit. Most of the other memmove users seem to already use some kind of synchronization to prevent this. For example, this can also be fixed by just holding the cell lock around the memmove since we're dealing with indexing storage and the GC reads that under the cell lock. * runtime/JSArray.cpp: (JSC::JSArray::shiftCountWithAnyIndexingType): (JSC::JSArray::unshiftCountWithAnyIndexingType): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSArray.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (210934 => 210935) --- trunk/Source/_javascript_Core/ChangeLog 2017-01-19 20:21:14 UTC (rev 210934) +++ trunk/Source/_javascript_Core/ChangeLog 2017-01-19 20:53:42 UTC (rev 210935) @@ -1,3 +1,28 @@ +2017-01-19 Filip Pizlo + +The mutator needs to fire a barrier after memmoving stuff around in an object that the GC scans +https://bugs.webkit.org/show_bug.cgi?id=167208 + +Reviewed by Saam Barati. + +It used to be that if you moved a value from one place to another in the same object +then there is no need for a barrier because the generational GC would have no need to +know that some old object still continues to refer to the same other old object. + +But the concurrent GC might scan that object as the mutator moves pointers around in +it. If the ordering is right, this could mean that the collector never sees some of +those pointers. This can be fixed by adding a barrier. + +This fixes the most obvious cases I found. There may be more and I'll continue to +audit. Most of the other memmove users seem to already use some kind of synchronization +to prevent this. For example, this can also be fixed by just holding the cell lock +around the memmove since we're dealing with indexing storage and the GC reads that +under the cell lock. + +* runtime/JSArray.cpp: +(JSC::JSArray::shiftCountWithAnyIndexingType): +(JSC::JSArray::unshiftCountWithAnyIndexingType): + 2017-01-19 Myles C. Maxfield [Cocoa] Variation fonts are erroneously disabled on iOS Modified: trunk/Source/_javascript_Core/runtime/JSArray.cpp (210934 => 210935) --- trunk/Source/_javascript_Core/runtime/JSArray.cpp 2017-01-19 20:21:14 UTC (rev 210934) +++ trunk/Source/_javascript_Core/runtime/JSArray.cpp 2017-01-19 20:53:42 UTC (rev 210935) @@ -1021,6 +1021,11 @@ butterfly->contiguous()[i].clear(); butterfly->setPublicLength(oldLength - count); + +// Our memmoving of values around in the array could have concealed some of them from +// the collector. Let's make sure that the collector scans this object again. +vm.heap.writeBarrier(this); + return true; } @@ -1169,6 +1174,10 @@ butterfly->contiguous()[i + count].setWithoutWriteBarrier(v); } +// Our memmoving of values around in the array could have concealed some of them from +// the collector. Let's make sure that the collector scans this object again. +vm.heap.writeBarrier(this); + // NOTE: we're leaving being garbage in the part of the array that we shifted out // of. This is fine because the caller is required to store over that area, and // in contiguous mode storing into a hole is guaranteed to behave exactly the same ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210936] trunk/Source
Title: [210936] trunk/Source Revision 210936 Author cdu...@apple.com Date 2017-01-19 13:33:36 -0800 (Thu, 19 Jan 2017) Log Message Implement per activity state CPU usage reporting using diagnostic logging https://bugs.webkit.org/show_bug.cgi?id=167163 Reviewed by Andreas Kling. Implement per activity state CPU usage reporting using diagnostic logging. Source/WebCore: * WebCore.xcodeproj/project.pbxproj: * page/ActivityState.h: * page/ChromeClient.h: * page/DiagnosticLoggingKeys.cpp: (WebCore::DiagnosticLoggingKeys::nonVisibleStateKey): (WebCore::DiagnosticLoggingKeys::visibleNonActiveStateKey): (WebCore::DiagnosticLoggingKeys::visibleAndActiveStateKey): (WebCore::DiagnosticLoggingKeys::foregroundCPUUsageToDiagnosticLogginKey): (WebCore::DiagnosticLoggingKeys::backgroundCPUUsageToDiagnosticLogginKey): * page/DiagnosticLoggingKeys.h: * page/Page.cpp: (WebCore::isUtilityPageChromeClient): (WebCore::Page::Page): (WebCore::Page::~Page): (WebCore::Page::didStartProvisionalLoad): (WebCore::Page::didFinishLoad): (WebCore::Page::isUtilityPage): (WebCore::Page::setActivityState): (WebCore::Page::setIsVisibleInternal): * page/Page.h: (WebCore::Page::activityState): (WebCore::Page::isUtilityPage): * page/PerformanceMonitor.cpp: Added. (WebCore::activityStateForCPUSampling): (WebCore::PerformanceMonitor::PerformanceMonitor): (WebCore::PerformanceMonitor::didStartProvisionalLoad): (WebCore::PerformanceMonitor::didFinishLoad): (WebCore::PerformanceMonitor::activityStateChanged): (WebCore::PerformanceMonitor::measurePostLoadCPUUsage): (WebCore::PerformanceMonitor::measurePostBackgroundingCPUUsage): (WebCore::PerformanceMonitor::measurePerActivityStateCPUUsage): (WebCore::stringForCPUSamplingActivityState): (WebCore::PerformanceMonitor::measureCPUUsageInActivityState): * page/PerformanceMonitor.h: Copied from Source/WebCore/page/ActivityState.h. * page/Settings.cpp: * page/Settings.h: (WebCore::Settings::isPostLoadCPUUsageMeasurementEnabled): (WebCore::Settings::isPostBackgroundingCPUUsageMeasurementEnabled): (WebCore::Settings::isPerActivityStateCPUUsageMeasurementEnabled): Source/WebKit2: * Platform/Logging.h: * UIProcess/PerActivityStateCPUUsageSampler.cpp: Added. (WebKit::PerActivityStateCPUUsageSampler::PerActivityStateCPUUsageSampler): (WebKit::PerActivityStateCPUUsageSampler::~PerActivityStateCPUUsageSampler): (WebKit::PerActivityStateCPUUsageSampler::reportWebContentCPUTime): (WebKit::loggingKeyForActivityState): (WebKit::loggingKeyForCPUUsage): (WebKit::PerActivityStateCPUUsageSampler::loggingTimerFired): (WebKit::PerActivityStateCPUUsageSampler::pageForLogging): * UIProcess/PerActivityStateCPUUsageSampler.h: Copied from Source/WebCore/page/ActivityState.h. * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::WebProcessPool): (WebKit::WebProcessPool::reportWebContentCPUTime): * UIProcess/WebProcessPool.h: * UIProcess/WebProcessPool.messages.in: * WebKit2.xcodeproj/project.pbxproj: * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::reportProcessCPUTime): * WebProcess/WebCoreSupport/WebChromeClient.h: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/page/ActivityState.h trunk/Source/WebCore/page/ChromeClient.h trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp trunk/Source/WebCore/page/DiagnosticLoggingKeys.h trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h trunk/Source/WebCore/page/Settings.cpp trunk/Source/WebCore/page/Settings.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Platform/Logging.h trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp trunk/Source/WebKit2/UIProcess/WebProcessPool.h trunk/Source/WebKit2/UIProcess/WebProcessPool.messages.in trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h Added Paths trunk/Source/WebCore/page/PerformanceMonitor.cpp trunk/Source/WebCore/page/PerformanceMonitor.h trunk/Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp trunk/Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (210935 => 210936) --- trunk/Source/WebCore/CMakeLists.txt 2017-01-19 20:53:42 UTC (rev 210935) +++ trunk/Source/WebCore/CMakeLists.txt 2017-01-19 21:33:36 UTC (rev 210936) @@ -1986,6 +1986,7 @@ page/Performance.cpp page/PerformanceEntry.cpp page/PerformanceLogging.cpp +page/PerformanceMonitor.cpp page/PerformanceNavigation.cpp page/PerformanceResourceTiming.cpp page/PerformanceTiming.cpp Modified: trunk/Source/WebCore/ChangeLog (210935 => 210936) --- trunk/Source/WebCore/ChangeLog 2017-01-19 20:53:42 UTC (rev 210935) +++ trunk/Source/WebCore/ChangeLog 2017-01-19 21:33:36 UTC (rev 210936) @@ -1,3 +1,53 @@ +2017-01-19 Chris Dumez + +Implement per activity state CPU usag
[webkit-changes] [210937] trunk/LayoutTests
Title: [210937] trunk/LayoutTests Revision 210937 Author ryanhad...@apple.com Date 2017-01-19 13:35:10 -0800 (Thu, 19 Jan 2017) Log Message Skipping three crashing pointer lock tests. https://bugs.webkit.org/show_bug.cgi?id=166765 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (210936 => 210937) --- trunk/LayoutTests/ChangeLog 2017-01-19 21:33:36 UTC (rev 210936) +++ trunk/LayoutTests/ChangeLog 2017-01-19 21:35:10 UTC (rev 210937) @@ -1,3 +1,12 @@ +2017-01-19 Ryan Haddad + +Skipping three crashing pointer lock tests. +https://bugs.webkit.org/show_bug.cgi?id=166765 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2017-01-18 Sam Weinig [WebIDL] Records should preserve _javascript_ object order Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (210936 => 210937) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-01-19 21:33:36 UTC (rev 210936) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-01-19 21:35:10 UTC (rev 210937) @@ -605,6 +605,6 @@ webkit.org/b/165392 [ ElCapitan Release ] imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html [ Pass Failure ] -webkit.org/b/166765 [ Debug ] http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html [ Crash ] -webkit.org/b/166765 [ Debug ] http/tests/pointer-lock/pointerlockelement-same-origin.html [ Crash ] -webkit.org/b/166765 [ Debug ] pointer-lock/lock-lost-on-alert.html [ Crash ] +webkit.org/b/166765 [ Debug ] http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html [ Skip ] +webkit.org/b/166765 [ Debug ] http/tests/pointer-lock/pointerlockelement-same-origin.html [ Skip ] +webkit.org/b/166765 [ Debug ] pointer-lock/lock-lost-on-alert.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210938] trunk/Websites/perf.webkit.org
Title: [210938] trunk/Websites/perf.webkit.org Revision 210938 Author rn...@webkit.org Date 2017-01-19 14:58:46 -0800 (Thu, 19 Jan 2017) Log Message Add a mechanism to dispatch and listen to an action https://bugs.webkit.org/show_bug.cgi?id=167191 Reviewed by Antti Koivisto. Added the notion of an action to components. Like DOM events, it can be dispatched or listen to. Also added ComponentBase.prototype.part which finds a sub-component inside a component's shadow tree, and made ComponentBase.prototype.content take an id to find an element that matches it. * browser-tests/close-button-tests.js: Added. Tests for CloseButton. * browser-tests/component-base-tests.js: Added tests for ComponentBase's part(~), content(id), dispatchEvent. * browser-tests/index.html: * public/v3/components/base.js: (ComponentBase): Added this._actionCallbacks, which is a map of an action name to a callback to be invoked. (ComponentBase.prototype.content): Return an element of the given id if one is specified. (ComponentBase.prototype.part): Find a component whose element has the matching id. (ComponentBase.prototype.dispatchAction): Added. (ComponentBase.prototype.listenToAction): Added. (ComponentBase.prototype._ensureShadowTree): Call didConstructShadowTree. (ComponentBase.prototype.didConstructShadowTree): Added. (ComponentBase.prototype._recursivelyReplaceUnknownElementsByComponents): Copy attributes when instantiating an element for a component when the browser doesn't support custom elements API. (ComponentBase.createLink): (ComponentBase.prototype.createEventHandler): Added. (ComponentBase.createEventHandler): Renamed from createActionHandler. * public/v3/components/button-base.js: (ButtonBase.prototype.didConstructShadowTree): Added. Dispatch "activate" action when the button is clicked. (ButtonBase.prototype.setCallback): Deleted. (ButtonBase.htmlTemplate): Use id instead of class so that this.content() can find it. (ButtonBase.cssTemplate): Updated style rules. * public/v3/pages/chart-pane.js: (ChartPane): (ChartPane.prototype.didConstructShadowTree): Added. Listen to "activate" action on the close button. (ChartPane.prototype.render): Fixed a bug that we were never calling enqueueToRender on the close button. (ChartPane.htmlTemplate): Add the id on the close button. Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/browser-tests/component-base-tests.js trunk/Websites/perf.webkit.org/browser-tests/index.html trunk/Websites/perf.webkit.org/public/v3/components/base.js trunk/Websites/perf.webkit.org/public/v3/components/button-base.js trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js Added Paths trunk/Websites/perf.webkit.org/browser-tests/close-button-tests.js Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (210937 => 210938) --- trunk/Websites/perf.webkit.org/ChangeLog 2017-01-19 21:35:10 UTC (rev 210937) +++ trunk/Websites/perf.webkit.org/ChangeLog 2017-01-19 22:58:46 UTC (rev 210938) @@ -1,3 +1,42 @@ +2017-01-18 Ryosuke Niwa + +Add a mechanism to dispatch and listen to an action +https://bugs.webkit.org/show_bug.cgi?id=167191 + +Reviewed by Antti Koivisto. + +Added the notion of an action to components. Like DOM events, it can be dispatched or listen to. + +Also added ComponentBase.prototype.part which finds a sub-component inside a component's shadow tree, +and made ComponentBase.prototype.content take an id to find an element that matches it. + +* browser-tests/close-button-tests.js: Added. Tests for CloseButton. +* browser-tests/component-base-tests.js: Added tests for ComponentBase's part(~), content(id), dispatchEvent. +* browser-tests/index.html: +* public/v3/components/base.js: +(ComponentBase): Added this._actionCallbacks, which is a map of an action name to a callback to be invoked. +(ComponentBase.prototype.content): Return an element of the given id if one is specified. +(ComponentBase.prototype.part): Find a component whose element has the matching id. +(ComponentBase.prototype.dispatchAction): Added. +(ComponentBase.prototype.listenToAction): Added. +(ComponentBase.prototype._ensureShadowTree): Call didConstructShadowTree. +(ComponentBase.prototype.didConstructShadowTree): Added. +(ComponentBase.prototype._recursivelyReplaceUnknownElementsByComponents): Copy attributes when instantiating +an element for a component when the browser doesn't support custom elements API. +(ComponentBase.createLink): +(ComponentBase.prototype.createEventHandler): Added. +(ComponentBase.createEventHandler): Renamed from createActionHandler. +* public/v3/components/button-base.js: +(ButtonBase.prototype.didConstructShadowTree): Added. Dispatch "activate" action when the button is clicked. +(ButtonBase.prototype.setCallback): Deleted. +(Button
[webkit-changes] [210939] trunk
Title: [210939] trunk Revision 210939 Author cdu...@apple.com Date 2017-01-19 15:04:37 -0800 (Thu, 19 Jan 2017) Log Message Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached https://bugs.webkit.org/show_bug.cgi?id=167215 Reviewed by Andreas Kling. Source/WebCore: Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached and that we do not crash. Tests: fast/forms/validation-message-detached-iframe.html fast/forms/validation-message-detached-iframe2.html * dom/Document.cpp: (WebCore::Document::prepareForDestruction): * page/ValidationMessageClient.h: Source/WebKit/mac: Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached and that we do not crash. * WebCoreSupport/WebValidationMessageClient.h: * WebCoreSupport/WebValidationMessageClient.mm: (WebValidationMessageClient::documentDetached): Source/WebKit2: Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached and that we do not crash. * WebProcess/WebCoreSupport/WebValidationMessageClient.cpp: (WebKit::WebValidationMessageClient::documentDetached): * WebProcess/WebCoreSupport/WebValidationMessageClient.h: LayoutTests: Add layout test coverage. * fast/forms/resources/form-validation-iframe.html: Added. * fast/forms/validation-message-detached-iframe-expected.txt: Added. * fast/forms/validation-message-detached-iframe.html: Added. * fast/forms/validation-message-detached-iframe2-expected.txt: Added. * fast/forms/validation-message-detached-iframe2.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/page/ValidationMessageClient.h trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.h trunk/Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebValidationMessageClient.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebValidationMessageClient.h Added Paths trunk/LayoutTests/fast/forms/resources/form-validation-iframe.html trunk/LayoutTests/fast/forms/validation-message-detached-iframe-expected.txt trunk/LayoutTests/fast/forms/validation-message-detached-iframe.html trunk/LayoutTests/fast/forms/validation-message-detached-iframe2-expected.txt trunk/LayoutTests/fast/forms/validation-message-detached-iframe2.html Diff Modified: trunk/LayoutTests/ChangeLog (210938 => 210939) --- trunk/LayoutTests/ChangeLog 2017-01-19 22:58:46 UTC (rev 210938) +++ trunk/LayoutTests/ChangeLog 2017-01-19 23:04:37 UTC (rev 210939) @@ -1,3 +1,19 @@ +2017-01-19 Chris Dumez + +Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached +https://bugs.webkit.org/show_bug.cgi?id=167215 + + +Reviewed by Andreas Kling. + +Add layout test coverage. + +* fast/forms/resources/form-validation-iframe.html: Added. +* fast/forms/validation-message-detached-iframe-expected.txt: Added. +* fast/forms/validation-message-detached-iframe.html: Added. +* fast/forms/validation-message-detached-iframe2-expected.txt: Added. +* fast/forms/validation-message-detached-iframe2.html: Added. + 2017-01-19 Ryan Haddad Skipping three crashing pointer lock tests. Added: trunk/LayoutTests/fast/forms/resources/form-validation-iframe.html (0 => 210939) --- trunk/LayoutTests/fast/forms/resources/form-validation-iframe.html (rev 0) +++ trunk/LayoutTests/fast/forms/resources/form-validation-iframe.html 2017-01-19 23:04:37 UTC (rev 210939) @@ -0,0 +1,8 @@ + + + + + Required text input: + + + Added: trunk/LayoutTests/fast/forms/validation-message-detached-iframe-expected.txt (0 => 210939) --- trunk/LayoutTests/fast/forms/validation-message-detached-iframe-expected.txt (rev 0) +++ trunk/LayoutTests/fast/forms/validation-message-detached-iframe-expected.txt 2017-01-19 23:04:37 UTC (rev 210939) @@ -0,0 +1,9 @@ +Tests that the form validation message goes away when its element's iframe gets detached. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + +PASS validationBubbleContents.message is "" +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/forms/validation-message-detached-iframe.html (0 => 210939) --- trunk/LayoutTests/fast/forms/validation-message-detached-iframe.html (rev 0) +++ trunk/LayoutTests/fast/forms/validation-message-detached-iframe.html 2017-01-19 23:04:37 UTC (rev 210939) @@ -0,0 +1,37 @@ + + + +