date:20170208

[webkit-changes] [211929] trunk/Source

2017-02-08 Thread simon . fraser

Title: [211929] trunk/Source








Revision 211929
Author simon.fra...@apple.com
Date 2017-02-08 21:22:51 -0800 (Wed, 08 Feb 2017)


Log Message
Put names on more UIViews for ease of debugging
https://bugs.webkit.org/show_bug.cgi?id=168035

Reviewed by Tim Horton.

Source/WebCore:

Name the page overlay layers.

* page/PageOverlayController.cpp:
(WebCore::PageOverlayController::createRootLayersIfNeeded):
(WebCore::PageOverlayController::installPageOverlay):

Source/WebKit2:

Put names on the various bare UIViews that we create.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setHasCustomContentView:loadedMIMEType:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
* UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::showPaintRect):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PageOverlayController.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm
trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (211928 => 211929)

--- trunk/Source/WebCore/ChangeLog	2017-02-09 05:10:11 UTC (rev 211928)
+++ trunk/Source/WebCore/ChangeLog	2017-02-09 05:22:51 UTC (rev 211929)
@@ -1,3 +1,16 @@
+2017-02-08  Simon Fraser  
+
+Put names on more UIViews for ease of debugging
+https://bugs.webkit.org/show_bug.cgi?id=168035
+
+Reviewed by Tim Horton.
+
+Name the page overlay layers.
+
+* page/PageOverlayController.cpp:
+(WebCore::PageOverlayController::createRootLayersIfNeeded):
+(WebCore::PageOverlayController::installPageOverlay):
+
 2017-02-08  Commit Queue  
 
 Unreviewed, rolling out r211912.


Modified: trunk/Source/WebCore/page/PageOverlayController.cpp (211928 => 211929)

--- trunk/Source/WebCore/page/PageOverlayController.cpp	2017-02-09 05:10:11 UTC (rev 211928)
+++ trunk/Source/WebCore/page/PageOverlayController.cpp	2017-02-09 05:22:51 UTC (rev 211929)
@@ -66,10 +66,8 @@
 
 m_documentOverlayRootLayer = GraphicsLayer::create(m_mainFrame.page()->chrome().client().graphicsLayerFactory(), *this);
 m_viewOverlayRootLayer = GraphicsLayer::create(m_mainFrame.page()->chrome().client().graphicsLayerFactory(), *this);
-#ifndef NDEBUG
-m_documentOverlayRootLayer->setName("Page Overlay container (document-relative)");
-m_viewOverlayRootLayer->setName("Page Overlay container (view-relative)");
-#endif
+m_documentOverlayRootLayer->setName("Document overlay Container");
+m_viewOverlayRootLayer->setName("View overlay container");
 }
 
 GraphicsLayer* PageOverlayController::documentOverlayRootLayer() const
@@ -149,9 +147,7 @@
 std::unique_ptr layer = GraphicsLayer::create(m_mainFrame.page()->chrome().client().graphicsLayerFactory(), *this);
 layer->setAnchorPoint(FloatPoint3D());
 layer->setBackgroundColor(overlay.backgroundColor());
-#ifndef NDEBUG
-layer->setName("Page Overlay content");
-#endif
+layer->setName("Overlay content");
 
 updateSettingsForLayer(*layer);
 


Modified: trunk/Source/WebKit2/ChangeLog (211928 => 211929)

--- trunk/Source/WebKit2/ChangeLog	2017-02-09 05:10:11 UTC (rev 211928)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-09 05:22:51 UTC (rev 211929)
@@ -1,3 +1,26 @@
+2017-02-08  Simon Fraser  
+
+Put names on more UIViews for ease of debugging
+https://bugs.webkit.org/show_bug.cgi?id=168035
+
+Reviewed by Tim Horton.
+
+Put names on the various bare UIViews that we create.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _setHasCustomContentView:loadedMIMEType:]):
+(-[WKWebView _beginAnimatedResizeWithUpdates:]):
+* UIProcess/ios/ViewGestureControllerIOS.mm:
+(WebKit::ViewGestureController::beginSwipeGesture):
+* UIProcess/ios/WKContentView.mm:
+(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView setupInteraction]):
+* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+(WebKit::WebInspectorClient::showPaintRect):
+* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
+

[webkit-changes] [211927] trunk

2017-02-08 Thread commit-queue

Title: [211927] trunk








Revision 211927
Author commit-qu...@webkit.org
Date 2017-02-08 20:49:25 -0800 (Wed, 08 Feb 2017)


Log Message
Unreviewed, rolling out r211912.
https://bugs.webkit.org/show_bug.cgi?id=168034

http/tests/media/media-stream/disconnected-frame-permission-
denied.html should be updated (Requested by youenn on
#webkit).

Reverted changeset:

"[MediaStream] Remove legacy Navigator.webkitGetUserMedia"
https://bugs.webkit.org/show_bug.cgi?id=168016
http://trac.webkit.org/changeset/211912

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html
trunk/LayoutTests/fast/mediastream/delayed-permission-allowed.html
trunk/LayoutTests/fast/mediastream/delayed-permission-denied.html
trunk/LayoutTests/fast/mediastream/enabled-expected.txt
trunk/LayoutTests/fast/mediastream/error.html
trunk/LayoutTests/fast/mediastream/script-tests/enabled.js
trunk/LayoutTests/fast/mediastream/success.html
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.cpp
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/page/Navigator.idl
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js


Added Paths

trunk/LayoutTests/fast/mediastream/argument-types.html
trunk/LayoutTests/fast/mediastream/getusermedia.html
trunk/LayoutTests/fast/mediastream/script-tests/argument-types.js
trunk/LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then.html
trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.idl
trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.js




Diff

Modified: trunk/LayoutTests/ChangeLog (211926 => 211927)

--- trunk/LayoutTests/ChangeLog	2017-02-09 02:50:00 UTC (rev 211926)
+++ trunk/LayoutTests/ChangeLog	2017-02-09 04:49:25 UTC (rev 211927)
@@ -1,3 +1,18 @@
+2017-02-08  Commit Queue  
+
+Unreviewed, rolling out r211912.
+https://bugs.webkit.org/show_bug.cgi?id=168034
+
+http/tests/media/media-stream/disconnected-frame-permission-
+denied.html should be updated (Requested by youenn on
+#webkit).
+
+Reverted changeset:
+
+"[MediaStream] Remove legacy Navigator.webkitGetUserMedia"
+https://bugs.webkit.org/show_bug.cgi?id=168016
+http://trac.webkit.org/changeset/211912
+
 2017-02-08  Youenn Fablet  
 
 HTML Link elements should load data URLs as same origin


Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html (211926 => 211927)

--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html	2017-02-09 02:50:00 UTC (rev 211926)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html	2017-02-09 04:49:25 UTC (rev 211927)
@@ -2,7 +2,6 @@
 
 
 -