[webkit-changes] [214394] trunk
Title: [214394] trunk Revision 214394 Author mmaxfi...@apple.com Date 2017-03-24 23:50:18 -0700 (Fri, 24 Mar 2017) Log Message Add font-optical-sizing to CSSComputedStyleDeclaration https://bugs.webkit.org/show_bug.cgi?id=170083 Reviewed by Joseph Pecoraro. Source/WebCore: Covered by existing tests. * css/CSSComputedStyleDeclaration.cpp: LayoutTests: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-font-family-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * fast/css/getComputedStyle/resources/property-names.js: * fast/text/variations/optical-sizing-expected.txt: * fast/text/variations/optical-sizing.html: * platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-expected.txt: Added. * platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added. * platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js trunk/LayoutTests/fast/text/variations/optical-sizing-expected.txt trunk/LayoutTests/fast/text/variations/optical-sizing.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp Added Paths trunk/LayoutTests/platform/mac-elcapitan/fast/css/getComputedStyle/ trunk/LayoutTests/platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-font-family-expected.txt trunk/LayoutTests/platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (214393 => 214394) --- trunk/LayoutTests/ChangeLog 2017-03-25 05:34:02 UTC (rev 214393) +++ trunk/LayoutTests/ChangeLog 2017-03-25 06:50:18 UTC (rev 214394) @@ -1,3 +1,20 @@ +2017-03-24 Myles C. Maxfield + +Add font-optical-sizing to CSSComputedStyleDeclaration +https://bugs.webkit.org/show_bug.cgi?id=170083 + +Reviewed by Joseph Pecoraro. + +* fast/css/getComputedStyle/computed-style-expected.txt: +* fast/css/getComputedStyle/computed-style-font-family-expected.txt: +* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* fast/css/getComputedStyle/resources/property-names.js: +* fast/text/variations/optical-sizing-expected.txt: +* fast/text/variations/optical-sizing.html: +* platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-expected.txt: Added. +* platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added. +* platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added. + 2017-03-24 Ryan Haddad Consolidate TestExpectations for media/restore-from-page-cache.html. Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (214393 => 214394) --- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2017-03-25 05:34:02 UTC (rev 214393) +++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2017-03-25 06:50:18 UTC (rev 214394) @@ -50,6 +50,7 @@ font-synthesis: style weight small-caps; font-variant: normal; font-weight: normal; +font-optical-sizing: auto; hanging-punctuation: none; height: 576px; image-rendering: auto; Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt (214393 => 214394) --- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt 2017-03-25 05:34:02 UTC (rev 214393) +++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt 2017-03-25 06:50:18 UTC (rev 214394) @@ -7,6 +7,7 @@ font-synthesis: style weight small-caps; font-variant: normal; font-weight: normal; +font-optical-sizing: auto; font-variant-ligatures: normal; font-variant-position: normal; font-variant-caps: normal; Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (214393 => 214394) --- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2017-03-25 05:34:02 UTC (rev 214393) +++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2017-03-25 06:50:18 UTC (rev 214394) @@ -49,6 +49,7 @@ font-synthesis: style weight small-caps font-variant: normal font-weight: normal +font-optical-sizing: auto hanging-punctuation: none height: 100px image-rendering: auto Modified: trunk/LayoutTests/fast/css/getComputedStyle/resources
[webkit-changes] [214393] trunk/Source/JavaScriptCore
Title: [214393] trunk/Source/_javascript_Core
Revision 214393
Author mark@apple.com
Date 2017-03-24 22:34:02 -0700 (Fri, 24 Mar 2017)
Log Message
Add some instrumentation in Heap::resumeThePeriphery() to help debug an issue.
https://bugs.webkit.org/show_bug.cgi?id=170086
Reviewed by Saam Barati.
Adding some instrumentation in Heap::resumeThePeriphery() to dump some Heap state
just before we RELEASE_ASSERT_NOT_REACHED.
* heap/Heap.cpp:
(JSC::Heap::resumeThePeriphery):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (214392 => 214393)
--- trunk/Source/_javascript_Core/ChangeLog 2017-03-25 01:13:23 UTC (rev 214392)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-03-25 05:34:02 UTC (rev 214393)
@@ -1,3 +1,17 @@
+2017-03-24 Mark Lam
+
+Add some instrumentation in Heap::resumeThePeriphery() to help debug an issue.
+https://bugs.webkit.org/show_bug.cgi?id=170086
+
+
+Reviewed by Saam Barati.
+
+Adding some instrumentation in Heap::resumeThePeriphery() to dump some Heap state
+just before we RELEASE_ASSERT_NOT_REACHED.
+
+* heap/Heap.cpp:
+(JSC::Heap::resumeThePeriphery):
+
2017-03-24 JF Bastien
WebAssembly: store state in TLS instead of on VM
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (214392 => 214393)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2017-03-25 01:13:23 UTC (rev 214392)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2017-03-25 05:34:02 UTC (rev 214393)
@@ -1499,6 +1499,30 @@
if (!m_collectorBelievesThatTheWorldIsStopped) {
dataLog("Fatal: collector does not believe that the world is stopped.\n");
+#if OS(DARWIN)
+// FIXME: Remove this when no longer needed.
+// https://bugs.webkit.org/show_bug.cgi?id=170094
+#if CPU(X86_64)
+unsigned worldState = m_worldState.load();
+asm volatile(
+"int3"
+:
+: "a"(m_currentPhase), "b"(m_nextPhase), "c"(worldState), "S"(m_lastServedTicket), "D"(m_lastGrantedTicket)
+: "memory");
+#elif CPU(ARM64)
+unsigned worldState = m_worldState.load();
+asm volatile(
+"ldrb w0, %0\n"
+"ldrb w1, %1\n"
+"ldr w2, %2\n"
+"ldr x3, %3\n"
+"ldr x4, %4\n"
+"brk #0"
+:
+: "m"(m_currentPhase), "m"(m_nextPhase), "m"(worldState), "m"(m_lastServedTicket), "m"(m_lastGrantedTicket)
+: "memory");
+#endif
+#endif // OS(DARWIN)
RELEASE_ASSERT_NOT_REACHED();
}
m_collectorBelievesThatTheWorldIsStopped = false;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [214392] trunk/Source/WebCore
Title: [214392] trunk/Source/WebCore
Revision 214392
Author dba...@webkit.org
Date 2017-03-24 18:13:23 -0700 (Fri, 24 Mar 2017)
Log Message
media/restore-from-page-cache.html causes NoEventDispatchAssertion::isEventAllowedInMainThread() assertion failure
https://bugs.webkit.org/show_bug.cgi?id=170087
Reviewed by Simon Fraser.
Reduce the scope of code that should never dispatch DOM events so as to allow updating contents size
after restoring a page from the page cache.
In r214014 we instantiate a NoEventDispatchAssertion in FrameLoader::commitProvisionalLoad()
around the call to CachedPage::restore() to assert when a DOM event is dispatched during
page restoration as such events can cause re-entrancy into the page cache. As it turns out
it is sufficient to ensure that no DOM events are dispatched after restoring all cached frames
as opposed to after CachedPage::restore() returns.
Also rename Document::enqueue{Pageshow, Popstate}Event() to dispatch{Pageshow, Popstate}Event(),
respectively, since they synchronously dispatch events :(. We hope in the future to make them
asynchronously dispatch events.
* dom/Document.cpp:
(WebCore::Document::implicitClose): Update for renaming.
(WebCore::Document::statePopped): Ditto.
(WebCore::Document::dispatchPageshowEvent): Renamed; formerly named enqueuePageshowEvent().
(WebCore::Document::dispatchPopstateEvent): Renamed; formerly named enqueuePopstateEvent().
(WebCore::Document::enqueuePageshowEvent): Deleted.
(WebCore::Document::enqueuePopstateEvent): Deleted.
* dom/Document.h:
* history/CachedPage.cpp:
(WebCore::firePageShowAndPopStateEvents): Moved logic from FrameLoader::didRestoreFromCachedPage() to here.
(WebCore::CachedPage::restore): Modified to call firePageShowAndPopStateEvents().
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad): Removed use of NoEventDispatchAssertion RAII object. We
will instantiate it in CachedPage::restore() with a smaller scope.
(WebCore::FrameLoader::didRestoreFromCachedPage): Deleted; moved logic from here to WebCore::firePageShowAndPopStateEvents().
* loader/FrameLoader.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/history/CachedPage.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (214391 => 214392)
--- trunk/Source/WebCore/ChangeLog 2017-03-25 01:04:32 UTC (rev 214391)
+++ trunk/Source/WebCore/ChangeLog 2017-03-25 01:13:23 UTC (rev 214392)
@@ -1,3 +1,41 @@
+2017-03-24 Daniel Bates
+
+media/restore-from-page-cache.html causes NoEventDispatchAssertion::isEventAllowedInMainThread() assertion failure
+https://bugs.webkit.org/show_bug.cgi?id=170087
+
+
+Reviewed by Simon Fraser.
+
+Reduce the scope of code that should never dispatch DOM events so as to allow updating contents size
+after restoring a page from the page cache.
+
+In r214014 we instantiate a NoEventDispatchAssertion in FrameLoader::commitProvisionalLoad()
+around the call to CachedPage::restore() to assert when a DOM event is dispatched during
+page restoration as such events can cause re-entrancy into the page cache. As it turns out
+it is sufficient to ensure that no DOM events are dispatched after restoring all cached frames
+as opposed to after CachedPage::restore() returns.
+
+Also rename Document::enqueue{Pageshow, Popstate}Event() to dispatch{Pageshow, Popstate}Event(),
+respectively, since they synchronously dispatch events :(. We hope in the future to make them
+asynchronously dispatch events.
+
+* dom/Document.cpp:
+(WebCore::Document::implicitClose): Update for renaming.
+(WebCore::Document::statePopped): Ditto.
+(WebCore::Document::dispatchPageshowEvent): Renamed; formerly named enqueuePageshowEvent().
+(WebCore::Document::dispatchPopstateEvent): Renamed; formerly named enqueuePopstateEvent().
+(WebCore::Document::enqueuePageshowEvent): Deleted.
+(WebCore::Document::enqueuePopstateEvent): Deleted.
+* dom/Document.h:
+* history/CachedPage.cpp:
+(WebCore::firePageShowAndPopStateEvents): Moved logic from FrameLoader::didRestoreFromCachedPage() to here.
+(WebCore::CachedPage::restore): Modified to call firePageShowAndPopStateEvents().
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::commitProvisionalLoad): Removed use of NoEventDispatchAssertion RAII object. We
+will instantiate it in CachedPage::restore() with a smaller scope.
+(WebCore::FrameLoader::didRestoreFromCachedPage): Deleted; moved logic from here to WebCore::firePageShowAndPopStateEvents().
+* loader/FrameLoader.h:
+
2017-03-24 Ryan Haddad
Unreviewed, rolling out r214361.
Modified: trunk/Source/WebCore/dom/Document.cpp (21
[webkit-changes] [214391] trunk/Source/WebKit2
Title: [214391] trunk/Source/WebKit2
Revision 214391
Author simon.fra...@apple.com
Date 2017-03-24 18:04:32 -0700 (Fri, 24 Mar 2017)
Log Message
[iOS WK2] Move from a pre-commit handler to dispatch_async for visible content rect updates
https://bugs.webkit.org/show_bug.cgi?id=170091
rdar://problem/30682584
Reviewed by Tim Horton.
[CATransaction addCommitHandler:forPhase:] is sometimes not called when running inside another
commit callback (rdar://problem/31253952), and we don't yet have a reliable way to detect this.
So dispatch_async() to postpone the call to [CATransaction addCommitHandler:forPhase:] to a known-
good time.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (214390 => 214391)
--- trunk/Source/WebKit2/ChangeLog 2017-03-25 00:39:20 UTC (rev 214390)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-25 01:04:32 UTC (rev 214391)
@@ -1,3 +1,20 @@
+2017-03-24 Simon Fraser
+
+[iOS WK2] Move from a pre-commit handler to dispatch_async for visible content rect updates
+https://bugs.webkit.org/show_bug.cgi?id=170091
+rdar://problem/30682584
+
+Reviewed by Tim Horton.
+
+[CATransaction addCommitHandler:forPhase:] is sometimes not called when running inside another
+commit callback (rdar://problem/31253952), and we don't yet have a reliable way to detect this.
+
+So dispatch_async() to postpone the call to [CATransaction addCommitHandler:forPhase:] to a known-
+good time.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):
+
2017-03-24 John Wilander
Re-enable the network process' keychain access to fix client certificate authentication
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (214390 => 214391)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-03-25 00:39:20 UTC (rev 214390)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-03-25 01:04:32 UTC (rev 214391)
@@ -288,7 +288,7 @@
RetainPtr _passwordView;
-BOOL _hasInstalledPreCommitHandlerForVisibleRectUpdate;
+BOOL _hasScheduledVisibleRectUpdate;
BOOL _visibleContentRectUpdateScheduledFromScrollViewInStableState;
Vector> _visibleContentRectUpdateCallbacks;
#endif
@@ -2301,16 +2301,19 @@
{
_visibleContentRectUpdateScheduledFromScrollViewInStableState = [self _scrollViewIsInStableState:scrollView];
-if (_hasInstalledPreCommitHandlerForVisibleRectUpdate)
+if (_hasScheduledVisibleRectUpdate)
return;
-_hasInstalledPreCommitHandlerForVisibleRectUpdate = YES;
-
-[CATransaction addCommitHandler:[retainedSelf = retainPtr(self)] {
-WKWebView *webView = retainedSelf.get();
-[webView _updateVisibleContentRects];
-webView->_hasInstalledPreCommitHandlerForVisibleRectUpdate = NO;
-} forPhase:kCATransactionPhasePreCommit];
+_hasScheduledVisibleRectUpdate = YES;
+
+// FIXME: remove the dispatch_async() when we have a fix for rdar://problem/31253952.
+dispatch_async(dispatch_get_main_queue(), [retainedSelf = retainPtr(self)] {
+[CATransaction addCommitHandler:[retainedSelf] {
+WKWebView *webView = retainedSelf.get();
+[webView _updateVisibleContentRects];
+webView->_hasScheduledVisibleRectUpdate = NO;
+} forPhase:kCATransactionPhasePreCommit];
+});
}
static bool scrollViewCanScroll(UIScrollView *scrollView)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [214390] trunk/LayoutTests
Title: [214390] trunk/LayoutTests Revision 214390 Author ryanhad...@apple.com Date 2017-03-24 17:39:20 -0700 (Fri, 24 Mar 2017) Log Message Consolidate TestExpectations for media/restore-from-page-cache.html. Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (214389 => 214390) --- trunk/LayoutTests/ChangeLog 2017-03-25 00:12:55 UTC (rev 214389) +++ trunk/LayoutTests/ChangeLog 2017-03-25 00:39:20 UTC (rev 214390) @@ -1,5 +1,13 @@ 2017-03-24 Ryan Haddad +Consolidate TestExpectations for media/restore-from-page-cache.html. + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +2017-03-24 Ryan Haddad + Unreviewed, rolling out r214361. This change caused flakiness in http/tests/preload tests. Modified: trunk/LayoutTests/platform/mac/TestExpectations (214389 => 214390) --- trunk/LayoutTests/platform/mac/TestExpectations 2017-03-25 00:12:55 UTC (rev 214389) +++ trunk/LayoutTests/platform/mac/TestExpectations 2017-03-25 00:39:20 UTC (rev 214390) @@ -1365,10 +1365,8 @@ webkit.org/b/159379 fast/history/page-cache-webdatabase-pending-transaction.html [ Pass Failure ] -webkit.org/b/158747 media/restore-from-page-cache.html [ Pass Failure ] - # rdar://problem/31243824 -[ Debug ] media/restore-from-page-cache.html [ Pass Crash Failure ] +webkit.org/b/158747 media/restore-from-page-cache.html [ Pass Failure Crash ] # See also https://bugs.webkit.org/show_bug.cgi?id=162494 webkit.org/b/151287 [ ElCapitan+ ] media/controls/inline-elements-dropoff-order.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [214389] trunk/Source/WebKit2
Title: [214389] trunk/Source/WebKit2 Revision 214389 Author wilan...@apple.com Date 2017-03-24 17:12:55 -0700 (Fri, 24 Mar 2017) Log Message Re-enable the network process' keychain access to fix client certificate authentication https://bugs.webkit.org/show_bug.cgi?id=170074 Reviewed by Brent Fulgham. * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: Reverted remaining change from https://trac.webkit.org/changeset/208702/webkit and https://trac.webkit.org/changeset/208707/webkit. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in Diff Modified: trunk/Source/WebKit2/ChangeLog (214388 => 214389) --- trunk/Source/WebKit2/ChangeLog 2017-03-25 00:10:06 UTC (rev 214388) +++ trunk/Source/WebKit2/ChangeLog 2017-03-25 00:12:55 UTC (rev 214389) @@ -1,3 +1,16 @@ +2017-03-24 John Wilander + +Re-enable the network process' keychain access to fix client certificate authentication +https://bugs.webkit.org/show_bug.cgi?id=170074 + + +Reviewed by Brent Fulgham. + +* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: +Reverted remaining change from +https://trac.webkit.org/changeset/208702/webkit and +https://trac.webkit.org/changeset/208707/webkit. + 2017-03-24 Eric Carlson [MediaStream] "ideal" constraints passed to getUserMedia should affect fitness score Modified: trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (214388 => 214389) --- trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2017-03-25 00:10:06 UTC (rev 214388) +++ trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2017-03-25 00:12:55 UTC (rev 214389) @@ -152,7 +152,6 @@ (global-name "com.apple.CoreAuthentication.agent.libxpc") (global-name "com.apple.SecurityServer")) -#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101240 ;; FIXME: This should be removed when is fixed. ;; Restrict AppSandboxed processes from creating /Library/Keychains, but allow access to the contents of /Library/Keychains: (allow file-read-data file-read-metadata file-write-data @@ -163,7 +162,6 @@ (deny file-read* file-write* (regex (string-append "/Library/Keychains/" (uuid-regex-string) "(/|$)")) (home-regex (string-append "/Library/Keychains/" (uuid-regex-string) "(/|$)"))) -#endif (allow file-read* file-write* (subpath "/private/var/db/mds/system")) ;; FIXME: This should be removed when is fixed. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [214388] trunk
Title: [214388] trunk
Revision 214388
Author ryanhad...@apple.com
Date 2017-03-24 17:10:06 -0700 (Fri, 24 Mar 2017)
Log Message
Unreviewed, rolling out r214361.
This change caused flakiness in http/tests/preload tests.
Reverted changeset:
"Add a warning for unused link preloads."
https://bugs.webkit.org/show_bug.cgi?id=165670
http://trac.webkit.org/changeset/214361
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/preload/download_resources-expected.txt
trunk/LayoutTests/http/tests/preload/download_resources.html
trunk/LayoutTests/http/tests/preload/onerror_event-expected.txt
trunk/LayoutTests/http/tests/preload/onerror_event.html
trunk/LayoutTests/http/tests/preload/onload_event-expected.txt
trunk/LayoutTests/http/tests/preload/onload_event.html
trunk/LayoutTests/http/tests/preload/single_download_preload.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/loader/LinkPreloadResourceClients.h
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResourceClient.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
Removed Paths
trunk/LayoutTests/http/tests/preload/unused_preload_warning-expected.txt
trunk/LayoutTests/http/tests/preload/unused_preload_warning.html
Diff
Modified: trunk/LayoutTests/ChangeLog (214387 => 214388)
--- trunk/LayoutTests/ChangeLog 2017-03-24 23:43:56 UTC (rev 214387)
+++ trunk/LayoutTests/ChangeLog 2017-03-25 00:10:06 UTC (rev 214388)
@@ -1,3 +1,15 @@
+2017-03-24 Ryan Haddad
+
+Unreviewed, rolling out r214361.
+
+This change caused flakiness in http/tests/preload tests.
+
+Reverted changeset:
+
+"Add a warning for unused link preloads."
+https://bugs.webkit.org/show_bug.cgi?id=165670
+http://trac.webkit.org/changeset/214361
+
2017-03-24 Antoine Quint
[Modern Media Controls] Remove placard icon if height is compressed
Modified: trunk/LayoutTests/http/tests/preload/download_resources-expected.txt (214387 => 214388)
--- trunk/LayoutTests/http/tests/preload/download_resources-expected.txt 2017-03-24 23:43:56 UTC (rev 214387)
+++ trunk/LayoutTests/http/tests/preload/download_resources-expected.txt 2017-03-25 00:10:06 UTC (rev 214388)
@@ -1,5 +1,13 @@
-CONSOLE MESSAGE: line 13: must have a valid `as` value
-This test makes sure that link preload preloads resources
+CONSOLE MESSAGE: line 11: must have a valid `as` value
+PASS internals.isPreloaded('../resources/dummy.js'); is true
+PASS internals.isPreloaded('../resources/dummy.css'); is true
+PASS internals.isPreloaded('../resources/square.png'); is true
+PASS internals.isPreloaded('../resources/Ahem.ttf'); is true
+PASS internals.isPreloaded('../resources/test.mp4'); is true
+PASS internals.isPreloaded('../security/resources/captions.vtt'); is true
+PASS internals.isPreloaded('../resources/dummy.xml?badvalue'); is false
+PASS internals.isPreloaded('../resources/dummy.xml'); is true
+PASS successfullyParsed is true
-PASS Makes sure that preloaded resources are downloaded
+TEST COMPLETE
Modified: trunk/LayoutTests/http/tests/preload/download_resources.html (214387 => 214388)
--- trunk/LayoutTests/http/tests/preload/download_resources.html 2017-03-24 23:43:56 UTC (rev 214387)
+++ trunk/LayoutTests/http/tests/preload/download_resources.html 2017-03-25 00:10:06 UTC (rev 214388)
@@ -1,43 +1,27 @@
-
-var t = async_test('Makes sure that preloaded resources are downloaded');
-
+
+
+
-
-
+
+
-