[webkit-changes] [216820] branches/safari-604.1.21-branch/Source/WebKit2
Title: [216820] branches/safari-604.1.21-branch/Source/WebKit2 Revision 216820 Author jmarc...@apple.com Date 2017-05-12 23:51:11 -0700 (Fri, 12 May 2017) Log Message Cherry-pick r216774. rdar://problem/31587957 Modified Paths branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm Diff Modified: branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog (216819 => 216820) --- branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-13 06:39:30 UTC (rev 216819) +++ branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-13 06:51:11 UTC (rev 216820) @@ -1,5 +1,20 @@ 2017-05-12 Jason Marcell +Cherry-pick r216774. rdar://problem/31587957 + +2017-05-12 Andy Estes + +[Cocoa] Stop setting a status on PKPaymentRequestShippingContactUpdate when there are errors +https://bugs.webkit.org/show_bug.cgi?id=172036 + + +Reviewed by Anders Carlsson. + +* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: +(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingContactSelection): + +2017-05-12 Jason Marcell + Cherry-pick r216349. rdar://problem/32117885 2017-05-07 Youenn Fablet Modified: branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm (216819 => 216820) --- branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2017-05-13 06:39:30 UTC (rev 216819) +++ branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2017-05-13 06:51:11 UTC (rev 216820) @@ -785,8 +785,6 @@ #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 11) auto pkShippingContactUpdate = adoptNS([allocPKPaymentRequestShippingContactUpdateInstance() initWithErrors:update ? toNSErrors(update->errors).get() : @[ ] paymentSummaryItems:m_paymentAuthorizationViewControllerDelegate->_paymentSummaryItems.get() shippingMethods:m_paymentAuthorizationViewControllerDelegate->_shippingMethods.get()]); -if ([pkShippingContactUpdate errors].count) -[pkShippingContactUpdate setStatus:PKPaymentAuthorizationStatusFailure]; m_paymentAuthorizationViewControllerDelegate->_didSelectShippingContactCompletion(pkShippingContactUpdate.get()); #else m_paymentAuthorizationViewControllerDelegate->_didSelectShippingContactCompletion(toPKPaymentAuthorizationStatus(update), m_paymentAuthorizationViewControllerDelegate->_shippingMethods.get(), m_paymentAuthorizationViewControllerDelegate->_paymentSummaryItems.get()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216821] branches/safari-604.1.21-branch/Source/WebCore
Title: [216821] branches/safari-604.1.21-branch/Source/WebCore
Revision 216821
Author jmarc...@apple.com
Date 2017-05-12 23:51:13 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216792. rdar://problem/32084098
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderWidget.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216820 => 216821)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-13 06:51:11 UTC (rev 216820)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-13 06:51:13 UTC (rev 216821)
@@ -1,5 +1,27 @@
2017-05-12 Jason Marcell
+Cherry-pick r216792. rdar://problem/32084098
+
+2017-05-12 Zalan Bujtas
+
+[iOS WK1] Do not try to layout a subframe if its document has not been constructed yet.
+https://bugs.webkit.org/show_bug.cgi?id=172042
+
+
+Reviewed by Antti Koivisto.
+
+On iOS WK1 we can end up in an inconsistent state, where
+1. the web thread is inside a newly injected iframe's document's c'tor and
+2. waiting on a delegate callback on the main thread
+while the main thread
+1. executes a pending didLayout() task
+2. triggers layout on the newly injected iframe.
+
+* rendering/RenderWidget.cpp:
+(WebCore::RenderWidget::updateWidgetPosition):
+
+2017-05-12 Jason Marcell
+
Cherry-pick r216766. rdar://problem/32151246
2017-05-12 Jer Noble
Modified: branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderWidget.cpp (216820 => 216821)
--- branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderWidget.cpp 2017-05-13 06:51:11 UTC (rev 216820)
+++ branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderWidget.cpp 2017-05-13 06:51:13 UTC (rev 216821)
@@ -324,7 +324,7 @@
if (is(*m_widget)) {
FrameView& frameView = downcast(*m_widget);
// Check the frame's page to make sure that the frame isn't in the process of being destroyed.
-if ((widgetSizeChanged || frameView.needsLayout()) && frameView.frame().page())
+if ((widgetSizeChanged || frameView.needsLayout()) && frameView.frame().page() && frameView.frame().document())
frameView.layout();
}
return ChildWidgetState::Valid;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216819] trunk/Source/WebCore
Title: [216819] trunk/Source/WebCore
Revision 216819
Author commit-qu...@webkit.org
Date 2017-05-12 23:39:30 -0700 (Fri, 12 May 2017)
Log Message
[WebIDL] Remove need for custom binding for Worker constructor
https://bugs.webkit.org/show_bug.cgi?id=172050
Patch by Sam Weinig on 2017-05-12
Reviewed by Chris Dumez.
* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWorkerCustom.cpp: Removed.
Remove JSWorkerCustom.cpp
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
* bindings/scripts/IDLAttributes.json:
Add RuntimeFlags as a new option for the ConstructorCallWith extended attribute.
* workers/Worker.cpp:
(WebCore::Worker::create):
* workers/Worker.h:
Update order of arguments to appease the generator.
* workers/Worker.idl:
Add extended attributes for the constructor.
Modified Paths
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.json
trunk/Source/WebCore/workers/Worker.cpp
trunk/Source/WebCore/workers/Worker.h
trunk/Source/WebCore/workers/Worker.idl
Removed Paths
trunk/Source/WebCore/bindings/js/JSWorkerCustom.cpp
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (216818 => 216819)
--- trunk/Source/WebCore/CMakeLists.txt 2017-05-13 06:23:23 UTC (rev 216818)
+++ trunk/Source/WebCore/CMakeLists.txt 2017-05-13 06:39:30 UTC (rev 216819)
@@ -1226,7 +1226,6 @@
bindings/js/JSWebGPURenderPassAttachmentDescriptorCustom.cpp
bindings/js/JSWebGPURenderingContextCustom.cpp
bindings/js/JSWebKitSubtleCryptoCustom.cpp
-bindings/js/JSWorkerCustom.cpp
bindings/js/JSWorkerGlobalScopeBase.cpp
bindings/js/JSWorkerGlobalScopeCustom.cpp
bindings/js/JSXMLDocumentCustom.cpp
Modified: trunk/Source/WebCore/ChangeLog (216818 => 216819)
--- trunk/Source/WebCore/ChangeLog 2017-05-13 06:23:23 UTC (rev 216818)
+++ trunk/Source/WebCore/ChangeLog 2017-05-13 06:39:30 UTC (rev 216819)
@@ -1,3 +1,28 @@
+2017-05-12 Sam Weinig
+
+[WebIDL] Remove need for custom binding for Worker constructor
+https://bugs.webkit.org/show_bug.cgi?id=172050
+
+Reviewed by Chris Dumez.
+
+* CMakeLists.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* bindings/js/JSWorkerCustom.cpp: Removed.
+Remove JSWorkerCustom.cpp
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateCallWith):
+* bindings/scripts/IDLAttributes.json:
+Add RuntimeFlags as a new option for the ConstructorCallWith extended attribute.
+
+* workers/Worker.cpp:
+(WebCore::Worker::create):
+* workers/Worker.h:
+Update order of arguments to appease the generator.
+
+* workers/Worker.idl:
+Add extended attributes for the constructor.
+
2017-05-12 Simon Fraser
The rects returned by Element/Range.getClientRects() should not be rounded
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (216818 => 216819)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-05-13 06:23:23 UTC (rev 216818)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-05-13 06:39:30 UTC (rev 216819)
@@ -6604,7 +6604,6 @@
E1C657271816F9FE00256CDD /* CryptoAlgorithmParametersDeprecated.h in Headers */ = {isa = PBXBuildFile; fileRef = E1C657261816F9FE00256CDD /* CryptoAlgorithmParametersDeprecated.h */; };
E1C8BE5D0E8BD15A0064CB7D /* JSWorker.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E1C8BE5C0E8BD15A0064CB7D /* JSWorker.cpp */; };
E1C94AF9191303F000D5A893 /* BlobPart.h in Headers */ = {isa = PBXBuildFile; fileRef = E1C94AF7191303F000D5A893 /* BlobPart.h */; settings = {ATTRIBUTES = (Private, ); }; };
- E1CA5CBC0E8CDCAF00E8EF90 /* JSWorkerCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E1CA5CBB0E8CDCAF00E8EF90 /* JSWorkerCustom.cpp */; };
E1CAA5C60E8BD23600A73ECA /* JSWorker.h in Headers */ = {isa = PBXBuildFile; fileRef = E1CAA5C50E8BD23600A73ECA /* JSWorker.h */; };
E1CDE92015018ED000862CC5 /* AsyncFileStream.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E1CDE91F15018ED000862CC5 /* AsyncFileStream.cpp */; };
E1CDE9221501916900862CC5 /* AsyncFileStream.h in Headers */ = {isa = PBXBuildFile; fileRef = E1CDE9211501916900862CC5 /* AsyncFileStream.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -15139,7 +15138,6 @@
E1C6CFC21746D293007B87A1 /* DOMWindowConstructors.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = DOMWindowConstructors.idl; sourceTree = ""; };
E1C8BE5C0E8BD15A0064CB7D /* JSWorker.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSWorker.cpp; sourceTree = ""; };
E1C94AF7191303F000D5A893 /* BlobPart.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BlobPa
[webkit-changes] [216818] branches/safari-603-branch
Title: [216818] branches/safari-603-branch Revision 216818 Author jmarc...@apple.com Date 2017-05-12 23:23:23 -0700 (Fri, 12 May 2017) Log Message Cherry-pick r216599. rdar://problem/32081484 Modified Paths branches/safari-603-branch/LayoutTests/ChangeLog branches/safari-603-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt branches/safari-603-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html branches/safari-603-branch/LayoutTests/http/tests/navigation/resources/keyboard-events-after-navigation.html branches/safari-603-branch/LayoutTests/http/tests/navigation/resources/keyboard-events-test.js branches/safari-603-branch/Source/WebCore/ChangeLog branches/safari-603-branch/Source/WebCore/dom/EventDispatcher.cpp branches/safari-603-branch/Source/WebCore/editing/Editor.cpp Added Paths branches/safari-603-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt branches/safari-603-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html Diff Modified: branches/safari-603-branch/LayoutTests/ChangeLog (216817 => 216818) --- branches/safari-603-branch/LayoutTests/ChangeLog 2017-05-13 05:41:28 UTC (rev 216817) +++ branches/safari-603-branch/LayoutTests/ChangeLog 2017-05-13 06:23:23 UTC (rev 216818) @@ -1,5 +1,27 @@ 2017-05-12 Jason Marcell +Cherry-pick r216599. rdar://problem/32081484 + +2017-05-10 Andy Estes + +Keyboard input suppression should extend to subframes +https://bugs.webkit.org/show_bug.cgi?id=171880 + + +Reviewed by Ryosuke Niwa. + +* http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: +* http/tests/navigation/keyboard-events-during-provisional-navigation.html: +* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt. +* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html. +* http/tests/navigation/resources/keyboard-events-after-navigation.html: +* http/tests/navigation/resources/keyboard-events-test.js: +(runTest): +(waitForProvisionalNavigation.xhr.onreadystatechange): +(waitForProvisionalNavigation): + +2017-05-12 Jason Marcell + Cherry-pick r216307. rdar://problem/32119568 2017-05-05 Zalan Bujtas Modified: branches/safari-603-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt (216817 => 216818) --- branches/safari-603-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt 2017-05-13 05:41:28 UTC (rev 216817) +++ branches/safari-603-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt 2017-05-13 06:23:23 UTC (rev 216818) @@ -1,23 +1,23 @@ -CONSOLE MESSAGE: line 30: Provisional navigation started. -CONSOLE MESSAGE: line 31: No trusted events should be logged and the input element should have the value "". -CONSOLE MESSAGE: line 18: Dispatching untrusted keypress event. +CONSOLE MESSAGE: line 14: Provisional navigation started. +CONSOLE MESSAGE: line 15: No trusted events should be logged and the input element should have the value "". +CONSOLE MESSAGE: line 20: Dispatching untrusted keypress event. CONSOLE MESSAGE: line 5: keypressevent dispatched (isTrusted: false). -CONSOLE MESSAGE: line 26: Pressing tab. -CONSOLE MESSAGE: line 28: Active element after pressing tab: [object HTMLInputElement]. -CONSOLE MESSAGE: line 30: Pressing "a". -CONSOLE MESSAGE: line 33: Setting marked text to "b". -CONSOLE MESSAGE: line 36: Inserting text "c". -CONSOLE MESSAGE: line 39: Input element value after text input events: "". -CONSOLE MESSAGE: line 34: Pressing "z" with access key modifiers should navigate to resources/keyboard-events-after-navigation.html. +CONSOLE MESSAGE: line 28: Pressing tab. +CONSOLE MESSAGE: line 30: Active element after pressing tab: [object HTMLInputElement]. +CONSOLE MESSAGE: line 32: Pressing "a". +CONSOLE MESSAGE: line 42: Setting marked text to "b". +CONSOLE MESSAGE: line 45: Inserting text "c". +CONSOLE MESSAGE: line 48: Input element value after text input events: "". +CONSOLE MESSAGE: line 18: Pressing "z" with access key modifiers should navigate to resources/keyboard-events-after-navigation.html. CONSOLE MESSAGE: line 6: Finished navigating to resources/keyboard-events-after-navigation.html. CONSOLE MESSAGE: line 7: Trusted events should be logged and the input element should have the value "ac". -CONSOLE MESSAGE: line 18: Dispatching untrusted
[webkit-changes] [216816] trunk/Source/WebKit
Title: [216816] trunk/Source/WebKit Revision 216816 Author cdu...@apple.com Date 2017-05-12 22:26:11 -0700 (Fri, 12 May 2017) Log Message Drop uses of PassRefPtr in WebKit/mac https://bugs.webkit.org/show_bug.cgi?id=172066 Reviewed by Sam Weinig. Source/WebKit/ios: Build fix. * Misc/WebGeolocationProviderIOS.mm: Source/WebKit/mac: * History/WebBackForwardListInternal.h: * History/WebHistoryItem.mm: (kit): (-[WebHistoryItem initWithWebCoreHistoryItem:]): * History/WebHistoryItemInternal.h: * Plugins/Hosted/HostedNetscapePluginStream.h: (WebKit::HostedNetscapePluginStream::create): * Plugins/Hosted/NetscapePluginHostManager.h: * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): * Plugins/Hosted/NetscapePluginInstanceProxy.h: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::create): (WebKit::NetscapePluginInstanceProxy::create): (WebKit::NetscapePluginInstanceProxy::setManualStream): * Plugins/Hosted/ProxyInstance.h: (WebKit::ProxyInstance::create): * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::ProxyInstance): (WebKit::ProxyInstance::newRuntimeObject): * Plugins/Hosted/ProxyRuntimeObject.h: (WebKit::ProxyRuntimeObject::create): * Plugins/Hosted/ProxyRuntimeObject.mm: (WebKit::ProxyRuntimeObject::ProxyRuntimeObject): * Plugins/Hosted/WebHostedNetscapePluginView.h: * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]): * Plugins/WebBaseNetscapePluginView.h: * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]): * Plugins/WebNetscapePluginStream.h: (WebNetscapePluginStream::create): * Plugins/WebNetscapePluginView.h: * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]): * WebCoreSupport/WebChromeClient.mm: * WebCoreSupport/WebEditorClient.mm: * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::requestPermission): (-[WebNotificationPolicyListener initWithCallback:]): * WebCoreSupport/WebOpenPanelResultListener.mm: * WebCoreSupport/WebUserMediaClient.mm: (WebUserMediaClient::requestUserMediaAccess): (WebUserMediaClient::enumerateMediaDevices): (-[WebUserMediaPolicyListener initWithUserMediaRequest:]): (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]): * WebView/WebArchive.mm: (-[WebArchivePrivate initWithCoreArchive:]): (-[WebArchivePrivate setCoreArchive:]): (-[WebArchive initWithData:]): (-[WebArchive subframeArchives]): (-[WebArchive _initWithCoreLegacyWebArchive:]): * WebView/WebArchiveInternal.h: * WebView/WebDataSource.mm: (WebDataSourcePrivate::WebDataSourcePrivate): (WebDataSourcePrivate::~WebDataSourcePrivate): (-[WebDataSource _initWithDocumentLoader:]): * WebView/WebDataSourceInternal.h: * WebView/WebDeviceOrientation.mm: (-[WebDeviceOrientation initWithCoreDeviceOrientation:]): * WebView/WebDeviceOrientationInternal.h: * WebView/WebFrame.mm: (-[WebFrame _convertToDOMRange:]): (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]): * WebView/WebFrameInternal.h: * WebView/WebFullScreenController.h: * WebView/WebFullScreenController.mm: (-[WebFullScreenController setElement:]): * WebView/WebGeolocationPosition.mm: (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]): (-[WebGeolocationPosition initWithGeolocationPosition:]): * WebView/WebHTMLView.mm: (currentKeyboardEvent): * WebView/WebResource.mm: * WebView/WebScriptWorld.mm: (-[WebScriptWorld initWithWorld:]): (+[WebScriptWorld standardWorld]): (+[WebScriptWorld findOrCreateWorld:]): * WebView/WebViewData.h: (LayerFlushController::create): Modified Paths trunk/Source/WebKit/ios/ChangeLog trunk/Source/WebKit/ios/Misc/WebGeolocationProviderIOS.mm trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/History/WebBackForwardListInternal.h trunk/Source/WebKit/mac/History/WebHistoryItem.mm trunk/Source/WebKit/mac/History/WebHistoryItemInternal.h trunk/Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.h trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginHostManager.h trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginHostManager.mm trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm trunk/Source/WebKit/mac/Plugins/Hosted/ProxyInstance.h trunk/Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm trunk/Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h trunk/Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.mm trunk/Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.h trunk/Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm trunk/Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.h trunk/Source/
[webkit-changes] [216815] trunk/Source/JavaScriptCore
Title: [216815] trunk/Source/_javascript_Core
Revision 216815
Author gga...@apple.com
Date 2017-05-12 21:59:35 -0700 (Fri, 12 May 2017)
Log Message
[JSC] DFG::Node should not have its own allocator
https://bugs.webkit.org/show_bug.cgi?id=160098
Reviewed by Saam Barati.
I just rebased the patch from .
I ran Octane and JetStream locally on a MacBook Air and I wasn't able to
reproduce a regression. Let's land this again and see what the bots say.
* _javascript_Core.xcodeproj/project.pbxproj:
* b3/B3SparseCollection.h:
(JSC::B3::SparseCollection::packIndices):
* dfg/DFGAllocator.h: Removed.
* dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::~Graph):
(JSC::DFG::Graph::deleteNode):
(JSC::DFG::Graph::packNodeIndices):
(JSC::DFG::Graph::addNodeToMapByIndex): Deleted.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::addNode):
(JSC::DFG::Graph::maxNodeCount):
(JSC::DFG::Graph::nodeAt):
* dfg/DFGLongLivedState.cpp: Removed.
* dfg/DFGLongLivedState.h: Removed.
* dfg/DFGNode.h:
* dfg/DFGNodeAllocator.h:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
* dfg/DFGPlan.h:
* dfg/DFGWorklist.cpp:
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
Modified Paths
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/b3/B3SparseCollection.h
trunk/Source/_javascript_Core/dfg/DFGDriver.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGNodeAllocator.h
trunk/Source/_javascript_Core/dfg/DFGPlan.cpp
trunk/Source/_javascript_Core/dfg/DFGPlan.h
trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h
Removed Paths
trunk/Source/_javascript_Core/dfg/DFGAllocator.h
trunk/Source/_javascript_Core/dfg/DFGLongLivedState.cpp
trunk/Source/_javascript_Core/dfg/DFGLongLivedState.h
Diff
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (216814 => 216815)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2017-05-13 03:09:57 UTC (rev 216814)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2017-05-13 04:59:35 UTC (rev 216815)
@@ -358,7 +358,6 @@
dfg/DFGLazyJSValue.cpp
dfg/DFGLazyNode.cpp
dfg/DFGLivenessAnalysisPhase.cpp
-dfg/DFGLongLivedState.cpp
dfg/DFGLoopPreHeaderCreationPhase.cpp
dfg/DFGMaximalFlushInsertionPhase.cpp
dfg/DFGMayExit.cpp
Modified: trunk/Source/_javascript_Core/ChangeLog (216814 => 216815)
--- trunk/Source/_javascript_Core/ChangeLog 2017-05-13 03:09:57 UTC (rev 216814)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-05-13 04:59:35 UTC (rev 216815)
@@ -1,3 +1,44 @@
+2017-05-12 Geoffrey Garen
+
+[JSC] DFG::Node should not have its own allocator
+https://bugs.webkit.org/show_bug.cgi?id=160098
+
+Reviewed by Saam Barati.
+
+I just rebased the patch from .
+
+I ran Octane and JetStream locally on a MacBook Air and I wasn't able to
+reproduce a regression. Let's land this again and see what the bots say.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* b3/B3SparseCollection.h:
+(JSC::B3::SparseCollection::packIndices):
+* dfg/DFGAllocator.h: Removed.
+* dfg/DFGDriver.cpp:
+(JSC::DFG::compileImpl):
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::Graph):
+(JSC::DFG::Graph::~Graph):
+(JSC::DFG::Graph::deleteNode):
+(JSC::DFG::Graph::packNodeIndices):
+(JSC::DFG::Graph::addNodeToMapByIndex): Deleted.
+* dfg/DFGGraph.h:
+(JSC::DFG::Graph::addNode):
+(JSC::DFG::Graph::maxNodeCount):
+(JSC::DFG::Graph::nodeAt):
+* dfg/DFGLongLivedState.cpp: Removed.
+* dfg/DFGLongLivedState.h: Removed.
+* dfg/DFGNode.h:
+* dfg/DFGNodeAllocator.h:
+* dfg/DFGPlan.cpp:
+(JSC::DFG::Plan::compileInThread):
+(JSC::DFG::Plan::compileInThreadImpl):
+* dfg/DFGPlan.h:
+* dfg/DFGWorklist.cpp:
+* runtime/VM.cpp:
+(JSC::VM::VM):
+* runtime/VM.h:
+
2017-05-12 Keith Miller
Use Mach exceptions instead of signals where possible
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (216814 => 216815)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2017-05-13 03:09:57 UTC (rev 216814)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2017-05-13 04:59:35 UTC (rev 216815)
@@ -1003,8 +1003,6 @@
0FEFC9AB1681A3B600567F53 /* DFGOSRExitJumpPlaceholder.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FEFC9A81681A3B000567F53 /* DFGOSRExitJumpPlaceholder.h */; };
0FF054F91AC35B4400E5BE57 /* ExecutableAllocationFuzz.cpp in Sources
[webkit-changes] [216814] branches/safari-603-branch
Title: [216814] branches/safari-603-branch
Revision 216814
Author jmarc...@apple.com
Date 2017-05-12 20:09:57 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216307. rdar://problem/32119568
Modified Paths
branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/accessibility/AXObjectCache.cpp
Added Paths
branches/safari-603-branch/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt
branches/safari-603-branch/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html
Diff
Modified: branches/safari-603-branch/LayoutTests/ChangeLog (216813 => 216814)
--- branches/safari-603-branch/LayoutTests/ChangeLog 2017-05-13 03:03:37 UTC (rev 216813)
+++ branches/safari-603-branch/LayoutTests/ChangeLog 2017-05-13 03:09:57 UTC (rev 216814)
@@ -1,3 +1,18 @@
+2017-05-12 Jason Marcell
+
+Cherry-pick r216307. rdar://problem/32119568
+
+2017-05-05 Zalan Bujtas
+
+Renderers being destroyed should not be added to AX's deferred list.
+https://bugs.webkit.org/show_bug.cgi?id=171768
+
+
+Reviewed by Simon Fraser.
+
+* accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt: Added.
+* accessibility/crash-when-renderers-are-added-back-to-deferred-list.html: Added.
+
2017-05-10 Ryan Haddad
Unreviewed test gardening.
Added: branches/safari-603-branch/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt (0 => 216814)
--- branches/safari-603-branch/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt (rev 0)
+++ branches/safari-603-branch/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt 2017-05-13 03:09:57 UTC (rev 216814)
@@ -0,0 +1 @@
+PASS if no crash or assert.
Added: branches/safari-603-branch/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html (0 => 216814)
--- branches/safari-603-branch/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html (rev 0)
+++ branches/safari-603-branch/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html 2017-05-13 03:09:57 UTC (rev 216814)
@@ -0,0 +1,26 @@
+
+
+
+This tests that accessibility ignores elements that are being destroyed
+
+if (window.accessibilityController)
+accessibilityController.accessibleElementById("foo");
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+::-webkit-scrollbar-corner {
+border: 1px solid green;
+}
+
+
+
+PASS if no crash or assert.
+
+
+document.body.offsetHeight;
+foo.style.display = "none";
+document.body.offsetHeight;
+
+
+
Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (216813 => 216814)
--- branches/safari-603-branch/Source/WebCore/ChangeLog 2017-05-13 03:03:37 UTC (rev 216813)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog 2017-05-13 03:09:57 UTC (rev 216814)
@@ -1,3 +1,29 @@
+2017-05-12 Jason Marcell
+
+Cherry-pick r216307. rdar://problem/32119568
+
+2017-05-05 Zalan Bujtas
+
+Renderers being destroyed should not be added to AX's deferred list.
+https://bugs.webkit.org/show_bug.cgi?id=171768
+
+
+Reviewed by Simon Fraser.
+
+In certain cases, when custom scrollbars are present, while destroying the scrollbars' block parent, we
+ - first remove the block from the AX's deferred list (AXObjectCache::remove)
+ - destroy the render layer that owns the custom scrollbars (RenderLayer::destroyLayer)
+ - detach the scrollbars from the parent (block) (RenderObject::removeFromParent)
+- clean up the block's lines (RenderBlock::deleteLines)
+ - push the block back to the AX's deferred list (AXObjectCache::recomputeDeferredIsIgnored)
+At this point no one will remove the current block from AX's deferred list.
+
+Test: accessibility/crash-when-renderers-are-added-back-to-deferred-list.html
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::recomputeDeferredIsIgnored):
+(WebCore::AXObjectCache::deferTextChanged):
+
2017-05-10 Matthew Hanson
Fix order of merge from r212528. rdar://problem/31153819
Modified: branches/safari-603-branch/Source/WebCore/accessibility/AXObjectCache.cpp (216813 => 216814)
--- branches/safari-603-branch/Source/WebCore/accessibility/AXObjectCache.cpp 2017-05-13 03:03:37 UTC (rev 216813)
+++ branches/safari-603-branch/Source/WebCore/accessibility/AXObjectCache.cpp 2017-05-13 03:09:57 UTC (rev 216814)
@@ -2634,11 +2634,15 @@
void AXObjectCache::recomputeDeferredIsIgnored(RenderBlock& renderer)
{
+if (renderer
[webkit-changes] [216813] trunk
Title: [216813] trunk
Revision 216813
Author jiewen_...@apple.com
Date 2017-05-12 20:03:37 -0700 (Fri, 12 May 2017)
Log Message
Elements should be inserted into a template element as its content's last child
https://bugs.webkit.org/show_bug.cgi?id=171373
Reviewed by Ryosuke Niwa.
Source/WebCore:
Before this change, our HTML parser obeys the following premises:
1) A fostering child whose parent is a table should be inserted before its parent and under its grandparent.
2) When inserting into a template element, an element should be inserted into its content.
Let's walk through the example:
a) Before eventhandler takes place
template
table
svg <- parser
b) After eventhandler takes place
template
table
svg <- parser
c) after parsing svg
template
content
svg
(table)
table
Finally, in the example, the svg element will be inserted into the content of the template element while
having its next sibling point to the table element. However, the table element is actually under the
template element not its content.
This messy tree is constructed because the second premise is incompleted. It should be: When inserting into
a template element, an element should be inserted into its content as its last child.
Quoted from Step 3 of https://html.spec.whatwg.org/multipage/syntax.html#appropriate-place-for-inserting-a-node
A correct tree will then looks like:
template
content
svg
table
Tests: fast/dom/HTMLTemplateElement/insert-fostering-child-crash.html
fast/dom/HTMLTemplateElement/insert-fostering-child.html
* html/parser/HTMLConstructionSite.cpp:
(WebCore::insert):
By nullifying task.nextChild, it will force the parser to append the element as task.parent's last child.
LayoutTests:
* fast/dom/HTMLTemplateElement/insert-fostering-child-expected.txt: Added.
* fast/dom/HTMLTemplateElement/insert-fostering-child.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp
Added Paths
trunk/LayoutTests/fast/dom/HTMLTemplateElement/insert-fostering-child-expected.txt
trunk/LayoutTests/fast/dom/HTMLTemplateElement/insert-fostering-child.html
Diff
Modified: trunk/LayoutTests/ChangeLog (216812 => 216813)
--- trunk/LayoutTests/ChangeLog 2017-05-13 02:05:02 UTC (rev 216812)
+++ trunk/LayoutTests/ChangeLog 2017-05-13 03:03:37 UTC (rev 216813)
@@ -1,3 +1,14 @@
+2017-05-12 Jiewen Tan
+
+Elements should be inserted into a template element as its content's last child
+https://bugs.webkit.org/show_bug.cgi?id=171373
+
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/HTMLTemplateElement/insert-fostering-child-expected.txt: Added.
+* fast/dom/HTMLTemplateElement/insert-fostering-child.html: Added.
+
2017-05-11 Simon Fraser
Incorrect position when dragging jQuery Draggable elements with position fixed after pinch zoom
Added: trunk/LayoutTests/fast/dom/HTMLTemplateElement/insert-fostering-child-expected.txt (0 => 216813)
--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/insert-fostering-child-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/insert-fostering-child-expected.txt 2017-05-13 03:03:37 UTC (rev 216813)
@@ -0,0 +1,12 @@
+Test inserting a fostering child into HTMLTemplateElement
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS template.firstChild is table
+PASS template.content.lastChild is svg
+PASS svg.nextSibling is null
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/HTMLTemplateElement/insert-fostering-child.html (0 => 216813)
--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/insert-fostering-child.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/insert-fostering-child.html 2017-05-13 03:03:37 UTC (rev 216813)
@@ -0,0 +1,35 @@
+
+
+
+
+jsTestIsAsync = true;
+
+function checkOrder()
+{
+description('Test inserting a fostering child into HTMLTemplateElement');
+shouldBe('template.firstChild', 'table');
+svg = template.content.querySelector("svg");
+shouldBe('template.content.lastChild', 'svg');
+shouldBeNull('svg.nextSibling');
+finishJSTest();
+}
+
+function eventhandler()
+{
+template.appendChild(table);
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
[webkit-changes] [216812] branches/safari-604.1.21-branch/Source
Title: [216812] branches/safari-604.1.21-branch/Source Revision 216812 Author jmarc...@apple.com Date 2017-05-12 19:05:02 -0700 (Fri, 12 May 2017) Log Message Versioning. Modified Paths branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig (216811 => 216812) --- branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2017-05-13 02:02:02 UTC (rev 216811) +++ branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2017-05-13 02:05:02 UTC (rev 216812) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (216811 => 216812) --- branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-05-13 02:02:02 UTC (rev 216811) +++ branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-05-13 02:05:02 UTC (rev 216812) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig (216811 => 216812) --- branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig 2017-05-13 02:02:02 UTC (rev 216811) +++ branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig 2017-05-13 02:05:02 UTC (rev 216812) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (216811 => 216812) --- branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-05-13 02:02:02 UTC (rev 216811) +++ branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-05-13 02:05:02 UTC (rev 216812) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (216811 => 216812) --- branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-05-13 02:02:02 UTC (rev 216811) +++ branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-05-13 02:05:02 UTC (rev 216812) @@ -1,7 +1,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig (216811 => 216812) --- branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2017-05-13 02:02:02 UTC (rev 216811) +++ branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2017-05-13 02:05:02 UTC (rev 216812) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig (216811 => 216812) --- branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig 2017-05-13 02:02:02 UTC (rev 216811) +++ branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig 2017-05-13 02:05:02 UTC (rev 216812) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-chang
[webkit-changes] [216810] trunk/Source/WebKit2
Title: [216810] trunk/Source/WebKit2 Revision 216810 Author cdu...@apple.com Date 2017-05-12 18:55:14 -0700 (Fri, 12 May 2017) Log Message Drop remaining uses of PassRefPtr in WebKit2/WebProcess https://bugs.webkit.org/show_bug.cgi?id=172055 Reviewed by Alex Christensen. * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm: (+[WKWebProcessPlugInScriptWorld normalWorld]): * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (contextMenuItems): * WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp: (WKBundleScriptWorldNormalWorld): * WebProcess/InjectedBundle/API/gtk/WebKitScriptWorld.cpp: (webkitScriptWorldCreate): * WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp: (WebKit::InjectedBundleCSSStyleDeclarationHandle::getOrCreate): * WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h: * WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp: (WebKit::InjectedBundleRangeHandle::getOrCreate): (WebKit::InjectedBundleRangeHandle::create): (WebKit::InjectedBundleRangeHandle::coreRange): (WebKit::InjectedBundleRangeHandle::renderedImage): * WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::create): (WebKit::InjectedBundle::createWebDataFromUint8Array): * WebProcess/InjectedBundle/InjectedBundle.h: * WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp: (WebKit::InjectedBundleBackForwardList::itemAtIndex): * WebProcess/InjectedBundle/InjectedBundleBackForwardList.h: (WebKit::InjectedBundleBackForwardList::detach): * WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h: (WebKit::InjectedBundleBackForwardListItem::create): (WebKit::InjectedBundleBackForwardListItem::InjectedBundleBackForwardListItem): * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp: (WebKit::InjectedBundleHitTestResult::nodeHandle): (WebKit::InjectedBundleHitTestResult::urlElementHandle): * WebProcess/InjectedBundle/InjectedBundleHitTestResult.h: * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: (WebKit::InjectedBundleNavigationAction::create): (WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction): * WebProcess/InjectedBundle/InjectedBundleNavigationAction.h: * WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp: (WebKit::InjectedBundleScriptWorld::getOrCreate): (WebKit::InjectedBundleScriptWorld::normalWorld): * WebProcess/InjectedBundle/InjectedBundleScriptWorld.h: * WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::create): (WebKit::NetscapePlugin::NetscapePlugin): (WebKit::NetscapePlugin::supportsSnapshotting): * WebProcess/Plugins/Netscape/NetscapePlugin.h: * WebProcess/Plugins/PDF/PDFPluginAnnotation.h: * WebProcess/Plugins/PDF/PDFPluginAnnotation.mm: (WebKit::PDFPluginAnnotation::create): * WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h: * WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm: (WebKit::PDFPluginChoiceAnnotation::createAnnotationElement): * WebProcess/Plugins/PDF/PDFPluginPasswordField.h: * WebProcess/Plugins/PDF/PDFPluginPasswordField.mm: (WebKit::PDFPluginPasswordField::createAnnotationElement): * WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h: * WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm: (WebKit::PDFPluginTextAnnotation::createAnnotationElement): * WebProcess/UserContent/WebUserContentController.cpp: (WebKit::worldMap): (WebKit::WebUserMessageHandlerDescriptorProxy::create): * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::convertImageToBitmap): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::addUserScript): (WebKit::WebPage::addUserStyleSheet): * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: (WebKit::WebPrintOperationGtk::create): * WebProcess/WebPage/gtk/WebPrintOperationGtk.h: * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::rangeForPosition): (WebKit::rangeAtWordBoundaryForPosition): * WebProcess/WebPage/mac/PlatformCAAnimationRemote.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/APIWebArchive.h trunk/Source/WebKit2/Shared/APIWebArchive.mm trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitScriptWorld.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHa
[webkit-changes] [216808] trunk
Title: [216808] trunk Revision 216808 Author keith_mil...@apple.com Date 2017-05-12 18:30:13 -0700 (Fri, 12 May 2017) Log Message Use Mach exceptions instead of signals where possible https://bugs.webkit.org/show_bug.cgi?id=171865 Reviewed by Mark Lam. Source/_javascript_Core: This patch adds some new JSC options. The first is an option that enables or disables web assembly tier up. The second controls whether or not we use mach exceptions (where available). * API/tests/ExecutionTimeLimitTest.cpp: (dispatchTermitateCallback): (testExecutionTimeLimit): * runtime/JSLock.cpp: (JSC::JSLock::didAcquireLock): * runtime/Options.cpp: (JSC::overrideDefaults): (JSC::Options::initialize): * runtime/Options.h: * runtime/VMTraps.cpp: (JSC::SignalContext::SignalContext): (JSC::SignalContext::adjustPCToPointToTrappingInstruction): (JSC::installSignalHandler): (JSC::VMTraps::SignalSender::send): * tools/SigillCrashAnalyzer.cpp: (JSC::SignalContext::SignalContext): (JSC::SignalContext::dump): (JSC::installCrashHandler): * wasm/WasmBBQPlan.cpp: (JSC::Wasm::BBQPlan::compileFunctions): * wasm/WasmFaultSignalHandler.cpp: (JSC::Wasm::trapHandler): (JSC::Wasm::enableFastMemory): * wasm/WasmMachineThreads.cpp: (JSC::Wasm::resetInstructionCacheOnAllThreads): Source/WTF: This patch enables using mach exceptions on darwin. The way the mach exception api works is that we create a mach port, which is like a file descriptor. We then wait for a message to arrive on that port in a thread. When another thread raises an exception (say due to a bad memory access) the OS sends our thread a message. The payload of that message is the register file of the crashing thread. We then call our custom handlers that change the state as needed. In order to restart the thread we send a payload back to the OS with an updated register file along with a success message header. This patch also makes thread messages work without signals by simply suspending the thread, and then running the message at that time. You can read more about mach exceptions here: http://www.cs.cmu.edu/afs/cs/project/mach/public/doc/unpublished/exception.ps and the Mach interface Generator (MiG) here: http://www.cs.cmu.edu/afs/cs/project/mach/public/doc/unpublished/mig.ps * Configurations/WTF.xcconfig: * WTF.xcodeproj/project.pbxproj: * wtf/Platform.h: * wtf/PlatformRegisters.h: (WTF::registersFromUContext): * wtf/StackBounds.h: (WTF::StackBounds::StackBounds): * wtf/ThreadHolder.cpp: (WTF::ThreadHolder::~ThreadHolder): * wtf/ThreadMessage.cpp: (WTF::sendMessageUsingSignal): (WTF::sendMessageUsingMach): (WTF::deliverMessagesUsingMach): (WTF::sendMessageScoped): * wtf/ThreadMessage.h: (WTF::sendMessage): * wtf/Threading.h: (WTF::Thread::machThread): * wtf/mac/MachExceptions.defs: Copied from Source/WTF/wtf/ThreadMessage.h. * wtf/threads/Signals.cpp: (WTF::startMachExceptionHandlerThread): (WTF::fromMachException): (WTF::toMachMask): (WTF::handleSignalsWithMach): (WTF::setExceptionPorts): (WTF::activeThreads): (WTF::registerThreadForMachExceptionHandling): (WTF::unregisterThreadForMachExceptionHandling): (WTF::installSignalHandler): (WTF::jscSignalHandler): * wtf/threads/Signals.h: Tools: * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: (runThreadMessageTest): (TEST): Modified Paths trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSLock.cpp trunk/Source/_javascript_Core/runtime/Options.cpp trunk/Source/_javascript_Core/runtime/Options.h trunk/Source/_javascript_Core/runtime/VMTraps.cpp trunk/Source/_javascript_Core/tools/SigillCrashAnalyzer.cpp trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp trunk/Source/_javascript_Core/wasm/WasmFaultSignalHandler.cpp trunk/Source/_javascript_Core/wasm/WasmMachineThreads.cpp trunk/Source/WTF/ChangeLog trunk/Source/WTF/Configurations/WTF.xcconfig trunk/Source/WTF/WTF.xcodeproj/project.pbxproj trunk/Source/WTF/wtf/Platform.h trunk/Source/WTF/wtf/PlatformRegisters.h trunk/Source/WTF/wtf/StackBounds.h trunk/Source/WTF/wtf/ThreadHolder.cpp trunk/Source/WTF/wtf/ThreadMessage.cpp trunk/Source/WTF/wtf/ThreadMessage.h trunk/Source/WTF/wtf/Threading.h trunk/Source/WTF/wtf/threads/Signals.cpp trunk/Source/WTF/wtf/threads/Signals.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp Added Paths trunk/Source/WTF/wtf/mac/MachExceptions.defs Diff Modified: trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp (216807 => 216808) --- trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp 2017-05-13 01:00:37 UTC (rev 216807) +++ trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp 2017-05-13 01:30:13 UTC (rev 216808) @@ -30,10 +30,18 @@ #include "JSContextRefPrivate.h" #include "_javascript_Core.h" #include "Options.h" + #include +#include +#include #include +#include #include +#if HAVE(MACH_EXCEPTIONS) +#include +#endif + using namespace std::chrono; using JS
[webkit-changes] [216807] trunk/Source/WebCore
Title: [216807] trunk/Source/WebCore Revision 216807 Author timothy_hor...@apple.com Date 2017-05-12 18:00:37 -0700 (Fri, 12 May 2017) Log Message Don't use LinkPresentation URL shortening if it's not available https://bugs.webkit.org/show_bug.cgi?id=172064 Rubber-stamped by Wenson Hsieh. * platform/mac/DragImageMac.mm: (WebCore::LinkImageLayout::LinkImageLayout): * platform/spi/cocoa/LinkPresentationSPI.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/mac/DragImageMac.mm trunk/Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h Diff Modified: trunk/Source/WebCore/ChangeLog (216806 => 216807) --- trunk/Source/WebCore/ChangeLog 2017-05-13 00:32:23 UTC (rev 216806) +++ trunk/Source/WebCore/ChangeLog 2017-05-13 01:00:37 UTC (rev 216807) @@ -1,3 +1,15 @@ +2017-05-12 Timothy Horton + +Don't use LinkPresentation URL shortening if it's not available +https://bugs.webkit.org/show_bug.cgi?id=172064 + + +Rubber-stamped by Wenson Hsieh. + +* platform/mac/DragImageMac.mm: +(WebCore::LinkImageLayout::LinkImageLayout): +* platform/spi/cocoa/LinkPresentationSPI.h: + 2017-05-11 Simon Fraser Incorrect position when dragging jQuery Draggable elements with position fixed after pinch zoom Modified: trunk/Source/WebCore/platform/mac/DragImageMac.mm (216806 => 216807) --- trunk/Source/WebCore/platform/mac/DragImageMac.mm 2017-05-13 00:32:23 UTC (rev 216806) +++ trunk/Source/WebCore/platform/mac/DragImageMac.mm 2017-05-13 01:00:37 UTC (rev 216807) @@ -45,7 +45,7 @@ #import "URL.h" #import -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 SOFT_LINK_PRIVATE_FRAMEWORK(LinkPresentation) #endif @@ -196,7 +196,7 @@ NSURL *cocoaURL = url; NSString *absoluteURLString = [cocoaURL absoluteString]; -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 LinkPresentationLibrary(); NSString *domain = [cocoaURL _lp_simplifiedDisplayString]; #else Modified: trunk/Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h (216806 => 216807) --- trunk/Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h 2017-05-13 00:32:23 UTC (rev 216806) +++ trunk/Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h 2017-05-13 01:00:37 UTC (rev 216807) @@ -23,7 +23,7 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 #if USE(APPLE_INTERNAL_SDK) @@ -37,4 +37,4 @@ #endif -#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 +#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216806] trunk
Title: [216806] trunk
Revision 216806
Author commit-qu...@webkit.org
Date 2017-05-12 17:32:23 -0700 (Fri, 12 May 2017)
Log Message
Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
https://bugs.webkit.org/show_bug.cgi?id=172048
rdar://problem/32163054
Patch by Jeremy Jones on 2017-05-12
Reviewed by Simon Fraser.
Source/WebKit2:
Rename UIPageClient setHasVideoInPictureInPicture to hasVideoInPictureInPictureDidChange.
Add missing _allowsPictureInPictureMediaPlayback property to WKPreferences.
Add -hasVideoInPictureInPictureDidChange to UIDelegate.
* UIProcess/API/APIUIClient.h:
(API::UIClient::hasVideoInPictureInPictureDidChange):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/C/WKPageUIClient.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _allowsPictureInPictureMediaPlayback]):
(-[WKPreferences _setAllowsPictureInPictureMediaPlayback:]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::hasVideoInPictureInPictureDidChange):
* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged):
Tools:
Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
* TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
* TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
(hasVideoInPictureInPictureDidChange):
(-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
(-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APIUIClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPageUIClient.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.h
trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm
trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (216805 => 216806)
--- trunk/Source/WebKit2/ChangeLog 2017-05-13 00:31:47 UTC (rev 216805)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-13 00:32:23 UTC (rev 216806)
@@ -1,3 +1,33 @@
+2017-05-12 Jeremy Jones
+
+Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
+https://bugs.webkit.org/show_bug.cgi?id=172048
+rdar://problem/32163054
+
+Reviewed by Simon Fraser.
+
+Rename UIPageClient setHasVideoInPictureInPicture to hasVideoInPictureInPictureDidChange.
+Add missing _allowsPictureInPictureMediaPlayback property to WKPreferences.
+Add -hasVideoInPictureInPictureDidChange to UIDelegate.
+
+* UIProcess/API/APIUIClient.h:
+(API::UIClient::hasVideoInPictureInPictureDidChange):
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPageUIClient):
+* UIProcess/API/C/WKPageUIClient.h:
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences _allowsPictureInPictureMediaPlayback]):
+(-[WKPreferences _setAllowsPictureInPictureMediaPlayback:]):
+* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
+* UIProcess/Cocoa/UIDelegate.h:
+* UIProcess/Cocoa/UIDelegate.mm:
+(WebKit::UIDelegate::setDelegate):
+(WebKit::UIDelegate::UIClient::hasVideoInPictureInPictureDidChange):
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
+(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
+(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged):
+
2017-05-12 David Quesada
Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
Modified: trunk/Source/WebKit2/UIProcess/API/APIUIClient.h (216805 => 216806)
--- trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2017-05-13 00:31:47 UTC (rev 216805)
+++ trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2017-05-13 00:32:23 UTC (rev 216806)
@@ -79,7 +79,7 @@
virtual void fullscreenMayReturnToInline(WebKit::WebPageProxy*) { }
virtual void didEnterFullscreen(WebKit::WebPageProxy*) { }
virtual void didExitFullscreen(WebKit::WebPageProxy*) { }
-virtual void setHasVideoInPictureInPicture(WebKit::WebPageProxy*, bool) { }
+virtual void hasVideoInPicture
[webkit-changes] [216805] trunk/Tools
Title: [216805] trunk/Tools
Revision 216805
Author beid...@apple.com
Date 2017-05-12 17:31:47 -0700 (Fri, 12 May 2017)
Log Message
REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
https://bugs.webkit.org/show_bug.cgi?id=172030
Unreviewed - Test gardening
Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
before the test starts.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
(defaultWebsiteCacheDirectory):
(defaultApplicationCacheDirectory):
(TEST):
(defaultWebsiteDataDirectory): Deleted.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm
Diff
Modified: trunk/Tools/ChangeLog (216804 => 216805)
--- trunk/Tools/ChangeLog 2017-05-13 00:00:14 UTC (rev 216804)
+++ trunk/Tools/ChangeLog 2017-05-13 00:31:47 UTC (rev 216805)
@@ -1,3 +1,19 @@
+2017-05-12 Brady Eidson
+
+REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
+https://bugs.webkit.org/show_bug.cgi?id=172030
+
+Unreviewed - Test gardening
+
+Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
+before the test starts.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
+(defaultWebsiteCacheDirectory):
+(defaultApplicationCacheDirectory):
+(TEST):
+(defaultWebsiteDataDirectory): Deleted.
+
2017-05-12 David Quesada
Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm (216804 => 216805)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm 2017-05-13 00:00:14 UTC (rev 216804)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm 2017-05-13 00:31:47 UTC (rev 216805)
@@ -107,7 +107,7 @@
return @"com.apple.webbookmarksd";
}
-NSString *defaultWebsiteDataDirectory()
+NSString *defaultWebsiteCacheDirectory()
{
#if PLATFORM(IOS)
return nil;
@@ -122,7 +122,7 @@
// This is to mirror a quirk in WebsiteDataStore::defaultApplicationCacheDirectory and catch any regressions.
return [NSHomeDirectory() stringByAppendingPathComponent:@"Library/Caches/com.apple.WebAppCache"];
#else
-return [defaultWebsiteDataDirectory() stringByAppendingString:@"/OfflineWebApplicationCache"];
+return [defaultWebsiteCacheDirectory() stringByAppendingString:@"/OfflineWebApplicationCache"];
#endif
}
@@ -132,16 +132,25 @@
// On iOS, MobileSafari and webbookmarksd need to share the same AppCache directory.
TestWebKitAPI::InstanceMethodSwizzler swizzle([NSBundle class], @selector(bundleIdentifier), reinterpret_cast(swizzledBundleIdentifierWebBookmarksD));
#endif
+
+// Start with a clean slate of WebsiteData.
+readyToContinue = false;
+[[WKWebsiteDataStore defaultDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^()
+{
+readyToContinue = true;
+}];
+TestWebKitAPI::Util::run(&readyToContinue);
+
+// Start with a clean slate of Website caches.
+if (auto *websiteCacheDirectory = defaultWebsiteCacheDirectory()) {
+NSURL *websiteCacheURL = [NSURL fileURLWithPath:[websiteCacheDirectory stringByExpandingTildeInPath]];
+[[NSFileManager defaultManager] removeItemAtURL:websiteCacheURL error:nil];
+}
+
NSURL *dbResourceURL = [[NSBundle mainBundle] URLForResource:@"ApplicationCache" withExtension:@"db" subdirectory:@"TestWebKitAPI.resources"];
NSURL *shmResourceURL = [[NSBundle mainBundle] URLForResource:@"ApplicationCache" withExtension:@"db-shm" subdirectory:@"TestWebKitAPI.resources"];
NSURL *walResourceURL = [[NSBundle mainBundle] URLForResource:@"ApplicationCache" withExtension:@"db-wal" subdirectory:@"TestWebKitAPI.resources"];
-// Clean up any website data files left from any previous test run.
-if (auto *websiteDataDirectory = defaultWebsiteDataDirectory()) {
-NSURL *websiteDataURL = [NSURL fileURLWithPath:[websiteDataDirectory stringByExpandingTildeInPath]];
-[[NSFileManager defaultManager] removeItemAtURL:websiteDataURL error:nil];
-}
-
NSURL *targetURL = [NSURL fileURLWithPath:[defaultApplicationCacheDirectory() stringByExpandingTildeInPath]];
[[NSFileManager defaultManager] createDirectoryAtURL:targetURL withIntermediateDirectories:YES attributes:nil error:nil];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216804] trunk/Source
Title: [216804] trunk/Source Revision 216804 Author bshaf...@apple.com Date 2017-05-12 17:00:14 -0700 (Fri, 12 May 2017) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (216803 => 216804) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2017-05-12 23:48:12 UTC (rev 216803) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2017-05-13 00:00:14 UTC (rev 216804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; -TINY_VERSION = 22; +TINY_VERSION = 23; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (216803 => 216804) --- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-05-12 23:48:12 UTC (rev 216803) +++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-05-13 00:00:14 UTC (rev 216804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; -TINY_VERSION = 22; +TINY_VERSION = 23; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (216803 => 216804) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2017-05-12 23:48:12 UTC (rev 216803) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2017-05-13 00:00:14 UTC (rev 216804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; -TINY_VERSION = 22; +TINY_VERSION = 23; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (216803 => 216804) --- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-05-12 23:48:12 UTC (rev 216803) +++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-05-13 00:00:14 UTC (rev 216804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; -TINY_VERSION = 22; +TINY_VERSION = 23; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (216803 => 216804) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-05-12 23:48:12 UTC (rev 216803) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-05-13 00:00:14 UTC (rev 216804) @@ -1,6 +1,6 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; -TINY_VERSION = 22; +TINY_VERSION = 23; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (216803 => 216804) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2017-05-12 23:48:12 UTC (rev 216803) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2017-05-13 00:00:14 UTC (rev 216804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; -TINY_VERSION = 22; +TINY_VERSION = 23; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (216803 => 216804) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2017-05-12 23:48:12 UTC (rev 216803) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2017-05-13 00:00:14 UTC (rev 216804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; -TINY_VERSION = 22; +TINY_VERSION = 23; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216803] trunk
Title: [216803] trunk
Revision 216803
Author simon.fra...@apple.com
Date 2017-05-12 16:48:12 -0700 (Fri, 12 May 2017)
Log Message
Incorrect position when dragging jQuery Draggable elements with position fixed after pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=171113
Source/WebCore:
rdar://problem/31746516
Reviewed by Tim Horton.
Make getBoundingClientRect() and getClientRects() return rects which are relative to the layout
viewport, rather than the visual viewport. This goes part of the way to fixing webkit.org/b/170981,
which aims to make pinch-zoom invisible to web pages ("inert visual viewport"). It fixes issues on various
sites like Facebook when zoomed.
Factor coordinate conversion code into functions on FrameView, which now documents
the various coordinate systems in a big comment. Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale()
and Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale() are renamed and factored
to use these helpers.
There are two behavior changes here:
1. FrameView::documentToClientOffset() now uses the origin of the layout viewport in the "document to client"
coordinate mapping.
2. The two document functions would apply the scale and offset in the wrong order. We need
to first undo the effects of CSS zoom, page zoom and page scale, and then map from document
to client coordinates.
Tests: fast/visual-viewport/client-rects-relative-to-layout-viewport.html
fast/zooming/client-rects-with-css-and-page-zoom.html
* dom/Document.cpp:
(WebCore::Document::convertAbsoluteToClientQuads):
(WebCore::Document::convertAbsoluteToClientRect):
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale): Deleted.
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale): Deleted.
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
* dom/Range.cpp:
(WebCore::Range::borderAndTextQuads):
* page/FrameView.cpp:
(WebCore::FrameView::absoluteToDocumentScaleFactor):
(WebCore::FrameView::absoluteToDocumentRect):
(WebCore::FrameView::absoluteToDocumentPoint):
(WebCore::FrameView::documentToClientOffset):
(WebCore::FrameView::documentToClientRect):
(WebCore::FrameView::documentToClientPoint):
* page/FrameView.h:
* platform/ScrollableArea.h: #pragma once
* platform/Scrollbar.h: #pragma once
* platform/Widget.h: #pragma once
LayoutTests:
Reviewed by Tim Horton.
Rebaseline tests which dumped the getBoundingClientRect for fixed elements; now that these
are layout viewport-relative, getBoundingClientRect() for a fixed element is unchanging.
New test that exercises getBoundingClientRect() and getClientRects() for fixed and absolute
elements after zooming.
* fast/events/autoscroll-when-zoomed.html: Adjust to account for behavior change.
* fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt: Added.
* fast/visual-viewport/client-rects-relative-to-layout-viewport.html: Added.
* fast/visual-viewport/zoomed-fixed-expected.txt:
* fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
* fast/zooming/client-rect-in-fixed-zoomed-expected.txt:
* fast/zooming/client-rect-in-fixed-zoomed.html:
* fast/zooming/client-rects-with-css-and-page-zoom-expected.txt: Added.
* fast/zooming/client-rects-with-css-and-page-zoom.html: Added.
* platform/ios-wk2/fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt: Added.
* platform/ios/TestExpectations: Mark imported/w3c/web-platform-tests/cssom-view/elementFromPoint.html as failing;
it will be fixed via webkit.org/b/172019
* platform/ios/fast/visual-viewport/zoomed-fixed-expected.txt:
* platform/ios/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/autoscroll-when-zoomed.html
trunk/LayoutTests/fast/visual-viewport/zoomed-fixed-expected.txt
trunk/LayoutTests/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt
trunk/LayoutTests/fast/zooming/client-rect-in-fixed-zoomed-expected.txt
trunk/LayoutTests/fast/zooming/client-rect-in-fixed-zoomed.html
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios/fast/visual-viewport/zoomed-fixed-expected.txt
trunk/LayoutTests/platform/ios/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Range.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/platform/Scrollbar.h
trunk/Source/WebCore/platform/Widget.h
Added Paths
trunk/LayoutTests/fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt
trunk/LayoutTests/fast/visual-viewport/client-rects-relative-to-layout-viewport.html
trunk/LayoutTests/fast/zooming/client-rects-wi
[webkit-changes] [216802] trunk
Title: [216802] trunk
Revision 216802
Author commit-qu...@webkit.org
Date 2017-05-12 16:29:28 -0700 (Fri, 12 May 2017)
Log Message
Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=172000
rdar://problem/32144756
Patch by David Quesada on 2017-05-12
Reviewed by Simon Fraser.
Source/WebKit2:
Extract -[WKWebView _visibleContentRect]'s use of -_scroller to a new property
_enclosingViewForExposedRectComputation, which is declared in the private
header for subclasses to implement custom logic for determining the view to
clip rendering to.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _enclosingViewForExposedRectComputation]):
(-[WKWebView _visibleRectInEnclosingView:]):
(-[WKWebView _visibleContentRect]):
(-[WKWebView _visibleRectInEnclosingScrollView:]): Deleted.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
Tools:
Added API tests to verify that WKWebView provides the expected value for
_visibleContentRect in various configurations. (i.e. not inside a scrollview,
inside a scrollview but not clipped, clipped by an ancestor scrollview,
clipped by the webview's _enclosingViewForExposedRectComputation)
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
(-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (216801 => 216802)
--- trunk/Source/WebKit2/ChangeLog 2017-05-12 23:12:13 UTC (rev 216801)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-12 23:29:28 UTC (rev 216802)
@@ -1,3 +1,23 @@
+2017-05-12 David Quesada
+
+Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
+https://bugs.webkit.org/show_bug.cgi?id=172000
+rdar://problem/32144756
+
+Reviewed by Simon Fraser.
+
+Extract -[WKWebView _visibleContentRect]'s use of -_scroller to a new property
+_enclosingViewForExposedRectComputation, which is declared in the private
+header for subclasses to implement custom logic for determining the view to
+clip rendering to.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _enclosingViewForExposedRectComputation]):
+(-[WKWebView _visibleRectInEnclosingView:]):
+(-[WKWebView _visibleContentRect]):
+(-[WKWebView _visibleRectInEnclosingScrollView:]): Deleted.
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+
2017-05-12 Chris Dumez
Stop using PassRefPtr under WebKit2/UIProcess
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (216801 => 216802)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-05-12 23:12:13 UTC (rev 216801)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-05-12 23:29:28 UTC (rev 216802)
@@ -2177,12 +2177,17 @@
[self _scheduleVisibleContentRectUpdateAfterScrollInView:scrollView];
}
-- (CGRect)_visibleRectInEnclosingScrollView:(UIScrollView *)enclosingScrollView
+- (UIView *)_enclosingViewForExposedRectComputation
{
-if (!enclosingScrollView)
+return [self _scroller];
+}
+
+- (CGRect)_visibleRectInEnclosingView:(UIView *)enclosingView
+{
+if (!enclosingView)
return self.bounds;
-CGRect exposedRect = [enclosingScrollView convertRect:enclosingScrollView.bounds toView:self];
+CGRect exposedRect = [enclosingView convertRect:enclosingView.bounds toView:self];
return CGRectIntersectsRect(exposedRect, self.bounds) ? CGRectIntersection(exposedRect, self.bounds) : CGRectZero;
}
@@ -2193,8 +2198,8 @@
CGRect visibleRectInContentCoordinates = [self convertRect:self.bounds toView:_contentView.get()];
-if (UIScrollView *enclosingScroller = [self _scroller]) {
-CGRect viewVisibleRect = [self _visibleRectInEnclosingScrollView:enclosingScroller];
+if (UIView *enclosingView = [self _enclosingViewForExposedRectComputation]) {
+CGRect viewVisibleRect = [self _visibleRectInEnclosingView:enclosingView];
CGRect viewVisibleContentRect = [self convertRect:viewVisibleRect toView:_contentView.get()];
visibleRectInContentCoordinates = CGRectIntersection(visibleRectInContentCoordinates, viewVisibleContentRect);
}
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h (216801 => 216802)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h 2017-05-12 23:12:13 UTC (rev 216801)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h 2017-05-12 23:29:28 UTC (rev 216802)
@@ -158,6 +158,9 @@
@property (nonatomic, setter=_setUnobscuredSafeArea
[webkit-changes] [216801] trunk
Title: [216801] trunk Revision 216801 Author mark@apple.com Date 2017-05-12 16:12:13 -0700 (Fri, 12 May 2017) Log Message WorkerRunLoop::Task::performTask() should check !scriptController->isTerminatingExecution(). https://bugs.webkit.org/show_bug.cgi?id=171775 Reviewed by Saam Barati. Source/_javascript_Core: Increased the number of frames captured in VM::nativeStackTraceOfLastThrow() from 25 to 100. From experience, I found that 25 is sometimes not sufficient for our debugging needs. Also added VM::throwingThread() to track which thread an exception was thrown in. This may be useful if the client is entering the VM from different threads. * runtime/ExceptionScope.cpp: (JSC::ExceptionScope::unexpectedExceptionMessage): * runtime/ExceptionScope.h: (JSC::ExceptionScope::exception): (JSC::ExceptionScope::unexpectedExceptionMessage): * runtime/Options.h: - Added the unexpectedExceptionStackTraceLimit option. * runtime/VM.cpp: (JSC::VM::throwException): * runtime/VM.h: (JSC::VM::throwingThread): (JSC::VM::clearException): Source/WebCore: Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate JS execution first, followed by posting a cleanup task to the worker, and lastly, it invokes terminate() on the WorkerRunLoop. As a result, before the run loop is terminated, the worker thread may observe the TerminatedExecutionException in JS code, bail out, see another JS task to run, re-enters the VM to run said JS code, and fails with an assertion due to the TerminatedExecutionException still being pending on VM entry. WorkerRunLoop::Task::performTask() already has a check to only allow a task to run if and only if !runLoop.terminated() and the task is not a clean up task. We'll fix the above race by changing WorkerRunLoop::Task::performTask() to check !context->script()->isTerminatingExecution() instead of !runLoop.terminated(). Since WorkerThread::stop() always scheduleExecutionTermination() before it terminates the run loop, !context->script()->isTerminatingExecution() implies !runLoop.terminated(). The only time that runLoop is terminated without scheduleExecutionTermination() being called is when WorkerThread::stop() is called before the WorkerThread has finished creating its WorkerGlobalScope. In this scenario, WorkerThread::stop() will still terminate the run loop. Hence, after the WorkerGlobalScope is created (in WorkerThread::workerThread()), we will check if the run loop has been terminated (i.e. stop() was called). If so, we'll scheduleExecutionTermination() there, and guarantee that if runloop.terminated() is true, then context->script()->isTerminatingExecution() is also true. Solutions that were considered but did not work (recorded for future reference): 1. In WorkerThread::stop(), call scheduleExecutionTermination() only after it posts the cleanup task and terminate the run loop. This did not work because this creates a race where the worker thread may run the cleanup task before WorkerThread::stop() finishes. As a result, the scriptController may be deleted before we get to invoke scheduleExecutionTermination() on it, thereby resulting in a use after free. To make this work, we would have to change the life cycle management strategy of the WorkerScriptController. This is a more risky change that we would want to take on at this time, and may also not be worth the gain. 2. Break scheduleExecutionTermination() up into 2 parts i.e. WorkerThread::stop() will: 1. set the scriptControllers m_isTerminatingExecution flag before posting the cleanup task and terminating the run loop, and 2. invoke VM::notifyNeedsTermination() after posting the cleanup task and terminating the run loop. This requires that we protect the liveness of the VM until we can invoke notifyNeedsTermination() on it. This did not work because: 1. We may end up destructing the VM in WorkerThread::stop() i.e. in the main web frame, but only the worker thread holds the JS lock for the VM. We can make the WorkerThread::stop() acquire the JS lock just before it releases the protected VM's RefPtr, but that would mean the main thread may be stuck waiting a bit for the worker thread to release its JSLock. This is not desirable. 2. In practice, changing the liveness period of the Worker VM relative to its WorkerScriptController and WorkerGlobalScope also has unexpected ramifications. We observed many worker tests failing with assertion failures and crashes due to this change. Hence, this approach is also a more risky change than it appears on the surface, and is not worth exploring at this time. In the end, changing WorkerRunLoop::Task::performTask() to check for !scriptController->isTerminatingExecution() is the most straight forward solution that is easy to prove correct. Also fixed a race in WorkerThread::workerThread() where it can delete the WorkerGlobalScope whil
[webkit-changes] [216800] trunk/Tools
Title: [216800] trunk/Tools
Revision 216800
Author beid...@apple.com
Date 2017-05-12 15:51:08 -0700 (Fri, 12 May 2017)
Log Message
REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
https://bugs.webkit.org/show_bug.cgi?id=172030
Unreviewed - Test gardening, in effect...
More exploration as to why this continues to fail on the bots.
This change should give us a smoking gun.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
(TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm
Diff
Modified: trunk/Tools/ChangeLog (216799 => 216800)
--- trunk/Tools/ChangeLog 2017-05-12 22:47:55 UTC (rev 216799)
+++ trunk/Tools/ChangeLog 2017-05-12 22:51:08 UTC (rev 216800)
@@ -1,3 +1,17 @@
+2017-05-12 Brady Eidson
+
+REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
+https://bugs.webkit.org/show_bug.cgi?id=172030
+
+Unreviewed - Test gardening, in effect...
+
+More exploration as to why this continues to fail on the bots.
+
+This change should give us a smoking gun.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
+(TEST):
+
2017-05-12 Hyungwook Lee
[GTK] Fix compile warnings in PlatformImageCairo.cpp
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm (216799 => 216800)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm 2017-05-12 22:47:55 UTC (rev 216799)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm 2017-05-12 22:51:08 UTC (rev 216800)
@@ -168,6 +168,12 @@
[[WKWebsiteDataStore defaultDataStore] fetchDataRecordsOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] completionHandler:^(NSArray *websiteDataRecords)
{
EXPECT_EQ(websiteDataRecords.count, 1ul);
+for (WKWebsiteDataRecord *record in websiteDataRecords) {
+EXPECT_STREQ("127.0.0.1", [record.displayName UTF8String]);
+for (NSString *type in record.dataTypes)
+EXPECT_STREQ([WKWebsiteDataTypeOfflineWebApplicationCache UTF8String], [type UTF8String]);
+}
+
originalWebsiteDataRecordCount = websiteDataRecords.count;
readyToContinue = true;
}];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216799] trunk/LayoutTests
Title: [216799] trunk/LayoutTests
Revision 216799
Author dba...@webkit.org
Date 2017-05-12 15:47:55 -0700 (Fri, 12 May 2017)
Log Message
Attempt to fix timeout failure of test plugins/navigator-plugin-crash.html in WebKit1
following
(https://bugs.webkit.org/show_bug.cgi?id=171712)
In r216798 I inadvertently added testRunner.setPopupBlockingEnabled(true) instead
instead of testRunner.setPopupBlockingEnabled(false) to disable the popup blocker.
* plugins/navigator-plugin-crash.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/plugins/navigator-plugin-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (216798 => 216799)
--- trunk/LayoutTests/ChangeLog 2017-05-12 22:43:22 UTC (rev 216798)
+++ trunk/LayoutTests/ChangeLog 2017-05-12 22:47:55 UTC (rev 216799)
@@ -4,12 +4,23 @@
following
(https://bugs.webkit.org/show_bug.cgi?id=171712)
+In r216798 I inadvertently added testRunner.setPopupBlockingEnabled(true) instead
+instead of testRunner.setPopupBlockingEnabled(false) to disable the popup blocker.
+
+* plugins/navigator-plugin-crash.html:
+
+2017-05-12 Daniel Bates
+
+Attempt to fix timeout failure of test plugins/navigator-plugin-crash.html in WebKit1
+following
+(https://bugs.webkit.org/show_bug.cgi?id=171712)
+
On WebKit1 we need to explicitly allow the test tool to open windows by calling
testRunner.setCanOpenWindows(). We should also call testRunner.setCloseRemainingWindowsWhenComplete(true)
to have the test tool close any open windows after running the test.
It is also good practice to explicitly disable the popup blocker by calling
-testRunner.setPopupBlockingEnabled(true);.
+testRunner.setPopupBlockingEnabled(false).
* plugins/navigator-plugin-crash.html:
Modified: trunk/LayoutTests/plugins/navigator-plugin-crash.html (216798 => 216799)
--- trunk/LayoutTests/plugins/navigator-plugin-crash.html 2017-05-12 22:43:22 UTC (rev 216798)
+++ trunk/LayoutTests/plugins/navigator-plugin-crash.html 2017-05-12 22:47:55 UTC (rev 216799)
@@ -8,7 +8,7 @@
if (window.testRunner) {
testRunner.dumpAsText();
testRunner.setCanOpenWindows();
-testRunner.setPopupBlockingEnabled(true);
+testRunner.setPopupBlockingEnabled(false);
testRunner.setCloseRemainingWindowsWhenComplete(true);
testRunner.waitUntilDone();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216798] trunk/LayoutTests
Title: [216798] trunk/LayoutTests Revision 216798 Author dba...@webkit.org Date 2017-05-12 15:43:22 -0700 (Fri, 12 May 2017) Log Message Attempt to fix timeout failure of test plugins/navigator-plugin-crash.html in WebKit1 following (https://bugs.webkit.org/show_bug.cgi?id=171712) On WebKit1 we need to explicitly allow the test tool to open windows by calling testRunner.setCanOpenWindows(). We should also call testRunner.setCloseRemainingWindowsWhenComplete(true) to have the test tool close any open windows after running the test. It is also good practice to explicitly disable the popup blocker by calling testRunner.setPopupBlockingEnabled(true);. * plugins/navigator-plugin-crash.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/plugins/navigator-plugin-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (216797 => 216798) --- trunk/LayoutTests/ChangeLog 2017-05-12 22:15:00 UTC (rev 216797) +++ trunk/LayoutTests/ChangeLog 2017-05-12 22:43:22 UTC (rev 216798) @@ -1,3 +1,18 @@ +2017-05-12 Daniel Bates + +Attempt to fix timeout failure of test plugins/navigator-plugin-crash.html in WebKit1 +following +(https://bugs.webkit.org/show_bug.cgi?id=171712) + +On WebKit1 we need to explicitly allow the test tool to open windows by calling +testRunner.setCanOpenWindows(). We should also call testRunner.setCloseRemainingWindowsWhenComplete(true) +to have the test tool close any open windows after running the test. + +It is also good practice to explicitly disable the popup blocker by calling +testRunner.setPopupBlockingEnabled(true);. + +* plugins/navigator-plugin-crash.html: + 2017-05-11 Jiewen Tan Check existence of a page before accessing its plugins Modified: trunk/LayoutTests/plugins/navigator-plugin-crash.html (216797 => 216798) --- trunk/LayoutTests/plugins/navigator-plugin-crash.html 2017-05-12 22:15:00 UTC (rev 216797) +++ trunk/LayoutTests/plugins/navigator-plugin-crash.html 2017-05-12 22:43:22 UTC (rev 216798) @@ -7,6 +7,9 @@
[webkit-changes] [216797] tags/Safari-604.1.22/
Title: [216797] tags/Safari-604.1.22/ Revision 216797 Author bshaf...@apple.com Date 2017-05-12 15:15:00 -0700 (Fri, 12 May 2017) Log Message Tag Safari-604.1.22. Added Paths tags/Safari-604.1.22/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216796] trunk/Source/WTF
Title: [216796] trunk/Source/WTF Revision 216796 Author commit-qu...@webkit.org Date 2017-05-12 15:05:24 -0700 (Fri, 12 May 2017) Log Message Include algorithm before using std::min https://bugs.webkit.org/show_bug.cgi?id=171733 Patch by Ting-Wei Lan on 2017-05-12 Reviewed by Chris Dumez. * wtf/text/StringCommon.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/text/StringCommon.h Diff Modified: trunk/Source/WTF/ChangeLog (216795 => 216796) --- trunk/Source/WTF/ChangeLog 2017-05-12 22:02:11 UTC (rev 216795) +++ trunk/Source/WTF/ChangeLog 2017-05-12 22:05:24 UTC (rev 216796) @@ -1,3 +1,12 @@ +2017-05-12 Ting-Wei Lan + +Include algorithm before using std::min +https://bugs.webkit.org/show_bug.cgi?id=171733 + +Reviewed by Chris Dumez. + +* wtf/text/StringCommon.h: + 2017-05-12 Andreas Kling More aggressive memory kill limits. Modified: trunk/Source/WTF/wtf/text/StringCommon.h (216795 => 216796) --- trunk/Source/WTF/wtf/text/StringCommon.h 2017-05-12 22:02:11 UTC (rev 216795) +++ trunk/Source/WTF/wtf/text/StringCommon.h 2017-05-12 22:05:24 UTC (rev 216796) @@ -26,6 +26,7 @@ #ifndef StringCommon_h #define StringCommon_h +#include #include #include #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216794] trunk/Source/WebKit2
Title: [216794] trunk/Source/WebKit2 Revision 216794 Author cdu...@apple.com Date 2017-05-12 15:00:00 -0700 (Fri, 12 May 2017) Log Message Stop using PassRefPtr under WebKit2/UIProcess https://bugs.webkit.org/show_bug.cgi?id=172029 Reviewed by Alex Christensen. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _takeViewSnapshot]): * UIProcess/API/Cocoa/WKWebViewInternal.h: * UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::registerEditCommand): * UIProcess/API/gtk/PageClientImpl.h: * UIProcess/API/gtk/WebKitFaviconDatabase.cpp: (getIconSurfaceSynchronously): * UIProcess/API/gtk/WebKitWebContext.cpp: * UIProcess/API/wpe/PageClientImpl.cpp: (WebKit::PageClientImpl::registerEditCommand): * UIProcess/API/wpe/PageClientImpl.h: * UIProcess/Cocoa/WebViewImpl.h: * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::registerEditCommand): * UIProcess/DefaultUndoController.cpp: (WebKit::DefaultUndoController::registerEditCommand): * UIProcess/DefaultUndoController.h: * UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::create): * UIProcess/Downloads/DownloadProxy.h: * UIProcess/GeolocationPermissionRequestManagerProxy.cpp: (WebKit::GeolocationPermissionRequestManagerProxy::createRequest): * UIProcess/GeolocationPermissionRequestManagerProxy.h: * UIProcess/InspectorServer/HTTPRequest.cpp: (WebKit::HTTPRequest::parseHTTPRequestFromBuffer): * UIProcess/InspectorServer/HTTPRequest.h: * UIProcess/InspectorServer/WebInspectorServer.cpp: (WebKit::WebInspectorServer::didReceiveUnrecognizedHTTPRequest): (WebKit::WebInspectorServer::didReceiveWebSocketUpgradeHTTPRequest): (WebKit::WebInspectorServer::didEstablishWebSocketConnection): * UIProcess/InspectorServer/WebInspectorServer.h: * UIProcess/InspectorServer/WebSocketServerClient.h: (WebKit::WebSocketServerClient::didReceiveUnrecognizedHTTPRequest): (WebKit::WebSocketServerClient::didReceiveWebSocketUpgradeHTTPRequest): (WebKit::WebSocketServerClient::didEstablishWebSocketConnection): * UIProcess/InspectorServer/WebSocketServerConnection.cpp: (WebKit::WebSocketServerConnection::readHTTPMessage): (WebKit::WebSocketServerConnection::upgradeToWebSocketServerConnection): * UIProcess/InspectorServer/WebSocketServerConnection.h: * UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp: (WebKit::NotificationPermissionRequestManagerProxy::createRequest): * UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h: * UIProcess/Notifications/WebNotificationProvider.cpp: (WebKit::WebNotificationProvider::notificationPermissions): * UIProcess/Notifications/WebNotificationProvider.h: * UIProcess/PageClient.h: * UIProcess/Storage/LocalStorageDatabase.cpp: * UIProcess/WebContextMenuListenerProxy.h: * UIProcess/WebCookieManagerProxy.h: * UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::unapply): (WebKit::WebEditCommandProxy::reapply): * UIProcess/WebEditCommandProxy.h: * UIProcess/WebGrammarDetail.cpp: (WebKit::WebGrammarDetail::create): * UIProcess/WebGrammarDetail.h: * UIProcess/WebPageProxy.cpp: (WebKit::ExceededDatabaseQuotaRecords::createRecord): (WebKit::WebPageProxy::registerEditCommand): (WebKit::WebPageProxy::didReceiveAuthenticationChallengeProxy): (WebKit::WebPageProxy::exceededDatabaseQuota): (WebKit::WebPageProxy::reachedApplicationCacheOriginQuota): (WebKit::WebPageProxy::takeViewSnapshot): * UIProcess/WebPageProxy.h: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::plugInAutoStartOriginHashes): * UIProcess/WebProcessPool.h: * UIProcess/WebProcessProxy.h: * UIProcess/ios/PageClientImplIOS.h: * UIProcess/ios/PageClientImplIOS.mm: (-[WKEditCommandObjC initWithWebEditCommandProxy:]): (WebKit::PageClientImpl::registerEditCommand): (WebKit::PageClientImpl::saveImageToLibrary): (WebKit::PageClientImpl::setDragImage): (WebKit::PageClientImpl::takeViewSnapshot): * UIProcess/ios/WKGeolocationProviderIOS.mm: (-[WKWebAllowDenyPolicyListener initWithPermissionRequestProxy:]): * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::saveImageToLibrary): * UIProcess/mac/PageClientImpl.h: * UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::registerEditCommand): (WebKit::PageClientImpl::setDragImage): (WebKit::PageClientImpl::setPromisedDataForImage): (WebKit::PageClientImpl::takeViewSnapshot): * UIProcess/mac/WKImmediateActionController.mm: (-[WKImmediateActionController _webHitTestResult]): * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::setDragImage): (WebKit::WebPageProxy::setPromisedDataForImage): * WebProcess/IconDatabase/WebIconDatabaseProxy.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp trunk/Source/WebKit2/UIProcess/API/C/WKGrammarDetail.cpp trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFaviconDatab
[webkit-changes] [216793] tags/Safari-604.1.21.2/
Title: [216793] tags/Safari-604.1.21.2/ Revision 216793 Author jmarc...@apple.com Date 2017-05-12 14:56:27 -0700 (Fri, 12 May 2017) Log Message Tag Safari-604.1.21.2. Added Paths tags/Safari-604.1.21.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216792] trunk/Source/WebCore
Title: [216792] trunk/Source/WebCore
Revision 216792
Author za...@apple.com
Date 2017-05-12 13:54:05 -0700 (Fri, 12 May 2017)
Log Message
[iOS WK1] Do not try to layout a subframe if its document has not been constructed yet.
https://bugs.webkit.org/show_bug.cgi?id=172042
Reviewed by Antti Koivisto.
On iOS WK1 we can end up in an inconsistent state, where
1. the web thread is inside a newly injected iframe's document's c'tor and
2. waiting on a delegate callback on the main thread
while the main thread
1. executes a pending didLayout() task
2. triggers layout on the newly injected iframe.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetPosition):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderWidget.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (216791 => 216792)
--- trunk/Source/WebCore/ChangeLog 2017-05-12 20:49:26 UTC (rev 216791)
+++ trunk/Source/WebCore/ChangeLog 2017-05-12 20:54:05 UTC (rev 216792)
@@ -1,3 +1,21 @@
+2017-05-12 Zalan Bujtas
+
+[iOS WK1] Do not try to layout a subframe if its document has not been constructed yet.
+https://bugs.webkit.org/show_bug.cgi?id=172042
+
+
+Reviewed by Antti Koivisto.
+
+On iOS WK1 we can end up in an inconsistent state, where
+1. the web thread is inside a newly injected iframe's document's c'tor and
+2. waiting on a delegate callback on the main thread
+while the main thread
+1. executes a pending didLayout() task
+2. triggers layout on the newly injected iframe.
+
+* rendering/RenderWidget.cpp:
+(WebCore::RenderWidget::updateWidgetPosition):
+
2017-05-11 Jiewen Tan
Check existence of a page before accessing its plugins
Modified: trunk/Source/WebCore/rendering/RenderWidget.cpp (216791 => 216792)
--- trunk/Source/WebCore/rendering/RenderWidget.cpp 2017-05-12 20:49:26 UTC (rev 216791)
+++ trunk/Source/WebCore/rendering/RenderWidget.cpp 2017-05-12 20:54:05 UTC (rev 216792)
@@ -324,7 +324,7 @@
if (is(*m_widget)) {
FrameView& frameView = downcast(*m_widget);
// Check the frame's page to make sure that the frame isn't in the process of being destroyed.
-if ((widgetSizeChanged || frameView.needsLayout()) && frameView.frame().page())
+if ((widgetSizeChanged || frameView.needsLayout()) && frameView.frame().page() && frameView.frame().document())
frameView.layout();
}
return ChildWidgetState::Valid;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216791] trunk
Title: [216791] trunk
Revision 216791
Author commit-qu...@webkit.org
Date 2017-05-12 13:49:26 -0700 (Fri, 12 May 2017)
Log Message
Add UIClient callback for when picture-in-picture is activated.
https://bugs.webkit.org/show_bug.cgi?id=172023
Patch by Jeremy Jones on 2017-05-12
Reviewed by Simon Fraser.
Source/WebKit2:
Add WKUIPageClientV10 with setHasVideoInPictureInPicture.
* UIProcess/API/APIUIClient.h:
(API::UIClient::setHasVideoInPictureInPicture):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/C/WKPageUIClient.h:
* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged):
Tools:
Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
* TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
(onLoadedCompletedCallback):
(waitUntilOnLoadIsCompleted):
(didFinishLoadForFrame):
(setHasVideoInPictureInPicture):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APIUIClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPageUIClient.h
trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (216790 => 216791)
--- trunk/Source/WebKit2/ChangeLog 2017-05-12 20:43:02 UTC (rev 216790)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-12 20:49:26 UTC (rev 216791)
@@ -1,3 +1,21 @@
+2017-05-12 Jeremy Jones
+
+Add UIClient callback for when picture-in-picture is activated.
+https://bugs.webkit.org/show_bug.cgi?id=172023
+
+Reviewed by Simon Fraser.
+
+Add WKUIPageClientV10 with setHasVideoInPictureInPicture.
+
+* UIProcess/API/APIUIClient.h:
+(API::UIClient::setHasVideoInPictureInPicture):
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPageUIClient):
+* UIProcess/API/C/WKPageUIClient.h:
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
+(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
+(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged):
+
2017-05-12 Brent Fulgham
REGRESSION(r213564): Flash audio playback failures
Modified: trunk/Source/WebKit2/UIProcess/API/APIUIClient.h (216790 => 216791)
--- trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2017-05-12 20:43:02 UTC (rev 216790)
+++ trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2017-05-12 20:49:26 UTC (rev 216791)
@@ -79,6 +79,7 @@
virtual void fullscreenMayReturnToInline(WebKit::WebPageProxy*) { }
virtual void didEnterFullscreen(WebKit::WebPageProxy*) { }
virtual void didExitFullscreen(WebKit::WebPageProxy*) { }
+virtual void setHasVideoInPictureInPicture(WebKit::WebPageProxy*, bool) { }
virtual void close(WebKit::WebPageProxy*) { }
virtual void takeFocus(WebKit::WebPageProxy*, WKFocusDirection) { }
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (216790 => 216791)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2017-05-12 20:43:02 UTC (rev 216790)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2017-05-12 20:49:26 UTC (rev 216791)
@@ -110,7 +110,7 @@
};
template<> struct ClientTraits {
-typedef std::tuple Versions;
+typedef std::tuple Versions;
};
#if ENABLE(CONTEXT_MENUS)
@@ -1768,6 +1768,14 @@
m_client.fullscreenMayReturnToInline(toAPI(page), m_client.base.clientInfo);
}
+
+void setHasVideoInPictureInPicture(WebPageProxy* page, bool hasVideoInPictureInPicture) override
+{
+if (!m_client.setHasVideoInPictureInPicture)
+return;
+
+m_client.setHasVideoInPictureInPicture(toAPI(page), hasVideoInPictureInPicture, m_client.base.clientInfo);
+}
void close(WebPageProxy* page) override
{
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPageUIClient.h (216790 => 216791)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPageUIClient.h 2017-05-12 20:43:02 UTC (rev 216790)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPageUIClient.h 2017-05-12 20:49:26 UTC (rev 216791)
@@ -119,10 +119,10 @@
typedef void (*WKPageMediaSessionMetadataDidChangeCallback)(WKPageRef page, WKMediaSessionMetadataRef metadata, const void* clientInfo);
typedef void (*WKHandleAutoplayEventCallback)(WKPageRef page, WKAutoplayEvent event, WKAutoplayEventFlags flags, const void* clientInfo);
typedef void (*WKFullscreenMayReturnToInlineCallback)(WKPageRef page, cons
[webkit-changes] [216790] trunk/Source/WebKit2
Title: [216790] trunk/Source/WebKit2 Revision 216790 Author bfulg...@apple.com Date 2017-05-12 13:43:02 -0700 (Fri, 12 May 2017) Log Message REGRESSION(r213564): Flash audio playback failures https://bugs.webkit.org/show_bug.cgi?id=171876 Reviewed by Alexey Proskuryakov. The IOKit property filters added in r213564 need to be expanded to support some Flash features. * PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in Diff Modified: trunk/Source/WebKit2/ChangeLog (216789 => 216790) --- trunk/Source/WebKit2/ChangeLog 2017-05-12 20:37:54 UTC (rev 216789) +++ trunk/Source/WebKit2/ChangeLog 2017-05-12 20:43:02 UTC (rev 216790) @@ -1,5 +1,18 @@ 2017-05-12 Brent Fulgham +REGRESSION(r213564): Flash audio playback failures +https://bugs.webkit.org/show_bug.cgi?id=171876 + + +Reviewed by Alexey Proskuryakov. + +The IOKit property filters added in r213564 need to be expanded to support +some Flash features. + +* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in: + +2017-05-12 Brent Fulgham + [WK2][macOS] Add a mach-lookup exception for 'com.apple.analyticsd' https://bugs.webkit.org/show_bug.cgi?id=172040 Modified: trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in (216789 => 216790) --- trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in 2017-05-12 20:37:54 UTC (rev 216789) +++ trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in 2017-05-12 20:43:02 UTC (rev 216790) @@ -22,7 +22,8 @@ ; THE POSSIBILITY OF SUCH DAMAGE. (version 1) -(deny default) +;(deny default) +(allow default (with report)) (allow system-audit file-read-metadata) (import "system.sb") @@ -67,6 +68,7 @@ (iokit-property "IOVARendererID") (iokit-property-regex #"^MetalPlugin(Name|ClassName)") (iokit-property "NoAutoRoute") +(iokit-property "Protocol Characteristics") (iokit-property "SupportAudioAUUC") (iokit-property "board-id") (iokit-property "idProduct") @@ -279,6 +281,7 @@ ;; Various services required by AppKit and other frameworks (allow mach-lookup +(global-name "com.apple.audio.AudioComponentRegistrar") (global-name "com.apple.CoreServices.coreservicesd") (global-name "com.apple.DiskArbitration.diskarbitrationd") (global-name "com.apple.FileCoordination") @@ -339,7 +342,6 @@ (allow network-inbound (local udp)) - ;; Open and Save panels (define (webkit-powerbox) (allow file-read* (literal "/Library/Preferences/com.apple.ViewBridge.plist")) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216789] trunk
Title: [216789] trunk
Revision 216789
Author jiewen_...@apple.com
Date 2017-05-12 13:37:54 -0700 (Fri, 12 May 2017)
Log Message
Check existence of a page before accessing its plugins
https://bugs.webkit.org/show_bug.cgi?id=171712
Reviewed by Brent Fulgham.
Source/WebCore:
Test: plugins/navigator-plugin-crash.html
* plugins/DOMPlugin.cpp:
(WebCore::DOMPlugin::item):
(WebCore::DOMPlugin::namedItem):
LayoutTests:
* plugins/navigator-plugin-crash-expected.txt: Added.
* plugins/navigator-plugin-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/DOMPlugin.cpp
Added Paths
trunk/LayoutTests/plugins/navigator-plugin-crash-expected.txt
trunk/LayoutTests/plugins/navigator-plugin-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (216788 => 216789)
--- trunk/LayoutTests/ChangeLog 2017-05-12 20:37:46 UTC (rev 216788)
+++ trunk/LayoutTests/ChangeLog 2017-05-12 20:37:54 UTC (rev 216789)
@@ -1,3 +1,14 @@
+2017-05-11 Jiewen Tan
+
+Check existence of a page before accessing its plugins
+https://bugs.webkit.org/show_bug.cgi?id=171712
+
+
+Reviewed by Brent Fulgham.
+
+* plugins/navigator-plugin-crash-expected.txt: Added.
+* plugins/navigator-plugin-crash.html: Added.
+
2017-05-12 Romain Bellessort
[Readable Streams API] Add ReadableStreamBYOBReader closed getter
Added: trunk/LayoutTests/plugins/navigator-plugin-crash-expected.txt (0 => 216789)
--- trunk/LayoutTests/plugins/navigator-plugin-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/plugins/navigator-plugin-crash-expected.txt 2017-05-12 20:37:54 UTC (rev 216789)
@@ -0,0 +1 @@
+Test passes if WebKit doesn't crash. {"0":null,"1":null}
Added: trunk/LayoutTests/plugins/navigator-plugin-crash.html (0 => 216789)
--- trunk/LayoutTests/plugins/navigator-plugin-crash.html (rev 0)
+++ trunk/LayoutTests/plugins/navigator-plugin-crash.html 2017-05-12 20:37:54 UTC (rev 216789)
@@ -0,0 +1,25 @@
+
+
+
+
+
+Test passes if WebKit doesn't crash.
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+_onload_ = function() {
+var t1 = window.open('target.html', '_blank');
+var data = ""
+t1.close();
+setTimeout(function() {
+document.body.innerHTML += JSON.stringify(data);
+if (window.testRunner)
+testRunner.notifyDone();
+}, 200);
+}
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (216788 => 216789)
--- trunk/Source/WebCore/ChangeLog 2017-05-12 20:37:46 UTC (rev 216788)
+++ trunk/Source/WebCore/ChangeLog 2017-05-12 20:37:54 UTC (rev 216789)
@@ -1,3 +1,17 @@
+2017-05-11 Jiewen Tan
+
+Check existence of a page before accessing its plugins
+https://bugs.webkit.org/show_bug.cgi?id=171712
+
+
+Reviewed by Brent Fulgham.
+
+Test: plugins/navigator-plugin-crash.html
+
+* plugins/DOMPlugin.cpp:
+(WebCore::DOMPlugin::item):
+(WebCore::DOMPlugin::namedItem):
+
2017-05-12 Simon Fraser
Add some logging for layer tree commits, and resize and orientation change events
Modified: trunk/Source/WebCore/plugins/DOMPlugin.cpp (216788 => 216789)
--- trunk/Source/WebCore/plugins/DOMPlugin.cpp 2017-05-12 20:37:46 UTC (rev 216788)
+++ trunk/Source/WebCore/plugins/DOMPlugin.cpp 2017-05-12 20:37:54 UTC (rev 216789)
@@ -58,7 +58,7 @@
RefPtr DOMPlugin::item(unsigned index)
{
-if (index >= m_pluginInfo.mimes.size())
+if (index >= m_pluginInfo.mimes.size() || !m_frame || !m_frame->page())
return nullptr;
MimeClassInfo mime = m_pluginInfo.mimes[index];
@@ -76,6 +76,9 @@
RefPtr DOMPlugin::namedItem(const AtomicString& propertyName)
{
+if (!m_frame || !m_frame->page())
+return nullptr;
+
Vector mimes;
Vector mimePluginIndices;
m_pluginData->getWebVisibleMimesAndPluginIndices(mimes, mimePluginIndices);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216788] trunk/Tools
Title: [216788] trunk/Tools Revision 216788 Author jbed...@apple.com Date 2017-05-12 13:37:46 -0700 (Fri, 12 May 2017) Log Message Unreviewed follow-up to r216776. * Scripts/webkitpy/port/base.py: (Port.path_to_crash_logs): Raise not implemented. * Scripts/webkitpy/port/test.py: (TestPort.path_to_crash_logs): Return results directory as the location of crash logs. * Scripts/webkitpy/port/win.py: (WinPort.path_to_crash_logs): Ditto. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/base.py trunk/Tools/Scripts/webkitpy/port/test.py trunk/Tools/Scripts/webkitpy/port/win.py Diff Modified: trunk/Tools/ChangeLog (216787 => 216788) --- trunk/Tools/ChangeLog 2017-05-12 20:32:23 UTC (rev 216787) +++ trunk/Tools/ChangeLog 2017-05-12 20:37:46 UTC (rev 216788) @@ -1,3 +1,14 @@ +2017-05-12 Jonathan Bedard + +Unreviewed follow-up to r216776. + +* Scripts/webkitpy/port/base.py: +(Port.path_to_crash_logs): Raise not implemented. +* Scripts/webkitpy/port/test.py: +(TestPort.path_to_crash_logs): Return results directory as the location of crash logs. +* Scripts/webkitpy/port/win.py: +(WinPort.path_to_crash_logs): Ditto. + 2017-05-12 Alexey Proskuryakov Bot watcher's dashboard shows results links twice sometimes Modified: trunk/Tools/Scripts/webkitpy/port/base.py (216787 => 216788) --- trunk/Tools/Scripts/webkitpy/port/base.py 2017-05-12 20:32:23 UTC (rev 216787) +++ trunk/Tools/Scripts/webkitpy/port/base.py 2017-05-12 20:37:46 UTC (rev 216788) @@ -1348,7 +1348,7 @@ return driver.Driver def path_to_crash_logs(self): -return self.results_directory() +raise NotImplementedError def _get_crash_log(self, name, pid, stdout, stderr, newer_than): name_str = name or '' Modified: trunk/Tools/Scripts/webkitpy/port/test.py (216787 => 216788) --- trunk/Tools/Scripts/webkitpy/port/test.py 2017-05-12 20:32:23 UTC (rev 216787) +++ trunk/Tools/Scripts/webkitpy/port/test.py 2017-05-12 20:37:46 UTC (rev 216788) @@ -463,6 +463,9 @@ def _driver_class(self): return TestDriver +def path_to_crash_logs(self): +return self.results_directory() + def start_http_server(self, additional_dirs=None): pass Modified: trunk/Tools/Scripts/webkitpy/port/win.py (216787 => 216788) --- trunk/Tools/Scripts/webkitpy/port/win.py 2017-05-12 20:32:23 UTC (rev 216787) +++ trunk/Tools/Scripts/webkitpy/port/win.py 2017-05-12 20:37:46 UTC (rev 216788) @@ -369,6 +369,9 @@ self.restore_crash_log_saving() super(WinPort, self).clean_up_test_run() +def path_to_crash_logs(self): +return self.results_directory() + def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True): # Note that we do slow-spin here and wait, since it appears the time # ReportCrash takes to actually write and flush the file varies when there are ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216785] branches/safari-604.1.21-branch/Source/WTF
Title: [216785] branches/safari-604.1.21-branch/Source/WTF
Revision 216785
Author jmarc...@apple.com
Date 2017-05-12 13:32:19 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216772. rdar://problem/31969082
Modified Paths
branches/safari-604.1.21-branch/Source/WTF/ChangeLog
branches/safari-604.1.21-branch/Source/WTF/wtf/MemoryPressureHandler.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WTF/ChangeLog (216784 => 216785)
--- branches/safari-604.1.21-branch/Source/WTF/ChangeLog 2017-05-12 20:32:17 UTC (rev 216784)
+++ branches/safari-604.1.21-branch/Source/WTF/ChangeLog 2017-05-12 20:32:19 UTC (rev 216785)
@@ -1,3 +1,22 @@
+2017-05-12 Jason Marcell
+
+Cherry-pick r216772. rdar://problem/31969082
+
+2017-05-12 Andreas Kling
+
+More aggressive memory kill limits.
+https://bugs.webkit.org/show_bug.cgi?id=172037
+
+
+Reviewed by Michael Saboff.
+
+Bring down the memory kill limits to 4GB for active processes, and 2GB for inactive.
+Also make MemoryUsagePolicy::Strict kick in above 1.5GB.
+
+* wtf/MemoryPressureHandler.cpp:
+(WTF::MemoryPressureHandler::thresholdForMemoryKill):
+(WTF::thresholdForPolicy):
+
2017-05-03 Mark Lam
Use the CLoop for CPU(ARM64E).
Modified: branches/safari-604.1.21-branch/Source/WTF/wtf/MemoryPressureHandler.cpp (216784 => 216785)
--- branches/safari-604.1.21-branch/Source/WTF/wtf/MemoryPressureHandler.cpp 2017-05-12 20:32:17 UTC (rev 216784)
+++ branches/safari-604.1.21-branch/Source/WTF/wtf/MemoryPressureHandler.cpp 2017-05-12 20:32:19 UTC (rev 216785)
@@ -79,8 +79,8 @@
{
#if CPU(X86_64) || CPU(ARM64)
if (m_processState == WebsamProcessState::Active)
-return 16 * GB;
-return 4 * GB;
+return 4 * GB;
+return 2 * GB;
#else
return 3 * GB;
#endif
@@ -92,7 +92,7 @@
case MemoryUsagePolicy::Conservative:
return 1 * GB;
case MemoryUsagePolicy::Strict:
-return 2 * GB;
+return 1.5 * GB;
case MemoryUsagePolicy::Unrestricted:
default:
ASSERT_NOT_REACHED();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216786] trunk/Tools
Title: [216786] trunk/Tools
Revision 216786
Author a...@apple.com
Date 2017-05-12 13:32:20 -0700 (Fri, 12 May 2017)
Log Message
Bot watcher's dashboard shows results links twice sometimes
https://bugs.webkit.org/show_bug.cgi?id=172043
Reviewed by Tim Horton.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (216785 => 216786)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2017-05-12 20:32:19 UTC (rev 216785)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2017-05-12 20:32:20 UTC (rev 216786)
@@ -255,7 +255,7 @@
iteration.failedTestSteps.forEach(function(failedStep) {
if (failedStep.name === "layout-test")
addResultKind(this._testStepFailureDescriptionWithCount(failedStep), iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration));
-if (failedStep.name === "dashboard-tests")
+else if (failedStep.name === "dashboard-tests")
addResultKind(this._testStepFailureDescription(failedStep), iteration.queue.buildbot.dashboardTestResultsURLForIteration(iteration));
else
addResultKind(this._testStepFailureDescriptionWithCount(failedStep), failedStep.URL);
Modified: trunk/Tools/ChangeLog (216785 => 216786)
--- trunk/Tools/ChangeLog 2017-05-12 20:32:19 UTC (rev 216785)
+++ trunk/Tools/ChangeLog 2017-05-12 20:32:20 UTC (rev 216786)
@@ -1,3 +1,13 @@
+2017-05-12 Alexey Proskuryakov
+
+Bot watcher's dashboard shows results links twice sometimes
+https://bugs.webkit.org/show_bug.cgi?id=172043
+
+Reviewed by Tim Horton.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+(BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
+
2017-05-12 Brady Eidson
REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216780] branches/safari-604.1.21-branch/Source/WebCore
Title: [216780] branches/safari-604.1.21-branch/Source/WebCore
Revision 216780
Author jmarc...@apple.com
Date 2017-05-12 13:31:59 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216215. rdar://problem/31999512
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/inspector/InspectorPageAgent.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216779 => 216780)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 20:27:42 UTC (rev 216779)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 20:31:59 UTC (rev 216780)
@@ -1,3 +1,20 @@
+2017-05-12 Jason Marcell
+
+Cherry-pick r216215. rdar://problem/31999512
+
+2017-05-04 Joseph Pecoraro
+
+REGRESSION(r216138): Web Inspector: ASSERT(!content.isNull()) when checking for source map url opening inspector
+https://bugs.webkit.org/show_bug.cgi?id=171697
+
+
+Reviewed by Matt Baker.
+
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::cachedResourceContent):
+Always set base64Encoded when returning true. Return the empty
+string instead of a null string matching previous behavior.
+
2017-05-12 Matthew Hanson
Cherry-pick r216432. rdar://problem/32051782
Modified: branches/safari-604.1.21-branch/Source/WebCore/inspector/InspectorPageAgent.cpp (216779 => 216780)
--- branches/safari-604.1.21-branch/Source/WebCore/inspector/InspectorPageAgent.cpp 2017-05-12 20:27:42 UTC (rev 216779)
+++ branches/safari-604.1.21-branch/Source/WebCore/inspector/InspectorPageAgent.cpp 2017-05-12 20:31:59 UTC (rev 216780)
@@ -115,12 +115,13 @@
if (!cachedResource)
return false;
+*base64Encoded = !hasTextContent(cachedResource);
+
if (!cachedResource->encodedSize()) {
-*result = String();
+*result = emptyString();
return true;
}
-*base64Encoded = !hasTextContent(cachedResource);
if (*base64Encoded) {
if (auto* buffer = cachedResource->resourceBuffer()) {
*result = base64Encode(buffer->data(), buffer->size());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216782] branches/safari-604.1.21-branch
Title: [216782] branches/safari-604.1.21-branch Revision 216782 Author jmarc...@apple.com Date 2017-05-12 13:32:08 -0700 (Fri, 12 May 2017) Log Message Cherry-pick r216712. rdar://problem/32117885 Modified Paths branches/safari-604.1.21-branch/LayoutTests/ChangeLog branches/safari-604.1.21-branch/LayoutTests/webrtc/audio-peer-connection-webaudio.html branches/safari-604.1.21-branch/LayoutTests/webrtc/audio-replace-track-expected.txt branches/safari-604.1.21-branch/LayoutTests/webrtc/audio-replace-track.html branches/safari-604.1.21-branch/LayoutTests/webrtc/peer-connection-audio-mute.html branches/safari-604.1.21-branch/LayoutTests/webrtc/peer-connection-audio-mute2.html branches/safari-604.1.21-branch/LayoutTests/webrtc/peer-connection-remote-audio-mute.html branches/safari-604.1.21-branch/LayoutTests/webrtc/peer-connection-remote-audio-mute2.html branches/safari-604.1.21-branch/LayoutTests/webrtc/routines.js branches/safari-604.1.21-branch/LayoutTests/webrtc/video-replace-track-expected.txt branches/safari-604.1.21-branch/LayoutTests/webrtc/video-replace-track.html branches/safari-604.1.21-branch/Source/WebCore/ChangeLog branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/RealtimeMediaSource.h branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/AVAudioCaptureSource.mm branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.h branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp branches/safari-604.1.21-branch/Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp branches/safari-604.1.21-branch/Source/WebCore/platform/mock/MockRealtimeAudioSource.h branches/safari-604.1.21-branch/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp branches/safari-604.1.21-branch/Source/WebCore/platform/mock/MockRealtimeVideoSource.h Added Paths branches/safari-604.1.21-branch/LayoutTests/platform/ios/mediastream/ branches/safari-604.1.21-branch/LayoutTests/platform/ios/mediastream/getUserMedia-single-capture-expected.txt branches/safari-604.1.21-branch/LayoutTests/platform/ios/mediastream/getUserMedia-single-capture.html Diff Modified: branches/safari-604.1.21-branch/LayoutTests/ChangeLog (216781 => 216782) --- branches/safari-604.1.21-branch/LayoutTests/ChangeLog 2017-05-12 20:32:01 UTC (rev 216781) +++ branches/safari-604.1.21-branch/LayoutTests/ChangeLog 2017-05-12 20:32:08 UTC (rev 216782) @@ -1,3 +1,31 @@ +2017-05-12 Jason Marcell + +Cherry-pick r216712. rdar://problem/32117885 + +2017-05-11 Youenn Fablet + +[iOS] Unset active media capture source when stopped capturing +https://bugs.webkit.org/show_bug.cgi?id=171815 + + +Reviewed by Eric Carlson. + +Improving the existing tests for better reliability and debugability. +Updating tests to use less webkitAudioContext. + +* platform/ios/mediastream/getUserMedia-single-capture-expected.txt: Added. +* platform/ios/mediastream/getUserMedia-single-capture.html: Added. +* webrtc/audio-peer-connection-webaudio.html: +* webrtc/audio-replace-track-expected.txt: +* webrtc/audio-replace-track.html: +* webrtc/peer-connection-audio-mute.html: +* webrtc/peer-connection-audio-mute2.html: +* webrtc/peer-connection-remote-audio-mute.html: +* webrtc/peer-connection-remote-audio-mute2.html: +* webrtc/routines.js: +* webrtc/video-replace-track-expected.txt: +* webrtc/video-replace-track.html: + 2017-05-11 Jason Marcell Cherry-pick r216599. rdar://problem/31201793 Added: branches/safari-604.1.21-branch/LayoutTests/platform/ios/mediastream/getUserMedia-single-capture-expected.txt (0 => 216782) --- branches/safari-604.1.21-branch/LayoutTests/platform/ios/mediastream/getUserMedia-single-capture-expected.txt (rev 0) +++ branches/safari-604.1.21-branch/LayoutTests/platform/ios/mediastream/getUserMedia-single-capture-expected.txt 2017-05-12 20:32:08 UTC (rev 216782) @@ -0,0 +1,3 @@ + +PASS Testing successive getUserMedia calls + Added: branches/safari-604.1.21-branch/LayoutTests/platform/ios/mediastream/getUserMedia-single-capture.html (0 => 216782) --- branches/safari-604.1.21-branch/LayoutTests/platform/ios/mediastream/getUserMedia-single-capture.html (rev 0) +++ branches/safari-604.1.21-branch/LayoutTests/platform/ios/mediastream/getUserMedia-single-capture.html 2017-05-12 20:32:08 UTC (rev 216782) @@ -0,0 +1,39 @@ + + + + +i
[webkit-changes] [216787] branches/safari-604.1.21-branch/Source/JavaScriptCore
Title: [216787] branches/safari-604.1.21-branch/Source/_javascript_Core
Revision 216787
Author jmarc...@apple.com
Date 2017-05-12 13:32:23 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216460. rdar://problem/32027549
Modified Paths
branches/safari-604.1.21-branch/Source/_javascript_Core/API/JSObjectRef.cpp
branches/safari-604.1.21-branch/Source/_javascript_Core/API/JSObjectRefPrivate.h
branches/safari-604.1.21-branch/Source/_javascript_Core/API/tests/testapi.c
branches/safari-604.1.21-branch/Source/_javascript_Core/ChangeLog
branches/safari-604.1.21-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
branches/safari-604.1.21-branch/Source/_javascript_Core/runtime/ProxyObject.h
branches/safari-604.1.21-branch/Source/_javascript_Core/shell/PlatformWin.cmake
Added Paths
branches/safari-604.1.21-branch/Source/_javascript_Core/API/tests/JSObjectGetProxyTargetTest.cpp
branches/safari-604.1.21-branch/Source/_javascript_Core/API/tests/JSObjectGetProxyTargetTest.h
Diff
Modified: branches/safari-604.1.21-branch/Source/_javascript_Core/API/JSObjectRef.cpp (216786 => 216787)
--- branches/safari-604.1.21-branch/Source/_javascript_Core/API/JSObjectRef.cpp 2017-05-12 20:32:20 UTC (rev 216786)
+++ branches/safari-604.1.21-branch/Source/_javascript_Core/API/JSObjectRef.cpp 2017-05-12 20:32:23 UTC (rev 216787)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2006, 2007, 2008, 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2006-2017 Apple Inc. All rights reserved.
* Copyright (C) 2008 Kelvin W Sherlock (ksherl...@gmail.com)
*
* Redistribution and use in source and binary forms, with or without
@@ -52,6 +52,7 @@
#include "ObjectConstructor.h"
#include "ObjectPrototype.h"
#include "PropertyNameArray.h"
+#include "ProxyObject.h"
#include "RegExpConstructor.h"
#if ENABLE(REMOTE_INSPECTOR)
@@ -675,3 +676,18 @@
JSLockHolder locker(propertyNames->vm());
propertyNames->add(propertyName->identifier(propertyNames->vm()));
}
+
+JSObjectRef JSObjectGetProxyTarget(JSObjectRef objectRef)
+{
+JSObject* object = toJS(objectRef);
+if (!object)
+return nullptr;
+VM& vm = *object->vm();
+JSLockHolder locker(vm);
+JSObject* result = nullptr;
+if (JSProxy* proxy = jsDynamicCast(vm, object))
+result = proxy->target();
+else if (ProxyObject* proxy = jsDynamicCast(vm, object))
+result = proxy->target();
+return toRef(result);
+}
Modified: branches/safari-604.1.21-branch/Source/_javascript_Core/API/JSObjectRefPrivate.h (216786 => 216787)
--- branches/safari-604.1.21-branch/Source/_javascript_Core/API/JSObjectRefPrivate.h 2017-05-12 20:32:20 UTC (rev 216786)
+++ branches/safari-604.1.21-branch/Source/_javascript_Core/API/JSObjectRefPrivate.h 2017-05-12 20:32:23 UTC (rev 216787)
@@ -67,6 +67,8 @@
*/
JS_EXPORT bool JSObjectDeletePrivateProperty(JSContextRef ctx, JSObjectRef object, JSStringRef propertyName);
+JS_EXPORT JSObjectRef JSObjectGetProxyTarget(JSObjectRef);
+
#ifdef __cplusplus
}
#endif
Added: branches/safari-604.1.21-branch/Source/_javascript_Core/API/tests/JSObjectGetProxyTargetTest.cpp (0 => 216787)
--- branches/safari-604.1.21-branch/Source/_javascript_Core/API/tests/JSObjectGetProxyTargetTest.cpp (rev 0)
+++ branches/safari-604.1.21-branch/Source/_javascript_Core/API/tests/JSObjectGetProxyTargetTest.cpp 2017-05-12 20:32:23 UTC (rev 216787)
@@ -0,0 +1,89 @@
+/*
+ * Copyright (C) 2017 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "JSObjectGetProxyTargetTest.h"
+
+#include "APICast.h"
+#include "InitializeThreading.h"
+#include "JSCInlines.h"
+#include "JSObjectRefPriv
[webkit-changes] [216784] branches/safari-604.1.21-branch/Source/WebCore
Title: [216784] branches/safari-604.1.21-branch/Source/WebCore
Revision 216784
Author jmarc...@apple.com
Date 2017-05-12 13:32:17 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216766. rdar://problem/32151246
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/html/HTMLMediaElement.cpp
branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderVideo.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216783 => 216784)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 20:32:14 UTC (rev 216783)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 20:32:17 UTC (rev 216784)
@@ -1,5 +1,31 @@
2017-05-12 Jason Marcell
+Cherry-pick r216766. rdar://problem/32151246
+
+2017-05-12 Jer Noble
+
+[MediaStream] Streams while play while page is in background can get "stuck" when page is forgrounded.
+https://bugs.webkit.org/show_bug.cgi?id=172022
+
+Reviewed by Youenn Fablet.
+
+When an AVSampleBufferDisplayLayer is disconnected from the CA renderer, none of its samples will be decoded
+and enqueued for rendering. Once the layer is attached to a renderer again, it's stuffed full of samples which
+will never be decoded as their decode time has long passed.
+
+Pass the visibility state of the element through to the MediaPlayer so that MediaPlayerPrivateMediaStreamAVFObjC
+can flush its renderers when going from not visible -> visible.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::visibilityStateChanged):
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisible):
+* rendering/RenderVideo.cpp:
+(WebCore::RenderVideo::updatePlayer):
+
+2017-05-12 Jason Marcell
+
Cherry-pick r216349. rdar://problem/32117885
2017-05-07 Youenn Fablet
Modified: branches/safari-604.1.21-branch/Source/WebCore/html/HTMLMediaElement.cpp (216783 => 216784)
--- branches/safari-604.1.21-branch/Source/WebCore/html/HTMLMediaElement.cpp 2017-05-12 20:32:14 UTC (rev 216783)
+++ branches/safari-604.1.21-branch/Source/WebCore/html/HTMLMediaElement.cpp 2017-05-12 20:32:17 UTC (rev 216784)
@@ -5355,6 +5355,8 @@
LOG(Media, "HTMLMediaElement::visibilityStateChanged(%p) - visible = %s", this, boolString(!m_elementIsHidden));
updateSleepDisabling();
m_mediaSession->visibilityChanged();
+if (m_player)
+m_player->setVisible(!m_elementIsHidden);
bool isPlayingAudio = isPlaying() && hasAudio() && !muted() && volume();
if (!isPlayingAudio) {
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h (216783 => 216784)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h 2017-05-12 20:32:14 UTC (rev 216783)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h 2017-05-12 20:32:17 UTC (rev 216784)
@@ -120,7 +120,7 @@
bool hasVideo() const override;
bool hasAudio() const override;
-void setVisible(bool) override { /* No-op */ }
+void setVisible(bool) final;
MediaTime durationMediaTime() const override;
MediaTime currentMediaTime() const override;
@@ -262,6 +262,7 @@
bool m_pendingSelectedTrackCheck { false };
bool m_shouldDisplayFirstVideoFrame { false };
bool m_transformIsValid { false };
+bool m_visible { false };
#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
std::unique_ptr m_videoFullscreenLayerManager;
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm (216783 => 216784)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2017-05-12 20:32:14 UTC (rev 216783)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2017-05-12 20:32:17 UTC (rev 216784)
@@ -696,6 +696,16 @@
return m_mediaStreamPrivate->hasAudio();
}
+void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool visible)
+{
+if (m_visible == visible)
+return;
+
+m_visible = visible;
+if (m_visible)
+flushRenderers();
+}
[webkit-changes] [216781] branches/safari-604.1.21-branch/Source/WebKit2
Title: [216781] branches/safari-604.1.21-branch/Source/WebKit2 Revision 216781 Author jmarc...@apple.com Date 2017-05-12 13:32:01 -0700 (Fri, 12 May 2017) Log Message Cherry-pick r216710. rdar://problem/32146527 Modified Paths branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog branches/safari-604.1.21-branch/Source/WebKit2/Shared/WebPreferencesDefinitions.h Diff Modified: branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog (216780 => 216781) --- branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-12 20:31:59 UTC (rev 216780) +++ branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-12 20:32:01 UTC (rev 216781) @@ -1,3 +1,21 @@ +2017-05-12 Jason Marcell + +Cherry-pick r216710. rdar://problem/32146527 + +2017-05-11 Dean Jackson + +Modern Media Controls shouldn't be an experimental feature +https://bugs.webkit.org/show_bug.cgi?id=172004 + + +Reviewed by Simon Fraser. + +This is either always on or always off, so shouldn't +show up in an Experimental Features menu. + +* Shared/WebPreferencesDefinitions.h: Move ModernMediaControlsEnabled +to a normal preference. + 2017-05-11 Jason Marcell Cherry-pick r216691. rdar://problem/32136567 Modified: branches/safari-604.1.21-branch/Source/WebKit2/Shared/WebPreferencesDefinitions.h (216780 => 216781) --- branches/safari-604.1.21-branch/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-05-12 20:31:59 UTC (rev 216780) +++ branches/safari-604.1.21-branch/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-05-12 20:32:01 UTC (rev 216781) @@ -113,6 +113,12 @@ #define DEFAULT_SHOULD_CAPTURE_AUDIO_IN_UIPROCESS false #endif +#if PLATFORM(COCOA) +#define DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED true +#else +#define DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED false +#endif + // macro(KeyUpper, KeyLower, TypeNameUpper, TypeName, DefaultValue, HumanReadableName, HumanReadableDescription) #define FOR_EACH_WEBKIT_BOOL_PREFERENCE(macro) \ @@ -265,6 +271,7 @@ macro(GamepadsEnabled, gamepadsEnabled, Bool, bool, true, "Gamepads", "Web Gamepad API support") \ macro(InputEventsEnabled, inputEventsEnabled, Bool, bool, true, "Input Events", "Enable InputEvents support") \ macro(CredentialManagementEnabled, credentialManagementEnabled, Bool, bool, false, "Credential Management", "Enable Credential Management support") \ +macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED, "Modern Media Controls", "Use modern media controls look") \ \ #define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \ @@ -321,12 +328,6 @@ #define DEFAULT_EXPERIMENTAL_FEATURES_ENABLED false #endif -#if PLATFORM(COCOA) -#define DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED true -#else -#define DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED false -#endif - #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101200 // El Capitan NetworkLoadTiming values are sometimes jumbled #define DEFAULT_RESOURCE_TIMING_ENABLED false @@ -346,7 +347,6 @@ #define FOR_EACH_WEBKIT_EXPERIMENTAL_FEATURE_PREFERENCE(macro) \ macro(SpringTimingFunctionEnabled, springTimingFunctionEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "CSS Spring Animations", "CSS Spring Animation prototype") \ macro(LinkPreloadEnabled, linkPreloadEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Link Preload", "Link preload support") \ -macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED, "Modern Media Controls", "Use modern media controls look") \ macro(ResourceTimingEnabled, resourceTimingEnabled, Bool, bool, DEFAULT_RESOURCE_TIMING_ENABLED, "Resource Timing", "Enable ResourceTiming API") \ macro(SubtleCryptoEnabled, subtleCryptoEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "SubtleCrypto", "Enable SubtleCrypto support") \ macro(UserTimingEnabled, userTimingEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "User Timing", "Enable UserTiming API") \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216783] branches/safari-604.1.21-branch
Title: [216783] branches/safari-604.1.21-branch Revision 216783 Author jmarc...@apple.com Date 2017-05-12 13:32:14 -0700 (Fri, 12 May 2017) Log Message Cherry-pick r216349. rdar://problem/32117885 Modified Paths branches/safari-604.1.21-branch/LayoutTests/ChangeLog branches/safari-604.1.21-branch/LayoutTests/platform/ios-wk2/TestExpectations branches/safari-604.1.21-branch/Source/WebCore/ChangeLog branches/safari-604.1.21-branch/Source/WebCore/Modules/mediastream/MediaStream.cpp branches/safari-604.1.21-branch/Source/WebCore/Modules/mediastream/MediaStream.h branches/safari-604.1.21-branch/Source/WebCore/Modules/mediastream/MediaStreamTrack.h branches/safari-604.1.21-branch/Source/WebCore/dom/Document.cpp branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/AVAudioCaptureSource.mm branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaProcessManager.cpp Diff Modified: branches/safari-604.1.21-branch/LayoutTests/ChangeLog (216782 => 216783) --- branches/safari-604.1.21-branch/LayoutTests/ChangeLog 2017-05-12 20:32:08 UTC (rev 216782) +++ branches/safari-604.1.21-branch/LayoutTests/ChangeLog 2017-05-12 20:32:14 UTC (rev 216783) @@ -1,5 +1,18 @@ 2017-05-12 Jason Marcell +Cherry-pick r216349. rdar://problem/32117885 + +2017-05-07 Youenn Fablet + +[MediaStream] r216197 caused some webrtc tests to fail +https://bugs.webkit.org/show_bug.cgi?id=171728 + +Reviewed by Eric Carlson. + +* platform/ios-wk2/TestExpectations: + +2017-05-12 Jason Marcell + Cherry-pick r216712. rdar://problem/32117885 2017-05-11 Youenn Fablet Modified: branches/safari-604.1.21-branch/LayoutTests/platform/ios-wk2/TestExpectations (216782 => 216783) --- branches/safari-604.1.21-branch/LayoutTests/platform/ios-wk2/TestExpectations 2017-05-12 20:32:08 UTC (rev 216782) +++ branches/safari-604.1.21-branch/LayoutTests/platform/ios-wk2/TestExpectations 2017-05-12 20:32:14 UTC (rev 216783) @@ -1970,6 +1970,3 @@ webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ] -webkit.org/b/171728 webrtc/audio-replace-track.html [ Failure ] - -webkit.org/b/171728 webrtc/video-replace-track.html [ Timeout ] Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216782 => 216783) --- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 20:32:08 UTC (rev 216782) +++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 20:32:14 UTC (rev 216783) @@ -1,5 +1,44 @@ 2017-05-12 Jason Marcell +Cherry-pick r216349. rdar://problem/32117885 + +2017-05-07 Youenn Fablet + +[MediaStream] r216197 caused some webrtc tests to fail +https://bugs.webkit.org/show_bug.cgi?id=171728 + +Reviewed by Eric Carlson. + +Covered by existing tests. + +Rename MediaStream::endStream to MediaStream::endCaptureTracks and only stopping capture tracks. +Using it when Document is asked to stop media capture. + +Adding the ability to have only one active capture source at a time in a WebProcess. +This is done by keeping in its related factory the active capture source. +When a new source is created and started, it replaces the active capture source which becomes muted. +Using that mechanism for iOS. + +* Modules/mediastream/MediaStream.cpp: +(WebCore::MediaStream::endCaptureTracks): +(WebCore::MediaStream::endStream): Deleted. +* Modules/mediastream/MediaStream.h: +* Modules/mediastream/MediaStreamTrack.h: +(WebCore::MediaStreamTrack::isCaptureTrack): +* dom/Document.cpp: +(WebCore::Document::stopMediaCapture): +* platform/mediastream/mac/AVAudioCaptureSource.mm: +(WebCore::AVAudioCaptureSourceFactory::setActiveSource): +(WebCore::AVAudioCaptureSource::setupCaptureSession): +* platform/mediastream/mac/AVVideoCaptureSource.mm: +(WebCore::AVVideoCaptureSourceFactory::setActiveSource): +(WebCore::AVVideoCaptureSource::setupCaptureSession): +* platform/mediastream/mac/CoreAudioCaptureSource.cpp: +(WebCore::CoreAudioCaptureSourceFactory::setActiveSource): +(WebCore::CoreAudioSharedUnit::startProducingData): + +2017-05-12 Jason Marcell + Cherry-pick r216712. rdar://problem/32117885 2017-05-11 Youenn Fablet Modified: branches/safari-604.1.21-branch/Source/WebCore/Modules/mediastrea
[webkit-changes] [216779] trunk/Source/WebKit2
Title: [216779] trunk/Source/WebKit2 Revision 216779 Author bfulg...@apple.com Date 2017-05-12 13:27:42 -0700 (Fri, 12 May 2017) Log Message [WK2][macOS] Add a mach-lookup exception for 'com.apple.analyticsd' https://bugs.webkit.org/show_bug.cgi?id=172040 Reviewed by Alexey Proskuryakov. * DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in: * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in: * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit2/ChangeLog (216778 => 216779) --- trunk/Source/WebKit2/ChangeLog 2017-05-12 20:09:25 UTC (rev 216778) +++ trunk/Source/WebKit2/ChangeLog 2017-05-12 20:27:42 UTC (rev 216779) @@ -1,3 +1,16 @@ +2017-05-12 Brent Fulgham + +[WK2][macOS] Add a mach-lookup exception for 'com.apple.analyticsd' +https://bugs.webkit.org/show_bug.cgi?id=172040 + + +Reviewed by Alexey Proskuryakov. + +* DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in: +* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: +* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in: +* WebProcess/com.apple.WebProcess.sb.in: + 2017-05-12 Simon Fraser Add some logging for layer tree commits, and resize and orientation change events Modified: trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in (216778 => 216779) --- trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in 2017-05-12 20:09:25 UTC (rev 216778) +++ trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in 2017-05-12 20:27:42 UTC (rev 216779) @@ -102,6 +102,12 @@ (subpath (param "WEBKIT2_FRAMEWORK_DIR"))) (allow system-fsctl (fsctl-command (_IO "h" 47))) +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 +;; Various services required by CFNetwork and other frameworks +(allow mach-lookup +(global-name "com.apple.analyticsd")) +#endif + ;; Sandbox extensions (define (apply-read-and-issue-extension op path-filter) (op file-read* path-filter) Modified: trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (216778 => 216779) --- trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2017-05-12 20:09:25 UTC (rev 216778) +++ trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2017-05-12 20:27:42 UTC (rev 216779) @@ -138,6 +138,9 @@ (global-name "com.apple.FileCoordination") (global-name "com.apple.PowerManagement.control") (global-name "com.apple.SystemConfiguration.configd") +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 +(global-name "com.apple.analyticsd") +#endif (global-name "com.apple.cookied") (global-name "com.apple.cfnetwork.AuthBrokerAgent") #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 Modified: trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in (216778 => 216779) --- trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in 2017-05-12 20:09:25 UTC (rev 216778) +++ trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in 2017-05-12 20:27:42 UTC (rev 216779) @@ -292,6 +292,9 @@ (global-name "com.apple.SystemConfiguration.PPPController") (global-name "com.apple.SystemConfiguration.configd") (global-name "com.apple.UNCUserNotification") +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 +(global-name "com.apple.analyticsd") +#endif #if __MAC_OS_X_VERSION_MIN_REQUIRED < 101100 (global-name "com.apple.audio.VDCAssistant") #endif Modified: trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in (216778 => 216779) --- trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in 2017-05-12 20:09:25 UTC (rev 216778) +++ trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in 2017-05-12 20:27:42 UTC (rev 216779) @@ -323,6 +323,9 @@ #if __MAC_OS_X_VERSION_MIN_REQUIRED < 101100 (global-name "com.apple.audio.VDCAssistant") #endif +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 + (global-name "com.apple.analyticsd") +#endif (global-name "com.apple.audio.audiohald") (global-name "com.apple.audio.coreaudiod") (global-name "com.apple.awdd") ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216777] trunk/Tools
Title: [216777] trunk/Tools
Revision 216777
Author beid...@apple.com
Date 2017-05-12 13:09:25 -0700 (Fri, 12 May 2017)
Log Message
REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
https://bugs.webkit.org/show_bug.cgi?id=172030
Unreviewed - Test gardening, in effect...
This failure is only being seen by the bots.
I believe this test is utterly broken in the first place; when it checks the .wal file's
size that is not actually an indicator that the records were deleted.
But that isn't what's coming up as failure on the bots.
This patch is an attempt to:
1 - More forcefully clear the Website data directory of leftovers before the test starts.
2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
(defaultWebsiteDataDirectory):
(defaultApplicationCacheDirectory):
(TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm
Diff
Modified: trunk/Tools/ChangeLog (216776 => 216777)
--- trunk/Tools/ChangeLog 2017-05-12 19:52:18 UTC (rev 216776)
+++ trunk/Tools/ChangeLog 2017-05-12 20:09:25 UTC (rev 216777)
@@ -1,3 +1,26 @@
+2017-05-12 Brady Eidson
+
+REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
+https://bugs.webkit.org/show_bug.cgi?id=172030
+
+Unreviewed - Test gardening, in effect...
+
+This failure is only being seen by the bots.
+
+I believe this test is utterly broken in the first place; when it checks the .wal file's
+size that is not actually an indicator that the records were deleted.
+
+But that isn't what's coming up as failure on the bots.
+
+This patch is an attempt to:
+1 - More forcefully clear the Website data directory of leftovers before the test starts.
+2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
+(defaultWebsiteDataDirectory):
+(defaultApplicationCacheDirectory):
+(TEST):
+
2017-05-12 Jonathan Bedard
webkitpy: Pass directory with crash logs into CrashLogs
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm (216776 => 216777)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm 2017-05-12 19:52:18 UTC (rev 216776)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm 2017-05-12 20:09:25 UTC (rev 216777)
@@ -107,6 +107,15 @@
return @"com.apple.webbookmarksd";
}
+NSString *defaultWebsiteDataDirectory()
+{
+#if PLATFORM(IOS)
+return nil;
+#else
+return @"~/Library/Caches/TestWebKitAPI/WebKit";
+#endif
+}
+
NSString *defaultApplicationCacheDirectory()
{
#if PLATFORM(IOS)
@@ -113,7 +122,7 @@
// This is to mirror a quirk in WebsiteDataStore::defaultApplicationCacheDirectory and catch any regressions.
return [NSHomeDirectory() stringByAppendingPathComponent:@"Library/Caches/com.apple.WebAppCache"];
#else
-return @"~/Library/Caches/TestWebKitAPI/WebKit/OfflineWebApplicationCache";
+return [defaultWebsiteDataDirectory() stringByAppendingString:@"/OfflineWebApplicationCache"];
#endif
}
@@ -126,22 +135,24 @@
NSURL *dbResourceURL = [[NSBundle mainBundle] URLForResource:@"ApplicationCache" withExtension:@"db" subdirectory:@"TestWebKitAPI.resources"];
NSURL *shmResourceURL = [[NSBundle mainBundle] URLForResource:@"ApplicationCache" withExtension:@"db-shm" subdirectory:@"TestWebKitAPI.resources"];
NSURL *walResourceURL = [[NSBundle mainBundle] URLForResource:@"ApplicationCache" withExtension:@"db-wal" subdirectory:@"TestWebKitAPI.resources"];
-
+
+// Clean up any website data files left from any previous test run.
+if (auto *websiteDataDirectory = defaultWebsiteDataDirectory()) {
+NSURL *websiteDataURL = [NSURL fileURLWithPath:[websiteDataDirectory stringByExpandingTildeInPath]];
+[[NSFileManager defaultManager] removeItemAtURL:websiteDataURL error:nil];
+}
+
NSURL *targetURL = [NSURL fileURLWithPath:[defaultApplicationCacheDirectory() stringByExpandingTildeInPath]];
[[NSFileManager defaultManager] createDirectoryAtURL:targetURL withIntermediateDirectories:YES attributes:nil error:nil];
-
+
NSURL *dbTargetURL = [targetURL URLByAppendingPathComponent:@"ApplicationCache.db"];
NSURL *walTargetURL = [targetURL URLByAppendingPathComponent:@"ApplicationCache.db-wal"];
NSURL *shmTargetURL = [targetURL URLByAppendingPathComponent:@"ApplicationCache.db-shm"];
-// Clean up any files that may have been left from this test failing before.
-[[NSFileManager defaultManager] removeItemAtURL:dbTargetURL error:nil];
-[[NSFileManager defaultManager] removeItemAtURL:walTargetURL error:nil];
-[[NSFileManager defaultManager] removeItemAtURL:shmTargetURL error:nil];
[webkit-changes] [216778] trunk/Source
Title: [216778] trunk/Source
Revision 216778
Author simon.fra...@apple.com
Date 2017-05-12 13:09:25 -0700 (Fri, 12 May 2017)
Log Message
Add some logging for layer tree commits, and resize and orientation change events
https://bugs.webkit.org/show_bug.cgi?id=172041
Reviewed by Tim Horton.
Add some logging that's useful during rotation investigations.
Source/WebCore:
* dom/Document.cpp:
(WebCore::Document::orientationChanged):
* page/FrameView.cpp:
(WebCore::FrameView::sendResizeEventIfNeeded):
Source/WebKit2:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _didCommitLayerTree:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (216777 => 216778)
--- trunk/Source/WebCore/ChangeLog 2017-05-12 20:09:25 UTC (rev 216777)
+++ trunk/Source/WebCore/ChangeLog 2017-05-12 20:09:25 UTC (rev 216778)
@@ -1,3 +1,17 @@
+2017-05-12 Simon Fraser
+
+Add some logging for layer tree commits, and resize and orientation change events
+https://bugs.webkit.org/show_bug.cgi?id=172041
+
+Reviewed by Tim Horton.
+
+Add some logging that's useful during rotation investigations.
+
+* dom/Document.cpp:
+(WebCore::Document::orientationChanged):
+* page/FrameView.cpp:
+(WebCore::FrameView::sendResizeEventIfNeeded):
+
2017-05-12 Romain Bellessort
[Readable Streams API] Add ReadableStreamBYOBReader closed getter
Modified: trunk/Source/WebCore/dom/Document.cpp (216777 => 216778)
--- trunk/Source/WebCore/dom/Document.cpp 2017-05-12 20:09:25 UTC (rev 216777)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-05-12 20:09:25 UTC (rev 216778)
@@ -6970,6 +6970,7 @@
void Document::orientationChanged(int orientation)
{
+LOG(Events, "Document %p orientationChanged - orientation %d", this, orientation);
dispatchWindowEvent(Event::create(eventNames().orientationchangeEvent, false, false));
m_orientationNotifier.orientationChanged(orientation);
}
Modified: trunk/Source/WebCore/page/FrameView.cpp (216777 => 216778)
--- trunk/Source/WebCore/page/FrameView.cpp 2017-05-12 20:09:25 UTC (rev 216777)
+++ trunk/Source/WebCore/page/FrameView.cpp 2017-05-12 20:09:25 UTC (rev 216778)
@@ -3625,6 +3625,8 @@
bool isMainFrame = frame().isMainFrame();
bool canSendResizeEventSynchronously = isMainFrame && !m_shouldAutoSize;
+LOG(Events, "FrameView %p sendResizeEventIfNeeded sending resize event, size %dx%d (canSendResizeEventSynchronously %d)", this, currentSize.width(), currentSize.height(), canSendResizeEventSynchronously);
+
Ref resizeEvent = Event::create(eventNames().resizeEvent, false, false);
if (canSendResizeEventSynchronously)
frame().document()->dispatchWindowEvent(resizeEvent);
Modified: trunk/Source/WebKit2/ChangeLog (216777 => 216778)
--- trunk/Source/WebKit2/ChangeLog 2017-05-12 20:09:25 UTC (rev 216777)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-12 20:09:25 UTC (rev 216778)
@@ -1,3 +1,17 @@
+2017-05-12 Simon Fraser
+
+Add some logging for layer tree commits, and resize and orientation change events
+https://bugs.webkit.org/show_bug.cgi?id=172041
+
+Reviewed by Tim Horton.
+
+Add some logging that's useful during rotation investigations.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _didCommitLayerTree:]):
+* UIProcess/ios/WKContentView.mm:
+(-[WKContentView _didCommitLayerTree:]):
+
2017-05-12 Andy Estes
[Cocoa] Stop setting a status on PKPaymentRequestShippingContactUpdate when there are errors
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (216777 => 216778)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-05-12 20:09:25 UTC (rev 216777)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-05-12 20:09:25 UTC (rev 216778)
@@ -1468,6 +1468,8 @@
if (![self usesStandardContentView])
return;
+LOG_WITH_STREAM(VisibleRects, stream << "-[WKWebView _didCommitLayerTree:] transactionID " << layerTreeTransaction.transactionID() << " _dynamicViewportUpdateMode " << (int)_dynamicViewportUpdateMode);
+
if (_dynamicViewportUpdateMode != DynamicViewportUpdateMode::NotResizing) {
if (_resizeAnimationTransformTransactionID && layerTreeTransaction.transactionID() >= _resizeAnimationTransformTransactionID.value()) {
_resizeAnimationTransformTransactionID = std::nullopt;
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm (216777 => 216778)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm 2017-05-12 20:09:25 UTC (rev 216777)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm 2017-05
[webkit-changes] [216776] trunk/Tools
Title: [216776] trunk/Tools Revision 216776 Author jbed...@apple.com Date 2017-05-12 12:52:18 -0700 (Fri, 12 May 2017) Log Message webkitpy: Pass directory with crash logs into CrashLogs https://bugs.webkit.org/show_bug.cgi?id=172033 Reviewed by Daniel Bates. Refactor CrashLogs and the callers of CrashLogs so that the port object owns the location of crash logs. * Scripts/webkitpy/common/system/crashlogs.py: (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing. (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of generating one. (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of self._results_directory. (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of generating one. (CrashLogs._log_directory_darwin): Moved to port. * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path to the crash log is no longer owned by CrashLogs. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general directory for uploading crash logs. Note that crash logs are only supported on Mac and Windows. * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import. * Scripts/webkitpy/port/base.py: (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed to be in the results directory. * Scripts/webkitpy/port/darwin.py: (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin. (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path. (DarwinPort._get_crash_log): Ditto. * Scripts/webkitpy/port/darwin_testcase.py: (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating the path to crash logs. * Scripts/webkitpy/port/ios_device.py: (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS. * Scripts/webkitpy/port/ios_device_unittest.py: (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS. * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import. * Scripts/webkitpy/port/mac.py: Ditto. * Scripts/webkitpy/port/test.py: (TestDriver.run_test): Use port specific crash log path when retrieving crash logs. * Scripts/webkitpy/port/win.py: (WinPort._get_crash_log): Ditto. * Scripts/webkitpy/tool/commands/queries.py: (execute): Construct a port object since this is the object which owns the path to crash logs. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py trunk/Tools/Scripts/webkitpy/port/apple.py trunk/Tools/Scripts/webkitpy/port/base.py trunk/Tools/Scripts/webkitpy/port/darwin.py trunk/Tools/Scripts/webkitpy/port/darwin_testcase.py trunk/Tools/Scripts/webkitpy/port/ios_device.py trunk/Tools/Scripts/webkitpy/port/ios_device_unittest.py trunk/Tools/Scripts/webkitpy/port/ios_simulator.py trunk/Tools/Scripts/webkitpy/port/mac.py trunk/Tools/Scripts/webkitpy/port/test.py trunk/Tools/Scripts/webkitpy/port/win.py trunk/Tools/Scripts/webkitpy/tool/commands/queries.py Diff Modified: trunk/Tools/ChangeLog (216775 => 216776) --- trunk/Tools/ChangeLog 2017-05-12 19:18:00 UTC (rev 216775) +++ trunk/Tools/ChangeLog 2017-05-12 19:52:18 UTC (rev 216776) @@ -1,3 +1,52 @@ +2017-05-12 Jonathan Bedard + +webkitpy: Pass directory with crash logs into CrashLogs +https://bugs.webkit.org/show_bug.cgi?id=172033 + + +Reviewed by Daniel Bates. + +Refactor CrashLogs and the callers of CrashLogs so that the port object owns +the location of crash logs. + +* Scripts/webkitpy/common/system/crashlogs.py: +(CrashLogs.__init__): Pass mandatory crash_log_directory when constructing. +(CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of +generating one. +(CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of +self._results_directory. +(CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of +generating one. +(CrashLogs._log_directory_darwin): Moved to port. +* Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path +to the crash log is no longer owned by CrashLogs. +* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general +directory for uploading crash logs. Note that crash logs are only supported on Mac +and Windows. +* Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import. +* Scripts/webkitpy/port/base.py: +(Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed +to be in the results directory. +* Scripts/webkitpy/port/darwin.py: +(DarwinPort.path_to_crash_logs): Moved from CrashLog
[webkit-changes] [216775] trunk
Title: [216775] trunk Revision 216775 Author commit-qu...@webkit.org Date 2017-05-12 12:18:00 -0700 (Fri, 12 May 2017) Log Message [Readable Streams API] Add ReadableStreamBYOBReader closed getter https://bugs.webkit.org/show_bug.cgi?id=172024 Patch by Romain Bellessort on 2017-05-12 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: Updated expectations. * web-platform-tests/streams/readable-byte-streams/general-expected.txt: Updated. * web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt: Updated. Source/WebCore: Added tests to check closed getter behaviour. * Modules/streams/ReadableStreamBYOBReader.js: (closed): Implemented. LayoutTests: Added tests to check closed getter behaviour. * streams/readable-stream-byob-reader-expected.txt: Updated. * streams/readable-stream-byob-reader.js: Updated. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt trunk/LayoutTests/streams/readable-stream-byob-reader-expected.txt trunk/LayoutTests/streams/readable-stream-byob-reader.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBReader.js Diff Modified: trunk/LayoutTests/ChangeLog (216774 => 216775) --- trunk/LayoutTests/ChangeLog 2017-05-12 19:14:06 UTC (rev 216774) +++ trunk/LayoutTests/ChangeLog 2017-05-12 19:18:00 UTC (rev 216775) @@ -1,3 +1,15 @@ +2017-05-12 Romain Bellessort + +[Readable Streams API] Add ReadableStreamBYOBReader closed getter +https://bugs.webkit.org/show_bug.cgi?id=172024 + +Reviewed by Youenn Fablet. + +Added tests to check closed getter behaviour. + +* streams/readable-stream-byob-reader-expected.txt: Updated. +* streams/readable-stream-byob-reader.js: Updated. + 2017-05-12 Matt Lewis Marked webrtc/closing-peerconnection.html as flaky. Modified: trunk/LayoutTests/imported/w3c/ChangeLog (216774 => 216775) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-05-12 19:14:06 UTC (rev 216774) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-05-12 19:18:00 UTC (rev 216775) @@ -1,3 +1,15 @@ +2017-05-12 Romain Bellessort + +[Readable Streams API] Add ReadableStreamBYOBReader closed getter +https://bugs.webkit.org/show_bug.cgi?id=172024 + +Reviewed by Youenn Fablet. + +Updated expectations. + +* web-platform-tests/streams/readable-byte-streams/general-expected.txt: Updated. +* web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt: Updated. + 2017-05-12 Manuel Rego Casasnovas [selectors4] css/selectors4/focus-within-006.html test from WPT is failing Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt (216774 => 216775) --- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt 2017-05-12 19:14:06 UTC (rev 216774) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt 2017-05-12 19:18:00 UTC (rev 216775) @@ -10,9 +10,9 @@ PASS ReadableStream with byte source: getReader(), then releaseLock() FAIL ReadableStream with byte source: getReader() with mode set to byob, then releaseLock() ReadableStreamBYOBReader releaseLock() is not implemented PASS ReadableStream with byte source: Test that closing a stream does not release a reader automatically -FAIL ReadableStream with byte source: Test that closing a stream does not release a BYOB reader automatically ReadableStreamBYOBReader closed is not implemented +PASS ReadableStream with byte source: Test that closing a stream does not release a BYOB reader automatically PASS ReadableStream with byte source: Test that erroring a stream does not release a reader automatically -FAIL ReadableStream with byte source: Test that erroring a stream does not release a BYOB reader automatically ReadableStreamBYOBReader closed is not implemented +PASS ReadableStream with byte source: Test that erroring a stream does not release a BYOB reader automatically PASS ReadableStream with byte source: releaseLock() on ReadableStreamReader with pending read() must throw PASS ReadableStream with byte source: Automatic pull() after start() PASS ReadableStream with byte source: Automatic pull() after start() and read() Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt (216774 => 216775) --- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt 2017-05-12 19:14:06 UTC (rev 216774) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.ded
[webkit-changes] [216774] trunk/Source/WebKit2
Title: [216774] trunk/Source/WebKit2 Revision 216774 Author aes...@apple.com Date 2017-05-12 12:14:06 -0700 (Fri, 12 May 2017) Log Message [Cocoa] Stop setting a status on PKPaymentRequestShippingContactUpdate when there are errors https://bugs.webkit.org/show_bug.cgi?id=172036 Reviewed by Anders Carlsson. * UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingContactSelection): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (216773 => 216774) --- trunk/Source/WebKit2/ChangeLog 2017-05-12 19:10:18 UTC (rev 216773) +++ trunk/Source/WebKit2/ChangeLog 2017-05-12 19:14:06 UTC (rev 216774) @@ -1,3 +1,14 @@ +2017-05-12 Andy Estes + +[Cocoa] Stop setting a status on PKPaymentRequestShippingContactUpdate when there are errors +https://bugs.webkit.org/show_bug.cgi?id=172036 + + +Reviewed by Anders Carlsson. + +* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: +(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingContactSelection): + 2017-05-12 Chris Dumez Stop using PassRefPtr under WebKit2/Shared Modified: trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm (216773 => 216774) --- trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2017-05-12 19:10:18 UTC (rev 216773) +++ trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2017-05-12 19:14:06 UTC (rev 216774) @@ -785,8 +785,6 @@ #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 11) auto pkShippingContactUpdate = adoptNS([allocPKPaymentRequestShippingContactUpdateInstance() initWithErrors:update ? toNSErrors(update->errors).get() : @[ ] paymentSummaryItems:m_paymentAuthorizationViewControllerDelegate->_paymentSummaryItems.get() shippingMethods:m_paymentAuthorizationViewControllerDelegate->_shippingMethods.get()]); -if ([pkShippingContactUpdate errors].count) -[pkShippingContactUpdate setStatus:PKPaymentAuthorizationStatusFailure]; m_paymentAuthorizationViewControllerDelegate->_didSelectShippingContactCompletion(pkShippingContactUpdate.get()); #else m_paymentAuthorizationViewControllerDelegate->_didSelectShippingContactCompletion(toPKPaymentAuthorizationStatus(update), m_paymentAuthorizationViewControllerDelegate->_shippingMethods.get(), m_paymentAuthorizationViewControllerDelegate->_paymentSummaryItems.get()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216773] branches/safari-604.1.21-branch/Source/WebCore
Title: [216773] branches/safari-604.1.21-branch/Source/WebCore
Revision 216773
Author matthew_han...@apple.com
Date 2017-05-12 12:10:18 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216432. rdar://problem/32051782
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216772 => 216773)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 18:48:07 UTC (rev 216772)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 19:10:18 UTC (rev 216773)
@@ -1,3 +1,20 @@
+2017-05-12 Matthew Hanson
+
+Cherry-pick r216432. rdar://problem/32051782
+
+2017-05-08 Youenn Fablet
+
+CoreAudioCaptureSource should not modify its shared unit if already started/stopped
+https://bugs.webkit.org/show_bug.cgi?id=171804
+
+Reviewed by Jer Noble.
+
+Manual testing only since CoreAudioSharedUnit is not mocked.
+
+* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+(WebCore::CoreAudioCaptureSource::startProducingData): Exit early if source is already started.
+(WebCore::CoreAudioCaptureSource::stopProducingData): Exit early if source is already stopped.
+
2017-05-11 Jason Marcell
Cherry-pick r216691. rdar://problem/32136567
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (216772 => 216773)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2017-05-12 18:48:07 UTC (rev 216772)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2017-05-12 19:10:18 UTC (rev 216773)
@@ -667,6 +667,9 @@
void CoreAudioCaptureSource::startProducingData()
{
+if (m_isProducingData)
+return;
+
CoreAudioSharedUnit::singleton().startProducingData();
m_isProducingData = CoreAudioSharedUnit::singleton().isProducingData();
@@ -681,6 +684,9 @@
void CoreAudioCaptureSource::stopProducingData()
{
+if (!m_isProducingData)
+return;
+
CoreAudioSharedUnit::singleton().stopProducingData();
m_isProducingData = false;
m_muted = true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216772] trunk/Source/WTF
Title: [216772] trunk/Source/WTF
Revision 216772
Author akl...@apple.com
Date 2017-05-12 11:48:07 -0700 (Fri, 12 May 2017)
Log Message
More aggressive memory kill limits.
https://bugs.webkit.org/show_bug.cgi?id=172037
Reviewed by Michael Saboff.
Bring down the memory kill limits to 4GB for active processes, and 2GB for inactive.
Also make MemoryUsagePolicy::Strict kick in above 1.5GB.
* wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::thresholdForMemoryKill):
(WTF::thresholdForPolicy):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MemoryPressureHandler.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (216771 => 216772)
--- trunk/Source/WTF/ChangeLog 2017-05-12 18:34:12 UTC (rev 216771)
+++ trunk/Source/WTF/ChangeLog 2017-05-12 18:48:07 UTC (rev 216772)
@@ -1,3 +1,18 @@
+2017-05-12 Andreas Kling
+
+More aggressive memory kill limits.
+https://bugs.webkit.org/show_bug.cgi?id=172037
+
+
+Reviewed by Michael Saboff.
+
+Bring down the memory kill limits to 4GB for active processes, and 2GB for inactive.
+Also make MemoryUsagePolicy::Strict kick in above 1.5GB.
+
+* wtf/MemoryPressureHandler.cpp:
+(WTF::MemoryPressureHandler::thresholdForMemoryKill):
+(WTF::thresholdForPolicy):
+
2017-05-12 Michael Saboff
[iOS] Use memory footprint to dynamically adjust behavior of allocators
Modified: trunk/Source/WTF/wtf/MemoryPressureHandler.cpp (216771 => 216772)
--- trunk/Source/WTF/wtf/MemoryPressureHandler.cpp 2017-05-12 18:34:12 UTC (rev 216771)
+++ trunk/Source/WTF/wtf/MemoryPressureHandler.cpp 2017-05-12 18:48:07 UTC (rev 216772)
@@ -79,8 +79,8 @@
{
#if CPU(X86_64) || CPU(ARM64)
if (m_processState == WebsamProcessState::Active)
-return 16 * GB;
-return 4 * GB;
+return 4 * GB;
+return 2 * GB;
#else
return 3 * GB;
#endif
@@ -92,7 +92,7 @@
case MemoryUsagePolicy::Conservative:
return 1 * GB;
case MemoryUsagePolicy::Strict:
-return 2 * GB;
+return 1.5 * GB;
case MemoryUsagePolicy::Unrestricted:
default:
ASSERT_NOT_REACHED();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216771] trunk/Source/WebCore
Title: [216771] trunk/Source/WebCore
Revision 216771
Author akl...@apple.com
Date 2017-05-12 11:34:12 -0700 (Fri, 12 May 2017)
Log Message
MediaResourceLoader shouldn't keep its HTMLMediaElement alive.
https://bugs.webkit.org/show_bug.cgi?id=172032
Reviewed by Joseph Pecoraro.
Use a WeakPtr in MediaResourceLoader instead, since the loader
is retained by a NSURLSession object we hand over to AVFoundation.
This prevents AVFoundation from keeping entire documents alive outside our control.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::createWeakPtr):
* loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::MediaResourceLoader):
(WebCore::MediaResourceLoader::requestResource):
* loader/MediaResourceLoader.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/loader/MediaResourceLoader.cpp
trunk/Source/WebCore/loader/MediaResourceLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (216770 => 216771)
--- trunk/Source/WebCore/ChangeLog 2017-05-12 18:21:45 UTC (rev 216770)
+++ trunk/Source/WebCore/ChangeLog 2017-05-12 18:34:12 UTC (rev 216771)
@@ -1,5 +1,27 @@
2017-05-12 Andreas Kling
+MediaResourceLoader shouldn't keep its HTMLMediaElement alive.
+https://bugs.webkit.org/show_bug.cgi?id=172032
+
+
+Reviewed by Joseph Pecoraro.
+
+Use a WeakPtr in MediaResourceLoader instead, since the loader
+is retained by a NSURLSession object we hand over to AVFoundation.
+
+This prevents AVFoundation from keeping entire documents alive outside our control.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::HTMLMediaElement):
+* html/HTMLMediaElement.h:
+(WebCore::HTMLMediaElement::createWeakPtr):
+* loader/MediaResourceLoader.cpp:
+(WebCore::MediaResourceLoader::MediaResourceLoader):
+(WebCore::MediaResourceLoader::requestResource):
+* loader/MediaResourceLoader.h:
+
+2017-05-12 Andreas Kling
+
Memory pressure response should only do sync bmalloc scavenge in sync mode.
https://bugs.webkit.org/show_bug.cgi?id=172035
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (216770 => 216771)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-05-12 18:21:45 UTC (rev 216770)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-05-12 18:34:12 UTC (rev 216771)
@@ -392,6 +392,7 @@
HTMLMediaElement::HTMLMediaElement(const QualifiedName& tagName, Document& document, bool createdByParser)
: HTMLElement(tagName, document)
, ActiveDOMObject(&document)
+, m_weakFactory(this)
, m_pendingActionTimer(*this, &HTMLMediaElement::pendingActionTimerFired)
, m_progressEventTimer(*this, &HTMLMediaElement::progressEventTimerFired)
, m_playbackProgressTimer(*this, &HTMLMediaElement::playbackProgressTimerFired)
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (216770 => 216771)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2017-05-12 18:21:45 UTC (rev 216770)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2017-05-12 18:34:12 UTC (rev 216771)
@@ -130,6 +130,7 @@
#endif
{
public:
+WeakPtr createWeakPtr() { return m_weakFactory.createWeakPtr(); }
MediaPlayer* player() const { return m_player.get(); }
virtual bool isVideo() const { return false; }
@@ -855,6 +856,7 @@
void handleSeekToPlaybackPosition(double);
void seekToPlaybackPositionEndedTimerFired();
+WeakPtrFactory m_weakFactory;
Timer m_pendingActionTimer;
Timer m_progressEventTimer;
Timer m_playbackProgressTimer;
Modified: trunk/Source/WebCore/loader/MediaResourceLoader.cpp (216770 => 216771)
--- trunk/Source/WebCore/loader/MediaResourceLoader.cpp 2017-05-12 18:21:45 UTC (rev 216770)
+++ trunk/Source/WebCore/loader/MediaResourceLoader.cpp 2017-05-12 18:34:12 UTC (rev 216771)
@@ -43,7 +43,7 @@
MediaResourceLoader::MediaResourceLoader(Document& document, HTMLMediaElement& mediaElement, const String& crossOriginMode)
: ContextDestructionObserver(&document)
, m_document(&document)
-, m_mediaElement(&mediaElement)
+, m_mediaElement(mediaElement.createWeakPtr())
, m_crossOriginMode(crossOriginMode)
, m_weakFactory(this)
{
@@ -79,7 +79,8 @@
// FIXME: Skip Content Security Policy check if the element that initiated this request is in a user-agent shadow tree. See .
CachedResourceRequest cacheRequest(WTFMove(request), ResourceLoaderOptions(SendCallbacks, DoNotSniffContent, bufferingPolicy, AllowStoredCredentials, ClientCredentialPolicy::MayAskClientForCredentials, FetchOptions::Credentials::Include, DoSecurityCheck, FetchOptions::Mode::NoCors, DoNotIncludeCertificateInfo, ContentSecurityPolicyImposition::DoPolicyCheck, DefersLoadingPolicy::AllowDefersLoading, cachingPolicy));
ca
[webkit-changes] [216770] trunk/Source/WebCore
Title: [216770] trunk/Source/WebCore
Revision 216770
Author akl...@apple.com
Date 2017-05-12 11:21:45 -0700 (Fri, 12 May 2017)
Log Message
Memory pressure response should only do sync bmalloc scavenge in sync mode.
https://bugs.webkit.org/show_bug.cgi?id=172035
Reviewed by Michael Saboff.
Only call WTF::releaseFastMallocFreeMemory() and his threading-related friends
when releaseMemory() is invoked with Synchronous::Yes, or if it's a critical
pressure response (maintaining the behavior added in r215775.)
* page/MemoryRelease.cpp:
(WebCore::releaseMemory):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/MemoryRelease.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (216769 => 216770)
--- trunk/Source/WebCore/ChangeLog 2017-05-12 17:54:11 UTC (rev 216769)
+++ trunk/Source/WebCore/ChangeLog 2017-05-12 18:21:45 UTC (rev 216770)
@@ -1,3 +1,17 @@
+2017-05-12 Andreas Kling
+
+Memory pressure response should only do sync bmalloc scavenge in sync mode.
+https://bugs.webkit.org/show_bug.cgi?id=172035
+
+Reviewed by Michael Saboff.
+
+Only call WTF::releaseFastMallocFreeMemory() and his threading-related friends
+when releaseMemory() is invoked with Synchronous::Yes, or if it's a critical
+pressure response (maintaining the behavior added in r215775.)
+
+* page/MemoryRelease.cpp:
+(WebCore::releaseMemory):
+
2017-05-12 Daniel Bates
Cleanup: Use Ref instead of RefPtr to hold DOMWrapperWorld
Modified: trunk/Source/WebCore/page/MemoryRelease.cpp (216769 => 216770)
--- trunk/Source/WebCore/page/MemoryRelease.cpp 2017-05-12 17:54:11 UTC (rev 216769)
+++ trunk/Source/WebCore/page/MemoryRelease.cpp 2017-05-12 18:21:45 UTC (rev 216770)
@@ -110,24 +110,26 @@
{
TraceScope scope(MemoryPressureHandlerStart, MemoryPressureHandlerEnd, static_cast(critical), static_cast(synchronous));
-// Return unused pages back to the OS now as this will likely give us a little memory to work with.
-WTF::releaseFastMallocFreeMemory();
-
-if (critical == Critical::Yes)
+if (critical == Critical::Yes) {
+// Return unused pages back to the OS now as this will likely give us a little memory to work with.
+WTF::releaseFastMallocFreeMemory();
releaseCriticalMemory(synchronous);
+}
releaseNoncriticalMemory();
platformReleaseMemory(critical);
-// FastMalloc has lock-free thread specific caches that can only be cleared from the thread itself.
-WorkerThread::releaseFastMallocFreeMemoryInAllThreads();
+if (synchronous == Synchronous::Yes) {
+// FastMalloc has lock-free thread specific caches that can only be cleared from the thread itself.
+WorkerThread::releaseFastMallocFreeMemoryInAllThreads();
#if ENABLE(ASYNC_SCROLLING) && !PLATFORM(IOS)
-ScrollingThread::dispatch([]() {
+ScrollingThread::dispatch([]() {
+WTF::releaseFastMallocFreeMemory();
+});
+#endif
WTF::releaseFastMallocFreeMemory();
-});
-#endif
-WTF::releaseFastMallocFreeMemory();
+}
#if ENABLE(RESOURCE_USAGE)
Page::forEachPage([&](Page& page) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216769] trunk/Source/WebCore
Title: [216769] trunk/Source/WebCore
Revision 216769
Author dba...@webkit.org
Date 2017-05-12 10:54:11 -0700 (Fri, 12 May 2017)
Log Message
Cleanup: Use Ref instead of RefPtr to hold DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=171988
Reviewed by Chris Dumez.
* bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::JSCustomElementInterface):
(WebCore::JSCustomElementInterface::upgradeElement):
(WebCore::JSCustomElementInterface::invokeCallback):
* bindings/js/JSCustomElementInterface.h:
* bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::JSMutationCallback):
(WebCore::JSMutationCallback::call):
* bindings/js/JSMutationCallback.h:
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::execute):
* bindings/js/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction):
* page/DOMWindowExtension.cpp:
(WebCore::DOMWindowExtension::DOMWindowExtension):
* page/DOMWindowExtension.h:
(WebCore::DOMWindowExtension::world):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSCustomElementInterface.cpp
trunk/Source/WebCore/bindings/js/JSCustomElementInterface.h
trunk/Source/WebCore/bindings/js/JSMutationCallback.cpp
trunk/Source/WebCore/bindings/js/JSMutationCallback.h
trunk/Source/WebCore/bindings/js/ScheduledAction.cpp
trunk/Source/WebCore/bindings/js/ScheduledAction.h
trunk/Source/WebCore/page/DOMWindowExtension.cpp
trunk/Source/WebCore/page/DOMWindowExtension.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (216768 => 216769)
--- trunk/Source/WebCore/ChangeLog 2017-05-12 17:53:18 UTC (rev 216768)
+++ trunk/Source/WebCore/ChangeLog 2017-05-12 17:54:11 UTC (rev 216769)
@@ -1,5 +1,31 @@
2017-05-12 Daniel Bates
+Cleanup: Use Ref instead of RefPtr to hold DOMWrapperWorld
+https://bugs.webkit.org/show_bug.cgi?id=171988
+
+Reviewed by Chris Dumez.
+
+* bindings/js/JSCustomElementInterface.cpp:
+(WebCore::JSCustomElementInterface::JSCustomElementInterface):
+(WebCore::JSCustomElementInterface::upgradeElement):
+(WebCore::JSCustomElementInterface::invokeCallback):
+* bindings/js/JSCustomElementInterface.h:
+* bindings/js/JSMutationCallback.cpp:
+(WebCore::JSMutationCallback::JSMutationCallback):
+(WebCore::JSMutationCallback::call):
+* bindings/js/JSMutationCallback.h:
+* bindings/js/ScheduledAction.cpp:
+(WebCore::ScheduledAction::ScheduledAction):
+(WebCore::ScheduledAction::execute):
+* bindings/js/ScheduledAction.h:
+(WebCore::ScheduledAction::ScheduledAction):
+* page/DOMWindowExtension.cpp:
+(WebCore::DOMWindowExtension::DOMWindowExtension):
+* page/DOMWindowExtension.h:
+(WebCore::DOMWindowExtension::world):
+
+2017-05-12 Daniel Bates
+
Cleanup: Make QueueTaskToEventLoopFunctionPtr take JSGlobalObject&
https://bugs.webkit.org/show_bug.cgi?id=172021
Modified: trunk/Source/WebCore/bindings/js/JSCustomElementInterface.cpp (216768 => 216769)
--- trunk/Source/WebCore/bindings/js/JSCustomElementInterface.cpp 2017-05-12 17:53:18 UTC (rev 216768)
+++ trunk/Source/WebCore/bindings/js/JSCustomElementInterface.cpp 2017-05-12 17:54:11 UTC (rev 216769)
@@ -48,7 +48,7 @@
: ActiveDOMCallback(globalObject->scriptExecutionContext())
, m_name(name)
, m_constructor(constructor)
-, m_isolatedWorld(&globalObject->world())
+, m_isolatedWorld(globalObject->world())
{
}
@@ -182,7 +182,7 @@
if (!context)
return;
ASSERT(context->isDocument());
-JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(context, *m_isolatedWorld);
+JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(context, m_isolatedWorld);
ExecState* state = globalObject->globalExec();
RETURN_IF_EXCEPTION(scope, void());
@@ -233,7 +233,7 @@
ASSERT(context);
ASSERT(context->isDocument());
-JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(context, *m_isolatedWorld);
+JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(context, m_isolatedWorld);
ExecState* state = globalObject->globalExec();
JSObject* jsElement = asObject(toJS(state, globalObject, element));
Modified: trunk/Source/WebCore/bindings/js/JSCustomElementInterface.h (216768 => 216769)
--- trunk/Source/WebCore/bindings/js/JSCustomElementInterface.h 2017-05-12 17:53:18 UTC (rev 216768)
+++ trunk/Source/WebCore/bindings/js/JSCustomElementInterface.h 2017-05-12 17:54:11 UTC (rev 216769)
@@ -34,7 +34,6 @@
#include
#include
#include
-#include
#include
namespace JSC {
@@ -103,7 +102,7 @@
JSC::Weak m_disconnectedCallback;
JSC::Weak m_adoptedCallback;
JSC::Weak m_attributeChangedCallback;
-RefPtr m_isolatedWorld;
+Ref m_isolatedWorld;
Vector, 1> m_constructionStack;
HashSet m_observedAttributes;
};
Modified: trunk/Source/WebCor
[webkit-changes] [216768] trunk/Source
Title: [216768] trunk/Source
Revision 216768
Author dba...@webkit.org
Date 2017-05-12 10:53:18 -0700 (Fri, 12 May 2017)
Log Message
Cleanup: Make QueueTaskToEventLoopFunctionPtr take JSGlobalObject&
https://bugs.webkit.org/show_bug.cgi?id=172021
Reviewed by Mark Lam.
Source/_javascript_Core:
Change the function alias for QueueTaskToEventLoopFunctionPtr to take JSGlobalObject&
instead of a const JSGlobalObject* as all implementations expect to be passed a non-
const, non-null JSGlobalObject object.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::queueMicrotask):
* runtime/JSGlobalObject.h:
* runtime/VM.cpp:
(JSC::VM::queueMicrotask):
* runtime/VM.h: Remove JS_EXPORT_PRIVATE annotation from queueMicrotask() as
it is only called from _javascript_Core code.
Source/WebCore:
* bindings/js/JSDOMGlobalObjectTask.cpp: Include header JSDOMGlobalObject.h.
(WebCore::JSGlobalObjectTask::JSGlobalObjectTask): Change type of first argument from JSDOMGlobalObject*
to JSDOMGlobalObject& and update code as necessary. Also, use C++11 brace initialization syntax
for member initializer list.
* bindings/js/JSDOMGlobalObjectTask.h: Remove header JSDOMGlobalObject.h and forward declare
JSDOMGlobalObject and JSC::Microtask.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowMicrotaskCallback::create):
(WebCore::JSDOMWindowMicrotaskCallback::JSDOMWindowMicrotaskCallback): Change type of first argument
from JSDOMWindowBase* to JSDOMWindowBase& and update code as necessary. Also, use C++11 brace
initialization syntax for member initializer list.
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
* bindings/js/JSWorkerGlobalScopeBase.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp
trunk/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.h
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.h
trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp
trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (216767 => 216768)
--- trunk/Source/_javascript_Core/ChangeLog 2017-05-12 17:14:58 UTC (rev 216767)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-05-12 17:53:18 UTC (rev 216768)
@@ -1,3 +1,22 @@
+2017-05-12 Daniel Bates
+
+Cleanup: Make QueueTaskToEventLoopFunctionPtr take JSGlobalObject&
+https://bugs.webkit.org/show_bug.cgi?id=172021
+
+Reviewed by Mark Lam.
+
+Change the function alias for QueueTaskToEventLoopFunctionPtr to take JSGlobalObject&
+instead of a const JSGlobalObject* as all implementations expect to be passed a non-
+const, non-null JSGlobalObject object.
+
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::queueMicrotask):
+* runtime/JSGlobalObject.h:
+* runtime/VM.cpp:
+(JSC::VM::queueMicrotask):
+* runtime/VM.h: Remove JS_EXPORT_PRIVATE annotation from queueMicrotask() as
+it is only called from _javascript_Core code.
+
2017-05-12 Michael Saboff
[iOS] Use memory footprint to dynamically adjust behavior of allocators
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp (216767 => 216768)
--- trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp 2017-05-12 17:14:58 UTC (rev 216767)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp 2017-05-12 17:53:18 UTC (rev 216768)
@@ -1431,11 +1431,11 @@
void JSGlobalObject::queueMicrotask(Ref&& task)
{
if (globalObjectMethodTable()->queueTaskToEventLoop) {
-globalObjectMethodTable()->queueTaskToEventLoop(this, WTFMove(task));
+globalObjectMethodTable()->queueTaskToEventLoop(*this, WTFMove(task));
return;
}
-vm().queueMicrotask(this, WTFMove(task));
+vm().queueMicrotask(*this, WTFMove(task));
}
bool JSGlobalObject::hasDebugger() const
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.h (216767 => 216768)
--- trunk/Source/_javascript_Core/runtime/JSGlobalObject.h 2017-05-12 17:14:58 UTC (rev 216767)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.h 2017-05-12 17:53:18 UTC (rev 216768)
@@ -177,7 +177,7 @@
typedef RuntimeFlags (*_javascript_RuntimeFlagsFunctionPtr)(const JSGlobalObject*);
_javascript_RuntimeFlagsFunctionPtr _javascript_RuntimeFlags;
-typedef void (*QueueTaskToEventLoopFunctionPtr)(const JSGlobalObject*, Ref&&);
+typedef void (*QueueTaskToEventLoopFunctionPtr)(JSGlobalObject&, Ref&&);
QueueTaskToEventLoopFunctionPtr queueTaskToEventLoop;
typedef
[webkit-changes] [216767] trunk/LayoutTests
Title: [216767] trunk/LayoutTests Revision 216767 Author jlew...@apple.com Date 2017-05-12 10:14:58 -0700 (Fri, 12 May 2017) Log Message Marked webrtc/closing-peerconnection.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=172034 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (216766 => 216767) --- trunk/LayoutTests/ChangeLog 2017-05-12 16:05:38 UTC (rev 216766) +++ trunk/LayoutTests/ChangeLog 2017-05-12 17:14:58 UTC (rev 216767) @@ -1,3 +1,12 @@ +2017-05-12 Matt Lewis + +Marked webrtc/closing-peerconnection.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=172034 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2017-05-12 Claudio Saavedra [GTK] After upgrading glib and glib-networking, resources with zero bytes are always identified as text/plain Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (216766 => 216767) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-05-12 16:05:38 UTC (rev 216766) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-05-12 17:14:58 UTC (rev 216767) @@ -688,3 +688,5 @@ webkit.org/b/170699 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html [ Pass Failure ] webkit.org/b/168937 [ Debug ] tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html [ Pass Failure ] + +webkit.org/b/172034 [ Sierra Release ] webrtc/closing-peerconnection.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216766] trunk/Source/WebCore
Title: [216766] trunk/Source/WebCore
Revision 216766
Author jer.no...@apple.com
Date 2017-05-12 09:05:38 -0700 (Fri, 12 May 2017)
Log Message
[MediaStream] Streams while play while page is in background can get "stuck" when page is forgrounded.
https://bugs.webkit.org/show_bug.cgi?id=172022
Reviewed by Youenn Fablet.
When an AVSampleBufferDisplayLayer is disconnected from the CA renderer, none of its samples will be decoded
and enqueued for rendering. Once the layer is attached to a renderer again, it's stuffed full of samples which
will never be decoded as their decode time has long passed.
Pass the visibility state of the element through to the MediaPlayer so that MediaPlayerPrivateMediaStreamAVFObjC
can flush its renderers when going from not visible -> visible.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::visibilityStateChanged):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisible):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updatePlayer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
trunk/Source/WebCore/rendering/RenderVideo.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (216765 => 216766)
--- trunk/Source/WebCore/ChangeLog 2017-05-12 15:37:17 UTC (rev 216765)
+++ trunk/Source/WebCore/ChangeLog 2017-05-12 16:05:38 UTC (rev 216766)
@@ -1,3 +1,25 @@
+2017-05-12 Jer Noble
+
+[MediaStream] Streams while play while page is in background can get "stuck" when page is forgrounded.
+https://bugs.webkit.org/show_bug.cgi?id=172022
+
+Reviewed by Youenn Fablet.
+
+When an AVSampleBufferDisplayLayer is disconnected from the CA renderer, none of its samples will be decoded
+and enqueued for rendering. Once the layer is attached to a renderer again, it's stuffed full of samples which
+will never be decoded as their decode time has long passed.
+
+Pass the visibility state of the element through to the MediaPlayer so that MediaPlayerPrivateMediaStreamAVFObjC
+can flush its renderers when going from not visible -> visible.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::visibilityStateChanged):
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisible):
+* rendering/RenderVideo.cpp:
+(WebCore::RenderVideo::updatePlayer):
+
2017-05-12 Per Arne Vollan
Unreviewed Windows build fix.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (216765 => 216766)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-05-12 15:37:17 UTC (rev 216765)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-05-12 16:05:38 UTC (rev 216766)
@@ -5355,6 +5355,8 @@
LOG(Media, "HTMLMediaElement::visibilityStateChanged(%p) - visible = %s", this, boolString(!m_elementIsHidden));
updateSleepDisabling();
m_mediaSession->visibilityChanged();
+if (m_player)
+m_player->setVisible(!m_elementIsHidden);
bool isPlayingAudio = isPlaying() && hasAudio() && !muted() && volume();
if (!isPlayingAudio) {
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h (216765 => 216766)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h 2017-05-12 15:37:17 UTC (rev 216765)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h 2017-05-12 16:05:38 UTC (rev 216766)
@@ -120,7 +120,7 @@
bool hasVideo() const override;
bool hasAudio() const override;
-void setVisible(bool) override { /* No-op */ }
+void setVisible(bool) final;
MediaTime durationMediaTime() const override;
MediaTime currentMediaTime() const override;
@@ -262,6 +262,7 @@
bool m_pendingSelectedTrackCheck { false };
bool m_shouldDisplayFirstVideoFrame { false };
bool m_transformIsValid { false };
+bool m_visible { false };
#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
std::unique_ptr m_videoFullscreenLayerManager;
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm (216765 => 216766)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2017-05-12 15:37:17 UTC (rev 216765)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2017-05-12 1
[webkit-changes] [216765] trunk/Source/WebCore
Title: [216765] trunk/Source/WebCore Revision 216765 Author pvol...@apple.com Date 2017-05-12 08:37:17 -0700 (Fri, 12 May 2017) Log Message Unreviewed Windows build fix. * bindings/js/JSWebGLRenderingContextCustom.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (216764 => 216765) --- trunk/Source/WebCore/ChangeLog 2017-05-12 14:33:15 UTC (rev 216764) +++ trunk/Source/WebCore/ChangeLog 2017-05-12 15:37:17 UTC (rev 216765) @@ -1,3 +1,9 @@ +2017-05-12 Per Arne Vollan + +Unreviewed Windows build fix. + +* bindings/js/JSWebGLRenderingContextCustom.cpp: + 2017-05-12 Antti Koivisto Updating class name of a shadow host does not update the style applied by descendants of :host() Modified: trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp (216764 => 216765) --- trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp 2017-05-12 14:33:15 UTC (rev 216764) +++ trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp 2017-05-12 15:37:17 UTC (rev 216765) @@ -24,9 +24,9 @@ */ #include "config.h" -#include "JSWebGLRenderingContext.h" #if ENABLE(WEBGL) +#include "JSWebGLRenderingContext.h" #include "DOMWrapperWorld.h" #include "EXTBlendMinMax.h" #include "EXTFragDepth.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216764] trunk/Source/WebKit2
Title: [216764] trunk/Source/WebKit2 Revision 216764 Author cdu...@apple.com Date 2017-05-12 07:33:15 -0700 (Fri, 12 May 2017) Log Message Stop using PassRefPtr under WebKit2/Shared https://bugs.webkit.org/show_bug.cgi?id=172017 Reviewed by Antti Koivisto. * Shared/API/APIDictionary.cpp: (API::Dictionary::add): (API::Dictionary::set): * Shared/API/APIDictionary.h: * Shared/API/APISecurityOrigin.h: (API::SecurityOrigin::createFromString): (API::SecurityOrigin::create): (API::SecurityOrigin::securityOrigin): (API::SecurityOrigin::SecurityOrigin): * Shared/API/APISerializedScriptValue.h: (API::SerializedScriptValue::create): (API::SerializedScriptValue::SerializedScriptValue): * Shared/API/c/WKSharedAPICast.h: (WebKit::ProxyingRefPtr::ProxyingRefPtr): * Shared/APIWebArchiveResource.h: * Shared/APIWebArchiveResource.mm: (API::WebArchiveResource::create): (API::WebArchiveResource::WebArchiveResource): * Shared/AsyncRequest.h: (WebKit::AsyncRequestMap::add): * Shared/BlobDataFileReferenceWithSandboxExtension.cpp: (WebKit::BlobDataFileReferenceWithSandboxExtension::BlobDataFileReferenceWithSandboxExtension): * Shared/BlobDataFileReferenceWithSandboxExtension.h: * Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp: (WebKit::CoordinatedBackingStoreTile::setBackBuffer): (WebKit::CoordinatedBackingStore::updateTile): * Shared/CoordinatedGraphics/CoordinatedBackingStore.h: * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: (WebKit::CoordinatedGraphicsScene::createUpdateAtlas): (WebKit::CoordinatedGraphicsScene::updateImageBacking): * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h: * Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::getOrCreate): * Shared/Plugins/Netscape/NetscapePluginModule.h: * Shared/VisitedLinkTable.cpp: (WebKit::VisitedLinkTable::setSharedMemory): * Shared/VisitedLinkTable.h: * Shared/WebBackForwardListItem.h: (WebKit::WebBackForwardListItem::setSnapshot): * Shared/WebContextMenuItem.cpp: (WebKit::WebContextMenuItem::create): * Shared/WebContextMenuItem.h: * Shared/WebGeolocationPosition.h: * Shared/WebRenderLayer.cpp: (WebKit::WebRenderLayer::create): (WebKit::WebRenderLayer::createArrayFromLayerList): (WebKit::WebRenderLayer::WebRenderLayer): * Shared/WebRenderLayer.h: * Shared/WebRenderObject.cpp: (WebKit::WebRenderObject::create): (WebKit::WebRenderObject::WebRenderObject): * Shared/WebRenderObject.h: * UIProcess/VisitedLinkStore.cpp: (WebKit::VisitedLinkStore::resizeTable): * WebProcess/WebPage/VisitedLinkTableController.cpp: (WebKit::VisitedLinkTableController::setVisitedLinkTable): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp trunk/Source/WebKit2/Shared/API/APIDictionary.cpp trunk/Source/WebKit2/Shared/API/APIDictionary.h trunk/Source/WebKit2/Shared/API/APISecurityOrigin.h trunk/Source/WebKit2/Shared/API/APISerializedScriptValue.h trunk/Source/WebKit2/Shared/API/c/WKContextMenuItem.cpp trunk/Source/WebKit2/Shared/API/c/WKSecurityOriginRef.cpp trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h trunk/Source/WebKit2/Shared/APIWebArchiveResource.h trunk/Source/WebKit2/Shared/APIWebArchiveResource.mm trunk/Source/WebKit2/Shared/AsyncRequest.h trunk/Source/WebKit2/Shared/BlobDataFileReferenceWithSandboxExtension.cpp trunk/Source/WebKit2/Shared/BlobDataFileReferenceWithSandboxExtension.h trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedBackingStore.h trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h trunk/Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp trunk/Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.h trunk/Source/WebKit2/Shared/VisitedLinkTable.cpp trunk/Source/WebKit2/Shared/VisitedLinkTable.h trunk/Source/WebKit2/Shared/WebBackForwardListItem.h trunk/Source/WebKit2/Shared/WebContextMenuItem.cpp trunk/Source/WebKit2/Shared/WebContextMenuItem.h trunk/Source/WebKit2/Shared/WebGeolocationPosition.h trunk/Source/WebKit2/Shared/WebRenderLayer.cpp trunk/Source/WebKit2/Shared/WebRenderLayer.h trunk/Source/WebKit2/Shared/WebRenderObject.cpp trunk/Source/WebKit2/Shared/WebRenderObject.h trunk/Source/WebKit2/UIProcess/API/APIFrameInfo.cpp trunk/Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp trunk/Source/WebKit2/UIProcess/VisitedLinkStore.cpp trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (216763 => 216764) --- trunk/Source/WebKit2/ChangeLog 2017-05-12 14:15:08 UTC (rev 216763) +++ trunk/Source/WebKit2/ChangeLog 2017-05-12 14:33:15 UTC (rev 216764) @@ -1,3 +1,67 @@ +2017-05-12 Chris Dumez + +Stop using PassRefPtr under WebKit2/Shared +https://bugs.webkit.org/show_bug.cgi?id=172017 + +Reviewed by Antti Koivisto. + +* Shared/API
[webkit-changes] [216763] trunk/Source
Title: [216763] trunk/Source
Revision 216763
Author msab...@apple.com
Date 2017-05-12 07:15:08 -0700 (Fri, 12 May 2017)
Log Message
[iOS] Use memory footprint to dynamically adjust behavior of allocators
https://bugs.webkit.org/show_bug.cgi?id=171944
Reviewed by Filip Pizlo.
Source/bmalloc:
This change is iOS only.
After the scavenger thread completes scavenging, it asks the OS for how much total memory the
process is using. This information is used to update the sleep delay for the scanvenger thread,
as well as to provide memory in use data for other parts of the system.
The scavenger sleep time is calculated using the following quadradic equation.
scavengerSleep = 1.2*percentFreeMemory^2 - percentFreeMemory + 2
Where percentFreeMemory is between 0 and 100. The result is constrained to the values 2 and 250.
This equation empirically works out to providing a 2ms sleep time when we have less than 10%
memory available, 30ms when 20% is available and 250ms when 50% or more is available. In testing,
this exponentially agressive scavenging delay by itself reduced memory usage and made it much
more deterministic when used without the corresponding change in the JSC Heap.
Changed the scavenger thread to use the User Initiated QOS priority to ensure it doesn't
get starved.
Moved the non-Windows functionality of WTF::RAMSize() to new files AvailableMemory.{cpp,h}
and implemented in the function availableMemory(). That functions limits the value returned
on iOS to a maximum of 840MB as that is the jetsam soft memory limit.
Added a new API availableMemory() so that WTF::RAMSize() will use this value.
* CMakeLists.txt:
* bmalloc.xcodeproj/project.pbxproj:
* bmalloc/BPlatform.h:
* bmalloc/Heap.cpp:
(bmalloc::Heap::Heap):
(bmalloc::Heap::updateMemoryInUseParameters):
(bmalloc::Heap::concurrentScavenge):
(bmalloc::Heap::scavenge):
* bmalloc/Heap.h:
(bmalloc::Heap::memoryFootprint):
(bmalloc::Heap::percentAvailableMemoryInUse):
* bmalloc/Sizes.h:
* bmalloc/bmalloc.h:
(bmalloc::api::availableMemory):
(bmalloc::api::memoryFootprint):
(bmalloc::api::percentAvailableMemoryInUse):
* bmalloc/AvailableMemory.cpp: Added.
(bmalloc::computeAvailableMemory):
(bmalloc::availableMemory):
* bmalloc/AvailableMemory.h: Added.
Source/_javascript_Core:
This change is iOS only.
Added the ability to react to when memory usage is critical. This is defined as memory
usage being above the newly added option criticalGCMemoryThreshold. When we are in this
critical state, all collections are Full and we limit the amount of memory we allocate
between collections to 1/4th the memory above the critical threshold.
Changed the calculation of proportionalHeapSize to be based on process memory footprint
and not how big the heap is. Also, the values of Options::smallHeapRAMFraction and
Options::mediumHeapRAMFraction are overriden so that most of the heap growth is happens
using the more agressive Options::smallHeapGrowthFactor.
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::overCriticalMemoryThreshold):
(JSC::Heap::shouldDoFullCollection):
(JSC::Heap::collectIfNecessaryOrDefer):
* heap/Heap.h:
* runtime/Options.cpp:
(JSC::overrideDefaults):
(JSC::Options::initialize):
* runtime/Options.h:
Source/WTF:
Moved the non-Windows implementation of RAMSize() to bmalloc/AvailableMemory.cpp and
called the function availableMemory().
* wtf/RAMSize.cpp:
(WTF::computeRAMSize):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/runtime/Options.cpp
trunk/Source/_javascript_Core/runtime/Options.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/RAMSize.cpp
trunk/Source/bmalloc/CMakeLists.txt
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/BPlatform.h
trunk/Source/bmalloc/bmalloc/Heap.cpp
trunk/Source/bmalloc/bmalloc/Heap.h
trunk/Source/bmalloc/bmalloc/Sizes.h
trunk/Source/bmalloc/bmalloc/bmalloc.h
trunk/Source/bmalloc/bmalloc.xcodeproj/project.pbxproj
Added Paths
trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp
trunk/Source/bmalloc/bmalloc/AvailableMemory.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (216762 => 216763)
--- trunk/Source/_javascript_Core/ChangeLog 2017-05-12 12:58:44 UTC (rev 216762)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-05-12 14:15:08 UTC (rev 216763)
@@ -1,3 +1,33 @@
+2017-05-12 Michael Saboff
+
+[iOS] Use memory footprint to dynamically adjust behavior of allocators
+https://bugs.webkit.org/show_bug.cgi?id=171944
+
+Reviewed by Filip Pizlo.
+
+This change is iOS only.
+
+Added the ability to react to when memory usage is critical. This is defined as memory
+usage being above the newly added option criticalGCMemoryThreshold. When we are in this
+critical state, all collections are Full and we limit the amount of memory we allocate
+between collections to 1/4th the memory above the criti
[webkit-changes] [216761] trunk
Title: [216761] trunk
Revision 216761
Author an...@apple.com
Date 2017-05-12 05:31:49 -0700 (Fri, 12 May 2017)
Log Message
Updating class name of a shadow host does not update the style applied by descendants of :host()
https://bugs.webkit.org/show_bug.cgi?id=170762
Reviewed by Ryosuke Niwa.
Source/WebCore:
We need to invalidate shadow tree style when host classes or attributes change if it may be
affected by host rules.
Test: fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html
* css/RuleSet.cpp:
(WebCore::isHostSelectorMatchingInShadowTree):
(WebCore::RuleSet::addRule):
Check if we have :host selectors that affect shadow tree.
* css/RuleSet.h:
(WebCore::RuleSet::hasHostPseudoClassRulesMatchingInShadowTree):
* style/AttributeChangeInvalidation.cpp:
(WebCore::Style::mayBeAffectedByHostRules):
(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):
Invalidate the whole subtree if there is a class change that may affect shadow tree style.
* style/ClassChangeInvalidation.cpp:
(WebCore::Style::mayBeAffectedByHostRules):
(WebCore::Style::ClassChangeInvalidation::invalidateStyle):
* style/IdChangeInvalidation.cpp:
(WebCore::Style::mayBeAffectedByHostRules):
(WebCore::Style::IdChangeInvalidation::invalidateStyle):
Same for classes and ids.
This should be refactored at some point to reduce copy-code.
LayoutTests:
* fast/shadow-dom/css-scoping-host-class-and-attribute-mutation-expected.html: Added.
* fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/RuleSet.cpp
trunk/Source/WebCore/css/RuleSet.h
trunk/Source/WebCore/style/AttributeChangeInvalidation.cpp
trunk/Source/WebCore/style/ClassChangeInvalidation.cpp
trunk/Source/WebCore/style/IdChangeInvalidation.cpp
Added Paths
trunk/LayoutTests/fast/shadow-dom/css-scoping-host-class-and-attribute-mutation-expected.html
trunk/LayoutTests/fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html
Diff
Modified: trunk/LayoutTests/ChangeLog (216760 => 216761)
--- trunk/LayoutTests/ChangeLog 2017-05-12 11:53:58 UTC (rev 216760)
+++ trunk/LayoutTests/ChangeLog 2017-05-12 12:31:49 UTC (rev 216761)
@@ -1,3 +1,14 @@
+2017-05-12 Antti Koivisto
+
+Updating class name of a shadow host does not update the style applied by descendants of :host()
+https://bugs.webkit.org/show_bug.cgi?id=170762
+
+
+Reviewed by Ryosuke Niwa.
+
+* fast/shadow-dom/css-scoping-host-class-and-attribute-mutation-expected.html: Added.
+* fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html: Added.
+
2017-05-12 Claudio Saavedra
[WPE] Unreviewed gardening.
Added: trunk/LayoutTests/fast/shadow-dom/css-scoping-host-class-and-attribute-mutation-expected.html (0 => 216761)
--- trunk/LayoutTests/fast/shadow-dom/css-scoping-host-class-and-attribute-mutation-expected.html (rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/css-scoping-host-class-and-attribute-mutation-expected.html 2017-05-12 12:31:49 UTC (rev 216761)
@@ -0,0 +1,7 @@
+
+
+
+Test passes if you see a single 100px by 100px green box below.
+
+
+
Added: trunk/LayoutTests/fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html (0 => 216761)
--- trunk/LayoutTests/fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html (rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html 2017-05-12 12:31:49 UTC (rev 216761)
@@ -0,0 +1,130 @@
+
+
+
+
+
+Test passes if you see a single 100px by 100px green box below.
+
+
+
+
+
+
+
+
+
+:host(.green) div {
+background-color: green;
+}
+div {
+width: 100px;
+height: 20px;
+background-color: red;
+}
+
+
+
+
+
+
+:host(.red) > div {
+background-color: red;
+}
+div {
+width: 100px;
+height: 20px;
+background-color: green;
+}
+
+
+
+
+
+
+:host([color=green]) div {
+background-color: green;
+}
+div {
+width: 100px;
+height: 20px;
+background-color: red;
+}
+
+
+
+
+
+
+:host(#green) div {
+background-color: green;
+}
+div {
+width: 100px;
+height: 20px;
+background-color: red;
+}
+
+
+
+
+
+
+:host div.green {
+background-color: green;
+}
+div {
+width: 100px;
+height: 20px;
+background-color: red;
+}
+
+
+
+
+
+
+
+function checkColor(host, expected)
+{
+const div = host.shadowRoot.querySelector("div");
+const color = getComputedStyle(div).backgroundColor;
+const width = getComputedStyle(div).width;
+if (color != expected)
+log.innerHTML += `FAIL: unexpected background color ${color}
`;
+if (width != "100px")
+log.innerHTML += `FAIL: unexpected width ${width}
`;
+}
+
+function test(hostselector, shadowselector, mutation) {
+const host = document.querySelector(hostselector);
+const shadowTemp
[webkit-changes] [216759] trunk
Title: [216759] trunk Revision 216759 Author carlo...@webkit.org Date 2017-05-12 04:42:48 -0700 (Fri, 12 May 2017) Log Message [GTK] ASSERTION FAILED: !m_flushingLayers https://bugs.webkit.org/show_bug.cgi?id=172025 Reviewed by Žan Doberšek. Source/WebCore: The problem is that syncImageBacking() is calling didChangeLayerState(). All sync methods are called by flushCompositingStateForThisLayerOnly() while flushing layers, so none of them should call didChange method that will schedule a new flush while flushing. * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::syncImageBacking): LayoutTests: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp Diff Modified: trunk/LayoutTests/ChangeLog (216758 => 216759) --- trunk/LayoutTests/ChangeLog 2017-05-12 10:29:49 UTC (rev 216758) +++ trunk/LayoutTests/ChangeLog 2017-05-12 11:42:48 UTC (rev 216759) @@ -1,5 +1,14 @@ 2017-05-12 Carlos Garcia Campos +[GTK] ASSERTION FAILED: !m_flushingLayers +https://bugs.webkit.org/show_bug.cgi?id=172025 + +Reviewed by Žan Doberšek. + +* platform/gtk/TestExpectations: + +2017-05-12 Carlos Garcia Campos + [GTK] GIF images are not properly loaded the first time https://bugs.webkit.org/show_bug.cgi?id=170432 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (216758 => 216759) --- trunk/LayoutTests/platform/gtk/TestExpectations 2017-05-12 10:29:49 UTC (rev 216758) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-05-12 11:42:48 UTC (rev 216759) @@ -274,20 +274,20 @@ webkit.org/b/99028 fast/autoresize [ Failure ] # We need to set ENABLE_CSS_COMPOSITING=ON -webkit.org/b/169916 [ Release ] css3/blending/blend-mode-accelerated-with-multiple-stacking-contexts.html [ Failure ] -webkit.org/b/169916 [ Release ] css3/blending/blend-mode-ancestor-clipping-layer.html [ Failure ] -webkit.org/b/169916 [ Release ] css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer.html [ Failure ] +webkit.org/b/169916 css3/blending/blend-mode-accelerated-with-multiple-stacking-contexts.html [ Failure ] +webkit.org/b/169916 css3/blending/blend-mode-ancestor-clipping-layer.html [ Failure ] +webkit.org/b/169916 css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer.html [ Failure ] webkit.org/b/169916 css3/blending/blend-mode-clip-accelerated-blending-canvas.html [ Failure ] -webkit.org/b/169916 [ Release ] css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html [ Failure ] +webkit.org/b/169916 css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html [ Failure ] webkit.org/b/169916 css3/blending/blend-mode-isolation-turn-off-self-painting-layer.html [ Failure ] webkit.org/b/169916 css3/blending/blend-mode-isolation-turn-off-self-painting-layer1.html [ Failure ] webkit.org/b/169916 css3/blending/blend-mode-isolation-turn-off-self-painting-layer2.html [ Failure ] webkit.org/b/169916 css3/blending/blend-mode-isolation-turn-on-self-painting-layer.html [ Failure ] -webkit.org/b/169916 [ Release ] css3/blending/blend-mode-parent-of-composited-blended-has-layer.html [ Failure ] +webkit.org/b/169916 css3/blending/blend-mode-parent-of-composited-blended-has-layer.html [ Failure ] webkit.org/b/169916 css3/blending/blend-mode-property-parsing.html [ Failure ] webkit.org/b/169916 css3/blending/blend-mode-property.html [ Failure ] webkit.org/b/169916 css3/blending/blend-mode-transform-style.html [ Failure ] -webkit.org/b/169916 [ Release ] css3/blending/blend-mode-with-composited-descendant-should-have-layer.html [ Failure ] +webkit.org/b/169916 css3/blending/blend-mode-with-composited-descendant-should-have-layer.html [ Failure ] webkit.org/b/169916 css3/blending/isolation-parsing.html [ Failure ] webkit.org/b/169916 css3/blending/repaint/blend-mode-isolate-stacking-context.html [ Failure ] webkit.org/b/169916 css3/blending/repaint/blend-mode-turn-off-isolation.html [ Failure ] @@ -339,38 +339,37 @@ # Failures related with compositing tests. webkit.org/b/169918 compositing/animation/animation-backing.html [ Failure Pass ] -webkit.org/b/169918 [ Release ] compositing/backing/no-backing-for-perspective.html [ Failure ] -webkit.org/b/169918 [ Release ] compositing/backing/whitespace-nodes-no-backing.html [ Failure ] -webkit.org/b/169918 [ Release ] compositing/canvas/accelerated-canvas-compositing-size-limit.html [ Failure ] -webkit.org/b/169918 [ Release ] compositing/clipping/border-radius-overflow-hidden-stacking-context.html [ Failure ] +webkit.org/b/169918 compositing/backing/no-backing-for-perspective.html [ Failure ] +webkit.org/b/169918 compositing/backing/whitespace-nodes-no-backing.html [ Failure ]
[webkit-changes] [216758] trunk
Title: [216758] trunk
Revision 216758
Author carlo...@webkit.org
Date 2017-05-12 03:29:49 -0700 (Fri, 12 May 2017)
Log Message
[GTK] GIF images are not properly loaded the first time
https://bugs.webkit.org/show_bug.cgi?id=170432
Reviewed by Carlos Alberto Lopez Perez.
Source/WebCore:
When the GIF image is loaded for the first time, it's always read from the network, and the decoder is usually
fetched with chunks of data. Then the data is cached in disk by the network process, so that when loaded from
the cache, the whole encoded data is available to fetch the encoder. The problem is that we are failing to
decode the image when giving chunks of data, that's why it only happens the first time loaded. If the first
chunk of data provided is enough to get some metadata, including the size, but not frame contents, the load fails
in CachedImage::addIncrementalDataBuffer() because the EncodedDataStatus reported is SizeAvailable but
Image::isNull() returns true. An Image is considered to be Null when its size is empty, and the size is
calculated always using the first frame in ImageFrameCache. Since we still don't have frames, the image is
always Null in this case. It is not expected that EncodedDataStatus returns SizeAvailable and the image is Null,
that's why it's considered an error and the load finishes with a decode error. However, the non CG ImageDecoder
has a m_size member to handle this particular case, and it's when m_size is set when EncodedDataStatus changes
to SizeAvailable. We should return the ImageEncoder size as the ImageSize when we have a decoder but
not frames yet.
Test: http/tests/images/gif-progressive-load.html
* platform/graphics/ImageFrameCache.cpp:
(WebCore::ImageFrameCache::size): Return ImageDecoder::size() without caching it, if frame list is empty.
LayoutTests:
* http/tests/images/gif-progressive-load-expected.html: Added.
* http/tests/images/gif-progressive-load.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ImageFrameCache.cpp
Added Paths
trunk/LayoutTests/http/tests/images/gif-progressive-load-expected.html
trunk/LayoutTests/http/tests/images/gif-progressive-load.html
Diff
Modified: trunk/LayoutTests/ChangeLog (216757 => 216758)
--- trunk/LayoutTests/ChangeLog 2017-05-12 10:08:38 UTC (rev 216757)
+++ trunk/LayoutTests/ChangeLog 2017-05-12 10:29:49 UTC (rev 216758)
@@ -1,3 +1,13 @@
+2017-05-12 Carlos Garcia Campos
+
+[GTK] GIF images are not properly loaded the first time
+https://bugs.webkit.org/show_bug.cgi?id=170432
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* http/tests/images/gif-progressive-load-expected.html: Added.
+* http/tests/images/gif-progressive-load.html: Added.
+
2017-05-12 Manuel Rego Casasnovas
[selectors4] css/selectors4/focus-within-006.html test from WPT is failing
Added: trunk/LayoutTests/http/tests/images/gif-progressive-load-expected.html (0 => 216758)
--- trunk/LayoutTests/http/tests/images/gif-progressive-load-expected.html (rev 0)
+++ trunk/LayoutTests/http/tests/images/gif-progressive-load-expected.html 2017-05-12 10:29:49 UTC (rev 216758)
@@ -0,0 +1,22 @@
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+}
+
+function testDone()
+{
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+function runTest()
+{
+// This test checks that GIF loading doesn't fail when the first chunk of data decoded
+// contains the metadata, but not a complete frame. See webkit.org/b/170432.
+document.querySelector("img").src = ""
+setTimeout(testDone, 1000);
+}
+
+setTimeout(runTest, 0);
+
Added: trunk/LayoutTests/http/tests/images/gif-progressive-load.html (0 => 216758)
--- trunk/LayoutTests/http/tests/images/gif-progressive-load.html (rev 0)
+++ trunk/LayoutTests/http/tests/images/gif-progressive-load.html 2017-05-12 10:29:49 UTC (rev 216758)
@@ -0,0 +1,32 @@
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+}
+
+function loadAndStall()
+{
+return "http://127.0.0.1:8000/resources/load-and-stall.php";
+}
+
+function gifImage()
+{
+return "?name=../permissionclient/resources/boston.gif&mimeType=image%2Fgif";
+}
+
+function testDone()
+{
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+function runTest()
+{
+// This test checks that GIF loading doesn't fail when the first chunk of data decoded
+// contains the metadata, but not a complete frame. See webkit.org/b/170432.
+document.querySelector("img").src = "" + gifImage() + "&stallAt=512&stallFor=1";
+setTimeout(testDone, 1500);
+}
+
+setTimeout(runTest, 0);
+
Modified: trunk/Source/WebCore/ChangeLog (216757 => 216758)
--- trunk/Source/WebCore/ChangeLog 2017-05-12 10:08:38 UTC (rev 216757)
+++ trunk/Source/WebCore/ChangeLog 2017-05-12 10:29:49 UTC (rev 216758)
@@ -1,3 +1,29 @@
+2017-05-12 Carlos Garcia Camp
[webkit-changes] [216757] trunk/Source/WebCore
Title: [216757] trunk/Source/WebCore
Revision 216757
Author pvol...@apple.com
Date 2017-05-12 03:08:38 -0700 (Fri, 12 May 2017)
Log Message
The iBooks application is not able to get current position.
https://bugs.webkit.org/show_bug.cgi?id=171982
rdar://problem/29318409
Reviewed by Brent Fulgham.
Geolocation requests from iBooks are currently blocked. Make an exemption from the policy for iBooks.
No new tests since we currently can't mock the iBooks application bundle ID.
* Modules/geolocation/Geolocation.cpp:
(WebCore::isRequestFromIBooks):
(WebCore::Geolocation::shouldBlockGeolocationRequests):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (216756 => 216757)
--- trunk/Source/WebCore/ChangeLog 2017-05-12 09:43:44 UTC (rev 216756)
+++ trunk/Source/WebCore/ChangeLog 2017-05-12 10:08:38 UTC (rev 216757)
@@ -1,3 +1,19 @@
+2017-05-12 Per Arne Vollan
+
+The iBooks application is not able to get current position.
+https://bugs.webkit.org/show_bug.cgi?id=171982
+rdar://problem/29318409
+
+Reviewed by Brent Fulgham.
+
+Geolocation requests from iBooks are currently blocked. Make an exemption from the policy for iBooks.
+
+No new tests since we currently can't mock the iBooks application bundle ID.
+
+* Modules/geolocation/Geolocation.cpp:
+(WebCore::isRequestFromIBooks):
+(WebCore::Geolocation::shouldBlockGeolocationRequests):
+
2017-05-11 Per Arne Vollan
Geolocation requests should not be blocked when the security origin is local.
Modified: trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp (216756 => 216757)
--- trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp 2017-05-12 09:43:44 UTC (rev 216756)
+++ trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp 2017-05-12 10:08:38 UTC (rev 216757)
@@ -40,6 +40,7 @@
#include "Geoposition.h"
#include "Page.h"
#include "PositionError.h"
+#include "RuntimeApplicationChecks.h"
#include "SecurityOrigin.h"
#include
#include
@@ -346,6 +347,17 @@
document->addConsoleMessage(MessageSource::Security, MessageLevel::Error, message.toString());
}
+// FIXME: remove this function when rdar://problem/32137821 is fixed.
+static bool isRequestFromIBooks()
+{
+#if PLATFORM(MAC)
+return MacApplication::isIBooks();
+#elif PLATFORM(IOS)
+return IOSApplication::isIBooks();
+#endif
+return false;
+}
+
bool Geolocation::shouldBlockGeolocationRequests()
{
bool isSecure = SecurityOrigin::isSecure(document()->url());
@@ -352,7 +364,7 @@
bool hasMixedContent = document()->foundMixedContent();
bool isLocalOrigin = securityOrigin()->isLocal();
if (securityOrigin()->canRequestGeolocation()) {
-if (isLocalOrigin || (isSecure && !hasMixedContent))
+if (isLocalOrigin || (isSecure && !hasMixedContent) || isRequestFromIBooks())
return false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216753] trunk
Title: [216753] trunk
Revision 216753
Author pvol...@apple.com
Date 2017-05-12 01:08:45 -0700 (Fri, 12 May 2017)
Log Message
Geolocation requests should not be blocked when the security origin is local.
https://bugs.webkit.org/show_bug.cgi?id=171857
Source/WebCore:
rdar://problem/29318409
Reviewed by Brent Fulgham.
Geolocation requests from security origins where the url scheme is registered as local,
should not be blocked. This applies to the file url scheme, but also to other local url
schemes.
Test: fast/misc/geolocation-local-security-origin.html
* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::shouldBlockGeolocationRequests):
LayoutTests:
Reviewed by Brent Fulgham.
* fast/misc/geolocation-local-security-origin-expected.txt: Added.
* fast/misc/geolocation-local-security-origin.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp
Added Paths
trunk/LayoutTests/fast/misc/geolocation-local-security-origin-expected.txt
trunk/LayoutTests/fast/misc/geolocation-local-security-origin.html
Diff
Modified: trunk/LayoutTests/ChangeLog (216752 => 216753)
--- trunk/LayoutTests/ChangeLog 2017-05-12 07:52:50 UTC (rev 216752)
+++ trunk/LayoutTests/ChangeLog 2017-05-12 08:08:45 UTC (rev 216753)
@@ -1,3 +1,13 @@
+2017-05-11 Per Arne Vollan
+
+Geolocation requests should not be blocked when the security origin is local.
+https://bugs.webkit.org/show_bug.cgi?id=171857
+
+Reviewed by Brent Fulgham.
+
+* fast/misc/geolocation-local-security-origin-expected.txt: Added.
+* fast/misc/geolocation-local-security-origin.html: Added.
+
2017-05-11 Manuel Rego Casasnovas
[selectors4] :focus-within tests using shadow DOM don't pass on WK1
Added: trunk/LayoutTests/fast/misc/geolocation-local-security-origin-expected.txt (0 => 216753)
--- trunk/LayoutTests/fast/misc/geolocation-local-security-origin-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/misc/geolocation-local-security-origin-expected.txt 2017-05-12 08:08:45 UTC (rev 216753)
@@ -0,0 +1 @@
+This test makes sure we are not getting a console message stating that geolocation is blocked when the url scheme is local (e.g. file://).
Added: trunk/LayoutTests/fast/misc/geolocation-local-security-origin.html (0 => 216753)
--- trunk/LayoutTests/fast/misc/geolocation-local-security-origin.html (rev 0)
+++ trunk/LayoutTests/fast/misc/geolocation-local-security-origin.html 2017-05-12 08:08:45 UTC (rev 216753)
@@ -0,0 +1,14 @@
+
+
+This test makes sure we are not getting a console message stating that geolocation is blocked when the url scheme is local (e.g. file://).
+
+if (window.testRunner)
+testRunner.dumpAsText();
+if (navigator.geolocation)
+navigator.geolocation.getCurrentPosition(showPosition);
+function showPosition(position) {
+console.log("Latitude: " + position.coords.latitude + "Longitude: " + position.coords.longitude);
+}
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (216752 => 216753)
--- trunk/Source/WebCore/ChangeLog 2017-05-12 07:52:50 UTC (rev 216752)
+++ trunk/Source/WebCore/ChangeLog 2017-05-12 08:08:45 UTC (rev 216753)
@@ -1,3 +1,20 @@
+2017-05-11 Per Arne Vollan
+
+Geolocation requests should not be blocked when the security origin is local.
+https://bugs.webkit.org/show_bug.cgi?id=171857
+rdar://problem/29318409
+
+Reviewed by Brent Fulgham.
+
+Geolocation requests from security origins where the url scheme is registered as local,
+should not be blocked. This applies to the file url scheme, but also to other local url
+schemes.
+
+Test: fast/misc/geolocation-local-security-origin.html
+
+* Modules/geolocation/Geolocation.cpp:
+(WebCore::Geolocation::shouldBlockGeolocationRequests):
+
2017-05-11 Chris Dumez
Drop remaining uses of PassRefPtr in WebCore
Modified: trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp (216752 => 216753)
--- trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp 2017-05-12 07:52:50 UTC (rev 216752)
+++ trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp 2017-05-12 08:08:45 UTC (rev 216753)
@@ -350,9 +350,9 @@
{
bool isSecure = SecurityOrigin::isSecure(document()->url());
bool hasMixedContent = document()->foundMixedContent();
-bool isLocalFile = document()->url().isLocalFile();
+bool isLocalOrigin = securityOrigin()->isLocal();
if (securityOrigin()->canRequestGeolocation()) {
-if (isLocalFile || (isSecure && !hasMixedContent))
+if (isLocalOrigin || (isSecure && !hasMixedContent))
return false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216744] branches/safari-604.1.21-branch/Source/WebKit/win
Title: [216744] branches/safari-604.1.21-branch/Source/WebKit/win
Revision 216744
Author jmarc...@apple.com
Date 2017-05-12 00:52:27 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216554. rdar://problem/27362159
Modified Paths
branches/safari-604.1.21-branch/Source/WebKit/win/ChangeLog
branches/safari-604.1.21-branch/Source/WebKit/win/Plugins/PluginView.h
branches/safari-604.1.21-branch/Source/WebKit/win/Plugins/PluginViewWin.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WebKit/win/ChangeLog (216743 => 216744)
--- branches/safari-604.1.21-branch/Source/WebKit/win/ChangeLog 2017-05-12 07:52:24 UTC (rev 216743)
+++ branches/safari-604.1.21-branch/Source/WebKit/win/ChangeLog 2017-05-12 07:52:27 UTC (rev 216744)
@@ -1,3 +1,15 @@
+2017-05-11 Jason Marcell
+
+Cherry-pick r216554. rdar://problem/27362159
+
+2017-05-09 Dean Jackson
+
+Fix Windows build.
+
+* Plugins/PluginView.h:
+* Plugins/PluginViewWin.cpp:
+(WebCore::PluginView::paint):
+
2017-04-27 Alex Christensen
Modernize Frame.h
Modified: branches/safari-604.1.21-branch/Source/WebKit/win/Plugins/PluginView.h (216743 => 216744)
--- branches/safari-604.1.21-branch/Source/WebKit/win/Plugins/PluginView.h 2017-05-12 07:52:24 UTC (rev 216743)
+++ branches/safari-604.1.21-branch/Source/WebKit/win/Plugins/PluginView.h 2017-05-12 07:52:27 UTC (rev 216744)
@@ -180,7 +180,7 @@
void setFocus(bool) override;
void show() override;
void hide() override;
-void paint(GraphicsContext&, const IntRect&) override;
+void paint(GraphicsContext&, const IntRect&, Widget::SecurityOriginPaintPolicy) override;
void clipRectChanged() override;
// This method is used by plugins on all platforms to obtain a clip rect that includes clips set by WebCore,
Modified: branches/safari-604.1.21-branch/Source/WebKit/win/Plugins/PluginViewWin.cpp (216743 => 216744)
--- branches/safari-604.1.21-branch/Source/WebKit/win/Plugins/PluginViewWin.cpp 2017-05-12 07:52:24 UTC (rev 216743)
+++ branches/safari-604.1.21-branch/Source/WebKit/win/Plugins/PluginViewWin.cpp 2017-05-12 07:52:27 UTC (rev 216744)
@@ -537,7 +537,7 @@
#endif
}
-void PluginView::paint(GraphicsContext& context, const IntRect& rect)
+void PluginView::paint(GraphicsContext& context, const IntRect& rect, Widget::SecurityOriginPaintPolicy)
{
if (!m_isStarted) {
// Draw the "missing plugin" image
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216752] branches/safari-604.1.21-branch/Source
Title: [216752] branches/safari-604.1.21-branch/Source
Revision 216752
Author jmarc...@apple.com
Date 2017-05-12 00:52:50 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216691. rdar://problem/32136567
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/Modules/applepay/ApplePayError.idl
branches/safari-604.1.21-branch/Source/WebCore/Modules/applepay/PaymentRequest.h
branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog
branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216751 => 216752)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:47 UTC (rev 216751)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:50 UTC (rev 216752)
@@ -1,5 +1,20 @@
2017-05-11 Jason Marcell
+Cherry-pick r216691. rdar://problem/32136567
+
+2017-05-11 Andy Estes
+
+Fix a spelling mistake in ApplePayErrorCode
+https://bugs.webkit.org/show_bug.cgi?id=171981
+
+
+Reviewed by Beth Dakin.
+
+* Modules/applepay/ApplePayError.idl:
+* Modules/applepay/PaymentRequest.h:
+
+2017-05-11 Jason Marcell
+
Cherry-pick r216650. rdar://problem/32111991
2017-05-10 Eric Carlson
Modified: branches/safari-604.1.21-branch/Source/WebCore/Modules/applepay/ApplePayError.idl (216751 => 216752)
--- branches/safari-604.1.21-branch/Source/WebCore/Modules/applepay/ApplePayError.idl 2017-05-12 07:52:47 UTC (rev 216751)
+++ branches/safari-604.1.21-branch/Source/WebCore/Modules/applepay/ApplePayError.idl 2017-05-12 07:52:50 UTC (rev 216752)
@@ -29,7 +29,7 @@
"unknown",
"shippingContactInvalid",
"billingContactInvalid",
-"addressUnservicable"
+"addressUnserviceable"
};
[
Modified: branches/safari-604.1.21-branch/Source/WebCore/Modules/applepay/PaymentRequest.h (216751 => 216752)
--- branches/safari-604.1.21-branch/Source/WebCore/Modules/applepay/PaymentRequest.h 2017-05-12 07:52:47 UTC (rev 216751)
+++ branches/safari-604.1.21-branch/Source/WebCore/Modules/applepay/PaymentRequest.h 2017-05-12 07:52:50 UTC (rev 216752)
@@ -155,7 +155,7 @@
Unknown,
ShippingContactInvalid,
BillingContactInvalid,
-AddressUnservicable,
+AddressUnserviceable,
};
enum class ContactField {
@@ -207,7 +207,7 @@
WebCore::PaymentError::Code::Unknown,
WebCore::PaymentError::Code::ShippingContactInvalid,
WebCore::PaymentError::Code::BillingContactInvalid,
-WebCore::PaymentError::Code::AddressUnservicable
+WebCore::PaymentError::Code::AddressUnserviceable
>;
};
Modified: branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog (216751 => 216752)
--- branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-12 07:52:47 UTC (rev 216751)
+++ branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-12 07:52:50 UTC (rev 216752)
@@ -1,5 +1,21 @@
2017-05-11 Jason Marcell
+Cherry-pick r216691. rdar://problem/32136567
+
+2017-05-11 Andy Estes
+
+Fix a spelling mistake in ApplePayErrorCode
+https://bugs.webkit.org/show_bug.cgi?id=171981
+
+
+Reviewed by Beth Dakin.
+
+* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
+(WebKit::toPKPaymentErrorCode):
+(WebKit::toPKPaymentAuthorizationStatus):
+
+2017-05-11 Jason Marcell
+
Cherry-pick r216616. rdar://problem/32116375
2017-05-10 Alex Christensen
Modified: branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm (216751 => 216752)
--- branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2017-05-12 07:52:47 UTC (rev 216751)
+++ branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2017-05-12 07:52:50 UTC (rev 216752)
@@ -580,7 +580,7 @@
return PKPaymentShippingContactInvalidError;
case WebCore::PaymentError::Code::BillingContactInvalid:
return PKPaymentBillingContactInvalidError;
-case WebCore::PaymentError::Code::AddressUnservicable:
+case WebCore::PaymentError::Code::AddressUnserviceable:
return PKPaymentShippingAddressUnserviceableError;
}
}
@@ -666,7 +666,7 @@
auto& error = result->errors[0];
switch (error.code) {
case WebCore::PaymentError::Code::Unknown:
-case WebCore::PaymentError::Code::AddressUnservicable:
+case WebCore::PaymentError::Code::AddressUnserviceable:
return PKPaymentAuthorizationStatusFailure;
case WebCore::PaymentError::Code::BillingContactInvalid:
@@ -750,7 +750,7 @@
auto& error = update->
[webkit-changes] [216751] branches/safari-604.1.21-branch/Source/WebCore
Title: [216751] branches/safari-604.1.21-branch/Source/WebCore
Revision 216751
Author jmarc...@apple.com
Date 2017-05-12 00:52:47 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216650. rdar://problem/32111991
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216750 => 216751)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:45 UTC (rev 216750)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:47 UTC (rev 216751)
@@ -1,5 +1,20 @@
2017-05-11 Jason Marcell
+Cherry-pick r216650. rdar://problem/32111991
+
+2017-05-10 Eric Carlson
+
+[MediaStream] CoreAudioCaptureSource claims to never be muted
+https://bugs.webkit.org/show_bug.cgi?id=171946
+
+
+Reviewed by Jer Noble.
+
+* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+(WebCore::CoreAudioCaptureSource::stopProducingData): Set m_muted to true.
+
+2017-05-11 Jason Marcell
+
Cherry-pick r216645. rdar://problem/31995807
2017-05-10 Jer Noble
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (216750 => 216751)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2017-05-12 07:52:45 UTC (rev 216750)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2017-05-12 07:52:47 UTC (rev 216751)
@@ -683,7 +683,7 @@
{
CoreAudioSharedUnit::singleton().stopProducingData();
m_isProducingData = false;
-m_muted = false;
+m_muted = true;
if (m_audioSourceProvider)
m_audioSourceProvider->unprepare();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216748] branches/safari-604.1.21-branch/Source/WebKit2
Title: [216748] branches/safari-604.1.21-branch/Source/WebKit2 Revision 216748 Author jmarc...@apple.com Date 2017-05-12 00:52:41 -0700 (Fri, 12 May 2017) Log Message Cherry-pick r216616. rdar://problem/32116375 Modified Paths branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog branches/safari-604.1.21-branch/Source/WebKit2/Shared/API/Cocoa/WebKit.h Diff Modified: branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog (216747 => 216748) --- branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-12 07:52:38 UTC (rev 216747) +++ branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-12 07:52:41 UTC (rev 216748) @@ -1,5 +1,18 @@ 2017-05-11 Jason Marcell +Cherry-pick r216616. rdar://problem/32116375 + +2017-05-10 Alex Christensen + +Include headers in WebKit.h +https://bugs.webkit.org/show_bug.cgi?id=171943 + +Reviewed by Dan Bernstein. + +* Shared/API/Cocoa/WebKit.h: + +2017-05-11 Jason Marcell + Cherry-pick r216612. rdar://problem/32080713 2017-05-10 Timothy Horton Modified: branches/safari-604.1.21-branch/Source/WebKit2/Shared/API/Cocoa/WebKit.h (216747 => 216748) --- branches/safari-604.1.21-branch/Source/WebKit2/Shared/API/Cocoa/WebKit.h 2017-05-12 07:52:38 UTC (rev 216747) +++ branches/safari-604.1.21-branch/Source/WebKit2/Shared/API/Cocoa/WebKit.h 2017-05-12 07:52:41 UTC (rev 216748) @@ -30,6 +30,7 @@ #import #import #import +#import #import #import #import @@ -44,6 +45,8 @@ #import #import #import +#import +#import #import #import #import ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216749] branches/safari-604.1.21-branch/Source/WebCore
Title: [216749] branches/safari-604.1.21-branch/Source/WebCore
Revision 216749
Author jmarc...@apple.com
Date 2017-05-12 00:52:43 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216623. rdar://problem/32116336
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216748 => 216749)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:41 UTC (rev 216748)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:43 UTC (rev 216749)
@@ -1,5 +1,23 @@
2017-05-11 Jason Marcell
+Cherry-pick r216623. rdar://problem/32116336
+
+2017-05-10 Jer Noble
+
+CoreAudioCaptureSource reports 3 or 5 channel audio output; actually only mono
+https://bugs.webkit.org/show_bug.cgi?id=171940
+
+Reviewed by Eric Carlson.
+
+Asking for the Input VPIO stream format will return the internal mic format, before processing. Instead
+ask for the input bus's output format, which is post processing, which will return the correct number
+of channels (one).
+
+* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):
+
+2017-05-11 Jason Marcell
+
Cherry-pick r216599. rdar://problem/31201793
2017-05-10 Andy Estes
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (216748 => 216749)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2017-05-12 07:52:41 UTC (rev 216748)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2017-05-12 07:52:43 UTC (rev 216749)
@@ -298,7 +298,7 @@
AudioStreamBasicDescription microphoneProcFormat = { };
UInt32 size = sizeof(microphoneProcFormat);
-err = AudioUnitGetProperty(m_ioUnit, kAudioUnitProperty_StreamFormat, kAudioUnitScope_Input, inputBus, µphoneProcFormat, &size);
+err = AudioUnitGetProperty(m_ioUnit, kAudioUnitProperty_StreamFormat, kAudioUnitScope_Output, inputBus, µphoneProcFormat, &size);
if (err) {
LOG(Media, "CoreAudioSharedUnit::configureMicrophoneProc(%p) unable to get output stream format, error %d (%.4s)", this, (int)err, (char*)&err);
return err;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216743] branches/safari-604.1.21-branch
Title: [216743] branches/safari-604.1.21-branch
Revision 216743
Author jmarc...@apple.com
Date 2017-05-12 00:52:24 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216541. rdar://problem/27362159
Modified Paths
branches/safari-604.1.21-branch/LayoutTests/ChangeLog
branches/safari-604.1.21-branch/LayoutTests/platform/ios-wk1/TestExpectations
branches/safari-604.1.21-branch/LayoutTests/platform/mac-wk1/TestExpectations
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/page/FrameView.cpp
branches/safari-604.1.21-branch/Source/WebCore/page/FrameView.h
branches/safari-604.1.21-branch/Source/WebCore/platform/ScrollView.cpp
branches/safari-604.1.21-branch/Source/WebCore/platform/ScrollView.h
branches/safari-604.1.21-branch/Source/WebCore/platform/Scrollbar.cpp
branches/safari-604.1.21-branch/Source/WebCore/platform/Scrollbar.h
branches/safari-604.1.21-branch/Source/WebCore/platform/Widget.h
branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/filters/FilterOperation.h
branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/filters/FilterOperations.cpp
branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/filters/FilterOperations.h
branches/safari-604.1.21-branch/Source/WebCore/platform/gtk/WidgetGtk.cpp
branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WidgetIOS.mm
branches/safari-604.1.21-branch/Source/WebCore/platform/mac/WidgetMac.mm
branches/safari-604.1.21-branch/Source/WebCore/platform/win/WidgetWin.cpp
branches/safari-604.1.21-branch/Source/WebCore/rendering/FilterEffectRenderer.cpp
branches/safari-604.1.21-branch/Source/WebCore/rendering/FilterEffectRenderer.h
branches/safari-604.1.21-branch/Source/WebCore/rendering/PaintInfo.h
branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderLayer.cpp
branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderLayer.h
branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderScrollbar.cpp
branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderScrollbar.h
branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderWidget.cpp
branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog
branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/Plugins/PluginView.h
Added Paths
branches/safari-604.1.21-branch/LayoutTests/http/tests/css/filters-on-iframes-expected.html
branches/safari-604.1.21-branch/LayoutTests/http/tests/css/filters-on-iframes.html
branches/safari-604.1.21-branch/LayoutTests/http/tests/css/resources/blank.html
branches/safari-604.1.21-branch/LayoutTests/http/tests/css/resources/references-external.html
branches/safari-604.1.21-branch/LayoutTests/http/tests/css/resources/solid-red.html
Diff
Modified: branches/safari-604.1.21-branch/LayoutTests/ChangeLog (216742 => 216743)
--- branches/safari-604.1.21-branch/LayoutTests/ChangeLog 2017-05-12 07:52:14 UTC (rev 216742)
+++ branches/safari-604.1.21-branch/LayoutTests/ChangeLog 2017-05-12 07:52:24 UTC (rev 216743)
@@ -1,3 +1,26 @@
+2017-05-11 Jason Marcell
+
+Cherry-pick r216541. rdar://problem/27362159
+
+2017-05-10 Dean Jackson
+
+Restrict SVG filters to accessible security origins
+https://bugs.webkit.org/show_bug.cgi?id=118689
+
+
+Reviewed by Brent Fulgham.
+
+Add a test that shows safe frames, unsafe frames, and
+then a safe frame that itself has an unsafe frame, to
+show that the security requirements are being forwarded
+down the tree.
+
+* http/tests/css/filters-on-iframes-expected.html: Added.
+* http/tests/css/filters-on-iframes.html: Added.
+* http/tests/css/resources/blank.html: Added.
+* http/tests/css/resources/references-external.html: Added.
+* http/tests/css/resources/solid-red.html: Added.
+
2017-05-10 Jason Marcell
Cherry-pick r216331. rdar://problem/31122612
Added: branches/safari-604.1.21-branch/LayoutTests/http/tests/css/filters-on-iframes-expected.html (0 => 216743)
--- branches/safari-604.1.21-branch/LayoutTests/http/tests/css/filters-on-iframes-expected.html (rev 0)
+++ branches/safari-604.1.21-branch/LayoutTests/http/tests/css/filters-on-iframes-expected.html 2017-05-12 07:52:24 UTC (rev 216743)
@@ -0,0 +1,40 @@
+
+body {
+margin: 0;
+padding: 0;
+}
+iframe {
+border: none;
+}
+div {
+display: inline-block;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Added: branches/safari-604.1.21-branch/LayoutTests/http/tests/css/filters-on-iframes.html (0 => 216743)
--- branches/safari-604.1.21-branch/LayoutTests/http/tests/css/filters-on-iframes.html (rev 0)
+++ branches/safari-604.1.21-branch/LayoutTests/http/tests/css/filters-on-iframes.html 2017-05-12 07:52:24 UTC (rev 216743)
@@ -0,0 +1,54 @
[webkit-changes] [216746] branches/safari-604.1.21-branch
Title: [216746] branches/safari-604.1.21-branch Revision 216746 Author jmarc...@apple.com Date 2017-05-12 00:52:33 -0700 (Fri, 12 May 2017) Log Message Cherry-pick r216599. rdar://problem/31201793 Modified Paths branches/safari-604.1.21-branch/LayoutTests/ChangeLog branches/safari-604.1.21-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt branches/safari-604.1.21-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html branches/safari-604.1.21-branch/LayoutTests/http/tests/navigation/resources/keyboard-events-after-navigation.html branches/safari-604.1.21-branch/LayoutTests/http/tests/navigation/resources/keyboard-events-test.js branches/safari-604.1.21-branch/Source/WebCore/ChangeLog branches/safari-604.1.21-branch/Source/WebCore/dom/EventDispatcher.cpp branches/safari-604.1.21-branch/Source/WebCore/editing/Editor.cpp Added Paths branches/safari-604.1.21-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt branches/safari-604.1.21-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html Diff Modified: branches/safari-604.1.21-branch/LayoutTests/ChangeLog (216745 => 216746) --- branches/safari-604.1.21-branch/LayoutTests/ChangeLog 2017-05-12 07:52:29 UTC (rev 216745) +++ branches/safari-604.1.21-branch/LayoutTests/ChangeLog 2017-05-12 07:52:33 UTC (rev 216746) @@ -1,5 +1,27 @@ 2017-05-11 Jason Marcell +Cherry-pick r216599. rdar://problem/31201793 + +2017-05-10 Andy Estes + +Keyboard input suppression should extend to subframes +https://bugs.webkit.org/show_bug.cgi?id=171880 + + +Reviewed by Ryosuke Niwa. + +* http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: +* http/tests/navigation/keyboard-events-during-provisional-navigation.html: +* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt. +* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html. +* http/tests/navigation/resources/keyboard-events-after-navigation.html: +* http/tests/navigation/resources/keyboard-events-test.js: +(runTest): +(waitForProvisionalNavigation.xhr.onreadystatechange): +(waitForProvisionalNavigation): + +2017-05-11 Jason Marcell + Cherry-pick r216541. rdar://problem/27362159 2017-05-10 Dean Jackson Modified: branches/safari-604.1.21-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt (216745 => 216746) --- branches/safari-604.1.21-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt 2017-05-12 07:52:29 UTC (rev 216745) +++ branches/safari-604.1.21-branch/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt 2017-05-12 07:52:33 UTC (rev 216746) @@ -1,23 +1,23 @@ -CONSOLE MESSAGE: line 30: Provisional navigation started. -CONSOLE MESSAGE: line 31: No trusted events should be logged and the input element should have the value "". -CONSOLE MESSAGE: line 18: Dispatching untrusted keypress event. +CONSOLE MESSAGE: line 14: Provisional navigation started. +CONSOLE MESSAGE: line 15: No trusted events should be logged and the input element should have the value "". +CONSOLE MESSAGE: line 20: Dispatching untrusted keypress event. CONSOLE MESSAGE: line 5: keypressevent dispatched (isTrusted: false). -CONSOLE MESSAGE: line 26: Pressing tab. -CONSOLE MESSAGE: line 28: Active element after pressing tab: [object HTMLInputElement]. -CONSOLE MESSAGE: line 30: Pressing "a". -CONSOLE MESSAGE: line 33: Setting marked text to "b". -CONSOLE MESSAGE: line 36: Inserting text "c". -CONSOLE MESSAGE: line 39: Input element value after text input events: "". -CONSOLE MESSAGE: line 34: Pressing "z" with access key modifiers should navigate to resources/keyboard-events-after-navigation.html. +CONSOLE MESSAGE: line 28: Pressing tab. +CONSOLE MESSAGE: line 30: Active element after pressing tab: [object HTMLInputElement]. +CONSOLE MESSAGE: line 32: Pressing "a". +CONSOLE MESSAGE: line 42: Setting marked text to "b". +CONSOLE MESSAGE: line 45: Inserting text "c". +CONSOLE MESSAGE: line 48: Input element value after text input events: "". +CONSOLE MESSAGE: line 18: Pressing "z" with access key modifiers should navigate to resources/keyboard-events-after-navigation.html. CONSOLE MESSAGE: line 6: Finished navigating to resources/keyboard-events-after-navigation.html. CONSOLE MESSAGE: line 7: Trusted events should be logged and the input
[webkit-changes] [216750] branches/safari-604.1.21-branch/Source/WebCore
Title: [216750] branches/safari-604.1.21-branch/Source/WebCore
Revision 216750
Author jmarc...@apple.com
Date 2017-05-12 00:52:45 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216645. rdar://problem/31995807
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216749 => 216750)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:43 UTC (rev 216749)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:45 UTC (rev 216750)
@@ -1,5 +1,25 @@
2017-05-11 Jason Marcell
+Cherry-pick r216645. rdar://problem/31995807
+
+2017-05-10 Jer Noble
+
+RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
+https://bugs.webkit.org/show_bug.cgi?id=171711
+
+Reviewed by Youenn Fablet.
+
+Before iterating over the channels in either the WebAudioBufferList or the AudioBus, ensure
+we don't walk over the end of either by only iterating over the minimum length of either.
+Also, when the internal format of WebAudioSourceProviderAVFObjC changes, notify the
+MediaStreamAudioSourceNode that the number of channels and sample rate have changed.
+
+* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
+(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
+(WebCore::WebAudioSourceProviderAVFObjC::prepare):
+
+2017-05-11 Jason Marcell
+
Cherry-pick r216623. rdar://problem/32116336
2017-05-10 Jer Noble
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm (216749 => 216750)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm 2017-05-12 07:52:43 UTC (rev 216749)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm 2017-05-12 07:52:45 UTC (rev 216750)
@@ -80,8 +80,12 @@
}
WebAudioBufferList list { *m_outputDescription };
-for (unsigned i = 0; i < list.bufferCount(); ++i) {
+for (unsigned i = 0; i < bus->numberOfChannels(); ++i) {
AudioChannel& channel = *bus->channel(i);
+if (i >= list.bufferCount()) {
+channel.zero();
+continue;
+}
auto* buffer = list.buffer(i);
buffer->mNumberChannels = 1;
buffer->mData = channel.mutableData();
@@ -137,8 +141,7 @@
m_dataSource->setInputFormat(*m_inputDescription);
m_dataSource->setOutputFormat(*m_outputDescription);
-RefPtr protectedThis = this;
-callOnMainThread([protectedThis = WTFMove(protectedThis), numberOfChannels, sampleRate] {
+callOnMainThread([protectedThis = makeRef(*this), numberOfChannels, sampleRate] {
if (protectedThis->m_client)
protectedThis->m_client->setFormat(numberOfChannels, sampleRate);
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216745] branches/safari-604.1.21-branch/Source/WebCore
Title: [216745] branches/safari-604.1.21-branch/Source/WebCore
Revision 216745
Author jmarc...@apple.com
Date 2017-05-12 00:52:29 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216559. rdar://problem/31771707
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216744 => 216745)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:27 UTC (rev 216744)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:29 UTC (rev 216745)
@@ -1,5 +1,24 @@
2017-05-11 Jason Marcell
+Cherry-pick r216559. rdar://problem/31771707
+
+2017-05-09 Jeremy Jones
+
+Video fullscreen window level should be below status bar.
+https://bugs.webkit.org/show_bug.cgi?id=171892
+rdar://problem/31771707
+
+Reviewed by Jer Noble.
+
+No new tests because it only affects platform window level.
+
+Move the fullscreen window below the status bar, but above the input field window level.
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
+
+2017-05-11 Jason Marcell
+
Cherry-pick r216541. rdar://problem/27362159
2017-05-10 Dean Jackson
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (216744 => 216745)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2017-05-12 07:52:27 UTC (rev 216744)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2017-05-12 07:52:29 UTC (rev 216745)
@@ -73,7 +73,7 @@
SOFT_LINK_CLASS(UIKit, UIView)
SOFT_LINK_CLASS(UIKit, UIViewController)
SOFT_LINK_CLASS(UIKit, UIColor)
-SOFT_LINK_CONSTANT(UIKit, UIRemoteKeyboardLevel, UIWindowLevel)
+SOFT_LINK_CONSTANT(UIKit, UITextEffectsBeneathStatusBarWindowLevel, UIWindowLevel)
static UIColor *clearUIColor()
{
@@ -613,7 +613,7 @@
[[m_viewController view] setFrame:[m_window bounds]];
[m_viewController _setIgnoreAppSupportedOrientations:YES];
[m_window setRootViewController:m_viewController.get()];
-[m_window setWindowLevel:getUIRemoteKeyboardLevel() + 1];
+[m_window setWindowLevel:getUITextEffectsBeneathStatusBarWindowLevel() + 1];
[m_window makeKeyAndVisible];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216747] branches/safari-604.1.21-branch/Source/WebKit2
Title: [216747] branches/safari-604.1.21-branch/Source/WebKit2 Revision 216747 Author jmarc...@apple.com Date 2017-05-12 00:52:38 -0700 (Fri, 12 May 2017) Log Message Cherry-pick r216612. rdar://problem/32080713 Modified Paths branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog branches/safari-604.1.21-branch/Source/WebKit2/Shared/WebPageCreationParameters.cpp branches/safari-604.1.21-branch/Source/WebKit2/Shared/WebPageCreationParameters.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/Cocoa/VersionChecks.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/PageClient.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm Diff Modified: branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog (216746 => 216747) --- branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-12 07:52:33 UTC (rev 216746) +++ branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-12 07:52:38 UTC (rev 216747) @@ -1,5 +1,56 @@ 2017-05-11 Jason Marcell +Cherry-pick r216612. rdar://problem/32080713 + +2017-05-10 Timothy Horton + +Disable block selection for dynamic selection granularity +https://bugs.webkit.org/show_bug.cgi?id=171908 + + +Reviewed by Enrica Casucci. + +* UIProcess/API/Cocoa/WKWebViewConfiguration.mm: +(-[WKWebViewConfiguration init]): +(-[WKWebViewConfiguration copyWithZone:]): +(-[WKWebViewConfiguration _allowsBlockSelection]): +(-[WKWebViewConfiguration _setAllowsBlockSelection:]): +* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: +Add a private configuration parameter to re-enable block selection. + +* Shared/WebPageCreationParameters.cpp: +(WebKit::WebPageCreationParameters::encode): +(WebKit::WebPageCreationParameters::decode): +* Shared/WebPageCreationParameters.h: +* UIProcess/API/Cocoa/WKWebView.mm: +(-[WKWebView _allowsBlockSelection]): +* UIProcess/API/Cocoa/WKWebViewInternal.h: +* UIProcess/Cocoa/VersionChecks.h: +* UIProcess/PageClient.h: +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::creationParameters): +* UIProcess/ios/PageClientImplIOS.h: +* UIProcess/ios/PageClientImplIOS.mm: +(WebKit::PageClientImpl::allowsBlockSelection): +* WebProcess/WebPage/WebPage.cpp: +* WebProcess/WebPage/WebPage.h: +Plumb allowsBlockSelection through from WKWebViewConfiguration to WebPage. + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView setupInteraction]): +(-[WKContentView useSelectionAssistantWithGranularity:]): +(-[WKContentView _startAssistingKeyboard]): +(-[WKContentView _stopAssistingKeyboard]): +(toUIWebSelectionMode): Deleted. +(-[WKContentView useSelectionAssistantWithMode:]): Deleted. +Stop needlessly converting to UIWebSelectionMode. + +* WebProcess/WebPage/ios/WebPageIOS.mm: +(WebKit::WebPage::shouldSwitchToBlockModeForHandle): +Don't switch to block selection unless allowsBlockSelection is set. + +2017-05-11 Jason Marcell + Cherry-pick r216541. rdar://problem/27362159 2017-05-10 Dean Jackson Modified: branches/safari-604.1.21-branch/Source/WebKit2/Shared/WebPageCreationParameters.cpp (216746 => 216747) --- branches/safari-604.1.21-branch/Source/WebKit2/Shared/WebPageCreationParameters.cpp 2017-05-12 07:52:33 UTC (rev 216746) +++ branches/safari-604.1.21-branch/Source/WebKit2/Shared/WebPageCreationParameters.cpp 2017-05-12 07:52:38 UTC (rev 216747) @@ -84,6 +84,7 @@ encoder << availableScreenSize; encoder << textAutosizingWidth; encoder << ignoresViewportScaleLimits; +encoder << allowsBlockSelection; #endif #if PLATFORM(COCOA) encoder << smartInsertDeleteEnabled; @@ -210,7 +211,10 @@ return false; if (!decoder.decode(parameters
[webkit-changes] [216739] branches/safari-604.1.21-branch
Title: [216739] branches/safari-604.1.21-branch Revision 216739 Author jmarc...@apple.com Date 2017-05-12 00:51:54 -0700 (Fri, 12 May 2017) Log Message Cherry-pick r216197. rdar://problem/31821492 Modified Paths branches/safari-604.1.21-branch/Source/WebCore/ChangeLog branches/safari-604.1.21-branch/Source/WebCore/Modules/mediastream/MediaStream.cpp branches/safari-604.1.21-branch/Source/WebCore/Modules/mediastream/MediaStream.h branches/safari-604.1.21-branch/Source/WebCore/Modules/mediastream/MediaStreamRegistry.cpp branches/safari-604.1.21-branch/Source/WebCore/Modules/mediastream/MediaStreamRegistry.h branches/safari-604.1.21-branch/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp branches/safari-604.1.21-branch/Source/WebCore/Modules/mediastream/MediaStreamTrack.h branches/safari-604.1.21-branch/Source/WebCore/dom/Document.cpp branches/safari-604.1.21-branch/Source/WebCore/dom/Document.h branches/safari-604.1.21-branch/Source/WebCore/page/Page.cpp branches/safari-604.1.21-branch/Source/WebCore/page/Page.h branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/MediaStreamPrivate.h branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/API/C/WKPage.cpp branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaProcessManager.cpp branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaProcessManager.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/WebPageProxy.h branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/MediaStream/UserMediaPermissionRequestManager.h branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in branches/safari-604.1.21-branch/Tools/ChangeLog branches/safari-604.1.21-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Added Paths branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html Diff Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216738 => 216739) --- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:50:30 UTC (rev 216738) +++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:51:54 UTC (rev 216739) @@ -1,3 +1,52 @@ +2017-05-11 Jason Marcell + +Cherry-pick r216197. rdar://problem/31821492 + +2017-05-04 Eric Carlson + +[MediaStream] Allow host application to enable/disable media capture +https://bugs.webkit.org/show_bug.cgi?id=171292 + + +Reviewed by Jer Noble. + +No new layout tests, added an API test instead. + +* Modules/mediastream/MediaStream.cpp: +(WebCore::MediaStream::endStream): New, stop all tracks. +* Modules/mediastream/MediaStream.h: + +* Modules/mediastream/MediaStreamRegistry.cpp: +(WebCore::MediaStreamRegistry::unregisterStream): Minor cleanup. +(WebCore::MediaStreamRegistry::forEach): New, call the lambda with each stream. +(WebCore::MediaStreamRegistry::MediaStreamRegistry): Deleted, unused. +* Modules/mediastream/MediaStreamRegistry.h: + +* Modules/mediastream/MediaStreamTrack.cpp: +(WebCore::MediaStreamTrack::stopTrack): Add parameter so caller can specify if an 'ended' +event should be sent or not. +(WebCore::MediaStreamTrack::trackMutedChanged): Don't post an event if the track has ended. +* Modules/mediastream/MediaStreamTrack.h: + +* dom/Document.cpp: +(WebCore::Document::stopMediaCapture): Stop all streams in the document. +* dom/Document.h: + +* page/Page.cpp: +(WebCore::Page::stopMediaCapture): Stop all streams. +* page/Page.h: + +
[webkit-changes] [216740] branches/safari-604.1.21-branch
Title: [216740] branches/safari-604.1.21-branch Revision 216740 Author jmarc...@apple.com Date 2017-05-12 00:52:02 -0700 (Fri, 12 May 2017) Log Message Cherry-pick r216212. rdar://problem/31544320 Modified Paths branches/safari-604.1.21-branch/Source/WebCore/ChangeLog branches/safari-604.1.21-branch/Source/WebCore/dom/DocumentMarker.h branches/safari-604.1.21-branch/Source/WebCore/dom/DocumentMarkerController.cpp branches/safari-604.1.21-branch/Source/WebCore/dom/DocumentMarkerController.h branches/safari-604.1.21-branch/Source/WebCore/page/DragController.h branches/safari-604.1.21-branch/Source/WebCore/page/DragState.h branches/safari-604.1.21-branch/Source/WebCore/page/EventHandler.cpp branches/safari-604.1.21-branch/Source/WebCore/page/EventHandler.h branches/safari-604.1.21-branch/Source/WebCore/page/FocusController.cpp branches/safari-604.1.21-branch/Source/WebCore/rendering/InlineTextBox.cpp branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderReplaced.cpp branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderText.cpp branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderText.h branches/safari-604.1.21-branch/Source/WebCore/rendering/TextPainter.cpp branches/safari-604.1.21-branch/Source/WebCore/rendering/TextPainter.h branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/WebPageProxy.h branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h branches/safari-604.1.21-branch/Tools/ChangeLog branches/safari-604.1.21-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm branches/safari-604.1.21-branch/Tools/TestWebKitAPI/ios/DataInteractionSimulator.h branches/safari-604.1.21-branch/Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm Added Paths branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html Diff Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216739 => 216740) --- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:51:54 UTC (rev 216739) +++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:02 UTC (rev 216740) @@ -1,5 +1,109 @@ 2017-05-11 Jason Marcell +Cherry-pick r216212. rdar://problem/31544320 + +2017-05-04 Wenson Hsieh + +[WK2] Add support for keeping the selection in a focused editable element when dragging begins +https://bugs.webkit.org/show_bug.cgi?id=171585 + + +Reviewed by Beth Dakin and Zalan Bujtas. + +Covered by 4 API tests. + +* dom/DocumentMarker.h: + +Introduces the DraggedContent DocumentMarker type, which applies to the Range in the DOM that is being used as +a drag source. Also adds DraggedContentData, which contains nodes found by the TextIterator in the process of +finding Ranges to mark. + +(WebCore::DocumentMarker::AllMarkers::AllMarkers): +* dom/DocumentMarkerController.cpp: +(WebCore::DocumentMarkerController::addDraggedContentMarker): +(WebCore::shouldInsertAsSeparateMarker): +(WebCore::DocumentMarkerController::addMarker): + +When adding DocumentMarkers of type DraggedContent, keep adjacent RenderReplaced elements separate, rather than +merging them into existing RenderedDocumentMarkers. This is because the data for each of these (i.e. the target +node) needs to be preserved. + +(WebCore::DocumentMarkerController::markersFor): + +Bail and return an empty list if the map of document markers cannot possibly contain a dragged content marker. + +* dom/DocumentMarkerController.h: +* page/DragController.h: +* page/DragState.h: + +Add draggedContentRange to DragState. This tracks the Range that is being dragged; it is created when the drag +session has begun, and ends when drag session finishes (either via WebPage::dragEnded or WebPage::dragCancelled). + +* page/EventHandler.cpp: +(WebCore::repaintContentsOfRange): +(WebCore::EventHandler::dragCancelled): + +Called when a drag is cancelled in the UI process without a session ever getting a chance to begin. We use this +as a hook to remove all DraggedContent document markers from the document of the dragged content range. + +(WebCore::EventHandler::didStartDrag): + +Called when a drag session has begun in the UI process. We use this as a hook to set up document markers for the
[webkit-changes] [216741] branches/safari-604.1.21-branch/Source
Title: [216741] branches/safari-604.1.21-branch/Source
Revision 216741
Author jmarc...@apple.com
Date 2017-05-12 00:52:08 -0700 (Fri, 12 May 2017)
Log Message
Cherry-pick r216216. rdar://problem/31814074
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/platform/cocoa/WebPlaybackSessionModel.h
branches/safari-604.1.21-branch/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h
branches/safari-604.1.21-branch/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm
branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebAVPlayerController.h
branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebAVPlayerController.mm
branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.h
branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm
branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog
branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h
branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.messages.in
branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.mm
branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/cocoa/WebPlaybackSessionManager.h
branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/cocoa/WebPlaybackSessionManager.messages.in
branches/safari-604.1.21-branch/Source/WebKit2/WebProcess/cocoa/WebPlaybackSessionManager.mm
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (216740 => 216741)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:02 UTC (rev 216740)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-12 07:52:08 UTC (rev 216741)
@@ -1,5 +1,39 @@
2017-05-11 Jason Marcell
+Cherry-pick r216216. rdar://problem/31814074
+
+2017-05-04 Jeremy Jones
+
+Add muted to WebPlaybackSessionModel.
+https://bugs.webkit.org/show_bug.cgi?id=171592
+rdar://problem/31814074
+
+Reviewed by Jer Noble.
+
+No behavior change. This just adds the ability for UI to mute.
+
+* platform/cocoa/WebPlaybackSessionModel.h:
+(WebCore::WebPlaybackSessionModelClient::mutedChanged):
+* platform/cocoa/WebPlaybackSessionModelMediaElement.h:
+* platform/cocoa/WebPlaybackSessionModelMediaElement.mm:
+(WebCore::WebPlaybackSessionModelMediaElement::updateForEventName):
+(WebCore::WebPlaybackSessionModelMediaElement::toggleMuted):
+(WebCore::WebPlaybackSessionModelMediaElement::observedEventNames):
+(WebCore::WebPlaybackSessionModelMediaElement::isMuted):
+* platform/ios/WebAVPlayerController.h:
+* platform/ios/WebAVPlayerController.mm:
+(-[WebAVPlayerController toggleMuted:]):
+* platform/ios/WebPlaybackSessionInterfaceAVKit.h:
+* platform/ios/WebPlaybackSessionInterfaceAVKit.mm:
+(WebCore::WebPlaybackSessionInterfaceAVKit::mutedChanged):
+* platform/ios/WebVideoFullscreenControllerAVKit.mm:
+(WebVideoFullscreenControllerContext::mutedChanged):
+(WebVideoFullscreenControllerContext::isMuted):
+(WebVideoFullscreenControllerContext::toggleMuted):
+* platform/spi/ios/MediaPlayerSPI.h:
+
+2017-05-11 Jason Marcell
+
Cherry-pick r216212. rdar://problem/31544320
2017-05-04 Wenson Hsieh
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/cocoa/WebPlaybackSessionModel.h (216740 => 216741)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/cocoa/WebPlaybackSessionModel.h 2017-05-12 07:52:02 UTC (rev 216740)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/cocoa/WebPlaybackSessionModel.h 2017-05-12 07:52:08 UTC (rev 216741)
@@ -56,6 +56,7 @@
virtual void selectAudioMediaOption(uint64_t index) = 0;
virtual void selectLegibleMediaOption(uint64_t index) = 0;
virtual void togglePictureInPicture() = 0;
+virtual void toggleMuted() = 0;
enum ExternalPlaybackTargetType { TargetTypeNone, TargetTypeAirPlay, TargetTypeTVOut };
@@ -76,6 +77,7 @@
virtual ExternalPlaybackTargetType externalPlaybackTargetType() const = 0;
virtual String externalPlaybackLocalizedDeviceName() const = 0;
virtual bool wirelessVideoPlaybackDisabled() const = 0;
+virtual bool isMuted() const = 0;
};
class WebPlaybackSessionModelClient {
@@ -94,6 +96,7 @@
virtual void legibleMediaSelectionIndexChanged(uint64_t) { }
virtual void externalPlaybackChanged(bool /* enabled */, WebPlaybackSessionModel::ExternalPlaybackTargetType, const String& /* localizedDeviceName */) { }
[webkit-changes] [216738] trunk/Tools
Title: [216738] trunk/Tools
Revision 216738
Author carlo...@webkit.org
Date 2017-05-12 00:50:30 -0700 (Fri, 12 May 2017)
Log Message
Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
URL parameter using the default value "about:blank" when not provided.
* TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
(testWebViewCreateNavigationData):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp
Diff
Modified: trunk/Tools/ChangeLog (216737 => 216738)
--- trunk/Tools/ChangeLog 2017-05-12 07:48:33 UTC (rev 216737)
+++ trunk/Tools/ChangeLog 2017-05-12 07:50:30 UTC (rev 216738)
@@ -1,3 +1,13 @@
+2017-05-12 Carlos Garcia Campos
+
+Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
+
+In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
+URL parameter using the default value "about:blank" when not provided.
+
+* TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
+(testWebViewCreateNavigationData):
+
2017-05-11 Youenn Fablet
Allow WPT server to serve specific WebKit test
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp (216737 => 216738)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp 2017-05-12 07:48:33 UTC (rev 216737)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp 2017-05-12 07:50:30 UTC (rev 216738)
@@ -455,7 +455,7 @@
test->loadHTML("");
test->waitUntilMainLoopFinishes();
-g_assert_cmpstr(webkit_uri_request_get_uri(webkit_navigation_action_get_request(test->m_navigation)), ==, "");
+g_assert_cmpstr(webkit_uri_request_get_uri(webkit_navigation_action_get_request(test->m_navigation)), ==, "about:blank");
g_assert_cmpuint(webkit_navigation_action_get_navigation_type(test->m_navigation), ==, WEBKIT_NAVIGATION_TYPE_OTHER);
g_assert_cmpuint(webkit_navigation_action_get_mouse_button(test->m_navigation), ==, 0);
g_assert_cmpuint(webkit_navigation_action_get_modifiers(test->m_navigation), ==, 0);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [216737] trunk/Source/WTF
Title: [216737] trunk/Source/WTF Revision 216737 Author o...@webkit.org Date 2017-05-12 00:48:33 -0700 (Fri, 12 May 2017) Log Message Unreviewed trivial JSCOnly buildfix after r216731. https://bugs.webkit.org/show_bug.cgi?id=171693 * wtf/PlatformJSCOnly.cmake: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformJSCOnly.cmake Diff Modified: trunk/Source/WTF/ChangeLog (216736 => 216737) --- trunk/Source/WTF/ChangeLog 2017-05-12 06:58:21 UTC (rev 216736) +++ trunk/Source/WTF/ChangeLog 2017-05-12 07:48:33 UTC (rev 216737) @@ -1,3 +1,10 @@ +2017-05-12 Csaba Osztrogonác + +Unreviewed trivial JSCOnly buildfix after r216731. +https://bugs.webkit.org/show_bug.cgi?id=171693 + +* wtf/PlatformJSCOnly.cmake: + 2017-05-11 Yusuke Suzuki [Win] Implement memoryFootprint for Windows Modified: trunk/Source/WTF/wtf/PlatformJSCOnly.cmake (216736 => 216737) --- trunk/Source/WTF/wtf/PlatformJSCOnly.cmake 2017-05-12 06:58:21 UTC (rev 216736) +++ trunk/Source/WTF/wtf/PlatformJSCOnly.cmake 2017-05-12 07:48:33 UTC (rev 216737) @@ -21,7 +21,7 @@ list(APPEND WTF_SOURCES win/MemoryFootprintWin.cpp ) -else (APPLE) +elseif (APPLE) list(APPEND WTF_SOURCES cocoa/MemoryFootprintCocoa.cpp ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
