[webkit-changes] [217184] trunk/Tools
Title: [217184] trunk/Tools
Revision 217184
Author commit-qu...@webkit.org
Date 2017-05-19 23:55:38 -0700 (Fri, 19 May 2017)
Log Message
[Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
https://bugs.webkit.org/show_bug.cgi?id=172267
Patch by Fujii Hironori on 2017-05-19
Reviewed by Per Arne Vollan.
TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
TestWebCoreLib should link only with WebCore. And, TestWebKitLib
should link only with WebKit.
Unfortunately, there is a layer violation at the moment.
WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
in WebKit. This change contains a stub of loadResourceIntoBuffer
in TestWebCoreLib for the workaround.
* TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
TestWebCoreLib. Do not link WebCore to TestWebKitLib.
* TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
(loadResourceIntoBuffer): Added a stub.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformWin.cmake
Added Paths
trunk/Tools/TestWebKitAPI/win/TestWebCoreStubs.cpp
Diff
Modified: trunk/Tools/ChangeLog (217183 => 217184)
--- trunk/Tools/ChangeLog 2017-05-20 04:24:42 UTC (rev 217183)
+++ trunk/Tools/ChangeLog 2017-05-20 06:55:38 UTC (rev 217184)
@@ -1,3 +1,24 @@
+2017-05-19 Fujii Hironori
+
+[Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
+https://bugs.webkit.org/show_bug.cgi?id=172267
+
+Reviewed by Per Arne Vollan.
+
+TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
+TestWebCoreLib should link only with WebCore. And, TestWebKitLib
+should link only with WebKit.
+
+Unfortunately, there is a layer violation at the moment.
+WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
+in WebKit. This change contains a stub of loadResourceIntoBuffer
+in TestWebCoreLib for the workaround.
+
+* TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
+TestWebCoreLib. Do not link WebCore to TestWebKitLib.
+* TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
+(loadResourceIntoBuffer): Added a stub.
+
2017-05-19 Simon Fraser
Fix dump-class-layout to handle different file architectures
Modified: trunk/Tools/TestWebKitAPI/PlatformWin.cmake (217183 => 217184)
--- trunk/Tools/TestWebKitAPI/PlatformWin.cmake 2017-05-20 04:24:42 UTC (rev 217183)
+++ trunk/Tools/TestWebKitAPI/PlatformWin.cmake 2017-05-20 06:55:38 UTC (rev 217184)
@@ -36,7 +36,6 @@
Usp10
WebCore${DEBUG_SUFFIX}
WebCoreDerivedSources${DEBUG_SUFFIX}
-WebKit${DEBUG_SUFFIX}
WindowsCodecs
gtest
)
@@ -43,6 +42,7 @@
set(TestWebCoreLib_SOURCES
${test_main_SOURCES}
+win/TestWebCoreStubs.cpp
${TESTWEBKITAPI_DIR}/TestsController.cpp
${TESTWEBKITAPI_DIR}/Tests/WebCore/AffineTransform.cpp
${TESTWEBKITAPI_DIR}/Tests/WebCore/CalculationValue.cpp
@@ -140,6 +140,11 @@
)
endif ()
+set(test_webkit_LIBRARIES
+WebCoreTestSupport
+WebKit${DEBUG_SUFFIX}
+gtest
+)
add_library(TestWebKitLib SHARED
${test_main_SOURCES}
${TESTWEBKITAPI_DIR}/TestsController.cpp
@@ -148,7 +153,7 @@
${TESTWEBKITAPI_DIR}/win/HostWindow.cpp
)
-target_link_libraries(TestWebKitLib ${test_webcore_LIBRARIES})
+target_link_libraries(TestWebKitLib ${test_webkit_LIBRARIES})
add_executable(TestWebKit
${TOOLS_DIR}/win/DLLLauncher/DLLLauncherMain.cpp
Added: trunk/Tools/TestWebKitAPI/win/TestWebCoreStubs.cpp (0 => 217184)
--- trunk/Tools/TestWebKitAPI/win/TestWebCoreStubs.cpp (rev 0)
+++ trunk/Tools/TestWebKitAPI/win/TestWebCoreStubs.cpp 2017-05-20 06:55:38 UTC (rev 217184)
@@ -0,0 +1,32 @@
+/*
+ * Copyright (C) 2017 Sony Interactive Entertainment Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CON
[webkit-changes] [217183] trunk/Source/WebCore
Title: [217183] trunk/Source/WebCore
Revision 217183
Author commit-qu...@webkit.org
Date 2017-05-19 21:24:42 -0700 (Fri, 19 May 2017)
Log Message
WebAVStreamDataParserListener String leak
https://bugs.webkit.org/show_bug.cgi?id=172395
Patch by Joseph Pecoraro on 2017-05-19
Reviewed by Chris Dumez.
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]):
(-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]):
Use an isolated String in a lambda used across threads.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (217182 => 217183)
--- trunk/Source/WebCore/ChangeLog 2017-05-20 03:31:28 UTC (rev 217182)
+++ trunk/Source/WebCore/ChangeLog 2017-05-20 04:24:42 UTC (rev 217183)
@@ -1,3 +1,15 @@
+2017-05-19 Joseph Pecoraro
+
+WebAVStreamDataParserListener String leak
+https://bugs.webkit.org/show_bug.cgi?id=172395
+
+Reviewed by Chris Dumez.
+
+* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]):
+(-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]):
+Use an isolated String in a lambda used across threads.
+
2017-05-19 Chris Dumez
Consider not exposing webkitURL in workers
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm (217182 => 217183)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm 2017-05-20 03:31:28 UTC (rev 217182)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm 2017-05-20 04:24:42 UTC (rev 217183)
@@ -175,8 +175,7 @@
ASSERT_UNUSED(streamDataParser, streamDataParser == _parser);
RetainPtr protectedSample = sample;
-String mediaType = nsMediaType;
-callOnMainThread([parent = _parent, protectedSample = WTFMove(protectedSample), trackID, mediaType, flags] {
+callOnMainThread([parent = _parent, protectedSample = WTFMove(protectedSample), trackID, mediaType = String(nsMediaType), flags] {
if (parent)
parent->didProvideMediaDataForTrackID(trackID, protectedSample.get(), mediaType, flags);
});
@@ -186,8 +185,7 @@
{
ASSERT_UNUSED(streamDataParser, streamDataParser == _parser);
-String mediaType = nsMediaType;
-callOnMainThread([parent = _parent, trackID, mediaType] {
+callOnMainThread([parent = _parent, trackID, mediaType = String(nsMediaType)] {
if (parent)
parent->didReachEndOfTrackWithTrackID(trackID, mediaType);
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217181] trunk
Title: [217181] trunk
Revision 217181
Author cdu...@apple.com
Date 2017-05-19 19:30:27 -0700 (Fri, 19 May 2017)
Log Message
Consider not exposing webkitURL in workers
https://bugs.webkit.org/show_bug.cgi?id=172166
Reviewed by Geoffrey Garen.
Source/WebCore:
Drop webkitURL alias for URL in workers, to match other browsers. The risk should
be low given that this only impacts workers, we expose URL to workers and Blink
does not have this alias. We still support the webkitURL alias for URL on Window.
No new tests, rebaselined existing test.
* workers/WorkerGlobalScope.idl:
LayoutTests:
Rebaseline existing test to reflect behavior change.
* js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerGlobalScope.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (217180 => 217181)
--- trunk/LayoutTests/ChangeLog 2017-05-20 01:59:16 UTC (rev 217180)
+++ trunk/LayoutTests/ChangeLog 2017-05-20 02:30:27 UTC (rev 217181)
@@ -1,3 +1,14 @@
+2017-05-19 Chris Dumez
+
+Consider not exposing webkitURL in workers
+https://bugs.webkit.org/show_bug.cgi?id=172166
+
+Reviewed by Geoffrey Garen.
+
+Rebaseline existing test to reflect behavior change.
+
+* js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
+
2017-05-19 Jeremy Jones
webkitSupportsFullscreen and webkitSupportsPresentationMode('fullscreen') disagree.
Modified: trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt (217180 => 217181)
--- trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt 2017-05-20 01:59:16 UTC (rev 217180)
+++ trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt 2017-05-20 02:30:27 UTC (rev 217181)
@@ -389,11 +389,6 @@
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'XMLHttpRequestEventTarget').hasOwnProperty('set') is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'XMLHttpRequestEventTarget').enumerable is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'XMLHttpRequestEventTarget').configurable is true
-PASS [Worker] Object.getOwnPropertyDescriptor(global, 'webkitURL').value is webkitURL
-PASS [Worker] Object.getOwnPropertyDescriptor(global, 'webkitURL').hasOwnProperty('get') is false
-PASS [Worker] Object.getOwnPropertyDescriptor(global, 'webkitURL').hasOwnProperty('set') is false
-PASS [Worker] Object.getOwnPropertyDescriptor(global, 'webkitURL').enumerable is false
-PASS [Worker] Object.getOwnPropertyDescriptor(global, 'webkitURL').configurable is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/Source/WebCore/ChangeLog (217180 => 217181)
--- trunk/Source/WebCore/ChangeLog 2017-05-20 01:59:16 UTC (rev 217180)
+++ trunk/Source/WebCore/ChangeLog 2017-05-20 02:30:27 UTC (rev 217181)
@@ -1,3 +1,18 @@
+2017-05-19 Chris Dumez
+
+Consider not exposing webkitURL in workers
+https://bugs.webkit.org/show_bug.cgi?id=172166
+
+Reviewed by Geoffrey Garen.
+
+Drop webkitURL alias for URL in workers, to match other browsers. The risk should
+be low given that this only impacts workers, we expose URL to workers and Blink
+does not have this alias. We still support the webkitURL alias for URL on Window.
+
+No new tests, rebaselined existing test.
+
+* workers/WorkerGlobalScope.idl:
+
2017-05-19 Youenn Fablet
Add RTCPeerConnection connection state change logging
Modified: trunk/Source/WebCore/workers/WorkerGlobalScope.idl (217180 => 217181)
--- trunk/Source/WebCore/workers/WorkerGlobalScope.idl 2017-05-20 01:59:16 UTC (rev 217180)
+++ trunk/Source/WebCore/workers/WorkerGlobalScope.idl 2017-05-20 02:30:27 UTC (rev 217181)
@@ -45,8 +45,6 @@
// Additional constructors
-attribute DOMURLConstructor webkitURL; // FIXME: deprecate this.
-
// FIXME: Automatically generate these once we can drop the IndexedDBWorkers runtime flag.
[Conditional=INDEXED_DATABASE_IN_WORKERS, EnabledAtRuntime=IndexedDBWorkers] attribute IDBCursorConstructor IDBCursor;
[Conditional=INDEXED_DATABASE_IN_WORKERS, EnabledAtRuntime=IndexedDBWorkers] attribute IDBCursorWithValueConstructor IDBCursorWithValue;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217180] trunk/Source/WebCore
Title: [217180] trunk/Source/WebCore
Revision 217180
Author commit-qu...@webkit.org
Date 2017-05-19 18:59:16 -0700 (Fri, 19 May 2017)
Log Message
Add RTCPeerConnection connection state change logging
https://bugs.webkit.org/show_bug.cgi?id=172314
Patch by Youenn Fablet on 2017-05-19
Reviewed by Eric Carlson.
No change of behavior.
Adding some release logging of connection state changes.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::rtcIceGatheringStateToString):
(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::rtcIceConnectionStateToString):
(WebCore::RTCPeerConnection::updateIceConnectionState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (217179 => 217180)
--- trunk/Source/WebCore/ChangeLog 2017-05-20 00:59:31 UTC (rev 217179)
+++ trunk/Source/WebCore/ChangeLog 2017-05-20 01:59:16 UTC (rev 217180)
@@ -1,3 +1,19 @@
+2017-05-19 Youenn Fablet
+
+Add RTCPeerConnection connection state change logging
+https://bugs.webkit.org/show_bug.cgi?id=172314
+
+Reviewed by Eric Carlson.
+
+No change of behavior.
+Adding some release logging of connection state changes.
+
+* Modules/mediastream/RTCPeerConnection.cpp:
+(WebCore::rtcIceGatheringStateToString):
+(WebCore::RTCPeerConnection::updateIceGatheringState):
+(WebCore::rtcIceConnectionStateToString):
+(WebCore::RTCPeerConnection::updateIceConnectionState):
+
2017-05-19 Jeremy Jones
webkitSupportsFullscreen and webkitSupportsPresentationMode('fullscreen') disagree.
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (217179 => 217180)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2017-05-20 00:59:31 UTC (rev 217179)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2017-05-20 01:59:16 UTC (rev 217180)
@@ -444,8 +444,24 @@
m_signalingState = newState;
}
+#if !RELEASE_LOG_DISABLED
+static inline const char* rtcIceGatheringStateToString(RTCIceGatheringState newState)
+{
+switch (newState) {
+case RTCIceGatheringState::New:
+return "new";
+case RTCIceGatheringState::Gathering:
+return "gathering";
+case RTCIceGatheringState::Complete:
+return "complete";
+}
+}
+#endif
+
void RTCPeerConnection::updateIceGatheringState(RTCIceGatheringState newState)
{
+RELEASE_LOG(WebRTC, "New ICE gathering state: %s\n", rtcIceGatheringStateToString(newState));
+
scriptExecutionContext()->postTask([protectedThis = makeRef(*this), newState](ScriptExecutionContext&) {
if (protectedThis->isClosed() || protectedThis->m_iceGatheringState == newState)
return;
@@ -456,8 +472,32 @@
});
}
+#if !RELEASE_LOG_DISABLED
+static inline const char* rtcIceConnectionStateToString(RTCIceConnectionState newState)
+{
+switch (newState) {
+case RTCIceConnectionState::New:
+return "new";
+case RTCIceConnectionState::Checking:
+return "checking";
+case RTCIceConnectionState::Connected:
+return "connected";
+case RTCIceConnectionState::Completed:
+return "completed";
+case RTCIceConnectionState::Failed:
+return "failed";
+case RTCIceConnectionState::Disconnected:
+return "disconnected";
+case RTCIceConnectionState::Closed:
+return "closed";
+}
+}
+#endif
+
void RTCPeerConnection::updateIceConnectionState(RTCIceConnectionState newState)
{
+RELEASE_LOG(WebRTC, "New ICE connection state: %s\n", rtcIceConnectionStateToString(newState));
+
scriptExecutionContext()->postTask([protectedThis = makeRef(*this), newState](ScriptExecutionContext&) {
if (protectedThis->isClosed() || protectedThis->m_iceConnectionState == newState)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217179] trunk
Title: [217179] trunk
Revision 217179
Author mark@apple.com
Date 2017-05-19 17:59:31 -0700 (Fri, 19 May 2017)
Log Message
[Re-landing] DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring result registers.
https://bugs.webkit.org/show_bug.cgi?id=172383
Reviewed by Filip Pizlo.
JSTests:
* stress/regress-172383.js: Added.
Source/_javascript_Core:
pickCanTrample() is wrongly assuming that one of regT0 and regT1 is always
available as a scratch register. This assumption is wrong if this canTrample
register is used for a silentFill() after an operation that returns a result in
regT0 or regT1.
Turns out the only reason we need the canTrample register is for
SetDoubleConstant. We can remove the need for this canTrample register by
introducing a moveDouble() pseudo instruction in the MacroAssembler to do the
job using the scratchRegister() on X86_64 or the dataMemoryTempRegister() on
ARM64. In so doing, we can simplify the silentFill() code and eliminate the bug.
Update for re-landing: Changed ARM64 to use scratchRegister() as well.
scratchRegister() is the proper way to get the underlying dataMemoryTempRegister()
as a scratch register.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::moveDouble):
* dfg/DFGArrayifySlowPathGenerator.h:
* dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
(JSC::DFG::CallArrayAllocatorWithVariableStructureVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableStructureVariableSizeSlowPathGenerator):
* dfg/DFGCallCreateDirectArgumentsSlowPathGenerator.h:
* dfg/DFGSaneStringGetByValSlowPathGenerator.h:
* dfg/DFGSlowPathGenerator.h:
(JSC::DFG::CallSlowPathGenerator::tearDown):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compileToLowerCase):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::emitUntypedBitOp):
(JSC::DFG::SpeculativeJIT::emitUntypedRightShiftBitOp):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchStringOnString):
(JSC::DFG::SpeculativeJIT::compileStoreBarrier):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::pickCanTrample): Deleted.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::convertAnyInt):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/dfg/DFGArrayifySlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGCallArrayAllocatorSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGCallCreateDirectArgumentsSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGSaneStringGetByValSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Added Paths
trunk/JSTests/stress/regress-172383.js
Diff
Modified: trunk/JSTests/ChangeLog (217178 => 217179)
--- trunk/JSTests/ChangeLog 2017-05-20 00:58:51 UTC (rev 217178)
+++ trunk/JSTests/ChangeLog 2017-05-20 00:59:31 UTC (rev 217179)
@@ -1,3 +1,13 @@
+2017-05-19 Mark Lam
+
+[Re-landing] DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring result registers.
+https://bugs.webkit.org/show_bug.cgi?id=172383
+
+
+Reviewed by Filip Pizlo.
+
+* stress/regress-172383.js: Added.
+
2017-05-19 Ryan Haddad
Unreviewed, rolling out r217156.
Added: trunk/JSTests/stress/regress-172383.js (0 => 217179)
--- trunk/JSTests/stress/regress-172383.js (rev 0)
+++ trunk/JSTests/stress/regress-172383.js 2017-05-20 00:59:31 UTC (rev 217179)
@@ -0,0 +1,40 @@
+// This test should not crash.
+
+let x = undefined;
+
+function foo(w, a0, a1) {
+var r0 = x % a0;
+var r1 = w ^ a1;
+
+var r4 = 3 % 7;
+
+var r6 = w ^ 0;
+var r7 = r4 / r4;
+var r9 = x - r7;
+a1 = 0 + r0;
+
+var r11 = 0 & a0;
+var r12 = r4 * a1;
+var r7 = r11 & a0;
+
+var r15 = r11 | r4;
+var r16 = 0 & r1;
[webkit-changes] [217178] branches/safari-603-branch
Title: [217178] branches/safari-603-branch
Revision 217178
Author jmarc...@apple.com
Date 2017-05-19 17:58:51 -0700 (Fri, 19 May 2017)
Log Message
Cherry-pick r216541. rdar://problem/31971362
Modified Paths
branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/LayoutTests/platform/mac-wk1/TestExpectations
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/page/FrameView.cpp
branches/safari-603-branch/Source/WebCore/page/FrameView.h
branches/safari-603-branch/Source/WebCore/platform/ScrollView.cpp
branches/safari-603-branch/Source/WebCore/platform/ScrollView.h
branches/safari-603-branch/Source/WebCore/platform/Scrollbar.cpp
branches/safari-603-branch/Source/WebCore/platform/Scrollbar.h
branches/safari-603-branch/Source/WebCore/platform/Widget.h
branches/safari-603-branch/Source/WebCore/platform/graphics/filters/FilterOperation.h
branches/safari-603-branch/Source/WebCore/platform/graphics/filters/FilterOperations.cpp
branches/safari-603-branch/Source/WebCore/platform/graphics/filters/FilterOperations.h
branches/safari-603-branch/Source/WebCore/platform/gtk/WidgetGtk.cpp
branches/safari-603-branch/Source/WebCore/platform/ios/WidgetIOS.mm
branches/safari-603-branch/Source/WebCore/platform/mac/WidgetMac.mm
branches/safari-603-branch/Source/WebCore/platform/win/WidgetWin.cpp
branches/safari-603-branch/Source/WebCore/rendering/FilterEffectRenderer.cpp
branches/safari-603-branch/Source/WebCore/rendering/FilterEffectRenderer.h
branches/safari-603-branch/Source/WebCore/rendering/PaintInfo.h
branches/safari-603-branch/Source/WebCore/rendering/RenderLayer.cpp
branches/safari-603-branch/Source/WebCore/rendering/RenderLayer.h
branches/safari-603-branch/Source/WebCore/rendering/RenderScrollbar.cpp
branches/safari-603-branch/Source/WebCore/rendering/RenderScrollbar.h
branches/safari-603-branch/Source/WebCore/rendering/RenderWidget.cpp
branches/safari-603-branch/Source/WebKit2/ChangeLog
branches/safari-603-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
branches/safari-603-branch/Source/WebKit2/WebProcess/Plugins/PluginView.h
Added Paths
branches/safari-603-branch/LayoutTests/http/tests/css/filters-on-iframes-expected.html
branches/safari-603-branch/LayoutTests/http/tests/css/filters-on-iframes.html
branches/safari-603-branch/LayoutTests/http/tests/css/resources/blank.html
branches/safari-603-branch/LayoutTests/http/tests/css/resources/references-external.html
branches/safari-603-branch/LayoutTests/http/tests/css/resources/solid-red.html
Diff
Modified: branches/safari-603-branch/LayoutTests/ChangeLog (217177 => 217178)
--- branches/safari-603-branch/LayoutTests/ChangeLog 2017-05-20 00:43:28 UTC (rev 217177)
+++ branches/safari-603-branch/LayoutTests/ChangeLog 2017-05-20 00:58:51 UTC (rev 217178)
@@ -1,3 +1,22 @@
+2017-05-18 Dean Jackson
+
+Restrict SVG filters to accessible security origins
+https://bugs.webkit.org/show_bug.cgi?id=118689
+
+
+Reviewed by Brent Fulgham.
+
+Add a test that shows safe frames, unsafe frames, and
+then a safe frame that itself has an unsafe frame, to
+show that the security requirements are being forwarded
+down the tree.
+
+* http/tests/css/filters-on-iframes-expected.html: Added.
+* http/tests/css/filters-on-iframes.html: Added.
+* http/tests/css/resources/blank.html: Added.
+* http/tests/css/resources/references-external.html: Added.
+* http/tests/css/resources/solid-red.html: Added.
+
2017-05-19 Ryan Haddad
Unreviewed test gardening.
Added: branches/safari-603-branch/LayoutTests/http/tests/css/filters-on-iframes-expected.html (0 => 217178)
--- branches/safari-603-branch/LayoutTests/http/tests/css/filters-on-iframes-expected.html (rev 0)
+++ branches/safari-603-branch/LayoutTests/http/tests/css/filters-on-iframes-expected.html 2017-05-20 00:58:51 UTC (rev 217178)
@@ -0,0 +1,40 @@
+
+body {
+margin: 0;
+padding: 0;
+}
+iframe {
+border: none;
+}
+div {
+display: inline-block;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Added: branches/safari-603-branch/LayoutTests/http/tests/css/filters-on-iframes.html (0 => 217178)
--- branches/safari-603-branch/LayoutTests/http/tests/css/filters-on-iframes.html (rev 0)
+++ branches/safari-603-branch/LayoutTests/http/tests/css/filters-on-iframes.html 2017-05-20 00:58:51 UTC (rev 217178)
@@ -0,0 +1,54 @@
+
+body {
+margin: 0;
+padding: 0;
+}
+iframe {
+border: none;
+}
+div {
+display: inline-block;
+}
+.filtered {
+filter: url(#noop);
+}
+svg {
+display: none;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Added: branches/safari-603-branch/LayoutTests/http/tests/css/resources/blank.html (0 => 217178)
--- branches/safari-603-branch/LayoutTests/htt
[webkit-changes] [217177] branches/safari-603-branch/LayoutTests
Title: [217177] branches/safari-603-branch/LayoutTests
Revision 217177
Author ryanhad...@apple.com
Date 2017-05-19 17:43:28 -0700 (Fri, 19 May 2017)
Log Message
Unreviewed test gardening.
* platform/mac-wk1/TestExpectations:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/TestExpectations:
Modified Paths
branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/LayoutTests/platform/mac/TestExpectations
branches/safari-603-branch/LayoutTests/platform/mac-wk1/TestExpectations
branches/safari-603-branch/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt
Diff
Modified: branches/safari-603-branch/LayoutTests/ChangeLog (217176 => 217177)
--- branches/safari-603-branch/LayoutTests/ChangeLog 2017-05-20 00:27:33 UTC (rev 217176)
+++ branches/safari-603-branch/LayoutTests/ChangeLog 2017-05-20 00:43:28 UTC (rev 217177)
@@ -1,5 +1,13 @@
2017-05-19 Ryan Haddad
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac/TestExpectations:
+
+2017-05-19 Ryan Haddad
+
Merge r217138. rdar://problem/32182167
2017-05-19 Zalan Bujtas
Modified: branches/safari-603-branch/LayoutTests/platform/mac/TestExpectations (217176 => 217177)
--- branches/safari-603-branch/LayoutTests/platform/mac/TestExpectations 2017-05-20 00:27:33 UTC (rev 217176)
+++ branches/safari-603-branch/LayoutTests/platform/mac/TestExpectations 2017-05-20 00:43:28 UTC (rev 217177)
@@ -1459,3 +1459,5 @@
[ Yosemite ] fast/text/complex-text-opacity.html [ Failure ]
[ Sierra ] js/intl-datetimeformat.html [ Failure ]
+
+streams/readable-byte-stream-controller.html [ Failure ]
Modified: branches/safari-603-branch/LayoutTests/platform/mac-wk1/TestExpectations (217176 => 217177)
--- branches/safari-603-branch/LayoutTests/platform/mac-wk1/TestExpectations 2017-05-20 00:27:33 UTC (rev 217176)
+++ branches/safari-603-branch/LayoutTests/platform/mac-wk1/TestExpectations 2017-05-20 00:43:28 UTC (rev 217177)
@@ -304,3 +304,16 @@
webkit.org/b/167857 pageoverlay/overlay-remove-reinsert-view.html [ Skip ]
pointer-lock/mouse-event-delivery.html [ Failure ]
+
+streams/pipe-to.html [ Failure ]
+streams/reference-implementation/bad-strategies.html [ Failure ]
+streams/reference-implementation/bad-underlying-sinks.html [ Failure ]
+streams/reference-implementation/brand-checks.html [ Failure ]
+streams/reference-implementation/byte-length-queuing-strategy.html [ Failure ]
+streams/reference-implementation/count-queuing-strategy.html [ Failure ]
+streams/reference-implementation/pipe-through.html [ Failure ]
+streams/reference-implementation/pipe-to-options.html [ Failure ]
+streams/reference-implementation/readable-stream-templated.html [ Failure ]
+streams/reference-implementation/writable-stream-abort.html [ Failure ]
+streams/reference-implementation/writable-stream.html [ Failure ]
+streams/shadowing-Promise.html [ Failure ]
Modified: branches/safari-603-branch/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt (217176 => 217177)
--- branches/safari-603-branch/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt 2017-05-20 00:27:33 UTC (rev 217176)
+++ branches/safari-603-branch/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt 2017-05-20 00:43:28 UTC (rev 217177)
@@ -2353,11 +2353,6 @@
PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'WritableStream').value is WritableStream
-PASS Object.getOwnPropertyDescriptor(global, 'WritableStream').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WritableStream').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WritableStream').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'WritableStream').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217176] trunk
Title: [217176] trunk
Revision 217176
Author commit-qu...@webkit.org
Date 2017-05-19 17:27:33 -0700 (Fri, 19 May 2017)
Log Message
webkitSupportsFullscreen and webkitSupportsPresentationMode('fullscreen') disagree.
https://bugs.webkit.org/show_bug.cgi?id=172329
rdar://problem/32260891
Patch by Jeremy Jones on 2017-05-19
Reviewed by Darin Adler.
Source/WebCore:
Updated tests:
* media/media-fullscreen-inline-expected.txt:
* media/media-fullscreen-not-in-document-expected.txt:
* media/media-fullscreen.js:
webkitSupportsPresentationMode('fullscreen') should delegate to webkitSupportsFullscreen.
The additional mediaSession().fullscreenPermitted() check causes it to return false when
not handling a user gesture, which isn't helpful to deciding to show a button in controls
or not.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitSupportsPresentationMode):
LayoutTests:
webkitSupportsPresentationMode('fullscreen') should delegate to webkitSupportsFullscreen.
The additional mediaSession().fullscreenPermitted() check causes it to return false when
not handling a user gesture, which isn't helpful to deciding to show a button in controls
or not.
* media/media-fullscreen-inline-expected.txt:
* media/media-fullscreen-not-in-document-expected.txt:
* media/media-fullscreen.js:
(canplaythrough):
* platform/mac-elcapitan/media/media-fullscreen-inline-expected.txt:
* platform/mac-elcapitan/media/media-fullscreen-not-in-document-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/media-fullscreen-inline-expected.txt
trunk/LayoutTests/media/media-fullscreen-not-in-document-expected.txt
trunk/LayoutTests/media/media-fullscreen.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLVideoElement.cpp
Added Paths
trunk/LayoutTests/platform/mac-elcapitan/media/media-fullscreen-inline-expected.txt
trunk/LayoutTests/platform/mac-elcapitan/media/media-fullscreen-not-in-document-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (217175 => 217176)
--- trunk/LayoutTests/ChangeLog 2017-05-20 00:25:01 UTC (rev 217175)
+++ trunk/LayoutTests/ChangeLog 2017-05-20 00:27:33 UTC (rev 217176)
@@ -1,3 +1,23 @@
+2017-05-19 Jeremy Jones
+
+webkitSupportsFullscreen and webkitSupportsPresentationMode('fullscreen') disagree.
+https://bugs.webkit.org/show_bug.cgi?id=172329
+rdar://problem/32260891
+
+Reviewed by Darin Adler.
+
+webkitSupportsPresentationMode('fullscreen') should delegate to webkitSupportsFullscreen.
+The additional mediaSession().fullscreenPermitted() check causes it to return false when
+not handling a user gesture, which isn't helpful to deciding to show a button in controls
+or not.
+
+* media/media-fullscreen-inline-expected.txt:
+* media/media-fullscreen-not-in-document-expected.txt:
+* media/media-fullscreen.js:
+(canplaythrough):
+* platform/mac-elcapitan/media/media-fullscreen-inline-expected.txt:
+* platform/mac-elcapitan/media/media-fullscreen-not-in-document-expected.txt:
+
2017-05-19 Matt Lewis
Marked webrtc/datachannel/filter-ice-candidate.html as flaky.
Modified: trunk/LayoutTests/media/media-fullscreen-inline-expected.txt (217175 => 217176)
--- trunk/LayoutTests/media/media-fullscreen-inline-expected.txt 2017-05-20 00:25:01 UTC (rev 217175)
+++ trunk/LayoutTests/media/media-fullscreen-inline-expected.txt 2017-05-20 00:27:33 UTC (rev 217176)
@@ -10,6 +10,7 @@
EVENT(canplaythrough)
* event handler NOT triggered by a user gesture
EXPECTED (mediaElement.webkitSupportsFullscreen == 'undefined') OK
+EXPECTED (mediaElement.webkitSupportsPresentationMode == 'undefined') OK
EXPECTED (mediaElement.webkitDisplayingFullscreen == 'undefined') OK
* clicking on button
EVENT(mouseup)
@@ -21,6 +22,7 @@
EVENT(canplaythrough)
* event handler NOT triggered by a user gesture
EXPECTED (mediaElement.webkitSupportsFullscreen == 'true') OK
+EXPECTED (mediaElement.webkitSupportsPresentationMode('fullscreen') == 'true') OK
EXPECTED (mediaElement.webkitDisplayingFullscreen == 'false') OK
TEST(mediaElement.webkitEnterFullScreen()) THROWS(DOMException.INVALID_STATE_ERR) OK
* clicking on button
Modified: trunk/LayoutTests/media/media-fullscreen-not-in-document-expected.txt (217175 => 217176)
--- trunk/LayoutTests/media/media-fullscreen-not-in-document-expected.txt 2017-05-20 00:25:01 UTC (rev 217175)
+++ trunk/LayoutTests/media/media-fullscreen-not-in-document-expected.txt 2017-05-20 00:27:33 UTC (rev 217176)
@@ -9,6 +9,7 @@
EVENT(canplaythrough)
* event handler NOT triggered by a user gesture
EXPECTED (mediaElement.webkitSupportsFullscreen == 'true') OK
+EXPECTED (mediaElement.webkitSupportsPresentationMode('fullscreen') == 'true') OK
EXPECTED (mediaElement.webkitDisplayingFullscreen == 'false') OK
TEST(mediaElement.webkitEnterFullScreen()) THROWS(DOMException.INVALID_STATE_ERR) OK
* clicking on button
@@ -26,6 +27,
[webkit-changes] [217175] trunk/Source/WebCore
Title: [217175] trunk/Source/WebCore
Revision 217175
Author commit-qu...@webkit.org
Date 2017-05-19 17:25:01 -0700 (Fri, 19 May 2017)
Log Message
Prevent _javascript_ interface from activating picture-in-picture for video elements that are showing capture camera on ios.
https://bugs.webkit.org/show_bug.cgi?id=172328
Patch by Jeremy Jones on 2017-05-19
Reviewed by Eric Carlson.
This change allows MediaPlayers to decide if they support pictureInPicture.
And check this from supportsFullscreen().
In MediaPlayerPrivateMediaStreamAVFObjC disable pip if there is a capture video track.
Elsewhere, leave it enabled.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::supportsFullscreen): Added Check.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsPictureInPicture): Added.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::supportsPictureInPicture): Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::supportsPictureInPicture): Added
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::supportsFullscreen): Deleted. Moved inline.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLVideoElement.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (217174 => 217175)
--- trunk/Source/WebCore/ChangeLog 2017-05-20 00:18:14 UTC (rev 217174)
+++ trunk/Source/WebCore/ChangeLog 2017-05-20 00:25:01 UTC (rev 217175)
@@ -1,3 +1,32 @@
+2017-05-19 Jeremy Jones
+
+Prevent _javascript_ interface from activating picture-in-picture for video elements that are showing capture camera on ios.
+https://bugs.webkit.org/show_bug.cgi?id=172328
+
+Reviewed by Eric Carlson.
+
+This change allows MediaPlayers to decide if they support pictureInPicture.
+And check this from supportsFullscreen().
+
+In MediaPlayerPrivateMediaStreamAVFObjC disable pip if there is a capture video track.
+Elsewhere, leave it enabled.
+
+* html/HTMLVideoElement.cpp:
+(WebCore::HTMLVideoElement::supportsFullscreen): Added Check.
+* platform/graphics/MediaPlayer.cpp:
+(WebCore::MediaPlayer::supportsPictureInPicture): Added.
+* platform/graphics/MediaPlayer.h:
+* platform/graphics/MediaPlayerPrivate.h:
+(WebCore::MediaPlayerPrivateInterface::supportsPictureInPicture): Added.
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::supportsPictureInPicture): Added
+* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+(WebCore::MediaPlayerPrivateQTKit::supportsFullscreen): Deleted. Moved inline.
+
2017-05-19 Chris Dumez
Do not fire load event for SVGElements that are detached or in frameless documents
Modified: trunk/Source/WebCore/html/HTMLVideoElement.cpp (217174 => 217175)
--- trunk/Source/WebCore/html/HTMLVideoElement.cpp 2017-05-20 00:18:14 UTC (rev 217174)
+++ trunk/Source/WebCore/html/HTMLVideoElement.cpp 2017-05-20 00:25:01 UTC (rev 217175)
@@ -153,14 +153,21 @@
bool HTMLVideoElement::supportsFullscreen(HTMLMediaElementEnums::VideoFullscreenMode videoFullscreenMode) const
{
-if (videoFullscreenMode == HTMLMediaElementEnums::VideoFullscreenModePictureInPicture && !mediaSession().allowsPictureInPicture(*this))
+if (!player())
return false;
+
+if (videoFullscreenMode == HTMLMediaElementEnums::VideoFullscreenModePictureInPicture) {
+if (!mediaSession().allowsPictureInPicture(*this))
+return false;
+if (!player()->supportsPictureInPicture())
+return false;
+}
Page* page = document().page();
if (!page)
[webkit-changes] [217174] trunk/LayoutTests
Title: [217174] trunk/LayoutTests Revision 217174 Author jlew...@apple.com Date 2017-05-19 17:18:14 -0700 (Fri, 19 May 2017) Log Message Marked webrtc/datachannel/filter-ice-candidate.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=171061 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: * platform/mac-wk1/TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (217173 => 217174) --- trunk/LayoutTests/ChangeLog 2017-05-20 00:03:24 UTC (rev 217173) +++ trunk/LayoutTests/ChangeLog 2017-05-20 00:18:14 UTC (rev 217174) @@ -1,3 +1,14 @@ +2017-05-19 Matt Lewis + +Marked webrtc/datachannel/filter-ice-candidate.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=171061 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: +* platform/mac-wk1/TestExpectations: +* platform/mac-wk2/TestExpectations: + 2017-05-19 Chris Dumez Do not fire load event for SVGElements that are detached or in frameless documents Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (217173 => 217174) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-05-20 00:03:24 UTC (rev 217173) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-05-20 00:18:14 UTC (rev 217174) @@ -1985,3 +1985,5 @@ webkit.org/b/171957 [ Debug ] fast/animation/request-animation-frame-time-unit.html [ Pass Failure ] webkit.org/b/172094 [ Debug ] imported/w3c/web-platform-tests/webrtc/interfaces.html [ Pass Crash ] + +webkit.org/b/171061 webrtc/datachannel/filter-ice-candidate.html [ Pass Timeout ] Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (217173 => 217174) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-05-20 00:03:24 UTC (rev 217173) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-05-20 00:18:14 UTC (rev 217174) @@ -377,3 +377,5 @@ webkit.org/b/171814 http/tests/media/hls/video-duration-accessibility.html [ Failure ] webkit.org/b/172241 http/tests/appcache/404-resource-with-slow-main-resource.php [ Pass Failure ] + +webkit.org/b/171061 webrtc/datachannel/filter-ice-candidate.html [ Pass Timeout ] Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (217173 => 217174) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-05-20 00:03:24 UTC (rev 217173) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-05-20 00:18:14 UTC (rev 217174) @@ -691,3 +691,5 @@ webkit.org/b/168937 [ Debug ] tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html [ Pass Failure ] webkit.org/b/172034 [ Sierra Release ] webrtc/closing-peerconnection.html [ Pass Timeout ] + +webkit.org/b/171061 webrtc/datachannel/filter-ice-candidate.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217173] trunk/Websites/perf.webkit.org
Title: [217173] trunk/Websites/perf.webkit.org Revision 217173 Author rn...@webkit.org Date 2017-05-19 17:03:24 -0700 (Fri, 19 May 2017) Log Message Add a commit log viewer next to the analysis results viewer https://bugs.webkit.org/show_bug.cgi?id=172399 Reviewed by Chris Dumez. Add a commit log viewer next to the analysis results viewer, which visualizes the A/B testing results. Also linkify the revisions in the table that shows the status of each A/B testing job, and allow the prefix of "r" when associating a Subversion revision. Finally, Fixed a bug that the list of commits associated with the analysis task were not re-rendered when the list was updated by the user. * public/v3/components/analysis-results-viewer.js: (AnalysisResultsViewer): Added _selectorRadioButtonList as an instance variable. It's a list of radio buttons to select a configuration (A/B) with a commit set. It's added to update the checked status of radio buttons upon changing the currently selected test group. (AnalysisResultsViewer.prototype.setTestGroups): Update the selected range to that of the currently selected group. (AnalysisResultsViewer.prototype.render): Fill _selectorRadioButtonList with radio buttons. * public/v3/components/commit-log-viewer.js: (CommitLogViewer): Added _showRepositoryName as an instance variable. (CommitLogViewer.prototype.setShowRepositoryName): Added. (CommitLogViewer.prototype.render): Hide the repository name when _showRepositoryName is false. This is used in the newly added commit log viewer for the analysis results since we're showing a select element with all the names of repositories above this component. * public/v3/components/test-group-revision-table.js: (TestGroupRevisionTable.prototype._buildCommitCell): Linkify the revisions if possible. * public/v3/models/analysis-task.js: (AnalysisTask.prototype.associateCommit): Strip "r" at the beginning for a Subversion like r12345 since that's the format we use to show to the user. This makes copy & paste easier. * public/v3/pages/analysis-task-page.js: (AnalysisTaskResultsPane): Added a bunch of new instance variables to show and update the commit log viewer next to the analysis results viewer. (AnalysisTaskResultsPane.prototype.setPoints): Create the list of repositories to show details. (AnalysisTaskResultsPane.prototype.didConstructShadowTree): Re-render when the current selected test group changes since that may have updated the selected range for A/B testing. Also re-render when a new repository is selected to show details. (AnalysisTaskResultsPane.prototype.render): Update the list of repositories and the commit log viewer. (AnalysisTaskResultsPane.prototype._renderRepositoryList): Renders the list of repositories. (AnalysisTaskResultsPane.prototype._updateCommitViewer): Updates the commit log viewer given the range selected in the analysis results viewer. (AnalysisTaskResultsPane.htmlTemplate): Updated the template. (AnalysisTaskResultsPane.cssTemplate): Ditto. (AnalysisTaskTestGroupPane.cssTemplate): Add a little space between the list of results and the table of A/B testing jobs with revisions. (AnalysisTaskPage.prototype.render): Fixed the bug that the list of commits associated with the task is not updated when the list changes the task or the start point never changed when the list of commits associated with the task changed. Make the lazily evaluated function compare the actual list of commits so that it will invoke _renderCauseAndFixes when the list changes. (AnalysisTaskPage.prototype._renderCauseAndFixes): Now renders a specific list. Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/public/v3/components/analysis-results-viewer.js trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js trunk/Websites/perf.webkit.org/public/v3/components/test-group-revision-table.js trunk/Websites/perf.webkit.org/public/v3/models/analysis-task.js trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (217172 => 217173) --- trunk/Websites/perf.webkit.org/ChangeLog 2017-05-20 00:00:58 UTC (rev 217172) +++ trunk/Websites/perf.webkit.org/ChangeLog 2017-05-20 00:03:24 UTC (rev 217173) @@ -1,3 +1,61 @@ +2017-05-19 Ryosuke Niwa + +Add a commit log viewer next to the analysis results viewer +https://bugs.webkit.org/show_bug.cgi?id=172399 + +Reviewed by Chris Dumez. + +Add a commit log viewer next to the analysis results viewer, which visualizes the A/B testing results. + +Also linkify the revisions in the table that shows the status of each A/B testing job, +and allow the prefix of "r" when associating a Subversion revision. + +Finally, Fixed a bug that the list of commits associated with the analysis task were not re-rendered +when the list was updated by the user. + +* public/v3/components/analysis-results-viewer.js: +(AnalysisR
[webkit-changes] [217172] trunk
Title: [217172] trunk Revision 217172 Author cdu...@apple.com Date 2017-05-19 17:00:58 -0700 (Fri, 19 May 2017) Log Message Do not fire load event for SVGElements that are detached or in frameless documents https://bugs.webkit.org/show_bug.cgi?id=172289 Reviewed by Ryosuke Niwa. Source/WebCore: We should not fire load event for SVGElements that are detached or in frameless documents. Test: svg/load-event-detached.html * svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible): LayoutTests: Add layout test coverage. * svg/load-event-detached-expected.txt: Added. * svg/load-event-detached.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/SVGElement.cpp Added Paths trunk/LayoutTests/svg/load-event-detached-expected.txt trunk/LayoutTests/svg/load-event-detached.html Diff Modified: trunk/LayoutTests/ChangeLog (217171 => 217172) --- trunk/LayoutTests/ChangeLog 2017-05-19 23:37:59 UTC (rev 217171) +++ trunk/LayoutTests/ChangeLog 2017-05-20 00:00:58 UTC (rev 217172) @@ -1,3 +1,16 @@ +2017-05-19 Chris Dumez + +Do not fire load event for SVGElements that are detached or in frameless documents +https://bugs.webkit.org/show_bug.cgi?id=172289 + + +Reviewed by Ryosuke Niwa. + +Add layout test coverage. + +* svg/load-event-detached-expected.txt: Added. +* svg/load-event-detached.html: Added. + 2017-05-19 Alexey Proskuryakov Many accessibility js-tests use waitUntilDone Added: trunk/LayoutTests/svg/load-event-detached-expected.txt (0 => 217172) --- trunk/LayoutTests/svg/load-event-detached-expected.txt (rev 0) +++ trunk/LayoutTests/svg/load-event-detached-expected.txt 2017-05-20 00:00:58 UTC (rev 217172) @@ -0,0 +1,3 @@ +Test that we do not fire the svg load event when the SVGElement is detached. + +This test passes if you see no alert. Added: trunk/LayoutTests/svg/load-event-detached.html (0 => 217172) --- trunk/LayoutTests/svg/load-event-detached.html (rev 0) +++ trunk/LayoutTests/svg/load-event-detached.html 2017-05-20 00:00:58 UTC (rev 217172) @@ -0,0 +1,30 @@ + + + +Test that we do not fire the svg load event when the SVGElement is detached. +This test passes if you see no alert. + +if (window.testRunner) +testRunner.dumpAsText(); + +const payloads = [ +'', +'
[webkit-changes] [217170] trunk/LayoutTests
Title: [217170] trunk/LayoutTests
Revision 217170
Author jlew...@apple.com
Date 2017-05-19 16:30:09 -0700 (Fri, 19 May 2017)
Log Message
Rebaselined js/dom/global-constructors-attributes.html after revision 217129
Unreviewed test gardening.
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (217169 => 217170)
--- trunk/LayoutTests/ChangeLog 2017-05-19 23:25:09 UTC (rev 217169)
+++ trunk/LayoutTests/ChangeLog 2017-05-19 23:30:09 UTC (rev 217170)
@@ -1,3 +1,12 @@
+2017-05-19 Matt Lewis
+
+Rebaselined js/dom/global-constructors-attributes.html after revision 217129
+
+
+Unreviewed test gardening.
+
+* platform/mac/js/dom/global-constructors-attributes-expected.txt:
+
2017-05-19 Chris Dumez
URLSearchParams / Headers objects @@iterator is not as per Web IDL spec
Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (217169 => 217170)
--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2017-05-19 23:25:09 UTC (rev 217169)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2017-05-19 23:30:09 UTC (rev 217170)
@@ -28,6 +28,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'AnimationTimeline').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationTimeline').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'AnimationTimeline').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ApplePaySession').value is ApplePaySession
+PASS Object.getOwnPropertyDescriptor(global, 'ApplePaySession').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplePaySession').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplePaySession').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ApplePaySession').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').value is ApplicationCache
PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'ApplicationCache').hasOwnProperty('set') is false
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217169] trunk
Title: [217169] trunk
Revision 217169
Author ryanhad...@apple.com
Date 2017-05-19 16:25:09 -0700 (Fri, 19 May 2017)
Log Message
Unreviewed, rolling out r217156.
This change broke the iOS build.
Reverted changeset:
"DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring
result registers."
https://bugs.webkit.org/show_bug.cgi?id=172383
http://trac.webkit.org/changeset/217156
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/dfg/DFGArrayifySlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGCallArrayAllocatorSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGCallCreateDirectArgumentsSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGSaneStringGetByValSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Removed Paths
trunk/JSTests/stress/regress-172383.js
Diff
Modified: trunk/JSTests/ChangeLog (217168 => 217169)
--- trunk/JSTests/ChangeLog 2017-05-19 23:20:08 UTC (rev 217168)
+++ trunk/JSTests/ChangeLog 2017-05-19 23:25:09 UTC (rev 217169)
@@ -1,3 +1,16 @@
+2017-05-19 Ryan Haddad
+
+Unreviewed, rolling out r217156.
+
+This change broke the iOS build.
+
+Reverted changeset:
+
+"DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring
+result registers."
+https://bugs.webkit.org/show_bug.cgi?id=172383
+http://trac.webkit.org/changeset/217156
+
2017-05-19 Mark Lam
Add missing exception check.
Deleted: trunk/JSTests/stress/regress-172383.js (217168 => 217169)
--- trunk/JSTests/stress/regress-172383.js 2017-05-19 23:20:08 UTC (rev 217168)
+++ trunk/JSTests/stress/regress-172383.js 2017-05-19 23:25:09 UTC (rev 217169)
@@ -1,40 +0,0 @@
-// This test should not crash.
-
-let x = undefined;
-
-function foo(w, a0, a1) {
-var r0 = x % a0;
-var r1 = w ^ a1;
-
-var r4 = 3 % 7;
-
-var r6 = w ^ 0;
-var r7 = r4 / r4;
-var r9 = x - r7;
-a1 = 0 + r0;
-
-var r11 = 0 & a0;
-var r12 = r4 * a1;
-var r7 = r11 & a0;
-
-var r15 = r11 | r4;
-var r16 = 0 & r1;
-var r20 = 5 * a0;
-
-var r2 = 0 + r9;
-var r26 = r11 | r15;
-var r29 = r16 + 0;
-var r29 = r28 * r1;
-var r34 = w / r12;
-
-var r28 = 0 / r7;
-var r64 = r20 + 0;
-var r65 = 0 + r6;
-
-return a1;
-}
-noInline(foo);
-
-for (var i = 0; i < 1886; i++)
-foo("q");
-
Modified: trunk/Source/_javascript_Core/ChangeLog (217168 => 217169)
--- trunk/Source/_javascript_Core/ChangeLog 2017-05-19 23:20:08 UTC (rev 217168)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-05-19 23:25:09 UTC (rev 217169)
@@ -1,3 +1,16 @@
+2017-05-19 Ryan Haddad
+
+Unreviewed, rolling out r217156.
+
+This change broke the iOS build.
+
+Reverted changeset:
+
+"DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring
+result registers."
+https://bugs.webkit.org/show_bug.cgi?id=172383
+http://trac.webkit.org/changeset/217156
+
2017-05-19 Mark Lam
Add missing exception check.
Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (217168 => 217169)
--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2017-05-19 23:20:08 UTC (rev 217168)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2017-05-19 23:25:09 UTC (rev 217169)
@@ -1328,20 +1328,6 @@
move(imm.asTrustedImm64(), dest);
}
-#if CPU(X86_64)
-void moveDouble(Imm64 imm, FPRegisterID dest)
-{
-move(imm, scratchRegister());
-move64ToDouble(scratchRegister(), dest);
-}
-#elif CPU(ARM64)
-void moveDouble(Imm64 imm, FPRegisterID dest)
-{
-move(imm, dataMemoryTempRegister());
-move64ToDouble(dataMemoryTempRegister(), dest);
-}
-#endif
-
void and64(Imm32 imm, RegisterID dest)
{
if (shouldBlind(imm)) {
Modified: trunk/Source/_javascript_Core/dfg/DFGArrayifySlowPathGenerator.h (217168 => 217169)
--- trunk/Source/_javascript_Core/dfg/DFGArrayifySlowPathGenerator.h 2017-05-19 23:20:08 UTC (rev 217168)
+++ trunk/Source/_javascript_Core/dfg/DFGArrayifySlowPathGenerator.h 2017-05-19 23:25:09 UTC (rev 217169)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -111,7 +111,7 @@
break;
}
for (unsigned i = m_plans.size(); i--;)
-jit->silentFill(m_plans[i]);
+jit->silentFill(m_plans[i], GPRInfo::regT0);
[webkit-changes] [217168] trunk
Title: [217168] trunk Revision 217168 Author cdu...@apple.com Date 2017-05-19 16:20:08 -0700 (Fri, 19 May 2017) Log Message Option() named constructor is not per spec https://bugs.webkit.org/show_bug.cgi?id=172185 Reviewed by Sam Weinig. LayoutTests/imported/w3c: Import test coverage from upstream web-platform-tests at 8b69df3a68. * web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor-expected.txt: Added. * web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor.html: Added. * web-platform-tests/html/semantics/forms/the-option-element/option-index-expected.txt: Added. * web-platform-tests/html/semantics/forms/the-option-element/option-index.html: Added. * web-platform-tests/html/semantics/forms/the-option-element/w3c-import.log: Source/WebCore: Align the behavior of the Option() named constructor with the HTML specification: - https://html.spec.whatwg.org/#dom-option In particular, we no longer create an empty Text child node if the input text is the empty string. This also aligns our behavior with Firefox. Test: imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor.html * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::createForJSConstructor): * html/HTMLOptionElement.h: * html/HTMLOptionElement.idl: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/w3c-import.log trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLOptionElement.cpp trunk/Source/WebCore/html/HTMLOptionElement.h trunk/Source/WebCore/html/HTMLOptionElement.idl Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor.html trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-index-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-index.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (217167 => 217168) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-05-19 23:14:53 UTC (rev 217167) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-05-19 23:20:08 UTC (rev 217168) @@ -1,5 +1,20 @@ 2017-05-19 Chris Dumez +Option() named constructor is not per spec +https://bugs.webkit.org/show_bug.cgi?id=172185 + +Reviewed by Sam Weinig. + +Import test coverage from upstream web-platform-tests at 8b69df3a68. + +* web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor-expected.txt: Added. +* web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor.html: Added. +* web-platform-tests/html/semantics/forms/the-option-element/option-index-expected.txt: Added. +* web-platform-tests/html/semantics/forms/the-option-element/option-index.html: Added. +* web-platform-tests/html/semantics/forms/the-option-element/w3c-import.log: + +2017-05-19 Chris Dumez + URLSearchParams / Headers objects @@iterator is not as per Web IDL spec https://bugs.webkit.org/show_bug.cgi?id=172218 Added: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor-expected.txt (0 => 217168) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor-expected.txt 2017-05-19 23:20:08 UTC (rev 217168) @@ -0,0 +1,11 @@ + +PASS Option constructor with no arguments +PASS Option constructor with falsy arguments +PASS Option constructor creates HTMLOptionElement with specified text and value +PASS Option constructor handles selectedness correctly when specified with defaultSelected only +PASS Option constructor handles selectedness correctly, even when incongruous with defaultSelected +PASS Option constructor treats undefined text and value correctly +PASS Option constructor treats falsy selected and defaultSelected correctly +PASS Option constructor treats truthy selected and defaultSelected correctly +PASS Option constructor does not set dirtiness (so, manipulating the selected content attribute still updates the selected IDL attribute) + Added: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor.html (0 => 217168) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor.html (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/sem
[webkit-changes] [217167] trunk/Tools
Title: [217167] trunk/Tools
Revision 217167
Author simon.fra...@apple.com
Date 2017-05-19 16:14:53 -0700 (Fri, 19 May 2017)
Log Message
Fix dump-class-layout to handle different file architectures
https://bugs.webkit.org/show_bug.cgi?id=172392
Reviewed by Zalan Bujtas.
Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
and use the first architecture reported. Also add a "--architecture" argument
to allow the user to specify an architecture.
* Scripts/dump-class-layout:
(import_lldb):
(verify_type_recursive):
(get_first_file_architecture):
(dump_class):
(main):
(find_build_directory): Deleted.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/dump-class-layout
Diff
Modified: trunk/Tools/ChangeLog (217166 => 217167)
--- trunk/Tools/ChangeLog 2017-05-19 23:07:40 UTC (rev 217166)
+++ trunk/Tools/ChangeLog 2017-05-19 23:14:53 UTC (rev 217167)
@@ -1,3 +1,22 @@
+2017-05-19 Simon Fraser
+
+Fix dump-class-layout to handle different file architectures
+https://bugs.webkit.org/show_bug.cgi?id=172392
+
+Reviewed by Zalan Bujtas.
+
+Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
+and use the first architecture reported. Also add a "--architecture" argument
+to allow the user to specify an architecture.
+
+* Scripts/dump-class-layout:
+(import_lldb):
+(verify_type_recursive):
+(get_first_file_architecture):
+(dump_class):
+(main):
+(find_build_directory): Deleted.
+
2017-05-19 Jonathan Bedard
Unreviewed infrastructure fix.
Modified: trunk/Tools/Scripts/dump-class-layout (217166 => 217167)
--- trunk/Tools/Scripts/dump-class-layout 2017-05-19 23:07:40 UTC (rev 217166)
+++ trunk/Tools/Scripts/dump-class-layout 2017-05-19 23:14:53 UTC (rev 217167)
@@ -23,6 +23,7 @@
# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
# THE POSSIBILITY OF SUCH DAMAGE.
+import re
import sys
import getopt
import argparse
@@ -33,6 +34,7 @@
framework = "WebCore"
build_directory = ""
config = "Release"
+arch = None
def webkit_build_dir():
scriptpath = os.path.dirname(os.path.realpath(__file__))
@@ -53,10 +55,6 @@
print "Failed to import {} from {}".format(LLDB_MODULE_NAME, lldb_framework_path)
sys.exit(1)
-def find_build_directory():
-return
-
-
def verify_type(target, type):
typename = type.GetName()
(end_offset, padding) = verify_type_recursive(target, type, None, 0, 0, 0)
@@ -122,22 +120,42 @@
return (prev_end_offset, padding)
-def dump_class(framework, classname):
+def get_first_file_architecture(framework_path):
+p = re.compile('shared library +(\w+)$')
+file_result = subprocess.check_output(["file", framework_path]).split('\n')
+arches = []
+for line in file_result:
+match = p.search(line)
+if match:
+arches.append(match.group(1));
+
+if len(arches) > 1:
+print 'Found architectures %s, using %s' % (arches, arches[0])
+
+if len(arches) > 0:
+return arches[0]
+
+return lldb.LLDB_ARCH_DEFAULT
+
+def dump_class(framework_path, classname, architecture):
debugger = lldb.SBDebugger.Create()
-debugger.SetAsync (False)
-target = debugger.CreateTargetWithFileAndArch(framework, lldb.LLDB_ARCH_DEFAULT)
+debugger.SetAsync(False)
+if not architecture:
+architecture = get_first_file_architecture(framework_path)
+
+target = debugger.CreateTargetWithFileAndArch(framework_path, architecture)
if not target:
-print "Failed to make target for " + framework;
+print "Failed to make target for " + framework_path;
sys.exit(1)
module = target.GetModuleAtIndex(0)
if not module:
-print "Failed to get first module in " + framework;
+print "Failed to get first module in " + framework_path;
sys.exit(1)
types = module.FindTypes(classname)
if types.GetSize():
-print 'Found %u types matching "%s" in "%s"' % (len(types), classname, module.file)
+print 'Found %u types matching "%s" in "%s" for %s' % (len(types), classname, module.file, architecture)
for type in types:
verify_type(target, type)
else:
@@ -158,6 +176,9 @@
parser.add_argument('-c', '--configuration', dest='config', action='',
help='Configuration (Debug or Release)')
+parser.add_argument('-a', '--architecture', dest='arch', action='',
+help='Architecture (i386, x86_64, armv7, armv7s, arm64). Uses the first architecture listed by \'file\' by default')
+
args = parser.parse_args()
build_dir = webkit_build_dir()
@@ -169,7 +190,7 @@
target_path = os.path.join(build_dir, args.config, args.framework + ".framework", args.framework);
import_lldb()
-dump_class(target_path, args.classname)
+dump_class(target_path, args.classname, args.arch)
if __name
[webkit-changes] [217166] trunk
Title: [217166] trunk
Revision 217166
Author cdu...@apple.com
Date 2017-05-19 16:07:40 -0700 (Fri, 19 May 2017)
Log Message
URLSearchParams / Headers objects @@iterator is not as per Web IDL spec
https://bugs.webkit.org/show_bug.cgi?id=172218
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Rebaseline web-platform-tests that are now passing.
* web-platform-tests/fetch/api/headers/headers-idl-expected.txt:
* web-platform-tests/url/interfaces.any-expected.txt:
* web-platform-tests/url/interfaces.any.worker-expected.txt:
Source/WebCore:
Both URLSearchParams and Headers interfaces are iterable as per their
respective specification, and they both have a pair iterator:
- https://url.spec.whatwg.org/#interface-urlsearchparams
- https://fetch.spec.whatwg.org/#headers-class
As per the WebIDL specification for 'entries'[1], "If the interface has a pair
iterator, then the Function object is the value of the @@iterator property",
the value of @@iterator being defined at [2]. In WebKit, we were using
different values/functions for 'entries' and @@iterator, although those
functions were doing the same thing (and the right thing).
Also, as per [2], the name of the @@iterator function should be "entries",
which I also implemented in this patch. Previously, we were using
"[Symbol.Iterator]" as function name.
[1] https://heycam.github.io/webidl/#es-iterable-entries
[2] https://heycam.github.io/webidl/#es-iterator
No new tests, rebaselined existing tests.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateImplementationIterableFunctions):
* bindings/scripts/test/JS/JSMapLike.cpp:
* bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
* bindings/scripts/test/JS/JSTestIterable.cpp:
(WebCore::JSTestIterablePrototype::finishCreation):
(WebCore::jsTestIterablePrototypeFunctionEntriesCaller):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodePrototype::finishCreation):
(WebCore::jsTestNodePrototypeFunctionEntriesCaller):
LayoutTests:
* fast/text/font-face-set-_javascript_-expected.txt:
* fast/text/font-face-set-_javascript_.html:
Fix FontFaceSet test which wrong expected FontFaceSet's entries() to return
a pair iterator. It does not make sense to return a pair iterator here given
that this is not a key-value structure. FontFaceSet should not even have an
entries() method but this is an artifact of us using iterable instead of
setlike until we support setlike<> (Bug 159140).
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt
trunk/LayoutTests/fast/text/font-face-set-_javascript_.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-idl-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/interfaces.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/interfaces.any.worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSMapLike.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSReadOnlyMapLike.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestIterable.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (217165 => 217166)
--- trunk/LayoutTests/ChangeLog 2017-05-19 23:02:27 UTC (rev 217165)
+++ trunk/LayoutTests/ChangeLog 2017-05-19 23:07:40 UTC (rev 217166)
@@ -1,3 +1,18 @@
+2017-05-19 Chris Dumez
+
+URLSearchParams / Headers objects @@iterator is not as per Web IDL spec
+https://bugs.webkit.org/show_bug.cgi?id=172218
+
+Reviewed by Youenn Fablet.
+
+* fast/text/font-face-set-_javascript_-expected.txt:
+* fast/text/font-face-set-_javascript_.html:
+Fix FontFaceSet test which wrong expected FontFaceSet's entries() to return
+a pair iterator. It does not make sense to return a pair iterator here given
+that this is not a key-value structure. FontFaceSet should not even have an
+entries() method but this is an artifact of us using iterable instead of
+setlike until we support setlike<> (Bug 159140).
+
2017-05-19 Zalan Bujtas
Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox::parent().
Modified: trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt (217165 => 217166)
--- trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt 2017-05-19 23:02:27 UTC (rev 217165)
+++ trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt 2017-05-19 23:07:40 UTC (rev 217166)
@@ -10,9 +10,7 @@
PASS x = { [Symbol.iterator]: function*() { yield fontFace1; throw {name: 'SomeError', toString: () => 'Some error'}; } }; new FontFaceSet(x) threw exception Some error.
PASS fontFaceSet.status is "loaded"
PASS item.done is false
-PASS item.value.length is 2
-PASS item.value[0] is fontFace1
-PASS item.value[1] is font
[webkit-changes] [217165] trunk/Tools
Title: [217165] trunk/Tools
Revision 217165
Author jbed...@apple.com
Date 2017-05-19 16:02:27 -0700 (Fri, 19 May 2017)
Log Message
Unreviewed infrastructure fix.
* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios_simulator.py
Diff
Modified: trunk/Tools/ChangeLog (217164 => 217165)
--- trunk/Tools/ChangeLog 2017-05-19 22:54:06 UTC (rev 217164)
+++ trunk/Tools/ChangeLog 2017-05-19 23:02:27 UTC (rev 217165)
@@ -1,5 +1,12 @@
2017-05-19 Jonathan Bedard
+Unreviewed infrastructure fix.
+
+* Scripts/webkitpy/port/ios_simulator.py:
+(IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
+
+2017-05-19 Jonathan Bedard
+
webkitpy: Use simctl boot to run multiple simulators at once
https://bugs.webkit.org/show_bug.cgi?id=172374
Modified: trunk/Tools/Scripts/webkitpy/port/ios_simulator.py (217164 => 217165)
--- trunk/Tools/Scripts/webkitpy/port/ios_simulator.py 2017-05-19 22:54:06 UTC (rev 217164)
+++ trunk/Tools/Scripts/webkitpy/port/ios_simulator.py 2017-05-19 23:02:27 UTC (rev 217165)
@@ -227,7 +227,7 @@
time.sleep(2.5)
if not self.use_multiple_simulator_apps():
-self._executive.run_command(['open', '-g', '-b', self.SIMULATOR_BUNDLE_ID])
+self._executive.run_command(['open', '-g', '-b', self.SIMULATOR_BUNDLE_ID], return_exit_code=True)
_log.info('Waiting for all iOS Simulators to finish booting.')
for i in xrange(self.child_processes()):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217164] trunk
Title: [217164] trunk
Revision 217164
Author za...@apple.com
Date 2017-05-19 15:54:06 -0700 (Fri, 19 May 2017)
Log Message
Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox::parent().
https://bugs.webkit.org/show_bug.cgi?id=172309
Reviewed by Simon Fraser.
Source/WebCore:
This patch stops the redundant ellipsis box trigger ASSERT_WITH_SECURITY_IMPLICATION.
In RootInlineBox::placeEllipsis we construct an ellipsis box and append it to a static HashMap which
keeps track of the ellipsis boxes on each line. However when the line already has an ellipsis, we
re-use the existing one and this newly constructed (but redundant) box gets destroyed as we return from this function.
In InlineBox's d'tor, we let the parent know that now it has a dangling child and we assert on it
later, while accessing the children list. However this redundant ellipsis box was never added to the line,
so the assertion hits incorrectly.
Test: fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::EllipsisBox):
* rendering/InlineBox.cpp: This needs 32bits padding.
(WebCore::InlineBox::invalidateParentChildList):
* rendering/InlineBox.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::placeEllipsis):
LayoutTests:
* fast/inline/redundant-ellipsis-triggers-assert-incorrectly-expected.txt: Added.
* fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/EllipsisBox.cpp
trunk/Source/WebCore/rendering/InlineBox.cpp
trunk/Source/WebCore/rendering/InlineBox.h
trunk/Source/WebCore/rendering/RootInlineBox.cpp
Added Paths
trunk/LayoutTests/fast/inline/redundant-ellipsis-triggers-assert-incorrectly-expected.txt
trunk/LayoutTests/fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html
Diff
Modified: trunk/LayoutTests/ChangeLog (217163 => 217164)
--- trunk/LayoutTests/ChangeLog 2017-05-19 22:51:55 UTC (rev 217163)
+++ trunk/LayoutTests/ChangeLog 2017-05-19 22:54:06 UTC (rev 217164)
@@ -1,3 +1,14 @@
+2017-05-19 Zalan Bujtas
+
+Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox::parent().
+https://bugs.webkit.org/show_bug.cgi?id=172309
+
+
+Reviewed by Simon Fraser.
+
+* fast/inline/redundant-ellipsis-triggers-assert-incorrectly-expected.txt: Added.
+* fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html: Added.
+
2017-05-19 Ryan Haddad
LayoutTest js/Promise-types.html is a flaky failure
Added: trunk/LayoutTests/fast/inline/redundant-ellipsis-triggers-assert-incorrectly-expected.txt (0 => 217164)
--- trunk/LayoutTests/fast/inline/redundant-ellipsis-triggers-assert-incorrectly-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/inline/redundant-ellipsis-triggers-assert-incorrectly-expected.txt 2017-05-19 22:54:06 UTC (rev 217164)
@@ -0,0 +1,2 @@
+PASS if no assert or crash.
+foobaar foobarfoobarfo foobar
Added: trunk/LayoutTests/fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html (0 => 217164)
--- trunk/LayoutTests/fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html (rev 0)
+++ trunk/LayoutTests/fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html 2017-05-19 22:54:06 UTC (rev 217164)
@@ -0,0 +1,29 @@
+
+
+
+This tests that we don't trigger assert incorrectly for ellipsis boxes
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+@font-face{
+font-family:"Market Sans"; src:url('');
+}
+
+div {
+display: -webkit-box;
+overflow: hidden;
+text-overflow: ellipsis;
+-webkit-line-clamp: 2;
+-webkit-box-orient: vertical;
+font-family: "Market Sans";
+max-width: 224px;
+}
+
+
+
+PASS if no assert or crash.
+foobaar foobarfoobarfo foobar
+
+
Modified: trunk/Source/WebCore/ChangeLog (217163 => 217164)
--- trunk/Source/WebCore/ChangeLog 2017-05-19 22:51:55 UTC (rev 217163)
+++ trunk/Source/WebCore/ChangeLog 2017-05-19 22:54:06 UTC (rev 217164)
@@ -1,3 +1,30 @@
+2017-05-19 Zalan Bujtas
+
+Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox::parent().
+https://bugs.webkit.org/show_bug.cgi?id=172309
+
+
+Reviewed by Simon Fraser.
+
+This patch stops the redundant ellipsis box trigger ASSERT_WITH_SECURITY_IMPLICATION.
+
+In RootInlineBox::placeEllipsis we construct an ellipsis box and append it to a static HashMap which
+keeps track of the ellipsis boxes on each line. However when the line already has an ellipsis, we
+re-use the existing one and this newly constructed (but redundant) box gets destroyed as we return from this function.
+In InlineBox's d'tor, we let the parent know that now it has a dangling child and we assert on it
+later, while accessing the children list. However
[webkit-changes] [217162] branches/safari-603-branch/Source/WebCore
Title: [217162] branches/safari-603-branch/Source/WebCore
Revision 217162
Author jmarc...@apple.com
Date 2017-05-19 15:51:52 -0700 (Fri, 19 May 2017)
Log Message
Build Fix: Disabling WritableStream and ReadableByteStream.
Grizzly: Outdated WritableStream API shipped in Safari 10.1
Patch by Youenn Fablet on 2017-05-19
* Modules/streams/ReadableStream.js:
(initializeReadableStream): Throwing in case the source type is bytes.
* Modules/streams/WritableStream.idl: Making it dependent on writable stream API flag.
Modified Paths
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStream.js
branches/safari-603-branch/Source/WebCore/Modules/streams/WritableStream.idl
Diff
Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (217161 => 217162)
--- branches/safari-603-branch/Source/WebCore/ChangeLog 2017-05-19 22:42:43 UTC (rev 217161)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog 2017-05-19 22:51:52 UTC (rev 217162)
@@ -1,3 +1,11 @@
+2017-05-19 Youenn Fablet
+
+Disabling WritableStream and ReadableByteStream.
+
+* Modules/streams/ReadableStream.js:
+(initializeReadableStream): Throwing in case the source type is bytes.
+* Modules/streams/WritableStream.idl: Making it dependent on writable stream API flag.
+
2017-05-17 Jason Marcell
Cherry-pick r216726. rdar://problem/31971324
Modified: branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStream.js (217161 => 217162)
--- branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStream.js 2017-05-19 22:42:43 UTC (rev 217161)
+++ branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStream.js 2017-05-19 22:51:52 UTC (rev 217162)
@@ -52,17 +52,7 @@
const typeString = @String(type);
if (typeString === "bytes") {
-if (strategy.highWaterMark === @undefined)
-strategy.highWaterMark = 0;
-// FIXME: When ReadableByteStreamController is no more dependent on a compile flag, specific error handling can be removed.
-// Constructor is not necessarily available if the byteStream part of Readeable Stream API is not activated. Therefore, a
-// specific handling of error is done.
-try {
-let readableByteStreamControllerConstructor = @ReadableByteStreamController;
-} catch (e) {
-@throwTypeError("ReadableByteStreamController is not implemented");
-}
-this.@readableStreamController = new @ReadableByteStreamController(this, underlyingSource, strategy.highWaterMark);
+@throwTypeError("ReadableByteStreamController is not implemented");
} else if (type === @undefined) {
if (strategy.highWaterMark === @undefined)
strategy.highWaterMark = 1;
Modified: branches/safari-603-branch/Source/WebCore/Modules/streams/WritableStream.idl (217161 => 217162)
--- branches/safari-603-branch/Source/WebCore/Modules/streams/WritableStream.idl 2017-05-19 22:42:43 UTC (rev 217161)
+++ branches/safari-603-branch/Source/WebCore/Modules/streams/WritableStream.idl 2017-05-19 22:51:52 UTC (rev 217162)
@@ -30,6 +30,7 @@
[
Conditional=STREAMS_API,
Constructor,
+EnabledAtRuntime=WritableStreamAPI,
JSBuiltin
] interface WritableStream {
Promise abort(optional any reason);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217163] branches/safari-603-branch/Source/WebCore
Title: [217163] branches/safari-603-branch/Source/WebCore
Revision 217163
Author jmarc...@apple.com
Date 2017-05-19 15:51:55 -0700 (Fri, 19 May 2017)
Log Message
Cherry-pick r215091. rdar://problem/32279160
Modified Paths
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/platform/graphics/ImageFrameCache.cpp
Diff
Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (217162 => 217163)
--- branches/safari-603-branch/Source/WebCore/ChangeLog 2017-05-19 22:51:52 UTC (rev 217162)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog 2017-05-19 22:51:55 UTC (rev 217163)
@@ -1,3 +1,22 @@
+2017-05-19 Jason Marcell
+
+Cherry-pick r215091. rdar://problem/32279160
+
+2017-04-07 Miguel Gomez
+
+[GTK+] Animations not played properly when using synchronous decoding
+https://bugs.webkit.org/show_bug.cgi?id=170591
+
+Reviewed by Carlos Garcia Campos.
+
+Fix an index error when destroying decoded frames that was sometimes deleting the frame we wanted
+to keep.
+
+Covered by exitent tests.
+
+* platform/graphics/ImageFrameCache.cpp:
+(WebCore::ImageFrameCache::destroyDecodedData):
+
2017-05-19 Youenn Fablet
Disabling WritableStream and ReadableByteStream.
Modified: branches/safari-603-branch/Source/WebCore/platform/graphics/ImageFrameCache.cpp (217162 => 217163)
--- branches/safari-603-branch/Source/WebCore/platform/graphics/ImageFrameCache.cpp 2017-05-19 22:51:52 UTC (rev 217162)
+++ branches/safari-603-branch/Source/WebCore/platform/graphics/ImageFrameCache.cpp 2017-05-19 22:51:55 UTC (rev 217163)
@@ -96,7 +96,7 @@
for (size_t index = 0; index < frameCount; ++index) {
if (index == excludeFrame)
continue;
-decodedSize += m_frames[index++].clearImage();
+decodedSize += m_frames[index].clearImage();
}
decodedSizeReset(decodedSize);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217161] trunk
Title: [217161] trunk
Revision 217161
Author rn...@webkit.org
Date 2017-05-19 15:42:43 -0700 (Fri, 19 May 2017)
Log Message
REGRESSION(r217118): Speedometer 2.0: Flight.js test is broken
https://bugs.webkit.org/show_bug.cgi?id=172394
Reviewed by Chris Dumez.
PerformanceTests:
Fixed the bug that we were never clearing window.checkLoadedTimeoutId.
* Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:
(newContext.checkLoaded):
Websites/browserbench.org:
Merge the fix.
* Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:
(newContext.checkLoaded):
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js
trunk/Websites/browserbench.org/ChangeLog
trunk/Websites/browserbench.org/Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (217160 => 217161)
--- trunk/PerformanceTests/ChangeLog 2017-05-19 22:38:06 UTC (rev 217160)
+++ trunk/PerformanceTests/ChangeLog 2017-05-19 22:42:43 UTC (rev 217161)
@@ -1,3 +1,15 @@
+2017-05-19 Ryosuke Niwa
+
+REGRESSION(r217118): Speedometer 2.0: Flight.js test is broken
+https://bugs.webkit.org/show_bug.cgi?id=172394
+
+Reviewed by Chris Dumez.
+
+Fixed the bug that we were never clearing window.checkLoadedTimeoutId.
+
+* Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:
+(newContext.checkLoaded):
+
2017-05-19 Yusuke Suzuki
Add SixSpeed benchmark to PerformanceTests
Modified: trunk/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js (217160 => 217161)
--- trunk/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js 2017-05-19 22:38:06 UTC (rev 217160)
+++ trunk/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js 2017-05-19 22:42:43 UTC (rev 217161)
@@ -716,6 +716,7 @@
if ((isBrowser || isWebWorker) && !checkLoadedTimeoutId) {
checkLoadedTimeoutId = setTimeout(function () {
checkLoadedTimeoutId = 0;
+window.checkLoadedTimeoutId = 0;
checkLoaded();
}, 50);
window.checkLoadedTimeoutId = checkLoadedTimeoutId;
Modified: trunk/Websites/browserbench.org/ChangeLog (217160 => 217161)
--- trunk/Websites/browserbench.org/ChangeLog 2017-05-19 22:38:06 UTC (rev 217160)
+++ trunk/Websites/browserbench.org/ChangeLog 2017-05-19 22:42:43 UTC (rev 217161)
@@ -1,5 +1,17 @@
2017-05-19 Ryosuke Niwa
+REGRESSION(r217118): Speedometer 2.0: Flight.js test is broken
+https://bugs.webkit.org/show_bug.cgi?id=172394
+
+Reviewed by Chris Dumez.
+
+Merge the fix.
+
+* Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:
+(newContext.checkLoaded):
+
+2017-05-19 Ryosuke Niwa
+
Merge Speedometer 2.0 fixes up to r217121 to browserbench.org
https://bugs.webkit.org/show_bug.cgi?id=172389
Modified: trunk/Websites/browserbench.org/Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js (217160 => 217161)
--- trunk/Websites/browserbench.org/Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js 2017-05-19 22:38:06 UTC (rev 217160)
+++ trunk/Websites/browserbench.org/Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js 2017-05-19 22:42:43 UTC (rev 217161)
@@ -716,6 +716,7 @@
if ((isBrowser || isWebWorker) && !checkLoadedTimeoutId) {
checkLoadedTimeoutId = setTimeout(function () {
checkLoadedTimeoutId = 0;
+window.checkLoadedTimeoutId = 0;
checkLoaded();
}, 50);
window.checkLoadedTimeoutId = checkLoadedTimeoutId;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217160] branches/safari-604.1.21-branch/Source
Title: [217160] branches/safari-604.1.21-branch/Source Revision 217160 Author jmarc...@apple.com Date 2017-05-19 15:38:06 -0700 (Fri, 19 May 2017) Log Message Versioning. Modified Paths branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig (217159 => 217160) --- branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2017-05-19 22:36:21 UTC (rev 217159) +++ branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2017-05-19 22:38:06 UTC (rev 217160) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (217159 => 217160) --- branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-05-19 22:36:21 UTC (rev 217159) +++ branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-05-19 22:38:06 UTC (rev 217160) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig (217159 => 217160) --- branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig 2017-05-19 22:36:21 UTC (rev 217159) +++ branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig 2017-05-19 22:38:06 UTC (rev 217160) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (217159 => 217160) --- branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-05-19 22:36:21 UTC (rev 217159) +++ branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-05-19 22:38:06 UTC (rev 217160) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (217159 => 217160) --- branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-05-19 22:36:21 UTC (rev 217159) +++ branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-05-19 22:38:06 UTC (rev 217160) @@ -1,7 +1,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig (217159 => 217160) --- branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2017-05-19 22:36:21 UTC (rev 217159) +++ branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2017-05-19 22:38:06 UTC (rev 217160) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig (217159 => 217160) --- branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig 2017-05-19 22:36:21 UTC (rev 217159) +++ branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig 2017-05-19 22:38:06 UTC (rev 217160) @@ -24,7 +24,7 @@ MAJOR_VERSION = 604; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-chang
[webkit-changes] [217159] tags/Safari-604.1.21.7/
Title: [217159] tags/Safari-604.1.21.7/ Revision 217159 Author jmarc...@apple.com Date 2017-05-19 15:36:21 -0700 (Fri, 19 May 2017) Log Message Tag Safari-604.1.21.7. Added Paths tags/Safari-604.1.21.7/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217158] trunk/Source/WebKit2
Title: [217158] trunk/Source/WebKit2
Revision 217158
Author wilan...@apple.com
Date 2017-05-19 15:31:16 -0700 (Fri, 19 May 2017)
Log Message
Resource Load Statistics: Use WebProcessPool::allProcessPools() when sending message to network process about partitioning
https://bugs.webkit.org/show_bug.cgi?id=172370
Reviewed by Alex Christensen.
The existing test case
http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html
is currently failing and should start passing again with this patch.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (217157 => 217158)
--- trunk/Source/WebKit2/ChangeLog 2017-05-19 22:28:10 UTC (rev 217157)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-19 22:31:16 UTC (rev 217158)
@@ -1,3 +1,18 @@
+2017-05-19 John Wilander
+
+Resource Load Statistics: Use WebProcessPool::allProcessPools() when sending message to network process about partitioning
+https://bugs.webkit.org/show_bug.cgi?id=172370
+
+
+Reviewed by Alex Christensen.
+
+The existing test case
+http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html
+is currently failing and should start passing again with this patch.
+
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains):
+
2017-05-19 Chris Dumez
[WK2] Notify client when a process exceeds background CPU limit while in the foreground
Modified: trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp (217157 => 217158)
--- trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp 2017-05-19 22:28:10 UTC (rev 217157)
+++ trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp 2017-05-19 22:31:16 UTC (rev 217158)
@@ -1076,7 +1076,7 @@
#if HAVE(CFNETWORK_STORAGE_PARTITIONING)
void WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains(const Vector& domainsToRemove, const Vector& domainsToAdd, bool clearFirst)
{
-for (auto& processPool : processPools())
+for (auto& processPool : WebProcessPool::allProcessPools())
processPool->sendToNetworkingProcess(Messages::NetworkProcess::ShouldPartitionCookiesForTopPrivatelyOwnedDomains(domainsToRemove, domainsToAdd, clearFirst));
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217157] trunk
Title: [217157] trunk
Revision 217157
Author mark@apple.com
Date 2017-05-19 15:28:10 -0700 (Fri, 19 May 2017)
Log Message
Add missing exception check.
https://bugs.webkit.org/show_bug.cgi?id=172346
Reviewed by Geoffrey Garen.
JSTests:
* stress/regress-172346.js: Added.
Source/_javascript_Core:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.cpp
Added Paths
trunk/JSTests/stress/regress-172346.js
Diff
Modified: trunk/JSTests/ChangeLog (217156 => 217157)
--- trunk/JSTests/ChangeLog 2017-05-19 22:25:16 UTC (rev 217156)
+++ trunk/JSTests/ChangeLog 2017-05-19 22:28:10 UTC (rev 217157)
@@ -1,5 +1,15 @@
2017-05-19 Mark Lam
+Add missing exception check.
+https://bugs.webkit.org/show_bug.cgi?id=172346
+
+
+Reviewed by Geoffrey Garen.
+
+* stress/regress-172346.js: Added.
+
+2017-05-19 Mark Lam
+
DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring result registers.
https://bugs.webkit.org/show_bug.cgi?id=172383
Added: trunk/JSTests/stress/regress-172346.js (0 => 217157)
--- trunk/JSTests/stress/regress-172346.js (rev 0)
+++ trunk/JSTests/stress/regress-172346.js 2017-05-19 22:28:10 UTC (rev 217157)
@@ -0,0 +1,16 @@
+function test(){
+var get = [];
+var p = new Proxy(Function(), { get:function(){ return Proxy; }});
+({}) instanceof p;
+}
+
+var exception;
+try {
+test();
+} catch (e) {
+exception = e;
+}
+
+if (exception != "TypeError: calling Proxy constructor without new is invalid")
+throw "FAILED";
+
Modified: trunk/Source/_javascript_Core/ChangeLog (217156 => 217157)
--- trunk/Source/_javascript_Core/ChangeLog 2017-05-19 22:25:16 UTC (rev 217156)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-05-19 22:28:10 UTC (rev 217157)
@@ -1,5 +1,16 @@
2017-05-19 Mark Lam
+Add missing exception check.
+https://bugs.webkit.org/show_bug.cgi?id=172346
+
+
+Reviewed by Geoffrey Garen.
+
+* runtime/JSObject.cpp:
+(JSC::JSObject::hasInstance):
+
+2017-05-19 Mark Lam
+
DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring result registers.
https://bugs.webkit.org/show_bug.cgi?id=172383
Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (217156 => 217157)
--- trunk/Source/_javascript_Core/runtime/JSObject.cpp 2017-05-19 22:25:16 UTC (rev 217156)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp 2017-05-19 22:28:10 UTC (rev 217157)
@@ -2036,6 +2036,7 @@
MarkedArgumentBuffer args;
args.append(value);
JSValue result = call(exec, hasInstanceValue, callType, callData, this, args);
+RETURN_IF_EXCEPTION(scope, false);
return result.toBoolean(exec);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217156] trunk
Title: [217156] trunk
Revision 217156
Author mark@apple.com
Date 2017-05-19 15:25:16 -0700 (Fri, 19 May 2017)
Log Message
DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring result registers.
https://bugs.webkit.org/show_bug.cgi?id=172383
Reviewed by Filip Pizlo.
JSTests:
* stress/regress-172383.js: Added.
Source/_javascript_Core:
pickCanTrample() is wrongly assuming that one of regT0 and regT1 is always
available as a scratch register. This assumption is wrong if this canTrample
register is used for a silentFill() after an operation that returns a result in
regT0 or regT1.
Turns out the only reason we need the canTrample register is for
SetDoubleConstant. We can remove the need for this canTrample register by
introducing a moveDouble() pseudo instruction in the MacroAssembler to do the
job using the scratchRegister() on X86_64 or the dataMemoryTempRegister() on
ARM64. In so doing, we can simplify the silentFill() code and eliminate the bug.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::moveDouble):
* dfg/DFGArrayifySlowPathGenerator.h:
* dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
(JSC::DFG::CallArrayAllocatorWithVariableStructureVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableStructureVariableSizeSlowPathGenerator):
* dfg/DFGCallCreateDirectArgumentsSlowPathGenerator.h:
* dfg/DFGSaneStringGetByValSlowPathGenerator.h:
* dfg/DFGSlowPathGenerator.h:
(JSC::DFG::CallSlowPathGenerator::tearDown):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compileToLowerCase):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::emitUntypedBitOp):
(JSC::DFG::SpeculativeJIT::emitUntypedRightShiftBitOp):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchStringOnString):
(JSC::DFG::SpeculativeJIT::compileStoreBarrier):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::pickCanTrample): Deleted.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::convertAnyInt):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/dfg/DFGArrayifySlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGCallArrayAllocatorSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGCallCreateDirectArgumentsSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGSaneStringGetByValSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGSlowPathGenerator.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Added Paths
trunk/JSTests/stress/regress-172383.js
Diff
Modified: trunk/JSTests/ChangeLog (217155 => 217156)
--- trunk/JSTests/ChangeLog 2017-05-19 22:24:25 UTC (rev 217155)
+++ trunk/JSTests/ChangeLog 2017-05-19 22:25:16 UTC (rev 217156)
@@ -1,3 +1,13 @@
+2017-05-19 Mark Lam
+
+DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring result registers.
+https://bugs.webkit.org/show_bug.cgi?id=172383
+
+
+Reviewed by Filip Pizlo.
+
+* stress/regress-172383.js: Added.
+
2017-05-19 Filip Pizlo
arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
Added: trunk/JSTests/stress/regress-172383.js (0 => 217156)
--- trunk/JSTests/stress/regress-172383.js (rev 0)
+++ trunk/JSTests/stress/regress-172383.js 2017-05-19 22:25:16 UTC (rev 217156)
@@ -0,0 +1,40 @@
+// This test should not crash.
+
+let x = undefined;
+
+function foo(w, a0, a1) {
+var r0 = x % a0;
+var r1 = w ^ a1;
+
+var r4 = 3 % 7;
+
+var r6 = w ^ 0;
+var r7 = r4 / r4;
+var r9 = x - r7;
+a1 = 0 + r0;
+
+var r11 = 0 & a0;
+var r12 = r4 * a1;
+var r7 = r11 & a0;
+
+var r15 = r11 | r4;
+var r16 = 0 & r1;
+var r20 = 5 * a0;
+
+var r2 = 0 + r9;
+var r26 = r11 | r15;
+var r29 = r16 + 0;
+var r29 = r28 * r1;
+var r34 = w / r12;
+
[webkit-changes] [217155] trunk/LayoutTests
Title: [217155] trunk/LayoutTests
Revision 217155
Author ryanhad...@apple.com
Date 2017-05-19 15:24:25 -0700 (Fri, 19 May 2017)
Log Message
LayoutTest js/Promise-types.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=171739
Unreviewed follow-up fix for JSC tests.
* js/script-tests/Promise-types.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/script-tests/Promise-types.js
Diff
Modified: trunk/LayoutTests/ChangeLog (217154 => 217155)
--- trunk/LayoutTests/ChangeLog 2017-05-19 22:17:49 UTC (rev 217154)
+++ trunk/LayoutTests/ChangeLog 2017-05-19 22:24:25 UTC (rev 217155)
@@ -1,3 +1,12 @@
+2017-05-19 Ryan Haddad
+
+LayoutTest js/Promise-types.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=171739
+
+Unreviewed follow-up fix for JSC tests.
+
+* js/script-tests/Promise-types.js:
+
2017-05-19 Youenn Fablet
Align MockRealtimeMediaSourceCenter with RealtimeMediaSourceCenter
Modified: trunk/LayoutTests/js/script-tests/Promise-types.js (217154 => 217155)
--- trunk/LayoutTests/js/script-tests/Promise-types.js 2017-05-19 22:17:49 UTC (rev 217154)
+++ trunk/LayoutTests/js/script-tests/Promise-types.js 2017-05-19 22:24:25 UTC (rev 217155)
@@ -6,7 +6,7 @@
debug("");
// Silence unhandled rejection messages.
-window._onunhandledrejection_ = () => false;
+_onunhandledrejection_ = () => false;
// Promises should be of type Promise.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217154] trunk/Websites/browserbench.org
Title: [217154] trunk/Websites/browserbench.org
Revision 217154
Author rn...@webkit.org
Date 2017-05-19 15:17:49 -0700 (Fri, 19 May 2017)
Log Message
Merge Speedometer 2.0 fixes up to r217121 to browserbench.org
https://bugs.webkit.org/show_bug.cgi?id=172389
Rubber-stamped by Chris Dumez.
Merged the various fixes for Speedometer 2.0 starting from r217107 through r217121.
* Speedometer2.0/InteractiveRunner.html:
* Speedometer2.0/resources/benchmark-runner.js:
* Speedometer2.0/resources/tests.js:
* Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/app/js/main.js:
* Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:
* Speedometer2.0/resources/todomvc/functional-prog-examples/elm/dist/elm.js:
* Speedometer2.0/resources/todomvc/vanilla-examples/vanillajs/js/store.js:
Modified Paths
trunk/Websites/browserbench.org/ChangeLog
trunk/Websites/browserbench.org/Speedometer2.0/InteractiveRunner.html
trunk/Websites/browserbench.org/Speedometer2.0/resources/benchmark-runner.js
trunk/Websites/browserbench.org/Speedometer2.0/resources/tests.js
trunk/Websites/browserbench.org/Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/app/js/main.js
trunk/Websites/browserbench.org/Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js
trunk/Websites/browserbench.org/Speedometer2.0/resources/todomvc/functional-prog-examples/elm/dist/elm.js
trunk/Websites/browserbench.org/Speedometer2.0/resources/todomvc/vanilla-examples/vanillajs/js/store.js
Diff
Modified: trunk/Websites/browserbench.org/ChangeLog (217153 => 217154)
--- trunk/Websites/browserbench.org/ChangeLog 2017-05-19 22:11:15 UTC (rev 217153)
+++ trunk/Websites/browserbench.org/ChangeLog 2017-05-19 22:17:49 UTC (rev 217154)
@@ -1,3 +1,20 @@
+2017-05-19 Ryosuke Niwa
+
+Merge Speedometer 2.0 fixes up to r217121 to browserbench.org
+https://bugs.webkit.org/show_bug.cgi?id=172389
+
+Rubber-stamped by Chris Dumez.
+
+Merged the various fixes for Speedometer 2.0 starting from r217107 through r217121.
+
+* Speedometer2.0/InteractiveRunner.html:
+* Speedometer2.0/resources/benchmark-runner.js:
+* Speedometer2.0/resources/tests.js:
+* Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/app/js/main.js:
+* Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:
+* Speedometer2.0/resources/todomvc/functional-prog-examples/elm/dist/elm.js:
+* Speedometer2.0/resources/todomvc/vanilla-examples/vanillajs/js/store.js:
+
2017-05-18 Ryosuke Niwa
Add Speedometer 2.0 to browserbench.org for final testing
Modified: trunk/Websites/browserbench.org/Speedometer2.0/InteractiveRunner.html (217153 => 217154)
--- trunk/Websites/browserbench.org/Speedometer2.0/InteractiveRunner.html 2017-05-19 22:11:15 UTC (rev 217153)
+++ trunk/Websites/browserbench.org/Speedometer2.0/InteractiveRunner.html 2017-05-19 22:17:49 UTC (rev 217154)
@@ -10,7 +10,8 @@
ol ol { margin-left: 2em; list-position: outside; }
.running { text-decoration: underline; }
.ran { color: grey; }
-nav { position: absolute; right: 10px; }
+nav { position: absolute; right: 10px; height: 600px; }
+nav > ol { height: 100%; overflow-y: scroll; }
Modified: trunk/Websites/browserbench.org/Speedometer2.0/resources/benchmark-runner.js (217153 => 217154)
--- trunk/Websites/browserbench.org/Speedometer2.0/resources/benchmark-runner.js 2017-05-19 22:11:15 UTC (rev 217153)
+++ trunk/Websites/browserbench.org/Speedometer2.0/resources/benchmark-runner.js 2017-05-19 22:17:49 UTC (rev 217154)
@@ -192,6 +192,7 @@
}
if (state.isFirstTest()) {
+this._removeFrame();
this._masuredValuesForCurrentSuite = {};
var self = this;
return state.prepareCurrentSuite(this, this._appendFrame()).then(function (prepareReturnValue) {
@@ -251,8 +252,6 @@
self._client.didRunTest(suite, test);
state.next();
-if (state.currentSuite() != suite)
-self._removeFrame();
promise.resolve(state);
});
}, 0);
Modified: trunk/Websites/browserbench.org/Speedometer2.0/resources/tests.js (217153 => 217154)
--- trunk/Websites/browserbench.org/Speedometer2.0/resources/tests.js 2017-05-19 22:11:15 UTC (rev 217153)
+++ trunk/Websites/browserbench.org/Speedometer2.0/resources/tests.js 2017-05-19 22:17:49 UTC (rev 217154)
@@ -250,9 +250,8 @@
checkboxes[i].click();
}),
new BenchmarkTestStep('DeletingAllItems', function (newTodo, contentWindow, contentDocument) {
-var deleteButtons = contentDocument.querySelectorAll('.destroy');
-for (var i = 0; i < deleteButtons.length; i++)
-deleteButtons[i].click();
+for (var i = 0; i < numberOfItemsToAdd; i++)
+
[webkit-changes] [217153] trunk/Source/WebKit2
Title: [217153] trunk/Source/WebKit2 Revision 217153 Author cdu...@apple.com Date 2017-05-19 15:11:15 -0700 (Fri, 19 May 2017) Log Message [WK2] Notify client when a process exceeds background CPU limit while in the foreground https://bugs.webkit.org/show_bug.cgi?id=172246 Reviewed by Geoffrey Garen. When there is a background CPU limit set by the client, we now monitor the CPU usages of all WebContent processes, not just the non-visible ones. This way, we are now able to notify the client a process has exceeded the background CPU limit while in the foreground, via the UIClient's didExceedBackgroundResourceLimitWhileInForeground function, passing kWKResourceLimitCPU. * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): * Shared/WebPageCreationParameters.h: * UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::copy): * UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::cpuLimit): (API::PageConfiguration::setCPULimit): * UIProcess/API/C/WKPageConfigurationRef.cpp: (WKPageConfigurationSetBackgroundCPULimit): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateThrottleState): (WebKit::WebPageProxy::creationParameters): (WebKit::WebPageProxy::didExceedInactiveMemoryLimitWhileActive): (WebKit::WebPageProxy::didExceedBackgroundCPULimitWhileInForeground): * UIProcess/WebPageProxy.h: * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didExceedCPULimit): * UIProcess/WebProcessProxy.h: * UIProcess/WebProcessProxy.messages.in: * WebProcess/WebPage/WebPage.cpp: (WebKit::m_cpuLimit): * WebProcess/WebPage/WebPage.h: (WebKit::WebPage::cpuLimit): * WebProcess/WebProcess.cpp: (WebKit::WebProcess::createWebPage): (WebKit::WebProcess::removeWebPage): (WebKit::WebProcess::updateCPULimit): (WebKit::WebProcess::updateCPUMonitorState): (WebKit::WebProcess::pageActivityStateDidChange): * WebProcess/WebProcess.h: * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::updateCPULimit): (WebKit::WebProcess::updateCPUMonitorState): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp trunk/Source/WebKit2/Shared/WebPageCreationParameters.h trunk/Source/WebKit2/UIProcess/API/APIPageConfiguration.cpp trunk/Source/WebKit2/UIProcess/API/APIPageConfiguration.h trunk/Source/WebKit2/UIProcess/API/C/WKPageConfigurationRef.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp trunk/Source/WebKit2/UIProcess/WebProcessProxy.h trunk/Source/WebKit2/UIProcess/WebProcessProxy.messages.in trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Source/WebKit2/WebProcess/WebProcess.cpp trunk/Source/WebKit2/WebProcess/WebProcess.h trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (217152 => 217153) --- trunk/Source/WebKit2/ChangeLog 2017-05-19 21:56:00 UTC (rev 217152) +++ trunk/Source/WebKit2/ChangeLog 2017-05-19 22:11:15 UTC (rev 217153) @@ -1,3 +1,53 @@ +2017-05-19 Chris Dumez + +[WK2] Notify client when a process exceeds background CPU limit while in the foreground +https://bugs.webkit.org/show_bug.cgi?id=172246 + + +Reviewed by Geoffrey Garen. + +When there is a background CPU limit set by the client, we now monitor the CPU +usages of all WebContent processes, not just the non-visible ones. This way, we +are now able to notify the client a process has exceeded the background CPU +limit while in the foreground, via the UIClient's didExceedBackgroundResourceLimitWhileInForeground +function, passing kWKResourceLimitCPU. + +* Shared/WebPageCreationParameters.cpp: +(WebKit::WebPageCreationParameters::encode): +(WebKit::WebPageCreationParameters::decode): +* Shared/WebPageCreationParameters.h: +* UIProcess/API/APIPageConfiguration.cpp: +(API::PageConfiguration::copy): +* UIProcess/API/APIPageConfiguration.h: +(API::PageConfiguration::cpuLimit): +(API::PageConfiguration::setCPULimit): +* UIProcess/API/C/WKPageConfigurationRef.cpp: +(WKPageConfigurationSetBackgroundCPULimit): +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::updateThrottleState): +(WebKit::WebPageProxy::creationParameters): +(WebKit::WebPageProxy::didExceedInactiveMemoryLimitWhileActive): +(WebKit::WebPageProxy::didExceedBackgroundCPULimitWhileInForeground): +* UIProcess/WebPageProxy.h: +* UIProcess/WebProcessProxy.cpp: +(WebKit::WebProcessProxy::didExceedCPULimit): +* UIProcess/WebProcessProxy.h: +* UIProcess/WebProcessProxy.messages.in: +* WebProcess/WebPage/WebPage.cpp: +(WebKit::m_cpuLimit): +* WebProcess/WebPage/WebPage.h: +
[webkit-changes] [217152] trunk
Title: [217152] trunk
Revision 217152
Author mra...@apple.com
Date 2017-05-19 14:56:00 -0700 (Fri, 19 May 2017)
Log Message
Inherit media user gestures from the top document when autoplay quirks are allowed.
https://bugs.webkit.org/show_bug.cgi?id=172375
Reviewed by Eric Carlson.
Added API test.
* dom/Document.cpp:
(WebCore::Document::processingUserGestureForMedia):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit2/autoplay-inherits-gesture-from-document.html
Diff
Modified: trunk/Source/WebCore/ChangeLog (217151 => 217152)
--- trunk/Source/WebCore/ChangeLog 2017-05-19 21:41:50 UTC (rev 217151)
+++ trunk/Source/WebCore/ChangeLog 2017-05-19 21:56:00 UTC (rev 217152)
@@ -1,3 +1,15 @@
+2017-05-19 Matt Rajca
+
+Inherit media user gestures from the top document when autoplay quirks are allowed.
+https://bugs.webkit.org/show_bug.cgi?id=172375
+
+Reviewed by Eric Carlson.
+
+Added API test.
+
+* dom/Document.cpp:
+(WebCore::Document::processingUserGestureForMedia):
+
2017-05-19 Youenn Fablet
Align MockRealtimeMediaSourceCenter with RealtimeMediaSourceCenter
Modified: trunk/Source/WebCore/dom/Document.cpp (217151 => 217152)
--- trunk/Source/WebCore/dom/Document.cpp 2017-05-19 21:41:50 UTC (rev 217151)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-05-19 21:56:00 UTC (rev 217152)
@@ -6388,10 +6388,14 @@
if (ScriptController::processingUserGestureForMedia())
return true;
-if (!settings().mediaUserGestureInheritsFromDocument())
-return false;
+if (settings().mediaUserGestureInheritsFromDocument())
+return topDocument().hasHadUserInteraction();
-return topDocument().hasHadUserInteraction();
+auto* loader = this->loader();
+if (loader && loader->allowsAutoplayQuirks())
+return topDocument().hasHadUserInteraction();
+
+return false;
}
void Document::startTrackingStyleRecalcs()
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (217151 => 217152)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2017-05-19 21:41:50 UTC (rev 217151)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2017-05-19 21:56:00 UTC (rev 217152)
@@ -569,6 +569,7 @@
C99B675D1E39722000FC6C80 /* js-play-with-controls.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C99B675B1E3971FC00FC6C80 /* js-play-with-controls.html */; };
C99B675F1E39736F00FC6C80 /* no-autoplay-with-controls.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C99B675E1E39735C00FC6C80 /* no-autoplay-with-controls.html */; };
C99BDF891E80980400C7170E /* autoplay-zero-volume-check.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C99BDF881E8097E300C7170E /* autoplay-zero-volume-check.html */; };
+ C9B1043E1ECF9848000520FA /* autoplay-inherits-gesture-from-document.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C9B1043D1ECF9832000520FA /* autoplay-inherits-gesture-from-document.html */; };
C9BF06EF1E9C132500595E3E /* autoplay-muted-with-controls.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C9BF06EE1E9C130400595E3E /* autoplay-muted-with-controls.html */; };
C9C60E651E53A9DC006DA181 /* autoplay-check-frame.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C9C60E631E53A9BA006DA181 /* autoplay-check-frame.html */; };
C9C60E661E53A9DC006DA181 /* autoplay-check-in-iframe.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C9C60E641E53A9BA006DA181 /* autoplay-check-in-iframe.html */; };
@@ -691,6 +692,7 @@
dstPath = TestWebKitAPI.resources;
dstSubfolderSpec = 7;
files = (
+C9B1043E1ECF9848000520FA /* autoplay-inherits-gesture-from-document.html in Copy Resources */,
3FCC4FE81EC4E8CA0076E37C /* PictureInPictureDelegate.html in Copy Resources */,
55226A2F1EBA44B900C36AD0 /* large-red-square-image.html in Copy Resources */,
5797FE331EB15AB100B2F4A0 /* navigation-client-default-crypto.html in Copy Resources */,
@@ -1455,6 +1457,7 @@
C99B675B1E3971FC00FC6C80 /* js-play-with-controls.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "js-play-with-controls.html"; sourceTree = ""; };
C99B675E1E39735C00FC6C80 /* no-autoplay-with-controls.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "no-autoplay-with-controls.html"; sourceTree = ""; };
C99BDF881E8097E300C7170E /* autoplay-zero-volume-check.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "autoplay-zero-volume-check.html"; sourceTree = ""; };
+ C9B1043D1ECF9832000520FA /* autoplay-inherits-gesture-from-document.html */ = {isa = PBXFileReference; lastKnownFileType
[webkit-changes] [217151] trunk
Title: [217151] trunk
Revision 217151
Author commit-qu...@webkit.org
Date 2017-05-19 14:41:50 -0700 (Fri, 19 May 2017)
Log Message
Align MockRealtimeMediaSourceCenter with RealtimeMediaSourceCenter
https://bugs.webkit.org/show_bug.cgi?id=172324
Patch by Youenn Fablet on 2017-05-19
Reviewed by Eric Carlson.
Source/WebCore:
No change of behavior.
Remove most of MockRealtimeMediaSourceCenter implementation.
Next step should be to remove it entirely and use the factory setters instead.
* platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::RealtimeMediaSourceCenter::RealtimeMediaSourceCenter):
(WebCore::RealtimeMediaSourceCenter::createMediaStream):
(WebCore::RealtimeMediaSourceCenter::getMediaStreamDevices):
(WebCore::RealtimeMediaSourceCenter::setDeviceEnabled):
* platform/mediastream/RealtimeMediaSourceCenter.h:
(WebCore::RealtimeMediaSourceCenter::supportedConstraints):
* platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenterMac::RealtimeMediaSourceCenterMac):
* platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
* platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::MockCaptureDeviceManager::captureDevices):
* platform/mock/MockRealtimeMediaSourceCenter.h:
LayoutTests:
* fast/mediastream/mock-media-source-webaudio.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/mock-media-source-webaudio.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h
trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp
trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.h
trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h
Diff
Modified: trunk/LayoutTests/ChangeLog (217150 => 217151)
--- trunk/LayoutTests/ChangeLog 2017-05-19 21:19:00 UTC (rev 217150)
+++ trunk/LayoutTests/ChangeLog 2017-05-19 21:41:50 UTC (rev 217151)
@@ -1,3 +1,12 @@
+2017-05-19 Youenn Fablet
+
+Align MockRealtimeMediaSourceCenter with RealtimeMediaSourceCenter
+https://bugs.webkit.org/show_bug.cgi?id=172324
+
+Reviewed by Eric Carlson.
+
+* fast/mediastream/mock-media-source-webaudio.html:
+
2017-05-19 Alexey Proskuryakov
Many CSS js-tests use waitUntilDone
Modified: trunk/LayoutTests/fast/mediastream/mock-media-source-webaudio.html (217150 => 217151)
--- trunk/LayoutTests/fast/mediastream/mock-media-source-webaudio.html 2017-05-19 21:19:00 UTC (rev 217150)
+++ trunk/LayoutTests/fast/mediastream/mock-media-source-webaudio.html 2017-05-19 21:41:50 UTC (rev 217151)
@@ -64,8 +64,8 @@
test.done();
};
-var timeout = setTimeout(done, 3000);
-var interval = setInterval(analyse, 1000 / 30);
+var timeout = setTimeout(() => { done(); }, 3000);
+var interval = setInterval(() => { analyse(); }, 1000 / 30);
analyse();
});
}, "Basic getUserMedia to Web Audio test");
Modified: trunk/Source/WebCore/ChangeLog (217150 => 217151)
--- trunk/Source/WebCore/ChangeLog 2017-05-19 21:19:00 UTC (rev 217150)
+++ trunk/Source/WebCore/ChangeLog 2017-05-19 21:41:50 UTC (rev 217151)
@@ -1,3 +1,28 @@
+2017-05-19 Youenn Fablet
+
+Align MockRealtimeMediaSourceCenter with RealtimeMediaSourceCenter
+https://bugs.webkit.org/show_bug.cgi?id=172324
+
+Reviewed by Eric Carlson.
+
+No change of behavior.
+Remove most of MockRealtimeMediaSourceCenter implementation.
+Next step should be to remove it entirely and use the factory setters instead.
+
+* platform/mediastream/RealtimeMediaSourceCenter.cpp:
+(WebCore::RealtimeMediaSourceCenter::RealtimeMediaSourceCenter):
+(WebCore::RealtimeMediaSourceCenter::createMediaStream):
+(WebCore::RealtimeMediaSourceCenter::getMediaStreamDevices):
+(WebCore::RealtimeMediaSourceCenter::setDeviceEnabled):
+* platform/mediastream/RealtimeMediaSourceCenter.h:
+(WebCore::RealtimeMediaSourceCenter::supportedConstraints):
+* platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
+(WebCore::RealtimeMediaSourceCenterMac::RealtimeMediaSourceCenterMac):
+* platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
+* platform/mock/MockRealtimeMediaSourceCenter.cpp:
+(WebCore::MockRealtimeMediaSourceCenter::MockCaptureDeviceManager::captureDevices):
+* platform/mock/MockRealtimeMediaSourceCenter.h:
+
2017-05-19 Zalan Bujtas
Update SameSizeAsInlineBox with the correct InlineBoxBitfields bits.
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (217150 => 217151)
--- trunk/Source/We
[webkit-changes] [217150] trunk/LayoutTests
Title: [217150] trunk/LayoutTests Revision 217150 Author a...@apple.com Date 2017-05-19 14:19:00 -0700 (Fri, 19 May 2017) Log Message Many CSS js-tests use waitUntilDone https://bugs.webkit.org/show_bug.cgi?id=172379 Reviewed by Tim Horton. Corrected the use of js-test harness, updated the tests to use js-test.js instead of js-test-pre.js where possible. * css3/filters/should-not-have-compositing-layer-expected.txt: * css3/filters/should-not-have-compositing-layer.html: * css3/scroll-snap/nested-elements-expected.txt: * css3/scroll-snap/nested-elements.html: * css3/scroll-snap/scroll-snap-2d-change-axis-type-expected.txt: * css3/scroll-snap/scroll-snap-2d-change-axis-type.html: * css3/scroll-snap/scroll-snap-2d-offsets-computed-independently-expected.txt: * css3/scroll-snap/scroll-snap-2d-offsets-computed-independently.html: * css3/scroll-snap/scroll-snap-elements-container-larger-than-children-expected.txt: * css3/scroll-snap/scroll-snap-elements-container-larger-than-children.html: * css3/scroll-snap/scroll-snap-mismatch-expected.txt: * css3/scroll-snap/scroll-snap-mismatch.html: * css3/scroll-snap/scroll-snap-offsets-expected.txt: * css3/scroll-snap/scroll-snap-offsets.html: * css3/scroll-snap/scroll-snap-positions-expected.txt: * css3/scroll-snap/scroll-snap-positions-mainframe-expected.txt: * css3/scroll-snap/scroll-snap-positions-mainframe.html: * css3/scroll-snap/scroll-snap-positions-overflow-resize-expected.txt: * css3/scroll-snap/scroll-snap-positions-overflow-resize.html: * css3/scroll-snap/scroll-snap-positions.html: * css3/scroll-snap/scroll-snap-style-changed-align-expected.txt: * css3/scroll-snap/scroll-snap-style-changed-align.html: * css3/touch-action/touch-action-manipulation-fast-clicks.html: * fast/css/counters/2displays-expected.txt: * fast/css/counters/2displays.html: * fast/css/counters/after-continuation-expected.txt: * fast/css/counters/after-continuation.html: * fast/css/counters/counter-increment-inherit-expected.txt: * fast/css/counters/counter-increment-inherit.htm: * fast/css/counters/counter-increment-tests-expected.txt: * fast/css/counters/counter-increment-tests.htm: * fast/css/device-aspect-ratio.html: * fast/css/hover-display-block-inline-expected.txt: * fast/css/hover-display-block-inline.html: * fast/css/hover-display-block-none-expected.txt: * fast/css/hover-display-block-none.html: * fast/css/image-resolution/image-resolution.html: * fast/css/max-device-aspect-ratio.html: * fast/css/min-device-aspect-ratio.html: * fast/css/pseudo-target-indirect-sibling-001.html: * fast/css/pseudo-target-indirect-sibling-002.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/filters/should-not-have-compositing-layer-expected.txt trunk/LayoutTests/css3/filters/should-not-have-compositing-layer.html trunk/LayoutTests/css3/scroll-snap/nested-elements-expected.txt trunk/LayoutTests/css3/scroll-snap/nested-elements.html trunk/LayoutTests/css3/scroll-snap/scroll-snap-2d-change-axis-type-expected.txt trunk/LayoutTests/css3/scroll-snap/scroll-snap-2d-change-axis-type.html trunk/LayoutTests/css3/scroll-snap/scroll-snap-2d-offsets-computed-independently-expected.txt trunk/LayoutTests/css3/scroll-snap/scroll-snap-2d-offsets-computed-independently.html trunk/LayoutTests/css3/scroll-snap/scroll-snap-elements-container-larger-than-children-expected.txt trunk/LayoutTests/css3/scroll-snap/scroll-snap-elements-container-larger-than-children.html trunk/LayoutTests/css3/scroll-snap/scroll-snap-mismatch-expected.txt trunk/LayoutTests/css3/scroll-snap/scroll-snap-mismatch.html trunk/LayoutTests/css3/scroll-snap/scroll-snap-offsets-expected.txt trunk/LayoutTests/css3/scroll-snap/scroll-snap-offsets.html trunk/LayoutTests/css3/scroll-snap/scroll-snap-positions-expected.txt trunk/LayoutTests/css3/scroll-snap/scroll-snap-positions-mainframe-expected.txt trunk/LayoutTests/css3/scroll-snap/scroll-snap-positions-mainframe.html trunk/LayoutTests/css3/scroll-snap/scroll-snap-positions-overflow-resize-expected.txt trunk/LayoutTests/css3/scroll-snap/scroll-snap-positions-overflow-resize.html trunk/LayoutTests/css3/scroll-snap/scroll-snap-positions.html trunk/LayoutTests/css3/scroll-snap/scroll-snap-style-changed-align-expected.txt trunk/LayoutTests/css3/scroll-snap/scroll-snap-style-changed-align.html trunk/LayoutTests/css3/touch-action/touch-action-manipulation-fast-clicks.html trunk/LayoutTests/fast/css/counters/2displays-expected.txt trunk/LayoutTests/fast/css/counters/2displays.html trunk/LayoutTests/fast/css/counters/after-continuation-expected.txt trunk/LayoutTests/fast/css/counters/after-continuation.html trunk/LayoutTests/fast/css/counters/counter-increment-inherit-expected.txt trunk/LayoutTests/fast/css/counters/counter-increment-inherit.htm trunk/LayoutTests/fast/css/counters/counter-increment-tests-expected.txt trunk/LayoutTests/fast/css/counters/counter-increment-tests.htm trunk/LayoutTests/fast/css/device-aspect-ratio.html trunk/LayoutTests/fast/css/hover-display-bloc
[webkit-changes] [217149] trunk/Source/JavaScriptCore
Title: [217149] trunk/Source/_javascript_Core
Revision 217149
Author fpi...@apple.com
Date 2017-05-19 14:08:42 -0700 (Fri, 19 May 2017)
Log Message
Deduplicate some code in arrayProtoPrivateFuncConcatMemcpy
https://bugs.webkit.org/show_bug.cgi?id=172382
Reviewed by Saam Barati.
This is just a small clean-up - my last patch here created some unnecessary code duplication.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoPrivateFuncConcatMemcpy):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (217148 => 217149)
--- trunk/Source/_javascript_Core/ChangeLog 2017-05-19 20:47:44 UTC (rev 217148)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-05-19 21:08:42 UTC (rev 217149)
@@ -1,5 +1,17 @@
2017-05-19 Filip Pizlo
+Deduplicate some code in arrayProtoPrivateFuncConcatMemcpy
+https://bugs.webkit.org/show_bug.cgi?id=172382
+
+Reviewed by Saam Barati.
+
+This is just a small clean-up - my last patch here created some unnecessary code duplication.
+
+* runtime/ArrayPrototype.cpp:
+(JSC::arrayProtoPrivateFuncConcatMemcpy):
+
+2017-05-19 Filip Pizlo
+
arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
https://bugs.webkit.org/show_bug.cgi?id=172369
Modified: trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp (217148 => 217149)
--- trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp 2017-05-19 20:47:44 UTC (rev 217148)
+++ trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp 2017-05-19 21:08:42 UTC (rev 217149)
@@ -1318,18 +1318,19 @@
memcpy(buffer + firstArraySize, secondButterfly->contiguousDouble().data(), sizeof(JSValue) * secondArraySize);
} else if (type != ArrayWithUndecided) {
WriteBarrier* buffer = result->butterfly()->contiguous().data();
-if (firstType != ArrayWithUndecided)
-memcpy(buffer, firstButterfly->contiguous().data(), sizeof(JSValue) * firstArraySize);
-else {
-for (unsigned i = firstArraySize; i--;)
-buffer[i].clear();
-}
-if (secondType != ArrayWithUndecided)
-memcpy(buffer + firstArraySize, secondButterfly->contiguous().data(), sizeof(JSValue) * secondArraySize);
-else {
-for (unsigned i = secondArraySize; i--;)
-buffer[i + firstArraySize].clear();
-}
+
+auto copy = [&] (unsigned offset, void* source, unsigned size, IndexingType type) {
+if (type != ArrayWithUndecided) {
+memcpy(buffer + offset, source, sizeof(JSValue) * size);
+return;
+}
+
+for (unsigned i = size; i--;)
+buffer[i + offset].clear();
+};
+
+copy(0, firstButterfly->contiguous().data(), firstArraySize, firstType);
+copy(firstArraySize, secondButterfly->contiguous().data(), secondArraySize, secondType);
}
result->butterfly()->setPublicLength(resultSize);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217147] trunk/Tools
Title: [217147] trunk/Tools
Revision 217147
Author jbed...@apple.com
Date 2017-05-19 13:47:44 -0700 (Fri, 19 May 2017)
Log Message
webkitpy: Use simctl boot to run multiple simulators at once
https://bugs.webkit.org/show_bug.cgi?id=172374
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.xcode_version): Return the current version of Xcode.
* Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.xcode_version): Return version 8.0 for testing.
* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
run multiple Simulator.app instances.
(IOSSimulatorPort._create_simulators): Only copy the simulator app for older
versions of Xcode.
(IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
an older version of Xcode.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py
trunk/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py
trunk/Tools/Scripts/webkitpy/port/ios_simulator.py
Diff
Modified: trunk/Tools/ChangeLog (217146 => 217147)
--- trunk/Tools/ChangeLog 2017-05-19 20:13:16 UTC (rev 217146)
+++ trunk/Tools/ChangeLog 2017-05-19 20:47:44 UTC (rev 217147)
@@ -1,3 +1,22 @@
+2017-05-19 Jonathan Bedard
+
+webkitpy: Use simctl boot to run multiple simulators at once
+https://bugs.webkit.org/show_bug.cgi?id=172374
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/system/platforminfo.py:
+(PlatformInfo.xcode_version): Return the current version of Xcode.
+* Scripts/webkitpy/common/system/platforminfo_mock.py:
+(MockPlatformInfo.xcode_version): Return version 8.0 for testing.
+* Scripts/webkitpy/port/ios_simulator.py:
+(IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
+run multiple Simulator.app instances.
+(IOSSimulatorPort._create_simulators): Only copy the simulator app for older
+versions of Xcode.
+(IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
+an older version of Xcode.
+
2017-05-19 Wenson Hsieh
Unreviewed, fix the build on the latest internal SDK.
Modified: trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py (217146 => 217147)
--- trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py 2017-05-19 20:13:16 UTC (rev 217146)
+++ trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py 2017-05-19 20:47:44 UTC (rev 217147)
@@ -133,6 +133,11 @@
output = self._executive.run_command(['xcrun', 'simctl', 'list'], return_stderr=False)
return (line for line in output.splitlines())
+def xcode_version(self):
+if not self.is_mac():
+raise NotImplementedError
+return self._executive.run_command(['xcodebuild', '-version']).split()[1]
+
def _determine_os_name(self, sys_platform):
if sys_platform == 'darwin':
return 'mac'
Modified: trunk/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py (217146 => 217147)
--- trunk/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py 2017-05-19 20:13:16 UTC (rev 217146)
+++ trunk/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py 2017-05-19 20:47:44 UTC (rev 217147)
@@ -60,5 +60,8 @@
def xcode_sdk_version(self, sdk_name):
return '8.1'
+def xcode_version(self):
+return '8.0'
+
def xcode_simctl_list(self):
return self.expected_xcode_simctl_list
Modified: trunk/Tools/Scripts/webkitpy/port/ios_simulator.py (217146 => 217147)
--- trunk/Tools/Scripts/webkitpy/port/ios_simulator.py 2017-05-19 20:13:16 UTC (rev 217146)
+++ trunk/Tools/Scripts/webkitpy/port/ios_simulator.py 2017-05-19 20:47:44 UTC (rev 217147)
@@ -170,6 +170,9 @@
except:
_log.warning('Unable to remove Simulator' + str(i))
+def use_multiple_simulator_apps(self):
+return int(self.host.platform.xcode_version().split('.')[0]) < 9
+
def _create_simulators(self):
if (self.default_child_processes() < self.child_processes()):
_log.warn('You have specified very high value({0}) for --child-processes'.format(self.child_processes()))
@@ -178,8 +181,10 @@
if self._using_dedicated_simulators():
atexit.register(lambda: self._teardown_managed_simulators())
-self._createSimulatorApps()
+if self.use_multiple_simulator_apps():
+self._createSimulatorApps()
+
for i in xrange(self.child_processes()):
self._create_device(i)
@@ -211,16 +216,23 @@
_log.debug('testing device %s has udid %s', i, device_udid)
# FIXME: Switch to using CoreSimulator.framework for launching and quitting iOS Simulator
-self._executive.run_command([
-'open', '-g', '-b', self.SIMULATOR_BUNDLE_ID + str(i),
-
[webkit-changes] [217148] trunk/Source/WebCore
Title: [217148] trunk/Source/WebCore Revision 217148 Author za...@apple.com Date 2017-05-19 13:47:44 -0700 (Fri, 19 May 2017) Log Message Update SameSizeAsInlineBox with the correct InlineBoxBitfields bits. https://bugs.webkit.org/show_bug.cgi?id=172377 Reviewed by Tim Horton. * rendering/InlineBox.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/InlineBox.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (217147 => 217148) --- trunk/Source/WebCore/ChangeLog 2017-05-19 20:47:44 UTC (rev 217147) +++ trunk/Source/WebCore/ChangeLog 2017-05-19 20:47:44 UTC (rev 217148) @@ -1,3 +1,12 @@ +2017-05-19 Zalan Bujtas + +Update SameSizeAsInlineBox with the correct InlineBoxBitfields bits. +https://bugs.webkit.org/show_bug.cgi?id=172377 + +Reviewed by Tim Horton. + +* rendering/InlineBox.cpp: + 2017-05-19 Daniel Bates Bindings: Support runtime-enabled features in specific worlds Modified: trunk/Source/WebCore/rendering/InlineBox.cpp (217147 => 217148) --- trunk/Source/WebCore/rendering/InlineBox.cpp 2017-05-19 20:47:44 UTC (rev 217147) +++ trunk/Source/WebCore/rendering/InlineBox.cpp 2017-05-19 20:47:44 UTC (rev 217148) @@ -39,7 +39,7 @@ void* a[4]; FloatPoint b; float c[2]; -unsigned d : 20; +unsigned d : 23; #if !ASSERT_WITH_SECURITY_IMPLICATION_DISABLED unsigned s; bool f; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217146] trunk/Source/WebCore
Title: [217146] trunk/Source/WebCore Revision 217146 Author dba...@webkit.org Date 2017-05-19 13:13:16 -0700 (Fri, 19 May 2017) Log Message Bindings: Support runtime-enabled features in specific worlds https://bugs.webkit.org/show_bug.cgi?id=172235 Reviewed by Chris Dumez. Currently a function, attribute, or interface can be annotated with either EnabledAtRuntime or EnabledForWorld (not both) to expose/conceal it depending on the state of a runtime feature flag or the DOM world associated with the running _javascript_ code, respectively. Even though we do not have any functions, attributes, or interfaces that are annotated with both EnabledAtRuntime and EnabledForWorld at the time of writing, it seems reasonable to support such a combination of annotations. This also has the benefit of making it straightforward to support the extended attribute SecureContext by generalizing the logic that generates the code to expose/conceal a function, attribute, or interface. * bindings/scripts/CodeGeneratorJS.pm: (GenerateRuntimeEnableConditionalString): Use an array to build up all the conjuncts in the conditional _expression_. (GenerateImplementation): Substitute GenerateRuntimeEnableConditionalString() and $runtimeEnableConditionalString for GetRuntimeEnableFunctionName() and $enable_function_result, respectively. (GetRuntimeEnableFunctionName): Deleted. * bindings/scripts/test/JS/JSTestGlobalObject.cpp: (WebCore::JSTestGlobalObject::finishCreation): (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabled): (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabledCaller): (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeaturesEnabled): (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeaturesEnabledCaller): Update expected results. * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjPrototype::finishCreation): (WebCore::jsTestObjPrototypeFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabled): (WebCore::jsTestObjPrototypeFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabledCaller): Ditto. * bindings/scripts/test/TestGlobalObject.idl: Added test cases. * bindings/scripts/test/TestObj.idl: Added test case. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/TestGlobalObject.idl trunk/Source/WebCore/bindings/scripts/test/TestObj.idl Diff Modified: trunk/Source/WebCore/ChangeLog (217145 => 217146) --- trunk/Source/WebCore/ChangeLog 2017-05-19 20:12:12 UTC (rev 217145) +++ trunk/Source/WebCore/ChangeLog 2017-05-19 20:13:16 UTC (rev 217146) @@ -1,3 +1,43 @@ +2017-05-19 Daniel Bates + +Bindings: Support runtime-enabled features in specific worlds +https://bugs.webkit.org/show_bug.cgi?id=172235 + +Reviewed by Chris Dumez. + +Currently a function, attribute, or interface can be annotated with either EnabledAtRuntime +or EnabledForWorld (not both) to expose/conceal it depending on the state of a runtime +feature flag or the DOM world associated with the running _javascript_ code, respectively. +Even though we do not have any functions, attributes, or interfaces that are annotated +with both EnabledAtRuntime and EnabledForWorld at the time of writing, it seems reasonable +to support such a combination of annotations. This also has the benefit of making it +straightforward to support the extended attribute SecureContext by generalizing the logic +that generates the code to expose/conceal a function, attribute, or interface. + +* bindings/scripts/CodeGeneratorJS.pm: +(GenerateRuntimeEnableConditionalString): Use an array to build up all the conjuncts in +the conditional _expression_. +(GenerateImplementation): Substitute GenerateRuntimeEnableConditionalString() and $runtimeEnableConditionalString +for GetRuntimeEnableFunctionName() and $enable_function_result, respectively. +(GetRuntimeEnableFunctionName): Deleted. + +* bindings/scripts/test/JS/JSTestGlobalObject.cpp: + (WebCore::JSTestGlobalObject::finishCreation): + (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabled): + (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabledCaller): + (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeaturesEnabled): + (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeaturesEnabledCaller): + Update expected results. + + * bindings/scripts/test/JS/JSTestObj.cpp: + (WebCore::JSTestObjPrototype::finishCreation): +
[webkit-changes] [217144] trunk/LayoutTests
Title: [217144] trunk/LayoutTests Revision 217144 Author ryanhad...@apple.com Date 2017-05-19 13:12:12 -0700 (Fri, 19 May 2017) Log Message Skip tests that are reporting FailureNotTested. https://bugs.webkit.org/show_bug.cgi?id=172378 Unreviewed test gardening. * TestExpectations: * platform/ios-wk2/TestExpectations: * platform/ios/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (217143 => 217144) --- trunk/LayoutTests/ChangeLog 2017-05-19 19:39:09 UTC (rev 217143) +++ trunk/LayoutTests/ChangeLog 2017-05-19 20:12:12 UTC (rev 217144) @@ -1,5 +1,17 @@ 2017-05-19 Ryan Haddad +Skip tests that are reporting FailureNotTested. +https://bugs.webkit.org/show_bug.cgi?id=172378 + +Unreviewed test gardening. + +* TestExpectations: +* platform/ios-wk2/TestExpectations: +* platform/ios/TestExpectations: +* platform/mac/TestExpectations: + +2017-05-19 Ryan Haddad + LayoutTest js/Promise-types.html is a flaky failure (Unhandled Promise Rejection messages) https://bugs.webkit.org/show_bug.cgi?id=171739 Modified: trunk/LayoutTests/TestExpectations (217143 => 217144) --- trunk/LayoutTests/TestExpectations 2017-05-19 19:39:09 UTC (rev 217143) +++ trunk/LayoutTests/TestExpectations 2017-05-19 20:12:12 UTC (rev 217144) @@ -839,8 +839,6 @@ fast/table/hittest-tablecell-right-edge.html [ Pass Failure ] fast/css/appearance-apple-pay-button.html [ ImageOnlyFailure ] -webkit.org/b/150598 fast/repaint/table-hover-on-link.html [ Pass Failure ] - webkit.org/b/151949 streams/reference-implementation/pipe-to.html [ Pass Failure ] webkit.org/b/154687 streams/pipe-to.html [ Slow ] @@ -1298,3 +1296,12 @@ webkit.org/b/170701 webrtc/datachannel/bufferedAmountLowThreshold.html [ Pass Failure ] webkit.org/b/170835 fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html [ Pass Failure ] + +webkit.org/b/172378 fast/loader/recursive-before-unload-crash.html [ Skip ] +webkit.org/b/172378 fast/repaint/table-hover-on-link.html [ Skip ] +webkit.org/b/172378 http/tests/misc/slow-loading-mask.html [ Skip ] +webkit.org/b/172378 http/tests/multipart/policy-ignore-crash.php [ Skip ] +webkit.org/b/172378 http/tests/navigation/back-twice-without-commit.html [ Skip ] +webkit.org/b/172378 imported/blink/fast/block/float/float-mark-descendants-for-layout-crash.html [ Skip ] +webkit.org/b/172378 imported/blink/fast/frames/freed-frame.html [ Skip ] +webkit.org/b/172378 imported/blink/printing/print-document-without-documentElement-crash.html [ Skip ] Modified: trunk/LayoutTests/platform/ios/TestExpectations (217143 => 217144) --- trunk/LayoutTests/platform/ios/TestExpectations 2017-05-19 19:39:09 UTC (rev 217143) +++ trunk/LayoutTests/platform/ios/TestExpectations 2017-05-19 20:12:12 UTC (rev 217144) @@ -2069,7 +2069,6 @@ http/tests/misc/favicon-as-image.html [ Failure ] http/tests/misc/iframe404.html [ Failure ] http/tests/misc/slow-loading-image-in-pattern.html [ Failure ] -http/tests/misc/slow-loading-mask.html [ Failure ] http/tests/uri/css-href.php [ Failure ] ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm [ Failure ] svg/W3C-SVG-1.1/animate-elem-04-t.svg [ Failure ] Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (217143 => 217144) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-05-19 19:39:09 UTC (rev 217143) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-05-19 20:12:12 UTC (rev 217144) @@ -1357,7 +1357,6 @@ fast/text/word-space.html [ Failure Pass ] fast/text/zero-font-size.html [ Failure Pass ] http/tests/misc/DOMContentLoaded-event.html [ Failure Pass ] -http/tests/misc/slow-loading-mask.html [ Failure Pass ] http/tests/websocket/tests/hybi/invalid-encode-length.html [ Failure Pass ] imported/mozilla/svg/filters/filter-marked-line-02.svg [ Failure Pass ] imported/mozilla/svg/filters/filter-marked-line-03.svg [ Failure Pass ] Modified: trunk/LayoutTests/platform/mac/TestExpectations (217143 => 217144) --- trunk/LayoutTests/platform/mac/TestExpectations 2017-05-19 19:39:09 UTC (rev 217143) +++ trunk/LayoutTests/platform/mac/TestExpectations 2017-05-19 20:12:12 UTC (rev 217144) @@ -1054,8 +1054,6 @@ # FIXME: Needs bugzilla () [ Yosemite+ ] storage/websql/sql-error-codes.html [ Failure ] -webkit.org/b/82980 http/tests/navigation/back-twice-without-commit.html [ Pass Timeout ] - # Language-specific font fallback is disabled on certain versions of OS X webkit.org/b/147390 [ Yosemite ElCapitan ] fast/text/fallback-language-han.html [ ImageOnlyFailure ] webkit.org/b/147390 [ Yosemite ElCapitan ] fast/text/fallback-language-han-2.html [ ImageOnlyFailure ] _
[webkit-changes] [217145] trunk/Source/WebCore
Title: [217145] trunk/Source/WebCore
Revision 217145
Author jer.no...@apple.com
Date 2017-05-19 13:12:12 -0700 (Fri, 19 May 2017)
Log Message
Fix macos build after r217143
https://bugs.webkit.org/show_bug.cgi?id=172380
unreviewed.
Remove reference to WebVideoFullscreenInterface for mac build.
Patch by Jeremy Jones on 2017-05-19
* html/HTMLMediaElement.cpp:
* platform/mac/WebVideoFullscreenInterfaceMac.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (217144 => 217145)
--- trunk/Source/WebCore/ChangeLog 2017-05-19 20:12:12 UTC (rev 217144)
+++ trunk/Source/WebCore/ChangeLog 2017-05-19 20:12:12 UTC (rev 217145)
@@ -1,5 +1,17 @@
2017-05-19 Jeremy Jones
+Fix macos build after r217143
+https://bugs.webkit.org/show_bug.cgi?id=172380
+
+unreviewed.
+
+Remove reference to WebVideoFullscreenInterface for mac build.
+
+* html/HTMLMediaElement.cpp:
+* platform/mac/WebVideoFullscreenInterfaceMac.h:
+
+2017-05-19 Jeremy Jones
+
Remove defunct WebVideoFullscreenInterface
https://bugs.webkit.org/show_bug.cgi?id=172254
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (217144 => 217145)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-05-19 20:12:12 UTC (rev 217144)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-05-19 20:12:12 UTC (rev 217145)
@@ -153,6 +153,10 @@
#include "NotImplemented.h"
#endif
+#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#include "WebVideoFullscreenModel.h"
+#endif
+
#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(document().page() && document().page()->isAlwaysOnLoggingAllowed(), Media, "%p - HTMLMediaElement::" fmt, this, ##__VA_ARGS__)
namespace WebCore {
Modified: trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h (217144 => 217145)
--- trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h 2017-05-19 20:12:12 UTC (rev 217144)
+++ trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h 2017-05-19 20:12:12 UTC (rev 217145)
@@ -46,8 +46,7 @@
class WebVideoFullscreenChangeObserver;
class WEBCORE_EXPORT WebVideoFullscreenInterfaceMac
-: public WebVideoFullscreenInterface
-, public WebVideoFullscreenModelClient
+: public WebVideoFullscreenModelClient
, private WebPlaybackSessionModelClient
, public RefCounted {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217143] trunk/Source
Title: [217143] trunk/Source
Revision 217143
Author commit-qu...@webkit.org
Date 2017-05-19 12:39:09 -0700 (Fri, 19 May 2017)
Log Message
Remove defunct WebVideoFullscreenInterface
https://bugs.webkit.org/show_bug.cgi?id=172254
Patch by Jeremy Jones on 2017-05-19
Reviewed by Jon Lee.
Source/WebCore:
No new tests because no behavior change.
WebVideoFullscreenInterface has long since been replaced by WebVideoFullscreenModelClient.
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLMediaElement.cpp:
* html/HTMLVideoElement.cpp:
* platform/cocoa/WebPlaybackSessionModelMediaElement.mm:
* platform/cocoa/WebVideoFullscreenInterface.h: Removed.
* platform/cocoa/WebVideoFullscreenModel.h:
* platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
* platform/mac/WebVideoFullscreenInterfaceMac.h:
Source/WebKit2:
Remove reference to WebVideoFullscreenInterface. It has long since been replaced by
WebVideoFullscreenModelClient.
* WebProcess/cocoa/WebVideoFullscreenManager.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLVideoElement.cpp
trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm
trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModel.h
trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.mm
trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h
trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.h
Removed Paths
trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenInterface.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (217142 => 217143)
--- trunk/Source/WebCore/ChangeLog 2017-05-19 19:31:18 UTC (rev 217142)
+++ trunk/Source/WebCore/ChangeLog 2017-05-19 19:39:09 UTC (rev 217143)
@@ -1,5 +1,27 @@
2017-05-19 Jeremy Jones
+Remove defunct WebVideoFullscreenInterface
+https://bugs.webkit.org/show_bug.cgi?id=172254
+
+Reviewed by Jon Lee.
+
+No new tests because no behavior change.
+
+WebVideoFullscreenInterface has long since been replaced by WebVideoFullscreenModelClient.
+
+* WebCore.xcodeproj/project.pbxproj:
+* html/HTMLMediaElement.cpp:
+* html/HTMLVideoElement.cpp:
+* platform/cocoa/WebPlaybackSessionModelMediaElement.mm:
+* platform/cocoa/WebVideoFullscreenInterface.h: Removed.
+* platform/cocoa/WebVideoFullscreenModel.h:
+* platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
+* platform/ios/WebVideoFullscreenControllerAVKit.mm:
+* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
+* platform/mac/WebVideoFullscreenInterfaceMac.h:
+
+2017-05-19 Jeremy Jones
+
HTMLVideoElement::webkitSupportsPresentationMode allowsPictureInPicture() check is redundant.
https://bugs.webkit.org/show_bug.cgi?id=172330
rdar://problem/32285443
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (217142 => 217143)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-05-19 19:31:18 UTC (rev 217142)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-05-19 19:39:09 UTC (rev 217143)
@@ -2458,7 +2458,6 @@
51FB5505113E3E9100821176 /* JSCloseEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51FB5503113E3E9100821176 /* JSCloseEvent.cpp */; };
51FB67DB1AE6B82B00D06C5A /* ContentExtensionStyleSheet.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51FB67D91AE6B5E400D06C5A /* ContentExtensionStyleSheet.cpp */; };
51FB67DC1AE6B82F00D06C5A /* ContentExtensionStyleSheet.h in Headers */ = {isa = PBXBuildFile; fileRef = 51FB67DA1AE6B5E400D06C5A /* ContentExtensionStyleSheet.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 52131E591C4F15350033F802 /* WebVideoFullscreenInterface.h in Headers */ = {isa = PBXBuildFile; fileRef = 52131E581C4F15220033F802 /* WebVideoFullscreenInterface.h */; settings = {ATTRIBUTES = (Private, ); }; };
52131E5B1C4F15760033F802 /* WebVideoFullscreenInterfaceMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 52131E5A1C4F15610033F802 /* WebVideoFullscreenInterfaceMac.mm */; };
521D46F611AEC98100514613 /* KillRingMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 521D46F511AEC98100514613 /* KillRingMac.mm */; };
521D46F811AEC9B100514613 /* KillRing.h in Headers */ = {isa = PBXBuildFile; fileRef = 521D46F711AEC9B100514613 /* KillRing.h */; };
@@ -10187,7 +10186,6 @@
51FB5503113E3E9100821176 /* JSCloseEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSCloseEvent.cpp; sourceTree = ""; };
51FB67D91AE6B5E400D06C5A /* ContentExtensionStyleSheet.cpp
[webkit-changes] [217142] branches/safari-603-branch/LayoutTests
Title: [217142] branches/safari-603-branch/LayoutTests
Revision 217142
Author ryanhad...@apple.com
Date 2017-05-19 12:31:18 -0700 (Fri, 19 May 2017)
Log Message
Merge r217138. rdar://problem/32182167
Modified Paths
branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html
Diff
Modified: branches/safari-603-branch/LayoutTests/ChangeLog (217141 => 217142)
--- branches/safari-603-branch/LayoutTests/ChangeLog 2017-05-19 19:25:51 UTC (rev 217141)
+++ branches/safari-603-branch/LayoutTests/ChangeLog 2017-05-19 19:31:18 UTC (rev 217142)
@@ -1,3 +1,19 @@
+2017-05-19 Ryan Haddad
+
+Merge r217138. rdar://problem/32182167
+
+2017-05-19 Zalan Bujtas
+
+LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html should force layout after r216726.
+https://bugs.webkit.org/show_bug.cgi?id=172363
+
+
+Reviewed by Simon Fraser.
+
+10ms timer is too short to securely ensure a layout. Let's force it instead.
+
+* accessibility/mac/aria-multiple-liveregions-notification.html:
+
2017-05-18 Ryan Haddad
Unreviewed test gardening.
Modified: branches/safari-603-branch/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html (217141 => 217142)
--- branches/safari-603-branch/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html 2017-05-19 19:25:51 UTC (rev 217141)
+++ branches/safari-603-branch/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html 2017-05-19 19:31:18 UTC (rev 217142)
@@ -53,21 +53,25 @@
function textChangeOperation() {
// this should trigger a live region change for a text change.
document.getElementById("innerlive").innerText = "changed text";
+document.body.offsetHeight;
}
function newElementOperation() {
// this should trigger a live region change for a new element.
document.getElementById("liveregion1").innerHTML += "new text element";
+document.body.offsetHeight;
}
function alternativeChangeOperation() {
// this should also trigger a live region change because its a text alternative change.
document.getElementById("image").setAttribute('alt', "new image text");
+document.body.offsetHeight;
}
function removeElementOperation() {
// this should trigger a live region change for a removed element.
document.getElementById("liveregion2").removeChild(document.getElementById("image"));
+document.body.offsetHeight;
}
function finishTest() {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217141] trunk/Source/WebCore
Title: [217141] trunk/Source/WebCore Revision 217141 Author commit-qu...@webkit.org Date 2017-05-19 12:25:51 -0700 (Fri, 19 May 2017) Log Message HTMLVideoElement::webkitSupportsPresentationMode allowsPictureInPicture() check is redundant. https://bugs.webkit.org/show_bug.cgi?id=172330 rdar://problem/32285443 Patch by Jeremy Jones on 2017-05-19 Reviewed by Eric Carlson. No new tests because no behavior change. This removes a redundant call to allowsPictureInPicture() to make it more clear that webkitSupportsPresentationMode gives the same result as webkitSupportsFullscreen(pipMode) * html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::webkitSupportsPresentationMode): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLVideoElement.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (217140 => 217141) --- trunk/Source/WebCore/ChangeLog 2017-05-19 19:09:34 UTC (rev 217140) +++ trunk/Source/WebCore/ChangeLog 2017-05-19 19:25:51 UTC (rev 217141) @@ -1,5 +1,22 @@ 2017-05-19 Jeremy Jones +HTMLVideoElement::webkitSupportsPresentationMode allowsPictureInPicture() check is redundant. +https://bugs.webkit.org/show_bug.cgi?id=172330 +rdar://problem/32285443 + +Reviewed by Eric Carlson. + +No new tests because no behavior change. + +This removes a redundant call to allowsPictureInPicture() to make it +more clear that webkitSupportsPresentationMode gives the same result as +webkitSupportsFullscreen(pipMode) + +* html/HTMLVideoElement.cpp: +(WebCore::HTMLVideoElement::webkitSupportsPresentationMode): + +2017-05-19 Jeremy Jones + [WebRTC] Remove PiP support for video elements that are showing camera capture https://bugs.webkit.org/show_bug.cgi?id=172336 Modified: trunk/Source/WebCore/html/HTMLVideoElement.cpp (217140 => 217141) --- trunk/Source/WebCore/html/HTMLVideoElement.cpp 2017-05-19 19:09:34 UTC (rev 217140) +++ trunk/Source/WebCore/html/HTMLVideoElement.cpp 2017-05-19 19:25:51 UTC (rev 217141) @@ -399,7 +399,7 @@ return false; #endif -return mediaSession().allowsPictureInPicture(*this) && supportsFullscreen(HTMLMediaElementEnums::VideoFullscreenModePictureInPicture); +return supportsFullscreen(HTMLMediaElementEnums::VideoFullscreenModePictureInPicture); } if (mode == VideoPresentationMode::Inline) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217140] trunk/LayoutTests
Title: [217140] trunk/LayoutTests
Revision 217140
Author ryanhad...@apple.com
Date 2017-05-19 12:09:34 -0700 (Fri, 19 May 2017)
Log Message
LayoutTest js/Promise-types.html is a flaky failure (Unhandled Promise Rejection messages)
https://bugs.webkit.org/show_bug.cgi?id=171739
Reviewed by Joseph Pecoraro.
Silence the console messages for unhandled rejections in this LayoutTest.
* js/script-tests/Promise-types.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/script-tests/Promise-types.js
Diff
Modified: trunk/LayoutTests/ChangeLog (217139 => 217140)
--- trunk/LayoutTests/ChangeLog 2017-05-19 19:06:40 UTC (rev 217139)
+++ trunk/LayoutTests/ChangeLog 2017-05-19 19:09:34 UTC (rev 217140)
@@ -1,3 +1,14 @@
+2017-05-19 Ryan Haddad
+
+LayoutTest js/Promise-types.html is a flaky failure (Unhandled Promise Rejection messages)
+https://bugs.webkit.org/show_bug.cgi?id=171739
+
+Reviewed by Joseph Pecoraro.
+
+Silence the console messages for unhandled rejections in this LayoutTest.
+
+* js/script-tests/Promise-types.js:
+
2017-05-19 Zalan Bujtas
LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html should force layout after r216726.
Modified: trunk/LayoutTests/js/script-tests/Promise-types.js (217139 => 217140)
--- trunk/LayoutTests/js/script-tests/Promise-types.js 2017-05-19 19:06:40 UTC (rev 217139)
+++ trunk/LayoutTests/js/script-tests/Promise-types.js 2017-05-19 19:09:34 UTC (rev 217140)
@@ -5,6 +5,9 @@
debug("Promises");
debug("");
+// Silence unhandled rejection messages.
+window._onunhandledrejection_ = () => false;
+
// Promises should be of type Promise.
var aPromise = new Promise(function(resolve, reject) { resolve(1); });
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217139] trunk/Source
Title: [217139] trunk/Source
Revision 217139
Author commit-qu...@webkit.org
Date 2017-05-19 12:06:40 -0700 (Fri, 19 May 2017)
Log Message
[WebRTC] Remove PiP support for video elements that are showing camera capture
https://bugs.webkit.org/show_bug.cgi?id=172336
Patch by Jeremy Jones on 2017-05-19
Reviewed by Eric Carlson.
Source/WebCore:
No new tests because no effect on the DOM. This just changes a value sent to the platform interface layer.
Ask video element if it supports picture-in-picture instead of asking the mediaSession directly.
This allows the video element to give a more robust answer.
* html/HTMLVideoElement.h:
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::setUpFullscreen):
Source/WebKit2:
Ask video element if it supports picture-in-picture instead of asking the mediaSession directly.
This allows the video element to give a more robust answer.
* WebProcess/cocoa/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLVideoElement.h
trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (217138 => 217139)
--- trunk/Source/WebCore/ChangeLog 2017-05-19 18:47:03 UTC (rev 217138)
+++ trunk/Source/WebCore/ChangeLog 2017-05-19 19:06:40 UTC (rev 217139)
@@ -1,3 +1,19 @@
+2017-05-19 Jeremy Jones
+
+[WebRTC] Remove PiP support for video elements that are showing camera capture
+https://bugs.webkit.org/show_bug.cgi?id=172336
+
+Reviewed by Eric Carlson.
+
+No new tests because no effect on the DOM. This just changes a value sent to the platform interface layer.
+
+Ask video element if it supports picture-in-picture instead of asking the mediaSession directly.
+This allows the video element to give a more robust answer.
+
+* html/HTMLVideoElement.h:
+* platform/ios/WebVideoFullscreenControllerAVKit.mm:
+(WebVideoFullscreenControllerContext::setUpFullscreen):
+
2017-05-18 Sam Weinig
[WebIDL] Remove the need for the generator to know about native type mapping
Modified: trunk/Source/WebCore/html/HTMLVideoElement.h (217138 => 217139)
--- trunk/Source/WebCore/html/HTMLVideoElement.h 2017-05-19 18:47:03 UTC (rev 217138)
+++ trunk/Source/WebCore/html/HTMLVideoElement.h 2017-05-19 19:06:40 UTC (rev 217139)
@@ -76,7 +76,7 @@
#if ENABLE(VIDEO_PRESENTATION_MODE)
enum class VideoPresentationMode { Fullscreen, PictureInPicture, Inline };
-bool webkitSupportsPresentationMode(VideoPresentationMode) const;
+WEBCORE_EXPORT bool webkitSupportsPresentationMode(VideoPresentationMode) const;
void webkitSetPresentationMode(VideoPresentationMode);
VideoPresentationMode webkitPresentationMode() const;
void setFullscreenMode(VideoFullscreenMode);
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm (217138 => 217139)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm 2017-05-19 18:47:03 UTC (rev 217138)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm 2017-05-19 19:06:40 UTC (rev 217139)
@@ -803,7 +803,7 @@
m_fullscreenModel->addClient(*this);
m_fullscreenModel->setVideoElement(m_videoElement.get());
-bool allowsPictureInPicture = m_videoElement->mediaSession().allowsPictureInPicture(*m_videoElement.get());
+bool allowsPictureInPicture = m_videoElement->webkitSupportsPresentationMode(HTMLVideoElement::VideoPresentationMode::PictureInPicture);
IntRect videoElementClientRect = elementRectInWindow(m_videoElement.get());
FloatRect videoLayerFrame = FloatRect(FloatPoint(), videoElementClientRect.size());
Modified: trunk/Source/WebKit2/ChangeLog (217138 => 217139)
--- trunk/Source/WebKit2/ChangeLog 2017-05-19 18:47:03 UTC (rev 217138)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-19 19:06:40 UTC (rev 217139)
@@ -1,3 +1,16 @@
+2017-05-19 Jeremy Jones
+
+[WebRTC] Remove PiP support for video elements that are showing camera capture
+https://bugs.webkit.org/show_bug.cgi?id=172336
+
+Reviewed by Eric Carlson.
+
+Ask video element if it supports picture-in-picture instead of asking the mediaSession directly.
+This allows the video element to give a more robust answer.
+
+* WebProcess/cocoa/WebVideoFullscreenManager.mm:
+(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement):
+
2017-05-19 Chris Dumez
Make sure implementation of InitializeWebKit2() always run on the main thread
Modified: trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.mm (217138 => 217139)
--- trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.mm 2017-05-19 18:47:03 UTC (
[webkit-changes] [217138] trunk/LayoutTests
Title: [217138] trunk/LayoutTests
Revision 217138
Author za...@apple.com
Date 2017-05-19 11:47:03 -0700 (Fri, 19 May 2017)
Log Message
LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html should force layout after r216726.
https://bugs.webkit.org/show_bug.cgi?id=172363
Reviewed by Simon Fraser.
10ms timer is too short to securely ensure a layout. Let's force it instead.
* accessibility/mac/aria-multiple-liveregions-notification.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html
Diff
Modified: trunk/LayoutTests/ChangeLog (217137 => 217138)
--- trunk/LayoutTests/ChangeLog 2017-05-19 18:44:14 UTC (rev 217137)
+++ trunk/LayoutTests/ChangeLog 2017-05-19 18:47:03 UTC (rev 217138)
@@ -1,3 +1,15 @@
+2017-05-19 Zalan Bujtas
+
+LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html should force layout after r216726.
+https://bugs.webkit.org/show_bug.cgi?id=172363
+
+
+Reviewed by Simon Fraser.
+
+10ms timer is too short to securely ensure a layout. Let's force it instead.
+
+* accessibility/mac/aria-multiple-liveregions-notification.html:
+
2017-05-19 Commit Queue
Unreviewed, rolling out r217098, r217111, r217113, and
Modified: trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html (217137 => 217138)
--- trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html 2017-05-19 18:44:14 UTC (rev 217137)
+++ trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html 2017-05-19 18:47:03 UTC (rev 217138)
@@ -53,21 +53,25 @@
function textChangeOperation() {
// this should trigger a live region change for a text change.
document.getElementById("innerlive").innerText = "changed text";
+document.body.offsetHeight;
}
function newElementOperation() {
// this should trigger a live region change for a new element.
document.getElementById("liveregion1").innerHTML += "new text element";
+document.body.offsetHeight;
}
function alternativeChangeOperation() {
// this should also trigger a live region change because its a text alternative change.
document.getElementById("image").setAttribute('alt', "new image text");
+document.body.offsetHeight;
}
function removeElementOperation() {
// this should trigger a live region change for a removed element.
document.getElementById("liveregion2").removeChild(document.getElementById("image"));
+document.body.offsetHeight;
}
function finishTest() {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217137] trunk/Source/WebKit2
Title: [217137] trunk/Source/WebKit2 Revision 217137 Author cdu...@apple.com Date 2017-05-19 11:44:14 -0700 (Fri, 19 May 2017) Log Message Make sure implementation of InitializeWebKit2() always run on the main thread https://bugs.webkit.org/show_bug.cgi?id=172362 Reviewed by Geoffrey Garen. Add logic in InitializeWebKit2() for Cocoa ports to always run the initialization code is only called once, and on the main thread. If we are called from a non-main thread, we will dispatch synchronously to the main thread to run the initialization code. This is needed because WebKit2Initialize() is called from the API::Object constructor. API::Object is thread-safe RefCounted and those objects are sometimes initialized on non-main thread. If the first of such objects happened to be initialized on a non-main thread, then we would run the initialization code for the first time on a non-main thread. This would lead to hard to debug issues because code such as RunLoop::initializeMainRunLoop() is only safe to call on the main thread because it stores a pointer to the current thread's RunLoop in a static variable for later use (i.e. for RunLoop::main()). * Shared/Cocoa/WebKit2InitializeCocoa.mm: Copied from Source/WebKit2/Shared/WebKit2Initialize.cpp. (WebKit::runInitializationCode): (WebKit::InitializeWebKit2): * Shared/WebKit2Initialize.cpp: (WebKit::InitializeWebKit2): * WebKit2.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebKit2Initialize.cpp trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit2/Shared/Cocoa/WebKit2InitializeCocoa.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (217136 => 217137) --- trunk/Source/WebKit2/ChangeLog 2017-05-19 18:41:22 UTC (rev 217136) +++ trunk/Source/WebKit2/ChangeLog 2017-05-19 18:44:14 UTC (rev 217137) @@ -1,3 +1,31 @@ +2017-05-19 Chris Dumez + +Make sure implementation of InitializeWebKit2() always run on the main thread +https://bugs.webkit.org/show_bug.cgi?id=172362 + + +Reviewed by Geoffrey Garen. + +Add logic in InitializeWebKit2() for Cocoa ports to always run the initialization code +is only called once, and on the main thread. If we are called from a non-main thread, +we will dispatch synchronously to the main thread to run the initialization code. + +This is needed because WebKit2Initialize() is called from the API::Object constructor. +API::Object is thread-safe RefCounted and those objects are sometimes initialized on +non-main thread. If the first of such objects happened to be initialized on a non-main +thread, then we would run the initialization code for the first time on a non-main +thread. This would lead to hard to debug issues because code such as +RunLoop::initializeMainRunLoop() is only safe to call on the main thread because it +stores a pointer to the current thread's RunLoop in a static variable for later use +(i.e. for RunLoop::main()). + +* Shared/Cocoa/WebKit2InitializeCocoa.mm: Copied from Source/WebKit2/Shared/WebKit2Initialize.cpp. +(WebKit::runInitializationCode): +(WebKit::InitializeWebKit2): +* Shared/WebKit2Initialize.cpp: +(WebKit::InitializeWebKit2): +* WebKit2.xcodeproj/project.pbxproj: + 2017-05-19 Carlos Garcia Campos REGRESSION(r216977): [GTK] Ephemeral sessions broken after r216977 Copied: trunk/Source/WebKit2/Shared/Cocoa/WebKit2InitializeCocoa.mm (from rev 217136, trunk/Source/WebKit2/Shared/WebKit2Initialize.cpp) (0 => 217137) --- trunk/Source/WebKit2/Shared/Cocoa/WebKit2InitializeCocoa.mm (rev 0) +++ trunk/Source/WebKit2/Shared/Cocoa/WebKit2InitializeCocoa.mm 2017-05-19 18:44:14 UTC (rev 217137) @@ -0,0 +1,73 @@ +/* + * Copyright (C) 2017 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTIO
[webkit-changes] [217136] trunk/Tools
Title: [217136] trunk/Tools
Revision 217136
Author wenson_hs...@apple.com
Date 2017-05-19 11:41:22 -0700 (Fri, 19 May 2017)
Log Message
Unreviewed, fix the build on the latest internal SDK.
* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
Diff
Modified: trunk/Tools/ChangeLog (217135 => 217136)
--- trunk/Tools/ChangeLog 2017-05-19 18:36:55 UTC (rev 217135)
+++ trunk/Tools/ChangeLog 2017-05-19 18:41:22 UTC (rev 217136)
@@ -1,3 +1,10 @@
+2017-05-19 Wenson Hsieh
+
+Unreviewed, fix the build on the latest internal SDK.
+
+* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
+(TestWebKitAPI::TEST):
+
2017-05-19 Filip Pizlo
arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm (217135 => 217136)
--- trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm 2017-05-19 18:36:55 UTC (rev 217135)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm 2017-05-19 18:41:22 UTC (rev 217136)
@@ -283,7 +283,8 @@
__block bool doneLoadingURL = false;
UIItemProvider *sourceItemProvider = [dataInteractionSimulator sourceItemProviders].firstObject;
-[sourceItemProvider loadObjectOfClass:[NSURL class] completionHandler:^(NSURL *url, NSError *error) {
+[sourceItemProvider loadObjectOfClass:[NSURL class] completionHandler:^(id object, NSError *error) {
+NSURL *url = ""
EXPECT_WK_STREQ("Hello world", url._title.UTF8String ?: "");
doneLoadingURL = true;
}];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217135] trunk
Title: [217135] trunk
Revision 217135
Author fpi...@apple.com
Date 2017-05-19 11:36:55 -0700 (Fri, 19 May 2017)
Log Message
arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
https://bugs.webkit.org/show_bug.cgi?id=172369
Reviewed by Mark Lam.
JSTests:
* stress/undecided-concat.js: Added.
Source/_javascript_Core:
* heap/Subspace.cpp: Reshaped the code a bit to aid debugging.
(JSC::Subspace::allocate):
(JSC::Subspace::tryAllocate):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoPrivateFuncConcatMemcpy): Fix the bug!
* runtime/ObjectInitializationScope.cpp: Provide even better feedback.
(JSC::ObjectInitializationScope::verifyPropertiesAreInitialized):
Tools:
Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
would be a good idea to write this down.
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Subspace.cpp
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
trunk/Source/_javascript_Core/runtime/ObjectInitializationScope.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Added Paths
trunk/JSTests/stress/undecided-concat.js
Diff
Modified: trunk/JSTests/ChangeLog (217134 => 217135)
--- trunk/JSTests/ChangeLog 2017-05-19 18:07:49 UTC (rev 217134)
+++ trunk/JSTests/ChangeLog 2017-05-19 18:36:55 UTC (rev 217135)
@@ -1,3 +1,12 @@
+2017-05-19 Filip Pizlo
+
+arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
+https://bugs.webkit.org/show_bug.cgi?id=172369
+
+Reviewed by Mark Lam.
+
+* stress/undecided-concat.js: Added.
+
2017-05-19 Yusuke Suzuki
[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
Added: trunk/JSTests/stress/undecided-concat.js (0 => 217135)
--- trunk/JSTests/stress/undecided-concat.js (rev 0)
+++ trunk/JSTests/stress/undecided-concat.js 2017-05-19 18:36:55 UTC (rev 217135)
@@ -0,0 +1,8 @@
+// This is guaranteed to scribble free cells.
+//@ runNoCJITValidate
+
+var result = (new Array(64).concat(new Array(64))).concat(["hello"]);
+
+var value = result[0];
+if (value !== void 0)
+throw "Error: bad result: " + value;
Modified: trunk/Source/_javascript_Core/ChangeLog (217134 => 217135)
--- trunk/Source/_javascript_Core/ChangeLog 2017-05-19 18:07:49 UTC (rev 217134)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-05-19 18:36:55 UTC (rev 217135)
@@ -1,3 +1,18 @@
+2017-05-19 Filip Pizlo
+
+arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
+https://bugs.webkit.org/show_bug.cgi?id=172369
+
+Reviewed by Mark Lam.
+
+* heap/Subspace.cpp: Reshaped the code a bit to aid debugging.
+(JSC::Subspace::allocate):
+(JSC::Subspace::tryAllocate):
+* runtime/ArrayPrototype.cpp:
+(JSC::arrayProtoPrivateFuncConcatMemcpy): Fix the bug!
+* runtime/ObjectInitializationScope.cpp: Provide even better feedback.
+(JSC::ObjectInitializationScope::verifyPropertiesAreInitialized):
+
2017-05-18 Filip Pizlo
B3::Value::effects() says that having a fence range implies the fence bit, but on x86_64 we lower loadAcq/storeRel to load/store so the store-before-load fence bit orderings won't be honored
Modified: trunk/Source/_javascript_Core/heap/Subspace.cpp (217134 => 217135)
--- trunk/Source/_javascript_Core/heap/Subspace.cpp 2017-05-19 18:07:49 UTC (rev 217134)
+++ trunk/Source/_javascript_Core/heap/Subspace.cpp 2017-05-19 18:36:55 UTC (rev 217135)
@@ -93,30 +93,42 @@
// need the deferralContext.
void* Subspace::allocate(size_t size)
{
+void* result;
if (MarkedAllocator* allocator = tryAllocatorFor(size))
-return allocator->allocate();
-return allocateSlow(nullptr, size);
+result = allocator->allocate();
+else
+result = allocateSlow(nullptr, size);
+return result;
}
void* Subspace::allocate(GCDeferralContext* deferralContext, size_t size)
{
+void *result;
if (MarkedAllocator* allocator = tryAllocatorFor(size))
-return allocator->allocate(deferralContext);
-return allocateSlow(deferralContext, size);
+result = allocator->allocate(deferralContext);
+else
+result = allocateSlow(deferralContext, size);
+return result;
}
void* Subspace::tryAllocate(size_t size)
{
+void* result;
if (MarkedAllocator* allocator = tryAllocatorFor(size))
-return allocator->tryAllocate();
-return tryAllocateSlow(nullptr, size);
+result = allocator->tryAllocate();
+else
+result = tryAllocateSlow(nullptr, size);
+return result;
}
void* Subspace::tryAllocate(GCDeferralContext* deferralContext, size_t size)
{
+void* result;
if (MarkedAllocator* allocator = tryAllocatorFor(size))
-return allocator->tryAllocate(deferralContext);
-
[webkit-changes] [217134] trunk/Source
Title: [217134] trunk/Source
Revision 217134
Author wei...@apple.com
Date 2017-05-19 11:07:49 -0700 (Fri, 19 May 2017)
Log Message
[WebIDL] Remove the need for the generator to know about native type mapping
https://bugs.webkit.org/show_bug.cgi?id=172310
Reviewed by Darin Adler.
Source/WebCore:
Replace the use of explicit typename to native type mappings in CodeGeneratorJS.pm
with use of IDLTypes and Converter, which already need the mapping. This allows us
to have the information in only one spot.
Also, callback generation to account for nullability and update the IDLs to correctly
annotate only the types that need to be nullable.
* Modules/geolocation/GeoNotifier.cpp:
* Modules/geolocation/GeoNotifier.h:
* Modules/geolocation/Geolocation.cpp:
* Modules/geolocation/Geolocation.h:
* Modules/geolocation/PositionCallback.idl:
* Modules/geolocation/PositionErrorCallback.h:
Use references where possible in the Geolocation code. It was almost possible
to make PositionCallback take a non-nullable position, but some odd logic in
Geolocation::makeCachedPositionCallbacks() implies that there is a path where
passing null is possible, though it would assert. Added FIXME's to return to
this in a follow up.
* Modules/webaudio/AudioBufferCallback.idl:
Add nullable annotation and FIXME explaining that the latest spec splits the callback
into two separate ones.
* Modules/webdatabase/Database.cpp:
(WebCore::Database::runTransaction):
* Modules/webdatabase/DatabaseCallback.h:
* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
* Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::performCallback):
* Modules/webdatabase/SQLStatementCallback.h:
* Modules/webdatabase/SQLStatementErrorCallback.h:
* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):
* Modules/webdatabase/SQLTransactionCallback.h:
* Modules/webdatabase/SQLTransactionErrorCallback.h:
* inspector/InspectorDatabaseAgent.cpp:
* bindings/js/JSSQLStatementErrorCallbackCustom.cpp:
(WebCore::JSSQLStatementErrorCallback::handleEvent):
Update to pass callback parameters as references, since they are never null.
* bindings/IDLTypes.h:
Add NullableParameterType to allow customization of nullable parameters (in much
the same way we allow customization of the nullable implementation type).
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateDefaultValue):
Use Converter<>::ReturnType{ } for default values rather than ${GetNativeType..}().
(GenerateHeader):
Remove use of GetNativeType for toWrapped by using the impl type, since this will never
be a complex type.
(GenerateImplementation):
Simplify DOMJIT UnsafeToNative by merging two identical paths and using auto.
(GenerateParametersCheck):
Rework parameter checks to use more specific variable names, make branches more clear,
and use Converter<>::ReturnType rather than GetNativeType.
(GenerateCallbackHeaderContent):
(GenerateCallbackImplementationContent):
Switch to using typename ${IDLType}::ParameterType as the parameters for callback functions. Also
add final and override to make sure the generated function matches the user provided base class.
(GetNativeType): Deleted.
(GetNativeInnerType): Deleted.
(GetNativeTypeForCallbacks): Deleted.
Remove native type mappings.
* css/MediaQueryListListener.h:
* css/MediaQueryListListener.idl:
* css/MediaQueryMatcher.cpp:
Update MediaQueryListListener to take a non-nullable MediaQueryList.
* dom/NativeNodeFilter.cpp:
* dom/NativeNodeFilter.h:
* dom/NodeFilter.h:
* dom/NodeFilter.idl:
* dom/NodeIterator.cpp:
* dom/Traversal.cpp:
* dom/Traversal.h:
* dom/TreeWalker.cpp:
* bindings/js/JSNodeFilterCustom.cpp:
Update acceptNode to be non-nullable and pass the Node by reference.
* dom/StringCallback.cpp:
* dom/StringCallback.h:
Pass the ScriptExecutionContext by reference.
* page/IntersectionObserverCallback.h:
Update to match new parameter types and pass IntersectionObserver by reference.
* page/PerformanceObserver.cpp:
* page/PerformanceObserverCallback.h:
Update to pass PerformanceObserverEntryList and PerformanceObserver by reference.
* bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
* bindings/scripts/test/JS/JSTestCallbackFunction.h:
* bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.cpp:
* bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.h:
* bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
* bindings/scripts/test/JS/JSTestCallbackInterface.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
Update test results.
* bindings/scripts/test/TestCallbackInterface.idl:
Update test to refer to actual interfaces as we now do lookup on these parameter
types rather than blindly assuming they are interfaces.
Source/WebKit/mac:
* DOM/DOM.mm:
(-[DOMNodeFilter acceptNode:]):
Update to pass Node by reference.
Modified Paths
trunk/Source/WebCore/Chan
[webkit-changes] [217132] trunk/Source/WebInspectorUI
Title: [217132] trunk/Source/WebInspectorUI
Revision 217132
Author drou...@apple.com
Date 2017-05-19 11:02:32 -0700 (Fri, 19 May 2017)
Log Message
Web Inspector: Use initialLayout for Settings tab
https://bugs.webkit.org/show_bug.cgi?id=172304
Reviewed by Matt Baker.
* UserInterface/Views/GeneralSettingsView.js:
(WebInspector.GeneralSettingsView.prototype.initialLayout):
Move listener for zoom factor to only update that editor.
* UserInterface/Views/SettingsTabContentView.js:
(WebInspector.SettingsTabContentView):
(WebInspector.SettingsTabContentView.prototype.initialLayout): Added.
It is not necessary to create the UI for editing settings until the Settings tab is shown.
Use initialLayout to ensure UI gets created exactly once, after the tab is selected.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/GeneralSettingsView.js
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (217131 => 217132)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-05-19 16:37:32 UTC (rev 217131)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-05-19 18:02:32 UTC (rev 217132)
@@ -1,3 +1,20 @@
+2017-05-19 Devin Rousso
+
+Web Inspector: Use initialLayout for Settings tab
+https://bugs.webkit.org/show_bug.cgi?id=172304
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/GeneralSettingsView.js:
+(WebInspector.GeneralSettingsView.prototype.initialLayout):
+Move listener for zoom factor to only update that editor.
+
+* UserInterface/Views/SettingsTabContentView.js:
+(WebInspector.SettingsTabContentView):
+(WebInspector.SettingsTabContentView.prototype.initialLayout): Added.
+It is not necessary to create the UI for editing settings until the Settings tab is shown.
+Use initialLayout to ensure UI gets created exactly once, after the tab is selected.
+
2017-05-18 Devin Rousso
REGRESSION (r?): Web Inspector: Shift-click on color square in Styles sidebar should not select text
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralSettingsView.js (217131 => 217132)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralSettingsView.js 2017-05-19 16:37:32 UTC (rev 217131)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralSettingsView.js 2017-05-19 18:02:32 UTC (rev 217132)
@@ -79,8 +79,9 @@
const zoomValues = zoomLevels.map((level) => [level, Number.percentageString(level, 0)]);
let [/* unused */, zoomEditor] = this.addGroupWithCustomSetting(WebInspector.UIString("Zoom:"), WebInspector.SettingEditor.Type.Select, {values: zoomValues});
-zoomEditor.value = WebInspector.settings.zoomFactor.value;
+zoomEditor.value = WebInspector.getZoomFactor();
zoomEditor.addEventListener(WebInspector.SettingEditor.Event.ValueDidChange, () => { WebInspector.setZoomFactor(zoomEditor.value); });
+WebInspector.settings.zoomFactor.addEventListener(WebInspector.Setting.Event.Changed, () => { zoomEditor.value = WebInspector.getZoomFactor().maxDecimals(2); });
this.addSeparator();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (217131 => 217132)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2017-05-19 16:37:32 UTC (rev 217131)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2017-05-19 18:02:32 UTC (rev 217132)
@@ -35,22 +35,8 @@
// Ensures that the Settings tab is displayable from a pinned tab bar item.
tabBarItem.representedObject = this;
-let boundNeedsLayout = this.needsLayout.bind(this, WebInspector.View.LayoutReason.Dirty);
-WebInspector.notifications.addEventListener(WebInspector.Notification.DebugUIEnabledDidChange, boundNeedsLayout);
-WebInspector.settings.zoomFactor.addEventListener(WebInspector.Setting.Event.Changed, boundNeedsLayout);
-
-this._navigationBar = new WebInspector.NavigationBar;
-this._navigationBar.addEventListener(WebInspector.NavigationBar.Event.NavigationItemSelected, this._navigationItemSelected, this);
-
this._selectedSettingsView = null;
this._settingsViews = [];
-
-this.addSubview(this._navigationBar);
-
-let generalSettingsView = new WebInspector.GeneralSettingsView;
-this.addSettingsView(generalSettingsView);
-
-this.selectedSettingsView = generalSettingsView;
}
static tabInfo()
@@ -166,6 +152,23 @@
}
}
+// Protected
+
+initialLayout()
+{
+this._navigationBar = new WebInspector.NavigationBar;
+this._navigationBar.addEventListener(WebInspector.NavigationBar.Event.NavigationItemSelected, this._navigationItemSelected, this);
+
+this.addSubview(this._navigationBar);
+
+let generalSettingsView = new WebInspector.GeneralSet
[webkit-changes] [217131] branches/safari-604.1.21-branch/Source/WebCore
Title: [217131] branches/safari-604.1.21-branch/Source/WebCore
Revision 217131
Author jmarc...@apple.com
Date 2017-05-19 09:37:32 -0700 (Fri, 19 May 2017)
Log Message
Cherry-pick r217096. rdar://problem/32243153
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/BitmapImage.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (217130 => 217131)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 16:23:15 UTC (rev 217130)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 16:37:32 UTC (rev 217131)
@@ -1,5 +1,32 @@
2017-05-19 Jason Marcell
+Cherry-pick r217096. rdar://problem/32243153
+
+2017-05-18 Said Abou-Hallawa
+
+[REGRESSION](r216901): Delete ImageDecoder if BitmapImage::destroyDecodedData() was called to destroy all the decoded frames
+https://bugs.webkit.org/show_bug.cgi?id=172325
+
+Reviewed by Simon Fraser.
+
+When calling BitmapImage::destroyDecodedData() with destroyAll = true, the
+current ImageDecoder has to be deleted regardless the current frame needs
+to be cached or not. This is true except when the image is animating.
+Creating a new ImageDecoder for the animated image will lead to decoding
+all the frames from frame-zero till the current frame.
+
+Deleting the current ImageDecoder has the benefit of releasing its raster
+data. We also must delete the current ImageDecoder when the CachedImage
+switched its data SharedBuffer.
+
+The fix is return the condition in BitmapImage::destroyDecodedData() to
+be as it was before r216901.
+
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::destroyDecodedData):
+
+2017-05-19 Jason Marcell
+
Cherry-pick r217058. rdar://problem/32277335
2017-05-18 Youenn Fablet
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/BitmapImage.cpp (217130 => 217131)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/BitmapImage.cpp 2017-05-19 16:23:15 UTC (rev 217130)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/graphics/BitmapImage.cpp 2017-05-19 16:37:32 UTC (rev 217131)
@@ -78,10 +78,9 @@
if (!destroyAll)
m_source.destroyDecodedDataBeforeFrame(m_currentFrame);
-else if (!canDestroyDecodedData()) {
+else if (!canDestroyDecodedData())
m_source.destroyAllDecodedDataExcludeFrame(m_currentFrame);
-destroyAll = false;
-} else {
+else {
m_source.destroyAllDecodedData();
m_currentFrameDecodingStatus = ImageFrame::DecodingStatus::Invalid;
}
@@ -88,7 +87,7 @@
// There's no need to throw away the decoder unless we're explicitly asked
// to destroy all of the frames.
-if (!destroyAll)
+if (!destroyAll || m_source.hasAsyncDecodingQueue())
m_source.clearFrameBufferCache(m_currentFrame);
else
m_source.clear(data());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217130] trunk/Tools
Title: [217130] trunk/Tools Revision 217130 Author jbed...@apple.com Date 2017-05-19 09:23:15 -0700 (Fri, 19 May 2017) Log Message webkitpy: Layout tests which have no output will succeed https://bugs.webkit.org/show_bug.cgi?id=172322 Reviewed by David Kilzer. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output. * Scripts/webkitpy/layout_tests/models/test_failures.py: (determine_result_type): FailureNotTested means that the test could not be loaded. This is classified as a MISSING failure. (FailureNotTested): Added. (FailureNotTested.message): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py Diff Modified: trunk/Tools/ChangeLog (217129 => 217130) --- trunk/Tools/ChangeLog 2017-05-19 16:16:52 UTC (rev 217129) +++ trunk/Tools/ChangeLog 2017-05-19 16:23:15 UTC (rev 217130) @@ -1,3 +1,19 @@ +2017-05-19 Jonathan Bedard + +webkitpy: Layout tests which have no output will succeed +https://bugs.webkit.org/show_bug.cgi?id=172322 + + +Reviewed by David Kilzer. + +* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: +(SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output. +* Scripts/webkitpy/layout_tests/models/test_failures.py: +(determine_result_type): FailureNotTested means that the test could not be loaded. This +is classified as a MISSING failure. +(FailureNotTested): Added. +(FailureNotTested.message): + 2017-05-19 Yusuke Suzuki Add SixSpeed benchmark to PerformanceTests Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (217129 => 217130) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2017-05-19 16:16:52 UTC (rev 217129) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2017-05-19 16:23:15 UTC (rev 217130) @@ -240,6 +240,8 @@ failures.append(test_failures.FailureTextMismatch()) elif actual_text and not expected_text: failures.append(test_failures.FailureMissingResult()) +elif not actual_text and expected_text: +failures.append(test_failures.FailureNotTested()) return failures def _compare_audio(self, expected_audio, actual_audio): Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py (217129 => 217130) --- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py 2017-05-19 16:16:52 UTC (rev 217129) +++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py 2017-05-19 16:23:15 UTC (rev 217130) @@ -62,7 +62,8 @@ elif (FailureMissingResult in failure_types or FailureMissingImage in failure_types or FailureMissingImageHash in failure_types or - FailureMissingAudio in failure_types): + FailureMissingAudio in failure_types or + FailureNotTested in failure_types): return test_expectations.MISSING else: is_text_failure = FailureTextMismatch in failure_types @@ -164,6 +165,10 @@ return "-expected.txt was missing" +class FailureNotTested(FailureText): +def message(self): +return 'test was not run' + class FailureTextMismatch(FailureText): def message(self): return "text diff" @@ -265,7 +270,7 @@ # Convenient collection of all failure classes for anything that might # need to enumerate over them all. -ALL_FAILURE_CLASSES = (FailureTimeout, FailureCrash, FailureMissingResult, +ALL_FAILURE_CLASSES = (FailureTimeout, FailureCrash, FailureMissingResult, FailureNotTested, FailureTextMismatch, FailureMissingImageHash, FailureMissingImage, FailureImageHashMismatch, FailureImageHashIncorrect, FailureReftestMismatch, ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217129] trunk
Title: [217129] trunk Revision 217129 Author aes...@apple.com Date 2017-05-19 09:16:52 -0700 (Fri, 19 May 2017) Log Message REGRESSION (r217078): window.ApplePaySession is undefined on macOS Sierra https://bugs.webkit.org/show_bug.cgi?id=172344 Reviewed by Tim Horton. Source/WebCore: r213673 mistakenly changed the ApplePaySession interface from being conditional on APPLE_PAY to being conditional on APPLE_PAY_DELEGATE, so when r217078 disabled APPLE_PAY_DELEGATE on Sierra and earlier it disabled ApplePaySession. Fix this by reverting ApplePaySession to being conditional on APPLE_PAY. Fixes http/tests/ssl/applepay/ApplePaySession.html * Modules/applepay/ApplePaySession.idl: LayoutTests: * TestExpectations: Removed http/tests/ssl/applepay/ApplePaySession.html Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/applepay/ApplePaySession.idl Diff Modified: trunk/LayoutTests/ChangeLog (217128 => 217129) --- trunk/LayoutTests/ChangeLog 2017-05-19 16:11:33 UTC (rev 217128) +++ trunk/LayoutTests/ChangeLog 2017-05-19 16:16:52 UTC (rev 217129) @@ -1,3 +1,12 @@ +2017-05-19 Andy Estes + +REGRESSION (r217078): window.ApplePaySession is undefined on macOS Sierra +https://bugs.webkit.org/show_bug.cgi?id=172344 + +Reviewed by Tim Horton. + +* TestExpectations: Removed http/tests/ssl/applepay/ApplePaySession.html + 2017-05-19 Chris Dumez CSSOM insertRule() index argument is optional with default 0 Modified: trunk/LayoutTests/TestExpectations (217128 => 217129) --- trunk/LayoutTests/TestExpectations 2017-05-19 16:11:33 UTC (rev 217128) +++ trunk/LayoutTests/TestExpectations 2017-05-19 16:16:52 UTC (rev 217129) @@ -1298,5 +1298,3 @@ webkit.org/b/170701 webrtc/datachannel/bufferedAmountLowThreshold.html [ Pass Failure ] webkit.org/b/170835 fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html [ Pass Failure ] - -webkit.org/b/172344 http/tests/ssl/applepay/ApplePaySession.html [ Failure ] Modified: trunk/Source/WebCore/ChangeLog (217128 => 217129) --- trunk/Source/WebCore/ChangeLog 2017-05-19 16:11:33 UTC (rev 217128) +++ trunk/Source/WebCore/ChangeLog 2017-05-19 16:16:52 UTC (rev 217129) @@ -1,3 +1,20 @@ +2017-05-19 Andy Estes + +REGRESSION (r217078): window.ApplePaySession is undefined on macOS Sierra +https://bugs.webkit.org/show_bug.cgi?id=172344 + +Reviewed by Tim Horton. + +r213673 mistakenly changed the ApplePaySession interface from being conditional on +APPLE_PAY to being conditional on APPLE_PAY_DELEGATE, so when r217078 disabled +APPLE_PAY_DELEGATE on Sierra and earlier it disabled ApplePaySession. + +Fix this by reverting ApplePaySession to being conditional on APPLE_PAY. + +Fixes http/tests/ssl/applepay/ApplePaySession.html + +* Modules/applepay/ApplePaySession.idl: + 2017-05-19 Chris Dumez CSSOM insertRule() index argument is optional with default 0 Modified: trunk/Source/WebCore/Modules/applepay/ApplePaySession.idl (217128 => 217129) --- trunk/Source/WebCore/Modules/applepay/ApplePaySession.idl 2017-05-19 16:11:33 UTC (rev 217128) +++ trunk/Source/WebCore/Modules/applepay/ApplePaySession.idl 2017-05-19 16:16:52 UTC (rev 217129) @@ -25,7 +25,7 @@ [ ActiveDOMObject, -Conditional=APPLE_PAY_DELEGATE, +Conditional=APPLE_PAY, Constructor(unsigned long version, ApplePayPaymentRequest paymentRequest), ConstructorCallWith=Document, ConstructorMayThrowException, ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217128] trunk/Source/WebKit2
Title: [217128] trunk/Source/WebKit2
Revision 217128
Author carlo...@webkit.org
Date 2017-05-19 09:11:33 -0700 (Fri, 19 May 2017)
Log Message
REGRESSION(r216977): [GTK] Ephemeral sessions broken after r216977
https://bugs.webkit.org/show_bug.cgi?id=172345
Reviewed by Michael Catanzaro.
Since r216977, WebProcessPool sends the page session ID to the web process, but the WebsiteDataStoreParameters
session ID to the network process. WebsiteDataStoreParameters is only implemented for Cocoa, so we are sending 0
session ID to the network process, while using the right session ID everywhere else.
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::pageAddedToProcess): Add an ASSERT to ensure we are sending the same session ID to Web
and Network processes.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::parameters): Add minimal implementation for non-Cocoa ports to at least set the
session ID.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (217127 => 217128)
--- trunk/Source/WebKit2/ChangeLog 2017-05-19 15:48:40 UTC (rev 217127)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-19 16:11:33 UTC (rev 217128)
@@ -1,5 +1,23 @@
2017-05-19 Carlos Garcia Campos
+REGRESSION(r216977): [GTK] Ephemeral sessions broken after r216977
+https://bugs.webkit.org/show_bug.cgi?id=172345
+
+Reviewed by Michael Catanzaro.
+
+Since r216977, WebProcessPool sends the page session ID to the web process, but the WebsiteDataStoreParameters
+session ID to the network process. WebsiteDataStoreParameters is only implemented for Cocoa, so we are sending 0
+session ID to the network process, while using the right session ID everywhere else.
+
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::pageAddedToProcess): Add an ASSERT to ensure we are sending the same session ID to Web
+and Network processes.
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::parameters): Add minimal implementation for non-Cocoa ports to at least set the
+session ID.
+
+2017-05-19 Carlos Garcia Campos
+
Add more input validation in Connection::processMessage()
https://bugs.webkit.org/show_bug.cgi?id=171682
Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (217127 => 217128)
--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-05-19 15:48:40 UTC (rev 217127)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-05-19 16:11:33 UTC (rev 217128)
@@ -947,6 +947,7 @@
if (sessionID.isEphemeral()) {
// FIXME: Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type.
// They do basically the same thing.
+ASSERT(page.websiteDataStore().parameters().sessionID == sessionID);
sendToNetworkingProcess(Messages::NetworkProcess::EnsurePrivateBrowsingSession(page.websiteDataStore().parameters()));
page.process().send(Messages::WebProcess::EnsurePrivateBrowsingSession(sessionID), 0);
} else if (sessionID != SessionID::defaultSessionID()) {
Modified: trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp (217127 => 217128)
--- trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp 2017-05-19 15:48:40 UTC (rev 217127)
+++ trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp 2017-05-19 16:11:33 UTC (rev 217128)
@@ -1299,9 +1299,10 @@
#if !PLATFORM(COCOA)
WebsiteDataStoreParameters WebsiteDataStore::parameters()
{
-// FIXME: Implement.
-
-return { };
+// FIXME: Implement cookies.
+WebsiteDataStoreParameters parameters;
+parameters.sessionID = m_sessionID;
+return parameters;
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217127] trunk/Source/JavaScriptCore
Title: [217127] trunk/Source/_javascript_Core Revision 217127 Author fpi...@apple.com Date 2017-05-19 08:48:40 -0700 (Fri, 19 May 2017) Log Message B3::Value::effects() says that having a fence range implies the fence bit, but on x86_64 we lower loadAcq/storeRel to load/store so the store-before-load fence bit orderings won't be honored https://bugs.webkit.org/show_bug.cgi?id=172306 Reviewed by Michael Saboff. This changes B3 to emit xchg and its variants for fenced stores on x86. This ensures that fenced stores cannot be reordered around other fenced instructions. Previously, B3 emitted normal store instructions for fenced stores. That's wrong because then you get reorderings that are possible in TSO but impossible in SC. Fenced instructions are supposed to be SC with respect for each other. This is imprecise. If you really just wanted a store-release, then every X86 store does this. But, in B3, fenced stores are ARM-style store-release, meaning that they are fenced with respect to all other fences. If we ever did want to say that something is a store release in the traditional sense, then we'd want MemoryValue to have a fence flag. Then, having a fence range without the fence flag would mean the traditional store-release, which lowers to a normal store on x86. But to my knowledge, that traditional store-release is only useful for unlocking spinlocks. We don't use spinlocks in JSC. Adaptive locks require CAS for unlock, and B3 CAS is plenty fast. I think it's OK to have this small imprecision of giving clients an ARM-style store-release on x86 using xchg. The implication of this change is that the FTL no longer violates the SAB memory model. * assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::xchg8): (JSC::MacroAssemblerX86Common::xchg16): (JSC::MacroAssemblerX86Common::xchg32): (JSC::MacroAssemblerX86Common::loadAcq8): Deleted. (JSC::MacroAssemblerX86Common::loadAcq8SignedExtendTo32): Deleted. (JSC::MacroAssemblerX86Common::loadAcq16): Deleted. (JSC::MacroAssemblerX86Common::loadAcq16SignedExtendTo32): Deleted. (JSC::MacroAssemblerX86Common::loadAcq32): Deleted. (JSC::MacroAssemblerX86Common::storeRel8): Deleted. (JSC::MacroAssemblerX86Common::storeRel16): Deleted. (JSC::MacroAssemblerX86Common::storeRel32): Deleted. * assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::xchg64): (JSC::MacroAssemblerX86_64::loadAcq64): Deleted. (JSC::MacroAssemblerX86_64::storeRel64): Deleted. * b3/B3LowerToAir.cpp: (JSC::B3::Air::LowerToAir::ArgPromise::inst): (JSC::B3::Air::LowerToAir::trappingInst): (JSC::B3::Air::LowerToAir::tryAppendStoreBinOp): (JSC::B3::Air::LowerToAir::createStore): (JSC::B3::Air::LowerToAir::storeOpcode): (JSC::B3::Air::LowerToAir::appendStore): (JSC::B3::Air::LowerToAir::append): (JSC::B3::Air::LowerToAir::appendTrapping): (JSC::B3::Air::LowerToAir::fillStackmap): (JSC::B3::Air::LowerToAir::lower): * b3/air/AirKind.cpp: (JSC::B3::Air::Kind::dump): * b3/air/AirKind.h: (JSC::B3::Air::Kind::Kind): (JSC::B3::Air::Kind::operator==): (JSC::B3::Air::Kind::hash): * b3/air/AirLowerAfterRegAlloc.cpp: (JSC::B3::Air::lowerAfterRegAlloc): * b3/air/AirLowerMacros.cpp: (JSC::B3::Air::lowerMacros): * b3/air/AirOpcode.opcodes: * b3/air/AirValidate.cpp: * b3/air/opcode_generator.rb: * b3/testb3.cpp: (JSC::B3::correctSqrt): (JSC::B3::testSqrtArg): (JSC::B3::testSqrtImm): (JSC::B3::testSqrtMem): (JSC::B3::testSqrtArgWithUselessDoubleConversion): (JSC::B3::testSqrtArgWithEffectfulDoubleConversion): (JSC::B3::testStoreRelAddLoadAcq32): (JSC::B3::testTrappingLoad): (JSC::B3::testTrappingStore): (JSC::B3::testTrappingLoadAddStore): (JSC::B3::testTrappingLoadDCE): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp trunk/Source/_javascript_Core/b3/air/AirKind.cpp trunk/Source/_javascript_Core/b3/air/AirKind.h trunk/Source/_javascript_Core/b3/air/AirLowerAfterRegAlloc.cpp trunk/Source/_javascript_Core/b3/air/AirLowerMacros.cpp trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes trunk/Source/_javascript_Core/b3/air/AirValidate.cpp trunk/Source/_javascript_Core/b3/air/opcode_generator.rb trunk/Source/_javascript_Core/b3/testb3.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (217126 => 217127) --- trunk/Source/_javascript_Core/ChangeLog 2017-05-19 14:45:49 UTC (rev 217126) +++ trunk/Source/_javascript_Core/ChangeLog 2017-05-19 15:48:40 UTC (rev 217127) @@ -1,3 +1,81 @@ +2017-05-18 Filip Pizlo + +B3::Value::effects() says that having a fence range implies the fence bit, but on x86_64 we lower loadAcq/storeRel to load/store so the store-before-load fence bit orderings won't be honored +https://bugs.webkit.org/show_bug.cgi?id=172306 + +Reviewed by Michael Saboff. + +This changes B3 to emit xchg and its variants for fen
[webkit-changes] [217126] trunk/Source/WebKit2
Title: [217126] trunk/Source/WebKit2
Revision 217126
Author carlo...@webkit.org
Date 2017-05-19 07:45:49 -0700 (Fri, 19 May 2017)
Log Message
Add more input validation in Connection::processMessage()
https://bugs.webkit.org/show_bug.cgi?id=171682
Reviewed by Michael Catanzaro.
Check limits of attachments and message size. Credit to Nathan Crandall for reporting this issue and submitting
an equivalent fix.
* Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::processMessage):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (217125 => 217126)
--- trunk/Source/WebKit2/ChangeLog 2017-05-19 14:11:48 UTC (rev 217125)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-19 14:45:49 UTC (rev 217126)
@@ -1,5 +1,18 @@
2017-05-19 Carlos Garcia Campos
+Add more input validation in Connection::processMessage()
+https://bugs.webkit.org/show_bug.cgi?id=171682
+
+Reviewed by Michael Catanzaro.
+
+Check limits of attachments and message size. Credit to Nathan Crandall for reporting this issue and submitting
+an equivalent fix.
+
+* Platform/IPC/unix/ConnectionUnix.cpp:
+(IPC::Connection::processMessage):
+
+2017-05-19 Carlos Garcia Campos
+
[Threaded Compositor] Remove platform ifdefs from threaded compositor implementation
https://bugs.webkit.org/show_bug.cgi?id=172265
Modified: trunk/Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp (217125 => 217126)
--- trunk/Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp 2017-05-19 14:11:48 UTC (rev 217125)
+++ trunk/Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp 2017-05-19 14:45:49 UTC (rev 217126)
@@ -132,6 +132,11 @@
memcpy(&messageInfo, messageData, sizeof(messageInfo));
messageData += sizeof(messageInfo);
+if (messageInfo.attachmentCount() > attachmentMaxAmount || (!messageInfo.isBodyOutOfLine() && messageInfo.bodySize() > messageMaxSize)) {
+ASSERT_NOT_REACHED();
+return false;
+}
+
size_t messageLength = sizeof(MessageInfo) + messageInfo.attachmentCount() * sizeof(AttachmentInfo) + (messageInfo.isBodyOutOfLine() ? 0 : messageInfo.bodySize());
if (m_readBuffer.size() < messageLength)
return false;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217123] trunk/Source
Title: [217123] trunk/Source Revision 217123 Author carlo...@webkit.org Date 2017-05-19 05:32:44 -0700 (Fri, 19 May 2017) Log Message [Threaded Compositor] Remove platform ifdefs from threaded compositor implementation https://bugs.webkit.org/show_bug.cgi?id=172265 Reviewed by Žan Doberšek. Source/WebCore: Remove PlatformDisplayWPE::EGLTarget. * platform/graphics/wpe/PlatformDisplayWPE.cpp: * platform/graphics/wpe/PlatformDisplayWPE.h: Source/WebKit2: Add AcceleratedSurfaceWPE implementation that is equivalent to the PlatformDisplayWPE::EGLTarget. Since WPE needs the surface to be initialized/finalized in the compositing thread, two new virtual methods has been added to AcceleratedSurface initialize/finalize that are only implemented by WPE. The threaded compositor no longer receives a native surface handle as contructor parameter, it now asks the client for it from the compositing thread, right after it's created. * PlatformWPE.cmake: * Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp: (WebKit::ThreadedCompositor::create): Remove ativeSurfaceHandle parameter. (WebKit::ThreadedCompositor::ThreadedCompositor): Initialize m_nativeSurfaceHandle from the compositing thread asking the client for it. (WebKit::ThreadedCompositor::createGLContext): Remove the WPE implementation. (WebKit::ThreadedCompositor::invalidate): Notify the client that the GL context has been destroyed. (WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing): Remove GTK ifdefs. (WebKit::ThreadedCompositor::setViewportSize): Remove WPE implementation. (WebKit::ThreadedCompositor::renderLayerTree): Notify the client the frame will be rendered, and when it has been rendered. (WebKit::ThreadedCompositor::frameComplete): Remove WPE ifdefs. * Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h: * WebProcess/WebPage/AcceleratedSurface.cpp: (WebKit::AcceleratedSurface::create): Add client parameter. (WebKit::AcceleratedSurface::AcceleratedSurface): Create a AcceleratedSurfaceWPE if display is WPE. * WebProcess/WebPage/AcceleratedSurface.h: (WebKit::AcceleratedSurface::surfaceID): (WebKit::AcceleratedSurface::initialize): (WebKit::AcceleratedSurface::finalize): (WebKit::AcceleratedSurface::willRenderFrame): (WebKit::AcceleratedSurface::didRenderFrame): * WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp: (WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost): Pass this as client of AcceleratedSurface. (WebKit::ThreadedCoordinatedLayerTreeHost::frameComplete): Notify the compositor. (WebKit::ThreadedCoordinatedLayerTreeHost::nativeSurfaceHandleForCompositing): Initialize the surface and return the window handler. (WebKit::ThreadedCoordinatedLayerTreeHost::didDestroyGLContext): Finalize the surface. (WebKit::ThreadedCoordinatedLayerTreeHost::willRenderFrame): Notify the surface. (WebKit::ThreadedCoordinatedLayerTreeHost::didRenderFrame): Ditto. * WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h: * WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.cpp: (WebKit::AcceleratedSurfaceWayland::create): Add client parameter. (WebKit::AcceleratedSurfaceWayland::AcceleratedSurfaceWayland): Ditto. (WebKit::AcceleratedSurfaceWayland::didRenderFrame): Call Client::frameComplete(). * WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.h: * WebProcess/WebPage/gtk/AcceleratedSurfaceX11.cpp: (WebKit::AcceleratedSurfaceX11::create): Add client parameter. (WebKit::AcceleratedSurfaceX11::AcceleratedSurfaceX11): Ditto. (WebKit::AcceleratedSurfaceX11::didRenderFrame): Call Client::frameComplete(). * WebProcess/WebPage/gtk/AcceleratedSurfaceX11.h: * WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp: Added. (WebKit::AcceleratedSurfaceWPE::create): (WebKit::AcceleratedSurfaceWPE::AcceleratedSurfaceWPE): (WebKit::AcceleratedSurfaceWPE::~AcceleratedSurfaceWPE): (WebKit::AcceleratedSurfaceWPE::initialize): (WebKit::AcceleratedSurfaceWPE::finalize): (WebKit::AcceleratedSurfaceWPE::window): (WebKit::AcceleratedSurfaceWPE::surfaceID): (WebKit::AcceleratedSurfaceWPE::resize): (WebKit::AcceleratedSurfaceWPE::willRenderFrame): (WebKit::AcceleratedSurfaceWPE::didRenderFrame): * WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.h: Copied from Source/WebKit2/WebProcess/WebPage/gtk/AcceleratedSurfaceX11.h. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/wpe/PlatformDisplayWPE.cpp trunk/Source/WebCore/platform/graphics/wpe/PlatformDisplayWPE.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/PlatformWPE.cmake trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h trunk/Source/WebKit2/WebProcess/WebPage/AcceleratedSurface.cpp trunk/Source/WebKit2/WebProcess/WebPage/AcceleratedSurface.h trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp trunk/Source/WebKit2/Web
[webkit-changes] [217121] trunk/PerformanceTests
Title: [217121] trunk/PerformanceTests
Revision 217121
Author rn...@webkit.org
Date 2017-05-19 03:50:38 -0700 (Fri, 19 May 2017)
Log Message
Speedometer 2.0: Angular v1 test only deletes the second item
https://bugs.webkit.org/show_bug.cgi?id=172353
Reviewed by Antti Koivisto.
Like jQuery and Inferno, run querySelector after removing each todo item.
* Speedometer/InteractiveRunner.html: Tweaked CSS again.
* Speedometer/resources/tests.js:
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Speedometer/InteractiveRunner.html
trunk/PerformanceTests/Speedometer/resources/tests.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (217120 => 217121)
--- trunk/PerformanceTests/ChangeLog 2017-05-19 10:13:03 UTC (rev 217120)
+++ trunk/PerformanceTests/ChangeLog 2017-05-19 10:50:38 UTC (rev 217121)
@@ -1,5 +1,17 @@
2017-05-19 Ryosuke Niwa
+Speedometer 2.0: Angular v1 test only deletes the second item
+https://bugs.webkit.org/show_bug.cgi?id=172353
+
+Reviewed by Antti Koivisto.
+
+Like jQuery and Inferno, run querySelector after removing each todo item.
+
+* Speedometer/InteractiveRunner.html: Tweaked CSS again.
+* Speedometer/resources/tests.js:
+
+2017-05-19 Ryosuke Niwa
+
Speedometer 2.0: Elem test isn't updating DOM during the measurement
https://bugs.webkit.org/show_bug.cgi?id=172343
Modified: trunk/PerformanceTests/Speedometer/InteractiveRunner.html (217120 => 217121)
--- trunk/PerformanceTests/Speedometer/InteractiveRunner.html 2017-05-19 10:13:03 UTC (rev 217120)
+++ trunk/PerformanceTests/Speedometer/InteractiveRunner.html 2017-05-19 10:50:38 UTC (rev 217121)
@@ -10,7 +10,7 @@
ol ol { margin-left: 2em; list-position: outside; }
.running { text-decoration: underline; }
.ran { color: grey; }
-nav { position: absolute; right: 10px; max-height: 600px; }
+nav { position: absolute; right: 10px; height: 600px; }
nav > ol { height: 100%; overflow-y: scroll; }
Modified: trunk/PerformanceTests/Speedometer/resources/tests.js (217120 => 217121)
--- trunk/PerformanceTests/Speedometer/resources/tests.js 2017-05-19 10:13:03 UTC (rev 217120)
+++ trunk/PerformanceTests/Speedometer/resources/tests.js 2017-05-19 10:50:38 UTC (rev 217121)
@@ -250,9 +250,8 @@
checkboxes[i].click();
}),
new BenchmarkTestStep('DeletingAllItems', function (newTodo, contentWindow, contentDocument) {
-var deleteButtons = contentDocument.querySelectorAll('.destroy');
-for (var i = 0; i < deleteButtons.length; i++)
-deleteButtons[i].click();
+for (var i = 0; i < numberOfItemsToAdd; i++)
+contentDocument.querySelector('.destroy').click();
}),
]
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217120] trunk/Source/WTF
Title: [217120] trunk/Source/WTF
Revision 217120
Author commit-qu...@webkit.org
Date 2017-05-19 03:13:03 -0700 (Fri, 19 May 2017)
Log Message
[WTF] Remove PLATFORM(WIN) references
https://bugs.webkit.org/show_bug.cgi?id=172301
Patch by Don Olmstead on 2017-05-19
Reviewed by Yusuke Suzuki.
* wtf/MemoryPressureHandler.cpp:
* wtf/MemoryPressureHandler.h:
* wtf/Platform.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MemoryPressureHandler.cpp
trunk/Source/WTF/wtf/MemoryPressureHandler.h
trunk/Source/WTF/wtf/Platform.h
Diff
Modified: trunk/Source/WTF/ChangeLog (217119 => 217120)
--- trunk/Source/WTF/ChangeLog 2017-05-19 10:09:13 UTC (rev 217119)
+++ trunk/Source/WTF/ChangeLog 2017-05-19 10:13:03 UTC (rev 217120)
@@ -1,5 +1,16 @@
2017-05-19 Don Olmstead
+[WTF] Remove PLATFORM(WIN) references
+https://bugs.webkit.org/show_bug.cgi?id=172301
+
+Reviewed by Yusuke Suzuki.
+
+* wtf/MemoryPressureHandler.cpp:
+* wtf/MemoryPressureHandler.h:
+* wtf/Platform.h:
+
+2017-05-19 Don Olmstead
+
[CMake] Add HAVE check for __int128_t
https://bugs.webkit.org/show_bug.cgi?id=172317
Modified: trunk/Source/WTF/wtf/MemoryPressureHandler.cpp (217119 => 217120)
--- trunk/Source/WTF/wtf/MemoryPressureHandler.cpp 2017-05-19 10:09:13 UTC (rev 217119)
+++ trunk/Source/WTF/wtf/MemoryPressureHandler.cpp 2017-05-19 10:13:03 UTC (rev 217120)
@@ -277,7 +277,7 @@
m_initialMemory->physical, currentMemory->physical, physicalDiff);
}
-#if !PLATFORM(COCOA) && !OS(LINUX) && !PLATFORM(WIN)
+#if !PLATFORM(COCOA) && !OS(LINUX) && !OS(WINDOWS)
void MemoryPressureHandler::install() { }
void MemoryPressureHandler::uninstall() { }
void MemoryPressureHandler::holdOff(unsigned) { }
@@ -286,7 +286,7 @@
std::optional MemoryPressureHandler::ReliefLogger::platformMemoryUsage() { return std::nullopt; }
#endif
-#if !PLATFORM(WIN)
+#if !OS(WINDOWS)
void MemoryPressureHandler::platformInitialize() { }
#endif
Modified: trunk/Source/WTF/wtf/MemoryPressureHandler.h (217119 => 217120)
--- trunk/Source/WTF/wtf/MemoryPressureHandler.h 2017-05-19 10:09:13 UTC (rev 217119)
+++ trunk/Source/WTF/wtf/MemoryPressureHandler.h 2017-05-19 10:13:03 UTC (rev 217120)
@@ -39,7 +39,7 @@
#include
#endif
-#if PLATFORM(WIN)
+#if OS(WINDOWS)
#include
#endif
Modified: trunk/Source/WTF/wtf/Platform.h (217119 => 217120)
--- trunk/Source/WTF/wtf/Platform.h 2017-05-19 10:09:13 UTC (rev 217119)
+++ trunk/Source/WTF/wtf/Platform.h 2017-05-19 10:13:03 UTC (rev 217120)
@@ -1029,11 +1029,11 @@
since most ports try to support sub-project independence, adding new headers
to WTF causes many ports to break, and so this way we can address the build
breakages one port at a time. */
-#if !defined(USE_EXPORT_MACROS) && (PLATFORM(COCOA) || PLATFORM(WIN))
+#if !defined(USE_EXPORT_MACROS) && (PLATFORM(COCOA) || OS(WINDOWS))
#define USE_EXPORT_MACROS 1
#endif
-#if !defined(USE_EXPORT_MACROS_FOR_TESTING) && (PLATFORM(GTK) || PLATFORM(WIN))
+#if !defined(USE_EXPORT_MACROS_FOR_TESTING) && (PLATFORM(GTK) || OS(WINDOWS))
#define USE_EXPORT_MACROS_FOR_TESTING 1
#endif
@@ -1216,7 +1216,10 @@
#endif
#if WTF_DEFAULT_EVENT_LOOP
-#if PLATFORM(WIN)
+#if USE(GLIB)
+/* Use GLib's event loop abstraction. Primarily GTK port uses it. */
+#define USE_GLIB_EVENT_LOOP 1
+#elif OS(WINDOWS)
/* Use Windows message pump abstraction.
* Even if the port is AppleWin, we use the Windows message pump system for the event loop,
* so that USE(WINDOWS_EVENT_LOOP) && USE(CF) can be true.
@@ -1227,9 +1230,6 @@
#elif PLATFORM(COCOA)
/* OS X and IOS. Use CoreFoundation & GCD abstraction. */
#define USE_COCOA_EVENT_LOOP 1
-#elif USE(GLIB)
-/* Use GLib's event loop abstraction. Primarily GTK port uses it. */
-#define USE_GLIB_EVENT_LOOP 1
#else
#define USE_GENERIC_EVENT_LOOP 1
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217119] trunk/PerformanceTests
Title: [217119] trunk/PerformanceTests
Revision 217119
Author rn...@webkit.org
Date 2017-05-19 03:09:13 -0700 (Fri, 19 May 2017)
Log Message
Speedometer 2.0: Elem test isn't updating DOM during the measurement
https://bugs.webkit.org/show_bug.cgi?id=172343
Reviewed by Antti Koivisto.
Elem test wasn't doing much work because it simply enqueues items into the work queue, which doesn't get
executed until the next requestAnimationFrame or setTimeout callback happens.
Expose elm's work function as contentWindow.elemWork and make the first use of rAF a synchronous callback
just as it would when requestAnimationFrame isn't defined, and make the second use of rAF queue up to
an array of callbacks, and have the test runner manually invoke each callback.
This increases the runtime of the Elm suite from 100ms to 300ms on Safari.
* Speedometer/resources/tests.js:
(processElmWorkQueue): Added. A helper which processes Elm's work queue and manually invokes render callbacks.
* Speedometer/resources/todomvc/functional-prog-examples/elm/dist/elm.js:
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Speedometer/resources/tests.js
trunk/PerformanceTests/Speedometer/resources/todomvc/functional-prog-examples/elm/dist/elm.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (217118 => 217119)
--- trunk/PerformanceTests/ChangeLog 2017-05-19 10:05:13 UTC (rev 217118)
+++ trunk/PerformanceTests/ChangeLog 2017-05-19 10:09:13 UTC (rev 217119)
@@ -1,3 +1,23 @@
+2017-05-19 Ryosuke Niwa
+
+Speedometer 2.0: Elem test isn't updating DOM during the measurement
+https://bugs.webkit.org/show_bug.cgi?id=172343
+
+Reviewed by Antti Koivisto.
+
+Elem test wasn't doing much work because it simply enqueues items into the work queue, which doesn't get
+executed until the next requestAnimationFrame or setTimeout callback happens.
+
+Expose elm's work function as contentWindow.elemWork and make the first use of rAF a synchronous callback
+just as it would when requestAnimationFrame isn't defined, and make the second use of rAF queue up to
+an array of callbacks, and have the test runner manually invoke each callback.
+
+This increases the runtime of the Elm suite from 100ms to 300ms on Safari.
+
+* Speedometer/resources/tests.js:
+(processElmWorkQueue): Added. A helper which processes Elm's work queue and manually invokes render callbacks.
+* Speedometer/resources/todomvc/functional-prog-examples/elm/dist/elm.js:
+
2017-05-18 Ryosuke Niwa
Speedometer 2.0: Flight.js test is sometime broken
Modified: trunk/PerformanceTests/Speedometer/resources/tests.js (217118 => 217119)
--- trunk/PerformanceTests/Speedometer/resources/tests.js 2017-05-19 10:05:13 UTC (rev 217118)
+++ trunk/PerformanceTests/Speedometer/resources/tests.js 2017-05-19 10:09:13 UTC (rev 217119)
@@ -413,6 +413,18 @@
]
});
+function processElmWorkQueue(contentWindow)
+{
+contentWindow.elmWork();
+var callbacks = contentWindow.rAFCallbackList;
+var i = 0;
+while (i < callbacks.length) {
+callbacks[i]();
+i++;
+}
+contentWindow.rAFCallbackList = [];
+}
+
Suites.push({
name: 'Elm-TodoMVC',
url: 'todomvc/functional-prog-examples/elm/index.html',
@@ -430,18 +442,23 @@
bubbles: true,
cancelable: true
}));
+processElmWorkQueue(contentWindow);
triggerEnter(newTodo, 'keydown');
+processElmWorkQueue(contentWindow);
}
}),
new BenchmarkTestStep('CompletingAllItems', function (params, contentWindow, contentDocument) {
var checkboxes = contentDocument.querySelectorAll('.toggle');
-for (var i = 0; i < checkboxes.length; i++)
+for (var i = 0; i < checkboxes.length; i++) {
checkboxes[i].click();
+processElmWorkQueue(contentWindow);
+}
}),
new BenchmarkTestStep('DeletingItems', function (params, contentWindow, contentDocument) {
-var deleteButtons = contentDocument.querySelectorAll('.destroy');
-for (var i = 0; i < deleteButtons.length; i++)
-deleteButtons[i].click();
+for (var i = 0; i < numberOfItemsToAdd; i++) {
+contentDocument.querySelector('.destroy').click();
+processElmWorkQueue(contentWindow);
+}
}),
]
});
Modified: trunk/PerformanceTests/Speedometer/resources/todomvc/functional-prog-examples/elm/dist/elm.js (217118 => 217119)
--- trunk/PerformanceTests/Speedometer/resources/todomvc/functional-prog-examples/elm/dist/elm.js 2017-05-19 10:05:13 UTC (rev 217118)
+++ trunk/PerformanceTests/Speedometer/resources/todomvc/functional-prog-examples/elm/dist/elm.js 2017-05-19 10:09:13 UTC (rev 217119)
@@ -2678,8 +2678,8 @@
}
setTimeout(work
[webkit-changes] [217118] trunk/PerformanceTests
Title: [217118] trunk/PerformanceTests
Revision 217118
Author rn...@webkit.org
Date 2017-05-19 03:05:13 -0700 (Fri, 19 May 2017)
Log Message
Speedometer 2.0: Flight.js test is sometime broken
https://bugs.webkit.org/show_bug.cgi?id=172347
Reviewed by Antti Koivisto.
The bug was caused by the test runner only waiting for #new-todo, which happens before all other states are
updated in the Flight.js dependency example. As done in Speedometer v1, insert a dummy element with id set
to appIsReady and wait for this element to appear in the benchmark harness.
* Speedometer/resources/tests.js: Wait for #appIsReady.
* Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/main.js: Removed the superflous call
to console.log.
(checkReady): Added. Insert #appIsReady if checkLoaded is no longer running at 50ms interval. Because this
could happen asynchronously, we check the absense of checkLoadedTimeoutId Ωevery 10ms for 5 times for
the total duration of 50ms. If checkLoadedTimeoutId was never present, we call it ready. If we ever observed
the presence of checkLoadedTimeoutId, wait another 50ms and start over.
* Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:
(.newContext.checkLoaded): Expose checkLoadedTimeoutId which is a timer ID used to check the dependency.
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Speedometer/resources/tests.js
trunk/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/main.js
trunk/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (217117 => 217118)
--- trunk/PerformanceTests/ChangeLog 2017-05-19 10:02:12 UTC (rev 217117)
+++ trunk/PerformanceTests/ChangeLog 2017-05-19 10:05:13 UTC (rev 217118)
@@ -1,3 +1,24 @@
+2017-05-18 Ryosuke Niwa
+
+Speedometer 2.0: Flight.js test is sometime broken
+https://bugs.webkit.org/show_bug.cgi?id=172347
+
+Reviewed by Antti Koivisto.
+
+The bug was caused by the test runner only waiting for #new-todo, which happens before all other states are
+updated in the Flight.js dependency example. As done in Speedometer v1, insert a dummy element with id set
+to appIsReady and wait for this element to appear in the benchmark harness.
+
+* Speedometer/resources/tests.js: Wait for #appIsReady.
+* Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/main.js: Removed the superflous call
+to console.log.
+(checkReady): Added. Insert #appIsReady if checkLoaded is no longer running at 50ms interval. Because this
+could happen asynchronously, we check the absense of checkLoadedTimeoutId Ωevery 10ms for 5 times for
+the total duration of 50ms. If checkLoadedTimeoutId was never present, we call it ready. If we ever observed
+the presence of checkLoadedTimeoutId, wait another 50ms and start over.
+* Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:
+(.newContext.checkLoaded): Expose checkLoadedTimeoutId which is a timer ID used to check the dependency.
+
2017-05-19 Ryosuke Niwa
Speedometer 2.0: jQuery and Inferno tests don't delete all ToDo items
Modified: trunk/PerformanceTests/Speedometer/resources/tests.js (217117 => 217118)
--- trunk/PerformanceTests/Speedometer/resources/tests.js 2017-05-19 10:02:12 UTC (rev 217117)
+++ trunk/PerformanceTests/Speedometer/resources/tests.js 2017-05-19 10:05:13 UTC (rev 217118)
@@ -450,9 +450,10 @@
name: 'Flight-TodoMVC',
url: 'todomvc/dependency-examples/flight/flight/index.html',
prepare: function (runner, contentWindow, contentDocument) {
-return runner.waitForElement('#new-todo').then(function (element) {
-element.focus();
-return element;
+return runner.waitForElement('#appIsReady').then(function (element) {
+var newTodo = contentDocument.getElementById('new-todo');
+newTodo.focus();
+return newTodo;
});
},
tests: [
Modified: trunk/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/main.js (217117 => 217118)
--- trunk/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/main.js 2017-05-19 10:02:12 UTC (rev 217117)
+++ trunk/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/main.js 2017-05-19 10:05:13 UTC (rev 217118)
@@ -23,9 +23,20 @@
}
});
+function checkReady(count) {
+if (window.checkLoadedTimeoutId)
+return setTimeout(checkReady.bind(this, 0), 50);
+if (count < 5)
+return setTimeout(checkReady.bind(this, count + 1), 10);
+
+var dummyNodeToNotifyAppIsReady = document.createElement('div');
+dummyNodeToNotifyAppIsReady.
[webkit-changes] [217117] trunk/Tools
Title: [217117] trunk/Tools
Revision 217117
Author wenson_hs...@apple.com
Date 2017-05-19 03:02:12 -0700 (Fri, 19 May 2017)
Log Message
[WK1] MiniBrowser should navigate when handling a dropped URL
https://bugs.webkit.org/show_bug.cgi?id=172350
Reviewed by Tim Horton.
Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m
Diff
Modified: trunk/Tools/ChangeLog (217116 => 217117)
--- trunk/Tools/ChangeLog 2017-05-19 10:01:01 UTC (rev 217116)
+++ trunk/Tools/ChangeLog 2017-05-19 10:02:12 UTC (rev 217117)
@@ -1,3 +1,15 @@
+2017-05-19 Wenson Hsieh
+
+[WK1] MiniBrowser should navigate when handling a dropped URL
+https://bugs.webkit.org/show_bug.cgi?id=172350
+
+Reviewed by Tim Horton.
+
+Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
+
+* MiniBrowser/mac/WK1BrowserWindowController.m:
+(-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
+
2017-05-18 Ryosuke Niwa
REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
Modified: trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m (217116 => 217117)
--- trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2017-05-19 10:01:01 UTC (rev 217116)
+++ trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2017-05-19 10:02:12 UTC (rev 217117)
@@ -404,4 +404,9 @@
return response == NSAlertFirstButtonReturn;
}
+- (NSUInteger)webView:(WebView *)webView dragDestinationActionMaskForDraggingInfo:(id )draggingInfo
+{
+return WebDragDestinationActionAny;
+}
+
@end
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217116] branches/safari-604.1.21-branch/Source/WebCore
Title: [217116] branches/safari-604.1.21-branch/Source/WebCore
Revision 217116
Author jmarc...@apple.com
Date 2017-05-19 03:01:01 -0700 (Fri, 19 May 2017)
Log Message
Cherry-pick r217058. rdar://problem/32277335
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (217115 => 217116)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 10:00:58 UTC (rev 217115)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 10:01:01 UTC (rev 217116)
@@ -1,5 +1,21 @@
2017-05-19 Jason Marcell
+Cherry-pick r217058. rdar://problem/32277335
+
+2017-05-18 Youenn Fablet
+
+RealtimeOutgoingAudioSource should use the source sample rate
+https://bugs.webkit.org/show_bug.cgi?id=172297
+
+Reviewed by Eric Carlson.
+
+Covered by manual tests.
+
+* platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:
+(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable): Using the audio source sample rate so that the converter does the right conversion.
+
+2017-05-19 Jason Marcell
+
Cherry-pick r216936. rdar://problem/32278538
2017-05-16 Wenson Hsieh
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp (217115 => 217116)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp 2017-05-19 10:00:58 UTC (rev 217115)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp 2017-05-19 10:01:01 UTC (rev 217116)
@@ -93,8 +93,10 @@
status = m_sampleConverter->setOutputFormat(m_outputStreamDescription.streamDescription());
ASSERT(!status);
}
-
-m_sampleConverter->pushSamples(MediaTime(m_writeCount, LibWebRTCAudioFormat::sampleRate), audioData, sampleCount);
+
+// If we change the audio track or its sample rate changes, the timestamp based on m_writeCount may be wrong.
+// FIXME: We should update m_writeCount to be valid according the new sampleRate.
+m_sampleConverter->pushSamples(MediaTime(m_writeCount, static_cast(m_inputStreamDescription.sampleRate())), audioData, sampleCount);
m_writeCount += sampleCount;
LibWebRTCProvider::callOnWebRTCSignalingThread([protectedThis = makeRef(*this)] {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217115] branches/safari-604.1.21-branch/Source/WebCore
Title: [217115] branches/safari-604.1.21-branch/Source/WebCore
Revision 217115
Author jmarc...@apple.com
Date 2017-05-19 03:00:58 -0700 (Fri, 19 May 2017)
Log Message
Cherry-pick r216936. rdar://problem/32278538
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (217114 => 217115)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 09:54:48 UTC (rev 217114)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 10:00:58 UTC (rev 217115)
@@ -1,3 +1,25 @@
+2017-05-19 Jason Marcell
+
+Cherry-pick r216936. rdar://problem/32278538
+
+2017-05-16 Wenson Hsieh
+
+WebItemProviderPasteboard should be robust when temporary files are missing path extensions
+https://bugs.webkit.org/show_bug.cgi?id=172170
+
+Reviewed by Tim Horton.
+
+Makes a slight adjustment to the temporary file URLs are handled when using WebItemProviderPasteboard to load
+data off of item providers. Previously, we would bail early and not load any data if the temporary URL is
+missing an extension. Since the switch to NSItemProviders from UIItemProviders, some types of temporary files
+generated by item providers are missing extensions, so this extra check is meaningless.
+
+Covered by existing data interaction unit tests.
+
+* platform/ios/WebItemProviderPasteboard.mm:
+(temporaryFileURLForDataInteractionContent):
+(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:]):
+
2017-05-18 Jason Marcell
Cherry-pick r217083. rdar://problem/32282831
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm (217114 => 217115)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm 2017-05-19 09:54:48 UTC (rev 217114)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm 2017-05-19 10:00:58 UTC (rev 217115)
@@ -405,11 +405,11 @@
return numberOfFiles;
}
-static NSURL *temporaryFileURLForDataInteractionContent(NSString *fileExtension, NSString *suggestedName)
+static NSURL *temporaryFileURLForDataInteractionContent(NSURL *url, NSString *suggestedName)
{
static NSString *defaultDataInteractionFileName = @"file";
static NSString *dataInteractionDirectoryPrefix = @"data-interaction";
-if (!fileExtension.length)
+if (!url)
return nil;
NSString *temporaryDataInteractionDirectory = WebCore::createTemporaryDirectory(dataInteractionDirectoryPrefix);
@@ -416,8 +416,8 @@
if (!temporaryDataInteractionDirectory)
return nil;
-NSString *filenameWithExtension = [suggestedName ?: defaultDataInteractionFileName stringByAppendingPathExtension:fileExtension];
-return [NSURL fileURLWithPath:[temporaryDataInteractionDirectory stringByAppendingPathComponent:filenameWithExtension]];
+suggestedName = [suggestedName ?: defaultDataInteractionFileName stringByAppendingPathExtension:url.pathExtension];
+return [NSURL fileURLWithPath:[temporaryDataInteractionDirectory stringByAppendingPathComponent:url.lastPathComponent ?: suggestedName]];
}
- (void)doAfterLoadingProvidedContentIntoFileURLs:(WebItemProviderFileLoadBlock)action
@@ -483,7 +483,7 @@
// After executing this completion block, UIKit removes the file at the given URL. However, we need this data to persist longer for the web content process.
// To address this, we hard link the given URL to a new temporary file in the temporary directory. This follows the same flow as regular file upload, in
// WKFileUploadPanel.mm. The temporary files are cleaned up by the system at a later time.
-RetainPtr destinationURL = temporaryFileURLForDataInteractionContent(url.pathExtension, suggestedName.get() ?: url.lastPathComponent);
+RetainPtr destinationURL = temporaryFileURLForDataInteractionContent(url, suggestedName.get());
if (destinationURL && !error && [[NSFileManager defaultManager] linkItemAtURL:url toURL:destinationURL.get() error:nil]) {
[setFileURLsLock lock];
[typeToFileURLMaps setObject:[NSDictionary dictionaryWithObject:destinationURL.get() forKey:typeIdentifier.get()] atIndexedSubscript:indexInItemProviderArray];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217114] trunk/LayoutTests
Title: [217114] trunk/LayoutTests
Revision 217114
Author jer.no...@apple.com
Date 2017-05-19 02:54:48 -0700 (Fri, 19 May 2017)
Log Message
[MSE][Mac] Support painting MSE video-element to canvas
https://bugs.webkit.org/show_bug.cgi?id=125157
Reviewed by Eric Carlson.
* media/media-source/content/test-fragmented.mp4:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/media-source/content/test-fragmented.mp4
Diff
Modified: trunk/LayoutTests/ChangeLog (217113 => 217114)
--- trunk/LayoutTests/ChangeLog 2017-05-19 09:50:48 UTC (rev 217113)
+++ trunk/LayoutTests/ChangeLog 2017-05-19 09:54:48 UTC (rev 217114)
@@ -1,3 +1,13 @@
+2017-05-19 Jer Noble
+
+[MSE][Mac] Support painting MSE video-element to canvas
+https://bugs.webkit.org/show_bug.cgi?id=125157
+
+
+Reviewed by Eric Carlson.
+
+* media/media-source/content/test-fragmented.mp4:
+
2017-04-11 Jer Noble
[MSE][Mac] Support painting MSE video-element to canvas
Modified: trunk/LayoutTests/media/media-source/content/test-fragmented.mp4 (217113 => 217114)
--- trunk/LayoutTests/media/media-source/content/test-fragmented.mp4 2017-05-19 09:50:48 UTC (rev 217113)
+++ trunk/LayoutTests/media/media-source/content/test-fragmented.mp4 2017-05-19 09:54:48 UTC (rev 217114)
@@ -1,5 +1,5 @@
-$ftypisomisomiso2avc1iso6mp41\xABmoovlmvhd\xE8@\xD5trak\tkhd@\x80\xE0qmdia mdhdK\xC7-hdlrvideVideoHandler minfvmhd$dinf dref url \xDCstbl\x90stsd\x80avc1\x80\xE0HH\xFF\xFF*avcCM@ \xFF'M@ \xA9\xB6\xD4µ\xEF|(\xDE \xC8sttsstscstszstco\xA8trak\tkhd@Dmdia mdhd\xACD\xC7-hdlrsounSoundHandler\xEFminfsmhd$dinf dref url \xB3stblgstsdWmp4a
\xACD3esds\x80\x80\x80"\x80\x80\x80@\xE8S\x80\x80\x80\x80\x80\x80sttsstscstszstcoXmvexmehd' trex trexbudtaZmeta!hdlrmdirappl-ilst%\xA9too dataLavf56.15.102\xD8moofmfhdtraf$tfhd9\xAF b tfdt\xD8trun
-b }@D@a\xA2@,\xCF@# @>\x90@\xC1@\x8D\xEF@2@\xD2\xAD@{"@\xB0\x8C \xA8traf$tfhd9\xAF .tfdthtrun*\xCF\xED .\xD3\xFC0@ \x89Z4Du ^H;vK+$ftypisomisomiso2avc1iso6mp41\xC7moovlmvhd\xE8@trak\tkhd@\x80\xE0qmdia mdhdK\xC7-hdlrvideVideoHandler minfvmhd$dinf dref url \xDCstbl\x90stsd\x80avc1\x80\xE0
HH\xFF\xFF*avcCM@ \xFF'M@ \xA9\xB6\xD4µ\xEF|(\xDE \xC8sttsstscstszstco,edts$elst \xA8trak\tkhd@Dmdia mdhd\xACD\xC7-hdlrsounSoundHandler\xEFminfsmhd$dinf dref url \xB3stblgstsdWmp4a\xACD3esds\x80\x80\x80"\x80\x80\x80@\xE8S\x80\x80\x80\x80\x80\x80sttsstscstszstcoHmvex trex trexbudtaZmeta!hdlrmdirappl-ilst%\xA9too dataLavf56.15.102\xD8moofmfhdtraf$tfhd9\xCB b tfdt\xD8trun
+b }@D@a\xA2@,\xCF@# @>\x90@\xC1@\x8D\xEF@2@\xD2\xAD@{"@\xB0\x8C \xA8traf$tfhd9\xCB .tfdthtrun*\xCF\xED .\xD3\xFC0@ \x89Z4Du ^H;vK 9,4kPunkH\xD5\xCFnk{\x9FndT\xF5\xF6(\xEEmdat \x8D\xBB\xA0@\x80\x87\xF4N\xCD
Kܡ\x94:\xC3ԛ \x80%\xB8 !\xFF\xFF\xFE&(\xC0p,\x80\xC08@aD\xCE\xCF8\x80J[g\x80\x80 \x80`L\xB1\xF8x
Id\x96I o[\xC0/\xE0p.\xA0\xD9\xFF \x80 \x85$\x92I$\x907\xAD\x80\xE0\A\xB2\xFE\xE0
@@ -599,8 +599,8 @@
\x89f_==\x98O\xDA \x95Ԅ\xF2~\xFEf\xAA\xA0\xAB\xB0\x97\xAC c\xDFY\xDFfhW\xE2\x8D\xE9E~*\xDD\xC0! \xDD=\x98!̀w(\xB6l\x9Aqd\xA1?\xF6\x9A7\xB0\xCDo)|\xB8\xF4\xBB\xD5&\x84\xF9\xEBr\xEA \xE4\xCF Z\x91\x8E\x96g
\xA2\xC5\xC1\xBA\xE4\xD6\xD7\xDB\xFFm\xC0+T ]ғ\xD2u Of\xF3m\xD5\xC0jJ\xA6\xEC\xDB\xF9\xF6\xFFy\xA7:\xB4\xD3\xEBep\xF0\xC6mۄ\x8A*\xFC\x86Lrǯ\xBF\xC5Bey\xD6F=\xBA(\x93\x9Aq2
i\x88\x90EߜH4\xE7h{\xB6P\xD9׃\xB0\xE9\x877\xE9_uE.m\xD6\xCD\xDB9\xB2\xFCN \xB0\xC32x@O3dlG -\xC4 \x86ᛰ\x9D\xE3\xE2p#\xFF\x94\xEA;`\xC1>\L\xEFL\xF5`\x80\xE8i\xBAO\x87\xD6\x87\xFD\xAFZ\xDA \x96\xF9+v\xC4 S֖\xC05\xFEy\xEF݆\xD4pG\xAEE-ښ\x94\xF0TF\xE5\xF7\xFD\xEC\xEE\xFCݷ\xCC$r\xE9b1k\xC5P }\xB4\xA1\xB6\xA1\x91\x8C\x80eC\x8B\xE6F2\x81\xC04moofmfhdtraf$tfhd9\xD1 e5tfdtK\xD8trun
-e5 a@\xA5\xDD@\xFA@h\x96@ER@Hi@\x99@\xD6\xE1@E@\xF1\xC0@\xBB~@D\x85 traf$tfhd9\xD1jtfdt\xAF.\xC4trun+ڵjpJV\xB6\x83tj\x83\x8C\x91\x9BpKUn\x8Bp\xAB\xA1\x8F\fr\x99z\x80|f\xB8?8 \x82GHP_`J`\xB7mdat\x87\xF4N\xCD
+\xC4 \x86ᛰ\x9D\xE3\xE2p#\xFF\x94\xEA;`\xC1>\L\xEFL\xF5`\x80\xE8i\xBAO\x87\xD6\x87\xFD\xAFZ\xDA \x96\xF9+v\xC4 S֖\xC05\xFEy\xEF݆\xD4pG\xAEE-ښ\x94\xF0TF\xE5\xF7\xFD\xEC\xEE\xFCݷ\xCC$r\xE9b1k\xC5P }\xB4\xA1\xB6\xA1\x91\x8C\x80eC\x8B\xE6F2\x81\xC04moofmfhdtraf$tfhd9\xED e5tfdtK\xD8trun
+e5 a@\xA5\xDD@\xFA@h\x96@ER@Hi@\x99@\xD6\xE1@E@\xF1\xC0@\xBB~@D\x85 traf$tfhd9\xEDjtfdt\xAF.\xC4trun+ڵjpJV\x
[webkit-changes] [217113] trunk/Source/WebCore
Title: [217113] trunk/Source/WebCore Revision 217113 Author jer.no...@apple.com Date 2017-05-19 02:50:48 -0700 (Fri, 19 May 2017) Log Message Unreviewed build fix; add undefined functions and constants to the CoreMediaSoftLink.h, and use the correct (and previously soft-linked) method in WebCoreDecompressionSession. * platform/cf/CoreMediaSoftLink.cpp: * platform/cf/CoreMediaSoftLink.h: * platform/graphics/cocoa/WebCoreDecompressionSession.mm: (WebCore::WebCoreDecompressionSession::imageForTime): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/cf/CoreMediaSoftLink.cpp trunk/Source/WebCore/platform/cf/CoreMediaSoftLink.h trunk/Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm Diff Modified: trunk/Source/WebCore/ChangeLog (217112 => 217113) --- trunk/Source/WebCore/ChangeLog 2017-05-19 09:43:40 UTC (rev 217112) +++ trunk/Source/WebCore/ChangeLog 2017-05-19 09:50:48 UTC (rev 217113) @@ -1,3 +1,13 @@ +2017-05-19 Jer Noble + +Unreviewed build fix; add undefined functions and constants to the CoreMediaSoftLink.h, and use the +correct (and previously soft-linked) method in WebCoreDecompressionSession. + +* platform/cf/CoreMediaSoftLink.cpp: +* platform/cf/CoreMediaSoftLink.h: +* platform/graphics/cocoa/WebCoreDecompressionSession.mm: +(WebCore::WebCoreDecompressionSession::imageForTime): + 2017-05-19 Yusuke Suzuki [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass Modified: trunk/Source/WebCore/platform/cf/CoreMediaSoftLink.cpp (217112 => 217113) --- trunk/Source/WebCore/platform/cf/CoreMediaSoftLink.cpp 2017-05-19 09:43:40 UTC (rev 217112) +++ trunk/Source/WebCore/platform/cf/CoreMediaSoftLink.cpp 2017-05-19 09:50:48 UTC (rev 217113) @@ -55,6 +55,7 @@ SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreMedia, CMBufferQueueIsEmpty, Boolean, (CMBufferQueueRef queue), (queue)) SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreMedia, CMBufferQueueGetBufferCount, CMItemCount, (CMBufferQueueRef queue), (queue)) SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreMedia, CMBufferQueueGetFirstPresentationTimeStamp, CMTime, (CMBufferQueueRef queue), (queue)) +SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreMedia, CMBufferQueueGetEndPresentationTimeStamp, CMTime, (CMBufferQueueRef queue), (queue)) SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreMedia, CMBufferQueueInstallTriggerWithIntegerThreshold, OSStatus, (CMBufferQueueRef queue, CMBufferQueueTriggerCallback triggerCallback, void* triggerRefcon, CMBufferQueueTriggerCondition triggerCondition, CMItemCount triggerThreshold, CMBufferQueueTriggerToken* triggerTokenOut), (queue, triggerCallback, triggerRefcon, triggerCondition, triggerThreshold, triggerTokenOut)) SOFT_LINK_CONSTANT_FOR_SOURCE(WebCore, CoreMedia, kCMFormatDescriptionExtension_SampleDescriptionExtensionAtoms, CFStringRef) @@ -79,6 +80,7 @@ SOFT_LINK_CONSTANT_FOR_SOURCE(WebCore, CoreMedia, kCMTextVerticalLayout_RightToLeft, CFStringRef) SOFT_LINK_CONSTANT_FOR_SOURCE(WebCore, CoreMedia, kCMTimeInvalid, CMTime) SOFT_LINK_CONSTANT_FOR_SOURCE(WebCore, CoreMedia, kCMTimeZero, CMTime) +SOFT_LINK_CONSTANT_FOR_SOURCE(WebCore, CoreMedia, kCMTimePositiveInfinity, CMTime) #if PLATFORM(COCOA) SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreMedia, CMFormatDescriptionGetMediaSubType, FourCharCode, (CMFormatDescriptionRef desc), (desc)) Modified: trunk/Source/WebCore/platform/cf/CoreMediaSoftLink.h (217112 => 217113) --- trunk/Source/WebCore/platform/cf/CoreMediaSoftLink.h 2017-05-19 09:43:40 UTC (rev 217112) +++ trunk/Source/WebCore/platform/cf/CoreMediaSoftLink.h 2017-05-19 09:50:48 UTC (rev 217113) @@ -79,6 +79,8 @@ #define CMBufferQueueGetBufferCount softLink_CoreMedia_CMBufferQueueGetBufferCount SOFT_LINK_FUNCTION_FOR_HEADER(WebCore, CoreMedia, CMBufferQueueGetFirstPresentationTimeStamp, CMTime, (CMBufferQueueRef queue), (queue)) #define CMBufferQueueGetFirstPresentationTimeStamp softLink_CoreMedia_CMBufferQueueGetFirstPresentationTimeStamp +SOFT_LINK_FUNCTION_FOR_HEADER(WebCore, CoreMedia, CMBufferQueueGetEndPresentationTimeStamp, CMTime, (CMBufferQueueRef queue), (queue)) +#define CMBufferQueueGetEndPresentationTimeStamp softLink_CoreMedia_CMBufferQueueGetEndPresentationTimeStamp SOFT_LINK_FUNCTION_FOR_HEADER(WebCore, CoreMedia, CMBufferQueueInstallTriggerWithIntegerThreshold, OSStatus, (CMBufferQueueRef queue, CMBufferQueueTriggerCallback triggerCallback, void* triggerRefcon, CMBufferQueueTriggerCondition triggerCondition, CMItemCount triggerThreshold, CMBufferQueueTriggerToken* triggerTokenOut), (queue, triggerCallback, triggerRefcon, triggerCondition, triggerThreshold, triggerTokenOut)) #define CMBufferQueueInstallTriggerWithIntegerThreshold softLink_CoreMedia_CMBufferQueueInstallTriggerWithIntegerThreshold @@ -126,6 +128,8 @@ #define kCMTimeInvalid get_CoreMedia_kCMTimeInvalid() SOFT_LINK_CONSTANT_FOR_HEADER(WebCore, CoreMedia, kCMTimeZero, CMTime) #define kCMTimeZero get_CoreMedia_kCMTimeZer
[webkit-changes] [217112] trunk/PerformanceTests
Title: [217112] trunk/PerformanceTests
Revision 217112
Author rn...@webkit.org
Date 2017-05-19 02:43:40 -0700 (Fri, 19 May 2017)
Log Message
Speedometer 2.0: jQuery and Inferno tests don't delete all ToDo items
https://bugs.webkit.org/show_bug.cgi?id=172341
Reviewed by Antti Koivisto.
The bug was caused by the fact TodoMVC examples for jQuery and Inferno JS create a new button
to delete the todo item each time todo items are rendered.
Fixed the bug by dynamically look for .destroy using querySelector for each item.
Also moved the deletion of the iframe from the end of each test suite to the beginning of each suite.
This will make debugging the issue like this easier on InteractiveRunner.html since the iframe
will stick around after stepping the last item in the suite.
* Speedometer/InteractiveRunner.html: Tweaked the CSS to make buttons to "Step" and "Run" always visible
even if the list of suites and subtests are too long to fit in the viewport.
* Speedometer/resources/benchmark-runner.js:
(BenchmarkRunner.prototype.step):
(BenchmarkRunner.prototype._runTestAndRecordResults):
* Speedometer/resources/tests.js: Fixed the bug for jQuery and Inferno. In the case of jQuery
we also have to fix the code for checking every ToDo item as completed as well.
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Speedometer/InteractiveRunner.html
trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js
trunk/PerformanceTests/Speedometer/resources/tests.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (217111 => 217112)
--- trunk/PerformanceTests/ChangeLog 2017-05-19 09:41:23 UTC (rev 217111)
+++ trunk/PerformanceTests/ChangeLog 2017-05-19 09:43:40 UTC (rev 217112)
@@ -1,5 +1,31 @@
2017-05-19 Ryosuke Niwa
+Speedometer 2.0: jQuery and Inferno tests don't delete all ToDo items
+https://bugs.webkit.org/show_bug.cgi?id=172341
+
+Reviewed by Antti Koivisto.
+
+The bug was caused by the fact TodoMVC examples for jQuery and Inferno JS create a new button
+to delete the todo item each time todo items are rendered.
+
+Fixed the bug by dynamically look for .destroy using querySelector for each item.
+
+Also moved the deletion of the iframe from the end of each test suite to the beginning of each suite.
+This will make debugging the issue like this easier on InteractiveRunner.html since the iframe
+will stick around after stepping the last item in the suite.
+
+* Speedometer/InteractiveRunner.html: Tweaked the CSS to make buttons to "Step" and "Run" always visible
+even if the list of suites and subtests are too long to fit in the viewport.
+
+* Speedometer/resources/benchmark-runner.js:
+(BenchmarkRunner.prototype.step):
+(BenchmarkRunner.prototype._runTestAndRecordResults):
+
+* Speedometer/resources/tests.js: Fixed the bug for jQuery and Inferno. In the case of jQuery
+we also have to fix the code for checking every ToDo item as completed as well.
+
+2017-05-19 Ryosuke Niwa
+
Speedometer 2.0: Vanilla JS test doesn't mark all todo items as completed
https://bugs.webkit.org/show_bug.cgi?id=172348
Modified: trunk/PerformanceTests/Speedometer/InteractiveRunner.html (217111 => 217112)
--- trunk/PerformanceTests/Speedometer/InteractiveRunner.html 2017-05-19 09:41:23 UTC (rev 217111)
+++ trunk/PerformanceTests/Speedometer/InteractiveRunner.html 2017-05-19 09:43:40 UTC (rev 217112)
@@ -10,7 +10,8 @@
ol ol { margin-left: 2em; list-position: outside; }
.running { text-decoration: underline; }
.ran { color: grey; }
-nav { position: absolute; right: 10px; }
+nav { position: absolute; right: 10px; max-height: 600px; }
+nav > ol { height: 100%; overflow-y: scroll; }
Modified: trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js (217111 => 217112)
--- trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js 2017-05-19 09:41:23 UTC (rev 217111)
+++ trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js 2017-05-19 09:43:40 UTC (rev 217112)
@@ -192,6 +192,7 @@
}
if (state.isFirstTest()) {
+this._removeFrame();
this._masuredValuesForCurrentSuite = {};
var self = this;
return state.prepareCurrentSuite(this, this._appendFrame()).then(function (prepareReturnValue) {
@@ -251,8 +252,6 @@
self._client.didRunTest(suite, test);
state.next();
-if (state.currentSuite() != suite)
-self._removeFrame();
promise.resolve(state);
});
}, 0);
Modified: trunk/PerformanceTests/Speedometer/resources/tests.js (217111 => 217112)
--- trunk/PerformanceTests/Speedometer/resources/tests.js 2017-05-19 09:41:23 UTC (rev 217111)
+++ trunk/PerformanceTests/Speedometer/resources/tests.js 2017-05-19 09:43:40 UTC (rev 217112)
@@ -340,14 +340,13 @@
}
}),
new Benchma
[webkit-changes] [217111] trunk/LayoutTests
Title: [217111] trunk/LayoutTests
Revision 217111
Author jer.no...@apple.com
Date 2017-05-19 02:41:23 -0700 (Fri, 19 May 2017)
Log Message
[MSE][Mac] Support painting MSE video-element to canvas
https://bugs.webkit.org/show_bug.cgi?id=125157
Reviewed by Eric Carlson.
* media/media-source/content/test-fragmented.mp4: Add a 'edts' atom to move the presentation time for the
first sample to 0:00.
* media/media-source/media-source-paint-to-canvas-expected.txt: Added.
* media/media-source/media-source-paint-to-canvas.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/media/media-source/media-source-paint-to-canvas-expected.txt
trunk/LayoutTests/media/media-source/media-source-paint-to-canvas.html
Diff
Modified: trunk/LayoutTests/ChangeLog (217110 => 217111)
--- trunk/LayoutTests/ChangeLog 2017-05-19 09:39:51 UTC (rev 217110)
+++ trunk/LayoutTests/ChangeLog 2017-05-19 09:41:23 UTC (rev 217111)
@@ -1,3 +1,16 @@
+2017-04-11 Jer Noble
+
+[MSE][Mac] Support painting MSE video-element to canvas
+https://bugs.webkit.org/show_bug.cgi?id=125157
+
+
+Reviewed by Eric Carlson.
+
+* media/media-source/content/test-fragmented.mp4: Add a 'edts' atom to move the presentation time for the
+first sample to 0:00.
+* media/media-source/media-source-paint-to-canvas-expected.txt: Added.
+* media/media-source/media-source-paint-to-canvas.html: Added.
+
2017-05-19 Zan Dobersek
Unreviewed GTK+ gardening.
Added: trunk/LayoutTests/media/media-source/media-source-paint-to-canvas-expected.txt (0 => 217111)
--- trunk/LayoutTests/media/media-source/media-source-paint-to-canvas-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-paint-to-canvas-expected.txt 2017-05-19 09:41:23 UTC (rev 217111)
@@ -0,0 +1,12 @@
+EVENT(sourceopen)
+EVENT(update)
+EVENT(canplay)
+EXPECTED (canvas.getContext("2d").getImageData(250, 130, 1, 1).data[0] != '0') OK
+RUN(video.currentTime += 1.001 / 24)
+EVENT(seeked)
+EXPECTED (canvas.getContext("2d").getImageData(250, 130, 1, 1).data[0] != '0') OK
+RUN(video.currentTime += 1.001 / 24)
+EVENT(seeked)
+EXPECTED (canvas.getContext("2d").getImageData(250, 130, 1, 1).data[0] != '0') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/media-source/media-source-paint-to-canvas.html (0 => 217111)
--- trunk/LayoutTests/media/media-source/media-source-paint-to-canvas.html (rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-paint-to-canvas.html 2017-05-19 09:41:23 UTC (rev 217111)
@@ -0,0 +1,74 @@
+
+
+
+media-source-stalled-holds-sleep-assertion
+
+
+var canvas;
+var loader;
+var source;
+var sourceBuffer;
+
+function runTest() {
+mediaElement = video = document.createElement('video');
+
+loader = new MediaSourceLoader('content/test-fragmented-manifest.json');
+loader._onload_ = mediaDataLoaded;
+loader._onerror_ = mediaDataLoadingFailed;
+}
+
+function mediaDataLoadingFailed() {
+failTest('Media data loading failed');
+}
+
+function mediaDataLoaded() {
+source = new MediaSource();
+waitForEvent('sourceopen', sourceOpen, false, false, source);
+video.src = ""
+}
+
+function sourceOpen() {
+source.duration = loader.duration();
+sourceBuffer = source.addSourceBuffer(loader.type());
+waitForEventOn(sourceBuffer, 'update', sourceInitialized, false, true);
+sourceBuffer.appendBuffer(loader.initSegment());
+}
+
+function sourceInitialized() {
+waitForEvent('canplay', canPlay, false, true);
+sourceBuffer.appendBuffer(loader.mediaSegment(0));
+}
+
+function paint() {
+canvas = document.createElement('canvas');
+canvas.width = video.videoWidth / 2;
+canvas.height = video.videoHeight / 2;
+canvas.getContext('2d').drawImage(video, 0, 0, canvas.width, canvas.height);
+document.getElementById('canvases').appendChild(canvas);
+testExpected('canvas.getContext("2d").getImageData(250, 130, 1, 1).data[0]', '0', '!=');
+}
+
+function canPlay() {
+paint();
+waitForEvent('seeked', seeked1, false, true);
+run('video.currentTime += 1.001 / 24');
+}
+
+function seeked1() {
+paint();
+waitForEvent('seeked', seeked2, false, true);
+run('video.currentTime += 1.001 / 24');
+}
+
+function seeked2() {
+paint();
+endTest();
+}
+
+
+
+
+
+
\ No newline at end of file
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217109] trunk/Source/JavaScriptCore
Title: [217109] trunk/Source/_javascript_Core
Revision 217109
Author commit-qu...@webkit.org
Date 2017-05-19 02:39:28 -0700 (Fri, 19 May 2017)
Log Message
[JSC] Remove PLATFORM(WIN) references
https://bugs.webkit.org/show_bug.cgi?id=172294
Patch by Don Olmstead on 2017-05-19
Reviewed by Yusuke Suzuki.
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::removeThread):
* llint/LLIntOfflineAsmConfig.h:
* runtime/ConfigFile.h:
* runtime/VM.cpp:
(JSC::VM::updateStackLimits):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp
trunk/Source/_javascript_Core/llint/LLIntOfflineAsmConfig.h
trunk/Source/_javascript_Core/runtime/ConfigFile.h
trunk/Source/_javascript_Core/runtime/VM.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (217108 => 217109)
--- trunk/Source/_javascript_Core/ChangeLog 2017-05-19 09:23:20 UTC (rev 217108)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-05-19 09:39:28 UTC (rev 217109)
@@ -1,3 +1,17 @@
+2017-05-19 Don Olmstead
+
+[JSC] Remove PLATFORM(WIN) references
+https://bugs.webkit.org/show_bug.cgi?id=172294
+
+Reviewed by Yusuke Suzuki.
+
+* heap/MachineStackMarker.cpp:
+(JSC::MachineThreads::removeThread):
+* llint/LLIntOfflineAsmConfig.h:
+* runtime/ConfigFile.h:
+* runtime/VM.cpp:
+(JSC::VM::updateStackLimits):
+
2017-05-19 Yusuke Suzuki
[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
Modified: trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp (217108 => 217109)
--- trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2017-05-19 09:23:20 UTC (rev 217108)
+++ trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2017-05-19 09:39:28 UTC (rev 217109)
@@ -162,7 +162,7 @@
// may not be found in this MachineThreads registry. We only need to
// do a removal if this thread is found in it.
-#if PLATFORM(WIN)
+#if OS(WINDOWS)
// On Windows the thread specific destructor is also called when the
// main thread is exiting. This may lead to the main thread waiting
// forever for the machine thread lock when exiting, if the sampling
Modified: trunk/Source/_javascript_Core/llint/LLIntOfflineAsmConfig.h (217108 => 217109)
--- trunk/Source/_javascript_Core/llint/LLIntOfflineAsmConfig.h 2017-05-19 09:23:20 UTC (rev 217108)
+++ trunk/Source/_javascript_Core/llint/LLIntOfflineAsmConfig.h 2017-05-19 09:39:28 UTC (rev 217109)
@@ -48,13 +48,13 @@
#define OFFLINE_ASM_C_LOOP 0
-#if CPU(X86) && !PLATFORM(WIN)
+#if CPU(X86) && !COMPILER(MSVC)
#define OFFLINE_ASM_X86 1
#else
#define OFFLINE_ASM_X86 0
#endif
-#if CPU(X86) && PLATFORM(WIN)
+#if CPU(X86) && COMPILER(MSVC)
#define OFFLINE_ASM_X86_WIN 1
#else
#define OFFLINE_ASM_X86_WIN 0
@@ -91,13 +91,13 @@
#define OFFLINE_ASM_ARM 0
#endif
-#if CPU(X86_64) && !PLATFORM(WIN)
+#if CPU(X86_64) && !COMPILER(MSVC)
#define OFFLINE_ASM_X86_64 1
#else
#define OFFLINE_ASM_X86_64 0
#endif
-#if CPU(X86_64) && PLATFORM(WIN)
+#if CPU(X86_64) && COMPILER(MSVC)
#define OFFLINE_ASM_X86_64_WIN 1
#else
#define OFFLINE_ASM_X86_64_WIN 0
Modified: trunk/Source/_javascript_Core/runtime/ConfigFile.h (217108 => 217109)
--- trunk/Source/_javascript_Core/runtime/ConfigFile.h 2017-05-19 09:23:20 UTC (rev 217108)
+++ trunk/Source/_javascript_Core/runtime/ConfigFile.h 2017-05-19 09:39:28 UTC (rev 217109)
@@ -40,7 +40,7 @@
private:
void canonicalizePaths();
-#if PLATFORM(WIN)
+#if OS(WINDOWS)
static const size_t s_maxPathLength = 260; // Windows value for "MAX_PATH"
#else
static const size_t s_maxPathLength = PATH_MAX;
Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (217108 => 217109)
--- trunk/Source/_javascript_Core/runtime/VM.cpp 2017-05-19 09:23:20 UTC (rev 217108)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp 2017-05-19 09:39:28 UTC (rev 217109)
@@ -652,7 +652,7 @@
return oldSoftReservedZoneSize;
}
-#if PLATFORM(WIN)
+#if OS(WINDOWS)
// On Windows the reserved stack space consists of committed memory, a guard page, and uncommitted memory,
// where the guard page is a barrier between committed and uncommitted memory.
// When data from the guard page is read or written, the guard page is moved, and memory is committed.
@@ -679,7 +679,7 @@
inline void VM::updateStackLimits()
{
-#if PLATFORM(WIN)
+#if OS(WINDOWS)
void* lastSoftStackLimit = m_softStackLimit;
#endif
@@ -694,7 +694,7 @@
m_stackLimit = wtfThreadData().stack().recursionLimit(reservedZoneSize);
}
-#if PLATFORM(WIN)
+#if OS(WINDOWS)
// We only need to precommit stack memory dictated by the VM::m_softStackLimit limit.
// This is because VM::m_softStackLimit applies to stack usage by LLINT asm or JIT
// generated code which can allocate stack space that the C++ compiler does not know
___
webkit-changes mailing list
webkit-ch
[webkit-changes] [217110] branches/safari-604.1.21-branch/Source/WebCore
Title: [217110] branches/safari-604.1.21-branch/Source/WebCore
Revision 217110
Author jmarc...@apple.com
Date 2017-05-19 02:39:51 -0700 (Fri, 19 May 2017)
Log Message
Cherry-pick r217083. rdar://problem/32282831
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/page/DragController.cpp
branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderAttachment.h
branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderThemeIOS.mm
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (217109 => 217110)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 09:39:28 UTC (rev 217109)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 09:39:51 UTC (rev 217110)
@@ -1,3 +1,23 @@
+2017-05-18 Jason Marcell
+
+Cherry-pick r217083. rdar://problem/32282831
+
+2017-05-18 Wenson Hsieh
+
+Attachment drag preview should not have the attachment outline
+https://bugs.webkit.org/show_bug.cgi?id=172327
+
+
+Reviewed by Tim Horton.
+
+When creating a drag image for an attachment element, don't include borders around the attachment.
+
+* page/DragController.cpp:
+(WebCore::DragController::startDrag):
+* rendering/RenderAttachment.h:
+* rendering/RenderThemeIOS.mm:
+(WebCore::RenderThemeIOS::paintAttachment):
+
2017-05-18 Youenn Fablet
Media Capture: MobileSafari crashes when trying to invoke gUM.
Modified: branches/safari-604.1.21-branch/Source/WebCore/page/DragController.cpp (217109 => 217110)
--- branches/safari-604.1.21-branch/Source/WebCore/page/DragController.cpp 2017-05-19 09:39:28 UTC (rev 217109)
+++ branches/safari-604.1.21-branch/Source/WebCore/page/DragController.cpp 2017-05-19 09:39:51 UTC (rev 217110)
@@ -65,6 +65,7 @@
#include "PluginDocument.h"
#include "PluginViewBase.h"
#include "Position.h"
+#include "RenderAttachment.h"
#include "RenderFileUploadControl.h"
#include "RenderImage.h"
#include "RenderView.h"
@@ -1060,6 +1061,10 @@
#if ENABLE(ATTACHMENT_ELEMENT)
if (is(element) && m_dragSourceAction & DragSourceActionAttachment) {
+auto* attachmentRenderer = downcast(element).renderer();
+if (!attachmentRenderer)
+return false;
+
src.editor().setIgnoreSelectionChanges(true);
auto previousSelection = src.selection().selection();
if (!dataTransfer.pasteboard().hasData()) {
@@ -1083,7 +1088,9 @@
if (!dragImage) {
TextIndicatorData textIndicator;
+attachmentRenderer->setShouldDrawBorder(false);
dragImage = DragImage { dissolveDragImageToFraction(createDragImageForSelection(src, textIndicator), DragImageAlpha) };
+attachmentRenderer->setShouldDrawBorder(true);
if (textIndicator.contentImage)
dragImage.setIndicatorData(textIndicator);
dragLoc = dragLocForSelectionDrag(src);
Modified: branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderAttachment.h (217109 => 217110)
--- branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderAttachment.h 2017-05-19 09:39:28 UTC (rev 217109)
+++ branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderAttachment.h 2017-05-19 09:39:51 UTC (rev 217110)
@@ -38,6 +38,9 @@
HTMLAttachmentElement& attachmentElement() const;
+void setShouldDrawBorder(bool drawBorder) { m_shouldDrawBorder = drawBorder; }
+bool shouldDrawBorder() const { return m_shouldDrawBorder; }
+
void invalidate();
private:
@@ -52,6 +55,7 @@
int baselinePosition(FontBaseline, bool, LineDirectionMode, LinePositionMode) const override;
LayoutUnit m_minimumIntrinsicWidth;
+bool m_shouldDrawBorder { true };
};
inline RenderAttachment* HTMLAttachmentElement::renderer() const
Modified: branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderThemeIOS.mm (217109 => 217110)
--- branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderThemeIOS.mm 2017-05-19 09:39:28 UTC (rev 217109)
+++ branches/safari-604.1.21-branch/Source/WebCore/rendering/RenderThemeIOS.mm 2017-05-19 09:39:51 UTC (rev 217110)
@@ -1771,9 +1771,11 @@
context.translate(toFloatSize(paintRect.location()));
-Path borderPath = attachmentBorderPath(info);
-paintAttachmentBorder(context, borderPath);
-context.clipPath(borderPath);
+if (attachment.shouldDrawBorder()) {
+auto borderPath = attachmentBorderPath(info);
+paintAttachmentBorder(context, borderPath);
+context.clipPath(borderPath);
+}
context.translate(FloatSize(0, info.contentYOrigin));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217107] trunk/PerformanceTests
Title: [217107] trunk/PerformanceTests
Revision 217107
Author rn...@webkit.org
Date 2017-05-19 02:19:01 -0700 (Fri, 19 May 2017)
Log Message
Speedometer 2.0: Vanilla JS test doesn't mark all todo items as completed
https://bugs.webkit.org/show_bug.cgi?id=172348
Reviewed by Antti Koivisto.
The bug was caused by the in-memory store class using the milisecond precision timestamp as an ID.
Because we inserts 50 items all at once, this can result in multiple data items sharing a single ID.
Fixed the bug by using a mononotically increasing ID instead.
* Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js:
(Store.prototype.save):
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (217106 => 217107)
--- trunk/PerformanceTests/ChangeLog 2017-05-19 09:11:47 UTC (rev 217106)
+++ trunk/PerformanceTests/ChangeLog 2017-05-19 09:19:01 UTC (rev 217107)
@@ -1,3 +1,18 @@
+2017-05-19 Ryosuke Niwa
+
+Speedometer 2.0: Vanilla JS test doesn't mark all todo items as completed
+https://bugs.webkit.org/show_bug.cgi?id=172348
+
+Reviewed by Antti Koivisto.
+
+The bug was caused by the in-memory store class using the milisecond precision timestamp as an ID.
+Because we inserts 50 items all at once, this can result in multiple data items sharing a single ID.
+
+Fixed the bug by using a mononotically increasing ID instead.
+
+* Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js:
+(Store.prototype.save):
+
2017-05-18 Ryosuke Niwa
REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
Modified: trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js (217106 => 217107)
--- trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js 2017-05-19 09:11:47 UTC (rev 217106)
+++ trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js 2017-05-19 09:19:01 UTC (rev 217107)
@@ -3,6 +3,8 @@
'use strict';
var MemoryStorage = {};
+var id = 1;
+
/**
* Creates a new client side storage object and will create an empty
* collection if no collection already exists.
@@ -96,7 +98,7 @@
callback.call(this, todos);
} else {
// Generate an ID
-updateData.id = new Date().getTime();
+updateData.id = id++;
todos.push(updateData);
MemoryStorage[this._dbName] = JSON.stringify(data);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217105] trunk
Title: [217105] trunk
Revision 217105
Author commit-qu...@webkit.org
Date 2017-05-19 01:58:30 -0700 (Fri, 19 May 2017)
Log Message
[CMake] Add HAVE check for __int128_t
https://bugs.webkit.org/show_bug.cgi?id=172317
Patch by Don Olmstead on 2017-05-19
Reviewed by Yusuke Suzuki.
.:
* Source/cmake/OptionsCommon.cmake:
Source/WTF:
* wtf/MediaTime.cpp:
(WTF::MediaTime::setTimeScale):
* wtf/Platform.h:
Modified Paths
trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MediaTime.cpp
trunk/Source/WTF/wtf/Platform.h
trunk/Source/cmake/OptionsCommon.cmake
Diff
Modified: trunk/ChangeLog (217104 => 217105)
--- trunk/ChangeLog 2017-05-19 08:27:18 UTC (rev 217104)
+++ trunk/ChangeLog 2017-05-19 08:58:30 UTC (rev 217105)
@@ -1,3 +1,12 @@
+2017-05-19 Don Olmstead
+
+[CMake] Add HAVE check for __int128_t
+https://bugs.webkit.org/show_bug.cgi?id=172317
+
+Reviewed by Yusuke Suzuki.
+
+* Source/cmake/OptionsCommon.cmake:
+
2017-05-16 Zan Dobersek
[WPE] Set and expose ENABLE_DEVELOPER_MODE in build when DEVELOPER_MODE is enabled
Modified: trunk/Source/WTF/ChangeLog (217104 => 217105)
--- trunk/Source/WTF/ChangeLog 2017-05-19 08:27:18 UTC (rev 217104)
+++ trunk/Source/WTF/ChangeLog 2017-05-19 08:58:30 UTC (rev 217105)
@@ -1,3 +1,14 @@
+2017-05-19 Don Olmstead
+
+[CMake] Add HAVE check for __int128_t
+https://bugs.webkit.org/show_bug.cgi?id=172317
+
+Reviewed by Yusuke Suzuki.
+
+* wtf/MediaTime.cpp:
+(WTF::MediaTime::setTimeScale):
+* wtf/Platform.h:
+
2017-05-18 Andreas Kling
[WK2] Notify WebPageProxy client when an active process goes over the inactive memory limit
Modified: trunk/Source/WTF/wtf/MediaTime.cpp (217104 => 217105)
--- trunk/Source/WTF/wtf/MediaTime.cpp 2017-05-19 08:27:18 UTC (rev 217104)
+++ trunk/Source/WTF/wtf/MediaTime.cpp 2017-05-19 08:58:30 UTC (rev 217105)
@@ -489,7 +489,7 @@
timeScale = std::min(MaximumTimeScale, timeScale);
-#if !PLATFORM(WIN) && (CPU(X86_64) || CPU(ARM64))
+#if HAVE(INT128_T)
__int128_t newValue = static_cast<__int128_t>(m_timeValue) * timeScale;
int64_t remainder = newValue % m_timeScale;
newValue = newValue / m_timeScale;
Modified: trunk/Source/WTF/wtf/Platform.h (217104 => 217105)
--- trunk/Source/WTF/wtf/Platform.h 2017-05-19 08:27:18 UTC (rev 217104)
+++ trunk/Source/WTF/wtf/Platform.h 2017-05-19 08:58:30 UTC (rev 217105)
@@ -648,6 +648,10 @@
#define HAVE_TM_GMTOFF 1
#define HAVE_TM_ZONE 1
#define HAVE_TIMEGM 1
+
+#if CPU(X86_64) || CPU(ARM64)
+#define HAVE_INT128_T 1
+#endif
#endif /* OS(DARWIN) */
#if OS(UNIX)
Modified: trunk/Source/cmake/OptionsCommon.cmake (217104 => 217105)
--- trunk/Source/cmake/OptionsCommon.cmake 2017-05-19 08:27:18 UTC (rev 217104)
+++ trunk/Source/cmake/OptionsCommon.cmake 2017-05-19 08:58:30 UTC (rev 217105)
@@ -228,6 +228,7 @@
include(CheckFunctionExists)
include(CheckSymbolExists)
include(CheckStructHasMember)
+include(CheckTypeSize)
macro(_HAVE_CHECK_INCLUDE _variable _header)
check_include_file(${_header} ${_variable}_value)
@@ -280,3 +281,10 @@
_HAVE_CHECK_STRUCT(HAVE_STAT_BIRTHTIME "struct stat" st_birthtime sys/stat.h)
_HAVE_CHECK_STRUCT(HAVE_TM_GMTOFF "struct tm" tm_gmtoff time.h)
_HAVE_CHECK_STRUCT(HAVE_TM_ZONE "struct tm" tm_zone time.h)
+
+# Check for int types
+check_type_size("__int128_t" INT128_VALUE)
+
+if (HAVE_INT128_VALUE)
+ SET_AND_EXPOSE_TO_BUILD(HAVE_INT128_T INT128_VALUE)
+endif ()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217104] branches/safari-604.1.21-branch/Source
Title: [217104] branches/safari-604.1.21-branch/Source
Revision 217104
Author jmarc...@apple.com
Date 2017-05-19 01:27:18 -0700 (Fri, 19 May 2017)
Log Message
Cherry-pick r216952, r216991. rdar://problem/32261722
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h
branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog
branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionCheckProxy.cpp
branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionCheckProxy.h
branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (217103 => 217104)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 08:04:16 UTC (rev 217103)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 08:27:18 UTC (rev 217104)
@@ -1,3 +1,12 @@
+2017-05-18 Youenn Fablet
+
+Media Capture: MobileSafari crashes when trying to invoke gUM.
+rdar://problem/32261722.
+
+Reduced version of r216952.
+
+* platform/mediastream/RealtimeMediaSourceCenter.h: Using more WTF::Function.
+
2017-05-18 Jason Marcell
Cherry-pick r217074. rdar://problem/32282945
Modified: branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h (217103 => 217104)
--- branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h 2017-05-19 08:04:16 UTC (rev 217103)
+++ branches/safari-604.1.21-branch/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h 2017-05-19 08:27:18 UTC (rev 217104)
@@ -36,6 +36,7 @@
#include "ExceptionOr.h"
#include "RealtimeMediaSource.h"
#include "RealtimeMediaSourceSupportedConstraints.h"
+#include
#include
#include
@@ -55,8 +56,8 @@
WEBCORE_EXPORT static RealtimeMediaSourceCenter& singleton();
static void setSharedStreamCenterOverride(RealtimeMediaSourceCenter*);
-using ValidConstraintsHandler = std::function&& audioDeviceUIDs, const Vector&& videoDeviceUIDs)>;
-using InvalidConstraintsHandler = std::function;
+using ValidConstraintsHandler = WTF::Function& audioDeviceUIDs, const Vector& videoDeviceUIDs)>;
+using InvalidConstraintsHandler = WTF::Function;
virtual void validateRequestConstraints(ValidConstraintsHandler&&, InvalidConstraintsHandler&&, const MediaConstraints& audioConstraints, const MediaConstraints& videoConstraints);
using NewMediaStreamHandler = std::function&&)>;
Modified: branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog (217103 => 217104)
--- branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-19 08:04:16 UTC (rev 217103)
+++ branches/safari-604.1.21-branch/Source/WebKit2/ChangeLog 2017-05-19 08:27:18 UTC (rev 217104)
@@ -1,3 +1,17 @@
+2017-05-18 Youenn Fablet
+
+Media Capture: MobileSafari crashes when trying to invoke gUM.
+rdar://problem/32261722.
+
+Reduced version of r216952.
+
+* UIProcess/UserMediaPermissionCheckProxy.cpp:
+(WebKit::UserMediaPermissionCheckProxy::failed): Added to not require copy the completionHandler.
+* UIProcess/UserMediaPermissionCheckProxy.h: Moving completion handle to WTF::Function to better handle moves.
+* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
+(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Using failed() to not copy the handler.
+
2017-05-17 Jason Marcell
Cherry-pick r216898. rdar://problem/32231650
Modified: branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionCheckProxy.cpp (217103 => 217104)
--- branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionCheckProxy.cpp 2017-05-19 08:04:16 UTC (rev 217103)
+++ branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionCheckProxy.cpp 2017-05-19 08:27:18 UTC (rev 217104)
@@ -52,6 +52,15 @@
m_completionHandler = nullptr;
}
+void UserMediaPermissionCheckProxy::failed()
+{
+if (!m_completionHandler)
+return;
+
+m_completionHandler(m_userMediaID, { }, false);
+m_completionHandler = nullptr;
+}
+
void UserMediaPermissionCheckProxy::invalidate()
{
m_completionHandler = nullptr;
Modified: branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionCheckProxy.h (217103 => 217104)
--- branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionCheckProxy.h 2017-05-19 08:04:16 UTC (rev 217103)
+++ branches/safari-604.1.21-branch/Source/WebKit2/UIProcess/UserMediaPermissionCheckProxy.h 2017-05-19 08:27:18 UTC (rev 217104)
@@ -27,6 +27,7 @@
#define UserMediaPermissionCheckProxy_h
#include "
[webkit-changes] [217103] branches/safari-604.1.21-branch
Title: [217103] branches/safari-604.1.21-branch
Revision 217103
Author jmarc...@apple.com
Date 2017-05-19 01:04:16 -0700 (Fri, 19 May 2017)
Log Message
Cherry-pick r217074. rdar://problem/32282945
Modified Paths
branches/safari-604.1.21-branch/Source/WebCore/ChangeLog
branches/safari-604.1.21-branch/Source/WebCore/page/DragController.cpp
branches/safari-604.1.21-branch/Tools/ChangeLog
branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
Diff
Modified: branches/safari-604.1.21-branch/Source/WebCore/ChangeLog (217102 => 217103)
--- branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 06:58:05 UTC (rev 217102)
+++ branches/safari-604.1.21-branch/Source/WebCore/ChangeLog 2017-05-19 08:04:16 UTC (rev 217103)
@@ -1,3 +1,23 @@
+2017-05-18 Jason Marcell
+
+Cherry-pick r217074. rdar://problem/32282945
+
+2017-05-18 Wenson Hsieh
+
+Selection around attachment elements should not persist when beginning a drag
+https://bugs.webkit.org/show_bug.cgi?id=172319
+
+
+Reviewed by Tim Horton.
+
+When beginning to drag an attachment element, save and restore the visible selection when calling out to the
+injected bundle for additional data, and when creating the drag image.
+
+Augmented an existing API test: DataInteractionTests.AttachmentElementItemProviders.
+
+* page/DragController.cpp:
+(WebCore::DragController::startDrag):
+
2017-05-17 Jason Marcell
Cherry-pick r217022. rdar://problem/32258020
Modified: branches/safari-604.1.21-branch/Source/WebCore/page/DragController.cpp (217102 => 217103)
--- branches/safari-604.1.21-branch/Source/WebCore/page/DragController.cpp 2017-05-19 06:58:05 UTC (rev 217102)
+++ branches/safari-604.1.21-branch/Source/WebCore/page/DragController.cpp 2017-05-19 08:04:16 UTC (rev 217103)
@@ -1060,6 +1060,8 @@
#if ENABLE(ATTACHMENT_ELEMENT)
if (is(element) && m_dragSourceAction & DragSourceActionAttachment) {
+src.editor().setIgnoreSelectionChanges(true);
+auto previousSelection = src.selection().selection();
if (!dataTransfer.pasteboard().hasData()) {
selectElement(element);
if (!attachmentURL.isEmpty()) {
@@ -1088,6 +1090,8 @@
m_dragOffset = IntPoint(dragOrigin.x() - dragLoc.x(), dragOrigin.y() - dragLoc.y());
}
doSystemDrag(WTFMove(dragImage), dragLoc, dragOrigin, { }, dataTransfer, src, DragSourceActionAttachment);
+src.selection().setSelection(previousSelection);
+src.editor().setIgnoreSelectionChanges(false);
return true;
}
#endif
Modified: branches/safari-604.1.21-branch/Tools/ChangeLog (217102 => 217103)
--- branches/safari-604.1.21-branch/Tools/ChangeLog 2017-05-19 06:58:05 UTC (rev 217102)
+++ branches/safari-604.1.21-branch/Tools/ChangeLog 2017-05-19 08:04:16 UTC (rev 217103)
@@ -1,3 +1,20 @@
+2017-05-18 Jason Marcell
+
+Cherry-pick r217074. rdar://problem/32282945
+
+2017-05-18 Wenson Hsieh
+
+Selection around attachment elements should not persist when beginning a drag
+https://bugs.webkit.org/show_bug.cgi?id=172319
+
+
+Reviewed by Tim Horton.
+
+Tests that temporary selection around an attachment does not persist longer than it needs to.
+
+* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
+(TestWebKitAPI::TEST):
+
2017-05-17 Jason Marcell
Cherry-pick r217010. rdar://problem/32141505
Modified: branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm (217102 => 217103)
--- branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm 2017-05-19 06:58:05 UTC (rev 217102)
+++ branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm 2017-05-19 08:04:16 UTC (rev 217103)
@@ -588,6 +588,7 @@
[dataInteractionSimulator runFrom:CGPointMake(50, 50) to:CGPointMake(50, 400)];
EXPECT_WK_STREQ("hello", [injectedString UTF8String]);
+EXPECT_TRUE([webView stringByEvaluatingJavaScript:@"getSelection().isCollapsed"].boolValue);
}
TEST(DataInteractionTests, LargeImageToTargetDiv)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
