[webkit-changes] [217925] trunk
Title: [217925] trunk Revision 217925 Author carlo...@webkit.org Date 2017-06-07 23:48:22 -0700 (Wed, 07 Jun 2017) Log Message [WPE] Enable resource usage https://bugs.webkit.org/show_bug.cgi?id=173054 Reviewed by Žan Doberšek. .: Add private option for resource usage enabled by default. * Source/cmake/OptionsWPE.cmake: Source/WebCore: Add resource usage linux files to the compilation. * PlatformWPE.cmake: Source/WebKit2: Enable/disable the resources overlay with CTRL + Shift + G. * UIProcess/API/wpe/WPEView.cpp: (WKWPE::m_compositingManagerProxy): Modified Paths trunk/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformWPE.cmake trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/wpe/WPEView.cpp trunk/Source/cmake/OptionsWPE.cmake Diff Modified: trunk/ChangeLog (217924 => 217925) --- trunk/ChangeLog 2017-06-08 06:46:21 UTC (rev 217924) +++ trunk/ChangeLog 2017-06-08 06:48:22 UTC (rev 217925) @@ -1,5 +1,16 @@ 2017-06-07 Carlos Garcia Campos +[WPE] Enable resource usage +https://bugs.webkit.org/show_bug.cgi?id=173054 + +Reviewed by Žan Doberšek. + +Add private option for resource usage enabled by default. + +* Source/cmake/OptionsWPE.cmake: + +2017-06-07 Carlos Garcia Campos + Remove legacy INSPECTOR_SERVER implementation https://bugs.webkit.org/show_bug.cgi?id=172966 Modified: trunk/Source/WebCore/ChangeLog (217924 => 217925) --- trunk/Source/WebCore/ChangeLog 2017-06-08 06:46:21 UTC (rev 217924) +++ trunk/Source/WebCore/ChangeLog 2017-06-08 06:48:22 UTC (rev 217925) @@ -1,3 +1,14 @@ +2017-06-07 Carlos Garcia Campos + +[WPE] Enable resource usage +https://bugs.webkit.org/show_bug.cgi?id=173054 + +Reviewed by Žan Doberšek. + +Add resource usage linux files to the compilation. + +* PlatformWPE.cmake: + 2017-06-07 Jer Noble [Web Audio] createScriptProcessor throws IndexSizeError for valid arguments Modified: trunk/Source/WebCore/PlatformWPE.cmake (217924 => 217925) --- trunk/Source/WebCore/PlatformWPE.cmake 2017-06-08 06:46:21 UTC (rev 217924) +++ trunk/Source/WebCore/PlatformWPE.cmake 2017-06-08 06:48:22 UTC (rev 217925) @@ -51,6 +51,9 @@ loader/soup/CachedRawResourceSoup.cpp loader/soup/SubresourceLoaderSoup.cpp +page/linux/ResourceUsageOverlayLinux.cpp +page/linux/ResourceUsageThreadLinux.cpp + page/scrolling/ScrollingStateStickyNode.cpp page/scrolling/ScrollingThread.cpp page/scrolling/ScrollingTreeNode.cpp Modified: trunk/Source/WebKit2/ChangeLog (217924 => 217925) --- trunk/Source/WebKit2/ChangeLog 2017-06-08 06:46:21 UTC (rev 217924) +++ trunk/Source/WebKit2/ChangeLog 2017-06-08 06:48:22 UTC (rev 217925) @@ -1,5 +1,17 @@ 2017-06-07 Carlos Garcia Campos +[WPE] Enable resource usage +https://bugs.webkit.org/show_bug.cgi?id=173054 + +Reviewed by Žan Doberšek. + +Enable/disable the resources overlay with CTRL + Shift + G. + +* UIProcess/API/wpe/WPEView.cpp: +(WKWPE::m_compositingManagerProxy): + +2017-06-07 Carlos Garcia Campos + Remove legacy INSPECTOR_SERVER implementation https://bugs.webkit.org/show_bug.cgi?id=172966 Modified: trunk/Source/WebKit2/UIProcess/API/wpe/WPEView.cpp (217924 => 217925) --- trunk/Source/WebKit2/UIProcess/API/wpe/WPEView.cpp 2017-06-08 06:46:21 UTC (rev 217924) +++ trunk/Source/WebKit2/UIProcess/API/wpe/WPEView.cpp 2017-06-08 06:48:22 UTC (rev 217925) @@ -89,6 +89,14 @@ [](void* data, struct wpe_input_keyboard_event* event) { auto& view = *reinterpret_cast(data); +if (event->pressed +&& event->modifiers & wpe_input_keyboard_modifier_control +&& event->modifiers & wpe_input_keyboard_modifier_shift +&& event->keyCode == 'G') { +auto& preferences = view.page().preferences(); +preferences.setResourceUsageOverlayVisible(!preferences.resourceUsageOverlayVisible()); +return; +} view.page().handleKeyboardEvent(WebKit::NativeWebKeyboardEvent(event)); }, // handle_pointer_event Modified: trunk/Source/cmake/OptionsWPE.cmake (217924 => 217925) --- trunk/Source/cmake/OptionsWPE.cmake 2017-06-08 06:46:21 UTC (rev 217924) +++ trunk/Source/cmake/OptionsWPE.cmake 2017-06-08 06:48:22 UTC (rev 217925) @@ -36,6 +36,12 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_TIMING PUBLIC ON) +if (CMAKE_SYSTEM_NAME MATCHES "Linux") +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON) +else () +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF) +endif () + WEBKIT_OPTION_DEFINE(USE_GSTREAMER_GL "Whether to enable support for GStreamer GL" PRIVATE OFF) WEBKIT_OPTION_END()
[webkit-changes] [217924] trunk
Title: [217924] trunk Revision 217924 Author carlo...@webkit.org Date 2017-06-07 23:46:21 -0700 (Wed, 07 Jun 2017) Log Message Remove legacy INSPECTOR_SERVER implementation https://bugs.webkit.org/show_bug.cgi?id=172966 Reviewed by Žan Doberšek. .: * Source/PlatformWin.cmake: Source/WebInspectorUI: Remove InspectorFrontendHostStub and thr web sockets initialization. * UserInterface/Base/InspectorFrontendHostStub.js: Removed. * UserInterface/Base/Main.js: (WebInspector.loaded): * UserInterface/Main.html: * UserInterface/Test.html: * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters: Source/WebKit2: * CMakeLists.txt: * Platform/Logging.h: * PlatformWPE.cmake: * UIProcess/InspectorServer/HTTPRequest.cpp: Removed. * UIProcess/InspectorServer/HTTPRequest.h: Removed. * UIProcess/InspectorServer/WebInspectorServer.cpp: Removed. * UIProcess/InspectorServer/WebInspectorServer.h: Removed. * UIProcess/InspectorServer/WebSocketServer.cpp: Removed. * UIProcess/InspectorServer/WebSocketServer.h: Removed. * UIProcess/InspectorServer/WebSocketServerClient.h: Removed. * UIProcess/InspectorServer/WebSocketServerConnection.cpp: Removed. * UIProcess/InspectorServer/WebSocketServerConnection.h: Removed. * UIProcess/InspectorServer/front-end/inspectorPageIndex.html: Removed. * UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp: Removed. * UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::invalidate): * UIProcess/WebInspectorProxy.h: * UIProcess/WebInspectorProxy.messages.in: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::preferencesDidChange): * UIProcess/wpe/WebProcessPoolWPE.cpp: * WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::sendMessageToFrontend): * WebProcess/WebPage/WebInspector.h: * WebProcess/WebPage/WebInspector.messages.in: Modified Paths trunk/ChangeLog trunk/Source/PlatformWin.cmake trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Base/Main.js trunk/Source/WebInspectorUI/UserInterface/Main.html trunk/Source/WebInspectorUI/UserInterface/Test.html trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.vcxproj trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters trunk/Source/WebKit2/CMakeLists.txt trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Platform/Logging.h trunk/Source/WebKit2/PlatformWPE.cmake trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/wpe/WebProcessPoolWPE.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.messages.in Removed Paths trunk/Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js trunk/Source/WebKit2/UIProcess/InspectorServer/ Diff Modified: trunk/ChangeLog (217923 => 217924) --- trunk/ChangeLog 2017-06-08 05:02:48 UTC (rev 217923) +++ trunk/ChangeLog 2017-06-08 06:46:21 UTC (rev 217924) @@ -1,3 +1,12 @@ +2017-06-07 Carlos Garcia Campos + +Remove legacy INSPECTOR_SERVER implementation +https://bugs.webkit.org/show_bug.cgi?id=172966 + +Reviewed by Žan Doberšek. + +* Source/PlatformWin.cmake: + 2017-06-07 Loïc Yhuel [CMake] Only force response files for Ninja with CMake < 3.2 on Linux Modified: trunk/Source/PlatformWin.cmake (217923 => 217924) --- trunk/Source/PlatformWin.cmake 2017-06-08 05:02:48 UTC (rev 217923) +++ trunk/Source/PlatformWin.cmake 2017-06-08 06:46:21 UTC (rev 217924) @@ -6,7 +6,6 @@ COMMAND ${CMAKE_COMMAND} -E copy_directory ${WEBINSPECTORUI_DIR}/UserInterface ${WEB_INSPECTOR_DIR} COMMAND ${CMAKE_COMMAND} -E copy ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector/InspectorBackendCommands.js ${WEB_INSPECTOR_DIR}/Protocol COMMAND ${CMAKE_COMMAND} -E copy ${WEBINSPECTORUI_DIR}/Localizations/en.lproj/localizedStrings.js ${WEB_INSPECTOR_DIR} -COMMAND ${CMAKE_COMMAND} -E copy ${WEBKIT2_DIR}/UIProcess/InspectorServer/front-end/inspectorPageIndex.html ${WEB_INSPECTOR_DIR} DEPENDS _javascript_Core WebCore WORKING_DIRECTORY ${CMAKE_BINARY_DIR} ) Modified: trunk/Source/WebInspectorUI/ChangeLog (217923 => 217924) --- trunk/Source/WebInspectorUI/ChangeLog 2017-06-08 05:02:48 UTC (rev 217923) +++ trunk/Source/WebInspectorUI/ChangeLog 2017-06-08 06:46:21 UTC (rev 217924) @@ -1,3 +1,20 @@ +2017-06-07 Carlos Garcia Campos + +Remove legacy INSPECTOR_SERVER implementation +https://bugs.webkit.org/show_bug.cgi?id=172966 + +Reviewed by Žan Doberšek. + +Remove InspectorFrontendHostStub and thr web sockets initialization. + +* UserInterface/Base/InspectorFrontendHostStub.js: Removed. +* UserInterface/Base/Main.js:
[webkit-changes] [217923] trunk
Title: [217923] trunk Revision 217923 Author m...@apple.com Date 2017-06-07 22:02:48 -0700 (Wed, 07 Jun 2017) Log Message Source/WebKit2: [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin-1 paths https://bugs.webkit.org/show_bug.cgi?id=173086 Reviewed by Andy Estes. We were incorrectly passing the fileSystemRepresentation of an NSURL into the WTF::String constructor that expects a Latin-1 string. However, in general, fileSystemRepresentation is not Latin-1. * UIProcess/API/APIProcessPoolConfiguration.h: Changed m_additionalReadAccessAllowedPaths from a Vector into a Vector. * UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm: (-[_WKProcessPoolConfiguration additionalReadAccessAllowedURLs]): Updated for the change. (-[_WKProcessPoolConfiguration setAdditionalReadAccessAllowedURLs:]): Ditto. * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::resolvePathsForSandboxExtensions): Ditto. Tools: [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths https://bugs.webkit.org/show_bug.cgi?id=173086 Reviewed by Andy Estes. * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: (TEST): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (217922 => 217923) --- trunk/Source/WebKit2/ChangeLog 2017-06-08 04:46:34 UTC (rev 217922) +++ trunk/Source/WebKit2/ChangeLog 2017-06-08 05:02:48 UTC (rev 217923) @@ -1,3 +1,24 @@ +2017-06-07 Dan Bernstein + +[Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin-1 paths +https://bugs.webkit.org/show_bug.cgi?id=173086 + +Reviewed by Andy Estes. + +We were incorrectly passing the fileSystemRepresentation of an NSURL into the WTF::String +constructor that expects a Latin-1 string. However, in general, fileSystemRepresentation is +not Latin-1. + +* UIProcess/API/APIProcessPoolConfiguration.h: Changed m_additionalReadAccessAllowedPaths + from a Vector into a Vector. + +* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm: +(-[_WKProcessPoolConfiguration additionalReadAccessAllowedURLs]): Updated for the change. +(-[_WKProcessPoolConfiguration setAdditionalReadAccessAllowedURLs:]): Ditto. + +* UIProcess/WebProcessPool.cpp: +(WebKit::WebProcessPool::resolvePathsForSandboxExtensions): Ditto. + 2017-06-07 Ryosuke Niwa Crash inside WebKit::PluginView::getAuthenticationInfo Modified: trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h (217922 => 217923) --- trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h 2017-06-08 04:46:34 UTC (rev 217922) +++ trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h 2017-06-08 05:02:48 UTC (rev 217923) @@ -31,6 +31,7 @@ #include "WebsiteDataStore.h" #include #include +#include #include namespace API { @@ -99,8 +100,8 @@ const Vector& alwaysRevalidatedURLSchemes() { return m_alwaysRevalidatedURLSchemes; } void setAlwaysRevalidatedURLSchemes(Vector&& alwaysRevalidatedURLSchemes) { m_alwaysRevalidatedURLSchemes = WTFMove(alwaysRevalidatedURLSchemes); } -const Vector& additionalReadAccessAllowedPaths() { return m_additionalReadAccessAllowedPaths; } -void setAdditionalReadAccessAllowedPaths(Vector&& additionalReadAccessAllowedPaths) { m_additionalReadAccessAllowedPaths = additionalReadAccessAllowedPaths; } +const Vector& additionalReadAccessAllowedPaths() { return m_additionalReadAccessAllowedPaths; } +void setAdditionalReadAccessAllowedPaths(Vector&& additionalReadAccessAllowedPaths) { m_additionalReadAccessAllowedPaths = additionalReadAccessAllowedPaths; } bool fullySynchronousModeIsAllowedForTesting() const { return m_fullySynchronousModeIsAllowedForTesting; } void setFullySynchronousModeIsAllowedForTesting(bool allowed) { m_fullySynchronousModeIsAllowedForTesting = allowed; } @@ -158,7 +159,7 @@ WTF::String m_javaScriptConfigurationDirectory; Vector m_cachePartitionedURLSchemes; Vector m_alwaysRevalidatedURLSchemes; -Vector m_additionalReadAccessAllowedPaths; +Vector m_additionalReadAccessAllowedPaths; bool m_fullySynchronousModeIsAllowedForTesting { false }; bool m_ignoreSynchronousMessagingTimeoutsForTesting { false }; Vector m_overrideLanguages; Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm (217922 => 217923) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm 2017-06-08 04:46:34 UTC (rev 217922) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm 2017-06-08 05:02:48 UTC (rev 217923) @@ -110,7 +110,7 @@
[webkit-changes] [217922] trunk
Title: [217922] trunk Revision 217922 Author a...@apple.com Date 2017-06-07 21:46:34 -0700 (Wed, 07 Jun 2017) Log Message Add High Sierra support to WebKit tools https://bugs.webkit.org/show_bug.cgi?id=173080 Rubber-stamped by Daniel Bates. Tools: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/highsie...@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added dashboard support. * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Trigger the right build queues on check-in. * Scripts/webkitpy/common/system/platforminfo.py: * Scripts/webkitpy/common/system/platforminfo_unittest.py: * Scripts/webkitpy/layout_tests/models/test_expectations.py: * Scripts/webkitpy/port/mac.py: * Scripts/webkitpy/port/mac_unittest.py: * TestResultServer/static-dashboards/flakiness_dashboard.js: Added cases for Sierra, and updated tests for new baseline search paths. LayoutTests: * platform/mac-sierra: Added an empty directory to avoid breaking scripts. Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py trunk/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py trunk/Tools/Scripts/webkitpy/port/mac.py trunk/Tools/Scripts/webkitpy/port/mac_unittest.py trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js Added Paths trunk/LayoutTests/platform/mac-sierra/ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/highsie...@2x.png Diff Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png (Binary files differ) Index: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png === --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png 2017-06-08 04:43:51 UTC (rev 217921) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png 2017-06-08 04:46:34 UTC (rev 217922) Property changes on: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png ___ Added: svn:mime-type +image/png \ No newline at end of property Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/highsie...@2x.png (Binary files differ) Index: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/highsie...@2x.png === --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/highsie...@2x.png 2017-06-08 04:43:51 UTC (rev 217921) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/highsie...@2x.png 2017-06-08 04:46:34 UTC (rev 217922) Property changes on: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/highsie...@2x.png ___ Added: svn:mime-type +image/png \ No newline at end of property Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js (217921 => 217922) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js 2017-06-08 04:43:51 UTC (rev 217921) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js 2017-06-08 04:46:34 UTC (rev 217922) @@ -25,6 +25,7 @@ Dashboard = { Platform: { +macOSHighSierra: { name: "macos-highsierra", readableName: "macOS High Sierra", order: 7 }, macOSSierra: { name: "macos-sierra", readableName: "macOS Sierra", order: 8 }, MacOSXElCapitan: { name: "mac-os-x-elcapitan", readableName: "OS X El Capitan", order: 9 }, iOS10Simulator: { name: "ios-simulator-10", readableName: "iOS 10 Simulator", order: 30 }, Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (217921 => 217922) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2
[webkit-changes] [217921] trunk
Title: [217921] trunk Revision 217921 Author jfbast...@apple.com Date 2017-06-07 21:43:51 -0700 (Wed, 07 Jun 2017) Log Message WebAssembly: test imports and exports with 16-bit characters https://bugs.webkit.org/show_bug.cgi?id=165977 Reviewed by Saam Barati. JSTests: The output for import failure was improved, so many tests need to be updated here. Only one has new tests as noted below. * wasm/function-tests/memory-import-and-grow.js: * wasm/js-api/Instance.imports.exports.unicode.js: Added. Main new test. (idxModule): * wasm/js-api/global-error.js: (new.Number): (assert.throws): * wasm/js-api/table.js: (assert.throws): (new.WebAssembly.Table): * wasm/js-api/test_memory.js: (test): * wasm/js-api/wasm-to-wasm-bad-signature.js: (BadSignatureDropStartParams.): (BadSignatureDropStartParams): (BadSignatureDropEndParams.): (BadSignatureSwapParam.): (BadSignatureRet.): * wasm/js-api/web-assembly-instantiate.js: (assert.asyncTest.async.test): (assert.asyncTest): * wasm/js-api/wrapper-function.js: (return.new.WebAssembly.Module): Source/_javascript_Core: Add the missing UTF-8 conversions. Improve import failure error messages, otherwise it's hard to figure out which import is wrong. * wasm/js/JSWebAssemblyInstance.cpp: (JSC::JSWebAssemblyInstance::create): * wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::finishCreation): (JSC::WebAssemblyModuleRecord::link): Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/wasm/function-tests/memory-import-and-grow.js trunk/JSTests/wasm/js-api/global-error.js trunk/JSTests/wasm/js-api/table.js trunk/JSTests/wasm/js-api/test_memory.js trunk/JSTests/wasm/js-api/wasm-to-wasm-bad-signature.js trunk/JSTests/wasm/js-api/web-assembly-instantiate.js trunk/JSTests/wasm/js-api/wrapper-function.js trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyInstance.cpp trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp Added Paths trunk/JSTests/wasm/js-api/Instance.imports.exports.unicode.js Diff Modified: trunk/JSTests/ChangeLog (217920 => 217921) --- trunk/JSTests/ChangeLog 2017-06-08 04:42:46 UTC (rev 217920) +++ trunk/JSTests/ChangeLog 2017-06-08 04:43:51 UTC (rev 217921) @@ -1,3 +1,37 @@ +2017-06-07 JF Bastien + +WebAssembly: test imports and exports with 16-bit characters +https://bugs.webkit.org/show_bug.cgi?id=165977 + + +Reviewed by Saam Barati. + +The output for import failure was improved, so many tests need to +be updated here. Only one has new tests as noted below. + +* wasm/function-tests/memory-import-and-grow.js: +* wasm/js-api/Instance.imports.exports.unicode.js: Added. Main new test. +(idxModule): +* wasm/js-api/global-error.js: +(new.Number): +(assert.throws): +* wasm/js-api/table.js: +(assert.throws): +(new.WebAssembly.Table): +* wasm/js-api/test_memory.js: +(test): +* wasm/js-api/wasm-to-wasm-bad-signature.js: +(BadSignatureDropStartParams.): +(BadSignatureDropStartParams): +(BadSignatureDropEndParams.): +(BadSignatureSwapParam.): +(BadSignatureRet.): +* wasm/js-api/web-assembly-instantiate.js: +(assert.asyncTest.async.test): +(assert.asyncTest): +* wasm/js-api/wrapper-function.js: +(return.new.WebAssembly.Module): + 2017-06-07 Mark Lam Restrict the regress-173035.js test to only run on Darwin x86-64. Modified: trunk/JSTests/wasm/function-tests/memory-import-and-grow.js (217920 => 217921) --- trunk/JSTests/wasm/function-tests/memory-import-and-grow.js 2017-06-08 04:42:46 UTC (rev 217920) +++ trunk/JSTests/wasm/function-tests/memory-import-and-grow.js 2017-06-08 04:43:51 UTC (rev 217921) @@ -121,11 +121,11 @@ test({ initial: 2, maximum: 4 }, { initial: 2 }, 0, u, 2); // Disallowed: imported initial is lesser than declared. -assert.throws(() => test({ initial: 1, maximum: 4 }, { initial: 2, maximum: 4 }, u, u, 2), WebAssembly.LinkError, `Memory import provided an 'initial' that is smaller than the module's declared 'initial' import memory size`); -assert.throws(() => test({ initial: 0, maximum: 4 }, { initial: 2, maximum: 4 }, u, u, 2), WebAssembly.LinkError, `Memory import provided an 'initial' that is smaller than the module's declared 'initial' import memory size`); +assert.throws(() => test({ initial: 1, maximum: 4 }, { initial: 2, maximum: 4 }, u, u, 2), WebAssembly.LinkError, `Memory import imp:memory provided an 'initial' that is smaller than the module's declared 'initial' import memory size`); +assert.throws(() => test({ initial: 0, maximum: 4 }, { initial: 2, maximum: 4 }, u, u, 2), WebAssembly.LinkError, `Memory import imp:memory provided an 'initial' that is smaller than the module's declared 'initial' import memory size`); // Disallowed: imported maximum is greater than declared. -assert.throws(() => test({ initial
[webkit-changes] [217920] trunk
Title: [217920] trunk Revision 217920 Author a...@apple.com Date 2017-06-07 21:42:46 -0700 (Wed, 07 Jun 2017) Log Message Add High Sierra support to WebKit tools https://bugs.webkit.org/show_bug.cgi?id=173080 Rubber-stamped by Daniel Bates. Tools: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/highsie...@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added dashboard support. * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Trigger the right build queues on check-in. * Scripts/webkitpy/common/system/platforminfo.py: * Scripts/webkitpy/common/system/platforminfo_unittest.py: * Scripts/webkitpy/layout_tests/models/test_expectations.py: * Scripts/webkitpy/port/mac.py: * Scripts/webkitpy/port/mac_unittest.py: * TestResultServer/static-dashboards/flakiness_dashboard.js: Added cases for Sierra, and updated tests for new baseline search paths. LayoutTests: * platform/mac-sierra: Added an empty directory to avoid breaking scripts. Modified Paths trunk/LayoutTests/ChangeLog trunk/Tools/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (217919 => 217920) --- trunk/LayoutTests/ChangeLog 2017-06-08 04:31:31 UTC (rev 217919) +++ trunk/LayoutTests/ChangeLog 2017-06-08 04:42:46 UTC (rev 217920) @@ -1,3 +1,12 @@ +2017-06-07 Alexey Proskuryakov + +Add High Sierra support to WebKit tools +https://bugs.webkit.org/show_bug.cgi?id=173080 + +Rubber-stamped by Daniel Bates. + +* platform/mac-sierra: Added an empty directory to avoid breaking scripts. + 2017-06-07 Jer Noble [Web Audio] createScriptProcessor throws IndexSizeError for valid arguments Modified: trunk/Tools/ChangeLog (217919 => 217920) --- trunk/Tools/ChangeLog 2017-06-08 04:31:31 UTC (rev 217919) +++ trunk/Tools/ChangeLog 2017-06-08 04:42:46 UTC (rev 217920) @@ -1,3 +1,28 @@ +2017-06-07 Alexey Proskuryakov + +Add High Sierra support to WebKit tools +https://bugs.webkit.org/show_bug.cgi?id=173080 + +Rubber-stamped by Daniel Bates. + +* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added. +* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/highsie...@2x.png: Added. +* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: +* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: +Added dashboard support. + +* BuildSlaveSupport/build.webkit.org-config/wkbuild.py: +* BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: +Trigger the right build queues on check-in. + +* Scripts/webkitpy/common/system/platforminfo.py: +* Scripts/webkitpy/common/system/platforminfo_unittest.py: +* Scripts/webkitpy/layout_tests/models/test_expectations.py: +* Scripts/webkitpy/port/mac.py: +* Scripts/webkitpy/port/mac_unittest.py: +* TestResultServer/static-dashboards/flakiness_dashboard.js: +Added cases for Sierra, and updated tests for new baseline search paths. + 2017-06-07 Ryan Haddad Unreviewed, rolling out r217902. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] Delivery Status Notification (Delay)
** Delivery incomplete ** There was a temporary problem delivering your message to curtiskwo...@gmail.com. Gmail will retry for 47 more hours. You'll be notified if the delivery fails permanently. Reporting-MTA: dns; googlemail.com Received-From-MTA: dns; FWD-737R3YSMGFA4YCMAC4SVAODAFMASYA6QDTSAGWAAIAG3I3EGMA6RI2JSWAPOAE5GADMCQJTAGFBCEALZFQRGEIAAEA==@opayq.com Arrival-Date: Tue, 06 Jun 2017 21:12:47 -0700 (PDT) X-Original-Message-ID: Final-Recipient: rfc822; curtiskwong9@gmail.com Action: delayed Status: 4.0.0 Last-Attempt-Date: Wed, 07 Jun 2017 21:38:22 -0700 (PDT) Will-Retry-Until: Fri, 09 Jun 2017 21:12:47 -0700 (PDT) webkit-changes Digest, Vol 145, Issue 89 Description: Message attachment ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [217919] trunk
Title: [217919] trunk Revision 217919 Author jer.no...@apple.com Date 2017-06-07 21:31:31 -0700 (Wed, 07 Jun 2017) Log Message [Web Audio] createScriptProcessor throws IndexSizeError for valid arguments https://bugs.webkit.org/show_bug.cgi?id=173022 Reviewed by Sam Weinig. Source/WebCore: Updated test: webaudio/_javascript_audionode.html The Web Audio spec (, 06 June 2017) defines a default behavior when clients pass in a value of 0 for bufferSize to the createScriptProcessor() method. * Modules/webaudio/AudioContext.cpp: (WebCore::AudioContext::createScriptProcessor): * Modules/webaudio/AudioContext.idl: * Modules/webaudio/ScriptProcessorNode.cpp: (WebCore::ScriptProcessorNode::create): * Modules/webaudio/ScriptProcessorNode.h: LayoutTests: * webaudio/_javascript_audionode-expected.txt: * webaudio/_javascript_audionode.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/webaudio/_javascript_audionode-expected.txt trunk/LayoutTests/webaudio/_javascript_audionode.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp trunk/Source/WebCore/Modules/webaudio/AudioContext.idl trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h Diff Modified: trunk/LayoutTests/ChangeLog (217918 => 217919) --- trunk/LayoutTests/ChangeLog 2017-06-08 04:05:43 UTC (rev 217918) +++ trunk/LayoutTests/ChangeLog 2017-06-08 04:31:31 UTC (rev 217919) @@ -1,3 +1,13 @@ +2017-06-07 Jer Noble + +[Web Audio] createScriptProcessor throws IndexSizeError for valid arguments +https://bugs.webkit.org/show_bug.cgi?id=173022 + +Reviewed by Sam Weinig. + +* webaudio/_javascript_audionode-expected.txt: +* webaudio/_javascript_audionode.html: + 2017-06-07 Chris Dumez CSSStyleRule.style / CSSPageRule.style / CSSKeyframeRule.style should be settable Modified: trunk/LayoutTests/webaudio/_javascript_audionode-expected.txt (217918 => 217919) --- trunk/LayoutTests/webaudio/_javascript_audionode-expected.txt 2017-06-08 04:05:43 UTC (rev 217918) +++ trunk/LayoutTests/webaudio/_javascript_audionode-expected.txt 2017-06-08 04:31:31 UTC (rev 217919) @@ -8,6 +8,7 @@ PASS Successfully created ScriptProcessorNode with numberOfInputChannels = 0 and numberOfOutputChannels = 1. PASS Successfully created ScriptProcessorNode with numberOfInputChannels = 0 and numberOfOutputChannels = 2. PASS Exception was thrown for illegal bufferSize. +PASS Successfully created ScriptProcessorNode with bufferSize = 0. PASS Successfully created ScriptProcessorNode with bufferSize = 256. PASS Successfully created ScriptProcessorNode with bufferSize = 512. PASS Successfully created ScriptProcessorNode with bufferSize = 1024. Modified: trunk/LayoutTests/webaudio/_javascript_audionode.html (217918 => 217919) --- trunk/LayoutTests/webaudio/_javascript_audionode.html 2017-06-08 04:05:43 UTC (rev 217918) +++ trunk/LayoutTests/webaudio/_javascript_audionode.html 2017-06-08 04:31:31 UTC (rev 217919) @@ -123,6 +123,7 @@ testPassed("Exception was thrown for illegal bufferSize."); } +doBufferSizeTest(0); doBufferSizeTest(256); doBufferSizeTest(512); doBufferSizeTest(1024); Modified: trunk/Source/WebCore/ChangeLog (217918 => 217919) --- trunk/Source/WebCore/ChangeLog 2017-06-08 04:05:43 UTC (rev 217918) +++ trunk/Source/WebCore/ChangeLog 2017-06-08 04:31:31 UTC (rev 217919) @@ -1,3 +1,22 @@ +2017-06-07 Jer Noble + +[Web Audio] createScriptProcessor throws IndexSizeError for valid arguments +https://bugs.webkit.org/show_bug.cgi?id=173022 + +Reviewed by Sam Weinig. + +Updated test: webaudio/_javascript_audionode.html + +The Web Audio spec (, 06 June 2017) defines a default behavior when +clients pass in a value of 0 for bufferSize to the createScriptProcessor() method. + +* Modules/webaudio/AudioContext.cpp: +(WebCore::AudioContext::createScriptProcessor): +* Modules/webaudio/AudioContext.idl: +* Modules/webaudio/ScriptProcessorNode.cpp: +(WebCore::ScriptProcessorNode::create): +* Modules/webaudio/ScriptProcessorNode.h: + 2017-06-07 Chris Dumez CSSStyleRule.style / CSSPageRule.style / CSSKeyframeRule.style should be settable Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp (217918 => 217919) --- trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp 2017-06-08 04:05:43 UTC (rev 217918) +++ trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp 2017-06-08 04:31:31 UTC (rev 217919) @@ -37,6 +37,7 @@ #include "AudioListener.h" #include "AudioNodeInput.h" #include "AudioNodeOutput.h" +#include "AudioSession.h" #include "BiquadFilterNode.h" #include "ChannelMergerNode.h" #include "ChannelSplitterNode.h" @@ -488,13 +489,58 @@ { ASSERT(isMainThread()); lazyInitialize(); -auto node = ScriptProcessorNode::create(
[webkit-changes] [217918] trunk/Source/bmalloc
Title: [217918] trunk/Source/bmalloc Revision 217918 Author gga...@apple.com Date 2017-06-07 21:05:43 -0700 (Wed, 07 Jun 2017) Log Message bmalloc: memory APIs don't need to be heap members https://bugs.webkit.org/show_bug.cgi?id=173076 Reviewed by Sam Weinig. Asking the OS about memory use is unrelated to the state of bmalloc's heap, so it's a better separation of concerns if related code is not part of the heap. * bmalloc/AvailableMemory.cpp: (bmalloc::memoryStatus): * bmalloc/AvailableMemory.h: (bmalloc::MemoryStatus::MemoryStatus): (bmalloc::isUnderMemoryPressure): (bmalloc::memoryFootprint): (bmalloc::percentAvailableMemoryInUse): * bmalloc/Heap.cpp: (bmalloc::Heap::Heap): (bmalloc::Heap::updateMemoryInUseParameters): Deleted. * bmalloc/Heap.h: (bmalloc::Heap::isUnderMemoryPressure): Deleted. (bmalloc::Heap::memoryFootprint): Deleted. (bmalloc::Heap::percentAvailableMemoryInUse): Deleted. Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp trunk/Source/bmalloc/bmalloc/AvailableMemory.h trunk/Source/bmalloc/bmalloc/Heap.cpp trunk/Source/bmalloc/bmalloc/Heap.h trunk/Source/bmalloc/bmalloc/bmalloc.h Diff Modified: trunk/Source/bmalloc/ChangeLog (217917 => 217918) --- trunk/Source/bmalloc/ChangeLog 2017-06-08 03:32:21 UTC (rev 217917) +++ trunk/Source/bmalloc/ChangeLog 2017-06-08 04:05:43 UTC (rev 217918) @@ -1,3 +1,29 @@ +2017-06-07 Geoffrey Garen + +bmalloc: memory APIs don't need to be heap members +https://bugs.webkit.org/show_bug.cgi?id=173076 + +Reviewed by Sam Weinig. + +Asking the OS about memory use is unrelated to the state of bmalloc's +heap, so it's a better separation of concerns if related code is not +part of the heap. + +* bmalloc/AvailableMemory.cpp: +(bmalloc::memoryStatus): +* bmalloc/AvailableMemory.h: +(bmalloc::MemoryStatus::MemoryStatus): +(bmalloc::isUnderMemoryPressure): +(bmalloc::memoryFootprint): +(bmalloc::percentAvailableMemoryInUse): +* bmalloc/Heap.cpp: +(bmalloc::Heap::Heap): +(bmalloc::Heap::updateMemoryInUseParameters): Deleted. +* bmalloc/Heap.h: +(bmalloc::Heap::isUnderMemoryPressure): Deleted. +(bmalloc::Heap::memoryFootprint): Deleted. +(bmalloc::Heap::percentAvailableMemoryInUse): Deleted. + 2017-06-06 Yusuke Suzuki struct does not accept initializer-form if member has initializers in GCC 4.9 Modified: trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp (217917 => 217918) --- trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp 2017-06-08 03:32:21 UTC (rev 217917) +++ trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp 2017-06-08 04:05:43 UTC (rev 217918) @@ -92,4 +92,21 @@ return availableMemory; } +#if BPLATFORM(IOS) +MemoryStatus memoryStatus() +{ +task_vm_info_data_t vmInfo; +mach_msg_type_number_t vmSize = TASK_VM_INFO_COUNT; + +size_t memoryFootprint = 0; +if (KERN_SUCCESS == task_info(mach_task_self(), TASK_VM_INFO, (task_info_t)(&vmInfo), &vmSize)) +memoryFootprint = static_cast(vmInfo.phys_footprint); + +double percentInUse = static_cast(memoryFootprint) / static_cast(availableMemory()); +double percentAvailableMemoryInUse = std::min(percentInUse, 1.0); + +return MemoryStatus(memoryFootprint, percentAvailableMemoryInUse); +} +#endif + } // namespace bmalloc Modified: trunk/Source/bmalloc/bmalloc/AvailableMemory.h (217917 => 217918) --- trunk/Source/bmalloc/bmalloc/AvailableMemory.h 2017-06-08 03:32:21 UTC (rev 217917) +++ trunk/Source/bmalloc/bmalloc/AvailableMemory.h 2017-06-08 04:05:43 UTC (rev 217918) @@ -32,5 +32,40 @@ size_t availableMemory(); +#if BPLATFORM(IOS) +struct MemoryStatus { +MemoryStatus(size_t memoryFootprint, double percentAvailableMemoryInUse) +: memoryFootprint(memoryFootprint) +, percentAvailableMemoryInUse(percentAvailableMemoryInUse) +{ +} + +size_t memoryFootprint; +double percentAvailableMemoryInUse; +}; + +MemoryStatus memoryStatus(); + +inline size_t memoryFootprint() +{ +auto memoryUse = memoryStatus(); +return memoryUse.memoryFootprint; } +inline double percentAvailableMemoryInUse() +{ +auto memoryUse = memoryStatus(); +return memoryUse.percentAvailableMemoryInUse; +} +#endif + +inline bool isUnderMemoryPressure() +{ +#if BPLATFORM(IOS) +return percentAvailableMemoryInUse() > memoryPressureThreshold; +#else +return false; +#endif +} + +} // namespace bmalloc Modified: trunk/Source/bmalloc/bmalloc/Heap.cpp (217917 => 217918) --- trunk/Source/bmalloc/bmalloc/Heap.cpp 2017-06-08 03:32:21 UTC (rev 217917) +++ trunk/Source/bmalloc/bmalloc/Heap.cpp 2017-06-08 04:05:43 UTC (rev 217918) @@ -25,9 +25,7 @@ #include "Heap.h" -#if BPLATFORM(IOS) #include "AvailableMemory.h" -#endif #include "BumpAllocator.h" #include "Chunk.h" #include "DebugHeap.h" @@ -36,15 +34,6 @@
[webkit-changes] [217917] trunk
Title: [217917] trunk Revision 217917 Author cdu...@apple.com Date 2017-06-07 20:32:21 -0700 (Wed, 07 Jun 2017) Log Message CSSStyleRule.style / CSSPageRule.style / CSSKeyframeRule.style should be settable https://bugs.webkit.org/show_bug.cgi?id=164537 Reviewed by Sam Weinig. LayoutTests/imported/w3c: * web-platform-tests/cssom/CSSKeyframeRule-expected.txt: * web-platform-tests/cssom/CSSKeyframeRule.html: * web-platform-tests/cssom/CSSStyleRule-expected.txt: * web-platform-tests/cssom/CSSStyleRule.html: Re-sync web-platform tests after: - https://github.com/w3c/web-platform-tests/pull/6181 - https://github.com/w3c/web-platform-tests/pull/6184 This extends test coverage. * web-platform-tests/cssom/interfaces-expected.txt: Rebaseline now that more checks are passing. Source/WebCore: CSSStyleRule.style / CSSPageRule.style / CSSKeyframeRule.style should be settable as per: - https://drafts.csswg.org/cssom/#the-cssstylerule-interface - https://drafts.csswg.org/cssom/#the-csspagerule-interface - https://drafts.csswg.org/css-animations/#interface-csskeyframerule Tests: http/wpt/cssom/CSSPageRule.html imported/w3c/web-platform-tests/cssom/CSSKeyframeRule.html imported/w3c/web-platform-tests/cssom/CSSStyleRule.html imported/w3c/web-platform-tests/cssom/interfaces.html * css/CSSKeyframeRule.idl: * css/CSSPageRule.idl: * css/CSSStyleRule.idl: LayoutTests: Add better test coverage for CSSPageRule. This test is being upstreamed via: - https://github.com/w3c/web-platform-tests/pull/6183 * http/wpt/cssom/CSSPageRule-expected.txt: Added. * http/wpt/cssom/CSSPageRule.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/CSSKeyframeRule-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/CSSKeyframeRule.html trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/CSSStyleRule-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/CSSStyleRule.html trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/interfaces-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSKeyframeRule.idl trunk/Source/WebCore/css/CSSPageRule.idl trunk/Source/WebCore/css/CSSStyleRule.idl Added Paths trunk/LayoutTests/http/wpt/cssom/ trunk/LayoutTests/http/wpt/cssom/CSSPageRule-expected.txt trunk/LayoutTests/http/wpt/cssom/CSSPageRule.html Diff Modified: trunk/LayoutTests/ChangeLog (217916 => 217917) --- trunk/LayoutTests/ChangeLog 2017-06-08 03:25:06 UTC (rev 217916) +++ trunk/LayoutTests/ChangeLog 2017-06-08 03:32:21 UTC (rev 217917) @@ -1,3 +1,17 @@ +2017-06-07 Chris Dumez + +CSSStyleRule.style / CSSPageRule.style / CSSKeyframeRule.style should be settable +https://bugs.webkit.org/show_bug.cgi?id=164537 + + +Reviewed by Sam Weinig. + +Add better test coverage for CSSPageRule. This test is being upstreamed via: +- https://github.com/w3c/web-platform-tests/pull/6183 + +* http/wpt/cssom/CSSPageRule-expected.txt: Added. +* http/wpt/cssom/CSSPageRule.html: Added. + 2017-06-07 Youenn Fablet RTCTrackEvent.track should be found in RTCTrackEvent.streams[0] Added: trunk/LayoutTests/http/wpt/cssom/CSSPageRule-expected.txt (0 => 217917) --- trunk/LayoutTests/http/wpt/cssom/CSSPageRule-expected.txt (rev 0) +++ trunk/LayoutTests/http/wpt/cssom/CSSPageRule-expected.txt 2017-06-08 03:32:21 UTC (rev 217917) @@ -0,0 +1,10 @@ + +PASS CSSRule and CSSPageRule types +PASS Existence of CSSRule attributes +PASS Writability of CSSRule attributes +PASS Values of CSSRule attributes +PASS Existence and type of CSSPageRule attributes +PASS Values of CSSPageRule attributes +PASS Mutability of CSSPageRule's style attribute +PASS CSSPageRule's style has [PutForwards] + Added: trunk/LayoutTests/http/wpt/cssom/CSSPageRule.html (0 => 217917) --- trunk/LayoutTests/http/wpt/cssom/CSSPageRule.html (rev 0) +++ trunk/LayoutTests/http/wpt/cssom/CSSPageRule.html 2017-06-08 03:32:21 UTC (rev 217917) @@ -0,0 +1,81 @@ + + + +CSSPageRule interface + + + +@page :left { +margin-left: 3cm; +margin-right: 4cm; +} + + + +